gdb/ChangeLog

   1 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * symtab.c (struct demangled_name_entry): Change demangled name
   4         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
   5         part of the struct anymore.
   6         (symbol_set_names): No longer obstack allocate + copy the demangled
   7         name, just store the allocated name from bfd.
   8
   9 2019-10-25  Tom Tromey  <tromey@adacore.com>
  10
  11         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
  12         (bsearch_cie_cmp, add_cie): Remove.
  13         (find_cie): Reimplement.
  14         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
  15         (dwarf2_build_frame_info): Update.
  16
  17 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
  18
  19         PR gdb/25126
  20         * symfile.c (reread_symbols): Call forget_cached_source_info to
  21         clear the stale source cache.
  22
  23 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
  24
  25         * configure: Regenerate.
  26         * configure.ac: Remove code that sets python_has_threads.
  27
  28 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
  29
  30         * config.in: Regenerate.
  31         * configure: Regenerate.
  32         * configure.ac: Remove the code that uses sed to get the python
  33         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
  34
  35 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
  36
  37         * python/py-progspace.c (pspy_block_for_pc): Return None for all
  38         error paths.
  39
  40 2019-10-23  Tom Tromey  <tom@tromey.com>
  41
  42         * arc-tdep.c: Remove ".." from include.
  43         * frv-tdep.c: Remove ".." from include.
  44         * lm32-tdep.c: Remove ".." from include.
  45         * microblaze-tdep.c: Remove ".." from include.
  46         * or1k-tdep.h: Remove ".." from include.
  47         * s12z-tdep.c: Remove ".." from include.
  48         * Makefile.in (OPCODES_CFLAGS): Add comment.
  49         (TOP_CFLAGS): New variable.
  50         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
  51
  52 2019-10-23  Tom Tromey  <tom@tromey.com>
  53
  54         * Makefile.in (READLINE_DIR): Update.
  55
  56 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  57
  58         * infcall.c (call_function_by_hand_dummy): Fix the function
  59         comment.  And extract out a code section into...
  60         (reserve_stack_space): ...this new function.
  61
  62 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  63
  64         * infcall.c (value_arg_coerce): Remove an unused parameter.
  65         (call_function_by_hand_dummy): Update the call to
  66         'value_arg_coerce'.
  67
  68 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  69
  70         * infcall.c (call_function_by_hand_dummy): Refactor.
  71
  72 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  73
  74         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
  75
  76 2019-10-23  Tom Tromey  <tom@tromey.com>
  77
  78         * configure: Rebuild.
  79         * configure.ac: Don't check for sigprocmask.
  80         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
  81
  82 2019-10-23  Tom Tromey  <tom@tromey.com>
  83
  84         * configure: Rebuild.
  85         * acinclude.m4: Use m4_include, not sinclude.
  86
  87 2019-10-23  Tom de Vries  <tdevries@suse.de>
  88
  89         PR breakpoints/24687
  90         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
  91
  92 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  93
  94         * symtab.c (struct demangled_name_entry) <language>: Change from
  95         bitfield to regular variable.
  96
  97 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  98
  99         * symtab.c (struct demangled_name_entry): Add a constructor.
 100         (free_demangled_name_entry): New function to call the destructor
 101         for demangled_name_entry.
 102         (create_demangled_names_hash): Pass free_demangled_name_entry to
 103         htab_create_alloc.
 104         (symbol_set_names): Call placement new for demangled_name_entry.
 105         * utils.c: No longer include xxhash.h here, now that fast_hash
 106         is inlined in the header.
 107         * utils.h: Instead, include it here.
 108
 109 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 110
 111         * Makefile.in: Link with libxxhash.
 112         * config.in: Regenerate.
 113         * configure: Regenerate.
 114         * configure.ac: Search for libxxhash.
 115         * utils.c (fast_hash): Use xxhash if present.
 116
 117 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 118
 119         * utils.h (fast_hash): New function.
 120         * symtab.c (hash_demangled_name_entry): Call new function
 121         fast_hash.
 122
 123 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 124
 125         * symtab.c (struct demangled_name_entry): Change type of mangled
 126         to gdb::string_view. Also adds a constructor that takes the
 127         mangled name.
 128         (hash_demangled_name_entry): Update.
 129         (eq_demangled_name_entry): Update.
 130         (free_demangled_name_entry): New function to call the destructor
 131         now that this is not a POD anymore.
 132         (create_demangled_names_hash): Pass free_demangled_name_entry to
 133         htab_create_alloc.
 134         (symbol_set_names): Update.
 135
 136 2019-10-21  Ali Tamur  <tamu@google.com>
 137
 138         * dwarf2read.c (dir_index): Change type.
 139         (file_name_index): Likewise.
 140         (line_header::include_dir_at): Change comment and implementation on
 141         whether it is DWARF 5.
 142         (line_header::is_valid_file_index): New function.
 143         (line_header::file_name_at): Change comment and implementation on
 144         whether it is DWARF 5.
 145         (line_header::file_names): Change to private field renamed as
 146         m_file_names and introduce a new accessor method.
 147         (line_header::file_names_size): New method.
 148         (line_header::include_dirs): Change to private field and rename as
 149         m_include_dirs.
 150         (dw2_get_file_names_reader): Define local var at a smaller scope and
 151         reflect API change.
 152         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 153         (process_structure_scope): Likewise.
 154         (line_header::add_include_dir): Change message and reflect renaming.
 155         (line_header::add_file_name): Likewise.
 156         (read_formatted_entries): Handle DW_FORM_data16.
 157         (dwarf_decode_line_header): Fix line header length calculation.
 158         (psymtab_include_file_name): Change comment and API.
 159         (lnp_state_machine::m_file): Update comment and reflect type change.
 160         (lnp_state_machine::record_line): Reflect type change.
 161         (dwarf_decode_lines): Reflect API change.
 162         (file_file_name): Likewise.
 163         (file_full_name): Likewise.
 164
 165 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 166
 167         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 168
 169 2019-10-21  Tom Tromey  <tom@tromey.com>
 170
 171         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 172
 173 2019-10-21  Tom Tromey  <tom@tromey.com>
 174
 175         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 176         NM_H.   Use AC_CONFIG_LINKS.
 177         * configure: Rebuild.
 178         * Makefile.in (NM_H): New variable.
 179         (generated_files): Add NM_H.  Remove gcore.
 180         (nm.h, stamp-nmh): New targets.
 181
 182 2019-10-20  Tom Tromey  <tom@tromey.com>
 183
 184         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 185         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 186         obsolete comment.
 187         (put_objfile_before): Now static.
 188
 189 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 190
 191         * gdbsupport/common-utils.h (startswith): Change return type to
 192         bool.
 193
 194 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 195
 196         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 197         * breakpoint.c (bp_locations_compare): Rename to...
 198         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 199         (update_global_location_list): Use std::sort instead of qsort.
 200         * buildsym.c (compare_line_numbers): Rename to...
 201         (lte_is_less_than): ...this, and change to std::sort semantics.
 202         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 203         instead of qsort.
 204         * disasm.c (compare_lines): Rename to...
 205         (line_is_less_than): ...this, and change to std::sort semantics.
 206         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 207         of qsort.
 208         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 209         (fde_is_less_than): ...this, and change to std::sort semantics.
 210         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 211         * mdebugread.c (compare_blocks):
 212         (block_is_less_than): ...this, and change to std::sort semantics.
 213         (sort_blocks): Call std::sort instead of qsort.
 214         * objfiles.c (qsort_cmp): Rename to...
 215         (sort_cmp): ...this, and change to std::sort semantics.
 216         (update_section_map): Call std::sort instead of qsort.
 217         * remote.c (compare_pnums): Remove.
 218         (map_regcache_remote_table): Call std::sort instead of qsort.
 219         * utils.c (compare_positive_ints): Remove.
 220         * utils.h (compare_positive_ints): Remove.
 221         * xcoffread.c (compare_lte): Remove.
 222         (arrange_linetable): Call std::sort instead of qsort.
 223
 224 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 225
 226         * symfile.c (init_entry_point_info): Fix typo.
 227         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 228
 229 2019-10-18  Tom de Vries  <tdevries@suse.de>
 230
 231         * aarch64-tdep.c: Fix typos in comments.
 232         * ada-lang.c: Same.
 233         * ada-tasks.c: Same.
 234         * alpha-tdep.c: Same.
 235         * alpha-tdep.h: Same.
 236         * amd64-nat.c: Same.
 237         * amd64-windows-tdep.c: Same.
 238         * arc-tdep.c: Same.
 239         * arc-tdep.h: Same.
 240         * arch-utils.c: Same.
 241         * arm-nbsd-tdep.c: Same.
 242         * arm-tdep.c: Same.
 243         * ax-gdb.c: Same.
 244         * blockframe.c: Same.
 245         * btrace.c: Same.
 246         * c-varobj.c: Same.
 247         * coff-pe-read.c: Same.
 248         * coffread.c: Same.
 249         * cris-tdep.c: Same.
 250         * darwin-nat.c: Same.
 251         * dbxread.c: Same.
 252         * dcache.c: Same.
 253         * disasm.c: Same.
 254         * dtrace-probe.c: Same.
 255         * dwarf-index-write.c: Same.
 256         * dwarf2-frame-tailcall.c: Same.
 257         * dwarf2-frame.c: Same.
 258         * dwarf2read.c: Same.
 259         * eval.c: Same.
 260         * exceptions.c: Same.
 261         * fbsd-tdep.c: Same.
 262         * findvar.c: Same.
 263         * frame.c: Same.
 264         * frv-tdep.c: Same.
 265         * gnu-v3-abi.c: Same.
 266         * go32-nat.c: Same.
 267         * h8300-tdep.c: Same.
 268         * hppa-tdep.c: Same.
 269         * i386-linux-tdep.c: Same.
 270         * i386-tdep.c: Same.
 271         * ia64-libunwind-tdep.c: Same.
 272         * ia64-tdep.c: Same.
 273         * infcmd.c: Same.
 274         * infrun.c: Same.
 275         * linespec.c: Same.
 276         * linux-nat.c: Same.
 277         * linux-thread-db.c: Same.
 278         * machoread.c: Same.
 279         * mdebugread.c: Same.
 280         * mep-tdep.c: Same.
 281         * mn10300-tdep.c: Same.
 282         * namespace.c: Same.
 283         * objfiles.c: Same.
 284         * opencl-lang.c: Same.
 285         * or1k-tdep.c: Same.
 286         * osabi.c: Same.
 287         * ppc-linux-nat.c: Same.
 288         * ppc-linux-tdep.c: Same.
 289         * ppc-sysv-tdep.c: Same.
 290         * printcmd.c: Same.
 291         * procfs.c: Same.
 292         * record-btrace.c: Same.
 293         * record-full.c: Same.
 294         * remote-fileio.c: Same.
 295         * remote.c: Same.
 296         * rs6000-tdep.c: Same.
 297         * s12z-tdep.c: Same.
 298         * score-tdep.c: Same.
 299         * ser-base.c: Same.
 300         * ser-go32.c: Same.
 301         * skip.c: Same.
 302         * sol-thread.c: Same.
 303         * solib-svr4.c: Same.
 304         * solib.c: Same.
 305         * source.c: Same.
 306         * sparc-nat.c: Same.
 307         * sparc-sol2-tdep.c: Same.
 308         * sparc-tdep.c: Same.
 309         * sparc64-tdep.c: Same.
 310         * stabsread.c: Same.
 311         * stack.c: Same.
 312         * symfile.c: Same.
 313         * symtab.c: Same.
 314         * target-descriptions.c: Same.
 315         * target-float.c: Same.
 316         * thread.c: Same.
 317         * utils.c: Same.
 318         * valops.c: Same.
 319         * valprint.c: Same.
 320         * value.c: Same.
 321         * varobj.c: Same.
 322         * windows-nat.c: Same.
 323         * xcoffread.c: Same.
 324         * xstormy16-tdep.c: Same.
 325         * xtensa-tdep.c: Same.
 326
 327 2019-10-17  Tom Tromey  <tromey@adacore.com>
 328
 329         * configure: Rebuild.
 330         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 331         in AC_CONFIG_FILES invocation.
 332         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 333         new-style config.status invocation.
 334
 335 2019-10-17  Tom de Vries  <tdevries@suse.de>
 336
 337         * arm-nbsd-nat.c: Fix typos in comments.
 338         * arm-tdep.c: Same.
 339         * darwin-nat-info.c: Same.
 340         * dwarf2read.c: Same.
 341         * elfread.c: Same.
 342         * event-top.c: Same.
 343         * findvar.c: Same.
 344         * gdbtypes.c: Same.
 345         * hppa-tdep.c: Same.
 346         * i386-tdep.c: Same.
 347         * jit.c: Same.
 348         * main.c: Same.
 349         * mdebugread.c: Same.
 350         * moxie-tdep.c: Same.
 351         * nto-procfs.c: Same.
 352         * osabi.c: Same.
 353         * ppc-linux-tdep.c: Same.
 354         * remote.c: Same.
 355         * riscv-tdep.c: Same.
 356         * s390-tdep.c: Same.
 357         * sh-tdep.c: Same.
 358         * sparc-linux-tdep.c: Same.
 359         * sparc-nat.c: Same.
 360         * stack.c: Same.
 361         * target-descriptions.c: Same.
 362         * top.c: Same.
 363         * varobj.c: Same.
 364
 365 2019-10-16  Tom Tromey  <tom@tromey.com>
 366
 367         * objfiles.h (struct objfile) <original_name>: Now const.
 368
 369 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 370
 371         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 372         pass on to sigsetjmp's second argument.
 373         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 374
 375 2019-10-16  Keith Seitz  <keiths@redhat.com>
 376
 377         PR gdb/23567
 378         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 379         sections whose size is greater than the file size.
 380
 381 2019-10-16  Jim Wilson  <jimw@sifive.com>
 382
 383         * riscv-tdep.c (riscv_gcc_target_options): New.
 384         (riscv_gnu_triplet_regexp): New.
 385         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 386         set_gdbarch_gnu_triplet_regexp.
 387
 388 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 389
 390         * Makefile.in: Add xml-builtin.h.
 391         * features/feature_to_c.sh: Add an include for xml-builtin.h
 392         to ensure that the compiler checks that the types match.
 393         * xml-builtin.h: New file.
 394         * xml-support.c (fetch_xml_builtin): Add missing const.
 395         * xml-support.h: Remove declaration of xml_builtins.
 396
 397 2019-10-16  Tom de Vries  <tdevries@suse.de>
 398
 399         PR tdep/25096
 400         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 401         (amd64_classify_aggregate): ... here.
 402         (amd64_classify_aggregate_field): Handled fiels of nested structs
 403         recursively.
 404
 405 2019-10-16  Tom de Vries  <tdevries@suse.de>
 406
 407         PR tdep/24104
 408         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 409         that handles 'theclass'.
 410
 411 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 412
 413         * linespec.c (decode_digits_ordinary): Update comment.
 414         * make-target-delegates: No longer need to handle VEC case.
 415         * memrange.c (normalize_mem_ranges): Update comment.
 416         * namespace.c (add_using_directive): Update comment.
 417         * objc-lang.c (uniquify_strings): Update comment.
 418         * ppc-linux-nat.c (struct thread_points): Update comment.
 419         * probe.h (find_probes_in_objfile): Update comment.
 420         * target.h (enum flash_preserve_mode): Update comment.
 421         * varobj.c (varobj_restrict_range): Update comment.
 422         * varobj.h (varobj_list_children): Update comment.
 423
 424 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 425
 426         * Makefile.in: Remove references to vec.h and vec.c.
 427         * aarch64-tdep.c: No longer include vec.h.
 428         * ada-lang.c: Likewise.
 429         * ada-lang.h: Likewise.
 430         * arm-tdep.c: Likewise.
 431         * ax.h: Likewise.
 432         * breakpoint.h: Likewise.
 433         * charset.c: Likewise.
 434         * cp-support.h: Likewise.
 435         * dtrace-probe.c: Likewise.
 436         * dwarf2read.c: Likewise.
 437         * extension.h: Likewise.
 438         * gdb_bfd.c: Likewise.
 439         * gdbsupport/gdb_vecs.h: Likewise.
 440         * gdbsupport/vec.c: Remove.
 441         * gdbsupport/vec.h: Remove.
 442         * gdbthread.h: Likewise.
 443         * guile/scm-type.c: Likewise.
 444         * inline-frame.c: Likewise.
 445         * machoread.c: Likewise.
 446         * memattr.c: Likewise.
 447         * memrange.h: Likewise.
 448         * namespace.h: Likewise.
 449         * nat/linux-btrace.h: Likewise.
 450         * osdata.c: Likewise.
 451         * parser-defs.h: Likewise.
 452         * progspace.h: Likewise.
 453         * python/py-type.c: Likewise.
 454         * record-btrace.c: Likewise.
 455         * rust-exp.y: Likewise.
 456         * solib-target.c: Likewise.
 457         * stap-probe.c: Likewise.
 458         * target-descriptions.c: Likewise.
 459         * target-memory.c: Likewise.
 460         * target.h: Likewise.
 461         * varobj.c: Likewise.
 462         * varobj.h: Likewise.
 463         * xml-support.h: Likewise.
 464
 465 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 466
 467         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 468         Update for new std::vector based implementation.
 469         (process_psymtab_comp_unit_reader): Likewise.
 470         (scan_partial_symbols): Likewise.
 471         (recursively_compute_inclusions): Likewise.
 472         (compute_compunit_symtab_includes): Likewise.
 473         (process_imported_unit_die): Likewise.
 474         (queue_and_load_dwo_tu): Likewise.
 475         (follow_die_sig_1): Likewise.
 476         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 477         (typedef dwarf2_per_cu_ptr): Remove.
 478         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 479         function.
 480         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 481         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 482         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 483         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 484         std::vector.
 485
 486 2019-10-15  Tom Tromey  <tromey@adacore.com>
 487
 488         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 489         TID.
 490
 491 2019-10-15  Tom Tromey  <tromey@adacore.com>
 492
 493         * windows-nat.c (windows_nat_target::fetch_registers)
 494         (windows_nat_target::store_registers): Rename "pid" to "tid".
 495
 496 2019-10-15  Tom Tromey  <tromey@adacore.com>
 497
 498         * gdbarch.h, gdbarch.c: Rebuild.
 499         * gdbarch.sh (gcc_target_options): Change return type to
 500         std::string.
 501         * compile/compile.c (get_args): Update.
 502         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 503         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 504         std::string.
 505         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 506         std::string.
 507         * arch-utils.c (default_gcc_target_options): Return std::string.
 508         * arch-utils.h (default_gcc_target_options): Return std::string.
 509         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 510
 511 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 512
 513         * breakpoint.c (breakpoint_chain): Make static.
 514         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 515         of accessing breakpoint_chain.
 516
 517 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 518
 519         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 520         to a gdb::function_view and return value to bool.
 521         * breakpoint.h (iterate_over_breakpoints): Likewise.
 522         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 523         (pop_dummy_frame): Update.
 524         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 525         (gdbscm_breakpoints): Update.
 526         * python/py-breakpoint.c (build_bp_list): Update.
 527         (gdbpy_breakpoints): Update.
 528         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 529         Update.
 530         (bpfinishpy_handle_stop): Update.
 531         (bpfinishpy_handle_exit): Update.
 532         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 533         (svr4_update_solib_event_breakpoints): Update.
 534
 535 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 536
 537         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 538         when unwrapping single-field structs.
 539
 540 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 541
 542         * dwarf2read.c: Remove includes.
 543
 544 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 545
 546         * ui-out.c (ui_out::call_do_message): Silence
 547         -Wformat-nonliteral warning.
 548
 549 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 550
 551         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 552         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 553         include: readline/tilde.h.
 554
 555 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 556
 557         * remote.c (remote_target::get_trace_status): Remove declaration of
 558         trace_regblock_size.
 559
 560 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 561
 562         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 563         (show_user): Remove declaration of cmdlist.
 564         * cli/cli-cmds.h (max_user_call_depth): Declare.
 565         * cli/cli-script.c (execute_user_command): Remove declaration
 566         of max_user_call_depth.
 567
 568 2019-10-11  Jim Wilson  <jimw@sifive.com>
 569
 570         * gdbsupport/print-utils.h (pulongest): Fix comment.
 571         (plongest): Likewise.
 572         (phex): Add missing comment, mention leading zeros.
 573         (phex_nz): Add mention of no leading zeros to comment.
 574
 575         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 576         plongest instead of unsigned long long cast.
 577
 578 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 579
 580         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 581         for external_editor_command and gdbtk_test.
 582
 583 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 584
 585         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 586         * varobj.c (varobjdebug): Move comment to...
 587         * varobj.h (varobjdebug): ...here, and declare.
 588
 589 2019-10-09  Tom Tromey  <tom@tromey.com>
 590
 591         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 592         erase_data_content.
 593
 594 2019-10-09  Tom Tromey  <tom@tromey.com>
 595
 596         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 597         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 598         * tui/tui-command.c (tui_cmd_window::resize)
 599         (tui_refresh_cmd_win): Update.
 600         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 601         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 602         * tui/tui-data.c (~tui_gen_win_info): Remove.
 603         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 604         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 605         (tui_redisplay_readline, tui_mld_flush)
 606         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 607         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 608         (tui_data_window::erase_data_content)
 609         (tui_data_item_window::rerender)
 610         (tui_data_item_window::refresh_window): Update.
 611         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 612         (box_win, tui_gen_win_info::make_window)
 613         (tui_gen_win_info::make_visible): Update.
 614         (tui_delete_win): Remove.
 615         * tui/tui-winsource.c
 616         (tui_source_window_base::do_erase_source_content): Update.
 617         (tui_show_source_line, tui_source_window_base::update_tab_width)
 618         (tui_source_window_base::update_exec_info): Update.
 619         * tui/tui-data.h (struct curses_deleter): New.
 620         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 621         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 622
 623 2019-10-09  Tom Tromey  <tom@tromey.com>
 624
 625         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 626
 627 2019-10-09  Tom Tromey  <tom@tromey.com>
 628
 629         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 630         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 631
 632 2019-10-09  Tom Tromey  <tom@tromey.com>
 633
 634         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 635         window height directly.
 636         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 637         declare.
 638         * tui/tui-layout.c (tui_default_win_height): Remove.
 639         (tui_default_win_viewport_height): Remove.
 640
 641 2019-10-09  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui.h: Remove comments.
 644
 645 2019-10-09  Tom de Vries  <tdevries@suse.de>
 646
 647         * python/lib/gdb/printer/bound_registers.py: Use
 648         '^builtin_type_bound128' as regexp argument for
 649         add_builtin_pretty_printer.
 650
 651 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 652
 653         * guile/guile.c (guile_extension_script_ops): Remove forward
 654         declaration and mark as static.
 655         (guile_script_ops): Likewise.
 656         (extension_language_guile): Move further down in the file so
 657         it can reference the definitions for guile_{extension_,}script_ops.
 658
 659 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 660
 661         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 662         except SORTL, DFLTCC, and KDSA.
 663
 664 2019-10-08  Tom Tromey  <tromey@adacore.com>
 665
 666         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 667         (struct safe_symbol_file_add_args): Remove.
 668
 669 2019-10-08  Tom Tromey  <tromey@adacore.com>
 670
 671         * windows-nat.c: Don't include buildsym-legacy.h.
 672
 673 2019-10-08  Tom Tromey  <tromey@adacore.com>
 674
 675         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 676
 677 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 678
 679         * gdbtypes.c (overload_debug): Move comment to header.
 680         * gdbtypes.h (overload_debug): Declare.
 681         * valops.c: Remove declaration of overload_debug, instead
 682         include gdbtypes.h.
 683
 684 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 685
 686         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 687         through _().
 688         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 689         move comment...
 690         * language.h (lang_frame_mismatch_warn): ... here. Also add
 691         declaration.
 692         * top.c (lang_frame_mismatch_warn): Remove declaration.
 693         (check_frame_language_change): Pass lang_frame_mismatch_warn
 694         through _().
 695
 696 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 697
 698         * c-lang.h (vtbl_ptr_name): Declare.
 699         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 700         it from the header.
 701         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 702
 703 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 704
 705         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 706         gdb_static_assert.
 707
 708 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 709
 710         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 711         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 712         * ctfread.c: New file.
 713         * ctfread.h: New file.
 714         * elfread.c: Include ctfread.h.
 715         (struct elfinfo text_p): New member ctfsect.
 716         (elf_locate_sections): Mark CTF section.
 717         (elf_symfile_read): Call elfctf_build_psymtabs.
 718         * Makefile.in (LIBCTF): Add.
 719         (CLIBS): Use it.
 720         (CDEPS): Likewise.
 721         (DIST): Add ctfread.c.
 722
 723 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 724
 725         * ctfread.c (struct nextfield): Renamed to ...
 726         (struct ctf_nextfield): ... this.
 727         (struct field_info): Renamed to ...
 728         (strut ctf_field_info): ... this.
 729         (attach_fields_to_type): Update for renamed structures.
 730         (ctf_add_member_cb): Likewise.
 731         (ctf_add_enum_member_cb): Likewise.
 732         (process_struct_members): Likewise.
 733         (process_enum_type): Likewise.
 734
 735 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 736
 737         * tracectf.h: Rename, was ctf.h.
 738         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 739         * tracefile.c: Likewise.
 740         * tracepoint.c: Remove unused include ctf.h.
 741         * mi/mi-main.c: Likewise.
 742         * Makefile.in Replace ctf.c with tracectf.c.
 743
 744 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 745
 746         * version.in: Change version number to "9.0.50.DATE-git".
 747
 748 2019-10-03  Tom Tromey  <tom@tromey.com>
 749
 750         PR rust/24976:
 751         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 752
 753 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 754
 755         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 756         cp_search_name_hash.
 757         * NEWS: Add entry about nested function support.
 758
 759 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 760             Andrew Burgess  <andrew.burgess@embecosm.com>
 761
 762         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 763         for nested static variables when searchin VAR_DOMAIN.
 764         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 765         global scope, update comment.
 766         (add_partial_subprogram): Call add_partial_subprogram recursively
 767         for nested subroutines when processinng Fortran.
 768         (load_partial_dies): Process the child entities of a subprogram
 769         when processing Fortran.
 770         (partial_die_parent_scope): Handle building scope
 771         for Fortran nested functions.
 772         (process_die): Record that nested functions have a scope.
 773         (new_symbol): Always record Fortran subprograms on the global
 774         symbol list.
 775         (determine_prefix): How to build the prefix for Fortran
 776         subprograms.
 777
 778 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 779
 780         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 781         have just sent the thread a SIGSTOP and are waiting for it to
 782         arrive.
 783
 784 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 785
 786         * btrace.c (btrace_add_pc): Remove whitespace before the template
 787         parameter in 'std::vector <...>'.
 788         (parse_xml_btrace_block): Likewise.
 789         (btrace_maint_decode_pt): Likewise.
 790         (btrace_maint_update_packets): Likewise.
 791         (btrace_maint_print_packets): Likewise.
 792         * btrace.h (struct btrace_maint_info): Likewise.
 793         * dwarf2read.c (struct type_unit_group): Likewise.
 794         (build_type_psymtabs_reader): Likewise.
 795         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 796         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 797         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 798
 799 2019-10-03  Tom de Vries  <tdevries@suse.de>
 800
 801         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 802         the first line of the help text for set/show style metadata.
 803
 804 2019-10-02  Tom Tromey  <tromey@adacore.com>
 805
 806         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 807         * gdbsupport/common-inferior.c: New file.
 808         * infcmd.c (startup_with_shell): Don't define.
 809         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 810         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 811         * inferior.h (startup_with_shell): Don't declare.
 812
 813 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 814
 815         * gdbsupport/gdb_assert.h: Include errors.h.
 816         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 817
 818 2019-10-02  Tom Tromey  <tromey@adacore.com>
 819
 820         * NEWS: Add $_ada_exception entry.
 821         * ada-lang.c (struct ada_catchpoint): Add constructor.
 822         <m_kind>: New member.
 823         (allocate_location_exception, re_set_exception): Remove
 824         "ex" parameter.
 825         (should_stop_exception): Compute $_ada_exception.
 826         (check_status_exception, print_it_exception)
 827         (print_one_exception, print_mention_exception): Remove
 828         "ex" parameter.
 829         (allocate_location_catch_exception, re_set_catch_exception)
 830         (check_status_exception, print_it_catch_exception)
 831         (print_one_catch_exception, print_mention_catch_exception)
 832         (print_recreate_catch_exception)
 833         (allocate_location_catch_exception_unhandled)
 834         (re_set_catch_exception_unhandled)
 835         (check_status_exception, print_it_catch_exception_unhandled)
 836         (print_one_catch_exception_unhandled)
 837         (print_mention_catch_exception_unhandled)
 838         (print_recreate_catch_exception_unhandled)
 839         (allocate_location_catch_assert, re_set_catch_assert)
 840         (check_status_assert, print_it_catch_assert)
 841         (print_one_catch_assert, print_mention_catch_assert)
 842         (print_recreate_catch_assert)
 843         (allocate_location_catch_handlers, re_set_catch_handlers)
 844         (check_status_handlers, print_it_catch_handlers)
 845         (print_one_catch_handlers, print_mention_catch_handlers)
 846         (print_recreate_catch_handlers): Remove.
 847         (create_ada_exception_catchpoint): Update.
 848         (initialize_ada_catchpoint_ops): Update.
 849
 850 2019-10-02  Tom Tromey  <tromey@adacore.com>
 851
 852         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 853         (create_excep_cond_exprs): Simplify exception string computation.
 854         (ada_exception_catchpoint_cond_string): Likewise.
 855
 856 2019-10-02  Tom Tromey  <tromey@adacore.com>
 857
 858         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 859         * ada-lang.c (lesseq_defined_than): Handle
 860         LOC_STATIC.
 861         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 862         parameter.
 863         (dwarf2_has_info): Likewise.
 864         (new_symbol): Set maybe_copied on symbol when
 865         appropriate.
 866         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 867         parameter.
 868         <can_copy>: New member.
 869         * elfread.c (record_minimal_symbol): Set maybe_copied
 870         on symbol when appropriate.
 871         (elf_symfile_read): Update call to dwarf2_has_info.
 872         * minsyms.c (lookup_minimal_symbol_linkage): New
 873         function.
 874         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 875         * symtab.c (get_symbol_address, get_msymbol_address):
 876         New functions.
 877         * symtab.h (get_symbol_address, get_msymbol_address):
 878         Declare.
 879         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 880         maybe_copied.
 881         (struct symbol, struct minimal_symbol) <maybe_copied>:
 882         New member.
 883
 884 2019-10-02  Tom Tromey  <tromey@adacore.com>
 885
 886         * source.c (struct current_source_location): New.
 887         (current_source_key): New global.
 888         (current_source_symtab, current_source_line)
 889         (current_source_pspace): Remove.
 890         (get_source_location): New function.
 891         (get_current_source_symtab_and_line)
 892         (set_default_source_symtab_and_line)
 893         (set_current_source_symtab_and_line)
 894         (clear_current_source_symtab_and_line, select_source_symtab)
 895         (info_source_command, print_source_lines_base)
 896         (info_line_command, search_command_helper, _initialize_source):
 897         Update.
 898
 899 2019-10-02  Tom Tromey  <tromey@adacore.com>
 900
 901         * source.c (select_source_symtab): Don't call
 902         decode_line_with_current_source.
 903
 904 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 905
 906         * symtab.c (lookup_global_symbol): Search global block.
 907
 908 2019-10-02  Tom Tromey  <tromey@adacore.com>
 909
 910         * coffread.c (process_coff_symbol): Update.
 911         * dwarf2read.c (var_decode_location, new_symbol): Update.
 912         * mdebugread.c (parse_symbol): Update.
 913         * objfiles.c (relocate_one_symbol): Update.
 914         * stabsread.c (define_symbol, fix_common_block)
 915         (scan_file_globals): Update.
 916         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 917         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 918         * xcoffread.c (process_xcoff_symbol): Update.
 919
 920 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 921
 922         * MAINTAINERS: Update my email address.
 923
 924 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 925
 926         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 927         std::vector.
 928         (build_type_psymtabs_reader): Update for std::vector.
 929         (build_type_psymtab_dependencies): Likewise.
 930         * dwarf2read.h: Remove use of DEF_VEC_P.
 931         (typedef sig_type_ptr): Delete.
 932
 933 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 934
 935         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 936         to std::vector.
 937         (btrace_maint_decode_pt): Likewise, and move allocation of the
 938         vector outside of the loop.
 939         (btrace_maint_update_packets): Update to handle change from VEC to
 940         std::vector.
 941         (btrace_maint_print_packets): Likewise.
 942         (maint_info_btrace_cmd): Likewise.
 943         * btrace.h: Remove use of DEF_VEC_O.
 944         (typedef btrace_pt_packet_s): Delete.
 945         (struct btrace_maint_info) <packets>: Change fromm VEC to
 946         std::vector.
 947         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 948
 949 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 950
 951         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 952         make accesses into the vector constant references.
 953         (btrace_add_pc): Update for std::vector.
 954         (btrace_stitch_bts): Likewise.
 955         (parse_xml_btrace_block): Likewise.
 956         (btrace_maint_update_packets): Likewise.
 957         (btrace_maint_print_packets): Likewise.
 958         (maint_info_btrace_cmd): Likewise.
 959         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 960         std::vector.
 961         (btrace_data::empty): Likewise.
 962         (btrace_data_append): Likewise.
 963         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 964         (typedef btrace_block_s): Delete.
 965         (struct btrace_block): Add constructor.
 966         (struct btrace_data_bts) <blocks>: Change to std::vector.
 967         * nat/linux-btrace.c (perf_event_read_bts): Update for
 968         std::vector.
 969         (linux_read_bts): Likewise.
 970
 971 2019-10-01  Tom Tromey  <tom@tromey.com>
 972
 973         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 974
 975 2019-10-01  Tom Tromey  <tom@tromey.com>
 976
 977         * stack.c (print_frame, info_frame_command_core): Use
 978         styled_string.
 979         * linux-thread-db.c (try_thread_db_load_1)
 980         (try_thread_db_load_from_pdir_1): Use styled_string.
 981         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 982         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 983         (maybe_print_unsupported_script_warning)
 984         (maybe_print_script_not_found_warning): Use styled_string.
 985         * ada-lang.c (user_select_syms): Use styled_string.
 986
 987 2019-10-01  Tom Tromey  <tom@tromey.com>
 988
 989         * p-lang.c (pascal_printstr): Use metadata style.
 990         * value.c (show_convenience): Use metadata style.
 991         * valprint.c (valprint_check_validity, val_print_optimized_out)
 992         (val_print_not_saved, val_print_unavailable)
 993         (val_print_invalid_address, generic_val_print, val_print)
 994         (value_check_printable, val_print_array_elements): Use metadata
 995         style.
 996         * ui-out.h (class ui_out) <field_fmt>: New overload.
 997         <do_field_fmt>: Add style parameter.
 998         * ui-out.c (ui_out::field_fmt): New overload.
 999         * typeprint.c (type_print_unknown_return_type)
1000         (val_print_not_allocated, val_print_not_associated): Use metadata
1001         style.
1002         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1003         parameter.
1004         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1005         * tracepoint.c (tvariables_info_1): Use metadata style.
1006         * stack.c (print_frame_arg, print_frame_info, print_frame)
1007         (info_frame_command_core): Use metadata style.
1008         * skip.c (info_skip_command): Use metadata style.
1009         * rust-lang.c (rust_print_enum): Use metadata style.
1010         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1011         metadata style.
1012         * python/py-framefilter.c (py_print_single_arg): Use metadata
1013         style.
1014         * printcmd.c (do_one_display, print_variable_and_value): Use
1015         metadata style.
1016         * p-valprint.c (pascal_val_print)
1017         (pascal_object_print_value_fields): Use metadata style.
1018         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1019         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1020         parameter.
1021         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1022         * m2-valprint.c (m2_print_long_set): Use metadata style.
1023         * m2-typeprint.c (m2_print_type): Use metadata style.
1024         * infcmd.c (print_return_value_1): Use metadata style.
1025         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1026         * f-valprint.c (info_common_command_for_block): Use metadata
1027         style.
1028         * f-typeprint.c (f_type_print_base): Use metadata style.
1029         * expprint.c (print_subexp_standard): Use metadata style.
1030         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1031         * cli/cli-style.h (class cli_style_option): Add constructor.
1032         (metadata_style): Declare.
1033         * cli/cli-style.c (metadata_style): New global.
1034         (_initialize_cli_style): Register metadata style.
1035         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1036         parameter.
1037         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1038         * c-typeprint.c (c_type_print_base_struct_union)
1039         (c_type_print_base_1): Use metadata style.
1040         * breakpoint.c (watchpoint_value_print)
1041         (print_one_breakpoint_location): Use metadata style.
1042         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1043         style.
1044         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1045         style.
1046         * ada-valprint.c (val_print_packed_array_elements, printstr)
1047         (print_field_values, ada_val_print_ref, ada_val_print): Use
1048         metadata style.
1049         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1050         style.
1051         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1052         style.
1053         * ada-lang.c (user_select_syms): Use metadata style.
1054
1055 2019-10-01  Tom Tromey  <tom@tromey.com>
1056
1057         * cli/cli-cmds.c (pwd_command): Style output.
1058
1059 2019-10-01  Pedro Alves  <palves@redhat.com>
1060             Tom Tromey  <tom@tromey.com>
1061
1062         * symtab.c (print_symbol_info): Use %ps.
1063         (print_msymbol_info): Use %ps.
1064         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1065         * printcmd.c (print_variable_and_value): Use %ps.
1066         * macrocmd.c (show_pp_source_pos): Use %ps.
1067         * infrun.c (print_exited_reason): Use ui_out::message.
1068         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1069         (describe_other_breakpoints): Use ui_out::message and new
1070         formats.
1071         (say_where): Use new formats.
1072         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1073         and new formats.
1074
1075 2019-10-01  Pedro Alves  <palves@redhat.com>
1076             Tom Tromey  <tom@tromey.com>
1077
1078         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1079         (test_gdb_formats): New function.
1080         (run_tests): Call it.
1081         (test_format_specifier): Update.
1082         * utils.h (fputs_filtered): Update comment.
1083         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1084         (fputs_styled_unfiltered): Declare.
1085         * utils.c (fputs_styled_unfiltered): New function.
1086         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1087         (vfprintf_filtered): Update.
1088         (vfprintf_unfiltered, vprintf_filtered): Update.
1089         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1090         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1091         disallow_ui_out_field>: New constants.
1092         (enum class field_kind): New.
1093         (struct base_field_s, struct signed_field_s): New.
1094         (signed_field): New function.
1095         (struct string_field_s): New.
1096         (string_field): New function.
1097         (struct styled_string_s): New.
1098         (styled_string): New function.
1099         (class ui_out) <message>: Add comment.
1100         <vmessage, call_do_message>: New methods.
1101         <do_message>: Add style parameter.
1102         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1103         methods.
1104         (ui_out::message): Rewrite.
1105         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1106         parameter.
1107         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1108         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1109         gdb_extensions parameter.
1110         (class format_piece): Add parameter to constructor.
1111         (n_int_args): New field.
1112         * gdbsupport/format.c (format_pieces::format_pieces): Add
1113         gdb_extensions parameter.  Handle '*'.
1114         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1115         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1116         vfprintf_styled_no_gdbfmt.
1117         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1118         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1119         unfiltered output.
1120         * ui-style.h (struct ui_file_style) <ptr>: New method.
1121
1122 2019-10-01  Tom Tromey  <tom@tromey.com>
1123
1124         * unittests/format_pieces-selftests.c: Update.  Add final format.
1125         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1126         empty literal pieces.
1127
1128 2019-10-01  Tom Tromey  <tom@tromey.com>
1129
1130         * ui-out.h (enum class ui_out_style_kind): Remove.
1131         (class ui_out) <field_string, field_stsream, do_field_string>:
1132         Change type of "style".
1133         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1134         (ui_out::field_string): Update.
1135         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1136         of "style".
1137         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1138         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1139         * stack.c (print_frame_arg, print_frame_info, print_frame):
1140         Update.
1141         * source.c (print_source_lines_base): Update.
1142         * solib.c (info_sharedlibrary_command): Update.
1143         * skip.c (info_skip_command): Update.
1144         * record-btrace.c (btrace_call_history_src_line)
1145         (btrace_call_history): Update.
1146         * python/py-framefilter.c (py_print_frame): Update.
1147         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1148         "style".
1149         * mi/mi-out.c (mi_ui_out::do_table_header)
1150         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1151         (mi_ui_out::do_field_string): Update.
1152         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1153         Update.
1154         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1155         "style".
1156         * cli-out.c (cli_ui_out::do_table_header)
1157         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1158         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1159         (cli_ui_out::do_field_fmt): Update.
1160         * breakpoint.c (print_breakpoint_location): Update.
1161         (update_static_tracepoint): Update.
1162
1163 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1164
1165         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1166         conversion of gdb_datadir.
1167         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1168         remove not needed c_str ().
1169
1170 2019-09-30  Ali Tamur <tamur@google.com>
1171
1172         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1173         (dwarf2_string_attr): Likewise.
1174
1175 2019-09-30  Ali Tamur <tamur@google.com>
1176
1177         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1178         (process_full_type_unit): Likewise.
1179         (dump_die_shallow): Likewise.
1180         (cu_debug_loc_section): Likewise.
1181
1182 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1183
1184         * minsyms.c (compare_minimal_symbols): Rename to...
1185         (minimal_symbol_is_less_than): ...this, and adjust to STL
1186         conventions (return bool, take arguments as references)
1187         (minimal_symbol_reader::install): Call std::sort instead
1188         of qsort.
1189
1190 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1191
1192         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1193         hash and why.
1194         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1195         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1196
1197 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1198
1199         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1200         * psympriv.h (add_psymbol_to_list): Move comment here and update
1201         it.
1202
1203 2019-09-29  Tom de Vries  <tdevries@suse.de>
1204
1205         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1206         Use $tmpdir/$(basename "$output_file").dwz instead of
1207         "${output_file}.dwz".
1208
1209 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1210
1211         PR gdb/25045
1212         * hppa-linux-nat.c: Include gdbarch.h.
1213
1214 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1215
1216         * blockframe.c (find_pc_partial_function): Change return type to bool.
1217         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1218         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1219         (stub_gnu_ifunc_resolve_name): Likewise.
1220         * symtab.c (compare_filenames_for_search): Likewise.
1221         (compare_glob_filenames_for_search): Likewise.
1222         (matching_obj_sections): Likewise.
1223         (symbol_matches_domain): Likewise.
1224         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1225         (find_line_pc): Change return type to bool.
1226         (find_line_pc_range): Likewise.
1227         (producer_is_realview): Likewise.
1228         * symtab.h (symbol_matches_domain): Likewise.
1229         (find_pc_partial_function): Likewise.
1230         (find_pc_line_pc_range): Likewise.
1231         (in_gnu_ifunc_stub): Likewise.
1232         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1233         (find_line_pc): Likewise.
1234         (find_line_pc_range): Likewise.
1235         (matching_obj_sections): Likewise.
1236         (find_line_symtab): Change out parameter to bool.
1237         (producer_is_realview): Change return type to bool.
1238         (compare_filenames_for_search): Likewise.
1239         (compare_glob_filenames_for_search): Likewise.
1240
1241 2019-09-26  Tom Tromey  <tom@tromey.com>
1242
1243         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1244         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1245         * gdb_usleep.h: Remove.
1246         * gdb_usleep.c: Remove.
1247         * utils.c: Don't include gdb_usleep.h.
1248
1249 2019-09-26  Tom Tromey  <tromey@adacore.com>
1250
1251         * python/py-type.c (type_to_type_object): Call check_typedef
1252         for stub types.
1253
1254 2019-09-26  Tom Tromey  <tom@tromey.com>
1255
1256         * utils.h (initialize_utils): Don't declare.
1257         * top.c (gdb_init): Don't call initialize_utils.
1258         * utils.c (initialize_utils): Remove.  Move contents...
1259         (_initialize_utils): ... here.
1260
1261 2019-09-25  Tom Tromey  <tom@tromey.com>
1262
1263         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1264         * utils.h (make_hex_string): Don't declare.
1265         * utils.c (make_hex_string): Remove.
1266
1267 2019-09-24  Tom de Vries  <tdevries@suse.de>
1268
1269         PR gdb/23815
1270         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1271         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1272
1273 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1274
1275         * NEWS: Mention new simulator port for PRU.
1276
1277 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1278
1279         * ada-exp.y (write_object_remaining): Update.
1280         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1281         and eliminate the static buffer.
1282         (ada_decode_symbol): Update.
1283         (ada_la_decode): Update.
1284         (ada_sniff_from_mangled_name): Update.
1285         (is_valid_name_for_wild_match): Update.
1286         (ada_lookup_name_info::matches): Update and simplify.
1287         (name_matches_regex): Update.
1288         (ada_add_global_exceptions): Update.
1289         * ada-lang.h (ada_decode): Update signature.
1290         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1291         * dwarf-index-write.c (debug_names::insert): Update.
1292
1293 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1294
1295         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1296         formatting.
1297
1298 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1299
1300         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1301         Change "nonzero" to "true" in documentation.
1302
1303 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1304
1305         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1306         (_initialize_darwin_solib): Don't set
1307         darwin_so_ops.lookup_lib_global_symbol.
1308         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1309         set_gdbarch_iterate_over_objfiles_in_search_order.
1310         (elf_lookup_lib_symbol): Rename to...
1311         (svr4_iterate_over_objfiles_in_search_order): this, and update
1312         to iterate semantics.
1313         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1314         * solib.c (solib_global_lookup): Remove.
1315         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1316         (solib_global_lookup): Remove.
1317         * symtab.c (lookup_global_or_static_symbol): Remove call to
1318         solib_global_lookup.
1319
1320 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1321
1322         * NEWS: Move entries about default MI version now being
1323         version 3, and about the GDB/MI fix for multi-location
1324         breakpoints to the "since GDB 8.3" section.
1325
1326 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1327
1328         GDB 8.3.1 released.
1329
1330 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1331
1332         * NEWS: Mention that Cell/B.E. debugging support was removed.
1333         * MAINTAINERS: Remove spu target.
1334
1335         * config/djgpp/fnchange.lst: Remove entries for removed files.
1336
1337         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1338         spu-multiarch.o, and spu-tdep.o.
1339         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1340         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1341         spu-multiarch.c, and spu-tdep.c.
1342         * spu-linux-nat.c: Remove file.
1343         * spu-multiarch.c: Remove file.
1344         * spu-tdep.c: Remove file.
1345         * spu-tdep.h: Remove file.
1346         * solib-spu.c: Remove file.
1347         * solib-spu.h: Remove file.
1348
1349         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1350         * configure.nat (spu-linux): Remove.
1351         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1352         solib-multiarch.o from gdb_target_obs.
1353         (spu*-*-*): Remove.
1354
1355         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1356         feature flag.
1357         (ppc_linux_no_features): Update.
1358         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1359         Cell/B.E. support.
1360         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1361         (tdesc_powerpc_cell64l): Likewise.
1362         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1363         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1364         Cell/B.E. support.
1365         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1366         Do not include "features/rs6000/powerpc-cell32l.c" or
1367         "features/rs6000/powerpc-cell64l.c".
1368         (ppc_linux_spu_section): Remove.
1369         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1370         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1371         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1372         (ppc_linux_spe_context_lookup): Remove.
1373         (ppc_linux_spe_context_inferior_created): Remove.
1374         (ppc_linux_spe_context_solib_loaded): Remove.
1375         (ppc_linux_spe_context_solib_unloaded): Remove.
1376         (ppc_linux_spe_context): Remove.
1377         (struct ppu2spu_cache): Remove.
1378         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1379         (struct ppu2spu_data): Remove.
1380         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1381         ppu2spu_unwind): Remove.
1382         (ppc_linux_init_abi): Remove Cell/B.E. support.
1383         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1384
1385         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1386         (rs6000/powerpc-cell64l-expedite): Likewise
1387         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1388         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1389         rs6000/powerpc-cell64l.xml.
1390         * features/rs6000/powerpc-cell32l.xml: Remove.
1391         * features/rs6000/powerpc-cell64l.xml: Likewise.
1392         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1393         * features/rs6000/powerpc-cell64l.c: Likewise.
1394         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1395         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1396         * regformats/reg-spu.dat: Remove.
1397
1398         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1399         * corelow.c (struct spuid_list): Remove.
1400         (add_to_spuid_list): Remove.
1401         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1402         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1403         (remote_protocol_features): Remove associated entries.
1404         (_initialize_remote): No longer initialize them.
1405         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1406         * linux-nat.c (SPUFS_MAGIC): Remove.
1407         (linux_proc_xfer_spu): Remove.
1408         (spu_enumerate_spu_ids): Remove.
1409         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1410         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1411         (linux_make_corefile_notes): No longer call it.
1412
1413         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1414         (cooked_write_test): Likewise.
1415
1416 2019-09-20  Tom Tromey  <tom@tromey.com>
1417
1418         * NEWS: Mention case-sensitivity of TUI commands.
1419         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1420         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1421         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1422
1423 2019-09-20  Tom Tromey  <tom@tromey.com>
1424
1425         * tui/tui-source.c (tui_source_window::set_contents): Use
1426         make_unique_xstrdup.
1427         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1428         make_unique_xstrdup.
1429
1430 2019-09-20  Tom Tromey  <tom@tromey.com>
1431
1432         * tui/tui-data.c: Remove separator comments.
1433         * tui/tui-layout.c: Remove separator comments.
1434         * tui/tui-win.c: Remove separator comments.
1435         * tui/tui-wingeneral.c: Remove separator comments.
1436
1437 2019-09-20  Tom Tromey  <tom@tromey.com>
1438
1439         * tui/tui.h (strcat_to_buf): Don't declare.
1440         * tui/tui.c (strcat_to_buf): Remove.
1441
1442 2019-09-20  Tom Tromey  <tom@tromey.com>
1443
1444         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1445         from "fullname".
1446         * tui/tui-source.c (tui_source_window::set_contents)
1447         (tui_source_window::location_matches_p)
1448         (tui_source_window::maybe_update): Update.
1449
1450 2019-09-20  Tom Tromey  <tom@tromey.com>
1451
1452         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1453         Update.
1454         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1455         prefix.
1456         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1457         (tui_data_window::line_from_reg_element_no)
1458         (tui_data_window::first_reg_element_no_inline)
1459         (tui_data_window::show_registers)
1460         (tui_data_window::show_register_group)
1461         (tui_data_window::display_registers_from)
1462         (tui_data_window::display_registers_from_line)
1463         (tui_data_window::first_data_item_displayed)
1464         (tui_data_window::delete_data_content_windows)
1465         (tui_data_window::erase_data_content)
1466         (tui_data_window::do_scroll_vertical)
1467         (tui_data_window::refresh_window)
1468         (tui_data_window::check_register_values): Update.
1469
1470 2019-09-20  Tom Tromey  <tom@tromey.com>
1471
1472         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1473         (struct tui_locator_window) <full_name, proc_name>: Now
1474         std::string.
1475         * tui/tui-stack.c (tui_locator_window::make_status_line)
1476         (tui_locator_window::set_locator_fullname)
1477         (tui_locator_window::set_locator_info): Update.
1478         * tui/tui-source.c (tui_source_window::set_contents)
1479         (tui_source_window::showing_source_p): Update.
1480
1481 2019-09-20  Tom Tromey  <tom@tromey.com>
1482
1483         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1484         Don't call tui_locator_win_info_ptr.
1485
1486 2019-09-20  Tom Tromey  <tom@tromey.com>
1487
1488         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1489
1490 2019-09-20  Tom Tromey  <tom@tromey.com>
1491
1492         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1493         height for locator.
1494         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1495         * tui/tui-layout.c (show_source_disasm_command, show_data)
1496         (show_source_or_disasm_and_command): Use 1 as height for locator.
1497
1498 2019-09-20  Tom Tromey  <tom@tromey.com>
1499
1500         * tui/tui.c (tui_enable): Update.
1501         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1502         Update.
1503         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1504         Update.
1505         * tui/tui-data.c (win_resized): Now bool.
1506         (tui_win_resized): Return bool.
1507         (tui_set_win_resized_to): Accept a bool.
1508
1509 2019-09-20  Tom Tromey  <tom@tromey.com>
1510
1511         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1512         Change type of "refresh_values_only".
1513         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1514         type of "refresh_values_only".
1515
1516 2019-09-20  Tom Tromey  <tom@tromey.com>
1517
1518         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1519         std::string.
1520         (tui_disassemble): Add "pos" parameter.
1521         (tui_disasm_window::set_contents): Simplify.
1522
1523 2019-09-20  Tom Tromey  <tom@tromey.com>
1524
1525         * tui/tui-winsource.h (struct tui_source_window_base)
1526         <show_source_content>: Now private.
1527         * tui/tui-winsource.c
1528         (tui_source_window_base::show_source_content): Don't handle empty
1529         content case.
1530
1531 2019-09-20  Tom Tromey  <tom@tromey.com>
1532
1533         * tui/tui-layout.c (show_source_disasm_command)
1534         (show_source_or_disasm_and_command): Don't call
1535         show_source_content.
1536
1537 2019-09-20  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1540         Declare.
1541         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1542         from tui_make_status_line.
1543         (tui_locator_window::rerender): Update.
1544
1545 2019-09-20  Tom Tromey  <tom@tromey.com>
1546
1547         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1548         (tui_locator_window::rerender): Update.
1549
1550 2019-09-20  Tom Tromey  <tom@tromey.com>
1551
1552         * tui/tui-winsource.h (struct tui_source_window_base)
1553         <~tui_source_window_base>: Don't declare.
1554         <fullname>: Remove.
1555         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1556         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1557         member.
1558         * tui/tui-source.c (tui_source_window::set_contents): Update.
1559         (tui_source_window::location_matches_p)
1560         (tui_source_window::maybe_update): Update.
1561
1562 2019-09-20  Tom Tromey  <tom@tromey.com>
1563
1564         * tui/tui-winsource.h (~tui_source_element): Remove.
1565         (tui_source_element): Update.
1566         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1567         * tui/tui-winsource.c (tui_show_source_line): Update.
1568         * tui/tui-source.c (tui_source_window::set_contents): Update.
1569         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1570
1571 2019-09-20  Tom Tromey  <tom@tromey.com>
1572
1573         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1574         declare.
1575         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1576         tui_clear_source_windows_detail.
1577         * tui/tui-winsource.h (struct tui_source_window_base)
1578         <clear_detail>: Don't declare.
1579         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1580         Remove.
1581         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1582
1583 2019-09-20  Tom Tromey  <tromey@adacore.com>
1584
1585         PR ada/24919:
1586         * block.c (contained_in): Fix final return value.
1587
1588 2019-09-20  Alan Modra  <amodra@gmail.com>
1589
1590         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1591         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1592         (read_indirect_string_from_dwz): Use bfd accessor.
1593         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1594         * machoread.c (macho_symfile_read_all_oso): Likewise.
1595         * solib.c (solib_bfd_open): Likewise.
1596
1597 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1598
1599         * eval.c: Move declaration of overload_resolution to...
1600         * value.h: ...here.
1601
1602 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1603
1604         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1605         * arm-linux-tdep.c: Likewise.
1606         * arm-nbsd-nat.c: Likewise.
1607         * arm-tdep.h: Declare arm_apcs_32.
1608         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1609
1610 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1611
1612         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1613         * dwarf2read.h: Declare dwarf_always_disassemble.
1614
1615 2019-09-19  Tom de Vries  <tdevries@suse.de>
1616
1617         PR gdb/25009
1618         * source-cache.c (source_cache::ensure): Catch exception thrown during
1619         construction of the highlighter.
1620
1621 2019-09-18  Alan Modra  <amodra@gmail.com>
1622
1623         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1624         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1625         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1626         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1627         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1628         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1629         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1630         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1631         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1632         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1633         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1634         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1635         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1636         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1637         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1638         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1639         * mi/mi-interp.c: Update throughout for bfd section macro and
1640         function changes.
1641         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1642         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1643
1644 2019-09-18  Tom Tromey  <tom@tromey.com>
1645
1646         * NEWS: Add entry.
1647         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1648         call rl_initialize.
1649         (tui_enable): Do not call rl_initialize.
1650
1651 2019-09-18  Christian Groessler  <chris@groessler.org>
1652
1653         * alpha-linux-nat.c: Include gdbarch.h.
1654
1655 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1656
1657         * ui-file.c: Include cli/cli-style.h.
1658         (term_cli_styling): Remove cli_styling declaration.
1659
1660 2019-09-18  Alan Modra  <amodra@gmail.com>
1661
1662         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1663         to bfd_asymbol_section.
1664
1665 2019-09-18  Alan Modra  <amodra@gmail.com>
1666
1667         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1668         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1669         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1670
1671 2019-09-18  Alan Modra  <amodra@gmail.com>
1672
1673         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1674         * spu-linux-nat.c (spu_bfd_open): Likewise.
1675
1676 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1677
1678         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1679         to bool to match definition in dwarf2read.c.
1680
1681 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1682
1683         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1684         (print_signatures): Likewise.
1685         (trust_pad_over_xvs): Likewise.
1686         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1687         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1688         * arm-linux-nat.c (arm_apcs_32): Likewise.
1689         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1690         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1691         * arm-tdep.c (arm_debug): Likewise.
1692         (arm_apcs_32): Likewise.
1693         * auto-load.c (debug_auto_load): Likewise.
1694         (auto_load_gdb_scripts): Likewise.
1695         (global_auto_load): Likewise.
1696         (auto_load_local_gdbinit): Likewise.
1697         (auto_load_local_gdbinit_loaded): Likewise.
1698         * auto-load.h (global_auto_load): Likewise.
1699         (auto_load_local_gdbinit): Likewise.
1700         (auto_load_local_gdbinit_loaded): Likewise.
1701         * breakpoint.c (disconnected_dprintf): Likewise.
1702         (breakpoint_proceeded): Likewise.
1703         (automatic_hardware_breakpoints): Likewise.
1704         (always_inserted_mode): Likewise.
1705         (target_exact_watchpoints): Likewise.
1706         (_initialize_breakpoint): Update.
1707         * breakpoint.h (target_exact_watchpoints): Change to bool.
1708         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1709         * cli/cli-cmds.c (trace_commands): Likewise.
1710         * cli/cli-cmds.h (trace_commands): Likewise.
1711         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1712         to bool*.
1713         * cli/cli-logging.c (logging_overwrite): Change to bool.
1714         (logging_redirect): Likewise.
1715         (debug_redirect): Likewise.
1716         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1717         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1718         to bool.
1719         <boolean_option_def>: Update.
1720         (struct flag_option_def): Change default type of Context to bool
1721         from int.
1722         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1723         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1724         (get_setshow_command_value_string): Likewise.
1725         * cli/cli-style.c (cli_styling): Change to bool.
1726         (source_styling): Likewise.
1727         * cli/cli-style.h (source_styling): Likewise.
1728         (cli_styling): Likewise.
1729         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1730         to bool.
1731         * command.h (var_types): Update comment.
1732         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1733         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1734         bool.
1735         (debug_compile_cplus_scopes): Likewise.
1736         * compile/compile-internal.h (compile_debug): Likewise.
1737         * compile/compile.c (compile_debug): Likewise.
1738         (struct compile_options) <raw>: Likewise.
1739         * cp-support.c (catch_demangler_crashes): Likewise.
1740         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1741         (usr_cmd_cris_dwarf2_cfi): Likewise.
1742         * csky-tdep.c (csky_debug): Likewise.
1743         * darwin-nat.c (enable_mach_exceptions): Likewise.
1744         * dcache.c (dcache_enabled_p): Likewise.
1745         * defs.h (info_verbose): Likewise.
1746         * demangle.c (demangle): Likewise.
1747         (asm_demangle): Likewise.
1748         * dwarf-index-cache.c (debug_index_cache): Likewise.
1749         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1750         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1751         * dwarf2read.c (check_physname): Likewise.
1752         (use_deprecated_index_sections): Likewise.
1753         (dwarf_always_disassemble): Likewise.
1754         * eval.c (overload_resolution): Likewise.
1755         * event-top.c (set_editing_cmd_var): Likewise.
1756         (exec_done_display_p): Likewise.
1757         * event-top.h (set_editing_cmd_var): Likewise.
1758         (exec_done_display_p): Likewise.
1759         * exec.c (write_files): Likewise.
1760         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1761         (debug_fbsd_nat): Likewise.
1762         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1763         Likewise.
1764         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1765         <backtrace_past_entry> Likewise.
1766         * gdb-demangle.h (demangle): Likewise.
1767         (asm_demangle): Likewise.
1768         * gdb_bfd.c (bfd_sharing): Likewise.
1769         * gdbcore.h (write_files): Likewise.
1770         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1771         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1772         * gdbthread.h (print_thread_events): Likewise.
1773         * gdbtypes.c (opaque_type_resolution): Likewise.
1774         (strict_type_checking): Likewise.
1775         * gnu-nat.c (gnu_debug_flag): Likewise.
1776         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1777         * guile/scm-param.c (pascm_variable): Add boolval.
1778         (add_setshow_generic): Update.
1779         (pascm_param_value): Update.
1780         (pascm_set_param_value_x): Update.
1781         * hppa-tdep.c (hppa_debug): Change to bool..
1782         * infcall.c (may_call_functions_p): Likewise.
1783         (coerce_float_to_double_p): Likewise.
1784         (unwind_on_signal_p): Likewise.
1785         (unwind_on_terminating_exception_p): Likewise.
1786         * infcmd.c (startup_with_shell): Likewise.
1787         * inferior.c (print_inferior_events): Likewise.
1788         * inferior.h (startup_with_shell): Likewise.
1789         (print_inferior_events): Likewise.
1790         * infrun.c (step_stop_if_no_debug): Likewise.
1791         (detach_fork): Likewise.
1792         (debug_displaced): Likewise.
1793         (disable_randomization): Likewise.
1794         (non_stop): Likewise.
1795         (non_stop_1): Likewise.
1796         (observer_mode): Likewise.
1797         (observer_mode_1): Likewise.
1798         (set_observer_mode): Update.
1799         (sched_multi): Change to bool.
1800         * infrun.h (debug_displaced): Likewise.
1801         (sched_multi): Likewise.
1802         (step_stop_if_no_debug): Likewise.
1803         (non_stop): Likewise.
1804         (disable_randomization): Likewise.
1805         * linux-tdep.c (use_coredump_filter): Likewise.
1806         (dump_excluded_mappings): Likewise.
1807         * linux-thread-db.c (auto_load_thread_db): Likewise.
1808         (check_thread_db_on_load): Likewise.
1809         * main.c (captured_main_1): Update.
1810         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1811         xx2_opt, boolean_opt>: Change to bool.
1812         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1813         * maint.c (maintenance_profile_p): Likewise.
1814         (per_command_time): Likewise.
1815         (per_command_space): Likewise.
1816         (per_command_symtab): Likewise.
1817         * memattr.c (inaccessible_by_default): Likewise.
1818         * mi/mi-main.c (mi_async): Likewise.
1819         (mi_async_1): Likewise.
1820         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1821         * nat/fork-inferior.h (startup_with_shell): Likewise.
1822         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1823         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1824         * nios2-tdep.c (nios2_debug): Likewise.
1825         * or1k-tdep.c (or1k_debug): Likewise.
1826         * parse.c (parser_debug): Likewise.
1827         * parser-defs.h (parser_debug): Likewise.
1828         * printcmd.c (print_symbol_filename): Likewise.
1829         * proc-api.c (procfs_trace): Likewise.
1830         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1831         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1832         (set_parameter_value): Update.
1833         (add_setshow_generic): Update.
1834         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1835         to bool*.
1836         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1837         int*.
1838         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1839         * record-btrace.c (record_btrace_target::store_registers): Update.
1840         * record-full.c (record_full_memory_query): Change to bool.
1841         (record_full_stop_at_limit): Likewise.
1842         * record-full.h (record_full_memory_query): Likewise.
1843         * remote-notif.c (notif_debug): Likewise.
1844         * remote-notif.h (notif_debug): Likewise.
1845         * remote.c (use_range_stepping): Likewise.
1846         (interrupt_on_connect): Likewise.
1847         (remote_break): Likewise.
1848         * ser-tcp.c (tcp_auto_retry): Likewise.
1849         * ser-unix.c (serial_hwflow): Likewise.
1850         * skip.c (debug_skip): Likewise.
1851         * solib-aix.c (solib_aix_debug): Likewise.
1852         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1853         (spu_auto_flush_cache_p): Likewise.
1854         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1855         Likewise.
1856         (struct info_print_options) <quiet>: Likewise.
1857         * symfile-debug.c (debug_symfile): Likewise.
1858         * symfile.c (auto_solib_add): Likewise.
1859         (separate_debug_file_debug): Likewise.
1860         * symfile.h (auto_solib_add): Likewise.
1861         (separate_debug_file_debug): Likewise.
1862         * symtab.c (basenames_may_differ): Likewise.
1863         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1864         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1865         (struct info_types_options) <quiet>: Likewise.
1866         * symtab.h (demangle): Likewise.
1867         (basenames_may_differ): Likewise.
1868         * target-dcache.c (stack_cache_enabled_1): Likewise.
1869         (code_cache_enabled_1): Likewise.
1870         * target.c (trust_readonly): Likewise.
1871         (may_write_registers): Likewise.
1872         (may_write_memory): Likewise.
1873         (may_insert_breakpoints): Likewise.
1874         (may_insert_tracepoints): Likewise.
1875         (may_insert_fast_tracepoints): Likewise.
1876         (may_stop): Likewise.
1877         (auto_connect_native_target): Likewise.
1878         (target_stop_and_wait): Update.
1879         (target_async_permitted): Change to bool.
1880         (target_async_permitted_1): Likewise.
1881         (may_write_registers_1): Likewise.
1882         (may_write_memory_1): Likewise.
1883         (may_insert_breakpoints_1): Likewise.
1884         (may_insert_tracepoints_1): Likewise.
1885         (may_insert_fast_tracepoints_1): Likewise.
1886         (may_stop_1): Likewise.
1887         * target.h (target_async_permitted): Likewise.
1888         (may_write_registers): Likewise.
1889         (may_write_memory): Likewise.
1890         (may_insert_breakpoints): Likewise.
1891         (may_insert_tracepoints): Likewise.
1892         (may_insert_fast_tracepoints): Likewise.
1893         (may_stop): Likewise.
1894         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1895         (make_thread_apply_all_options_def_group): Change argument from int*
1896         to bool*.
1897         (thread_apply_all_command): Update.
1898         (print_thread_events): Change to bool.
1899         * top.c (confirm): Likewise.
1900         (command_editing_p): Likewise.
1901         (history_expansion_p): Likewise.
1902         (write_history_p): Likewise.
1903         (info_verbose): Likewise.
1904         * top.h (confirm): Likewise.
1905         (history_expansion_p): Likewise.
1906         * tracepoint.c (disconnected_tracing): Likewise.
1907         (circular_trace_buffer): Likewise.
1908         * typeprint.c (print_methods): Likewise.
1909         (print_typedefs): Likewise.
1910         * utils.c (debug_timestamp): Likewise.
1911         (sevenbit_strings): Likewise.
1912         (pagination_enabled): Likewise.
1913         * utils.h (sevenbit_strings): Likewise.
1914         (pagination_enabled): Likewise.
1915         * valops.c (overload_resolution): Likewise.
1916         * valprint.h (struct value_print_options) <prettyformat_arrays,
1917         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1918         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1919         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1920         Likewise.
1921         * windows-nat.c (new_console): Likewise.
1922         (cygwin_exceptions): Likewise.
1923         (new_group): Likewise.
1924         (debug_exec): Likewise.
1925         (debug_events): Likewise.
1926         (debug_memory): Likewise.
1927         (debug_exceptions): Likewise.
1928         (useshell): Likewise.
1929         * windows-tdep.c (maint_display_all_tib): Likewise.
1930         * xml-support.c (debug_xml): Likewise.
1931
1932 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1933
1934         * source.c (prepare_path_for_appending): New function.
1935         (openp): Make use of new function.
1936         (find_and_open_source): Search for the compilation directory and
1937         source file as a relative path beneath the directory search path.
1938
1939 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1940
1941         * source-cache.c (source_cache::get_line_charpos): Catch
1942         exceptions and return false, this matches the behaviour documented
1943         in the header file.
1944
1945 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1946
1947         * ada-tasks.c (info_task): Remove quoting of the task's name.
1948
1949 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1950
1951         * symfile.c (auto_solib_add): Replace comment with a reference
1952         to the header file.
1953
1954 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1955
1956         * NEWS: Mention that gdb can now be compiled with Python 3
1957         on Windows.
1958
1959 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1960
1961         * maint.c (maint_print_section_data::maint_print_section_data):
1962         Force use of 'float log10 (float)' by casting the argument to
1963         float.
1964
1965 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1966
1967         * maint.c: Add 'cmath' include.
1968         (struct maint_print_section_data): New structure.
1969         (print_section_index): New function.
1970         (print_bfd_section_info): Add header comment, small whitespace
1971         cleanup, and update to call new print_section_index function.
1972         (print_objfile_section_info): Likewise.
1973         (maint_obj_section_from_bfd_section): New function.
1974         (print_bfd_section_info_maybe_relocated): New function.
1975         (maintenance_info_sections): Add header comment, always use
1976         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1977
1978 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1979
1980         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1981         inner scope, add check that the objfile has psymtabs before
1982         checking psymtabs_addrmap.
1983         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1984
1985 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1986
1987         * NEWS: Announce that Ada task names are now shown at more places,
1988         and between quotes (except in info task output).
1989         * gdb/ada-tasks.c (task_to_str): New function.
1990         (display_current_task_id): Call task_to_str.
1991         (task_command_1): Likewise.
1992         (print_ada_task_info): In non-mi mode, Properly align headers and data
1993         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1994
1995 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1996
1997         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1998         prstatus.pr_lwp.pr_info instead of making it up.
1999
2000 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2001
2002         * auto-load.c (auto_load_expand_dir_vars): Update.
2003         * defs.h (gdb_datadir): Change to std::string.
2004         (python_libdir): Likewise.
2005         (relocate_gdb_directory): Change return type to std::string.
2006         * guile/guile.c (gdbscm_data_directory): Update.
2007         (initialize_scheme_side): Update.
2008         * jit.c (jit_reader_dir): Change to std::string.
2009         (jit_reader_load_command): Update.
2010         * main.c (gdb_datadir): Change to std::string.
2011         (python_libdir): Likewise.
2012         (set_gdb_data_directory): Update.
2013         (relocate_path): Change to return std::string.
2014         (relocate_gdb_directory): Change to return std::string.
2015         (relocate_gdbinit_path_maybe_in_datadir): Update.
2016         (captured_main_1): Update.
2017         * python/python.c (do_start_initialization): Update.
2018         * top.c (show_gdb_datadir): Update.
2019         * xml-syscall.c (xml_init_syscalls_info): Update.
2020         (init_syscalls_info): Update.
2021
2022 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2023
2024         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2025         out of get_init_files.
2026         (get_init_files): Update.
2027
2028 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2029
2030         * main.c (get_init_files): Change to use std::string.
2031         (captured_main_1): Update.
2032         (print_gdb_help): Update.
2033
2034 2019-09-11  Ali Tamur  <tamur@google.com>
2035
2036         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2037         implementation.
2038
2039 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2040
2041         * dbxread.c (read_dbx_symtab): Update.
2042         * dwarf2read.c (load_partial_dies): Update.
2043         * mdebugread.c (parse_partial_symbols): Update.
2044         (handle_psymbol_enumerators): Update.
2045         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2046         * psymtab.c (add_psymbol_to_bcache): Likewise.
2047         (add_psymbol_to_list): Likewise.
2048         * symtab.c (symbol_set_names): Likewise.
2049         * symtab.h (symbol_set_names): Likewise.
2050         * xcoffread.c (scan_xcoff_symtab): Update.
2051
2052 2019-09-11  Tom Tromey  <tom@tromey.com>
2053
2054         * symfile-mem.c (symbol_file_add_from_memory): Use
2055         bfd_set_filename.
2056         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2057         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2058
2059 2019-09-10  Tom Tromey  <tromey@adacore.com>
2060
2061         * dwarf-index-write.c (write_psymbols): Extend error message.
2062         (debug_names::insert): Add Ada code.
2063         (debug_names::write_psymbols): Remove Ada check.
2064         (debug_names) <m_string_obstack>: New member.
2065         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2066         (gdb_index_symbol_name_matcher::matches): Remove.
2067         (mapped_index_base::find_name_components_bounds): Add "lang"
2068         parameter.
2069         (mapped_index_base::build_name_components): Also split names
2070         according to Ada syntax.
2071         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2072         type of "match_callback".
2073         (check_match, check_find_bounds_finds)
2074         (dw2_expand_symtabs_matching): Update.
2075         (dw2_debug_names_iterator): Add new constructor.
2076         (dw2_debug_names_map_matching_symbols): New function.
2077         (dw2_debug_names_expand_symtabs_matching): Update.
2078         (dwarf2_debug_names_functions): Use
2079         dw2_debug_names_map_matching_symbols.
2080
2081 2019-09-10  Tom Tromey  <tromey@adacore.com>
2082
2083         * dwarf2read.c (dw2_get_file_names_reader): Add the
2084         CU's file name to the results.
2085
2086 2019-09-10  Tom Tromey  <tromey@adacore.com>
2087
2088         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2089         map_matching_symbols.  Update.
2090         * dwarf2read.c (dw2_map_matching_symbols): Update.
2091         * psymtab.c (match_partial_symbol): Change type; update.
2092         (psym_map_matching_symbols): Likewise.
2093         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2094         type; update.
2095         * symfile.h (struct quick_symbol_functions)
2096         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2097         Remove "match".
2098
2099 2019-09-10  Tom Tromey  <tromey@adacore.com>
2100
2101         * psymtab.c (map_block): Remove.
2102         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2103         * symtab.c (iterate_over_symbols_terminated): New function.
2104         * symtab.c (iterate_over_symbols_terminated): Declare.
2105
2106 2019-09-10  Tom Tromey  <tromey@adacore.com>
2107
2108         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2109         * language.h (struct language_defn) <la_iterate_over_symbols>:
2110         Return bool.
2111         * symtab.c (iterate_over_symbols): Return bool.
2112         * symtab.h (iterate_over_symbols): Return bool.
2113
2114 2019-09-10  Tom Tromey  <tromey@adacore.com>
2115
2116         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2117         (add_nonlocal_symbols): Update.
2118         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2119         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2120         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2121         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2122         Change type of "callback".  Remove "data".
2123
2124
2125 2019-09-09  Ali Tamur  <tamur@google.com>
2126
2127         * dwarf2read.c (comp_unit_head): Update comment.
2128         (dwarf2_dwo_name): New function declaration.
2129         (dwarf_unit_type_name): New function declaration.
2130         (read_comp_unit_head): Add support for new compilation units,
2131         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2132         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2133         (currently named as "signature") in their header. Also clarify error
2134         messages.
2135         (lookup_dwo_id): New function. Returns the dwo id of the given
2136         compile unit.
2137         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2138         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2139         functions.
2140         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2141         (dwarf2_dwo_name): Get the dwo name if present.
2142         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2143         purposes.
2144
2145 2019-09-09  Tom Tromey  <tom@tromey.com>
2146
2147         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2148
2149 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2150
2151         * python/python.c (do_start_initialization): Make progname_copy static,
2152         to avoid a leak report.
2153
2154 2019-09-08  Tom Tromey  <tom@tromey.com>
2155
2156         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2157
2158 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2159
2160         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2161         Change type to gdb::optional<block_enum>.
2162         (dw2_symtab_iter_init): Change block_index parameter type
2163         to gdb::optional<block_enum>.
2164         (dw2_lookup_symbol): Change block_index parameter
2165         type to block_enum.c
2166         (dw2_debug_names_lookup_symbol): Likewise.
2167         * psymtab.c (psym_lookup_symbol): Likewise.
2168         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2169         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2170         Likewise.
2171
2172 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2173
2174         * defs.h (relocate_gdb_directory): Change int to bool in
2175         signature and rename flag to relocatable.
2176         * main.c (relocate_path): Likewise.
2177         (relocate_gdb_directory): Likewise.
2178
2179 2019-09-06  Alan Modra  <amodra@gmail.com>
2180
2181         * coffread.c (coff_symfile_read): Constify filename variable.
2182         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2183         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2184         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2185         * solib.c (reload_shared_libraries_1): Likewise.
2186         * symfile.c (reread_symbols): Likewise.
2187         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2188         * solib-darwin.c (darwin_bfd_open): Likewise.
2189         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2190
2191 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2192
2193         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2194         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2195
2196 2019-09-03  Tom Tromey  <tromey@adacore.com>
2197
2198         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2199         types.
2200         (has_negatives): Unbias a range type bound.
2201         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2202         * gdbtypes.c (operator==): Handle new field.
2203         (create_range_type): Add "bias" parameter.
2204         (create_static_range_type, resolve_dynamic_range): Update.
2205         * gdbtypes.h (struct range_bounds) <bias>: New member.
2206         (create_range_type): Add bias parameter.
2207         * printcmd.c (print_scalar_formatted): Unbias range types.
2208         * value.c (unpack_long): Unbias range types.
2209         (pack_long): Bias range types.
2210
2211 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2212
2213         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2214         probe arguments.
2215
2216 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2217
2218         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2219         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2220         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2221         (compile_probe_arg): Likewise.
2222         * probe.h (get_argument_count): Likewise.
2223         * solib-svr4.c (solib_event_probe_action): Likewise.
2224         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2225
2226 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2227
2228         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2229         code to here...
2230         (svr4_create_solib_event_breakpoints): ...from here.
2231
2232 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2233
2234         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2235         suffix from warning message.
2236
2237 2019-08-30  Tom Tromey  <tom@tromey.com>
2238
2239         * tui/tui-winsource.h (struct tui_source_window_base)
2240         <refresh_all>: Don't declare.
2241         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2242         Remove.
2243         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2244         tui_show_locator_content.
2245         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2246         declare.
2247         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2248         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2249         declare.
2250
2251 2019-08-30  Tom Tromey  <tom@tromey.com>
2252
2253         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2254
2255 2019-08-30  Tom Tromey  <tom@tromey.com>
2256
2257         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2258         Remove unnecessary forward declarations.
2259
2260 2019-08-30  Tom Tromey  <tom@tromey.com>
2261
2262         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2263         rerender.
2264         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2265         tui_show_locator_content.
2266
2267 2019-08-30  Tom Tromey  <tom@tromey.com>
2268
2269         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2270         (tui_locator_window::rerender): Rewrite using body of previous
2271         tui_show_locator_content.
2272
2273 2019-08-30  Tom Tromey  <tom@tromey.com>
2274
2275         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2276         set_locator_fullname>: New methods.
2277         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2278         Rename from tui_set_locator_fullname.
2279         (tui_locator_window::set_locator_info): Rename from
2280         tui_set_locator_info.  Return bool.
2281         (tui_update_locator_fullname, tui_show_frame_info): Update.
2282
2283 2019-08-30  Tom Tromey  <tom@tromey.com>
2284
2285         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2286
2287 2019-08-30  Tom Tromey  <tom@tromey.com>
2288
2289         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2290         call touchwin.
2291
2292 2019-08-30  Tom Tromey  <tom@tromey.com>
2293
2294         * tui/tui-wingeneral.c (box_win): Assume win_info and
2295         win_info->handle cannot be NULL.
2296
2297 2019-08-30  Tom Tromey  <tom@tromey.com>
2298
2299         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2300         refresh_window>: Declare.
2301         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2302         resize.
2303         (tui_data_item_window::rerender): Rename from
2304         tui_display_register.
2305         (tui_data_item_window::refresh_window): New method.
2306         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2307         no-op.
2308
2309 2019-08-30  Tom Tromey  <tom@tromey.com>
2310
2311         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2312         regs_column_count, current_group>: Move later.  Now private.
2313         <get_current_group>: New method.
2314         * tui/tui-regs.c (tui_reg_command): Update.
2315         * tui/tui-layout.c (tui_set_layout): Update.
2316
2317 2019-08-30  Tom Tromey  <tom@tromey.com>
2318
2319         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2320         (tui_data_window::rerender): Don't call
2321         check_and_display_highlight_if_needed.
2322         (tui_data_window::refresh_all): Remove call to
2323         erase_data_content.
2324
2325 2019-08-30  Tom Tromey  <tom@tromey.com>
2326
2327         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2328         (tui_data_window::display_registers_from)
2329         (tui_data_window::display_reg_element_at_line)
2330         (tui_data_window::display_registers_from_line): Remove checks of
2331         "empty".
2332
2333 2019-08-30  Tom Tromey  <tom@tromey.com>
2334
2335         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2336         Don't declare.
2337         * tui/tui-regs.c (tui_data_window::show_registers): Call
2338         rerender.
2339         (tui_data_window::rerender): Rename from display_all_data.
2340         (tui_data_window::rerender): Remove old implementation.
2341
2342 2019-08-30  Tom Tromey  <tom@tromey.com>
2343
2344         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2345         text.
2346         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2347
2348 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2349             Sergio Durigan Junior  <sergiodj@redhat.com>
2350
2351         PR win32/24284
2352         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2353
2354 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2355
2356         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2357         when searching for types.
2358
2359 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2360
2361         * f-lang.c (f_language_defn): Use f_print_typedef.
2362         * f-lang.h (f_print_typedef): Declare.
2363         * f-typeprint.c (f_print_typedef): Define.
2364
2365 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2366
2367         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2368
2369 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2370
2371         * cli/cli-utils.c (info_print_options_defs): Delete.
2372         (make_info_print_options_def_group): Delete.
2373         (extract_info_print_options): Delete.
2374         (info_print_command_completer): Delete.
2375         (info_print_args_help): Add extra parameter, and optionally
2376         include text about -n flag.
2377         * cli/cli-utils.h (struct info_print_options): Delete.
2378         (extract_info_print_options): Delete declaration.
2379         (info_print_command_completer): Delete declaration.
2380         (info_print_args_help): Add extra parameter, extend header
2381         comment.
2382         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2383         search_symbols.
2384         * stack.c (struct info_print_options): New type.
2385         (info_print_options_defs): New file scoped variable.
2386         (make_info_print_options_def_group): New static function.
2387         (info_print_command_completer): New static function.
2388         (info_locals_command): Update to use new local functions.
2389         (info_args_command): Likewise.
2390         (_initialize_stack): Add extra parameter to calls to
2391         info_print_args_help.
2392         * symtab.c (search_symbols): Add extra parameter, use this to
2393         possibly excluse non-debug symbols.
2394         (symtab_symbol_info): Add extra parameter, which is passed on to
2395         search_symbols.
2396         (struct info_print_options): New type.
2397         (info_print_options_defs): New file scoped variable.
2398         (make_info_print_options_def_group): New static function.
2399         (info_print_command_completer): New static function.
2400         (info_variables_command): Update to use local functions, and pass
2401         extra parameter through to symtab_symbol_info.
2402         (info_functions_command): Likewise.
2403         (info_types_command): Pass additional argument through to
2404         symtab_symbol_info.
2405         (rbreak_command): Pass extra argument to search_symbols.
2406         (_initialize_symtab): Add extra arguments for calls to
2407         info_print_args_help, and update help text for 'info variables',
2408         'whereis', and 'info functions' commands.
2409         * symtab.h (search_symbols): Add extra argument to declaration.
2410         * NEWS: Mention new flags.
2411
2412 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2413
2414         * symtab.c (lookup_static_symbol): Call the new function (and move
2415         it down to be next to lookup_global_symbol).
2416         (struct global_sym_lookup_data): Add block_enum member and rename to...
2417         (struct global_or_static_sym_lookup_data): ...this.
2418         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2419         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2420         (lookup_symbol_global_or_static_iterator_cb): ...this.
2421         (lookup_global_or_static_symbol): New function.
2422         (lookup_global_symbol): Call new function.
2423
2424 2019-08-26  Tom de Vries  <tdevries@suse.de>
2425
2426         PR c++/24852
2427         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2428         when pc_probe.prob == NULL.
2429
2430 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2431
2432         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2433         variable symbol_linkage to symbol_linkage_.
2434
2435 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2436
2437         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2438         represent whether the symbol is static, dynamic, or we don't
2439         know.
2440
2441 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2442
2443         * gdb/rx-tdep.c (rx_register_names): New.
2444         (rx_register_name): Delete.
2445         (rx_psw_type): Delete.
2446         (rx_fpsw_type): Delete.
2447         (rx_register_type): Delete.
2448         (rx_gdbarch_init): Convert target-descriptions.
2449         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2450         * gdb/features/Makefile: Add rx.xml.
2451         * gdb/features/rx.xml: New.
2452         * gdb/features/rx.c: Generated.
2453         * gdb/NEWS: Mention target description support.
2454
2455 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2456
2457         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2458         *slot_ptr.
2459
2460 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2461
2462         * configure.ac: Don't check for 'dlfcn.h' (moved to
2463         gdbsupport/common.m4).
2464         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2465         'gdbsupport/'.
2466         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2467         * compile/compile-c-support.c: Include
2468         'gdbsupport/gdb-dlfcn.h'.
2469         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2470         * gdb-dlfcn.c: Move to...
2471         * gdbsupport/gdb-dlfcn.c: ... here.
2472         * gdb-dlfcn.h: Move to...
2473         * gdbsupport/gdb-dlfcn.h: ... here.
2474
2475 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2476
2477         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2478         the offset field signed.
2479
2480 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2481
2482         * python/lib/gdb/__init__.py (_execute_file): New function.
2483         * python/python.c (python_run_simple_file): Call gdb._execute_file
2484         on Windows.
2485
2486 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2487
2488         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2489         all uses as this was never set to anything but a zero value.
2490
2491 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2492
2493         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2494
2495 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2496
2497         * tui/tui-data.h (tui_gen_win_info): Add an =default
2498         move constructor, required by some GCC versions.
2499
2500 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2501
2502         * go32-nat.c (go32_sysinfo): Add hygon_p.
2503
2504 2019-08-20  Tom Tromey  <tom@tromey.com>
2505
2506         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2507         line_from_reg_element_no, first_reg_element_no_inline,
2508         display_all_data, delete_data_content_windows,
2509         erase_data_content>: Now private.
2510
2511 2019-08-20  Tom Tromey  <tom@tromey.com>
2512
2513         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2514         (tui_unhighlight_win, tui_highlight_win)
2515         (tui_win_info::make_window): Update.
2516         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2517
2518 2019-08-20  Tom Tromey  <tom@tromey.com>
2519
2520         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2521         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2522         (MAX_PID_WIDTH): Move to tui-stack.c.
2523         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2524         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2525         (MAX_PID_WIDTH): Move from tui-data.h.
2526
2527 2019-08-20  Tom Tromey  <tom@tromey.com>
2528
2529         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2530         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2531         (box_win): Update.
2532         (tui_gen_win_info::make_window): Rename from tui_make_window.
2533         (tui_win_info::make_window): New method.
2534         (tui_gen_win_info::make_visible): Update.
2535         * tui/tui-source.c (tui_source_window::set_contents): Update.
2536         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2537         (tui_data_window::display_registers_from): Update.
2538         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2539         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2540         Declare.
2541         <can_box>: Remove.
2542         <title>: Remove.
2543         (struct tui_win_info) <make_window>: Declare.
2544         <can_box>: Now virtual.
2545         <title>: New member.
2546         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2547         * tui/tui-command.c (tui_cmd_window::resize): Update.
2548
2549 2019-08-20  Tom Tromey  <tom@tromey.com>
2550
2551         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2552         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2553         (tui_data_window::check_register_values): Update.
2554
2555 2019-08-20  Tom Tromey  <tom@tromey.com>
2556
2557         * tui/tui-regs.h (struct tui_data_window): Use
2558         DISABLE_COPY_AND_ASSIGN.
2559         <regs_content>: Change type, removing unique_ptr.
2560         <tui_data_window>: Add move constructor.
2561         * tui/tui-regs.c (tui_data_window::show_registers)
2562         (tui_data_window::show_register_group)
2563         (tui_data_window::display_registers_from)
2564         (tui_data_window::display_registers_from)
2565         (tui_data_window::first_data_item_displayed)
2566         (tui_data_window::delete_data_content_windows)
2567         (tui_data_window::rerender, tui_data_window::refresh_window)
2568         (tui_data_window::check_register_values): Update.
2569
2570 2019-08-20  Tom Tromey  <tom@tromey.com>
2571
2572         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2573         show_register_group>: Declare.
2574         (tui_show_register_group): Don't declare.
2575         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2576         tui_show_registers.
2577         (tui_data_window::show_register_group): Rename from
2578         tui_show_register_group.
2579         (tui_data_window::check_register_values, tui_reg_command):
2580         Update.
2581         * tui/tui-layout.c (tui_set_layout): Update.
2582
2583 2019-08-20  Tom Tromey  <tom@tromey.com>
2584
2585         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2586         Declare.
2587         (tui_check_register_values): Don't declare.
2588         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2589         from tui_check_register_values.
2590         * tui/tui-hooks.c (tui_register_changed): Update.
2591
2592 2019-08-20  Tom Tromey  <tom@tromey.com>
2593
2594         * tui/tui-regs.c (tui_reg_layout): Move later.
2595         (tui_show_registers): Don't enable TUI mode or change layout.
2596
2597 2019-08-20  Tom Tromey  <tom@tromey.com>
2598
2599         * tui/tui-regs.h (struct tui_data_item_window)
2600         <~tui_data_item_window>: Remove.
2601         <content>: Now a unique_xmalloc_ptr.
2602         * tui/tui-regs.c (tui_register_format): Return a
2603         unique_xmalloc_ptr.
2604         (tui_get_register): Update.
2605         (~tui_data_item_window): Remove.
2606         (tui_data_window::display_registers_from, tui_display_register):
2607         Update.
2608         * tui/tui-io.h (tui_expand_tabs): Update.
2609         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2610         Remove "col" parameter.
2611
2612 2019-08-20  Tom Tromey  <tom@tromey.com>
2613
2614         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2615         field.
2616         * tui/tui-regs.c (~tui_data_item_window): Update.
2617
2618 2019-08-20  Tom Tromey  <tom@tromey.com>
2619
2620         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2621         earlier.
2622
2623 2019-08-20  Tom Tromey  <tom@tromey.com>
2624
2625         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2626
2627 2019-08-20  Tom Tromey  <tom@tromey.com>
2628
2629         * tui/tui-source.h (struct tui_source_window): Update.
2630         * tui/tui-regs.c (tui_show_registers): Update.
2631         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2632         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2633         (NO_REGS_STRING): Remove defines.
2634
2635 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2636
2637         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2638         unnecessary thread walk if remote doesn't support the packet.
2639
2640 2019-08-19  Tom Tromey  <tromey@adacore.com>
2641
2642         * python/py-value.c (value_has_field): Fix indentation.
2643
2644 2019-08-19  Tom Tromey  <tromey@adacore.com>
2645
2646         * printcmd.c (do_one_display, info_display_command): Update.
2647         * block.h (contained_in): Return bool.  Add allow_nested
2648         parameter.
2649         * block.c (contained_in): Return bool.  Add allow_nested
2650         parameter.
2651
2652 2019-08-19  Tom Tromey  <tom@tromey.com>
2653
2654         * configure: Rebuild.
2655         * configure.ac: Disallow the combination of -static-libstdc++ and
2656         source highlight.
2657         * source-cache.c (get_language_name): Handle rust.
2658         (source_cache::get_source_lines): Ignore highlighting exceptions.
2659
2660 2019-08-16  Tom Tromey  <tom@tromey.com>
2661
2662         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2663         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2664         (struct tui_source_window_base) <make_visible, refresh_window,
2665         resize>: Remove methods.
2666         <execution_info>: Remove field.
2667         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2668         (tui_show_source_line, tui_source_window_base)
2669         (~tui_source_window_base): Update.
2670         (tui_source_window_base::resize)
2671         (tui_source_window_base::make_visible)
2672         (tui_source_window_base::refresh_window): Remove.
2673         (tui_source_window_base::update_exec_info): Update.
2674         * tui/tui-source.c (tui_source_window::set_contents): Update.
2675         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2676
2677 2019-08-16  Tom Tromey  <tom@tromey.com>
2678
2679         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2680         deprecated_query_hook.
2681
2682 2019-08-16  Tom Tromey  <tom@tromey.com>
2683
2684         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2685         (tui_update_source_windows_with_line): Update.
2686         * tui/tui-source.h (struct tui_source_window)
2687         <show_symtab_source>: Declare.
2688         (tui_show_symtab_source): Don't declare.
2689         * tui/tui-source.c (tui_show_symtab_source): Rename from
2690         tui_show_symtab_source.
2691
2692 2019-08-16  Tom Tromey  <tom@tromey.com>
2693
2694         * tui/tui-winsource.h (struct tui_source_window_base)
2695         <set_contents>: Declare.
2696         * tui/tui-winsource.c
2697         (tui_source_window_base::update_source_window_as_is): Update.
2698         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2699         Declare.
2700         (tui_set_source_content): Don't declare.
2701         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2702         tui_set_source_content.
2703         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2704         Declare.
2705         (tui_set_disassem_content): Don't declare.
2706         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2707         tui_set_disassem_content.
2708
2709 2019-08-16  Tom Tromey  <tom@tromey.com>
2710
2711         * tui/tui-winsource.h (struct tui_source_window_base)
2712         <update_breakpoint_info>: Declare.
2713         (tui_update_breakpoint_info): Don't declare.
2714         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2715         (tui_update_all_breakpoint_info): Update.
2716         (tui_source_window_base::update_breakpoint_info): Rename from
2717         tui_update_breakpoint_info.
2718         (tui_source_window_base::update_exec_info): Update.
2719
2720 2019-08-16  Tom Tromey  <tom@tromey.com>
2721
2722         * tui/tui-winsource.h (struct tui_source_window_base)
2723         <update_source_window>: Declare.
2724         (tui_update_source_window): Don't declare.
2725         * tui/tui-winsource.c
2726         (tui_source_window_base::update_source_window): Rename from
2727         tui_update_source_window.
2728         (tui_source_window_base::rerender): Update.
2729         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2730         * tui/tui-disasm.c (tui_show_disassem)
2731         (tui_show_disassem_and_update_source)
2732         (tui_disasm_window::maybe_update): Update.
2733
2734 2019-08-16  Tom Tromey  <tom@tromey.com>
2735
2736         * tui/tui-winsource.h (struct tui_source_window_base)
2737         <update_source_window_as_is>: Declare.
2738         (tui_update_source_window_as_is): Don't declare.
2739         * tui/tui-winsource.c (tui_update_source_window): Update
2740         (tui_source_window_base::update_source_window_as_is): Rename from
2741         tui_update_source_window_as_is.
2742         (tui_source_window_base::refill): Update.
2743         * tui/tui-source.c (tui_show_symtab_source): Update.
2744         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2745         Update.
2746
2747 2019-08-16  Tom Tromey  <tom@tromey.com>
2748
2749         * tui/tui-winsource.h (tui_update_source_window)
2750         (tui_update_source_window_as_is): Remove "noerror" parameter.
2751         * tui/tui-winsource.c (tui_update_source_window)
2752         (tui_update_source_window_as_is): Remove "noerror" parameter.
2753         (tui_update_source_windows_with_addr)
2754         (tui_update_source_windows_with_line)
2755         (tui_source_window_base::rerender)
2756         (tui_source_window_base::refill): Update.
2757         * tui/tui-source.h (tui_set_source_content)
2758         (tui_show_symtab_source): Remove "noerror" parameter.
2759         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2760         parameter.
2761         (tui_show_symtab_source): Likewise.
2762         (tui_source_window::maybe_update): Update.
2763         * tui/tui-disasm.c (tui_show_disassem)
2764         (tui_show_disassem_and_update_source)
2765         (tui_disasm_window::do_scroll_vertical)
2766         (tui_disasm_window::maybe_update): Update.
2767
2768 2019-08-16  Tom Tromey  <tom@tromey.com>
2769
2770         * tui/tui.c (tui_is_window_visible): Update.
2771         * tui/tui-wingeneral.c (tui_make_window)
2772         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2773         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2774         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2775         (tui_set_win_height_command, parse_scrolling_args): Update.
2776         * tui/tui-source.c (tui_source_window::style_changed): Update.
2777         * tui/tui-regs.c (tui_show_registers)
2778         (tui_data_window::first_data_item_displayed)
2779         (tui_data_window::delete_data_content_windows)
2780         (tui_check_register_values, tui_reg_command): Update.
2781         * tui/tui-disasm.c (tui_show_disassem): Update.
2782         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2783         method.
2784         <is_visible>: Remove field.
2785         * tui/tui-data.c (tui_next_win, tui_prev_win)
2786         (tui_delete_invisible_windows): Update.
2787
2788 2019-08-16  Tom Tromey  <tom@tromey.com>
2789
2790         * tui/tui-winsource.h (struct tui_source_window_base)
2791         <m_has_locator>: Remove.
2792         * tui/tui-layout.c (show_source_disasm_command, show_data)
2793         (show_source_or_disasm_and_command): Update.
2794
2795 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2796
2797         * NEWS (Other MI changes): New subsection.
2798         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2799         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2800         * arch-utils.c (default_get_pc_address_flags): New function.
2801         * arch-utils.h (default_get_pc_address_flags): New declaration.
2802         * gdbarch.sh: Add get_pc_address_flags.
2803         * gdbarch.c: Regenerate.
2804         * gdbarch.h: Likewise.
2805         * stack.c (print_pc): New function.
2806         (print_frame_info) (print_frame): Call print_pc.
2807
2808 2019-08-16  Tom de Vries  <tdevries@suse.de>
2809
2810         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2811         print_objfile_section_info.
2812
2813 2019-08-15  Tom Tromey  <tom@tromey.com>
2814
2815         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2816         calling update_cmdwin_start_line.
2817         * tui/tui-winsource.h (struct tui_source_window_base)
2818         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2819         <rerender>: Declare.
2820         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2821         Call rerender.
2822         (tui_source_window_base::set_new_height): Remove.
2823         (tui_source_window_base::rerender): Rename from
2824         do_make_visible_with_new_height.
2825         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2826         resize method.
2827         (tui_win_info::make_invisible_and_set_new_height)
2828         (tui_win_info::make_visible_with_new_height): Remove.
2829         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2830         Declare.
2831         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2832         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2833         do_make_visible_with_new_height>: Don't declare.
2834         <rerender>: Declare.
2835         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2836         set_new_height.
2837         (tui_data_window::do_make_visible_with_new_height): Remove.
2838         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2839         call tui_show_locator_content.
2840         (tui_gen_win_info::resize): Call rerender.
2841         (show_source_or_disasm_and_command): Don't call
2842         tui_show_locator_content.
2843         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2844         method.
2845         (struct tui_win_info) <rerender>: Declare.
2846         <set_new_height, make_invisible_and_set_new_height,
2847         make_visible_with_new_height>: Don't declare.
2848         * tui/tui-data.c (tui_win_list::rerender): New method.
2849         * tui/tui-command.h (struct tui_cmd_window)
2850         <do_make_visible_with_new_height>: Don't declare.
2851         * tui/tui-command.c
2852         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2853
2854 2019-08-15  Tom Tromey  <tromey@adacore.com>
2855
2856         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2857         * ada-lang.c (ada_enum_name): Likewise.
2858
2859 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2860
2861         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2862         leading underscore.
2863         (GdbOutputErrorFile): Likewise.
2864         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2865         accordingly.
2866         (execute_unwinders): Rename to have a leading underscore.
2867         (auto_load_packages): Likewise.
2868         (global scope): Adjust call to auto_load_packages accordingly.
2869         (GdbSetPythonDirectory): Likewise.
2870         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2871         instead of execute_unwinders.
2872
2873 2019-08-15  Tom Tromey  <tom@tromey.com>
2874
2875         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2876         (show_data): Don't change window visibility.
2877         (tui_gen_win_info::resize): Remove special case for command
2878         window.  Use wresize, when available.
2879         (show_source_or_disasm_and_command): Don't change window
2880         visibility.
2881         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2882         <make_visible>: New method.
2883         * tui/tui-command.c (tui_cmd_window::resize): New method.
2884
2885 2019-08-15  Tom Tromey  <tom@tromey.com>
2886
2887         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2888         (struct tui_source_windows): New.
2889         * tui/tui-winsource.c (tui_display_main): Update.
2890         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2891         (new_height_ok, parse_scrolling_args): Update.
2892         * tui/tui-layout.c (show_layout, show_data): Update.
2893         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2894         (tui_add_to_source_windows): Don't declare.
2895         * tui/tui-data.c (source_windows, tui_source_windows)
2896         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2897
2898 2019-08-15  Tom Tromey  <tom@tromey.com>
2899
2900         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2901         Rename from reset.
2902         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2903         * tui/tui-layout.c (show_source_disasm_command, show_data):
2904         Update.
2905         (tui_gen_win_info::resize): Rename.
2906         (show_source_or_disasm_and_command): Update.
2907         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2908         reset.
2909
2910 2019-08-15  Tom Tromey  <tom@tromey.com>
2911
2912         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2913         * tui/tui-interp.c (tui_interp::init): Don't call
2914         tui_initialize_static_data.
2915         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2916
2917 2019-08-15  Tom Tromey  <tom@tromey.com>
2918
2919         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2920         examine tui_win_list.
2921
2922 2019-08-15  Tom Tromey  <tom@tromey.com>
2923
2924         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2925         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2926         tui_clear_source_content.
2927         (tui_clear_source_content): Remove.
2928         (tui_source_window_base::do_erase_source_content): Hoist call to
2929         content.clear().
2930         * tui/tui-stack.c (tui_show_frame_info): Don't call
2931         tui_clear_source_content.
2932
2933 2019-08-15  Tom Tromey  <tom@tromey.com>
2934
2935         * tui/tui-winsource.h (struct tui_source_window_base)
2936         <do_erase_source_content>: New method.
2937         <erase_source_content>: New method.
2938         (tui_erase_source_content): Don't declare.
2939         * tui/tui-winsource.c (tui_clear_source_content): Update.
2940         (tui_source_window_base::do_erase_source_content): Rename from
2941         tui_erase_source_content.
2942         (tui_source_window_base::show_source_content): Update.
2943         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2944         * tui/tui-source.h (struct tui_source_window)
2945         <erase_source_content>: New method.
2946         * tui/tui-disasm.h (struct tui_disasm_window)
2947         <erase_source_content>: New method.
2948
2949 2019-08-15  Tom Tromey  <tom@tromey.com>
2950
2951         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2952         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2953         constructor.
2954         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2955         * tui/tui-source.c (tui_set_source_content): Update.
2956         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2957
2958 2019-08-15  Tom Tromey  <tom@tromey.com>
2959
2960         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2961         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2962         tui-source.c.
2963         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2964         Declare.
2965         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2966         method.
2967         (tui_source_window::maybe_update): Update.
2968
2969 2019-08-15  Tom Tromey  <tom@tromey.com>
2970
2971         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2972         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2973         tui-disasm.c.
2974         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2975         Declare.
2976         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2977         method.
2978         (tui_disasm_window::maybe_update): Update.
2979
2980 2019-08-15  Tom Tromey  <tom@tromey.com>
2981
2982         * tui/tui-winsource.h (struct tui_source_window_base)
2983         <maybe_update>: Declare.
2984         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2985         method.
2986         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2987         Declare.
2988         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2989         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2990         Declare.
2991         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2992
2993 2019-08-15  Tom Tromey  <tom@tromey.com>
2994
2995         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2996
2997 2019-08-15  Tom Tromey  <tom@tromey.com>
2998
2999         * tui/tui-wingeneral.c: Include tui-stack.h.
3000         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3001         (struct tui_locator_window): Move from tui-data.h.
3002         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3003         (tui_initialize_static_data): Move from tui-data.c.
3004         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3005         (struct tui_locator_window): Move to tui-stack.c.
3006         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3007         (tui_initialize_static_data): Move to tui-stack.c.
3008
3009 2019-08-15  Tom Tromey  <tom@tromey.com>
3010
3011         * tui/tui-layout.c (show_source_disasm_command)
3012         (show_source_or_disasm_and_command): Use make_visible method, not
3013         tui_make_window.
3014         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3015         Remove.
3016
3017 2019-08-15  Tom Tromey  <tom@tromey.com>
3018
3019         * tui/tui-wingeneral.h (tui_make_window): Update.
3020         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3021         parameter.
3022         (tui_gen_win_info::make_visible): Update.
3023         * tui/tui-regs.c (tui_data_window::display_registers_from):
3024         Update.
3025         * tui/tui-layout.c (show_source_disasm_command)
3026         (show_source_or_disasm_and_command): Update.
3027         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3028         (enum tui_box): Remove.
3029         (struct tui_win_info) <can_box>: New method.
3030         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3031         method.
3032
3033 2019-08-15  Tom de Vries  <tdevries@suse.de>
3034
3035         * linux-nat-trad.c: Include gdbarch.h.
3036
3037 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3038
3039         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3040         register sizes.
3041
3042 2019-08-14  Tom Tromey  <tromey@adacore.com>
3043
3044         * darwin-nat.c: Include gdbarch.h.
3045         * darwin-nat-info.c: Include gdbarch.h.
3046
3047 2019-08-13  Tom Tromey  <tom@tromey.com>
3048
3049         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3050         Remove.
3051         * tui/tui-data.c (tui_initialize_static_data): Update.
3052
3053 2019-08-13  Tom Tromey  <tom@tromey.com>
3054
3055         * tui/tui-winsource.h (struct tui_exec_info_window)
3056         <~tui_exec_info_window, maybe_allocate_content, get_content,
3057         m_content>: Remove.
3058         (struct tui_source_window_base) <set_exec_info_content,
3059         show_exec_info_content>: Don't declare.
3060         * tui/tui-winsource.c
3061         (tui_exec_info_window::maybe_allocate_content): Remove.
3062         (tui_source_window_base::update_exec_info): Rename from
3063         set_exec_info_content.
3064         (tui_source_window_base::show_exec_info_content)
3065         (tui_source_window_base::update_exec_info): Remove.
3066
3067 2019-08-13  Tom Tromey  <tom@tromey.com>
3068
3069         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3070         declare.
3071         * tui/tui-winsource.c (tui_update_source_window_as_is)
3072         (tui_update_source_windows_with_addr, tui_erase_source_content):
3073         Update.
3074         (tui_clear_exec_info_content): Remove.
3075
3076 2019-08-13  Tom Tromey  <tom@tromey.com>
3077
3078         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3079         declare.
3080         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3081         call tui_erase_exec_info_content.
3082         (tui_clear_exec_info_content): Rename from
3083         tui_erase_exec_info_content.
3084         (tui_clear_exec_info_content): Delete.
3085
3086 2019-08-13  Tom Tromey  <tom@tromey.com>
3087
3088         * tui/tui-winsource.h (struct tui_source_window_base)
3089         <show_exec_info_content>: Declare.
3090         (tui_show_exec_info_content): Don't declare.
3091         * tui/tui-winsource.c
3092         (tui_source_window_base::show_exec_info_content): Rename from
3093         tui_show_exec_info_content.
3094         (tui_source_window_base::update_exec_info): Update.
3095
3096 2019-08-13  Tom Tromey  <tom@tromey.com>
3097
3098         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3099         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3100         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3101         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3102         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3103         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3104         ... here.
3105
3106 2019-08-13  Tom Tromey  <tom@tromey.com>
3107
3108         * tui/tui-winsource.h (struct tui_source_window_base)
3109         <update_exec_info>: Declare.
3110         (tui_update_exec_info): Don't declare.
3111         * tui/tui-winsource.c (tui_update_source_window_as_is)
3112         (tui_source_window_base::refresh_all)
3113         (tui_update_all_breakpoint_info): Update.
3114         (tui_source_window_base::update_exec_info): Rename from
3115         tui_update_exec_info.
3116         * tui/tui-stack.c (tui_show_frame_info): Update.
3117
3118 2019-08-13  Tom Tromey  <tom@tromey.com>
3119
3120         * tui/tui-winsource.h (struct tui_source_window_base)
3121         <set_exec_info_content>: Declare.
3122         (tui_set_exec_info_content): Don't declare.
3123         * tui/tui-winsource.c
3124         (tui_source_window_base::set_exec_info_content): Rename from
3125         tui_set_exec_info_content.
3126         (tui_update_exec_info): Update.
3127
3128 2019-08-13  Tom Tromey  <tom@tromey.com>
3129
3130         * tui/tui-winsource.h (struct tui_source_window_base)
3131         <show_source_content>: Declare.
3132         (tui_show_source_content): Don't declare.
3133         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3134         (tui_source_window_base::show_source_content): Rename from
3135         tui_show_source_content.
3136         (tui_source_window_base::refresh_all): Update.
3137         * tui/tui-layout.c (show_source_disasm_command)
3138         (show_source_or_disasm_and_command): Update.
3139
3140 2019-08-13  Tom Tromey  <tom@tromey.com>
3141
3142         * tui/tui-winsource.c (tui_erase_source_content)
3143         (tui_show_source_content, tui_source_window_base::refresh_all):
3144         Update.
3145         * tui/tui-wingeneral.h
3146         (tui_check_and_display_highlight_if_needed): Don't declare.
3147         * tui/tui-wingeneral.c
3148         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3149         check_and_display_highlight_if_needed.
3150         * tui/tui-win.c (tui_rehighlight_all)
3151         (tui_win_info::make_visible_with_new_height): Update.
3152         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3153         (tui_data_window::erase_data_content)
3154         (tui_data_window::display_all_data): Update.
3155         * tui/tui-data.h (struct tui_win_info)
3156         <check_and_display_highlight_if_needed>: Declare.
3157
3158 2019-08-13  Tom Tromey  <tom@tromey.com>
3159
3160         * tui/tui-win.c (tui_resize_all): Call
3161         tui_delete_invisible_windows.
3162         * tui/tui-layout.c (show_layout): Call
3163         tui_delete_invisible_windows.
3164         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3165         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3166
3167 2019-08-13  Tom Tromey  <tom@tromey.com>
3168
3169         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3170         tui_add_win_to_layout.
3171
3172 2019-08-13  Tom Tromey  <tom@tromey.com>
3173
3174         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3175         * tui/tui-layout.c (tui_default_win_height): Now static.
3176
3177 2019-08-13  Tom Tromey  <tom@tromey.com>
3178
3179         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3180         single switch.
3181         (show_source_disasm_command, show_source_or_disasm_and_command):
3182         Don't check current layout.
3183
3184 2019-08-13  Tom Tromey  <tom@tromey.com>
3185
3186         * tui/tui-wingeneral.c (make_all_visible): Remove.
3187         (tui_make_all_invisible): Simplify.
3188         * tui/tui-layout.c (tui_make_all_invisible): Move from
3189         tui-wingeneral.c; simplify.
3190         (show_layout): Hoist call to tui_make_all_invisible.
3191         (show_data): Don't call tui_make_all_invisible.
3192
3193 2019-08-13  Tom Tromey  <tom@tromey.com>
3194
3195         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3196         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3197
3198 2019-08-13  Tom Tromey  <tom@tromey.com>
3199
3200         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3201         tui-data.c.
3202         (show_source_disasm_command, show_data)
3203         (show_source_or_disasm_and_command): Don't use
3204         tui_set_current_layout_to.
3205         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3206         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3207         tui-layout.c.
3208         (tui_set_current_layout_to): Remove.
3209
3210 2019-08-13  Tom Tromey  <tom@tromey.com>
3211
3212         * tui/tui-layout.c (tui_set_layout): Update.
3213         * tui/tui-data.h (struct tui_layout_def): Remove.
3214         (tui_layout_def): Don't declare.
3215         * tui/tui-data.c (layout_def): Remove.
3216         (tui_layout_def): Remove.
3217
3218 2019-08-13  Tom Tromey  <tom@tromey.com>
3219
3220         * tui/tui-winsource.h (struct tui_source_window_base)
3221         <clear_detail>: No longer "override".
3222         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3223         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3224         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3225         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3226         Remove.
3227         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3228
3229 2019-08-13  Tom Tromey  <tromey@adacore.com>
3230
3231         * tracepoint.c: Don't include readline.h or history.h.
3232
3233 2019-08-12  Tom Tromey  <tom@tromey.com>
3234
3235         * configure: Rebuild.
3236         * configure.ac: Check for readline 7.
3237         * NEWS: Mention readline 7 requirement.
3238         * README: Update.
3239
3240 2019-08-12  Tom Tromey  <tom@tromey.com>
3241
3242         * mingw-hdep.c (gdb_select): Remove readline hack.
3243
3244 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3245
3246         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3247         when the function fails.
3248
3249 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3250
3251         * s390-tdep.c (s390_type_align): New function.
3252         (s390_gdbarch_init): Set it as type_align gdbarch method.
3253
3254 2019-08-09  Tom de Vries  <tdevries@suse.de>
3255
3256         PR gdb/24591
3257         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3258         pc_low with relocation offset.
3259
3260 2019-08-07  Tom Tromey  <tromey@adacore.com>
3261
3262         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3263         (print_frame_args): Update.
3264         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3265         Update.
3266         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3267         * frame.h (struct frame_arg): Add initializers.
3268         <error>: Now a unique_xmalloc_ptr.
3269
3270 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3271
3272         * NEWS: Expand the Pointer Authentication entry.
3273         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3274         (aarch64_frame_unmask_lr): ... to this.
3275         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3276         Call aarch64_frame_unmask_lr.
3277         * frame.c (struct frame_info): Add "masked" variable.
3278         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3279         (fprint_frame): Check for masked pc.
3280         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3281         declarations.
3282         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3283         * stack.c (print_frame): Check for masked pc.
3284
3285 2019-08-06  Tom Tromey  <tom@tromey.com>
3286
3287         * stabsread.c (patch_block_stabs, read_one_struct_field)
3288         (read_enum_type): Use obstack_strndup.
3289         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3290         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3291         * dwarf2read.c (guess_full_die_structure_name)
3292         (anonymous_struct_prefix): Use obstack_strndup.
3293         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3294         * c-exp.y (yylex): Use obstack_strndup.
3295         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3296         (write_var_or_type): Use obstack_strndup.
3297
3298 2019-08-06  Tom Tromey  <tom@tromey.com>
3299
3300         * symfile.c (reread_symbols): Use obstack_strdup.
3301         * stabsread.c (read_type): Use obstack_strdup.
3302         * gdb_obstack.h (obstack_strdup): New overload.
3303         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3304         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3305         (dwarf2_canonicalize_name): Use obstack_strdup.
3306         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3307         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3308         Use obstack_strdup.
3309
3310 2019-08-06  Tom Tromey  <tom@tromey.com>
3311
3312         * gdb_obstack.h (obstack_strdup): Define.
3313         * gdb_obstack.c (obstack_strdup): Don't define.
3314
3315 2019-08-06  Tom Tromey  <tom@tromey.com>
3316
3317         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3318         obstack_strdup.
3319         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3320         obstack_strdup.
3321         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3322         * stabsread.c (common_block_start): Use obstack_strdup.
3323         * objfiles.c (set_objfile_main_name, objfile): Use
3324         obstack_strdup.
3325         * namespace.c (add_using_directive): Use obstack_strdup.
3326         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3327         * jit.c (finalize_symtab): Use obstack_strdup.
3328         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3329         (guess_partial_die_structure_name, partial_die_info::fixup)
3330         (dwarf2_name): Use obstack_strdup.
3331         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3332         obstack_strdup.
3333         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3334         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3335         obstack_strdup.
3336         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3337
3338 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3339
3340         * unittests/help-doc-selftests.c: New file.
3341         * Makefile.in: Add the new file.
3342
3343 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3344
3345         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3346         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3347         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3348         the trailing '.' is not output, and the first character is uppercased.
3349         (print_help_for_command): Update call to print_doc_line.
3350         (print_doc_of_command): Likewise.
3351         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3352         * cli/cli-option.c (append_indented_doc): Do not append newline.
3353         (build_help_option): Append newline after first appended_indented_doc
3354         only if a second call is done.
3355         (build_help): Append 2 new lines before each option, except the first
3356         one.
3357         * compile/compile.c (_initialize_compile): Add new lines after
3358         %OPTIONS%, when not at the end of the help.
3359         Change help doc or code
3360         producing the help doc to respect the invariants.
3361         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3362         Also removed the new line after 'Options:', as all other commands
3363         do not put an empty line between 'Options:' and the first option.
3364         * printcmd.c (_initialize_printcmd): Likewise.
3365         * stack.c (_initialize_stack): Likewise.
3366         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3367         incorrectly telling COMMAND is optional.
3368         * ada-lang.c (_initialize_ada_language): Change help doc or code
3369         producing the help doc to respect the invariants.
3370         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3371         * breakpoint.c (_initialize_breakpoint): Likewise.
3372         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3373         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3374         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3375         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3376         _initialize_cli_style): Likewise.
3377         * corelow.c (core_target_info): Likewise.
3378         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3379         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3380         * filesystem.c (_initialize_filesystem): Likewise.
3381         * frame.c (_initialize_frame): Likewise.
3382         * gnu-nat.c (add_task_commands): Likewise.
3383         * infcall.c (_initialize_infcall): Likewise.
3384         * infcmd.c (_initialize_infcmd): Likewise.
3385         * interps.c (_initialize_interpreter): Likewise.
3386         * language.c (_initialize_language): Likewise.
3387         * linux-fork.c (_initialize_linux_fork): Likewise.
3388         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3389         * maint.c (_initialize_maint_cmds): Likewise.
3390         * memattr.c (_initialize_mem): Likewise.
3391         * printcmd.c (_initialize_printcmd): Likewise.
3392         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3393         _RegEx): Likewise.
3394         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3395         * record-btrace.c (_initialize_record_btrace): Likewise.
3396         * record-full.c (_initialize_record_full): Likewise.
3397         * record.c (_initialize_record): Likewise.
3398         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3399         * regcache.c (_initialize_regcache): Likewise.
3400         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3401         _initialize_remote): Likewise.
3402         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3403         * serial.c (_initialize_serial): Likewise.
3404         * skip.c (_initialize_step_skip): Likewise.
3405         * source.c (_initialize_source): Likewise.
3406         * stack.c (_initialize_stack): Likewise.
3407         * symfile.c (_initialize_symfile): Likewise.
3408         * symtab.c (_initialize_symtab): Likewise.
3409         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3410         * top.c (init_main): Likewise.
3411         * tracefile-tfile.c (tfile_target_info): Likewise.
3412         * tracepoint.c (_initialize_tracepoint): Likewise.
3413         * tui/tui-win.c (_initialize_tui_win): Likewise.
3414         * utils.c (add_internal_problem_command): Likewise.
3415         * valprint.c (value_print_option_defs): Likewise.
3416
3417 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3418
3419         PR build/24886
3420         * configure.ac: Drop enable-libmcheck support.
3421         * configure, config.in: Rebuild.
3422         * libmcheck.m4: Remove.
3423         * acinclude.m4: Don't include it.
3424         * Makefile.in: Don't distribute it.
3425         * top.c (print_gdb_configuration): Don't mention it.
3426
3427 2019-08-06  Tom Tromey  <tom@tromey.com>
3428
3429         * utils.c (set_output_style): Sometimes pass stream to
3430         emit_style_escape.
3431         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3432         * record-btrace.c (btrace_insn_history): Update.
3433         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3434         method.
3435         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3436         Update initializers.
3437         <m_uiout>: New field.
3438         <m_di>: Move lower.
3439         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3440         Remove "uiout" parameter.
3441         (dump_insns): Update.
3442         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3443         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3444
3445 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3446
3447         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3448         (error_in_psymtab_expansion): Likewise.
3449         (lookup_symbol_via_quick_fns): Likewise.
3450         (basic_lookup_transparent_type_quick): Likewise.
3451         (basic_lookup_transparent_type_1): Likewise.
3452
3453 2019-08-06  Tom Tromey  <tromey@adacore.com>
3454
3455         * source.c (last_source_error): Now bool.
3456         (print_source_lines_base): Make "noprint" bool.  Only open
3457         source file when last_source_visited changes.
3458
3459 2019-08-06  Tom Tromey  <tromey@adacore.com>
3460
3461         * annotate.c (annotate_source_line): Use g_source_cache.
3462         * source-cache.c (source_cache::get_plain_source_lines): Change
3463         parameters.  Populate m_offset_cache.
3464         (source_cache::ensure): New method.
3465         (source_cache::get_line_charpos): New method.
3466         (extract_lines): Move lower.  Change parameters.
3467         (source_cache::get_source_lines): Move lower.
3468         * source-cache.h (class source_cache): Update comment.
3469         <get_line_charpos>: New method.
3470         <get_source_lines>: Update comment.
3471         <clear>: Clear m_offset_cache.
3472         <get_plain_source_lines>: Change parameters.
3473         <ensure>: New method
3474         <m_offset_cache>: New member.
3475         * source.c (forget_cached_source_info_for_objfile): Update.
3476         (info_source_command): Use g_source_cache.
3477         (find_source_lines, open_source_file_with_line_charpos): Remove.
3478         (print_source_lines_base, search_command_helper): Use g_source_cache.
3479         * source.h (open_source_file_with_line_charpos): Don't declare.
3480         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3481         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3482         Use g_source_cache.
3483
3484 2019-08-06  Tom Tromey  <tromey@adacore.com>
3485
3486         * source-cache.c (source_cache::get_plain_source_lines):
3487         Remove "first_line" and "last_line" parameters.
3488         (source_cache::get_source_lines): Cache plain text.
3489         * source-cache.h (class source_cache)
3490         <get_plain_source_lines>: Update.
3491
3492 2019-08-06  Tom Tromey  <tromey@adacore.com>
3493
3494         * source-cache.c (extract_lines): No longer a method.
3495         Changed type of parameter.  Include final newline.
3496         (selftests::extract_lines_test): New function.
3497         (_initialize_source_cache): Likewise.
3498         * source-cache.h (class source_cache)
3499         <extract_lines>: Don't declare.
3500
3501 2019-08-06  Tom Tromey  <tromey@adacore.com>
3502
3503         * breakpoint.c (init_breakpoint_sal): Update.
3504         (breakpoint): Update.
3505         * breakpoint.h (struct breakpoint) <filter>: Now a
3506         unique_xmalloc_ptr.
3507
3508 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3509
3510         * NEWS: Mention dictionary access on blocks.
3511         * python/py-block.c (blpy_getitem): New function.
3512         (block_object_as_mapping): New struct.
3513         (block_object_type): Use new struct for tp_as_mapping field.
3514
3515 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3516
3517         * objfiles.h (objfile): Add a comment describing partial symbols.
3518
3519 2019-08-05  Tom Tromey  <tromey@adacore.com>
3520
3521         * compile/compile.c (_initialize_compile): Use _(), not N_().
3522         * thread.c (_initialize_thread): Use _(), not N_().
3523         * stack.c (_initialize_stack): Use _(), not N_().
3524         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3525
3526 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3527
3528         * dwarf2read.c (struct dw2_symtab_iterator):
3529         <want_specific_block>: Remove.
3530         <block_index>: Change type to gdb::optional.
3531         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3532         change type of BLOCK_INDEX parameter to gdb::optional.
3533         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3534         (dw2_lookup_symbol): Don't pass argument for
3535         WANT_SPECIFIC_BLOCK.
3536         (dw2_expand_symtabs_for_function): Don't pass argument for
3537         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3538         (class dw2_debug_names_iterator)
3539         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3540         parameter, change BLOCK_INDEX type to gdb::optional.
3541         <m_want_specific_block>: Remove.
3542         <m_block_index>: Change type to gdb::optional.
3543         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3544         gdb::optional.  Re-write in function of gdb::optional.
3545         (dw2_debug_names_lookup_symbol): Don't pass argument for
3546         WANT_SPECIFIC_BLOCK.
3547         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3548         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3549         BLOCK_INDEX.
3550
3551 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3552
3553         * NEWS: Mention changes to "info sources" command.
3554
3555 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3556
3557         * symtab.c (filename_partial_match_opts): New struct type.
3558         (struct output_source_filename_data): New members
3559         regexp, c_regexp, partial_match.
3560         (output_source_filename): Use new members to decide to print file.
3561         (info_sources_option_defs): New variable.
3562         (make_info_sources_options_def_group, print_info_sources_header,
3563         info_sources_command_completer):
3564         New functions.
3565         (info_sources_command): Read new optional arguments.
3566         (_initialize_symtab): Update info sources help.
3567
3568 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3569
3570         * ada-lang.c (exception_support_info_v0): Renamed from...
3571         (default_exception_support_info): ... this.  Create new
3572         definition for v1.
3573         (ada_has_this_exception_support): Look up catch_handlers_sym.
3574         (ada_exception_support_info_sniffer): Try v0 after default.
3575
3576 2019-08-01  Tom Tromey  <tromey@adacore.com>
3577
3578         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3579         gdbarch.h.
3580
3581 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3582
3583         * s12z-tdep.c: Fix include path for s12z-opc.h.
3584
3585 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3586
3587         * NEWS: Require GNU make 3.82.
3588
3589 2019-07-16  Tom Tromey  <tom@tromey.com>
3590
3591         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3592         declare.
3593
3594 2019-07-30  Tom Tromey  <tromey@adacore.com>
3595
3596         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3597
3598 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3599
3600         * printcmd.c (print_address_symbolic): Print negative offsets.
3601         (build_address_symbolic): Force signed arithmetic when computing
3602         offset.
3603
3604 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3605
3606         PR/24474: Add a function to lookup static variables.
3607         * NEWS: Mention this new function.
3608         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3609         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3610         * python/python.c (python_GdbMethods): Add new function.
3611
3612 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3613
3614         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3615         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3616         (objfpy_lookup_static_symbol): New function.
3617         (objfile_object_methods): Add new functions.
3618
3619 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3620
3621         * NEWS: Mention 'set|show print frame-info'.  Mention new
3622         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3623         backtrace argument.  Mention that python frame filtering code
3624         is now consistent with what 'backtrace' command prints.
3625
3626 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3627
3628         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3629         comments.
3630         (print_frame_info_auto, print_frame_info_source_line,
3631         print_frame_info_location, print_frame_info_source_and_location,
3632         print_frame_info_location_and_address, print_frame_info_short_location):
3633         New declarations.
3634         (struct frame_print_options): New member print_frame_info.
3635         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3636         * stack.h (get_user_print_what_frame_info): New declaration.
3637         (frame_show_address): New declaration.
3638         * stack.c (print_frame_arguments_choices): New value 'presence'.
3639         (print_frame_info_auto, print_frame_info_source_line,
3640         print_frame_info_location, print_frame_info_source_and_location,
3641         print_frame_info_location_and_address, print_frame_info_short_location,
3642         print_frame_info_choices, print_frame_info_print_what): New definitions.
3643         (print_frame_args): Only print dots for args if print frame-arguments
3644         is 'presence'.
3645         (frame_print_option_defs): New element for "frame-info".
3646         (get_user_print_what_frame_info): New function.
3647         (frame_show_address): Make non static.  Move comment to stack.h.
3648         (print_frame_info_to_print_what): New function.
3649         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3650         to decide what to print.
3651         (backtrace_command_1): Handle the new print_frame_arguments_presence
3652         value.
3653         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3654         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3655         (py_print_frame): In non-mi mode, use LOCATION as default for
3656         print_what, similarly to frame information printed directly by
3657         backtrace command. Handle frame-info user option in non MI mode.
3658
3659 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3660
3661         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3662         Add case for debugging 32-bit target on 64-bit host.  Revise
3663         comment.
3664
3665 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3666
3667         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3668         instead of find_function_entry_range_from_pc.
3669
3670 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3671
3672         * stack.c (find_frame_funname): Remove code which preferred
3673         minsym over symtab sym in "certain pathological cases".
3674
3675         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3676         parameter.  Change type of "do_demangle" to bool.
3677         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3678         Pass suitable "prefer_sym_over_minsym" flag to
3679         build_address_symbolic().  Don't output "+" for negative offsets.
3680         * printcmd.c (print_address_symbolic): Update invocation of
3681         build_address_symbolic to include a "prefer_sym_over_minsym"
3682         flag.
3683         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3684         Restrict cases in which use of minimal symbol is preferred to that
3685         of a found symbol.  Update comments.
3686
3687         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3688         for entry pc when entry pc is out of range for that FDE.
3689
3690 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3691
3692         PR gdb/24839:
3693         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3694         type.
3695
3696 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3697
3698         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3699         this function's Python signature.
3700
3701
3702 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3703
3704         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3705         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3706         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3707         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3708         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3709
3710
3711 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3712
3713         * h8300-tdep.c (h8300_register_name_common): New.
3714         h8300_register_name): Use h8300_register_name_common.
3715         (h8300s_register_name): Likewise.
3716         (h8300sx_register_name): Likewise.
3717         (h8300h_register_nam): New.
3718         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3719
3720
3721 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3722
3723         * arm-tdep.c (arm_skip_cmse_entry): New function.
3724         (arm_is_sgstubs_section): New function.
3725         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3726
3727 2019-07-22  Tom Tromey  <tom@tromey.com>
3728
3729         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3730         Don't self-assign.
3731
3732 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3733
3734         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3735         type_print.
3736
3737 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3738
3739         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3740         so that GDB doesn't match any msymbols when searching in the
3741         TYPES_DOMAIN.
3742         (print_symbol_info): Print using typedef_print or type_print based
3743         on the type of the symbol.  Add updated FIXME comment moved from...
3744         (_initialize_symtab): ... move and update FIXME comment to above.
3745
3746 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3747
3748         * NEWS: Mention adding -q option to "info types".
3749         * symtab.c (struct info_types_options): New struct.
3750         (info_types_options_defs): New variable.
3751         (make_info_types_options_def_group): New function.
3752         (info_types_command): Use gdb::option framework to parse options.
3753         (info_types_command_completer): New function.
3754         (_initialize_symtab): Extend the help text on "info types" and
3755         register command completer.
3756
3757 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3758
3759         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3760         (lookup_symbol_in_objfile): Change int to block_enum and add a
3761         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3762
3763 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3764
3765         * MAINTAINERS (Write After Approval): Add self.
3766
3767 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3768
3769         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3770         instruction to the dummy code region.
3771
3772 2019-07-19  Tom Tromey  <tromey@adacore.com>
3773
3774         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3775         (ARGSUSED, PARAMS, __func__): Remove rules.
3776
3777 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3778
3779         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3780         * features/arm/arm-with-iwmmxt.c: Remove.
3781         * features/arm/arm-with-iwmmxt.xml: Remove.
3782         * features/arm/arm-with-m-fpa-layout.c: Remove.
3783         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3784         * features/arm/arm-with-m-vfp-d16.c: Remove.
3785         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3786         * features/arm/arm-with-m.c: Remove.
3787         * features/arm/arm-with-m.xml: Remove.
3788         * features/arm/arm-with-neon.c: Remove.
3789         * features/arm/arm-with-neon.xml: Remove.
3790         * features/arm/arm-with-vfpv2.c: Remove.
3791         * features/arm/arm-with-vfpv2.xml: Remove.
3792         * features/arm/arm-with-vfpv3.c: Remove.
3793         * features/arm/arm-with-vfpv3.xml: Remove.
3794
3795 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3796
3797         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3798
3799 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3800
3801         * arch/aarch32.c (aarch32_create_target_description): Create
3802         target descriptions using features.
3803         * arch/arm.c (arm_create_target_description)
3804         (arm_create_mprofile_target_description): Likewise.
3805         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3806
3807 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3808
3809         * Makefile.in: Add new files.
3810         * aarch32-tdep.c: New file.
3811         * aarch32-tdep.h: New file.
3812         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3813         Call aarch32_read_description.
3814         * arch/aarch32.c: New file.
3815         * arch/aarch32.h: New file.
3816         * arch/arm.c (arm_create_target_description)
3817         (arm_create_mprofile_target_description): New function.
3818         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3819         (arm_create_target_description)
3820         (arm_create_mprofile_target_description): New declaration.
3821         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3822         read_description functions.
3823         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3824         Likewise.
3825         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3826         * arm-tdep.c (tdesc_arm_list): New variable.
3827         (arm_register_g_packet_guesses): Call create description functions.
3828         (arm_read_description) (arm_read_mprofile_description): New
3829         function.
3830         * arm-tdep.h (arm_read_description)
3831         (arm_read_mprofile_description): Add declaration.
3832         * configure.tgt: Add new files.
3833
3834 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3835
3836         * top.c (new_ui_command): Open specified terminal just once.
3837
3838 2019-07-18  Tom Tromey  <tromey@adacore.com>
3839
3840         * symtab.c (main_name): Constify return type.
3841         * symfile.c (set_initial_language): Update.
3842         * symtab.h (main_name): Constify return type.
3843
3844 2019-07-17  Tom Tromey  <tom@tromey.com>
3845
3846         * tui/tui-winsource.c (tui_update_source_window)
3847         (tui_update_source_window_as_is)
3848         (tui_update_source_windows_with_line): Remove return.
3849         * tui/tui-disasm.c (tui_show_disassem)
3850         (tui_show_disassem_and_update_source): Remove return.
3851         * tui/tui.c (tui_reset): Remove return.
3852         * tui/tui-wingeneral.c
3853         (tui_check_and_display_highlight_if_needed): Remove return.
3854
3855 2019-07-17  Tom Tromey  <tom@tromey.com>
3856
3857         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3858
3859 2019-07-17  Tom Tromey  <tom@tromey.com>
3860
3861         * tui/tui-winsource.h (struct tui_exec_info_window)
3862         (struct tui_source_window_base): Move from tui-data.h.
3863         * tui/tui-winsource.c: Move many method definitions from
3864         elsewhere.  Remove "structuring" comments.
3865         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3866         (tui_source_window_base::refresh_window): Move to
3867         tui-winsource.c.
3868         * tui/tui-win.c (tui_source_window_base::refresh_all)
3869         (tui_source_window_base::update_tab_width)
3870         (tui_source_window_base::set_new_height)
3871         (tui_source_window_base::do_make_visible_with_new_height): Move to
3872         tui-winsource.c.
3873         * tui/tui-source.h: Update.
3874         * tui/tui-source.c (tui_source_window_base::reset): Move to
3875         tui-winsource.c.
3876         * tui/tui-disasm.h: Update.
3877         * tui/tui-data.h (struct tui_exec_info_window): Move to
3878         tui-winsource.h.
3879         (struct tui_source_window_base): Likewise.
3880         * tui/tui-data.c (tui_source_window_base::clear_detail)
3881         (tui_source_window_base, ~tui_source_window_base): Move to
3882         tui-winsource.c.
3883
3884 2019-07-17  Tom Tromey  <tom@tromey.com>
3885
3886         * tui/tui-win.c (tui_resize_all)
3887         (tui_source_window_base::update_tab_width)
3888         (tui_adjust_win_heights): Update.
3889         (tui_win_info::make_invisible_and_set_new_height): Rename from
3890         make_invisible_and_set_new_height.
3891         * tui/tui-data.h (struct tui_win_info)
3892         <make_invisible_and_set_new_height>: New method.
3893
3894 2019-07-17  Tom Tromey  <tom@tromey.com>
3895
3896         * tui/tui.c: Update.
3897         * tui/tui-source.h (struct tui_source_window): Move from
3898         tui-data.h.
3899         * tui/tui-layout.c: Update.
3900         * tui/tui-disasm.c: Update.
3901         * tui/tui-data.h (struct tui_source_window): Move to
3902         tui-source.h.
3903
3904 2019-07-17  Tom Tromey  <tom@tromey.com>
3905
3906         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3907         tui-data.h.
3908         * tui/tui-data.h (struct tui_disasm_window): Move to
3909         tui-disasm.h.
3910
3911 2019-07-17  Tom Tromey  <tom@tromey.com>
3912
3913         * tui/tui-regs.h (struct tui_data_item_window): Move from
3914         tui-data.h.
3915         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3916         * tui/tui-data.h (struct tui_data_item_window): Move to
3917         tui-regs.h.
3918         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3919
3920 2019-07-17  Tom Tromey  <tom@tromey.com>
3921
3922         * tui/tui.c: Update.
3923         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3924         (tui_cmd_window::max_height): Move to tui-command.c.
3925         * tui/tui-layout.c: Update.
3926         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3927         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3928         tui-command.c.
3929         * tui/tui-command.h (struct tui_cmd_window): Move from
3930         tui-data.h.
3931         * tui/tui-command.c: Remove "structuring" comments.
3932         (tui_cmd_window::clear_detail)
3933         (tui_cmd_window::do_make_visible_with_new_height)
3934         (tui_cmd_window::max_height): Move from elsewhere.
3935
3936 2019-07-17  Tom Tromey  <tom@tromey.com>
3937
3938         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3939         Now static.
3940         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3941         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3942
3943 2019-07-17  Tom Tromey  <tom@tromey.com>
3944
3945         * tui/tui.c: Update.
3946         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3947         tui-regs.c.
3948         * tui/tui-windata.h: Remove file.
3949         * tui/tui-windata.c: Remove file.
3950         * tui/tui-win.c (tui_data_window::set_new_height)
3951         (tui_data_window::do_make_visible_with_new_height): Move to
3952         tui-regs.c.
3953         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3954         * tui/tui-regs.c: Remove "structuring" comments.
3955         (tui_data_window::first_data_item_displayed)
3956         (tui_data_window::delete_data_content_windows)
3957         (tui_data_window::erase_data_content)
3958         (tui_data_window::display_all_data)
3959         (tui_data_window::refresh_all)
3960         (tui_data_window::do_scroll_vertical)
3961         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3962         (tui_data_window::do_make_visible_with_new_height)
3963         (tui_data_window::refresh_window): Move from elsewhere.
3964         (_initialize_tui_regs): Move to end of file.
3965         * tui/tui-layout.c: Update.
3966         * tui/tui-hooks.c: Update.
3967         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3968         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3969         tui-regs.c.
3970         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3971
3972 2019-07-17  Tom Tromey  <tom@tromey.com>
3973
3974         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3975         seen.
3976
3977 2019-07-17  Tom Tromey  <tom@tromey.com>
3978
3979         * tui/tui-win.c (tui_source_window_base::set_new_height)
3980         (tui_source_window_base::do_make_visible_with_new_height): Use
3981         m_has_locator field directly.
3982         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3983         method.
3984         (struct tui_source_window_base) <has_locator>: Likewise.
3985
3986 2019-07-17  Tom Tromey  <tom@tromey.com>
3987
3988         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3989         Don't declare.
3990         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3991         Remove.
3992         * tui/tui-win.c (tui_source_window_base::set_new_height)
3993         (tui_source_window_base::set_new_height)
3994         (make_invisible_and_set_new_height)
3995         (tui_source_window_base::do_make_visible_with_new_height)
3996         (tui_source_window_base::do_make_visible_with_new_height):
3997         Update.
3998         * tui/tui-layout.c (show_source_disasm_command, show_data)
3999         (show_source_or_disasm_and_command): Update.
4000         * tui/tui-layout.c (show_layout): Update.
4001
4002 2019-07-17  Tom Tromey  <tom@tromey.com>
4003
4004         * tui/tui-layout.c (make_data_window): Remove.
4005         (show_data): Unify creation and re-initialization cases.
4006
4007 2019-07-17  Tom Tromey  <tom@tromey.com>
4008
4009         * tui/tui-layout.c (make_source_window, make_disasm_window):
4010         Remove.
4011         (show_data): Unify creation and re-initialization cases.
4012
4013 2019-07-17  Tom Tromey  <tom@tromey.com>
4014
4015         * tui/tui-layout.c (make_command_window): Remove.
4016         (show_source_disasm_command, show_source_or_disasm_and_command):
4017         Unify creation and re-initialization cases.
4018
4019 2019-07-17  Tom Tromey  <tom@tromey.com>
4020
4021         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4022         creation and re-initialization cases.
4023
4024 2019-07-17  Tom Tromey  <tom@tromey.com>
4025
4026         * tui/tui-regs.c (tui_get_register): Return void.
4027
4028 2019-07-17  Tom Tromey  <tom@tromey.com>
4029
4030         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4031         Simplify.
4032
4033 2019-07-17  Tom Tromey  <tom@tromey.com>
4034
4035         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4036         resetting.
4037
4038 2019-07-17  Tom Tromey  <tom@tromey.com>
4039
4040         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4041         * tui/tui-regs.c (tui_reg_layout): New function.
4042         (tui_show_registers, tui_reg_command): Use it.
4043         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4044         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4045         parameters.
4046         (tui_layout_command): Remove.
4047
4048 2019-07-17  Tom Tromey  <tom@tromey.com>
4049
4050         * tui/tui-layout.h (tui/tui-layout): Return void.
4051         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4052
4053 2019-07-17  Tom Tromey  <tom@tromey.com>
4054
4055         * tui/tui-layout.c (show_source_disasm_command, show_data):
4056         Update.
4057         (reset_locator): Remove.
4058         (show_source_or_disasm_and_command): Update.
4059
4060 2019-07-17  Tom Tromey  <tom@tromey.com>
4061
4062         * tui/tui-source.c (tui_source_window_base::reset): Remove
4063         win_type parameter.
4064         * tui/tui-layout.c (make_command_window, make_source_window)
4065         (make_disasm_window, make_data_window)
4066         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4067         (reset_locator, show_source_or_disasm_and_command): Update.
4068         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4069         win_type parameter.
4070         (struct tui_source_window_base) <reset>: Likewise.
4071
4072 2019-07-17  Tom Tromey  <tom@tromey.com>
4073
4074         * tui/tui-layout.c (show_source_disasm_command): Use
4075         reset_locator.
4076         (reset_locator): New function.
4077         (init_and_make_win): Remove.
4078         (show_source_or_disasm_and_command): Use reset_locator.
4079
4080 2019-07-17  Tom Tromey  <tom@tromey.com>
4081
4082         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4083         condition.
4084         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4085         Remove condition.
4086         * tui/tui-source.c (tui_source_window_base::reset): New method.
4087         * tui/tui-layout.c (make_command_window): Don't call
4088         init_and_make_win.
4089         (make_source_window, make_disasm_window): Don't call
4090         make_source_or_disasm_window.
4091         (make_data_window): Don't call init_and_make_win.  Change calling
4092         convention.
4093         (show_source_disasm_command, show_data): Simplify.
4094         (make_source_or_disasm_window): Remove.
4095         (show_source_or_disasm_and_command): Simplify.
4096         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4097         (struct tui_source_window_base) <reset>: Likewise.
4098         <execution_info>: Remove initializer.
4099         * tui/tui-data.c (tui_source_window_base): Initialize
4100         execution_info.
4101
4102 2019-07-17  Tom Tromey  <tom@tromey.com>
4103
4104         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4105         variable.
4106
4107 2019-07-17  Tom Tromey  <tom@tromey.com>
4108
4109         * tui/tui.c (tui_rl_other_window): Update.
4110         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4111         superclass method first.  Always iterate over regs_content.
4112         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4113         method.
4114         * tui/tui-win.c (tui_set_focus_command): Update.
4115
4116 2019-07-17  Tom Tromey  <tom@tromey.com>
4117
4118         * tui/tui-win.c (tui_set_focus_command): Rename from
4119         tui_set_focus.  Call tui_enable.
4120         (tui_set_focus_command): Remove.
4121
4122 2019-07-17  Tom Tromey  <tom@tromey.com>
4123
4124         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4125         refresh_window.
4126         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4127         touchwin.
4128         (tui_data_window::refresh_window): Call refresh_window on data
4129         items.  Always call superclass refresh_window.
4130         (tui_win_info::refresh): Remove.
4131         (tui_source_window_base::refresh_window): Update.
4132         (tui_refresh_all): Update.
4133         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4134         refresh_window.
4135         (show_source_or_disasm_and_command): Likewise.
4136         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4137         (struct tui_source_window_base) <refresh>: Likewise.
4138
4139 2019-07-17  Tom Tromey  <tom@tromey.com>
4140
4141         * tui/tui-winsource.c (tui_clear_source_content)
4142         (tui_show_source_content): Update.
4143         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4144         whether content is empty.
4145         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4146         Remove.
4147
4148 2019-07-17  Tom Tromey  <tom@tromey.com>
4149
4150         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4151         window's contents.
4152         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4153         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4154
4155 2019-07-17  Tom Tromey  <tom@tromey.com>
4156
4157         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4158         (struct tui_data_item_window): Update.
4159
4160 2019-07-17  Tom Tromey  <tom@tromey.com>
4161
4162         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4163         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4164         defines.
4165
4166 2019-07-17  Tom Tromey  <tom@tromey.com>
4167
4168         * tui/tui-winsource.h (tui_erase_source_content)
4169         (tui_clear_source_content): Remove "display_prompt" parameter.
4170         * tui/tui-winsource.c (tui_update_source_window_as_is)
4171         (tui_update_source_windows_with_addr): Update.
4172         (tui_clear_source_content): Remove "display_prompt" parameter.
4173         (tui_erase_source_content): Likewise.  Simplify.
4174         (tui_show_source_content): Update.
4175         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4176         * tui/tui-stack.c (tui_show_frame_info): Update.
4177         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4178         Remove defines.
4179
4180 2019-07-17  Tom Tromey  <tom@tromey.com>
4181
4182         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4183         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4184         parameter.
4185         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4186         parameter.
4187
4188 2019-07-17  Tom Tromey  <tom@tromey.com>
4189
4190         * tui/tui-winsource.c (tui_clear_source_content)
4191         (tui_show_source_content, tui_show_exec_info_content)
4192         (tui_clear_exec_info_content): Update.
4193         * tui/tui-stack.c (tui_show_locator_content): Update.
4194         (tui_show_frame_info): Update.
4195         * tui/tui-source.h (tui_source_window): Don't declare.
4196         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4197         from tui_source_is_displayed.
4198         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4199         Remove field.
4200         (struct tui_source_window_base) <content_in_use>: New field.  Now
4201         bool.
4202         (struct tui_source_window) <showing_source_p>: New method.
4203         (TUI_SRC_WIN): Change cast.
4204         * tui/tui-data.c (tui_initialize_static_data): Update.
4205
4206 2019-07-17  Tom Tromey  <tom@tromey.com>
4207
4208         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4209         location_matches_p.
4210         * tui/tui-source.c (tui_source_window::location_matches_p): New
4211         method.
4212         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4213         method.
4214         * tui/tui-data.h (struct tui_source_window_base)
4215         <location_matches_p>: New method.
4216         (struct tui_source_window, struct tui_disasm_window)
4217         <location_matches_p>: Likewise.
4218
4219 2019-07-17  Tom Tromey  <tom@tromey.com>
4220
4221         * tui/tui-win.c (tui_set_win_height_command): Rename from
4222         tui_set_win_height.
4223         (tui_set_win_height_command): Remove.
4224
4225 2019-07-17  Tom Tromey  <tom@tromey.com>
4226
4227         * tui/tui-source.c (tui_source_window): New constructor.  Add
4228         observer.
4229         (~tui_source_window): New destructor.
4230         (tui_source_window::style_changed): New method.
4231         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4232         (tui_attach_detach_observers): Update.
4233         * tui/tui-data.h (struct tui_source_window): Make constructor not
4234         inline.  Add destructor.
4235         (struct tui_source_window) <style_changed>: New method.
4236         <m_observable>: New member.
4237
4238 2019-07-17  Tom Tromey  <tom@tromey.com>
4239
4240         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4241         * tui/tui-win.c (tui_resize_all): Fix typo.
4242
4243 2019-07-17  Tom Tromey  <tom@tromey.com>
4244
4245         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4246         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4247         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4248         * tui/tui-win.c (window_name_completer): Use foreach.
4249         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4250         (update_tab_width): Likewise.
4251         * tui/tui-layout.c (show_layout): Update.
4252         * tui/tui-data.h (class tui_window_iterator): New.
4253         (struct all_tui_windows): New.
4254         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4255
4256 2019-07-17  Tom Tromey  <tom@tromey.com>
4257
4258         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4259         parameter.  Don't reference globals.
4260         (tui_reg_command): Update.
4261
4262 2019-07-17  Tom Tromey  <tom@tromey.com>
4263
4264         * tui/tui-regs.c (tui_show_registers): Simplify.
4265
4266 2019-07-17  Tom Tromey  <tom@tromey.com>
4267
4268         * tui/tui-regs.c (tui_show_registers): Update.
4269         (tui_show_register_group): Add win_info parameter.
4270
4271 2019-07-17  Tom Tromey  <tom@tromey.com>
4272
4273         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4274         Rename from tui_display_reg_element_at_line.
4275         (tui_data_window::display_registers_from_line): Update.
4276         * tui/tui-data.h (struct tui_data_window)
4277         <display_reg_element_at_line>: New method.
4278
4279 2019-07-17  Tom Tromey  <tom@tromey.com>
4280
4281         * tui/tui-regs.h (tui_display_registers_from)
4282         (tui_display_registers_from_line): Don't declare.
4283         * tui/tui-windata.c (tui_data_window::display_all_data)
4284         (tui_data_window::refresh_all)
4285         (tui_data_window::do_scroll_vertical): Update.
4286         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4287         from tui_display_registers_from.
4288         (tui_display_reg_element_at_line): Update.
4289         (tui_data_window::display_registers_from_line): Rename from
4290         tui_display_registers_from_line.
4291         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4292         display_registers_from_line>: New methods.
4293
4294 2019-07-17  Tom Tromey  <tom@tromey.com>
4295
4296         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4297         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4298         from tui_erase_data_content.
4299         (tui_data_window::display_all_data)
4300         (tui_data_window::refresh_all)
4301         (tui_data_window::do_scroll_vertical): Update.
4302         * tui/tui-regs.c (tui_show_registers): Update.
4303         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4304         New method.
4305
4306 2019-07-17  Tom Tromey  <tom@tromey.com>
4307
4308         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4309         declare.
4310         * tui/tui-windata.c
4311         (tui_data_window::delete_data_content_windows): Rename from
4312         tui_delete_data_content_windows.
4313         (tui_data_window::display_all_data)
4314         (tui_data_window::do_scroll_vertical): Update.
4315         * tui/tui-data.h (struct tui_data_window)
4316         <delete_data_content_windows>: New method.
4317
4318 2019-07-17  Tom Tromey  <tom@tromey.com>
4319
4320         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4321         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4322
4323 2019-07-17  Tom Tromey  <tom@tromey.com>
4324
4325         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4326         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4327         from tui_display_all_data.
4328         * tui/tui-win.c
4329         (tui_data_window::do_make_visible_with_new_height): Update.
4330         * tui/tui-regs.c (tui_show_registers): Update.
4331         * tui/tui-layout.c (tui_set_layout): Update.
4332         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4333         method.
4334
4335 2019-07-17  Tom Tromey  <tom@tromey.com>
4336
4337         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4338         * tui/tui-windata.c (tui_display_data_from): Remove.
4339         (tui_data_window::refresh_all): Update.
4340
4341 2019-07-17  Tom Tromey  <tom@tromey.com>
4342
4343         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4344         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4345         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4346         tui_display_registers_from_line.
4347         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4348         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4349         "force_display" parameter.
4350
4351 2019-07-17  Tom Tromey  <tom@tromey.com>
4352
4353         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4354         declare.
4355         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4356         Rename from tui_first_reg_element_no_inline.
4357         (tui_display_reg_element_at_line)
4358         (tui_display_registers_from_line): Update.
4359         * tui/tui-data.h (struct tui_data_window)
4360         <first_reg_element_no_inline>: New method.
4361
4362 2019-07-17  Tom Tromey  <tom@tromey.com>
4363
4364         * tui/tui-windata.c (tui_display_data_from)
4365         (tui_data_window::do_scroll_vertical): Update.
4366         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4367         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4368         Rename from tui_line_from_reg_element_no.
4369         (tui_display_registers_from_line): Update.
4370         * tui/tui-data.h (struct tui_data_window)
4371         <line_from_reg_element_no>: New method.
4372
4373 2019-07-17  Tom Tromey  <tom@tromey.com>
4374
4375         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4376         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4377         tui_last_regs_line_no.
4378         (tui_display_reg_element_at_line)
4379         (tui_display_registers_from_line): Update.
4380         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4381         method.
4382
4383 2019-07-17  Tom Tromey  <tom@tromey.com>
4384
4385         PR tui/24722:
4386         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4387         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4388         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4389         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4390         (tui_update_breakpoint_info): Likewise.
4391         * tui/tui-hooks.c (tui_event_create_breakpoint)
4392         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4393         Update.
4394
4395 2019-07-17  Tom Tromey  <tom@tromey.com>
4396
4397         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4398
4399 2019-07-17  Tom Tromey  <tom@tromey.com>
4400
4401         * tui/tui-winsource.c (tui_update_source_window_as_is)
4402         (tui_update_source_windows_with_addr): Update.
4403         * tui/tui-source.h (tui_set_source_content)
4404         (tui_show_symtab_source): Add "win_info" parameter.
4405         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4406         parameter.
4407         (tui_show_symtab_source): Likewise.
4408
4409 2019-07-17  Tom Tromey  <tom@tromey.com>
4410
4411         * tui/tui-wingeneral.c
4412         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4413
4414 2019-07-17  Tom Tromey  <tom@tromey.com>
4415
4416         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4417         (struct tui_cmd_window) <can_scroll>: New method.
4418         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4419         method.
4420
4421 2019-07-17  Tom Tromey  <tromey@adacore.com>
4422
4423         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4424         do_field_signed>: Rename.  Change type of "value".
4425         * ui-out.c (ui_out::field_signed): Rename from field_int.
4426         Change type of "value".
4427         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4428         type of "value".
4429         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4430         do_field_int.  Change type of "value".
4431         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4432         do_field_int.  Change type of "value".
4433         * tracepoint.c (trace_status_mi, tfind_1)
4434         (print_one_static_tracepoint_marker): Update.
4435         * thread.c (print_thread_info_1, print_selected_thread_frame):
4436         Update.
4437         * stack.c (print_frame, print_frame_info): Update.
4438         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4439         Update.
4440         * source.c (print_source_lines_base): Update.
4441         * skip.c (info_skip_command): Update.
4442         * record-btrace.c (btrace_ui_out_decode_error)
4443         (btrace_call_history_src_line): Update.
4444         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4445         Update.
4446         * progspace.c (print_program_space): Update.
4447         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4448         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4449         do_field_int.  Change type of "value".
4450         * mi/mi-out.c (mi_ui_out::do_table_begin)
4451         (mi_ui_out::do_table_header): Update.
4452         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4453         type of "value".
4454         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4455         (mi_cmd_data_list_changed_registers, output_register)
4456         (mi_cmd_data_read_memory, mi_load_progress)
4457         (mi_cmd_trace_frame_collected): Update.
4458         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4459         Update.
4460         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4461         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4462         (mi_cmd_var_list_children, varobj_update_one): Update.
4463         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4464         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4465         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4466         * inferior.c (print_inferior): Update.
4467         * gdb_bfd.c (print_one_bfd): Update.
4468         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4469         Update.
4470         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4471         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4472         do_field_int.  Change type of "value".
4473         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4474         do_field_int.  Change type of "value".
4475         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4476         (print_one_breakpoint_location, print_it_catch_fork)
4477         (print_one_catch_fork, print_it_catch_vfork)
4478         (print_one_catch_vfork, print_it_catch_solib)
4479         (print_it_catch_exec, print_it_ranged_breakpoint)
4480         (print_mention_watchpoint, print_mention_masked_watchpoint)
4481         (bkpt_print_it, update_static_tracepoint): Update.
4482         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4483         * break-catch-syscall.c (print_it_catch_syscall): Update.
4484         * ada-tasks.c (print_ada_task_info): Update.
4485         * ada-lang.c (print_it_exception, print_mention_exception):
4486         Update.
4487
4488 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4489
4490         PR breakpoints/24541
4491         * gdbarch.c: Regenerate.
4492         * gdbarch.h: Regenerate.
4493         * gdbarch.sh: Adjust return type and parameter types for
4494         'stap_adjust_register'.
4495         (i386_stap_adjust_register): Adjust signature and return new
4496         register name.
4497         * stap-probe.c (stap_parse_register_operand): Adjust use of
4498         'gdbarch_stap_adjust_register'.
4499
4500 2019-07-17  Tom Tromey  <tromey@adacore.com>
4501
4502         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4503         declare VEC.
4504         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4505         std::vector.
4506         (struct s390_process_info): Add initializers.
4507         (s390_add_process): Use new.
4508         (s390_linux_nat_target::low_forget_process): Use delete.
4509         (s390_linux_nat_target::low_new_fork)
4510         (s390_linux_nat_target::stopped_by_watchpoint)
4511         (s390_linux_nat_target::low_prepare_to_resume)
4512         (s390_linux_nat_target::insert_watchpoint)
4513         (s390_linux_nat_target::insert_hw_breakpoint)
4514         (s390_linux_nat_target::remove_watchpoint)
4515         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4516
4517 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4518
4519         * aarch64-fbsd-nat.c: Include regcache.h.
4520         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4521         argument.
4522         (aarch64_fbsd_nat_target::fetch_registers)
4523         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4524         variable.
4525         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4526
4527 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4528
4529         * fbsd-nat.c: Include gdbarch.h.
4530
4531 2019-07-15  Tom Tromey  <tromey@adacore.com>
4532
4533         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4534
4535 2019-07-15  Tom Tromey  <tromey@adacore.com>
4536
4537         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4538         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4539         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4540         * cli-out.c (cli_ui_out::do_field_int): New method.
4541         * ui-out.c (ui_out::field_unsigned): New method.
4542         * symfile.c (generic_load): Use field_unsigned.
4543         (print_transfer_performance): Likewise.
4544         * record-btrace.c (ui_out_field_uint): Remove.
4545         (btrace_call_history_insn_range, btrace_call_history): Use
4546         field_unsigned.
4547         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4548         field_unsigned.
4549         * ui-out.h (class ui_out) <field_unsigned>: New method.
4550         <do_field_unsigned>: Likewise.
4551
4552 2019-07-15  Tom Tromey  <tromey@adacore.com>
4553
4554         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4555         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4556         * target.c (flash_erase_command): Use field_string.
4557         * infrun.c (print_signal_received_reason): Use field_string.
4558         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4559         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4560         field_string.
4561         * ada-tasks.c (print_ada_task_info): Use field_string.
4562
4563 2019-07-15  Tom Tromey  <tromey@adacore.com>
4564
4565         * target.c (flash_erase_command): Use field_core_addr.
4566         * symfile.c (generic_load): Use field_core_addr.
4567         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4568         Use field_core_addr.
4569         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4570         field_core_addr.
4571
4572 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4573
4574         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4575         value if its desired type is smaller than a CORE_ADDR and signed.
4576
4577 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4578
4579         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4580         of changes to field names, and use new is_reference field to
4581         decide if a property is a reference or not.
4582         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4583         field.
4584         (struct dwarf2_property_baton): Update header comment, rename
4585         'referenced_type' to 'property_type' and update comments.
4586         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4587         default property type, store in property baton, update to take
4588         accound of renamed field.
4589         (read_func_scope): Update call to attr_to_dynamic_prop.
4590         (read_array_type): Likewise.
4591         (dwarf2_per_cu_addr_sized_int_type): New function.
4592         (read_subrange_index_type): Move type finding code to
4593         dwarf2_per_cu_addr_sized_int_type.
4594         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4595         (dwarf2_per_cu_addr_type): New function.
4596         (set_die_type): Update calls to attr_to_dynamic_prop.
4597
4598 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4599
4600         * dwarf2read.c (read_subrange_index_type): New function.
4601         (read_subrange_type): Move code into new function and call it.
4602         * gdbtypes.c (create_range_type): Add some asserts.
4603
4604 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4605
4606         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4607         update return statements.
4608         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4609         declaration, and update comment to match.
4610         * gdbtypes.c (resolve_dynamic_array): Update call to
4611         dwarf2_evaluate_property to match new return type.
4612
4613 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4614
4615         * valarith.c (value_subscripted_rvalue): Change lowerbound
4616         parameter type from int to LONGEST.
4617         * value.h (value_subscripted_rvalue): Likewise in declaration.
4618
4619 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4620
4621         * cli/cli-utils.c (info_print_command_completer): New function.
4622         * cli/cli-utils.h: Add 'completer.h' include, and forward
4623         declaration for 'struct cmd_list_element'.
4624         (info_print_command_completer): Declare.
4625         * stack.c (_initialize_stack): Add completer for 'info locals' and
4626         'info args'.
4627         * symtab.c (_initialize_symtab): Add completer for 'info
4628         variables' and 'info functions'.
4629         * NEWS: Mention completion for additional info commands.
4630
4631 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4632
4633         * cli/cli-utils.c (extract_info_print_args): Delete.
4634         (extract_arg_maybe_quoted): Delete.
4635         (info_print_options_defs): New variable.
4636         (make_info_print_options_def_group): New function.
4637         (extract_info_print_options): Define new function.
4638         * cli/cli-utils.h (extract_info_print_args): Delete.
4639         (struct info_print_options): New structure.
4640         (extract_info_print_options): Declare new function.
4641         * stack.c (info_locals_command): Update to use new
4642         extract_info_print_options, also add a header comment.
4643         (info_args_command): Likewise.
4644         * symtab.c (info_variables_command): Likewise.
4645         (info_functions_command): Likewise.
4646
4647 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4648
4649         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4650         to extract string arguments.
4651         * common/common-utils.c (extract_string_maybe_quoted): New function.
4652         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4653
4654 2019-07-11  Tom Tromey  <tromey@adacore.com>
4655
4656         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4657         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4658         * top.h (gdbinit): Don't declare.
4659         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4660         into...
4661         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4662         * top.c (gdb_init): Don't call init_cli_cmds.
4663         (gdbinit): Remove.
4664         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4665
4666 2019-07-11  Tom Tromey  <tromey@adacore.com>
4667
4668         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4669         after it has been moved.
4670
4671 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4672
4673         * valops.c (value_must_coerce_to_target): Change return type to
4674         bool.
4675         * value.h (value_must_coerce_to_target): Likewise.
4676
4677 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4678
4679         * breakpoint.c (is_hardware_watchpoint): Remove
4680         forward-declaration.
4681         (is_masked_watchpoint): Change return type to bool.
4682         (is_tracepoint): Likewise.
4683         (is_breakpoint): Likewise.
4684         (is_hardware_watchpoint): Likewise.
4685         (is_watchpoint): Likewise.
4686         (is_no_memory_software_watchpoint): Likewise.
4687         (is_catchpoint): Likewise.
4688         (breakpoint_1): Make FILTER parameter's return type bool.
4689         is_masked_watchpoint): Change return type to bool.
4690         (save_breakpoints): Make FILTER parameter's return type bool.
4691         * breakpoint.h (is_breakpoint): Change return type to bool.
4692         (is_watchpoint): Likewise.
4693         (is_catchpoint): Likewise.
4694         (is_tracepoint): Likewise.
4695
4696 2019-07-10  Tom Tromey  <tom@tromey.com>
4697
4698         * defs.h: Don't include gdbarch.h.
4699         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4700         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4701         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4702         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4703         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4704         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4705         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4706         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4707         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4708         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4709         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4710         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4711         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4712         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4713         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4714         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4715         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4716         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4717         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4718         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4719         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4720         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4721         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4722         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4723         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4724         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4725         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4726
4727 2019-07-10  Tom Tromey  <tromey@adacore.com>
4728
4729         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4730         * breakpoint.c (init_ada_exception_breakpoint): Register as
4731         bp_catchpoint.
4732         (print_one_breakpoint_location, print_one_breakpoint): Use
4733         is_ada_exception_catchpoint.
4734         * ada-lang.c (class ada_catchpoint_location): Pass
4735         bp_loc_software_breakpoint to bp_location constructor.
4736         (is_ada_exception_catchpoint): New function.
4737
4738 2019-07-10  Tom Tromey  <tromey@adacore.com>
4739
4740         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4741         VEC.
4742         (struct arm_exidx_entry): New method operator<.
4743         (struct arm_exidx_data) <section_maps>: Change type.
4744         (arm_exidx_data_free): Remove.
4745         (arm_exidx_data_key): Change type.  Move lower.
4746         (arm_exidx_new_objfile): Update.
4747         (arm_compare_exidx_entries): Remove.
4748         (arm_find_exidx_entry, _initialize_arm_tdep)
4749
4750 2019-07-10  Tom Tromey  <tromey@adacore.com>
4751
4752         * solib-spu.c (ocl_program_data_key): Change type.
4753         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4754         Update.
4755
4756 2019-07-10  Tom Tromey  <tromey@adacore.com>
4757
4758         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4759         (struct solib_aix_inferior_data) <library_list>: Change type.
4760         (solib_aix_inferior_data_handle): Change type.
4761         (get_solib_aix_inferior_data): Update.
4762         (solib_aix_free_library_list): Remove.
4763         (library_list_start_library): Update.
4764         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4765         return type.
4766         (solib_aix_get_library_list)
4767         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4768         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4769
4770 2019-07-10  Tom Tromey  <tromey@adacore.com>
4771
4772         * solib-dsbt.c (struct dsbt_info): Add initializers.
4773         (solib_dsbt_pspace_data): Change type.
4774         (dsbt_pspace_data_cleanup): Remove.
4775         (get_dsbt_info, _initialize_dsbt_solib): Update.
4776
4777 2019-07-10  Tom Tromey  <tromey@adacore.com>
4778
4779         * spu-tdep.c (spu_overlay_data): Change type.
4780         (spu_get_overlay_table, spu_overlay_new_objfile)
4781         (_initialize_spu_tdep): Update.
4782
4783 2019-07-10  Tom Tromey  <tromey@adacore.com>
4784
4785         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4786         destructor.
4787         (dbx_objfile_data_key): Change type and declare later.
4788         (DBX_SYMFILE_INFO): Rewrite.
4789         * dbxread.c (dbx_objfile_data_key): Change type.
4790         (dbx_symfile_init): Update.
4791         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4792         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4793         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4794
4795 2019-07-10  Tom Tromey  <tromey@adacore.com>
4796
4797         * jit.c (jit_program_space_key): Change type.  Move lower.
4798         (get_jit_program_space_data): Update.
4799         (jit_program_space_data_cleanup): Remove.
4800         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4801         Update.
4802         (struct jit_program_space_data): Add initializers.
4803
4804 2019-07-10  Tom Tromey  <tromey@adacore.com>
4805
4806         * solib-darwin.c (struct darwin_info): Add initializers.
4807         (solib_darwin_pspace_data): Change type.
4808         (darwin_pspace_data_cleanup): Remove.
4809         (get_darwin_info, _initialize_darwin_solib): Update.
4810
4811 2019-07-10  Tom Tromey  <tromey@adacore.com>
4812
4813         * remote-sim.c (struct sim_inferior_data): Add initializers,
4814         constructor, and destructor.
4815         (sim_inferior_data_key): Change type.  Move lower.
4816         (check_for_duplicate_sim_descriptor): Update.
4817         (get_sim_inferior_data): Use new.  Update.
4818         (~sim_inferior_data_cleanup): Rename from
4819         sim_inferior_data_cleanup.  Simplify.
4820         (gdbsim_close_inferior, simulator_command)
4821         (sim_command_completer, _initialize_remote_sim): Update.
4822         (next_pid, INITIAL_PID): Move earlier.
4823
4824 2019-07-10  Tom Tromey  <tromey@adacore.com>
4825
4826         * python/python-internal.h (create_thread_object): Return
4827         gdbpy_ref.
4828         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4829         * python/py-inferior.c (struct threadlist_entry): Add
4830         constructor.
4831         <thread_obj>: Now a gdbpy_ref.
4832         (thread_to_thread_object): Update.
4833         (add_thread_object): Use new.
4834         (delete_thread_object): Use delete.
4835         (infpy_threads): Update.
4836         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4837         GIL.
4838
4839 2019-07-10  Tom Tromey  <tromey@adacore.com>
4840
4841         * valops.c (value_cast): Specialize error message for Ada.
4842
4843 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4844
4845         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4846
4847 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4848
4849         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4850         bpstat_should_step): Return bool, adjust comments.
4851         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4852         bpstat_should_step): Likewise.
4853
4854 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4855
4856         * features/Makefile: Use feature target descriptions for Arm.
4857         * features/arm/arm-core.c: Generate new file.
4858         * features/arm/arm-fpa.c: Likewise.
4859         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4860         * features/arm/arm-m-profile.c: Likewise.
4861         * features/arm/arm-vfpv2.c: Likewise.
4862         * features/arm/arm-vfpv3.c: Likewise.
4863         * features/arm/xscale-iwmmxt.c: Likewise.
4864         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4865
4866 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4867
4868         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4869         ptrace earlier.
4870
4871 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4872
4873         * features/aarch64-pauth.c: Regenerate.
4874
4875 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4876
4877         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4878         bool.
4879         (bpstat_what): Use false instead of 0.
4880
4881 2019-07-09  Pedro Alves  <palves@redhat.com>
4882
4883         * break-catch-throw.c (is_exception_catchpoint): New.
4884         * breakpoint.c (print_one_breakpoint_location): New parameter
4885         'raw_loc'.  Handle it.  Use
4886         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4887         looking at the breakpoint's type.
4888         (print_one_breakpoint): If handling "maint info breakpoints", also
4889         print locations of exception catchpoints.
4890         * breakpoint.h (is_exception_catchpoint): Declare.
4891
4892 2019-07-09  Pedro Alves  <palves@redhat.com>
4893
4894         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4895         "addr" field.
4896         (allocate_location_exception_catchpoint): New.
4897         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4898         (initialize_throw_catchpoint_ops): Install
4899         allocate_location_exception_catchpoint as allocate_location
4900         method.
4901         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4902         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4903         bp_loc_other.
4904         (breakpoint_address_is_meaningful): Delete.
4905         (bl_address_is_meaningful): New.
4906         (breakpoint_locations_match): Adjust comment.
4907         (bp_location_from_bp_type): New, factored out of...
4908         (bp_location::bp_location(breakpoint *)): ... this.
4909         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4910         factored out of...
4911         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4912         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4913         breakpoint_address_is_meaningful.
4914         (bp_locations_compare): Adjust comment.
4915         (update_global_location_list): Use bl_address_is_meaningful
4916         instead of breakpoint_address_is_meaningful.
4917         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4918         explicit.
4919         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4920         * python/py-breakpoint.c (bppy_get_location): No longer check
4921         whether location is null.
4922
4923 2019-07-09  Pedro Alves  <palves@redhat.com>
4924
4925         PR c++/15468
4926         * breakpoint.c (print_one_breakpoint_location): Remove
4927         single-location assert.
4928
4929 2019-07-09  Tom Tromey  <tom@tromey.com>
4930
4931         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4932         * configure: Rebuild.
4933         * configure.ac: Change common to gdbsupport.
4934         * gdbsupport: Rename from common.
4935         * acinclude.m4: Change common to gdbsupport.
4936         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4937         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4938         gdbsupport.
4939         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4940         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4941         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4942         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4943         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4944         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4945         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4946         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4947         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4948         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4949         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4950         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4951         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4952         coff-pe-read.c, command.h, compile/compile-c-support.c,
4953         compile/compile-c.h, compile/compile-cplus-symbols.c,
4954         compile/compile-cplus-types.c, compile/compile-cplus.h,
4955         compile/compile-loc2c.c, compile/compile.c, completer.c,
4956         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4957         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4958         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4959         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4960         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4961         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4962         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4963         features/aarch64-core.c, features/aarch64-fpu.c,
4964         features/aarch64-pauth.c, features/aarch64-sve.c,
4965         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4966         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4967         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4968         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4969         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4970         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4971         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4972         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4973         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4974         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4975         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4976         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4977         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4978         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4979         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4980         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4981         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4982         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4983         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4984         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4985         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4986         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4987         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4988         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4989         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4990         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4991         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4992         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4993         minsyms.c, mips-linux-tdep.c, namespace.h,
4994         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4995         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4996         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4997         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4998         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4999         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5000         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5001         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5002         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5003         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5004         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5005         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5006         procfs.c, producer.c, progspace.h, psymtab.h,
5007         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5008         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5009         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5010         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5011         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5012         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5013         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5014         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5015         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5016         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5017         target-memory.c, target.c, target.h, target/waitstatus.c,
5018         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5019         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5020         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5021         unittests/array-view-selftests.c,
5022         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5023         unittests/common-utils-selftests.c,
5024         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5025         unittests/format_pieces-selftests.c,
5026         unittests/function-view-selftests.c,
5027         unittests/lookup_name_info-selftests.c,
5028         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5029         unittests/mkdir-recursive-selftests.c,
5030         unittests/observable-selftests.c,
5031         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5032         unittests/parse-connection-spec-selftests.c,
5033         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5034         unittests/scoped_fd-selftests.c,
5035         unittests/scoped_mmap-selftests.c,
5036         unittests/scoped_restore-selftests.c,
5037         unittests/string_view-selftests.c, unittests/style-selftests.c,
5038         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5039         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5040         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5041         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5042         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5043         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5044
5045 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5046
5047         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5048         bool value.
5049         (decode_digits_ordinary): Set explicit_line field in sal.
5050         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5051         symtab_and_line that was set on an explicit line number in
5052         assembler code.  Do always update the recorded symtab and line if
5053         we do skip the prologue.
5054
5055 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5056
5057         * breakpoint.c (set_breakpoint_location_function): Remove
5058         explicit_loc parameter.
5059         (momentary_breakpoint_from_master): Update call to
5060         set_breakpoint_location_function.
5061         (add_location_to_breakpoint): Likewise.
5062
5063 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5064
5065         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5066         required features based on default bfd type when no specific bfd
5067         is present.
5068
5069 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5070
5071         * NEWS: Mention that GDB printf and eval commands can now print
5072         C-style and Ada-style convenience var strings without
5073         calling the inferior.
5074         * printcmd.c (printf_c_string): Locally print GDB internal var
5075         instead of transiting via the inferior.
5076         (printf_wide_c_string): Likewise.
5077
5078 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5079
5080         PR breakpoints/25011
5081         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5082
5083 2019-07-04  Tom Tromey  <tom@tromey.com>
5084
5085         PR tui/24724:
5086         * tui/tui-winsource.c (tui_clear_source_content): Update.
5087         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5088         (tui_update_breakpoint_info): Update.
5089         (tui_set_exec_info_content): Update.
5090         * tui/tui-source.c (tui_set_source_content_nil): Update.
5091         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5092         has_break.
5093         * tui/tui-data.h (enum tui_bp_flag): New.
5094         (tui_bp_flags): New enum flags type.
5095         (struct tui_source_element) <break_mode>: Change type.  Rename
5096         from has_break.
5097         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5098         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5099         constants.
5100         * tui/tui-winsource.h: Fix comment.
5101
5102 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5103
5104         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5105         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5106         (store_fpregs_to_thread)
5107         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5108         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5109         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5110         (IWMMXT_REGS_SIZE): Add define.
5111         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5112         (fetch_vfp_regs, store_vfp_regs)
5113         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5114         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5115
5116 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5117
5118         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5119         defines.
5120         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5121         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5122         (ARM_INT_REGISTER_SIZE): ...to this.
5123         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5124         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5125         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5126         (arm_linux_collect_gregset, supply_nwfpe_register)
5127         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5128         defines.
5129         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5130         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5131         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5132         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5133         (arm_return_in_memory, arm_store_return_value)
5134         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5135         (arm_record_ld_st_multiple): Likewise.
5136         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5137         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5138
5139 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5140
5141         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5142         AARCH64_DISPLACED_MODIFIED_INSNS.
5143         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5144         (aarch64_displaced_step_copy_insn): Likewise.
5145         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5146         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5147         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5148         ARM_DISPLACED_MODIFIED_INSNS.
5149         * arm-tdep.c (arm_gdbarch_init): Likewise.
5150         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5151         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5152         (struct arm_displaced_step_closure): Use
5153         ARM_DISPLACED_MODIFIED_INSNS.
5154
5155 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5156
5157         * features/Makefile: Remove unused xml files.
5158         * features/aarch64.xml: Remove.
5159         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5160         * features/i386/amd64-avx-avx512.xml: Remove.
5161         * features/i386/amd64-avx-linux.xml: Remove.
5162         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5163         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5164         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5165         * features/i386/amd64-avx-mpx.xml: Remove.
5166         * features/i386/amd64-avx.xml: Remove.
5167         * features/i386/amd64-linux.xml: Remove.
5168         * features/i386/amd64-mpx-linux.xml: Remove.
5169         * features/i386/amd64-mpx.xml: Remove.
5170         * features/i386/amd64.xml: Remove.
5171         * features/i386/i386-avx-avx512-linux.xml: Remove.
5172         * features/i386/i386-avx-avx512.xml: Remove.
5173         * features/i386/i386-avx-linux.xml: Remove.
5174         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5175         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5176         * features/i386/i386-avx-mpx-linux.xml: Remove.
5177         * features/i386/i386-avx-mpx.xml: Remove.
5178         * features/i386/i386-avx.xml: Remove.
5179         * features/i386/i386-linux.xml: Remove.
5180         * features/i386/i386-mmx-linux.xml: Remove.
5181         * features/i386/i386-mmx.xml: Remove.
5182         * features/i386/i386-mpx-linux.xml: Remove.
5183         * features/i386/i386-mpx.xml: Remove.
5184         * features/i386/i386.xml: Remove.
5185         * features/i386/x32-avx-avx512-linux.xml: Remove.
5186         * features/i386/x32-avx-linux.xml: Remove.
5187         * features/i386/x32-linux.xml: Remove.
5188
5189 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5190
5191         * regformats/aarch64.dat: Remove.
5192         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5193         * regformats/i386/amd64-avx-linux.dat: Remove.
5194         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5195         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5196         * regformats/i386/amd64-linux.dat: Remove.
5197         * regformats/i386/amd64-mpx-linux.dat: Remove.
5198         * regformats/i386/amd64.dat: Remove.
5199         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5200         * regformats/i386/i386-avx-linux.dat: Remove.
5201         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5202         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5203         * regformats/i386/i386-linux.dat: Remove.
5204         * regformats/i386/i386-mmx-linux.dat: Remove.
5205         * regformats/i386/i386-mpx-linux.dat: Remove.
5206         * regformats/i386/i386.dat: Remove.
5207         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5208         * regformats/i386/x32-avx-linux.dat: Remove.
5209         * regformats/i386/x32-linux.dat: Remove.
5210
5211 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5212
5213         * aarch64-tdep.c: Remove xml self tests.
5214         * amd64-linux-tdep.c: Likewise.
5215         * amd64-tdep.c: Likewise.
5216         * i386-linux-tdep.c: Likewise.
5217         * i386-tdep.c: Likewise.
5218
5219 2019-07-03  Pedro Alves  <palves@redhat.com>
5220
5221         PR cli/24732
5222         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5223         (pipe_cmd_option_defs): New.
5224         (make_pipe_cmd_options_def_group): New.
5225         (pipe_command): Use gdb::option::process_options.
5226         (pipe_command_completer): New function.
5227         (_initialize_cli_cmds): Install completer for "pipe" command.
5228
5229 2019-07-03  Pedro Alves  <palves@redhat.com>
5230
5231         * cli/cli-option.c (union option_value) <string>: New field.
5232         (struct option_def_and_value): Add ctor, move ctor, dtor and
5233         use DISABLE_COPY_AND_ASSIGN.
5234         (option_def_and_value::clear_value): New.
5235         (parse_option, save_option_value_in_ctx, get_val_type_str)
5236         (add_setshow_cmds_for_options): Handle var_string.
5237         * cli-option.h (union option_def::var_address) <string>: New
5238         field.
5239         (struct string_option_def): New.
5240         * maint-test-options.c (struct test_options_opts): Add default
5241         ctor and use DISABLE_COPY_AND_ASSIGN.
5242         <string_opt>: New field.
5243         (test_options_opts::~test_options_opts): New.
5244         (test_options_opts::dump): Also dump "-string".
5245         (test_options_option_defs): Install "string.
5246
5247 2019-07-03  Pedro Alves  <palves@redhat.com>
5248
5249         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5250         option_value with a null enumeration.
5251         (complete_options): Save the option values in the context.
5252         (save_option_value_in_ctx): New, factored out from ...
5253         (process_options): ... here.
5254         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5255         of the function.
5256         * maint-test-options.c (test_options_opts::dump): New, factored
5257         out from ...
5258         (maintenance_test_options_command_mode): ... here.
5259         (maintenance_test_options_command_completion_result): Delete.
5260         (maintenance_test_options_command_completion_text): Update
5261         comment.
5262         (maintenance_show_test_options_completion_result): Change
5263         prototype.  Just print
5264         maintenance_test_options_command_completion_text.
5265         (save_completion_result): New.
5266         (maintenance_test_options_completer_mode): Pass options context to
5267         complete_options, and then save a dump.
5268         (_initialize_maint_test_options): Use add_cmd to install "maint
5269         show test-options-completion-result".
5270
5271 2019-07-03  Pedro Alves  <palves@redhat.com>
5272
5273         * NEWS (New commands): Mention "with" and "maint with".
5274         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5275         (with_command, with_command_completer): New.
5276         (pipe_command): Adjust to new repeat_previous
5277         interface.
5278         (_initialize_cli_cmds): Install the "with" command and its "w"
5279         alias.
5280         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5281         declarations.
5282         * cli/cli-setshow.c (parse_cli_var_uinteger)
5283         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5284         argument strings for all var_types.
5285         (get_setshow_command_value_string): New, factored out from ...
5286         (do_show_command): ... this.
5287         * cli/cli-setshow.h: Include <string>.
5288         (get_setshow_command_value_string): Declare.
5289         * command.h (repeat_previous): Now returns const char *.  Adjust
5290         comment.
5291         * maint.c: Include "cli/cli-cmds.h".
5292         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5293         (_initialize_maint_cmds): Register the "maintenance with" command.
5294         * top.c (repeat_previous): Move bits from pipe_command here:
5295         Return the saved command line, if any; error out if there's no
5296         command to relaunch.
5297
5298 2019-07-03  Pedro Alves  <palves@redhat.com>
5299
5300         * NEWS (New commands): Mention "maint set/show test-settings"
5301         instead of "maint test-settings".
5302         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5303         (maintenance_test_settings_set_list): Rename to ...
5304         (maintenance_set_test_settings_list): ... this.
5305         (maintenance_test_settings_show_list): Rename to  ...
5306         (maintenance_show_test_settings_list): ... this.
5307         (maintenance_test_settings_cmd): Delete.
5308         (maintenance_test_settings_set_cmd): ...
5309         (maintenance_set_test_settings_cmd): ... this.
5310         (maintenance_test_settings_show_cmd): ...
5311         (maintenance_show_test_settings_cmd): ... this.
5312         (maintenance_test_settings_show_value_cmd):
5313         (maintenance_show_test_settings_value_cmd): ... this.
5314         (_initialize_maint_test_settings): No longer install the "maint
5315         test-settings" prefix command.  Rename "maint test-settings set"
5316         to "maint set test-settings", and "maint test-settings show" to
5317         "maint show test-settings".  Adjust all subcommands.
5318
5319 2019-07-03  Pedro Alves  <palves@redhat.com>
5320
5321         * maint-test-settings.c: Fix file's intro comment.  Replace all
5322         references to "test-options" with references to "test-settings",
5323         in comments.
5324
5325 2019-07-03  Pedro Alves  <palves@redhat.com>
5326
5327         * maint-test-settings.c (maintenance_test_settings_xxx)
5328         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5329         New.
5330         (maintenance_test_settings_enums): Use them.
5331         (maintenance_test_settings_enum): Default to
5332         maintenance_test_settings_xxx.
5333         (_initialize_maint_test_settings): Initialize
5334         MAINTENANCE_TEST_SETTINGS_FILENAME.
5335
5336 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5337
5338         * breakpoint.h (remove_breakpoints_inf): Change return type to
5339         void, move function documentation here.
5340         * breakpoint.c (remove_breakpoints_inf): Change return type to
5341         void, move function documentation to header.
5342
5343 2019-07-02  Pedro Alves  <palves@redhat.com>
5344
5345         * NEWS (Completion improvements): Mention "info threads".
5346         * thread.c (struct info_threads_opts, info_threads_option_defs)
5347         (make_info_threads_options_def_group): New.
5348         (info_threads_command): Use gdb::option::process_options.
5349         (info_threads_command_completer): New.
5350         (_initialize_thread): Use gdb::option::build_help to build the
5351         help text for "info threads".
5352
5353 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5354
5355         * defs.h (generic_load): Move from here...
5356         * symfile.h (generic_load): ... to here.  Rename name parameter
5357         to args.
5358         * symfile.c (generic_load): Add comment.
5359
5360 2019-07-01  Tom Tromey  <tromey@adacore.com>
5361
5362         * dwarf2read.c
5363         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5364         declaration of without_params.  Fix formatting.
5365
5366 2019-07-01  Tom Tromey  <tromey@adacore.com>
5367
5368         * ada-exp.y (find_primitive_type): Update.
5369         * ada-lang.h (ada_lookup_symbol): Update.
5370         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5371         parameter.
5372         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5373
5374 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5375
5376         PR breakpoints/24541
5377         * gdbarch.c: Regenerate.
5378         * gdbarch.h: Regenerate.
5379         * gdbarch.sh: Add 'stap_adjust_register'.
5380         * i386-tdep.c: Include '<unordered_set>'.
5381         (i386_stap_adjust_register): New function.
5382         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5383         * stap-probe.c (stap_parse_register_operand): Call
5384         'gdbarch_stap_adjust_register'.
5385
5386 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5387
5388         PR python/24742
5389         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5390         * python/python.c (do_start_initialization): Use 'xmalloc'
5391         instead of 'PyMem_Malloc'.
5392
5393 2019-06-28  Tom Tromey  <tromey@adacore.com>
5394
5395         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5396         for Ada.
5397
5398 2019-06-27  Tom Tromey  <tromey@adacore.com>
5399
5400         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5401         objfile_key.
5402         (arm_find_mapping_symbol, arm_record_special_symbol)
5403         (_initialize_arm_tdep): Update.
5404         (arm_objfile_data_free): Remove.
5405
5406 2019-06-27  Tom Tromey  <tromey@adacore.com>
5407
5408         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5409         to cp_print_static_field.
5410
5411 2019-06-26  Tom Tromey  <tromey@adacore.com>
5412
5413         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5414         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5415         declare.
5416
5417 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5418
5419         * features/aarch64-core.c (create_feature_aarch64_core):
5420         Regenerate.
5421         * features/aarch64-core.xml: Add cpsr flags.
5422
5423 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5424
5425         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5426         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5427
5428 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5429
5430         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5431         field.
5432         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5433         use.
5434         (arm_record_special_symbol): Don't insert new symbol in sorted
5435         position, push it at the end.
5436
5437 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5438
5439         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5440         (arm_mapping_symbol_s): Remove.
5441         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5442         (arm_mapping_symbol_vec): New typedef.
5443         (struct arm_per_objfile): Add constructor.
5444         <section_maps>: Change type to
5445         std::unique_ptr<arm_mapping_symbol_vec[]>.
5446         (arm_compare_mapping_symbols): Remove.
5447         (arm_find_mapping_symbol): Adjust to section_maps type change.
5448         (arm_objfile_data_free): Call delete on arm_per_objfile.
5449         (arm_record_special_symbol): Adjust to section_maps type change.
5450         Allocate arm_per_objfile with new.
5451
5452 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5453
5454         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5455         with the command prefix.
5456
5457 2019-06-25  Tom Tromey  <tom@tromey.com>
5458
5459         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5460         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5461
5462 2019-06-25  Tom Tromey  <tom@tromey.com>
5463
5464         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5465         type.
5466         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5467         protected.
5468
5469 2019-06-25  Tom Tromey  <tom@tromey.com>
5470
5471         * tui/tui-winsource.c
5472         (tui_source_window_base::set_is_exec_point_at): Add check against
5473         LOA_ADDRESS.
5474
5475 2019-06-25  Tom Tromey  <tom@tromey.com>
5476
5477         * tui/tui-source.c (tui_set_source_content): Don't check before
5478         xfree.
5479         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5480
5481 2019-06-25  Tom Tromey  <tom@tromey.com>
5482
5483         * tui/tui-winsource.h (tui_update_source_window_as_is)
5484         (tui_alloc_source_buffer, tui_line_is_displayed)
5485         (tui_addr_is_displayed): Change type of win_info.
5486         * tui/tui-winsource.c (tui_update_source_window_as_is)
5487         (tui_clear_source_content, tui_show_source_line)
5488         (tui_show_source_content, tui_source_window_base::refill)
5489         (tui_source_window_base::set_is_exec_point_at)
5490         (tui_source_window_base::set_is_exec_point_at)
5491         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5492         (tui_alloc_source_buffer, tui_line_is_displayed)
5493         (tui_addr_is_displayed): Change type of win_info.  Update.
5494         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5495         (tui_source_window_base::do_make_visible_with_new_height):
5496         Update.
5497         * tui/tui-source.c (tui_set_source_content)
5498         (tui_set_source_content_nil)
5499         (tui_source_window::do_scroll_vertical): Update.
5500         * tui/tui-layout.c (show_layout): Update.
5501         * tui/tui-disasm.c (tui_set_disassem_content)
5502         (tui_disasm_window::do_scroll_vertical): Update.
5503         * tui/tui-data.h (tui_win_content): Remove.
5504         (struct tui_gen_win_info) <content, content_size>: Remove.
5505         (struct tui_source_element): Add initializers and destructor.
5506         (union tui_which_element, struct tui_win_element): Remove.
5507         (struct tui_source_window_base) <content>: New field.
5508         (struct tui_data_window): Remove destructor.
5509         (tui_alloc_content, tui_free_win_content)
5510         (tui_free_all_source_wins_content): Don't declare.
5511         * tui/tui-data.c (tui_initialize_static_data): Update.
5512         (init_content_element, tui_alloc_content): Remove.
5513         (~tui_gen_win_info): Update.
5514         (~tui_data_window, tui_free_all_source_wins_content)
5515         (tui_free_win_content, free_content, free_content_elements):
5516         Remove.
5517
5518 2019-06-25  Tom Tromey  <tom@tromey.com>
5519
5520         * tui/tui-winsource.h (tui_clear_source_content)
5521         (tui_erase_source_content, tui_show_source_content): Change type
5522         of win_info.
5523         * tui/tui-winsource.c (tui_clear_source_content)
5524         (tui_erase_source_content, tui_show_source_content): Change type
5525         of win_info.
5526         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5527         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5528         win_info.
5529         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5530         win_info.
5531         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5532
5533 2019-06-25  Tom Tromey  <tom@tromey.com>
5534
5535         * tui/tui-winsource.c (tui_clear_source_content)
5536         (tui_source_window_base::set_is_exec_point_at): Update.
5537         * tui/tui-source.c (tui_set_source_content_nil): Update.
5538         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5539         a bool.
5540         * tui/tui-data.c (init_content_element): Update.
5541
5542 2019-06-25  Tom Tromey  <tom@tromey.com>
5543
5544         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5545         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5546         * tui/tui-layout.c (init_and_make_win): Update.
5547         * tui/tui.h (enum tui_win_type): Update.
5548         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5549         tui_win_is_auxillary.
5550         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5551         tui_win_is_auxillary.
5552
5553 2019-06-25  Tom Tromey  <tom@tromey.com>
5554
5555         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5556         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5557         (tui_delete_data_content_windows, tui_display_all_data)
5558         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5559         Update.
5560         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5561         * tui/tui-regs.c (tui_last_regs_line_no)
5562         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5563         (tui_show_registers): Update.
5564         (tui_show_register_group): Return void.  Update.
5565         (tui_display_registers_from, tui_display_reg_element_at_line)
5566         (tui_display_registers_from_line, tui_check_register_values):
5567         Update.
5568         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5569         member.
5570         (struct tui_data_window) <regs_content>: Now a std::vector.
5571         <regs_content_count>: Remove.
5572         (tui_add_content_elements, tui_free_data_content): Don't declare.
5573         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5574         (init_content_element): Remove DATA_WIN case.  Add assert.
5575         (tui_add_content_elements): Remove.
5576         (tui_data_window): Update.
5577         (tui_free_data_content): Remove.
5578         (free_content_elements): Remove DATA_WIN case.
5579
5580 2019-06-25  Tom Tromey  <tom@tromey.com>
5581
5582         * tui/tui-data.c (tui_data_item_window): Update.
5583         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5584         * tui/tui-windata.c (tui_display_all_data)
5585         (tui_display_data_from_line): Update.
5586         (tui_check_data_values): Remove.
5587         * tui/tui-regs.c (tui_show_register_group)
5588         (tui_display_reg_element_at_line): Update.
5589         * tui/tui-hooks.c (tui_register_changed)
5590         (tui_refresh_frame_and_register_information): Call
5591         tui_check_register_values.
5592         * tui/tui-data.h (struct tui_data_window) <data_content,
5593         data_content_count, data_type>: Remove.
5594         (enum tui_data_type): Remove.
5595
5596         * tui/tui-data.c (tui_data_window::clear_detail)
5597         (~tui_data_window): Update.
5598
5599 2019-06-25  Tom Tromey  <tom@tromey.com>
5600
5601         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5602         declare.
5603         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5604         Rename from tui_first_data_item_displayed.  Update.
5605         (tui_data_window::refresh_all)
5606         (tui_data_window::do_scroll_vertical): Update.
5607         * tui/tui-data.h (struct tui_data_window)
5608         <first_data_item_displayed>: Declare new method.
5609
5610 2019-06-25  Tom Tromey  <tom@tromey.com>
5611
5612         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5613         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5614         contents...
5615         (tui_initialize_static_data): ...here.
5616
5617 2019-06-25  Tom Tromey  <tom@tromey.com>
5618
5619         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5620         (tui_display_registers_from, tui_check_register_values): Update.
5621         (tui_display_register): Remove win_info parameter; update.
5622         (tui_get_register): Change type of parameters.
5623         * tui/tui-data.h (struct tui_data_element): Remove.
5624         (union tui_which_element) <data>: Remove.
5625         <data_window>: Change type.
5626         (struct tui_data_item_window): New.
5627         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5628         case.  Add assert.
5629         (~tui_data_item_window): New destructor.
5630         (free_content_elements): Remove DATA_ITEM_WIN case.
5631
5632 2019-06-25  Tom Tromey  <tom@tromey.com>
5633
5634         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5635         Remove.
5636
5637 2019-06-25  Tom Tromey  <tom@tromey.com>
5638
5639         * tui/tui-data.h (struct tui_command_element): Remove.
5640         (union tui_which_element) <command>: Remove.
5641         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5642         assert.
5643         (free_content_elements): Remove CMD_WIN case.
5644
5645 2019-06-25  Tom Tromey  <tom@tromey.com>
5646
5647         * tui/tui-layout.c (tui_set_layout): Update.
5648         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5649         * tui/tui-data.c (layout_def): Update.
5650
5651 2019-06-25  Tom Tromey  <tom@tromey.com>
5652
5653         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5654         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5655         (tui_source_window_base::set_new_height): Update.
5656         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5657         Update.
5658         (tui_set_locator_fullname, tui_set_locator_info)
5659         (tui_show_frame_info): Update.
5660         * tui/tui-source.c (tui_set_source_content)
5661         (tui_source_is_displayed): Update.
5662         * tui/tui-layout.c (show_source_disasm_command, show_data)
5663         (show_source_or_disasm_and_command): Update.
5664         * tui/tui-disasm.c (tui_set_disassem_content)
5665         (tui_get_begin_asm_address): Update.
5666         * tui/tui-data.h (struct tui_locator_element): Remove.
5667         (union tui_which_element) <locator>: Remove.
5668         (struct tui_locator_window): New.
5669         (tui_locator_win_info_ptr): Change return type.
5670         * tui/tui-data.c (_locator): Change type.
5671         (tui_locator_win_info_ptr): Change return type.
5672         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5673         (tui_alloc_content): Add assert.
5674
5675 2019-06-25  Tom Tromey  <tom@tromey.com>
5676
5677         * tui/tui-winsource.c
5678         (tui_exec_info_window::maybe_allocate_content): New method.
5679         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5680         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5681         (make_source_or_disasm_window): Add cast.
5682         * tui/tui-data.h (union tui_which_element) <simple_string>:
5683         Remove.
5684         (struct tui_source_info): New.
5685         (struct tui_source_window_base) <execution_info>: Change type.
5686         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5687         case, and add assert.
5688         (tui_alloc_content): Add assert.
5689
5690 2019-06-25  Tom Tromey  <tom@tromey.com>
5691
5692         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5693         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5694         * tui/tui-data.c (tui_alloc_win_info): Remove.
5695
5696 2019-06-25  Tom Tromey  <tom@tromey.com>
5697
5698         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5699         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5700         can_highlight.
5701
5702 2019-06-25  Tom Tromey  <tom@tromey.com>
5703
5704         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5705         make_visible_with_new_height method.
5706         (tui_win_info::make_visible_with_new_height): New method.
5707         (tui_source_window_base::do_make_visible_with_new_height)
5708         (tui_data_window::do_make_visible_with_new_height)
5709         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5710         (make_visible_with_new_height): Remove.
5711         (tui_resize_all, tui_adjust_win_heights): Use
5712         make_visible_with_new_height method.
5713         * tui/tui-data.h (struct tui_win_info)
5714         <do_make_visible_with_new_height, make_visible_with_new_height>:
5715         New methods.
5716         (struct tui_source_window_base, struct tui_data_window)
5717         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5718         methods.
5719
5720 2019-06-25  Tom Tromey  <tom@tromey.com>
5721
5722         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5723         method.
5724         (update_tab_width): Call update_tab_width method.
5725         * tui/tui-data.h (struct tui_win_info)
5726         (struct tui_source_window_base) <update_tab_width>: New methods.
5727
5728 2019-06-25  Tom Tromey  <tom@tromey.com>
5729
5730         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5731         parameter.
5732         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5733         parameter.
5734         (tui_gen_win_info::make_visible): Update.
5735         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5736         parameter.
5737         * tui/tui-data.h (enum tui_box): New enum.
5738         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5739
5740 2019-06-25  Tom Tromey  <tom@tromey.com>
5741
5742         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5743         init_and_make_win for EXEC_INFO_WIN.
5744         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5745         longer inline.
5746         (struct tui_win_info) <~tui_win_info>: Inline.
5747         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5748         Don't declare.
5749         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5750         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5751         Remove.
5752         (tui_initialize_static_data): Update.
5753         (~tui_gen_win_info): Handle more cleanup here.
5754         (~tui_source_window_base): Delete "execution_info".
5755         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5756
5757 2019-06-25  Tom Tromey  <tom@tromey.com>
5758
5759         * tui/tui-layout.c (make_command_window): Don't set
5760         can_highlight.
5761         (show_source_disasm_command): Call the reset method.
5762         (show_data): Don't set can_highlight.  Call the reset method.
5763         (tui_gen_win_info::reset): Rename from init_gen_win_info
5764         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5765         (show_source_or_disasm_and_command): Call the reset method.
5766         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5767         (struct tui_cmd_window): Set can_highlight.
5768
5769 2019-06-25  Tom Tromey  <tom@tromey.com>
5770
5771         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5772         from make_visible.
5773         (tui_make_visible, tui_make_invisible): Rewrite.
5774         (tui_win_info::make_visible): Remove.
5775         (tui_source_window_base::make_visible): Update.
5776         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5777         method.  Moved from...
5778         (struct tui_win_info) <make_visible>: ...here.
5779
5780 2019-06-25  Tom Tromey  <tom@tromey.com>
5781
5782         * tui/tui-winsource.c
5783         (tui_source_window_base::do_scroll_horizontal): Remove direction
5784         parameter.
5785         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5786         direction parameter.
5787         * tui/tui-win.c (tui_win_info::forward_scroll)
5788         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5789         (tui_win_info::right_scroll): Update.
5790         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5791         direction parameter.
5792         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5793         direction parameter.
5794         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5795         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5796         Remove direction parameter.
5797         (struct tui_source_window_base, struct tui_source_window)
5798         (struct tui_disasm_window, struct tui_data_window)
5799         (struct tui_cmd_window): Update.
5800
5801 2019-06-25  Tom Tromey  <tom@tromey.com>
5802
5803         * tui/tui-winsource.h (tui_set_exec_info_content)
5804         (tui_show_exec_info_content, tui_erase_exec_info_content)
5805         (tui_clear_exec_info_content, tui_update_exec_info): Change
5806         argument to tui_source_window_base.
5807         * tui/tui-winsource.c (tui_set_exec_info_content)
5808         (tui_show_exec_info_content, tui_erase_exec_info_content)
5809         (tui_clear_exec_info_content, tui_update_exec_info): Change
5810         argument to tui_source_window_base.
5811
5812 2019-06-25  Tom Tromey  <tom@tromey.com>
5813
5814         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5815         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5816
5817 2019-06-25  Tom Tromey  <tom@tromey.com>
5818
5819         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5820         check.
5821
5822 2019-06-25  Tom Tromey  <tom@tromey.com>
5823
5824         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5825         type to void.
5826         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5827         type to void.
5828         * tui/tui-source.c (tui_set_source_content): Update.
5829         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5830
5831 2019-06-25  Tom Tromey  <tom@tromey.com>
5832
5833         * tui/tui-win.c (window_name_completer, tui_set_focus)
5834         (tui_all_windows_info): Use name method.
5835         * tui/tui-data.h (struct tui_gen_win_info)
5836         (struct tui_source_window, struct tui_disasm_window)
5837         (struct tui_data_window, struct tui_cmd_window) <name>: New
5838         method.
5839         (tui_win_name): Don't declare.
5840         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5841         (tui_win_name): Remove.
5842
5843 2019-06-25  Tom Tromey  <tom@tromey.com>
5844
5845         * tui/tui-winsource.h (tui_update_source_window)
5846         (tui_update_source_window_as_is): Change parameter type.
5847         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5848         to be a tui_source_window_base.
5849         (tui_update_source_window_as_is): Likewise.
5850         * tui/tui-win.c (make_visible_with_new_height): Update.
5851
5852 2019-06-25  Tom Tromey  <tom@tromey.com>
5853
5854         * tui/tui-winsource.c (tui_erase_source_content)
5855         (tui_show_source_content, tui_show_exec_info_content)
5856         (tui_erase_exec_info_content): Use refresh_window method.
5857         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5858         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5859         from tui_refresh_win.
5860         (tui_data_window::refresh_window): New method.
5861         (tui_win_info::refresh, tui_source_window_base::refresh)
5862         (tui_refresh_all): Use refresh_window method.
5863         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5864         method.
5865         * tui/tui-regs.c (tui_display_register): Call refresh_window
5866         method.
5867         * tui/tui-layout.c (show_source_disasm_command)
5868         (show_source_or_disasm_and_command): Call refresh_window method.
5869         * tui/tui-data.h (struct tui_gen_win_info)
5870         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5871         New method.
5872
5873 2019-06-25  Tom Tromey  <tom@tromey.com>
5874
5875         * tui/tui.c (tui_rl_other_window, tui_enable)
5876         (tui_is_window_visible, tui_get_command_dimension): Update.
5877         * tui/tui-winsource.c (tui_update_source_window_as_is)
5878         (tui_clear_source_content, tui_erase_source_content)
5879         (tui_show_source_line, tui_source_window_base::refill)
5880         (tui_source_window_base::do_scroll_horizontal)
5881         (tui_source_window_base::set_is_exec_point_at)
5882         (tui_update_breakpoint_info, tui_set_exec_info_content)
5883         (tui_alloc_source_buffer, tui_line_is_displayed)
5884         (tui_addr_is_displayed): Update.
5885         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5886         (tui_check_and_display_highlight_if_needed)
5887         (tui_win_info::make_visible, tui_win_info::refresh)
5888         (tui_refresh_all): Update.
5889         * tui/tui-windata.c (tui_first_data_item_displayed)
5890         (tui_delete_data_content_windows, tui_erase_data_content)
5891         (tui_display_all_data, tui_data_window::refresh_all)
5892         (tui_check_data_values): Update.
5893         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5894         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5895         (tui_win_info::backward_scroll, tui_refresh_all_win)
5896         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5897         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5898         (tui_source_window_base::set_new_height)
5899         (tui_data_window::set_new_height)
5900         (make_invisible_and_set_new_height)
5901         (make_visible_with_new_height, new_height_ok)
5902         (parse_scrolling_args): Update.
5903         * tui/tui-stack.c (tui_show_frame_info): Update.
5904         * tui/tui-source.c (tui_set_source_content)
5905         (tui_set_source_content_nil, tui_source_is_displayed)
5906         (tui_source_window::do_scroll_vertical): Update.
5907         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5908         (tui_display_registers_from, tui_display_reg_element_at_line)
5909         (tui_check_register_values, tui_reg_command): Update.
5910         * tui/tui-layout.c (tui_default_win_height)
5911         (show_source_disasm_command, show_data, init_and_make_win)
5912         (show_source_or_disasm_and_command): Update.
5913         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5914         (tui_redisplay_readline, tui_mld_flush)
5915         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5916         (tui_getc): Update.
5917         * tui/tui-disasm.c (tui_set_disassem_content)
5918         (tui_disasm_window::do_scroll_vertical): Update.
5919         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5920         Now virtual.
5921         (struct tui_win_info): Derive from tui_gen_win_info.
5922         <~tui_win_info>: Mark as override.
5923         <generic>: Remove member.
5924         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5925         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5926         (~tui_data_window, ~tui_win_info)
5927         (tui_free_all_source_wins_content): Update.
5928         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5929
5930 2019-06-25  Tom Tromey  <tom@tromey.com>
5931
5932         * tui/tui-layout.c (init_and_make_win): Use new.
5933         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5934         destructor, initializers.
5935         (tui_alloc_generic_win_info): Don't declare.
5936         * tui/tui-data.c (_locator): Add argument to constructor.
5937         (source_win, disasm_win): New globals.
5938         (exec_info): Remove.
5939         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5940         Update.
5941         (tui_alloc_generic_win_info): Remove.
5942         (init_content_element): Use new.
5943         (tui_win_info::tui_win_info): Update.
5944         (free_content_elements) <case DATA_WIN>: Use delete.
5945
5946 2019-06-25  Tom Tromey  <tom@tromey.com>
5947
5948         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5949         * tui/tui-windata.c (tui_first_data_item_displayed)
5950         (tui_delete_data_content_windows): Update.
5951         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5952         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5953         (tui_display_registers_from, tui_check_register_values): Update.
5954         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5955         pointer.
5956         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5957         window.
5958         (tui_free_data_content): Update.
5959         (free_content_elements) <case DATA_WIN>: Free the window.
5960
5961 2019-06-25  Tom Tromey  <tom@tromey.com>
5962
5963         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5964         Update.
5965         * tui/tui-layout.c (make_command_window)
5966         (show_source_disasm_command, show_data, init_and_make_win)
5967         (show_source_or_disasm_and_command): Update.
5968         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5969         method.
5970         <can_highight, is_highlighted>: Now bool.
5971         (tui_set_win_highlight): Don't declare.
5972         * tui/tui-data.c (tui_set_win_highlight): Remove.
5973
5974 2019-06-25  Tom Tromey  <tom@tromey.com>
5975
5976         * tui/tui-wingeneral.c (make_visible): Remove check of window
5977         type.
5978
5979 2019-06-25  Tom Tromey  <tom@tromey.com>
5980
5981         * tui/tui-win.c (tui_win_info::max_height)
5982         (tui_cmd_window::max_height): New methods.
5983         (new_height_ok): Call max_height.
5984         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5985         <max_height>: New method.
5986
5987 2019-06-25  Tom Tromey  <tom@tromey.com>
5988
5989         * tui/tui-win.c (tui_source_window_base::set_new_height)
5990         (tui_data_window::set_new_height): New methods.
5991         (make_invisible_and_set_new_height): Call set_new_height method.
5992         * tui/tui-data.h (struct tui_win_info)
5993         (struct tui_source_window_base, struct tui_data_window)
5994         <set_new_height>: New method.
5995
5996 2019-06-25  Tom Tromey  <tom@tromey.com>
5997
5998         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5999         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6000         tui_refresh_data_win.
6001         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6002         method.
6003         (tui_refresh_all_win): Call the refresh_all method.
6004         (tui_set_focus): Likewise.
6005         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6006         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6007         Likewise.
6008
6009 2019-06-25  Tom Tromey  <tom@tromey.com>
6010
6011         * tui/tui-winsource.h (tui_refill_source_window)
6012         (tui_set_is_exec_point_at): Don't declare.
6013         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6014         (tui_source_window_base::refill): Rename from
6015         tui_refill_source_window.
6016         (tui_source_window_base::do_scroll_horizontal): Update.
6017         (tui_source_window_base::set_is_exec_point_at): Rename from
6018         tui_set_is_exec_point_at.
6019         (tui_update_all_breakpoint_info): Update.
6020         * tui/tui-stack.c (tui_show_frame_info): Update.
6021         * tui/tui-layout.c (show_data): Add cast.
6022         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6023         * tui/tui-data.h (struct tui_source_window_base) <refill,
6024         set_is_exec_point_at>: New methods.
6025         (tui_source_windows, tui_add_to_source_windows): Update types.
6026         (tui_add_to_source_windows): Remove redundant declaration.
6027         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6028         (tui_source_windows): Change return type.
6029         (tui_clear_source_windows_detail): Update.
6030         (tui_add_to_source_windows): Change type of parameter.
6031         (tui_free_all_source_wins_content): Update.
6032
6033 2019-06-25  Tom Tromey  <tom@tromey.com>
6034
6035         * tui/tui-wingeneral.c (tui_win_info::refresh)
6036         (tui_source_window_base::refresh): New methods.
6037         (tui_refresh_all): Call the refresh method.
6038         * tui/tui-data.h (struct tui_win_info)
6039         (struct tui_source_window_base) <refresh>: New method.
6040
6041 2019-06-25  Tom Tromey  <tom@tromey.com>
6042
6043         * tui/tui.h (tui_is_window_visible): Return bool.
6044         * tui/tui.c (tui_is_window_visible): Return bool.
6045         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6046         (tui_make_visible, tui_make_invisible)
6047         (tui_win_info::make_visible)
6048         (tui_source_window_base::make_visible, make_all_visible)
6049         (tui_make_all_visible, tui_make_all_invisible): Update.
6050         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6051         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6052         bool.
6053         (struct tui_win_info, struct tui_source_window_base)
6054         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6055         * tui/tui-data.c (tui_init_generic_part): Update.
6056
6057 2019-06-25  Tom Tromey  <tom@tromey.com>
6058
6059         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6060         (tui_source_window_base::make_visible): New methods.
6061         (make_all_visible): Make method call.
6062         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6063         (struct tui_source_window_base, struct tui_cmd_window): Override
6064         make_visible.
6065         (tui_win_is_source_type): Don't declare.
6066         * tui/tui-data.c (tui_win_is_source_type): Remove.
6067
6068 2019-06-25  Tom Tromey  <tom@tromey.com>
6069
6070         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6071         NULL check.
6072
6073 2019-06-25  Tom Tromey  <tom@tromey.com>
6074
6075         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6076         Inline constructor.  Add initializers for members.
6077         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6078         constructors; now inline in class.
6079
6080 2019-06-25  Tom Tromey  <tom@tromey.com>
6081
6082         * tui/tui-regs.c (tui_show_registers): Update.
6083         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6084         bool.
6085         * tui/tui-data.c (tui_data_window::clear_detail)
6086         (tui_data_window): Update.
6087
6088 2019-06-25  Tom Tromey  <tom@tromey.com>
6089
6090         * tui/tui-windata.c (tui_display_all_data)
6091         (tui_display_data_from_line, tui_display_data_from)
6092         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6093         Update.
6094         * tui/tui-regs.c (tui_last_regs_line_no)
6095         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6096         (tui_show_registers, tui_show_register_group)
6097         (tui_display_registers_from, tui_display_reg_element_at_line)
6098         (tui_display_registers_from_line, tui_check_register_values)
6099         (tui_reg_next, tui_reg_prev): Update.
6100         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6101         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6102         tui_data_window.
6103         (struct tui_win_info) <detail>: Remove.  Add new fields from
6104         tui_data_info.
6105         (TUI_DATA_WIN): Add cast.
6106         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6107         (~tui_data_window): Simplify.
6108
6109 2019-06-25  Tom Tromey  <tom@tromey.com>
6110
6111         * tui/tui-layout.c (show_source_disasm_command)
6112         (show_source_or_disasm_and_command): Update.
6113         * tui/tui-io.c (update_cmdwin_start_line)
6114         (tui_redisplay_readline): Update.
6115         * tui/tui-data.h (struct tui_command_info): Remove.
6116         (struct tui_win_info) <detail>: Remove command_info member.
6117         (struct tui_data_window) <start_line>: New member, from
6118         tui_command_info.
6119         (TUI_CMD_WIN): Add casts.
6120
6121 2019-06-25  Tom Tromey  <tom@tromey.com>
6122
6123         * tui/tui-winsource.c (tui_update_source_window)
6124         (tui_refill_source_window)
6125         (tui_source_window_base::do_scroll_horizontal)
6126         (tui_update_breakpoint_info, tui_set_exec_info_content)
6127         (tui_show_exec_info_content, tui_erase_exec_info_content)
6128         (tui_clear_exec_info_content): Update.
6129         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6130         Update.
6131         * tui/tui-win.c (make_invisible_and_set_new_height)
6132         (make_visible_with_new_height): Update.
6133         * tui/tui-source.c (tui_set_source_content)
6134         (tui_show_symtab_source): Update.
6135         * tui/tui-layout.c (extract_display_start_addr)
6136         (show_source_disasm_command, show_data)
6137         (make_source_or_disasm_window)
6138         (show_source_or_disasm_and_command): Update.
6139         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6140         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6141         "gdbarch".
6142         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6143         to tui_source_window_base.
6144         (struct tui_win_info) <detail>: Remove source_info member.
6145         (struct tui_source_window_base) <has_locator>: Inline.
6146         Move contents from tui_source_info; rename has_locator member to
6147         m_has_locator.
6148         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6149         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6150         header file.
6151         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6152         Simplify.
6153         (tui_free_all_source_wins_content): Cast to
6154         tui_source_window_base.
6155
6156 2019-06-25  Tom Tromey  <tom@tromey.com>
6157
6158         * tui/tui-win.c (make_invisible_and_set_new_height)
6159         (make_visible_with_new_height): Call has_locator method.
6160         * tui/tui-layout.c (show_source_disasm_command, show_data)
6161         (show_source_or_disasm_and_command): Update for bool change.
6162         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6163         (tui_win_info) <has_locator>: New method.
6164         (struct tui_source_window_base) <has_locator>: New method.
6165         (tui_win_has_locator): Don't declare.
6166         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6167         from tui_win_has_locator.
6168         (tui_source_window_base): Use false, not FALSE.
6169
6170 2019-06-25  Tom Tromey  <tom@tromey.com>
6171
6172         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6173         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6174         clear_detail method directly.
6175         (tui_clear_win_detail): Remove.
6176
6177 2019-06-25  Tom Tromey  <tom@tromey.com>
6178
6179         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6180         "this", not TUI_DISASM_WIN.
6181
6182 2019-06-25  Tom Tromey  <tom@tromey.com>
6183
6184         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6185         declare.
6186         * tui/tui-winsource.c
6187         (tui_source_window_base::do_scroll_horizontal): Rename from
6188         tui_horizontal_source_scroll.
6189         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6190         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6191         from tui_vertical_data_scroll.
6192         * tui/tui-win.h (tui_scroll): Don't declare.
6193         * tui/tui-win.c (tui_win_info::forward_scroll)
6194         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6195         (tui_win_info::right_scroll): Rename and update.
6196         (tui_scroll_forward_command, tui_scroll_backward_command)
6197         (tui_scroll_left_command, tui_scroll_right_command): Update.
6198         (tui_scroll): Remove.
6199         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6200         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6201         from tui_vertical_source_scroll.
6202         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6203         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6204         from tui_vertical_disassem_scroll.
6205         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6206         do_scroll_horizontal>: New methods.
6207         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6208         Likewise.
6209         (struct tui_source_window_base): Add do_scroll_horizontal.
6210         (struct tui_source_window, struct tui_disasm_window): Add
6211         do_scroll_vertical.
6212         (struct tui_data_window, struct tui_cmd_window): Add
6213         do_scroll_horizontal and do_scroll_vertical.
6214         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6215
6216 2019-06-25  Tom Tromey  <tom@tromey.com>
6217
6218         * tui/tui-data.h (struct tui_source_window_base): New struct.
6219         (struct tui_source_window): Derive from tui_source_window_base.
6220         (struct tui_disasm_window): New struct.
6221         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6222         from tui_source_window::clear_detail.
6223         (tui_source_window_base): Rename from tui_source_window.
6224         (~tui_source_window_base): Rename from ~tui_source_window.
6225         (tui_alloc_win_info): Create a tui_disasm_window.
6226
6227 2019-06-25  Tom Tromey  <tom@tromey.com>
6228
6229         * tui/tui-data.h (struct tui_source_window)
6230         (struct tui_data_window): Declare destructors.
6231         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6232         destructors.
6233         (tui_win_info): Simplify.
6234
6235 2019-06-25  Tom Tromey  <tom@tromey.com>
6236
6237         * tui/tui-winsource.c (tui_display_main)
6238         (tui_update_source_windows_with_addr)
6239         (tui_update_all_breakpoint_info): Update.
6240         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6241         (new_height_ok, parse_scrolling_args): Update.
6242         * tui/tui-stack.c (tui_show_frame_info): Update.
6243         * tui/tui-data.h (struct tui_list): Remove.
6244         (tui_source_windows): Return a reference to a std::vector.
6245         * tui/tui-data.c (source_windows): Now a std::vector.
6246         (tui_source_windows): Change return type.
6247         (tui_clear_source_windows): Rewrite.
6248         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6249         (tui_free_all_source_wins_content): Rewrite.
6250
6251 2019-06-25  Tom Tromey  <tom@tromey.com>
6252
6253         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6254         (struct tui_data_window, struct tui_cmd_window): Declare
6255         clear_detail method.
6256         * tui/tui-data.c (tui_source_window::clear_detail)
6257         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6258         methods.
6259         (tui_clear_win_detail): Simplify.
6260
6261 2019-06-25  Tom Tromey  <tom@tromey.com>
6262
6263         * tui/tui-layout.c (make_source_window, make_disasm_window)
6264         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6265         Return the new window.
6266         (show_source_disasm_command, show_data)
6267         (show_source_or_disasm_and_command): Update.
6268
6269 2019-06-25  Tom Tromey  <tom@tromey.com>
6270
6271         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6272         parameter.  Return the new window.
6273         (show_source_disasm_command): Update and remove NULL check.
6274         (show_source_or_disasm_and_command): Update.
6275
6276 2019-06-25  Tom Tromey  <tom@tromey.com>
6277
6278         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6279
6280 2019-06-25  Tom Tromey  <tom@tromey.com>
6281
6282         * tui/tui-data.h (struct tui_win_info): Make constructor
6283         protected.  Make destructor virtual.  Add initializers.
6284         (tui_source_window, tui_data_window, tui_cmd_window): New
6285         classes.
6286         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6287         constructor.  Add "type" parameter.
6288         (tui_source_window, tui_data_window, tui_cmd_window): New
6289         constructors.
6290         (tui_alloc_win_info): Instantiate the appropriate subclass.
6291
6292 2019-06-25  Tom Tromey  <tom@tromey.com>
6293
6294         * tui/tui-win.c (tui_resize_all): Use delete.
6295         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6296         destructor.
6297         (tui_free_window): Don't declare.
6298         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6299         Update.
6300
6301 2019-06-25  Tom Tromey  <tom@tromey.com>
6302
6303         * tui/tui-data.h (struct tui_win_info): Add constructor.
6304         * tui/tui-data.c (tui_alloc_win_info): Use new.
6305         (tui_free_window): Use delete.
6306
6307 2019-06-22  Tom Tromey  <tom@tromey.com>
6308
6309         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6310         declare.
6311         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6312
6313 2019-06-22  Tom Tromey  <tom@tromey.com>
6314
6315         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6316         declare.
6317         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6318
6319 2019-06-22  Tom de Vries  <tdevries@suse.de>
6320
6321         * dwarf2read.c (create_addrmap_from_aranges)
6322         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6323         instead of '%zu'.
6324
6325 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6326
6327         * dwarf2read.h (dwarf2_section_info_def): Remove.
6328         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6329         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6330         std::vector<dwarf2_section_info>.
6331         (struct dwo_file) <~dwo_file>: Remove.
6332         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6333         types field.
6334         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6335         (dwarf2_read_debug_names): Likewise.
6336         (create_debug_types_hash_table): Change parameter type to
6337         array_view, adjust code accordingly.
6338         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6339         (partial_die_info::fixup): Likewise.
6340         (determine_prefix): Likewise.
6341         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6342
6343 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6344
6345         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6346         gdb_bfd_ref_ptr.
6347         <~dwo_file>: Remove call to gdb_bfd_unref.
6348         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6349         gdb_bfd_ref_ptr::get.
6350
6351 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6352
6353         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6354         type to htab_up.
6355         * dwarf2read.c (struct dwo_file): Initialize fields.
6356         <~dwo_file>: New.
6357         (free_dwo_file): Remove, move content to ~dwo_file.
6358         (struct dwo_file_deleter): Remove.
6359         (dwo_file_up>: Remove custom deleter.
6360         (free_dwo_files): Remove.
6361         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6362         dwo_files.
6363         (process_skeletonless_type_units): Call unique_ptr::get.
6364         (allocate_dwo_file_hash_table): Add deleter to created hash
6365         table.  Change return type to htab_up.
6366         (lookup_dwo_file_slot): Don't memset dwo_file, call
6367         unique_ptr::get.
6368         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6369         (create_dwo_unit_in_dwp_v2): Likewise.
6370         (open_and_init_dwo_file): Likewise.
6371         (free_dwo_file_from_slot): Remove.
6372
6373 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6374
6375         * dwarf2read.h (struct dwarf2_section_info) <readin,
6376         is_virtual>: Change type to bool.
6377         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6378         true instead of 1.
6379
6380 2019-06-19  Tom Tromey  <tom@tromey.com>
6381
6382         * tui/tui-data.h (tui_init_content_element): Don't declare.
6383
6384 2019-06-19  Tom Tromey  <tom@tromey.com>
6385
6386         * tui/tui-data.h (tui_init_win_info): Don't declare.
6387
6388 2019-06-19  Tom de Vries  <tdevries@suse.de>
6389
6390         * dwarf2read.h (abstract_to_concrete): Change type to
6391         std::unordered_map<sect_offset, std::vector<sect_offset>,
6392         gdb::hash_enum<sect_offset>>.
6393
6394 2019-06-19  Tom Tromey  <tromey@adacore.com>
6395
6396         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6397         EVAL_AVOID_SIDE_EFFECTS specially.
6398
6399 2019-06-19  Tom Tromey  <tromey@adacore.com>
6400
6401         * source-cache.c (highlighter): New global.
6402         (source_cache::get_source_lines): Create a highlighter on demand.
6403
6404 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6405
6406         * defs.h (deprecated_interactive_hook): Delete declaration.
6407         * interps.c (clear_interpreter_hooks): Remove use of
6408         deprecated_interactive_hook.
6409         * top.c (deprecated_interactive_hook): Delete definition.
6410         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6411
6412 2019-06-18  Tom de Vries  <tdevries@suse.de>
6413
6414         PR gdb/24515
6415         * dwarf2read.h (abstract_to_concrete): Change type from
6416         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6417         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6418         * dwarf2read.c (read_variable): Update.
6419         (dwarf2_fetch_die_loc_sect_off): Update.
6420
6421 2019-06-17  Tom de Vries  <tdevries@suse.de>
6422
6423         PR gdb/24617
6424         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6425         accessing parent[parent_len - 1].
6426
6427 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6428
6429         PR gdb/24364
6430         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6431         call dtrace_process_dof with NULL dof.
6432
6433 2019-06-16  Tom de Vries  <tdevries@suse.de>
6434
6435         PR gdb/24445
6436         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6437
6438 2019-06-16  Tom Tromey  <tom@tromey.com>
6439
6440         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6441         (make_all_visible): Use address of member.
6442
6443 2019-06-16  Tom Tromey  <tom@tromey.com>
6444
6445         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6446         (tui_free_window, free_content, free_content_elements): Remove
6447         unnecessary cast.
6448         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6449         cast.
6450         * tui/tui-regs.c (tui_show_register_group)
6451         (tui_display_registers_from, tui_display_reg_element_at_line):
6452         Remove unnecessary cast.
6453
6454 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6455
6456         * linux-nat.c (normal_mask): Delete.
6457         (_initialize_linux_nat): Don't initialise normal_mask.
6458
6459 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6460
6461         PR gdb/24445
6462         * dwarf-index-write.h (write_psymtabs_to_index): Add
6463         dwz_basename parameter.
6464         * dwarf-index-write.c (write_gdbindex): Move file writing to
6465         write_gdbindex_1.  Change return type void.
6466         (assert_file_size): Move up, remove filename parameter.
6467         (write_gdbindex_1): New function.
6468         (write_debug_names): Change return type to void, call
6469         assert_file_size.
6470         (struct index_wip_file): New struct.
6471         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6472         file logic to index_wip_file.  Write index for dwz file if
6473         needed.
6474         (save_gdb_index_command): Pass basename of dwz file, if present.
6475         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6476         build-id of dwz file, if present.
6477         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6478         (dwarf2_get_dwz_file): Likewise.
6479         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6480         (dwarf2_get_dwz_file): Likewise.
6481
6482 2019-06-16  Tom Tromey  <tom@tromey.com>
6483
6484         * coffread.c (process_coff_symbol): Use xstrdup.
6485         * value.c (create_internalvar): Use xstrdup.
6486
6487 2019-06-16  Tom Tromey  <tom@tromey.com>
6488
6489         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6490         * breakpoint.c (stopin_command, stopat_command)
6491         (until_break_command, decode_location_default): Remove unnecessary
6492         cast.
6493         * utils.c (subset_compare): Remove unnecessary cast.
6494         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6495         cast.
6496         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6497         cast.
6498         * infcmd.c (path_command): Remove unnecessary cast.
6499         * coffread.c (decode_type): Remove unnecessary cast.
6500         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6501         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6502         * tui/tui-stack.c (tui_show_locator_content)
6503         (tui_show_frame_info): Remove unnecessary cast.
6504         * tui/tui-win.c (tui_scroll_forward_command)
6505         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6506         (parse_scrolling_args): Remove unnecessary cast.
6507         * tui/tui-data.c (init_win_info, tui_del_window)
6508         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6509         (free_content_elements): Remove unnecessary cast.
6510         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6511         unnecessary cast.
6512         * tui/tui-source.c (tui_set_source_content)
6513         (tui_vertical_source_scroll): Remove unnecessary cast.
6514         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6515         cast.
6516         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6517         * tui/tui-regs.c (tui_display_registers_from)
6518         (tui_display_register): Remove unnecessary cast.
6519         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6520         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6521         (make_visible): Remove unnecessary cast.
6522         * tui/tui-winsource.c (tui_erase_source_content)
6523         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6524         unnecessary cast.
6525         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6526         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6527         * stabsread.c (read_type, read_array_type, read_range_type):
6528         Remove unnecessary cast.
6529         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6530         (parse_symbol, parse_type, upgrade_type, parse_external)
6531         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6532         unnecessary cast.
6533         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6534
6535 2019-06-16  Tom Tromey  <tom@tromey.com>
6536
6537         * tui/tui-data.c (tui_alloc_generic_win_info)
6538         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6539         checks.
6540
6541 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6542             Andrew Burgess  <andrew.burgess@embecosm.com>
6543
6544         * f-typeprint.c (f_print_type): Don't return early for not
6545         associated or not allocated types.
6546         (f_type_print_varspec_suffix): Add print_rank parameter and print
6547         ranks of array types in case they dangling.
6548         (f_type_print_base): Add print_rank parameter.
6549
6550 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6551
6552         * NEWS: Mention new MI commands.
6553         * break-catch-throw.c (enum exception_event_kind): Move to
6554         breakpoint.h.
6555         (print_mention_exception_catchpoint): Output text as a single
6556         message.
6557         (catch_exception_command_1): Rename to...
6558         (catch_exception_event): ...this, make non-static, update header
6559         command, and change some parameter types.
6560         (catch_catch_command): Update for changes to
6561         catch_exception_command_1.
6562         (catch_throw_command): Likewise.
6563         (catch_rethrow_command): Likewise.
6564         * breakpoint.c (enum exception_event_kind): Delete.
6565         * breakpoint.h (enum exception_event_kind): Moved here from
6566         break-catch-throw.c.
6567         (catch_exception_event): Declare.
6568         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6569         (mi_cmd_catch_throw): New function.
6570         (mi_cmd_catch_rethrow): New function.
6571         (mi_cmd_catch_catch): New function.
6572         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6573         'catch-catch' entries.
6574         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6575         (mi_cmd_catch_rethrow): Declare.
6576         (mi_cmd_catch_catch): Declare.
6577
6578 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6579
6580         * annotate.c (annotate_source_line): Change return type to void,
6581         update implementation to match.
6582         * annotate.h (annotate_source_line): Change return type to void,
6583         update header comment.
6584         * stack.c (print_frame_info): Don't change what frame information
6585         is printed based on whether annotations are on or not.
6586
6587 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6588
6589         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6590         (annotate_source): Make static.
6591         (annotate_source_line): Moved from source.c and renamed from
6592         identify_source_line.  Update the return type.
6593         * annotate.h (annotate_source): Delete declaration.
6594         (annotate_source_line): Declaration moved from source.h, and
6595         renamed from identify_source_line.  Return type updated.
6596         * source.c (identify_source_line): Moved to annotate.c and renamed
6597         to annotate_source_line.
6598         (info_line_command): Remove check of annotation_level.
6599         * source.h (identify_source_line): Move declaration to annotate.h
6600         and rename to annotate_source_line.
6601         * stack.c: Add 'annotate.h' include.
6602         (print_frame_info): Remove check of annotation_level before
6603         calling annotate_source_line.
6604
6605 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6606
6607         * source-cache.c (source_cache::get_plain_source_lines): Use
6608         open_source_file_with_line_charpos instead of just
6609         open_source_file, remove call to find_source_lines.
6610         (source_cache::get_source_lines): Likewise.
6611         * source.c (find_source_lines): Make static.
6612         (get_filename_and_charpos): Renamed into...
6613         (open_source_file_with_line_charpos): ..this along with changes to
6614         return a scoped_fd, and some other minor clean ups.
6615         (identify_source_line): Use open_source_file_with_line_charpos.
6616         (search_command_helper): Use open_source_file_with_line_charpos
6617         instead of just open_source_file, remove call to
6618         find_source_lines.
6619         * source.h (open_source_file_with_line_charpos): Declare new
6620         function.
6621         (find_source_lines): Delete declaration.
6622
6623 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6624
6625         * source.c (get_filename_and_charpos): Remove fullname
6626         parameter.
6627         (identify_source_line): Update call to get_filename_and_charpos.
6628
6629 2019-06-14  Tom Tromey  <tromey@adacore.com>
6630
6631         PR gdb/24502:
6632         * ui-style.h (skip_ansi_escape): Update comment.
6633         * ui-file.h (class no_terminal_escape_file): New class.
6634         * ui-file.c (no_terminal_escape_file::write)
6635         (no_terminal_escape_file::puts): New methods.
6636         * cli/cli-logging.c (handle_redirections): Use
6637         no_terminal_escape_file.
6638
6639 2019-06-14  Tom Tromey  <tromey@adacore.com>
6640
6641         * NEWS: Move convenience variable news above Python news.
6642
6643 2019-06-14  Tom Tromey  <tom@tromey.com>
6644
6645         * gnulib: Move directory to top-level.
6646         * configure.ac: Don't configure gnulib.
6647         * configure: Rebuild.
6648         * common/common-defs.h: Use new path to gnulib.
6649         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6650         (GNULIB_H): Remove.
6651         (INCGNU): Look in new gnulib location.
6652         (HFILES_NO_SRCDIR): Remove gnulib files.
6653         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6654         (generated_files): Remove GNULIB_H.
6655         ($(LIBGNU), all-lib): Remove targets.
6656         (distclean): Don't mention GNULIB_BUILDDIR.
6657         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6658
6659 2019-06-14  Tom Tromey  <tromey@adacore.com>
6660
6661         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6662         Warn if symbol file does not provide any symbols.
6663
6664 2019-06-14  Tom Tromey  <tromey@adacore.com>
6665
6666         * source.c (find_and_open_source): Respect basenames_may_differ.
6667
6668 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6669
6670         * annotate.c (annotate_breakpoints_invalid): Make use of
6671         scoped_restore_terminal_state.
6672         (annotate_frames_invalid): Likewise.
6673
6674 2019-06-14  Tom Tromey  <tromey@adacore.com>
6675
6676         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6677         allow assignment to an internalvar.
6678
6679 2019-06-14  Tom Tromey  <tromey@adacore.com>
6680
6681         * ada-lex.l: Allow "_" in attribute names.
6682
6683 2019-06-14  Tom Tromey  <tromey@adacore.com>
6684
6685         PR gdb/24653:
6686         * regcache.c (registers_changed): Don't call alloca.
6687         * top.c (execute_command): Don't call alloca.
6688
6689 2019-06-13  Pedro Alves  <palves@redhat.com>
6690
6691         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6692         'expression'.  When parsing an expression, error out if there's
6693         junk after "unlimited".
6694         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6695         (do_set_command): Adjust calls to is_unlimited_literal.
6696
6697 2019-06-13  Pedro Alves  <palves@redhat.com>
6698
6699         * compile/compile.c (make_compile_options_def_group): Add braces
6700         around array_view initializer.
6701         * thread.c (make_thread_apply_all_options_def_group)
6702         (make_thread_apply_all_options_def_group): Likewise.
6703
6704 2019-06-13  Pedro Alves  <palves@redhat.com>
6705
6706         * NEWS (New commands): Mention "maint test-options
6707         require-delimiter", "maint test-options unknown-is-error", "maint
6708         test-options unknown-is-operand" and "maint show
6709         test-options-completion-result".
6710         (New command options, command completion): New section.
6711         (Completion improvements): New section.
6712         Mention that you can abbreviate "unlimited".
6713
6714 2019-06-13  Pedro Alves  <palves@redhat.com>
6715
6716         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6717         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6718         * unittests/cli-utils-selftests.c (test_parse_flags)
6719         (test_parse_flags_qcs): Delete.
6720         (test_cli_utils): Don't call deleted functions.
6721
6722 2019-06-13  Pedro Alves  <palves@redhat.com>
6723
6724         * thread.c: Include "cli/cli-option.h".
6725         (tp_array_compar_ascending): Global.
6726         (tp_array_compar): Delete function.
6727         (tp_array_compar_ascending, tp_array_compar_descending): New
6728         functions.
6729         (ascending_option_def, qcs_flag_option_def)
6730         (thr_qcs_flags_option_defs)
6731         (make_thread_apply_all_options_def_group)
6732         (make_thread_apply_options_def_group): New.
6733         (thread_apply_all_command): Use gdb::option::process_options.
6734         (thread_apply_command_completer)
6735         (thread_apply_all_command_completer): New.
6736         (thread_apply_command): Use gdb::option::process_options.
6737         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6738         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6739         to generate help text of "thread apply".  Adjust "taas"'s help.
6740         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6741         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6742
6743 2019-06-13  Pedro Alves  <palves@redhat.com>
6744
6745         * thread.c (thread_apply_command): Check for invalid TID with
6746         isdigit instead of !isalpha.
6747
6748 2019-06-13  Pedro Alves  <palves@redhat.com>
6749
6750         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6751         (validate_flags_qcs): New.
6752         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6753         (validate_flags_qcs): Declare.
6754         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6755         (make_frame_apply_options_def_group): New.
6756         (frame_apply_command_count): Process options with
6757         gdb::option::process_options.
6758         (frame_apply_completer): New.
6759         (frame_apply_level_completer, frame_apply_all_completer)
6760         (frame_apply_completer): New.
6761         (_initialize_stack): Update help of "frame apply", "frame apply
6762         level", "frame apply all" and "faas" to mention supported options
6763         and install command completers.
6764         * stack.h (frame_apply_all_completer): Declare.
6765         * thread.c: Include "stack.h".
6766         (tfaas_command): Add "--".
6767         (_initialize_thread): Update help "tfaas" to mention supported
6768         options and install command completer.
6769
6770 2019-06-13  Pedro Alves  <palves@redhat.com>
6771
6772         * completer.c (complete_nested_command_line): New.
6773         (gdb_completion_word_break_characters_throw): Add assertion.
6774         * completer.h (complete_nested_command_line): Declare.
6775
6776 2019-06-13  Pedro Alves  <palves@redhat.com>
6777
6778         * stack.c (parse_backtrace_qualifiers): New.
6779         (backtrace_command): Use it.
6780         (backtrace_command_completer): Complete on qualifiers.
6781
6782 2019-06-13  Pedro Alves  <palves@redhat.com>
6783
6784         * frame.c: Include "cli/cli-option.h.
6785         (user_set_backtrace_options): New.
6786         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6787         Delete.
6788         (get_prev_frame): Adjust.
6789         (boolean_option_def, uinteger_option_def)
6790         (set_backtrace_option_defs): New.
6791         (_initialize_frame): Adjust and use
6792         gdb::option::add_setshow_cmds_for_options to install "set
6793         backtrace past-main" and "set backtrace past-entry".
6794         * frame.h: Include "cli/cli-option.h".
6795         (struct frame_print_options): Forward declare.
6796         (print_frame_arguments_all, print_frame_arguments_scalars)
6797         (print_frame_arguments_none): Declare.
6798         (print_entry_values): Delete declaration.
6799         (struct frame_print_options, user_frame_print_options): New.
6800         (struct set_backtrace_options): New.
6801         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6802         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6803         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6804         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6805         (list_args_or_locals): Add frame_print_options parameter.
6806         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6807         * python/py-framefilter.c (enumerate_args): Pass down
6808         USER_FRAME_PRINT_OPTIONS.
6809         * stack.c: Include "cli/cli-option.h".
6810         (print_frame_arguments_all, print_frame_arguments_scalars)
6811         (print_frame_arguments_none): Declare.
6812         (print_raw_frame_arguments, print_entry_values): Delete.
6813         (user_frame_print_options): New.
6814         (boolean_option_def, enum_option_def, frame_print_option_defs):
6815         New.
6816         (struct backtrace_cmd_options): New.
6817         (bt_flag_option_def): New.
6818         (backtrace_command_option_defs): New.
6819         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6820         (print_frame_arg, read_frame_arg, print_frame_args)
6821         (print_frame_info, print_frame): Add frame_print_options parameter
6822         and use it.
6823         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6824         (backtrace_command_1): Add frame_print_options and
6825         backtrace_cmd_options parameters and use them.
6826         (make_backtrace_options_def_group): New.
6827         (backtrace_command): Process command options with
6828         gdb::option::process_options.
6829         (backtrace_command_completer): New.
6830         (_initialize_stack): Extend "backtrace"'s help to mention
6831         supported options.  Install completer for "backtrace".
6832         Install some settings commands with add_setshow_cmds_for_options.
6833
6834 2019-06-13  Pedro Alves  <palves@redhat.com>
6835
6836         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6837         and that "set/show print raw frame-arguments" are now deprecated.
6838
6839         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6840         command.
6841         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6842         * stack.c (_initialize_stack): Install "set/show print
6843         raw-frame-arguments", and deprecate "set/show print raw
6844         frame-arguments".
6845         * valprint.c (_initialize_valprint): Deprecate "set/show print
6846         raw".
6847
6848 2019-06-13  Pedro Alves  <palves@redhat.com>
6849
6850         * compile/compile.c (struct compile_options): New.
6851         (compile_flag_option_def, compile_command_option_defs)
6852         (make_compile_options_def_group): New.
6853         (compile_file_command): Handle options with
6854         gdb::option::process_options.
6855         (compile_file_command_completer): New function.
6856         (compile_code_command): Handle options with
6857         gdb::option::process_options.
6858         (compile_code_command_completer): New function.
6859         (_initialize_compiler): Install completers for "compile code" and
6860         "compile file".  Mention available options in "compile code" and
6861         "compile code"'s help.
6862         * completer.c (advance_to_completion_word): New, factored out from
6863         ...
6864         (advance_to_expression_complete_word_point): ... this.
6865         (advance_to_filename_complete_word_point): New.
6866         * completer.h (advance_to_filename_complete_word_point): New
6867         declaration.
6868
6869 2019-06-13  Pedro Alves  <palves@redhat.com>
6870
6871         * compile/compile.c: Include "cli/cli-option.h".
6872         (compile_print_value): Scope data pointer is now a
6873         value_print_options pointer; adjust.
6874         (compile_print_command): Process options.  Scope data pointer is
6875         now a value_print_options pointer; adjust.
6876         (_initialize_compile): Update "compile print"'s help to include
6877         supported options.  Install a completer for "compile print".
6878         * cp-valprint.c (show_vtblprint, show_objectprint)
6879         (show_static_field_print): Delete.
6880         (_initialize_cp_valprint): Don't install "set print
6881         static-members", "set print vtbl", "set print object" here.
6882         * printcmd.c: Include "cli/cli-option.h" and
6883         "common/gdb_optional.h".
6884         (print_command_parse_format): Rework to fill in a
6885         value_print_options instead of a format_data.
6886         (print_value): Change parameter type from format_data pointer to
6887         value_print_options reference.  Adjust.
6888         (print_command_1): Process options.  Adjust to pass down a
6889         value_print_options.
6890         (print_command_completer): New.
6891         (_initialize_printcmd): Install print_command_completer as
6892         handle_brkchars completer for the "print" command.  Update
6893         "print"'s help to include supported options.
6894         * valprint.c: Include "cli/cli-option.h".
6895         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6896         here from cp-valprint.c.
6897         (boolean_option_def, uinteger_option_def)
6898         (value_print_option_defs, make_value_print_options_def_group):
6899         New.  Use gdb::option::add_setshow_cmds_for_options to install
6900         "set print elements", "set print null-stop", "set print repeats",
6901         "set print pretty", "set print union", "set print array", "set
6902         print address", "set print symbol", "set print array-indexes".
6903         * valprint.h: Include <string> and "cli/cli-option.h".
6904         (make_value_print_options_def_group): Declare.
6905         (print_value): Change parameter type from format_data pointer to
6906         value_print_options reference.
6907         (print_command_completer): Declare.
6908
6909 2019-06-13  Pedro Alves  <palves@redhat.com>
6910
6911         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6912         (COMMON_SFILES): Add maint-test-settings.c.
6913         * cli/cli-decode.c (boolean_enums): New global, factored out from
6914         ...
6915         (add_setshow_boolean_cmd): ... here.
6916         * cli/cli-decode.h (boolean_enums): Declare.
6917         * cli/cli-option.c: New file.
6918         * cli/cli-option.h: New file.
6919         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6920         factored out from ...
6921         (parse_cli_boolean_value(const char *)): ... this.
6922         (is_unlimited_literal): Change parameter type to pointer to
6923         pointer.  Adjust and advance ARG pointer.
6924         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6925         (parse_cli_var_enum): New, factored out from ...
6926         (do_set_command): ... this.  Adjust.
6927         * cli/cli-setshow.h (parse_cli_boolean_value)
6928         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6929         (parse_cli_var_enum): Declare.
6930         * cli/cli-utils.c: Include "cli/cli-option.h".
6931         (get_ulongest): New.
6932         * cli/cli-utils.h (get_ulongest): Declare.
6933         (check_for_argument): New overloads.
6934         * maint-test-options.c: New file.
6935
6936 2019-06-13  Pedro Alves  <palves@redhat.com>
6937
6938         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6939         parse a range if "-" is at the end of the string.
6940
6941 2019-06-13  Pedro Alves  <palves@redhat.com>
6942
6943         * cli/cli-setshow.c (parse_auto_binary_operation)
6944         (parse_cli_boolean_value): Don't allow "o".
6945
6946 2019-06-13  Pedro Alves  <palves@redhat.com>
6947
6948         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6949         * NEWS: Mention maint test-settings KIND.
6950         * maint-test-settings.c: New file.
6951
6952 2019-06-13  Pedro Alves  <palves@redhat.com>
6953
6954         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6955         completer.
6956         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6957         "set" completers.
6958
6959 2019-06-13  Pedro Alves  <palves@redhat.com>
6960
6961         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6962         after item.
6963
6964 2019-06-13  Pedro Alves  <palves@redhat.com>
6965
6966         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6967
6968 2019-06-13  Pedro Alves <palves@redhat.com>
6969
6970         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6971         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6972         call.
6973         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6974         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6975         calls.
6976         (check_for_argument): Skip spaces after argument.
6977
6978 2019-06-13  Pedro Alves  <palves@redhat.com>
6979
6980         * thread.c (thread_apply_command): Adjust TID parsing.
6981         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6982         detected before end of string.
6983         (tid_is_in_list): Error out if LIST is invalid.
6984
6985 2019-06-13  Pedro Alves  <palves@redhat.com>
6986
6987         * completer.c (complete_line_internal_1): Rewind completion word
6988         point.
6989         (completion_tracker::advance_custom_word_point_by): Change
6990         parameter type to int.
6991         * completer.h (completion_tracker::advance_custom_word_point_by):
6992         Likewise.
6993
6994 2019-06-13  Pedro Alves  <palves@redhat.com>
6995
6996         * completer.c (advance_to_completion_word): Handle delimiters.
6997
6998 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6999
7000         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7001
7002 2019-06-11  Tom Tromey  <tom@tromey.com>
7003
7004         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7005         (xmalloc_failed): Move to alloc.c.
7006         * alloc.c: New file.
7007         * Makefile.in (COMMON_SFILES): Add alloc.c.
7008
7009 2019-06-11  Tom Tromey  <tom@tromey.com>
7010
7011         * nat/linux-waitpid.c: Don't include server.h.
7012         (linux_debug): Remove.
7013         (my_waitpid): Update.
7014
7015 2019-06-11  Tom Tromey  <tromey@adacore.com>
7016
7017         * infcall.c (_initialize_infcall): Remove trailing newline from
7018         help.
7019         * user-regs.c (_initialize_user_regs): Remove trailing newline
7020         from help.
7021         * typeprint.c (_initialize_typeprint): Remove trailing newline
7022         from help.
7023         * reverse.c (_initialize_reverse): Remove trailing newlines from
7024         help.
7025         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7026         from help.
7027         * language.c (add_set_language_command): Remove trailing newline
7028         from help.
7029         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7030         help.
7031         * disasm.c (_initialize_disasm): Remove trailing newline from
7032         help.
7033         * top.c (init_main): Remove trailing newline from help.
7034         * interps.c (_initialize_interpreter): Remove trailing newline
7035         from help.
7036         * btrace.c (_initialize_btrace): Remove trailing newlines from
7037         help.
7038         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7039         from help.
7040         * python/python.c (_initialize_python): Remove trailing newline
7041         from help.
7042         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7043         help.
7044         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7045         from help.  Reformat some text.
7046         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7047         from help.
7048         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7049         newline from help.
7050
7051 2019-06-11  Tom Tromey  <tromey@adacore.com>
7052
7053         * darwin-nat.c (darwin_decode_exception_message)
7054         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7055
7056 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7057
7058         * valops.c (value_slice): Check for not allocated or not
7059         associated values.
7060
7061 2019-06-10  Tom de Vries  <tdevries@suse.de>
7062
7063         PR gdb/24618
7064         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7065         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7066         invalid.
7067
7068 2019-06-10  Tom de Vries  <tdevries@suse.de>
7069
7070         PR gdb/24611
7071         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7072         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7073
7074 2019-06-10  Tom de Vries  <tdevries@suse.de>
7075
7076         PR symtab/24545
7077         * symtab.c (struct demangled_name_entry): Add language field.
7078         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7079         static minimal symbol".  Set and use language field.
7080
7081 2019-06-10  Tom Tromey  <tromey@adacore.com>
7082
7083         * ada-lang.c (_initialize_ada_language): Update help text.
7084
7085 2019-06-10  Tom Tromey  <tromey@adacore.com>
7086
7087         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7088         with a newline.
7089         * guile/guile.c (handle_boot_error): Don't end warning with a
7090         newline.
7091         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7092         warning with a newline.
7093         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7094         newline.
7095         (s12z_frame_cache): Likewise.
7096         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7097         a newline.
7098         * solib-svr4.c (disable_probes_interface): Don't end warning with
7099         a newline.
7100         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7101         newline.
7102         * python/python.c (do_finish_initialization): Don't end warning
7103         with a newline.
7104
7105 2019-06-10  Tom Tromey  <tom@tromey.com>
7106
7107         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7108         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7109         gdbpy_enter.
7110
7111 2019-06-10  Tom Tromey  <tromey@adacore.com>
7112
7113         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7114         data.
7115         (elf_new_init): Don't call stabsread_new_init.
7116         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7117         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7118         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7119
7120 2019-06-10  Tom de Vries  <tdevries@suse.de>
7121
7122         PR symtab/16264
7123         PR symtab/24517
7124         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7125
7126 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7127
7128         * source.c (find_and_open_source): Also rewrite relative file
7129         names.
7130
7131 2019-04-26  Amos Bird  <amosbird@gmail.com>
7132
7133         * annotate.c (annotate_thread_exited): Add "thread-exited"
7134         annotation.
7135
7136 2019-06-06  Tom Tromey  <tromey@adacore.com>
7137
7138         * maint.h (class scoped_command_stats): Use
7139         DISABLE_COPY_AND_ASSIGN.
7140         <print_time>: New method.
7141         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7142         print_time.
7143         (scoped_command_stats::print_time): New method.
7144
7145 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7146
7147         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7148         instructions of lengths 6 or 8 bytes.
7149
7150 2019-06-04  Pedro Alves  <palves@redhat.com>
7151
7152         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7153
7154         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7155         * breakpoint.c (condition_completer): Likewise.
7156         * cli/cli-dump.c (scan_expression): Likewise.
7157         * common/filestuff.c (mkdir_recursive): Likewise.
7158         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7159         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7160         (gdb_abspath): Likewise.
7161         * compile/compile-cplus-types.c
7162         (compile_cplus_instance::decl_name): Likewise.
7163         * completer.c (complete_explicit_location):
7164         (signal_completer, reg_or_group_completer_1): Likewise.
7165         * cp-support.c (cp_remove_params_if_any): Likewise.
7166         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7167         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7168         * infcmd.c (strip_bg_char): Likewise.
7169         * linespec.c (copy_token_string): Likewise.
7170         * mi/mi-main.c (output_cores): Likewise.
7171         * psymtab.c (psymtab_search_name):
7172         * symfile.c (test_set_ext_lang_command): Likewise.
7173         * target.c (target_fileio_read_stralloc): Likewise.
7174         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7175         * value.c (complete_internalvar): Likewise.
7176
7177 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7178
7179         Add objfile property to gdb.Type.
7180         * NEWS: Mention Python API addition.
7181         * python/py-type.c (typy_get_objfile): New method.
7182
7183 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7184
7185         * NEWS: Mention the new set|show style [title|highlight].
7186         Mention changes to "show style", "help" and "apropos".
7187
7188 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7189
7190         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7191         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7192         instead of print_help_for_command.
7193         (print_doc_of_command): New function.
7194         (help_list): Add 'apropos -v word' suggestion.
7195         (print_help_for_command): Style the command name using title style.
7196         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7197         (_initialize_cli_cmds): Describe -v in apropos_command help.
7198
7199 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7200
7201         * cli/cli-style.h (cli_style_option): Add name in constructor,
7202         add m_name class member, add constructor with intensity,
7203         add name class function.
7204         (cli_style_option::add_setshow_commands): Remove name argument.
7205         (highlight_style, title_style): New styles.
7206         * cli/cli-style.c (do_show): New function that shows a style
7207         characteristic styling the style name with itself.
7208         (set_style_name): New function.
7209         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7210         Update all callers according to the changes in cli/cli-style.h.
7211         * utils.h (fputs_highlighted): New function.
7212         * utils.c (fputs_highlighted): Likewise.
7213
7214 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7215
7216         * NEWS: Mention new pipe command and new convenience variables.
7217
7218 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7219
7220         * cli/cli-cmds.c (pipe_command): New function.
7221         (_initialize_cli_cmds): Call add_com for pipe_command.
7222         Define | as an alias for pipe.
7223         (exit_status_set_internal_vars): New function.
7224         (shell_escape): Call exit_status_set_internal_vars.
7225         cli/cli-decode.c (find_command_name_length): Recognize | as
7226         a single character command.
7227
7228 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7229
7230         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7231         top.c (execute_command_to_ui_file): New function, mostly a copy
7232         of execute_command_to_string.
7233         (execute_command_to_string): Implement by calling
7234         execute_command_to_ui_file.
7235
7236 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7237
7238         * top.h (saved_command_line): Remove declaration.
7239         * top.c (previous_saved_command_line, previous_repeat_arguments):
7240         New variables.
7241         (saved_command_line): Make static, define together with other
7242         'repeat variables'.
7243         (dont_repeat): Clear repeat_arguments.
7244         (repeat_previous, get_saved_command_line, save_command_line):
7245         New functions.
7246         (gdb_init): Initialize saved_command_line
7247         and previous_saved_command_line.
7248         * main.c (captured_main_1): Remove saved_command_line initialization.
7249         * event-top.c (handle_line_of_input): Update to use
7250         the new 'repeat' related functions instead of direct access to
7251         saved_command_line.
7252         * command.h (repeat_previous, get_saved_command_line,
7253         save_command_line): New declarations.
7254         (dont_repeat): Add comment.
7255
7256 2019-05-30  Tom Tromey  <tromey@adacore.com>
7257
7258         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7259         Fix comment.
7260         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7261
7262 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7263
7264         PR cli/24587
7265         * completer.c (complete): Initialize variable word.
7266
7267 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7268
7269         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7270         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7271         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7272         'body' is NULL to the outter 'if', protecting the '!is_define'
7273         situation as well.
7274
7275 2019-05-29  Tom Tromey  <tromey@adacore.com>
7276
7277         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7278         (dwarf_unknown): New function.
7279         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7280         (dwarf_type_encoding_name): Use dwarf_unknown.
7281
7282 2019-05-29  Tom Tromey  <tromey@adacore.com>
7283
7284         PR c++/20020:
7285         * cp-valprint.c (cp_print_value_fields): Call
7286         cp_print_static_field inside "try".
7287
7288 2019-05-29  Tom Tromey  <tromey@adacore.com>
7289
7290         * inflow.c (struct terminal_info): Add default operator=.
7291         * configure: Rebuild.
7292         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7293         -Wdeprecated-copy-dtor, -Wredundant-move.
7294
7295 2019-05-29  Tom Tromey  <tromey@adacore.com>
7296
7297         * NEWS: Add entry.
7298         * infcmd.c (print_return_value_1): Handle finish_print
7299         option.
7300         (show_print_finish): New function.
7301         (_initialize_infcmd): Add "set/show print finish" commands.
7302         * valprint.c (user_print_options): Initialize new member.
7303         * valprint.h (struct value_print_options) <finish_print>: New
7304         member.
7305
7306 2019-05-28  Tom Tromey  <tromey@adacore.com>
7307
7308         * ada-lang.c (ada_remove_Xbn_suffix)
7309         (find_old_style_renaming_symbol)
7310         (parse_old_style_renaming): Remove.
7311         (ada_find_renaming_symbol): Don't call
7312         find_old_style_renaming_symbol.
7313         (ada_is_renaming_symbol): Rename from
7314         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7315         bool.  Now static.
7316         (ada_read_var_value): Update and simplify.
7317         * ada-exp.y (write_var_or_type): Remove old code.
7318
7319 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7320
7321         PR gdb/25010
7322         * event-top.c: Remove include comment.
7323         * inflow.c (class scoped_ignore_sigttou): Move from here...
7324         * inflow.h (class scoped_ignore_sigttou): ...to here.
7325         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7326         * top.c:  Remove include comment.
7327
7328 2019-05-27  Tom Tromey  <tom@tromey.com>
7329
7330         * NEWS: Fix typo.
7331
7332 2019-05-22  Tom Tromey  <tromey@adacore.com>
7333
7334         * target.c (target_follow_exec): Constify parameter.
7335         * target-delegates.c: Rebuild.
7336         * remote.c (remote_target::follow_exec): Constify parameter.
7337         * infrun.c (follow_exec): Constify parameter.
7338         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7339         (target_follow_exec): Likewise.
7340
7341 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7342
7343         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7344         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7345
7346 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7347
7348         * NEWS: Add debugredirect and testsuite sections.
7349
7350 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7351
7352         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7353         target descriptions using exclusively floating point register name
7354         aliases.
7355
7356 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7357
7358         PR gdb/18644:
7359         * f-lang.c (build_fortran_types): Handle the case where
7360         gdbarch_floatformat_for_type returns a nullptr.
7361
7362 2019-05-21  Tom de Vries  <tdevries@suse.de>
7363
7364         PR cli/24587
7365         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7366
7367 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7368
7369         PR gdb/18644:
7370         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7371         16-byte floats.
7372         * i386-tdep.c (i386_floatformat_for_type): Use
7373         floatformats_ia64_quad for the 16-byte floating point component
7374         within a fortran 32-byte complex number.
7375
7376 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7377
7378         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7379         delete default constructor.
7380         (find_partial_die): Update to return const struct.
7381         (partial_die_parent_scope): Move variable declaration into scope
7382         of its use and change its type to auto.
7383         (guess_partial_die_structure_name): Likewise.
7384         (partial_die_info::fixup): Likewise.
7385
7386 2019-05-17  Tom Tromey  <tromey@adacore.com>
7387
7388         * source.c (find_and_open_source): Remove cast.
7389
7390 2019-05-17  Tom Tromey  <tromey@adacore.com>
7391
7392         * annotate.c (annotate_source): Make "filename" const.
7393         * annotate.h (annotate_source): Use const.
7394
7395 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7396
7397         * disasm.c (set_disassembler_options): Send errors to stderr.
7398
7399 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7400
7401         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7402         (cli_interp_base::set_logging): Check debug_redirect.
7403         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7404         * cli/cli-logging.c (debug_redirect): Add static variable.
7405         (pop_output_files): Add default param.
7406         (handle_redirections): Print debug setting.
7407         (show_logging_command): Likewise.
7408         (_initialize_cli_logging): Add debugredirect command.
7409         * interps.c (current_interp_set_logging): Add debug_redirect
7410         parameter.
7411         * interps.h (set_logging): Add debug_redirect parameter.
7412         (current_interp_set_logging): Likewise.
7413         * mi/mi-common.h: Likewise.
7414         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7415
7416 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7417             Tom Tromey  <tromey@adacore.com>
7418
7419         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7420         directly.
7421         * cli/cli-interp.h (make_logging_output): Remove declaration.
7422         * cli/cli-logging.c (make_logging_output): Remove function.
7423         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7424         directly.
7425         * ui-file.c (tee_file::tee_file): Remove bools.
7426         (tee_file::~tee_file): Remove deletes.
7427         * ui-file.h (tee_file): Remove bools.
7428
7429 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7430
7431         * mi/mi-cmds.h (mi_cmd_complete): New function.
7432         * mi/mi-main.c (mi_cmd_complete): Likewise.
7433         * mi/mi-cmds.c: Define new MI command -complete.
7434         * NEWS: Mention new -complete command.
7435
7436 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7437
7438         * completer.h (complete): New function.
7439         * completer.c (complete): Likewise.
7440         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7441         function defined in completer.h.
7442
7443 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7444
7445         * MAINTAINERS (Write After Approval): Add myself.
7446
7447 2019-05-17  Tom de Vries  <tdevries@suse.de>
7448
7449         PR gdb/24094
7450         * dwarf2read.c (struct cu_partial_die_info): New struct.
7451         (find_partial_die): Return cu_partial_die_info.
7452         (partial_die_parent_scope, guess_partial_die_structure_name)
7453         (partial_die_info::fixup): Handle new return type of find_partial_die.
7454
7455 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7456
7457         PR breakpoints/24541
7458         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7459         "std::string", simplifying the algorithm.
7460
7461 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7462
7463         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7464         (stap_static_probe_ops::get_probes): Likewise.
7465
7466 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7467
7468         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7469         '-')" and "else if".
7470         (stap_parse_single_operand): Join checks for
7471         "gdbarch_stap_parse_special_token_p" and
7472         "gdbarch_stap_parse_special_token" in the same "if" statement.
7473         Invert check when verifying for operation on register
7474         displacement.
7475
7476 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7477
7478         * stap-probe.c (stap_get_opcode): Update comment.
7479         (stap_get_expected_argument_type): Likewise.
7480         (handle_stap_probe): Likewise.
7481
7482 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7483
7484         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7485         return type to 'bool'.  Adjust comment.  Use 'bool' when
7486         appropriate.
7487         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7488         * stap-probe.c (stap_parse_argument_1): Likewise.
7489         (stap_is_operator): Likewise.
7490         (stap_is_generic_prefix): Likewise.
7491         (stap_is_register_prefix): Likewise.
7492         (stap_is_register_indirection_prefix): Likewise.
7493         (stap_is_integer_prefix): Likewise.
7494         (stap_generic_check_suffix): Likewise.
7495         (stap_check_integer_suffix): Likewise.
7496         (stap_check_register_suffix): Likewise.
7497         (stap_check_register_indirection_suffix): Likewise.
7498         (stap_parse_register_operand): Likewise.
7499         (stap_parse_single_operand): Likewise.
7500         (stap_parse_argument_1): Likewise.
7501         (stap_probe::get_argument_count): Likewise.
7502         (stap_is_operator): Likewise.
7503
7504 2019-05-16  Tom Tromey  <tromey@adacore.com>
7505
7506         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7507         keyword to foreach.
7508
7509 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7510
7511         * linux-thread-db.c (try_thread_db_load_1): Change return type
7512         to bool.
7513         (try_thread_db_load): Likewise.
7514         (try_thread_db_load_from_pdir_1): Likewise.
7515         (try_thread_db_load_from_pdir): Likewise.
7516         (try_thread_db_load_from_sdir): Likewise.
7517         (try_thread_db_load_from_dir): Likewise.
7518         (thread_db_load_search): Likewise.
7519         (has_libpthread): Likewise.
7520         (thread_db_load): Likewise.
7521
7522 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7523
7524         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7525         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7526         NULL, and complain/return if that's the case.
7527
7528 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7529
7530         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7531         (advance, posn, abstract_read_memory): New functions.
7532         [struct mem_read_abstraction]: New struct.
7533         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7534
7535 2019-05-14  Tom Tromey  <tromey@adacore.com>
7536
7537         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7538         value is not lval_memory.
7539
7540 2019-05-14  Tom Tromey  <tromey@adacore.com>
7541
7542         * solib.c (info_sharedlibrary_command): Style the file name.
7543
7544 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7545
7546         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7547         (aarch64_vnv_type): Likewise.
7548         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7549         * common/tdesc.c: Likewise.
7550         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7551         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7552         * features/aarch64-fpu.xml: Add ieee half view.
7553         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7554         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7555         * gdbtypes.h (struct builtin_type): Likewise.
7556         (struct objfile_type): Likewise.
7557
7558 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7559
7560         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7561         typo.
7562         * location.h (string_to_event_location): Likewise.
7563
7564 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7565
7566         GDB 8.3 released.
7567
7568 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7569
7570         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7571         New variable declaration.
7572         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7573         New variable.
7574         (print_one_breakpoint): Use ui_out::test_flags and new global
7575         variable to compute use_fixed_output.
7576         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7577         Remove.
7578         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7579         (mi_multi_location_breakpoint_output_fixed): Remove.
7580         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7581         new variable.
7582         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7583         fix_multi_location_breakpoint_output flag if version >= 3.
7584         * ui-out.h (enum ui_out_flag)
7585         <fix_multi_location_breakpoint_output>: New enumerator.
7586
7587 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7588
7589         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7590
7591 2019-05-10  Tom Tromey  <tromey@adacore.com>
7592
7593         * ada-lang.c (catch_ada_completer): New function.
7594         (_initialize_ada_language): Use it.
7595
7596 2019-05-10  Tom Tromey  <tromey@adacore.com>
7597
7598         * thread.c (print_thread_info): Make "requested_threads" const.
7599         * gdbthread.h (print_thread_info): Make "requested_threads"
7600         const.
7601         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7602         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7603
7604 2019-05-08  Tom Tromey  <tom@tromey.com>
7605
7606         * gdbtypes.c (objfile_type_data): Change type.
7607         (objfile_type, _initialize_gdbtypes): Update.
7608
7609 2019-05-08  Tom Tromey  <tom@tromey.com>
7610
7611         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7612         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7613         (_initialize_dwarf2_frame): Update.
7614
7615 2019-05-08  Tom Tromey  <tom@tromey.com>
7616
7617         * objc-lang.c (objc_objfile_data): Change type.
7618         (find_methods): Update.
7619         (_initialize_objc_lang): Remove.
7620
7621 2019-05-08  Tom Tromey  <tom@tromey.com>
7622
7623         * stabsread.c (rs6000_builtin_type_data): Change type.
7624         (rs6000_builtin_type, _initialize_stabsread): Update.
7625
7626 2019-05-08  Tom Tromey  <tom@tromey.com>
7627
7628         * mips-tdep.c (mips_pdr_data): Remove.
7629         (_initialize_mips_tdep): Update.
7630
7631 2019-05-08  Tom Tromey  <tom@tromey.com>
7632
7633         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7634         (hppa_init_objfile_priv_data, read_unwind_info)
7635         (find_unwind_entry, _initialize_hppa_tdep): Update.
7636
7637 2019-05-08  Tom Tromey  <tom@tromey.com>
7638
7639         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7640         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7641         on obstack.
7642         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7643
7644 2019-05-08  Tom Tromey  <tom@tromey.com>
7645
7646         * mdebugread.c (basic_type_data): Change type.
7647         (basic_type, _initialize_mdebugread): Update.
7648
7649 2019-05-08  Tom Tromey  <tom@tromey.com>
7650
7651         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7652
7653 2019-05-08  Tom Tromey  <tom@tromey.com>
7654
7655         * nto-tdep.c (nto_inferior_data_reg): Change type.
7656         (nto_inferior_data): Update.
7657         (nto_inferior_data_cleanup, nto_new_inferior_data)
7658         (_initialize_nto_tdep): Remove.
7659         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7660
7661 2019-05-08  Tom Tromey  <tom@tromey.com>
7662
7663         * ada-lang.c (struct ada_inferior_data): Add initializers.
7664         (ada_inferior_data): Change type.
7665         (ada_inferior_data_cleanup): Remove.
7666         (get_ada_inferior_data, ada_inferior_exit)
7667         (struct ada_pspace_data): Add initializers, destructor.
7668         (ada_pspace_data_handle): Change type.
7669         (get_ada_pspace_data): Update.
7670         (ada_pspace_data_cleanup): Remove.
7671
7672 2019-05-08  Tom Tromey  <tom@tromey.com>
7673
7674         * coffread.c (struct coff_symfile_info): Add initializers.
7675         (coff_objfile_data_key): Move lower.  Change type.
7676         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7677         Update.
7678         (coff_free_info): Remove.
7679
7680 2019-05-08  Tom Tromey  <tom@tromey.com>
7681
7682         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7683         (fbsd_pspace_data_handle): Move lower.  Change type.
7684         (get_fbsd_pspace_data): Update.
7685         (fbsd_pspace_data_cleanup): Remove.
7686         (_initialize_fbsd_tdep): Update.
7687
7688 2019-05-08  Tom Tromey  <tom@tromey.com>
7689
7690         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7691         (get_ada_tasks_pspace_data): Update.
7692         (ada_tasks_pspace_data_cleanup): Remove.
7693         (_initialize_tasks): Update.
7694         (ada_tasks_inferior_data_handle): Change type.
7695         (get_ada_tasks_inferior_data): Update.
7696         (ada_tasks_inferior_data_cleanup): Remove.
7697         (struct ada_tasks_pspace_data): Add initializers.
7698
7699 2019-05-08  Tom Tromey  <tom@tromey.com>
7700
7701         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7702         * symfile-debug.c (debug_sym_get_probes): Change type.
7703         * stap-probe.c (handle_stap_probe):
7704         (stap_static_probe_ops::get_probes): Change type.
7705         * probe.h (class static_probe_ops) <get_probes>: Change type.
7706         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7707         (parse_probes_in_pspace): Update.
7708         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7709         Update.
7710         (any_static_probe_ops::get_probes): Change type.
7711         * elfread.c (elfread_data): New typedef.
7712         (probe_key): Change type.
7713         (elf_get_probes): Likewise.  Update.
7714         (probe_key_free): Remove.
7715         (_initialize_elfread): Update.
7716         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7717         Change type.
7718         (dtrace_process_dof_probe, dtrace_process_dof)
7719         (dtrace_static_probe_ops::get_probe): Change type.
7720
7721 2019-05-08  Tom Tromey  <tom@tromey.com>
7722
7723         * xcoffread.c (struct xcoff_symfile_info): Rename from
7724         coff_symfile_info.  Add initializers.
7725         (xcoff_objfile_data_key): Move lower.  Change type.
7726         (XCOFF_DATA): Rewrite.
7727         (xcoff_free_info): Remove.
7728         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7729         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7730         (xcoff_initial_scan): Update.
7731
7732 2019-05-08  Tom Tromey  <tom@tromey.com>
7733
7734         * solib-svr4.c (struct svr4_info): Add initializers and
7735         destructor.
7736         <probes_table>: Now an htab_up.
7737         (solib_svr4_pspace_data): Change type.
7738         (free_probes_table): Simplify.
7739         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7740         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7741         (probes_table_remove_objfile_probes, register_solib_event_probe)
7742         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7743         (_initialize_svr4_solib): Update.
7744
7745 2019-05-08  Tom Tromey  <tom@tromey.com>
7746
7747         * remote.c (remote_pspace_data): Change type.
7748         (remote_pspace_data_cleanup): Remove.
7749         (get_remote_exec_file, set_pspace_remote_exec_file)
7750         (_initialize_remote): Update.
7751
7752 2019-05-08  Tom Tromey  <tom@tromey.com>
7753
7754         * breakpoint.c (breakpoint_objfile_key): Change type.
7755         (get_breakpoint_objfile_data): Update.
7756         (free_breakpoint_objfile_data): Remove.
7757         (_initialize_breakpoint): Update.
7758
7759 2019-05-08  Tom Tromey  <tom@tromey.com>
7760
7761         * linux-tdep.c (struct linux_info): Add initializers.
7762         (linux_inferior_data): Move.  Change type.
7763         (invalidate_linux_cache_inf): Update.
7764         (linux_inferior_data_cleanup): Remove.
7765         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7766
7767 2019-05-08  Tom Tromey  <tom@tromey.com>
7768
7769         * auxv.c (auxv_inferior_data): Move.  Change type.
7770         (auxv_inferior_data_cleanup): Remove.
7771         (invalidate_auxv_cache_inf): Rewrite.
7772         (get_auxv_inferior_data, _initialize_auxv): Update.
7773
7774 2019-05-08  Tom Tromey  <tom@tromey.com>
7775
7776         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7777         (symfile_debug_objfile_data_key): Change type.
7778         (symfile_debug_installed, debug_qf_has_symbols)
7779         (debug_qf_find_last_source_symtab)
7780         (debug_qf_forget_cached_source_info)
7781         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7782         (debug_qf_print_stats, debug_qf_dump)
7783         (debug_qf_expand_symtabs_for_function)
7784         (debug_qf_expand_all_symtabs)
7785         (debug_qf_expand_symtabs_with_fullname)
7786         (debug_qf_map_matching_symbols)
7787         (debug_qf_expand_symtabs_matching)
7788         (debug_qf_find_pc_sect_compunit_symtab)
7789         (debug_qf_map_symbol_filenames)
7790         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7791         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7792         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7793         (debug_sym_read_linetable, debug_sym_relocate): Update.
7794         (symfile_debug_free_objfile): Remove.
7795         (install_symfile_debug_logging, _initialize_symfile_debug):
7796         Update.
7797
7798 2019-05-08  Tom Tromey  <tom@tromey.com>
7799
7800         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7801         allocate_on_obstack.
7802         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7803         (get_dwarf2_per_objfile): Update.
7804         (set_dwarf2_per_objfile): Remove.
7805         (dwarf2_has_info, dwarf2_get_section_info): Update.
7806         (dwarf2_free_objfile): Remove.
7807         (_initialize_dwarf2_read): Update.
7808
7809 2019-05-08  Tom Tromey  <tom@tromey.com>
7810
7811         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7812         initializers.
7813         <unsupported_script_warning_printed,
7814         script_not_found_warning_printed>: Now bool.
7815         (auto_load_pspace_data): Change type.
7816         (~auto_load_pspace_info): Rename from
7817         auto_load_pspace_data_cleanup.
7818         (get_auto_load_pspace_data, init_loaded_scripts_info)
7819         (clear_section_scripts, maybe_print_unsupported_script_warning)
7820         (maybe_print_script_not_found_warning, _initialize_auto_load):
7821         Update.
7822
7823 2019-05-08  Tom Tromey  <tom@tromey.com>
7824
7825         * objfiles.c (objfile_pspace_info): Add destructor and
7826         initializers.
7827         (objfiles_pspace_data): Change type.
7828         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7829         (get_objfile_pspace_data): Update.
7830         (objfiles_bfd_data): Change type.
7831         (get_objfile_bfd_data): Update.
7832         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7833
7834 2019-05-08  Tom Tromey  <tom@tromey.com>
7835
7836         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7837         Change type.
7838         (get_catch_syscall_inferior_data): Update.
7839         (catch_syscall_inferior_data_cleanup): Remove.
7840         (_initialize_break_catch_syscall): Update.
7841
7842 2019-05-08  Tom Tromey  <tom@tromey.com>
7843
7844         * inflow.c (struct terminal_info): Add destructor and
7845         initializers.
7846         (inflow_inferior_data): Change type.
7847         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7848         (get_inflow_inferior_data, inflow_inferior_exit)
7849         (swap_terminal_info, _initialize_inflow): Update.
7850
7851 2019-05-08  Tom Tromey  <tom@tromey.com>
7852
7853         * target-dcache.c (target_dcache_cleanup): Remove.
7854         (target_dcache_aspace_key): Change type.
7855         (target_dcache_init_p, target_dcache_invalidate)
7856         (target_dcache_get, target_dcache_get_or_init)
7857         (_initialize_target_dcache): Update.
7858         * dcache.h (struct dcache_deleter): New.
7859
7860 2019-05-08  Tom Tromey  <tom@tromey.com>
7861
7862         * symtab.c (struct symbol_cache): Add destructor and
7863         initializers.
7864         (symbol_cache_key): Move.  Change type.
7865         (make_symbol_cache, free_symbol_cache): Remove.
7866         (get_symbol_cache): Update.
7867         (symbol_cache_cleanup): Remove.
7868         (ALL_PSPACES, symbol_cache_flush)
7869         (maintenance_print_symbol_cache)
7870         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7871         Update.
7872
7873 2019-05-08  Tom Tromey  <tom@tromey.com>
7874
7875         * symtab.c (struct main_info): Add destructor and initializers.
7876         (main_progspace_key): Move.  Change type.
7877         (get_main_info): Update.
7878         (main_info_cleanup): Remove.
7879         (_initialize_symtab): Update.
7880
7881 2019-05-08  Tom Tromey  <tom@tromey.com>
7882
7883         * registry.h (DECLARE_REGISTRY): Define the _key class.
7884
7885 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7886
7887         * NEWS: Merge two 'New commands' sections.
7888
7889 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7890
7891         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7892         parameter and use Ada language definition instead.
7893         (ada_val_print_ptr): Remove unused language parameter.
7894         (ada_val_print_num): Remove language parameter and use Ada language
7895         definition instead.
7896         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7897         parameter.
7898         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7899         parameter and use Ada language definition instead.
7900         (ada_val_print_1): Update all ada_val_print_xxx calls.
7901         Remove language parameter.
7902         (ada_val_print): Update ada_val_print_1 call.
7903
7904 2019-05-08  Tom Tromey  <tromey@adacore.com>
7905
7906         * remote.c (remote_hw_watchpoint_limit)
7907         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7908         Now static.
7909
7910 2019-05-08  Tom Tromey  <tromey@adacore.com>
7911
7912         * maint.c (_initialize_maint_cmds): Move initialization code to
7913         remote.c.
7914         (watchdog, show_watchdog): Move to remote.c.
7915         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7916         "watchdog" static.
7917         (_initialize_remote): Move initialization code from maint.c.
7918         * defs.h (watchdog): Don't declare.
7919
7920 2019-05-08  Tom Tromey  <tromey@adacore.com>
7921
7922         * tui/tui-interp.c: Include main.h.
7923         * interps.c: Include main.h.
7924         * main.h (interpreter_p): Declare.
7925         * defs.h (interpreter_p): Don't declare.
7926
7927 2019-05-08  Tom Tromey  <tromey@adacore.com>
7928
7929         * dwarf2loc.c: Include dwarf2read.h.
7930         * defs.h (read_unsigned_leb128): Don't declare.
7931         * dwarf2read.h (read_unsigned_leb128): Declare.
7932
7933 2019-05-08  Tom Tromey  <tromey@adacore.com>
7934
7935         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7936         method.
7937
7938 2019-05-08  Tom Tromey  <tromey@adacore.com>
7939
7940         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7941         when no wrap column is set.
7942
7943 2019-05-08  Tom Tromey  <tromey@adacore.com>
7944
7945         * c-lang.c (c_get_string): Handle non-C-style arrays.
7946
7947 2019-05-08  Tom Tromey  <tromey@adacore.com>
7948
7949         * typeprint.c (print_offset_data::update): Print the bit offset,
7950         not the number of bits remaining.
7951
7952 2019-05-08  Tom Tromey  <tromey@adacore.com>
7953
7954         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7955         padding at end of comment.
7956
7957 2019-05-08  Tom Tromey  <tromey@adacore.com>
7958
7959         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7960         Compare main types.
7961
7962 2019-05-06  Tom Tromey  <tom@tromey.com>
7963
7964         * common/scoped_mmap.c: Include common-defs.h.
7965         * common/scoped_mmap.h: Don't include config.h.
7966
7967 2019-05-04  Tom Tromey  <tom@tromey.com>
7968
7969         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7970         (struct aarch64_call_info): Add initializers.
7971         <si>: Now a std::vector.
7972         (pass_on_stack, aarch64_push_dummy_call): Update.
7973
7974 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7975             Tom Tromey  <tom@tromey.com>
7976
7977         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7978         (ppc_threads): Now a std::vector.  Now static.
7979         (hwdebug_find_thread_points_by_tid)
7980         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7981         Update.
7982
7983 2019-05-04  Tom Tromey  <tom@tromey.com>
7984
7985         * arc-tdep.c (arc_tdesc_init): Return bool.
7986
7987 2019-05-04  Tom Tromey  <tom@tromey.com>
7988
7989         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7990         Use gdb_assert_not_reached.
7991
7992 2019-05-04  Tom Tromey  <tom@tromey.com>
7993
7994         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7995         "false".
7996
7997 2019-05-04  Tom Tromey  <tom@tromey.com>
7998
7999         * arc-tdep.c (arc_tdesc_init): Use bool.
8000
8001 2019-05-04  Tom Tromey  <tom@tromey.com>
8002
8003         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8004
8005 2019-05-04  Tom Tromey  <tom@tromey.com>
8006
8007         * cli/cli-cmds.c (valid_command_p): Return bool.
8008
8009 2019-05-04  Tom Tromey  <tom@tromey.com>
8010
8011         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8012         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8013
8014 2019-05-04  Raul Tambre  <raul@tambre.ee>
8015
8016         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8017         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8018         operator for comparison.
8019
8020 2019-05-04  Tom Tromey  <tom@tromey.com>
8021
8022         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8023         (lookup_partial_symbol, print_partial_symbols)
8024         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8025         (psymbol_compare): Update.
8026         (add_psymbol_to_bcache): Clear the entire psymbol.
8027         (maintenance_check_psymtabs): Update.
8028         * psympriv.h (struct partial_symbol): Don't derive from
8029         general_symbol_info.
8030         <obj_section, unrelocated_address, address,
8031         set_unrelocated_address>: Update.
8032         <ginfo>: New member.
8033         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8034         (debug_names::write_psymbols): Update.
8035
8036 2019-05-04  Tom de Vries  <tdevries@suse.de>
8037
8038         * contrib/cc-with-tweaks.sh: Support -n arg.
8039
8040 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8041
8042         * corelow.c (core_target::detach): Ensure frame cache and
8043         register caches are cleared.
8044         inferior.c (exit_inferior_1): Likewise.
8045
8046 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8047             Tom Tromey  <tom@tromey.com>
8048
8049         * dictionary.c (collate_pending_symbols_by_language): Remove
8050         "struct" from foreach.
8051         * symtab.c (lookup_global_symbol_from_objfile)
8052         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8053         foreach.
8054         * ser-tcp.c (net_open): Remove "struct" from foreach.
8055         * objfiles.c (objfile_relocate, objfile_rebase)
8056         (objfile_has_symbols): Remove "struct" from foreach.
8057         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8058         from foreach.
8059         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8060         foreach.
8061         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8062         "struct" from foreach.
8063         * ada-lang.c (create_excep_cond_exprs)
8064         (ada_exception_catchpoint_cond_string): Remove "struct" from
8065         foreach.
8066
8067 2019-05-03  Tom Tromey  <tromey@adacore.com>
8068
8069         * ada-exp.y (convert_char_literal): Check suffix of each
8070         enumerator.
8071
8072 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8073
8074         PR ada/21406:
8075         * ada-exp.y (yywrap): Don't define.
8076         * ada-lex.l (%option): Add noyywrap
8077         (yywrap): Remove.
8078
8079 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8080
8081         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8082         _WIN32_WINNT to the XP level, unless already defined to a higher
8083         level.
8084
8085         * unittests/parse-connection-spec-selftests.c:
8086         * ser-tcp.c:
8087         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8088         override.
8089
8090         * symfile.c (find_separate_debug_file): Remove colon from the
8091         drive spec of DOS/Windows file names of the target, so that the
8092         file name produced from DEBUGDIR and the target's directory will
8093         be valid on DOS/Windows systems.
8094
8095 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8096
8097         * rust-lang.c (val_print_struct): Handle printing structures
8098         containing strings.
8099
8100 2019-05-02  Tom Tromey  <tromey@adacore.com>
8101
8102         * valarith.c (_initialize_valarith): Remove.
8103
8104 2019-05-01  Tom Tromey  <tromey@adacore.com>
8105
8106         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8107         bitfields.
8108
8109 2019-05-01  Tom Tromey  <tromey@adacore.com>
8110
8111         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8112         for big-endian copies.
8113
8114 2019-04-30  Ali Tamur  <tamur@google.com>
8115         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8116         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8117         (read_3_bytes): New function.
8118
8119 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8120
8121         * windows-nat.c (main_thread_id): Delete.
8122         (handle_output_debug_string): Replace main_thread_id by
8123         current_event.dwThreadId.
8124         (fake_create_process): Likewise.
8125         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8126         Do not set main_thread_id.
8127         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8128         current_event.dwThreadId.
8129         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8130
8131 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8132
8133         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8134         Use current_event.dwThreadId instead of main_thread_id.
8135
8136 2019-04-30  Tom Tromey  <tromey@adacore.com>
8137
8138         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8139         (create_excep_cond_exprs): Iterate over program spaces.
8140         (ada_exception_catchpoint_cond_string): Examine all minimal
8141         symbols for exception types.
8142
8143 2019-04-30  Tom Tromey  <tromey@adacore.com>
8144
8145         PR c++/24470:
8146         * dwarf2read.c (process_structure_scope): Handle case where type
8147         has template parameters but no symbol was created.
8148
8149 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8150             Chris January  <chris.january@arm.com>
8151
8152         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8153         qualifier.
8154         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8155
8156 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8157
8158         * f-typeprint.c (f_print_type): Update rules for printing
8159         whitespace.
8160         (f_type_print_varspec_suffix): Likewise.
8161
8162 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8163             Chris January  <chris.january@arm.com>
8164
8165         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8166         function arguments.
8167
8168 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8169
8170         * f-lang.c (build_fortran_types): Change name of void type to
8171         lower case.
8172         * f-typeprint.c (f_type_print_base): Print the name of the void
8173         type, rather than a fixed string.
8174         * f-valprint.c (f_decorations): Use lower case void string.
8175
8176 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8177             Chris January  <chris.january@arm.com>
8178
8179         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8180         types for Fortran.
8181
8182 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8183             Chris January  <chris.january@arm.com>
8184             David Lecomber  <david.lecomber@arm.com>
8185
8186         * f-exp.y (BINOP_INTRINSIC): New token.
8187         (exp): New parser rule handling BINOP_INTRINSIC.
8188         (f77_keywords): Add new builtin procedures.
8189         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8190         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8191         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8192         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8193         (print_unop_subexp_f): New function.
8194         (print_binop_subexp_f): New function.
8195         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8196         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8197         (dump_subexp_body_f): Likewise.
8198         (operator_check_f): Likewise.
8199         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8200         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8201
8202 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8203
8204         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8205         UNOP_KIND.
8206         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8207         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8208         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8209         (operator_length_f): New fuction.
8210         (print_subexp_f): New function.
8211         (op_name_f): New function.
8212         (dump_subexp_body_f): New function.
8213         (operator_check_f): New function.
8214         (exp_descriptor_f): Replace standard expression handling functions
8215         with new functions.
8216         * gdb/fortran-operator.def: New file.
8217         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8218         * gdb/std-operator.def: Remove UNOP_KIND.
8219
8220 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8221
8222         * std-operator.def: Remove unbalanced, stray double quote
8223         character.
8224
8225 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8226             Chris January  <chris.january@arm.com>
8227             Daniel Everett  <daniel.everett@arm.com>
8228             Nick Forrington  <nick.forrington@arm.com>
8229             Richard Bunt  <richard.bunt@arm.com>
8230
8231         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8232         of depth when printing anonymous structs or unions.
8233         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8234         Don't print either the top-level value, or the children if the
8235         max-depth is exceeded.
8236         (ppscm_print_children): When printing the key of a map, allow one
8237         extra level of depth.
8238         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8239         print either the top-level value, or the children if the max-depth
8240         is exceeded.
8241         (print_children): When printing the key of a map, allow one extra
8242         level of depth.
8243         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8244         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8245         (user_print_options): Initialise max_depth field.
8246         (val_print_scalar_or_string_type_p): New function.
8247         (val_print): Check to see if the max depth has been reached.
8248         (val_print_check_max_depth): Define new function.
8249         (show_print_max_depth): New function.
8250         (_initialize_valprint): Add 'print max-depth' option.
8251         * valprint.h (struct value_print_options) <max_depth>: New field.
8252         (val_print_check_max_depth): Declare new function.
8253         * NEWS: Document new feature.
8254
8255 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8256
8257         * ada-lang.c (ada_language_defn): Initialise new field.
8258         * c-lang.c (c_is_string_type_p): New function.
8259         (c_language_defn): Initialise new field.
8260         (cplus_language_defn): Initialise new field.
8261         (asm_language_defn): Initialise new field.
8262         (minimal_language_defn): Initialise new field.
8263         * c-lang.h (c_is_string_type_p): Declare new function.
8264         * d-lang.c (d_language_defn): Initialise new field.
8265         * f-lang.c (f_is_string_type_p): New function.
8266         (f_language_defn): Initialise new field.
8267         * go-lang.c (go_is_string_type_p): New function.
8268         (go_language_defn): Initialise new field.
8269         * language.c (default_is_string_type_p): New function.
8270         (unknown_language_defn): Initialise new field.
8271         (auto_language_defn): Initialise new field.
8272         * language.h (struct language_defn) <la_is_string_type_p>: New
8273         member variable.
8274         (default_is_string_type_p): Declare new function.
8275         * m2-lang.c (m2_language_defn): Initialise new field.
8276         * objc-lang.c (objc_language_defn): Initialise new field.
8277         * opencl-lang.c (opencl_language_defn): Initialise new field.
8278         * p-lang.c (pascal_is_string_type_p): New function.
8279         (pascal_language_defn): Initialise new field.
8280         * rust-lang.c (rust_is_string_type_p): New function.
8281         (rust_language_defn): Initialise new field.
8282
8283 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8284
8285         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8286         New field.
8287         * ada-lang.c (ada_language_defn): Initialise new field.
8288         * c-lang.c (c_language_defn): Likewise.
8289         (cplus_language_defn): Likewise.
8290         (asm_language_defn): Likewise.
8291         (minimal_language_defn): Likewise.
8292         * d-lang.c (d_language_defn): Likewise.
8293         * f-lang.c (f_language_defn): Likewise.
8294         * go-lang.c (go_language_defn): Likewise.
8295         * language.c (unknown_language_defn): Likewise.
8296         (auto_language_defn): Likewise.
8297         * m2-lang.c (m2_language_defn): Likewise.
8298         * objc-lang.c (objc_language_defn): Likewise.
8299         * opencl-lang.c (opencl_language_defn): Likewise.
8300         * p-lang.c (pascal_language_defn): Likewise.
8301         * rust-lang.c (rust_language_defn): Likewise.
8302
8303 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8304
8305         * ada-lang.c (ada_is_character_type): Change return type to bool.
8306         (ada_is_string_type): Likewise.
8307         * ada-lang.h (ada_is_character_type): Update declaration
8308         (ada_is_string_type): Likewise.
8309
8310 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8311
8312         Support style in 'frame|thread apply'
8313
8314         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8315         * record.c (record_start, record_stop): Update callers of
8316         execute_command_to_string with false.
8317         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8318         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8319         methods.
8320         (class string_file): New constructor with term_out parameter.
8321         Override methods term_out and can_emit_style_escape.  New member
8322         term_out.
8323         (class stdio_file): Override can_emit_style_escape.
8324         (class tee_file): Override term_out and can_emit_style_escape.
8325         * utils.h (can_emit_style_escape): Remove.
8326         * utils.c (can_emit_style_escape): Likewise.
8327         Update all callers of can_emit_style_escape (SOMESTREAM) to
8328         SOMESTREAM->can_emit_style_escape.
8329         * source-cache.c (source_cache::get_source_lines): Likewise.
8330         * stack.c (frame_apply_command_count): Call execute_command_to_string
8331         passing the term_out characteristic of the current gdb_stdout.
8332         * thread.c (thr_try_catch_cmd): Likewise.
8333         * top.c (execute_command_to_string): pass term_out parameter
8334         to construct the string_file for the command output.
8335         * ui-file.c (term_cli_styling): New function (most code moved
8336         from utils.c can_emit_style_escape).
8337         (string_file::string_file, string_file::can_emit_style_escape,
8338         stdio_file::can_emit_style_escape, tee_file::term_out,
8339         tee_file::can_emit_style_escape): New functions.
8340
8341 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8342
8343         * NEWS: Mention the new set|show may-call-functions.
8344         * infcall.c (may_call_functions_p): New variable.
8345         (show_may_call_functions_p): New function.
8346         (call_function_by_hand_dummy): Throws an error if not
8347         may-call-functions.
8348         (_initialize_infcall): Call add_setshow_boolean_cmd for
8349         may-call-functions.
8350
8351 2019-04-25  Keith Seitz  <keiths@redhat.com>
8352
8353         PR c++/24367
8354         * cp-support.c (inspect_type): Don't attempt substitutions
8355         of symbol with the same name.
8356
8357 2019-04-25  Tom Tromey  <tromey@adacore.com>
8358
8359         PR gdb/24475:
8360         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8361         static.
8362
8363 2019-04-25  Tom Tromey  <tromey@adacore.com>
8364
8365         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8366         rvalue reference.
8367         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8368         (gdb_xml_parser::parse): Use std::move.
8369         * python/python-internal.h (gdbpy_convert_exception): Take a const
8370         reference.
8371         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8372         std::move.
8373         * python/py-utils.c (gdbpy_convert_exception): Take a const
8374         reference.
8375         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8376         Use std::move.
8377         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8378         Use std::move.
8379         * mi/mi-main.c (mi_print_exception): Take a const reference.
8380         * main.c (handle_command_errors): Take a const reference.
8381         * linespec.c (parse_linespec): Use std::move.
8382         * infcall.c (run_inferior_call): Use std::move.
8383         (call_function_by_hand_dummy): Use std::move.
8384         * exec.c (try_open_exec_file): Use std::move.
8385         * exceptions.h (exception_print, exception_fprintf)
8386         (exception_print_same): Update.
8387         * exceptions.c (print_exception, exception_print)
8388         (exception_fprintf, exception_print_same): Change parameters to
8389         const reference.
8390         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8391         * common/new-op.c: Use std::move.
8392         * common/common-exceptions.h (struct gdb_exception): Add move
8393         constructor.
8394         (struct gdb_exception_error, struct gdb_exception_quit, struct
8395         gdb_quit_bad_alloc): Change constructor to move constructor.
8396         (throw_exception): Change parameter to rvalue reference.
8397         * common/common-exceptions.c (throw_exception): Take rvalue
8398         reference.
8399         * cli/cli-interp.c (safe_execute_command): Use std::move.
8400         * breakpoint.c (insert_bp_location, location_to_sals): Use
8401         std::move.
8402
8403 2019-04-25  Tom Tromey  <tromey@adacore.com>
8404
8405         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8406         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8407         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8408         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8409         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8410         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8411         guile/scm-value.c: Use unpack.
8412         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8413         gdbscm_gdb_exception.
8414         (gdbscm_throw_gdb_exception): Likewise.
8415         (struct gdbscm_gdb_exception): New.
8416         (unpack): New function.
8417         (gdbscm_wrap): Use unpack.
8418
8419 2019-04-25  Tom Tromey  <tromey@adacore.com>
8420
8421         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8422         (gdb_rl_callback_handler): Use std::move.
8423         * common/common-exceptions.h (struct gdb_exception): Add move
8424         assignment operator.
8425         (throw_exception_sjlj): Change "exception" to const reference.
8426         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8427         (throw_exception_sjlj): Change "exception" to const reference.
8428
8429 2019-04-25  Tom Tromey  <tromey@adacore.com>
8430
8431         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8432         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8433         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8434         Update.
8435         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8436         Update.
8437         * mi/mi-interp.c (mi_interp::exec): Update.
8438         * linespec.c (parse_linespec): Update.
8439         * infcall.c (run_inferior_call): Update.
8440         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8441         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8442         (gdbscm_lookup_global_symbol): Update.
8443         * guile/scm-param.c (gdbscm_parameter_value): Update.
8444         * guile/scm-frame.c (gdbscm_frame_read_register)
8445         (gdbscm_frame_read_var): Update.
8446         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8447         * exec.c (try_open_exec_file): Update.
8448         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8449         (gdb_rl_callback_handler): Update.
8450         * common/common-exceptions.h (exception_none): Don't declare.
8451         * common/common-exceptions.c (exception_none): Don't define.
8452         (struct catcher) <exception>: Update.
8453         * cli/cli-interp.c (safe_execute_command): Update.
8454         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8455
8456 2019-04-25  Ali Tamur  <tamur@google.com>
8457
8458         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8459         (read_attribute_value): Likewise.
8460         (dwarf2_read_addr_index): Update comment.
8461         (read_str_index): Add DW_FORM_strx.
8462         (dwarf2_string_attr): Likewise.
8463         (dwarf2_const_value_attr): Likewise.
8464         (dump_die_shallow): Likewise.
8465         (dwarf2_fetch_constant_bytes): Likewise.
8466         (skip_form_bytes): Likewise.
8467         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8468
8469 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8470
8471         PR corefiles/11608
8472         PR corefiles/18187
8473         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8474         OFFSET.  Verify if current mapping contains an ELF header.
8475         (linux_find_memory_regions_full): Adjust call to
8476         dump_mapping_p.
8477
8478 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8479             Kang Li <kanglictf@gmail.com>
8480
8481         PR gdb/21600
8482
8483         * dwarf2-frame.c (read_initial_length): Be consistent about using
8484         unsigned representation of length.
8485         (decode_frame_entry_1): Likewise.  Check for wraparound of
8486         end pointer as well as buffer overflow.
8487
8488 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8489
8490         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8491         "vq".
8492
8493 2019-04-24  Tom Tromey  <tromey@adacore.com>
8494
8495         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8496
8497 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8498
8499         * s12z-tdep.c (s12z_unwind_pc): Delete.
8500         (s12z_unwind_sp): Delete.
8501         (s12z_gdbarch_init): Don't register deleted functions with
8502         gdbarch.
8503
8504 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8505
8506         * rl78-tdep.c (rl78_unwind_sp): Delete.
8507         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8508
8509 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8510
8511         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8512         (xstormy16_unwind_pc): Delete.
8513         (xstormy16_dummy_id): Delete.
8514         (xstormy16_gdbarch_init): Don't register deleted functions with
8515         gdbarch.
8516
8517 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8518
8519         * vax-tdep.c (vax_unwind_pc): Delete.
8520         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8521
8522 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8523
8524         * v850-tdep.c (v850_unwind_sp): Delete.
8525         (v850_unwind_pc): Delete.
8526         (v850_dummy_id): Delete.
8527         (v850_gdbarch_init): Don't register deleted functions with
8528         gdbarch.
8529
8530 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8531
8532         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8533         (tilegx_unwind_pc): Delete.
8534         (tilegx_unwind_dummy_id): Delete.
8535         (tilegx_gdbarch_init): Don't register deleted functions with
8536         gdbarch.
8537
8538 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8539
8540         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8541         (tic6x_dummy_id): Delete.
8542         (tic6x_gdbarch_init): Don't register deleted functions with
8543         gdbarch.
8544
8545 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8546
8547         * sparc-tdep.c (sparc_unwind_pc): Delete.
8548         (sparc32_gdbarch_init): Don't register deleted function with
8549         gdbarch.
8550
8551 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8552
8553         * sh-tdep.c (sh_unwind_sp): Delete.
8554         (sh_unwind_pc): Delete.
8555         (sh_dummy_id): Delete.
8556         (sh_gdbarch_init): Don't register deleted functions with
8557         gdbarch.
8558
8559 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8560
8561         * score-tdep.c (score_unwind_sp): Delete.
8562         (score_unwind_pc): Delete.
8563         (score_dummy_id): Delete.
8564         (score_gdbarch_init): Don't register deleted functions with
8565         gdbarch.
8566
8567 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8568
8569         * rx-tdep.c (rx_unwind_pc): Delete.
8570         (rx_unwind_sp): Delete.
8571         (rx_dummy_id): Delete.
8572         (rx_gdbarch_init): Don't register deleted functions with
8573         gdbarch.  Update comment.
8574
8575 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8576
8577         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8578         (rs6000_dummy_id): Delete.
8579         (rs6000_gdbarch_init): Don't register deleted functions with
8580         gdbarch.
8581
8582 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8583
8584         * or1k-tdep.c (or1k_dummy_id): Delete.
8585         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8586
8587 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8588
8589         * nios2-tdep.c (nios2_dummy_id): Delete.
8590         (nios2_unwind_sp): Delete.
8591         (nios2_gdbarch_init): Don't register deleted functions with
8592         gdbarch.
8593
8594 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8595
8596         * nds32-tdep.c (nds32_dummy_id): Delete.
8597         (nds32_unwind_pc): Delete.
8598         (nds32_unwind_sp): Delete.
8599         (nds32_gdbarch_init): Don't register deleted functions with
8600         gdbarch.
8601
8602 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8603
8604         * msp430-tdep.c (msp430_unwind_pc): Delete.
8605         (msp430_unwind_sp): Delete.
8606         (msp430_dummy_id): Delete.
8607         (msp430_gdbarch_init): Don't register deleted functions with
8608         gdbarch.
8609
8610 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8611
8612         * moxie-tdep.c (moxie_unwind_sp): Delete.
8613         (moxie_unwind_pc): Delete.
8614         (moxie_dummy_id): Delete.
8615         (moxie_gdbarch_init): Don't register deleted functions with
8616         gdbarch.
8617
8618 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8619
8620         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8621         (mn10300_unwind_pc): Delete.
8622         (mn10300_unwind_sp): Delete.
8623         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8624         mn10300_unwind_sp.
8625         (mn10300_frame_unwind_init): Don't register deleted functions with
8626         gdbarch.
8627
8628 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8629
8630         * mep-tdep.c (mep_unwind_pc): Delete.
8631         (mep_unwind_sp): Delete.
8632         (mep_dummy_id): Delete.
8633         (mep_gdbarch_init): Don't register deleted functions with
8634         gdbarch.
8635
8636 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8637
8638         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8639         (m68hc11_unwind_sp): Delete.
8640         (m68hc11_gdbarch_init): Don't register deleted functions with
8641         gdbarch.
8642
8643 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8644
8645         * m32r-tdep.c (m32r_unwind_sp): Delete.
8646         (m32r_unwind_pc): Delete.
8647         (m32r_dummy_id): Delete.
8648         (m32r_gdbarch_init): Don't register deleted functions with
8649         gdbarch.
8650
8651 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8652
8653         * m32c-tdep.c (m32c_unwind_pc): Delete.
8654         (m32c_unwind_sp): Delete.
8655         (m32c_dummy_id): Delete.
8656         (m32c_gdbarch_init): Don't register deleted functions with
8657         gdbarch.
8658
8659 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8660
8661         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8662         (lm32_unwind_pc): Delete.
8663         (lm32_dummy_id): Delete.
8664         (lm32_gdbarch_init): Don't register deleted functions with
8665         gdbarch.
8666
8667 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8668
8669         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8670         (iq2000_unwind_pc): Delete.
8671         (iq2000_dummy_id): Delete.
8672         (iq2000_gdbarch_init): Don't register deleted functions with
8673         gdbarch.
8674
8675 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8676
8677         * nds32-tdep.c (nds32_type_align): Delete.
8678         (nds32_push_dummy_call): Use type_align instead.
8679
8680 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8681
8682         * arm-tdep.c (arm_type_align): Only handle vector override case.
8683         (arm_push_dummy_call): Use type_align.
8684         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8685
8686 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8687
8688         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8689         case.
8690         (pass_on_stack): Use type_align.
8691         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8692         function.
8693
8694 2019-04-23  Tom Tromey  <tromey@adacore.com>
8695
8696         * dwarf2read.c (line_header::file_name_at): Remove unused
8697         overload.
8698
8699 2019-04-23  Tom de Vries  <tdevries@suse.de>
8700
8701         PR gdb/24438
8702         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8703         invocation.
8704
8705
8706 2019-03-27  Ali Tamur  <tamur@google.com>
8707
8708         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8709         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8710         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8711         (dwarf_expr_context::get_addr_index): Likewise
8712         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8713         (symbol_needs_eval_context::get_addr_index): Likewise
8714         (disassemble_dwarf_expression): Add DW_OP_addrx
8715         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8716         (read_cutu_die_from_dwo): Update comment
8717         (skip_one_die): Add DW_FORM_addrx
8718         (read_attribute_value): Likewise
8719         (var_decode_location): Add DW_OP_addrx
8720         (dwarf2_const_value_attr): Add DW_FORM_addrx
8721         (dump_die_shallow): Likewise
8722         (dwarf2_fetch_constant_bytes): Likewise
8723         (decode_locdesc): Add DW_OP_addrx
8724         (skip_form_bytes): Add DW_FORM_addrx
8725
8726 2019-04-22  Ali Tamur  <tamur@google.com>
8727
8728         * MAINTAINERS (Write After Approval): Add self.
8729
8730 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8731
8732         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8733         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8734         (open_symbol_file_object): Likewise.
8735         (svr4_default_sos): Add info parameter.
8736         (svr4_read_so_list): Likewise.
8737         (svr4_current_sos_direct): Adjust functions calls to pass down
8738         info.
8739         (svr4_current_sos_1): Add info parameter.
8740         (svr4_current_sos): Call get_svr4_info, pass info down to
8741         svr4_current_sos_1.
8742         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8743         get_svr4_info.
8744         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8745         get_svr4_info.
8746         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8747         to get_svr4_info.
8748         (probes_table_remove_objfile_probes): Likewise.
8749         (register_solib_event_probe): Add info parameter.
8750         (solist_update_incremental): Pass info parameter down to
8751         svr4_read_so_list.
8752         (disable_probes_interface): Add info parameter.
8753         (svr4_handle_solib_event): Pass current_program_space to
8754         get_svr4_info.  Adjust disable_probes_interface cleanup.
8755         (svr4_create_probe_breakpoints): Add info parameter, pass it
8756         down to register_solib_event_probe.
8757         (svr4_create_solib_event_breakpoints): Add info parameter,
8758         pass it down to svr4_create_probe_breakpoints.
8759         (enable_break): Pass info down to
8760         svr4_create_solib_event_breakpoints.
8761         (svr4_solib_create_inferior_hook): Pass current_program_space to
8762         get_svr4_info.
8763         (svr4_clear_solib): Likewise.
8764
8765 2019-04-22  Pedro Alves  <palves@redhat.com>
8766
8767         * solib-svr4.c (svr4_free_objfile_observer): New.
8768         (probe_and_action::objfile): New field.
8769         (probes_table_htab_remove_objfile_probes)
8770         (probes_table_remove_objfile_probes): New functions.
8771         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8772         in the new probe_and_action.  Don't store the probe in 'lookup'.
8773         (svr4_create_probe_breakpoints): Pass objfile to
8774         register_solib_event_probe.
8775         (_initialize_svr4_solib): Register a free_objfile observer.
8776
8777 2019-04-19  Tom Tromey  <tom@tromey.com>
8778
8779         * common/queue.h: Remove.
8780
8781 2019-04-19  Tom Tromey  <tom@tromey.com>
8782
8783         * event-loop.c: Don't include "common/queue.h".
8784
8785 2019-04-19  Tom Tromey  <tom@tromey.com>
8786
8787         * remote.c (remote_target): Use delete.
8788         * remote-notif.h: Include <list>, not "common/queue.h".
8789         (notif_client_p): Remove typedef.
8790         (remote_notif_state): Add constructor, destructor, initializer.
8791         <notif_queue>: Now a std::list.
8792         (remote_notif_state_xfree): Don't declare.
8793         * remote-notif.c (remote_notif_process, handle_notification)
8794         (remote_notif_state_allocate): Update.
8795         (~remote_notif_state): Rename from remote_notif_state_xfree.
8796
8797 2019-04-19  Tom Tromey  <tom@tromey.com>
8798
8799         * symfile.c (reread_symbols): Update.
8800         * objfiles.c (objfile_register_static_link)
8801         (objfile_lookup_static_link): Update
8802         (~objfile) Don't delete static_links.
8803         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8804
8805 2019-04-19  Tom Tromey  <tom@tromey.com>
8806
8807         * type-stack.h (struct type_stack) <insert>: Constify string.
8808         * type-stack.c (type_stack::insert): Constify string.
8809         * gdbtypes.h (lookup_template_type): Update.
8810         (address_space_name_to_int): Update.
8811         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8812         const.
8813         (lookup_template_type): Make name const.
8814         * c-exp.y: Update rules.
8815         (lex_one_token, classify_name, classify_inner_name)
8816         (c_print_token): Update.
8817         * p-exp.y: Update rules.
8818         (yylex): Update.
8819         * f-exp.y: Update rules.
8820         (yylex): Update.
8821         * d-exp.y: Update rules.
8822         (lex_one_token, classify_name, classify_inner_name): Update.
8823         * parse.c (write_dollar_variable, copy_name): Return std::string.
8824         * parser-defs.h (copy_name): Change return type.
8825         * m2-exp.y: Update rules.
8826         (yylex): Update.
8827         * go-exp.y (lex_one_token): Update.
8828         Update rules.
8829         (classify_unsafe_function, classify_packaged_name)
8830         (classify_name, yylex): Update.
8831
8832 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8833
8834         * configure.ac: add --enable-source-highlight switch.
8835         * configure: Regenerate.
8836         * top.c (print_gdb_version): plumb --enable-source-highlight
8837         status to "show configuration".
8838
8839 2019-04-19  Tom Tromey  <tromey@adacore.com>
8840
8841         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8842         Check ADA_TYPE_P.
8843         (empty_record, ada_template_to_fixed_record_type_1)
8844         (template_to_static_fixed_type)
8845         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8846         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8847         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8848         macros.
8849
8850 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8851
8852         PR symtab/24423:
8853         * source.c (print_source_lines_base): Advance "iter" when a
8854         control character is seen.
8855
8856 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8857
8858         * inferior.h (struct infcall_suspend_state_deleter):
8859         Catch exception in destructor to avoid crash.
8860
8861 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8862
8863         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8864         close to the add_com "shell".
8865
8866 2019-04-18  Tom Tromey  <tromey@adacore.com>
8867
8868         * process-stratum-target.h (class process_stratum_target)
8869         <stratum>: Add "final".
8870
8871 2019-04-17  Tom Tromey  <tromey@adacore.com>
8872
8873         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8874         against nullptr before use.
8875
8876 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8877
8878         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8879
8880 2019-04-17  Jim Wilson  <jimw@sifive.com>
8881             Andrew Burgess  <andrew.burgess@embecosm.com>
8882
8883         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8884         code read might fail, assume 4-byte breakpoint in that case.
8885
8886 2019-04-15  Leszek Swirski  <leszeks@google.com>
8887
8888         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8889         rather than a hand-rolled POD check when checking for forced MEMORY
8890         classification.
8891
8892 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8893
8894         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8895         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8896         function.
8897         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8898         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8899         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8900         declaration.
8901
8902 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8903
8904         * aarch64-linux-nat.c
8905         (aarch64_linux_nat_target::thread_architecture): Add override.
8906         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8907         each VQ.
8908
8909 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8910
8911         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8912
8913 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8914
8915         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8916         target types of size 96-bits, add some additional comments, and
8917         check that the builtin type we found was the correct size.
8918
8919 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8920
8921         * utils.c (prompt_for_continue): Don't restore the styling at the
8922         end, as applied_style has the wrong value.  This fixes styling in
8923         long lists of file names that are interrupted by the "Continue?"
8924         prompt.
8925
8926 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8927
8928         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8929         * c-lang.c (c_language_defn): Likewise.
8930         (cplus_language_defn): Likewise.
8931         (asm_language_defn): Likewise.
8932         (minimal_language_defn): Likewise.
8933         * d-lang.c (d_language_defn): Likewise.
8934         * f-lang.c (f_language_defn): Likewise.
8935         * go-lang.c (go_language_defn): Likewise.
8936         * language.c (unknown_language_defn): Likewise.
8937         (auto_language_defn): Likewise.
8938         * language.h (struct language_defn): Remove la_magic field.
8939         (LANG_MAGIC): Delete.
8940         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8941         * objc-lang.c (objc_language_defn): Likewise.
8942         * opencl-lang.c (opencl_language_defn): Likewise.
8943         * p-lang.c (pascal_language_defn): Likewise.
8944         * rust-lang.c (rust_language_defn): Likewise.
8945
8946 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8947
8948         * riscv-tdep.c (riscv_type_align): New function.
8949         (riscv_type_alignment): Delete.
8950         (riscv_arg_location): Use 'type_align'.
8951         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8952
8953 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8954
8955         * gdbtypes.c (type_align): A struct with no non-static fields also
8956         has alignment of 1.
8957
8958 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8959
8960         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8961         component to 0.
8962         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8963         member.
8964         (riscv_struct_info::analyse): New implementation using new
8965         analyse_inner member function.
8966         (riscv_struct_info::field_offset): New member function.
8967         (riscv_struct_info::m_offsets): New member variable.
8968         (riscv_struct_info::analyse_inner): New private member function,
8969         takes the old implementation of riscv_struct_info::analyse but
8970         extended to track field offsets.
8971         (riscv_call_arg_struct): Update the struct folding special cases
8972         to handle cases where empty C++ structs, which are non-zero
8973         length, are found.
8974         (riscv_arg_location): Initialise the length of each location, a
8975         non-zero length now indicates the location is in use.
8976         (riscv_push_dummy_call): Allow for the first location having a
8977         non-zero offset when setting up arguments.
8978         (riscv_return_value): Likewise, but for return values.
8979
8980 2019-04-11  Tom Tromey  <tromey@adacore.com>
8981
8982         * utils.c (internal_vproblem): Make "msg" const.
8983
8984 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8985
8986         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8987         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8988         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8989         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8990
8991 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8992
8993         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8994         function.
8995         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8996         of amd64_collect_native_gregset.
8997         (amd64_linux_nat_target::store_registers): Likewise.
8998
8999 2019-04-10  Tom Tromey  <tom@tromey.com>
9000
9001         * symtab.c (lookup_global_symbol_from_objfile)
9002         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9003         * objfiles.h (class separate_debug_iterator): New.
9004         (class separate_debug_range): New.
9005         (struct objfile) <separate_debug_objfiles>: New method.
9006         (objfile_separate_debug_iterate): Don't declare.
9007         * objfiles.c (separate_debug_iterator::operator++): Rename from
9008         objfile_separate_debug_iterate.
9009         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9010         iterator.
9011         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9012         iterator.
9013
9014 2019-04-10  Tom Tromey  <tom@tromey.com>
9015
9016         * symfile.c (reread_symbols): Remove old comment.
9017         * objfiles.c (free_all_objfiles): Fix a typo.
9018
9019 2019-04-10  Tom Tromey  <tom@tromey.com>
9020
9021         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9022         * minsyms.c (lookup_minimal_symbol): Use foreach.
9023         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9024         (lookup_minimal_symbol_solib_trampoline): Likewise.
9025         * symfile.c (reread_symbols): Use foreach.
9026
9027 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9028             Tom Tromey  <tromey@adacore.com>
9029
9030         PR rust/24414:
9031         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9032         (rust_lex_int_test): Change "value" to be LONGEST.
9033         (rust_lex_tests): Add test for long integer literal.
9034
9035 2019-04-09  Tom Tromey  <tromey@adacore.com>
9036
9037         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9038         to bool.
9039         (extended_remote_target::attach): Update.
9040         (remote_target::remote_notice_new_inferior): Update.
9041         (remote_target::add_current_inferior_and_thread): Update.
9042         * inferior.c (exit_inferior_1): Use "false".
9043         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9044
9045 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9046
9047         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9048         the "start" command.
9049
9050 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9051
9052         * python/py-inferior.c (infpy_thread_from_thread_handle):
9053         Adjust comments to reflect renaming of thread_from_thread_handle
9054         to thread_from_handle.  Adjust keywords.  Fix type error message.
9055         (inferior_object_methods): Add thread_from_handle.  Retain
9056         thread_from_thread_handle, but mark it as deprecated.
9057
9058 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9059
9060         * gdbthread.h (find_thread_by_handle): Revise declaration.
9061         * thread.c (find_thread_by_handle): Likewise.  Adjust
9062         implementation too.
9063         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9064         support for buffer objects as handles.
9065
9066 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9067
9068         * python/py-infthread.c (thpy_thread_handle): New function.
9069         (thread_object_methods): Register thpy_thread_handle.
9070
9071 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9072
9073         * gdbthread.h (thread_to_thread_handle): Declare.
9074         * thread.c (gdbtypes.h): Include.
9075         (thread_to_thread_handle): New function.
9076
9077         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9078         (target_thread_info_to_thread_handle): Declare.
9079         * target.c (target_thread_info_to_thread_handle): New function.
9080         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9081         * target-delegates.c: Regenerate.
9082
9083         * linux-thread-db.c (class thread_db_target): Add method
9084         thread_info_to_thread_handle.
9085         (thread_db_target::thread_info_to_thread_handle): Define.
9086         * remote.c (class remote_target): Add new method
9087         thread_info_to_thread_handle.
9088         (remote_target::thread_info_to_thread_handle): Define.
9089
9090 2019-04-08  Pedro Alves  <palves@redhat.com>
9091
9092         * common/common-exceptions.c (throw_exception): Don't create
9093         named object to throw; throw directly.
9094         (throw_it): Likewise.  Don't initialize gdb_exception::message
9095         here, with new; pass FMT and AP to the ctor instead.
9096         * common/common-exceptions.h: Include <string>.
9097         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9098         const char *, va_list)): New ctor.  Use std::make_shared.
9099         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9100         errors)): Delete.
9101         (gdb_exception_error::gdb_exception_error(enum errors, const char
9102         *, va_list)): New.
9103         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9104         Add assertion.
9105         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9106         errors)): Delete.
9107         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9108         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9109         Add assertion.
9110
9111 2019-04-08  Tom Tromey  <tom@tromey.com>
9112
9113         * valops.c (value_rtti_indirect_type): Replace throw_exception
9114         with throw.
9115         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9116         with throw.
9117         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9118         throw.
9119         * target.c (target_translate_tls_address): Replace throw_exception
9120         with throw.
9121         * stack.c (frame_apply_command_count): Replace throw_exception
9122         with throw.
9123         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9124         throw.
9125         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9126         with throw.
9127         * rs6000-tdep.c (rs6000_frame_cache)
9128         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9129         * remote.c: Replace throw_exception with throw.
9130         * record-full.c (record_full_message, record_full_wait_1)
9131         (record_full_restore): Replace throw_exception with throw.
9132         * record-btrace.c:
9133         (get_thread_current_frame_id, record_btrace_start_replaying)
9134         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9135         (cmd_record_btrace_start): Replace throw_exception with throw.
9136         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9137         throw.
9138         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9139         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9140         * linespec.c:
9141         (find_linespec_symbols): Replace throw_exception with throw.
9142         * infrun.c (displaced_step_prepare, resume): Replace
9143         throw_exception with throw.
9144         * infcmd.c (post_create_inferior): Replace throw_exception with
9145         throw.
9146         * inf-loop.c (inferior_event_handler): Replace throw_exception
9147         with throw.
9148         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9149         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9150         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9151         (get_prev_frame_always, get_frame_pc_if_available)
9152         (get_frame_address_in_block_if_available, get_frame_language):
9153         Replace throw_exception with throw.
9154         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9155         throw_exception with throw.
9156         * eval.c (fetch_subexp_value, evaluate_var_value)
9157         (evaluate_funcall, evaluate_subexp_standard): Replace
9158         throw_exception with throw.
9159         * dwarf2loc.c (call_site_find_chain)
9160         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9161         Replace throw_exception with throw.
9162         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9163         with throw.
9164         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9165         throw.
9166         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9167         * completer.c (complete_line_internal): Replace throw_exception
9168         with throw.
9169         * compile/compile-object-run.c (compile_object_run): Replace
9170         throw_exception with throw.
9171         * cli/cli-script.c (process_next_line): Replace throw_exception
9172         with throw.
9173         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9174         (btrace_enable, btrace_maint_update_pt_packets): Replace
9175         throw_exception with throw.
9176         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9177         throw_exception with throw.
9178         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9179         throw_exception with throw.
9180         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9181         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9182         * aarch64-tdep.c (aarch64_make_prologue_cache)
9183         (aarch64_make_stub_cache): Replace throw_exception with throw.
9184
9185 2019-04-08  Tom Tromey  <tom@tromey.com>
9186
9187         * common/common-exceptions.c (throw_exception): Rename from
9188         throw_exception_cxx.  Remove old copy.  Make argument const.
9189         (throw_it): Create and throw exception objects directly.
9190         * common/common-exceptions.h (throw_exception): Make argument
9191         const.
9192         (struct gdb_exception_error): Add constructor.
9193         (struct gdb_exception_quit): Add constructor.
9194
9195 2019-04-08  Tom Tromey  <tom@tromey.com>
9196
9197         * common/common-exceptions.h (exception_rethrow): Don't declare.
9198         (TRY_SJLJ): Update comment.
9199         (TRY, CATCH, END_CATCH): Remove.
9200         * common/common-exceptions.c (exception_rethrow): Remove.
9201
9202 2019-04-08  Tom Tromey  <tom@tromey.com>
9203
9204         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9205         Remove.
9206         (gdb_exception_error): Rename from
9207         gdb_exception_RETURN_MASK_ERROR.
9208         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9209         (gdb_quit_bad_alloc): Update.
9210         * aarch64-tdep.c: Update.
9211         * ada-lang.c: Update.
9212         * ada-typeprint.c: Update.
9213         * ada-valprint.c: Update.
9214         * amd64-tdep.c: Update.
9215         * arch-utils.c: Update.
9216         * break-catch-throw.c: Update.
9217         * breakpoint.c: Update.
9218         * btrace.c: Update.
9219         * c-varobj.c: Update.
9220         * cli/cli-cmds.c: Update.
9221         * cli/cli-interp.c: Update.
9222         * cli/cli-script.c: Update.
9223         * common/common-exceptions.c: Update.
9224         * common/new-op.c: Update.
9225         * common/selftest.c: Update.
9226         * compile/compile-c-symbols.c: Update.
9227         * compile/compile-cplus-symbols.c: Update.
9228         * compile/compile-object-load.c: Update.
9229         * compile/compile-object-run.c: Update.
9230         * completer.c: Update.
9231         * corelow.c: Update.
9232         * cp-abi.c: Update.
9233         * cp-support.c: Update.
9234         * cp-valprint.c: Update.
9235         * darwin-nat.c: Update.
9236         * disasm-selftests.c: Update.
9237         * dtrace-probe.c: Update.
9238         * dwarf-index-cache.c: Update.
9239         * dwarf-index-write.c: Update.
9240         * dwarf2-frame-tailcall.c: Update.
9241         * dwarf2-frame.c: Update.
9242         * dwarf2loc.c: Update.
9243         * dwarf2read.c: Update.
9244         * eval.c: Update.
9245         * event-loop.c: Update.
9246         * event-top.c: Update.
9247         * exec.c: Update.
9248         * f-valprint.c: Update.
9249         * fbsd-tdep.c: Update.
9250         * frame-unwind.c: Update.
9251         * frame.c: Update.
9252         * gdbtypes.c: Update.
9253         * gnu-v3-abi.c: Update.
9254         * guile/guile-internal.h: Update.
9255         * guile/scm-block.c: Update.
9256         * guile/scm-breakpoint.c: Update.
9257         * guile/scm-cmd.c: Update.
9258         * guile/scm-disasm.c: Update.
9259         * guile/scm-frame.c: Update.
9260         * guile/scm-lazy-string.c: Update.
9261         * guile/scm-math.c: Update.
9262         * guile/scm-param.c: Update.
9263         * guile/scm-ports.c: Update.
9264         * guile/scm-pretty-print.c: Update.
9265         * guile/scm-symbol.c: Update.
9266         * guile/scm-symtab.c: Update.
9267         * guile/scm-type.c: Update.
9268         * guile/scm-value.c: Update.
9269         * i386-linux-tdep.c: Update.
9270         * i386-tdep.c: Update.
9271         * inf-loop.c: Update.
9272         * infcall.c: Update.
9273         * infcmd.c: Update.
9274         * infrun.c: Update.
9275         * jit.c: Update.
9276         * language.c: Update.
9277         * linespec.c: Update.
9278         * linux-fork.c: Update.
9279         * linux-nat.c: Update.
9280         * linux-tdep.c: Update.
9281         * linux-thread-db.c: Update.
9282         * main.c: Update.
9283         * mi/mi-cmd-break.c: Update.
9284         * mi/mi-cmd-stack.c: Update.
9285         * mi/mi-interp.c: Update.
9286         * mi/mi-main.c: Update.
9287         * objc-lang.c: Update.
9288         * p-valprint.c: Update.
9289         * parse.c: Update.
9290         * ppc-linux-tdep.c: Update.
9291         * printcmd.c: Update.
9292         * python/py-arch.c: Update.
9293         * python/py-breakpoint.c: Update.
9294         * python/py-cmd.c: Update.
9295         * python/py-finishbreakpoint.c: Update.
9296         * python/py-frame.c: Update.
9297         * python/py-framefilter.c: Update.
9298         * python/py-gdb-readline.c: Update.
9299         * python/py-inferior.c: Update.
9300         * python/py-infthread.c: Update.
9301         * python/py-lazy-string.c: Update.
9302         * python/py-linetable.c: Update.
9303         * python/py-objfile.c: Update.
9304         * python/py-param.c: Update.
9305         * python/py-prettyprint.c: Update.
9306         * python/py-progspace.c: Update.
9307         * python/py-record-btrace.c: Update.
9308         * python/py-record.c: Update.
9309         * python/py-symbol.c: Update.
9310         * python/py-type.c: Update.
9311         * python/py-unwind.c: Update.
9312         * python/py-utils.c: Update.
9313         * python/py-value.c: Update.
9314         * python/python.c: Update.
9315         * record-btrace.c: Update.
9316         * record-full.c: Update.
9317         * remote-fileio.c: Update.
9318         * remote.c: Update.
9319         * riscv-tdep.c: Update.
9320         * rs6000-aix-tdep.c: Update.
9321         * rs6000-tdep.c: Update.
9322         * rust-exp.y: Update.
9323         * rust-lang.c: Update.
9324         * s390-tdep.c: Update.
9325         * selftest-arch.c: Update.
9326         * solib-dsbt.c: Update.
9327         * solib-frv.c: Update.
9328         * solib-spu.c: Update.
9329         * solib-svr4.c: Update.
9330         * solib.c: Update.
9331         * sparc64-linux-tdep.c: Update.
9332         * stack.c: Update.
9333         * symfile-mem.c: Update.
9334         * symmisc.c: Update.
9335         * target.c: Update.
9336         * thread.c: Update.
9337         * top.c: Update.
9338         * tracefile-tfile.c: Update.
9339         * tui/tui.c: Update.
9340         * typeprint.c: Update.
9341         * unittests/cli-utils-selftests.c: Update.
9342         * unittests/parse-connection-spec-selftests.c: Update.
9343         * valops.c: Update.
9344         * valprint.c: Update.
9345         * value.c: Update.
9346         * varobj.c: Update.
9347         * windows-nat.c: Update.
9348         * x86-linux-nat.c: Update.
9349         * xml-support.c: Update.
9350
9351 2019-04-08  Tom Tromey  <tom@tromey.com>
9352
9353         * xml-support.c: Use C++ exception handling.
9354         * x86-linux-nat.c: Use C++ exception handling.
9355         * windows-nat.c: Use C++ exception handling.
9356         * varobj.c: Use C++ exception handling.
9357         * value.c: Use C++ exception handling.
9358         * valprint.c: Use C++ exception handling.
9359         * valops.c: Use C++ exception handling.
9360         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9361         handling.
9362         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9363         * typeprint.c: Use C++ exception handling.
9364         * tui/tui.c: Use C++ exception handling.
9365         * tracefile-tfile.c: Use C++ exception handling.
9366         * top.c: Use C++ exception handling.
9367         * thread.c: Use C++ exception handling.
9368         * target.c: Use C++ exception handling.
9369         * symmisc.c: Use C++ exception handling.
9370         * symfile-mem.c: Use C++ exception handling.
9371         * stack.c: Use C++ exception handling.
9372         * sparc64-linux-tdep.c: Use C++ exception handling.
9373         * solib.c: Use C++ exception handling.
9374         * solib-svr4.c: Use C++ exception handling.
9375         * solib-spu.c: Use C++ exception handling.
9376         * solib-frv.c: Use C++ exception handling.
9377         * solib-dsbt.c: Use C++ exception handling.
9378         * selftest-arch.c: Use C++ exception handling.
9379         * s390-tdep.c: Use C++ exception handling.
9380         * rust-lang.c: Use C++ exception handling.
9381         * rust-exp.y: Use C++ exception handling.
9382         * rs6000-tdep.c: Use C++ exception handling.
9383         * rs6000-aix-tdep.c: Use C++ exception handling.
9384         * riscv-tdep.c: Use C++ exception handling.
9385         * remote.c: Use C++ exception handling.
9386         * remote-fileio.c: Use C++ exception handling.
9387         * record-full.c: Use C++ exception handling.
9388         * record-btrace.c: Use C++ exception handling.
9389         * python/python.c: Use C++ exception handling.
9390         * python/py-value.c: Use C++ exception handling.
9391         * python/py-utils.c: Use C++ exception handling.
9392         * python/py-unwind.c: Use C++ exception handling.
9393         * python/py-type.c: Use C++ exception handling.
9394         * python/py-symbol.c: Use C++ exception handling.
9395         * python/py-record.c: Use C++ exception handling.
9396         * python/py-record-btrace.c: Use C++ exception handling.
9397         * python/py-progspace.c: Use C++ exception handling.
9398         * python/py-prettyprint.c: Use C++ exception handling.
9399         * python/py-param.c: Use C++ exception handling.
9400         * python/py-objfile.c: Use C++ exception handling.
9401         * python/py-linetable.c: Use C++ exception handling.
9402         * python/py-lazy-string.c: Use C++ exception handling.
9403         * python/py-infthread.c: Use C++ exception handling.
9404         * python/py-inferior.c: Use C++ exception handling.
9405         * python/py-gdb-readline.c: Use C++ exception handling.
9406         * python/py-framefilter.c: Use C++ exception handling.
9407         * python/py-frame.c: Use C++ exception handling.
9408         * python/py-finishbreakpoint.c: Use C++ exception handling.
9409         * python/py-cmd.c: Use C++ exception handling.
9410         * python/py-breakpoint.c: Use C++ exception handling.
9411         * python/py-arch.c: Use C++ exception handling.
9412         * printcmd.c: Use C++ exception handling.
9413         * ppc-linux-tdep.c: Use C++ exception handling.
9414         * parse.c: Use C++ exception handling.
9415         * p-valprint.c: Use C++ exception handling.
9416         * objc-lang.c: Use C++ exception handling.
9417         * mi/mi-main.c: Use C++ exception handling.
9418         * mi/mi-interp.c: Use C++ exception handling.
9419         * mi/mi-cmd-stack.c: Use C++ exception handling.
9420         * mi/mi-cmd-break.c: Use C++ exception handling.
9421         * main.c: Use C++ exception handling.
9422         * linux-thread-db.c: Use C++ exception handling.
9423         * linux-tdep.c: Use C++ exception handling.
9424         * linux-nat.c: Use C++ exception handling.
9425         * linux-fork.c: Use C++ exception handling.
9426         * linespec.c: Use C++ exception handling.
9427         * language.c: Use C++ exception handling.
9428         * jit.c: Use C++ exception handling.
9429         * infrun.c: Use C++ exception handling.
9430         * infcmd.c: Use C++ exception handling.
9431         * infcall.c: Use C++ exception handling.
9432         * inf-loop.c: Use C++ exception handling.
9433         * i386-tdep.c: Use C++ exception handling.
9434         * i386-linux-tdep.c: Use C++ exception handling.
9435         * guile/scm-value.c: Use C++ exception handling.
9436         * guile/scm-type.c: Use C++ exception handling.
9437         * guile/scm-symtab.c: Use C++ exception handling.
9438         * guile/scm-symbol.c: Use C++ exception handling.
9439         * guile/scm-pretty-print.c: Use C++ exception handling.
9440         * guile/scm-ports.c: Use C++ exception handling.
9441         * guile/scm-param.c: Use C++ exception handling.
9442         * guile/scm-math.c: Use C++ exception handling.
9443         * guile/scm-lazy-string.c: Use C++ exception handling.
9444         * guile/scm-frame.c: Use C++ exception handling.
9445         * guile/scm-disasm.c: Use C++ exception handling.
9446         * guile/scm-cmd.c: Use C++ exception handling.
9447         * guile/scm-breakpoint.c: Use C++ exception handling.
9448         * guile/scm-block.c: Use C++ exception handling.
9449         * guile/guile-internal.h: Use C++ exception handling.
9450         * gnu-v3-abi.c: Use C++ exception handling.
9451         * gdbtypes.c: Use C++ exception handling.
9452         * frame.c: Use C++ exception handling.
9453         * frame-unwind.c: Use C++ exception handling.
9454         * fbsd-tdep.c: Use C++ exception handling.
9455         * f-valprint.c: Use C++ exception handling.
9456         * exec.c: Use C++ exception handling.
9457         * event-top.c: Use C++ exception handling.
9458         * event-loop.c: Use C++ exception handling.
9459         * eval.c: Use C++ exception handling.
9460         * dwarf2read.c: Use C++ exception handling.
9461         * dwarf2loc.c: Use C++ exception handling.
9462         * dwarf2-frame.c: Use C++ exception handling.
9463         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9464         * dwarf-index-write.c: Use C++ exception handling.
9465         * dwarf-index-cache.c: Use C++ exception handling.
9466         * dtrace-probe.c: Use C++ exception handling.
9467         * disasm-selftests.c: Use C++ exception handling.
9468         * darwin-nat.c: Use C++ exception handling.
9469         * cp-valprint.c: Use C++ exception handling.
9470         * cp-support.c: Use C++ exception handling.
9471         * cp-abi.c: Use C++ exception handling.
9472         * corelow.c: Use C++ exception handling.
9473         * completer.c: Use C++ exception handling.
9474         * compile/compile-object-run.c: Use C++ exception handling.
9475         * compile/compile-object-load.c: Use C++ exception handling.
9476         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9477         * compile/compile-c-symbols.c: Use C++ exception handling.
9478         * common/selftest.c: Use C++ exception handling.
9479         * common/new-op.c: Use C++ exception handling.
9480         * cli/cli-script.c: Use C++ exception handling.
9481         * cli/cli-interp.c: Use C++ exception handling.
9482         * cli/cli-cmds.c: Use C++ exception handling.
9483         * c-varobj.c: Use C++ exception handling.
9484         * btrace.c: Use C++ exception handling.
9485         * breakpoint.c: Use C++ exception handling.
9486         * break-catch-throw.c: Use C++ exception handling.
9487         * arch-utils.c: Use C++ exception handling.
9488         * amd64-tdep.c: Use C++ exception handling.
9489         * ada-valprint.c: Use C++ exception handling.
9490         * ada-typeprint.c: Use C++ exception handling.
9491         * ada-lang.c: Use C++ exception handling.
9492         * aarch64-tdep.c: Use C++ exception handling.
9493
9494 2019-04-08  Tom Tromey  <tom@tromey.com>
9495
9496         * xml-support.c (gdb_xml_parser::parse): Update.
9497         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9498         * value.c (show_convenience): Update.
9499         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9500         (test_parse_flags_qcs): Update.
9501         * thread.c (thr_try_catch_cmd): Update.
9502         * target.c (target_translate_tls_address): Update.
9503         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9504         (info_frame_command_core, frame_apply_command_count): Update.
9505         * rust-exp.y (rust_lex_exception_test): Update.
9506         * riscv-tdep.c (riscv_print_one_register_info): Update.
9507         * remote.c (remote_target::enable_btrace): Update.
9508         * record-btrace.c (record_btrace_enable_warn): Update.
9509         * python/py-utils.c (gdbpy_convert_exception): Update.
9510         * printcmd.c (do_one_display, print_variable_and_value): Update.
9511         * mi/mi-main.c (mi_print_exception): Update.
9512         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9513         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9514         * linux-nat.c (linux_nat_target::attach): Update.
9515         * linux-fork.c (class scoped_switch_fork_info): Update.
9516         * infrun.c (displaced_step_prepare): Update.
9517         * infcall.c (call_function_by_hand_dummy): Update.
9518         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9519         * gnu-v3-abi.c (print_one_vtable): Update.
9520         * frame.c (get_prev_frame_always): Update.
9521         * f-valprint.c (info_common_command_for_block): Update.
9522         * exec.c (try_open_exec_file): Update.
9523         * exceptions.c (print_exception, exception_print)
9524         (exception_fprintf, exception_print_same): Update.
9525         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9526         * dwarf-index-cache.c (index_cache::store)
9527         (index_cache::lookup_gdb_index): Update.
9528         * darwin-nat.c (maybe_cache_shell): Update.
9529         * cp-valprint.c (cp_print_value_fields): Update.
9530         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9531         (gcc_cplus_symbol_address): Update.
9532         * compile/compile-c-symbols.c (gcc_convert_symbol)
9533         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9534         * common/selftest.c: Update.
9535         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9536         a std::string.
9537         (exception_try_scope_entry, exception_try_scope_exit): Don't
9538         declare.
9539         (struct exception_try_scope): Remove.
9540         (TRY): Don't use exception_try_scope.
9541         (struct gdb_exception): Add constructor, operator=.
9542         <what>: New method.
9543         (struct gdb_exception_RETURN_MASK_ALL)
9544         (struct gdb_exception_RETURN_MASK_ERROR)
9545         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9546         (struct gdb_quit_bad_alloc): Update.
9547         * common/common-exceptions.c (exception_none): Change
9548         initializer.
9549         (struct catcher) <state, exception>: Initialize inline.
9550         <prev>: Remove member.
9551         (current_catcher): Remove.
9552         (catchers): New global.
9553         (exceptions_state_mc_init): Simplify.
9554         (catcher_pop): Remove.
9555         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9556         (try_scope_depth, exception_try_scope_entry)
9557         (exception_try_scope_exit): Remove.
9558         (throw_exception_sjlj): Update.
9559         (exception_messages, exception_messages_size): Remove.
9560         (throw_it): Simplify.
9561         (gdb_exception_sliced_copy): Remove.
9562         (throw_exception_cxx): Update.
9563         * cli/cli-script.c (script_from_file): Update.
9564         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9565         Update.
9566         * ada-valprint.c (ada_val_print): Update.
9567         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9568         (create_excep_cond_exprs): Update.
9569
9570 2019-04-08  Tom Tromey  <tom@tromey.com>
9571
9572         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9573         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9574         (TRY, CATCH, END_CATCH): Remove some definitions.
9575         * common/common-exceptions.c: Don't use GDB_XCPT.
9576         (catcher_list_size): Remove.
9577         (throw_exception, throw_it): Simplify.
9578
9579 2019-04-05  Tom Tromey  <tom@tromey.com>
9580
9581         Revert the header-sorting patch.
9582         * ft32-tdep.c: Revert.
9583         * frv-tdep.c: Revert.
9584         * frv-linux-tdep.c: Revert.
9585         * frame.c: Revert.
9586         * frame-unwind.c: Revert.
9587         * frame-base.c: Revert.
9588         * fork-child.c: Revert.
9589         * findvar.c: Revert.
9590         * findcmd.c: Revert.
9591         * filesystem.c: Revert.
9592         * filename-seen-cache.h: Revert.
9593         * filename-seen-cache.c: Revert.
9594         * fbsd-tdep.c: Revert.
9595         * fbsd-nat.h: Revert.
9596         * fbsd-nat.c: Revert.
9597         * f-valprint.c: Revert.
9598         * f-typeprint.c: Revert.
9599         * f-lang.c: Revert.
9600         * extension.h: Revert.
9601         * extension.c: Revert.
9602         * extension-priv.h: Revert.
9603         * expprint.c: Revert.
9604         * exec.h: Revert.
9605         * exec.c: Revert.
9606         * exceptions.c: Revert.
9607         * event-top.c: Revert.
9608         * event-loop.c: Revert.
9609         * eval.c: Revert.
9610         * elfread.c: Revert.
9611         * dwarf2read.h: Revert.
9612         * dwarf2read.c: Revert.
9613         * dwarf2loc.c: Revert.
9614         * dwarf2expr.h: Revert.
9615         * dwarf2expr.c: Revert.
9616         * dwarf2-frame.c: Revert.
9617         * dwarf2-frame-tailcall.c: Revert.
9618         * dwarf-index-write.h: Revert.
9619         * dwarf-index-write.c: Revert.
9620         * dwarf-index-common.c: Revert.
9621         * dwarf-index-cache.h: Revert.
9622         * dwarf-index-cache.c: Revert.
9623         * dummy-frame.c: Revert.
9624         * dtrace-probe.c: Revert.
9625         * disasm.h: Revert.
9626         * disasm.c: Revert.
9627         * disasm-selftests.c: Revert.
9628         * dictionary.c: Revert.
9629         * dicos-tdep.c: Revert.
9630         * demangle.c: Revert.
9631         * dcache.h: Revert.
9632         * dcache.c: Revert.
9633         * darwin-nat.h: Revert.
9634         * darwin-nat.c: Revert.
9635         * darwin-nat-info.c: Revert.
9636         * d-valprint.c: Revert.
9637         * d-namespace.c: Revert.
9638         * d-lang.c: Revert.
9639         * ctf.c: Revert.
9640         * csky-tdep.c: Revert.
9641         * csky-linux-tdep.c: Revert.
9642         * cris-tdep.c: Revert.
9643         * cris-linux-tdep.c: Revert.
9644         * cp-valprint.c: Revert.
9645         * cp-support.c: Revert.
9646         * cp-namespace.c: Revert.
9647         * cp-abi.c: Revert.
9648         * corelow.c: Revert.
9649         * corefile.c: Revert.
9650         * continuations.c: Revert.
9651         * completer.h: Revert.
9652         * completer.c: Revert.
9653         * complaints.c: Revert.
9654         * coffread.c: Revert.
9655         * coff-pe-read.c: Revert.
9656         * cli-out.h: Revert.
9657         * cli-out.c: Revert.
9658         * charset.c: Revert.
9659         * c-varobj.c: Revert.
9660         * c-valprint.c: Revert.
9661         * c-typeprint.c: Revert.
9662         * c-lang.c: Revert.
9663         * buildsym.c: Revert.
9664         * buildsym-legacy.c: Revert.
9665         * build-id.h: Revert.
9666         * build-id.c: Revert.
9667         * btrace.c: Revert.
9668         * bsd-uthread.c: Revert.
9669         * breakpoint.h: Revert.
9670         * breakpoint.c: Revert.
9671         * break-catch-throw.c: Revert.
9672         * break-catch-syscall.c: Revert.
9673         * break-catch-sig.c: Revert.
9674         * blockframe.c: Revert.
9675         * block.c: Revert.
9676         * bfin-tdep.c: Revert.
9677         * bfin-linux-tdep.c: Revert.
9678         * bfd-target.c: Revert.
9679         * bcache.c: Revert.
9680         * ax-general.c: Revert.
9681         * ax-gdb.h: Revert.
9682         * ax-gdb.c: Revert.
9683         * avr-tdep.c: Revert.
9684         * auxv.c: Revert.
9685         * auto-load.c: Revert.
9686         * arm-wince-tdep.c: Revert.
9687         * arm-tdep.c: Revert.
9688         * arm-symbian-tdep.c: Revert.
9689         * arm-pikeos-tdep.c: Revert.
9690         * arm-obsd-tdep.c: Revert.
9691         * arm-nbsd-tdep.c: Revert.
9692         * arm-nbsd-nat.c: Revert.
9693         * arm-linux-tdep.c: Revert.
9694         * arm-linux-nat.c: Revert.
9695         * arm-fbsd-tdep.c: Revert.
9696         * arm-fbsd-nat.c: Revert.
9697         * arm-bsd-tdep.c: Revert.
9698         * arch-utils.c: Revert.
9699         * arc-tdep.c: Revert.
9700         * arc-newlib-tdep.c: Revert.
9701         * annotate.h: Revert.
9702         * annotate.c: Revert.
9703         * amd64-windows-tdep.c: Revert.
9704         * amd64-windows-nat.c: Revert.
9705         * amd64-tdep.c: Revert.
9706         * amd64-sol2-tdep.c: Revert.
9707         * amd64-obsd-tdep.c: Revert.
9708         * amd64-obsd-nat.c: Revert.
9709         * amd64-nbsd-tdep.c: Revert.
9710         * amd64-nbsd-nat.c: Revert.
9711         * amd64-nat.c: Revert.
9712         * amd64-linux-tdep.c: Revert.
9713         * amd64-linux-nat.c: Revert.
9714         * amd64-fbsd-tdep.c: Revert.
9715         * amd64-fbsd-nat.c: Revert.
9716         * amd64-dicos-tdep.c: Revert.
9717         * amd64-darwin-tdep.c: Revert.
9718         * amd64-bsd-nat.c: Revert.
9719         * alpha-tdep.c: Revert.
9720         * alpha-obsd-tdep.c: Revert.
9721         * alpha-nbsd-tdep.c: Revert.
9722         * alpha-mdebug-tdep.c: Revert.
9723         * alpha-linux-tdep.c: Revert.
9724         * alpha-linux-nat.c: Revert.
9725         * alpha-bsd-tdep.c: Revert.
9726         * alpha-bsd-nat.c: Revert.
9727         * aix-thread.c: Revert.
9728         * agent.c: Revert.
9729         * addrmap.c: Revert.
9730         * ada-varobj.c: Revert.
9731         * ada-valprint.c: Revert.
9732         * ada-typeprint.c: Revert.
9733         * ada-tasks.c: Revert.
9734         * ada-lang.c: Revert.
9735         * aarch64-tdep.c: Revert.
9736         * aarch64-ravenscar-thread.c: Revert.
9737         * aarch64-newlib-tdep.c: Revert.
9738         * aarch64-linux-tdep.c: Revert.
9739         * aarch64-linux-nat.c: Revert.
9740         * aarch64-fbsd-tdep.c: Revert.
9741         * aarch64-fbsd-nat.c: Revert.
9742         * aarch32-linux-nat.c: Revert.
9743
9744 2019-04-05  Tom Tromey  <tom@tromey.com>
9745
9746         * ft32-tdep.c: Sort headers.
9747         * frv-tdep.c: Sort headers.
9748         * frv-linux-tdep.c: Sort headers.
9749         * frame.c: Sort headers.
9750         * frame-unwind.c: Sort headers.
9751         * frame-base.c: Sort headers.
9752         * fork-child.c: Sort headers.
9753         * findvar.c: Sort headers.
9754         * findcmd.c: Sort headers.
9755         * filesystem.c: Sort headers.
9756         * filename-seen-cache.h: Sort headers.
9757         * filename-seen-cache.c: Sort headers.
9758         * fbsd-tdep.c: Sort headers.
9759         * fbsd-nat.h: Sort headers.
9760         * fbsd-nat.c: Sort headers.
9761         * f-valprint.c: Sort headers.
9762         * f-typeprint.c: Sort headers.
9763         * f-lang.c: Sort headers.
9764         * extension.h: Sort headers.
9765         * extension.c: Sort headers.
9766         * extension-priv.h: Sort headers.
9767         * expprint.c: Sort headers.
9768         * exec.h: Sort headers.
9769         * exec.c: Sort headers.
9770         * exceptions.c: Sort headers.
9771         * event-top.c: Sort headers.
9772         * event-loop.c: Sort headers.
9773         * eval.c: Sort headers.
9774         * elfread.c: Sort headers.
9775         * dwarf2read.h: Sort headers.
9776         * dwarf2read.c: Sort headers.
9777         * dwarf2loc.c: Sort headers.
9778         * dwarf2expr.h: Sort headers.
9779         * dwarf2expr.c: Sort headers.
9780         * dwarf2-frame.c: Sort headers.
9781         * dwarf2-frame-tailcall.c: Sort headers.
9782         * dwarf-index-write.h: Sort headers.
9783         * dwarf-index-write.c: Sort headers.
9784         * dwarf-index-common.c: Sort headers.
9785         * dwarf-index-cache.h: Sort headers.
9786         * dwarf-index-cache.c: Sort headers.
9787         * dummy-frame.c: Sort headers.
9788         * dtrace-probe.c: Sort headers.
9789         * disasm.h: Sort headers.
9790         * disasm.c: Sort headers.
9791         * disasm-selftests.c: Sort headers.
9792         * dictionary.c: Sort headers.
9793         * dicos-tdep.c: Sort headers.
9794         * demangle.c: Sort headers.
9795         * dcache.h: Sort headers.
9796         * dcache.c: Sort headers.
9797         * darwin-nat.h: Sort headers.
9798         * darwin-nat.c: Sort headers.
9799         * darwin-nat-info.c: Sort headers.
9800         * d-valprint.c: Sort headers.
9801         * d-namespace.c: Sort headers.
9802         * d-lang.c: Sort headers.
9803         * ctf.c: Sort headers.
9804         * csky-tdep.c: Sort headers.
9805         * csky-linux-tdep.c: Sort headers.
9806         * cris-tdep.c: Sort headers.
9807         * cris-linux-tdep.c: Sort headers.
9808         * cp-valprint.c: Sort headers.
9809         * cp-support.c: Sort headers.
9810         * cp-namespace.c: Sort headers.
9811         * cp-abi.c: Sort headers.
9812         * corelow.c: Sort headers.
9813         * corefile.c: Sort headers.
9814         * continuations.c: Sort headers.
9815         * completer.h: Sort headers.
9816         * completer.c: Sort headers.
9817         * complaints.c: Sort headers.
9818         * coffread.c: Sort headers.
9819         * coff-pe-read.c: Sort headers.
9820         * cli-out.h: Sort headers.
9821         * cli-out.c: Sort headers.
9822         * charset.c: Sort headers.
9823         * c-varobj.c: Sort headers.
9824         * c-valprint.c: Sort headers.
9825         * c-typeprint.c: Sort headers.
9826         * c-lang.c: Sort headers.
9827         * buildsym.c: Sort headers.
9828         * buildsym-legacy.c: Sort headers.
9829         * build-id.h: Sort headers.
9830         * build-id.c: Sort headers.
9831         * btrace.c: Sort headers.
9832         * bsd-uthread.c: Sort headers.
9833         * breakpoint.h: Sort headers.
9834         * breakpoint.c: Sort headers.
9835         * break-catch-throw.c: Sort headers.
9836         * break-catch-syscall.c: Sort headers.
9837         * break-catch-sig.c: Sort headers.
9838         * blockframe.c: Sort headers.
9839         * block.c: Sort headers.
9840         * bfin-tdep.c: Sort headers.
9841         * bfin-linux-tdep.c: Sort headers.
9842         * bfd-target.c: Sort headers.
9843         * bcache.c: Sort headers.
9844         * ax-general.c: Sort headers.
9845         * ax-gdb.h: Sort headers.
9846         * ax-gdb.c: Sort headers.
9847         * avr-tdep.c: Sort headers.
9848         * auxv.c: Sort headers.
9849         * auto-load.c: Sort headers.
9850         * arm-wince-tdep.c: Sort headers.
9851         * arm-tdep.c: Sort headers.
9852         * arm-symbian-tdep.c: Sort headers.
9853         * arm-pikeos-tdep.c: Sort headers.
9854         * arm-obsd-tdep.c: Sort headers.
9855         * arm-nbsd-tdep.c: Sort headers.
9856         * arm-nbsd-nat.c: Sort headers.
9857         * arm-linux-tdep.c: Sort headers.
9858         * arm-linux-nat.c: Sort headers.
9859         * arm-fbsd-tdep.c: Sort headers.
9860         * arm-fbsd-nat.c: Sort headers.
9861         * arm-bsd-tdep.c: Sort headers.
9862         * arch-utils.c: Sort headers.
9863         * arc-tdep.c: Sort headers.
9864         * arc-newlib-tdep.c: Sort headers.
9865         * annotate.h: Sort headers.
9866         * annotate.c: Sort headers.
9867         * amd64-windows-tdep.c: Sort headers.
9868         * amd64-windows-nat.c: Sort headers.
9869         * amd64-tdep.c: Sort headers.
9870         * amd64-sol2-tdep.c: Sort headers.
9871         * amd64-obsd-tdep.c: Sort headers.
9872         * amd64-obsd-nat.c: Sort headers.
9873         * amd64-nbsd-tdep.c: Sort headers.
9874         * amd64-nbsd-nat.c: Sort headers.
9875         * amd64-nat.c: Sort headers.
9876         * amd64-linux-tdep.c: Sort headers.
9877         * amd64-linux-nat.c: Sort headers.
9878         * amd64-fbsd-tdep.c: Sort headers.
9879         * amd64-fbsd-nat.c: Sort headers.
9880         * amd64-dicos-tdep.c: Sort headers.
9881         * amd64-darwin-tdep.c: Sort headers.
9882         * amd64-bsd-nat.c: Sort headers.
9883         * alpha-tdep.c: Sort headers.
9884         * alpha-obsd-tdep.c: Sort headers.
9885         * alpha-nbsd-tdep.c: Sort headers.
9886         * alpha-mdebug-tdep.c: Sort headers.
9887         * alpha-linux-tdep.c: Sort headers.
9888         * alpha-linux-nat.c: Sort headers.
9889         * alpha-bsd-tdep.c: Sort headers.
9890         * alpha-bsd-nat.c: Sort headers.
9891         * aix-thread.c: Sort headers.
9892         * agent.c: Sort headers.
9893         * addrmap.c: Sort headers.
9894         * ada-varobj.c: Sort headers.
9895         * ada-valprint.c: Sort headers.
9896         * ada-typeprint.c: Sort headers.
9897         * ada-tasks.c: Sort headers.
9898         * ada-lang.c: Sort headers.
9899         * aarch64-tdep.c: Sort headers.
9900         * aarch64-ravenscar-thread.c: Sort headers.
9901         * aarch64-newlib-tdep.c: Sort headers.
9902         * aarch64-linux-tdep.c: Sort headers.
9903         * aarch64-linux-nat.c: Sort headers.
9904         * aarch64-fbsd-tdep.c: Sort headers.
9905         * aarch64-fbsd-nat.c: Sort headers.
9906         * aarch32-linux-nat.c: Sort headers.
9907
9908 2019-04-04  Tom Tromey  <tom@tromey.com>
9909
9910         * varobj.c (varobj_create): Update.
9911         * rust-exp.y (struct rust_parser) <update_innermost_block,
9912         lookup_symbol>: New methods.
9913         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9914         Rename.
9915         (rust_parser::rust_lookup_type)
9916         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9917         * printcmd.c (display_command, do_one_display): Update.
9918         * parser-defs.h (struct parser_state) <parser_state>: Add
9919         "tracker" parameter.
9920         (block_tracker): New member.
9921         (class innermost_block_tracker) <innermost_block_tracker>: Add
9922         "types" parameter.
9923         <reset>: Remove method.
9924         (innermost_block): Don't declare.
9925         (null_post_parser): Update.
9926         * parse.c (innermost_block): Remove global.
9927         (write_dollar_variable): Update.
9928         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9929         Remove "tracker_types" parameter.
9930         (parse_expression): Add "tracker" parameter.
9931         (parse_expression_for_completion): Update.
9932         (null_post_parser): Add "tracker" parameter.
9933         * p-exp.y: Update rules.
9934         * m2-exp.y: Update rules.
9935         * language.h (struct language_defn) <la_post_parser>: Add
9936         "tracker" parameter.
9937         * go-exp.y: Update rules.
9938         * f-exp.y: Update rules.
9939         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9940         parameter.
9941         * d-exp.y: Update rules.
9942         * c-exp.y: Update rules.
9943         * breakpoint.c (set_breakpoint_condition): Create an
9944         innermost_block_tracker.
9945         (watch_command_1): Likewise.
9946         * ada-lang.c (resolve): Add "tracker" parameter.
9947         (resolve_subexp): Likewise.
9948         * ada-exp.y (write_var_from_sym): Update.
9949
9950 2019-04-04  Tom Tromey  <tom@tromey.com>
9951
9952         * type-stack.h: New file.
9953         * type-stack.c: New file.
9954         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9955         type-stack.h.
9956         (insert_into_type_stack, insert_type, push_type, push_type_int)
9957         (insert_type_address_space, pop_type, pop_type_int)
9958         (pop_typelist, pop_type_stack, append_type_stack)
9959         (push_type_stack, get_type_stack, push_typelist)
9960         (follow_type_instance_flags, follow_types): Don't declare.
9961         * parse.c (type_stack): Remove global.
9962         (parse_exp_in_context): Update.
9963         (insert_into_type_stack, insert_type, push_type, push_type_int)
9964         (insert_type_address_space, pop_type, pop_type_int)
9965         (pop_typelist, pop_type_stack, append_type_stack)
9966         (push_type_stack, get_type_stack, push_typelist)
9967         (follow_type_instance_flags, follow_types): Remove (moved to
9968         type-stack.c).
9969         * f-exp.y (type_stack): New global.
9970         Update rules.
9971         (push_kind_type, f_parse): Update.
9972         * d-exp.y (type_stack): New global.
9973         Update rules.
9974         (d_parse): Update.
9975         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9976         Update rules.
9977         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9978         (HFILES_NO_SRCDIR): Add type-stack.h.
9979
9980 2019-04-04  Tom Tromey  <tom@tromey.com>
9981
9982         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9983         (rust_parser::convert_ast_to_expression, rust_parse)
9984         (rust_lex_test_completion, rust_lex_tests): Update.
9985         * parser-defs.h (struct expr_completion_state): New.
9986         (struct parser_state) <parser_state>: Add completion parameter.
9987         <mark_struct_expression, mark_completion_tag>: New methods.
9988         <parse_completion, m_completion_state>: New members.
9989         (prefixify_expression, null_post_parser): Update.
9990         (mark_struct_expression, mark_completion_tag): Don't declare.
9991         * parse.c (parse_completion, expout_last_struct)
9992         (expout_tag_completion_type, expout_completion_name): Remove
9993         globals.
9994         (parser_state::mark_struct_expression)
9995         (parser_state::mark_completion_tag): Now methods.
9996         (prefixify_expression): Add last_struct parameter.
9997         (prefixify_subexp): Likewise.
9998         (parse_exp_1): Update.
9999         (parse_exp_in_context): Add cstate parameter.  Update.
10000         (parse_expression_for_completion): Create an
10001         expr_completion_state.
10002         (null_post_parser): Add "completion" parameter.
10003         * p-exp.y: Update rules.
10004         (yylex): Update.
10005         * language.h (struct language_defn) <la_post_parser>: Add
10006         "completing" parameter.
10007         * go-exp.y: Update rules.
10008         (lex_one_token): Update.
10009         * expression.h (parse_completion): Don't declare.
10010         * d-exp.y: Update rules.
10011         (lex_one_token): Update rules.
10012         * c-exp.y: Update rules.
10013         (lex_one_token): Update.
10014         * ada-lang.c (resolve): Add "parse_completion" parameter.
10015         (resolve_subexp): Likewise.
10016         (ada_resolve_function): Likewise.
10017
10018 2019-04-04  Tom Tromey  <tom@tromey.com>
10019
10020         * parser-defs.h (struct parser_state) <start_arglist,
10021         end_arglist>: New methods.
10022         <arglist_len, m_funcall_chain>: New members.
10023         (arglist_len, start_arglist, end_arglist): Don't declare.
10024         * parse.c (arglist_len, funcall_chain): Remove global.
10025         (start_arglist, end_arglist): Remove functions.
10026         (parse_exp_in_context): Update.
10027         * p-exp.y: Update rules.
10028         * m2-exp.y: Update rules.
10029         * go-exp.y: Update rules.
10030         * f-exp.y: Update rules.
10031         * d-exp.y: Update rules.
10032         * c-exp.y: Update rules.
10033
10034 2019-04-04  Tom Tromey  <tom@tromey.com>
10035
10036         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10037         lex_operator, push_back>: New methods.
10038         Update all rules.
10039         (rust_parser::lex_hex, lex_escape): Rename and update.
10040         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10041         (rust_parser::lex_operator): Rename and update.
10042         (rust_parser::lex_number, rustyylex, rustyyerror)
10043         (rust_lex_test_init, rust_lex_test_sequence)
10044         (rust_lex_test_push_back, rust_lex_tests): Update.
10045         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10046         parameter.
10047         <lexptr, prev_lexptr>: New members.
10048         (lexptr, prev_lexptr): Don't declare.
10049         * parse.c (lexptr, prev_lexptr): Remove globals.
10050         (parse_exp_in_context): Update.
10051         * p-exp.y (yylex, yyerror): Update.
10052         * m2-exp.y (parse_number, yylex, yyerror): Update.
10053         * go-exp.y (lex_one_token, yyerror): Update.
10054         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10055         * d-exp.y (lex_one_token, yyerror): Update.
10056         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10057         (lex_one_token, yyerror): Update.
10058         * ada-lex.l (YY_INPUT): Update.
10059         (rewind_to_char): Update.
10060         * ada-exp.y (yyerror): Update.
10061
10062 2019-04-04  Tom Tromey  <tom@tromey.com>
10063
10064         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10065         * parser-defs.h (struct parser_state) <parser_state>: Add new
10066         parameter.
10067         <comma_terminates>: New member.
10068         (comma_terminates): Don't declare global.
10069         * parse.c (comma_terminates): Remove global.
10070         (parse_exp_in_context): Update.
10071         * p-exp.y (yylex): Update.
10072         * m2-exp.y (yylex): Update.
10073         * go-exp.y (lex_one_token): Update.
10074         * f-exp.y (yylex): Update.
10075         * d-exp.y (lex_one_token): Update.
10076         * c-exp.y (lex_one_token): Update.
10077         * ada-lex.l: Update.
10078
10079 2019-04-04  Tom Tromey  <tom@tromey.com>
10080
10081         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10082         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10083         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10084         * parser-defs.h (paren_depth): Don't declare.
10085         * parse.c (paren_depth): Remove global.
10086         (parse_exp_in_context): Update.
10087         * p-exp.y (paren_depth): New global.
10088         (pascal_parse): Initialize it.
10089         * m2-exp.y (paren_depth): New global.
10090         (m2_parse): Initialize it.
10091         * go-exp.y (paren_depth): New global.
10092         (go_parse): Initialize it.
10093         * f-exp.y (paren_depth): New global.
10094         (f_parse): Initialize it.
10095         * d-exp.y (paren_depth): New global.
10096         (d_parse): Initialize it.
10097         * c-exp.y (paren_depth): New global.
10098         (c_parse): Initialize it.
10099         * ada-lex.l (paren_depth): New global.
10100         (lexer_init): Initialize it.
10101
10102 2019-04-04  Tom Tromey  <tom@tromey.com>
10103
10104         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10105         (rust_parser::convert_ast_to_type)
10106         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10107         * parser-defs.h (struct parser_state) <parser_state>: Add
10108         parameters.  Initialize new members.
10109         <expression_context_block, expression_context_pc>: New members.
10110         * parse.c (expression_context_block, expression_context_pc):
10111         Remove globals.
10112         (parse_exp_in_context): Update.
10113         * p-exp.y: Update all rules.
10114         (yylex): Update.
10115         * m2-exp.y: Update all rules.
10116         (yylex): Update.
10117         * go-exp.y (yylex): Update.
10118         * f-exp.y (yylex): Update.
10119         * d-exp.y: Update all rules.
10120         (yylex): Update.
10121         * c-exp.y: Update all rules.
10122         (lex_one_token, classify_name, yylex, c_parse): Update.
10123         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10124
10125 2019-04-04  Tom Tromey  <tom@tromey.com>
10126
10127         * gdbarch.h, gdbarch.c: Rebuild.
10128         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10129         * stap-probe.h:
10130         (struct stap_parse_info): Replace "parser_state" with
10131         "expr_builder".
10132         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10133         (parser_state): New class.
10134         * parse.c (expr_builder): Rename.
10135         (expr_builder::release): Rename.
10136         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10137         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10138         (write_exp_elt_longcst, write_exp_elt_floatcst)
10139         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10140         (write_exp_string_vector, write_exp_bitstring)
10141         (write_exp_msymbol, mark_struct_expression)
10142         (write_dollar_variable)
10143         (insert_type_address_space, increase_expout_size): Replace
10144         "parser_state" with "expr_builder".
10145         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10146         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10147         "parser_state" with "expr_builder".
10148
10149 2019-04-04  Tom Tromey  <tom@tromey.com>
10150
10151         * rust-exp.y: Replace "parse_language" with method call.
10152         * p-exp.y:
10153         (yylex): Replace "parse_language" with method call.
10154         * m2-exp.y:
10155         (yylex): Replace "parse_language" with method call.
10156         * go-exp.y (classify_name): Replace "parse_language" with method
10157         call.
10158         * f-exp.y (yylex): Replace "parse_language" with method call.
10159         * d-exp.y (lex_one_token): Replace "parse_language" with method
10160         call.
10161         * c-exp.y:
10162         (lex_one_token, classify_name, yylex): Replace "parse_language"
10163         with method call.
10164         * ada-exp.y (find_primitive_type, type_char)
10165         (type_system_address): Replace "parse_language" with method call.
10166
10167 2019-04-04  Tom Tromey  <tom@tromey.com>
10168
10169         * rust-exp.y: Replace "parse_gdbarch" with method call.
10170         * parse.c (write_dollar_variable, insert_type_address_space):
10171         Replace "parse_gdbarch" with method call.
10172         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10173         call.
10174         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10175         call.
10176         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10177         "parse_gdbarch" with method call.
10178         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10179         with method call.
10180         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10181         "parse_gdbarch" with method call.
10182         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10183         "parse_gdbarch" with method call.
10184         * c-exp.y (parse_type, parse_number, classify_name): Replace
10185         "parse_gdbarch" with method call.
10186         * ada-lex.l: Replace "parse_gdbarch" with method call.
10187         * ada-exp.y (parse_type, find_primitive_type, type_char)
10188         (type_system_address): Replace "parse_gdbarch" with method call.
10189
10190 2019-04-04  Tom Tromey  <tom@tromey.com>
10191
10192         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10193         * stap-probe.c (stap_parse_argument): Update.
10194         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10195         initial_size parameter.
10196         * rust-exp.y (rust_lex_tests): Update.
10197         * parse.c (parser_state): Update.
10198         (parse_exp_in_context): Update.
10199         * parser-defs.h (struct parser_state) <parser_state>: Remove
10200         "initial_size" parameter.
10201
10202 2019-04-04  Tom Tromey  <tom@tromey.com>
10203
10204         * parser-defs.h (increase_expout_size): Don't declare.
10205         * parse.c (increase_expout_size): Now static.
10206
10207 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10208
10209         * gnu-nat.c (gnu_nat_target::wait): Fix
10210         target_waitstatus_to_string call.
10211
10212 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10213
10214         * eval.c (evaluate_subexp_standard): Handle internal functions
10215         during Fortran function call handling.
10216
10217 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10218
10219         * NEWS: Mention new internal functions.
10220         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10221         (read_base_type): Use dwarf2_init_complex_target_type.
10222         * value.c (creal_internal_fn): New function.
10223         (cimag_internal_fn): New function.
10224         (_initialize_values): Register new internal functions.
10225
10226 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10227
10228         * infrun.c (stop_all_threads): If debug_infrun, always
10229         trace the wait status after wait_one, using
10230         target_waitstatus_to_string and target_pid_to_str.
10231         (handle_inferior_event): Replace various trace of
10232         wait status kind by a single trace.
10233         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10234         wait status kind image by target_waitstatus_to_string.
10235         * target/waitstatus.c (target_waitstatus_to_string): Fix
10236         obsolete comment.
10237
10238 2019-04-01  Tom Tromey  <tromey@adacore.com>
10239
10240         PR symtab/23331:
10241         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10242
10243 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10244             Pedro Alves  <palves@redhat.com>
10245
10246         * top.c (quit_force): Call 'finalize_values'.
10247         * value.c (finalize_values): New function.
10248         * value.h (finalize_values): Declare.
10249
10250 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10251
10252         * NEWS: Announce $_gdb_major and $_gdb_minor.
10253
10254         * top.c (init_gdb_version_vars): New function.
10255         (gdb_init): Call init_gdb_version_vars.
10256
10257 2019-03-29  Tom Tromey  <tromey@adacore.com>
10258
10259         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10260         help text.  Remove dead code.
10261
10262 2019-03-29  Keith Seitz  <keiths@redhat.com>
10263
10264         From Siddhesh Poyarekar:
10265         * f-lang.h (f77_get_upperbound): Return LONGEST.
10266         (f77_get_lowerbound): Likewise.
10267         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10268         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10269         print them.
10270         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10271         plongest to format print it.
10272         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10273         (f77_get_upperbound): Likewise.
10274         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10275         LOWER_BOUND to LONGEST.
10276         (f77_create_arrayprint_offset_tbl): Likewise.
10277
10278 2019-03-29  Keith Seitz  <keiths@redhat.com>
10279
10280         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10281         %s/pulongest for TYPE_LENGTH instead of %d in format
10282         strings.
10283         * ada-typerint.c (ada_print_type): Likewise.
10284         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10285         * compile/compile-c-support.c (generate_register_struct): Likewise.
10286         * gdbtypes.c (recursive_dump_type): Likewise.
10287         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10288         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10289         instead of %d in format strings.
10290         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10291         to std::min to ULONGEST.
10292         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10293         instead of %d in format strings.
10294         * tracepoint.c (info_scope_command): Likewise.
10295         * typeprint.c (print_offset_data::update)
10296         (print_offset_data::finish): Likewise.
10297         * xtensa-tdep.c (xtensa_store_return_value)
10298         (xtensa_push_dummy_call): Likewise.
10299
10300 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10301
10302         * windows-nat.c (display_selector): Fixed format specifications
10303         for 64-bit Cygwin.
10304
10305 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10306
10307         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10308
10309 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10310
10311         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10312         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10313         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10314         (nios2_linux_init_abi): Install it.
10315
10316 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10317
10318         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10319
10320 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10321
10322         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10323
10324 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10325             Tom Tromey  <tromey@adacore.com>
10326
10327         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10328
10329 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10330
10331         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10332         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10333         method to compute the bounds of range types. Also print "[evaluated]"
10334         if the bounds' values come from a dynamic evaluation.
10335
10336 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10337
10338         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10339         whitespace when pretty printing is on.
10340
10341 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10342
10343         * ppc-linux-nat.c: Add include.
10344
10345 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10346
10347         * NEWS: Mention AArch64 Pointer Authentication.
10348
10349 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10350
10351         * arm-linux-nat.c: Add include.
10352
10353 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10354
10355         * source-cache.c (source_cache::get_source_lines): Re-read
10356         fullname after calling open_source_file.
10357
10358 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10359
10360         * NEWS: Mention TLS support for FreeBSD.
10361
10362 2019-03-25  Tom Tromey  <tromey@adacore.com>
10363
10364         * minsyms.c (BUNCH_SIZE): Update comment.
10365         (~minimal_symbol_reader): Remove old comment.
10366         (compact_minimal_symbols): Update comment.
10367         (minimal_symbol_reader::install): Remove old comment.  Update
10368         other comments.
10369
10370 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10371
10372         * s390-linux-nat.c: Add include.
10373
10374 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10375
10376         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10377         Call linux_get_hwcap.
10378         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10379         Likewise.
10380         (aarch64_linux_get_hwcap): Remove function.
10381         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10382         declaration.
10383         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10384         linux_get_hwcap.
10385         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10386         * linux-tdep.c (linux_get_hwcap): Add function.
10387         (linux_get_hwcap2): Likewise.
10388         * linux-tdep.h (linux_get_hwcap): Add declaration.
10389         (linux_get_hwcap2): Likewise.
10390         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10391         (ppc_linux_get_hwcap2): Likewise.
10392         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10393         linux_get_hwcap.
10394         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10395         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10396         (ppc_linux_nat_target::read_description): Likewise.
10397         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10398         * s390-linux-nat.c: Likewise.
10399         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10400
10401 2019-03-24  Tom Tromey  <tom@tromey.com>
10402
10403         * ada-lang.c (standard_lookup): Simplify initialization.
10404         (ada_lookup_symbol_nonlocal): Simplify return.
10405         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10406         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10407         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10408         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10409         initialization.
10410         * solib.c (solib_global_lookup): Simplify.
10411         * symtab.c (null_block_symbol): Remove.
10412         (symbol_cache_lookup): Simplify returns.
10413         (lookup_language_this): Simplify returns.
10414         (lookup_symbol_aux): Simplify return.
10415         (lookup_local_symbol): Simplify returns.
10416         (lookup_global_symbol_from_objfile): Simplify return.
10417         (lookup_symbol_in_objfile_symtabs)
10418         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10419         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10420         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10421         * cp-namespace.c (cp_lookup_bare_symbol)
10422         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10423         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10424         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10425         (cp_lookup_symbol_via_imports): Simplify initialization.
10426         (find_symbol_in_baseclass): Likewise.
10427         * symtab.h (null_block_symbol): Remove.
10428         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10429         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10430         (d_lookup_symbol_module): Likewise.
10431         (find_symbol_in_baseclass): Simplify initialization.
10432
10433 2019-03-24  Tom Tromey  <tom@tromey.com>
10434
10435         * expression.h: Don't include symtab.h.
10436         (struct block): Forward declare.
10437
10438 2019-03-24  Tom Tromey  <tom@tromey.com>
10439
10440         * c-exp.y (typebase): Remove casts.
10441         * gdbtypes.c (lookup_unsigned_typename, )
10442         (lookup_signed_typename): Remove cast.
10443         * eval.c (parse_to_comma_and_eval): Remove cast.
10444         * parse.c (write_dollar_variable): Remove cast.
10445         * block.h (struct block) <superblock>: Now const.
10446         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10447         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10448         (map_block): Make "block" const.
10449         * symfile.h (struct quick_symbol_functions)
10450         <map_matching_symbols>: Constify block argument to "callback".
10451         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10452         const.
10453         (find_pc_sect_compunit_symtab): Make "b" const.
10454         (find_symbol_at_address): Likewise.
10455         (search_symbols): Likewise.
10456         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10457         (dw2_debug_names_lookup_symbol): Likewise.
10458         (dw2_map_matching_symbols): Update.
10459         * p-valprint.c (pascal_val_print): Remove "block".
10460         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10461         (aux_add_nonlocal_symbols): Make "block" const.
10462         (resolve_subexp): Remove cast.
10463         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10464         const.
10465         (iterate_over_file_blocks): Likewise.
10466         * f-exp.y (%union) <bval>: Remove.
10467         * coffread.c (patch_opaque_types): Make "b" const.
10468         * spu-tdep.c (spu_catch_start): Make "block" const.
10469         * c-valprint.c (print_unpacked_pointer): Remove "block".
10470         * symmisc.c (dump_symtab_1): Make "b" const.
10471         (block_depth): Make "block" const.
10472         * d-exp.y (%union) <bval>: Remove.
10473         * cp-support.h (cp_lookup_rtti_type): Update.
10474         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10475         * psymtab.c (psym_lookup_symbol): Make "block" const.
10476         (maintenance_check_psymtabs): Make "b" const.
10477         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10478         (enumerate_locals, enumerate_args): Update.
10479         * python/py-symtab.c (stpy_global_block): Make "block" const.
10480         (stpy_static_block): Likewise.
10481         * inline-frame.c (block_starting_point_at): Make "new_block"
10482         const.
10483         * block.c (find_block_in_blockvector): Make return type const.
10484         (blockvector_for_pc_sect): Make "b" const.
10485         (find_block_in_blockvector): Make "b" const.
10486
10487 2019-03-23  Tom Tromey  <tom@tromey.com>
10488
10489         * varobj.c (varobj_create): Update.
10490         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10491         * printcmd.c (display_command, do_one_display): Don't reset
10492         innermost_block.
10493         * parser-defs.h (enum innermost_block_tracker_type): Move to
10494         expression.h.
10495         (innermost_block): Update comment.
10496         * parse.c (parse_exp_1): Add tracker_types parameter.
10497         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10498         tracker_types parameter.  Reset innermost_block.
10499         (parse_exp_in_context): Remove.
10500         (parse_expression_for_completion): Update.
10501         * objfiles.c (~objfile): Don't reset expression_context_block or
10502         innermost_block.
10503         * expression.h (enum innermost_block_tracker_type): Move from
10504         parser-defs.h.
10505         (parse_exp_1): Add tracker_types parameter.
10506         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10507         reset innermost_block.
10508
10509 2019-03-23  Tom Tromey  <tom@tromey.com>
10510
10511         * objfiles.h: Include bcache.h.
10512
10513 2019-03-23  Tom Tromey  <tom@tromey.com>
10514
10515         * linespec.c (get_current_search_block): Use
10516         scoped_restore_current_language.
10517         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10518
10519 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10520             Jiong Wang  <jiong.wang@arm.com>
10521
10522         * aarch64-linux-tdep.c
10523         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10524         section.
10525         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10526
10527 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10528             Jiong Wang  <jiong.wang@arm.com>
10529
10530         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10531         instructions.
10532         (aarch64_analyze_prologue_test): Add PACIASP test.
10533         (aarch64_prologue_prev_register): Unmask PC value.
10534
10535 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10536             Jiong Wang  <jiong.wang@arm.com>
10537
10538         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10539         (aarch64_dwarf2_prev_register): Unmask PC value.
10540         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10541         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10542         DW_CFA_AARCH64_negate_ra_state.
10543         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10544
10545 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10546             Jiong Wang  <jiong.wang@arm.com>
10547
10548         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10549         registers.
10550         (aarch64_pseudo_register_name): Likewise.
10551         (aarch64_pseudo_register_type): Likewise.
10552         (aarch64_pseudo_register_reggroup_p): Likewise.
10553         (aarch64_gdbarch_init): Add pauth registers.
10554         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10555         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10556         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10557         (struct gdbarch_tdep): Add regnum for ra_state.
10558
10559 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10560             Jiong Wang  <jiong.wang@arm.com>
10561
10562         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10563
10564 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10565             Jiong Wang  <jiong.wang@arm.com>
10566
10567         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10568         function.
10569         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10570         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10571         (aarch64_gdbarch_init): Add puth registers.
10572         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10573         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10574         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10575
10576 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10577             Jiong Wang  <jiong.wang@arm.com>
10578
10579         * aarch64-linux-nat.c
10580         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10581         * aarch64-linux-tdep.c
10582         (aarch64_linux_core_read_description): Likewise.
10583         (aarch64_linux_get_hwcap): New function.
10584         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10585         (aarch64_linux_get_hwcap): New declaration.
10586
10587 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10588             Jiong Wang  <jiong.wang@arm.com>
10589
10590         * aarch64-linux-nat.c
10591         (aarch64_linux_nat_target::read_description): Add pauth param.
10592         * aarch64-linux-tdep.c
10593         (aarch64_linux_core_read_description): Likewise.
10594         * aarch64-tdep.c (struct target_desc): Add in pauth.
10595         (aarch64_read_description): Add pauth param.
10596         (aarch64_gdbarch_init): Likewise.
10597         * aarch64-tdep.h (aarch64_read_description): Likewise.
10598         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10599         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10600         * features/Makefile: Add new files.
10601         * features/aarch64-pauth.c: New file.
10602         * features/aarch64-pauth.xml: New file.
10603
10604 2019-03-20  Tom Tromey  <tromey@adacore.com>
10605
10606         * infrun.c (handle_inferior_event): Rename from
10607         handle_inferior_event_1.  Create a scoped_value_mark.
10608         (handle_inferior_event): Remove.
10609
10610 2019-03-19  Tom Tromey  <tromey@adacore.com>
10611
10612         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10613         * infrun.h (print_stop_event): Add "displays" parameter.
10614         * infrun.c (print_stop_event): Add "displays" parameter.
10615
10616 2019-03-19  Pedro Alves  <palves@redhat.com>
10617
10618         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10619         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10620         to -1.  Fix TABs vs spaces.
10621         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10622         * tui/tui-out.h (tui_ui_out) Add intro comments.
10623         <m_line, m_start_of_line>: In-class initialize, and add describing
10624         comment.
10625
10626 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10627
10628         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10629         variable names.
10630         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10631
10632 2019-03-18  Pedro Alves  <palves@redhat.com>
10633             Eli Zaretskii <eliz@gnu.org>
10634
10635         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10636         m_line and m_start_of_line.
10637
10638 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10639
10640         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10641         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10642         it returns a newline.  This fixes a regression in TU mode, whereby
10643         the next line is output on the same screen line as the user input.
10644
10645 2019-03-18  Tom Tromey  <tromey@adacore.com>
10646
10647         * minsyms.c (minimal_symbol_reader::install): Remove call to
10648         obstack_blank.
10649
10650 2019-03-18  Pedro Alves  <palves@redhat.com>
10651
10652         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10653         New globals.
10654         (apply_style): New, factored out from ...
10655         (apply_ansi_escape): ... this.  Handle reverse video mode.
10656         (tui_set_reverse_mode): New function.
10657         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10658         * tui/tui-winsource.c (tui_show_source_line): Use
10659         tui_set_reverse_mode instead of setting A_STANDOUT.
10660         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10661         New setter methods.
10662
10663 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10664
10665         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10666         Handle tabs.
10667
10668 2019-03-18  Tom Tromey  <tromey@adacore.com>
10669
10670         * ada-lang.c (empty_array): Add "high" parameter.
10671         (ada_evaluate_subexp): Update.
10672
10673 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10674
10675         * unittests/string_view-selftests.c: Define
10676         _initialize_string_view_selftests unconditionally.
10677
10678 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10679
10680         PR gdb/24350
10681         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10682
10683 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10684
10685         PR gdb/24351
10686         * windows-nat.c (display_selector): Fix format specifiers.
10687
10688 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10689
10690         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10691         tui_refill_source_window instead of tui_refresh_win, to update the
10692         current execution line.  This fixes redisplay of the current line
10693         when stepping through the code with "next" or "step".
10694
10695 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10696
10697         * source-cache.c (source_cache::get_source_lines): Call
10698         find_source_lines to initialize s->nlines.  This fixes vertical
10699         scrolling of TUI source window when the DOWN arrow is pressed.
10700
10701 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10702
10703         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10704         linux-thread-db.c (_initialize_thread_db): Likewise.
10705
10706 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10707
10708         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10709         wclrtoeol in tui_show_source_line".  This reverts changes made in
10710         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10711
10712 2019-03-15  Tom Tromey  <tom@tromey.com>
10713
10714         * symtab.h (struct minimal_symbol): Derive from
10715         general_symbol_info.
10716         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10717         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10718         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10719         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10720         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10721         (MSYMBOL_SEARCH_NAME): Update.
10722         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10723         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10724         * minsyms.c (minimal_symbol_reader::record_full): Update.
10725
10726 2019-03-15  Tom Tromey  <tom@tromey.com>
10727
10728         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10729
10730 2019-03-15  Tom Tromey  <tom@tromey.com>
10731
10732         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10733         unique_xmalloc_ptr.
10734         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10735         Update.
10736         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10737         (build_minimal_symbol_hash_tables)
10738         (minimal_symbol_reader::install): Update.
10739
10740 2019-03-15  Tom Tromey  <tom@tromey.com>
10741
10742         * symtab.c (create_demangled_names_hash): Update.
10743         (symbol_set_names): Update.
10744         * objfiles.h (struct objfile_per_bfd_storage)
10745         <demangled_names_hash>: Now an htab_up.
10746         * objfiles.c (objfile_per_bfd_storage): Simplify.
10747
10748 2019-03-15  Tom Tromey  <tom@tromey.com>
10749
10750         * objfiles.h (struct objfile_per_bfd_storage): Declare
10751         destructor.
10752         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10753         New.
10754         (get_objfile_bfd_data): Use new.  Don't initialize
10755         language_of_main.
10756         (free_objfile_per_bfd_storage): Remove.
10757         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10758
10759 2019-03-15  Tom Tromey  <tom@tromey.com>
10760
10761         * symfile.c (reread_symbols): Update.
10762         * objfiles.c (objfile::objfile): Update.
10763         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10764         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10765         comment.
10766         (minimal_symbol_reader::install): Update.
10767         (terminate_minimal_symbol_table): Remove.
10768         * jit.c (jit_object_close_impl): Update.
10769
10770 2019-03-15  Tom Tromey  <tom@tromey.com>
10771
10772         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10773         initializations.
10774
10775 2019-03-15  Tom Tromey  <tom@tromey.com>
10776
10777         * objfiles.h (struct objfile_per_bfd_storage)
10778         <demangled_hash_languages>: Now a bitset.
10779         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10780         (lookup_minimal_symbol): Update.
10781
10782 2019-03-15  Tom Tromey  <tom@tromey.com>
10783
10784         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10785         Don't return the symbol.
10786         * coffread.c (record_minimal_symbol): Use record_full.
10787
10788 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10789
10790         The MS-Windows port of ncurses fails to switch to a color pair if
10791         one or both of the colors are the implicit default colors.  This
10792         change records the default colors when TUI is initialized, and
10793         then specifies them explicitly when a color pair uses the default
10794         colors.  This allows color styling in TUI mode on MS-Windows.
10795
10796         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10797         ncurses_norm_attr.
10798         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10799         colors in ncurses_norm_attr.
10800         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10801         "none", replace it with the default color recorded in
10802         ncurses_norm_attr.
10803
10804 2019-03-14  Tom Tromey  <tromey@adacore.com>
10805
10806         * source-cache.h (class source_cache) <get_source_lines>: Return
10807         std::string.
10808         * source-cache.c (source_cache::extract_lines): Handle case where
10809         first_pos==npos.  Return std::string.
10810         (source_cache::get_source_lines): Update.
10811
10812 2019-03-14  Tom Tromey  <tromey@adacore.com>
10813
10814         * NEWS: Add item for "style sources" commands.
10815         * source-cache.c (source_cache::get_source_lines): Check
10816         source_styling.
10817         * cli/cli-style.c (source_styling): New global.
10818         (_initialize_cli_style): Add "style sources" commands.
10819         (show_style_sources): New function.
10820         * cli/cli-style.h (source_styling): Declare.
10821
10822 2019-03-14  Pedro Alves  <palves@redhat.com>
10823             Tom Tromey  <tromey@adacore.com>
10824
10825         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10826         * tui/tui-winsource.c (tui_refill_source_window): New function,
10827         from...
10828         (tui_horizontal_source_scroll): ... here.  Move some logic.
10829         * cli/cli-style.c (set_style_enabled): Notify new observable.
10830         * tui/tui-hooks.c (tui_redisplay_source): New function.
10831         (tui_attach_detach_observers): Attach or detach
10832         tui_redisplay_source.
10833         * observable.h (source_styling_changed): New observable.
10834         * observable.c: Define source_styling_changed observable.
10835
10836 2019-03-13  Tom Tromey  <tromey@adacore.com>
10837
10838         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10839         (i386_gnu_nat_target::store_registers): Update.
10840         * target-debug.h (target_debug_print_std_string): New macro.
10841         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10842         * windows-tdep.c (display_one_tib): Update.
10843         * tui/tui-stack.c (tui_make_status_line): Update.
10844         * top.c (print_inferior_quit_action): Update.
10845         * thread.c (thr_try_catch_cmd): Update.
10846         (add_thread_with_info): Update.
10847         (thread_target_id_str): Update.
10848         (thr_try_catch_cmd): Update.
10849         (thread_command): Update.
10850         (thread_find_command): Update.
10851         * record-btrace.c (record_btrace_target::info_record)
10852         (record_btrace_resume_thread, record_btrace_target::resume)
10853         (record_btrace_cancel_resume, record_btrace_step_thread)
10854         (record_btrace_target::wait, record_btrace_target::wait)
10855         (record_btrace_target::wait, record_btrace_target::stop): Update.
10856         * progspace.c (print_program_space): Update.
10857         * process-stratum-target.c
10858         (process_stratum_target::thread_address_space): Update.
10859         * linux-fork.c (linux_fork_mourn_inferior)
10860         (detach_checkpoint_command, info_checkpoints_command)
10861         (linux_fork_context): Update.
10862         (linux_fork_detach): Update.
10863         (class scoped_switch_fork_info): Update.
10864         (delete_checkpoint_command): Update.
10865         * infrun.c (follow_fork_inferior): Update.
10866         (follow_fork_inferior): Update.
10867         (proceed_after_vfork_done): Update.
10868         (handle_vfork_child_exec_or_exit): Update.
10869         (follow_exec): Update.
10870         (displaced_step_prepare_throw): Update.
10871         (displaced_step_restore): Update.
10872         (start_step_over): Update.
10873         (resume_1): Update.
10874         (clear_proceed_status_thread): Update.
10875         (proceed): Update.
10876         (print_target_wait_results): Update.
10877         (do_target_wait): Update.
10878         (context_switch): Update.
10879         (stop_all_threads): Update.
10880         (restart_threads): Update.
10881         (finish_step_over): Update.
10882         (handle_signal_stop): Update.
10883         (switch_back_to_stepped_thread): Update.
10884         (keep_going_pass_signal): Update.
10885         (print_exited_reason): Update.
10886         (normal_stop): Update.
10887         * inferior.c (inferior_pid_to_str): Change return type.
10888         (print_selected_inferior): Update.
10889         (add_inferior): Update.
10890         (detach_inferior): Update.
10891         * dummy-frame.c (fprint_dummy_frames): Update.
10892         * dcache.c (dcache_info_1): Update.
10893         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10894         (btrace_fetch, btrace_clear): Update.
10895         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10896         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10897         type.
10898         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10899         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10900         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10901         * gdbarch.c, gdbarch.h: Rebuild.
10902         * gdbarch.sh (core_pid_to_str): Change return type.
10903         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10904         return type.
10905         (windows_nat_target::pid_to_str): Change return type.
10906         (windows_delete_thread): Update.
10907         (windows_nat_target::attach): Update.
10908         (windows_nat_target::files_info): Update.
10909         * target-delegates.c: Rebuild.
10910         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10911         return type.
10912         (sol_thread_target::pid_to_str): Change return type.
10913         * remote.c (class remote_target) <pid_to_str>: Change return
10914         type.
10915         (remote_target::pid_to_str): Change return type.
10916         (extended_remote_target::attach, remote_target::remote_stop_ns)
10917         (remote_target::remote_notif_remove_queued_reply)
10918         (remote_target::push_stop_reply, remote_target::disable_btrace):
10919         Update.
10920         (extended_remote_target::attach): Update.
10921         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10922         type.
10923         (gdbsim_target::pid_to_str): Change return type.
10924         * ravenscar-thread.c (struct ravenscar_thread_target)
10925         <pid_to_str>: Change return type.
10926         (ravenscar_thread_target::pid_to_str): Change return type.
10927         * procfs.c (class procfs_target) <pid_to_str>: Change return
10928         type.
10929         (procfs_target::pid_to_str): Change return type.
10930         (procfs_target::attach): Update.
10931         (procfs_target::detach): Update.
10932         (procfs_target::fetch_registers): Update.
10933         (procfs_target::store_registers): Update.
10934         (procfs_target::wait): Update.
10935         (procfs_target::files_info): Update.
10936         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10937         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10938         return type.
10939         (nto_procfs_target::pid_to_str): Change return type.
10940         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10941         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10942         return type.
10943         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10944         (exit_lwp): Update.
10945         (attach_proc_task_lwp_callback, get_detach_signal)
10946         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10947         (linux_nat_target::resume, wait_lwp, stop_callback)
10948         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10949         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10950         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10951         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10952         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10953         type.
10954         (inf_ptrace_target::attach): Update.
10955         (inf_ptrace_target::files_info): Update.
10956         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10957         type.
10958         (go32_nat_target::pid_to_str): Change return type.
10959         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10960         (gnu_nat_target::wait): Update.
10961         (gnu_nat_target::wait): Update.
10962         (gnu_nat_target::resume): Update.
10963         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10964         (fbsd_nat_target::wait): Update.
10965         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10966         type.
10967         (darwin_nat_target::attach): Update.
10968         * corelow.c (class core_target) <pid_to_str>: Change return type.
10969         (core_target::pid_to_str): Change return type.
10970         * target.c (normal_pid_to_str): Change return type.
10971         (default_pid_to_str): Likewise.
10972         (target_pid_to_str): Change return type.
10973         (target_translate_tls_address): Update.
10974         (target_announce_detach): Update.
10975         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10976         return type.
10977         (bsd_uthread_target::pid_to_str): Change return type.
10978         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10979         type.
10980         (bsd_kvm_target::pid_to_str): Change return type.
10981         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10982         return type.
10983         (aix_thread_target::pid_to_str): Change return type.
10984         * target.h (struct target_ops) <pid_to_str>: Change return type.
10985         (target_pid_to_str, normal_pid_to_str): Likewise.
10986         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10987         type.
10988         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10989         type.
10990         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10991         return type.
10992         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10993         type.
10994         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10995         type.
10996         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10997         return type.
10998
10999 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11000
11001         * NEWS: Mention that the new default MI version is 3.  Mention
11002         changes to the output of commands and events that deal with
11003         multi-location breakpoints.
11004         * breakpoint.c: Include "mi/mi-out.h".
11005         (print_one_breakpoint): Change output syntax if using MI version
11006         >= 3.
11007         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11008         New.
11009         (mi_multi_location_breakpoint_output_fixed): New.
11010         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11011         (mi_cmd_fix_multi_location_breakpoint_output): New.
11012         (mi_multi_location_breakpoint_output_fixed): New.
11013         * mi/mi-cmds.c (mi_cmds): Register command
11014         -fix-multi-location-breakpoint-output.
11015         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11016         interpreter "mi".
11017
11018 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11019
11020         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11021         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11022         instantiate mi_ui_out based on interpreter name.
11023         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11024         * mi/mi-main.c (mi_load_progress): Likewise.
11025
11026 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11027
11028         * NEWS: Combine separate "New targets" sections for 8.3.
11029
11030 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11031
11032         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11033         (ppcfbsd_init_abi): Install gdbarch
11034         "fetch_tls_load_module_address" and "get_thread_local_address"
11035         methods.
11036
11037 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11038
11039         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11040         (riscv_fbsd_init_abi): Install gdbarch
11041         "fetch_tls_load_module_address" and "get_thread_local_address"
11042         methods.
11043
11044 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11045
11046         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11047         (i386fbsd_init_abi): Install gdbarch
11048         "fetch_tls_load_module_address" and "get_thread_local_address"
11049         methods.
11050
11051 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11052
11053         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11054         (amd64fbsd_init_abi): Install gdbarch
11055         "fetch_tls_load_module_address" and "get_thread_local_address"
11056         methods.
11057
11058 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11059
11060         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11061         (struct fbsd_pspace_data): New type.
11062         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11063         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11064         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11065         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11066         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11067
11068 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11069
11070         * gdbtypes.c (lookup_struct_elt): New function.
11071         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11072         * gdbtypes.h (struct struct_elt): New type.
11073         (lookup_struct_elt): New prototype.
11074
11075 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11076
11077         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11078         remove disabled code block.
11079
11080 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11081
11082         * gdbarch.sh (get_thread_local_address): New method.
11083         * gdbarch.h, gdbarch.c: Regenerate.
11084         * target.c (target_translate_tls_address): Use
11085         gdbarch_get_thread_local_address if present instead of
11086         target::get_thread_local_address.
11087
11088 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11089
11090         * target.h (target::get_thread_local_address): Update comment.
11091
11092 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11093
11094         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11095         objfile->separate_debug_objfile_backlink if not NULL.
11096
11097 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11098
11099         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11100         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11101         (amd64bsd_store_inferior_registers): Likewise.
11102         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11103         Enable segment base registers.
11104         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11105         PT_GETFSBASE and PT_GETGSBASE.
11106         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11107         PT_SETGSBASE.
11108         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11109         segment base registers.
11110         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11111
11112 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11113
11114         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11115         Update calls to i386_target_description to add 'segments'
11116         parameter.
11117         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11118         add segment base registers.
11119         * arch/i386.c (i386_create_target_description): Add 'segments'
11120         parameter to enable segment base registers.
11121         * arch/i386.h (i386_create_target_description): Likewise.
11122         * features/i386/32bit-segments.xml: New file.
11123         * features/i386/32bit-segments.c: Generate.
11124         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11125         call to i386_target_description to add 'segments' parameter.
11126         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11127         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11128         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11129         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11130         if feature is present.
11131         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11132         Add 'segments' parameter to call to i386_target_description.
11133         (i386_target_description): Add 'segments' parameter to enable
11134         segment base registers.
11135         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11136         to call to i386_target_description.
11137         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11138         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11139         Define I386_NUM_REGS.
11140         (i386_target_description): Add 'segments' parameter to enable
11141         segment base registers.
11142
11143 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11144
11145         PR/24325
11146         * source-cache.c: #undef open and close, to avoid unresolved
11147         externals during linking.
11148
11149 2019-03-12  Tom Tromey  <tromey@adacore.com>
11150
11151         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11152         const.  Add initializers.
11153         (_initialize_remote): Don't initialize ptid globals.
11154
11155 2019-03-12  Pedro Alves  <palves@redhat.com>
11156
11157         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11158
11159 2019-03-12  Pedro Alves  <palves@redhat.com>
11160
11161         * cp-name-parser.y (main): Remove unused 'len' variable.
11162
11163 2019-03-12  Tom Tromey  <tromey@adacore.com>
11164
11165         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11166         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11167
11168 2019-03-12  Tom Tromey  <tromey@adacore.com>
11169
11170         * linux-nat.c (iterate_over_lwps): Update.
11171         (stop_callback): Remove parameter.
11172         (stop_wait_callback, detach_callback, resume_set_callback)
11173         (select_singlestep_lwp_callback, set_ignore_sigint)
11174         (status_callback, resumed_callback, resume_clear_callback)
11175         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11176         data parameter.
11177         (linux_nat_target::detach, linux_nat_target::resume)
11178         (linux_stop_and_wait_all_lwps, select_event_lwp)
11179         (linux_nat_filter_event, linux_nat_wait_1)
11180         (linux_nat_target::kill, linux_nat_target::stop)
11181         (linux_nat_target::stop): Update.
11182         (linux_nat_resume_callback): Change type.
11183         (resume_stopped_resumed_lwps, count_events_callback)
11184         (select_event_lwp_callback): Likewise.
11185         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11186         * arm-linux-nat.c (struct update_registers_data): Remove.
11187         (update_registers_callback): Change type.
11188         (arm_linux_insert_hw_breakpoint1): Update.
11189         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11190         parameter.
11191         (x86_linux_dr_set_addr): Update.
11192         (x86_linux_dr_set_control): Update.
11193         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11194         (iterate_over_lwps): Use gdb::function_view.
11195         * nat/aarch64-linux-hw-point.c (struct
11196         aarch64_dr_update_callback_param): Remove.
11197         (debug_reg_change_callback): Change type.
11198         (aarch64_notify_debug_reg_change): Update.
11199         * s390-linux-nat.c (s390_refresh_per_info): Update.
11200
11201 2019-03-11  Tom Tromey  <tromey@adacore.com>
11202
11203         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11204         redundant assignment to "this_cu".
11205
11206 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11207
11208         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11209
11210 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11211
11212         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11213         from...
11214         (rank_one_type): ... this.
11215
11216 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11217
11218         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11219         from...
11220         (rank_one_type): ... this.
11221
11222 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11223
11224         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11225         from...
11226         (rank_one_type): ... this.
11227
11228 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11229
11230         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11231         from...
11232         (rank_one_type): ... this.
11233
11234 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11235
11236         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11237         from...
11238         (rank_one_type): ... this.
11239
11240 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11241
11242         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11243         from...
11244         (rank_one_type): ... this.
11245
11246 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11247
11248         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11249         from...
11250         (rank_one_type): ... this.
11251
11252 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11253
11254         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11255         from...
11256         (rank_one_type): ... this.
11257
11258 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11259
11260         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11261         from...
11262         (rank_one_type): ... this.
11263
11264 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11265
11266         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11267         from...
11268         (rank_one_type): ... this.
11269
11270 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11271
11272         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11273         from...
11274         (rank_one_type): ... this.
11275
11276 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11277
11278         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11279         from...
11280         (rank_one_type): ... this.
11281
11282 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11283
11284         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11285         inferior-events' shows the example events.
11286
11287 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11288
11289         Support styling on native MS-Windows console
11290
11291         PR/24315
11292         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11293         on MS-Windows if $TERM is not defined.
11294
11295         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11296
11297         * posix-hdep.c (gdb_console_fputs):
11298         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11299         functions.
11300         * ui-file.h (gdb_console_fputs): Add prototype.
11301
11302         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11303         back to fputs only if the former returns zero.
11304
11305 2019-03-07  Tom Tromey  <tom@tromey.com>
11306
11307         * symmisc.c (print_symbol_bcache_statistics): Update.
11308         (print_objfile_statistics): Update.
11309         * symfile.c (allocate_symtab): Update.
11310         * stabsread.c: Don't include bcache.h.
11311         * psymtab.h (struct psymbol_bcache): Don't declare.
11312         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11313         (psymbol_bcache_init, psymbol_bcache_free)
11314         (psymbol_bcache_get_bcache): Don't declare.
11315         * psymtab.c (struct psymbol_bcache): Remove.
11316         (psymtab_storage::psymtab_storage): Update.
11317         (psymtab_storage::~psymtab_storage): Update.
11318         (psymbol_bcache_init, psymbol_bcache_free)
11319         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11320         (add_psymbol_to_bcache): Update.
11321         (allocate_psymtab): Update.
11322         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11323         macro_cache>: No longer pointers.
11324         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11325         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11326         * macrotab.c (macro_bcache): Update.
11327         * macroexp.c: Don't include bcache.h.
11328         * gdbtypes.c (check_types_worklist): Update.
11329         (types_deeply_equal): Remove TRY/CATCH.  Update.
11330         * elfread.c (elf_symtab_read): Update.
11331         * dwarf2read.c: Don't include bcache.h.
11332         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11333         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11334         (print_bcache_statistics, bcache_memory_used): Don't declare.
11335         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11336         methods.  Rename all data members.
11337         * bcache.c (struct bcache): Move to bcache.h.
11338         (bcache::expand_hash_table): Rename from expand_hash_table.
11339         (bcache): Remove.
11340         (bcache::insert): Rename from bcache_full.
11341         (bcache::compare): Rename from bcache_compare.
11342         (bcache_xmalloc): Remove.
11343         (bcache::~bcache): Rename from bcache_xfree.
11344         (bcache::print_statistics): Rename from print_bcache_statistics.
11345         (bcache::memory_used): Rename from bcache_memory_used.
11346
11347 2019-03-07  Pedro Alves  <palves@redhat.com>
11348
11349         * infrun.c (normal_stop): Also check for
11350         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11351
11352 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11353
11354         * f-lang.c (value_from_host_double): Moved to...
11355         * value.c (value_from_host_double): ...here.
11356         * value.h (value_from_host_double): Declare.
11357         * guile/scm-math.c (vlscm_convert_typed_number): Use
11358         value_from_host_double.
11359         (vlscm_convert_number): Likewise.
11360         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11361         * python/py-value.c (convert_value_from_python): Likewise.
11362
11363 2019-03-06  Tom Tromey  <tom@tromey.com>
11364
11365         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11366
11367 2019-03-06  Tom Tromey  <tom@tromey.com>
11368
11369         * utils.h (free_current_contents): Don't declare.
11370         * utils.c (free_current_contents): Remove.
11371
11372 2019-03-06  Tom Tromey  <tom@tromey.com>
11373
11374         * top.c (quit_force): Update.
11375         * main.c (captured_command_loop): Update.
11376         * common/new-op.c (operator new): Update.
11377         * common/common-exceptions.c (struct catcher)
11378         <save_cleanup_chain>: Remove member.
11379         (exceptions_state_mc_init): Update.
11380         (exception_try_scope_entry): Return nullptr.
11381         (exception_try_scope_exit, exception_rethrow)
11382         (throw_exception_sjlj, throw_exception_cxx): Update.
11383         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11384         (all_cleanups, do_cleanups, discard_cleanups)
11385         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11386         (restore_cleanups, restore_final_cleanups): Don't declare.
11387         (do_final_cleanups): Remove parameter.
11388         * common/cleanups.c (cleanup_chain, make_cleanup)
11389         (make_cleanup_dtor, all_cleanups, do_cleanups)
11390         (discard_my_cleanups, discard_cleanups)
11391         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11392         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11393         (null_cleanup): Remove.
11394         (do_final_cleanups): Remove parameter.
11395
11396 2019-03-06  Tom Tromey  <tom@tromey.com>
11397
11398         * remote.c (remote_target::remote_parse_stop_reply): Use
11399         unique_xmalloc_ptr.
11400
11401 2019-03-06  Tom Tromey  <tom@tromey.com>
11402
11403         * stabsread.c (struct stabs_field_info): Rename from field_info.
11404         <list, fnlist>: Add initializers.
11405         <obstack>: New member.
11406         (read_member_functions, read_struct_fields, read_baseclasses):
11407         Allocate on obstack.  Don't use cleanups.
11408         (read_one_struct_field, read_member_functions, read_struct_fields)
11409         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11410         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11411         (read_struct_type): Update.
11412
11413 2019-03-06  Tom Tromey  <tom@tromey.com>
11414
11415         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11416         * common/filestuff.h (make_cleanup_close): Don't declare.
11417         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11418         Remove.
11419
11420 2019-03-06  Tom Tromey  <tom@tromey.com>
11421
11422         * solib-aix.c: Use make_scope_exit.
11423
11424 2019-03-06  Tom Tromey  <tom@tromey.com>
11425
11426         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11427         Use make_scope_exit.
11428
11429 2019-03-06  Tom Tromey  <tom@tromey.com>
11430
11431         * solib-svr4.c (disable_probes_interface): Remove parameter.
11432         (svr4_handle_solib_event): Use make_scope_exit.
11433
11434 2019-03-06  Tom Tromey  <tom@tromey.com>
11435
11436         * remote.c (struct stop_reply_deleter): Remove.
11437         (stop_reply_up): Update.
11438         (struct stop_reply): Derive from notif_event.  Don't typedef.
11439         <regcache>: Now a std::vector.
11440         (stop_reply_xfree): Remove.
11441         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11442         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11443         (remote_target::discard_pending_stop_replies): Use delete.
11444         (remote_target::remote_parse_stop_reply): Update.
11445         (remote_target::process_stop_reply): Update.
11446         * remote-notif.h (struct notif_event): Add virtual destructor.
11447         Remove "dtr" member.
11448         (struct notif_client) <alloc_event>: Return a unique_ptr.
11449         (notif_event_xfree): Don't declare.
11450         (notif_event_up): New typedef.
11451         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11452         (notif_event_xfree, do_notif_event_xfree): Remove.
11453         (remote_notif_state_xfree): Update.
11454
11455 2019-03-06  Tom Tromey  <tom@tromey.com>
11456
11457         * infrun.c (displaced_step_clear_cleanup): Now a
11458         forward_scope_exit type.
11459         (displaced_step_prepare_throw): Update.
11460         (displaced_step_fixup): Update.
11461
11462 2019-03-06  Tom Tromey  <tom@tromey.com>
11463
11464         * inferior.h (class inferior): Update comment.
11465         * gdbthread.h (class thread_info): Update comment.
11466
11467 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11468             Tom Tromey  <tom@tromey.com>
11469
11470         * stabsread.h (struct stab_section_list): Remove.
11471         (coffstab_build_psymtabs): Update.
11472         * dbxread.c (symbuf_sections): Now a std::vector.
11473         (sect_idx): New global.
11474         (fill_symbuf): Update.
11475         (coffstab_build_psymtabs): Change type of stabsects parameter.
11476         Update.
11477         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11478         std::vector.
11479         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11480         (coff_locate_sections): Update.
11481         (coff_symfile_read): Remove cleanups.  Update.
11482         (init_stringtab): Add storage parameter.
11483         (free_stringtab, free_stringtab_cleanup): Remove.
11484         (init_lineno): Add storage parameter.
11485         (free_linetab, free_linetab_cleanup): Remove.
11486
11487 2019-03-06  Pedro Alves  <palves@redhat.com>
11488
11489         * linux-fork.c (fork_info::clobber_regs): Delete.
11490         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11491         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11492         comment.  Adjust.
11493         (scoped_switch_fork_info::scoped_switch_fork_info)
11494         (checkpoint_command, linux_fork_context): Adjust
11495         fork_save_infrun_state calls.
11496
11497 2019-03-06  Pedro Alves  <palves@redhat.com>
11498
11499         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11500         (inf_has_multiple_threads): Return 'bool' and rewrite using
11501         inferior_info::threads().
11502
11503 2019-03-06  Pedro Alves  <palves@redhat.com>
11504
11505         * linux-fork.c: Include <list>.
11506         (fork_list): Now a std::list instance.
11507         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11508         (forks_exist_p, find_last_fork): Adjust.
11509         (new_fork): Delete.
11510         (one_fork_p): New.
11511         (add_fork): Adjust.
11512         (free_fork): Delete, folded into fork_info::~fork_info().
11513         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11514         Adjust.
11515         (init_fork_list): Delete.
11516         (linux_fork_killall, linux_fork_mourn_inferior)
11517         (linux_fork_detach, info_checkpoints_command): Adjust.
11518         (_initialize_linux_fork): No longer call init_fork_list.
11519
11520 2019-03-06  Pedro Alves  <palves@redhat.com>
11521
11522         * linux-fork.c (new_fork): New, split out of ...
11523         (add_fork): ... this.  Return void.  Move "first fork" special
11524         case from here, to ...
11525         (checkpoint_command): ... here.
11526         * linux-linux.h (add_fork): Return void.
11527
11528 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11529
11530         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11531
11532 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11533             Chris January  <chris.january@arm.com>
11534             David Lecomber  <david.lecomber@arm.com>
11535
11536         * f-exp.y: New token, UNOP_INTRINSIC.
11537         (exp): New pattern using UNOP_INTRINSIC token.
11538         (f77_keywords): Add 'abs' keyword.
11539         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11540         (value_from_host_double): New function.
11541         (evaluate_subexp_f): Support UNOP_ABS.
11542
11543 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11544
11545         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11546         types.
11547
11548 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11549
11550         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11551         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11552         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11553
11554 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11555
11556         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11557
11558 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11559             Chris January  <chris.january@arm.com>
11560
11561         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11562         * f-exp.y: Define 'KIND' token.
11563         (exp): New pattern for KIND expressions.
11564         (ptype): Handle types with a kind extension.
11565         (direct_abs_decl): Extend to spot kind extensions.
11566         (f77_keywords): Add 'kind' to the list.
11567         (push_kind_type): New function.
11568         (convert_to_kind_type): New function.
11569         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11570         * parse.c (operator_length_standard): Likewise.
11571         * parser-defs.h (enum type_pieces): Add tp_kind.
11572         * std-operator.def: Add UNOP_KIND.
11573
11574 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11575
11576         * f-exp.y (f_parse): Set yydebug.
11577
11578 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11579
11580         * f-lang.c (evaluate_subexp_f): New function.
11581         (exp_descriptor_f): New global.
11582         (f_language_defn): Use exp_descriptor_f instead of
11583         exp_descriptor_standard.
11584
11585 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11586
11587         * f-exp.y (struct token): Add comments.
11588         (dot_ops): Remove uppercase versions and the end marker.
11589         (f77_keywords): Likewise.
11590         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11591         entries in the dot_ops array are case insensitive, and use
11592         strncasecmp to compare strings.  Also some whitespace cleanup in
11593         this area.  Similar for the f77_keywords array, except entries in
11594         this list might be case sensitive.
11595
11596 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11597
11598         * f-exp.y (struct f77_boolean_val): Add comments.
11599         (boolean_values): Remove uppercase versions, and end marker.
11600         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11601         and use strncasecmp to achieve case insensitivity.  Additionally,
11602         perform whitespace cleanup around this code.
11603
11604 2019-03-06  Tom Tromey  <tromey@adacore.com>
11605
11606         * remote-sim.c (gdbsim_target_open): Use result of
11607         gdb_argv::release.
11608
11609 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11610         Dirk Schubert  <dirk.schubert@arm.com>
11611         Chris January  <chris.january@arm.com>
11612
11613         * eval.c (evaluate_subexp_standard): Call Fortran argument
11614         wrapping logic.
11615         * f-lang.c (struct value): A value which can be passed into a
11616         Fortran function call.
11617         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11618         where appropriate.
11619         (struct type): Value ready for a Fortran function call.
11620         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11621         is needed.
11622         * f-lang.h (fortran_argument_convert): Declaration.
11623         (fortran_preserve_arg_pointer): Declaration.
11624         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11625
11626 2019-03-05  Tom Tromey  <tromey@adacore.com>
11627
11628         * python/py-prettyprint.c (print_string_repr): Remove #if.
11629         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11630
11631 2019-03-05  Tom Tromey  <tromey@adacore.com>
11632
11633         * target.c (the_dummy_target): Move later.  Change type to
11634         "dummy_target".
11635         (initialize_targets): Don't initialize the_dummy_target.
11636
11637 2019-03-05  Tom Tromey  <tromey@adacore.com>
11638
11639         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11640         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11641
11642 2019-03-05  Tom Tromey  <tromey@adacore.com>
11643
11644         * windows-nat.c (windows_nat_target::attach)
11645         (windows_nat_target::detach): Don't call gdb_flush.
11646         * valprint.c (generic_val_print, val_print, val_print_string):
11647         Don't call gdb_flush.
11648         * utils.c (defaulted_query): Don't call gdb_flush.
11649         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11650         * target.c (target_announce_detach): Don't call gdb_flush.
11651         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11652         * remote.c (extended_remote_target::attach): Don't call
11653         gdb_flush.
11654         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11655         * printcmd.c (do_examine): Don't call gdb_flush.
11656         (info_display_command): Don't call gdb_flush.
11657         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11658         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11659         * memattr.c (info_mem_command): Don't call gdb_flush.
11660         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11661         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11662         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11663         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11664         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11665         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11666         (gnu_nat_target::detach): Don't call gdb_flush.
11667         * f-valprint.c (f_val_print): Don't call gdb_flush.
11668         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11669         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11670         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11671         gdb_flush.
11672         * c-valprint.c (c_val_print): Don't call gdb_flush.
11673         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11674
11675 2019-03-05  Tom Tromey  <tromey@adacore.com>
11676
11677         * varobj.c (update_dynamic_varobj_children): Update.
11678         (install_default_visualizer): Use reset, not release.
11679         * value.c (set_internalvar): Update.
11680         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11681         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11682         ATTRIBUTE_UNUSED_RESULT.
11683
11684 2019-03-05  Tom Tromey  <tromey@adacore.com>
11685
11686         * remote.c (class scoped_remote_fd) <release>: Add
11687         ATTRIBUTE_UNUSED_RESULT.
11688
11689 2019-03-05  Tom Tromey  <tromey@adacore.com>
11690
11691         * macroexp.c (struct macro_buffer) <release>: Add
11692         ATTRIBUTE_UNUSED_RESULT.
11693
11694 2019-03-05  Tom Tromey  <tromey@adacore.com>
11695
11696         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11697         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11698         ATTRIBUTE_UNUSED_RESULT.
11699
11700 2019-03-05  Tom Tromey  <tromey@adacore.com>
11701
11702         * common/scoped_fd.h (class scoped_fd) <release>: Add
11703         ATTRIBUTE_UNUSED_RESULT.
11704
11705 2019-03-05  Tom Tromey  <tromey@adacore.com>
11706
11707         * parser-defs.h (struct parser_state) <release>: Add
11708         ATTRIBUTE_UNUSED_RESULT.
11709
11710 2019-03-05  Tom Tromey  <tromey@adacore.com>
11711
11712         * utils.h (class gdb_argv) <release>: Add
11713         ATTRIBUTE_UNUSED_RESULT.
11714         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11715
11716 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11717
11718         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11719         for-loop range, to avoid compiler warnings.
11720
11721         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11722         avoid compiler warnings about unused variables.
11723
11724         * NEWS: Mention end of support for native debugging on MS-Windows
11725         before XP.
11726
11727         PR gdb/24292
11728         * common/netstuff.c:
11729         * gdbserver/gdbreplay.c
11730         * gdbserver/remote-utils.c:
11731         * ser-tcp.c:
11732         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11733         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11734         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11735         'getaddrinfo' and 'freeaddrinfo' were not available before
11736         Windows XP, and mingw.org's MinGW headers by default define
11737         _WIN32_WINNT to 0x500.
11738
11739 2019-03-01  Gary Benson <gbenson@redhat.com>
11740
11741         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11742
11743 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11744             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11745
11746         PR gdb/8527
11747         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11748         set_sigint_trap, clear_sigint_trap.
11749
11750 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11751
11752         * target.c (target_detach): Clear the regcache and the
11753         frame cache.
11754
11755 2019-02-27  Pedro Alves  <palves@redhat.com>
11756
11757         * utils.c (set_screen_size): When we cap the height/width sizes,
11758         tweak the corresponding command variable to show "unlimited":
11759
11760 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11761             Pedro Alves  <palves@redhat.com>
11762
11763         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11764         before calling rl_set_screen_size.
11765
11766 2019-02-27  Tom Tromey  <tromey@adacore.com>
11767
11768         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11769         define.
11770         * python/py-value.c: Remove Python 2.4 workaround.
11771         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11772         workaround.
11773         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11774         Python 2.4 workaround.
11775         * python/python-internal.h: Remove Python 2.4 comment.
11776         (Py_ssize_t): Don't define.
11777         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11778         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11779         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11780         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11781         * python/python.c (do_start_initialization): Remove Python 2.4
11782         workaround.
11783         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11784         (print_children): Remove Python 2.4 workaround.
11785         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11786         workaround.
11787         (CHARBUFFERPROC_NAME): Remove.
11788         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11789         Python 2.4 workaround.
11790
11791 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11792
11793         * NEWS: Note minimum Python version.
11794
11795 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11796
11797         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11798         code from these functions.  Remove corresponding ifdefs.  Use
11799         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11800         Remove gotos and target of gotos.
11801         (infpy_search_memory): Likewise.
11802
11803 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11804
11805         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11806         (hppa_gdbarch_init): Don't register deleted functions with
11807         gdbarch.
11808
11809 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11810
11811         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11812         (h8300_unwind_sp): Delete.
11813         (h8300_dummy_id): Delete.
11814         (h8300_gdbarch_init): Don't register deleted functions with
11815         gdbarch.
11816
11817 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11818
11819         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11820         (ft32_unwind_pc): Delete.
11821         (ft32_unwind_sp): Delete.
11822         (ft32_gdbarch_init): Don't register deleted functions with
11823         gdbarch.
11824
11825 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11826
11827         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11828         (frv_unwind_pc): Delete.
11829         (frv_unwind_sp): Delete.
11830         (frv_gdbarch_init): Don't register deleted functions with
11831         gdbarch.
11832
11833 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11834
11835         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11836         (riscv_unwind_pc): Delete.
11837         (riscv_unwind_sp): Delete.
11838         (riscv_gdbarch_init): Don't register deleted functions with
11839         gdbarch.
11840
11841 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11842
11843         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11844         (csky_unwind_pc): Delete.
11845         (csky_unwind_sp): Delete.
11846         (csky_gdbarch_init): Don't register deleted functions with
11847         gdbarch.
11848
11849 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11850
11851         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11852         (cris_unwind_pc): Delete.
11853         (cris_unwind_sp): Delete.
11854         (cris_gdbarch_init): Don't register deleted functions with
11855         gdbarch.
11856
11857 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11858
11859         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11860         (bfin_unwind_pc): Delete.
11861         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11862
11863 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11864
11865         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11866         (arm_unwind_pc): Delete.
11867         (arm_unwind_sp): Delete.
11868         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11869
11870 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11871
11872         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11873         (arc_unwind_pc): Delete.
11874         (arc_unwind_sp): Delete.
11875         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11876
11877 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11878
11879         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11880         (alpha_unwind_pc): Delete.
11881         (alpha_gdbarch_init): Don't register deleted functions with
11882         gdbarch.
11883
11884 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11885
11886         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11887         (aarch64_unwind_pc): Delete.
11888         (aarch64_unwind_sp): Delete.
11889         (aarch64_gdbarch_init): Don't register deleted functions with
11890         gdbarch.
11891
11892 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11893
11894         * gdbtypes.c (type_align): Don't consider static members when
11895         computing structure alignment.
11896
11897 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11898
11899         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11900         return 0 for other types.
11901         * arch-utils.c (default_type_align): Always return 0.
11902         * gdbarch.h: Regenerate.
11903         * gdbarch.sh (type_align): Extend comment.
11904         * gdbtypes.c (type_align): Add additional comments, always call
11905         gdbarch_type_align before applying the default rules.
11906         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11907         generic code will then apply a suitable default.
11908         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11909         types, return 0 for other types.
11910
11911 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11912
11913         * NEWS: Create a new section for the next release branch.
11914         Rename the section of the current branch, now that it has
11915         been cut.
11916
11917 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11918
11919         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11920         * version.in: Bump version to 8.3.50.DATE-git.
11921
11922 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11923
11924         * aix-thread.c (ptid_cmp): Remove unused variable.
11925         (get_signaled_thread): Likewise.
11926         (store_regs_user_thread): Likewise.
11927         (store_regs_kernel_thread): Likewise.
11928         (fetch_regs_kernel_thread): Remove shadowed variable.
11929
11930 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11931
11932         * features/riscv/32bit-cpu.xml: Add register numbers.
11933         * features/riscv/32bit-fpu.c: Regenerate.
11934         * features/riscv/32bit-fpu.xml: Add register numbers.
11935         * features/riscv/64bit-cpu.xml: Add register numbers.
11936         * features/riscv/64bit-fpu.c: Regenerate.
11937         * features/riscv/64bit-fpu.xml: Add register numbers.
11938
11939 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11940
11941         * NEWS: Mention two argument form of gdb.Value constructor.
11942         * python/py-value.c (convert_buffer_and_type_to_value): New
11943         function.
11944         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11945         Add support for handling an optional second argument.  Call
11946         convert_buffer_and_type_to_value as appropriate.
11947         * python/python-internal.h (Py_buffer_deleter): New struct.
11948         (Py_buffer_up): New typedef.
11949
11950 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11951
11952         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11953         instead of releasing ownership.
11954
11955 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11956
11957         * dwarf2read.c (open_and_init_dwp_file): Call
11958         elf_numsections instead of bfd_count_sections to initialize
11959         dwp_file->num_sections.
11960
11961 2019-02-25  Tom Tromey  <tromey@adacore.com>
11962
11963         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11964
11965 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11966
11967         * gcore.in: Add '--readnever' option when invoking GDB.
11968
11969 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11970
11971         * MAINTAINERS: Update my email address.
11972
11973 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11974
11975         * build-id.c (build_id_to_debug_bfd_1): New function.
11976         (build_id_to_debug_bfd): Look for separate debug file in
11977         sysroot.
11978
11979 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11980
11981         * gdbarch.sh: Update the copyright year range that is placed into
11982         generated files.
11983
11984 2019-02-22  Keith Seitz  <keiths@redhat.com>
11985
11986         PR symtab/23853
11987         * linespec.c (create_sals_line_offset): Search for the default
11988         symtab's filename instead of its fullname.
11989
11990 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11991
11992         * NEWS: Update style defaults.
11993
11994 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11995
11996         * main.c (captured_main_1): Disable styling in batch mode.
11997
11998 2019-02-20  Tom Tromey  <tom@tromey.com>
11999
12000         * symtab.c (symtab_symbol_info): Fix typos.
12001
12002 2019-02-20  Tom Tromey  <tromey@adacore.com>
12003
12004         * findcmd.c (_initialize_mem_search): Use upper case for
12005         metasyntactic variables.
12006
12007 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12008
12009         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12010         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12011
12012 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12013
12014         * top.h (source_file_name): Change to std::string.
12015         * top.c (source_file_name): Likewise.
12016         (command_line_input): Adjust.
12017         * cli/cli-script.c (script_from_file): Adjust.
12018
12019 2019-02-19  Tom Tromey  <tromey@adacore.com>
12020
12021         * ravenscar-thread.c
12022         (ravenscar_thread_target::update_thread_list): Don't call
12023         ada_build_task_list.
12024         * ada-lang.h (ada_build_task_list): Don't declare.
12025         * ada-tasks.c (struct ada_tasks_inferior_data)
12026         <task_list_valid_p>: Now bool.
12027         (read_known_tasks, ada_task_list_changed)
12028         (ada_tasks_invalidate_inferior_data): Update.
12029         (read_known_tasks_array): Return bool.
12030         (read_known_tasks_list): Likewise.
12031         (read_known_tasks): Return void.
12032         (ada_build_task_list): Now static.
12033
12034 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12035
12036         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12037         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12038
12039 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12040
12041         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12042         variant for ada_tasks_pspace_data_handle and
12043         ada_tasks_inferior_data_handle.
12044         (ada_tasks_pspace_data_cleanup): New function.
12045         (ada_tasks_inferior_data_cleanup): New function.
12046
12047 2019-02-17  Tom Tromey  <tom@tromey.com>
12048
12049         * macrotab.h (macro_source_fullname): Return a std::string.
12050         * macrotab.c (macro_include, check_for_redefinition)
12051         (macro_undef, macro_lookup_definition, foreach_macro)
12052         (foreach_macro_in_scope): Update.
12053         (macro_source_fullname): Return a std::string.
12054         * macrocmd.c (show_pp_source_pos): Update.
12055
12056 2019-02-17  Tom Tromey  <tom@tromey.com>
12057
12058         * macrocmd.c (show_pp_source_pos): Style the file names.
12059
12060 2019-02-17  Tom Tromey  <tom@tromey.com>
12061
12062         PR tui/24197:
12063         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12064
12065 2019-02-17  Tom Tromey  <tom@tromey.com>
12066
12067         * ada-lang.c (user_select_syms): Use filtered printing.
12068         * utils.c (wrap_style): New global.
12069         (desired_style): Remove.
12070         (emit_style_escape): Add stream parameter.
12071         (set_output_style, reset_terminal_style, prompt_for_continue):
12072         Update.
12073         (flush_wrap_buffer): Only flush gdb_stdout.
12074         (wrap_here): Set wrap_style.
12075         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12076         treat escape sequences as a character.  Change when wrap buffer is
12077         flushed.
12078         (fputs_styled): Do not set the output style when the default is
12079         requested.
12080         * ui-style.h (struct ui_file_style) <is_default>: New method.
12081         * source.c (print_source_lines_base): Emit escape sequences in one
12082         piece.
12083
12084 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12085
12086         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12087         integers and enumeration types.
12088
12089 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12090
12091         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12092         instead of lookup_symbol_in_language
12093         (do_exact_match): New function.
12094         (ada_get_symbol_name_matcher): Return do_exact_match when
12095         doing a verbatim match.
12096
12097 2019-02-15  Tom Tromey  <tromey@adacore.com>
12098
12099         * ravenscar-thread.c (ravenscar_thread_target::resume)
12100         (ravenscar_thread_target::wait): Special case wildcard requests.
12101
12102 2019-02-15  Tom Tromey  <tromey@adacore.com>
12103
12104         * ravenscar-thread.c (base_ptid): Remove.
12105         (struct ravenscar_thread_target) <close>: New method.
12106         <m_base_ptid>: New member.
12107         <update_inferior_ptid, active_task, task_is_currently_active,
12108         runtime_initialized>: Declare methods.
12109         <ravenscar_thread_target>: Add constructor.
12110         (ravenscar_thread_target::task_is_currently_active)
12111         (ravenscar_thread_target::update_inferior_ptid)
12112         (ravenscar_runtime_initialized): Rename.  Now methods.
12113         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12114         (ravenscar_thread_target::update_thread_list): Update.
12115         (ravenscar_thread_target::active_task): Now method.
12116         (ravenscar_thread_target::store_registers)
12117         (ravenscar_thread_target::prepare_to_store)
12118         (ravenscar_thread_target::prepare_to_store)
12119         (ravenscar_thread_target::mourn_inferior): Update.
12120         (ravenscar_inferior_created): Use "new" to create target.
12121         (ravenscar_thread_target::get_ada_task_ptid): Update.
12122         (_initialize_ravenscar): Don't initialize base_ptid.
12123         (ravenscar_ops): Remove global.
12124
12125 2019-02-15  Tom Tromey  <tromey@adacore.com>
12126
12127         * target.h (push_target): Declare new overload.
12128         * target.c (push_target): New overload, taking an rvalue reference.
12129         * remote.c (remote_target::open_1): Use push_target overload.
12130         * corelow.c (core_target_open): Use push_target overload.
12131
12132 2019-02-15  Tom Tromey  <tromey@adacore.com>
12133
12134         * ravenscar-thread.c (is_ravenscar_task)
12135         (ravenscar_task_is_currently_active): Return bool.
12136         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12137         (_initialize_ravenscar): Remove "(void)".
12138         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12139         Return bool.
12140
12141 2019-02-15  Tom Tromey  <tromey@adacore.com>
12142
12143         * ravenscar-thread.c (ravenscar_runtime_initializer)
12144         (has_ravenscar_runtime, get_running_thread_id)
12145         (ravenscar_thread_target::resume): Fix indentation.
12146
12147 2019-02-15  Tom Tromey  <tromey@adacore.com>
12148
12149         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12150         from ravenscar_arch_ops.
12151         (sparc_ravenscar_ops::fetch_registers)
12152         (sparc_ravenscar_ops::store_registers): Now methods.
12153         (sparc_ravenscar_prepare_to_store): Remove.
12154         (sparc_ravenscar_ops): Redefine.
12155         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12156         methods and destructor.  Remove members.
12157         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12158         (ravenscar_thread_target::store_registers)
12159         (ravenscar_thread_target::prepare_to_store): Update.
12160         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12161         Remove.
12162         (struct ppc_ravenscar_powerpc_ops): Derive from
12163         ravenscar_arch_ops.
12164         (ppc_ravenscar_powerpc_ops::fetch_registers)
12165         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12166         (ppc_ravenscar_powerpc_ops): Redefine.
12167         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12168         (ppc_ravenscar_e500_ops::fetch_registers)
12169         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12170         (ppc_ravenscar_e500_ops): Redefine.
12171         * aarch64-ravenscar-thread.c
12172         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12173         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12174         (aarch64_ravenscar_fetch_registers)
12175         (aarch64_ravenscar_store_registers): Now methods.
12176         (aarch64_ravenscar_ops): Redefine.
12177
12178 2019-02-15  Tom Tromey  <tromey@adacore.com>
12179
12180         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12181         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12182         (ravenscar_thread_target::stopped_by_watchpoint)
12183         (ravenscar_thread_target::stopped_data_address)
12184         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12185
12186 2019-02-15  Tom Tromey  <tromey@adacore.com>
12187
12188         * ravenscar-thread.c: Fix some typos.
12189
12190 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12191             Tom Tromey  <tromey@adacore.com>
12192
12193         * ada-lang.c (ada_exception_sal): Change addr_string to a
12194         std::string.
12195         (create_ada_exception_catchpoint): Update.
12196
12197 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12198             Tom Tromey  <tromey@adacore.com>
12199
12200         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12201         (bp_location_ops): Remove.
12202         (base_breakpoint_allocate_location): Update.
12203         (free_bp_location): Update.
12204         * ada-lang.c (class ada_catchpoint_location)
12205         <ada_catchpoint_location>: Remove ops parameter.
12206         (ada_catchpoint_location_dtor): Remove.
12207         (ada_catchpoint_location_ops): Remove.
12208         (allocate_location_exception): Update.
12209         * breakpoint.h (struct bp_location_ops): Remove.
12210         (class bp_location) <bp_location>: Remove bp_location_ops
12211         parameter.
12212         <~bp_location>: Add destructor.
12213         <ops>: Remove.
12214
12215 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12216             Pedro Alves  <palves@redhat.com>
12217
12218         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12219         'PATH_MAX'.
12220
12221 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12222             Samuel Thibault  <samuel.thibault@gnu.org>
12223             Thomas Schwinge  <thomas@codesourcery.com>
12224
12225         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12226         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12227
12228 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12229
12230         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12231         (check_empty): Use "const char *".
12232
12233         * gnu-nat.c (gnu_nat_target::detach): Instead of
12234         'detach_inferior (pid)' call
12235         'detach_inferior (find_inferior_pid (pid))'.
12236
12237         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12238         'nat/fork-inferior.o'.
12239         * gnu-nat.c: #include "nat/fork-inferior.h".
12240
12241         * gnu-nat.c (gnu_nat_target::detach): Instead of
12242         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12243         * gnu-nat.h: #include "inf-child.h".
12244         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12245         'i386_gnu_nat_target::fetch_registers'.
12246         (gnu_store_registers): Rename/move to
12247         'i386_gnu_nat_target::store_registers'.
12248
12249         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12250         * gnu-nat.h (mach_thread_info): New function.
12251         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12252
12253         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12254
12255 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12256
12257         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12258
12259 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12260
12261         * windows-nat.c (windows_add_thread): Add new parameter
12262         "main_thread_p" with default value set to false.  Update
12263         function documentation as well as all callers.
12264         (windows_delete_thread): Likewise.
12265         (fake_create_process): Update call to windows_add_thread.
12266         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12267         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12268         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12269         call to windows_delete_thread.
12270
12271 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12272
12273         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12274
12275 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12276
12277         * symfile.c (find_separate_debug_file): Use canonical path of
12278         sysroot with child_path instead of gdb_sysroot if it is valid.
12279
12280 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12281
12282         * symfile.c (find_separate_debug_file): Use child_path to
12283         determine if an object file is under a sysroot.
12284
12285 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12286
12287         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12288         unittests/child-path-selftests.c.
12289         * common/pathstuff.c (child_path): New function.
12290         * common/pathstuff.h (child_path): New prototype.
12291         * unittests/child-path-selftests.c: New file.
12292
12293 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12294
12295         * symfile.c (find_separate_debug_file): Look for separate debug
12296         files in debug directories under the sysroot.
12297
12298 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12299
12300         * symtab.h (struct minimal_symbol data_p): New const method.
12301         (struct minimal_symbol text_p): Likewise.
12302         * symtab.c (output_source_filename): Use file name style
12303         to print file name.
12304         (print_symbol_info): Likewise.
12305         (print_msymbol_info): Use address style to print addresses.
12306         Use function name style to print executable text symbols.
12307         (expand_symtab_containing_pc): Use data_p.
12308         (find_pc_sect_compunit_symtab): Likewise.
12309
12310 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12311
12312         * breakpoint.c (describe_other_breakpoints): Use address style
12313         to print addresses.
12314         (say_where): Likewise.
12315
12316 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12317
12318         * ada-typeprint.c (print_func_type): Print function name
12319         style to print function name.
12320         * c-typeprint.c (c_print_type_1): Likewise.
12321
12322 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12323
12324         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12325         for execve.
12326
12327 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12328
12329         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12330         type_stack.
12331
12332 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12333
12334         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12335         TYPE_CODE_REF types.
12336
12337 2019-02-08  Jim Wilson  <jimw@sifive.com>
12338
12339         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12340         (riscv_linux_fregset): New.
12341         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12342
12343 2019-02-07  Tom Tromey  <tom@tromey.com>
12344
12345         * thread.c (thread_cancel_execution_command): Update.
12346         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12347         methods.
12348         (struct thread_fsm_ops): Remove.
12349         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12350         (thread_fsm_should_stop, thread_fsm_return_value)
12351         (thread_fsm_set_finished, thread_fsm_finished_p)
12352         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12353         Don't declare.
12354         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12355         * infrun.c (clear_proceed_status_thread)
12356         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12357         (print_stop_event): Update.
12358         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12359         Add constructor.
12360         (step_command_fsm_ops): Remove.
12361         (new_step_command_fsm): Remove.
12362         (step_1): Update.
12363         (step_command_fsm::should_stop): Rename from
12364         step_command_fsm_should_stop.
12365         (step_command_fsm::clean_up): Rename from
12366         step_command_fsm_clean_up.
12367         (step_command_fsm::do_async_reply_reason): Rename from
12368         step_command_fsm_async_reply_reason.
12369         (struct until_next_fsm): Inherit from thread_fsm.  Add
12370         constructor.
12371         (until_next_fsm_ops): Remove.
12372         (new_until_next_fsm): Remove.
12373         (until_next_fsm::should_stop): Rename from
12374         until_next_fsm_should_stop.
12375         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12376         (until_next_fsm::do_async_reply_reason): Rename from
12377         until_next_fsm_async_reply_reason.
12378         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12379         constructor.  Change type of breakpoint.
12380         (finish_command_fsm_ops): Remove.
12381         (new_finish_command_fsm): Remove.
12382         (finish_command_fsm::should_stop): Rename from
12383         finish_command_fsm_should_stop.
12384         (finish_command_fsm::clean_up): Rename from
12385         finish_command_fsm_clean_up.
12386         (finish_command_fsm::return_value): Rename from
12387         finish_command_fsm_return_value.
12388         (finish_command_fsm::do_async_reply_reason): Rename from
12389         finish_command_fsm_async_reply_reason.
12390         (finish_command): Update.
12391         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12392         Add constructor.
12393         (call_thread_fsm_ops): Remove.
12394         (call_thread_fsm::call_thread_fsm): Rename from
12395         new_call_thread_fsm.
12396         (call_thread_fsm::should_stop): Rename from
12397         call_thread_fsm_should_stop.
12398         (call_thread_fsm::should_notify_stop): Rename from
12399         call_thread_fsm_should_notify_stop.
12400         (run_inferior_call, call_function_by_hand_dummy): Update.
12401         * cli/cli-interp.c (should_print_stop_to_console): Update.
12402         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12403         Add constructor.  Change type of location_breakpoint,
12404         caller_breakpoint.
12405         (until_break_fsm_ops): Remove.
12406         (new_until_break_fsm): Remove.
12407         (until_break_fsm::should_stop): Rename from
12408         until_break_fsm_should_stop.
12409         (until_break_fsm::clean_up): Rename from
12410         until_break_fsm_clean_up.
12411         (until_break_fsm::do_async_reply_reason): Rename from
12412         until_break_fsm_async_reply_reason.
12413         (until_break_command): Update.
12414         * thread-fsm.c: Remove.
12415         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12416
12417 2019-02-07  Tom Tromey  <tom@tromey.com>
12418
12419         * yy-remap.h: Add include guard.
12420         * xtensa-tdep.h: Add include guard.
12421         * xcoffread.h: Rename include guard.
12422         * varobj-iter.h: Add include guard.
12423         * tui/tui.h: Rename include guard.
12424         * tui/tui-winsource.h: Rename include guard.
12425         * tui/tui-wingeneral.h: Rename include guard.
12426         * tui/tui-windata.h: Rename include guard.
12427         * tui/tui-win.h: Rename include guard.
12428         * tui/tui-stack.h: Rename include guard.
12429         * tui/tui-source.h: Rename include guard.
12430         * tui/tui-regs.h: Rename include guard.
12431         * tui/tui-out.h: Rename include guard.
12432         * tui/tui-layout.h: Rename include guard.
12433         * tui/tui-io.h: Rename include guard.
12434         * tui/tui-hooks.h: Rename include guard.
12435         * tui/tui-file.h: Rename include guard.
12436         * tui/tui-disasm.h: Rename include guard.
12437         * tui/tui-data.h: Rename include guard.
12438         * tui/tui-command.h: Rename include guard.
12439         * tic6x-tdep.h: Add include guard.
12440         * target/waitstatus.h: Rename include guard.
12441         * target/wait.h: Rename include guard.
12442         * target/target.h: Rename include guard.
12443         * target/resume.h: Rename include guard.
12444         * target-float.h: Rename include guard.
12445         * stabsread.h: Add include guard.
12446         * rs6000-tdep.h: Add include guard.
12447         * riscv-fbsd-tdep.h: Add include guard.
12448         * regformats/regdef.h: Rename include guard.
12449         * record.h: Rename include guard.
12450         * python/python.h: Rename include guard.
12451         * python/python-internal.h: Rename include guard.
12452         * python/py-stopevent.h: Rename include guard.
12453         * python/py-ref.h: Rename include guard.
12454         * python/py-record.h: Rename include guard.
12455         * python/py-record-full.h: Rename include guard.
12456         * python/py-record-btrace.h: Rename include guard.
12457         * python/py-instruction.h: Rename include guard.
12458         * python/py-events.h: Rename include guard.
12459         * python/py-event.h: Rename include guard.
12460         * procfs.h: Add include guard.
12461         * proc-utils.h: Add include guard.
12462         * p-lang.h: Add include guard.
12463         * or1k-tdep.h: Rename include guard.
12464         * observable.h: Rename include guard.
12465         * nto-tdep.h: Rename include guard.
12466         * nat/x86-linux.h: Rename include guard.
12467         * nat/x86-linux-dregs.h: Rename include guard.
12468         * nat/x86-gcc-cpuid.h: Add include guard.
12469         * nat/x86-dregs.h: Rename include guard.
12470         * nat/x86-cpuid.h: Rename include guard.
12471         * nat/ppc-linux.h: Rename include guard.
12472         * nat/mips-linux-watch.h: Rename include guard.
12473         * nat/linux-waitpid.h: Rename include guard.
12474         * nat/linux-ptrace.h: Rename include guard.
12475         * nat/linux-procfs.h: Rename include guard.
12476         * nat/linux-osdata.h: Rename include guard.
12477         * nat/linux-nat.h: Rename include guard.
12478         * nat/linux-namespaces.h: Rename include guard.
12479         * nat/linux-btrace.h: Rename include guard.
12480         * nat/glibc_thread_db.h: Rename include guard.
12481         * nat/gdb_thread_db.h: Rename include guard.
12482         * nat/gdb_ptrace.h: Rename include guard.
12483         * nat/fork-inferior.h: Rename include guard.
12484         * nat/amd64-linux-siginfo.h: Rename include guard.
12485         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12486         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12487         * nat/aarch64-linux.h: Rename include guard.
12488         * nat/aarch64-linux-hw-point.h: Rename include guard.
12489         * mn10300-tdep.h: Add include guard.
12490         * mips-linux-tdep.h: Add include guard.
12491         * mi/mi-parse.h: Rename include guard.
12492         * mi/mi-out.h: Rename include guard.
12493         * mi/mi-main.h: Rename include guard.
12494         * mi/mi-interp.h: Rename include guard.
12495         * mi/mi-getopt.h: Rename include guard.
12496         * mi/mi-console.h: Rename include guard.
12497         * mi/mi-common.h: Rename include guard.
12498         * mi/mi-cmds.h: Rename include guard.
12499         * mi/mi-cmd-break.h: Rename include guard.
12500         * m2-lang.h: Add include guard.
12501         * location.h: Rename include guard.
12502         * linux-record.h: Rename include guard.
12503         * linux-nat.h: Add include guard.
12504         * linux-fork.h: Add include guard.
12505         * i386-darwin-tdep.h: Rename include guard.
12506         * hppa-linux-offsets.h: Add include guard.
12507         * guile/guile.h: Rename include guard.
12508         * guile/guile-internal.h: Rename include guard.
12509         * gnu-nat.h: Rename include guard.
12510         * gdb-stabs.h: Rename include guard.
12511         * frv-tdep.h: Add include guard.
12512         * f-lang.h: Add include guard.
12513         * event-loop.h: Add include guard.
12514         * darwin-nat.h: Rename include guard.
12515         * cp-abi.h: Rename include guard.
12516         * config/sparc/nm-sol2.h: Rename include guard.
12517         * config/nm-nto.h: Rename include guard.
12518         * config/nm-linux.h: Add include guard.
12519         * config/i386/nm-i386gnu.h: Rename include guard.
12520         * config/djgpp/nl_types.h: Rename include guard.
12521         * config/djgpp/langinfo.h: Rename include guard.
12522         * compile/gcc-cp-plugin.h: Add include guard.
12523         * compile/gcc-c-plugin.h: Add include guard.
12524         * compile/compile.h: Rename include guard.
12525         * compile/compile-object-run.h: Rename include guard.
12526         * compile/compile-object-load.h: Rename include guard.
12527         * compile/compile-internal.h: Rename include guard.
12528         * compile/compile-cplus.h: Rename include guard.
12529         * compile/compile-c.h: Rename include guard.
12530         * common/xml-utils.h: Rename include guard.
12531         * common/x86-xstate.h: Rename include guard.
12532         * common/version.h: Rename include guard.
12533         * common/vec.h: Rename include guard.
12534         * common/tdesc.h: Rename include guard.
12535         * common/selftest.h: Rename include guard.
12536         * common/scoped_restore.h: Rename include guard.
12537         * common/scoped_mmap.h: Rename include guard.
12538         * common/scoped_fd.h: Rename include guard.
12539         * common/safe-iterator.h: Rename include guard.
12540         * common/run-time-clock.h: Rename include guard.
12541         * common/refcounted-object.h: Rename include guard.
12542         * common/queue.h: Rename include guard.
12543         * common/ptid.h: Rename include guard.
12544         * common/print-utils.h: Rename include guard.
12545         * common/preprocessor.h: Rename include guard.
12546         * common/pathstuff.h: Rename include guard.
12547         * common/observable.h: Rename include guard.
12548         * common/netstuff.h: Rename include guard.
12549         * common/job-control.h: Rename include guard.
12550         * common/host-defs.h: Rename include guard.
12551         * common/gdb_wait.h: Rename include guard.
12552         * common/gdb_vecs.h: Rename include guard.
12553         * common/gdb_unlinker.h: Rename include guard.
12554         * common/gdb_unique_ptr.h: Rename include guard.
12555         * common/gdb_tilde_expand.h: Rename include guard.
12556         * common/gdb_sys_time.h: Rename include guard.
12557         * common/gdb_string_view.h: Rename include guard.
12558         * common/gdb_splay_tree.h: Rename include guard.
12559         * common/gdb_setjmp.h: Rename include guard.
12560         * common/gdb_ref_ptr.h: Rename include guard.
12561         * common/gdb_optional.h: Rename include guard.
12562         * common/gdb_locale.h: Rename include guard.
12563         * common/gdb_assert.h: Rename include guard.
12564         * common/filtered-iterator.h: Rename include guard.
12565         * common/filestuff.h: Rename include guard.
12566         * common/fileio.h: Rename include guard.
12567         * common/environ.h: Rename include guard.
12568         * common/common-utils.h: Rename include guard.
12569         * common/common-types.h: Rename include guard.
12570         * common/common-regcache.h: Rename include guard.
12571         * common/common-inferior.h: Rename include guard.
12572         * common/common-gdbthread.h: Rename include guard.
12573         * common/common-exceptions.h: Rename include guard.
12574         * common/common-defs.h: Rename include guard.
12575         * common/common-debug.h: Rename include guard.
12576         * common/cleanups.h: Rename include guard.
12577         * common/buffer.h: Rename include guard.
12578         * common/btrace-common.h: Rename include guard.
12579         * common/break-common.h: Rename include guard.
12580         * cli/cli-utils.h: Rename include guard.
12581         * cli/cli-style.h: Rename include guard.
12582         * cli/cli-setshow.h: Rename include guard.
12583         * cli/cli-script.h: Rename include guard.
12584         * cli/cli-interp.h: Rename include guard.
12585         * cli/cli-decode.h: Rename include guard.
12586         * cli/cli-cmds.h: Rename include guard.
12587         * charset-list.h: Add include guard.
12588         * buildsym-legacy.h: Rename include guard.
12589         * bfin-tdep.h: Add include guard.
12590         * ax.h: Rename include guard.
12591         * arm-linux-tdep.h: Add include guard.
12592         * arm-fbsd-tdep.h: Add include guard.
12593         * arch/xtensa.h: Rename include guard.
12594         * arch/tic6x.h: Add include guard.
12595         * arch/i386.h: Add include guard.
12596         * arch/arm.h: Rename include guard.
12597         * arch/arm-linux.h: Rename include guard.
12598         * arch/arm-get-next-pcs.h: Rename include guard.
12599         * arch/amd64.h: Add include guard.
12600         * arch/aarch64-insn.h: Rename include guard.
12601         * arch-utils.h: Rename include guard.
12602         * annotate.h: Add include guard.
12603         * amd64-darwin-tdep.h: Rename include guard.
12604         * aarch64-linux-tdep.h: Add include guard.
12605         * aarch64-fbsd-tdep.h: Add include guard.
12606         * aarch32-linux-nat.h: Add include guard.
12607
12608 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12609
12610         * macrotab.c (macro_define_internal): New function that
12611         factorizes macro_define_object_internal and macro_define_function
12612         code.
12613         (macro_define_object_internal): Use macro_define_internal.
12614         (macro_define_function): Likewise.
12615
12616 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12617
12618         * macrocmd.c (extract_identifier): Return
12619         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12620         callers.
12621
12622 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12623
12624         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12625
12626 2019-02-05  Tom Tromey  <tom@tromey.com>
12627
12628         * target.c (target_stack::unpush): Move assertion earlier.
12629
12630 2019-01-30  Tom Tromey  <tom@tromey.com>
12631
12632         PR python/23615:
12633         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12634         (gdbpy_parse_and_eval): Likewise.
12635         * python/python-internal.h (gdbpy_allow_threads): New class.
12636
12637 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12638
12639         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12640         (aarch64_fbsd_fpregmap): Move earlier.
12641         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12642         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12643         instead of individual calls to trad_frame_set_reg_addr.
12644         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12645         earlier.
12646         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12647         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12648         instead of individual calls to trad_frame_set_reg_addr.
12649
12650 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12651
12652         * CONTRIBUTE: Replace contribution list with wiki link.
12653
12654 2019-01-25  Tom Tromey  <tom@tromey.com>
12655
12656         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12657
12658 2019-01-25  Tom Tromey  <tom@tromey.com>
12659
12660         * xtensa-linux-nat.c: Fix common/ includes.
12661         * xml-support.h: Fix common/ includes.
12662         * xml-support.c: Fix common/ includes.
12663         * x86-linux-nat.c: Fix common/ includes.
12664         * windows-nat.c: Fix common/ includes.
12665         * varobj.h: Fix common/ includes.
12666         * varobj.c: Fix common/ includes.
12667         * value.c: Fix common/ includes.
12668         * valops.c: Fix common/ includes.
12669         * utils.c: Fix common/ includes.
12670         * unittests/xml-utils-selftests.c: Fix common/ includes.
12671         * unittests/utils-selftests.c: Fix common/ includes.
12672         * unittests/unpack-selftests.c: Fix common/ includes.
12673         * unittests/tracepoint-selftests.c: Fix common/ includes.
12674         * unittests/style-selftests.c: Fix common/ includes.
12675         * unittests/string_view-selftests.c: Fix common/ includes.
12676         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12677         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12678         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12679         * unittests/rsp-low-selftests.c: Fix common/ includes.
12680         * unittests/parse-connection-spec-selftests.c: Fix common/
12681         includes.
12682         * unittests/optional-selftests.c: Fix common/ includes.
12683         * unittests/offset-type-selftests.c: Fix common/ includes.
12684         * unittests/observable-selftests.c: Fix common/ includes.
12685         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12686         * unittests/memrange-selftests.c: Fix common/ includes.
12687         * unittests/memory-map-selftests.c: Fix common/ includes.
12688         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12689         * unittests/function-view-selftests.c: Fix common/ includes.
12690         * unittests/environ-selftests.c: Fix common/ includes.
12691         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12692         * unittests/common-utils-selftests.c: Fix common/ includes.
12693         * unittests/cli-utils-selftests.c: Fix common/ includes.
12694         * unittests/array-view-selftests.c: Fix common/ includes.
12695         * ui-file.c: Fix common/ includes.
12696         * tui/tui-io.c: Fix common/ includes.
12697         * tracepoint.h: Fix common/ includes.
12698         * tracepoint.c: Fix common/ includes.
12699         * tracefile-tfile.c: Fix common/ includes.
12700         * top.h: Fix common/ includes.
12701         * top.c: Fix common/ includes.
12702         * thread.c: Fix common/ includes.
12703         * target/waitstatus.h: Fix common/ includes.
12704         * target/waitstatus.c: Fix common/ includes.
12705         * target.h: Fix common/ includes.
12706         * target.c: Fix common/ includes.
12707         * target-memory.c: Fix common/ includes.
12708         * target-descriptions.c: Fix common/ includes.
12709         * symtab.h: Fix common/ includes.
12710         * symfile.c: Fix common/ includes.
12711         * stap-probe.c: Fix common/ includes.
12712         * spu-linux-nat.c: Fix common/ includes.
12713         * sparc-nat.c: Fix common/ includes.
12714         * source.c: Fix common/ includes.
12715         * solib.c: Fix common/ includes.
12716         * solib-target.c: Fix common/ includes.
12717         * ser-unix.c: Fix common/ includes.
12718         * ser-tcp.c: Fix common/ includes.
12719         * ser-pipe.c: Fix common/ includes.
12720         * ser-base.c: Fix common/ includes.
12721         * selftest-arch.c: Fix common/ includes.
12722         * s12z-tdep.c: Fix common/ includes.
12723         * rust-exp.y: Fix common/ includes.
12724         * rs6000-aix-tdep.c: Fix common/ includes.
12725         * riscv-tdep.c: Fix common/ includes.
12726         * remote.c: Fix common/ includes.
12727         * remote-notif.h: Fix common/ includes.
12728         * remote-fileio.h: Fix common/ includes.
12729         * remote-fileio.c: Fix common/ includes.
12730         * regcache.h: Fix common/ includes.
12731         * regcache.c: Fix common/ includes.
12732         * record-btrace.c: Fix common/ includes.
12733         * python/python.c: Fix common/ includes.
12734         * python/py-type.c: Fix common/ includes.
12735         * python/py-inferior.c: Fix common/ includes.
12736         * progspace.h: Fix common/ includes.
12737         * producer.c: Fix common/ includes.
12738         * procfs.c: Fix common/ includes.
12739         * proc-api.c: Fix common/ includes.
12740         * printcmd.c: Fix common/ includes.
12741         * ppc-linux-nat.c: Fix common/ includes.
12742         * parser-defs.h: Fix common/ includes.
12743         * osdata.c: Fix common/ includes.
12744         * obsd-nat.c: Fix common/ includes.
12745         * nat/x86-linux.c: Fix common/ includes.
12746         * nat/x86-linux-dregs.c: Fix common/ includes.
12747         * nat/x86-dregs.h: Fix common/ includes.
12748         * nat/x86-dregs.c: Fix common/ includes.
12749         * nat/ppc-linux.c: Fix common/ includes.
12750         * nat/mips-linux-watch.h: Fix common/ includes.
12751         * nat/mips-linux-watch.c: Fix common/ includes.
12752         * nat/linux-waitpid.c: Fix common/ includes.
12753         * nat/linux-ptrace.h: Fix common/ includes.
12754         * nat/linux-ptrace.c: Fix common/ includes.
12755         * nat/linux-procfs.c: Fix common/ includes.
12756         * nat/linux-personality.c: Fix common/ includes.
12757         * nat/linux-osdata.c: Fix common/ includes.
12758         * nat/linux-namespaces.c: Fix common/ includes.
12759         * nat/linux-btrace.h: Fix common/ includes.
12760         * nat/linux-btrace.c: Fix common/ includes.
12761         * nat/fork-inferior.c: Fix common/ includes.
12762         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12763         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12764         * nat/aarch64-linux.c: Fix common/ includes.
12765         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12766         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12767         * namespace.h: Fix common/ includes.
12768         * mips-linux-tdep.c: Fix common/ includes.
12769         * minsyms.c: Fix common/ includes.
12770         * mi/mi-parse.h: Fix common/ includes.
12771         * mi/mi-main.c: Fix common/ includes.
12772         * mi/mi-cmd-env.c: Fix common/ includes.
12773         * memrange.h: Fix common/ includes.
12774         * memattr.c: Fix common/ includes.
12775         * maint.h: Fix common/ includes.
12776         * maint.c: Fix common/ includes.
12777         * main.c: Fix common/ includes.
12778         * machoread.c: Fix common/ includes.
12779         * location.c: Fix common/ includes.
12780         * linux-thread-db.c: Fix common/ includes.
12781         * linux-nat.c: Fix common/ includes.
12782         * linux-fork.c: Fix common/ includes.
12783         * inline-frame.c: Fix common/ includes.
12784         * infrun.c: Fix common/ includes.
12785         * inflow.c: Fix common/ includes.
12786         * inferior.h: Fix common/ includes.
12787         * inferior.c: Fix common/ includes.
12788         * infcmd.c: Fix common/ includes.
12789         * inf-ptrace.c: Fix common/ includes.
12790         * inf-child.c: Fix common/ includes.
12791         * ia64-linux-nat.c: Fix common/ includes.
12792         * i387-tdep.c: Fix common/ includes.
12793         * i386-tdep.c: Fix common/ includes.
12794         * i386-linux-tdep.c: Fix common/ includes.
12795         * i386-linux-nat.c: Fix common/ includes.
12796         * i386-go32-tdep.c: Fix common/ includes.
12797         * i386-fbsd-tdep.c: Fix common/ includes.
12798         * i386-fbsd-nat.c: Fix common/ includes.
12799         * guile/scm-type.c: Fix common/ includes.
12800         * guile/guile.c: Fix common/ includes.
12801         * go32-nat.c: Fix common/ includes.
12802         * gnu-nat.c: Fix common/ includes.
12803         * gdbthread.h: Fix common/ includes.
12804         * gdbarch-selftests.c: Fix common/ includes.
12805         * gdb_usleep.c: Fix common/ includes.
12806         * gdb_select.h: Fix common/ includes.
12807         * gdb_bfd.c: Fix common/ includes.
12808         * gcore.c: Fix common/ includes.
12809         * fork-child.c: Fix common/ includes.
12810         * findvar.c: Fix common/ includes.
12811         * fbsd-nat.c: Fix common/ includes.
12812         * event-top.c: Fix common/ includes.
12813         * event-loop.c: Fix common/ includes.
12814         * dwarf2read.c: Fix common/ includes.
12815         * dwarf2loc.c: Fix common/ includes.
12816         * dwarf2-frame.c: Fix common/ includes.
12817         * dwarf-index-cache.c: Fix common/ includes.
12818         * dtrace-probe.c: Fix common/ includes.
12819         * disasm-selftests.c: Fix common/ includes.
12820         * defs.h: Fix common/ includes.
12821         * csky-tdep.c: Fix common/ includes.
12822         * cp-valprint.c: Fix common/ includes.
12823         * cp-support.h: Fix common/ includes.
12824         * cp-support.c: Fix common/ includes.
12825         * corelow.c: Fix common/ includes.
12826         * completer.h: Fix common/ includes.
12827         * completer.c: Fix common/ includes.
12828         * compile/compile.c: Fix common/ includes.
12829         * compile/compile-loc2c.c: Fix common/ includes.
12830         * compile/compile-cplus-types.c: Fix common/ includes.
12831         * compile/compile-cplus-symbols.c: Fix common/ includes.
12832         * command.h: Fix common/ includes.
12833         * cli/cli-dump.c: Fix common/ includes.
12834         * cli/cli-cmds.c: Fix common/ includes.
12835         * charset.c: Fix common/ includes.
12836         * build-id.c: Fix common/ includes.
12837         * btrace.h: Fix common/ includes.
12838         * btrace.c: Fix common/ includes.
12839         * breakpoint.h: Fix common/ includes.
12840         * breakpoint.c: Fix common/ includes.
12841         * ax.h:
12842         (enum agent_op): Fix common/ includes.
12843         * ax-general.c (struct aop_map): Fix common/ includes.
12844         * ax-gdb.c: Fix common/ includes.
12845         * auxv.c: Fix common/ includes.
12846         * auto-load.c: Fix common/ includes.
12847         * arm-tdep.c: Fix common/ includes.
12848         * arch/riscv.c: Fix common/ includes.
12849         * arch/ppc-linux-common.c: Fix common/ includes.
12850         * arch/i386.c: Fix common/ includes.
12851         * arch/arm.c: Fix common/ includes.
12852         * arch/arm-linux.c: Fix common/ includes.
12853         * arch/arm-get-next-pcs.c: Fix common/ includes.
12854         * arch/amd64.c: Fix common/ includes.
12855         * arch/aarch64.c: Fix common/ includes.
12856         * arch/aarch64-insn.c: Fix common/ includes.
12857         * arch-utils.c: Fix common/ includes.
12858         * amd64-windows-tdep.c: Fix common/ includes.
12859         * amd64-tdep.c: Fix common/ includes.
12860         * amd64-sol2-tdep.c: Fix common/ includes.
12861         * amd64-obsd-tdep.c: Fix common/ includes.
12862         * amd64-nbsd-tdep.c: Fix common/ includes.
12863         * amd64-linux-tdep.c: Fix common/ includes.
12864         * amd64-linux-nat.c: Fix common/ includes.
12865         * amd64-fbsd-tdep.c: Fix common/ includes.
12866         * amd64-fbsd-nat.c: Fix common/ includes.
12867         * amd64-dicos-tdep.c: Fix common/ includes.
12868         * amd64-darwin-tdep.c: Fix common/ includes.
12869         * agent.c: Fix common/ includes.
12870         * ada-lang.h: Fix common/ includes.
12871         * ada-lang.c: Fix common/ includes.
12872         * aarch64-tdep.c: Fix common/ includes.
12873
12874 2019-01-25  Tom Tromey  <tom@tromey.com>
12875
12876         * common/create-version.sh: Use common/version.h.
12877
12878 2019-01-24  Pedro Alves  <palves@redhat.com>
12879
12880         * infrun.c (signal_stop, signal_print, signal_program)
12881         (signal_catch, signal_pass): Now arrays instead of pointers.
12882         (update_signals_program_target, do_target_resume)
12883         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12884         * linux-nat.c (linux_nat_target::pass_signals)
12885         (linux_nat_target::create_inferior, linux_nat_target::attach):
12886         Adjust.
12887         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12888         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12889         * procfs.c (procfs_target::pass_signals): Adjust.
12890         * record-full.c (record_full_target::resume): Adjust.
12891         * remote.c (remote_target::pass_signals)
12892         (remote_target::program_signals): Adjust.
12893         * target-debug.h (target_debug_print_signals): Now takes a
12894         gdb::array_view as parameter.  Adjust.
12895         * target.h (target_ops) <pass_signals, program_signals>: Replace
12896         pointer and length parameters with gdb::array_view.
12897         (target_pass_signals, target_program_signals): Likewise.
12898         * target-delegates.c: Regenerate.
12899
12900 2019-01-24  Pedro Alves  <palves@redhat.com>
12901
12902         * common/forward-scope-exit.h
12903         (forward_scope_exit::forward_scope_exit): Pass arguments to
12904         m_bind_function directly, instead of creating a std::bind and
12905         copying that.
12906
12907 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12908
12909         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12910         for static members.
12911         (pass_in_v_vfp_candidate): Likewise.
12912
12913 2019-01-23  Tom Tromey  <tom@tromey.com>
12914             Pedro Alves  <palves@redhat.com>
12915
12916         * regcache.c (class regcache_invalidator): Remove.
12917         (regcache::raw_write): Use make_scope_exit.
12918
12919 2019-01-23  Tom Tromey  <tom@tromey.com>
12920
12921         * ui-out.h (class ui_out_emit_type): Update comment.
12922
12923 2019-01-23  Tom Tromey  <tom@tromey.com>
12924
12925         * infrun.c (fetch_inferior_event): Update comment.
12926
12927 2019-01-23  Tom Tromey  <tom@tromey.com>
12928             Pedro Alves  <palves@redhat.com>
12929
12930         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12931         parameter.
12932         (fetch_inferior_event): Use SCOPE_EXIT.
12933
12934
12935 2019-01-23  Tom Tromey  <tom@tromey.com>
12936             Pedro Alves  <palves@redhat.com>
12937
12938         * infrun.c (disable_thread_events): Delete.
12939         (stop_all_threads): Use SCOPE_EXIT.
12940
12941 2019-01-23  Tom Tromey  <tom@tromey.com>
12942             Pedro Alves  <palves@redhat.com>
12943
12944         * symfile.c: Include forward-scope-exit.h.
12945         (clear_symtab_users_cleanup): Replace forward declaration with
12946         a FORWARD_SCOPE_EXIT.
12947         (syms_from_objfile_1): Use the forward_scope_exit and
12948         gdb::optional instead of cleanup_function.
12949         (reread_symbols): Use the forward_scope_exit instead of
12950         cleanup_function.
12951         (clear_symtab_users_cleanup): Remove function.
12952
12953 2019-01-23  Tom Tromey  <tom@tromey.com>
12954             Pedro Alves  <palves@redhat.com>
12955
12956         * linux-nat.c: Include scope-exit.h.
12957         (cleanup_target_stop): Remove.
12958         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12959         SCOPE_EXIT.
12960
12961 2019-01-23  Tom Tromey  <tom@tromey.com>
12962             Pedro Alves  <palves@redhat.com>
12963
12964         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12965         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12966
12967 2019-01-23  Tom Tromey  <tom@tromey.com>
12968             Andrew Burgess  <andrew.burgess@embecosm.com>
12969             Pedro Alves  <palves@redhat.com>
12970
12971         * infrun.c (fetch_inferior_event): Use scope_exit.
12972         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12973         * top.c (execute_command): Use scope_exit.
12974         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12975         * utils.c (do_bpstat_clear_actions_cleanup)
12976         (make_bpstat_clear_actions_cleanup): Remove.
12977
12978 2019-01-23  Tom Tromey  <tom@tromey.com>
12979             Pedro Alves  <palves@redhat.com>
12980
12981         * infrun.c: Include "common/scope-exit.h"
12982         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12983         (wait_for_inferior): Use SCOPE_EXIT.
12984         (fetch_inferior_event): Use scope_exit.
12985
12986 2019-01-23  Tom Tromey  <tom@tromey.com>
12987             Pedro Alves  <palves@redhat.com>
12988
12989         * breakpoint.c (create_breakpoint): Remove cleanup.
12990
12991 2019-01-23  Tom Tromey  <tom@tromey.com>
12992             Andrew Burgess  <andrew.burgess@embecosm.com>
12993             Pedro Alves  <palves@redhat.com>
12994
12995 2019-01-23  Pedro Alves  <palves@redhat.com>
12996
12997         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12998
12999 2019-01-23  Pedro Alves  <palves@redhat.com>
13000             Andrew Burgess  <andrew.burgess@embecosm.com>
13001
13002         * gdbthread.h: Include "common/forward-scope-exit.h".
13003         (scoped_finish_thread_state): Redefine custom class in terms of
13004         forward_scope_exit.
13005
13006 2019-01-23  Pedro Alves  <palves@redhat.com>
13007             Andrew Burgess  <andrew.burgess@embecosm.com>
13008
13009         * common/forward-scope-exit.h: New file.
13010
13011 2019-01-23  Pedro Alves  <palves@redhat.com>
13012             Andrew Burgess  <andrew.burgess@embecosm.com>
13013             Tom Tromey  <tom@tromey.com>
13014
13015         * common/scope-exit.h: New file.
13016
13017 2019-01-23  Pedro Alves  <palves@redhat.com>
13018
13019         * common/preprocessor.h (ESC): Rename to ...
13020         (ESC_PARENS): ... this.
13021         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13022         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13023
13024 2019-01-23  Tom Tromey  <tom@tromey.com>
13025
13026         * language.h (class scoped_switch_to_sym_language_if_auto):
13027         Initialize m_lang in both cases.
13028
13029 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13030
13031         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13032         with XCNEW.
13033
13034 2019-01-22  Tom Tromey  <tom@tromey.com>
13035
13036         * corelow.c: Do not include sys/file.h.
13037
13038 2019-01-22  Tom Tromey  <tom@tromey.com>
13039
13040         * tui/tui-wingeneral.h: Include gdb_curses.h.
13041
13042 2019-01-22  Tom Tromey  <tom@tromey.com>
13043
13044         * source-cache.h (class source_cache) <get_source_lines,
13045         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13046
13047 2019-01-22  Tom Tromey  <tom@tromey.com>
13048
13049         * remote-fileio.h (struct remote_target): Declare.
13050
13051 2019-01-22  Tom Tromey  <tom@tromey.com>
13052
13053         * python/py-arch.c: Do not include py-ref.h.
13054         * python/py-bpevent.c: Do not include py-ref.h.
13055         * python/py-cmd.c: Do not include py-ref.h.
13056         * python/py-continueevent.c: Do not include py-ref.h.
13057         * python/py-event.h: Do not include py-ref.h.
13058         * python/py-evtregistry.c: Do not include py-ref.h.
13059         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13060         * python/py-frame.c: Do not include py-ref.h.
13061         * python/py-framefilter.c: Do not include py-ref.h.
13062         * python/py-function.c: Do not include py-ref.h.
13063         * python/py-infevents.c: Do not include py-ref.h.
13064         * python/py-linetable.c: Do not include py-ref.h.
13065         * python/py-objfile.c: Do not include py-ref.h.
13066         * python/py-param.c: Do not include py-ref.h.
13067         * python/py-prettyprint.c: Do not include py-ref.h.
13068         * python/py-progspace.c: Do not include py-ref.h.
13069         * python/py-symbol.c: Do not include py-ref.h.
13070         * python/py-symtab.c: Do not include py-ref.h.
13071         * python/py-type.c: Do not include py-ref.h.
13072         * python/py-unwind.c: Do not include py-ref.h.
13073         * python/py-utils.c: Do not include py-ref.h.
13074         * python/py-value.c: Do not include py-ref.h.
13075         * python/py-varobj.c: Do not include py-ref.h.
13076         * python/py-xmethods.c: Do not include py-ref.h.
13077         * python/python.c: Do not include py-ref.h.
13078         * varobj.c: Do not include py-ref.h.
13079
13080 2019-01-22  Tom Tromey  <tom@tromey.com>
13081
13082         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13083         keyword for bcache.
13084
13085 2019-01-22  Tom Tromey  <tom@tromey.com>
13086
13087         * compile/compile-cplus-types.c: Remove a comment by #include.
13088
13089 2019-01-22  Tom Tromey  <tom@tromey.com>
13090
13091         * compile/gcc-c-plugin.h: Include compile-internal.h.
13092
13093 2019-01-22  Tom Tromey  <tom@tromey.com>
13094
13095         * stabsread.c (EXTERN): Do not define.
13096         (symnum, next_symbol_text_func, processing_gcc_compilation)
13097         (within_function, global_sym_chain, global_stabs)
13098         (previous_stab_code, this_object_header_files)
13099         (n_this_object_header_files)
13100         (n_allocated_this_object_header_files): Define.
13101         * stabsread.h (EXTERN): Never define.  Use "extern".
13102
13103 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13104
13105         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13106         history_value.
13107
13108 2019-01-21  Tom Tromey  <tom@tromey.com>
13109
13110         * ui-out.c: Fix includes.
13111         * tui/tui-source.c: Fix includes.
13112         * target.c: Fix includes.
13113         * remote.c: Fix includes.
13114         * regcache.c: Fix includes.
13115         * python/py-block.c: Fix includes.
13116         * printcmd.c: Fix includes.
13117         * or1k-tdep.c: Fix includes.
13118         * mi/mi-main.c: Fix includes.
13119         * m32r-tdep.c: Fix includes.
13120         * csky-tdep.c: Fix includes.
13121         * compile/compile-cplus-types.c: Fix includes.
13122         * cli/cli-interp.c: Fix includes.
13123
13124 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13125
13126         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13127         for padding.
13128
13129 2019-01-16  Tom Tromey  <tom@tromey.com>
13130
13131         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13132         earlier.
13133         (struct objfile) <msymbols_range>: Move from top level.
13134         <msymbols>: New method.
13135         (class objfile_msymbols): Remove.
13136         * symtab.c (default_collect_symbol_completion_matches_break_on):
13137         Update.
13138         * symmisc.c (dump_msymbols): Update.
13139         * stabsread.c (scan_file_globals): Update.
13140         * objc-lang.c (info_selectors_command, info_classes_command)
13141         (find_methods): Update.
13142         * minsyms.c (find_solib_trampoline_target): Update.
13143         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13144         * coffread.c (coff_symfile_read): Update.
13145         * ada-lang.c (ada_lookup_simple_minsym)
13146         (ada_collect_symbol_completion_matches): Update.
13147
13148 2019-01-16  Tom Tromey  <tom@tromey.com>
13149
13150         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13151         type.  Remove no-argument constructor.
13152         <iterator::operator++>: Simplify.
13153         <begin>: Update.
13154         <end>: Use minimal_symbol_count.
13155
13156 2019-01-16  Tom Tromey  <tom@tromey.com>
13157
13158         * objfiles.h (struct objfile) <psymtabs>: New method.
13159         (class objfile_psymtabs): Remove.
13160         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13161         typedef.
13162         <range>: New method.
13163         (require_partial_symbols): Change return type.
13164         * psymtab.c (require_partial_symbols)
13165         (psym_expand_symtabs_matching): Update.
13166         * mdebugread.c (parse_partial_symbols): Update.
13167         * dbxread.c (dbx_end_psymtab): Update.
13168
13169 2019-01-15  Tom Tromey  <tom@tromey.com>
13170
13171         * symtab.c (lookup_objfile_from_block)
13172         (lookup_symbol_in_objfile_symtabs)
13173         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13174         (find_line_symtab, info_sources_command)
13175         (default_collect_symbol_completion_matches_break_on)
13176         (make_source_files_completion_list): Update.
13177         * symmisc.c (print_objfile_statistics, dump_objfile)
13178         (maintenance_print_symbols, maintenance_info_symtabs)
13179         (maintenance_check_symtabs, maintenance_info_line_tables):
13180         Update.
13181         * source.c (select_source_symtab)
13182         (forget_cached_source_info_for_objfile): Update.
13183         * objfiles.h (class objfile_compunits): Remove.
13184         (struct objfile) <compunits_range>: New typedef.
13185         (compunits): New method.
13186         * objfiles.c (objfile_relocate1): Update.
13187         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13188         * maint.c (count_symtabs_and_blocks): Update.
13189         * linespec.c (iterate_over_all_matching_symtabs): Update.
13190         * cp-support.c (add_symbol_overload_list_qualified): Update.
13191         * coffread.c (coff_symtab_read): Update.
13192         * ada-lang.c (add_nonlocal_symbols)
13193         (ada_collect_symbol_completion_matches)
13194         (ada_add_global_exceptions): Update.
13195
13196 2019-01-15  Tom Tromey  <tom@tromey.com>
13197
13198         * progspace.h (program_space) <objfiles_safe_range>: New
13199         typedef.
13200         <objfiles_safe>: New method.
13201         * objfiles.h (class all_objfiles_safe): Remove.
13202         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13203         * jit.c (jit_inferior_exit_hook): Update.
13204
13205 2019-01-17  Tom Tromey  <tom@tromey.com>
13206
13207         * progspace.h (program_space) <objfiles_range>: New typedef.
13208         <objfiles>: New method.
13209         <objfiles_head>: Rename from objfiles.
13210         (object_files): Update.
13211         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13212         * guile/scm-pretty-print.c
13213         (ppscm_find_pretty_printer_from_objfiles): Update.
13214         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13215         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13216         Update.
13217         * python/py-progspace.c (pspy_get_objfiles): Update.
13218         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13219         Update.
13220         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13221         (objfpy_lookup_objfile_by_build_id): Update.
13222         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13223         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13224         Update.
13225         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13226         (expand_symtab_containing_pc, lookup_objfile_from_block)
13227         (lookup_static_symbol, basic_lookup_transparent_type)
13228         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13229         (find_line_symtab, info_sources_command)
13230         (default_collect_symbol_completion_matches_break_on)
13231         (make_source_files_completion_list, find_main_name): Update.
13232         * symmisc.c (print_symbol_bcache_statistics)
13233         (print_objfile_statistics, maintenance_print_symbols)
13234         (maintenance_print_msymbols, maintenance_print_objfiles)
13235         (maintenance_info_symtabs, maintenance_check_symtabs)
13236         (maintenance_expand_symtabs, maintenance_info_line_tables):
13237         Update.
13238         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13239         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13240         (map_overlay_command, unmap_overlay_command)
13241         (simple_overlay_update, expand_symtabs_matching)
13242         (map_symbol_filenames): Update.
13243         * symfile-debug.c (set_debug_symfile): Update.
13244         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13245         Update.
13246         * source.c (select_source_symtab, forget_cached_source_info):
13247         Update.
13248         * solib.c (solib_read_symbols): Update.
13249         * solib-spu.c (append_ocl_sos): Update.
13250         * psymtab.c (maintenance_print_psymbols)
13251         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13252         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13253         * printcmd.c (info_symbol_command): Update.
13254         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13255         Update.
13256         * objfiles.h (class all_objfiles): Remove.
13257         * objfiles.c (have_partial_symbols, have_full_symbols)
13258         (have_minimal_symbols, qsort_cmp, update_section_map)
13259         (shared_objfile_contains_address_p)
13260         (default_iterate_over_objfiles_in_search_order): Update.
13261         * objc-lang.c (info_selectors_command, info_classes_command)
13262         (find_methods): Update.
13263         * minsyms.c (find_solib_trampoline_target): Update.
13264         * maint.c (maintenance_info_sections)
13265         (maintenance_translate_address, count_symtabs_and_blocks):
13266         Update.
13267         * main.c (captured_main_1): Update.
13268         * linux-thread-db.c (try_thread_db_load_from_pdir)
13269         (has_libpthread): Update.
13270         * linespec.c (iterate_over_all_matching_symtabs)
13271         (search_minsyms_for_name): Update.
13272         * jit.c (jit_find_objf_with_entry_addr): Update.
13273         * hppa-tdep.c (find_unwind_entry)
13274         (hppa_lookup_stub_minimal_symbol): Update.
13275         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13276         Update.
13277         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13278         (elf_gnu_ifunc_resolve_by_got): Update.
13279         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13280         * dwarf-index-write.c (save_gdb_index_command): Update.
13281         * cp-support.c (add_symbol_overload_list_qualified): Update.
13282         * breakpoint.c (create_overlay_event_breakpoint)
13283         (create_longjmp_master_breakpoint)
13284         (create_std_terminate_master_breakpoint)
13285         (create_exception_master_breakpoint): Update.
13286         * blockframe.c (find_pc_partial_function): Update.
13287         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13288         (ada_collect_symbol_completion_matches)
13289         (ada_add_global_exceptions): Update.
13290
13291 2019-01-17  Tom Tromey  <tom@tromey.com>
13292
13293         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13294         declare VEC.
13295         (solib_target_parse_libraries): Change return type.
13296         (library_list_start_segment, library_list_start_section)
13297         (library_list_end_library, library_list_start_library); Update.
13298         (solib_target_free_library_list): Remove.
13299         (solib_target_parse_libraries): Remove cleanup.  Change return
13300         type.
13301         (solib_target_current_sos): Update.
13302
13303 2019-01-17  Tom Tromey  <tromey@bapiya>
13304
13305         * valprint.c: Replace "the the" with "the".
13306         * symtab.c: Replace "the the" with "the".
13307         * solib.c: Replace "the the" with "the".
13308         * solib-dsbt.c: Replace "the the" with "the".
13309         * linespec.c: Replace "the the" with "the".
13310         * dwarf2loc.h: Replace "the the" with "the".
13311         * amd64-windows-tdep.c: Replace "the the" with "the".
13312         * aarch64-tdep.c: Replace "the the" with "the".
13313
13314 2019-01-16  Keith Seitz  <keiths@redhat.com>
13315
13316         PR gdb/23773
13317         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13318         <builder>: Rename to ..
13319         <m_builder>: ... this and make private.
13320         (dwarf2_cu::get_builder): New method.  Change all users of
13321         `builder' to use this method.
13322         (dwarf2_start_symtab): Move to ...
13323         (dwarf2_cu::start_symtab): ... here.  Update all callers
13324         (setup_type_unit_groups): Move to ...
13325         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13326         callers.
13327         (dwarf2_cu::reset_builder): New method.
13328         (process_full_compunit, process_full_type_unit): Use
13329         dwarf2_cu::reset_builder.
13330         (follow_die_offset): Record the ancestor CU if it is different
13331         from the followed DIE's CU.
13332         (follow_die_sig_1): Likewise.
13333
13334 2019-01-15  Tom Tromey  <tom@tromey.com>
13335
13336         * remote.c (class remote_state) <buf>: Now a char_vector.
13337         <buf_size>: Remove.
13338         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13339         parameter.
13340         (remote_target::getpkt_or_notif_sane_1)
13341         (remote_target::getpkt_sane)
13342         (remote_target::getpkt_or_notif_sane): Likewise.
13343         (class remote_target) <putpkt>: New overload.
13344         (remote_target::read_frame): Change type of "buf_p".  Remove
13345         sizeof_p parameter.
13346         (packet_ok): New overload.
13347         (packet_check_result): New overload.
13348         Update all uses.
13349
13350 2019-01-14  Tom Tromey  <tom@tromey.com>
13351
13352         * remote-notif.c (handle_notification, remote_notif_ack)
13353         (remote_notif_parse): Make "buf" const.
13354         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13355         const.
13356         (remote_notif_parse, remote_notif_ack, handle_notification):
13357         Likewise.
13358         * remote.c (remote_notif_stop_parse): Make "buf" const.
13359         (remote_target::remote_parse_stop_reply): Make "buf" const.
13360         (remote_notif_stop_ack): Make "buf" const.
13361
13362 2019-01-14  Tom Tromey  <tom@tromey.com>
13363
13364         * remote.c (remote_console_output): Make parameter const.
13365
13366 2019-01-14  Tom Tromey  <tom@tromey.com>
13367
13368         * target-debug.h (target_debug_print_signals): Constify.
13369         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13370         * procfs.c (procfs_target::pass_signals): Update.
13371         * linux-nat.c (linux_nat_target::pass_signals): Update.
13372         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13373         * target-delegates.c: Rebuild.
13374         * remote.c (remote_target::program_signals): Update.
13375         (remote_target::pass_signals): Update.
13376         * target.c (target_pass_signals): Constify argument.
13377         (target_program_signals): Likewise.
13378         * target.h (struct target_ops) <pass_signals, program_signals>:
13379         Constify argument.
13380         (target_pass_signals, target_program_signals): Constify argument.
13381
13382 2019-01-14  Tom Tromey  <tom@tromey.com>
13383
13384         PR tui/28819:
13385         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13386
13387 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13388
13389         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13390         field.
13391         * rs6000-tdep.c: Include reggroups.h.
13392         (IS_V_ALIAS_PSEUDOREG): Define.
13393         (rs6000_register_name): Return names for the "vX" aliases.
13394         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13395         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13396         aliases.  Call default_register_reggroup_p for all other
13397         pseudo-registers.
13398         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13399         New functions.
13400         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13401         Handle "vX" aliases.
13402         (v_alias_pseudo_register_collect): New function.
13403         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13404         (rs6000_gdbarch_init): Initialize "vX" aliases as
13405         pseudo-registers.  Restore registration of
13406         rs6000_pseudo_register_reggroup_p with
13407         set_tdesc_pseudo_register_reggroup_p.
13408
13409 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13410
13411         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13412         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13413         set_gdbarch_num_pseudo_regs.
13414
13415 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13416
13417         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13418         Remove arg prefixname, add do_set and do_show.
13419         Add member functions set_list and show_list.
13420         * cli/cli-style.c (class cli_style_option): Update accordingly.
13421         (style_set_list): Move to file scope.
13422         (style_show_list): Likewise.
13423         (set_style): Call help_list.
13424         (show_style): Call cmd_show_list.
13425         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13426         Update to use the new macro.
13427
13428 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13429
13430         * ada-lang.c (_initialize_ada_language): Expand the help text
13431         for the "catch exception" command.
13432
13433 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13434
13435         * symtab.c (matching_obj_sections): Initialize obj,
13436         declare it closer to its usage.
13437
13438 2019-01-10  Tom Tromey  <tom@tromey.com>
13439
13440         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13441         (basic_inf_threads_range): Remove.
13442         (inf_threads_range, inf_non_exited_threads_range)
13443         (safe_inf_threads_range): Use next_adapter.
13444
13445 2019-01-10  Keith Seitz  <keiths@redhat.com>
13446
13447         PR gdb/23712
13448         PR symtab/23010
13449         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13450         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13451
13452 2019-01-10  Keith Seitz  <keiths@redhat.com>
13453
13454         PR gdb/23712
13455         PR symtab/23010
13456         * dictionary.c (pending_to_vector): Remove.
13457         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13458         Remove _1 suffix, replacing functions of the same name.  Update
13459         all callers.
13460         (dict_create_hashed, dict_create_hashed_expandable)
13461         (dict_create_linear, dict_create_linear_expandable, dict_free)
13462         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13463         Make functions static.
13464
13465 2019-01-10  Keith Seitz  <keiths@redhat.com>
13466
13467         PR gdb/23712
13468         PR symtab/23010
13469         * dictionary.h (struct dictionary): Replace declaration with
13470         multidictionary.
13471         (dict_create_hashed, dict_create_hashed_expandable)
13472         (dict_create_linear, dict_create_linear_expandable)
13473         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13474         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13475         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13476         taking multidictionary argument.
13477         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13478         * block.h (struct block) <dict>: Change to multidictionary
13479         and rename `multidict'.
13480         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13481         symmisc.c: Update all dictionary references to multidictionary.
13482
13483 2019-01-10  Keith Seitz  <keiths@redhat.com>
13484
13485         PR gdb/23712
13486         PR symtab/23010
13487         * dictionary.c: Include unordered_map.
13488         (pending_to_vector): New function.
13489         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13490         Rewrite the non-"_1" functions to take vector instead
13491         of linked list.
13492         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13493         "new" _1 versions of the same name.
13494         (multidictionary): Define.
13495         (std::hash<enum language): New definition.
13496         (collate_pending_symbols_by_language, mdict_create_hashed)
13497         (mdict_create_hashed_expandable, mdict_create_linear)
13498         (mdict_create_linear_expandable, mdict_free)
13499         (find_language_dictionary, create_new_language_dictionary)
13500         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13501         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13502         (mdict_size, mdict_empty): New functions.
13503         * dictionary.h (mdict_iterator): Define.
13504
13505 2019-01-10  Pedro Alves  <palves@redhat.com>
13506
13507         * breakpoint.c (read_uploaded_action)
13508         (create_tracepoint_from_upload): Adjust to use
13509         gdb::unique_xmalloc_ptr.
13510         * ctf.c (ctf_write_uploaded_tp):
13511         (SET_ARRAY_FIELD): Use emplace_back.
13512         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13513         * tracefile-tfile.c (tfile_write_uploaded_tp):
13514         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13515         gdb::unique_xmalloc_ptr.
13516         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13517         at_string, cond_string, cmd_strings>: Replace char pointers
13518         with gdb::unique_xmalloc_ptr.
13519
13520 2019-01-10  Pedro Alves  <palves@redhat.com>
13521
13522         * solib-target.c (library_list_start_library): Don't xstrdup name.
13523
13524 2019-01-10  Pedro Alves  <palves@redhat.com>
13525
13526         * mdebugread.c (parse_partial_symbols): Use
13527         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13528
13529 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13530
13531         * linux-fork.c (scoped_switch_fork_info)
13532         <~scoped_switch_fork_info>: Fix incorrect variable name.
13533
13534 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13535
13536         * linux-fork.c (scoped_switch_fork_info)
13537         <scoped_switch_fork_info>: Make explicit.
13538         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13539
13540 2019-01-10  Tom Tromey  <tom@tromey.com>
13541
13542         * objfiles.h (objfile::reset_psymtabs): Update.
13543         * objfiles.c (objfile::objfile): Update.
13544         * psymtab.h (psymtab_storage::obstack): Update.
13545         (psymtab_storage::m_obstack): Use gdb::optional.
13546         (class psymtab_storage): Update comment.  Remove objfile
13547         parameter.
13548         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13549
13550 2019-01-10  Tom Tromey  <tom@tromey.com>
13551
13552         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13553         <free_psymtabs>: Now private.
13554         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13555         (allocate_psymtab): Use new method.
13556
13557 2019-01-10  Tom Tromey  <tom@tromey.com>
13558
13559         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13560         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13561         * mdebugread.c (parse_partial_symbols): Use
13562         allocate_dependencies.
13563         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13564         allocate_dependencies.
13565         (process_psymtab_comp_unit_reader)
13566         (build_type_psymtab_dependencies): Likewise.
13567         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13568
13569 2019-01-10  Tom Tromey  <tom@tromey.com>
13570
13571         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13572         PSYMBOL_SET_LANGUAGE.
13573         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13574
13575 2019-01-10  Tom Tromey  <tom@tromey.com>
13576
13577         * psymtab.h (psymtab_storage::obstack): New method.
13578         <m_obstack>: Rename from obstack; now private.
13579         * psymtab.c (psymtab_storage): Update.
13580         * dwarf2read.c (create_addrmap_from_index)
13581         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13582         Update.
13583
13584 2019-01-10  Tom Tromey  <tom@tromey.com>
13585
13586         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13587         * objfiles.h (objfile::reset_psymtabs): New method.
13588
13589 2019-01-10  Tom Tromey  <tom@tromey.com>
13590
13591         * symmisc.c (print_symbol_bcache_statistics): Update.
13592         (print_objfile_statistics): Update.
13593         * symfile.c (reread_symbols): Update.
13594         * psymtab.h (class psymtab_storage): New.
13595         * psymtab.c (psymtab_storage): New constructor.
13596         (~psymtab_storage): New destructor.
13597         (require_partial_symbols): Update.
13598         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13599         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13600         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13601         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13602         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13603         (start_psymtab_common, end_psymtab_common)
13604         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13605         (allocate_psymtab): Update.
13606         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13607         Update.
13608         (dump_psymtab_addrmap, maintenance_print_psymbols)
13609         (maintenance_check_psymtabs): Update.
13610         (class objfile_psymtabs): Move to objfiles.h.
13611         * psympriv.h (discard_psymtab): Now inline.
13612         (psymtab_discarder::psymtab_discarder): Update.
13613         (psymtab_discarder::~psymtab_discarder): Update.
13614         (ALL_OBJFILE_PSYMTABS): Rewrite.
13615         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13616         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13617         Remove fields.
13618         <partial_symtabs>: New field.
13619         (class objfile_psymtabs): Move from psymtab.h.  Update.
13620         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13621         psymbol_cache.
13622         (objfile::~objfile): Don't destroy psymbol_cache.
13623         * mdebugread.c (parse_partial_symbols): Update.
13624         * dwarf2read.c (create_addrmap_from_index)
13625         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13626         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13627         (add_partial_subprogram, dwarf2_ranges_read): Update.
13628         * dwarf-index-write.c (write_address_map)
13629         (write_one_signatured_type, recursively_write_psymbols)
13630         (class debug_names, class debug_names, write_psymtabs_to_index):
13631         Update.
13632
13633 2019-01-10  Tom Tromey  <tom@tromey.com>
13634
13635         * symtab.h (SYMBOL_SET_NAMES): Update.
13636         (symbol_set_names): Update.
13637         (MSYMBOL_SET_NAMES): Update.
13638         * symtab.c (symbol_set_names): Change argument to be an
13639         objfile_per_bfd_storage.
13640         * psymtab.c (add_psymbol_to_bcache): Update.
13641         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13642
13643 2019-01-10  Tom Tromey  <tom@tromey.com>
13644
13645         * symtab.c (create_demangled_names_hash): Change argument to be an
13646         objfile_per_bfd_storage.
13647         (symbol_set_names): Update.
13648
13649 2019-01-10  Tom Tromey  <tom@tromey.com>
13650
13651         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13652         init_psymbol_list.
13653         * psymtab.c (init_psymbol_list): Do nothing if already called.
13654         * psympriv.h (init_psymbol_list): Add comment.
13655         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13656         init_psymbol_list.
13657         * dbxread.c (dbx_symfile_read): Unconditionally call
13658         init_psymbol_list.
13659
13660 2019-01-10  Tom Tromey  <tom@tromey.com>
13661
13662         * xcoffread.c (scan_xcoff_symtab): Update.
13663         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13664         "where".
13665         * mdebugread.c (parse_partial_symbols)
13666         (handle_psymbol_enumerators): Update.
13667         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13668         * dbxread.c (read_dbx_symtab): Update.
13669         * psympriv.h (psymbol_placement): New enum.
13670         (add_psymbol_to_list): Update.
13671
13672 2019-01-10  Tom Tromey  <tom@tromey.com>
13673
13674         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13675         static_psymbols parameters.
13676         (scan_xcoff_symtab): Update.
13677         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13678         static_psymbols parameters.
13679         * psympriv.h (start_psymtab_common): Update.
13680         * mdebugread.c (parse_partial_symbols): Update.
13681         * dwarf2read.c (create_partial_symtab): Update.
13682         * dbxread.c (read_dbx_symtab): Update.
13683         (start_psymtab): Remove global_psymbols and static_psymbols
13684         parameters.
13685
13686 2019-01-10  Tom Tromey  <tom@tromey.com>
13687
13688         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13689         * psymtab.c (allocate_psymtab): Add comment.
13690         * psympriv.h (allocate_psymtab): Add comment.
13691         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13692         initializations.
13693         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13694
13695 2019-01-10  Tom Tromey  <tom@tromey.com>
13696
13697         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13698         Don't declare.
13699         * mipsread.c: Include mdebugread.h.
13700         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13701         Declare.
13702         * elfread.c: Include mdebugread.h.
13703
13704 2019-01-09  Tom Tromey  <tom@tromey.com>
13705
13706         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13707         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13708         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13709         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13710         (psym_lookup_symbol, psym_find_last_source_symtab)
13711         (psym_forget_cached_source_info, psym_print_stats)
13712         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13713         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13714         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13715         (psym_find_compunit_symtab_by_address)
13716         (maintenance_print_psymbols, maintenance_info_psymtabs)
13717         (maintenance_check_psymtabs): Use ranged for.
13718         * psymtab.h (class objfile_psymtabs): New.
13719         (require_partial_symbols): Return objfile_psymtabs.
13720         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13721
13722 2019-01-09  Tom Tromey  <tom@tromey.com>
13723
13724         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13725         (find_pc_mapped_section, list_overlays_command)
13726         (map_overlay_command, unmap_overlay_command)
13727         (simple_overlay_update): Use all_objfiles.
13728         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13729         * printcmd.c (info_symbol_command): Use all_objfiles.
13730         * objfiles.h (ALL_OBJSECTIONS): Remove.
13731         * maint.c (maintenance_translate_address): Use all_objfiles.
13732         * gcore.c (gcore_create_callback): Use all_objfiles.
13733         (objfile_find_memory_regions): Likewise.
13734
13735 2019-01-09  Tom Tromey  <tom@tromey.com>
13736
13737         * symtab.c (find_line_symtab, info_sources_command)
13738         (make_source_files_completion_list): Use objfile_compunits.
13739         * source.c (select_source_symtab): Use objfile_compunits.
13740         * objfiles.h (struct objfile): Update comment.
13741         (ALL_OBJFILES): Remove.
13742         (ALL_FILETABS): Remove.
13743         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13744         objfile_compunits.
13745
13746 2019-01-09  Tom Tromey  <tom@tromey.com>
13747
13748         * symmisc.c (print_objfile_statistics, dump_objfile)
13749         (maintenance_print_symbols): Use compunit_filetabs.
13750         * source.c (forget_cached_source_info_for_objfile): Use
13751         compunit_filetabs.
13752         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13753         (ALL_FILETABS): Use compunit_filetabs.
13754         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13755         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13756
13757 2019-01-09  Tom Tromey  <tom@tromey.com>
13758
13759         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13760         (compunit_filetabs): New.
13761         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13762         compunit_filetabs.
13763         (info_sources_command, make_source_files_completion_list): Remove
13764         declaration.
13765         * symmisc.c (print_objfile_statistics, dump_objfile)
13766         (maintenance_print_symbols): Remove declaration.
13767         (maintenance_info_symtabs): Use compunit_filetabs.
13768         (maintenance_info_line_tables): Likewise.
13769         * source.c (select_source_symtab): Change local variable name.
13770         (forget_cached_source_info_for_objfile): Remove declaration.
13771         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13772         * objfiles.c (objfile_relocate1): Remove declaration.
13773         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13774         declaration.
13775         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13776         * coffread.c (coff_symtab_read): Remove declaration.
13777         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13778         compunit_filetabs.
13779
13780 2019-01-09  Tom Tromey  <tom@tromey.com>
13781
13782         * symtab.c (lookup_objfile_from_block)
13783         (find_pc_sect_compunit_symtab, search_symbols)
13784         (default_collect_symbol_completion_matches_break_on): Use
13785         objfile_compunits.
13786         * objfiles.h (ALL_COMPUNITS): Remove.
13787         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13788         * cp-support.c (add_symbol_overload_list_qualified): Use
13789         objfile_compunits.
13790         * ada-lang.c (ada_collect_symbol_completion_matches)
13791         (ada_add_global_exceptions): Use objfile_compunits.
13792
13793 2019-01-09  Tom Tromey  <tom@tromey.com>
13794
13795         * source.c (select_source_symtab)
13796         (forget_cached_source_info_for_objfile): Remove declaration.
13797         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13798         declaration.
13799         * maint.c (count_symtabs_and_blocks): Remove declaration.
13800         * cp-support.c (add_symbol_overload_list_qualified): Remove
13801         declaration.
13802         * coffread.c (coff_symtab_read): Remove declaration.
13803         * symtab.c (lookup_symbol_in_objfile_symtabs)
13804         (basic_lookup_transparent_type_1): Use objfile_compunits.
13805         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13806         (info_sources_command, search_symbols)
13807         (default_collect_symbol_completion_matches_break_on)
13808         (make_source_files_completion_list): Remove declaration.
13809         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13810         (ada_collect_symbol_completion_matches)
13811         (ada_add_global_exceptions): Remove declaration.
13812         * linespec.c (iterate_over_all_matching_symtabs): Use
13813         objfile_compunits.
13814         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13815         (class objfile_compunits): New.
13816         (ALL_COMPUNITS): Use objfile_compunits.
13817         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13818         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13819         objfile_compunits.
13820         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13821
13822 2019-01-09  Tom Tromey  <tom@tromey.com>
13823
13824         * symtab.c (search_symbols)
13825         (default_collect_symbol_completion_matches_break_on): Use
13826         objfile_msymbols.
13827         * ada-lang.c (ada_lookup_simple_minsym)
13828         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13829         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13830         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13831         objfile_msymbols.
13832         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13833         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13834         * objc-lang.c (find_methods): Use objfile_msymbols.
13835         (info_selectors_command, info_classes_command): Likewise.
13836         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13837         * objfiles.h (class objfile_msymbols): New.
13838         (ALL_OBJFILE_MSYMBOLS): Remove.
13839         (ALL_MSYMBOLS): Remove.
13840
13841 2019-01-09  Tom Tromey  <tom@tromey.com>
13842
13843         * common/next-iterator.h (next_adapter): Add Iterator template
13844         parameter.
13845         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13846         (class all_objfiles_safe): New.
13847         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13848         * objfiles.c (put_objfile_before): Update comment.
13849         (add_separate_debug_objfile): Likewise.
13850         (free_all_objfiles): Use all_objfiles_safe.
13851         (objfile_purge_solibs): Likewise.
13852
13853 2019-01-09  Tom Tromey  <tom@tromey.com>
13854
13855         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13856         (expand_symtab_containing_pc, lookup_static_symbol)
13857         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13858         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13859         all_objfiles.
13860         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13861         * breakpoint.c (create_overlay_event_breakpoint)
13862         (create_longjmp_master_breakpoint)
13863         (create_std_terminate_master_breakpoint)
13864         (create_exception_master_breakpoint): Use all_objfiles.
13865         * linux-thread-db.c (try_thread_db_load_from_pdir)
13866         (has_libpthread): Use all_objfiles.
13867         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13868         * linespec.c (iterate_over_all_matching_symtabs)
13869         (search_minsyms_for_name): Use all_objfiles.
13870         * maint.c (maintenance_info_sections): Use all_objfiles.
13871         * main.c (captured_main_1): Use all_objfiles.
13872         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13873         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13874         * guile/scm-pretty-print.c
13875         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13876         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13877         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13878         (maintenance_print_msymbols): Use all_objfiles.
13879         * source.c (select_source_symtab): Use all_objfiles.
13880         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13881         * symfile.c (remove_symbol_file_command)
13882         (expand_symtabs_matching, map_symbol_filenames): Use
13883         all_objfiles.
13884         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13885         all_objfiles.
13886         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13887         * objc-lang.c (find_methods): Use all_objfiles.
13888         * objfiles.c (have_partial_symbols, have_full_symbols)
13889         (have_minimal_symbols, qsort_cmp)
13890         (default_iterate_over_objfiles_in_search_order): Use
13891         all_objfiles.
13892         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13893         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13894         (maintenance_check_psymtabs): Use all_objfiles.
13895         (ALL_PSYMTABS): Remove.
13896         * compile/compile-object-run.c (do_module_cleanup): Use
13897         all_objfiles.
13898         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13899         * cp-support.c (add_symbol_overload_list_qualified): Use
13900         all_objfiles.
13901         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13902         Use all_objfiles.
13903         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13904         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13905         all_objfiles.
13906         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13907         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13908         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13909         Uses all_objfiles.
13910         * solib.c (solib_read_symbols): Use all_objfiles
13911
13912 2019-01-09  Tom Tromey  <tom@tromey.com>
13913
13914         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13915         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13916         all_objfiles.
13917         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13918         * symmisc.c (print_symbol_bcache_statistics)
13919         (print_objfile_statistics, maintenance_print_objfiles)
13920         (maintenance_info_symtabs, maintenance_check_symtabs)
13921         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13922         all_objfiles.
13923         * source.c (forget_cached_source_info): Use all_objfiles.
13924         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13925         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13926         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13927         * objfiles.c (update_section_map): Use all_objfiles.
13928         (shared_objfile_contains_address_p): Likewise.
13929         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13930         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13931
13932 2019-01-09  Tom Tromey  <tom@tromey.com>
13933
13934         * common/next-iterator.h: New file.
13935         * objfiles.h (class all_objfiles): New.
13936         (struct objfile_iterator): New.
13937
13938 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13939
13940         * NEWS: Move the description of the changed "frame", "select-frame",
13941          and "info frame" commands to the Changed commands section.
13942
13943 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13944
13945         * gdbtypes.c (check_stub_method_group): Remove handling of old
13946         mangling schemes.
13947         * linespec.c (find_methods): Likewise.
13948         * stabsread.c (read_member_functions): Likewise.
13949         * valops.c (search_struct_method): Likewise.
13950         (value_struct_elt_for_reference): Likewise.
13951         * NEWS: Mention this change.
13952
13953 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13954
13955         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13956         print_source_lines.
13957         * source.c (print_source_lines_base): Update line number check.
13958         (print_source_lines): New function.
13959         (source_lines_range::source_lines_range): New function.
13960         * source.h (class source_lines_range): New class.
13961         (print_source_lines): New declaration.
13962
13963 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13964
13965         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13966
13967 2019-01-08  Tom Tromey  <tom@tromey.com>
13968             Simon Marchi  <simon.marchi@ericsson.com>
13969
13970         PR gdb/24060
13971         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13972         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13973         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13974         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13975         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13976         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13977
13978 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13979
13980         * source.c (select_source_symtab): Move header comment to
13981         declaration in source.h.
13982         (forget_cached_source_info_for_objfile): Likewise.
13983         (forget_cached_source_info): Likewise.
13984         (identify_source_line): Likewise.
13985         * source.h (identify_source_line): Move declaration from symtab.h
13986         and add comment from source.c
13987         (print_source_lines): Likewise.
13988         (forget_cached_source_info_for_objfile): Likewise.
13989         (forget_cached_source_info): Likewise.
13990         (select_source_symtab): Likewise.
13991         (enum print_source_lines_flag): Move definition from symtab.h.
13992         * symtab.h (identify_source_line): Move declaration to source.h.
13993         (print_source_lines): Likewise.
13994         (forget_cached_source_info_for_objfile): Likewise.
13995         (forget_cached_source_info): Likewise.
13996         (select_source_symtab): Likewise.
13997         (enum print_source_lines_flag): Move definition to source.h.
13998         * tui/tui-hooks.c: Add 'source.h' include.
13999
14000 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14001
14002         * source.c (print_source_lines_base): Handle requests to print
14003         reverse line number sequences, and guard against empty lines
14004         string.
14005
14006 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14007
14008         * source.c (print_source_lines_base): Fix skip of '\r' if next
14009         character is '\n'.
14010
14011 2019-01-06  Tom Tromey  <tom@tromey.com>
14012
14013         * c-exp.y (struct c_parse_state) <macro_original_text,
14014         expansion_obstack>: New member.
14015         (macro_original_text, expansion_obstack): Remove globals.
14016         (scan_macro_expansion, scanning_macro_expansion)
14017         (finished_macro_expansion): Update.
14018         (scan_macro_cleanup): Remove.
14019         (yylex, c_parse): Update.
14020
14021 2019-01-06  Tom Tromey  <tom@tromey.com>
14022
14023         * c-exp.y (struct c_parse_state) <strings>: New member.
14024         (operator_stoken): Update.
14025
14026 2019-01-06  Tom Tromey  <tom@tromey.com>
14027
14028         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14029         (union type_stack_elt) <typelist_val>: Now a pointer to
14030         std::vector.
14031         (type_stack_cleanup): Don't declare.
14032         (push_typelist): Update.
14033         * parse.c (pop_typelist): Return a std::vector.
14034         (push_typelist): Take a std::vector.
14035         (follow_types): Update.  Do not free args.
14036         (type_stack_cleanup): Remove.
14037         * c-exp.y (struct c_parse_state): New.
14038         (cpstate): New global.
14039         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14040         (nonempty_typelist): Update.
14041         (func_mod): Create a new vector.
14042         (c_parse): Create a c_parse_state.
14043         (check_parameter_typelist): Do not delete params.
14044         (function_method): Update.  Do not delete type_list.
14045
14046 2019-01-06  Tom Tromey  <tom@tromey.com>
14047
14048         PR gdb/28155:
14049         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14050         check_typedef.
14051         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14052         (print_return_value): Likewise.
14053
14054 2019-01-05  Tom Tromey  <tom@tromey.com>
14055
14056         * contrib/cleanup_check.py: Remove.
14057         * contrib/gcc-with-excheck: Remove.
14058         * contrib/exsummary.py: Remove.
14059         * contrib/excheck.py: Remove.
14060
14061 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14062
14063         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14064         NULL. Initialize tpprev to NULL instead of assigning it
14065         to NULL on the next statement.
14066         * windows-nat.c (windows_delete_thread): Remove check for
14067         main_thread_id before printing thread exit notifications.
14068         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14069         Remove thread ID check against main_thread_id.
14070         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14071         windows_delete_thread.
14072         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14073
14074 2019-01-04  Tom Tromey  <tom@tromey.com>
14075
14076         * compile/compile.c (_initialize_compile): Use upper case for
14077         metasyntactic variables.
14078         * symmisc.c (_initialize_symmisc): Use upper case for
14079         metasyntactic variables.
14080         * psymtab.c (_initialize_psymtab): Use upper case for
14081         metasyntactic variables.
14082         * demangle.c (demangle_command): Use upper case for metasyntactic
14083         variables.
14084         (_initialize_demangler): Likewise.
14085         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14086         variables.
14087
14088 2019-01-03  Tom Tromey  <tom@tromey.com>
14089
14090         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14091
14092 2019-01-03  Tom Tromey  <tom@tromey.com>
14093
14094         * python/py-symtab.c (salpy_str): Update.
14095         (struct salpy_sal_object) <symtab>: Now a PyObject.
14096         (salpy_dealloc): Update.
14097         (del_objfile_sal): Use gdbpy_ref.
14098
14099 2019-01-03  Tom Tromey  <tom@tromey.com>
14100
14101         * python/py-type.c (convert_field): Use new_reference.  Return
14102         gdbpy_ref.
14103         (make_fielditem): Return gdbpy_ref.
14104         (typy_fields): Update.
14105         (typy_getitem): Update.
14106         (field_name): Return gdbpy_ref.  Use new_reference.
14107         (typy_iterator_iternext): Update.
14108
14109 2019-01-03  Tom Tromey  <tom@tromey.com>
14110
14111         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14112
14113 2019-01-03  Tom Tromey  <tom@tromey.com>
14114
14115         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14116         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14117         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14118         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14119         (pspy_set_type_printers): Likewise.
14120         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14121         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14122         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14123         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14124         (objfpy_set_type_printers): Likewise.
14125
14126 2019-01-03  Tom Tromey  <tom@tromey.com>
14127
14128         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14129         (gdbpy_print_stack): Use gdbpy_err_fetch.
14130         * python/python-internal.h (class gdbpy_err_fetch): New class.
14131         (class gdbpy_enter) <m_error_type, m_error_value,
14132         m_error_traceback>: Remove.
14133         <m_error>: New member.
14134         (gdbpy_exception_to_string): Don't declare.
14135         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14136         * python/py-value.c (convert_value_from_python): Use
14137         gdbpy_err_fetch.
14138         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14139         gdbpy_exception_to_string.
14140         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14141         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14142         gdbpy_err_fetch.
14143
14144 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14145
14146         * linux-nat.c (delete_lwp_cleanup): Delete.
14147         (struct lwp_deleter): New struct.
14148         (lwp_info_up): New typedef.
14149         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14150         lwp_info_up.
14151
14152 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14153
14154         * linux-fork.c (class scoped_switch_fork_info): New class.
14155         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14156
14157 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14158
14159         * valops.c (find_overload_match): Remove use of null_cleanup, and
14160         calls to do_cleanups.
14161
14162 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14163
14164         * compile/compile-cplus-types.c
14165         (compile_cplus_instance::decl_name): Handle changes to
14166         cp_func_name.
14167         * cp-support.c (cp_func_name): Update header comment, update
14168         return type.
14169         * cp-support.h (cp_func_name): Update return type in declaration.
14170         * valops.c (find_overload_match): Move temp_func local to top
14171         level of function and change its type.  Use temp_func to hold and
14172         delete temporary string obtained from cp_func_name.
14173
14174 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14175
14176         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14177         gdb::char_vector, remove cleanup, and update uses of `msg`.
14178
14179 2019-01-03  Jim Wilson  <jimw@sifive.com>
14180
14181         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14182
14183 2019-01-02  Tom Tromey  <tom@tromey.com>
14184
14185         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14186         (tdesc_parse_xml): Remove cleanups.
14187         * target-descriptions.h (make_cleanup_free_target_description):
14188         Don't declare.
14189         (target_desc_deleter): New struct.
14190         (target_desc_up): New typedef.
14191         * target-descriptions.c (target_desc_deleter::operator()): Rename
14192         from free_target_description.
14193         (make_cleanup_free_target_description): Remove.
14194
14195 2019-01-02  Tom Tromey  <tom@tromey.com>
14196
14197         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14198         constructor, destructor.
14199         (linespec_parser): Remove typedef.
14200         (~linespec_parser): Rename from linespec_parser_delete.
14201         (linespec_lex_to_end, linespec_complete_label)
14202         (linespec_complete): Update.
14203         (decode_line_full): Remove cleanups.
14204         (decode_line_1): Update.
14205
14206 2019-01-02  Tom Tromey  <tom@tromey.com>
14207
14208         * python/python-internal.h (inferior_to_inferior_object): Change
14209         return type.
14210         * python/py-exitedevent.c (create_exited_event_object): Update.
14211         * python/py-inferior.c (inferior_to_inferior_object): Return
14212         gdbpy_ref.
14213         (python_new_inferior, python_inferior_deleted)
14214         (thread_to_thread_object, delete_thread_object)
14215         (build_inferior_list, gdbpy_selected_inferior): Update.
14216         * python/py-infthread.c (create_thread_object): Update.  Also fail
14217         if inferior_to_inferior_object fails.
14218
14219 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14220
14221         * inferior.h (class inferior) <displaced_step_state>: New field.
14222         * infrun.h (struct displaced_step_state): Move here from
14223         infrun.c.  Initialize fields, add constructor.
14224         <inf>: Remove field.
14225         <reset>: New method.
14226         * infrun.c (struct displaced_step_inferior_state): Move to
14227         infrun.h.
14228         (displaced_step_inferior_states): Remove.
14229         (get_displaced_stepping_state): Adust.
14230         (displaced_step_in_progress_any_inferior): Adjust.
14231         (displaced_step_in_progress_thread): Adjust.
14232         (displaced_step_in_progress): Adjust.
14233         (add_displaced_stepping_state): Remove.
14234         (get_displaced_step_closure_by_addr): Adjust.
14235         (remove_displaced_stepping_state): Remove.
14236         (infrun_inferior_exit): Call displaced_step_state.reset.
14237         (use_displaced_stepping): Don't check for NULL.
14238         (displaced_step_prepare_throw): Call
14239         get_displaced_stepping_state.
14240         (displaced_step_fixup): Don't check for NULL.
14241         (prepare_for_detach): Don't check for NULL.
14242
14243 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14244
14245         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14246          in case of call that did not complete.
14247
14248 2019-01-02  Andrey Utkin  <autkin@undo.io>
14249
14250         * symfile.c (find_separate_debug_file): Fix search of debug files for
14251         remote debuggee.
14252
14253 2019-01-02  Tom Tromey  <tom@tromey.com>
14254
14255         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14256         indentation.
14257         * python/py-frame.c (frapy_older): Remove cast.
14258         (frapy_newer): Likewise.
14259         * python/py-breakpoint.c (local_setattro): Remove cast.
14260         * python/py-arch.c (archpy_name): Remove local variable.
14261         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14262
14263 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14264
14265         * unittests/basic_string_view/element_access/char/empty.cc:
14266         Fix year range in copyright header.
14267
14268 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14269
14270         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14271         Delete.
14272         <operator==>: Update with for removed field.
14273         <hash>: Likewise.
14274         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14275         <isa_features>: ...this.
14276         <abi_features>: New field.
14277         (riscv_isa_flen): Update comment.
14278         (riscv_abi_xlen): New declaration.
14279         (riscv_abi_flen): New declaration.
14280         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14281         isa_features.
14282         (riscv_abi_xlen): New function.
14283         (riscv_isa_flen): Update to get answer from isa_features.
14284         (riscv_abi_flen): New function.
14285         (riscv_has_fp_abi): Update to get answer from abi_features.
14286         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14287         xlen and flen.
14288         (riscv_call_info) <xlen, flen>: Update comment.
14289         (riscv_call_arg_struct): Remove invalid assertions
14290         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14291         is removed.
14292         (riscv_gdbarch_init): Gather isa features and abi features
14293         separately, ensure both match on the gdbarch when reusing an old
14294         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14295         a target with 64-bit float hardware.
14296
14297 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14298
14299         * source.c (search_command_helper): Stop reverse search
14300         when line 1 has been searched.
14301
14302 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14303
14304         * record-full.c (record_full_base_target::close): Rewrite
14305         record_full_core_buf_list free logic.
14306
14307 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14308
14309         * break-catch-syscall.c (print_one_catch_syscall): xfree
14310         the last text.
14311
14312 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14313
14314         * top.c (print_gdb_version): Update Copyright year in version
14315         message.
14316
14317 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14318
14319         Update copyright year range in all GDB files.
14320
14321 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14322
14323         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14324
14325 For older changes see ChangeLog-2018.
14326 \f
14327 Local Variables:
14328 mode: change-log
14329 left-margin: 8
14330 fill-column: 74
14331 version-control: never
14332 coding: utf-8
14333 End:
14334