gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.h (tui_update_source_window_as_is)
   4         (tui_alloc_source_buffer, tui_line_is_displayed)
   5         (tui_addr_is_displayed): Change type of win_info.
   6         * tui/tui-winsource.c (tui_update_source_window_as_is)
   7         (tui_clear_source_content, tui_show_source_line)
   8         (tui_show_source_content, tui_source_window_base::refill)
   9         (tui_source_window_base::set_is_exec_point_at)
  10         (tui_source_window_base::set_is_exec_point_at)
  11         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
  12         (tui_alloc_source_buffer, tui_line_is_displayed)
  13         (tui_addr_is_displayed): Change type of win_info.  Update.
  14         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
  15         (tui_source_window_base::do_make_visible_with_new_height):
  16         Update.
  17         * tui/tui-source.c (tui_set_source_content)
  18         (tui_set_source_content_nil)
  19         (tui_source_window::do_scroll_vertical): Update.
  20         * tui/tui-layout.c (show_layout): Update.
  21         * tui/tui-disasm.c (tui_set_disassem_content)
  22         (tui_disasm_window::do_scroll_vertical): Update.
  23         * tui/tui-data.h (tui_win_content): Remove.
  24         (struct tui_gen_win_info) <content, content_size>: Remove.
  25         (struct tui_source_element): Add initializers and destructor.
  26         (union tui_which_element, struct tui_win_element): Remove.
  27         (struct tui_source_window_base) <content>: New field.
  28         (struct tui_data_window): Remove destructor.
  29         (tui_alloc_content, tui_free_win_content)
  30         (tui_free_all_source_wins_content): Don't declare.
  31         * tui/tui-data.c (tui_initialize_static_data): Update.
  32         (init_content_element, tui_alloc_content): Remove.
  33         (~tui_gen_win_info): Update.
  34         (~tui_data_window, tui_free_all_source_wins_content)
  35         (tui_free_win_content, free_content, free_content_elements):
  36         Remove.
  37
  38 2019-06-25  Tom Tromey  <tom@tromey.com>
  39
  40         * tui/tui-winsource.h (tui_clear_source_content)
  41         (tui_erase_source_content, tui_show_source_content): Change type
  42         of win_info.
  43         * tui/tui-winsource.c (tui_clear_source_content)
  44         (tui_erase_source_content, tui_show_source_content): Change type
  45         of win_info.
  46         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
  47         * tui/tui-source.h (tui_set_source_content_nil): Change type of
  48         win_info.
  49         * tui/tui-source.c (tui_set_source_content_nil): Change type of
  50         win_info.
  51         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
  52
  53 2019-06-25  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui-winsource.c (tui_clear_source_content)
  56         (tui_source_window_base::set_is_exec_point_at): Update.
  57         * tui/tui-source.c (tui_set_source_content_nil): Update.
  58         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
  59         a bool.
  60         * tui/tui-data.c (init_content_element): Update.
  61
  62 2019-06-25  Tom Tromey  <tom@tromey.com>
  63
  64         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
  65         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
  66         * tui/tui-layout.c (init_and_make_win): Update.
  67         * tui/tui.h (enum tui_win_type): Update.
  68         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
  69         tui_win_is_auxillary.
  70         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
  71         tui_win_is_auxillary.
  72
  73 2019-06-25  Tom Tromey  <tom@tromey.com>
  74
  75         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
  76         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
  77         (tui_delete_data_content_windows, tui_display_all_data)
  78         (tui_data_window::do_scroll_vertical, tui_display_data_from):
  79         Update.
  80         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
  81         * tui/tui-regs.c (tui_last_regs_line_no)
  82         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
  83         (tui_show_registers): Update.
  84         (tui_show_register_group): Return void.  Update.
  85         (tui_display_registers_from, tui_display_reg_element_at_line)
  86         (tui_display_registers_from_line, tui_check_register_values):
  87         Update.
  88         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
  89         member.
  90         (struct tui_data_window) <regs_content>: Now a std::vector.
  91         <regs_content_count>: Remove.
  92         (tui_add_content_elements, tui_free_data_content): Don't declare.
  93         * tui/tui-data.c (tui_data_window::clear_detail): Update.
  94         (init_content_element): Remove DATA_WIN case.  Add assert.
  95         (tui_add_content_elements): Remove.
  96         (tui_data_window): Update.
  97         (tui_free_data_content): Remove.
  98         (free_content_elements): Remove DATA_WIN case.
  99
 100 2019-06-25  Tom Tromey  <tom@tromey.com>
 101
 102         * tui/tui-data.c (tui_data_item_window): Update.
 103         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 104         * tui/tui-windata.c (tui_display_all_data)
 105         (tui_display_data_from_line): Update.
 106         (tui_check_data_values): Remove.
 107         * tui/tui-regs.c (tui_show_register_group)
 108         (tui_display_reg_element_at_line): Update.
 109         * tui/tui-hooks.c (tui_register_changed)
 110         (tui_refresh_frame_and_register_information): Call
 111         tui_check_register_values.
 112         * tui/tui-data.h (struct tui_data_window) <data_content,
 113         data_content_count, data_type>: Remove.
 114         (enum tui_data_type): Remove.
 115
 116         * tui/tui-data.c (tui_data_window::clear_detail)
 117         (~tui_data_window): Update.
 118
 119 2019-06-25  Tom Tromey  <tom@tromey.com>
 120
 121         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 122         declare.
 123         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 124         Rename from tui_first_data_item_displayed.  Update.
 125         (tui_data_window::refresh_all)
 126         (tui_data_window::do_scroll_vertical): Update.
 127         * tui/tui-data.h (struct tui_data_window)
 128         <first_data_item_displayed>: Declare new method.
 129
 130 2019-06-25  Tom Tromey  <tom@tromey.com>
 131
 132         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 133         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 134         contents...
 135         (tui_initialize_static_data): ...here.
 136
 137 2019-06-25  Tom Tromey  <tom@tromey.com>
 138
 139         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 140         (tui_display_registers_from, tui_check_register_values): Update.
 141         (tui_display_register): Remove win_info parameter; update.
 142         (tui_get_register): Change type of parameters.
 143         * tui/tui-data.h (struct tui_data_element): Remove.
 144         (union tui_which_element) <data>: Remove.
 145         <data_window>: Change type.
 146         (struct tui_data_item_window): New.
 147         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 148         case.  Add assert.
 149         (~tui_data_item_window): New destructor.
 150         (free_content_elements): Remove DATA_ITEM_WIN case.
 151
 152 2019-06-25  Tom Tromey  <tom@tromey.com>
 153
 154         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 155         Remove.
 156
 157 2019-06-25  Tom Tromey  <tom@tromey.com>
 158
 159         * tui/tui-data.h (struct tui_command_element): Remove.
 160         (union tui_which_element) <command>: Remove.
 161         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 162         assert.
 163         (free_content_elements): Remove CMD_WIN case.
 164
 165 2019-06-25  Tom Tromey  <tom@tromey.com>
 166
 167         * tui/tui-layout.c (tui_set_layout): Update.
 168         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 169         * tui/tui-data.c (layout_def): Update.
 170
 171 2019-06-25  Tom Tromey  <tom@tromey.com>
 172
 173         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 174         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 175         (tui_source_window_base::set_new_height): Update.
 176         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 177         Update.
 178         (tui_set_locator_fullname, tui_set_locator_info)
 179         (tui_show_frame_info): Update.
 180         * tui/tui-source.c (tui_set_source_content)
 181         (tui_source_is_displayed): Update.
 182         * tui/tui-layout.c (show_source_disasm_command, show_data)
 183         (show_source_or_disasm_and_command): Update.
 184         * tui/tui-disasm.c (tui_set_disassem_content)
 185         (tui_get_begin_asm_address): Update.
 186         * tui/tui-data.h (struct tui_locator_element): Remove.
 187         (union tui_which_element) <locator>: Remove.
 188         (struct tui_locator_window): New.
 189         (tui_locator_win_info_ptr): Change return type.
 190         * tui/tui-data.c (_locator): Change type.
 191         (tui_locator_win_info_ptr): Change return type.
 192         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 193         (tui_alloc_content): Add assert.
 194
 195 2019-06-25  Tom Tromey  <tom@tromey.com>
 196
 197         * tui/tui-winsource.c
 198         (tui_exec_info_window::maybe_allocate_content): New method.
 199         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 200         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 201         (make_source_or_disasm_window): Add cast.
 202         * tui/tui-data.h (union tui_which_element) <simple_string>:
 203         Remove.
 204         (struct tui_source_info): New.
 205         (struct tui_source_window_base) <execution_info>: Change type.
 206         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 207         case, and add assert.
 208         (tui_alloc_content): Add assert.
 209
 210 2019-06-25  Tom Tromey  <tom@tromey.com>
 211
 212         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 213         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 214         * tui/tui-data.c (tui_alloc_win_info): Remove.
 215
 216 2019-06-25  Tom Tromey  <tom@tromey.com>
 217
 218         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 219         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 220         can_highlight.
 221
 222 2019-06-25  Tom Tromey  <tom@tromey.com>
 223
 224         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 225         make_visible_with_new_height method.
 226         (tui_win_info::make_visible_with_new_height): New method.
 227         (tui_source_window_base::do_make_visible_with_new_height)
 228         (tui_data_window::do_make_visible_with_new_height)
 229         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 230         (make_visible_with_new_height): Remove.
 231         (tui_resize_all, tui_adjust_win_heights): Use
 232         make_visible_with_new_height method.
 233         * tui/tui-data.h (struct tui_win_info)
 234         <do_make_visible_with_new_height, make_visible_with_new_height>:
 235         New methods.
 236         (struct tui_source_window_base, struct tui_data_window)
 237         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 238         methods.
 239
 240 2019-06-25  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 243         method.
 244         (update_tab_width): Call update_tab_width method.
 245         * tui/tui-data.h (struct tui_win_info)
 246         (struct tui_source_window_base) <update_tab_width>: New methods.
 247
 248 2019-06-25  Tom Tromey  <tom@tromey.com>
 249
 250         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 251         parameter.
 252         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 253         parameter.
 254         (tui_gen_win_info::make_visible): Update.
 255         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 256         parameter.
 257         * tui/tui-data.h (enum tui_box): New enum.
 258         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 259
 260 2019-06-25  Tom Tromey  <tom@tromey.com>
 261
 262         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 263         init_and_make_win for EXEC_INFO_WIN.
 264         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 265         longer inline.
 266         (struct tui_win_info) <~tui_win_info>: Inline.
 267         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 268         Don't declare.
 269         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 270         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 271         Remove.
 272         (tui_initialize_static_data): Update.
 273         (~tui_gen_win_info): Handle more cleanup here.
 274         (~tui_source_window_base): Delete "execution_info".
 275         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 276
 277 2019-06-25  Tom Tromey  <tom@tromey.com>
 278
 279         * tui/tui-layout.c (make_command_window): Don't set
 280         can_highlight.
 281         (show_source_disasm_command): Call the reset method.
 282         (show_data): Don't set can_highlight.  Call the reset method.
 283         (tui_gen_win_info::reset): Rename from init_gen_win_info
 284         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 285         (show_source_or_disasm_and_command): Call the reset method.
 286         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 287         (struct tui_cmd_window): Set can_highlight.
 288
 289 2019-06-25  Tom Tromey  <tom@tromey.com>
 290
 291         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 292         from make_visible.
 293         (tui_make_visible, tui_make_invisible): Rewrite.
 294         (tui_win_info::make_visible): Remove.
 295         (tui_source_window_base::make_visible): Update.
 296         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 297         method.  Moved from...
 298         (struct tui_win_info) <make_visible>: ...here.
 299
 300 2019-06-25  Tom Tromey  <tom@tromey.com>
 301
 302         * tui/tui-winsource.c
 303         (tui_source_window_base::do_scroll_horizontal): Remove direction
 304         parameter.
 305         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 306         direction parameter.
 307         * tui/tui-win.c (tui_win_info::forward_scroll)
 308         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 309         (tui_win_info::right_scroll): Update.
 310         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 311         direction parameter.
 312         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 313         direction parameter.
 314         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 315         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 316         Remove direction parameter.
 317         (struct tui_source_window_base, struct tui_source_window)
 318         (struct tui_disasm_window, struct tui_data_window)
 319         (struct tui_cmd_window): Update.
 320
 321 2019-06-25  Tom Tromey  <tom@tromey.com>
 322
 323         * tui/tui-winsource.h (tui_set_exec_info_content)
 324         (tui_show_exec_info_content, tui_erase_exec_info_content)
 325         (tui_clear_exec_info_content, tui_update_exec_info): Change
 326         argument to tui_source_window_base.
 327         * tui/tui-winsource.c (tui_set_exec_info_content)
 328         (tui_show_exec_info_content, tui_erase_exec_info_content)
 329         (tui_clear_exec_info_content, tui_update_exec_info): Change
 330         argument to tui_source_window_base.
 331
 332 2019-06-25  Tom Tromey  <tom@tromey.com>
 333
 334         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 335         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 336
 337 2019-06-25  Tom Tromey  <tom@tromey.com>
 338
 339         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 340         check.
 341
 342 2019-06-25  Tom Tromey  <tom@tromey.com>
 343
 344         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 345         type to void.
 346         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 347         type to void.
 348         * tui/tui-source.c (tui_set_source_content): Update.
 349         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 350
 351 2019-06-25  Tom Tromey  <tom@tromey.com>
 352
 353         * tui/tui-win.c (window_name_completer, tui_set_focus)
 354         (tui_all_windows_info): Use name method.
 355         * tui/tui-data.h (struct tui_gen_win_info)
 356         (struct tui_source_window, struct tui_disasm_window)
 357         (struct tui_data_window, struct tui_cmd_window) <name>: New
 358         method.
 359         (tui_win_name): Don't declare.
 360         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 361         (tui_win_name): Remove.
 362
 363 2019-06-25  Tom Tromey  <tom@tromey.com>
 364
 365         * tui/tui-winsource.h (tui_update_source_window)
 366         (tui_update_source_window_as_is): Change parameter type.
 367         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 368         to be a tui_source_window_base.
 369         (tui_update_source_window_as_is): Likewise.
 370         * tui/tui-win.c (make_visible_with_new_height): Update.
 371
 372 2019-06-25  Tom Tromey  <tom@tromey.com>
 373
 374         * tui/tui-winsource.c (tui_erase_source_content)
 375         (tui_show_source_content, tui_show_exec_info_content)
 376         (tui_erase_exec_info_content): Use refresh_window method.
 377         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 378         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 379         from tui_refresh_win.
 380         (tui_data_window::refresh_window): New method.
 381         (tui_win_info::refresh, tui_source_window_base::refresh)
 382         (tui_refresh_all): Use refresh_window method.
 383         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 384         method.
 385         * tui/tui-regs.c (tui_display_register): Call refresh_window
 386         method.
 387         * tui/tui-layout.c (show_source_disasm_command)
 388         (show_source_or_disasm_and_command): Call refresh_window method.
 389         * tui/tui-data.h (struct tui_gen_win_info)
 390         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 391         New method.
 392
 393 2019-06-25  Tom Tromey  <tom@tromey.com>
 394
 395         * tui/tui.c (tui_rl_other_window, tui_enable)
 396         (tui_is_window_visible, tui_get_command_dimension): Update.
 397         * tui/tui-winsource.c (tui_update_source_window_as_is)
 398         (tui_clear_source_content, tui_erase_source_content)
 399         (tui_show_source_line, tui_source_window_base::refill)
 400         (tui_source_window_base::do_scroll_horizontal)
 401         (tui_source_window_base::set_is_exec_point_at)
 402         (tui_update_breakpoint_info, tui_set_exec_info_content)
 403         (tui_alloc_source_buffer, tui_line_is_displayed)
 404         (tui_addr_is_displayed): Update.
 405         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 406         (tui_check_and_display_highlight_if_needed)
 407         (tui_win_info::make_visible, tui_win_info::refresh)
 408         (tui_refresh_all): Update.
 409         * tui/tui-windata.c (tui_first_data_item_displayed)
 410         (tui_delete_data_content_windows, tui_erase_data_content)
 411         (tui_display_all_data, tui_data_window::refresh_all)
 412         (tui_check_data_values): Update.
 413         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 414         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 415         (tui_win_info::backward_scroll, tui_refresh_all_win)
 416         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 417         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 418         (tui_source_window_base::set_new_height)
 419         (tui_data_window::set_new_height)
 420         (make_invisible_and_set_new_height)
 421         (make_visible_with_new_height, new_height_ok)
 422         (parse_scrolling_args): Update.
 423         * tui/tui-stack.c (tui_show_frame_info): Update.
 424         * tui/tui-source.c (tui_set_source_content)
 425         (tui_set_source_content_nil, tui_source_is_displayed)
 426         (tui_source_window::do_scroll_vertical): Update.
 427         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 428         (tui_display_registers_from, tui_display_reg_element_at_line)
 429         (tui_check_register_values, tui_reg_command): Update.
 430         * tui/tui-layout.c (tui_default_win_height)
 431         (show_source_disasm_command, show_data, init_and_make_win)
 432         (show_source_or_disasm_and_command): Update.
 433         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 434         (tui_redisplay_readline, tui_mld_flush)
 435         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 436         (tui_getc): Update.
 437         * tui/tui-disasm.c (tui_set_disassem_content)
 438         (tui_disasm_window::do_scroll_vertical): Update.
 439         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 440         Now virtual.
 441         (struct tui_win_info): Derive from tui_gen_win_info.
 442         <~tui_win_info>: Mark as override.
 443         <generic>: Remove member.
 444         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 445         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 446         (~tui_data_window, ~tui_win_info)
 447         (tui_free_all_source_wins_content): Update.
 448         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 449
 450 2019-06-25  Tom Tromey  <tom@tromey.com>
 451
 452         * tui/tui-layout.c (init_and_make_win): Use new.
 453         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 454         destructor, initializers.
 455         (tui_alloc_generic_win_info): Don't declare.
 456         * tui/tui-data.c (_locator): Add argument to constructor.
 457         (source_win, disasm_win): New globals.
 458         (exec_info): Remove.
 459         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 460         Update.
 461         (tui_alloc_generic_win_info): Remove.
 462         (init_content_element): Use new.
 463         (tui_win_info::tui_win_info): Update.
 464         (free_content_elements) <case DATA_WIN>: Use delete.
 465
 466 2019-06-25  Tom Tromey  <tom@tromey.com>
 467
 468         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 469         * tui/tui-windata.c (tui_first_data_item_displayed)
 470         (tui_delete_data_content_windows): Update.
 471         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 472         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 473         (tui_display_registers_from, tui_check_register_values): Update.
 474         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 475         pointer.
 476         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 477         window.
 478         (tui_free_data_content): Update.
 479         (free_content_elements) <case DATA_WIN>: Free the window.
 480
 481 2019-06-25  Tom Tromey  <tom@tromey.com>
 482
 483         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 484         Update.
 485         * tui/tui-layout.c (make_command_window)
 486         (show_source_disasm_command, show_data, init_and_make_win)
 487         (show_source_or_disasm_and_command): Update.
 488         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 489         method.
 490         <can_highight, is_highlighted>: Now bool.
 491         (tui_set_win_highlight): Don't declare.
 492         * tui/tui-data.c (tui_set_win_highlight): Remove.
 493
 494 2019-06-25  Tom Tromey  <tom@tromey.com>
 495
 496         * tui/tui-wingeneral.c (make_visible): Remove check of window
 497         type.
 498
 499 2019-06-25  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui-win.c (tui_win_info::max_height)
 502         (tui_cmd_window::max_height): New methods.
 503         (new_height_ok): Call max_height.
 504         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 505         <max_height>: New method.
 506
 507 2019-06-25  Tom Tromey  <tom@tromey.com>
 508
 509         * tui/tui-win.c (tui_source_window_base::set_new_height)
 510         (tui_data_window::set_new_height): New methods.
 511         (make_invisible_and_set_new_height): Call set_new_height method.
 512         * tui/tui-data.h (struct tui_win_info)
 513         (struct tui_source_window_base, struct tui_data_window)
 514         <set_new_height>: New method.
 515
 516 2019-06-25  Tom Tromey  <tom@tromey.com>
 517
 518         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 519         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 520         tui_refresh_data_win.
 521         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 522         method.
 523         (tui_refresh_all_win): Call the refresh_all method.
 524         (tui_set_focus): Likewise.
 525         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 526         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 527         Likewise.
 528
 529 2019-06-25  Tom Tromey  <tom@tromey.com>
 530
 531         * tui/tui-winsource.h (tui_refill_source_window)
 532         (tui_set_is_exec_point_at): Don't declare.
 533         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 534         (tui_source_window_base::refill): Rename from
 535         tui_refill_source_window.
 536         (tui_source_window_base::do_scroll_horizontal): Update.
 537         (tui_source_window_base::set_is_exec_point_at): Rename from
 538         tui_set_is_exec_point_at.
 539         (tui_update_all_breakpoint_info): Update.
 540         * tui/tui-stack.c (tui_show_frame_info): Update.
 541         * tui/tui-layout.c (show_data): Add cast.
 542         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 543         * tui/tui-data.h (struct tui_source_window_base) <refill,
 544         set_is_exec_point_at>: New methods.
 545         (tui_source_windows, tui_add_to_source_windows): Update types.
 546         (tui_add_to_source_windows): Remove redundant declaration.
 547         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 548         (tui_source_windows): Change return type.
 549         (tui_clear_source_windows_detail): Update.
 550         (tui_add_to_source_windows): Change type of parameter.
 551         (tui_free_all_source_wins_content): Update.
 552
 553 2019-06-25  Tom Tromey  <tom@tromey.com>
 554
 555         * tui/tui-wingeneral.c (tui_win_info::refresh)
 556         (tui_source_window_base::refresh): New methods.
 557         (tui_refresh_all): Call the refresh method.
 558         * tui/tui-data.h (struct tui_win_info)
 559         (struct tui_source_window_base) <refresh>: New method.
 560
 561 2019-06-25  Tom Tromey  <tom@tromey.com>
 562
 563         * tui/tui.h (tui_is_window_visible): Return bool.
 564         * tui/tui.c (tui_is_window_visible): Return bool.
 565         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 566         (tui_make_visible, tui_make_invisible)
 567         (tui_win_info::make_visible)
 568         (tui_source_window_base::make_visible, make_all_visible)
 569         (tui_make_all_visible, tui_make_all_invisible): Update.
 570         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 571         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 572         bool.
 573         (struct tui_win_info, struct tui_source_window_base)
 574         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 575         * tui/tui-data.c (tui_init_generic_part): Update.
 576
 577 2019-06-25  Tom Tromey  <tom@tromey.com>
 578
 579         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 580         (tui_source_window_base::make_visible): New methods.
 581         (make_all_visible): Make method call.
 582         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 583         (struct tui_source_window_base, struct tui_cmd_window): Override
 584         make_visible.
 585         (tui_win_is_source_type): Don't declare.
 586         * tui/tui-data.c (tui_win_is_source_type): Remove.
 587
 588 2019-06-25  Tom Tromey  <tom@tromey.com>
 589
 590         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 591         NULL check.
 592
 593 2019-06-25  Tom Tromey  <tom@tromey.com>
 594
 595         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 596         Inline constructor.  Add initializers for members.
 597         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 598         constructors; now inline in class.
 599
 600 2019-06-25  Tom Tromey  <tom@tromey.com>
 601
 602         * tui/tui-regs.c (tui_show_registers): Update.
 603         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 604         bool.
 605         * tui/tui-data.c (tui_data_window::clear_detail)
 606         (tui_data_window): Update.
 607
 608 2019-06-25  Tom Tromey  <tom@tromey.com>
 609
 610         * tui/tui-windata.c (tui_display_all_data)
 611         (tui_display_data_from_line, tui_display_data_from)
 612         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 613         Update.
 614         * tui/tui-regs.c (tui_last_regs_line_no)
 615         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 616         (tui_show_registers, tui_show_register_group)
 617         (tui_display_registers_from, tui_display_reg_element_at_line)
 618         (tui_display_registers_from_line, tui_check_register_values)
 619         (tui_reg_next, tui_reg_prev): Update.
 620         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 621         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 622         tui_data_window.
 623         (struct tui_win_info) <detail>: Remove.  Add new fields from
 624         tui_data_info.
 625         (TUI_DATA_WIN): Add cast.
 626         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 627         (~tui_data_window): Simplify.
 628
 629 2019-06-25  Tom Tromey  <tom@tromey.com>
 630
 631         * tui/tui-layout.c (show_source_disasm_command)
 632         (show_source_or_disasm_and_command): Update.
 633         * tui/tui-io.c (update_cmdwin_start_line)
 634         (tui_redisplay_readline): Update.
 635         * tui/tui-data.h (struct tui_command_info): Remove.
 636         (struct tui_win_info) <detail>: Remove command_info member.
 637         (struct tui_data_window) <start_line>: New member, from
 638         tui_command_info.
 639         (TUI_CMD_WIN): Add casts.
 640
 641 2019-06-25  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui-winsource.c (tui_update_source_window)
 644         (tui_refill_source_window)
 645         (tui_source_window_base::do_scroll_horizontal)
 646         (tui_update_breakpoint_info, tui_set_exec_info_content)
 647         (tui_show_exec_info_content, tui_erase_exec_info_content)
 648         (tui_clear_exec_info_content): Update.
 649         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 650         Update.
 651         * tui/tui-win.c (make_invisible_and_set_new_height)
 652         (make_visible_with_new_height): Update.
 653         * tui/tui-source.c (tui_set_source_content)
 654         (tui_show_symtab_source): Update.
 655         * tui/tui-layout.c (extract_display_start_addr)
 656         (show_source_disasm_command, show_data)
 657         (make_source_or_disasm_window)
 658         (show_source_or_disasm_and_command): Update.
 659         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 660         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 661         "gdbarch".
 662         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 663         to tui_source_window_base.
 664         (struct tui_win_info) <detail>: Remove source_info member.
 665         (struct tui_source_window_base) <has_locator>: Inline.
 666         Move contents from tui_source_info; rename has_locator member to
 667         m_has_locator.
 668         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 669         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 670         header file.
 671         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 672         Simplify.
 673         (tui_free_all_source_wins_content): Cast to
 674         tui_source_window_base.
 675
 676 2019-06-25  Tom Tromey  <tom@tromey.com>
 677
 678         * tui/tui-win.c (make_invisible_and_set_new_height)
 679         (make_visible_with_new_height): Call has_locator method.
 680         * tui/tui-layout.c (show_source_disasm_command, show_data)
 681         (show_source_or_disasm_and_command): Update for bool change.
 682         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 683         (tui_win_info) <has_locator>: New method.
 684         (struct tui_source_window_base) <has_locator>: New method.
 685         (tui_win_has_locator): Don't declare.
 686         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 687         from tui_win_has_locator.
 688         (tui_source_window_base): Use false, not FALSE.
 689
 690 2019-06-25  Tom Tromey  <tom@tromey.com>
 691
 692         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 693         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 694         clear_detail method directly.
 695         (tui_clear_win_detail): Remove.
 696
 697 2019-06-25  Tom Tromey  <tom@tromey.com>
 698
 699         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 700         "this", not TUI_DISASM_WIN.
 701
 702 2019-06-25  Tom Tromey  <tom@tromey.com>
 703
 704         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 705         declare.
 706         * tui/tui-winsource.c
 707         (tui_source_window_base::do_scroll_horizontal): Rename from
 708         tui_horizontal_source_scroll.
 709         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 710         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 711         from tui_vertical_data_scroll.
 712         * tui/tui-win.h (tui_scroll): Don't declare.
 713         * tui/tui-win.c (tui_win_info::forward_scroll)
 714         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 715         (tui_win_info::right_scroll): Rename and update.
 716         (tui_scroll_forward_command, tui_scroll_backward_command)
 717         (tui_scroll_left_command, tui_scroll_right_command): Update.
 718         (tui_scroll): Remove.
 719         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 720         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 721         from tui_vertical_source_scroll.
 722         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 723         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 724         from tui_vertical_disassem_scroll.
 725         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 726         do_scroll_horizontal>: New methods.
 727         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 728         Likewise.
 729         (struct tui_source_window_base): Add do_scroll_horizontal.
 730         (struct tui_source_window, struct tui_disasm_window): Add
 731         do_scroll_vertical.
 732         (struct tui_data_window, struct tui_cmd_window): Add
 733         do_scroll_horizontal and do_scroll_vertical.
 734         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 735
 736 2019-06-25  Tom Tromey  <tom@tromey.com>
 737
 738         * tui/tui-data.h (struct tui_source_window_base): New struct.
 739         (struct tui_source_window): Derive from tui_source_window_base.
 740         (struct tui_disasm_window): New struct.
 741         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 742         from tui_source_window::clear_detail.
 743         (tui_source_window_base): Rename from tui_source_window.
 744         (~tui_source_window_base): Rename from ~tui_source_window.
 745         (tui_alloc_win_info): Create a tui_disasm_window.
 746
 747 2019-06-25  Tom Tromey  <tom@tromey.com>
 748
 749         * tui/tui-data.h (struct tui_source_window)
 750         (struct tui_data_window): Declare destructors.
 751         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 752         destructors.
 753         (tui_win_info): Simplify.
 754
 755 2019-06-25  Tom Tromey  <tom@tromey.com>
 756
 757         * tui/tui-winsource.c (tui_display_main)
 758         (tui_update_source_windows_with_addr)
 759         (tui_update_all_breakpoint_info): Update.
 760         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 761         (new_height_ok, parse_scrolling_args): Update.
 762         * tui/tui-stack.c (tui_show_frame_info): Update.
 763         * tui/tui-data.h (struct tui_list): Remove.
 764         (tui_source_windows): Return a reference to a std::vector.
 765         * tui/tui-data.c (source_windows): Now a std::vector.
 766         (tui_source_windows): Change return type.
 767         (tui_clear_source_windows): Rewrite.
 768         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 769         (tui_free_all_source_wins_content): Rewrite.
 770
 771 2019-06-25  Tom Tromey  <tom@tromey.com>
 772
 773         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 774         (struct tui_data_window, struct tui_cmd_window): Declare
 775         clear_detail method.
 776         * tui/tui-data.c (tui_source_window::clear_detail)
 777         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 778         methods.
 779         (tui_clear_win_detail): Simplify.
 780
 781 2019-06-25  Tom Tromey  <tom@tromey.com>
 782
 783         * tui/tui-layout.c (make_source_window, make_disasm_window)
 784         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 785         Return the new window.
 786         (show_source_disasm_command, show_data)
 787         (show_source_or_disasm_and_command): Update.
 788
 789 2019-06-25  Tom Tromey  <tom@tromey.com>
 790
 791         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 792         parameter.  Return the new window.
 793         (show_source_disasm_command): Update and remove NULL check.
 794         (show_source_or_disasm_and_command): Update.
 795
 796 2019-06-25  Tom Tromey  <tom@tromey.com>
 797
 798         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 799
 800 2019-06-25  Tom Tromey  <tom@tromey.com>
 801
 802         * tui/tui-data.h (struct tui_win_info): Make constructor
 803         protected.  Make destructor virtual.  Add initializers.
 804         (tui_source_window, tui_data_window, tui_cmd_window): New
 805         classes.
 806         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 807         constructor.  Add "type" parameter.
 808         (tui_source_window, tui_data_window, tui_cmd_window): New
 809         constructors.
 810         (tui_alloc_win_info): Instantiate the appropriate subclass.
 811
 812 2019-06-25  Tom Tromey  <tom@tromey.com>
 813
 814         * tui/tui-win.c (tui_resize_all): Use delete.
 815         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 816         destructor.
 817         (tui_free_window): Don't declare.
 818         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 819         Update.
 820
 821 2019-06-25  Tom Tromey  <tom@tromey.com>
 822
 823         * tui/tui-data.h (struct tui_win_info): Add constructor.
 824         * tui/tui-data.c (tui_alloc_win_info): Use new.
 825         (tui_free_window): Use delete.
 826
 827 2019-06-22  Tom Tromey  <tom@tromey.com>
 828
 829         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 830         declare.
 831         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 832
 833 2019-06-22  Tom Tromey  <tom@tromey.com>
 834
 835         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 836         declare.
 837         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 838
 839 2019-06-22  Tom de Vries  <tdevries@suse.de>
 840
 841         * dwarf2read.c (create_addrmap_from_aranges)
 842         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 843         instead of '%zu'.
 844
 845 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 846
 847         * dwarf2read.h (dwarf2_section_info_def): Remove.
 848         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 849         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 850         std::vector<dwarf2_section_info>.
 851         (struct dwo_file) <~dwo_file>: Remove.
 852         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 853         types field.
 854         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 855         (dwarf2_read_debug_names): Likewise.
 856         (create_debug_types_hash_table): Change parameter type to
 857         array_view, adjust code accordingly.
 858         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 859         (partial_die_info::fixup): Likewise.
 860         (determine_prefix): Likewise.
 861         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 862
 863 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 864
 865         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 866         gdb_bfd_ref_ptr.
 867         <~dwo_file>: Remove call to gdb_bfd_unref.
 868         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 869         gdb_bfd_ref_ptr::get.
 870
 871 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 872
 873         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 874         type to htab_up.
 875         * dwarf2read.c (struct dwo_file): Initialize fields.
 876         <~dwo_file>: New.
 877         (free_dwo_file): Remove, move content to ~dwo_file.
 878         (struct dwo_file_deleter): Remove.
 879         (dwo_file_up>: Remove custom deleter.
 880         (free_dwo_files): Remove.
 881         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 882         dwo_files.
 883         (process_skeletonless_type_units): Call unique_ptr::get.
 884         (allocate_dwo_file_hash_table): Add deleter to created hash
 885         table.  Change return type to htab_up.
 886         (lookup_dwo_file_slot): Don't memset dwo_file, call
 887         unique_ptr::get.
 888         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 889         (create_dwo_unit_in_dwp_v2): Likewise.
 890         (open_and_init_dwo_file): Likewise.
 891         (free_dwo_file_from_slot): Remove.
 892
 893 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 894
 895         * dwarf2read.h (struct dwarf2_section_info) <readin,
 896         is_virtual>: Change type to bool.
 897         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 898         true instead of 1.
 899
 900 2019-06-19  Tom Tromey  <tom@tromey.com>
 901
 902         * tui/tui-data.h (tui_init_content_element): Don't declare.
 903
 904 2019-06-19  Tom Tromey  <tom@tromey.com>
 905
 906         * tui/tui-data.h (tui_init_win_info): Don't declare.
 907
 908 2019-06-19  Tom de Vries  <tdevries@suse.de>
 909
 910         * dwarf2read.h (abstract_to_concrete): Change type to
 911         std::unordered_map<sect_offset, std::vector<sect_offset>,
 912         gdb::hash_enum<sect_offset>>.
 913
 914 2019-06-19  Tom Tromey  <tromey@adacore.com>
 915
 916         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 917         EVAL_AVOID_SIDE_EFFECTS specially.
 918
 919 2019-06-19  Tom Tromey  <tromey@adacore.com>
 920
 921         * source-cache.c (highlighter): New global.
 922         (source_cache::get_source_lines): Create a highlighter on demand.
 923
 924 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 925
 926         * defs.h (deprecated_interactive_hook): Delete declaration.
 927         * interps.c (clear_interpreter_hooks): Remove use of
 928         deprecated_interactive_hook.
 929         * top.c (deprecated_interactive_hook): Delete definition.
 930         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 931
 932 2019-06-18  Tom de Vries  <tdevries@suse.de>
 933
 934         PR gdb/24515
 935         * dwarf2read.h (abstract_to_concrete): Change type from
 936         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 937         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 938         * dwarf2read.c (read_variable): Update.
 939         (dwarf2_fetch_die_loc_sect_off): Update.
 940
 941 2019-06-17  Tom de Vries  <tdevries@suse.de>
 942
 943         PR gdb/24617
 944         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 945         accessing parent[parent_len - 1].
 946
 947 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 948
 949         PR gdb/24364
 950         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 951         call dtrace_process_dof with NULL dof.
 952
 953 2019-06-16  Tom de Vries  <tdevries@suse.de>
 954
 955         PR gdb/24445
 956         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 957
 958 2019-06-16  Tom Tromey  <tom@tromey.com>
 959
 960         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 961         (make_all_visible): Use address of member.
 962
 963 2019-06-16  Tom Tromey  <tom@tromey.com>
 964
 965         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 966         (tui_free_window, free_content, free_content_elements): Remove
 967         unnecessary cast.
 968         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 969         cast.
 970         * tui/tui-regs.c (tui_show_register_group)
 971         (tui_display_registers_from, tui_display_reg_element_at_line):
 972         Remove unnecessary cast.
 973
 974 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 975
 976         * linux-nat.c (normal_mask): Delete.
 977         (_initialize_linux_nat): Don't initialise normal_mask.
 978
 979 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 980
 981         PR gdb/24445
 982         * dwarf-index-write.h (write_psymtabs_to_index): Add
 983         dwz_basename parameter.
 984         * dwarf-index-write.c (write_gdbindex): Move file writing to
 985         write_gdbindex_1.  Change return type void.
 986         (assert_file_size): Move up, remove filename parameter.
 987         (write_gdbindex_1): New function.
 988         (write_debug_names): Change return type to void, call
 989         assert_file_size.
 990         (struct index_wip_file): New struct.
 991         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 992         file logic to index_wip_file.  Write index for dwz file if
 993         needed.
 994         (save_gdb_index_command): Pass basename of dwz file, if present.
 995         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 996         build-id of dwz file, if present.
 997         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 998         (dwarf2_get_dwz_file): Likewise.
 999         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1000         (dwarf2_get_dwz_file): Likewise.
1001
1002 2019-06-16  Tom Tromey  <tom@tromey.com>
1003
1004         * coffread.c (process_coff_symbol): Use xstrdup.
1005         * value.c (create_internalvar): Use xstrdup.
1006
1007 2019-06-16  Tom Tromey  <tom@tromey.com>
1008
1009         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1010         * breakpoint.c (stopin_command, stopat_command)
1011         (until_break_command, decode_location_default): Remove unnecessary
1012         cast.
1013         * utils.c (subset_compare): Remove unnecessary cast.
1014         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1015         cast.
1016         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1017         cast.
1018         * infcmd.c (path_command): Remove unnecessary cast.
1019         * coffread.c (decode_type): Remove unnecessary cast.
1020         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1021         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1022         * tui/tui-stack.c (tui_show_locator_content)
1023         (tui_show_frame_info): Remove unnecessary cast.
1024         * tui/tui-win.c (tui_scroll_forward_command)
1025         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1026         (parse_scrolling_args): Remove unnecessary cast.
1027         * tui/tui-data.c (init_win_info, tui_del_window)
1028         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1029         (free_content_elements): Remove unnecessary cast.
1030         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1031         unnecessary cast.
1032         * tui/tui-source.c (tui_set_source_content)
1033         (tui_vertical_source_scroll): Remove unnecessary cast.
1034         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1035         cast.
1036         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1037         * tui/tui-regs.c (tui_display_registers_from)
1038         (tui_display_register): Remove unnecessary cast.
1039         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1040         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1041         (make_visible): Remove unnecessary cast.
1042         * tui/tui-winsource.c (tui_erase_source_content)
1043         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1044         unnecessary cast.
1045         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1046         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1047         * stabsread.c (read_type, read_array_type, read_range_type):
1048         Remove unnecessary cast.
1049         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1050         (parse_symbol, parse_type, upgrade_type, parse_external)
1051         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1052         unnecessary cast.
1053         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1054
1055 2019-06-16  Tom Tromey  <tom@tromey.com>
1056
1057         * tui/tui-data.c (tui_alloc_generic_win_info)
1058         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1059         checks.
1060
1061 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1062             Andrew Burgess  <andrew.burgess@embecosm.com>
1063
1064         * f-typeprint.c (f_print_type): Don't return early for not
1065         associated or not allocated types.
1066         (f_type_print_varspec_suffix): Add print_rank parameter and print
1067         ranks of array types in case they dangling.
1068         (f_type_print_base): Add print_rank parameter.
1069
1070 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1071
1072         * NEWS: Mention new MI commands.
1073         * break-catch-throw.c (enum exception_event_kind): Move to
1074         breakpoint.h.
1075         (print_mention_exception_catchpoint): Output text as a single
1076         message.
1077         (catch_exception_command_1): Rename to...
1078         (catch_exception_event): ...this, make non-static, update header
1079         command, and change some parameter types.
1080         (catch_catch_command): Update for changes to
1081         catch_exception_command_1.
1082         (catch_throw_command): Likewise.
1083         (catch_rethrow_command): Likewise.
1084         * breakpoint.c (enum exception_event_kind): Delete.
1085         * breakpoint.h (enum exception_event_kind): Moved here from
1086         break-catch-throw.c.
1087         (catch_exception_event): Declare.
1088         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1089         (mi_cmd_catch_throw): New function.
1090         (mi_cmd_catch_rethrow): New function.
1091         (mi_cmd_catch_catch): New function.
1092         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1093         'catch-catch' entries.
1094         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1095         (mi_cmd_catch_rethrow): Declare.
1096         (mi_cmd_catch_catch): Declare.
1097
1098 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1099
1100         * annotate.c (annotate_source_line): Change return type to void,
1101         update implementation to match.
1102         * annotate.h (annotate_source_line): Change return type to void,
1103         update header comment.
1104         * stack.c (print_frame_info): Don't change what frame information
1105         is printed based on whether annotations are on or not.
1106
1107 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1108
1109         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1110         (annotate_source): Make static.
1111         (annotate_source_line): Moved from source.c and renamed from
1112         identify_source_line.  Update the return type.
1113         * annotate.h (annotate_source): Delete declaration.
1114         (annotate_source_line): Declaration moved from source.h, and
1115         renamed from identify_source_line.  Return type updated.
1116         * source.c (identify_source_line): Moved to annotate.c and renamed
1117         to annotate_source_line.
1118         (info_line_command): Remove check of annotation_level.
1119         * source.h (identify_source_line): Move declaration to annotate.h
1120         and rename to annotate_source_line.
1121         * stack.c: Add 'annotate.h' include.
1122         (print_frame_info): Remove check of annotation_level before
1123         calling annotate_source_line.
1124
1125 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1126
1127         * source-cache.c (source_cache::get_plain_source_lines): Use
1128         open_source_file_with_line_charpos instead of just
1129         open_source_file, remove call to find_source_lines.
1130         (source_cache::get_source_lines): Likewise.
1131         * source.c (find_source_lines): Make static.
1132         (get_filename_and_charpos): Renamed into...
1133         (open_source_file_with_line_charpos): ..this along with changes to
1134         return a scoped_fd, and some other minor clean ups.
1135         (identify_source_line): Use open_source_file_with_line_charpos.
1136         (search_command_helper): Use open_source_file_with_line_charpos
1137         instead of just open_source_file, remove call to
1138         find_source_lines.
1139         * source.h (open_source_file_with_line_charpos): Declare new
1140         function.
1141         (find_source_lines): Delete declaration.
1142
1143 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1144
1145         * source.c (get_filename_and_charpos): Remove fullname
1146         parameter.
1147         (identify_source_line): Update call to get_filename_and_charpos.
1148
1149 2019-06-14  Tom Tromey  <tromey@adacore.com>
1150
1151         PR gdb/24502:
1152         * ui-style.h (skip_ansi_escape): Update comment.
1153         * ui-file.h (class no_terminal_escape_file): New class.
1154         * ui-file.c (no_terminal_escape_file::write)
1155         (no_terminal_escape_file::puts): New methods.
1156         * cli/cli-logging.c (handle_redirections): Use
1157         no_terminal_escape_file.
1158
1159 2019-06-14  Tom Tromey  <tromey@adacore.com>
1160
1161         * NEWS: Move convenience variable news above Python news.
1162
1163 2019-06-14  Tom Tromey  <tom@tromey.com>
1164
1165         * gnulib: Move directory to top-level.
1166         * configure.ac: Don't configure gnulib.
1167         * configure: Rebuild.
1168         * common/common-defs.h: Use new path to gnulib.
1169         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1170         (GNULIB_H): Remove.
1171         (INCGNU): Look in new gnulib location.
1172         (HFILES_NO_SRCDIR): Remove gnulib files.
1173         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1174         (generated_files): Remove GNULIB_H.
1175         ($(LIBGNU), all-lib): Remove targets.
1176         (distclean): Don't mention GNULIB_BUILDDIR.
1177         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1178
1179 2019-06-14  Tom Tromey  <tromey@adacore.com>
1180
1181         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1182         Warn if symbol file does not provide any symbols.
1183
1184 2019-06-14  Tom Tromey  <tromey@adacore.com>
1185
1186         * source.c (find_and_open_source): Respect basenames_may_differ.
1187
1188 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1189
1190         * annotate.c (annotate_breakpoints_invalid): Make use of
1191         scoped_restore_terminal_state.
1192         (annotate_frames_invalid): Likewise.
1193
1194 2019-06-14  Tom Tromey  <tromey@adacore.com>
1195
1196         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1197         allow assignment to an internalvar.
1198
1199 2019-06-14  Tom Tromey  <tromey@adacore.com>
1200
1201         * ada-lex.l: Allow "_" in attribute names.
1202
1203 2019-06-14  Tom Tromey  <tromey@adacore.com>
1204
1205         PR gdb/24653:
1206         * regcache.c (registers_changed): Don't call alloca.
1207         * top.c (execute_command): Don't call alloca.
1208
1209 2019-06-13  Pedro Alves  <palves@redhat.com>
1210
1211         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1212         'expression'.  When parsing an expression, error out if there's
1213         junk after "unlimited".
1214         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1215         (do_set_command): Adjust calls to is_unlimited_literal.
1216
1217 2019-06-13  Pedro Alves  <palves@redhat.com>
1218
1219         * compile/compile.c (make_compile_options_def_group): Add braces
1220         around array_view initializer.
1221         * thread.c (make_thread_apply_all_options_def_group)
1222         (make_thread_apply_all_options_def_group): Likewise.
1223
1224 2019-06-13  Pedro Alves  <palves@redhat.com>
1225
1226         * NEWS (New commands): Mention "maint test-options
1227         require-delimiter", "maint test-options unknown-is-error", "maint
1228         test-options unknown-is-operand" and "maint show
1229         test-options-completion-result".
1230         (New command options, command completion): New section.
1231         (Completion improvements): New section.
1232         Mention that you can abbreviate "unlimited".
1233
1234 2019-06-13  Pedro Alves  <palves@redhat.com>
1235
1236         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1237         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1238         * unittests/cli-utils-selftests.c (test_parse_flags)
1239         (test_parse_flags_qcs): Delete.
1240         (test_cli_utils): Don't call deleted functions.
1241
1242 2019-06-13  Pedro Alves  <palves@redhat.com>
1243
1244         * thread.c: Include "cli/cli-option.h".
1245         (tp_array_compar_ascending): Global.
1246         (tp_array_compar): Delete function.
1247         (tp_array_compar_ascending, tp_array_compar_descending): New
1248         functions.
1249         (ascending_option_def, qcs_flag_option_def)
1250         (thr_qcs_flags_option_defs)
1251         (make_thread_apply_all_options_def_group)
1252         (make_thread_apply_options_def_group): New.
1253         (thread_apply_all_command): Use gdb::option::process_options.
1254         (thread_apply_command_completer)
1255         (thread_apply_all_command_completer): New.
1256         (thread_apply_command): Use gdb::option::process_options.
1257         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1258         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1259         to generate help text of "thread apply".  Adjust "taas"'s help.
1260         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1261         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1262
1263 2019-06-13  Pedro Alves  <palves@redhat.com>
1264
1265         * thread.c (thread_apply_command): Check for invalid TID with
1266         isdigit instead of !isalpha.
1267
1268 2019-06-13  Pedro Alves  <palves@redhat.com>
1269
1270         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1271         (validate_flags_qcs): New.
1272         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1273         (validate_flags_qcs): Declare.
1274         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1275         (make_frame_apply_options_def_group): New.
1276         (frame_apply_command_count): Process options with
1277         gdb::option::process_options.
1278         (frame_apply_completer): New.
1279         (frame_apply_level_completer, frame_apply_all_completer)
1280         (frame_apply_completer): New.
1281         (_initialize_stack): Update help of "frame apply", "frame apply
1282         level", "frame apply all" and "faas" to mention supported options
1283         and install command completers.
1284         * stack.h (frame_apply_all_completer): Declare.
1285         * thread.c: Include "stack.h".
1286         (tfaas_command): Add "--".
1287         (_initialize_thread): Update help "tfaas" to mention supported
1288         options and install command completer.
1289
1290 2019-06-13  Pedro Alves  <palves@redhat.com>
1291
1292         * completer.c (complete_nested_command_line): New.
1293         (gdb_completion_word_break_characters_throw): Add assertion.
1294         * completer.h (complete_nested_command_line): Declare.
1295
1296 2019-06-13  Pedro Alves  <palves@redhat.com>
1297
1298         * stack.c (parse_backtrace_qualifiers): New.
1299         (backtrace_command): Use it.
1300         (backtrace_command_completer): Complete on qualifiers.
1301
1302 2019-06-13  Pedro Alves  <palves@redhat.com>
1303
1304         * frame.c: Include "cli/cli-option.h.
1305         (user_set_backtrace_options): New.
1306         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1307         Delete.
1308         (get_prev_frame): Adjust.
1309         (boolean_option_def, uinteger_option_def)
1310         (set_backtrace_option_defs): New.
1311         (_initialize_frame): Adjust and use
1312         gdb::option::add_setshow_cmds_for_options to install "set
1313         backtrace past-main" and "set backtrace past-entry".
1314         * frame.h: Include "cli/cli-option.h".
1315         (struct frame_print_options): Forward declare.
1316         (print_frame_arguments_all, print_frame_arguments_scalars)
1317         (print_frame_arguments_none): Declare.
1318         (print_entry_values): Delete declaration.
1319         (struct frame_print_options, user_frame_print_options): New.
1320         (struct set_backtrace_options): New.
1321         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1322         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1323         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1324         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1325         (list_args_or_locals): Add frame_print_options parameter.
1326         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1327         * python/py-framefilter.c (enumerate_args): Pass down
1328         USER_FRAME_PRINT_OPTIONS.
1329         * stack.c: Include "cli/cli-option.h".
1330         (print_frame_arguments_all, print_frame_arguments_scalars)
1331         (print_frame_arguments_none): Declare.
1332         (print_raw_frame_arguments, print_entry_values): Delete.
1333         (user_frame_print_options): New.
1334         (boolean_option_def, enum_option_def, frame_print_option_defs):
1335         New.
1336         (struct backtrace_cmd_options): New.
1337         (bt_flag_option_def): New.
1338         (backtrace_command_option_defs): New.
1339         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1340         (print_frame_arg, read_frame_arg, print_frame_args)
1341         (print_frame_info, print_frame): Add frame_print_options parameter
1342         and use it.
1343         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1344         (backtrace_command_1): Add frame_print_options and
1345         backtrace_cmd_options parameters and use them.
1346         (make_backtrace_options_def_group): New.
1347         (backtrace_command): Process command options with
1348         gdb::option::process_options.
1349         (backtrace_command_completer): New.
1350         (_initialize_stack): Extend "backtrace"'s help to mention
1351         supported options.  Install completer for "backtrace".
1352         Install some settings commands with add_setshow_cmds_for_options.
1353
1354 2019-06-13  Pedro Alves  <palves@redhat.com>
1355
1356         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1357         and that "set/show print raw frame-arguments" are now deprecated.
1358
1359         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1360         command.
1361         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1362         * stack.c (_initialize_stack): Install "set/show print
1363         raw-frame-arguments", and deprecate "set/show print raw
1364         frame-arguments".
1365         * valprint.c (_initialize_valprint): Deprecate "set/show print
1366         raw".
1367
1368 2019-06-13  Pedro Alves  <palves@redhat.com>
1369
1370         * compile/compile.c (struct compile_options): New.
1371         (compile_flag_option_def, compile_command_option_defs)
1372         (make_compile_options_def_group): New.
1373         (compile_file_command): Handle options with
1374         gdb::option::process_options.
1375         (compile_file_command_completer): New function.
1376         (compile_code_command): Handle options with
1377         gdb::option::process_options.
1378         (compile_code_command_completer): New function.
1379         (_initialize_compiler): Install completers for "compile code" and
1380         "compile file".  Mention available options in "compile code" and
1381         "compile code"'s help.
1382         * completer.c (advance_to_completion_word): New, factored out from
1383         ...
1384         (advance_to_expression_complete_word_point): ... this.
1385         (advance_to_filename_complete_word_point): New.
1386         * completer.h (advance_to_filename_complete_word_point): New
1387         declaration.
1388
1389 2019-06-13  Pedro Alves  <palves@redhat.com>
1390
1391         * compile/compile.c: Include "cli/cli-option.h".
1392         (compile_print_value): Scope data pointer is now a
1393         value_print_options pointer; adjust.
1394         (compile_print_command): Process options.  Scope data pointer is
1395         now a value_print_options pointer; adjust.
1396         (_initialize_compile): Update "compile print"'s help to include
1397         supported options.  Install a completer for "compile print".
1398         * cp-valprint.c (show_vtblprint, show_objectprint)
1399         (show_static_field_print): Delete.
1400         (_initialize_cp_valprint): Don't install "set print
1401         static-members", "set print vtbl", "set print object" here.
1402         * printcmd.c: Include "cli/cli-option.h" and
1403         "common/gdb_optional.h".
1404         (print_command_parse_format): Rework to fill in a
1405         value_print_options instead of a format_data.
1406         (print_value): Change parameter type from format_data pointer to
1407         value_print_options reference.  Adjust.
1408         (print_command_1): Process options.  Adjust to pass down a
1409         value_print_options.
1410         (print_command_completer): New.
1411         (_initialize_printcmd): Install print_command_completer as
1412         handle_brkchars completer for the "print" command.  Update
1413         "print"'s help to include supported options.
1414         * valprint.c: Include "cli/cli-option.h".
1415         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1416         here from cp-valprint.c.
1417         (boolean_option_def, uinteger_option_def)
1418         (value_print_option_defs, make_value_print_options_def_group):
1419         New.  Use gdb::option::add_setshow_cmds_for_options to install
1420         "set print elements", "set print null-stop", "set print repeats",
1421         "set print pretty", "set print union", "set print array", "set
1422         print address", "set print symbol", "set print array-indexes".
1423         * valprint.h: Include <string> and "cli/cli-option.h".
1424         (make_value_print_options_def_group): Declare.
1425         (print_value): Change parameter type from format_data pointer to
1426         value_print_options reference.
1427         (print_command_completer): Declare.
1428
1429 2019-06-13  Pedro Alves  <palves@redhat.com>
1430
1431         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1432         (COMMON_SFILES): Add maint-test-settings.c.
1433         * cli/cli-decode.c (boolean_enums): New global, factored out from
1434         ...
1435         (add_setshow_boolean_cmd): ... here.
1436         * cli/cli-decode.h (boolean_enums): Declare.
1437         * cli/cli-option.c: New file.
1438         * cli/cli-option.h: New file.
1439         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1440         factored out from ...
1441         (parse_cli_boolean_value(const char *)): ... this.
1442         (is_unlimited_literal): Change parameter type to pointer to
1443         pointer.  Adjust and advance ARG pointer.
1444         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1445         (parse_cli_var_enum): New, factored out from ...
1446         (do_set_command): ... this.  Adjust.
1447         * cli/cli-setshow.h (parse_cli_boolean_value)
1448         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1449         (parse_cli_var_enum): Declare.
1450         * cli/cli-utils.c: Include "cli/cli-option.h".
1451         (get_ulongest): New.
1452         * cli/cli-utils.h (get_ulongest): Declare.
1453         (check_for_argument): New overloads.
1454         * maint-test-options.c: New file.
1455
1456 2019-06-13  Pedro Alves  <palves@redhat.com>
1457
1458         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1459         parse a range if "-" is at the end of the string.
1460
1461 2019-06-13  Pedro Alves  <palves@redhat.com>
1462
1463         * cli/cli-setshow.c (parse_auto_binary_operation)
1464         (parse_cli_boolean_value): Don't allow "o".
1465
1466 2019-06-13  Pedro Alves  <palves@redhat.com>
1467
1468         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1469         * NEWS: Mention maint test-settings KIND.
1470         * maint-test-settings.c: New file.
1471
1472 2019-06-13  Pedro Alves  <palves@redhat.com>
1473
1474         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1475         completer.
1476         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1477         "set" completers.
1478
1479 2019-06-13  Pedro Alves  <palves@redhat.com>
1480
1481         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1482         after item.
1483
1484 2019-06-13  Pedro Alves  <palves@redhat.com>
1485
1486         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1487
1488 2019-06-13  Pedro Alves <palves@redhat.com>
1489
1490         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1491         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1492         call.
1493         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1494         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1495         calls.
1496         (check_for_argument): Skip spaces after argument.
1497
1498 2019-06-13  Pedro Alves  <palves@redhat.com>
1499
1500         * thread.c (thread_apply_command): Adjust TID parsing.
1501         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1502         detected before end of string.
1503         (tid_is_in_list): Error out if LIST is invalid.
1504
1505 2019-06-13  Pedro Alves  <palves@redhat.com>
1506
1507         * completer.c (complete_line_internal_1): Rewind completion word
1508         point.
1509         (completion_tracker::advance_custom_word_point_by): Change
1510         parameter type to int.
1511         * completer.h (completion_tracker::advance_custom_word_point_by):
1512         Likewise.
1513
1514 2019-06-13  Pedro Alves  <palves@redhat.com>
1515
1516         * completer.c (advance_to_completion_word): Handle delimiters.
1517
1518 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1519
1520         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1521
1522 2019-06-11  Tom Tromey  <tom@tromey.com>
1523
1524         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1525         (xmalloc_failed): Move to alloc.c.
1526         * alloc.c: New file.
1527         * Makefile.in (COMMON_SFILES): Add alloc.c.
1528
1529 2019-06-11  Tom Tromey  <tom@tromey.com>
1530
1531         * nat/linux-waitpid.c: Don't include server.h.
1532         (linux_debug): Remove.
1533         (my_waitpid): Update.
1534
1535 2019-06-11  Tom Tromey  <tromey@adacore.com>
1536
1537         * infcall.c (_initialize_infcall): Remove trailing newline from
1538         help.
1539         * user-regs.c (_initialize_user_regs): Remove trailing newline
1540         from help.
1541         * typeprint.c (_initialize_typeprint): Remove trailing newline
1542         from help.
1543         * reverse.c (_initialize_reverse): Remove trailing newlines from
1544         help.
1545         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1546         from help.
1547         * language.c (add_set_language_command): Remove trailing newline
1548         from help.
1549         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1550         help.
1551         * disasm.c (_initialize_disasm): Remove trailing newline from
1552         help.
1553         * top.c (init_main): Remove trailing newline from help.
1554         * interps.c (_initialize_interpreter): Remove trailing newline
1555         from help.
1556         * btrace.c (_initialize_btrace): Remove trailing newlines from
1557         help.
1558         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1559         from help.
1560         * python/python.c (_initialize_python): Remove trailing newline
1561         from help.
1562         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1563         help.
1564         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1565         from help.  Reformat some text.
1566         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1567         from help.
1568         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1569         newline from help.
1570
1571 2019-06-11  Tom Tromey  <tromey@adacore.com>
1572
1573         * darwin-nat.c (darwin_decode_exception_message)
1574         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1575
1576 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1577
1578         * valops.c (value_slice): Check for not allocated or not
1579         associated values.
1580
1581 2019-06-10  Tom de Vries  <tdevries@suse.de>
1582
1583         PR gdb/24618
1584         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1585         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1586         invalid.
1587
1588 2019-06-10  Tom de Vries  <tdevries@suse.de>
1589
1590         PR gdb/24611
1591         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1592         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1593
1594 2019-06-10  Tom de Vries  <tdevries@suse.de>
1595
1596         PR symtab/24545
1597         * symtab.c (struct demangled_name_entry): Add language field.
1598         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1599         static minimal symbol".  Set and use language field.
1600
1601 2019-06-10  Tom Tromey  <tromey@adacore.com>
1602
1603         * ada-lang.c (_initialize_ada_language): Update help text.
1604
1605 2019-06-10  Tom Tromey  <tromey@adacore.com>
1606
1607         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1608         with a newline.
1609         * guile/guile.c (handle_boot_error): Don't end warning with a
1610         newline.
1611         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1612         warning with a newline.
1613         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1614         newline.
1615         (s12z_frame_cache): Likewise.
1616         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1617         a newline.
1618         * solib-svr4.c (disable_probes_interface): Don't end warning with
1619         a newline.
1620         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1621         newline.
1622         * python/python.c (do_finish_initialization): Don't end warning
1623         with a newline.
1624
1625 2019-06-10  Tom Tromey  <tom@tromey.com>
1626
1627         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1628         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1629         gdbpy_enter.
1630
1631 2019-06-10  Tom Tromey  <tromey@adacore.com>
1632
1633         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1634         data.
1635         (elf_new_init): Don't call stabsread_new_init.
1636         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1637         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1638         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1639
1640 2019-06-10  Tom de Vries  <tdevries@suse.de>
1641
1642         PR symtab/16264
1643         PR symtab/24517
1644         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1645
1646 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1647
1648         * source.c (find_and_open_source): Also rewrite relative file
1649         names.
1650
1651 2019-04-26  Amos Bird  <amosbird@gmail.com>
1652
1653         * annotate.c (annotate_thread_exited): Add "thread-exited"
1654         annotation.
1655
1656 2019-06-06  Tom Tromey  <tromey@adacore.com>
1657
1658         * maint.h (class scoped_command_stats): Use
1659         DISABLE_COPY_AND_ASSIGN.
1660         <print_time>: New method.
1661         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1662         print_time.
1663         (scoped_command_stats::print_time): New method.
1664
1665 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1666
1667         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1668         instructions of lengths 6 or 8 bytes.
1669
1670 2019-06-04  Pedro Alves  <palves@redhat.com>
1671
1672         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1673
1674         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1675         * breakpoint.c (condition_completer): Likewise.
1676         * cli/cli-dump.c (scan_expression): Likewise.
1677         * common/filestuff.c (mkdir_recursive): Likewise.
1678         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1679         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1680         (gdb_abspath): Likewise.
1681         * compile/compile-cplus-types.c
1682         (compile_cplus_instance::decl_name): Likewise.
1683         * completer.c (complete_explicit_location):
1684         (signal_completer, reg_or_group_completer_1): Likewise.
1685         * cp-support.c (cp_remove_params_if_any): Likewise.
1686         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1687         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1688         * infcmd.c (strip_bg_char): Likewise.
1689         * linespec.c (copy_token_string): Likewise.
1690         * mi/mi-main.c (output_cores): Likewise.
1691         * psymtab.c (psymtab_search_name):
1692         * symfile.c (test_set_ext_lang_command): Likewise.
1693         * target.c (target_fileio_read_stralloc): Likewise.
1694         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1695         * value.c (complete_internalvar): Likewise.
1696
1697 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1698
1699         Add objfile property to gdb.Type.
1700         * NEWS: Mention Python API addition.
1701         * python/py-type.c (typy_get_objfile): New method.
1702
1703 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1704
1705         * NEWS: Mention the new set|show style [title|highlight].
1706         Mention changes to "show style", "help" and "apropos".
1707
1708 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1709
1710         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1711         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1712         instead of print_help_for_command.
1713         (print_doc_of_command): New function.
1714         (help_list): Add 'apropos -v word' suggestion.
1715         (print_help_for_command): Style the command name using title style.
1716         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1717         (_initialize_cli_cmds): Describe -v in apropos_command help.
1718
1719 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1720
1721         * cli/cli-style.h (cli_style_option): Add name in constructor,
1722         add m_name class member, add constructor with intensity,
1723         add name class function.
1724         (cli_style_option::add_setshow_commands): Remove name argument.
1725         (highlight_style, title_style): New styles.
1726         * cli/cli-style.c (do_show): New function that shows a style
1727         characteristic styling the style name with itself.
1728         (set_style_name): New function.
1729         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1730         Update all callers according to the changes in cli/cli-style.h.
1731         * utils.h (fputs_highlighted): New function.
1732         * utils.c (fputs_highlighted): Likewise.
1733
1734 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1735
1736         * NEWS: Mention new pipe command and new convenience variables.
1737
1738 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1739
1740         * cli/cli-cmds.c (pipe_command): New function.
1741         (_initialize_cli_cmds): Call add_com for pipe_command.
1742         Define | as an alias for pipe.
1743         (exit_status_set_internal_vars): New function.
1744         (shell_escape): Call exit_status_set_internal_vars.
1745         cli/cli-decode.c (find_command_name_length): Recognize | as
1746         a single character command.
1747
1748 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1749
1750         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1751         top.c (execute_command_to_ui_file): New function, mostly a copy
1752         of execute_command_to_string.
1753         (execute_command_to_string): Implement by calling
1754         execute_command_to_ui_file.
1755
1756 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1757
1758         * top.h (saved_command_line): Remove declaration.
1759         * top.c (previous_saved_command_line, previous_repeat_arguments):
1760         New variables.
1761         (saved_command_line): Make static, define together with other
1762         'repeat variables'.
1763         (dont_repeat): Clear repeat_arguments.
1764         (repeat_previous, get_saved_command_line, save_command_line):
1765         New functions.
1766         (gdb_init): Initialize saved_command_line
1767         and previous_saved_command_line.
1768         * main.c (captured_main_1): Remove saved_command_line initialization.
1769         * event-top.c (handle_line_of_input): Update to use
1770         the new 'repeat' related functions instead of direct access to
1771         saved_command_line.
1772         * command.h (repeat_previous, get_saved_command_line,
1773         save_command_line): New declarations.
1774         (dont_repeat): Add comment.
1775
1776 2019-05-30  Tom Tromey  <tromey@adacore.com>
1777
1778         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1779         Fix comment.
1780         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1781
1782 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1783
1784         PR cli/24587
1785         * completer.c (complete): Initialize variable word.
1786
1787 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1788
1789         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1790         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1791         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1792         'body' is NULL to the outter 'if', protecting the '!is_define'
1793         situation as well.
1794
1795 2019-05-29  Tom Tromey  <tromey@adacore.com>
1796
1797         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1798         (dwarf_unknown): New function.
1799         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1800         (dwarf_type_encoding_name): Use dwarf_unknown.
1801
1802 2019-05-29  Tom Tromey  <tromey@adacore.com>
1803
1804         PR c++/20020:
1805         * cp-valprint.c (cp_print_value_fields): Call
1806         cp_print_static_field inside "try".
1807
1808 2019-05-29  Tom Tromey  <tromey@adacore.com>
1809
1810         * inflow.c (struct terminal_info): Add default operator=.
1811         * configure: Rebuild.
1812         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1813         -Wdeprecated-copy-dtor, -Wredundant-move.
1814
1815 2019-05-29  Tom Tromey  <tromey@adacore.com>
1816
1817         * NEWS: Add entry.
1818         * infcmd.c (print_return_value_1): Handle finish_print
1819         option.
1820         (show_print_finish): New function.
1821         (_initialize_infcmd): Add "set/show print finish" commands.
1822         * valprint.c (user_print_options): Initialize new member.
1823         * valprint.h (struct value_print_options) <finish_print>: New
1824         member.
1825
1826 2019-05-28  Tom Tromey  <tromey@adacore.com>
1827
1828         * ada-lang.c (ada_remove_Xbn_suffix)
1829         (find_old_style_renaming_symbol)
1830         (parse_old_style_renaming): Remove.
1831         (ada_find_renaming_symbol): Don't call
1832         find_old_style_renaming_symbol.
1833         (ada_is_renaming_symbol): Rename from
1834         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1835         bool.  Now static.
1836         (ada_read_var_value): Update and simplify.
1837         * ada-exp.y (write_var_or_type): Remove old code.
1838
1839 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1840
1841         * event-top.c: Remove include comment.
1842         * inflow.c (class scoped_ignore_sigttou): Move from here...
1843         * inflow.h (class scoped_ignore_sigttou): ...to here.
1844         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1845         * top.c:  Remove include comment.
1846
1847 2019-05-27  Tom Tromey  <tom@tromey.com>
1848
1849         * NEWS: Fix typo.
1850
1851 2019-05-22  Tom Tromey  <tromey@adacore.com>
1852
1853         * target.c (target_follow_exec): Constify parameter.
1854         * target-delegates.c: Rebuild.
1855         * remote.c (remote_target::follow_exec): Constify parameter.
1856         * infrun.c (follow_exec): Constify parameter.
1857         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1858         (target_follow_exec): Likewise.
1859
1860 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1861
1862         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1863         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1864
1865 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1866
1867         * NEWS: Add debugredirect and testsuite sections.
1868
1869 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1870
1871         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1872         target descriptions using exclusively floating point register name
1873         aliases.
1874
1875 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1876
1877         PR gdb/18644:
1878         * f-lang.c (build_fortran_types): Handle the case where
1879         gdbarch_floatformat_for_type returns a nullptr.
1880
1881 2019-05-21  Tom de Vries  <tdevries@suse.de>
1882
1883         PR cli/24587
1884         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1885
1886 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1887
1888         PR gdb/18644:
1889         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1890         16-byte floats.
1891         * i386-tdep.c (i386_floatformat_for_type): Use
1892         floatformats_ia64_quad for the 16-byte floating point component
1893         within a fortran 32-byte complex number.
1894
1895 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1896
1897         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1898         delete default constructor.
1899         (find_partial_die): Update to return const struct.
1900         (partial_die_parent_scope): Move variable declaration into scope
1901         of its use and change its type to auto.
1902         (guess_partial_die_structure_name): Likewise.
1903         (partial_die_info::fixup): Likewise.
1904
1905 2019-05-17  Tom Tromey  <tromey@adacore.com>
1906
1907         * source.c (find_and_open_source): Remove cast.
1908
1909 2019-05-17  Tom Tromey  <tromey@adacore.com>
1910
1911         * annotate.c (annotate_source): Make "filename" const.
1912         * annotate.h (annotate_source): Use const.
1913
1914 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1915
1916         * disasm.c (set_disassembler_options): Send errors to stderr.
1917
1918 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1919
1920         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1921         (cli_interp_base::set_logging): Check debug_redirect.
1922         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1923         * cli/cli-logging.c (debug_redirect): Add static variable.
1924         (pop_output_files): Add default param.
1925         (handle_redirections): Print debug setting.
1926         (show_logging_command): Likewise.
1927         (_initialize_cli_logging): Add debugredirect command.
1928         * interps.c (current_interp_set_logging): Add debug_redirect
1929         parameter.
1930         * interps.h (set_logging): Add debug_redirect parameter.
1931         (current_interp_set_logging): Likewise.
1932         * mi/mi-common.h: Likewise.
1933         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1934
1935 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1936             Tom Tromey  <tromey@adacore.com>
1937
1938         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1939         directly.
1940         * cli/cli-interp.h (make_logging_output): Remove declaration.
1941         * cli/cli-logging.c (make_logging_output): Remove function.
1942         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1943         directly.
1944         * ui-file.c (tee_file::tee_file): Remove bools.
1945         (tee_file::~tee_file): Remove deletes.
1946         * ui-file.h (tee_file): Remove bools.
1947
1948 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1949
1950         * mi/mi-cmds.h (mi_cmd_complete): New function.
1951         * mi/mi-main.c (mi_cmd_complete): Likewise.
1952         * mi/mi-cmds.c: Define new MI command -complete.
1953         * NEWS: Mention new -complete command.
1954
1955 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1956
1957         * completer.h (complete): New function.
1958         * completer.c (complete): Likewise.
1959         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1960         function defined in completer.h.
1961
1962 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1963
1964         * MAINTAINERS (Write After Approval): Add myself.
1965
1966 2019-05-17  Tom de Vries  <tdevries@suse.de>
1967
1968         PR gdb/24094
1969         * dwarf2read.c (struct cu_partial_die_info): New struct.
1970         (find_partial_die): Return cu_partial_die_info.
1971         (partial_die_parent_scope, guess_partial_die_structure_name)
1972         (partial_die_info::fixup): Handle new return type of find_partial_die.
1973
1974 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1975
1976         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1977         "std::string", simplifying the algorithm.
1978
1979 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1980
1981         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1982         (stap_static_probe_ops::get_probes): Likewise.
1983
1984 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1985
1986         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1987         '-')" and "else if".
1988         (stap_parse_single_operand): Join checks for
1989         "gdbarch_stap_parse_special_token_p" and
1990         "gdbarch_stap_parse_special_token" in the same "if" statement.
1991         Invert check when verifying for operation on register
1992         displacement.
1993
1994 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1995
1996         * stap-probe.c (stap_get_opcode): Update comment.
1997         (stap_get_expected_argument_type): Likewise.
1998         (handle_stap_probe): Likewise.
1999
2000 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2001
2002         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2003         return type to 'bool'.  Adjust comment.  Use 'bool' when
2004         appropriate.
2005         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2006         * stap-probe.c (stap_parse_argument_1): Likewise.
2007         (stap_is_operator): Likewise.
2008         (stap_is_generic_prefix): Likewise.
2009         (stap_is_register_prefix): Likewise.
2010         (stap_is_register_indirection_prefix): Likewise.
2011         (stap_is_integer_prefix): Likewise.
2012         (stap_generic_check_suffix): Likewise.
2013         (stap_check_integer_suffix): Likewise.
2014         (stap_check_register_suffix): Likewise.
2015         (stap_check_register_indirection_suffix): Likewise.
2016         (stap_parse_register_operand): Likewise.
2017         (stap_parse_single_operand): Likewise.
2018         (stap_parse_argument_1): Likewise.
2019         (stap_probe::get_argument_count): Likewise.
2020         (stap_is_operator): Likewise.
2021
2022 2019-05-16  Tom Tromey  <tromey@adacore.com>
2023
2024         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2025         keyword to foreach.
2026
2027 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2028
2029         * linux-thread-db.c (try_thread_db_load_1): Change return type
2030         to bool.
2031         (try_thread_db_load): Likewise.
2032         (try_thread_db_load_from_pdir_1): Likewise.
2033         (try_thread_db_load_from_pdir): Likewise.
2034         (try_thread_db_load_from_sdir): Likewise.
2035         (try_thread_db_load_from_dir): Likewise.
2036         (thread_db_load_search): Likewise.
2037         (has_libpthread): Likewise.
2038         (thread_db_load): Likewise.
2039
2040 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2041
2042         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2043         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2044         NULL, and complain/return if that's the case.
2045
2046 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2047
2048         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2049         (advance, posn, abstract_read_memory): New functions.
2050         [struct mem_read_abstraction]: New struct.
2051         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2052
2053 2019-05-14  Tom Tromey  <tromey@adacore.com>
2054
2055         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2056         value is not lval_memory.
2057
2058 2019-05-14  Tom Tromey  <tromey@adacore.com>
2059
2060         * solib.c (info_sharedlibrary_command): Style the file name.
2061
2062 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2063
2064         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2065         (aarch64_vnv_type): Likewise.
2066         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2067         * common/tdesc.c: Likewise.
2068         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2069         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2070         * features/aarch64-fpu.xml: Add ieee half view.
2071         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2072         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2073         * gdbtypes.h (struct builtin_type): Likewise.
2074         (struct objfile_type): Likewise.
2075
2076 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2077
2078         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2079         typo.
2080         * location.h (string_to_event_location): Likewise.
2081
2082 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2083
2084         GDB 8.3 released.
2085
2086 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2087
2088         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2089         New variable declaration.
2090         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2091         New variable.
2092         (print_one_breakpoint): Use ui_out::test_flags and new global
2093         variable to compute use_fixed_output.
2094         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2095         Remove.
2096         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2097         (mi_multi_location_breakpoint_output_fixed): Remove.
2098         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2099         new variable.
2100         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2101         fix_multi_location_breakpoint_output flag if version >= 3.
2102         * ui-out.h (enum ui_out_flag)
2103         <fix_multi_location_breakpoint_output>: New enumerator.
2104
2105 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2106
2107         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2108
2109 2019-05-10  Tom Tromey  <tromey@adacore.com>
2110
2111         * ada-lang.c (catch_ada_completer): New function.
2112         (_initialize_ada_language): Use it.
2113
2114 2019-05-10  Tom Tromey  <tromey@adacore.com>
2115
2116         * thread.c (print_thread_info): Make "requested_threads" const.
2117         * gdbthread.h (print_thread_info): Make "requested_threads"
2118         const.
2119         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2120         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2121
2122 2019-05-08  Tom Tromey  <tom@tromey.com>
2123
2124         * gdbtypes.c (objfile_type_data): Change type.
2125         (objfile_type, _initialize_gdbtypes): Update.
2126
2127 2019-05-08  Tom Tromey  <tom@tromey.com>
2128
2129         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2130         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2131         (_initialize_dwarf2_frame): Update.
2132
2133 2019-05-08  Tom Tromey  <tom@tromey.com>
2134
2135         * objc-lang.c (objc_objfile_data): Change type.
2136         (find_methods): Update.
2137         (_initialize_objc_lang): Remove.
2138
2139 2019-05-08  Tom Tromey  <tom@tromey.com>
2140
2141         * stabsread.c (rs6000_builtin_type_data): Change type.
2142         (rs6000_builtin_type, _initialize_stabsread): Update.
2143
2144 2019-05-08  Tom Tromey  <tom@tromey.com>
2145
2146         * mips-tdep.c (mips_pdr_data): Remove.
2147         (_initialize_mips_tdep): Update.
2148
2149 2019-05-08  Tom Tromey  <tom@tromey.com>
2150
2151         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2152         (hppa_init_objfile_priv_data, read_unwind_info)
2153         (find_unwind_entry, _initialize_hppa_tdep): Update.
2154
2155 2019-05-08  Tom Tromey  <tom@tromey.com>
2156
2157         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2158         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2159         on obstack.
2160         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2161
2162 2019-05-08  Tom Tromey  <tom@tromey.com>
2163
2164         * mdebugread.c (basic_type_data): Change type.
2165         (basic_type, _initialize_mdebugread): Update.
2166
2167 2019-05-08  Tom Tromey  <tom@tromey.com>
2168
2169         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2170
2171 2019-05-08  Tom Tromey  <tom@tromey.com>
2172
2173         * nto-tdep.c (nto_inferior_data_reg): Change type.
2174         (nto_inferior_data): Update.
2175         (nto_inferior_data_cleanup, nto_new_inferior_data)
2176         (_initialize_nto_tdep): Remove.
2177         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2178
2179 2019-05-08  Tom Tromey  <tom@tromey.com>
2180
2181         * ada-lang.c (struct ada_inferior_data): Add initializers.
2182         (ada_inferior_data): Change type.
2183         (ada_inferior_data_cleanup): Remove.
2184         (get_ada_inferior_data, ada_inferior_exit)
2185         (struct ada_pspace_data): Add initializers, destructor.
2186         (ada_pspace_data_handle): Change type.
2187         (get_ada_pspace_data): Update.
2188         (ada_pspace_data_cleanup): Remove.
2189
2190 2019-05-08  Tom Tromey  <tom@tromey.com>
2191
2192         * coffread.c (struct coff_symfile_info): Add initializers.
2193         (coff_objfile_data_key): Move lower.  Change type.
2194         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2195         Update.
2196         (coff_free_info): Remove.
2197
2198 2019-05-08  Tom Tromey  <tom@tromey.com>
2199
2200         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2201         (fbsd_pspace_data_handle): Move lower.  Change type.
2202         (get_fbsd_pspace_data): Update.
2203         (fbsd_pspace_data_cleanup): Remove.
2204         (_initialize_fbsd_tdep): Update.
2205
2206 2019-05-08  Tom Tromey  <tom@tromey.com>
2207
2208         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2209         (get_ada_tasks_pspace_data): Update.
2210         (ada_tasks_pspace_data_cleanup): Remove.
2211         (_initialize_tasks): Update.
2212         (ada_tasks_inferior_data_handle): Change type.
2213         (get_ada_tasks_inferior_data): Update.
2214         (ada_tasks_inferior_data_cleanup): Remove.
2215         (struct ada_tasks_pspace_data): Add initializers.
2216
2217 2019-05-08  Tom Tromey  <tom@tromey.com>
2218
2219         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2220         * symfile-debug.c (debug_sym_get_probes): Change type.
2221         * stap-probe.c (handle_stap_probe):
2222         (stap_static_probe_ops::get_probes): Change type.
2223         * probe.h (class static_probe_ops) <get_probes>: Change type.
2224         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2225         (parse_probes_in_pspace): Update.
2226         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2227         Update.
2228         (any_static_probe_ops::get_probes): Change type.
2229         * elfread.c (elfread_data): New typedef.
2230         (probe_key): Change type.
2231         (elf_get_probes): Likewise.  Update.
2232         (probe_key_free): Remove.
2233         (_initialize_elfread): Update.
2234         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2235         Change type.
2236         (dtrace_process_dof_probe, dtrace_process_dof)
2237         (dtrace_static_probe_ops::get_probe): Change type.
2238
2239 2019-05-08  Tom Tromey  <tom@tromey.com>
2240
2241         * xcoffread.c (struct xcoff_symfile_info): Rename from
2242         coff_symfile_info.  Add initializers.
2243         (xcoff_objfile_data_key): Move lower.  Change type.
2244         (XCOFF_DATA): Rewrite.
2245         (xcoff_free_info): Remove.
2246         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2247         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2248         (xcoff_initial_scan): Update.
2249
2250 2019-05-08  Tom Tromey  <tom@tromey.com>
2251
2252         * solib-svr4.c (struct svr4_info): Add initializers and
2253         destructor.
2254         <probes_table>: Now an htab_up.
2255         (solib_svr4_pspace_data): Change type.
2256         (free_probes_table): Simplify.
2257         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2258         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2259         (probes_table_remove_objfile_probes, register_solib_event_probe)
2260         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2261         (_initialize_svr4_solib): Update.
2262
2263 2019-05-08  Tom Tromey  <tom@tromey.com>
2264
2265         * remote.c (remote_pspace_data): Change type.
2266         (remote_pspace_data_cleanup): Remove.
2267         (get_remote_exec_file, set_pspace_remote_exec_file)
2268         (_initialize_remote): Update.
2269
2270 2019-05-08  Tom Tromey  <tom@tromey.com>
2271
2272         * breakpoint.c (breakpoint_objfile_key): Change type.
2273         (get_breakpoint_objfile_data): Update.
2274         (free_breakpoint_objfile_data): Remove.
2275         (_initialize_breakpoint): Update.
2276
2277 2019-05-08  Tom Tromey  <tom@tromey.com>
2278
2279         * linux-tdep.c (struct linux_info): Add initializers.
2280         (linux_inferior_data): Move.  Change type.
2281         (invalidate_linux_cache_inf): Update.
2282         (linux_inferior_data_cleanup): Remove.
2283         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2284
2285 2019-05-08  Tom Tromey  <tom@tromey.com>
2286
2287         * auxv.c (auxv_inferior_data): Move.  Change type.
2288         (auxv_inferior_data_cleanup): Remove.
2289         (invalidate_auxv_cache_inf): Rewrite.
2290         (get_auxv_inferior_data, _initialize_auxv): Update.
2291
2292 2019-05-08  Tom Tromey  <tom@tromey.com>
2293
2294         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2295         (symfile_debug_objfile_data_key): Change type.
2296         (symfile_debug_installed, debug_qf_has_symbols)
2297         (debug_qf_find_last_source_symtab)
2298         (debug_qf_forget_cached_source_info)
2299         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2300         (debug_qf_print_stats, debug_qf_dump)
2301         (debug_qf_expand_symtabs_for_function)
2302         (debug_qf_expand_all_symtabs)
2303         (debug_qf_expand_symtabs_with_fullname)
2304         (debug_qf_map_matching_symbols)
2305         (debug_qf_expand_symtabs_matching)
2306         (debug_qf_find_pc_sect_compunit_symtab)
2307         (debug_qf_map_symbol_filenames)
2308         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2309         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2310         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2311         (debug_sym_read_linetable, debug_sym_relocate): Update.
2312         (symfile_debug_free_objfile): Remove.
2313         (install_symfile_debug_logging, _initialize_symfile_debug):
2314         Update.
2315
2316 2019-05-08  Tom Tromey  <tom@tromey.com>
2317
2318         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2319         allocate_on_obstack.
2320         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2321         (get_dwarf2_per_objfile): Update.
2322         (set_dwarf2_per_objfile): Remove.
2323         (dwarf2_has_info, dwarf2_get_section_info): Update.
2324         (dwarf2_free_objfile): Remove.
2325         (_initialize_dwarf2_read): Update.
2326
2327 2019-05-08  Tom Tromey  <tom@tromey.com>
2328
2329         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2330         initializers.
2331         <unsupported_script_warning_printed,
2332         script_not_found_warning_printed>: Now bool.
2333         (auto_load_pspace_data): Change type.
2334         (~auto_load_pspace_info): Rename from
2335         auto_load_pspace_data_cleanup.
2336         (get_auto_load_pspace_data, init_loaded_scripts_info)
2337         (clear_section_scripts, maybe_print_unsupported_script_warning)
2338         (maybe_print_script_not_found_warning, _initialize_auto_load):
2339         Update.
2340
2341 2019-05-08  Tom Tromey  <tom@tromey.com>
2342
2343         * objfiles.c (objfile_pspace_info): Add destructor and
2344         initializers.
2345         (objfiles_pspace_data): Change type.
2346         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2347         (get_objfile_pspace_data): Update.
2348         (objfiles_bfd_data): Change type.
2349         (get_objfile_bfd_data): Update.
2350         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2351
2352 2019-05-08  Tom Tromey  <tom@tromey.com>
2353
2354         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2355         Change type.
2356         (get_catch_syscall_inferior_data): Update.
2357         (catch_syscall_inferior_data_cleanup): Remove.
2358         (_initialize_break_catch_syscall): Update.
2359
2360 2019-05-08  Tom Tromey  <tom@tromey.com>
2361
2362         * inflow.c (struct terminal_info): Add destructor and
2363         initializers.
2364         (inflow_inferior_data): Change type.
2365         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2366         (get_inflow_inferior_data, inflow_inferior_exit)
2367         (swap_terminal_info, _initialize_inflow): Update.
2368
2369 2019-05-08  Tom Tromey  <tom@tromey.com>
2370
2371         * target-dcache.c (target_dcache_cleanup): Remove.
2372         (target_dcache_aspace_key): Change type.
2373         (target_dcache_init_p, target_dcache_invalidate)
2374         (target_dcache_get, target_dcache_get_or_init)
2375         (_initialize_target_dcache): Update.
2376         * dcache.h (struct dcache_deleter): New.
2377
2378 2019-05-08  Tom Tromey  <tom@tromey.com>
2379
2380         * symtab.c (struct symbol_cache): Add destructor and
2381         initializers.
2382         (symbol_cache_key): Move.  Change type.
2383         (make_symbol_cache, free_symbol_cache): Remove.
2384         (get_symbol_cache): Update.
2385         (symbol_cache_cleanup): Remove.
2386         (ALL_PSPACES, symbol_cache_flush)
2387         (maintenance_print_symbol_cache)
2388         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2389         Update.
2390
2391 2019-05-08  Tom Tromey  <tom@tromey.com>
2392
2393         * symtab.c (struct main_info): Add destructor and initializers.
2394         (main_progspace_key): Move.  Change type.
2395         (get_main_info): Update.
2396         (main_info_cleanup): Remove.
2397         (_initialize_symtab): Update.
2398
2399 2019-05-08  Tom Tromey  <tom@tromey.com>
2400
2401         * registry.h (DECLARE_REGISTRY): Define the _key class.
2402
2403 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2404
2405         * NEWS: Merge two 'New commands' sections.
2406
2407 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2408
2409         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2410         parameter and use Ada language definition instead.
2411         (ada_val_print_ptr): Remove unused language parameter.
2412         (ada_val_print_num): Remove language parameter and use Ada language
2413         definition instead.
2414         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2415         parameter.
2416         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2417         parameter and use Ada language definition instead.
2418         (ada_val_print_1): Update all ada_val_print_xxx calls.
2419         Remove language parameter.
2420         (ada_val_print): Update ada_val_print_1 call.
2421
2422 2019-05-08  Tom Tromey  <tromey@adacore.com>
2423
2424         * remote.c (remote_hw_watchpoint_limit)
2425         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2426         Now static.
2427
2428 2019-05-08  Tom Tromey  <tromey@adacore.com>
2429
2430         * maint.c (_initialize_maint_cmds): Move initialization code to
2431         remote.c.
2432         (watchdog, show_watchdog): Move to remote.c.
2433         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2434         "watchdog" static.
2435         (_initialize_remote): Move initialization code from maint.c.
2436         * defs.h (watchdog): Don't declare.
2437
2438 2019-05-08  Tom Tromey  <tromey@adacore.com>
2439
2440         * tui/tui-interp.c: Include main.h.
2441         * interps.c: Include main.h.
2442         * main.h (interpreter_p): Declare.
2443         * defs.h (interpreter_p): Don't declare.
2444
2445 2019-05-08  Tom Tromey  <tromey@adacore.com>
2446
2447         * dwarf2loc.c: Include dwarf2read.h.
2448         * defs.h (read_unsigned_leb128): Don't declare.
2449         * dwarf2read.h (read_unsigned_leb128): Declare.
2450
2451 2019-05-08  Tom Tromey  <tromey@adacore.com>
2452
2453         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2454         method.
2455
2456 2019-05-08  Tom Tromey  <tromey@adacore.com>
2457
2458         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2459         when no wrap column is set.
2460
2461 2019-05-08  Tom Tromey  <tromey@adacore.com>
2462
2463         * c-lang.c (c_get_string): Handle non-C-style arrays.
2464
2465 2019-05-08  Tom Tromey  <tromey@adacore.com>
2466
2467         * typeprint.c (print_offset_data::update): Print the bit offset,
2468         not the number of bits remaining.
2469
2470 2019-05-08  Tom Tromey  <tromey@adacore.com>
2471
2472         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2473         padding at end of comment.
2474
2475 2019-05-08  Tom Tromey  <tromey@adacore.com>
2476
2477         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2478         Compare main types.
2479
2480 2019-05-06  Tom Tromey  <tom@tromey.com>
2481
2482         * common/scoped_mmap.c: Include common-defs.h.
2483         * common/scoped_mmap.h: Don't include config.h.
2484
2485 2019-05-04  Tom Tromey  <tom@tromey.com>
2486
2487         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2488         (struct aarch64_call_info): Add initializers.
2489         <si>: Now a std::vector.
2490         (pass_on_stack, aarch64_push_dummy_call): Update.
2491
2492 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2493             Tom Tromey  <tom@tromey.com>
2494
2495         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2496         (ppc_threads): Now a std::vector.  Now static.
2497         (hwdebug_find_thread_points_by_tid)
2498         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2499         Update.
2500
2501 2019-05-04  Tom Tromey  <tom@tromey.com>
2502
2503         * arc-tdep.c (arc_tdesc_init): Return bool.
2504
2505 2019-05-04  Tom Tromey  <tom@tromey.com>
2506
2507         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2508         Use gdb_assert_not_reached.
2509
2510 2019-05-04  Tom Tromey  <tom@tromey.com>
2511
2512         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2513         "false".
2514
2515 2019-05-04  Tom Tromey  <tom@tromey.com>
2516
2517         * arc-tdep.c (arc_tdesc_init): Use bool.
2518
2519 2019-05-04  Tom Tromey  <tom@tromey.com>
2520
2521         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2522
2523 2019-05-04  Tom Tromey  <tom@tromey.com>
2524
2525         * cli/cli-cmds.c (valid_command_p): Return bool.
2526
2527 2019-05-04  Tom Tromey  <tom@tromey.com>
2528
2529         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2530         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2531
2532 2019-05-04  Raul Tambre  <raul@tambre.ee>
2533
2534         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2535         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2536         operator for comparison.
2537
2538 2019-05-04  Tom Tromey  <tom@tromey.com>
2539
2540         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2541         (lookup_partial_symbol, print_partial_symbols)
2542         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2543         (psymbol_compare): Update.
2544         (add_psymbol_to_bcache): Clear the entire psymbol.
2545         (maintenance_check_psymtabs): Update.
2546         * psympriv.h (struct partial_symbol): Don't derive from
2547         general_symbol_info.
2548         <obj_section, unrelocated_address, address,
2549         set_unrelocated_address>: Update.
2550         <ginfo>: New member.
2551         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2552         (debug_names::write_psymbols): Update.
2553
2554 2019-05-04  Tom de Vries  <tdevries@suse.de>
2555
2556         * contrib/cc-with-tweaks.sh: Support -n arg.
2557
2558 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2559
2560         * corelow.c (core_target::detach): Ensure frame cache and
2561         register caches are cleared.
2562         inferior.c (exit_inferior_1): Likewise.
2563
2564 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2565             Tom Tromey  <tom@tromey.com>
2566
2567         * dictionary.c (collate_pending_symbols_by_language): Remove
2568         "struct" from foreach.
2569         * symtab.c (lookup_global_symbol_from_objfile)
2570         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2571         foreach.
2572         * ser-tcp.c (net_open): Remove "struct" from foreach.
2573         * objfiles.c (objfile_relocate, objfile_rebase)
2574         (objfile_has_symbols): Remove "struct" from foreach.
2575         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2576         from foreach.
2577         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2578         foreach.
2579         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2580         "struct" from foreach.
2581         * ada-lang.c (create_excep_cond_exprs)
2582         (ada_exception_catchpoint_cond_string): Remove "struct" from
2583         foreach.
2584
2585 2019-05-03  Tom Tromey  <tromey@adacore.com>
2586
2587         * ada-exp.y (convert_char_literal): Check suffix of each
2588         enumerator.
2589
2590 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2591
2592         PR ada/21406:
2593         * ada-exp.y (yywrap): Don't define.
2594         * ada-lex.l (%option): Add noyywrap
2595         (yywrap): Remove.
2596
2597 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2598
2599         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2600         _WIN32_WINNT to the XP level, unless already defined to a higher
2601         level.
2602
2603         * unittests/parse-connection-spec-selftests.c:
2604         * ser-tcp.c:
2605         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2606         override.
2607
2608         * symfile.c (find_separate_debug_file): Remove colon from the
2609         drive spec of DOS/Windows file names of the target, so that the
2610         file name produced from DEBUGDIR and the target's directory will
2611         be valid on DOS/Windows systems.
2612
2613 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2614
2615         * rust-lang.c (val_print_struct): Handle printing structures
2616         containing strings.
2617
2618 2019-05-02  Tom Tromey  <tromey@adacore.com>
2619
2620         * valarith.c (_initialize_valarith): Remove.
2621
2622 2019-05-01  Tom Tromey  <tromey@adacore.com>
2623
2624         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2625         bitfields.
2626
2627 2019-05-01  Tom Tromey  <tromey@adacore.com>
2628
2629         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2630         for big-endian copies.
2631
2632 2019-04-30  Ali Tamur  <tamur@google.com>
2633         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2634         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2635         (read_3_bytes): New function.
2636
2637 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2638
2639         * windows-nat.c (main_thread_id): Delete.
2640         (handle_output_debug_string): Replace main_thread_id by
2641         current_event.dwThreadId.
2642         (fake_create_process): Likewise.
2643         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2644         Do not set main_thread_id.
2645         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2646         current_event.dwThreadId.
2647         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2648
2649 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2650
2651         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2652         Use current_event.dwThreadId instead of main_thread_id.
2653
2654 2019-04-30  Tom Tromey  <tromey@adacore.com>
2655
2656         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2657         (create_excep_cond_exprs): Iterate over program spaces.
2658         (ada_exception_catchpoint_cond_string): Examine all minimal
2659         symbols for exception types.
2660
2661 2019-04-30  Tom Tromey  <tromey@adacore.com>
2662
2663         PR c++/24470:
2664         * dwarf2read.c (process_structure_scope): Handle case where type
2665         has template parameters but no symbol was created.
2666
2667 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2668             Chris January  <chris.january@arm.com>
2669
2670         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2671         qualifier.
2672         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2673
2674 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2675
2676         * f-typeprint.c (f_print_type): Update rules for printing
2677         whitespace.
2678         (f_type_print_varspec_suffix): Likewise.
2679
2680 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2681             Chris January  <chris.january@arm.com>
2682
2683         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2684         function arguments.
2685
2686 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2687
2688         * f-lang.c (build_fortran_types): Change name of void type to
2689         lower case.
2690         * f-typeprint.c (f_type_print_base): Print the name of the void
2691         type, rather than a fixed string.
2692         * f-valprint.c (f_decorations): Use lower case void string.
2693
2694 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2695             Chris January  <chris.january@arm.com>
2696
2697         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2698         types for Fortran.
2699
2700 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2701             Chris January  <chris.january@arm.com>
2702             David Lecomber  <david.lecomber@arm.com>
2703
2704         * f-exp.y (BINOP_INTRINSIC): New token.
2705         (exp): New parser rule handling BINOP_INTRINSIC.
2706         (f77_keywords): Add new builtin procedures.
2707         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2708         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2709         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2710         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2711         (print_unop_subexp_f): New function.
2712         (print_binop_subexp_f): New function.
2713         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2714         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2715         (dump_subexp_body_f): Likewise.
2716         (operator_check_f): Likewise.
2717         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2718         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2719
2720 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2721
2722         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2723         UNOP_KIND.
2724         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2725         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2726         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2727         (operator_length_f): New fuction.
2728         (print_subexp_f): New function.
2729         (op_name_f): New function.
2730         (dump_subexp_body_f): New function.
2731         (operator_check_f): New function.
2732         (exp_descriptor_f): Replace standard expression handling functions
2733         with new functions.
2734         * gdb/fortran-operator.def: New file.
2735         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2736         * gdb/std-operator.def: Remove UNOP_KIND.
2737
2738 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2739
2740         * std-operator.def: Remove unbalanced, stray double quote
2741         character.
2742
2743 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2744             Chris January  <chris.january@arm.com>
2745             Daniel Everett  <daniel.everett@arm.com>
2746             Nick Forrington  <nick.forrington@arm.com>
2747             Richard Bunt  <richard.bunt@arm.com>
2748
2749         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2750         of depth when printing anonymous structs or unions.
2751         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2752         Don't print either the top-level value, or the children if the
2753         max-depth is exceeded.
2754         (ppscm_print_children): When printing the key of a map, allow one
2755         extra level of depth.
2756         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2757         print either the top-level value, or the children if the max-depth
2758         is exceeded.
2759         (print_children): When printing the key of a map, allow one extra
2760         level of depth.
2761         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2762         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2763         (user_print_options): Initialise max_depth field.
2764         (val_print_scalar_or_string_type_p): New function.
2765         (val_print): Check to see if the max depth has been reached.
2766         (val_print_check_max_depth): Define new function.
2767         (show_print_max_depth): New function.
2768         (_initialize_valprint): Add 'print max-depth' option.
2769         * valprint.h (struct value_print_options) <max_depth>: New field.
2770         (val_print_check_max_depth): Declare new function.
2771         * NEWS: Document new feature.
2772
2773 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2774
2775         * ada-lang.c (ada_language_defn): Initialise new field.
2776         * c-lang.c (c_is_string_type_p): New function.
2777         (c_language_defn): Initialise new field.
2778         (cplus_language_defn): Initialise new field.
2779         (asm_language_defn): Initialise new field.
2780         (minimal_language_defn): Initialise new field.
2781         * c-lang.h (c_is_string_type_p): Declare new function.
2782         * d-lang.c (d_language_defn): Initialise new field.
2783         * f-lang.c (f_is_string_type_p): New function.
2784         (f_language_defn): Initialise new field.
2785         * go-lang.c (go_is_string_type_p): New function.
2786         (go_language_defn): Initialise new field.
2787         * language.c (default_is_string_type_p): New function.
2788         (unknown_language_defn): Initialise new field.
2789         (auto_language_defn): Initialise new field.
2790         * language.h (struct language_defn) <la_is_string_type_p>: New
2791         member variable.
2792         (default_is_string_type_p): Declare new function.
2793         * m2-lang.c (m2_language_defn): Initialise new field.
2794         * objc-lang.c (objc_language_defn): Initialise new field.
2795         * opencl-lang.c (opencl_language_defn): Initialise new field.
2796         * p-lang.c (pascal_is_string_type_p): New function.
2797         (pascal_language_defn): Initialise new field.
2798         * rust-lang.c (rust_is_string_type_p): New function.
2799         (rust_language_defn): Initialise new field.
2800
2801 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2802
2803         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2804         New field.
2805         * ada-lang.c (ada_language_defn): Initialise new field.
2806         * c-lang.c (c_language_defn): Likewise.
2807         (cplus_language_defn): Likewise.
2808         (asm_language_defn): Likewise.
2809         (minimal_language_defn): Likewise.
2810         * d-lang.c (d_language_defn): Likewise.
2811         * f-lang.c (f_language_defn): Likewise.
2812         * go-lang.c (go_language_defn): Likewise.
2813         * language.c (unknown_language_defn): Likewise.
2814         (auto_language_defn): Likewise.
2815         * m2-lang.c (m2_language_defn): Likewise.
2816         * objc-lang.c (objc_language_defn): Likewise.
2817         * opencl-lang.c (opencl_language_defn): Likewise.
2818         * p-lang.c (pascal_language_defn): Likewise.
2819         * rust-lang.c (rust_language_defn): Likewise.
2820
2821 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2822
2823         * ada-lang.c (ada_is_character_type): Change return type to bool.
2824         (ada_is_string_type): Likewise.
2825         * ada-lang.h (ada_is_character_type): Update declaration
2826         (ada_is_string_type): Likewise.
2827
2828 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2829
2830         Support style in 'frame|thread apply'
2831
2832         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2833         * record.c (record_start, record_stop): Update callers of
2834         execute_command_to_string with false.
2835         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2836         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2837         methods.
2838         (class string_file): New constructor with term_out parameter.
2839         Override methods term_out and can_emit_style_escape.  New member
2840         term_out.
2841         (class stdio_file): Override can_emit_style_escape.
2842         (class tee_file): Override term_out and can_emit_style_escape.
2843         * utils.h (can_emit_style_escape): Remove.
2844         * utils.c (can_emit_style_escape): Likewise.
2845         Update all callers of can_emit_style_escape (SOMESTREAM) to
2846         SOMESTREAM->can_emit_style_escape.
2847         * source-cache.c (source_cache::get_source_lines): Likewise.
2848         * stack.c (frame_apply_command_count): Call execute_command_to_string
2849         passing the term_out characteristic of the current gdb_stdout.
2850         * thread.c (thr_try_catch_cmd): Likewise.
2851         * top.c (execute_command_to_string): pass term_out parameter
2852         to construct the string_file for the command output.
2853         * ui-file.c (term_cli_styling): New function (most code moved
2854         from utils.c can_emit_style_escape).
2855         (string_file::string_file, string_file::can_emit_style_escape,
2856         stdio_file::can_emit_style_escape, tee_file::term_out,
2857         tee_file::can_emit_style_escape): New functions.
2858
2859 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2860
2861         * NEWS: Mention the new set|show may-call-functions.
2862         * infcall.c (may_call_functions_p): New variable.
2863         (show_may_call_functions_p): New function.
2864         (call_function_by_hand_dummy): Throws an error if not
2865         may-call-functions.
2866         (_initialize_infcall): Call add_setshow_boolean_cmd for
2867         may-call-functions.
2868
2869 2019-04-25  Keith Seitz  <keiths@redhat.com>
2870
2871         PR c++/24367
2872         * cp-support.c (inspect_type): Don't attempt substitutions
2873         of symbol with the same name.
2874
2875 2019-04-25  Tom Tromey  <tromey@adacore.com>
2876
2877         PR gdb/24475:
2878         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2879         static.
2880
2881 2019-04-25  Tom Tromey  <tromey@adacore.com>
2882
2883         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2884         rvalue reference.
2885         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2886         (gdb_xml_parser::parse): Use std::move.
2887         * python/python-internal.h (gdbpy_convert_exception): Take a const
2888         reference.
2889         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2890         std::move.
2891         * python/py-utils.c (gdbpy_convert_exception): Take a const
2892         reference.
2893         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2894         Use std::move.
2895         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2896         Use std::move.
2897         * mi/mi-main.c (mi_print_exception): Take a const reference.
2898         * main.c (handle_command_errors): Take a const reference.
2899         * linespec.c (parse_linespec): Use std::move.
2900         * infcall.c (run_inferior_call): Use std::move.
2901         (call_function_by_hand_dummy): Use std::move.
2902         * exec.c (try_open_exec_file): Use std::move.
2903         * exceptions.h (exception_print, exception_fprintf)
2904         (exception_print_same): Update.
2905         * exceptions.c (print_exception, exception_print)
2906         (exception_fprintf, exception_print_same): Change parameters to
2907         const reference.
2908         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2909         * common/new-op.c: Use std::move.
2910         * common/common-exceptions.h (struct gdb_exception): Add move
2911         constructor.
2912         (struct gdb_exception_error, struct gdb_exception_quit, struct
2913         gdb_quit_bad_alloc): Change constructor to move constructor.
2914         (throw_exception): Change parameter to rvalue reference.
2915         * common/common-exceptions.c (throw_exception): Take rvalue
2916         reference.
2917         * cli/cli-interp.c (safe_execute_command): Use std::move.
2918         * breakpoint.c (insert_bp_location, location_to_sals): Use
2919         std::move.
2920
2921 2019-04-25  Tom Tromey  <tromey@adacore.com>
2922
2923         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2924         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2925         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2926         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2927         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2928         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2929         guile/scm-value.c: Use unpack.
2930         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2931         gdbscm_gdb_exception.
2932         (gdbscm_throw_gdb_exception): Likewise.
2933         (struct gdbscm_gdb_exception): New.
2934         (unpack): New function.
2935         (gdbscm_wrap): Use unpack.
2936
2937 2019-04-25  Tom Tromey  <tromey@adacore.com>
2938
2939         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2940         (gdb_rl_callback_handler): Use std::move.
2941         * common/common-exceptions.h (struct gdb_exception): Add move
2942         assignment operator.
2943         (throw_exception_sjlj): Change "exception" to const reference.
2944         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2945         (throw_exception_sjlj): Change "exception" to const reference.
2946
2947 2019-04-25  Tom Tromey  <tromey@adacore.com>
2948
2949         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2950         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2951         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2952         Update.
2953         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2954         Update.
2955         * mi/mi-interp.c (mi_interp::exec): Update.
2956         * linespec.c (parse_linespec): Update.
2957         * infcall.c (run_inferior_call): Update.
2958         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2959         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2960         (gdbscm_lookup_global_symbol): Update.
2961         * guile/scm-param.c (gdbscm_parameter_value): Update.
2962         * guile/scm-frame.c (gdbscm_frame_read_register)
2963         (gdbscm_frame_read_var): Update.
2964         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2965         * exec.c (try_open_exec_file): Update.
2966         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2967         (gdb_rl_callback_handler): Update.
2968         * common/common-exceptions.h (exception_none): Don't declare.
2969         * common/common-exceptions.c (exception_none): Don't define.
2970         (struct catcher) <exception>: Update.
2971         * cli/cli-interp.c (safe_execute_command): Update.
2972         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2973
2974 2019-04-25  Ali Tamur  <tamur@google.com>
2975
2976         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2977         (read_attribute_value): Likewise.
2978         (dwarf2_read_addr_index): Update comment.
2979         (read_str_index): Add DW_FORM_strx.
2980         (dwarf2_string_attr): Likewise.
2981         (dwarf2_const_value_attr): Likewise.
2982         (dump_die_shallow): Likewise.
2983         (dwarf2_fetch_constant_bytes): Likewise.
2984         (skip_form_bytes): Likewise.
2985         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2986
2987 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2988
2989         PR corefiles/11608
2990         PR corefiles/18187
2991         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2992         OFFSET.  Verify if current mapping contains an ELF header.
2993         (linux_find_memory_regions_full): Adjust call to
2994         dump_mapping_p.
2995
2996 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2997             Kang Li <kanglictf@gmail.com>
2998
2999         PR gdb/21600
3000
3001         * dwarf2-frame.c (read_initial_length): Be consistent about using
3002         unsigned representation of length.
3003         (decode_frame_entry_1): Likewise.  Check for wraparound of
3004         end pointer as well as buffer overflow.
3005
3006 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3007
3008         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3009         "vq".
3010
3011 2019-04-24  Tom Tromey  <tromey@adacore.com>
3012
3013         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3014
3015 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3016
3017         * s12z-tdep.c (s12z_unwind_pc): Delete.
3018         (s12z_unwind_sp): Delete.
3019         (s12z_gdbarch_init): Don't register deleted functions with
3020         gdbarch.
3021
3022 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3023
3024         * rl78-tdep.c (rl78_unwind_sp): Delete.
3025         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3026
3027 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3028
3029         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3030         (xstormy16_unwind_pc): Delete.
3031         (xstormy16_dummy_id): Delete.
3032         (xstormy16_gdbarch_init): Don't register deleted functions with
3033         gdbarch.
3034
3035 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3036
3037         * vax-tdep.c (vax_unwind_pc): Delete.
3038         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3039
3040 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3041
3042         * v850-tdep.c (v850_unwind_sp): Delete.
3043         (v850_unwind_pc): Delete.
3044         (v850_dummy_id): Delete.
3045         (v850_gdbarch_init): Don't register deleted functions with
3046         gdbarch.
3047
3048 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3049
3050         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3051         (tilegx_unwind_pc): Delete.
3052         (tilegx_unwind_dummy_id): Delete.
3053         (tilegx_gdbarch_init): Don't register deleted functions with
3054         gdbarch.
3055
3056 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3057
3058         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3059         (tic6x_dummy_id): Delete.
3060         (tic6x_gdbarch_init): Don't register deleted functions with
3061         gdbarch.
3062
3063 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3064
3065         * sparc-tdep.c (sparc_unwind_pc): Delete.
3066         (sparc32_gdbarch_init): Don't register deleted function with
3067         gdbarch.
3068
3069 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3070
3071         * sh-tdep.c (sh_unwind_sp): Delete.
3072         (sh_unwind_pc): Delete.
3073         (sh_dummy_id): Delete.
3074         (sh_gdbarch_init): Don't register deleted functions with
3075         gdbarch.
3076
3077 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3078
3079         * score-tdep.c (score_unwind_sp): Delete.
3080         (score_unwind_pc): Delete.
3081         (score_dummy_id): Delete.
3082         (score_gdbarch_init): Don't register deleted functions with
3083         gdbarch.
3084
3085 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3086
3087         * rx-tdep.c (rx_unwind_pc): Delete.
3088         (rx_unwind_sp): Delete.
3089         (rx_dummy_id): Delete.
3090         (rx_gdbarch_init): Don't register deleted functions with
3091         gdbarch.  Update comment.
3092
3093 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3094
3095         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3096         (rs6000_dummy_id): Delete.
3097         (rs6000_gdbarch_init): Don't register deleted functions with
3098         gdbarch.
3099
3100 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3101
3102         * or1k-tdep.c (or1k_dummy_id): Delete.
3103         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3104
3105 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3106
3107         * nios2-tdep.c (nios2_dummy_id): Delete.
3108         (nios2_unwind_sp): Delete.
3109         (nios2_gdbarch_init): Don't register deleted functions with
3110         gdbarch.
3111
3112 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3113
3114         * nds32-tdep.c (nds32_dummy_id): Delete.
3115         (nds32_unwind_pc): Delete.
3116         (nds32_unwind_sp): Delete.
3117         (nds32_gdbarch_init): Don't register deleted functions with
3118         gdbarch.
3119
3120 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3121
3122         * msp430-tdep.c (msp430_unwind_pc): Delete.
3123         (msp430_unwind_sp): Delete.
3124         (msp430_dummy_id): Delete.
3125         (msp430_gdbarch_init): Don't register deleted functions with
3126         gdbarch.
3127
3128 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3129
3130         * moxie-tdep.c (moxie_unwind_sp): Delete.
3131         (moxie_unwind_pc): Delete.
3132         (moxie_dummy_id): Delete.
3133         (moxie_gdbarch_init): Don't register deleted functions with
3134         gdbarch.
3135
3136 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3137
3138         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3139         (mn10300_unwind_pc): Delete.
3140         (mn10300_unwind_sp): Delete.
3141         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3142         mn10300_unwind_sp.
3143         (mn10300_frame_unwind_init): Don't register deleted functions with
3144         gdbarch.
3145
3146 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3147
3148         * mep-tdep.c (mep_unwind_pc): Delete.
3149         (mep_unwind_sp): Delete.
3150         (mep_dummy_id): Delete.
3151         (mep_gdbarch_init): Don't register deleted functions with
3152         gdbarch.
3153
3154 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3155
3156         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3157         (m68hc11_unwind_sp): Delete.
3158         (m68hc11_gdbarch_init): Don't register deleted functions with
3159         gdbarch.
3160
3161 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3162
3163         * m32r-tdep.c (m32r_unwind_sp): Delete.
3164         (m32r_unwind_pc): Delete.
3165         (m32r_dummy_id): Delete.
3166         (m32r_gdbarch_init): Don't register deleted functions with
3167         gdbarch.
3168
3169 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3170
3171         * m32c-tdep.c (m32c_unwind_pc): Delete.
3172         (m32c_unwind_sp): Delete.
3173         (m32c_dummy_id): Delete.
3174         (m32c_gdbarch_init): Don't register deleted functions with
3175         gdbarch.
3176
3177 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3178
3179         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3180         (lm32_unwind_pc): Delete.
3181         (lm32_dummy_id): Delete.
3182         (lm32_gdbarch_init): Don't register deleted functions with
3183         gdbarch.
3184
3185 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3186
3187         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3188         (iq2000_unwind_pc): Delete.
3189         (iq2000_dummy_id): Delete.
3190         (iq2000_gdbarch_init): Don't register deleted functions with
3191         gdbarch.
3192
3193 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3194
3195         * nds32-tdep.c (nds32_type_align): Delete.
3196         (nds32_push_dummy_call): Use type_align instead.
3197
3198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3199
3200         * arm-tdep.c (arm_type_align): Only handle vector override case.
3201         (arm_push_dummy_call): Use type_align.
3202         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3203
3204 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3205
3206         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3207         case.
3208         (pass_on_stack): Use type_align.
3209         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3210         function.
3211
3212 2019-04-23  Tom Tromey  <tromey@adacore.com>
3213
3214         * dwarf2read.c (line_header::file_name_at): Remove unused
3215         overload.
3216
3217 2019-04-23  Tom de Vries  <tdevries@suse.de>
3218
3219         PR gdb/24438
3220         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3221         invocation.
3222
3223
3224 2019-03-27  Ali Tamur  <tamur@google.com>
3225
3226         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3227         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3228         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3229         (dwarf_expr_context::get_addr_index): Likewise
3230         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3231         (symbol_needs_eval_context::get_addr_index): Likewise
3232         (disassemble_dwarf_expression): Add DW_OP_addrx
3233         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3234         (read_cutu_die_from_dwo): Update comment
3235         (skip_one_die): Add DW_FORM_addrx
3236         (read_attribute_value): Likewise
3237         (var_decode_location): Add DW_OP_addrx
3238         (dwarf2_const_value_attr): Add DW_FORM_addrx
3239         (dump_die_shallow): Likewise
3240         (dwarf2_fetch_constant_bytes): Likewise
3241         (decode_locdesc): Add DW_OP_addrx
3242         (skip_form_bytes): Add DW_FORM_addrx
3243
3244 2019-04-22  Ali Tamur  <tamur@google.com>
3245
3246         * MAINTAINERS (Write After Approval): Add self.
3247
3248 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3249
3250         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3251         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3252         (open_symbol_file_object): Likewise.
3253         (svr4_default_sos): Add info parameter.
3254         (svr4_read_so_list): Likewise.
3255         (svr4_current_sos_direct): Adjust functions calls to pass down
3256         info.
3257         (svr4_current_sos_1): Add info parameter.
3258         (svr4_current_sos): Call get_svr4_info, pass info down to
3259         svr4_current_sos_1.
3260         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3261         get_svr4_info.
3262         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3263         get_svr4_info.
3264         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3265         to get_svr4_info.
3266         (probes_table_remove_objfile_probes): Likewise.
3267         (register_solib_event_probe): Add info parameter.
3268         (solist_update_incremental): Pass info parameter down to
3269         svr4_read_so_list.
3270         (disable_probes_interface): Add info parameter.
3271         (svr4_handle_solib_event): Pass current_program_space to
3272         get_svr4_info.  Adjust disable_probes_interface cleanup.
3273         (svr4_create_probe_breakpoints): Add info parameter, pass it
3274         down to register_solib_event_probe.
3275         (svr4_create_solib_event_breakpoints): Add info parameter,
3276         pass it down to svr4_create_probe_breakpoints.
3277         (enable_break): Pass info down to
3278         svr4_create_solib_event_breakpoints.
3279         (svr4_solib_create_inferior_hook): Pass current_program_space to
3280         get_svr4_info.
3281         (svr4_clear_solib): Likewise.
3282
3283 2019-04-22  Pedro Alves  <palves@redhat.com>
3284
3285         * solib-svr4.c (svr4_free_objfile_observer): New.
3286         (probe_and_action::objfile): New field.
3287         (probes_table_htab_remove_objfile_probes)
3288         (probes_table_remove_objfile_probes): New functions.
3289         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3290         in the new probe_and_action.  Don't store the probe in 'lookup'.
3291         (svr4_create_probe_breakpoints): Pass objfile to
3292         register_solib_event_probe.
3293         (_initialize_svr4_solib): Register a free_objfile observer.
3294
3295 2019-04-19  Tom Tromey  <tom@tromey.com>
3296
3297         * common/queue.h: Remove.
3298
3299 2019-04-19  Tom Tromey  <tom@tromey.com>
3300
3301         * event-loop.c: Don't include "common/queue.h".
3302
3303 2019-04-19  Tom Tromey  <tom@tromey.com>
3304
3305         * remote.c (remote_target): Use delete.
3306         * remote-notif.h: Include <list>, not "common/queue.h".
3307         (notif_client_p): Remove typedef.
3308         (remote_notif_state): Add constructor, destructor, initializer.
3309         <notif_queue>: Now a std::list.
3310         (remote_notif_state_xfree): Don't declare.
3311         * remote-notif.c (remote_notif_process, handle_notification)
3312         (remote_notif_state_allocate): Update.
3313         (~remote_notif_state): Rename from remote_notif_state_xfree.
3314
3315 2019-04-19  Tom Tromey  <tom@tromey.com>
3316
3317         * symfile.c (reread_symbols): Update.
3318         * objfiles.c (objfile_register_static_link)
3319         (objfile_lookup_static_link): Update
3320         (~objfile) Don't delete static_links.
3321         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3322
3323 2019-04-19  Tom Tromey  <tom@tromey.com>
3324
3325         * type-stack.h (struct type_stack) <insert>: Constify string.
3326         * type-stack.c (type_stack::insert): Constify string.
3327         * gdbtypes.h (lookup_template_type): Update.
3328         (address_space_name_to_int): Update.
3329         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3330         const.
3331         (lookup_template_type): Make name const.
3332         * c-exp.y: Update rules.
3333         (lex_one_token, classify_name, classify_inner_name)
3334         (c_print_token): Update.
3335         * p-exp.y: Update rules.
3336         (yylex): Update.
3337         * f-exp.y: Update rules.
3338         (yylex): Update.
3339         * d-exp.y: Update rules.
3340         (lex_one_token, classify_name, classify_inner_name): Update.
3341         * parse.c (write_dollar_variable, copy_name): Return std::string.
3342         * parser-defs.h (copy_name): Change return type.
3343         * m2-exp.y: Update rules.
3344         (yylex): Update.
3345         * go-exp.y (lex_one_token): Update.
3346         Update rules.
3347         (classify_unsafe_function, classify_packaged_name)
3348         (classify_name, yylex): Update.
3349
3350 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3351
3352         * configure.ac: add --enable-source-highlight switch.
3353         * configure: Regenerate.
3354         * top.c (print_gdb_version): plumb --enable-source-highlight
3355         status to "show configuration".
3356
3357 2019-04-19  Tom Tromey  <tromey@adacore.com>
3358
3359         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3360         Check ADA_TYPE_P.
3361         (empty_record, ada_template_to_fixed_record_type_1)
3362         (template_to_static_fixed_type)
3363         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3364         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3365         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3366         macros.
3367
3368 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3369
3370         PR symtab/24423:
3371         * source.c (print_source_lines_base): Advance "iter" when a
3372         control character is seen.
3373
3374 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3375
3376         * inferior.h (struct infcall_suspend_state_deleter):
3377         Catch exception in destructor to avoid crash.
3378
3379 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3380
3381         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3382         close to the add_com "shell".
3383
3384 2019-04-18  Tom Tromey  <tromey@adacore.com>
3385
3386         * process-stratum-target.h (class process_stratum_target)
3387         <stratum>: Add "final".
3388
3389 2019-04-17  Tom Tromey  <tromey@adacore.com>
3390
3391         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3392         against nullptr before use.
3393
3394 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3395
3396         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3397
3398 2019-04-17  Jim Wilson  <jimw@sifive.com>
3399             Andrew Burgess  <andrew.burgess@embecosm.com>
3400
3401         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3402         code read might fail, assume 4-byte breakpoint in that case.
3403
3404 2019-04-15  Leszek Swirski  <leszeks@google.com>
3405
3406         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3407         rather than a hand-rolled POD check when checking for forced MEMORY
3408         classification.
3409
3410 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3411
3412         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3413         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3414         function.
3415         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3416         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3417         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3418         declaration.
3419
3420 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3421
3422         * aarch64-linux-nat.c
3423         (aarch64_linux_nat_target::thread_architecture): Add override.
3424         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3425         each VQ.
3426
3427 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3428
3429         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3430
3431 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3432
3433         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3434         target types of size 96-bits, add some additional comments, and
3435         check that the builtin type we found was the correct size.
3436
3437 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3438
3439         * utils.c (prompt_for_continue): Don't restore the styling at the
3440         end, as applied_style has the wrong value.  This fixes styling in
3441         long lists of file names that are interrupted by the "Continue?"
3442         prompt.
3443
3444 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3445
3446         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3447         * c-lang.c (c_language_defn): Likewise.
3448         (cplus_language_defn): Likewise.
3449         (asm_language_defn): Likewise.
3450         (minimal_language_defn): Likewise.
3451         * d-lang.c (d_language_defn): Likewise.
3452         * f-lang.c (f_language_defn): Likewise.
3453         * go-lang.c (go_language_defn): Likewise.
3454         * language.c (unknown_language_defn): Likewise.
3455         (auto_language_defn): Likewise.
3456         * language.h (struct language_defn): Remove la_magic field.
3457         (LANG_MAGIC): Delete.
3458         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3459         * objc-lang.c (objc_language_defn): Likewise.
3460         * opencl-lang.c (opencl_language_defn): Likewise.
3461         * p-lang.c (pascal_language_defn): Likewise.
3462         * rust-lang.c (rust_language_defn): Likewise.
3463
3464 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3465
3466         * riscv-tdep.c (riscv_type_align): New function.
3467         (riscv_type_alignment): Delete.
3468         (riscv_arg_location): Use 'type_align'.
3469         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3470
3471 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3472
3473         * gdbtypes.c (type_align): A struct with no non-static fields also
3474         has alignment of 1.
3475
3476 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3477
3478         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3479         component to 0.
3480         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3481         member.
3482         (riscv_struct_info::analyse): New implementation using new
3483         analyse_inner member function.
3484         (riscv_struct_info::field_offset): New member function.
3485         (riscv_struct_info::m_offsets): New member variable.
3486         (riscv_struct_info::analyse_inner): New private member function,
3487         takes the old implementation of riscv_struct_info::analyse but
3488         extended to track field offsets.
3489         (riscv_call_arg_struct): Update the struct folding special cases
3490         to handle cases where empty C++ structs, which are non-zero
3491         length, are found.
3492         (riscv_arg_location): Initialise the length of each location, a
3493         non-zero length now indicates the location is in use.
3494         (riscv_push_dummy_call): Allow for the first location having a
3495         non-zero offset when setting up arguments.
3496         (riscv_return_value): Likewise, but for return values.
3497
3498 2019-04-11  Tom Tromey  <tromey@adacore.com>
3499
3500         * utils.c (internal_vproblem): Make "msg" const.
3501
3502 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3503
3504         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3505         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3506         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3507         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3508
3509 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3510
3511         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3512         function.
3513         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3514         of amd64_collect_native_gregset.
3515         (amd64_linux_nat_target::store_registers): Likewise.
3516
3517 2019-04-10  Tom Tromey  <tom@tromey.com>
3518
3519         * symtab.c (lookup_global_symbol_from_objfile)
3520         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3521         * objfiles.h (class separate_debug_iterator): New.
3522         (class separate_debug_range): New.
3523         (struct objfile) <separate_debug_objfiles>: New method.
3524         (objfile_separate_debug_iterate): Don't declare.
3525         * objfiles.c (separate_debug_iterator::operator++): Rename from
3526         objfile_separate_debug_iterate.
3527         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3528         iterator.
3529         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3530         iterator.
3531
3532 2019-04-10  Tom Tromey  <tom@tromey.com>
3533
3534         * symfile.c (reread_symbols): Remove old comment.
3535         * objfiles.c (free_all_objfiles): Fix a typo.
3536
3537 2019-04-10  Tom Tromey  <tom@tromey.com>
3538
3539         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3540         * minsyms.c (lookup_minimal_symbol): Use foreach.
3541         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3542         (lookup_minimal_symbol_solib_trampoline): Likewise.
3543         * symfile.c (reread_symbols): Use foreach.
3544
3545 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3546             Tom Tromey  <tromey@adacore.com>
3547
3548         PR rust/24414:
3549         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3550         (rust_lex_int_test): Change "value" to be LONGEST.
3551         (rust_lex_tests): Add test for long integer literal.
3552
3553 2019-04-09  Tom Tromey  <tromey@adacore.com>
3554
3555         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3556         to bool.
3557         (extended_remote_target::attach): Update.
3558         (remote_target::remote_notice_new_inferior): Update.
3559         (remote_target::add_current_inferior_and_thread): Update.
3560         * inferior.c (exit_inferior_1): Use "false".
3561         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3562
3563 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3564
3565         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3566         the "start" command.
3567
3568 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3569
3570         * python/py-inferior.c (infpy_thread_from_thread_handle):
3571         Adjust comments to reflect renaming of thread_from_thread_handle
3572         to thread_from_handle.  Adjust keywords.  Fix type error message.
3573         (inferior_object_methods): Add thread_from_handle.  Retain
3574         thread_from_thread_handle, but mark it as deprecated.
3575
3576 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3577
3578         * gdbthread.h (find_thread_by_handle): Revise declaration.
3579         * thread.c (find_thread_by_handle): Likewise.  Adjust
3580         implementation too.
3581         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3582         support for buffer objects as handles.
3583
3584 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3585
3586         * python/py-infthread.c (thpy_thread_handle): New function.
3587         (thread_object_methods): Register thpy_thread_handle.
3588
3589 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3590
3591         * gdbthread.h (thread_to_thread_handle): Declare.
3592         * thread.c (gdbtypes.h): Include.
3593         (thread_to_thread_handle): New function.
3594
3595         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3596         (target_thread_info_to_thread_handle): Declare.
3597         * target.c (target_thread_info_to_thread_handle): New function.
3598         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3599         * target-delegates.c: Regenerate.
3600
3601         * linux-thread-db.c (class thread_db_target): Add method
3602         thread_info_to_thread_handle.
3603         (thread_db_target::thread_info_to_thread_handle): Define.
3604         * remote.c (class remote_target): Add new method
3605         thread_info_to_thread_handle.
3606         (remote_target::thread_info_to_thread_handle): Define.
3607
3608 2019-04-08  Pedro Alves  <palves@redhat.com>
3609
3610         * common/common-exceptions.c (throw_exception): Don't create
3611         named object to throw; throw directly.
3612         (throw_it): Likewise.  Don't initialize gdb_exception::message
3613         here, with new; pass FMT and AP to the ctor instead.
3614         * common/common-exceptions.h: Include <string>.
3615         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3616         const char *, va_list)): New ctor.  Use std::make_shared.
3617         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3618         errors)): Delete.
3619         (gdb_exception_error::gdb_exception_error(enum errors, const char
3620         *, va_list)): New.
3621         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3622         Add assertion.
3623         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3624         errors)): Delete.
3625         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3626         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3627         Add assertion.
3628
3629 2019-04-08  Tom Tromey  <tom@tromey.com>
3630
3631         * valops.c (value_rtti_indirect_type): Replace throw_exception
3632         with throw.
3633         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3634         with throw.
3635         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3636         throw.
3637         * target.c (target_translate_tls_address): Replace throw_exception
3638         with throw.
3639         * stack.c (frame_apply_command_count): Replace throw_exception
3640         with throw.
3641         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3642         throw.
3643         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3644         with throw.
3645         * rs6000-tdep.c (rs6000_frame_cache)
3646         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3647         * remote.c: Replace throw_exception with throw.
3648         * record-full.c (record_full_message, record_full_wait_1)
3649         (record_full_restore): Replace throw_exception with throw.
3650         * record-btrace.c:
3651         (get_thread_current_frame_id, record_btrace_start_replaying)
3652         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3653         (cmd_record_btrace_start): Replace throw_exception with throw.
3654         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3655         throw.
3656         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3657         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3658         * linespec.c:
3659         (find_linespec_symbols): Replace throw_exception with throw.
3660         * infrun.c (displaced_step_prepare, resume): Replace
3661         throw_exception with throw.
3662         * infcmd.c (post_create_inferior): Replace throw_exception with
3663         throw.
3664         * inf-loop.c (inferior_event_handler): Replace throw_exception
3665         with throw.
3666         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3667         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3668         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3669         (get_prev_frame_always, get_frame_pc_if_available)
3670         (get_frame_address_in_block_if_available, get_frame_language):
3671         Replace throw_exception with throw.
3672         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3673         throw_exception with throw.
3674         * eval.c (fetch_subexp_value, evaluate_var_value)
3675         (evaluate_funcall, evaluate_subexp_standard): Replace
3676         throw_exception with throw.
3677         * dwarf2loc.c (call_site_find_chain)
3678         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3679         Replace throw_exception with throw.
3680         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3681         with throw.
3682         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3683         throw.
3684         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3685         * completer.c (complete_line_internal): Replace throw_exception
3686         with throw.
3687         * compile/compile-object-run.c (compile_object_run): Replace
3688         throw_exception with throw.
3689         * cli/cli-script.c (process_next_line): Replace throw_exception
3690         with throw.
3691         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3692         (btrace_enable, btrace_maint_update_pt_packets): Replace
3693         throw_exception with throw.
3694         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3695         throw_exception with throw.
3696         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3697         throw_exception with throw.
3698         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3699         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3700         * aarch64-tdep.c (aarch64_make_prologue_cache)
3701         (aarch64_make_stub_cache): Replace throw_exception with throw.
3702
3703 2019-04-08  Tom Tromey  <tom@tromey.com>
3704
3705         * common/common-exceptions.c (throw_exception): Rename from
3706         throw_exception_cxx.  Remove old copy.  Make argument const.
3707         (throw_it): Create and throw exception objects directly.
3708         * common/common-exceptions.h (throw_exception): Make argument
3709         const.
3710         (struct gdb_exception_error): Add constructor.
3711         (struct gdb_exception_quit): Add constructor.
3712
3713 2019-04-08  Tom Tromey  <tom@tromey.com>
3714
3715         * common/common-exceptions.h (exception_rethrow): Don't declare.
3716         (TRY_SJLJ): Update comment.
3717         (TRY, CATCH, END_CATCH): Remove.
3718         * common/common-exceptions.c (exception_rethrow): Remove.
3719
3720 2019-04-08  Tom Tromey  <tom@tromey.com>
3721
3722         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3723         Remove.
3724         (gdb_exception_error): Rename from
3725         gdb_exception_RETURN_MASK_ERROR.
3726         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3727         (gdb_quit_bad_alloc): Update.
3728         * aarch64-tdep.c: Update.
3729         * ada-lang.c: Update.
3730         * ada-typeprint.c: Update.
3731         * ada-valprint.c: Update.
3732         * amd64-tdep.c: Update.
3733         * arch-utils.c: Update.
3734         * break-catch-throw.c: Update.
3735         * breakpoint.c: Update.
3736         * btrace.c: Update.
3737         * c-varobj.c: Update.
3738         * cli/cli-cmds.c: Update.
3739         * cli/cli-interp.c: Update.
3740         * cli/cli-script.c: Update.
3741         * common/common-exceptions.c: Update.
3742         * common/new-op.c: Update.
3743         * common/selftest.c: Update.
3744         * compile/compile-c-symbols.c: Update.
3745         * compile/compile-cplus-symbols.c: Update.
3746         * compile/compile-object-load.c: Update.
3747         * compile/compile-object-run.c: Update.
3748         * completer.c: Update.
3749         * corelow.c: Update.
3750         * cp-abi.c: Update.
3751         * cp-support.c: Update.
3752         * cp-valprint.c: Update.
3753         * darwin-nat.c: Update.
3754         * disasm-selftests.c: Update.
3755         * dtrace-probe.c: Update.
3756         * dwarf-index-cache.c: Update.
3757         * dwarf-index-write.c: Update.
3758         * dwarf2-frame-tailcall.c: Update.
3759         * dwarf2-frame.c: Update.
3760         * dwarf2loc.c: Update.
3761         * dwarf2read.c: Update.
3762         * eval.c: Update.
3763         * event-loop.c: Update.
3764         * event-top.c: Update.
3765         * exec.c: Update.
3766         * f-valprint.c: Update.
3767         * fbsd-tdep.c: Update.
3768         * frame-unwind.c: Update.
3769         * frame.c: Update.
3770         * gdbtypes.c: Update.
3771         * gnu-v3-abi.c: Update.
3772         * guile/guile-internal.h: Update.
3773         * guile/scm-block.c: Update.
3774         * guile/scm-breakpoint.c: Update.
3775         * guile/scm-cmd.c: Update.
3776         * guile/scm-disasm.c: Update.
3777         * guile/scm-frame.c: Update.
3778         * guile/scm-lazy-string.c: Update.
3779         * guile/scm-math.c: Update.
3780         * guile/scm-param.c: Update.
3781         * guile/scm-ports.c: Update.
3782         * guile/scm-pretty-print.c: Update.
3783         * guile/scm-symbol.c: Update.
3784         * guile/scm-symtab.c: Update.
3785         * guile/scm-type.c: Update.
3786         * guile/scm-value.c: Update.
3787         * i386-linux-tdep.c: Update.
3788         * i386-tdep.c: Update.
3789         * inf-loop.c: Update.
3790         * infcall.c: Update.
3791         * infcmd.c: Update.
3792         * infrun.c: Update.
3793         * jit.c: Update.
3794         * language.c: Update.
3795         * linespec.c: Update.
3796         * linux-fork.c: Update.
3797         * linux-nat.c: Update.
3798         * linux-tdep.c: Update.
3799         * linux-thread-db.c: Update.
3800         * main.c: Update.
3801         * mi/mi-cmd-break.c: Update.
3802         * mi/mi-cmd-stack.c: Update.
3803         * mi/mi-interp.c: Update.
3804         * mi/mi-main.c: Update.
3805         * objc-lang.c: Update.
3806         * p-valprint.c: Update.
3807         * parse.c: Update.
3808         * ppc-linux-tdep.c: Update.
3809         * printcmd.c: Update.
3810         * python/py-arch.c: Update.
3811         * python/py-breakpoint.c: Update.
3812         * python/py-cmd.c: Update.
3813         * python/py-finishbreakpoint.c: Update.
3814         * python/py-frame.c: Update.
3815         * python/py-framefilter.c: Update.
3816         * python/py-gdb-readline.c: Update.
3817         * python/py-inferior.c: Update.
3818         * python/py-infthread.c: Update.
3819         * python/py-lazy-string.c: Update.
3820         * python/py-linetable.c: Update.
3821         * python/py-objfile.c: Update.
3822         * python/py-param.c: Update.
3823         * python/py-prettyprint.c: Update.
3824         * python/py-progspace.c: Update.
3825         * python/py-record-btrace.c: Update.
3826         * python/py-record.c: Update.
3827         * python/py-symbol.c: Update.
3828         * python/py-type.c: Update.
3829         * python/py-unwind.c: Update.
3830         * python/py-utils.c: Update.
3831         * python/py-value.c: Update.
3832         * python/python.c: Update.
3833         * record-btrace.c: Update.
3834         * record-full.c: Update.
3835         * remote-fileio.c: Update.
3836         * remote.c: Update.
3837         * riscv-tdep.c: Update.
3838         * rs6000-aix-tdep.c: Update.
3839         * rs6000-tdep.c: Update.
3840         * rust-exp.y: Update.
3841         * rust-lang.c: Update.
3842         * s390-tdep.c: Update.
3843         * selftest-arch.c: Update.
3844         * solib-dsbt.c: Update.
3845         * solib-frv.c: Update.
3846         * solib-spu.c: Update.
3847         * solib-svr4.c: Update.
3848         * solib.c: Update.
3849         * sparc64-linux-tdep.c: Update.
3850         * stack.c: Update.
3851         * symfile-mem.c: Update.
3852         * symmisc.c: Update.
3853         * target.c: Update.
3854         * thread.c: Update.
3855         * top.c: Update.
3856         * tracefile-tfile.c: Update.
3857         * tui/tui.c: Update.
3858         * typeprint.c: Update.
3859         * unittests/cli-utils-selftests.c: Update.
3860         * unittests/parse-connection-spec-selftests.c: Update.
3861         * valops.c: Update.
3862         * valprint.c: Update.
3863         * value.c: Update.
3864         * varobj.c: Update.
3865         * windows-nat.c: Update.
3866         * x86-linux-nat.c: Update.
3867         * xml-support.c: Update.
3868
3869 2019-04-08  Tom Tromey  <tom@tromey.com>
3870
3871         * xml-support.c: Use C++ exception handling.
3872         * x86-linux-nat.c: Use C++ exception handling.
3873         * windows-nat.c: Use C++ exception handling.
3874         * varobj.c: Use C++ exception handling.
3875         * value.c: Use C++ exception handling.
3876         * valprint.c: Use C++ exception handling.
3877         * valops.c: Use C++ exception handling.
3878         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3879         handling.
3880         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3881         * typeprint.c: Use C++ exception handling.
3882         * tui/tui.c: Use C++ exception handling.
3883         * tracefile-tfile.c: Use C++ exception handling.
3884         * top.c: Use C++ exception handling.
3885         * thread.c: Use C++ exception handling.
3886         * target.c: Use C++ exception handling.
3887         * symmisc.c: Use C++ exception handling.
3888         * symfile-mem.c: Use C++ exception handling.
3889         * stack.c: Use C++ exception handling.
3890         * sparc64-linux-tdep.c: Use C++ exception handling.
3891         * solib.c: Use C++ exception handling.
3892         * solib-svr4.c: Use C++ exception handling.
3893         * solib-spu.c: Use C++ exception handling.
3894         * solib-frv.c: Use C++ exception handling.
3895         * solib-dsbt.c: Use C++ exception handling.
3896         * selftest-arch.c: Use C++ exception handling.
3897         * s390-tdep.c: Use C++ exception handling.
3898         * rust-lang.c: Use C++ exception handling.
3899         * rust-exp.y: Use C++ exception handling.
3900         * rs6000-tdep.c: Use C++ exception handling.
3901         * rs6000-aix-tdep.c: Use C++ exception handling.
3902         * riscv-tdep.c: Use C++ exception handling.
3903         * remote.c: Use C++ exception handling.
3904         * remote-fileio.c: Use C++ exception handling.
3905         * record-full.c: Use C++ exception handling.
3906         * record-btrace.c: Use C++ exception handling.
3907         * python/python.c: Use C++ exception handling.
3908         * python/py-value.c: Use C++ exception handling.
3909         * python/py-utils.c: Use C++ exception handling.
3910         * python/py-unwind.c: Use C++ exception handling.
3911         * python/py-type.c: Use C++ exception handling.
3912         * python/py-symbol.c: Use C++ exception handling.
3913         * python/py-record.c: Use C++ exception handling.
3914         * python/py-record-btrace.c: Use C++ exception handling.
3915         * python/py-progspace.c: Use C++ exception handling.
3916         * python/py-prettyprint.c: Use C++ exception handling.
3917         * python/py-param.c: Use C++ exception handling.
3918         * python/py-objfile.c: Use C++ exception handling.
3919         * python/py-linetable.c: Use C++ exception handling.
3920         * python/py-lazy-string.c: Use C++ exception handling.
3921         * python/py-infthread.c: Use C++ exception handling.
3922         * python/py-inferior.c: Use C++ exception handling.
3923         * python/py-gdb-readline.c: Use C++ exception handling.
3924         * python/py-framefilter.c: Use C++ exception handling.
3925         * python/py-frame.c: Use C++ exception handling.
3926         * python/py-finishbreakpoint.c: Use C++ exception handling.
3927         * python/py-cmd.c: Use C++ exception handling.
3928         * python/py-breakpoint.c: Use C++ exception handling.
3929         * python/py-arch.c: Use C++ exception handling.
3930         * printcmd.c: Use C++ exception handling.
3931         * ppc-linux-tdep.c: Use C++ exception handling.
3932         * parse.c: Use C++ exception handling.
3933         * p-valprint.c: Use C++ exception handling.
3934         * objc-lang.c: Use C++ exception handling.
3935         * mi/mi-main.c: Use C++ exception handling.
3936         * mi/mi-interp.c: Use C++ exception handling.
3937         * mi/mi-cmd-stack.c: Use C++ exception handling.
3938         * mi/mi-cmd-break.c: Use C++ exception handling.
3939         * main.c: Use C++ exception handling.
3940         * linux-thread-db.c: Use C++ exception handling.
3941         * linux-tdep.c: Use C++ exception handling.
3942         * linux-nat.c: Use C++ exception handling.
3943         * linux-fork.c: Use C++ exception handling.
3944         * linespec.c: Use C++ exception handling.
3945         * language.c: Use C++ exception handling.
3946         * jit.c: Use C++ exception handling.
3947         * infrun.c: Use C++ exception handling.
3948         * infcmd.c: Use C++ exception handling.
3949         * infcall.c: Use C++ exception handling.
3950         * inf-loop.c: Use C++ exception handling.
3951         * i386-tdep.c: Use C++ exception handling.
3952         * i386-linux-tdep.c: Use C++ exception handling.
3953         * guile/scm-value.c: Use C++ exception handling.
3954         * guile/scm-type.c: Use C++ exception handling.
3955         * guile/scm-symtab.c: Use C++ exception handling.
3956         * guile/scm-symbol.c: Use C++ exception handling.
3957         * guile/scm-pretty-print.c: Use C++ exception handling.
3958         * guile/scm-ports.c: Use C++ exception handling.
3959         * guile/scm-param.c: Use C++ exception handling.
3960         * guile/scm-math.c: Use C++ exception handling.
3961         * guile/scm-lazy-string.c: Use C++ exception handling.
3962         * guile/scm-frame.c: Use C++ exception handling.
3963         * guile/scm-disasm.c: Use C++ exception handling.
3964         * guile/scm-cmd.c: Use C++ exception handling.
3965         * guile/scm-breakpoint.c: Use C++ exception handling.
3966         * guile/scm-block.c: Use C++ exception handling.
3967         * guile/guile-internal.h: Use C++ exception handling.
3968         * gnu-v3-abi.c: Use C++ exception handling.
3969         * gdbtypes.c: Use C++ exception handling.
3970         * frame.c: Use C++ exception handling.
3971         * frame-unwind.c: Use C++ exception handling.
3972         * fbsd-tdep.c: Use C++ exception handling.
3973         * f-valprint.c: Use C++ exception handling.
3974         * exec.c: Use C++ exception handling.
3975         * event-top.c: Use C++ exception handling.
3976         * event-loop.c: Use C++ exception handling.
3977         * eval.c: Use C++ exception handling.
3978         * dwarf2read.c: Use C++ exception handling.
3979         * dwarf2loc.c: Use C++ exception handling.
3980         * dwarf2-frame.c: Use C++ exception handling.
3981         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3982         * dwarf-index-write.c: Use C++ exception handling.
3983         * dwarf-index-cache.c: Use C++ exception handling.
3984         * dtrace-probe.c: Use C++ exception handling.
3985         * disasm-selftests.c: Use C++ exception handling.
3986         * darwin-nat.c: Use C++ exception handling.
3987         * cp-valprint.c: Use C++ exception handling.
3988         * cp-support.c: Use C++ exception handling.
3989         * cp-abi.c: Use C++ exception handling.
3990         * corelow.c: Use C++ exception handling.
3991         * completer.c: Use C++ exception handling.
3992         * compile/compile-object-run.c: Use C++ exception handling.
3993         * compile/compile-object-load.c: Use C++ exception handling.
3994         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3995         * compile/compile-c-symbols.c: Use C++ exception handling.
3996         * common/selftest.c: Use C++ exception handling.
3997         * common/new-op.c: Use C++ exception handling.
3998         * cli/cli-script.c: Use C++ exception handling.
3999         * cli/cli-interp.c: Use C++ exception handling.
4000         * cli/cli-cmds.c: Use C++ exception handling.
4001         * c-varobj.c: Use C++ exception handling.
4002         * btrace.c: Use C++ exception handling.
4003         * breakpoint.c: Use C++ exception handling.
4004         * break-catch-throw.c: Use C++ exception handling.
4005         * arch-utils.c: Use C++ exception handling.
4006         * amd64-tdep.c: Use C++ exception handling.
4007         * ada-valprint.c: Use C++ exception handling.
4008         * ada-typeprint.c: Use C++ exception handling.
4009         * ada-lang.c: Use C++ exception handling.
4010         * aarch64-tdep.c: Use C++ exception handling.
4011
4012 2019-04-08  Tom Tromey  <tom@tromey.com>
4013
4014         * xml-support.c (gdb_xml_parser::parse): Update.
4015         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4016         * value.c (show_convenience): Update.
4017         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4018         (test_parse_flags_qcs): Update.
4019         * thread.c (thr_try_catch_cmd): Update.
4020         * target.c (target_translate_tls_address): Update.
4021         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4022         (info_frame_command_core, frame_apply_command_count): Update.
4023         * rust-exp.y (rust_lex_exception_test): Update.
4024         * riscv-tdep.c (riscv_print_one_register_info): Update.
4025         * remote.c (remote_target::enable_btrace): Update.
4026         * record-btrace.c (record_btrace_enable_warn): Update.
4027         * python/py-utils.c (gdbpy_convert_exception): Update.
4028         * printcmd.c (do_one_display, print_variable_and_value): Update.
4029         * mi/mi-main.c (mi_print_exception): Update.
4030         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4031         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4032         * linux-nat.c (linux_nat_target::attach): Update.
4033         * linux-fork.c (class scoped_switch_fork_info): Update.
4034         * infrun.c (displaced_step_prepare): Update.
4035         * infcall.c (call_function_by_hand_dummy): Update.
4036         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4037         * gnu-v3-abi.c (print_one_vtable): Update.
4038         * frame.c (get_prev_frame_always): Update.
4039         * f-valprint.c (info_common_command_for_block): Update.
4040         * exec.c (try_open_exec_file): Update.
4041         * exceptions.c (print_exception, exception_print)
4042         (exception_fprintf, exception_print_same): Update.
4043         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4044         * dwarf-index-cache.c (index_cache::store)
4045         (index_cache::lookup_gdb_index): Update.
4046         * darwin-nat.c (maybe_cache_shell): Update.
4047         * cp-valprint.c (cp_print_value_fields): Update.
4048         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4049         (gcc_cplus_symbol_address): Update.
4050         * compile/compile-c-symbols.c (gcc_convert_symbol)
4051         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4052         * common/selftest.c: Update.
4053         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4054         a std::string.
4055         (exception_try_scope_entry, exception_try_scope_exit): Don't
4056         declare.
4057         (struct exception_try_scope): Remove.
4058         (TRY): Don't use exception_try_scope.
4059         (struct gdb_exception): Add constructor, operator=.
4060         <what>: New method.
4061         (struct gdb_exception_RETURN_MASK_ALL)
4062         (struct gdb_exception_RETURN_MASK_ERROR)
4063         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4064         (struct gdb_quit_bad_alloc): Update.
4065         * common/common-exceptions.c (exception_none): Change
4066         initializer.
4067         (struct catcher) <state, exception>: Initialize inline.
4068         <prev>: Remove member.
4069         (current_catcher): Remove.
4070         (catchers): New global.
4071         (exceptions_state_mc_init): Simplify.
4072         (catcher_pop): Remove.
4073         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4074         (try_scope_depth, exception_try_scope_entry)
4075         (exception_try_scope_exit): Remove.
4076         (throw_exception_sjlj): Update.
4077         (exception_messages, exception_messages_size): Remove.
4078         (throw_it): Simplify.
4079         (gdb_exception_sliced_copy): Remove.
4080         (throw_exception_cxx): Update.
4081         * cli/cli-script.c (script_from_file): Update.
4082         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4083         Update.
4084         * ada-valprint.c (ada_val_print): Update.
4085         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4086         (create_excep_cond_exprs): Update.
4087
4088 2019-04-08  Tom Tromey  <tom@tromey.com>
4089
4090         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4091         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4092         (TRY, CATCH, END_CATCH): Remove some definitions.
4093         * common/common-exceptions.c: Don't use GDB_XCPT.
4094         (catcher_list_size): Remove.
4095         (throw_exception, throw_it): Simplify.
4096
4097 2019-04-05  Tom Tromey  <tom@tromey.com>
4098
4099         Revert the header-sorting patch.
4100         * ft32-tdep.c: Revert.
4101         * frv-tdep.c: Revert.
4102         * frv-linux-tdep.c: Revert.
4103         * frame.c: Revert.
4104         * frame-unwind.c: Revert.
4105         * frame-base.c: Revert.
4106         * fork-child.c: Revert.
4107         * findvar.c: Revert.
4108         * findcmd.c: Revert.
4109         * filesystem.c: Revert.
4110         * filename-seen-cache.h: Revert.
4111         * filename-seen-cache.c: Revert.
4112         * fbsd-tdep.c: Revert.
4113         * fbsd-nat.h: Revert.
4114         * fbsd-nat.c: Revert.
4115         * f-valprint.c: Revert.
4116         * f-typeprint.c: Revert.
4117         * f-lang.c: Revert.
4118         * extension.h: Revert.
4119         * extension.c: Revert.
4120         * extension-priv.h: Revert.
4121         * expprint.c: Revert.
4122         * exec.h: Revert.
4123         * exec.c: Revert.
4124         * exceptions.c: Revert.
4125         * event-top.c: Revert.
4126         * event-loop.c: Revert.
4127         * eval.c: Revert.
4128         * elfread.c: Revert.
4129         * dwarf2read.h: Revert.
4130         * dwarf2read.c: Revert.
4131         * dwarf2loc.c: Revert.
4132         * dwarf2expr.h: Revert.
4133         * dwarf2expr.c: Revert.
4134         * dwarf2-frame.c: Revert.
4135         * dwarf2-frame-tailcall.c: Revert.
4136         * dwarf-index-write.h: Revert.
4137         * dwarf-index-write.c: Revert.
4138         * dwarf-index-common.c: Revert.
4139         * dwarf-index-cache.h: Revert.
4140         * dwarf-index-cache.c: Revert.
4141         * dummy-frame.c: Revert.
4142         * dtrace-probe.c: Revert.
4143         * disasm.h: Revert.
4144         * disasm.c: Revert.
4145         * disasm-selftests.c: Revert.
4146         * dictionary.c: Revert.
4147         * dicos-tdep.c: Revert.
4148         * demangle.c: Revert.
4149         * dcache.h: Revert.
4150         * dcache.c: Revert.
4151         * darwin-nat.h: Revert.
4152         * darwin-nat.c: Revert.
4153         * darwin-nat-info.c: Revert.
4154         * d-valprint.c: Revert.
4155         * d-namespace.c: Revert.
4156         * d-lang.c: Revert.
4157         * ctf.c: Revert.
4158         * csky-tdep.c: Revert.
4159         * csky-linux-tdep.c: Revert.
4160         * cris-tdep.c: Revert.
4161         * cris-linux-tdep.c: Revert.
4162         * cp-valprint.c: Revert.
4163         * cp-support.c: Revert.
4164         * cp-namespace.c: Revert.
4165         * cp-abi.c: Revert.
4166         * corelow.c: Revert.
4167         * corefile.c: Revert.
4168         * continuations.c: Revert.
4169         * completer.h: Revert.
4170         * completer.c: Revert.
4171         * complaints.c: Revert.
4172         * coffread.c: Revert.
4173         * coff-pe-read.c: Revert.
4174         * cli-out.h: Revert.
4175         * cli-out.c: Revert.
4176         * charset.c: Revert.
4177         * c-varobj.c: Revert.
4178         * c-valprint.c: Revert.
4179         * c-typeprint.c: Revert.
4180         * c-lang.c: Revert.
4181         * buildsym.c: Revert.
4182         * buildsym-legacy.c: Revert.
4183         * build-id.h: Revert.
4184         * build-id.c: Revert.
4185         * btrace.c: Revert.
4186         * bsd-uthread.c: Revert.
4187         * breakpoint.h: Revert.
4188         * breakpoint.c: Revert.
4189         * break-catch-throw.c: Revert.
4190         * break-catch-syscall.c: Revert.
4191         * break-catch-sig.c: Revert.
4192         * blockframe.c: Revert.
4193         * block.c: Revert.
4194         * bfin-tdep.c: Revert.
4195         * bfin-linux-tdep.c: Revert.
4196         * bfd-target.c: Revert.
4197         * bcache.c: Revert.
4198         * ax-general.c: Revert.
4199         * ax-gdb.h: Revert.
4200         * ax-gdb.c: Revert.
4201         * avr-tdep.c: Revert.
4202         * auxv.c: Revert.
4203         * auto-load.c: Revert.
4204         * arm-wince-tdep.c: Revert.
4205         * arm-tdep.c: Revert.
4206         * arm-symbian-tdep.c: Revert.
4207         * arm-pikeos-tdep.c: Revert.
4208         * arm-obsd-tdep.c: Revert.
4209         * arm-nbsd-tdep.c: Revert.
4210         * arm-nbsd-nat.c: Revert.
4211         * arm-linux-tdep.c: Revert.
4212         * arm-linux-nat.c: Revert.
4213         * arm-fbsd-tdep.c: Revert.
4214         * arm-fbsd-nat.c: Revert.
4215         * arm-bsd-tdep.c: Revert.
4216         * arch-utils.c: Revert.
4217         * arc-tdep.c: Revert.
4218         * arc-newlib-tdep.c: Revert.
4219         * annotate.h: Revert.
4220         * annotate.c: Revert.
4221         * amd64-windows-tdep.c: Revert.
4222         * amd64-windows-nat.c: Revert.
4223         * amd64-tdep.c: Revert.
4224         * amd64-sol2-tdep.c: Revert.
4225         * amd64-obsd-tdep.c: Revert.
4226         * amd64-obsd-nat.c: Revert.
4227         * amd64-nbsd-tdep.c: Revert.
4228         * amd64-nbsd-nat.c: Revert.
4229         * amd64-nat.c: Revert.
4230         * amd64-linux-tdep.c: Revert.
4231         * amd64-linux-nat.c: Revert.
4232         * amd64-fbsd-tdep.c: Revert.
4233         * amd64-fbsd-nat.c: Revert.
4234         * amd64-dicos-tdep.c: Revert.
4235         * amd64-darwin-tdep.c: Revert.
4236         * amd64-bsd-nat.c: Revert.
4237         * alpha-tdep.c: Revert.
4238         * alpha-obsd-tdep.c: Revert.
4239         * alpha-nbsd-tdep.c: Revert.
4240         * alpha-mdebug-tdep.c: Revert.
4241         * alpha-linux-tdep.c: Revert.
4242         * alpha-linux-nat.c: Revert.
4243         * alpha-bsd-tdep.c: Revert.
4244         * alpha-bsd-nat.c: Revert.
4245         * aix-thread.c: Revert.
4246         * agent.c: Revert.
4247         * addrmap.c: Revert.
4248         * ada-varobj.c: Revert.
4249         * ada-valprint.c: Revert.
4250         * ada-typeprint.c: Revert.
4251         * ada-tasks.c: Revert.
4252         * ada-lang.c: Revert.
4253         * aarch64-tdep.c: Revert.
4254         * aarch64-ravenscar-thread.c: Revert.
4255         * aarch64-newlib-tdep.c: Revert.
4256         * aarch64-linux-tdep.c: Revert.
4257         * aarch64-linux-nat.c: Revert.
4258         * aarch64-fbsd-tdep.c: Revert.
4259         * aarch64-fbsd-nat.c: Revert.
4260         * aarch32-linux-nat.c: Revert.
4261
4262 2019-04-05  Tom Tromey  <tom@tromey.com>
4263
4264         * ft32-tdep.c: Sort headers.
4265         * frv-tdep.c: Sort headers.
4266         * frv-linux-tdep.c: Sort headers.
4267         * frame.c: Sort headers.
4268         * frame-unwind.c: Sort headers.
4269         * frame-base.c: Sort headers.
4270         * fork-child.c: Sort headers.
4271         * findvar.c: Sort headers.
4272         * findcmd.c: Sort headers.
4273         * filesystem.c: Sort headers.
4274         * filename-seen-cache.h: Sort headers.
4275         * filename-seen-cache.c: Sort headers.
4276         * fbsd-tdep.c: Sort headers.
4277         * fbsd-nat.h: Sort headers.
4278         * fbsd-nat.c: Sort headers.
4279         * f-valprint.c: Sort headers.
4280         * f-typeprint.c: Sort headers.
4281         * f-lang.c: Sort headers.
4282         * extension.h: Sort headers.
4283         * extension.c: Sort headers.
4284         * extension-priv.h: Sort headers.
4285         * expprint.c: Sort headers.
4286         * exec.h: Sort headers.
4287         * exec.c: Sort headers.
4288         * exceptions.c: Sort headers.
4289         * event-top.c: Sort headers.
4290         * event-loop.c: Sort headers.
4291         * eval.c: Sort headers.
4292         * elfread.c: Sort headers.
4293         * dwarf2read.h: Sort headers.
4294         * dwarf2read.c: Sort headers.
4295         * dwarf2loc.c: Sort headers.
4296         * dwarf2expr.h: Sort headers.
4297         * dwarf2expr.c: Sort headers.
4298         * dwarf2-frame.c: Sort headers.
4299         * dwarf2-frame-tailcall.c: Sort headers.
4300         * dwarf-index-write.h: Sort headers.
4301         * dwarf-index-write.c: Sort headers.
4302         * dwarf-index-common.c: Sort headers.
4303         * dwarf-index-cache.h: Sort headers.
4304         * dwarf-index-cache.c: Sort headers.
4305         * dummy-frame.c: Sort headers.
4306         * dtrace-probe.c: Sort headers.
4307         * disasm.h: Sort headers.
4308         * disasm.c: Sort headers.
4309         * disasm-selftests.c: Sort headers.
4310         * dictionary.c: Sort headers.
4311         * dicos-tdep.c: Sort headers.
4312         * demangle.c: Sort headers.
4313         * dcache.h: Sort headers.
4314         * dcache.c: Sort headers.
4315         * darwin-nat.h: Sort headers.
4316         * darwin-nat.c: Sort headers.
4317         * darwin-nat-info.c: Sort headers.
4318         * d-valprint.c: Sort headers.
4319         * d-namespace.c: Sort headers.
4320         * d-lang.c: Sort headers.
4321         * ctf.c: Sort headers.
4322         * csky-tdep.c: Sort headers.
4323         * csky-linux-tdep.c: Sort headers.
4324         * cris-tdep.c: Sort headers.
4325         * cris-linux-tdep.c: Sort headers.
4326         * cp-valprint.c: Sort headers.
4327         * cp-support.c: Sort headers.
4328         * cp-namespace.c: Sort headers.
4329         * cp-abi.c: Sort headers.
4330         * corelow.c: Sort headers.
4331         * corefile.c: Sort headers.
4332         * continuations.c: Sort headers.
4333         * completer.h: Sort headers.
4334         * completer.c: Sort headers.
4335         * complaints.c: Sort headers.
4336         * coffread.c: Sort headers.
4337         * coff-pe-read.c: Sort headers.
4338         * cli-out.h: Sort headers.
4339         * cli-out.c: Sort headers.
4340         * charset.c: Sort headers.
4341         * c-varobj.c: Sort headers.
4342         * c-valprint.c: Sort headers.
4343         * c-typeprint.c: Sort headers.
4344         * c-lang.c: Sort headers.
4345         * buildsym.c: Sort headers.
4346         * buildsym-legacy.c: Sort headers.
4347         * build-id.h: Sort headers.
4348         * build-id.c: Sort headers.
4349         * btrace.c: Sort headers.
4350         * bsd-uthread.c: Sort headers.
4351         * breakpoint.h: Sort headers.
4352         * breakpoint.c: Sort headers.
4353         * break-catch-throw.c: Sort headers.
4354         * break-catch-syscall.c: Sort headers.
4355         * break-catch-sig.c: Sort headers.
4356         * blockframe.c: Sort headers.
4357         * block.c: Sort headers.
4358         * bfin-tdep.c: Sort headers.
4359         * bfin-linux-tdep.c: Sort headers.
4360         * bfd-target.c: Sort headers.
4361         * bcache.c: Sort headers.
4362         * ax-general.c: Sort headers.
4363         * ax-gdb.h: Sort headers.
4364         * ax-gdb.c: Sort headers.
4365         * avr-tdep.c: Sort headers.
4366         * auxv.c: Sort headers.
4367         * auto-load.c: Sort headers.
4368         * arm-wince-tdep.c: Sort headers.
4369         * arm-tdep.c: Sort headers.
4370         * arm-symbian-tdep.c: Sort headers.
4371         * arm-pikeos-tdep.c: Sort headers.
4372         * arm-obsd-tdep.c: Sort headers.
4373         * arm-nbsd-tdep.c: Sort headers.
4374         * arm-nbsd-nat.c: Sort headers.
4375         * arm-linux-tdep.c: Sort headers.
4376         * arm-linux-nat.c: Sort headers.
4377         * arm-fbsd-tdep.c: Sort headers.
4378         * arm-fbsd-nat.c: Sort headers.
4379         * arm-bsd-tdep.c: Sort headers.
4380         * arch-utils.c: Sort headers.
4381         * arc-tdep.c: Sort headers.
4382         * arc-newlib-tdep.c: Sort headers.
4383         * annotate.h: Sort headers.
4384         * annotate.c: Sort headers.
4385         * amd64-windows-tdep.c: Sort headers.
4386         * amd64-windows-nat.c: Sort headers.
4387         * amd64-tdep.c: Sort headers.
4388         * amd64-sol2-tdep.c: Sort headers.
4389         * amd64-obsd-tdep.c: Sort headers.
4390         * amd64-obsd-nat.c: Sort headers.
4391         * amd64-nbsd-tdep.c: Sort headers.
4392         * amd64-nbsd-nat.c: Sort headers.
4393         * amd64-nat.c: Sort headers.
4394         * amd64-linux-tdep.c: Sort headers.
4395         * amd64-linux-nat.c: Sort headers.
4396         * amd64-fbsd-tdep.c: Sort headers.
4397         * amd64-fbsd-nat.c: Sort headers.
4398         * amd64-dicos-tdep.c: Sort headers.
4399         * amd64-darwin-tdep.c: Sort headers.
4400         * amd64-bsd-nat.c: Sort headers.
4401         * alpha-tdep.c: Sort headers.
4402         * alpha-obsd-tdep.c: Sort headers.
4403         * alpha-nbsd-tdep.c: Sort headers.
4404         * alpha-mdebug-tdep.c: Sort headers.
4405         * alpha-linux-tdep.c: Sort headers.
4406         * alpha-linux-nat.c: Sort headers.
4407         * alpha-bsd-tdep.c: Sort headers.
4408         * alpha-bsd-nat.c: Sort headers.
4409         * aix-thread.c: Sort headers.
4410         * agent.c: Sort headers.
4411         * addrmap.c: Sort headers.
4412         * ada-varobj.c: Sort headers.
4413         * ada-valprint.c: Sort headers.
4414         * ada-typeprint.c: Sort headers.
4415         * ada-tasks.c: Sort headers.
4416         * ada-lang.c: Sort headers.
4417         * aarch64-tdep.c: Sort headers.
4418         * aarch64-ravenscar-thread.c: Sort headers.
4419         * aarch64-newlib-tdep.c: Sort headers.
4420         * aarch64-linux-tdep.c: Sort headers.
4421         * aarch64-linux-nat.c: Sort headers.
4422         * aarch64-fbsd-tdep.c: Sort headers.
4423         * aarch64-fbsd-nat.c: Sort headers.
4424         * aarch32-linux-nat.c: Sort headers.
4425
4426 2019-04-04  Tom Tromey  <tom@tromey.com>
4427
4428         * varobj.c (varobj_create): Update.
4429         * rust-exp.y (struct rust_parser) <update_innermost_block,
4430         lookup_symbol>: New methods.
4431         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4432         Rename.
4433         (rust_parser::rust_lookup_type)
4434         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4435         * printcmd.c (display_command, do_one_display): Update.
4436         * parser-defs.h (struct parser_state) <parser_state>: Add
4437         "tracker" parameter.
4438         (block_tracker): New member.
4439         (class innermost_block_tracker) <innermost_block_tracker>: Add
4440         "types" parameter.
4441         <reset>: Remove method.
4442         (innermost_block): Don't declare.
4443         (null_post_parser): Update.
4444         * parse.c (innermost_block): Remove global.
4445         (write_dollar_variable): Update.
4446         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4447         Remove "tracker_types" parameter.
4448         (parse_expression): Add "tracker" parameter.
4449         (parse_expression_for_completion): Update.
4450         (null_post_parser): Add "tracker" parameter.
4451         * p-exp.y: Update rules.
4452         * m2-exp.y: Update rules.
4453         * language.h (struct language_defn) <la_post_parser>: Add
4454         "tracker" parameter.
4455         * go-exp.y: Update rules.
4456         * f-exp.y: Update rules.
4457         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4458         parameter.
4459         * d-exp.y: Update rules.
4460         * c-exp.y: Update rules.
4461         * breakpoint.c (set_breakpoint_condition): Create an
4462         innermost_block_tracker.
4463         (watch_command_1): Likewise.
4464         * ada-lang.c (resolve): Add "tracker" parameter.
4465         (resolve_subexp): Likewise.
4466         * ada-exp.y (write_var_from_sym): Update.
4467
4468 2019-04-04  Tom Tromey  <tom@tromey.com>
4469
4470         * type-stack.h: New file.
4471         * type-stack.c: New file.
4472         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4473         type-stack.h.
4474         (insert_into_type_stack, insert_type, push_type, push_type_int)
4475         (insert_type_address_space, pop_type, pop_type_int)
4476         (pop_typelist, pop_type_stack, append_type_stack)
4477         (push_type_stack, get_type_stack, push_typelist)
4478         (follow_type_instance_flags, follow_types): Don't declare.
4479         * parse.c (type_stack): Remove global.
4480         (parse_exp_in_context): Update.
4481         (insert_into_type_stack, insert_type, push_type, push_type_int)
4482         (insert_type_address_space, pop_type, pop_type_int)
4483         (pop_typelist, pop_type_stack, append_type_stack)
4484         (push_type_stack, get_type_stack, push_typelist)
4485         (follow_type_instance_flags, follow_types): Remove (moved to
4486         type-stack.c).
4487         * f-exp.y (type_stack): New global.
4488         Update rules.
4489         (push_kind_type, f_parse): Update.
4490         * d-exp.y (type_stack): New global.
4491         Update rules.
4492         (d_parse): Update.
4493         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4494         Update rules.
4495         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4496         (HFILES_NO_SRCDIR): Add type-stack.h.
4497
4498 2019-04-04  Tom Tromey  <tom@tromey.com>
4499
4500         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4501         (rust_parser::convert_ast_to_expression, rust_parse)
4502         (rust_lex_test_completion, rust_lex_tests): Update.
4503         * parser-defs.h (struct expr_completion_state): New.
4504         (struct parser_state) <parser_state>: Add completion parameter.
4505         <mark_struct_expression, mark_completion_tag>: New methods.
4506         <parse_completion, m_completion_state>: New members.
4507         (prefixify_expression, null_post_parser): Update.
4508         (mark_struct_expression, mark_completion_tag): Don't declare.
4509         * parse.c (parse_completion, expout_last_struct)
4510         (expout_tag_completion_type, expout_completion_name): Remove
4511         globals.
4512         (parser_state::mark_struct_expression)
4513         (parser_state::mark_completion_tag): Now methods.
4514         (prefixify_expression): Add last_struct parameter.
4515         (prefixify_subexp): Likewise.
4516         (parse_exp_1): Update.
4517         (parse_exp_in_context): Add cstate parameter.  Update.
4518         (parse_expression_for_completion): Create an
4519         expr_completion_state.
4520         (null_post_parser): Add "completion" parameter.
4521         * p-exp.y: Update rules.
4522         (yylex): Update.
4523         * language.h (struct language_defn) <la_post_parser>: Add
4524         "completing" parameter.
4525         * go-exp.y: Update rules.
4526         (lex_one_token): Update.
4527         * expression.h (parse_completion): Don't declare.
4528         * d-exp.y: Update rules.
4529         (lex_one_token): Update rules.
4530         * c-exp.y: Update rules.
4531         (lex_one_token): Update.
4532         * ada-lang.c (resolve): Add "parse_completion" parameter.
4533         (resolve_subexp): Likewise.
4534         (ada_resolve_function): Likewise.
4535
4536 2019-04-04  Tom Tromey  <tom@tromey.com>
4537
4538         * parser-defs.h (struct parser_state) <start_arglist,
4539         end_arglist>: New methods.
4540         <arglist_len, m_funcall_chain>: New members.
4541         (arglist_len, start_arglist, end_arglist): Don't declare.
4542         * parse.c (arglist_len, funcall_chain): Remove global.
4543         (start_arglist, end_arglist): Remove functions.
4544         (parse_exp_in_context): Update.
4545         * p-exp.y: Update rules.
4546         * m2-exp.y: Update rules.
4547         * go-exp.y: Update rules.
4548         * f-exp.y: Update rules.
4549         * d-exp.y: Update rules.
4550         * c-exp.y: Update rules.
4551
4552 2019-04-04  Tom Tromey  <tom@tromey.com>
4553
4554         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4555         lex_operator, push_back>: New methods.
4556         Update all rules.
4557         (rust_parser::lex_hex, lex_escape): Rename and update.
4558         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4559         (rust_parser::lex_operator): Rename and update.
4560         (rust_parser::lex_number, rustyylex, rustyyerror)
4561         (rust_lex_test_init, rust_lex_test_sequence)
4562         (rust_lex_test_push_back, rust_lex_tests): Update.
4563         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4564         parameter.
4565         <lexptr, prev_lexptr>: New members.
4566         (lexptr, prev_lexptr): Don't declare.
4567         * parse.c (lexptr, prev_lexptr): Remove globals.
4568         (parse_exp_in_context): Update.
4569         * p-exp.y (yylex, yyerror): Update.
4570         * m2-exp.y (parse_number, yylex, yyerror): Update.
4571         * go-exp.y (lex_one_token, yyerror): Update.
4572         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4573         * d-exp.y (lex_one_token, yyerror): Update.
4574         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4575         (lex_one_token, yyerror): Update.
4576         * ada-lex.l (YY_INPUT): Update.
4577         (rewind_to_char): Update.
4578         * ada-exp.y (yyerror): Update.
4579
4580 2019-04-04  Tom Tromey  <tom@tromey.com>
4581
4582         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4583         * parser-defs.h (struct parser_state) <parser_state>: Add new
4584         parameter.
4585         <comma_terminates>: New member.
4586         (comma_terminates): Don't declare global.
4587         * parse.c (comma_terminates): Remove global.
4588         (parse_exp_in_context): Update.
4589         * p-exp.y (yylex): Update.
4590         * m2-exp.y (yylex): Update.
4591         * go-exp.y (lex_one_token): Update.
4592         * f-exp.y (yylex): Update.
4593         * d-exp.y (lex_one_token): Update.
4594         * c-exp.y (lex_one_token): Update.
4595         * ada-lex.l: Update.
4596
4597 2019-04-04  Tom Tromey  <tom@tromey.com>
4598
4599         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4600         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4601         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4602         * parser-defs.h (paren_depth): Don't declare.
4603         * parse.c (paren_depth): Remove global.
4604         (parse_exp_in_context): Update.
4605         * p-exp.y (paren_depth): New global.
4606         (pascal_parse): Initialize it.
4607         * m2-exp.y (paren_depth): New global.
4608         (m2_parse): Initialize it.
4609         * go-exp.y (paren_depth): New global.
4610         (go_parse): Initialize it.
4611         * f-exp.y (paren_depth): New global.
4612         (f_parse): Initialize it.
4613         * d-exp.y (paren_depth): New global.
4614         (d_parse): Initialize it.
4615         * c-exp.y (paren_depth): New global.
4616         (c_parse): Initialize it.
4617         * ada-lex.l (paren_depth): New global.
4618         (lexer_init): Initialize it.
4619
4620 2019-04-04  Tom Tromey  <tom@tromey.com>
4621
4622         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4623         (rust_parser::convert_ast_to_type)
4624         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4625         * parser-defs.h (struct parser_state) <parser_state>: Add
4626         parameters.  Initialize new members.
4627         <expression_context_block, expression_context_pc>: New members.
4628         * parse.c (expression_context_block, expression_context_pc):
4629         Remove globals.
4630         (parse_exp_in_context): Update.
4631         * p-exp.y: Update all rules.
4632         (yylex): Update.
4633         * m2-exp.y: Update all rules.
4634         (yylex): Update.
4635         * go-exp.y (yylex): Update.
4636         * f-exp.y (yylex): Update.
4637         * d-exp.y: Update all rules.
4638         (yylex): Update.
4639         * c-exp.y: Update all rules.
4640         (lex_one_token, classify_name, yylex, c_parse): Update.
4641         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4642
4643 2019-04-04  Tom Tromey  <tom@tromey.com>
4644
4645         * gdbarch.h, gdbarch.c: Rebuild.
4646         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4647         * stap-probe.h:
4648         (struct stap_parse_info): Replace "parser_state" with
4649         "expr_builder".
4650         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4651         (parser_state): New class.
4652         * parse.c (expr_builder): Rename.
4653         (expr_builder::release): Rename.
4654         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4655         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4656         (write_exp_elt_longcst, write_exp_elt_floatcst)
4657         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4658         (write_exp_string_vector, write_exp_bitstring)
4659         (write_exp_msymbol, mark_struct_expression)
4660         (write_dollar_variable)
4661         (insert_type_address_space, increase_expout_size): Replace
4662         "parser_state" with "expr_builder".
4663         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4664         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4665         "parser_state" with "expr_builder".
4666
4667 2019-04-04  Tom Tromey  <tom@tromey.com>
4668
4669         * rust-exp.y: Replace "parse_language" with method call.
4670         * p-exp.y:
4671         (yylex): Replace "parse_language" with method call.
4672         * m2-exp.y:
4673         (yylex): Replace "parse_language" with method call.
4674         * go-exp.y (classify_name): Replace "parse_language" with method
4675         call.
4676         * f-exp.y (yylex): Replace "parse_language" with method call.
4677         * d-exp.y (lex_one_token): Replace "parse_language" with method
4678         call.
4679         * c-exp.y:
4680         (lex_one_token, classify_name, yylex): Replace "parse_language"
4681         with method call.
4682         * ada-exp.y (find_primitive_type, type_char)
4683         (type_system_address): Replace "parse_language" with method call.
4684
4685 2019-04-04  Tom Tromey  <tom@tromey.com>
4686
4687         * rust-exp.y: Replace "parse_gdbarch" with method call.
4688         * parse.c (write_dollar_variable, insert_type_address_space):
4689         Replace "parse_gdbarch" with method call.
4690         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4691         call.
4692         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4693         call.
4694         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4695         "parse_gdbarch" with method call.
4696         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4697         with method call.
4698         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4699         "parse_gdbarch" with method call.
4700         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4701         "parse_gdbarch" with method call.
4702         * c-exp.y (parse_type, parse_number, classify_name): Replace
4703         "parse_gdbarch" with method call.
4704         * ada-lex.l: Replace "parse_gdbarch" with method call.
4705         * ada-exp.y (parse_type, find_primitive_type, type_char)
4706         (type_system_address): Replace "parse_gdbarch" with method call.
4707
4708 2019-04-04  Tom Tromey  <tom@tromey.com>
4709
4710         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4711         * stap-probe.c (stap_parse_argument): Update.
4712         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4713         initial_size parameter.
4714         * rust-exp.y (rust_lex_tests): Update.
4715         * parse.c (parser_state): Update.
4716         (parse_exp_in_context): Update.
4717         * parser-defs.h (struct parser_state) <parser_state>: Remove
4718         "initial_size" parameter.
4719
4720 2019-04-04  Tom Tromey  <tom@tromey.com>
4721
4722         * parser-defs.h (increase_expout_size): Don't declare.
4723         * parse.c (increase_expout_size): Now static.
4724
4725 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4726
4727         * gnu-nat.c (gnu_nat_target::wait): Fix
4728         target_waitstatus_to_string call.
4729
4730 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4731
4732         * eval.c (evaluate_subexp_standard): Handle internal functions
4733         during Fortran function call handling.
4734
4735 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4736
4737         * NEWS: Mention new internal functions.
4738         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4739         (read_base_type): Use dwarf2_init_complex_target_type.
4740         * value.c (creal_internal_fn): New function.
4741         (cimag_internal_fn): New function.
4742         (_initialize_values): Register new internal functions.
4743
4744 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4745
4746         * infrun.c (stop_all_threads): If debug_infrun, always
4747         trace the wait status after wait_one, using
4748         target_waitstatus_to_string and target_pid_to_str.
4749         (handle_inferior_event): Replace various trace of
4750         wait status kind by a single trace.
4751         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4752         wait status kind image by target_waitstatus_to_string.
4753         * target/waitstatus.c (target_waitstatus_to_string): Fix
4754         obsolete comment.
4755
4756 2019-04-01  Tom Tromey  <tromey@adacore.com>
4757
4758         PR symtab/23331:
4759         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4760
4761 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4762             Pedro Alves  <palves@redhat.com>
4763
4764         * top.c (quit_force): Call 'finalize_values'.
4765         * value.c (finalize_values): New function.
4766         * value.h (finalize_values): Declare.
4767
4768 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4769
4770         * NEWS: Announce $_gdb_major and $_gdb_minor.
4771
4772         * top.c (init_gdb_version_vars): New function.
4773         (gdb_init): Call init_gdb_version_vars.
4774
4775 2019-03-29  Tom Tromey  <tromey@adacore.com>
4776
4777         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4778         help text.  Remove dead code.
4779
4780 2019-03-29  Keith Seitz  <keiths@redhat.com>
4781
4782         From Siddhesh Poyarekar:
4783         * f-lang.h (f77_get_upperbound): Return LONGEST.
4784         (f77_get_lowerbound): Likewise.
4785         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4786         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4787         print them.
4788         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4789         plongest to format print it.
4790         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4791         (f77_get_upperbound): Likewise.
4792         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4793         LOWER_BOUND to LONGEST.
4794         (f77_create_arrayprint_offset_tbl): Likewise.
4795
4796 2019-03-29  Keith Seitz  <keiths@redhat.com>
4797
4798         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4799         %s/pulongest for TYPE_LENGTH instead of %d in format
4800         strings.
4801         * ada-typerint.c (ada_print_type): Likewise.
4802         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4803         * compile/compile-c-support.c (generate_register_struct): Likewise.
4804         * gdbtypes.c (recursive_dump_type): Likewise.
4805         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4806         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4807         instead of %d in format strings.
4808         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4809         to std::min to ULONGEST.
4810         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4811         instead of %d in format strings.
4812         * tracepoint.c (info_scope_command): Likewise.
4813         * typeprint.c (print_offset_data::update)
4814         (print_offset_data::finish): Likewise.
4815         * xtensa-tdep.c (xtensa_store_return_value)
4816         (xtensa_push_dummy_call): Likewise.
4817
4818 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4819
4820         * windows-nat.c (display_selector): Fixed format specifications
4821         for 64-bit Cygwin.
4822
4823 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4824
4825         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4826
4827 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4828
4829         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4830         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4831         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4832         (nios2_linux_init_abi): Install it.
4833
4834 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4835
4836         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4837
4838 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4839
4840         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4841
4842 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4843             Tom Tromey  <tromey@adacore.com>
4844
4845         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4846
4847 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4848
4849         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4850         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4851         method to compute the bounds of range types. Also print "[evaluated]"
4852         if the bounds' values come from a dynamic evaluation.
4853
4854 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4855
4856         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4857         whitespace when pretty printing is on.
4858
4859 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4860
4861         * ppc-linux-nat.c: Add include.
4862
4863 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4864
4865         * NEWS: Mention AArch64 Pointer Authentication.
4866
4867 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4868
4869         * arm-linux-nat.c: Add include.
4870
4871 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4872
4873         * source-cache.c (source_cache::get_source_lines): Re-read
4874         fullname after calling open_source_file.
4875
4876 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4877
4878         * NEWS: Mention TLS support for FreeBSD.
4879
4880 2019-03-25  Tom Tromey  <tromey@adacore.com>
4881
4882         * minsyms.c (BUNCH_SIZE): Update comment.
4883         (~minimal_symbol_reader): Remove old comment.
4884         (compact_minimal_symbols): Update comment.
4885         (minimal_symbol_reader::install): Remove old comment.  Update
4886         other comments.
4887
4888 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4889
4890         * s390-linux-nat.c: Add include.
4891
4892 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4893
4894         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4895         Call linux_get_hwcap.
4896         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4897         Likewise.
4898         (aarch64_linux_get_hwcap): Remove function.
4899         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4900         declaration.
4901         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4902         linux_get_hwcap.
4903         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4904         * linux-tdep.c (linux_get_hwcap): Add function.
4905         (linux_get_hwcap2): Likewise.
4906         * linux-tdep.h (linux_get_hwcap): Add declaration.
4907         (linux_get_hwcap2): Likewise.
4908         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4909         (ppc_linux_get_hwcap2): Likewise.
4910         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4911         linux_get_hwcap.
4912         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4913         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4914         (ppc_linux_nat_target::read_description): Likewise.
4915         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4916         * s390-linux-nat.c: Likewise.
4917         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4918
4919 2019-03-24  Tom Tromey  <tom@tromey.com>
4920
4921         * ada-lang.c (standard_lookup): Simplify initialization.
4922         (ada_lookup_symbol_nonlocal): Simplify return.
4923         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4924         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4925         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4926         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4927         initialization.
4928         * solib.c (solib_global_lookup): Simplify.
4929         * symtab.c (null_block_symbol): Remove.
4930         (symbol_cache_lookup): Simplify returns.
4931         (lookup_language_this): Simplify returns.
4932         (lookup_symbol_aux): Simplify return.
4933         (lookup_local_symbol): Simplify returns.
4934         (lookup_global_symbol_from_objfile): Simplify return.
4935         (lookup_symbol_in_objfile_symtabs)
4936         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4937         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4938         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4939         * cp-namespace.c (cp_lookup_bare_symbol)
4940         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4941         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4942         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4943         (cp_lookup_symbol_via_imports): Simplify initialization.
4944         (find_symbol_in_baseclass): Likewise.
4945         * symtab.h (null_block_symbol): Remove.
4946         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4947         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4948         (d_lookup_symbol_module): Likewise.
4949         (find_symbol_in_baseclass): Simplify initialization.
4950
4951 2019-03-24  Tom Tromey  <tom@tromey.com>
4952
4953         * expression.h: Don't include symtab.h.
4954         (struct block): Forward declare.
4955
4956 2019-03-24  Tom Tromey  <tom@tromey.com>
4957
4958         * c-exp.y (typebase): Remove casts.
4959         * gdbtypes.c (lookup_unsigned_typename, )
4960         (lookup_signed_typename): Remove cast.
4961         * eval.c (parse_to_comma_and_eval): Remove cast.
4962         * parse.c (write_dollar_variable): Remove cast.
4963         * block.h (struct block) <superblock>: Now const.
4964         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4965         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4966         (map_block): Make "block" const.
4967         * symfile.h (struct quick_symbol_functions)
4968         <map_matching_symbols>: Constify block argument to "callback".
4969         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4970         const.
4971         (find_pc_sect_compunit_symtab): Make "b" const.
4972         (find_symbol_at_address): Likewise.
4973         (search_symbols): Likewise.
4974         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4975         (dw2_debug_names_lookup_symbol): Likewise.
4976         (dw2_map_matching_symbols): Update.
4977         * p-valprint.c (pascal_val_print): Remove "block".
4978         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4979         (aux_add_nonlocal_symbols): Make "block" const.
4980         (resolve_subexp): Remove cast.
4981         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4982         const.
4983         (iterate_over_file_blocks): Likewise.
4984         * f-exp.y (%union) <bval>: Remove.
4985         * coffread.c (patch_opaque_types): Make "b" const.
4986         * spu-tdep.c (spu_catch_start): Make "block" const.
4987         * c-valprint.c (print_unpacked_pointer): Remove "block".
4988         * symmisc.c (dump_symtab_1): Make "b" const.
4989         (block_depth): Make "block" const.
4990         * d-exp.y (%union) <bval>: Remove.
4991         * cp-support.h (cp_lookup_rtti_type): Update.
4992         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4993         * psymtab.c (psym_lookup_symbol): Make "block" const.
4994         (maintenance_check_psymtabs): Make "b" const.
4995         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4996         (enumerate_locals, enumerate_args): Update.
4997         * python/py-symtab.c (stpy_global_block): Make "block" const.
4998         (stpy_static_block): Likewise.
4999         * inline-frame.c (block_starting_point_at): Make "new_block"
5000         const.
5001         * block.c (find_block_in_blockvector): Make return type const.
5002         (blockvector_for_pc_sect): Make "b" const.
5003         (find_block_in_blockvector): Make "b" const.
5004
5005 2019-03-23  Tom Tromey  <tom@tromey.com>
5006
5007         * varobj.c (varobj_create): Update.
5008         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5009         * printcmd.c (display_command, do_one_display): Don't reset
5010         innermost_block.
5011         * parser-defs.h (enum innermost_block_tracker_type): Move to
5012         expression.h.
5013         (innermost_block): Update comment.
5014         * parse.c (parse_exp_1): Add tracker_types parameter.
5015         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5016         tracker_types parameter.  Reset innermost_block.
5017         (parse_exp_in_context): Remove.
5018         (parse_expression_for_completion): Update.
5019         * objfiles.c (~objfile): Don't reset expression_context_block or
5020         innermost_block.
5021         * expression.h (enum innermost_block_tracker_type): Move from
5022         parser-defs.h.
5023         (parse_exp_1): Add tracker_types parameter.
5024         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5025         reset innermost_block.
5026
5027 2019-03-23  Tom Tromey  <tom@tromey.com>
5028
5029         * objfiles.h: Include bcache.h.
5030
5031 2019-03-23  Tom Tromey  <tom@tromey.com>
5032
5033         * linespec.c (get_current_search_block): Use
5034         scoped_restore_current_language.
5035         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5036
5037 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5038             Jiong Wang  <jiong.wang@arm.com>
5039
5040         * aarch64-linux-tdep.c
5041         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5042         section.
5043         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5044
5045 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5046             Jiong Wang  <jiong.wang@arm.com>
5047
5048         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5049         instructions.
5050         (aarch64_analyze_prologue_test): Add PACIASP test.
5051         (aarch64_prologue_prev_register): Unmask PC value.
5052
5053 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5054             Jiong Wang  <jiong.wang@arm.com>
5055
5056         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5057         (aarch64_dwarf2_prev_register): Unmask PC value.
5058         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5059         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5060         DW_CFA_AARCH64_negate_ra_state.
5061         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5062
5063 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5064             Jiong Wang  <jiong.wang@arm.com>
5065
5066         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5067         registers.
5068         (aarch64_pseudo_register_name): Likewise.
5069         (aarch64_pseudo_register_type): Likewise.
5070         (aarch64_pseudo_register_reggroup_p): Likewise.
5071         (aarch64_gdbarch_init): Add pauth registers.
5072         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5073         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5074         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5075         (struct gdbarch_tdep): Add regnum for ra_state.
5076
5077 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5078             Jiong Wang  <jiong.wang@arm.com>
5079
5080         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5081
5082 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5083             Jiong Wang  <jiong.wang@arm.com>
5084
5085         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5086         function.
5087         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5088         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5089         (aarch64_gdbarch_init): Add puth registers.
5090         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5091         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5092         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5093
5094 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5095             Jiong Wang  <jiong.wang@arm.com>
5096
5097         * aarch64-linux-nat.c
5098         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5099         * aarch64-linux-tdep.c
5100         (aarch64_linux_core_read_description): Likewise.
5101         (aarch64_linux_get_hwcap): New function.
5102         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5103         (aarch64_linux_get_hwcap): New declaration.
5104
5105 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5106             Jiong Wang  <jiong.wang@arm.com>
5107
5108         * aarch64-linux-nat.c
5109         (aarch64_linux_nat_target::read_description): Add pauth param.
5110         * aarch64-linux-tdep.c
5111         (aarch64_linux_core_read_description): Likewise.
5112         * aarch64-tdep.c (struct target_desc): Add in pauth.
5113         (aarch64_read_description): Add pauth param.
5114         (aarch64_gdbarch_init): Likewise.
5115         * aarch64-tdep.h (aarch64_read_description): Likewise.
5116         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5117         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5118         * features/Makefile: Add new files.
5119         * features/aarch64-pauth.c: New file.
5120         * features/aarch64-pauth.xml: New file.
5121
5122 2019-03-20  Tom Tromey  <tromey@adacore.com>
5123
5124         * infrun.c (handle_inferior_event): Rename from
5125         handle_inferior_event_1.  Create a scoped_value_mark.
5126         (handle_inferior_event): Remove.
5127
5128 2019-03-19  Tom Tromey  <tromey@adacore.com>
5129
5130         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5131         * infrun.h (print_stop_event): Add "displays" parameter.
5132         * infrun.c (print_stop_event): Add "displays" parameter.
5133
5134 2019-03-19  Pedro Alves  <palves@redhat.com>
5135
5136         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5137         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5138         to -1.  Fix TABs vs spaces.
5139         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5140         * tui/tui-out.h (tui_ui_out) Add intro comments.
5141         <m_line, m_start_of_line>: In-class initialize, and add describing
5142         comment.
5143
5144 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5145
5146         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5147         variable names.
5148         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5149
5150 2019-03-18  Pedro Alves  <palves@redhat.com>
5151             Eli Zaretskii <eliz@gnu.org>
5152
5153         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5154         m_line and m_start_of_line.
5155
5156 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5157
5158         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5159         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5160         it returns a newline.  This fixes a regression in TU mode, whereby
5161         the next line is output on the same screen line as the user input.
5162
5163 2019-03-18  Tom Tromey  <tromey@adacore.com>
5164
5165         * minsyms.c (minimal_symbol_reader::install): Remove call to
5166         obstack_blank.
5167
5168 2019-03-18  Pedro Alves  <palves@redhat.com>
5169
5170         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5171         New globals.
5172         (apply_style): New, factored out from ...
5173         (apply_ansi_escape): ... this.  Handle reverse video mode.
5174         (tui_set_reverse_mode): New function.
5175         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5176         * tui/tui-winsource.c (tui_show_source_line): Use
5177         tui_set_reverse_mode instead of setting A_STANDOUT.
5178         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5179         New setter methods.
5180
5181 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5182
5183         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5184         Handle tabs.
5185
5186 2019-03-18  Tom Tromey  <tromey@adacore.com>
5187
5188         * ada-lang.c (empty_array): Add "high" parameter.
5189         (ada_evaluate_subexp): Update.
5190
5191 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5192
5193         * unittests/string_view-selftests.c: Define
5194         _initialize_string_view_selftests unconditionally.
5195
5196 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5197
5198         PR gdb/24350
5199         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5200
5201 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5202
5203         PR gdb/24351
5204         * windows-nat.c (display_selector): Fix format specifiers.
5205
5206 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5207
5208         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5209         tui_refill_source_window instead of tui_refresh_win, to update the
5210         current execution line.  This fixes redisplay of the current line
5211         when stepping through the code with "next" or "step".
5212
5213 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5214
5215         * source-cache.c (source_cache::get_source_lines): Call
5216         find_source_lines to initialize s->nlines.  This fixes vertical
5217         scrolling of TUI source window when the DOWN arrow is pressed.
5218
5219 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5220
5221         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5222         linux-thread-db.c (_initialize_thread_db): Likewise.
5223
5224 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5225
5226         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5227         wclrtoeol in tui_show_source_line".  This reverts changes made in
5228         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5229
5230 2019-03-15  Tom Tromey  <tom@tromey.com>
5231
5232         * symtab.h (struct minimal_symbol): Derive from
5233         general_symbol_info.
5234         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5235         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5236         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5237         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5238         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5239         (MSYMBOL_SEARCH_NAME): Update.
5240         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5241         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5242         * minsyms.c (minimal_symbol_reader::record_full): Update.
5243
5244 2019-03-15  Tom Tromey  <tom@tromey.com>
5245
5246         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5247
5248 2019-03-15  Tom Tromey  <tom@tromey.com>
5249
5250         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5251         unique_xmalloc_ptr.
5252         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5253         Update.
5254         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5255         (build_minimal_symbol_hash_tables)
5256         (minimal_symbol_reader::install): Update.
5257
5258 2019-03-15  Tom Tromey  <tom@tromey.com>
5259
5260         * symtab.c (create_demangled_names_hash): Update.
5261         (symbol_set_names): Update.
5262         * objfiles.h (struct objfile_per_bfd_storage)
5263         <demangled_names_hash>: Now an htab_up.
5264         * objfiles.c (objfile_per_bfd_storage): Simplify.
5265
5266 2019-03-15  Tom Tromey  <tom@tromey.com>
5267
5268         * objfiles.h (struct objfile_per_bfd_storage): Declare
5269         destructor.
5270         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5271         New.
5272         (get_objfile_bfd_data): Use new.  Don't initialize
5273         language_of_main.
5274         (free_objfile_per_bfd_storage): Remove.
5275         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5276
5277 2019-03-15  Tom Tromey  <tom@tromey.com>
5278
5279         * symfile.c (reread_symbols): Update.
5280         * objfiles.c (objfile::objfile): Update.
5281         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5282         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5283         comment.
5284         (minimal_symbol_reader::install): Update.
5285         (terminate_minimal_symbol_table): Remove.
5286         * jit.c (jit_object_close_impl): Update.
5287
5288 2019-03-15  Tom Tromey  <tom@tromey.com>
5289
5290         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5291         initializations.
5292
5293 2019-03-15  Tom Tromey  <tom@tromey.com>
5294
5295         * objfiles.h (struct objfile_per_bfd_storage)
5296         <demangled_hash_languages>: Now a bitset.
5297         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5298         (lookup_minimal_symbol): Update.
5299
5300 2019-03-15  Tom Tromey  <tom@tromey.com>
5301
5302         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5303         Don't return the symbol.
5304         * coffread.c (record_minimal_symbol): Use record_full.
5305
5306 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5307
5308         The MS-Windows port of ncurses fails to switch to a color pair if
5309         one or both of the colors are the implicit default colors.  This
5310         change records the default colors when TUI is initialized, and
5311         then specifies them explicitly when a color pair uses the default
5312         colors.  This allows color styling in TUI mode on MS-Windows.
5313
5314         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5315         ncurses_norm_attr.
5316         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5317         colors in ncurses_norm_attr.
5318         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5319         "none", replace it with the default color recorded in
5320         ncurses_norm_attr.
5321
5322 2019-03-14  Tom Tromey  <tromey@adacore.com>
5323
5324         * source-cache.h (class source_cache) <get_source_lines>: Return
5325         std::string.
5326         * source-cache.c (source_cache::extract_lines): Handle case where
5327         first_pos==npos.  Return std::string.
5328         (source_cache::get_source_lines): Update.
5329
5330 2019-03-14  Tom Tromey  <tromey@adacore.com>
5331
5332         * NEWS: Add item for "style sources" commands.
5333         * source-cache.c (source_cache::get_source_lines): Check
5334         source_styling.
5335         * cli/cli-style.c (source_styling): New global.
5336         (_initialize_cli_style): Add "style sources" commands.
5337         (show_style_sources): New function.
5338         * cli/cli-style.h (source_styling): Declare.
5339
5340 2019-03-14  Pedro Alves  <palves@redhat.com>
5341             Tom Tromey  <tromey@adacore.com>
5342
5343         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5344         * tui/tui-winsource.c (tui_refill_source_window): New function,
5345         from...
5346         (tui_horizontal_source_scroll): ... here.  Move some logic.
5347         * cli/cli-style.c (set_style_enabled): Notify new observable.
5348         * tui/tui-hooks.c (tui_redisplay_source): New function.
5349         (tui_attach_detach_observers): Attach or detach
5350         tui_redisplay_source.
5351         * observable.h (source_styling_changed): New observable.
5352         * observable.c: Define source_styling_changed observable.
5353
5354 2019-03-13  Tom Tromey  <tromey@adacore.com>
5355
5356         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5357         (i386_gnu_nat_target::store_registers): Update.
5358         * target-debug.h (target_debug_print_std_string): New macro.
5359         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5360         * windows-tdep.c (display_one_tib): Update.
5361         * tui/tui-stack.c (tui_make_status_line): Update.
5362         * top.c (print_inferior_quit_action): Update.
5363         * thread.c (thr_try_catch_cmd): Update.
5364         (add_thread_with_info): Update.
5365         (thread_target_id_str): Update.
5366         (thr_try_catch_cmd): Update.
5367         (thread_command): Update.
5368         (thread_find_command): Update.
5369         * record-btrace.c (record_btrace_target::info_record)
5370         (record_btrace_resume_thread, record_btrace_target::resume)
5371         (record_btrace_cancel_resume, record_btrace_step_thread)
5372         (record_btrace_target::wait, record_btrace_target::wait)
5373         (record_btrace_target::wait, record_btrace_target::stop): Update.
5374         * progspace.c (print_program_space): Update.
5375         * process-stratum-target.c
5376         (process_stratum_target::thread_address_space): Update.
5377         * linux-fork.c (linux_fork_mourn_inferior)
5378         (detach_checkpoint_command, info_checkpoints_command)
5379         (linux_fork_context): Update.
5380         (linux_fork_detach): Update.
5381         (class scoped_switch_fork_info): Update.
5382         (delete_checkpoint_command): Update.
5383         * infrun.c (follow_fork_inferior): Update.
5384         (follow_fork_inferior): Update.
5385         (proceed_after_vfork_done): Update.
5386         (handle_vfork_child_exec_or_exit): Update.
5387         (follow_exec): Update.
5388         (displaced_step_prepare_throw): Update.
5389         (displaced_step_restore): Update.
5390         (start_step_over): Update.
5391         (resume_1): Update.
5392         (clear_proceed_status_thread): Update.
5393         (proceed): Update.
5394         (print_target_wait_results): Update.
5395         (do_target_wait): Update.
5396         (context_switch): Update.
5397         (stop_all_threads): Update.
5398         (restart_threads): Update.
5399         (finish_step_over): Update.
5400         (handle_signal_stop): Update.
5401         (switch_back_to_stepped_thread): Update.
5402         (keep_going_pass_signal): Update.
5403         (print_exited_reason): Update.
5404         (normal_stop): Update.
5405         * inferior.c (inferior_pid_to_str): Change return type.
5406         (print_selected_inferior): Update.
5407         (add_inferior): Update.
5408         (detach_inferior): Update.
5409         * dummy-frame.c (fprint_dummy_frames): Update.
5410         * dcache.c (dcache_info_1): Update.
5411         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5412         (btrace_fetch, btrace_clear): Update.
5413         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5414         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5415         type.
5416         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5417         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5418         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5419         * gdbarch.c, gdbarch.h: Rebuild.
5420         * gdbarch.sh (core_pid_to_str): Change return type.
5421         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5422         return type.
5423         (windows_nat_target::pid_to_str): Change return type.
5424         (windows_delete_thread): Update.
5425         (windows_nat_target::attach): Update.
5426         (windows_nat_target::files_info): Update.
5427         * target-delegates.c: Rebuild.
5428         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5429         return type.
5430         (sol_thread_target::pid_to_str): Change return type.
5431         * remote.c (class remote_target) <pid_to_str>: Change return
5432         type.
5433         (remote_target::pid_to_str): Change return type.
5434         (extended_remote_target::attach, remote_target::remote_stop_ns)
5435         (remote_target::remote_notif_remove_queued_reply)
5436         (remote_target::push_stop_reply, remote_target::disable_btrace):
5437         Update.
5438         (extended_remote_target::attach): Update.
5439         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5440         type.
5441         (gdbsim_target::pid_to_str): Change return type.
5442         * ravenscar-thread.c (struct ravenscar_thread_target)
5443         <pid_to_str>: Change return type.
5444         (ravenscar_thread_target::pid_to_str): Change return type.
5445         * procfs.c (class procfs_target) <pid_to_str>: Change return
5446         type.
5447         (procfs_target::pid_to_str): Change return type.
5448         (procfs_target::attach): Update.
5449         (procfs_target::detach): Update.
5450         (procfs_target::fetch_registers): Update.
5451         (procfs_target::store_registers): Update.
5452         (procfs_target::wait): Update.
5453         (procfs_target::files_info): Update.
5454         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5455         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5456         return type.
5457         (nto_procfs_target::pid_to_str): Change return type.
5458         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5459         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5460         return type.
5461         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5462         (exit_lwp): Update.
5463         (attach_proc_task_lwp_callback, get_detach_signal)
5464         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5465         (linux_nat_target::resume, wait_lwp, stop_callback)
5466         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5467         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5468         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5469         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5470         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5471         type.
5472         (inf_ptrace_target::attach): Update.
5473         (inf_ptrace_target::files_info): Update.
5474         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5475         type.
5476         (go32_nat_target::pid_to_str): Change return type.
5477         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5478         (gnu_nat_target::wait): Update.
5479         (gnu_nat_target::wait): Update.
5480         (gnu_nat_target::resume): Update.
5481         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5482         (fbsd_nat_target::wait): Update.
5483         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5484         type.
5485         (darwin_nat_target::attach): Update.
5486         * corelow.c (class core_target) <pid_to_str>: Change return type.
5487         (core_target::pid_to_str): Change return type.
5488         * target.c (normal_pid_to_str): Change return type.
5489         (default_pid_to_str): Likewise.
5490         (target_pid_to_str): Change return type.
5491         (target_translate_tls_address): Update.
5492         (target_announce_detach): Update.
5493         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5494         return type.
5495         (bsd_uthread_target::pid_to_str): Change return type.
5496         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5497         type.
5498         (bsd_kvm_target::pid_to_str): Change return type.
5499         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5500         return type.
5501         (aix_thread_target::pid_to_str): Change return type.
5502         * target.h (struct target_ops) <pid_to_str>: Change return type.
5503         (target_pid_to_str, normal_pid_to_str): Likewise.
5504         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5505         type.
5506         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5507         type.
5508         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5509         return type.
5510         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5511         type.
5512         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5513         type.
5514         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5515         return type.
5516
5517 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5518
5519         * NEWS: Mention that the new default MI version is 3.  Mention
5520         changes to the output of commands and events that deal with
5521         multi-location breakpoints.
5522         * breakpoint.c: Include "mi/mi-out.h".
5523         (print_one_breakpoint): Change output syntax if using MI version
5524         >= 3.
5525         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5526         New.
5527         (mi_multi_location_breakpoint_output_fixed): New.
5528         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5529         (mi_cmd_fix_multi_location_breakpoint_output): New.
5530         (mi_multi_location_breakpoint_output_fixed): New.
5531         * mi/mi-cmds.c (mi_cmds): Register command
5532         -fix-multi-location-breakpoint-output.
5533         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5534         interpreter "mi".
5535
5536 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5537
5538         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5539         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5540         instantiate mi_ui_out based on interpreter name.
5541         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5542         * mi/mi-main.c (mi_load_progress): Likewise.
5543
5544 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5545
5546         * NEWS: Combine separate "New targets" sections for 8.3.
5547
5548 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5549
5550         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5551         (ppcfbsd_init_abi): Install gdbarch
5552         "fetch_tls_load_module_address" and "get_thread_local_address"
5553         methods.
5554
5555 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5556
5557         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5558         (riscv_fbsd_init_abi): Install gdbarch
5559         "fetch_tls_load_module_address" and "get_thread_local_address"
5560         methods.
5561
5562 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5563
5564         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5565         (i386fbsd_init_abi): Install gdbarch
5566         "fetch_tls_load_module_address" and "get_thread_local_address"
5567         methods.
5568
5569 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5570
5571         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5572         (amd64fbsd_init_abi): Install gdbarch
5573         "fetch_tls_load_module_address" and "get_thread_local_address"
5574         methods.
5575
5576 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5577
5578         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5579         (struct fbsd_pspace_data): New type.
5580         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5581         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5582         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5583         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5584         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5585
5586 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5587
5588         * gdbtypes.c (lookup_struct_elt): New function.
5589         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5590         * gdbtypes.h (struct struct_elt): New type.
5591         (lookup_struct_elt): New prototype.
5592
5593 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5594
5595         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5596         remove disabled code block.
5597
5598 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5599
5600         * gdbarch.sh (get_thread_local_address): New method.
5601         * gdbarch.h, gdbarch.c: Regenerate.
5602         * target.c (target_translate_tls_address): Use
5603         gdbarch_get_thread_local_address if present instead of
5604         target::get_thread_local_address.
5605
5606 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5607
5608         * target.h (target::get_thread_local_address): Update comment.
5609
5610 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5611
5612         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5613         objfile->separate_debug_objfile_backlink if not NULL.
5614
5615 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5616
5617         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5618         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5619         (amd64bsd_store_inferior_registers): Likewise.
5620         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5621         Enable segment base registers.
5622         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5623         PT_GETFSBASE and PT_GETGSBASE.
5624         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5625         PT_SETGSBASE.
5626         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5627         segment base registers.
5628         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5629
5630 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5631
5632         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5633         Update calls to i386_target_description to add 'segments'
5634         parameter.
5635         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5636         add segment base registers.
5637         * arch/i386.c (i386_create_target_description): Add 'segments'
5638         parameter to enable segment base registers.
5639         * arch/i386.h (i386_create_target_description): Likewise.
5640         * features/i386/32bit-segments.xml: New file.
5641         * features/i386/32bit-segments.c: Generate.
5642         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5643         call to i386_target_description to add 'segments' parameter.
5644         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5645         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5646         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5647         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5648         if feature is present.
5649         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5650         Add 'segments' parameter to call to i386_target_description.
5651         (i386_target_description): Add 'segments' parameter to enable
5652         segment base registers.
5653         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5654         to call to i386_target_description.
5655         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5656         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5657         Define I386_NUM_REGS.
5658         (i386_target_description): Add 'segments' parameter to enable
5659         segment base registers.
5660
5661 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5662
5663         PR/24325
5664         * source-cache.c: #undef open and close, to avoid unresolved
5665         externals during linking.
5666
5667 2019-03-12  Tom Tromey  <tromey@adacore.com>
5668
5669         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5670         const.  Add initializers.
5671         (_initialize_remote): Don't initialize ptid globals.
5672
5673 2019-03-12  Pedro Alves  <palves@redhat.com>
5674
5675         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5676
5677 2019-03-12  Pedro Alves  <palves@redhat.com>
5678
5679         * cp-name-parser.y (main): Remove unused 'len' variable.
5680
5681 2019-03-12  Tom Tromey  <tromey@adacore.com>
5682
5683         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5684         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5685
5686 2019-03-12  Tom Tromey  <tromey@adacore.com>
5687
5688         * linux-nat.c (iterate_over_lwps): Update.
5689         (stop_callback): Remove parameter.
5690         (stop_wait_callback, detach_callback, resume_set_callback)
5691         (select_singlestep_lwp_callback, set_ignore_sigint)
5692         (status_callback, resumed_callback, resume_clear_callback)
5693         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5694         data parameter.
5695         (linux_nat_target::detach, linux_nat_target::resume)
5696         (linux_stop_and_wait_all_lwps, select_event_lwp)
5697         (linux_nat_filter_event, linux_nat_wait_1)
5698         (linux_nat_target::kill, linux_nat_target::stop)
5699         (linux_nat_target::stop): Update.
5700         (linux_nat_resume_callback): Change type.
5701         (resume_stopped_resumed_lwps, count_events_callback)
5702         (select_event_lwp_callback): Likewise.
5703         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5704         * arm-linux-nat.c (struct update_registers_data): Remove.
5705         (update_registers_callback): Change type.
5706         (arm_linux_insert_hw_breakpoint1): Update.
5707         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5708         parameter.
5709         (x86_linux_dr_set_addr): Update.
5710         (x86_linux_dr_set_control): Update.
5711         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5712         (iterate_over_lwps): Use gdb::function_view.
5713         * nat/aarch64-linux-hw-point.c (struct
5714         aarch64_dr_update_callback_param): Remove.
5715         (debug_reg_change_callback): Change type.
5716         (aarch64_notify_debug_reg_change): Update.
5717         * s390-linux-nat.c (s390_refresh_per_info): Update.
5718
5719 2019-03-11  Tom Tromey  <tromey@adacore.com>
5720
5721         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5722         redundant assignment to "this_cu".
5723
5724 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5725
5726         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5727
5728 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5729
5730         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5731         from...
5732         (rank_one_type): ... this.
5733
5734 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5735
5736         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5737         from...
5738         (rank_one_type): ... this.
5739
5740 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5741
5742         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5743         from...
5744         (rank_one_type): ... this.
5745
5746 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5747
5748         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5749         from...
5750         (rank_one_type): ... this.
5751
5752 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5753
5754         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5755         from...
5756         (rank_one_type): ... this.
5757
5758 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5759
5760         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5761         from...
5762         (rank_one_type): ... this.
5763
5764 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5765
5766         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5767         from...
5768         (rank_one_type): ... this.
5769
5770 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5771
5772         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5773         from...
5774         (rank_one_type): ... this.
5775
5776 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5777
5778         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5779         from...
5780         (rank_one_type): ... this.
5781
5782 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5783
5784         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5785         from...
5786         (rank_one_type): ... this.
5787
5788 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5789
5790         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5791         from...
5792         (rank_one_type): ... this.
5793
5794 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5795
5796         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5797         from...
5798         (rank_one_type): ... this.
5799
5800 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5801
5802         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5803         inferior-events' shows the example events.
5804
5805 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5806
5807         Support styling on native MS-Windows console
5808
5809         PR/24315
5810         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5811         on MS-Windows if $TERM is not defined.
5812
5813         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5814
5815         * posix-hdep.c (gdb_console_fputs):
5816         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5817         functions.
5818         * ui-file.h (gdb_console_fputs): Add prototype.
5819
5820         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5821         back to fputs only if the former returns zero.
5822
5823 2019-03-07  Tom Tromey  <tom@tromey.com>
5824
5825         * symmisc.c (print_symbol_bcache_statistics): Update.
5826         (print_objfile_statistics): Update.
5827         * symfile.c (allocate_symtab): Update.
5828         * stabsread.c: Don't include bcache.h.
5829         * psymtab.h (struct psymbol_bcache): Don't declare.
5830         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5831         (psymbol_bcache_init, psymbol_bcache_free)
5832         (psymbol_bcache_get_bcache): Don't declare.
5833         * psymtab.c (struct psymbol_bcache): Remove.
5834         (psymtab_storage::psymtab_storage): Update.
5835         (psymtab_storage::~psymtab_storage): Update.
5836         (psymbol_bcache_init, psymbol_bcache_free)
5837         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5838         (add_psymbol_to_bcache): Update.
5839         (allocate_psymtab): Update.
5840         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5841         macro_cache>: No longer pointers.
5842         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5843         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5844         * macrotab.c (macro_bcache): Update.
5845         * macroexp.c: Don't include bcache.h.
5846         * gdbtypes.c (check_types_worklist): Update.
5847         (types_deeply_equal): Remove TRY/CATCH.  Update.
5848         * elfread.c (elf_symtab_read): Update.
5849         * dwarf2read.c: Don't include bcache.h.
5850         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5851         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5852         (print_bcache_statistics, bcache_memory_used): Don't declare.
5853         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5854         methods.  Rename all data members.
5855         * bcache.c (struct bcache): Move to bcache.h.
5856         (bcache::expand_hash_table): Rename from expand_hash_table.
5857         (bcache): Remove.
5858         (bcache::insert): Rename from bcache_full.
5859         (bcache::compare): Rename from bcache_compare.
5860         (bcache_xmalloc): Remove.
5861         (bcache::~bcache): Rename from bcache_xfree.
5862         (bcache::print_statistics): Rename from print_bcache_statistics.
5863         (bcache::memory_used): Rename from bcache_memory_used.
5864
5865 2019-03-07  Pedro Alves  <palves@redhat.com>
5866
5867         * infrun.c (normal_stop): Also check for
5868         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5869
5870 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5871
5872         * f-lang.c (value_from_host_double): Moved to...
5873         * value.c (value_from_host_double): ...here.
5874         * value.h (value_from_host_double): Declare.
5875         * guile/scm-math.c (vlscm_convert_typed_number): Use
5876         value_from_host_double.
5877         (vlscm_convert_number): Likewise.
5878         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5879         * python/py-value.c (convert_value_from_python): Likewise.
5880
5881 2019-03-06  Tom Tromey  <tom@tromey.com>
5882
5883         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5884
5885 2019-03-06  Tom Tromey  <tom@tromey.com>
5886
5887         * utils.h (free_current_contents): Don't declare.
5888         * utils.c (free_current_contents): Remove.
5889
5890 2019-03-06  Tom Tromey  <tom@tromey.com>
5891
5892         * top.c (quit_force): Update.
5893         * main.c (captured_command_loop): Update.
5894         * common/new-op.c (operator new): Update.
5895         * common/common-exceptions.c (struct catcher)
5896         <save_cleanup_chain>: Remove member.
5897         (exceptions_state_mc_init): Update.
5898         (exception_try_scope_entry): Return nullptr.
5899         (exception_try_scope_exit, exception_rethrow)
5900         (throw_exception_sjlj, throw_exception_cxx): Update.
5901         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5902         (all_cleanups, do_cleanups, discard_cleanups)
5903         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5904         (restore_cleanups, restore_final_cleanups): Don't declare.
5905         (do_final_cleanups): Remove parameter.
5906         * common/cleanups.c (cleanup_chain, make_cleanup)
5907         (make_cleanup_dtor, all_cleanups, do_cleanups)
5908         (discard_my_cleanups, discard_cleanups)
5909         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5910         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5911         (null_cleanup): Remove.
5912         (do_final_cleanups): Remove parameter.
5913
5914 2019-03-06  Tom Tromey  <tom@tromey.com>
5915
5916         * remote.c (remote_target::remote_parse_stop_reply): Use
5917         unique_xmalloc_ptr.
5918
5919 2019-03-06  Tom Tromey  <tom@tromey.com>
5920
5921         * stabsread.c (struct stabs_field_info): Rename from field_info.
5922         <list, fnlist>: Add initializers.
5923         <obstack>: New member.
5924         (read_member_functions, read_struct_fields, read_baseclasses):
5925         Allocate on obstack.  Don't use cleanups.
5926         (read_one_struct_field, read_member_functions, read_struct_fields)
5927         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5928         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5929         (read_struct_type): Update.
5930
5931 2019-03-06  Tom Tromey  <tom@tromey.com>
5932
5933         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5934         * common/filestuff.h (make_cleanup_close): Don't declare.
5935         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5936         Remove.
5937
5938 2019-03-06  Tom Tromey  <tom@tromey.com>
5939
5940         * solib-aix.c: Use make_scope_exit.
5941
5942 2019-03-06  Tom Tromey  <tom@tromey.com>
5943
5944         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5945         Use make_scope_exit.
5946
5947 2019-03-06  Tom Tromey  <tom@tromey.com>
5948
5949         * solib-svr4.c (disable_probes_interface): Remove parameter.
5950         (svr4_handle_solib_event): Use make_scope_exit.
5951
5952 2019-03-06  Tom Tromey  <tom@tromey.com>
5953
5954         * remote.c (struct stop_reply_deleter): Remove.
5955         (stop_reply_up): Update.
5956         (struct stop_reply): Derive from notif_event.  Don't typedef.
5957         <regcache>: Now a std::vector.
5958         (stop_reply_xfree): Remove.
5959         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5960         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5961         (remote_target::discard_pending_stop_replies): Use delete.
5962         (remote_target::remote_parse_stop_reply): Update.
5963         (remote_target::process_stop_reply): Update.
5964         * remote-notif.h (struct notif_event): Add virtual destructor.
5965         Remove "dtr" member.
5966         (struct notif_client) <alloc_event>: Return a unique_ptr.
5967         (notif_event_xfree): Don't declare.
5968         (notif_event_up): New typedef.
5969         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5970         (notif_event_xfree, do_notif_event_xfree): Remove.
5971         (remote_notif_state_xfree): Update.
5972
5973 2019-03-06  Tom Tromey  <tom@tromey.com>
5974
5975         * infrun.c (displaced_step_clear_cleanup): Now a
5976         forward_scope_exit type.
5977         (displaced_step_prepare_throw): Update.
5978         (displaced_step_fixup): Update.
5979
5980 2019-03-06  Tom Tromey  <tom@tromey.com>
5981
5982         * inferior.h (class inferior): Update comment.
5983         * gdbthread.h (class thread_info): Update comment.
5984
5985 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5986             Tom Tromey  <tom@tromey.com>
5987
5988         * stabsread.h (struct stab_section_list): Remove.
5989         (coffstab_build_psymtabs): Update.
5990         * dbxread.c (symbuf_sections): Now a std::vector.
5991         (sect_idx): New global.
5992         (fill_symbuf): Update.
5993         (coffstab_build_psymtabs): Change type of stabsects parameter.
5994         Update.
5995         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5996         std::vector.
5997         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5998         (coff_locate_sections): Update.
5999         (coff_symfile_read): Remove cleanups.  Update.
6000         (init_stringtab): Add storage parameter.
6001         (free_stringtab, free_stringtab_cleanup): Remove.
6002         (init_lineno): Add storage parameter.
6003         (free_linetab, free_linetab_cleanup): Remove.
6004
6005 2019-03-06  Pedro Alves  <palves@redhat.com>
6006
6007         * linux-fork.c (fork_info::clobber_regs): Delete.
6008         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6009         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6010         comment.  Adjust.
6011         (scoped_switch_fork_info::scoped_switch_fork_info)
6012         (checkpoint_command, linux_fork_context): Adjust
6013         fork_save_infrun_state calls.
6014
6015 2019-03-06  Pedro Alves  <palves@redhat.com>
6016
6017         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6018         (inf_has_multiple_threads): Return 'bool' and rewrite using
6019         inferior_info::threads().
6020
6021 2019-03-06  Pedro Alves  <palves@redhat.com>
6022
6023         * linux-fork.c: Include <list>.
6024         (fork_list): Now a std::list instance.
6025         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6026         (forks_exist_p, find_last_fork): Adjust.
6027         (new_fork): Delete.
6028         (one_fork_p): New.
6029         (add_fork): Adjust.
6030         (free_fork): Delete, folded into fork_info::~fork_info().
6031         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6032         Adjust.
6033         (init_fork_list): Delete.
6034         (linux_fork_killall, linux_fork_mourn_inferior)
6035         (linux_fork_detach, info_checkpoints_command): Adjust.
6036         (_initialize_linux_fork): No longer call init_fork_list.
6037
6038 2019-03-06  Pedro Alves  <palves@redhat.com>
6039
6040         * linux-fork.c (new_fork): New, split out of ...
6041         (add_fork): ... this.  Return void.  Move "first fork" special
6042         case from here, to ...
6043         (checkpoint_command): ... here.
6044         * linux-linux.h (add_fork): Return void.
6045
6046 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6047
6048         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6049
6050 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6051             Chris January  <chris.january@arm.com>
6052             David Lecomber  <david.lecomber@arm.com>
6053
6054         * f-exp.y: New token, UNOP_INTRINSIC.
6055         (exp): New pattern using UNOP_INTRINSIC token.
6056         (f77_keywords): Add 'abs' keyword.
6057         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6058         (value_from_host_double): New function.
6059         (evaluate_subexp_f): Support UNOP_ABS.
6060
6061 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6062
6063         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6064         types.
6065
6066 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6067
6068         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6069         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6070         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6071
6072 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6073
6074         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6075
6076 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6077             Chris January  <chris.january@arm.com>
6078
6079         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6080         * f-exp.y: Define 'KIND' token.
6081         (exp): New pattern for KIND expressions.
6082         (ptype): Handle types with a kind extension.
6083         (direct_abs_decl): Extend to spot kind extensions.
6084         (f77_keywords): Add 'kind' to the list.
6085         (push_kind_type): New function.
6086         (convert_to_kind_type): New function.
6087         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6088         * parse.c (operator_length_standard): Likewise.
6089         * parser-defs.h (enum type_pieces): Add tp_kind.
6090         * std-operator.def: Add UNOP_KIND.
6091
6092 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6093
6094         * f-exp.y (f_parse): Set yydebug.
6095
6096 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6097
6098         * f-lang.c (evaluate_subexp_f): New function.
6099         (exp_descriptor_f): New global.
6100         (f_language_defn): Use exp_descriptor_f instead of
6101         exp_descriptor_standard.
6102
6103 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6104
6105         * f-exp.y (struct token): Add comments.
6106         (dot_ops): Remove uppercase versions and the end marker.
6107         (f77_keywords): Likewise.
6108         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6109         entries in the dot_ops array are case insensitive, and use
6110         strncasecmp to compare strings.  Also some whitespace cleanup in
6111         this area.  Similar for the f77_keywords array, except entries in
6112         this list might be case sensitive.
6113
6114 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6115
6116         * f-exp.y (struct f77_boolean_val): Add comments.
6117         (boolean_values): Remove uppercase versions, and end marker.
6118         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6119         and use strncasecmp to achieve case insensitivity.  Additionally,
6120         perform whitespace cleanup around this code.
6121
6122 2019-03-06  Tom Tromey  <tromey@adacore.com>
6123
6124         * remote-sim.c (gdbsim_target_open): Use result of
6125         gdb_argv::release.
6126
6127 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6128         Dirk Schubert  <dirk.schubert@arm.com>
6129         Chris January  <chris.january@arm.com>
6130
6131         * eval.c (evaluate_subexp_standard): Call Fortran argument
6132         wrapping logic.
6133         * f-lang.c (struct value): A value which can be passed into a
6134         Fortran function call.
6135         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6136         where appropriate.
6137         (struct type): Value ready for a Fortran function call.
6138         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6139         is needed.
6140         * f-lang.h (fortran_argument_convert): Declaration.
6141         (fortran_preserve_arg_pointer): Declaration.
6142         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6143
6144 2019-03-05  Tom Tromey  <tromey@adacore.com>
6145
6146         * python/py-prettyprint.c (print_string_repr): Remove #if.
6147         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6148
6149 2019-03-05  Tom Tromey  <tromey@adacore.com>
6150
6151         * target.c (the_dummy_target): Move later.  Change type to
6152         "dummy_target".
6153         (initialize_targets): Don't initialize the_dummy_target.
6154
6155 2019-03-05  Tom Tromey  <tromey@adacore.com>
6156
6157         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6158         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6159
6160 2019-03-05  Tom Tromey  <tromey@adacore.com>
6161
6162         * windows-nat.c (windows_nat_target::attach)
6163         (windows_nat_target::detach): Don't call gdb_flush.
6164         * valprint.c (generic_val_print, val_print, val_print_string):
6165         Don't call gdb_flush.
6166         * utils.c (defaulted_query): Don't call gdb_flush.
6167         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6168         * target.c (target_announce_detach): Don't call gdb_flush.
6169         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6170         * remote.c (extended_remote_target::attach): Don't call
6171         gdb_flush.
6172         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6173         * printcmd.c (do_examine): Don't call gdb_flush.
6174         (info_display_command): Don't call gdb_flush.
6175         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6176         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6177         * memattr.c (info_mem_command): Don't call gdb_flush.
6178         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6179         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6180         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6181         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6182         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6183         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6184         (gnu_nat_target::detach): Don't call gdb_flush.
6185         * f-valprint.c (f_val_print): Don't call gdb_flush.
6186         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6187         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6188         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6189         gdb_flush.
6190         * c-valprint.c (c_val_print): Don't call gdb_flush.
6191         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6192
6193 2019-03-05  Tom Tromey  <tromey@adacore.com>
6194
6195         * varobj.c (update_dynamic_varobj_children): Update.
6196         (install_default_visualizer): Use reset, not release.
6197         * value.c (set_internalvar): Update.
6198         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6199         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6200         ATTRIBUTE_UNUSED_RESULT.
6201
6202 2019-03-05  Tom Tromey  <tromey@adacore.com>
6203
6204         * remote.c (class scoped_remote_fd) <release>: Add
6205         ATTRIBUTE_UNUSED_RESULT.
6206
6207 2019-03-05  Tom Tromey  <tromey@adacore.com>
6208
6209         * macroexp.c (struct macro_buffer) <release>: Add
6210         ATTRIBUTE_UNUSED_RESULT.
6211
6212 2019-03-05  Tom Tromey  <tromey@adacore.com>
6213
6214         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6215         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6216         ATTRIBUTE_UNUSED_RESULT.
6217
6218 2019-03-05  Tom Tromey  <tromey@adacore.com>
6219
6220         * common/scoped_fd.h (class scoped_fd) <release>: Add
6221         ATTRIBUTE_UNUSED_RESULT.
6222
6223 2019-03-05  Tom Tromey  <tromey@adacore.com>
6224
6225         * parser-defs.h (struct parser_state) <release>: Add
6226         ATTRIBUTE_UNUSED_RESULT.
6227
6228 2019-03-05  Tom Tromey  <tromey@adacore.com>
6229
6230         * utils.h (class gdb_argv) <release>: Add
6231         ATTRIBUTE_UNUSED_RESULT.
6232         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6233
6234 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6235
6236         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6237         for-loop range, to avoid compiler warnings.
6238
6239         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6240         avoid compiler warnings about unused variables.
6241
6242         * NEWS: Mention end of support for native debugging on MS-Windows
6243         before XP.
6244
6245         PR gdb/24292
6246         * common/netstuff.c:
6247         * gdbserver/gdbreplay.c
6248         * gdbserver/remote-utils.c:
6249         * ser-tcp.c:
6250         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6251         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6252         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6253         'getaddrinfo' and 'freeaddrinfo' were not available before
6254         Windows XP, and mingw.org's MinGW headers by default define
6255         _WIN32_WINNT to 0x500.
6256
6257 2019-03-01  Gary Benson <gbenson@redhat.com>
6258
6259         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6260
6261 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6262             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6263
6264         PR gdb/8527
6265         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6266         set_sigint_trap, clear_sigint_trap.
6267
6268 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6269
6270         * target.c (target_detach): Clear the regcache and the
6271         frame cache.
6272
6273 2019-02-27  Pedro Alves  <palves@redhat.com>
6274
6275         * utils.c (set_screen_size): When we cap the height/width sizes,
6276         tweak the corresponding command variable to show "unlimited":
6277
6278 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6279             Pedro Alves  <palves@redhat.com>
6280
6281         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6282         before calling rl_set_screen_size.
6283
6284 2019-02-27  Tom Tromey  <tromey@adacore.com>
6285
6286         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6287         define.
6288         * python/py-value.c: Remove Python 2.4 workaround.
6289         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6290         workaround.
6291         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6292         Python 2.4 workaround.
6293         * python/python-internal.h: Remove Python 2.4 comment.
6294         (Py_ssize_t): Don't define.
6295         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6296         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6297         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6298         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6299         * python/python.c (do_start_initialization): Remove Python 2.4
6300         workaround.
6301         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6302         (print_children): Remove Python 2.4 workaround.
6303         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6304         workaround.
6305         (CHARBUFFERPROC_NAME): Remove.
6306         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6307         Python 2.4 workaround.
6308
6309 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6310
6311         * NEWS: Note minimum Python version.
6312
6313 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6314
6315         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6316         code from these functions.  Remove corresponding ifdefs.  Use
6317         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6318         Remove gotos and target of gotos.
6319         (infpy_search_memory): Likewise.
6320
6321 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6322
6323         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6324         (hppa_gdbarch_init): Don't register deleted functions with
6325         gdbarch.
6326
6327 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6328
6329         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6330         (h8300_unwind_sp): Delete.
6331         (h8300_dummy_id): Delete.
6332         (h8300_gdbarch_init): Don't register deleted functions with
6333         gdbarch.
6334
6335 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6336
6337         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6338         (ft32_unwind_pc): Delete.
6339         (ft32_unwind_sp): Delete.
6340         (ft32_gdbarch_init): Don't register deleted functions with
6341         gdbarch.
6342
6343 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6344
6345         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6346         (frv_unwind_pc): Delete.
6347         (frv_unwind_sp): Delete.
6348         (frv_gdbarch_init): Don't register deleted functions with
6349         gdbarch.
6350
6351 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6352
6353         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6354         (riscv_unwind_pc): Delete.
6355         (riscv_unwind_sp): Delete.
6356         (riscv_gdbarch_init): Don't register deleted functions with
6357         gdbarch.
6358
6359 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6360
6361         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6362         (csky_unwind_pc): Delete.
6363         (csky_unwind_sp): Delete.
6364         (csky_gdbarch_init): Don't register deleted functions with
6365         gdbarch.
6366
6367 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6368
6369         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6370         (cris_unwind_pc): Delete.
6371         (cris_unwind_sp): Delete.
6372         (cris_gdbarch_init): Don't register deleted functions with
6373         gdbarch.
6374
6375 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6376
6377         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6378         (bfin_unwind_pc): Delete.
6379         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6380
6381 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6382
6383         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6384         (arm_unwind_pc): Delete.
6385         (arm_unwind_sp): Delete.
6386         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6387
6388 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6389
6390         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6391         (arc_unwind_pc): Delete.
6392         (arc_unwind_sp): Delete.
6393         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6394
6395 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6396
6397         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6398         (alpha_unwind_pc): Delete.
6399         (alpha_gdbarch_init): Don't register deleted functions with
6400         gdbarch.
6401
6402 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6403
6404         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6405         (aarch64_unwind_pc): Delete.
6406         (aarch64_unwind_sp): Delete.
6407         (aarch64_gdbarch_init): Don't register deleted functions with
6408         gdbarch.
6409
6410 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6411
6412         * gdbtypes.c (type_align): Don't consider static members when
6413         computing structure alignment.
6414
6415 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6416
6417         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6418         return 0 for other types.
6419         * arch-utils.c (default_type_align): Always return 0.
6420         * gdbarch.h: Regenerate.
6421         * gdbarch.sh (type_align): Extend comment.
6422         * gdbtypes.c (type_align): Add additional comments, always call
6423         gdbarch_type_align before applying the default rules.
6424         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6425         generic code will then apply a suitable default.
6426         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6427         types, return 0 for other types.
6428
6429 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6430
6431         * NEWS: Create a new section for the next release branch.
6432         Rename the section of the current branch, now that it has
6433         been cut.
6434
6435 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6436
6437         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6438         * version.in: Bump version to 8.3.50.DATE-git.
6439
6440 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6441
6442         * aix-thread.c (ptid_cmp): Remove unused variable.
6443         (get_signaled_thread): Likewise.
6444         (store_regs_user_thread): Likewise.
6445         (store_regs_kernel_thread): Likewise.
6446         (fetch_regs_kernel_thread): Remove shadowed variable.
6447
6448 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6449
6450         * features/riscv/32bit-cpu.xml: Add register numbers.
6451         * features/riscv/32bit-fpu.c: Regenerate.
6452         * features/riscv/32bit-fpu.xml: Add register numbers.
6453         * features/riscv/64bit-cpu.xml: Add register numbers.
6454         * features/riscv/64bit-fpu.c: Regenerate.
6455         * features/riscv/64bit-fpu.xml: Add register numbers.
6456
6457 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6458
6459         * NEWS: Mention two argument form of gdb.Value constructor.
6460         * python/py-value.c (convert_buffer_and_type_to_value): New
6461         function.
6462         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6463         Add support for handling an optional second argument.  Call
6464         convert_buffer_and_type_to_value as appropriate.
6465         * python/python-internal.h (Py_buffer_deleter): New struct.
6466         (Py_buffer_up): New typedef.
6467
6468 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6469
6470         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6471         instead of releasing ownership.
6472
6473 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6474
6475         * dwarf2read.c (open_and_init_dwp_file): Call
6476         elf_numsections instead of bfd_count_sections to initialize
6477         dwp_file->num_sections.
6478
6479 2019-02-25  Tom Tromey  <tromey@adacore.com>
6480
6481         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6482
6483 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6484
6485         * gcore.in: Add '--readnever' option when invoking GDB.
6486
6487 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6488
6489         * MAINTAINERS: Update my email address.
6490
6491 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6492
6493         * build-id.c (build_id_to_debug_bfd_1): New function.
6494         (build_id_to_debug_bfd): Look for separate debug file in
6495         sysroot.
6496
6497 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6498
6499         * gdbarch.sh: Update the copyright year range that is placed into
6500         generated files.
6501
6502 2019-02-22  Keith Seitz  <keiths@redhat.com>
6503
6504         PR symtab/23853
6505         * linespec.c (create_sals_line_offset): Search for the default
6506         symtab's filename instead of its fullname.
6507
6508 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6509
6510         * NEWS: Update style defaults.
6511
6512 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6513
6514         * main.c (captured_main_1): Disable styling in batch mode.
6515
6516 2019-02-20  Tom Tromey  <tom@tromey.com>
6517
6518         * symtab.c (symtab_symbol_info): Fix typos.
6519
6520 2019-02-20  Tom Tromey  <tromey@adacore.com>
6521
6522         * findcmd.c (_initialize_mem_search): Use upper case for
6523         metasyntactic variables.
6524
6525 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6526
6527         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6528         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6529
6530 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6531
6532         * top.h (source_file_name): Change to std::string.
6533         * top.c (source_file_name): Likewise.
6534         (command_line_input): Adjust.
6535         * cli/cli-script.c (script_from_file): Adjust.
6536
6537 2019-02-19  Tom Tromey  <tromey@adacore.com>
6538
6539         * ravenscar-thread.c
6540         (ravenscar_thread_target::update_thread_list): Don't call
6541         ada_build_task_list.
6542         * ada-lang.h (ada_build_task_list): Don't declare.
6543         * ada-tasks.c (struct ada_tasks_inferior_data)
6544         <task_list_valid_p>: Now bool.
6545         (read_known_tasks, ada_task_list_changed)
6546         (ada_tasks_invalidate_inferior_data): Update.
6547         (read_known_tasks_array): Return bool.
6548         (read_known_tasks_list): Likewise.
6549         (read_known_tasks): Return void.
6550         (ada_build_task_list): Now static.
6551
6552 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6553
6554         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6555         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6556
6557 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6558
6559         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6560         variant for ada_tasks_pspace_data_handle and
6561         ada_tasks_inferior_data_handle.
6562         (ada_tasks_pspace_data_cleanup): New function.
6563         (ada_tasks_inferior_data_cleanup): New function.
6564
6565 2019-02-17  Tom Tromey  <tom@tromey.com>
6566
6567         * macrotab.h (macro_source_fullname): Return a std::string.
6568         * macrotab.c (macro_include, check_for_redefinition)
6569         (macro_undef, macro_lookup_definition, foreach_macro)
6570         (foreach_macro_in_scope): Update.
6571         (macro_source_fullname): Return a std::string.
6572         * macrocmd.c (show_pp_source_pos): Update.
6573
6574 2019-02-17  Tom Tromey  <tom@tromey.com>
6575
6576         * macrocmd.c (show_pp_source_pos): Style the file names.
6577
6578 2019-02-17  Tom Tromey  <tom@tromey.com>
6579
6580         PR tui/24197:
6581         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6582
6583 2019-02-17  Tom Tromey  <tom@tromey.com>
6584
6585         * ada-lang.c (user_select_syms): Use filtered printing.
6586         * utils.c (wrap_style): New global.
6587         (desired_style): Remove.
6588         (emit_style_escape): Add stream parameter.
6589         (set_output_style, reset_terminal_style, prompt_for_continue):
6590         Update.
6591         (flush_wrap_buffer): Only flush gdb_stdout.
6592         (wrap_here): Set wrap_style.
6593         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6594         treat escape sequences as a character.  Change when wrap buffer is
6595         flushed.
6596         (fputs_styled): Do not set the output style when the default is
6597         requested.
6598         * ui-style.h (struct ui_file_style) <is_default>: New method.
6599         * source.c (print_source_lines_base): Emit escape sequences in one
6600         piece.
6601
6602 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6603
6604         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6605         integers and enumeration types.
6606
6607 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6608
6609         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6610         instead of lookup_symbol_in_language
6611         (do_exact_match): New function.
6612         (ada_get_symbol_name_matcher): Return do_exact_match when
6613         doing a verbatim match.
6614
6615 2019-02-15  Tom Tromey  <tromey@adacore.com>
6616
6617         * ravenscar-thread.c (ravenscar_thread_target::resume)
6618         (ravenscar_thread_target::wait): Special case wildcard requests.
6619
6620 2019-02-15  Tom Tromey  <tromey@adacore.com>
6621
6622         * ravenscar-thread.c (base_ptid): Remove.
6623         (struct ravenscar_thread_target) <close>: New method.
6624         <m_base_ptid>: New member.
6625         <update_inferior_ptid, active_task, task_is_currently_active,
6626         runtime_initialized>: Declare methods.
6627         <ravenscar_thread_target>: Add constructor.
6628         (ravenscar_thread_target::task_is_currently_active)
6629         (ravenscar_thread_target::update_inferior_ptid)
6630         (ravenscar_runtime_initialized): Rename.  Now methods.
6631         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6632         (ravenscar_thread_target::update_thread_list): Update.
6633         (ravenscar_thread_target::active_task): Now method.
6634         (ravenscar_thread_target::store_registers)
6635         (ravenscar_thread_target::prepare_to_store)
6636         (ravenscar_thread_target::prepare_to_store)
6637         (ravenscar_thread_target::mourn_inferior): Update.
6638         (ravenscar_inferior_created): Use "new" to create target.
6639         (ravenscar_thread_target::get_ada_task_ptid): Update.
6640         (_initialize_ravenscar): Don't initialize base_ptid.
6641         (ravenscar_ops): Remove global.
6642
6643 2019-02-15  Tom Tromey  <tromey@adacore.com>
6644
6645         * target.h (push_target): Declare new overload.
6646         * target.c (push_target): New overload, taking an rvalue reference.
6647         * remote.c (remote_target::open_1): Use push_target overload.
6648         * corelow.c (core_target_open): Use push_target overload.
6649
6650 2019-02-15  Tom Tromey  <tromey@adacore.com>
6651
6652         * ravenscar-thread.c (is_ravenscar_task)
6653         (ravenscar_task_is_currently_active): Return bool.
6654         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6655         (_initialize_ravenscar): Remove "(void)".
6656         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6657         Return bool.
6658
6659 2019-02-15  Tom Tromey  <tromey@adacore.com>
6660
6661         * ravenscar-thread.c (ravenscar_runtime_initializer)
6662         (has_ravenscar_runtime, get_running_thread_id)
6663         (ravenscar_thread_target::resume): Fix indentation.
6664
6665 2019-02-15  Tom Tromey  <tromey@adacore.com>
6666
6667         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6668         from ravenscar_arch_ops.
6669         (sparc_ravenscar_ops::fetch_registers)
6670         (sparc_ravenscar_ops::store_registers): Now methods.
6671         (sparc_ravenscar_prepare_to_store): Remove.
6672         (sparc_ravenscar_ops): Redefine.
6673         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6674         methods and destructor.  Remove members.
6675         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6676         (ravenscar_thread_target::store_registers)
6677         (ravenscar_thread_target::prepare_to_store): Update.
6678         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6679         Remove.
6680         (struct ppc_ravenscar_powerpc_ops): Derive from
6681         ravenscar_arch_ops.
6682         (ppc_ravenscar_powerpc_ops::fetch_registers)
6683         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6684         (ppc_ravenscar_powerpc_ops): Redefine.
6685         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6686         (ppc_ravenscar_e500_ops::fetch_registers)
6687         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6688         (ppc_ravenscar_e500_ops): Redefine.
6689         * aarch64-ravenscar-thread.c
6690         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6691         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6692         (aarch64_ravenscar_fetch_registers)
6693         (aarch64_ravenscar_store_registers): Now methods.
6694         (aarch64_ravenscar_ops): Redefine.
6695
6696 2019-02-15  Tom Tromey  <tromey@adacore.com>
6697
6698         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6699         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6700         (ravenscar_thread_target::stopped_by_watchpoint)
6701         (ravenscar_thread_target::stopped_data_address)
6702         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6703
6704 2019-02-15  Tom Tromey  <tromey@adacore.com>
6705
6706         * ravenscar-thread.c: Fix some typos.
6707
6708 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6709             Tom Tromey  <tromey@adacore.com>
6710
6711         * ada-lang.c (ada_exception_sal): Change addr_string to a
6712         std::string.
6713         (create_ada_exception_catchpoint): Update.
6714
6715 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6716             Tom Tromey  <tromey@adacore.com>
6717
6718         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6719         (bp_location_ops): Remove.
6720         (base_breakpoint_allocate_location): Update.
6721         (free_bp_location): Update.
6722         * ada-lang.c (class ada_catchpoint_location)
6723         <ada_catchpoint_location>: Remove ops parameter.
6724         (ada_catchpoint_location_dtor): Remove.
6725         (ada_catchpoint_location_ops): Remove.
6726         (allocate_location_exception): Update.
6727         * breakpoint.h (struct bp_location_ops): Remove.
6728         (class bp_location) <bp_location>: Remove bp_location_ops
6729         parameter.
6730         <~bp_location>: Add destructor.
6731         <ops>: Remove.
6732
6733 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6734             Pedro Alves  <palves@redhat.com>
6735
6736         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6737         'PATH_MAX'.
6738
6739 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6740             Samuel Thibault  <samuel.thibault@gnu.org>
6741             Thomas Schwinge  <thomas@codesourcery.com>
6742
6743         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6744         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6745
6746 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6747
6748         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6749         (check_empty): Use "const char *".
6750
6751         * gnu-nat.c (gnu_nat_target::detach): Instead of
6752         'detach_inferior (pid)' call
6753         'detach_inferior (find_inferior_pid (pid))'.
6754
6755         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6756         'nat/fork-inferior.o'.
6757         * gnu-nat.c: #include "nat/fork-inferior.h".
6758
6759         * gnu-nat.c (gnu_nat_target::detach): Instead of
6760         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6761         * gnu-nat.h: #include "inf-child.h".
6762         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6763         'i386_gnu_nat_target::fetch_registers'.
6764         (gnu_store_registers): Rename/move to
6765         'i386_gnu_nat_target::store_registers'.
6766
6767         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6768         * gnu-nat.h (mach_thread_info): New function.
6769         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6770
6771         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6772
6773 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6774
6775         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6776
6777 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6778
6779         * windows-nat.c (windows_add_thread): Add new parameter
6780         "main_thread_p" with default value set to false.  Update
6781         function documentation as well as all callers.
6782         (windows_delete_thread): Likewise.
6783         (fake_create_process): Update call to windows_add_thread.
6784         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6785         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6786         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6787         call to windows_delete_thread.
6788
6789 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6790
6791         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6792
6793 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6794
6795         * symfile.c (find_separate_debug_file): Use canonical path of
6796         sysroot with child_path instead of gdb_sysroot if it is valid.
6797
6798 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6799
6800         * symfile.c (find_separate_debug_file): Use child_path to
6801         determine if an object file is under a sysroot.
6802
6803 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6804
6805         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6806         unittests/child-path-selftests.c.
6807         * common/pathstuff.c (child_path): New function.
6808         * common/pathstuff.h (child_path): New prototype.
6809         * unittests/child-path-selftests.c: New file.
6810
6811 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6812
6813         * symfile.c (find_separate_debug_file): Look for separate debug
6814         files in debug directories under the sysroot.
6815
6816 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6817
6818         * symtab.h (struct minimal_symbol data_p): New const method.
6819         (struct minimal_symbol text_p): Likewise.
6820         * symtab.c (output_source_filename): Use file name style
6821         to print file name.
6822         (print_symbol_info): Likewise.
6823         (print_msymbol_info): Use address style to print addresses.
6824         Use function name style to print executable text symbols.
6825         (expand_symtab_containing_pc): Use data_p.
6826         (find_pc_sect_compunit_symtab): Likewise.
6827
6828 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6829
6830         * breakpoint.c (describe_other_breakpoints): Use address style
6831         to print addresses.
6832         (say_where): Likewise.
6833
6834 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6835
6836         * ada-typeprint.c (print_func_type): Print function name
6837         style to print function name.
6838         * c-typeprint.c (c_print_type_1): Likewise.
6839
6840 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6841
6842         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6843         for execve.
6844
6845 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6846
6847         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6848         type_stack.
6849
6850 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6851
6852         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6853         TYPE_CODE_REF types.
6854
6855 2019-02-08  Jim Wilson  <jimw@sifive.com>
6856
6857         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6858         (riscv_linux_fregset): New.
6859         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6860
6861 2019-02-07  Tom Tromey  <tom@tromey.com>
6862
6863         * thread.c (thread_cancel_execution_command): Update.
6864         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6865         methods.
6866         (struct thread_fsm_ops): Remove.
6867         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6868         (thread_fsm_should_stop, thread_fsm_return_value)
6869         (thread_fsm_set_finished, thread_fsm_finished_p)
6870         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6871         Don't declare.
6872         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6873         * infrun.c (clear_proceed_status_thread)
6874         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6875         (print_stop_event): Update.
6876         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6877         Add constructor.
6878         (step_command_fsm_ops): Remove.
6879         (new_step_command_fsm): Remove.
6880         (step_1): Update.
6881         (step_command_fsm::should_stop): Rename from
6882         step_command_fsm_should_stop.
6883         (step_command_fsm::clean_up): Rename from
6884         step_command_fsm_clean_up.
6885         (step_command_fsm::do_async_reply_reason): Rename from
6886         step_command_fsm_async_reply_reason.
6887         (struct until_next_fsm): Inherit from thread_fsm.  Add
6888         constructor.
6889         (until_next_fsm_ops): Remove.
6890         (new_until_next_fsm): Remove.
6891         (until_next_fsm::should_stop): Rename from
6892         until_next_fsm_should_stop.
6893         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6894         (until_next_fsm::do_async_reply_reason): Rename from
6895         until_next_fsm_async_reply_reason.
6896         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6897         constructor.  Change type of breakpoint.
6898         (finish_command_fsm_ops): Remove.
6899         (new_finish_command_fsm): Remove.
6900         (finish_command_fsm::should_stop): Rename from
6901         finish_command_fsm_should_stop.
6902         (finish_command_fsm::clean_up): Rename from
6903         finish_command_fsm_clean_up.
6904         (finish_command_fsm::return_value): Rename from
6905         finish_command_fsm_return_value.
6906         (finish_command_fsm::do_async_reply_reason): Rename from
6907         finish_command_fsm_async_reply_reason.
6908         (finish_command): Update.
6909         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6910         Add constructor.
6911         (call_thread_fsm_ops): Remove.
6912         (call_thread_fsm::call_thread_fsm): Rename from
6913         new_call_thread_fsm.
6914         (call_thread_fsm::should_stop): Rename from
6915         call_thread_fsm_should_stop.
6916         (call_thread_fsm::should_notify_stop): Rename from
6917         call_thread_fsm_should_notify_stop.
6918         (run_inferior_call, call_function_by_hand_dummy): Update.
6919         * cli/cli-interp.c (should_print_stop_to_console): Update.
6920         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6921         Add constructor.  Change type of location_breakpoint,
6922         caller_breakpoint.
6923         (until_break_fsm_ops): Remove.
6924         (new_until_break_fsm): Remove.
6925         (until_break_fsm::should_stop): Rename from
6926         until_break_fsm_should_stop.
6927         (until_break_fsm::clean_up): Rename from
6928         until_break_fsm_clean_up.
6929         (until_break_fsm::do_async_reply_reason): Rename from
6930         until_break_fsm_async_reply_reason.
6931         (until_break_command): Update.
6932         * thread-fsm.c: Remove.
6933         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6934
6935 2019-02-07  Tom Tromey  <tom@tromey.com>
6936
6937         * yy-remap.h: Add include guard.
6938         * xtensa-tdep.h: Add include guard.
6939         * xcoffread.h: Rename include guard.
6940         * varobj-iter.h: Add include guard.
6941         * tui/tui.h: Rename include guard.
6942         * tui/tui-winsource.h: Rename include guard.
6943         * tui/tui-wingeneral.h: Rename include guard.
6944         * tui/tui-windata.h: Rename include guard.
6945         * tui/tui-win.h: Rename include guard.
6946         * tui/tui-stack.h: Rename include guard.
6947         * tui/tui-source.h: Rename include guard.
6948         * tui/tui-regs.h: Rename include guard.
6949         * tui/tui-out.h: Rename include guard.
6950         * tui/tui-layout.h: Rename include guard.
6951         * tui/tui-io.h: Rename include guard.
6952         * tui/tui-hooks.h: Rename include guard.
6953         * tui/tui-file.h: Rename include guard.
6954         * tui/tui-disasm.h: Rename include guard.
6955         * tui/tui-data.h: Rename include guard.
6956         * tui/tui-command.h: Rename include guard.
6957         * tic6x-tdep.h: Add include guard.
6958         * target/waitstatus.h: Rename include guard.
6959         * target/wait.h: Rename include guard.
6960         * target/target.h: Rename include guard.
6961         * target/resume.h: Rename include guard.
6962         * target-float.h: Rename include guard.
6963         * stabsread.h: Add include guard.
6964         * rs6000-tdep.h: Add include guard.
6965         * riscv-fbsd-tdep.h: Add include guard.
6966         * regformats/regdef.h: Rename include guard.
6967         * record.h: Rename include guard.
6968         * python/python.h: Rename include guard.
6969         * python/python-internal.h: Rename include guard.
6970         * python/py-stopevent.h: Rename include guard.
6971         * python/py-ref.h: Rename include guard.
6972         * python/py-record.h: Rename include guard.
6973         * python/py-record-full.h: Rename include guard.
6974         * python/py-record-btrace.h: Rename include guard.
6975         * python/py-instruction.h: Rename include guard.
6976         * python/py-events.h: Rename include guard.
6977         * python/py-event.h: Rename include guard.
6978         * procfs.h: Add include guard.
6979         * proc-utils.h: Add include guard.
6980         * p-lang.h: Add include guard.
6981         * or1k-tdep.h: Rename include guard.
6982         * observable.h: Rename include guard.
6983         * nto-tdep.h: Rename include guard.
6984         * nat/x86-linux.h: Rename include guard.
6985         * nat/x86-linux-dregs.h: Rename include guard.
6986         * nat/x86-gcc-cpuid.h: Add include guard.
6987         * nat/x86-dregs.h: Rename include guard.
6988         * nat/x86-cpuid.h: Rename include guard.
6989         * nat/ppc-linux.h: Rename include guard.
6990         * nat/mips-linux-watch.h: Rename include guard.
6991         * nat/linux-waitpid.h: Rename include guard.
6992         * nat/linux-ptrace.h: Rename include guard.
6993         * nat/linux-procfs.h: Rename include guard.
6994         * nat/linux-osdata.h: Rename include guard.
6995         * nat/linux-nat.h: Rename include guard.
6996         * nat/linux-namespaces.h: Rename include guard.
6997         * nat/linux-btrace.h: Rename include guard.
6998         * nat/glibc_thread_db.h: Rename include guard.
6999         * nat/gdb_thread_db.h: Rename include guard.
7000         * nat/gdb_ptrace.h: Rename include guard.
7001         * nat/fork-inferior.h: Rename include guard.
7002         * nat/amd64-linux-siginfo.h: Rename include guard.
7003         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7004         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7005         * nat/aarch64-linux.h: Rename include guard.
7006         * nat/aarch64-linux-hw-point.h: Rename include guard.
7007         * mn10300-tdep.h: Add include guard.
7008         * mips-linux-tdep.h: Add include guard.
7009         * mi/mi-parse.h: Rename include guard.
7010         * mi/mi-out.h: Rename include guard.
7011         * mi/mi-main.h: Rename include guard.
7012         * mi/mi-interp.h: Rename include guard.
7013         * mi/mi-getopt.h: Rename include guard.
7014         * mi/mi-console.h: Rename include guard.
7015         * mi/mi-common.h: Rename include guard.
7016         * mi/mi-cmds.h: Rename include guard.
7017         * mi/mi-cmd-break.h: Rename include guard.
7018         * m2-lang.h: Add include guard.
7019         * location.h: Rename include guard.
7020         * linux-record.h: Rename include guard.
7021         * linux-nat.h: Add include guard.
7022         * linux-fork.h: Add include guard.
7023         * i386-darwin-tdep.h: Rename include guard.
7024         * hppa-linux-offsets.h: Add include guard.
7025         * guile/guile.h: Rename include guard.
7026         * guile/guile-internal.h: Rename include guard.
7027         * gnu-nat.h: Rename include guard.
7028         * gdb-stabs.h: Rename include guard.
7029         * frv-tdep.h: Add include guard.
7030         * f-lang.h: Add include guard.
7031         * event-loop.h: Add include guard.
7032         * darwin-nat.h: Rename include guard.
7033         * cp-abi.h: Rename include guard.
7034         * config/sparc/nm-sol2.h: Rename include guard.
7035         * config/nm-nto.h: Rename include guard.
7036         * config/nm-linux.h: Add include guard.
7037         * config/i386/nm-i386gnu.h: Rename include guard.
7038         * config/djgpp/nl_types.h: Rename include guard.
7039         * config/djgpp/langinfo.h: Rename include guard.
7040         * compile/gcc-cp-plugin.h: Add include guard.
7041         * compile/gcc-c-plugin.h: Add include guard.
7042         * compile/compile.h: Rename include guard.
7043         * compile/compile-object-run.h: Rename include guard.
7044         * compile/compile-object-load.h: Rename include guard.
7045         * compile/compile-internal.h: Rename include guard.
7046         * compile/compile-cplus.h: Rename include guard.
7047         * compile/compile-c.h: Rename include guard.
7048         * common/xml-utils.h: Rename include guard.
7049         * common/x86-xstate.h: Rename include guard.
7050         * common/version.h: Rename include guard.
7051         * common/vec.h: Rename include guard.
7052         * common/tdesc.h: Rename include guard.
7053         * common/selftest.h: Rename include guard.
7054         * common/scoped_restore.h: Rename include guard.
7055         * common/scoped_mmap.h: Rename include guard.
7056         * common/scoped_fd.h: Rename include guard.
7057         * common/safe-iterator.h: Rename include guard.
7058         * common/run-time-clock.h: Rename include guard.
7059         * common/refcounted-object.h: Rename include guard.
7060         * common/queue.h: Rename include guard.
7061         * common/ptid.h: Rename include guard.
7062         * common/print-utils.h: Rename include guard.
7063         * common/preprocessor.h: Rename include guard.
7064         * common/pathstuff.h: Rename include guard.
7065         * common/observable.h: Rename include guard.
7066         * common/netstuff.h: Rename include guard.
7067         * common/job-control.h: Rename include guard.
7068         * common/host-defs.h: Rename include guard.
7069         * common/gdb_wait.h: Rename include guard.
7070         * common/gdb_vecs.h: Rename include guard.
7071         * common/gdb_unlinker.h: Rename include guard.
7072         * common/gdb_unique_ptr.h: Rename include guard.
7073         * common/gdb_tilde_expand.h: Rename include guard.
7074         * common/gdb_sys_time.h: Rename include guard.
7075         * common/gdb_string_view.h: Rename include guard.
7076         * common/gdb_splay_tree.h: Rename include guard.
7077         * common/gdb_setjmp.h: Rename include guard.
7078         * common/gdb_ref_ptr.h: Rename include guard.
7079         * common/gdb_optional.h: Rename include guard.
7080         * common/gdb_locale.h: Rename include guard.
7081         * common/gdb_assert.h: Rename include guard.
7082         * common/filtered-iterator.h: Rename include guard.
7083         * common/filestuff.h: Rename include guard.
7084         * common/fileio.h: Rename include guard.
7085         * common/environ.h: Rename include guard.
7086         * common/common-utils.h: Rename include guard.
7087         * common/common-types.h: Rename include guard.
7088         * common/common-regcache.h: Rename include guard.
7089         * common/common-inferior.h: Rename include guard.
7090         * common/common-gdbthread.h: Rename include guard.
7091         * common/common-exceptions.h: Rename include guard.
7092         * common/common-defs.h: Rename include guard.
7093         * common/common-debug.h: Rename include guard.
7094         * common/cleanups.h: Rename include guard.
7095         * common/buffer.h: Rename include guard.
7096         * common/btrace-common.h: Rename include guard.
7097         * common/break-common.h: Rename include guard.
7098         * cli/cli-utils.h: Rename include guard.
7099         * cli/cli-style.h: Rename include guard.
7100         * cli/cli-setshow.h: Rename include guard.
7101         * cli/cli-script.h: Rename include guard.
7102         * cli/cli-interp.h: Rename include guard.
7103         * cli/cli-decode.h: Rename include guard.
7104         * cli/cli-cmds.h: Rename include guard.
7105         * charset-list.h: Add include guard.
7106         * buildsym-legacy.h: Rename include guard.
7107         * bfin-tdep.h: Add include guard.
7108         * ax.h: Rename include guard.
7109         * arm-linux-tdep.h: Add include guard.
7110         * arm-fbsd-tdep.h: Add include guard.
7111         * arch/xtensa.h: Rename include guard.
7112         * arch/tic6x.h: Add include guard.
7113         * arch/i386.h: Add include guard.
7114         * arch/arm.h: Rename include guard.
7115         * arch/arm-linux.h: Rename include guard.
7116         * arch/arm-get-next-pcs.h: Rename include guard.
7117         * arch/amd64.h: Add include guard.
7118         * arch/aarch64-insn.h: Rename include guard.
7119         * arch-utils.h: Rename include guard.
7120         * annotate.h: Add include guard.
7121         * amd64-darwin-tdep.h: Rename include guard.
7122         * aarch64-linux-tdep.h: Add include guard.
7123         * aarch64-fbsd-tdep.h: Add include guard.
7124         * aarch32-linux-nat.h: Add include guard.
7125
7126 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7127
7128         * macrotab.c (macro_define_internal): New function that
7129         factorizes macro_define_object_internal and macro_define_function
7130         code.
7131         (macro_define_object_internal): Use macro_define_internal.
7132         (macro_define_function): Likewise.
7133
7134 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7135
7136         * macrocmd.c (extract_identifier): Return
7137         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7138         callers.
7139
7140 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7141
7142         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7143
7144 2019-02-05  Tom Tromey  <tom@tromey.com>
7145
7146         * target.c (target_stack::unpush): Move assertion earlier.
7147
7148 2019-01-30  Tom Tromey  <tom@tromey.com>
7149
7150         PR python/23615:
7151         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7152         (gdbpy_parse_and_eval): Likewise.
7153         * python/python-internal.h (gdbpy_allow_threads): New class.
7154
7155 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7156
7157         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7158         (aarch64_fbsd_fpregmap): Move earlier.
7159         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7160         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7161         instead of individual calls to trad_frame_set_reg_addr.
7162         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7163         earlier.
7164         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7165         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7166         instead of individual calls to trad_frame_set_reg_addr.
7167
7168 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7169
7170         * CONTRIBUTE: Replace contribution list with wiki link.
7171
7172 2019-01-25  Tom Tromey  <tom@tromey.com>
7173
7174         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7175
7176 2019-01-25  Tom Tromey  <tom@tromey.com>
7177
7178         * xtensa-linux-nat.c: Fix common/ includes.
7179         * xml-support.h: Fix common/ includes.
7180         * xml-support.c: Fix common/ includes.
7181         * x86-linux-nat.c: Fix common/ includes.
7182         * windows-nat.c: Fix common/ includes.
7183         * varobj.h: Fix common/ includes.
7184         * varobj.c: Fix common/ includes.
7185         * value.c: Fix common/ includes.
7186         * valops.c: Fix common/ includes.
7187         * utils.c: Fix common/ includes.
7188         * unittests/xml-utils-selftests.c: Fix common/ includes.
7189         * unittests/utils-selftests.c: Fix common/ includes.
7190         * unittests/unpack-selftests.c: Fix common/ includes.
7191         * unittests/tracepoint-selftests.c: Fix common/ includes.
7192         * unittests/style-selftests.c: Fix common/ includes.
7193         * unittests/string_view-selftests.c: Fix common/ includes.
7194         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7195         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7196         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7197         * unittests/rsp-low-selftests.c: Fix common/ includes.
7198         * unittests/parse-connection-spec-selftests.c: Fix common/
7199         includes.
7200         * unittests/optional-selftests.c: Fix common/ includes.
7201         * unittests/offset-type-selftests.c: Fix common/ includes.
7202         * unittests/observable-selftests.c: Fix common/ includes.
7203         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7204         * unittests/memrange-selftests.c: Fix common/ includes.
7205         * unittests/memory-map-selftests.c: Fix common/ includes.
7206         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7207         * unittests/function-view-selftests.c: Fix common/ includes.
7208         * unittests/environ-selftests.c: Fix common/ includes.
7209         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7210         * unittests/common-utils-selftests.c: Fix common/ includes.
7211         * unittests/cli-utils-selftests.c: Fix common/ includes.
7212         * unittests/array-view-selftests.c: Fix common/ includes.
7213         * ui-file.c: Fix common/ includes.
7214         * tui/tui-io.c: Fix common/ includes.
7215         * tracepoint.h: Fix common/ includes.
7216         * tracepoint.c: Fix common/ includes.
7217         * tracefile-tfile.c: Fix common/ includes.
7218         * top.h: Fix common/ includes.
7219         * top.c: Fix common/ includes.
7220         * thread.c: Fix common/ includes.
7221         * target/waitstatus.h: Fix common/ includes.
7222         * target/waitstatus.c: Fix common/ includes.
7223         * target.h: Fix common/ includes.
7224         * target.c: Fix common/ includes.
7225         * target-memory.c: Fix common/ includes.
7226         * target-descriptions.c: Fix common/ includes.
7227         * symtab.h: Fix common/ includes.
7228         * symfile.c: Fix common/ includes.
7229         * stap-probe.c: Fix common/ includes.
7230         * spu-linux-nat.c: Fix common/ includes.
7231         * sparc-nat.c: Fix common/ includes.
7232         * source.c: Fix common/ includes.
7233         * solib.c: Fix common/ includes.
7234         * solib-target.c: Fix common/ includes.
7235         * ser-unix.c: Fix common/ includes.
7236         * ser-tcp.c: Fix common/ includes.
7237         * ser-pipe.c: Fix common/ includes.
7238         * ser-base.c: Fix common/ includes.
7239         * selftest-arch.c: Fix common/ includes.
7240         * s12z-tdep.c: Fix common/ includes.
7241         * rust-exp.y: Fix common/ includes.
7242         * rs6000-aix-tdep.c: Fix common/ includes.
7243         * riscv-tdep.c: Fix common/ includes.
7244         * remote.c: Fix common/ includes.
7245         * remote-notif.h: Fix common/ includes.
7246         * remote-fileio.h: Fix common/ includes.
7247         * remote-fileio.c: Fix common/ includes.
7248         * regcache.h: Fix common/ includes.
7249         * regcache.c: Fix common/ includes.
7250         * record-btrace.c: Fix common/ includes.
7251         * python/python.c: Fix common/ includes.
7252         * python/py-type.c: Fix common/ includes.
7253         * python/py-inferior.c: Fix common/ includes.
7254         * progspace.h: Fix common/ includes.
7255         * producer.c: Fix common/ includes.
7256         * procfs.c: Fix common/ includes.
7257         * proc-api.c: Fix common/ includes.
7258         * printcmd.c: Fix common/ includes.
7259         * ppc-linux-nat.c: Fix common/ includes.
7260         * parser-defs.h: Fix common/ includes.
7261         * osdata.c: Fix common/ includes.
7262         * obsd-nat.c: Fix common/ includes.
7263         * nat/x86-linux.c: Fix common/ includes.
7264         * nat/x86-linux-dregs.c: Fix common/ includes.
7265         * nat/x86-dregs.h: Fix common/ includes.
7266         * nat/x86-dregs.c: Fix common/ includes.
7267         * nat/ppc-linux.c: Fix common/ includes.
7268         * nat/mips-linux-watch.h: Fix common/ includes.
7269         * nat/mips-linux-watch.c: Fix common/ includes.
7270         * nat/linux-waitpid.c: Fix common/ includes.
7271         * nat/linux-ptrace.h: Fix common/ includes.
7272         * nat/linux-ptrace.c: Fix common/ includes.
7273         * nat/linux-procfs.c: Fix common/ includes.
7274         * nat/linux-personality.c: Fix common/ includes.
7275         * nat/linux-osdata.c: Fix common/ includes.
7276         * nat/linux-namespaces.c: Fix common/ includes.
7277         * nat/linux-btrace.h: Fix common/ includes.
7278         * nat/linux-btrace.c: Fix common/ includes.
7279         * nat/fork-inferior.c: Fix common/ includes.
7280         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7281         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7282         * nat/aarch64-linux.c: Fix common/ includes.
7283         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7284         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7285         * namespace.h: Fix common/ includes.
7286         * mips-linux-tdep.c: Fix common/ includes.
7287         * minsyms.c: Fix common/ includes.
7288         * mi/mi-parse.h: Fix common/ includes.
7289         * mi/mi-main.c: Fix common/ includes.
7290         * mi/mi-cmd-env.c: Fix common/ includes.
7291         * memrange.h: Fix common/ includes.
7292         * memattr.c: Fix common/ includes.
7293         * maint.h: Fix common/ includes.
7294         * maint.c: Fix common/ includes.
7295         * main.c: Fix common/ includes.
7296         * machoread.c: Fix common/ includes.
7297         * location.c: Fix common/ includes.
7298         * linux-thread-db.c: Fix common/ includes.
7299         * linux-nat.c: Fix common/ includes.
7300         * linux-fork.c: Fix common/ includes.
7301         * inline-frame.c: Fix common/ includes.
7302         * infrun.c: Fix common/ includes.
7303         * inflow.c: Fix common/ includes.
7304         * inferior.h: Fix common/ includes.
7305         * inferior.c: Fix common/ includes.
7306         * infcmd.c: Fix common/ includes.
7307         * inf-ptrace.c: Fix common/ includes.
7308         * inf-child.c: Fix common/ includes.
7309         * ia64-linux-nat.c: Fix common/ includes.
7310         * i387-tdep.c: Fix common/ includes.
7311         * i386-tdep.c: Fix common/ includes.
7312         * i386-linux-tdep.c: Fix common/ includes.
7313         * i386-linux-nat.c: Fix common/ includes.
7314         * i386-go32-tdep.c: Fix common/ includes.
7315         * i386-fbsd-tdep.c: Fix common/ includes.
7316         * i386-fbsd-nat.c: Fix common/ includes.
7317         * guile/scm-type.c: Fix common/ includes.
7318         * guile/guile.c: Fix common/ includes.
7319         * go32-nat.c: Fix common/ includes.
7320         * gnu-nat.c: Fix common/ includes.
7321         * gdbthread.h: Fix common/ includes.
7322         * gdbarch-selftests.c: Fix common/ includes.
7323         * gdb_usleep.c: Fix common/ includes.
7324         * gdb_select.h: Fix common/ includes.
7325         * gdb_bfd.c: Fix common/ includes.
7326         * gcore.c: Fix common/ includes.
7327         * fork-child.c: Fix common/ includes.
7328         * findvar.c: Fix common/ includes.
7329         * fbsd-nat.c: Fix common/ includes.
7330         * event-top.c: Fix common/ includes.
7331         * event-loop.c: Fix common/ includes.
7332         * dwarf2read.c: Fix common/ includes.
7333         * dwarf2loc.c: Fix common/ includes.
7334         * dwarf2-frame.c: Fix common/ includes.
7335         * dwarf-index-cache.c: Fix common/ includes.
7336         * dtrace-probe.c: Fix common/ includes.
7337         * disasm-selftests.c: Fix common/ includes.
7338         * defs.h: Fix common/ includes.
7339         * csky-tdep.c: Fix common/ includes.
7340         * cp-valprint.c: Fix common/ includes.
7341         * cp-support.h: Fix common/ includes.
7342         * cp-support.c: Fix common/ includes.
7343         * corelow.c: Fix common/ includes.
7344         * completer.h: Fix common/ includes.
7345         * completer.c: Fix common/ includes.
7346         * compile/compile.c: Fix common/ includes.
7347         * compile/compile-loc2c.c: Fix common/ includes.
7348         * compile/compile-cplus-types.c: Fix common/ includes.
7349         * compile/compile-cplus-symbols.c: Fix common/ includes.
7350         * command.h: Fix common/ includes.
7351         * cli/cli-dump.c: Fix common/ includes.
7352         * cli/cli-cmds.c: Fix common/ includes.
7353         * charset.c: Fix common/ includes.
7354         * build-id.c: Fix common/ includes.
7355         * btrace.h: Fix common/ includes.
7356         * btrace.c: Fix common/ includes.
7357         * breakpoint.h: Fix common/ includes.
7358         * breakpoint.c: Fix common/ includes.
7359         * ax.h:
7360         (enum agent_op): Fix common/ includes.
7361         * ax-general.c (struct aop_map): Fix common/ includes.
7362         * ax-gdb.c: Fix common/ includes.
7363         * auxv.c: Fix common/ includes.
7364         * auto-load.c: Fix common/ includes.
7365         * arm-tdep.c: Fix common/ includes.
7366         * arch/riscv.c: Fix common/ includes.
7367         * arch/ppc-linux-common.c: Fix common/ includes.
7368         * arch/i386.c: Fix common/ includes.
7369         * arch/arm.c: Fix common/ includes.
7370         * arch/arm-linux.c: Fix common/ includes.
7371         * arch/arm-get-next-pcs.c: Fix common/ includes.
7372         * arch/amd64.c: Fix common/ includes.
7373         * arch/aarch64.c: Fix common/ includes.
7374         * arch/aarch64-insn.c: Fix common/ includes.
7375         * arch-utils.c: Fix common/ includes.
7376         * amd64-windows-tdep.c: Fix common/ includes.
7377         * amd64-tdep.c: Fix common/ includes.
7378         * amd64-sol2-tdep.c: Fix common/ includes.
7379         * amd64-obsd-tdep.c: Fix common/ includes.
7380         * amd64-nbsd-tdep.c: Fix common/ includes.
7381         * amd64-linux-tdep.c: Fix common/ includes.
7382         * amd64-linux-nat.c: Fix common/ includes.
7383         * amd64-fbsd-tdep.c: Fix common/ includes.
7384         * amd64-fbsd-nat.c: Fix common/ includes.
7385         * amd64-dicos-tdep.c: Fix common/ includes.
7386         * amd64-darwin-tdep.c: Fix common/ includes.
7387         * agent.c: Fix common/ includes.
7388         * ada-lang.h: Fix common/ includes.
7389         * ada-lang.c: Fix common/ includes.
7390         * aarch64-tdep.c: Fix common/ includes.
7391
7392 2019-01-25  Tom Tromey  <tom@tromey.com>
7393
7394         * common/create-version.sh: Use common/version.h.
7395
7396 2019-01-24  Pedro Alves  <palves@redhat.com>
7397
7398         * infrun.c (signal_stop, signal_print, signal_program)
7399         (signal_catch, signal_pass): Now arrays instead of pointers.
7400         (update_signals_program_target, do_target_resume)
7401         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7402         * linux-nat.c (linux_nat_target::pass_signals)
7403         (linux_nat_target::create_inferior, linux_nat_target::attach):
7404         Adjust.
7405         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7406         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7407         * procfs.c (procfs_target::pass_signals): Adjust.
7408         * record-full.c (record_full_target::resume): Adjust.
7409         * remote.c (remote_target::pass_signals)
7410         (remote_target::program_signals): Adjust.
7411         * target-debug.h (target_debug_print_signals): Now takes a
7412         gdb::array_view as parameter.  Adjust.
7413         * target.h (target_ops) <pass_signals, program_signals>: Replace
7414         pointer and length parameters with gdb::array_view.
7415         (target_pass_signals, target_program_signals): Likewise.
7416         * target-delegates.c: Regenerate.
7417
7418 2019-01-24  Pedro Alves  <palves@redhat.com>
7419
7420         * common/forward-scope-exit.h
7421         (forward_scope_exit::forward_scope_exit): Pass arguments to
7422         m_bind_function directly, instead of creating a std::bind and
7423         copying that.
7424
7425 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7426
7427         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7428         for static members.
7429         (pass_in_v_vfp_candidate): Likewise.
7430
7431 2019-01-23  Tom Tromey  <tom@tromey.com>
7432             Pedro Alves  <palves@redhat.com>
7433
7434         * regcache.c (class regcache_invalidator): Remove.
7435         (regcache::raw_write): Use make_scope_exit.
7436
7437 2019-01-23  Tom Tromey  <tom@tromey.com>
7438
7439         * ui-out.h (class ui_out_emit_type): Update comment.
7440
7441 2019-01-23  Tom Tromey  <tom@tromey.com>
7442
7443         * infrun.c (fetch_inferior_event): Update comment.
7444
7445 2019-01-23  Tom Tromey  <tom@tromey.com>
7446             Pedro Alves  <palves@redhat.com>
7447
7448         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7449         parameter.
7450         (fetch_inferior_event): Use SCOPE_EXIT.
7451
7452
7453 2019-01-23  Tom Tromey  <tom@tromey.com>
7454             Pedro Alves  <palves@redhat.com>
7455
7456         * infrun.c (disable_thread_events): Delete.
7457         (stop_all_threads): Use SCOPE_EXIT.
7458
7459 2019-01-23  Tom Tromey  <tom@tromey.com>
7460             Pedro Alves  <palves@redhat.com>
7461
7462         * symfile.c: Include forward-scope-exit.h.
7463         (clear_symtab_users_cleanup): Replace forward declaration with
7464         a FORWARD_SCOPE_EXIT.
7465         (syms_from_objfile_1): Use the forward_scope_exit and
7466         gdb::optional instead of cleanup_function.
7467         (reread_symbols): Use the forward_scope_exit instead of
7468         cleanup_function.
7469         (clear_symtab_users_cleanup): Remove function.
7470
7471 2019-01-23  Tom Tromey  <tom@tromey.com>
7472             Pedro Alves  <palves@redhat.com>
7473
7474         * linux-nat.c: Include scope-exit.h.
7475         (cleanup_target_stop): Remove.
7476         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7477         SCOPE_EXIT.
7478
7479 2019-01-23  Tom Tromey  <tom@tromey.com>
7480             Pedro Alves  <palves@redhat.com>
7481
7482         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7483         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7484
7485 2019-01-23  Tom Tromey  <tom@tromey.com>
7486             Andrew Burgess  <andrew.burgess@embecosm.com>
7487             Pedro Alves  <palves@redhat.com>
7488
7489         * infrun.c (fetch_inferior_event): Use scope_exit.
7490         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7491         * top.c (execute_command): Use scope_exit.
7492         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7493         * utils.c (do_bpstat_clear_actions_cleanup)
7494         (make_bpstat_clear_actions_cleanup): Remove.
7495
7496 2019-01-23  Tom Tromey  <tom@tromey.com>
7497             Pedro Alves  <palves@redhat.com>
7498
7499         * infrun.c: Include "common/scope-exit.h"
7500         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7501         (wait_for_inferior): Use SCOPE_EXIT.
7502         (fetch_inferior_event): Use scope_exit.
7503
7504 2019-01-23  Tom Tromey  <tom@tromey.com>
7505             Pedro Alves  <palves@redhat.com>
7506
7507         * breakpoint.c (create_breakpoint): Remove cleanup.
7508
7509 2019-01-23  Tom Tromey  <tom@tromey.com>
7510             Andrew Burgess  <andrew.burgess@embecosm.com>
7511             Pedro Alves  <palves@redhat.com>
7512
7513 2019-01-23  Pedro Alves  <palves@redhat.com>
7514
7515         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7516
7517 2019-01-23  Pedro Alves  <palves@redhat.com>
7518             Andrew Burgess  <andrew.burgess@embecosm.com>
7519
7520         * gdbthread.h: Include "common/forward-scope-exit.h".
7521         (scoped_finish_thread_state): Redefine custom class in terms of
7522         forward_scope_exit.
7523
7524 2019-01-23  Pedro Alves  <palves@redhat.com>
7525             Andrew Burgess  <andrew.burgess@embecosm.com>
7526
7527         * common/forward-scope-exit.h: New file.
7528
7529 2019-01-23  Pedro Alves  <palves@redhat.com>
7530             Andrew Burgess  <andrew.burgess@embecosm.com>
7531             Tom Tromey  <tom@tromey.com>
7532
7533         * common/scope-exit.h: New file.
7534
7535 2019-01-23  Pedro Alves  <palves@redhat.com>
7536
7537         * common/preprocessor.h (ESC): Rename to ...
7538         (ESC_PARENS): ... this.
7539         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7540         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7541
7542 2019-01-23  Tom Tromey  <tom@tromey.com>
7543
7544         * language.h (class scoped_switch_to_sym_language_if_auto):
7545         Initialize m_lang in both cases.
7546
7547 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7548
7549         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7550         with XCNEW.
7551
7552 2019-01-22  Tom Tromey  <tom@tromey.com>
7553
7554         * corelow.c: Do not include sys/file.h.
7555
7556 2019-01-22  Tom Tromey  <tom@tromey.com>
7557
7558         * tui/tui-wingeneral.h: Include gdb_curses.h.
7559
7560 2019-01-22  Tom Tromey  <tom@tromey.com>
7561
7562         * source-cache.h (class source_cache) <get_source_lines,
7563         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7564
7565 2019-01-22  Tom Tromey  <tom@tromey.com>
7566
7567         * remote-fileio.h (struct remote_target): Declare.
7568
7569 2019-01-22  Tom Tromey  <tom@tromey.com>
7570
7571         * python/py-arch.c: Do not include py-ref.h.
7572         * python/py-bpevent.c: Do not include py-ref.h.
7573         * python/py-cmd.c: Do not include py-ref.h.
7574         * python/py-continueevent.c: Do not include py-ref.h.
7575         * python/py-event.h: Do not include py-ref.h.
7576         * python/py-evtregistry.c: Do not include py-ref.h.
7577         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7578         * python/py-frame.c: Do not include py-ref.h.
7579         * python/py-framefilter.c: Do not include py-ref.h.
7580         * python/py-function.c: Do not include py-ref.h.
7581         * python/py-infevents.c: Do not include py-ref.h.
7582         * python/py-linetable.c: Do not include py-ref.h.
7583         * python/py-objfile.c: Do not include py-ref.h.
7584         * python/py-param.c: Do not include py-ref.h.
7585         * python/py-prettyprint.c: Do not include py-ref.h.
7586         * python/py-progspace.c: Do not include py-ref.h.
7587         * python/py-symbol.c: Do not include py-ref.h.
7588         * python/py-symtab.c: Do not include py-ref.h.
7589         * python/py-type.c: Do not include py-ref.h.
7590         * python/py-unwind.c: Do not include py-ref.h.
7591         * python/py-utils.c: Do not include py-ref.h.
7592         * python/py-value.c: Do not include py-ref.h.
7593         * python/py-varobj.c: Do not include py-ref.h.
7594         * python/py-xmethods.c: Do not include py-ref.h.
7595         * python/python.c: Do not include py-ref.h.
7596         * varobj.c: Do not include py-ref.h.
7597
7598 2019-01-22  Tom Tromey  <tom@tromey.com>
7599
7600         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7601         keyword for bcache.
7602
7603 2019-01-22  Tom Tromey  <tom@tromey.com>
7604
7605         * compile/compile-cplus-types.c: Remove a comment by #include.
7606
7607 2019-01-22  Tom Tromey  <tom@tromey.com>
7608
7609         * compile/gcc-c-plugin.h: Include compile-internal.h.
7610
7611 2019-01-22  Tom Tromey  <tom@tromey.com>
7612
7613         * stabsread.c (EXTERN): Do not define.
7614         (symnum, next_symbol_text_func, processing_gcc_compilation)
7615         (within_function, global_sym_chain, global_stabs)
7616         (previous_stab_code, this_object_header_files)
7617         (n_this_object_header_files)
7618         (n_allocated_this_object_header_files): Define.
7619         * stabsread.h (EXTERN): Never define.  Use "extern".
7620
7621 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7622
7623         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7624         history_value.
7625
7626 2019-01-21  Tom Tromey  <tom@tromey.com>
7627
7628         * ui-out.c: Fix includes.
7629         * tui/tui-source.c: Fix includes.
7630         * target.c: Fix includes.
7631         * remote.c: Fix includes.
7632         * regcache.c: Fix includes.
7633         * python/py-block.c: Fix includes.
7634         * printcmd.c: Fix includes.
7635         * or1k-tdep.c: Fix includes.
7636         * mi/mi-main.c: Fix includes.
7637         * m32r-tdep.c: Fix includes.
7638         * csky-tdep.c: Fix includes.
7639         * compile/compile-cplus-types.c: Fix includes.
7640         * cli/cli-interp.c: Fix includes.
7641
7642 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7643
7644         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7645         for padding.
7646
7647 2019-01-16  Tom Tromey  <tom@tromey.com>
7648
7649         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7650         earlier.
7651         (struct objfile) <msymbols_range>: Move from top level.
7652         <msymbols>: New method.
7653         (class objfile_msymbols): Remove.
7654         * symtab.c (default_collect_symbol_completion_matches_break_on):
7655         Update.
7656         * symmisc.c (dump_msymbols): Update.
7657         * stabsread.c (scan_file_globals): Update.
7658         * objc-lang.c (info_selectors_command, info_classes_command)
7659         (find_methods): Update.
7660         * minsyms.c (find_solib_trampoline_target): Update.
7661         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7662         * coffread.c (coff_symfile_read): Update.
7663         * ada-lang.c (ada_lookup_simple_minsym)
7664         (ada_collect_symbol_completion_matches): Update.
7665
7666 2019-01-16  Tom Tromey  <tom@tromey.com>
7667
7668         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7669         type.  Remove no-argument constructor.
7670         <iterator::operator++>: Simplify.
7671         <begin>: Update.
7672         <end>: Use minimal_symbol_count.
7673
7674 2019-01-16  Tom Tromey  <tom@tromey.com>
7675
7676         * objfiles.h (struct objfile) <psymtabs>: New method.
7677         (class objfile_psymtabs): Remove.
7678         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7679         typedef.
7680         <range>: New method.
7681         (require_partial_symbols): Change return type.
7682         * psymtab.c (require_partial_symbols)
7683         (psym_expand_symtabs_matching): Update.
7684         * mdebugread.c (parse_partial_symbols): Update.
7685         * dbxread.c (dbx_end_psymtab): Update.
7686
7687 2019-01-15  Tom Tromey  <tom@tromey.com>
7688
7689         * symtab.c (lookup_objfile_from_block)
7690         (lookup_symbol_in_objfile_symtabs)
7691         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7692         (find_line_symtab, info_sources_command)
7693         (default_collect_symbol_completion_matches_break_on)
7694         (make_source_files_completion_list): Update.
7695         * symmisc.c (print_objfile_statistics, dump_objfile)
7696         (maintenance_print_symbols, maintenance_info_symtabs)
7697         (maintenance_check_symtabs, maintenance_info_line_tables):
7698         Update.
7699         * source.c (select_source_symtab)
7700         (forget_cached_source_info_for_objfile): Update.
7701         * objfiles.h (class objfile_compunits): Remove.
7702         (struct objfile) <compunits_range>: New typedef.
7703         (compunits): New method.
7704         * objfiles.c (objfile_relocate1): Update.
7705         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7706         * maint.c (count_symtabs_and_blocks): Update.
7707         * linespec.c (iterate_over_all_matching_symtabs): Update.
7708         * cp-support.c (add_symbol_overload_list_qualified): Update.
7709         * coffread.c (coff_symtab_read): Update.
7710         * ada-lang.c (add_nonlocal_symbols)
7711         (ada_collect_symbol_completion_matches)
7712         (ada_add_global_exceptions): Update.
7713
7714 2019-01-15  Tom Tromey  <tom@tromey.com>
7715
7716         * progspace.h (program_space) <objfiles_safe_range>: New
7717         typedef.
7718         <objfiles_safe>: New method.
7719         * objfiles.h (class all_objfiles_safe): Remove.
7720         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7721         * jit.c (jit_inferior_exit_hook): Update.
7722
7723 2019-01-17  Tom Tromey  <tom@tromey.com>
7724
7725         * progspace.h (program_space) <objfiles_range>: New typedef.
7726         <objfiles>: New method.
7727         <objfiles_head>: Rename from objfiles.
7728         (object_files): Update.
7729         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7730         * guile/scm-pretty-print.c
7731         (ppscm_find_pretty_printer_from_objfiles): Update.
7732         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7733         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7734         Update.
7735         * python/py-progspace.c (pspy_get_objfiles): Update.
7736         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7737         Update.
7738         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7739         (objfpy_lookup_objfile_by_build_id): Update.
7740         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7741         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7742         Update.
7743         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7744         (expand_symtab_containing_pc, lookup_objfile_from_block)
7745         (lookup_static_symbol, basic_lookup_transparent_type)
7746         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7747         (find_line_symtab, info_sources_command)
7748         (default_collect_symbol_completion_matches_break_on)
7749         (make_source_files_completion_list, find_main_name): Update.
7750         * symmisc.c (print_symbol_bcache_statistics)
7751         (print_objfile_statistics, maintenance_print_symbols)
7752         (maintenance_print_msymbols, maintenance_print_objfiles)
7753         (maintenance_info_symtabs, maintenance_check_symtabs)
7754         (maintenance_expand_symtabs, maintenance_info_line_tables):
7755         Update.
7756         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7757         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7758         (map_overlay_command, unmap_overlay_command)
7759         (simple_overlay_update, expand_symtabs_matching)
7760         (map_symbol_filenames): Update.
7761         * symfile-debug.c (set_debug_symfile): Update.
7762         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7763         Update.
7764         * source.c (select_source_symtab, forget_cached_source_info):
7765         Update.
7766         * solib.c (solib_read_symbols): Update.
7767         * solib-spu.c (append_ocl_sos): Update.
7768         * psymtab.c (maintenance_print_psymbols)
7769         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7770         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7771         * printcmd.c (info_symbol_command): Update.
7772         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7773         Update.
7774         * objfiles.h (class all_objfiles): Remove.
7775         * objfiles.c (have_partial_symbols, have_full_symbols)
7776         (have_minimal_symbols, qsort_cmp, update_section_map)
7777         (shared_objfile_contains_address_p)
7778         (default_iterate_over_objfiles_in_search_order): Update.
7779         * objc-lang.c (info_selectors_command, info_classes_command)
7780         (find_methods): Update.
7781         * minsyms.c (find_solib_trampoline_target): Update.
7782         * maint.c (maintenance_info_sections)
7783         (maintenance_translate_address, count_symtabs_and_blocks):
7784         Update.
7785         * main.c (captured_main_1): Update.
7786         * linux-thread-db.c (try_thread_db_load_from_pdir)
7787         (has_libpthread): Update.
7788         * linespec.c (iterate_over_all_matching_symtabs)
7789         (search_minsyms_for_name): Update.
7790         * jit.c (jit_find_objf_with_entry_addr): Update.
7791         * hppa-tdep.c (find_unwind_entry)
7792         (hppa_lookup_stub_minimal_symbol): Update.
7793         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7794         Update.
7795         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7796         (elf_gnu_ifunc_resolve_by_got): Update.
7797         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7798         * dwarf-index-write.c (save_gdb_index_command): Update.
7799         * cp-support.c (add_symbol_overload_list_qualified): Update.
7800         * breakpoint.c (create_overlay_event_breakpoint)
7801         (create_longjmp_master_breakpoint)
7802         (create_std_terminate_master_breakpoint)
7803         (create_exception_master_breakpoint): Update.
7804         * blockframe.c (find_pc_partial_function): Update.
7805         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7806         (ada_collect_symbol_completion_matches)
7807         (ada_add_global_exceptions): Update.
7808
7809 2019-01-17  Tom Tromey  <tom@tromey.com>
7810
7811         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7812         declare VEC.
7813         (solib_target_parse_libraries): Change return type.
7814         (library_list_start_segment, library_list_start_section)
7815         (library_list_end_library, library_list_start_library); Update.
7816         (solib_target_free_library_list): Remove.
7817         (solib_target_parse_libraries): Remove cleanup.  Change return
7818         type.
7819         (solib_target_current_sos): Update.
7820
7821 2019-01-17  Tom Tromey  <tromey@bapiya>
7822
7823         * valprint.c: Replace "the the" with "the".
7824         * symtab.c: Replace "the the" with "the".
7825         * solib.c: Replace "the the" with "the".
7826         * solib-dsbt.c: Replace "the the" with "the".
7827         * linespec.c: Replace "the the" with "the".
7828         * dwarf2loc.h: Replace "the the" with "the".
7829         * amd64-windows-tdep.c: Replace "the the" with "the".
7830         * aarch64-tdep.c: Replace "the the" with "the".
7831
7832 2019-01-16  Keith Seitz  <keiths@redhat.com>
7833
7834         PR gdb/23773
7835         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7836         <builder>: Rename to ..
7837         <m_builder>: ... this and make private.
7838         (dwarf2_cu::get_builder): New method.  Change all users of
7839         `builder' to use this method.
7840         (dwarf2_start_symtab): Move to ...
7841         (dwarf2_cu::start_symtab): ... here.  Update all callers
7842         (setup_type_unit_groups): Move to ...
7843         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7844         callers.
7845         (dwarf2_cu::reset_builder): New method.
7846         (process_full_compunit, process_full_type_unit): Use
7847         dwarf2_cu::reset_builder.
7848         (follow_die_offset): Record the ancestor CU if it is different
7849         from the followed DIE's CU.
7850         (follow_die_sig_1): Likewise.
7851
7852 2019-01-15  Tom Tromey  <tom@tromey.com>
7853
7854         * remote.c (class remote_state) <buf>: Now a char_vector.
7855         <buf_size>: Remove.
7856         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7857         parameter.
7858         (remote_target::getpkt_or_notif_sane_1)
7859         (remote_target::getpkt_sane)
7860         (remote_target::getpkt_or_notif_sane): Likewise.
7861         (class remote_target) <putpkt>: New overload.
7862         (remote_target::read_frame): Change type of "buf_p".  Remove
7863         sizeof_p parameter.
7864         (packet_ok): New overload.
7865         (packet_check_result): New overload.
7866         Update all uses.
7867
7868 2019-01-14  Tom Tromey  <tom@tromey.com>
7869
7870         * remote-notif.c (handle_notification, remote_notif_ack)
7871         (remote_notif_parse): Make "buf" const.
7872         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7873         const.
7874         (remote_notif_parse, remote_notif_ack, handle_notification):
7875         Likewise.
7876         * remote.c (remote_notif_stop_parse): Make "buf" const.
7877         (remote_target::remote_parse_stop_reply): Make "buf" const.
7878         (remote_notif_stop_ack): Make "buf" const.
7879
7880 2019-01-14  Tom Tromey  <tom@tromey.com>
7881
7882         * remote.c (remote_console_output): Make parameter const.
7883
7884 2019-01-14  Tom Tromey  <tom@tromey.com>
7885
7886         * target-debug.h (target_debug_print_signals): Constify.
7887         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7888         * procfs.c (procfs_target::pass_signals): Update.
7889         * linux-nat.c (linux_nat_target::pass_signals): Update.
7890         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7891         * target-delegates.c: Rebuild.
7892         * remote.c (remote_target::program_signals): Update.
7893         (remote_target::pass_signals): Update.
7894         * target.c (target_pass_signals): Constify argument.
7895         (target_program_signals): Likewise.
7896         * target.h (struct target_ops) <pass_signals, program_signals>:
7897         Constify argument.
7898         (target_pass_signals, target_program_signals): Constify argument.
7899
7900 2019-01-14  Tom Tromey  <tom@tromey.com>
7901
7902         PR tui/28819:
7903         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7904
7905 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7906
7907         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7908         field.
7909         * rs6000-tdep.c: Include reggroups.h.
7910         (IS_V_ALIAS_PSEUDOREG): Define.
7911         (rs6000_register_name): Return names for the "vX" aliases.
7912         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7913         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7914         aliases.  Call default_register_reggroup_p for all other
7915         pseudo-registers.
7916         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7917         New functions.
7918         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7919         Handle "vX" aliases.
7920         (v_alias_pseudo_register_collect): New function.
7921         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7922         (rs6000_gdbarch_init): Initialize "vX" aliases as
7923         pseudo-registers.  Restore registration of
7924         rs6000_pseudo_register_reggroup_p with
7925         set_tdesc_pseudo_register_reggroup_p.
7926
7927 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7928
7929         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7930         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7931         set_gdbarch_num_pseudo_regs.
7932
7933 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7934
7935         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7936         Remove arg prefixname, add do_set and do_show.
7937         Add member functions set_list and show_list.
7938         * cli/cli-style.c (class cli_style_option): Update accordingly.
7939         (style_set_list): Move to file scope.
7940         (style_show_list): Likewise.
7941         (set_style): Call help_list.
7942         (show_style): Call cmd_show_list.
7943         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7944         Update to use the new macro.
7945
7946 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7947
7948         * ada-lang.c (_initialize_ada_language): Expand the help text
7949         for the "catch exception" command.
7950
7951 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7952
7953         * symtab.c (matching_obj_sections): Initialize obj,
7954         declare it closer to its usage.
7955
7956 2019-01-10  Tom Tromey  <tom@tromey.com>
7957
7958         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7959         (basic_inf_threads_range): Remove.
7960         (inf_threads_range, inf_non_exited_threads_range)
7961         (safe_inf_threads_range): Use next_adapter.
7962
7963 2019-01-10  Keith Seitz  <keiths@redhat.com>
7964
7965         PR gdb/23712
7966         PR symtab/23010
7967         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7968         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7969
7970 2019-01-10  Keith Seitz  <keiths@redhat.com>
7971
7972         PR gdb/23712
7973         PR symtab/23010
7974         * dictionary.c (pending_to_vector): Remove.
7975         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7976         Remove _1 suffix, replacing functions of the same name.  Update
7977         all callers.
7978         (dict_create_hashed, dict_create_hashed_expandable)
7979         (dict_create_linear, dict_create_linear_expandable, dict_free)
7980         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7981         Make functions static.
7982
7983 2019-01-10  Keith Seitz  <keiths@redhat.com>
7984
7985         PR gdb/23712
7986         PR symtab/23010
7987         * dictionary.h (struct dictionary): Replace declaration with
7988         multidictionary.
7989         (dict_create_hashed, dict_create_hashed_expandable)
7990         (dict_create_linear, dict_create_linear_expandable)
7991         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7992         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7993         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7994         taking multidictionary argument.
7995         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7996         * block.h (struct block) <dict>: Change to multidictionary
7997         and rename `multidict'.
7998         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7999         symmisc.c: Update all dictionary references to multidictionary.
8000
8001 2019-01-10  Keith Seitz  <keiths@redhat.com>
8002
8003         PR gdb/23712
8004         PR symtab/23010
8005         * dictionary.c: Include unordered_map.
8006         (pending_to_vector): New function.
8007         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8008         Rewrite the non-"_1" functions to take vector instead
8009         of linked list.
8010         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8011         "new" _1 versions of the same name.
8012         (multidictionary): Define.
8013         (std::hash<enum language): New definition.
8014         (collate_pending_symbols_by_language, mdict_create_hashed)
8015         (mdict_create_hashed_expandable, mdict_create_linear)
8016         (mdict_create_linear_expandable, mdict_free)
8017         (find_language_dictionary, create_new_language_dictionary)
8018         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8019         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8020         (mdict_size, mdict_empty): New functions.
8021         * dictionary.h (mdict_iterator): Define.
8022
8023 2019-01-10  Pedro Alves  <palves@redhat.com>
8024
8025         * breakpoint.c (read_uploaded_action)
8026         (create_tracepoint_from_upload): Adjust to use
8027         gdb::unique_xmalloc_ptr.
8028         * ctf.c (ctf_write_uploaded_tp):
8029         (SET_ARRAY_FIELD): Use emplace_back.
8030         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8031         * tracefile-tfile.c (tfile_write_uploaded_tp):
8032         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8033         gdb::unique_xmalloc_ptr.
8034         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8035         at_string, cond_string, cmd_strings>: Replace char pointers
8036         with gdb::unique_xmalloc_ptr.
8037
8038 2019-01-10  Pedro Alves  <palves@redhat.com>
8039
8040         * solib-target.c (library_list_start_library): Don't xstrdup name.
8041
8042 2019-01-10  Pedro Alves  <palves@redhat.com>
8043
8044         * mdebugread.c (parse_partial_symbols): Use
8045         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8046
8047 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8048
8049         * linux-fork.c (scoped_switch_fork_info)
8050         <~scoped_switch_fork_info>: Fix incorrect variable name.
8051
8052 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8053
8054         * linux-fork.c (scoped_switch_fork_info)
8055         <scoped_switch_fork_info>: Make explicit.
8056         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8057
8058 2019-01-10  Tom Tromey  <tom@tromey.com>
8059
8060         * objfiles.h (objfile::reset_psymtabs): Update.
8061         * objfiles.c (objfile::objfile): Update.
8062         * psymtab.h (psymtab_storage::obstack): Update.
8063         (psymtab_storage::m_obstack): Use gdb::optional.
8064         (class psymtab_storage): Update comment.  Remove objfile
8065         parameter.
8066         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8067
8068 2019-01-10  Tom Tromey  <tom@tromey.com>
8069
8070         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8071         <free_psymtabs>: Now private.
8072         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8073         (allocate_psymtab): Use new method.
8074
8075 2019-01-10  Tom Tromey  <tom@tromey.com>
8076
8077         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8078         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8079         * mdebugread.c (parse_partial_symbols): Use
8080         allocate_dependencies.
8081         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8082         allocate_dependencies.
8083         (process_psymtab_comp_unit_reader)
8084         (build_type_psymtab_dependencies): Likewise.
8085         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8086
8087 2019-01-10  Tom Tromey  <tom@tromey.com>
8088
8089         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8090         PSYMBOL_SET_LANGUAGE.
8091         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8092
8093 2019-01-10  Tom Tromey  <tom@tromey.com>
8094
8095         * psymtab.h (psymtab_storage::obstack): New method.
8096         <m_obstack>: Rename from obstack; now private.
8097         * psymtab.c (psymtab_storage): Update.
8098         * dwarf2read.c (create_addrmap_from_index)
8099         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8100         Update.
8101
8102 2019-01-10  Tom Tromey  <tom@tromey.com>
8103
8104         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8105         * objfiles.h (objfile::reset_psymtabs): New method.
8106
8107 2019-01-10  Tom Tromey  <tom@tromey.com>
8108
8109         * symmisc.c (print_symbol_bcache_statistics): Update.
8110         (print_objfile_statistics): Update.
8111         * symfile.c (reread_symbols): Update.
8112         * psymtab.h (class psymtab_storage): New.
8113         * psymtab.c (psymtab_storage): New constructor.
8114         (~psymtab_storage): New destructor.
8115         (require_partial_symbols): Update.
8116         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8117         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8118         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8119         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8120         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8121         (start_psymtab_common, end_psymtab_common)
8122         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8123         (allocate_psymtab): Update.
8124         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8125         Update.
8126         (dump_psymtab_addrmap, maintenance_print_psymbols)
8127         (maintenance_check_psymtabs): Update.
8128         (class objfile_psymtabs): Move to objfiles.h.
8129         * psympriv.h (discard_psymtab): Now inline.
8130         (psymtab_discarder::psymtab_discarder): Update.
8131         (psymtab_discarder::~psymtab_discarder): Update.
8132         (ALL_OBJFILE_PSYMTABS): Rewrite.
8133         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8134         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8135         Remove fields.
8136         <partial_symtabs>: New field.
8137         (class objfile_psymtabs): Move from psymtab.h.  Update.
8138         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8139         psymbol_cache.
8140         (objfile::~objfile): Don't destroy psymbol_cache.
8141         * mdebugread.c (parse_partial_symbols): Update.
8142         * dwarf2read.c (create_addrmap_from_index)
8143         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8144         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8145         (add_partial_subprogram, dwarf2_ranges_read): Update.
8146         * dwarf-index-write.c (write_address_map)
8147         (write_one_signatured_type, recursively_write_psymbols)
8148         (class debug_names, class debug_names, write_psymtabs_to_index):
8149         Update.
8150
8151 2019-01-10  Tom Tromey  <tom@tromey.com>
8152
8153         * symtab.h (SYMBOL_SET_NAMES): Update.
8154         (symbol_set_names): Update.
8155         (MSYMBOL_SET_NAMES): Update.
8156         * symtab.c (symbol_set_names): Change argument to be an
8157         objfile_per_bfd_storage.
8158         * psymtab.c (add_psymbol_to_bcache): Update.
8159         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8160
8161 2019-01-10  Tom Tromey  <tom@tromey.com>
8162
8163         * symtab.c (create_demangled_names_hash): Change argument to be an
8164         objfile_per_bfd_storage.
8165         (symbol_set_names): Update.
8166
8167 2019-01-10  Tom Tromey  <tom@tromey.com>
8168
8169         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8170         init_psymbol_list.
8171         * psymtab.c (init_psymbol_list): Do nothing if already called.
8172         * psympriv.h (init_psymbol_list): Add comment.
8173         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8174         init_psymbol_list.
8175         * dbxread.c (dbx_symfile_read): Unconditionally call
8176         init_psymbol_list.
8177
8178 2019-01-10  Tom Tromey  <tom@tromey.com>
8179
8180         * xcoffread.c (scan_xcoff_symtab): Update.
8181         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8182         "where".
8183         * mdebugread.c (parse_partial_symbols)
8184         (handle_psymbol_enumerators): Update.
8185         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8186         * dbxread.c (read_dbx_symtab): Update.
8187         * psympriv.h (psymbol_placement): New enum.
8188         (add_psymbol_to_list): Update.
8189
8190 2019-01-10  Tom Tromey  <tom@tromey.com>
8191
8192         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8193         static_psymbols parameters.
8194         (scan_xcoff_symtab): Update.
8195         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8196         static_psymbols parameters.
8197         * psympriv.h (start_psymtab_common): Update.
8198         * mdebugread.c (parse_partial_symbols): Update.
8199         * dwarf2read.c (create_partial_symtab): Update.
8200         * dbxread.c (read_dbx_symtab): Update.
8201         (start_psymtab): Remove global_psymbols and static_psymbols
8202         parameters.
8203
8204 2019-01-10  Tom Tromey  <tom@tromey.com>
8205
8206         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8207         * psymtab.c (allocate_psymtab): Add comment.
8208         * psympriv.h (allocate_psymtab): Add comment.
8209         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8210         initializations.
8211         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8212
8213 2019-01-10  Tom Tromey  <tom@tromey.com>
8214
8215         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8216         Don't declare.
8217         * mipsread.c: Include mdebugread.h.
8218         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8219         Declare.
8220         * elfread.c: Include mdebugread.h.
8221
8222 2019-01-09  Tom Tromey  <tom@tromey.com>
8223
8224         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8225         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8226         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8227         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8228         (psym_lookup_symbol, psym_find_last_source_symtab)
8229         (psym_forget_cached_source_info, psym_print_stats)
8230         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8231         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8232         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8233         (psym_find_compunit_symtab_by_address)
8234         (maintenance_print_psymbols, maintenance_info_psymtabs)
8235         (maintenance_check_psymtabs): Use ranged for.
8236         * psymtab.h (class objfile_psymtabs): New.
8237         (require_partial_symbols): Return objfile_psymtabs.
8238         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8239
8240 2019-01-09  Tom Tromey  <tom@tromey.com>
8241
8242         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8243         (find_pc_mapped_section, list_overlays_command)
8244         (map_overlay_command, unmap_overlay_command)
8245         (simple_overlay_update): Use all_objfiles.
8246         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8247         * printcmd.c (info_symbol_command): Use all_objfiles.
8248         * objfiles.h (ALL_OBJSECTIONS): Remove.
8249         * maint.c (maintenance_translate_address): Use all_objfiles.
8250         * gcore.c (gcore_create_callback): Use all_objfiles.
8251         (objfile_find_memory_regions): Likewise.
8252
8253 2019-01-09  Tom Tromey  <tom@tromey.com>
8254
8255         * symtab.c (find_line_symtab, info_sources_command)
8256         (make_source_files_completion_list): Use objfile_compunits.
8257         * source.c (select_source_symtab): Use objfile_compunits.
8258         * objfiles.h (struct objfile): Update comment.
8259         (ALL_OBJFILES): Remove.
8260         (ALL_FILETABS): Remove.
8261         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8262         objfile_compunits.
8263
8264 2019-01-09  Tom Tromey  <tom@tromey.com>
8265
8266         * symmisc.c (print_objfile_statistics, dump_objfile)
8267         (maintenance_print_symbols): Use compunit_filetabs.
8268         * source.c (forget_cached_source_info_for_objfile): Use
8269         compunit_filetabs.
8270         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8271         (ALL_FILETABS): Use compunit_filetabs.
8272         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8273         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8274
8275 2019-01-09  Tom Tromey  <tom@tromey.com>
8276
8277         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8278         (compunit_filetabs): New.
8279         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8280         compunit_filetabs.
8281         (info_sources_command, make_source_files_completion_list): Remove
8282         declaration.
8283         * symmisc.c (print_objfile_statistics, dump_objfile)
8284         (maintenance_print_symbols): Remove declaration.
8285         (maintenance_info_symtabs): Use compunit_filetabs.
8286         (maintenance_info_line_tables): Likewise.
8287         * source.c (select_source_symtab): Change local variable name.
8288         (forget_cached_source_info_for_objfile): Remove declaration.
8289         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8290         * objfiles.c (objfile_relocate1): Remove declaration.
8291         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8292         declaration.
8293         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8294         * coffread.c (coff_symtab_read): Remove declaration.
8295         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8296         compunit_filetabs.
8297
8298 2019-01-09  Tom Tromey  <tom@tromey.com>
8299
8300         * symtab.c (lookup_objfile_from_block)
8301         (find_pc_sect_compunit_symtab, search_symbols)
8302         (default_collect_symbol_completion_matches_break_on): Use
8303         objfile_compunits.
8304         * objfiles.h (ALL_COMPUNITS): Remove.
8305         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8306         * cp-support.c (add_symbol_overload_list_qualified): Use
8307         objfile_compunits.
8308         * ada-lang.c (ada_collect_symbol_completion_matches)
8309         (ada_add_global_exceptions): Use objfile_compunits.
8310
8311 2019-01-09  Tom Tromey  <tom@tromey.com>
8312
8313         * source.c (select_source_symtab)
8314         (forget_cached_source_info_for_objfile): Remove declaration.
8315         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8316         declaration.
8317         * maint.c (count_symtabs_and_blocks): Remove declaration.
8318         * cp-support.c (add_symbol_overload_list_qualified): Remove
8319         declaration.
8320         * coffread.c (coff_symtab_read): Remove declaration.
8321         * symtab.c (lookup_symbol_in_objfile_symtabs)
8322         (basic_lookup_transparent_type_1): Use objfile_compunits.
8323         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8324         (info_sources_command, search_symbols)
8325         (default_collect_symbol_completion_matches_break_on)
8326         (make_source_files_completion_list): Remove declaration.
8327         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8328         (ada_collect_symbol_completion_matches)
8329         (ada_add_global_exceptions): Remove declaration.
8330         * linespec.c (iterate_over_all_matching_symtabs): Use
8331         objfile_compunits.
8332         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8333         (class objfile_compunits): New.
8334         (ALL_COMPUNITS): Use objfile_compunits.
8335         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8336         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8337         objfile_compunits.
8338         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8339
8340 2019-01-09  Tom Tromey  <tom@tromey.com>
8341
8342         * symtab.c (search_symbols)
8343         (default_collect_symbol_completion_matches_break_on): Use
8344         objfile_msymbols.
8345         * ada-lang.c (ada_lookup_simple_minsym)
8346         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8347         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8348         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8349         objfile_msymbols.
8350         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8351         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8352         * objc-lang.c (find_methods): Use objfile_msymbols.
8353         (info_selectors_command, info_classes_command): Likewise.
8354         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8355         * objfiles.h (class objfile_msymbols): New.
8356         (ALL_OBJFILE_MSYMBOLS): Remove.
8357         (ALL_MSYMBOLS): Remove.
8358
8359 2019-01-09  Tom Tromey  <tom@tromey.com>
8360
8361         * common/next-iterator.h (next_adapter): Add Iterator template
8362         parameter.
8363         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8364         (class all_objfiles_safe): New.
8365         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8366         * objfiles.c (put_objfile_before): Update comment.
8367         (add_separate_debug_objfile): Likewise.
8368         (free_all_objfiles): Use all_objfiles_safe.
8369         (objfile_purge_solibs): Likewise.
8370
8371 2019-01-09  Tom Tromey  <tom@tromey.com>
8372
8373         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8374         (expand_symtab_containing_pc, lookup_static_symbol)
8375         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8376         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8377         all_objfiles.
8378         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8379         * breakpoint.c (create_overlay_event_breakpoint)
8380         (create_longjmp_master_breakpoint)
8381         (create_std_terminate_master_breakpoint)
8382         (create_exception_master_breakpoint): Use all_objfiles.
8383         * linux-thread-db.c (try_thread_db_load_from_pdir)
8384         (has_libpthread): Use all_objfiles.
8385         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8386         * linespec.c (iterate_over_all_matching_symtabs)
8387         (search_minsyms_for_name): Use all_objfiles.
8388         * maint.c (maintenance_info_sections): Use all_objfiles.
8389         * main.c (captured_main_1): Use all_objfiles.
8390         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8391         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8392         * guile/scm-pretty-print.c
8393         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8394         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8395         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8396         (maintenance_print_msymbols): Use all_objfiles.
8397         * source.c (select_source_symtab): Use all_objfiles.
8398         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8399         * symfile.c (remove_symbol_file_command)
8400         (expand_symtabs_matching, map_symbol_filenames): Use
8401         all_objfiles.
8402         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8403         all_objfiles.
8404         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8405         * objc-lang.c (find_methods): Use all_objfiles.
8406         * objfiles.c (have_partial_symbols, have_full_symbols)
8407         (have_minimal_symbols, qsort_cmp)
8408         (default_iterate_over_objfiles_in_search_order): Use
8409         all_objfiles.
8410         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8411         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8412         (maintenance_check_psymtabs): Use all_objfiles.
8413         (ALL_PSYMTABS): Remove.
8414         * compile/compile-object-run.c (do_module_cleanup): Use
8415         all_objfiles.
8416         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8417         * cp-support.c (add_symbol_overload_list_qualified): Use
8418         all_objfiles.
8419         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8420         Use all_objfiles.
8421         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8422         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8423         all_objfiles.
8424         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8425         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8426         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8427         Uses all_objfiles.
8428         * solib.c (solib_read_symbols): Use all_objfiles
8429
8430 2019-01-09  Tom Tromey  <tom@tromey.com>
8431
8432         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8433         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8434         all_objfiles.
8435         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8436         * symmisc.c (print_symbol_bcache_statistics)
8437         (print_objfile_statistics, maintenance_print_objfiles)
8438         (maintenance_info_symtabs, maintenance_check_symtabs)
8439         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8440         all_objfiles.
8441         * source.c (forget_cached_source_info): Use all_objfiles.
8442         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8443         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8444         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8445         * objfiles.c (update_section_map): Use all_objfiles.
8446         (shared_objfile_contains_address_p): Likewise.
8447         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8448         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8449
8450 2019-01-09  Tom Tromey  <tom@tromey.com>
8451
8452         * common/next-iterator.h: New file.
8453         * objfiles.h (class all_objfiles): New.
8454         (struct objfile_iterator): New.
8455
8456 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8457
8458         * NEWS: Move the description of the changed "frame", "select-frame",
8459          and "info frame" commands to the Changed commands section.
8460
8461 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8462
8463         * gdbtypes.c (check_stub_method_group): Remove handling of old
8464         mangling schemes.
8465         * linespec.c (find_methods): Likewise.
8466         * stabsread.c (read_member_functions): Likewise.
8467         * valops.c (search_struct_method): Likewise.
8468         (value_struct_elt_for_reference): Likewise.
8469         * NEWS: Mention this change.
8470
8471 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8472
8473         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8474         print_source_lines.
8475         * source.c (print_source_lines_base): Update line number check.
8476         (print_source_lines): New function.
8477         (source_lines_range::source_lines_range): New function.
8478         * source.h (class source_lines_range): New class.
8479         (print_source_lines): New declaration.
8480
8481 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8482
8483         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8484
8485 2019-01-08  Tom Tromey  <tom@tromey.com>
8486             Simon Marchi  <simon.marchi@ericsson.com>
8487
8488         PR gdb/24060
8489         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8490         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8491         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8492         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8493         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8494         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8495
8496 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8497
8498         * source.c (select_source_symtab): Move header comment to
8499         declaration in source.h.
8500         (forget_cached_source_info_for_objfile): Likewise.
8501         (forget_cached_source_info): Likewise.
8502         (identify_source_line): Likewise.
8503         * source.h (identify_source_line): Move declaration from symtab.h
8504         and add comment from source.c
8505         (print_source_lines): Likewise.
8506         (forget_cached_source_info_for_objfile): Likewise.
8507         (forget_cached_source_info): Likewise.
8508         (select_source_symtab): Likewise.
8509         (enum print_source_lines_flag): Move definition from symtab.h.
8510         * symtab.h (identify_source_line): Move declaration to source.h.
8511         (print_source_lines): Likewise.
8512         (forget_cached_source_info_for_objfile): Likewise.
8513         (forget_cached_source_info): Likewise.
8514         (select_source_symtab): Likewise.
8515         (enum print_source_lines_flag): Move definition to source.h.
8516         * tui/tui-hooks.c: Add 'source.h' include.
8517
8518 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8519
8520         * source.c (print_source_lines_base): Handle requests to print
8521         reverse line number sequences, and guard against empty lines
8522         string.
8523
8524 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8525
8526         * source.c (print_source_lines_base): Fix skip of '\r' if next
8527         character is '\n'.
8528
8529 2019-01-06  Tom Tromey  <tom@tromey.com>
8530
8531         * c-exp.y (struct c_parse_state) <macro_original_text,
8532         expansion_obstack>: New member.
8533         (macro_original_text, expansion_obstack): Remove globals.
8534         (scan_macro_expansion, scanning_macro_expansion)
8535         (finished_macro_expansion): Update.
8536         (scan_macro_cleanup): Remove.
8537         (yylex, c_parse): Update.
8538
8539 2019-01-06  Tom Tromey  <tom@tromey.com>
8540
8541         * c-exp.y (struct c_parse_state) <strings>: New member.
8542         (operator_stoken): Update.
8543
8544 2019-01-06  Tom Tromey  <tom@tromey.com>
8545
8546         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8547         (union type_stack_elt) <typelist_val>: Now a pointer to
8548         std::vector.
8549         (type_stack_cleanup): Don't declare.
8550         (push_typelist): Update.
8551         * parse.c (pop_typelist): Return a std::vector.
8552         (push_typelist): Take a std::vector.
8553         (follow_types): Update.  Do not free args.
8554         (type_stack_cleanup): Remove.
8555         * c-exp.y (struct c_parse_state): New.
8556         (cpstate): New global.
8557         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8558         (nonempty_typelist): Update.
8559         (func_mod): Create a new vector.
8560         (c_parse): Create a c_parse_state.
8561         (check_parameter_typelist): Do not delete params.
8562         (function_method): Update.  Do not delete type_list.
8563
8564 2019-01-06  Tom Tromey  <tom@tromey.com>
8565
8566         PR gdb/28155:
8567         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8568         check_typedef.
8569         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8570         (print_return_value): Likewise.
8571
8572 2019-01-05  Tom Tromey  <tom@tromey.com>
8573
8574         * contrib/cleanup_check.py: Remove.
8575         * contrib/gcc-with-excheck: Remove.
8576         * contrib/exsummary.py: Remove.
8577         * contrib/excheck.py: Remove.
8578
8579 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8580
8581         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8582         NULL. Initialize tpprev to NULL instead of assigning it
8583         to NULL on the next statement.
8584         * windows-nat.c (windows_delete_thread): Remove check for
8585         main_thread_id before printing thread exit notifications.
8586         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8587         Remove thread ID check against main_thread_id.
8588         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8589         windows_delete_thread.
8590         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8591
8592 2019-01-04  Tom Tromey  <tom@tromey.com>
8593
8594         * compile/compile.c (_initialize_compile): Use upper case for
8595         metasyntactic variables.
8596         * symmisc.c (_initialize_symmisc): Use upper case for
8597         metasyntactic variables.
8598         * psymtab.c (_initialize_psymtab): Use upper case for
8599         metasyntactic variables.
8600         * demangle.c (demangle_command): Use upper case for metasyntactic
8601         variables.
8602         (_initialize_demangler): Likewise.
8603         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8604         variables.
8605
8606 2019-01-03  Tom Tromey  <tom@tromey.com>
8607
8608         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8609
8610 2019-01-03  Tom Tromey  <tom@tromey.com>
8611
8612         * python/py-symtab.c (salpy_str): Update.
8613         (struct salpy_sal_object) <symtab>: Now a PyObject.
8614         (salpy_dealloc): Update.
8615         (del_objfile_sal): Use gdbpy_ref.
8616
8617 2019-01-03  Tom Tromey  <tom@tromey.com>
8618
8619         * python/py-type.c (convert_field): Use new_reference.  Return
8620         gdbpy_ref.
8621         (make_fielditem): Return gdbpy_ref.
8622         (typy_fields): Update.
8623         (typy_getitem): Update.
8624         (field_name): Return gdbpy_ref.  Use new_reference.
8625         (typy_iterator_iternext): Update.
8626
8627 2019-01-03  Tom Tromey  <tom@tromey.com>
8628
8629         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8630
8631 2019-01-03  Tom Tromey  <tom@tromey.com>
8632
8633         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8634         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8635         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8636         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8637         (pspy_set_type_printers): Likewise.
8638         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8639         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8640         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8641         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8642         (objfpy_set_type_printers): Likewise.
8643
8644 2019-01-03  Tom Tromey  <tom@tromey.com>
8645
8646         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8647         (gdbpy_print_stack): Use gdbpy_err_fetch.
8648         * python/python-internal.h (class gdbpy_err_fetch): New class.
8649         (class gdbpy_enter) <m_error_type, m_error_value,
8650         m_error_traceback>: Remove.
8651         <m_error>: New member.
8652         (gdbpy_exception_to_string): Don't declare.
8653         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8654         * python/py-value.c (convert_value_from_python): Use
8655         gdbpy_err_fetch.
8656         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8657         gdbpy_exception_to_string.
8658         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8659         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8660         gdbpy_err_fetch.
8661
8662 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8663
8664         * linux-nat.c (delete_lwp_cleanup): Delete.
8665         (struct lwp_deleter): New struct.
8666         (lwp_info_up): New typedef.
8667         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8668         lwp_info_up.
8669
8670 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8671
8672         * linux-fork.c (class scoped_switch_fork_info): New class.
8673         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8674
8675 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8676
8677         * valops.c (find_overload_match): Remove use of null_cleanup, and
8678         calls to do_cleanups.
8679
8680 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8681
8682         * compile/compile-cplus-types.c
8683         (compile_cplus_instance::decl_name): Handle changes to
8684         cp_func_name.
8685         * cp-support.c (cp_func_name): Update header comment, update
8686         return type.
8687         * cp-support.h (cp_func_name): Update return type in declaration.
8688         * valops.c (find_overload_match): Move temp_func local to top
8689         level of function and change its type.  Use temp_func to hold and
8690         delete temporary string obtained from cp_func_name.
8691
8692 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8693
8694         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8695         gdb::char_vector, remove cleanup, and update uses of `msg`.
8696
8697 2019-01-03  Jim Wilson  <jimw@sifive.com>
8698
8699         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8700
8701 2019-01-02  Tom Tromey  <tom@tromey.com>
8702
8703         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8704         (tdesc_parse_xml): Remove cleanups.
8705         * target-descriptions.h (make_cleanup_free_target_description):
8706         Don't declare.
8707         (target_desc_deleter): New struct.
8708         (target_desc_up): New typedef.
8709         * target-descriptions.c (target_desc_deleter::operator()): Rename
8710         from free_target_description.
8711         (make_cleanup_free_target_description): Remove.
8712
8713 2019-01-02  Tom Tromey  <tom@tromey.com>
8714
8715         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8716         constructor, destructor.
8717         (linespec_parser): Remove typedef.
8718         (~linespec_parser): Rename from linespec_parser_delete.
8719         (linespec_lex_to_end, linespec_complete_label)
8720         (linespec_complete): Update.
8721         (decode_line_full): Remove cleanups.
8722         (decode_line_1): Update.
8723
8724 2019-01-02  Tom Tromey  <tom@tromey.com>
8725
8726         * python/python-internal.h (inferior_to_inferior_object): Change
8727         return type.
8728         * python/py-exitedevent.c (create_exited_event_object): Update.
8729         * python/py-inferior.c (inferior_to_inferior_object): Return
8730         gdbpy_ref.
8731         (python_new_inferior, python_inferior_deleted)
8732         (thread_to_thread_object, delete_thread_object)
8733         (build_inferior_list, gdbpy_selected_inferior): Update.
8734         * python/py-infthread.c (create_thread_object): Update.  Also fail
8735         if inferior_to_inferior_object fails.
8736
8737 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8738
8739         * inferior.h (class inferior) <displaced_step_state>: New field.
8740         * infrun.h (struct displaced_step_state): Move here from
8741         infrun.c.  Initialize fields, add constructor.
8742         <inf>: Remove field.
8743         <reset>: New method.
8744         * infrun.c (struct displaced_step_inferior_state): Move to
8745         infrun.h.
8746         (displaced_step_inferior_states): Remove.
8747         (get_displaced_stepping_state): Adust.
8748         (displaced_step_in_progress_any_inferior): Adjust.
8749         (displaced_step_in_progress_thread): Adjust.
8750         (displaced_step_in_progress): Adjust.
8751         (add_displaced_stepping_state): Remove.
8752         (get_displaced_step_closure_by_addr): Adjust.
8753         (remove_displaced_stepping_state): Remove.
8754         (infrun_inferior_exit): Call displaced_step_state.reset.
8755         (use_displaced_stepping): Don't check for NULL.
8756         (displaced_step_prepare_throw): Call
8757         get_displaced_stepping_state.
8758         (displaced_step_fixup): Don't check for NULL.
8759         (prepare_for_detach): Don't check for NULL.
8760
8761 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8762
8763         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8764          in case of call that did not complete.
8765
8766 2019-01-02  Andrey Utkin  <autkin@undo.io>
8767
8768         * symfile.c (find_separate_debug_file): Fix search of debug files for
8769         remote debuggee.
8770
8771 2019-01-02  Tom Tromey  <tom@tromey.com>
8772
8773         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8774         indentation.
8775         * python/py-frame.c (frapy_older): Remove cast.
8776         (frapy_newer): Likewise.
8777         * python/py-breakpoint.c (local_setattro): Remove cast.
8778         * python/py-arch.c (archpy_name): Remove local variable.
8779         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8780
8781 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8782
8783         * unittests/basic_string_view/element_access/char/empty.cc:
8784         Fix year range in copyright header.
8785
8786 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8787
8788         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8789         Delete.
8790         <operator==>: Update with for removed field.
8791         <hash>: Likewise.
8792         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8793         <isa_features>: ...this.
8794         <abi_features>: New field.
8795         (riscv_isa_flen): Update comment.
8796         (riscv_abi_xlen): New declaration.
8797         (riscv_abi_flen): New declaration.
8798         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8799         isa_features.
8800         (riscv_abi_xlen): New function.
8801         (riscv_isa_flen): Update to get answer from isa_features.
8802         (riscv_abi_flen): New function.
8803         (riscv_has_fp_abi): Update to get answer from abi_features.
8804         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8805         xlen and flen.
8806         (riscv_call_info) <xlen, flen>: Update comment.
8807         (riscv_call_arg_struct): Remove invalid assertions
8808         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8809         is removed.
8810         (riscv_gdbarch_init): Gather isa features and abi features
8811         separately, ensure both match on the gdbarch when reusing an old
8812         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8813         a target with 64-bit float hardware.
8814
8815 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8816
8817         * source.c (search_command_helper): Stop reverse search
8818         when line 1 has been searched.
8819
8820 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8821
8822         * record-full.c (record_full_base_target::close): Rewrite
8823         record_full_core_buf_list free logic.
8824
8825 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8826
8827         * break-catch-syscall.c (print_one_catch_syscall): xfree
8828         the last text.
8829
8830 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8831
8832         * top.c (print_gdb_version): Update Copyright year in version
8833         message.
8834
8835 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8836
8837         Update copyright year range in all GDB files.
8838
8839 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8840
8841         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8842
8843 For older changes see ChangeLog-2018.
8844 \f
8845 Local Variables:
8846 mode: change-log
8847 left-margin: 8
8848 fill-column: 74
8849 version-control: never
8850 coding: utf-8
8851 End:
8852