gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui.h (tui_is_window_visible): Return bool.
   4         * tui/tui.c (tui_is_window_visible): Return bool.
   5         * tui/tui-wingeneral.c (tui_make_window, make_visible)
   6         (tui_make_visible, tui_make_invisible)
   7         (tui_win_info::make_visible)
   8         (tui_source_window_base::make_visible, make_all_visible)
   9         (tui_make_all_visible, tui_make_all_invisible): Update.
  10         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
  11         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
  12         bool.
  13         (struct tui_win_info, struct tui_source_window_base)
  14         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
  15         * tui/tui-data.c (tui_init_generic_part): Update.
  16
  17 2019-06-25  Tom Tromey  <tom@tromey.com>
  18
  19         * tui/tui-wingeneral.c (tui_win_info::make_visible)
  20         (tui_source_window_base::make_visible): New methods.
  21         (make_all_visible): Make method call.
  22         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
  23         (struct tui_source_window_base, struct tui_cmd_window): Override
  24         make_visible.
  25         (tui_win_is_source_type): Don't declare.
  26         * tui/tui-data.c (tui_win_is_source_type): Remove.
  27
  28 2019-06-25  Tom Tromey  <tom@tromey.com>
  29
  30         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
  31         NULL check.
  32
  33 2019-06-25  Tom Tromey  <tom@tromey.com>
  34
  35         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
  36         Inline constructor.  Add initializers for members.
  37         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
  38         constructors; now inline in class.
  39
  40 2019-06-25  Tom Tromey  <tom@tromey.com>
  41
  42         * tui/tui-regs.c (tui_show_registers): Update.
  43         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
  44         bool.
  45         * tui/tui-data.c (tui_data_window::clear_detail)
  46         (tui_data_window): Update.
  47
  48 2019-06-25  Tom Tromey  <tom@tromey.com>
  49
  50         * tui/tui-windata.c (tui_display_all_data)
  51         (tui_display_data_from_line, tui_display_data_from)
  52         (tui_check_data_values, tui_data_window::do_scroll_vertical):
  53         Update.
  54         * tui/tui-regs.c (tui_last_regs_line_no)
  55         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
  56         (tui_show_registers, tui_show_register_group)
  57         (tui_display_registers_from, tui_display_reg_element_at_line)
  58         (tui_display_registers_from_line, tui_check_register_values)
  59         (tui_reg_next, tui_reg_prev): Update.
  60         * tui/tui-layout.c (tui_set_layout, show_data): Update.
  61         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
  62         tui_data_window.
  63         (struct tui_win_info) <detail>: Remove.  Add new fields from
  64         tui_data_info.
  65         (TUI_DATA_WIN): Add cast.
  66         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
  67         (~tui_data_window): Simplify.
  68
  69 2019-06-25  Tom Tromey  <tom@tromey.com>
  70
  71         * tui/tui-layout.c (show_source_disasm_command)
  72         (show_source_or_disasm_and_command): Update.
  73         * tui/tui-io.c (update_cmdwin_start_line)
  74         (tui_redisplay_readline): Update.
  75         * tui/tui-data.h (struct tui_command_info): Remove.
  76         (struct tui_win_info) <detail>: Remove command_info member.
  77         (struct tui_data_window) <start_line>: New member, from
  78         tui_command_info.
  79         (TUI_CMD_WIN): Add casts.
  80
  81 2019-06-25  Tom Tromey  <tom@tromey.com>
  82
  83         * tui/tui-winsource.c (tui_update_source_window)
  84         (tui_refill_source_window)
  85         (tui_source_window_base::do_scroll_horizontal)
  86         (tui_update_breakpoint_info, tui_set_exec_info_content)
  87         (tui_show_exec_info_content, tui_erase_exec_info_content)
  88         (tui_clear_exec_info_content): Update.
  89         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
  90         Update.
  91         * tui/tui-win.c (make_invisible_and_set_new_height)
  92         (make_visible_with_new_height): Update.
  93         * tui/tui-source.c (tui_set_source_content)
  94         (tui_show_symtab_source): Update.
  95         * tui/tui-layout.c (extract_display_start_addr)
  96         (show_source_disasm_command, show_data)
  97         (make_source_or_disasm_window)
  98         (show_source_or_disasm_and_command): Update.
  99         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 100         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 101         "gdbarch".
 102         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 103         to tui_source_window_base.
 104         (struct tui_win_info) <detail>: Remove source_info member.
 105         (struct tui_source_window_base) <has_locator>: Inline.
 106         Move contents from tui_source_info; rename has_locator member to
 107         m_has_locator.
 108         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 109         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 110         header file.
 111         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 112         Simplify.
 113         (tui_free_all_source_wins_content): Cast to
 114         tui_source_window_base.
 115
 116 2019-06-25  Tom Tromey  <tom@tromey.com>
 117
 118         * tui/tui-win.c (make_invisible_and_set_new_height)
 119         (make_visible_with_new_height): Call has_locator method.
 120         * tui/tui-layout.c (show_source_disasm_command, show_data)
 121         (show_source_or_disasm_and_command): Update for bool change.
 122         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 123         (tui_win_info) <has_locator>: New method.
 124         (struct tui_source_window_base) <has_locator>: New method.
 125         (tui_win_has_locator): Don't declare.
 126         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 127         from tui_win_has_locator.
 128         (tui_source_window_base): Use false, not FALSE.
 129
 130 2019-06-25  Tom Tromey  <tom@tromey.com>
 131
 132         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 133         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 134         clear_detail method directly.
 135         (tui_clear_win_detail): Remove.
 136
 137 2019-06-25  Tom Tromey  <tom@tromey.com>
 138
 139         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 140         "this", not TUI_DISASM_WIN.
 141
 142 2019-06-25  Tom Tromey  <tom@tromey.com>
 143
 144         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 145         declare.
 146         * tui/tui-winsource.c
 147         (tui_source_window_base::do_scroll_horizontal): Rename from
 148         tui_horizontal_source_scroll.
 149         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 150         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 151         from tui_vertical_data_scroll.
 152         * tui/tui-win.h (tui_scroll): Don't declare.
 153         * tui/tui-win.c (tui_win_info::forward_scroll)
 154         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 155         (tui_win_info::right_scroll): Rename and update.
 156         (tui_scroll_forward_command, tui_scroll_backward_command)
 157         (tui_scroll_left_command, tui_scroll_right_command): Update.
 158         (tui_scroll): Remove.
 159         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 160         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 161         from tui_vertical_source_scroll.
 162         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 163         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 164         from tui_vertical_disassem_scroll.
 165         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 166         do_scroll_horizontal>: New methods.
 167         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 168         Likewise.
 169         (struct tui_source_window_base): Add do_scroll_horizontal.
 170         (struct tui_source_window, struct tui_disasm_window): Add
 171         do_scroll_vertical.
 172         (struct tui_data_window, struct tui_cmd_window): Add
 173         do_scroll_horizontal and do_scroll_vertical.
 174         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 175
 176 2019-06-25  Tom Tromey  <tom@tromey.com>
 177
 178         * tui/tui-data.h (struct tui_source_window_base): New struct.
 179         (struct tui_source_window): Derive from tui_source_window_base.
 180         (struct tui_disasm_window): New struct.
 181         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 182         from tui_source_window::clear_detail.
 183         (tui_source_window_base): Rename from tui_source_window.
 184         (~tui_source_window_base): Rename from ~tui_source_window.
 185         (tui_alloc_win_info): Create a tui_disasm_window.
 186
 187 2019-06-25  Tom Tromey  <tom@tromey.com>
 188
 189         * tui/tui-data.h (struct tui_source_window)
 190         (struct tui_data_window): Declare destructors.
 191         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 192         destructors.
 193         (tui_win_info): Simplify.
 194
 195 2019-06-25  Tom Tromey  <tom@tromey.com>
 196
 197         * tui/tui-winsource.c (tui_display_main)
 198         (tui_update_source_windows_with_addr)
 199         (tui_update_all_breakpoint_info): Update.
 200         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 201         (new_height_ok, parse_scrolling_args): Update.
 202         * tui/tui-stack.c (tui_show_frame_info): Update.
 203         * tui/tui-data.h (struct tui_list): Remove.
 204         (tui_source_windows): Return a reference to a std::vector.
 205         * tui/tui-data.c (source_windows): Now a std::vector.
 206         (tui_source_windows): Change return type.
 207         (tui_clear_source_windows): Rewrite.
 208         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 209         (tui_free_all_source_wins_content): Rewrite.
 210
 211 2019-06-25  Tom Tromey  <tom@tromey.com>
 212
 213         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 214         (struct tui_data_window, struct tui_cmd_window): Declare
 215         clear_detail method.
 216         * tui/tui-data.c (tui_source_window::clear_detail)
 217         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 218         methods.
 219         (tui_clear_win_detail): Simplify.
 220
 221 2019-06-25  Tom Tromey  <tom@tromey.com>
 222
 223         * tui/tui-layout.c (make_source_window, make_disasm_window)
 224         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 225         Return the new window.
 226         (show_source_disasm_command, show_data)
 227         (show_source_or_disasm_and_command): Update.
 228
 229 2019-06-25  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 232         parameter.  Return the new window.
 233         (show_source_disasm_command): Update and remove NULL check.
 234         (show_source_or_disasm_and_command): Update.
 235
 236 2019-06-25  Tom Tromey  <tom@tromey.com>
 237
 238         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 239
 240 2019-06-25  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui-data.h (struct tui_win_info): Make constructor
 243         protected.  Make destructor virtual.  Add initializers.
 244         (tui_source_window, tui_data_window, tui_cmd_window): New
 245         classes.
 246         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 247         constructor.  Add "type" parameter.
 248         (tui_source_window, tui_data_window, tui_cmd_window): New
 249         constructors.
 250         (tui_alloc_win_info): Instantiate the appropriate subclass.
 251
 252 2019-06-25  Tom Tromey  <tom@tromey.com>
 253
 254         * tui/tui-win.c (tui_resize_all): Use delete.
 255         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 256         destructor.
 257         (tui_free_window): Don't declare.
 258         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 259         Update.
 260
 261 2019-06-25  Tom Tromey  <tom@tromey.com>
 262
 263         * tui/tui-data.h (struct tui_win_info): Add constructor.
 264         * tui/tui-data.c (tui_alloc_win_info): Use new.
 265         (tui_free_window): Use delete.
 266
 267 2019-06-22  Tom Tromey  <tom@tromey.com>
 268
 269         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 270         declare.
 271         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 272
 273 2019-06-22  Tom Tromey  <tom@tromey.com>
 274
 275         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 276         declare.
 277         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 278
 279 2019-06-22  Tom de Vries  <tdevries@suse.de>
 280
 281         * dwarf2read.c (create_addrmap_from_aranges)
 282         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 283         instead of '%zu'.
 284
 285 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 286
 287         * dwarf2read.h (dwarf2_section_info_def): Remove.
 288         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 289         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 290         std::vector<dwarf2_section_info>.
 291         (struct dwo_file) <~dwo_file>: Remove.
 292         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 293         types field.
 294         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 295         (dwarf2_read_debug_names): Likewise.
 296         (create_debug_types_hash_table): Change parameter type to
 297         array_view, adjust code accordingly.
 298         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 299         (partial_die_info::fixup): Likewise.
 300         (determine_prefix): Likewise.
 301         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 302
 303 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 304
 305         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 306         gdb_bfd_ref_ptr.
 307         <~dwo_file>: Remove call to gdb_bfd_unref.
 308         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 309         gdb_bfd_ref_ptr::get.
 310
 311 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 312
 313         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 314         type to htab_up.
 315         * dwarf2read.c (struct dwo_file): Initialize fields.
 316         <~dwo_file>: New.
 317         (free_dwo_file): Remove, move content to ~dwo_file.
 318         (struct dwo_file_deleter): Remove.
 319         (dwo_file_up>: Remove custom deleter.
 320         (free_dwo_files): Remove.
 321         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 322         dwo_files.
 323         (process_skeletonless_type_units): Call unique_ptr::get.
 324         (allocate_dwo_file_hash_table): Add deleter to created hash
 325         table.  Change return type to htab_up.
 326         (lookup_dwo_file_slot): Don't memset dwo_file, call
 327         unique_ptr::get.
 328         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 329         (create_dwo_unit_in_dwp_v2): Likewise.
 330         (open_and_init_dwo_file): Likewise.
 331         (free_dwo_file_from_slot): Remove.
 332
 333 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 334
 335         * dwarf2read.h (struct dwarf2_section_info) <readin,
 336         is_virtual>: Change type to bool.
 337         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 338         true instead of 1.
 339
 340 2019-06-19  Tom Tromey  <tom@tromey.com>
 341
 342         * tui/tui-data.h (tui_init_content_element): Don't declare.
 343
 344 2019-06-19  Tom Tromey  <tom@tromey.com>
 345
 346         * tui/tui-data.h (tui_init_win_info): Don't declare.
 347
 348 2019-06-19  Tom de Vries  <tdevries@suse.de>
 349
 350         * dwarf2read.h (abstract_to_concrete): Change type to
 351         std::unordered_map<sect_offset, std::vector<sect_offset>,
 352         gdb::hash_enum<sect_offset>>.
 353
 354 2019-06-19  Tom Tromey  <tromey@adacore.com>
 355
 356         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 357         EVAL_AVOID_SIDE_EFFECTS specially.
 358
 359 2019-06-19  Tom Tromey  <tromey@adacore.com>
 360
 361         * source-cache.c (highlighter): New global.
 362         (source_cache::get_source_lines): Create a highlighter on demand.
 363
 364 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 365
 366         * defs.h (deprecated_interactive_hook): Delete declaration.
 367         * interps.c (clear_interpreter_hooks): Remove use of
 368         deprecated_interactive_hook.
 369         * top.c (deprecated_interactive_hook): Delete definition.
 370         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 371
 372 2019-06-18  Tom de Vries  <tdevries@suse.de>
 373
 374         PR gdb/24515
 375         * dwarf2read.h (abstract_to_concrete): Change type from
 376         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 377         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 378         * dwarf2read.c (read_variable): Update.
 379         (dwarf2_fetch_die_loc_sect_off): Update.
 380
 381 2019-06-17  Tom de Vries  <tdevries@suse.de>
 382
 383         PR gdb/24617
 384         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 385         accessing parent[parent_len - 1].
 386
 387 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 388
 389         PR gdb/24364
 390         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 391         call dtrace_process_dof with NULL dof.
 392
 393 2019-06-16  Tom de Vries  <tdevries@suse.de>
 394
 395         PR gdb/24445
 396         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 397
 398 2019-06-16  Tom Tromey  <tom@tromey.com>
 399
 400         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 401         (make_all_visible): Use address of member.
 402
 403 2019-06-16  Tom Tromey  <tom@tromey.com>
 404
 405         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 406         (tui_free_window, free_content, free_content_elements): Remove
 407         unnecessary cast.
 408         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 409         cast.
 410         * tui/tui-regs.c (tui_show_register_group)
 411         (tui_display_registers_from, tui_display_reg_element_at_line):
 412         Remove unnecessary cast.
 413
 414 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 415
 416         * linux-nat.c (normal_mask): Delete.
 417         (_initialize_linux_nat): Don't initialise normal_mask.
 418
 419 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 420
 421         PR gdb/24445
 422         * dwarf-index-write.h (write_psymtabs_to_index): Add
 423         dwz_basename parameter.
 424         * dwarf-index-write.c (write_gdbindex): Move file writing to
 425         write_gdbindex_1.  Change return type void.
 426         (assert_file_size): Move up, remove filename parameter.
 427         (write_gdbindex_1): New function.
 428         (write_debug_names): Change return type to void, call
 429         assert_file_size.
 430         (struct index_wip_file): New struct.
 431         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 432         file logic to index_wip_file.  Write index for dwz file if
 433         needed.
 434         (save_gdb_index_command): Pass basename of dwz file, if present.
 435         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 436         build-id of dwz file, if present.
 437         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 438         (dwarf2_get_dwz_file): Likewise.
 439         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 440         (dwarf2_get_dwz_file): Likewise.
 441
 442 2019-06-16  Tom Tromey  <tom@tromey.com>
 443
 444         * coffread.c (process_coff_symbol): Use xstrdup.
 445         * value.c (create_internalvar): Use xstrdup.
 446
 447 2019-06-16  Tom Tromey  <tom@tromey.com>
 448
 449         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 450         * breakpoint.c (stopin_command, stopat_command)
 451         (until_break_command, decode_location_default): Remove unnecessary
 452         cast.
 453         * utils.c (subset_compare): Remove unnecessary cast.
 454         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 455         cast.
 456         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 457         cast.
 458         * infcmd.c (path_command): Remove unnecessary cast.
 459         * coffread.c (decode_type): Remove unnecessary cast.
 460         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 461         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 462         * tui/tui-stack.c (tui_show_locator_content)
 463         (tui_show_frame_info): Remove unnecessary cast.
 464         * tui/tui-win.c (tui_scroll_forward_command)
 465         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 466         (parse_scrolling_args): Remove unnecessary cast.
 467         * tui/tui-data.c (init_win_info, tui_del_window)
 468         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 469         (free_content_elements): Remove unnecessary cast.
 470         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 471         unnecessary cast.
 472         * tui/tui-source.c (tui_set_source_content)
 473         (tui_vertical_source_scroll): Remove unnecessary cast.
 474         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 475         cast.
 476         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 477         * tui/tui-regs.c (tui_display_registers_from)
 478         (tui_display_register): Remove unnecessary cast.
 479         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 480         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 481         (make_visible): Remove unnecessary cast.
 482         * tui/tui-winsource.c (tui_erase_source_content)
 483         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 484         unnecessary cast.
 485         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 486         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 487         * stabsread.c (read_type, read_array_type, read_range_type):
 488         Remove unnecessary cast.
 489         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 490         (parse_symbol, parse_type, upgrade_type, parse_external)
 491         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 492         unnecessary cast.
 493         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 494
 495 2019-06-16  Tom Tromey  <tom@tromey.com>
 496
 497         * tui/tui-data.c (tui_alloc_generic_win_info)
 498         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 499         checks.
 500
 501 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 502             Andrew Burgess  <andrew.burgess@embecosm.com>
 503
 504         * f-typeprint.c (f_print_type): Don't return early for not
 505         associated or not allocated types.
 506         (f_type_print_varspec_suffix): Add print_rank parameter and print
 507         ranks of array types in case they dangling.
 508         (f_type_print_base): Add print_rank parameter.
 509
 510 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 511
 512         * NEWS: Mention new MI commands.
 513         * break-catch-throw.c (enum exception_event_kind): Move to
 514         breakpoint.h.
 515         (print_mention_exception_catchpoint): Output text as a single
 516         message.
 517         (catch_exception_command_1): Rename to...
 518         (catch_exception_event): ...this, make non-static, update header
 519         command, and change some parameter types.
 520         (catch_catch_command): Update for changes to
 521         catch_exception_command_1.
 522         (catch_throw_command): Likewise.
 523         (catch_rethrow_command): Likewise.
 524         * breakpoint.c (enum exception_event_kind): Delete.
 525         * breakpoint.h (enum exception_event_kind): Moved here from
 526         break-catch-throw.c.
 527         (catch_exception_event): Declare.
 528         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 529         (mi_cmd_catch_throw): New function.
 530         (mi_cmd_catch_rethrow): New function.
 531         (mi_cmd_catch_catch): New function.
 532         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 533         'catch-catch' entries.
 534         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 535         (mi_cmd_catch_rethrow): Declare.
 536         (mi_cmd_catch_catch): Declare.
 537
 538 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 539
 540         * annotate.c (annotate_source_line): Change return type to void,
 541         update implementation to match.
 542         * annotate.h (annotate_source_line): Change return type to void,
 543         update header comment.
 544         * stack.c (print_frame_info): Don't change what frame information
 545         is printed based on whether annotations are on or not.
 546
 547 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 548
 549         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 550         (annotate_source): Make static.
 551         (annotate_source_line): Moved from source.c and renamed from
 552         identify_source_line.  Update the return type.
 553         * annotate.h (annotate_source): Delete declaration.
 554         (annotate_source_line): Declaration moved from source.h, and
 555         renamed from identify_source_line.  Return type updated.
 556         * source.c (identify_source_line): Moved to annotate.c and renamed
 557         to annotate_source_line.
 558         (info_line_command): Remove check of annotation_level.
 559         * source.h (identify_source_line): Move declaration to annotate.h
 560         and rename to annotate_source_line.
 561         * stack.c: Add 'annotate.h' include.
 562         (print_frame_info): Remove check of annotation_level before
 563         calling annotate_source_line.
 564
 565 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 566
 567         * source-cache.c (source_cache::get_plain_source_lines): Use
 568         open_source_file_with_line_charpos instead of just
 569         open_source_file, remove call to find_source_lines.
 570         (source_cache::get_source_lines): Likewise.
 571         * source.c (find_source_lines): Make static.
 572         (get_filename_and_charpos): Renamed into...
 573         (open_source_file_with_line_charpos): ..this along with changes to
 574         return a scoped_fd, and some other minor clean ups.
 575         (identify_source_line): Use open_source_file_with_line_charpos.
 576         (search_command_helper): Use open_source_file_with_line_charpos
 577         instead of just open_source_file, remove call to
 578         find_source_lines.
 579         * source.h (open_source_file_with_line_charpos): Declare new
 580         function.
 581         (find_source_lines): Delete declaration.
 582
 583 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 584
 585         * source.c (get_filename_and_charpos): Remove fullname
 586         parameter.
 587         (identify_source_line): Update call to get_filename_and_charpos.
 588
 589 2019-06-14  Tom Tromey  <tromey@adacore.com>
 590
 591         PR gdb/24502:
 592         * ui-style.h (skip_ansi_escape): Update comment.
 593         * ui-file.h (class no_terminal_escape_file): New class.
 594         * ui-file.c (no_terminal_escape_file::write)
 595         (no_terminal_escape_file::puts): New methods.
 596         * cli/cli-logging.c (handle_redirections): Use
 597         no_terminal_escape_file.
 598
 599 2019-06-14  Tom Tromey  <tromey@adacore.com>
 600
 601         * NEWS: Move convenience variable news above Python news.
 602
 603 2019-06-14  Tom Tromey  <tom@tromey.com>
 604
 605         * gnulib: Move directory to top-level.
 606         * configure.ac: Don't configure gnulib.
 607         * configure: Rebuild.
 608         * common/common-defs.h: Use new path to gnulib.
 609         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 610         (GNULIB_H): Remove.
 611         (INCGNU): Look in new gnulib location.
 612         (HFILES_NO_SRCDIR): Remove gnulib files.
 613         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 614         (generated_files): Remove GNULIB_H.
 615         ($(LIBGNU), all-lib): Remove targets.
 616         (distclean): Don't mention GNULIB_BUILDDIR.
 617         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 618
 619 2019-06-14  Tom Tromey  <tromey@adacore.com>
 620
 621         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 622         Warn if symbol file does not provide any symbols.
 623
 624 2019-06-14  Tom Tromey  <tromey@adacore.com>
 625
 626         * source.c (find_and_open_source): Respect basenames_may_differ.
 627
 628 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 629
 630         * annotate.c (annotate_breakpoints_invalid): Make use of
 631         scoped_restore_terminal_state.
 632         (annotate_frames_invalid): Likewise.
 633
 634 2019-06-14  Tom Tromey  <tromey@adacore.com>
 635
 636         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 637         allow assignment to an internalvar.
 638
 639 2019-06-14  Tom Tromey  <tromey@adacore.com>
 640
 641         * ada-lex.l: Allow "_" in attribute names.
 642
 643 2019-06-14  Tom Tromey  <tromey@adacore.com>
 644
 645         PR gdb/24653:
 646         * regcache.c (registers_changed): Don't call alloca.
 647         * top.c (execute_command): Don't call alloca.
 648
 649 2019-06-13  Pedro Alves  <palves@redhat.com>
 650
 651         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 652         'expression'.  When parsing an expression, error out if there's
 653         junk after "unlimited".
 654         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 655         (do_set_command): Adjust calls to is_unlimited_literal.
 656
 657 2019-06-13  Pedro Alves  <palves@redhat.com>
 658
 659         * compile/compile.c (make_compile_options_def_group): Add braces
 660         around array_view initializer.
 661         * thread.c (make_thread_apply_all_options_def_group)
 662         (make_thread_apply_all_options_def_group): Likewise.
 663
 664 2019-06-13  Pedro Alves  <palves@redhat.com>
 665
 666         * NEWS (New commands): Mention "maint test-options
 667         require-delimiter", "maint test-options unknown-is-error", "maint
 668         test-options unknown-is-operand" and "maint show
 669         test-options-completion-result".
 670         (New command options, command completion): New section.
 671         (Completion improvements): New section.
 672         Mention that you can abbreviate "unlimited".
 673
 674 2019-06-13  Pedro Alves  <palves@redhat.com>
 675
 676         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 677         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 678         * unittests/cli-utils-selftests.c (test_parse_flags)
 679         (test_parse_flags_qcs): Delete.
 680         (test_cli_utils): Don't call deleted functions.
 681
 682 2019-06-13  Pedro Alves  <palves@redhat.com>
 683
 684         * thread.c: Include "cli/cli-option.h".
 685         (tp_array_compar_ascending): Global.
 686         (tp_array_compar): Delete function.
 687         (tp_array_compar_ascending, tp_array_compar_descending): New
 688         functions.
 689         (ascending_option_def, qcs_flag_option_def)
 690         (thr_qcs_flags_option_defs)
 691         (make_thread_apply_all_options_def_group)
 692         (make_thread_apply_options_def_group): New.
 693         (thread_apply_all_command): Use gdb::option::process_options.
 694         (thread_apply_command_completer)
 695         (thread_apply_all_command_completer): New.
 696         (thread_apply_command): Use gdb::option::process_options.
 697         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 698         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 699         to generate help text of "thread apply".  Adjust "taas"'s help.
 700         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 701         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 702
 703 2019-06-13  Pedro Alves  <palves@redhat.com>
 704
 705         * thread.c (thread_apply_command): Check for invalid TID with
 706         isdigit instead of !isalpha.
 707
 708 2019-06-13  Pedro Alves  <palves@redhat.com>
 709
 710         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 711         (validate_flags_qcs): New.
 712         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 713         (validate_flags_qcs): Declare.
 714         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 715         (make_frame_apply_options_def_group): New.
 716         (frame_apply_command_count): Process options with
 717         gdb::option::process_options.
 718         (frame_apply_completer): New.
 719         (frame_apply_level_completer, frame_apply_all_completer)
 720         (frame_apply_completer): New.
 721         (_initialize_stack): Update help of "frame apply", "frame apply
 722         level", "frame apply all" and "faas" to mention supported options
 723         and install command completers.
 724         * stack.h (frame_apply_all_completer): Declare.
 725         * thread.c: Include "stack.h".
 726         (tfaas_command): Add "--".
 727         (_initialize_thread): Update help "tfaas" to mention supported
 728         options and install command completer.
 729
 730 2019-06-13  Pedro Alves  <palves@redhat.com>
 731
 732         * completer.c (complete_nested_command_line): New.
 733         (gdb_completion_word_break_characters_throw): Add assertion.
 734         * completer.h (complete_nested_command_line): Declare.
 735
 736 2019-06-13  Pedro Alves  <palves@redhat.com>
 737
 738         * stack.c (parse_backtrace_qualifiers): New.
 739         (backtrace_command): Use it.
 740         (backtrace_command_completer): Complete on qualifiers.
 741
 742 2019-06-13  Pedro Alves  <palves@redhat.com>
 743
 744         * frame.c: Include "cli/cli-option.h.
 745         (user_set_backtrace_options): New.
 746         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 747         Delete.
 748         (get_prev_frame): Adjust.
 749         (boolean_option_def, uinteger_option_def)
 750         (set_backtrace_option_defs): New.
 751         (_initialize_frame): Adjust and use
 752         gdb::option::add_setshow_cmds_for_options to install "set
 753         backtrace past-main" and "set backtrace past-entry".
 754         * frame.h: Include "cli/cli-option.h".
 755         (struct frame_print_options): Forward declare.
 756         (print_frame_arguments_all, print_frame_arguments_scalars)
 757         (print_frame_arguments_none): Declare.
 758         (print_entry_values): Delete declaration.
 759         (struct frame_print_options, user_frame_print_options): New.
 760         (struct set_backtrace_options): New.
 761         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 762         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 763         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 764         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 765         (list_args_or_locals): Add frame_print_options parameter.
 766         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 767         * python/py-framefilter.c (enumerate_args): Pass down
 768         USER_FRAME_PRINT_OPTIONS.
 769         * stack.c: Include "cli/cli-option.h".
 770         (print_frame_arguments_all, print_frame_arguments_scalars)
 771         (print_frame_arguments_none): Declare.
 772         (print_raw_frame_arguments, print_entry_values): Delete.
 773         (user_frame_print_options): New.
 774         (boolean_option_def, enum_option_def, frame_print_option_defs):
 775         New.
 776         (struct backtrace_cmd_options): New.
 777         (bt_flag_option_def): New.
 778         (backtrace_command_option_defs): New.
 779         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 780         (print_frame_arg, read_frame_arg, print_frame_args)
 781         (print_frame_info, print_frame): Add frame_print_options parameter
 782         and use it.
 783         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 784         (backtrace_command_1): Add frame_print_options and
 785         backtrace_cmd_options parameters and use them.
 786         (make_backtrace_options_def_group): New.
 787         (backtrace_command): Process command options with
 788         gdb::option::process_options.
 789         (backtrace_command_completer): New.
 790         (_initialize_stack): Extend "backtrace"'s help to mention
 791         supported options.  Install completer for "backtrace".
 792         Install some settings commands with add_setshow_cmds_for_options.
 793
 794 2019-06-13  Pedro Alves  <palves@redhat.com>
 795
 796         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 797         and that "set/show print raw frame-arguments" are now deprecated.
 798
 799         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 800         command.
 801         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 802         * stack.c (_initialize_stack): Install "set/show print
 803         raw-frame-arguments", and deprecate "set/show print raw
 804         frame-arguments".
 805         * valprint.c (_initialize_valprint): Deprecate "set/show print
 806         raw".
 807
 808 2019-06-13  Pedro Alves  <palves@redhat.com>
 809
 810         * compile/compile.c (struct compile_options): New.
 811         (compile_flag_option_def, compile_command_option_defs)
 812         (make_compile_options_def_group): New.
 813         (compile_file_command): Handle options with
 814         gdb::option::process_options.
 815         (compile_file_command_completer): New function.
 816         (compile_code_command): Handle options with
 817         gdb::option::process_options.
 818         (compile_code_command_completer): New function.
 819         (_initialize_compiler): Install completers for "compile code" and
 820         "compile file".  Mention available options in "compile code" and
 821         "compile code"'s help.
 822         * completer.c (advance_to_completion_word): New, factored out from
 823         ...
 824         (advance_to_expression_complete_word_point): ... this.
 825         (advance_to_filename_complete_word_point): New.
 826         * completer.h (advance_to_filename_complete_word_point): New
 827         declaration.
 828
 829 2019-06-13  Pedro Alves  <palves@redhat.com>
 830
 831         * compile/compile.c: Include "cli/cli-option.h".
 832         (compile_print_value): Scope data pointer is now a
 833         value_print_options pointer; adjust.
 834         (compile_print_command): Process options.  Scope data pointer is
 835         now a value_print_options pointer; adjust.
 836         (_initialize_compile): Update "compile print"'s help to include
 837         supported options.  Install a completer for "compile print".
 838         * cp-valprint.c (show_vtblprint, show_objectprint)
 839         (show_static_field_print): Delete.
 840         (_initialize_cp_valprint): Don't install "set print
 841         static-members", "set print vtbl", "set print object" here.
 842         * printcmd.c: Include "cli/cli-option.h" and
 843         "common/gdb_optional.h".
 844         (print_command_parse_format): Rework to fill in a
 845         value_print_options instead of a format_data.
 846         (print_value): Change parameter type from format_data pointer to
 847         value_print_options reference.  Adjust.
 848         (print_command_1): Process options.  Adjust to pass down a
 849         value_print_options.
 850         (print_command_completer): New.
 851         (_initialize_printcmd): Install print_command_completer as
 852         handle_brkchars completer for the "print" command.  Update
 853         "print"'s help to include supported options.
 854         * valprint.c: Include "cli/cli-option.h".
 855         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 856         here from cp-valprint.c.
 857         (boolean_option_def, uinteger_option_def)
 858         (value_print_option_defs, make_value_print_options_def_group):
 859         New.  Use gdb::option::add_setshow_cmds_for_options to install
 860         "set print elements", "set print null-stop", "set print repeats",
 861         "set print pretty", "set print union", "set print array", "set
 862         print address", "set print symbol", "set print array-indexes".
 863         * valprint.h: Include <string> and "cli/cli-option.h".
 864         (make_value_print_options_def_group): Declare.
 865         (print_value): Change parameter type from format_data pointer to
 866         value_print_options reference.
 867         (print_command_completer): Declare.
 868
 869 2019-06-13  Pedro Alves  <palves@redhat.com>
 870
 871         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 872         (COMMON_SFILES): Add maint-test-settings.c.
 873         * cli/cli-decode.c (boolean_enums): New global, factored out from
 874         ...
 875         (add_setshow_boolean_cmd): ... here.
 876         * cli/cli-decode.h (boolean_enums): Declare.
 877         * cli/cli-option.c: New file.
 878         * cli/cli-option.h: New file.
 879         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 880         factored out from ...
 881         (parse_cli_boolean_value(const char *)): ... this.
 882         (is_unlimited_literal): Change parameter type to pointer to
 883         pointer.  Adjust and advance ARG pointer.
 884         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 885         (parse_cli_var_enum): New, factored out from ...
 886         (do_set_command): ... this.  Adjust.
 887         * cli/cli-setshow.h (parse_cli_boolean_value)
 888         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 889         (parse_cli_var_enum): Declare.
 890         * cli/cli-utils.c: Include "cli/cli-option.h".
 891         (get_ulongest): New.
 892         * cli/cli-utils.h (get_ulongest): Declare.
 893         (check_for_argument): New overloads.
 894         * maint-test-options.c: New file.
 895
 896 2019-06-13  Pedro Alves  <palves@redhat.com>
 897
 898         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 899         parse a range if "-" is at the end of the string.
 900
 901 2019-06-13  Pedro Alves  <palves@redhat.com>
 902
 903         * cli/cli-setshow.c (parse_auto_binary_operation)
 904         (parse_cli_boolean_value): Don't allow "o".
 905
 906 2019-06-13  Pedro Alves  <palves@redhat.com>
 907
 908         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 909         * NEWS: Mention maint test-settings KIND.
 910         * maint-test-settings.c: New file.
 911
 912 2019-06-13  Pedro Alves  <palves@redhat.com>
 913
 914         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 915         completer.
 916         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 917         "set" completers.
 918
 919 2019-06-13  Pedro Alves  <palves@redhat.com>
 920
 921         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 922         after item.
 923
 924 2019-06-13  Pedro Alves  <palves@redhat.com>
 925
 926         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 927
 928 2019-06-13  Pedro Alves <palves@redhat.com>
 929
 930         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 931         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 932         call.
 933         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 934         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 935         calls.
 936         (check_for_argument): Skip spaces after argument.
 937
 938 2019-06-13  Pedro Alves  <palves@redhat.com>
 939
 940         * thread.c (thread_apply_command): Adjust TID parsing.
 941         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 942         detected before end of string.
 943         (tid_is_in_list): Error out if LIST is invalid.
 944
 945 2019-06-13  Pedro Alves  <palves@redhat.com>
 946
 947         * completer.c (complete_line_internal_1): Rewind completion word
 948         point.
 949         (completion_tracker::advance_custom_word_point_by): Change
 950         parameter type to int.
 951         * completer.h (completion_tracker::advance_custom_word_point_by):
 952         Likewise.
 953
 954 2019-06-13  Pedro Alves  <palves@redhat.com>
 955
 956         * completer.c (advance_to_completion_word): Handle delimiters.
 957
 958 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 959
 960         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 961
 962 2019-06-11  Tom Tromey  <tom@tromey.com>
 963
 964         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 965         (xmalloc_failed): Move to alloc.c.
 966         * alloc.c: New file.
 967         * Makefile.in (COMMON_SFILES): Add alloc.c.
 968
 969 2019-06-11  Tom Tromey  <tom@tromey.com>
 970
 971         * nat/linux-waitpid.c: Don't include server.h.
 972         (linux_debug): Remove.
 973         (my_waitpid): Update.
 974
 975 2019-06-11  Tom Tromey  <tromey@adacore.com>
 976
 977         * infcall.c (_initialize_infcall): Remove trailing newline from
 978         help.
 979         * user-regs.c (_initialize_user_regs): Remove trailing newline
 980         from help.
 981         * typeprint.c (_initialize_typeprint): Remove trailing newline
 982         from help.
 983         * reverse.c (_initialize_reverse): Remove trailing newlines from
 984         help.
 985         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 986         from help.
 987         * language.c (add_set_language_command): Remove trailing newline
 988         from help.
 989         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 990         help.
 991         * disasm.c (_initialize_disasm): Remove trailing newline from
 992         help.
 993         * top.c (init_main): Remove trailing newline from help.
 994         * interps.c (_initialize_interpreter): Remove trailing newline
 995         from help.
 996         * btrace.c (_initialize_btrace): Remove trailing newlines from
 997         help.
 998         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 999         from help.
1000         * python/python.c (_initialize_python): Remove trailing newline
1001         from help.
1002         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1003         help.
1004         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1005         from help.  Reformat some text.
1006         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1007         from help.
1008         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1009         newline from help.
1010
1011 2019-06-11  Tom Tromey  <tromey@adacore.com>
1012
1013         * darwin-nat.c (darwin_decode_exception_message)
1014         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1015
1016 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1017
1018         * valops.c (value_slice): Check for not allocated or not
1019         associated values.
1020
1021 2019-06-10  Tom de Vries  <tdevries@suse.de>
1022
1023         PR gdb/24618
1024         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1025         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1026         invalid.
1027
1028 2019-06-10  Tom de Vries  <tdevries@suse.de>
1029
1030         PR gdb/24611
1031         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1032         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1033
1034 2019-06-10  Tom de Vries  <tdevries@suse.de>
1035
1036         PR symtab/24545
1037         * symtab.c (struct demangled_name_entry): Add language field.
1038         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1039         static minimal symbol".  Set and use language field.
1040
1041 2019-06-10  Tom Tromey  <tromey@adacore.com>
1042
1043         * ada-lang.c (_initialize_ada_language): Update help text.
1044
1045 2019-06-10  Tom Tromey  <tromey@adacore.com>
1046
1047         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1048         with a newline.
1049         * guile/guile.c (handle_boot_error): Don't end warning with a
1050         newline.
1051         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1052         warning with a newline.
1053         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1054         newline.
1055         (s12z_frame_cache): Likewise.
1056         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1057         a newline.
1058         * solib-svr4.c (disable_probes_interface): Don't end warning with
1059         a newline.
1060         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1061         newline.
1062         * python/python.c (do_finish_initialization): Don't end warning
1063         with a newline.
1064
1065 2019-06-10  Tom Tromey  <tom@tromey.com>
1066
1067         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1068         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1069         gdbpy_enter.
1070
1071 2019-06-10  Tom Tromey  <tromey@adacore.com>
1072
1073         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1074         data.
1075         (elf_new_init): Don't call stabsread_new_init.
1076         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1077         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1078         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1079
1080 2019-06-10  Tom de Vries  <tdevries@suse.de>
1081
1082         PR symtab/16264
1083         PR symtab/24517
1084         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1085
1086 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1087
1088         * source.c (find_and_open_source): Also rewrite relative file
1089         names.
1090
1091 2019-04-26  Amos Bird  <amosbird@gmail.com>
1092
1093         * annotate.c (annotate_thread_exited): Add "thread-exited"
1094         annotation.
1095
1096 2019-06-06  Tom Tromey  <tromey@adacore.com>
1097
1098         * maint.h (class scoped_command_stats): Use
1099         DISABLE_COPY_AND_ASSIGN.
1100         <print_time>: New method.
1101         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1102         print_time.
1103         (scoped_command_stats::print_time): New method.
1104
1105 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1106
1107         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1108         instructions of lengths 6 or 8 bytes.
1109
1110 2019-06-04  Pedro Alves  <palves@redhat.com>
1111
1112         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1113
1114         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1115         * breakpoint.c (condition_completer): Likewise.
1116         * cli/cli-dump.c (scan_expression): Likewise.
1117         * common/filestuff.c (mkdir_recursive): Likewise.
1118         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1119         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1120         (gdb_abspath): Likewise.
1121         * compile/compile-cplus-types.c
1122         (compile_cplus_instance::decl_name): Likewise.
1123         * completer.c (complete_explicit_location):
1124         (signal_completer, reg_or_group_completer_1): Likewise.
1125         * cp-support.c (cp_remove_params_if_any): Likewise.
1126         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1127         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1128         * infcmd.c (strip_bg_char): Likewise.
1129         * linespec.c (copy_token_string): Likewise.
1130         * mi/mi-main.c (output_cores): Likewise.
1131         * psymtab.c (psymtab_search_name):
1132         * symfile.c (test_set_ext_lang_command): Likewise.
1133         * target.c (target_fileio_read_stralloc): Likewise.
1134         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1135         * value.c (complete_internalvar): Likewise.
1136
1137 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1138
1139         Add objfile property to gdb.Type.
1140         * NEWS: Mention Python API addition.
1141         * python/py-type.c (typy_get_objfile): New method.
1142
1143 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1144
1145         * NEWS: Mention the new set|show style [title|highlight].
1146         Mention changes to "show style", "help" and "apropos".
1147
1148 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1149
1150         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1151         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1152         instead of print_help_for_command.
1153         (print_doc_of_command): New function.
1154         (help_list): Add 'apropos -v word' suggestion.
1155         (print_help_for_command): Style the command name using title style.
1156         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1157         (_initialize_cli_cmds): Describe -v in apropos_command help.
1158
1159 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1160
1161         * cli/cli-style.h (cli_style_option): Add name in constructor,
1162         add m_name class member, add constructor with intensity,
1163         add name class function.
1164         (cli_style_option::add_setshow_commands): Remove name argument.
1165         (highlight_style, title_style): New styles.
1166         * cli/cli-style.c (do_show): New function that shows a style
1167         characteristic styling the style name with itself.
1168         (set_style_name): New function.
1169         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1170         Update all callers according to the changes in cli/cli-style.h.
1171         * utils.h (fputs_highlighted): New function.
1172         * utils.c (fputs_highlighted): Likewise.
1173
1174 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1175
1176         * NEWS: Mention new pipe command and new convenience variables.
1177
1178 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1179
1180         * cli/cli-cmds.c (pipe_command): New function.
1181         (_initialize_cli_cmds): Call add_com for pipe_command.
1182         Define | as an alias for pipe.
1183         (exit_status_set_internal_vars): New function.
1184         (shell_escape): Call exit_status_set_internal_vars.
1185         cli/cli-decode.c (find_command_name_length): Recognize | as
1186         a single character command.
1187
1188 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1189
1190         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1191         top.c (execute_command_to_ui_file): New function, mostly a copy
1192         of execute_command_to_string.
1193         (execute_command_to_string): Implement by calling
1194         execute_command_to_ui_file.
1195
1196 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1197
1198         * top.h (saved_command_line): Remove declaration.
1199         * top.c (previous_saved_command_line, previous_repeat_arguments):
1200         New variables.
1201         (saved_command_line): Make static, define together with other
1202         'repeat variables'.
1203         (dont_repeat): Clear repeat_arguments.
1204         (repeat_previous, get_saved_command_line, save_command_line):
1205         New functions.
1206         (gdb_init): Initialize saved_command_line
1207         and previous_saved_command_line.
1208         * main.c (captured_main_1): Remove saved_command_line initialization.
1209         * event-top.c (handle_line_of_input): Update to use
1210         the new 'repeat' related functions instead of direct access to
1211         saved_command_line.
1212         * command.h (repeat_previous, get_saved_command_line,
1213         save_command_line): New declarations.
1214         (dont_repeat): Add comment.
1215
1216 2019-05-30  Tom Tromey  <tromey@adacore.com>
1217
1218         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1219         Fix comment.
1220         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1221
1222 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1223
1224         PR cli/24587
1225         * completer.c (complete): Initialize variable word.
1226
1227 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1228
1229         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1230         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1231         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1232         'body' is NULL to the outter 'if', protecting the '!is_define'
1233         situation as well.
1234
1235 2019-05-29  Tom Tromey  <tromey@adacore.com>
1236
1237         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1238         (dwarf_unknown): New function.
1239         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1240         (dwarf_type_encoding_name): Use dwarf_unknown.
1241
1242 2019-05-29  Tom Tromey  <tromey@adacore.com>
1243
1244         PR c++/20020:
1245         * cp-valprint.c (cp_print_value_fields): Call
1246         cp_print_static_field inside "try".
1247
1248 2019-05-29  Tom Tromey  <tromey@adacore.com>
1249
1250         * inflow.c (struct terminal_info): Add default operator=.
1251         * configure: Rebuild.
1252         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1253         -Wdeprecated-copy-dtor, -Wredundant-move.
1254
1255 2019-05-29  Tom Tromey  <tromey@adacore.com>
1256
1257         * NEWS: Add entry.
1258         * infcmd.c (print_return_value_1): Handle finish_print
1259         option.
1260         (show_print_finish): New function.
1261         (_initialize_infcmd): Add "set/show print finish" commands.
1262         * valprint.c (user_print_options): Initialize new member.
1263         * valprint.h (struct value_print_options) <finish_print>: New
1264         member.
1265
1266 2019-05-28  Tom Tromey  <tromey@adacore.com>
1267
1268         * ada-lang.c (ada_remove_Xbn_suffix)
1269         (find_old_style_renaming_symbol)
1270         (parse_old_style_renaming): Remove.
1271         (ada_find_renaming_symbol): Don't call
1272         find_old_style_renaming_symbol.
1273         (ada_is_renaming_symbol): Rename from
1274         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1275         bool.  Now static.
1276         (ada_read_var_value): Update and simplify.
1277         * ada-exp.y (write_var_or_type): Remove old code.
1278
1279 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1280
1281         * event-top.c: Remove include comment.
1282         * inflow.c (class scoped_ignore_sigttou): Move from here...
1283         * inflow.h (class scoped_ignore_sigttou): ...to here.
1284         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1285         * top.c:  Remove include comment.
1286
1287 2019-05-27  Tom Tromey  <tom@tromey.com>
1288
1289         * NEWS: Fix typo.
1290
1291 2019-05-22  Tom Tromey  <tromey@adacore.com>
1292
1293         * target.c (target_follow_exec): Constify parameter.
1294         * target-delegates.c: Rebuild.
1295         * remote.c (remote_target::follow_exec): Constify parameter.
1296         * infrun.c (follow_exec): Constify parameter.
1297         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1298         (target_follow_exec): Likewise.
1299
1300 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1301
1302         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1303         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1304
1305 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1306
1307         * NEWS: Add debugredirect and testsuite sections.
1308
1309 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1310
1311         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1312         target descriptions using exclusively floating point register name
1313         aliases.
1314
1315 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1316
1317         PR gdb/18644:
1318         * f-lang.c (build_fortran_types): Handle the case where
1319         gdbarch_floatformat_for_type returns a nullptr.
1320
1321 2019-05-21  Tom de Vries  <tdevries@suse.de>
1322
1323         PR cli/24587
1324         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1325
1326 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1327
1328         PR gdb/18644:
1329         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1330         16-byte floats.
1331         * i386-tdep.c (i386_floatformat_for_type): Use
1332         floatformats_ia64_quad for the 16-byte floating point component
1333         within a fortran 32-byte complex number.
1334
1335 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1336
1337         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1338         delete default constructor.
1339         (find_partial_die): Update to return const struct.
1340         (partial_die_parent_scope): Move variable declaration into scope
1341         of its use and change its type to auto.
1342         (guess_partial_die_structure_name): Likewise.
1343         (partial_die_info::fixup): Likewise.
1344
1345 2019-05-17  Tom Tromey  <tromey@adacore.com>
1346
1347         * source.c (find_and_open_source): Remove cast.
1348
1349 2019-05-17  Tom Tromey  <tromey@adacore.com>
1350
1351         * annotate.c (annotate_source): Make "filename" const.
1352         * annotate.h (annotate_source): Use const.
1353
1354 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1355
1356         * disasm.c (set_disassembler_options): Send errors to stderr.
1357
1358 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1359
1360         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1361         (cli_interp_base::set_logging): Check debug_redirect.
1362         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1363         * cli/cli-logging.c (debug_redirect): Add static variable.
1364         (pop_output_files): Add default param.
1365         (handle_redirections): Print debug setting.
1366         (show_logging_command): Likewise.
1367         (_initialize_cli_logging): Add debugredirect command.
1368         * interps.c (current_interp_set_logging): Add debug_redirect
1369         parameter.
1370         * interps.h (set_logging): Add debug_redirect parameter.
1371         (current_interp_set_logging): Likewise.
1372         * mi/mi-common.h: Likewise.
1373         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1374
1375 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1376             Tom Tromey  <tromey@adacore.com>
1377
1378         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1379         directly.
1380         * cli/cli-interp.h (make_logging_output): Remove declaration.
1381         * cli/cli-logging.c (make_logging_output): Remove function.
1382         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1383         directly.
1384         * ui-file.c (tee_file::tee_file): Remove bools.
1385         (tee_file::~tee_file): Remove deletes.
1386         * ui-file.h (tee_file): Remove bools.
1387
1388 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1389
1390         * mi/mi-cmds.h (mi_cmd_complete): New function.
1391         * mi/mi-main.c (mi_cmd_complete): Likewise.
1392         * mi/mi-cmds.c: Define new MI command -complete.
1393         * NEWS: Mention new -complete command.
1394
1395 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1396
1397         * completer.h (complete): New function.
1398         * completer.c (complete): Likewise.
1399         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1400         function defined in completer.h.
1401
1402 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1403
1404         * MAINTAINERS (Write After Approval): Add myself.
1405
1406 2019-05-17  Tom de Vries  <tdevries@suse.de>
1407
1408         PR gdb/24094
1409         * dwarf2read.c (struct cu_partial_die_info): New struct.
1410         (find_partial_die): Return cu_partial_die_info.
1411         (partial_die_parent_scope, guess_partial_die_structure_name)
1412         (partial_die_info::fixup): Handle new return type of find_partial_die.
1413
1414 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1415
1416         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1417         "std::string", simplifying the algorithm.
1418
1419 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1420
1421         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1422         (stap_static_probe_ops::get_probes): Likewise.
1423
1424 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1425
1426         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1427         '-')" and "else if".
1428         (stap_parse_single_operand): Join checks for
1429         "gdbarch_stap_parse_special_token_p" and
1430         "gdbarch_stap_parse_special_token" in the same "if" statement.
1431         Invert check when verifying for operation on register
1432         displacement.
1433
1434 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1435
1436         * stap-probe.c (stap_get_opcode): Update comment.
1437         (stap_get_expected_argument_type): Likewise.
1438         (handle_stap_probe): Likewise.
1439
1440 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1441
1442         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1443         return type to 'bool'.  Adjust comment.  Use 'bool' when
1444         appropriate.
1445         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1446         * stap-probe.c (stap_parse_argument_1): Likewise.
1447         (stap_is_operator): Likewise.
1448         (stap_is_generic_prefix): Likewise.
1449         (stap_is_register_prefix): Likewise.
1450         (stap_is_register_indirection_prefix): Likewise.
1451         (stap_is_integer_prefix): Likewise.
1452         (stap_generic_check_suffix): Likewise.
1453         (stap_check_integer_suffix): Likewise.
1454         (stap_check_register_suffix): Likewise.
1455         (stap_check_register_indirection_suffix): Likewise.
1456         (stap_parse_register_operand): Likewise.
1457         (stap_parse_single_operand): Likewise.
1458         (stap_parse_argument_1): Likewise.
1459         (stap_probe::get_argument_count): Likewise.
1460         (stap_is_operator): Likewise.
1461
1462 2019-05-16  Tom Tromey  <tromey@adacore.com>
1463
1464         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1465         keyword to foreach.
1466
1467 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1468
1469         * linux-thread-db.c (try_thread_db_load_1): Change return type
1470         to bool.
1471         (try_thread_db_load): Likewise.
1472         (try_thread_db_load_from_pdir_1): Likewise.
1473         (try_thread_db_load_from_pdir): Likewise.
1474         (try_thread_db_load_from_sdir): Likewise.
1475         (try_thread_db_load_from_dir): Likewise.
1476         (thread_db_load_search): Likewise.
1477         (has_libpthread): Likewise.
1478         (thread_db_load): Likewise.
1479
1480 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1481
1482         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1483         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1484         NULL, and complain/return if that's the case.
1485
1486 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1487
1488         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1489         (advance, posn, abstract_read_memory): New functions.
1490         [struct mem_read_abstraction]: New struct.
1491         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1492
1493 2019-05-14  Tom Tromey  <tromey@adacore.com>
1494
1495         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1496         value is not lval_memory.
1497
1498 2019-05-14  Tom Tromey  <tromey@adacore.com>
1499
1500         * solib.c (info_sharedlibrary_command): Style the file name.
1501
1502 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1503
1504         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1505         (aarch64_vnv_type): Likewise.
1506         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1507         * common/tdesc.c: Likewise.
1508         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1509         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1510         * features/aarch64-fpu.xml: Add ieee half view.
1511         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1512         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1513         * gdbtypes.h (struct builtin_type): Likewise.
1514         (struct objfile_type): Likewise.
1515
1516 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1517
1518         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1519         typo.
1520         * location.h (string_to_event_location): Likewise.
1521
1522 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1523
1524         GDB 8.3 released.
1525
1526 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1527
1528         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1529         New variable declaration.
1530         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1531         New variable.
1532         (print_one_breakpoint): Use ui_out::test_flags and new global
1533         variable to compute use_fixed_output.
1534         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1535         Remove.
1536         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1537         (mi_multi_location_breakpoint_output_fixed): Remove.
1538         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1539         new variable.
1540         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1541         fix_multi_location_breakpoint_output flag if version >= 3.
1542         * ui-out.h (enum ui_out_flag)
1543         <fix_multi_location_breakpoint_output>: New enumerator.
1544
1545 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1546
1547         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1548
1549 2019-05-10  Tom Tromey  <tromey@adacore.com>
1550
1551         * ada-lang.c (catch_ada_completer): New function.
1552         (_initialize_ada_language): Use it.
1553
1554 2019-05-10  Tom Tromey  <tromey@adacore.com>
1555
1556         * thread.c (print_thread_info): Make "requested_threads" const.
1557         * gdbthread.h (print_thread_info): Make "requested_threads"
1558         const.
1559         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1560         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1561
1562 2019-05-08  Tom Tromey  <tom@tromey.com>
1563
1564         * gdbtypes.c (objfile_type_data): Change type.
1565         (objfile_type, _initialize_gdbtypes): Update.
1566
1567 2019-05-08  Tom Tromey  <tom@tromey.com>
1568
1569         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1570         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1571         (_initialize_dwarf2_frame): Update.
1572
1573 2019-05-08  Tom Tromey  <tom@tromey.com>
1574
1575         * objc-lang.c (objc_objfile_data): Change type.
1576         (find_methods): Update.
1577         (_initialize_objc_lang): Remove.
1578
1579 2019-05-08  Tom Tromey  <tom@tromey.com>
1580
1581         * stabsread.c (rs6000_builtin_type_data): Change type.
1582         (rs6000_builtin_type, _initialize_stabsread): Update.
1583
1584 2019-05-08  Tom Tromey  <tom@tromey.com>
1585
1586         * mips-tdep.c (mips_pdr_data): Remove.
1587         (_initialize_mips_tdep): Update.
1588
1589 2019-05-08  Tom Tromey  <tom@tromey.com>
1590
1591         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1592         (hppa_init_objfile_priv_data, read_unwind_info)
1593         (find_unwind_entry, _initialize_hppa_tdep): Update.
1594
1595 2019-05-08  Tom Tromey  <tom@tromey.com>
1596
1597         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1598         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1599         on obstack.
1600         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1601
1602 2019-05-08  Tom Tromey  <tom@tromey.com>
1603
1604         * mdebugread.c (basic_type_data): Change type.
1605         (basic_type, _initialize_mdebugread): Update.
1606
1607 2019-05-08  Tom Tromey  <tom@tromey.com>
1608
1609         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1610
1611 2019-05-08  Tom Tromey  <tom@tromey.com>
1612
1613         * nto-tdep.c (nto_inferior_data_reg): Change type.
1614         (nto_inferior_data): Update.
1615         (nto_inferior_data_cleanup, nto_new_inferior_data)
1616         (_initialize_nto_tdep): Remove.
1617         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1618
1619 2019-05-08  Tom Tromey  <tom@tromey.com>
1620
1621         * ada-lang.c (struct ada_inferior_data): Add initializers.
1622         (ada_inferior_data): Change type.
1623         (ada_inferior_data_cleanup): Remove.
1624         (get_ada_inferior_data, ada_inferior_exit)
1625         (struct ada_pspace_data): Add initializers, destructor.
1626         (ada_pspace_data_handle): Change type.
1627         (get_ada_pspace_data): Update.
1628         (ada_pspace_data_cleanup): Remove.
1629
1630 2019-05-08  Tom Tromey  <tom@tromey.com>
1631
1632         * coffread.c (struct coff_symfile_info): Add initializers.
1633         (coff_objfile_data_key): Move lower.  Change type.
1634         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1635         Update.
1636         (coff_free_info): Remove.
1637
1638 2019-05-08  Tom Tromey  <tom@tromey.com>
1639
1640         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1641         (fbsd_pspace_data_handle): Move lower.  Change type.
1642         (get_fbsd_pspace_data): Update.
1643         (fbsd_pspace_data_cleanup): Remove.
1644         (_initialize_fbsd_tdep): Update.
1645
1646 2019-05-08  Tom Tromey  <tom@tromey.com>
1647
1648         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1649         (get_ada_tasks_pspace_data): Update.
1650         (ada_tasks_pspace_data_cleanup): Remove.
1651         (_initialize_tasks): Update.
1652         (ada_tasks_inferior_data_handle): Change type.
1653         (get_ada_tasks_inferior_data): Update.
1654         (ada_tasks_inferior_data_cleanup): Remove.
1655         (struct ada_tasks_pspace_data): Add initializers.
1656
1657 2019-05-08  Tom Tromey  <tom@tromey.com>
1658
1659         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1660         * symfile-debug.c (debug_sym_get_probes): Change type.
1661         * stap-probe.c (handle_stap_probe):
1662         (stap_static_probe_ops::get_probes): Change type.
1663         * probe.h (class static_probe_ops) <get_probes>: Change type.
1664         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1665         (parse_probes_in_pspace): Update.
1666         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1667         Update.
1668         (any_static_probe_ops::get_probes): Change type.
1669         * elfread.c (elfread_data): New typedef.
1670         (probe_key): Change type.
1671         (elf_get_probes): Likewise.  Update.
1672         (probe_key_free): Remove.
1673         (_initialize_elfread): Update.
1674         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1675         Change type.
1676         (dtrace_process_dof_probe, dtrace_process_dof)
1677         (dtrace_static_probe_ops::get_probe): Change type.
1678
1679 2019-05-08  Tom Tromey  <tom@tromey.com>
1680
1681         * xcoffread.c (struct xcoff_symfile_info): Rename from
1682         coff_symfile_info.  Add initializers.
1683         (xcoff_objfile_data_key): Move lower.  Change type.
1684         (XCOFF_DATA): Rewrite.
1685         (xcoff_free_info): Remove.
1686         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1687         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1688         (xcoff_initial_scan): Update.
1689
1690 2019-05-08  Tom Tromey  <tom@tromey.com>
1691
1692         * solib-svr4.c (struct svr4_info): Add initializers and
1693         destructor.
1694         <probes_table>: Now an htab_up.
1695         (solib_svr4_pspace_data): Change type.
1696         (free_probes_table): Simplify.
1697         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1698         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1699         (probes_table_remove_objfile_probes, register_solib_event_probe)
1700         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1701         (_initialize_svr4_solib): Update.
1702
1703 2019-05-08  Tom Tromey  <tom@tromey.com>
1704
1705         * remote.c (remote_pspace_data): Change type.
1706         (remote_pspace_data_cleanup): Remove.
1707         (get_remote_exec_file, set_pspace_remote_exec_file)
1708         (_initialize_remote): Update.
1709
1710 2019-05-08  Tom Tromey  <tom@tromey.com>
1711
1712         * breakpoint.c (breakpoint_objfile_key): Change type.
1713         (get_breakpoint_objfile_data): Update.
1714         (free_breakpoint_objfile_data): Remove.
1715         (_initialize_breakpoint): Update.
1716
1717 2019-05-08  Tom Tromey  <tom@tromey.com>
1718
1719         * linux-tdep.c (struct linux_info): Add initializers.
1720         (linux_inferior_data): Move.  Change type.
1721         (invalidate_linux_cache_inf): Update.
1722         (linux_inferior_data_cleanup): Remove.
1723         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1724
1725 2019-05-08  Tom Tromey  <tom@tromey.com>
1726
1727         * auxv.c (auxv_inferior_data): Move.  Change type.
1728         (auxv_inferior_data_cleanup): Remove.
1729         (invalidate_auxv_cache_inf): Rewrite.
1730         (get_auxv_inferior_data, _initialize_auxv): Update.
1731
1732 2019-05-08  Tom Tromey  <tom@tromey.com>
1733
1734         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1735         (symfile_debug_objfile_data_key): Change type.
1736         (symfile_debug_installed, debug_qf_has_symbols)
1737         (debug_qf_find_last_source_symtab)
1738         (debug_qf_forget_cached_source_info)
1739         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1740         (debug_qf_print_stats, debug_qf_dump)
1741         (debug_qf_expand_symtabs_for_function)
1742         (debug_qf_expand_all_symtabs)
1743         (debug_qf_expand_symtabs_with_fullname)
1744         (debug_qf_map_matching_symbols)
1745         (debug_qf_expand_symtabs_matching)
1746         (debug_qf_find_pc_sect_compunit_symtab)
1747         (debug_qf_map_symbol_filenames)
1748         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1749         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1750         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1751         (debug_sym_read_linetable, debug_sym_relocate): Update.
1752         (symfile_debug_free_objfile): Remove.
1753         (install_symfile_debug_logging, _initialize_symfile_debug):
1754         Update.
1755
1756 2019-05-08  Tom Tromey  <tom@tromey.com>
1757
1758         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1759         allocate_on_obstack.
1760         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1761         (get_dwarf2_per_objfile): Update.
1762         (set_dwarf2_per_objfile): Remove.
1763         (dwarf2_has_info, dwarf2_get_section_info): Update.
1764         (dwarf2_free_objfile): Remove.
1765         (_initialize_dwarf2_read): Update.
1766
1767 2019-05-08  Tom Tromey  <tom@tromey.com>
1768
1769         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1770         initializers.
1771         <unsupported_script_warning_printed,
1772         script_not_found_warning_printed>: Now bool.
1773         (auto_load_pspace_data): Change type.
1774         (~auto_load_pspace_info): Rename from
1775         auto_load_pspace_data_cleanup.
1776         (get_auto_load_pspace_data, init_loaded_scripts_info)
1777         (clear_section_scripts, maybe_print_unsupported_script_warning)
1778         (maybe_print_script_not_found_warning, _initialize_auto_load):
1779         Update.
1780
1781 2019-05-08  Tom Tromey  <tom@tromey.com>
1782
1783         * objfiles.c (objfile_pspace_info): Add destructor and
1784         initializers.
1785         (objfiles_pspace_data): Change type.
1786         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1787         (get_objfile_pspace_data): Update.
1788         (objfiles_bfd_data): Change type.
1789         (get_objfile_bfd_data): Update.
1790         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1791
1792 2019-05-08  Tom Tromey  <tom@tromey.com>
1793
1794         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1795         Change type.
1796         (get_catch_syscall_inferior_data): Update.
1797         (catch_syscall_inferior_data_cleanup): Remove.
1798         (_initialize_break_catch_syscall): Update.
1799
1800 2019-05-08  Tom Tromey  <tom@tromey.com>
1801
1802         * inflow.c (struct terminal_info): Add destructor and
1803         initializers.
1804         (inflow_inferior_data): Change type.
1805         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1806         (get_inflow_inferior_data, inflow_inferior_exit)
1807         (swap_terminal_info, _initialize_inflow): Update.
1808
1809 2019-05-08  Tom Tromey  <tom@tromey.com>
1810
1811         * target-dcache.c (target_dcache_cleanup): Remove.
1812         (target_dcache_aspace_key): Change type.
1813         (target_dcache_init_p, target_dcache_invalidate)
1814         (target_dcache_get, target_dcache_get_or_init)
1815         (_initialize_target_dcache): Update.
1816         * dcache.h (struct dcache_deleter): New.
1817
1818 2019-05-08  Tom Tromey  <tom@tromey.com>
1819
1820         * symtab.c (struct symbol_cache): Add destructor and
1821         initializers.
1822         (symbol_cache_key): Move.  Change type.
1823         (make_symbol_cache, free_symbol_cache): Remove.
1824         (get_symbol_cache): Update.
1825         (symbol_cache_cleanup): Remove.
1826         (ALL_PSPACES, symbol_cache_flush)
1827         (maintenance_print_symbol_cache)
1828         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1829         Update.
1830
1831 2019-05-08  Tom Tromey  <tom@tromey.com>
1832
1833         * symtab.c (struct main_info): Add destructor and initializers.
1834         (main_progspace_key): Move.  Change type.
1835         (get_main_info): Update.
1836         (main_info_cleanup): Remove.
1837         (_initialize_symtab): Update.
1838
1839 2019-05-08  Tom Tromey  <tom@tromey.com>
1840
1841         * registry.h (DECLARE_REGISTRY): Define the _key class.
1842
1843 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1844
1845         * NEWS: Merge two 'New commands' sections.
1846
1847 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1848
1849         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1850         parameter and use Ada language definition instead.
1851         (ada_val_print_ptr): Remove unused language parameter.
1852         (ada_val_print_num): Remove language parameter and use Ada language
1853         definition instead.
1854         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1855         parameter.
1856         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1857         parameter and use Ada language definition instead.
1858         (ada_val_print_1): Update all ada_val_print_xxx calls.
1859         Remove language parameter.
1860         (ada_val_print): Update ada_val_print_1 call.
1861
1862 2019-05-08  Tom Tromey  <tromey@adacore.com>
1863
1864         * remote.c (remote_hw_watchpoint_limit)
1865         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1866         Now static.
1867
1868 2019-05-08  Tom Tromey  <tromey@adacore.com>
1869
1870         * maint.c (_initialize_maint_cmds): Move initialization code to
1871         remote.c.
1872         (watchdog, show_watchdog): Move to remote.c.
1873         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1874         "watchdog" static.
1875         (_initialize_remote): Move initialization code from maint.c.
1876         * defs.h (watchdog): Don't declare.
1877
1878 2019-05-08  Tom Tromey  <tromey@adacore.com>
1879
1880         * tui/tui-interp.c: Include main.h.
1881         * interps.c: Include main.h.
1882         * main.h (interpreter_p): Declare.
1883         * defs.h (interpreter_p): Don't declare.
1884
1885 2019-05-08  Tom Tromey  <tromey@adacore.com>
1886
1887         * dwarf2loc.c: Include dwarf2read.h.
1888         * defs.h (read_unsigned_leb128): Don't declare.
1889         * dwarf2read.h (read_unsigned_leb128): Declare.
1890
1891 2019-05-08  Tom Tromey  <tromey@adacore.com>
1892
1893         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1894         method.
1895
1896 2019-05-08  Tom Tromey  <tromey@adacore.com>
1897
1898         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1899         when no wrap column is set.
1900
1901 2019-05-08  Tom Tromey  <tromey@adacore.com>
1902
1903         * c-lang.c (c_get_string): Handle non-C-style arrays.
1904
1905 2019-05-08  Tom Tromey  <tromey@adacore.com>
1906
1907         * typeprint.c (print_offset_data::update): Print the bit offset,
1908         not the number of bits remaining.
1909
1910 2019-05-08  Tom Tromey  <tromey@adacore.com>
1911
1912         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1913         padding at end of comment.
1914
1915 2019-05-08  Tom Tromey  <tromey@adacore.com>
1916
1917         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1918         Compare main types.
1919
1920 2019-05-06  Tom Tromey  <tom@tromey.com>
1921
1922         * common/scoped_mmap.c: Include common-defs.h.
1923         * common/scoped_mmap.h: Don't include config.h.
1924
1925 2019-05-04  Tom Tromey  <tom@tromey.com>
1926
1927         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1928         (struct aarch64_call_info): Add initializers.
1929         <si>: Now a std::vector.
1930         (pass_on_stack, aarch64_push_dummy_call): Update.
1931
1932 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1933             Tom Tromey  <tom@tromey.com>
1934
1935         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1936         (ppc_threads): Now a std::vector.  Now static.
1937         (hwdebug_find_thread_points_by_tid)
1938         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1939         Update.
1940
1941 2019-05-04  Tom Tromey  <tom@tromey.com>
1942
1943         * arc-tdep.c (arc_tdesc_init): Return bool.
1944
1945 2019-05-04  Tom Tromey  <tom@tromey.com>
1946
1947         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1948         Use gdb_assert_not_reached.
1949
1950 2019-05-04  Tom Tromey  <tom@tromey.com>
1951
1952         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1953         "false".
1954
1955 2019-05-04  Tom Tromey  <tom@tromey.com>
1956
1957         * arc-tdep.c (arc_tdesc_init): Use bool.
1958
1959 2019-05-04  Tom Tromey  <tom@tromey.com>
1960
1961         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1962
1963 2019-05-04  Tom Tromey  <tom@tromey.com>
1964
1965         * cli/cli-cmds.c (valid_command_p): Return bool.
1966
1967 2019-05-04  Tom Tromey  <tom@tromey.com>
1968
1969         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1970         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1971
1972 2019-05-04  Raul Tambre  <raul@tambre.ee>
1973
1974         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1975         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1976         operator for comparison.
1977
1978 2019-05-04  Tom Tromey  <tom@tromey.com>
1979
1980         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1981         (lookup_partial_symbol, print_partial_symbols)
1982         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1983         (psymbol_compare): Update.
1984         (add_psymbol_to_bcache): Clear the entire psymbol.
1985         (maintenance_check_psymtabs): Update.
1986         * psympriv.h (struct partial_symbol): Don't derive from
1987         general_symbol_info.
1988         <obj_section, unrelocated_address, address,
1989         set_unrelocated_address>: Update.
1990         <ginfo>: New member.
1991         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1992         (debug_names::write_psymbols): Update.
1993
1994 2019-05-04  Tom de Vries  <tdevries@suse.de>
1995
1996         * contrib/cc-with-tweaks.sh: Support -n arg.
1997
1998 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1999
2000         * corelow.c (core_target::detach): Ensure frame cache and
2001         register caches are cleared.
2002         inferior.c (exit_inferior_1): Likewise.
2003
2004 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2005             Tom Tromey  <tom@tromey.com>
2006
2007         * dictionary.c (collate_pending_symbols_by_language): Remove
2008         "struct" from foreach.
2009         * symtab.c (lookup_global_symbol_from_objfile)
2010         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2011         foreach.
2012         * ser-tcp.c (net_open): Remove "struct" from foreach.
2013         * objfiles.c (objfile_relocate, objfile_rebase)
2014         (objfile_has_symbols): Remove "struct" from foreach.
2015         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2016         from foreach.
2017         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2018         foreach.
2019         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2020         "struct" from foreach.
2021         * ada-lang.c (create_excep_cond_exprs)
2022         (ada_exception_catchpoint_cond_string): Remove "struct" from
2023         foreach.
2024
2025 2019-05-03  Tom Tromey  <tromey@adacore.com>
2026
2027         * ada-exp.y (convert_char_literal): Check suffix of each
2028         enumerator.
2029
2030 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2031
2032         PR ada/21406:
2033         * ada-exp.y (yywrap): Don't define.
2034         * ada-lex.l (%option): Add noyywrap
2035         (yywrap): Remove.
2036
2037 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2038
2039         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2040         _WIN32_WINNT to the XP level, unless already defined to a higher
2041         level.
2042
2043         * unittests/parse-connection-spec-selftests.c:
2044         * ser-tcp.c:
2045         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2046         override.
2047
2048         * symfile.c (find_separate_debug_file): Remove colon from the
2049         drive spec of DOS/Windows file names of the target, so that the
2050         file name produced from DEBUGDIR and the target's directory will
2051         be valid on DOS/Windows systems.
2052
2053 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2054
2055         * rust-lang.c (val_print_struct): Handle printing structures
2056         containing strings.
2057
2058 2019-05-02  Tom Tromey  <tromey@adacore.com>
2059
2060         * valarith.c (_initialize_valarith): Remove.
2061
2062 2019-05-01  Tom Tromey  <tromey@adacore.com>
2063
2064         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2065         bitfields.
2066
2067 2019-05-01  Tom Tromey  <tromey@adacore.com>
2068
2069         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2070         for big-endian copies.
2071
2072 2019-04-30  Ali Tamur  <tamur@google.com>
2073         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2074         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2075         (read_3_bytes): New function.
2076
2077 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2078
2079         * windows-nat.c (main_thread_id): Delete.
2080         (handle_output_debug_string): Replace main_thread_id by
2081         current_event.dwThreadId.
2082         (fake_create_process): Likewise.
2083         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2084         Do not set main_thread_id.
2085         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2086         current_event.dwThreadId.
2087         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2088
2089 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2090
2091         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2092         Use current_event.dwThreadId instead of main_thread_id.
2093
2094 2019-04-30  Tom Tromey  <tromey@adacore.com>
2095
2096         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2097         (create_excep_cond_exprs): Iterate over program spaces.
2098         (ada_exception_catchpoint_cond_string): Examine all minimal
2099         symbols for exception types.
2100
2101 2019-04-30  Tom Tromey  <tromey@adacore.com>
2102
2103         PR c++/24470:
2104         * dwarf2read.c (process_structure_scope): Handle case where type
2105         has template parameters but no symbol was created.
2106
2107 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2108             Chris January  <chris.january@arm.com>
2109
2110         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2111         qualifier.
2112         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2113
2114 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2115
2116         * f-typeprint.c (f_print_type): Update rules for printing
2117         whitespace.
2118         (f_type_print_varspec_suffix): Likewise.
2119
2120 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2121             Chris January  <chris.january@arm.com>
2122
2123         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2124         function arguments.
2125
2126 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2127
2128         * f-lang.c (build_fortran_types): Change name of void type to
2129         lower case.
2130         * f-typeprint.c (f_type_print_base): Print the name of the void
2131         type, rather than a fixed string.
2132         * f-valprint.c (f_decorations): Use lower case void string.
2133
2134 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2135             Chris January  <chris.january@arm.com>
2136
2137         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2138         types for Fortran.
2139
2140 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2141             Chris January  <chris.january@arm.com>
2142             David Lecomber  <david.lecomber@arm.com>
2143
2144         * f-exp.y (BINOP_INTRINSIC): New token.
2145         (exp): New parser rule handling BINOP_INTRINSIC.
2146         (f77_keywords): Add new builtin procedures.
2147         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2148         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2149         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2150         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2151         (print_unop_subexp_f): New function.
2152         (print_binop_subexp_f): New function.
2153         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2154         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2155         (dump_subexp_body_f): Likewise.
2156         (operator_check_f): Likewise.
2157         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2158         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2159
2160 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2161
2162         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2163         UNOP_KIND.
2164         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2165         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2166         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2167         (operator_length_f): New fuction.
2168         (print_subexp_f): New function.
2169         (op_name_f): New function.
2170         (dump_subexp_body_f): New function.
2171         (operator_check_f): New function.
2172         (exp_descriptor_f): Replace standard expression handling functions
2173         with new functions.
2174         * gdb/fortran-operator.def: New file.
2175         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2176         * gdb/std-operator.def: Remove UNOP_KIND.
2177
2178 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2179
2180         * std-operator.def: Remove unbalanced, stray double quote
2181         character.
2182
2183 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2184             Chris January  <chris.january@arm.com>
2185             Daniel Everett  <daniel.everett@arm.com>
2186             Nick Forrington  <nick.forrington@arm.com>
2187             Richard Bunt  <richard.bunt@arm.com>
2188
2189         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2190         of depth when printing anonymous structs or unions.
2191         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2192         Don't print either the top-level value, or the children if the
2193         max-depth is exceeded.
2194         (ppscm_print_children): When printing the key of a map, allow one
2195         extra level of depth.
2196         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2197         print either the top-level value, or the children if the max-depth
2198         is exceeded.
2199         (print_children): When printing the key of a map, allow one extra
2200         level of depth.
2201         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2202         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2203         (user_print_options): Initialise max_depth field.
2204         (val_print_scalar_or_string_type_p): New function.
2205         (val_print): Check to see if the max depth has been reached.
2206         (val_print_check_max_depth): Define new function.
2207         (show_print_max_depth): New function.
2208         (_initialize_valprint): Add 'print max-depth' option.
2209         * valprint.h (struct value_print_options) <max_depth>: New field.
2210         (val_print_check_max_depth): Declare new function.
2211         * NEWS: Document new feature.
2212
2213 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2214
2215         * ada-lang.c (ada_language_defn): Initialise new field.
2216         * c-lang.c (c_is_string_type_p): New function.
2217         (c_language_defn): Initialise new field.
2218         (cplus_language_defn): Initialise new field.
2219         (asm_language_defn): Initialise new field.
2220         (minimal_language_defn): Initialise new field.
2221         * c-lang.h (c_is_string_type_p): Declare new function.
2222         * d-lang.c (d_language_defn): Initialise new field.
2223         * f-lang.c (f_is_string_type_p): New function.
2224         (f_language_defn): Initialise new field.
2225         * go-lang.c (go_is_string_type_p): New function.
2226         (go_language_defn): Initialise new field.
2227         * language.c (default_is_string_type_p): New function.
2228         (unknown_language_defn): Initialise new field.
2229         (auto_language_defn): Initialise new field.
2230         * language.h (struct language_defn) <la_is_string_type_p>: New
2231         member variable.
2232         (default_is_string_type_p): Declare new function.
2233         * m2-lang.c (m2_language_defn): Initialise new field.
2234         * objc-lang.c (objc_language_defn): Initialise new field.
2235         * opencl-lang.c (opencl_language_defn): Initialise new field.
2236         * p-lang.c (pascal_is_string_type_p): New function.
2237         (pascal_language_defn): Initialise new field.
2238         * rust-lang.c (rust_is_string_type_p): New function.
2239         (rust_language_defn): Initialise new field.
2240
2241 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2242
2243         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2244         New field.
2245         * ada-lang.c (ada_language_defn): Initialise new field.
2246         * c-lang.c (c_language_defn): Likewise.
2247         (cplus_language_defn): Likewise.
2248         (asm_language_defn): Likewise.
2249         (minimal_language_defn): Likewise.
2250         * d-lang.c (d_language_defn): Likewise.
2251         * f-lang.c (f_language_defn): Likewise.
2252         * go-lang.c (go_language_defn): Likewise.
2253         * language.c (unknown_language_defn): Likewise.
2254         (auto_language_defn): Likewise.
2255         * m2-lang.c (m2_language_defn): Likewise.
2256         * objc-lang.c (objc_language_defn): Likewise.
2257         * opencl-lang.c (opencl_language_defn): Likewise.
2258         * p-lang.c (pascal_language_defn): Likewise.
2259         * rust-lang.c (rust_language_defn): Likewise.
2260
2261 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2262
2263         * ada-lang.c (ada_is_character_type): Change return type to bool.
2264         (ada_is_string_type): Likewise.
2265         * ada-lang.h (ada_is_character_type): Update declaration
2266         (ada_is_string_type): Likewise.
2267
2268 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2269
2270         Support style in 'frame|thread apply'
2271
2272         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2273         * record.c (record_start, record_stop): Update callers of
2274         execute_command_to_string with false.
2275         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2276         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2277         methods.
2278         (class string_file): New constructor with term_out parameter.
2279         Override methods term_out and can_emit_style_escape.  New member
2280         term_out.
2281         (class stdio_file): Override can_emit_style_escape.
2282         (class tee_file): Override term_out and can_emit_style_escape.
2283         * utils.h (can_emit_style_escape): Remove.
2284         * utils.c (can_emit_style_escape): Likewise.
2285         Update all callers of can_emit_style_escape (SOMESTREAM) to
2286         SOMESTREAM->can_emit_style_escape.
2287         * source-cache.c (source_cache::get_source_lines): Likewise.
2288         * stack.c (frame_apply_command_count): Call execute_command_to_string
2289         passing the term_out characteristic of the current gdb_stdout.
2290         * thread.c (thr_try_catch_cmd): Likewise.
2291         * top.c (execute_command_to_string): pass term_out parameter
2292         to construct the string_file for the command output.
2293         * ui-file.c (term_cli_styling): New function (most code moved
2294         from utils.c can_emit_style_escape).
2295         (string_file::string_file, string_file::can_emit_style_escape,
2296         stdio_file::can_emit_style_escape, tee_file::term_out,
2297         tee_file::can_emit_style_escape): New functions.
2298
2299 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2300
2301         * NEWS: Mention the new set|show may-call-functions.
2302         * infcall.c (may_call_functions_p): New variable.
2303         (show_may_call_functions_p): New function.
2304         (call_function_by_hand_dummy): Throws an error if not
2305         may-call-functions.
2306         (_initialize_infcall): Call add_setshow_boolean_cmd for
2307         may-call-functions.
2308
2309 2019-04-25  Keith Seitz  <keiths@redhat.com>
2310
2311         PR c++/24367
2312         * cp-support.c (inspect_type): Don't attempt substitutions
2313         of symbol with the same name.
2314
2315 2019-04-25  Tom Tromey  <tromey@adacore.com>
2316
2317         PR gdb/24475:
2318         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2319         static.
2320
2321 2019-04-25  Tom Tromey  <tromey@adacore.com>
2322
2323         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2324         rvalue reference.
2325         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2326         (gdb_xml_parser::parse): Use std::move.
2327         * python/python-internal.h (gdbpy_convert_exception): Take a const
2328         reference.
2329         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2330         std::move.
2331         * python/py-utils.c (gdbpy_convert_exception): Take a const
2332         reference.
2333         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2334         Use std::move.
2335         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2336         Use std::move.
2337         * mi/mi-main.c (mi_print_exception): Take a const reference.
2338         * main.c (handle_command_errors): Take a const reference.
2339         * linespec.c (parse_linespec): Use std::move.
2340         * infcall.c (run_inferior_call): Use std::move.
2341         (call_function_by_hand_dummy): Use std::move.
2342         * exec.c (try_open_exec_file): Use std::move.
2343         * exceptions.h (exception_print, exception_fprintf)
2344         (exception_print_same): Update.
2345         * exceptions.c (print_exception, exception_print)
2346         (exception_fprintf, exception_print_same): Change parameters to
2347         const reference.
2348         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2349         * common/new-op.c: Use std::move.
2350         * common/common-exceptions.h (struct gdb_exception): Add move
2351         constructor.
2352         (struct gdb_exception_error, struct gdb_exception_quit, struct
2353         gdb_quit_bad_alloc): Change constructor to move constructor.
2354         (throw_exception): Change parameter to rvalue reference.
2355         * common/common-exceptions.c (throw_exception): Take rvalue
2356         reference.
2357         * cli/cli-interp.c (safe_execute_command): Use std::move.
2358         * breakpoint.c (insert_bp_location, location_to_sals): Use
2359         std::move.
2360
2361 2019-04-25  Tom Tromey  <tromey@adacore.com>
2362
2363         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2364         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2365         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2366         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2367         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2368         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2369         guile/scm-value.c: Use unpack.
2370         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2371         gdbscm_gdb_exception.
2372         (gdbscm_throw_gdb_exception): Likewise.
2373         (struct gdbscm_gdb_exception): New.
2374         (unpack): New function.
2375         (gdbscm_wrap): Use unpack.
2376
2377 2019-04-25  Tom Tromey  <tromey@adacore.com>
2378
2379         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2380         (gdb_rl_callback_handler): Use std::move.
2381         * common/common-exceptions.h (struct gdb_exception): Add move
2382         assignment operator.
2383         (throw_exception_sjlj): Change "exception" to const reference.
2384         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2385         (throw_exception_sjlj): Change "exception" to const reference.
2386
2387 2019-04-25  Tom Tromey  <tromey@adacore.com>
2388
2389         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2390         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2391         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2392         Update.
2393         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2394         Update.
2395         * mi/mi-interp.c (mi_interp::exec): Update.
2396         * linespec.c (parse_linespec): Update.
2397         * infcall.c (run_inferior_call): Update.
2398         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2399         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2400         (gdbscm_lookup_global_symbol): Update.
2401         * guile/scm-param.c (gdbscm_parameter_value): Update.
2402         * guile/scm-frame.c (gdbscm_frame_read_register)
2403         (gdbscm_frame_read_var): Update.
2404         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2405         * exec.c (try_open_exec_file): Update.
2406         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2407         (gdb_rl_callback_handler): Update.
2408         * common/common-exceptions.h (exception_none): Don't declare.
2409         * common/common-exceptions.c (exception_none): Don't define.
2410         (struct catcher) <exception>: Update.
2411         * cli/cli-interp.c (safe_execute_command): Update.
2412         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2413
2414 2019-04-25  Ali Tamur  <tamur@google.com>
2415
2416         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2417         (read_attribute_value): Likewise.
2418         (dwarf2_read_addr_index): Update comment.
2419         (read_str_index): Add DW_FORM_strx.
2420         (dwarf2_string_attr): Likewise.
2421         (dwarf2_const_value_attr): Likewise.
2422         (dump_die_shallow): Likewise.
2423         (dwarf2_fetch_constant_bytes): Likewise.
2424         (skip_form_bytes): Likewise.
2425         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2426
2427 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2428
2429         PR corefiles/11608
2430         PR corefiles/18187
2431         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2432         OFFSET.  Verify if current mapping contains an ELF header.
2433         (linux_find_memory_regions_full): Adjust call to
2434         dump_mapping_p.
2435
2436 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2437             Kang Li <kanglictf@gmail.com>
2438
2439         PR gdb/21600
2440
2441         * dwarf2-frame.c (read_initial_length): Be consistent about using
2442         unsigned representation of length.
2443         (decode_frame_entry_1): Likewise.  Check for wraparound of
2444         end pointer as well as buffer overflow.
2445
2446 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2447
2448         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2449         "vq".
2450
2451 2019-04-24  Tom Tromey  <tromey@adacore.com>
2452
2453         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2454
2455 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2456
2457         * s12z-tdep.c (s12z_unwind_pc): Delete.
2458         (s12z_unwind_sp): Delete.
2459         (s12z_gdbarch_init): Don't register deleted functions with
2460         gdbarch.
2461
2462 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2463
2464         * rl78-tdep.c (rl78_unwind_sp): Delete.
2465         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2466
2467 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2468
2469         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2470         (xstormy16_unwind_pc): Delete.
2471         (xstormy16_dummy_id): Delete.
2472         (xstormy16_gdbarch_init): Don't register deleted functions with
2473         gdbarch.
2474
2475 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2476
2477         * vax-tdep.c (vax_unwind_pc): Delete.
2478         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2479
2480 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2481
2482         * v850-tdep.c (v850_unwind_sp): Delete.
2483         (v850_unwind_pc): Delete.
2484         (v850_dummy_id): Delete.
2485         (v850_gdbarch_init): Don't register deleted functions with
2486         gdbarch.
2487
2488 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2489
2490         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2491         (tilegx_unwind_pc): Delete.
2492         (tilegx_unwind_dummy_id): Delete.
2493         (tilegx_gdbarch_init): Don't register deleted functions with
2494         gdbarch.
2495
2496 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2497
2498         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2499         (tic6x_dummy_id): Delete.
2500         (tic6x_gdbarch_init): Don't register deleted functions with
2501         gdbarch.
2502
2503 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2504
2505         * sparc-tdep.c (sparc_unwind_pc): Delete.
2506         (sparc32_gdbarch_init): Don't register deleted function with
2507         gdbarch.
2508
2509 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2510
2511         * sh-tdep.c (sh_unwind_sp): Delete.
2512         (sh_unwind_pc): Delete.
2513         (sh_dummy_id): Delete.
2514         (sh_gdbarch_init): Don't register deleted functions with
2515         gdbarch.
2516
2517 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2518
2519         * score-tdep.c (score_unwind_sp): Delete.
2520         (score_unwind_pc): Delete.
2521         (score_dummy_id): Delete.
2522         (score_gdbarch_init): Don't register deleted functions with
2523         gdbarch.
2524
2525 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2526
2527         * rx-tdep.c (rx_unwind_pc): Delete.
2528         (rx_unwind_sp): Delete.
2529         (rx_dummy_id): Delete.
2530         (rx_gdbarch_init): Don't register deleted functions with
2531         gdbarch.  Update comment.
2532
2533 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2534
2535         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2536         (rs6000_dummy_id): Delete.
2537         (rs6000_gdbarch_init): Don't register deleted functions with
2538         gdbarch.
2539
2540 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2541
2542         * or1k-tdep.c (or1k_dummy_id): Delete.
2543         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2544
2545 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2546
2547         * nios2-tdep.c (nios2_dummy_id): Delete.
2548         (nios2_unwind_sp): Delete.
2549         (nios2_gdbarch_init): Don't register deleted functions with
2550         gdbarch.
2551
2552 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2553
2554         * nds32-tdep.c (nds32_dummy_id): Delete.
2555         (nds32_unwind_pc): Delete.
2556         (nds32_unwind_sp): Delete.
2557         (nds32_gdbarch_init): Don't register deleted functions with
2558         gdbarch.
2559
2560 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2561
2562         * msp430-tdep.c (msp430_unwind_pc): Delete.
2563         (msp430_unwind_sp): Delete.
2564         (msp430_dummy_id): Delete.
2565         (msp430_gdbarch_init): Don't register deleted functions with
2566         gdbarch.
2567
2568 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2569
2570         * moxie-tdep.c (moxie_unwind_sp): Delete.
2571         (moxie_unwind_pc): Delete.
2572         (moxie_dummy_id): Delete.
2573         (moxie_gdbarch_init): Don't register deleted functions with
2574         gdbarch.
2575
2576 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2577
2578         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2579         (mn10300_unwind_pc): Delete.
2580         (mn10300_unwind_sp): Delete.
2581         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2582         mn10300_unwind_sp.
2583         (mn10300_frame_unwind_init): Don't register deleted functions with
2584         gdbarch.
2585
2586 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2587
2588         * mep-tdep.c (mep_unwind_pc): Delete.
2589         (mep_unwind_sp): Delete.
2590         (mep_dummy_id): Delete.
2591         (mep_gdbarch_init): Don't register deleted functions with
2592         gdbarch.
2593
2594 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2595
2596         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2597         (m68hc11_unwind_sp): Delete.
2598         (m68hc11_gdbarch_init): Don't register deleted functions with
2599         gdbarch.
2600
2601 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2602
2603         * m32r-tdep.c (m32r_unwind_sp): Delete.
2604         (m32r_unwind_pc): Delete.
2605         (m32r_dummy_id): Delete.
2606         (m32r_gdbarch_init): Don't register deleted functions with
2607         gdbarch.
2608
2609 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2610
2611         * m32c-tdep.c (m32c_unwind_pc): Delete.
2612         (m32c_unwind_sp): Delete.
2613         (m32c_dummy_id): Delete.
2614         (m32c_gdbarch_init): Don't register deleted functions with
2615         gdbarch.
2616
2617 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2618
2619         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2620         (lm32_unwind_pc): Delete.
2621         (lm32_dummy_id): Delete.
2622         (lm32_gdbarch_init): Don't register deleted functions with
2623         gdbarch.
2624
2625 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2626
2627         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2628         (iq2000_unwind_pc): Delete.
2629         (iq2000_dummy_id): Delete.
2630         (iq2000_gdbarch_init): Don't register deleted functions with
2631         gdbarch.
2632
2633 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2634
2635         * nds32-tdep.c (nds32_type_align): Delete.
2636         (nds32_push_dummy_call): Use type_align instead.
2637
2638 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2639
2640         * arm-tdep.c (arm_type_align): Only handle vector override case.
2641         (arm_push_dummy_call): Use type_align.
2642         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2643
2644 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2645
2646         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2647         case.
2648         (pass_on_stack): Use type_align.
2649         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2650         function.
2651
2652 2019-04-23  Tom Tromey  <tromey@adacore.com>
2653
2654         * dwarf2read.c (line_header::file_name_at): Remove unused
2655         overload.
2656
2657 2019-04-23  Tom de Vries  <tdevries@suse.de>
2658
2659         PR gdb/24438
2660         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2661         invocation.
2662
2663
2664 2019-03-27  Ali Tamur  <tamur@google.com>
2665
2666         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2667         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2668         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2669         (dwarf_expr_context::get_addr_index): Likewise
2670         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2671         (symbol_needs_eval_context::get_addr_index): Likewise
2672         (disassemble_dwarf_expression): Add DW_OP_addrx
2673         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2674         (read_cutu_die_from_dwo): Update comment
2675         (skip_one_die): Add DW_FORM_addrx
2676         (read_attribute_value): Likewise
2677         (var_decode_location): Add DW_OP_addrx
2678         (dwarf2_const_value_attr): Add DW_FORM_addrx
2679         (dump_die_shallow): Likewise
2680         (dwarf2_fetch_constant_bytes): Likewise
2681         (decode_locdesc): Add DW_OP_addrx
2682         (skip_form_bytes): Add DW_FORM_addrx
2683
2684 2019-04-22  Ali Tamur  <tamur@google.com>
2685
2686         * MAINTAINERS (Write After Approval): Add self.
2687
2688 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2689
2690         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2691         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2692         (open_symbol_file_object): Likewise.
2693         (svr4_default_sos): Add info parameter.
2694         (svr4_read_so_list): Likewise.
2695         (svr4_current_sos_direct): Adjust functions calls to pass down
2696         info.
2697         (svr4_current_sos_1): Add info parameter.
2698         (svr4_current_sos): Call get_svr4_info, pass info down to
2699         svr4_current_sos_1.
2700         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2701         get_svr4_info.
2702         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2703         get_svr4_info.
2704         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2705         to get_svr4_info.
2706         (probes_table_remove_objfile_probes): Likewise.
2707         (register_solib_event_probe): Add info parameter.
2708         (solist_update_incremental): Pass info parameter down to
2709         svr4_read_so_list.
2710         (disable_probes_interface): Add info parameter.
2711         (svr4_handle_solib_event): Pass current_program_space to
2712         get_svr4_info.  Adjust disable_probes_interface cleanup.
2713         (svr4_create_probe_breakpoints): Add info parameter, pass it
2714         down to register_solib_event_probe.
2715         (svr4_create_solib_event_breakpoints): Add info parameter,
2716         pass it down to svr4_create_probe_breakpoints.
2717         (enable_break): Pass info down to
2718         svr4_create_solib_event_breakpoints.
2719         (svr4_solib_create_inferior_hook): Pass current_program_space to
2720         get_svr4_info.
2721         (svr4_clear_solib): Likewise.
2722
2723 2019-04-22  Pedro Alves  <palves@redhat.com>
2724
2725         * solib-svr4.c (svr4_free_objfile_observer): New.
2726         (probe_and_action::objfile): New field.
2727         (probes_table_htab_remove_objfile_probes)
2728         (probes_table_remove_objfile_probes): New functions.
2729         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2730         in the new probe_and_action.  Don't store the probe in 'lookup'.
2731         (svr4_create_probe_breakpoints): Pass objfile to
2732         register_solib_event_probe.
2733         (_initialize_svr4_solib): Register a free_objfile observer.
2734
2735 2019-04-19  Tom Tromey  <tom@tromey.com>
2736
2737         * common/queue.h: Remove.
2738
2739 2019-04-19  Tom Tromey  <tom@tromey.com>
2740
2741         * event-loop.c: Don't include "common/queue.h".
2742
2743 2019-04-19  Tom Tromey  <tom@tromey.com>
2744
2745         * remote.c (remote_target): Use delete.
2746         * remote-notif.h: Include <list>, not "common/queue.h".
2747         (notif_client_p): Remove typedef.
2748         (remote_notif_state): Add constructor, destructor, initializer.
2749         <notif_queue>: Now a std::list.
2750         (remote_notif_state_xfree): Don't declare.
2751         * remote-notif.c (remote_notif_process, handle_notification)
2752         (remote_notif_state_allocate): Update.
2753         (~remote_notif_state): Rename from remote_notif_state_xfree.
2754
2755 2019-04-19  Tom Tromey  <tom@tromey.com>
2756
2757         * symfile.c (reread_symbols): Update.
2758         * objfiles.c (objfile_register_static_link)
2759         (objfile_lookup_static_link): Update
2760         (~objfile) Don't delete static_links.
2761         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2762
2763 2019-04-19  Tom Tromey  <tom@tromey.com>
2764
2765         * type-stack.h (struct type_stack) <insert>: Constify string.
2766         * type-stack.c (type_stack::insert): Constify string.
2767         * gdbtypes.h (lookup_template_type): Update.
2768         (address_space_name_to_int): Update.
2769         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2770         const.
2771         (lookup_template_type): Make name const.
2772         * c-exp.y: Update rules.
2773         (lex_one_token, classify_name, classify_inner_name)
2774         (c_print_token): Update.
2775         * p-exp.y: Update rules.
2776         (yylex): Update.
2777         * f-exp.y: Update rules.
2778         (yylex): Update.
2779         * d-exp.y: Update rules.
2780         (lex_one_token, classify_name, classify_inner_name): Update.
2781         * parse.c (write_dollar_variable, copy_name): Return std::string.
2782         * parser-defs.h (copy_name): Change return type.
2783         * m2-exp.y: Update rules.
2784         (yylex): Update.
2785         * go-exp.y (lex_one_token): Update.
2786         Update rules.
2787         (classify_unsafe_function, classify_packaged_name)
2788         (classify_name, yylex): Update.
2789
2790 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2791
2792         * configure.ac: add --enable-source-highlight switch.
2793         * configure: Regenerate.
2794         * top.c (print_gdb_version): plumb --enable-source-highlight
2795         status to "show configuration".
2796
2797 2019-04-19  Tom Tromey  <tromey@adacore.com>
2798
2799         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2800         Check ADA_TYPE_P.
2801         (empty_record, ada_template_to_fixed_record_type_1)
2802         (template_to_static_fixed_type)
2803         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2804         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2805         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2806         macros.
2807
2808 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2809
2810         PR symtab/24423:
2811         * source.c (print_source_lines_base): Advance "iter" when a
2812         control character is seen.
2813
2814 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2815
2816         * inferior.h (struct infcall_suspend_state_deleter):
2817         Catch exception in destructor to avoid crash.
2818
2819 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2820
2821         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2822         close to the add_com "shell".
2823
2824 2019-04-18  Tom Tromey  <tromey@adacore.com>
2825
2826         * process-stratum-target.h (class process_stratum_target)
2827         <stratum>: Add "final".
2828
2829 2019-04-17  Tom Tromey  <tromey@adacore.com>
2830
2831         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2832         against nullptr before use.
2833
2834 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2835
2836         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2837
2838 2019-04-17  Jim Wilson  <jimw@sifive.com>
2839             Andrew Burgess  <andrew.burgess@embecosm.com>
2840
2841         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2842         code read might fail, assume 4-byte breakpoint in that case.
2843
2844 2019-04-15  Leszek Swirski  <leszeks@google.com>
2845
2846         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2847         rather than a hand-rolled POD check when checking for forced MEMORY
2848         classification.
2849
2850 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2851
2852         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2853         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2854         function.
2855         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2856         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2857         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2858         declaration.
2859
2860 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2861
2862         * aarch64-linux-nat.c
2863         (aarch64_linux_nat_target::thread_architecture): Add override.
2864         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2865         each VQ.
2866
2867 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2868
2869         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2870
2871 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2872
2873         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2874         target types of size 96-bits, add some additional comments, and
2875         check that the builtin type we found was the correct size.
2876
2877 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2878
2879         * utils.c (prompt_for_continue): Don't restore the styling at the
2880         end, as applied_style has the wrong value.  This fixes styling in
2881         long lists of file names that are interrupted by the "Continue?"
2882         prompt.
2883
2884 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2885
2886         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2887         * c-lang.c (c_language_defn): Likewise.
2888         (cplus_language_defn): Likewise.
2889         (asm_language_defn): Likewise.
2890         (minimal_language_defn): Likewise.
2891         * d-lang.c (d_language_defn): Likewise.
2892         * f-lang.c (f_language_defn): Likewise.
2893         * go-lang.c (go_language_defn): Likewise.
2894         * language.c (unknown_language_defn): Likewise.
2895         (auto_language_defn): Likewise.
2896         * language.h (struct language_defn): Remove la_magic field.
2897         (LANG_MAGIC): Delete.
2898         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2899         * objc-lang.c (objc_language_defn): Likewise.
2900         * opencl-lang.c (opencl_language_defn): Likewise.
2901         * p-lang.c (pascal_language_defn): Likewise.
2902         * rust-lang.c (rust_language_defn): Likewise.
2903
2904 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2905
2906         * riscv-tdep.c (riscv_type_align): New function.
2907         (riscv_type_alignment): Delete.
2908         (riscv_arg_location): Use 'type_align'.
2909         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2910
2911 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2912
2913         * gdbtypes.c (type_align): A struct with no non-static fields also
2914         has alignment of 1.
2915
2916 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2917
2918         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2919         component to 0.
2920         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2921         member.
2922         (riscv_struct_info::analyse): New implementation using new
2923         analyse_inner member function.
2924         (riscv_struct_info::field_offset): New member function.
2925         (riscv_struct_info::m_offsets): New member variable.
2926         (riscv_struct_info::analyse_inner): New private member function,
2927         takes the old implementation of riscv_struct_info::analyse but
2928         extended to track field offsets.
2929         (riscv_call_arg_struct): Update the struct folding special cases
2930         to handle cases where empty C++ structs, which are non-zero
2931         length, are found.
2932         (riscv_arg_location): Initialise the length of each location, a
2933         non-zero length now indicates the location is in use.
2934         (riscv_push_dummy_call): Allow for the first location having a
2935         non-zero offset when setting up arguments.
2936         (riscv_return_value): Likewise, but for return values.
2937
2938 2019-04-11  Tom Tromey  <tromey@adacore.com>
2939
2940         * utils.c (internal_vproblem): Make "msg" const.
2941
2942 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2943
2944         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2945         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2946         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2947         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2948
2949 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2950
2951         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2952         function.
2953         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2954         of amd64_collect_native_gregset.
2955         (amd64_linux_nat_target::store_registers): Likewise.
2956
2957 2019-04-10  Tom Tromey  <tom@tromey.com>
2958
2959         * symtab.c (lookup_global_symbol_from_objfile)
2960         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2961         * objfiles.h (class separate_debug_iterator): New.
2962         (class separate_debug_range): New.
2963         (struct objfile) <separate_debug_objfiles>: New method.
2964         (objfile_separate_debug_iterate): Don't declare.
2965         * objfiles.c (separate_debug_iterator::operator++): Rename from
2966         objfile_separate_debug_iterate.
2967         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2968         iterator.
2969         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2970         iterator.
2971
2972 2019-04-10  Tom Tromey  <tom@tromey.com>
2973
2974         * symfile.c (reread_symbols): Remove old comment.
2975         * objfiles.c (free_all_objfiles): Fix a typo.
2976
2977 2019-04-10  Tom Tromey  <tom@tromey.com>
2978
2979         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2980         * minsyms.c (lookup_minimal_symbol): Use foreach.
2981         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2982         (lookup_minimal_symbol_solib_trampoline): Likewise.
2983         * symfile.c (reread_symbols): Use foreach.
2984
2985 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2986             Tom Tromey  <tromey@adacore.com>
2987
2988         PR rust/24414:
2989         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2990         (rust_lex_int_test): Change "value" to be LONGEST.
2991         (rust_lex_tests): Add test for long integer literal.
2992
2993 2019-04-09  Tom Tromey  <tromey@adacore.com>
2994
2995         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2996         to bool.
2997         (extended_remote_target::attach): Update.
2998         (remote_target::remote_notice_new_inferior): Update.
2999         (remote_target::add_current_inferior_and_thread): Update.
3000         * inferior.c (exit_inferior_1): Use "false".
3001         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3002
3003 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3004
3005         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3006         the "start" command.
3007
3008 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3009
3010         * python/py-inferior.c (infpy_thread_from_thread_handle):
3011         Adjust comments to reflect renaming of thread_from_thread_handle
3012         to thread_from_handle.  Adjust keywords.  Fix type error message.
3013         (inferior_object_methods): Add thread_from_handle.  Retain
3014         thread_from_thread_handle, but mark it as deprecated.
3015
3016 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3017
3018         * gdbthread.h (find_thread_by_handle): Revise declaration.
3019         * thread.c (find_thread_by_handle): Likewise.  Adjust
3020         implementation too.
3021         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3022         support for buffer objects as handles.
3023
3024 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3025
3026         * python/py-infthread.c (thpy_thread_handle): New function.
3027         (thread_object_methods): Register thpy_thread_handle.
3028
3029 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3030
3031         * gdbthread.h (thread_to_thread_handle): Declare.
3032         * thread.c (gdbtypes.h): Include.
3033         (thread_to_thread_handle): New function.
3034
3035         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3036         (target_thread_info_to_thread_handle): Declare.
3037         * target.c (target_thread_info_to_thread_handle): New function.
3038         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3039         * target-delegates.c: Regenerate.
3040
3041         * linux-thread-db.c (class thread_db_target): Add method
3042         thread_info_to_thread_handle.
3043         (thread_db_target::thread_info_to_thread_handle): Define.
3044         * remote.c (class remote_target): Add new method
3045         thread_info_to_thread_handle.
3046         (remote_target::thread_info_to_thread_handle): Define.
3047
3048 2019-04-08  Pedro Alves  <palves@redhat.com>
3049
3050         * common/common-exceptions.c (throw_exception): Don't create
3051         named object to throw; throw directly.
3052         (throw_it): Likewise.  Don't initialize gdb_exception::message
3053         here, with new; pass FMT and AP to the ctor instead.
3054         * common/common-exceptions.h: Include <string>.
3055         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3056         const char *, va_list)): New ctor.  Use std::make_shared.
3057         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3058         errors)): Delete.
3059         (gdb_exception_error::gdb_exception_error(enum errors, const char
3060         *, va_list)): New.
3061         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3062         Add assertion.
3063         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3064         errors)): Delete.
3065         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3066         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3067         Add assertion.
3068
3069 2019-04-08  Tom Tromey  <tom@tromey.com>
3070
3071         * valops.c (value_rtti_indirect_type): Replace throw_exception
3072         with throw.
3073         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3074         with throw.
3075         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3076         throw.
3077         * target.c (target_translate_tls_address): Replace throw_exception
3078         with throw.
3079         * stack.c (frame_apply_command_count): Replace throw_exception
3080         with throw.
3081         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3082         throw.
3083         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3084         with throw.
3085         * rs6000-tdep.c (rs6000_frame_cache)
3086         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3087         * remote.c: Replace throw_exception with throw.
3088         * record-full.c (record_full_message, record_full_wait_1)
3089         (record_full_restore): Replace throw_exception with throw.
3090         * record-btrace.c:
3091         (get_thread_current_frame_id, record_btrace_start_replaying)
3092         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3093         (cmd_record_btrace_start): Replace throw_exception with throw.
3094         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3095         throw.
3096         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3097         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3098         * linespec.c:
3099         (find_linespec_symbols): Replace throw_exception with throw.
3100         * infrun.c (displaced_step_prepare, resume): Replace
3101         throw_exception with throw.
3102         * infcmd.c (post_create_inferior): Replace throw_exception with
3103         throw.
3104         * inf-loop.c (inferior_event_handler): Replace throw_exception
3105         with throw.
3106         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3107         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3108         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3109         (get_prev_frame_always, get_frame_pc_if_available)
3110         (get_frame_address_in_block_if_available, get_frame_language):
3111         Replace throw_exception with throw.
3112         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3113         throw_exception with throw.
3114         * eval.c (fetch_subexp_value, evaluate_var_value)
3115         (evaluate_funcall, evaluate_subexp_standard): Replace
3116         throw_exception with throw.
3117         * dwarf2loc.c (call_site_find_chain)
3118         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3119         Replace throw_exception with throw.
3120         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3121         with throw.
3122         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3123         throw.
3124         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3125         * completer.c (complete_line_internal): Replace throw_exception
3126         with throw.
3127         * compile/compile-object-run.c (compile_object_run): Replace
3128         throw_exception with throw.
3129         * cli/cli-script.c (process_next_line): Replace throw_exception
3130         with throw.
3131         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3132         (btrace_enable, btrace_maint_update_pt_packets): Replace
3133         throw_exception with throw.
3134         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3135         throw_exception with throw.
3136         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3137         throw_exception with throw.
3138         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3139         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3140         * aarch64-tdep.c (aarch64_make_prologue_cache)
3141         (aarch64_make_stub_cache): Replace throw_exception with throw.
3142
3143 2019-04-08  Tom Tromey  <tom@tromey.com>
3144
3145         * common/common-exceptions.c (throw_exception): Rename from
3146         throw_exception_cxx.  Remove old copy.  Make argument const.
3147         (throw_it): Create and throw exception objects directly.
3148         * common/common-exceptions.h (throw_exception): Make argument
3149         const.
3150         (struct gdb_exception_error): Add constructor.
3151         (struct gdb_exception_quit): Add constructor.
3152
3153 2019-04-08  Tom Tromey  <tom@tromey.com>
3154
3155         * common/common-exceptions.h (exception_rethrow): Don't declare.
3156         (TRY_SJLJ): Update comment.
3157         (TRY, CATCH, END_CATCH): Remove.
3158         * common/common-exceptions.c (exception_rethrow): Remove.
3159
3160 2019-04-08  Tom Tromey  <tom@tromey.com>
3161
3162         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3163         Remove.
3164         (gdb_exception_error): Rename from
3165         gdb_exception_RETURN_MASK_ERROR.
3166         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3167         (gdb_quit_bad_alloc): Update.
3168         * aarch64-tdep.c: Update.
3169         * ada-lang.c: Update.
3170         * ada-typeprint.c: Update.
3171         * ada-valprint.c: Update.
3172         * amd64-tdep.c: Update.
3173         * arch-utils.c: Update.
3174         * break-catch-throw.c: Update.
3175         * breakpoint.c: Update.
3176         * btrace.c: Update.
3177         * c-varobj.c: Update.
3178         * cli/cli-cmds.c: Update.
3179         * cli/cli-interp.c: Update.
3180         * cli/cli-script.c: Update.
3181         * common/common-exceptions.c: Update.
3182         * common/new-op.c: Update.
3183         * common/selftest.c: Update.
3184         * compile/compile-c-symbols.c: Update.
3185         * compile/compile-cplus-symbols.c: Update.
3186         * compile/compile-object-load.c: Update.
3187         * compile/compile-object-run.c: Update.
3188         * completer.c: Update.
3189         * corelow.c: Update.
3190         * cp-abi.c: Update.
3191         * cp-support.c: Update.
3192         * cp-valprint.c: Update.
3193         * darwin-nat.c: Update.
3194         * disasm-selftests.c: Update.
3195         * dtrace-probe.c: Update.
3196         * dwarf-index-cache.c: Update.
3197         * dwarf-index-write.c: Update.
3198         * dwarf2-frame-tailcall.c: Update.
3199         * dwarf2-frame.c: Update.
3200         * dwarf2loc.c: Update.
3201         * dwarf2read.c: Update.
3202         * eval.c: Update.
3203         * event-loop.c: Update.
3204         * event-top.c: Update.
3205         * exec.c: Update.
3206         * f-valprint.c: Update.
3207         * fbsd-tdep.c: Update.
3208         * frame-unwind.c: Update.
3209         * frame.c: Update.
3210         * gdbtypes.c: Update.
3211         * gnu-v3-abi.c: Update.
3212         * guile/guile-internal.h: Update.
3213         * guile/scm-block.c: Update.
3214         * guile/scm-breakpoint.c: Update.
3215         * guile/scm-cmd.c: Update.
3216         * guile/scm-disasm.c: Update.
3217         * guile/scm-frame.c: Update.
3218         * guile/scm-lazy-string.c: Update.
3219         * guile/scm-math.c: Update.
3220         * guile/scm-param.c: Update.
3221         * guile/scm-ports.c: Update.
3222         * guile/scm-pretty-print.c: Update.
3223         * guile/scm-symbol.c: Update.
3224         * guile/scm-symtab.c: Update.
3225         * guile/scm-type.c: Update.
3226         * guile/scm-value.c: Update.
3227         * i386-linux-tdep.c: Update.
3228         * i386-tdep.c: Update.
3229         * inf-loop.c: Update.
3230         * infcall.c: Update.
3231         * infcmd.c: Update.
3232         * infrun.c: Update.
3233         * jit.c: Update.
3234         * language.c: Update.
3235         * linespec.c: Update.
3236         * linux-fork.c: Update.
3237         * linux-nat.c: Update.
3238         * linux-tdep.c: Update.
3239         * linux-thread-db.c: Update.
3240         * main.c: Update.
3241         * mi/mi-cmd-break.c: Update.
3242         * mi/mi-cmd-stack.c: Update.
3243         * mi/mi-interp.c: Update.
3244         * mi/mi-main.c: Update.
3245         * objc-lang.c: Update.
3246         * p-valprint.c: Update.
3247         * parse.c: Update.
3248         * ppc-linux-tdep.c: Update.
3249         * printcmd.c: Update.
3250         * python/py-arch.c: Update.
3251         * python/py-breakpoint.c: Update.
3252         * python/py-cmd.c: Update.
3253         * python/py-finishbreakpoint.c: Update.
3254         * python/py-frame.c: Update.
3255         * python/py-framefilter.c: Update.
3256         * python/py-gdb-readline.c: Update.
3257         * python/py-inferior.c: Update.
3258         * python/py-infthread.c: Update.
3259         * python/py-lazy-string.c: Update.
3260         * python/py-linetable.c: Update.
3261         * python/py-objfile.c: Update.
3262         * python/py-param.c: Update.
3263         * python/py-prettyprint.c: Update.
3264         * python/py-progspace.c: Update.
3265         * python/py-record-btrace.c: Update.
3266         * python/py-record.c: Update.
3267         * python/py-symbol.c: Update.
3268         * python/py-type.c: Update.
3269         * python/py-unwind.c: Update.
3270         * python/py-utils.c: Update.
3271         * python/py-value.c: Update.
3272         * python/python.c: Update.
3273         * record-btrace.c: Update.
3274         * record-full.c: Update.
3275         * remote-fileio.c: Update.
3276         * remote.c: Update.
3277         * riscv-tdep.c: Update.
3278         * rs6000-aix-tdep.c: Update.
3279         * rs6000-tdep.c: Update.
3280         * rust-exp.y: Update.
3281         * rust-lang.c: Update.
3282         * s390-tdep.c: Update.
3283         * selftest-arch.c: Update.
3284         * solib-dsbt.c: Update.
3285         * solib-frv.c: Update.
3286         * solib-spu.c: Update.
3287         * solib-svr4.c: Update.
3288         * solib.c: Update.
3289         * sparc64-linux-tdep.c: Update.
3290         * stack.c: Update.
3291         * symfile-mem.c: Update.
3292         * symmisc.c: Update.
3293         * target.c: Update.
3294         * thread.c: Update.
3295         * top.c: Update.
3296         * tracefile-tfile.c: Update.
3297         * tui/tui.c: Update.
3298         * typeprint.c: Update.
3299         * unittests/cli-utils-selftests.c: Update.
3300         * unittests/parse-connection-spec-selftests.c: Update.
3301         * valops.c: Update.
3302         * valprint.c: Update.
3303         * value.c: Update.
3304         * varobj.c: Update.
3305         * windows-nat.c: Update.
3306         * x86-linux-nat.c: Update.
3307         * xml-support.c: Update.
3308
3309 2019-04-08  Tom Tromey  <tom@tromey.com>
3310
3311         * xml-support.c: Use C++ exception handling.
3312         * x86-linux-nat.c: Use C++ exception handling.
3313         * windows-nat.c: Use C++ exception handling.
3314         * varobj.c: Use C++ exception handling.
3315         * value.c: Use C++ exception handling.
3316         * valprint.c: Use C++ exception handling.
3317         * valops.c: Use C++ exception handling.
3318         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3319         handling.
3320         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3321         * typeprint.c: Use C++ exception handling.
3322         * tui/tui.c: Use C++ exception handling.
3323         * tracefile-tfile.c: Use C++ exception handling.
3324         * top.c: Use C++ exception handling.
3325         * thread.c: Use C++ exception handling.
3326         * target.c: Use C++ exception handling.
3327         * symmisc.c: Use C++ exception handling.
3328         * symfile-mem.c: Use C++ exception handling.
3329         * stack.c: Use C++ exception handling.
3330         * sparc64-linux-tdep.c: Use C++ exception handling.
3331         * solib.c: Use C++ exception handling.
3332         * solib-svr4.c: Use C++ exception handling.
3333         * solib-spu.c: Use C++ exception handling.
3334         * solib-frv.c: Use C++ exception handling.
3335         * solib-dsbt.c: Use C++ exception handling.
3336         * selftest-arch.c: Use C++ exception handling.
3337         * s390-tdep.c: Use C++ exception handling.
3338         * rust-lang.c: Use C++ exception handling.
3339         * rust-exp.y: Use C++ exception handling.
3340         * rs6000-tdep.c: Use C++ exception handling.
3341         * rs6000-aix-tdep.c: Use C++ exception handling.
3342         * riscv-tdep.c: Use C++ exception handling.
3343         * remote.c: Use C++ exception handling.
3344         * remote-fileio.c: Use C++ exception handling.
3345         * record-full.c: Use C++ exception handling.
3346         * record-btrace.c: Use C++ exception handling.
3347         * python/python.c: Use C++ exception handling.
3348         * python/py-value.c: Use C++ exception handling.
3349         * python/py-utils.c: Use C++ exception handling.
3350         * python/py-unwind.c: Use C++ exception handling.
3351         * python/py-type.c: Use C++ exception handling.
3352         * python/py-symbol.c: Use C++ exception handling.
3353         * python/py-record.c: Use C++ exception handling.
3354         * python/py-record-btrace.c: Use C++ exception handling.
3355         * python/py-progspace.c: Use C++ exception handling.
3356         * python/py-prettyprint.c: Use C++ exception handling.
3357         * python/py-param.c: Use C++ exception handling.
3358         * python/py-objfile.c: Use C++ exception handling.
3359         * python/py-linetable.c: Use C++ exception handling.
3360         * python/py-lazy-string.c: Use C++ exception handling.
3361         * python/py-infthread.c: Use C++ exception handling.
3362         * python/py-inferior.c: Use C++ exception handling.
3363         * python/py-gdb-readline.c: Use C++ exception handling.
3364         * python/py-framefilter.c: Use C++ exception handling.
3365         * python/py-frame.c: Use C++ exception handling.
3366         * python/py-finishbreakpoint.c: Use C++ exception handling.
3367         * python/py-cmd.c: Use C++ exception handling.
3368         * python/py-breakpoint.c: Use C++ exception handling.
3369         * python/py-arch.c: Use C++ exception handling.
3370         * printcmd.c: Use C++ exception handling.
3371         * ppc-linux-tdep.c: Use C++ exception handling.
3372         * parse.c: Use C++ exception handling.
3373         * p-valprint.c: Use C++ exception handling.
3374         * objc-lang.c: Use C++ exception handling.
3375         * mi/mi-main.c: Use C++ exception handling.
3376         * mi/mi-interp.c: Use C++ exception handling.
3377         * mi/mi-cmd-stack.c: Use C++ exception handling.
3378         * mi/mi-cmd-break.c: Use C++ exception handling.
3379         * main.c: Use C++ exception handling.
3380         * linux-thread-db.c: Use C++ exception handling.
3381         * linux-tdep.c: Use C++ exception handling.
3382         * linux-nat.c: Use C++ exception handling.
3383         * linux-fork.c: Use C++ exception handling.
3384         * linespec.c: Use C++ exception handling.
3385         * language.c: Use C++ exception handling.
3386         * jit.c: Use C++ exception handling.
3387         * infrun.c: Use C++ exception handling.
3388         * infcmd.c: Use C++ exception handling.
3389         * infcall.c: Use C++ exception handling.
3390         * inf-loop.c: Use C++ exception handling.
3391         * i386-tdep.c: Use C++ exception handling.
3392         * i386-linux-tdep.c: Use C++ exception handling.
3393         * guile/scm-value.c: Use C++ exception handling.
3394         * guile/scm-type.c: Use C++ exception handling.
3395         * guile/scm-symtab.c: Use C++ exception handling.
3396         * guile/scm-symbol.c: Use C++ exception handling.
3397         * guile/scm-pretty-print.c: Use C++ exception handling.
3398         * guile/scm-ports.c: Use C++ exception handling.
3399         * guile/scm-param.c: Use C++ exception handling.
3400         * guile/scm-math.c: Use C++ exception handling.
3401         * guile/scm-lazy-string.c: Use C++ exception handling.
3402         * guile/scm-frame.c: Use C++ exception handling.
3403         * guile/scm-disasm.c: Use C++ exception handling.
3404         * guile/scm-cmd.c: Use C++ exception handling.
3405         * guile/scm-breakpoint.c: Use C++ exception handling.
3406         * guile/scm-block.c: Use C++ exception handling.
3407         * guile/guile-internal.h: Use C++ exception handling.
3408         * gnu-v3-abi.c: Use C++ exception handling.
3409         * gdbtypes.c: Use C++ exception handling.
3410         * frame.c: Use C++ exception handling.
3411         * frame-unwind.c: Use C++ exception handling.
3412         * fbsd-tdep.c: Use C++ exception handling.
3413         * f-valprint.c: Use C++ exception handling.
3414         * exec.c: Use C++ exception handling.
3415         * event-top.c: Use C++ exception handling.
3416         * event-loop.c: Use C++ exception handling.
3417         * eval.c: Use C++ exception handling.
3418         * dwarf2read.c: Use C++ exception handling.
3419         * dwarf2loc.c: Use C++ exception handling.
3420         * dwarf2-frame.c: Use C++ exception handling.
3421         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3422         * dwarf-index-write.c: Use C++ exception handling.
3423         * dwarf-index-cache.c: Use C++ exception handling.
3424         * dtrace-probe.c: Use C++ exception handling.
3425         * disasm-selftests.c: Use C++ exception handling.
3426         * darwin-nat.c: Use C++ exception handling.
3427         * cp-valprint.c: Use C++ exception handling.
3428         * cp-support.c: Use C++ exception handling.
3429         * cp-abi.c: Use C++ exception handling.
3430         * corelow.c: Use C++ exception handling.
3431         * completer.c: Use C++ exception handling.
3432         * compile/compile-object-run.c: Use C++ exception handling.
3433         * compile/compile-object-load.c: Use C++ exception handling.
3434         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3435         * compile/compile-c-symbols.c: Use C++ exception handling.
3436         * common/selftest.c: Use C++ exception handling.
3437         * common/new-op.c: Use C++ exception handling.
3438         * cli/cli-script.c: Use C++ exception handling.
3439         * cli/cli-interp.c: Use C++ exception handling.
3440         * cli/cli-cmds.c: Use C++ exception handling.
3441         * c-varobj.c: Use C++ exception handling.
3442         * btrace.c: Use C++ exception handling.
3443         * breakpoint.c: Use C++ exception handling.
3444         * break-catch-throw.c: Use C++ exception handling.
3445         * arch-utils.c: Use C++ exception handling.
3446         * amd64-tdep.c: Use C++ exception handling.
3447         * ada-valprint.c: Use C++ exception handling.
3448         * ada-typeprint.c: Use C++ exception handling.
3449         * ada-lang.c: Use C++ exception handling.
3450         * aarch64-tdep.c: Use C++ exception handling.
3451
3452 2019-04-08  Tom Tromey  <tom@tromey.com>
3453
3454         * xml-support.c (gdb_xml_parser::parse): Update.
3455         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3456         * value.c (show_convenience): Update.
3457         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3458         (test_parse_flags_qcs): Update.
3459         * thread.c (thr_try_catch_cmd): Update.
3460         * target.c (target_translate_tls_address): Update.
3461         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3462         (info_frame_command_core, frame_apply_command_count): Update.
3463         * rust-exp.y (rust_lex_exception_test): Update.
3464         * riscv-tdep.c (riscv_print_one_register_info): Update.
3465         * remote.c (remote_target::enable_btrace): Update.
3466         * record-btrace.c (record_btrace_enable_warn): Update.
3467         * python/py-utils.c (gdbpy_convert_exception): Update.
3468         * printcmd.c (do_one_display, print_variable_and_value): Update.
3469         * mi/mi-main.c (mi_print_exception): Update.
3470         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3471         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3472         * linux-nat.c (linux_nat_target::attach): Update.
3473         * linux-fork.c (class scoped_switch_fork_info): Update.
3474         * infrun.c (displaced_step_prepare): Update.
3475         * infcall.c (call_function_by_hand_dummy): Update.
3476         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3477         * gnu-v3-abi.c (print_one_vtable): Update.
3478         * frame.c (get_prev_frame_always): Update.
3479         * f-valprint.c (info_common_command_for_block): Update.
3480         * exec.c (try_open_exec_file): Update.
3481         * exceptions.c (print_exception, exception_print)
3482         (exception_fprintf, exception_print_same): Update.
3483         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3484         * dwarf-index-cache.c (index_cache::store)
3485         (index_cache::lookup_gdb_index): Update.
3486         * darwin-nat.c (maybe_cache_shell): Update.
3487         * cp-valprint.c (cp_print_value_fields): Update.
3488         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3489         (gcc_cplus_symbol_address): Update.
3490         * compile/compile-c-symbols.c (gcc_convert_symbol)
3491         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3492         * common/selftest.c: Update.
3493         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3494         a std::string.
3495         (exception_try_scope_entry, exception_try_scope_exit): Don't
3496         declare.
3497         (struct exception_try_scope): Remove.
3498         (TRY): Don't use exception_try_scope.
3499         (struct gdb_exception): Add constructor, operator=.
3500         <what>: New method.
3501         (struct gdb_exception_RETURN_MASK_ALL)
3502         (struct gdb_exception_RETURN_MASK_ERROR)
3503         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3504         (struct gdb_quit_bad_alloc): Update.
3505         * common/common-exceptions.c (exception_none): Change
3506         initializer.
3507         (struct catcher) <state, exception>: Initialize inline.
3508         <prev>: Remove member.
3509         (current_catcher): Remove.
3510         (catchers): New global.
3511         (exceptions_state_mc_init): Simplify.
3512         (catcher_pop): Remove.
3513         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3514         (try_scope_depth, exception_try_scope_entry)
3515         (exception_try_scope_exit): Remove.
3516         (throw_exception_sjlj): Update.
3517         (exception_messages, exception_messages_size): Remove.
3518         (throw_it): Simplify.
3519         (gdb_exception_sliced_copy): Remove.
3520         (throw_exception_cxx): Update.
3521         * cli/cli-script.c (script_from_file): Update.
3522         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3523         Update.
3524         * ada-valprint.c (ada_val_print): Update.
3525         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3526         (create_excep_cond_exprs): Update.
3527
3528 2019-04-08  Tom Tromey  <tom@tromey.com>
3529
3530         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3531         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3532         (TRY, CATCH, END_CATCH): Remove some definitions.
3533         * common/common-exceptions.c: Don't use GDB_XCPT.
3534         (catcher_list_size): Remove.
3535         (throw_exception, throw_it): Simplify.
3536
3537 2019-04-05  Tom Tromey  <tom@tromey.com>
3538
3539         Revert the header-sorting patch.
3540         * ft32-tdep.c: Revert.
3541         * frv-tdep.c: Revert.
3542         * frv-linux-tdep.c: Revert.
3543         * frame.c: Revert.
3544         * frame-unwind.c: Revert.
3545         * frame-base.c: Revert.
3546         * fork-child.c: Revert.
3547         * findvar.c: Revert.
3548         * findcmd.c: Revert.
3549         * filesystem.c: Revert.
3550         * filename-seen-cache.h: Revert.
3551         * filename-seen-cache.c: Revert.
3552         * fbsd-tdep.c: Revert.
3553         * fbsd-nat.h: Revert.
3554         * fbsd-nat.c: Revert.
3555         * f-valprint.c: Revert.
3556         * f-typeprint.c: Revert.
3557         * f-lang.c: Revert.
3558         * extension.h: Revert.
3559         * extension.c: Revert.
3560         * extension-priv.h: Revert.
3561         * expprint.c: Revert.
3562         * exec.h: Revert.
3563         * exec.c: Revert.
3564         * exceptions.c: Revert.
3565         * event-top.c: Revert.
3566         * event-loop.c: Revert.
3567         * eval.c: Revert.
3568         * elfread.c: Revert.
3569         * dwarf2read.h: Revert.
3570         * dwarf2read.c: Revert.
3571         * dwarf2loc.c: Revert.
3572         * dwarf2expr.h: Revert.
3573         * dwarf2expr.c: Revert.
3574         * dwarf2-frame.c: Revert.
3575         * dwarf2-frame-tailcall.c: Revert.
3576         * dwarf-index-write.h: Revert.
3577         * dwarf-index-write.c: Revert.
3578         * dwarf-index-common.c: Revert.
3579         * dwarf-index-cache.h: Revert.
3580         * dwarf-index-cache.c: Revert.
3581         * dummy-frame.c: Revert.
3582         * dtrace-probe.c: Revert.
3583         * disasm.h: Revert.
3584         * disasm.c: Revert.
3585         * disasm-selftests.c: Revert.
3586         * dictionary.c: Revert.
3587         * dicos-tdep.c: Revert.
3588         * demangle.c: Revert.
3589         * dcache.h: Revert.
3590         * dcache.c: Revert.
3591         * darwin-nat.h: Revert.
3592         * darwin-nat.c: Revert.
3593         * darwin-nat-info.c: Revert.
3594         * d-valprint.c: Revert.
3595         * d-namespace.c: Revert.
3596         * d-lang.c: Revert.
3597         * ctf.c: Revert.
3598         * csky-tdep.c: Revert.
3599         * csky-linux-tdep.c: Revert.
3600         * cris-tdep.c: Revert.
3601         * cris-linux-tdep.c: Revert.
3602         * cp-valprint.c: Revert.
3603         * cp-support.c: Revert.
3604         * cp-namespace.c: Revert.
3605         * cp-abi.c: Revert.
3606         * corelow.c: Revert.
3607         * corefile.c: Revert.
3608         * continuations.c: Revert.
3609         * completer.h: Revert.
3610         * completer.c: Revert.
3611         * complaints.c: Revert.
3612         * coffread.c: Revert.
3613         * coff-pe-read.c: Revert.
3614         * cli-out.h: Revert.
3615         * cli-out.c: Revert.
3616         * charset.c: Revert.
3617         * c-varobj.c: Revert.
3618         * c-valprint.c: Revert.
3619         * c-typeprint.c: Revert.
3620         * c-lang.c: Revert.
3621         * buildsym.c: Revert.
3622         * buildsym-legacy.c: Revert.
3623         * build-id.h: Revert.
3624         * build-id.c: Revert.
3625         * btrace.c: Revert.
3626         * bsd-uthread.c: Revert.
3627         * breakpoint.h: Revert.
3628         * breakpoint.c: Revert.
3629         * break-catch-throw.c: Revert.
3630         * break-catch-syscall.c: Revert.
3631         * break-catch-sig.c: Revert.
3632         * blockframe.c: Revert.
3633         * block.c: Revert.
3634         * bfin-tdep.c: Revert.
3635         * bfin-linux-tdep.c: Revert.
3636         * bfd-target.c: Revert.
3637         * bcache.c: Revert.
3638         * ax-general.c: Revert.
3639         * ax-gdb.h: Revert.
3640         * ax-gdb.c: Revert.
3641         * avr-tdep.c: Revert.
3642         * auxv.c: Revert.
3643         * auto-load.c: Revert.
3644         * arm-wince-tdep.c: Revert.
3645         * arm-tdep.c: Revert.
3646         * arm-symbian-tdep.c: Revert.
3647         * arm-pikeos-tdep.c: Revert.
3648         * arm-obsd-tdep.c: Revert.
3649         * arm-nbsd-tdep.c: Revert.
3650         * arm-nbsd-nat.c: Revert.
3651         * arm-linux-tdep.c: Revert.
3652         * arm-linux-nat.c: Revert.
3653         * arm-fbsd-tdep.c: Revert.
3654         * arm-fbsd-nat.c: Revert.
3655         * arm-bsd-tdep.c: Revert.
3656         * arch-utils.c: Revert.
3657         * arc-tdep.c: Revert.
3658         * arc-newlib-tdep.c: Revert.
3659         * annotate.h: Revert.
3660         * annotate.c: Revert.
3661         * amd64-windows-tdep.c: Revert.
3662         * amd64-windows-nat.c: Revert.
3663         * amd64-tdep.c: Revert.
3664         * amd64-sol2-tdep.c: Revert.
3665         * amd64-obsd-tdep.c: Revert.
3666         * amd64-obsd-nat.c: Revert.
3667         * amd64-nbsd-tdep.c: Revert.
3668         * amd64-nbsd-nat.c: Revert.
3669         * amd64-nat.c: Revert.
3670         * amd64-linux-tdep.c: Revert.
3671         * amd64-linux-nat.c: Revert.
3672         * amd64-fbsd-tdep.c: Revert.
3673         * amd64-fbsd-nat.c: Revert.
3674         * amd64-dicos-tdep.c: Revert.
3675         * amd64-darwin-tdep.c: Revert.
3676         * amd64-bsd-nat.c: Revert.
3677         * alpha-tdep.c: Revert.
3678         * alpha-obsd-tdep.c: Revert.
3679         * alpha-nbsd-tdep.c: Revert.
3680         * alpha-mdebug-tdep.c: Revert.
3681         * alpha-linux-tdep.c: Revert.
3682         * alpha-linux-nat.c: Revert.
3683         * alpha-bsd-tdep.c: Revert.
3684         * alpha-bsd-nat.c: Revert.
3685         * aix-thread.c: Revert.
3686         * agent.c: Revert.
3687         * addrmap.c: Revert.
3688         * ada-varobj.c: Revert.
3689         * ada-valprint.c: Revert.
3690         * ada-typeprint.c: Revert.
3691         * ada-tasks.c: Revert.
3692         * ada-lang.c: Revert.
3693         * aarch64-tdep.c: Revert.
3694         * aarch64-ravenscar-thread.c: Revert.
3695         * aarch64-newlib-tdep.c: Revert.
3696         * aarch64-linux-tdep.c: Revert.
3697         * aarch64-linux-nat.c: Revert.
3698         * aarch64-fbsd-tdep.c: Revert.
3699         * aarch64-fbsd-nat.c: Revert.
3700         * aarch32-linux-nat.c: Revert.
3701
3702 2019-04-05  Tom Tromey  <tom@tromey.com>
3703
3704         * ft32-tdep.c: Sort headers.
3705         * frv-tdep.c: Sort headers.
3706         * frv-linux-tdep.c: Sort headers.
3707         * frame.c: Sort headers.
3708         * frame-unwind.c: Sort headers.
3709         * frame-base.c: Sort headers.
3710         * fork-child.c: Sort headers.
3711         * findvar.c: Sort headers.
3712         * findcmd.c: Sort headers.
3713         * filesystem.c: Sort headers.
3714         * filename-seen-cache.h: Sort headers.
3715         * filename-seen-cache.c: Sort headers.
3716         * fbsd-tdep.c: Sort headers.
3717         * fbsd-nat.h: Sort headers.
3718         * fbsd-nat.c: Sort headers.
3719         * f-valprint.c: Sort headers.
3720         * f-typeprint.c: Sort headers.
3721         * f-lang.c: Sort headers.
3722         * extension.h: Sort headers.
3723         * extension.c: Sort headers.
3724         * extension-priv.h: Sort headers.
3725         * expprint.c: Sort headers.
3726         * exec.h: Sort headers.
3727         * exec.c: Sort headers.
3728         * exceptions.c: Sort headers.
3729         * event-top.c: Sort headers.
3730         * event-loop.c: Sort headers.
3731         * eval.c: Sort headers.
3732         * elfread.c: Sort headers.
3733         * dwarf2read.h: Sort headers.
3734         * dwarf2read.c: Sort headers.
3735         * dwarf2loc.c: Sort headers.
3736         * dwarf2expr.h: Sort headers.
3737         * dwarf2expr.c: Sort headers.
3738         * dwarf2-frame.c: Sort headers.
3739         * dwarf2-frame-tailcall.c: Sort headers.
3740         * dwarf-index-write.h: Sort headers.
3741         * dwarf-index-write.c: Sort headers.
3742         * dwarf-index-common.c: Sort headers.
3743         * dwarf-index-cache.h: Sort headers.
3744         * dwarf-index-cache.c: Sort headers.
3745         * dummy-frame.c: Sort headers.
3746         * dtrace-probe.c: Sort headers.
3747         * disasm.h: Sort headers.
3748         * disasm.c: Sort headers.
3749         * disasm-selftests.c: Sort headers.
3750         * dictionary.c: Sort headers.
3751         * dicos-tdep.c: Sort headers.
3752         * demangle.c: Sort headers.
3753         * dcache.h: Sort headers.
3754         * dcache.c: Sort headers.
3755         * darwin-nat.h: Sort headers.
3756         * darwin-nat.c: Sort headers.
3757         * darwin-nat-info.c: Sort headers.
3758         * d-valprint.c: Sort headers.
3759         * d-namespace.c: Sort headers.
3760         * d-lang.c: Sort headers.
3761         * ctf.c: Sort headers.
3762         * csky-tdep.c: Sort headers.
3763         * csky-linux-tdep.c: Sort headers.
3764         * cris-tdep.c: Sort headers.
3765         * cris-linux-tdep.c: Sort headers.
3766         * cp-valprint.c: Sort headers.
3767         * cp-support.c: Sort headers.
3768         * cp-namespace.c: Sort headers.
3769         * cp-abi.c: Sort headers.
3770         * corelow.c: Sort headers.
3771         * corefile.c: Sort headers.
3772         * continuations.c: Sort headers.
3773         * completer.h: Sort headers.
3774         * completer.c: Sort headers.
3775         * complaints.c: Sort headers.
3776         * coffread.c: Sort headers.
3777         * coff-pe-read.c: Sort headers.
3778         * cli-out.h: Sort headers.
3779         * cli-out.c: Sort headers.
3780         * charset.c: Sort headers.
3781         * c-varobj.c: Sort headers.
3782         * c-valprint.c: Sort headers.
3783         * c-typeprint.c: Sort headers.
3784         * c-lang.c: Sort headers.
3785         * buildsym.c: Sort headers.
3786         * buildsym-legacy.c: Sort headers.
3787         * build-id.h: Sort headers.
3788         * build-id.c: Sort headers.
3789         * btrace.c: Sort headers.
3790         * bsd-uthread.c: Sort headers.
3791         * breakpoint.h: Sort headers.
3792         * breakpoint.c: Sort headers.
3793         * break-catch-throw.c: Sort headers.
3794         * break-catch-syscall.c: Sort headers.
3795         * break-catch-sig.c: Sort headers.
3796         * blockframe.c: Sort headers.
3797         * block.c: Sort headers.
3798         * bfin-tdep.c: Sort headers.
3799         * bfin-linux-tdep.c: Sort headers.
3800         * bfd-target.c: Sort headers.
3801         * bcache.c: Sort headers.
3802         * ax-general.c: Sort headers.
3803         * ax-gdb.h: Sort headers.
3804         * ax-gdb.c: Sort headers.
3805         * avr-tdep.c: Sort headers.
3806         * auxv.c: Sort headers.
3807         * auto-load.c: Sort headers.
3808         * arm-wince-tdep.c: Sort headers.
3809         * arm-tdep.c: Sort headers.
3810         * arm-symbian-tdep.c: Sort headers.
3811         * arm-pikeos-tdep.c: Sort headers.
3812         * arm-obsd-tdep.c: Sort headers.
3813         * arm-nbsd-tdep.c: Sort headers.
3814         * arm-nbsd-nat.c: Sort headers.
3815         * arm-linux-tdep.c: Sort headers.
3816         * arm-linux-nat.c: Sort headers.
3817         * arm-fbsd-tdep.c: Sort headers.
3818         * arm-fbsd-nat.c: Sort headers.
3819         * arm-bsd-tdep.c: Sort headers.
3820         * arch-utils.c: Sort headers.
3821         * arc-tdep.c: Sort headers.
3822         * arc-newlib-tdep.c: Sort headers.
3823         * annotate.h: Sort headers.
3824         * annotate.c: Sort headers.
3825         * amd64-windows-tdep.c: Sort headers.
3826         * amd64-windows-nat.c: Sort headers.
3827         * amd64-tdep.c: Sort headers.
3828         * amd64-sol2-tdep.c: Sort headers.
3829         * amd64-obsd-tdep.c: Sort headers.
3830         * amd64-obsd-nat.c: Sort headers.
3831         * amd64-nbsd-tdep.c: Sort headers.
3832         * amd64-nbsd-nat.c: Sort headers.
3833         * amd64-nat.c: Sort headers.
3834         * amd64-linux-tdep.c: Sort headers.
3835         * amd64-linux-nat.c: Sort headers.
3836         * amd64-fbsd-tdep.c: Sort headers.
3837         * amd64-fbsd-nat.c: Sort headers.
3838         * amd64-dicos-tdep.c: Sort headers.
3839         * amd64-darwin-tdep.c: Sort headers.
3840         * amd64-bsd-nat.c: Sort headers.
3841         * alpha-tdep.c: Sort headers.
3842         * alpha-obsd-tdep.c: Sort headers.
3843         * alpha-nbsd-tdep.c: Sort headers.
3844         * alpha-mdebug-tdep.c: Sort headers.
3845         * alpha-linux-tdep.c: Sort headers.
3846         * alpha-linux-nat.c: Sort headers.
3847         * alpha-bsd-tdep.c: Sort headers.
3848         * alpha-bsd-nat.c: Sort headers.
3849         * aix-thread.c: Sort headers.
3850         * agent.c: Sort headers.
3851         * addrmap.c: Sort headers.
3852         * ada-varobj.c: Sort headers.
3853         * ada-valprint.c: Sort headers.
3854         * ada-typeprint.c: Sort headers.
3855         * ada-tasks.c: Sort headers.
3856         * ada-lang.c: Sort headers.
3857         * aarch64-tdep.c: Sort headers.
3858         * aarch64-ravenscar-thread.c: Sort headers.
3859         * aarch64-newlib-tdep.c: Sort headers.
3860         * aarch64-linux-tdep.c: Sort headers.
3861         * aarch64-linux-nat.c: Sort headers.
3862         * aarch64-fbsd-tdep.c: Sort headers.
3863         * aarch64-fbsd-nat.c: Sort headers.
3864         * aarch32-linux-nat.c: Sort headers.
3865
3866 2019-04-04  Tom Tromey  <tom@tromey.com>
3867
3868         * varobj.c (varobj_create): Update.
3869         * rust-exp.y (struct rust_parser) <update_innermost_block,
3870         lookup_symbol>: New methods.
3871         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3872         Rename.
3873         (rust_parser::rust_lookup_type)
3874         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3875         * printcmd.c (display_command, do_one_display): Update.
3876         * parser-defs.h (struct parser_state) <parser_state>: Add
3877         "tracker" parameter.
3878         (block_tracker): New member.
3879         (class innermost_block_tracker) <innermost_block_tracker>: Add
3880         "types" parameter.
3881         <reset>: Remove method.
3882         (innermost_block): Don't declare.
3883         (null_post_parser): Update.
3884         * parse.c (innermost_block): Remove global.
3885         (write_dollar_variable): Update.
3886         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3887         Remove "tracker_types" parameter.
3888         (parse_expression): Add "tracker" parameter.
3889         (parse_expression_for_completion): Update.
3890         (null_post_parser): Add "tracker" parameter.
3891         * p-exp.y: Update rules.
3892         * m2-exp.y: Update rules.
3893         * language.h (struct language_defn) <la_post_parser>: Add
3894         "tracker" parameter.
3895         * go-exp.y: Update rules.
3896         * f-exp.y: Update rules.
3897         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3898         parameter.
3899         * d-exp.y: Update rules.
3900         * c-exp.y: Update rules.
3901         * breakpoint.c (set_breakpoint_condition): Create an
3902         innermost_block_tracker.
3903         (watch_command_1): Likewise.
3904         * ada-lang.c (resolve): Add "tracker" parameter.
3905         (resolve_subexp): Likewise.
3906         * ada-exp.y (write_var_from_sym): Update.
3907
3908 2019-04-04  Tom Tromey  <tom@tromey.com>
3909
3910         * type-stack.h: New file.
3911         * type-stack.c: New file.
3912         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3913         type-stack.h.
3914         (insert_into_type_stack, insert_type, push_type, push_type_int)
3915         (insert_type_address_space, pop_type, pop_type_int)
3916         (pop_typelist, pop_type_stack, append_type_stack)
3917         (push_type_stack, get_type_stack, push_typelist)
3918         (follow_type_instance_flags, follow_types): Don't declare.
3919         * parse.c (type_stack): Remove global.
3920         (parse_exp_in_context): Update.
3921         (insert_into_type_stack, insert_type, push_type, push_type_int)
3922         (insert_type_address_space, pop_type, pop_type_int)
3923         (pop_typelist, pop_type_stack, append_type_stack)
3924         (push_type_stack, get_type_stack, push_typelist)
3925         (follow_type_instance_flags, follow_types): Remove (moved to
3926         type-stack.c).
3927         * f-exp.y (type_stack): New global.
3928         Update rules.
3929         (push_kind_type, f_parse): Update.
3930         * d-exp.y (type_stack): New global.
3931         Update rules.
3932         (d_parse): Update.
3933         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3934         Update rules.
3935         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3936         (HFILES_NO_SRCDIR): Add type-stack.h.
3937
3938 2019-04-04  Tom Tromey  <tom@tromey.com>
3939
3940         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3941         (rust_parser::convert_ast_to_expression, rust_parse)
3942         (rust_lex_test_completion, rust_lex_tests): Update.
3943         * parser-defs.h (struct expr_completion_state): New.
3944         (struct parser_state) <parser_state>: Add completion parameter.
3945         <mark_struct_expression, mark_completion_tag>: New methods.
3946         <parse_completion, m_completion_state>: New members.
3947         (prefixify_expression, null_post_parser): Update.
3948         (mark_struct_expression, mark_completion_tag): Don't declare.
3949         * parse.c (parse_completion, expout_last_struct)
3950         (expout_tag_completion_type, expout_completion_name): Remove
3951         globals.
3952         (parser_state::mark_struct_expression)
3953         (parser_state::mark_completion_tag): Now methods.
3954         (prefixify_expression): Add last_struct parameter.
3955         (prefixify_subexp): Likewise.
3956         (parse_exp_1): Update.
3957         (parse_exp_in_context): Add cstate parameter.  Update.
3958         (parse_expression_for_completion): Create an
3959         expr_completion_state.
3960         (null_post_parser): Add "completion" parameter.
3961         * p-exp.y: Update rules.
3962         (yylex): Update.
3963         * language.h (struct language_defn) <la_post_parser>: Add
3964         "completing" parameter.
3965         * go-exp.y: Update rules.
3966         (lex_one_token): Update.
3967         * expression.h (parse_completion): Don't declare.
3968         * d-exp.y: Update rules.
3969         (lex_one_token): Update rules.
3970         * c-exp.y: Update rules.
3971         (lex_one_token): Update.
3972         * ada-lang.c (resolve): Add "parse_completion" parameter.
3973         (resolve_subexp): Likewise.
3974         (ada_resolve_function): Likewise.
3975
3976 2019-04-04  Tom Tromey  <tom@tromey.com>
3977
3978         * parser-defs.h (struct parser_state) <start_arglist,
3979         end_arglist>: New methods.
3980         <arglist_len, m_funcall_chain>: New members.
3981         (arglist_len, start_arglist, end_arglist): Don't declare.
3982         * parse.c (arglist_len, funcall_chain): Remove global.
3983         (start_arglist, end_arglist): Remove functions.
3984         (parse_exp_in_context): Update.
3985         * p-exp.y: Update rules.
3986         * m2-exp.y: Update rules.
3987         * go-exp.y: Update rules.
3988         * f-exp.y: Update rules.
3989         * d-exp.y: Update rules.
3990         * c-exp.y: Update rules.
3991
3992 2019-04-04  Tom Tromey  <tom@tromey.com>
3993
3994         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3995         lex_operator, push_back>: New methods.
3996         Update all rules.
3997         (rust_parser::lex_hex, lex_escape): Rename and update.
3998         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3999         (rust_parser::lex_operator): Rename and update.
4000         (rust_parser::lex_number, rustyylex, rustyyerror)
4001         (rust_lex_test_init, rust_lex_test_sequence)
4002         (rust_lex_test_push_back, rust_lex_tests): Update.
4003         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4004         parameter.
4005         <lexptr, prev_lexptr>: New members.
4006         (lexptr, prev_lexptr): Don't declare.
4007         * parse.c (lexptr, prev_lexptr): Remove globals.
4008         (parse_exp_in_context): Update.
4009         * p-exp.y (yylex, yyerror): Update.
4010         * m2-exp.y (parse_number, yylex, yyerror): Update.
4011         * go-exp.y (lex_one_token, yyerror): Update.
4012         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4013         * d-exp.y (lex_one_token, yyerror): Update.
4014         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4015         (lex_one_token, yyerror): Update.
4016         * ada-lex.l (YY_INPUT): Update.
4017         (rewind_to_char): Update.
4018         * ada-exp.y (yyerror): Update.
4019
4020 2019-04-04  Tom Tromey  <tom@tromey.com>
4021
4022         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4023         * parser-defs.h (struct parser_state) <parser_state>: Add new
4024         parameter.
4025         <comma_terminates>: New member.
4026         (comma_terminates): Don't declare global.
4027         * parse.c (comma_terminates): Remove global.
4028         (parse_exp_in_context): Update.
4029         * p-exp.y (yylex): Update.
4030         * m2-exp.y (yylex): Update.
4031         * go-exp.y (lex_one_token): Update.
4032         * f-exp.y (yylex): Update.
4033         * d-exp.y (lex_one_token): Update.
4034         * c-exp.y (lex_one_token): Update.
4035         * ada-lex.l: Update.
4036
4037 2019-04-04  Tom Tromey  <tom@tromey.com>
4038
4039         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4040         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4041         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4042         * parser-defs.h (paren_depth): Don't declare.
4043         * parse.c (paren_depth): Remove global.
4044         (parse_exp_in_context): Update.
4045         * p-exp.y (paren_depth): New global.
4046         (pascal_parse): Initialize it.
4047         * m2-exp.y (paren_depth): New global.
4048         (m2_parse): Initialize it.
4049         * go-exp.y (paren_depth): New global.
4050         (go_parse): Initialize it.
4051         * f-exp.y (paren_depth): New global.
4052         (f_parse): Initialize it.
4053         * d-exp.y (paren_depth): New global.
4054         (d_parse): Initialize it.
4055         * c-exp.y (paren_depth): New global.
4056         (c_parse): Initialize it.
4057         * ada-lex.l (paren_depth): New global.
4058         (lexer_init): Initialize it.
4059
4060 2019-04-04  Tom Tromey  <tom@tromey.com>
4061
4062         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4063         (rust_parser::convert_ast_to_type)
4064         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4065         * parser-defs.h (struct parser_state) <parser_state>: Add
4066         parameters.  Initialize new members.
4067         <expression_context_block, expression_context_pc>: New members.
4068         * parse.c (expression_context_block, expression_context_pc):
4069         Remove globals.
4070         (parse_exp_in_context): Update.
4071         * p-exp.y: Update all rules.
4072         (yylex): Update.
4073         * m2-exp.y: Update all rules.
4074         (yylex): Update.
4075         * go-exp.y (yylex): Update.
4076         * f-exp.y (yylex): Update.
4077         * d-exp.y: Update all rules.
4078         (yylex): Update.
4079         * c-exp.y: Update all rules.
4080         (lex_one_token, classify_name, yylex, c_parse): Update.
4081         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4082
4083 2019-04-04  Tom Tromey  <tom@tromey.com>
4084
4085         * gdbarch.h, gdbarch.c: Rebuild.
4086         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4087         * stap-probe.h:
4088         (struct stap_parse_info): Replace "parser_state" with
4089         "expr_builder".
4090         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4091         (parser_state): New class.
4092         * parse.c (expr_builder): Rename.
4093         (expr_builder::release): Rename.
4094         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4095         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4096         (write_exp_elt_longcst, write_exp_elt_floatcst)
4097         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4098         (write_exp_string_vector, write_exp_bitstring)
4099         (write_exp_msymbol, mark_struct_expression)
4100         (write_dollar_variable)
4101         (insert_type_address_space, increase_expout_size): Replace
4102         "parser_state" with "expr_builder".
4103         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4104         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4105         "parser_state" with "expr_builder".
4106
4107 2019-04-04  Tom Tromey  <tom@tromey.com>
4108
4109         * rust-exp.y: Replace "parse_language" with method call.
4110         * p-exp.y:
4111         (yylex): Replace "parse_language" with method call.
4112         * m2-exp.y:
4113         (yylex): Replace "parse_language" with method call.
4114         * go-exp.y (classify_name): Replace "parse_language" with method
4115         call.
4116         * f-exp.y (yylex): Replace "parse_language" with method call.
4117         * d-exp.y (lex_one_token): Replace "parse_language" with method
4118         call.
4119         * c-exp.y:
4120         (lex_one_token, classify_name, yylex): Replace "parse_language"
4121         with method call.
4122         * ada-exp.y (find_primitive_type, type_char)
4123         (type_system_address): Replace "parse_language" with method call.
4124
4125 2019-04-04  Tom Tromey  <tom@tromey.com>
4126
4127         * rust-exp.y: Replace "parse_gdbarch" with method call.
4128         * parse.c (write_dollar_variable, insert_type_address_space):
4129         Replace "parse_gdbarch" with method call.
4130         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4131         call.
4132         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4133         call.
4134         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4135         "parse_gdbarch" with method call.
4136         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4137         with method call.
4138         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4139         "parse_gdbarch" with method call.
4140         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4141         "parse_gdbarch" with method call.
4142         * c-exp.y (parse_type, parse_number, classify_name): Replace
4143         "parse_gdbarch" with method call.
4144         * ada-lex.l: Replace "parse_gdbarch" with method call.
4145         * ada-exp.y (parse_type, find_primitive_type, type_char)
4146         (type_system_address): Replace "parse_gdbarch" with method call.
4147
4148 2019-04-04  Tom Tromey  <tom@tromey.com>
4149
4150         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4151         * stap-probe.c (stap_parse_argument): Update.
4152         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4153         initial_size parameter.
4154         * rust-exp.y (rust_lex_tests): Update.
4155         * parse.c (parser_state): Update.
4156         (parse_exp_in_context): Update.
4157         * parser-defs.h (struct parser_state) <parser_state>: Remove
4158         "initial_size" parameter.
4159
4160 2019-04-04  Tom Tromey  <tom@tromey.com>
4161
4162         * parser-defs.h (increase_expout_size): Don't declare.
4163         * parse.c (increase_expout_size): Now static.
4164
4165 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4166
4167         * gnu-nat.c (gnu_nat_target::wait): Fix
4168         target_waitstatus_to_string call.
4169
4170 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4171
4172         * eval.c (evaluate_subexp_standard): Handle internal functions
4173         during Fortran function call handling.
4174
4175 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4176
4177         * NEWS: Mention new internal functions.
4178         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4179         (read_base_type): Use dwarf2_init_complex_target_type.
4180         * value.c (creal_internal_fn): New function.
4181         (cimag_internal_fn): New function.
4182         (_initialize_values): Register new internal functions.
4183
4184 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4185
4186         * infrun.c (stop_all_threads): If debug_infrun, always
4187         trace the wait status after wait_one, using
4188         target_waitstatus_to_string and target_pid_to_str.
4189         (handle_inferior_event): Replace various trace of
4190         wait status kind by a single trace.
4191         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4192         wait status kind image by target_waitstatus_to_string.
4193         * target/waitstatus.c (target_waitstatus_to_string): Fix
4194         obsolete comment.
4195
4196 2019-04-01  Tom Tromey  <tromey@adacore.com>
4197
4198         PR symtab/23331:
4199         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4200
4201 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4202             Pedro Alves  <palves@redhat.com>
4203
4204         * top.c (quit_force): Call 'finalize_values'.
4205         * value.c (finalize_values): New function.
4206         * value.h (finalize_values): Declare.
4207
4208 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4209
4210         * NEWS: Announce $_gdb_major and $_gdb_minor.
4211
4212         * top.c (init_gdb_version_vars): New function.
4213         (gdb_init): Call init_gdb_version_vars.
4214
4215 2019-03-29  Tom Tromey  <tromey@adacore.com>
4216
4217         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4218         help text.  Remove dead code.
4219
4220 2019-03-29  Keith Seitz  <keiths@redhat.com>
4221
4222         From Siddhesh Poyarekar:
4223         * f-lang.h (f77_get_upperbound): Return LONGEST.
4224         (f77_get_lowerbound): Likewise.
4225         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4226         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4227         print them.
4228         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4229         plongest to format print it.
4230         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4231         (f77_get_upperbound): Likewise.
4232         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4233         LOWER_BOUND to LONGEST.
4234         (f77_create_arrayprint_offset_tbl): Likewise.
4235
4236 2019-03-29  Keith Seitz  <keiths@redhat.com>
4237
4238         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4239         %s/pulongest for TYPE_LENGTH instead of %d in format
4240         strings.
4241         * ada-typerint.c (ada_print_type): Likewise.
4242         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4243         * compile/compile-c-support.c (generate_register_struct): Likewise.
4244         * gdbtypes.c (recursive_dump_type): Likewise.
4245         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4246         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4247         instead of %d in format strings.
4248         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4249         to std::min to ULONGEST.
4250         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4251         instead of %d in format strings.
4252         * tracepoint.c (info_scope_command): Likewise.
4253         * typeprint.c (print_offset_data::update)
4254         (print_offset_data::finish): Likewise.
4255         * xtensa-tdep.c (xtensa_store_return_value)
4256         (xtensa_push_dummy_call): Likewise.
4257
4258 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4259
4260         * windows-nat.c (display_selector): Fixed format specifications
4261         for 64-bit Cygwin.
4262
4263 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4264
4265         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4266
4267 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4268
4269         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4270         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4271         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4272         (nios2_linux_init_abi): Install it.
4273
4274 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4275
4276         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4277
4278 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4279
4280         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4281
4282 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4283             Tom Tromey  <tromey@adacore.com>
4284
4285         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4286
4287 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4288
4289         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4290         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4291         method to compute the bounds of range types. Also print "[evaluated]"
4292         if the bounds' values come from a dynamic evaluation.
4293
4294 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4295
4296         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4297         whitespace when pretty printing is on.
4298
4299 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4300
4301         * ppc-linux-nat.c: Add include.
4302
4303 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4304
4305         * NEWS: Mention AArch64 Pointer Authentication.
4306
4307 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4308
4309         * arm-linux-nat.c: Add include.
4310
4311 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4312
4313         * source-cache.c (source_cache::get_source_lines): Re-read
4314         fullname after calling open_source_file.
4315
4316 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4317
4318         * NEWS: Mention TLS support for FreeBSD.
4319
4320 2019-03-25  Tom Tromey  <tromey@adacore.com>
4321
4322         * minsyms.c (BUNCH_SIZE): Update comment.
4323         (~minimal_symbol_reader): Remove old comment.
4324         (compact_minimal_symbols): Update comment.
4325         (minimal_symbol_reader::install): Remove old comment.  Update
4326         other comments.
4327
4328 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4329
4330         * s390-linux-nat.c: Add include.
4331
4332 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4333
4334         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4335         Call linux_get_hwcap.
4336         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4337         Likewise.
4338         (aarch64_linux_get_hwcap): Remove function.
4339         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4340         declaration.
4341         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4342         linux_get_hwcap.
4343         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4344         * linux-tdep.c (linux_get_hwcap): Add function.
4345         (linux_get_hwcap2): Likewise.
4346         * linux-tdep.h (linux_get_hwcap): Add declaration.
4347         (linux_get_hwcap2): Likewise.
4348         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4349         (ppc_linux_get_hwcap2): Likewise.
4350         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4351         linux_get_hwcap.
4352         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4353         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4354         (ppc_linux_nat_target::read_description): Likewise.
4355         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4356         * s390-linux-nat.c: Likewise.
4357         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4358
4359 2019-03-24  Tom Tromey  <tom@tromey.com>
4360
4361         * ada-lang.c (standard_lookup): Simplify initialization.
4362         (ada_lookup_symbol_nonlocal): Simplify return.
4363         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4364         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4365         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4366         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4367         initialization.
4368         * solib.c (solib_global_lookup): Simplify.
4369         * symtab.c (null_block_symbol): Remove.
4370         (symbol_cache_lookup): Simplify returns.
4371         (lookup_language_this): Simplify returns.
4372         (lookup_symbol_aux): Simplify return.
4373         (lookup_local_symbol): Simplify returns.
4374         (lookup_global_symbol_from_objfile): Simplify return.
4375         (lookup_symbol_in_objfile_symtabs)
4376         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4377         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4378         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4379         * cp-namespace.c (cp_lookup_bare_symbol)
4380         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4381         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4382         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4383         (cp_lookup_symbol_via_imports): Simplify initialization.
4384         (find_symbol_in_baseclass): Likewise.
4385         * symtab.h (null_block_symbol): Remove.
4386         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4387         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4388         (d_lookup_symbol_module): Likewise.
4389         (find_symbol_in_baseclass): Simplify initialization.
4390
4391 2019-03-24  Tom Tromey  <tom@tromey.com>
4392
4393         * expression.h: Don't include symtab.h.
4394         (struct block): Forward declare.
4395
4396 2019-03-24  Tom Tromey  <tom@tromey.com>
4397
4398         * c-exp.y (typebase): Remove casts.
4399         * gdbtypes.c (lookup_unsigned_typename, )
4400         (lookup_signed_typename): Remove cast.
4401         * eval.c (parse_to_comma_and_eval): Remove cast.
4402         * parse.c (write_dollar_variable): Remove cast.
4403         * block.h (struct block) <superblock>: Now const.
4404         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4405         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4406         (map_block): Make "block" const.
4407         * symfile.h (struct quick_symbol_functions)
4408         <map_matching_symbols>: Constify block argument to "callback".
4409         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4410         const.
4411         (find_pc_sect_compunit_symtab): Make "b" const.
4412         (find_symbol_at_address): Likewise.
4413         (search_symbols): Likewise.
4414         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4415         (dw2_debug_names_lookup_symbol): Likewise.
4416         (dw2_map_matching_symbols): Update.
4417         * p-valprint.c (pascal_val_print): Remove "block".
4418         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4419         (aux_add_nonlocal_symbols): Make "block" const.
4420         (resolve_subexp): Remove cast.
4421         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4422         const.
4423         (iterate_over_file_blocks): Likewise.
4424         * f-exp.y (%union) <bval>: Remove.
4425         * coffread.c (patch_opaque_types): Make "b" const.
4426         * spu-tdep.c (spu_catch_start): Make "block" const.
4427         * c-valprint.c (print_unpacked_pointer): Remove "block".
4428         * symmisc.c (dump_symtab_1): Make "b" const.
4429         (block_depth): Make "block" const.
4430         * d-exp.y (%union) <bval>: Remove.
4431         * cp-support.h (cp_lookup_rtti_type): Update.
4432         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4433         * psymtab.c (psym_lookup_symbol): Make "block" const.
4434         (maintenance_check_psymtabs): Make "b" const.
4435         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4436         (enumerate_locals, enumerate_args): Update.
4437         * python/py-symtab.c (stpy_global_block): Make "block" const.
4438         (stpy_static_block): Likewise.
4439         * inline-frame.c (block_starting_point_at): Make "new_block"
4440         const.
4441         * block.c (find_block_in_blockvector): Make return type const.
4442         (blockvector_for_pc_sect): Make "b" const.
4443         (find_block_in_blockvector): Make "b" const.
4444
4445 2019-03-23  Tom Tromey  <tom@tromey.com>
4446
4447         * varobj.c (varobj_create): Update.
4448         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4449         * printcmd.c (display_command, do_one_display): Don't reset
4450         innermost_block.
4451         * parser-defs.h (enum innermost_block_tracker_type): Move to
4452         expression.h.
4453         (innermost_block): Update comment.
4454         * parse.c (parse_exp_1): Add tracker_types parameter.
4455         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4456         tracker_types parameter.  Reset innermost_block.
4457         (parse_exp_in_context): Remove.
4458         (parse_expression_for_completion): Update.
4459         * objfiles.c (~objfile): Don't reset expression_context_block or
4460         innermost_block.
4461         * expression.h (enum innermost_block_tracker_type): Move from
4462         parser-defs.h.
4463         (parse_exp_1): Add tracker_types parameter.
4464         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4465         reset innermost_block.
4466
4467 2019-03-23  Tom Tromey  <tom@tromey.com>
4468
4469         * objfiles.h: Include bcache.h.
4470
4471 2019-03-23  Tom Tromey  <tom@tromey.com>
4472
4473         * linespec.c (get_current_search_block): Use
4474         scoped_restore_current_language.
4475         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4476
4477 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4478             Jiong Wang  <jiong.wang@arm.com>
4479
4480         * aarch64-linux-tdep.c
4481         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4482         section.
4483         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4484
4485 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4486             Jiong Wang  <jiong.wang@arm.com>
4487
4488         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4489         instructions.
4490         (aarch64_analyze_prologue_test): Add PACIASP test.
4491         (aarch64_prologue_prev_register): Unmask PC value.
4492
4493 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4494             Jiong Wang  <jiong.wang@arm.com>
4495
4496         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4497         (aarch64_dwarf2_prev_register): Unmask PC value.
4498         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4499         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4500         DW_CFA_AARCH64_negate_ra_state.
4501         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4502
4503 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4504             Jiong Wang  <jiong.wang@arm.com>
4505
4506         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4507         registers.
4508         (aarch64_pseudo_register_name): Likewise.
4509         (aarch64_pseudo_register_type): Likewise.
4510         (aarch64_pseudo_register_reggroup_p): Likewise.
4511         (aarch64_gdbarch_init): Add pauth registers.
4512         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4513         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4514         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4515         (struct gdbarch_tdep): Add regnum for ra_state.
4516
4517 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4518             Jiong Wang  <jiong.wang@arm.com>
4519
4520         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4521
4522 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4523             Jiong Wang  <jiong.wang@arm.com>
4524
4525         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4526         function.
4527         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4528         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4529         (aarch64_gdbarch_init): Add puth registers.
4530         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4531         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4532         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4533
4534 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4535             Jiong Wang  <jiong.wang@arm.com>
4536
4537         * aarch64-linux-nat.c
4538         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4539         * aarch64-linux-tdep.c
4540         (aarch64_linux_core_read_description): Likewise.
4541         (aarch64_linux_get_hwcap): New function.
4542         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4543         (aarch64_linux_get_hwcap): New declaration.
4544
4545 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4546             Jiong Wang  <jiong.wang@arm.com>
4547
4548         * aarch64-linux-nat.c
4549         (aarch64_linux_nat_target::read_description): Add pauth param.
4550         * aarch64-linux-tdep.c
4551         (aarch64_linux_core_read_description): Likewise.
4552         * aarch64-tdep.c (struct target_desc): Add in pauth.
4553         (aarch64_read_description): Add pauth param.
4554         (aarch64_gdbarch_init): Likewise.
4555         * aarch64-tdep.h (aarch64_read_description): Likewise.
4556         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4557         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4558         * features/Makefile: Add new files.
4559         * features/aarch64-pauth.c: New file.
4560         * features/aarch64-pauth.xml: New file.
4561
4562 2019-03-20  Tom Tromey  <tromey@adacore.com>
4563
4564         * infrun.c (handle_inferior_event): Rename from
4565         handle_inferior_event_1.  Create a scoped_value_mark.
4566         (handle_inferior_event): Remove.
4567
4568 2019-03-19  Tom Tromey  <tromey@adacore.com>
4569
4570         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4571         * infrun.h (print_stop_event): Add "displays" parameter.
4572         * infrun.c (print_stop_event): Add "displays" parameter.
4573
4574 2019-03-19  Pedro Alves  <palves@redhat.com>
4575
4576         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4577         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4578         to -1.  Fix TABs vs spaces.
4579         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4580         * tui/tui-out.h (tui_ui_out) Add intro comments.
4581         <m_line, m_start_of_line>: In-class initialize, and add describing
4582         comment.
4583
4584 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4585
4586         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4587         variable names.
4588         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4589
4590 2019-03-18  Pedro Alves  <palves@redhat.com>
4591             Eli Zaretskii <eliz@gnu.org>
4592
4593         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4594         m_line and m_start_of_line.
4595
4596 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4597
4598         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4599         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4600         it returns a newline.  This fixes a regression in TU mode, whereby
4601         the next line is output on the same screen line as the user input.
4602
4603 2019-03-18  Tom Tromey  <tromey@adacore.com>
4604
4605         * minsyms.c (minimal_symbol_reader::install): Remove call to
4606         obstack_blank.
4607
4608 2019-03-18  Pedro Alves  <palves@redhat.com>
4609
4610         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4611         New globals.
4612         (apply_style): New, factored out from ...
4613         (apply_ansi_escape): ... this.  Handle reverse video mode.
4614         (tui_set_reverse_mode): New function.
4615         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4616         * tui/tui-winsource.c (tui_show_source_line): Use
4617         tui_set_reverse_mode instead of setting A_STANDOUT.
4618         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4619         New setter methods.
4620
4621 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4622
4623         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4624         Handle tabs.
4625
4626 2019-03-18  Tom Tromey  <tromey@adacore.com>
4627
4628         * ada-lang.c (empty_array): Add "high" parameter.
4629         (ada_evaluate_subexp): Update.
4630
4631 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4632
4633         * unittests/string_view-selftests.c: Define
4634         _initialize_string_view_selftests unconditionally.
4635
4636 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4637
4638         PR gdb/24350
4639         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4640
4641 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4642
4643         PR gdb/24351
4644         * windows-nat.c (display_selector): Fix format specifiers.
4645
4646 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4647
4648         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4649         tui_refill_source_window instead of tui_refresh_win, to update the
4650         current execution line.  This fixes redisplay of the current line
4651         when stepping through the code with "next" or "step".
4652
4653 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4654
4655         * source-cache.c (source_cache::get_source_lines): Call
4656         find_source_lines to initialize s->nlines.  This fixes vertical
4657         scrolling of TUI source window when the DOWN arrow is pressed.
4658
4659 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4660
4661         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4662         linux-thread-db.c (_initialize_thread_db): Likewise.
4663
4664 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4665
4666         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4667         wclrtoeol in tui_show_source_line".  This reverts changes made in
4668         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4669
4670 2019-03-15  Tom Tromey  <tom@tromey.com>
4671
4672         * symtab.h (struct minimal_symbol): Derive from
4673         general_symbol_info.
4674         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4675         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4676         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4677         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4678         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4679         (MSYMBOL_SEARCH_NAME): Update.
4680         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4681         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4682         * minsyms.c (minimal_symbol_reader::record_full): Update.
4683
4684 2019-03-15  Tom Tromey  <tom@tromey.com>
4685
4686         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4687
4688 2019-03-15  Tom Tromey  <tom@tromey.com>
4689
4690         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4691         unique_xmalloc_ptr.
4692         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4693         Update.
4694         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4695         (build_minimal_symbol_hash_tables)
4696         (minimal_symbol_reader::install): Update.
4697
4698 2019-03-15  Tom Tromey  <tom@tromey.com>
4699
4700         * symtab.c (create_demangled_names_hash): Update.
4701         (symbol_set_names): Update.
4702         * objfiles.h (struct objfile_per_bfd_storage)
4703         <demangled_names_hash>: Now an htab_up.
4704         * objfiles.c (objfile_per_bfd_storage): Simplify.
4705
4706 2019-03-15  Tom Tromey  <tom@tromey.com>
4707
4708         * objfiles.h (struct objfile_per_bfd_storage): Declare
4709         destructor.
4710         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4711         New.
4712         (get_objfile_bfd_data): Use new.  Don't initialize
4713         language_of_main.
4714         (free_objfile_per_bfd_storage): Remove.
4715         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4716
4717 2019-03-15  Tom Tromey  <tom@tromey.com>
4718
4719         * symfile.c (reread_symbols): Update.
4720         * objfiles.c (objfile::objfile): Update.
4721         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4722         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4723         comment.
4724         (minimal_symbol_reader::install): Update.
4725         (terminate_minimal_symbol_table): Remove.
4726         * jit.c (jit_object_close_impl): Update.
4727
4728 2019-03-15  Tom Tromey  <tom@tromey.com>
4729
4730         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4731         initializations.
4732
4733 2019-03-15  Tom Tromey  <tom@tromey.com>
4734
4735         * objfiles.h (struct objfile_per_bfd_storage)
4736         <demangled_hash_languages>: Now a bitset.
4737         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4738         (lookup_minimal_symbol): Update.
4739
4740 2019-03-15  Tom Tromey  <tom@tromey.com>
4741
4742         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4743         Don't return the symbol.
4744         * coffread.c (record_minimal_symbol): Use record_full.
4745
4746 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4747
4748         The MS-Windows port of ncurses fails to switch to a color pair if
4749         one or both of the colors are the implicit default colors.  This
4750         change records the default colors when TUI is initialized, and
4751         then specifies them explicitly when a color pair uses the default
4752         colors.  This allows color styling in TUI mode on MS-Windows.
4753
4754         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4755         ncurses_norm_attr.
4756         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4757         colors in ncurses_norm_attr.
4758         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4759         "none", replace it with the default color recorded in
4760         ncurses_norm_attr.
4761
4762 2019-03-14  Tom Tromey  <tromey@adacore.com>
4763
4764         * source-cache.h (class source_cache) <get_source_lines>: Return
4765         std::string.
4766         * source-cache.c (source_cache::extract_lines): Handle case where
4767         first_pos==npos.  Return std::string.
4768         (source_cache::get_source_lines): Update.
4769
4770 2019-03-14  Tom Tromey  <tromey@adacore.com>
4771
4772         * NEWS: Add item for "style sources" commands.
4773         * source-cache.c (source_cache::get_source_lines): Check
4774         source_styling.
4775         * cli/cli-style.c (source_styling): New global.
4776         (_initialize_cli_style): Add "style sources" commands.
4777         (show_style_sources): New function.
4778         * cli/cli-style.h (source_styling): Declare.
4779
4780 2019-03-14  Pedro Alves  <palves@redhat.com>
4781             Tom Tromey  <tromey@adacore.com>
4782
4783         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4784         * tui/tui-winsource.c (tui_refill_source_window): New function,
4785         from...
4786         (tui_horizontal_source_scroll): ... here.  Move some logic.
4787         * cli/cli-style.c (set_style_enabled): Notify new observable.
4788         * tui/tui-hooks.c (tui_redisplay_source): New function.
4789         (tui_attach_detach_observers): Attach or detach
4790         tui_redisplay_source.
4791         * observable.h (source_styling_changed): New observable.
4792         * observable.c: Define source_styling_changed observable.
4793
4794 2019-03-13  Tom Tromey  <tromey@adacore.com>
4795
4796         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4797         (i386_gnu_nat_target::store_registers): Update.
4798         * target-debug.h (target_debug_print_std_string): New macro.
4799         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4800         * windows-tdep.c (display_one_tib): Update.
4801         * tui/tui-stack.c (tui_make_status_line): Update.
4802         * top.c (print_inferior_quit_action): Update.
4803         * thread.c (thr_try_catch_cmd): Update.
4804         (add_thread_with_info): Update.
4805         (thread_target_id_str): Update.
4806         (thr_try_catch_cmd): Update.
4807         (thread_command): Update.
4808         (thread_find_command): Update.
4809         * record-btrace.c (record_btrace_target::info_record)
4810         (record_btrace_resume_thread, record_btrace_target::resume)
4811         (record_btrace_cancel_resume, record_btrace_step_thread)
4812         (record_btrace_target::wait, record_btrace_target::wait)
4813         (record_btrace_target::wait, record_btrace_target::stop): Update.
4814         * progspace.c (print_program_space): Update.
4815         * process-stratum-target.c
4816         (process_stratum_target::thread_address_space): Update.
4817         * linux-fork.c (linux_fork_mourn_inferior)
4818         (detach_checkpoint_command, info_checkpoints_command)
4819         (linux_fork_context): Update.
4820         (linux_fork_detach): Update.
4821         (class scoped_switch_fork_info): Update.
4822         (delete_checkpoint_command): Update.
4823         * infrun.c (follow_fork_inferior): Update.
4824         (follow_fork_inferior): Update.
4825         (proceed_after_vfork_done): Update.
4826         (handle_vfork_child_exec_or_exit): Update.
4827         (follow_exec): Update.
4828         (displaced_step_prepare_throw): Update.
4829         (displaced_step_restore): Update.
4830         (start_step_over): Update.
4831         (resume_1): Update.
4832         (clear_proceed_status_thread): Update.
4833         (proceed): Update.
4834         (print_target_wait_results): Update.
4835         (do_target_wait): Update.
4836         (context_switch): Update.
4837         (stop_all_threads): Update.
4838         (restart_threads): Update.
4839         (finish_step_over): Update.
4840         (handle_signal_stop): Update.
4841         (switch_back_to_stepped_thread): Update.
4842         (keep_going_pass_signal): Update.
4843         (print_exited_reason): Update.
4844         (normal_stop): Update.
4845         * inferior.c (inferior_pid_to_str): Change return type.
4846         (print_selected_inferior): Update.
4847         (add_inferior): Update.
4848         (detach_inferior): Update.
4849         * dummy-frame.c (fprint_dummy_frames): Update.
4850         * dcache.c (dcache_info_1): Update.
4851         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4852         (btrace_fetch, btrace_clear): Update.
4853         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4854         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4855         type.
4856         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4857         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4858         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4859         * gdbarch.c, gdbarch.h: Rebuild.
4860         * gdbarch.sh (core_pid_to_str): Change return type.
4861         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4862         return type.
4863         (windows_nat_target::pid_to_str): Change return type.
4864         (windows_delete_thread): Update.
4865         (windows_nat_target::attach): Update.
4866         (windows_nat_target::files_info): Update.
4867         * target-delegates.c: Rebuild.
4868         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4869         return type.
4870         (sol_thread_target::pid_to_str): Change return type.
4871         * remote.c (class remote_target) <pid_to_str>: Change return
4872         type.
4873         (remote_target::pid_to_str): Change return type.
4874         (extended_remote_target::attach, remote_target::remote_stop_ns)
4875         (remote_target::remote_notif_remove_queued_reply)
4876         (remote_target::push_stop_reply, remote_target::disable_btrace):
4877         Update.
4878         (extended_remote_target::attach): Update.
4879         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4880         type.
4881         (gdbsim_target::pid_to_str): Change return type.
4882         * ravenscar-thread.c (struct ravenscar_thread_target)
4883         <pid_to_str>: Change return type.
4884         (ravenscar_thread_target::pid_to_str): Change return type.
4885         * procfs.c (class procfs_target) <pid_to_str>: Change return
4886         type.
4887         (procfs_target::pid_to_str): Change return type.
4888         (procfs_target::attach): Update.
4889         (procfs_target::detach): Update.
4890         (procfs_target::fetch_registers): Update.
4891         (procfs_target::store_registers): Update.
4892         (procfs_target::wait): Update.
4893         (procfs_target::files_info): Update.
4894         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4895         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4896         return type.
4897         (nto_procfs_target::pid_to_str): Change return type.
4898         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4899         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4900         return type.
4901         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4902         (exit_lwp): Update.
4903         (attach_proc_task_lwp_callback, get_detach_signal)
4904         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4905         (linux_nat_target::resume, wait_lwp, stop_callback)
4906         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4907         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4908         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4909         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4910         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4911         type.
4912         (inf_ptrace_target::attach): Update.
4913         (inf_ptrace_target::files_info): Update.
4914         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4915         type.
4916         (go32_nat_target::pid_to_str): Change return type.
4917         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4918         (gnu_nat_target::wait): Update.
4919         (gnu_nat_target::wait): Update.
4920         (gnu_nat_target::resume): Update.
4921         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4922         (fbsd_nat_target::wait): Update.
4923         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4924         type.
4925         (darwin_nat_target::attach): Update.
4926         * corelow.c (class core_target) <pid_to_str>: Change return type.
4927         (core_target::pid_to_str): Change return type.
4928         * target.c (normal_pid_to_str): Change return type.
4929         (default_pid_to_str): Likewise.
4930         (target_pid_to_str): Change return type.
4931         (target_translate_tls_address): Update.
4932         (target_announce_detach): Update.
4933         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4934         return type.
4935         (bsd_uthread_target::pid_to_str): Change return type.
4936         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4937         type.
4938         (bsd_kvm_target::pid_to_str): Change return type.
4939         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4940         return type.
4941         (aix_thread_target::pid_to_str): Change return type.
4942         * target.h (struct target_ops) <pid_to_str>: Change return type.
4943         (target_pid_to_str, normal_pid_to_str): Likewise.
4944         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4945         type.
4946         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4947         type.
4948         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4949         return type.
4950         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4951         type.
4952         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4953         type.
4954         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4955         return type.
4956
4957 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4958
4959         * NEWS: Mention that the new default MI version is 3.  Mention
4960         changes to the output of commands and events that deal with
4961         multi-location breakpoints.
4962         * breakpoint.c: Include "mi/mi-out.h".
4963         (print_one_breakpoint): Change output syntax if using MI version
4964         >= 3.
4965         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4966         New.
4967         (mi_multi_location_breakpoint_output_fixed): New.
4968         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4969         (mi_cmd_fix_multi_location_breakpoint_output): New.
4970         (mi_multi_location_breakpoint_output_fixed): New.
4971         * mi/mi-cmds.c (mi_cmds): Register command
4972         -fix-multi-location-breakpoint-output.
4973         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4974         interpreter "mi".
4975
4976 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4977
4978         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4979         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4980         instantiate mi_ui_out based on interpreter name.
4981         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4982         * mi/mi-main.c (mi_load_progress): Likewise.
4983
4984 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4985
4986         * NEWS: Combine separate "New targets" sections for 8.3.
4987
4988 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4989
4990         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4991         (ppcfbsd_init_abi): Install gdbarch
4992         "fetch_tls_load_module_address" and "get_thread_local_address"
4993         methods.
4994
4995 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4996
4997         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4998         (riscv_fbsd_init_abi): Install gdbarch
4999         "fetch_tls_load_module_address" and "get_thread_local_address"
5000         methods.
5001
5002 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5003
5004         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5005         (i386fbsd_init_abi): Install gdbarch
5006         "fetch_tls_load_module_address" and "get_thread_local_address"
5007         methods.
5008
5009 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5010
5011         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5012         (amd64fbsd_init_abi): Install gdbarch
5013         "fetch_tls_load_module_address" and "get_thread_local_address"
5014         methods.
5015
5016 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5017
5018         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5019         (struct fbsd_pspace_data): New type.
5020         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5021         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5022         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5023         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5024         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5025
5026 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5027
5028         * gdbtypes.c (lookup_struct_elt): New function.
5029         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5030         * gdbtypes.h (struct struct_elt): New type.
5031         (lookup_struct_elt): New prototype.
5032
5033 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5034
5035         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5036         remove disabled code block.
5037
5038 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5039
5040         * gdbarch.sh (get_thread_local_address): New method.
5041         * gdbarch.h, gdbarch.c: Regenerate.
5042         * target.c (target_translate_tls_address): Use
5043         gdbarch_get_thread_local_address if present instead of
5044         target::get_thread_local_address.
5045
5046 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5047
5048         * target.h (target::get_thread_local_address): Update comment.
5049
5050 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5051
5052         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5053         objfile->separate_debug_objfile_backlink if not NULL.
5054
5055 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5056
5057         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5058         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5059         (amd64bsd_store_inferior_registers): Likewise.
5060         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5061         Enable segment base registers.
5062         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5063         PT_GETFSBASE and PT_GETGSBASE.
5064         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5065         PT_SETGSBASE.
5066         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5067         segment base registers.
5068         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5069
5070 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5071
5072         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5073         Update calls to i386_target_description to add 'segments'
5074         parameter.
5075         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5076         add segment base registers.
5077         * arch/i386.c (i386_create_target_description): Add 'segments'
5078         parameter to enable segment base registers.
5079         * arch/i386.h (i386_create_target_description): Likewise.
5080         * features/i386/32bit-segments.xml: New file.
5081         * features/i386/32bit-segments.c: Generate.
5082         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5083         call to i386_target_description to add 'segments' parameter.
5084         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5085         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5086         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5087         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5088         if feature is present.
5089         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5090         Add 'segments' parameter to call to i386_target_description.
5091         (i386_target_description): Add 'segments' parameter to enable
5092         segment base registers.
5093         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5094         to call to i386_target_description.
5095         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5096         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5097         Define I386_NUM_REGS.
5098         (i386_target_description): Add 'segments' parameter to enable
5099         segment base registers.
5100
5101 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5102
5103         PR/24325
5104         * source-cache.c: #undef open and close, to avoid unresolved
5105         externals during linking.
5106
5107 2019-03-12  Tom Tromey  <tromey@adacore.com>
5108
5109         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5110         const.  Add initializers.
5111         (_initialize_remote): Don't initialize ptid globals.
5112
5113 2019-03-12  Pedro Alves  <palves@redhat.com>
5114
5115         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5116
5117 2019-03-12  Pedro Alves  <palves@redhat.com>
5118
5119         * cp-name-parser.y (main): Remove unused 'len' variable.
5120
5121 2019-03-12  Tom Tromey  <tromey@adacore.com>
5122
5123         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5124         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5125
5126 2019-03-12  Tom Tromey  <tromey@adacore.com>
5127
5128         * linux-nat.c (iterate_over_lwps): Update.
5129         (stop_callback): Remove parameter.
5130         (stop_wait_callback, detach_callback, resume_set_callback)
5131         (select_singlestep_lwp_callback, set_ignore_sigint)
5132         (status_callback, resumed_callback, resume_clear_callback)
5133         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5134         data parameter.
5135         (linux_nat_target::detach, linux_nat_target::resume)
5136         (linux_stop_and_wait_all_lwps, select_event_lwp)
5137         (linux_nat_filter_event, linux_nat_wait_1)
5138         (linux_nat_target::kill, linux_nat_target::stop)
5139         (linux_nat_target::stop): Update.
5140         (linux_nat_resume_callback): Change type.
5141         (resume_stopped_resumed_lwps, count_events_callback)
5142         (select_event_lwp_callback): Likewise.
5143         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5144         * arm-linux-nat.c (struct update_registers_data): Remove.
5145         (update_registers_callback): Change type.
5146         (arm_linux_insert_hw_breakpoint1): Update.
5147         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5148         parameter.
5149         (x86_linux_dr_set_addr): Update.
5150         (x86_linux_dr_set_control): Update.
5151         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5152         (iterate_over_lwps): Use gdb::function_view.
5153         * nat/aarch64-linux-hw-point.c (struct
5154         aarch64_dr_update_callback_param): Remove.
5155         (debug_reg_change_callback): Change type.
5156         (aarch64_notify_debug_reg_change): Update.
5157         * s390-linux-nat.c (s390_refresh_per_info): Update.
5158
5159 2019-03-11  Tom Tromey  <tromey@adacore.com>
5160
5161         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5162         redundant assignment to "this_cu".
5163
5164 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5165
5166         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5167
5168 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5169
5170         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5171         from...
5172         (rank_one_type): ... this.
5173
5174 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5175
5176         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5177         from...
5178         (rank_one_type): ... this.
5179
5180 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5181
5182         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5183         from...
5184         (rank_one_type): ... this.
5185
5186 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5187
5188         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5189         from...
5190         (rank_one_type): ... this.
5191
5192 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5193
5194         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5195         from...
5196         (rank_one_type): ... this.
5197
5198 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5199
5200         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5201         from...
5202         (rank_one_type): ... this.
5203
5204 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5205
5206         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5207         from...
5208         (rank_one_type): ... this.
5209
5210 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5211
5212         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5213         from...
5214         (rank_one_type): ... this.
5215
5216 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5217
5218         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5219         from...
5220         (rank_one_type): ... this.
5221
5222 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5223
5224         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5225         from...
5226         (rank_one_type): ... this.
5227
5228 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5229
5230         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5231         from...
5232         (rank_one_type): ... this.
5233
5234 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5235
5236         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5237         from...
5238         (rank_one_type): ... this.
5239
5240 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5241
5242         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5243         inferior-events' shows the example events.
5244
5245 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5246
5247         Support styling on native MS-Windows console
5248
5249         PR/24315
5250         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5251         on MS-Windows if $TERM is not defined.
5252
5253         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5254
5255         * posix-hdep.c (gdb_console_fputs):
5256         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5257         functions.
5258         * ui-file.h (gdb_console_fputs): Add prototype.
5259
5260         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5261         back to fputs only if the former returns zero.
5262
5263 2019-03-07  Tom Tromey  <tom@tromey.com>
5264
5265         * symmisc.c (print_symbol_bcache_statistics): Update.
5266         (print_objfile_statistics): Update.
5267         * symfile.c (allocate_symtab): Update.
5268         * stabsread.c: Don't include bcache.h.
5269         * psymtab.h (struct psymbol_bcache): Don't declare.
5270         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5271         (psymbol_bcache_init, psymbol_bcache_free)
5272         (psymbol_bcache_get_bcache): Don't declare.
5273         * psymtab.c (struct psymbol_bcache): Remove.
5274         (psymtab_storage::psymtab_storage): Update.
5275         (psymtab_storage::~psymtab_storage): Update.
5276         (psymbol_bcache_init, psymbol_bcache_free)
5277         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5278         (add_psymbol_to_bcache): Update.
5279         (allocate_psymtab): Update.
5280         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5281         macro_cache>: No longer pointers.
5282         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5283         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5284         * macrotab.c (macro_bcache): Update.
5285         * macroexp.c: Don't include bcache.h.
5286         * gdbtypes.c (check_types_worklist): Update.
5287         (types_deeply_equal): Remove TRY/CATCH.  Update.
5288         * elfread.c (elf_symtab_read): Update.
5289         * dwarf2read.c: Don't include bcache.h.
5290         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5291         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5292         (print_bcache_statistics, bcache_memory_used): Don't declare.
5293         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5294         methods.  Rename all data members.
5295         * bcache.c (struct bcache): Move to bcache.h.
5296         (bcache::expand_hash_table): Rename from expand_hash_table.
5297         (bcache): Remove.
5298         (bcache::insert): Rename from bcache_full.
5299         (bcache::compare): Rename from bcache_compare.
5300         (bcache_xmalloc): Remove.
5301         (bcache::~bcache): Rename from bcache_xfree.
5302         (bcache::print_statistics): Rename from print_bcache_statistics.
5303         (bcache::memory_used): Rename from bcache_memory_used.
5304
5305 2019-03-07  Pedro Alves  <palves@redhat.com>
5306
5307         * infrun.c (normal_stop): Also check for
5308         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5309
5310 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5311
5312         * f-lang.c (value_from_host_double): Moved to...
5313         * value.c (value_from_host_double): ...here.
5314         * value.h (value_from_host_double): Declare.
5315         * guile/scm-math.c (vlscm_convert_typed_number): Use
5316         value_from_host_double.
5317         (vlscm_convert_number): Likewise.
5318         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5319         * python/py-value.c (convert_value_from_python): Likewise.
5320
5321 2019-03-06  Tom Tromey  <tom@tromey.com>
5322
5323         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5324
5325 2019-03-06  Tom Tromey  <tom@tromey.com>
5326
5327         * utils.h (free_current_contents): Don't declare.
5328         * utils.c (free_current_contents): Remove.
5329
5330 2019-03-06  Tom Tromey  <tom@tromey.com>
5331
5332         * top.c (quit_force): Update.
5333         * main.c (captured_command_loop): Update.
5334         * common/new-op.c (operator new): Update.
5335         * common/common-exceptions.c (struct catcher)
5336         <save_cleanup_chain>: Remove member.
5337         (exceptions_state_mc_init): Update.
5338         (exception_try_scope_entry): Return nullptr.
5339         (exception_try_scope_exit, exception_rethrow)
5340         (throw_exception_sjlj, throw_exception_cxx): Update.
5341         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5342         (all_cleanups, do_cleanups, discard_cleanups)
5343         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5344         (restore_cleanups, restore_final_cleanups): Don't declare.
5345         (do_final_cleanups): Remove parameter.
5346         * common/cleanups.c (cleanup_chain, make_cleanup)
5347         (make_cleanup_dtor, all_cleanups, do_cleanups)
5348         (discard_my_cleanups, discard_cleanups)
5349         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5350         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5351         (null_cleanup): Remove.
5352         (do_final_cleanups): Remove parameter.
5353
5354 2019-03-06  Tom Tromey  <tom@tromey.com>
5355
5356         * remote.c (remote_target::remote_parse_stop_reply): Use
5357         unique_xmalloc_ptr.
5358
5359 2019-03-06  Tom Tromey  <tom@tromey.com>
5360
5361         * stabsread.c (struct stabs_field_info): Rename from field_info.
5362         <list, fnlist>: Add initializers.
5363         <obstack>: New member.
5364         (read_member_functions, read_struct_fields, read_baseclasses):
5365         Allocate on obstack.  Don't use cleanups.
5366         (read_one_struct_field, read_member_functions, read_struct_fields)
5367         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5368         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5369         (read_struct_type): Update.
5370
5371 2019-03-06  Tom Tromey  <tom@tromey.com>
5372
5373         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5374         * common/filestuff.h (make_cleanup_close): Don't declare.
5375         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5376         Remove.
5377
5378 2019-03-06  Tom Tromey  <tom@tromey.com>
5379
5380         * solib-aix.c: Use make_scope_exit.
5381
5382 2019-03-06  Tom Tromey  <tom@tromey.com>
5383
5384         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5385         Use make_scope_exit.
5386
5387 2019-03-06  Tom Tromey  <tom@tromey.com>
5388
5389         * solib-svr4.c (disable_probes_interface): Remove parameter.
5390         (svr4_handle_solib_event): Use make_scope_exit.
5391
5392 2019-03-06  Tom Tromey  <tom@tromey.com>
5393
5394         * remote.c (struct stop_reply_deleter): Remove.
5395         (stop_reply_up): Update.
5396         (struct stop_reply): Derive from notif_event.  Don't typedef.
5397         <regcache>: Now a std::vector.
5398         (stop_reply_xfree): Remove.
5399         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5400         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5401         (remote_target::discard_pending_stop_replies): Use delete.
5402         (remote_target::remote_parse_stop_reply): Update.
5403         (remote_target::process_stop_reply): Update.
5404         * remote-notif.h (struct notif_event): Add virtual destructor.
5405         Remove "dtr" member.
5406         (struct notif_client) <alloc_event>: Return a unique_ptr.
5407         (notif_event_xfree): Don't declare.
5408         (notif_event_up): New typedef.
5409         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5410         (notif_event_xfree, do_notif_event_xfree): Remove.
5411         (remote_notif_state_xfree): Update.
5412
5413 2019-03-06  Tom Tromey  <tom@tromey.com>
5414
5415         * infrun.c (displaced_step_clear_cleanup): Now a
5416         forward_scope_exit type.
5417         (displaced_step_prepare_throw): Update.
5418         (displaced_step_fixup): Update.
5419
5420 2019-03-06  Tom Tromey  <tom@tromey.com>
5421
5422         * inferior.h (class inferior): Update comment.
5423         * gdbthread.h (class thread_info): Update comment.
5424
5425 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5426             Tom Tromey  <tom@tromey.com>
5427
5428         * stabsread.h (struct stab_section_list): Remove.
5429         (coffstab_build_psymtabs): Update.
5430         * dbxread.c (symbuf_sections): Now a std::vector.
5431         (sect_idx): New global.
5432         (fill_symbuf): Update.
5433         (coffstab_build_psymtabs): Change type of stabsects parameter.
5434         Update.
5435         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5436         std::vector.
5437         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5438         (coff_locate_sections): Update.
5439         (coff_symfile_read): Remove cleanups.  Update.
5440         (init_stringtab): Add storage parameter.
5441         (free_stringtab, free_stringtab_cleanup): Remove.
5442         (init_lineno): Add storage parameter.
5443         (free_linetab, free_linetab_cleanup): Remove.
5444
5445 2019-03-06  Pedro Alves  <palves@redhat.com>
5446
5447         * linux-fork.c (fork_info::clobber_regs): Delete.
5448         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5449         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5450         comment.  Adjust.
5451         (scoped_switch_fork_info::scoped_switch_fork_info)
5452         (checkpoint_command, linux_fork_context): Adjust
5453         fork_save_infrun_state calls.
5454
5455 2019-03-06  Pedro Alves  <palves@redhat.com>
5456
5457         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5458         (inf_has_multiple_threads): Return 'bool' and rewrite using
5459         inferior_info::threads().
5460
5461 2019-03-06  Pedro Alves  <palves@redhat.com>
5462
5463         * linux-fork.c: Include <list>.
5464         (fork_list): Now a std::list instance.
5465         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5466         (forks_exist_p, find_last_fork): Adjust.
5467         (new_fork): Delete.
5468         (one_fork_p): New.
5469         (add_fork): Adjust.
5470         (free_fork): Delete, folded into fork_info::~fork_info().
5471         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5472         Adjust.
5473         (init_fork_list): Delete.
5474         (linux_fork_killall, linux_fork_mourn_inferior)
5475         (linux_fork_detach, info_checkpoints_command): Adjust.
5476         (_initialize_linux_fork): No longer call init_fork_list.
5477
5478 2019-03-06  Pedro Alves  <palves@redhat.com>
5479
5480         * linux-fork.c (new_fork): New, split out of ...
5481         (add_fork): ... this.  Return void.  Move "first fork" special
5482         case from here, to ...
5483         (checkpoint_command): ... here.
5484         * linux-linux.h (add_fork): Return void.
5485
5486 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5487
5488         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5489
5490 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5491             Chris January  <chris.january@arm.com>
5492             David Lecomber  <david.lecomber@arm.com>
5493
5494         * f-exp.y: New token, UNOP_INTRINSIC.
5495         (exp): New pattern using UNOP_INTRINSIC token.
5496         (f77_keywords): Add 'abs' keyword.
5497         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5498         (value_from_host_double): New function.
5499         (evaluate_subexp_f): Support UNOP_ABS.
5500
5501 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5502
5503         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5504         types.
5505
5506 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5507
5508         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5509         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5510         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5511
5512 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5513
5514         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5515
5516 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5517             Chris January  <chris.january@arm.com>
5518
5519         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5520         * f-exp.y: Define 'KIND' token.
5521         (exp): New pattern for KIND expressions.
5522         (ptype): Handle types with a kind extension.
5523         (direct_abs_decl): Extend to spot kind extensions.
5524         (f77_keywords): Add 'kind' to the list.
5525         (push_kind_type): New function.
5526         (convert_to_kind_type): New function.
5527         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5528         * parse.c (operator_length_standard): Likewise.
5529         * parser-defs.h (enum type_pieces): Add tp_kind.
5530         * std-operator.def: Add UNOP_KIND.
5531
5532 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5533
5534         * f-exp.y (f_parse): Set yydebug.
5535
5536 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5537
5538         * f-lang.c (evaluate_subexp_f): New function.
5539         (exp_descriptor_f): New global.
5540         (f_language_defn): Use exp_descriptor_f instead of
5541         exp_descriptor_standard.
5542
5543 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5544
5545         * f-exp.y (struct token): Add comments.
5546         (dot_ops): Remove uppercase versions and the end marker.
5547         (f77_keywords): Likewise.
5548         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5549         entries in the dot_ops array are case insensitive, and use
5550         strncasecmp to compare strings.  Also some whitespace cleanup in
5551         this area.  Similar for the f77_keywords array, except entries in
5552         this list might be case sensitive.
5553
5554 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5555
5556         * f-exp.y (struct f77_boolean_val): Add comments.
5557         (boolean_values): Remove uppercase versions, and end marker.
5558         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5559         and use strncasecmp to achieve case insensitivity.  Additionally,
5560         perform whitespace cleanup around this code.
5561
5562 2019-03-06  Tom Tromey  <tromey@adacore.com>
5563
5564         * remote-sim.c (gdbsim_target_open): Use result of
5565         gdb_argv::release.
5566
5567 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5568         Dirk Schubert  <dirk.schubert@arm.com>
5569         Chris January  <chris.january@arm.com>
5570
5571         * eval.c (evaluate_subexp_standard): Call Fortran argument
5572         wrapping logic.
5573         * f-lang.c (struct value): A value which can be passed into a
5574         Fortran function call.
5575         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5576         where appropriate.
5577         (struct type): Value ready for a Fortran function call.
5578         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5579         is needed.
5580         * f-lang.h (fortran_argument_convert): Declaration.
5581         (fortran_preserve_arg_pointer): Declaration.
5582         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5583
5584 2019-03-05  Tom Tromey  <tromey@adacore.com>
5585
5586         * python/py-prettyprint.c (print_string_repr): Remove #if.
5587         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5588
5589 2019-03-05  Tom Tromey  <tromey@adacore.com>
5590
5591         * target.c (the_dummy_target): Move later.  Change type to
5592         "dummy_target".
5593         (initialize_targets): Don't initialize the_dummy_target.
5594
5595 2019-03-05  Tom Tromey  <tromey@adacore.com>
5596
5597         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5598         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5599
5600 2019-03-05  Tom Tromey  <tromey@adacore.com>
5601
5602         * windows-nat.c (windows_nat_target::attach)
5603         (windows_nat_target::detach): Don't call gdb_flush.
5604         * valprint.c (generic_val_print, val_print, val_print_string):
5605         Don't call gdb_flush.
5606         * utils.c (defaulted_query): Don't call gdb_flush.
5607         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5608         * target.c (target_announce_detach): Don't call gdb_flush.
5609         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5610         * remote.c (extended_remote_target::attach): Don't call
5611         gdb_flush.
5612         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5613         * printcmd.c (do_examine): Don't call gdb_flush.
5614         (info_display_command): Don't call gdb_flush.
5615         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5616         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5617         * memattr.c (info_mem_command): Don't call gdb_flush.
5618         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5619         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5620         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5621         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5622         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5623         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5624         (gnu_nat_target::detach): Don't call gdb_flush.
5625         * f-valprint.c (f_val_print): Don't call gdb_flush.
5626         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5627         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5628         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5629         gdb_flush.
5630         * c-valprint.c (c_val_print): Don't call gdb_flush.
5631         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5632
5633 2019-03-05  Tom Tromey  <tromey@adacore.com>
5634
5635         * varobj.c (update_dynamic_varobj_children): Update.
5636         (install_default_visualizer): Use reset, not release.
5637         * value.c (set_internalvar): Update.
5638         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5639         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5640         ATTRIBUTE_UNUSED_RESULT.
5641
5642 2019-03-05  Tom Tromey  <tromey@adacore.com>
5643
5644         * remote.c (class scoped_remote_fd) <release>: Add
5645         ATTRIBUTE_UNUSED_RESULT.
5646
5647 2019-03-05  Tom Tromey  <tromey@adacore.com>
5648
5649         * macroexp.c (struct macro_buffer) <release>: Add
5650         ATTRIBUTE_UNUSED_RESULT.
5651
5652 2019-03-05  Tom Tromey  <tromey@adacore.com>
5653
5654         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5655         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5656         ATTRIBUTE_UNUSED_RESULT.
5657
5658 2019-03-05  Tom Tromey  <tromey@adacore.com>
5659
5660         * common/scoped_fd.h (class scoped_fd) <release>: Add
5661         ATTRIBUTE_UNUSED_RESULT.
5662
5663 2019-03-05  Tom Tromey  <tromey@adacore.com>
5664
5665         * parser-defs.h (struct parser_state) <release>: Add
5666         ATTRIBUTE_UNUSED_RESULT.
5667
5668 2019-03-05  Tom Tromey  <tromey@adacore.com>
5669
5670         * utils.h (class gdb_argv) <release>: Add
5671         ATTRIBUTE_UNUSED_RESULT.
5672         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5673
5674 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5675
5676         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5677         for-loop range, to avoid compiler warnings.
5678
5679         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5680         avoid compiler warnings about unused variables.
5681
5682         * NEWS: Mention end of support for native debugging on MS-Windows
5683         before XP.
5684
5685         PR gdb/24292
5686         * common/netstuff.c:
5687         * gdbserver/gdbreplay.c
5688         * gdbserver/remote-utils.c:
5689         * ser-tcp.c:
5690         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5691         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5692         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5693         'getaddrinfo' and 'freeaddrinfo' were not available before
5694         Windows XP, and mingw.org's MinGW headers by default define
5695         _WIN32_WINNT to 0x500.
5696
5697 2019-03-01  Gary Benson <gbenson@redhat.com>
5698
5699         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5700
5701 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5702             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5703
5704         PR gdb/8527
5705         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5706         set_sigint_trap, clear_sigint_trap.
5707
5708 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5709
5710         * target.c (target_detach): Clear the regcache and the
5711         frame cache.
5712
5713 2019-02-27  Pedro Alves  <palves@redhat.com>
5714
5715         * utils.c (set_screen_size): When we cap the height/width sizes,
5716         tweak the corresponding command variable to show "unlimited":
5717
5718 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5719             Pedro Alves  <palves@redhat.com>
5720
5721         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5722         before calling rl_set_screen_size.
5723
5724 2019-02-27  Tom Tromey  <tromey@adacore.com>
5725
5726         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5727         define.
5728         * python/py-value.c: Remove Python 2.4 workaround.
5729         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5730         workaround.
5731         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5732         Python 2.4 workaround.
5733         * python/python-internal.h: Remove Python 2.4 comment.
5734         (Py_ssize_t): Don't define.
5735         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5736         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5737         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5738         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5739         * python/python.c (do_start_initialization): Remove Python 2.4
5740         workaround.
5741         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5742         (print_children): Remove Python 2.4 workaround.
5743         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5744         workaround.
5745         (CHARBUFFERPROC_NAME): Remove.
5746         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5747         Python 2.4 workaround.
5748
5749 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5750
5751         * NEWS: Note minimum Python version.
5752
5753 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5754
5755         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5756         code from these functions.  Remove corresponding ifdefs.  Use
5757         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5758         Remove gotos and target of gotos.
5759         (infpy_search_memory): Likewise.
5760
5761 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5762
5763         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5764         (hppa_gdbarch_init): Don't register deleted functions with
5765         gdbarch.
5766
5767 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5768
5769         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5770         (h8300_unwind_sp): Delete.
5771         (h8300_dummy_id): Delete.
5772         (h8300_gdbarch_init): Don't register deleted functions with
5773         gdbarch.
5774
5775 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5776
5777         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5778         (ft32_unwind_pc): Delete.
5779         (ft32_unwind_sp): Delete.
5780         (ft32_gdbarch_init): Don't register deleted functions with
5781         gdbarch.
5782
5783 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5784
5785         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5786         (frv_unwind_pc): Delete.
5787         (frv_unwind_sp): Delete.
5788         (frv_gdbarch_init): Don't register deleted functions with
5789         gdbarch.
5790
5791 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5792
5793         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5794         (riscv_unwind_pc): Delete.
5795         (riscv_unwind_sp): Delete.
5796         (riscv_gdbarch_init): Don't register deleted functions with
5797         gdbarch.
5798
5799 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5800
5801         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5802         (csky_unwind_pc): Delete.
5803         (csky_unwind_sp): Delete.
5804         (csky_gdbarch_init): Don't register deleted functions with
5805         gdbarch.
5806
5807 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5808
5809         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5810         (cris_unwind_pc): Delete.
5811         (cris_unwind_sp): Delete.
5812         (cris_gdbarch_init): Don't register deleted functions with
5813         gdbarch.
5814
5815 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5816
5817         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5818         (bfin_unwind_pc): Delete.
5819         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5820
5821 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5822
5823         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5824         (arm_unwind_pc): Delete.
5825         (arm_unwind_sp): Delete.
5826         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5827
5828 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5829
5830         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5831         (arc_unwind_pc): Delete.
5832         (arc_unwind_sp): Delete.
5833         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5834
5835 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5836
5837         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5838         (alpha_unwind_pc): Delete.
5839         (alpha_gdbarch_init): Don't register deleted functions with
5840         gdbarch.
5841
5842 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5843
5844         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5845         (aarch64_unwind_pc): Delete.
5846         (aarch64_unwind_sp): Delete.
5847         (aarch64_gdbarch_init): Don't register deleted functions with
5848         gdbarch.
5849
5850 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5851
5852         * gdbtypes.c (type_align): Don't consider static members when
5853         computing structure alignment.
5854
5855 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5856
5857         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5858         return 0 for other types.
5859         * arch-utils.c (default_type_align): Always return 0.
5860         * gdbarch.h: Regenerate.
5861         * gdbarch.sh (type_align): Extend comment.
5862         * gdbtypes.c (type_align): Add additional comments, always call
5863         gdbarch_type_align before applying the default rules.
5864         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5865         generic code will then apply a suitable default.
5866         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5867         types, return 0 for other types.
5868
5869 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5870
5871         * NEWS: Create a new section for the next release branch.
5872         Rename the section of the current branch, now that it has
5873         been cut.
5874
5875 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5876
5877         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5878         * version.in: Bump version to 8.3.50.DATE-git.
5879
5880 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5881
5882         * aix-thread.c (ptid_cmp): Remove unused variable.
5883         (get_signaled_thread): Likewise.
5884         (store_regs_user_thread): Likewise.
5885         (store_regs_kernel_thread): Likewise.
5886         (fetch_regs_kernel_thread): Remove shadowed variable.
5887
5888 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5889
5890         * features/riscv/32bit-cpu.xml: Add register numbers.
5891         * features/riscv/32bit-fpu.c: Regenerate.
5892         * features/riscv/32bit-fpu.xml: Add register numbers.
5893         * features/riscv/64bit-cpu.xml: Add register numbers.
5894         * features/riscv/64bit-fpu.c: Regenerate.
5895         * features/riscv/64bit-fpu.xml: Add register numbers.
5896
5897 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5898
5899         * NEWS: Mention two argument form of gdb.Value constructor.
5900         * python/py-value.c (convert_buffer_and_type_to_value): New
5901         function.
5902         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5903         Add support for handling an optional second argument.  Call
5904         convert_buffer_and_type_to_value as appropriate.
5905         * python/python-internal.h (Py_buffer_deleter): New struct.
5906         (Py_buffer_up): New typedef.
5907
5908 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5909
5910         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5911         instead of releasing ownership.
5912
5913 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5914
5915         * dwarf2read.c (open_and_init_dwp_file): Call
5916         elf_numsections instead of bfd_count_sections to initialize
5917         dwp_file->num_sections.
5918
5919 2019-02-25  Tom Tromey  <tromey@adacore.com>
5920
5921         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5922
5923 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5924
5925         * gcore.in: Add '--readnever' option when invoking GDB.
5926
5927 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5928
5929         * MAINTAINERS: Update my email address.
5930
5931 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5932
5933         * build-id.c (build_id_to_debug_bfd_1): New function.
5934         (build_id_to_debug_bfd): Look for separate debug file in
5935         sysroot.
5936
5937 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5938
5939         * gdbarch.sh: Update the copyright year range that is placed into
5940         generated files.
5941
5942 2019-02-22  Keith Seitz  <keiths@redhat.com>
5943
5944         PR symtab/23853
5945         * linespec.c (create_sals_line_offset): Search for the default
5946         symtab's filename instead of its fullname.
5947
5948 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5949
5950         * NEWS: Update style defaults.
5951
5952 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5953
5954         * main.c (captured_main_1): Disable styling in batch mode.
5955
5956 2019-02-20  Tom Tromey  <tom@tromey.com>
5957
5958         * symtab.c (symtab_symbol_info): Fix typos.
5959
5960 2019-02-20  Tom Tromey  <tromey@adacore.com>
5961
5962         * findcmd.c (_initialize_mem_search): Use upper case for
5963         metasyntactic variables.
5964
5965 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5966
5967         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5968         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5969
5970 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5971
5972         * top.h (source_file_name): Change to std::string.
5973         * top.c (source_file_name): Likewise.
5974         (command_line_input): Adjust.
5975         * cli/cli-script.c (script_from_file): Adjust.
5976
5977 2019-02-19  Tom Tromey  <tromey@adacore.com>
5978
5979         * ravenscar-thread.c
5980         (ravenscar_thread_target::update_thread_list): Don't call
5981         ada_build_task_list.
5982         * ada-lang.h (ada_build_task_list): Don't declare.
5983         * ada-tasks.c (struct ada_tasks_inferior_data)
5984         <task_list_valid_p>: Now bool.
5985         (read_known_tasks, ada_task_list_changed)
5986         (ada_tasks_invalidate_inferior_data): Update.
5987         (read_known_tasks_array): Return bool.
5988         (read_known_tasks_list): Likewise.
5989         (read_known_tasks): Return void.
5990         (ada_build_task_list): Now static.
5991
5992 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5993
5994         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5995         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5996
5997 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5998
5999         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6000         variant for ada_tasks_pspace_data_handle and
6001         ada_tasks_inferior_data_handle.
6002         (ada_tasks_pspace_data_cleanup): New function.
6003         (ada_tasks_inferior_data_cleanup): New function.
6004
6005 2019-02-17  Tom Tromey  <tom@tromey.com>
6006
6007         * macrotab.h (macro_source_fullname): Return a std::string.
6008         * macrotab.c (macro_include, check_for_redefinition)
6009         (macro_undef, macro_lookup_definition, foreach_macro)
6010         (foreach_macro_in_scope): Update.
6011         (macro_source_fullname): Return a std::string.
6012         * macrocmd.c (show_pp_source_pos): Update.
6013
6014 2019-02-17  Tom Tromey  <tom@tromey.com>
6015
6016         * macrocmd.c (show_pp_source_pos): Style the file names.
6017
6018 2019-02-17  Tom Tromey  <tom@tromey.com>
6019
6020         PR tui/24197:
6021         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6022
6023 2019-02-17  Tom Tromey  <tom@tromey.com>
6024
6025         * ada-lang.c (user_select_syms): Use filtered printing.
6026         * utils.c (wrap_style): New global.
6027         (desired_style): Remove.
6028         (emit_style_escape): Add stream parameter.
6029         (set_output_style, reset_terminal_style, prompt_for_continue):
6030         Update.
6031         (flush_wrap_buffer): Only flush gdb_stdout.
6032         (wrap_here): Set wrap_style.
6033         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6034         treat escape sequences as a character.  Change when wrap buffer is
6035         flushed.
6036         (fputs_styled): Do not set the output style when the default is
6037         requested.
6038         * ui-style.h (struct ui_file_style) <is_default>: New method.
6039         * source.c (print_source_lines_base): Emit escape sequences in one
6040         piece.
6041
6042 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6043
6044         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6045         integers and enumeration types.
6046
6047 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6048
6049         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6050         instead of lookup_symbol_in_language
6051         (do_exact_match): New function.
6052         (ada_get_symbol_name_matcher): Return do_exact_match when
6053         doing a verbatim match.
6054
6055 2019-02-15  Tom Tromey  <tromey@adacore.com>
6056
6057         * ravenscar-thread.c (ravenscar_thread_target::resume)
6058         (ravenscar_thread_target::wait): Special case wildcard requests.
6059
6060 2019-02-15  Tom Tromey  <tromey@adacore.com>
6061
6062         * ravenscar-thread.c (base_ptid): Remove.
6063         (struct ravenscar_thread_target) <close>: New method.
6064         <m_base_ptid>: New member.
6065         <update_inferior_ptid, active_task, task_is_currently_active,
6066         runtime_initialized>: Declare methods.
6067         <ravenscar_thread_target>: Add constructor.
6068         (ravenscar_thread_target::task_is_currently_active)
6069         (ravenscar_thread_target::update_inferior_ptid)
6070         (ravenscar_runtime_initialized): Rename.  Now methods.
6071         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6072         (ravenscar_thread_target::update_thread_list): Update.
6073         (ravenscar_thread_target::active_task): Now method.
6074         (ravenscar_thread_target::store_registers)
6075         (ravenscar_thread_target::prepare_to_store)
6076         (ravenscar_thread_target::prepare_to_store)
6077         (ravenscar_thread_target::mourn_inferior): Update.
6078         (ravenscar_inferior_created): Use "new" to create target.
6079         (ravenscar_thread_target::get_ada_task_ptid): Update.
6080         (_initialize_ravenscar): Don't initialize base_ptid.
6081         (ravenscar_ops): Remove global.
6082
6083 2019-02-15  Tom Tromey  <tromey@adacore.com>
6084
6085         * target.h (push_target): Declare new overload.
6086         * target.c (push_target): New overload, taking an rvalue reference.
6087         * remote.c (remote_target::open_1): Use push_target overload.
6088         * corelow.c (core_target_open): Use push_target overload.
6089
6090 2019-02-15  Tom Tromey  <tromey@adacore.com>
6091
6092         * ravenscar-thread.c (is_ravenscar_task)
6093         (ravenscar_task_is_currently_active): Return bool.
6094         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6095         (_initialize_ravenscar): Remove "(void)".
6096         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6097         Return bool.
6098
6099 2019-02-15  Tom Tromey  <tromey@adacore.com>
6100
6101         * ravenscar-thread.c (ravenscar_runtime_initializer)
6102         (has_ravenscar_runtime, get_running_thread_id)
6103         (ravenscar_thread_target::resume): Fix indentation.
6104
6105 2019-02-15  Tom Tromey  <tromey@adacore.com>
6106
6107         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6108         from ravenscar_arch_ops.
6109         (sparc_ravenscar_ops::fetch_registers)
6110         (sparc_ravenscar_ops::store_registers): Now methods.
6111         (sparc_ravenscar_prepare_to_store): Remove.
6112         (sparc_ravenscar_ops): Redefine.
6113         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6114         methods and destructor.  Remove members.
6115         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6116         (ravenscar_thread_target::store_registers)
6117         (ravenscar_thread_target::prepare_to_store): Update.
6118         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6119         Remove.
6120         (struct ppc_ravenscar_powerpc_ops): Derive from
6121         ravenscar_arch_ops.
6122         (ppc_ravenscar_powerpc_ops::fetch_registers)
6123         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6124         (ppc_ravenscar_powerpc_ops): Redefine.
6125         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6126         (ppc_ravenscar_e500_ops::fetch_registers)
6127         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6128         (ppc_ravenscar_e500_ops): Redefine.
6129         * aarch64-ravenscar-thread.c
6130         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6131         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6132         (aarch64_ravenscar_fetch_registers)
6133         (aarch64_ravenscar_store_registers): Now methods.
6134         (aarch64_ravenscar_ops): Redefine.
6135
6136 2019-02-15  Tom Tromey  <tromey@adacore.com>
6137
6138         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6139         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6140         (ravenscar_thread_target::stopped_by_watchpoint)
6141         (ravenscar_thread_target::stopped_data_address)
6142         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6143
6144 2019-02-15  Tom Tromey  <tromey@adacore.com>
6145
6146         * ravenscar-thread.c: Fix some typos.
6147
6148 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6149             Tom Tromey  <tromey@adacore.com>
6150
6151         * ada-lang.c (ada_exception_sal): Change addr_string to a
6152         std::string.
6153         (create_ada_exception_catchpoint): Update.
6154
6155 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6156             Tom Tromey  <tromey@adacore.com>
6157
6158         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6159         (bp_location_ops): Remove.
6160         (base_breakpoint_allocate_location): Update.
6161         (free_bp_location): Update.
6162         * ada-lang.c (class ada_catchpoint_location)
6163         <ada_catchpoint_location>: Remove ops parameter.
6164         (ada_catchpoint_location_dtor): Remove.
6165         (ada_catchpoint_location_ops): Remove.
6166         (allocate_location_exception): Update.
6167         * breakpoint.h (struct bp_location_ops): Remove.
6168         (class bp_location) <bp_location>: Remove bp_location_ops
6169         parameter.
6170         <~bp_location>: Add destructor.
6171         <ops>: Remove.
6172
6173 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6174             Pedro Alves  <palves@redhat.com>
6175
6176         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6177         'PATH_MAX'.
6178
6179 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6180             Samuel Thibault  <samuel.thibault@gnu.org>
6181             Thomas Schwinge  <thomas@codesourcery.com>
6182
6183         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6184         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6185
6186 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6187
6188         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6189         (check_empty): Use "const char *".
6190
6191         * gnu-nat.c (gnu_nat_target::detach): Instead of
6192         'detach_inferior (pid)' call
6193         'detach_inferior (find_inferior_pid (pid))'.
6194
6195         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6196         'nat/fork-inferior.o'.
6197         * gnu-nat.c: #include "nat/fork-inferior.h".
6198
6199         * gnu-nat.c (gnu_nat_target::detach): Instead of
6200         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6201         * gnu-nat.h: #include "inf-child.h".
6202         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6203         'i386_gnu_nat_target::fetch_registers'.
6204         (gnu_store_registers): Rename/move to
6205         'i386_gnu_nat_target::store_registers'.
6206
6207         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6208         * gnu-nat.h (mach_thread_info): New function.
6209         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6210
6211         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6212
6213 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6214
6215         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6216
6217 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6218
6219         * windows-nat.c (windows_add_thread): Add new parameter
6220         "main_thread_p" with default value set to false.  Update
6221         function documentation as well as all callers.
6222         (windows_delete_thread): Likewise.
6223         (fake_create_process): Update call to windows_add_thread.
6224         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6225         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6226         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6227         call to windows_delete_thread.
6228
6229 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6230
6231         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6232
6233 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6234
6235         * symfile.c (find_separate_debug_file): Use canonical path of
6236         sysroot with child_path instead of gdb_sysroot if it is valid.
6237
6238 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6239
6240         * symfile.c (find_separate_debug_file): Use child_path to
6241         determine if an object file is under a sysroot.
6242
6243 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6244
6245         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6246         unittests/child-path-selftests.c.
6247         * common/pathstuff.c (child_path): New function.
6248         * common/pathstuff.h (child_path): New prototype.
6249         * unittests/child-path-selftests.c: New file.
6250
6251 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6252
6253         * symfile.c (find_separate_debug_file): Look for separate debug
6254         files in debug directories under the sysroot.
6255
6256 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6257
6258         * symtab.h (struct minimal_symbol data_p): New const method.
6259         (struct minimal_symbol text_p): Likewise.
6260         * symtab.c (output_source_filename): Use file name style
6261         to print file name.
6262         (print_symbol_info): Likewise.
6263         (print_msymbol_info): Use address style to print addresses.
6264         Use function name style to print executable text symbols.
6265         (expand_symtab_containing_pc): Use data_p.
6266         (find_pc_sect_compunit_symtab): Likewise.
6267
6268 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6269
6270         * breakpoint.c (describe_other_breakpoints): Use address style
6271         to print addresses.
6272         (say_where): Likewise.
6273
6274 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6275
6276         * ada-typeprint.c (print_func_type): Print function name
6277         style to print function name.
6278         * c-typeprint.c (c_print_type_1): Likewise.
6279
6280 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6281
6282         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6283         for execve.
6284
6285 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6286
6287         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6288         type_stack.
6289
6290 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6291
6292         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6293         TYPE_CODE_REF types.
6294
6295 2019-02-08  Jim Wilson  <jimw@sifive.com>
6296
6297         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6298         (riscv_linux_fregset): New.
6299         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6300
6301 2019-02-07  Tom Tromey  <tom@tromey.com>
6302
6303         * thread.c (thread_cancel_execution_command): Update.
6304         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6305         methods.
6306         (struct thread_fsm_ops): Remove.
6307         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6308         (thread_fsm_should_stop, thread_fsm_return_value)
6309         (thread_fsm_set_finished, thread_fsm_finished_p)
6310         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6311         Don't declare.
6312         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6313         * infrun.c (clear_proceed_status_thread)
6314         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6315         (print_stop_event): Update.
6316         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6317         Add constructor.
6318         (step_command_fsm_ops): Remove.
6319         (new_step_command_fsm): Remove.
6320         (step_1): Update.
6321         (step_command_fsm::should_stop): Rename from
6322         step_command_fsm_should_stop.
6323         (step_command_fsm::clean_up): Rename from
6324         step_command_fsm_clean_up.
6325         (step_command_fsm::do_async_reply_reason): Rename from
6326         step_command_fsm_async_reply_reason.
6327         (struct until_next_fsm): Inherit from thread_fsm.  Add
6328         constructor.
6329         (until_next_fsm_ops): Remove.
6330         (new_until_next_fsm): Remove.
6331         (until_next_fsm::should_stop): Rename from
6332         until_next_fsm_should_stop.
6333         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6334         (until_next_fsm::do_async_reply_reason): Rename from
6335         until_next_fsm_async_reply_reason.
6336         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6337         constructor.  Change type of breakpoint.
6338         (finish_command_fsm_ops): Remove.
6339         (new_finish_command_fsm): Remove.
6340         (finish_command_fsm::should_stop): Rename from
6341         finish_command_fsm_should_stop.
6342         (finish_command_fsm::clean_up): Rename from
6343         finish_command_fsm_clean_up.
6344         (finish_command_fsm::return_value): Rename from
6345         finish_command_fsm_return_value.
6346         (finish_command_fsm::do_async_reply_reason): Rename from
6347         finish_command_fsm_async_reply_reason.
6348         (finish_command): Update.
6349         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6350         Add constructor.
6351         (call_thread_fsm_ops): Remove.
6352         (call_thread_fsm::call_thread_fsm): Rename from
6353         new_call_thread_fsm.
6354         (call_thread_fsm::should_stop): Rename from
6355         call_thread_fsm_should_stop.
6356         (call_thread_fsm::should_notify_stop): Rename from
6357         call_thread_fsm_should_notify_stop.
6358         (run_inferior_call, call_function_by_hand_dummy): Update.
6359         * cli/cli-interp.c (should_print_stop_to_console): Update.
6360         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6361         Add constructor.  Change type of location_breakpoint,
6362         caller_breakpoint.
6363         (until_break_fsm_ops): Remove.
6364         (new_until_break_fsm): Remove.
6365         (until_break_fsm::should_stop): Rename from
6366         until_break_fsm_should_stop.
6367         (until_break_fsm::clean_up): Rename from
6368         until_break_fsm_clean_up.
6369         (until_break_fsm::do_async_reply_reason): Rename from
6370         until_break_fsm_async_reply_reason.
6371         (until_break_command): Update.
6372         * thread-fsm.c: Remove.
6373         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6374
6375 2019-02-07  Tom Tromey  <tom@tromey.com>
6376
6377         * yy-remap.h: Add include guard.
6378         * xtensa-tdep.h: Add include guard.
6379         * xcoffread.h: Rename include guard.
6380         * varobj-iter.h: Add include guard.
6381         * tui/tui.h: Rename include guard.
6382         * tui/tui-winsource.h: Rename include guard.
6383         * tui/tui-wingeneral.h: Rename include guard.
6384         * tui/tui-windata.h: Rename include guard.
6385         * tui/tui-win.h: Rename include guard.
6386         * tui/tui-stack.h: Rename include guard.
6387         * tui/tui-source.h: Rename include guard.
6388         * tui/tui-regs.h: Rename include guard.
6389         * tui/tui-out.h: Rename include guard.
6390         * tui/tui-layout.h: Rename include guard.
6391         * tui/tui-io.h: Rename include guard.
6392         * tui/tui-hooks.h: Rename include guard.
6393         * tui/tui-file.h: Rename include guard.
6394         * tui/tui-disasm.h: Rename include guard.
6395         * tui/tui-data.h: Rename include guard.
6396         * tui/tui-command.h: Rename include guard.
6397         * tic6x-tdep.h: Add include guard.
6398         * target/waitstatus.h: Rename include guard.
6399         * target/wait.h: Rename include guard.
6400         * target/target.h: Rename include guard.
6401         * target/resume.h: Rename include guard.
6402         * target-float.h: Rename include guard.
6403         * stabsread.h: Add include guard.
6404         * rs6000-tdep.h: Add include guard.
6405         * riscv-fbsd-tdep.h: Add include guard.
6406         * regformats/regdef.h: Rename include guard.
6407         * record.h: Rename include guard.
6408         * python/python.h: Rename include guard.
6409         * python/python-internal.h: Rename include guard.
6410         * python/py-stopevent.h: Rename include guard.
6411         * python/py-ref.h: Rename include guard.
6412         * python/py-record.h: Rename include guard.
6413         * python/py-record-full.h: Rename include guard.
6414         * python/py-record-btrace.h: Rename include guard.
6415         * python/py-instruction.h: Rename include guard.
6416         * python/py-events.h: Rename include guard.
6417         * python/py-event.h: Rename include guard.
6418         * procfs.h: Add include guard.
6419         * proc-utils.h: Add include guard.
6420         * p-lang.h: Add include guard.
6421         * or1k-tdep.h: Rename include guard.
6422         * observable.h: Rename include guard.
6423         * nto-tdep.h: Rename include guard.
6424         * nat/x86-linux.h: Rename include guard.
6425         * nat/x86-linux-dregs.h: Rename include guard.
6426         * nat/x86-gcc-cpuid.h: Add include guard.
6427         * nat/x86-dregs.h: Rename include guard.
6428         * nat/x86-cpuid.h: Rename include guard.
6429         * nat/ppc-linux.h: Rename include guard.
6430         * nat/mips-linux-watch.h: Rename include guard.
6431         * nat/linux-waitpid.h: Rename include guard.
6432         * nat/linux-ptrace.h: Rename include guard.
6433         * nat/linux-procfs.h: Rename include guard.
6434         * nat/linux-osdata.h: Rename include guard.
6435         * nat/linux-nat.h: Rename include guard.
6436         * nat/linux-namespaces.h: Rename include guard.
6437         * nat/linux-btrace.h: Rename include guard.
6438         * nat/glibc_thread_db.h: Rename include guard.
6439         * nat/gdb_thread_db.h: Rename include guard.
6440         * nat/gdb_ptrace.h: Rename include guard.
6441         * nat/fork-inferior.h: Rename include guard.
6442         * nat/amd64-linux-siginfo.h: Rename include guard.
6443         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6444         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6445         * nat/aarch64-linux.h: Rename include guard.
6446         * nat/aarch64-linux-hw-point.h: Rename include guard.
6447         * mn10300-tdep.h: Add include guard.
6448         * mips-linux-tdep.h: Add include guard.
6449         * mi/mi-parse.h: Rename include guard.
6450         * mi/mi-out.h: Rename include guard.
6451         * mi/mi-main.h: Rename include guard.
6452         * mi/mi-interp.h: Rename include guard.
6453         * mi/mi-getopt.h: Rename include guard.
6454         * mi/mi-console.h: Rename include guard.
6455         * mi/mi-common.h: Rename include guard.
6456         * mi/mi-cmds.h: Rename include guard.
6457         * mi/mi-cmd-break.h: Rename include guard.
6458         * m2-lang.h: Add include guard.
6459         * location.h: Rename include guard.
6460         * linux-record.h: Rename include guard.
6461         * linux-nat.h: Add include guard.
6462         * linux-fork.h: Add include guard.
6463         * i386-darwin-tdep.h: Rename include guard.
6464         * hppa-linux-offsets.h: Add include guard.
6465         * guile/guile.h: Rename include guard.
6466         * guile/guile-internal.h: Rename include guard.
6467         * gnu-nat.h: Rename include guard.
6468         * gdb-stabs.h: Rename include guard.
6469         * frv-tdep.h: Add include guard.
6470         * f-lang.h: Add include guard.
6471         * event-loop.h: Add include guard.
6472         * darwin-nat.h: Rename include guard.
6473         * cp-abi.h: Rename include guard.
6474         * config/sparc/nm-sol2.h: Rename include guard.
6475         * config/nm-nto.h: Rename include guard.
6476         * config/nm-linux.h: Add include guard.
6477         * config/i386/nm-i386gnu.h: Rename include guard.
6478         * config/djgpp/nl_types.h: Rename include guard.
6479         * config/djgpp/langinfo.h: Rename include guard.
6480         * compile/gcc-cp-plugin.h: Add include guard.
6481         * compile/gcc-c-plugin.h: Add include guard.
6482         * compile/compile.h: Rename include guard.
6483         * compile/compile-object-run.h: Rename include guard.
6484         * compile/compile-object-load.h: Rename include guard.
6485         * compile/compile-internal.h: Rename include guard.
6486         * compile/compile-cplus.h: Rename include guard.
6487         * compile/compile-c.h: Rename include guard.
6488         * common/xml-utils.h: Rename include guard.
6489         * common/x86-xstate.h: Rename include guard.
6490         * common/version.h: Rename include guard.
6491         * common/vec.h: Rename include guard.
6492         * common/tdesc.h: Rename include guard.
6493         * common/selftest.h: Rename include guard.
6494         * common/scoped_restore.h: Rename include guard.
6495         * common/scoped_mmap.h: Rename include guard.
6496         * common/scoped_fd.h: Rename include guard.
6497         * common/safe-iterator.h: Rename include guard.
6498         * common/run-time-clock.h: Rename include guard.
6499         * common/refcounted-object.h: Rename include guard.
6500         * common/queue.h: Rename include guard.
6501         * common/ptid.h: Rename include guard.
6502         * common/print-utils.h: Rename include guard.
6503         * common/preprocessor.h: Rename include guard.
6504         * common/pathstuff.h: Rename include guard.
6505         * common/observable.h: Rename include guard.
6506         * common/netstuff.h: Rename include guard.
6507         * common/job-control.h: Rename include guard.
6508         * common/host-defs.h: Rename include guard.
6509         * common/gdb_wait.h: Rename include guard.
6510         * common/gdb_vecs.h: Rename include guard.
6511         * common/gdb_unlinker.h: Rename include guard.
6512         * common/gdb_unique_ptr.h: Rename include guard.
6513         * common/gdb_tilde_expand.h: Rename include guard.
6514         * common/gdb_sys_time.h: Rename include guard.
6515         * common/gdb_string_view.h: Rename include guard.
6516         * common/gdb_splay_tree.h: Rename include guard.
6517         * common/gdb_setjmp.h: Rename include guard.
6518         * common/gdb_ref_ptr.h: Rename include guard.
6519         * common/gdb_optional.h: Rename include guard.
6520         * common/gdb_locale.h: Rename include guard.
6521         * common/gdb_assert.h: Rename include guard.
6522         * common/filtered-iterator.h: Rename include guard.
6523         * common/filestuff.h: Rename include guard.
6524         * common/fileio.h: Rename include guard.
6525         * common/environ.h: Rename include guard.
6526         * common/common-utils.h: Rename include guard.
6527         * common/common-types.h: Rename include guard.
6528         * common/common-regcache.h: Rename include guard.
6529         * common/common-inferior.h: Rename include guard.
6530         * common/common-gdbthread.h: Rename include guard.
6531         * common/common-exceptions.h: Rename include guard.
6532         * common/common-defs.h: Rename include guard.
6533         * common/common-debug.h: Rename include guard.
6534         * common/cleanups.h: Rename include guard.
6535         * common/buffer.h: Rename include guard.
6536         * common/btrace-common.h: Rename include guard.
6537         * common/break-common.h: Rename include guard.
6538         * cli/cli-utils.h: Rename include guard.
6539         * cli/cli-style.h: Rename include guard.
6540         * cli/cli-setshow.h: Rename include guard.
6541         * cli/cli-script.h: Rename include guard.
6542         * cli/cli-interp.h: Rename include guard.
6543         * cli/cli-decode.h: Rename include guard.
6544         * cli/cli-cmds.h: Rename include guard.
6545         * charset-list.h: Add include guard.
6546         * buildsym-legacy.h: Rename include guard.
6547         * bfin-tdep.h: Add include guard.
6548         * ax.h: Rename include guard.
6549         * arm-linux-tdep.h: Add include guard.
6550         * arm-fbsd-tdep.h: Add include guard.
6551         * arch/xtensa.h: Rename include guard.
6552         * arch/tic6x.h: Add include guard.
6553         * arch/i386.h: Add include guard.
6554         * arch/arm.h: Rename include guard.
6555         * arch/arm-linux.h: Rename include guard.
6556         * arch/arm-get-next-pcs.h: Rename include guard.
6557         * arch/amd64.h: Add include guard.
6558         * arch/aarch64-insn.h: Rename include guard.
6559         * arch-utils.h: Rename include guard.
6560         * annotate.h: Add include guard.
6561         * amd64-darwin-tdep.h: Rename include guard.
6562         * aarch64-linux-tdep.h: Add include guard.
6563         * aarch64-fbsd-tdep.h: Add include guard.
6564         * aarch32-linux-nat.h: Add include guard.
6565
6566 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6567
6568         * macrotab.c (macro_define_internal): New function that
6569         factorizes macro_define_object_internal and macro_define_function
6570         code.
6571         (macro_define_object_internal): Use macro_define_internal.
6572         (macro_define_function): Likewise.
6573
6574 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6575
6576         * macrocmd.c (extract_identifier): Return
6577         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6578         callers.
6579
6580 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6581
6582         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6583
6584 2019-02-05  Tom Tromey  <tom@tromey.com>
6585
6586         * target.c (target_stack::unpush): Move assertion earlier.
6587
6588 2019-01-30  Tom Tromey  <tom@tromey.com>
6589
6590         PR python/23615:
6591         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6592         (gdbpy_parse_and_eval): Likewise.
6593         * python/python-internal.h (gdbpy_allow_threads): New class.
6594
6595 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6596
6597         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6598         (aarch64_fbsd_fpregmap): Move earlier.
6599         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6600         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6601         instead of individual calls to trad_frame_set_reg_addr.
6602         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6603         earlier.
6604         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6605         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6606         instead of individual calls to trad_frame_set_reg_addr.
6607
6608 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6609
6610         * CONTRIBUTE: Replace contribution list with wiki link.
6611
6612 2019-01-25  Tom Tromey  <tom@tromey.com>
6613
6614         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6615
6616 2019-01-25  Tom Tromey  <tom@tromey.com>
6617
6618         * xtensa-linux-nat.c: Fix common/ includes.
6619         * xml-support.h: Fix common/ includes.
6620         * xml-support.c: Fix common/ includes.
6621         * x86-linux-nat.c: Fix common/ includes.
6622         * windows-nat.c: Fix common/ includes.
6623         * varobj.h: Fix common/ includes.
6624         * varobj.c: Fix common/ includes.
6625         * value.c: Fix common/ includes.
6626         * valops.c: Fix common/ includes.
6627         * utils.c: Fix common/ includes.
6628         * unittests/xml-utils-selftests.c: Fix common/ includes.
6629         * unittests/utils-selftests.c: Fix common/ includes.
6630         * unittests/unpack-selftests.c: Fix common/ includes.
6631         * unittests/tracepoint-selftests.c: Fix common/ includes.
6632         * unittests/style-selftests.c: Fix common/ includes.
6633         * unittests/string_view-selftests.c: Fix common/ includes.
6634         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6635         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6636         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6637         * unittests/rsp-low-selftests.c: Fix common/ includes.
6638         * unittests/parse-connection-spec-selftests.c: Fix common/
6639         includes.
6640         * unittests/optional-selftests.c: Fix common/ includes.
6641         * unittests/offset-type-selftests.c: Fix common/ includes.
6642         * unittests/observable-selftests.c: Fix common/ includes.
6643         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6644         * unittests/memrange-selftests.c: Fix common/ includes.
6645         * unittests/memory-map-selftests.c: Fix common/ includes.
6646         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6647         * unittests/function-view-selftests.c: Fix common/ includes.
6648         * unittests/environ-selftests.c: Fix common/ includes.
6649         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6650         * unittests/common-utils-selftests.c: Fix common/ includes.
6651         * unittests/cli-utils-selftests.c: Fix common/ includes.
6652         * unittests/array-view-selftests.c: Fix common/ includes.
6653         * ui-file.c: Fix common/ includes.
6654         * tui/tui-io.c: Fix common/ includes.
6655         * tracepoint.h: Fix common/ includes.
6656         * tracepoint.c: Fix common/ includes.
6657         * tracefile-tfile.c: Fix common/ includes.
6658         * top.h: Fix common/ includes.
6659         * top.c: Fix common/ includes.
6660         * thread.c: Fix common/ includes.
6661         * target/waitstatus.h: Fix common/ includes.
6662         * target/waitstatus.c: Fix common/ includes.
6663         * target.h: Fix common/ includes.
6664         * target.c: Fix common/ includes.
6665         * target-memory.c: Fix common/ includes.
6666         * target-descriptions.c: Fix common/ includes.
6667         * symtab.h: Fix common/ includes.
6668         * symfile.c: Fix common/ includes.
6669         * stap-probe.c: Fix common/ includes.
6670         * spu-linux-nat.c: Fix common/ includes.
6671         * sparc-nat.c: Fix common/ includes.
6672         * source.c: Fix common/ includes.
6673         * solib.c: Fix common/ includes.
6674         * solib-target.c: Fix common/ includes.
6675         * ser-unix.c: Fix common/ includes.
6676         * ser-tcp.c: Fix common/ includes.
6677         * ser-pipe.c: Fix common/ includes.
6678         * ser-base.c: Fix common/ includes.
6679         * selftest-arch.c: Fix common/ includes.
6680         * s12z-tdep.c: Fix common/ includes.
6681         * rust-exp.y: Fix common/ includes.
6682         * rs6000-aix-tdep.c: Fix common/ includes.
6683         * riscv-tdep.c: Fix common/ includes.
6684         * remote.c: Fix common/ includes.
6685         * remote-notif.h: Fix common/ includes.
6686         * remote-fileio.h: Fix common/ includes.
6687         * remote-fileio.c: Fix common/ includes.
6688         * regcache.h: Fix common/ includes.
6689         * regcache.c: Fix common/ includes.
6690         * record-btrace.c: Fix common/ includes.
6691         * python/python.c: Fix common/ includes.
6692         * python/py-type.c: Fix common/ includes.
6693         * python/py-inferior.c: Fix common/ includes.
6694         * progspace.h: Fix common/ includes.
6695         * producer.c: Fix common/ includes.
6696         * procfs.c: Fix common/ includes.
6697         * proc-api.c: Fix common/ includes.
6698         * printcmd.c: Fix common/ includes.
6699         * ppc-linux-nat.c: Fix common/ includes.
6700         * parser-defs.h: Fix common/ includes.
6701         * osdata.c: Fix common/ includes.
6702         * obsd-nat.c: Fix common/ includes.
6703         * nat/x86-linux.c: Fix common/ includes.
6704         * nat/x86-linux-dregs.c: Fix common/ includes.
6705         * nat/x86-dregs.h: Fix common/ includes.
6706         * nat/x86-dregs.c: Fix common/ includes.
6707         * nat/ppc-linux.c: Fix common/ includes.
6708         * nat/mips-linux-watch.h: Fix common/ includes.
6709         * nat/mips-linux-watch.c: Fix common/ includes.
6710         * nat/linux-waitpid.c: Fix common/ includes.
6711         * nat/linux-ptrace.h: Fix common/ includes.
6712         * nat/linux-ptrace.c: Fix common/ includes.
6713         * nat/linux-procfs.c: Fix common/ includes.
6714         * nat/linux-personality.c: Fix common/ includes.
6715         * nat/linux-osdata.c: Fix common/ includes.
6716         * nat/linux-namespaces.c: Fix common/ includes.
6717         * nat/linux-btrace.h: Fix common/ includes.
6718         * nat/linux-btrace.c: Fix common/ includes.
6719         * nat/fork-inferior.c: Fix common/ includes.
6720         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6721         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6722         * nat/aarch64-linux.c: Fix common/ includes.
6723         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6724         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6725         * namespace.h: Fix common/ includes.
6726         * mips-linux-tdep.c: Fix common/ includes.
6727         * minsyms.c: Fix common/ includes.
6728         * mi/mi-parse.h: Fix common/ includes.
6729         * mi/mi-main.c: Fix common/ includes.
6730         * mi/mi-cmd-env.c: Fix common/ includes.
6731         * memrange.h: Fix common/ includes.
6732         * memattr.c: Fix common/ includes.
6733         * maint.h: Fix common/ includes.
6734         * maint.c: Fix common/ includes.
6735         * main.c: Fix common/ includes.
6736         * machoread.c: Fix common/ includes.
6737         * location.c: Fix common/ includes.
6738         * linux-thread-db.c: Fix common/ includes.
6739         * linux-nat.c: Fix common/ includes.
6740         * linux-fork.c: Fix common/ includes.
6741         * inline-frame.c: Fix common/ includes.
6742         * infrun.c: Fix common/ includes.
6743         * inflow.c: Fix common/ includes.
6744         * inferior.h: Fix common/ includes.
6745         * inferior.c: Fix common/ includes.
6746         * infcmd.c: Fix common/ includes.
6747         * inf-ptrace.c: Fix common/ includes.
6748         * inf-child.c: Fix common/ includes.
6749         * ia64-linux-nat.c: Fix common/ includes.
6750         * i387-tdep.c: Fix common/ includes.
6751         * i386-tdep.c: Fix common/ includes.
6752         * i386-linux-tdep.c: Fix common/ includes.
6753         * i386-linux-nat.c: Fix common/ includes.
6754         * i386-go32-tdep.c: Fix common/ includes.
6755         * i386-fbsd-tdep.c: Fix common/ includes.
6756         * i386-fbsd-nat.c: Fix common/ includes.
6757         * guile/scm-type.c: Fix common/ includes.
6758         * guile/guile.c: Fix common/ includes.
6759         * go32-nat.c: Fix common/ includes.
6760         * gnu-nat.c: Fix common/ includes.
6761         * gdbthread.h: Fix common/ includes.
6762         * gdbarch-selftests.c: Fix common/ includes.
6763         * gdb_usleep.c: Fix common/ includes.
6764         * gdb_select.h: Fix common/ includes.
6765         * gdb_bfd.c: Fix common/ includes.
6766         * gcore.c: Fix common/ includes.
6767         * fork-child.c: Fix common/ includes.
6768         * findvar.c: Fix common/ includes.
6769         * fbsd-nat.c: Fix common/ includes.
6770         * event-top.c: Fix common/ includes.
6771         * event-loop.c: Fix common/ includes.
6772         * dwarf2read.c: Fix common/ includes.
6773         * dwarf2loc.c: Fix common/ includes.
6774         * dwarf2-frame.c: Fix common/ includes.
6775         * dwarf-index-cache.c: Fix common/ includes.
6776         * dtrace-probe.c: Fix common/ includes.
6777         * disasm-selftests.c: Fix common/ includes.
6778         * defs.h: Fix common/ includes.
6779         * csky-tdep.c: Fix common/ includes.
6780         * cp-valprint.c: Fix common/ includes.
6781         * cp-support.h: Fix common/ includes.
6782         * cp-support.c: Fix common/ includes.
6783         * corelow.c: Fix common/ includes.
6784         * completer.h: Fix common/ includes.
6785         * completer.c: Fix common/ includes.
6786         * compile/compile.c: Fix common/ includes.
6787         * compile/compile-loc2c.c: Fix common/ includes.
6788         * compile/compile-cplus-types.c: Fix common/ includes.
6789         * compile/compile-cplus-symbols.c: Fix common/ includes.
6790         * command.h: Fix common/ includes.
6791         * cli/cli-dump.c: Fix common/ includes.
6792         * cli/cli-cmds.c: Fix common/ includes.
6793         * charset.c: Fix common/ includes.
6794         * build-id.c: Fix common/ includes.
6795         * btrace.h: Fix common/ includes.
6796         * btrace.c: Fix common/ includes.
6797         * breakpoint.h: Fix common/ includes.
6798         * breakpoint.c: Fix common/ includes.
6799         * ax.h:
6800         (enum agent_op): Fix common/ includes.
6801         * ax-general.c (struct aop_map): Fix common/ includes.
6802         * ax-gdb.c: Fix common/ includes.
6803         * auxv.c: Fix common/ includes.
6804         * auto-load.c: Fix common/ includes.
6805         * arm-tdep.c: Fix common/ includes.
6806         * arch/riscv.c: Fix common/ includes.
6807         * arch/ppc-linux-common.c: Fix common/ includes.
6808         * arch/i386.c: Fix common/ includes.
6809         * arch/arm.c: Fix common/ includes.
6810         * arch/arm-linux.c: Fix common/ includes.
6811         * arch/arm-get-next-pcs.c: Fix common/ includes.
6812         * arch/amd64.c: Fix common/ includes.
6813         * arch/aarch64.c: Fix common/ includes.
6814         * arch/aarch64-insn.c: Fix common/ includes.
6815         * arch-utils.c: Fix common/ includes.
6816         * amd64-windows-tdep.c: Fix common/ includes.
6817         * amd64-tdep.c: Fix common/ includes.
6818         * amd64-sol2-tdep.c: Fix common/ includes.
6819         * amd64-obsd-tdep.c: Fix common/ includes.
6820         * amd64-nbsd-tdep.c: Fix common/ includes.
6821         * amd64-linux-tdep.c: Fix common/ includes.
6822         * amd64-linux-nat.c: Fix common/ includes.
6823         * amd64-fbsd-tdep.c: Fix common/ includes.
6824         * amd64-fbsd-nat.c: Fix common/ includes.
6825         * amd64-dicos-tdep.c: Fix common/ includes.
6826         * amd64-darwin-tdep.c: Fix common/ includes.
6827         * agent.c: Fix common/ includes.
6828         * ada-lang.h: Fix common/ includes.
6829         * ada-lang.c: Fix common/ includes.
6830         * aarch64-tdep.c: Fix common/ includes.
6831
6832 2019-01-25  Tom Tromey  <tom@tromey.com>
6833
6834         * common/create-version.sh: Use common/version.h.
6835
6836 2019-01-24  Pedro Alves  <palves@redhat.com>
6837
6838         * infrun.c (signal_stop, signal_print, signal_program)
6839         (signal_catch, signal_pass): Now arrays instead of pointers.
6840         (update_signals_program_target, do_target_resume)
6841         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6842         * linux-nat.c (linux_nat_target::pass_signals)
6843         (linux_nat_target::create_inferior, linux_nat_target::attach):
6844         Adjust.
6845         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6846         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6847         * procfs.c (procfs_target::pass_signals): Adjust.
6848         * record-full.c (record_full_target::resume): Adjust.
6849         * remote.c (remote_target::pass_signals)
6850         (remote_target::program_signals): Adjust.
6851         * target-debug.h (target_debug_print_signals): Now takes a
6852         gdb::array_view as parameter.  Adjust.
6853         * target.h (target_ops) <pass_signals, program_signals>: Replace
6854         pointer and length parameters with gdb::array_view.
6855         (target_pass_signals, target_program_signals): Likewise.
6856         * target-delegates.c: Regenerate.
6857
6858 2019-01-24  Pedro Alves  <palves@redhat.com>
6859
6860         * common/forward-scope-exit.h
6861         (forward_scope_exit::forward_scope_exit): Pass arguments to
6862         m_bind_function directly, instead of creating a std::bind and
6863         copying that.
6864
6865 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6866
6867         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6868         for static members.
6869         (pass_in_v_vfp_candidate): Likewise.
6870
6871 2019-01-23  Tom Tromey  <tom@tromey.com>
6872             Pedro Alves  <palves@redhat.com>
6873
6874         * regcache.c (class regcache_invalidator): Remove.
6875         (regcache::raw_write): Use make_scope_exit.
6876
6877 2019-01-23  Tom Tromey  <tom@tromey.com>
6878
6879         * ui-out.h (class ui_out_emit_type): Update comment.
6880
6881 2019-01-23  Tom Tromey  <tom@tromey.com>
6882
6883         * infrun.c (fetch_inferior_event): Update comment.
6884
6885 2019-01-23  Tom Tromey  <tom@tromey.com>
6886             Pedro Alves  <palves@redhat.com>
6887
6888         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6889         parameter.
6890         (fetch_inferior_event): Use SCOPE_EXIT.
6891
6892
6893 2019-01-23  Tom Tromey  <tom@tromey.com>
6894             Pedro Alves  <palves@redhat.com>
6895
6896         * infrun.c (disable_thread_events): Delete.
6897         (stop_all_threads): Use SCOPE_EXIT.
6898
6899 2019-01-23  Tom Tromey  <tom@tromey.com>
6900             Pedro Alves  <palves@redhat.com>
6901
6902         * symfile.c: Include forward-scope-exit.h.
6903         (clear_symtab_users_cleanup): Replace forward declaration with
6904         a FORWARD_SCOPE_EXIT.
6905         (syms_from_objfile_1): Use the forward_scope_exit and
6906         gdb::optional instead of cleanup_function.
6907         (reread_symbols): Use the forward_scope_exit instead of
6908         cleanup_function.
6909         (clear_symtab_users_cleanup): Remove function.
6910
6911 2019-01-23  Tom Tromey  <tom@tromey.com>
6912             Pedro Alves  <palves@redhat.com>
6913
6914         * linux-nat.c: Include scope-exit.h.
6915         (cleanup_target_stop): Remove.
6916         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6917         SCOPE_EXIT.
6918
6919 2019-01-23  Tom Tromey  <tom@tromey.com>
6920             Pedro Alves  <palves@redhat.com>
6921
6922         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6923         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6924
6925 2019-01-23  Tom Tromey  <tom@tromey.com>
6926             Andrew Burgess  <andrew.burgess@embecosm.com>
6927             Pedro Alves  <palves@redhat.com>
6928
6929         * infrun.c (fetch_inferior_event): Use scope_exit.
6930         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6931         * top.c (execute_command): Use scope_exit.
6932         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6933         * utils.c (do_bpstat_clear_actions_cleanup)
6934         (make_bpstat_clear_actions_cleanup): Remove.
6935
6936 2019-01-23  Tom Tromey  <tom@tromey.com>
6937             Pedro Alves  <palves@redhat.com>
6938
6939         * infrun.c: Include "common/scope-exit.h"
6940         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6941         (wait_for_inferior): Use SCOPE_EXIT.
6942         (fetch_inferior_event): Use scope_exit.
6943
6944 2019-01-23  Tom Tromey  <tom@tromey.com>
6945             Pedro Alves  <palves@redhat.com>
6946
6947         * breakpoint.c (create_breakpoint): Remove cleanup.
6948
6949 2019-01-23  Tom Tromey  <tom@tromey.com>
6950             Andrew Burgess  <andrew.burgess@embecosm.com>
6951             Pedro Alves  <palves@redhat.com>
6952
6953 2019-01-23  Pedro Alves  <palves@redhat.com>
6954
6955         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6956
6957 2019-01-23  Pedro Alves  <palves@redhat.com>
6958             Andrew Burgess  <andrew.burgess@embecosm.com>
6959
6960         * gdbthread.h: Include "common/forward-scope-exit.h".
6961         (scoped_finish_thread_state): Redefine custom class in terms of
6962         forward_scope_exit.
6963
6964 2019-01-23  Pedro Alves  <palves@redhat.com>
6965             Andrew Burgess  <andrew.burgess@embecosm.com>
6966
6967         * common/forward-scope-exit.h: New file.
6968
6969 2019-01-23  Pedro Alves  <palves@redhat.com>
6970             Andrew Burgess  <andrew.burgess@embecosm.com>
6971             Tom Tromey  <tom@tromey.com>
6972
6973         * common/scope-exit.h: New file.
6974
6975 2019-01-23  Pedro Alves  <palves@redhat.com>
6976
6977         * common/preprocessor.h (ESC): Rename to ...
6978         (ESC_PARENS): ... this.
6979         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6980         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6981
6982 2019-01-23  Tom Tromey  <tom@tromey.com>
6983
6984         * language.h (class scoped_switch_to_sym_language_if_auto):
6985         Initialize m_lang in both cases.
6986
6987 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6988
6989         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6990         with XCNEW.
6991
6992 2019-01-22  Tom Tromey  <tom@tromey.com>
6993
6994         * corelow.c: Do not include sys/file.h.
6995
6996 2019-01-22  Tom Tromey  <tom@tromey.com>
6997
6998         * tui/tui-wingeneral.h: Include gdb_curses.h.
6999
7000 2019-01-22  Tom Tromey  <tom@tromey.com>
7001
7002         * source-cache.h (class source_cache) <get_source_lines,
7003         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7004
7005 2019-01-22  Tom Tromey  <tom@tromey.com>
7006
7007         * remote-fileio.h (struct remote_target): Declare.
7008
7009 2019-01-22  Tom Tromey  <tom@tromey.com>
7010
7011         * python/py-arch.c: Do not include py-ref.h.
7012         * python/py-bpevent.c: Do not include py-ref.h.
7013         * python/py-cmd.c: Do not include py-ref.h.
7014         * python/py-continueevent.c: Do not include py-ref.h.
7015         * python/py-event.h: Do not include py-ref.h.
7016         * python/py-evtregistry.c: Do not include py-ref.h.
7017         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7018         * python/py-frame.c: Do not include py-ref.h.
7019         * python/py-framefilter.c: Do not include py-ref.h.
7020         * python/py-function.c: Do not include py-ref.h.
7021         * python/py-infevents.c: Do not include py-ref.h.
7022         * python/py-linetable.c: Do not include py-ref.h.
7023         * python/py-objfile.c: Do not include py-ref.h.
7024         * python/py-param.c: Do not include py-ref.h.
7025         * python/py-prettyprint.c: Do not include py-ref.h.
7026         * python/py-progspace.c: Do not include py-ref.h.
7027         * python/py-symbol.c: Do not include py-ref.h.
7028         * python/py-symtab.c: Do not include py-ref.h.
7029         * python/py-type.c: Do not include py-ref.h.
7030         * python/py-unwind.c: Do not include py-ref.h.
7031         * python/py-utils.c: Do not include py-ref.h.
7032         * python/py-value.c: Do not include py-ref.h.
7033         * python/py-varobj.c: Do not include py-ref.h.
7034         * python/py-xmethods.c: Do not include py-ref.h.
7035         * python/python.c: Do not include py-ref.h.
7036         * varobj.c: Do not include py-ref.h.
7037
7038 2019-01-22  Tom Tromey  <tom@tromey.com>
7039
7040         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7041         keyword for bcache.
7042
7043 2019-01-22  Tom Tromey  <tom@tromey.com>
7044
7045         * compile/compile-cplus-types.c: Remove a comment by #include.
7046
7047 2019-01-22  Tom Tromey  <tom@tromey.com>
7048
7049         * compile/gcc-c-plugin.h: Include compile-internal.h.
7050
7051 2019-01-22  Tom Tromey  <tom@tromey.com>
7052
7053         * stabsread.c (EXTERN): Do not define.
7054         (symnum, next_symbol_text_func, processing_gcc_compilation)
7055         (within_function, global_sym_chain, global_stabs)
7056         (previous_stab_code, this_object_header_files)
7057         (n_this_object_header_files)
7058         (n_allocated_this_object_header_files): Define.
7059         * stabsread.h (EXTERN): Never define.  Use "extern".
7060
7061 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7062
7063         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7064         history_value.
7065
7066 2019-01-21  Tom Tromey  <tom@tromey.com>
7067
7068         * ui-out.c: Fix includes.
7069         * tui/tui-source.c: Fix includes.
7070         * target.c: Fix includes.
7071         * remote.c: Fix includes.
7072         * regcache.c: Fix includes.
7073         * python/py-block.c: Fix includes.
7074         * printcmd.c: Fix includes.
7075         * or1k-tdep.c: Fix includes.
7076         * mi/mi-main.c: Fix includes.
7077         * m32r-tdep.c: Fix includes.
7078         * csky-tdep.c: Fix includes.
7079         * compile/compile-cplus-types.c: Fix includes.
7080         * cli/cli-interp.c: Fix includes.
7081
7082 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7083
7084         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7085         for padding.
7086
7087 2019-01-16  Tom Tromey  <tom@tromey.com>
7088
7089         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7090         earlier.
7091         (struct objfile) <msymbols_range>: Move from top level.
7092         <msymbols>: New method.
7093         (class objfile_msymbols): Remove.
7094         * symtab.c (default_collect_symbol_completion_matches_break_on):
7095         Update.
7096         * symmisc.c (dump_msymbols): Update.
7097         * stabsread.c (scan_file_globals): Update.
7098         * objc-lang.c (info_selectors_command, info_classes_command)
7099         (find_methods): Update.
7100         * minsyms.c (find_solib_trampoline_target): Update.
7101         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7102         * coffread.c (coff_symfile_read): Update.
7103         * ada-lang.c (ada_lookup_simple_minsym)
7104         (ada_collect_symbol_completion_matches): Update.
7105
7106 2019-01-16  Tom Tromey  <tom@tromey.com>
7107
7108         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7109         type.  Remove no-argument constructor.
7110         <iterator::operator++>: Simplify.
7111         <begin>: Update.
7112         <end>: Use minimal_symbol_count.
7113
7114 2019-01-16  Tom Tromey  <tom@tromey.com>
7115
7116         * objfiles.h (struct objfile) <psymtabs>: New method.
7117         (class objfile_psymtabs): Remove.
7118         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7119         typedef.
7120         <range>: New method.
7121         (require_partial_symbols): Change return type.
7122         * psymtab.c (require_partial_symbols)
7123         (psym_expand_symtabs_matching): Update.
7124         * mdebugread.c (parse_partial_symbols): Update.
7125         * dbxread.c (dbx_end_psymtab): Update.
7126
7127 2019-01-15  Tom Tromey  <tom@tromey.com>
7128
7129         * symtab.c (lookup_objfile_from_block)
7130         (lookup_symbol_in_objfile_symtabs)
7131         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7132         (find_line_symtab, info_sources_command)
7133         (default_collect_symbol_completion_matches_break_on)
7134         (make_source_files_completion_list): Update.
7135         * symmisc.c (print_objfile_statistics, dump_objfile)
7136         (maintenance_print_symbols, maintenance_info_symtabs)
7137         (maintenance_check_symtabs, maintenance_info_line_tables):
7138         Update.
7139         * source.c (select_source_symtab)
7140         (forget_cached_source_info_for_objfile): Update.
7141         * objfiles.h (class objfile_compunits): Remove.
7142         (struct objfile) <compunits_range>: New typedef.
7143         (compunits): New method.
7144         * objfiles.c (objfile_relocate1): Update.
7145         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7146         * maint.c (count_symtabs_and_blocks): Update.
7147         * linespec.c (iterate_over_all_matching_symtabs): Update.
7148         * cp-support.c (add_symbol_overload_list_qualified): Update.
7149         * coffread.c (coff_symtab_read): Update.
7150         * ada-lang.c (add_nonlocal_symbols)
7151         (ada_collect_symbol_completion_matches)
7152         (ada_add_global_exceptions): Update.
7153
7154 2019-01-15  Tom Tromey  <tom@tromey.com>
7155
7156         * progspace.h (program_space) <objfiles_safe_range>: New
7157         typedef.
7158         <objfiles_safe>: New method.
7159         * objfiles.h (class all_objfiles_safe): Remove.
7160         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7161         * jit.c (jit_inferior_exit_hook): Update.
7162
7163 2019-01-17  Tom Tromey  <tom@tromey.com>
7164
7165         * progspace.h (program_space) <objfiles_range>: New typedef.
7166         <objfiles>: New method.
7167         <objfiles_head>: Rename from objfiles.
7168         (object_files): Update.
7169         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7170         * guile/scm-pretty-print.c
7171         (ppscm_find_pretty_printer_from_objfiles): Update.
7172         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7173         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7174         Update.
7175         * python/py-progspace.c (pspy_get_objfiles): Update.
7176         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7177         Update.
7178         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7179         (objfpy_lookup_objfile_by_build_id): Update.
7180         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7181         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7182         Update.
7183         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7184         (expand_symtab_containing_pc, lookup_objfile_from_block)
7185         (lookup_static_symbol, basic_lookup_transparent_type)
7186         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7187         (find_line_symtab, info_sources_command)
7188         (default_collect_symbol_completion_matches_break_on)
7189         (make_source_files_completion_list, find_main_name): Update.
7190         * symmisc.c (print_symbol_bcache_statistics)
7191         (print_objfile_statistics, maintenance_print_symbols)
7192         (maintenance_print_msymbols, maintenance_print_objfiles)
7193         (maintenance_info_symtabs, maintenance_check_symtabs)
7194         (maintenance_expand_symtabs, maintenance_info_line_tables):
7195         Update.
7196         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7197         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7198         (map_overlay_command, unmap_overlay_command)
7199         (simple_overlay_update, expand_symtabs_matching)
7200         (map_symbol_filenames): Update.
7201         * symfile-debug.c (set_debug_symfile): Update.
7202         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7203         Update.
7204         * source.c (select_source_symtab, forget_cached_source_info):
7205         Update.
7206         * solib.c (solib_read_symbols): Update.
7207         * solib-spu.c (append_ocl_sos): Update.
7208         * psymtab.c (maintenance_print_psymbols)
7209         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7210         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7211         * printcmd.c (info_symbol_command): Update.
7212         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7213         Update.
7214         * objfiles.h (class all_objfiles): Remove.
7215         * objfiles.c (have_partial_symbols, have_full_symbols)
7216         (have_minimal_symbols, qsort_cmp, update_section_map)
7217         (shared_objfile_contains_address_p)
7218         (default_iterate_over_objfiles_in_search_order): Update.
7219         * objc-lang.c (info_selectors_command, info_classes_command)
7220         (find_methods): Update.
7221         * minsyms.c (find_solib_trampoline_target): Update.
7222         * maint.c (maintenance_info_sections)
7223         (maintenance_translate_address, count_symtabs_and_blocks):
7224         Update.
7225         * main.c (captured_main_1): Update.
7226         * linux-thread-db.c (try_thread_db_load_from_pdir)
7227         (has_libpthread): Update.
7228         * linespec.c (iterate_over_all_matching_symtabs)
7229         (search_minsyms_for_name): Update.
7230         * jit.c (jit_find_objf_with_entry_addr): Update.
7231         * hppa-tdep.c (find_unwind_entry)
7232         (hppa_lookup_stub_minimal_symbol): Update.
7233         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7234         Update.
7235         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7236         (elf_gnu_ifunc_resolve_by_got): Update.
7237         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7238         * dwarf-index-write.c (save_gdb_index_command): Update.
7239         * cp-support.c (add_symbol_overload_list_qualified): Update.
7240         * breakpoint.c (create_overlay_event_breakpoint)
7241         (create_longjmp_master_breakpoint)
7242         (create_std_terminate_master_breakpoint)
7243         (create_exception_master_breakpoint): Update.
7244         * blockframe.c (find_pc_partial_function): Update.
7245         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7246         (ada_collect_symbol_completion_matches)
7247         (ada_add_global_exceptions): Update.
7248
7249 2019-01-17  Tom Tromey  <tom@tromey.com>
7250
7251         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7252         declare VEC.
7253         (solib_target_parse_libraries): Change return type.
7254         (library_list_start_segment, library_list_start_section)
7255         (library_list_end_library, library_list_start_library); Update.
7256         (solib_target_free_library_list): Remove.
7257         (solib_target_parse_libraries): Remove cleanup.  Change return
7258         type.
7259         (solib_target_current_sos): Update.
7260
7261 2019-01-17  Tom Tromey  <tromey@bapiya>
7262
7263         * valprint.c: Replace "the the" with "the".
7264         * symtab.c: Replace "the the" with "the".
7265         * solib.c: Replace "the the" with "the".
7266         * solib-dsbt.c: Replace "the the" with "the".
7267         * linespec.c: Replace "the the" with "the".
7268         * dwarf2loc.h: Replace "the the" with "the".
7269         * amd64-windows-tdep.c: Replace "the the" with "the".
7270         * aarch64-tdep.c: Replace "the the" with "the".
7271
7272 2019-01-16  Keith Seitz  <keiths@redhat.com>
7273
7274         PR gdb/23773
7275         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7276         <builder>: Rename to ..
7277         <m_builder>: ... this and make private.
7278         (dwarf2_cu::get_builder): New method.  Change all users of
7279         `builder' to use this method.
7280         (dwarf2_start_symtab): Move to ...
7281         (dwarf2_cu::start_symtab): ... here.  Update all callers
7282         (setup_type_unit_groups): Move to ...
7283         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7284         callers.
7285         (dwarf2_cu::reset_builder): New method.
7286         (process_full_compunit, process_full_type_unit): Use
7287         dwarf2_cu::reset_builder.
7288         (follow_die_offset): Record the ancestor CU if it is different
7289         from the followed DIE's CU.
7290         (follow_die_sig_1): Likewise.
7291
7292 2019-01-15  Tom Tromey  <tom@tromey.com>
7293
7294         * remote.c (class remote_state) <buf>: Now a char_vector.
7295         <buf_size>: Remove.
7296         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7297         parameter.
7298         (remote_target::getpkt_or_notif_sane_1)
7299         (remote_target::getpkt_sane)
7300         (remote_target::getpkt_or_notif_sane): Likewise.
7301         (class remote_target) <putpkt>: New overload.
7302         (remote_target::read_frame): Change type of "buf_p".  Remove
7303         sizeof_p parameter.
7304         (packet_ok): New overload.
7305         (packet_check_result): New overload.
7306         Update all uses.
7307
7308 2019-01-14  Tom Tromey  <tom@tromey.com>
7309
7310         * remote-notif.c (handle_notification, remote_notif_ack)
7311         (remote_notif_parse): Make "buf" const.
7312         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7313         const.
7314         (remote_notif_parse, remote_notif_ack, handle_notification):
7315         Likewise.
7316         * remote.c (remote_notif_stop_parse): Make "buf" const.
7317         (remote_target::remote_parse_stop_reply): Make "buf" const.
7318         (remote_notif_stop_ack): Make "buf" const.
7319
7320 2019-01-14  Tom Tromey  <tom@tromey.com>
7321
7322         * remote.c (remote_console_output): Make parameter const.
7323
7324 2019-01-14  Tom Tromey  <tom@tromey.com>
7325
7326         * target-debug.h (target_debug_print_signals): Constify.
7327         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7328         * procfs.c (procfs_target::pass_signals): Update.
7329         * linux-nat.c (linux_nat_target::pass_signals): Update.
7330         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7331         * target-delegates.c: Rebuild.
7332         * remote.c (remote_target::program_signals): Update.
7333         (remote_target::pass_signals): Update.
7334         * target.c (target_pass_signals): Constify argument.
7335         (target_program_signals): Likewise.
7336         * target.h (struct target_ops) <pass_signals, program_signals>:
7337         Constify argument.
7338         (target_pass_signals, target_program_signals): Constify argument.
7339
7340 2019-01-14  Tom Tromey  <tom@tromey.com>
7341
7342         PR tui/28819:
7343         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7344
7345 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7346
7347         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7348         field.
7349         * rs6000-tdep.c: Include reggroups.h.
7350         (IS_V_ALIAS_PSEUDOREG): Define.
7351         (rs6000_register_name): Return names for the "vX" aliases.
7352         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7353         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7354         aliases.  Call default_register_reggroup_p for all other
7355         pseudo-registers.
7356         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7357         New functions.
7358         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7359         Handle "vX" aliases.
7360         (v_alias_pseudo_register_collect): New function.
7361         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7362         (rs6000_gdbarch_init): Initialize "vX" aliases as
7363         pseudo-registers.  Restore registration of
7364         rs6000_pseudo_register_reggroup_p with
7365         set_tdesc_pseudo_register_reggroup_p.
7366
7367 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7368
7369         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7370         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7371         set_gdbarch_num_pseudo_regs.
7372
7373 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7374
7375         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7376         Remove arg prefixname, add do_set and do_show.
7377         Add member functions set_list and show_list.
7378         * cli/cli-style.c (class cli_style_option): Update accordingly.
7379         (style_set_list): Move to file scope.
7380         (style_show_list): Likewise.
7381         (set_style): Call help_list.
7382         (show_style): Call cmd_show_list.
7383         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7384         Update to use the new macro.
7385
7386 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7387
7388         * ada-lang.c (_initialize_ada_language): Expand the help text
7389         for the "catch exception" command.
7390
7391 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7392
7393         * symtab.c (matching_obj_sections): Initialize obj,
7394         declare it closer to its usage.
7395
7396 2019-01-10  Tom Tromey  <tom@tromey.com>
7397
7398         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7399         (basic_inf_threads_range): Remove.
7400         (inf_threads_range, inf_non_exited_threads_range)
7401         (safe_inf_threads_range): Use next_adapter.
7402
7403 2019-01-10  Keith Seitz  <keiths@redhat.com>
7404
7405         PR gdb/23712
7406         PR symtab/23010
7407         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7408         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7409
7410 2019-01-10  Keith Seitz  <keiths@redhat.com>
7411
7412         PR gdb/23712
7413         PR symtab/23010
7414         * dictionary.c (pending_to_vector): Remove.
7415         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7416         Remove _1 suffix, replacing functions of the same name.  Update
7417         all callers.
7418         (dict_create_hashed, dict_create_hashed_expandable)
7419         (dict_create_linear, dict_create_linear_expandable, dict_free)
7420         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7421         Make functions static.
7422
7423 2019-01-10  Keith Seitz  <keiths@redhat.com>
7424
7425         PR gdb/23712
7426         PR symtab/23010
7427         * dictionary.h (struct dictionary): Replace declaration with
7428         multidictionary.
7429         (dict_create_hashed, dict_create_hashed_expandable)
7430         (dict_create_linear, dict_create_linear_expandable)
7431         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7432         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7433         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7434         taking multidictionary argument.
7435         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7436         * block.h (struct block) <dict>: Change to multidictionary
7437         and rename `multidict'.
7438         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7439         symmisc.c: Update all dictionary references to multidictionary.
7440
7441 2019-01-10  Keith Seitz  <keiths@redhat.com>
7442
7443         PR gdb/23712
7444         PR symtab/23010
7445         * dictionary.c: Include unordered_map.
7446         (pending_to_vector): New function.
7447         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7448         Rewrite the non-"_1" functions to take vector instead
7449         of linked list.
7450         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7451         "new" _1 versions of the same name.
7452         (multidictionary): Define.
7453         (std::hash<enum language): New definition.
7454         (collate_pending_symbols_by_language, mdict_create_hashed)
7455         (mdict_create_hashed_expandable, mdict_create_linear)
7456         (mdict_create_linear_expandable, mdict_free)
7457         (find_language_dictionary, create_new_language_dictionary)
7458         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7459         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7460         (mdict_size, mdict_empty): New functions.
7461         * dictionary.h (mdict_iterator): Define.
7462
7463 2019-01-10  Pedro Alves  <palves@redhat.com>
7464
7465         * breakpoint.c (read_uploaded_action)
7466         (create_tracepoint_from_upload): Adjust to use
7467         gdb::unique_xmalloc_ptr.
7468         * ctf.c (ctf_write_uploaded_tp):
7469         (SET_ARRAY_FIELD): Use emplace_back.
7470         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7471         * tracefile-tfile.c (tfile_write_uploaded_tp):
7472         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7473         gdb::unique_xmalloc_ptr.
7474         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7475         at_string, cond_string, cmd_strings>: Replace char pointers
7476         with gdb::unique_xmalloc_ptr.
7477
7478 2019-01-10  Pedro Alves  <palves@redhat.com>
7479
7480         * solib-target.c (library_list_start_library): Don't xstrdup name.
7481
7482 2019-01-10  Pedro Alves  <palves@redhat.com>
7483
7484         * mdebugread.c (parse_partial_symbols): Use
7485         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7486
7487 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7488
7489         * linux-fork.c (scoped_switch_fork_info)
7490         <~scoped_switch_fork_info>: Fix incorrect variable name.
7491
7492 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7493
7494         * linux-fork.c (scoped_switch_fork_info)
7495         <scoped_switch_fork_info>: Make explicit.
7496         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7497
7498 2019-01-10  Tom Tromey  <tom@tromey.com>
7499
7500         * objfiles.h (objfile::reset_psymtabs): Update.
7501         * objfiles.c (objfile::objfile): Update.
7502         * psymtab.h (psymtab_storage::obstack): Update.
7503         (psymtab_storage::m_obstack): Use gdb::optional.
7504         (class psymtab_storage): Update comment.  Remove objfile
7505         parameter.
7506         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7507
7508 2019-01-10  Tom Tromey  <tom@tromey.com>
7509
7510         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7511         <free_psymtabs>: Now private.
7512         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7513         (allocate_psymtab): Use new method.
7514
7515 2019-01-10  Tom Tromey  <tom@tromey.com>
7516
7517         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7518         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7519         * mdebugread.c (parse_partial_symbols): Use
7520         allocate_dependencies.
7521         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7522         allocate_dependencies.
7523         (process_psymtab_comp_unit_reader)
7524         (build_type_psymtab_dependencies): Likewise.
7525         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7526
7527 2019-01-10  Tom Tromey  <tom@tromey.com>
7528
7529         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7530         PSYMBOL_SET_LANGUAGE.
7531         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7532
7533 2019-01-10  Tom Tromey  <tom@tromey.com>
7534
7535         * psymtab.h (psymtab_storage::obstack): New method.
7536         <m_obstack>: Rename from obstack; now private.
7537         * psymtab.c (psymtab_storage): Update.
7538         * dwarf2read.c (create_addrmap_from_index)
7539         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7540         Update.
7541
7542 2019-01-10  Tom Tromey  <tom@tromey.com>
7543
7544         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7545         * objfiles.h (objfile::reset_psymtabs): New method.
7546
7547 2019-01-10  Tom Tromey  <tom@tromey.com>
7548
7549         * symmisc.c (print_symbol_bcache_statistics): Update.
7550         (print_objfile_statistics): Update.
7551         * symfile.c (reread_symbols): Update.
7552         * psymtab.h (class psymtab_storage): New.
7553         * psymtab.c (psymtab_storage): New constructor.
7554         (~psymtab_storage): New destructor.
7555         (require_partial_symbols): Update.
7556         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7557         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7558         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7559         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7560         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7561         (start_psymtab_common, end_psymtab_common)
7562         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7563         (allocate_psymtab): Update.
7564         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7565         Update.
7566         (dump_psymtab_addrmap, maintenance_print_psymbols)
7567         (maintenance_check_psymtabs): Update.
7568         (class objfile_psymtabs): Move to objfiles.h.
7569         * psympriv.h (discard_psymtab): Now inline.
7570         (psymtab_discarder::psymtab_discarder): Update.
7571         (psymtab_discarder::~psymtab_discarder): Update.
7572         (ALL_OBJFILE_PSYMTABS): Rewrite.
7573         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7574         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7575         Remove fields.
7576         <partial_symtabs>: New field.
7577         (class objfile_psymtabs): Move from psymtab.h.  Update.
7578         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7579         psymbol_cache.
7580         (objfile::~objfile): Don't destroy psymbol_cache.
7581         * mdebugread.c (parse_partial_symbols): Update.
7582         * dwarf2read.c (create_addrmap_from_index)
7583         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7584         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7585         (add_partial_subprogram, dwarf2_ranges_read): Update.
7586         * dwarf-index-write.c (write_address_map)
7587         (write_one_signatured_type, recursively_write_psymbols)
7588         (class debug_names, class debug_names, write_psymtabs_to_index):
7589         Update.
7590
7591 2019-01-10  Tom Tromey  <tom@tromey.com>
7592
7593         * symtab.h (SYMBOL_SET_NAMES): Update.
7594         (symbol_set_names): Update.
7595         (MSYMBOL_SET_NAMES): Update.
7596         * symtab.c (symbol_set_names): Change argument to be an
7597         objfile_per_bfd_storage.
7598         * psymtab.c (add_psymbol_to_bcache): Update.
7599         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7600
7601 2019-01-10  Tom Tromey  <tom@tromey.com>
7602
7603         * symtab.c (create_demangled_names_hash): Change argument to be an
7604         objfile_per_bfd_storage.
7605         (symbol_set_names): Update.
7606
7607 2019-01-10  Tom Tromey  <tom@tromey.com>
7608
7609         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7610         init_psymbol_list.
7611         * psymtab.c (init_psymbol_list): Do nothing if already called.
7612         * psympriv.h (init_psymbol_list): Add comment.
7613         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7614         init_psymbol_list.
7615         * dbxread.c (dbx_symfile_read): Unconditionally call
7616         init_psymbol_list.
7617
7618 2019-01-10  Tom Tromey  <tom@tromey.com>
7619
7620         * xcoffread.c (scan_xcoff_symtab): Update.
7621         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7622         "where".
7623         * mdebugread.c (parse_partial_symbols)
7624         (handle_psymbol_enumerators): Update.
7625         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7626         * dbxread.c (read_dbx_symtab): Update.
7627         * psympriv.h (psymbol_placement): New enum.
7628         (add_psymbol_to_list): Update.
7629
7630 2019-01-10  Tom Tromey  <tom@tromey.com>
7631
7632         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7633         static_psymbols parameters.
7634         (scan_xcoff_symtab): Update.
7635         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7636         static_psymbols parameters.
7637         * psympriv.h (start_psymtab_common): Update.
7638         * mdebugread.c (parse_partial_symbols): Update.
7639         * dwarf2read.c (create_partial_symtab): Update.
7640         * dbxread.c (read_dbx_symtab): Update.
7641         (start_psymtab): Remove global_psymbols and static_psymbols
7642         parameters.
7643
7644 2019-01-10  Tom Tromey  <tom@tromey.com>
7645
7646         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7647         * psymtab.c (allocate_psymtab): Add comment.
7648         * psympriv.h (allocate_psymtab): Add comment.
7649         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7650         initializations.
7651         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7652
7653 2019-01-10  Tom Tromey  <tom@tromey.com>
7654
7655         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7656         Don't declare.
7657         * mipsread.c: Include mdebugread.h.
7658         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7659         Declare.
7660         * elfread.c: Include mdebugread.h.
7661
7662 2019-01-09  Tom Tromey  <tom@tromey.com>
7663
7664         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7665         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7666         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7667         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7668         (psym_lookup_symbol, psym_find_last_source_symtab)
7669         (psym_forget_cached_source_info, psym_print_stats)
7670         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7671         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7672         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7673         (psym_find_compunit_symtab_by_address)
7674         (maintenance_print_psymbols, maintenance_info_psymtabs)
7675         (maintenance_check_psymtabs): Use ranged for.
7676         * psymtab.h (class objfile_psymtabs): New.
7677         (require_partial_symbols): Return objfile_psymtabs.
7678         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7679
7680 2019-01-09  Tom Tromey  <tom@tromey.com>
7681
7682         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7683         (find_pc_mapped_section, list_overlays_command)
7684         (map_overlay_command, unmap_overlay_command)
7685         (simple_overlay_update): Use all_objfiles.
7686         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7687         * printcmd.c (info_symbol_command): Use all_objfiles.
7688         * objfiles.h (ALL_OBJSECTIONS): Remove.
7689         * maint.c (maintenance_translate_address): Use all_objfiles.
7690         * gcore.c (gcore_create_callback): Use all_objfiles.
7691         (objfile_find_memory_regions): Likewise.
7692
7693 2019-01-09  Tom Tromey  <tom@tromey.com>
7694
7695         * symtab.c (find_line_symtab, info_sources_command)
7696         (make_source_files_completion_list): Use objfile_compunits.
7697         * source.c (select_source_symtab): Use objfile_compunits.
7698         * objfiles.h (struct objfile): Update comment.
7699         (ALL_OBJFILES): Remove.
7700         (ALL_FILETABS): Remove.
7701         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7702         objfile_compunits.
7703
7704 2019-01-09  Tom Tromey  <tom@tromey.com>
7705
7706         * symmisc.c (print_objfile_statistics, dump_objfile)
7707         (maintenance_print_symbols): Use compunit_filetabs.
7708         * source.c (forget_cached_source_info_for_objfile): Use
7709         compunit_filetabs.
7710         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7711         (ALL_FILETABS): Use compunit_filetabs.
7712         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7713         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7714
7715 2019-01-09  Tom Tromey  <tom@tromey.com>
7716
7717         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7718         (compunit_filetabs): New.
7719         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7720         compunit_filetabs.
7721         (info_sources_command, make_source_files_completion_list): Remove
7722         declaration.
7723         * symmisc.c (print_objfile_statistics, dump_objfile)
7724         (maintenance_print_symbols): Remove declaration.
7725         (maintenance_info_symtabs): Use compunit_filetabs.
7726         (maintenance_info_line_tables): Likewise.
7727         * source.c (select_source_symtab): Change local variable name.
7728         (forget_cached_source_info_for_objfile): Remove declaration.
7729         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7730         * objfiles.c (objfile_relocate1): Remove declaration.
7731         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7732         declaration.
7733         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7734         * coffread.c (coff_symtab_read): Remove declaration.
7735         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7736         compunit_filetabs.
7737
7738 2019-01-09  Tom Tromey  <tom@tromey.com>
7739
7740         * symtab.c (lookup_objfile_from_block)
7741         (find_pc_sect_compunit_symtab, search_symbols)
7742         (default_collect_symbol_completion_matches_break_on): Use
7743         objfile_compunits.
7744         * objfiles.h (ALL_COMPUNITS): Remove.
7745         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7746         * cp-support.c (add_symbol_overload_list_qualified): Use
7747         objfile_compunits.
7748         * ada-lang.c (ada_collect_symbol_completion_matches)
7749         (ada_add_global_exceptions): Use objfile_compunits.
7750
7751 2019-01-09  Tom Tromey  <tom@tromey.com>
7752
7753         * source.c (select_source_symtab)
7754         (forget_cached_source_info_for_objfile): Remove declaration.
7755         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7756         declaration.
7757         * maint.c (count_symtabs_and_blocks): Remove declaration.
7758         * cp-support.c (add_symbol_overload_list_qualified): Remove
7759         declaration.
7760         * coffread.c (coff_symtab_read): Remove declaration.
7761         * symtab.c (lookup_symbol_in_objfile_symtabs)
7762         (basic_lookup_transparent_type_1): Use objfile_compunits.
7763         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7764         (info_sources_command, search_symbols)
7765         (default_collect_symbol_completion_matches_break_on)
7766         (make_source_files_completion_list): Remove declaration.
7767         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7768         (ada_collect_symbol_completion_matches)
7769         (ada_add_global_exceptions): Remove declaration.
7770         * linespec.c (iterate_over_all_matching_symtabs): Use
7771         objfile_compunits.
7772         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7773         (class objfile_compunits): New.
7774         (ALL_COMPUNITS): Use objfile_compunits.
7775         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7776         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7777         objfile_compunits.
7778         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7779
7780 2019-01-09  Tom Tromey  <tom@tromey.com>
7781
7782         * symtab.c (search_symbols)
7783         (default_collect_symbol_completion_matches_break_on): Use
7784         objfile_msymbols.
7785         * ada-lang.c (ada_lookup_simple_minsym)
7786         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7787         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7788         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7789         objfile_msymbols.
7790         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7791         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7792         * objc-lang.c (find_methods): Use objfile_msymbols.
7793         (info_selectors_command, info_classes_command): Likewise.
7794         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7795         * objfiles.h (class objfile_msymbols): New.
7796         (ALL_OBJFILE_MSYMBOLS): Remove.
7797         (ALL_MSYMBOLS): Remove.
7798
7799 2019-01-09  Tom Tromey  <tom@tromey.com>
7800
7801         * common/next-iterator.h (next_adapter): Add Iterator template
7802         parameter.
7803         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7804         (class all_objfiles_safe): New.
7805         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7806         * objfiles.c (put_objfile_before): Update comment.
7807         (add_separate_debug_objfile): Likewise.
7808         (free_all_objfiles): Use all_objfiles_safe.
7809         (objfile_purge_solibs): Likewise.
7810
7811 2019-01-09  Tom Tromey  <tom@tromey.com>
7812
7813         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7814         (expand_symtab_containing_pc, lookup_static_symbol)
7815         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7816         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7817         all_objfiles.
7818         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7819         * breakpoint.c (create_overlay_event_breakpoint)
7820         (create_longjmp_master_breakpoint)
7821         (create_std_terminate_master_breakpoint)
7822         (create_exception_master_breakpoint): Use all_objfiles.
7823         * linux-thread-db.c (try_thread_db_load_from_pdir)
7824         (has_libpthread): Use all_objfiles.
7825         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7826         * linespec.c (iterate_over_all_matching_symtabs)
7827         (search_minsyms_for_name): Use all_objfiles.
7828         * maint.c (maintenance_info_sections): Use all_objfiles.
7829         * main.c (captured_main_1): Use all_objfiles.
7830         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7831         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7832         * guile/scm-pretty-print.c
7833         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7834         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7835         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7836         (maintenance_print_msymbols): Use all_objfiles.
7837         * source.c (select_source_symtab): Use all_objfiles.
7838         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7839         * symfile.c (remove_symbol_file_command)
7840         (expand_symtabs_matching, map_symbol_filenames): Use
7841         all_objfiles.
7842         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7843         all_objfiles.
7844         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7845         * objc-lang.c (find_methods): Use all_objfiles.
7846         * objfiles.c (have_partial_symbols, have_full_symbols)
7847         (have_minimal_symbols, qsort_cmp)
7848         (default_iterate_over_objfiles_in_search_order): Use
7849         all_objfiles.
7850         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7851         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7852         (maintenance_check_psymtabs): Use all_objfiles.
7853         (ALL_PSYMTABS): Remove.
7854         * compile/compile-object-run.c (do_module_cleanup): Use
7855         all_objfiles.
7856         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7857         * cp-support.c (add_symbol_overload_list_qualified): Use
7858         all_objfiles.
7859         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7860         Use all_objfiles.
7861         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7862         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7863         all_objfiles.
7864         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7865         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7866         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7867         Uses all_objfiles.
7868         * solib.c (solib_read_symbols): Use all_objfiles
7869
7870 2019-01-09  Tom Tromey  <tom@tromey.com>
7871
7872         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7873         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7874         all_objfiles.
7875         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7876         * symmisc.c (print_symbol_bcache_statistics)
7877         (print_objfile_statistics, maintenance_print_objfiles)
7878         (maintenance_info_symtabs, maintenance_check_symtabs)
7879         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7880         all_objfiles.
7881         * source.c (forget_cached_source_info): Use all_objfiles.
7882         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7883         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7884         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7885         * objfiles.c (update_section_map): Use all_objfiles.
7886         (shared_objfile_contains_address_p): Likewise.
7887         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7888         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7889
7890 2019-01-09  Tom Tromey  <tom@tromey.com>
7891
7892         * common/next-iterator.h: New file.
7893         * objfiles.h (class all_objfiles): New.
7894         (struct objfile_iterator): New.
7895
7896 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7897
7898         * NEWS: Move the description of the changed "frame", "select-frame",
7899          and "info frame" commands to the Changed commands section.
7900
7901 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7902
7903         * gdbtypes.c (check_stub_method_group): Remove handling of old
7904         mangling schemes.
7905         * linespec.c (find_methods): Likewise.
7906         * stabsread.c (read_member_functions): Likewise.
7907         * valops.c (search_struct_method): Likewise.
7908         (value_struct_elt_for_reference): Likewise.
7909         * NEWS: Mention this change.
7910
7911 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7912
7913         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7914         print_source_lines.
7915         * source.c (print_source_lines_base): Update line number check.
7916         (print_source_lines): New function.
7917         (source_lines_range::source_lines_range): New function.
7918         * source.h (class source_lines_range): New class.
7919         (print_source_lines): New declaration.
7920
7921 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7922
7923         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7924
7925 2019-01-08  Tom Tromey  <tom@tromey.com>
7926             Simon Marchi  <simon.marchi@ericsson.com>
7927
7928         PR gdb/24060
7929         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7930         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7931         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7932         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7933         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7934         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7935
7936 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7937
7938         * source.c (select_source_symtab): Move header comment to
7939         declaration in source.h.
7940         (forget_cached_source_info_for_objfile): Likewise.
7941         (forget_cached_source_info): Likewise.
7942         (identify_source_line): Likewise.
7943         * source.h (identify_source_line): Move declaration from symtab.h
7944         and add comment from source.c
7945         (print_source_lines): Likewise.
7946         (forget_cached_source_info_for_objfile): Likewise.
7947         (forget_cached_source_info): Likewise.
7948         (select_source_symtab): Likewise.
7949         (enum print_source_lines_flag): Move definition from symtab.h.
7950         * symtab.h (identify_source_line): Move declaration to source.h.
7951         (print_source_lines): Likewise.
7952         (forget_cached_source_info_for_objfile): Likewise.
7953         (forget_cached_source_info): Likewise.
7954         (select_source_symtab): Likewise.
7955         (enum print_source_lines_flag): Move definition to source.h.
7956         * tui/tui-hooks.c: Add 'source.h' include.
7957
7958 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7959
7960         * source.c (print_source_lines_base): Handle requests to print
7961         reverse line number sequences, and guard against empty lines
7962         string.
7963
7964 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7965
7966         * source.c (print_source_lines_base): Fix skip of '\r' if next
7967         character is '\n'.
7968
7969 2019-01-06  Tom Tromey  <tom@tromey.com>
7970
7971         * c-exp.y (struct c_parse_state) <macro_original_text,
7972         expansion_obstack>: New member.
7973         (macro_original_text, expansion_obstack): Remove globals.
7974         (scan_macro_expansion, scanning_macro_expansion)
7975         (finished_macro_expansion): Update.
7976         (scan_macro_cleanup): Remove.
7977         (yylex, c_parse): Update.
7978
7979 2019-01-06  Tom Tromey  <tom@tromey.com>
7980
7981         * c-exp.y (struct c_parse_state) <strings>: New member.
7982         (operator_stoken): Update.
7983
7984 2019-01-06  Tom Tromey  <tom@tromey.com>
7985
7986         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7987         (union type_stack_elt) <typelist_val>: Now a pointer to
7988         std::vector.
7989         (type_stack_cleanup): Don't declare.
7990         (push_typelist): Update.
7991         * parse.c (pop_typelist): Return a std::vector.
7992         (push_typelist): Take a std::vector.
7993         (follow_types): Update.  Do not free args.
7994         (type_stack_cleanup): Remove.
7995         * c-exp.y (struct c_parse_state): New.
7996         (cpstate): New global.
7997         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7998         (nonempty_typelist): Update.
7999         (func_mod): Create a new vector.
8000         (c_parse): Create a c_parse_state.
8001         (check_parameter_typelist): Do not delete params.
8002         (function_method): Update.  Do not delete type_list.
8003
8004 2019-01-06  Tom Tromey  <tom@tromey.com>
8005
8006         PR gdb/28155:
8007         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8008         check_typedef.
8009         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8010         (print_return_value): Likewise.
8011
8012 2019-01-05  Tom Tromey  <tom@tromey.com>
8013
8014         * contrib/cleanup_check.py: Remove.
8015         * contrib/gcc-with-excheck: Remove.
8016         * contrib/exsummary.py: Remove.
8017         * contrib/excheck.py: Remove.
8018
8019 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8020
8021         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8022         NULL. Initialize tpprev to NULL instead of assigning it
8023         to NULL on the next statement.
8024         * windows-nat.c (windows_delete_thread): Remove check for
8025         main_thread_id before printing thread exit notifications.
8026         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8027         Remove thread ID check against main_thread_id.
8028         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8029         windows_delete_thread.
8030         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8031
8032 2019-01-04  Tom Tromey  <tom@tromey.com>
8033
8034         * compile/compile.c (_initialize_compile): Use upper case for
8035         metasyntactic variables.
8036         * symmisc.c (_initialize_symmisc): Use upper case for
8037         metasyntactic variables.
8038         * psymtab.c (_initialize_psymtab): Use upper case for
8039         metasyntactic variables.
8040         * demangle.c (demangle_command): Use upper case for metasyntactic
8041         variables.
8042         (_initialize_demangler): Likewise.
8043         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8044         variables.
8045
8046 2019-01-03  Tom Tromey  <tom@tromey.com>
8047
8048         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8049
8050 2019-01-03  Tom Tromey  <tom@tromey.com>
8051
8052         * python/py-symtab.c (salpy_str): Update.
8053         (struct salpy_sal_object) <symtab>: Now a PyObject.
8054         (salpy_dealloc): Update.
8055         (del_objfile_sal): Use gdbpy_ref.
8056
8057 2019-01-03  Tom Tromey  <tom@tromey.com>
8058
8059         * python/py-type.c (convert_field): Use new_reference.  Return
8060         gdbpy_ref.
8061         (make_fielditem): Return gdbpy_ref.
8062         (typy_fields): Update.
8063         (typy_getitem): Update.
8064         (field_name): Return gdbpy_ref.  Use new_reference.
8065         (typy_iterator_iternext): Update.
8066
8067 2019-01-03  Tom Tromey  <tom@tromey.com>
8068
8069         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8070
8071 2019-01-03  Tom Tromey  <tom@tromey.com>
8072
8073         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8074         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8075         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8076         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8077         (pspy_set_type_printers): Likewise.
8078         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8079         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8080         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8081         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8082         (objfpy_set_type_printers): Likewise.
8083
8084 2019-01-03  Tom Tromey  <tom@tromey.com>
8085
8086         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8087         (gdbpy_print_stack): Use gdbpy_err_fetch.
8088         * python/python-internal.h (class gdbpy_err_fetch): New class.
8089         (class gdbpy_enter) <m_error_type, m_error_value,
8090         m_error_traceback>: Remove.
8091         <m_error>: New member.
8092         (gdbpy_exception_to_string): Don't declare.
8093         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8094         * python/py-value.c (convert_value_from_python): Use
8095         gdbpy_err_fetch.
8096         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8097         gdbpy_exception_to_string.
8098         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8099         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8100         gdbpy_err_fetch.
8101
8102 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8103
8104         * linux-nat.c (delete_lwp_cleanup): Delete.
8105         (struct lwp_deleter): New struct.
8106         (lwp_info_up): New typedef.
8107         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8108         lwp_info_up.
8109
8110 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8111
8112         * linux-fork.c (class scoped_switch_fork_info): New class.
8113         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8114
8115 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8116
8117         * valops.c (find_overload_match): Remove use of null_cleanup, and
8118         calls to do_cleanups.
8119
8120 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8121
8122         * compile/compile-cplus-types.c
8123         (compile_cplus_instance::decl_name): Handle changes to
8124         cp_func_name.
8125         * cp-support.c (cp_func_name): Update header comment, update
8126         return type.
8127         * cp-support.h (cp_func_name): Update return type in declaration.
8128         * valops.c (find_overload_match): Move temp_func local to top
8129         level of function and change its type.  Use temp_func to hold and
8130         delete temporary string obtained from cp_func_name.
8131
8132 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8133
8134         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8135         gdb::char_vector, remove cleanup, and update uses of `msg`.
8136
8137 2019-01-03  Jim Wilson  <jimw@sifive.com>
8138
8139         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8140
8141 2019-01-02  Tom Tromey  <tom@tromey.com>
8142
8143         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8144         (tdesc_parse_xml): Remove cleanups.
8145         * target-descriptions.h (make_cleanup_free_target_description):
8146         Don't declare.
8147         (target_desc_deleter): New struct.
8148         (target_desc_up): New typedef.
8149         * target-descriptions.c (target_desc_deleter::operator()): Rename
8150         from free_target_description.
8151         (make_cleanup_free_target_description): Remove.
8152
8153 2019-01-02  Tom Tromey  <tom@tromey.com>
8154
8155         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8156         constructor, destructor.
8157         (linespec_parser): Remove typedef.
8158         (~linespec_parser): Rename from linespec_parser_delete.
8159         (linespec_lex_to_end, linespec_complete_label)
8160         (linespec_complete): Update.
8161         (decode_line_full): Remove cleanups.
8162         (decode_line_1): Update.
8163
8164 2019-01-02  Tom Tromey  <tom@tromey.com>
8165
8166         * python/python-internal.h (inferior_to_inferior_object): Change
8167         return type.
8168         * python/py-exitedevent.c (create_exited_event_object): Update.
8169         * python/py-inferior.c (inferior_to_inferior_object): Return
8170         gdbpy_ref.
8171         (python_new_inferior, python_inferior_deleted)
8172         (thread_to_thread_object, delete_thread_object)
8173         (build_inferior_list, gdbpy_selected_inferior): Update.
8174         * python/py-infthread.c (create_thread_object): Update.  Also fail
8175         if inferior_to_inferior_object fails.
8176
8177 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8178
8179         * inferior.h (class inferior) <displaced_step_state>: New field.
8180         * infrun.h (struct displaced_step_state): Move here from
8181         infrun.c.  Initialize fields, add constructor.
8182         <inf>: Remove field.
8183         <reset>: New method.
8184         * infrun.c (struct displaced_step_inferior_state): Move to
8185         infrun.h.
8186         (displaced_step_inferior_states): Remove.
8187         (get_displaced_stepping_state): Adust.
8188         (displaced_step_in_progress_any_inferior): Adjust.
8189         (displaced_step_in_progress_thread): Adjust.
8190         (displaced_step_in_progress): Adjust.
8191         (add_displaced_stepping_state): Remove.
8192         (get_displaced_step_closure_by_addr): Adjust.
8193         (remove_displaced_stepping_state): Remove.
8194         (infrun_inferior_exit): Call displaced_step_state.reset.
8195         (use_displaced_stepping): Don't check for NULL.
8196         (displaced_step_prepare_throw): Call
8197         get_displaced_stepping_state.
8198         (displaced_step_fixup): Don't check for NULL.
8199         (prepare_for_detach): Don't check for NULL.
8200
8201 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8202
8203         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8204          in case of call that did not complete.
8205
8206 2019-01-02  Andrey Utkin  <autkin@undo.io>
8207
8208         * symfile.c (find_separate_debug_file): Fix search of debug files for
8209         remote debuggee.
8210
8211 2019-01-02  Tom Tromey  <tom@tromey.com>
8212
8213         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8214         indentation.
8215         * python/py-frame.c (frapy_older): Remove cast.
8216         (frapy_newer): Likewise.
8217         * python/py-breakpoint.c (local_setattro): Remove cast.
8218         * python/py-arch.c (archpy_name): Remove local variable.
8219         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8220
8221 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8222
8223         * unittests/basic_string_view/element_access/char/empty.cc:
8224         Fix year range in copyright header.
8225
8226 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8227
8228         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8229         Delete.
8230         <operator==>: Update with for removed field.
8231         <hash>: Likewise.
8232         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8233         <isa_features>: ...this.
8234         <abi_features>: New field.
8235         (riscv_isa_flen): Update comment.
8236         (riscv_abi_xlen): New declaration.
8237         (riscv_abi_flen): New declaration.
8238         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8239         isa_features.
8240         (riscv_abi_xlen): New function.
8241         (riscv_isa_flen): Update to get answer from isa_features.
8242         (riscv_abi_flen): New function.
8243         (riscv_has_fp_abi): Update to get answer from abi_features.
8244         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8245         xlen and flen.
8246         (riscv_call_info) <xlen, flen>: Update comment.
8247         (riscv_call_arg_struct): Remove invalid assertions
8248         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8249         is removed.
8250         (riscv_gdbarch_init): Gather isa features and abi features
8251         separately, ensure both match on the gdbarch when reusing an old
8252         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8253         a target with 64-bit float hardware.
8254
8255 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8256
8257         * source.c (search_command_helper): Stop reverse search
8258         when line 1 has been searched.
8259
8260 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8261
8262         * record-full.c (record_full_base_target::close): Rewrite
8263         record_full_core_buf_list free logic.
8264
8265 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8266
8267         * break-catch-syscall.c (print_one_catch_syscall): xfree
8268         the last text.
8269
8270 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8271
8272         * top.c (print_gdb_version): Update Copyright year in version
8273         message.
8274
8275 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8276
8277         Update copyright year range in all GDB files.
8278
8279 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8280
8281         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8282
8283 For older changes see ChangeLog-2018.
8284 \f
8285 Local Variables:
8286 mode: change-log
8287 left-margin: 8
8288 fill-column: 74
8289 version-control: never
8290 coding: utf-8
8291 End:
8292