gdb/ChangeLog

   1 2020-03-26  Tom Tromey  <tom@tromey.com>
   2
   3         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
   4         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
   5         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
   6         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
   7
   8 2020-03-26  Tom Tromey  <tom@tromey.com>
   9
  10         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
  11         file_names_size, file_full_name, file_file_name>: Use const.
  12         <file_name_at, file_names>: Add const overload.
  13         * dwarf2/line-header.c (line_header::file_file_name)
  14         (line_header::file_full_name): Update.
  15
  16 2020-03-26  Tom Tromey  <tom@tromey.com>
  17
  18         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
  19         (macro_start_file, consume_improper_spaces)
  20         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
  21         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
  22         (dwarf_decode_macros): Move to macro.c.
  23         * dwarf2/macro.c: New file.
  24         * dwarf2/macro.h: New file.
  25         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
  26
  27 2020-03-26  Tom Tromey  <tom@tromey.com>
  28
  29         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
  30         method.
  31         * dwarf2/section.c: New method.  From
  32         read_indirect_string_at_offset_from.
  33         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
  34         (read_indirect_string_at_offset_from): Move to section.c.
  35         (read_indirect_string_at_offset): Rewrite.
  36         (read_indirect_line_string_at_offset): Remove.
  37         (read_indirect_string, read_indirect_line_string)
  38         (dwarf_decode_macro_bytes): Update.
  39
  40 2020-03-26  Tom Tromey  <tom@tromey.com>
  41
  42         * dwarf2/section.h (struct dwarf2_section_info)
  43         <overload_complaint>: Declare.
  44         (dwarf2_section_buffer_overflow_complaint): Don't declare.
  45         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
  46         Rename from dwarf2_section_buffer_overflow_complaint.
  47         * dwarf2/read.c (skip_one_die, partial_die_info::read)
  48         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
  49
  50 2020-03-26  Tom Tromey  <tom@tromey.com>
  51
  52         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
  53         Declare.
  54         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
  55         Move from read.c.
  56         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
  57         to section.c.
  58
  59 2020-03-26  Tom Tromey  <tom@tromey.com>
  60
  61         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
  62
  63 2020-03-26  Tom Tromey  <tom@tromey.com>
  64
  65         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
  66         "builder".
  67         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
  68         parameter.
  69         (dwarf_decode_macros): Update.
  70
  71 2020-03-26  Tom Tromey  <tom@tromey.com>
  72
  73         * dwarf2/read.c (read_attribute_value): Update.
  74         (read_indirect_string_from_dwz): Move to dwz.c; change into
  75         method.
  76         (dwarf_decode_macro_bytes): Update.
  77         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
  78         * dwarf2/dwz.c: New file.
  79         * Makefile.in (COMMON_SFILES): Add dwz.c.
  80
  81 2020-03-26  Tom Tromey  <tom@tromey.com>
  82
  83         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
  84         * dwarf2/read.c: Add include.
  85         * dwarf2/index-write.c: Add include.
  86         * dwarf2/index-cache.c: Add include.
  87         * dwarf2/dwz.h: New file.
  88
  89 2020-03-25  Tom Tromey  <tom@tromey.com>
  90
  91         * compile/compile-object-load.c (get_out_value_type): Mention
  92         correct symbol name in error message.
  93
  94 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
  95
  96         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
  97
  98 2020-03-25  Tom de Vries  <tdevries@suse.de>
  99
 100         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
 101         * symmisc.c (dump_symtab_1): Print user and includes fields.
 102         (maintenance_info_symtabs): Same.
 103
 104 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 105
 106         PR gdb/25534
 107         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
 108         (riscv_regcache_cooked_write): New function.
 109         (riscv_push_dummy_call): Use new function.
 110         (riscv_return_value): Likewise.
 111
 112 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
 113
 114         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
 115         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
 116         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
 117         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
 118         * infrun.c (follow_fork): Likewise.
 119         (follow_fork_inferior): Likewise.
 120         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
 121         * linux-nat.h (class linux_nat_target): Likewise.
 122         * remote.c (class remote_target) <follow_fork>: Likewise.
 123         (remote_target::follow_fork): Likewise.
 124         * target-delegates.c: Re-generate.
 125         * target.c (default_follow_fork): Likewise.
 126         (target_follow_fork): Likewise.
 127         * target.h (struct target_ops) <follow_fork>: Likewise.
 128         (target_follow_fork): Likewise.
 129
 130 2020-03-24  Tom de Vries  <tdevries@suse.de>
 131
 132         * psymtab.c (maintenance_info_psymtabs): Print user field.
 133
 134 2020-03-20  Tom Tromey  <tromey@adacore.com>
 135
 136         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
 137         const.
 138         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
 139         const.
 140
 141 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
 142
 143         * ptrace.m4: Don't check for ptrace declaration.
 144         * config.in: Re-generate.
 145         * configure: Re-generate.
 146         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
 147         not defined.
 148
 149 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
 150
 151         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
 152         `PTRACE_TYPE_RET'.
 153         * i386-bsd-nat.c (gdb_ptrace): Likewise.
 154         * sparc-nat.c (gdb_ptrace): Likewise.
 155         * x86-bsd-nat.c (gdb_ptrace): Likewise.
 156
 157 2020-03-20  Tom Tromey  <tromey@adacore.com>
 158
 159         * c-exp.y (lex_one_token): Fix assert.
 160
 161 2020-03-20  Tom Tromey  <tromey@adacore.com>
 162
 163         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
 164         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
 165         strncpy call.
 166
 167 2020-03-20  Tom Tromey  <tromey@adacore.com>
 168
 169         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
 170
 171 2020-03-20  Tom Tromey  <tromey@adacore.com>
 172
 173         * ada-valprint.c (print_variant_part): Remove parameters; switch
 174         to value-based API.
 175         (print_field_values): Likewise.
 176         (ada_val_print_struct_union): Likewise.
 177         (ada_value_print_1): Update.
 178
 179 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
 180
 181         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
 182         nbsd_nat_target instead of inf_ptrace_target.
 183         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
 184         nbsd_nat_target.
 185
 186 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
 187
 188         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
 189         it to the ptrace call.
 190         * (store_registers): Likewise.
 191
 192 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
 193
 194         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
 195         it to the ptrace call.
 196         * (store_registers): Likewise.
 197
 198 2020-03-19  Luis Machado  <luis.machado@linaro.org>
 199
 200         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
 201         valid, fetch vg value from ptrace.
 202
 203 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
 204         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
 205         * inf-ptrace.c: Likewise.
 206         * (gdb_ptrace): Add.
 207         * (inf_ptrace_target::resume): Update.
 208         * (inf_ptrace_target::xfer_partial): Likewise.
 209         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
 210         * (inf_ptrace_peek_poke): Update.
 211
 212 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
 213
 214         * x86-bsd-nat.c (gdb_ptrace): New.
 215         * (x86bsd_dr_set): Add new argument `ptid'.
 216         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
 217         x86bsd_dr_set_addr): Update.
 218
 219 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 220
 221         * remote.c (remote_target::process_stop_reply): Handle events for
 222         all threads differently.
 223
 224 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 225
 226         * completer.c (completion_tracker::remove_completion): Define new
 227         function.
 228         * completer.h (completion_tracker::remove_completion): Declare new
 229         function.
 230         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
 231         when adding a C++ function symbol.
 232
 233 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 234
 235         * completer.c (completion_tracker::completion_hash_entry): Define
 236         new class.
 237         (advance_to_filename_complete_word_point): Call
 238         recompute_lowest_common_denominator.
 239         (completion_tracker::completion_tracker): Call discard_completions
 240         to setup the hash table.
 241         (completion_tracker::discard_completions): Allow for being called
 242         from the constructor, pass new equal function, and element deleter
 243         when constructing the hash table.  Initialise new class member
 244         variables.
 245         (completion_tracker::maybe_add_completion): Remove use of
 246         m_entries_vec, and store more information into m_entries_hash.
 247         (completion_tracker::recompute_lcd_visitor): New function, most
 248         content taken from...
 249         (completion_tracker::recompute_lowest_common_denominator):
 250         ...here, this now just visits each item in the hash calling the
 251         above visitor.
 252         (completion_tracker::build_completion_result): Remove use of
 253         m_entries_vec, call recompute_lowest_common_denominator.
 254         * completer.h (completion_tracker::have_completions): Remove use
 255         of m_entries_vec.
 256         (completion_tracker::completion_hash_entry): Declare new class.
 257         (completion_tracker::recompute_lowest_common_denominator): Change
 258         function signature.
 259         (completion_tracker::recompute_lcd_visitor): Declare new function.
 260         (completion_tracker::m_entries_vec): Delete.
 261         (completion_tracker::m_entries_hash): Initialize to NULL.
 262         (completion_tracker::m_lowest_common_denominator_valid): New
 263         member variable.
 264         (completion_tracker::m_lowest_common_denominator_max_length): New
 265         member variable.
 266
 267 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 268
 269         * regformats/regdef.h: Put reg in gdb namespace.
 270
 271 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 272
 273         * i386-bsd-nat.c (gdb_ptrace): New.
 274         * (i386bsd_fetch_inferior_registers,
 275         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
 276         * (i386bsd_fetch_inferior_registers,
 277         i386bsd_store_inferior_registers) Use gdb_ptrace.
 278
 279 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 280
 281         * amd64-bsd-nat.c (gdb_ptrace): New.
 282         * (amd64bsd_fetch_inferior_registers,
 283         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
 284         * (amd64bsd_fetch_inferior_registers,
 285         amd64bsd_store_inferior_registers) Use gdb_ptrace.
 286
 287 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 288
 289         * user-regs.c (user_reg::read): Rename to...
 290         (user_reg::xread): ...this.
 291         * (append_user_reg): Rename argument `read' to `xread'.
 292         * (user_reg_add_builtin): Likewise.
 293         * (user_reg_add): Likewise.
 294         * (value_of_user_reg): Likewise.
 295
 296 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 297
 298         * sparc-nat.c (gdb_ptrace): New.
 299         * sparc-nat.c (sparc_fetch_inferior_registers)
 300         (sparc_store_inferior_registers) Remove obsolete comment.
 301         * sparc-nat.c (sparc_fetch_inferior_registers)
 302         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
 303         * sparc-nat.c (sparc_fetch_inferior_registers)
 304         (sparc_store_inferior_registers) Use gdb_ptrace.
 305
 306 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 307
 308         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
 309         it to the ptrace call.
 310         * sh-nbsd-nat.c (store_registers): Likewise.
 311
 312 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 313
 314         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
 315         nbsd_nat_target instead of inf_ptrace_target.
 316         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
 317         nbsd_nat_target.
 318
 319 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 320
 321         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
 322
 323 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 324
 325         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
 326         <sys/sysctl.h>.
 327         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
 328
 329 2020-03-17  Tom de Vries  <tdevries@suse.de>
 330
 331         PR gdb/23710
 332         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
 333         fields.
 334         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
 335         fields.
 336         (process_imported_unit_die): Skip import of c++ CUs.
 337
 338 2020-03-16  Tom Tromey  <tom@tromey.com>
 339
 340         * p-valprint.c (pascal_object_print_value): Initialize
 341         base_value.
 342
 343 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
 344             Shahab Vahedi  <shahab@synopsys.com>
 345
 346         * Makefile.in: Add arch/arc.o
 347         * configure.tgt: Likewise.
 348         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
 349         (_initialize_arc_tdep): Don't initialize old target descriptions.
 350         (arc_read_description): New function to cache target descriptions.
 351         * arc-tdep.h (arc_read_description): Add proto type.
 352         * arch/arc.c: New file.
 353         * arch/arc.h: Likewise.
 354         * features/Makefile: Replace old target descriptions with new.
 355         * features/arc-arcompact.c: Remove.
 356         * features/arc-arcompact.xml: Likewise.
 357         * features/arc-v2.c: Likewise
 358         * features/arc-v2.xml: Likewise
 359         * features/arc/aux-arcompact.xml: New file.
 360         * features/arc/aux-v2.xml: Likewise.
 361         * features/arc/core-arcompact.xml: Likewise.
 362         * features/arc/core-v2.xml: Likewise.
 363         * features/arc/aux-arcompact.c: Generate.
 364         * features/arc/aux-v2.c: Likewise.
 365         * features/arc/core-arcompact.c: Likewise.
 366         * features/arc/core-v2.c: Likewise.
 367         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
 368
 369 2020-03-16  Tom Tromey  <tromey@adacore.com>
 370
 371         PR gdb/25663:
 372         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
 373         putting value into bcache.
 374
 375 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
 376
 377         PR gdb/21500
 378         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
 379         to...
 380         (amd64_windows_init_abi_common): ... this.  Don't set size of
 381         long type.
 382         (amd64_windows_init_abi): New function.
 383         (amd64_cygwin_init_abi): New function.
 384         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
 385         the Cygwin OS ABI.
 386         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
 387         comment.
 388
 389 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
 390
 391         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
 392         * windows-tdep.c (CYGWIN_DLL_NAME): New.
 393         (pe_import_directory_entry): New struct type.
 394         (is_linked_with_cygwin_dll): New function.
 395         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
 396         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
 397         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
 398
 399 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
 400
 401         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
 402         i386_cygwin_core_osabi_sniffer.
 403
 404 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
 405
 406         * i386-cygwin-tdep.c: Rename to...
 407         * i386-windows-tdep.c: ... this.
 408         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
 409         i386-windows-tdep.c.
 410         * configure.tgt: Likewise.
 411
 412 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
 413
 414         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
 415         * osabi.c (gdb_osabi_names): Add "Windows".
 416         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
 417         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
 418         (i386_cygwin_core_osabi_sniffer): New function, extracted from
 419         i386_cygwin_osabi_sniffer.
 420         (_initialize_i386_cygwin_tdep): Register OS ABI
 421         GDB_OSABI_WINDOWS for i386.
 422         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
 423         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
 424         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
 425         for x86-64.
 426         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
 427         when the target matches '*-*-mingw*'.
 428
 429 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
 430
 431         * defs.h (enum gdb_osabi): Move to...
 432         * osabi.h (enum gdb_osabi): ... here.
 433         * gdbarch.sh: Include osabi.h in gdbarch.h.
 434         * gdbarch.h: Re-generate.
 435
 436 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
 437
 438         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
 439         function.
 440         (_initialize_amd64_windows_tdep): Register osabi sniffer.
 441
 442 2020-03-14  Tom Tromey  <tom@tromey.com>
 443
 444         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
 445         for C++.
 446         (c_type_print_modifier): Likewise.  Add "language" parameter.
 447         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
 448         (c_type_print_base_1): Update.
 449         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
 450         constants.
 451         * type-stack.c (type_stack::insert): Handle tp_atomic and
 452         tp_restrict.
 453         (type_stack::follow_type_instance_flags): Likewise.
 454         (type_stack::follow_types): Likewise.  Merge type-following code.
 455         * c-exp.y (RESTRICT, ATOMIC): New tokens.
 456         (space_identifier, cv_with_space_id)
 457         (const_or_volatile_or_space_identifier_noopt)
 458         (const_or_volatile_or_space_identifier): Remove.
 459         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
 460         rules.
 461         (ptr_operator, typebase): Update.
 462         (enum token_flag) <FLAG_C>: New constant.
 463         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
 464         "_Atomic".
 465         (lex_one_token): Handle FLAG_C.
 466
 467 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 468
 469         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
 470         it to the ptrace call.
 471         * m68k-bsd-nat.c (store_registers): Likewise.
 472
 473 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 474
 475         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
 476         gdb_byte *.
 477         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
 478         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
 479         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
 480
 481 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 482
 483         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
 484         nbsd_nat_target instead of inf_ptrace_target.
 485         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
 486         nbsd_nat_target.
 487
 488 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 489
 490         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
 491         register_t.
 492
 493 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 494
 495         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
 496         it to the ptrace call.
 497         * alpha-bsd-nat.c (store_registers): Likewise.
 498
 499 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 500
 501         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
 502         includes.
 503         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
 504         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
 505         fill_fpregset): Likewise.
 506
 507 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 508
 509         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
 510         nbsd_nat_target instead of inf_ptrace_target.
 511         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
 512         nbsd_nat_target.
 513
 514 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 515
 516         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
 517         register_t.
 518
 519 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 520
 521         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
 522         it to the ptrace call.
 523         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
 524         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
 525         * arm-nbsd-nat.c (store_register): Likewise.
 526         * arm-nbsd-nat.c (store_regs): Likewise.
 527         * arm-nbsd-nat.c (store_fp_register): Likewise.
 528         * arm-nbsd-nat.c (store_fp_regs): Likewise.
 529
 530 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 531
 532         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
 533         nbsd_nat_target instead of inf_ptrace_target.
 534         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
 535         nbsd_nat_target.
 536
 537 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 538
 539         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
 540         it to the ptrace call.
 541         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
 542
 543 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 544
 545         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
 546         it to the ptrace call.
 547         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
 548
 549 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 550
 551         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
 552         gdb_byte *.
 553         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
 554
 555 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 556
 557         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
 558         instead of inf_ptrace_target.
 559         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
 560         nbsd_nat_target.
 561
 562 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 563
 564         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
 565         register_t.
 566
 567 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 568
 569         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
 570         register_t.
 571
 572 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 573
 574         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
 575         register_t.
 576
 577 2020-03-13  Tom Tromey  <tom@tromey.com>
 578
 579         * value.h (val_print): Don't declare.
 580         * valprint.h (val_print_array_elements)
 581         (val_print_scalar_formatted, generic_val_print): Don't declare.
 582         * valprint.c (generic_val_print_array): Take a struct value.
 583         (generic_val_print_ptr, generic_val_print_memberptr)
 584         (generic_val_print_bool, generic_val_print_int)
 585         (generic_val_print_char, generic_val_print_complex)
 586         (generic_val_print): Remove.
 587         (generic_value_print): Update.
 588         (do_val_print): Remove unused parameters.  Don't call
 589         la_val_print.
 590         (val_print): Remove.
 591         (common_val_print): Update.  Don't call value_check_printable.
 592         (val_print_scalar_formatted, val_print_array_elements): Remove.
 593         * rust-lang.c (rust_val_print): Remove.
 594         (rust_language_defn): Update.
 595         * p-valprint.c (pascal_val_print): Remove.
 596         (pascal_value_print_inner): Update.
 597         (pascal_object_print_val_fields, pascal_object_print_val):
 598         Remove.
 599         (pascal_object_print_static_field): Update.
 600         * p-lang.h (pascal_val_print): Don't declare.
 601         * p-lang.c (pascal_language_defn): Update.
 602         * opencl-lang.c (opencl_language_defn): Update.
 603         * objc-lang.c (objc_language_defn): Update.
 604         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
 605         * m2-lang.h (m2_val_print): Don't declare.
 606         * m2-lang.c (m2_language_defn): Update.
 607         * language.h (struct language_defn) <la_val_print>: Remove.
 608         * language.c (unk_lang_value_print_inner): Rename.  Change
 609         argument types.
 610         (unknown_language_defn, auto_language_defn): Update.
 611         * go-valprint.c (go_val_print): Remove.
 612         * go-lang.h (go_val_print): Don't declare.
 613         * go-lang.c (go_language_defn): Update.
 614         * f-valprint.c (f_val_print): Remove.
 615         * f-lang.h (f_value_print): Don't declare.
 616         * f-lang.c (f_language_defn): Update.
 617         * d-valprint.c (d_val_print): Remove.
 618         * d-lang.h (d_value_print): Don't declare.
 619         * d-lang.c (d_language_defn): Update.
 620         * cp-valprint.c (cp_print_value_fields)
 621         (cp_print_value_fields_rtti, cp_print_value): Remove.
 622         (cp_print_static_field): Update.
 623         * c-valprint.c (c_val_print_array, c_val_print_ptr)
 624         (c_val_print_struct, c_val_print_union, c_val_print_int)
 625         (c_val_print_memberptr, c_val_print): Remove.
 626         * c-lang.h (c_val_print_array, cp_print_value_fields)
 627         (cp_print_value_fields_rtti): Don't declare.
 628         * c-lang.c (c_language_defn, cplus_language_defn)
 629         (asm_language_defn, minimal_language_defn): Update.
 630         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
 631         (ada_val_print_enum): Take a struct value.
 632         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
 633         (ada_val_print): Remove.
 634         (ada_value_print_1): Update.
 635         (printable_val_type): Remove.
 636         * ada-lang.h (ada_val_print): Don't declare.
 637         * ada-lang.c (ada_language_defn): Update.
 638
 639 2020-03-13  Tom Tromey  <tom@tromey.com>
 640
 641         * valprint.c (do_val_print): Update.
 642         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
 643         a struct value.
 644         (value_to_value_object_no_release): Declare.
 645         * python/py-value.c (value_to_value_object_no_release): New
 646         function.
 647         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
 648         struct value.
 649         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
 650         function.
 651         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
 652         a struct value.
 653         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
 654         Declare.
 655         (gdbscm_apply_val_pretty_printer): Take a struct value.
 656         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
 657         value.
 658         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
 659         value.
 660         * extension-priv.h (struct extension_language_ops)
 661         <apply_val_pretty_printer>: Take a struct value.
 662         * cp-valprint.c (cp_print_value): Create a struct value.
 663         (cp_print_value): Update.
 664
 665 2020-03-13  Tom Tromey  <tom@tromey.com>
 666
 667         * ada-valprint.c (print_field_values): Call common_val_print.
 668
 669 2020-03-13  Tom Tromey  <tom@tromey.com>
 670
 671         * ada-valprint.c (val_print_packed_array_elements): Remove
 672         bitoffset and val parameters.  Call common_val_print.
 673         (ada_val_print_string): Remove offset, address, and original_value
 674         parameters.
 675         (ada_val_print_array): Update.
 676         (ada_value_print_array): New function.
 677         (ada_value_print_1): Call it.
 678
 679 2020-03-13  Tom Tromey  <tom@tromey.com>
 680
 681         * ada-valprint.c (ada_value_print): Use common_val_print.
 682
 683 2020-03-13  Tom Tromey  <tom@tromey.com>
 684
 685         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
 686
 687 2020-03-13  Tom Tromey  <tom@tromey.com>
 688
 689         * ada-valprint.c (ada_value_print_num): New function.
 690         (ada_value_print_1): Use it.
 691
 692 2020-03-13  Tom Tromey  <tom@tromey.com>
 693
 694         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
 695
 696 2020-03-13  Tom Tromey  <tom@tromey.com>
 697
 698         * ada-valprint.c (ada_value_print_ptr): New function.
 699         (ada_value_print_1): Use it.
 700
 701 2020-03-13  Tom Tromey  <tom@tromey.com>
 702
 703         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
 704         call common_val_print.
 705         (ada_val_print_1): Update.
 706         (ada_value_print_1): New function.
 707         (ada_value_print_inner): Rewrite.
 708
 709 2020-03-13  Tom Tromey  <tom@tromey.com>
 710
 711         * cp-valprint.c (cp_print_value_fields): Update.
 712         (cp_print_value): New function.
 713
 714 2020-03-13  Tom Tromey  <tom@tromey.com>
 715
 716         * m2-valprint.c (m2_value_print_inner): Use
 717         cp_print_value_fields.
 718         * cp-valprint.c (cp_print_value_fields): New function.
 719         * c-valprint.c (c_value_print_struct): New function.
 720         (c_value_print_inner): Use c_value_print_struct.
 721         * c-lang.h (cp_print_value_fields): Declare.
 722
 723 2020-03-13  Tom Tromey  <tom@tromey.com>
 724
 725         * c-valprint.c (c_value_print_array): New function.
 726         (c_value_print_inner): Use it.
 727
 728 2020-03-13  Tom Tromey  <tom@tromey.com>
 729
 730         * c-valprint.c (c_value_print_memberptr): New function.
 731         (c_value_print_inner): Use it.
 732
 733 2020-03-13  Tom Tromey  <tom@tromey.com>
 734
 735         * c-valprint.c (c_value_print_int): New function.
 736         (c_value_print_inner): Use it.
 737
 738 2020-03-13  Tom Tromey  <tom@tromey.com>
 739
 740         * c-valprint.c (c_value_print_ptr): New function.
 741         (c_value_print_inner): Use it.
 742
 743 2020-03-13  Tom Tromey  <tom@tromey.com>
 744
 745         * c-valprint.c (c_value_print_inner): Rewrite.
 746
 747 2020-03-13  Tom Tromey  <tom@tromey.com>
 748
 749         * valprint.c (generic_value_print_complex): New function.
 750         (generic_value_print): Use it.
 751
 752 2020-03-13  Tom Tromey  <tom@tromey.com>
 753
 754         * valprint.c (generic_val_print_float): Don't call
 755         val_print_scalar_formatted.
 756         (generic_val_print, generic_value_print): Update.
 757
 758 2020-03-13  Tom Tromey  <tom@tromey.com>
 759
 760         * valprint.c (generic_value_print_char): New function
 761         (generic_value_print): Use it.
 762
 763 2020-03-13  Tom Tromey  <tom@tromey.com>
 764
 765         * valprint.c (generic_value_print_int): New function.
 766         (generic_value_print): Use it.
 767
 768 2020-03-13  Tom Tromey  <tom@tromey.com>
 769
 770         * valprint.c (generic_value_print_bool): New function.
 771         (generic_value_print): Use it.
 772
 773 2020-03-13  Tom Tromey  <tom@tromey.com>
 774
 775         * valprint.c (generic_val_print_func): Simplify.
 776         (generic_val_print, generic_value_print): Update.
 777
 778 2020-03-13  Tom Tromey  <tom@tromey.com>
 779
 780         * valprint.c (generic_val_print_flags): Remove.
 781         (generic_val_print, generic_value_print): Update.
 782         (val_print_type_code_flags): Add original_value parameter.
 783
 784 2020-03-13  Tom Tromey  <tom@tromey.com>
 785
 786         * valprint.c (generic_val_print): Update.
 787         (generic_value_print): Update.
 788         * valprint.c (generic_val_print_enum): Don't call
 789         val_print_scalar_formatted.
 790
 791 2020-03-13  Tom Tromey  <tom@tromey.com>
 792
 793         * valprint.c (generic_value_print): Call generic_value_print_ptr.
 794         * valprint.c (generic_value_print_ptr): New function.
 795
 796 2020-03-13  Tom Tromey  <tom@tromey.com>
 797
 798         * valprint.c (generic_value_print): Rewrite.
 799
 800 2020-03-13  Tom Tromey  <tom@tromey.com>
 801
 802         * p-valprint.c (pascal_object_print_value_fields)
 803         (pascal_object_print_value): New functions.
 804
 805 2020-03-13  Tom Tromey  <tom@tromey.com>
 806
 807         * p-valprint.c (pascal_value_print_inner): Rewrite.
 808
 809 2020-03-13  Tom Tromey  <tom@tromey.com>
 810
 811         * f-valprint.c (f_value_print_innner): Rewrite.
 812
 813 2020-03-13  Tom Tromey  <tom@tromey.com>
 814
 815         * m2-valprint.c (m2_print_unbounded_array): New overload.
 816         (m2_print_unbounded_array): Update.
 817         (m2_print_array_contents): Take a struct value.
 818         (m2_value_print_inner): Rewrite.
 819
 820 2020-03-13  Tom Tromey  <tom@tromey.com>
 821
 822         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
 823         (d_value_print_inner): New function.
 824         * d-lang.h (d_value_print_inner): Declare.
 825         * d-lang.c (d_language_defn): Use d_value_print_inner.
 826
 827 2020-03-13  Tom Tromey  <tom@tromey.com>
 828
 829         * go-valprint.c (go_value_print_inner): New function.
 830         * go-lang.h (go_value_print_inner): Declare.
 831         * go-lang.c (go_language_defn): Use go_value_print_inner.
 832
 833 2020-03-13  Tom Tromey  <tom@tromey.com>
 834
 835         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
 836         API.
 837         (rust_val_print): Rewrite.
 838         (rust_value_print_inner): New function, from rust_val_print.
 839         (rust_language_defn): Use rust_value_print_inner.
 840
 841 2020-03-13  Tom Tromey  <tom@tromey.com>
 842
 843         * ada-valprint.c (ada_value_print_inner): New function.
 844         * ada-lang.h (ada_value_print_inner): Declare.
 845         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
 846
 847 2020-03-13  Tom Tromey  <tom@tromey.com>
 848
 849         * f-valprint.c (f_value_print_innner): New function.
 850         * f-lang.h (f_value_print_innner): Declare.
 851         * f-lang.c (f_language_defn): Use f_value_print_innner.
 852
 853 2020-03-13  Tom Tromey  <tom@tromey.com>
 854
 855         * p-valprint.c (pascal_value_print_inner): New function.
 856         * p-lang.h (pascal_value_print_inner): Declare.
 857         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
 858
 859 2020-03-13  Tom Tromey  <tom@tromey.com>
 860
 861         * m2-valprint.c (m2_value_print_inner): New function.
 862         * m2-lang.h (m2_value_print_inner): Declare.
 863         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
 864
 865 2020-03-13  Tom Tromey  <tom@tromey.com>
 866
 867         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
 868         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
 869         * c-valprint.c (c_value_print_inner): New function.
 870         * c-lang.h (c_value_print_inner): Declare.
 871         * c-lang.c (c_language_defn, cplus_language_defn)
 872         (asm_language_defn, minimal_language_defn): Use
 873         c_value_print_inner.
 874
 875 2020-03-13  Tom Tromey  <tom@tromey.com>
 876
 877         * p-valprint.c (pascal_object_print_value_fields): Now static.
 878         * p-lang.h (pascal_object_print_value_fields): Don't declare.
 879
 880 2020-03-13  Tom Tromey  <tom@tromey.com>
 881
 882         * c-valprint.c (c_val_print_array): Simplify.
 883
 884 2020-03-13  Tom Tromey  <tom@tromey.com>
 885
 886         * valprint.c (value_print_array_elements): New function.
 887         * valprint.h (value_print_array_elements): Declare.
 888
 889 2020-03-13  Tom Tromey  <tom@tromey.com>
 890
 891         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
 892         * mips-tdep.c (mips_print_register): Use
 893         value_print_scalar_formatted.
 894
 895 2020-03-13  Tom Tromey  <tom@tromey.com>
 896
 897         * valprint.h (value_print_scalar_formatted): Declare.
 898         * valprint.c (value_print_scalar_formatted): New function.
 899
 900 2020-03-13  Tom Tromey  <tom@tromey.com>
 901
 902         * valprint.h (generic_value_print): Declare.
 903         * valprint.c (generic_value_print): New function.
 904
 905 2020-03-13  Tom Tromey  <tom@tromey.com>
 906
 907         * valprint.c (do_val_print): Call la_value_print_inner, if
 908         available.
 909         * rust-lang.c (rust_language_defn): Update.
 910         * p-lang.c (pascal_language_defn): Update.
 911         * opencl-lang.c (opencl_language_defn): Update.
 912         * objc-lang.c (objc_language_defn): Update.
 913         * m2-lang.c (m2_language_defn): Update.
 914         * language.h (struct language_defn) <la_value_print_inner>: New
 915         member.
 916         * language.c (unknown_language_defn, auto_language_defn): Update.
 917         * go-lang.c (go_language_defn): Update.
 918         * f-lang.c (f_language_defn): Update.
 919         * d-lang.c (d_language_defn): Update.
 920         * c-lang.c (c_language_defn, cplus_language_defn)
 921         (asm_language_defn, minimal_language_defn): Update.
 922         * ada-lang.c (ada_language_defn): Update.
 923
 924 2020-03-13  Tom Tromey  <tom@tromey.com>
 925
 926         * c-valprint.c (c_value_print): Use common_val_print.
 927
 928 2020-03-13  Tom Tromey  <tom@tromey.com>
 929
 930         * cp-valprint.c (cp_print_static_field): Use common_val_print.
 931
 932 2020-03-13  Tom Tromey  <tom@tromey.com>
 933
 934         * f-valprint.c (f77_print_array_1, f_val_print): Use
 935         common_val_print.
 936
 937 2020-03-13  Tom Tromey  <tom@tromey.com>
 938
 939         * riscv-tdep.c (riscv_print_one_register_info): Use
 940         common_val_print.
 941
 942 2020-03-13  Tom Tromey  <tom@tromey.com>
 943
 944         * mi/mi-main.c (output_register): Use common_val_print.
 945
 946 2020-03-13  Tom Tromey  <tom@tromey.com>
 947
 948         * infcmd.c (default_print_one_register_info): Use
 949         common_val_print.
 950
 951 2020-03-13  Tom Tromey  <tom@tromey.com>
 952
 953         * valprint.h (common_val_print_checked): Declare.
 954         * valprint.c (common_val_print_checked): New function.
 955         * stack.c (print_frame_arg): Use common_val_print_checked.
 956
 957 2020-03-13  Tom Tromey  <tom@tromey.com>
 958
 959         * valprint.c (do_val_print): New function, from val_print.
 960         (val_print): Use do_val_print.
 961         (common_val_print): Use do_val_print.
 962
 963 2020-03-13  Tom Tromey  <tom@tromey.com>
 964
 965         * valprint.c (value_print): Use scoped_value_mark.
 966
 967 2020-03-13  Tom de Vries  <tdevries@suse.de>
 968
 969         PR symtab/25646
 970         * psymtab.c (partial_symtab::partial_symtab): Don't set
 971         globals_offset and statics_offset.  Push element onto
 972         current_global_psymbols and current_static_psymbols stacks.
 973         (concat): New function.
 974         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
 975         element from current_global_psymbols and current_static_psymbols
 976         stacks.  Concat popped elements to global_psymbols and
 977         static_symbols.
 978         (add_psymbol_to_list): Use current_global_psymbols and
 979         current_static_psymbols stacks.
 980         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
 981         current_static_psymbols fields.
 982
 983 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
 984
 985         * corelow.c (sniff_core_bfd): Remove.
 986         (class core_target) <m_core_vec>: Remove.
 987         (core_target::core_target): Update.
 988         (core_file_fns): Remove.
 989         (deprecated_add_core_fns): Remove.
 990         (default_core_sniffer): Remove.
 991         (sniff_core_bfd): Remove.
 992         (default_check_format): Remove.
 993         (gdb_check_format): Remove.
 994         (core_target_open): Update.
 995         (core_target::get_core_register_section): Update.
 996         (get_core_registers_cb): Update.
 997         (core_target::fetch_registers): Update.
 998         * gdbcore.h (struct core_fns): Remove.
 999         (deprecated_add_core_fns): Remove.
1000         (default_core_sniffer): Remove.
1001         (default_check_format): Remove.
1002
1003 2020-03-12  Tom Tromey  <tom@tromey.com>
1004
1005         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
1006         CORE_ADDR.
1007         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
1008
1009 2020-03-12  Tom Tromey  <tom@tromey.com>
1010
1011         * remote.c (remote_target::download_tracepoint)
1012         (remote_target::enable_tracepoint)
1013         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
1014         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
1015         sprintf_vma.
1016
1017 2020-03-12  Tom Tromey  <tom@tromey.com>
1018
1019         * symfile-mem.c: Update CORE_ADDR size assert.
1020
1021 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
1022
1023         * selftest.m4: Move to gdbsupport/.
1024         * acinclude.m4: Update path to selftest.m4.
1025
1026 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
1027
1028         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
1029         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
1030         gdbarch-selfselftests.c and selftest-arch.c.
1031         (SUBDIR_UNITTESTS_OBS): Rename to...
1032         (SELFTESTS_OBS): ... this.
1033         (COMMON_SFILES): Remove disasm-selftests.c and
1034         gdbarch-selftests.c.
1035         * configure.ac: Don't add selftest-arch.{c,o} to
1036         CONFIG_{SRCS,OBS}.
1037         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
1038         preprocessor conditions.
1039
1040 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
1041
1042         * configure.ac: Don't source bfd/development.sh.
1043         * selftest.m4: Modify comment.
1044         * configure: Re-generate.
1045
1046 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
1047
1048         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
1049         not "true" or "false".
1050         * configure: Re-generate.
1051
1052 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
1053
1054         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
1055         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
1056         renamed to arm_nbsd_supply_gregset.
1057         (fetch_register): Update to call arm_nbsd_supply_gregset.
1058         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
1059         (arm_netbsd_nat_target::fetch_registers): Update.
1060         (fetch_elfcore_registers): Removed.
1061         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
1062         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
1063         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
1064         not require NetBSD system headers.
1065         (arm_nbsd_regset): New struct.
1066         (arm_nbsd_iterate_over_regset_sections): New function.
1067         (arm_netbsd_init_abi_common): Updated to call
1068         set_gdbarch_iterate_over_regset_sections.
1069         * arm-nbsd-tdep.h: New file.
1070
1071 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
1072
1073         * symtab.c (find_pc_sect_line): Add check which prevents infinite
1074         recursion.
1075
1076 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
1077
1078         * configure: Re-generate.
1079
1080 2020-03-11  Tom Tromey  <tromey@adacore.com>
1081
1082         * ada-typeprint.c (print_choices): Fix comment.
1083
1084 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1085
1086         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
1087         previous item in the list, when the list has no items.
1088
1089 2020-03-11  Tom de Vries  <tdevries@suse.de>
1090
1091         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
1092         PROP_LOCLIST handling code.
1093
1094 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1095
1096         * buildsym-legacy.c (record_line): Pass extra parameter to
1097         record_line.
1098         * buildsym.c (buildsym_compunit::record_line): Take an extra
1099         parameter, reduce duplication in the line table, and record the
1100         is_stmt flag in the line table.
1101         * buildsym.h (buildsym_compunit::record_line): Add extra
1102         parameter.
1103         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
1104         non-statement lines.
1105         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
1106         this to the symtab builder.
1107         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
1108         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
1109         through to dwarf_record_line_1.
1110         * infrun.c (process_event_stop_test): When stepping, don't stop at
1111         a non-statement instruction, and only refresh the step info when
1112         we land in the middle of a line's range.  Also add an extra
1113         comment.
1114         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
1115         field.
1116         * record-btrace.c (btrace_find_line_range): Only record lines
1117         marked as is-statement.
1118         * stack.c (frame_show_address): Show the frame address if we are
1119         in a non-statement sal.
1120         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
1121         (maintenance_print_one_line_table): Print a header for the is_stmt
1122         column, and include is_stmt information in the output.
1123         * symtab.c (find_pc_sect_line): Find lines marked as statements in
1124         preference to non-statements.
1125         (find_pcs_for_symtab_line): Prefer is-statement entries.
1126         (find_line_common): Likewise.
1127         * symtab.h (struct linetable_entry): Add is_stmt field.
1128         (struct symtab_and_line): Likewise.
1129         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
1130         arranging the line table.
1131
1132 2020-03-07  Tom de Vries  <tdevries@suse.de>
1133
1134         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
1135         DIE.
1136
1137 2020-03-07  Tom Tromey  <tom@tromey.com>
1138
1139         * valops.c (value_literal_complex): Remove obsolete comment.
1140         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
1141         comment.
1142
1143 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
1144
1145         * infrun.h: Forward-declare thread_info.
1146         (set_step_info): Add thread_info parameter, add doc.
1147         * infrun.c (set_step_info): Add thread_info parameter, move doc
1148         to header.
1149         * infrun.c (process_event_stop_test): Pass thread to
1150         set_step_info call.
1151         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
1152         set_step_info.
1153         (prepare_one_step): Add thread_info parameter, pass it to
1154         set_step_frame and prepare_one_step (recursive) call.
1155         (step_1): Pass thread to prepare_one_step call.
1156         (step_command_fsm::should_stop): Pass thread to
1157         prepare_one_step.
1158         (until_next_fsm): Pass thread to set_step_frame call.
1159         (finish_command): Pass thread to set_step_info call.
1160
1161 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
1162
1163         * windows-tdep.c (windows_solib_create_inferior_hook):
1164         Check if inferior is running.
1165
1166 2020-03-06  Tom de Vries  <tdevries@suse.de>
1167
1168         * NEWS: Fix "the the".
1169         * ctfread.c: Same.
1170
1171 2020-03-06  Tom de Vries  <tdevries@suse.de>
1172
1173         * psymtab.c (psymtab_to_symtab): Don't print "done.".
1174
1175 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1176
1177         * .dir-locals.el: Add a comment referencing the other copies of
1178         this file.
1179
1180 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
1181
1182         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
1183         psargs.
1184
1185 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1186
1187         * .gitattributes: New file.
1188
1189 2020-03-04  Tom Tromey  <tom@tromey.com>
1190
1191         * symmisc.c (print_symbol_bcache_statistics)
1192         (print_objfile_statistics): Update.
1193         * symfile.c (allocate_symtab): Use intern.
1194         * psymtab.c (partial_symtab::partial_symtab): Use intern.
1195         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1196         macro_cache>: Remove.
1197         <string_cache>: New member.
1198         (struct objfile) <intern>: New methods.
1199         * elfread.c (elf_symtab_read): Use intern.
1200         * dwarf2/read.c (fixup_go_packaging): Intern package name.
1201         (dwarf2_compute_name, dwarf2_physname)
1202         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
1203         names.
1204         (guess_partial_die_structure_name): Update.
1205         (partial_die_info::fixup): Intern name.
1206         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
1207         name.
1208         (dwarf2_name): Intern name.  Update.
1209         * buildsym.c (buildsym_compunit::get_macro_table): Use
1210         string_cache.
1211
1212 2020-03-04  Tom Tromey  <tom@tromey.com>
1213
1214         * jit.c (bfd_open_from_target_memory): Make "target" const.
1215         * corefile.c (gnutarget): Now const.
1216         * gdbcore.h (gnutarget): Now const.
1217
1218 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
1219
1220         * NEWS: Mention support for WOW64 processes.
1221         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
1222         (amd64_windows_segment_register_p): Remove static.
1223         (_initialize_amd64_windows_nat): Update.
1224         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
1225         * i386-windows-nat.c (context_offset): Update.
1226         (i386_mappings): Rename and remove static.
1227         (i386_windows_segment_register_p): Remove static.
1228         (_initialize_i386_windows_nat): Update.
1229         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
1230         (STATUS_WX86_SINGLE_STEP): New macro.
1231         (EnumProcessModulesEx): New macro.
1232         (Wow64SuspendThread): New macro.
1233         (Wow64GetThreadContext): New macro.
1234         (Wow64SetThreadContext): New macro.
1235         (Wow64GetThreadSelectorEntry): New macro.
1236         (windows_set_context_register_offsets): Add static.
1237         (windows_set_segment_register_p): Likewise.
1238         (windows_add_thread): Adapt for WOW64 processes.
1239         (windows_fetch_one_register): Likewise.
1240         (windows_nat_target::fetch_registers): Likewise.
1241         (windows_store_one_register): Likewise.
1242         (display_selector): Likewise.
1243         (display_selectors): Likewise.
1244         (handle_exception): Likewise.
1245         (windows_continue): Likewise.
1246         (windows_nat_target::resume): Likewise.
1247         (windows_add_all_dlls): Likewise.
1248         (do_initial_windows_stuff): Likewise.
1249         (windows_nat_target::attach): Likewise.
1250         (windows_get_exec_module_filename): Likewise.
1251         (windows_nat_target::create_inferior): Likewise.
1252         (windows_xfer_siginfo): Likewise.
1253         (_initialize_loadable): Initialize Wow64SuspendThread,
1254         Wow64GetThreadContext, Wow64SetThreadContext,
1255         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
1256         * windows-nat.h (windows_set_context_register_offsets):
1257         Remove declaration.
1258         (windows_set_segment_register_p): Likewise.
1259         (i386_windows_segment_register_p): Add declaration.
1260         (amd64_windows_segment_register_p): Likewise.
1261
1262 2020-03-04  Luis Machado  <luis.machado@linaro.org>
1263
1264         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
1265         in "info registers" for AArch64/ARM.
1266
1267         The change caused "info registers" to not print GPR's.
1268
1269         gdb/ChangeLog:
1270
1271         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
1272
1273         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
1274         when reg->group is empty and reggroup is not.
1275
1276 2020-03-03  Tom Tromey  <tromey@adacore.com>
1277
1278         * dwarf2/frame.c (struct dwarf2_frame_cache)
1279         <checked_tailcall_bottom, entry_cfa_sp_offset,
1280         entry_cfa_sp_offset_p>: Remove members.
1281         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
1282         (dwarf2_frame_prev_register): Don't call
1283         dwarf2_tailcall_sniffer_first.
1284         (dwarf2_append_unwinders): Don't append tailcall unwinder.
1285         * frame-unwind.c (add_unwinder): New fuction.
1286         (frame_unwind_init): Use it.  Add tailcall unwinder.
1287
1288 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1289             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
1290
1291         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
1292         value should be printed as true.
1293
1294 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
1295
1296         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
1297         (windows_init_abi): Set and use windows_so_ops.
1298
1299 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
1300
1301         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
1302         when verifying if dealing with a convenience variable.
1303
1304 2020-03-03  Luis Machado  <luis.machado@linaro.org>
1305
1306         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
1307
1308 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
1309
1310         * infrun.c (gdbarch_supports_displaced_stepping): New.
1311         (use_displaced_stepping): Break up conditions in smaller pieces.
1312         Use gdbarch_supports_displaced_stepping.
1313         (displaced_step_prepare_throw): Use
1314         gdbarch_supports_displaced_stepping.
1315
1316 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1317
1318         * NEWS: Mention new behaviour of the history filename.
1319         * top.c (write_history_p): Add comment.
1320         (show_write_history_p): Add header comment, give a different
1321         message when history writing is on, but the history filename is
1322         empty.
1323         (history_filename): Add comment.
1324         (history_filename_empty): New function.
1325         (show_history_filename): Add header comment, give a different
1326         message when the filename is empty.
1327         (init_history): Compare history_filename against nullptr, and only
1328         read history if the filename is not empty.
1329         (set_history_filename): Add header comment, and only make
1330         non-empty filenames absolute.
1331         (init_main): Make the filename argument to 'set history filename'
1332         optional.
1333
1334 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
1335
1336         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
1337         (arm_supply_vfpregset): ...this, and update to use VFP registers.
1338         (fetch_fp_register): Update.
1339         (fetch_fp_regs): Update.
1340         (store_fp_register): Update.
1341         (store_fp_regs): Update.
1342         (arm_netbsd_nat_target::read_description): New function.
1343         (fetch_elfcore_registers): Update.
1344
1345 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1346
1347         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
1348         general_thread if the stop reply is missing a thread-id.
1349         (remote_target::process_stop_reply): Use the first non-exited
1350         thread if the target didn't pass a thread-id.
1351         * infrun.c (do_target_wait): Move call to
1352         switch_to_inferior_no_thread to ....
1353         (do_target_wait_1): ... here.
1354
1355 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
1356
1357         * debuginfod-support.c: Include defs.h first.
1358
1359 2020-02-28  Tom de Vries  <tdevries@suse.de>
1360
1361         * symfile.c (set_initial_language): Use default language for lookup.
1362
1363 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
1364
1365         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
1366         reader variable, pass `this` to read_cutu_die_from_dwo.
1367
1368 2020-02-27  Aaron Merey  <amerey@redhat.com>
1369
1370         * source.c (open_source_file): Check for nullptr when computing
1371         srcpath.
1372
1373 2020-02-27  Tom Tromey  <tromey@adacore.com>
1374
1375         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
1376         member.
1377         (dwarf2_add_field): Don't update nfields.
1378         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
1379
1380 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1381
1382         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
1383         abs.
1384
1385 2020-02-26  Tom Tromey  <tom@tromey.com>
1386
1387         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
1388         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
1389         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
1390         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
1391         per_cu_data.
1392
1393 2020-02-26  Tom Tromey  <tom@tromey.com>
1394
1395         * dwarf2/index-write.c (psym_index_map): Change type.
1396         (add_address_entry_worker, write_one_signatured_type)
1397         (recursively_count_psymbols, recursively_write_psymbols)
1398         (class debug_names, psyms_seen_size, write_gdbindex)
1399         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
1400
1401 2020-02-26  Aaron Merey  <amerey@redhat.com>
1402
1403         * Makefile.in: Handle optional debuginfod support.
1404         * NEWS: Update.
1405         * README: Add --with-debuginfod summary.
1406         * config.in: Regenerate.
1407         * configure: Regenerate.
1408         * configure.ac: Handle optional debuginfod support.
1409         * debuginfod-support.c: debuginfod helper functions.
1410         * debuginfod-support.h: Ditto.
1411         * doc/gdb.texinfo: Add --with-debuginfod to configure options
1412         summary.
1413         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
1414         when a dwz file cannot be found.
1415         * elfread.c (elf_symfile_read): Query debuginfod servers when a
1416         debuginfo file cannot be found.
1417         * source.c (open_source_file): Query debuginfod servers when a
1418         source file cannot be found.
1419         * top.c (print_gdb_configuration): Include
1420         --{with,without}-debuginfod in the output.
1421
1422 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
1423
1424         * thread.c (thr_try_catch_cmd): Print thread name.
1425
1426 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
1427
1428         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
1429         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
1430         dwarf2_fetch_die_type_sect_off): Move to...
1431         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
1432         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
1433         dwarf2_fetch_die_type_sect_off): ... here.
1434         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
1435         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
1436         dwarf2_fetch_die_type_sect_off): Move doc to header file.
1437
1438 2020-02-26  Tom de Vries  <tdevries@suse.de>
1439
1440         PR gdb/25603
1441         * symfile.c (set_initial_language): Exit-early if
1442         language_mode == language_mode_manual.
1443
1444 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
1445
1446         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
1447         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
1448         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
1449
1450 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1451
1452         * gdbtypes.c (create_array_type_with_stride): Handle negative
1453         array strides.
1454         * valarith.c (value_subscripted_rvalue): Likewise.
1455
1456 2020-02-25  Luis Machado  <luis.machado@linaro.org>
1457
1458         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
1459
1460 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
1461
1462         * loc.h (dwarf2_get_die_type): Move to...
1463         * read.h (dwarf2_get_die_type): ... here.
1464         * read.c (dwarf2_get_die_type): Move doc to header.
1465
1466 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
1467
1468         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
1469         'gnulib/Makefile.in' to the list.
1470
1471 2020-02-24  Tom Tromey  <tom@tromey.com>
1472
1473         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
1474         Remove.
1475         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
1476         XOBNEWVEC.
1477
1478 2020-02-24  Tom Tromey  <tom@tromey.com>
1479
1480         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
1481         New method.
1482         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
1483         (dw2_do_instantiate_symtab, dw2_get_file_names)
1484         (build_type_psymtab_dependencies, load_full_type_unit): Update.
1485
1486 2020-02-24  Tom Tromey  <tom@tromey.com>
1487
1488         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
1489         make_scoped_restore.
1490         (dwarf2_psymtab::read_symtab): Don't clear
1491         reading_partial_symbols.
1492
1493 2020-02-24  Tom de Vries  <tdevries@suse.de>
1494
1495         PR gdb/25592
1496         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
1497
1498 2020-02-24  Tom de Vries  <tdevries@suse.de>
1499
1500         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
1501         commands layout next/prev/regs.
1502
1503 2020-02-22  Tom Tromey  <tom@tromey.com>
1504
1505         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
1506         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
1507
1508 2020-02-22  Tom Tromey  <tom@tromey.com>
1509
1510         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
1511
1512 2020-02-22  Tom Tromey  <tom@tromey.com>
1513
1514         * tui/tui-win.c (_initialize_tui_win): Add usage text.
1515         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
1516         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
1517         * tui/tui.c (_initialize_tui): Add usage text.
1518
1519 2020-02-22  Tom Tromey  <tom@tromey.com>
1520
1521         * tui/tui-win.c (tui_set_focus_command)
1522         (tui_set_win_height_command): Use error_no_arg.
1523         (_initialize_tui_win): Update help text.
1524         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
1525
1526 2020-02-22  Tom Tromey  <tom@tromey.com>
1527
1528         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
1529         * tui/tui-disasm.h (struct tui_disasm_window)
1530         <display_start_addr>: Declare.
1531         * tui/tui-source.h (struct tui_source_window)
1532         <display_start_addr>: Declare.
1533         * tui/tui-winsource.h (struct tui_source_window_base)
1534         <show_source_line, display_start_addr>: New methods.
1535         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
1536         Rename and move to protected section.
1537         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
1538         (tui_source_window_base::do_erase_source_content): Update.
1539         (tui_source_window_base::show_source_line): Now a method.
1540         (tui_source_window_base::show_source_content)
1541         (tui_source_window_base::tui_source_window_base)
1542         (tui_source_window_base::rerender)
1543         (tui_source_window_base::refill)
1544         (tui_source_window_base::do_scroll_horizontal)
1545         (tui_source_window_base::set_is_exec_point_at)
1546         (tui_source_window_base::update_breakpoint_info)
1547         (tui_source_window_base::update_exec_info): Update.
1548         * tui/tui-source.c (tui_source_window::set_contents)
1549         (tui_source_window::showing_source_p)
1550         (tui_source_window::do_scroll_vertical)
1551         (tui_source_window::location_matches_p)
1552         (tui_source_window::line_is_displayed): Update.
1553         (tui_source_window::display_start_addr): New method.
1554         * tui/tui-disasm.c (tui_disasm_window::set_contents)
1555         (tui_disasm_window::do_scroll_vertical)
1556         (tui_disasm_window::location_matches_p): Update.
1557         (tui_disasm_window::display_start_addr): New method.
1558
1559 2020-02-22  Tom Tromey  <tom@tromey.com>
1560
1561         * NEWS: Add entry for gdb.register_window_type.
1562         * tui/tui-layout.h (window_factory): New typedef.
1563         (tui_register_window): Declare.
1564         * tui/tui-layout.c (saved_tui_windows): New global.
1565         (tui_apply_current_layout): Use it.
1566         (tui_register_window): New function.
1567         * python/python.c (do_start_initialization): Call
1568         gdbpy_initialize_tui.
1569         (python_GdbMethods): Add "register_window_type" function.
1570         * python/python-internal.h (gdbpy_register_tui_window)
1571         (gdbpy_initialize_tui): Declare.
1572         * python/py-tui.c: New file.
1573         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
1574
1575 2020-02-22  Tom Tromey  <tom@tromey.com>
1576
1577         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
1578
1579 2020-02-22  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
1582         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
1583         * tui/tui-data.c (tui_set_win_with_focus): Remove.
1584         (tui_set_win_focus_to): Move from tui-win.c.
1585
1586 2020-02-22  Tom Tromey  <tom@tromey.com>
1587
1588         * tui/tui-layout.c (make_standard_window, get_locator_window): New
1589         functions.
1590         (known_window_types): New global.
1591         (tui_get_window_by_name): Reimplement.
1592         (initialize_known_windows): New function.
1593         (validate_window_name): Rewrite.
1594         (_initialize_tui_layout): Call initialize_known_windows.
1595
1596 2020-02-22  Tom Tromey  <tom@tromey.com>
1597
1598         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
1599         Remove constants.
1600         * tui/tui-winsource.h (struct tui_source_window_base)
1601         <tui_source_window_base>: Remove parameter.
1602         * tui/tui-winsource.c
1603         (tui_source_window_base::tui_source_window_base): Remove
1604         parameter.
1605         (tui_source_window_base::refill): Update.
1606         * tui/tui-stack.h (struct tui_locator_window)
1607         <tui_locator_window>: Update.
1608         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
1609         Default the constructor.
1610         * tui/tui-regs.h (struct tui_data_item_window)
1611         <tui_data_item_window>: Default the constructor.
1612         (struct tui_data_window) <tui_data_window>: Likewise.
1613         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
1614         Default the constructor.
1615         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
1616         Default the constructor.
1617         <type>: Remove.
1618         (struct tui_win_info) <tui_win_info>: Default the constructor.
1619         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
1620         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1621         Default the constructor.
1622
1623 2020-02-22  Tom Tromey  <tom@tromey.com>
1624
1625         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
1626         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
1627         * tui/tui-win.c (tui_resize_all): Don't call
1628         tui_delete_invisible_windows.
1629         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
1630         done.
1631         (tui_set_layout): Update.
1632         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
1633         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
1634         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
1635
1636 2020-02-22  Tom Tromey  <tom@tromey.com>
1637
1638         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
1639         correctly.
1640
1641 2020-02-22  Tom Tromey  <tom@tromey.com>
1642
1643         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
1644
1645 2020-02-22  Tom Tromey  <tom@tromey.com>
1646
1647         * tui/tui-winsource.h (struct tui_source_window_iterator)
1648         <inner_iterator>: New etytypedef.
1649         <tui_source_window_iterator>: Take "end" parameter.
1650         <tui_source_window_iterator>: Take iterator.
1651         <operator*, advance>: Update.
1652         <m_iter>: Change type.
1653         <m_end>: New field.
1654         (struct tui_source_windows) <begin, end>: Update.
1655         * tui/tui-layout.c (tui_windows): New global.
1656         (tui_apply_current_layout): Clear tui_windows.
1657         (tui_layout_window::apply): Update tui_windows.
1658         * tui/tui-data.h (tui_windows): Declare.
1659         (all_tui_windows): Now inline function.
1660         (class tui_window_iterator, struct all_tui_windows): Remove.
1661
1662 2020-02-22  Tom Tromey  <tom@tromey.com>
1663
1664         PR tui/17850:
1665         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
1666         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
1667         "height" argument.
1668         (class tui_layout_window) <get_sizes>: Likewise.
1669         (class tui_layout_split) <tui_layout_split>: Add "vertical"
1670         argument.
1671         <get_sizes>: Add "height" argument.
1672         <m_vertical>: New field.
1673         * tui/tui-layout.c (tui_layout_split::clone): Update.
1674         (tui_layout_split::get_sizes): Add "height" argument.
1675         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
1676         (tui_new_layout_command): Parse "-horizontal".
1677         (_initialize_tui_layout): Update help string.
1678         (tui_layout_split::specification): Add "-horizontal" when needed.
1679         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
1680         argument.
1681         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
1682         New methods.
1683
1684 2020-02-22  Tom Tromey  <tom@tromey.com>
1685
1686         * tui/tui-layout.h (enum tui_adjust_result): New.
1687         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
1688         (class tui_layout_window) <adjust_size>: Return
1689         tui_adjust_result.  Rewrite.
1690         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
1691         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
1692
1693 2020-02-22  Tom Tromey  <tom@tromey.com>
1694
1695         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
1696         parameter and return types.
1697         (class tui_layout_base) <specification>: Add "depth".
1698         (class tui_layout_window) <specification>: Add "depth".
1699         (class tui_layout_split) <specification>: Add "depth".
1700         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
1701         and return types.
1702         (tui_new_layout_command): Parse sub-layouts.
1703         (_initialize_tui_layout): Update help string.
1704         (tui_layout_window::specification): Add "depth".
1705         (add_layout_command): Update.
1706
1707 2020-02-22  Tom Tromey  <tom@tromey.com>
1708
1709         * NEWS: Add "tui new-layout" item.
1710         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
1711         Add new-layout command to help text.
1712         (validate_window_name): New function.
1713         (tui_new_layout_command): New function.
1714         (_initialize_tui_layout): Register "new-layout".
1715         (tui_layout_window::specification): New method.
1716         (tui_layout_window::specification): New method.
1717         * tui/tui-layout.h (class tui_layout_base) <specification>: New
1718         method.
1719         (class tui_layout_window) <specification>: New method.
1720         (class tui_layout_split) <specification>: New method.
1721
1722 2020-02-22  Tom Tromey  <tom@tromey.com>
1723
1724         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
1725         * tui/tui-win.c (window_name_completer): Update comment.
1726         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
1727         Declare method.
1728         (class tui_layout_window) <replace_window>: Likewise.
1729         (class tui_layout_split) <replace_window>: Likewise.
1730         (tui_set_layout): Don't declare.
1731         (tui_set_initial_layout): Declare function.
1732         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
1733         (asm_regs_layout): New globals.
1734         (tui_current_layout, show_layout): Remove.
1735         (tui_set_layout, tui_add_win_to_layout): Rewrite.
1736         (find_layout, tui_apply_layout): New function.
1737         (layout_completer): Remove.
1738         (tui_next_layout): Reimplement.
1739         (tui_next_layout_command): New function.
1740         (tui_set_initial_layout, tui_prev_layout_command): New functions.
1741         (tui_regs_layout): Reimplement.
1742         (tui_regs_layout_command): New function.
1743         (extract_display_start_addr): Rewrite.
1744         (next_layout, prev_layout): Remove.
1745         (tui_layout_window::replace_window): New method.
1746         (tui_layout_split::replace_window): New method.
1747         (destroy_layout): New function.
1748         (layout_list): New global.
1749         (add_layout_command): New function.
1750         (initialize_layouts): Update.
1751         (tui_layout_command): New function.
1752         (_initialize_tui_layout): Install "layout" commands.
1753         * tui/tui-data.h (enum tui_layout_type): Remove.
1754         (tui_current_layout): Don't declare.
1755
1756 2020-02-22  Tom Tromey  <tom@tromey.com>
1757
1758         * tui/tui-regs.c (tui_reg_layout): Remove.
1759         (tui_reg_command): Use tui_regs_layout.
1760         * tui/tui-layout.h (tui_reg_command): Declare.
1761         * tui/tui-layout.c (tui_reg_command): New function.
1762
1763 2020-02-22  Tom Tromey  <tom@tromey.com>
1764
1765         * tui/tui.c (tui_rl_delete_other_windows): Call
1766         tui_remove_some_windows.
1767         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
1768         Declare method.
1769         (class tui_layout_window) <remove_windows>: New method.
1770         (class tui_layout_split) <remove_windows>: Declare.
1771         (tui_remove_some_windows): Declare.
1772         * tui/tui-layout.c (tui_remove_some_windows): New function.
1773         (tui_layout_split::remove_windows): New method.
1774
1775 2020-02-22  Tom Tromey  <tom@tromey.com>
1776
1777         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
1778         * tui/tui-layout.h (tui_next_layout): Declare.
1779         * tui/tui-layout.c (tui_next_layout): New function.
1780
1781 2020-02-22  Tom Tromey  <tom@tromey.com>
1782
1783         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
1784         correct coordinates.
1785
1786 2020-02-22  Tom Tromey  <tom@tromey.com>
1787
1788         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
1789         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
1790         DATA_WIN case.
1791
1792 2020-02-22  Tom Tromey  <tom@tromey.com>
1793
1794         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
1795         TUI_DISASM_WIN, not tui_win_list.
1796
1797 2020-02-22  Tom Tromey  <tom@tromey.com>
1798
1799         * valprint.c (generic_val_print_enum_1)
1800         (val_print_type_code_flags): Style member names.
1801         * rust-lang.c (val_print_struct, rust_print_enum)
1802         (rust_print_struct_def, rust_internal_print_type): Style member
1803         names.
1804         * p-valprint.c (pascal_object_print_value_fields): Style member
1805         names.  Only call fprintf_symbol_filtered for static members.
1806         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
1807         * f-valprint.c (f_val_print): Style member names.
1808         * f-typeprint.c (f_type_print_base): Style member names.
1809         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
1810         call fprintf_symbol_filtered for static members.
1811         (cp_print_class_member): Style member names.
1812         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
1813         member names.
1814         * ada-valprint.c (ada_print_scalar): Style enum names.
1815         (ada_val_print_enum): Likewise.
1816         * ada-typeprint.c (print_enum_type): Style enum names.
1817
1818 2020-02-21  Tom Tromey  <tom@tromey.com>
1819
1820         * psympriv.h (struct partial_symtab): Update comment.
1821
1822 2020-02-21  Tom Tromey  <tromey@adacore.com>
1823
1824         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
1825         type is CORE_ADDR.
1826
1827 2020-02-21  Tom de Vries  <tdevries@suse.de>
1828
1829         PR gdb/25534
1830         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
1831         if dependencies[i]->user != NULL.
1832
1833 2020-02-21  Ali Tamur  <tamur@google.com>
1834
1835         * dwarf2/read.c (dwarf2_name): Add null check.
1836
1837 2020-02-20  Tom Tromey  <tom@tromey.com>
1838
1839         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
1840         ">=", in binary search.
1841         (dwarf2_find_containing_comp_unit): New overload.
1842         (run_test): New self-test.
1843         (_initialize_dwarf2_read): Register new test.
1844
1845 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
1846
1847         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
1848         * riscv-tdep.h: Likewise.
1849         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
1850         rv32-only CSR.
1851         * features/riscv/64bit-csr.xml: Regenerated.
1852
1853 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
1854             Tom Tromey  <tom@tromey.com>
1855
1856         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
1857         of 'fputc_unfiltered'.
1858         (putchar_unfiltered): Call 'fputc_unfiltered'.
1859         (fputc_unfiltered): Call 'fputs_unfiltered'.
1860
1861 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
1862
1863         * config.in: Regenerate.
1864         * configure: Regenerate.
1865         * configure.ac: Add --with-python-libdir option.
1866         * main.c: Use WITH_PYTHON_LIBDIR.
1867
1868 2020-02-19  Tom Tromey  <tom@tromey.com>
1869
1870         * symtab.c (general_symbol_info::compute_and_set_names): Use
1871         obstack_strndup.  Simplify call to symbol_set_demangled_name.
1872
1873 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
1874
1875         * dwarf2/read.c (allocate_signatured_type_table,
1876         allocate_dwo_unit_table, allocate_type_unit_groups_table,
1877         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
1878         Remove objfile parameter, update all callers.
1879
1880 2020-02-19  Doug Evans  <dje@google.com>
1881
1882         PR rust/25535
1883         * rust-lang.c (rust_print_enum): Apply embedded_offset to
1884         rust_enum_variant calculation.
1885
1886 2020-02-19  Tom Tromey  <tromey@adacore.com>
1887
1888         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
1889
1890 2020-02-19  Tom Tromey  <tromey@adacore.com>
1891
1892         * ada-lang.c (cache_symbol): Use obstack_strdup.
1893
1894 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1895
1896         * configure: Regenerate.
1897
1898 2020-02-19  Tom Tromey  <tromey@adacore.com>
1899
1900         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
1901         NULL check.
1902
1903 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
1904
1905         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
1906
1907 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1908
1909         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
1910         if GDBSERVER is not defined.
1911         (riscv_tdesc_cache): Likewise, also store const target_desc.
1912         (STATIC_IN_GDB): Define.
1913         (riscv_create_target_description): Update declaration with
1914         STATIC_IN_GDB.
1915         (riscv_lookup_target_description): New function, only define if
1916         GDBSERVER is not defined.
1917         * arch/riscv.h (riscv_create_target_description): Declare only
1918         when GDBSERVER is defined.
1919         (riscv_lookup_target_description): New declaration when GDBSERVER
1920         is not defined.
1921         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
1922         (riscv_linux_read_features): ...this, and return
1923         riscv_gdbarch_features instead of target_desc.
1924         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
1925         (riscv_linux_read_description): Rename to...
1926         (riscv_linux_read_features): ...this.
1927         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
1928         Update to use riscv_gdbarch_features and
1929         riscv_lookup_target_description.
1930         * riscv-tdep.c (riscv_find_default_target_description): Use
1931         riscv_lookup_target_description instead of
1932         riscv_create_target_description.
1933
1934 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1935
1936         * valprint.c (generic_val_print_enum_1): When printing a flag
1937         enum with value 0 and there is no enumerator with value 0, print
1938         just "0" instead of "(unknown: 0x0)".
1939
1940 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1941
1942         * valprint.c (generic_val_print_enum_1): Print unknown part of
1943         flag enum in hex.
1944
1945 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1946
1947         * dwarf2/read.c (update_enumeration_type_from_children): Allow
1948         flag enums to contain duplicate enumerators.
1949         * valprint.c (generic_val_print_enum_1): Update comment.
1950
1951 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1952
1953         * dwarf2/read.c: Include "count-one-bits.h".
1954         (update_enumeration_type_from_children): If an enumerator has
1955         multiple bits set, don't treat the enumeration as a "flag enum".
1956         * valprint.c (generic_val_print_enum_1): Assert that enumerators
1957         of flag enums have 0 or 1 bit set.
1958
1959 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1960
1961         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
1962         conversion.
1963         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
1964         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
1965         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
1966         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
1967         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
1968
1969 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1970
1971         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
1972
1973 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
1974
1975         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
1976         displaced_step_closure_up.
1977         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
1978         (struct displaced_step_closure_up):
1979         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
1980         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
1981         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
1982         Likewise.
1983         * gdbarch.sh (displaced_step_copy_insn): Likewise.
1984         * gdbarch.c, gdbarch.h: Re-generate.
1985         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
1986         displaced_step_closure_up.
1987         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
1988         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
1989         * infrun.h (displaced_step_closure_up): New type alias.
1990         (struct displaced_step_inferior_state) <step_closure>: Change
1991         type to displaced_step_closure_up.
1992         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
1993         displaced_step_closure_up.
1994         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
1995
1996 2020-02-14  Tom Tromey  <tom@tromey.com>
1997
1998         * minidebug.c (gnu_debug_key): New global.
1999         (find_separate_debug_file_in_section): Use it.
2000
2001 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
2002
2003         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
2004         std::unique_ptr.
2005         * gdbarch.c: Re-generate.
2006         * gdbarch.h: Re-generate.
2007         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
2008         change.
2009         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
2010         type to std::unique_ptr.
2011         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
2012         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
2013         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
2014         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
2015         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
2016         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
2017         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
2018         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
2019         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
2020
2021 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
2022
2023         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
2024         std::unique_ptr.
2025         (displaced_step_clear): Rename to...
2026         (displaced_step_reset): ... this.  Just call displaced->reset ().
2027         (displaced_step_clear_cleanup): Rename to...
2028         (displaced_step_reset_cleanup): ... this.
2029         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
2030         (displaced_step_fixup): Likewise.
2031         (resume_1): Likewise.
2032         (handle_inferior_event): Restore child's memory before calling
2033         displaced_step_fixup on the parent.
2034         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
2035         to std::unique_ptr.
2036         <step_closure>: Change type to std::unique_ptr.
2037
2038 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
2039
2040         * arm-tdep.c: Include count-one-bits.h.
2041         (cleanup_block_store_pc): Use count_one_bits.
2042         (cleanup_block_load_pc): Use count_one_bits.
2043         (arm_copy_block_xfer): Use count_one_bits.
2044         (thumb2_copy_block_xfer): Use count_one_bits.
2045         (thumb_copy_pop_pc_16bit): Use count_one_bits.
2046         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
2047         (thumb_get_next_pcs_raw): Use count_one_bits.
2048         (arm_get_next_pcs_raw): Use count_one_bits_l.
2049         * arch/arm.c (bitcount): Remove.
2050         * arch/arm.h (bitcount): Remove.
2051
2052 2020-02-14  Tom Tromey  <tromey@adacore.com>
2053
2054         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
2055         Update.
2056         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
2057         * dwarf2/loc.c (call_site_find_chain_1): Return
2058         unique_xmalloc_ptr.
2059         (call_site_find_chain): Likewise.
2060
2061 2020-02-14  Richard Biener  <rguenther@suse.de>
2062
2063         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
2064         on expression with division operators.
2065
2066 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
2067
2068         * MAINTAINERS (Write After Approval): Adding myself.
2069
2070 2020-02-12  Tom Tromey  <tom@tromey.com>
2071
2072         * event-loop.c (event_data, gdb_event, event_handler_func):
2073         Remove.
2074
2075 2020-02-12  Tom Tromey  <tom@tromey.com>
2076
2077         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
2078         (dwarf2_frame_objfile_data): Add comment.
2079         (find_comp_unit, set_comp_unit): New functions.
2080         (dwarf2_frame_find_fde): Use find_comp_unit.
2081         (dwarf2_build_frame_info): Use set_comp_unit.
2082
2083 2020-02-12  Tom Tromey  <tom@tromey.com>
2084
2085         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
2086         (comp_unit): Don't initialize objfile.
2087         (execute_cfa_program): Add text_offset parameter.
2088         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
2089         (dwarf2_frame_cache): Update.
2090         (dwarf2_build_frame_info): Don't set "objfile" member.
2091
2092 2020-02-12  Tom Tromey  <tom@tromey.com>
2093
2094         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
2095         (decode_frame_entry): Likewise.
2096         (dwarf2_build_frame_info): Update.
2097
2098 2020-02-12  Tom Tromey  <tom@tromey.com>
2099
2100         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
2101         (decode_frame_entry_1): Use the comp_unit obstack.
2102
2103 2020-02-12  Tom Tromey  <tom@tromey.com>
2104
2105         * dwarf2/frame.c (struct comp_unit): Add initializers and
2106         constructor.
2107         (dwarf2_frame_objfile_data): Store a comp_unit.
2108         (dwarf2_frame_find_fde): Update.
2109         (dwarf2_build_frame_info): Use "new".
2110
2111 2020-02-12  Tom Tromey  <tom@tromey.com>
2112
2113         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
2114         (dwarf2_fde_table): Typedef for std::vector.
2115         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
2116         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
2117         (decode_frame_entry): Update.
2118         (dwarf2_build_frame_info): Use "new".
2119
2120 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
2121
2122         * arm-tdep.c (arm_gdbarch_init): Update.
2123         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
2124         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
2125         have_neon, is_m>: Change to bool.
2126
2127 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
2128
2129         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
2130
2131 2020-02-12  Tom Tromey  <tom@tromey.com>
2132
2133         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
2134
2135 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
2136
2137         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
2138         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
2139
2140 2020-02-11  Tom Tromey  <tom@tromey.com>
2141
2142         * psymtab.h: Update comment.
2143
2144 2020-02-11  Tom Tromey  <tom@tromey.com>
2145
2146         * gdb_obstack.h (struct auto_obstack): Use
2147         DISABLE_COPY_AND_ASSIGN.
2148
2149 2020-02-11  Tom Tromey  <tom@tromey.com>
2150
2151         * dwarf2/frame.h (struct objfile): Don't forward declare.
2152
2153 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
2154
2155         * cris-tdep.c (cris_supply_gregset): Change signature to match
2156         what struct regset expects.
2157         (cris_regset): New struct.
2158         (fetch_core_registers): Remove.
2159         (cris_iterate_over_regset_sections): New function.
2160         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
2161         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
2162
2163 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
2164
2165         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
2166         registers.
2167
2168 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
2169
2170         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
2171
2172 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
2173
2174         * configure: Re-generate.
2175
2176 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
2177
2178         * configure: Re-generate.
2179
2180 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
2181
2182         * acinclude: Update warning.m4 path.
2183         * warning.m4: Move to gdbsupport.
2184
2185 2020-02-11  Tom Tromey  <tromey@adacore.com>
2186
2187         * remote.c (remote_console_output): Update.
2188         * printcmd.c (printf_command): Update.
2189         * event-loop.c (gdb_wait_for_event): Update.
2190         * linux-nat.c (sigchld_handler): Update.
2191         * remote-sim.c (gdb_os_write_stdout): Update.
2192         (gdb_os_flush_stdout): Update.
2193         (gdb_os_flush_stderr): Update.
2194         (gdb_os_write_stderr): Update.
2195         * exceptions.c (print_exception): Update.
2196         * remote-fileio.c (remote_fileio_func_read): Update.
2197         (remote_fileio_func_write): Update.
2198         * tui/tui.c (tui_enable): Update.
2199         * tui/tui-interp.c (tui_interp::init): Update.
2200         * utils.c (init_page_info): Update.
2201         (putchar_unfiltered, fputc_unfiltered): Update.
2202         (gdb_flush): Update.
2203         (emit_style_escape): Update.
2204         (flush_wrap_buffer, fputs_maybe_filtered): Update.
2205         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
2206         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
2207         (stderr_file::write): Update.
2208         (stderr_file::puts): Update.
2209         * ui-file.h (ui_file_isatty, ui_file_write)
2210         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
2211         (ui_file_puts): Don't declare.
2212
2213 2020-02-10  Tom de Vries  <tdevries@suse.de>
2214
2215         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
2216         sentinel to char *.
2217
2218 2020-02-09  Tom de Vries  <tdevries@suse.de>
2219
2220         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
2221         filename if it matches "<artificial>".
2222
2223 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
2224
2225         * windows-tdep.c (struct enum_value_name): New struct.
2226         (create_enum): New function.
2227         (windows_get_siginfo_type): Create and use enum types.
2228
2229 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
2230
2231         * NEWS: Mention $_siginfo support for Windows.
2232         * windows-nat.c (handle_exception): Set siginfo_er.
2233         (windows_nat_target::mourn_inferior): Reset siginfo_er.
2234         (windows_xfer_siginfo): New function.
2235         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
2236         * windows-tdep.c (struct windows_gdbarch_data): New struct.
2237         (init_windows_gdbarch_data): New function.
2238         (get_windows_gdbarch_data): New function.
2239         (windows_get_siginfo_type): New function.
2240         (windows_init_abi): Register windows_get_siginfo_type.
2241         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
2242
2243 2020-02-08  Tom Tromey  <tom@tromey.com>
2244
2245         * dwarf2/read.c (class cutu_reader) <cutu_reader,
2246         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
2247         <keep>: Declare method.
2248         <m_keep>: Remove member.
2249         <~cutu_reader>: Remove.
2250         (cutu_reader::init_tu_and_read_dwo_dies): Update.
2251         (cutu_reader::cutu_reader): Update.
2252         (cutu_reader::keep): Rename from ~cutu_reader.
2253         (process_psymtab_comp_unit, build_type_psymtabs_1)
2254         (process_skeletonless_type_unit, load_partial_comp_unit)
2255         (load_full_comp_unit, dwarf2_read_addr_index)
2256         (read_signatured_type): Update.
2257
2258 2020-02-08  Tom Tromey  <tom@tromey.com>
2259
2260         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
2261         "want_partial_unit" parameter.
2262         (process_psymtab_comp_unit): Change want_partial_unit to bool.
2263         Inline check for DW_TAG_partial_unit.
2264         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
2265
2266 2020-02-08  Tom Tromey  <tom@tromey.com>
2267
2268         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
2269         read.c.
2270         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
2271         read.c.
2272
2273 2020-02-08  Tom Tromey  <tom@tromey.com>
2274
2275         * dwarf2/read.c (read_address): Move to comp-unit.c.
2276         (dwarf2_rnglists_process, dwarf2_ranges_process)
2277         (read_attribute_value, dwarf_decode_lines_1)
2278         (var_decode_location, decode_locdesc): Update.
2279         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
2280         read.c.  Remove "cu" parameter.
2281         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
2282         method.
2283
2284 2020-02-08  Tom Tromey  <tom@tromey.com>
2285
2286         * dwarf2/read.c (read_attribute_value, read_indirect_string)
2287         (read_indirect_line_string): Update.
2288         * dwarf2/comp-unit.c (read_offset): Remove.
2289         (read_comp_unit_head): Update.
2290         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
2291         method.
2292         (read_offset): Don't declare.
2293
2294 2020-02-08  Tom Tromey  <tom@tromey.com>
2295
2296         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
2297         * dwarf2/read.c (struct comp_unit_head): Move to
2298         dwarf2/comp-unit.h.
2299         (enum class rcuh_kind): Move to comp-unit.h.
2300         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
2301         (read_comp_unit_head, error_check_comp_unit_head)
2302         (read_and_check_comp_unit_head): Move to comp-unit.c.
2303         (read_offset, dwarf_unit_type_name): Likewise.
2304         (create_debug_type_hash_table, read_cutu_die_from_dwo)
2305         (cutu_reader::cutu_reader, read_call_site_scope)
2306         (find_partial_die, follow_die_offset): Update.
2307         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
2308
2309 2020-02-08  Tom Tromey  <tom@tromey.com>
2310
2311         * dwarf2/read.c (read_offset_1): Move to leb.c.
2312         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
2313         (dwarf_decode_macro_bytes): Update.
2314         * dwarf2/leb.c (read_offset): Rename; move from read.c.
2315         * dwarf2/leb.h (read_offset): Declare.
2316
2317 2020-02-08  Tom Tromey  <tom@tromey.com>
2318
2319         * dwarf2/read.c (dwarf2_section_size): Remove.
2320         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
2321         Update.
2322         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
2323
2324 2020-02-08  Tom Tromey  <tom@tromey.com>
2325
2326         * dwarf2/read.c (read_initial_length): Move to leb.c.
2327         * dwarf2/leb.h (read_initial_length): Declare.
2328         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
2329         handle_nonstd parameter.
2330         * dwarf2/frame.c (read_initial_length): Remove.
2331         (decode_frame_entry_1): Update.
2332
2333 2020-02-08  Tom Tromey  <tom@tromey.com>
2334
2335         * dwarf2/loc.c (dwarf2_find_location_expression)
2336         (dwarf_evaluate_loc_desc::get_tls_address)
2337         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
2338         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
2339         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
2340         (dwarf2_compile_property_to_c)
2341         (dwarf2_loc_desc_get_symbol_read_needs)
2342         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
2343         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
2344         (loclist_describe_location, loclist_tracepoint_var_ref)
2345         (loclist_generate_c_location): Update.
2346         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
2347         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
2348         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
2349         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
2350         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
2351         (dwarf2_per_cu_data::addr_size)
2352         (dwarf2_per_cu_data::ref_addr_size)
2353         (dwarf2_per_cu_data::text_offset)
2354         (dwarf2_per_cu_data::addr_type): Now methods.
2355         (per_cu_header_read_in): Make per_cu "const".
2356         (dwarf2_version): Remove.
2357         (dwarf2_per_cu_data::int_type): Now a method.
2358         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
2359         (set_die_type, read_array_type, read_subrange_index_type)
2360         (read_tag_string_type, read_subrange_type): Update.
2361         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
2362         offset_size, ref_addr_size, text_offset, addr_type, version,
2363         objfile, int_type, addr_sized_int_type>: Declare methods.
2364
2365 2020-02-08  Tom Tromey  <tom@tromey.com>
2366
2367         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
2368         Move earlier.
2369
2370 2020-02-08  Tom Tromey  <tom@tromey.com>
2371
2372         * dwarf2/read.h (dwarf_line_debug): Declare.
2373         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
2374         * dwarf2/read.c: Move line_header code to new files.
2375         (dwarf_line_debug): No longer static.
2376         * dwarf2/line-header.c: New file.
2377         * dwarf2/line-header.h: New file.
2378
2379 2020-02-08  Tom Tromey  <tom@tromey.com>
2380
2381         * dwarf2/read.c (struct line_header) <file_full_name,
2382         file_file_name>: Return unique_xmalloc_ptr.
2383         (line_header::file_file_name): Update.
2384         (line_header::file_full_name): Update.
2385         (dw2_get_file_names_reader): Update.
2386         (macro_start_file): Update.
2387
2388 2020-02-08  Tom Tromey  <tom@tromey.com>
2389
2390         * dwarf2/read.c (struct line_header) <file_full_name,
2391         file_file_name>: Declare methods.
2392         (dw2_get_file_names_reader): Update.
2393         (file_file_name): Now a method.
2394         (file_full_name): Likewise.
2395         (macro_start_file): Update.
2396
2397 2020-02-08  Tom Tromey  <tom@tromey.com>
2398
2399         * dwarf2/read.c (dwarf_always_disassemble)
2400         (show_dwarf_always_disassemble): Move to loc.c.
2401         (_initialize_dwarf2_read): Move "always-disassemble" registration
2402         to loc.c.
2403         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
2404         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
2405         static.
2406         (show_dwarf_always_disassemble): Move from read.c.
2407         (_initialize_dwarf2loc): Move always-disassemble from read.c.
2408
2409 2020-02-08  Tom Tromey  <tom@tromey.com>
2410
2411         * dwarf2/read.c (~dwarf2_per_objfile): Update.
2412         (create_quick_file_names_table): Return htab_up.
2413         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
2414         Update.
2415         * dwarf2/read.h (struct dwarf2_per_objfile)
2416         <quick_file_names_table>: Now htab_up.
2417
2418 2020-02-08  Tom Tromey  <tom@tromey.com>
2419
2420         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
2421
2422 2020-02-08  Tom Tromey  <tom@tromey.com>
2423
2424         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
2425         Rewrite.
2426         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
2427         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
2428         (abbrev_table::abbrev_table): No longer inline.
2429         (ABBREV_HASH_SIZE): Remove.
2430         (abbrev_table::m_abbrevs): Now an htab_up.
2431
2432 2020-02-08  Tom Tromey  <tom@tromey.com>
2433
2434         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
2435         (cutu_reader): Update.
2436         (build_type_psymtabs_1): Update.
2437         * dwarf2/abbrev.c (abbrev_table::read): Rename.
2438         (abbrev_table::alloc_abbrev): Update.
2439         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
2440         (abbrev_table::read): New static method, renamed from
2441         abbrev_table_read_table.
2442         (abbrev_table::alloc_abbrev)
2443         (abbrev_table::add_abbrev): Now private.
2444         (abbrev_table::abbrev_table): Now private.
2445         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
2446
2447 2020-02-08  Tom Tromey  <tom@tromey.com>
2448
2449         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
2450         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
2451         htab_up.
2452
2453 2020-02-08  Tom Tromey  <tom@tromey.com>
2454
2455         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
2456         htab_up.
2457         (lookup_dwo_unit_in_dwp): Update.
2458         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
2459         on obstack.
2460
2461 2020-02-08  Tom Tromey  <tom@tromey.com>
2462
2463         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
2464         obstack.
2465
2466 2020-02-08  Tom Tromey  <tom@tromey.com>
2467
2468         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
2469         line_header_hash.
2470         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
2471         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
2472         Change type to htab_up.
2473
2474 2020-02-08  Tom Tromey  <tom@tromey.com>
2475
2476         * dwarf2/read.c (allocate_type_unit_groups_table): Return
2477         htab_up.  Don't allocate on obstack.
2478         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
2479         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
2480         Change type to htab_up.
2481
2482 2020-02-08  Tom Tromey  <tom@tromey.com>
2483
2484         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
2485         Change type to htab_up.
2486         * dwarf2/read.c (create_signatured_type_table_from_index)
2487         (create_signatured_type_table_from_debug_names)
2488         (create_all_type_units, add_type_unit)
2489         (lookup_dwo_signatured_type, lookup_signatured_type)
2490         (process_skeletonless_type_unit): Update.
2491         (create_debug_type_hash_table, create_debug_types_hash_table):
2492         Change type of types_htab.
2493         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
2494         htab_up.  Don't allocate on obstack.
2495         (create_cus_hash_table): Change type of cus_htab parameter.
2496         (struct dwo_file) <cus, tus>: Now htab_up.
2497         (lookup_dwo_signatured_type, lookup_dwo_cutu)
2498         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
2499         (queue_and_load_all_dwo_tus): Update.
2500         * dwarf2/index-write.c (write_gdbindex): Update.
2501         (write_debug_names): Update.
2502
2503 2020-02-08  Tom Tromey  <tom@tromey.com>
2504
2505         * dwarf2/read.h (struct dwarf2_queue_item): Move from
2506         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
2507         destructor.
2508         (struct dwarf2_per_objfile) <queue>: New member.
2509         * dwarf2/read.c (struct dwarf2_queue_item): Move to
2510         dwarf2/read.h.
2511         (dwarf2_queue, dwarf2_queue_tail): Remove.
2512         (class dwarf2_queue_guard): Add parameter to constructor.  Use
2513         DISABLE_COPY_AND_ASSIGN.
2514         <m_per_objfile>: New member.
2515         <~dwarf2_queue_guard>: Rewrite.
2516         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
2517         Update.
2518         (~dwarf2_queue_item): New.
2519
2520 2020-02-08  Tom Tromey  <tom@tromey.com>
2521
2522         * dwarf2/read.c (struct die_info) <has_children>: New member.
2523         (dw2_get_file_names_reader): Remove has_children.
2524         (dw2_get_file_names): Update.
2525         (read_cutu_die_from_dwo): Remove has_children.
2526         (cutu_reader::init_tu_and_read_dwo_dies)
2527         (cutu_reader::cutu_reader): Update.
2528         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
2529         Remove has_children.
2530         (build_type_psymtabs_1, process_skeletonless_type_unit)
2531         (load_partial_comp_unit, load_full_comp_unit): Update.
2532         (create_dwo_cu_reader): Remove has_children.
2533         (create_cus_hash_table, read_die_and_children): Update.
2534         (read_full_die_1,read_full_die): Remove has_children.
2535         (read_signatured_type): Update.
2536         (class cutu_reader) <has_children>: Remove.
2537
2538 2020-02-08  Tom Tromey  <tom@tromey.com>
2539
2540         * dwarf2/expr.c: Rename from dwarf2expr.c.
2541         * dwarf2/expr.h: Rename from dwarf2expr.h.
2542         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
2543         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
2544         * dwarf2/frame.c: Rename from dwarf2-frame.c.
2545         * dwarf2/frame.h: Rename from dwarf2-frame.h.
2546         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
2547         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
2548         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
2549         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
2550         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
2551         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
2552         * dwarf2/loc.c: Rename from dwarf2loc.c.
2553         * dwarf2/loc.h: Rename from dwarf2loc.h.
2554         * dwarf2/read.c: Rename from dwarf2read.c.
2555         * dwarf2/read.h: Rename from dwarf2read.h.
2556         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
2557         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
2558         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
2559         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
2560         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
2561         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
2562         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
2563         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
2564         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
2565         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
2566         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
2567         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
2568         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
2569         Update.
2570         * Makefile.in (COMMON_SFILES): Update.
2571         (HFILES_NO_SRCDIR): Update.
2572
2573 2020-02-08  Tom Tromey  <tom@tromey.com>
2574
2575         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
2576         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
2577
2578 2020-02-08  Tom Tromey  <tom@tromey.com>
2579
2580         * dwarf2read.h (struct die_info): Don't declare.
2581
2582 2020-02-08  Tom Tromey  <tom@tromey.com>
2583
2584         * dwarf2read.h (die_info_ptr): Remove typedef.
2585
2586 2020-02-08  Tom Tromey  <tom@tromey.com>
2587
2588         * dwarf2read.c (read_call_site_scope)
2589         (handle_data_member_location, dwarf2_add_member_fn)
2590         (mark_common_block_symbol_computed, read_common_block)
2591         (attr_to_dynamic_prop, partial_die_info::read)
2592         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
2593         (dwarf2_symbol_mark_computed, set_die_type): Update.
2594         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
2595         method.
2596         (attr_form_is_block): Don't declare.
2597         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
2598
2599 2020-02-08  Tom Tromey  <tom@tromey.com>
2600
2601         * dwarf2read.c (dwarf2_find_base_address, )
2602         (read_call_site_scope, rust_containing_type)
2603         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
2604         (handle_data_member_location, dwarf2_add_member_fn)
2605         (get_alignment, read_structure_type, process_structure_scope)
2606         (mark_common_block_symbol_computed, read_common_block)
2607         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
2608         (partial_die_info::read, read_attribute_value, new_symbol)
2609         (lookup_die_type, dwarf2_get_ref_die_offset)
2610         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
2611         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
2612         (dwarf2_symbol_mark_computed): Update.
2613         * dwarf2/attribute.h (struct attribute) <value_as_address,
2614         form_is_section_offset, form_is_constant, form_is_ref>: Declare
2615         methods.
2616         (value_as_address, attr_form_is_section_offset)
2617         (attr_form_is_constant, attr_form_is_ref): Don't declare.
2618         * dwarf2/attribute.c (attribute::value_as_address)
2619         (attribute::form_is_section_offset, attribute::form_is_constant)
2620         (attribute::form_is_ref): Now methods.
2621
2622 2020-02-08  Tom Tromey  <tom@tromey.com>
2623
2624         * dwarf2read.c (struct attribute, DW_STRING)
2625         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
2626         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
2627         (attr_form_is_block, attr_form_is_section_offset)
2628         (attr_form_is_constant, attr_form_is_ref): Move.
2629         * dwarf2/attribute.h: New file.
2630         * dwarf2/attribute.c: New file, from dwarf2read.c.
2631         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
2632
2633 2020-02-08  Tom Tromey  <tom@tromey.com>
2634
2635         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
2636         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
2637         Move.
2638         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
2639         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
2640         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
2641         abbrev.c.
2642         * dwarf2/abbrev.h: New file.
2643         * dwarf2/abbrev.c: New file, from dwarf2read.c.
2644         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
2645
2646 2020-02-08  Tom Tromey  <tom@tromey.com>
2647
2648         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
2649         (dwarf2_section_size, dwarf2_get_section_info)
2650         (create_signatured_type_table_from_debug_names)
2651         (create_addrmap_from_aranges, read_debug_names_from_section)
2652         (get_gdb_index_contents_from_section, read_comp_unit_head)
2653         (error_check_comp_unit_head, read_abbrev_offset)
2654         (create_debug_type_hash_table, init_cu_die_reader)
2655         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
2656         (read_comp_units_from_section, create_cus_hash_table)
2657         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
2658         (create_dwp_v2_section, dwarf2_rnglists_process)
2659         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
2660         (abbrev_table_read_table, read_indirect_string_at_offset_from)
2661         (read_indirect_string_from_dwz, read_addr_index_1)
2662         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
2663         (dwarf_decode_macro_bytes, dwarf_decode_macros)
2664         (fill_in_loclist_baton): Update.
2665         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
2666         get_containing_section, get_bfd_owner, get_bfd_section,
2667         get_file_name, get_id, get_flags, empty, read>: Declare methods.
2668         (dwarf2_read_section, get_section_name, get_section_file_name)
2669         (get_containing_section, get_section_bfd_owner)
2670         (get_section_bfd_section, get_section_name, get_section_file_name)
2671         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
2672         declare.
2673         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
2674         (dwarf2_section_info::get_bfd_owner)
2675         (dwarf2_section_info::get_bfd_section)
2676         (dwarf2_section_info::get_name)
2677         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
2678         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
2679         (dwarf2_section_info::read): Now methods.
2680         * dwarf-index-write.c (class debug_names): Update.
2681
2682 2020-02-08  Tom Tromey  <tom@tromey.com>
2683
2684         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
2685         Move to dwarf2/section.h.
2686         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
2687         (get_section_bfd_section, get_section_name)
2688         (get_section_file_name, get_section_id, get_section_flags)
2689         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
2690         dwarf2/section.c.
2691         * dwarf2/section.h: New file.
2692         * dwarf2/section.c: New file, from dwarf2read.c.
2693         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
2694
2695 2020-02-08  Tom Tromey  <tom@tromey.com>
2696
2697         * dwarf2read.h (read_unsigned_leb128): Don't declare.
2698         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
2699         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
2700         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
2701         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
2702         * dwarf2/leb.h: New file, from dwarf2read.c.
2703         * dwarf2/leb.c: New file, from dwarf2read.c.
2704         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
2705         Remove.
2706         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
2707         (COMMON_SFILES): Add dwarf2/leb.c.
2708
2709 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
2710
2711         GDB 9.1 released.
2712
2713 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
2714
2715         PR gdb/25190:
2716         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
2717         * gdb/remote.c (remote_console_output): Update.
2718         * gdb/ui-file.c (fputs_unfiltered): Rename to...
2719         (ui_file_puts): ...this.
2720         * gdb/ui-file.h (ui_file_puts): Add declaration.
2721         * gdb/utils.c (emit_style_escape): Update.
2722         (flush_wrap_buffer): Update.
2723         (fputs_maybe_filtered): Update.
2724         (fputs_unfiltered): Add function.
2725
2726 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
2727
2728         * gdb/event-loop.c (gdb_wait_for_event): Update.
2729         * gdb/printcmd.c (printf_command): Update.
2730         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
2731         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
2732         (gdb_os_flush_stderr): Update.
2733         * gdb/remote.c (remote_console_output): Update.
2734         * gdb/ui-file.c (gdb_flush): Rename to...
2735         (ui_file_flush): ...this.
2736         (stderr_file::write): Update.
2737         (stderr_file::puts): Update.
2738         * gdb/ui-file.h (gdb_flush): Rename to...
2739         (ui_file_flush): ...this.
2740         * gdb/utils.c (gdb_flush): Add function.
2741         * gdb/utils.h (gdb_flush): Add declaration.
2742
2743 2020-02-07  Tom Tromey  <tromey@adacore.com>
2744
2745         PR breakpoints/24915:
2746         * source.c (find_and_open_source): Do not check basenames_may_differ.
2747
2748 2020-02-07  Tom Tromey  <tom@tromey.com>
2749
2750         * README: Update gdbserver documentation.
2751         * gdbserver: Move to top level.
2752         * configure.tgt (build_gdbserver): Remove.
2753         * configure.ac: Remove --enable-gdbserver.
2754         * configure: Rebuild.
2755         * Makefile.in (distclean): Don't mention gdbserver.
2756
2757 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
2758
2759         * source-cache.c (source_cache::ensure): Surround
2760         get_plain_source_lines with a try/catch.
2761         (source_cache::get_line_charpos): Get rid of try/catch
2762         and only check for the return value of "ensure".
2763         * tui/tui-source.c (tui_source_window::set_contents):
2764         Simplify "nlines" calculation.
2765
2766 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
2767
2768         * MAINTAINERS (Write After Approval): Add myself.
2769
2770 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
2771
2772         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
2773         function call.
2774
2775 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
2776
2777         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
2778
2779 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
2780
2781         * nat/riscv-linux-tdesc.h: New file.
2782         * nat/riscv-linux-tdesc.c: New file, taking code from...
2783         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
2784         ... here.
2785         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
2786         NATDEPFILES.
2787
2788 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
2789
2790         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
2791         we don't set the fake simulator ptid to the null_ptid.
2792
2793 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
2794
2795         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
2796         * gdbthread.h (class thread_info) <resumed>: Likewise.
2797         * infrun.c (resume_1): Likewise.
2798         (proceed): Likewise.
2799         (infrun_thread_stop_requested): Likewise.
2800         (stop_all_threads): Likewise.
2801         (handle_inferior_event): Likewise.
2802         (restart_threads): Likewise.
2803         (finish_step_over): Likewise.
2804         (keep_going_stepped_thread): Likewise.
2805         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
2806         (linux_handle_extended_wait): Likewise.
2807         * record-btrace.c (get_thread_current_frame_id): Likewise.
2808         * record-full.c (record_full_wait_1): Likewise.
2809         * remote.c (remote_target::process_initial_stop_replies): Likewise.
2810         * target.c (target_resume): Likewise.
2811         * thread.c (set_running_thread): Likewise.
2812
2813 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
2814
2815         * f-valprint.c (f77_print_array_1): Changed datatype of index
2816         variable to LONGEST from int to enable it to contain bound
2817         values correctly.
2818
2819 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
2820
2821         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
2822         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
2823         offsets according to FLEN determined.
2824         (riscv_linux_nat_target::read_description): Determine FLEN
2825         dynamically.
2826         (riscv_linux_nat_target::fetch_registers): Size regset buffer
2827         according to FLEN determined.
2828         (riscv_linux_nat_target::store_registers): Likewise.
2829
2830 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
2831
2832         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
2833         when reg->group is empty and reggroup is not.
2834
2835 2020-01-31  Tom Tromey  <tromey@adacore.com>
2836
2837         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
2838         Call beneath target's mourn_inferior after unpushing.
2839
2840 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2841
2842         PR tui/9765
2843         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
2844         have enough lines to fill the screen, still return the lowest
2845         address we found.
2846
2847 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2848
2849         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
2850         '-', '<', and '>' commands.
2851
2852 2020-01-29  Pedro Alves  <palves@redhat.com>
2853             Sergio Durigan Junior  <sergiodj@redhat.com>
2854
2855         * infcmd.c (construct_inferior_arguments): Assert that
2856         'argc' is greater than 0.
2857
2858 2020-01-29  Luis Machado  <luis.machado@linaro.org>
2859
2860         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
2861         (BRK_INSN_MASK): Define to 0xd4200000.
2862         (aarch64_program_breakpoint_here_p): New function.
2863         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
2864         * arch-utils.c (default_program_breakpoint_here_p): Moved from
2865         breakpoint.c.
2866         * arch-utils.h (default_program_breakpoint_here_p): Moved from
2867         breakpoint.h
2868         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
2869         call gdbarch_program_breakpoint_here_p.
2870         (program_breakpoint_here): Moved to arch-utils.c, renamed to
2871         default_program_breakpoint_here_p, changed return type to bool and
2872         simplified.
2873         * breakpoint.h (program_breakpoint_here): Moved prototype to
2874         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
2875         return type to bool.
2876         * gdbarch.c: Regenerate.
2877         * gdbarch.h: Regenerate.
2878         * gdbarch.sh (program_breakpoint_here_p): New method.
2879         * infrun.c (handle_signal_stop): Call
2880         gdbarch_program_breakpoint_here_p.
2881
2882 2020-01-26  Tom Tromey  <tom@tromey.com>
2883
2884         * ctfread.c (struct ctf_fp_info): Reindent.
2885         (_initialize_ctfread): Remove.
2886
2887 2020-01-26  Tom Tromey  <tom@tromey.com>
2888
2889         * psymtab.c (partial_map_expand_apply)
2890         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
2891         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
2892         (psym_print_stats, psym_expand_symtabs_for_function)
2893         (psym_map_symbol_filenames, psym_map_matching_symbols)
2894         (psym_expand_symtabs_matching)
2895         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
2896         (maintenance_check_psymtabs): Use new methods.
2897         * psympriv.h (struct partial_symtab) <readin_p,
2898         get_compunit_symtab>: New methods.
2899         <readin, compunit_symtab>: Remove members.
2900         (struct standard_psymtab): New.
2901         (struct legacy_psymtab): Derive from standard_psymtab.
2902         * dwarf2read.h (struct dwarf2_psymtab): Derive from
2903         standard_psymtab.
2904         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
2905
2906 2020-01-26  Tom Tromey  <tom@tromey.com>
2907
2908         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
2909         read_dependencies.  Add assert.
2910         * psymtab.c (partial_symtab::read_dependencies): New method.
2911         * psympriv.h (struct partial_symtab) <read_dependencies>: New
2912         method.
2913         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
2914         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
2915         read_dependencies.
2916         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
2917         Add assert.
2918
2919 2020-01-26  Tom Tromey  <tom@tromey.com>
2920
2921         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
2922         Call expand_psymtab.
2923         (xcoff_read_symtab): Call expand_psymtab.
2924         (xcoff_start_psymtab, xcoff_end_psymtab): Set
2925         legacy_expand_psymtab.
2926         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
2927         method.
2928         (struct legacy_psymtab) <expand_psymtab>: Implement.
2929         <legacy_expand_psymtab>: New member.
2930         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
2931         (parse_partial_symbols): Set legacy_expand_psymtab.
2932         (psymtab_to_symtab_1): Change argument order.  Call
2933         expand_psymtab.
2934         (new_psymtab): Set legacy_expand_psymtab.
2935         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
2936         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
2937         expand_psymtab.
2938         (dwarf2_psymtab::expand_psymtab): Rename from
2939         psymtab_to_symtab_1.  Call expand_psymtab.
2940         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
2941         (dbx_end_psymtab): Likewise.
2942         (dbx_psymtab_to_symtab_1): Change argument order. Call
2943         expand_psymtab.
2944         (dbx_read_symtab): Call expand_psymtab.
2945         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
2946         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
2947         (ctf_psymtab::read_symtab): Call expand_psymtab.
2948
2949 2020-01-26  Tom Tromey  <tom@tromey.com>
2950
2951         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
2952         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
2953         messages.
2954         * mdebugread.c (mdebug_read_symtab): Remove prints.
2955         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
2956         assert.
2957         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
2958
2959 2020-01-26  Tom Tromey  <tom@tromey.com>
2960
2961         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
2962         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
2963         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
2964         legacy_symtab.
2965         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
2966         * psymtab.c (psymtab_to_symtab): Call method.
2967         (dump_psymtab): Update.
2968         * psympriv.h (struct partial_symtab): Add virtual destructor.
2969         <read_symtab>: New method.
2970         (struct legacy_symtab): New.
2971         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
2972         (struct pst_map) <pst>: Now a legacy_psymtab.
2973         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
2974         (new_psymtab): Use legacy_psymtab.
2975         * dwarf2read.h (struct dwarf2_psymtab): New.
2976         (struct dwarf2_per_cu_data) <psymtab>: Use it.
2977         * dwarf2read.c (dwarf2_create_include_psymtab)
2978         (dwarf2_build_include_psymtabs, create_type_unit_group)
2979         (create_partial_symtab, process_psymtab_comp_unit_reader)
2980         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
2981         (set_partial_user): Use dwarf2_psymtab.
2982         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
2983         (psymtab_to_symtab_1, process_full_comp_unit)
2984         (process_full_type_unit, dwarf2_ranges_read)
2985         (dwarf2_get_pc_bounds, psymtab_include_file_name)
2986         (dwarf_decode_lines): Use dwarf2_psymtab.
2987         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
2988         (add_address_entry_worker, write_one_signatured_type)
2989         (recursively_count_psymbols, recursively_write_psymbols)
2990         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
2991         (write_debug_names): Likewise.
2992         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
2993         <pst>: Now a legacy_psymtab.
2994         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
2995         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
2996         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
2997         * ctfread.c (struct ctf_psymtab): New.
2998         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
2999         ctf_psymtab.
3000         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
3001         (create_partial_symtab): Return a ctf_psymtab.
3002         (scan_partial_symbols): Update.
3003
3004 2020-01-26  Tom Tromey  <tom@tromey.com>
3005
3006         * xcoffread.c (xcoff_start_psymtab): Use new.
3007         * psymtab.c (partial_symtab::partial_symtab): New constructor,
3008         renamed from start_psymtab_common.
3009         * psympriv.h (struct partial_symtab): Add new constructor.
3010         (start_psymtab_common): Don't declare.
3011         * mdebugread.c (parse_partial_symbols): Use new.
3012         * dwarf2read.c (create_partial_symtab): Use new.
3013         * dbxread.c (start_psymtab): Use new.
3014         * ctfread.c (create_partial_symtab): Use new.
3015
3016 2020-01-26  Tom Tromey  <tom@tromey.com>
3017
3018         * xcoffread.c (xcoff_end_psymtab): Use new.
3019         * psymtab.c (start_psymtab_common): Use new.
3020         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
3021         Update.
3022         * psympriv.h (struct partial_symtab): Add parameters to
3023         constructor.  Don't inline.
3024         (allocate_psymtab): Don't declare.
3025         * mdebugread.c (new_psymtab): Use new.
3026         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
3027         * dbxread.c (dbx_end_psymtab): Use new.
3028
3029 2020-01-26  Tom Tromey  <tom@tromey.com>
3030
3031         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
3032         allocate_psymtab.  Update documentation.
3033         * psymtab.c (psymtab_storage::install_psymtab): Rename from
3034         allocate_psymtab.  Do not use new.
3035         (allocate_psymtab): Use new.  Update.
3036
3037 2020-01-26  Tom Tromey  <tom@tromey.com>
3038
3039         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
3040         * psymtab.c (psym_print_stats): Update.
3041         * psympriv.h (struct partial_symtab) <readin,
3042         psymtabs_addrmap_supported, anonymous>: Now bool.
3043         * mdebugread.c (psymtab_to_symtab_1): Update.
3044         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
3045         (build_type_psymtabs_reader, psymtab_to_symtab_1)
3046         (process_full_comp_unit, process_full_type_unit): Update.
3047         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
3048         * ctfread.c (psymtab_to_symtab): Update.
3049
3050 2020-01-26  Tom Tromey  <tom@tromey.com>
3051
3052         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
3053         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
3054         * psymtab.c (psymtab_storage): Delete psymtabs.
3055         (psymtab_storage::allocate_psymtab): Use new.
3056         (psymtab_storage::discard_psymtab): Use delete.
3057         * psympriv.h (struct partial_symtab): Add constructor and
3058         initializers.
3059
3060 2020-01-26  Tom Tromey  <tom@tromey.com>
3061
3062         * machoread.c: Do not include psympriv.h.
3063
3064 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3065
3066         * NEWS: Mention the new option and the set/show commands.
3067
3068 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3069
3070         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
3071         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
3072         (validate_exec_file): New variables, enums, functions.
3073         (exec_file_locate_attach, print_section_info): Style the filenames.
3074         (_initialize_exec): Install show_exec_file_mismatch_command and
3075          set_exec_file_mismatch_command.
3076         * gdbcore.h (validate_exec_file): Declare.
3077         * infcmd.c (attach_command): Call validate_exec_file.
3078         * remote.c ( remote_target::remote_add_inferior): Likewise.
3079
3080 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3081
3082         * frame.c (find_frame_sal): Move call to get_next_frame into more
3083         inner scope.
3084         * inline-frame.c (inilne_state) <inline_state>: Update argument
3085         types.
3086         (inilne_state) <skipped_symbol>: Rename to...
3087         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
3088         (skip_inline_frames): Build vector of skipped symbols and use this
3089         to reate the inline_state.
3090         (inline_skipped_symbol): Add a comment and some assertions, fetch
3091         skipped symbol from the list.
3092
3093 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3094
3095         * buildsym.c (lte_is_less_than): Delete.
3096         (buildsym_compunit::end_symtab_with_blockvector): Create local
3097         lambda function to sort line table entries, and use
3098         std::stable_sort instead of std::sort.
3099         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
3100         markers when looking for a previous line.
3101
3102 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3103
3104         * dwarf2read.c (lnp_state_machine::record_line): Include
3105         end_sequence parameter in debug print out.  Record the line if we
3106         are at an end_sequence marker even if it's not the start of a
3107         statement.
3108         * symmisc.c (maintenance_print_one_line_table): Print end of
3109         sequence markers with 'END' not '0'.
3110
3111 2020-01-24  Pedro Alves  <palves@redhat.com>
3112
3113         PR gdb/25410
3114         * thread.c (scoped_restore_current_thread::restore): Use
3115         switch_to_inferior_no_thread.
3116         * exec.c: Include "progspace-and-thread.h".
3117         (add_target_sections, remove_target_sections):
3118         scoped_restore_current_pspace_and_thread instead of
3119         scoped_restore_current_thread.
3120         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
3121         and aspace to the inferior before calling clone_program_space.
3122         Remove stale comment.
3123
3124 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
3125
3126         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
3127         (arm_netbsd_nat_target::fetch_registers): ...this.
3128         (arm_nbsd_nat_target::store_registers): Rename to...
3129         (arm_netbsd_nat_target::store_registers): ...this.
3130
3131 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
3132
3133         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
3134         register_t.
3135
3136 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
3137
3138         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
3139         Update comment.
3140         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
3141         Likewise.
3142         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
3143         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
3144         the correct replacement (iterate_over_regset_sections).
3145         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
3146         Update comment.
3147
3148 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
3149
3150         PR gdb/23718
3151         * gdb/python/python.c (execute_gdb_command): Call
3152         async_enable_stdin in catch block.
3153
3154 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3155
3156         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
3157         SWITCH_THRU_ALL_UIS.
3158
3159 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3160
3161         PR tui/9765
3162         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
3163         comment, add extra parameter, and update to store previous symbol
3164         when appropriate.
3165         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
3166         add extra parameter.
3167         * tui/tui-disasm.c (tui_disassemble): Update header comment,
3168         remove unneeded parameter, add try/catch around gdb_print_insn,
3169         rewrite to add items to asm_lines vector.
3170         (tui_find_backward_disassembly_start_address): New function.
3171         (tui_find_disassembly_address): Updated throughout.
3172         (tui_disasm_window::set_contents): Update for changes to
3173         tui_disassemble.
3174         (tui_disasm_window::do_scroll_vertical): No need to adjust the
3175         number of lines to scroll.
3176
3177 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
3178
3179         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
3180         (SECT_OFF_DATA): Likewise.
3181         (SECT_OFF_RODATA): Likewise.
3182         (SECT_OFF_TEXT): Likewise.
3183         (SECT_OFF_BSS): Likewise.
3184         (struct objfile) <text_section_offset, data_section_offset>: New
3185         methods.
3186         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
3187         objfile::text_section_offset.
3188         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
3189         * coffread.c (coff_symtab_read): Likewise.
3190         (enter_linenos): Likewise.
3191         (process_coff_symbol): Likewise.
3192         * ctfread.c (get_objfile_text_range): Likewise.
3193         * dtrace-probe.c (dtrace_probe::get_relocated_address):
3194         Use objfile::data_section_offset.
3195         * dwarf2-frame.c (execute_cfa_program): Use
3196         objfile::text_section_offset.
3197         (dwarf2_frame_find_fde): Likewise.
3198         * dwarf2read.c (create_addrmap_from_index): Likewise.
3199         (create_addrmap_from_aranges): Likewise.
3200         (dw2_find_pc_sect_compunit_symtab): Likewise.
3201         (process_psymtab_comp_unit_reader): Likewise.
3202         (add_partial_symbol): Likewise.
3203         (add_partial_subprogram): Likewise.
3204         (process_full_comp_unit): Likewise.
3205         (read_file_scope): Likewise.
3206         (read_func_scope): Likewise.
3207         (read_lexical_block_scope): Likewise.
3208         (read_call_site_scope): Likewise.
3209         (dwarf2_rnglists_process): Likewise.
3210         (dwarf2_ranges_process): Likewise.
3211         (dwarf2_ranges_read): Likewise.
3212         (dwarf_decode_lines_1): Likewise.
3213         (new_symbol): Likewise.
3214         (dwarf2_fetch_die_loc_sect_off): Likewise.
3215         (dwarf2_per_cu_text_offset): Likewise.
3216         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
3217         * hppa-tdep.c (read_unwind_info): Likewise.
3218         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
3219         * psympriv.h (struct partial_symtab): Likewise.
3220         * psymtab.c (find_pc_sect_psymtab): Likewise.
3221         * solib-svr4.c (enable_break): Likewise.
3222         * stap-probe.c (relocate_address): Use
3223         objfile::data_section_offset.
3224         * xcoffread.c (enter_line_range): Use
3225         objfile::text_section_offset.
3226         (read_xcoff_symtab): Likewise.
3227
3228 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
3229
3230         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
3231         declaration to narrower scopes.
3232
3233 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
3234
3235         * darwin-nat.h (struct darwin_exception_msg, enum
3236         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
3237         Move up.
3238         (class darwin_nat_target) <wait_1, check_new_threads,
3239         decode_exception_message, decode_message, stop_inferior,
3240         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
3241         * darwin-nat.c (darwin_check_new_threads): Rename to...
3242         (darwin_nat_target::check_new_threads): ... this.
3243         (darwin_suspend_inferior_it): Remove.
3244         (darwin_decode_exception_message): Rename to...
3245         (darwin_nat_target::decode_exception_message): ... this.
3246         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
3247         (darwin_decode_message): Rename to...
3248         (darwin_nat_target::decode_message): ... this.
3249         (cancel_breakpoint): Rename to...
3250         (darwin_nat_target::cancel_breakpoint): ... this.
3251         (darwin_wait): Rename to...
3252         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
3253         instead of iterate_over_inferiors.
3254         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
3255         (darwin_stop_inferior): Rename to...
3256         (darwin_nat_target::stop_inferior): ... this.
3257         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
3258         (darwin_init_thread_list): Rename to...
3259         (darwin_nat_target::init_thread_list): ... this.
3260         (darwin_ptrace_him): Rename to...
3261         (darwin_nat_target::ptrace_him): ... this.
3262         (darwin_nat_target::create_inferior): Pass lambda function to
3263         fork_inferior.
3264         (darwin_nat_target::detach): Call stop_inferior instead of
3265         darwin_stop_inferior.
3266         * fork-inferior.h (fork_inferior): Change init_trace_fun
3267         parameter to gdb::function_view.
3268         * fork-inferior.c (fork_inferior): Likewise.
3269
3270 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
3271
3272         * i386-cygwin-tdep.c (core_process_module_section): Update.
3273         * windows-nat.c (struct lm_info_windows): Add text_offset.
3274         (windows_xfer_shared_libraries): Update.
3275         * windows-tdep.c (windows_xfer_shared_library):
3276         Add text_offset_cached argument.
3277         * windows-tdep.h (windows_xfer_shared_library): Update.
3278
3279 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
3280
3281         * gdbarch.sh: Add declaration for _initialize_gdbarch.
3282
3283 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
3284
3285         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
3286         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
3287         replace with range-based for.
3288         (gdbsim_interrupt_inferior): Remove.
3289         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
3290         with a range-based for.  Inline code from
3291         gdbsim_interrupt_inferior.
3292
3293 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
3294
3295         * infrun.c (proceed): Fix indentation.
3296
3297 2020-01-21  Tom Tromey  <tromey@adacore.com>
3298
3299         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
3300         * python/python.c (python_extension_ops): Update.
3301         (gdbpy_colorize): New function.
3302         * python/lib/gdb/__init__.py (colorize): New function.
3303         * extension.h (ext_lang_colorize): Declare.
3304         * extension.c (ext_lang_colorize): New function.
3305         * extension-priv.h (struct extension_language_ops) <colorize>: New
3306         member.
3307         * cli/cli-style.c (_initialize_cli_style): Update help text.
3308
3309 2020-01-21  Luis Machado  <luis.machado@linaro.org>
3310
3311         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
3312         <cond>: Change type to bool.
3313         (aarch64_displaced_step_b_cond): Update cond to use bool type.
3314         (aarch64_displaced_step_cb): Likewise.
3315         (aarch64_displaced_step_tb): Likewise.
3316
3317 2020-01-21  Luis Machado  <luis.machado@linaro.org>
3318
3319         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
3320         output.
3321
3322 2020-01-21  Luis Machado  <luis.machado@linaro.org>
3323
3324         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
3325         <pc_adjust>: Adjust the documentation.
3326         (aarch64_displaced_step_fixup): Check if PC really moved before
3327         adjusting it.
3328
3329 2020-01-19  Tom Tromey  <tom@tromey.com>
3330
3331         * disasm.c (~gdb_disassembler): New destructor.
3332         (gdb_buffered_insn_length): Call disassemble_free_target.
3333         * disasm.h (class gdb_disassembler): Declare destructor.  Use
3334         DISABLE_COPY_AND_ASSIGN.
3335
3336 2020-01-19  Tom Tromey  <tom@tromey.com>
3337
3338         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
3339         (die_reader_func_ftype): Remove.
3340         (cutu_reader): New class.
3341         (dw2_get_file_names_reader): Remove "data" parameter.
3342         (dw2_get_file_names): Use cutu_reader.
3343         (create_debug_type_hash_table): Update.
3344         (read_cutu_die_from_dwo): Update comment.
3345         (lookup_dwo_unit): Add dwo_name parameter.
3346         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
3347         die_reader_func_ftype and data parameters.
3348         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
3349         Remove die_reader_func_ftype and data parameters.
3350         (~cutu_reader): New; from init_cutu_and_read_dies.
3351         (cutu_reader::cutu_reader): Rename from
3352         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
3353         and data parameters.
3354         (init_cutu_and_read_dies_simple): Remove.
3355         (struct process_psymtab_comp_unit_data): Remove.
3356         (process_psymtab_comp_unit_reader): Remove data parameter; add
3357         want_partial_unit and pretend_language parameters.
3358         (process_psymtab_comp_unit): Use cutu_reader.
3359         (build_type_psymtabs_reader): Remove data parameter.
3360         (build_type_psymtabs_1): Use cutu_reader.
3361         (process_skeletonless_type_unit): Likewise.
3362         (load_partial_comp_unit_reader): Remove.
3363         (load_partial_comp_unit): Use cutu_reader.
3364         (load_full_comp_unit_reader): Remove.
3365         (load_full_comp_unit): Use cutu_reader.
3366         (struct create_dwo_cu_data): Remove.
3367         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
3368         dwo_unit parameters.
3369         (create_cus_hash_table): Use cutu_reader.
3370         (struct dwarf2_read_addr_index_data): Remove.
3371         (dwarf2_read_addr_index_reader): Remove.
3372         (dwarf2_read_addr_index): Use cutu_reader.
3373         (read_signatured_type_reader): Remove.
3374         (read_signatured_type): Use cutu_reader.
3375
3376 2020-01-19  Tom Tromey  <tom@tromey.com>
3377
3378         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
3379         * tui/tui-wingeneral.h (class tui_suppress_output): New.
3380         (tui_wrefresh): Declare.
3381         * tui/tui-wingeneral.c (suppress_output): New global.
3382         (tui_suppress_output, ~tui_suppress_output): New constructor and
3383         destructor.
3384         (tui_wrefresh): New function.
3385         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
3386         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
3387         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
3388         method.
3389         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
3390         tui_wrefresh.
3391         (tui_data_window::no_refresh): New method.
3392         (tui_data_item_window::refresh_window): Call tui_wrefresh.
3393         (tui_reg_command): Use tui_suppress_output
3394         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
3395         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
3396         method.
3397         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
3398
3399 2020-01-19  Tom Tromey  <tom@tromey.com>
3400
3401         * tui/tui-winsource.c (tui_update_source_windows_with_line):
3402         Handle case where symtab is null.
3403
3404 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
3405
3406         * linux-fork.c (one_fork_p): Simplify.
3407
3408 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
3409
3410         * top.c (struct qt_args): Remove.
3411         (kill_or_detach): Change return type to void, replace `void *`
3412         parameter with a proper one.
3413         (print_inferior_quit_action):  Likewise.
3414         (quit_confirm): Use range-based for loop to iterate over inferiors.
3415         (quit_force): Likewise.
3416
3417 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
3418
3419         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
3420         `void *` parameter with proper parameters.
3421         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
3422         (print_one_inferior): Change return type to void, replace `void *`
3423         parameter with proper parameters.
3424         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
3425         inferiors.
3426         (get_other_inferior): Remove.
3427         (mi_cmd_remove_inferior): Use range-based loop to iterate over
3428         inferiors.
3429
3430 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
3431
3432         * mi/mi-interp.c (report_initial_inferior): Remove.
3433         (mi_interp::init): Use range-based for to iterate over inferiors.
3434
3435 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
3436
3437         * python/py-inferior.c (build_inferior_list): Remove.
3438         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
3439
3440 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
3441
3442         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
3443         (btrace_stitch_trace): Likewise.
3444         * charset.c (intermediate_encoding): Likewise (vaild).
3445         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
3446         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
3447         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
3448
3449 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
3450
3451         * windows-tdep.c (windows_get_tlb_type):
3452         Add rtl_user_process_parameters type.
3453
3454 2020-01-16  Pedro Alves  <palves@redhat.com>
3455             Norbert Lange  <nolange79@gmail.com>
3456
3457         PR build/24805
3458         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
3459         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
3460         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
3461         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
3462         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
3463         (ps_plog): Redeclare exported functions with default visibility.
3464
3465 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
3466
3467         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
3468         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
3469
3470 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
3471
3472         * infcmd.c (post_create_inferior): Use get_thread_regcache
3473         instead of get_current_regcache.
3474
3475 2020-01-14  Tom Tromey  <tom@tromey.com>
3476
3477         PR symtab/12535:
3478         * python/python.c (gdbpy_decode_line): Treat empty string the same
3479         as no argument.
3480
3481 2020-01-14  Tom Tromey  <tom@tromey.com>
3482
3483         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
3484
3485 2020-01-14  Tom Tromey  <tom@tromey.com>
3486
3487         * nat/linux-btrace.c: Don't include <config.h>.
3488         * nat/linux-ptrace.c: Don't include <config.h>.
3489         * nat/x86-linux-dregs.c: Don't include <config.h>.
3490
3491 2020-01-14  Tom Tromey  <tom@tromey.com>
3492
3493         * configure: Rebuild.
3494         * configure.ac: Move many checks to ../gdbsupport/common.m4.
3495
3496 2020-01-14  Tom Tromey  <tom@tromey.com>
3497
3498         * nat/x86-linux-dregs.c: Include configh.h.
3499         * nat/linux-ptrace.c: Include configh.h.
3500         * nat/linux-btrace.c: Include configh.h.
3501         * defs.h: Include config.h, bfd.h.
3502         * configure.ac: Don't source common.host.
3503         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
3504         * configure: Rebuild.
3505         * acinclude.m4: Update path.
3506         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
3507         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
3508         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
3509         (CLIBS): Add LIBSUPPORT.
3510         (CDEPS): Likewise.
3511         (COMMON_SFILES): Remove gdbsupport files.
3512         (HFILES_NO_SRCDIR): Likewise.
3513         (stamp-version): Update path to create-version.sh.
3514         (ALLDEPFILES): Remove gdbsupport files.
3515
3516 2020-01-14  Tom Tromey  <tom@tromey.com>
3517
3518         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
3519         USE_WIN32API when needed.
3520         * configure.ac (USE_WIN32API): Don't define.
3521         (WIN32LIBS): Use WIN32APILIBS.
3522         * configure: Rebuild.
3523
3524 2020-01-14  Tom Tromey  <tom@tromey.com>
3525
3526         * configure: Rebuild.
3527         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
3528
3529 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
3530
3531         * skip.c (skip_function_command): Make skip w/o arguments use the
3532         name of the inlined function if pc is inside any inlined function.
3533
3534 2020-01-14  Luis Machado  <luis.machado@linaro.org>
3535
3536         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
3537         * infrun.c (resume_1): Likewise.
3538         (handle_inferior_event): Remove stale comment.
3539         * linux-nat.c (linux_nat_target::resume): Update comments.
3540         (save_stop_reason): Likewise.
3541         (linux_nat_filter_event): Likewise.
3542         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
3543
3544 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3545
3546         * elfread.c (record_minimal_symbol): Set section index to 0 for
3547         non-allocatable sections.
3548
3549
3550 2020-01-13  Ali Tamur <tamur@google.com>
3551
3552         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
3553         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
3554         to gdb::optional.  Update comments.
3555         (dwo_file): Update comments.
3556         (read_attribute): Update API to take an additional out parameter,
3557         need_reprocess.  This is used to mark attributes that need other
3558         attributes (e.g. str_offsets_base) for correct computation which may not
3559         have been read yet.
3560         (read_attribute_reprocess): New function declaration.
3561         (read_addr_index): Likewise.
3562         (read_dwo_str_index): Likewise.
3563         (read_stub_str_index): Likewise.
3564         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
3565         (lookup_addr_base): New function definition.
3566         (lookup_ranges_base): Likewise.
3567         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
3568         lookup_ranges_base.
3569         (init_cutu_and_read_dies): Update comments.
3570         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
3571         unit.  This is used to inherit parent's str_offsets_base and addr_base.
3572         Update comments.
3573         (init_cutu_and_read_dies_simple): Reflect API changes.
3574         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
3575         (create_cus_hash_table): Change API to take parent compile unit.
3576         Reflect API changes.
3577         (open_and_init_dwo_file): Reflect API changes.
3578         (dwarf2_get_pc_bounds): Update comments.
3579         (dwarf2_record_block_ranges): Likewise.
3580         (read_full_die_1): Change implementation to reprocess attributes that
3581         need str_offsets_base and addr_base.
3582         (partial_die_info::read): Likewise.
3583         (read_attribute_reprocess): New function definition.
3584         (read_attribute_value): Change API to take an additional out parameter,
3585         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
3586         when a non-dwo compile unit has index based attributes.
3587         (read_attribute): Reflect API changes.
3588         (read_addr_index_1): Reflect API changes.  Update comments.
3589         (dwarf2_read_addr_index_data): Reflect API changes.
3590         (dwarf2_read_addr_index): Likewise.
3591         (read_str_index): Change API and implementation.  This becomes a helper
3592         to be used by the new string index related methods.  Update error
3593         message and comments.
3594         (read_dwo_str_index): New function definition.
3595         (read_stub_str_index): Likewise.
3596         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
3597         * symfile.h (dwarf2_debug_sections): Likewise.
3598         * xcoffread.c (dwarf2_debug_sections): Likewise.
3599
3600 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
3601
3602         * gdbcore.h (struct core_fns) <core_read_registers>: Change
3603         core_reg_sect type to gdb_byte *.
3604         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
3605         * cris-tdep.c (fetch_core_registers): Likewise.
3606         * corelow.c (core_target::get_core_register_section): Change
3607         type of `contents` to gdb::byte_vector.
3608
3609 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3610
3611         * tui/tui-wingeneral.c (box_win): Position the title in the center
3612         of the border.
3613
3614 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
3615
3616         * corelow.c (core_target::get_core_register_section): Use
3617           std::vector instead of alloca.
3618
3619 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
3620
3621         * warning.m4: Add -Wmissing-declarations to build_warnings.
3622         * configure: Re-generate.
3623
3624 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
3625
3626         * python/python.c (init__gdb_module): Add declaration.
3627
3628 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
3629
3630         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
3631         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
3632         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
3633         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
3634         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
3635         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
3636         * ada-exp.y (_initialize_ada_exp): Add declaration.
3637         * ada-lang.c (_initialize_ada_language): Add declaration.
3638         * ada-tasks.c (_initialize_tasks): Add declaration.
3639         * agent.c (_initialize_agent): Add declaration.
3640         * aix-thread.c (_initialize_aix_thread): Add declaration.
3641         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
3642         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
3643         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
3644         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
3645         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
3646         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
3647         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
3648         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
3649         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
3650         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
3651         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
3652         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
3653         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
3654         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
3655         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
3656         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
3657         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
3658         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
3659         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
3660         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
3661         * annotate.c (_initialize_annotate): Add declaration.
3662         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
3663         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
3664         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
3665         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
3666         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
3667         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
3668         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
3669         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
3670         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
3671         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
3672         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
3673         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
3674         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
3675         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
3676         * auto-load.c (_initialize_auto_load): Add declaration.
3677         * auxv.c (_initialize_auxv): Add declaration.
3678         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
3679         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
3680         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
3681         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
3682         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
3683         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
3684         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
3685         * breakpoint.c (_initialize_breakpoint): Add declaration.
3686         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
3687         * btrace.c (_initialize_btrace): Add declaration.
3688         * charset.c (_initialize_charset): Add declaration.
3689         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
3690         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
3691         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
3692         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
3693         * cli/cli-script.c (_initialize_cli_script): Add declaration.
3694         * cli/cli-style.c (_initialize_cli_style): Add declaration.
3695         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
3696         * coffread.c (_initialize_coffread): Add declaration.
3697         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
3698         * compile/compile.c (_initialize_compile): Add declaration.
3699         * complaints.c (_initialize_complaints): Add declaration.
3700         * completer.c (_initialize_completer): Add declaration.
3701         * copying.c (_initialize_copying): Add declaration.
3702         * corefile.c (_initialize_core): Add declaration.
3703         * corelow.c (_initialize_corelow): Add declaration.
3704         * cp-abi.c (_initialize_cp_abi): Add declaration.
3705         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
3706         * cp-support.c (_initialize_cp_support): Add declaration.
3707         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
3708         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
3709         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
3710         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
3711         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
3712         * ctfread.c (_initialize_ctfread): Add declaration.
3713         * d-lang.c (_initialize_d_language): Add declaration.
3714         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
3715         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
3716         * dbxread.c (_initialize_dbxread): Add declaration.
3717         * dcache.c (_initialize_dcache): Add declaration.
3718         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
3719         * disasm.c (_initialize_disasm): Add declaration.
3720         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
3721         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
3722         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
3723         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
3724         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
3725         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
3726         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
3727         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
3728         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
3729         * elfread.c (_initialize_elfread): Add declaration.
3730         * exec.c (_initialize_exec): Add declaration.
3731         * extension.c (_initialize_extension): Add declaration.
3732         * f-lang.c (_initialize_f_language): Add declaration.
3733         * f-valprint.c (_initialize_f_valprint): Add declaration.
3734         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
3735         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
3736         * filesystem.c (_initialize_filesystem): Add declaration.
3737         * findcmd.c (_initialize_mem_search): Add declaration.
3738         * findvar.c (_initialize_findvar): Add declaration.
3739         * fork-child.c (_initialize_fork_child): Add declaration.
3740         * frame-base.c (_initialize_frame_base): Add declaration.
3741         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
3742         * frame.c (_initialize_frame): Add declaration.
3743         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
3744         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
3745         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
3746         * gcore.c (_initialize_gcore): Add declaration.
3747         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
3748         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
3749         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
3750         * gdbarch.c (_initialize_gdbarch): Add declaration.
3751         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
3752         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
3753         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
3754         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
3755         * go-lang.c (_initialize_go_language): Add declaration.
3756         * go32-nat.c (_initialize_go32_nat): Add declaration.
3757         * guile/guile.c (_initialize_guile): Add declaration.
3758         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
3759         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
3760         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
3761         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
3762         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
3763         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
3764         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
3765         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
3766         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
3767         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
3768         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
3769         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
3770         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
3771         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
3772         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
3773         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
3774         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
3775         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
3776         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
3777         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
3778         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
3779         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
3780         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
3781         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
3782         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
3783         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
3784         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
3785         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
3786         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
3787         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
3788         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
3789         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
3790         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
3791         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
3792         * infcall.c (_initialize_infcall): Add declaration.
3793         * infcmd.c (_initialize_infcmd): Add declaration.
3794         * inflow.c (_initialize_inflow): Add declaration.
3795         * infrun.c (_initialize_infrun): Add declaration.
3796         * interps.c (_initialize_interpreter): Add declaration.
3797         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
3798         * jit.c (_initialize_jit): Add declaration.
3799         * language.c (_initialize_language): Add declaration.
3800         * linux-fork.c (_initialize_linux_fork): Add declaration.
3801         * linux-nat.c (_initialize_linux_nat): Add declaration.
3802         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
3803         * linux-thread-db.c (_initialize_thread_db): Add declaration.
3804         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
3805         * m2-lang.c (_initialize_m2_language): Add declaration.
3806         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
3807         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
3808         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
3809         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
3810         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
3811         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
3812         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
3813         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
3814         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
3815         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
3816         * machoread.c (_initialize_machoread): Add declaration.
3817         * macrocmd.c (_initialize_macrocmd): Add declaration.
3818         * macroscope.c (_initialize_macroscope): Add declaration.
3819         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
3820         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
3821         * maint.c (_initialize_maint_cmds): Add declaration.
3822         * mdebugread.c (_initialize_mdebugread): Add declaration.
3823         * memattr.c (_initialize_mem): Add declaration.
3824         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
3825         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
3826         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
3827         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
3828         * mi/mi-main.c (_initialize_mi_main): Add declaration.
3829         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
3830         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
3831         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
3832         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
3833         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
3834         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
3835         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
3836         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
3837         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
3838         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
3839         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
3840         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
3841         * mipsread.c (_initialize_mipsread): Add declaration.
3842         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
3843         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
3844         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
3845         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
3846         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
3847         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
3848         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
3849         * nto-procfs.c (_initialize_procfs): Add declaration.
3850         * objc-lang.c (_initialize_objc_language): Add declaration.
3851         * observable.c (_initialize_observer): Add declaration.
3852         * opencl-lang.c (_initialize_opencl_language): Add declaration.
3853         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
3854         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
3855         * osabi.c (_initialize_gdb_osabi): Add declaration.
3856         * osdata.c (_initialize_osdata): Add declaration.
3857         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
3858         * parse.c (_initialize_parse): Add declaration.
3859         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
3860         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
3861         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
3862         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
3863         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
3864         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
3865         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
3866         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
3867         * printcmd.c (_initialize_printcmd): Add declaration.
3868         * probe.c (_initialize_probe): Add declaration.
3869         * proc-api.c (_initialize_proc_api): Add declaration.
3870         * proc-events.c (_initialize_proc_events): Add declaration.
3871         * proc-service.c (_initialize_proc_service): Add declaration.
3872         * procfs.c (_initialize_procfs): Add declaration.
3873         * producer.c (_initialize_producer): Add declaration.
3874         * psymtab.c (_initialize_psymtab): Add declaration.
3875         * python/python.c (_initialize_python): Add declaration.
3876         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
3877         * record-btrace.c (_initialize_record_btrace): Add declaration.
3878         * record-full.c (_initialize_record_full): Add declaration.
3879         * record.c (_initialize_record): Add declaration.
3880         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
3881         * regcache.c (_initialize_regcache): Add declaration.
3882         * reggroups.c (_initialize_reggroup): Add declaration.
3883         * remote-notif.c (_initialize_notif): Add declaration.
3884         * remote-sim.c (_initialize_remote_sim): Add declaration.
3885         * remote.c (_initialize_remote): Add declaration.
3886         * reverse.c (_initialize_reverse): Add declaration.
3887         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
3888         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
3889         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
3890         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
3891         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
3892         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
3893         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
3894         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
3895         Add declaration.
3896         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
3897         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
3898         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
3899         * rust-exp.y (_initialize_rust_exp): Add declaration.
3900         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
3901         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
3902         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
3903         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
3904         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
3905         * score-tdep.c (_initialize_score_tdep): Add declaration.
3906         * ser-go32.c (_initialize_ser_dos): Add declaration.
3907         * ser-mingw.c (_initialize_ser_windows): Add declaration.
3908         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
3909         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
3910         * ser-uds.c (_initialize_ser_socket): Add declaration.
3911         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
3912         * serial.c (_initialize_serial): Add declaration.
3913         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
3914         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
3915         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
3916         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
3917         * skip.c (_initialize_step_skip): Add declaration.
3918         * sol-thread.c (_initialize_sol_thread): Add declaration.
3919         * solib-aix.c (_initialize_solib_aix): Add declaration.
3920         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
3921         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
3922         * solib-frv.c (_initialize_frv_solib): Add declaration.
3923         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
3924         * solib-target.c (_initialize_solib_target): Add declaration.
3925         * solib.c (_initialize_solib): Add declaration.
3926         * source-cache.c (_initialize_source_cache): Add declaration.
3927         * source.c (_initialize_source): Add declaration.
3928         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
3929         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
3930         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
3931         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
3932         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
3933         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
3934         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
3935         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
3936         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
3937         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
3938         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
3939         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
3940         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
3941         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
3942         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
3943         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
3944         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
3945         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
3946         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
3947         * stabsread.c (_initialize_stabsread): Add declaration.
3948         * stack.c (_initialize_stack): Add declaration.
3949         * stap-probe.c (_initialize_stap_probe): Add declaration.
3950         * std-regs.c (_initialize_frame_reg): Add declaration.
3951         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
3952         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
3953         * symfile.c (_initialize_symfile): Add declaration.
3954         * symmisc.c (_initialize_symmisc): Add declaration.
3955         * symtab.c (_initialize_symtab): Add declaration.
3956         * target.c (_initialize_target): Add declaration.
3957         * target-connection.c (_initialize_target_connection): Add
3958         declaration.
3959         * target-dcache.c (_initialize_target_dcache): Add declaration.
3960         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
3961         * thread.c (_initialize_thread): Add declaration.
3962         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
3963         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
3964         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
3965         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
3966         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
3967         * tracectf.c (_initialize_ctf): Add declaration.
3968         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
3969         * tracefile.c (_initialize_tracefile): Add declaration.
3970         * tracepoint.c (_initialize_tracepoint): Add declaration.
3971         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
3972         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
3973         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
3974         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
3975         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
3976         * tui/tui-win.c (_initialize_tui_win): Add declaration.
3977         * tui/tui.c (_initialize_tui): Add declaration.
3978         * typeprint.c (_initialize_typeprint): Add declaration.
3979         * ui-style.c (_initialize_ui_style): Add declaration.
3980         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
3981         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
3982         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
3983         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
3984         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
3985         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
3986         * unittests/filtered_iterator-selftests.c
3987         (_initialize_filtered_iterator_selftests): Add declaration.
3988         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
3989         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
3990         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
3991         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
3992         * unittests/main-thread-selftests.c
3993         (_initialize_main_thread_selftests): Add declaration.
3994         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
3995         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
3996         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
3997         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
3998         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
3999         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
4000         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
4001         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
4002         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
4003         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
4004         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
4005         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
4006         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
4007         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
4008         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
4009         declaration.
4010         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
4011         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
4012         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
4013         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
4014         * user-regs.c (_initialize_user_regs): Add declaration.
4015         * utils.c (_initialize_utils): Add declaration.
4016         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
4017         * valops.c (_initialize_valops): Add declaration.
4018         * valprint.c (_initialize_valprint): Add declaration.
4019         * value.c (_initialize_values): Add declaration.
4020         * varobj.c (_initialize_varobj): Add declaration.
4021         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
4022         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
4023         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
4024         * windows-nat.c (_initialize_windows_nat): Add declaration.
4025         (_initialize_check_for_gdb_ini): Add declaration.
4026         (_initialize_loadable): Add declaration.
4027         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
4028         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
4029         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
4030         * xcoffread.c (_initialize_xcoffread): Add declaration.
4031         * xml-support.c (_initialize_xml_support): Add declaration.
4032         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
4033         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
4034         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
4035         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
4036
4037 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
4038
4039         * regformats/regdat.sh: Generate declaration for init function.
4040
4041 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
4042
4043         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
4044         up.
4045         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
4046         close_one_inferior>: New methods.
4047         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
4048         pass down target to find_inferior_pid.
4049         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
4050         Pass down target to find_inferior_ptid.
4051         (gdbsim_target::create_inferior): Pass down target to
4052         add_thread_silent.
4053         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
4054         target down to find_inferior_ptid and switch_to_thread.
4055         (gdbsim_target::close): Update to call close_one_inferior.
4056         (struct resume_data): Remove.
4057         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
4058         directly, rather than through a void pointer.
4059         (gdbsim_target::resume): Update to call resume_one_inferior.
4060
4061 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
4062
4063         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
4064
4065 2020-01-12  Pedro Alves  <palves@redhat.com>
4066
4067         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
4068         directly for the current inferior instead of
4069         discard_all_inferiors.
4070         (discard_all_inferiors): Delete.
4071
4072 2020-01-11  Tom Tromey  <tom@tromey.com>
4073
4074         * tui/tui-wingeneral.c (box_win): Check cli_styling.
4075         * tui/tui-winsource.c (tui_source_window_base::refill): Use
4076         deprecated_safe_get_selected_frame.
4077
4078 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4079
4080         * inferior.c (print_inferior): Switch inferior before printing it.
4081
4082 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
4083             Pedro Alves  <palves@redhat.com>
4084
4085         * progspace-and-thread.c (switch_to_program_space_and_thread):
4086         Assert there's an inferior for PSPACE.  Use
4087         switch_to_inferior_no_thread to switch the inferior too.
4088         * progspace.c (program_space::~program_space): Call
4089         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
4090         (program_space::free_all_objfiles): Don't call clear_symtab_users
4091         here.
4092         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
4093
4094 2020-01-10  Pedro Alves  <palves@redhat.com>
4095
4096         * NEWS: Mention multi-target debugging, "info connections", and
4097         "add-inferior -no-connection".
4098
4099 2020-01-10  Pedro Alves  <palves@redhat.com>
4100
4101         * infrun.c: Include "target-connection.h".
4102         (check_multi_target_resumption): New.
4103         (proceed): Call it.
4104         * target-connection.c (make_target_connection_string): Make
4105         extern.
4106         * target-connection.h (make_target_connection_string): Declare.
4107
4108 2020-01-10  Pedro Alves  <palves@redhat.com>
4109
4110         * Makefile.in (COMMON_SFILES): Add target-connection.c.
4111         * inferior.c (uiout_field_connection): New function.
4112         (print_inferior): Add new "connection-id" column.
4113         (add_inferior_command): Show connection number/string of added
4114         inferior.
4115         * process-stratum-target.h
4116         (process_stratum_target::connection_string): New virtual method.
4117         (process_stratum_target::connection_number): New field.
4118         * remote.c (remote_target::connection_string): New override.
4119         * target-connection.c: New file.
4120         * target-connection.h: New file.
4121         * target.c (decref_target): Remove process_stratum targets from
4122         the connection list.
4123         (target_stack::push): Add process_stratum targets to the
4124         connection list.
4125
4126 2020-01-10  Pedro Alves  <palves@redhat.com>
4127
4128         Revert:
4129         2016-04-12  Pedro Alves  <palves@redhat.com>
4130         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
4131         Remove references to name.
4132         * serial.h (struct serial) <name>: Delete.
4133
4134 2020-01-10  Pedro Alves  <palves@redhat.com>
4135
4136         * gdbarch-selftests.c (register_to_value_test): Remove "target
4137         already pushed" check.
4138
4139 2020-01-10  Pedro Alves  <palves@redhat.com>
4140             John Baldwin  <jhb@FreeBSD.org>
4141
4142         * aarch64-linux-nat.c
4143         (aarch64_linux_nat_target::thread_architecture): Adjust.
4144         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
4145         (task_command_1): Likewise.
4146         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
4147         (aix_thread_target::wait, aix_thread_target::fetch_registers)
4148         (aix_thread_target::store_registers)
4149         (aix_thread_target::thread_alive): Adjust.
4150         * amd64-fbsd-tdep.c: Include "inferior.h".
4151         (amd64fbsd_get_thread_local_address): Pass down target.
4152         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
4153         thread's gdbarch instead of target_gdbarch.
4154         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
4155         get_last_target_status.
4156         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
4157         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
4158         inferiors.
4159         (update_inserted_breakpoint_locations): Skip if inferiors with no
4160         execution.
4161         (update_global_location_list): When handling moribund locations,
4162         find representative inferior for location's pspace, and use thread
4163         count of its process_stratum target.
4164         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
4165         * bsd-uthread.c (bsd_uthread_target::wait): Use
4166         as_process_stratum_target and adjust thread_change_ptid and
4167         add_thread calls.
4168         (bsd_uthread_target::update_thread_list): Use
4169         as_process_stratum_target and adjust find_thread_ptid,
4170         thread_change_ptid and add_thread calls.
4171         * btrace.c (maint_btrace_packet_history_cmd): Adjust
4172         find_thread_ptid call.
4173         * corelow.c (add_to_thread_list): Adjust add_thread call.
4174         (core_target_open): Adjust add_thread_silent and thread_count
4175         calls.
4176         (core_target::pid_to_str): Adjust find_inferior_ptid call.
4177         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
4178         * event-top.c (async_disconnect): Pop targets from all inferiors.
4179         * exec.c (add_target_sections): Push exec target on all inferiors
4180         sharing the program space.
4181         (remove_target_sections): Remove the exec target from all
4182         inferiors sharing the program space.
4183         (exec_on_vfork): New.
4184         * exec.h (exec_on_vfork): Declare.
4185         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
4186         Pass it down.
4187         (fbsd_nat_target::update_thread_list): Adjust.
4188         (fbsd_nat_target::resume): Adjust.
4189         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
4190         down.
4191         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
4192         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
4193         get_thread_arch_regcache call.
4194         * fork-child.c (gdb_startup_inferior): Pass target down to
4195         startup_inferior and set_executing.
4196         * gdbthread.h (struct process_stratum_target): Forward declare.
4197         (add_thread, add_thread_silent, add_thread_with_info)
4198         (in_thread_list): Add process_stratum_target parameter.
4199         (find_thread_ptid(inferior*, ptid_t)): New overload.
4200         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
4201         parameter.
4202         (all_threads()): Delete overload.
4203         (all_threads, all_non_exited_threads): Add process_stratum_target
4204         parameter.
4205         (all_threads_safe): Use brace initialization.
4206         (thread_count): Add process_stratum_target parameter.
4207         (set_resumed, set_running, set_stop_requested, set_executing)
4208         (threads_are_executing, finish_thread_state): Add
4209         process_stratum_target parameter.
4210         (switch_to_thread): Use is_current_thread.
4211         * i386-fbsd-tdep.c: Include "inferior.h".
4212         (i386fbsd_get_thread_local_address): Pass down target.
4213         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
4214         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
4215         have_inferiors check.
4216         * inf-ptrace.c (inf_ptrace_target::create_inferior)
4217         (inf_ptrace_target::attach): Adjust.
4218         * infcall.c (run_inferior_call): Adjust.
4219         * infcmd.c (run_command_1): Pass target to
4220         scoped_finish_thread_state.
4221         (proceed_thread_callback): Skip inferiors with no execution.
4222         (continue_command): Rename 'all_threads' local to avoid hiding
4223         'all_threads' function.  Adjust get_last_target_status call.
4224         (prepare_one_step): Adjust set_running call.
4225         (signal_command): Use user_visible_resume_target.  Compare thread
4226         pointers instead of inferior_ptid.
4227         (info_program_command): Adjust to pass down target.
4228         (attach_command): Mark target's 'thread_executing' flag.
4229         (stop_current_target_threads_ns): New, factored out from ...
4230         (interrupt_target_1): ... this.  Switch inferior before making
4231         target calls.
4232         * inferior-iter.h
4233         (struct all_inferiors_iterator, struct all_inferiors_range)
4234         (struct all_inferiors_safe_range)
4235         (struct all_non_exited_inferiors_range): Filter on
4236         process_stratum_target too.  Remove explicit.
4237         * inferior.c (inferior::inferior): Push dummy target on target
4238         stack.
4239         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
4240         Add process_stratum_target parameter, and pass it down.
4241         (have_live_inferiors): Adjust.
4242         (switch_to_inferior_and_push_target): New.
4243         (add_inferior_command, clone_inferior_command): Handle
4244         "-no-connection" parameter.  Use
4245         switch_to_inferior_and_push_target.
4246         (_initialize_inferior): Mention "-no-connection" option in
4247         the help of "add-inferior" and "clone-inferior" commands.
4248         * inferior.h: Include "process-stratum-target.h".
4249         (interrupt_target_1): Use bool.
4250         (struct inferior) <push_target, unpush_target, target_is_pushed,
4251         find_target_beneath, top_target, process_target, target_at,
4252         m_stack>: New.
4253         (discard_all_inferiors): Delete.
4254         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
4255         (all_inferiors, all_non_exited_inferiors): Add
4256         process_stratum_target parameter.
4257         * infrun.c: Include "gdb_select.h" and <unordered_map>.
4258         (target_last_proc_target): New global.
4259         (follow_fork_inferior): Push target on new inferior.  Pass target
4260         to add_thread_silent.  Call exec_on_vfork.  Handle target's
4261         reference count.
4262         (follow_fork): Adjust get_last_target_status call.  Also consider
4263         target.
4264         (follow_exec): Push target on new inferior.
4265         (struct execution_control_state) <target>: New field.
4266         (user_visible_resume_target): New.
4267         (do_target_resume): Call target_async.
4268         (resume_1): Set target's threads_executing flag.  Consider resume
4269         target.
4270         (commit_resume_all_targets): New.
4271         (proceed): Also consider resume target.  Skip threads of inferiors
4272         with no execution.  Commit resumtion in all targets.
4273         (start_remote): Pass current inferior to wait_for_inferior.
4274         (infrun_thread_stop_requested): Consider target as well.  Pass
4275         thread_info pointer to clear_inline_frame_state instead of ptid.
4276         (infrun_thread_thread_exit): Consider target as well.
4277         (random_pending_event_thread): New inferior parameter.  Use it.
4278         (do_target_wait): Rename to ...
4279         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
4280         down.
4281         (threads_are_resumed_pending_p, do_target_wait): New.
4282         (prepare_for_detach): Adjust calls.
4283         (wait_for_inferior): New inferior parameter.  Handle it.  Use
4284         do_target_wait_1 instead of do_target_wait.
4285         (fetch_inferior_event): Adjust.  Switch to representative
4286         inferior.  Pass target down.
4287         (set_last_target_status): Add process_stratum_target parameter.
4288         Save target in global.
4289         (get_last_target_status): Add process_stratum_target parameter and
4290         handle it.
4291         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
4292         (context_switch): Check inferior_ptid == null_ptid before calling
4293         inferior_thread().
4294         (get_inferior_stop_soon): Pass down target.
4295         (wait_one): Rename to ...
4296         (poll_one_curr_target): ... this.
4297         (struct wait_one_event): New.
4298         (wait_one): New.
4299         (stop_all_threads): Adjust.
4300         (handle_no_resumed, handle_inferior_event): Adjust to consider the
4301         event's target.
4302         (switch_back_to_stepped_thread): Also consider target.
4303         (print_stop_event): Update.
4304         (normal_stop): Update.  Also consider the resume target.
4305         * infrun.h (wait_for_inferior): Remove declaration.
4306         (user_visible_resume_target): New declaration.
4307         (get_last_target_status, set_last_target_status): New
4308         process_stratum_target parameter.
4309         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
4310         process_stratum_target parameter, and use it.
4311         (clear_inline_frame_state (thread_info*)): New.
4312         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
4313         process_stratum_target parameter.
4314         (clear_inline_frame_state (thread_info*)): Declare.
4315         * linux-fork.c (delete_checkpoint_command): Pass target down to
4316         find_thread_ptid.
4317         (checkpoint_command): Adjust.
4318         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
4319         instead of just tweaking inferior_ptid.
4320         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
4321         (exit_lwp): Pass target down to find_thread_ptid.
4322         (attach_proc_task_lwp_callback): Pass target down to
4323         add_thread/set_running/set_executing.
4324         (linux_nat_target::attach): Pass target down to
4325         thread_change_ptid.
4326         (get_detach_signal): Pass target down to find_thread_ptid.
4327         Consider last target status's target.
4328         (linux_resume_one_lwp_throw, resume_lwp)
4329         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
4330         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
4331         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
4332         (linux_nat_target::async_wait_fd): New.
4333         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
4334         target down.
4335         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
4336         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
4337         * linux-thread-db.c (struct thread_db_info::process_target): New
4338         field.
4339         (add_thread_db_info): Save target.
4340         (get_thread_db_info): New process_stratum_target parameter.  Also
4341         match target.
4342         (delete_thread_db_info): New process_stratum_target parameter.
4343         Also match target.
4344         (thread_from_lwp): Adjust to pass down target.
4345         (thread_db_notice_clone): Pass down target.
4346         (check_thread_db_callback): Pass down target.
4347         (try_thread_db_load_1): Always push the thread_db target.
4348         (try_thread_db_load, record_thread): Pass target down.
4349         (thread_db_target::detach): Pass target down.  Always unpush the
4350         thread_db target.
4351         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
4352         target down.  Always unpush the thread_db target.
4353         (find_new_threads_callback, thread_db_find_new_threads_2)
4354         (thread_db_target::update_thread_list): Pass target down.
4355         (thread_db_target::pid_to_str): Pass current inferior down.
4356         (thread_db_target::get_thread_local_address): Pass target down.
4357         (thread_db_target::resume, maintenance_check_libthread_db): Pass
4358         target down.
4359         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
4360         * procfs.c (procfs_target::procfs_init_inferior): Declare.
4361         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
4362         (procfs_init_inferior): Rename to ...
4363         (procfs_target::procfs_init_inferior): ... this and adjust.
4364         (procfs_target::create_inferior, procfs_notice_thread)
4365         (procfs_do_thread_registers): Adjust.
4366         * ppc-fbsd-tdep.c: Include "inferior.h".
4367         (ppcfbsd_get_thread_local_address): Pass down target.
4368         * proc-service.c (ps_xfer_memory): Switch current inferior and
4369         program space as well.
4370         (get_ps_regcache): Pass target down.
4371         * process-stratum-target.c
4372         (process_stratum_target::thread_address_space)
4373         (process_stratum_target::thread_architecture): Pass target down.
4374         * process-stratum-target.h
4375         (process_stratum_target::threads_executing): New field.
4376         (as_process_stratum_target): New.
4377         * ravenscar-thread.c
4378         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
4379         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
4380         down.
4381         * record-btrace.c (record_btrace_target::info_record): Adjust.
4382         (record_btrace_target::record_method)
4383         (record_btrace_target::record_is_replaying)
4384         (record_btrace_target::fetch_registers)
4385         (get_thread_current_frame_id, record_btrace_target::resume)
4386         (record_btrace_target::wait, record_btrace_target::stop): Pass
4387         target down.
4388         * record-full.c (record_full_wait_1): Switch to event thread.
4389         Pass target down.
4390         * regcache.c (regcache::regcache)
4391         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
4392         process_stratum_target parameter and handle it.
4393         (current_thread_target): New global.
4394         (get_thread_regcache): Add process_stratum_target parameter and
4395         handle it.  Switch inferior before calling target method.
4396         (get_thread_regcache): Pass target down.
4397         (get_thread_regcache_for_ptid): Pass target down.
4398         (registers_changed_ptid): Add process_stratum_target parameter and
4399         handle it.
4400         (registers_changed_thread, registers_changed): Pass target down.
4401         (test_get_thread_arch_aspace_regcache): New.
4402         (current_regcache_test): Define a couple local test_target_ops
4403         instances and use them for testing.
4404         (readwrite_regcache): Pass process_stratum_target parameter.
4405         (cooked_read_test, cooked_write_test): Pass mock_target down.
4406         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
4407         (get_thread_arch_aspace_regcache): Add process_stratum_target
4408         parameter.
4409         (regcache::target): New method.
4410         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
4411         (regcache::registers_changed_ptid): Add process_stratum_target
4412         parameter.
4413         (regcache::m_target): New field.
4414         (registers_changed_ptid): Add process_stratum_target parameter.
4415         * remote.c (remote_state::supports_vCont_probed): New field.
4416         (remote_target::async_wait_fd): New method.
4417         (remote_unpush_and_throw): Add remote_target parameter.
4418         (get_current_remote_target): Adjust.
4419         (remote_target::remote_add_inferior): Push target.
4420         (remote_target::remote_add_thread)
4421         (remote_target::remote_notice_new_inferior)
4422         (get_remote_thread_info): Pass target down.
4423         (remote_target::update_thread_list): Skip threads of inferiors
4424         bound to other targets.  (remote_target::close): Don't discard
4425         inferiors.  (remote_target::add_current_inferior_and_thread)
4426         (remote_target::process_initial_stop_replies)
4427         (remote_target::start_remote)
4428         (remote_target::remote_serial_quit_handler): Pass down target.
4429         (remote_target::remote_unpush_target): New remote_target
4430         parameter.  Unpush the target from all inferiors.
4431         (remote_target::remote_unpush_and_throw): New remote_target
4432         parameter.  Pass it down.
4433         (remote_target::open_1): Check whether the current inferior has
4434         execution instead of checking whether any inferior is live.  Pass
4435         target down.
4436         (remote_target::remote_detach_1): Pass down target.  Use
4437         remote_unpush_target.
4438         (extended_remote_target::attach): Pass down target.
4439         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
4440         (remote_target::append_resumption): Pass down target.
4441         (remote_target::append_pending_thread_resumptions)
4442         (remote_target::remote_resume_with_hc, remote_target::resume)
4443         (remote_target::commit_resume): Pass down target.
4444         (remote_target::remote_stop_ns): Check supports_vCont_probed.
4445         (remote_target::interrupt_query)
4446         (remote_target::remove_new_fork_children)
4447         (remote_target::check_pending_events_prevent_wildcard_vcont)
4448         (remote_target::remote_parse_stop_reply)
4449         (remote_target::process_stop_reply): Pass down target.
4450         (first_remote_resumed_thread): New remote_target parameter.  Pass
4451         it down.
4452         (remote_target::wait_as): Pass down target.
4453         (unpush_and_perror): New remote_target parameter.  Pass it down.
4454         (remote_target::readchar, remote_target::remote_serial_write)
4455         (remote_target::getpkt_or_notif_sane_1)
4456         (remote_target::kill_new_fork_children, remote_target::kill): Pass
4457         down target.
4458         (remote_target::mourn_inferior): Pass down target.  Use
4459         remote_unpush_target.
4460         (remote_target::core_of_thread)
4461         (remote_target::remote_btrace_maybe_reopen): Pass down target.
4462         (remote_target::pid_to_exec_file)
4463         (remote_target::thread_handle_to_thread_info): Pass down target.
4464         (remote_target::async_wait_fd): New.
4465         * riscv-fbsd-tdep.c: Include "inferior.h".
4466         (riscv_fbsd_get_thread_local_address): Pass down target.
4467         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
4468         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
4469         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
4470         Adjust.
4471         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
4472         * solib-svr4.c (enable_break): Pass down target.
4473         * spu-multiarch.c (parse_spufs_run): Pass down target.
4474         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
4475         * target-delegates.c: Regenerate.
4476         * target.c (g_target_stack): Delete.
4477         (current_top_target): Return the current inferior's top target.
4478         (target_has_execution_1): Refer to the passed-in inferior's top
4479         target.
4480         (target_supports_terminal_ours): Check whether the initial
4481         inferior was already created.
4482         (decref_target): New.
4483         (target_stack::push): Incref/decref the target.
4484         (push_target, push_target, unpush_target): Adjust.
4485         (target_stack::unpush): Defref target.
4486         (target_is_pushed): Return bool.  Adjust to refer to the current
4487         inferior's target stack.
4488         (dispose_inferior): Delete, and inline parts ...
4489         (target_preopen): ... here.  Only dispose of the current inferior.
4490         (target_detach): Hold strong target reference while detaching.
4491         Pass target down.
4492         (target_thread_name): Add assertion.
4493         (target_resume): Pass down target.
4494         (target_ops::beneath, find_target_at): Adjust to refer to the
4495         current inferior's target stack.
4496         (get_dummy_target): New.
4497         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
4498         has a thread running.
4499         (initialize_targets): Rename to ...
4500         (_initialize_target): ... this.
4501         * target.h: Include "gdbsupport/refcounted-object.h".
4502         (struct target_ops): Inherit refcounted_object.
4503         (target_ops::shortname, target_ops::longname): Make const.
4504         (target_ops::async_wait_fd): New method.
4505         (decref_target): Declare.
4506         (struct target_ops_ref_policy): New.
4507         (target_ops_ref): New typedef.
4508         (get_dummy_target): Declare function.
4509         (target_is_pushed): Return bool.
4510         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
4511         (all_matching_threads_iterator::all_matching_threads_iterator):
4512         Handle filter target.
4513         * thread-iter.h (struct all_matching_threads_iterator, struct
4514         all_matching_threads_range, class all_non_exited_threads_range):
4515         Filter by target too.  Remove explicit.
4516         * thread.c (threads_executing): Delete.
4517         (inferior_thread): Pass down current inferior.
4518         (clear_thread_inferior_resources): Pass down thread pointer
4519         instead of ptid_t.
4520         (add_thread_silent, add_thread_with_info, add_thread): Add
4521         process_stratum_target parameter.  Use it for thread and inferior
4522         searches.
4523         (is_current_thread): New.
4524         (thread_info::deletable): Use it.
4525         (find_thread_ptid, thread_count, in_thread_list)
4526         (thread_change_ptid, set_resumed, set_running): New
4527         process_stratum_target parameter.  Pass it down.
4528         (set_executing): New process_stratum_target parameter.  Pass it
4529         down.  Adjust reference to 'threads_executing'.
4530         (threads_are_executing): New process_stratum_target parameter.
4531         Adjust reference to 'threads_executing'.
4532         (set_stop_requested, finish_thread_state): New
4533         process_stratum_target parameter.  Pass it down.
4534         (switch_to_thread): Also match inferior.
4535         (switch_to_thread): New process_stratum_target parameter.  Pass it
4536         down.
4537         (update_threads_executing): Reimplement.
4538         * top.c (quit_force): Pop targets from all inferior.
4539         (gdb_init): Don't call initialize_targets.
4540         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
4541         Declare.
4542         (windows_add_thread, windows_delete_thread): Adjust.
4543         (get_windows_debug_event): Rename to ...
4544         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
4545         * tracefile-tfile.c (tfile_target_open): Pass down target.
4546         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
4547         Forward declare.
4548         (switch_to_thread): Add process_stratum_target parameter.
4549         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
4550         parameter.  Use it.
4551         (mi_on_resume): Pass target down.
4552         * nat/fork-inferior.c (startup_inferior): Add
4553         process_stratum_target parameter.  Pass it down.
4554         * nat/fork-inferior.h (startup_inferior): Add
4555         process_stratum_target parameter.
4556         * python/py-threadevent.c (py_get_event_thread): Pass target down.
4557
4558 2020-01-10  Pedro Alves  <palves@redhat.com>
4559
4560         * remote.c (remote_target::start_remote): Don't set inferior_ptid
4561         directly.  Instead find the first thread in the thread list and
4562         use switch_to_thread.
4563
4564 2020-01-10  Pedro Alves  <palves@redhat.com>
4565
4566         * remote.c (remote_target::remote_add_inferior): Don't bind a
4567         process to the current inferior if the current inferior is already
4568         bound to a process.
4569
4570 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4571             Pedro Alves  <palves@redhat.com>
4572
4573         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
4574         If no process is specified, return null_ptid instead of
4575         inferior_ptid.
4576         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
4577         TARGET_WAITKIND_SIGNALLED with no pid.
4578
4579 2020-01-10  Pedro Alves  <palves@redhat.com>
4580
4581         * remote.c (first_remote_resumed_thread): New.
4582         (remote_target::wait_as): Use it as default event_ptid instead of
4583         inferior_ptid.
4584
4585 2020-01-10  Pedro Alves  <palves@redhat.com>
4586
4587         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
4588
4589 2020-01-10  Pedro Alves  <palves@redhat.com>
4590
4591         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
4592         not -1.
4593
4594 2020-01-10  Pedro Alves  <palves@redhat.com>
4595
4596         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
4597         ptid to get_last_target_status.
4598         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
4599         ptid to get_last_target_status.
4600         * infcmd.c (continue_command): Don't pass a target_waitstatus to
4601         get_last_target_status.
4602         (info_program_command): Don't pass a target_waitstatus to
4603         get_last_target_status.
4604         * infrun.c (init_wait_for_inferior): Use
4605         nullify_last_target_wait_ptid.
4606         (get_last_target_status): Handle nullptr arguments.
4607         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
4608         (print_stop_event): Don't pass a ptid to get_last_target_status.
4609         (normal_stop): Don't pass a ptid to get_last_target_status.
4610         * infrun.h (get_last_target_status, set_last_target_status): Move
4611         comments here and update.
4612         (nullify_last_target_wait_ptid): Declare.
4613         * linux-fork.c (fork_load_infrun_state): Remove local extern
4614         declaration of nullify_last_target_wait_ptid.
4615         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
4616         to get_last_target_status.
4617
4618 2020-01-10  Pedro Alves  <palves@redhat.com>
4619
4620         * gdbthread.h (scoped_restore_current_thread)
4621         <dont_restore, restore, m_dont_restore>: Declare.
4622         * thread.c (thread_alive): Add assertion.  Return bool.
4623         (switch_to_thread_if_alive): New.
4624         (prune_threads): Switch inferior/thread.
4625         (print_thread_info_1): Switch thread before calling target methods.
4626         (scoped_restore_current_thread::restore): New, factored out from
4627         ...
4628         (scoped_restore_current_thread::~scoped_restore_current_thread):
4629         ... this.
4630         (scoped_restore_current_thread::scoped_restore_current_thread):
4631         Add assertion.
4632         (thread_apply_all_command, thread_select): Use
4633         switch_to_thread_if_alive.
4634         * infrun.c (proceed, restart_threads, handle_signal_stop)
4635         (switch_back_to_stepped_thread): Switch current thread before
4636         calling target methods.
4637
4638 2020-01-10  Pedro Alves <palves@redhat.com>
4639
4640         * inferior.c (switch_to_inferior_no_thread): New function,
4641         factored out from ...
4642         (inferior_command): ... here.
4643         * inferior.h (switch_to_inferior_no_thread): Declare.
4644         * mi/mi-main.c (run_one_inferior): Use
4645         switch_to_inferior_no_thread.
4646
4647 2020-01-10  Pedro Alves  <palves@redhat.com>
4648
4649         * infcmd.c (kill_command): Remove dead code.
4650
4651 2020-01-10  Pedro Alves  <palves@redhat.com>
4652
4653         * remote.c (remote_target::mourn_inferior): No longer check
4654         whether the target is running.
4655
4656 2020-01-10  Pedro Alves  <palves@redhat.com>
4657
4658         * corelow.c (core_target::has_execution): Change parameter type to
4659         inferior pointer.
4660         * inferior.c (number_of_live_inferiors): Use
4661         inferior::has_execution instead of target_has_execution_1.
4662         * inferior.h (inferior::has_execution): New.
4663         * linux-thread-db.c (thread_db_target::update_thread_list): Use
4664         inferior::has_execution instead of target_has_execution_1.
4665         * process-stratum-target.c
4666         (process_stratum_target::has_execution): Change parameter type to
4667         inferior pointer.  Check the inferior's PID instead of
4668         inferior_ptid.
4669         * process-stratum-target.h
4670         (process_stratum_target::has_execution): Change parameter type to
4671         inferior pointer.
4672         * record-full.c (record_full_core_target::has_execution): Change
4673         parameter type to inferior pointer.
4674         * target.c (target_has_execution_1): Change parameter type to
4675         inferior pointer.
4676         (target_has_execution_current): Adjust.
4677         * target.h (target_ops::has_execution): Change parameter type to
4678         inferior pointer.
4679         (target_has_execution_1): Change parameter type to inferior
4680         pointer.  Change return type to bool.
4681         * tracefile.h (tracefile_target::has_execution): Change parameter
4682         type to inferior pointer.
4683
4684 2020-01-10  Pedro Alves  <palves@redhat.com>
4685
4686         * exceptions.c (print_flush): Remove current_top_target() check.
4687
4688 2020-01-10  Pedro Alves  <palves@redhat.com>
4689
4690         * remote.c (show_remote_exec_file): Show the current inferior's
4691         exec-file instead of the command variable's value.
4692
4693 2020-01-10  Pedro Alves  <palves@redhat.com>
4694
4695         * record-full.c (record_full_resume_ptid): New global.
4696         (record_full_target::resume): Set it.
4697         (record_full_wait_1): Use record_full_resume_ptid instead of
4698         inferior_ptid.
4699
4700 2020-01-10  Pedro Alves  <palves@redhat.com>
4701
4702         * gdbthread.h (scoped_restore_current_thread)
4703         <dont_restore, restore, m_dont_restore>: Declare.
4704         * thread.c (thread_alive): Add assertion.  Return bool.
4705         (switch_to_thread_if_alive): New.
4706         (prune_threads): Switch inferior/thread.
4707         (print_thread_info_1): Switch thread before calling target methods.
4708         (scoped_restore_current_thread::restore): New, factored out from
4709         ...
4710         (scoped_restore_current_thread::~scoped_restore_current_thread):
4711         ... this.
4712         (scoped_restore_current_thread::scoped_restore_current_thread):
4713         Add assertion.
4714         (thread_apply_all_command, thread_select): Use
4715         switch_to_thread_if_alive.
4716
4717 2020-01-10  George Barrett  <bob@bob131.so>
4718
4719         * stap-probe.c (stap_modify_semaphore): Don't check for null
4720         semaphores.
4721         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
4722         for null semaphores.
4723
4724 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4725
4726         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
4727         all source windows, and maintain horizontal scroll status while
4728         doing so.
4729
4730 2020-01-09  Tom Tromey  <tom@tromey.com>
4731
4732         PR tui/18932:
4733         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
4734         update_source_window, not print_source_lines.
4735
4736 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4737
4738         * tui/tui.c (tui_enable): Register tui hooks after calling
4739         tui_display_main.
4740
4741 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
4742
4743         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
4744
4745 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
4746
4747         * thread.c (print_thread_info_1): Fix indentation.
4748
4749 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
4750
4751         * symtab.c (general_symbol_info::compute_and_set_names): Move the
4752         unique_xmalloc_ptr outside the if to always free the demangled name.
4753
4754 2020-01-08  Tom Tromey  <tromey@adacore.com>
4755
4756         * xcoffread.c (enter_line_range, read_xcoff_symtab)
4757         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
4758         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
4759         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
4760         Remove.
4761         (section_offsets): New typedef.
4762         * symtab.c (fixup_section, get_msymbol_address): Update.
4763         * symmisc.c (dump_msymbols): Update.
4764         * symfile.h (relative_addr_info_to_section_offsets)
4765         (symfile_map_offsets_to_segments): Update.
4766         * symfile.c (build_section_addr_info_from_objfile)
4767         (init_objfile_sect_indices): Update.
4768         (struct place_section_arg): Change type of "offsets".
4769         (place_section): Update.
4770         (relative_addr_info_to_section_offsets): Change type of
4771         "section_offsets".  Remove "num_sections" parameter.
4772         (default_symfile_offsets, syms_from_objfile_1)
4773         (set_objfile_default_section_offset): Update.
4774         (reread_symbols): No need to preserve section offsets by hand.
4775         (symfile_map_offsets_to_segments): Change type of "offsets".
4776         * stap-probe.c (relocate_address): Update.
4777         * stabsread.h (process_one_symbol): Update.
4778         * solib-target.c (struct lm_info_target) <offsets>: Change type.
4779         (solib_target_relocate_section_addresses): Update.
4780         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
4781         Update.
4782         * solib-frv.c (frv_relocate_main_executable): Update.
4783         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
4784         * solib-aix.c (solib_aix_get_section_offsets): Change return
4785         type.
4786         (solib_aix_solib_create_inferior_hook): Update.
4787         * remote.c (remote_target::get_offsets): Update.
4788         * psymtab.c (find_pc_sect_psymtab): Update.
4789         * psympriv.h (struct partial_symbol) <address, text_low,
4790         text_high>: Update.
4791         * objfiles.h (obj_section_offset): Update.
4792         (struct objfile) <section_offsets>: Change type.
4793         <num_sections>: Remove.
4794         (objfile_relocate): Update.
4795         * objfiles.c (entry_point_address_query): Update
4796         (relocate_one_symbol): Change type of "section_offsets".
4797         (objfile_relocate1, objfile_relocate1): Change type of
4798         "new_offsets".
4799         (objfile_rebase1): Update.
4800         * mipsread.c (mipscoff_symfile_read): Update.
4801         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
4802         parameter.
4803         * mdebugread.c (parse_symbol): Change type of "section_offsets".
4804         (parse_external, psymtab_to_symtab_1): Update.
4805         * machoread.c (macho_symfile_offsets): Update.
4806         * ia64-tdep.c (ia64_find_unwind_table): Update.
4807         * hppa-tdep.c (read_unwind_info): Update.
4808         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
4809         * dwarf2read.c (create_addrmap_from_index)
4810         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4811         (process_psymtab_comp_unit_reader, add_partial_symbol)
4812         (add_partial_subprogram, process_full_comp_unit)
4813         (read_file_scope, read_func_scope, read_lexical_block_scope)
4814         (read_call_site_scope, dwarf2_rnglists_process)
4815         (dwarf2_ranges_process, dwarf2_ranges_read)
4816         (dwarf_decode_lines_1, var_decode_location, new_symbol)
4817         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
4818         Update.
4819         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
4820         Update.
4821         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
4822         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
4823         (process_one_symbol): Change type of "section_offsets".
4824         * ctfread.c (get_objfile_text_range): Update.
4825         * coffread.c (coff_symtab_read, enter_linenos)
4826         (process_coff_symbol): Update.
4827         * coff-pe-read.c (add_pe_forwarded_sym): Update.
4828         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
4829
4830 2020-01-08  Tom Tromey  <tromey@adacore.com>
4831
4832         * dwarf2read.c (parse_macro_definition): Use std::string.
4833         (parse_macro_definition): Likewise.
4834
4835 2020-01-08  Tom Tromey  <tromey@adacore.com>
4836
4837         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
4838         (ATTR_ALLOC_CHUNK): Remove.
4839
4840 2020-01-08  Tom Tromey  <tromey@adacore.com>
4841
4842         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
4843
4844 2020-01-08  Tom Tromey  <tromey@adacore.com>
4845
4846         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
4847         (dwarf2_compute_name, open_dwo_file): Likewise.
4848         (process_enumeration_scope): Use std::vector.
4849         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
4850         (partial_die_info::fixup, dwarf2_start_subfile)
4851         (guess_full_die_structure_name, dwarf2_name): Likewise.
4852         (determine_prefix): Update.
4853         (guess_full_die_structure_name): Make return type const.
4854         (partial_die_full_name): Return unique_xmalloc_ptr.
4855         (DW_FIELD_ALLOC_CHUNK): Remove.
4856
4857 2020-01-07  Tom Tromey  <tromey@adacore.com>
4858
4859         PR build/24937:
4860         * stap-probe.c (class stap_static_probe_ops): Add constructor.
4861
4862 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
4863
4864         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
4865
4866 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4867
4868         * stack.c (print_frame_info): Move disassemble_next_line code
4869         inside source_print block.
4870
4871 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
4872
4873         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
4874         gdb/signals.h, as we are now using native signal symbols.
4875
4876 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
4877
4878         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
4879         overflow by an early check of content vs threshold.
4880         * tui/tui-source.c (tui_source_window::line_is_displayed):
4881         Likewise.
4882
4883 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
4884
4885         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
4886
4887 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
4888
4889         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
4890         export table if no section contains it's RVA.
4891
4892 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
4893
4894         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
4895
4896 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
4897
4898         * source.c (print_source_lines_base): Set last_line_listed.
4899
4900 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
4901
4902         * tui/tui-disasm.c: Remove trailing spaces.
4903
4904 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
4905             Pedro Alves  <palves@redhat.com>
4906
4907         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
4908         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
4909         (windows_gdb_signal_to_target): New function, uses the above
4910         enumeration to convert GDB internal signal codes to equivalent
4911         Windows codes.
4912         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
4913         * windows-nat.c: Include "gdb_wait.h".
4914         (get_windows_debug_event): Extract the fatal exception from the
4915         exit status and convert to the equivalent Posix signal number.
4916         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
4917         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
4918         * gdbsupport/gdb_wait.c: New file, implements
4919         windows_status_to_termsig.
4920         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
4921         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
4922
4923 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4924
4925         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
4926         show_layout.
4927
4928 2020-01-05  Luis Machado  <luis.machado@linaro.org>
4929
4930         * aarch64-linux-nat.c
4931         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
4932         and bfd_mach_aarch64.
4933
4934 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4935
4936         * ui-file.c (stdio_file::can_emit_style_escape)
4937         (tee_file::can_emit_style_escape): Ensure style is used also on
4938         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
4939         to gdb_stdout.
4940         * main.c (set_gdb_data_directory): Use file style to output the
4941         warning that the given pathname is not a directory.
4942         * top.c (show_history_filename, gdb_safe_append_history)
4943         (show_gdb_datadir): Use file style.
4944
4945 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
4946
4947         * solib-target.c (struct lm_info_target):
4948         Change offsets to be a unique_xmalloc_ptr.
4949         (solib_target_relocate_section_addresses): Update.
4950
4951 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
4952
4953         * windows-nat.c (windows_clear_solib): Free so_list linked list.
4954
4955 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4956
4957         * MAINTAINERS (Write After Approval): Add myself.
4958
4959 2020-01-02  Luis Machado  <luis.machado@linaro.org>
4960
4961         * proc-service.c (get_ps_regcache): Remove reference to obsolete
4962         Cell BE architecture.
4963         * target.h (struct target_ops) <thread_architecture>: Likewise.
4964
4965 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
4966
4967         * Makefile.in: Use INSTALL_PROGRAM_ENV.
4968
4969 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
4970
4971         * MAINTAINERS (Write After Approval): Add myself.
4972
4973 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4974
4975         * gdbarch.sh: Update copyright year range of generated files.
4976
4977 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4978
4979         Update copyright year range in all GDB files.
4980
4981 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4982
4983         * copyright.py: Convert to Python 3.
4984
4985 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4986
4987         * copyright.py: Adapt after move of gnulib directory from gdb
4988         directory to toplevel directory.
4989
4990 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4991
4992         * copyright.py (main): Exit if run from the wrong directory.
4993
4994 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4995
4996         * top.c (print_gdb_version): Change copyright year to 2020.
4997
4998 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4999
5000         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
5001
5002 For older changes see ChangeLog-2019.
5003 \f
5004 Local Variables:
5005 mode: change-log
5006 left-margin: 8
5007 fill-column: 74
5008 version-control: never
5009 coding: utf-8
5010 End: