gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tom@tromey.com>
   2
   3         * registry.h (DECLARE_REGISTRY): Define the _key class.
   4
   5 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
   6
   7         * NEWS: Merge two 'New commands' sections.
   8
   9 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
  10
  11         * ada-valprint.c (ada_val_print_gnat_array): Remove language
  12         parameter and use Ada language definition instead.
  13         (ada_val_print_ptr): Remove unused language parameter.
  14         (ada_val_print_num): Remove language parameter and use Ada language
  15         definition instead.
  16         (ada_val_print_enum, ada_val_print_flt): Remove unused language
  17         parameter.
  18         (ada_val_print_struct_union, ada_val_print_ref): Remove language
  19         parameter and use Ada language definition instead.
  20         (ada_val_print_1): Update all ada_val_print_xxx calls.
  21         Remove language parameter.
  22         (ada_val_print): Update ada_val_print_1 call.
  23
  24 2019-05-08  Tom Tromey  <tromey@adacore.com>
  25
  26         * remote.c (remote_hw_watchpoint_limit)
  27         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
  28         Now static.
  29
  30 2019-05-08  Tom Tromey  <tromey@adacore.com>
  31
  32         * maint.c (_initialize_maint_cmds): Move initialization code to
  33         remote.c.
  34         (watchdog, show_watchdog): Move to remote.c.
  35         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
  36         "watchdog" static.
  37         (_initialize_remote): Move initialization code from maint.c.
  38         * defs.h (watchdog): Don't declare.
  39
  40 2019-05-08  Tom Tromey  <tromey@adacore.com>
  41
  42         * tui/tui-interp.c: Include main.h.
  43         * interps.c: Include main.h.
  44         * main.h (interpreter_p): Declare.
  45         * defs.h (interpreter_p): Don't declare.
  46
  47 2019-05-08  Tom Tromey  <tromey@adacore.com>
  48
  49         * dwarf2loc.c: Include dwarf2read.h.
  50         * defs.h (read_unsigned_leb128): Don't declare.
  51         * dwarf2read.h (read_unsigned_leb128): Declare.
  52
  53 2019-05-08  Tom Tromey  <tromey@adacore.com>
  54
  55         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
  56         method.
  57
  58 2019-05-08  Tom Tromey  <tromey@adacore.com>
  59
  60         * utils.c (fputs_maybe_filtered): Reset style after paging, even
  61         when no wrap column is set.
  62
  63 2019-05-08  Tom Tromey  <tromey@adacore.com>
  64
  65         * c-lang.c (c_get_string): Handle non-C-style arrays.
  66
  67 2019-05-08  Tom Tromey  <tromey@adacore.com>
  68
  69         * typeprint.c (print_offset_data::update): Print the bit offset,
  70         not the number of bits remaining.
  71
  72 2019-05-08  Tom Tromey  <tromey@adacore.com>
  73
  74         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
  75         padding at end of comment.
  76
  77 2019-05-08  Tom Tromey  <tromey@adacore.com>
  78
  79         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
  80         Compare main types.
  81
  82 2019-05-06  Tom Tromey  <tom@tromey.com>
  83
  84         * common/scoped_mmap.c: Include common-defs.h.
  85         * common/scoped_mmap.h: Don't include config.h.
  86
  87 2019-05-04  Tom Tromey  <tom@tromey.com>
  88
  89         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
  90         (struct aarch64_call_info): Add initializers.
  91         <si>: Now a std::vector.
  92         (pass_on_stack, aarch64_push_dummy_call): Update.
  93
  94 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
  95             Tom Tromey  <tom@tromey.com>
  96
  97         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
  98         (ppc_threads): Now a std::vector.  Now static.
  99         (hwdebug_find_thread_points_by_tid)
 100         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 101         Update.
 102
 103 2019-05-04  Tom Tromey  <tom@tromey.com>
 104
 105         * arc-tdep.c (arc_tdesc_init): Return bool.
 106
 107 2019-05-04  Tom Tromey  <tom@tromey.com>
 108
 109         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 110         Use gdb_assert_not_reached.
 111
 112 2019-05-04  Tom Tromey  <tom@tromey.com>
 113
 114         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 115         "false".
 116
 117 2019-05-04  Tom Tromey  <tom@tromey.com>
 118
 119         * arc-tdep.c (arc_tdesc_init): Use bool.
 120
 121 2019-05-04  Tom Tromey  <tom@tromey.com>
 122
 123         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 124
 125 2019-05-04  Tom Tromey  <tom@tromey.com>
 126
 127         * cli/cli-cmds.c (valid_command_p): Return bool.
 128
 129 2019-05-04  Tom Tromey  <tom@tromey.com>
 130
 131         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 132         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 133
 134 2019-05-04  Raul Tambre  <raul@tambre.ee>
 135
 136         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 137         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 138         operator for comparison.
 139
 140 2019-05-04  Tom Tromey  <tom@tromey.com>
 141
 142         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 143         (lookup_partial_symbol, print_partial_symbols)
 144         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 145         (psymbol_compare): Update.
 146         (add_psymbol_to_bcache): Clear the entire psymbol.
 147         (maintenance_check_psymtabs): Update.
 148         * psympriv.h (struct partial_symbol): Don't derive from
 149         general_symbol_info.
 150         <obj_section, unrelocated_address, address,
 151         set_unrelocated_address>: Update.
 152         <ginfo>: New member.
 153         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 154         (debug_names::write_psymbols): Update.
 155
 156 2019-05-04  Tom de Vries  <tdevries@suse.de>
 157
 158         * contrib/cc-with-tweaks.sh: Support -n arg.
 159
 160 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 161
 162         * corelow.c (core_target::detach): Ensure frame cache and
 163         register caches are cleared.
 164         inferior.c (exit_inferior_1): Likewise.
 165
 166 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 167             Tom Tromey  <tom@tromey.com>
 168
 169         * dictionary.c (collate_pending_symbols_by_language): Remove
 170         "struct" from foreach.
 171         * symtab.c (lookup_global_symbol_from_objfile)
 172         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 173         foreach.
 174         * ser-tcp.c (net_open): Remove "struct" from foreach.
 175         * objfiles.c (objfile_relocate, objfile_rebase)
 176         (objfile_has_symbols): Remove "struct" from foreach.
 177         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 178         from foreach.
 179         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 180         foreach.
 181         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 182         "struct" from foreach.
 183         * ada-lang.c (create_excep_cond_exprs)
 184         (ada_exception_catchpoint_cond_string): Remove "struct" from
 185         foreach.
 186
 187 2019-05-03  Tom Tromey  <tromey@adacore.com>
 188
 189         * ada-exp.y (convert_char_literal): Check suffix of each
 190         enumerator.
 191
 192 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 193
 194         PR ada/21406:
 195         * ada-exp.y (yywrap): Don't define.
 196         * ada-lex.l (%option): Add noyywrap
 197         (yywrap): Remove.
 198
 199 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 200
 201         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 202         _WIN32_WINNT to the XP level, unless already defined to a higher
 203         level.
 204
 205         * unittests/parse-connection-spec-selftests.c:
 206         * ser-tcp.c:
 207         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 208         override.
 209
 210         * symfile.c (find_separate_debug_file): Remove colon from the
 211         drive spec of DOS/Windows file names of the target, so that the
 212         file name produced from DEBUGDIR and the target's directory will
 213         be valid on DOS/Windows systems.
 214
 215 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 216
 217         * rust-lang.c (val_print_struct): Handle printing structures
 218         containing strings.
 219
 220 2019-05-02  Tom Tromey  <tromey@adacore.com>
 221
 222         * valarith.c (_initialize_valarith): Remove.
 223
 224 2019-05-01  Tom Tromey  <tromey@adacore.com>
 225
 226         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 227         bitfields.
 228
 229 2019-05-01  Tom Tromey  <tromey@adacore.com>
 230
 231         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 232         for big-endian copies.
 233
 234 2019-04-30  Ali Tamur  <tamur@google.com>
 235         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 236         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 237         (read_3_bytes): New function.
 238
 239 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 240
 241         * windows-nat.c (main_thread_id): Delete.
 242         (handle_output_debug_string): Replace main_thread_id by
 243         current_event.dwThreadId.
 244         (fake_create_process): Likewise.
 245         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 246         Do not set main_thread_id.
 247         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 248         current_event.dwThreadId.
 249         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 250
 251 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 252
 253         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 254         Use current_event.dwThreadId instead of main_thread_id.
 255
 256 2019-04-30  Tom Tromey  <tromey@adacore.com>
 257
 258         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 259         (create_excep_cond_exprs): Iterate over program spaces.
 260         (ada_exception_catchpoint_cond_string): Examine all minimal
 261         symbols for exception types.
 262
 263 2019-04-30  Tom Tromey  <tromey@adacore.com>
 264
 265         PR c++/24470:
 266         * dwarf2read.c (process_structure_scope): Handle case where type
 267         has template parameters but no symbol was created.
 268
 269 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 270             Chris January  <chris.january@arm.com>
 271
 272         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 273         qualifier.
 274         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 275
 276 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 277
 278         * f-typeprint.c (f_print_type): Update rules for printing
 279         whitespace.
 280         (f_type_print_varspec_suffix): Likewise.
 281
 282 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 283             Chris January  <chris.january@arm.com>
 284
 285         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 286         function arguments.
 287
 288 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 289
 290         * f-lang.c (build_fortran_types): Change name of void type to
 291         lower case.
 292         * f-typeprint.c (f_type_print_base): Print the name of the void
 293         type, rather than a fixed string.
 294         * f-valprint.c (f_decorations): Use lower case void string.
 295
 296 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 297             Chris January  <chris.january@arm.com>
 298
 299         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 300         types for Fortran.
 301
 302 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 303             Chris January  <chris.january@arm.com>
 304             David Lecomber  <david.lecomber@arm.com>
 305
 306         * f-exp.y (BINOP_INTRINSIC): New token.
 307         (exp): New parser rule handling BINOP_INTRINSIC.
 308         (f77_keywords): Add new builtin procedures.
 309         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 310         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 311         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 312         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 313         (print_unop_subexp_f): New function.
 314         (print_binop_subexp_f): New function.
 315         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 316         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 317         (dump_subexp_body_f): Likewise.
 318         (operator_check_f): Likewise.
 319         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 320         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 321
 322 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 323
 324         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 325         UNOP_KIND.
 326         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 327         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 328         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 329         (operator_length_f): New fuction.
 330         (print_subexp_f): New function.
 331         (op_name_f): New function.
 332         (dump_subexp_body_f): New function.
 333         (operator_check_f): New function.
 334         (exp_descriptor_f): Replace standard expression handling functions
 335         with new functions.
 336         * gdb/fortran-operator.def: New file.
 337         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 338         * gdb/std-operator.def: Remove UNOP_KIND.
 339
 340 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 341
 342         * std-operator.def: Remove unbalanced, stray double quote
 343         character.
 344
 345 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 346             Chris January  <chris.january@arm.com>
 347             Daniel Everett  <daniel.everett@arm.com>
 348             Nick Forrington  <nick.forrington@arm.com>
 349             Richard Bunt  <richard.bunt@arm.com>
 350
 351         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 352         of depth when printing anonymous structs or unions.
 353         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 354         Don't print either the top-level value, or the children if the
 355         max-depth is exceeded.
 356         (ppscm_print_children): When printing the key of a map, allow one
 357         extra level of depth.
 358         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 359         print either the top-level value, or the children if the max-depth
 360         is exceeded.
 361         (print_children): When printing the key of a map, allow one extra
 362         level of depth.
 363         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 364         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 365         (user_print_options): Initialise max_depth field.
 366         (val_print_scalar_or_string_type_p): New function.
 367         (val_print): Check to see if the max depth has been reached.
 368         (val_print_check_max_depth): Define new function.
 369         (show_print_max_depth): New function.
 370         (_initialize_valprint): Add 'print max-depth' option.
 371         * valprint.h (struct value_print_options) <max_depth>: New field.
 372         (val_print_check_max_depth): Declare new function.
 373         * NEWS: Document new feature.
 374
 375 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 376
 377         * ada-lang.c (ada_language_defn): Initialise new field.
 378         * c-lang.c (c_is_string_type_p): New function.
 379         (c_language_defn): Initialise new field.
 380         (cplus_language_defn): Initialise new field.
 381         (asm_language_defn): Initialise new field.
 382         (minimal_language_defn): Initialise new field.
 383         * c-lang.h (c_is_string_type_p): Declare new function.
 384         * d-lang.c (d_language_defn): Initialise new field.
 385         * f-lang.c (f_is_string_type_p): New function.
 386         (f_language_defn): Initialise new field.
 387         * go-lang.c (go_is_string_type_p): New function.
 388         (go_language_defn): Initialise new field.
 389         * language.c (default_is_string_type_p): New function.
 390         (unknown_language_defn): Initialise new field.
 391         (auto_language_defn): Initialise new field.
 392         * language.h (struct language_defn) <la_is_string_type_p>: New
 393         member variable.
 394         (default_is_string_type_p): Declare new function.
 395         * m2-lang.c (m2_language_defn): Initialise new field.
 396         * objc-lang.c (objc_language_defn): Initialise new field.
 397         * opencl-lang.c (opencl_language_defn): Initialise new field.
 398         * p-lang.c (pascal_is_string_type_p): New function.
 399         (pascal_language_defn): Initialise new field.
 400         * rust-lang.c (rust_is_string_type_p): New function.
 401         (rust_language_defn): Initialise new field.
 402
 403 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 404
 405         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 406         New field.
 407         * ada-lang.c (ada_language_defn): Initialise new field.
 408         * c-lang.c (c_language_defn): Likewise.
 409         (cplus_language_defn): Likewise.
 410         (asm_language_defn): Likewise.
 411         (minimal_language_defn): Likewise.
 412         * d-lang.c (d_language_defn): Likewise.
 413         * f-lang.c (f_language_defn): Likewise.
 414         * go-lang.c (go_language_defn): Likewise.
 415         * language.c (unknown_language_defn): Likewise.
 416         (auto_language_defn): Likewise.
 417         * m2-lang.c (m2_language_defn): Likewise.
 418         * objc-lang.c (objc_language_defn): Likewise.
 419         * opencl-lang.c (opencl_language_defn): Likewise.
 420         * p-lang.c (pascal_language_defn): Likewise.
 421         * rust-lang.c (rust_language_defn): Likewise.
 422
 423 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 424
 425         * ada-lang.c (ada_is_character_type): Change return type to bool.
 426         (ada_is_string_type): Likewise.
 427         * ada-lang.h (ada_is_character_type): Update declaration
 428         (ada_is_string_type): Likewise.
 429
 430 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 431
 432         Support style in 'frame|thread apply'
 433
 434         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 435         * record.c (record_start, record_stop): Update callers of
 436         execute_command_to_string with false.
 437         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 438         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 439         methods.
 440         (class string_file): New constructor with term_out parameter.
 441         Override methods term_out and can_emit_style_escape.  New member
 442         term_out.
 443         (class stdio_file): Override can_emit_style_escape.
 444         (class tee_file): Override term_out and can_emit_style_escape.
 445         * utils.h (can_emit_style_escape): Remove.
 446         * utils.c (can_emit_style_escape): Likewise.
 447         Update all callers of can_emit_style_escape (SOMESTREAM) to
 448         SOMESTREAM->can_emit_style_escape.
 449         * source-cache.c (source_cache::get_source_lines): Likewise.
 450         * stack.c (frame_apply_command_count): Call execute_command_to_string
 451         passing the term_out characteristic of the current gdb_stdout.
 452         * thread.c (thr_try_catch_cmd): Likewise.
 453         * top.c (execute_command_to_string): pass term_out parameter
 454         to construct the string_file for the command output.
 455         * ui-file.c (term_cli_styling): New function (most code moved
 456         from utils.c can_emit_style_escape).
 457         (string_file::string_file, string_file::can_emit_style_escape,
 458         stdio_file::can_emit_style_escape, tee_file::term_out,
 459         tee_file::can_emit_style_escape): New functions.
 460
 461 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 462
 463         * NEWS: Mention the new set|show may-call-functions.
 464         * infcall.c (may_call_functions_p): New variable.
 465         (show_may_call_functions_p): New function.
 466         (call_function_by_hand_dummy): Throws an error if not
 467         may-call-functions.
 468         (_initialize_infcall): Call add_setshow_boolean_cmd for
 469         may-call-functions.
 470
 471 2019-04-25  Keith Seitz  <keiths@redhat.com>
 472
 473         PR c++/24367
 474         * cp-support.c (inspect_type): Don't attempt substitutions
 475         of symbol with the same name.
 476
 477 2019-04-25  Tom Tromey  <tromey@adacore.com>
 478
 479         PR gdb/24475:
 480         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 481         static.
 482
 483 2019-04-25  Tom Tromey  <tromey@adacore.com>
 484
 485         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 486         rvalue reference.
 487         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 488         (gdb_xml_parser::parse): Use std::move.
 489         * python/python-internal.h (gdbpy_convert_exception): Take a const
 490         reference.
 491         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 492         std::move.
 493         * python/py-utils.c (gdbpy_convert_exception): Take a const
 494         reference.
 495         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 496         Use std::move.
 497         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 498         Use std::move.
 499         * mi/mi-main.c (mi_print_exception): Take a const reference.
 500         * main.c (handle_command_errors): Take a const reference.
 501         * linespec.c (parse_linespec): Use std::move.
 502         * infcall.c (run_inferior_call): Use std::move.
 503         (call_function_by_hand_dummy): Use std::move.
 504         * exec.c (try_open_exec_file): Use std::move.
 505         * exceptions.h (exception_print, exception_fprintf)
 506         (exception_print_same): Update.
 507         * exceptions.c (print_exception, exception_print)
 508         (exception_fprintf, exception_print_same): Change parameters to
 509         const reference.
 510         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 511         * common/new-op.c: Use std::move.
 512         * common/common-exceptions.h (struct gdb_exception): Add move
 513         constructor.
 514         (struct gdb_exception_error, struct gdb_exception_quit, struct
 515         gdb_quit_bad_alloc): Change constructor to move constructor.
 516         (throw_exception): Change parameter to rvalue reference.
 517         * common/common-exceptions.c (throw_exception): Take rvalue
 518         reference.
 519         * cli/cli-interp.c (safe_execute_command): Use std::move.
 520         * breakpoint.c (insert_bp_location, location_to_sals): Use
 521         std::move.
 522
 523 2019-04-25  Tom Tromey  <tromey@adacore.com>
 524
 525         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 526         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 527         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 528         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 529         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 530         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 531         guile/scm-value.c: Use unpack.
 532         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 533         gdbscm_gdb_exception.
 534         (gdbscm_throw_gdb_exception): Likewise.
 535         (struct gdbscm_gdb_exception): New.
 536         (unpack): New function.
 537         (gdbscm_wrap): Use unpack.
 538
 539 2019-04-25  Tom Tromey  <tromey@adacore.com>
 540
 541         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 542         (gdb_rl_callback_handler): Use std::move.
 543         * common/common-exceptions.h (struct gdb_exception): Add move
 544         assignment operator.
 545         (throw_exception_sjlj): Change "exception" to const reference.
 546         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 547         (throw_exception_sjlj): Change "exception" to const reference.
 548
 549 2019-04-25  Tom Tromey  <tromey@adacore.com>
 550
 551         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 552         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 553         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 554         Update.
 555         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 556         Update.
 557         * mi/mi-interp.c (mi_interp::exec): Update.
 558         * linespec.c (parse_linespec): Update.
 559         * infcall.c (run_inferior_call): Update.
 560         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 561         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 562         (gdbscm_lookup_global_symbol): Update.
 563         * guile/scm-param.c (gdbscm_parameter_value): Update.
 564         * guile/scm-frame.c (gdbscm_frame_read_register)
 565         (gdbscm_frame_read_var): Update.
 566         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 567         * exec.c (try_open_exec_file): Update.
 568         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 569         (gdb_rl_callback_handler): Update.
 570         * common/common-exceptions.h (exception_none): Don't declare.
 571         * common/common-exceptions.c (exception_none): Don't define.
 572         (struct catcher) <exception>: Update.
 573         * cli/cli-interp.c (safe_execute_command): Update.
 574         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 575
 576 2019-04-25  Ali Tamur  <tamur@google.com>
 577
 578         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 579         (read_attribute_value): Likewise.
 580         (dwarf2_read_addr_index): Update comment.
 581         (read_str_index): Add DW_FORM_strx.
 582         (dwarf2_string_attr): Likewise.
 583         (dwarf2_const_value_attr): Likewise.
 584         (dump_die_shallow): Likewise.
 585         (dwarf2_fetch_constant_bytes): Likewise.
 586         (skip_form_bytes): Likewise.
 587         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 588
 589 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 590
 591         PR corefiles/11608
 592         PR corefiles/18187
 593         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 594         OFFSET.  Verify if current mapping contains an ELF header.
 595         (linux_find_memory_regions_full): Adjust call to
 596         dump_mapping_p.
 597
 598 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 599             Kang Li <kanglictf@gmail.com>
 600
 601         PR gdb/21600
 602
 603         * dwarf2-frame.c (read_initial_length): Be consistent about using
 604         unsigned representation of length.
 605         (decode_frame_entry_1): Likewise.  Check for wraparound of
 606         end pointer as well as buffer overflow.
 607
 608 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 609
 610         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 611         "vq".
 612
 613 2019-04-24  Tom Tromey  <tromey@adacore.com>
 614
 615         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 616
 617 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 618
 619         * s12z-tdep.c (s12z_unwind_pc): Delete.
 620         (s12z_unwind_sp): Delete.
 621         (s12z_gdbarch_init): Don't register deleted functions with
 622         gdbarch.
 623
 624 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 625
 626         * rl78-tdep.c (rl78_unwind_sp): Delete.
 627         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 628
 629 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 630
 631         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 632         (xstormy16_unwind_pc): Delete.
 633         (xstormy16_dummy_id): Delete.
 634         (xstormy16_gdbarch_init): Don't register deleted functions with
 635         gdbarch.
 636
 637 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 638
 639         * vax-tdep.c (vax_unwind_pc): Delete.
 640         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 641
 642 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 643
 644         * v850-tdep.c (v850_unwind_sp): Delete.
 645         (v850_unwind_pc): Delete.
 646         (v850_dummy_id): Delete.
 647         (v850_gdbarch_init): Don't register deleted functions with
 648         gdbarch.
 649
 650 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 651
 652         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 653         (tilegx_unwind_pc): Delete.
 654         (tilegx_unwind_dummy_id): Delete.
 655         (tilegx_gdbarch_init): Don't register deleted functions with
 656         gdbarch.
 657
 658 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 659
 660         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 661         (tic6x_dummy_id): Delete.
 662         (tic6x_gdbarch_init): Don't register deleted functions with
 663         gdbarch.
 664
 665 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 666
 667         * sparc-tdep.c (sparc_unwind_pc): Delete.
 668         (sparc32_gdbarch_init): Don't register deleted function with
 669         gdbarch.
 670
 671 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 672
 673         * sh-tdep.c (sh_unwind_sp): Delete.
 674         (sh_unwind_pc): Delete.
 675         (sh_dummy_id): Delete.
 676         (sh_gdbarch_init): Don't register deleted functions with
 677         gdbarch.
 678
 679 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 680
 681         * score-tdep.c (score_unwind_sp): Delete.
 682         (score_unwind_pc): Delete.
 683         (score_dummy_id): Delete.
 684         (score_gdbarch_init): Don't register deleted functions with
 685         gdbarch.
 686
 687 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 688
 689         * rx-tdep.c (rx_unwind_pc): Delete.
 690         (rx_unwind_sp): Delete.
 691         (rx_dummy_id): Delete.
 692         (rx_gdbarch_init): Don't register deleted functions with
 693         gdbarch.  Update comment.
 694
 695 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 696
 697         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 698         (rs6000_dummy_id): Delete.
 699         (rs6000_gdbarch_init): Don't register deleted functions with
 700         gdbarch.
 701
 702 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 703
 704         * or1k-tdep.c (or1k_dummy_id): Delete.
 705         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 706
 707 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 708
 709         * nios2-tdep.c (nios2_dummy_id): Delete.
 710         (nios2_unwind_sp): Delete.
 711         (nios2_gdbarch_init): Don't register deleted functions with
 712         gdbarch.
 713
 714 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 715
 716         * nds32-tdep.c (nds32_dummy_id): Delete.
 717         (nds32_unwind_pc): Delete.
 718         (nds32_unwind_sp): Delete.
 719         (nds32_gdbarch_init): Don't register deleted functions with
 720         gdbarch.
 721
 722 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 723
 724         * msp430-tdep.c (msp430_unwind_pc): Delete.
 725         (msp430_unwind_sp): Delete.
 726         (msp430_dummy_id): Delete.
 727         (msp430_gdbarch_init): Don't register deleted functions with
 728         gdbarch.
 729
 730 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 731
 732         * moxie-tdep.c (moxie_unwind_sp): Delete.
 733         (moxie_unwind_pc): Delete.
 734         (moxie_dummy_id): Delete.
 735         (moxie_gdbarch_init): Don't register deleted functions with
 736         gdbarch.
 737
 738 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 739
 740         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 741         (mn10300_unwind_pc): Delete.
 742         (mn10300_unwind_sp): Delete.
 743         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 744         mn10300_unwind_sp.
 745         (mn10300_frame_unwind_init): Don't register deleted functions with
 746         gdbarch.
 747
 748 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 749
 750         * mep-tdep.c (mep_unwind_pc): Delete.
 751         (mep_unwind_sp): Delete.
 752         (mep_dummy_id): Delete.
 753         (mep_gdbarch_init): Don't register deleted functions with
 754         gdbarch.
 755
 756 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 757
 758         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 759         (m68hc11_unwind_sp): Delete.
 760         (m68hc11_gdbarch_init): Don't register deleted functions with
 761         gdbarch.
 762
 763 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 764
 765         * m32r-tdep.c (m32r_unwind_sp): Delete.
 766         (m32r_unwind_pc): Delete.
 767         (m32r_dummy_id): Delete.
 768         (m32r_gdbarch_init): Don't register deleted functions with
 769         gdbarch.
 770
 771 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 772
 773         * m32c-tdep.c (m32c_unwind_pc): Delete.
 774         (m32c_unwind_sp): Delete.
 775         (m32c_dummy_id): Delete.
 776         (m32c_gdbarch_init): Don't register deleted functions with
 777         gdbarch.
 778
 779 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 780
 781         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 782         (lm32_unwind_pc): Delete.
 783         (lm32_dummy_id): Delete.
 784         (lm32_gdbarch_init): Don't register deleted functions with
 785         gdbarch.
 786
 787 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 788
 789         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 790         (iq2000_unwind_pc): Delete.
 791         (iq2000_dummy_id): Delete.
 792         (iq2000_gdbarch_init): Don't register deleted functions with
 793         gdbarch.
 794
 795 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 796
 797         * nds32-tdep.c (nds32_type_align): Delete.
 798         (nds32_push_dummy_call): Use type_align instead.
 799
 800 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 801
 802         * arm-tdep.c (arm_type_align): Only handle vector override case.
 803         (arm_push_dummy_call): Use type_align.
 804         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 805
 806 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 807
 808         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 809         case.
 810         (pass_on_stack): Use type_align.
 811         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 812         function.
 813
 814 2019-04-23  Tom Tromey  <tromey@adacore.com>
 815
 816         * dwarf2read.c (line_header::file_name_at): Remove unused
 817         overload.
 818
 819 2019-04-23  Tom de Vries  <tdevries@suse.de>
 820
 821         PR gdb/24438
 822         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 823         invocation.
 824
 825
 826 2019-03-27  Ali Tamur  <tamur@google.com>
 827
 828         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 829         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 830         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 831         (dwarf_expr_context::get_addr_index): Likewise
 832         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 833         (symbol_needs_eval_context::get_addr_index): Likewise
 834         (disassemble_dwarf_expression): Add DW_OP_addrx
 835         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 836         (read_cutu_die_from_dwo): Update comment
 837         (skip_one_die): Add DW_FORM_addrx
 838         (read_attribute_value): Likewise
 839         (var_decode_location): Add DW_OP_addrx
 840         (dwarf2_const_value_attr): Add DW_FORM_addrx
 841         (dump_die_shallow): Likewise
 842         (dwarf2_fetch_constant_bytes): Likewise
 843         (decode_locdesc): Add DW_OP_addrx
 844         (skip_form_bytes): Add DW_FORM_addrx
 845
 846 2019-04-22  Ali Tamur  <tamur@google.com>
 847
 848         * MAINTAINERS (Write After Approval): Add self.
 849
 850 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 851
 852         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 853         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 854         (open_symbol_file_object): Likewise.
 855         (svr4_default_sos): Add info parameter.
 856         (svr4_read_so_list): Likewise.
 857         (svr4_current_sos_direct): Adjust functions calls to pass down
 858         info.
 859         (svr4_current_sos_1): Add info parameter.
 860         (svr4_current_sos): Call get_svr4_info, pass info down to
 861         svr4_current_sos_1.
 862         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 863         get_svr4_info.
 864         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 865         get_svr4_info.
 866         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 867         to get_svr4_info.
 868         (probes_table_remove_objfile_probes): Likewise.
 869         (register_solib_event_probe): Add info parameter.
 870         (solist_update_incremental): Pass info parameter down to
 871         svr4_read_so_list.
 872         (disable_probes_interface): Add info parameter.
 873         (svr4_handle_solib_event): Pass current_program_space to
 874         get_svr4_info.  Adjust disable_probes_interface cleanup.
 875         (svr4_create_probe_breakpoints): Add info parameter, pass it
 876         down to register_solib_event_probe.
 877         (svr4_create_solib_event_breakpoints): Add info parameter,
 878         pass it down to svr4_create_probe_breakpoints.
 879         (enable_break): Pass info down to
 880         svr4_create_solib_event_breakpoints.
 881         (svr4_solib_create_inferior_hook): Pass current_program_space to
 882         get_svr4_info.
 883         (svr4_clear_solib): Likewise.
 884
 885 2019-04-22  Pedro Alves  <palves@redhat.com>
 886
 887         * solib-svr4.c (svr4_free_objfile_observer): New.
 888         (probe_and_action::objfile): New field.
 889         (probes_table_htab_remove_objfile_probes)
 890         (probes_table_remove_objfile_probes): New functions.
 891         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 892         in the new probe_and_action.  Don't store the probe in 'lookup'.
 893         (svr4_create_probe_breakpoints): Pass objfile to
 894         register_solib_event_probe.
 895         (_initialize_svr4_solib): Register a free_objfile observer.
 896
 897 2019-04-19  Tom Tromey  <tom@tromey.com>
 898
 899         * common/queue.h: Remove.
 900
 901 2019-04-19  Tom Tromey  <tom@tromey.com>
 902
 903         * event-loop.c: Don't include "common/queue.h".
 904
 905 2019-04-19  Tom Tromey  <tom@tromey.com>
 906
 907         * remote.c (remote_target): Use delete.
 908         * remote-notif.h: Include <list>, not "common/queue.h".
 909         (notif_client_p): Remove typedef.
 910         (remote_notif_state): Add constructor, destructor, initializer.
 911         <notif_queue>: Now a std::list.
 912         (remote_notif_state_xfree): Don't declare.
 913         * remote-notif.c (remote_notif_process, handle_notification)
 914         (remote_notif_state_allocate): Update.
 915         (~remote_notif_state): Rename from remote_notif_state_xfree.
 916
 917 2019-04-19  Tom Tromey  <tom@tromey.com>
 918
 919         * symfile.c (reread_symbols): Update.
 920         * objfiles.c (objfile_register_static_link)
 921         (objfile_lookup_static_link): Update
 922         (~objfile) Don't delete static_links.
 923         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 924
 925 2019-04-19  Tom Tromey  <tom@tromey.com>
 926
 927         * type-stack.h (struct type_stack) <insert>: Constify string.
 928         * type-stack.c (type_stack::insert): Constify string.
 929         * gdbtypes.h (lookup_template_type): Update.
 930         (address_space_name_to_int): Update.
 931         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 932         const.
 933         (lookup_template_type): Make name const.
 934         * c-exp.y: Update rules.
 935         (lex_one_token, classify_name, classify_inner_name)
 936         (c_print_token): Update.
 937         * p-exp.y: Update rules.
 938         (yylex): Update.
 939         * f-exp.y: Update rules.
 940         (yylex): Update.
 941         * d-exp.y: Update rules.
 942         (lex_one_token, classify_name, classify_inner_name): Update.
 943         * parse.c (write_dollar_variable, copy_name): Return std::string.
 944         * parser-defs.h (copy_name): Change return type.
 945         * m2-exp.y: Update rules.
 946         (yylex): Update.
 947         * go-exp.y (lex_one_token): Update.
 948         Update rules.
 949         (classify_unsafe_function, classify_packaged_name)
 950         (classify_name, yylex): Update.
 951
 952 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 953
 954         * configure.ac: add --enable-source-highlight switch.
 955         * configure: Regenerate.
 956         * top.c (print_gdb_version): plumb --enable-source-highlight
 957         status to "show configuration".
 958
 959 2019-04-19  Tom Tromey  <tromey@adacore.com>
 960
 961         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 962         Check ADA_TYPE_P.
 963         (empty_record, ada_template_to_fixed_record_type_1)
 964         (template_to_static_fixed_type)
 965         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 966         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 967         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 968         macros.
 969
 970 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 971
 972         PR symtab/24423:
 973         * source.c (print_source_lines_base): Advance "iter" when a
 974         control character is seen.
 975
 976 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 977
 978         * inferior.h (struct infcall_suspend_state_deleter):
 979         Catch exception in destructor to avoid crash.
 980
 981 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 982
 983         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 984         close to the add_com "shell".
 985
 986 2019-04-18  Tom Tromey  <tromey@adacore.com>
 987
 988         * process-stratum-target.h (class process_stratum_target)
 989         <stratum>: Add "final".
 990
 991 2019-04-17  Tom Tromey  <tromey@adacore.com>
 992
 993         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 994         against nullptr before use.
 995
 996 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 997
 998         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 999
1000 2019-04-17  Jim Wilson  <jimw@sifive.com>
1001             Andrew Burgess  <andrew.burgess@embecosm.com>
1002
1003         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1004         code read might fail, assume 4-byte breakpoint in that case.
1005
1006 2019-04-15  Leszek Swirski  <leszeks@google.com>
1007
1008         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1009         rather than a hand-rolled POD check when checking for forced MEMORY
1010         classification.
1011
1012 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1013
1014         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1015         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1016         function.
1017         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1018         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1019         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1020         declaration.
1021
1022 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1023
1024         * aarch64-linux-nat.c
1025         (aarch64_linux_nat_target::thread_architecture): Add override.
1026         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1027         each VQ.
1028
1029 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1030
1031         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1032
1033 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1034
1035         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1036         target types of size 96-bits, add some additional comments, and
1037         check that the builtin type we found was the correct size.
1038
1039 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1040
1041         * utils.c (prompt_for_continue): Don't restore the styling at the
1042         end, as applied_style has the wrong value.  This fixes styling in
1043         long lists of file names that are interrupted by the "Continue?"
1044         prompt.
1045
1046 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1047
1048         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1049         * c-lang.c (c_language_defn): Likewise.
1050         (cplus_language_defn): Likewise.
1051         (asm_language_defn): Likewise.
1052         (minimal_language_defn): Likewise.
1053         * d-lang.c (d_language_defn): Likewise.
1054         * f-lang.c (f_language_defn): Likewise.
1055         * go-lang.c (go_language_defn): Likewise.
1056         * language.c (unknown_language_defn): Likewise.
1057         (auto_language_defn): Likewise.
1058         * language.h (struct language_defn): Remove la_magic field.
1059         (LANG_MAGIC): Delete.
1060         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1061         * objc-lang.c (objc_language_defn): Likewise.
1062         * opencl-lang.c (opencl_language_defn): Likewise.
1063         * p-lang.c (pascal_language_defn): Likewise.
1064         * rust-lang.c (rust_language_defn): Likewise.
1065
1066 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1067
1068         * riscv-tdep.c (riscv_type_align): New function.
1069         (riscv_type_alignment): Delete.
1070         (riscv_arg_location): Use 'type_align'.
1071         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1072
1073 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1074
1075         * gdbtypes.c (type_align): A struct with no non-static fields also
1076         has alignment of 1.
1077
1078 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1079
1080         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1081         component to 0.
1082         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1083         member.
1084         (riscv_struct_info::analyse): New implementation using new
1085         analyse_inner member function.
1086         (riscv_struct_info::field_offset): New member function.
1087         (riscv_struct_info::m_offsets): New member variable.
1088         (riscv_struct_info::analyse_inner): New private member function,
1089         takes the old implementation of riscv_struct_info::analyse but
1090         extended to track field offsets.
1091         (riscv_call_arg_struct): Update the struct folding special cases
1092         to handle cases where empty C++ structs, which are non-zero
1093         length, are found.
1094         (riscv_arg_location): Initialise the length of each location, a
1095         non-zero length now indicates the location is in use.
1096         (riscv_push_dummy_call): Allow for the first location having a
1097         non-zero offset when setting up arguments.
1098         (riscv_return_value): Likewise, but for return values.
1099
1100 2019-04-11  Tom Tromey  <tromey@adacore.com>
1101
1102         * utils.c (internal_vproblem): Make "msg" const.
1103
1104 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1105
1106         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1107         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1108         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1109         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1110
1111 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1112
1113         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1114         function.
1115         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1116         of amd64_collect_native_gregset.
1117         (amd64_linux_nat_target::store_registers): Likewise.
1118
1119 2019-04-10  Tom Tromey  <tom@tromey.com>
1120
1121         * symtab.c (lookup_global_symbol_from_objfile)
1122         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1123         * objfiles.h (class separate_debug_iterator): New.
1124         (class separate_debug_range): New.
1125         (struct objfile) <separate_debug_objfiles>: New method.
1126         (objfile_separate_debug_iterate): Don't declare.
1127         * objfiles.c (separate_debug_iterator::operator++): Rename from
1128         objfile_separate_debug_iterate.
1129         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1130         iterator.
1131         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1132         iterator.
1133
1134 2019-04-10  Tom Tromey  <tom@tromey.com>
1135
1136         * symfile.c (reread_symbols): Remove old comment.
1137         * objfiles.c (free_all_objfiles): Fix a typo.
1138
1139 2019-04-10  Tom Tromey  <tom@tromey.com>
1140
1141         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1142         * minsyms.c (lookup_minimal_symbol): Use foreach.
1143         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1144         (lookup_minimal_symbol_solib_trampoline): Likewise.
1145         * symfile.c (reread_symbols): Use foreach.
1146
1147 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1148             Tom Tromey  <tromey@adacore.com>
1149
1150         PR rust/24414:
1151         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1152         (rust_lex_int_test): Change "value" to be LONGEST.
1153         (rust_lex_tests): Add test for long integer literal.
1154
1155 2019-04-09  Tom Tromey  <tromey@adacore.com>
1156
1157         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1158         to bool.
1159         (extended_remote_target::attach): Update.
1160         (remote_target::remote_notice_new_inferior): Update.
1161         (remote_target::add_current_inferior_and_thread): Update.
1162         * inferior.c (exit_inferior_1): Use "false".
1163         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1164
1165 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1166
1167         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1168         the "start" command.
1169
1170 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1171
1172         * python/py-inferior.c (infpy_thread_from_thread_handle):
1173         Adjust comments to reflect renaming of thread_from_thread_handle
1174         to thread_from_handle.  Adjust keywords.  Fix type error message.
1175         (inferior_object_methods): Add thread_from_handle.  Retain
1176         thread_from_thread_handle, but mark it as deprecated.
1177
1178 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1179
1180         * gdbthread.h (find_thread_by_handle): Revise declaration.
1181         * thread.c (find_thread_by_handle): Likewise.  Adjust
1182         implementation too.
1183         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1184         support for buffer objects as handles.
1185
1186 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1187
1188         * python/py-infthread.c (thpy_thread_handle): New function.
1189         (thread_object_methods): Register thpy_thread_handle.
1190
1191 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1192
1193         * gdbthread.h (thread_to_thread_handle): Declare.
1194         * thread.c (gdbtypes.h): Include.
1195         (thread_to_thread_handle): New function.
1196
1197         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1198         (target_thread_info_to_thread_handle): Declare.
1199         * target.c (target_thread_info_to_thread_handle): New function.
1200         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1201         * target-delegates.c: Regenerate.
1202
1203         * linux-thread-db.c (class thread_db_target): Add method
1204         thread_info_to_thread_handle.
1205         (thread_db_target::thread_info_to_thread_handle): Define.
1206         * remote.c (class remote_target): Add new method
1207         thread_info_to_thread_handle.
1208         (remote_target::thread_info_to_thread_handle): Define.
1209
1210 2019-04-08  Pedro Alves  <palves@redhat.com>
1211
1212         * common/common-exceptions.c (throw_exception): Don't create
1213         named object to throw; throw directly.
1214         (throw_it): Likewise.  Don't initialize gdb_exception::message
1215         here, with new; pass FMT and AP to the ctor instead.
1216         * common/common-exceptions.h: Include <string>.
1217         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1218         const char *, va_list)): New ctor.  Use std::make_shared.
1219         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1220         errors)): Delete.
1221         (gdb_exception_error::gdb_exception_error(enum errors, const char
1222         *, va_list)): New.
1223         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1224         Add assertion.
1225         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1226         errors)): Delete.
1227         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1228         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1229         Add assertion.
1230
1231 2019-04-08  Tom Tromey  <tom@tromey.com>
1232
1233         * valops.c (value_rtti_indirect_type): Replace throw_exception
1234         with throw.
1235         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1236         with throw.
1237         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1238         throw.
1239         * target.c (target_translate_tls_address): Replace throw_exception
1240         with throw.
1241         * stack.c (frame_apply_command_count): Replace throw_exception
1242         with throw.
1243         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1244         throw.
1245         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1246         with throw.
1247         * rs6000-tdep.c (rs6000_frame_cache)
1248         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1249         * remote.c: Replace throw_exception with throw.
1250         * record-full.c (record_full_message, record_full_wait_1)
1251         (record_full_restore): Replace throw_exception with throw.
1252         * record-btrace.c:
1253         (get_thread_current_frame_id, record_btrace_start_replaying)
1254         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1255         (cmd_record_btrace_start): Replace throw_exception with throw.
1256         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1257         throw.
1258         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1259         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1260         * linespec.c:
1261         (find_linespec_symbols): Replace throw_exception with throw.
1262         * infrun.c (displaced_step_prepare, resume): Replace
1263         throw_exception with throw.
1264         * infcmd.c (post_create_inferior): Replace throw_exception with
1265         throw.
1266         * inf-loop.c (inferior_event_handler): Replace throw_exception
1267         with throw.
1268         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1269         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1270         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1271         (get_prev_frame_always, get_frame_pc_if_available)
1272         (get_frame_address_in_block_if_available, get_frame_language):
1273         Replace throw_exception with throw.
1274         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1275         throw_exception with throw.
1276         * eval.c (fetch_subexp_value, evaluate_var_value)
1277         (evaluate_funcall, evaluate_subexp_standard): Replace
1278         throw_exception with throw.
1279         * dwarf2loc.c (call_site_find_chain)
1280         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1281         Replace throw_exception with throw.
1282         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1283         with throw.
1284         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1285         throw.
1286         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1287         * completer.c (complete_line_internal): Replace throw_exception
1288         with throw.
1289         * compile/compile-object-run.c (compile_object_run): Replace
1290         throw_exception with throw.
1291         * cli/cli-script.c (process_next_line): Replace throw_exception
1292         with throw.
1293         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1294         (btrace_enable, btrace_maint_update_pt_packets): Replace
1295         throw_exception with throw.
1296         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1297         throw_exception with throw.
1298         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1299         throw_exception with throw.
1300         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1301         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1302         * aarch64-tdep.c (aarch64_make_prologue_cache)
1303         (aarch64_make_stub_cache): Replace throw_exception with throw.
1304
1305 2019-04-08  Tom Tromey  <tom@tromey.com>
1306
1307         * common/common-exceptions.c (throw_exception): Rename from
1308         throw_exception_cxx.  Remove old copy.  Make argument const.
1309         (throw_it): Create and throw exception objects directly.
1310         * common/common-exceptions.h (throw_exception): Make argument
1311         const.
1312         (struct gdb_exception_error): Add constructor.
1313         (struct gdb_exception_quit): Add constructor.
1314
1315 2019-04-08  Tom Tromey  <tom@tromey.com>
1316
1317         * common/common-exceptions.h (exception_rethrow): Don't declare.
1318         (TRY_SJLJ): Update comment.
1319         (TRY, CATCH, END_CATCH): Remove.
1320         * common/common-exceptions.c (exception_rethrow): Remove.
1321
1322 2019-04-08  Tom Tromey  <tom@tromey.com>
1323
1324         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1325         Remove.
1326         (gdb_exception_error): Rename from
1327         gdb_exception_RETURN_MASK_ERROR.
1328         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1329         (gdb_quit_bad_alloc): Update.
1330         * aarch64-tdep.c: Update.
1331         * ada-lang.c: Update.
1332         * ada-typeprint.c: Update.
1333         * ada-valprint.c: Update.
1334         * amd64-tdep.c: Update.
1335         * arch-utils.c: Update.
1336         * break-catch-throw.c: Update.
1337         * breakpoint.c: Update.
1338         * btrace.c: Update.
1339         * c-varobj.c: Update.
1340         * cli/cli-cmds.c: Update.
1341         * cli/cli-interp.c: Update.
1342         * cli/cli-script.c: Update.
1343         * common/common-exceptions.c: Update.
1344         * common/new-op.c: Update.
1345         * common/selftest.c: Update.
1346         * compile/compile-c-symbols.c: Update.
1347         * compile/compile-cplus-symbols.c: Update.
1348         * compile/compile-object-load.c: Update.
1349         * compile/compile-object-run.c: Update.
1350         * completer.c: Update.
1351         * corelow.c: Update.
1352         * cp-abi.c: Update.
1353         * cp-support.c: Update.
1354         * cp-valprint.c: Update.
1355         * darwin-nat.c: Update.
1356         * disasm-selftests.c: Update.
1357         * dtrace-probe.c: Update.
1358         * dwarf-index-cache.c: Update.
1359         * dwarf-index-write.c: Update.
1360         * dwarf2-frame-tailcall.c: Update.
1361         * dwarf2-frame.c: Update.
1362         * dwarf2loc.c: Update.
1363         * dwarf2read.c: Update.
1364         * eval.c: Update.
1365         * event-loop.c: Update.
1366         * event-top.c: Update.
1367         * exec.c: Update.
1368         * f-valprint.c: Update.
1369         * fbsd-tdep.c: Update.
1370         * frame-unwind.c: Update.
1371         * frame.c: Update.
1372         * gdbtypes.c: Update.
1373         * gnu-v3-abi.c: Update.
1374         * guile/guile-internal.h: Update.
1375         * guile/scm-block.c: Update.
1376         * guile/scm-breakpoint.c: Update.
1377         * guile/scm-cmd.c: Update.
1378         * guile/scm-disasm.c: Update.
1379         * guile/scm-frame.c: Update.
1380         * guile/scm-lazy-string.c: Update.
1381         * guile/scm-math.c: Update.
1382         * guile/scm-param.c: Update.
1383         * guile/scm-ports.c: Update.
1384         * guile/scm-pretty-print.c: Update.
1385         * guile/scm-symbol.c: Update.
1386         * guile/scm-symtab.c: Update.
1387         * guile/scm-type.c: Update.
1388         * guile/scm-value.c: Update.
1389         * i386-linux-tdep.c: Update.
1390         * i386-tdep.c: Update.
1391         * inf-loop.c: Update.
1392         * infcall.c: Update.
1393         * infcmd.c: Update.
1394         * infrun.c: Update.
1395         * jit.c: Update.
1396         * language.c: Update.
1397         * linespec.c: Update.
1398         * linux-fork.c: Update.
1399         * linux-nat.c: Update.
1400         * linux-tdep.c: Update.
1401         * linux-thread-db.c: Update.
1402         * main.c: Update.
1403         * mi/mi-cmd-break.c: Update.
1404         * mi/mi-cmd-stack.c: Update.
1405         * mi/mi-interp.c: Update.
1406         * mi/mi-main.c: Update.
1407         * objc-lang.c: Update.
1408         * p-valprint.c: Update.
1409         * parse.c: Update.
1410         * ppc-linux-tdep.c: Update.
1411         * printcmd.c: Update.
1412         * python/py-arch.c: Update.
1413         * python/py-breakpoint.c: Update.
1414         * python/py-cmd.c: Update.
1415         * python/py-finishbreakpoint.c: Update.
1416         * python/py-frame.c: Update.
1417         * python/py-framefilter.c: Update.
1418         * python/py-gdb-readline.c: Update.
1419         * python/py-inferior.c: Update.
1420         * python/py-infthread.c: Update.
1421         * python/py-lazy-string.c: Update.
1422         * python/py-linetable.c: Update.
1423         * python/py-objfile.c: Update.
1424         * python/py-param.c: Update.
1425         * python/py-prettyprint.c: Update.
1426         * python/py-progspace.c: Update.
1427         * python/py-record-btrace.c: Update.
1428         * python/py-record.c: Update.
1429         * python/py-symbol.c: Update.
1430         * python/py-type.c: Update.
1431         * python/py-unwind.c: Update.
1432         * python/py-utils.c: Update.
1433         * python/py-value.c: Update.
1434         * python/python.c: Update.
1435         * record-btrace.c: Update.
1436         * record-full.c: Update.
1437         * remote-fileio.c: Update.
1438         * remote.c: Update.
1439         * riscv-tdep.c: Update.
1440         * rs6000-aix-tdep.c: Update.
1441         * rs6000-tdep.c: Update.
1442         * rust-exp.y: Update.
1443         * rust-lang.c: Update.
1444         * s390-tdep.c: Update.
1445         * selftest-arch.c: Update.
1446         * solib-dsbt.c: Update.
1447         * solib-frv.c: Update.
1448         * solib-spu.c: Update.
1449         * solib-svr4.c: Update.
1450         * solib.c: Update.
1451         * sparc64-linux-tdep.c: Update.
1452         * stack.c: Update.
1453         * symfile-mem.c: Update.
1454         * symmisc.c: Update.
1455         * target.c: Update.
1456         * thread.c: Update.
1457         * top.c: Update.
1458         * tracefile-tfile.c: Update.
1459         * tui/tui.c: Update.
1460         * typeprint.c: Update.
1461         * unittests/cli-utils-selftests.c: Update.
1462         * unittests/parse-connection-spec-selftests.c: Update.
1463         * valops.c: Update.
1464         * valprint.c: Update.
1465         * value.c: Update.
1466         * varobj.c: Update.
1467         * windows-nat.c: Update.
1468         * x86-linux-nat.c: Update.
1469         * xml-support.c: Update.
1470
1471 2019-04-08  Tom Tromey  <tom@tromey.com>
1472
1473         * xml-support.c: Use C++ exception handling.
1474         * x86-linux-nat.c: Use C++ exception handling.
1475         * windows-nat.c: Use C++ exception handling.
1476         * varobj.c: Use C++ exception handling.
1477         * value.c: Use C++ exception handling.
1478         * valprint.c: Use C++ exception handling.
1479         * valops.c: Use C++ exception handling.
1480         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1481         handling.
1482         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1483         * typeprint.c: Use C++ exception handling.
1484         * tui/tui.c: Use C++ exception handling.
1485         * tracefile-tfile.c: Use C++ exception handling.
1486         * top.c: Use C++ exception handling.
1487         * thread.c: Use C++ exception handling.
1488         * target.c: Use C++ exception handling.
1489         * symmisc.c: Use C++ exception handling.
1490         * symfile-mem.c: Use C++ exception handling.
1491         * stack.c: Use C++ exception handling.
1492         * sparc64-linux-tdep.c: Use C++ exception handling.
1493         * solib.c: Use C++ exception handling.
1494         * solib-svr4.c: Use C++ exception handling.
1495         * solib-spu.c: Use C++ exception handling.
1496         * solib-frv.c: Use C++ exception handling.
1497         * solib-dsbt.c: Use C++ exception handling.
1498         * selftest-arch.c: Use C++ exception handling.
1499         * s390-tdep.c: Use C++ exception handling.
1500         * rust-lang.c: Use C++ exception handling.
1501         * rust-exp.y: Use C++ exception handling.
1502         * rs6000-tdep.c: Use C++ exception handling.
1503         * rs6000-aix-tdep.c: Use C++ exception handling.
1504         * riscv-tdep.c: Use C++ exception handling.
1505         * remote.c: Use C++ exception handling.
1506         * remote-fileio.c: Use C++ exception handling.
1507         * record-full.c: Use C++ exception handling.
1508         * record-btrace.c: Use C++ exception handling.
1509         * python/python.c: Use C++ exception handling.
1510         * python/py-value.c: Use C++ exception handling.
1511         * python/py-utils.c: Use C++ exception handling.
1512         * python/py-unwind.c: Use C++ exception handling.
1513         * python/py-type.c: Use C++ exception handling.
1514         * python/py-symbol.c: Use C++ exception handling.
1515         * python/py-record.c: Use C++ exception handling.
1516         * python/py-record-btrace.c: Use C++ exception handling.
1517         * python/py-progspace.c: Use C++ exception handling.
1518         * python/py-prettyprint.c: Use C++ exception handling.
1519         * python/py-param.c: Use C++ exception handling.
1520         * python/py-objfile.c: Use C++ exception handling.
1521         * python/py-linetable.c: Use C++ exception handling.
1522         * python/py-lazy-string.c: Use C++ exception handling.
1523         * python/py-infthread.c: Use C++ exception handling.
1524         * python/py-inferior.c: Use C++ exception handling.
1525         * python/py-gdb-readline.c: Use C++ exception handling.
1526         * python/py-framefilter.c: Use C++ exception handling.
1527         * python/py-frame.c: Use C++ exception handling.
1528         * python/py-finishbreakpoint.c: Use C++ exception handling.
1529         * python/py-cmd.c: Use C++ exception handling.
1530         * python/py-breakpoint.c: Use C++ exception handling.
1531         * python/py-arch.c: Use C++ exception handling.
1532         * printcmd.c: Use C++ exception handling.
1533         * ppc-linux-tdep.c: Use C++ exception handling.
1534         * parse.c: Use C++ exception handling.
1535         * p-valprint.c: Use C++ exception handling.
1536         * objc-lang.c: Use C++ exception handling.
1537         * mi/mi-main.c: Use C++ exception handling.
1538         * mi/mi-interp.c: Use C++ exception handling.
1539         * mi/mi-cmd-stack.c: Use C++ exception handling.
1540         * mi/mi-cmd-break.c: Use C++ exception handling.
1541         * main.c: Use C++ exception handling.
1542         * linux-thread-db.c: Use C++ exception handling.
1543         * linux-tdep.c: Use C++ exception handling.
1544         * linux-nat.c: Use C++ exception handling.
1545         * linux-fork.c: Use C++ exception handling.
1546         * linespec.c: Use C++ exception handling.
1547         * language.c: Use C++ exception handling.
1548         * jit.c: Use C++ exception handling.
1549         * infrun.c: Use C++ exception handling.
1550         * infcmd.c: Use C++ exception handling.
1551         * infcall.c: Use C++ exception handling.
1552         * inf-loop.c: Use C++ exception handling.
1553         * i386-tdep.c: Use C++ exception handling.
1554         * i386-linux-tdep.c: Use C++ exception handling.
1555         * guile/scm-value.c: Use C++ exception handling.
1556         * guile/scm-type.c: Use C++ exception handling.
1557         * guile/scm-symtab.c: Use C++ exception handling.
1558         * guile/scm-symbol.c: Use C++ exception handling.
1559         * guile/scm-pretty-print.c: Use C++ exception handling.
1560         * guile/scm-ports.c: Use C++ exception handling.
1561         * guile/scm-param.c: Use C++ exception handling.
1562         * guile/scm-math.c: Use C++ exception handling.
1563         * guile/scm-lazy-string.c: Use C++ exception handling.
1564         * guile/scm-frame.c: Use C++ exception handling.
1565         * guile/scm-disasm.c: Use C++ exception handling.
1566         * guile/scm-cmd.c: Use C++ exception handling.
1567         * guile/scm-breakpoint.c: Use C++ exception handling.
1568         * guile/scm-block.c: Use C++ exception handling.
1569         * guile/guile-internal.h: Use C++ exception handling.
1570         * gnu-v3-abi.c: Use C++ exception handling.
1571         * gdbtypes.c: Use C++ exception handling.
1572         * frame.c: Use C++ exception handling.
1573         * frame-unwind.c: Use C++ exception handling.
1574         * fbsd-tdep.c: Use C++ exception handling.
1575         * f-valprint.c: Use C++ exception handling.
1576         * exec.c: Use C++ exception handling.
1577         * event-top.c: Use C++ exception handling.
1578         * event-loop.c: Use C++ exception handling.
1579         * eval.c: Use C++ exception handling.
1580         * dwarf2read.c: Use C++ exception handling.
1581         * dwarf2loc.c: Use C++ exception handling.
1582         * dwarf2-frame.c: Use C++ exception handling.
1583         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1584         * dwarf-index-write.c: Use C++ exception handling.
1585         * dwarf-index-cache.c: Use C++ exception handling.
1586         * dtrace-probe.c: Use C++ exception handling.
1587         * disasm-selftests.c: Use C++ exception handling.
1588         * darwin-nat.c: Use C++ exception handling.
1589         * cp-valprint.c: Use C++ exception handling.
1590         * cp-support.c: Use C++ exception handling.
1591         * cp-abi.c: Use C++ exception handling.
1592         * corelow.c: Use C++ exception handling.
1593         * completer.c: Use C++ exception handling.
1594         * compile/compile-object-run.c: Use C++ exception handling.
1595         * compile/compile-object-load.c: Use C++ exception handling.
1596         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1597         * compile/compile-c-symbols.c: Use C++ exception handling.
1598         * common/selftest.c: Use C++ exception handling.
1599         * common/new-op.c: Use C++ exception handling.
1600         * cli/cli-script.c: Use C++ exception handling.
1601         * cli/cli-interp.c: Use C++ exception handling.
1602         * cli/cli-cmds.c: Use C++ exception handling.
1603         * c-varobj.c: Use C++ exception handling.
1604         * btrace.c: Use C++ exception handling.
1605         * breakpoint.c: Use C++ exception handling.
1606         * break-catch-throw.c: Use C++ exception handling.
1607         * arch-utils.c: Use C++ exception handling.
1608         * amd64-tdep.c: Use C++ exception handling.
1609         * ada-valprint.c: Use C++ exception handling.
1610         * ada-typeprint.c: Use C++ exception handling.
1611         * ada-lang.c: Use C++ exception handling.
1612         * aarch64-tdep.c: Use C++ exception handling.
1613
1614 2019-04-08  Tom Tromey  <tom@tromey.com>
1615
1616         * xml-support.c (gdb_xml_parser::parse): Update.
1617         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1618         * value.c (show_convenience): Update.
1619         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1620         (test_parse_flags_qcs): Update.
1621         * thread.c (thr_try_catch_cmd): Update.
1622         * target.c (target_translate_tls_address): Update.
1623         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1624         (info_frame_command_core, frame_apply_command_count): Update.
1625         * rust-exp.y (rust_lex_exception_test): Update.
1626         * riscv-tdep.c (riscv_print_one_register_info): Update.
1627         * remote.c (remote_target::enable_btrace): Update.
1628         * record-btrace.c (record_btrace_enable_warn): Update.
1629         * python/py-utils.c (gdbpy_convert_exception): Update.
1630         * printcmd.c (do_one_display, print_variable_and_value): Update.
1631         * mi/mi-main.c (mi_print_exception): Update.
1632         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1633         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1634         * linux-nat.c (linux_nat_target::attach): Update.
1635         * linux-fork.c (class scoped_switch_fork_info): Update.
1636         * infrun.c (displaced_step_prepare): Update.
1637         * infcall.c (call_function_by_hand_dummy): Update.
1638         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1639         * gnu-v3-abi.c (print_one_vtable): Update.
1640         * frame.c (get_prev_frame_always): Update.
1641         * f-valprint.c (info_common_command_for_block): Update.
1642         * exec.c (try_open_exec_file): Update.
1643         * exceptions.c (print_exception, exception_print)
1644         (exception_fprintf, exception_print_same): Update.
1645         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1646         * dwarf-index-cache.c (index_cache::store)
1647         (index_cache::lookup_gdb_index): Update.
1648         * darwin-nat.c (maybe_cache_shell): Update.
1649         * cp-valprint.c (cp_print_value_fields): Update.
1650         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1651         (gcc_cplus_symbol_address): Update.
1652         * compile/compile-c-symbols.c (gcc_convert_symbol)
1653         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1654         * common/selftest.c: Update.
1655         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1656         a std::string.
1657         (exception_try_scope_entry, exception_try_scope_exit): Don't
1658         declare.
1659         (struct exception_try_scope): Remove.
1660         (TRY): Don't use exception_try_scope.
1661         (struct gdb_exception): Add constructor, operator=.
1662         <what>: New method.
1663         (struct gdb_exception_RETURN_MASK_ALL)
1664         (struct gdb_exception_RETURN_MASK_ERROR)
1665         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1666         (struct gdb_quit_bad_alloc): Update.
1667         * common/common-exceptions.c (exception_none): Change
1668         initializer.
1669         (struct catcher) <state, exception>: Initialize inline.
1670         <prev>: Remove member.
1671         (current_catcher): Remove.
1672         (catchers): New global.
1673         (exceptions_state_mc_init): Simplify.
1674         (catcher_pop): Remove.
1675         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1676         (try_scope_depth, exception_try_scope_entry)
1677         (exception_try_scope_exit): Remove.
1678         (throw_exception_sjlj): Update.
1679         (exception_messages, exception_messages_size): Remove.
1680         (throw_it): Simplify.
1681         (gdb_exception_sliced_copy): Remove.
1682         (throw_exception_cxx): Update.
1683         * cli/cli-script.c (script_from_file): Update.
1684         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1685         Update.
1686         * ada-valprint.c (ada_val_print): Update.
1687         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1688         (create_excep_cond_exprs): Update.
1689
1690 2019-04-08  Tom Tromey  <tom@tromey.com>
1691
1692         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1693         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1694         (TRY, CATCH, END_CATCH): Remove some definitions.
1695         * common/common-exceptions.c: Don't use GDB_XCPT.
1696         (catcher_list_size): Remove.
1697         (throw_exception, throw_it): Simplify.
1698
1699 2019-04-05  Tom Tromey  <tom@tromey.com>
1700
1701         Revert the header-sorting patch.
1702         * ft32-tdep.c: Revert.
1703         * frv-tdep.c: Revert.
1704         * frv-linux-tdep.c: Revert.
1705         * frame.c: Revert.
1706         * frame-unwind.c: Revert.
1707         * frame-base.c: Revert.
1708         * fork-child.c: Revert.
1709         * findvar.c: Revert.
1710         * findcmd.c: Revert.
1711         * filesystem.c: Revert.
1712         * filename-seen-cache.h: Revert.
1713         * filename-seen-cache.c: Revert.
1714         * fbsd-tdep.c: Revert.
1715         * fbsd-nat.h: Revert.
1716         * fbsd-nat.c: Revert.
1717         * f-valprint.c: Revert.
1718         * f-typeprint.c: Revert.
1719         * f-lang.c: Revert.
1720         * extension.h: Revert.
1721         * extension.c: Revert.
1722         * extension-priv.h: Revert.
1723         * expprint.c: Revert.
1724         * exec.h: Revert.
1725         * exec.c: Revert.
1726         * exceptions.c: Revert.
1727         * event-top.c: Revert.
1728         * event-loop.c: Revert.
1729         * eval.c: Revert.
1730         * elfread.c: Revert.
1731         * dwarf2read.h: Revert.
1732         * dwarf2read.c: Revert.
1733         * dwarf2loc.c: Revert.
1734         * dwarf2expr.h: Revert.
1735         * dwarf2expr.c: Revert.
1736         * dwarf2-frame.c: Revert.
1737         * dwarf2-frame-tailcall.c: Revert.
1738         * dwarf-index-write.h: Revert.
1739         * dwarf-index-write.c: Revert.
1740         * dwarf-index-common.c: Revert.
1741         * dwarf-index-cache.h: Revert.
1742         * dwarf-index-cache.c: Revert.
1743         * dummy-frame.c: Revert.
1744         * dtrace-probe.c: Revert.
1745         * disasm.h: Revert.
1746         * disasm.c: Revert.
1747         * disasm-selftests.c: Revert.
1748         * dictionary.c: Revert.
1749         * dicos-tdep.c: Revert.
1750         * demangle.c: Revert.
1751         * dcache.h: Revert.
1752         * dcache.c: Revert.
1753         * darwin-nat.h: Revert.
1754         * darwin-nat.c: Revert.
1755         * darwin-nat-info.c: Revert.
1756         * d-valprint.c: Revert.
1757         * d-namespace.c: Revert.
1758         * d-lang.c: Revert.
1759         * ctf.c: Revert.
1760         * csky-tdep.c: Revert.
1761         * csky-linux-tdep.c: Revert.
1762         * cris-tdep.c: Revert.
1763         * cris-linux-tdep.c: Revert.
1764         * cp-valprint.c: Revert.
1765         * cp-support.c: Revert.
1766         * cp-namespace.c: Revert.
1767         * cp-abi.c: Revert.
1768         * corelow.c: Revert.
1769         * corefile.c: Revert.
1770         * continuations.c: Revert.
1771         * completer.h: Revert.
1772         * completer.c: Revert.
1773         * complaints.c: Revert.
1774         * coffread.c: Revert.
1775         * coff-pe-read.c: Revert.
1776         * cli-out.h: Revert.
1777         * cli-out.c: Revert.
1778         * charset.c: Revert.
1779         * c-varobj.c: Revert.
1780         * c-valprint.c: Revert.
1781         * c-typeprint.c: Revert.
1782         * c-lang.c: Revert.
1783         * buildsym.c: Revert.
1784         * buildsym-legacy.c: Revert.
1785         * build-id.h: Revert.
1786         * build-id.c: Revert.
1787         * btrace.c: Revert.
1788         * bsd-uthread.c: Revert.
1789         * breakpoint.h: Revert.
1790         * breakpoint.c: Revert.
1791         * break-catch-throw.c: Revert.
1792         * break-catch-syscall.c: Revert.
1793         * break-catch-sig.c: Revert.
1794         * blockframe.c: Revert.
1795         * block.c: Revert.
1796         * bfin-tdep.c: Revert.
1797         * bfin-linux-tdep.c: Revert.
1798         * bfd-target.c: Revert.
1799         * bcache.c: Revert.
1800         * ax-general.c: Revert.
1801         * ax-gdb.h: Revert.
1802         * ax-gdb.c: Revert.
1803         * avr-tdep.c: Revert.
1804         * auxv.c: Revert.
1805         * auto-load.c: Revert.
1806         * arm-wince-tdep.c: Revert.
1807         * arm-tdep.c: Revert.
1808         * arm-symbian-tdep.c: Revert.
1809         * arm-pikeos-tdep.c: Revert.
1810         * arm-obsd-tdep.c: Revert.
1811         * arm-nbsd-tdep.c: Revert.
1812         * arm-nbsd-nat.c: Revert.
1813         * arm-linux-tdep.c: Revert.
1814         * arm-linux-nat.c: Revert.
1815         * arm-fbsd-tdep.c: Revert.
1816         * arm-fbsd-nat.c: Revert.
1817         * arm-bsd-tdep.c: Revert.
1818         * arch-utils.c: Revert.
1819         * arc-tdep.c: Revert.
1820         * arc-newlib-tdep.c: Revert.
1821         * annotate.h: Revert.
1822         * annotate.c: Revert.
1823         * amd64-windows-tdep.c: Revert.
1824         * amd64-windows-nat.c: Revert.
1825         * amd64-tdep.c: Revert.
1826         * amd64-sol2-tdep.c: Revert.
1827         * amd64-obsd-tdep.c: Revert.
1828         * amd64-obsd-nat.c: Revert.
1829         * amd64-nbsd-tdep.c: Revert.
1830         * amd64-nbsd-nat.c: Revert.
1831         * amd64-nat.c: Revert.
1832         * amd64-linux-tdep.c: Revert.
1833         * amd64-linux-nat.c: Revert.
1834         * amd64-fbsd-tdep.c: Revert.
1835         * amd64-fbsd-nat.c: Revert.
1836         * amd64-dicos-tdep.c: Revert.
1837         * amd64-darwin-tdep.c: Revert.
1838         * amd64-bsd-nat.c: Revert.
1839         * alpha-tdep.c: Revert.
1840         * alpha-obsd-tdep.c: Revert.
1841         * alpha-nbsd-tdep.c: Revert.
1842         * alpha-mdebug-tdep.c: Revert.
1843         * alpha-linux-tdep.c: Revert.
1844         * alpha-linux-nat.c: Revert.
1845         * alpha-bsd-tdep.c: Revert.
1846         * alpha-bsd-nat.c: Revert.
1847         * aix-thread.c: Revert.
1848         * agent.c: Revert.
1849         * addrmap.c: Revert.
1850         * ada-varobj.c: Revert.
1851         * ada-valprint.c: Revert.
1852         * ada-typeprint.c: Revert.
1853         * ada-tasks.c: Revert.
1854         * ada-lang.c: Revert.
1855         * aarch64-tdep.c: Revert.
1856         * aarch64-ravenscar-thread.c: Revert.
1857         * aarch64-newlib-tdep.c: Revert.
1858         * aarch64-linux-tdep.c: Revert.
1859         * aarch64-linux-nat.c: Revert.
1860         * aarch64-fbsd-tdep.c: Revert.
1861         * aarch64-fbsd-nat.c: Revert.
1862         * aarch32-linux-nat.c: Revert.
1863
1864 2019-04-05  Tom Tromey  <tom@tromey.com>
1865
1866         * ft32-tdep.c: Sort headers.
1867         * frv-tdep.c: Sort headers.
1868         * frv-linux-tdep.c: Sort headers.
1869         * frame.c: Sort headers.
1870         * frame-unwind.c: Sort headers.
1871         * frame-base.c: Sort headers.
1872         * fork-child.c: Sort headers.
1873         * findvar.c: Sort headers.
1874         * findcmd.c: Sort headers.
1875         * filesystem.c: Sort headers.
1876         * filename-seen-cache.h: Sort headers.
1877         * filename-seen-cache.c: Sort headers.
1878         * fbsd-tdep.c: Sort headers.
1879         * fbsd-nat.h: Sort headers.
1880         * fbsd-nat.c: Sort headers.
1881         * f-valprint.c: Sort headers.
1882         * f-typeprint.c: Sort headers.
1883         * f-lang.c: Sort headers.
1884         * extension.h: Sort headers.
1885         * extension.c: Sort headers.
1886         * extension-priv.h: Sort headers.
1887         * expprint.c: Sort headers.
1888         * exec.h: Sort headers.
1889         * exec.c: Sort headers.
1890         * exceptions.c: Sort headers.
1891         * event-top.c: Sort headers.
1892         * event-loop.c: Sort headers.
1893         * eval.c: Sort headers.
1894         * elfread.c: Sort headers.
1895         * dwarf2read.h: Sort headers.
1896         * dwarf2read.c: Sort headers.
1897         * dwarf2loc.c: Sort headers.
1898         * dwarf2expr.h: Sort headers.
1899         * dwarf2expr.c: Sort headers.
1900         * dwarf2-frame.c: Sort headers.
1901         * dwarf2-frame-tailcall.c: Sort headers.
1902         * dwarf-index-write.h: Sort headers.
1903         * dwarf-index-write.c: Sort headers.
1904         * dwarf-index-common.c: Sort headers.
1905         * dwarf-index-cache.h: Sort headers.
1906         * dwarf-index-cache.c: Sort headers.
1907         * dummy-frame.c: Sort headers.
1908         * dtrace-probe.c: Sort headers.
1909         * disasm.h: Sort headers.
1910         * disasm.c: Sort headers.
1911         * disasm-selftests.c: Sort headers.
1912         * dictionary.c: Sort headers.
1913         * dicos-tdep.c: Sort headers.
1914         * demangle.c: Sort headers.
1915         * dcache.h: Sort headers.
1916         * dcache.c: Sort headers.
1917         * darwin-nat.h: Sort headers.
1918         * darwin-nat.c: Sort headers.
1919         * darwin-nat-info.c: Sort headers.
1920         * d-valprint.c: Sort headers.
1921         * d-namespace.c: Sort headers.
1922         * d-lang.c: Sort headers.
1923         * ctf.c: Sort headers.
1924         * csky-tdep.c: Sort headers.
1925         * csky-linux-tdep.c: Sort headers.
1926         * cris-tdep.c: Sort headers.
1927         * cris-linux-tdep.c: Sort headers.
1928         * cp-valprint.c: Sort headers.
1929         * cp-support.c: Sort headers.
1930         * cp-namespace.c: Sort headers.
1931         * cp-abi.c: Sort headers.
1932         * corelow.c: Sort headers.
1933         * corefile.c: Sort headers.
1934         * continuations.c: Sort headers.
1935         * completer.h: Sort headers.
1936         * completer.c: Sort headers.
1937         * complaints.c: Sort headers.
1938         * coffread.c: Sort headers.
1939         * coff-pe-read.c: Sort headers.
1940         * cli-out.h: Sort headers.
1941         * cli-out.c: Sort headers.
1942         * charset.c: Sort headers.
1943         * c-varobj.c: Sort headers.
1944         * c-valprint.c: Sort headers.
1945         * c-typeprint.c: Sort headers.
1946         * c-lang.c: Sort headers.
1947         * buildsym.c: Sort headers.
1948         * buildsym-legacy.c: Sort headers.
1949         * build-id.h: Sort headers.
1950         * build-id.c: Sort headers.
1951         * btrace.c: Sort headers.
1952         * bsd-uthread.c: Sort headers.
1953         * breakpoint.h: Sort headers.
1954         * breakpoint.c: Sort headers.
1955         * break-catch-throw.c: Sort headers.
1956         * break-catch-syscall.c: Sort headers.
1957         * break-catch-sig.c: Sort headers.
1958         * blockframe.c: Sort headers.
1959         * block.c: Sort headers.
1960         * bfin-tdep.c: Sort headers.
1961         * bfin-linux-tdep.c: Sort headers.
1962         * bfd-target.c: Sort headers.
1963         * bcache.c: Sort headers.
1964         * ax-general.c: Sort headers.
1965         * ax-gdb.h: Sort headers.
1966         * ax-gdb.c: Sort headers.
1967         * avr-tdep.c: Sort headers.
1968         * auxv.c: Sort headers.
1969         * auto-load.c: Sort headers.
1970         * arm-wince-tdep.c: Sort headers.
1971         * arm-tdep.c: Sort headers.
1972         * arm-symbian-tdep.c: Sort headers.
1973         * arm-pikeos-tdep.c: Sort headers.
1974         * arm-obsd-tdep.c: Sort headers.
1975         * arm-nbsd-tdep.c: Sort headers.
1976         * arm-nbsd-nat.c: Sort headers.
1977         * arm-linux-tdep.c: Sort headers.
1978         * arm-linux-nat.c: Sort headers.
1979         * arm-fbsd-tdep.c: Sort headers.
1980         * arm-fbsd-nat.c: Sort headers.
1981         * arm-bsd-tdep.c: Sort headers.
1982         * arch-utils.c: Sort headers.
1983         * arc-tdep.c: Sort headers.
1984         * arc-newlib-tdep.c: Sort headers.
1985         * annotate.h: Sort headers.
1986         * annotate.c: Sort headers.
1987         * amd64-windows-tdep.c: Sort headers.
1988         * amd64-windows-nat.c: Sort headers.
1989         * amd64-tdep.c: Sort headers.
1990         * amd64-sol2-tdep.c: Sort headers.
1991         * amd64-obsd-tdep.c: Sort headers.
1992         * amd64-obsd-nat.c: Sort headers.
1993         * amd64-nbsd-tdep.c: Sort headers.
1994         * amd64-nbsd-nat.c: Sort headers.
1995         * amd64-nat.c: Sort headers.
1996         * amd64-linux-tdep.c: Sort headers.
1997         * amd64-linux-nat.c: Sort headers.
1998         * amd64-fbsd-tdep.c: Sort headers.
1999         * amd64-fbsd-nat.c: Sort headers.
2000         * amd64-dicos-tdep.c: Sort headers.
2001         * amd64-darwin-tdep.c: Sort headers.
2002         * amd64-bsd-nat.c: Sort headers.
2003         * alpha-tdep.c: Sort headers.
2004         * alpha-obsd-tdep.c: Sort headers.
2005         * alpha-nbsd-tdep.c: Sort headers.
2006         * alpha-mdebug-tdep.c: Sort headers.
2007         * alpha-linux-tdep.c: Sort headers.
2008         * alpha-linux-nat.c: Sort headers.
2009         * alpha-bsd-tdep.c: Sort headers.
2010         * alpha-bsd-nat.c: Sort headers.
2011         * aix-thread.c: Sort headers.
2012         * agent.c: Sort headers.
2013         * addrmap.c: Sort headers.
2014         * ada-varobj.c: Sort headers.
2015         * ada-valprint.c: Sort headers.
2016         * ada-typeprint.c: Sort headers.
2017         * ada-tasks.c: Sort headers.
2018         * ada-lang.c: Sort headers.
2019         * aarch64-tdep.c: Sort headers.
2020         * aarch64-ravenscar-thread.c: Sort headers.
2021         * aarch64-newlib-tdep.c: Sort headers.
2022         * aarch64-linux-tdep.c: Sort headers.
2023         * aarch64-linux-nat.c: Sort headers.
2024         * aarch64-fbsd-tdep.c: Sort headers.
2025         * aarch64-fbsd-nat.c: Sort headers.
2026         * aarch32-linux-nat.c: Sort headers.
2027
2028 2019-04-04  Tom Tromey  <tom@tromey.com>
2029
2030         * varobj.c (varobj_create): Update.
2031         * rust-exp.y (struct rust_parser) <update_innermost_block,
2032         lookup_symbol>: New methods.
2033         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2034         Rename.
2035         (rust_parser::rust_lookup_type)
2036         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2037         * printcmd.c (display_command, do_one_display): Update.
2038         * parser-defs.h (struct parser_state) <parser_state>: Add
2039         "tracker" parameter.
2040         (block_tracker): New member.
2041         (class innermost_block_tracker) <innermost_block_tracker>: Add
2042         "types" parameter.
2043         <reset>: Remove method.
2044         (innermost_block): Don't declare.
2045         (null_post_parser): Update.
2046         * parse.c (innermost_block): Remove global.
2047         (write_dollar_variable): Update.
2048         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2049         Remove "tracker_types" parameter.
2050         (parse_expression): Add "tracker" parameter.
2051         (parse_expression_for_completion): Update.
2052         (null_post_parser): Add "tracker" parameter.
2053         * p-exp.y: Update rules.
2054         * m2-exp.y: Update rules.
2055         * language.h (struct language_defn) <la_post_parser>: Add
2056         "tracker" parameter.
2057         * go-exp.y: Update rules.
2058         * f-exp.y: Update rules.
2059         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2060         parameter.
2061         * d-exp.y: Update rules.
2062         * c-exp.y: Update rules.
2063         * breakpoint.c (set_breakpoint_condition): Create an
2064         innermost_block_tracker.
2065         (watch_command_1): Likewise.
2066         * ada-lang.c (resolve): Add "tracker" parameter.
2067         (resolve_subexp): Likewise.
2068         * ada-exp.y (write_var_from_sym): Update.
2069
2070 2019-04-04  Tom Tromey  <tom@tromey.com>
2071
2072         * type-stack.h: New file.
2073         * type-stack.c: New file.
2074         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2075         type-stack.h.
2076         (insert_into_type_stack, insert_type, push_type, push_type_int)
2077         (insert_type_address_space, pop_type, pop_type_int)
2078         (pop_typelist, pop_type_stack, append_type_stack)
2079         (push_type_stack, get_type_stack, push_typelist)
2080         (follow_type_instance_flags, follow_types): Don't declare.
2081         * parse.c (type_stack): Remove global.
2082         (parse_exp_in_context): Update.
2083         (insert_into_type_stack, insert_type, push_type, push_type_int)
2084         (insert_type_address_space, pop_type, pop_type_int)
2085         (pop_typelist, pop_type_stack, append_type_stack)
2086         (push_type_stack, get_type_stack, push_typelist)
2087         (follow_type_instance_flags, follow_types): Remove (moved to
2088         type-stack.c).
2089         * f-exp.y (type_stack): New global.
2090         Update rules.
2091         (push_kind_type, f_parse): Update.
2092         * d-exp.y (type_stack): New global.
2093         Update rules.
2094         (d_parse): Update.
2095         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2096         Update rules.
2097         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2098         (HFILES_NO_SRCDIR): Add type-stack.h.
2099
2100 2019-04-04  Tom Tromey  <tom@tromey.com>
2101
2102         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2103         (rust_parser::convert_ast_to_expression, rust_parse)
2104         (rust_lex_test_completion, rust_lex_tests): Update.
2105         * parser-defs.h (struct expr_completion_state): New.
2106         (struct parser_state) <parser_state>: Add completion parameter.
2107         <mark_struct_expression, mark_completion_tag>: New methods.
2108         <parse_completion, m_completion_state>: New members.
2109         (prefixify_expression, null_post_parser): Update.
2110         (mark_struct_expression, mark_completion_tag): Don't declare.
2111         * parse.c (parse_completion, expout_last_struct)
2112         (expout_tag_completion_type, expout_completion_name): Remove
2113         globals.
2114         (parser_state::mark_struct_expression)
2115         (parser_state::mark_completion_tag): Now methods.
2116         (prefixify_expression): Add last_struct parameter.
2117         (prefixify_subexp): Likewise.
2118         (parse_exp_1): Update.
2119         (parse_exp_in_context): Add cstate parameter.  Update.
2120         (parse_expression_for_completion): Create an
2121         expr_completion_state.
2122         (null_post_parser): Add "completion" parameter.
2123         * p-exp.y: Update rules.
2124         (yylex): Update.
2125         * language.h (struct language_defn) <la_post_parser>: Add
2126         "completing" parameter.
2127         * go-exp.y: Update rules.
2128         (lex_one_token): Update.
2129         * expression.h (parse_completion): Don't declare.
2130         * d-exp.y: Update rules.
2131         (lex_one_token): Update rules.
2132         * c-exp.y: Update rules.
2133         (lex_one_token): Update.
2134         * ada-lang.c (resolve): Add "parse_completion" parameter.
2135         (resolve_subexp): Likewise.
2136         (ada_resolve_function): Likewise.
2137
2138 2019-04-04  Tom Tromey  <tom@tromey.com>
2139
2140         * parser-defs.h (struct parser_state) <start_arglist,
2141         end_arglist>: New methods.
2142         <arglist_len, m_funcall_chain>: New members.
2143         (arglist_len, start_arglist, end_arglist): Don't declare.
2144         * parse.c (arglist_len, funcall_chain): Remove global.
2145         (start_arglist, end_arglist): Remove functions.
2146         (parse_exp_in_context): Update.
2147         * p-exp.y: Update rules.
2148         * m2-exp.y: Update rules.
2149         * go-exp.y: Update rules.
2150         * f-exp.y: Update rules.
2151         * d-exp.y: Update rules.
2152         * c-exp.y: Update rules.
2153
2154 2019-04-04  Tom Tromey  <tom@tromey.com>
2155
2156         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2157         lex_operator, push_back>: New methods.
2158         Update all rules.
2159         (rust_parser::lex_hex, lex_escape): Rename and update.
2160         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2161         (rust_parser::lex_operator): Rename and update.
2162         (rust_parser::lex_number, rustyylex, rustyyerror)
2163         (rust_lex_test_init, rust_lex_test_sequence)
2164         (rust_lex_test_push_back, rust_lex_tests): Update.
2165         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2166         parameter.
2167         <lexptr, prev_lexptr>: New members.
2168         (lexptr, prev_lexptr): Don't declare.
2169         * parse.c (lexptr, prev_lexptr): Remove globals.
2170         (parse_exp_in_context): Update.
2171         * p-exp.y (yylex, yyerror): Update.
2172         * m2-exp.y (parse_number, yylex, yyerror): Update.
2173         * go-exp.y (lex_one_token, yyerror): Update.
2174         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2175         * d-exp.y (lex_one_token, yyerror): Update.
2176         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2177         (lex_one_token, yyerror): Update.
2178         * ada-lex.l (YY_INPUT): Update.
2179         (rewind_to_char): Update.
2180         * ada-exp.y (yyerror): Update.
2181
2182 2019-04-04  Tom Tromey  <tom@tromey.com>
2183
2184         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2185         * parser-defs.h (struct parser_state) <parser_state>: Add new
2186         parameter.
2187         <comma_terminates>: New member.
2188         (comma_terminates): Don't declare global.
2189         * parse.c (comma_terminates): Remove global.
2190         (parse_exp_in_context): Update.
2191         * p-exp.y (yylex): Update.
2192         * m2-exp.y (yylex): Update.
2193         * go-exp.y (lex_one_token): Update.
2194         * f-exp.y (yylex): Update.
2195         * d-exp.y (lex_one_token): Update.
2196         * c-exp.y (lex_one_token): Update.
2197         * ada-lex.l: Update.
2198
2199 2019-04-04  Tom Tromey  <tom@tromey.com>
2200
2201         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2202         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2203         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2204         * parser-defs.h (paren_depth): Don't declare.
2205         * parse.c (paren_depth): Remove global.
2206         (parse_exp_in_context): Update.
2207         * p-exp.y (paren_depth): New global.
2208         (pascal_parse): Initialize it.
2209         * m2-exp.y (paren_depth): New global.
2210         (m2_parse): Initialize it.
2211         * go-exp.y (paren_depth): New global.
2212         (go_parse): Initialize it.
2213         * f-exp.y (paren_depth): New global.
2214         (f_parse): Initialize it.
2215         * d-exp.y (paren_depth): New global.
2216         (d_parse): Initialize it.
2217         * c-exp.y (paren_depth): New global.
2218         (c_parse): Initialize it.
2219         * ada-lex.l (paren_depth): New global.
2220         (lexer_init): Initialize it.
2221
2222 2019-04-04  Tom Tromey  <tom@tromey.com>
2223
2224         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2225         (rust_parser::convert_ast_to_type)
2226         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2227         * parser-defs.h (struct parser_state) <parser_state>: Add
2228         parameters.  Initialize new members.
2229         <expression_context_block, expression_context_pc>: New members.
2230         * parse.c (expression_context_block, expression_context_pc):
2231         Remove globals.
2232         (parse_exp_in_context): Update.
2233         * p-exp.y: Update all rules.
2234         (yylex): Update.
2235         * m2-exp.y: Update all rules.
2236         (yylex): Update.
2237         * go-exp.y (yylex): Update.
2238         * f-exp.y (yylex): Update.
2239         * d-exp.y: Update all rules.
2240         (yylex): Update.
2241         * c-exp.y: Update all rules.
2242         (lex_one_token, classify_name, yylex, c_parse): Update.
2243         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2244
2245 2019-04-04  Tom Tromey  <tom@tromey.com>
2246
2247         * gdbarch.h, gdbarch.c: Rebuild.
2248         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2249         * stap-probe.h:
2250         (struct stap_parse_info): Replace "parser_state" with
2251         "expr_builder".
2252         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2253         (parser_state): New class.
2254         * parse.c (expr_builder): Rename.
2255         (expr_builder::release): Rename.
2256         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2257         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2258         (write_exp_elt_longcst, write_exp_elt_floatcst)
2259         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2260         (write_exp_string_vector, write_exp_bitstring)
2261         (write_exp_msymbol, mark_struct_expression)
2262         (write_dollar_variable)
2263         (insert_type_address_space, increase_expout_size): Replace
2264         "parser_state" with "expr_builder".
2265         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2266         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2267         "parser_state" with "expr_builder".
2268
2269 2019-04-04  Tom Tromey  <tom@tromey.com>
2270
2271         * rust-exp.y: Replace "parse_language" with method call.
2272         * p-exp.y:
2273         (yylex): Replace "parse_language" with method call.
2274         * m2-exp.y:
2275         (yylex): Replace "parse_language" with method call.
2276         * go-exp.y (classify_name): Replace "parse_language" with method
2277         call.
2278         * f-exp.y (yylex): Replace "parse_language" with method call.
2279         * d-exp.y (lex_one_token): Replace "parse_language" with method
2280         call.
2281         * c-exp.y:
2282         (lex_one_token, classify_name, yylex): Replace "parse_language"
2283         with method call.
2284         * ada-exp.y (find_primitive_type, type_char)
2285         (type_system_address): Replace "parse_language" with method call.
2286
2287 2019-04-04  Tom Tromey  <tom@tromey.com>
2288
2289         * rust-exp.y: Replace "parse_gdbarch" with method call.
2290         * parse.c (write_dollar_variable, insert_type_address_space):
2291         Replace "parse_gdbarch" with method call.
2292         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2293         call.
2294         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2295         call.
2296         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2297         "parse_gdbarch" with method call.
2298         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2299         with method call.
2300         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2301         "parse_gdbarch" with method call.
2302         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2303         "parse_gdbarch" with method call.
2304         * c-exp.y (parse_type, parse_number, classify_name): Replace
2305         "parse_gdbarch" with method call.
2306         * ada-lex.l: Replace "parse_gdbarch" with method call.
2307         * ada-exp.y (parse_type, find_primitive_type, type_char)
2308         (type_system_address): Replace "parse_gdbarch" with method call.
2309
2310 2019-04-04  Tom Tromey  <tom@tromey.com>
2311
2312         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2313         * stap-probe.c (stap_parse_argument): Update.
2314         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2315         initial_size parameter.
2316         * rust-exp.y (rust_lex_tests): Update.
2317         * parse.c (parser_state): Update.
2318         (parse_exp_in_context): Update.
2319         * parser-defs.h (struct parser_state) <parser_state>: Remove
2320         "initial_size" parameter.
2321
2322 2019-04-04  Tom Tromey  <tom@tromey.com>
2323
2324         * parser-defs.h (increase_expout_size): Don't declare.
2325         * parse.c (increase_expout_size): Now static.
2326
2327 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2328
2329         * gnu-nat.c (gnu_nat_target::wait): Fix
2330         target_waitstatus_to_string call.
2331
2332 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2333
2334         * eval.c (evaluate_subexp_standard): Handle internal functions
2335         during Fortran function call handling.
2336
2337 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2338
2339         * NEWS: Mention new internal functions.
2340         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2341         (read_base_type): Use dwarf2_init_complex_target_type.
2342         * value.c (creal_internal_fn): New function.
2343         (cimag_internal_fn): New function.
2344         (_initialize_values): Register new internal functions.
2345
2346 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2347
2348         * infrun.c (stop_all_threads): If debug_infrun, always
2349         trace the wait status after wait_one, using
2350         target_waitstatus_to_string and target_pid_to_str.
2351         (handle_inferior_event): Replace various trace of
2352         wait status kind by a single trace.
2353         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2354         wait status kind image by target_waitstatus_to_string.
2355         * target/waitstatus.c (target_waitstatus_to_string): Fix
2356         obsolete comment.
2357
2358 2019-04-01  Tom Tromey  <tromey@adacore.com>
2359
2360         PR symtab/23331:
2361         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2362
2363 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2364             Pedro Alves  <palves@redhat.com>
2365
2366         * top.c (quit_force): Call 'finalize_values'.
2367         * value.c (finalize_values): New function.
2368         * value.h (finalize_values): Declare.
2369
2370 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2371
2372         * NEWS: Announce $_gdb_major and $_gdb_minor.
2373
2374         * top.c (init_gdb_version_vars): New function.
2375         (gdb_init): Call init_gdb_version_vars.
2376
2377 2019-03-29  Tom Tromey  <tromey@adacore.com>
2378
2379         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2380         help text.  Remove dead code.
2381
2382 2019-03-29  Keith Seitz  <keiths@redhat.com>
2383
2384         From Siddhesh Poyarekar:
2385         * f-lang.h (f77_get_upperbound): Return LONGEST.
2386         (f77_get_lowerbound): Likewise.
2387         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2388         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2389         print them.
2390         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2391         plongest to format print it.
2392         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2393         (f77_get_upperbound): Likewise.
2394         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2395         LOWER_BOUND to LONGEST.
2396         (f77_create_arrayprint_offset_tbl): Likewise.
2397
2398 2019-03-29  Keith Seitz  <keiths@redhat.com>
2399
2400         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2401         %s/pulongest for TYPE_LENGTH instead of %d in format
2402         strings.
2403         * ada-typerint.c (ada_print_type): Likewise.
2404         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2405         * compile/compile-c-support.c (generate_register_struct): Likewise.
2406         * gdbtypes.c (recursive_dump_type): Likewise.
2407         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2408         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2409         instead of %d in format strings.
2410         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2411         to std::min to ULONGEST.
2412         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2413         instead of %d in format strings.
2414         * tracepoint.c (info_scope_command): Likewise.
2415         * typeprint.c (print_offset_data::update)
2416         (print_offset_data::finish): Likewise.
2417         * xtensa-tdep.c (xtensa_store_return_value)
2418         (xtensa_push_dummy_call): Likewise.
2419
2420 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2421
2422         * windows-nat.c (display_selector): Fixed format specifications
2423         for 64-bit Cygwin.
2424
2425 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2426
2427         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2428
2429 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2430
2431         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2432         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2433         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2434         (nios2_linux_init_abi): Install it.
2435
2436 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2437
2438         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2439
2440 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2441
2442         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2443
2444 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2445             Tom Tromey  <tromey@adacore.com>
2446
2447         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2448
2449 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2450
2451         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2452         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2453         method to compute the bounds of range types. Also print "[evaluated]"
2454         if the bounds' values come from a dynamic evaluation.
2455
2456 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2457
2458         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2459         whitespace when pretty printing is on.
2460
2461 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2462
2463         * ppc-linux-nat.c: Add include.
2464
2465 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2466
2467         * NEWS: Mention AArch64 Pointer Authentication.
2468
2469 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2470
2471         * arm-linux-nat.c: Add include.
2472
2473 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2474
2475         * source-cache.c (source_cache::get_source_lines): Re-read
2476         fullname after calling open_source_file.
2477
2478 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2479
2480         * NEWS: Mention TLS support for FreeBSD.
2481
2482 2019-03-25  Tom Tromey  <tromey@adacore.com>
2483
2484         * minsyms.c (BUNCH_SIZE): Update comment.
2485         (~minimal_symbol_reader): Remove old comment.
2486         (compact_minimal_symbols): Update comment.
2487         (minimal_symbol_reader::install): Remove old comment.  Update
2488         other comments.
2489
2490 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2491
2492         * s390-linux-nat.c: Add include.
2493
2494 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2495
2496         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2497         Call linux_get_hwcap.
2498         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2499         Likewise.
2500         (aarch64_linux_get_hwcap): Remove function.
2501         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2502         declaration.
2503         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2504         linux_get_hwcap.
2505         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2506         * linux-tdep.c (linux_get_hwcap): Add function.
2507         (linux_get_hwcap2): Likewise.
2508         * linux-tdep.h (linux_get_hwcap): Add declaration.
2509         (linux_get_hwcap2): Likewise.
2510         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2511         (ppc_linux_get_hwcap2): Likewise.
2512         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2513         linux_get_hwcap.
2514         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2515         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2516         (ppc_linux_nat_target::read_description): Likewise.
2517         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2518         * s390-linux-nat.c: Likewise.
2519         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2520
2521 2019-03-24  Tom Tromey  <tom@tromey.com>
2522
2523         * ada-lang.c (standard_lookup): Simplify initialization.
2524         (ada_lookup_symbol_nonlocal): Simplify return.
2525         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2526         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2527         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2528         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2529         initialization.
2530         * solib.c (solib_global_lookup): Simplify.
2531         * symtab.c (null_block_symbol): Remove.
2532         (symbol_cache_lookup): Simplify returns.
2533         (lookup_language_this): Simplify returns.
2534         (lookup_symbol_aux): Simplify return.
2535         (lookup_local_symbol): Simplify returns.
2536         (lookup_global_symbol_from_objfile): Simplify return.
2537         (lookup_symbol_in_objfile_symtabs)
2538         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2539         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2540         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2541         * cp-namespace.c (cp_lookup_bare_symbol)
2542         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2543         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2544         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2545         (cp_lookup_symbol_via_imports): Simplify initialization.
2546         (find_symbol_in_baseclass): Likewise.
2547         * symtab.h (null_block_symbol): Remove.
2548         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2549         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2550         (d_lookup_symbol_module): Likewise.
2551         (find_symbol_in_baseclass): Simplify initialization.
2552
2553 2019-03-24  Tom Tromey  <tom@tromey.com>
2554
2555         * expression.h: Don't include symtab.h.
2556         (struct block): Forward declare.
2557
2558 2019-03-24  Tom Tromey  <tom@tromey.com>
2559
2560         * c-exp.y (typebase): Remove casts.
2561         * gdbtypes.c (lookup_unsigned_typename, )
2562         (lookup_signed_typename): Remove cast.
2563         * eval.c (parse_to_comma_and_eval): Remove cast.
2564         * parse.c (write_dollar_variable): Remove cast.
2565         * block.h (struct block) <superblock>: Now const.
2566         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2567         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2568         (map_block): Make "block" const.
2569         * symfile.h (struct quick_symbol_functions)
2570         <map_matching_symbols>: Constify block argument to "callback".
2571         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2572         const.
2573         (find_pc_sect_compunit_symtab): Make "b" const.
2574         (find_symbol_at_address): Likewise.
2575         (search_symbols): Likewise.
2576         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2577         (dw2_debug_names_lookup_symbol): Likewise.
2578         (dw2_map_matching_symbols): Update.
2579         * p-valprint.c (pascal_val_print): Remove "block".
2580         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2581         (aux_add_nonlocal_symbols): Make "block" const.
2582         (resolve_subexp): Remove cast.
2583         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2584         const.
2585         (iterate_over_file_blocks): Likewise.
2586         * f-exp.y (%union) <bval>: Remove.
2587         * coffread.c (patch_opaque_types): Make "b" const.
2588         * spu-tdep.c (spu_catch_start): Make "block" const.
2589         * c-valprint.c (print_unpacked_pointer): Remove "block".
2590         * symmisc.c (dump_symtab_1): Make "b" const.
2591         (block_depth): Make "block" const.
2592         * d-exp.y (%union) <bval>: Remove.
2593         * cp-support.h (cp_lookup_rtti_type): Update.
2594         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2595         * psymtab.c (psym_lookup_symbol): Make "block" const.
2596         (maintenance_check_psymtabs): Make "b" const.
2597         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2598         (enumerate_locals, enumerate_args): Update.
2599         * python/py-symtab.c (stpy_global_block): Make "block" const.
2600         (stpy_static_block): Likewise.
2601         * inline-frame.c (block_starting_point_at): Make "new_block"
2602         const.
2603         * block.c (find_block_in_blockvector): Make return type const.
2604         (blockvector_for_pc_sect): Make "b" const.
2605         (find_block_in_blockvector): Make "b" const.
2606
2607 2019-03-23  Tom Tromey  <tom@tromey.com>
2608
2609         * varobj.c (varobj_create): Update.
2610         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2611         * printcmd.c (display_command, do_one_display): Don't reset
2612         innermost_block.
2613         * parser-defs.h (enum innermost_block_tracker_type): Move to
2614         expression.h.
2615         (innermost_block): Update comment.
2616         * parse.c (parse_exp_1): Add tracker_types parameter.
2617         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2618         tracker_types parameter.  Reset innermost_block.
2619         (parse_exp_in_context): Remove.
2620         (parse_expression_for_completion): Update.
2621         * objfiles.c (~objfile): Don't reset expression_context_block or
2622         innermost_block.
2623         * expression.h (enum innermost_block_tracker_type): Move from
2624         parser-defs.h.
2625         (parse_exp_1): Add tracker_types parameter.
2626         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2627         reset innermost_block.
2628
2629 2019-03-23  Tom Tromey  <tom@tromey.com>
2630
2631         * objfiles.h: Include bcache.h.
2632
2633 2019-03-23  Tom Tromey  <tom@tromey.com>
2634
2635         * linespec.c (get_current_search_block): Use
2636         scoped_restore_current_language.
2637         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2638
2639 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2640             Jiong Wang  <jiong.wang@arm.com>
2641
2642         * aarch64-linux-tdep.c
2643         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2644         section.
2645         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2646
2647 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2648             Jiong Wang  <jiong.wang@arm.com>
2649
2650         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2651         instructions.
2652         (aarch64_analyze_prologue_test): Add PACIASP test.
2653         (aarch64_prologue_prev_register): Unmask PC value.
2654
2655 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2656             Jiong Wang  <jiong.wang@arm.com>
2657
2658         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2659         (aarch64_dwarf2_prev_register): Unmask PC value.
2660         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2661         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2662         DW_CFA_AARCH64_negate_ra_state.
2663         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2664
2665 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2666             Jiong Wang  <jiong.wang@arm.com>
2667
2668         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2669         registers.
2670         (aarch64_pseudo_register_name): Likewise.
2671         (aarch64_pseudo_register_type): Likewise.
2672         (aarch64_pseudo_register_reggroup_p): Likewise.
2673         (aarch64_gdbarch_init): Add pauth registers.
2674         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2675         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2676         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2677         (struct gdbarch_tdep): Add regnum for ra_state.
2678
2679 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2680             Jiong Wang  <jiong.wang@arm.com>
2681
2682         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2683
2684 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2685             Jiong Wang  <jiong.wang@arm.com>
2686
2687         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2688         function.
2689         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2690         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2691         (aarch64_gdbarch_init): Add puth registers.
2692         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2693         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2694         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2695
2696 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2697             Jiong Wang  <jiong.wang@arm.com>
2698
2699         * aarch64-linux-nat.c
2700         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2701         * aarch64-linux-tdep.c
2702         (aarch64_linux_core_read_description): Likewise.
2703         (aarch64_linux_get_hwcap): New function.
2704         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2705         (aarch64_linux_get_hwcap): New declaration.
2706
2707 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2708             Jiong Wang  <jiong.wang@arm.com>
2709
2710         * aarch64-linux-nat.c
2711         (aarch64_linux_nat_target::read_description): Add pauth param.
2712         * aarch64-linux-tdep.c
2713         (aarch64_linux_core_read_description): Likewise.
2714         * aarch64-tdep.c (struct target_desc): Add in pauth.
2715         (aarch64_read_description): Add pauth param.
2716         (aarch64_gdbarch_init): Likewise.
2717         * aarch64-tdep.h (aarch64_read_description): Likewise.
2718         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2719         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2720         * features/Makefile: Add new files.
2721         * features/aarch64-pauth.c: New file.
2722         * features/aarch64-pauth.xml: New file.
2723
2724 2019-03-20  Tom Tromey  <tromey@adacore.com>
2725
2726         * infrun.c (handle_inferior_event): Rename from
2727         handle_inferior_event_1.  Create a scoped_value_mark.
2728         (handle_inferior_event): Remove.
2729
2730 2019-03-19  Tom Tromey  <tromey@adacore.com>
2731
2732         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2733         * infrun.h (print_stop_event): Add "displays" parameter.
2734         * infrun.c (print_stop_event): Add "displays" parameter.
2735
2736 2019-03-19  Pedro Alves  <palves@redhat.com>
2737
2738         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2739         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2740         to -1.  Fix TABs vs spaces.
2741         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2742         * tui/tui-out.h (tui_ui_out) Add intro comments.
2743         <m_line, m_start_of_line>: In-class initialize, and add describing
2744         comment.
2745
2746 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2747
2748         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2749         variable names.
2750         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2751
2752 2019-03-18  Pedro Alves  <palves@redhat.com>
2753             Eli Zaretskii <eliz@gnu.org>
2754
2755         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2756         m_line and m_start_of_line.
2757
2758 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2759
2760         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2761         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2762         it returns a newline.  This fixes a regression in TU mode, whereby
2763         the next line is output on the same screen line as the user input.
2764
2765 2019-03-18  Tom Tromey  <tromey@adacore.com>
2766
2767         * minsyms.c (minimal_symbol_reader::install): Remove call to
2768         obstack_blank.
2769
2770 2019-03-18  Pedro Alves  <palves@redhat.com>
2771
2772         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2773         New globals.
2774         (apply_style): New, factored out from ...
2775         (apply_ansi_escape): ... this.  Handle reverse video mode.
2776         (tui_set_reverse_mode): New function.
2777         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2778         * tui/tui-winsource.c (tui_show_source_line): Use
2779         tui_set_reverse_mode instead of setting A_STANDOUT.
2780         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2781         New setter methods.
2782
2783 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2784
2785         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2786         Handle tabs.
2787
2788 2019-03-18  Tom Tromey  <tromey@adacore.com>
2789
2790         * ada-lang.c (empty_array): Add "high" parameter.
2791         (ada_evaluate_subexp): Update.
2792
2793 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2794
2795         * unittests/string_view-selftests.c: Define
2796         _initialize_string_view_selftests unconditionally.
2797
2798 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2799
2800         PR gdb/24350
2801         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2802
2803 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2804
2805         PR gdb/24351
2806         * windows-nat.c (display_selector): Fix format specifiers.
2807
2808 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2809
2810         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2811         tui_refill_source_window instead of tui_refresh_win, to update the
2812         current execution line.  This fixes redisplay of the current line
2813         when stepping through the code with "next" or "step".
2814
2815 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2816
2817         * source-cache.c (source_cache::get_source_lines): Call
2818         find_source_lines to initialize s->nlines.  This fixes vertical
2819         scrolling of TUI source window when the DOWN arrow is pressed.
2820
2821 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2822
2823         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2824         linux-thread-db.c (_initialize_thread_db): Likewise.
2825
2826 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2827
2828         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2829         wclrtoeol in tui_show_source_line".  This reverts changes made in
2830         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2831
2832 2019-03-15  Tom Tromey  <tom@tromey.com>
2833
2834         * symtab.h (struct minimal_symbol): Derive from
2835         general_symbol_info.
2836         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2837         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2838         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2839         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2840         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2841         (MSYMBOL_SEARCH_NAME): Update.
2842         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2843         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2844         * minsyms.c (minimal_symbol_reader::record_full): Update.
2845
2846 2019-03-15  Tom Tromey  <tom@tromey.com>
2847
2848         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2849
2850 2019-03-15  Tom Tromey  <tom@tromey.com>
2851
2852         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2853         unique_xmalloc_ptr.
2854         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2855         Update.
2856         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2857         (build_minimal_symbol_hash_tables)
2858         (minimal_symbol_reader::install): Update.
2859
2860 2019-03-15  Tom Tromey  <tom@tromey.com>
2861
2862         * symtab.c (create_demangled_names_hash): Update.
2863         (symbol_set_names): Update.
2864         * objfiles.h (struct objfile_per_bfd_storage)
2865         <demangled_names_hash>: Now an htab_up.
2866         * objfiles.c (objfile_per_bfd_storage): Simplify.
2867
2868 2019-03-15  Tom Tromey  <tom@tromey.com>
2869
2870         * objfiles.h (struct objfile_per_bfd_storage): Declare
2871         destructor.
2872         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2873         New.
2874         (get_objfile_bfd_data): Use new.  Don't initialize
2875         language_of_main.
2876         (free_objfile_per_bfd_storage): Remove.
2877         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2878
2879 2019-03-15  Tom Tromey  <tom@tromey.com>
2880
2881         * symfile.c (reread_symbols): Update.
2882         * objfiles.c (objfile::objfile): Update.
2883         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2884         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2885         comment.
2886         (minimal_symbol_reader::install): Update.
2887         (terminate_minimal_symbol_table): Remove.
2888         * jit.c (jit_object_close_impl): Update.
2889
2890 2019-03-15  Tom Tromey  <tom@tromey.com>
2891
2892         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2893         initializations.
2894
2895 2019-03-15  Tom Tromey  <tom@tromey.com>
2896
2897         * objfiles.h (struct objfile_per_bfd_storage)
2898         <demangled_hash_languages>: Now a bitset.
2899         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2900         (lookup_minimal_symbol): Update.
2901
2902 2019-03-15  Tom Tromey  <tom@tromey.com>
2903
2904         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2905         Don't return the symbol.
2906         * coffread.c (record_minimal_symbol): Use record_full.
2907
2908 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2909
2910         The MS-Windows port of ncurses fails to switch to a color pair if
2911         one or both of the colors are the implicit default colors.  This
2912         change records the default colors when TUI is initialized, and
2913         then specifies them explicitly when a color pair uses the default
2914         colors.  This allows color styling in TUI mode on MS-Windows.
2915
2916         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2917         ncurses_norm_attr.
2918         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2919         colors in ncurses_norm_attr.
2920         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2921         "none", replace it with the default color recorded in
2922         ncurses_norm_attr.
2923
2924 2019-03-14  Tom Tromey  <tromey@adacore.com>
2925
2926         * source-cache.h (class source_cache) <get_source_lines>: Return
2927         std::string.
2928         * source-cache.c (source_cache::extract_lines): Handle case where
2929         first_pos==npos.  Return std::string.
2930         (source_cache::get_source_lines): Update.
2931
2932 2019-03-14  Tom Tromey  <tromey@adacore.com>
2933
2934         * NEWS: Add item for "style sources" commands.
2935         * source-cache.c (source_cache::get_source_lines): Check
2936         source_styling.
2937         * cli/cli-style.c (source_styling): New global.
2938         (_initialize_cli_style): Add "style sources" commands.
2939         (show_style_sources): New function.
2940         * cli/cli-style.h (source_styling): Declare.
2941
2942 2019-03-14  Pedro Alves  <palves@redhat.com>
2943             Tom Tromey  <tromey@adacore.com>
2944
2945         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2946         * tui/tui-winsource.c (tui_refill_source_window): New function,
2947         from...
2948         (tui_horizontal_source_scroll): ... here.  Move some logic.
2949         * cli/cli-style.c (set_style_enabled): Notify new observable.
2950         * tui/tui-hooks.c (tui_redisplay_source): New function.
2951         (tui_attach_detach_observers): Attach or detach
2952         tui_redisplay_source.
2953         * observable.h (source_styling_changed): New observable.
2954         * observable.c: Define source_styling_changed observable.
2955
2956 2019-03-13  Tom Tromey  <tromey@adacore.com>
2957
2958         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2959         (i386_gnu_nat_target::store_registers): Update.
2960         * target-debug.h (target_debug_print_std_string): New macro.
2961         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2962         * windows-tdep.c (display_one_tib): Update.
2963         * tui/tui-stack.c (tui_make_status_line): Update.
2964         * top.c (print_inferior_quit_action): Update.
2965         * thread.c (thr_try_catch_cmd): Update.
2966         (add_thread_with_info): Update.
2967         (thread_target_id_str): Update.
2968         (thr_try_catch_cmd): Update.
2969         (thread_command): Update.
2970         (thread_find_command): Update.
2971         * record-btrace.c (record_btrace_target::info_record)
2972         (record_btrace_resume_thread, record_btrace_target::resume)
2973         (record_btrace_cancel_resume, record_btrace_step_thread)
2974         (record_btrace_target::wait, record_btrace_target::wait)
2975         (record_btrace_target::wait, record_btrace_target::stop): Update.
2976         * progspace.c (print_program_space): Update.
2977         * process-stratum-target.c
2978         (process_stratum_target::thread_address_space): Update.
2979         * linux-fork.c (linux_fork_mourn_inferior)
2980         (detach_checkpoint_command, info_checkpoints_command)
2981         (linux_fork_context): Update.
2982         (linux_fork_detach): Update.
2983         (class scoped_switch_fork_info): Update.
2984         (delete_checkpoint_command): Update.
2985         * infrun.c (follow_fork_inferior): Update.
2986         (follow_fork_inferior): Update.
2987         (proceed_after_vfork_done): Update.
2988         (handle_vfork_child_exec_or_exit): Update.
2989         (follow_exec): Update.
2990         (displaced_step_prepare_throw): Update.
2991         (displaced_step_restore): Update.
2992         (start_step_over): Update.
2993         (resume_1): Update.
2994         (clear_proceed_status_thread): Update.
2995         (proceed): Update.
2996         (print_target_wait_results): Update.
2997         (do_target_wait): Update.
2998         (context_switch): Update.
2999         (stop_all_threads): Update.
3000         (restart_threads): Update.
3001         (finish_step_over): Update.
3002         (handle_signal_stop): Update.
3003         (switch_back_to_stepped_thread): Update.
3004         (keep_going_pass_signal): Update.
3005         (print_exited_reason): Update.
3006         (normal_stop): Update.
3007         * inferior.c (inferior_pid_to_str): Change return type.
3008         (print_selected_inferior): Update.
3009         (add_inferior): Update.
3010         (detach_inferior): Update.
3011         * dummy-frame.c (fprint_dummy_frames): Update.
3012         * dcache.c (dcache_info_1): Update.
3013         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3014         (btrace_fetch, btrace_clear): Update.
3015         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3016         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3017         type.
3018         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3019         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3020         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3021         * gdbarch.c, gdbarch.h: Rebuild.
3022         * gdbarch.sh (core_pid_to_str): Change return type.
3023         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3024         return type.
3025         (windows_nat_target::pid_to_str): Change return type.
3026         (windows_delete_thread): Update.
3027         (windows_nat_target::attach): Update.
3028         (windows_nat_target::files_info): Update.
3029         * target-delegates.c: Rebuild.
3030         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3031         return type.
3032         (sol_thread_target::pid_to_str): Change return type.
3033         * remote.c (class remote_target) <pid_to_str>: Change return
3034         type.
3035         (remote_target::pid_to_str): Change return type.
3036         (extended_remote_target::attach, remote_target::remote_stop_ns)
3037         (remote_target::remote_notif_remove_queued_reply)
3038         (remote_target::push_stop_reply, remote_target::disable_btrace):
3039         Update.
3040         (extended_remote_target::attach): Update.
3041         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3042         type.
3043         (gdbsim_target::pid_to_str): Change return type.
3044         * ravenscar-thread.c (struct ravenscar_thread_target)
3045         <pid_to_str>: Change return type.
3046         (ravenscar_thread_target::pid_to_str): Change return type.
3047         * procfs.c (class procfs_target) <pid_to_str>: Change return
3048         type.
3049         (procfs_target::pid_to_str): Change return type.
3050         (procfs_target::attach): Update.
3051         (procfs_target::detach): Update.
3052         (procfs_target::fetch_registers): Update.
3053         (procfs_target::store_registers): Update.
3054         (procfs_target::wait): Update.
3055         (procfs_target::files_info): Update.
3056         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3057         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3058         return type.
3059         (nto_procfs_target::pid_to_str): Change return type.
3060         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3061         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3062         return type.
3063         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3064         (exit_lwp): Update.
3065         (attach_proc_task_lwp_callback, get_detach_signal)
3066         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3067         (linux_nat_target::resume, wait_lwp, stop_callback)
3068         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3069         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3070         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3071         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3072         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3073         type.
3074         (inf_ptrace_target::attach): Update.
3075         (inf_ptrace_target::files_info): Update.
3076         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3077         type.
3078         (go32_nat_target::pid_to_str): Change return type.
3079         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3080         (gnu_nat_target::wait): Update.
3081         (gnu_nat_target::wait): Update.
3082         (gnu_nat_target::resume): Update.
3083         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3084         (fbsd_nat_target::wait): Update.
3085         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3086         type.
3087         (darwin_nat_target::attach): Update.
3088         * corelow.c (class core_target) <pid_to_str>: Change return type.
3089         (core_target::pid_to_str): Change return type.
3090         * target.c (normal_pid_to_str): Change return type.
3091         (default_pid_to_str): Likewise.
3092         (target_pid_to_str): Change return type.
3093         (target_translate_tls_address): Update.
3094         (target_announce_detach): Update.
3095         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3096         return type.
3097         (bsd_uthread_target::pid_to_str): Change return type.
3098         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3099         type.
3100         (bsd_kvm_target::pid_to_str): Change return type.
3101         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3102         return type.
3103         (aix_thread_target::pid_to_str): Change return type.
3104         * target.h (struct target_ops) <pid_to_str>: Change return type.
3105         (target_pid_to_str, normal_pid_to_str): Likewise.
3106         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3107         type.
3108         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3109         type.
3110         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3111         return type.
3112         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3113         type.
3114         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3115         type.
3116         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3117         return type.
3118
3119 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3120
3121         * NEWS: Mention that the new default MI version is 3.  Mention
3122         changes to the output of commands and events that deal with
3123         multi-location breakpoints.
3124         * breakpoint.c: Include "mi/mi-out.h".
3125         (print_one_breakpoint): Change output syntax if using MI version
3126         >= 3.
3127         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3128         New.
3129         (mi_multi_location_breakpoint_output_fixed): New.
3130         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3131         (mi_cmd_fix_multi_location_breakpoint_output): New.
3132         (mi_multi_location_breakpoint_output_fixed): New.
3133         * mi/mi-cmds.c (mi_cmds): Register command
3134         -fix-multi-location-breakpoint-output.
3135         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3136         interpreter "mi".
3137
3138 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3139
3140         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3141         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3142         instantiate mi_ui_out based on interpreter name.
3143         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3144         * mi/mi-main.c (mi_load_progress): Likewise.
3145
3146 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3147
3148         * NEWS: Combine separate "New targets" sections for 8.3.
3149
3150 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3151
3152         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3153         (ppcfbsd_init_abi): Install gdbarch
3154         "fetch_tls_load_module_address" and "get_thread_local_address"
3155         methods.
3156
3157 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3158
3159         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3160         (riscv_fbsd_init_abi): Install gdbarch
3161         "fetch_tls_load_module_address" and "get_thread_local_address"
3162         methods.
3163
3164 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3165
3166         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3167         (i386fbsd_init_abi): Install gdbarch
3168         "fetch_tls_load_module_address" and "get_thread_local_address"
3169         methods.
3170
3171 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3172
3173         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3174         (amd64fbsd_init_abi): Install gdbarch
3175         "fetch_tls_load_module_address" and "get_thread_local_address"
3176         methods.
3177
3178 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3179
3180         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3181         (struct fbsd_pspace_data): New type.
3182         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3183         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3184         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3185         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3186         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3187
3188 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3189
3190         * gdbtypes.c (lookup_struct_elt): New function.
3191         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3192         * gdbtypes.h (struct struct_elt): New type.
3193         (lookup_struct_elt): New prototype.
3194
3195 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3196
3197         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3198         remove disabled code block.
3199
3200 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3201
3202         * gdbarch.sh (get_thread_local_address): New method.
3203         * gdbarch.h, gdbarch.c: Regenerate.
3204         * target.c (target_translate_tls_address): Use
3205         gdbarch_get_thread_local_address if present instead of
3206         target::get_thread_local_address.
3207
3208 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3209
3210         * target.h (target::get_thread_local_address): Update comment.
3211
3212 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3213
3214         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3215         objfile->separate_debug_objfile_backlink if not NULL.
3216
3217 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3218
3219         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3220         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3221         (amd64bsd_store_inferior_registers): Likewise.
3222         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3223         Enable segment base registers.
3224         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3225         PT_GETFSBASE and PT_GETGSBASE.
3226         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3227         PT_SETGSBASE.
3228         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3229         segment base registers.
3230         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3231
3232 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3233
3234         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3235         Update calls to i386_target_description to add 'segments'
3236         parameter.
3237         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3238         add segment base registers.
3239         * arch/i386.c (i386_create_target_description): Add 'segments'
3240         parameter to enable segment base registers.
3241         * arch/i386.h (i386_create_target_description): Likewise.
3242         * features/i386/32bit-segments.xml: New file.
3243         * features/i386/32bit-segments.c: Generate.
3244         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3245         call to i386_target_description to add 'segments' parameter.
3246         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3247         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3248         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3249         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3250         if feature is present.
3251         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3252         Add 'segments' parameter to call to i386_target_description.
3253         (i386_target_description): Add 'segments' parameter to enable
3254         segment base registers.
3255         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3256         to call to i386_target_description.
3257         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3258         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3259         Define I386_NUM_REGS.
3260         (i386_target_description): Add 'segments' parameter to enable
3261         segment base registers.
3262
3263 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3264
3265         PR/24325
3266         * source-cache.c: #undef open and close, to avoid unresolved
3267         externals during linking.
3268
3269 2019-03-12  Tom Tromey  <tromey@adacore.com>
3270
3271         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3272         const.  Add initializers.
3273         (_initialize_remote): Don't initialize ptid globals.
3274
3275 2019-03-12  Pedro Alves  <palves@redhat.com>
3276
3277         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3278
3279 2019-03-12  Pedro Alves  <palves@redhat.com>
3280
3281         * cp-name-parser.y (main): Remove unused 'len' variable.
3282
3283 2019-03-12  Tom Tromey  <tromey@adacore.com>
3284
3285         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3286         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3287
3288 2019-03-12  Tom Tromey  <tromey@adacore.com>
3289
3290         * linux-nat.c (iterate_over_lwps): Update.
3291         (stop_callback): Remove parameter.
3292         (stop_wait_callback, detach_callback, resume_set_callback)
3293         (select_singlestep_lwp_callback, set_ignore_sigint)
3294         (status_callback, resumed_callback, resume_clear_callback)
3295         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3296         data parameter.
3297         (linux_nat_target::detach, linux_nat_target::resume)
3298         (linux_stop_and_wait_all_lwps, select_event_lwp)
3299         (linux_nat_filter_event, linux_nat_wait_1)
3300         (linux_nat_target::kill, linux_nat_target::stop)
3301         (linux_nat_target::stop): Update.
3302         (linux_nat_resume_callback): Change type.
3303         (resume_stopped_resumed_lwps, count_events_callback)
3304         (select_event_lwp_callback): Likewise.
3305         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3306         * arm-linux-nat.c (struct update_registers_data): Remove.
3307         (update_registers_callback): Change type.
3308         (arm_linux_insert_hw_breakpoint1): Update.
3309         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3310         parameter.
3311         (x86_linux_dr_set_addr): Update.
3312         (x86_linux_dr_set_control): Update.
3313         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3314         (iterate_over_lwps): Use gdb::function_view.
3315         * nat/aarch64-linux-hw-point.c (struct
3316         aarch64_dr_update_callback_param): Remove.
3317         (debug_reg_change_callback): Change type.
3318         (aarch64_notify_debug_reg_change): Update.
3319         * s390-linux-nat.c (s390_refresh_per_info): Update.
3320
3321 2019-03-11  Tom Tromey  <tromey@adacore.com>
3322
3323         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3324         redundant assignment to "this_cu".
3325
3326 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3327
3328         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3329
3330 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3331
3332         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3333         from...
3334         (rank_one_type): ... this.
3335
3336 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3337
3338         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3339         from...
3340         (rank_one_type): ... this.
3341
3342 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3343
3344         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3345         from...
3346         (rank_one_type): ... this.
3347
3348 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3349
3350         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3351         from...
3352         (rank_one_type): ... this.
3353
3354 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3355
3356         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3357         from...
3358         (rank_one_type): ... this.
3359
3360 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3361
3362         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3363         from...
3364         (rank_one_type): ... this.
3365
3366 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3367
3368         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3369         from...
3370         (rank_one_type): ... this.
3371
3372 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3373
3374         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3375         from...
3376         (rank_one_type): ... this.
3377
3378 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3379
3380         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3381         from...
3382         (rank_one_type): ... this.
3383
3384 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3385
3386         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3387         from...
3388         (rank_one_type): ... this.
3389
3390 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3391
3392         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3393         from...
3394         (rank_one_type): ... this.
3395
3396 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3397
3398         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3399         from...
3400         (rank_one_type): ... this.
3401
3402 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3403
3404         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3405         inferior-events' shows the example events.
3406
3407 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3408
3409         Support styling on native MS-Windows console
3410
3411         PR/24315
3412         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3413         on MS-Windows if $TERM is not defined.
3414
3415         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3416
3417         * posix-hdep.c (gdb_console_fputs):
3418         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3419         functions.
3420         * ui-file.h (gdb_console_fputs): Add prototype.
3421
3422         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3423         back to fputs only if the former returns zero.
3424
3425 2019-03-07  Tom Tromey  <tom@tromey.com>
3426
3427         * symmisc.c (print_symbol_bcache_statistics): Update.
3428         (print_objfile_statistics): Update.
3429         * symfile.c (allocate_symtab): Update.
3430         * stabsread.c: Don't include bcache.h.
3431         * psymtab.h (struct psymbol_bcache): Don't declare.
3432         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3433         (psymbol_bcache_init, psymbol_bcache_free)
3434         (psymbol_bcache_get_bcache): Don't declare.
3435         * psymtab.c (struct psymbol_bcache): Remove.
3436         (psymtab_storage::psymtab_storage): Update.
3437         (psymtab_storage::~psymtab_storage): Update.
3438         (psymbol_bcache_init, psymbol_bcache_free)
3439         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3440         (add_psymbol_to_bcache): Update.
3441         (allocate_psymtab): Update.
3442         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3443         macro_cache>: No longer pointers.
3444         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3445         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3446         * macrotab.c (macro_bcache): Update.
3447         * macroexp.c: Don't include bcache.h.
3448         * gdbtypes.c (check_types_worklist): Update.
3449         (types_deeply_equal): Remove TRY/CATCH.  Update.
3450         * elfread.c (elf_symtab_read): Update.
3451         * dwarf2read.c: Don't include bcache.h.
3452         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3453         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3454         (print_bcache_statistics, bcache_memory_used): Don't declare.
3455         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3456         methods.  Rename all data members.
3457         * bcache.c (struct bcache): Move to bcache.h.
3458         (bcache::expand_hash_table): Rename from expand_hash_table.
3459         (bcache): Remove.
3460         (bcache::insert): Rename from bcache_full.
3461         (bcache::compare): Rename from bcache_compare.
3462         (bcache_xmalloc): Remove.
3463         (bcache::~bcache): Rename from bcache_xfree.
3464         (bcache::print_statistics): Rename from print_bcache_statistics.
3465         (bcache::memory_used): Rename from bcache_memory_used.
3466
3467 2019-03-07  Pedro Alves  <palves@redhat.com>
3468
3469         * infrun.c (normal_stop): Also check for
3470         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3471
3472 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3473
3474         * f-lang.c (value_from_host_double): Moved to...
3475         * value.c (value_from_host_double): ...here.
3476         * value.h (value_from_host_double): Declare.
3477         * guile/scm-math.c (vlscm_convert_typed_number): Use
3478         value_from_host_double.
3479         (vlscm_convert_number): Likewise.
3480         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3481         * python/py-value.c (convert_value_from_python): Likewise.
3482
3483 2019-03-06  Tom Tromey  <tom@tromey.com>
3484
3485         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3486
3487 2019-03-06  Tom Tromey  <tom@tromey.com>
3488
3489         * utils.h (free_current_contents): Don't declare.
3490         * utils.c (free_current_contents): Remove.
3491
3492 2019-03-06  Tom Tromey  <tom@tromey.com>
3493
3494         * top.c (quit_force): Update.
3495         * main.c (captured_command_loop): Update.
3496         * common/new-op.c (operator new): Update.
3497         * common/common-exceptions.c (struct catcher)
3498         <save_cleanup_chain>: Remove member.
3499         (exceptions_state_mc_init): Update.
3500         (exception_try_scope_entry): Return nullptr.
3501         (exception_try_scope_exit, exception_rethrow)
3502         (throw_exception_sjlj, throw_exception_cxx): Update.
3503         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3504         (all_cleanups, do_cleanups, discard_cleanups)
3505         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3506         (restore_cleanups, restore_final_cleanups): Don't declare.
3507         (do_final_cleanups): Remove parameter.
3508         * common/cleanups.c (cleanup_chain, make_cleanup)
3509         (make_cleanup_dtor, all_cleanups, do_cleanups)
3510         (discard_my_cleanups, discard_cleanups)
3511         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3512         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3513         (null_cleanup): Remove.
3514         (do_final_cleanups): Remove parameter.
3515
3516 2019-03-06  Tom Tromey  <tom@tromey.com>
3517
3518         * remote.c (remote_target::remote_parse_stop_reply): Use
3519         unique_xmalloc_ptr.
3520
3521 2019-03-06  Tom Tromey  <tom@tromey.com>
3522
3523         * stabsread.c (struct stabs_field_info): Rename from field_info.
3524         <list, fnlist>: Add initializers.
3525         <obstack>: New member.
3526         (read_member_functions, read_struct_fields, read_baseclasses):
3527         Allocate on obstack.  Don't use cleanups.
3528         (read_one_struct_field, read_member_functions, read_struct_fields)
3529         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3530         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3531         (read_struct_type): Update.
3532
3533 2019-03-06  Tom Tromey  <tom@tromey.com>
3534
3535         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3536         * common/filestuff.h (make_cleanup_close): Don't declare.
3537         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3538         Remove.
3539
3540 2019-03-06  Tom Tromey  <tom@tromey.com>
3541
3542         * solib-aix.c: Use make_scope_exit.
3543
3544 2019-03-06  Tom Tromey  <tom@tromey.com>
3545
3546         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3547         Use make_scope_exit.
3548
3549 2019-03-06  Tom Tromey  <tom@tromey.com>
3550
3551         * solib-svr4.c (disable_probes_interface): Remove parameter.
3552         (svr4_handle_solib_event): Use make_scope_exit.
3553
3554 2019-03-06  Tom Tromey  <tom@tromey.com>
3555
3556         * remote.c (struct stop_reply_deleter): Remove.
3557         (stop_reply_up): Update.
3558         (struct stop_reply): Derive from notif_event.  Don't typedef.
3559         <regcache>: Now a std::vector.
3560         (stop_reply_xfree): Remove.
3561         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3562         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3563         (remote_target::discard_pending_stop_replies): Use delete.
3564         (remote_target::remote_parse_stop_reply): Update.
3565         (remote_target::process_stop_reply): Update.
3566         * remote-notif.h (struct notif_event): Add virtual destructor.
3567         Remove "dtr" member.
3568         (struct notif_client) <alloc_event>: Return a unique_ptr.
3569         (notif_event_xfree): Don't declare.
3570         (notif_event_up): New typedef.
3571         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3572         (notif_event_xfree, do_notif_event_xfree): Remove.
3573         (remote_notif_state_xfree): Update.
3574
3575 2019-03-06  Tom Tromey  <tom@tromey.com>
3576
3577         * infrun.c (displaced_step_clear_cleanup): Now a
3578         forward_scope_exit type.
3579         (displaced_step_prepare_throw): Update.
3580         (displaced_step_fixup): Update.
3581
3582 2019-03-06  Tom Tromey  <tom@tromey.com>
3583
3584         * inferior.h (class inferior): Update comment.
3585         * gdbthread.h (class thread_info): Update comment.
3586
3587 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3588             Tom Tromey  <tom@tromey.com>
3589
3590         * stabsread.h (struct stab_section_list): Remove.
3591         (coffstab_build_psymtabs): Update.
3592         * dbxread.c (symbuf_sections): Now a std::vector.
3593         (sect_idx): New global.
3594         (fill_symbuf): Update.
3595         (coffstab_build_psymtabs): Change type of stabsects parameter.
3596         Update.
3597         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3598         std::vector.
3599         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3600         (coff_locate_sections): Update.
3601         (coff_symfile_read): Remove cleanups.  Update.
3602         (init_stringtab): Add storage parameter.
3603         (free_stringtab, free_stringtab_cleanup): Remove.
3604         (init_lineno): Add storage parameter.
3605         (free_linetab, free_linetab_cleanup): Remove.
3606
3607 2019-03-06  Pedro Alves  <palves@redhat.com>
3608
3609         * linux-fork.c (fork_info::clobber_regs): Delete.
3610         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3611         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3612         comment.  Adjust.
3613         (scoped_switch_fork_info::scoped_switch_fork_info)
3614         (checkpoint_command, linux_fork_context): Adjust
3615         fork_save_infrun_state calls.
3616
3617 2019-03-06  Pedro Alves  <palves@redhat.com>
3618
3619         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3620         (inf_has_multiple_threads): Return 'bool' and rewrite using
3621         inferior_info::threads().
3622
3623 2019-03-06  Pedro Alves  <palves@redhat.com>
3624
3625         * linux-fork.c: Include <list>.
3626         (fork_list): Now a std::list instance.
3627         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3628         (forks_exist_p, find_last_fork): Adjust.
3629         (new_fork): Delete.
3630         (one_fork_p): New.
3631         (add_fork): Adjust.
3632         (free_fork): Delete, folded into fork_info::~fork_info().
3633         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3634         Adjust.
3635         (init_fork_list): Delete.
3636         (linux_fork_killall, linux_fork_mourn_inferior)
3637         (linux_fork_detach, info_checkpoints_command): Adjust.
3638         (_initialize_linux_fork): No longer call init_fork_list.
3639
3640 2019-03-06  Pedro Alves  <palves@redhat.com>
3641
3642         * linux-fork.c (new_fork): New, split out of ...
3643         (add_fork): ... this.  Return void.  Move "first fork" special
3644         case from here, to ...
3645         (checkpoint_command): ... here.
3646         * linux-linux.h (add_fork): Return void.
3647
3648 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3649
3650         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3651
3652 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3653             Chris January  <chris.january@arm.com>
3654             David Lecomber  <david.lecomber@arm.com>
3655
3656         * f-exp.y: New token, UNOP_INTRINSIC.
3657         (exp): New pattern using UNOP_INTRINSIC token.
3658         (f77_keywords): Add 'abs' keyword.
3659         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3660         (value_from_host_double): New function.
3661         (evaluate_subexp_f): Support UNOP_ABS.
3662
3663 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3664
3665         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3666         types.
3667
3668 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3669
3670         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3671         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3672         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3673
3674 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3675
3676         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3677
3678 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3679             Chris January  <chris.january@arm.com>
3680
3681         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3682         * f-exp.y: Define 'KIND' token.
3683         (exp): New pattern for KIND expressions.
3684         (ptype): Handle types with a kind extension.
3685         (direct_abs_decl): Extend to spot kind extensions.
3686         (f77_keywords): Add 'kind' to the list.
3687         (push_kind_type): New function.
3688         (convert_to_kind_type): New function.
3689         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3690         * parse.c (operator_length_standard): Likewise.
3691         * parser-defs.h (enum type_pieces): Add tp_kind.
3692         * std-operator.def: Add UNOP_KIND.
3693
3694 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3695
3696         * f-exp.y (f_parse): Set yydebug.
3697
3698 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3699
3700         * f-lang.c (evaluate_subexp_f): New function.
3701         (exp_descriptor_f): New global.
3702         (f_language_defn): Use exp_descriptor_f instead of
3703         exp_descriptor_standard.
3704
3705 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3706
3707         * f-exp.y (struct token): Add comments.
3708         (dot_ops): Remove uppercase versions and the end marker.
3709         (f77_keywords): Likewise.
3710         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3711         entries in the dot_ops array are case insensitive, and use
3712         strncasecmp to compare strings.  Also some whitespace cleanup in
3713         this area.  Similar for the f77_keywords array, except entries in
3714         this list might be case sensitive.
3715
3716 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3717
3718         * f-exp.y (struct f77_boolean_val): Add comments.
3719         (boolean_values): Remove uppercase versions, and end marker.
3720         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3721         and use strncasecmp to achieve case insensitivity.  Additionally,
3722         perform whitespace cleanup around this code.
3723
3724 2019-03-06  Tom Tromey  <tromey@adacore.com>
3725
3726         * remote-sim.c (gdbsim_target_open): Use result of
3727         gdb_argv::release.
3728
3729 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3730         Dirk Schubert  <dirk.schubert@arm.com>
3731         Chris January  <chris.january@arm.com>
3732
3733         * eval.c (evaluate_subexp_standard): Call Fortran argument
3734         wrapping logic.
3735         * f-lang.c (struct value): A value which can be passed into a
3736         Fortran function call.
3737         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3738         where appropriate.
3739         (struct type): Value ready for a Fortran function call.
3740         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3741         is needed.
3742         * f-lang.h (fortran_argument_convert): Declaration.
3743         (fortran_preserve_arg_pointer): Declaration.
3744         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3745
3746 2019-03-05  Tom Tromey  <tromey@adacore.com>
3747
3748         * python/py-prettyprint.c (print_string_repr): Remove #if.
3749         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3750
3751 2019-03-05  Tom Tromey  <tromey@adacore.com>
3752
3753         * target.c (the_dummy_target): Move later.  Change type to
3754         "dummy_target".
3755         (initialize_targets): Don't initialize the_dummy_target.
3756
3757 2019-03-05  Tom Tromey  <tromey@adacore.com>
3758
3759         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3760         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3761
3762 2019-03-05  Tom Tromey  <tromey@adacore.com>
3763
3764         * windows-nat.c (windows_nat_target::attach)
3765         (windows_nat_target::detach): Don't call gdb_flush.
3766         * valprint.c (generic_val_print, val_print, val_print_string):
3767         Don't call gdb_flush.
3768         * utils.c (defaulted_query): Don't call gdb_flush.
3769         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3770         * target.c (target_announce_detach): Don't call gdb_flush.
3771         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3772         * remote.c (extended_remote_target::attach): Don't call
3773         gdb_flush.
3774         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3775         * printcmd.c (do_examine): Don't call gdb_flush.
3776         (info_display_command): Don't call gdb_flush.
3777         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3778         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3779         * memattr.c (info_mem_command): Don't call gdb_flush.
3780         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3781         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3782         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3783         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3784         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3785         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3786         (gnu_nat_target::detach): Don't call gdb_flush.
3787         * f-valprint.c (f_val_print): Don't call gdb_flush.
3788         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3789         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3790         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3791         gdb_flush.
3792         * c-valprint.c (c_val_print): Don't call gdb_flush.
3793         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3794
3795 2019-03-05  Tom Tromey  <tromey@adacore.com>
3796
3797         * varobj.c (update_dynamic_varobj_children): Update.
3798         (install_default_visualizer): Use reset, not release.
3799         * value.c (set_internalvar): Update.
3800         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3801         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3802         ATTRIBUTE_UNUSED_RESULT.
3803
3804 2019-03-05  Tom Tromey  <tromey@adacore.com>
3805
3806         * remote.c (class scoped_remote_fd) <release>: Add
3807         ATTRIBUTE_UNUSED_RESULT.
3808
3809 2019-03-05  Tom Tromey  <tromey@adacore.com>
3810
3811         * macroexp.c (struct macro_buffer) <release>: Add
3812         ATTRIBUTE_UNUSED_RESULT.
3813
3814 2019-03-05  Tom Tromey  <tromey@adacore.com>
3815
3816         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3817         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3818         ATTRIBUTE_UNUSED_RESULT.
3819
3820 2019-03-05  Tom Tromey  <tromey@adacore.com>
3821
3822         * common/scoped_fd.h (class scoped_fd) <release>: Add
3823         ATTRIBUTE_UNUSED_RESULT.
3824
3825 2019-03-05  Tom Tromey  <tromey@adacore.com>
3826
3827         * parser-defs.h (struct parser_state) <release>: Add
3828         ATTRIBUTE_UNUSED_RESULT.
3829
3830 2019-03-05  Tom Tromey  <tromey@adacore.com>
3831
3832         * utils.h (class gdb_argv) <release>: Add
3833         ATTRIBUTE_UNUSED_RESULT.
3834         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3835
3836 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3837
3838         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3839         for-loop range, to avoid compiler warnings.
3840
3841         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3842         avoid compiler warnings about unused variables.
3843
3844         * NEWS: Mention end of support for native debugging on MS-Windows
3845         before XP.
3846
3847         PR gdb/24292
3848         * common/netstuff.c:
3849         * gdbserver/gdbreplay.c
3850         * gdbserver/remote-utils.c:
3851         * ser-tcp.c:
3852         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3853         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3854         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3855         'getaddrinfo' and 'freeaddrinfo' were not available before
3856         Windows XP, and mingw.org's MinGW headers by default define
3857         _WIN32_WINNT to 0x500.
3858
3859 2019-03-01  Gary Benson <gbenson@redhat.com>
3860
3861         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3862
3863 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3864             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3865
3866         PR gdb/8527
3867         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3868         set_sigint_trap, clear_sigint_trap.
3869
3870 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3871
3872         * target.c (target_detach): Clear the regcache and the
3873         frame cache.
3874
3875 2019-02-27  Pedro Alves  <palves@redhat.com>
3876
3877         * utils.c (set_screen_size): When we cap the height/width sizes,
3878         tweak the corresponding command variable to show "unlimited":
3879
3880 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3881             Pedro Alves  <palves@redhat.com>
3882
3883         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3884         before calling rl_set_screen_size.
3885
3886 2019-02-27  Tom Tromey  <tromey@adacore.com>
3887
3888         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3889         define.
3890         * python/py-value.c: Remove Python 2.4 workaround.
3891         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3892         workaround.
3893         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3894         Python 2.4 workaround.
3895         * python/python-internal.h: Remove Python 2.4 comment.
3896         (Py_ssize_t): Don't define.
3897         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3898         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3899         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3900         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3901         * python/python.c (do_start_initialization): Remove Python 2.4
3902         workaround.
3903         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3904         (print_children): Remove Python 2.4 workaround.
3905         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3906         workaround.
3907         (CHARBUFFERPROC_NAME): Remove.
3908         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3909         Python 2.4 workaround.
3910
3911 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3912
3913         * NEWS: Note minimum Python version.
3914
3915 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3916
3917         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3918         code from these functions.  Remove corresponding ifdefs.  Use
3919         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3920         Remove gotos and target of gotos.
3921         (infpy_search_memory): Likewise.
3922
3923 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3924
3925         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3926         (hppa_gdbarch_init): Don't register deleted functions with
3927         gdbarch.
3928
3929 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3930
3931         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3932         (h8300_unwind_sp): Delete.
3933         (h8300_dummy_id): Delete.
3934         (h8300_gdbarch_init): Don't register deleted functions with
3935         gdbarch.
3936
3937 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3938
3939         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3940         (ft32_unwind_pc): Delete.
3941         (ft32_unwind_sp): Delete.
3942         (ft32_gdbarch_init): Don't register deleted functions with
3943         gdbarch.
3944
3945 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3946
3947         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3948         (frv_unwind_pc): Delete.
3949         (frv_unwind_sp): Delete.
3950         (frv_gdbarch_init): Don't register deleted functions with
3951         gdbarch.
3952
3953 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3954
3955         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3956         (riscv_unwind_pc): Delete.
3957         (riscv_unwind_sp): Delete.
3958         (riscv_gdbarch_init): Don't register deleted functions with
3959         gdbarch.
3960
3961 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3962
3963         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3964         (csky_unwind_pc): Delete.
3965         (csky_unwind_sp): Delete.
3966         (csky_gdbarch_init): Don't register deleted functions with
3967         gdbarch.
3968
3969 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3970
3971         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3972         (cris_unwind_pc): Delete.
3973         (cris_unwind_sp): Delete.
3974         (cris_gdbarch_init): Don't register deleted functions with
3975         gdbarch.
3976
3977 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3978
3979         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3980         (bfin_unwind_pc): Delete.
3981         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3982
3983 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3984
3985         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3986         (arm_unwind_pc): Delete.
3987         (arm_unwind_sp): Delete.
3988         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3989
3990 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3991
3992         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3993         (arc_unwind_pc): Delete.
3994         (arc_unwind_sp): Delete.
3995         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3996
3997 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3998
3999         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4000         (alpha_unwind_pc): Delete.
4001         (alpha_gdbarch_init): Don't register deleted functions with
4002         gdbarch.
4003
4004 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4005
4006         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4007         (aarch64_unwind_pc): Delete.
4008         (aarch64_unwind_sp): Delete.
4009         (aarch64_gdbarch_init): Don't register deleted functions with
4010         gdbarch.
4011
4012 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4013
4014         * gdbtypes.c (type_align): Don't consider static members when
4015         computing structure alignment.
4016
4017 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4018
4019         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4020         return 0 for other types.
4021         * arch-utils.c (default_type_align): Always return 0.
4022         * gdbarch.h: Regenerate.
4023         * gdbarch.sh (type_align): Extend comment.
4024         * gdbtypes.c (type_align): Add additional comments, always call
4025         gdbarch_type_align before applying the default rules.
4026         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4027         generic code will then apply a suitable default.
4028         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4029         types, return 0 for other types.
4030
4031 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4032
4033         * NEWS: Create a new section for the next release branch.
4034         Rename the section of the current branch, now that it has
4035         been cut.
4036
4037 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4038
4039         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4040         * version.in: Bump version to 8.3.50.DATE-git.
4041
4042 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4043
4044         * aix-thread.c (ptid_cmp): Remove unused variable.
4045         (get_signaled_thread): Likewise.
4046         (store_regs_user_thread): Likewise.
4047         (store_regs_kernel_thread): Likewise.
4048         (fetch_regs_kernel_thread): Remove shadowed variable.
4049
4050 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4051
4052         * features/riscv/32bit-cpu.xml: Add register numbers.
4053         * features/riscv/32bit-fpu.c: Regenerate.
4054         * features/riscv/32bit-fpu.xml: Add register numbers.
4055         * features/riscv/64bit-cpu.xml: Add register numbers.
4056         * features/riscv/64bit-fpu.c: Regenerate.
4057         * features/riscv/64bit-fpu.xml: Add register numbers.
4058
4059 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4060
4061         * NEWS: Mention two argument form of gdb.Value constructor.
4062         * python/py-value.c (convert_buffer_and_type_to_value): New
4063         function.
4064         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4065         Add support for handling an optional second argument.  Call
4066         convert_buffer_and_type_to_value as appropriate.
4067         * python/python-internal.h (Py_buffer_deleter): New struct.
4068         (Py_buffer_up): New typedef.
4069
4070 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4071
4072         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4073         instead of releasing ownership.
4074
4075 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4076
4077         * dwarf2read.c (open_and_init_dwp_file): Call
4078         elf_numsections instead of bfd_count_sections to initialize
4079         dwp_file->num_sections.
4080
4081 2019-02-25  Tom Tromey  <tromey@adacore.com>
4082
4083         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4084
4085 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4086
4087         * gcore.in: Add '--readnever' option when invoking GDB.
4088
4089 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4090
4091         * MAINTAINERS: Update my email address.
4092
4093 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4094
4095         * build-id.c (build_id_to_debug_bfd_1): New function.
4096         (build_id_to_debug_bfd): Look for separate debug file in
4097         sysroot.
4098
4099 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4100
4101         * gdbarch.sh: Update the copyright year range that is placed into
4102         generated files.
4103
4104 2019-02-22  Keith Seitz  <keiths@redhat.com>
4105
4106         PR symtab/23853
4107         * linespec.c (create_sals_line_offset): Search for the default
4108         symtab's filename instead of its fullname.
4109
4110 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4111
4112         * NEWS: Update style defaults.
4113
4114 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4115
4116         * main.c (captured_main_1): Disable styling in batch mode.
4117
4118 2019-02-20  Tom Tromey  <tom@tromey.com>
4119
4120         * symtab.c (symtab_symbol_info): Fix typos.
4121
4122 2019-02-20  Tom Tromey  <tromey@adacore.com>
4123
4124         * findcmd.c (_initialize_mem_search): Use upper case for
4125         metasyntactic variables.
4126
4127 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4128
4129         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4130         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4131
4132 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4133
4134         * top.h (source_file_name): Change to std::string.
4135         * top.c (source_file_name): Likewise.
4136         (command_line_input): Adjust.
4137         * cli/cli-script.c (script_from_file): Adjust.
4138
4139 2019-02-19  Tom Tromey  <tromey@adacore.com>
4140
4141         * ravenscar-thread.c
4142         (ravenscar_thread_target::update_thread_list): Don't call
4143         ada_build_task_list.
4144         * ada-lang.h (ada_build_task_list): Don't declare.
4145         * ada-tasks.c (struct ada_tasks_inferior_data)
4146         <task_list_valid_p>: Now bool.
4147         (read_known_tasks, ada_task_list_changed)
4148         (ada_tasks_invalidate_inferior_data): Update.
4149         (read_known_tasks_array): Return bool.
4150         (read_known_tasks_list): Likewise.
4151         (read_known_tasks): Return void.
4152         (ada_build_task_list): Now static.
4153
4154 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4155
4156         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4157         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4158
4159 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4160
4161         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4162         variant for ada_tasks_pspace_data_handle and
4163         ada_tasks_inferior_data_handle.
4164         (ada_tasks_pspace_data_cleanup): New function.
4165         (ada_tasks_inferior_data_cleanup): New function.
4166
4167 2019-02-17  Tom Tromey  <tom@tromey.com>
4168
4169         * macrotab.h (macro_source_fullname): Return a std::string.
4170         * macrotab.c (macro_include, check_for_redefinition)
4171         (macro_undef, macro_lookup_definition, foreach_macro)
4172         (foreach_macro_in_scope): Update.
4173         (macro_source_fullname): Return a std::string.
4174         * macrocmd.c (show_pp_source_pos): Update.
4175
4176 2019-02-17  Tom Tromey  <tom@tromey.com>
4177
4178         * macrocmd.c (show_pp_source_pos): Style the file names.
4179
4180 2019-02-17  Tom Tromey  <tom@tromey.com>
4181
4182         PR tui/24197:
4183         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4184
4185 2019-02-17  Tom Tromey  <tom@tromey.com>
4186
4187         * ada-lang.c (user_select_syms): Use filtered printing.
4188         * utils.c (wrap_style): New global.
4189         (desired_style): Remove.
4190         (emit_style_escape): Add stream parameter.
4191         (set_output_style, reset_terminal_style, prompt_for_continue):
4192         Update.
4193         (flush_wrap_buffer): Only flush gdb_stdout.
4194         (wrap_here): Set wrap_style.
4195         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4196         treat escape sequences as a character.  Change when wrap buffer is
4197         flushed.
4198         (fputs_styled): Do not set the output style when the default is
4199         requested.
4200         * ui-style.h (struct ui_file_style) <is_default>: New method.
4201         * source.c (print_source_lines_base): Emit escape sequences in one
4202         piece.
4203
4204 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4205
4206         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4207         integers and enumeration types.
4208
4209 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4210
4211         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4212         instead of lookup_symbol_in_language
4213         (do_exact_match): New function.
4214         (ada_get_symbol_name_matcher): Return do_exact_match when
4215         doing a verbatim match.
4216
4217 2019-02-15  Tom Tromey  <tromey@adacore.com>
4218
4219         * ravenscar-thread.c (ravenscar_thread_target::resume)
4220         (ravenscar_thread_target::wait): Special case wildcard requests.
4221
4222 2019-02-15  Tom Tromey  <tromey@adacore.com>
4223
4224         * ravenscar-thread.c (base_ptid): Remove.
4225         (struct ravenscar_thread_target) <close>: New method.
4226         <m_base_ptid>: New member.
4227         <update_inferior_ptid, active_task, task_is_currently_active,
4228         runtime_initialized>: Declare methods.
4229         <ravenscar_thread_target>: Add constructor.
4230         (ravenscar_thread_target::task_is_currently_active)
4231         (ravenscar_thread_target::update_inferior_ptid)
4232         (ravenscar_runtime_initialized): Rename.  Now methods.
4233         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4234         (ravenscar_thread_target::update_thread_list): Update.
4235         (ravenscar_thread_target::active_task): Now method.
4236         (ravenscar_thread_target::store_registers)
4237         (ravenscar_thread_target::prepare_to_store)
4238         (ravenscar_thread_target::prepare_to_store)
4239         (ravenscar_thread_target::mourn_inferior): Update.
4240         (ravenscar_inferior_created): Use "new" to create target.
4241         (ravenscar_thread_target::get_ada_task_ptid): Update.
4242         (_initialize_ravenscar): Don't initialize base_ptid.
4243         (ravenscar_ops): Remove global.
4244
4245 2019-02-15  Tom Tromey  <tromey@adacore.com>
4246
4247         * target.h (push_target): Declare new overload.
4248         * target.c (push_target): New overload, taking an rvalue reference.
4249         * remote.c (remote_target::open_1): Use push_target overload.
4250         * corelow.c (core_target_open): Use push_target overload.
4251
4252 2019-02-15  Tom Tromey  <tromey@adacore.com>
4253
4254         * ravenscar-thread.c (is_ravenscar_task)
4255         (ravenscar_task_is_currently_active): Return bool.
4256         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4257         (_initialize_ravenscar): Remove "(void)".
4258         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4259         Return bool.
4260
4261 2019-02-15  Tom Tromey  <tromey@adacore.com>
4262
4263         * ravenscar-thread.c (ravenscar_runtime_initializer)
4264         (has_ravenscar_runtime, get_running_thread_id)
4265         (ravenscar_thread_target::resume): Fix indentation.
4266
4267 2019-02-15  Tom Tromey  <tromey@adacore.com>
4268
4269         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4270         from ravenscar_arch_ops.
4271         (sparc_ravenscar_ops::fetch_registers)
4272         (sparc_ravenscar_ops::store_registers): Now methods.
4273         (sparc_ravenscar_prepare_to_store): Remove.
4274         (sparc_ravenscar_ops): Redefine.
4275         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4276         methods and destructor.  Remove members.
4277         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4278         (ravenscar_thread_target::store_registers)
4279         (ravenscar_thread_target::prepare_to_store): Update.
4280         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4281         Remove.
4282         (struct ppc_ravenscar_powerpc_ops): Derive from
4283         ravenscar_arch_ops.
4284         (ppc_ravenscar_powerpc_ops::fetch_registers)
4285         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4286         (ppc_ravenscar_powerpc_ops): Redefine.
4287         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4288         (ppc_ravenscar_e500_ops::fetch_registers)
4289         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4290         (ppc_ravenscar_e500_ops): Redefine.
4291         * aarch64-ravenscar-thread.c
4292         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4293         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4294         (aarch64_ravenscar_fetch_registers)
4295         (aarch64_ravenscar_store_registers): Now methods.
4296         (aarch64_ravenscar_ops): Redefine.
4297
4298 2019-02-15  Tom Tromey  <tromey@adacore.com>
4299
4300         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4301         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4302         (ravenscar_thread_target::stopped_by_watchpoint)
4303         (ravenscar_thread_target::stopped_data_address)
4304         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4305
4306 2019-02-15  Tom Tromey  <tromey@adacore.com>
4307
4308         * ravenscar-thread.c: Fix some typos.
4309
4310 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4311             Tom Tromey  <tromey@adacore.com>
4312
4313         * ada-lang.c (ada_exception_sal): Change addr_string to a
4314         std::string.
4315         (create_ada_exception_catchpoint): Update.
4316
4317 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4318             Tom Tromey  <tromey@adacore.com>
4319
4320         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4321         (bp_location_ops): Remove.
4322         (base_breakpoint_allocate_location): Update.
4323         (free_bp_location): Update.
4324         * ada-lang.c (class ada_catchpoint_location)
4325         <ada_catchpoint_location>: Remove ops parameter.
4326         (ada_catchpoint_location_dtor): Remove.
4327         (ada_catchpoint_location_ops): Remove.
4328         (allocate_location_exception): Update.
4329         * breakpoint.h (struct bp_location_ops): Remove.
4330         (class bp_location) <bp_location>: Remove bp_location_ops
4331         parameter.
4332         <~bp_location>: Add destructor.
4333         <ops>: Remove.
4334
4335 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4336             Pedro Alves  <palves@redhat.com>
4337
4338         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4339         'PATH_MAX'.
4340
4341 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4342             Samuel Thibault  <samuel.thibault@gnu.org>
4343             Thomas Schwinge  <thomas@codesourcery.com>
4344
4345         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4346         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4347
4348 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4349
4350         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4351         (check_empty): Use "const char *".
4352
4353         * gnu-nat.c (gnu_nat_target::detach): Instead of
4354         'detach_inferior (pid)' call
4355         'detach_inferior (find_inferior_pid (pid))'.
4356
4357         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4358         'nat/fork-inferior.o'.
4359         * gnu-nat.c: #include "nat/fork-inferior.h".
4360
4361         * gnu-nat.c (gnu_nat_target::detach): Instead of
4362         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4363         * gnu-nat.h: #include "inf-child.h".
4364         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4365         'i386_gnu_nat_target::fetch_registers'.
4366         (gnu_store_registers): Rename/move to
4367         'i386_gnu_nat_target::store_registers'.
4368
4369         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4370         * gnu-nat.h (mach_thread_info): New function.
4371         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4372
4373         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4374
4375 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4376
4377         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4378
4379 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4380
4381         * windows-nat.c (windows_add_thread): Add new parameter
4382         "main_thread_p" with default value set to false.  Update
4383         function documentation as well as all callers.
4384         (windows_delete_thread): Likewise.
4385         (fake_create_process): Update call to windows_add_thread.
4386         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4387         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4388         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4389         call to windows_delete_thread.
4390
4391 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4392
4393         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4394
4395 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4396
4397         * symfile.c (find_separate_debug_file): Use canonical path of
4398         sysroot with child_path instead of gdb_sysroot if it is valid.
4399
4400 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4401
4402         * symfile.c (find_separate_debug_file): Use child_path to
4403         determine if an object file is under a sysroot.
4404
4405 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4406
4407         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4408         unittests/child-path-selftests.c.
4409         * common/pathstuff.c (child_path): New function.
4410         * common/pathstuff.h (child_path): New prototype.
4411         * unittests/child-path-selftests.c: New file.
4412
4413 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4414
4415         * symfile.c (find_separate_debug_file): Look for separate debug
4416         files in debug directories under the sysroot.
4417
4418 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4419
4420         * symtab.h (struct minimal_symbol data_p): New const method.
4421         (struct minimal_symbol text_p): Likewise.
4422         * symtab.c (output_source_filename): Use file name style
4423         to print file name.
4424         (print_symbol_info): Likewise.
4425         (print_msymbol_info): Use address style to print addresses.
4426         Use function name style to print executable text symbols.
4427         (expand_symtab_containing_pc): Use data_p.
4428         (find_pc_sect_compunit_symtab): Likewise.
4429
4430 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4431
4432         * breakpoint.c (describe_other_breakpoints): Use address style
4433         to print addresses.
4434         (say_where): Likewise.
4435
4436 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4437
4438         * ada-typeprint.c (print_func_type): Print function name
4439         style to print function name.
4440         * c-typeprint.c (c_print_type_1): Likewise.
4441
4442 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4443
4444         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4445         for execve.
4446
4447 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4448
4449         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4450         type_stack.
4451
4452 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4453
4454         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4455         TYPE_CODE_REF types.
4456
4457 2019-02-08  Jim Wilson  <jimw@sifive.com>
4458
4459         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4460         (riscv_linux_fregset): New.
4461         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4462
4463 2019-02-07  Tom Tromey  <tom@tromey.com>
4464
4465         * thread.c (thread_cancel_execution_command): Update.
4466         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4467         methods.
4468         (struct thread_fsm_ops): Remove.
4469         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4470         (thread_fsm_should_stop, thread_fsm_return_value)
4471         (thread_fsm_set_finished, thread_fsm_finished_p)
4472         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4473         Don't declare.
4474         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4475         * infrun.c (clear_proceed_status_thread)
4476         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4477         (print_stop_event): Update.
4478         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4479         Add constructor.
4480         (step_command_fsm_ops): Remove.
4481         (new_step_command_fsm): Remove.
4482         (step_1): Update.
4483         (step_command_fsm::should_stop): Rename from
4484         step_command_fsm_should_stop.
4485         (step_command_fsm::clean_up): Rename from
4486         step_command_fsm_clean_up.
4487         (step_command_fsm::do_async_reply_reason): Rename from
4488         step_command_fsm_async_reply_reason.
4489         (struct until_next_fsm): Inherit from thread_fsm.  Add
4490         constructor.
4491         (until_next_fsm_ops): Remove.
4492         (new_until_next_fsm): Remove.
4493         (until_next_fsm::should_stop): Rename from
4494         until_next_fsm_should_stop.
4495         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4496         (until_next_fsm::do_async_reply_reason): Rename from
4497         until_next_fsm_async_reply_reason.
4498         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4499         constructor.  Change type of breakpoint.
4500         (finish_command_fsm_ops): Remove.
4501         (new_finish_command_fsm): Remove.
4502         (finish_command_fsm::should_stop): Rename from
4503         finish_command_fsm_should_stop.
4504         (finish_command_fsm::clean_up): Rename from
4505         finish_command_fsm_clean_up.
4506         (finish_command_fsm::return_value): Rename from
4507         finish_command_fsm_return_value.
4508         (finish_command_fsm::do_async_reply_reason): Rename from
4509         finish_command_fsm_async_reply_reason.
4510         (finish_command): Update.
4511         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4512         Add constructor.
4513         (call_thread_fsm_ops): Remove.
4514         (call_thread_fsm::call_thread_fsm): Rename from
4515         new_call_thread_fsm.
4516         (call_thread_fsm::should_stop): Rename from
4517         call_thread_fsm_should_stop.
4518         (call_thread_fsm::should_notify_stop): Rename from
4519         call_thread_fsm_should_notify_stop.
4520         (run_inferior_call, call_function_by_hand_dummy): Update.
4521         * cli/cli-interp.c (should_print_stop_to_console): Update.
4522         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4523         Add constructor.  Change type of location_breakpoint,
4524         caller_breakpoint.
4525         (until_break_fsm_ops): Remove.
4526         (new_until_break_fsm): Remove.
4527         (until_break_fsm::should_stop): Rename from
4528         until_break_fsm_should_stop.
4529         (until_break_fsm::clean_up): Rename from
4530         until_break_fsm_clean_up.
4531         (until_break_fsm::do_async_reply_reason): Rename from
4532         until_break_fsm_async_reply_reason.
4533         (until_break_command): Update.
4534         * thread-fsm.c: Remove.
4535         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4536
4537 2019-02-07  Tom Tromey  <tom@tromey.com>
4538
4539         * yy-remap.h: Add include guard.
4540         * xtensa-tdep.h: Add include guard.
4541         * xcoffread.h: Rename include guard.
4542         * varobj-iter.h: Add include guard.
4543         * tui/tui.h: Rename include guard.
4544         * tui/tui-winsource.h: Rename include guard.
4545         * tui/tui-wingeneral.h: Rename include guard.
4546         * tui/tui-windata.h: Rename include guard.
4547         * tui/tui-win.h: Rename include guard.
4548         * tui/tui-stack.h: Rename include guard.
4549         * tui/tui-source.h: Rename include guard.
4550         * tui/tui-regs.h: Rename include guard.
4551         * tui/tui-out.h: Rename include guard.
4552         * tui/tui-layout.h: Rename include guard.
4553         * tui/tui-io.h: Rename include guard.
4554         * tui/tui-hooks.h: Rename include guard.
4555         * tui/tui-file.h: Rename include guard.
4556         * tui/tui-disasm.h: Rename include guard.
4557         * tui/tui-data.h: Rename include guard.
4558         * tui/tui-command.h: Rename include guard.
4559         * tic6x-tdep.h: Add include guard.
4560         * target/waitstatus.h: Rename include guard.
4561         * target/wait.h: Rename include guard.
4562         * target/target.h: Rename include guard.
4563         * target/resume.h: Rename include guard.
4564         * target-float.h: Rename include guard.
4565         * stabsread.h: Add include guard.
4566         * rs6000-tdep.h: Add include guard.
4567         * riscv-fbsd-tdep.h: Add include guard.
4568         * regformats/regdef.h: Rename include guard.
4569         * record.h: Rename include guard.
4570         * python/python.h: Rename include guard.
4571         * python/python-internal.h: Rename include guard.
4572         * python/py-stopevent.h: Rename include guard.
4573         * python/py-ref.h: Rename include guard.
4574         * python/py-record.h: Rename include guard.
4575         * python/py-record-full.h: Rename include guard.
4576         * python/py-record-btrace.h: Rename include guard.
4577         * python/py-instruction.h: Rename include guard.
4578         * python/py-events.h: Rename include guard.
4579         * python/py-event.h: Rename include guard.
4580         * procfs.h: Add include guard.
4581         * proc-utils.h: Add include guard.
4582         * p-lang.h: Add include guard.
4583         * or1k-tdep.h: Rename include guard.
4584         * observable.h: Rename include guard.
4585         * nto-tdep.h: Rename include guard.
4586         * nat/x86-linux.h: Rename include guard.
4587         * nat/x86-linux-dregs.h: Rename include guard.
4588         * nat/x86-gcc-cpuid.h: Add include guard.
4589         * nat/x86-dregs.h: Rename include guard.
4590         * nat/x86-cpuid.h: Rename include guard.
4591         * nat/ppc-linux.h: Rename include guard.
4592         * nat/mips-linux-watch.h: Rename include guard.
4593         * nat/linux-waitpid.h: Rename include guard.
4594         * nat/linux-ptrace.h: Rename include guard.
4595         * nat/linux-procfs.h: Rename include guard.
4596         * nat/linux-osdata.h: Rename include guard.
4597         * nat/linux-nat.h: Rename include guard.
4598         * nat/linux-namespaces.h: Rename include guard.
4599         * nat/linux-btrace.h: Rename include guard.
4600         * nat/glibc_thread_db.h: Rename include guard.
4601         * nat/gdb_thread_db.h: Rename include guard.
4602         * nat/gdb_ptrace.h: Rename include guard.
4603         * nat/fork-inferior.h: Rename include guard.
4604         * nat/amd64-linux-siginfo.h: Rename include guard.
4605         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4606         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4607         * nat/aarch64-linux.h: Rename include guard.
4608         * nat/aarch64-linux-hw-point.h: Rename include guard.
4609         * mn10300-tdep.h: Add include guard.
4610         * mips-linux-tdep.h: Add include guard.
4611         * mi/mi-parse.h: Rename include guard.
4612         * mi/mi-out.h: Rename include guard.
4613         * mi/mi-main.h: Rename include guard.
4614         * mi/mi-interp.h: Rename include guard.
4615         * mi/mi-getopt.h: Rename include guard.
4616         * mi/mi-console.h: Rename include guard.
4617         * mi/mi-common.h: Rename include guard.
4618         * mi/mi-cmds.h: Rename include guard.
4619         * mi/mi-cmd-break.h: Rename include guard.
4620         * m2-lang.h: Add include guard.
4621         * location.h: Rename include guard.
4622         * linux-record.h: Rename include guard.
4623         * linux-nat.h: Add include guard.
4624         * linux-fork.h: Add include guard.
4625         * i386-darwin-tdep.h: Rename include guard.
4626         * hppa-linux-offsets.h: Add include guard.
4627         * guile/guile.h: Rename include guard.
4628         * guile/guile-internal.h: Rename include guard.
4629         * gnu-nat.h: Rename include guard.
4630         * gdb-stabs.h: Rename include guard.
4631         * frv-tdep.h: Add include guard.
4632         * f-lang.h: Add include guard.
4633         * event-loop.h: Add include guard.
4634         * darwin-nat.h: Rename include guard.
4635         * cp-abi.h: Rename include guard.
4636         * config/sparc/nm-sol2.h: Rename include guard.
4637         * config/nm-nto.h: Rename include guard.
4638         * config/nm-linux.h: Add include guard.
4639         * config/i386/nm-i386gnu.h: Rename include guard.
4640         * config/djgpp/nl_types.h: Rename include guard.
4641         * config/djgpp/langinfo.h: Rename include guard.
4642         * compile/gcc-cp-plugin.h: Add include guard.
4643         * compile/gcc-c-plugin.h: Add include guard.
4644         * compile/compile.h: Rename include guard.
4645         * compile/compile-object-run.h: Rename include guard.
4646         * compile/compile-object-load.h: Rename include guard.
4647         * compile/compile-internal.h: Rename include guard.
4648         * compile/compile-cplus.h: Rename include guard.
4649         * compile/compile-c.h: Rename include guard.
4650         * common/xml-utils.h: Rename include guard.
4651         * common/x86-xstate.h: Rename include guard.
4652         * common/version.h: Rename include guard.
4653         * common/vec.h: Rename include guard.
4654         * common/tdesc.h: Rename include guard.
4655         * common/selftest.h: Rename include guard.
4656         * common/scoped_restore.h: Rename include guard.
4657         * common/scoped_mmap.h: Rename include guard.
4658         * common/scoped_fd.h: Rename include guard.
4659         * common/safe-iterator.h: Rename include guard.
4660         * common/run-time-clock.h: Rename include guard.
4661         * common/refcounted-object.h: Rename include guard.
4662         * common/queue.h: Rename include guard.
4663         * common/ptid.h: Rename include guard.
4664         * common/print-utils.h: Rename include guard.
4665         * common/preprocessor.h: Rename include guard.
4666         * common/pathstuff.h: Rename include guard.
4667         * common/observable.h: Rename include guard.
4668         * common/netstuff.h: Rename include guard.
4669         * common/job-control.h: Rename include guard.
4670         * common/host-defs.h: Rename include guard.
4671         * common/gdb_wait.h: Rename include guard.
4672         * common/gdb_vecs.h: Rename include guard.
4673         * common/gdb_unlinker.h: Rename include guard.
4674         * common/gdb_unique_ptr.h: Rename include guard.
4675         * common/gdb_tilde_expand.h: Rename include guard.
4676         * common/gdb_sys_time.h: Rename include guard.
4677         * common/gdb_string_view.h: Rename include guard.
4678         * common/gdb_splay_tree.h: Rename include guard.
4679         * common/gdb_setjmp.h: Rename include guard.
4680         * common/gdb_ref_ptr.h: Rename include guard.
4681         * common/gdb_optional.h: Rename include guard.
4682         * common/gdb_locale.h: Rename include guard.
4683         * common/gdb_assert.h: Rename include guard.
4684         * common/filtered-iterator.h: Rename include guard.
4685         * common/filestuff.h: Rename include guard.
4686         * common/fileio.h: Rename include guard.
4687         * common/environ.h: Rename include guard.
4688         * common/common-utils.h: Rename include guard.
4689         * common/common-types.h: Rename include guard.
4690         * common/common-regcache.h: Rename include guard.
4691         * common/common-inferior.h: Rename include guard.
4692         * common/common-gdbthread.h: Rename include guard.
4693         * common/common-exceptions.h: Rename include guard.
4694         * common/common-defs.h: Rename include guard.
4695         * common/common-debug.h: Rename include guard.
4696         * common/cleanups.h: Rename include guard.
4697         * common/buffer.h: Rename include guard.
4698         * common/btrace-common.h: Rename include guard.
4699         * common/break-common.h: Rename include guard.
4700         * cli/cli-utils.h: Rename include guard.
4701         * cli/cli-style.h: Rename include guard.
4702         * cli/cli-setshow.h: Rename include guard.
4703         * cli/cli-script.h: Rename include guard.
4704         * cli/cli-interp.h: Rename include guard.
4705         * cli/cli-decode.h: Rename include guard.
4706         * cli/cli-cmds.h: Rename include guard.
4707         * charset-list.h: Add include guard.
4708         * buildsym-legacy.h: Rename include guard.
4709         * bfin-tdep.h: Add include guard.
4710         * ax.h: Rename include guard.
4711         * arm-linux-tdep.h: Add include guard.
4712         * arm-fbsd-tdep.h: Add include guard.
4713         * arch/xtensa.h: Rename include guard.
4714         * arch/tic6x.h: Add include guard.
4715         * arch/i386.h: Add include guard.
4716         * arch/arm.h: Rename include guard.
4717         * arch/arm-linux.h: Rename include guard.
4718         * arch/arm-get-next-pcs.h: Rename include guard.
4719         * arch/amd64.h: Add include guard.
4720         * arch/aarch64-insn.h: Rename include guard.
4721         * arch-utils.h: Rename include guard.
4722         * annotate.h: Add include guard.
4723         * amd64-darwin-tdep.h: Rename include guard.
4724         * aarch64-linux-tdep.h: Add include guard.
4725         * aarch64-fbsd-tdep.h: Add include guard.
4726         * aarch32-linux-nat.h: Add include guard.
4727
4728 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4729
4730         * macrotab.c (macro_define_internal): New function that
4731         factorizes macro_define_object_internal and macro_define_function
4732         code.
4733         (macro_define_object_internal): Use macro_define_internal.
4734         (macro_define_function): Likewise.
4735
4736 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4737
4738         * macrocmd.c (extract_identifier): Return
4739         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4740         callers.
4741
4742 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4743
4744         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4745
4746 2019-02-05  Tom Tromey  <tom@tromey.com>
4747
4748         * target.c (target_stack::unpush): Move assertion earlier.
4749
4750 2019-01-30  Tom Tromey  <tom@tromey.com>
4751
4752         PR python/23615:
4753         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4754         (gdbpy_parse_and_eval): Likewise.
4755         * python/python-internal.h (gdbpy_allow_threads): New class.
4756
4757 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4758
4759         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4760         (aarch64_fbsd_fpregmap): Move earlier.
4761         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4762         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4763         instead of individual calls to trad_frame_set_reg_addr.
4764         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4765         earlier.
4766         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4767         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4768         instead of individual calls to trad_frame_set_reg_addr.
4769
4770 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4771
4772         * CONTRIBUTE: Replace contribution list with wiki link.
4773
4774 2019-01-25  Tom Tromey  <tom@tromey.com>
4775
4776         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4777
4778 2019-01-25  Tom Tromey  <tom@tromey.com>
4779
4780         * xtensa-linux-nat.c: Fix common/ includes.
4781         * xml-support.h: Fix common/ includes.
4782         * xml-support.c: Fix common/ includes.
4783         * x86-linux-nat.c: Fix common/ includes.
4784         * windows-nat.c: Fix common/ includes.
4785         * varobj.h: Fix common/ includes.
4786         * varobj.c: Fix common/ includes.
4787         * value.c: Fix common/ includes.
4788         * valops.c: Fix common/ includes.
4789         * utils.c: Fix common/ includes.
4790         * unittests/xml-utils-selftests.c: Fix common/ includes.
4791         * unittests/utils-selftests.c: Fix common/ includes.
4792         * unittests/unpack-selftests.c: Fix common/ includes.
4793         * unittests/tracepoint-selftests.c: Fix common/ includes.
4794         * unittests/style-selftests.c: Fix common/ includes.
4795         * unittests/string_view-selftests.c: Fix common/ includes.
4796         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4797         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4798         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4799         * unittests/rsp-low-selftests.c: Fix common/ includes.
4800         * unittests/parse-connection-spec-selftests.c: Fix common/
4801         includes.
4802         * unittests/optional-selftests.c: Fix common/ includes.
4803         * unittests/offset-type-selftests.c: Fix common/ includes.
4804         * unittests/observable-selftests.c: Fix common/ includes.
4805         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4806         * unittests/memrange-selftests.c: Fix common/ includes.
4807         * unittests/memory-map-selftests.c: Fix common/ includes.
4808         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4809         * unittests/function-view-selftests.c: Fix common/ includes.
4810         * unittests/environ-selftests.c: Fix common/ includes.
4811         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4812         * unittests/common-utils-selftests.c: Fix common/ includes.
4813         * unittests/cli-utils-selftests.c: Fix common/ includes.
4814         * unittests/array-view-selftests.c: Fix common/ includes.
4815         * ui-file.c: Fix common/ includes.
4816         * tui/tui-io.c: Fix common/ includes.
4817         * tracepoint.h: Fix common/ includes.
4818         * tracepoint.c: Fix common/ includes.
4819         * tracefile-tfile.c: Fix common/ includes.
4820         * top.h: Fix common/ includes.
4821         * top.c: Fix common/ includes.
4822         * thread.c: Fix common/ includes.
4823         * target/waitstatus.h: Fix common/ includes.
4824         * target/waitstatus.c: Fix common/ includes.
4825         * target.h: Fix common/ includes.
4826         * target.c: Fix common/ includes.
4827         * target-memory.c: Fix common/ includes.
4828         * target-descriptions.c: Fix common/ includes.
4829         * symtab.h: Fix common/ includes.
4830         * symfile.c: Fix common/ includes.
4831         * stap-probe.c: Fix common/ includes.
4832         * spu-linux-nat.c: Fix common/ includes.
4833         * sparc-nat.c: Fix common/ includes.
4834         * source.c: Fix common/ includes.
4835         * solib.c: Fix common/ includes.
4836         * solib-target.c: Fix common/ includes.
4837         * ser-unix.c: Fix common/ includes.
4838         * ser-tcp.c: Fix common/ includes.
4839         * ser-pipe.c: Fix common/ includes.
4840         * ser-base.c: Fix common/ includes.
4841         * selftest-arch.c: Fix common/ includes.
4842         * s12z-tdep.c: Fix common/ includes.
4843         * rust-exp.y: Fix common/ includes.
4844         * rs6000-aix-tdep.c: Fix common/ includes.
4845         * riscv-tdep.c: Fix common/ includes.
4846         * remote.c: Fix common/ includes.
4847         * remote-notif.h: Fix common/ includes.
4848         * remote-fileio.h: Fix common/ includes.
4849         * remote-fileio.c: Fix common/ includes.
4850         * regcache.h: Fix common/ includes.
4851         * regcache.c: Fix common/ includes.
4852         * record-btrace.c: Fix common/ includes.
4853         * python/python.c: Fix common/ includes.
4854         * python/py-type.c: Fix common/ includes.
4855         * python/py-inferior.c: Fix common/ includes.
4856         * progspace.h: Fix common/ includes.
4857         * producer.c: Fix common/ includes.
4858         * procfs.c: Fix common/ includes.
4859         * proc-api.c: Fix common/ includes.
4860         * printcmd.c: Fix common/ includes.
4861         * ppc-linux-nat.c: Fix common/ includes.
4862         * parser-defs.h: Fix common/ includes.
4863         * osdata.c: Fix common/ includes.
4864         * obsd-nat.c: Fix common/ includes.
4865         * nat/x86-linux.c: Fix common/ includes.
4866         * nat/x86-linux-dregs.c: Fix common/ includes.
4867         * nat/x86-dregs.h: Fix common/ includes.
4868         * nat/x86-dregs.c: Fix common/ includes.
4869         * nat/ppc-linux.c: Fix common/ includes.
4870         * nat/mips-linux-watch.h: Fix common/ includes.
4871         * nat/mips-linux-watch.c: Fix common/ includes.
4872         * nat/linux-waitpid.c: Fix common/ includes.
4873         * nat/linux-ptrace.h: Fix common/ includes.
4874         * nat/linux-ptrace.c: Fix common/ includes.
4875         * nat/linux-procfs.c: Fix common/ includes.
4876         * nat/linux-personality.c: Fix common/ includes.
4877         * nat/linux-osdata.c: Fix common/ includes.
4878         * nat/linux-namespaces.c: Fix common/ includes.
4879         * nat/linux-btrace.h: Fix common/ includes.
4880         * nat/linux-btrace.c: Fix common/ includes.
4881         * nat/fork-inferior.c: Fix common/ includes.
4882         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4883         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4884         * nat/aarch64-linux.c: Fix common/ includes.
4885         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4886         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4887         * namespace.h: Fix common/ includes.
4888         * mips-linux-tdep.c: Fix common/ includes.
4889         * minsyms.c: Fix common/ includes.
4890         * mi/mi-parse.h: Fix common/ includes.
4891         * mi/mi-main.c: Fix common/ includes.
4892         * mi/mi-cmd-env.c: Fix common/ includes.
4893         * memrange.h: Fix common/ includes.
4894         * memattr.c: Fix common/ includes.
4895         * maint.h: Fix common/ includes.
4896         * maint.c: Fix common/ includes.
4897         * main.c: Fix common/ includes.
4898         * machoread.c: Fix common/ includes.
4899         * location.c: Fix common/ includes.
4900         * linux-thread-db.c: Fix common/ includes.
4901         * linux-nat.c: Fix common/ includes.
4902         * linux-fork.c: Fix common/ includes.
4903         * inline-frame.c: Fix common/ includes.
4904         * infrun.c: Fix common/ includes.
4905         * inflow.c: Fix common/ includes.
4906         * inferior.h: Fix common/ includes.
4907         * inferior.c: Fix common/ includes.
4908         * infcmd.c: Fix common/ includes.
4909         * inf-ptrace.c: Fix common/ includes.
4910         * inf-child.c: Fix common/ includes.
4911         * ia64-linux-nat.c: Fix common/ includes.
4912         * i387-tdep.c: Fix common/ includes.
4913         * i386-tdep.c: Fix common/ includes.
4914         * i386-linux-tdep.c: Fix common/ includes.
4915         * i386-linux-nat.c: Fix common/ includes.
4916         * i386-go32-tdep.c: Fix common/ includes.
4917         * i386-fbsd-tdep.c: Fix common/ includes.
4918         * i386-fbsd-nat.c: Fix common/ includes.
4919         * guile/scm-type.c: Fix common/ includes.
4920         * guile/guile.c: Fix common/ includes.
4921         * go32-nat.c: Fix common/ includes.
4922         * gnu-nat.c: Fix common/ includes.
4923         * gdbthread.h: Fix common/ includes.
4924         * gdbarch-selftests.c: Fix common/ includes.
4925         * gdb_usleep.c: Fix common/ includes.
4926         * gdb_select.h: Fix common/ includes.
4927         * gdb_bfd.c: Fix common/ includes.
4928         * gcore.c: Fix common/ includes.
4929         * fork-child.c: Fix common/ includes.
4930         * findvar.c: Fix common/ includes.
4931         * fbsd-nat.c: Fix common/ includes.
4932         * event-top.c: Fix common/ includes.
4933         * event-loop.c: Fix common/ includes.
4934         * dwarf2read.c: Fix common/ includes.
4935         * dwarf2loc.c: Fix common/ includes.
4936         * dwarf2-frame.c: Fix common/ includes.
4937         * dwarf-index-cache.c: Fix common/ includes.
4938         * dtrace-probe.c: Fix common/ includes.
4939         * disasm-selftests.c: Fix common/ includes.
4940         * defs.h: Fix common/ includes.
4941         * csky-tdep.c: Fix common/ includes.
4942         * cp-valprint.c: Fix common/ includes.
4943         * cp-support.h: Fix common/ includes.
4944         * cp-support.c: Fix common/ includes.
4945         * corelow.c: Fix common/ includes.
4946         * completer.h: Fix common/ includes.
4947         * completer.c: Fix common/ includes.
4948         * compile/compile.c: Fix common/ includes.
4949         * compile/compile-loc2c.c: Fix common/ includes.
4950         * compile/compile-cplus-types.c: Fix common/ includes.
4951         * compile/compile-cplus-symbols.c: Fix common/ includes.
4952         * command.h: Fix common/ includes.
4953         * cli/cli-dump.c: Fix common/ includes.
4954         * cli/cli-cmds.c: Fix common/ includes.
4955         * charset.c: Fix common/ includes.
4956         * build-id.c: Fix common/ includes.
4957         * btrace.h: Fix common/ includes.
4958         * btrace.c: Fix common/ includes.
4959         * breakpoint.h: Fix common/ includes.
4960         * breakpoint.c: Fix common/ includes.
4961         * ax.h:
4962         (enum agent_op): Fix common/ includes.
4963         * ax-general.c (struct aop_map): Fix common/ includes.
4964         * ax-gdb.c: Fix common/ includes.
4965         * auxv.c: Fix common/ includes.
4966         * auto-load.c: Fix common/ includes.
4967         * arm-tdep.c: Fix common/ includes.
4968         * arch/riscv.c: Fix common/ includes.
4969         * arch/ppc-linux-common.c: Fix common/ includes.
4970         * arch/i386.c: Fix common/ includes.
4971         * arch/arm.c: Fix common/ includes.
4972         * arch/arm-linux.c: Fix common/ includes.
4973         * arch/arm-get-next-pcs.c: Fix common/ includes.
4974         * arch/amd64.c: Fix common/ includes.
4975         * arch/aarch64.c: Fix common/ includes.
4976         * arch/aarch64-insn.c: Fix common/ includes.
4977         * arch-utils.c: Fix common/ includes.
4978         * amd64-windows-tdep.c: Fix common/ includes.
4979         * amd64-tdep.c: Fix common/ includes.
4980         * amd64-sol2-tdep.c: Fix common/ includes.
4981         * amd64-obsd-tdep.c: Fix common/ includes.
4982         * amd64-nbsd-tdep.c: Fix common/ includes.
4983         * amd64-linux-tdep.c: Fix common/ includes.
4984         * amd64-linux-nat.c: Fix common/ includes.
4985         * amd64-fbsd-tdep.c: Fix common/ includes.
4986         * amd64-fbsd-nat.c: Fix common/ includes.
4987         * amd64-dicos-tdep.c: Fix common/ includes.
4988         * amd64-darwin-tdep.c: Fix common/ includes.
4989         * agent.c: Fix common/ includes.
4990         * ada-lang.h: Fix common/ includes.
4991         * ada-lang.c: Fix common/ includes.
4992         * aarch64-tdep.c: Fix common/ includes.
4993
4994 2019-01-25  Tom Tromey  <tom@tromey.com>
4995
4996         * common/create-version.sh: Use common/version.h.
4997
4998 2019-01-24  Pedro Alves  <palves@redhat.com>
4999
5000         * infrun.c (signal_stop, signal_print, signal_program)
5001         (signal_catch, signal_pass): Now arrays instead of pointers.
5002         (update_signals_program_target, do_target_resume)
5003         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5004         * linux-nat.c (linux_nat_target::pass_signals)
5005         (linux_nat_target::create_inferior, linux_nat_target::attach):
5006         Adjust.
5007         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5008         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5009         * procfs.c (procfs_target::pass_signals): Adjust.
5010         * record-full.c (record_full_target::resume): Adjust.
5011         * remote.c (remote_target::pass_signals)
5012         (remote_target::program_signals): Adjust.
5013         * target-debug.h (target_debug_print_signals): Now takes a
5014         gdb::array_view as parameter.  Adjust.
5015         * target.h (target_ops) <pass_signals, program_signals>: Replace
5016         pointer and length parameters with gdb::array_view.
5017         (target_pass_signals, target_program_signals): Likewise.
5018         * target-delegates.c: Regenerate.
5019
5020 2019-01-24  Pedro Alves  <palves@redhat.com>
5021
5022         * common/forward-scope-exit.h
5023         (forward_scope_exit::forward_scope_exit): Pass arguments to
5024         m_bind_function directly, instead of creating a std::bind and
5025         copying that.
5026
5027 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5028
5029         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5030         for static members.
5031         (pass_in_v_vfp_candidate): Likewise.
5032
5033 2019-01-23  Tom Tromey  <tom@tromey.com>
5034             Pedro Alves  <palves@redhat.com>
5035
5036         * regcache.c (class regcache_invalidator): Remove.
5037         (regcache::raw_write): Use make_scope_exit.
5038
5039 2019-01-23  Tom Tromey  <tom@tromey.com>
5040
5041         * ui-out.h (class ui_out_emit_type): Update comment.
5042
5043 2019-01-23  Tom Tromey  <tom@tromey.com>
5044
5045         * infrun.c (fetch_inferior_event): Update comment.
5046
5047 2019-01-23  Tom Tromey  <tom@tromey.com>
5048             Pedro Alves  <palves@redhat.com>
5049
5050         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5051         parameter.
5052         (fetch_inferior_event): Use SCOPE_EXIT.
5053
5054
5055 2019-01-23  Tom Tromey  <tom@tromey.com>
5056             Pedro Alves  <palves@redhat.com>
5057
5058         * infrun.c (disable_thread_events): Delete.
5059         (stop_all_threads): Use SCOPE_EXIT.
5060
5061 2019-01-23  Tom Tromey  <tom@tromey.com>
5062             Pedro Alves  <palves@redhat.com>
5063
5064         * symfile.c: Include forward-scope-exit.h.
5065         (clear_symtab_users_cleanup): Replace forward declaration with
5066         a FORWARD_SCOPE_EXIT.
5067         (syms_from_objfile_1): Use the forward_scope_exit and
5068         gdb::optional instead of cleanup_function.
5069         (reread_symbols): Use the forward_scope_exit instead of
5070         cleanup_function.
5071         (clear_symtab_users_cleanup): Remove function.
5072
5073 2019-01-23  Tom Tromey  <tom@tromey.com>
5074             Pedro Alves  <palves@redhat.com>
5075
5076         * linux-nat.c: Include scope-exit.h.
5077         (cleanup_target_stop): Remove.
5078         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5079         SCOPE_EXIT.
5080
5081 2019-01-23  Tom Tromey  <tom@tromey.com>
5082             Pedro Alves  <palves@redhat.com>
5083
5084         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5085         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5086
5087 2019-01-23  Tom Tromey  <tom@tromey.com>
5088             Andrew Burgess  <andrew.burgess@embecosm.com>
5089             Pedro Alves  <palves@redhat.com>
5090
5091         * infrun.c (fetch_inferior_event): Use scope_exit.
5092         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5093         * top.c (execute_command): Use scope_exit.
5094         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5095         * utils.c (do_bpstat_clear_actions_cleanup)
5096         (make_bpstat_clear_actions_cleanup): Remove.
5097
5098 2019-01-23  Tom Tromey  <tom@tromey.com>
5099             Pedro Alves  <palves@redhat.com>
5100
5101         * infrun.c: Include "common/scope-exit.h"
5102         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5103         (wait_for_inferior): Use SCOPE_EXIT.
5104         (fetch_inferior_event): Use scope_exit.
5105
5106 2019-01-23  Tom Tromey  <tom@tromey.com>
5107             Pedro Alves  <palves@redhat.com>
5108
5109         * breakpoint.c (create_breakpoint): Remove cleanup.
5110
5111 2019-01-23  Tom Tromey  <tom@tromey.com>
5112             Andrew Burgess  <andrew.burgess@embecosm.com>
5113             Pedro Alves  <palves@redhat.com>
5114
5115 2019-01-23  Pedro Alves  <palves@redhat.com>
5116
5117         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5118
5119 2019-01-23  Pedro Alves  <palves@redhat.com>
5120             Andrew Burgess  <andrew.burgess@embecosm.com>
5121
5122         * gdbthread.h: Include "common/forward-scope-exit.h".
5123         (scoped_finish_thread_state): Redefine custom class in terms of
5124         forward_scope_exit.
5125
5126 2019-01-23  Pedro Alves  <palves@redhat.com>
5127             Andrew Burgess  <andrew.burgess@embecosm.com>
5128
5129         * common/forward-scope-exit.h: New file.
5130
5131 2019-01-23  Pedro Alves  <palves@redhat.com>
5132             Andrew Burgess  <andrew.burgess@embecosm.com>
5133             Tom Tromey  <tom@tromey.com>
5134
5135         * common/scope-exit.h: New file.
5136
5137 2019-01-23  Pedro Alves  <palves@redhat.com>
5138
5139         * common/preprocessor.h (ESC): Rename to ...
5140         (ESC_PARENS): ... this.
5141         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5142         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5143
5144 2019-01-23  Tom Tromey  <tom@tromey.com>
5145
5146         * language.h (class scoped_switch_to_sym_language_if_auto):
5147         Initialize m_lang in both cases.
5148
5149 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5150
5151         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5152         with XCNEW.
5153
5154 2019-01-22  Tom Tromey  <tom@tromey.com>
5155
5156         * corelow.c: Do not include sys/file.h.
5157
5158 2019-01-22  Tom Tromey  <tom@tromey.com>
5159
5160         * tui/tui-wingeneral.h: Include gdb_curses.h.
5161
5162 2019-01-22  Tom Tromey  <tom@tromey.com>
5163
5164         * source-cache.h (class source_cache) <get_source_lines,
5165         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5166
5167 2019-01-22  Tom Tromey  <tom@tromey.com>
5168
5169         * remote-fileio.h (struct remote_target): Declare.
5170
5171 2019-01-22  Tom Tromey  <tom@tromey.com>
5172
5173         * python/py-arch.c: Do not include py-ref.h.
5174         * python/py-bpevent.c: Do not include py-ref.h.
5175         * python/py-cmd.c: Do not include py-ref.h.
5176         * python/py-continueevent.c: Do not include py-ref.h.
5177         * python/py-event.h: Do not include py-ref.h.
5178         * python/py-evtregistry.c: Do not include py-ref.h.
5179         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5180         * python/py-frame.c: Do not include py-ref.h.
5181         * python/py-framefilter.c: Do not include py-ref.h.
5182         * python/py-function.c: Do not include py-ref.h.
5183         * python/py-infevents.c: Do not include py-ref.h.
5184         * python/py-linetable.c: Do not include py-ref.h.
5185         * python/py-objfile.c: Do not include py-ref.h.
5186         * python/py-param.c: Do not include py-ref.h.
5187         * python/py-prettyprint.c: Do not include py-ref.h.
5188         * python/py-progspace.c: Do not include py-ref.h.
5189         * python/py-symbol.c: Do not include py-ref.h.
5190         * python/py-symtab.c: Do not include py-ref.h.
5191         * python/py-type.c: Do not include py-ref.h.
5192         * python/py-unwind.c: Do not include py-ref.h.
5193         * python/py-utils.c: Do not include py-ref.h.
5194         * python/py-value.c: Do not include py-ref.h.
5195         * python/py-varobj.c: Do not include py-ref.h.
5196         * python/py-xmethods.c: Do not include py-ref.h.
5197         * python/python.c: Do not include py-ref.h.
5198         * varobj.c: Do not include py-ref.h.
5199
5200 2019-01-22  Tom Tromey  <tom@tromey.com>
5201
5202         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5203         keyword for bcache.
5204
5205 2019-01-22  Tom Tromey  <tom@tromey.com>
5206
5207         * compile/compile-cplus-types.c: Remove a comment by #include.
5208
5209 2019-01-22  Tom Tromey  <tom@tromey.com>
5210
5211         * compile/gcc-c-plugin.h: Include compile-internal.h.
5212
5213 2019-01-22  Tom Tromey  <tom@tromey.com>
5214
5215         * stabsread.c (EXTERN): Do not define.
5216         (symnum, next_symbol_text_func, processing_gcc_compilation)
5217         (within_function, global_sym_chain, global_stabs)
5218         (previous_stab_code, this_object_header_files)
5219         (n_this_object_header_files)
5220         (n_allocated_this_object_header_files): Define.
5221         * stabsread.h (EXTERN): Never define.  Use "extern".
5222
5223 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5224
5225         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5226         history_value.
5227
5228 2019-01-21  Tom Tromey  <tom@tromey.com>
5229
5230         * ui-out.c: Fix includes.
5231         * tui/tui-source.c: Fix includes.
5232         * target.c: Fix includes.
5233         * remote.c: Fix includes.
5234         * regcache.c: Fix includes.
5235         * python/py-block.c: Fix includes.
5236         * printcmd.c: Fix includes.
5237         * or1k-tdep.c: Fix includes.
5238         * mi/mi-main.c: Fix includes.
5239         * m32r-tdep.c: Fix includes.
5240         * csky-tdep.c: Fix includes.
5241         * compile/compile-cplus-types.c: Fix includes.
5242         * cli/cli-interp.c: Fix includes.
5243
5244 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5245
5246         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5247         for padding.
5248
5249 2019-01-16  Tom Tromey  <tom@tromey.com>
5250
5251         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5252         earlier.
5253         (struct objfile) <msymbols_range>: Move from top level.
5254         <msymbols>: New method.
5255         (class objfile_msymbols): Remove.
5256         * symtab.c (default_collect_symbol_completion_matches_break_on):
5257         Update.
5258         * symmisc.c (dump_msymbols): Update.
5259         * stabsread.c (scan_file_globals): Update.
5260         * objc-lang.c (info_selectors_command, info_classes_command)
5261         (find_methods): Update.
5262         * minsyms.c (find_solib_trampoline_target): Update.
5263         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5264         * coffread.c (coff_symfile_read): Update.
5265         * ada-lang.c (ada_lookup_simple_minsym)
5266         (ada_collect_symbol_completion_matches): Update.
5267
5268 2019-01-16  Tom Tromey  <tom@tromey.com>
5269
5270         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5271         type.  Remove no-argument constructor.
5272         <iterator::operator++>: Simplify.
5273         <begin>: Update.
5274         <end>: Use minimal_symbol_count.
5275
5276 2019-01-16  Tom Tromey  <tom@tromey.com>
5277
5278         * objfiles.h (struct objfile) <psymtabs>: New method.
5279         (class objfile_psymtabs): Remove.
5280         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5281         typedef.
5282         <range>: New method.
5283         (require_partial_symbols): Change return type.
5284         * psymtab.c (require_partial_symbols)
5285         (psym_expand_symtabs_matching): Update.
5286         * mdebugread.c (parse_partial_symbols): Update.
5287         * dbxread.c (dbx_end_psymtab): Update.
5288
5289 2019-01-15  Tom Tromey  <tom@tromey.com>
5290
5291         * symtab.c (lookup_objfile_from_block)
5292         (lookup_symbol_in_objfile_symtabs)
5293         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5294         (find_line_symtab, info_sources_command)
5295         (default_collect_symbol_completion_matches_break_on)
5296         (make_source_files_completion_list): Update.
5297         * symmisc.c (print_objfile_statistics, dump_objfile)
5298         (maintenance_print_symbols, maintenance_info_symtabs)
5299         (maintenance_check_symtabs, maintenance_info_line_tables):
5300         Update.
5301         * source.c (select_source_symtab)
5302         (forget_cached_source_info_for_objfile): Update.
5303         * objfiles.h (class objfile_compunits): Remove.
5304         (struct objfile) <compunits_range>: New typedef.
5305         (compunits): New method.
5306         * objfiles.c (objfile_relocate1): Update.
5307         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5308         * maint.c (count_symtabs_and_blocks): Update.
5309         * linespec.c (iterate_over_all_matching_symtabs): Update.
5310         * cp-support.c (add_symbol_overload_list_qualified): Update.
5311         * coffread.c (coff_symtab_read): Update.
5312         * ada-lang.c (add_nonlocal_symbols)
5313         (ada_collect_symbol_completion_matches)
5314         (ada_add_global_exceptions): Update.
5315
5316 2019-01-15  Tom Tromey  <tom@tromey.com>
5317
5318         * progspace.h (program_space) <objfiles_safe_range>: New
5319         typedef.
5320         <objfiles_safe>: New method.
5321         * objfiles.h (class all_objfiles_safe): Remove.
5322         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5323         * jit.c (jit_inferior_exit_hook): Update.
5324
5325 2019-01-17  Tom Tromey  <tom@tromey.com>
5326
5327         * progspace.h (program_space) <objfiles_range>: New typedef.
5328         <objfiles>: New method.
5329         <objfiles_head>: Rename from objfiles.
5330         (object_files): Update.
5331         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5332         * guile/scm-pretty-print.c
5333         (ppscm_find_pretty_printer_from_objfiles): Update.
5334         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5335         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5336         Update.
5337         * python/py-progspace.c (pspy_get_objfiles): Update.
5338         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5339         Update.
5340         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5341         (objfpy_lookup_objfile_by_build_id): Update.
5342         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5343         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5344         Update.
5345         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5346         (expand_symtab_containing_pc, lookup_objfile_from_block)
5347         (lookup_static_symbol, basic_lookup_transparent_type)
5348         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5349         (find_line_symtab, info_sources_command)
5350         (default_collect_symbol_completion_matches_break_on)
5351         (make_source_files_completion_list, find_main_name): Update.
5352         * symmisc.c (print_symbol_bcache_statistics)
5353         (print_objfile_statistics, maintenance_print_symbols)
5354         (maintenance_print_msymbols, maintenance_print_objfiles)
5355         (maintenance_info_symtabs, maintenance_check_symtabs)
5356         (maintenance_expand_symtabs, maintenance_info_line_tables):
5357         Update.
5358         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5359         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5360         (map_overlay_command, unmap_overlay_command)
5361         (simple_overlay_update, expand_symtabs_matching)
5362         (map_symbol_filenames): Update.
5363         * symfile-debug.c (set_debug_symfile): Update.
5364         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5365         Update.
5366         * source.c (select_source_symtab, forget_cached_source_info):
5367         Update.
5368         * solib.c (solib_read_symbols): Update.
5369         * solib-spu.c (append_ocl_sos): Update.
5370         * psymtab.c (maintenance_print_psymbols)
5371         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5372         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5373         * printcmd.c (info_symbol_command): Update.
5374         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5375         Update.
5376         * objfiles.h (class all_objfiles): Remove.
5377         * objfiles.c (have_partial_symbols, have_full_symbols)
5378         (have_minimal_symbols, qsort_cmp, update_section_map)
5379         (shared_objfile_contains_address_p)
5380         (default_iterate_over_objfiles_in_search_order): Update.
5381         * objc-lang.c (info_selectors_command, info_classes_command)
5382         (find_methods): Update.
5383         * minsyms.c (find_solib_trampoline_target): Update.
5384         * maint.c (maintenance_info_sections)
5385         (maintenance_translate_address, count_symtabs_and_blocks):
5386         Update.
5387         * main.c (captured_main_1): Update.
5388         * linux-thread-db.c (try_thread_db_load_from_pdir)
5389         (has_libpthread): Update.
5390         * linespec.c (iterate_over_all_matching_symtabs)
5391         (search_minsyms_for_name): Update.
5392         * jit.c (jit_find_objf_with_entry_addr): Update.
5393         * hppa-tdep.c (find_unwind_entry)
5394         (hppa_lookup_stub_minimal_symbol): Update.
5395         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5396         Update.
5397         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5398         (elf_gnu_ifunc_resolve_by_got): Update.
5399         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5400         * dwarf-index-write.c (save_gdb_index_command): Update.
5401         * cp-support.c (add_symbol_overload_list_qualified): Update.
5402         * breakpoint.c (create_overlay_event_breakpoint)
5403         (create_longjmp_master_breakpoint)
5404         (create_std_terminate_master_breakpoint)
5405         (create_exception_master_breakpoint): Update.
5406         * blockframe.c (find_pc_partial_function): Update.
5407         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5408         (ada_collect_symbol_completion_matches)
5409         (ada_add_global_exceptions): Update.
5410
5411 2019-01-17  Tom Tromey  <tom@tromey.com>
5412
5413         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5414         declare VEC.
5415         (solib_target_parse_libraries): Change return type.
5416         (library_list_start_segment, library_list_start_section)
5417         (library_list_end_library, library_list_start_library); Update.
5418         (solib_target_free_library_list): Remove.
5419         (solib_target_parse_libraries): Remove cleanup.  Change return
5420         type.
5421         (solib_target_current_sos): Update.
5422
5423 2019-01-17  Tom Tromey  <tromey@bapiya>
5424
5425         * valprint.c: Replace "the the" with "the".
5426         * symtab.c: Replace "the the" with "the".
5427         * solib.c: Replace "the the" with "the".
5428         * solib-dsbt.c: Replace "the the" with "the".
5429         * linespec.c: Replace "the the" with "the".
5430         * dwarf2loc.h: Replace "the the" with "the".
5431         * amd64-windows-tdep.c: Replace "the the" with "the".
5432         * aarch64-tdep.c: Replace "the the" with "the".
5433
5434 2019-01-16  Keith Seitz  <keiths@redhat.com>
5435
5436         PR gdb/23773
5437         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5438         <builder>: Rename to ..
5439         <m_builder>: ... this and make private.
5440         (dwarf2_cu::get_builder): New method.  Change all users of
5441         `builder' to use this method.
5442         (dwarf2_start_symtab): Move to ...
5443         (dwarf2_cu::start_symtab): ... here.  Update all callers
5444         (setup_type_unit_groups): Move to ...
5445         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5446         callers.
5447         (dwarf2_cu::reset_builder): New method.
5448         (process_full_compunit, process_full_type_unit): Use
5449         dwarf2_cu::reset_builder.
5450         (follow_die_offset): Record the ancestor CU if it is different
5451         from the followed DIE's CU.
5452         (follow_die_sig_1): Likewise.
5453
5454 2019-01-15  Tom Tromey  <tom@tromey.com>
5455
5456         * remote.c (class remote_state) <buf>: Now a char_vector.
5457         <buf_size>: Remove.
5458         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5459         parameter.
5460         (remote_target::getpkt_or_notif_sane_1)
5461         (remote_target::getpkt_sane)
5462         (remote_target::getpkt_or_notif_sane): Likewise.
5463         (class remote_target) <putpkt>: New overload.
5464         (remote_target::read_frame): Change type of "buf_p".  Remove
5465         sizeof_p parameter.
5466         (packet_ok): New overload.
5467         (packet_check_result): New overload.
5468         Update all uses.
5469
5470 2019-01-14  Tom Tromey  <tom@tromey.com>
5471
5472         * remote-notif.c (handle_notification, remote_notif_ack)
5473         (remote_notif_parse): Make "buf" const.
5474         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5475         const.
5476         (remote_notif_parse, remote_notif_ack, handle_notification):
5477         Likewise.
5478         * remote.c (remote_notif_stop_parse): Make "buf" const.
5479         (remote_target::remote_parse_stop_reply): Make "buf" const.
5480         (remote_notif_stop_ack): Make "buf" const.
5481
5482 2019-01-14  Tom Tromey  <tom@tromey.com>
5483
5484         * remote.c (remote_console_output): Make parameter const.
5485
5486 2019-01-14  Tom Tromey  <tom@tromey.com>
5487
5488         * target-debug.h (target_debug_print_signals): Constify.
5489         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5490         * procfs.c (procfs_target::pass_signals): Update.
5491         * linux-nat.c (linux_nat_target::pass_signals): Update.
5492         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5493         * target-delegates.c: Rebuild.
5494         * remote.c (remote_target::program_signals): Update.
5495         (remote_target::pass_signals): Update.
5496         * target.c (target_pass_signals): Constify argument.
5497         (target_program_signals): Likewise.
5498         * target.h (struct target_ops) <pass_signals, program_signals>:
5499         Constify argument.
5500         (target_pass_signals, target_program_signals): Constify argument.
5501
5502 2019-01-14  Tom Tromey  <tom@tromey.com>
5503
5504         PR tui/28819:
5505         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5506
5507 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5508
5509         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5510         field.
5511         * rs6000-tdep.c: Include reggroups.h.
5512         (IS_V_ALIAS_PSEUDOREG): Define.
5513         (rs6000_register_name): Return names for the "vX" aliases.
5514         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5515         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5516         aliases.  Call default_register_reggroup_p for all other
5517         pseudo-registers.
5518         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5519         New functions.
5520         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5521         Handle "vX" aliases.
5522         (v_alias_pseudo_register_collect): New function.
5523         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5524         (rs6000_gdbarch_init): Initialize "vX" aliases as
5525         pseudo-registers.  Restore registration of
5526         rs6000_pseudo_register_reggroup_p with
5527         set_tdesc_pseudo_register_reggroup_p.
5528
5529 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5530
5531         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5532         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5533         set_gdbarch_num_pseudo_regs.
5534
5535 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5536
5537         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5538         Remove arg prefixname, add do_set and do_show.
5539         Add member functions set_list and show_list.
5540         * cli/cli-style.c (class cli_style_option): Update accordingly.
5541         (style_set_list): Move to file scope.
5542         (style_show_list): Likewise.
5543         (set_style): Call help_list.
5544         (show_style): Call cmd_show_list.
5545         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5546         Update to use the new macro.
5547
5548 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5549
5550         * ada-lang.c (_initialize_ada_language): Expand the help text
5551         for the "catch exception" command.
5552
5553 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5554
5555         * symtab.c (matching_obj_sections): Initialize obj,
5556         declare it closer to its usage.
5557
5558 2019-01-10  Tom Tromey  <tom@tromey.com>
5559
5560         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5561         (basic_inf_threads_range): Remove.
5562         (inf_threads_range, inf_non_exited_threads_range)
5563         (safe_inf_threads_range): Use next_adapter.
5564
5565 2019-01-10  Keith Seitz  <keiths@redhat.com>
5566
5567         PR gdb/23712
5568         PR symtab/23010
5569         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5570         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5571
5572 2019-01-10  Keith Seitz  <keiths@redhat.com>
5573
5574         PR gdb/23712
5575         PR symtab/23010
5576         * dictionary.c (pending_to_vector): Remove.
5577         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5578         Remove _1 suffix, replacing functions of the same name.  Update
5579         all callers.
5580         (dict_create_hashed, dict_create_hashed_expandable)
5581         (dict_create_linear, dict_create_linear_expandable, dict_free)
5582         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5583         Make functions static.
5584
5585 2019-01-10  Keith Seitz  <keiths@redhat.com>
5586
5587         PR gdb/23712
5588         PR symtab/23010
5589         * dictionary.h (struct dictionary): Replace declaration with
5590         multidictionary.
5591         (dict_create_hashed, dict_create_hashed_expandable)
5592         (dict_create_linear, dict_create_linear_expandable)
5593         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5594         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5595         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5596         taking multidictionary argument.
5597         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5598         * block.h (struct block) <dict>: Change to multidictionary
5599         and rename `multidict'.
5600         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5601         symmisc.c: Update all dictionary references to multidictionary.
5602
5603 2019-01-10  Keith Seitz  <keiths@redhat.com>
5604
5605         PR gdb/23712
5606         PR symtab/23010
5607         * dictionary.c: Include unordered_map.
5608         (pending_to_vector): New function.
5609         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5610         Rewrite the non-"_1" functions to take vector instead
5611         of linked list.
5612         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5613         "new" _1 versions of the same name.
5614         (multidictionary): Define.
5615         (std::hash<enum language): New definition.
5616         (collate_pending_symbols_by_language, mdict_create_hashed)
5617         (mdict_create_hashed_expandable, mdict_create_linear)
5618         (mdict_create_linear_expandable, mdict_free)
5619         (find_language_dictionary, create_new_language_dictionary)
5620         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5621         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5622         (mdict_size, mdict_empty): New functions.
5623         * dictionary.h (mdict_iterator): Define.
5624
5625 2019-01-10  Pedro Alves  <palves@redhat.com>
5626
5627         * breakpoint.c (read_uploaded_action)
5628         (create_tracepoint_from_upload): Adjust to use
5629         gdb::unique_xmalloc_ptr.
5630         * ctf.c (ctf_write_uploaded_tp):
5631         (SET_ARRAY_FIELD): Use emplace_back.
5632         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5633         * tracefile-tfile.c (tfile_write_uploaded_tp):
5634         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5635         gdb::unique_xmalloc_ptr.
5636         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5637         at_string, cond_string, cmd_strings>: Replace char pointers
5638         with gdb::unique_xmalloc_ptr.
5639
5640 2019-01-10  Pedro Alves  <palves@redhat.com>
5641
5642         * solib-target.c (library_list_start_library): Don't xstrdup name.
5643
5644 2019-01-10  Pedro Alves  <palves@redhat.com>
5645
5646         * mdebugread.c (parse_partial_symbols): Use
5647         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5648
5649 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5650
5651         * linux-fork.c (scoped_switch_fork_info)
5652         <~scoped_switch_fork_info>: Fix incorrect variable name.
5653
5654 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5655
5656         * linux-fork.c (scoped_switch_fork_info)
5657         <scoped_switch_fork_info>: Make explicit.
5658         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5659
5660 2019-01-10  Tom Tromey  <tom@tromey.com>
5661
5662         * objfiles.h (objfile::reset_psymtabs): Update.
5663         * objfiles.c (objfile::objfile): Update.
5664         * psymtab.h (psymtab_storage::obstack): Update.
5665         (psymtab_storage::m_obstack): Use gdb::optional.
5666         (class psymtab_storage): Update comment.  Remove objfile
5667         parameter.
5668         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5669
5670 2019-01-10  Tom Tromey  <tom@tromey.com>
5671
5672         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5673         <free_psymtabs>: Now private.
5674         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5675         (allocate_psymtab): Use new method.
5676
5677 2019-01-10  Tom Tromey  <tom@tromey.com>
5678
5679         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5680         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5681         * mdebugread.c (parse_partial_symbols): Use
5682         allocate_dependencies.
5683         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5684         allocate_dependencies.
5685         (process_psymtab_comp_unit_reader)
5686         (build_type_psymtab_dependencies): Likewise.
5687         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5688
5689 2019-01-10  Tom Tromey  <tom@tromey.com>
5690
5691         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5692         PSYMBOL_SET_LANGUAGE.
5693         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5694
5695 2019-01-10  Tom Tromey  <tom@tromey.com>
5696
5697         * psymtab.h (psymtab_storage::obstack): New method.
5698         <m_obstack>: Rename from obstack; now private.
5699         * psymtab.c (psymtab_storage): Update.
5700         * dwarf2read.c (create_addrmap_from_index)
5701         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5702         Update.
5703
5704 2019-01-10  Tom Tromey  <tom@tromey.com>
5705
5706         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5707         * objfiles.h (objfile::reset_psymtabs): New method.
5708
5709 2019-01-10  Tom Tromey  <tom@tromey.com>
5710
5711         * symmisc.c (print_symbol_bcache_statistics): Update.
5712         (print_objfile_statistics): Update.
5713         * symfile.c (reread_symbols): Update.
5714         * psymtab.h (class psymtab_storage): New.
5715         * psymtab.c (psymtab_storage): New constructor.
5716         (~psymtab_storage): New destructor.
5717         (require_partial_symbols): Update.
5718         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5719         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5720         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5721         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5722         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5723         (start_psymtab_common, end_psymtab_common)
5724         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5725         (allocate_psymtab): Update.
5726         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5727         Update.
5728         (dump_psymtab_addrmap, maintenance_print_psymbols)
5729         (maintenance_check_psymtabs): Update.
5730         (class objfile_psymtabs): Move to objfiles.h.
5731         * psympriv.h (discard_psymtab): Now inline.
5732         (psymtab_discarder::psymtab_discarder): Update.
5733         (psymtab_discarder::~psymtab_discarder): Update.
5734         (ALL_OBJFILE_PSYMTABS): Rewrite.
5735         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5736         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5737         Remove fields.
5738         <partial_symtabs>: New field.
5739         (class objfile_psymtabs): Move from psymtab.h.  Update.
5740         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5741         psymbol_cache.
5742         (objfile::~objfile): Don't destroy psymbol_cache.
5743         * mdebugread.c (parse_partial_symbols): Update.
5744         * dwarf2read.c (create_addrmap_from_index)
5745         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5746         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5747         (add_partial_subprogram, dwarf2_ranges_read): Update.
5748         * dwarf-index-write.c (write_address_map)
5749         (write_one_signatured_type, recursively_write_psymbols)
5750         (class debug_names, class debug_names, write_psymtabs_to_index):
5751         Update.
5752
5753 2019-01-10  Tom Tromey  <tom@tromey.com>
5754
5755         * symtab.h (SYMBOL_SET_NAMES): Update.
5756         (symbol_set_names): Update.
5757         (MSYMBOL_SET_NAMES): Update.
5758         * symtab.c (symbol_set_names): Change argument to be an
5759         objfile_per_bfd_storage.
5760         * psymtab.c (add_psymbol_to_bcache): Update.
5761         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5762
5763 2019-01-10  Tom Tromey  <tom@tromey.com>
5764
5765         * symtab.c (create_demangled_names_hash): Change argument to be an
5766         objfile_per_bfd_storage.
5767         (symbol_set_names): Update.
5768
5769 2019-01-10  Tom Tromey  <tom@tromey.com>
5770
5771         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5772         init_psymbol_list.
5773         * psymtab.c (init_psymbol_list): Do nothing if already called.
5774         * psympriv.h (init_psymbol_list): Add comment.
5775         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5776         init_psymbol_list.
5777         * dbxread.c (dbx_symfile_read): Unconditionally call
5778         init_psymbol_list.
5779
5780 2019-01-10  Tom Tromey  <tom@tromey.com>
5781
5782         * xcoffread.c (scan_xcoff_symtab): Update.
5783         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5784         "where".
5785         * mdebugread.c (parse_partial_symbols)
5786         (handle_psymbol_enumerators): Update.
5787         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5788         * dbxread.c (read_dbx_symtab): Update.
5789         * psympriv.h (psymbol_placement): New enum.
5790         (add_psymbol_to_list): Update.
5791
5792 2019-01-10  Tom Tromey  <tom@tromey.com>
5793
5794         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5795         static_psymbols parameters.
5796         (scan_xcoff_symtab): Update.
5797         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5798         static_psymbols parameters.
5799         * psympriv.h (start_psymtab_common): Update.
5800         * mdebugread.c (parse_partial_symbols): Update.
5801         * dwarf2read.c (create_partial_symtab): Update.
5802         * dbxread.c (read_dbx_symtab): Update.
5803         (start_psymtab): Remove global_psymbols and static_psymbols
5804         parameters.
5805
5806 2019-01-10  Tom Tromey  <tom@tromey.com>
5807
5808         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5809         * psymtab.c (allocate_psymtab): Add comment.
5810         * psympriv.h (allocate_psymtab): Add comment.
5811         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5812         initializations.
5813         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5814
5815 2019-01-10  Tom Tromey  <tom@tromey.com>
5816
5817         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5818         Don't declare.
5819         * mipsread.c: Include mdebugread.h.
5820         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5821         Declare.
5822         * elfread.c: Include mdebugread.h.
5823
5824 2019-01-09  Tom Tromey  <tom@tromey.com>
5825
5826         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5827         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5828         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5829         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5830         (psym_lookup_symbol, psym_find_last_source_symtab)
5831         (psym_forget_cached_source_info, psym_print_stats)
5832         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5833         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5834         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5835         (psym_find_compunit_symtab_by_address)
5836         (maintenance_print_psymbols, maintenance_info_psymtabs)
5837         (maintenance_check_psymtabs): Use ranged for.
5838         * psymtab.h (class objfile_psymtabs): New.
5839         (require_partial_symbols): Return objfile_psymtabs.
5840         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5841
5842 2019-01-09  Tom Tromey  <tom@tromey.com>
5843
5844         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5845         (find_pc_mapped_section, list_overlays_command)
5846         (map_overlay_command, unmap_overlay_command)
5847         (simple_overlay_update): Use all_objfiles.
5848         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5849         * printcmd.c (info_symbol_command): Use all_objfiles.
5850         * objfiles.h (ALL_OBJSECTIONS): Remove.
5851         * maint.c (maintenance_translate_address): Use all_objfiles.
5852         * gcore.c (gcore_create_callback): Use all_objfiles.
5853         (objfile_find_memory_regions): Likewise.
5854
5855 2019-01-09  Tom Tromey  <tom@tromey.com>
5856
5857         * symtab.c (find_line_symtab, info_sources_command)
5858         (make_source_files_completion_list): Use objfile_compunits.
5859         * source.c (select_source_symtab): Use objfile_compunits.
5860         * objfiles.h (struct objfile): Update comment.
5861         (ALL_OBJFILES): Remove.
5862         (ALL_FILETABS): Remove.
5863         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5864         objfile_compunits.
5865
5866 2019-01-09  Tom Tromey  <tom@tromey.com>
5867
5868         * symmisc.c (print_objfile_statistics, dump_objfile)
5869         (maintenance_print_symbols): Use compunit_filetabs.
5870         * source.c (forget_cached_source_info_for_objfile): Use
5871         compunit_filetabs.
5872         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5873         (ALL_FILETABS): Use compunit_filetabs.
5874         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5875         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5876
5877 2019-01-09  Tom Tromey  <tom@tromey.com>
5878
5879         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5880         (compunit_filetabs): New.
5881         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5882         compunit_filetabs.
5883         (info_sources_command, make_source_files_completion_list): Remove
5884         declaration.
5885         * symmisc.c (print_objfile_statistics, dump_objfile)
5886         (maintenance_print_symbols): Remove declaration.
5887         (maintenance_info_symtabs): Use compunit_filetabs.
5888         (maintenance_info_line_tables): Likewise.
5889         * source.c (select_source_symtab): Change local variable name.
5890         (forget_cached_source_info_for_objfile): Remove declaration.
5891         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5892         * objfiles.c (objfile_relocate1): Remove declaration.
5893         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5894         declaration.
5895         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5896         * coffread.c (coff_symtab_read): Remove declaration.
5897         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5898         compunit_filetabs.
5899
5900 2019-01-09  Tom Tromey  <tom@tromey.com>
5901
5902         * symtab.c (lookup_objfile_from_block)
5903         (find_pc_sect_compunit_symtab, search_symbols)
5904         (default_collect_symbol_completion_matches_break_on): Use
5905         objfile_compunits.
5906         * objfiles.h (ALL_COMPUNITS): Remove.
5907         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5908         * cp-support.c (add_symbol_overload_list_qualified): Use
5909         objfile_compunits.
5910         * ada-lang.c (ada_collect_symbol_completion_matches)
5911         (ada_add_global_exceptions): Use objfile_compunits.
5912
5913 2019-01-09  Tom Tromey  <tom@tromey.com>
5914
5915         * source.c (select_source_symtab)
5916         (forget_cached_source_info_for_objfile): Remove declaration.
5917         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5918         declaration.
5919         * maint.c (count_symtabs_and_blocks): Remove declaration.
5920         * cp-support.c (add_symbol_overload_list_qualified): Remove
5921         declaration.
5922         * coffread.c (coff_symtab_read): Remove declaration.
5923         * symtab.c (lookup_symbol_in_objfile_symtabs)
5924         (basic_lookup_transparent_type_1): Use objfile_compunits.
5925         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5926         (info_sources_command, search_symbols)
5927         (default_collect_symbol_completion_matches_break_on)
5928         (make_source_files_completion_list): Remove declaration.
5929         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5930         (ada_collect_symbol_completion_matches)
5931         (ada_add_global_exceptions): Remove declaration.
5932         * linespec.c (iterate_over_all_matching_symtabs): Use
5933         objfile_compunits.
5934         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5935         (class objfile_compunits): New.
5936         (ALL_COMPUNITS): Use objfile_compunits.
5937         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5938         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5939         objfile_compunits.
5940         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5941
5942 2019-01-09  Tom Tromey  <tom@tromey.com>
5943
5944         * symtab.c (search_symbols)
5945         (default_collect_symbol_completion_matches_break_on): Use
5946         objfile_msymbols.
5947         * ada-lang.c (ada_lookup_simple_minsym)
5948         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5949         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5950         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5951         objfile_msymbols.
5952         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5953         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5954         * objc-lang.c (find_methods): Use objfile_msymbols.
5955         (info_selectors_command, info_classes_command): Likewise.
5956         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5957         * objfiles.h (class objfile_msymbols): New.
5958         (ALL_OBJFILE_MSYMBOLS): Remove.
5959         (ALL_MSYMBOLS): Remove.
5960
5961 2019-01-09  Tom Tromey  <tom@tromey.com>
5962
5963         * common/next-iterator.h (next_adapter): Add Iterator template
5964         parameter.
5965         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5966         (class all_objfiles_safe): New.
5967         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5968         * objfiles.c (put_objfile_before): Update comment.
5969         (add_separate_debug_objfile): Likewise.
5970         (free_all_objfiles): Use all_objfiles_safe.
5971         (objfile_purge_solibs): Likewise.
5972
5973 2019-01-09  Tom Tromey  <tom@tromey.com>
5974
5975         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5976         (expand_symtab_containing_pc, lookup_static_symbol)
5977         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5978         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5979         all_objfiles.
5980         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5981         * breakpoint.c (create_overlay_event_breakpoint)
5982         (create_longjmp_master_breakpoint)
5983         (create_std_terminate_master_breakpoint)
5984         (create_exception_master_breakpoint): Use all_objfiles.
5985         * linux-thread-db.c (try_thread_db_load_from_pdir)
5986         (has_libpthread): Use all_objfiles.
5987         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5988         * linespec.c (iterate_over_all_matching_symtabs)
5989         (search_minsyms_for_name): Use all_objfiles.
5990         * maint.c (maintenance_info_sections): Use all_objfiles.
5991         * main.c (captured_main_1): Use all_objfiles.
5992         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5993         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5994         * guile/scm-pretty-print.c
5995         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5996         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5997         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5998         (maintenance_print_msymbols): Use all_objfiles.
5999         * source.c (select_source_symtab): Use all_objfiles.
6000         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6001         * symfile.c (remove_symbol_file_command)
6002         (expand_symtabs_matching, map_symbol_filenames): Use
6003         all_objfiles.
6004         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6005         all_objfiles.
6006         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6007         * objc-lang.c (find_methods): Use all_objfiles.
6008         * objfiles.c (have_partial_symbols, have_full_symbols)
6009         (have_minimal_symbols, qsort_cmp)
6010         (default_iterate_over_objfiles_in_search_order): Use
6011         all_objfiles.
6012         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6013         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6014         (maintenance_check_psymtabs): Use all_objfiles.
6015         (ALL_PSYMTABS): Remove.
6016         * compile/compile-object-run.c (do_module_cleanup): Use
6017         all_objfiles.
6018         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6019         * cp-support.c (add_symbol_overload_list_qualified): Use
6020         all_objfiles.
6021         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6022         Use all_objfiles.
6023         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6024         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6025         all_objfiles.
6026         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6027         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6028         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6029         Uses all_objfiles.
6030         * solib.c (solib_read_symbols): Use all_objfiles
6031
6032 2019-01-09  Tom Tromey  <tom@tromey.com>
6033
6034         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6035         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6036         all_objfiles.
6037         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6038         * symmisc.c (print_symbol_bcache_statistics)
6039         (print_objfile_statistics, maintenance_print_objfiles)
6040         (maintenance_info_symtabs, maintenance_check_symtabs)
6041         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6042         all_objfiles.
6043         * source.c (forget_cached_source_info): Use all_objfiles.
6044         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6045         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6046         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6047         * objfiles.c (update_section_map): Use all_objfiles.
6048         (shared_objfile_contains_address_p): Likewise.
6049         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6050         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6051
6052 2019-01-09  Tom Tromey  <tom@tromey.com>
6053
6054         * common/next-iterator.h: New file.
6055         * objfiles.h (class all_objfiles): New.
6056         (struct objfile_iterator): New.
6057
6058 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6059
6060         * NEWS: Move the description of the changed "frame", "select-frame",
6061          and "info frame" commands to the Changed commands section.
6062
6063 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6064
6065         * gdbtypes.c (check_stub_method_group): Remove handling of old
6066         mangling schemes.
6067         * linespec.c (find_methods): Likewise.
6068         * stabsread.c (read_member_functions): Likewise.
6069         * valops.c (search_struct_method): Likewise.
6070         (value_struct_elt_for_reference): Likewise.
6071         * NEWS: Mention this change.
6072
6073 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6074
6075         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6076         print_source_lines.
6077         * source.c (print_source_lines_base): Update line number check.
6078         (print_source_lines): New function.
6079         (source_lines_range::source_lines_range): New function.
6080         * source.h (class source_lines_range): New class.
6081         (print_source_lines): New declaration.
6082
6083 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6084
6085         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6086
6087 2019-01-08  Tom Tromey  <tom@tromey.com>
6088             Simon Marchi  <simon.marchi@ericsson.com>
6089
6090         PR gdb/24060
6091         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6092         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6093         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6094         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6095         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6096         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6097
6098 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6099
6100         * source.c (select_source_symtab): Move header comment to
6101         declaration in source.h.
6102         (forget_cached_source_info_for_objfile): Likewise.
6103         (forget_cached_source_info): Likewise.
6104         (identify_source_line): Likewise.
6105         * source.h (identify_source_line): Move declaration from symtab.h
6106         and add comment from source.c
6107         (print_source_lines): Likewise.
6108         (forget_cached_source_info_for_objfile): Likewise.
6109         (forget_cached_source_info): Likewise.
6110         (select_source_symtab): Likewise.
6111         (enum print_source_lines_flag): Move definition from symtab.h.
6112         * symtab.h (identify_source_line): Move declaration to source.h.
6113         (print_source_lines): Likewise.
6114         (forget_cached_source_info_for_objfile): Likewise.
6115         (forget_cached_source_info): Likewise.
6116         (select_source_symtab): Likewise.
6117         (enum print_source_lines_flag): Move definition to source.h.
6118         * tui/tui-hooks.c: Add 'source.h' include.
6119
6120 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6121
6122         * source.c (print_source_lines_base): Handle requests to print
6123         reverse line number sequences, and guard against empty lines
6124         string.
6125
6126 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6127
6128         * source.c (print_source_lines_base): Fix skip of '\r' if next
6129         character is '\n'.
6130
6131 2019-01-06  Tom Tromey  <tom@tromey.com>
6132
6133         * c-exp.y (struct c_parse_state) <macro_original_text,
6134         expansion_obstack>: New member.
6135         (macro_original_text, expansion_obstack): Remove globals.
6136         (scan_macro_expansion, scanning_macro_expansion)
6137         (finished_macro_expansion): Update.
6138         (scan_macro_cleanup): Remove.
6139         (yylex, c_parse): Update.
6140
6141 2019-01-06  Tom Tromey  <tom@tromey.com>
6142
6143         * c-exp.y (struct c_parse_state) <strings>: New member.
6144         (operator_stoken): Update.
6145
6146 2019-01-06  Tom Tromey  <tom@tromey.com>
6147
6148         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6149         (union type_stack_elt) <typelist_val>: Now a pointer to
6150         std::vector.
6151         (type_stack_cleanup): Don't declare.
6152         (push_typelist): Update.
6153         * parse.c (pop_typelist): Return a std::vector.
6154         (push_typelist): Take a std::vector.
6155         (follow_types): Update.  Do not free args.
6156         (type_stack_cleanup): Remove.
6157         * c-exp.y (struct c_parse_state): New.
6158         (cpstate): New global.
6159         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6160         (nonempty_typelist): Update.
6161         (func_mod): Create a new vector.
6162         (c_parse): Create a c_parse_state.
6163         (check_parameter_typelist): Do not delete params.
6164         (function_method): Update.  Do not delete type_list.
6165
6166 2019-01-06  Tom Tromey  <tom@tromey.com>
6167
6168         PR gdb/28155:
6169         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6170         check_typedef.
6171         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6172         (print_return_value): Likewise.
6173
6174 2019-01-05  Tom Tromey  <tom@tromey.com>
6175
6176         * contrib/cleanup_check.py: Remove.
6177         * contrib/gcc-with-excheck: Remove.
6178         * contrib/exsummary.py: Remove.
6179         * contrib/excheck.py: Remove.
6180
6181 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6182
6183         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6184         NULL. Initialize tpprev to NULL instead of assigning it
6185         to NULL on the next statement.
6186         * windows-nat.c (windows_delete_thread): Remove check for
6187         main_thread_id before printing thread exit notifications.
6188         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6189         Remove thread ID check against main_thread_id.
6190         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6191         windows_delete_thread.
6192         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6193
6194 2019-01-04  Tom Tromey  <tom@tromey.com>
6195
6196         * compile/compile.c (_initialize_compile): Use upper case for
6197         metasyntactic variables.
6198         * symmisc.c (_initialize_symmisc): Use upper case for
6199         metasyntactic variables.
6200         * psymtab.c (_initialize_psymtab): Use upper case for
6201         metasyntactic variables.
6202         * demangle.c (demangle_command): Use upper case for metasyntactic
6203         variables.
6204         (_initialize_demangler): Likewise.
6205         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6206         variables.
6207
6208 2019-01-03  Tom Tromey  <tom@tromey.com>
6209
6210         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6211
6212 2019-01-03  Tom Tromey  <tom@tromey.com>
6213
6214         * python/py-symtab.c (salpy_str): Update.
6215         (struct salpy_sal_object) <symtab>: Now a PyObject.
6216         (salpy_dealloc): Update.
6217         (del_objfile_sal): Use gdbpy_ref.
6218
6219 2019-01-03  Tom Tromey  <tom@tromey.com>
6220
6221         * python/py-type.c (convert_field): Use new_reference.  Return
6222         gdbpy_ref.
6223         (make_fielditem): Return gdbpy_ref.
6224         (typy_fields): Update.
6225         (typy_getitem): Update.
6226         (field_name): Return gdbpy_ref.  Use new_reference.
6227         (typy_iterator_iternext): Update.
6228
6229 2019-01-03  Tom Tromey  <tom@tromey.com>
6230
6231         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6232
6233 2019-01-03  Tom Tromey  <tom@tromey.com>
6234
6235         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6236         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6237         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6238         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6239         (pspy_set_type_printers): Likewise.
6240         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6241         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6242         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6243         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6244         (objfpy_set_type_printers): Likewise.
6245
6246 2019-01-03  Tom Tromey  <tom@tromey.com>
6247
6248         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6249         (gdbpy_print_stack): Use gdbpy_err_fetch.
6250         * python/python-internal.h (class gdbpy_err_fetch): New class.
6251         (class gdbpy_enter) <m_error_type, m_error_value,
6252         m_error_traceback>: Remove.
6253         <m_error>: New member.
6254         (gdbpy_exception_to_string): Don't declare.
6255         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6256         * python/py-value.c (convert_value_from_python): Use
6257         gdbpy_err_fetch.
6258         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6259         gdbpy_exception_to_string.
6260         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6261         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6262         gdbpy_err_fetch.
6263
6264 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6265
6266         * linux-nat.c (delete_lwp_cleanup): Delete.
6267         (struct lwp_deleter): New struct.
6268         (lwp_info_up): New typedef.
6269         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6270         lwp_info_up.
6271
6272 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6273
6274         * linux-fork.c (class scoped_switch_fork_info): New class.
6275         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6276
6277 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6278
6279         * valops.c (find_overload_match): Remove use of null_cleanup, and
6280         calls to do_cleanups.
6281
6282 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6283
6284         * compile/compile-cplus-types.c
6285         (compile_cplus_instance::decl_name): Handle changes to
6286         cp_func_name.
6287         * cp-support.c (cp_func_name): Update header comment, update
6288         return type.
6289         * cp-support.h (cp_func_name): Update return type in declaration.
6290         * valops.c (find_overload_match): Move temp_func local to top
6291         level of function and change its type.  Use temp_func to hold and
6292         delete temporary string obtained from cp_func_name.
6293
6294 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6295
6296         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6297         gdb::char_vector, remove cleanup, and update uses of `msg`.
6298
6299 2019-01-03  Jim Wilson  <jimw@sifive.com>
6300
6301         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6302
6303 2019-01-02  Tom Tromey  <tom@tromey.com>
6304
6305         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6306         (tdesc_parse_xml): Remove cleanups.
6307         * target-descriptions.h (make_cleanup_free_target_description):
6308         Don't declare.
6309         (target_desc_deleter): New struct.
6310         (target_desc_up): New typedef.
6311         * target-descriptions.c (target_desc_deleter::operator()): Rename
6312         from free_target_description.
6313         (make_cleanup_free_target_description): Remove.
6314
6315 2019-01-02  Tom Tromey  <tom@tromey.com>
6316
6317         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6318         constructor, destructor.
6319         (linespec_parser): Remove typedef.
6320         (~linespec_parser): Rename from linespec_parser_delete.
6321         (linespec_lex_to_end, linespec_complete_label)
6322         (linespec_complete): Update.
6323         (decode_line_full): Remove cleanups.
6324         (decode_line_1): Update.
6325
6326 2019-01-02  Tom Tromey  <tom@tromey.com>
6327
6328         * python/python-internal.h (inferior_to_inferior_object): Change
6329         return type.
6330         * python/py-exitedevent.c (create_exited_event_object): Update.
6331         * python/py-inferior.c (inferior_to_inferior_object): Return
6332         gdbpy_ref.
6333         (python_new_inferior, python_inferior_deleted)
6334         (thread_to_thread_object, delete_thread_object)
6335         (build_inferior_list, gdbpy_selected_inferior): Update.
6336         * python/py-infthread.c (create_thread_object): Update.  Also fail
6337         if inferior_to_inferior_object fails.
6338
6339 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6340
6341         * inferior.h (class inferior) <displaced_step_state>: New field.
6342         * infrun.h (struct displaced_step_state): Move here from
6343         infrun.c.  Initialize fields, add constructor.
6344         <inf>: Remove field.
6345         <reset>: New method.
6346         * infrun.c (struct displaced_step_inferior_state): Move to
6347         infrun.h.
6348         (displaced_step_inferior_states): Remove.
6349         (get_displaced_stepping_state): Adust.
6350         (displaced_step_in_progress_any_inferior): Adjust.
6351         (displaced_step_in_progress_thread): Adjust.
6352         (displaced_step_in_progress): Adjust.
6353         (add_displaced_stepping_state): Remove.
6354         (get_displaced_step_closure_by_addr): Adjust.
6355         (remove_displaced_stepping_state): Remove.
6356         (infrun_inferior_exit): Call displaced_step_state.reset.
6357         (use_displaced_stepping): Don't check for NULL.
6358         (displaced_step_prepare_throw): Call
6359         get_displaced_stepping_state.
6360         (displaced_step_fixup): Don't check for NULL.
6361         (prepare_for_detach): Don't check for NULL.
6362
6363 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6364
6365         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6366          in case of call that did not complete.
6367
6368 2019-01-02  Andrey Utkin  <autkin@undo.io>
6369
6370         * symfile.c (find_separate_debug_file): Fix search of debug files for
6371         remote debuggee.
6372
6373 2019-01-02  Tom Tromey  <tom@tromey.com>
6374
6375         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6376         indentation.
6377         * python/py-frame.c (frapy_older): Remove cast.
6378         (frapy_newer): Likewise.
6379         * python/py-breakpoint.c (local_setattro): Remove cast.
6380         * python/py-arch.c (archpy_name): Remove local variable.
6381         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6382
6383 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6384
6385         * unittests/basic_string_view/element_access/char/empty.cc:
6386         Fix year range in copyright header.
6387
6388 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6389
6390         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6391         Delete.
6392         <operator==>: Update with for removed field.
6393         <hash>: Likewise.
6394         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6395         <isa_features>: ...this.
6396         <abi_features>: New field.
6397         (riscv_isa_flen): Update comment.
6398         (riscv_abi_xlen): New declaration.
6399         (riscv_abi_flen): New declaration.
6400         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6401         isa_features.
6402         (riscv_abi_xlen): New function.
6403         (riscv_isa_flen): Update to get answer from isa_features.
6404         (riscv_abi_flen): New function.
6405         (riscv_has_fp_abi): Update to get answer from abi_features.
6406         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6407         xlen and flen.
6408         (riscv_call_info) <xlen, flen>: Update comment.
6409         (riscv_call_arg_struct): Remove invalid assertions
6410         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6411         is removed.
6412         (riscv_gdbarch_init): Gather isa features and abi features
6413         separately, ensure both match on the gdbarch when reusing an old
6414         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6415         a target with 64-bit float hardware.
6416
6417 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6418
6419         * source.c (search_command_helper): Stop reverse search
6420         when line 1 has been searched.
6421
6422 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6423
6424         * record-full.c (record_full_base_target::close): Rewrite
6425         record_full_core_buf_list free logic.
6426
6427 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6428
6429         * break-catch-syscall.c (print_one_catch_syscall): xfree
6430         the last text.
6431
6432 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6433
6434         * top.c (print_gdb_version): Update Copyright year in version
6435         message.
6436
6437 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6438
6439         Update copyright year range in all GDB files.
6440
6441 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6442
6443         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6444
6445 For older changes see ChangeLog-2018.
6446 \f
6447 Local Variables:
6448 mode: change-log
6449 left-margin: 8
6450 fill-column: 74
6451 version-control: never
6452 coding: utf-8
6453 End:
6454