gdb/ChangeLog

   1 2019-09-10  Tom Tromey  <tromey@adacore.com>
   2
   3         * psymtab.c (map_block): Remove.
   4         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
   5         * symtab.c (iterate_over_symbols_terminated): New function.
   6         * symtab.c (iterate_over_symbols_terminated): Declare.
   7
   8 2019-09-10  Tom Tromey  <tromey@adacore.com>
   9
  10         * ada-lang.c (ada_iterate_over_symbols): Return bool.
  11         * language.h (struct language_defn) <la_iterate_over_symbols>:
  12         Return bool.
  13         * symtab.c (iterate_over_symbols): Return bool.
  14         * symtab.h (iterate_over_symbols): Return bool.
  15
  16 2019-09-10  Tom Tromey  <tromey@adacore.com>
  17
  18         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
  19         (add_nonlocal_symbols): Update.
  20         * dwarf2read.c (dw2_map_matching_symbols): Change type.
  21         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
  22         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
  23         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
  24         Change type of "callback".  Remove "data".
  25
  26
  27 2019-09-09  Ali Tamur  <tamur@google.com>
  28
  29         * dwarf2read.c (comp_unit_head): Update comment.
  30         (dwarf2_dwo_name): New function declaration.
  31         (dwarf_unit_type_name): New function declaration.
  32         (read_comp_unit_head): Add support for new compilation units,
  33         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
  34         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
  35         (currently named as "signature") in their header. Also clarify error
  36         messages.
  37         (lookup_dwo_id): New function. Returns the dwo id of the given
  38         compile unit.
  39         (lookup_dwo_unit): Use the new lookup_dwo_id function.
  40         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
  41         functions.
  42         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
  43         (dwarf2_dwo_name): Get the dwo name if present.
  44         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
  45         purposes.
  46
  47 2019-09-09  Tom Tromey  <tom@tromey.com>
  48
  49         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
  50
  51 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  52
  53         * python/python.c (do_start_initialization): Make progname_copy static,
  54         to avoid a leak report.
  55
  56 2019-09-08  Tom Tromey  <tom@tromey.com>
  57
  58         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
  59
  60 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
  61
  62         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
  63         Change type to gdb::optional<block_enum>.
  64         (dw2_symtab_iter_init): Change block_index parameter type
  65         to gdb::optional<block_enum>.
  66         (dw2_lookup_symbol): Change block_index parameter
  67         type to block_enum.c
  68         (dw2_debug_names_lookup_symbol): Likewise.
  69         * psymtab.c (psym_lookup_symbol): Likewise.
  70         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
  71         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
  72         Likewise.
  73
  74 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
  75
  76         * defs.h (relocate_gdb_directory): Change int to bool in
  77         signature and rename flag to relocatable.
  78         * main.c (relocate_path): Likewise.
  79         (relocate_gdb_directory): Likewise.
  80
  81 2019-09-06  Alan Modra  <amodra@gmail.com>
  82
  83         * coffread.c (coff_symfile_read): Constify filename variable.
  84         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
  85         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
  86         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
  87         * solib.c (reload_shared_libraries_1): Likewise.
  88         * symfile.c (reread_symbols): Likewise.
  89         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
  90         * solib-darwin.c (darwin_bfd_open): Likewise.
  91         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
  92
  93 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
  94
  95         * psymtab.c (print_partial_symbols): Handle missing domain_enum
  96         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
  97
  98 2019-09-03  Tom Tromey  <tromey@adacore.com>
  99
 100         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 101         types.
 102         (has_negatives): Unbias a range type bound.
 103         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 104         * gdbtypes.c (operator==): Handle new field.
 105         (create_range_type): Add "bias" parameter.
 106         (create_static_range_type, resolve_dynamic_range): Update.
 107         * gdbtypes.h (struct range_bounds) <bias>: New member.
 108         (create_range_type): Add bias parameter.
 109         * printcmd.c (print_scalar_formatted): Unbias range types.
 110         * value.c (unpack_long): Unbias range types.
 111         (pack_long): Bias range types.
 112
 113 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 114
 115         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 116         probe arguments.
 117
 118 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 119
 120         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 121         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 122         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 123         (compile_probe_arg): Likewise.
 124         * probe.h (get_argument_count): Likewise.
 125         * solib-svr4.c (solib_event_probe_action): Likewise.
 126         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 127
 128 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 129
 130         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 131         code to here...
 132         (svr4_create_solib_event_breakpoints): ...from here.
 133
 134 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 135
 136         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 137         suffix from warning message.
 138
 139 2019-08-30  Tom Tromey  <tom@tromey.com>
 140
 141         * tui/tui-winsource.h (struct tui_source_window_base)
 142         <refresh_all>: Don't declare.
 143         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 144         Remove.
 145         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 146         tui_show_locator_content.
 147         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 148         declare.
 149         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 150         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 151         declare.
 152
 153 2019-08-30  Tom Tromey  <tom@tromey.com>
 154
 155         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 156
 157 2019-08-30  Tom Tromey  <tom@tromey.com>
 158
 159         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 160         Remove unnecessary forward declarations.
 161
 162 2019-08-30  Tom Tromey  <tom@tromey.com>
 163
 164         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 165         rerender.
 166         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 167         tui_show_locator_content.
 168
 169 2019-08-30  Tom Tromey  <tom@tromey.com>
 170
 171         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 172         (tui_locator_window::rerender): Rewrite using body of previous
 173         tui_show_locator_content.
 174
 175 2019-08-30  Tom Tromey  <tom@tromey.com>
 176
 177         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 178         set_locator_fullname>: New methods.
 179         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 180         Rename from tui_set_locator_fullname.
 181         (tui_locator_window::set_locator_info): Rename from
 182         tui_set_locator_info.  Return bool.
 183         (tui_update_locator_fullname, tui_show_frame_info): Update.
 184
 185 2019-08-30  Tom Tromey  <tom@tromey.com>
 186
 187         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 188
 189 2019-08-30  Tom Tromey  <tom@tromey.com>
 190
 191         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 192         call touchwin.
 193
 194 2019-08-30  Tom Tromey  <tom@tromey.com>
 195
 196         * tui/tui-wingeneral.c (box_win): Assume win_info and
 197         win_info->handle cannot be NULL.
 198
 199 2019-08-30  Tom Tromey  <tom@tromey.com>
 200
 201         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 202         refresh_window>: Declare.
 203         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 204         resize.
 205         (tui_data_item_window::rerender): Rename from
 206         tui_display_register.
 207         (tui_data_item_window::refresh_window): New method.
 208         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 209         no-op.
 210
 211 2019-08-30  Tom Tromey  <tom@tromey.com>
 212
 213         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 214         regs_column_count, current_group>: Move later.  Now private.
 215         <get_current_group>: New method.
 216         * tui/tui-regs.c (tui_reg_command): Update.
 217         * tui/tui-layout.c (tui_set_layout): Update.
 218
 219 2019-08-30  Tom Tromey  <tom@tromey.com>
 220
 221         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 222         (tui_data_window::rerender): Don't call
 223         check_and_display_highlight_if_needed.
 224         (tui_data_window::refresh_all): Remove call to
 225         erase_data_content.
 226
 227 2019-08-30  Tom Tromey  <tom@tromey.com>
 228
 229         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 230         (tui_data_window::display_registers_from)
 231         (tui_data_window::display_reg_element_at_line)
 232         (tui_data_window::display_registers_from_line): Remove checks of
 233         "empty".
 234
 235 2019-08-30  Tom Tromey  <tom@tromey.com>
 236
 237         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 238         Don't declare.
 239         * tui/tui-regs.c (tui_data_window::show_registers): Call
 240         rerender.
 241         (tui_data_window::rerender): Rename from display_all_data.
 242         (tui_data_window::rerender): Remove old implementation.
 243
 244 2019-08-30  Tom Tromey  <tom@tromey.com>
 245
 246         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 247         text.
 248         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 249
 250 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 251             Sergio Durigan Junior  <sergiodj@redhat.com>
 252
 253         PR win32/24284
 254         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 255
 256 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 257
 258         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 259         when searching for types.
 260
 261 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 262
 263         * f-lang.c (f_language_defn): Use f_print_typedef.
 264         * f-lang.h (f_print_typedef): Declare.
 265         * f-typeprint.c (f_print_typedef): Define.
 266
 267 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 268
 269         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 270
 271 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 272
 273         * cli/cli-utils.c (info_print_options_defs): Delete.
 274         (make_info_print_options_def_group): Delete.
 275         (extract_info_print_options): Delete.
 276         (info_print_command_completer): Delete.
 277         (info_print_args_help): Add extra parameter, and optionally
 278         include text about -n flag.
 279         * cli/cli-utils.h (struct info_print_options): Delete.
 280         (extract_info_print_options): Delete declaration.
 281         (info_print_command_completer): Delete declaration.
 282         (info_print_args_help): Add extra parameter, extend header
 283         comment.
 284         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 285         search_symbols.
 286         * stack.c (struct info_print_options): New type.
 287         (info_print_options_defs): New file scoped variable.
 288         (make_info_print_options_def_group): New static function.
 289         (info_print_command_completer): New static function.
 290         (info_locals_command): Update to use new local functions.
 291         (info_args_command): Likewise.
 292         (_initialize_stack): Add extra parameter to calls to
 293         info_print_args_help.
 294         * symtab.c (search_symbols): Add extra parameter, use this to
 295         possibly excluse non-debug symbols.
 296         (symtab_symbol_info): Add extra parameter, which is passed on to
 297         search_symbols.
 298         (struct info_print_options): New type.
 299         (info_print_options_defs): New file scoped variable.
 300         (make_info_print_options_def_group): New static function.
 301         (info_print_command_completer): New static function.
 302         (info_variables_command): Update to use local functions, and pass
 303         extra parameter through to symtab_symbol_info.
 304         (info_functions_command): Likewise.
 305         (info_types_command): Pass additional argument through to
 306         symtab_symbol_info.
 307         (rbreak_command): Pass extra argument to search_symbols.
 308         (_initialize_symtab): Add extra arguments for calls to
 309         info_print_args_help, and update help text for 'info variables',
 310         'whereis', and 'info functions' commands.
 311         * symtab.h (search_symbols): Add extra argument to declaration.
 312         * NEWS: Mention new flags.
 313
 314 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 315
 316         * symtab.c (lookup_static_symbol): Call the new function (and move
 317         it down to be next to lookup_global_symbol).
 318         (struct global_sym_lookup_data): Add block_enum member and rename to...
 319         (struct global_or_static_sym_lookup_data): ...this.
 320         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 321         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 322         (lookup_symbol_global_or_static_iterator_cb): ...this.
 323         (lookup_global_or_static_symbol): New function.
 324         (lookup_global_symbol): Call new function.
 325
 326 2019-08-26  Tom de Vries  <tdevries@suse.de>
 327
 328         PR c++/24852
 329         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 330         when pc_probe.prob == NULL.
 331
 332 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 333
 334         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 335         variable symbol_linkage to symbol_linkage_.
 336
 337 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 338
 339         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 340         represent whether the symbol is static, dynamic, or we don't
 341         know.
 342
 343 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 344
 345         * gdb/rx-tdep.c (rx_register_names): New.
 346         (rx_register_name): Delete.
 347         (rx_psw_type): Delete.
 348         (rx_fpsw_type): Delete.
 349         (rx_register_type): Delete.
 350         (rx_gdbarch_init): Convert target-descriptions.
 351         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 352         * gdb/features/Makefile: Add rx.xml.
 353         * gdb/features/rx.xml: New.
 354         * gdb/features/rx.c: Generated.
 355         * gdb/NEWS: Mention target description support.
 356
 357 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 358
 359         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 360         *slot_ptr.
 361
 362 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 363
 364         * configure.ac: Don't check for 'dlfcn.h' (moved to
 365         gdbsupport/common.m4).
 366         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 367         'gdbsupport/'.
 368         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 369         * compile/compile-c-support.c: Include
 370         'gdbsupport/gdb-dlfcn.h'.
 371         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 372         * gdb-dlfcn.c: Move to...
 373         * gdbsupport/gdb-dlfcn.c: ... here.
 374         * gdb-dlfcn.h: Move to...
 375         * gdbsupport/gdb-dlfcn.h: ... here.
 376
 377 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 378
 379         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 380         the offset field signed.
 381
 382 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 383
 384         * python/lib/gdb/__init__.py (_execute_file): New function.
 385         * python/python.c (python_run_simple_file): Call gdb._execute_file
 386         on Windows.
 387
 388 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 389
 390         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 391         all uses as this was never set to anything but a zero value.
 392
 393 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 394
 395         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 396
 397 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 398
 399         * tui/tui-data.h (tui_gen_win_info): Add an =default
 400         move constructor, required by some GCC versions.
 401
 402 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 403
 404         * go32-nat.c (go32_sysinfo): Add hygon_p.
 405
 406 2019-08-20  Tom Tromey  <tom@tromey.com>
 407
 408         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 409         line_from_reg_element_no, first_reg_element_no_inline,
 410         display_all_data, delete_data_content_windows,
 411         erase_data_content>: Now private.
 412
 413 2019-08-20  Tom Tromey  <tom@tromey.com>
 414
 415         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 416         (tui_unhighlight_win, tui_highlight_win)
 417         (tui_win_info::make_window): Update.
 418         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 419
 420 2019-08-20  Tom Tromey  <tom@tromey.com>
 421
 422         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 423         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 424         (MAX_PID_WIDTH): Move to tui-stack.c.
 425         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 426         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 427         (MAX_PID_WIDTH): Move from tui-data.h.
 428
 429 2019-08-20  Tom Tromey  <tom@tromey.com>
 430
 431         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 432         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 433         (box_win): Update.
 434         (tui_gen_win_info::make_window): Rename from tui_make_window.
 435         (tui_win_info::make_window): New method.
 436         (tui_gen_win_info::make_visible): Update.
 437         * tui/tui-source.c (tui_source_window::set_contents): Update.
 438         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 439         (tui_data_window::display_registers_from): Update.
 440         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 441         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 442         Declare.
 443         <can_box>: Remove.
 444         <title>: Remove.
 445         (struct tui_win_info) <make_window>: Declare.
 446         <can_box>: Now virtual.
 447         <title>: New member.
 448         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 449         * tui/tui-command.c (tui_cmd_window::resize): Update.
 450
 451 2019-08-20  Tom Tromey  <tom@tromey.com>
 452
 453         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 454         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 455         (tui_data_window::check_register_values): Update.
 456
 457 2019-08-20  Tom Tromey  <tom@tromey.com>
 458
 459         * tui/tui-regs.h (struct tui_data_window): Use
 460         DISABLE_COPY_AND_ASSIGN.
 461         <regs_content>: Change type, removing unique_ptr.
 462         <tui_data_window>: Add move constructor.
 463         * tui/tui-regs.c (tui_data_window::show_registers)
 464         (tui_data_window::show_register_group)
 465         (tui_data_window::display_registers_from)
 466         (tui_data_window::display_registers_from)
 467         (tui_data_window::first_data_item_displayed)
 468         (tui_data_window::delete_data_content_windows)
 469         (tui_data_window::rerender, tui_data_window::refresh_window)
 470         (tui_data_window::check_register_values): Update.
 471
 472 2019-08-20  Tom Tromey  <tom@tromey.com>
 473
 474         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 475         show_register_group>: Declare.
 476         (tui_show_register_group): Don't declare.
 477         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 478         tui_show_registers.
 479         (tui_data_window::show_register_group): Rename from
 480         tui_show_register_group.
 481         (tui_data_window::check_register_values, tui_reg_command):
 482         Update.
 483         * tui/tui-layout.c (tui_set_layout): Update.
 484
 485 2019-08-20  Tom Tromey  <tom@tromey.com>
 486
 487         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 488         Declare.
 489         (tui_check_register_values): Don't declare.
 490         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 491         from tui_check_register_values.
 492         * tui/tui-hooks.c (tui_register_changed): Update.
 493
 494 2019-08-20  Tom Tromey  <tom@tromey.com>
 495
 496         * tui/tui-regs.c (tui_reg_layout): Move later.
 497         (tui_show_registers): Don't enable TUI mode or change layout.
 498
 499 2019-08-20  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui-regs.h (struct tui_data_item_window)
 502         <~tui_data_item_window>: Remove.
 503         <content>: Now a unique_xmalloc_ptr.
 504         * tui/tui-regs.c (tui_register_format): Return a
 505         unique_xmalloc_ptr.
 506         (tui_get_register): Update.
 507         (~tui_data_item_window): Remove.
 508         (tui_data_window::display_registers_from, tui_display_register):
 509         Update.
 510         * tui/tui-io.h (tui_expand_tabs): Update.
 511         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 512         Remove "col" parameter.
 513
 514 2019-08-20  Tom Tromey  <tom@tromey.com>
 515
 516         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 517         field.
 518         * tui/tui-regs.c (~tui_data_item_window): Update.
 519
 520 2019-08-20  Tom Tromey  <tom@tromey.com>
 521
 522         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 523         earlier.
 524
 525 2019-08-20  Tom Tromey  <tom@tromey.com>
 526
 527         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 528
 529 2019-08-20  Tom Tromey  <tom@tromey.com>
 530
 531         * tui/tui-source.h (struct tui_source_window): Update.
 532         * tui/tui-regs.c (tui_show_registers): Update.
 533         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 534         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 535         (NO_REGS_STRING): Remove defines.
 536
 537 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 538
 539         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 540         unnecessary thread walk if remote doesn't support the packet.
 541
 542 2019-08-19  Tom Tromey  <tromey@adacore.com>
 543
 544         * python/py-value.c (value_has_field): Fix indentation.
 545
 546 2019-08-19  Tom Tromey  <tromey@adacore.com>
 547
 548         * printcmd.c (do_one_display, info_display_command): Update.
 549         * block.h (contained_in): Return bool.  Add allow_nested
 550         parameter.
 551         * block.c (contained_in): Return bool.  Add allow_nested
 552         parameter.
 553
 554 2019-08-19  Tom Tromey  <tom@tromey.com>
 555
 556         * configure: Rebuild.
 557         * configure.ac: Disallow the combination of -static-libstdc++ and
 558         source highlight.
 559         * source-cache.c (get_language_name): Handle rust.
 560         (source_cache::get_source_lines): Ignore highlighting exceptions.
 561
 562 2019-08-16  Tom Tromey  <tom@tromey.com>
 563
 564         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 565         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 566         (struct tui_source_window_base) <make_visible, refresh_window,
 567         resize>: Remove methods.
 568         <execution_info>: Remove field.
 569         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 570         (tui_show_source_line, tui_source_window_base)
 571         (~tui_source_window_base): Update.
 572         (tui_source_window_base::resize)
 573         (tui_source_window_base::make_visible)
 574         (tui_source_window_base::refresh_window): Remove.
 575         (tui_source_window_base::update_exec_info): Update.
 576         * tui/tui-source.c (tui_source_window::set_contents): Update.
 577         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 578
 579 2019-08-16  Tom Tromey  <tom@tromey.com>
 580
 581         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 582         deprecated_query_hook.
 583
 584 2019-08-16  Tom Tromey  <tom@tromey.com>
 585
 586         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 587         (tui_update_source_windows_with_line): Update.
 588         * tui/tui-source.h (struct tui_source_window)
 589         <show_symtab_source>: Declare.
 590         (tui_show_symtab_source): Don't declare.
 591         * tui/tui-source.c (tui_show_symtab_source): Rename from
 592         tui_show_symtab_source.
 593
 594 2019-08-16  Tom Tromey  <tom@tromey.com>
 595
 596         * tui/tui-winsource.h (struct tui_source_window_base)
 597         <set_contents>: Declare.
 598         * tui/tui-winsource.c
 599         (tui_source_window_base::update_source_window_as_is): Update.
 600         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 601         Declare.
 602         (tui_set_source_content): Don't declare.
 603         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 604         tui_set_source_content.
 605         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 606         Declare.
 607         (tui_set_disassem_content): Don't declare.
 608         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 609         tui_set_disassem_content.
 610
 611 2019-08-16  Tom Tromey  <tom@tromey.com>
 612
 613         * tui/tui-winsource.h (struct tui_source_window_base)
 614         <update_breakpoint_info>: Declare.
 615         (tui_update_breakpoint_info): Don't declare.
 616         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 617         (tui_update_all_breakpoint_info): Update.
 618         (tui_source_window_base::update_breakpoint_info): Rename from
 619         tui_update_breakpoint_info.
 620         (tui_source_window_base::update_exec_info): Update.
 621
 622 2019-08-16  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui-winsource.h (struct tui_source_window_base)
 625         <update_source_window>: Declare.
 626         (tui_update_source_window): Don't declare.
 627         * tui/tui-winsource.c
 628         (tui_source_window_base::update_source_window): Rename from
 629         tui_update_source_window.
 630         (tui_source_window_base::rerender): Update.
 631         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 632         * tui/tui-disasm.c (tui_show_disassem)
 633         (tui_show_disassem_and_update_source)
 634         (tui_disasm_window::maybe_update): Update.
 635
 636 2019-08-16  Tom Tromey  <tom@tromey.com>
 637
 638         * tui/tui-winsource.h (struct tui_source_window_base)
 639         <update_source_window_as_is>: Declare.
 640         (tui_update_source_window_as_is): Don't declare.
 641         * tui/tui-winsource.c (tui_update_source_window): Update
 642         (tui_source_window_base::update_source_window_as_is): Rename from
 643         tui_update_source_window_as_is.
 644         (tui_source_window_base::refill): Update.
 645         * tui/tui-source.c (tui_show_symtab_source): Update.
 646         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 647         Update.
 648
 649 2019-08-16  Tom Tromey  <tom@tromey.com>
 650
 651         * tui/tui-winsource.h (tui_update_source_window)
 652         (tui_update_source_window_as_is): Remove "noerror" parameter.
 653         * tui/tui-winsource.c (tui_update_source_window)
 654         (tui_update_source_window_as_is): Remove "noerror" parameter.
 655         (tui_update_source_windows_with_addr)
 656         (tui_update_source_windows_with_line)
 657         (tui_source_window_base::rerender)
 658         (tui_source_window_base::refill): Update.
 659         * tui/tui-source.h (tui_set_source_content)
 660         (tui_show_symtab_source): Remove "noerror" parameter.
 661         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 662         parameter.
 663         (tui_show_symtab_source): Likewise.
 664         (tui_source_window::maybe_update): Update.
 665         * tui/tui-disasm.c (tui_show_disassem)
 666         (tui_show_disassem_and_update_source)
 667         (tui_disasm_window::do_scroll_vertical)
 668         (tui_disasm_window::maybe_update): Update.
 669
 670 2019-08-16  Tom Tromey  <tom@tromey.com>
 671
 672         * tui/tui.c (tui_is_window_visible): Update.
 673         * tui/tui-wingeneral.c (tui_make_window)
 674         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 675         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 676         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 677         (tui_set_win_height_command, parse_scrolling_args): Update.
 678         * tui/tui-source.c (tui_source_window::style_changed): Update.
 679         * tui/tui-regs.c (tui_show_registers)
 680         (tui_data_window::first_data_item_displayed)
 681         (tui_data_window::delete_data_content_windows)
 682         (tui_check_register_values, tui_reg_command): Update.
 683         * tui/tui-disasm.c (tui_show_disassem): Update.
 684         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 685         method.
 686         <is_visible>: Remove field.
 687         * tui/tui-data.c (tui_next_win, tui_prev_win)
 688         (tui_delete_invisible_windows): Update.
 689
 690 2019-08-16  Tom Tromey  <tom@tromey.com>
 691
 692         * tui/tui-winsource.h (struct tui_source_window_base)
 693         <m_has_locator>: Remove.
 694         * tui/tui-layout.c (show_source_disasm_command, show_data)
 695         (show_source_or_disasm_and_command): Update.
 696
 697 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 698
 699         * NEWS (Other MI changes): New subsection.
 700         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 701         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 702         * arch-utils.c (default_get_pc_address_flags): New function.
 703         * arch-utils.h (default_get_pc_address_flags): New declaration.
 704         * gdbarch.sh: Add get_pc_address_flags.
 705         * gdbarch.c: Regenerate.
 706         * gdbarch.h: Likewise.
 707         * stack.c (print_pc): New function.
 708         (print_frame_info) (print_frame): Call print_pc.
 709
 710 2019-08-16  Tom de Vries  <tdevries@suse.de>
 711
 712         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 713         print_objfile_section_info.
 714
 715 2019-08-15  Tom Tromey  <tom@tromey.com>
 716
 717         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 718         calling update_cmdwin_start_line.
 719         * tui/tui-winsource.h (struct tui_source_window_base)
 720         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 721         <rerender>: Declare.
 722         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 723         Call rerender.
 724         (tui_source_window_base::set_new_height): Remove.
 725         (tui_source_window_base::rerender): Rename from
 726         do_make_visible_with_new_height.
 727         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 728         resize method.
 729         (tui_win_info::make_invisible_and_set_new_height)
 730         (tui_win_info::make_visible_with_new_height): Remove.
 731         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 732         Declare.
 733         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 734         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 735         do_make_visible_with_new_height>: Don't declare.
 736         <rerender>: Declare.
 737         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 738         set_new_height.
 739         (tui_data_window::do_make_visible_with_new_height): Remove.
 740         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 741         call tui_show_locator_content.
 742         (tui_gen_win_info::resize): Call rerender.
 743         (show_source_or_disasm_and_command): Don't call
 744         tui_show_locator_content.
 745         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 746         method.
 747         (struct tui_win_info) <rerender>: Declare.
 748         <set_new_height, make_invisible_and_set_new_height,
 749         make_visible_with_new_height>: Don't declare.
 750         * tui/tui-data.c (tui_win_list::rerender): New method.
 751         * tui/tui-command.h (struct tui_cmd_window)
 752         <do_make_visible_with_new_height>: Don't declare.
 753         * tui/tui-command.c
 754         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 755
 756 2019-08-15  Tom Tromey  <tromey@adacore.com>
 757
 758         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 759         * ada-lang.c (ada_enum_name): Likewise.
 760
 761 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 762
 763         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 764         leading underscore.
 765         (GdbOutputErrorFile): Likewise.
 766         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 767         accordingly.
 768         (execute_unwinders): Rename to have a leading underscore.
 769         (auto_load_packages): Likewise.
 770         (global scope): Adjust call to auto_load_packages accordingly.
 771         (GdbSetPythonDirectory): Likewise.
 772         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 773         instead of execute_unwinders.
 774
 775 2019-08-15  Tom Tromey  <tom@tromey.com>
 776
 777         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 778         (show_data): Don't change window visibility.
 779         (tui_gen_win_info::resize): Remove special case for command
 780         window.  Use wresize, when available.
 781         (show_source_or_disasm_and_command): Don't change window
 782         visibility.
 783         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 784         <make_visible>: New method.
 785         * tui/tui-command.c (tui_cmd_window::resize): New method.
 786
 787 2019-08-15  Tom Tromey  <tom@tromey.com>
 788
 789         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 790         (struct tui_source_windows): New.
 791         * tui/tui-winsource.c (tui_display_main): Update.
 792         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 793         (new_height_ok, parse_scrolling_args): Update.
 794         * tui/tui-layout.c (show_layout, show_data): Update.
 795         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 796         (tui_add_to_source_windows): Don't declare.
 797         * tui/tui-data.c (source_windows, tui_source_windows)
 798         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 799
 800 2019-08-15  Tom Tromey  <tom@tromey.com>
 801
 802         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 803         Rename from reset.
 804         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 805         * tui/tui-layout.c (show_source_disasm_command, show_data):
 806         Update.
 807         (tui_gen_win_info::resize): Rename.
 808         (show_source_or_disasm_and_command): Update.
 809         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 810         reset.
 811
 812 2019-08-15  Tom Tromey  <tom@tromey.com>
 813
 814         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 815         * tui/tui-interp.c (tui_interp::init): Don't call
 816         tui_initialize_static_data.
 817         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 818
 819 2019-08-15  Tom Tromey  <tom@tromey.com>
 820
 821         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 822         examine tui_win_list.
 823
 824 2019-08-15  Tom Tromey  <tom@tromey.com>
 825
 826         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 827         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 828         tui_clear_source_content.
 829         (tui_clear_source_content): Remove.
 830         (tui_source_window_base::do_erase_source_content): Hoist call to
 831         content.clear().
 832         * tui/tui-stack.c (tui_show_frame_info): Don't call
 833         tui_clear_source_content.
 834
 835 2019-08-15  Tom Tromey  <tom@tromey.com>
 836
 837         * tui/tui-winsource.h (struct tui_source_window_base)
 838         <do_erase_source_content>: New method.
 839         <erase_source_content>: New method.
 840         (tui_erase_source_content): Don't declare.
 841         * tui/tui-winsource.c (tui_clear_source_content): Update.
 842         (tui_source_window_base::do_erase_source_content): Rename from
 843         tui_erase_source_content.
 844         (tui_source_window_base::show_source_content): Update.
 845         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 846         * tui/tui-source.h (struct tui_source_window)
 847         <erase_source_content>: New method.
 848         * tui/tui-disasm.h (struct tui_disasm_window)
 849         <erase_source_content>: New method.
 850
 851 2019-08-15  Tom Tromey  <tom@tromey.com>
 852
 853         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 854         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 855         constructor.
 856         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 857         * tui/tui-source.c (tui_set_source_content): Update.
 858         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 859
 860 2019-08-15  Tom Tromey  <tom@tromey.com>
 861
 862         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 863         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 864         tui-source.c.
 865         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 866         Declare.
 867         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 868         method.
 869         (tui_source_window::maybe_update): Update.
 870
 871 2019-08-15  Tom Tromey  <tom@tromey.com>
 872
 873         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 874         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 875         tui-disasm.c.
 876         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 877         Declare.
 878         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 879         method.
 880         (tui_disasm_window::maybe_update): Update.
 881
 882 2019-08-15  Tom Tromey  <tom@tromey.com>
 883
 884         * tui/tui-winsource.h (struct tui_source_window_base)
 885         <maybe_update>: Declare.
 886         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 887         method.
 888         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 889         Declare.
 890         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 891         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 892         Declare.
 893         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 894
 895 2019-08-15  Tom Tromey  <tom@tromey.com>
 896
 897         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 898
 899 2019-08-15  Tom Tromey  <tom@tromey.com>
 900
 901         * tui/tui-wingeneral.c: Include tui-stack.h.
 902         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 903         (struct tui_locator_window): Move from tui-data.h.
 904         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 905         (tui_initialize_static_data): Move from tui-data.c.
 906         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 907         (struct tui_locator_window): Move to tui-stack.c.
 908         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 909         (tui_initialize_static_data): Move to tui-stack.c.
 910
 911 2019-08-15  Tom Tromey  <tom@tromey.com>
 912
 913         * tui/tui-layout.c (show_source_disasm_command)
 914         (show_source_or_disasm_and_command): Use make_visible method, not
 915         tui_make_window.
 916         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 917         Remove.
 918
 919 2019-08-15  Tom Tromey  <tom@tromey.com>
 920
 921         * tui/tui-wingeneral.h (tui_make_window): Update.
 922         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 923         parameter.
 924         (tui_gen_win_info::make_visible): Update.
 925         * tui/tui-regs.c (tui_data_window::display_registers_from):
 926         Update.
 927         * tui/tui-layout.c (show_source_disasm_command)
 928         (show_source_or_disasm_and_command): Update.
 929         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 930         (enum tui_box): Remove.
 931         (struct tui_win_info) <can_box>: New method.
 932         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 933         method.
 934
 935 2019-08-15  Tom de Vries  <tdevries@suse.de>
 936
 937         * linux-nat-trad.c: Include gdbarch.h.
 938
 939 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 940
 941         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 942         register sizes.
 943
 944 2019-08-14  Tom Tromey  <tromey@adacore.com>
 945
 946         * darwin-nat.c: Include gdbarch.h.
 947         * darwin-nat-info.c: Include gdbarch.h.
 948
 949 2019-08-13  Tom Tromey  <tom@tromey.com>
 950
 951         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 952         Remove.
 953         * tui/tui-data.c (tui_initialize_static_data): Update.
 954
 955 2019-08-13  Tom Tromey  <tom@tromey.com>
 956
 957         * tui/tui-winsource.h (struct tui_exec_info_window)
 958         <~tui_exec_info_window, maybe_allocate_content, get_content,
 959         m_content>: Remove.
 960         (struct tui_source_window_base) <set_exec_info_content,
 961         show_exec_info_content>: Don't declare.
 962         * tui/tui-winsource.c
 963         (tui_exec_info_window::maybe_allocate_content): Remove.
 964         (tui_source_window_base::update_exec_info): Rename from
 965         set_exec_info_content.
 966         (tui_source_window_base::show_exec_info_content)
 967         (tui_source_window_base::update_exec_info): Remove.
 968
 969 2019-08-13  Tom Tromey  <tom@tromey.com>
 970
 971         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 972         declare.
 973         * tui/tui-winsource.c (tui_update_source_window_as_is)
 974         (tui_update_source_windows_with_addr, tui_erase_source_content):
 975         Update.
 976         (tui_clear_exec_info_content): Remove.
 977
 978 2019-08-13  Tom Tromey  <tom@tromey.com>
 979
 980         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 981         declare.
 982         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 983         call tui_erase_exec_info_content.
 984         (tui_clear_exec_info_content): Rename from
 985         tui_erase_exec_info_content.
 986         (tui_clear_exec_info_content): Delete.
 987
 988 2019-08-13  Tom Tromey  <tom@tromey.com>
 989
 990         * tui/tui-winsource.h (struct tui_source_window_base)
 991         <show_exec_info_content>: Declare.
 992         (tui_show_exec_info_content): Don't declare.
 993         * tui/tui-winsource.c
 994         (tui_source_window_base::show_exec_info_content): Rename from
 995         tui_show_exec_info_content.
 996         (tui_source_window_base::update_exec_info): Update.
 997
 998 2019-08-13  Tom Tromey  <tom@tromey.com>
 999
1000         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1001         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1002         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1003         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1004         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1005         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1006         ... here.
1007
1008 2019-08-13  Tom Tromey  <tom@tromey.com>
1009
1010         * tui/tui-winsource.h (struct tui_source_window_base)
1011         <update_exec_info>: Declare.
1012         (tui_update_exec_info): Don't declare.
1013         * tui/tui-winsource.c (tui_update_source_window_as_is)
1014         (tui_source_window_base::refresh_all)
1015         (tui_update_all_breakpoint_info): Update.
1016         (tui_source_window_base::update_exec_info): Rename from
1017         tui_update_exec_info.
1018         * tui/tui-stack.c (tui_show_frame_info): Update.
1019
1020 2019-08-13  Tom Tromey  <tom@tromey.com>
1021
1022         * tui/tui-winsource.h (struct tui_source_window_base)
1023         <set_exec_info_content>: Declare.
1024         (tui_set_exec_info_content): Don't declare.
1025         * tui/tui-winsource.c
1026         (tui_source_window_base::set_exec_info_content): Rename from
1027         tui_set_exec_info_content.
1028         (tui_update_exec_info): Update.
1029
1030 2019-08-13  Tom Tromey  <tom@tromey.com>
1031
1032         * tui/tui-winsource.h (struct tui_source_window_base)
1033         <show_source_content>: Declare.
1034         (tui_show_source_content): Don't declare.
1035         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1036         (tui_source_window_base::show_source_content): Rename from
1037         tui_show_source_content.
1038         (tui_source_window_base::refresh_all): Update.
1039         * tui/tui-layout.c (show_source_disasm_command)
1040         (show_source_or_disasm_and_command): Update.
1041
1042 2019-08-13  Tom Tromey  <tom@tromey.com>
1043
1044         * tui/tui-winsource.c (tui_erase_source_content)
1045         (tui_show_source_content, tui_source_window_base::refresh_all):
1046         Update.
1047         * tui/tui-wingeneral.h
1048         (tui_check_and_display_highlight_if_needed): Don't declare.
1049         * tui/tui-wingeneral.c
1050         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1051         check_and_display_highlight_if_needed.
1052         * tui/tui-win.c (tui_rehighlight_all)
1053         (tui_win_info::make_visible_with_new_height): Update.
1054         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1055         (tui_data_window::erase_data_content)
1056         (tui_data_window::display_all_data): Update.
1057         * tui/tui-data.h (struct tui_win_info)
1058         <check_and_display_highlight_if_needed>: Declare.
1059
1060 2019-08-13  Tom Tromey  <tom@tromey.com>
1061
1062         * tui/tui-win.c (tui_resize_all): Call
1063         tui_delete_invisible_windows.
1064         * tui/tui-layout.c (show_layout): Call
1065         tui_delete_invisible_windows.
1066         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1067         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1068
1069 2019-08-13  Tom Tromey  <tom@tromey.com>
1070
1071         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1072         tui_add_win_to_layout.
1073
1074 2019-08-13  Tom Tromey  <tom@tromey.com>
1075
1076         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1077         * tui/tui-layout.c (tui_default_win_height): Now static.
1078
1079 2019-08-13  Tom Tromey  <tom@tromey.com>
1080
1081         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1082         single switch.
1083         (show_source_disasm_command, show_source_or_disasm_and_command):
1084         Don't check current layout.
1085
1086 2019-08-13  Tom Tromey  <tom@tromey.com>
1087
1088         * tui/tui-wingeneral.c (make_all_visible): Remove.
1089         (tui_make_all_invisible): Simplify.
1090         * tui/tui-layout.c (tui_make_all_invisible): Move from
1091         tui-wingeneral.c; simplify.
1092         (show_layout): Hoist call to tui_make_all_invisible.
1093         (show_data): Don't call tui_make_all_invisible.
1094
1095 2019-08-13  Tom Tromey  <tom@tromey.com>
1096
1097         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1098         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1099
1100 2019-08-13  Tom Tromey  <tom@tromey.com>
1101
1102         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1103         tui-data.c.
1104         (show_source_disasm_command, show_data)
1105         (show_source_or_disasm_and_command): Don't use
1106         tui_set_current_layout_to.
1107         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1108         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1109         tui-layout.c.
1110         (tui_set_current_layout_to): Remove.
1111
1112 2019-08-13  Tom Tromey  <tom@tromey.com>
1113
1114         * tui/tui-layout.c (tui_set_layout): Update.
1115         * tui/tui-data.h (struct tui_layout_def): Remove.
1116         (tui_layout_def): Don't declare.
1117         * tui/tui-data.c (layout_def): Remove.
1118         (tui_layout_def): Remove.
1119
1120 2019-08-13  Tom Tromey  <tom@tromey.com>
1121
1122         * tui/tui-winsource.h (struct tui_source_window_base)
1123         <clear_detail>: No longer "override".
1124         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1125         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1126         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1127         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1128         Remove.
1129         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1130
1131 2019-08-13  Tom Tromey  <tromey@adacore.com>
1132
1133         * tracepoint.c: Don't include readline.h or history.h.
1134
1135 2019-08-12  Tom Tromey  <tom@tromey.com>
1136
1137         * configure: Rebuild.
1138         * configure.ac: Check for readline 7.
1139         * NEWS: Mention readline 7 requirement.
1140         * README: Update.
1141
1142 2019-08-12  Tom Tromey  <tom@tromey.com>
1143
1144         * mingw-hdep.c (gdb_select): Remove readline hack.
1145
1146 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1147
1148         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1149         when the function fails.
1150
1151 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1152
1153         * s390-tdep.c (s390_type_align): New function.
1154         (s390_gdbarch_init): Set it as type_align gdbarch method.
1155
1156 2019-08-09  Tom de Vries  <tdevries@suse.de>
1157
1158         PR gdb/24591
1159         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1160         pc_low with relocation offset.
1161
1162 2019-08-07  Tom Tromey  <tromey@adacore.com>
1163
1164         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1165         (print_frame_args): Update.
1166         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1167         Update.
1168         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1169         * frame.h (struct frame_arg): Add initializers.
1170         <error>: Now a unique_xmalloc_ptr.
1171
1172 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1173
1174         * NEWS: Expand the Pointer Authentication entry.
1175         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1176         (aarch64_frame_unmask_lr): ... to this.
1177         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1178         Call aarch64_frame_unmask_lr.
1179         * frame.c (struct frame_info): Add "masked" variable.
1180         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1181         (fprint_frame): Check for masked pc.
1182         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1183         declarations.
1184         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1185         * stack.c (print_frame): Check for masked pc.
1186
1187 2019-08-06  Tom Tromey  <tom@tromey.com>
1188
1189         * stabsread.c (patch_block_stabs, read_one_struct_field)
1190         (read_enum_type): Use obstack_strndup.
1191         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1192         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1193         * dwarf2read.c (guess_full_die_structure_name)
1194         (anonymous_struct_prefix): Use obstack_strndup.
1195         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1196         * c-exp.y (yylex): Use obstack_strndup.
1197         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1198         (write_var_or_type): Use obstack_strndup.
1199
1200 2019-08-06  Tom Tromey  <tom@tromey.com>
1201
1202         * symfile.c (reread_symbols): Use obstack_strdup.
1203         * stabsread.c (read_type): Use obstack_strdup.
1204         * gdb_obstack.h (obstack_strdup): New overload.
1205         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1206         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1207         (dwarf2_canonicalize_name): Use obstack_strdup.
1208         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1209         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1210         Use obstack_strdup.
1211
1212 2019-08-06  Tom Tromey  <tom@tromey.com>
1213
1214         * gdb_obstack.h (obstack_strdup): Define.
1215         * gdb_obstack.c (obstack_strdup): Don't define.
1216
1217 2019-08-06  Tom Tromey  <tom@tromey.com>
1218
1219         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1220         obstack_strdup.
1221         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1222         obstack_strdup.
1223         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1224         * stabsread.c (common_block_start): Use obstack_strdup.
1225         * objfiles.c (set_objfile_main_name, objfile): Use
1226         obstack_strdup.
1227         * namespace.c (add_using_directive): Use obstack_strdup.
1228         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1229         * jit.c (finalize_symtab): Use obstack_strdup.
1230         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1231         (guess_partial_die_structure_name, partial_die_info::fixup)
1232         (dwarf2_name): Use obstack_strdup.
1233         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1234         obstack_strdup.
1235         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1236         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1237         obstack_strdup.
1238         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1239
1240 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1241
1242         * unittests/help-doc-selftests.c: New file.
1243         * Makefile.in: Add the new file.
1244
1245 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1246
1247         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1248         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1249         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1250         the trailing '.' is not output, and the first character is uppercased.
1251         (print_help_for_command): Update call to print_doc_line.
1252         (print_doc_of_command): Likewise.
1253         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1254         * cli/cli-option.c (append_indented_doc): Do not append newline.
1255         (build_help_option): Append newline after first appended_indented_doc
1256         only if a second call is done.
1257         (build_help): Append 2 new lines before each option, except the first
1258         one.
1259         * compile/compile.c (_initialize_compile): Add new lines after
1260         %OPTIONS%, when not at the end of the help.
1261         Change help doc or code
1262         producing the help doc to respect the invariants.
1263         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1264         Also removed the new line after 'Options:', as all other commands
1265         do not put an empty line between 'Options:' and the first option.
1266         * printcmd.c (_initialize_printcmd): Likewise.
1267         * stack.c (_initialize_stack): Likewise.
1268         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1269         incorrectly telling COMMAND is optional.
1270         * ada-lang.c (_initialize_ada_language): Change help doc or code
1271         producing the help doc to respect the invariants.
1272         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1273         * breakpoint.c (_initialize_breakpoint): Likewise.
1274         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1275         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1276         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1277         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1278         _initialize_cli_style): Likewise.
1279         * corelow.c (core_target_info): Likewise.
1280         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1281         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1282         * filesystem.c (_initialize_filesystem): Likewise.
1283         * frame.c (_initialize_frame): Likewise.
1284         * gnu-nat.c (add_task_commands): Likewise.
1285         * infcall.c (_initialize_infcall): Likewise.
1286         * infcmd.c (_initialize_infcmd): Likewise.
1287         * interps.c (_initialize_interpreter): Likewise.
1288         * language.c (_initialize_language): Likewise.
1289         * linux-fork.c (_initialize_linux_fork): Likewise.
1290         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1291         * maint.c (_initialize_maint_cmds): Likewise.
1292         * memattr.c (_initialize_mem): Likewise.
1293         * printcmd.c (_initialize_printcmd): Likewise.
1294         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1295         _RegEx): Likewise.
1296         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1297         * record-btrace.c (_initialize_record_btrace): Likewise.
1298         * record-full.c (_initialize_record_full): Likewise.
1299         * record.c (_initialize_record): Likewise.
1300         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1301         * regcache.c (_initialize_regcache): Likewise.
1302         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1303         _initialize_remote): Likewise.
1304         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1305         * serial.c (_initialize_serial): Likewise.
1306         * skip.c (_initialize_step_skip): Likewise.
1307         * source.c (_initialize_source): Likewise.
1308         * stack.c (_initialize_stack): Likewise.
1309         * symfile.c (_initialize_symfile): Likewise.
1310         * symtab.c (_initialize_symtab): Likewise.
1311         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1312         * top.c (init_main): Likewise.
1313         * tracefile-tfile.c (tfile_target_info): Likewise.
1314         * tracepoint.c (_initialize_tracepoint): Likewise.
1315         * tui/tui-win.c (_initialize_tui_win): Likewise.
1316         * utils.c (add_internal_problem_command): Likewise.
1317         * valprint.c (value_print_option_defs): Likewise.
1318
1319 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1320
1321         PR build/24886
1322         * configure.ac: Drop enable-libmcheck support.
1323         * configure, config.in: Rebuild.
1324         * libmcheck.m4: Remove.
1325         * acinclude.m4: Don't include it.
1326         * Makefile.in: Don't distribute it.
1327         * top.c (print_gdb_configuration): Don't mention it.
1328
1329 2019-08-06  Tom Tromey  <tom@tromey.com>
1330
1331         * utils.c (set_output_style): Sometimes pass stream to
1332         emit_style_escape.
1333         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1334         * record-btrace.c (btrace_insn_history): Update.
1335         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1336         method.
1337         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1338         Update initializers.
1339         <m_uiout>: New field.
1340         <m_di>: Move lower.
1341         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1342         Remove "uiout" parameter.
1343         (dump_insns): Update.
1344         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1345         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1346
1347 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1348
1349         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1350         (error_in_psymtab_expansion): Likewise.
1351         (lookup_symbol_via_quick_fns): Likewise.
1352         (basic_lookup_transparent_type_quick): Likewise.
1353         (basic_lookup_transparent_type_1): Likewise.
1354
1355 2019-08-06  Tom Tromey  <tromey@adacore.com>
1356
1357         * source.c (last_source_error): Now bool.
1358         (print_source_lines_base): Make "noprint" bool.  Only open
1359         source file when last_source_visited changes.
1360
1361 2019-08-06  Tom Tromey  <tromey@adacore.com>
1362
1363         * annotate.c (annotate_source_line): Use g_source_cache.
1364         * source-cache.c (source_cache::get_plain_source_lines): Change
1365         parameters.  Populate m_offset_cache.
1366         (source_cache::ensure): New method.
1367         (source_cache::get_line_charpos): New method.
1368         (extract_lines): Move lower.  Change parameters.
1369         (source_cache::get_source_lines): Move lower.
1370         * source-cache.h (class source_cache): Update comment.
1371         <get_line_charpos>: New method.
1372         <get_source_lines>: Update comment.
1373         <clear>: Clear m_offset_cache.
1374         <get_plain_source_lines>: Change parameters.
1375         <ensure>: New method
1376         <m_offset_cache>: New member.
1377         * source.c (forget_cached_source_info_for_objfile): Update.
1378         (info_source_command): Use g_source_cache.
1379         (find_source_lines, open_source_file_with_line_charpos): Remove.
1380         (print_source_lines_base, search_command_helper): Use g_source_cache.
1381         * source.h (open_source_file_with_line_charpos): Don't declare.
1382         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1383         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1384         Use g_source_cache.
1385
1386 2019-08-06  Tom Tromey  <tromey@adacore.com>
1387
1388         * source-cache.c (source_cache::get_plain_source_lines):
1389         Remove "first_line" and "last_line" parameters.
1390         (source_cache::get_source_lines): Cache plain text.
1391         * source-cache.h (class source_cache)
1392         <get_plain_source_lines>: Update.
1393
1394 2019-08-06  Tom Tromey  <tromey@adacore.com>
1395
1396         * source-cache.c (extract_lines): No longer a method.
1397         Changed type of parameter.  Include final newline.
1398         (selftests::extract_lines_test): New function.
1399         (_initialize_source_cache): Likewise.
1400         * source-cache.h (class source_cache)
1401         <extract_lines>: Don't declare.
1402
1403 2019-08-06  Tom Tromey  <tromey@adacore.com>
1404
1405         * breakpoint.c (init_breakpoint_sal): Update.
1406         (breakpoint): Update.
1407         * breakpoint.h (struct breakpoint) <filter>: Now a
1408         unique_xmalloc_ptr.
1409
1410 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1411
1412         * NEWS: Mention dictionary access on blocks.
1413         * python/py-block.c (blpy_getitem): New function.
1414         (block_object_as_mapping): New struct.
1415         (block_object_type): Use new struct for tp_as_mapping field.
1416
1417 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1418
1419         * objfiles.h (objfile): Add a comment describing partial symbols.
1420
1421 2019-08-05  Tom Tromey  <tromey@adacore.com>
1422
1423         * compile/compile.c (_initialize_compile): Use _(), not N_().
1424         * thread.c (_initialize_thread): Use _(), not N_().
1425         * stack.c (_initialize_stack): Use _(), not N_().
1426         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1427
1428 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1429
1430         * dwarf2read.c (struct dw2_symtab_iterator):
1431         <want_specific_block>: Remove.
1432         <block_index>: Change type to gdb::optional.
1433         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1434         change type of BLOCK_INDEX parameter to gdb::optional.
1435         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1436         (dw2_lookup_symbol): Don't pass argument for
1437         WANT_SPECIFIC_BLOCK.
1438         (dw2_expand_symtabs_for_function): Don't pass argument for
1439         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1440         (class dw2_debug_names_iterator)
1441         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1442         parameter, change BLOCK_INDEX type to gdb::optional.
1443         <m_want_specific_block>: Remove.
1444         <m_block_index>: Change type to gdb::optional.
1445         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1446         gdb::optional.  Re-write in function of gdb::optional.
1447         (dw2_debug_names_lookup_symbol): Don't pass argument for
1448         WANT_SPECIFIC_BLOCK.
1449         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1450         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1451         BLOCK_INDEX.
1452
1453 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1454
1455         * NEWS: Mention changes to "info sources" command.
1456
1457 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1458
1459         * symtab.c (filename_partial_match_opts): New struct type.
1460         (struct output_source_filename_data): New members
1461         regexp, c_regexp, partial_match.
1462         (output_source_filename): Use new members to decide to print file.
1463         (info_sources_option_defs): New variable.
1464         (make_info_sources_options_def_group, print_info_sources_header,
1465         info_sources_command_completer):
1466         New functions.
1467         (info_sources_command): Read new optional arguments.
1468         (_initialize_symtab): Update info sources help.
1469
1470 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1471
1472         * ada-lang.c (exception_support_info_v0): Renamed from...
1473         (default_exception_support_info): ... this.  Create new
1474         definition for v1.
1475         (ada_has_this_exception_support): Look up catch_handlers_sym.
1476         (ada_exception_support_info_sniffer): Try v0 after default.
1477
1478 2019-08-01  Tom Tromey  <tromey@adacore.com>
1479
1480         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1481         gdbarch.h.
1482
1483 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1484
1485         * s12z-tdep.c: Fix include path for s12z-opc.h.
1486
1487 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1488
1489         * NEWS: Require GNU make 3.82.
1490
1491 2019-07-16  Tom Tromey  <tom@tromey.com>
1492
1493         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1494         declare.
1495
1496 2019-07-30  Tom Tromey  <tromey@adacore.com>
1497
1498         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1499
1500 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1501
1502         * printcmd.c (print_address_symbolic): Print negative offsets.
1503         (build_address_symbolic): Force signed arithmetic when computing
1504         offset.
1505
1506 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1507
1508         PR/24474: Add a function to lookup static variables.
1509         * NEWS: Mention this new function.
1510         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1511         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1512         * python/python.c (python_GdbMethods): Add new function.
1513
1514 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1515
1516         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1517         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1518         (objfpy_lookup_static_symbol): New function.
1519         (objfile_object_methods): Add new functions.
1520
1521 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1522
1523         * NEWS: Mention 'set|show print frame-info'.  Mention new
1524         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1525         backtrace argument.  Mention that python frame filtering code
1526         is now consistent with what 'backtrace' command prints.
1527
1528 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1529
1530         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1531         comments.
1532         (print_frame_info_auto, print_frame_info_source_line,
1533         print_frame_info_location, print_frame_info_source_and_location,
1534         print_frame_info_location_and_address, print_frame_info_short_location):
1535         New declarations.
1536         (struct frame_print_options): New member print_frame_info.
1537         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1538         * stack.h (get_user_print_what_frame_info): New declaration.
1539         (frame_show_address): New declaration.
1540         * stack.c (print_frame_arguments_choices): New value 'presence'.
1541         (print_frame_info_auto, print_frame_info_source_line,
1542         print_frame_info_location, print_frame_info_source_and_location,
1543         print_frame_info_location_and_address, print_frame_info_short_location,
1544         print_frame_info_choices, print_frame_info_print_what): New definitions.
1545         (print_frame_args): Only print dots for args if print frame-arguments
1546         is 'presence'.
1547         (frame_print_option_defs): New element for "frame-info".
1548         (get_user_print_what_frame_info): New function.
1549         (frame_show_address): Make non static.  Move comment to stack.h.
1550         (print_frame_info_to_print_what): New function.
1551         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1552         to decide what to print.
1553         (backtrace_command_1): Handle the new print_frame_arguments_presence
1554         value.
1555         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1556         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1557         (py_print_frame): In non-mi mode, use LOCATION as default for
1558         print_what, similarly to frame information printed directly by
1559         backtrace command. Handle frame-info user option in non MI mode.
1560
1561 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1562
1563         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1564         Add case for debugging 32-bit target on 64-bit host.  Revise
1565         comment.
1566
1567 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1568
1569         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1570         instead of find_function_entry_range_from_pc.
1571
1572 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1573
1574         * stack.c (find_frame_funname): Remove code which preferred
1575         minsym over symtab sym in "certain pathological cases".
1576
1577         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1578         parameter.  Change type of "do_demangle" to bool.
1579         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1580         Pass suitable "prefer_sym_over_minsym" flag to
1581         build_address_symbolic().  Don't output "+" for negative offsets.
1582         * printcmd.c (print_address_symbolic): Update invocation of
1583         build_address_symbolic to include a "prefer_sym_over_minsym"
1584         flag.
1585         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1586         Restrict cases in which use of minimal symbol is preferred to that
1587         of a found symbol.  Update comments.
1588
1589         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1590         for entry pc when entry pc is out of range for that FDE.
1591
1592 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1593
1594         PR gdb/24839:
1595         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1596         type.
1597
1598 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1599
1600         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1601         this function's Python signature.
1602
1603
1604 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1605
1606         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1607         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1608         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1609         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1610         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1611
1612
1613 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1614
1615         * h8300-tdep.c (h8300_register_name_common): New.
1616         h8300_register_name): Use h8300_register_name_common.
1617         (h8300s_register_name): Likewise.
1618         (h8300sx_register_name): Likewise.
1619         (h8300h_register_nam): New.
1620         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1621
1622
1623 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1624
1625         * arm-tdep.c (arm_skip_cmse_entry): New function.
1626         (arm_is_sgstubs_section): New function.
1627         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1628
1629 2019-07-22  Tom Tromey  <tom@tromey.com>
1630
1631         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1632         Don't self-assign.
1633
1634 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1635
1636         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1637         type_print.
1638
1639 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1640
1641         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1642         so that GDB doesn't match any msymbols when searching in the
1643         TYPES_DOMAIN.
1644         (print_symbol_info): Print using typedef_print or type_print based
1645         on the type of the symbol.  Add updated FIXME comment moved from...
1646         (_initialize_symtab): ... move and update FIXME comment to above.
1647
1648 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1649
1650         * NEWS: Mention adding -q option to "info types".
1651         * symtab.c (struct info_types_options): New struct.
1652         (info_types_options_defs): New variable.
1653         (make_info_types_options_def_group): New function.
1654         (info_types_command): Use gdb::option framework to parse options.
1655         (info_types_command_completer): New function.
1656         (_initialize_symtab): Extend the help text on "info types" and
1657         register command completer.
1658
1659 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1660
1661         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1662         (lookup_symbol_in_objfile): Change int to block_enum and add a
1663         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1664
1665 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1666
1667         * MAINTAINERS (Write After Approval): Add self.
1668
1669 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1670
1671         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1672         instruction to the dummy code region.
1673
1674 2019-07-19  Tom Tromey  <tromey@adacore.com>
1675
1676         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1677         (ARGSUSED, PARAMS, __func__): Remove rules.
1678
1679 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1680
1681         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1682         * features/arm/arm-with-iwmmxt.c: Remove.
1683         * features/arm/arm-with-iwmmxt.xml: Remove.
1684         * features/arm/arm-with-m-fpa-layout.c: Remove.
1685         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1686         * features/arm/arm-with-m-vfp-d16.c: Remove.
1687         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1688         * features/arm/arm-with-m.c: Remove.
1689         * features/arm/arm-with-m.xml: Remove.
1690         * features/arm/arm-with-neon.c: Remove.
1691         * features/arm/arm-with-neon.xml: Remove.
1692         * features/arm/arm-with-vfpv2.c: Remove.
1693         * features/arm/arm-with-vfpv2.xml: Remove.
1694         * features/arm/arm-with-vfpv3.c: Remove.
1695         * features/arm/arm-with-vfpv3.xml: Remove.
1696
1697 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1698
1699         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1700
1701 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1702
1703         * arch/aarch32.c (aarch32_create_target_description): Create
1704         target descriptions using features.
1705         * arch/arm.c (arm_create_target_description)
1706         (arm_create_mprofile_target_description): Likewise.
1707         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1708
1709 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1710
1711         * Makefile.in: Add new files.
1712         * aarch32-tdep.c: New file.
1713         * aarch32-tdep.h: New file.
1714         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1715         Call aarch32_read_description.
1716         * arch/aarch32.c: New file.
1717         * arch/aarch32.h: New file.
1718         * arch/arm.c (arm_create_target_description)
1719         (arm_create_mprofile_target_description): New function.
1720         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1721         (arm_create_target_description)
1722         (arm_create_mprofile_target_description): New declaration.
1723         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1724         read_description functions.
1725         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1726         Likewise.
1727         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1728         * arm-tdep.c (tdesc_arm_list): New variable.
1729         (arm_register_g_packet_guesses): Call create description functions.
1730         (arm_read_description) (arm_read_mprofile_description): New
1731         function.
1732         * arm-tdep.h (arm_read_description)
1733         (arm_read_mprofile_description): Add declaration.
1734         * configure.tgt: Add new files.
1735
1736 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1737
1738         * top.c (new_ui_command): Open specified terminal just once.
1739
1740 2019-07-18  Tom Tromey  <tromey@adacore.com>
1741
1742         * symtab.c (main_name): Constify return type.
1743         * symfile.c (set_initial_language): Update.
1744         * symtab.h (main_name): Constify return type.
1745
1746 2019-07-17  Tom Tromey  <tom@tromey.com>
1747
1748         * tui/tui-winsource.c (tui_update_source_window)
1749         (tui_update_source_window_as_is)
1750         (tui_update_source_windows_with_line): Remove return.
1751         * tui/tui-disasm.c (tui_show_disassem)
1752         (tui_show_disassem_and_update_source): Remove return.
1753         * tui/tui.c (tui_reset): Remove return.
1754         * tui/tui-wingeneral.c
1755         (tui_check_and_display_highlight_if_needed): Remove return.
1756
1757 2019-07-17  Tom Tromey  <tom@tromey.com>
1758
1759         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1760
1761 2019-07-17  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-winsource.h (struct tui_exec_info_window)
1764         (struct tui_source_window_base): Move from tui-data.h.
1765         * tui/tui-winsource.c: Move many method definitions from
1766         elsewhere.  Remove "structuring" comments.
1767         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1768         (tui_source_window_base::refresh_window): Move to
1769         tui-winsource.c.
1770         * tui/tui-win.c (tui_source_window_base::refresh_all)
1771         (tui_source_window_base::update_tab_width)
1772         (tui_source_window_base::set_new_height)
1773         (tui_source_window_base::do_make_visible_with_new_height): Move to
1774         tui-winsource.c.
1775         * tui/tui-source.h: Update.
1776         * tui/tui-source.c (tui_source_window_base::reset): Move to
1777         tui-winsource.c.
1778         * tui/tui-disasm.h: Update.
1779         * tui/tui-data.h (struct tui_exec_info_window): Move to
1780         tui-winsource.h.
1781         (struct tui_source_window_base): Likewise.
1782         * tui/tui-data.c (tui_source_window_base::clear_detail)
1783         (tui_source_window_base, ~tui_source_window_base): Move to
1784         tui-winsource.c.
1785
1786 2019-07-17  Tom Tromey  <tom@tromey.com>
1787
1788         * tui/tui-win.c (tui_resize_all)
1789         (tui_source_window_base::update_tab_width)
1790         (tui_adjust_win_heights): Update.
1791         (tui_win_info::make_invisible_and_set_new_height): Rename from
1792         make_invisible_and_set_new_height.
1793         * tui/tui-data.h (struct tui_win_info)
1794         <make_invisible_and_set_new_height>: New method.
1795
1796 2019-07-17  Tom Tromey  <tom@tromey.com>
1797
1798         * tui/tui.c: Update.
1799         * tui/tui-source.h (struct tui_source_window): Move from
1800         tui-data.h.
1801         * tui/tui-layout.c: Update.
1802         * tui/tui-disasm.c: Update.
1803         * tui/tui-data.h (struct tui_source_window): Move to
1804         tui-source.h.
1805
1806 2019-07-17  Tom Tromey  <tom@tromey.com>
1807
1808         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1809         tui-data.h.
1810         * tui/tui-data.h (struct tui_disasm_window): Move to
1811         tui-disasm.h.
1812
1813 2019-07-17  Tom Tromey  <tom@tromey.com>
1814
1815         * tui/tui-regs.h (struct tui_data_item_window): Move from
1816         tui-data.h.
1817         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1818         * tui/tui-data.h (struct tui_data_item_window): Move to
1819         tui-regs.h.
1820         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1821
1822 2019-07-17  Tom Tromey  <tom@tromey.com>
1823
1824         * tui/tui.c: Update.
1825         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1826         (tui_cmd_window::max_height): Move to tui-command.c.
1827         * tui/tui-layout.c: Update.
1828         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1829         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1830         tui-command.c.
1831         * tui/tui-command.h (struct tui_cmd_window): Move from
1832         tui-data.h.
1833         * tui/tui-command.c: Remove "structuring" comments.
1834         (tui_cmd_window::clear_detail)
1835         (tui_cmd_window::do_make_visible_with_new_height)
1836         (tui_cmd_window::max_height): Move from elsewhere.
1837
1838 2019-07-17  Tom Tromey  <tom@tromey.com>
1839
1840         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1841         Now static.
1842         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1843         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1844
1845 2019-07-17  Tom Tromey  <tom@tromey.com>
1846
1847         * tui/tui.c: Update.
1848         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1849         tui-regs.c.
1850         * tui/tui-windata.h: Remove file.
1851         * tui/tui-windata.c: Remove file.
1852         * tui/tui-win.c (tui_data_window::set_new_height)
1853         (tui_data_window::do_make_visible_with_new_height): Move to
1854         tui-regs.c.
1855         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1856         * tui/tui-regs.c: Remove "structuring" comments.
1857         (tui_data_window::first_data_item_displayed)
1858         (tui_data_window::delete_data_content_windows)
1859         (tui_data_window::erase_data_content)
1860         (tui_data_window::display_all_data)
1861         (tui_data_window::refresh_all)
1862         (tui_data_window::do_scroll_vertical)
1863         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1864         (tui_data_window::do_make_visible_with_new_height)
1865         (tui_data_window::refresh_window): Move from elsewhere.
1866         (_initialize_tui_regs): Move to end of file.
1867         * tui/tui-layout.c: Update.
1868         * tui/tui-hooks.c: Update.
1869         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1870         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1871         tui-regs.c.
1872         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1873
1874 2019-07-17  Tom Tromey  <tom@tromey.com>
1875
1876         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1877         seen.
1878
1879 2019-07-17  Tom Tromey  <tom@tromey.com>
1880
1881         * tui/tui-win.c (tui_source_window_base::set_new_height)
1882         (tui_source_window_base::do_make_visible_with_new_height): Use
1883         m_has_locator field directly.
1884         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1885         method.
1886         (struct tui_source_window_base) <has_locator>: Likewise.
1887
1888 2019-07-17  Tom Tromey  <tom@tromey.com>
1889
1890         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1891         Don't declare.
1892         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1893         Remove.
1894         * tui/tui-win.c (tui_source_window_base::set_new_height)
1895         (tui_source_window_base::set_new_height)
1896         (make_invisible_and_set_new_height)
1897         (tui_source_window_base::do_make_visible_with_new_height)
1898         (tui_source_window_base::do_make_visible_with_new_height):
1899         Update.
1900         * tui/tui-layout.c (show_source_disasm_command, show_data)
1901         (show_source_or_disasm_and_command): Update.
1902         * tui/tui-layout.c (show_layout): Update.
1903
1904 2019-07-17  Tom Tromey  <tom@tromey.com>
1905
1906         * tui/tui-layout.c (make_data_window): Remove.
1907         (show_data): Unify creation and re-initialization cases.
1908
1909 2019-07-17  Tom Tromey  <tom@tromey.com>
1910
1911         * tui/tui-layout.c (make_source_window, make_disasm_window):
1912         Remove.
1913         (show_data): Unify creation and re-initialization cases.
1914
1915 2019-07-17  Tom Tromey  <tom@tromey.com>
1916
1917         * tui/tui-layout.c (make_command_window): Remove.
1918         (show_source_disasm_command, show_source_or_disasm_and_command):
1919         Unify creation and re-initialization cases.
1920
1921 2019-07-17  Tom Tromey  <tom@tromey.com>
1922
1923         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1924         creation and re-initialization cases.
1925
1926 2019-07-17  Tom Tromey  <tom@tromey.com>
1927
1928         * tui/tui-regs.c (tui_get_register): Return void.
1929
1930 2019-07-17  Tom Tromey  <tom@tromey.com>
1931
1932         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1933         Simplify.
1934
1935 2019-07-17  Tom Tromey  <tom@tromey.com>
1936
1937         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1938         resetting.
1939
1940 2019-07-17  Tom Tromey  <tom@tromey.com>
1941
1942         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1943         * tui/tui-regs.c (tui_reg_layout): New function.
1944         (tui_show_registers, tui_reg_command): Use it.
1945         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1946         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1947         parameters.
1948         (tui_layout_command): Remove.
1949
1950 2019-07-17  Tom Tromey  <tom@tromey.com>
1951
1952         * tui/tui-layout.h (tui/tui-layout): Return void.
1953         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1954
1955 2019-07-17  Tom Tromey  <tom@tromey.com>
1956
1957         * tui/tui-layout.c (show_source_disasm_command, show_data):
1958         Update.
1959         (reset_locator): Remove.
1960         (show_source_or_disasm_and_command): Update.
1961
1962 2019-07-17  Tom Tromey  <tom@tromey.com>
1963
1964         * tui/tui-source.c (tui_source_window_base::reset): Remove
1965         win_type parameter.
1966         * tui/tui-layout.c (make_command_window, make_source_window)
1967         (make_disasm_window, make_data_window)
1968         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1969         (reset_locator, show_source_or_disasm_and_command): Update.
1970         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1971         win_type parameter.
1972         (struct tui_source_window_base) <reset>: Likewise.
1973
1974 2019-07-17  Tom Tromey  <tom@tromey.com>
1975
1976         * tui/tui-layout.c (show_source_disasm_command): Use
1977         reset_locator.
1978         (reset_locator): New function.
1979         (init_and_make_win): Remove.
1980         (show_source_or_disasm_and_command): Use reset_locator.
1981
1982 2019-07-17  Tom Tromey  <tom@tromey.com>
1983
1984         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1985         condition.
1986         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1987         Remove condition.
1988         * tui/tui-source.c (tui_source_window_base::reset): New method.
1989         * tui/tui-layout.c (make_command_window): Don't call
1990         init_and_make_win.
1991         (make_source_window, make_disasm_window): Don't call
1992         make_source_or_disasm_window.
1993         (make_data_window): Don't call init_and_make_win.  Change calling
1994         convention.
1995         (show_source_disasm_command, show_data): Simplify.
1996         (make_source_or_disasm_window): Remove.
1997         (show_source_or_disasm_and_command): Simplify.
1998         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1999         (struct tui_source_window_base) <reset>: Likewise.
2000         <execution_info>: Remove initializer.
2001         * tui/tui-data.c (tui_source_window_base): Initialize
2002         execution_info.
2003
2004 2019-07-17  Tom Tromey  <tom@tromey.com>
2005
2006         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2007         variable.
2008
2009 2019-07-17  Tom Tromey  <tom@tromey.com>
2010
2011         * tui/tui.c (tui_rl_other_window): Update.
2012         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2013         superclass method first.  Always iterate over regs_content.
2014         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2015         method.
2016         * tui/tui-win.c (tui_set_focus_command): Update.
2017
2018 2019-07-17  Tom Tromey  <tom@tromey.com>
2019
2020         * tui/tui-win.c (tui_set_focus_command): Rename from
2021         tui_set_focus.  Call tui_enable.
2022         (tui_set_focus_command): Remove.
2023
2024 2019-07-17  Tom Tromey  <tom@tromey.com>
2025
2026         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2027         refresh_window.
2028         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2029         touchwin.
2030         (tui_data_window::refresh_window): Call refresh_window on data
2031         items.  Always call superclass refresh_window.
2032         (tui_win_info::refresh): Remove.
2033         (tui_source_window_base::refresh_window): Update.
2034         (tui_refresh_all): Update.
2035         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2036         refresh_window.
2037         (show_source_or_disasm_and_command): Likewise.
2038         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2039         (struct tui_source_window_base) <refresh>: Likewise.
2040
2041 2019-07-17  Tom Tromey  <tom@tromey.com>
2042
2043         * tui/tui-winsource.c (tui_clear_source_content)
2044         (tui_show_source_content): Update.
2045         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2046         whether content is empty.
2047         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2048         Remove.
2049
2050 2019-07-17  Tom Tromey  <tom@tromey.com>
2051
2052         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2053         window's contents.
2054         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2055         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2056
2057 2019-07-17  Tom Tromey  <tom@tromey.com>
2058
2059         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2060         (struct tui_data_item_window): Update.
2061
2062 2019-07-17  Tom Tromey  <tom@tromey.com>
2063
2064         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2065         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2066         defines.
2067
2068 2019-07-17  Tom Tromey  <tom@tromey.com>
2069
2070         * tui/tui-winsource.h (tui_erase_source_content)
2071         (tui_clear_source_content): Remove "display_prompt" parameter.
2072         * tui/tui-winsource.c (tui_update_source_window_as_is)
2073         (tui_update_source_windows_with_addr): Update.
2074         (tui_clear_source_content): Remove "display_prompt" parameter.
2075         (tui_erase_source_content): Likewise.  Simplify.
2076         (tui_show_source_content): Update.
2077         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2078         * tui/tui-stack.c (tui_show_frame_info): Update.
2079         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2080         Remove defines.
2081
2082 2019-07-17  Tom Tromey  <tom@tromey.com>
2083
2084         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2085         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2086         parameter.
2087         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2088         parameter.
2089
2090 2019-07-17  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui-winsource.c (tui_clear_source_content)
2093         (tui_show_source_content, tui_show_exec_info_content)
2094         (tui_clear_exec_info_content): Update.
2095         * tui/tui-stack.c (tui_show_locator_content): Update.
2096         (tui_show_frame_info): Update.
2097         * tui/tui-source.h (tui_source_window): Don't declare.
2098         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2099         from tui_source_is_displayed.
2100         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2101         Remove field.
2102         (struct tui_source_window_base) <content_in_use>: New field.  Now
2103         bool.
2104         (struct tui_source_window) <showing_source_p>: New method.
2105         (TUI_SRC_WIN): Change cast.
2106         * tui/tui-data.c (tui_initialize_static_data): Update.
2107
2108 2019-07-17  Tom Tromey  <tom@tromey.com>
2109
2110         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2111         location_matches_p.
2112         * tui/tui-source.c (tui_source_window::location_matches_p): New
2113         method.
2114         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2115         method.
2116         * tui/tui-data.h (struct tui_source_window_base)
2117         <location_matches_p>: New method.
2118         (struct tui_source_window, struct tui_disasm_window)
2119         <location_matches_p>: Likewise.
2120
2121 2019-07-17  Tom Tromey  <tom@tromey.com>
2122
2123         * tui/tui-win.c (tui_set_win_height_command): Rename from
2124         tui_set_win_height.
2125         (tui_set_win_height_command): Remove.
2126
2127 2019-07-17  Tom Tromey  <tom@tromey.com>
2128
2129         * tui/tui-source.c (tui_source_window): New constructor.  Add
2130         observer.
2131         (~tui_source_window): New destructor.
2132         (tui_source_window::style_changed): New method.
2133         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2134         (tui_attach_detach_observers): Update.
2135         * tui/tui-data.h (struct tui_source_window): Make constructor not
2136         inline.  Add destructor.
2137         (struct tui_source_window) <style_changed>: New method.
2138         <m_observable>: New member.
2139
2140 2019-07-17  Tom Tromey  <tom@tromey.com>
2141
2142         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2143         * tui/tui-win.c (tui_resize_all): Fix typo.
2144
2145 2019-07-17  Tom Tromey  <tom@tromey.com>
2146
2147         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2148         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2149         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2150         * tui/tui-win.c (window_name_completer): Use foreach.
2151         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2152         (update_tab_width): Likewise.
2153         * tui/tui-layout.c (show_layout): Update.
2154         * tui/tui-data.h (class tui_window_iterator): New.
2155         (struct all_tui_windows): New.
2156         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2157
2158 2019-07-17  Tom Tromey  <tom@tromey.com>
2159
2160         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2161         parameter.  Don't reference globals.
2162         (tui_reg_command): Update.
2163
2164 2019-07-17  Tom Tromey  <tom@tromey.com>
2165
2166         * tui/tui-regs.c (tui_show_registers): Simplify.
2167
2168 2019-07-17  Tom Tromey  <tom@tromey.com>
2169
2170         * tui/tui-regs.c (tui_show_registers): Update.
2171         (tui_show_register_group): Add win_info parameter.
2172
2173 2019-07-17  Tom Tromey  <tom@tromey.com>
2174
2175         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2176         Rename from tui_display_reg_element_at_line.
2177         (tui_data_window::display_registers_from_line): Update.
2178         * tui/tui-data.h (struct tui_data_window)
2179         <display_reg_element_at_line>: New method.
2180
2181 2019-07-17  Tom Tromey  <tom@tromey.com>
2182
2183         * tui/tui-regs.h (tui_display_registers_from)
2184         (tui_display_registers_from_line): Don't declare.
2185         * tui/tui-windata.c (tui_data_window::display_all_data)
2186         (tui_data_window::refresh_all)
2187         (tui_data_window::do_scroll_vertical): Update.
2188         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2189         from tui_display_registers_from.
2190         (tui_display_reg_element_at_line): Update.
2191         (tui_data_window::display_registers_from_line): Rename from
2192         tui_display_registers_from_line.
2193         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2194         display_registers_from_line>: New methods.
2195
2196 2019-07-17  Tom Tromey  <tom@tromey.com>
2197
2198         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2199         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2200         from tui_erase_data_content.
2201         (tui_data_window::display_all_data)
2202         (tui_data_window::refresh_all)
2203         (tui_data_window::do_scroll_vertical): Update.
2204         * tui/tui-regs.c (tui_show_registers): Update.
2205         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2206         New method.
2207
2208 2019-07-17  Tom Tromey  <tom@tromey.com>
2209
2210         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2211         declare.
2212         * tui/tui-windata.c
2213         (tui_data_window::delete_data_content_windows): Rename from
2214         tui_delete_data_content_windows.
2215         (tui_data_window::display_all_data)
2216         (tui_data_window::do_scroll_vertical): Update.
2217         * tui/tui-data.h (struct tui_data_window)
2218         <delete_data_content_windows>: New method.
2219
2220 2019-07-17  Tom Tromey  <tom@tromey.com>
2221
2222         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2223         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2224
2225 2019-07-17  Tom Tromey  <tom@tromey.com>
2226
2227         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2228         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2229         from tui_display_all_data.
2230         * tui/tui-win.c
2231         (tui_data_window::do_make_visible_with_new_height): Update.
2232         * tui/tui-regs.c (tui_show_registers): Update.
2233         * tui/tui-layout.c (tui_set_layout): Update.
2234         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2235         method.
2236
2237 2019-07-17  Tom Tromey  <tom@tromey.com>
2238
2239         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2240         * tui/tui-windata.c (tui_display_data_from): Remove.
2241         (tui_data_window::refresh_all): Update.
2242
2243 2019-07-17  Tom Tromey  <tom@tromey.com>
2244
2245         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2246         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2247         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2248         tui_display_registers_from_line.
2249         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2250         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2251         "force_display" parameter.
2252
2253 2019-07-17  Tom Tromey  <tom@tromey.com>
2254
2255         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2256         declare.
2257         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2258         Rename from tui_first_reg_element_no_inline.
2259         (tui_display_reg_element_at_line)
2260         (tui_display_registers_from_line): Update.
2261         * tui/tui-data.h (struct tui_data_window)
2262         <first_reg_element_no_inline>: New method.
2263
2264 2019-07-17  Tom Tromey  <tom@tromey.com>
2265
2266         * tui/tui-windata.c (tui_display_data_from)
2267         (tui_data_window::do_scroll_vertical): Update.
2268         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2269         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2270         Rename from tui_line_from_reg_element_no.
2271         (tui_display_registers_from_line): Update.
2272         * tui/tui-data.h (struct tui_data_window)
2273         <line_from_reg_element_no>: New method.
2274
2275 2019-07-17  Tom Tromey  <tom@tromey.com>
2276
2277         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2278         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2279         tui_last_regs_line_no.
2280         (tui_display_reg_element_at_line)
2281         (tui_display_registers_from_line): Update.
2282         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2283         method.
2284
2285 2019-07-17  Tom Tromey  <tom@tromey.com>
2286
2287         PR tui/24722:
2288         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2289         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2290         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2291         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2292         (tui_update_breakpoint_info): Likewise.
2293         * tui/tui-hooks.c (tui_event_create_breakpoint)
2294         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2295         Update.
2296
2297 2019-07-17  Tom Tromey  <tom@tromey.com>
2298
2299         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2300
2301 2019-07-17  Tom Tromey  <tom@tromey.com>
2302
2303         * tui/tui-winsource.c (tui_update_source_window_as_is)
2304         (tui_update_source_windows_with_addr): Update.
2305         * tui/tui-source.h (tui_set_source_content)
2306         (tui_show_symtab_source): Add "win_info" parameter.
2307         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2308         parameter.
2309         (tui_show_symtab_source): Likewise.
2310
2311 2019-07-17  Tom Tromey  <tom@tromey.com>
2312
2313         * tui/tui-wingeneral.c
2314         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2315
2316 2019-07-17  Tom Tromey  <tom@tromey.com>
2317
2318         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2319         (struct tui_cmd_window) <can_scroll>: New method.
2320         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2321         method.
2322
2323 2019-07-17  Tom Tromey  <tromey@adacore.com>
2324
2325         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2326         do_field_signed>: Rename.  Change type of "value".
2327         * ui-out.c (ui_out::field_signed): Rename from field_int.
2328         Change type of "value".
2329         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2330         type of "value".
2331         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2332         do_field_int.  Change type of "value".
2333         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2334         do_field_int.  Change type of "value".
2335         * tracepoint.c (trace_status_mi, tfind_1)
2336         (print_one_static_tracepoint_marker): Update.
2337         * thread.c (print_thread_info_1, print_selected_thread_frame):
2338         Update.
2339         * stack.c (print_frame, print_frame_info): Update.
2340         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2341         Update.
2342         * source.c (print_source_lines_base): Update.
2343         * skip.c (info_skip_command): Update.
2344         * record-btrace.c (btrace_ui_out_decode_error)
2345         (btrace_call_history_src_line): Update.
2346         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2347         Update.
2348         * progspace.c (print_program_space): Update.
2349         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2350         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2351         do_field_int.  Change type of "value".
2352         * mi/mi-out.c (mi_ui_out::do_table_begin)
2353         (mi_ui_out::do_table_header): Update.
2354         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2355         type of "value".
2356         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2357         (mi_cmd_data_list_changed_registers, output_register)
2358         (mi_cmd_data_read_memory, mi_load_progress)
2359         (mi_cmd_trace_frame_collected): Update.
2360         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2361         Update.
2362         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2363         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2364         (mi_cmd_var_list_children, varobj_update_one): Update.
2365         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2366         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2367         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2368         * inferior.c (print_inferior): Update.
2369         * gdb_bfd.c (print_one_bfd): Update.
2370         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2371         Update.
2372         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2373         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2374         do_field_int.  Change type of "value".
2375         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2376         do_field_int.  Change type of "value".
2377         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2378         (print_one_breakpoint_location, print_it_catch_fork)
2379         (print_one_catch_fork, print_it_catch_vfork)
2380         (print_one_catch_vfork, print_it_catch_solib)
2381         (print_it_catch_exec, print_it_ranged_breakpoint)
2382         (print_mention_watchpoint, print_mention_masked_watchpoint)
2383         (bkpt_print_it, update_static_tracepoint): Update.
2384         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2385         * break-catch-syscall.c (print_it_catch_syscall): Update.
2386         * ada-tasks.c (print_ada_task_info): Update.
2387         * ada-lang.c (print_it_exception, print_mention_exception):
2388         Update.
2389
2390 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2391
2392         PR breakpoints/24541
2393         * gdbarch.c: Regenerate.
2394         * gdbarch.h: Regenerate.
2395         * gdbarch.sh: Adjust return type and parameter types for
2396         'stap_adjust_register'.
2397         (i386_stap_adjust_register): Adjust signature and return new
2398         register name.
2399         * stap-probe.c (stap_parse_register_operand): Adjust use of
2400         'gdbarch_stap_adjust_register'.
2401
2402 2019-07-17  Tom Tromey  <tromey@adacore.com>
2403
2404         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2405         declare VEC.
2406         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2407         std::vector.
2408         (struct s390_process_info): Add initializers.
2409         (s390_add_process): Use new.
2410         (s390_linux_nat_target::low_forget_process): Use delete.
2411         (s390_linux_nat_target::low_new_fork)
2412         (s390_linux_nat_target::stopped_by_watchpoint)
2413         (s390_linux_nat_target::low_prepare_to_resume)
2414         (s390_linux_nat_target::insert_watchpoint)
2415         (s390_linux_nat_target::insert_hw_breakpoint)
2416         (s390_linux_nat_target::remove_watchpoint)
2417         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2418
2419 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2420
2421         * aarch64-fbsd-nat.c: Include regcache.h.
2422         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2423         argument.
2424         (aarch64_fbsd_nat_target::fetch_registers)
2425         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2426         variable.
2427         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2428
2429 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2430
2431         * fbsd-nat.c: Include gdbarch.h.
2432
2433 2019-07-15  Tom Tromey  <tromey@adacore.com>
2434
2435         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2436
2437 2019-07-15  Tom Tromey  <tromey@adacore.com>
2438
2439         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2440         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2441         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2442         * cli-out.c (cli_ui_out::do_field_int): New method.
2443         * ui-out.c (ui_out::field_unsigned): New method.
2444         * symfile.c (generic_load): Use field_unsigned.
2445         (print_transfer_performance): Likewise.
2446         * record-btrace.c (ui_out_field_uint): Remove.
2447         (btrace_call_history_insn_range, btrace_call_history): Use
2448         field_unsigned.
2449         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2450         field_unsigned.
2451         * ui-out.h (class ui_out) <field_unsigned>: New method.
2452         <do_field_unsigned>: Likewise.
2453
2454 2019-07-15  Tom Tromey  <tromey@adacore.com>
2455
2456         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2457         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2458         * target.c (flash_erase_command): Use field_string.
2459         * infrun.c (print_signal_received_reason): Use field_string.
2460         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2461         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2462         field_string.
2463         * ada-tasks.c (print_ada_task_info): Use field_string.
2464
2465 2019-07-15  Tom Tromey  <tromey@adacore.com>
2466
2467         * target.c (flash_erase_command): Use field_core_addr.
2468         * symfile.c (generic_load): Use field_core_addr.
2469         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2470         Use field_core_addr.
2471         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2472         field_core_addr.
2473
2474 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2475
2476         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2477         value if its desired type is smaller than a CORE_ADDR and signed.
2478
2479 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2480
2481         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2482         of changes to field names, and use new is_reference field to
2483         decide if a property is a reference or not.
2484         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2485         field.
2486         (struct dwarf2_property_baton): Update header comment, rename
2487         'referenced_type' to 'property_type' and update comments.
2488         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2489         default property type, store in property baton, update to take
2490         accound of renamed field.
2491         (read_func_scope): Update call to attr_to_dynamic_prop.
2492         (read_array_type): Likewise.
2493         (dwarf2_per_cu_addr_sized_int_type): New function.
2494         (read_subrange_index_type): Move type finding code to
2495         dwarf2_per_cu_addr_sized_int_type.
2496         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2497         (dwarf2_per_cu_addr_type): New function.
2498         (set_die_type): Update calls to attr_to_dynamic_prop.
2499
2500 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2501
2502         * dwarf2read.c (read_subrange_index_type): New function.
2503         (read_subrange_type): Move code into new function and call it.
2504         * gdbtypes.c (create_range_type): Add some asserts.
2505
2506 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2507
2508         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2509         update return statements.
2510         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2511         declaration, and update comment to match.
2512         * gdbtypes.c (resolve_dynamic_array): Update call to
2513         dwarf2_evaluate_property to match new return type.
2514
2515 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2516
2517         * valarith.c (value_subscripted_rvalue): Change lowerbound
2518         parameter type from int to LONGEST.
2519         * value.h (value_subscripted_rvalue): Likewise in declaration.
2520
2521 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2522
2523         * cli/cli-utils.c (info_print_command_completer): New function.
2524         * cli/cli-utils.h: Add 'completer.h' include, and forward
2525         declaration for 'struct cmd_list_element'.
2526         (info_print_command_completer): Declare.
2527         * stack.c (_initialize_stack): Add completer for 'info locals' and
2528         'info args'.
2529         * symtab.c (_initialize_symtab): Add completer for 'info
2530         variables' and 'info functions'.
2531         * NEWS: Mention completion for additional info commands.
2532
2533 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2534
2535         * cli/cli-utils.c (extract_info_print_args): Delete.
2536         (extract_arg_maybe_quoted): Delete.
2537         (info_print_options_defs): New variable.
2538         (make_info_print_options_def_group): New function.
2539         (extract_info_print_options): Define new function.
2540         * cli/cli-utils.h (extract_info_print_args): Delete.
2541         (struct info_print_options): New structure.
2542         (extract_info_print_options): Declare new function.
2543         * stack.c (info_locals_command): Update to use new
2544         extract_info_print_options, also add a header comment.
2545         (info_args_command): Likewise.
2546         * symtab.c (info_variables_command): Likewise.
2547         (info_functions_command): Likewise.
2548
2549 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2550
2551         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2552         to extract string arguments.
2553         * common/common-utils.c (extract_string_maybe_quoted): New function.
2554         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2555
2556 2019-07-11  Tom Tromey  <tromey@adacore.com>
2557
2558         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2559         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2560         * top.h (gdbinit): Don't declare.
2561         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2562         into...
2563         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2564         * top.c (gdb_init): Don't call init_cli_cmds.
2565         (gdbinit): Remove.
2566         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2567
2568 2019-07-11  Tom Tromey  <tromey@adacore.com>
2569
2570         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2571         after it has been moved.
2572
2573 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2574
2575         * valops.c (value_must_coerce_to_target): Change return type to
2576         bool.
2577         * value.h (value_must_coerce_to_target): Likewise.
2578
2579 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2580
2581         * breakpoint.c (is_hardware_watchpoint): Remove
2582         forward-declaration.
2583         (is_masked_watchpoint): Change return type to bool.
2584         (is_tracepoint): Likewise.
2585         (is_breakpoint): Likewise.
2586         (is_hardware_watchpoint): Likewise.
2587         (is_watchpoint): Likewise.
2588         (is_no_memory_software_watchpoint): Likewise.
2589         (is_catchpoint): Likewise.
2590         (breakpoint_1): Make FILTER parameter's return type bool.
2591         is_masked_watchpoint): Change return type to bool.
2592         (save_breakpoints): Make FILTER parameter's return type bool.
2593         * breakpoint.h (is_breakpoint): Change return type to bool.
2594         (is_watchpoint): Likewise.
2595         (is_catchpoint): Likewise.
2596         (is_tracepoint): Likewise.
2597
2598 2019-07-10  Tom Tromey  <tom@tromey.com>
2599
2600         * defs.h: Don't include gdbarch.h.
2601         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2602         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2603         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2604         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2605         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2606         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2607         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2608         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2609         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2610         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2611         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2612         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2613         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2614         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2615         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2616         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2617         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2618         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2619         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2620         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2621         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2622         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2623         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2624         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2625         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2626         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2627         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2628
2629 2019-07-10  Tom Tromey  <tromey@adacore.com>
2630
2631         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2632         * breakpoint.c (init_ada_exception_breakpoint): Register as
2633         bp_catchpoint.
2634         (print_one_breakpoint_location, print_one_breakpoint): Use
2635         is_ada_exception_catchpoint.
2636         * ada-lang.c (class ada_catchpoint_location): Pass
2637         bp_loc_software_breakpoint to bp_location constructor.
2638         (is_ada_exception_catchpoint): New function.
2639
2640 2019-07-10  Tom Tromey  <tromey@adacore.com>
2641
2642         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2643         VEC.
2644         (struct arm_exidx_entry): New method operator<.
2645         (struct arm_exidx_data) <section_maps>: Change type.
2646         (arm_exidx_data_free): Remove.
2647         (arm_exidx_data_key): Change type.  Move lower.
2648         (arm_exidx_new_objfile): Update.
2649         (arm_compare_exidx_entries): Remove.
2650         (arm_find_exidx_entry, _initialize_arm_tdep)
2651
2652 2019-07-10  Tom Tromey  <tromey@adacore.com>
2653
2654         * solib-spu.c (ocl_program_data_key): Change type.
2655         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2656         Update.
2657
2658 2019-07-10  Tom Tromey  <tromey@adacore.com>
2659
2660         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2661         (struct solib_aix_inferior_data) <library_list>: Change type.
2662         (solib_aix_inferior_data_handle): Change type.
2663         (get_solib_aix_inferior_data): Update.
2664         (solib_aix_free_library_list): Remove.
2665         (library_list_start_library): Update.
2666         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2667         return type.
2668         (solib_aix_get_library_list)
2669         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2670         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2671
2672 2019-07-10  Tom Tromey  <tromey@adacore.com>
2673
2674         * solib-dsbt.c (struct dsbt_info): Add initializers.
2675         (solib_dsbt_pspace_data): Change type.
2676         (dsbt_pspace_data_cleanup): Remove.
2677         (get_dsbt_info, _initialize_dsbt_solib): Update.
2678
2679 2019-07-10  Tom Tromey  <tromey@adacore.com>
2680
2681         * spu-tdep.c (spu_overlay_data): Change type.
2682         (spu_get_overlay_table, spu_overlay_new_objfile)
2683         (_initialize_spu_tdep): Update.
2684
2685 2019-07-10  Tom Tromey  <tromey@adacore.com>
2686
2687         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2688         destructor.
2689         (dbx_objfile_data_key): Change type and declare later.
2690         (DBX_SYMFILE_INFO): Rewrite.
2691         * dbxread.c (dbx_objfile_data_key): Change type.
2692         (dbx_symfile_init): Update.
2693         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2694         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2695         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2696
2697 2019-07-10  Tom Tromey  <tromey@adacore.com>
2698
2699         * jit.c (jit_program_space_key): Change type.  Move lower.
2700         (get_jit_program_space_data): Update.
2701         (jit_program_space_data_cleanup): Remove.
2702         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2703         Update.
2704         (struct jit_program_space_data): Add initializers.
2705
2706 2019-07-10  Tom Tromey  <tromey@adacore.com>
2707
2708         * solib-darwin.c (struct darwin_info): Add initializers.
2709         (solib_darwin_pspace_data): Change type.
2710         (darwin_pspace_data_cleanup): Remove.
2711         (get_darwin_info, _initialize_darwin_solib): Update.
2712
2713 2019-07-10  Tom Tromey  <tromey@adacore.com>
2714
2715         * remote-sim.c (struct sim_inferior_data): Add initializers,
2716         constructor, and destructor.
2717         (sim_inferior_data_key): Change type.  Move lower.
2718         (check_for_duplicate_sim_descriptor): Update.
2719         (get_sim_inferior_data): Use new.  Update.
2720         (~sim_inferior_data_cleanup): Rename from
2721         sim_inferior_data_cleanup.  Simplify.
2722         (gdbsim_close_inferior, simulator_command)
2723         (sim_command_completer, _initialize_remote_sim): Update.
2724         (next_pid, INITIAL_PID): Move earlier.
2725
2726 2019-07-10  Tom Tromey  <tromey@adacore.com>
2727
2728         * python/python-internal.h (create_thread_object): Return
2729         gdbpy_ref.
2730         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2731         * python/py-inferior.c (struct threadlist_entry): Add
2732         constructor.
2733         <thread_obj>: Now a gdbpy_ref.
2734         (thread_to_thread_object): Update.
2735         (add_thread_object): Use new.
2736         (delete_thread_object): Use delete.
2737         (infpy_threads): Update.
2738         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2739         GIL.
2740
2741 2019-07-10  Tom Tromey  <tromey@adacore.com>
2742
2743         * valops.c (value_cast): Specialize error message for Ada.
2744
2745 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2746
2747         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2748
2749 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2750
2751         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2752         bpstat_should_step): Return bool, adjust comments.
2753         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2754         bpstat_should_step): Likewise.
2755
2756 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2757
2758         * features/Makefile: Use feature target descriptions for Arm.
2759         * features/arm/arm-core.c: Generate new file.
2760         * features/arm/arm-fpa.c: Likewise.
2761         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2762         * features/arm/arm-m-profile.c: Likewise.
2763         * features/arm/arm-vfpv2.c: Likewise.
2764         * features/arm/arm-vfpv3.c: Likewise.
2765         * features/arm/xscale-iwmmxt.c: Likewise.
2766         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2767
2768 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2769
2770         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2771         ptrace earlier.
2772
2773 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2774
2775         * features/aarch64-pauth.c: Regenerate.
2776
2777 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2778
2779         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2780         bool.
2781         (bpstat_what): Use false instead of 0.
2782
2783 2019-07-09  Pedro Alves  <palves@redhat.com>
2784
2785         * break-catch-throw.c (is_exception_catchpoint): New.
2786         * breakpoint.c (print_one_breakpoint_location): New parameter
2787         'raw_loc'.  Handle it.  Use
2788         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2789         looking at the breakpoint's type.
2790         (print_one_breakpoint): If handling "maint info breakpoints", also
2791         print locations of exception catchpoints.
2792         * breakpoint.h (is_exception_catchpoint): Declare.
2793
2794 2019-07-09  Pedro Alves  <palves@redhat.com>
2795
2796         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2797         "addr" field.
2798         (allocate_location_exception_catchpoint): New.
2799         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2800         (initialize_throw_catchpoint_ops): Install
2801         allocate_location_exception_catchpoint as allocate_location
2802         method.
2803         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2804         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2805         bp_loc_other.
2806         (breakpoint_address_is_meaningful): Delete.
2807         (bl_address_is_meaningful): New.
2808         (breakpoint_locations_match): Adjust comment.
2809         (bp_location_from_bp_type): New, factored out of...
2810         (bp_location::bp_location(breakpoint *)): ... this.
2811         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2812         factored out of...
2813         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2814         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2815         breakpoint_address_is_meaningful.
2816         (bp_locations_compare): Adjust comment.
2817         (update_global_location_list): Use bl_address_is_meaningful
2818         instead of breakpoint_address_is_meaningful.
2819         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2820         explicit.
2821         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2822         * python/py-breakpoint.c (bppy_get_location): No longer check
2823         whether location is null.
2824
2825 2019-07-09  Pedro Alves  <palves@redhat.com>
2826
2827         PR c++/15468
2828         * breakpoint.c (print_one_breakpoint_location): Remove
2829         single-location assert.
2830
2831 2019-07-09  Tom Tromey  <tom@tromey.com>
2832
2833         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2834         * configure: Rebuild.
2835         * configure.ac: Change common to gdbsupport.
2836         * gdbsupport: Rename from common.
2837         * acinclude.m4: Change common to gdbsupport.
2838         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2839         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2840         gdbsupport.
2841         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2842         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2843         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2844         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2845         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2846         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2847         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2848         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2849         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2850         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2851         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2852         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2853         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2854         coff-pe-read.c, command.h, compile/compile-c-support.c,
2855         compile/compile-c.h, compile/compile-cplus-symbols.c,
2856         compile/compile-cplus-types.c, compile/compile-cplus.h,
2857         compile/compile-loc2c.c, compile/compile.c, completer.c,
2858         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2859         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2860         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2861         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2862         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2863         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2864         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2865         features/aarch64-core.c, features/aarch64-fpu.c,
2866         features/aarch64-pauth.c, features/aarch64-sve.c,
2867         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2868         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2869         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2870         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2871         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2872         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2873         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2874         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2875         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2876         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2877         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2878         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2879         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2880         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2881         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2882         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2883         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2884         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2885         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2886         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2887         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2888         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2889         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2890         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2891         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2892         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2893         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2894         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2895         minsyms.c, mips-linux-tdep.c, namespace.h,
2896         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2897         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2898         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2899         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2900         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2901         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2902         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2903         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2904         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2905         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2906         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2907         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2908         procfs.c, producer.c, progspace.h, psymtab.h,
2909         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2910         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2911         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2912         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2913         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2914         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2915         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2916         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2917         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2918         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2919         target-memory.c, target.c, target.h, target/waitstatus.c,
2920         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2921         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2922         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2923         unittests/array-view-selftests.c,
2924         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2925         unittests/common-utils-selftests.c,
2926         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2927         unittests/format_pieces-selftests.c,
2928         unittests/function-view-selftests.c,
2929         unittests/lookup_name_info-selftests.c,
2930         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2931         unittests/mkdir-recursive-selftests.c,
2932         unittests/observable-selftests.c,
2933         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2934         unittests/parse-connection-spec-selftests.c,
2935         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2936         unittests/scoped_fd-selftests.c,
2937         unittests/scoped_mmap-selftests.c,
2938         unittests/scoped_restore-selftests.c,
2939         unittests/string_view-selftests.c, unittests/style-selftests.c,
2940         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2941         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2942         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2943         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2944         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2945         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2946
2947 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2948
2949         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2950         bool value.
2951         (decode_digits_ordinary): Set explicit_line field in sal.
2952         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2953         symtab_and_line that was set on an explicit line number in
2954         assembler code.  Do always update the recorded symtab and line if
2955         we do skip the prologue.
2956
2957 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2958
2959         * breakpoint.c (set_breakpoint_location_function): Remove
2960         explicit_loc parameter.
2961         (momentary_breakpoint_from_master): Update call to
2962         set_breakpoint_location_function.
2963         (add_location_to_breakpoint): Likewise.
2964
2965 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2966
2967         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2968         required features based on default bfd type when no specific bfd
2969         is present.
2970
2971 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2972
2973         * NEWS: Mention that GDB printf and eval commands can now print
2974         C-style and Ada-style convenience var strings without
2975         calling the inferior.
2976         * printcmd.c (printf_c_string): Locally print GDB internal var
2977         instead of transiting via the inferior.
2978         (printf_wide_c_string): Likewise.
2979
2980 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2981
2982         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2983
2984 2019-07-04  Tom Tromey  <tom@tromey.com>
2985
2986         PR tui/24724:
2987         * tui/tui-winsource.c (tui_clear_source_content): Update.
2988         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2989         (tui_update_breakpoint_info): Update.
2990         (tui_set_exec_info_content): Update.
2991         * tui/tui-source.c (tui_set_source_content_nil): Update.
2992         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2993         has_break.
2994         * tui/tui-data.h (enum tui_bp_flag): New.
2995         (tui_bp_flags): New enum flags type.
2996         (struct tui_source_element) <break_mode>: Change type.  Rename
2997         from has_break.
2998         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2999         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3000         constants.
3001         * tui/tui-winsource.h: Fix comment.
3002
3003 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3004
3005         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3006         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3007         (store_fpregs_to_thread)
3008         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3009         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3010         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3011         (IWMMXT_REGS_SIZE): Add define.
3012         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3013         (fetch_vfp_regs, store_vfp_regs)
3014         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3015         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3016
3017 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3018
3019         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3020         defines.
3021         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3022         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3023         (ARM_INT_REGISTER_SIZE): ...to this.
3024         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3025         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3026         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3027         (arm_linux_collect_gregset, supply_nwfpe_register)
3028         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3029         defines.
3030         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3031         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3032         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3033         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3034         (arm_return_in_memory, arm_store_return_value)
3035         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3036         (arm_record_ld_st_multiple): Likewise.
3037         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3038         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3039
3040 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3041
3042         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3043         AARCH64_DISPLACED_MODIFIED_INSNS.
3044         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3045         (aarch64_displaced_step_copy_insn): Likewise.
3046         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3047         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3048         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3049         ARM_DISPLACED_MODIFIED_INSNS.
3050         * arm-tdep.c (arm_gdbarch_init): Likewise.
3051         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3052         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3053         (struct arm_displaced_step_closure): Use
3054         ARM_DISPLACED_MODIFIED_INSNS.
3055
3056 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3057
3058         * features/Makefile: Remove unused xml files.
3059         * features/aarch64.xml: Remove.
3060         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3061         * features/i386/amd64-avx-avx512.xml: Remove.
3062         * features/i386/amd64-avx-linux.xml: Remove.
3063         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3064         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3065         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3066         * features/i386/amd64-avx-mpx.xml: Remove.
3067         * features/i386/amd64-avx.xml: Remove.
3068         * features/i386/amd64-linux.xml: Remove.
3069         * features/i386/amd64-mpx-linux.xml: Remove.
3070         * features/i386/amd64-mpx.xml: Remove.
3071         * features/i386/amd64.xml: Remove.
3072         * features/i386/i386-avx-avx512-linux.xml: Remove.
3073         * features/i386/i386-avx-avx512.xml: Remove.
3074         * features/i386/i386-avx-linux.xml: Remove.
3075         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3076         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3077         * features/i386/i386-avx-mpx-linux.xml: Remove.
3078         * features/i386/i386-avx-mpx.xml: Remove.
3079         * features/i386/i386-avx.xml: Remove.
3080         * features/i386/i386-linux.xml: Remove.
3081         * features/i386/i386-mmx-linux.xml: Remove.
3082         * features/i386/i386-mmx.xml: Remove.
3083         * features/i386/i386-mpx-linux.xml: Remove.
3084         * features/i386/i386-mpx.xml: Remove.
3085         * features/i386/i386.xml: Remove.
3086         * features/i386/x32-avx-avx512-linux.xml: Remove.
3087         * features/i386/x32-avx-linux.xml: Remove.
3088         * features/i386/x32-linux.xml: Remove.
3089
3090 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3091
3092         * regformats/aarch64.dat: Remove.
3093         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3094         * regformats/i386/amd64-avx-linux.dat: Remove.
3095         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3096         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3097         * regformats/i386/amd64-linux.dat: Remove.
3098         * regformats/i386/amd64-mpx-linux.dat: Remove.
3099         * regformats/i386/amd64.dat: Remove.
3100         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3101         * regformats/i386/i386-avx-linux.dat: Remove.
3102         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3103         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3104         * regformats/i386/i386-linux.dat: Remove.
3105         * regformats/i386/i386-mmx-linux.dat: Remove.
3106         * regformats/i386/i386-mpx-linux.dat: Remove.
3107         * regformats/i386/i386.dat: Remove.
3108         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3109         * regformats/i386/x32-avx-linux.dat: Remove.
3110         * regformats/i386/x32-linux.dat: Remove.
3111
3112 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3113
3114         * aarch64-tdep.c: Remove xml self tests.
3115         * amd64-linux-tdep.c: Likewise.
3116         * amd64-tdep.c: Likewise.
3117         * i386-linux-tdep.c: Likewise.
3118         * i386-tdep.c: Likewise.
3119
3120 2019-07-03  Pedro Alves  <palves@redhat.com>
3121
3122         PR cli/24732
3123         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3124         (pipe_cmd_option_defs): New.
3125         (make_pipe_cmd_options_def_group): New.
3126         (pipe_command): Use gdb::option::process_options.
3127         (pipe_command_completer): New function.
3128         (_initialize_cli_cmds): Install completer for "pipe" command.
3129
3130 2019-07-03  Pedro Alves  <palves@redhat.com>
3131
3132         * cli/cli-option.c (union option_value) <string>: New field.
3133         (struct option_def_and_value): Add ctor, move ctor, dtor and
3134         use DISABLE_COPY_AND_ASSIGN.
3135         (option_def_and_value::clear_value): New.
3136         (parse_option, save_option_value_in_ctx, get_val_type_str)
3137         (add_setshow_cmds_for_options): Handle var_string.
3138         * cli-option.h (union option_def::var_address) <string>: New
3139         field.
3140         (struct string_option_def): New.
3141         * maint-test-options.c (struct test_options_opts): Add default
3142         ctor and use DISABLE_COPY_AND_ASSIGN.
3143         <string_opt>: New field.
3144         (test_options_opts::~test_options_opts): New.
3145         (test_options_opts::dump): Also dump "-string".
3146         (test_options_option_defs): Install "string.
3147
3148 2019-07-03  Pedro Alves  <palves@redhat.com>
3149
3150         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3151         option_value with a null enumeration.
3152         (complete_options): Save the option values in the context.
3153         (save_option_value_in_ctx): New, factored out from ...
3154         (process_options): ... here.
3155         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3156         of the function.
3157         * maint-test-options.c (test_options_opts::dump): New, factored
3158         out from ...
3159         (maintenance_test_options_command_mode): ... here.
3160         (maintenance_test_options_command_completion_result): Delete.
3161         (maintenance_test_options_command_completion_text): Update
3162         comment.
3163         (maintenance_show_test_options_completion_result): Change
3164         prototype.  Just print
3165         maintenance_test_options_command_completion_text.
3166         (save_completion_result): New.
3167         (maintenance_test_options_completer_mode): Pass options context to
3168         complete_options, and then save a dump.
3169         (_initialize_maint_test_options): Use add_cmd to install "maint
3170         show test-options-completion-result".
3171
3172 2019-07-03  Pedro Alves  <palves@redhat.com>
3173
3174         * NEWS (New commands): Mention "with" and "maint with".
3175         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3176         (with_command, with_command_completer): New.
3177         (pipe_command): Adjust to new repeat_previous
3178         interface.
3179         (_initialize_cli_cmds): Install the "with" command and its "w"
3180         alias.
3181         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3182         declarations.
3183         * cli/cli-setshow.c (parse_cli_var_uinteger)
3184         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3185         argument strings for all var_types.
3186         (get_setshow_command_value_string): New, factored out from ...
3187         (do_show_command): ... this.
3188         * cli/cli-setshow.h: Include <string>.
3189         (get_setshow_command_value_string): Declare.
3190         * command.h (repeat_previous): Now returns const char *.  Adjust
3191         comment.
3192         * maint.c: Include "cli/cli-cmds.h".
3193         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3194         (_initialize_maint_cmds): Register the "maintenance with" command.
3195         * top.c (repeat_previous): Move bits from pipe_command here:
3196         Return the saved command line, if any; error out if there's no
3197         command to relaunch.
3198
3199 2019-07-03  Pedro Alves  <palves@redhat.com>
3200
3201         * NEWS (New commands): Mention "maint set/show test-settings"
3202         instead of "maint test-settings".
3203         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3204         (maintenance_test_settings_set_list): Rename to ...
3205         (maintenance_set_test_settings_list): ... this.
3206         (maintenance_test_settings_show_list): Rename to  ...
3207         (maintenance_show_test_settings_list): ... this.
3208         (maintenance_test_settings_cmd): Delete.
3209         (maintenance_test_settings_set_cmd): ...
3210         (maintenance_set_test_settings_cmd): ... this.
3211         (maintenance_test_settings_show_cmd): ...
3212         (maintenance_show_test_settings_cmd): ... this.
3213         (maintenance_test_settings_show_value_cmd):
3214         (maintenance_show_test_settings_value_cmd): ... this.
3215         (_initialize_maint_test_settings): No longer install the "maint
3216         test-settings" prefix command.  Rename "maint test-settings set"
3217         to "maint set test-settings", and "maint test-settings show" to
3218         "maint show test-settings".  Adjust all subcommands.
3219
3220 2019-07-03  Pedro Alves  <palves@redhat.com>
3221
3222         * maint-test-settings.c: Fix file's intro comment.  Replace all
3223         references to "test-options" with references to "test-settings",
3224         in comments.
3225
3226 2019-07-03  Pedro Alves  <palves@redhat.com>
3227
3228         * maint-test-settings.c (maintenance_test_settings_xxx)
3229         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3230         New.
3231         (maintenance_test_settings_enums): Use them.
3232         (maintenance_test_settings_enum): Default to
3233         maintenance_test_settings_xxx.
3234         (_initialize_maint_test_settings): Initialize
3235         MAINTENANCE_TEST_SETTINGS_FILENAME.
3236
3237 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3238
3239         * breakpoint.h (remove_breakpoints_inf): Change return type to
3240         void, move function documentation here.
3241         * breakpoint.c (remove_breakpoints_inf): Change return type to
3242         void, move function documentation to header.
3243
3244 2019-07-02  Pedro Alves  <palves@redhat.com>
3245
3246         * NEWS (Completion improvements): Mention "info threads".
3247         * thread.c (struct info_threads_opts, info_threads_option_defs)
3248         (make_info_threads_options_def_group): New.
3249         (info_threads_command): Use gdb::option::process_options.
3250         (info_threads_command_completer): New.
3251         (_initialize_thread): Use gdb::option::build_help to build the
3252         help text for "info threads".
3253
3254 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3255
3256         * defs.h (generic_load): Move from here...
3257         * symfile.h (generic_load): ... to here.  Rename name parameter
3258         to args.
3259         * symfile.c (generic_load): Add comment.
3260
3261 2019-07-01  Tom Tromey  <tromey@adacore.com>
3262
3263         * dwarf2read.c
3264         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3265         declaration of without_params.  Fix formatting.
3266
3267 2019-07-01  Tom Tromey  <tromey@adacore.com>
3268
3269         * ada-exp.y (find_primitive_type): Update.
3270         * ada-lang.h (ada_lookup_symbol): Update.
3271         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3272         parameter.
3273         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3274
3275 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3276
3277         PR breakpoints/24541
3278         * gdbarch.c: Regenerate.
3279         * gdbarch.h: Regenerate.
3280         * gdbarch.sh: Add 'stap_adjust_register'.
3281         * i386-tdep.c: Include '<unordered_set>'.
3282         (i386_stap_adjust_register): New function.
3283         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3284         * stap-probe.c (stap_parse_register_operand): Call
3285         'gdbarch_stap_adjust_register'.
3286
3287 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3288
3289         PR python/24742
3290         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3291         * python/python.c (do_start_initialization): Use 'xmalloc'
3292         instead of 'PyMem_Malloc'.
3293
3294 2019-06-28  Tom Tromey  <tromey@adacore.com>
3295
3296         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3297         for Ada.
3298
3299 2019-06-27  Tom Tromey  <tromey@adacore.com>
3300
3301         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3302         objfile_key.
3303         (arm_find_mapping_symbol, arm_record_special_symbol)
3304         (_initialize_arm_tdep): Update.
3305         (arm_objfile_data_free): Remove.
3306
3307 2019-06-27  Tom Tromey  <tromey@adacore.com>
3308
3309         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3310         to cp_print_static_field.
3311
3312 2019-06-26  Tom Tromey  <tromey@adacore.com>
3313
3314         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3315         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3316         declare.
3317
3318 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3319
3320         * features/aarch64-core.c (create_feature_aarch64_core):
3321         Regenerate.
3322         * features/aarch64-core.xml: Add cpsr flags.
3323
3324 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3325
3326         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3327         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3328
3329 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3330
3331         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3332         field.
3333         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3334         use.
3335         (arm_record_special_symbol): Don't insert new symbol in sorted
3336         position, push it at the end.
3337
3338 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3339
3340         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3341         (arm_mapping_symbol_s): Remove.
3342         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3343         (arm_mapping_symbol_vec): New typedef.
3344         (struct arm_per_objfile): Add constructor.
3345         <section_maps>: Change type to
3346         std::unique_ptr<arm_mapping_symbol_vec[]>.
3347         (arm_compare_mapping_symbols): Remove.
3348         (arm_find_mapping_symbol): Adjust to section_maps type change.
3349         (arm_objfile_data_free): Call delete on arm_per_objfile.
3350         (arm_record_special_symbol): Adjust to section_maps type change.
3351         Allocate arm_per_objfile with new.
3352
3353 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3354
3355         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3356         with the command prefix.
3357
3358 2019-06-25  Tom Tromey  <tom@tromey.com>
3359
3360         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3361         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3362
3363 2019-06-25  Tom Tromey  <tom@tromey.com>
3364
3365         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3366         type.
3367         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3368         protected.
3369
3370 2019-06-25  Tom Tromey  <tom@tromey.com>
3371
3372         * tui/tui-winsource.c
3373         (tui_source_window_base::set_is_exec_point_at): Add check against
3374         LOA_ADDRESS.
3375
3376 2019-06-25  Tom Tromey  <tom@tromey.com>
3377
3378         * tui/tui-source.c (tui_set_source_content): Don't check before
3379         xfree.
3380         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3381
3382 2019-06-25  Tom Tromey  <tom@tromey.com>
3383
3384         * tui/tui-winsource.h (tui_update_source_window_as_is)
3385         (tui_alloc_source_buffer, tui_line_is_displayed)
3386         (tui_addr_is_displayed): Change type of win_info.
3387         * tui/tui-winsource.c (tui_update_source_window_as_is)
3388         (tui_clear_source_content, tui_show_source_line)
3389         (tui_show_source_content, tui_source_window_base::refill)
3390         (tui_source_window_base::set_is_exec_point_at)
3391         (tui_source_window_base::set_is_exec_point_at)
3392         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3393         (tui_alloc_source_buffer, tui_line_is_displayed)
3394         (tui_addr_is_displayed): Change type of win_info.  Update.
3395         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3396         (tui_source_window_base::do_make_visible_with_new_height):
3397         Update.
3398         * tui/tui-source.c (tui_set_source_content)
3399         (tui_set_source_content_nil)
3400         (tui_source_window::do_scroll_vertical): Update.
3401         * tui/tui-layout.c (show_layout): Update.
3402         * tui/tui-disasm.c (tui_set_disassem_content)
3403         (tui_disasm_window::do_scroll_vertical): Update.
3404         * tui/tui-data.h (tui_win_content): Remove.
3405         (struct tui_gen_win_info) <content, content_size>: Remove.
3406         (struct tui_source_element): Add initializers and destructor.
3407         (union tui_which_element, struct tui_win_element): Remove.
3408         (struct tui_source_window_base) <content>: New field.
3409         (struct tui_data_window): Remove destructor.
3410         (tui_alloc_content, tui_free_win_content)
3411         (tui_free_all_source_wins_content): Don't declare.
3412         * tui/tui-data.c (tui_initialize_static_data): Update.
3413         (init_content_element, tui_alloc_content): Remove.
3414         (~tui_gen_win_info): Update.
3415         (~tui_data_window, tui_free_all_source_wins_content)
3416         (tui_free_win_content, free_content, free_content_elements):
3417         Remove.
3418
3419 2019-06-25  Tom Tromey  <tom@tromey.com>
3420
3421         * tui/tui-winsource.h (tui_clear_source_content)
3422         (tui_erase_source_content, tui_show_source_content): Change type
3423         of win_info.
3424         * tui/tui-winsource.c (tui_clear_source_content)
3425         (tui_erase_source_content, tui_show_source_content): Change type
3426         of win_info.
3427         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3428         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3429         win_info.
3430         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3431         win_info.
3432         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3433
3434 2019-06-25  Tom Tromey  <tom@tromey.com>
3435
3436         * tui/tui-winsource.c (tui_clear_source_content)
3437         (tui_source_window_base::set_is_exec_point_at): Update.
3438         * tui/tui-source.c (tui_set_source_content_nil): Update.
3439         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3440         a bool.
3441         * tui/tui-data.c (init_content_element): Update.
3442
3443 2019-06-25  Tom Tromey  <tom@tromey.com>
3444
3445         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3446         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3447         * tui/tui-layout.c (init_and_make_win): Update.
3448         * tui/tui.h (enum tui_win_type): Update.
3449         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3450         tui_win_is_auxillary.
3451         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3452         tui_win_is_auxillary.
3453
3454 2019-06-25  Tom Tromey  <tom@tromey.com>
3455
3456         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3457         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3458         (tui_delete_data_content_windows, tui_display_all_data)
3459         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3460         Update.
3461         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3462         * tui/tui-regs.c (tui_last_regs_line_no)
3463         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3464         (tui_show_registers): Update.
3465         (tui_show_register_group): Return void.  Update.
3466         (tui_display_registers_from, tui_display_reg_element_at_line)
3467         (tui_display_registers_from_line, tui_check_register_values):
3468         Update.
3469         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3470         member.
3471         (struct tui_data_window) <regs_content>: Now a std::vector.
3472         <regs_content_count>: Remove.
3473         (tui_add_content_elements, tui_free_data_content): Don't declare.
3474         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3475         (init_content_element): Remove DATA_WIN case.  Add assert.
3476         (tui_add_content_elements): Remove.
3477         (tui_data_window): Update.
3478         (tui_free_data_content): Remove.
3479         (free_content_elements): Remove DATA_WIN case.
3480
3481 2019-06-25  Tom Tromey  <tom@tromey.com>
3482
3483         * tui/tui-data.c (tui_data_item_window): Update.
3484         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3485         * tui/tui-windata.c (tui_display_all_data)
3486         (tui_display_data_from_line): Update.
3487         (tui_check_data_values): Remove.
3488         * tui/tui-regs.c (tui_show_register_group)
3489         (tui_display_reg_element_at_line): Update.
3490         * tui/tui-hooks.c (tui_register_changed)
3491         (tui_refresh_frame_and_register_information): Call
3492         tui_check_register_values.
3493         * tui/tui-data.h (struct tui_data_window) <data_content,
3494         data_content_count, data_type>: Remove.
3495         (enum tui_data_type): Remove.
3496
3497         * tui/tui-data.c (tui_data_window::clear_detail)
3498         (~tui_data_window): Update.
3499
3500 2019-06-25  Tom Tromey  <tom@tromey.com>
3501
3502         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3503         declare.
3504         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3505         Rename from tui_first_data_item_displayed.  Update.
3506         (tui_data_window::refresh_all)
3507         (tui_data_window::do_scroll_vertical): Update.
3508         * tui/tui-data.h (struct tui_data_window)
3509         <first_data_item_displayed>: Declare new method.
3510
3511 2019-06-25  Tom Tromey  <tom@tromey.com>
3512
3513         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3514         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3515         contents...
3516         (tui_initialize_static_data): ...here.
3517
3518 2019-06-25  Tom Tromey  <tom@tromey.com>
3519
3520         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3521         (tui_display_registers_from, tui_check_register_values): Update.
3522         (tui_display_register): Remove win_info parameter; update.
3523         (tui_get_register): Change type of parameters.
3524         * tui/tui-data.h (struct tui_data_element): Remove.
3525         (union tui_which_element) <data>: Remove.
3526         <data_window>: Change type.
3527         (struct tui_data_item_window): New.
3528         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3529         case.  Add assert.
3530         (~tui_data_item_window): New destructor.
3531         (free_content_elements): Remove DATA_ITEM_WIN case.
3532
3533 2019-06-25  Tom Tromey  <tom@tromey.com>
3534
3535         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3536         Remove.
3537
3538 2019-06-25  Tom Tromey  <tom@tromey.com>
3539
3540         * tui/tui-data.h (struct tui_command_element): Remove.
3541         (union tui_which_element) <command>: Remove.
3542         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3543         assert.
3544         (free_content_elements): Remove CMD_WIN case.
3545
3546 2019-06-25  Tom Tromey  <tom@tromey.com>
3547
3548         * tui/tui-layout.c (tui_set_layout): Update.
3549         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3550         * tui/tui-data.c (layout_def): Update.
3551
3552 2019-06-25  Tom Tromey  <tom@tromey.com>
3553
3554         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3555         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3556         (tui_source_window_base::set_new_height): Update.
3557         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3558         Update.
3559         (tui_set_locator_fullname, tui_set_locator_info)
3560         (tui_show_frame_info): Update.
3561         * tui/tui-source.c (tui_set_source_content)
3562         (tui_source_is_displayed): Update.
3563         * tui/tui-layout.c (show_source_disasm_command, show_data)
3564         (show_source_or_disasm_and_command): Update.
3565         * tui/tui-disasm.c (tui_set_disassem_content)
3566         (tui_get_begin_asm_address): Update.
3567         * tui/tui-data.h (struct tui_locator_element): Remove.
3568         (union tui_which_element) <locator>: Remove.
3569         (struct tui_locator_window): New.
3570         (tui_locator_win_info_ptr): Change return type.
3571         * tui/tui-data.c (_locator): Change type.
3572         (tui_locator_win_info_ptr): Change return type.
3573         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3574         (tui_alloc_content): Add assert.
3575
3576 2019-06-25  Tom Tromey  <tom@tromey.com>
3577
3578         * tui/tui-winsource.c
3579         (tui_exec_info_window::maybe_allocate_content): New method.
3580         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3581         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3582         (make_source_or_disasm_window): Add cast.
3583         * tui/tui-data.h (union tui_which_element) <simple_string>:
3584         Remove.
3585         (struct tui_source_info): New.
3586         (struct tui_source_window_base) <execution_info>: Change type.
3587         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3588         case, and add assert.
3589         (tui_alloc_content): Add assert.
3590
3591 2019-06-25  Tom Tromey  <tom@tromey.com>
3592
3593         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3594         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3595         * tui/tui-data.c (tui_alloc_win_info): Remove.
3596
3597 2019-06-25  Tom Tromey  <tom@tromey.com>
3598
3599         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3600         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3601         can_highlight.
3602
3603 2019-06-25  Tom Tromey  <tom@tromey.com>
3604
3605         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3606         make_visible_with_new_height method.
3607         (tui_win_info::make_visible_with_new_height): New method.
3608         (tui_source_window_base::do_make_visible_with_new_height)
3609         (tui_data_window::do_make_visible_with_new_height)
3610         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3611         (make_visible_with_new_height): Remove.
3612         (tui_resize_all, tui_adjust_win_heights): Use
3613         make_visible_with_new_height method.
3614         * tui/tui-data.h (struct tui_win_info)
3615         <do_make_visible_with_new_height, make_visible_with_new_height>:
3616         New methods.
3617         (struct tui_source_window_base, struct tui_data_window)
3618         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3619         methods.
3620
3621 2019-06-25  Tom Tromey  <tom@tromey.com>
3622
3623         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3624         method.
3625         (update_tab_width): Call update_tab_width method.
3626         * tui/tui-data.h (struct tui_win_info)
3627         (struct tui_source_window_base) <update_tab_width>: New methods.
3628
3629 2019-06-25  Tom Tromey  <tom@tromey.com>
3630
3631         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3632         parameter.
3633         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3634         parameter.
3635         (tui_gen_win_info::make_visible): Update.
3636         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3637         parameter.
3638         * tui/tui-data.h (enum tui_box): New enum.
3639         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3640
3641 2019-06-25  Tom Tromey  <tom@tromey.com>
3642
3643         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3644         init_and_make_win for EXEC_INFO_WIN.
3645         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3646         longer inline.
3647         (struct tui_win_info) <~tui_win_info>: Inline.
3648         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3649         Don't declare.
3650         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3651         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3652         Remove.
3653         (tui_initialize_static_data): Update.
3654         (~tui_gen_win_info): Handle more cleanup here.
3655         (~tui_source_window_base): Delete "execution_info".
3656         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3657
3658 2019-06-25  Tom Tromey  <tom@tromey.com>
3659
3660         * tui/tui-layout.c (make_command_window): Don't set
3661         can_highlight.
3662         (show_source_disasm_command): Call the reset method.
3663         (show_data): Don't set can_highlight.  Call the reset method.
3664         (tui_gen_win_info::reset): Rename from init_gen_win_info
3665         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3666         (show_source_or_disasm_and_command): Call the reset method.
3667         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3668         (struct tui_cmd_window): Set can_highlight.
3669
3670 2019-06-25  Tom Tromey  <tom@tromey.com>
3671
3672         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3673         from make_visible.
3674         (tui_make_visible, tui_make_invisible): Rewrite.
3675         (tui_win_info::make_visible): Remove.
3676         (tui_source_window_base::make_visible): Update.
3677         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3678         method.  Moved from...
3679         (struct tui_win_info) <make_visible>: ...here.
3680
3681 2019-06-25  Tom Tromey  <tom@tromey.com>
3682
3683         * tui/tui-winsource.c
3684         (tui_source_window_base::do_scroll_horizontal): Remove direction
3685         parameter.
3686         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3687         direction parameter.
3688         * tui/tui-win.c (tui_win_info::forward_scroll)
3689         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3690         (tui_win_info::right_scroll): Update.
3691         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3692         direction parameter.
3693         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3694         direction parameter.
3695         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3696         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3697         Remove direction parameter.
3698         (struct tui_source_window_base, struct tui_source_window)
3699         (struct tui_disasm_window, struct tui_data_window)
3700         (struct tui_cmd_window): Update.
3701
3702 2019-06-25  Tom Tromey  <tom@tromey.com>
3703
3704         * tui/tui-winsource.h (tui_set_exec_info_content)
3705         (tui_show_exec_info_content, tui_erase_exec_info_content)
3706         (tui_clear_exec_info_content, tui_update_exec_info): Change
3707         argument to tui_source_window_base.
3708         * tui/tui-winsource.c (tui_set_exec_info_content)
3709         (tui_show_exec_info_content, tui_erase_exec_info_content)
3710         (tui_clear_exec_info_content, tui_update_exec_info): Change
3711         argument to tui_source_window_base.
3712
3713 2019-06-25  Tom Tromey  <tom@tromey.com>
3714
3715         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3716         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3717
3718 2019-06-25  Tom Tromey  <tom@tromey.com>
3719
3720         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3721         check.
3722
3723 2019-06-25  Tom Tromey  <tom@tromey.com>
3724
3725         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3726         type to void.
3727         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3728         type to void.
3729         * tui/tui-source.c (tui_set_source_content): Update.
3730         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3731
3732 2019-06-25  Tom Tromey  <tom@tromey.com>
3733
3734         * tui/tui-win.c (window_name_completer, tui_set_focus)
3735         (tui_all_windows_info): Use name method.
3736         * tui/tui-data.h (struct tui_gen_win_info)
3737         (struct tui_source_window, struct tui_disasm_window)
3738         (struct tui_data_window, struct tui_cmd_window) <name>: New
3739         method.
3740         (tui_win_name): Don't declare.
3741         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3742         (tui_win_name): Remove.
3743
3744 2019-06-25  Tom Tromey  <tom@tromey.com>
3745
3746         * tui/tui-winsource.h (tui_update_source_window)
3747         (tui_update_source_window_as_is): Change parameter type.
3748         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3749         to be a tui_source_window_base.
3750         (tui_update_source_window_as_is): Likewise.
3751         * tui/tui-win.c (make_visible_with_new_height): Update.
3752
3753 2019-06-25  Tom Tromey  <tom@tromey.com>
3754
3755         * tui/tui-winsource.c (tui_erase_source_content)
3756         (tui_show_source_content, tui_show_exec_info_content)
3757         (tui_erase_exec_info_content): Use refresh_window method.
3758         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3759         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3760         from tui_refresh_win.
3761         (tui_data_window::refresh_window): New method.
3762         (tui_win_info::refresh, tui_source_window_base::refresh)
3763         (tui_refresh_all): Use refresh_window method.
3764         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3765         method.
3766         * tui/tui-regs.c (tui_display_register): Call refresh_window
3767         method.
3768         * tui/tui-layout.c (show_source_disasm_command)
3769         (show_source_or_disasm_and_command): Call refresh_window method.
3770         * tui/tui-data.h (struct tui_gen_win_info)
3771         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3772         New method.
3773
3774 2019-06-25  Tom Tromey  <tom@tromey.com>
3775
3776         * tui/tui.c (tui_rl_other_window, tui_enable)
3777         (tui_is_window_visible, tui_get_command_dimension): Update.
3778         * tui/tui-winsource.c (tui_update_source_window_as_is)
3779         (tui_clear_source_content, tui_erase_source_content)
3780         (tui_show_source_line, tui_source_window_base::refill)
3781         (tui_source_window_base::do_scroll_horizontal)
3782         (tui_source_window_base::set_is_exec_point_at)
3783         (tui_update_breakpoint_info, tui_set_exec_info_content)
3784         (tui_alloc_source_buffer, tui_line_is_displayed)
3785         (tui_addr_is_displayed): Update.
3786         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3787         (tui_check_and_display_highlight_if_needed)
3788         (tui_win_info::make_visible, tui_win_info::refresh)
3789         (tui_refresh_all): Update.
3790         * tui/tui-windata.c (tui_first_data_item_displayed)
3791         (tui_delete_data_content_windows, tui_erase_data_content)
3792         (tui_display_all_data, tui_data_window::refresh_all)
3793         (tui_check_data_values): Update.
3794         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3795         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3796         (tui_win_info::backward_scroll, tui_refresh_all_win)
3797         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3798         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3799         (tui_source_window_base::set_new_height)
3800         (tui_data_window::set_new_height)
3801         (make_invisible_and_set_new_height)
3802         (make_visible_with_new_height, new_height_ok)
3803         (parse_scrolling_args): Update.
3804         * tui/tui-stack.c (tui_show_frame_info): Update.
3805         * tui/tui-source.c (tui_set_source_content)
3806         (tui_set_source_content_nil, tui_source_is_displayed)
3807         (tui_source_window::do_scroll_vertical): Update.
3808         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3809         (tui_display_registers_from, tui_display_reg_element_at_line)
3810         (tui_check_register_values, tui_reg_command): Update.
3811         * tui/tui-layout.c (tui_default_win_height)
3812         (show_source_disasm_command, show_data, init_and_make_win)
3813         (show_source_or_disasm_and_command): Update.
3814         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3815         (tui_redisplay_readline, tui_mld_flush)
3816         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3817         (tui_getc): Update.
3818         * tui/tui-disasm.c (tui_set_disassem_content)
3819         (tui_disasm_window::do_scroll_vertical): Update.
3820         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3821         Now virtual.
3822         (struct tui_win_info): Derive from tui_gen_win_info.
3823         <~tui_win_info>: Mark as override.
3824         <generic>: Remove member.
3825         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3826         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3827         (~tui_data_window, ~tui_win_info)
3828         (tui_free_all_source_wins_content): Update.
3829         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3830
3831 2019-06-25  Tom Tromey  <tom@tromey.com>
3832
3833         * tui/tui-layout.c (init_and_make_win): Use new.
3834         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3835         destructor, initializers.
3836         (tui_alloc_generic_win_info): Don't declare.
3837         * tui/tui-data.c (_locator): Add argument to constructor.
3838         (source_win, disasm_win): New globals.
3839         (exec_info): Remove.
3840         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3841         Update.
3842         (tui_alloc_generic_win_info): Remove.
3843         (init_content_element): Use new.
3844         (tui_win_info::tui_win_info): Update.
3845         (free_content_elements) <case DATA_WIN>: Use delete.
3846
3847 2019-06-25  Tom Tromey  <tom@tromey.com>
3848
3849         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3850         * tui/tui-windata.c (tui_first_data_item_displayed)
3851         (tui_delete_data_content_windows): Update.
3852         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3853         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3854         (tui_display_registers_from, tui_check_register_values): Update.
3855         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3856         pointer.
3857         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3858         window.
3859         (tui_free_data_content): Update.
3860         (free_content_elements) <case DATA_WIN>: Free the window.
3861
3862 2019-06-25  Tom Tromey  <tom@tromey.com>
3863
3864         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3865         Update.
3866         * tui/tui-layout.c (make_command_window)
3867         (show_source_disasm_command, show_data, init_and_make_win)
3868         (show_source_or_disasm_and_command): Update.
3869         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3870         method.
3871         <can_highight, is_highlighted>: Now bool.
3872         (tui_set_win_highlight): Don't declare.
3873         * tui/tui-data.c (tui_set_win_highlight): Remove.
3874
3875 2019-06-25  Tom Tromey  <tom@tromey.com>
3876
3877         * tui/tui-wingeneral.c (make_visible): Remove check of window
3878         type.
3879
3880 2019-06-25  Tom Tromey  <tom@tromey.com>
3881
3882         * tui/tui-win.c (tui_win_info::max_height)
3883         (tui_cmd_window::max_height): New methods.
3884         (new_height_ok): Call max_height.
3885         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3886         <max_height>: New method.
3887
3888 2019-06-25  Tom Tromey  <tom@tromey.com>
3889
3890         * tui/tui-win.c (tui_source_window_base::set_new_height)
3891         (tui_data_window::set_new_height): New methods.
3892         (make_invisible_and_set_new_height): Call set_new_height method.
3893         * tui/tui-data.h (struct tui_win_info)
3894         (struct tui_source_window_base, struct tui_data_window)
3895         <set_new_height>: New method.
3896
3897 2019-06-25  Tom Tromey  <tom@tromey.com>
3898
3899         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3900         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3901         tui_refresh_data_win.
3902         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3903         method.
3904         (tui_refresh_all_win): Call the refresh_all method.
3905         (tui_set_focus): Likewise.
3906         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3907         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3908         Likewise.
3909
3910 2019-06-25  Tom Tromey  <tom@tromey.com>
3911
3912         * tui/tui-winsource.h (tui_refill_source_window)
3913         (tui_set_is_exec_point_at): Don't declare.
3914         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3915         (tui_source_window_base::refill): Rename from
3916         tui_refill_source_window.
3917         (tui_source_window_base::do_scroll_horizontal): Update.
3918         (tui_source_window_base::set_is_exec_point_at): Rename from
3919         tui_set_is_exec_point_at.
3920         (tui_update_all_breakpoint_info): Update.
3921         * tui/tui-stack.c (tui_show_frame_info): Update.
3922         * tui/tui-layout.c (show_data): Add cast.
3923         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3924         * tui/tui-data.h (struct tui_source_window_base) <refill,
3925         set_is_exec_point_at>: New methods.
3926         (tui_source_windows, tui_add_to_source_windows): Update types.
3927         (tui_add_to_source_windows): Remove redundant declaration.
3928         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3929         (tui_source_windows): Change return type.
3930         (tui_clear_source_windows_detail): Update.
3931         (tui_add_to_source_windows): Change type of parameter.
3932         (tui_free_all_source_wins_content): Update.
3933
3934 2019-06-25  Tom Tromey  <tom@tromey.com>
3935
3936         * tui/tui-wingeneral.c (tui_win_info::refresh)
3937         (tui_source_window_base::refresh): New methods.
3938         (tui_refresh_all): Call the refresh method.
3939         * tui/tui-data.h (struct tui_win_info)
3940         (struct tui_source_window_base) <refresh>: New method.
3941
3942 2019-06-25  Tom Tromey  <tom@tromey.com>
3943
3944         * tui/tui.h (tui_is_window_visible): Return bool.
3945         * tui/tui.c (tui_is_window_visible): Return bool.
3946         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3947         (tui_make_visible, tui_make_invisible)
3948         (tui_win_info::make_visible)
3949         (tui_source_window_base::make_visible, make_all_visible)
3950         (tui_make_all_visible, tui_make_all_invisible): Update.
3951         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3952         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3953         bool.
3954         (struct tui_win_info, struct tui_source_window_base)
3955         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3956         * tui/tui-data.c (tui_init_generic_part): Update.
3957
3958 2019-06-25  Tom Tromey  <tom@tromey.com>
3959
3960         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3961         (tui_source_window_base::make_visible): New methods.
3962         (make_all_visible): Make method call.
3963         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3964         (struct tui_source_window_base, struct tui_cmd_window): Override
3965         make_visible.
3966         (tui_win_is_source_type): Don't declare.
3967         * tui/tui-data.c (tui_win_is_source_type): Remove.
3968
3969 2019-06-25  Tom Tromey  <tom@tromey.com>
3970
3971         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3972         NULL check.
3973
3974 2019-06-25  Tom Tromey  <tom@tromey.com>
3975
3976         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3977         Inline constructor.  Add initializers for members.
3978         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3979         constructors; now inline in class.
3980
3981 2019-06-25  Tom Tromey  <tom@tromey.com>
3982
3983         * tui/tui-regs.c (tui_show_registers): Update.
3984         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3985         bool.
3986         * tui/tui-data.c (tui_data_window::clear_detail)
3987         (tui_data_window): Update.
3988
3989 2019-06-25  Tom Tromey  <tom@tromey.com>
3990
3991         * tui/tui-windata.c (tui_display_all_data)
3992         (tui_display_data_from_line, tui_display_data_from)
3993         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3994         Update.
3995         * tui/tui-regs.c (tui_last_regs_line_no)
3996         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3997         (tui_show_registers, tui_show_register_group)
3998         (tui_display_registers_from, tui_display_reg_element_at_line)
3999         (tui_display_registers_from_line, tui_check_register_values)
4000         (tui_reg_next, tui_reg_prev): Update.
4001         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4002         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4003         tui_data_window.
4004         (struct tui_win_info) <detail>: Remove.  Add new fields from
4005         tui_data_info.
4006         (TUI_DATA_WIN): Add cast.
4007         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4008         (~tui_data_window): Simplify.
4009
4010 2019-06-25  Tom Tromey  <tom@tromey.com>
4011
4012         * tui/tui-layout.c (show_source_disasm_command)
4013         (show_source_or_disasm_and_command): Update.
4014         * tui/tui-io.c (update_cmdwin_start_line)
4015         (tui_redisplay_readline): Update.
4016         * tui/tui-data.h (struct tui_command_info): Remove.
4017         (struct tui_win_info) <detail>: Remove command_info member.
4018         (struct tui_data_window) <start_line>: New member, from
4019         tui_command_info.
4020         (TUI_CMD_WIN): Add casts.
4021
4022 2019-06-25  Tom Tromey  <tom@tromey.com>
4023
4024         * tui/tui-winsource.c (tui_update_source_window)
4025         (tui_refill_source_window)
4026         (tui_source_window_base::do_scroll_horizontal)
4027         (tui_update_breakpoint_info, tui_set_exec_info_content)
4028         (tui_show_exec_info_content, tui_erase_exec_info_content)
4029         (tui_clear_exec_info_content): Update.
4030         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4031         Update.
4032         * tui/tui-win.c (make_invisible_and_set_new_height)
4033         (make_visible_with_new_height): Update.
4034         * tui/tui-source.c (tui_set_source_content)
4035         (tui_show_symtab_source): Update.
4036         * tui/tui-layout.c (extract_display_start_addr)
4037         (show_source_disasm_command, show_data)
4038         (make_source_or_disasm_window)
4039         (show_source_or_disasm_and_command): Update.
4040         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4041         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4042         "gdbarch".
4043         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4044         to tui_source_window_base.
4045         (struct tui_win_info) <detail>: Remove source_info member.
4046         (struct tui_source_window_base) <has_locator>: Inline.
4047         Move contents from tui_source_info; rename has_locator member to
4048         m_has_locator.
4049         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4050         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4051         header file.
4052         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4053         Simplify.
4054         (tui_free_all_source_wins_content): Cast to
4055         tui_source_window_base.
4056
4057 2019-06-25  Tom Tromey  <tom@tromey.com>
4058
4059         * tui/tui-win.c (make_invisible_and_set_new_height)
4060         (make_visible_with_new_height): Call has_locator method.
4061         * tui/tui-layout.c (show_source_disasm_command, show_data)
4062         (show_source_or_disasm_and_command): Update for bool change.
4063         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4064         (tui_win_info) <has_locator>: New method.
4065         (struct tui_source_window_base) <has_locator>: New method.
4066         (tui_win_has_locator): Don't declare.
4067         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4068         from tui_win_has_locator.
4069         (tui_source_window_base): Use false, not FALSE.
4070
4071 2019-06-25  Tom Tromey  <tom@tromey.com>
4072
4073         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4074         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4075         clear_detail method directly.
4076         (tui_clear_win_detail): Remove.
4077
4078 2019-06-25  Tom Tromey  <tom@tromey.com>
4079
4080         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4081         "this", not TUI_DISASM_WIN.
4082
4083 2019-06-25  Tom Tromey  <tom@tromey.com>
4084
4085         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4086         declare.
4087         * tui/tui-winsource.c
4088         (tui_source_window_base::do_scroll_horizontal): Rename from
4089         tui_horizontal_source_scroll.
4090         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4091         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4092         from tui_vertical_data_scroll.
4093         * tui/tui-win.h (tui_scroll): Don't declare.
4094         * tui/tui-win.c (tui_win_info::forward_scroll)
4095         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4096         (tui_win_info::right_scroll): Rename and update.
4097         (tui_scroll_forward_command, tui_scroll_backward_command)
4098         (tui_scroll_left_command, tui_scroll_right_command): Update.
4099         (tui_scroll): Remove.
4100         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4101         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4102         from tui_vertical_source_scroll.
4103         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4104         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4105         from tui_vertical_disassem_scroll.
4106         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4107         do_scroll_horizontal>: New methods.
4108         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4109         Likewise.
4110         (struct tui_source_window_base): Add do_scroll_horizontal.
4111         (struct tui_source_window, struct tui_disasm_window): Add
4112         do_scroll_vertical.
4113         (struct tui_data_window, struct tui_cmd_window): Add
4114         do_scroll_horizontal and do_scroll_vertical.
4115         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4116
4117 2019-06-25  Tom Tromey  <tom@tromey.com>
4118
4119         * tui/tui-data.h (struct tui_source_window_base): New struct.
4120         (struct tui_source_window): Derive from tui_source_window_base.
4121         (struct tui_disasm_window): New struct.
4122         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4123         from tui_source_window::clear_detail.
4124         (tui_source_window_base): Rename from tui_source_window.
4125         (~tui_source_window_base): Rename from ~tui_source_window.
4126         (tui_alloc_win_info): Create a tui_disasm_window.
4127
4128 2019-06-25  Tom Tromey  <tom@tromey.com>
4129
4130         * tui/tui-data.h (struct tui_source_window)
4131         (struct tui_data_window): Declare destructors.
4132         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4133         destructors.
4134         (tui_win_info): Simplify.
4135
4136 2019-06-25  Tom Tromey  <tom@tromey.com>
4137
4138         * tui/tui-winsource.c (tui_display_main)
4139         (tui_update_source_windows_with_addr)
4140         (tui_update_all_breakpoint_info): Update.
4141         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4142         (new_height_ok, parse_scrolling_args): Update.
4143         * tui/tui-stack.c (tui_show_frame_info): Update.
4144         * tui/tui-data.h (struct tui_list): Remove.
4145         (tui_source_windows): Return a reference to a std::vector.
4146         * tui/tui-data.c (source_windows): Now a std::vector.
4147         (tui_source_windows): Change return type.
4148         (tui_clear_source_windows): Rewrite.
4149         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4150         (tui_free_all_source_wins_content): Rewrite.
4151
4152 2019-06-25  Tom Tromey  <tom@tromey.com>
4153
4154         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4155         (struct tui_data_window, struct tui_cmd_window): Declare
4156         clear_detail method.
4157         * tui/tui-data.c (tui_source_window::clear_detail)
4158         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4159         methods.
4160         (tui_clear_win_detail): Simplify.
4161
4162 2019-06-25  Tom Tromey  <tom@tromey.com>
4163
4164         * tui/tui-layout.c (make_source_window, make_disasm_window)
4165         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4166         Return the new window.
4167         (show_source_disasm_command, show_data)
4168         (show_source_or_disasm_and_command): Update.
4169
4170 2019-06-25  Tom Tromey  <tom@tromey.com>
4171
4172         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4173         parameter.  Return the new window.
4174         (show_source_disasm_command): Update and remove NULL check.
4175         (show_source_or_disasm_and_command): Update.
4176
4177 2019-06-25  Tom Tromey  <tom@tromey.com>
4178
4179         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4180
4181 2019-06-25  Tom Tromey  <tom@tromey.com>
4182
4183         * tui/tui-data.h (struct tui_win_info): Make constructor
4184         protected.  Make destructor virtual.  Add initializers.
4185         (tui_source_window, tui_data_window, tui_cmd_window): New
4186         classes.
4187         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4188         constructor.  Add "type" parameter.
4189         (tui_source_window, tui_data_window, tui_cmd_window): New
4190         constructors.
4191         (tui_alloc_win_info): Instantiate the appropriate subclass.
4192
4193 2019-06-25  Tom Tromey  <tom@tromey.com>
4194
4195         * tui/tui-win.c (tui_resize_all): Use delete.
4196         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4197         destructor.
4198         (tui_free_window): Don't declare.
4199         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4200         Update.
4201
4202 2019-06-25  Tom Tromey  <tom@tromey.com>
4203
4204         * tui/tui-data.h (struct tui_win_info): Add constructor.
4205         * tui/tui-data.c (tui_alloc_win_info): Use new.
4206         (tui_free_window): Use delete.
4207
4208 2019-06-22  Tom Tromey  <tom@tromey.com>
4209
4210         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4211         declare.
4212         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4213
4214 2019-06-22  Tom Tromey  <tom@tromey.com>
4215
4216         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4217         declare.
4218         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4219
4220 2019-06-22  Tom de Vries  <tdevries@suse.de>
4221
4222         * dwarf2read.c (create_addrmap_from_aranges)
4223         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4224         instead of '%zu'.
4225
4226 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4227
4228         * dwarf2read.h (dwarf2_section_info_def): Remove.
4229         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4230         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4231         std::vector<dwarf2_section_info>.
4232         (struct dwo_file) <~dwo_file>: Remove.
4233         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4234         types field.
4235         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4236         (dwarf2_read_debug_names): Likewise.
4237         (create_debug_types_hash_table): Change parameter type to
4238         array_view, adjust code accordingly.
4239         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4240         (partial_die_info::fixup): Likewise.
4241         (determine_prefix): Likewise.
4242         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4243
4244 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4245
4246         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4247         gdb_bfd_ref_ptr.
4248         <~dwo_file>: Remove call to gdb_bfd_unref.
4249         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4250         gdb_bfd_ref_ptr::get.
4251
4252 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4253
4254         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4255         type to htab_up.
4256         * dwarf2read.c (struct dwo_file): Initialize fields.
4257         <~dwo_file>: New.
4258         (free_dwo_file): Remove, move content to ~dwo_file.
4259         (struct dwo_file_deleter): Remove.
4260         (dwo_file_up>: Remove custom deleter.
4261         (free_dwo_files): Remove.
4262         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4263         dwo_files.
4264         (process_skeletonless_type_units): Call unique_ptr::get.
4265         (allocate_dwo_file_hash_table): Add deleter to created hash
4266         table.  Change return type to htab_up.
4267         (lookup_dwo_file_slot): Don't memset dwo_file, call
4268         unique_ptr::get.
4269         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4270         (create_dwo_unit_in_dwp_v2): Likewise.
4271         (open_and_init_dwo_file): Likewise.
4272         (free_dwo_file_from_slot): Remove.
4273
4274 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4275
4276         * dwarf2read.h (struct dwarf2_section_info) <readin,
4277         is_virtual>: Change type to bool.
4278         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4279         true instead of 1.
4280
4281 2019-06-19  Tom Tromey  <tom@tromey.com>
4282
4283         * tui/tui-data.h (tui_init_content_element): Don't declare.
4284
4285 2019-06-19  Tom Tromey  <tom@tromey.com>
4286
4287         * tui/tui-data.h (tui_init_win_info): Don't declare.
4288
4289 2019-06-19  Tom de Vries  <tdevries@suse.de>
4290
4291         * dwarf2read.h (abstract_to_concrete): Change type to
4292         std::unordered_map<sect_offset, std::vector<sect_offset>,
4293         gdb::hash_enum<sect_offset>>.
4294
4295 2019-06-19  Tom Tromey  <tromey@adacore.com>
4296
4297         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4298         EVAL_AVOID_SIDE_EFFECTS specially.
4299
4300 2019-06-19  Tom Tromey  <tromey@adacore.com>
4301
4302         * source-cache.c (highlighter): New global.
4303         (source_cache::get_source_lines): Create a highlighter on demand.
4304
4305 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4306
4307         * defs.h (deprecated_interactive_hook): Delete declaration.
4308         * interps.c (clear_interpreter_hooks): Remove use of
4309         deprecated_interactive_hook.
4310         * top.c (deprecated_interactive_hook): Delete definition.
4311         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4312
4313 2019-06-18  Tom de Vries  <tdevries@suse.de>
4314
4315         PR gdb/24515
4316         * dwarf2read.h (abstract_to_concrete): Change type from
4317         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4318         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4319         * dwarf2read.c (read_variable): Update.
4320         (dwarf2_fetch_die_loc_sect_off): Update.
4321
4322 2019-06-17  Tom de Vries  <tdevries@suse.de>
4323
4324         PR gdb/24617
4325         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4326         accessing parent[parent_len - 1].
4327
4328 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4329
4330         PR gdb/24364
4331         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4332         call dtrace_process_dof with NULL dof.
4333
4334 2019-06-16  Tom de Vries  <tdevries@suse.de>
4335
4336         PR gdb/24445
4337         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4338
4339 2019-06-16  Tom Tromey  <tom@tromey.com>
4340
4341         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4342         (make_all_visible): Use address of member.
4343
4344 2019-06-16  Tom Tromey  <tom@tromey.com>
4345
4346         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4347         (tui_free_window, free_content, free_content_elements): Remove
4348         unnecessary cast.
4349         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4350         cast.
4351         * tui/tui-regs.c (tui_show_register_group)
4352         (tui_display_registers_from, tui_display_reg_element_at_line):
4353         Remove unnecessary cast.
4354
4355 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4356
4357         * linux-nat.c (normal_mask): Delete.
4358         (_initialize_linux_nat): Don't initialise normal_mask.
4359
4360 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4361
4362         PR gdb/24445
4363         * dwarf-index-write.h (write_psymtabs_to_index): Add
4364         dwz_basename parameter.
4365         * dwarf-index-write.c (write_gdbindex): Move file writing to
4366         write_gdbindex_1.  Change return type void.
4367         (assert_file_size): Move up, remove filename parameter.
4368         (write_gdbindex_1): New function.
4369         (write_debug_names): Change return type to void, call
4370         assert_file_size.
4371         (struct index_wip_file): New struct.
4372         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4373         file logic to index_wip_file.  Write index for dwz file if
4374         needed.
4375         (save_gdb_index_command): Pass basename of dwz file, if present.
4376         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4377         build-id of dwz file, if present.
4378         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4379         (dwarf2_get_dwz_file): Likewise.
4380         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4381         (dwarf2_get_dwz_file): Likewise.
4382
4383 2019-06-16  Tom Tromey  <tom@tromey.com>
4384
4385         * coffread.c (process_coff_symbol): Use xstrdup.
4386         * value.c (create_internalvar): Use xstrdup.
4387
4388 2019-06-16  Tom Tromey  <tom@tromey.com>
4389
4390         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4391         * breakpoint.c (stopin_command, stopat_command)
4392         (until_break_command, decode_location_default): Remove unnecessary
4393         cast.
4394         * utils.c (subset_compare): Remove unnecessary cast.
4395         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4396         cast.
4397         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4398         cast.
4399         * infcmd.c (path_command): Remove unnecessary cast.
4400         * coffread.c (decode_type): Remove unnecessary cast.
4401         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4402         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4403         * tui/tui-stack.c (tui_show_locator_content)
4404         (tui_show_frame_info): Remove unnecessary cast.
4405         * tui/tui-win.c (tui_scroll_forward_command)
4406         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4407         (parse_scrolling_args): Remove unnecessary cast.
4408         * tui/tui-data.c (init_win_info, tui_del_window)
4409         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4410         (free_content_elements): Remove unnecessary cast.
4411         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4412         unnecessary cast.
4413         * tui/tui-source.c (tui_set_source_content)
4414         (tui_vertical_source_scroll): Remove unnecessary cast.
4415         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4416         cast.
4417         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4418         * tui/tui-regs.c (tui_display_registers_from)
4419         (tui_display_register): Remove unnecessary cast.
4420         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4421         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4422         (make_visible): Remove unnecessary cast.
4423         * tui/tui-winsource.c (tui_erase_source_content)
4424         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4425         unnecessary cast.
4426         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4427         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4428         * stabsread.c (read_type, read_array_type, read_range_type):
4429         Remove unnecessary cast.
4430         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4431         (parse_symbol, parse_type, upgrade_type, parse_external)
4432         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4433         unnecessary cast.
4434         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4435
4436 2019-06-16  Tom Tromey  <tom@tromey.com>
4437
4438         * tui/tui-data.c (tui_alloc_generic_win_info)
4439         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4440         checks.
4441
4442 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4443             Andrew Burgess  <andrew.burgess@embecosm.com>
4444
4445         * f-typeprint.c (f_print_type): Don't return early for not
4446         associated or not allocated types.
4447         (f_type_print_varspec_suffix): Add print_rank parameter and print
4448         ranks of array types in case they dangling.
4449         (f_type_print_base): Add print_rank parameter.
4450
4451 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4452
4453         * NEWS: Mention new MI commands.
4454         * break-catch-throw.c (enum exception_event_kind): Move to
4455         breakpoint.h.
4456         (print_mention_exception_catchpoint): Output text as a single
4457         message.
4458         (catch_exception_command_1): Rename to...
4459         (catch_exception_event): ...this, make non-static, update header
4460         command, and change some parameter types.
4461         (catch_catch_command): Update for changes to
4462         catch_exception_command_1.
4463         (catch_throw_command): Likewise.
4464         (catch_rethrow_command): Likewise.
4465         * breakpoint.c (enum exception_event_kind): Delete.
4466         * breakpoint.h (enum exception_event_kind): Moved here from
4467         break-catch-throw.c.
4468         (catch_exception_event): Declare.
4469         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4470         (mi_cmd_catch_throw): New function.
4471         (mi_cmd_catch_rethrow): New function.
4472         (mi_cmd_catch_catch): New function.
4473         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4474         'catch-catch' entries.
4475         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4476         (mi_cmd_catch_rethrow): Declare.
4477         (mi_cmd_catch_catch): Declare.
4478
4479 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4480
4481         * annotate.c (annotate_source_line): Change return type to void,
4482         update implementation to match.
4483         * annotate.h (annotate_source_line): Change return type to void,
4484         update header comment.
4485         * stack.c (print_frame_info): Don't change what frame information
4486         is printed based on whether annotations are on or not.
4487
4488 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4489
4490         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4491         (annotate_source): Make static.
4492         (annotate_source_line): Moved from source.c and renamed from
4493         identify_source_line.  Update the return type.
4494         * annotate.h (annotate_source): Delete declaration.
4495         (annotate_source_line): Declaration moved from source.h, and
4496         renamed from identify_source_line.  Return type updated.
4497         * source.c (identify_source_line): Moved to annotate.c and renamed
4498         to annotate_source_line.
4499         (info_line_command): Remove check of annotation_level.
4500         * source.h (identify_source_line): Move declaration to annotate.h
4501         and rename to annotate_source_line.
4502         * stack.c: Add 'annotate.h' include.
4503         (print_frame_info): Remove check of annotation_level before
4504         calling annotate_source_line.
4505
4506 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4507
4508         * source-cache.c (source_cache::get_plain_source_lines): Use
4509         open_source_file_with_line_charpos instead of just
4510         open_source_file, remove call to find_source_lines.
4511         (source_cache::get_source_lines): Likewise.
4512         * source.c (find_source_lines): Make static.
4513         (get_filename_and_charpos): Renamed into...
4514         (open_source_file_with_line_charpos): ..this along with changes to
4515         return a scoped_fd, and some other minor clean ups.
4516         (identify_source_line): Use open_source_file_with_line_charpos.
4517         (search_command_helper): Use open_source_file_with_line_charpos
4518         instead of just open_source_file, remove call to
4519         find_source_lines.
4520         * source.h (open_source_file_with_line_charpos): Declare new
4521         function.
4522         (find_source_lines): Delete declaration.
4523
4524 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4525
4526         * source.c (get_filename_and_charpos): Remove fullname
4527         parameter.
4528         (identify_source_line): Update call to get_filename_and_charpos.
4529
4530 2019-06-14  Tom Tromey  <tromey@adacore.com>
4531
4532         PR gdb/24502:
4533         * ui-style.h (skip_ansi_escape): Update comment.
4534         * ui-file.h (class no_terminal_escape_file): New class.
4535         * ui-file.c (no_terminal_escape_file::write)
4536         (no_terminal_escape_file::puts): New methods.
4537         * cli/cli-logging.c (handle_redirections): Use
4538         no_terminal_escape_file.
4539
4540 2019-06-14  Tom Tromey  <tromey@adacore.com>
4541
4542         * NEWS: Move convenience variable news above Python news.
4543
4544 2019-06-14  Tom Tromey  <tom@tromey.com>
4545
4546         * gnulib: Move directory to top-level.
4547         * configure.ac: Don't configure gnulib.
4548         * configure: Rebuild.
4549         * common/common-defs.h: Use new path to gnulib.
4550         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4551         (GNULIB_H): Remove.
4552         (INCGNU): Look in new gnulib location.
4553         (HFILES_NO_SRCDIR): Remove gnulib files.
4554         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4555         (generated_files): Remove GNULIB_H.
4556         ($(LIBGNU), all-lib): Remove targets.
4557         (distclean): Don't mention GNULIB_BUILDDIR.
4558         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4559
4560 2019-06-14  Tom Tromey  <tromey@adacore.com>
4561
4562         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4563         Warn if symbol file does not provide any symbols.
4564
4565 2019-06-14  Tom Tromey  <tromey@adacore.com>
4566
4567         * source.c (find_and_open_source): Respect basenames_may_differ.
4568
4569 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4570
4571         * annotate.c (annotate_breakpoints_invalid): Make use of
4572         scoped_restore_terminal_state.
4573         (annotate_frames_invalid): Likewise.
4574
4575 2019-06-14  Tom Tromey  <tromey@adacore.com>
4576
4577         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4578         allow assignment to an internalvar.
4579
4580 2019-06-14  Tom Tromey  <tromey@adacore.com>
4581
4582         * ada-lex.l: Allow "_" in attribute names.
4583
4584 2019-06-14  Tom Tromey  <tromey@adacore.com>
4585
4586         PR gdb/24653:
4587         * regcache.c (registers_changed): Don't call alloca.
4588         * top.c (execute_command): Don't call alloca.
4589
4590 2019-06-13  Pedro Alves  <palves@redhat.com>
4591
4592         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4593         'expression'.  When parsing an expression, error out if there's
4594         junk after "unlimited".
4595         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4596         (do_set_command): Adjust calls to is_unlimited_literal.
4597
4598 2019-06-13  Pedro Alves  <palves@redhat.com>
4599
4600         * compile/compile.c (make_compile_options_def_group): Add braces
4601         around array_view initializer.
4602         * thread.c (make_thread_apply_all_options_def_group)
4603         (make_thread_apply_all_options_def_group): Likewise.
4604
4605 2019-06-13  Pedro Alves  <palves@redhat.com>
4606
4607         * NEWS (New commands): Mention "maint test-options
4608         require-delimiter", "maint test-options unknown-is-error", "maint
4609         test-options unknown-is-operand" and "maint show
4610         test-options-completion-result".
4611         (New command options, command completion): New section.
4612         (Completion improvements): New section.
4613         Mention that you can abbreviate "unlimited".
4614
4615 2019-06-13  Pedro Alves  <palves@redhat.com>
4616
4617         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4618         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4619         * unittests/cli-utils-selftests.c (test_parse_flags)
4620         (test_parse_flags_qcs): Delete.
4621         (test_cli_utils): Don't call deleted functions.
4622
4623 2019-06-13  Pedro Alves  <palves@redhat.com>
4624
4625         * thread.c: Include "cli/cli-option.h".
4626         (tp_array_compar_ascending): Global.
4627         (tp_array_compar): Delete function.
4628         (tp_array_compar_ascending, tp_array_compar_descending): New
4629         functions.
4630         (ascending_option_def, qcs_flag_option_def)
4631         (thr_qcs_flags_option_defs)
4632         (make_thread_apply_all_options_def_group)
4633         (make_thread_apply_options_def_group): New.
4634         (thread_apply_all_command): Use gdb::option::process_options.
4635         (thread_apply_command_completer)
4636         (thread_apply_all_command_completer): New.
4637         (thread_apply_command): Use gdb::option::process_options.
4638         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4639         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4640         to generate help text of "thread apply".  Adjust "taas"'s help.
4641         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4642         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4643
4644 2019-06-13  Pedro Alves  <palves@redhat.com>
4645
4646         * thread.c (thread_apply_command): Check for invalid TID with
4647         isdigit instead of !isalpha.
4648
4649 2019-06-13  Pedro Alves  <palves@redhat.com>
4650
4651         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4652         (validate_flags_qcs): New.
4653         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4654         (validate_flags_qcs): Declare.
4655         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4656         (make_frame_apply_options_def_group): New.
4657         (frame_apply_command_count): Process options with
4658         gdb::option::process_options.
4659         (frame_apply_completer): New.
4660         (frame_apply_level_completer, frame_apply_all_completer)
4661         (frame_apply_completer): New.
4662         (_initialize_stack): Update help of "frame apply", "frame apply
4663         level", "frame apply all" and "faas" to mention supported options
4664         and install command completers.
4665         * stack.h (frame_apply_all_completer): Declare.
4666         * thread.c: Include "stack.h".
4667         (tfaas_command): Add "--".
4668         (_initialize_thread): Update help "tfaas" to mention supported
4669         options and install command completer.
4670
4671 2019-06-13  Pedro Alves  <palves@redhat.com>
4672
4673         * completer.c (complete_nested_command_line): New.
4674         (gdb_completion_word_break_characters_throw): Add assertion.
4675         * completer.h (complete_nested_command_line): Declare.
4676
4677 2019-06-13  Pedro Alves  <palves@redhat.com>
4678
4679         * stack.c (parse_backtrace_qualifiers): New.
4680         (backtrace_command): Use it.
4681         (backtrace_command_completer): Complete on qualifiers.
4682
4683 2019-06-13  Pedro Alves  <palves@redhat.com>
4684
4685         * frame.c: Include "cli/cli-option.h.
4686         (user_set_backtrace_options): New.
4687         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4688         Delete.
4689         (get_prev_frame): Adjust.
4690         (boolean_option_def, uinteger_option_def)
4691         (set_backtrace_option_defs): New.
4692         (_initialize_frame): Adjust and use
4693         gdb::option::add_setshow_cmds_for_options to install "set
4694         backtrace past-main" and "set backtrace past-entry".
4695         * frame.h: Include "cli/cli-option.h".
4696         (struct frame_print_options): Forward declare.
4697         (print_frame_arguments_all, print_frame_arguments_scalars)
4698         (print_frame_arguments_none): Declare.
4699         (print_entry_values): Delete declaration.
4700         (struct frame_print_options, user_frame_print_options): New.
4701         (struct set_backtrace_options): New.
4702         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4703         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4704         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4705         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4706         (list_args_or_locals): Add frame_print_options parameter.
4707         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4708         * python/py-framefilter.c (enumerate_args): Pass down
4709         USER_FRAME_PRINT_OPTIONS.
4710         * stack.c: Include "cli/cli-option.h".
4711         (print_frame_arguments_all, print_frame_arguments_scalars)
4712         (print_frame_arguments_none): Declare.
4713         (print_raw_frame_arguments, print_entry_values): Delete.
4714         (user_frame_print_options): New.
4715         (boolean_option_def, enum_option_def, frame_print_option_defs):
4716         New.
4717         (struct backtrace_cmd_options): New.
4718         (bt_flag_option_def): New.
4719         (backtrace_command_option_defs): New.
4720         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4721         (print_frame_arg, read_frame_arg, print_frame_args)
4722         (print_frame_info, print_frame): Add frame_print_options parameter
4723         and use it.
4724         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4725         (backtrace_command_1): Add frame_print_options and
4726         backtrace_cmd_options parameters and use them.
4727         (make_backtrace_options_def_group): New.
4728         (backtrace_command): Process command options with
4729         gdb::option::process_options.
4730         (backtrace_command_completer): New.
4731         (_initialize_stack): Extend "backtrace"'s help to mention
4732         supported options.  Install completer for "backtrace".
4733         Install some settings commands with add_setshow_cmds_for_options.
4734
4735 2019-06-13  Pedro Alves  <palves@redhat.com>
4736
4737         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4738         and that "set/show print raw frame-arguments" are now deprecated.
4739
4740         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4741         command.
4742         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4743         * stack.c (_initialize_stack): Install "set/show print
4744         raw-frame-arguments", and deprecate "set/show print raw
4745         frame-arguments".
4746         * valprint.c (_initialize_valprint): Deprecate "set/show print
4747         raw".
4748
4749 2019-06-13  Pedro Alves  <palves@redhat.com>
4750
4751         * compile/compile.c (struct compile_options): New.
4752         (compile_flag_option_def, compile_command_option_defs)
4753         (make_compile_options_def_group): New.
4754         (compile_file_command): Handle options with
4755         gdb::option::process_options.
4756         (compile_file_command_completer): New function.
4757         (compile_code_command): Handle options with
4758         gdb::option::process_options.
4759         (compile_code_command_completer): New function.
4760         (_initialize_compiler): Install completers for "compile code" and
4761         "compile file".  Mention available options in "compile code" and
4762         "compile code"'s help.
4763         * completer.c (advance_to_completion_word): New, factored out from
4764         ...
4765         (advance_to_expression_complete_word_point): ... this.
4766         (advance_to_filename_complete_word_point): New.
4767         * completer.h (advance_to_filename_complete_word_point): New
4768         declaration.
4769
4770 2019-06-13  Pedro Alves  <palves@redhat.com>
4771
4772         * compile/compile.c: Include "cli/cli-option.h".
4773         (compile_print_value): Scope data pointer is now a
4774         value_print_options pointer; adjust.
4775         (compile_print_command): Process options.  Scope data pointer is
4776         now a value_print_options pointer; adjust.
4777         (_initialize_compile): Update "compile print"'s help to include
4778         supported options.  Install a completer for "compile print".
4779         * cp-valprint.c (show_vtblprint, show_objectprint)
4780         (show_static_field_print): Delete.
4781         (_initialize_cp_valprint): Don't install "set print
4782         static-members", "set print vtbl", "set print object" here.
4783         * printcmd.c: Include "cli/cli-option.h" and
4784         "common/gdb_optional.h".
4785         (print_command_parse_format): Rework to fill in a
4786         value_print_options instead of a format_data.
4787         (print_value): Change parameter type from format_data pointer to
4788         value_print_options reference.  Adjust.
4789         (print_command_1): Process options.  Adjust to pass down a
4790         value_print_options.
4791         (print_command_completer): New.
4792         (_initialize_printcmd): Install print_command_completer as
4793         handle_brkchars completer for the "print" command.  Update
4794         "print"'s help to include supported options.
4795         * valprint.c: Include "cli/cli-option.h".
4796         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4797         here from cp-valprint.c.
4798         (boolean_option_def, uinteger_option_def)
4799         (value_print_option_defs, make_value_print_options_def_group):
4800         New.  Use gdb::option::add_setshow_cmds_for_options to install
4801         "set print elements", "set print null-stop", "set print repeats",
4802         "set print pretty", "set print union", "set print array", "set
4803         print address", "set print symbol", "set print array-indexes".
4804         * valprint.h: Include <string> and "cli/cli-option.h".
4805         (make_value_print_options_def_group): Declare.
4806         (print_value): Change parameter type from format_data pointer to
4807         value_print_options reference.
4808         (print_command_completer): Declare.
4809
4810 2019-06-13  Pedro Alves  <palves@redhat.com>
4811
4812         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4813         (COMMON_SFILES): Add maint-test-settings.c.
4814         * cli/cli-decode.c (boolean_enums): New global, factored out from
4815         ...
4816         (add_setshow_boolean_cmd): ... here.
4817         * cli/cli-decode.h (boolean_enums): Declare.
4818         * cli/cli-option.c: New file.
4819         * cli/cli-option.h: New file.
4820         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4821         factored out from ...
4822         (parse_cli_boolean_value(const char *)): ... this.
4823         (is_unlimited_literal): Change parameter type to pointer to
4824         pointer.  Adjust and advance ARG pointer.
4825         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4826         (parse_cli_var_enum): New, factored out from ...
4827         (do_set_command): ... this.  Adjust.
4828         * cli/cli-setshow.h (parse_cli_boolean_value)
4829         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4830         (parse_cli_var_enum): Declare.
4831         * cli/cli-utils.c: Include "cli/cli-option.h".
4832         (get_ulongest): New.
4833         * cli/cli-utils.h (get_ulongest): Declare.
4834         (check_for_argument): New overloads.
4835         * maint-test-options.c: New file.
4836
4837 2019-06-13  Pedro Alves  <palves@redhat.com>
4838
4839         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4840         parse a range if "-" is at the end of the string.
4841
4842 2019-06-13  Pedro Alves  <palves@redhat.com>
4843
4844         * cli/cli-setshow.c (parse_auto_binary_operation)
4845         (parse_cli_boolean_value): Don't allow "o".
4846
4847 2019-06-13  Pedro Alves  <palves@redhat.com>
4848
4849         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4850         * NEWS: Mention maint test-settings KIND.
4851         * maint-test-settings.c: New file.
4852
4853 2019-06-13  Pedro Alves  <palves@redhat.com>
4854
4855         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4856         completer.
4857         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4858         "set" completers.
4859
4860 2019-06-13  Pedro Alves  <palves@redhat.com>
4861
4862         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4863         after item.
4864
4865 2019-06-13  Pedro Alves  <palves@redhat.com>
4866
4867         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4868
4869 2019-06-13  Pedro Alves <palves@redhat.com>
4870
4871         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4872         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4873         call.
4874         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4875         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4876         calls.
4877         (check_for_argument): Skip spaces after argument.
4878
4879 2019-06-13  Pedro Alves  <palves@redhat.com>
4880
4881         * thread.c (thread_apply_command): Adjust TID parsing.
4882         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4883         detected before end of string.
4884         (tid_is_in_list): Error out if LIST is invalid.
4885
4886 2019-06-13  Pedro Alves  <palves@redhat.com>
4887
4888         * completer.c (complete_line_internal_1): Rewind completion word
4889         point.
4890         (completion_tracker::advance_custom_word_point_by): Change
4891         parameter type to int.
4892         * completer.h (completion_tracker::advance_custom_word_point_by):
4893         Likewise.
4894
4895 2019-06-13  Pedro Alves  <palves@redhat.com>
4896
4897         * completer.c (advance_to_completion_word): Handle delimiters.
4898
4899 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4900
4901         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4902
4903 2019-06-11  Tom Tromey  <tom@tromey.com>
4904
4905         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4906         (xmalloc_failed): Move to alloc.c.
4907         * alloc.c: New file.
4908         * Makefile.in (COMMON_SFILES): Add alloc.c.
4909
4910 2019-06-11  Tom Tromey  <tom@tromey.com>
4911
4912         * nat/linux-waitpid.c: Don't include server.h.
4913         (linux_debug): Remove.
4914         (my_waitpid): Update.
4915
4916 2019-06-11  Tom Tromey  <tromey@adacore.com>
4917
4918         * infcall.c (_initialize_infcall): Remove trailing newline from
4919         help.
4920         * user-regs.c (_initialize_user_regs): Remove trailing newline
4921         from help.
4922         * typeprint.c (_initialize_typeprint): Remove trailing newline
4923         from help.
4924         * reverse.c (_initialize_reverse): Remove trailing newlines from
4925         help.
4926         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4927         from help.
4928         * language.c (add_set_language_command): Remove trailing newline
4929         from help.
4930         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4931         help.
4932         * disasm.c (_initialize_disasm): Remove trailing newline from
4933         help.
4934         * top.c (init_main): Remove trailing newline from help.
4935         * interps.c (_initialize_interpreter): Remove trailing newline
4936         from help.
4937         * btrace.c (_initialize_btrace): Remove trailing newlines from
4938         help.
4939         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4940         from help.
4941         * python/python.c (_initialize_python): Remove trailing newline
4942         from help.
4943         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4944         help.
4945         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4946         from help.  Reformat some text.
4947         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4948         from help.
4949         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4950         newline from help.
4951
4952 2019-06-11  Tom Tromey  <tromey@adacore.com>
4953
4954         * darwin-nat.c (darwin_decode_exception_message)
4955         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4956
4957 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4958
4959         * valops.c (value_slice): Check for not allocated or not
4960         associated values.
4961
4962 2019-06-10  Tom de Vries  <tdevries@suse.de>
4963
4964         PR gdb/24618
4965         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4966         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4967         invalid.
4968
4969 2019-06-10  Tom de Vries  <tdevries@suse.de>
4970
4971         PR gdb/24611
4972         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4973         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4974
4975 2019-06-10  Tom de Vries  <tdevries@suse.de>
4976
4977         PR symtab/24545
4978         * symtab.c (struct demangled_name_entry): Add language field.
4979         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4980         static minimal symbol".  Set and use language field.
4981
4982 2019-06-10  Tom Tromey  <tromey@adacore.com>
4983
4984         * ada-lang.c (_initialize_ada_language): Update help text.
4985
4986 2019-06-10  Tom Tromey  <tromey@adacore.com>
4987
4988         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4989         with a newline.
4990         * guile/guile.c (handle_boot_error): Don't end warning with a
4991         newline.
4992         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4993         warning with a newline.
4994         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4995         newline.
4996         (s12z_frame_cache): Likewise.
4997         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4998         a newline.
4999         * solib-svr4.c (disable_probes_interface): Don't end warning with
5000         a newline.
5001         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5002         newline.
5003         * python/python.c (do_finish_initialization): Don't end warning
5004         with a newline.
5005
5006 2019-06-10  Tom Tromey  <tom@tromey.com>
5007
5008         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5009         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5010         gdbpy_enter.
5011
5012 2019-06-10  Tom Tromey  <tromey@adacore.com>
5013
5014         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5015         data.
5016         (elf_new_init): Don't call stabsread_new_init.
5017         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5018         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5019         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5020
5021 2019-06-10  Tom de Vries  <tdevries@suse.de>
5022
5023         PR symtab/16264
5024         PR symtab/24517
5025         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5026
5027 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5028
5029         * source.c (find_and_open_source): Also rewrite relative file
5030         names.
5031
5032 2019-04-26  Amos Bird  <amosbird@gmail.com>
5033
5034         * annotate.c (annotate_thread_exited): Add "thread-exited"
5035         annotation.
5036
5037 2019-06-06  Tom Tromey  <tromey@adacore.com>
5038
5039         * maint.h (class scoped_command_stats): Use
5040         DISABLE_COPY_AND_ASSIGN.
5041         <print_time>: New method.
5042         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5043         print_time.
5044         (scoped_command_stats::print_time): New method.
5045
5046 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5047
5048         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5049         instructions of lengths 6 or 8 bytes.
5050
5051 2019-06-04  Pedro Alves  <palves@redhat.com>
5052
5053         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5054
5055         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5056         * breakpoint.c (condition_completer): Likewise.
5057         * cli/cli-dump.c (scan_expression): Likewise.
5058         * common/filestuff.c (mkdir_recursive): Likewise.
5059         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5060         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5061         (gdb_abspath): Likewise.
5062         * compile/compile-cplus-types.c
5063         (compile_cplus_instance::decl_name): Likewise.
5064         * completer.c (complete_explicit_location):
5065         (signal_completer, reg_or_group_completer_1): Likewise.
5066         * cp-support.c (cp_remove_params_if_any): Likewise.
5067         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5068         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5069         * infcmd.c (strip_bg_char): Likewise.
5070         * linespec.c (copy_token_string): Likewise.
5071         * mi/mi-main.c (output_cores): Likewise.
5072         * psymtab.c (psymtab_search_name):
5073         * symfile.c (test_set_ext_lang_command): Likewise.
5074         * target.c (target_fileio_read_stralloc): Likewise.
5075         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5076         * value.c (complete_internalvar): Likewise.
5077
5078 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5079
5080         Add objfile property to gdb.Type.
5081         * NEWS: Mention Python API addition.
5082         * python/py-type.c (typy_get_objfile): New method.
5083
5084 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5085
5086         * NEWS: Mention the new set|show style [title|highlight].
5087         Mention changes to "show style", "help" and "apropos".
5088
5089 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5090
5091         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5092         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5093         instead of print_help_for_command.
5094         (print_doc_of_command): New function.
5095         (help_list): Add 'apropos -v word' suggestion.
5096         (print_help_for_command): Style the command name using title style.
5097         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5098         (_initialize_cli_cmds): Describe -v in apropos_command help.
5099
5100 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5101
5102         * cli/cli-style.h (cli_style_option): Add name in constructor,
5103         add m_name class member, add constructor with intensity,
5104         add name class function.
5105         (cli_style_option::add_setshow_commands): Remove name argument.
5106         (highlight_style, title_style): New styles.
5107         * cli/cli-style.c (do_show): New function that shows a style
5108         characteristic styling the style name with itself.
5109         (set_style_name): New function.
5110         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5111         Update all callers according to the changes in cli/cli-style.h.
5112         * utils.h (fputs_highlighted): New function.
5113         * utils.c (fputs_highlighted): Likewise.
5114
5115 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5116
5117         * NEWS: Mention new pipe command and new convenience variables.
5118
5119 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5120
5121         * cli/cli-cmds.c (pipe_command): New function.
5122         (_initialize_cli_cmds): Call add_com for pipe_command.
5123         Define | as an alias for pipe.
5124         (exit_status_set_internal_vars): New function.
5125         (shell_escape): Call exit_status_set_internal_vars.
5126         cli/cli-decode.c (find_command_name_length): Recognize | as
5127         a single character command.
5128
5129 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5130
5131         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5132         top.c (execute_command_to_ui_file): New function, mostly a copy
5133         of execute_command_to_string.
5134         (execute_command_to_string): Implement by calling
5135         execute_command_to_ui_file.
5136
5137 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5138
5139         * top.h (saved_command_line): Remove declaration.
5140         * top.c (previous_saved_command_line, previous_repeat_arguments):
5141         New variables.
5142         (saved_command_line): Make static, define together with other
5143         'repeat variables'.
5144         (dont_repeat): Clear repeat_arguments.
5145         (repeat_previous, get_saved_command_line, save_command_line):
5146         New functions.
5147         (gdb_init): Initialize saved_command_line
5148         and previous_saved_command_line.
5149         * main.c (captured_main_1): Remove saved_command_line initialization.
5150         * event-top.c (handle_line_of_input): Update to use
5151         the new 'repeat' related functions instead of direct access to
5152         saved_command_line.
5153         * command.h (repeat_previous, get_saved_command_line,
5154         save_command_line): New declarations.
5155         (dont_repeat): Add comment.
5156
5157 2019-05-30  Tom Tromey  <tromey@adacore.com>
5158
5159         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5160         Fix comment.
5161         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5162
5163 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5164
5165         PR cli/24587
5166         * completer.c (complete): Initialize variable word.
5167
5168 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5169
5170         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5171         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5172         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5173         'body' is NULL to the outter 'if', protecting the '!is_define'
5174         situation as well.
5175
5176 2019-05-29  Tom Tromey  <tromey@adacore.com>
5177
5178         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5179         (dwarf_unknown): New function.
5180         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5181         (dwarf_type_encoding_name): Use dwarf_unknown.
5182
5183 2019-05-29  Tom Tromey  <tromey@adacore.com>
5184
5185         PR c++/20020:
5186         * cp-valprint.c (cp_print_value_fields): Call
5187         cp_print_static_field inside "try".
5188
5189 2019-05-29  Tom Tromey  <tromey@adacore.com>
5190
5191         * inflow.c (struct terminal_info): Add default operator=.
5192         * configure: Rebuild.
5193         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5194         -Wdeprecated-copy-dtor, -Wredundant-move.
5195
5196 2019-05-29  Tom Tromey  <tromey@adacore.com>
5197
5198         * NEWS: Add entry.
5199         * infcmd.c (print_return_value_1): Handle finish_print
5200         option.
5201         (show_print_finish): New function.
5202         (_initialize_infcmd): Add "set/show print finish" commands.
5203         * valprint.c (user_print_options): Initialize new member.
5204         * valprint.h (struct value_print_options) <finish_print>: New
5205         member.
5206
5207 2019-05-28  Tom Tromey  <tromey@adacore.com>
5208
5209         * ada-lang.c (ada_remove_Xbn_suffix)
5210         (find_old_style_renaming_symbol)
5211         (parse_old_style_renaming): Remove.
5212         (ada_find_renaming_symbol): Don't call
5213         find_old_style_renaming_symbol.
5214         (ada_is_renaming_symbol): Rename from
5215         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5216         bool.  Now static.
5217         (ada_read_var_value): Update and simplify.
5218         * ada-exp.y (write_var_or_type): Remove old code.
5219
5220 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5221
5222         * event-top.c: Remove include comment.
5223         * inflow.c (class scoped_ignore_sigttou): Move from here...
5224         * inflow.h (class scoped_ignore_sigttou): ...to here.
5225         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5226         * top.c:  Remove include comment.
5227
5228 2019-05-27  Tom Tromey  <tom@tromey.com>
5229
5230         * NEWS: Fix typo.
5231
5232 2019-05-22  Tom Tromey  <tromey@adacore.com>
5233
5234         * target.c (target_follow_exec): Constify parameter.
5235         * target-delegates.c: Rebuild.
5236         * remote.c (remote_target::follow_exec): Constify parameter.
5237         * infrun.c (follow_exec): Constify parameter.
5238         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5239         (target_follow_exec): Likewise.
5240
5241 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5242
5243         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5244         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5245
5246 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5247
5248         * NEWS: Add debugredirect and testsuite sections.
5249
5250 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5251
5252         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5253         target descriptions using exclusively floating point register name
5254         aliases.
5255
5256 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5257
5258         PR gdb/18644:
5259         * f-lang.c (build_fortran_types): Handle the case where
5260         gdbarch_floatformat_for_type returns a nullptr.
5261
5262 2019-05-21  Tom de Vries  <tdevries@suse.de>
5263
5264         PR cli/24587
5265         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5266
5267 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5268
5269         PR gdb/18644:
5270         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5271         16-byte floats.
5272         * i386-tdep.c (i386_floatformat_for_type): Use
5273         floatformats_ia64_quad for the 16-byte floating point component
5274         within a fortran 32-byte complex number.
5275
5276 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5277
5278         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5279         delete default constructor.
5280         (find_partial_die): Update to return const struct.
5281         (partial_die_parent_scope): Move variable declaration into scope
5282         of its use and change its type to auto.
5283         (guess_partial_die_structure_name): Likewise.
5284         (partial_die_info::fixup): Likewise.
5285
5286 2019-05-17  Tom Tromey  <tromey@adacore.com>
5287
5288         * source.c (find_and_open_source): Remove cast.
5289
5290 2019-05-17  Tom Tromey  <tromey@adacore.com>
5291
5292         * annotate.c (annotate_source): Make "filename" const.
5293         * annotate.h (annotate_source): Use const.
5294
5295 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5296
5297         * disasm.c (set_disassembler_options): Send errors to stderr.
5298
5299 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5300
5301         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5302         (cli_interp_base::set_logging): Check debug_redirect.
5303         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5304         * cli/cli-logging.c (debug_redirect): Add static variable.
5305         (pop_output_files): Add default param.
5306         (handle_redirections): Print debug setting.
5307         (show_logging_command): Likewise.
5308         (_initialize_cli_logging): Add debugredirect command.
5309         * interps.c (current_interp_set_logging): Add debug_redirect
5310         parameter.
5311         * interps.h (set_logging): Add debug_redirect parameter.
5312         (current_interp_set_logging): Likewise.
5313         * mi/mi-common.h: Likewise.
5314         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5315
5316 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5317             Tom Tromey  <tromey@adacore.com>
5318
5319         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5320         directly.
5321         * cli/cli-interp.h (make_logging_output): Remove declaration.
5322         * cli/cli-logging.c (make_logging_output): Remove function.
5323         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5324         directly.
5325         * ui-file.c (tee_file::tee_file): Remove bools.
5326         (tee_file::~tee_file): Remove deletes.
5327         * ui-file.h (tee_file): Remove bools.
5328
5329 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5330
5331         * mi/mi-cmds.h (mi_cmd_complete): New function.
5332         * mi/mi-main.c (mi_cmd_complete): Likewise.
5333         * mi/mi-cmds.c: Define new MI command -complete.
5334         * NEWS: Mention new -complete command.
5335
5336 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5337
5338         * completer.h (complete): New function.
5339         * completer.c (complete): Likewise.
5340         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5341         function defined in completer.h.
5342
5343 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5344
5345         * MAINTAINERS (Write After Approval): Add myself.
5346
5347 2019-05-17  Tom de Vries  <tdevries@suse.de>
5348
5349         PR gdb/24094
5350         * dwarf2read.c (struct cu_partial_die_info): New struct.
5351         (find_partial_die): Return cu_partial_die_info.
5352         (partial_die_parent_scope, guess_partial_die_structure_name)
5353         (partial_die_info::fixup): Handle new return type of find_partial_die.
5354
5355 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5356
5357         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5358         "std::string", simplifying the algorithm.
5359
5360 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5361
5362         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5363         (stap_static_probe_ops::get_probes): Likewise.
5364
5365 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5366
5367         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5368         '-')" and "else if".
5369         (stap_parse_single_operand): Join checks for
5370         "gdbarch_stap_parse_special_token_p" and
5371         "gdbarch_stap_parse_special_token" in the same "if" statement.
5372         Invert check when verifying for operation on register
5373         displacement.
5374
5375 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5376
5377         * stap-probe.c (stap_get_opcode): Update comment.
5378         (stap_get_expected_argument_type): Likewise.
5379         (handle_stap_probe): Likewise.
5380
5381 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5382
5383         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5384         return type to 'bool'.  Adjust comment.  Use 'bool' when
5385         appropriate.
5386         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5387         * stap-probe.c (stap_parse_argument_1): Likewise.
5388         (stap_is_operator): Likewise.
5389         (stap_is_generic_prefix): Likewise.
5390         (stap_is_register_prefix): Likewise.
5391         (stap_is_register_indirection_prefix): Likewise.
5392         (stap_is_integer_prefix): Likewise.
5393         (stap_generic_check_suffix): Likewise.
5394         (stap_check_integer_suffix): Likewise.
5395         (stap_check_register_suffix): Likewise.
5396         (stap_check_register_indirection_suffix): Likewise.
5397         (stap_parse_register_operand): Likewise.
5398         (stap_parse_single_operand): Likewise.
5399         (stap_parse_argument_1): Likewise.
5400         (stap_probe::get_argument_count): Likewise.
5401         (stap_is_operator): Likewise.
5402
5403 2019-05-16  Tom Tromey  <tromey@adacore.com>
5404
5405         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5406         keyword to foreach.
5407
5408 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5409
5410         * linux-thread-db.c (try_thread_db_load_1): Change return type
5411         to bool.
5412         (try_thread_db_load): Likewise.
5413         (try_thread_db_load_from_pdir_1): Likewise.
5414         (try_thread_db_load_from_pdir): Likewise.
5415         (try_thread_db_load_from_sdir): Likewise.
5416         (try_thread_db_load_from_dir): Likewise.
5417         (thread_db_load_search): Likewise.
5418         (has_libpthread): Likewise.
5419         (thread_db_load): Likewise.
5420
5421 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5422
5423         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5424         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5425         NULL, and complain/return if that's the case.
5426
5427 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5428
5429         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5430         (advance, posn, abstract_read_memory): New functions.
5431         [struct mem_read_abstraction]: New struct.
5432         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5433
5434 2019-05-14  Tom Tromey  <tromey@adacore.com>
5435
5436         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5437         value is not lval_memory.
5438
5439 2019-05-14  Tom Tromey  <tromey@adacore.com>
5440
5441         * solib.c (info_sharedlibrary_command): Style the file name.
5442
5443 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5444
5445         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5446         (aarch64_vnv_type): Likewise.
5447         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5448         * common/tdesc.c: Likewise.
5449         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5450         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5451         * features/aarch64-fpu.xml: Add ieee half view.
5452         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5453         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5454         * gdbtypes.h (struct builtin_type): Likewise.
5455         (struct objfile_type): Likewise.
5456
5457 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5458
5459         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5460         typo.
5461         * location.h (string_to_event_location): Likewise.
5462
5463 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5464
5465         GDB 8.3 released.
5466
5467 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5468
5469         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5470         New variable declaration.
5471         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5472         New variable.
5473         (print_one_breakpoint): Use ui_out::test_flags and new global
5474         variable to compute use_fixed_output.
5475         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5476         Remove.
5477         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5478         (mi_multi_location_breakpoint_output_fixed): Remove.
5479         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5480         new variable.
5481         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5482         fix_multi_location_breakpoint_output flag if version >= 3.
5483         * ui-out.h (enum ui_out_flag)
5484         <fix_multi_location_breakpoint_output>: New enumerator.
5485
5486 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5487
5488         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5489
5490 2019-05-10  Tom Tromey  <tromey@adacore.com>
5491
5492         * ada-lang.c (catch_ada_completer): New function.
5493         (_initialize_ada_language): Use it.
5494
5495 2019-05-10  Tom Tromey  <tromey@adacore.com>
5496
5497         * thread.c (print_thread_info): Make "requested_threads" const.
5498         * gdbthread.h (print_thread_info): Make "requested_threads"
5499         const.
5500         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5501         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5502
5503 2019-05-08  Tom Tromey  <tom@tromey.com>
5504
5505         * gdbtypes.c (objfile_type_data): Change type.
5506         (objfile_type, _initialize_gdbtypes): Update.
5507
5508 2019-05-08  Tom Tromey  <tom@tromey.com>
5509
5510         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5511         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5512         (_initialize_dwarf2_frame): Update.
5513
5514 2019-05-08  Tom Tromey  <tom@tromey.com>
5515
5516         * objc-lang.c (objc_objfile_data): Change type.
5517         (find_methods): Update.
5518         (_initialize_objc_lang): Remove.
5519
5520 2019-05-08  Tom Tromey  <tom@tromey.com>
5521
5522         * stabsread.c (rs6000_builtin_type_data): Change type.
5523         (rs6000_builtin_type, _initialize_stabsread): Update.
5524
5525 2019-05-08  Tom Tromey  <tom@tromey.com>
5526
5527         * mips-tdep.c (mips_pdr_data): Remove.
5528         (_initialize_mips_tdep): Update.
5529
5530 2019-05-08  Tom Tromey  <tom@tromey.com>
5531
5532         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5533         (hppa_init_objfile_priv_data, read_unwind_info)
5534         (find_unwind_entry, _initialize_hppa_tdep): Update.
5535
5536 2019-05-08  Tom Tromey  <tom@tromey.com>
5537
5538         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5539         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5540         on obstack.
5541         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5542
5543 2019-05-08  Tom Tromey  <tom@tromey.com>
5544
5545         * mdebugread.c (basic_type_data): Change type.
5546         (basic_type, _initialize_mdebugread): Update.
5547
5548 2019-05-08  Tom Tromey  <tom@tromey.com>
5549
5550         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5551
5552 2019-05-08  Tom Tromey  <tom@tromey.com>
5553
5554         * nto-tdep.c (nto_inferior_data_reg): Change type.
5555         (nto_inferior_data): Update.
5556         (nto_inferior_data_cleanup, nto_new_inferior_data)
5557         (_initialize_nto_tdep): Remove.
5558         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5559
5560 2019-05-08  Tom Tromey  <tom@tromey.com>
5561
5562         * ada-lang.c (struct ada_inferior_data): Add initializers.
5563         (ada_inferior_data): Change type.
5564         (ada_inferior_data_cleanup): Remove.
5565         (get_ada_inferior_data, ada_inferior_exit)
5566         (struct ada_pspace_data): Add initializers, destructor.
5567         (ada_pspace_data_handle): Change type.
5568         (get_ada_pspace_data): Update.
5569         (ada_pspace_data_cleanup): Remove.
5570
5571 2019-05-08  Tom Tromey  <tom@tromey.com>
5572
5573         * coffread.c (struct coff_symfile_info): Add initializers.
5574         (coff_objfile_data_key): Move lower.  Change type.
5575         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5576         Update.
5577         (coff_free_info): Remove.
5578
5579 2019-05-08  Tom Tromey  <tom@tromey.com>
5580
5581         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5582         (fbsd_pspace_data_handle): Move lower.  Change type.
5583         (get_fbsd_pspace_data): Update.
5584         (fbsd_pspace_data_cleanup): Remove.
5585         (_initialize_fbsd_tdep): Update.
5586
5587 2019-05-08  Tom Tromey  <tom@tromey.com>
5588
5589         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5590         (get_ada_tasks_pspace_data): Update.
5591         (ada_tasks_pspace_data_cleanup): Remove.
5592         (_initialize_tasks): Update.
5593         (ada_tasks_inferior_data_handle): Change type.
5594         (get_ada_tasks_inferior_data): Update.
5595         (ada_tasks_inferior_data_cleanup): Remove.
5596         (struct ada_tasks_pspace_data): Add initializers.
5597
5598 2019-05-08  Tom Tromey  <tom@tromey.com>
5599
5600         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5601         * symfile-debug.c (debug_sym_get_probes): Change type.
5602         * stap-probe.c (handle_stap_probe):
5603         (stap_static_probe_ops::get_probes): Change type.
5604         * probe.h (class static_probe_ops) <get_probes>: Change type.
5605         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5606         (parse_probes_in_pspace): Update.
5607         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5608         Update.
5609         (any_static_probe_ops::get_probes): Change type.
5610         * elfread.c (elfread_data): New typedef.
5611         (probe_key): Change type.
5612         (elf_get_probes): Likewise.  Update.
5613         (probe_key_free): Remove.
5614         (_initialize_elfread): Update.
5615         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5616         Change type.
5617         (dtrace_process_dof_probe, dtrace_process_dof)
5618         (dtrace_static_probe_ops::get_probe): Change type.
5619
5620 2019-05-08  Tom Tromey  <tom@tromey.com>
5621
5622         * xcoffread.c (struct xcoff_symfile_info): Rename from
5623         coff_symfile_info.  Add initializers.
5624         (xcoff_objfile_data_key): Move lower.  Change type.
5625         (XCOFF_DATA): Rewrite.
5626         (xcoff_free_info): Remove.
5627         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5628         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5629         (xcoff_initial_scan): Update.
5630
5631 2019-05-08  Tom Tromey  <tom@tromey.com>
5632
5633         * solib-svr4.c (struct svr4_info): Add initializers and
5634         destructor.
5635         <probes_table>: Now an htab_up.
5636         (solib_svr4_pspace_data): Change type.
5637         (free_probes_table): Simplify.
5638         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5639         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5640         (probes_table_remove_objfile_probes, register_solib_event_probe)
5641         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5642         (_initialize_svr4_solib): Update.
5643
5644 2019-05-08  Tom Tromey  <tom@tromey.com>
5645
5646         * remote.c (remote_pspace_data): Change type.
5647         (remote_pspace_data_cleanup): Remove.
5648         (get_remote_exec_file, set_pspace_remote_exec_file)
5649         (_initialize_remote): Update.
5650
5651 2019-05-08  Tom Tromey  <tom@tromey.com>
5652
5653         * breakpoint.c (breakpoint_objfile_key): Change type.
5654         (get_breakpoint_objfile_data): Update.
5655         (free_breakpoint_objfile_data): Remove.
5656         (_initialize_breakpoint): Update.
5657
5658 2019-05-08  Tom Tromey  <tom@tromey.com>
5659
5660         * linux-tdep.c (struct linux_info): Add initializers.
5661         (linux_inferior_data): Move.  Change type.
5662         (invalidate_linux_cache_inf): Update.
5663         (linux_inferior_data_cleanup): Remove.
5664         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5665
5666 2019-05-08  Tom Tromey  <tom@tromey.com>
5667
5668         * auxv.c (auxv_inferior_data): Move.  Change type.
5669         (auxv_inferior_data_cleanup): Remove.
5670         (invalidate_auxv_cache_inf): Rewrite.
5671         (get_auxv_inferior_data, _initialize_auxv): Update.
5672
5673 2019-05-08  Tom Tromey  <tom@tromey.com>
5674
5675         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5676         (symfile_debug_objfile_data_key): Change type.
5677         (symfile_debug_installed, debug_qf_has_symbols)
5678         (debug_qf_find_last_source_symtab)
5679         (debug_qf_forget_cached_source_info)
5680         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5681         (debug_qf_print_stats, debug_qf_dump)
5682         (debug_qf_expand_symtabs_for_function)
5683         (debug_qf_expand_all_symtabs)
5684         (debug_qf_expand_symtabs_with_fullname)
5685         (debug_qf_map_matching_symbols)
5686         (debug_qf_expand_symtabs_matching)
5687         (debug_qf_find_pc_sect_compunit_symtab)
5688         (debug_qf_map_symbol_filenames)
5689         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5690         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5691         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5692         (debug_sym_read_linetable, debug_sym_relocate): Update.
5693         (symfile_debug_free_objfile): Remove.
5694         (install_symfile_debug_logging, _initialize_symfile_debug):
5695         Update.
5696
5697 2019-05-08  Tom Tromey  <tom@tromey.com>
5698
5699         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5700         allocate_on_obstack.
5701         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5702         (get_dwarf2_per_objfile): Update.
5703         (set_dwarf2_per_objfile): Remove.
5704         (dwarf2_has_info, dwarf2_get_section_info): Update.
5705         (dwarf2_free_objfile): Remove.
5706         (_initialize_dwarf2_read): Update.
5707
5708 2019-05-08  Tom Tromey  <tom@tromey.com>
5709
5710         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5711         initializers.
5712         <unsupported_script_warning_printed,
5713         script_not_found_warning_printed>: Now bool.
5714         (auto_load_pspace_data): Change type.
5715         (~auto_load_pspace_info): Rename from
5716         auto_load_pspace_data_cleanup.
5717         (get_auto_load_pspace_data, init_loaded_scripts_info)
5718         (clear_section_scripts, maybe_print_unsupported_script_warning)
5719         (maybe_print_script_not_found_warning, _initialize_auto_load):
5720         Update.
5721
5722 2019-05-08  Tom Tromey  <tom@tromey.com>
5723
5724         * objfiles.c (objfile_pspace_info): Add destructor and
5725         initializers.
5726         (objfiles_pspace_data): Change type.
5727         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5728         (get_objfile_pspace_data): Update.
5729         (objfiles_bfd_data): Change type.
5730         (get_objfile_bfd_data): Update.
5731         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5732
5733 2019-05-08  Tom Tromey  <tom@tromey.com>
5734
5735         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5736         Change type.
5737         (get_catch_syscall_inferior_data): Update.
5738         (catch_syscall_inferior_data_cleanup): Remove.
5739         (_initialize_break_catch_syscall): Update.
5740
5741 2019-05-08  Tom Tromey  <tom@tromey.com>
5742
5743         * inflow.c (struct terminal_info): Add destructor and
5744         initializers.
5745         (inflow_inferior_data): Change type.
5746         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5747         (get_inflow_inferior_data, inflow_inferior_exit)
5748         (swap_terminal_info, _initialize_inflow): Update.
5749
5750 2019-05-08  Tom Tromey  <tom@tromey.com>
5751
5752         * target-dcache.c (target_dcache_cleanup): Remove.
5753         (target_dcache_aspace_key): Change type.
5754         (target_dcache_init_p, target_dcache_invalidate)
5755         (target_dcache_get, target_dcache_get_or_init)
5756         (_initialize_target_dcache): Update.
5757         * dcache.h (struct dcache_deleter): New.
5758
5759 2019-05-08  Tom Tromey  <tom@tromey.com>
5760
5761         * symtab.c (struct symbol_cache): Add destructor and
5762         initializers.
5763         (symbol_cache_key): Move.  Change type.
5764         (make_symbol_cache, free_symbol_cache): Remove.
5765         (get_symbol_cache): Update.
5766         (symbol_cache_cleanup): Remove.
5767         (ALL_PSPACES, symbol_cache_flush)
5768         (maintenance_print_symbol_cache)
5769         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5770         Update.
5771
5772 2019-05-08  Tom Tromey  <tom@tromey.com>
5773
5774         * symtab.c (struct main_info): Add destructor and initializers.
5775         (main_progspace_key): Move.  Change type.
5776         (get_main_info): Update.
5777         (main_info_cleanup): Remove.
5778         (_initialize_symtab): Update.
5779
5780 2019-05-08  Tom Tromey  <tom@tromey.com>
5781
5782         * registry.h (DECLARE_REGISTRY): Define the _key class.
5783
5784 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5785
5786         * NEWS: Merge two 'New commands' sections.
5787
5788 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5789
5790         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5791         parameter and use Ada language definition instead.
5792         (ada_val_print_ptr): Remove unused language parameter.
5793         (ada_val_print_num): Remove language parameter and use Ada language
5794         definition instead.
5795         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5796         parameter.
5797         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5798         parameter and use Ada language definition instead.
5799         (ada_val_print_1): Update all ada_val_print_xxx calls.
5800         Remove language parameter.
5801         (ada_val_print): Update ada_val_print_1 call.
5802
5803 2019-05-08  Tom Tromey  <tromey@adacore.com>
5804
5805         * remote.c (remote_hw_watchpoint_limit)
5806         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5807         Now static.
5808
5809 2019-05-08  Tom Tromey  <tromey@adacore.com>
5810
5811         * maint.c (_initialize_maint_cmds): Move initialization code to
5812         remote.c.
5813         (watchdog, show_watchdog): Move to remote.c.
5814         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5815         "watchdog" static.
5816         (_initialize_remote): Move initialization code from maint.c.
5817         * defs.h (watchdog): Don't declare.
5818
5819 2019-05-08  Tom Tromey  <tromey@adacore.com>
5820
5821         * tui/tui-interp.c: Include main.h.
5822         * interps.c: Include main.h.
5823         * main.h (interpreter_p): Declare.
5824         * defs.h (interpreter_p): Don't declare.
5825
5826 2019-05-08  Tom Tromey  <tromey@adacore.com>
5827
5828         * dwarf2loc.c: Include dwarf2read.h.
5829         * defs.h (read_unsigned_leb128): Don't declare.
5830         * dwarf2read.h (read_unsigned_leb128): Declare.
5831
5832 2019-05-08  Tom Tromey  <tromey@adacore.com>
5833
5834         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5835         method.
5836
5837 2019-05-08  Tom Tromey  <tromey@adacore.com>
5838
5839         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5840         when no wrap column is set.
5841
5842 2019-05-08  Tom Tromey  <tromey@adacore.com>
5843
5844         * c-lang.c (c_get_string): Handle non-C-style arrays.
5845
5846 2019-05-08  Tom Tromey  <tromey@adacore.com>
5847
5848         * typeprint.c (print_offset_data::update): Print the bit offset,
5849         not the number of bits remaining.
5850
5851 2019-05-08  Tom Tromey  <tromey@adacore.com>
5852
5853         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5854         padding at end of comment.
5855
5856 2019-05-08  Tom Tromey  <tromey@adacore.com>
5857
5858         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5859         Compare main types.
5860
5861 2019-05-06  Tom Tromey  <tom@tromey.com>
5862
5863         * common/scoped_mmap.c: Include common-defs.h.
5864         * common/scoped_mmap.h: Don't include config.h.
5865
5866 2019-05-04  Tom Tromey  <tom@tromey.com>
5867
5868         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5869         (struct aarch64_call_info): Add initializers.
5870         <si>: Now a std::vector.
5871         (pass_on_stack, aarch64_push_dummy_call): Update.
5872
5873 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5874             Tom Tromey  <tom@tromey.com>
5875
5876         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5877         (ppc_threads): Now a std::vector.  Now static.
5878         (hwdebug_find_thread_points_by_tid)
5879         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5880         Update.
5881
5882 2019-05-04  Tom Tromey  <tom@tromey.com>
5883
5884         * arc-tdep.c (arc_tdesc_init): Return bool.
5885
5886 2019-05-04  Tom Tromey  <tom@tromey.com>
5887
5888         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5889         Use gdb_assert_not_reached.
5890
5891 2019-05-04  Tom Tromey  <tom@tromey.com>
5892
5893         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5894         "false".
5895
5896 2019-05-04  Tom Tromey  <tom@tromey.com>
5897
5898         * arc-tdep.c (arc_tdesc_init): Use bool.
5899
5900 2019-05-04  Tom Tromey  <tom@tromey.com>
5901
5902         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5903
5904 2019-05-04  Tom Tromey  <tom@tromey.com>
5905
5906         * cli/cli-cmds.c (valid_command_p): Return bool.
5907
5908 2019-05-04  Tom Tromey  <tom@tromey.com>
5909
5910         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5911         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5912
5913 2019-05-04  Raul Tambre  <raul@tambre.ee>
5914
5915         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5916         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5917         operator for comparison.
5918
5919 2019-05-04  Tom Tromey  <tom@tromey.com>
5920
5921         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5922         (lookup_partial_symbol, print_partial_symbols)
5923         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5924         (psymbol_compare): Update.
5925         (add_psymbol_to_bcache): Clear the entire psymbol.
5926         (maintenance_check_psymtabs): Update.
5927         * psympriv.h (struct partial_symbol): Don't derive from
5928         general_symbol_info.
5929         <obj_section, unrelocated_address, address,
5930         set_unrelocated_address>: Update.
5931         <ginfo>: New member.
5932         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5933         (debug_names::write_psymbols): Update.
5934
5935 2019-05-04  Tom de Vries  <tdevries@suse.de>
5936
5937         * contrib/cc-with-tweaks.sh: Support -n arg.
5938
5939 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5940
5941         * corelow.c (core_target::detach): Ensure frame cache and
5942         register caches are cleared.
5943         inferior.c (exit_inferior_1): Likewise.
5944
5945 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5946             Tom Tromey  <tom@tromey.com>
5947
5948         * dictionary.c (collate_pending_symbols_by_language): Remove
5949         "struct" from foreach.
5950         * symtab.c (lookup_global_symbol_from_objfile)
5951         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5952         foreach.
5953         * ser-tcp.c (net_open): Remove "struct" from foreach.
5954         * objfiles.c (objfile_relocate, objfile_rebase)
5955         (objfile_has_symbols): Remove "struct" from foreach.
5956         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5957         from foreach.
5958         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5959         foreach.
5960         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5961         "struct" from foreach.
5962         * ada-lang.c (create_excep_cond_exprs)
5963         (ada_exception_catchpoint_cond_string): Remove "struct" from
5964         foreach.
5965
5966 2019-05-03  Tom Tromey  <tromey@adacore.com>
5967
5968         * ada-exp.y (convert_char_literal): Check suffix of each
5969         enumerator.
5970
5971 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5972
5973         PR ada/21406:
5974         * ada-exp.y (yywrap): Don't define.
5975         * ada-lex.l (%option): Add noyywrap
5976         (yywrap): Remove.
5977
5978 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5979
5980         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5981         _WIN32_WINNT to the XP level, unless already defined to a higher
5982         level.
5983
5984         * unittests/parse-connection-spec-selftests.c:
5985         * ser-tcp.c:
5986         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5987         override.
5988
5989         * symfile.c (find_separate_debug_file): Remove colon from the
5990         drive spec of DOS/Windows file names of the target, so that the
5991         file name produced from DEBUGDIR and the target's directory will
5992         be valid on DOS/Windows systems.
5993
5994 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5995
5996         * rust-lang.c (val_print_struct): Handle printing structures
5997         containing strings.
5998
5999 2019-05-02  Tom Tromey  <tromey@adacore.com>
6000
6001         * valarith.c (_initialize_valarith): Remove.
6002
6003 2019-05-01  Tom Tromey  <tromey@adacore.com>
6004
6005         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6006         bitfields.
6007
6008 2019-05-01  Tom Tromey  <tromey@adacore.com>
6009
6010         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6011         for big-endian copies.
6012
6013 2019-04-30  Ali Tamur  <tamur@google.com>
6014         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6015         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6016         (read_3_bytes): New function.
6017
6018 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6019
6020         * windows-nat.c (main_thread_id): Delete.
6021         (handle_output_debug_string): Replace main_thread_id by
6022         current_event.dwThreadId.
6023         (fake_create_process): Likewise.
6024         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6025         Do not set main_thread_id.
6026         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6027         current_event.dwThreadId.
6028         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6029
6030 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6031
6032         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6033         Use current_event.dwThreadId instead of main_thread_id.
6034
6035 2019-04-30  Tom Tromey  <tromey@adacore.com>
6036
6037         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6038         (create_excep_cond_exprs): Iterate over program spaces.
6039         (ada_exception_catchpoint_cond_string): Examine all minimal
6040         symbols for exception types.
6041
6042 2019-04-30  Tom Tromey  <tromey@adacore.com>
6043
6044         PR c++/24470:
6045         * dwarf2read.c (process_structure_scope): Handle case where type
6046         has template parameters but no symbol was created.
6047
6048 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6049             Chris January  <chris.january@arm.com>
6050
6051         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6052         qualifier.
6053         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6054
6055 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6056
6057         * f-typeprint.c (f_print_type): Update rules for printing
6058         whitespace.
6059         (f_type_print_varspec_suffix): Likewise.
6060
6061 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6062             Chris January  <chris.january@arm.com>
6063
6064         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6065         function arguments.
6066
6067 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6068
6069         * f-lang.c (build_fortran_types): Change name of void type to
6070         lower case.
6071         * f-typeprint.c (f_type_print_base): Print the name of the void
6072         type, rather than a fixed string.
6073         * f-valprint.c (f_decorations): Use lower case void string.
6074
6075 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6076             Chris January  <chris.january@arm.com>
6077
6078         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6079         types for Fortran.
6080
6081 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6082             Chris January  <chris.january@arm.com>
6083             David Lecomber  <david.lecomber@arm.com>
6084
6085         * f-exp.y (BINOP_INTRINSIC): New token.
6086         (exp): New parser rule handling BINOP_INTRINSIC.
6087         (f77_keywords): Add new builtin procedures.
6088         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6089         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6090         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6091         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6092         (print_unop_subexp_f): New function.
6093         (print_binop_subexp_f): New function.
6094         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6095         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6096         (dump_subexp_body_f): Likewise.
6097         (operator_check_f): Likewise.
6098         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6099         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6100
6101 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6102
6103         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6104         UNOP_KIND.
6105         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6106         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6107         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6108         (operator_length_f): New fuction.
6109         (print_subexp_f): New function.
6110         (op_name_f): New function.
6111         (dump_subexp_body_f): New function.
6112         (operator_check_f): New function.
6113         (exp_descriptor_f): Replace standard expression handling functions
6114         with new functions.
6115         * gdb/fortran-operator.def: New file.
6116         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6117         * gdb/std-operator.def: Remove UNOP_KIND.
6118
6119 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6120
6121         * std-operator.def: Remove unbalanced, stray double quote
6122         character.
6123
6124 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6125             Chris January  <chris.january@arm.com>
6126             Daniel Everett  <daniel.everett@arm.com>
6127             Nick Forrington  <nick.forrington@arm.com>
6128             Richard Bunt  <richard.bunt@arm.com>
6129
6130         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6131         of depth when printing anonymous structs or unions.
6132         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6133         Don't print either the top-level value, or the children if the
6134         max-depth is exceeded.
6135         (ppscm_print_children): When printing the key of a map, allow one
6136         extra level of depth.
6137         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6138         print either the top-level value, or the children if the max-depth
6139         is exceeded.
6140         (print_children): When printing the key of a map, allow one extra
6141         level of depth.
6142         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6143         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6144         (user_print_options): Initialise max_depth field.
6145         (val_print_scalar_or_string_type_p): New function.
6146         (val_print): Check to see if the max depth has been reached.
6147         (val_print_check_max_depth): Define new function.
6148         (show_print_max_depth): New function.
6149         (_initialize_valprint): Add 'print max-depth' option.
6150         * valprint.h (struct value_print_options) <max_depth>: New field.
6151         (val_print_check_max_depth): Declare new function.
6152         * NEWS: Document new feature.
6153
6154 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6155
6156         * ada-lang.c (ada_language_defn): Initialise new field.
6157         * c-lang.c (c_is_string_type_p): New function.
6158         (c_language_defn): Initialise new field.
6159         (cplus_language_defn): Initialise new field.
6160         (asm_language_defn): Initialise new field.
6161         (minimal_language_defn): Initialise new field.
6162         * c-lang.h (c_is_string_type_p): Declare new function.
6163         * d-lang.c (d_language_defn): Initialise new field.
6164         * f-lang.c (f_is_string_type_p): New function.
6165         (f_language_defn): Initialise new field.
6166         * go-lang.c (go_is_string_type_p): New function.
6167         (go_language_defn): Initialise new field.
6168         * language.c (default_is_string_type_p): New function.
6169         (unknown_language_defn): Initialise new field.
6170         (auto_language_defn): Initialise new field.
6171         * language.h (struct language_defn) <la_is_string_type_p>: New
6172         member variable.
6173         (default_is_string_type_p): Declare new function.
6174         * m2-lang.c (m2_language_defn): Initialise new field.
6175         * objc-lang.c (objc_language_defn): Initialise new field.
6176         * opencl-lang.c (opencl_language_defn): Initialise new field.
6177         * p-lang.c (pascal_is_string_type_p): New function.
6178         (pascal_language_defn): Initialise new field.
6179         * rust-lang.c (rust_is_string_type_p): New function.
6180         (rust_language_defn): Initialise new field.
6181
6182 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6183
6184         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6185         New field.
6186         * ada-lang.c (ada_language_defn): Initialise new field.
6187         * c-lang.c (c_language_defn): Likewise.
6188         (cplus_language_defn): Likewise.
6189         (asm_language_defn): Likewise.
6190         (minimal_language_defn): Likewise.
6191         * d-lang.c (d_language_defn): Likewise.
6192         * f-lang.c (f_language_defn): Likewise.
6193         * go-lang.c (go_language_defn): Likewise.
6194         * language.c (unknown_language_defn): Likewise.
6195         (auto_language_defn): Likewise.
6196         * m2-lang.c (m2_language_defn): Likewise.
6197         * objc-lang.c (objc_language_defn): Likewise.
6198         * opencl-lang.c (opencl_language_defn): Likewise.
6199         * p-lang.c (pascal_language_defn): Likewise.
6200         * rust-lang.c (rust_language_defn): Likewise.
6201
6202 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6203
6204         * ada-lang.c (ada_is_character_type): Change return type to bool.
6205         (ada_is_string_type): Likewise.
6206         * ada-lang.h (ada_is_character_type): Update declaration
6207         (ada_is_string_type): Likewise.
6208
6209 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6210
6211         Support style in 'frame|thread apply'
6212
6213         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6214         * record.c (record_start, record_stop): Update callers of
6215         execute_command_to_string with false.
6216         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6217         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6218         methods.
6219         (class string_file): New constructor with term_out parameter.
6220         Override methods term_out and can_emit_style_escape.  New member
6221         term_out.
6222         (class stdio_file): Override can_emit_style_escape.
6223         (class tee_file): Override term_out and can_emit_style_escape.
6224         * utils.h (can_emit_style_escape): Remove.
6225         * utils.c (can_emit_style_escape): Likewise.
6226         Update all callers of can_emit_style_escape (SOMESTREAM) to
6227         SOMESTREAM->can_emit_style_escape.
6228         * source-cache.c (source_cache::get_source_lines): Likewise.
6229         * stack.c (frame_apply_command_count): Call execute_command_to_string
6230         passing the term_out characteristic of the current gdb_stdout.
6231         * thread.c (thr_try_catch_cmd): Likewise.
6232         * top.c (execute_command_to_string): pass term_out parameter
6233         to construct the string_file for the command output.
6234         * ui-file.c (term_cli_styling): New function (most code moved
6235         from utils.c can_emit_style_escape).
6236         (string_file::string_file, string_file::can_emit_style_escape,
6237         stdio_file::can_emit_style_escape, tee_file::term_out,
6238         tee_file::can_emit_style_escape): New functions.
6239
6240 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6241
6242         * NEWS: Mention the new set|show may-call-functions.
6243         * infcall.c (may_call_functions_p): New variable.
6244         (show_may_call_functions_p): New function.
6245         (call_function_by_hand_dummy): Throws an error if not
6246         may-call-functions.
6247         (_initialize_infcall): Call add_setshow_boolean_cmd for
6248         may-call-functions.
6249
6250 2019-04-25  Keith Seitz  <keiths@redhat.com>
6251
6252         PR c++/24367
6253         * cp-support.c (inspect_type): Don't attempt substitutions
6254         of symbol with the same name.
6255
6256 2019-04-25  Tom Tromey  <tromey@adacore.com>
6257
6258         PR gdb/24475:
6259         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6260         static.
6261
6262 2019-04-25  Tom Tromey  <tromey@adacore.com>
6263
6264         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6265         rvalue reference.
6266         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6267         (gdb_xml_parser::parse): Use std::move.
6268         * python/python-internal.h (gdbpy_convert_exception): Take a const
6269         reference.
6270         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6271         std::move.
6272         * python/py-utils.c (gdbpy_convert_exception): Take a const
6273         reference.
6274         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6275         Use std::move.
6276         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6277         Use std::move.
6278         * mi/mi-main.c (mi_print_exception): Take a const reference.
6279         * main.c (handle_command_errors): Take a const reference.
6280         * linespec.c (parse_linespec): Use std::move.
6281         * infcall.c (run_inferior_call): Use std::move.
6282         (call_function_by_hand_dummy): Use std::move.
6283         * exec.c (try_open_exec_file): Use std::move.
6284         * exceptions.h (exception_print, exception_fprintf)
6285         (exception_print_same): Update.
6286         * exceptions.c (print_exception, exception_print)
6287         (exception_fprintf, exception_print_same): Change parameters to
6288         const reference.
6289         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6290         * common/new-op.c: Use std::move.
6291         * common/common-exceptions.h (struct gdb_exception): Add move
6292         constructor.
6293         (struct gdb_exception_error, struct gdb_exception_quit, struct
6294         gdb_quit_bad_alloc): Change constructor to move constructor.
6295         (throw_exception): Change parameter to rvalue reference.
6296         * common/common-exceptions.c (throw_exception): Take rvalue
6297         reference.
6298         * cli/cli-interp.c (safe_execute_command): Use std::move.
6299         * breakpoint.c (insert_bp_location, location_to_sals): Use
6300         std::move.
6301
6302 2019-04-25  Tom Tromey  <tromey@adacore.com>
6303
6304         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6305         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6306         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6307         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6308         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6309         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6310         guile/scm-value.c: Use unpack.
6311         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6312         gdbscm_gdb_exception.
6313         (gdbscm_throw_gdb_exception): Likewise.
6314         (struct gdbscm_gdb_exception): New.
6315         (unpack): New function.
6316         (gdbscm_wrap): Use unpack.
6317
6318 2019-04-25  Tom Tromey  <tromey@adacore.com>
6319
6320         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6321         (gdb_rl_callback_handler): Use std::move.
6322         * common/common-exceptions.h (struct gdb_exception): Add move
6323         assignment operator.
6324         (throw_exception_sjlj): Change "exception" to const reference.
6325         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6326         (throw_exception_sjlj): Change "exception" to const reference.
6327
6328 2019-04-25  Tom Tromey  <tromey@adacore.com>
6329
6330         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6331         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6332         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6333         Update.
6334         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6335         Update.
6336         * mi/mi-interp.c (mi_interp::exec): Update.
6337         * linespec.c (parse_linespec): Update.
6338         * infcall.c (run_inferior_call): Update.
6339         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6340         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6341         (gdbscm_lookup_global_symbol): Update.
6342         * guile/scm-param.c (gdbscm_parameter_value): Update.
6343         * guile/scm-frame.c (gdbscm_frame_read_register)
6344         (gdbscm_frame_read_var): Update.
6345         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6346         * exec.c (try_open_exec_file): Update.
6347         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6348         (gdb_rl_callback_handler): Update.
6349         * common/common-exceptions.h (exception_none): Don't declare.
6350         * common/common-exceptions.c (exception_none): Don't define.
6351         (struct catcher) <exception>: Update.
6352         * cli/cli-interp.c (safe_execute_command): Update.
6353         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6354
6355 2019-04-25  Ali Tamur  <tamur@google.com>
6356
6357         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6358         (read_attribute_value): Likewise.
6359         (dwarf2_read_addr_index): Update comment.
6360         (read_str_index): Add DW_FORM_strx.
6361         (dwarf2_string_attr): Likewise.
6362         (dwarf2_const_value_attr): Likewise.
6363         (dump_die_shallow): Likewise.
6364         (dwarf2_fetch_constant_bytes): Likewise.
6365         (skip_form_bytes): Likewise.
6366         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6367
6368 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6369
6370         PR corefiles/11608
6371         PR corefiles/18187
6372         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6373         OFFSET.  Verify if current mapping contains an ELF header.
6374         (linux_find_memory_regions_full): Adjust call to
6375         dump_mapping_p.
6376
6377 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6378             Kang Li <kanglictf@gmail.com>
6379
6380         PR gdb/21600
6381
6382         * dwarf2-frame.c (read_initial_length): Be consistent about using
6383         unsigned representation of length.
6384         (decode_frame_entry_1): Likewise.  Check for wraparound of
6385         end pointer as well as buffer overflow.
6386
6387 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6388
6389         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6390         "vq".
6391
6392 2019-04-24  Tom Tromey  <tromey@adacore.com>
6393
6394         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6395
6396 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6397
6398         * s12z-tdep.c (s12z_unwind_pc): Delete.
6399         (s12z_unwind_sp): Delete.
6400         (s12z_gdbarch_init): Don't register deleted functions with
6401         gdbarch.
6402
6403 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6404
6405         * rl78-tdep.c (rl78_unwind_sp): Delete.
6406         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6407
6408 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6409
6410         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6411         (xstormy16_unwind_pc): Delete.
6412         (xstormy16_dummy_id): Delete.
6413         (xstormy16_gdbarch_init): Don't register deleted functions with
6414         gdbarch.
6415
6416 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6417
6418         * vax-tdep.c (vax_unwind_pc): Delete.
6419         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6420
6421 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6422
6423         * v850-tdep.c (v850_unwind_sp): Delete.
6424         (v850_unwind_pc): Delete.
6425         (v850_dummy_id): Delete.
6426         (v850_gdbarch_init): Don't register deleted functions with
6427         gdbarch.
6428
6429 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6430
6431         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6432         (tilegx_unwind_pc): Delete.
6433         (tilegx_unwind_dummy_id): Delete.
6434         (tilegx_gdbarch_init): Don't register deleted functions with
6435         gdbarch.
6436
6437 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6438
6439         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6440         (tic6x_dummy_id): Delete.
6441         (tic6x_gdbarch_init): Don't register deleted functions with
6442         gdbarch.
6443
6444 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6445
6446         * sparc-tdep.c (sparc_unwind_pc): Delete.
6447         (sparc32_gdbarch_init): Don't register deleted function with
6448         gdbarch.
6449
6450 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6451
6452         * sh-tdep.c (sh_unwind_sp): Delete.
6453         (sh_unwind_pc): Delete.
6454         (sh_dummy_id): Delete.
6455         (sh_gdbarch_init): Don't register deleted functions with
6456         gdbarch.
6457
6458 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6459
6460         * score-tdep.c (score_unwind_sp): Delete.
6461         (score_unwind_pc): Delete.
6462         (score_dummy_id): Delete.
6463         (score_gdbarch_init): Don't register deleted functions with
6464         gdbarch.
6465
6466 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6467
6468         * rx-tdep.c (rx_unwind_pc): Delete.
6469         (rx_unwind_sp): Delete.
6470         (rx_dummy_id): Delete.
6471         (rx_gdbarch_init): Don't register deleted functions with
6472         gdbarch.  Update comment.
6473
6474 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6475
6476         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6477         (rs6000_dummy_id): Delete.
6478         (rs6000_gdbarch_init): Don't register deleted functions with
6479         gdbarch.
6480
6481 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6482
6483         * or1k-tdep.c (or1k_dummy_id): Delete.
6484         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6485
6486 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6487
6488         * nios2-tdep.c (nios2_dummy_id): Delete.
6489         (nios2_unwind_sp): Delete.
6490         (nios2_gdbarch_init): Don't register deleted functions with
6491         gdbarch.
6492
6493 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6494
6495         * nds32-tdep.c (nds32_dummy_id): Delete.
6496         (nds32_unwind_pc): Delete.
6497         (nds32_unwind_sp): Delete.
6498         (nds32_gdbarch_init): Don't register deleted functions with
6499         gdbarch.
6500
6501 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6502
6503         * msp430-tdep.c (msp430_unwind_pc): Delete.
6504         (msp430_unwind_sp): Delete.
6505         (msp430_dummy_id): Delete.
6506         (msp430_gdbarch_init): Don't register deleted functions with
6507         gdbarch.
6508
6509 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6510
6511         * moxie-tdep.c (moxie_unwind_sp): Delete.
6512         (moxie_unwind_pc): Delete.
6513         (moxie_dummy_id): Delete.
6514         (moxie_gdbarch_init): Don't register deleted functions with
6515         gdbarch.
6516
6517 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6518
6519         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6520         (mn10300_unwind_pc): Delete.
6521         (mn10300_unwind_sp): Delete.
6522         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6523         mn10300_unwind_sp.
6524         (mn10300_frame_unwind_init): Don't register deleted functions with
6525         gdbarch.
6526
6527 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6528
6529         * mep-tdep.c (mep_unwind_pc): Delete.
6530         (mep_unwind_sp): Delete.
6531         (mep_dummy_id): Delete.
6532         (mep_gdbarch_init): Don't register deleted functions with
6533         gdbarch.
6534
6535 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6536
6537         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6538         (m68hc11_unwind_sp): Delete.
6539         (m68hc11_gdbarch_init): Don't register deleted functions with
6540         gdbarch.
6541
6542 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6543
6544         * m32r-tdep.c (m32r_unwind_sp): Delete.
6545         (m32r_unwind_pc): Delete.
6546         (m32r_dummy_id): Delete.
6547         (m32r_gdbarch_init): Don't register deleted functions with
6548         gdbarch.
6549
6550 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6551
6552         * m32c-tdep.c (m32c_unwind_pc): Delete.
6553         (m32c_unwind_sp): Delete.
6554         (m32c_dummy_id): Delete.
6555         (m32c_gdbarch_init): Don't register deleted functions with
6556         gdbarch.
6557
6558 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6559
6560         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6561         (lm32_unwind_pc): Delete.
6562         (lm32_dummy_id): Delete.
6563         (lm32_gdbarch_init): Don't register deleted functions with
6564         gdbarch.
6565
6566 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6567
6568         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6569         (iq2000_unwind_pc): Delete.
6570         (iq2000_dummy_id): Delete.
6571         (iq2000_gdbarch_init): Don't register deleted functions with
6572         gdbarch.
6573
6574 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6575
6576         * nds32-tdep.c (nds32_type_align): Delete.
6577         (nds32_push_dummy_call): Use type_align instead.
6578
6579 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6580
6581         * arm-tdep.c (arm_type_align): Only handle vector override case.
6582         (arm_push_dummy_call): Use type_align.
6583         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6584
6585 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6586
6587         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6588         case.
6589         (pass_on_stack): Use type_align.
6590         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6591         function.
6592
6593 2019-04-23  Tom Tromey  <tromey@adacore.com>
6594
6595         * dwarf2read.c (line_header::file_name_at): Remove unused
6596         overload.
6597
6598 2019-04-23  Tom de Vries  <tdevries@suse.de>
6599
6600         PR gdb/24438
6601         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6602         invocation.
6603
6604
6605 2019-03-27  Ali Tamur  <tamur@google.com>
6606
6607         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6608         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6609         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6610         (dwarf_expr_context::get_addr_index): Likewise
6611         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6612         (symbol_needs_eval_context::get_addr_index): Likewise
6613         (disassemble_dwarf_expression): Add DW_OP_addrx
6614         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6615         (read_cutu_die_from_dwo): Update comment
6616         (skip_one_die): Add DW_FORM_addrx
6617         (read_attribute_value): Likewise
6618         (var_decode_location): Add DW_OP_addrx
6619         (dwarf2_const_value_attr): Add DW_FORM_addrx
6620         (dump_die_shallow): Likewise
6621         (dwarf2_fetch_constant_bytes): Likewise
6622         (decode_locdesc): Add DW_OP_addrx
6623         (skip_form_bytes): Add DW_FORM_addrx
6624
6625 2019-04-22  Ali Tamur  <tamur@google.com>
6626
6627         * MAINTAINERS (Write After Approval): Add self.
6628
6629 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6630
6631         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6632         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6633         (open_symbol_file_object): Likewise.
6634         (svr4_default_sos): Add info parameter.
6635         (svr4_read_so_list): Likewise.
6636         (svr4_current_sos_direct): Adjust functions calls to pass down
6637         info.
6638         (svr4_current_sos_1): Add info parameter.
6639         (svr4_current_sos): Call get_svr4_info, pass info down to
6640         svr4_current_sos_1.
6641         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6642         get_svr4_info.
6643         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6644         get_svr4_info.
6645         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6646         to get_svr4_info.
6647         (probes_table_remove_objfile_probes): Likewise.
6648         (register_solib_event_probe): Add info parameter.
6649         (solist_update_incremental): Pass info parameter down to
6650         svr4_read_so_list.
6651         (disable_probes_interface): Add info parameter.
6652         (svr4_handle_solib_event): Pass current_program_space to
6653         get_svr4_info.  Adjust disable_probes_interface cleanup.
6654         (svr4_create_probe_breakpoints): Add info parameter, pass it
6655         down to register_solib_event_probe.
6656         (svr4_create_solib_event_breakpoints): Add info parameter,
6657         pass it down to svr4_create_probe_breakpoints.
6658         (enable_break): Pass info down to
6659         svr4_create_solib_event_breakpoints.
6660         (svr4_solib_create_inferior_hook): Pass current_program_space to
6661         get_svr4_info.
6662         (svr4_clear_solib): Likewise.
6663
6664 2019-04-22  Pedro Alves  <palves@redhat.com>
6665
6666         * solib-svr4.c (svr4_free_objfile_observer): New.
6667         (probe_and_action::objfile): New field.
6668         (probes_table_htab_remove_objfile_probes)
6669         (probes_table_remove_objfile_probes): New functions.
6670         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6671         in the new probe_and_action.  Don't store the probe in 'lookup'.
6672         (svr4_create_probe_breakpoints): Pass objfile to
6673         register_solib_event_probe.
6674         (_initialize_svr4_solib): Register a free_objfile observer.
6675
6676 2019-04-19  Tom Tromey  <tom@tromey.com>
6677
6678         * common/queue.h: Remove.
6679
6680 2019-04-19  Tom Tromey  <tom@tromey.com>
6681
6682         * event-loop.c: Don't include "common/queue.h".
6683
6684 2019-04-19  Tom Tromey  <tom@tromey.com>
6685
6686         * remote.c (remote_target): Use delete.
6687         * remote-notif.h: Include <list>, not "common/queue.h".
6688         (notif_client_p): Remove typedef.
6689         (remote_notif_state): Add constructor, destructor, initializer.
6690         <notif_queue>: Now a std::list.
6691         (remote_notif_state_xfree): Don't declare.
6692         * remote-notif.c (remote_notif_process, handle_notification)
6693         (remote_notif_state_allocate): Update.
6694         (~remote_notif_state): Rename from remote_notif_state_xfree.
6695
6696 2019-04-19  Tom Tromey  <tom@tromey.com>
6697
6698         * symfile.c (reread_symbols): Update.
6699         * objfiles.c (objfile_register_static_link)
6700         (objfile_lookup_static_link): Update
6701         (~objfile) Don't delete static_links.
6702         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6703
6704 2019-04-19  Tom Tromey  <tom@tromey.com>
6705
6706         * type-stack.h (struct type_stack) <insert>: Constify string.
6707         * type-stack.c (type_stack::insert): Constify string.
6708         * gdbtypes.h (lookup_template_type): Update.
6709         (address_space_name_to_int): Update.
6710         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6711         const.
6712         (lookup_template_type): Make name const.
6713         * c-exp.y: Update rules.
6714         (lex_one_token, classify_name, classify_inner_name)
6715         (c_print_token): Update.
6716         * p-exp.y: Update rules.
6717         (yylex): Update.
6718         * f-exp.y: Update rules.
6719         (yylex): Update.
6720         * d-exp.y: Update rules.
6721         (lex_one_token, classify_name, classify_inner_name): Update.
6722         * parse.c (write_dollar_variable, copy_name): Return std::string.
6723         * parser-defs.h (copy_name): Change return type.
6724         * m2-exp.y: Update rules.
6725         (yylex): Update.
6726         * go-exp.y (lex_one_token): Update.
6727         Update rules.
6728         (classify_unsafe_function, classify_packaged_name)
6729         (classify_name, yylex): Update.
6730
6731 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6732
6733         * configure.ac: add --enable-source-highlight switch.
6734         * configure: Regenerate.
6735         * top.c (print_gdb_version): plumb --enable-source-highlight
6736         status to "show configuration".
6737
6738 2019-04-19  Tom Tromey  <tromey@adacore.com>
6739
6740         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6741         Check ADA_TYPE_P.
6742         (empty_record, ada_template_to_fixed_record_type_1)
6743         (template_to_static_fixed_type)
6744         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6745         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6746         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6747         macros.
6748
6749 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6750
6751         PR symtab/24423:
6752         * source.c (print_source_lines_base): Advance "iter" when a
6753         control character is seen.
6754
6755 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6756
6757         * inferior.h (struct infcall_suspend_state_deleter):
6758         Catch exception in destructor to avoid crash.
6759
6760 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6761
6762         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6763         close to the add_com "shell".
6764
6765 2019-04-18  Tom Tromey  <tromey@adacore.com>
6766
6767         * process-stratum-target.h (class process_stratum_target)
6768         <stratum>: Add "final".
6769
6770 2019-04-17  Tom Tromey  <tromey@adacore.com>
6771
6772         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6773         against nullptr before use.
6774
6775 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6776
6777         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6778
6779 2019-04-17  Jim Wilson  <jimw@sifive.com>
6780             Andrew Burgess  <andrew.burgess@embecosm.com>
6781
6782         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6783         code read might fail, assume 4-byte breakpoint in that case.
6784
6785 2019-04-15  Leszek Swirski  <leszeks@google.com>
6786
6787         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6788         rather than a hand-rolled POD check when checking for forced MEMORY
6789         classification.
6790
6791 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6792
6793         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6794         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6795         function.
6796         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6797         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6798         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6799         declaration.
6800
6801 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6802
6803         * aarch64-linux-nat.c
6804         (aarch64_linux_nat_target::thread_architecture): Add override.
6805         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6806         each VQ.
6807
6808 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6809
6810         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6811
6812 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6813
6814         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6815         target types of size 96-bits, add some additional comments, and
6816         check that the builtin type we found was the correct size.
6817
6818 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6819
6820         * utils.c (prompt_for_continue): Don't restore the styling at the
6821         end, as applied_style has the wrong value.  This fixes styling in
6822         long lists of file names that are interrupted by the "Continue?"
6823         prompt.
6824
6825 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6826
6827         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6828         * c-lang.c (c_language_defn): Likewise.
6829         (cplus_language_defn): Likewise.
6830         (asm_language_defn): Likewise.
6831         (minimal_language_defn): Likewise.
6832         * d-lang.c (d_language_defn): Likewise.
6833         * f-lang.c (f_language_defn): Likewise.
6834         * go-lang.c (go_language_defn): Likewise.
6835         * language.c (unknown_language_defn): Likewise.
6836         (auto_language_defn): Likewise.
6837         * language.h (struct language_defn): Remove la_magic field.
6838         (LANG_MAGIC): Delete.
6839         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6840         * objc-lang.c (objc_language_defn): Likewise.
6841         * opencl-lang.c (opencl_language_defn): Likewise.
6842         * p-lang.c (pascal_language_defn): Likewise.
6843         * rust-lang.c (rust_language_defn): Likewise.
6844
6845 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6846
6847         * riscv-tdep.c (riscv_type_align): New function.
6848         (riscv_type_alignment): Delete.
6849         (riscv_arg_location): Use 'type_align'.
6850         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6851
6852 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6853
6854         * gdbtypes.c (type_align): A struct with no non-static fields also
6855         has alignment of 1.
6856
6857 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6858
6859         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6860         component to 0.
6861         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6862         member.
6863         (riscv_struct_info::analyse): New implementation using new
6864         analyse_inner member function.
6865         (riscv_struct_info::field_offset): New member function.
6866         (riscv_struct_info::m_offsets): New member variable.
6867         (riscv_struct_info::analyse_inner): New private member function,
6868         takes the old implementation of riscv_struct_info::analyse but
6869         extended to track field offsets.
6870         (riscv_call_arg_struct): Update the struct folding special cases
6871         to handle cases where empty C++ structs, which are non-zero
6872         length, are found.
6873         (riscv_arg_location): Initialise the length of each location, a
6874         non-zero length now indicates the location is in use.
6875         (riscv_push_dummy_call): Allow for the first location having a
6876         non-zero offset when setting up arguments.
6877         (riscv_return_value): Likewise, but for return values.
6878
6879 2019-04-11  Tom Tromey  <tromey@adacore.com>
6880
6881         * utils.c (internal_vproblem): Make "msg" const.
6882
6883 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6884
6885         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6886         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6887         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6888         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6889
6890 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6891
6892         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6893         function.
6894         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6895         of amd64_collect_native_gregset.
6896         (amd64_linux_nat_target::store_registers): Likewise.
6897
6898 2019-04-10  Tom Tromey  <tom@tromey.com>
6899
6900         * symtab.c (lookup_global_symbol_from_objfile)
6901         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6902         * objfiles.h (class separate_debug_iterator): New.
6903         (class separate_debug_range): New.
6904         (struct objfile) <separate_debug_objfiles>: New method.
6905         (objfile_separate_debug_iterate): Don't declare.
6906         * objfiles.c (separate_debug_iterator::operator++): Rename from
6907         objfile_separate_debug_iterate.
6908         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6909         iterator.
6910         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6911         iterator.
6912
6913 2019-04-10  Tom Tromey  <tom@tromey.com>
6914
6915         * symfile.c (reread_symbols): Remove old comment.
6916         * objfiles.c (free_all_objfiles): Fix a typo.
6917
6918 2019-04-10  Tom Tromey  <tom@tromey.com>
6919
6920         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6921         * minsyms.c (lookup_minimal_symbol): Use foreach.
6922         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6923         (lookup_minimal_symbol_solib_trampoline): Likewise.
6924         * symfile.c (reread_symbols): Use foreach.
6925
6926 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6927             Tom Tromey  <tromey@adacore.com>
6928
6929         PR rust/24414:
6930         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6931         (rust_lex_int_test): Change "value" to be LONGEST.
6932         (rust_lex_tests): Add test for long integer literal.
6933
6934 2019-04-09  Tom Tromey  <tromey@adacore.com>
6935
6936         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6937         to bool.
6938         (extended_remote_target::attach): Update.
6939         (remote_target::remote_notice_new_inferior): Update.
6940         (remote_target::add_current_inferior_and_thread): Update.
6941         * inferior.c (exit_inferior_1): Use "false".
6942         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6943
6944 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6945
6946         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6947         the "start" command.
6948
6949 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6950
6951         * python/py-inferior.c (infpy_thread_from_thread_handle):
6952         Adjust comments to reflect renaming of thread_from_thread_handle
6953         to thread_from_handle.  Adjust keywords.  Fix type error message.
6954         (inferior_object_methods): Add thread_from_handle.  Retain
6955         thread_from_thread_handle, but mark it as deprecated.
6956
6957 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6958
6959         * gdbthread.h (find_thread_by_handle): Revise declaration.
6960         * thread.c (find_thread_by_handle): Likewise.  Adjust
6961         implementation too.
6962         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6963         support for buffer objects as handles.
6964
6965 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6966
6967         * python/py-infthread.c (thpy_thread_handle): New function.
6968         (thread_object_methods): Register thpy_thread_handle.
6969
6970 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6971
6972         * gdbthread.h (thread_to_thread_handle): Declare.
6973         * thread.c (gdbtypes.h): Include.
6974         (thread_to_thread_handle): New function.
6975
6976         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6977         (target_thread_info_to_thread_handle): Declare.
6978         * target.c (target_thread_info_to_thread_handle): New function.
6979         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6980         * target-delegates.c: Regenerate.
6981
6982         * linux-thread-db.c (class thread_db_target): Add method
6983         thread_info_to_thread_handle.
6984         (thread_db_target::thread_info_to_thread_handle): Define.
6985         * remote.c (class remote_target): Add new method
6986         thread_info_to_thread_handle.
6987         (remote_target::thread_info_to_thread_handle): Define.
6988
6989 2019-04-08  Pedro Alves  <palves@redhat.com>
6990
6991         * common/common-exceptions.c (throw_exception): Don't create
6992         named object to throw; throw directly.
6993         (throw_it): Likewise.  Don't initialize gdb_exception::message
6994         here, with new; pass FMT and AP to the ctor instead.
6995         * common/common-exceptions.h: Include <string>.
6996         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6997         const char *, va_list)): New ctor.  Use std::make_shared.
6998         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6999         errors)): Delete.
7000         (gdb_exception_error::gdb_exception_error(enum errors, const char
7001         *, va_list)): New.
7002         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7003         Add assertion.
7004         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7005         errors)): Delete.
7006         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7007         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7008         Add assertion.
7009
7010 2019-04-08  Tom Tromey  <tom@tromey.com>
7011
7012         * valops.c (value_rtti_indirect_type): Replace throw_exception
7013         with throw.
7014         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7015         with throw.
7016         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7017         throw.
7018         * target.c (target_translate_tls_address): Replace throw_exception
7019         with throw.
7020         * stack.c (frame_apply_command_count): Replace throw_exception
7021         with throw.
7022         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7023         throw.
7024         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7025         with throw.
7026         * rs6000-tdep.c (rs6000_frame_cache)
7027         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7028         * remote.c: Replace throw_exception with throw.
7029         * record-full.c (record_full_message, record_full_wait_1)
7030         (record_full_restore): Replace throw_exception with throw.
7031         * record-btrace.c:
7032         (get_thread_current_frame_id, record_btrace_start_replaying)
7033         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7034         (cmd_record_btrace_start): Replace throw_exception with throw.
7035         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7036         throw.
7037         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7038         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7039         * linespec.c:
7040         (find_linespec_symbols): Replace throw_exception with throw.
7041         * infrun.c (displaced_step_prepare, resume): Replace
7042         throw_exception with throw.
7043         * infcmd.c (post_create_inferior): Replace throw_exception with
7044         throw.
7045         * inf-loop.c (inferior_event_handler): Replace throw_exception
7046         with throw.
7047         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7048         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7049         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7050         (get_prev_frame_always, get_frame_pc_if_available)
7051         (get_frame_address_in_block_if_available, get_frame_language):
7052         Replace throw_exception with throw.
7053         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7054         throw_exception with throw.
7055         * eval.c (fetch_subexp_value, evaluate_var_value)
7056         (evaluate_funcall, evaluate_subexp_standard): Replace
7057         throw_exception with throw.
7058         * dwarf2loc.c (call_site_find_chain)
7059         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7060         Replace throw_exception with throw.
7061         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7062         with throw.
7063         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7064         throw.
7065         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7066         * completer.c (complete_line_internal): Replace throw_exception
7067         with throw.
7068         * compile/compile-object-run.c (compile_object_run): Replace
7069         throw_exception with throw.
7070         * cli/cli-script.c (process_next_line): Replace throw_exception
7071         with throw.
7072         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7073         (btrace_enable, btrace_maint_update_pt_packets): Replace
7074         throw_exception with throw.
7075         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7076         throw_exception with throw.
7077         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7078         throw_exception with throw.
7079         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7080         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7081         * aarch64-tdep.c (aarch64_make_prologue_cache)
7082         (aarch64_make_stub_cache): Replace throw_exception with throw.
7083
7084 2019-04-08  Tom Tromey  <tom@tromey.com>
7085
7086         * common/common-exceptions.c (throw_exception): Rename from
7087         throw_exception_cxx.  Remove old copy.  Make argument const.
7088         (throw_it): Create and throw exception objects directly.
7089         * common/common-exceptions.h (throw_exception): Make argument
7090         const.
7091         (struct gdb_exception_error): Add constructor.
7092         (struct gdb_exception_quit): Add constructor.
7093
7094 2019-04-08  Tom Tromey  <tom@tromey.com>
7095
7096         * common/common-exceptions.h (exception_rethrow): Don't declare.
7097         (TRY_SJLJ): Update comment.
7098         (TRY, CATCH, END_CATCH): Remove.
7099         * common/common-exceptions.c (exception_rethrow): Remove.
7100
7101 2019-04-08  Tom Tromey  <tom@tromey.com>
7102
7103         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7104         Remove.
7105         (gdb_exception_error): Rename from
7106         gdb_exception_RETURN_MASK_ERROR.
7107         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7108         (gdb_quit_bad_alloc): Update.
7109         * aarch64-tdep.c: Update.
7110         * ada-lang.c: Update.
7111         * ada-typeprint.c: Update.
7112         * ada-valprint.c: Update.
7113         * amd64-tdep.c: Update.
7114         * arch-utils.c: Update.
7115         * break-catch-throw.c: Update.
7116         * breakpoint.c: Update.
7117         * btrace.c: Update.
7118         * c-varobj.c: Update.
7119         * cli/cli-cmds.c: Update.
7120         * cli/cli-interp.c: Update.
7121         * cli/cli-script.c: Update.
7122         * common/common-exceptions.c: Update.
7123         * common/new-op.c: Update.
7124         * common/selftest.c: Update.
7125         * compile/compile-c-symbols.c: Update.
7126         * compile/compile-cplus-symbols.c: Update.
7127         * compile/compile-object-load.c: Update.
7128         * compile/compile-object-run.c: Update.
7129         * completer.c: Update.
7130         * corelow.c: Update.
7131         * cp-abi.c: Update.
7132         * cp-support.c: Update.
7133         * cp-valprint.c: Update.
7134         * darwin-nat.c: Update.
7135         * disasm-selftests.c: Update.
7136         * dtrace-probe.c: Update.
7137         * dwarf-index-cache.c: Update.
7138         * dwarf-index-write.c: Update.
7139         * dwarf2-frame-tailcall.c: Update.
7140         * dwarf2-frame.c: Update.
7141         * dwarf2loc.c: Update.
7142         * dwarf2read.c: Update.
7143         * eval.c: Update.
7144         * event-loop.c: Update.
7145         * event-top.c: Update.
7146         * exec.c: Update.
7147         * f-valprint.c: Update.
7148         * fbsd-tdep.c: Update.
7149         * frame-unwind.c: Update.
7150         * frame.c: Update.
7151         * gdbtypes.c: Update.
7152         * gnu-v3-abi.c: Update.
7153         * guile/guile-internal.h: Update.
7154         * guile/scm-block.c: Update.
7155         * guile/scm-breakpoint.c: Update.
7156         * guile/scm-cmd.c: Update.
7157         * guile/scm-disasm.c: Update.
7158         * guile/scm-frame.c: Update.
7159         * guile/scm-lazy-string.c: Update.
7160         * guile/scm-math.c: Update.
7161         * guile/scm-param.c: Update.
7162         * guile/scm-ports.c: Update.
7163         * guile/scm-pretty-print.c: Update.
7164         * guile/scm-symbol.c: Update.
7165         * guile/scm-symtab.c: Update.
7166         * guile/scm-type.c: Update.
7167         * guile/scm-value.c: Update.
7168         * i386-linux-tdep.c: Update.
7169         * i386-tdep.c: Update.
7170         * inf-loop.c: Update.
7171         * infcall.c: Update.
7172         * infcmd.c: Update.
7173         * infrun.c: Update.
7174         * jit.c: Update.
7175         * language.c: Update.
7176         * linespec.c: Update.
7177         * linux-fork.c: Update.
7178         * linux-nat.c: Update.
7179         * linux-tdep.c: Update.
7180         * linux-thread-db.c: Update.
7181         * main.c: Update.
7182         * mi/mi-cmd-break.c: Update.
7183         * mi/mi-cmd-stack.c: Update.
7184         * mi/mi-interp.c: Update.
7185         * mi/mi-main.c: Update.
7186         * objc-lang.c: Update.
7187         * p-valprint.c: Update.
7188         * parse.c: Update.
7189         * ppc-linux-tdep.c: Update.
7190         * printcmd.c: Update.
7191         * python/py-arch.c: Update.
7192         * python/py-breakpoint.c: Update.
7193         * python/py-cmd.c: Update.
7194         * python/py-finishbreakpoint.c: Update.
7195         * python/py-frame.c: Update.
7196         * python/py-framefilter.c: Update.
7197         * python/py-gdb-readline.c: Update.
7198         * python/py-inferior.c: Update.
7199         * python/py-infthread.c: Update.
7200         * python/py-lazy-string.c: Update.
7201         * python/py-linetable.c: Update.
7202         * python/py-objfile.c: Update.
7203         * python/py-param.c: Update.
7204         * python/py-prettyprint.c: Update.
7205         * python/py-progspace.c: Update.
7206         * python/py-record-btrace.c: Update.
7207         * python/py-record.c: Update.
7208         * python/py-symbol.c: Update.
7209         * python/py-type.c: Update.
7210         * python/py-unwind.c: Update.
7211         * python/py-utils.c: Update.
7212         * python/py-value.c: Update.
7213         * python/python.c: Update.
7214         * record-btrace.c: Update.
7215         * record-full.c: Update.
7216         * remote-fileio.c: Update.
7217         * remote.c: Update.
7218         * riscv-tdep.c: Update.
7219         * rs6000-aix-tdep.c: Update.
7220         * rs6000-tdep.c: Update.
7221         * rust-exp.y: Update.
7222         * rust-lang.c: Update.
7223         * s390-tdep.c: Update.
7224         * selftest-arch.c: Update.
7225         * solib-dsbt.c: Update.
7226         * solib-frv.c: Update.
7227         * solib-spu.c: Update.
7228         * solib-svr4.c: Update.
7229         * solib.c: Update.
7230         * sparc64-linux-tdep.c: Update.
7231         * stack.c: Update.
7232         * symfile-mem.c: Update.
7233         * symmisc.c: Update.
7234         * target.c: Update.
7235         * thread.c: Update.
7236         * top.c: Update.
7237         * tracefile-tfile.c: Update.
7238         * tui/tui.c: Update.
7239         * typeprint.c: Update.
7240         * unittests/cli-utils-selftests.c: Update.
7241         * unittests/parse-connection-spec-selftests.c: Update.
7242         * valops.c: Update.
7243         * valprint.c: Update.
7244         * value.c: Update.
7245         * varobj.c: Update.
7246         * windows-nat.c: Update.
7247         * x86-linux-nat.c: Update.
7248         * xml-support.c: Update.
7249
7250 2019-04-08  Tom Tromey  <tom@tromey.com>
7251
7252         * xml-support.c: Use C++ exception handling.
7253         * x86-linux-nat.c: Use C++ exception handling.
7254         * windows-nat.c: Use C++ exception handling.
7255         * varobj.c: Use C++ exception handling.
7256         * value.c: Use C++ exception handling.
7257         * valprint.c: Use C++ exception handling.
7258         * valops.c: Use C++ exception handling.
7259         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7260         handling.
7261         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7262         * typeprint.c: Use C++ exception handling.
7263         * tui/tui.c: Use C++ exception handling.
7264         * tracefile-tfile.c: Use C++ exception handling.
7265         * top.c: Use C++ exception handling.
7266         * thread.c: Use C++ exception handling.
7267         * target.c: Use C++ exception handling.
7268         * symmisc.c: Use C++ exception handling.
7269         * symfile-mem.c: Use C++ exception handling.
7270         * stack.c: Use C++ exception handling.
7271         * sparc64-linux-tdep.c: Use C++ exception handling.
7272         * solib.c: Use C++ exception handling.
7273         * solib-svr4.c: Use C++ exception handling.
7274         * solib-spu.c: Use C++ exception handling.
7275         * solib-frv.c: Use C++ exception handling.
7276         * solib-dsbt.c: Use C++ exception handling.
7277         * selftest-arch.c: Use C++ exception handling.
7278         * s390-tdep.c: Use C++ exception handling.
7279         * rust-lang.c: Use C++ exception handling.
7280         * rust-exp.y: Use C++ exception handling.
7281         * rs6000-tdep.c: Use C++ exception handling.
7282         * rs6000-aix-tdep.c: Use C++ exception handling.
7283         * riscv-tdep.c: Use C++ exception handling.
7284         * remote.c: Use C++ exception handling.
7285         * remote-fileio.c: Use C++ exception handling.
7286         * record-full.c: Use C++ exception handling.
7287         * record-btrace.c: Use C++ exception handling.
7288         * python/python.c: Use C++ exception handling.
7289         * python/py-value.c: Use C++ exception handling.
7290         * python/py-utils.c: Use C++ exception handling.
7291         * python/py-unwind.c: Use C++ exception handling.
7292         * python/py-type.c: Use C++ exception handling.
7293         * python/py-symbol.c: Use C++ exception handling.
7294         * python/py-record.c: Use C++ exception handling.
7295         * python/py-record-btrace.c: Use C++ exception handling.
7296         * python/py-progspace.c: Use C++ exception handling.
7297         * python/py-prettyprint.c: Use C++ exception handling.
7298         * python/py-param.c: Use C++ exception handling.
7299         * python/py-objfile.c: Use C++ exception handling.
7300         * python/py-linetable.c: Use C++ exception handling.
7301         * python/py-lazy-string.c: Use C++ exception handling.
7302         * python/py-infthread.c: Use C++ exception handling.
7303         * python/py-inferior.c: Use C++ exception handling.
7304         * python/py-gdb-readline.c: Use C++ exception handling.
7305         * python/py-framefilter.c: Use C++ exception handling.
7306         * python/py-frame.c: Use C++ exception handling.
7307         * python/py-finishbreakpoint.c: Use C++ exception handling.
7308         * python/py-cmd.c: Use C++ exception handling.
7309         * python/py-breakpoint.c: Use C++ exception handling.
7310         * python/py-arch.c: Use C++ exception handling.
7311         * printcmd.c: Use C++ exception handling.
7312         * ppc-linux-tdep.c: Use C++ exception handling.
7313         * parse.c: Use C++ exception handling.
7314         * p-valprint.c: Use C++ exception handling.
7315         * objc-lang.c: Use C++ exception handling.
7316         * mi/mi-main.c: Use C++ exception handling.
7317         * mi/mi-interp.c: Use C++ exception handling.
7318         * mi/mi-cmd-stack.c: Use C++ exception handling.
7319         * mi/mi-cmd-break.c: Use C++ exception handling.
7320         * main.c: Use C++ exception handling.
7321         * linux-thread-db.c: Use C++ exception handling.
7322         * linux-tdep.c: Use C++ exception handling.
7323         * linux-nat.c: Use C++ exception handling.
7324         * linux-fork.c: Use C++ exception handling.
7325         * linespec.c: Use C++ exception handling.
7326         * language.c: Use C++ exception handling.
7327         * jit.c: Use C++ exception handling.
7328         * infrun.c: Use C++ exception handling.
7329         * infcmd.c: Use C++ exception handling.
7330         * infcall.c: Use C++ exception handling.
7331         * inf-loop.c: Use C++ exception handling.
7332         * i386-tdep.c: Use C++ exception handling.
7333         * i386-linux-tdep.c: Use C++ exception handling.
7334         * guile/scm-value.c: Use C++ exception handling.
7335         * guile/scm-type.c: Use C++ exception handling.
7336         * guile/scm-symtab.c: Use C++ exception handling.
7337         * guile/scm-symbol.c: Use C++ exception handling.
7338         * guile/scm-pretty-print.c: Use C++ exception handling.
7339         * guile/scm-ports.c: Use C++ exception handling.
7340         * guile/scm-param.c: Use C++ exception handling.
7341         * guile/scm-math.c: Use C++ exception handling.
7342         * guile/scm-lazy-string.c: Use C++ exception handling.
7343         * guile/scm-frame.c: Use C++ exception handling.
7344         * guile/scm-disasm.c: Use C++ exception handling.
7345         * guile/scm-cmd.c: Use C++ exception handling.
7346         * guile/scm-breakpoint.c: Use C++ exception handling.
7347         * guile/scm-block.c: Use C++ exception handling.
7348         * guile/guile-internal.h: Use C++ exception handling.
7349         * gnu-v3-abi.c: Use C++ exception handling.
7350         * gdbtypes.c: Use C++ exception handling.
7351         * frame.c: Use C++ exception handling.
7352         * frame-unwind.c: Use C++ exception handling.
7353         * fbsd-tdep.c: Use C++ exception handling.
7354         * f-valprint.c: Use C++ exception handling.
7355         * exec.c: Use C++ exception handling.
7356         * event-top.c: Use C++ exception handling.
7357         * event-loop.c: Use C++ exception handling.
7358         * eval.c: Use C++ exception handling.
7359         * dwarf2read.c: Use C++ exception handling.
7360         * dwarf2loc.c: Use C++ exception handling.
7361         * dwarf2-frame.c: Use C++ exception handling.
7362         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7363         * dwarf-index-write.c: Use C++ exception handling.
7364         * dwarf-index-cache.c: Use C++ exception handling.
7365         * dtrace-probe.c: Use C++ exception handling.
7366         * disasm-selftests.c: Use C++ exception handling.
7367         * darwin-nat.c: Use C++ exception handling.
7368         * cp-valprint.c: Use C++ exception handling.
7369         * cp-support.c: Use C++ exception handling.
7370         * cp-abi.c: Use C++ exception handling.
7371         * corelow.c: Use C++ exception handling.
7372         * completer.c: Use C++ exception handling.
7373         * compile/compile-object-run.c: Use C++ exception handling.
7374         * compile/compile-object-load.c: Use C++ exception handling.
7375         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7376         * compile/compile-c-symbols.c: Use C++ exception handling.
7377         * common/selftest.c: Use C++ exception handling.
7378         * common/new-op.c: Use C++ exception handling.
7379         * cli/cli-script.c: Use C++ exception handling.
7380         * cli/cli-interp.c: Use C++ exception handling.
7381         * cli/cli-cmds.c: Use C++ exception handling.
7382         * c-varobj.c: Use C++ exception handling.
7383         * btrace.c: Use C++ exception handling.
7384         * breakpoint.c: Use C++ exception handling.
7385         * break-catch-throw.c: Use C++ exception handling.
7386         * arch-utils.c: Use C++ exception handling.
7387         * amd64-tdep.c: Use C++ exception handling.
7388         * ada-valprint.c: Use C++ exception handling.
7389         * ada-typeprint.c: Use C++ exception handling.
7390         * ada-lang.c: Use C++ exception handling.
7391         * aarch64-tdep.c: Use C++ exception handling.
7392
7393 2019-04-08  Tom Tromey  <tom@tromey.com>
7394
7395         * xml-support.c (gdb_xml_parser::parse): Update.
7396         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7397         * value.c (show_convenience): Update.
7398         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7399         (test_parse_flags_qcs): Update.
7400         * thread.c (thr_try_catch_cmd): Update.
7401         * target.c (target_translate_tls_address): Update.
7402         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7403         (info_frame_command_core, frame_apply_command_count): Update.
7404         * rust-exp.y (rust_lex_exception_test): Update.
7405         * riscv-tdep.c (riscv_print_one_register_info): Update.
7406         * remote.c (remote_target::enable_btrace): Update.
7407         * record-btrace.c (record_btrace_enable_warn): Update.
7408         * python/py-utils.c (gdbpy_convert_exception): Update.
7409         * printcmd.c (do_one_display, print_variable_and_value): Update.
7410         * mi/mi-main.c (mi_print_exception): Update.
7411         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7412         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7413         * linux-nat.c (linux_nat_target::attach): Update.
7414         * linux-fork.c (class scoped_switch_fork_info): Update.
7415         * infrun.c (displaced_step_prepare): Update.
7416         * infcall.c (call_function_by_hand_dummy): Update.
7417         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7418         * gnu-v3-abi.c (print_one_vtable): Update.
7419         * frame.c (get_prev_frame_always): Update.
7420         * f-valprint.c (info_common_command_for_block): Update.
7421         * exec.c (try_open_exec_file): Update.
7422         * exceptions.c (print_exception, exception_print)
7423         (exception_fprintf, exception_print_same): Update.
7424         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7425         * dwarf-index-cache.c (index_cache::store)
7426         (index_cache::lookup_gdb_index): Update.
7427         * darwin-nat.c (maybe_cache_shell): Update.
7428         * cp-valprint.c (cp_print_value_fields): Update.
7429         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7430         (gcc_cplus_symbol_address): Update.
7431         * compile/compile-c-symbols.c (gcc_convert_symbol)
7432         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7433         * common/selftest.c: Update.
7434         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7435         a std::string.
7436         (exception_try_scope_entry, exception_try_scope_exit): Don't
7437         declare.
7438         (struct exception_try_scope): Remove.
7439         (TRY): Don't use exception_try_scope.
7440         (struct gdb_exception): Add constructor, operator=.
7441         <what>: New method.
7442         (struct gdb_exception_RETURN_MASK_ALL)
7443         (struct gdb_exception_RETURN_MASK_ERROR)
7444         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7445         (struct gdb_quit_bad_alloc): Update.
7446         * common/common-exceptions.c (exception_none): Change
7447         initializer.
7448         (struct catcher) <state, exception>: Initialize inline.
7449         <prev>: Remove member.
7450         (current_catcher): Remove.
7451         (catchers): New global.
7452         (exceptions_state_mc_init): Simplify.
7453         (catcher_pop): Remove.
7454         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7455         (try_scope_depth, exception_try_scope_entry)
7456         (exception_try_scope_exit): Remove.
7457         (throw_exception_sjlj): Update.
7458         (exception_messages, exception_messages_size): Remove.
7459         (throw_it): Simplify.
7460         (gdb_exception_sliced_copy): Remove.
7461         (throw_exception_cxx): Update.
7462         * cli/cli-script.c (script_from_file): Update.
7463         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7464         Update.
7465         * ada-valprint.c (ada_val_print): Update.
7466         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7467         (create_excep_cond_exprs): Update.
7468
7469 2019-04-08  Tom Tromey  <tom@tromey.com>
7470
7471         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7472         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7473         (TRY, CATCH, END_CATCH): Remove some definitions.
7474         * common/common-exceptions.c: Don't use GDB_XCPT.
7475         (catcher_list_size): Remove.
7476         (throw_exception, throw_it): Simplify.
7477
7478 2019-04-05  Tom Tromey  <tom@tromey.com>
7479
7480         Revert the header-sorting patch.
7481         * ft32-tdep.c: Revert.
7482         * frv-tdep.c: Revert.
7483         * frv-linux-tdep.c: Revert.
7484         * frame.c: Revert.
7485         * frame-unwind.c: Revert.
7486         * frame-base.c: Revert.
7487         * fork-child.c: Revert.
7488         * findvar.c: Revert.
7489         * findcmd.c: Revert.
7490         * filesystem.c: Revert.
7491         * filename-seen-cache.h: Revert.
7492         * filename-seen-cache.c: Revert.
7493         * fbsd-tdep.c: Revert.
7494         * fbsd-nat.h: Revert.
7495         * fbsd-nat.c: Revert.
7496         * f-valprint.c: Revert.
7497         * f-typeprint.c: Revert.
7498         * f-lang.c: Revert.
7499         * extension.h: Revert.
7500         * extension.c: Revert.
7501         * extension-priv.h: Revert.
7502         * expprint.c: Revert.
7503         * exec.h: Revert.
7504         * exec.c: Revert.
7505         * exceptions.c: Revert.
7506         * event-top.c: Revert.
7507         * event-loop.c: Revert.
7508         * eval.c: Revert.
7509         * elfread.c: Revert.
7510         * dwarf2read.h: Revert.
7511         * dwarf2read.c: Revert.
7512         * dwarf2loc.c: Revert.
7513         * dwarf2expr.h: Revert.
7514         * dwarf2expr.c: Revert.
7515         * dwarf2-frame.c: Revert.
7516         * dwarf2-frame-tailcall.c: Revert.
7517         * dwarf-index-write.h: Revert.
7518         * dwarf-index-write.c: Revert.
7519         * dwarf-index-common.c: Revert.
7520         * dwarf-index-cache.h: Revert.
7521         * dwarf-index-cache.c: Revert.
7522         * dummy-frame.c: Revert.
7523         * dtrace-probe.c: Revert.
7524         * disasm.h: Revert.
7525         * disasm.c: Revert.
7526         * disasm-selftests.c: Revert.
7527         * dictionary.c: Revert.
7528         * dicos-tdep.c: Revert.
7529         * demangle.c: Revert.
7530         * dcache.h: Revert.
7531         * dcache.c: Revert.
7532         * darwin-nat.h: Revert.
7533         * darwin-nat.c: Revert.
7534         * darwin-nat-info.c: Revert.
7535         * d-valprint.c: Revert.
7536         * d-namespace.c: Revert.
7537         * d-lang.c: Revert.
7538         * ctf.c: Revert.
7539         * csky-tdep.c: Revert.
7540         * csky-linux-tdep.c: Revert.
7541         * cris-tdep.c: Revert.
7542         * cris-linux-tdep.c: Revert.
7543         * cp-valprint.c: Revert.
7544         * cp-support.c: Revert.
7545         * cp-namespace.c: Revert.
7546         * cp-abi.c: Revert.
7547         * corelow.c: Revert.
7548         * corefile.c: Revert.
7549         * continuations.c: Revert.
7550         * completer.h: Revert.
7551         * completer.c: Revert.
7552         * complaints.c: Revert.
7553         * coffread.c: Revert.
7554         * coff-pe-read.c: Revert.
7555         * cli-out.h: Revert.
7556         * cli-out.c: Revert.
7557         * charset.c: Revert.
7558         * c-varobj.c: Revert.
7559         * c-valprint.c: Revert.
7560         * c-typeprint.c: Revert.
7561         * c-lang.c: Revert.
7562         * buildsym.c: Revert.
7563         * buildsym-legacy.c: Revert.
7564         * build-id.h: Revert.
7565         * build-id.c: Revert.
7566         * btrace.c: Revert.
7567         * bsd-uthread.c: Revert.
7568         * breakpoint.h: Revert.
7569         * breakpoint.c: Revert.
7570         * break-catch-throw.c: Revert.
7571         * break-catch-syscall.c: Revert.
7572         * break-catch-sig.c: Revert.
7573         * blockframe.c: Revert.
7574         * block.c: Revert.
7575         * bfin-tdep.c: Revert.
7576         * bfin-linux-tdep.c: Revert.
7577         * bfd-target.c: Revert.
7578         * bcache.c: Revert.
7579         * ax-general.c: Revert.
7580         * ax-gdb.h: Revert.
7581         * ax-gdb.c: Revert.
7582         * avr-tdep.c: Revert.
7583         * auxv.c: Revert.
7584         * auto-load.c: Revert.
7585         * arm-wince-tdep.c: Revert.
7586         * arm-tdep.c: Revert.
7587         * arm-symbian-tdep.c: Revert.
7588         * arm-pikeos-tdep.c: Revert.
7589         * arm-obsd-tdep.c: Revert.
7590         * arm-nbsd-tdep.c: Revert.
7591         * arm-nbsd-nat.c: Revert.
7592         * arm-linux-tdep.c: Revert.
7593         * arm-linux-nat.c: Revert.
7594         * arm-fbsd-tdep.c: Revert.
7595         * arm-fbsd-nat.c: Revert.
7596         * arm-bsd-tdep.c: Revert.
7597         * arch-utils.c: Revert.
7598         * arc-tdep.c: Revert.
7599         * arc-newlib-tdep.c: Revert.
7600         * annotate.h: Revert.
7601         * annotate.c: Revert.
7602         * amd64-windows-tdep.c: Revert.
7603         * amd64-windows-nat.c: Revert.
7604         * amd64-tdep.c: Revert.
7605         * amd64-sol2-tdep.c: Revert.
7606         * amd64-obsd-tdep.c: Revert.
7607         * amd64-obsd-nat.c: Revert.
7608         * amd64-nbsd-tdep.c: Revert.
7609         * amd64-nbsd-nat.c: Revert.
7610         * amd64-nat.c: Revert.
7611         * amd64-linux-tdep.c: Revert.
7612         * amd64-linux-nat.c: Revert.
7613         * amd64-fbsd-tdep.c: Revert.
7614         * amd64-fbsd-nat.c: Revert.
7615         * amd64-dicos-tdep.c: Revert.
7616         * amd64-darwin-tdep.c: Revert.
7617         * amd64-bsd-nat.c: Revert.
7618         * alpha-tdep.c: Revert.
7619         * alpha-obsd-tdep.c: Revert.
7620         * alpha-nbsd-tdep.c: Revert.
7621         * alpha-mdebug-tdep.c: Revert.
7622         * alpha-linux-tdep.c: Revert.
7623         * alpha-linux-nat.c: Revert.
7624         * alpha-bsd-tdep.c: Revert.
7625         * alpha-bsd-nat.c: Revert.
7626         * aix-thread.c: Revert.
7627         * agent.c: Revert.
7628         * addrmap.c: Revert.
7629         * ada-varobj.c: Revert.
7630         * ada-valprint.c: Revert.
7631         * ada-typeprint.c: Revert.
7632         * ada-tasks.c: Revert.
7633         * ada-lang.c: Revert.
7634         * aarch64-tdep.c: Revert.
7635         * aarch64-ravenscar-thread.c: Revert.
7636         * aarch64-newlib-tdep.c: Revert.
7637         * aarch64-linux-tdep.c: Revert.
7638         * aarch64-linux-nat.c: Revert.
7639         * aarch64-fbsd-tdep.c: Revert.
7640         * aarch64-fbsd-nat.c: Revert.
7641         * aarch32-linux-nat.c: Revert.
7642
7643 2019-04-05  Tom Tromey  <tom@tromey.com>
7644
7645         * ft32-tdep.c: Sort headers.
7646         * frv-tdep.c: Sort headers.
7647         * frv-linux-tdep.c: Sort headers.
7648         * frame.c: Sort headers.
7649         * frame-unwind.c: Sort headers.
7650         * frame-base.c: Sort headers.
7651         * fork-child.c: Sort headers.
7652         * findvar.c: Sort headers.
7653         * findcmd.c: Sort headers.
7654         * filesystem.c: Sort headers.
7655         * filename-seen-cache.h: Sort headers.
7656         * filename-seen-cache.c: Sort headers.
7657         * fbsd-tdep.c: Sort headers.
7658         * fbsd-nat.h: Sort headers.
7659         * fbsd-nat.c: Sort headers.
7660         * f-valprint.c: Sort headers.
7661         * f-typeprint.c: Sort headers.
7662         * f-lang.c: Sort headers.
7663         * extension.h: Sort headers.
7664         * extension.c: Sort headers.
7665         * extension-priv.h: Sort headers.
7666         * expprint.c: Sort headers.
7667         * exec.h: Sort headers.
7668         * exec.c: Sort headers.
7669         * exceptions.c: Sort headers.
7670         * event-top.c: Sort headers.
7671         * event-loop.c: Sort headers.
7672         * eval.c: Sort headers.
7673         * elfread.c: Sort headers.
7674         * dwarf2read.h: Sort headers.
7675         * dwarf2read.c: Sort headers.
7676         * dwarf2loc.c: Sort headers.
7677         * dwarf2expr.h: Sort headers.
7678         * dwarf2expr.c: Sort headers.
7679         * dwarf2-frame.c: Sort headers.
7680         * dwarf2-frame-tailcall.c: Sort headers.
7681         * dwarf-index-write.h: Sort headers.
7682         * dwarf-index-write.c: Sort headers.
7683         * dwarf-index-common.c: Sort headers.
7684         * dwarf-index-cache.h: Sort headers.
7685         * dwarf-index-cache.c: Sort headers.
7686         * dummy-frame.c: Sort headers.
7687         * dtrace-probe.c: Sort headers.
7688         * disasm.h: Sort headers.
7689         * disasm.c: Sort headers.
7690         * disasm-selftests.c: Sort headers.
7691         * dictionary.c: Sort headers.
7692         * dicos-tdep.c: Sort headers.
7693         * demangle.c: Sort headers.
7694         * dcache.h: Sort headers.
7695         * dcache.c: Sort headers.
7696         * darwin-nat.h: Sort headers.
7697         * darwin-nat.c: Sort headers.
7698         * darwin-nat-info.c: Sort headers.
7699         * d-valprint.c: Sort headers.
7700         * d-namespace.c: Sort headers.
7701         * d-lang.c: Sort headers.
7702         * ctf.c: Sort headers.
7703         * csky-tdep.c: Sort headers.
7704         * csky-linux-tdep.c: Sort headers.
7705         * cris-tdep.c: Sort headers.
7706         * cris-linux-tdep.c: Sort headers.
7707         * cp-valprint.c: Sort headers.
7708         * cp-support.c: Sort headers.
7709         * cp-namespace.c: Sort headers.
7710         * cp-abi.c: Sort headers.
7711         * corelow.c: Sort headers.
7712         * corefile.c: Sort headers.
7713         * continuations.c: Sort headers.
7714         * completer.h: Sort headers.
7715         * completer.c: Sort headers.
7716         * complaints.c: Sort headers.
7717         * coffread.c: Sort headers.
7718         * coff-pe-read.c: Sort headers.
7719         * cli-out.h: Sort headers.
7720         * cli-out.c: Sort headers.
7721         * charset.c: Sort headers.
7722         * c-varobj.c: Sort headers.
7723         * c-valprint.c: Sort headers.
7724         * c-typeprint.c: Sort headers.
7725         * c-lang.c: Sort headers.
7726         * buildsym.c: Sort headers.
7727         * buildsym-legacy.c: Sort headers.
7728         * build-id.h: Sort headers.
7729         * build-id.c: Sort headers.
7730         * btrace.c: Sort headers.
7731         * bsd-uthread.c: Sort headers.
7732         * breakpoint.h: Sort headers.
7733         * breakpoint.c: Sort headers.
7734         * break-catch-throw.c: Sort headers.
7735         * break-catch-syscall.c: Sort headers.
7736         * break-catch-sig.c: Sort headers.
7737         * blockframe.c: Sort headers.
7738         * block.c: Sort headers.
7739         * bfin-tdep.c: Sort headers.
7740         * bfin-linux-tdep.c: Sort headers.
7741         * bfd-target.c: Sort headers.
7742         * bcache.c: Sort headers.
7743         * ax-general.c: Sort headers.
7744         * ax-gdb.h: Sort headers.
7745         * ax-gdb.c: Sort headers.
7746         * avr-tdep.c: Sort headers.
7747         * auxv.c: Sort headers.
7748         * auto-load.c: Sort headers.
7749         * arm-wince-tdep.c: Sort headers.
7750         * arm-tdep.c: Sort headers.
7751         * arm-symbian-tdep.c: Sort headers.
7752         * arm-pikeos-tdep.c: Sort headers.
7753         * arm-obsd-tdep.c: Sort headers.
7754         * arm-nbsd-tdep.c: Sort headers.
7755         * arm-nbsd-nat.c: Sort headers.
7756         * arm-linux-tdep.c: Sort headers.
7757         * arm-linux-nat.c: Sort headers.
7758         * arm-fbsd-tdep.c: Sort headers.
7759         * arm-fbsd-nat.c: Sort headers.
7760         * arm-bsd-tdep.c: Sort headers.
7761         * arch-utils.c: Sort headers.
7762         * arc-tdep.c: Sort headers.
7763         * arc-newlib-tdep.c: Sort headers.
7764         * annotate.h: Sort headers.
7765         * annotate.c: Sort headers.
7766         * amd64-windows-tdep.c: Sort headers.
7767         * amd64-windows-nat.c: Sort headers.
7768         * amd64-tdep.c: Sort headers.
7769         * amd64-sol2-tdep.c: Sort headers.
7770         * amd64-obsd-tdep.c: Sort headers.
7771         * amd64-obsd-nat.c: Sort headers.
7772         * amd64-nbsd-tdep.c: Sort headers.
7773         * amd64-nbsd-nat.c: Sort headers.
7774         * amd64-nat.c: Sort headers.
7775         * amd64-linux-tdep.c: Sort headers.
7776         * amd64-linux-nat.c: Sort headers.
7777         * amd64-fbsd-tdep.c: Sort headers.
7778         * amd64-fbsd-nat.c: Sort headers.
7779         * amd64-dicos-tdep.c: Sort headers.
7780         * amd64-darwin-tdep.c: Sort headers.
7781         * amd64-bsd-nat.c: Sort headers.
7782         * alpha-tdep.c: Sort headers.
7783         * alpha-obsd-tdep.c: Sort headers.
7784         * alpha-nbsd-tdep.c: Sort headers.
7785         * alpha-mdebug-tdep.c: Sort headers.
7786         * alpha-linux-tdep.c: Sort headers.
7787         * alpha-linux-nat.c: Sort headers.
7788         * alpha-bsd-tdep.c: Sort headers.
7789         * alpha-bsd-nat.c: Sort headers.
7790         * aix-thread.c: Sort headers.
7791         * agent.c: Sort headers.
7792         * addrmap.c: Sort headers.
7793         * ada-varobj.c: Sort headers.
7794         * ada-valprint.c: Sort headers.
7795         * ada-typeprint.c: Sort headers.
7796         * ada-tasks.c: Sort headers.
7797         * ada-lang.c: Sort headers.
7798         * aarch64-tdep.c: Sort headers.
7799         * aarch64-ravenscar-thread.c: Sort headers.
7800         * aarch64-newlib-tdep.c: Sort headers.
7801         * aarch64-linux-tdep.c: Sort headers.
7802         * aarch64-linux-nat.c: Sort headers.
7803         * aarch64-fbsd-tdep.c: Sort headers.
7804         * aarch64-fbsd-nat.c: Sort headers.
7805         * aarch32-linux-nat.c: Sort headers.
7806
7807 2019-04-04  Tom Tromey  <tom@tromey.com>
7808
7809         * varobj.c (varobj_create): Update.
7810         * rust-exp.y (struct rust_parser) <update_innermost_block,
7811         lookup_symbol>: New methods.
7812         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7813         Rename.
7814         (rust_parser::rust_lookup_type)
7815         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7816         * printcmd.c (display_command, do_one_display): Update.
7817         * parser-defs.h (struct parser_state) <parser_state>: Add
7818         "tracker" parameter.
7819         (block_tracker): New member.
7820         (class innermost_block_tracker) <innermost_block_tracker>: Add
7821         "types" parameter.
7822         <reset>: Remove method.
7823         (innermost_block): Don't declare.
7824         (null_post_parser): Update.
7825         * parse.c (innermost_block): Remove global.
7826         (write_dollar_variable): Update.
7827         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7828         Remove "tracker_types" parameter.
7829         (parse_expression): Add "tracker" parameter.
7830         (parse_expression_for_completion): Update.
7831         (null_post_parser): Add "tracker" parameter.
7832         * p-exp.y: Update rules.
7833         * m2-exp.y: Update rules.
7834         * language.h (struct language_defn) <la_post_parser>: Add
7835         "tracker" parameter.
7836         * go-exp.y: Update rules.
7837         * f-exp.y: Update rules.
7838         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7839         parameter.
7840         * d-exp.y: Update rules.
7841         * c-exp.y: Update rules.
7842         * breakpoint.c (set_breakpoint_condition): Create an
7843         innermost_block_tracker.
7844         (watch_command_1): Likewise.
7845         * ada-lang.c (resolve): Add "tracker" parameter.
7846         (resolve_subexp): Likewise.
7847         * ada-exp.y (write_var_from_sym): Update.
7848
7849 2019-04-04  Tom Tromey  <tom@tromey.com>
7850
7851         * type-stack.h: New file.
7852         * type-stack.c: New file.
7853         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7854         type-stack.h.
7855         (insert_into_type_stack, insert_type, push_type, push_type_int)
7856         (insert_type_address_space, pop_type, pop_type_int)
7857         (pop_typelist, pop_type_stack, append_type_stack)
7858         (push_type_stack, get_type_stack, push_typelist)
7859         (follow_type_instance_flags, follow_types): Don't declare.
7860         * parse.c (type_stack): Remove global.
7861         (parse_exp_in_context): Update.
7862         (insert_into_type_stack, insert_type, push_type, push_type_int)
7863         (insert_type_address_space, pop_type, pop_type_int)
7864         (pop_typelist, pop_type_stack, append_type_stack)
7865         (push_type_stack, get_type_stack, push_typelist)
7866         (follow_type_instance_flags, follow_types): Remove (moved to
7867         type-stack.c).
7868         * f-exp.y (type_stack): New global.
7869         Update rules.
7870         (push_kind_type, f_parse): Update.
7871         * d-exp.y (type_stack): New global.
7872         Update rules.
7873         (d_parse): Update.
7874         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7875         Update rules.
7876         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7877         (HFILES_NO_SRCDIR): Add type-stack.h.
7878
7879 2019-04-04  Tom Tromey  <tom@tromey.com>
7880
7881         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7882         (rust_parser::convert_ast_to_expression, rust_parse)
7883         (rust_lex_test_completion, rust_lex_tests): Update.
7884         * parser-defs.h (struct expr_completion_state): New.
7885         (struct parser_state) <parser_state>: Add completion parameter.
7886         <mark_struct_expression, mark_completion_tag>: New methods.
7887         <parse_completion, m_completion_state>: New members.
7888         (prefixify_expression, null_post_parser): Update.
7889         (mark_struct_expression, mark_completion_tag): Don't declare.
7890         * parse.c (parse_completion, expout_last_struct)
7891         (expout_tag_completion_type, expout_completion_name): Remove
7892         globals.
7893         (parser_state::mark_struct_expression)
7894         (parser_state::mark_completion_tag): Now methods.
7895         (prefixify_expression): Add last_struct parameter.
7896         (prefixify_subexp): Likewise.
7897         (parse_exp_1): Update.
7898         (parse_exp_in_context): Add cstate parameter.  Update.
7899         (parse_expression_for_completion): Create an
7900         expr_completion_state.
7901         (null_post_parser): Add "completion" parameter.
7902         * p-exp.y: Update rules.
7903         (yylex): Update.
7904         * language.h (struct language_defn) <la_post_parser>: Add
7905         "completing" parameter.
7906         * go-exp.y: Update rules.
7907         (lex_one_token): Update.
7908         * expression.h (parse_completion): Don't declare.
7909         * d-exp.y: Update rules.
7910         (lex_one_token): Update rules.
7911         * c-exp.y: Update rules.
7912         (lex_one_token): Update.
7913         * ada-lang.c (resolve): Add "parse_completion" parameter.
7914         (resolve_subexp): Likewise.
7915         (ada_resolve_function): Likewise.
7916
7917 2019-04-04  Tom Tromey  <tom@tromey.com>
7918
7919         * parser-defs.h (struct parser_state) <start_arglist,
7920         end_arglist>: New methods.
7921         <arglist_len, m_funcall_chain>: New members.
7922         (arglist_len, start_arglist, end_arglist): Don't declare.
7923         * parse.c (arglist_len, funcall_chain): Remove global.
7924         (start_arglist, end_arglist): Remove functions.
7925         (parse_exp_in_context): Update.
7926         * p-exp.y: Update rules.
7927         * m2-exp.y: Update rules.
7928         * go-exp.y: Update rules.
7929         * f-exp.y: Update rules.
7930         * d-exp.y: Update rules.
7931         * c-exp.y: Update rules.
7932
7933 2019-04-04  Tom Tromey  <tom@tromey.com>
7934
7935         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7936         lex_operator, push_back>: New methods.
7937         Update all rules.
7938         (rust_parser::lex_hex, lex_escape): Rename and update.
7939         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7940         (rust_parser::lex_operator): Rename and update.
7941         (rust_parser::lex_number, rustyylex, rustyyerror)
7942         (rust_lex_test_init, rust_lex_test_sequence)
7943         (rust_lex_test_push_back, rust_lex_tests): Update.
7944         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7945         parameter.
7946         <lexptr, prev_lexptr>: New members.
7947         (lexptr, prev_lexptr): Don't declare.
7948         * parse.c (lexptr, prev_lexptr): Remove globals.
7949         (parse_exp_in_context): Update.
7950         * p-exp.y (yylex, yyerror): Update.
7951         * m2-exp.y (parse_number, yylex, yyerror): Update.
7952         * go-exp.y (lex_one_token, yyerror): Update.
7953         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7954         * d-exp.y (lex_one_token, yyerror): Update.
7955         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7956         (lex_one_token, yyerror): Update.
7957         * ada-lex.l (YY_INPUT): Update.
7958         (rewind_to_char): Update.
7959         * ada-exp.y (yyerror): Update.
7960
7961 2019-04-04  Tom Tromey  <tom@tromey.com>
7962
7963         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7964         * parser-defs.h (struct parser_state) <parser_state>: Add new
7965         parameter.
7966         <comma_terminates>: New member.
7967         (comma_terminates): Don't declare global.
7968         * parse.c (comma_terminates): Remove global.
7969         (parse_exp_in_context): Update.
7970         * p-exp.y (yylex): Update.
7971         * m2-exp.y (yylex): Update.
7972         * go-exp.y (lex_one_token): Update.
7973         * f-exp.y (yylex): Update.
7974         * d-exp.y (lex_one_token): Update.
7975         * c-exp.y (lex_one_token): Update.
7976         * ada-lex.l: Update.
7977
7978 2019-04-04  Tom Tromey  <tom@tromey.com>
7979
7980         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7981         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7982         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7983         * parser-defs.h (paren_depth): Don't declare.
7984         * parse.c (paren_depth): Remove global.
7985         (parse_exp_in_context): Update.
7986         * p-exp.y (paren_depth): New global.
7987         (pascal_parse): Initialize it.
7988         * m2-exp.y (paren_depth): New global.
7989         (m2_parse): Initialize it.
7990         * go-exp.y (paren_depth): New global.
7991         (go_parse): Initialize it.
7992         * f-exp.y (paren_depth): New global.
7993         (f_parse): Initialize it.
7994         * d-exp.y (paren_depth): New global.
7995         (d_parse): Initialize it.
7996         * c-exp.y (paren_depth): New global.
7997         (c_parse): Initialize it.
7998         * ada-lex.l (paren_depth): New global.
7999         (lexer_init): Initialize it.
8000
8001 2019-04-04  Tom Tromey  <tom@tromey.com>
8002
8003         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8004         (rust_parser::convert_ast_to_type)
8005         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8006         * parser-defs.h (struct parser_state) <parser_state>: Add
8007         parameters.  Initialize new members.
8008         <expression_context_block, expression_context_pc>: New members.
8009         * parse.c (expression_context_block, expression_context_pc):
8010         Remove globals.
8011         (parse_exp_in_context): Update.
8012         * p-exp.y: Update all rules.
8013         (yylex): Update.
8014         * m2-exp.y: Update all rules.
8015         (yylex): Update.
8016         * go-exp.y (yylex): Update.
8017         * f-exp.y (yylex): Update.
8018         * d-exp.y: Update all rules.
8019         (yylex): Update.
8020         * c-exp.y: Update all rules.
8021         (lex_one_token, classify_name, yylex, c_parse): Update.
8022         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8023
8024 2019-04-04  Tom Tromey  <tom@tromey.com>
8025
8026         * gdbarch.h, gdbarch.c: Rebuild.
8027         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8028         * stap-probe.h:
8029         (struct stap_parse_info): Replace "parser_state" with
8030         "expr_builder".
8031         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8032         (parser_state): New class.
8033         * parse.c (expr_builder): Rename.
8034         (expr_builder::release): Rename.
8035         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8036         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8037         (write_exp_elt_longcst, write_exp_elt_floatcst)
8038         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8039         (write_exp_string_vector, write_exp_bitstring)
8040         (write_exp_msymbol, mark_struct_expression)
8041         (write_dollar_variable)
8042         (insert_type_address_space, increase_expout_size): Replace
8043         "parser_state" with "expr_builder".
8044         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8045         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8046         "parser_state" with "expr_builder".
8047
8048 2019-04-04  Tom Tromey  <tom@tromey.com>
8049
8050         * rust-exp.y: Replace "parse_language" with method call.
8051         * p-exp.y:
8052         (yylex): Replace "parse_language" with method call.
8053         * m2-exp.y:
8054         (yylex): Replace "parse_language" with method call.
8055         * go-exp.y (classify_name): Replace "parse_language" with method
8056         call.
8057         * f-exp.y (yylex): Replace "parse_language" with method call.
8058         * d-exp.y (lex_one_token): Replace "parse_language" with method
8059         call.
8060         * c-exp.y:
8061         (lex_one_token, classify_name, yylex): Replace "parse_language"
8062         with method call.
8063         * ada-exp.y (find_primitive_type, type_char)
8064         (type_system_address): Replace "parse_language" with method call.
8065
8066 2019-04-04  Tom Tromey  <tom@tromey.com>
8067
8068         * rust-exp.y: Replace "parse_gdbarch" with method call.
8069         * parse.c (write_dollar_variable, insert_type_address_space):
8070         Replace "parse_gdbarch" with method call.
8071         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8072         call.
8073         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8074         call.
8075         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8076         "parse_gdbarch" with method call.
8077         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8078         with method call.
8079         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8080         "parse_gdbarch" with method call.
8081         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8082         "parse_gdbarch" with method call.
8083         * c-exp.y (parse_type, parse_number, classify_name): Replace
8084         "parse_gdbarch" with method call.
8085         * ada-lex.l: Replace "parse_gdbarch" with method call.
8086         * ada-exp.y (parse_type, find_primitive_type, type_char)
8087         (type_system_address): Replace "parse_gdbarch" with method call.
8088
8089 2019-04-04  Tom Tromey  <tom@tromey.com>
8090
8091         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8092         * stap-probe.c (stap_parse_argument): Update.
8093         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8094         initial_size parameter.
8095         * rust-exp.y (rust_lex_tests): Update.
8096         * parse.c (parser_state): Update.
8097         (parse_exp_in_context): Update.
8098         * parser-defs.h (struct parser_state) <parser_state>: Remove
8099         "initial_size" parameter.
8100
8101 2019-04-04  Tom Tromey  <tom@tromey.com>
8102
8103         * parser-defs.h (increase_expout_size): Don't declare.
8104         * parse.c (increase_expout_size): Now static.
8105
8106 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8107
8108         * gnu-nat.c (gnu_nat_target::wait): Fix
8109         target_waitstatus_to_string call.
8110
8111 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8112
8113         * eval.c (evaluate_subexp_standard): Handle internal functions
8114         during Fortran function call handling.
8115
8116 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8117
8118         * NEWS: Mention new internal functions.
8119         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8120         (read_base_type): Use dwarf2_init_complex_target_type.
8121         * value.c (creal_internal_fn): New function.
8122         (cimag_internal_fn): New function.
8123         (_initialize_values): Register new internal functions.
8124
8125 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8126
8127         * infrun.c (stop_all_threads): If debug_infrun, always
8128         trace the wait status after wait_one, using
8129         target_waitstatus_to_string and target_pid_to_str.
8130         (handle_inferior_event): Replace various trace of
8131         wait status kind by a single trace.
8132         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8133         wait status kind image by target_waitstatus_to_string.
8134         * target/waitstatus.c (target_waitstatus_to_string): Fix
8135         obsolete comment.
8136
8137 2019-04-01  Tom Tromey  <tromey@adacore.com>
8138
8139         PR symtab/23331:
8140         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8141
8142 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8143             Pedro Alves  <palves@redhat.com>
8144
8145         * top.c (quit_force): Call 'finalize_values'.
8146         * value.c (finalize_values): New function.
8147         * value.h (finalize_values): Declare.
8148
8149 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8150
8151         * NEWS: Announce $_gdb_major and $_gdb_minor.
8152
8153         * top.c (init_gdb_version_vars): New function.
8154         (gdb_init): Call init_gdb_version_vars.
8155
8156 2019-03-29  Tom Tromey  <tromey@adacore.com>
8157
8158         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8159         help text.  Remove dead code.
8160
8161 2019-03-29  Keith Seitz  <keiths@redhat.com>
8162
8163         From Siddhesh Poyarekar:
8164         * f-lang.h (f77_get_upperbound): Return LONGEST.
8165         (f77_get_lowerbound): Likewise.
8166         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8167         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8168         print them.
8169         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8170         plongest to format print it.
8171         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8172         (f77_get_upperbound): Likewise.
8173         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8174         LOWER_BOUND to LONGEST.
8175         (f77_create_arrayprint_offset_tbl): Likewise.
8176
8177 2019-03-29  Keith Seitz  <keiths@redhat.com>
8178
8179         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8180         %s/pulongest for TYPE_LENGTH instead of %d in format
8181         strings.
8182         * ada-typerint.c (ada_print_type): Likewise.
8183         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8184         * compile/compile-c-support.c (generate_register_struct): Likewise.
8185         * gdbtypes.c (recursive_dump_type): Likewise.
8186         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8187         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8188         instead of %d in format strings.
8189         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8190         to std::min to ULONGEST.
8191         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8192         instead of %d in format strings.
8193         * tracepoint.c (info_scope_command): Likewise.
8194         * typeprint.c (print_offset_data::update)
8195         (print_offset_data::finish): Likewise.
8196         * xtensa-tdep.c (xtensa_store_return_value)
8197         (xtensa_push_dummy_call): Likewise.
8198
8199 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8200
8201         * windows-nat.c (display_selector): Fixed format specifications
8202         for 64-bit Cygwin.
8203
8204 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8205
8206         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8207
8208 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8209
8210         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8211         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8212         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8213         (nios2_linux_init_abi): Install it.
8214
8215 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8216
8217         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8218
8219 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8220
8221         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8222
8223 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8224             Tom Tromey  <tromey@adacore.com>
8225
8226         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8227
8228 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8229
8230         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8231         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8232         method to compute the bounds of range types. Also print "[evaluated]"
8233         if the bounds' values come from a dynamic evaluation.
8234
8235 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8236
8237         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8238         whitespace when pretty printing is on.
8239
8240 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8241
8242         * ppc-linux-nat.c: Add include.
8243
8244 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8245
8246         * NEWS: Mention AArch64 Pointer Authentication.
8247
8248 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8249
8250         * arm-linux-nat.c: Add include.
8251
8252 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8253
8254         * source-cache.c (source_cache::get_source_lines): Re-read
8255         fullname after calling open_source_file.
8256
8257 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8258
8259         * NEWS: Mention TLS support for FreeBSD.
8260
8261 2019-03-25  Tom Tromey  <tromey@adacore.com>
8262
8263         * minsyms.c (BUNCH_SIZE): Update comment.
8264         (~minimal_symbol_reader): Remove old comment.
8265         (compact_minimal_symbols): Update comment.
8266         (minimal_symbol_reader::install): Remove old comment.  Update
8267         other comments.
8268
8269 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8270
8271         * s390-linux-nat.c: Add include.
8272
8273 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8274
8275         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8276         Call linux_get_hwcap.
8277         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8278         Likewise.
8279         (aarch64_linux_get_hwcap): Remove function.
8280         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8281         declaration.
8282         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8283         linux_get_hwcap.
8284         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8285         * linux-tdep.c (linux_get_hwcap): Add function.
8286         (linux_get_hwcap2): Likewise.
8287         * linux-tdep.h (linux_get_hwcap): Add declaration.
8288         (linux_get_hwcap2): Likewise.
8289         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8290         (ppc_linux_get_hwcap2): Likewise.
8291         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8292         linux_get_hwcap.
8293         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8294         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8295         (ppc_linux_nat_target::read_description): Likewise.
8296         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8297         * s390-linux-nat.c: Likewise.
8298         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8299
8300 2019-03-24  Tom Tromey  <tom@tromey.com>
8301
8302         * ada-lang.c (standard_lookup): Simplify initialization.
8303         (ada_lookup_symbol_nonlocal): Simplify return.
8304         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8305         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8306         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8307         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8308         initialization.
8309         * solib.c (solib_global_lookup): Simplify.
8310         * symtab.c (null_block_symbol): Remove.
8311         (symbol_cache_lookup): Simplify returns.
8312         (lookup_language_this): Simplify returns.
8313         (lookup_symbol_aux): Simplify return.
8314         (lookup_local_symbol): Simplify returns.
8315         (lookup_global_symbol_from_objfile): Simplify return.
8316         (lookup_symbol_in_objfile_symtabs)
8317         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8318         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8319         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8320         * cp-namespace.c (cp_lookup_bare_symbol)
8321         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8322         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8323         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8324         (cp_lookup_symbol_via_imports): Simplify initialization.
8325         (find_symbol_in_baseclass): Likewise.
8326         * symtab.h (null_block_symbol): Remove.
8327         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8328         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8329         (d_lookup_symbol_module): Likewise.
8330         (find_symbol_in_baseclass): Simplify initialization.
8331
8332 2019-03-24  Tom Tromey  <tom@tromey.com>
8333
8334         * expression.h: Don't include symtab.h.
8335         (struct block): Forward declare.
8336
8337 2019-03-24  Tom Tromey  <tom@tromey.com>
8338
8339         * c-exp.y (typebase): Remove casts.
8340         * gdbtypes.c (lookup_unsigned_typename, )
8341         (lookup_signed_typename): Remove cast.
8342         * eval.c (parse_to_comma_and_eval): Remove cast.
8343         * parse.c (write_dollar_variable): Remove cast.
8344         * block.h (struct block) <superblock>: Now const.
8345         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8346         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8347         (map_block): Make "block" const.
8348         * symfile.h (struct quick_symbol_functions)
8349         <map_matching_symbols>: Constify block argument to "callback".
8350         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8351         const.
8352         (find_pc_sect_compunit_symtab): Make "b" const.
8353         (find_symbol_at_address): Likewise.
8354         (search_symbols): Likewise.
8355         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8356         (dw2_debug_names_lookup_symbol): Likewise.
8357         (dw2_map_matching_symbols): Update.
8358         * p-valprint.c (pascal_val_print): Remove "block".
8359         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8360         (aux_add_nonlocal_symbols): Make "block" const.
8361         (resolve_subexp): Remove cast.
8362         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8363         const.
8364         (iterate_over_file_blocks): Likewise.
8365         * f-exp.y (%union) <bval>: Remove.
8366         * coffread.c (patch_opaque_types): Make "b" const.
8367         * spu-tdep.c (spu_catch_start): Make "block" const.
8368         * c-valprint.c (print_unpacked_pointer): Remove "block".
8369         * symmisc.c (dump_symtab_1): Make "b" const.
8370         (block_depth): Make "block" const.
8371         * d-exp.y (%union) <bval>: Remove.
8372         * cp-support.h (cp_lookup_rtti_type): Update.
8373         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8374         * psymtab.c (psym_lookup_symbol): Make "block" const.
8375         (maintenance_check_psymtabs): Make "b" const.
8376         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8377         (enumerate_locals, enumerate_args): Update.
8378         * python/py-symtab.c (stpy_global_block): Make "block" const.
8379         (stpy_static_block): Likewise.
8380         * inline-frame.c (block_starting_point_at): Make "new_block"
8381         const.
8382         * block.c (find_block_in_blockvector): Make return type const.
8383         (blockvector_for_pc_sect): Make "b" const.
8384         (find_block_in_blockvector): Make "b" const.
8385
8386 2019-03-23  Tom Tromey  <tom@tromey.com>
8387
8388         * varobj.c (varobj_create): Update.
8389         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8390         * printcmd.c (display_command, do_one_display): Don't reset
8391         innermost_block.
8392         * parser-defs.h (enum innermost_block_tracker_type): Move to
8393         expression.h.
8394         (innermost_block): Update comment.
8395         * parse.c (parse_exp_1): Add tracker_types parameter.
8396         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8397         tracker_types parameter.  Reset innermost_block.
8398         (parse_exp_in_context): Remove.
8399         (parse_expression_for_completion): Update.
8400         * objfiles.c (~objfile): Don't reset expression_context_block or
8401         innermost_block.
8402         * expression.h (enum innermost_block_tracker_type): Move from
8403         parser-defs.h.
8404         (parse_exp_1): Add tracker_types parameter.
8405         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8406         reset innermost_block.
8407
8408 2019-03-23  Tom Tromey  <tom@tromey.com>
8409
8410         * objfiles.h: Include bcache.h.
8411
8412 2019-03-23  Tom Tromey  <tom@tromey.com>
8413
8414         * linespec.c (get_current_search_block): Use
8415         scoped_restore_current_language.
8416         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8417
8418 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8419             Jiong Wang  <jiong.wang@arm.com>
8420
8421         * aarch64-linux-tdep.c
8422         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8423         section.
8424         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8425
8426 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8427             Jiong Wang  <jiong.wang@arm.com>
8428
8429         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8430         instructions.
8431         (aarch64_analyze_prologue_test): Add PACIASP test.
8432         (aarch64_prologue_prev_register): Unmask PC value.
8433
8434 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8435             Jiong Wang  <jiong.wang@arm.com>
8436
8437         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8438         (aarch64_dwarf2_prev_register): Unmask PC value.
8439         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8440         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8441         DW_CFA_AARCH64_negate_ra_state.
8442         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8443
8444 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8445             Jiong Wang  <jiong.wang@arm.com>
8446
8447         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8448         registers.
8449         (aarch64_pseudo_register_name): Likewise.
8450         (aarch64_pseudo_register_type): Likewise.
8451         (aarch64_pseudo_register_reggroup_p): Likewise.
8452         (aarch64_gdbarch_init): Add pauth registers.
8453         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8454         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8455         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8456         (struct gdbarch_tdep): Add regnum for ra_state.
8457
8458 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8459             Jiong Wang  <jiong.wang@arm.com>
8460
8461         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8462
8463 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8464             Jiong Wang  <jiong.wang@arm.com>
8465
8466         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8467         function.
8468         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8469         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8470         (aarch64_gdbarch_init): Add puth registers.
8471         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8472         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8473         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8474
8475 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8476             Jiong Wang  <jiong.wang@arm.com>
8477
8478         * aarch64-linux-nat.c
8479         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8480         * aarch64-linux-tdep.c
8481         (aarch64_linux_core_read_description): Likewise.
8482         (aarch64_linux_get_hwcap): New function.
8483         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8484         (aarch64_linux_get_hwcap): New declaration.
8485
8486 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8487             Jiong Wang  <jiong.wang@arm.com>
8488
8489         * aarch64-linux-nat.c
8490         (aarch64_linux_nat_target::read_description): Add pauth param.
8491         * aarch64-linux-tdep.c
8492         (aarch64_linux_core_read_description): Likewise.
8493         * aarch64-tdep.c (struct target_desc): Add in pauth.
8494         (aarch64_read_description): Add pauth param.
8495         (aarch64_gdbarch_init): Likewise.
8496         * aarch64-tdep.h (aarch64_read_description): Likewise.
8497         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8498         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8499         * features/Makefile: Add new files.
8500         * features/aarch64-pauth.c: New file.
8501         * features/aarch64-pauth.xml: New file.
8502
8503 2019-03-20  Tom Tromey  <tromey@adacore.com>
8504
8505         * infrun.c (handle_inferior_event): Rename from
8506         handle_inferior_event_1.  Create a scoped_value_mark.
8507         (handle_inferior_event): Remove.
8508
8509 2019-03-19  Tom Tromey  <tromey@adacore.com>
8510
8511         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8512         * infrun.h (print_stop_event): Add "displays" parameter.
8513         * infrun.c (print_stop_event): Add "displays" parameter.
8514
8515 2019-03-19  Pedro Alves  <palves@redhat.com>
8516
8517         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8518         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8519         to -1.  Fix TABs vs spaces.
8520         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8521         * tui/tui-out.h (tui_ui_out) Add intro comments.
8522         <m_line, m_start_of_line>: In-class initialize, and add describing
8523         comment.
8524
8525 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8526
8527         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8528         variable names.
8529         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8530
8531 2019-03-18  Pedro Alves  <palves@redhat.com>
8532             Eli Zaretskii <eliz@gnu.org>
8533
8534         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8535         m_line and m_start_of_line.
8536
8537 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8538
8539         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8540         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8541         it returns a newline.  This fixes a regression in TU mode, whereby
8542         the next line is output on the same screen line as the user input.
8543
8544 2019-03-18  Tom Tromey  <tromey@adacore.com>
8545
8546         * minsyms.c (minimal_symbol_reader::install): Remove call to
8547         obstack_blank.
8548
8549 2019-03-18  Pedro Alves  <palves@redhat.com>
8550
8551         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8552         New globals.
8553         (apply_style): New, factored out from ...
8554         (apply_ansi_escape): ... this.  Handle reverse video mode.
8555         (tui_set_reverse_mode): New function.
8556         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8557         * tui/tui-winsource.c (tui_show_source_line): Use
8558         tui_set_reverse_mode instead of setting A_STANDOUT.
8559         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8560         New setter methods.
8561
8562 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8563
8564         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8565         Handle tabs.
8566
8567 2019-03-18  Tom Tromey  <tromey@adacore.com>
8568
8569         * ada-lang.c (empty_array): Add "high" parameter.
8570         (ada_evaluate_subexp): Update.
8571
8572 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8573
8574         * unittests/string_view-selftests.c: Define
8575         _initialize_string_view_selftests unconditionally.
8576
8577 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8578
8579         PR gdb/24350
8580         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8581
8582 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8583
8584         PR gdb/24351
8585         * windows-nat.c (display_selector): Fix format specifiers.
8586
8587 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8588
8589         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8590         tui_refill_source_window instead of tui_refresh_win, to update the
8591         current execution line.  This fixes redisplay of the current line
8592         when stepping through the code with "next" or "step".
8593
8594 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8595
8596         * source-cache.c (source_cache::get_source_lines): Call
8597         find_source_lines to initialize s->nlines.  This fixes vertical
8598         scrolling of TUI source window when the DOWN arrow is pressed.
8599
8600 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8601
8602         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8603         linux-thread-db.c (_initialize_thread_db): Likewise.
8604
8605 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8606
8607         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8608         wclrtoeol in tui_show_source_line".  This reverts changes made in
8609         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8610
8611 2019-03-15  Tom Tromey  <tom@tromey.com>
8612
8613         * symtab.h (struct minimal_symbol): Derive from
8614         general_symbol_info.
8615         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8616         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8617         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8618         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8619         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8620         (MSYMBOL_SEARCH_NAME): Update.
8621         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8622         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8623         * minsyms.c (minimal_symbol_reader::record_full): Update.
8624
8625 2019-03-15  Tom Tromey  <tom@tromey.com>
8626
8627         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8628
8629 2019-03-15  Tom Tromey  <tom@tromey.com>
8630
8631         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8632         unique_xmalloc_ptr.
8633         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8634         Update.
8635         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8636         (build_minimal_symbol_hash_tables)
8637         (minimal_symbol_reader::install): Update.
8638
8639 2019-03-15  Tom Tromey  <tom@tromey.com>
8640
8641         * symtab.c (create_demangled_names_hash): Update.
8642         (symbol_set_names): Update.
8643         * objfiles.h (struct objfile_per_bfd_storage)
8644         <demangled_names_hash>: Now an htab_up.
8645         * objfiles.c (objfile_per_bfd_storage): Simplify.
8646
8647 2019-03-15  Tom Tromey  <tom@tromey.com>
8648
8649         * objfiles.h (struct objfile_per_bfd_storage): Declare
8650         destructor.
8651         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8652         New.
8653         (get_objfile_bfd_data): Use new.  Don't initialize
8654         language_of_main.
8655         (free_objfile_per_bfd_storage): Remove.
8656         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8657
8658 2019-03-15  Tom Tromey  <tom@tromey.com>
8659
8660         * symfile.c (reread_symbols): Update.
8661         * objfiles.c (objfile::objfile): Update.
8662         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8663         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8664         comment.
8665         (minimal_symbol_reader::install): Update.
8666         (terminate_minimal_symbol_table): Remove.
8667         * jit.c (jit_object_close_impl): Update.
8668
8669 2019-03-15  Tom Tromey  <tom@tromey.com>
8670
8671         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8672         initializations.
8673
8674 2019-03-15  Tom Tromey  <tom@tromey.com>
8675
8676         * objfiles.h (struct objfile_per_bfd_storage)
8677         <demangled_hash_languages>: Now a bitset.
8678         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8679         (lookup_minimal_symbol): Update.
8680
8681 2019-03-15  Tom Tromey  <tom@tromey.com>
8682
8683         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8684         Don't return the symbol.
8685         * coffread.c (record_minimal_symbol): Use record_full.
8686
8687 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8688
8689         The MS-Windows port of ncurses fails to switch to a color pair if
8690         one or both of the colors are the implicit default colors.  This
8691         change records the default colors when TUI is initialized, and
8692         then specifies them explicitly when a color pair uses the default
8693         colors.  This allows color styling in TUI mode on MS-Windows.
8694
8695         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8696         ncurses_norm_attr.
8697         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8698         colors in ncurses_norm_attr.
8699         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8700         "none", replace it with the default color recorded in
8701         ncurses_norm_attr.
8702
8703 2019-03-14  Tom Tromey  <tromey@adacore.com>
8704
8705         * source-cache.h (class source_cache) <get_source_lines>: Return
8706         std::string.
8707         * source-cache.c (source_cache::extract_lines): Handle case where
8708         first_pos==npos.  Return std::string.
8709         (source_cache::get_source_lines): Update.
8710
8711 2019-03-14  Tom Tromey  <tromey@adacore.com>
8712
8713         * NEWS: Add item for "style sources" commands.
8714         * source-cache.c (source_cache::get_source_lines): Check
8715         source_styling.
8716         * cli/cli-style.c (source_styling): New global.
8717         (_initialize_cli_style): Add "style sources" commands.
8718         (show_style_sources): New function.
8719         * cli/cli-style.h (source_styling): Declare.
8720
8721 2019-03-14  Pedro Alves  <palves@redhat.com>
8722             Tom Tromey  <tromey@adacore.com>
8723
8724         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8725         * tui/tui-winsource.c (tui_refill_source_window): New function,
8726         from...
8727         (tui_horizontal_source_scroll): ... here.  Move some logic.
8728         * cli/cli-style.c (set_style_enabled): Notify new observable.
8729         * tui/tui-hooks.c (tui_redisplay_source): New function.
8730         (tui_attach_detach_observers): Attach or detach
8731         tui_redisplay_source.
8732         * observable.h (source_styling_changed): New observable.
8733         * observable.c: Define source_styling_changed observable.
8734
8735 2019-03-13  Tom Tromey  <tromey@adacore.com>
8736
8737         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8738         (i386_gnu_nat_target::store_registers): Update.
8739         * target-debug.h (target_debug_print_std_string): New macro.
8740         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8741         * windows-tdep.c (display_one_tib): Update.
8742         * tui/tui-stack.c (tui_make_status_line): Update.
8743         * top.c (print_inferior_quit_action): Update.
8744         * thread.c (thr_try_catch_cmd): Update.
8745         (add_thread_with_info): Update.
8746         (thread_target_id_str): Update.
8747         (thr_try_catch_cmd): Update.
8748         (thread_command): Update.
8749         (thread_find_command): Update.
8750         * record-btrace.c (record_btrace_target::info_record)
8751         (record_btrace_resume_thread, record_btrace_target::resume)
8752         (record_btrace_cancel_resume, record_btrace_step_thread)
8753         (record_btrace_target::wait, record_btrace_target::wait)
8754         (record_btrace_target::wait, record_btrace_target::stop): Update.
8755         * progspace.c (print_program_space): Update.
8756         * process-stratum-target.c
8757         (process_stratum_target::thread_address_space): Update.
8758         * linux-fork.c (linux_fork_mourn_inferior)
8759         (detach_checkpoint_command, info_checkpoints_command)
8760         (linux_fork_context): Update.
8761         (linux_fork_detach): Update.
8762         (class scoped_switch_fork_info): Update.
8763         (delete_checkpoint_command): Update.
8764         * infrun.c (follow_fork_inferior): Update.
8765         (follow_fork_inferior): Update.
8766         (proceed_after_vfork_done): Update.
8767         (handle_vfork_child_exec_or_exit): Update.
8768         (follow_exec): Update.
8769         (displaced_step_prepare_throw): Update.
8770         (displaced_step_restore): Update.
8771         (start_step_over): Update.
8772         (resume_1): Update.
8773         (clear_proceed_status_thread): Update.
8774         (proceed): Update.
8775         (print_target_wait_results): Update.
8776         (do_target_wait): Update.
8777         (context_switch): Update.
8778         (stop_all_threads): Update.
8779         (restart_threads): Update.
8780         (finish_step_over): Update.
8781         (handle_signal_stop): Update.
8782         (switch_back_to_stepped_thread): Update.
8783         (keep_going_pass_signal): Update.
8784         (print_exited_reason): Update.
8785         (normal_stop): Update.
8786         * inferior.c (inferior_pid_to_str): Change return type.
8787         (print_selected_inferior): Update.
8788         (add_inferior): Update.
8789         (detach_inferior): Update.
8790         * dummy-frame.c (fprint_dummy_frames): Update.
8791         * dcache.c (dcache_info_1): Update.
8792         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8793         (btrace_fetch, btrace_clear): Update.
8794         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8795         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8796         type.
8797         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8798         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8799         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8800         * gdbarch.c, gdbarch.h: Rebuild.
8801         * gdbarch.sh (core_pid_to_str): Change return type.
8802         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8803         return type.
8804         (windows_nat_target::pid_to_str): Change return type.
8805         (windows_delete_thread): Update.
8806         (windows_nat_target::attach): Update.
8807         (windows_nat_target::files_info): Update.
8808         * target-delegates.c: Rebuild.
8809         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8810         return type.
8811         (sol_thread_target::pid_to_str): Change return type.
8812         * remote.c (class remote_target) <pid_to_str>: Change return
8813         type.
8814         (remote_target::pid_to_str): Change return type.
8815         (extended_remote_target::attach, remote_target::remote_stop_ns)
8816         (remote_target::remote_notif_remove_queued_reply)
8817         (remote_target::push_stop_reply, remote_target::disable_btrace):
8818         Update.
8819         (extended_remote_target::attach): Update.
8820         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8821         type.
8822         (gdbsim_target::pid_to_str): Change return type.
8823         * ravenscar-thread.c (struct ravenscar_thread_target)
8824         <pid_to_str>: Change return type.
8825         (ravenscar_thread_target::pid_to_str): Change return type.
8826         * procfs.c (class procfs_target) <pid_to_str>: Change return
8827         type.
8828         (procfs_target::pid_to_str): Change return type.
8829         (procfs_target::attach): Update.
8830         (procfs_target::detach): Update.
8831         (procfs_target::fetch_registers): Update.
8832         (procfs_target::store_registers): Update.
8833         (procfs_target::wait): Update.
8834         (procfs_target::files_info): Update.
8835         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8836         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8837         return type.
8838         (nto_procfs_target::pid_to_str): Change return type.
8839         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8840         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8841         return type.
8842         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8843         (exit_lwp): Update.
8844         (attach_proc_task_lwp_callback, get_detach_signal)
8845         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8846         (linux_nat_target::resume, wait_lwp, stop_callback)
8847         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8848         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8849         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8850         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8851         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8852         type.
8853         (inf_ptrace_target::attach): Update.
8854         (inf_ptrace_target::files_info): Update.
8855         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8856         type.
8857         (go32_nat_target::pid_to_str): Change return type.
8858         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8859         (gnu_nat_target::wait): Update.
8860         (gnu_nat_target::wait): Update.
8861         (gnu_nat_target::resume): Update.
8862         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8863         (fbsd_nat_target::wait): Update.
8864         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8865         type.
8866         (darwin_nat_target::attach): Update.
8867         * corelow.c (class core_target) <pid_to_str>: Change return type.
8868         (core_target::pid_to_str): Change return type.
8869         * target.c (normal_pid_to_str): Change return type.
8870         (default_pid_to_str): Likewise.
8871         (target_pid_to_str): Change return type.
8872         (target_translate_tls_address): Update.
8873         (target_announce_detach): Update.
8874         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8875         return type.
8876         (bsd_uthread_target::pid_to_str): Change return type.
8877         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8878         type.
8879         (bsd_kvm_target::pid_to_str): Change return type.
8880         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8881         return type.
8882         (aix_thread_target::pid_to_str): Change return type.
8883         * target.h (struct target_ops) <pid_to_str>: Change return type.
8884         (target_pid_to_str, normal_pid_to_str): Likewise.
8885         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8886         type.
8887         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8888         type.
8889         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8890         return type.
8891         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8892         type.
8893         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8894         type.
8895         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8896         return type.
8897
8898 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8899
8900         * NEWS: Mention that the new default MI version is 3.  Mention
8901         changes to the output of commands and events that deal with
8902         multi-location breakpoints.
8903         * breakpoint.c: Include "mi/mi-out.h".
8904         (print_one_breakpoint): Change output syntax if using MI version
8905         >= 3.
8906         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8907         New.
8908         (mi_multi_location_breakpoint_output_fixed): New.
8909         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8910         (mi_cmd_fix_multi_location_breakpoint_output): New.
8911         (mi_multi_location_breakpoint_output_fixed): New.
8912         * mi/mi-cmds.c (mi_cmds): Register command
8913         -fix-multi-location-breakpoint-output.
8914         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8915         interpreter "mi".
8916
8917 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8918
8919         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8920         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8921         instantiate mi_ui_out based on interpreter name.
8922         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8923         * mi/mi-main.c (mi_load_progress): Likewise.
8924
8925 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8926
8927         * NEWS: Combine separate "New targets" sections for 8.3.
8928
8929 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8930
8931         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8932         (ppcfbsd_init_abi): Install gdbarch
8933         "fetch_tls_load_module_address" and "get_thread_local_address"
8934         methods.
8935
8936 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8937
8938         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8939         (riscv_fbsd_init_abi): Install gdbarch
8940         "fetch_tls_load_module_address" and "get_thread_local_address"
8941         methods.
8942
8943 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8944
8945         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8946         (i386fbsd_init_abi): Install gdbarch
8947         "fetch_tls_load_module_address" and "get_thread_local_address"
8948         methods.
8949
8950 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8951
8952         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8953         (amd64fbsd_init_abi): Install gdbarch
8954         "fetch_tls_load_module_address" and "get_thread_local_address"
8955         methods.
8956
8957 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8958
8959         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8960         (struct fbsd_pspace_data): New type.
8961         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8962         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8963         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8964         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8965         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8966
8967 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8968
8969         * gdbtypes.c (lookup_struct_elt): New function.
8970         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8971         * gdbtypes.h (struct struct_elt): New type.
8972         (lookup_struct_elt): New prototype.
8973
8974 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8975
8976         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8977         remove disabled code block.
8978
8979 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8980
8981         * gdbarch.sh (get_thread_local_address): New method.
8982         * gdbarch.h, gdbarch.c: Regenerate.
8983         * target.c (target_translate_tls_address): Use
8984         gdbarch_get_thread_local_address if present instead of
8985         target::get_thread_local_address.
8986
8987 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8988
8989         * target.h (target::get_thread_local_address): Update comment.
8990
8991 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8992
8993         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8994         objfile->separate_debug_objfile_backlink if not NULL.
8995
8996 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8997
8998         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8999         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9000         (amd64bsd_store_inferior_registers): Likewise.
9001         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9002         Enable segment base registers.
9003         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9004         PT_GETFSBASE and PT_GETGSBASE.
9005         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9006         PT_SETGSBASE.
9007         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9008         segment base registers.
9009         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9010
9011 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9012
9013         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9014         Update calls to i386_target_description to add 'segments'
9015         parameter.
9016         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9017         add segment base registers.
9018         * arch/i386.c (i386_create_target_description): Add 'segments'
9019         parameter to enable segment base registers.
9020         * arch/i386.h (i386_create_target_description): Likewise.
9021         * features/i386/32bit-segments.xml: New file.
9022         * features/i386/32bit-segments.c: Generate.
9023         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9024         call to i386_target_description to add 'segments' parameter.
9025         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9026         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9027         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9028         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9029         if feature is present.
9030         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9031         Add 'segments' parameter to call to i386_target_description.
9032         (i386_target_description): Add 'segments' parameter to enable
9033         segment base registers.
9034         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9035         to call to i386_target_description.
9036         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9037         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9038         Define I386_NUM_REGS.
9039         (i386_target_description): Add 'segments' parameter to enable
9040         segment base registers.
9041
9042 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9043
9044         PR/24325
9045         * source-cache.c: #undef open and close, to avoid unresolved
9046         externals during linking.
9047
9048 2019-03-12  Tom Tromey  <tromey@adacore.com>
9049
9050         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9051         const.  Add initializers.
9052         (_initialize_remote): Don't initialize ptid globals.
9053
9054 2019-03-12  Pedro Alves  <palves@redhat.com>
9055
9056         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9057
9058 2019-03-12  Pedro Alves  <palves@redhat.com>
9059
9060         * cp-name-parser.y (main): Remove unused 'len' variable.
9061
9062 2019-03-12  Tom Tromey  <tromey@adacore.com>
9063
9064         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9065         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9066
9067 2019-03-12  Tom Tromey  <tromey@adacore.com>
9068
9069         * linux-nat.c (iterate_over_lwps): Update.
9070         (stop_callback): Remove parameter.
9071         (stop_wait_callback, detach_callback, resume_set_callback)
9072         (select_singlestep_lwp_callback, set_ignore_sigint)
9073         (status_callback, resumed_callback, resume_clear_callback)
9074         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9075         data parameter.
9076         (linux_nat_target::detach, linux_nat_target::resume)
9077         (linux_stop_and_wait_all_lwps, select_event_lwp)
9078         (linux_nat_filter_event, linux_nat_wait_1)
9079         (linux_nat_target::kill, linux_nat_target::stop)
9080         (linux_nat_target::stop): Update.
9081         (linux_nat_resume_callback): Change type.
9082         (resume_stopped_resumed_lwps, count_events_callback)
9083         (select_event_lwp_callback): Likewise.
9084         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9085         * arm-linux-nat.c (struct update_registers_data): Remove.
9086         (update_registers_callback): Change type.
9087         (arm_linux_insert_hw_breakpoint1): Update.
9088         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9089         parameter.
9090         (x86_linux_dr_set_addr): Update.
9091         (x86_linux_dr_set_control): Update.
9092         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9093         (iterate_over_lwps): Use gdb::function_view.
9094         * nat/aarch64-linux-hw-point.c (struct
9095         aarch64_dr_update_callback_param): Remove.
9096         (debug_reg_change_callback): Change type.
9097         (aarch64_notify_debug_reg_change): Update.
9098         * s390-linux-nat.c (s390_refresh_per_info): Update.
9099
9100 2019-03-11  Tom Tromey  <tromey@adacore.com>
9101
9102         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9103         redundant assignment to "this_cu".
9104
9105 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9106
9107         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9108
9109 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9110
9111         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9112         from...
9113         (rank_one_type): ... this.
9114
9115 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9116
9117         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9118         from...
9119         (rank_one_type): ... this.
9120
9121 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9122
9123         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9124         from...
9125         (rank_one_type): ... this.
9126
9127 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9128
9129         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9130         from...
9131         (rank_one_type): ... this.
9132
9133 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9134
9135         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9136         from...
9137         (rank_one_type): ... this.
9138
9139 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9140
9141         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9142         from...
9143         (rank_one_type): ... this.
9144
9145 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9146
9147         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9148         from...
9149         (rank_one_type): ... this.
9150
9151 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9152
9153         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9154         from...
9155         (rank_one_type): ... this.
9156
9157 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9158
9159         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9160         from...
9161         (rank_one_type): ... this.
9162
9163 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9164
9165         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9166         from...
9167         (rank_one_type): ... this.
9168
9169 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9170
9171         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9172         from...
9173         (rank_one_type): ... this.
9174
9175 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9176
9177         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9178         from...
9179         (rank_one_type): ... this.
9180
9181 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9182
9183         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9184         inferior-events' shows the example events.
9185
9186 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9187
9188         Support styling on native MS-Windows console
9189
9190         PR/24315
9191         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9192         on MS-Windows if $TERM is not defined.
9193
9194         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9195
9196         * posix-hdep.c (gdb_console_fputs):
9197         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9198         functions.
9199         * ui-file.h (gdb_console_fputs): Add prototype.
9200
9201         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9202         back to fputs only if the former returns zero.
9203
9204 2019-03-07  Tom Tromey  <tom@tromey.com>
9205
9206         * symmisc.c (print_symbol_bcache_statistics): Update.
9207         (print_objfile_statistics): Update.
9208         * symfile.c (allocate_symtab): Update.
9209         * stabsread.c: Don't include bcache.h.
9210         * psymtab.h (struct psymbol_bcache): Don't declare.
9211         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9212         (psymbol_bcache_init, psymbol_bcache_free)
9213         (psymbol_bcache_get_bcache): Don't declare.
9214         * psymtab.c (struct psymbol_bcache): Remove.
9215         (psymtab_storage::psymtab_storage): Update.
9216         (psymtab_storage::~psymtab_storage): Update.
9217         (psymbol_bcache_init, psymbol_bcache_free)
9218         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9219         (add_psymbol_to_bcache): Update.
9220         (allocate_psymtab): Update.
9221         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9222         macro_cache>: No longer pointers.
9223         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9224         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9225         * macrotab.c (macro_bcache): Update.
9226         * macroexp.c: Don't include bcache.h.
9227         * gdbtypes.c (check_types_worklist): Update.
9228         (types_deeply_equal): Remove TRY/CATCH.  Update.
9229         * elfread.c (elf_symtab_read): Update.
9230         * dwarf2read.c: Don't include bcache.h.
9231         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9232         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9233         (print_bcache_statistics, bcache_memory_used): Don't declare.
9234         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9235         methods.  Rename all data members.
9236         * bcache.c (struct bcache): Move to bcache.h.
9237         (bcache::expand_hash_table): Rename from expand_hash_table.
9238         (bcache): Remove.
9239         (bcache::insert): Rename from bcache_full.
9240         (bcache::compare): Rename from bcache_compare.
9241         (bcache_xmalloc): Remove.
9242         (bcache::~bcache): Rename from bcache_xfree.
9243         (bcache::print_statistics): Rename from print_bcache_statistics.
9244         (bcache::memory_used): Rename from bcache_memory_used.
9245
9246 2019-03-07  Pedro Alves  <palves@redhat.com>
9247
9248         * infrun.c (normal_stop): Also check for
9249         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9250
9251 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9252
9253         * f-lang.c (value_from_host_double): Moved to...
9254         * value.c (value_from_host_double): ...here.
9255         * value.h (value_from_host_double): Declare.
9256         * guile/scm-math.c (vlscm_convert_typed_number): Use
9257         value_from_host_double.
9258         (vlscm_convert_number): Likewise.
9259         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9260         * python/py-value.c (convert_value_from_python): Likewise.
9261
9262 2019-03-06  Tom Tromey  <tom@tromey.com>
9263
9264         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9265
9266 2019-03-06  Tom Tromey  <tom@tromey.com>
9267
9268         * utils.h (free_current_contents): Don't declare.
9269         * utils.c (free_current_contents): Remove.
9270
9271 2019-03-06  Tom Tromey  <tom@tromey.com>
9272
9273         * top.c (quit_force): Update.
9274         * main.c (captured_command_loop): Update.
9275         * common/new-op.c (operator new): Update.
9276         * common/common-exceptions.c (struct catcher)
9277         <save_cleanup_chain>: Remove member.
9278         (exceptions_state_mc_init): Update.
9279         (exception_try_scope_entry): Return nullptr.
9280         (exception_try_scope_exit, exception_rethrow)
9281         (throw_exception_sjlj, throw_exception_cxx): Update.
9282         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9283         (all_cleanups, do_cleanups, discard_cleanups)
9284         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9285         (restore_cleanups, restore_final_cleanups): Don't declare.
9286         (do_final_cleanups): Remove parameter.
9287         * common/cleanups.c (cleanup_chain, make_cleanup)
9288         (make_cleanup_dtor, all_cleanups, do_cleanups)
9289         (discard_my_cleanups, discard_cleanups)
9290         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9291         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9292         (null_cleanup): Remove.
9293         (do_final_cleanups): Remove parameter.
9294
9295 2019-03-06  Tom Tromey  <tom@tromey.com>
9296
9297         * remote.c (remote_target::remote_parse_stop_reply): Use
9298         unique_xmalloc_ptr.
9299
9300 2019-03-06  Tom Tromey  <tom@tromey.com>
9301
9302         * stabsread.c (struct stabs_field_info): Rename from field_info.
9303         <list, fnlist>: Add initializers.
9304         <obstack>: New member.
9305         (read_member_functions, read_struct_fields, read_baseclasses):
9306         Allocate on obstack.  Don't use cleanups.
9307         (read_one_struct_field, read_member_functions, read_struct_fields)
9308         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9309         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9310         (read_struct_type): Update.
9311
9312 2019-03-06  Tom Tromey  <tom@tromey.com>
9313
9314         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9315         * common/filestuff.h (make_cleanup_close): Don't declare.
9316         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9317         Remove.
9318
9319 2019-03-06  Tom Tromey  <tom@tromey.com>
9320
9321         * solib-aix.c: Use make_scope_exit.
9322
9323 2019-03-06  Tom Tromey  <tom@tromey.com>
9324
9325         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9326         Use make_scope_exit.
9327
9328 2019-03-06  Tom Tromey  <tom@tromey.com>
9329
9330         * solib-svr4.c (disable_probes_interface): Remove parameter.
9331         (svr4_handle_solib_event): Use make_scope_exit.
9332
9333 2019-03-06  Tom Tromey  <tom@tromey.com>
9334
9335         * remote.c (struct stop_reply_deleter): Remove.
9336         (stop_reply_up): Update.
9337         (struct stop_reply): Derive from notif_event.  Don't typedef.
9338         <regcache>: Now a std::vector.
9339         (stop_reply_xfree): Remove.
9340         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9341         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9342         (remote_target::discard_pending_stop_replies): Use delete.
9343         (remote_target::remote_parse_stop_reply): Update.
9344         (remote_target::process_stop_reply): Update.
9345         * remote-notif.h (struct notif_event): Add virtual destructor.
9346         Remove "dtr" member.
9347         (struct notif_client) <alloc_event>: Return a unique_ptr.
9348         (notif_event_xfree): Don't declare.
9349         (notif_event_up): New typedef.
9350         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9351         (notif_event_xfree, do_notif_event_xfree): Remove.
9352         (remote_notif_state_xfree): Update.
9353
9354 2019-03-06  Tom Tromey  <tom@tromey.com>
9355
9356         * infrun.c (displaced_step_clear_cleanup): Now a
9357         forward_scope_exit type.
9358         (displaced_step_prepare_throw): Update.
9359         (displaced_step_fixup): Update.
9360
9361 2019-03-06  Tom Tromey  <tom@tromey.com>
9362
9363         * inferior.h (class inferior): Update comment.
9364         * gdbthread.h (class thread_info): Update comment.
9365
9366 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9367             Tom Tromey  <tom@tromey.com>
9368
9369         * stabsread.h (struct stab_section_list): Remove.
9370         (coffstab_build_psymtabs): Update.
9371         * dbxread.c (symbuf_sections): Now a std::vector.
9372         (sect_idx): New global.
9373         (fill_symbuf): Update.
9374         (coffstab_build_psymtabs): Change type of stabsects parameter.
9375         Update.
9376         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9377         std::vector.
9378         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9379         (coff_locate_sections): Update.
9380         (coff_symfile_read): Remove cleanups.  Update.
9381         (init_stringtab): Add storage parameter.
9382         (free_stringtab, free_stringtab_cleanup): Remove.
9383         (init_lineno): Add storage parameter.
9384         (free_linetab, free_linetab_cleanup): Remove.
9385
9386 2019-03-06  Pedro Alves  <palves@redhat.com>
9387
9388         * linux-fork.c (fork_info::clobber_regs): Delete.
9389         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9390         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9391         comment.  Adjust.
9392         (scoped_switch_fork_info::scoped_switch_fork_info)
9393         (checkpoint_command, linux_fork_context): Adjust
9394         fork_save_infrun_state calls.
9395
9396 2019-03-06  Pedro Alves  <palves@redhat.com>
9397
9398         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9399         (inf_has_multiple_threads): Return 'bool' and rewrite using
9400         inferior_info::threads().
9401
9402 2019-03-06  Pedro Alves  <palves@redhat.com>
9403
9404         * linux-fork.c: Include <list>.
9405         (fork_list): Now a std::list instance.
9406         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9407         (forks_exist_p, find_last_fork): Adjust.
9408         (new_fork): Delete.
9409         (one_fork_p): New.
9410         (add_fork): Adjust.
9411         (free_fork): Delete, folded into fork_info::~fork_info().
9412         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9413         Adjust.
9414         (init_fork_list): Delete.
9415         (linux_fork_killall, linux_fork_mourn_inferior)
9416         (linux_fork_detach, info_checkpoints_command): Adjust.
9417         (_initialize_linux_fork): No longer call init_fork_list.
9418
9419 2019-03-06  Pedro Alves  <palves@redhat.com>
9420
9421         * linux-fork.c (new_fork): New, split out of ...
9422         (add_fork): ... this.  Return void.  Move "first fork" special
9423         case from here, to ...
9424         (checkpoint_command): ... here.
9425         * linux-linux.h (add_fork): Return void.
9426
9427 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9428
9429         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9430
9431 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9432             Chris January  <chris.january@arm.com>
9433             David Lecomber  <david.lecomber@arm.com>
9434
9435         * f-exp.y: New token, UNOP_INTRINSIC.
9436         (exp): New pattern using UNOP_INTRINSIC token.
9437         (f77_keywords): Add 'abs' keyword.
9438         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9439         (value_from_host_double): New function.
9440         (evaluate_subexp_f): Support UNOP_ABS.
9441
9442 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9443
9444         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9445         types.
9446
9447 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9448
9449         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9450         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9451         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9452
9453 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9454
9455         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9456
9457 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9458             Chris January  <chris.january@arm.com>
9459
9460         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9461         * f-exp.y: Define 'KIND' token.
9462         (exp): New pattern for KIND expressions.
9463         (ptype): Handle types with a kind extension.
9464         (direct_abs_decl): Extend to spot kind extensions.
9465         (f77_keywords): Add 'kind' to the list.
9466         (push_kind_type): New function.
9467         (convert_to_kind_type): New function.
9468         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9469         * parse.c (operator_length_standard): Likewise.
9470         * parser-defs.h (enum type_pieces): Add tp_kind.
9471         * std-operator.def: Add UNOP_KIND.
9472
9473 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9474
9475         * f-exp.y (f_parse): Set yydebug.
9476
9477 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9478
9479         * f-lang.c (evaluate_subexp_f): New function.
9480         (exp_descriptor_f): New global.
9481         (f_language_defn): Use exp_descriptor_f instead of
9482         exp_descriptor_standard.
9483
9484 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9485
9486         * f-exp.y (struct token): Add comments.
9487         (dot_ops): Remove uppercase versions and the end marker.
9488         (f77_keywords): Likewise.
9489         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9490         entries in the dot_ops array are case insensitive, and use
9491         strncasecmp to compare strings.  Also some whitespace cleanup in
9492         this area.  Similar for the f77_keywords array, except entries in
9493         this list might be case sensitive.
9494
9495 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9496
9497         * f-exp.y (struct f77_boolean_val): Add comments.
9498         (boolean_values): Remove uppercase versions, and end marker.
9499         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9500         and use strncasecmp to achieve case insensitivity.  Additionally,
9501         perform whitespace cleanup around this code.
9502
9503 2019-03-06  Tom Tromey  <tromey@adacore.com>
9504
9505         * remote-sim.c (gdbsim_target_open): Use result of
9506         gdb_argv::release.
9507
9508 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9509         Dirk Schubert  <dirk.schubert@arm.com>
9510         Chris January  <chris.january@arm.com>
9511
9512         * eval.c (evaluate_subexp_standard): Call Fortran argument
9513         wrapping logic.
9514         * f-lang.c (struct value): A value which can be passed into a
9515         Fortran function call.
9516         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9517         where appropriate.
9518         (struct type): Value ready for a Fortran function call.
9519         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9520         is needed.
9521         * f-lang.h (fortran_argument_convert): Declaration.
9522         (fortran_preserve_arg_pointer): Declaration.
9523         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9524
9525 2019-03-05  Tom Tromey  <tromey@adacore.com>
9526
9527         * python/py-prettyprint.c (print_string_repr): Remove #if.
9528         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9529
9530 2019-03-05  Tom Tromey  <tromey@adacore.com>
9531
9532         * target.c (the_dummy_target): Move later.  Change type to
9533         "dummy_target".
9534         (initialize_targets): Don't initialize the_dummy_target.
9535
9536 2019-03-05  Tom Tromey  <tromey@adacore.com>
9537
9538         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9539         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9540
9541 2019-03-05  Tom Tromey  <tromey@adacore.com>
9542
9543         * windows-nat.c (windows_nat_target::attach)
9544         (windows_nat_target::detach): Don't call gdb_flush.
9545         * valprint.c (generic_val_print, val_print, val_print_string):
9546         Don't call gdb_flush.
9547         * utils.c (defaulted_query): Don't call gdb_flush.
9548         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9549         * target.c (target_announce_detach): Don't call gdb_flush.
9550         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9551         * remote.c (extended_remote_target::attach): Don't call
9552         gdb_flush.
9553         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9554         * printcmd.c (do_examine): Don't call gdb_flush.
9555         (info_display_command): Don't call gdb_flush.
9556         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9557         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9558         * memattr.c (info_mem_command): Don't call gdb_flush.
9559         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9560         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9561         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9562         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9563         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9564         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9565         (gnu_nat_target::detach): Don't call gdb_flush.
9566         * f-valprint.c (f_val_print): Don't call gdb_flush.
9567         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9568         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9569         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9570         gdb_flush.
9571         * c-valprint.c (c_val_print): Don't call gdb_flush.
9572         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9573
9574 2019-03-05  Tom Tromey  <tromey@adacore.com>
9575
9576         * varobj.c (update_dynamic_varobj_children): Update.
9577         (install_default_visualizer): Use reset, not release.
9578         * value.c (set_internalvar): Update.
9579         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9580         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9581         ATTRIBUTE_UNUSED_RESULT.
9582
9583 2019-03-05  Tom Tromey  <tromey@adacore.com>
9584
9585         * remote.c (class scoped_remote_fd) <release>: Add
9586         ATTRIBUTE_UNUSED_RESULT.
9587
9588 2019-03-05  Tom Tromey  <tromey@adacore.com>
9589
9590         * macroexp.c (struct macro_buffer) <release>: Add
9591         ATTRIBUTE_UNUSED_RESULT.
9592
9593 2019-03-05  Tom Tromey  <tromey@adacore.com>
9594
9595         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9596         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9597         ATTRIBUTE_UNUSED_RESULT.
9598
9599 2019-03-05  Tom Tromey  <tromey@adacore.com>
9600
9601         * common/scoped_fd.h (class scoped_fd) <release>: Add
9602         ATTRIBUTE_UNUSED_RESULT.
9603
9604 2019-03-05  Tom Tromey  <tromey@adacore.com>
9605
9606         * parser-defs.h (struct parser_state) <release>: Add
9607         ATTRIBUTE_UNUSED_RESULT.
9608
9609 2019-03-05  Tom Tromey  <tromey@adacore.com>
9610
9611         * utils.h (class gdb_argv) <release>: Add
9612         ATTRIBUTE_UNUSED_RESULT.
9613         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9614
9615 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9616
9617         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9618         for-loop range, to avoid compiler warnings.
9619
9620         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9621         avoid compiler warnings about unused variables.
9622
9623         * NEWS: Mention end of support for native debugging on MS-Windows
9624         before XP.
9625
9626         PR gdb/24292
9627         * common/netstuff.c:
9628         * gdbserver/gdbreplay.c
9629         * gdbserver/remote-utils.c:
9630         * ser-tcp.c:
9631         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9632         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9633         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9634         'getaddrinfo' and 'freeaddrinfo' were not available before
9635         Windows XP, and mingw.org's MinGW headers by default define
9636         _WIN32_WINNT to 0x500.
9637
9638 2019-03-01  Gary Benson <gbenson@redhat.com>
9639
9640         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9641
9642 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9643             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9644
9645         PR gdb/8527
9646         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9647         set_sigint_trap, clear_sigint_trap.
9648
9649 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9650
9651         * target.c (target_detach): Clear the regcache and the
9652         frame cache.
9653
9654 2019-02-27  Pedro Alves  <palves@redhat.com>
9655
9656         * utils.c (set_screen_size): When we cap the height/width sizes,
9657         tweak the corresponding command variable to show "unlimited":
9658
9659 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9660             Pedro Alves  <palves@redhat.com>
9661
9662         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9663         before calling rl_set_screen_size.
9664
9665 2019-02-27  Tom Tromey  <tromey@adacore.com>
9666
9667         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9668         define.
9669         * python/py-value.c: Remove Python 2.4 workaround.
9670         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9671         workaround.
9672         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9673         Python 2.4 workaround.
9674         * python/python-internal.h: Remove Python 2.4 comment.
9675         (Py_ssize_t): Don't define.
9676         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9677         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9678         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9679         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9680         * python/python.c (do_start_initialization): Remove Python 2.4
9681         workaround.
9682         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9683         (print_children): Remove Python 2.4 workaround.
9684         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9685         workaround.
9686         (CHARBUFFERPROC_NAME): Remove.
9687         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9688         Python 2.4 workaround.
9689
9690 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9691
9692         * NEWS: Note minimum Python version.
9693
9694 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9695
9696         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9697         code from these functions.  Remove corresponding ifdefs.  Use
9698         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9699         Remove gotos and target of gotos.
9700         (infpy_search_memory): Likewise.
9701
9702 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9703
9704         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9705         (hppa_gdbarch_init): Don't register deleted functions with
9706         gdbarch.
9707
9708 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9709
9710         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9711         (h8300_unwind_sp): Delete.
9712         (h8300_dummy_id): Delete.
9713         (h8300_gdbarch_init): Don't register deleted functions with
9714         gdbarch.
9715
9716 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9717
9718         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9719         (ft32_unwind_pc): Delete.
9720         (ft32_unwind_sp): Delete.
9721         (ft32_gdbarch_init): Don't register deleted functions with
9722         gdbarch.
9723
9724 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9725
9726         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9727         (frv_unwind_pc): Delete.
9728         (frv_unwind_sp): Delete.
9729         (frv_gdbarch_init): Don't register deleted functions with
9730         gdbarch.
9731
9732 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9733
9734         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9735         (riscv_unwind_pc): Delete.
9736         (riscv_unwind_sp): Delete.
9737         (riscv_gdbarch_init): Don't register deleted functions with
9738         gdbarch.
9739
9740 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9741
9742         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9743         (csky_unwind_pc): Delete.
9744         (csky_unwind_sp): Delete.
9745         (csky_gdbarch_init): Don't register deleted functions with
9746         gdbarch.
9747
9748 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9749
9750         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9751         (cris_unwind_pc): Delete.
9752         (cris_unwind_sp): Delete.
9753         (cris_gdbarch_init): Don't register deleted functions with
9754         gdbarch.
9755
9756 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9757
9758         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9759         (bfin_unwind_pc): Delete.
9760         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9761
9762 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9763
9764         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9765         (arm_unwind_pc): Delete.
9766         (arm_unwind_sp): Delete.
9767         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9768
9769 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9770
9771         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9772         (arc_unwind_pc): Delete.
9773         (arc_unwind_sp): Delete.
9774         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9775
9776 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9777
9778         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9779         (alpha_unwind_pc): Delete.
9780         (alpha_gdbarch_init): Don't register deleted functions with
9781         gdbarch.
9782
9783 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9784
9785         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9786         (aarch64_unwind_pc): Delete.
9787         (aarch64_unwind_sp): Delete.
9788         (aarch64_gdbarch_init): Don't register deleted functions with
9789         gdbarch.
9790
9791 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9792
9793         * gdbtypes.c (type_align): Don't consider static members when
9794         computing structure alignment.
9795
9796 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9797
9798         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9799         return 0 for other types.
9800         * arch-utils.c (default_type_align): Always return 0.
9801         * gdbarch.h: Regenerate.
9802         * gdbarch.sh (type_align): Extend comment.
9803         * gdbtypes.c (type_align): Add additional comments, always call
9804         gdbarch_type_align before applying the default rules.
9805         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9806         generic code will then apply a suitable default.
9807         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9808         types, return 0 for other types.
9809
9810 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9811
9812         * NEWS: Create a new section for the next release branch.
9813         Rename the section of the current branch, now that it has
9814         been cut.
9815
9816 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9817
9818         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9819         * version.in: Bump version to 8.3.50.DATE-git.
9820
9821 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9822
9823         * aix-thread.c (ptid_cmp): Remove unused variable.
9824         (get_signaled_thread): Likewise.
9825         (store_regs_user_thread): Likewise.
9826         (store_regs_kernel_thread): Likewise.
9827         (fetch_regs_kernel_thread): Remove shadowed variable.
9828
9829 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9830
9831         * features/riscv/32bit-cpu.xml: Add register numbers.
9832         * features/riscv/32bit-fpu.c: Regenerate.
9833         * features/riscv/32bit-fpu.xml: Add register numbers.
9834         * features/riscv/64bit-cpu.xml: Add register numbers.
9835         * features/riscv/64bit-fpu.c: Regenerate.
9836         * features/riscv/64bit-fpu.xml: Add register numbers.
9837
9838 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9839
9840         * NEWS: Mention two argument form of gdb.Value constructor.
9841         * python/py-value.c (convert_buffer_and_type_to_value): New
9842         function.
9843         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9844         Add support for handling an optional second argument.  Call
9845         convert_buffer_and_type_to_value as appropriate.
9846         * python/python-internal.h (Py_buffer_deleter): New struct.
9847         (Py_buffer_up): New typedef.
9848
9849 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9850
9851         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9852         instead of releasing ownership.
9853
9854 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9855
9856         * dwarf2read.c (open_and_init_dwp_file): Call
9857         elf_numsections instead of bfd_count_sections to initialize
9858         dwp_file->num_sections.
9859
9860 2019-02-25  Tom Tromey  <tromey@adacore.com>
9861
9862         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9863
9864 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9865
9866         * gcore.in: Add '--readnever' option when invoking GDB.
9867
9868 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9869
9870         * MAINTAINERS: Update my email address.
9871
9872 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9873
9874         * build-id.c (build_id_to_debug_bfd_1): New function.
9875         (build_id_to_debug_bfd): Look for separate debug file in
9876         sysroot.
9877
9878 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9879
9880         * gdbarch.sh: Update the copyright year range that is placed into
9881         generated files.
9882
9883 2019-02-22  Keith Seitz  <keiths@redhat.com>
9884
9885         PR symtab/23853
9886         * linespec.c (create_sals_line_offset): Search for the default
9887         symtab's filename instead of its fullname.
9888
9889 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9890
9891         * NEWS: Update style defaults.
9892
9893 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9894
9895         * main.c (captured_main_1): Disable styling in batch mode.
9896
9897 2019-02-20  Tom Tromey  <tom@tromey.com>
9898
9899         * symtab.c (symtab_symbol_info): Fix typos.
9900
9901 2019-02-20  Tom Tromey  <tromey@adacore.com>
9902
9903         * findcmd.c (_initialize_mem_search): Use upper case for
9904         metasyntactic variables.
9905
9906 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9907
9908         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9909         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9910
9911 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9912
9913         * top.h (source_file_name): Change to std::string.
9914         * top.c (source_file_name): Likewise.
9915         (command_line_input): Adjust.
9916         * cli/cli-script.c (script_from_file): Adjust.
9917
9918 2019-02-19  Tom Tromey  <tromey@adacore.com>
9919
9920         * ravenscar-thread.c
9921         (ravenscar_thread_target::update_thread_list): Don't call
9922         ada_build_task_list.
9923         * ada-lang.h (ada_build_task_list): Don't declare.
9924         * ada-tasks.c (struct ada_tasks_inferior_data)
9925         <task_list_valid_p>: Now bool.
9926         (read_known_tasks, ada_task_list_changed)
9927         (ada_tasks_invalidate_inferior_data): Update.
9928         (read_known_tasks_array): Return bool.
9929         (read_known_tasks_list): Likewise.
9930         (read_known_tasks): Return void.
9931         (ada_build_task_list): Now static.
9932
9933 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9934
9935         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9936         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9937
9938 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9939
9940         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9941         variant for ada_tasks_pspace_data_handle and
9942         ada_tasks_inferior_data_handle.
9943         (ada_tasks_pspace_data_cleanup): New function.
9944         (ada_tasks_inferior_data_cleanup): New function.
9945
9946 2019-02-17  Tom Tromey  <tom@tromey.com>
9947
9948         * macrotab.h (macro_source_fullname): Return a std::string.
9949         * macrotab.c (macro_include, check_for_redefinition)
9950         (macro_undef, macro_lookup_definition, foreach_macro)
9951         (foreach_macro_in_scope): Update.
9952         (macro_source_fullname): Return a std::string.
9953         * macrocmd.c (show_pp_source_pos): Update.
9954
9955 2019-02-17  Tom Tromey  <tom@tromey.com>
9956
9957         * macrocmd.c (show_pp_source_pos): Style the file names.
9958
9959 2019-02-17  Tom Tromey  <tom@tromey.com>
9960
9961         PR tui/24197:
9962         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9963
9964 2019-02-17  Tom Tromey  <tom@tromey.com>
9965
9966         * ada-lang.c (user_select_syms): Use filtered printing.
9967         * utils.c (wrap_style): New global.
9968         (desired_style): Remove.
9969         (emit_style_escape): Add stream parameter.
9970         (set_output_style, reset_terminal_style, prompt_for_continue):
9971         Update.
9972         (flush_wrap_buffer): Only flush gdb_stdout.
9973         (wrap_here): Set wrap_style.
9974         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9975         treat escape sequences as a character.  Change when wrap buffer is
9976         flushed.
9977         (fputs_styled): Do not set the output style when the default is
9978         requested.
9979         * ui-style.h (struct ui_file_style) <is_default>: New method.
9980         * source.c (print_source_lines_base): Emit escape sequences in one
9981         piece.
9982
9983 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9984
9985         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9986         integers and enumeration types.
9987
9988 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9989
9990         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9991         instead of lookup_symbol_in_language
9992         (do_exact_match): New function.
9993         (ada_get_symbol_name_matcher): Return do_exact_match when
9994         doing a verbatim match.
9995
9996 2019-02-15  Tom Tromey  <tromey@adacore.com>
9997
9998         * ravenscar-thread.c (ravenscar_thread_target::resume)
9999         (ravenscar_thread_target::wait): Special case wildcard requests.
10000
10001 2019-02-15  Tom Tromey  <tromey@adacore.com>
10002
10003         * ravenscar-thread.c (base_ptid): Remove.
10004         (struct ravenscar_thread_target) <close>: New method.
10005         <m_base_ptid>: New member.
10006         <update_inferior_ptid, active_task, task_is_currently_active,
10007         runtime_initialized>: Declare methods.
10008         <ravenscar_thread_target>: Add constructor.
10009         (ravenscar_thread_target::task_is_currently_active)
10010         (ravenscar_thread_target::update_inferior_ptid)
10011         (ravenscar_runtime_initialized): Rename.  Now methods.
10012         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10013         (ravenscar_thread_target::update_thread_list): Update.
10014         (ravenscar_thread_target::active_task): Now method.
10015         (ravenscar_thread_target::store_registers)
10016         (ravenscar_thread_target::prepare_to_store)
10017         (ravenscar_thread_target::prepare_to_store)
10018         (ravenscar_thread_target::mourn_inferior): Update.
10019         (ravenscar_inferior_created): Use "new" to create target.
10020         (ravenscar_thread_target::get_ada_task_ptid): Update.
10021         (_initialize_ravenscar): Don't initialize base_ptid.
10022         (ravenscar_ops): Remove global.
10023
10024 2019-02-15  Tom Tromey  <tromey@adacore.com>
10025
10026         * target.h (push_target): Declare new overload.
10027         * target.c (push_target): New overload, taking an rvalue reference.
10028         * remote.c (remote_target::open_1): Use push_target overload.
10029         * corelow.c (core_target_open): Use push_target overload.
10030
10031 2019-02-15  Tom Tromey  <tromey@adacore.com>
10032
10033         * ravenscar-thread.c (is_ravenscar_task)
10034         (ravenscar_task_is_currently_active): Return bool.
10035         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10036         (_initialize_ravenscar): Remove "(void)".
10037         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10038         Return bool.
10039
10040 2019-02-15  Tom Tromey  <tromey@adacore.com>
10041
10042         * ravenscar-thread.c (ravenscar_runtime_initializer)
10043         (has_ravenscar_runtime, get_running_thread_id)
10044         (ravenscar_thread_target::resume): Fix indentation.
10045
10046 2019-02-15  Tom Tromey  <tromey@adacore.com>
10047
10048         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10049         from ravenscar_arch_ops.
10050         (sparc_ravenscar_ops::fetch_registers)
10051         (sparc_ravenscar_ops::store_registers): Now methods.
10052         (sparc_ravenscar_prepare_to_store): Remove.
10053         (sparc_ravenscar_ops): Redefine.
10054         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10055         methods and destructor.  Remove members.
10056         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10057         (ravenscar_thread_target::store_registers)
10058         (ravenscar_thread_target::prepare_to_store): Update.
10059         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10060         Remove.
10061         (struct ppc_ravenscar_powerpc_ops): Derive from
10062         ravenscar_arch_ops.
10063         (ppc_ravenscar_powerpc_ops::fetch_registers)
10064         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10065         (ppc_ravenscar_powerpc_ops): Redefine.
10066         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10067         (ppc_ravenscar_e500_ops::fetch_registers)
10068         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10069         (ppc_ravenscar_e500_ops): Redefine.
10070         * aarch64-ravenscar-thread.c
10071         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10072         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10073         (aarch64_ravenscar_fetch_registers)
10074         (aarch64_ravenscar_store_registers): Now methods.
10075         (aarch64_ravenscar_ops): Redefine.
10076
10077 2019-02-15  Tom Tromey  <tromey@adacore.com>
10078
10079         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10080         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10081         (ravenscar_thread_target::stopped_by_watchpoint)
10082         (ravenscar_thread_target::stopped_data_address)
10083         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10084
10085 2019-02-15  Tom Tromey  <tromey@adacore.com>
10086
10087         * ravenscar-thread.c: Fix some typos.
10088
10089 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10090             Tom Tromey  <tromey@adacore.com>
10091
10092         * ada-lang.c (ada_exception_sal): Change addr_string to a
10093         std::string.
10094         (create_ada_exception_catchpoint): Update.
10095
10096 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10097             Tom Tromey  <tromey@adacore.com>
10098
10099         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10100         (bp_location_ops): Remove.
10101         (base_breakpoint_allocate_location): Update.
10102         (free_bp_location): Update.
10103         * ada-lang.c (class ada_catchpoint_location)
10104         <ada_catchpoint_location>: Remove ops parameter.
10105         (ada_catchpoint_location_dtor): Remove.
10106         (ada_catchpoint_location_ops): Remove.
10107         (allocate_location_exception): Update.
10108         * breakpoint.h (struct bp_location_ops): Remove.
10109         (class bp_location) <bp_location>: Remove bp_location_ops
10110         parameter.
10111         <~bp_location>: Add destructor.
10112         <ops>: Remove.
10113
10114 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10115             Pedro Alves  <palves@redhat.com>
10116
10117         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10118         'PATH_MAX'.
10119
10120 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10121             Samuel Thibault  <samuel.thibault@gnu.org>
10122             Thomas Schwinge  <thomas@codesourcery.com>
10123
10124         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10125         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10126
10127 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10128
10129         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10130         (check_empty): Use "const char *".
10131
10132         * gnu-nat.c (gnu_nat_target::detach): Instead of
10133         'detach_inferior (pid)' call
10134         'detach_inferior (find_inferior_pid (pid))'.
10135
10136         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10137         'nat/fork-inferior.o'.
10138         * gnu-nat.c: #include "nat/fork-inferior.h".
10139
10140         * gnu-nat.c (gnu_nat_target::detach): Instead of
10141         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10142         * gnu-nat.h: #include "inf-child.h".
10143         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10144         'i386_gnu_nat_target::fetch_registers'.
10145         (gnu_store_registers): Rename/move to
10146         'i386_gnu_nat_target::store_registers'.
10147
10148         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10149         * gnu-nat.h (mach_thread_info): New function.
10150         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10151
10152         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10153
10154 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10155
10156         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10157
10158 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10159
10160         * windows-nat.c (windows_add_thread): Add new parameter
10161         "main_thread_p" with default value set to false.  Update
10162         function documentation as well as all callers.
10163         (windows_delete_thread): Likewise.
10164         (fake_create_process): Update call to windows_add_thread.
10165         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10166         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10167         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10168         call to windows_delete_thread.
10169
10170 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10171
10172         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10173
10174 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10175
10176         * symfile.c (find_separate_debug_file): Use canonical path of
10177         sysroot with child_path instead of gdb_sysroot if it is valid.
10178
10179 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10180
10181         * symfile.c (find_separate_debug_file): Use child_path to
10182         determine if an object file is under a sysroot.
10183
10184 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10185
10186         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10187         unittests/child-path-selftests.c.
10188         * common/pathstuff.c (child_path): New function.
10189         * common/pathstuff.h (child_path): New prototype.
10190         * unittests/child-path-selftests.c: New file.
10191
10192 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10193
10194         * symfile.c (find_separate_debug_file): Look for separate debug
10195         files in debug directories under the sysroot.
10196
10197 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10198
10199         * symtab.h (struct minimal_symbol data_p): New const method.
10200         (struct minimal_symbol text_p): Likewise.
10201         * symtab.c (output_source_filename): Use file name style
10202         to print file name.
10203         (print_symbol_info): Likewise.
10204         (print_msymbol_info): Use address style to print addresses.
10205         Use function name style to print executable text symbols.
10206         (expand_symtab_containing_pc): Use data_p.
10207         (find_pc_sect_compunit_symtab): Likewise.
10208
10209 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10210
10211         * breakpoint.c (describe_other_breakpoints): Use address style
10212         to print addresses.
10213         (say_where): Likewise.
10214
10215 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10216
10217         * ada-typeprint.c (print_func_type): Print function name
10218         style to print function name.
10219         * c-typeprint.c (c_print_type_1): Likewise.
10220
10221 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10222
10223         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10224         for execve.
10225
10226 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10227
10228         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10229         type_stack.
10230
10231 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10232
10233         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10234         TYPE_CODE_REF types.
10235
10236 2019-02-08  Jim Wilson  <jimw@sifive.com>
10237
10238         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10239         (riscv_linux_fregset): New.
10240         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10241
10242 2019-02-07  Tom Tromey  <tom@tromey.com>
10243
10244         * thread.c (thread_cancel_execution_command): Update.
10245         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10246         methods.
10247         (struct thread_fsm_ops): Remove.
10248         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10249         (thread_fsm_should_stop, thread_fsm_return_value)
10250         (thread_fsm_set_finished, thread_fsm_finished_p)
10251         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10252         Don't declare.
10253         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10254         * infrun.c (clear_proceed_status_thread)
10255         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10256         (print_stop_event): Update.
10257         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10258         Add constructor.
10259         (step_command_fsm_ops): Remove.
10260         (new_step_command_fsm): Remove.
10261         (step_1): Update.
10262         (step_command_fsm::should_stop): Rename from
10263         step_command_fsm_should_stop.
10264         (step_command_fsm::clean_up): Rename from
10265         step_command_fsm_clean_up.
10266         (step_command_fsm::do_async_reply_reason): Rename from
10267         step_command_fsm_async_reply_reason.
10268         (struct until_next_fsm): Inherit from thread_fsm.  Add
10269         constructor.
10270         (until_next_fsm_ops): Remove.
10271         (new_until_next_fsm): Remove.
10272         (until_next_fsm::should_stop): Rename from
10273         until_next_fsm_should_stop.
10274         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10275         (until_next_fsm::do_async_reply_reason): Rename from
10276         until_next_fsm_async_reply_reason.
10277         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10278         constructor.  Change type of breakpoint.
10279         (finish_command_fsm_ops): Remove.
10280         (new_finish_command_fsm): Remove.
10281         (finish_command_fsm::should_stop): Rename from
10282         finish_command_fsm_should_stop.
10283         (finish_command_fsm::clean_up): Rename from
10284         finish_command_fsm_clean_up.
10285         (finish_command_fsm::return_value): Rename from
10286         finish_command_fsm_return_value.
10287         (finish_command_fsm::do_async_reply_reason): Rename from
10288         finish_command_fsm_async_reply_reason.
10289         (finish_command): Update.
10290         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10291         Add constructor.
10292         (call_thread_fsm_ops): Remove.
10293         (call_thread_fsm::call_thread_fsm): Rename from
10294         new_call_thread_fsm.
10295         (call_thread_fsm::should_stop): Rename from
10296         call_thread_fsm_should_stop.
10297         (call_thread_fsm::should_notify_stop): Rename from
10298         call_thread_fsm_should_notify_stop.
10299         (run_inferior_call, call_function_by_hand_dummy): Update.
10300         * cli/cli-interp.c (should_print_stop_to_console): Update.
10301         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10302         Add constructor.  Change type of location_breakpoint,
10303         caller_breakpoint.
10304         (until_break_fsm_ops): Remove.
10305         (new_until_break_fsm): Remove.
10306         (until_break_fsm::should_stop): Rename from
10307         until_break_fsm_should_stop.
10308         (until_break_fsm::clean_up): Rename from
10309         until_break_fsm_clean_up.
10310         (until_break_fsm::do_async_reply_reason): Rename from
10311         until_break_fsm_async_reply_reason.
10312         (until_break_command): Update.
10313         * thread-fsm.c: Remove.
10314         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10315
10316 2019-02-07  Tom Tromey  <tom@tromey.com>
10317
10318         * yy-remap.h: Add include guard.
10319         * xtensa-tdep.h: Add include guard.
10320         * xcoffread.h: Rename include guard.
10321         * varobj-iter.h: Add include guard.
10322         * tui/tui.h: Rename include guard.
10323         * tui/tui-winsource.h: Rename include guard.
10324         * tui/tui-wingeneral.h: Rename include guard.
10325         * tui/tui-windata.h: Rename include guard.
10326         * tui/tui-win.h: Rename include guard.
10327         * tui/tui-stack.h: Rename include guard.
10328         * tui/tui-source.h: Rename include guard.
10329         * tui/tui-regs.h: Rename include guard.
10330         * tui/tui-out.h: Rename include guard.
10331         * tui/tui-layout.h: Rename include guard.
10332         * tui/tui-io.h: Rename include guard.
10333         * tui/tui-hooks.h: Rename include guard.
10334         * tui/tui-file.h: Rename include guard.
10335         * tui/tui-disasm.h: Rename include guard.
10336         * tui/tui-data.h: Rename include guard.
10337         * tui/tui-command.h: Rename include guard.
10338         * tic6x-tdep.h: Add include guard.
10339         * target/waitstatus.h: Rename include guard.
10340         * target/wait.h: Rename include guard.
10341         * target/target.h: Rename include guard.
10342         * target/resume.h: Rename include guard.
10343         * target-float.h: Rename include guard.
10344         * stabsread.h: Add include guard.
10345         * rs6000-tdep.h: Add include guard.
10346         * riscv-fbsd-tdep.h: Add include guard.
10347         * regformats/regdef.h: Rename include guard.
10348         * record.h: Rename include guard.
10349         * python/python.h: Rename include guard.
10350         * python/python-internal.h: Rename include guard.
10351         * python/py-stopevent.h: Rename include guard.
10352         * python/py-ref.h: Rename include guard.
10353         * python/py-record.h: Rename include guard.
10354         * python/py-record-full.h: Rename include guard.
10355         * python/py-record-btrace.h: Rename include guard.
10356         * python/py-instruction.h: Rename include guard.
10357         * python/py-events.h: Rename include guard.
10358         * python/py-event.h: Rename include guard.
10359         * procfs.h: Add include guard.
10360         * proc-utils.h: Add include guard.
10361         * p-lang.h: Add include guard.
10362         * or1k-tdep.h: Rename include guard.
10363         * observable.h: Rename include guard.
10364         * nto-tdep.h: Rename include guard.
10365         * nat/x86-linux.h: Rename include guard.
10366         * nat/x86-linux-dregs.h: Rename include guard.
10367         * nat/x86-gcc-cpuid.h: Add include guard.
10368         * nat/x86-dregs.h: Rename include guard.
10369         * nat/x86-cpuid.h: Rename include guard.
10370         * nat/ppc-linux.h: Rename include guard.
10371         * nat/mips-linux-watch.h: Rename include guard.
10372         * nat/linux-waitpid.h: Rename include guard.
10373         * nat/linux-ptrace.h: Rename include guard.
10374         * nat/linux-procfs.h: Rename include guard.
10375         * nat/linux-osdata.h: Rename include guard.
10376         * nat/linux-nat.h: Rename include guard.
10377         * nat/linux-namespaces.h: Rename include guard.
10378         * nat/linux-btrace.h: Rename include guard.
10379         * nat/glibc_thread_db.h: Rename include guard.
10380         * nat/gdb_thread_db.h: Rename include guard.
10381         * nat/gdb_ptrace.h: Rename include guard.
10382         * nat/fork-inferior.h: Rename include guard.
10383         * nat/amd64-linux-siginfo.h: Rename include guard.
10384         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10385         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10386         * nat/aarch64-linux.h: Rename include guard.
10387         * nat/aarch64-linux-hw-point.h: Rename include guard.
10388         * mn10300-tdep.h: Add include guard.
10389         * mips-linux-tdep.h: Add include guard.
10390         * mi/mi-parse.h: Rename include guard.
10391         * mi/mi-out.h: Rename include guard.
10392         * mi/mi-main.h: Rename include guard.
10393         * mi/mi-interp.h: Rename include guard.
10394         * mi/mi-getopt.h: Rename include guard.
10395         * mi/mi-console.h: Rename include guard.
10396         * mi/mi-common.h: Rename include guard.
10397         * mi/mi-cmds.h: Rename include guard.
10398         * mi/mi-cmd-break.h: Rename include guard.
10399         * m2-lang.h: Add include guard.
10400         * location.h: Rename include guard.
10401         * linux-record.h: Rename include guard.
10402         * linux-nat.h: Add include guard.
10403         * linux-fork.h: Add include guard.
10404         * i386-darwin-tdep.h: Rename include guard.
10405         * hppa-linux-offsets.h: Add include guard.
10406         * guile/guile.h: Rename include guard.
10407         * guile/guile-internal.h: Rename include guard.
10408         * gnu-nat.h: Rename include guard.
10409         * gdb-stabs.h: Rename include guard.
10410         * frv-tdep.h: Add include guard.
10411         * f-lang.h: Add include guard.
10412         * event-loop.h: Add include guard.
10413         * darwin-nat.h: Rename include guard.
10414         * cp-abi.h: Rename include guard.
10415         * config/sparc/nm-sol2.h: Rename include guard.
10416         * config/nm-nto.h: Rename include guard.
10417         * config/nm-linux.h: Add include guard.
10418         * config/i386/nm-i386gnu.h: Rename include guard.
10419         * config/djgpp/nl_types.h: Rename include guard.
10420         * config/djgpp/langinfo.h: Rename include guard.
10421         * compile/gcc-cp-plugin.h: Add include guard.
10422         * compile/gcc-c-plugin.h: Add include guard.
10423         * compile/compile.h: Rename include guard.
10424         * compile/compile-object-run.h: Rename include guard.
10425         * compile/compile-object-load.h: Rename include guard.
10426         * compile/compile-internal.h: Rename include guard.
10427         * compile/compile-cplus.h: Rename include guard.
10428         * compile/compile-c.h: Rename include guard.
10429         * common/xml-utils.h: Rename include guard.
10430         * common/x86-xstate.h: Rename include guard.
10431         * common/version.h: Rename include guard.
10432         * common/vec.h: Rename include guard.
10433         * common/tdesc.h: Rename include guard.
10434         * common/selftest.h: Rename include guard.
10435         * common/scoped_restore.h: Rename include guard.
10436         * common/scoped_mmap.h: Rename include guard.
10437         * common/scoped_fd.h: Rename include guard.
10438         * common/safe-iterator.h: Rename include guard.
10439         * common/run-time-clock.h: Rename include guard.
10440         * common/refcounted-object.h: Rename include guard.
10441         * common/queue.h: Rename include guard.
10442         * common/ptid.h: Rename include guard.
10443         * common/print-utils.h: Rename include guard.
10444         * common/preprocessor.h: Rename include guard.
10445         * common/pathstuff.h: Rename include guard.
10446         * common/observable.h: Rename include guard.
10447         * common/netstuff.h: Rename include guard.
10448         * common/job-control.h: Rename include guard.
10449         * common/host-defs.h: Rename include guard.
10450         * common/gdb_wait.h: Rename include guard.
10451         * common/gdb_vecs.h: Rename include guard.
10452         * common/gdb_unlinker.h: Rename include guard.
10453         * common/gdb_unique_ptr.h: Rename include guard.
10454         * common/gdb_tilde_expand.h: Rename include guard.
10455         * common/gdb_sys_time.h: Rename include guard.
10456         * common/gdb_string_view.h: Rename include guard.
10457         * common/gdb_splay_tree.h: Rename include guard.
10458         * common/gdb_setjmp.h: Rename include guard.
10459         * common/gdb_ref_ptr.h: Rename include guard.
10460         * common/gdb_optional.h: Rename include guard.
10461         * common/gdb_locale.h: Rename include guard.
10462         * common/gdb_assert.h: Rename include guard.
10463         * common/filtered-iterator.h: Rename include guard.
10464         * common/filestuff.h: Rename include guard.
10465         * common/fileio.h: Rename include guard.
10466         * common/environ.h: Rename include guard.
10467         * common/common-utils.h: Rename include guard.
10468         * common/common-types.h: Rename include guard.
10469         * common/common-regcache.h: Rename include guard.
10470         * common/common-inferior.h: Rename include guard.
10471         * common/common-gdbthread.h: Rename include guard.
10472         * common/common-exceptions.h: Rename include guard.
10473         * common/common-defs.h: Rename include guard.
10474         * common/common-debug.h: Rename include guard.
10475         * common/cleanups.h: Rename include guard.
10476         * common/buffer.h: Rename include guard.
10477         * common/btrace-common.h: Rename include guard.
10478         * common/break-common.h: Rename include guard.
10479         * cli/cli-utils.h: Rename include guard.
10480         * cli/cli-style.h: Rename include guard.
10481         * cli/cli-setshow.h: Rename include guard.
10482         * cli/cli-script.h: Rename include guard.
10483         * cli/cli-interp.h: Rename include guard.
10484         * cli/cli-decode.h: Rename include guard.
10485         * cli/cli-cmds.h: Rename include guard.
10486         * charset-list.h: Add include guard.
10487         * buildsym-legacy.h: Rename include guard.
10488         * bfin-tdep.h: Add include guard.
10489         * ax.h: Rename include guard.
10490         * arm-linux-tdep.h: Add include guard.
10491         * arm-fbsd-tdep.h: Add include guard.
10492         * arch/xtensa.h: Rename include guard.
10493         * arch/tic6x.h: Add include guard.
10494         * arch/i386.h: Add include guard.
10495         * arch/arm.h: Rename include guard.
10496         * arch/arm-linux.h: Rename include guard.
10497         * arch/arm-get-next-pcs.h: Rename include guard.
10498         * arch/amd64.h: Add include guard.
10499         * arch/aarch64-insn.h: Rename include guard.
10500         * arch-utils.h: Rename include guard.
10501         * annotate.h: Add include guard.
10502         * amd64-darwin-tdep.h: Rename include guard.
10503         * aarch64-linux-tdep.h: Add include guard.
10504         * aarch64-fbsd-tdep.h: Add include guard.
10505         * aarch32-linux-nat.h: Add include guard.
10506
10507 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10508
10509         * macrotab.c (macro_define_internal): New function that
10510         factorizes macro_define_object_internal and macro_define_function
10511         code.
10512         (macro_define_object_internal): Use macro_define_internal.
10513         (macro_define_function): Likewise.
10514
10515 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10516
10517         * macrocmd.c (extract_identifier): Return
10518         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10519         callers.
10520
10521 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10522
10523         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10524
10525 2019-02-05  Tom Tromey  <tom@tromey.com>
10526
10527         * target.c (target_stack::unpush): Move assertion earlier.
10528
10529 2019-01-30  Tom Tromey  <tom@tromey.com>
10530
10531         PR python/23615:
10532         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10533         (gdbpy_parse_and_eval): Likewise.
10534         * python/python-internal.h (gdbpy_allow_threads): New class.
10535
10536 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10537
10538         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10539         (aarch64_fbsd_fpregmap): Move earlier.
10540         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10541         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10542         instead of individual calls to trad_frame_set_reg_addr.
10543         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10544         earlier.
10545         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10546         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10547         instead of individual calls to trad_frame_set_reg_addr.
10548
10549 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10550
10551         * CONTRIBUTE: Replace contribution list with wiki link.
10552
10553 2019-01-25  Tom Tromey  <tom@tromey.com>
10554
10555         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10556
10557 2019-01-25  Tom Tromey  <tom@tromey.com>
10558
10559         * xtensa-linux-nat.c: Fix common/ includes.
10560         * xml-support.h: Fix common/ includes.
10561         * xml-support.c: Fix common/ includes.
10562         * x86-linux-nat.c: Fix common/ includes.
10563         * windows-nat.c: Fix common/ includes.
10564         * varobj.h: Fix common/ includes.
10565         * varobj.c: Fix common/ includes.
10566         * value.c: Fix common/ includes.
10567         * valops.c: Fix common/ includes.
10568         * utils.c: Fix common/ includes.
10569         * unittests/xml-utils-selftests.c: Fix common/ includes.
10570         * unittests/utils-selftests.c: Fix common/ includes.
10571         * unittests/unpack-selftests.c: Fix common/ includes.
10572         * unittests/tracepoint-selftests.c: Fix common/ includes.
10573         * unittests/style-selftests.c: Fix common/ includes.
10574         * unittests/string_view-selftests.c: Fix common/ includes.
10575         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10576         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10577         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10578         * unittests/rsp-low-selftests.c: Fix common/ includes.
10579         * unittests/parse-connection-spec-selftests.c: Fix common/
10580         includes.
10581         * unittests/optional-selftests.c: Fix common/ includes.
10582         * unittests/offset-type-selftests.c: Fix common/ includes.
10583         * unittests/observable-selftests.c: Fix common/ includes.
10584         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10585         * unittests/memrange-selftests.c: Fix common/ includes.
10586         * unittests/memory-map-selftests.c: Fix common/ includes.
10587         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10588         * unittests/function-view-selftests.c: Fix common/ includes.
10589         * unittests/environ-selftests.c: Fix common/ includes.
10590         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10591         * unittests/common-utils-selftests.c: Fix common/ includes.
10592         * unittests/cli-utils-selftests.c: Fix common/ includes.
10593         * unittests/array-view-selftests.c: Fix common/ includes.
10594         * ui-file.c: Fix common/ includes.
10595         * tui/tui-io.c: Fix common/ includes.
10596         * tracepoint.h: Fix common/ includes.
10597         * tracepoint.c: Fix common/ includes.
10598         * tracefile-tfile.c: Fix common/ includes.
10599         * top.h: Fix common/ includes.
10600         * top.c: Fix common/ includes.
10601         * thread.c: Fix common/ includes.
10602         * target/waitstatus.h: Fix common/ includes.
10603         * target/waitstatus.c: Fix common/ includes.
10604         * target.h: Fix common/ includes.
10605         * target.c: Fix common/ includes.
10606         * target-memory.c: Fix common/ includes.
10607         * target-descriptions.c: Fix common/ includes.
10608         * symtab.h: Fix common/ includes.
10609         * symfile.c: Fix common/ includes.
10610         * stap-probe.c: Fix common/ includes.
10611         * spu-linux-nat.c: Fix common/ includes.
10612         * sparc-nat.c: Fix common/ includes.
10613         * source.c: Fix common/ includes.
10614         * solib.c: Fix common/ includes.
10615         * solib-target.c: Fix common/ includes.
10616         * ser-unix.c: Fix common/ includes.
10617         * ser-tcp.c: Fix common/ includes.
10618         * ser-pipe.c: Fix common/ includes.
10619         * ser-base.c: Fix common/ includes.
10620         * selftest-arch.c: Fix common/ includes.
10621         * s12z-tdep.c: Fix common/ includes.
10622         * rust-exp.y: Fix common/ includes.
10623         * rs6000-aix-tdep.c: Fix common/ includes.
10624         * riscv-tdep.c: Fix common/ includes.
10625         * remote.c: Fix common/ includes.
10626         * remote-notif.h: Fix common/ includes.
10627         * remote-fileio.h: Fix common/ includes.
10628         * remote-fileio.c: Fix common/ includes.
10629         * regcache.h: Fix common/ includes.
10630         * regcache.c: Fix common/ includes.
10631         * record-btrace.c: Fix common/ includes.
10632         * python/python.c: Fix common/ includes.
10633         * python/py-type.c: Fix common/ includes.
10634         * python/py-inferior.c: Fix common/ includes.
10635         * progspace.h: Fix common/ includes.
10636         * producer.c: Fix common/ includes.
10637         * procfs.c: Fix common/ includes.
10638         * proc-api.c: Fix common/ includes.
10639         * printcmd.c: Fix common/ includes.
10640         * ppc-linux-nat.c: Fix common/ includes.
10641         * parser-defs.h: Fix common/ includes.
10642         * osdata.c: Fix common/ includes.
10643         * obsd-nat.c: Fix common/ includes.
10644         * nat/x86-linux.c: Fix common/ includes.
10645         * nat/x86-linux-dregs.c: Fix common/ includes.
10646         * nat/x86-dregs.h: Fix common/ includes.
10647         * nat/x86-dregs.c: Fix common/ includes.
10648         * nat/ppc-linux.c: Fix common/ includes.
10649         * nat/mips-linux-watch.h: Fix common/ includes.
10650         * nat/mips-linux-watch.c: Fix common/ includes.
10651         * nat/linux-waitpid.c: Fix common/ includes.
10652         * nat/linux-ptrace.h: Fix common/ includes.
10653         * nat/linux-ptrace.c: Fix common/ includes.
10654         * nat/linux-procfs.c: Fix common/ includes.
10655         * nat/linux-personality.c: Fix common/ includes.
10656         * nat/linux-osdata.c: Fix common/ includes.
10657         * nat/linux-namespaces.c: Fix common/ includes.
10658         * nat/linux-btrace.h: Fix common/ includes.
10659         * nat/linux-btrace.c: Fix common/ includes.
10660         * nat/fork-inferior.c: Fix common/ includes.
10661         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10662         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10663         * nat/aarch64-linux.c: Fix common/ includes.
10664         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10665         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10666         * namespace.h: Fix common/ includes.
10667         * mips-linux-tdep.c: Fix common/ includes.
10668         * minsyms.c: Fix common/ includes.
10669         * mi/mi-parse.h: Fix common/ includes.
10670         * mi/mi-main.c: Fix common/ includes.
10671         * mi/mi-cmd-env.c: Fix common/ includes.
10672         * memrange.h: Fix common/ includes.
10673         * memattr.c: Fix common/ includes.
10674         * maint.h: Fix common/ includes.
10675         * maint.c: Fix common/ includes.
10676         * main.c: Fix common/ includes.
10677         * machoread.c: Fix common/ includes.
10678         * location.c: Fix common/ includes.
10679         * linux-thread-db.c: Fix common/ includes.
10680         * linux-nat.c: Fix common/ includes.
10681         * linux-fork.c: Fix common/ includes.
10682         * inline-frame.c: Fix common/ includes.
10683         * infrun.c: Fix common/ includes.
10684         * inflow.c: Fix common/ includes.
10685         * inferior.h: Fix common/ includes.
10686         * inferior.c: Fix common/ includes.
10687         * infcmd.c: Fix common/ includes.
10688         * inf-ptrace.c: Fix common/ includes.
10689         * inf-child.c: Fix common/ includes.
10690         * ia64-linux-nat.c: Fix common/ includes.
10691         * i387-tdep.c: Fix common/ includes.
10692         * i386-tdep.c: Fix common/ includes.
10693         * i386-linux-tdep.c: Fix common/ includes.
10694         * i386-linux-nat.c: Fix common/ includes.
10695         * i386-go32-tdep.c: Fix common/ includes.
10696         * i386-fbsd-tdep.c: Fix common/ includes.
10697         * i386-fbsd-nat.c: Fix common/ includes.
10698         * guile/scm-type.c: Fix common/ includes.
10699         * guile/guile.c: Fix common/ includes.
10700         * go32-nat.c: Fix common/ includes.
10701         * gnu-nat.c: Fix common/ includes.
10702         * gdbthread.h: Fix common/ includes.
10703         * gdbarch-selftests.c: Fix common/ includes.
10704         * gdb_usleep.c: Fix common/ includes.
10705         * gdb_select.h: Fix common/ includes.
10706         * gdb_bfd.c: Fix common/ includes.
10707         * gcore.c: Fix common/ includes.
10708         * fork-child.c: Fix common/ includes.
10709         * findvar.c: Fix common/ includes.
10710         * fbsd-nat.c: Fix common/ includes.
10711         * event-top.c: Fix common/ includes.
10712         * event-loop.c: Fix common/ includes.
10713         * dwarf2read.c: Fix common/ includes.
10714         * dwarf2loc.c: Fix common/ includes.
10715         * dwarf2-frame.c: Fix common/ includes.
10716         * dwarf-index-cache.c: Fix common/ includes.
10717         * dtrace-probe.c: Fix common/ includes.
10718         * disasm-selftests.c: Fix common/ includes.
10719         * defs.h: Fix common/ includes.
10720         * csky-tdep.c: Fix common/ includes.
10721         * cp-valprint.c: Fix common/ includes.
10722         * cp-support.h: Fix common/ includes.
10723         * cp-support.c: Fix common/ includes.
10724         * corelow.c: Fix common/ includes.
10725         * completer.h: Fix common/ includes.
10726         * completer.c: Fix common/ includes.
10727         * compile/compile.c: Fix common/ includes.
10728         * compile/compile-loc2c.c: Fix common/ includes.
10729         * compile/compile-cplus-types.c: Fix common/ includes.
10730         * compile/compile-cplus-symbols.c: Fix common/ includes.
10731         * command.h: Fix common/ includes.
10732         * cli/cli-dump.c: Fix common/ includes.
10733         * cli/cli-cmds.c: Fix common/ includes.
10734         * charset.c: Fix common/ includes.
10735         * build-id.c: Fix common/ includes.
10736         * btrace.h: Fix common/ includes.
10737         * btrace.c: Fix common/ includes.
10738         * breakpoint.h: Fix common/ includes.
10739         * breakpoint.c: Fix common/ includes.
10740         * ax.h:
10741         (enum agent_op): Fix common/ includes.
10742         * ax-general.c (struct aop_map): Fix common/ includes.
10743         * ax-gdb.c: Fix common/ includes.
10744         * auxv.c: Fix common/ includes.
10745         * auto-load.c: Fix common/ includes.
10746         * arm-tdep.c: Fix common/ includes.
10747         * arch/riscv.c: Fix common/ includes.
10748         * arch/ppc-linux-common.c: Fix common/ includes.
10749         * arch/i386.c: Fix common/ includes.
10750         * arch/arm.c: Fix common/ includes.
10751         * arch/arm-linux.c: Fix common/ includes.
10752         * arch/arm-get-next-pcs.c: Fix common/ includes.
10753         * arch/amd64.c: Fix common/ includes.
10754         * arch/aarch64.c: Fix common/ includes.
10755         * arch/aarch64-insn.c: Fix common/ includes.
10756         * arch-utils.c: Fix common/ includes.
10757         * amd64-windows-tdep.c: Fix common/ includes.
10758         * amd64-tdep.c: Fix common/ includes.
10759         * amd64-sol2-tdep.c: Fix common/ includes.
10760         * amd64-obsd-tdep.c: Fix common/ includes.
10761         * amd64-nbsd-tdep.c: Fix common/ includes.
10762         * amd64-linux-tdep.c: Fix common/ includes.
10763         * amd64-linux-nat.c: Fix common/ includes.
10764         * amd64-fbsd-tdep.c: Fix common/ includes.
10765         * amd64-fbsd-nat.c: Fix common/ includes.
10766         * amd64-dicos-tdep.c: Fix common/ includes.
10767         * amd64-darwin-tdep.c: Fix common/ includes.
10768         * agent.c: Fix common/ includes.
10769         * ada-lang.h: Fix common/ includes.
10770         * ada-lang.c: Fix common/ includes.
10771         * aarch64-tdep.c: Fix common/ includes.
10772
10773 2019-01-25  Tom Tromey  <tom@tromey.com>
10774
10775         * common/create-version.sh: Use common/version.h.
10776
10777 2019-01-24  Pedro Alves  <palves@redhat.com>
10778
10779         * infrun.c (signal_stop, signal_print, signal_program)
10780         (signal_catch, signal_pass): Now arrays instead of pointers.
10781         (update_signals_program_target, do_target_resume)
10782         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10783         * linux-nat.c (linux_nat_target::pass_signals)
10784         (linux_nat_target::create_inferior, linux_nat_target::attach):
10785         Adjust.
10786         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10787         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10788         * procfs.c (procfs_target::pass_signals): Adjust.
10789         * record-full.c (record_full_target::resume): Adjust.
10790         * remote.c (remote_target::pass_signals)
10791         (remote_target::program_signals): Adjust.
10792         * target-debug.h (target_debug_print_signals): Now takes a
10793         gdb::array_view as parameter.  Adjust.
10794         * target.h (target_ops) <pass_signals, program_signals>: Replace
10795         pointer and length parameters with gdb::array_view.
10796         (target_pass_signals, target_program_signals): Likewise.
10797         * target-delegates.c: Regenerate.
10798
10799 2019-01-24  Pedro Alves  <palves@redhat.com>
10800
10801         * common/forward-scope-exit.h
10802         (forward_scope_exit::forward_scope_exit): Pass arguments to
10803         m_bind_function directly, instead of creating a std::bind and
10804         copying that.
10805
10806 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10807
10808         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10809         for static members.
10810         (pass_in_v_vfp_candidate): Likewise.
10811
10812 2019-01-23  Tom Tromey  <tom@tromey.com>
10813             Pedro Alves  <palves@redhat.com>
10814
10815         * regcache.c (class regcache_invalidator): Remove.
10816         (regcache::raw_write): Use make_scope_exit.
10817
10818 2019-01-23  Tom Tromey  <tom@tromey.com>
10819
10820         * ui-out.h (class ui_out_emit_type): Update comment.
10821
10822 2019-01-23  Tom Tromey  <tom@tromey.com>
10823
10824         * infrun.c (fetch_inferior_event): Update comment.
10825
10826 2019-01-23  Tom Tromey  <tom@tromey.com>
10827             Pedro Alves  <palves@redhat.com>
10828
10829         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10830         parameter.
10831         (fetch_inferior_event): Use SCOPE_EXIT.
10832
10833
10834 2019-01-23  Tom Tromey  <tom@tromey.com>
10835             Pedro Alves  <palves@redhat.com>
10836
10837         * infrun.c (disable_thread_events): Delete.
10838         (stop_all_threads): Use SCOPE_EXIT.
10839
10840 2019-01-23  Tom Tromey  <tom@tromey.com>
10841             Pedro Alves  <palves@redhat.com>
10842
10843         * symfile.c: Include forward-scope-exit.h.
10844         (clear_symtab_users_cleanup): Replace forward declaration with
10845         a FORWARD_SCOPE_EXIT.
10846         (syms_from_objfile_1): Use the forward_scope_exit and
10847         gdb::optional instead of cleanup_function.
10848         (reread_symbols): Use the forward_scope_exit instead of
10849         cleanup_function.
10850         (clear_symtab_users_cleanup): Remove function.
10851
10852 2019-01-23  Tom Tromey  <tom@tromey.com>
10853             Pedro Alves  <palves@redhat.com>
10854
10855         * linux-nat.c: Include scope-exit.h.
10856         (cleanup_target_stop): Remove.
10857         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10858         SCOPE_EXIT.
10859
10860 2019-01-23  Tom Tromey  <tom@tromey.com>
10861             Pedro Alves  <palves@redhat.com>
10862
10863         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10864         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10865
10866 2019-01-23  Tom Tromey  <tom@tromey.com>
10867             Andrew Burgess  <andrew.burgess@embecosm.com>
10868             Pedro Alves  <palves@redhat.com>
10869
10870         * infrun.c (fetch_inferior_event): Use scope_exit.
10871         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10872         * top.c (execute_command): Use scope_exit.
10873         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10874         * utils.c (do_bpstat_clear_actions_cleanup)
10875         (make_bpstat_clear_actions_cleanup): Remove.
10876
10877 2019-01-23  Tom Tromey  <tom@tromey.com>
10878             Pedro Alves  <palves@redhat.com>
10879
10880         * infrun.c: Include "common/scope-exit.h"
10881         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10882         (wait_for_inferior): Use SCOPE_EXIT.
10883         (fetch_inferior_event): Use scope_exit.
10884
10885 2019-01-23  Tom Tromey  <tom@tromey.com>
10886             Pedro Alves  <palves@redhat.com>
10887
10888         * breakpoint.c (create_breakpoint): Remove cleanup.
10889
10890 2019-01-23  Tom Tromey  <tom@tromey.com>
10891             Andrew Burgess  <andrew.burgess@embecosm.com>
10892             Pedro Alves  <palves@redhat.com>
10893
10894 2019-01-23  Pedro Alves  <palves@redhat.com>
10895
10896         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10897
10898 2019-01-23  Pedro Alves  <palves@redhat.com>
10899             Andrew Burgess  <andrew.burgess@embecosm.com>
10900
10901         * gdbthread.h: Include "common/forward-scope-exit.h".
10902         (scoped_finish_thread_state): Redefine custom class in terms of
10903         forward_scope_exit.
10904
10905 2019-01-23  Pedro Alves  <palves@redhat.com>
10906             Andrew Burgess  <andrew.burgess@embecosm.com>
10907
10908         * common/forward-scope-exit.h: New file.
10909
10910 2019-01-23  Pedro Alves  <palves@redhat.com>
10911             Andrew Burgess  <andrew.burgess@embecosm.com>
10912             Tom Tromey  <tom@tromey.com>
10913
10914         * common/scope-exit.h: New file.
10915
10916 2019-01-23  Pedro Alves  <palves@redhat.com>
10917
10918         * common/preprocessor.h (ESC): Rename to ...
10919         (ESC_PARENS): ... this.
10920         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10921         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10922
10923 2019-01-23  Tom Tromey  <tom@tromey.com>
10924
10925         * language.h (class scoped_switch_to_sym_language_if_auto):
10926         Initialize m_lang in both cases.
10927
10928 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10929
10930         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10931         with XCNEW.
10932
10933 2019-01-22  Tom Tromey  <tom@tromey.com>
10934
10935         * corelow.c: Do not include sys/file.h.
10936
10937 2019-01-22  Tom Tromey  <tom@tromey.com>
10938
10939         * tui/tui-wingeneral.h: Include gdb_curses.h.
10940
10941 2019-01-22  Tom Tromey  <tom@tromey.com>
10942
10943         * source-cache.h (class source_cache) <get_source_lines,
10944         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10945
10946 2019-01-22  Tom Tromey  <tom@tromey.com>
10947
10948         * remote-fileio.h (struct remote_target): Declare.
10949
10950 2019-01-22  Tom Tromey  <tom@tromey.com>
10951
10952         * python/py-arch.c: Do not include py-ref.h.
10953         * python/py-bpevent.c: Do not include py-ref.h.
10954         * python/py-cmd.c: Do not include py-ref.h.
10955         * python/py-continueevent.c: Do not include py-ref.h.
10956         * python/py-event.h: Do not include py-ref.h.
10957         * python/py-evtregistry.c: Do not include py-ref.h.
10958         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10959         * python/py-frame.c: Do not include py-ref.h.
10960         * python/py-framefilter.c: Do not include py-ref.h.
10961         * python/py-function.c: Do not include py-ref.h.
10962         * python/py-infevents.c: Do not include py-ref.h.
10963         * python/py-linetable.c: Do not include py-ref.h.
10964         * python/py-objfile.c: Do not include py-ref.h.
10965         * python/py-param.c: Do not include py-ref.h.
10966         * python/py-prettyprint.c: Do not include py-ref.h.
10967         * python/py-progspace.c: Do not include py-ref.h.
10968         * python/py-symbol.c: Do not include py-ref.h.
10969         * python/py-symtab.c: Do not include py-ref.h.
10970         * python/py-type.c: Do not include py-ref.h.
10971         * python/py-unwind.c: Do not include py-ref.h.
10972         * python/py-utils.c: Do not include py-ref.h.
10973         * python/py-value.c: Do not include py-ref.h.
10974         * python/py-varobj.c: Do not include py-ref.h.
10975         * python/py-xmethods.c: Do not include py-ref.h.
10976         * python/python.c: Do not include py-ref.h.
10977         * varobj.c: Do not include py-ref.h.
10978
10979 2019-01-22  Tom Tromey  <tom@tromey.com>
10980
10981         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10982         keyword for bcache.
10983
10984 2019-01-22  Tom Tromey  <tom@tromey.com>
10985
10986         * compile/compile-cplus-types.c: Remove a comment by #include.
10987
10988 2019-01-22  Tom Tromey  <tom@tromey.com>
10989
10990         * compile/gcc-c-plugin.h: Include compile-internal.h.
10991
10992 2019-01-22  Tom Tromey  <tom@tromey.com>
10993
10994         * stabsread.c (EXTERN): Do not define.
10995         (symnum, next_symbol_text_func, processing_gcc_compilation)
10996         (within_function, global_sym_chain, global_stabs)
10997         (previous_stab_code, this_object_header_files)
10998         (n_this_object_header_files)
10999         (n_allocated_this_object_header_files): Define.
11000         * stabsread.h (EXTERN): Never define.  Use "extern".
11001
11002 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11003
11004         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11005         history_value.
11006
11007 2019-01-21  Tom Tromey  <tom@tromey.com>
11008
11009         * ui-out.c: Fix includes.
11010         * tui/tui-source.c: Fix includes.
11011         * target.c: Fix includes.
11012         * remote.c: Fix includes.
11013         * regcache.c: Fix includes.
11014         * python/py-block.c: Fix includes.
11015         * printcmd.c: Fix includes.
11016         * or1k-tdep.c: Fix includes.
11017         * mi/mi-main.c: Fix includes.
11018         * m32r-tdep.c: Fix includes.
11019         * csky-tdep.c: Fix includes.
11020         * compile/compile-cplus-types.c: Fix includes.
11021         * cli/cli-interp.c: Fix includes.
11022
11023 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11024
11025         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11026         for padding.
11027
11028 2019-01-16  Tom Tromey  <tom@tromey.com>
11029
11030         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11031         earlier.
11032         (struct objfile) <msymbols_range>: Move from top level.
11033         <msymbols>: New method.
11034         (class objfile_msymbols): Remove.
11035         * symtab.c (default_collect_symbol_completion_matches_break_on):
11036         Update.
11037         * symmisc.c (dump_msymbols): Update.
11038         * stabsread.c (scan_file_globals): Update.
11039         * objc-lang.c (info_selectors_command, info_classes_command)
11040         (find_methods): Update.
11041         * minsyms.c (find_solib_trampoline_target): Update.
11042         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11043         * coffread.c (coff_symfile_read): Update.
11044         * ada-lang.c (ada_lookup_simple_minsym)
11045         (ada_collect_symbol_completion_matches): Update.
11046
11047 2019-01-16  Tom Tromey  <tom@tromey.com>
11048
11049         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11050         type.  Remove no-argument constructor.
11051         <iterator::operator++>: Simplify.
11052         <begin>: Update.
11053         <end>: Use minimal_symbol_count.
11054
11055 2019-01-16  Tom Tromey  <tom@tromey.com>
11056
11057         * objfiles.h (struct objfile) <psymtabs>: New method.
11058         (class objfile_psymtabs): Remove.
11059         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11060         typedef.
11061         <range>: New method.
11062         (require_partial_symbols): Change return type.
11063         * psymtab.c (require_partial_symbols)
11064         (psym_expand_symtabs_matching): Update.
11065         * mdebugread.c (parse_partial_symbols): Update.
11066         * dbxread.c (dbx_end_psymtab): Update.
11067
11068 2019-01-15  Tom Tromey  <tom@tromey.com>
11069
11070         * symtab.c (lookup_objfile_from_block)
11071         (lookup_symbol_in_objfile_symtabs)
11072         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11073         (find_line_symtab, info_sources_command)
11074         (default_collect_symbol_completion_matches_break_on)
11075         (make_source_files_completion_list): Update.
11076         * symmisc.c (print_objfile_statistics, dump_objfile)
11077         (maintenance_print_symbols, maintenance_info_symtabs)
11078         (maintenance_check_symtabs, maintenance_info_line_tables):
11079         Update.
11080         * source.c (select_source_symtab)
11081         (forget_cached_source_info_for_objfile): Update.
11082         * objfiles.h (class objfile_compunits): Remove.
11083         (struct objfile) <compunits_range>: New typedef.
11084         (compunits): New method.
11085         * objfiles.c (objfile_relocate1): Update.
11086         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11087         * maint.c (count_symtabs_and_blocks): Update.
11088         * linespec.c (iterate_over_all_matching_symtabs): Update.
11089         * cp-support.c (add_symbol_overload_list_qualified): Update.
11090         * coffread.c (coff_symtab_read): Update.
11091         * ada-lang.c (add_nonlocal_symbols)
11092         (ada_collect_symbol_completion_matches)
11093         (ada_add_global_exceptions): Update.
11094
11095 2019-01-15  Tom Tromey  <tom@tromey.com>
11096
11097         * progspace.h (program_space) <objfiles_safe_range>: New
11098         typedef.
11099         <objfiles_safe>: New method.
11100         * objfiles.h (class all_objfiles_safe): Remove.
11101         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11102         * jit.c (jit_inferior_exit_hook): Update.
11103
11104 2019-01-17  Tom Tromey  <tom@tromey.com>
11105
11106         * progspace.h (program_space) <objfiles_range>: New typedef.
11107         <objfiles>: New method.
11108         <objfiles_head>: Rename from objfiles.
11109         (object_files): Update.
11110         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11111         * guile/scm-pretty-print.c
11112         (ppscm_find_pretty_printer_from_objfiles): Update.
11113         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11114         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11115         Update.
11116         * python/py-progspace.c (pspy_get_objfiles): Update.
11117         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11118         Update.
11119         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11120         (objfpy_lookup_objfile_by_build_id): Update.
11121         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11122         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11123         Update.
11124         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11125         (expand_symtab_containing_pc, lookup_objfile_from_block)
11126         (lookup_static_symbol, basic_lookup_transparent_type)
11127         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11128         (find_line_symtab, info_sources_command)
11129         (default_collect_symbol_completion_matches_break_on)
11130         (make_source_files_completion_list, find_main_name): Update.
11131         * symmisc.c (print_symbol_bcache_statistics)
11132         (print_objfile_statistics, maintenance_print_symbols)
11133         (maintenance_print_msymbols, maintenance_print_objfiles)
11134         (maintenance_info_symtabs, maintenance_check_symtabs)
11135         (maintenance_expand_symtabs, maintenance_info_line_tables):
11136         Update.
11137         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11138         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11139         (map_overlay_command, unmap_overlay_command)
11140         (simple_overlay_update, expand_symtabs_matching)
11141         (map_symbol_filenames): Update.
11142         * symfile-debug.c (set_debug_symfile): Update.
11143         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11144         Update.
11145         * source.c (select_source_symtab, forget_cached_source_info):
11146         Update.
11147         * solib.c (solib_read_symbols): Update.
11148         * solib-spu.c (append_ocl_sos): Update.
11149         * psymtab.c (maintenance_print_psymbols)
11150         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11151         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11152         * printcmd.c (info_symbol_command): Update.
11153         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11154         Update.
11155         * objfiles.h (class all_objfiles): Remove.
11156         * objfiles.c (have_partial_symbols, have_full_symbols)
11157         (have_minimal_symbols, qsort_cmp, update_section_map)
11158         (shared_objfile_contains_address_p)
11159         (default_iterate_over_objfiles_in_search_order): Update.
11160         * objc-lang.c (info_selectors_command, info_classes_command)
11161         (find_methods): Update.
11162         * minsyms.c (find_solib_trampoline_target): Update.
11163         * maint.c (maintenance_info_sections)
11164         (maintenance_translate_address, count_symtabs_and_blocks):
11165         Update.
11166         * main.c (captured_main_1): Update.
11167         * linux-thread-db.c (try_thread_db_load_from_pdir)
11168         (has_libpthread): Update.
11169         * linespec.c (iterate_over_all_matching_symtabs)
11170         (search_minsyms_for_name): Update.
11171         * jit.c (jit_find_objf_with_entry_addr): Update.
11172         * hppa-tdep.c (find_unwind_entry)
11173         (hppa_lookup_stub_minimal_symbol): Update.
11174         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11175         Update.
11176         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11177         (elf_gnu_ifunc_resolve_by_got): Update.
11178         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11179         * dwarf-index-write.c (save_gdb_index_command): Update.
11180         * cp-support.c (add_symbol_overload_list_qualified): Update.
11181         * breakpoint.c (create_overlay_event_breakpoint)
11182         (create_longjmp_master_breakpoint)
11183         (create_std_terminate_master_breakpoint)
11184         (create_exception_master_breakpoint): Update.
11185         * blockframe.c (find_pc_partial_function): Update.
11186         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11187         (ada_collect_symbol_completion_matches)
11188         (ada_add_global_exceptions): Update.
11189
11190 2019-01-17  Tom Tromey  <tom@tromey.com>
11191
11192         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11193         declare VEC.
11194         (solib_target_parse_libraries): Change return type.
11195         (library_list_start_segment, library_list_start_section)
11196         (library_list_end_library, library_list_start_library); Update.
11197         (solib_target_free_library_list): Remove.
11198         (solib_target_parse_libraries): Remove cleanup.  Change return
11199         type.
11200         (solib_target_current_sos): Update.
11201
11202 2019-01-17  Tom Tromey  <tromey@bapiya>
11203
11204         * valprint.c: Replace "the the" with "the".
11205         * symtab.c: Replace "the the" with "the".
11206         * solib.c: Replace "the the" with "the".
11207         * solib-dsbt.c: Replace "the the" with "the".
11208         * linespec.c: Replace "the the" with "the".
11209         * dwarf2loc.h: Replace "the the" with "the".
11210         * amd64-windows-tdep.c: Replace "the the" with "the".
11211         * aarch64-tdep.c: Replace "the the" with "the".
11212
11213 2019-01-16  Keith Seitz  <keiths@redhat.com>
11214
11215         PR gdb/23773
11216         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11217         <builder>: Rename to ..
11218         <m_builder>: ... this and make private.
11219         (dwarf2_cu::get_builder): New method.  Change all users of
11220         `builder' to use this method.
11221         (dwarf2_start_symtab): Move to ...
11222         (dwarf2_cu::start_symtab): ... here.  Update all callers
11223         (setup_type_unit_groups): Move to ...
11224         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11225         callers.
11226         (dwarf2_cu::reset_builder): New method.
11227         (process_full_compunit, process_full_type_unit): Use
11228         dwarf2_cu::reset_builder.
11229         (follow_die_offset): Record the ancestor CU if it is different
11230         from the followed DIE's CU.
11231         (follow_die_sig_1): Likewise.
11232
11233 2019-01-15  Tom Tromey  <tom@tromey.com>
11234
11235         * remote.c (class remote_state) <buf>: Now a char_vector.
11236         <buf_size>: Remove.
11237         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11238         parameter.
11239         (remote_target::getpkt_or_notif_sane_1)
11240         (remote_target::getpkt_sane)
11241         (remote_target::getpkt_or_notif_sane): Likewise.
11242         (class remote_target) <putpkt>: New overload.
11243         (remote_target::read_frame): Change type of "buf_p".  Remove
11244         sizeof_p parameter.
11245         (packet_ok): New overload.
11246         (packet_check_result): New overload.
11247         Update all uses.
11248
11249 2019-01-14  Tom Tromey  <tom@tromey.com>
11250
11251         * remote-notif.c (handle_notification, remote_notif_ack)
11252         (remote_notif_parse): Make "buf" const.
11253         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11254         const.
11255         (remote_notif_parse, remote_notif_ack, handle_notification):
11256         Likewise.
11257         * remote.c (remote_notif_stop_parse): Make "buf" const.
11258         (remote_target::remote_parse_stop_reply): Make "buf" const.
11259         (remote_notif_stop_ack): Make "buf" const.
11260
11261 2019-01-14  Tom Tromey  <tom@tromey.com>
11262
11263         * remote.c (remote_console_output): Make parameter const.
11264
11265 2019-01-14  Tom Tromey  <tom@tromey.com>
11266
11267         * target-debug.h (target_debug_print_signals): Constify.
11268         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11269         * procfs.c (procfs_target::pass_signals): Update.
11270         * linux-nat.c (linux_nat_target::pass_signals): Update.
11271         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11272         * target-delegates.c: Rebuild.
11273         * remote.c (remote_target::program_signals): Update.
11274         (remote_target::pass_signals): Update.
11275         * target.c (target_pass_signals): Constify argument.
11276         (target_program_signals): Likewise.
11277         * target.h (struct target_ops) <pass_signals, program_signals>:
11278         Constify argument.
11279         (target_pass_signals, target_program_signals): Constify argument.
11280
11281 2019-01-14  Tom Tromey  <tom@tromey.com>
11282
11283         PR tui/28819:
11284         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11285
11286 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11287
11288         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11289         field.
11290         * rs6000-tdep.c: Include reggroups.h.
11291         (IS_V_ALIAS_PSEUDOREG): Define.
11292         (rs6000_register_name): Return names for the "vX" aliases.
11293         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11294         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11295         aliases.  Call default_register_reggroup_p for all other
11296         pseudo-registers.
11297         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11298         New functions.
11299         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11300         Handle "vX" aliases.
11301         (v_alias_pseudo_register_collect): New function.
11302         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11303         (rs6000_gdbarch_init): Initialize "vX" aliases as
11304         pseudo-registers.  Restore registration of
11305         rs6000_pseudo_register_reggroup_p with
11306         set_tdesc_pseudo_register_reggroup_p.
11307
11308 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11309
11310         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11311         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11312         set_gdbarch_num_pseudo_regs.
11313
11314 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11315
11316         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11317         Remove arg prefixname, add do_set and do_show.
11318         Add member functions set_list and show_list.
11319         * cli/cli-style.c (class cli_style_option): Update accordingly.
11320         (style_set_list): Move to file scope.
11321         (style_show_list): Likewise.
11322         (set_style): Call help_list.
11323         (show_style): Call cmd_show_list.
11324         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11325         Update to use the new macro.
11326
11327 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11328
11329         * ada-lang.c (_initialize_ada_language): Expand the help text
11330         for the "catch exception" command.
11331
11332 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11333
11334         * symtab.c (matching_obj_sections): Initialize obj,
11335         declare it closer to its usage.
11336
11337 2019-01-10  Tom Tromey  <tom@tromey.com>
11338
11339         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11340         (basic_inf_threads_range): Remove.
11341         (inf_threads_range, inf_non_exited_threads_range)
11342         (safe_inf_threads_range): Use next_adapter.
11343
11344 2019-01-10  Keith Seitz  <keiths@redhat.com>
11345
11346         PR gdb/23712
11347         PR symtab/23010
11348         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11349         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11350
11351 2019-01-10  Keith Seitz  <keiths@redhat.com>
11352
11353         PR gdb/23712
11354         PR symtab/23010
11355         * dictionary.c (pending_to_vector): Remove.
11356         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11357         Remove _1 suffix, replacing functions of the same name.  Update
11358         all callers.
11359         (dict_create_hashed, dict_create_hashed_expandable)
11360         (dict_create_linear, dict_create_linear_expandable, dict_free)
11361         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11362         Make functions static.
11363
11364 2019-01-10  Keith Seitz  <keiths@redhat.com>
11365
11366         PR gdb/23712
11367         PR symtab/23010
11368         * dictionary.h (struct dictionary): Replace declaration with
11369         multidictionary.
11370         (dict_create_hashed, dict_create_hashed_expandable)
11371         (dict_create_linear, dict_create_linear_expandable)
11372         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11373         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11374         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11375         taking multidictionary argument.
11376         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11377         * block.h (struct block) <dict>: Change to multidictionary
11378         and rename `multidict'.
11379         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11380         symmisc.c: Update all dictionary references to multidictionary.
11381
11382 2019-01-10  Keith Seitz  <keiths@redhat.com>
11383
11384         PR gdb/23712
11385         PR symtab/23010
11386         * dictionary.c: Include unordered_map.
11387         (pending_to_vector): New function.
11388         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11389         Rewrite the non-"_1" functions to take vector instead
11390         of linked list.
11391         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11392         "new" _1 versions of the same name.
11393         (multidictionary): Define.
11394         (std::hash<enum language): New definition.
11395         (collate_pending_symbols_by_language, mdict_create_hashed)
11396         (mdict_create_hashed_expandable, mdict_create_linear)
11397         (mdict_create_linear_expandable, mdict_free)
11398         (find_language_dictionary, create_new_language_dictionary)
11399         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11400         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11401         (mdict_size, mdict_empty): New functions.
11402         * dictionary.h (mdict_iterator): Define.
11403
11404 2019-01-10  Pedro Alves  <palves@redhat.com>
11405
11406         * breakpoint.c (read_uploaded_action)
11407         (create_tracepoint_from_upload): Adjust to use
11408         gdb::unique_xmalloc_ptr.
11409         * ctf.c (ctf_write_uploaded_tp):
11410         (SET_ARRAY_FIELD): Use emplace_back.
11411         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11412         * tracefile-tfile.c (tfile_write_uploaded_tp):
11413         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11414         gdb::unique_xmalloc_ptr.
11415         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11416         at_string, cond_string, cmd_strings>: Replace char pointers
11417         with gdb::unique_xmalloc_ptr.
11418
11419 2019-01-10  Pedro Alves  <palves@redhat.com>
11420
11421         * solib-target.c (library_list_start_library): Don't xstrdup name.
11422
11423 2019-01-10  Pedro Alves  <palves@redhat.com>
11424
11425         * mdebugread.c (parse_partial_symbols): Use
11426         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11427
11428 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11429
11430         * linux-fork.c (scoped_switch_fork_info)
11431         <~scoped_switch_fork_info>: Fix incorrect variable name.
11432
11433 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11434
11435         * linux-fork.c (scoped_switch_fork_info)
11436         <scoped_switch_fork_info>: Make explicit.
11437         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11438
11439 2019-01-10  Tom Tromey  <tom@tromey.com>
11440
11441         * objfiles.h (objfile::reset_psymtabs): Update.
11442         * objfiles.c (objfile::objfile): Update.
11443         * psymtab.h (psymtab_storage::obstack): Update.
11444         (psymtab_storage::m_obstack): Use gdb::optional.
11445         (class psymtab_storage): Update comment.  Remove objfile
11446         parameter.
11447         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11448
11449 2019-01-10  Tom Tromey  <tom@tromey.com>
11450
11451         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11452         <free_psymtabs>: Now private.
11453         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11454         (allocate_psymtab): Use new method.
11455
11456 2019-01-10  Tom Tromey  <tom@tromey.com>
11457
11458         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11459         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11460         * mdebugread.c (parse_partial_symbols): Use
11461         allocate_dependencies.
11462         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11463         allocate_dependencies.
11464         (process_psymtab_comp_unit_reader)
11465         (build_type_psymtab_dependencies): Likewise.
11466         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11467
11468 2019-01-10  Tom Tromey  <tom@tromey.com>
11469
11470         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11471         PSYMBOL_SET_LANGUAGE.
11472         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11473
11474 2019-01-10  Tom Tromey  <tom@tromey.com>
11475
11476         * psymtab.h (psymtab_storage::obstack): New method.
11477         <m_obstack>: Rename from obstack; now private.
11478         * psymtab.c (psymtab_storage): Update.
11479         * dwarf2read.c (create_addrmap_from_index)
11480         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11481         Update.
11482
11483 2019-01-10  Tom Tromey  <tom@tromey.com>
11484
11485         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11486         * objfiles.h (objfile::reset_psymtabs): New method.
11487
11488 2019-01-10  Tom Tromey  <tom@tromey.com>
11489
11490         * symmisc.c (print_symbol_bcache_statistics): Update.
11491         (print_objfile_statistics): Update.
11492         * symfile.c (reread_symbols): Update.
11493         * psymtab.h (class psymtab_storage): New.
11494         * psymtab.c (psymtab_storage): New constructor.
11495         (~psymtab_storage): New destructor.
11496         (require_partial_symbols): Update.
11497         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11498         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11499         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11500         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11501         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11502         (start_psymtab_common, end_psymtab_common)
11503         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11504         (allocate_psymtab): Update.
11505         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11506         Update.
11507         (dump_psymtab_addrmap, maintenance_print_psymbols)
11508         (maintenance_check_psymtabs): Update.
11509         (class objfile_psymtabs): Move to objfiles.h.
11510         * psympriv.h (discard_psymtab): Now inline.
11511         (psymtab_discarder::psymtab_discarder): Update.
11512         (psymtab_discarder::~psymtab_discarder): Update.
11513         (ALL_OBJFILE_PSYMTABS): Rewrite.
11514         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11515         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11516         Remove fields.
11517         <partial_symtabs>: New field.
11518         (class objfile_psymtabs): Move from psymtab.h.  Update.
11519         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11520         psymbol_cache.
11521         (objfile::~objfile): Don't destroy psymbol_cache.
11522         * mdebugread.c (parse_partial_symbols): Update.
11523         * dwarf2read.c (create_addrmap_from_index)
11524         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11525         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11526         (add_partial_subprogram, dwarf2_ranges_read): Update.
11527         * dwarf-index-write.c (write_address_map)
11528         (write_one_signatured_type, recursively_write_psymbols)
11529         (class debug_names, class debug_names, write_psymtabs_to_index):
11530         Update.
11531
11532 2019-01-10  Tom Tromey  <tom@tromey.com>
11533
11534         * symtab.h (SYMBOL_SET_NAMES): Update.
11535         (symbol_set_names): Update.
11536         (MSYMBOL_SET_NAMES): Update.
11537         * symtab.c (symbol_set_names): Change argument to be an
11538         objfile_per_bfd_storage.
11539         * psymtab.c (add_psymbol_to_bcache): Update.
11540         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11541
11542 2019-01-10  Tom Tromey  <tom@tromey.com>
11543
11544         * symtab.c (create_demangled_names_hash): Change argument to be an
11545         objfile_per_bfd_storage.
11546         (symbol_set_names): Update.
11547
11548 2019-01-10  Tom Tromey  <tom@tromey.com>
11549
11550         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11551         init_psymbol_list.
11552         * psymtab.c (init_psymbol_list): Do nothing if already called.
11553         * psympriv.h (init_psymbol_list): Add comment.
11554         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11555         init_psymbol_list.
11556         * dbxread.c (dbx_symfile_read): Unconditionally call
11557         init_psymbol_list.
11558
11559 2019-01-10  Tom Tromey  <tom@tromey.com>
11560
11561         * xcoffread.c (scan_xcoff_symtab): Update.
11562         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11563         "where".
11564         * mdebugread.c (parse_partial_symbols)
11565         (handle_psymbol_enumerators): Update.
11566         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11567         * dbxread.c (read_dbx_symtab): Update.
11568         * psympriv.h (psymbol_placement): New enum.
11569         (add_psymbol_to_list): Update.
11570
11571 2019-01-10  Tom Tromey  <tom@tromey.com>
11572
11573         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11574         static_psymbols parameters.
11575         (scan_xcoff_symtab): Update.
11576         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11577         static_psymbols parameters.
11578         * psympriv.h (start_psymtab_common): Update.
11579         * mdebugread.c (parse_partial_symbols): Update.
11580         * dwarf2read.c (create_partial_symtab): Update.
11581         * dbxread.c (read_dbx_symtab): Update.
11582         (start_psymtab): Remove global_psymbols and static_psymbols
11583         parameters.
11584
11585 2019-01-10  Tom Tromey  <tom@tromey.com>
11586
11587         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11588         * psymtab.c (allocate_psymtab): Add comment.
11589         * psympriv.h (allocate_psymtab): Add comment.
11590         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11591         initializations.
11592         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11593
11594 2019-01-10  Tom Tromey  <tom@tromey.com>
11595
11596         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11597         Don't declare.
11598         * mipsread.c: Include mdebugread.h.
11599         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11600         Declare.
11601         * elfread.c: Include mdebugread.h.
11602
11603 2019-01-09  Tom Tromey  <tom@tromey.com>
11604
11605         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11606         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11607         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11608         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11609         (psym_lookup_symbol, psym_find_last_source_symtab)
11610         (psym_forget_cached_source_info, psym_print_stats)
11611         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11612         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11613         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11614         (psym_find_compunit_symtab_by_address)
11615         (maintenance_print_psymbols, maintenance_info_psymtabs)
11616         (maintenance_check_psymtabs): Use ranged for.
11617         * psymtab.h (class objfile_psymtabs): New.
11618         (require_partial_symbols): Return objfile_psymtabs.
11619         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11620
11621 2019-01-09  Tom Tromey  <tom@tromey.com>
11622
11623         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11624         (find_pc_mapped_section, list_overlays_command)
11625         (map_overlay_command, unmap_overlay_command)
11626         (simple_overlay_update): Use all_objfiles.
11627         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11628         * printcmd.c (info_symbol_command): Use all_objfiles.
11629         * objfiles.h (ALL_OBJSECTIONS): Remove.
11630         * maint.c (maintenance_translate_address): Use all_objfiles.
11631         * gcore.c (gcore_create_callback): Use all_objfiles.
11632         (objfile_find_memory_regions): Likewise.
11633
11634 2019-01-09  Tom Tromey  <tom@tromey.com>
11635
11636         * symtab.c (find_line_symtab, info_sources_command)
11637         (make_source_files_completion_list): Use objfile_compunits.
11638         * source.c (select_source_symtab): Use objfile_compunits.
11639         * objfiles.h (struct objfile): Update comment.
11640         (ALL_OBJFILES): Remove.
11641         (ALL_FILETABS): Remove.
11642         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11643         objfile_compunits.
11644
11645 2019-01-09  Tom Tromey  <tom@tromey.com>
11646
11647         * symmisc.c (print_objfile_statistics, dump_objfile)
11648         (maintenance_print_symbols): Use compunit_filetabs.
11649         * source.c (forget_cached_source_info_for_objfile): Use
11650         compunit_filetabs.
11651         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11652         (ALL_FILETABS): Use compunit_filetabs.
11653         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11654         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11655
11656 2019-01-09  Tom Tromey  <tom@tromey.com>
11657
11658         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11659         (compunit_filetabs): New.
11660         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11661         compunit_filetabs.
11662         (info_sources_command, make_source_files_completion_list): Remove
11663         declaration.
11664         * symmisc.c (print_objfile_statistics, dump_objfile)
11665         (maintenance_print_symbols): Remove declaration.
11666         (maintenance_info_symtabs): Use compunit_filetabs.
11667         (maintenance_info_line_tables): Likewise.
11668         * source.c (select_source_symtab): Change local variable name.
11669         (forget_cached_source_info_for_objfile): Remove declaration.
11670         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11671         * objfiles.c (objfile_relocate1): Remove declaration.
11672         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11673         declaration.
11674         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11675         * coffread.c (coff_symtab_read): Remove declaration.
11676         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11677         compunit_filetabs.
11678
11679 2019-01-09  Tom Tromey  <tom@tromey.com>
11680
11681         * symtab.c (lookup_objfile_from_block)
11682         (find_pc_sect_compunit_symtab, search_symbols)
11683         (default_collect_symbol_completion_matches_break_on): Use
11684         objfile_compunits.
11685         * objfiles.h (ALL_COMPUNITS): Remove.
11686         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11687         * cp-support.c (add_symbol_overload_list_qualified): Use
11688         objfile_compunits.
11689         * ada-lang.c (ada_collect_symbol_completion_matches)
11690         (ada_add_global_exceptions): Use objfile_compunits.
11691
11692 2019-01-09  Tom Tromey  <tom@tromey.com>
11693
11694         * source.c (select_source_symtab)
11695         (forget_cached_source_info_for_objfile): Remove declaration.
11696         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11697         declaration.
11698         * maint.c (count_symtabs_and_blocks): Remove declaration.
11699         * cp-support.c (add_symbol_overload_list_qualified): Remove
11700         declaration.
11701         * coffread.c (coff_symtab_read): Remove declaration.
11702         * symtab.c (lookup_symbol_in_objfile_symtabs)
11703         (basic_lookup_transparent_type_1): Use objfile_compunits.
11704         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11705         (info_sources_command, search_symbols)
11706         (default_collect_symbol_completion_matches_break_on)
11707         (make_source_files_completion_list): Remove declaration.
11708         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11709         (ada_collect_symbol_completion_matches)
11710         (ada_add_global_exceptions): Remove declaration.
11711         * linespec.c (iterate_over_all_matching_symtabs): Use
11712         objfile_compunits.
11713         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11714         (class objfile_compunits): New.
11715         (ALL_COMPUNITS): Use objfile_compunits.
11716         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11717         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11718         objfile_compunits.
11719         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11720
11721 2019-01-09  Tom Tromey  <tom@tromey.com>
11722
11723         * symtab.c (search_symbols)
11724         (default_collect_symbol_completion_matches_break_on): Use
11725         objfile_msymbols.
11726         * ada-lang.c (ada_lookup_simple_minsym)
11727         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11728         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11729         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11730         objfile_msymbols.
11731         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11732         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11733         * objc-lang.c (find_methods): Use objfile_msymbols.
11734         (info_selectors_command, info_classes_command): Likewise.
11735         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11736         * objfiles.h (class objfile_msymbols): New.
11737         (ALL_OBJFILE_MSYMBOLS): Remove.
11738         (ALL_MSYMBOLS): Remove.
11739
11740 2019-01-09  Tom Tromey  <tom@tromey.com>
11741
11742         * common/next-iterator.h (next_adapter): Add Iterator template
11743         parameter.
11744         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11745         (class all_objfiles_safe): New.
11746         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11747         * objfiles.c (put_objfile_before): Update comment.
11748         (add_separate_debug_objfile): Likewise.
11749         (free_all_objfiles): Use all_objfiles_safe.
11750         (objfile_purge_solibs): Likewise.
11751
11752 2019-01-09  Tom Tromey  <tom@tromey.com>
11753
11754         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11755         (expand_symtab_containing_pc, lookup_static_symbol)
11756         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11757         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11758         all_objfiles.
11759         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11760         * breakpoint.c (create_overlay_event_breakpoint)
11761         (create_longjmp_master_breakpoint)
11762         (create_std_terminate_master_breakpoint)
11763         (create_exception_master_breakpoint): Use all_objfiles.
11764         * linux-thread-db.c (try_thread_db_load_from_pdir)
11765         (has_libpthread): Use all_objfiles.
11766         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11767         * linespec.c (iterate_over_all_matching_symtabs)
11768         (search_minsyms_for_name): Use all_objfiles.
11769         * maint.c (maintenance_info_sections): Use all_objfiles.
11770         * main.c (captured_main_1): Use all_objfiles.
11771         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11772         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11773         * guile/scm-pretty-print.c
11774         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11775         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11776         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11777         (maintenance_print_msymbols): Use all_objfiles.
11778         * source.c (select_source_symtab): Use all_objfiles.
11779         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11780         * symfile.c (remove_symbol_file_command)
11781         (expand_symtabs_matching, map_symbol_filenames): Use
11782         all_objfiles.
11783         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11784         all_objfiles.
11785         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11786         * objc-lang.c (find_methods): Use all_objfiles.
11787         * objfiles.c (have_partial_symbols, have_full_symbols)
11788         (have_minimal_symbols, qsort_cmp)
11789         (default_iterate_over_objfiles_in_search_order): Use
11790         all_objfiles.
11791         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11792         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11793         (maintenance_check_psymtabs): Use all_objfiles.
11794         (ALL_PSYMTABS): Remove.
11795         * compile/compile-object-run.c (do_module_cleanup): Use
11796         all_objfiles.
11797         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11798         * cp-support.c (add_symbol_overload_list_qualified): Use
11799         all_objfiles.
11800         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11801         Use all_objfiles.
11802         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11803         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11804         all_objfiles.
11805         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11806         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11807         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11808         Uses all_objfiles.
11809         * solib.c (solib_read_symbols): Use all_objfiles
11810
11811 2019-01-09  Tom Tromey  <tom@tromey.com>
11812
11813         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11814         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11815         all_objfiles.
11816         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11817         * symmisc.c (print_symbol_bcache_statistics)
11818         (print_objfile_statistics, maintenance_print_objfiles)
11819         (maintenance_info_symtabs, maintenance_check_symtabs)
11820         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11821         all_objfiles.
11822         * source.c (forget_cached_source_info): Use all_objfiles.
11823         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11824         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11825         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11826         * objfiles.c (update_section_map): Use all_objfiles.
11827         (shared_objfile_contains_address_p): Likewise.
11828         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11829         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11830
11831 2019-01-09  Tom Tromey  <tom@tromey.com>
11832
11833         * common/next-iterator.h: New file.
11834         * objfiles.h (class all_objfiles): New.
11835         (struct objfile_iterator): New.
11836
11837 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11838
11839         * NEWS: Move the description of the changed "frame", "select-frame",
11840          and "info frame" commands to the Changed commands section.
11841
11842 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11843
11844         * gdbtypes.c (check_stub_method_group): Remove handling of old
11845         mangling schemes.
11846         * linespec.c (find_methods): Likewise.
11847         * stabsread.c (read_member_functions): Likewise.
11848         * valops.c (search_struct_method): Likewise.
11849         (value_struct_elt_for_reference): Likewise.
11850         * NEWS: Mention this change.
11851
11852 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11853
11854         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11855         print_source_lines.
11856         * source.c (print_source_lines_base): Update line number check.
11857         (print_source_lines): New function.
11858         (source_lines_range::source_lines_range): New function.
11859         * source.h (class source_lines_range): New class.
11860         (print_source_lines): New declaration.
11861
11862 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11863
11864         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11865
11866 2019-01-08  Tom Tromey  <tom@tromey.com>
11867             Simon Marchi  <simon.marchi@ericsson.com>
11868
11869         PR gdb/24060
11870         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11871         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11872         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11873         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11874         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11875         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11876
11877 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11878
11879         * source.c (select_source_symtab): Move header comment to
11880         declaration in source.h.
11881         (forget_cached_source_info_for_objfile): Likewise.
11882         (forget_cached_source_info): Likewise.
11883         (identify_source_line): Likewise.
11884         * source.h (identify_source_line): Move declaration from symtab.h
11885         and add comment from source.c
11886         (print_source_lines): Likewise.
11887         (forget_cached_source_info_for_objfile): Likewise.
11888         (forget_cached_source_info): Likewise.
11889         (select_source_symtab): Likewise.
11890         (enum print_source_lines_flag): Move definition from symtab.h.
11891         * symtab.h (identify_source_line): Move declaration to source.h.
11892         (print_source_lines): Likewise.
11893         (forget_cached_source_info_for_objfile): Likewise.
11894         (forget_cached_source_info): Likewise.
11895         (select_source_symtab): Likewise.
11896         (enum print_source_lines_flag): Move definition to source.h.
11897         * tui/tui-hooks.c: Add 'source.h' include.
11898
11899 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11900
11901         * source.c (print_source_lines_base): Handle requests to print
11902         reverse line number sequences, and guard against empty lines
11903         string.
11904
11905 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11906
11907         * source.c (print_source_lines_base): Fix skip of '\r' if next
11908         character is '\n'.
11909
11910 2019-01-06  Tom Tromey  <tom@tromey.com>
11911
11912         * c-exp.y (struct c_parse_state) <macro_original_text,
11913         expansion_obstack>: New member.
11914         (macro_original_text, expansion_obstack): Remove globals.
11915         (scan_macro_expansion, scanning_macro_expansion)
11916         (finished_macro_expansion): Update.
11917         (scan_macro_cleanup): Remove.
11918         (yylex, c_parse): Update.
11919
11920 2019-01-06  Tom Tromey  <tom@tromey.com>
11921
11922         * c-exp.y (struct c_parse_state) <strings>: New member.
11923         (operator_stoken): Update.
11924
11925 2019-01-06  Tom Tromey  <tom@tromey.com>
11926
11927         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11928         (union type_stack_elt) <typelist_val>: Now a pointer to
11929         std::vector.
11930         (type_stack_cleanup): Don't declare.
11931         (push_typelist): Update.
11932         * parse.c (pop_typelist): Return a std::vector.
11933         (push_typelist): Take a std::vector.
11934         (follow_types): Update.  Do not free args.
11935         (type_stack_cleanup): Remove.
11936         * c-exp.y (struct c_parse_state): New.
11937         (cpstate): New global.
11938         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11939         (nonempty_typelist): Update.
11940         (func_mod): Create a new vector.
11941         (c_parse): Create a c_parse_state.
11942         (check_parameter_typelist): Do not delete params.
11943         (function_method): Update.  Do not delete type_list.
11944
11945 2019-01-06  Tom Tromey  <tom@tromey.com>
11946
11947         PR gdb/28155:
11948         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11949         check_typedef.
11950         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11951         (print_return_value): Likewise.
11952
11953 2019-01-05  Tom Tromey  <tom@tromey.com>
11954
11955         * contrib/cleanup_check.py: Remove.
11956         * contrib/gcc-with-excheck: Remove.
11957         * contrib/exsummary.py: Remove.
11958         * contrib/excheck.py: Remove.
11959
11960 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11961
11962         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11963         NULL. Initialize tpprev to NULL instead of assigning it
11964         to NULL on the next statement.
11965         * windows-nat.c (windows_delete_thread): Remove check for
11966         main_thread_id before printing thread exit notifications.
11967         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11968         Remove thread ID check against main_thread_id.
11969         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11970         windows_delete_thread.
11971         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11972
11973 2019-01-04  Tom Tromey  <tom@tromey.com>
11974
11975         * compile/compile.c (_initialize_compile): Use upper case for
11976         metasyntactic variables.
11977         * symmisc.c (_initialize_symmisc): Use upper case for
11978         metasyntactic variables.
11979         * psymtab.c (_initialize_psymtab): Use upper case for
11980         metasyntactic variables.
11981         * demangle.c (demangle_command): Use upper case for metasyntactic
11982         variables.
11983         (_initialize_demangler): Likewise.
11984         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11985         variables.
11986
11987 2019-01-03  Tom Tromey  <tom@tromey.com>
11988
11989         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11990
11991 2019-01-03  Tom Tromey  <tom@tromey.com>
11992
11993         * python/py-symtab.c (salpy_str): Update.
11994         (struct salpy_sal_object) <symtab>: Now a PyObject.
11995         (salpy_dealloc): Update.
11996         (del_objfile_sal): Use gdbpy_ref.
11997
11998 2019-01-03  Tom Tromey  <tom@tromey.com>
11999
12000         * python/py-type.c (convert_field): Use new_reference.  Return
12001         gdbpy_ref.
12002         (make_fielditem): Return gdbpy_ref.
12003         (typy_fields): Update.
12004         (typy_getitem): Update.
12005         (field_name): Return gdbpy_ref.  Use new_reference.
12006         (typy_iterator_iternext): Update.
12007
12008 2019-01-03  Tom Tromey  <tom@tromey.com>
12009
12010         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12011
12012 2019-01-03  Tom Tromey  <tom@tromey.com>
12013
12014         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12015         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12016         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12017         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12018         (pspy_set_type_printers): Likewise.
12019         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12020         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12021         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12022         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12023         (objfpy_set_type_printers): Likewise.
12024
12025 2019-01-03  Tom Tromey  <tom@tromey.com>
12026
12027         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12028         (gdbpy_print_stack): Use gdbpy_err_fetch.
12029         * python/python-internal.h (class gdbpy_err_fetch): New class.
12030         (class gdbpy_enter) <m_error_type, m_error_value,
12031         m_error_traceback>: Remove.
12032         <m_error>: New member.
12033         (gdbpy_exception_to_string): Don't declare.
12034         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12035         * python/py-value.c (convert_value_from_python): Use
12036         gdbpy_err_fetch.
12037         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12038         gdbpy_exception_to_string.
12039         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12040         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12041         gdbpy_err_fetch.
12042
12043 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12044
12045         * linux-nat.c (delete_lwp_cleanup): Delete.
12046         (struct lwp_deleter): New struct.
12047         (lwp_info_up): New typedef.
12048         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12049         lwp_info_up.
12050
12051 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12052
12053         * linux-fork.c (class scoped_switch_fork_info): New class.
12054         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12055
12056 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12057
12058         * valops.c (find_overload_match): Remove use of null_cleanup, and
12059         calls to do_cleanups.
12060
12061 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12062
12063         * compile/compile-cplus-types.c
12064         (compile_cplus_instance::decl_name): Handle changes to
12065         cp_func_name.
12066         * cp-support.c (cp_func_name): Update header comment, update
12067         return type.
12068         * cp-support.h (cp_func_name): Update return type in declaration.
12069         * valops.c (find_overload_match): Move temp_func local to top
12070         level of function and change its type.  Use temp_func to hold and
12071         delete temporary string obtained from cp_func_name.
12072
12073 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12074
12075         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12076         gdb::char_vector, remove cleanup, and update uses of `msg`.
12077
12078 2019-01-03  Jim Wilson  <jimw@sifive.com>
12079
12080         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12081
12082 2019-01-02  Tom Tromey  <tom@tromey.com>
12083
12084         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12085         (tdesc_parse_xml): Remove cleanups.
12086         * target-descriptions.h (make_cleanup_free_target_description):
12087         Don't declare.
12088         (target_desc_deleter): New struct.
12089         (target_desc_up): New typedef.
12090         * target-descriptions.c (target_desc_deleter::operator()): Rename
12091         from free_target_description.
12092         (make_cleanup_free_target_description): Remove.
12093
12094 2019-01-02  Tom Tromey  <tom@tromey.com>
12095
12096         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12097         constructor, destructor.
12098         (linespec_parser): Remove typedef.
12099         (~linespec_parser): Rename from linespec_parser_delete.
12100         (linespec_lex_to_end, linespec_complete_label)
12101         (linespec_complete): Update.
12102         (decode_line_full): Remove cleanups.
12103         (decode_line_1): Update.
12104
12105 2019-01-02  Tom Tromey  <tom@tromey.com>
12106
12107         * python/python-internal.h (inferior_to_inferior_object): Change
12108         return type.
12109         * python/py-exitedevent.c (create_exited_event_object): Update.
12110         * python/py-inferior.c (inferior_to_inferior_object): Return
12111         gdbpy_ref.
12112         (python_new_inferior, python_inferior_deleted)
12113         (thread_to_thread_object, delete_thread_object)
12114         (build_inferior_list, gdbpy_selected_inferior): Update.
12115         * python/py-infthread.c (create_thread_object): Update.  Also fail
12116         if inferior_to_inferior_object fails.
12117
12118 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12119
12120         * inferior.h (class inferior) <displaced_step_state>: New field.
12121         * infrun.h (struct displaced_step_state): Move here from
12122         infrun.c.  Initialize fields, add constructor.
12123         <inf>: Remove field.
12124         <reset>: New method.
12125         * infrun.c (struct displaced_step_inferior_state): Move to
12126         infrun.h.
12127         (displaced_step_inferior_states): Remove.
12128         (get_displaced_stepping_state): Adust.
12129         (displaced_step_in_progress_any_inferior): Adjust.
12130         (displaced_step_in_progress_thread): Adjust.
12131         (displaced_step_in_progress): Adjust.
12132         (add_displaced_stepping_state): Remove.
12133         (get_displaced_step_closure_by_addr): Adjust.
12134         (remove_displaced_stepping_state): Remove.
12135         (infrun_inferior_exit): Call displaced_step_state.reset.
12136         (use_displaced_stepping): Don't check for NULL.
12137         (displaced_step_prepare_throw): Call
12138         get_displaced_stepping_state.
12139         (displaced_step_fixup): Don't check for NULL.
12140         (prepare_for_detach): Don't check for NULL.
12141
12142 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12143
12144         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12145          in case of call that did not complete.
12146
12147 2019-01-02  Andrey Utkin  <autkin@undo.io>
12148
12149         * symfile.c (find_separate_debug_file): Fix search of debug files for
12150         remote debuggee.
12151
12152 2019-01-02  Tom Tromey  <tom@tromey.com>
12153
12154         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12155         indentation.
12156         * python/py-frame.c (frapy_older): Remove cast.
12157         (frapy_newer): Likewise.
12158         * python/py-breakpoint.c (local_setattro): Remove cast.
12159         * python/py-arch.c (archpy_name): Remove local variable.
12160         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12161
12162 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12163
12164         * unittests/basic_string_view/element_access/char/empty.cc:
12165         Fix year range in copyright header.
12166
12167 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12168
12169         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12170         Delete.
12171         <operator==>: Update with for removed field.
12172         <hash>: Likewise.
12173         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12174         <isa_features>: ...this.
12175         <abi_features>: New field.
12176         (riscv_isa_flen): Update comment.
12177         (riscv_abi_xlen): New declaration.
12178         (riscv_abi_flen): New declaration.
12179         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12180         isa_features.
12181         (riscv_abi_xlen): New function.
12182         (riscv_isa_flen): Update to get answer from isa_features.
12183         (riscv_abi_flen): New function.
12184         (riscv_has_fp_abi): Update to get answer from abi_features.
12185         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12186         xlen and flen.
12187         (riscv_call_info) <xlen, flen>: Update comment.
12188         (riscv_call_arg_struct): Remove invalid assertions
12189         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12190         is removed.
12191         (riscv_gdbarch_init): Gather isa features and abi features
12192         separately, ensure both match on the gdbarch when reusing an old
12193         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12194         a target with 64-bit float hardware.
12195
12196 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12197
12198         * source.c (search_command_helper): Stop reverse search
12199         when line 1 has been searched.
12200
12201 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12202
12203         * record-full.c (record_full_base_target::close): Rewrite
12204         record_full_core_buf_list free logic.
12205
12206 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12207
12208         * break-catch-syscall.c (print_one_catch_syscall): xfree
12209         the last text.
12210
12211 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12212
12213         * top.c (print_gdb_version): Update Copyright year in version
12214         message.
12215
12216 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12217
12218         Update copyright year range in all GDB files.
12219
12220 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12221
12222         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12223
12224 For older changes see ChangeLog-2018.
12225 \f
12226 Local Variables:
12227 mode: change-log
12228 left-margin: 8
12229 fill-column: 74
12230 version-control: never
12231 coding: utf-8
12232 End:
12233