gdb/ChangeLog

   1 2019-03-15  Tom Tromey  <tom@tromey.com>
   2
   3         * symfile.c (reread_symbols): Update.
   4         * objfiles.c (objfile::objfile): Update.
   5         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
   6         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
   7         comment.
   8         (minimal_symbol_reader::install): Update.
   9         (terminate_minimal_symbol_table): Remove.
  10         * jit.c (jit_object_close_impl): Update.
  11
  12 2019-03-15  Tom Tromey  <tom@tromey.com>
  13
  14         * minsyms.c (minimal_symbol_reader::record_full): Remove some
  15         initializations.
  16
  17 2019-03-15  Tom Tromey  <tom@tromey.com>
  18
  19         * objfiles.h (struct objfile_per_bfd_storage)
  20         <demangled_hash_languages>: Now a bitset.
  21         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
  22         (lookup_minimal_symbol): Update.
  23
  24 2019-03-15  Tom Tromey  <tom@tromey.com>
  25
  26         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
  27         Don't return the symbol.
  28         * coffread.c (record_minimal_symbol): Use record_full.
  29
  30 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
  31
  32         The MS-Windows port of ncurses fails to switch to a color pair if
  33         one or both of the colors are the implicit default colors.  This
  34         change records the default colors when TUI is initialized, and
  35         then specifies them explicitly when a color pair uses the default
  36         colors.  This allows color styling in TUI mode on MS-Windows.
  37
  38         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
  39         ncurses_norm_attr.
  40         (tui_initialize_io) [__MINGW32__]: Record the default terminal
  41         colors in ncurses_norm_attr.
  42         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
  43         "none", replace it with the default color recorded in
  44         ncurses_norm_attr.
  45
  46 2019-03-14  Tom Tromey  <tromey@adacore.com>
  47
  48         * source-cache.h (class source_cache) <get_source_lines>: Return
  49         std::string.
  50         * source-cache.c (source_cache::extract_lines): Handle case where
  51         first_pos==npos.  Return std::string.
  52         (source_cache::get_source_lines): Update.
  53
  54 2019-03-14  Tom Tromey  <tromey@adacore.com>
  55
  56         * NEWS: Add item for "style sources" commands.
  57         * source-cache.c (source_cache::get_source_lines): Check
  58         source_styling.
  59         * cli/cli-style.c (source_styling): New global.
  60         (_initialize_cli_style): Add "style sources" commands.
  61         (show_style_sources): New function.
  62         * cli/cli-style.h (source_styling): Declare.
  63
  64 2019-03-14  Pedro Alves  <palves@redhat.com>
  65             Tom Tromey  <tromey@adacore.com>
  66
  67         * tui/tui-winsource.h (tui_refill_source_window): Declare.
  68         * tui/tui-winsource.c (tui_refill_source_window): New function,
  69         from...
  70         (tui_horizontal_source_scroll): ... here.  Move some logic.
  71         * cli/cli-style.c (set_style_enabled): Notify new observable.
  72         * tui/tui-hooks.c (tui_redisplay_source): New function.
  73         (tui_attach_detach_observers): Attach or detach
  74         tui_redisplay_source.
  75         * observable.h (source_styling_changed): New observable.
  76         * observable.c: Define source_styling_changed observable.
  77
  78 2019-03-13  Tom Tromey  <tromey@adacore.com>
  79
  80         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
  81         (i386_gnu_nat_target::store_registers): Update.
  82         * target-debug.h (target_debug_print_std_string): New macro.
  83         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
  84         * windows-tdep.c (display_one_tib): Update.
  85         * tui/tui-stack.c (tui_make_status_line): Update.
  86         * top.c (print_inferior_quit_action): Update.
  87         * thread.c (thr_try_catch_cmd): Update.
  88         (add_thread_with_info): Update.
  89         (thread_target_id_str): Update.
  90         (thr_try_catch_cmd): Update.
  91         (thread_command): Update.
  92         (thread_find_command): Update.
  93         * record-btrace.c (record_btrace_target::info_record)
  94         (record_btrace_resume_thread, record_btrace_target::resume)
  95         (record_btrace_cancel_resume, record_btrace_step_thread)
  96         (record_btrace_target::wait, record_btrace_target::wait)
  97         (record_btrace_target::wait, record_btrace_target::stop): Update.
  98         * progspace.c (print_program_space): Update.
  99         * process-stratum-target.c
 100         (process_stratum_target::thread_address_space): Update.
 101         * linux-fork.c (linux_fork_mourn_inferior)
 102         (detach_checkpoint_command, info_checkpoints_command)
 103         (linux_fork_context): Update.
 104         (linux_fork_detach): Update.
 105         (class scoped_switch_fork_info): Update.
 106         (delete_checkpoint_command): Update.
 107         * infrun.c (follow_fork_inferior): Update.
 108         (follow_fork_inferior): Update.
 109         (proceed_after_vfork_done): Update.
 110         (handle_vfork_child_exec_or_exit): Update.
 111         (follow_exec): Update.
 112         (displaced_step_prepare_throw): Update.
 113         (displaced_step_restore): Update.
 114         (start_step_over): Update.
 115         (resume_1): Update.
 116         (clear_proceed_status_thread): Update.
 117         (proceed): Update.
 118         (print_target_wait_results): Update.
 119         (do_target_wait): Update.
 120         (context_switch): Update.
 121         (stop_all_threads): Update.
 122         (restart_threads): Update.
 123         (finish_step_over): Update.
 124         (handle_signal_stop): Update.
 125         (switch_back_to_stepped_thread): Update.
 126         (keep_going_pass_signal): Update.
 127         (print_exited_reason): Update.
 128         (normal_stop): Update.
 129         * inferior.c (inferior_pid_to_str): Change return type.
 130         (print_selected_inferior): Update.
 131         (add_inferior): Update.
 132         (detach_inferior): Update.
 133         * dummy-frame.c (fprint_dummy_frames): Update.
 134         * dcache.c (dcache_info_1): Update.
 135         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 136         (btrace_fetch, btrace_clear): Update.
 137         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 138         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 139         type.
 140         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 141         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 142         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 143         * gdbarch.c, gdbarch.h: Rebuild.
 144         * gdbarch.sh (core_pid_to_str): Change return type.
 145         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 146         return type.
 147         (windows_nat_target::pid_to_str): Change return type.
 148         (windows_delete_thread): Update.
 149         (windows_nat_target::attach): Update.
 150         (windows_nat_target::files_info): Update.
 151         * target-delegates.c: Rebuild.
 152         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 153         return type.
 154         (sol_thread_target::pid_to_str): Change return type.
 155         * remote.c (class remote_target) <pid_to_str>: Change return
 156         type.
 157         (remote_target::pid_to_str): Change return type.
 158         (extended_remote_target::attach, remote_target::remote_stop_ns)
 159         (remote_target::remote_notif_remove_queued_reply)
 160         (remote_target::push_stop_reply, remote_target::disable_btrace):
 161         Update.
 162         (extended_remote_target::attach): Update.
 163         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 164         type.
 165         (gdbsim_target::pid_to_str): Change return type.
 166         * ravenscar-thread.c (struct ravenscar_thread_target)
 167         <pid_to_str>: Change return type.
 168         (ravenscar_thread_target::pid_to_str): Change return type.
 169         * procfs.c (class procfs_target) <pid_to_str>: Change return
 170         type.
 171         (procfs_target::pid_to_str): Change return type.
 172         (procfs_target::attach): Update.
 173         (procfs_target::detach): Update.
 174         (procfs_target::fetch_registers): Update.
 175         (procfs_target::store_registers): Update.
 176         (procfs_target::wait): Update.
 177         (procfs_target::files_info): Update.
 178         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 179         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 180         return type.
 181         (nto_procfs_target::pid_to_str): Change return type.
 182         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 183         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 184         return type.
 185         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 186         (exit_lwp): Update.
 187         (attach_proc_task_lwp_callback, get_detach_signal)
 188         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 189         (linux_nat_target::resume, wait_lwp, stop_callback)
 190         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 191         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 192         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 193         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 194         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 195         type.
 196         (inf_ptrace_target::attach): Update.
 197         (inf_ptrace_target::files_info): Update.
 198         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 199         type.
 200         (go32_nat_target::pid_to_str): Change return type.
 201         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 202         (gnu_nat_target::wait): Update.
 203         (gnu_nat_target::wait): Update.
 204         (gnu_nat_target::resume): Update.
 205         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 206         (fbsd_nat_target::wait): Update.
 207         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 208         type.
 209         (darwin_nat_target::attach): Update.
 210         * corelow.c (class core_target) <pid_to_str>: Change return type.
 211         (core_target::pid_to_str): Change return type.
 212         * target.c (normal_pid_to_str): Change return type.
 213         (default_pid_to_str): Likewise.
 214         (target_pid_to_str): Change return type.
 215         (target_translate_tls_address): Update.
 216         (target_announce_detach): Update.
 217         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 218         return type.
 219         (bsd_uthread_target::pid_to_str): Change return type.
 220         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 221         type.
 222         (bsd_kvm_target::pid_to_str): Change return type.
 223         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 224         return type.
 225         (aix_thread_target::pid_to_str): Change return type.
 226         * target.h (struct target_ops) <pid_to_str>: Change return type.
 227         (target_pid_to_str, normal_pid_to_str): Likewise.
 228         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 229         type.
 230         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 231         type.
 232         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 233         return type.
 234         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 235         type.
 236         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 237         type.
 238         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 239         return type.
 240
 241 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 242
 243         * NEWS: Mention that the new default MI version is 3.  Mention
 244         changes to the output of commands and events that deal with
 245         multi-location breakpoints.
 246         * breakpoint.c: Include "mi/mi-out.h".
 247         (print_one_breakpoint): Change output syntax if using MI version
 248         >= 3.
 249         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 250         New.
 251         (mi_multi_location_breakpoint_output_fixed): New.
 252         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 253         (mi_cmd_fix_multi_location_breakpoint_output): New.
 254         (mi_multi_location_breakpoint_output_fixed): New.
 255         * mi/mi-cmds.c (mi_cmds): Register command
 256         -fix-multi-location-breakpoint-output.
 257         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 258         interpreter "mi".
 259
 260 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 261
 262         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 263         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 264         instantiate mi_ui_out based on interpreter name.
 265         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 266         * mi/mi-main.c (mi_load_progress): Likewise.
 267
 268 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 269
 270         * NEWS: Combine separate "New targets" sections for 8.3.
 271
 272 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 273
 274         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 275         (ppcfbsd_init_abi): Install gdbarch
 276         "fetch_tls_load_module_address" and "get_thread_local_address"
 277         methods.
 278
 279 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 280
 281         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 282         (riscv_fbsd_init_abi): Install gdbarch
 283         "fetch_tls_load_module_address" and "get_thread_local_address"
 284         methods.
 285
 286 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 287
 288         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 289         (i386fbsd_init_abi): Install gdbarch
 290         "fetch_tls_load_module_address" and "get_thread_local_address"
 291         methods.
 292
 293 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 294
 295         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 296         (amd64fbsd_init_abi): Install gdbarch
 297         "fetch_tls_load_module_address" and "get_thread_local_address"
 298         methods.
 299
 300 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 301
 302         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 303         (struct fbsd_pspace_data): New type.
 304         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 305         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 306         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 307         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 308         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 309
 310 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 311
 312         * gdbtypes.c (lookup_struct_elt): New function.
 313         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 314         * gdbtypes.h (struct struct_elt): New type.
 315         (lookup_struct_elt): New prototype.
 316
 317 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 318
 319         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 320         remove disabled code block.
 321
 322 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 323
 324         * gdbarch.sh (get_thread_local_address): New method.
 325         * gdbarch.h, gdbarch.c: Regenerate.
 326         * target.c (target_translate_tls_address): Use
 327         gdbarch_get_thread_local_address if present instead of
 328         target::get_thread_local_address.
 329
 330 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 331
 332         * target.h (target::get_thread_local_address): Update comment.
 333
 334 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 335
 336         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 337         objfile->separate_debug_objfile_backlink if not NULL.
 338
 339 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 340
 341         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 342         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 343         (amd64bsd_store_inferior_registers): Likewise.
 344         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 345         Enable segment base registers.
 346         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 347         PT_GETFSBASE and PT_GETGSBASE.
 348         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 349         PT_SETGSBASE.
 350         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 351         segment base registers.
 352         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 353
 354 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 355
 356         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 357         Update calls to i386_target_description to add 'segments'
 358         parameter.
 359         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 360         add segment base registers.
 361         * arch/i386.c (i386_create_target_description): Add 'segments'
 362         parameter to enable segment base registers.
 363         * arch/i386.h (i386_create_target_description): Likewise.
 364         * features/i386/32bit-segments.xml: New file.
 365         * features/i386/32bit-segments.c: Generate.
 366         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 367         call to i386_target_description to add 'segments' parameter.
 368         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 369         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 370         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 371         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 372         if feature is present.
 373         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 374         Add 'segments' parameter to call to i386_target_description.
 375         (i386_target_description): Add 'segments' parameter to enable
 376         segment base registers.
 377         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 378         to call to i386_target_description.
 379         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 380         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 381         Define I386_NUM_REGS.
 382         (i386_target_description): Add 'segments' parameter to enable
 383         segment base registers.
 384
 385 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 386
 387         PR/24325
 388         * source-cache.c: #undef open and close, to avoid unresolved
 389         externals during linking.
 390
 391 2019-03-12  Tom Tromey  <tromey@adacore.com>
 392
 393         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 394         const.  Add initializers.
 395         (_initialize_remote): Don't initialize ptid globals.
 396
 397 2019-03-12  Pedro Alves  <palves@redhat.com>
 398
 399         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 400
 401 2019-03-12  Pedro Alves  <palves@redhat.com>
 402
 403         * cp-name-parser.y (main): Remove unused 'len' variable.
 404
 405 2019-03-12  Tom Tromey  <tromey@adacore.com>
 406
 407         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 408         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 409
 410 2019-03-12  Tom Tromey  <tromey@adacore.com>
 411
 412         * linux-nat.c (iterate_over_lwps): Update.
 413         (stop_callback): Remove parameter.
 414         (stop_wait_callback, detach_callback, resume_set_callback)
 415         (select_singlestep_lwp_callback, set_ignore_sigint)
 416         (status_callback, resumed_callback, resume_clear_callback)
 417         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 418         data parameter.
 419         (linux_nat_target::detach, linux_nat_target::resume)
 420         (linux_stop_and_wait_all_lwps, select_event_lwp)
 421         (linux_nat_filter_event, linux_nat_wait_1)
 422         (linux_nat_target::kill, linux_nat_target::stop)
 423         (linux_nat_target::stop): Update.
 424         (linux_nat_resume_callback): Change type.
 425         (resume_stopped_resumed_lwps, count_events_callback)
 426         (select_event_lwp_callback): Likewise.
 427         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 428         * arm-linux-nat.c (struct update_registers_data): Remove.
 429         (update_registers_callback): Change type.
 430         (arm_linux_insert_hw_breakpoint1): Update.
 431         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 432         parameter.
 433         (x86_linux_dr_set_addr): Update.
 434         (x86_linux_dr_set_control): Update.
 435         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 436         (iterate_over_lwps): Use gdb::function_view.
 437         * nat/aarch64-linux-hw-point.c (struct
 438         aarch64_dr_update_callback_param): Remove.
 439         (debug_reg_change_callback): Change type.
 440         (aarch64_notify_debug_reg_change): Update.
 441         * s390-linux-nat.c (s390_refresh_per_info): Update.
 442
 443 2019-03-11  Tom Tromey  <tromey@adacore.com>
 444
 445         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 446         redundant assignment to "this_cu".
 447
 448 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 449
 450         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 451
 452 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 453
 454         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 455         from...
 456         (rank_one_type): ... this.
 457
 458 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 459
 460         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 461         from...
 462         (rank_one_type): ... this.
 463
 464 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 465
 466         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 467         from...
 468         (rank_one_type): ... this.
 469
 470 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 471
 472         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 473         from...
 474         (rank_one_type): ... this.
 475
 476 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 477
 478         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 479         from...
 480         (rank_one_type): ... this.
 481
 482 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 483
 484         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 485         from...
 486         (rank_one_type): ... this.
 487
 488 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 489
 490         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 491         from...
 492         (rank_one_type): ... this.
 493
 494 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 495
 496         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 497         from...
 498         (rank_one_type): ... this.
 499
 500 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 501
 502         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 503         from...
 504         (rank_one_type): ... this.
 505
 506 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 507
 508         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 509         from...
 510         (rank_one_type): ... this.
 511
 512 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 513
 514         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 515         from...
 516         (rank_one_type): ... this.
 517
 518 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 519
 520         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 521         from...
 522         (rank_one_type): ... this.
 523
 524 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 525
 526         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 527         inferior-events' shows the example events.
 528
 529 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 530
 531         Support styling on native MS-Windows console
 532
 533         PR/24315
 534         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 535         on MS-Windows if $TERM is not defined.
 536
 537         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 538
 539         * posix-hdep.c (gdb_console_fputs):
 540         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 541         functions.
 542         * ui-file.h (gdb_console_fputs): Add prototype.
 543
 544         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 545         back to fputs only if the former returns zero.
 546
 547 2019-03-07  Tom Tromey  <tom@tromey.com>
 548
 549         * symmisc.c (print_symbol_bcache_statistics): Update.
 550         (print_objfile_statistics): Update.
 551         * symfile.c (allocate_symtab): Update.
 552         * stabsread.c: Don't include bcache.h.
 553         * psymtab.h (struct psymbol_bcache): Don't declare.
 554         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 555         (psymbol_bcache_init, psymbol_bcache_free)
 556         (psymbol_bcache_get_bcache): Don't declare.
 557         * psymtab.c (struct psymbol_bcache): Remove.
 558         (psymtab_storage::psymtab_storage): Update.
 559         (psymtab_storage::~psymtab_storage): Update.
 560         (psymbol_bcache_init, psymbol_bcache_free)
 561         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 562         (add_psymbol_to_bcache): Update.
 563         (allocate_psymtab): Update.
 564         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 565         macro_cache>: No longer pointers.
 566         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 567         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 568         * macrotab.c (macro_bcache): Update.
 569         * macroexp.c: Don't include bcache.h.
 570         * gdbtypes.c (check_types_worklist): Update.
 571         (types_deeply_equal): Remove TRY/CATCH.  Update.
 572         * elfread.c (elf_symtab_read): Update.
 573         * dwarf2read.c: Don't include bcache.h.
 574         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 575         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 576         (print_bcache_statistics, bcache_memory_used): Don't declare.
 577         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 578         methods.  Rename all data members.
 579         * bcache.c (struct bcache): Move to bcache.h.
 580         (bcache::expand_hash_table): Rename from expand_hash_table.
 581         (bcache): Remove.
 582         (bcache::insert): Rename from bcache_full.
 583         (bcache::compare): Rename from bcache_compare.
 584         (bcache_xmalloc): Remove.
 585         (bcache::~bcache): Rename from bcache_xfree.
 586         (bcache::print_statistics): Rename from print_bcache_statistics.
 587         (bcache::memory_used): Rename from bcache_memory_used.
 588
 589 2019-03-07  Pedro Alves  <palves@redhat.com>
 590
 591         * infrun.c (normal_stop): Also check for
 592         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 593
 594 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 595
 596         * f-lang.c (value_from_host_double): Moved to...
 597         * value.c (value_from_host_double): ...here.
 598         * value.h (value_from_host_double): Declare.
 599         * guile/scm-math.c (vlscm_convert_typed_number): Use
 600         value_from_host_double.
 601         (vlscm_convert_number): Likewise.
 602         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 603         * python/py-value.c (convert_value_from_python): Likewise.
 604
 605 2019-03-06  Tom Tromey  <tom@tromey.com>
 606
 607         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 608
 609 2019-03-06  Tom Tromey  <tom@tromey.com>
 610
 611         * utils.h (free_current_contents): Don't declare.
 612         * utils.c (free_current_contents): Remove.
 613
 614 2019-03-06  Tom Tromey  <tom@tromey.com>
 615
 616         * top.c (quit_force): Update.
 617         * main.c (captured_command_loop): Update.
 618         * common/new-op.c (operator new): Update.
 619         * common/common-exceptions.c (struct catcher)
 620         <save_cleanup_chain>: Remove member.
 621         (exceptions_state_mc_init): Update.
 622         (exception_try_scope_entry): Return nullptr.
 623         (exception_try_scope_exit, exception_rethrow)
 624         (throw_exception_sjlj, throw_exception_cxx): Update.
 625         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 626         (all_cleanups, do_cleanups, discard_cleanups)
 627         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 628         (restore_cleanups, restore_final_cleanups): Don't declare.
 629         (do_final_cleanups): Remove parameter.
 630         * common/cleanups.c (cleanup_chain, make_cleanup)
 631         (make_cleanup_dtor, all_cleanups, do_cleanups)
 632         (discard_my_cleanups, discard_cleanups)
 633         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 634         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 635         (null_cleanup): Remove.
 636         (do_final_cleanups): Remove parameter.
 637
 638 2019-03-06  Tom Tromey  <tom@tromey.com>
 639
 640         * remote.c (remote_target::remote_parse_stop_reply): Use
 641         unique_xmalloc_ptr.
 642
 643 2019-03-06  Tom Tromey  <tom@tromey.com>
 644
 645         * stabsread.c (struct stabs_field_info): Rename from field_info.
 646         <list, fnlist>: Add initializers.
 647         <obstack>: New member.
 648         (read_member_functions, read_struct_fields, read_baseclasses):
 649         Allocate on obstack.  Don't use cleanups.
 650         (read_one_struct_field, read_member_functions, read_struct_fields)
 651         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 652         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 653         (read_struct_type): Update.
 654
 655 2019-03-06  Tom Tromey  <tom@tromey.com>
 656
 657         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 658         * common/filestuff.h (make_cleanup_close): Don't declare.
 659         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 660         Remove.
 661
 662 2019-03-06  Tom Tromey  <tom@tromey.com>
 663
 664         * solib-aix.c: Use make_scope_exit.
 665
 666 2019-03-06  Tom Tromey  <tom@tromey.com>
 667
 668         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 669         Use make_scope_exit.
 670
 671 2019-03-06  Tom Tromey  <tom@tromey.com>
 672
 673         * solib-svr4.c (disable_probes_interface): Remove parameter.
 674         (svr4_handle_solib_event): Use make_scope_exit.
 675
 676 2019-03-06  Tom Tromey  <tom@tromey.com>
 677
 678         * remote.c (struct stop_reply_deleter): Remove.
 679         (stop_reply_up): Update.
 680         (struct stop_reply): Derive from notif_event.  Don't typedef.
 681         <regcache>: Now a std::vector.
 682         (stop_reply_xfree): Remove.
 683         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 684         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 685         (remote_target::discard_pending_stop_replies): Use delete.
 686         (remote_target::remote_parse_stop_reply): Update.
 687         (remote_target::process_stop_reply): Update.
 688         * remote-notif.h (struct notif_event): Add virtual destructor.
 689         Remove "dtr" member.
 690         (struct notif_client) <alloc_event>: Return a unique_ptr.
 691         (notif_event_xfree): Don't declare.
 692         (notif_event_up): New typedef.
 693         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 694         (notif_event_xfree, do_notif_event_xfree): Remove.
 695         (remote_notif_state_xfree): Update.
 696
 697 2019-03-06  Tom Tromey  <tom@tromey.com>
 698
 699         * infrun.c (displaced_step_clear_cleanup): Now a
 700         forward_scope_exit type.
 701         (displaced_step_prepare_throw): Update.
 702         (displaced_step_fixup): Update.
 703
 704 2019-03-06  Tom Tromey  <tom@tromey.com>
 705
 706         * inferior.h (class inferior): Update comment.
 707         * gdbthread.h (class thread_info): Update comment.
 708
 709 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 710             Tom Tromey  <tom@tromey.com>
 711
 712         * stabsread.h (struct stab_section_list): Remove.
 713         (coffstab_build_psymtabs): Update.
 714         * dbxread.c (symbuf_sections): Now a std::vector.
 715         (sect_idx): New global.
 716         (fill_symbuf): Update.
 717         (coffstab_build_psymtabs): Change type of stabsects parameter.
 718         Update.
 719         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 720         std::vector.
 721         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 722         (coff_locate_sections): Update.
 723         (coff_symfile_read): Remove cleanups.  Update.
 724         (init_stringtab): Add storage parameter.
 725         (free_stringtab, free_stringtab_cleanup): Remove.
 726         (init_lineno): Add storage parameter.
 727         (free_linetab, free_linetab_cleanup): Remove.
 728
 729 2019-03-06  Pedro Alves  <palves@redhat.com>
 730
 731         * linux-fork.c (fork_info::clobber_regs): Delete.
 732         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 733         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 734         comment.  Adjust.
 735         (scoped_switch_fork_info::scoped_switch_fork_info)
 736         (checkpoint_command, linux_fork_context): Adjust
 737         fork_save_infrun_state calls.
 738
 739 2019-03-06  Pedro Alves  <palves@redhat.com>
 740
 741         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 742         (inf_has_multiple_threads): Return 'bool' and rewrite using
 743         inferior_info::threads().
 744
 745 2019-03-06  Pedro Alves  <palves@redhat.com>
 746
 747         * linux-fork.c: Include <list>.
 748         (fork_list): Now a std::list instance.
 749         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 750         (forks_exist_p, find_last_fork): Adjust.
 751         (new_fork): Delete.
 752         (one_fork_p): New.
 753         (add_fork): Adjust.
 754         (free_fork): Delete, folded into fork_info::~fork_info().
 755         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 756         Adjust.
 757         (init_fork_list): Delete.
 758         (linux_fork_killall, linux_fork_mourn_inferior)
 759         (linux_fork_detach, info_checkpoints_command): Adjust.
 760         (_initialize_linux_fork): No longer call init_fork_list.
 761
 762 2019-03-06  Pedro Alves  <palves@redhat.com>
 763
 764         * linux-fork.c (new_fork): New, split out of ...
 765         (add_fork): ... this.  Return void.  Move "first fork" special
 766         case from here, to ...
 767         (checkpoint_command): ... here.
 768         * linux-linux.h (add_fork): Return void.
 769
 770 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 771
 772         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 773
 774 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 775             Chris January  <chris.january@arm.com>
 776             David Lecomber  <david.lecomber@arm.com>
 777
 778         * f-exp.y: New token, UNOP_INTRINSIC.
 779         (exp): New pattern using UNOP_INTRINSIC token.
 780         (f77_keywords): Add 'abs' keyword.
 781         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 782         (value_from_host_double): New function.
 783         (evaluate_subexp_f): Support UNOP_ABS.
 784
 785 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 786
 787         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 788         types.
 789
 790 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 791
 792         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 793         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 794         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 795
 796 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 797
 798         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 799
 800 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 801             Chris January  <chris.january@arm.com>
 802
 803         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 804         * f-exp.y: Define 'KIND' token.
 805         (exp): New pattern for KIND expressions.
 806         (ptype): Handle types with a kind extension.
 807         (direct_abs_decl): Extend to spot kind extensions.
 808         (f77_keywords): Add 'kind' to the list.
 809         (push_kind_type): New function.
 810         (convert_to_kind_type): New function.
 811         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 812         * parse.c (operator_length_standard): Likewise.
 813         * parser-defs.h (enum type_pieces): Add tp_kind.
 814         * std-operator.def: Add UNOP_KIND.
 815
 816 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 817
 818         * f-exp.y (f_parse): Set yydebug.
 819
 820 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 821
 822         * f-lang.c (evaluate_subexp_f): New function.
 823         (exp_descriptor_f): New global.
 824         (f_language_defn): Use exp_descriptor_f instead of
 825         exp_descriptor_standard.
 826
 827 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 828
 829         * f-exp.y (struct token): Add comments.
 830         (dot_ops): Remove uppercase versions and the end marker.
 831         (f77_keywords): Likewise.
 832         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 833         entries in the dot_ops array are case insensitive, and use
 834         strncasecmp to compare strings.  Also some whitespace cleanup in
 835         this area.  Similar for the f77_keywords array, except entries in
 836         this list might be case sensitive.
 837
 838 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 839
 840         * f-exp.y (struct f77_boolean_val): Add comments.
 841         (boolean_values): Remove uppercase versions, and end marker.
 842         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 843         and use strncasecmp to achieve case insensitivity.  Additionally,
 844         perform whitespace cleanup around this code.
 845
 846 2019-03-06  Tom Tromey  <tromey@adacore.com>
 847
 848         * remote-sim.c (gdbsim_target_open): Use result of
 849         gdb_argv::release.
 850
 851 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 852         Dirk Schubert  <dirk.schubert@arm.com>
 853         Chris January  <chris.january@arm.com>
 854
 855         * eval.c (evaluate_subexp_standard): Call Fortran argument
 856         wrapping logic.
 857         * f-lang.c (struct value): A value which can be passed into a
 858         Fortran function call.
 859         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 860         where appropriate.
 861         (struct type): Value ready for a Fortran function call.
 862         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 863         is needed.
 864         * f-lang.h (fortran_argument_convert): Declaration.
 865         (fortran_preserve_arg_pointer): Declaration.
 866         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 867
 868 2019-03-05  Tom Tromey  <tromey@adacore.com>
 869
 870         * python/py-prettyprint.c (print_string_repr): Remove #if.
 871         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 872
 873 2019-03-05  Tom Tromey  <tromey@adacore.com>
 874
 875         * target.c (the_dummy_target): Move later.  Change type to
 876         "dummy_target".
 877         (initialize_targets): Don't initialize the_dummy_target.
 878
 879 2019-03-05  Tom Tromey  <tromey@adacore.com>
 880
 881         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 882         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 883
 884 2019-03-05  Tom Tromey  <tromey@adacore.com>
 885
 886         * windows-nat.c (windows_nat_target::attach)
 887         (windows_nat_target::detach): Don't call gdb_flush.
 888         * valprint.c (generic_val_print, val_print, val_print_string):
 889         Don't call gdb_flush.
 890         * utils.c (defaulted_query): Don't call gdb_flush.
 891         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 892         * target.c (target_announce_detach): Don't call gdb_flush.
 893         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 894         * remote.c (extended_remote_target::attach): Don't call
 895         gdb_flush.
 896         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 897         * printcmd.c (do_examine): Don't call gdb_flush.
 898         (info_display_command): Don't call gdb_flush.
 899         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 900         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 901         * memattr.c (info_mem_command): Don't call gdb_flush.
 902         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 903         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 904         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 905         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 906         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 907         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 908         (gnu_nat_target::detach): Don't call gdb_flush.
 909         * f-valprint.c (f_val_print): Don't call gdb_flush.
 910         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 911         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 912         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 913         gdb_flush.
 914         * c-valprint.c (c_val_print): Don't call gdb_flush.
 915         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 916
 917 2019-03-05  Tom Tromey  <tromey@adacore.com>
 918
 919         * varobj.c (update_dynamic_varobj_children): Update.
 920         (install_default_visualizer): Use reset, not release.
 921         * value.c (set_internalvar): Update.
 922         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 923         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 924         ATTRIBUTE_UNUSED_RESULT.
 925
 926 2019-03-05  Tom Tromey  <tromey@adacore.com>
 927
 928         * remote.c (class scoped_remote_fd) <release>: Add
 929         ATTRIBUTE_UNUSED_RESULT.
 930
 931 2019-03-05  Tom Tromey  <tromey@adacore.com>
 932
 933         * macroexp.c (struct macro_buffer) <release>: Add
 934         ATTRIBUTE_UNUSED_RESULT.
 935
 936 2019-03-05  Tom Tromey  <tromey@adacore.com>
 937
 938         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 939         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 940         ATTRIBUTE_UNUSED_RESULT.
 941
 942 2019-03-05  Tom Tromey  <tromey@adacore.com>
 943
 944         * common/scoped_fd.h (class scoped_fd) <release>: Add
 945         ATTRIBUTE_UNUSED_RESULT.
 946
 947 2019-03-05  Tom Tromey  <tromey@adacore.com>
 948
 949         * parser-defs.h (struct parser_state) <release>: Add
 950         ATTRIBUTE_UNUSED_RESULT.
 951
 952 2019-03-05  Tom Tromey  <tromey@adacore.com>
 953
 954         * utils.h (class gdb_argv) <release>: Add
 955         ATTRIBUTE_UNUSED_RESULT.
 956         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
 957
 958 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 959
 960         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 961         for-loop range, to avoid compiler warnings.
 962
 963         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 964         avoid compiler warnings about unused variables.
 965
 966         * NEWS: Mention end of support for native debugging on MS-Windows
 967         before XP.
 968
 969         PR gdb/24292
 970         * common/netstuff.c:
 971         * gdbserver/gdbreplay.c
 972         * gdbserver/remote-utils.c:
 973         * ser-tcp.c:
 974         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 975         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 976         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 977         'getaddrinfo' and 'freeaddrinfo' were not available before
 978         Windows XP, and mingw.org's MinGW headers by default define
 979         _WIN32_WINNT to 0x500.
 980
 981 2019-03-01  Gary Benson <gbenson@redhat.com>
 982
 983         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
 984
 985 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
 986             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 987
 988         PR gdb/8527
 989         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 990         set_sigint_trap, clear_sigint_trap.
 991
 992 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 993
 994         * target.c (target_detach): Clear the regcache and the
 995         frame cache.
 996
 997 2019-02-27  Pedro Alves  <palves@redhat.com>
 998
 999         * utils.c (set_screen_size): When we cap the height/width sizes,
1000         tweak the corresponding command variable to show "unlimited":
1001
1002 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1003             Pedro Alves  <palves@redhat.com>
1004
1005         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1006         before calling rl_set_screen_size.
1007
1008 2019-02-27  Tom Tromey  <tromey@adacore.com>
1009
1010         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1011         define.
1012         * python/py-value.c: Remove Python 2.4 workaround.
1013         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1014         workaround.
1015         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1016         Python 2.4 workaround.
1017         * python/python-internal.h: Remove Python 2.4 comment.
1018         (Py_ssize_t): Don't define.
1019         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1020         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1021         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1022         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1023         * python/python.c (do_start_initialization): Remove Python 2.4
1024         workaround.
1025         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1026         (print_children): Remove Python 2.4 workaround.
1027         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1028         workaround.
1029         (CHARBUFFERPROC_NAME): Remove.
1030         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1031         Python 2.4 workaround.
1032
1033 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1034
1035         * NEWS: Note minimum Python version.
1036
1037 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1038
1039         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1040         code from these functions.  Remove corresponding ifdefs.  Use
1041         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1042         Remove gotos and target of gotos.
1043         (infpy_search_memory): Likewise.
1044
1045 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1046
1047         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1048         (hppa_gdbarch_init): Don't register deleted functions with
1049         gdbarch.
1050
1051 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1052
1053         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1054         (h8300_unwind_sp): Delete.
1055         (h8300_dummy_id): Delete.
1056         (h8300_gdbarch_init): Don't register deleted functions with
1057         gdbarch.
1058
1059 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1060
1061         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1062         (ft32_unwind_pc): Delete.
1063         (ft32_unwind_sp): Delete.
1064         (ft32_gdbarch_init): Don't register deleted functions with
1065         gdbarch.
1066
1067 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1068
1069         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1070         (frv_unwind_pc): Delete.
1071         (frv_unwind_sp): Delete.
1072         (frv_gdbarch_init): Don't register deleted functions with
1073         gdbarch.
1074
1075 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1076
1077         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1078         (riscv_unwind_pc): Delete.
1079         (riscv_unwind_sp): Delete.
1080         (riscv_gdbarch_init): Don't register deleted functions with
1081         gdbarch.
1082
1083 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1084
1085         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1086         (csky_unwind_pc): Delete.
1087         (csky_unwind_sp): Delete.
1088         (csky_gdbarch_init): Don't register deleted functions with
1089         gdbarch.
1090
1091 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1092
1093         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1094         (cris_unwind_pc): Delete.
1095         (cris_unwind_sp): Delete.
1096         (cris_gdbarch_init): Don't register deleted functions with
1097         gdbarch.
1098
1099 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1100
1101         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1102         (bfin_unwind_pc): Delete.
1103         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1104
1105 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1106
1107         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1108         (arm_unwind_pc): Delete.
1109         (arm_unwind_sp): Delete.
1110         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1111
1112 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1113
1114         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1115         (arc_unwind_pc): Delete.
1116         (arc_unwind_sp): Delete.
1117         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1118
1119 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1120
1121         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1122         (alpha_unwind_pc): Delete.
1123         (alpha_gdbarch_init): Don't register deleted functions with
1124         gdbarch.
1125
1126 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1127
1128         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1129         (aarch64_unwind_pc): Delete.
1130         (aarch64_unwind_sp): Delete.
1131         (aarch64_gdbarch_init): Don't register deleted functions with
1132         gdbarch.
1133
1134 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1135
1136         * gdbtypes.c (type_align): Don't consider static members when
1137         computing structure alignment.
1138
1139 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1140
1141         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1142         return 0 for other types.
1143         * arch-utils.c (default_type_align): Always return 0.
1144         * gdbarch.h: Regenerate.
1145         * gdbarch.sh (type_align): Extend comment.
1146         * gdbtypes.c (type_align): Add additional comments, always call
1147         gdbarch_type_align before applying the default rules.
1148         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1149         generic code will then apply a suitable default.
1150         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1151         types, return 0 for other types.
1152
1153 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1154
1155         * NEWS: Create a new section for the next release branch.
1156         Rename the section of the current branch, now that it has
1157         been cut.
1158
1159 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1160
1161         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1162         * version.in: Bump version to 8.3.50.DATE-git.
1163
1164 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1165
1166         * aix-thread.c (ptid_cmp): Remove unused variable.
1167         (get_signaled_thread): Likewise.
1168         (store_regs_user_thread): Likewise.
1169         (store_regs_kernel_thread): Likewise.
1170         (fetch_regs_kernel_thread): Remove shadowed variable.
1171
1172 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1173
1174         * features/riscv/32bit-cpu.xml: Add register numbers.
1175         * features/riscv/32bit-fpu.c: Regenerate.
1176         * features/riscv/32bit-fpu.xml: Add register numbers.
1177         * features/riscv/64bit-cpu.xml: Add register numbers.
1178         * features/riscv/64bit-fpu.c: Regenerate.
1179         * features/riscv/64bit-fpu.xml: Add register numbers.
1180
1181 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1182
1183         * NEWS: Mention two argument form of gdb.Value constructor.
1184         * python/py-value.c (convert_buffer_and_type_to_value): New
1185         function.
1186         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1187         Add support for handling an optional second argument.  Call
1188         convert_buffer_and_type_to_value as appropriate.
1189         * python/python-internal.h (Py_buffer_deleter): New struct.
1190         (Py_buffer_up): New typedef.
1191
1192 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1193
1194         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1195         instead of releasing ownership.
1196
1197 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1198
1199         * dwarf2read.c (open_and_init_dwp_file): Call
1200         elf_numsections instead of bfd_count_sections to initialize
1201         dwp_file->num_sections.
1202
1203 2019-02-25  Tom Tromey  <tromey@adacore.com>
1204
1205         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1206
1207 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1208
1209         * gcore.in: Add '--readnever' option when invoking GDB.
1210
1211 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1212
1213         * MAINTAINERS: Update my email address.
1214
1215 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1216
1217         * build-id.c (build_id_to_debug_bfd_1): New function.
1218         (build_id_to_debug_bfd): Look for separate debug file in
1219         sysroot.
1220
1221 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1222
1223         * gdbarch.sh: Update the copyright year range that is placed into
1224         generated files.
1225
1226 2019-02-22  Keith Seitz  <keiths@redhat.com>
1227
1228         PR symtab/23853
1229         * linespec.c (create_sals_line_offset): Search for the default
1230         symtab's filename instead of its fullname.
1231
1232 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1233
1234         * NEWS: Update style defaults.
1235
1236 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1237
1238         * main.c (captured_main_1): Disable styling in batch mode.
1239
1240 2019-02-20  Tom Tromey  <tom@tromey.com>
1241
1242         * symtab.c (symtab_symbol_info): Fix typos.
1243
1244 2019-02-20  Tom Tromey  <tromey@adacore.com>
1245
1246         * findcmd.c (_initialize_mem_search): Use upper case for
1247         metasyntactic variables.
1248
1249 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1250
1251         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1252         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1253
1254 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1255
1256         * top.h (source_file_name): Change to std::string.
1257         * top.c (source_file_name): Likewise.
1258         (command_line_input): Adjust.
1259         * cli/cli-script.c (script_from_file): Adjust.
1260
1261 2019-02-19  Tom Tromey  <tromey@adacore.com>
1262
1263         * ravenscar-thread.c
1264         (ravenscar_thread_target::update_thread_list): Don't call
1265         ada_build_task_list.
1266         * ada-lang.h (ada_build_task_list): Don't declare.
1267         * ada-tasks.c (struct ada_tasks_inferior_data)
1268         <task_list_valid_p>: Now bool.
1269         (read_known_tasks, ada_task_list_changed)
1270         (ada_tasks_invalidate_inferior_data): Update.
1271         (read_known_tasks_array): Return bool.
1272         (read_known_tasks_list): Likewise.
1273         (read_known_tasks): Return void.
1274         (ada_build_task_list): Now static.
1275
1276 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1277
1278         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1279         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1280
1281 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1282
1283         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1284         variant for ada_tasks_pspace_data_handle and
1285         ada_tasks_inferior_data_handle.
1286         (ada_tasks_pspace_data_cleanup): New function.
1287         (ada_tasks_inferior_data_cleanup): New function.
1288
1289 2019-02-17  Tom Tromey  <tom@tromey.com>
1290
1291         * macrotab.h (macro_source_fullname): Return a std::string.
1292         * macrotab.c (macro_include, check_for_redefinition)
1293         (macro_undef, macro_lookup_definition, foreach_macro)
1294         (foreach_macro_in_scope): Update.
1295         (macro_source_fullname): Return a std::string.
1296         * macrocmd.c (show_pp_source_pos): Update.
1297
1298 2019-02-17  Tom Tromey  <tom@tromey.com>
1299
1300         * macrocmd.c (show_pp_source_pos): Style the file names.
1301
1302 2019-02-17  Tom Tromey  <tom@tromey.com>
1303
1304         PR tui/24197:
1305         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1306
1307 2019-02-17  Tom Tromey  <tom@tromey.com>
1308
1309         * ada-lang.c (user_select_syms): Use filtered printing.
1310         * utils.c (wrap_style): New global.
1311         (desired_style): Remove.
1312         (emit_style_escape): Add stream parameter.
1313         (set_output_style, reset_terminal_style, prompt_for_continue):
1314         Update.
1315         (flush_wrap_buffer): Only flush gdb_stdout.
1316         (wrap_here): Set wrap_style.
1317         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1318         treat escape sequences as a character.  Change when wrap buffer is
1319         flushed.
1320         (fputs_styled): Do not set the output style when the default is
1321         requested.
1322         * ui-style.h (struct ui_file_style) <is_default>: New method.
1323         * source.c (print_source_lines_base): Emit escape sequences in one
1324         piece.
1325
1326 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1327
1328         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1329         integers and enumeration types.
1330
1331 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1332
1333         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1334         instead of lookup_symbol_in_language
1335         (do_exact_match): New function.
1336         (ada_get_symbol_name_matcher): Return do_exact_match when
1337         doing a verbatim match.
1338
1339 2019-02-15  Tom Tromey  <tromey@adacore.com>
1340
1341         * ravenscar-thread.c (ravenscar_thread_target::resume)
1342         (ravenscar_thread_target::wait): Special case wildcard requests.
1343
1344 2019-02-15  Tom Tromey  <tromey@adacore.com>
1345
1346         * ravenscar-thread.c (base_ptid): Remove.
1347         (struct ravenscar_thread_target) <close>: New method.
1348         <m_base_ptid>: New member.
1349         <update_inferior_ptid, active_task, task_is_currently_active,
1350         runtime_initialized>: Declare methods.
1351         <ravenscar_thread_target>: Add constructor.
1352         (ravenscar_thread_target::task_is_currently_active)
1353         (ravenscar_thread_target::update_inferior_ptid)
1354         (ravenscar_runtime_initialized): Rename.  Now methods.
1355         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1356         (ravenscar_thread_target::update_thread_list): Update.
1357         (ravenscar_thread_target::active_task): Now method.
1358         (ravenscar_thread_target::store_registers)
1359         (ravenscar_thread_target::prepare_to_store)
1360         (ravenscar_thread_target::prepare_to_store)
1361         (ravenscar_thread_target::mourn_inferior): Update.
1362         (ravenscar_inferior_created): Use "new" to create target.
1363         (ravenscar_thread_target::get_ada_task_ptid): Update.
1364         (_initialize_ravenscar): Don't initialize base_ptid.
1365         (ravenscar_ops): Remove global.
1366
1367 2019-02-15  Tom Tromey  <tromey@adacore.com>
1368
1369         * target.h (push_target): Declare new overload.
1370         * target.c (push_target): New overload, taking an rvalue reference.
1371         * remote.c (remote_target::open_1): Use push_target overload.
1372         * corelow.c (core_target_open): Use push_target overload.
1373
1374 2019-02-15  Tom Tromey  <tromey@adacore.com>
1375
1376         * ravenscar-thread.c (is_ravenscar_task)
1377         (ravenscar_task_is_currently_active): Return bool.
1378         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1379         (_initialize_ravenscar): Remove "(void)".
1380         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1381         Return bool.
1382
1383 2019-02-15  Tom Tromey  <tromey@adacore.com>
1384
1385         * ravenscar-thread.c (ravenscar_runtime_initializer)
1386         (has_ravenscar_runtime, get_running_thread_id)
1387         (ravenscar_thread_target::resume): Fix indentation.
1388
1389 2019-02-15  Tom Tromey  <tromey@adacore.com>
1390
1391         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1392         from ravenscar_arch_ops.
1393         (sparc_ravenscar_ops::fetch_registers)
1394         (sparc_ravenscar_ops::store_registers): Now methods.
1395         (sparc_ravenscar_prepare_to_store): Remove.
1396         (sparc_ravenscar_ops): Redefine.
1397         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1398         methods and destructor.  Remove members.
1399         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1400         (ravenscar_thread_target::store_registers)
1401         (ravenscar_thread_target::prepare_to_store): Update.
1402         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1403         Remove.
1404         (struct ppc_ravenscar_powerpc_ops): Derive from
1405         ravenscar_arch_ops.
1406         (ppc_ravenscar_powerpc_ops::fetch_registers)
1407         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1408         (ppc_ravenscar_powerpc_ops): Redefine.
1409         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1410         (ppc_ravenscar_e500_ops::fetch_registers)
1411         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1412         (ppc_ravenscar_e500_ops): Redefine.
1413         * aarch64-ravenscar-thread.c
1414         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1415         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1416         (aarch64_ravenscar_fetch_registers)
1417         (aarch64_ravenscar_store_registers): Now methods.
1418         (aarch64_ravenscar_ops): Redefine.
1419
1420 2019-02-15  Tom Tromey  <tromey@adacore.com>
1421
1422         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1423         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1424         (ravenscar_thread_target::stopped_by_watchpoint)
1425         (ravenscar_thread_target::stopped_data_address)
1426         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1427
1428 2019-02-15  Tom Tromey  <tromey@adacore.com>
1429
1430         * ravenscar-thread.c: Fix some typos.
1431
1432 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1433             Tom Tromey  <tromey@adacore.com>
1434
1435         * ada-lang.c (ada_exception_sal): Change addr_string to a
1436         std::string.
1437         (create_ada_exception_catchpoint): Update.
1438
1439 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1440             Tom Tromey  <tromey@adacore.com>
1441
1442         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1443         (bp_location_ops): Remove.
1444         (base_breakpoint_allocate_location): Update.
1445         (free_bp_location): Update.
1446         * ada-lang.c (class ada_catchpoint_location)
1447         <ada_catchpoint_location>: Remove ops parameter.
1448         (ada_catchpoint_location_dtor): Remove.
1449         (ada_catchpoint_location_ops): Remove.
1450         (allocate_location_exception): Update.
1451         * breakpoint.h (struct bp_location_ops): Remove.
1452         (class bp_location) <bp_location>: Remove bp_location_ops
1453         parameter.
1454         <~bp_location>: Add destructor.
1455         <ops>: Remove.
1456
1457 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1458             Pedro Alves  <palves@redhat.com>
1459
1460         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1461         'PATH_MAX'.
1462
1463 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1464             Samuel Thibault  <samuel.thibault@gnu.org>
1465             Thomas Schwinge  <thomas@codesourcery.com>
1466
1467         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1468         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1469
1470 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1471
1472         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1473         (check_empty): Use "const char *".
1474
1475         * gnu-nat.c (gnu_nat_target::detach): Instead of
1476         'detach_inferior (pid)' call
1477         'detach_inferior (find_inferior_pid (pid))'.
1478
1479         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1480         'nat/fork-inferior.o'.
1481         * gnu-nat.c: #include "nat/fork-inferior.h".
1482
1483         * gnu-nat.c (gnu_nat_target::detach): Instead of
1484         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1485         * gnu-nat.h: #include "inf-child.h".
1486         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1487         'i386_gnu_nat_target::fetch_registers'.
1488         (gnu_store_registers): Rename/move to
1489         'i386_gnu_nat_target::store_registers'.
1490
1491         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1492         * gnu-nat.h (mach_thread_info): New function.
1493         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1494
1495         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1496
1497 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1498
1499         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1500
1501 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1502
1503         * windows-nat.c (windows_add_thread): Add new parameter
1504         "main_thread_p" with default value set to false.  Update
1505         function documentation as well as all callers.
1506         (windows_delete_thread): Likewise.
1507         (fake_create_process): Update call to windows_add_thread.
1508         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1509         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1510         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1511         call to windows_delete_thread.
1512
1513 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1514
1515         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1516
1517 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1518
1519         * symfile.c (find_separate_debug_file): Use canonical path of
1520         sysroot with child_path instead of gdb_sysroot if it is valid.
1521
1522 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1523
1524         * symfile.c (find_separate_debug_file): Use child_path to
1525         determine if an object file is under a sysroot.
1526
1527 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1528
1529         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1530         unittests/child-path-selftests.c.
1531         * common/pathstuff.c (child_path): New function.
1532         * common/pathstuff.h (child_path): New prototype.
1533         * unittests/child-path-selftests.c: New file.
1534
1535 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1536
1537         * symfile.c (find_separate_debug_file): Look for separate debug
1538         files in debug directories under the sysroot.
1539
1540 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1541
1542         * symtab.h (struct minimal_symbol data_p): New const method.
1543         (struct minimal_symbol text_p): Likewise.
1544         * symtab.c (output_source_filename): Use file name style
1545         to print file name.
1546         (print_symbol_info): Likewise.
1547         (print_msymbol_info): Use address style to print addresses.
1548         Use function name style to print executable text symbols.
1549         (expand_symtab_containing_pc): Use data_p.
1550         (find_pc_sect_compunit_symtab): Likewise.
1551
1552 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1553
1554         * breakpoint.c (describe_other_breakpoints): Use address style
1555         to print addresses.
1556         (say_where): Likewise.
1557
1558 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1559
1560         * ada-typeprint.c (print_func_type): Print function name
1561         style to print function name.
1562         * c-typeprint.c (c_print_type_1): Likewise.
1563
1564 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1565
1566         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1567         for execve.
1568
1569 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1570
1571         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1572         type_stack.
1573
1574 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1575
1576         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1577         TYPE_CODE_REF types.
1578
1579 2019-02-08  Jim Wilson  <jimw@sifive.com>
1580
1581         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1582         (riscv_linux_fregset): New.
1583         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1584
1585 2019-02-07  Tom Tromey  <tom@tromey.com>
1586
1587         * thread.c (thread_cancel_execution_command): Update.
1588         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1589         methods.
1590         (struct thread_fsm_ops): Remove.
1591         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1592         (thread_fsm_should_stop, thread_fsm_return_value)
1593         (thread_fsm_set_finished, thread_fsm_finished_p)
1594         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1595         Don't declare.
1596         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1597         * infrun.c (clear_proceed_status_thread)
1598         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1599         (print_stop_event): Update.
1600         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1601         Add constructor.
1602         (step_command_fsm_ops): Remove.
1603         (new_step_command_fsm): Remove.
1604         (step_1): Update.
1605         (step_command_fsm::should_stop): Rename from
1606         step_command_fsm_should_stop.
1607         (step_command_fsm::clean_up): Rename from
1608         step_command_fsm_clean_up.
1609         (step_command_fsm::do_async_reply_reason): Rename from
1610         step_command_fsm_async_reply_reason.
1611         (struct until_next_fsm): Inherit from thread_fsm.  Add
1612         constructor.
1613         (until_next_fsm_ops): Remove.
1614         (new_until_next_fsm): Remove.
1615         (until_next_fsm::should_stop): Rename from
1616         until_next_fsm_should_stop.
1617         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1618         (until_next_fsm::do_async_reply_reason): Rename from
1619         until_next_fsm_async_reply_reason.
1620         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1621         constructor.  Change type of breakpoint.
1622         (finish_command_fsm_ops): Remove.
1623         (new_finish_command_fsm): Remove.
1624         (finish_command_fsm::should_stop): Rename from
1625         finish_command_fsm_should_stop.
1626         (finish_command_fsm::clean_up): Rename from
1627         finish_command_fsm_clean_up.
1628         (finish_command_fsm::return_value): Rename from
1629         finish_command_fsm_return_value.
1630         (finish_command_fsm::do_async_reply_reason): Rename from
1631         finish_command_fsm_async_reply_reason.
1632         (finish_command): Update.
1633         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1634         Add constructor.
1635         (call_thread_fsm_ops): Remove.
1636         (call_thread_fsm::call_thread_fsm): Rename from
1637         new_call_thread_fsm.
1638         (call_thread_fsm::should_stop): Rename from
1639         call_thread_fsm_should_stop.
1640         (call_thread_fsm::should_notify_stop): Rename from
1641         call_thread_fsm_should_notify_stop.
1642         (run_inferior_call, call_function_by_hand_dummy): Update.
1643         * cli/cli-interp.c (should_print_stop_to_console): Update.
1644         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1645         Add constructor.  Change type of location_breakpoint,
1646         caller_breakpoint.
1647         (until_break_fsm_ops): Remove.
1648         (new_until_break_fsm): Remove.
1649         (until_break_fsm::should_stop): Rename from
1650         until_break_fsm_should_stop.
1651         (until_break_fsm::clean_up): Rename from
1652         until_break_fsm_clean_up.
1653         (until_break_fsm::do_async_reply_reason): Rename from
1654         until_break_fsm_async_reply_reason.
1655         (until_break_command): Update.
1656         * thread-fsm.c: Remove.
1657         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1658
1659 2019-02-07  Tom Tromey  <tom@tromey.com>
1660
1661         * yy-remap.h: Add include guard.
1662         * xtensa-tdep.h: Add include guard.
1663         * xcoffread.h: Rename include guard.
1664         * varobj-iter.h: Add include guard.
1665         * tui/tui.h: Rename include guard.
1666         * tui/tui-winsource.h: Rename include guard.
1667         * tui/tui-wingeneral.h: Rename include guard.
1668         * tui/tui-windata.h: Rename include guard.
1669         * tui/tui-win.h: Rename include guard.
1670         * tui/tui-stack.h: Rename include guard.
1671         * tui/tui-source.h: Rename include guard.
1672         * tui/tui-regs.h: Rename include guard.
1673         * tui/tui-out.h: Rename include guard.
1674         * tui/tui-layout.h: Rename include guard.
1675         * tui/tui-io.h: Rename include guard.
1676         * tui/tui-hooks.h: Rename include guard.
1677         * tui/tui-file.h: Rename include guard.
1678         * tui/tui-disasm.h: Rename include guard.
1679         * tui/tui-data.h: Rename include guard.
1680         * tui/tui-command.h: Rename include guard.
1681         * tic6x-tdep.h: Add include guard.
1682         * target/waitstatus.h: Rename include guard.
1683         * target/wait.h: Rename include guard.
1684         * target/target.h: Rename include guard.
1685         * target/resume.h: Rename include guard.
1686         * target-float.h: Rename include guard.
1687         * stabsread.h: Add include guard.
1688         * rs6000-tdep.h: Add include guard.
1689         * riscv-fbsd-tdep.h: Add include guard.
1690         * regformats/regdef.h: Rename include guard.
1691         * record.h: Rename include guard.
1692         * python/python.h: Rename include guard.
1693         * python/python-internal.h: Rename include guard.
1694         * python/py-stopevent.h: Rename include guard.
1695         * python/py-ref.h: Rename include guard.
1696         * python/py-record.h: Rename include guard.
1697         * python/py-record-full.h: Rename include guard.
1698         * python/py-record-btrace.h: Rename include guard.
1699         * python/py-instruction.h: Rename include guard.
1700         * python/py-events.h: Rename include guard.
1701         * python/py-event.h: Rename include guard.
1702         * procfs.h: Add include guard.
1703         * proc-utils.h: Add include guard.
1704         * p-lang.h: Add include guard.
1705         * or1k-tdep.h: Rename include guard.
1706         * observable.h: Rename include guard.
1707         * nto-tdep.h: Rename include guard.
1708         * nat/x86-linux.h: Rename include guard.
1709         * nat/x86-linux-dregs.h: Rename include guard.
1710         * nat/x86-gcc-cpuid.h: Add include guard.
1711         * nat/x86-dregs.h: Rename include guard.
1712         * nat/x86-cpuid.h: Rename include guard.
1713         * nat/ppc-linux.h: Rename include guard.
1714         * nat/mips-linux-watch.h: Rename include guard.
1715         * nat/linux-waitpid.h: Rename include guard.
1716         * nat/linux-ptrace.h: Rename include guard.
1717         * nat/linux-procfs.h: Rename include guard.
1718         * nat/linux-osdata.h: Rename include guard.
1719         * nat/linux-nat.h: Rename include guard.
1720         * nat/linux-namespaces.h: Rename include guard.
1721         * nat/linux-btrace.h: Rename include guard.
1722         * nat/glibc_thread_db.h: Rename include guard.
1723         * nat/gdb_thread_db.h: Rename include guard.
1724         * nat/gdb_ptrace.h: Rename include guard.
1725         * nat/fork-inferior.h: Rename include guard.
1726         * nat/amd64-linux-siginfo.h: Rename include guard.
1727         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1728         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1729         * nat/aarch64-linux.h: Rename include guard.
1730         * nat/aarch64-linux-hw-point.h: Rename include guard.
1731         * mn10300-tdep.h: Add include guard.
1732         * mips-linux-tdep.h: Add include guard.
1733         * mi/mi-parse.h: Rename include guard.
1734         * mi/mi-out.h: Rename include guard.
1735         * mi/mi-main.h: Rename include guard.
1736         * mi/mi-interp.h: Rename include guard.
1737         * mi/mi-getopt.h: Rename include guard.
1738         * mi/mi-console.h: Rename include guard.
1739         * mi/mi-common.h: Rename include guard.
1740         * mi/mi-cmds.h: Rename include guard.
1741         * mi/mi-cmd-break.h: Rename include guard.
1742         * m2-lang.h: Add include guard.
1743         * location.h: Rename include guard.
1744         * linux-record.h: Rename include guard.
1745         * linux-nat.h: Add include guard.
1746         * linux-fork.h: Add include guard.
1747         * i386-darwin-tdep.h: Rename include guard.
1748         * hppa-linux-offsets.h: Add include guard.
1749         * guile/guile.h: Rename include guard.
1750         * guile/guile-internal.h: Rename include guard.
1751         * gnu-nat.h: Rename include guard.
1752         * gdb-stabs.h: Rename include guard.
1753         * frv-tdep.h: Add include guard.
1754         * f-lang.h: Add include guard.
1755         * event-loop.h: Add include guard.
1756         * darwin-nat.h: Rename include guard.
1757         * cp-abi.h: Rename include guard.
1758         * config/sparc/nm-sol2.h: Rename include guard.
1759         * config/nm-nto.h: Rename include guard.
1760         * config/nm-linux.h: Add include guard.
1761         * config/i386/nm-i386gnu.h: Rename include guard.
1762         * config/djgpp/nl_types.h: Rename include guard.
1763         * config/djgpp/langinfo.h: Rename include guard.
1764         * compile/gcc-cp-plugin.h: Add include guard.
1765         * compile/gcc-c-plugin.h: Add include guard.
1766         * compile/compile.h: Rename include guard.
1767         * compile/compile-object-run.h: Rename include guard.
1768         * compile/compile-object-load.h: Rename include guard.
1769         * compile/compile-internal.h: Rename include guard.
1770         * compile/compile-cplus.h: Rename include guard.
1771         * compile/compile-c.h: Rename include guard.
1772         * common/xml-utils.h: Rename include guard.
1773         * common/x86-xstate.h: Rename include guard.
1774         * common/version.h: Rename include guard.
1775         * common/vec.h: Rename include guard.
1776         * common/tdesc.h: Rename include guard.
1777         * common/selftest.h: Rename include guard.
1778         * common/scoped_restore.h: Rename include guard.
1779         * common/scoped_mmap.h: Rename include guard.
1780         * common/scoped_fd.h: Rename include guard.
1781         * common/safe-iterator.h: Rename include guard.
1782         * common/run-time-clock.h: Rename include guard.
1783         * common/refcounted-object.h: Rename include guard.
1784         * common/queue.h: Rename include guard.
1785         * common/ptid.h: Rename include guard.
1786         * common/print-utils.h: Rename include guard.
1787         * common/preprocessor.h: Rename include guard.
1788         * common/pathstuff.h: Rename include guard.
1789         * common/observable.h: Rename include guard.
1790         * common/netstuff.h: Rename include guard.
1791         * common/job-control.h: Rename include guard.
1792         * common/host-defs.h: Rename include guard.
1793         * common/gdb_wait.h: Rename include guard.
1794         * common/gdb_vecs.h: Rename include guard.
1795         * common/gdb_unlinker.h: Rename include guard.
1796         * common/gdb_unique_ptr.h: Rename include guard.
1797         * common/gdb_tilde_expand.h: Rename include guard.
1798         * common/gdb_sys_time.h: Rename include guard.
1799         * common/gdb_string_view.h: Rename include guard.
1800         * common/gdb_splay_tree.h: Rename include guard.
1801         * common/gdb_setjmp.h: Rename include guard.
1802         * common/gdb_ref_ptr.h: Rename include guard.
1803         * common/gdb_optional.h: Rename include guard.
1804         * common/gdb_locale.h: Rename include guard.
1805         * common/gdb_assert.h: Rename include guard.
1806         * common/filtered-iterator.h: Rename include guard.
1807         * common/filestuff.h: Rename include guard.
1808         * common/fileio.h: Rename include guard.
1809         * common/environ.h: Rename include guard.
1810         * common/common-utils.h: Rename include guard.
1811         * common/common-types.h: Rename include guard.
1812         * common/common-regcache.h: Rename include guard.
1813         * common/common-inferior.h: Rename include guard.
1814         * common/common-gdbthread.h: Rename include guard.
1815         * common/common-exceptions.h: Rename include guard.
1816         * common/common-defs.h: Rename include guard.
1817         * common/common-debug.h: Rename include guard.
1818         * common/cleanups.h: Rename include guard.
1819         * common/buffer.h: Rename include guard.
1820         * common/btrace-common.h: Rename include guard.
1821         * common/break-common.h: Rename include guard.
1822         * cli/cli-utils.h: Rename include guard.
1823         * cli/cli-style.h: Rename include guard.
1824         * cli/cli-setshow.h: Rename include guard.
1825         * cli/cli-script.h: Rename include guard.
1826         * cli/cli-interp.h: Rename include guard.
1827         * cli/cli-decode.h: Rename include guard.
1828         * cli/cli-cmds.h: Rename include guard.
1829         * charset-list.h: Add include guard.
1830         * buildsym-legacy.h: Rename include guard.
1831         * bfin-tdep.h: Add include guard.
1832         * ax.h: Rename include guard.
1833         * arm-linux-tdep.h: Add include guard.
1834         * arm-fbsd-tdep.h: Add include guard.
1835         * arch/xtensa.h: Rename include guard.
1836         * arch/tic6x.h: Add include guard.
1837         * arch/i386.h: Add include guard.
1838         * arch/arm.h: Rename include guard.
1839         * arch/arm-linux.h: Rename include guard.
1840         * arch/arm-get-next-pcs.h: Rename include guard.
1841         * arch/amd64.h: Add include guard.
1842         * arch/aarch64-insn.h: Rename include guard.
1843         * arch-utils.h: Rename include guard.
1844         * annotate.h: Add include guard.
1845         * amd64-darwin-tdep.h: Rename include guard.
1846         * aarch64-linux-tdep.h: Add include guard.
1847         * aarch64-fbsd-tdep.h: Add include guard.
1848         * aarch32-linux-nat.h: Add include guard.
1849
1850 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1851
1852         * macrotab.c (macro_define_internal): New function that
1853         factorizes macro_define_object_internal and macro_define_function
1854         code.
1855         (macro_define_object_internal): Use macro_define_internal.
1856         (macro_define_function): Likewise.
1857
1858 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1859
1860         * macrocmd.c (extract_identifier): Return
1861         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1862         callers.
1863
1864 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1865
1866         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1867
1868 2019-02-05  Tom Tromey  <tom@tromey.com>
1869
1870         * target.c (target_stack::unpush): Move assertion earlier.
1871
1872 2019-01-30  Tom Tromey  <tom@tromey.com>
1873
1874         PR python/23615:
1875         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1876         (gdbpy_parse_and_eval): Likewise.
1877         * python/python-internal.h (gdbpy_allow_threads): New class.
1878
1879 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1880
1881         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1882         (aarch64_fbsd_fpregmap): Move earlier.
1883         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1884         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1885         instead of individual calls to trad_frame_set_reg_addr.
1886         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1887         earlier.
1888         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1889         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1890         instead of individual calls to trad_frame_set_reg_addr.
1891
1892 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1893
1894         * CONTRIBUTE: Replace contribution list with wiki link.
1895
1896 2019-01-25  Tom Tromey  <tom@tromey.com>
1897
1898         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1899
1900 2019-01-25  Tom Tromey  <tom@tromey.com>
1901
1902         * xtensa-linux-nat.c: Fix common/ includes.
1903         * xml-support.h: Fix common/ includes.
1904         * xml-support.c: Fix common/ includes.
1905         * x86-linux-nat.c: Fix common/ includes.
1906         * windows-nat.c: Fix common/ includes.
1907         * varobj.h: Fix common/ includes.
1908         * varobj.c: Fix common/ includes.
1909         * value.c: Fix common/ includes.
1910         * valops.c: Fix common/ includes.
1911         * utils.c: Fix common/ includes.
1912         * unittests/xml-utils-selftests.c: Fix common/ includes.
1913         * unittests/utils-selftests.c: Fix common/ includes.
1914         * unittests/unpack-selftests.c: Fix common/ includes.
1915         * unittests/tracepoint-selftests.c: Fix common/ includes.
1916         * unittests/style-selftests.c: Fix common/ includes.
1917         * unittests/string_view-selftests.c: Fix common/ includes.
1918         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1919         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1920         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1921         * unittests/rsp-low-selftests.c: Fix common/ includes.
1922         * unittests/parse-connection-spec-selftests.c: Fix common/
1923         includes.
1924         * unittests/optional-selftests.c: Fix common/ includes.
1925         * unittests/offset-type-selftests.c: Fix common/ includes.
1926         * unittests/observable-selftests.c: Fix common/ includes.
1927         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1928         * unittests/memrange-selftests.c: Fix common/ includes.
1929         * unittests/memory-map-selftests.c: Fix common/ includes.
1930         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1931         * unittests/function-view-selftests.c: Fix common/ includes.
1932         * unittests/environ-selftests.c: Fix common/ includes.
1933         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1934         * unittests/common-utils-selftests.c: Fix common/ includes.
1935         * unittests/cli-utils-selftests.c: Fix common/ includes.
1936         * unittests/array-view-selftests.c: Fix common/ includes.
1937         * ui-file.c: Fix common/ includes.
1938         * tui/tui-io.c: Fix common/ includes.
1939         * tracepoint.h: Fix common/ includes.
1940         * tracepoint.c: Fix common/ includes.
1941         * tracefile-tfile.c: Fix common/ includes.
1942         * top.h: Fix common/ includes.
1943         * top.c: Fix common/ includes.
1944         * thread.c: Fix common/ includes.
1945         * target/waitstatus.h: Fix common/ includes.
1946         * target/waitstatus.c: Fix common/ includes.
1947         * target.h: Fix common/ includes.
1948         * target.c: Fix common/ includes.
1949         * target-memory.c: Fix common/ includes.
1950         * target-descriptions.c: Fix common/ includes.
1951         * symtab.h: Fix common/ includes.
1952         * symfile.c: Fix common/ includes.
1953         * stap-probe.c: Fix common/ includes.
1954         * spu-linux-nat.c: Fix common/ includes.
1955         * sparc-nat.c: Fix common/ includes.
1956         * source.c: Fix common/ includes.
1957         * solib.c: Fix common/ includes.
1958         * solib-target.c: Fix common/ includes.
1959         * ser-unix.c: Fix common/ includes.
1960         * ser-tcp.c: Fix common/ includes.
1961         * ser-pipe.c: Fix common/ includes.
1962         * ser-base.c: Fix common/ includes.
1963         * selftest-arch.c: Fix common/ includes.
1964         * s12z-tdep.c: Fix common/ includes.
1965         * rust-exp.y: Fix common/ includes.
1966         * rs6000-aix-tdep.c: Fix common/ includes.
1967         * riscv-tdep.c: Fix common/ includes.
1968         * remote.c: Fix common/ includes.
1969         * remote-notif.h: Fix common/ includes.
1970         * remote-fileio.h: Fix common/ includes.
1971         * remote-fileio.c: Fix common/ includes.
1972         * regcache.h: Fix common/ includes.
1973         * regcache.c: Fix common/ includes.
1974         * record-btrace.c: Fix common/ includes.
1975         * python/python.c: Fix common/ includes.
1976         * python/py-type.c: Fix common/ includes.
1977         * python/py-inferior.c: Fix common/ includes.
1978         * progspace.h: Fix common/ includes.
1979         * producer.c: Fix common/ includes.
1980         * procfs.c: Fix common/ includes.
1981         * proc-api.c: Fix common/ includes.
1982         * printcmd.c: Fix common/ includes.
1983         * ppc-linux-nat.c: Fix common/ includes.
1984         * parser-defs.h: Fix common/ includes.
1985         * osdata.c: Fix common/ includes.
1986         * obsd-nat.c: Fix common/ includes.
1987         * nat/x86-linux.c: Fix common/ includes.
1988         * nat/x86-linux-dregs.c: Fix common/ includes.
1989         * nat/x86-dregs.h: Fix common/ includes.
1990         * nat/x86-dregs.c: Fix common/ includes.
1991         * nat/ppc-linux.c: Fix common/ includes.
1992         * nat/mips-linux-watch.h: Fix common/ includes.
1993         * nat/mips-linux-watch.c: Fix common/ includes.
1994         * nat/linux-waitpid.c: Fix common/ includes.
1995         * nat/linux-ptrace.h: Fix common/ includes.
1996         * nat/linux-ptrace.c: Fix common/ includes.
1997         * nat/linux-procfs.c: Fix common/ includes.
1998         * nat/linux-personality.c: Fix common/ includes.
1999         * nat/linux-osdata.c: Fix common/ includes.
2000         * nat/linux-namespaces.c: Fix common/ includes.
2001         * nat/linux-btrace.h: Fix common/ includes.
2002         * nat/linux-btrace.c: Fix common/ includes.
2003         * nat/fork-inferior.c: Fix common/ includes.
2004         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2005         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2006         * nat/aarch64-linux.c: Fix common/ includes.
2007         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2008         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2009         * namespace.h: Fix common/ includes.
2010         * mips-linux-tdep.c: Fix common/ includes.
2011         * minsyms.c: Fix common/ includes.
2012         * mi/mi-parse.h: Fix common/ includes.
2013         * mi/mi-main.c: Fix common/ includes.
2014         * mi/mi-cmd-env.c: Fix common/ includes.
2015         * memrange.h: Fix common/ includes.
2016         * memattr.c: Fix common/ includes.
2017         * maint.h: Fix common/ includes.
2018         * maint.c: Fix common/ includes.
2019         * main.c: Fix common/ includes.
2020         * machoread.c: Fix common/ includes.
2021         * location.c: Fix common/ includes.
2022         * linux-thread-db.c: Fix common/ includes.
2023         * linux-nat.c: Fix common/ includes.
2024         * linux-fork.c: Fix common/ includes.
2025         * inline-frame.c: Fix common/ includes.
2026         * infrun.c: Fix common/ includes.
2027         * inflow.c: Fix common/ includes.
2028         * inferior.h: Fix common/ includes.
2029         * inferior.c: Fix common/ includes.
2030         * infcmd.c: Fix common/ includes.
2031         * inf-ptrace.c: Fix common/ includes.
2032         * inf-child.c: Fix common/ includes.
2033         * ia64-linux-nat.c: Fix common/ includes.
2034         * i387-tdep.c: Fix common/ includes.
2035         * i386-tdep.c: Fix common/ includes.
2036         * i386-linux-tdep.c: Fix common/ includes.
2037         * i386-linux-nat.c: Fix common/ includes.
2038         * i386-go32-tdep.c: Fix common/ includes.
2039         * i386-fbsd-tdep.c: Fix common/ includes.
2040         * i386-fbsd-nat.c: Fix common/ includes.
2041         * guile/scm-type.c: Fix common/ includes.
2042         * guile/guile.c: Fix common/ includes.
2043         * go32-nat.c: Fix common/ includes.
2044         * gnu-nat.c: Fix common/ includes.
2045         * gdbthread.h: Fix common/ includes.
2046         * gdbarch-selftests.c: Fix common/ includes.
2047         * gdb_usleep.c: Fix common/ includes.
2048         * gdb_select.h: Fix common/ includes.
2049         * gdb_bfd.c: Fix common/ includes.
2050         * gcore.c: Fix common/ includes.
2051         * fork-child.c: Fix common/ includes.
2052         * findvar.c: Fix common/ includes.
2053         * fbsd-nat.c: Fix common/ includes.
2054         * event-top.c: Fix common/ includes.
2055         * event-loop.c: Fix common/ includes.
2056         * dwarf2read.c: Fix common/ includes.
2057         * dwarf2loc.c: Fix common/ includes.
2058         * dwarf2-frame.c: Fix common/ includes.
2059         * dwarf-index-cache.c: Fix common/ includes.
2060         * dtrace-probe.c: Fix common/ includes.
2061         * disasm-selftests.c: Fix common/ includes.
2062         * defs.h: Fix common/ includes.
2063         * csky-tdep.c: Fix common/ includes.
2064         * cp-valprint.c: Fix common/ includes.
2065         * cp-support.h: Fix common/ includes.
2066         * cp-support.c: Fix common/ includes.
2067         * corelow.c: Fix common/ includes.
2068         * completer.h: Fix common/ includes.
2069         * completer.c: Fix common/ includes.
2070         * compile/compile.c: Fix common/ includes.
2071         * compile/compile-loc2c.c: Fix common/ includes.
2072         * compile/compile-cplus-types.c: Fix common/ includes.
2073         * compile/compile-cplus-symbols.c: Fix common/ includes.
2074         * command.h: Fix common/ includes.
2075         * cli/cli-dump.c: Fix common/ includes.
2076         * cli/cli-cmds.c: Fix common/ includes.
2077         * charset.c: Fix common/ includes.
2078         * build-id.c: Fix common/ includes.
2079         * btrace.h: Fix common/ includes.
2080         * btrace.c: Fix common/ includes.
2081         * breakpoint.h: Fix common/ includes.
2082         * breakpoint.c: Fix common/ includes.
2083         * ax.h:
2084         (enum agent_op): Fix common/ includes.
2085         * ax-general.c (struct aop_map): Fix common/ includes.
2086         * ax-gdb.c: Fix common/ includes.
2087         * auxv.c: Fix common/ includes.
2088         * auto-load.c: Fix common/ includes.
2089         * arm-tdep.c: Fix common/ includes.
2090         * arch/riscv.c: Fix common/ includes.
2091         * arch/ppc-linux-common.c: Fix common/ includes.
2092         * arch/i386.c: Fix common/ includes.
2093         * arch/arm.c: Fix common/ includes.
2094         * arch/arm-linux.c: Fix common/ includes.
2095         * arch/arm-get-next-pcs.c: Fix common/ includes.
2096         * arch/amd64.c: Fix common/ includes.
2097         * arch/aarch64.c: Fix common/ includes.
2098         * arch/aarch64-insn.c: Fix common/ includes.
2099         * arch-utils.c: Fix common/ includes.
2100         * amd64-windows-tdep.c: Fix common/ includes.
2101         * amd64-tdep.c: Fix common/ includes.
2102         * amd64-sol2-tdep.c: Fix common/ includes.
2103         * amd64-obsd-tdep.c: Fix common/ includes.
2104         * amd64-nbsd-tdep.c: Fix common/ includes.
2105         * amd64-linux-tdep.c: Fix common/ includes.
2106         * amd64-linux-nat.c: Fix common/ includes.
2107         * amd64-fbsd-tdep.c: Fix common/ includes.
2108         * amd64-fbsd-nat.c: Fix common/ includes.
2109         * amd64-dicos-tdep.c: Fix common/ includes.
2110         * amd64-darwin-tdep.c: Fix common/ includes.
2111         * agent.c: Fix common/ includes.
2112         * ada-lang.h: Fix common/ includes.
2113         * ada-lang.c: Fix common/ includes.
2114         * aarch64-tdep.c: Fix common/ includes.
2115
2116 2019-01-25  Tom Tromey  <tom@tromey.com>
2117
2118         * common/create-version.sh: Use common/version.h.
2119
2120 2019-01-24  Pedro Alves  <palves@redhat.com>
2121
2122         * infrun.c (signal_stop, signal_print, signal_program)
2123         (signal_catch, signal_pass): Now arrays instead of pointers.
2124         (update_signals_program_target, do_target_resume)
2125         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2126         * linux-nat.c (linux_nat_target::pass_signals)
2127         (linux_nat_target::create_inferior, linux_nat_target::attach):
2128         Adjust.
2129         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2130         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2131         * procfs.c (procfs_target::pass_signals): Adjust.
2132         * record-full.c (record_full_target::resume): Adjust.
2133         * remote.c (remote_target::pass_signals)
2134         (remote_target::program_signals): Adjust.
2135         * target-debug.h (target_debug_print_signals): Now takes a
2136         gdb::array_view as parameter.  Adjust.
2137         * target.h (target_ops) <pass_signals, program_signals>: Replace
2138         pointer and length parameters with gdb::array_view.
2139         (target_pass_signals, target_program_signals): Likewise.
2140         * target-delegates.c: Regenerate.
2141
2142 2019-01-24  Pedro Alves  <palves@redhat.com>
2143
2144         * common/forward-scope-exit.h
2145         (forward_scope_exit::forward_scope_exit): Pass arguments to
2146         m_bind_function directly, instead of creating a std::bind and
2147         copying that.
2148
2149 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2150
2151         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2152         for static members.
2153         (pass_in_v_vfp_candidate): Likewise.
2154
2155 2019-01-23  Tom Tromey  <tom@tromey.com>
2156             Pedro Alves  <palves@redhat.com>
2157
2158         * regcache.c (class regcache_invalidator): Remove.
2159         (regcache::raw_write): Use make_scope_exit.
2160
2161 2019-01-23  Tom Tromey  <tom@tromey.com>
2162
2163         * ui-out.h (class ui_out_emit_type): Update comment.
2164
2165 2019-01-23  Tom Tromey  <tom@tromey.com>
2166
2167         * infrun.c (fetch_inferior_event): Update comment.
2168
2169 2019-01-23  Tom Tromey  <tom@tromey.com>
2170             Pedro Alves  <palves@redhat.com>
2171
2172         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2173         parameter.
2174         (fetch_inferior_event): Use SCOPE_EXIT.
2175
2176
2177 2019-01-23  Tom Tromey  <tom@tromey.com>
2178             Pedro Alves  <palves@redhat.com>
2179
2180         * infrun.c (disable_thread_events): Delete.
2181         (stop_all_threads): Use SCOPE_EXIT.
2182
2183 2019-01-23  Tom Tromey  <tom@tromey.com>
2184             Pedro Alves  <palves@redhat.com>
2185
2186         * symfile.c: Include forward-scope-exit.h.
2187         (clear_symtab_users_cleanup): Replace forward declaration with
2188         a FORWARD_SCOPE_EXIT.
2189         (syms_from_objfile_1): Use the forward_scope_exit and
2190         gdb::optional instead of cleanup_function.
2191         (reread_symbols): Use the forward_scope_exit instead of
2192         cleanup_function.
2193         (clear_symtab_users_cleanup): Remove function.
2194
2195 2019-01-23  Tom Tromey  <tom@tromey.com>
2196             Pedro Alves  <palves@redhat.com>
2197
2198         * linux-nat.c: Include scope-exit.h.
2199         (cleanup_target_stop): Remove.
2200         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2201         SCOPE_EXIT.
2202
2203 2019-01-23  Tom Tromey  <tom@tromey.com>
2204             Pedro Alves  <palves@redhat.com>
2205
2206         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2207         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2208
2209 2019-01-23  Tom Tromey  <tom@tromey.com>
2210             Andrew Burgess  <andrew.burgess@embecosm.com>
2211             Pedro Alves  <palves@redhat.com>
2212
2213         * infrun.c (fetch_inferior_event): Use scope_exit.
2214         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2215         * top.c (execute_command): Use scope_exit.
2216         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2217         * utils.c (do_bpstat_clear_actions_cleanup)
2218         (make_bpstat_clear_actions_cleanup): Remove.
2219
2220 2019-01-23  Tom Tromey  <tom@tromey.com>
2221             Pedro Alves  <palves@redhat.com>
2222
2223         * infrun.c: Include "common/scope-exit.h"
2224         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2225         (wait_for_inferior): Use SCOPE_EXIT.
2226         (fetch_inferior_event): Use scope_exit.
2227
2228 2019-01-23  Tom Tromey  <tom@tromey.com>
2229             Pedro Alves  <palves@redhat.com>
2230
2231         * breakpoint.c (create_breakpoint): Remove cleanup.
2232
2233 2019-01-23  Tom Tromey  <tom@tromey.com>
2234             Andrew Burgess  <andrew.burgess@embecosm.com>
2235             Pedro Alves  <palves@redhat.com>
2236
2237 2019-01-23  Pedro Alves  <palves@redhat.com>
2238
2239         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2240
2241 2019-01-23  Pedro Alves  <palves@redhat.com>
2242             Andrew Burgess  <andrew.burgess@embecosm.com>
2243
2244         * gdbthread.h: Include "common/forward-scope-exit.h".
2245         (scoped_finish_thread_state): Redefine custom class in terms of
2246         forward_scope_exit.
2247
2248 2019-01-23  Pedro Alves  <palves@redhat.com>
2249             Andrew Burgess  <andrew.burgess@embecosm.com>
2250
2251         * common/forward-scope-exit.h: New file.
2252
2253 2019-01-23  Pedro Alves  <palves@redhat.com>
2254             Andrew Burgess  <andrew.burgess@embecosm.com>
2255             Tom Tromey  <tom@tromey.com>
2256
2257         * common/scope-exit.h: New file.
2258
2259 2019-01-23  Pedro Alves  <palves@redhat.com>
2260
2261         * common/preprocessor.h (ESC): Rename to ...
2262         (ESC_PARENS): ... this.
2263         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2264         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2265
2266 2019-01-23  Tom Tromey  <tom@tromey.com>
2267
2268         * language.h (class scoped_switch_to_sym_language_if_auto):
2269         Initialize m_lang in both cases.
2270
2271 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2272
2273         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2274         with XCNEW.
2275
2276 2019-01-22  Tom Tromey  <tom@tromey.com>
2277
2278         * corelow.c: Do not include sys/file.h.
2279
2280 2019-01-22  Tom Tromey  <tom@tromey.com>
2281
2282         * tui/tui-wingeneral.h: Include gdb_curses.h.
2283
2284 2019-01-22  Tom Tromey  <tom@tromey.com>
2285
2286         * source-cache.h (class source_cache) <get_source_lines,
2287         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2288
2289 2019-01-22  Tom Tromey  <tom@tromey.com>
2290
2291         * remote-fileio.h (struct remote_target): Declare.
2292
2293 2019-01-22  Tom Tromey  <tom@tromey.com>
2294
2295         * python/py-arch.c: Do not include py-ref.h.
2296         * python/py-bpevent.c: Do not include py-ref.h.
2297         * python/py-cmd.c: Do not include py-ref.h.
2298         * python/py-continueevent.c: Do not include py-ref.h.
2299         * python/py-event.h: Do not include py-ref.h.
2300         * python/py-evtregistry.c: Do not include py-ref.h.
2301         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2302         * python/py-frame.c: Do not include py-ref.h.
2303         * python/py-framefilter.c: Do not include py-ref.h.
2304         * python/py-function.c: Do not include py-ref.h.
2305         * python/py-infevents.c: Do not include py-ref.h.
2306         * python/py-linetable.c: Do not include py-ref.h.
2307         * python/py-objfile.c: Do not include py-ref.h.
2308         * python/py-param.c: Do not include py-ref.h.
2309         * python/py-prettyprint.c: Do not include py-ref.h.
2310         * python/py-progspace.c: Do not include py-ref.h.
2311         * python/py-symbol.c: Do not include py-ref.h.
2312         * python/py-symtab.c: Do not include py-ref.h.
2313         * python/py-type.c: Do not include py-ref.h.
2314         * python/py-unwind.c: Do not include py-ref.h.
2315         * python/py-utils.c: Do not include py-ref.h.
2316         * python/py-value.c: Do not include py-ref.h.
2317         * python/py-varobj.c: Do not include py-ref.h.
2318         * python/py-xmethods.c: Do not include py-ref.h.
2319         * python/python.c: Do not include py-ref.h.
2320         * varobj.c: Do not include py-ref.h.
2321
2322 2019-01-22  Tom Tromey  <tom@tromey.com>
2323
2324         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2325         keyword for bcache.
2326
2327 2019-01-22  Tom Tromey  <tom@tromey.com>
2328
2329         * compile/compile-cplus-types.c: Remove a comment by #include.
2330
2331 2019-01-22  Tom Tromey  <tom@tromey.com>
2332
2333         * compile/gcc-c-plugin.h: Include compile-internal.h.
2334
2335 2019-01-22  Tom Tromey  <tom@tromey.com>
2336
2337         * stabsread.c (EXTERN): Do not define.
2338         (symnum, next_symbol_text_func, processing_gcc_compilation)
2339         (within_function, global_sym_chain, global_stabs)
2340         (previous_stab_code, this_object_header_files)
2341         (n_this_object_header_files)
2342         (n_allocated_this_object_header_files): Define.
2343         * stabsread.h (EXTERN): Never define.  Use "extern".
2344
2345 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2346
2347         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2348         history_value.
2349
2350 2019-01-21  Tom Tromey  <tom@tromey.com>
2351
2352         * ui-out.c: Fix includes.
2353         * tui/tui-source.c: Fix includes.
2354         * target.c: Fix includes.
2355         * remote.c: Fix includes.
2356         * regcache.c: Fix includes.
2357         * python/py-block.c: Fix includes.
2358         * printcmd.c: Fix includes.
2359         * or1k-tdep.c: Fix includes.
2360         * mi/mi-main.c: Fix includes.
2361         * m32r-tdep.c: Fix includes.
2362         * csky-tdep.c: Fix includes.
2363         * compile/compile-cplus-types.c: Fix includes.
2364         * cli/cli-interp.c: Fix includes.
2365
2366 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2367
2368         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2369         for padding.
2370
2371 2019-01-16  Tom Tromey  <tom@tromey.com>
2372
2373         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2374         earlier.
2375         (struct objfile) <msymbols_range>: Move from top level.
2376         <msymbols>: New method.
2377         (class objfile_msymbols): Remove.
2378         * symtab.c (default_collect_symbol_completion_matches_break_on):
2379         Update.
2380         * symmisc.c (dump_msymbols): Update.
2381         * stabsread.c (scan_file_globals): Update.
2382         * objc-lang.c (info_selectors_command, info_classes_command)
2383         (find_methods): Update.
2384         * minsyms.c (find_solib_trampoline_target): Update.
2385         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2386         * coffread.c (coff_symfile_read): Update.
2387         * ada-lang.c (ada_lookup_simple_minsym)
2388         (ada_collect_symbol_completion_matches): Update.
2389
2390 2019-01-16  Tom Tromey  <tom@tromey.com>
2391
2392         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2393         type.  Remove no-argument constructor.
2394         <iterator::operator++>: Simplify.
2395         <begin>: Update.
2396         <end>: Use minimal_symbol_count.
2397
2398 2019-01-16  Tom Tromey  <tom@tromey.com>
2399
2400         * objfiles.h (struct objfile) <psymtabs>: New method.
2401         (class objfile_psymtabs): Remove.
2402         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2403         typedef.
2404         <range>: New method.
2405         (require_partial_symbols): Change return type.
2406         * psymtab.c (require_partial_symbols)
2407         (psym_expand_symtabs_matching): Update.
2408         * mdebugread.c (parse_partial_symbols): Update.
2409         * dbxread.c (dbx_end_psymtab): Update.
2410
2411 2019-01-15  Tom Tromey  <tom@tromey.com>
2412
2413         * symtab.c (lookup_objfile_from_block)
2414         (lookup_symbol_in_objfile_symtabs)
2415         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2416         (find_line_symtab, info_sources_command)
2417         (default_collect_symbol_completion_matches_break_on)
2418         (make_source_files_completion_list): Update.
2419         * symmisc.c (print_objfile_statistics, dump_objfile)
2420         (maintenance_print_symbols, maintenance_info_symtabs)
2421         (maintenance_check_symtabs, maintenance_info_line_tables):
2422         Update.
2423         * source.c (select_source_symtab)
2424         (forget_cached_source_info_for_objfile): Update.
2425         * objfiles.h (class objfile_compunits): Remove.
2426         (struct objfile) <compunits_range>: New typedef.
2427         (compunits): New method.
2428         * objfiles.c (objfile_relocate1): Update.
2429         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2430         * maint.c (count_symtabs_and_blocks): Update.
2431         * linespec.c (iterate_over_all_matching_symtabs): Update.
2432         * cp-support.c (add_symbol_overload_list_qualified): Update.
2433         * coffread.c (coff_symtab_read): Update.
2434         * ada-lang.c (add_nonlocal_symbols)
2435         (ada_collect_symbol_completion_matches)
2436         (ada_add_global_exceptions): Update.
2437
2438 2019-01-15  Tom Tromey  <tom@tromey.com>
2439
2440         * progspace.h (program_space) <objfiles_safe_range>: New
2441         typedef.
2442         <objfiles_safe>: New method.
2443         * objfiles.h (class all_objfiles_safe): Remove.
2444         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2445         * jit.c (jit_inferior_exit_hook): Update.
2446
2447 2019-01-17  Tom Tromey  <tom@tromey.com>
2448
2449         * progspace.h (program_space) <objfiles_range>: New typedef.
2450         <objfiles>: New method.
2451         <objfiles_head>: Rename from objfiles.
2452         (object_files): Update.
2453         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2454         * guile/scm-pretty-print.c
2455         (ppscm_find_pretty_printer_from_objfiles): Update.
2456         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2457         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2458         Update.
2459         * python/py-progspace.c (pspy_get_objfiles): Update.
2460         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2461         Update.
2462         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2463         (objfpy_lookup_objfile_by_build_id): Update.
2464         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2465         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2466         Update.
2467         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2468         (expand_symtab_containing_pc, lookup_objfile_from_block)
2469         (lookup_static_symbol, basic_lookup_transparent_type)
2470         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2471         (find_line_symtab, info_sources_command)
2472         (default_collect_symbol_completion_matches_break_on)
2473         (make_source_files_completion_list, find_main_name): Update.
2474         * symmisc.c (print_symbol_bcache_statistics)
2475         (print_objfile_statistics, maintenance_print_symbols)
2476         (maintenance_print_msymbols, maintenance_print_objfiles)
2477         (maintenance_info_symtabs, maintenance_check_symtabs)
2478         (maintenance_expand_symtabs, maintenance_info_line_tables):
2479         Update.
2480         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2481         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2482         (map_overlay_command, unmap_overlay_command)
2483         (simple_overlay_update, expand_symtabs_matching)
2484         (map_symbol_filenames): Update.
2485         * symfile-debug.c (set_debug_symfile): Update.
2486         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2487         Update.
2488         * source.c (select_source_symtab, forget_cached_source_info):
2489         Update.
2490         * solib.c (solib_read_symbols): Update.
2491         * solib-spu.c (append_ocl_sos): Update.
2492         * psymtab.c (maintenance_print_psymbols)
2493         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2494         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2495         * printcmd.c (info_symbol_command): Update.
2496         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2497         Update.
2498         * objfiles.h (class all_objfiles): Remove.
2499         * objfiles.c (have_partial_symbols, have_full_symbols)
2500         (have_minimal_symbols, qsort_cmp, update_section_map)
2501         (shared_objfile_contains_address_p)
2502         (default_iterate_over_objfiles_in_search_order): Update.
2503         * objc-lang.c (info_selectors_command, info_classes_command)
2504         (find_methods): Update.
2505         * minsyms.c (find_solib_trampoline_target): Update.
2506         * maint.c (maintenance_info_sections)
2507         (maintenance_translate_address, count_symtabs_and_blocks):
2508         Update.
2509         * main.c (captured_main_1): Update.
2510         * linux-thread-db.c (try_thread_db_load_from_pdir)
2511         (has_libpthread): Update.
2512         * linespec.c (iterate_over_all_matching_symtabs)
2513         (search_minsyms_for_name): Update.
2514         * jit.c (jit_find_objf_with_entry_addr): Update.
2515         * hppa-tdep.c (find_unwind_entry)
2516         (hppa_lookup_stub_minimal_symbol): Update.
2517         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2518         Update.
2519         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2520         (elf_gnu_ifunc_resolve_by_got): Update.
2521         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2522         * dwarf-index-write.c (save_gdb_index_command): Update.
2523         * cp-support.c (add_symbol_overload_list_qualified): Update.
2524         * breakpoint.c (create_overlay_event_breakpoint)
2525         (create_longjmp_master_breakpoint)
2526         (create_std_terminate_master_breakpoint)
2527         (create_exception_master_breakpoint): Update.
2528         * blockframe.c (find_pc_partial_function): Update.
2529         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2530         (ada_collect_symbol_completion_matches)
2531         (ada_add_global_exceptions): Update.
2532
2533 2019-01-17  Tom Tromey  <tom@tromey.com>
2534
2535         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2536         declare VEC.
2537         (solib_target_parse_libraries): Change return type.
2538         (library_list_start_segment, library_list_start_section)
2539         (library_list_end_library, library_list_start_library); Update.
2540         (solib_target_free_library_list): Remove.
2541         (solib_target_parse_libraries): Remove cleanup.  Change return
2542         type.
2543         (solib_target_current_sos): Update.
2544
2545 2019-01-17  Tom Tromey  <tromey@bapiya>
2546
2547         * valprint.c: Replace "the the" with "the".
2548         * symtab.c: Replace "the the" with "the".
2549         * solib.c: Replace "the the" with "the".
2550         * solib-dsbt.c: Replace "the the" with "the".
2551         * linespec.c: Replace "the the" with "the".
2552         * dwarf2loc.h: Replace "the the" with "the".
2553         * amd64-windows-tdep.c: Replace "the the" with "the".
2554         * aarch64-tdep.c: Replace "the the" with "the".
2555
2556 2019-01-16  Keith Seitz  <keiths@redhat.com>
2557
2558         PR gdb/23773
2559         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2560         <builder>: Rename to ..
2561         <m_builder>: ... this and make private.
2562         (dwarf2_cu::get_builder): New method.  Change all users of
2563         `builder' to use this method.
2564         (dwarf2_start_symtab): Move to ...
2565         (dwarf2_cu::start_symtab): ... here.  Update all callers
2566         (setup_type_unit_groups): Move to ...
2567         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2568         callers.
2569         (dwarf2_cu::reset_builder): New method.
2570         (process_full_compunit, process_full_type_unit): Use
2571         dwarf2_cu::reset_builder.
2572         (follow_die_offset): Record the ancestor CU if it is different
2573         from the followed DIE's CU.
2574         (follow_die_sig_1): Likewise.
2575
2576 2019-01-15  Tom Tromey  <tom@tromey.com>
2577
2578         * remote.c (class remote_state) <buf>: Now a char_vector.
2579         <buf_size>: Remove.
2580         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2581         parameter.
2582         (remote_target::getpkt_or_notif_sane_1)
2583         (remote_target::getpkt_sane)
2584         (remote_target::getpkt_or_notif_sane): Likewise.
2585         (class remote_target) <putpkt>: New overload.
2586         (remote_target::read_frame): Change type of "buf_p".  Remove
2587         sizeof_p parameter.
2588         (packet_ok): New overload.
2589         (packet_check_result): New overload.
2590         Update all uses.
2591
2592 2019-01-14  Tom Tromey  <tom@tromey.com>
2593
2594         * remote-notif.c (handle_notification, remote_notif_ack)
2595         (remote_notif_parse): Make "buf" const.
2596         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2597         const.
2598         (remote_notif_parse, remote_notif_ack, handle_notification):
2599         Likewise.
2600         * remote.c (remote_notif_stop_parse): Make "buf" const.
2601         (remote_target::remote_parse_stop_reply): Make "buf" const.
2602         (remote_notif_stop_ack): Make "buf" const.
2603
2604 2019-01-14  Tom Tromey  <tom@tromey.com>
2605
2606         * remote.c (remote_console_output): Make parameter const.
2607
2608 2019-01-14  Tom Tromey  <tom@tromey.com>
2609
2610         * target-debug.h (target_debug_print_signals): Constify.
2611         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2612         * procfs.c (procfs_target::pass_signals): Update.
2613         * linux-nat.c (linux_nat_target::pass_signals): Update.
2614         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2615         * target-delegates.c: Rebuild.
2616         * remote.c (remote_target::program_signals): Update.
2617         (remote_target::pass_signals): Update.
2618         * target.c (target_pass_signals): Constify argument.
2619         (target_program_signals): Likewise.
2620         * target.h (struct target_ops) <pass_signals, program_signals>:
2621         Constify argument.
2622         (target_pass_signals, target_program_signals): Constify argument.
2623
2624 2019-01-14  Tom Tromey  <tom@tromey.com>
2625
2626         PR tui/28819:
2627         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2628
2629 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2630
2631         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2632         field.
2633         * rs6000-tdep.c: Include reggroups.h.
2634         (IS_V_ALIAS_PSEUDOREG): Define.
2635         (rs6000_register_name): Return names for the "vX" aliases.
2636         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2637         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2638         aliases.  Call default_register_reggroup_p for all other
2639         pseudo-registers.
2640         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2641         New functions.
2642         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2643         Handle "vX" aliases.
2644         (v_alias_pseudo_register_collect): New function.
2645         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2646         (rs6000_gdbarch_init): Initialize "vX" aliases as
2647         pseudo-registers.  Restore registration of
2648         rs6000_pseudo_register_reggroup_p with
2649         set_tdesc_pseudo_register_reggroup_p.
2650
2651 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2652
2653         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2654         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2655         set_gdbarch_num_pseudo_regs.
2656
2657 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2658
2659         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2660         Remove arg prefixname, add do_set and do_show.
2661         Add member functions set_list and show_list.
2662         * cli/cli-style.c (class cli_style_option): Update accordingly.
2663         (style_set_list): Move to file scope.
2664         (style_show_list): Likewise.
2665         (set_style): Call help_list.
2666         (show_style): Call cmd_show_list.
2667         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2668         Update to use the new macro.
2669
2670 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2671
2672         * ada-lang.c (_initialize_ada_language): Expand the help text
2673         for the "catch exception" command.
2674
2675 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2676
2677         * symtab.c (matching_obj_sections): Initialize obj,
2678         declare it closer to its usage.
2679
2680 2019-01-10  Tom Tromey  <tom@tromey.com>
2681
2682         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2683         (basic_inf_threads_range): Remove.
2684         (inf_threads_range, inf_non_exited_threads_range)
2685         (safe_inf_threads_range): Use next_adapter.
2686
2687 2019-01-10  Keith Seitz  <keiths@redhat.com>
2688
2689         PR gdb/23712
2690         PR symtab/23010
2691         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2692         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2693
2694 2019-01-10  Keith Seitz  <keiths@redhat.com>
2695
2696         PR gdb/23712
2697         PR symtab/23010
2698         * dictionary.c (pending_to_vector): Remove.
2699         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2700         Remove _1 suffix, replacing functions of the same name.  Update
2701         all callers.
2702         (dict_create_hashed, dict_create_hashed_expandable)
2703         (dict_create_linear, dict_create_linear_expandable, dict_free)
2704         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2705         Make functions static.
2706
2707 2019-01-10  Keith Seitz  <keiths@redhat.com>
2708
2709         PR gdb/23712
2710         PR symtab/23010
2711         * dictionary.h (struct dictionary): Replace declaration with
2712         multidictionary.
2713         (dict_create_hashed, dict_create_hashed_expandable)
2714         (dict_create_linear, dict_create_linear_expandable)
2715         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2716         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2717         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2718         taking multidictionary argument.
2719         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2720         * block.h (struct block) <dict>: Change to multidictionary
2721         and rename `multidict'.
2722         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2723         symmisc.c: Update all dictionary references to multidictionary.
2724
2725 2019-01-10  Keith Seitz  <keiths@redhat.com>
2726
2727         PR gdb/23712
2728         PR symtab/23010
2729         * dictionary.c: Include unordered_map.
2730         (pending_to_vector): New function.
2731         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2732         Rewrite the non-"_1" functions to take vector instead
2733         of linked list.
2734         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2735         "new" _1 versions of the same name.
2736         (multidictionary): Define.
2737         (std::hash<enum language): New definition.
2738         (collate_pending_symbols_by_language, mdict_create_hashed)
2739         (mdict_create_hashed_expandable, mdict_create_linear)
2740         (mdict_create_linear_expandable, mdict_free)
2741         (find_language_dictionary, create_new_language_dictionary)
2742         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2743         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2744         (mdict_size, mdict_empty): New functions.
2745         * dictionary.h (mdict_iterator): Define.
2746
2747 2019-01-10  Pedro Alves  <palves@redhat.com>
2748
2749         * breakpoint.c (read_uploaded_action)
2750         (create_tracepoint_from_upload): Adjust to use
2751         gdb::unique_xmalloc_ptr.
2752         * ctf.c (ctf_write_uploaded_tp):
2753         (SET_ARRAY_FIELD): Use emplace_back.
2754         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2755         * tracefile-tfile.c (tfile_write_uploaded_tp):
2756         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2757         gdb::unique_xmalloc_ptr.
2758         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2759         at_string, cond_string, cmd_strings>: Replace char pointers
2760         with gdb::unique_xmalloc_ptr.
2761
2762 2019-01-10  Pedro Alves  <palves@redhat.com>
2763
2764         * solib-target.c (library_list_start_library): Don't xstrdup name.
2765
2766 2019-01-10  Pedro Alves  <palves@redhat.com>
2767
2768         * mdebugread.c (parse_partial_symbols): Use
2769         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2770
2771 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2772
2773         * linux-fork.c (scoped_switch_fork_info)
2774         <~scoped_switch_fork_info>: Fix incorrect variable name.
2775
2776 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2777
2778         * linux-fork.c (scoped_switch_fork_info)
2779         <scoped_switch_fork_info>: Make explicit.
2780         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2781
2782 2019-01-10  Tom Tromey  <tom@tromey.com>
2783
2784         * objfiles.h (objfile::reset_psymtabs): Update.
2785         * objfiles.c (objfile::objfile): Update.
2786         * psymtab.h (psymtab_storage::obstack): Update.
2787         (psymtab_storage::m_obstack): Use gdb::optional.
2788         (class psymtab_storage): Update comment.  Remove objfile
2789         parameter.
2790         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2791
2792 2019-01-10  Tom Tromey  <tom@tromey.com>
2793
2794         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2795         <free_psymtabs>: Now private.
2796         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2797         (allocate_psymtab): Use new method.
2798
2799 2019-01-10  Tom Tromey  <tom@tromey.com>
2800
2801         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2802         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2803         * mdebugread.c (parse_partial_symbols): Use
2804         allocate_dependencies.
2805         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2806         allocate_dependencies.
2807         (process_psymtab_comp_unit_reader)
2808         (build_type_psymtab_dependencies): Likewise.
2809         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2810
2811 2019-01-10  Tom Tromey  <tom@tromey.com>
2812
2813         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2814         PSYMBOL_SET_LANGUAGE.
2815         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2816
2817 2019-01-10  Tom Tromey  <tom@tromey.com>
2818
2819         * psymtab.h (psymtab_storage::obstack): New method.
2820         <m_obstack>: Rename from obstack; now private.
2821         * psymtab.c (psymtab_storage): Update.
2822         * dwarf2read.c (create_addrmap_from_index)
2823         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2824         Update.
2825
2826 2019-01-10  Tom Tromey  <tom@tromey.com>
2827
2828         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2829         * objfiles.h (objfile::reset_psymtabs): New method.
2830
2831 2019-01-10  Tom Tromey  <tom@tromey.com>
2832
2833         * symmisc.c (print_symbol_bcache_statistics): Update.
2834         (print_objfile_statistics): Update.
2835         * symfile.c (reread_symbols): Update.
2836         * psymtab.h (class psymtab_storage): New.
2837         * psymtab.c (psymtab_storage): New constructor.
2838         (~psymtab_storage): New destructor.
2839         (require_partial_symbols): Update.
2840         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2841         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2842         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2843         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2844         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2845         (start_psymtab_common, end_psymtab_common)
2846         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2847         (allocate_psymtab): Update.
2848         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2849         Update.
2850         (dump_psymtab_addrmap, maintenance_print_psymbols)
2851         (maintenance_check_psymtabs): Update.
2852         (class objfile_psymtabs): Move to objfiles.h.
2853         * psympriv.h (discard_psymtab): Now inline.
2854         (psymtab_discarder::psymtab_discarder): Update.
2855         (psymtab_discarder::~psymtab_discarder): Update.
2856         (ALL_OBJFILE_PSYMTABS): Rewrite.
2857         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2858         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2859         Remove fields.
2860         <partial_symtabs>: New field.
2861         (class objfile_psymtabs): Move from psymtab.h.  Update.
2862         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2863         psymbol_cache.
2864         (objfile::~objfile): Don't destroy psymbol_cache.
2865         * mdebugread.c (parse_partial_symbols): Update.
2866         * dwarf2read.c (create_addrmap_from_index)
2867         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2868         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2869         (add_partial_subprogram, dwarf2_ranges_read): Update.
2870         * dwarf-index-write.c (write_address_map)
2871         (write_one_signatured_type, recursively_write_psymbols)
2872         (class debug_names, class debug_names, write_psymtabs_to_index):
2873         Update.
2874
2875 2019-01-10  Tom Tromey  <tom@tromey.com>
2876
2877         * symtab.h (SYMBOL_SET_NAMES): Update.
2878         (symbol_set_names): Update.
2879         (MSYMBOL_SET_NAMES): Update.
2880         * symtab.c (symbol_set_names): Change argument to be an
2881         objfile_per_bfd_storage.
2882         * psymtab.c (add_psymbol_to_bcache): Update.
2883         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2884
2885 2019-01-10  Tom Tromey  <tom@tromey.com>
2886
2887         * symtab.c (create_demangled_names_hash): Change argument to be an
2888         objfile_per_bfd_storage.
2889         (symbol_set_names): Update.
2890
2891 2019-01-10  Tom Tromey  <tom@tromey.com>
2892
2893         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2894         init_psymbol_list.
2895         * psymtab.c (init_psymbol_list): Do nothing if already called.
2896         * psympriv.h (init_psymbol_list): Add comment.
2897         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2898         init_psymbol_list.
2899         * dbxread.c (dbx_symfile_read): Unconditionally call
2900         init_psymbol_list.
2901
2902 2019-01-10  Tom Tromey  <tom@tromey.com>
2903
2904         * xcoffread.c (scan_xcoff_symtab): Update.
2905         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2906         "where".
2907         * mdebugread.c (parse_partial_symbols)
2908         (handle_psymbol_enumerators): Update.
2909         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2910         * dbxread.c (read_dbx_symtab): Update.
2911         * psympriv.h (psymbol_placement): New enum.
2912         (add_psymbol_to_list): Update.
2913
2914 2019-01-10  Tom Tromey  <tom@tromey.com>
2915
2916         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2917         static_psymbols parameters.
2918         (scan_xcoff_symtab): Update.
2919         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2920         static_psymbols parameters.
2921         * psympriv.h (start_psymtab_common): Update.
2922         * mdebugread.c (parse_partial_symbols): Update.
2923         * dwarf2read.c (create_partial_symtab): Update.
2924         * dbxread.c (read_dbx_symtab): Update.
2925         (start_psymtab): Remove global_psymbols and static_psymbols
2926         parameters.
2927
2928 2019-01-10  Tom Tromey  <tom@tromey.com>
2929
2930         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2931         * psymtab.c (allocate_psymtab): Add comment.
2932         * psympriv.h (allocate_psymtab): Add comment.
2933         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2934         initializations.
2935         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2936
2937 2019-01-10  Tom Tromey  <tom@tromey.com>
2938
2939         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2940         Don't declare.
2941         * mipsread.c: Include mdebugread.h.
2942         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2943         Declare.
2944         * elfread.c: Include mdebugread.h.
2945
2946 2019-01-09  Tom Tromey  <tom@tromey.com>
2947
2948         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2949         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2950         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2951         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2952         (psym_lookup_symbol, psym_find_last_source_symtab)
2953         (psym_forget_cached_source_info, psym_print_stats)
2954         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2955         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2956         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2957         (psym_find_compunit_symtab_by_address)
2958         (maintenance_print_psymbols, maintenance_info_psymtabs)
2959         (maintenance_check_psymtabs): Use ranged for.
2960         * psymtab.h (class objfile_psymtabs): New.
2961         (require_partial_symbols): Return objfile_psymtabs.
2962         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2963
2964 2019-01-09  Tom Tromey  <tom@tromey.com>
2965
2966         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2967         (find_pc_mapped_section, list_overlays_command)
2968         (map_overlay_command, unmap_overlay_command)
2969         (simple_overlay_update): Use all_objfiles.
2970         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2971         * printcmd.c (info_symbol_command): Use all_objfiles.
2972         * objfiles.h (ALL_OBJSECTIONS): Remove.
2973         * maint.c (maintenance_translate_address): Use all_objfiles.
2974         * gcore.c (gcore_create_callback): Use all_objfiles.
2975         (objfile_find_memory_regions): Likewise.
2976
2977 2019-01-09  Tom Tromey  <tom@tromey.com>
2978
2979         * symtab.c (find_line_symtab, info_sources_command)
2980         (make_source_files_completion_list): Use objfile_compunits.
2981         * source.c (select_source_symtab): Use objfile_compunits.
2982         * objfiles.h (struct objfile): Update comment.
2983         (ALL_OBJFILES): Remove.
2984         (ALL_FILETABS): Remove.
2985         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2986         objfile_compunits.
2987
2988 2019-01-09  Tom Tromey  <tom@tromey.com>
2989
2990         * symmisc.c (print_objfile_statistics, dump_objfile)
2991         (maintenance_print_symbols): Use compunit_filetabs.
2992         * source.c (forget_cached_source_info_for_objfile): Use
2993         compunit_filetabs.
2994         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2995         (ALL_FILETABS): Use compunit_filetabs.
2996         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2997         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2998
2999 2019-01-09  Tom Tromey  <tom@tromey.com>
3000
3001         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3002         (compunit_filetabs): New.
3003         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3004         compunit_filetabs.
3005         (info_sources_command, make_source_files_completion_list): Remove
3006         declaration.
3007         * symmisc.c (print_objfile_statistics, dump_objfile)
3008         (maintenance_print_symbols): Remove declaration.
3009         (maintenance_info_symtabs): Use compunit_filetabs.
3010         (maintenance_info_line_tables): Likewise.
3011         * source.c (select_source_symtab): Change local variable name.
3012         (forget_cached_source_info_for_objfile): Remove declaration.
3013         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3014         * objfiles.c (objfile_relocate1): Remove declaration.
3015         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3016         declaration.
3017         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3018         * coffread.c (coff_symtab_read): Remove declaration.
3019         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3020         compunit_filetabs.
3021
3022 2019-01-09  Tom Tromey  <tom@tromey.com>
3023
3024         * symtab.c (lookup_objfile_from_block)
3025         (find_pc_sect_compunit_symtab, search_symbols)
3026         (default_collect_symbol_completion_matches_break_on): Use
3027         objfile_compunits.
3028         * objfiles.h (ALL_COMPUNITS): Remove.
3029         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3030         * cp-support.c (add_symbol_overload_list_qualified): Use
3031         objfile_compunits.
3032         * ada-lang.c (ada_collect_symbol_completion_matches)
3033         (ada_add_global_exceptions): Use objfile_compunits.
3034
3035 2019-01-09  Tom Tromey  <tom@tromey.com>
3036
3037         * source.c (select_source_symtab)
3038         (forget_cached_source_info_for_objfile): Remove declaration.
3039         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3040         declaration.
3041         * maint.c (count_symtabs_and_blocks): Remove declaration.
3042         * cp-support.c (add_symbol_overload_list_qualified): Remove
3043         declaration.
3044         * coffread.c (coff_symtab_read): Remove declaration.
3045         * symtab.c (lookup_symbol_in_objfile_symtabs)
3046         (basic_lookup_transparent_type_1): Use objfile_compunits.
3047         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3048         (info_sources_command, search_symbols)
3049         (default_collect_symbol_completion_matches_break_on)
3050         (make_source_files_completion_list): Remove declaration.
3051         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3052         (ada_collect_symbol_completion_matches)
3053         (ada_add_global_exceptions): Remove declaration.
3054         * linespec.c (iterate_over_all_matching_symtabs): Use
3055         objfile_compunits.
3056         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3057         (class objfile_compunits): New.
3058         (ALL_COMPUNITS): Use objfile_compunits.
3059         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3060         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3061         objfile_compunits.
3062         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3063
3064 2019-01-09  Tom Tromey  <tom@tromey.com>
3065
3066         * symtab.c (search_symbols)
3067         (default_collect_symbol_completion_matches_break_on): Use
3068         objfile_msymbols.
3069         * ada-lang.c (ada_lookup_simple_minsym)
3070         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3071         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3072         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3073         objfile_msymbols.
3074         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3075         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3076         * objc-lang.c (find_methods): Use objfile_msymbols.
3077         (info_selectors_command, info_classes_command): Likewise.
3078         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3079         * objfiles.h (class objfile_msymbols): New.
3080         (ALL_OBJFILE_MSYMBOLS): Remove.
3081         (ALL_MSYMBOLS): Remove.
3082
3083 2019-01-09  Tom Tromey  <tom@tromey.com>
3084
3085         * common/next-iterator.h (next_adapter): Add Iterator template
3086         parameter.
3087         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3088         (class all_objfiles_safe): New.
3089         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3090         * objfiles.c (put_objfile_before): Update comment.
3091         (add_separate_debug_objfile): Likewise.
3092         (free_all_objfiles): Use all_objfiles_safe.
3093         (objfile_purge_solibs): Likewise.
3094
3095 2019-01-09  Tom Tromey  <tom@tromey.com>
3096
3097         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3098         (expand_symtab_containing_pc, lookup_static_symbol)
3099         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3100         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3101         all_objfiles.
3102         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3103         * breakpoint.c (create_overlay_event_breakpoint)
3104         (create_longjmp_master_breakpoint)
3105         (create_std_terminate_master_breakpoint)
3106         (create_exception_master_breakpoint): Use all_objfiles.
3107         * linux-thread-db.c (try_thread_db_load_from_pdir)
3108         (has_libpthread): Use all_objfiles.
3109         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3110         * linespec.c (iterate_over_all_matching_symtabs)
3111         (search_minsyms_for_name): Use all_objfiles.
3112         * maint.c (maintenance_info_sections): Use all_objfiles.
3113         * main.c (captured_main_1): Use all_objfiles.
3114         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3115         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3116         * guile/scm-pretty-print.c
3117         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3118         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3119         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3120         (maintenance_print_msymbols): Use all_objfiles.
3121         * source.c (select_source_symtab): Use all_objfiles.
3122         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3123         * symfile.c (remove_symbol_file_command)
3124         (expand_symtabs_matching, map_symbol_filenames): Use
3125         all_objfiles.
3126         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3127         all_objfiles.
3128         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3129         * objc-lang.c (find_methods): Use all_objfiles.
3130         * objfiles.c (have_partial_symbols, have_full_symbols)
3131         (have_minimal_symbols, qsort_cmp)
3132         (default_iterate_over_objfiles_in_search_order): Use
3133         all_objfiles.
3134         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3135         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3136         (maintenance_check_psymtabs): Use all_objfiles.
3137         (ALL_PSYMTABS): Remove.
3138         * compile/compile-object-run.c (do_module_cleanup): Use
3139         all_objfiles.
3140         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3141         * cp-support.c (add_symbol_overload_list_qualified): Use
3142         all_objfiles.
3143         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3144         Use all_objfiles.
3145         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3146         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3147         all_objfiles.
3148         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3149         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3150         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3151         Uses all_objfiles.
3152         * solib.c (solib_read_symbols): Use all_objfiles
3153
3154 2019-01-09  Tom Tromey  <tom@tromey.com>
3155
3156         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3157         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3158         all_objfiles.
3159         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3160         * symmisc.c (print_symbol_bcache_statistics)
3161         (print_objfile_statistics, maintenance_print_objfiles)
3162         (maintenance_info_symtabs, maintenance_check_symtabs)
3163         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3164         all_objfiles.
3165         * source.c (forget_cached_source_info): Use all_objfiles.
3166         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3167         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3168         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3169         * objfiles.c (update_section_map): Use all_objfiles.
3170         (shared_objfile_contains_address_p): Likewise.
3171         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3172         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3173
3174 2019-01-09  Tom Tromey  <tom@tromey.com>
3175
3176         * common/next-iterator.h: New file.
3177         * objfiles.h (class all_objfiles): New.
3178         (struct objfile_iterator): New.
3179
3180 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3181
3182         * NEWS: Move the description of the changed "frame", "select-frame",
3183          and "info frame" commands to the Changed commands section.
3184
3185 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3186
3187         * gdbtypes.c (check_stub_method_group): Remove handling of old
3188         mangling schemes.
3189         * linespec.c (find_methods): Likewise.
3190         * stabsread.c (read_member_functions): Likewise.
3191         * valops.c (search_struct_method): Likewise.
3192         (value_struct_elt_for_reference): Likewise.
3193         * NEWS: Mention this change.
3194
3195 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3196
3197         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3198         print_source_lines.
3199         * source.c (print_source_lines_base): Update line number check.
3200         (print_source_lines): New function.
3201         (source_lines_range::source_lines_range): New function.
3202         * source.h (class source_lines_range): New class.
3203         (print_source_lines): New declaration.
3204
3205 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3206
3207         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3208
3209 2019-01-08  Tom Tromey  <tom@tromey.com>
3210             Simon Marchi  <simon.marchi@ericsson.com>
3211
3212         PR gdb/24060
3213         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3214         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3215         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3216         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3217         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3218         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3219
3220 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3221
3222         * source.c (select_source_symtab): Move header comment to
3223         declaration in source.h.
3224         (forget_cached_source_info_for_objfile): Likewise.
3225         (forget_cached_source_info): Likewise.
3226         (identify_source_line): Likewise.
3227         * source.h (identify_source_line): Move declaration from symtab.h
3228         and add comment from source.c
3229         (print_source_lines): Likewise.
3230         (forget_cached_source_info_for_objfile): Likewise.
3231         (forget_cached_source_info): Likewise.
3232         (select_source_symtab): Likewise.
3233         (enum print_source_lines_flag): Move definition from symtab.h.
3234         * symtab.h (identify_source_line): Move declaration to source.h.
3235         (print_source_lines): Likewise.
3236         (forget_cached_source_info_for_objfile): Likewise.
3237         (forget_cached_source_info): Likewise.
3238         (select_source_symtab): Likewise.
3239         (enum print_source_lines_flag): Move definition to source.h.
3240         * tui/tui-hooks.c: Add 'source.h' include.
3241
3242 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3243
3244         * source.c (print_source_lines_base): Handle requests to print
3245         reverse line number sequences, and guard against empty lines
3246         string.
3247
3248 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3249
3250         * source.c (print_source_lines_base): Fix skip of '\r' if next
3251         character is '\n'.
3252
3253 2019-01-06  Tom Tromey  <tom@tromey.com>
3254
3255         * c-exp.y (struct c_parse_state) <macro_original_text,
3256         expansion_obstack>: New member.
3257         (macro_original_text, expansion_obstack): Remove globals.
3258         (scan_macro_expansion, scanning_macro_expansion)
3259         (finished_macro_expansion): Update.
3260         (scan_macro_cleanup): Remove.
3261         (yylex, c_parse): Update.
3262
3263 2019-01-06  Tom Tromey  <tom@tromey.com>
3264
3265         * c-exp.y (struct c_parse_state) <strings>: New member.
3266         (operator_stoken): Update.
3267
3268 2019-01-06  Tom Tromey  <tom@tromey.com>
3269
3270         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3271         (union type_stack_elt) <typelist_val>: Now a pointer to
3272         std::vector.
3273         (type_stack_cleanup): Don't declare.
3274         (push_typelist): Update.
3275         * parse.c (pop_typelist): Return a std::vector.
3276         (push_typelist): Take a std::vector.
3277         (follow_types): Update.  Do not free args.
3278         (type_stack_cleanup): Remove.
3279         * c-exp.y (struct c_parse_state): New.
3280         (cpstate): New global.
3281         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3282         (nonempty_typelist): Update.
3283         (func_mod): Create a new vector.
3284         (c_parse): Create a c_parse_state.
3285         (check_parameter_typelist): Do not delete params.
3286         (function_method): Update.  Do not delete type_list.
3287
3288 2019-01-06  Tom Tromey  <tom@tromey.com>
3289
3290         PR gdb/28155:
3291         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3292         check_typedef.
3293         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3294         (print_return_value): Likewise.
3295
3296 2019-01-05  Tom Tromey  <tom@tromey.com>
3297
3298         * contrib/cleanup_check.py: Remove.
3299         * contrib/gcc-with-excheck: Remove.
3300         * contrib/exsummary.py: Remove.
3301         * contrib/excheck.py: Remove.
3302
3303 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3304
3305         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3306         NULL. Initialize tpprev to NULL instead of assigning it
3307         to NULL on the next statement.
3308         * windows-nat.c (windows_delete_thread): Remove check for
3309         main_thread_id before printing thread exit notifications.
3310         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3311         Remove thread ID check against main_thread_id.
3312         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3313         windows_delete_thread.
3314         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3315
3316 2019-01-04  Tom Tromey  <tom@tromey.com>
3317
3318         * compile/compile.c (_initialize_compile): Use upper case for
3319         metasyntactic variables.
3320         * symmisc.c (_initialize_symmisc): Use upper case for
3321         metasyntactic variables.
3322         * psymtab.c (_initialize_psymtab): Use upper case for
3323         metasyntactic variables.
3324         * demangle.c (demangle_command): Use upper case for metasyntactic
3325         variables.
3326         (_initialize_demangler): Likewise.
3327         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3328         variables.
3329
3330 2019-01-03  Tom Tromey  <tom@tromey.com>
3331
3332         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3333
3334 2019-01-03  Tom Tromey  <tom@tromey.com>
3335
3336         * python/py-symtab.c (salpy_str): Update.
3337         (struct salpy_sal_object) <symtab>: Now a PyObject.
3338         (salpy_dealloc): Update.
3339         (del_objfile_sal): Use gdbpy_ref.
3340
3341 2019-01-03  Tom Tromey  <tom@tromey.com>
3342
3343         * python/py-type.c (convert_field): Use new_reference.  Return
3344         gdbpy_ref.
3345         (make_fielditem): Return gdbpy_ref.
3346         (typy_fields): Update.
3347         (typy_getitem): Update.
3348         (field_name): Return gdbpy_ref.  Use new_reference.
3349         (typy_iterator_iternext): Update.
3350
3351 2019-01-03  Tom Tromey  <tom@tromey.com>
3352
3353         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3354
3355 2019-01-03  Tom Tromey  <tom@tromey.com>
3356
3357         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3358         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3359         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3360         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3361         (pspy_set_type_printers): Likewise.
3362         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3363         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3364         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3365         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3366         (objfpy_set_type_printers): Likewise.
3367
3368 2019-01-03  Tom Tromey  <tom@tromey.com>
3369
3370         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3371         (gdbpy_print_stack): Use gdbpy_err_fetch.
3372         * python/python-internal.h (class gdbpy_err_fetch): New class.
3373         (class gdbpy_enter) <m_error_type, m_error_value,
3374         m_error_traceback>: Remove.
3375         <m_error>: New member.
3376         (gdbpy_exception_to_string): Don't declare.
3377         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3378         * python/py-value.c (convert_value_from_python): Use
3379         gdbpy_err_fetch.
3380         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3381         gdbpy_exception_to_string.
3382         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3383         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3384         gdbpy_err_fetch.
3385
3386 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3387
3388         * linux-nat.c (delete_lwp_cleanup): Delete.
3389         (struct lwp_deleter): New struct.
3390         (lwp_info_up): New typedef.
3391         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3392         lwp_info_up.
3393
3394 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3395
3396         * linux-fork.c (class scoped_switch_fork_info): New class.
3397         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3398
3399 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3400
3401         * valops.c (find_overload_match): Remove use of null_cleanup, and
3402         calls to do_cleanups.
3403
3404 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3405
3406         * compile/compile-cplus-types.c
3407         (compile_cplus_instance::decl_name): Handle changes to
3408         cp_func_name.
3409         * cp-support.c (cp_func_name): Update header comment, update
3410         return type.
3411         * cp-support.h (cp_func_name): Update return type in declaration.
3412         * valops.c (find_overload_match): Move temp_func local to top
3413         level of function and change its type.  Use temp_func to hold and
3414         delete temporary string obtained from cp_func_name.
3415
3416 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3417
3418         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3419         gdb::char_vector, remove cleanup, and update uses of `msg`.
3420
3421 2019-01-03  Jim Wilson  <jimw@sifive.com>
3422
3423         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3424
3425 2019-01-02  Tom Tromey  <tom@tromey.com>
3426
3427         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3428         (tdesc_parse_xml): Remove cleanups.
3429         * target-descriptions.h (make_cleanup_free_target_description):
3430         Don't declare.
3431         (target_desc_deleter): New struct.
3432         (target_desc_up): New typedef.
3433         * target-descriptions.c (target_desc_deleter::operator()): Rename
3434         from free_target_description.
3435         (make_cleanup_free_target_description): Remove.
3436
3437 2019-01-02  Tom Tromey  <tom@tromey.com>
3438
3439         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3440         constructor, destructor.
3441         (linespec_parser): Remove typedef.
3442         (~linespec_parser): Rename from linespec_parser_delete.
3443         (linespec_lex_to_end, linespec_complete_label)
3444         (linespec_complete): Update.
3445         (decode_line_full): Remove cleanups.
3446         (decode_line_1): Update.
3447
3448 2019-01-02  Tom Tromey  <tom@tromey.com>
3449
3450         * python/python-internal.h (inferior_to_inferior_object): Change
3451         return type.
3452         * python/py-exitedevent.c (create_exited_event_object): Update.
3453         * python/py-inferior.c (inferior_to_inferior_object): Return
3454         gdbpy_ref.
3455         (python_new_inferior, python_inferior_deleted)
3456         (thread_to_thread_object, delete_thread_object)
3457         (build_inferior_list, gdbpy_selected_inferior): Update.
3458         * python/py-infthread.c (create_thread_object): Update.  Also fail
3459         if inferior_to_inferior_object fails.
3460
3461 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3462
3463         * inferior.h (class inferior) <displaced_step_state>: New field.
3464         * infrun.h (struct displaced_step_state): Move here from
3465         infrun.c.  Initialize fields, add constructor.
3466         <inf>: Remove field.
3467         <reset>: New method.
3468         * infrun.c (struct displaced_step_inferior_state): Move to
3469         infrun.h.
3470         (displaced_step_inferior_states): Remove.
3471         (get_displaced_stepping_state): Adust.
3472         (displaced_step_in_progress_any_inferior): Adjust.
3473         (displaced_step_in_progress_thread): Adjust.
3474         (displaced_step_in_progress): Adjust.
3475         (add_displaced_stepping_state): Remove.
3476         (get_displaced_step_closure_by_addr): Adjust.
3477         (remove_displaced_stepping_state): Remove.
3478         (infrun_inferior_exit): Call displaced_step_state.reset.
3479         (use_displaced_stepping): Don't check for NULL.
3480         (displaced_step_prepare_throw): Call
3481         get_displaced_stepping_state.
3482         (displaced_step_fixup): Don't check for NULL.
3483         (prepare_for_detach): Don't check for NULL.
3484
3485 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3486
3487         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3488          in case of call that did not complete.
3489
3490 2019-01-02  Andrey Utkin  <autkin@undo.io>
3491
3492         * symfile.c (find_separate_debug_file): Fix search of debug files for
3493         remote debuggee.
3494
3495 2019-01-02  Tom Tromey  <tom@tromey.com>
3496
3497         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3498         indentation.
3499         * python/py-frame.c (frapy_older): Remove cast.
3500         (frapy_newer): Likewise.
3501         * python/py-breakpoint.c (local_setattro): Remove cast.
3502         * python/py-arch.c (archpy_name): Remove local variable.
3503         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3504
3505 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3506
3507         * unittests/basic_string_view/element_access/char/empty.cc:
3508         Fix year range in copyright header.
3509
3510 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3511
3512         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3513         Delete.
3514         <operator==>: Update with for removed field.
3515         <hash>: Likewise.
3516         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3517         <isa_features>: ...this.
3518         <abi_features>: New field.
3519         (riscv_isa_flen): Update comment.
3520         (riscv_abi_xlen): New declaration.
3521         (riscv_abi_flen): New declaration.
3522         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3523         isa_features.
3524         (riscv_abi_xlen): New function.
3525         (riscv_isa_flen): Update to get answer from isa_features.
3526         (riscv_abi_flen): New function.
3527         (riscv_has_fp_abi): Update to get answer from abi_features.
3528         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3529         xlen and flen.
3530         (riscv_call_info) <xlen, flen>: Update comment.
3531         (riscv_call_arg_struct): Remove invalid assertions
3532         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3533         is removed.
3534         (riscv_gdbarch_init): Gather isa features and abi features
3535         separately, ensure both match on the gdbarch when reusing an old
3536         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3537         a target with 64-bit float hardware.
3538
3539 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3540
3541         * source.c (search_command_helper): Stop reverse search
3542         when line 1 has been searched.
3543
3544 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3545
3546         * record-full.c (record_full_base_target::close): Rewrite
3547         record_full_core_buf_list free logic.
3548
3549 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3550
3551         * break-catch-syscall.c (print_one_catch_syscall): xfree
3552         the last text.
3553
3554 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3555
3556         * top.c (print_gdb_version): Update Copyright year in version
3557         message.
3558
3559 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3560
3561         Update copyright year range in all GDB files.
3562
3563 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3564
3565         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3566
3567 For older changes see ChangeLog-2018.
3568 \f
3569 Local Variables:
3570 mode: change-log
3571 left-margin: 8
3572 fill-column: 74
3573 version-control: never
3574 coding: utf-8
3575 End:
3576