gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
   4         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
   5         clear_detail method directly.
   6         (tui_clear_win_detail): Remove.
   7
   8 2019-06-25  Tom Tromey  <tom@tromey.com>
   9
  10         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
  11         "this", not TUI_DISASM_WIN.
  12
  13 2019-06-25  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
  16         declare.
  17         * tui/tui-winsource.c
  18         (tui_source_window_base::do_scroll_horizontal): Rename from
  19         tui_horizontal_source_scroll.
  20         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
  21         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
  22         from tui_vertical_data_scroll.
  23         * tui/tui-win.h (tui_scroll): Don't declare.
  24         * tui/tui-win.c (tui_win_info::forward_scroll)
  25         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
  26         (tui_win_info::right_scroll): Rename and update.
  27         (tui_scroll_forward_command, tui_scroll_backward_command)
  28         (tui_scroll_left_command, tui_scroll_right_command): Update.
  29         (tui_scroll): Remove.
  30         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
  31         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
  32         from tui_vertical_source_scroll.
  33         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
  34         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
  35         from tui_vertical_disassem_scroll.
  36         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
  37         do_scroll_horizontal>: New methods.
  38         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
  39         Likewise.
  40         (struct tui_source_window_base): Add do_scroll_horizontal.
  41         (struct tui_source_window, struct tui_disasm_window): Add
  42         do_scroll_vertical.
  43         (struct tui_data_window, struct tui_cmd_window): Add
  44         do_scroll_horizontal and do_scroll_vertical.
  45         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
  46
  47 2019-06-25  Tom Tromey  <tom@tromey.com>
  48
  49         * tui/tui-data.h (struct tui_source_window_base): New struct.
  50         (struct tui_source_window): Derive from tui_source_window_base.
  51         (struct tui_disasm_window): New struct.
  52         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
  53         from tui_source_window::clear_detail.
  54         (tui_source_window_base): Rename from tui_source_window.
  55         (~tui_source_window_base): Rename from ~tui_source_window.
  56         (tui_alloc_win_info): Create a tui_disasm_window.
  57
  58 2019-06-25  Tom Tromey  <tom@tromey.com>
  59
  60         * tui/tui-data.h (struct tui_source_window)
  61         (struct tui_data_window): Declare destructors.
  62         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
  63         destructors.
  64         (tui_win_info): Simplify.
  65
  66 2019-06-25  Tom Tromey  <tom@tromey.com>
  67
  68         * tui/tui-winsource.c (tui_display_main)
  69         (tui_update_source_windows_with_addr)
  70         (tui_update_all_breakpoint_info): Update.
  71         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
  72         (new_height_ok, parse_scrolling_args): Update.
  73         * tui/tui-stack.c (tui_show_frame_info): Update.
  74         * tui/tui-data.h (struct tui_list): Remove.
  75         (tui_source_windows): Return a reference to a std::vector.
  76         * tui/tui-data.c (source_windows): Now a std::vector.
  77         (tui_source_windows): Change return type.
  78         (tui_clear_source_windows): Rewrite.
  79         (tui_clear_source_windows_detail, tui_add_to_source_windows)
  80         (tui_free_all_source_wins_content): Rewrite.
  81
  82 2019-06-25  Tom Tromey  <tom@tromey.com>
  83
  84         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
  85         (struct tui_data_window, struct tui_cmd_window): Declare
  86         clear_detail method.
  87         * tui/tui-data.c (tui_source_window::clear_detail)
  88         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
  89         methods.
  90         (tui_clear_win_detail): Simplify.
  91
  92 2019-06-25  Tom Tromey  <tom@tromey.com>
  93
  94         * tui/tui-layout.c (make_source_window, make_disasm_window)
  95         (make_source_or_disasm_window): Remove win_info_ptr parameter.
  96         Return the new window.
  97         (show_source_disasm_command, show_data)
  98         (show_source_or_disasm_and_command): Update.
  99
 100 2019-06-25  Tom Tromey  <tom@tromey.com>
 101
 102         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 103         parameter.  Return the new window.
 104         (show_source_disasm_command): Update and remove NULL check.
 105         (show_source_or_disasm_and_command): Update.
 106
 107 2019-06-25  Tom Tromey  <tom@tromey.com>
 108
 109         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 110
 111 2019-06-25  Tom Tromey  <tom@tromey.com>
 112
 113         * tui/tui-data.h (struct tui_win_info): Make constructor
 114         protected.  Make destructor virtual.  Add initializers.
 115         (tui_source_window, tui_data_window, tui_cmd_window): New
 116         classes.
 117         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 118         constructor.  Add "type" parameter.
 119         (tui_source_window, tui_data_window, tui_cmd_window): New
 120         constructors.
 121         (tui_alloc_win_info): Instantiate the appropriate subclass.
 122
 123 2019-06-25  Tom Tromey  <tom@tromey.com>
 124
 125         * tui/tui-win.c (tui_resize_all): Use delete.
 126         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 127         destructor.
 128         (tui_free_window): Don't declare.
 129         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 130         Update.
 131
 132 2019-06-25  Tom Tromey  <tom@tromey.com>
 133
 134         * tui/tui-data.h (struct tui_win_info): Add constructor.
 135         * tui/tui-data.c (tui_alloc_win_info): Use new.
 136         (tui_free_window): Use delete.
 137
 138 2019-06-22  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 141         declare.
 142         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 143
 144 2019-06-22  Tom Tromey  <tom@tromey.com>
 145
 146         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 147         declare.
 148         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 149
 150 2019-06-22  Tom de Vries  <tdevries@suse.de>
 151
 152         * dwarf2read.c (create_addrmap_from_aranges)
 153         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 154         instead of '%zu'.
 155
 156 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 157
 158         * dwarf2read.h (dwarf2_section_info_def): Remove.
 159         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 160         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 161         std::vector<dwarf2_section_info>.
 162         (struct dwo_file) <~dwo_file>: Remove.
 163         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 164         types field.
 165         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 166         (dwarf2_read_debug_names): Likewise.
 167         (create_debug_types_hash_table): Change parameter type to
 168         array_view, adjust code accordingly.
 169         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 170         (partial_die_info::fixup): Likewise.
 171         (determine_prefix): Likewise.
 172         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 173
 174 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 175
 176         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 177         gdb_bfd_ref_ptr.
 178         <~dwo_file>: Remove call to gdb_bfd_unref.
 179         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 180         gdb_bfd_ref_ptr::get.
 181
 182 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 183
 184         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 185         type to htab_up.
 186         * dwarf2read.c (struct dwo_file): Initialize fields.
 187         <~dwo_file>: New.
 188         (free_dwo_file): Remove, move content to ~dwo_file.
 189         (struct dwo_file_deleter): Remove.
 190         (dwo_file_up>: Remove custom deleter.
 191         (free_dwo_files): Remove.
 192         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 193         dwo_files.
 194         (process_skeletonless_type_units): Call unique_ptr::get.
 195         (allocate_dwo_file_hash_table): Add deleter to created hash
 196         table.  Change return type to htab_up.
 197         (lookup_dwo_file_slot): Don't memset dwo_file, call
 198         unique_ptr::get.
 199         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 200         (create_dwo_unit_in_dwp_v2): Likewise.
 201         (open_and_init_dwo_file): Likewise.
 202         (free_dwo_file_from_slot): Remove.
 203
 204 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 205
 206         * dwarf2read.h (struct dwarf2_section_info) <readin,
 207         is_virtual>: Change type to bool.
 208         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 209         true instead of 1.
 210
 211 2019-06-19  Tom Tromey  <tom@tromey.com>
 212
 213         * tui/tui-data.h (tui_init_content_element): Don't declare.
 214
 215 2019-06-19  Tom Tromey  <tom@tromey.com>
 216
 217         * tui/tui-data.h (tui_init_win_info): Don't declare.
 218
 219 2019-06-19  Tom de Vries  <tdevries@suse.de>
 220
 221         * dwarf2read.h (abstract_to_concrete): Change type to
 222         std::unordered_map<sect_offset, std::vector<sect_offset>,
 223         gdb::hash_enum<sect_offset>>.
 224
 225 2019-06-19  Tom Tromey  <tromey@adacore.com>
 226
 227         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 228         EVAL_AVOID_SIDE_EFFECTS specially.
 229
 230 2019-06-19  Tom Tromey  <tromey@adacore.com>
 231
 232         * source-cache.c (highlighter): New global.
 233         (source_cache::get_source_lines): Create a highlighter on demand.
 234
 235 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 236
 237         * defs.h (deprecated_interactive_hook): Delete declaration.
 238         * interps.c (clear_interpreter_hooks): Remove use of
 239         deprecated_interactive_hook.
 240         * top.c (deprecated_interactive_hook): Delete definition.
 241         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 242
 243 2019-06-18  Tom de Vries  <tdevries@suse.de>
 244
 245         PR gdb/24515
 246         * dwarf2read.h (abstract_to_concrete): Change type from
 247         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 248         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 249         * dwarf2read.c (read_variable): Update.
 250         (dwarf2_fetch_die_loc_sect_off): Update.
 251
 252 2019-06-17  Tom de Vries  <tdevries@suse.de>
 253
 254         PR gdb/24617
 255         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 256         accessing parent[parent_len - 1].
 257
 258 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 259
 260         PR gdb/24364
 261         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 262         call dtrace_process_dof with NULL dof.
 263
 264 2019-06-16  Tom de Vries  <tdevries@suse.de>
 265
 266         PR gdb/24445
 267         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 268
 269 2019-06-16  Tom Tromey  <tom@tromey.com>
 270
 271         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 272         (make_all_visible): Use address of member.
 273
 274 2019-06-16  Tom Tromey  <tom@tromey.com>
 275
 276         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 277         (tui_free_window, free_content, free_content_elements): Remove
 278         unnecessary cast.
 279         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 280         cast.
 281         * tui/tui-regs.c (tui_show_register_group)
 282         (tui_display_registers_from, tui_display_reg_element_at_line):
 283         Remove unnecessary cast.
 284
 285 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 286
 287         * linux-nat.c (normal_mask): Delete.
 288         (_initialize_linux_nat): Don't initialise normal_mask.
 289
 290 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 291
 292         PR gdb/24445
 293         * dwarf-index-write.h (write_psymtabs_to_index): Add
 294         dwz_basename parameter.
 295         * dwarf-index-write.c (write_gdbindex): Move file writing to
 296         write_gdbindex_1.  Change return type void.
 297         (assert_file_size): Move up, remove filename parameter.
 298         (write_gdbindex_1): New function.
 299         (write_debug_names): Change return type to void, call
 300         assert_file_size.
 301         (struct index_wip_file): New struct.
 302         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 303         file logic to index_wip_file.  Write index for dwz file if
 304         needed.
 305         (save_gdb_index_command): Pass basename of dwz file, if present.
 306         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 307         build-id of dwz file, if present.
 308         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 309         (dwarf2_get_dwz_file): Likewise.
 310         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 311         (dwarf2_get_dwz_file): Likewise.
 312
 313 2019-06-16  Tom Tromey  <tom@tromey.com>
 314
 315         * coffread.c (process_coff_symbol): Use xstrdup.
 316         * value.c (create_internalvar): Use xstrdup.
 317
 318 2019-06-16  Tom Tromey  <tom@tromey.com>
 319
 320         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 321         * breakpoint.c (stopin_command, stopat_command)
 322         (until_break_command, decode_location_default): Remove unnecessary
 323         cast.
 324         * utils.c (subset_compare): Remove unnecessary cast.
 325         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 326         cast.
 327         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 328         cast.
 329         * infcmd.c (path_command): Remove unnecessary cast.
 330         * coffread.c (decode_type): Remove unnecessary cast.
 331         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 332         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 333         * tui/tui-stack.c (tui_show_locator_content)
 334         (tui_show_frame_info): Remove unnecessary cast.
 335         * tui/tui-win.c (tui_scroll_forward_command)
 336         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 337         (parse_scrolling_args): Remove unnecessary cast.
 338         * tui/tui-data.c (init_win_info, tui_del_window)
 339         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 340         (free_content_elements): Remove unnecessary cast.
 341         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 342         unnecessary cast.
 343         * tui/tui-source.c (tui_set_source_content)
 344         (tui_vertical_source_scroll): Remove unnecessary cast.
 345         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 346         cast.
 347         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 348         * tui/tui-regs.c (tui_display_registers_from)
 349         (tui_display_register): Remove unnecessary cast.
 350         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 351         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 352         (make_visible): Remove unnecessary cast.
 353         * tui/tui-winsource.c (tui_erase_source_content)
 354         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 355         unnecessary cast.
 356         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 357         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 358         * stabsread.c (read_type, read_array_type, read_range_type):
 359         Remove unnecessary cast.
 360         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 361         (parse_symbol, parse_type, upgrade_type, parse_external)
 362         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 363         unnecessary cast.
 364         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 365
 366 2019-06-16  Tom Tromey  <tom@tromey.com>
 367
 368         * tui/tui-data.c (tui_alloc_generic_win_info)
 369         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 370         checks.
 371
 372 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 373             Andrew Burgess  <andrew.burgess@embecosm.com>
 374
 375         * f-typeprint.c (f_print_type): Don't return early for not
 376         associated or not allocated types.
 377         (f_type_print_varspec_suffix): Add print_rank parameter and print
 378         ranks of array types in case they dangling.
 379         (f_type_print_base): Add print_rank parameter.
 380
 381 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 382
 383         * NEWS: Mention new MI commands.
 384         * break-catch-throw.c (enum exception_event_kind): Move to
 385         breakpoint.h.
 386         (print_mention_exception_catchpoint): Output text as a single
 387         message.
 388         (catch_exception_command_1): Rename to...
 389         (catch_exception_event): ...this, make non-static, update header
 390         command, and change some parameter types.
 391         (catch_catch_command): Update for changes to
 392         catch_exception_command_1.
 393         (catch_throw_command): Likewise.
 394         (catch_rethrow_command): Likewise.
 395         * breakpoint.c (enum exception_event_kind): Delete.
 396         * breakpoint.h (enum exception_event_kind): Moved here from
 397         break-catch-throw.c.
 398         (catch_exception_event): Declare.
 399         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 400         (mi_cmd_catch_throw): New function.
 401         (mi_cmd_catch_rethrow): New function.
 402         (mi_cmd_catch_catch): New function.
 403         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 404         'catch-catch' entries.
 405         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 406         (mi_cmd_catch_rethrow): Declare.
 407         (mi_cmd_catch_catch): Declare.
 408
 409 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 410
 411         * annotate.c (annotate_source_line): Change return type to void,
 412         update implementation to match.
 413         * annotate.h (annotate_source_line): Change return type to void,
 414         update header comment.
 415         * stack.c (print_frame_info): Don't change what frame information
 416         is printed based on whether annotations are on or not.
 417
 418 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 419
 420         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 421         (annotate_source): Make static.
 422         (annotate_source_line): Moved from source.c and renamed from
 423         identify_source_line.  Update the return type.
 424         * annotate.h (annotate_source): Delete declaration.
 425         (annotate_source_line): Declaration moved from source.h, and
 426         renamed from identify_source_line.  Return type updated.
 427         * source.c (identify_source_line): Moved to annotate.c and renamed
 428         to annotate_source_line.
 429         (info_line_command): Remove check of annotation_level.
 430         * source.h (identify_source_line): Move declaration to annotate.h
 431         and rename to annotate_source_line.
 432         * stack.c: Add 'annotate.h' include.
 433         (print_frame_info): Remove check of annotation_level before
 434         calling annotate_source_line.
 435
 436 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 437
 438         * source-cache.c (source_cache::get_plain_source_lines): Use
 439         open_source_file_with_line_charpos instead of just
 440         open_source_file, remove call to find_source_lines.
 441         (source_cache::get_source_lines): Likewise.
 442         * source.c (find_source_lines): Make static.
 443         (get_filename_and_charpos): Renamed into...
 444         (open_source_file_with_line_charpos): ..this along with changes to
 445         return a scoped_fd, and some other minor clean ups.
 446         (identify_source_line): Use open_source_file_with_line_charpos.
 447         (search_command_helper): Use open_source_file_with_line_charpos
 448         instead of just open_source_file, remove call to
 449         find_source_lines.
 450         * source.h (open_source_file_with_line_charpos): Declare new
 451         function.
 452         (find_source_lines): Delete declaration.
 453
 454 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 455
 456         * source.c (get_filename_and_charpos): Remove fullname
 457         parameter.
 458         (identify_source_line): Update call to get_filename_and_charpos.
 459
 460 2019-06-14  Tom Tromey  <tromey@adacore.com>
 461
 462         PR gdb/24502:
 463         * ui-style.h (skip_ansi_escape): Update comment.
 464         * ui-file.h (class no_terminal_escape_file): New class.
 465         * ui-file.c (no_terminal_escape_file::write)
 466         (no_terminal_escape_file::puts): New methods.
 467         * cli/cli-logging.c (handle_redirections): Use
 468         no_terminal_escape_file.
 469
 470 2019-06-14  Tom Tromey  <tromey@adacore.com>
 471
 472         * NEWS: Move convenience variable news above Python news.
 473
 474 2019-06-14  Tom Tromey  <tom@tromey.com>
 475
 476         * gnulib: Move directory to top-level.
 477         * configure.ac: Don't configure gnulib.
 478         * configure: Rebuild.
 479         * common/common-defs.h: Use new path to gnulib.
 480         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 481         (GNULIB_H): Remove.
 482         (INCGNU): Look in new gnulib location.
 483         (HFILES_NO_SRCDIR): Remove gnulib files.
 484         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 485         (generated_files): Remove GNULIB_H.
 486         ($(LIBGNU), all-lib): Remove targets.
 487         (distclean): Don't mention GNULIB_BUILDDIR.
 488         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 489
 490 2019-06-14  Tom Tromey  <tromey@adacore.com>
 491
 492         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 493         Warn if symbol file does not provide any symbols.
 494
 495 2019-06-14  Tom Tromey  <tromey@adacore.com>
 496
 497         * source.c (find_and_open_source): Respect basenames_may_differ.
 498
 499 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 500
 501         * annotate.c (annotate_breakpoints_invalid): Make use of
 502         scoped_restore_terminal_state.
 503         (annotate_frames_invalid): Likewise.
 504
 505 2019-06-14  Tom Tromey  <tromey@adacore.com>
 506
 507         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 508         allow assignment to an internalvar.
 509
 510 2019-06-14  Tom Tromey  <tromey@adacore.com>
 511
 512         * ada-lex.l: Allow "_" in attribute names.
 513
 514 2019-06-14  Tom Tromey  <tromey@adacore.com>
 515
 516         PR gdb/24653:
 517         * regcache.c (registers_changed): Don't call alloca.
 518         * top.c (execute_command): Don't call alloca.
 519
 520 2019-06-13  Pedro Alves  <palves@redhat.com>
 521
 522         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 523         'expression'.  When parsing an expression, error out if there's
 524         junk after "unlimited".
 525         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 526         (do_set_command): Adjust calls to is_unlimited_literal.
 527
 528 2019-06-13  Pedro Alves  <palves@redhat.com>
 529
 530         * compile/compile.c (make_compile_options_def_group): Add braces
 531         around array_view initializer.
 532         * thread.c (make_thread_apply_all_options_def_group)
 533         (make_thread_apply_all_options_def_group): Likewise.
 534
 535 2019-06-13  Pedro Alves  <palves@redhat.com>
 536
 537         * NEWS (New commands): Mention "maint test-options
 538         require-delimiter", "maint test-options unknown-is-error", "maint
 539         test-options unknown-is-operand" and "maint show
 540         test-options-completion-result".
 541         (New command options, command completion): New section.
 542         (Completion improvements): New section.
 543         Mention that you can abbreviate "unlimited".
 544
 545 2019-06-13  Pedro Alves  <palves@redhat.com>
 546
 547         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 548         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 549         * unittests/cli-utils-selftests.c (test_parse_flags)
 550         (test_parse_flags_qcs): Delete.
 551         (test_cli_utils): Don't call deleted functions.
 552
 553 2019-06-13  Pedro Alves  <palves@redhat.com>
 554
 555         * thread.c: Include "cli/cli-option.h".
 556         (tp_array_compar_ascending): Global.
 557         (tp_array_compar): Delete function.
 558         (tp_array_compar_ascending, tp_array_compar_descending): New
 559         functions.
 560         (ascending_option_def, qcs_flag_option_def)
 561         (thr_qcs_flags_option_defs)
 562         (make_thread_apply_all_options_def_group)
 563         (make_thread_apply_options_def_group): New.
 564         (thread_apply_all_command): Use gdb::option::process_options.
 565         (thread_apply_command_completer)
 566         (thread_apply_all_command_completer): New.
 567         (thread_apply_command): Use gdb::option::process_options.
 568         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 569         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 570         to generate help text of "thread apply".  Adjust "taas"'s help.
 571         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 572         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 573
 574 2019-06-13  Pedro Alves  <palves@redhat.com>
 575
 576         * thread.c (thread_apply_command): Check for invalid TID with
 577         isdigit instead of !isalpha.
 578
 579 2019-06-13  Pedro Alves  <palves@redhat.com>
 580
 581         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 582         (validate_flags_qcs): New.
 583         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 584         (validate_flags_qcs): Declare.
 585         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 586         (make_frame_apply_options_def_group): New.
 587         (frame_apply_command_count): Process options with
 588         gdb::option::process_options.
 589         (frame_apply_completer): New.
 590         (frame_apply_level_completer, frame_apply_all_completer)
 591         (frame_apply_completer): New.
 592         (_initialize_stack): Update help of "frame apply", "frame apply
 593         level", "frame apply all" and "faas" to mention supported options
 594         and install command completers.
 595         * stack.h (frame_apply_all_completer): Declare.
 596         * thread.c: Include "stack.h".
 597         (tfaas_command): Add "--".
 598         (_initialize_thread): Update help "tfaas" to mention supported
 599         options and install command completer.
 600
 601 2019-06-13  Pedro Alves  <palves@redhat.com>
 602
 603         * completer.c (complete_nested_command_line): New.
 604         (gdb_completion_word_break_characters_throw): Add assertion.
 605         * completer.h (complete_nested_command_line): Declare.
 606
 607 2019-06-13  Pedro Alves  <palves@redhat.com>
 608
 609         * stack.c (parse_backtrace_qualifiers): New.
 610         (backtrace_command): Use it.
 611         (backtrace_command_completer): Complete on qualifiers.
 612
 613 2019-06-13  Pedro Alves  <palves@redhat.com>
 614
 615         * frame.c: Include "cli/cli-option.h.
 616         (user_set_backtrace_options): New.
 617         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 618         Delete.
 619         (get_prev_frame): Adjust.
 620         (boolean_option_def, uinteger_option_def)
 621         (set_backtrace_option_defs): New.
 622         (_initialize_frame): Adjust and use
 623         gdb::option::add_setshow_cmds_for_options to install "set
 624         backtrace past-main" and "set backtrace past-entry".
 625         * frame.h: Include "cli/cli-option.h".
 626         (struct frame_print_options): Forward declare.
 627         (print_frame_arguments_all, print_frame_arguments_scalars)
 628         (print_frame_arguments_none): Declare.
 629         (print_entry_values): Delete declaration.
 630         (struct frame_print_options, user_frame_print_options): New.
 631         (struct set_backtrace_options): New.
 632         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 633         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 634         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 635         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 636         (list_args_or_locals): Add frame_print_options parameter.
 637         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 638         * python/py-framefilter.c (enumerate_args): Pass down
 639         USER_FRAME_PRINT_OPTIONS.
 640         * stack.c: Include "cli/cli-option.h".
 641         (print_frame_arguments_all, print_frame_arguments_scalars)
 642         (print_frame_arguments_none): Declare.
 643         (print_raw_frame_arguments, print_entry_values): Delete.
 644         (user_frame_print_options): New.
 645         (boolean_option_def, enum_option_def, frame_print_option_defs):
 646         New.
 647         (struct backtrace_cmd_options): New.
 648         (bt_flag_option_def): New.
 649         (backtrace_command_option_defs): New.
 650         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 651         (print_frame_arg, read_frame_arg, print_frame_args)
 652         (print_frame_info, print_frame): Add frame_print_options parameter
 653         and use it.
 654         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 655         (backtrace_command_1): Add frame_print_options and
 656         backtrace_cmd_options parameters and use them.
 657         (make_backtrace_options_def_group): New.
 658         (backtrace_command): Process command options with
 659         gdb::option::process_options.
 660         (backtrace_command_completer): New.
 661         (_initialize_stack): Extend "backtrace"'s help to mention
 662         supported options.  Install completer for "backtrace".
 663         Install some settings commands with add_setshow_cmds_for_options.
 664
 665 2019-06-13  Pedro Alves  <palves@redhat.com>
 666
 667         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 668         and that "set/show print raw frame-arguments" are now deprecated.
 669
 670         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 671         command.
 672         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 673         * stack.c (_initialize_stack): Install "set/show print
 674         raw-frame-arguments", and deprecate "set/show print raw
 675         frame-arguments".
 676         * valprint.c (_initialize_valprint): Deprecate "set/show print
 677         raw".
 678
 679 2019-06-13  Pedro Alves  <palves@redhat.com>
 680
 681         * compile/compile.c (struct compile_options): New.
 682         (compile_flag_option_def, compile_command_option_defs)
 683         (make_compile_options_def_group): New.
 684         (compile_file_command): Handle options with
 685         gdb::option::process_options.
 686         (compile_file_command_completer): New function.
 687         (compile_code_command): Handle options with
 688         gdb::option::process_options.
 689         (compile_code_command_completer): New function.
 690         (_initialize_compiler): Install completers for "compile code" and
 691         "compile file".  Mention available options in "compile code" and
 692         "compile code"'s help.
 693         * completer.c (advance_to_completion_word): New, factored out from
 694         ...
 695         (advance_to_expression_complete_word_point): ... this.
 696         (advance_to_filename_complete_word_point): New.
 697         * completer.h (advance_to_filename_complete_word_point): New
 698         declaration.
 699
 700 2019-06-13  Pedro Alves  <palves@redhat.com>
 701
 702         * compile/compile.c: Include "cli/cli-option.h".
 703         (compile_print_value): Scope data pointer is now a
 704         value_print_options pointer; adjust.
 705         (compile_print_command): Process options.  Scope data pointer is
 706         now a value_print_options pointer; adjust.
 707         (_initialize_compile): Update "compile print"'s help to include
 708         supported options.  Install a completer for "compile print".
 709         * cp-valprint.c (show_vtblprint, show_objectprint)
 710         (show_static_field_print): Delete.
 711         (_initialize_cp_valprint): Don't install "set print
 712         static-members", "set print vtbl", "set print object" here.
 713         * printcmd.c: Include "cli/cli-option.h" and
 714         "common/gdb_optional.h".
 715         (print_command_parse_format): Rework to fill in a
 716         value_print_options instead of a format_data.
 717         (print_value): Change parameter type from format_data pointer to
 718         value_print_options reference.  Adjust.
 719         (print_command_1): Process options.  Adjust to pass down a
 720         value_print_options.
 721         (print_command_completer): New.
 722         (_initialize_printcmd): Install print_command_completer as
 723         handle_brkchars completer for the "print" command.  Update
 724         "print"'s help to include supported options.
 725         * valprint.c: Include "cli/cli-option.h".
 726         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 727         here from cp-valprint.c.
 728         (boolean_option_def, uinteger_option_def)
 729         (value_print_option_defs, make_value_print_options_def_group):
 730         New.  Use gdb::option::add_setshow_cmds_for_options to install
 731         "set print elements", "set print null-stop", "set print repeats",
 732         "set print pretty", "set print union", "set print array", "set
 733         print address", "set print symbol", "set print array-indexes".
 734         * valprint.h: Include <string> and "cli/cli-option.h".
 735         (make_value_print_options_def_group): Declare.
 736         (print_value): Change parameter type from format_data pointer to
 737         value_print_options reference.
 738         (print_command_completer): Declare.
 739
 740 2019-06-13  Pedro Alves  <palves@redhat.com>
 741
 742         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 743         (COMMON_SFILES): Add maint-test-settings.c.
 744         * cli/cli-decode.c (boolean_enums): New global, factored out from
 745         ...
 746         (add_setshow_boolean_cmd): ... here.
 747         * cli/cli-decode.h (boolean_enums): Declare.
 748         * cli/cli-option.c: New file.
 749         * cli/cli-option.h: New file.
 750         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 751         factored out from ...
 752         (parse_cli_boolean_value(const char *)): ... this.
 753         (is_unlimited_literal): Change parameter type to pointer to
 754         pointer.  Adjust and advance ARG pointer.
 755         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 756         (parse_cli_var_enum): New, factored out from ...
 757         (do_set_command): ... this.  Adjust.
 758         * cli/cli-setshow.h (parse_cli_boolean_value)
 759         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 760         (parse_cli_var_enum): Declare.
 761         * cli/cli-utils.c: Include "cli/cli-option.h".
 762         (get_ulongest): New.
 763         * cli/cli-utils.h (get_ulongest): Declare.
 764         (check_for_argument): New overloads.
 765         * maint-test-options.c: New file.
 766
 767 2019-06-13  Pedro Alves  <palves@redhat.com>
 768
 769         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 770         parse a range if "-" is at the end of the string.
 771
 772 2019-06-13  Pedro Alves  <palves@redhat.com>
 773
 774         * cli/cli-setshow.c (parse_auto_binary_operation)
 775         (parse_cli_boolean_value): Don't allow "o".
 776
 777 2019-06-13  Pedro Alves  <palves@redhat.com>
 778
 779         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 780         * NEWS: Mention maint test-settings KIND.
 781         * maint-test-settings.c: New file.
 782
 783 2019-06-13  Pedro Alves  <palves@redhat.com>
 784
 785         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 786         completer.
 787         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 788         "set" completers.
 789
 790 2019-06-13  Pedro Alves  <palves@redhat.com>
 791
 792         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 793         after item.
 794
 795 2019-06-13  Pedro Alves  <palves@redhat.com>
 796
 797         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 798
 799 2019-06-13  Pedro Alves <palves@redhat.com>
 800
 801         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 802         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 803         call.
 804         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 805         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 806         calls.
 807         (check_for_argument): Skip spaces after argument.
 808
 809 2019-06-13  Pedro Alves  <palves@redhat.com>
 810
 811         * thread.c (thread_apply_command): Adjust TID parsing.
 812         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 813         detected before end of string.
 814         (tid_is_in_list): Error out if LIST is invalid.
 815
 816 2019-06-13  Pedro Alves  <palves@redhat.com>
 817
 818         * completer.c (complete_line_internal_1): Rewind completion word
 819         point.
 820         (completion_tracker::advance_custom_word_point_by): Change
 821         parameter type to int.
 822         * completer.h (completion_tracker::advance_custom_word_point_by):
 823         Likewise.
 824
 825 2019-06-13  Pedro Alves  <palves@redhat.com>
 826
 827         * completer.c (advance_to_completion_word): Handle delimiters.
 828
 829 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 830
 831         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 832
 833 2019-06-11  Tom Tromey  <tom@tromey.com>
 834
 835         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 836         (xmalloc_failed): Move to alloc.c.
 837         * alloc.c: New file.
 838         * Makefile.in (COMMON_SFILES): Add alloc.c.
 839
 840 2019-06-11  Tom Tromey  <tom@tromey.com>
 841
 842         * nat/linux-waitpid.c: Don't include server.h.
 843         (linux_debug): Remove.
 844         (my_waitpid): Update.
 845
 846 2019-06-11  Tom Tromey  <tromey@adacore.com>
 847
 848         * infcall.c (_initialize_infcall): Remove trailing newline from
 849         help.
 850         * user-regs.c (_initialize_user_regs): Remove trailing newline
 851         from help.
 852         * typeprint.c (_initialize_typeprint): Remove trailing newline
 853         from help.
 854         * reverse.c (_initialize_reverse): Remove trailing newlines from
 855         help.
 856         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 857         from help.
 858         * language.c (add_set_language_command): Remove trailing newline
 859         from help.
 860         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 861         help.
 862         * disasm.c (_initialize_disasm): Remove trailing newline from
 863         help.
 864         * top.c (init_main): Remove trailing newline from help.
 865         * interps.c (_initialize_interpreter): Remove trailing newline
 866         from help.
 867         * btrace.c (_initialize_btrace): Remove trailing newlines from
 868         help.
 869         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 870         from help.
 871         * python/python.c (_initialize_python): Remove trailing newline
 872         from help.
 873         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 874         help.
 875         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 876         from help.  Reformat some text.
 877         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 878         from help.
 879         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 880         newline from help.
 881
 882 2019-06-11  Tom Tromey  <tromey@adacore.com>
 883
 884         * darwin-nat.c (darwin_decode_exception_message)
 885         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 886
 887 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 888
 889         * valops.c (value_slice): Check for not allocated or not
 890         associated values.
 891
 892 2019-06-10  Tom de Vries  <tdevries@suse.de>
 893
 894         PR gdb/24618
 895         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 896         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 897         invalid.
 898
 899 2019-06-10  Tom de Vries  <tdevries@suse.de>
 900
 901         PR gdb/24611
 902         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 903         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 904
 905 2019-06-10  Tom de Vries  <tdevries@suse.de>
 906
 907         PR symtab/24545
 908         * symtab.c (struct demangled_name_entry): Add language field.
 909         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 910         static minimal symbol".  Set and use language field.
 911
 912 2019-06-10  Tom Tromey  <tromey@adacore.com>
 913
 914         * ada-lang.c (_initialize_ada_language): Update help text.
 915
 916 2019-06-10  Tom Tromey  <tromey@adacore.com>
 917
 918         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 919         with a newline.
 920         * guile/guile.c (handle_boot_error): Don't end warning with a
 921         newline.
 922         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 923         warning with a newline.
 924         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 925         newline.
 926         (s12z_frame_cache): Likewise.
 927         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 928         a newline.
 929         * solib-svr4.c (disable_probes_interface): Don't end warning with
 930         a newline.
 931         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 932         newline.
 933         * python/python.c (do_finish_initialization): Don't end warning
 934         with a newline.
 935
 936 2019-06-10  Tom Tromey  <tom@tromey.com>
 937
 938         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 939         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 940         gdbpy_enter.
 941
 942 2019-06-10  Tom Tromey  <tromey@adacore.com>
 943
 944         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 945         data.
 946         (elf_new_init): Don't call stabsread_new_init.
 947         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 948         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 949         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 950
 951 2019-06-10  Tom de Vries  <tdevries@suse.de>
 952
 953         PR symtab/16264
 954         PR symtab/24517
 955         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 956
 957 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 958
 959         * source.c (find_and_open_source): Also rewrite relative file
 960         names.
 961
 962 2019-04-26  Amos Bird  <amosbird@gmail.com>
 963
 964         * annotate.c (annotate_thread_exited): Add "thread-exited"
 965         annotation.
 966
 967 2019-06-06  Tom Tromey  <tromey@adacore.com>
 968
 969         * maint.h (class scoped_command_stats): Use
 970         DISABLE_COPY_AND_ASSIGN.
 971         <print_time>: New method.
 972         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 973         print_time.
 974         (scoped_command_stats::print_time): New method.
 975
 976 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 977
 978         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 979         instructions of lengths 6 or 8 bytes.
 980
 981 2019-06-04  Pedro Alves  <palves@redhat.com>
 982
 983         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 984
 985         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 986         * breakpoint.c (condition_completer): Likewise.
 987         * cli/cli-dump.c (scan_expression): Likewise.
 988         * common/filestuff.c (mkdir_recursive): Likewise.
 989         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 990         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 991         (gdb_abspath): Likewise.
 992         * compile/compile-cplus-types.c
 993         (compile_cplus_instance::decl_name): Likewise.
 994         * completer.c (complete_explicit_location):
 995         (signal_completer, reg_or_group_completer_1): Likewise.
 996         * cp-support.c (cp_remove_params_if_any): Likewise.
 997         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 998         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 999         * infcmd.c (strip_bg_char): Likewise.
1000         * linespec.c (copy_token_string): Likewise.
1001         * mi/mi-main.c (output_cores): Likewise.
1002         * psymtab.c (psymtab_search_name):
1003         * symfile.c (test_set_ext_lang_command): Likewise.
1004         * target.c (target_fileio_read_stralloc): Likewise.
1005         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1006         * value.c (complete_internalvar): Likewise.
1007
1008 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1009
1010         Add objfile property to gdb.Type.
1011         * NEWS: Mention Python API addition.
1012         * python/py-type.c (typy_get_objfile): New method.
1013
1014 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1015
1016         * NEWS: Mention the new set|show style [title|highlight].
1017         Mention changes to "show style", "help" and "apropos".
1018
1019 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1020
1021         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1022         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1023         instead of print_help_for_command.
1024         (print_doc_of_command): New function.
1025         (help_list): Add 'apropos -v word' suggestion.
1026         (print_help_for_command): Style the command name using title style.
1027         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1028         (_initialize_cli_cmds): Describe -v in apropos_command help.
1029
1030 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1031
1032         * cli/cli-style.h (cli_style_option): Add name in constructor,
1033         add m_name class member, add constructor with intensity,
1034         add name class function.
1035         (cli_style_option::add_setshow_commands): Remove name argument.
1036         (highlight_style, title_style): New styles.
1037         * cli/cli-style.c (do_show): New function that shows a style
1038         characteristic styling the style name with itself.
1039         (set_style_name): New function.
1040         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1041         Update all callers according to the changes in cli/cli-style.h.
1042         * utils.h (fputs_highlighted): New function.
1043         * utils.c (fputs_highlighted): Likewise.
1044
1045 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1046
1047         * NEWS: Mention new pipe command and new convenience variables.
1048
1049 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1050
1051         * cli/cli-cmds.c (pipe_command): New function.
1052         (_initialize_cli_cmds): Call add_com for pipe_command.
1053         Define | as an alias for pipe.
1054         (exit_status_set_internal_vars): New function.
1055         (shell_escape): Call exit_status_set_internal_vars.
1056         cli/cli-decode.c (find_command_name_length): Recognize | as
1057         a single character command.
1058
1059 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1060
1061         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1062         top.c (execute_command_to_ui_file): New function, mostly a copy
1063         of execute_command_to_string.
1064         (execute_command_to_string): Implement by calling
1065         execute_command_to_ui_file.
1066
1067 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1068
1069         * top.h (saved_command_line): Remove declaration.
1070         * top.c (previous_saved_command_line, previous_repeat_arguments):
1071         New variables.
1072         (saved_command_line): Make static, define together with other
1073         'repeat variables'.
1074         (dont_repeat): Clear repeat_arguments.
1075         (repeat_previous, get_saved_command_line, save_command_line):
1076         New functions.
1077         (gdb_init): Initialize saved_command_line
1078         and previous_saved_command_line.
1079         * main.c (captured_main_1): Remove saved_command_line initialization.
1080         * event-top.c (handle_line_of_input): Update to use
1081         the new 'repeat' related functions instead of direct access to
1082         saved_command_line.
1083         * command.h (repeat_previous, get_saved_command_line,
1084         save_command_line): New declarations.
1085         (dont_repeat): Add comment.
1086
1087 2019-05-30  Tom Tromey  <tromey@adacore.com>
1088
1089         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1090         Fix comment.
1091         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1092
1093 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1094
1095         PR cli/24587
1096         * completer.c (complete): Initialize variable word.
1097
1098 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1099
1100         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1101         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1102         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1103         'body' is NULL to the outter 'if', protecting the '!is_define'
1104         situation as well.
1105
1106 2019-05-29  Tom Tromey  <tromey@adacore.com>
1107
1108         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1109         (dwarf_unknown): New function.
1110         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1111         (dwarf_type_encoding_name): Use dwarf_unknown.
1112
1113 2019-05-29  Tom Tromey  <tromey@adacore.com>
1114
1115         PR c++/20020:
1116         * cp-valprint.c (cp_print_value_fields): Call
1117         cp_print_static_field inside "try".
1118
1119 2019-05-29  Tom Tromey  <tromey@adacore.com>
1120
1121         * inflow.c (struct terminal_info): Add default operator=.
1122         * configure: Rebuild.
1123         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1124         -Wdeprecated-copy-dtor, -Wredundant-move.
1125
1126 2019-05-29  Tom Tromey  <tromey@adacore.com>
1127
1128         * NEWS: Add entry.
1129         * infcmd.c (print_return_value_1): Handle finish_print
1130         option.
1131         (show_print_finish): New function.
1132         (_initialize_infcmd): Add "set/show print finish" commands.
1133         * valprint.c (user_print_options): Initialize new member.
1134         * valprint.h (struct value_print_options) <finish_print>: New
1135         member.
1136
1137 2019-05-28  Tom Tromey  <tromey@adacore.com>
1138
1139         * ada-lang.c (ada_remove_Xbn_suffix)
1140         (find_old_style_renaming_symbol)
1141         (parse_old_style_renaming): Remove.
1142         (ada_find_renaming_symbol): Don't call
1143         find_old_style_renaming_symbol.
1144         (ada_is_renaming_symbol): Rename from
1145         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1146         bool.  Now static.
1147         (ada_read_var_value): Update and simplify.
1148         * ada-exp.y (write_var_or_type): Remove old code.
1149
1150 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1151
1152         * event-top.c: Remove include comment.
1153         * inflow.c (class scoped_ignore_sigttou): Move from here...
1154         * inflow.h (class scoped_ignore_sigttou): ...to here.
1155         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1156         * top.c:  Remove include comment.
1157
1158 2019-05-27  Tom Tromey  <tom@tromey.com>
1159
1160         * NEWS: Fix typo.
1161
1162 2019-05-22  Tom Tromey  <tromey@adacore.com>
1163
1164         * target.c (target_follow_exec): Constify parameter.
1165         * target-delegates.c: Rebuild.
1166         * remote.c (remote_target::follow_exec): Constify parameter.
1167         * infrun.c (follow_exec): Constify parameter.
1168         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1169         (target_follow_exec): Likewise.
1170
1171 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1172
1173         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1174         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1175
1176 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1177
1178         * NEWS: Add debugredirect and testsuite sections.
1179
1180 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1181
1182         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1183         target descriptions using exclusively floating point register name
1184         aliases.
1185
1186 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1187
1188         PR gdb/18644:
1189         * f-lang.c (build_fortran_types): Handle the case where
1190         gdbarch_floatformat_for_type returns a nullptr.
1191
1192 2019-05-21  Tom de Vries  <tdevries@suse.de>
1193
1194         PR cli/24587
1195         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1196
1197 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1198
1199         PR gdb/18644:
1200         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1201         16-byte floats.
1202         * i386-tdep.c (i386_floatformat_for_type): Use
1203         floatformats_ia64_quad for the 16-byte floating point component
1204         within a fortran 32-byte complex number.
1205
1206 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1207
1208         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1209         delete default constructor.
1210         (find_partial_die): Update to return const struct.
1211         (partial_die_parent_scope): Move variable declaration into scope
1212         of its use and change its type to auto.
1213         (guess_partial_die_structure_name): Likewise.
1214         (partial_die_info::fixup): Likewise.
1215
1216 2019-05-17  Tom Tromey  <tromey@adacore.com>
1217
1218         * source.c (find_and_open_source): Remove cast.
1219
1220 2019-05-17  Tom Tromey  <tromey@adacore.com>
1221
1222         * annotate.c (annotate_source): Make "filename" const.
1223         * annotate.h (annotate_source): Use const.
1224
1225 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1226
1227         * disasm.c (set_disassembler_options): Send errors to stderr.
1228
1229 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1230
1231         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1232         (cli_interp_base::set_logging): Check debug_redirect.
1233         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1234         * cli/cli-logging.c (debug_redirect): Add static variable.
1235         (pop_output_files): Add default param.
1236         (handle_redirections): Print debug setting.
1237         (show_logging_command): Likewise.
1238         (_initialize_cli_logging): Add debugredirect command.
1239         * interps.c (current_interp_set_logging): Add debug_redirect
1240         parameter.
1241         * interps.h (set_logging): Add debug_redirect parameter.
1242         (current_interp_set_logging): Likewise.
1243         * mi/mi-common.h: Likewise.
1244         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1245
1246 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1247             Tom Tromey  <tromey@adacore.com>
1248
1249         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1250         directly.
1251         * cli/cli-interp.h (make_logging_output): Remove declaration.
1252         * cli/cli-logging.c (make_logging_output): Remove function.
1253         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1254         directly.
1255         * ui-file.c (tee_file::tee_file): Remove bools.
1256         (tee_file::~tee_file): Remove deletes.
1257         * ui-file.h (tee_file): Remove bools.
1258
1259 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1260
1261         * mi/mi-cmds.h (mi_cmd_complete): New function.
1262         * mi/mi-main.c (mi_cmd_complete): Likewise.
1263         * mi/mi-cmds.c: Define new MI command -complete.
1264         * NEWS: Mention new -complete command.
1265
1266 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1267
1268         * completer.h (complete): New function.
1269         * completer.c (complete): Likewise.
1270         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1271         function defined in completer.h.
1272
1273 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1274
1275         * MAINTAINERS (Write After Approval): Add myself.
1276
1277 2019-05-17  Tom de Vries  <tdevries@suse.de>
1278
1279         PR gdb/24094
1280         * dwarf2read.c (struct cu_partial_die_info): New struct.
1281         (find_partial_die): Return cu_partial_die_info.
1282         (partial_die_parent_scope, guess_partial_die_structure_name)
1283         (partial_die_info::fixup): Handle new return type of find_partial_die.
1284
1285 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1286
1287         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1288         "std::string", simplifying the algorithm.
1289
1290 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1291
1292         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1293         (stap_static_probe_ops::get_probes): Likewise.
1294
1295 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1296
1297         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1298         '-')" and "else if".
1299         (stap_parse_single_operand): Join checks for
1300         "gdbarch_stap_parse_special_token_p" and
1301         "gdbarch_stap_parse_special_token" in the same "if" statement.
1302         Invert check when verifying for operation on register
1303         displacement.
1304
1305 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1306
1307         * stap-probe.c (stap_get_opcode): Update comment.
1308         (stap_get_expected_argument_type): Likewise.
1309         (handle_stap_probe): Likewise.
1310
1311 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1312
1313         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1314         return type to 'bool'.  Adjust comment.  Use 'bool' when
1315         appropriate.
1316         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1317         * stap-probe.c (stap_parse_argument_1): Likewise.
1318         (stap_is_operator): Likewise.
1319         (stap_is_generic_prefix): Likewise.
1320         (stap_is_register_prefix): Likewise.
1321         (stap_is_register_indirection_prefix): Likewise.
1322         (stap_is_integer_prefix): Likewise.
1323         (stap_generic_check_suffix): Likewise.
1324         (stap_check_integer_suffix): Likewise.
1325         (stap_check_register_suffix): Likewise.
1326         (stap_check_register_indirection_suffix): Likewise.
1327         (stap_parse_register_operand): Likewise.
1328         (stap_parse_single_operand): Likewise.
1329         (stap_parse_argument_1): Likewise.
1330         (stap_probe::get_argument_count): Likewise.
1331         (stap_is_operator): Likewise.
1332
1333 2019-05-16  Tom Tromey  <tromey@adacore.com>
1334
1335         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1336         keyword to foreach.
1337
1338 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1339
1340         * linux-thread-db.c (try_thread_db_load_1): Change return type
1341         to bool.
1342         (try_thread_db_load): Likewise.
1343         (try_thread_db_load_from_pdir_1): Likewise.
1344         (try_thread_db_load_from_pdir): Likewise.
1345         (try_thread_db_load_from_sdir): Likewise.
1346         (try_thread_db_load_from_dir): Likewise.
1347         (thread_db_load_search): Likewise.
1348         (has_libpthread): Likewise.
1349         (thread_db_load): Likewise.
1350
1351 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1352
1353         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1354         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1355         NULL, and complain/return if that's the case.
1356
1357 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1358
1359         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1360         (advance, posn, abstract_read_memory): New functions.
1361         [struct mem_read_abstraction]: New struct.
1362         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1363
1364 2019-05-14  Tom Tromey  <tromey@adacore.com>
1365
1366         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1367         value is not lval_memory.
1368
1369 2019-05-14  Tom Tromey  <tromey@adacore.com>
1370
1371         * solib.c (info_sharedlibrary_command): Style the file name.
1372
1373 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1374
1375         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1376         (aarch64_vnv_type): Likewise.
1377         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1378         * common/tdesc.c: Likewise.
1379         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1380         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1381         * features/aarch64-fpu.xml: Add ieee half view.
1382         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1383         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1384         * gdbtypes.h (struct builtin_type): Likewise.
1385         (struct objfile_type): Likewise.
1386
1387 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1388
1389         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1390         typo.
1391         * location.h (string_to_event_location): Likewise.
1392
1393 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1394
1395         GDB 8.3 released.
1396
1397 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1398
1399         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1400         New variable declaration.
1401         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1402         New variable.
1403         (print_one_breakpoint): Use ui_out::test_flags and new global
1404         variable to compute use_fixed_output.
1405         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1406         Remove.
1407         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1408         (mi_multi_location_breakpoint_output_fixed): Remove.
1409         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1410         new variable.
1411         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1412         fix_multi_location_breakpoint_output flag if version >= 3.
1413         * ui-out.h (enum ui_out_flag)
1414         <fix_multi_location_breakpoint_output>: New enumerator.
1415
1416 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1417
1418         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1419
1420 2019-05-10  Tom Tromey  <tromey@adacore.com>
1421
1422         * ada-lang.c (catch_ada_completer): New function.
1423         (_initialize_ada_language): Use it.
1424
1425 2019-05-10  Tom Tromey  <tromey@adacore.com>
1426
1427         * thread.c (print_thread_info): Make "requested_threads" const.
1428         * gdbthread.h (print_thread_info): Make "requested_threads"
1429         const.
1430         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1431         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1432
1433 2019-05-08  Tom Tromey  <tom@tromey.com>
1434
1435         * gdbtypes.c (objfile_type_data): Change type.
1436         (objfile_type, _initialize_gdbtypes): Update.
1437
1438 2019-05-08  Tom Tromey  <tom@tromey.com>
1439
1440         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1441         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1442         (_initialize_dwarf2_frame): Update.
1443
1444 2019-05-08  Tom Tromey  <tom@tromey.com>
1445
1446         * objc-lang.c (objc_objfile_data): Change type.
1447         (find_methods): Update.
1448         (_initialize_objc_lang): Remove.
1449
1450 2019-05-08  Tom Tromey  <tom@tromey.com>
1451
1452         * stabsread.c (rs6000_builtin_type_data): Change type.
1453         (rs6000_builtin_type, _initialize_stabsread): Update.
1454
1455 2019-05-08  Tom Tromey  <tom@tromey.com>
1456
1457         * mips-tdep.c (mips_pdr_data): Remove.
1458         (_initialize_mips_tdep): Update.
1459
1460 2019-05-08  Tom Tromey  <tom@tromey.com>
1461
1462         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1463         (hppa_init_objfile_priv_data, read_unwind_info)
1464         (find_unwind_entry, _initialize_hppa_tdep): Update.
1465
1466 2019-05-08  Tom Tromey  <tom@tromey.com>
1467
1468         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1469         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1470         on obstack.
1471         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1472
1473 2019-05-08  Tom Tromey  <tom@tromey.com>
1474
1475         * mdebugread.c (basic_type_data): Change type.
1476         (basic_type, _initialize_mdebugread): Update.
1477
1478 2019-05-08  Tom Tromey  <tom@tromey.com>
1479
1480         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1481
1482 2019-05-08  Tom Tromey  <tom@tromey.com>
1483
1484         * nto-tdep.c (nto_inferior_data_reg): Change type.
1485         (nto_inferior_data): Update.
1486         (nto_inferior_data_cleanup, nto_new_inferior_data)
1487         (_initialize_nto_tdep): Remove.
1488         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1489
1490 2019-05-08  Tom Tromey  <tom@tromey.com>
1491
1492         * ada-lang.c (struct ada_inferior_data): Add initializers.
1493         (ada_inferior_data): Change type.
1494         (ada_inferior_data_cleanup): Remove.
1495         (get_ada_inferior_data, ada_inferior_exit)
1496         (struct ada_pspace_data): Add initializers, destructor.
1497         (ada_pspace_data_handle): Change type.
1498         (get_ada_pspace_data): Update.
1499         (ada_pspace_data_cleanup): Remove.
1500
1501 2019-05-08  Tom Tromey  <tom@tromey.com>
1502
1503         * coffread.c (struct coff_symfile_info): Add initializers.
1504         (coff_objfile_data_key): Move lower.  Change type.
1505         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1506         Update.
1507         (coff_free_info): Remove.
1508
1509 2019-05-08  Tom Tromey  <tom@tromey.com>
1510
1511         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1512         (fbsd_pspace_data_handle): Move lower.  Change type.
1513         (get_fbsd_pspace_data): Update.
1514         (fbsd_pspace_data_cleanup): Remove.
1515         (_initialize_fbsd_tdep): Update.
1516
1517 2019-05-08  Tom Tromey  <tom@tromey.com>
1518
1519         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1520         (get_ada_tasks_pspace_data): Update.
1521         (ada_tasks_pspace_data_cleanup): Remove.
1522         (_initialize_tasks): Update.
1523         (ada_tasks_inferior_data_handle): Change type.
1524         (get_ada_tasks_inferior_data): Update.
1525         (ada_tasks_inferior_data_cleanup): Remove.
1526         (struct ada_tasks_pspace_data): Add initializers.
1527
1528 2019-05-08  Tom Tromey  <tom@tromey.com>
1529
1530         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1531         * symfile-debug.c (debug_sym_get_probes): Change type.
1532         * stap-probe.c (handle_stap_probe):
1533         (stap_static_probe_ops::get_probes): Change type.
1534         * probe.h (class static_probe_ops) <get_probes>: Change type.
1535         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1536         (parse_probes_in_pspace): Update.
1537         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1538         Update.
1539         (any_static_probe_ops::get_probes): Change type.
1540         * elfread.c (elfread_data): New typedef.
1541         (probe_key): Change type.
1542         (elf_get_probes): Likewise.  Update.
1543         (probe_key_free): Remove.
1544         (_initialize_elfread): Update.
1545         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1546         Change type.
1547         (dtrace_process_dof_probe, dtrace_process_dof)
1548         (dtrace_static_probe_ops::get_probe): Change type.
1549
1550 2019-05-08  Tom Tromey  <tom@tromey.com>
1551
1552         * xcoffread.c (struct xcoff_symfile_info): Rename from
1553         coff_symfile_info.  Add initializers.
1554         (xcoff_objfile_data_key): Move lower.  Change type.
1555         (XCOFF_DATA): Rewrite.
1556         (xcoff_free_info): Remove.
1557         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1558         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1559         (xcoff_initial_scan): Update.
1560
1561 2019-05-08  Tom Tromey  <tom@tromey.com>
1562
1563         * solib-svr4.c (struct svr4_info): Add initializers and
1564         destructor.
1565         <probes_table>: Now an htab_up.
1566         (solib_svr4_pspace_data): Change type.
1567         (free_probes_table): Simplify.
1568         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1569         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1570         (probes_table_remove_objfile_probes, register_solib_event_probe)
1571         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1572         (_initialize_svr4_solib): Update.
1573
1574 2019-05-08  Tom Tromey  <tom@tromey.com>
1575
1576         * remote.c (remote_pspace_data): Change type.
1577         (remote_pspace_data_cleanup): Remove.
1578         (get_remote_exec_file, set_pspace_remote_exec_file)
1579         (_initialize_remote): Update.
1580
1581 2019-05-08  Tom Tromey  <tom@tromey.com>
1582
1583         * breakpoint.c (breakpoint_objfile_key): Change type.
1584         (get_breakpoint_objfile_data): Update.
1585         (free_breakpoint_objfile_data): Remove.
1586         (_initialize_breakpoint): Update.
1587
1588 2019-05-08  Tom Tromey  <tom@tromey.com>
1589
1590         * linux-tdep.c (struct linux_info): Add initializers.
1591         (linux_inferior_data): Move.  Change type.
1592         (invalidate_linux_cache_inf): Update.
1593         (linux_inferior_data_cleanup): Remove.
1594         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1595
1596 2019-05-08  Tom Tromey  <tom@tromey.com>
1597
1598         * auxv.c (auxv_inferior_data): Move.  Change type.
1599         (auxv_inferior_data_cleanup): Remove.
1600         (invalidate_auxv_cache_inf): Rewrite.
1601         (get_auxv_inferior_data, _initialize_auxv): Update.
1602
1603 2019-05-08  Tom Tromey  <tom@tromey.com>
1604
1605         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1606         (symfile_debug_objfile_data_key): Change type.
1607         (symfile_debug_installed, debug_qf_has_symbols)
1608         (debug_qf_find_last_source_symtab)
1609         (debug_qf_forget_cached_source_info)
1610         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1611         (debug_qf_print_stats, debug_qf_dump)
1612         (debug_qf_expand_symtabs_for_function)
1613         (debug_qf_expand_all_symtabs)
1614         (debug_qf_expand_symtabs_with_fullname)
1615         (debug_qf_map_matching_symbols)
1616         (debug_qf_expand_symtabs_matching)
1617         (debug_qf_find_pc_sect_compunit_symtab)
1618         (debug_qf_map_symbol_filenames)
1619         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1620         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1621         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1622         (debug_sym_read_linetable, debug_sym_relocate): Update.
1623         (symfile_debug_free_objfile): Remove.
1624         (install_symfile_debug_logging, _initialize_symfile_debug):
1625         Update.
1626
1627 2019-05-08  Tom Tromey  <tom@tromey.com>
1628
1629         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1630         allocate_on_obstack.
1631         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1632         (get_dwarf2_per_objfile): Update.
1633         (set_dwarf2_per_objfile): Remove.
1634         (dwarf2_has_info, dwarf2_get_section_info): Update.
1635         (dwarf2_free_objfile): Remove.
1636         (_initialize_dwarf2_read): Update.
1637
1638 2019-05-08  Tom Tromey  <tom@tromey.com>
1639
1640         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1641         initializers.
1642         <unsupported_script_warning_printed,
1643         script_not_found_warning_printed>: Now bool.
1644         (auto_load_pspace_data): Change type.
1645         (~auto_load_pspace_info): Rename from
1646         auto_load_pspace_data_cleanup.
1647         (get_auto_load_pspace_data, init_loaded_scripts_info)
1648         (clear_section_scripts, maybe_print_unsupported_script_warning)
1649         (maybe_print_script_not_found_warning, _initialize_auto_load):
1650         Update.
1651
1652 2019-05-08  Tom Tromey  <tom@tromey.com>
1653
1654         * objfiles.c (objfile_pspace_info): Add destructor and
1655         initializers.
1656         (objfiles_pspace_data): Change type.
1657         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1658         (get_objfile_pspace_data): Update.
1659         (objfiles_bfd_data): Change type.
1660         (get_objfile_bfd_data): Update.
1661         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1662
1663 2019-05-08  Tom Tromey  <tom@tromey.com>
1664
1665         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1666         Change type.
1667         (get_catch_syscall_inferior_data): Update.
1668         (catch_syscall_inferior_data_cleanup): Remove.
1669         (_initialize_break_catch_syscall): Update.
1670
1671 2019-05-08  Tom Tromey  <tom@tromey.com>
1672
1673         * inflow.c (struct terminal_info): Add destructor and
1674         initializers.
1675         (inflow_inferior_data): Change type.
1676         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1677         (get_inflow_inferior_data, inflow_inferior_exit)
1678         (swap_terminal_info, _initialize_inflow): Update.
1679
1680 2019-05-08  Tom Tromey  <tom@tromey.com>
1681
1682         * target-dcache.c (target_dcache_cleanup): Remove.
1683         (target_dcache_aspace_key): Change type.
1684         (target_dcache_init_p, target_dcache_invalidate)
1685         (target_dcache_get, target_dcache_get_or_init)
1686         (_initialize_target_dcache): Update.
1687         * dcache.h (struct dcache_deleter): New.
1688
1689 2019-05-08  Tom Tromey  <tom@tromey.com>
1690
1691         * symtab.c (struct symbol_cache): Add destructor and
1692         initializers.
1693         (symbol_cache_key): Move.  Change type.
1694         (make_symbol_cache, free_symbol_cache): Remove.
1695         (get_symbol_cache): Update.
1696         (symbol_cache_cleanup): Remove.
1697         (ALL_PSPACES, symbol_cache_flush)
1698         (maintenance_print_symbol_cache)
1699         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1700         Update.
1701
1702 2019-05-08  Tom Tromey  <tom@tromey.com>
1703
1704         * symtab.c (struct main_info): Add destructor and initializers.
1705         (main_progspace_key): Move.  Change type.
1706         (get_main_info): Update.
1707         (main_info_cleanup): Remove.
1708         (_initialize_symtab): Update.
1709
1710 2019-05-08  Tom Tromey  <tom@tromey.com>
1711
1712         * registry.h (DECLARE_REGISTRY): Define the _key class.
1713
1714 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1715
1716         * NEWS: Merge two 'New commands' sections.
1717
1718 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1719
1720         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1721         parameter and use Ada language definition instead.
1722         (ada_val_print_ptr): Remove unused language parameter.
1723         (ada_val_print_num): Remove language parameter and use Ada language
1724         definition instead.
1725         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1726         parameter.
1727         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1728         parameter and use Ada language definition instead.
1729         (ada_val_print_1): Update all ada_val_print_xxx calls.
1730         Remove language parameter.
1731         (ada_val_print): Update ada_val_print_1 call.
1732
1733 2019-05-08  Tom Tromey  <tromey@adacore.com>
1734
1735         * remote.c (remote_hw_watchpoint_limit)
1736         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1737         Now static.
1738
1739 2019-05-08  Tom Tromey  <tromey@adacore.com>
1740
1741         * maint.c (_initialize_maint_cmds): Move initialization code to
1742         remote.c.
1743         (watchdog, show_watchdog): Move to remote.c.
1744         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1745         "watchdog" static.
1746         (_initialize_remote): Move initialization code from maint.c.
1747         * defs.h (watchdog): Don't declare.
1748
1749 2019-05-08  Tom Tromey  <tromey@adacore.com>
1750
1751         * tui/tui-interp.c: Include main.h.
1752         * interps.c: Include main.h.
1753         * main.h (interpreter_p): Declare.
1754         * defs.h (interpreter_p): Don't declare.
1755
1756 2019-05-08  Tom Tromey  <tromey@adacore.com>
1757
1758         * dwarf2loc.c: Include dwarf2read.h.
1759         * defs.h (read_unsigned_leb128): Don't declare.
1760         * dwarf2read.h (read_unsigned_leb128): Declare.
1761
1762 2019-05-08  Tom Tromey  <tromey@adacore.com>
1763
1764         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1765         method.
1766
1767 2019-05-08  Tom Tromey  <tromey@adacore.com>
1768
1769         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1770         when no wrap column is set.
1771
1772 2019-05-08  Tom Tromey  <tromey@adacore.com>
1773
1774         * c-lang.c (c_get_string): Handle non-C-style arrays.
1775
1776 2019-05-08  Tom Tromey  <tromey@adacore.com>
1777
1778         * typeprint.c (print_offset_data::update): Print the bit offset,
1779         not the number of bits remaining.
1780
1781 2019-05-08  Tom Tromey  <tromey@adacore.com>
1782
1783         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1784         padding at end of comment.
1785
1786 2019-05-08  Tom Tromey  <tromey@adacore.com>
1787
1788         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1789         Compare main types.
1790
1791 2019-05-06  Tom Tromey  <tom@tromey.com>
1792
1793         * common/scoped_mmap.c: Include common-defs.h.
1794         * common/scoped_mmap.h: Don't include config.h.
1795
1796 2019-05-04  Tom Tromey  <tom@tromey.com>
1797
1798         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1799         (struct aarch64_call_info): Add initializers.
1800         <si>: Now a std::vector.
1801         (pass_on_stack, aarch64_push_dummy_call): Update.
1802
1803 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1804             Tom Tromey  <tom@tromey.com>
1805
1806         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1807         (ppc_threads): Now a std::vector.  Now static.
1808         (hwdebug_find_thread_points_by_tid)
1809         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1810         Update.
1811
1812 2019-05-04  Tom Tromey  <tom@tromey.com>
1813
1814         * arc-tdep.c (arc_tdesc_init): Return bool.
1815
1816 2019-05-04  Tom Tromey  <tom@tromey.com>
1817
1818         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1819         Use gdb_assert_not_reached.
1820
1821 2019-05-04  Tom Tromey  <tom@tromey.com>
1822
1823         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1824         "false".
1825
1826 2019-05-04  Tom Tromey  <tom@tromey.com>
1827
1828         * arc-tdep.c (arc_tdesc_init): Use bool.
1829
1830 2019-05-04  Tom Tromey  <tom@tromey.com>
1831
1832         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1833
1834 2019-05-04  Tom Tromey  <tom@tromey.com>
1835
1836         * cli/cli-cmds.c (valid_command_p): Return bool.
1837
1838 2019-05-04  Tom Tromey  <tom@tromey.com>
1839
1840         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1841         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1842
1843 2019-05-04  Raul Tambre  <raul@tambre.ee>
1844
1845         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1846         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1847         operator for comparison.
1848
1849 2019-05-04  Tom Tromey  <tom@tromey.com>
1850
1851         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1852         (lookup_partial_symbol, print_partial_symbols)
1853         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1854         (psymbol_compare): Update.
1855         (add_psymbol_to_bcache): Clear the entire psymbol.
1856         (maintenance_check_psymtabs): Update.
1857         * psympriv.h (struct partial_symbol): Don't derive from
1858         general_symbol_info.
1859         <obj_section, unrelocated_address, address,
1860         set_unrelocated_address>: Update.
1861         <ginfo>: New member.
1862         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1863         (debug_names::write_psymbols): Update.
1864
1865 2019-05-04  Tom de Vries  <tdevries@suse.de>
1866
1867         * contrib/cc-with-tweaks.sh: Support -n arg.
1868
1869 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1870
1871         * corelow.c (core_target::detach): Ensure frame cache and
1872         register caches are cleared.
1873         inferior.c (exit_inferior_1): Likewise.
1874
1875 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1876             Tom Tromey  <tom@tromey.com>
1877
1878         * dictionary.c (collate_pending_symbols_by_language): Remove
1879         "struct" from foreach.
1880         * symtab.c (lookup_global_symbol_from_objfile)
1881         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1882         foreach.
1883         * ser-tcp.c (net_open): Remove "struct" from foreach.
1884         * objfiles.c (objfile_relocate, objfile_rebase)
1885         (objfile_has_symbols): Remove "struct" from foreach.
1886         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1887         from foreach.
1888         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1889         foreach.
1890         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1891         "struct" from foreach.
1892         * ada-lang.c (create_excep_cond_exprs)
1893         (ada_exception_catchpoint_cond_string): Remove "struct" from
1894         foreach.
1895
1896 2019-05-03  Tom Tromey  <tromey@adacore.com>
1897
1898         * ada-exp.y (convert_char_literal): Check suffix of each
1899         enumerator.
1900
1901 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1902
1903         PR ada/21406:
1904         * ada-exp.y (yywrap): Don't define.
1905         * ada-lex.l (%option): Add noyywrap
1906         (yywrap): Remove.
1907
1908 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1909
1910         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1911         _WIN32_WINNT to the XP level, unless already defined to a higher
1912         level.
1913
1914         * unittests/parse-connection-spec-selftests.c:
1915         * ser-tcp.c:
1916         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1917         override.
1918
1919         * symfile.c (find_separate_debug_file): Remove colon from the
1920         drive spec of DOS/Windows file names of the target, so that the
1921         file name produced from DEBUGDIR and the target's directory will
1922         be valid on DOS/Windows systems.
1923
1924 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1925
1926         * rust-lang.c (val_print_struct): Handle printing structures
1927         containing strings.
1928
1929 2019-05-02  Tom Tromey  <tromey@adacore.com>
1930
1931         * valarith.c (_initialize_valarith): Remove.
1932
1933 2019-05-01  Tom Tromey  <tromey@adacore.com>
1934
1935         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1936         bitfields.
1937
1938 2019-05-01  Tom Tromey  <tromey@adacore.com>
1939
1940         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1941         for big-endian copies.
1942
1943 2019-04-30  Ali Tamur  <tamur@google.com>
1944         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1945         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1946         (read_3_bytes): New function.
1947
1948 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1949
1950         * windows-nat.c (main_thread_id): Delete.
1951         (handle_output_debug_string): Replace main_thread_id by
1952         current_event.dwThreadId.
1953         (fake_create_process): Likewise.
1954         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1955         Do not set main_thread_id.
1956         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1957         current_event.dwThreadId.
1958         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1959
1960 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1961
1962         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1963         Use current_event.dwThreadId instead of main_thread_id.
1964
1965 2019-04-30  Tom Tromey  <tromey@adacore.com>
1966
1967         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1968         (create_excep_cond_exprs): Iterate over program spaces.
1969         (ada_exception_catchpoint_cond_string): Examine all minimal
1970         symbols for exception types.
1971
1972 2019-04-30  Tom Tromey  <tromey@adacore.com>
1973
1974         PR c++/24470:
1975         * dwarf2read.c (process_structure_scope): Handle case where type
1976         has template parameters but no symbol was created.
1977
1978 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1979             Chris January  <chris.january@arm.com>
1980
1981         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1982         qualifier.
1983         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1984
1985 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1986
1987         * f-typeprint.c (f_print_type): Update rules for printing
1988         whitespace.
1989         (f_type_print_varspec_suffix): Likewise.
1990
1991 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1992             Chris January  <chris.january@arm.com>
1993
1994         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1995         function arguments.
1996
1997 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1998
1999         * f-lang.c (build_fortran_types): Change name of void type to
2000         lower case.
2001         * f-typeprint.c (f_type_print_base): Print the name of the void
2002         type, rather than a fixed string.
2003         * f-valprint.c (f_decorations): Use lower case void string.
2004
2005 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2006             Chris January  <chris.january@arm.com>
2007
2008         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2009         types for Fortran.
2010
2011 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2012             Chris January  <chris.january@arm.com>
2013             David Lecomber  <david.lecomber@arm.com>
2014
2015         * f-exp.y (BINOP_INTRINSIC): New token.
2016         (exp): New parser rule handling BINOP_INTRINSIC.
2017         (f77_keywords): Add new builtin procedures.
2018         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2019         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2020         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2021         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2022         (print_unop_subexp_f): New function.
2023         (print_binop_subexp_f): New function.
2024         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2025         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2026         (dump_subexp_body_f): Likewise.
2027         (operator_check_f): Likewise.
2028         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2029         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2030
2031 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2032
2033         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2034         UNOP_KIND.
2035         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2036         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2037         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2038         (operator_length_f): New fuction.
2039         (print_subexp_f): New function.
2040         (op_name_f): New function.
2041         (dump_subexp_body_f): New function.
2042         (operator_check_f): New function.
2043         (exp_descriptor_f): Replace standard expression handling functions
2044         with new functions.
2045         * gdb/fortran-operator.def: New file.
2046         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2047         * gdb/std-operator.def: Remove UNOP_KIND.
2048
2049 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2050
2051         * std-operator.def: Remove unbalanced, stray double quote
2052         character.
2053
2054 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2055             Chris January  <chris.january@arm.com>
2056             Daniel Everett  <daniel.everett@arm.com>
2057             Nick Forrington  <nick.forrington@arm.com>
2058             Richard Bunt  <richard.bunt@arm.com>
2059
2060         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2061         of depth when printing anonymous structs or unions.
2062         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2063         Don't print either the top-level value, or the children if the
2064         max-depth is exceeded.
2065         (ppscm_print_children): When printing the key of a map, allow one
2066         extra level of depth.
2067         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2068         print either the top-level value, or the children if the max-depth
2069         is exceeded.
2070         (print_children): When printing the key of a map, allow one extra
2071         level of depth.
2072         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2073         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2074         (user_print_options): Initialise max_depth field.
2075         (val_print_scalar_or_string_type_p): New function.
2076         (val_print): Check to see if the max depth has been reached.
2077         (val_print_check_max_depth): Define new function.
2078         (show_print_max_depth): New function.
2079         (_initialize_valprint): Add 'print max-depth' option.
2080         * valprint.h (struct value_print_options) <max_depth>: New field.
2081         (val_print_check_max_depth): Declare new function.
2082         * NEWS: Document new feature.
2083
2084 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2085
2086         * ada-lang.c (ada_language_defn): Initialise new field.
2087         * c-lang.c (c_is_string_type_p): New function.
2088         (c_language_defn): Initialise new field.
2089         (cplus_language_defn): Initialise new field.
2090         (asm_language_defn): Initialise new field.
2091         (minimal_language_defn): Initialise new field.
2092         * c-lang.h (c_is_string_type_p): Declare new function.
2093         * d-lang.c (d_language_defn): Initialise new field.
2094         * f-lang.c (f_is_string_type_p): New function.
2095         (f_language_defn): Initialise new field.
2096         * go-lang.c (go_is_string_type_p): New function.
2097         (go_language_defn): Initialise new field.
2098         * language.c (default_is_string_type_p): New function.
2099         (unknown_language_defn): Initialise new field.
2100         (auto_language_defn): Initialise new field.
2101         * language.h (struct language_defn) <la_is_string_type_p>: New
2102         member variable.
2103         (default_is_string_type_p): Declare new function.
2104         * m2-lang.c (m2_language_defn): Initialise new field.
2105         * objc-lang.c (objc_language_defn): Initialise new field.
2106         * opencl-lang.c (opencl_language_defn): Initialise new field.
2107         * p-lang.c (pascal_is_string_type_p): New function.
2108         (pascal_language_defn): Initialise new field.
2109         * rust-lang.c (rust_is_string_type_p): New function.
2110         (rust_language_defn): Initialise new field.
2111
2112 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2113
2114         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2115         New field.
2116         * ada-lang.c (ada_language_defn): Initialise new field.
2117         * c-lang.c (c_language_defn): Likewise.
2118         (cplus_language_defn): Likewise.
2119         (asm_language_defn): Likewise.
2120         (minimal_language_defn): Likewise.
2121         * d-lang.c (d_language_defn): Likewise.
2122         * f-lang.c (f_language_defn): Likewise.
2123         * go-lang.c (go_language_defn): Likewise.
2124         * language.c (unknown_language_defn): Likewise.
2125         (auto_language_defn): Likewise.
2126         * m2-lang.c (m2_language_defn): Likewise.
2127         * objc-lang.c (objc_language_defn): Likewise.
2128         * opencl-lang.c (opencl_language_defn): Likewise.
2129         * p-lang.c (pascal_language_defn): Likewise.
2130         * rust-lang.c (rust_language_defn): Likewise.
2131
2132 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2133
2134         * ada-lang.c (ada_is_character_type): Change return type to bool.
2135         (ada_is_string_type): Likewise.
2136         * ada-lang.h (ada_is_character_type): Update declaration
2137         (ada_is_string_type): Likewise.
2138
2139 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2140
2141         Support style in 'frame|thread apply'
2142
2143         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2144         * record.c (record_start, record_stop): Update callers of
2145         execute_command_to_string with false.
2146         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2147         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2148         methods.
2149         (class string_file): New constructor with term_out parameter.
2150         Override methods term_out and can_emit_style_escape.  New member
2151         term_out.
2152         (class stdio_file): Override can_emit_style_escape.
2153         (class tee_file): Override term_out and can_emit_style_escape.
2154         * utils.h (can_emit_style_escape): Remove.
2155         * utils.c (can_emit_style_escape): Likewise.
2156         Update all callers of can_emit_style_escape (SOMESTREAM) to
2157         SOMESTREAM->can_emit_style_escape.
2158         * source-cache.c (source_cache::get_source_lines): Likewise.
2159         * stack.c (frame_apply_command_count): Call execute_command_to_string
2160         passing the term_out characteristic of the current gdb_stdout.
2161         * thread.c (thr_try_catch_cmd): Likewise.
2162         * top.c (execute_command_to_string): pass term_out parameter
2163         to construct the string_file for the command output.
2164         * ui-file.c (term_cli_styling): New function (most code moved
2165         from utils.c can_emit_style_escape).
2166         (string_file::string_file, string_file::can_emit_style_escape,
2167         stdio_file::can_emit_style_escape, tee_file::term_out,
2168         tee_file::can_emit_style_escape): New functions.
2169
2170 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2171
2172         * NEWS: Mention the new set|show may-call-functions.
2173         * infcall.c (may_call_functions_p): New variable.
2174         (show_may_call_functions_p): New function.
2175         (call_function_by_hand_dummy): Throws an error if not
2176         may-call-functions.
2177         (_initialize_infcall): Call add_setshow_boolean_cmd for
2178         may-call-functions.
2179
2180 2019-04-25  Keith Seitz  <keiths@redhat.com>
2181
2182         PR c++/24367
2183         * cp-support.c (inspect_type): Don't attempt substitutions
2184         of symbol with the same name.
2185
2186 2019-04-25  Tom Tromey  <tromey@adacore.com>
2187
2188         PR gdb/24475:
2189         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2190         static.
2191
2192 2019-04-25  Tom Tromey  <tromey@adacore.com>
2193
2194         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2195         rvalue reference.
2196         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2197         (gdb_xml_parser::parse): Use std::move.
2198         * python/python-internal.h (gdbpy_convert_exception): Take a const
2199         reference.
2200         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2201         std::move.
2202         * python/py-utils.c (gdbpy_convert_exception): Take a const
2203         reference.
2204         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2205         Use std::move.
2206         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2207         Use std::move.
2208         * mi/mi-main.c (mi_print_exception): Take a const reference.
2209         * main.c (handle_command_errors): Take a const reference.
2210         * linespec.c (parse_linespec): Use std::move.
2211         * infcall.c (run_inferior_call): Use std::move.
2212         (call_function_by_hand_dummy): Use std::move.
2213         * exec.c (try_open_exec_file): Use std::move.
2214         * exceptions.h (exception_print, exception_fprintf)
2215         (exception_print_same): Update.
2216         * exceptions.c (print_exception, exception_print)
2217         (exception_fprintf, exception_print_same): Change parameters to
2218         const reference.
2219         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2220         * common/new-op.c: Use std::move.
2221         * common/common-exceptions.h (struct gdb_exception): Add move
2222         constructor.
2223         (struct gdb_exception_error, struct gdb_exception_quit, struct
2224         gdb_quit_bad_alloc): Change constructor to move constructor.
2225         (throw_exception): Change parameter to rvalue reference.
2226         * common/common-exceptions.c (throw_exception): Take rvalue
2227         reference.
2228         * cli/cli-interp.c (safe_execute_command): Use std::move.
2229         * breakpoint.c (insert_bp_location, location_to_sals): Use
2230         std::move.
2231
2232 2019-04-25  Tom Tromey  <tromey@adacore.com>
2233
2234         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2235         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2236         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2237         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2238         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2239         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2240         guile/scm-value.c: Use unpack.
2241         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2242         gdbscm_gdb_exception.
2243         (gdbscm_throw_gdb_exception): Likewise.
2244         (struct gdbscm_gdb_exception): New.
2245         (unpack): New function.
2246         (gdbscm_wrap): Use unpack.
2247
2248 2019-04-25  Tom Tromey  <tromey@adacore.com>
2249
2250         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2251         (gdb_rl_callback_handler): Use std::move.
2252         * common/common-exceptions.h (struct gdb_exception): Add move
2253         assignment operator.
2254         (throw_exception_sjlj): Change "exception" to const reference.
2255         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2256         (throw_exception_sjlj): Change "exception" to const reference.
2257
2258 2019-04-25  Tom Tromey  <tromey@adacore.com>
2259
2260         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2261         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2262         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2263         Update.
2264         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2265         Update.
2266         * mi/mi-interp.c (mi_interp::exec): Update.
2267         * linespec.c (parse_linespec): Update.
2268         * infcall.c (run_inferior_call): Update.
2269         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2270         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2271         (gdbscm_lookup_global_symbol): Update.
2272         * guile/scm-param.c (gdbscm_parameter_value): Update.
2273         * guile/scm-frame.c (gdbscm_frame_read_register)
2274         (gdbscm_frame_read_var): Update.
2275         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2276         * exec.c (try_open_exec_file): Update.
2277         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2278         (gdb_rl_callback_handler): Update.
2279         * common/common-exceptions.h (exception_none): Don't declare.
2280         * common/common-exceptions.c (exception_none): Don't define.
2281         (struct catcher) <exception>: Update.
2282         * cli/cli-interp.c (safe_execute_command): Update.
2283         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2284
2285 2019-04-25  Ali Tamur  <tamur@google.com>
2286
2287         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2288         (read_attribute_value): Likewise.
2289         (dwarf2_read_addr_index): Update comment.
2290         (read_str_index): Add DW_FORM_strx.
2291         (dwarf2_string_attr): Likewise.
2292         (dwarf2_const_value_attr): Likewise.
2293         (dump_die_shallow): Likewise.
2294         (dwarf2_fetch_constant_bytes): Likewise.
2295         (skip_form_bytes): Likewise.
2296         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2297
2298 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2299
2300         PR corefiles/11608
2301         PR corefiles/18187
2302         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2303         OFFSET.  Verify if current mapping contains an ELF header.
2304         (linux_find_memory_regions_full): Adjust call to
2305         dump_mapping_p.
2306
2307 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2308             Kang Li <kanglictf@gmail.com>
2309
2310         PR gdb/21600
2311
2312         * dwarf2-frame.c (read_initial_length): Be consistent about using
2313         unsigned representation of length.
2314         (decode_frame_entry_1): Likewise.  Check for wraparound of
2315         end pointer as well as buffer overflow.
2316
2317 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2318
2319         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2320         "vq".
2321
2322 2019-04-24  Tom Tromey  <tromey@adacore.com>
2323
2324         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2325
2326 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2327
2328         * s12z-tdep.c (s12z_unwind_pc): Delete.
2329         (s12z_unwind_sp): Delete.
2330         (s12z_gdbarch_init): Don't register deleted functions with
2331         gdbarch.
2332
2333 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2334
2335         * rl78-tdep.c (rl78_unwind_sp): Delete.
2336         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2337
2338 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2339
2340         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2341         (xstormy16_unwind_pc): Delete.
2342         (xstormy16_dummy_id): Delete.
2343         (xstormy16_gdbarch_init): Don't register deleted functions with
2344         gdbarch.
2345
2346 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2347
2348         * vax-tdep.c (vax_unwind_pc): Delete.
2349         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2350
2351 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2352
2353         * v850-tdep.c (v850_unwind_sp): Delete.
2354         (v850_unwind_pc): Delete.
2355         (v850_dummy_id): Delete.
2356         (v850_gdbarch_init): Don't register deleted functions with
2357         gdbarch.
2358
2359 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2360
2361         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2362         (tilegx_unwind_pc): Delete.
2363         (tilegx_unwind_dummy_id): Delete.
2364         (tilegx_gdbarch_init): Don't register deleted functions with
2365         gdbarch.
2366
2367 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2368
2369         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2370         (tic6x_dummy_id): Delete.
2371         (tic6x_gdbarch_init): Don't register deleted functions with
2372         gdbarch.
2373
2374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2375
2376         * sparc-tdep.c (sparc_unwind_pc): Delete.
2377         (sparc32_gdbarch_init): Don't register deleted function with
2378         gdbarch.
2379
2380 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2381
2382         * sh-tdep.c (sh_unwind_sp): Delete.
2383         (sh_unwind_pc): Delete.
2384         (sh_dummy_id): Delete.
2385         (sh_gdbarch_init): Don't register deleted functions with
2386         gdbarch.
2387
2388 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2389
2390         * score-tdep.c (score_unwind_sp): Delete.
2391         (score_unwind_pc): Delete.
2392         (score_dummy_id): Delete.
2393         (score_gdbarch_init): Don't register deleted functions with
2394         gdbarch.
2395
2396 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2397
2398         * rx-tdep.c (rx_unwind_pc): Delete.
2399         (rx_unwind_sp): Delete.
2400         (rx_dummy_id): Delete.
2401         (rx_gdbarch_init): Don't register deleted functions with
2402         gdbarch.  Update comment.
2403
2404 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2405
2406         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2407         (rs6000_dummy_id): Delete.
2408         (rs6000_gdbarch_init): Don't register deleted functions with
2409         gdbarch.
2410
2411 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2412
2413         * or1k-tdep.c (or1k_dummy_id): Delete.
2414         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2415
2416 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2417
2418         * nios2-tdep.c (nios2_dummy_id): Delete.
2419         (nios2_unwind_sp): Delete.
2420         (nios2_gdbarch_init): Don't register deleted functions with
2421         gdbarch.
2422
2423 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2424
2425         * nds32-tdep.c (nds32_dummy_id): Delete.
2426         (nds32_unwind_pc): Delete.
2427         (nds32_unwind_sp): Delete.
2428         (nds32_gdbarch_init): Don't register deleted functions with
2429         gdbarch.
2430
2431 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2432
2433         * msp430-tdep.c (msp430_unwind_pc): Delete.
2434         (msp430_unwind_sp): Delete.
2435         (msp430_dummy_id): Delete.
2436         (msp430_gdbarch_init): Don't register deleted functions with
2437         gdbarch.
2438
2439 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2440
2441         * moxie-tdep.c (moxie_unwind_sp): Delete.
2442         (moxie_unwind_pc): Delete.
2443         (moxie_dummy_id): Delete.
2444         (moxie_gdbarch_init): Don't register deleted functions with
2445         gdbarch.
2446
2447 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2448
2449         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2450         (mn10300_unwind_pc): Delete.
2451         (mn10300_unwind_sp): Delete.
2452         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2453         mn10300_unwind_sp.
2454         (mn10300_frame_unwind_init): Don't register deleted functions with
2455         gdbarch.
2456
2457 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2458
2459         * mep-tdep.c (mep_unwind_pc): Delete.
2460         (mep_unwind_sp): Delete.
2461         (mep_dummy_id): Delete.
2462         (mep_gdbarch_init): Don't register deleted functions with
2463         gdbarch.
2464
2465 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2466
2467         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2468         (m68hc11_unwind_sp): Delete.
2469         (m68hc11_gdbarch_init): Don't register deleted functions with
2470         gdbarch.
2471
2472 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2473
2474         * m32r-tdep.c (m32r_unwind_sp): Delete.
2475         (m32r_unwind_pc): Delete.
2476         (m32r_dummy_id): Delete.
2477         (m32r_gdbarch_init): Don't register deleted functions with
2478         gdbarch.
2479
2480 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2481
2482         * m32c-tdep.c (m32c_unwind_pc): Delete.
2483         (m32c_unwind_sp): Delete.
2484         (m32c_dummy_id): Delete.
2485         (m32c_gdbarch_init): Don't register deleted functions with
2486         gdbarch.
2487
2488 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2489
2490         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2491         (lm32_unwind_pc): Delete.
2492         (lm32_dummy_id): Delete.
2493         (lm32_gdbarch_init): Don't register deleted functions with
2494         gdbarch.
2495
2496 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2497
2498         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2499         (iq2000_unwind_pc): Delete.
2500         (iq2000_dummy_id): Delete.
2501         (iq2000_gdbarch_init): Don't register deleted functions with
2502         gdbarch.
2503
2504 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2505
2506         * nds32-tdep.c (nds32_type_align): Delete.
2507         (nds32_push_dummy_call): Use type_align instead.
2508
2509 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2510
2511         * arm-tdep.c (arm_type_align): Only handle vector override case.
2512         (arm_push_dummy_call): Use type_align.
2513         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2514
2515 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2516
2517         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2518         case.
2519         (pass_on_stack): Use type_align.
2520         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2521         function.
2522
2523 2019-04-23  Tom Tromey  <tromey@adacore.com>
2524
2525         * dwarf2read.c (line_header::file_name_at): Remove unused
2526         overload.
2527
2528 2019-04-23  Tom de Vries  <tdevries@suse.de>
2529
2530         PR gdb/24438
2531         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2532         invocation.
2533
2534
2535 2019-03-27  Ali Tamur  <tamur@google.com>
2536
2537         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2538         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2539         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2540         (dwarf_expr_context::get_addr_index): Likewise
2541         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2542         (symbol_needs_eval_context::get_addr_index): Likewise
2543         (disassemble_dwarf_expression): Add DW_OP_addrx
2544         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2545         (read_cutu_die_from_dwo): Update comment
2546         (skip_one_die): Add DW_FORM_addrx
2547         (read_attribute_value): Likewise
2548         (var_decode_location): Add DW_OP_addrx
2549         (dwarf2_const_value_attr): Add DW_FORM_addrx
2550         (dump_die_shallow): Likewise
2551         (dwarf2_fetch_constant_bytes): Likewise
2552         (decode_locdesc): Add DW_OP_addrx
2553         (skip_form_bytes): Add DW_FORM_addrx
2554
2555 2019-04-22  Ali Tamur  <tamur@google.com>
2556
2557         * MAINTAINERS (Write After Approval): Add self.
2558
2559 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2560
2561         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2562         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2563         (open_symbol_file_object): Likewise.
2564         (svr4_default_sos): Add info parameter.
2565         (svr4_read_so_list): Likewise.
2566         (svr4_current_sos_direct): Adjust functions calls to pass down
2567         info.
2568         (svr4_current_sos_1): Add info parameter.
2569         (svr4_current_sos): Call get_svr4_info, pass info down to
2570         svr4_current_sos_1.
2571         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2572         get_svr4_info.
2573         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2574         get_svr4_info.
2575         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2576         to get_svr4_info.
2577         (probes_table_remove_objfile_probes): Likewise.
2578         (register_solib_event_probe): Add info parameter.
2579         (solist_update_incremental): Pass info parameter down to
2580         svr4_read_so_list.
2581         (disable_probes_interface): Add info parameter.
2582         (svr4_handle_solib_event): Pass current_program_space to
2583         get_svr4_info.  Adjust disable_probes_interface cleanup.
2584         (svr4_create_probe_breakpoints): Add info parameter, pass it
2585         down to register_solib_event_probe.
2586         (svr4_create_solib_event_breakpoints): Add info parameter,
2587         pass it down to svr4_create_probe_breakpoints.
2588         (enable_break): Pass info down to
2589         svr4_create_solib_event_breakpoints.
2590         (svr4_solib_create_inferior_hook): Pass current_program_space to
2591         get_svr4_info.
2592         (svr4_clear_solib): Likewise.
2593
2594 2019-04-22  Pedro Alves  <palves@redhat.com>
2595
2596         * solib-svr4.c (svr4_free_objfile_observer): New.
2597         (probe_and_action::objfile): New field.
2598         (probes_table_htab_remove_objfile_probes)
2599         (probes_table_remove_objfile_probes): New functions.
2600         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2601         in the new probe_and_action.  Don't store the probe in 'lookup'.
2602         (svr4_create_probe_breakpoints): Pass objfile to
2603         register_solib_event_probe.
2604         (_initialize_svr4_solib): Register a free_objfile observer.
2605
2606 2019-04-19  Tom Tromey  <tom@tromey.com>
2607
2608         * common/queue.h: Remove.
2609
2610 2019-04-19  Tom Tromey  <tom@tromey.com>
2611
2612         * event-loop.c: Don't include "common/queue.h".
2613
2614 2019-04-19  Tom Tromey  <tom@tromey.com>
2615
2616         * remote.c (remote_target): Use delete.
2617         * remote-notif.h: Include <list>, not "common/queue.h".
2618         (notif_client_p): Remove typedef.
2619         (remote_notif_state): Add constructor, destructor, initializer.
2620         <notif_queue>: Now a std::list.
2621         (remote_notif_state_xfree): Don't declare.
2622         * remote-notif.c (remote_notif_process, handle_notification)
2623         (remote_notif_state_allocate): Update.
2624         (~remote_notif_state): Rename from remote_notif_state_xfree.
2625
2626 2019-04-19  Tom Tromey  <tom@tromey.com>
2627
2628         * symfile.c (reread_symbols): Update.
2629         * objfiles.c (objfile_register_static_link)
2630         (objfile_lookup_static_link): Update
2631         (~objfile) Don't delete static_links.
2632         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2633
2634 2019-04-19  Tom Tromey  <tom@tromey.com>
2635
2636         * type-stack.h (struct type_stack) <insert>: Constify string.
2637         * type-stack.c (type_stack::insert): Constify string.
2638         * gdbtypes.h (lookup_template_type): Update.
2639         (address_space_name_to_int): Update.
2640         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2641         const.
2642         (lookup_template_type): Make name const.
2643         * c-exp.y: Update rules.
2644         (lex_one_token, classify_name, classify_inner_name)
2645         (c_print_token): Update.
2646         * p-exp.y: Update rules.
2647         (yylex): Update.
2648         * f-exp.y: Update rules.
2649         (yylex): Update.
2650         * d-exp.y: Update rules.
2651         (lex_one_token, classify_name, classify_inner_name): Update.
2652         * parse.c (write_dollar_variable, copy_name): Return std::string.
2653         * parser-defs.h (copy_name): Change return type.
2654         * m2-exp.y: Update rules.
2655         (yylex): Update.
2656         * go-exp.y (lex_one_token): Update.
2657         Update rules.
2658         (classify_unsafe_function, classify_packaged_name)
2659         (classify_name, yylex): Update.
2660
2661 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2662
2663         * configure.ac: add --enable-source-highlight switch.
2664         * configure: Regenerate.
2665         * top.c (print_gdb_version): plumb --enable-source-highlight
2666         status to "show configuration".
2667
2668 2019-04-19  Tom Tromey  <tromey@adacore.com>
2669
2670         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2671         Check ADA_TYPE_P.
2672         (empty_record, ada_template_to_fixed_record_type_1)
2673         (template_to_static_fixed_type)
2674         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2675         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2676         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2677         macros.
2678
2679 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2680
2681         PR symtab/24423:
2682         * source.c (print_source_lines_base): Advance "iter" when a
2683         control character is seen.
2684
2685 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2686
2687         * inferior.h (struct infcall_suspend_state_deleter):
2688         Catch exception in destructor to avoid crash.
2689
2690 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2691
2692         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2693         close to the add_com "shell".
2694
2695 2019-04-18  Tom Tromey  <tromey@adacore.com>
2696
2697         * process-stratum-target.h (class process_stratum_target)
2698         <stratum>: Add "final".
2699
2700 2019-04-17  Tom Tromey  <tromey@adacore.com>
2701
2702         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2703         against nullptr before use.
2704
2705 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2706
2707         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2708
2709 2019-04-17  Jim Wilson  <jimw@sifive.com>
2710             Andrew Burgess  <andrew.burgess@embecosm.com>
2711
2712         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2713         code read might fail, assume 4-byte breakpoint in that case.
2714
2715 2019-04-15  Leszek Swirski  <leszeks@google.com>
2716
2717         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2718         rather than a hand-rolled POD check when checking for forced MEMORY
2719         classification.
2720
2721 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2722
2723         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2724         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2725         function.
2726         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2727         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2728         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2729         declaration.
2730
2731 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2732
2733         * aarch64-linux-nat.c
2734         (aarch64_linux_nat_target::thread_architecture): Add override.
2735         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2736         each VQ.
2737
2738 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2739
2740         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2741
2742 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2743
2744         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2745         target types of size 96-bits, add some additional comments, and
2746         check that the builtin type we found was the correct size.
2747
2748 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2749
2750         * utils.c (prompt_for_continue): Don't restore the styling at the
2751         end, as applied_style has the wrong value.  This fixes styling in
2752         long lists of file names that are interrupted by the "Continue?"
2753         prompt.
2754
2755 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2756
2757         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2758         * c-lang.c (c_language_defn): Likewise.
2759         (cplus_language_defn): Likewise.
2760         (asm_language_defn): Likewise.
2761         (minimal_language_defn): Likewise.
2762         * d-lang.c (d_language_defn): Likewise.
2763         * f-lang.c (f_language_defn): Likewise.
2764         * go-lang.c (go_language_defn): Likewise.
2765         * language.c (unknown_language_defn): Likewise.
2766         (auto_language_defn): Likewise.
2767         * language.h (struct language_defn): Remove la_magic field.
2768         (LANG_MAGIC): Delete.
2769         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2770         * objc-lang.c (objc_language_defn): Likewise.
2771         * opencl-lang.c (opencl_language_defn): Likewise.
2772         * p-lang.c (pascal_language_defn): Likewise.
2773         * rust-lang.c (rust_language_defn): Likewise.
2774
2775 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2776
2777         * riscv-tdep.c (riscv_type_align): New function.
2778         (riscv_type_alignment): Delete.
2779         (riscv_arg_location): Use 'type_align'.
2780         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2781
2782 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2783
2784         * gdbtypes.c (type_align): A struct with no non-static fields also
2785         has alignment of 1.
2786
2787 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2788
2789         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2790         component to 0.
2791         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2792         member.
2793         (riscv_struct_info::analyse): New implementation using new
2794         analyse_inner member function.
2795         (riscv_struct_info::field_offset): New member function.
2796         (riscv_struct_info::m_offsets): New member variable.
2797         (riscv_struct_info::analyse_inner): New private member function,
2798         takes the old implementation of riscv_struct_info::analyse but
2799         extended to track field offsets.
2800         (riscv_call_arg_struct): Update the struct folding special cases
2801         to handle cases where empty C++ structs, which are non-zero
2802         length, are found.
2803         (riscv_arg_location): Initialise the length of each location, a
2804         non-zero length now indicates the location is in use.
2805         (riscv_push_dummy_call): Allow for the first location having a
2806         non-zero offset when setting up arguments.
2807         (riscv_return_value): Likewise, but for return values.
2808
2809 2019-04-11  Tom Tromey  <tromey@adacore.com>
2810
2811         * utils.c (internal_vproblem): Make "msg" const.
2812
2813 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2814
2815         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2816         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2817         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2818         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2819
2820 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2821
2822         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2823         function.
2824         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2825         of amd64_collect_native_gregset.
2826         (amd64_linux_nat_target::store_registers): Likewise.
2827
2828 2019-04-10  Tom Tromey  <tom@tromey.com>
2829
2830         * symtab.c (lookup_global_symbol_from_objfile)
2831         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2832         * objfiles.h (class separate_debug_iterator): New.
2833         (class separate_debug_range): New.
2834         (struct objfile) <separate_debug_objfiles>: New method.
2835         (objfile_separate_debug_iterate): Don't declare.
2836         * objfiles.c (separate_debug_iterator::operator++): Rename from
2837         objfile_separate_debug_iterate.
2838         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2839         iterator.
2840         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2841         iterator.
2842
2843 2019-04-10  Tom Tromey  <tom@tromey.com>
2844
2845         * symfile.c (reread_symbols): Remove old comment.
2846         * objfiles.c (free_all_objfiles): Fix a typo.
2847
2848 2019-04-10  Tom Tromey  <tom@tromey.com>
2849
2850         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2851         * minsyms.c (lookup_minimal_symbol): Use foreach.
2852         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2853         (lookup_minimal_symbol_solib_trampoline): Likewise.
2854         * symfile.c (reread_symbols): Use foreach.
2855
2856 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2857             Tom Tromey  <tromey@adacore.com>
2858
2859         PR rust/24414:
2860         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2861         (rust_lex_int_test): Change "value" to be LONGEST.
2862         (rust_lex_tests): Add test for long integer literal.
2863
2864 2019-04-09  Tom Tromey  <tromey@adacore.com>
2865
2866         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2867         to bool.
2868         (extended_remote_target::attach): Update.
2869         (remote_target::remote_notice_new_inferior): Update.
2870         (remote_target::add_current_inferior_and_thread): Update.
2871         * inferior.c (exit_inferior_1): Use "false".
2872         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2873
2874 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2875
2876         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2877         the "start" command.
2878
2879 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2880
2881         * python/py-inferior.c (infpy_thread_from_thread_handle):
2882         Adjust comments to reflect renaming of thread_from_thread_handle
2883         to thread_from_handle.  Adjust keywords.  Fix type error message.
2884         (inferior_object_methods): Add thread_from_handle.  Retain
2885         thread_from_thread_handle, but mark it as deprecated.
2886
2887 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2888
2889         * gdbthread.h (find_thread_by_handle): Revise declaration.
2890         * thread.c (find_thread_by_handle): Likewise.  Adjust
2891         implementation too.
2892         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2893         support for buffer objects as handles.
2894
2895 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2896
2897         * python/py-infthread.c (thpy_thread_handle): New function.
2898         (thread_object_methods): Register thpy_thread_handle.
2899
2900 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2901
2902         * gdbthread.h (thread_to_thread_handle): Declare.
2903         * thread.c (gdbtypes.h): Include.
2904         (thread_to_thread_handle): New function.
2905
2906         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2907         (target_thread_info_to_thread_handle): Declare.
2908         * target.c (target_thread_info_to_thread_handle): New function.
2909         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2910         * target-delegates.c: Regenerate.
2911
2912         * linux-thread-db.c (class thread_db_target): Add method
2913         thread_info_to_thread_handle.
2914         (thread_db_target::thread_info_to_thread_handle): Define.
2915         * remote.c (class remote_target): Add new method
2916         thread_info_to_thread_handle.
2917         (remote_target::thread_info_to_thread_handle): Define.
2918
2919 2019-04-08  Pedro Alves  <palves@redhat.com>
2920
2921         * common/common-exceptions.c (throw_exception): Don't create
2922         named object to throw; throw directly.
2923         (throw_it): Likewise.  Don't initialize gdb_exception::message
2924         here, with new; pass FMT and AP to the ctor instead.
2925         * common/common-exceptions.h: Include <string>.
2926         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2927         const char *, va_list)): New ctor.  Use std::make_shared.
2928         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2929         errors)): Delete.
2930         (gdb_exception_error::gdb_exception_error(enum errors, const char
2931         *, va_list)): New.
2932         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2933         Add assertion.
2934         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2935         errors)): Delete.
2936         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2937         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2938         Add assertion.
2939
2940 2019-04-08  Tom Tromey  <tom@tromey.com>
2941
2942         * valops.c (value_rtti_indirect_type): Replace throw_exception
2943         with throw.
2944         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2945         with throw.
2946         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2947         throw.
2948         * target.c (target_translate_tls_address): Replace throw_exception
2949         with throw.
2950         * stack.c (frame_apply_command_count): Replace throw_exception
2951         with throw.
2952         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2953         throw.
2954         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2955         with throw.
2956         * rs6000-tdep.c (rs6000_frame_cache)
2957         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2958         * remote.c: Replace throw_exception with throw.
2959         * record-full.c (record_full_message, record_full_wait_1)
2960         (record_full_restore): Replace throw_exception with throw.
2961         * record-btrace.c:
2962         (get_thread_current_frame_id, record_btrace_start_replaying)
2963         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2964         (cmd_record_btrace_start): Replace throw_exception with throw.
2965         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2966         throw.
2967         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2968         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2969         * linespec.c:
2970         (find_linespec_symbols): Replace throw_exception with throw.
2971         * infrun.c (displaced_step_prepare, resume): Replace
2972         throw_exception with throw.
2973         * infcmd.c (post_create_inferior): Replace throw_exception with
2974         throw.
2975         * inf-loop.c (inferior_event_handler): Replace throw_exception
2976         with throw.
2977         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2978         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2979         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2980         (get_prev_frame_always, get_frame_pc_if_available)
2981         (get_frame_address_in_block_if_available, get_frame_language):
2982         Replace throw_exception with throw.
2983         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2984         throw_exception with throw.
2985         * eval.c (fetch_subexp_value, evaluate_var_value)
2986         (evaluate_funcall, evaluate_subexp_standard): Replace
2987         throw_exception with throw.
2988         * dwarf2loc.c (call_site_find_chain)
2989         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2990         Replace throw_exception with throw.
2991         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2992         with throw.
2993         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2994         throw.
2995         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2996         * completer.c (complete_line_internal): Replace throw_exception
2997         with throw.
2998         * compile/compile-object-run.c (compile_object_run): Replace
2999         throw_exception with throw.
3000         * cli/cli-script.c (process_next_line): Replace throw_exception
3001         with throw.
3002         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3003         (btrace_enable, btrace_maint_update_pt_packets): Replace
3004         throw_exception with throw.
3005         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3006         throw_exception with throw.
3007         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3008         throw_exception with throw.
3009         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3010         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3011         * aarch64-tdep.c (aarch64_make_prologue_cache)
3012         (aarch64_make_stub_cache): Replace throw_exception with throw.
3013
3014 2019-04-08  Tom Tromey  <tom@tromey.com>
3015
3016         * common/common-exceptions.c (throw_exception): Rename from
3017         throw_exception_cxx.  Remove old copy.  Make argument const.
3018         (throw_it): Create and throw exception objects directly.
3019         * common/common-exceptions.h (throw_exception): Make argument
3020         const.
3021         (struct gdb_exception_error): Add constructor.
3022         (struct gdb_exception_quit): Add constructor.
3023
3024 2019-04-08  Tom Tromey  <tom@tromey.com>
3025
3026         * common/common-exceptions.h (exception_rethrow): Don't declare.
3027         (TRY_SJLJ): Update comment.
3028         (TRY, CATCH, END_CATCH): Remove.
3029         * common/common-exceptions.c (exception_rethrow): Remove.
3030
3031 2019-04-08  Tom Tromey  <tom@tromey.com>
3032
3033         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3034         Remove.
3035         (gdb_exception_error): Rename from
3036         gdb_exception_RETURN_MASK_ERROR.
3037         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3038         (gdb_quit_bad_alloc): Update.
3039         * aarch64-tdep.c: Update.
3040         * ada-lang.c: Update.
3041         * ada-typeprint.c: Update.
3042         * ada-valprint.c: Update.
3043         * amd64-tdep.c: Update.
3044         * arch-utils.c: Update.
3045         * break-catch-throw.c: Update.
3046         * breakpoint.c: Update.
3047         * btrace.c: Update.
3048         * c-varobj.c: Update.
3049         * cli/cli-cmds.c: Update.
3050         * cli/cli-interp.c: Update.
3051         * cli/cli-script.c: Update.
3052         * common/common-exceptions.c: Update.
3053         * common/new-op.c: Update.
3054         * common/selftest.c: Update.
3055         * compile/compile-c-symbols.c: Update.
3056         * compile/compile-cplus-symbols.c: Update.
3057         * compile/compile-object-load.c: Update.
3058         * compile/compile-object-run.c: Update.
3059         * completer.c: Update.
3060         * corelow.c: Update.
3061         * cp-abi.c: Update.
3062         * cp-support.c: Update.
3063         * cp-valprint.c: Update.
3064         * darwin-nat.c: Update.
3065         * disasm-selftests.c: Update.
3066         * dtrace-probe.c: Update.
3067         * dwarf-index-cache.c: Update.
3068         * dwarf-index-write.c: Update.
3069         * dwarf2-frame-tailcall.c: Update.
3070         * dwarf2-frame.c: Update.
3071         * dwarf2loc.c: Update.
3072         * dwarf2read.c: Update.
3073         * eval.c: Update.
3074         * event-loop.c: Update.
3075         * event-top.c: Update.
3076         * exec.c: Update.
3077         * f-valprint.c: Update.
3078         * fbsd-tdep.c: Update.
3079         * frame-unwind.c: Update.
3080         * frame.c: Update.
3081         * gdbtypes.c: Update.
3082         * gnu-v3-abi.c: Update.
3083         * guile/guile-internal.h: Update.
3084         * guile/scm-block.c: Update.
3085         * guile/scm-breakpoint.c: Update.
3086         * guile/scm-cmd.c: Update.
3087         * guile/scm-disasm.c: Update.
3088         * guile/scm-frame.c: Update.
3089         * guile/scm-lazy-string.c: Update.
3090         * guile/scm-math.c: Update.
3091         * guile/scm-param.c: Update.
3092         * guile/scm-ports.c: Update.
3093         * guile/scm-pretty-print.c: Update.
3094         * guile/scm-symbol.c: Update.
3095         * guile/scm-symtab.c: Update.
3096         * guile/scm-type.c: Update.
3097         * guile/scm-value.c: Update.
3098         * i386-linux-tdep.c: Update.
3099         * i386-tdep.c: Update.
3100         * inf-loop.c: Update.
3101         * infcall.c: Update.
3102         * infcmd.c: Update.
3103         * infrun.c: Update.
3104         * jit.c: Update.
3105         * language.c: Update.
3106         * linespec.c: Update.
3107         * linux-fork.c: Update.
3108         * linux-nat.c: Update.
3109         * linux-tdep.c: Update.
3110         * linux-thread-db.c: Update.
3111         * main.c: Update.
3112         * mi/mi-cmd-break.c: Update.
3113         * mi/mi-cmd-stack.c: Update.
3114         * mi/mi-interp.c: Update.
3115         * mi/mi-main.c: Update.
3116         * objc-lang.c: Update.
3117         * p-valprint.c: Update.
3118         * parse.c: Update.
3119         * ppc-linux-tdep.c: Update.
3120         * printcmd.c: Update.
3121         * python/py-arch.c: Update.
3122         * python/py-breakpoint.c: Update.
3123         * python/py-cmd.c: Update.
3124         * python/py-finishbreakpoint.c: Update.
3125         * python/py-frame.c: Update.
3126         * python/py-framefilter.c: Update.
3127         * python/py-gdb-readline.c: Update.
3128         * python/py-inferior.c: Update.
3129         * python/py-infthread.c: Update.
3130         * python/py-lazy-string.c: Update.
3131         * python/py-linetable.c: Update.
3132         * python/py-objfile.c: Update.
3133         * python/py-param.c: Update.
3134         * python/py-prettyprint.c: Update.
3135         * python/py-progspace.c: Update.
3136         * python/py-record-btrace.c: Update.
3137         * python/py-record.c: Update.
3138         * python/py-symbol.c: Update.
3139         * python/py-type.c: Update.
3140         * python/py-unwind.c: Update.
3141         * python/py-utils.c: Update.
3142         * python/py-value.c: Update.
3143         * python/python.c: Update.
3144         * record-btrace.c: Update.
3145         * record-full.c: Update.
3146         * remote-fileio.c: Update.
3147         * remote.c: Update.
3148         * riscv-tdep.c: Update.
3149         * rs6000-aix-tdep.c: Update.
3150         * rs6000-tdep.c: Update.
3151         * rust-exp.y: Update.
3152         * rust-lang.c: Update.
3153         * s390-tdep.c: Update.
3154         * selftest-arch.c: Update.
3155         * solib-dsbt.c: Update.
3156         * solib-frv.c: Update.
3157         * solib-spu.c: Update.
3158         * solib-svr4.c: Update.
3159         * solib.c: Update.
3160         * sparc64-linux-tdep.c: Update.
3161         * stack.c: Update.
3162         * symfile-mem.c: Update.
3163         * symmisc.c: Update.
3164         * target.c: Update.
3165         * thread.c: Update.
3166         * top.c: Update.
3167         * tracefile-tfile.c: Update.
3168         * tui/tui.c: Update.
3169         * typeprint.c: Update.
3170         * unittests/cli-utils-selftests.c: Update.
3171         * unittests/parse-connection-spec-selftests.c: Update.
3172         * valops.c: Update.
3173         * valprint.c: Update.
3174         * value.c: Update.
3175         * varobj.c: Update.
3176         * windows-nat.c: Update.
3177         * x86-linux-nat.c: Update.
3178         * xml-support.c: Update.
3179
3180 2019-04-08  Tom Tromey  <tom@tromey.com>
3181
3182         * xml-support.c: Use C++ exception handling.
3183         * x86-linux-nat.c: Use C++ exception handling.
3184         * windows-nat.c: Use C++ exception handling.
3185         * varobj.c: Use C++ exception handling.
3186         * value.c: Use C++ exception handling.
3187         * valprint.c: Use C++ exception handling.
3188         * valops.c: Use C++ exception handling.
3189         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3190         handling.
3191         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3192         * typeprint.c: Use C++ exception handling.
3193         * tui/tui.c: Use C++ exception handling.
3194         * tracefile-tfile.c: Use C++ exception handling.
3195         * top.c: Use C++ exception handling.
3196         * thread.c: Use C++ exception handling.
3197         * target.c: Use C++ exception handling.
3198         * symmisc.c: Use C++ exception handling.
3199         * symfile-mem.c: Use C++ exception handling.
3200         * stack.c: Use C++ exception handling.
3201         * sparc64-linux-tdep.c: Use C++ exception handling.
3202         * solib.c: Use C++ exception handling.
3203         * solib-svr4.c: Use C++ exception handling.
3204         * solib-spu.c: Use C++ exception handling.
3205         * solib-frv.c: Use C++ exception handling.
3206         * solib-dsbt.c: Use C++ exception handling.
3207         * selftest-arch.c: Use C++ exception handling.
3208         * s390-tdep.c: Use C++ exception handling.
3209         * rust-lang.c: Use C++ exception handling.
3210         * rust-exp.y: Use C++ exception handling.
3211         * rs6000-tdep.c: Use C++ exception handling.
3212         * rs6000-aix-tdep.c: Use C++ exception handling.
3213         * riscv-tdep.c: Use C++ exception handling.
3214         * remote.c: Use C++ exception handling.
3215         * remote-fileio.c: Use C++ exception handling.
3216         * record-full.c: Use C++ exception handling.
3217         * record-btrace.c: Use C++ exception handling.
3218         * python/python.c: Use C++ exception handling.
3219         * python/py-value.c: Use C++ exception handling.
3220         * python/py-utils.c: Use C++ exception handling.
3221         * python/py-unwind.c: Use C++ exception handling.
3222         * python/py-type.c: Use C++ exception handling.
3223         * python/py-symbol.c: Use C++ exception handling.
3224         * python/py-record.c: Use C++ exception handling.
3225         * python/py-record-btrace.c: Use C++ exception handling.
3226         * python/py-progspace.c: Use C++ exception handling.
3227         * python/py-prettyprint.c: Use C++ exception handling.
3228         * python/py-param.c: Use C++ exception handling.
3229         * python/py-objfile.c: Use C++ exception handling.
3230         * python/py-linetable.c: Use C++ exception handling.
3231         * python/py-lazy-string.c: Use C++ exception handling.
3232         * python/py-infthread.c: Use C++ exception handling.
3233         * python/py-inferior.c: Use C++ exception handling.
3234         * python/py-gdb-readline.c: Use C++ exception handling.
3235         * python/py-framefilter.c: Use C++ exception handling.
3236         * python/py-frame.c: Use C++ exception handling.
3237         * python/py-finishbreakpoint.c: Use C++ exception handling.
3238         * python/py-cmd.c: Use C++ exception handling.
3239         * python/py-breakpoint.c: Use C++ exception handling.
3240         * python/py-arch.c: Use C++ exception handling.
3241         * printcmd.c: Use C++ exception handling.
3242         * ppc-linux-tdep.c: Use C++ exception handling.
3243         * parse.c: Use C++ exception handling.
3244         * p-valprint.c: Use C++ exception handling.
3245         * objc-lang.c: Use C++ exception handling.
3246         * mi/mi-main.c: Use C++ exception handling.
3247         * mi/mi-interp.c: Use C++ exception handling.
3248         * mi/mi-cmd-stack.c: Use C++ exception handling.
3249         * mi/mi-cmd-break.c: Use C++ exception handling.
3250         * main.c: Use C++ exception handling.
3251         * linux-thread-db.c: Use C++ exception handling.
3252         * linux-tdep.c: Use C++ exception handling.
3253         * linux-nat.c: Use C++ exception handling.
3254         * linux-fork.c: Use C++ exception handling.
3255         * linespec.c: Use C++ exception handling.
3256         * language.c: Use C++ exception handling.
3257         * jit.c: Use C++ exception handling.
3258         * infrun.c: Use C++ exception handling.
3259         * infcmd.c: Use C++ exception handling.
3260         * infcall.c: Use C++ exception handling.
3261         * inf-loop.c: Use C++ exception handling.
3262         * i386-tdep.c: Use C++ exception handling.
3263         * i386-linux-tdep.c: Use C++ exception handling.
3264         * guile/scm-value.c: Use C++ exception handling.
3265         * guile/scm-type.c: Use C++ exception handling.
3266         * guile/scm-symtab.c: Use C++ exception handling.
3267         * guile/scm-symbol.c: Use C++ exception handling.
3268         * guile/scm-pretty-print.c: Use C++ exception handling.
3269         * guile/scm-ports.c: Use C++ exception handling.
3270         * guile/scm-param.c: Use C++ exception handling.
3271         * guile/scm-math.c: Use C++ exception handling.
3272         * guile/scm-lazy-string.c: Use C++ exception handling.
3273         * guile/scm-frame.c: Use C++ exception handling.
3274         * guile/scm-disasm.c: Use C++ exception handling.
3275         * guile/scm-cmd.c: Use C++ exception handling.
3276         * guile/scm-breakpoint.c: Use C++ exception handling.
3277         * guile/scm-block.c: Use C++ exception handling.
3278         * guile/guile-internal.h: Use C++ exception handling.
3279         * gnu-v3-abi.c: Use C++ exception handling.
3280         * gdbtypes.c: Use C++ exception handling.
3281         * frame.c: Use C++ exception handling.
3282         * frame-unwind.c: Use C++ exception handling.
3283         * fbsd-tdep.c: Use C++ exception handling.
3284         * f-valprint.c: Use C++ exception handling.
3285         * exec.c: Use C++ exception handling.
3286         * event-top.c: Use C++ exception handling.
3287         * event-loop.c: Use C++ exception handling.
3288         * eval.c: Use C++ exception handling.
3289         * dwarf2read.c: Use C++ exception handling.
3290         * dwarf2loc.c: Use C++ exception handling.
3291         * dwarf2-frame.c: Use C++ exception handling.
3292         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3293         * dwarf-index-write.c: Use C++ exception handling.
3294         * dwarf-index-cache.c: Use C++ exception handling.
3295         * dtrace-probe.c: Use C++ exception handling.
3296         * disasm-selftests.c: Use C++ exception handling.
3297         * darwin-nat.c: Use C++ exception handling.
3298         * cp-valprint.c: Use C++ exception handling.
3299         * cp-support.c: Use C++ exception handling.
3300         * cp-abi.c: Use C++ exception handling.
3301         * corelow.c: Use C++ exception handling.
3302         * completer.c: Use C++ exception handling.
3303         * compile/compile-object-run.c: Use C++ exception handling.
3304         * compile/compile-object-load.c: Use C++ exception handling.
3305         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3306         * compile/compile-c-symbols.c: Use C++ exception handling.
3307         * common/selftest.c: Use C++ exception handling.
3308         * common/new-op.c: Use C++ exception handling.
3309         * cli/cli-script.c: Use C++ exception handling.
3310         * cli/cli-interp.c: Use C++ exception handling.
3311         * cli/cli-cmds.c: Use C++ exception handling.
3312         * c-varobj.c: Use C++ exception handling.
3313         * btrace.c: Use C++ exception handling.
3314         * breakpoint.c: Use C++ exception handling.
3315         * break-catch-throw.c: Use C++ exception handling.
3316         * arch-utils.c: Use C++ exception handling.
3317         * amd64-tdep.c: Use C++ exception handling.
3318         * ada-valprint.c: Use C++ exception handling.
3319         * ada-typeprint.c: Use C++ exception handling.
3320         * ada-lang.c: Use C++ exception handling.
3321         * aarch64-tdep.c: Use C++ exception handling.
3322
3323 2019-04-08  Tom Tromey  <tom@tromey.com>
3324
3325         * xml-support.c (gdb_xml_parser::parse): Update.
3326         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3327         * value.c (show_convenience): Update.
3328         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3329         (test_parse_flags_qcs): Update.
3330         * thread.c (thr_try_catch_cmd): Update.
3331         * target.c (target_translate_tls_address): Update.
3332         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3333         (info_frame_command_core, frame_apply_command_count): Update.
3334         * rust-exp.y (rust_lex_exception_test): Update.
3335         * riscv-tdep.c (riscv_print_one_register_info): Update.
3336         * remote.c (remote_target::enable_btrace): Update.
3337         * record-btrace.c (record_btrace_enable_warn): Update.
3338         * python/py-utils.c (gdbpy_convert_exception): Update.
3339         * printcmd.c (do_one_display, print_variable_and_value): Update.
3340         * mi/mi-main.c (mi_print_exception): Update.
3341         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3342         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3343         * linux-nat.c (linux_nat_target::attach): Update.
3344         * linux-fork.c (class scoped_switch_fork_info): Update.
3345         * infrun.c (displaced_step_prepare): Update.
3346         * infcall.c (call_function_by_hand_dummy): Update.
3347         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3348         * gnu-v3-abi.c (print_one_vtable): Update.
3349         * frame.c (get_prev_frame_always): Update.
3350         * f-valprint.c (info_common_command_for_block): Update.
3351         * exec.c (try_open_exec_file): Update.
3352         * exceptions.c (print_exception, exception_print)
3353         (exception_fprintf, exception_print_same): Update.
3354         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3355         * dwarf-index-cache.c (index_cache::store)
3356         (index_cache::lookup_gdb_index): Update.
3357         * darwin-nat.c (maybe_cache_shell): Update.
3358         * cp-valprint.c (cp_print_value_fields): Update.
3359         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3360         (gcc_cplus_symbol_address): Update.
3361         * compile/compile-c-symbols.c (gcc_convert_symbol)
3362         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3363         * common/selftest.c: Update.
3364         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3365         a std::string.
3366         (exception_try_scope_entry, exception_try_scope_exit): Don't
3367         declare.
3368         (struct exception_try_scope): Remove.
3369         (TRY): Don't use exception_try_scope.
3370         (struct gdb_exception): Add constructor, operator=.
3371         <what>: New method.
3372         (struct gdb_exception_RETURN_MASK_ALL)
3373         (struct gdb_exception_RETURN_MASK_ERROR)
3374         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3375         (struct gdb_quit_bad_alloc): Update.
3376         * common/common-exceptions.c (exception_none): Change
3377         initializer.
3378         (struct catcher) <state, exception>: Initialize inline.
3379         <prev>: Remove member.
3380         (current_catcher): Remove.
3381         (catchers): New global.
3382         (exceptions_state_mc_init): Simplify.
3383         (catcher_pop): Remove.
3384         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3385         (try_scope_depth, exception_try_scope_entry)
3386         (exception_try_scope_exit): Remove.
3387         (throw_exception_sjlj): Update.
3388         (exception_messages, exception_messages_size): Remove.
3389         (throw_it): Simplify.
3390         (gdb_exception_sliced_copy): Remove.
3391         (throw_exception_cxx): Update.
3392         * cli/cli-script.c (script_from_file): Update.
3393         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3394         Update.
3395         * ada-valprint.c (ada_val_print): Update.
3396         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3397         (create_excep_cond_exprs): Update.
3398
3399 2019-04-08  Tom Tromey  <tom@tromey.com>
3400
3401         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3402         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3403         (TRY, CATCH, END_CATCH): Remove some definitions.
3404         * common/common-exceptions.c: Don't use GDB_XCPT.
3405         (catcher_list_size): Remove.
3406         (throw_exception, throw_it): Simplify.
3407
3408 2019-04-05  Tom Tromey  <tom@tromey.com>
3409
3410         Revert the header-sorting patch.
3411         * ft32-tdep.c: Revert.
3412         * frv-tdep.c: Revert.
3413         * frv-linux-tdep.c: Revert.
3414         * frame.c: Revert.
3415         * frame-unwind.c: Revert.
3416         * frame-base.c: Revert.
3417         * fork-child.c: Revert.
3418         * findvar.c: Revert.
3419         * findcmd.c: Revert.
3420         * filesystem.c: Revert.
3421         * filename-seen-cache.h: Revert.
3422         * filename-seen-cache.c: Revert.
3423         * fbsd-tdep.c: Revert.
3424         * fbsd-nat.h: Revert.
3425         * fbsd-nat.c: Revert.
3426         * f-valprint.c: Revert.
3427         * f-typeprint.c: Revert.
3428         * f-lang.c: Revert.
3429         * extension.h: Revert.
3430         * extension.c: Revert.
3431         * extension-priv.h: Revert.
3432         * expprint.c: Revert.
3433         * exec.h: Revert.
3434         * exec.c: Revert.
3435         * exceptions.c: Revert.
3436         * event-top.c: Revert.
3437         * event-loop.c: Revert.
3438         * eval.c: Revert.
3439         * elfread.c: Revert.
3440         * dwarf2read.h: Revert.
3441         * dwarf2read.c: Revert.
3442         * dwarf2loc.c: Revert.
3443         * dwarf2expr.h: Revert.
3444         * dwarf2expr.c: Revert.
3445         * dwarf2-frame.c: Revert.
3446         * dwarf2-frame-tailcall.c: Revert.
3447         * dwarf-index-write.h: Revert.
3448         * dwarf-index-write.c: Revert.
3449         * dwarf-index-common.c: Revert.
3450         * dwarf-index-cache.h: Revert.
3451         * dwarf-index-cache.c: Revert.
3452         * dummy-frame.c: Revert.
3453         * dtrace-probe.c: Revert.
3454         * disasm.h: Revert.
3455         * disasm.c: Revert.
3456         * disasm-selftests.c: Revert.
3457         * dictionary.c: Revert.
3458         * dicos-tdep.c: Revert.
3459         * demangle.c: Revert.
3460         * dcache.h: Revert.
3461         * dcache.c: Revert.
3462         * darwin-nat.h: Revert.
3463         * darwin-nat.c: Revert.
3464         * darwin-nat-info.c: Revert.
3465         * d-valprint.c: Revert.
3466         * d-namespace.c: Revert.
3467         * d-lang.c: Revert.
3468         * ctf.c: Revert.
3469         * csky-tdep.c: Revert.
3470         * csky-linux-tdep.c: Revert.
3471         * cris-tdep.c: Revert.
3472         * cris-linux-tdep.c: Revert.
3473         * cp-valprint.c: Revert.
3474         * cp-support.c: Revert.
3475         * cp-namespace.c: Revert.
3476         * cp-abi.c: Revert.
3477         * corelow.c: Revert.
3478         * corefile.c: Revert.
3479         * continuations.c: Revert.
3480         * completer.h: Revert.
3481         * completer.c: Revert.
3482         * complaints.c: Revert.
3483         * coffread.c: Revert.
3484         * coff-pe-read.c: Revert.
3485         * cli-out.h: Revert.
3486         * cli-out.c: Revert.
3487         * charset.c: Revert.
3488         * c-varobj.c: Revert.
3489         * c-valprint.c: Revert.
3490         * c-typeprint.c: Revert.
3491         * c-lang.c: Revert.
3492         * buildsym.c: Revert.
3493         * buildsym-legacy.c: Revert.
3494         * build-id.h: Revert.
3495         * build-id.c: Revert.
3496         * btrace.c: Revert.
3497         * bsd-uthread.c: Revert.
3498         * breakpoint.h: Revert.
3499         * breakpoint.c: Revert.
3500         * break-catch-throw.c: Revert.
3501         * break-catch-syscall.c: Revert.
3502         * break-catch-sig.c: Revert.
3503         * blockframe.c: Revert.
3504         * block.c: Revert.
3505         * bfin-tdep.c: Revert.
3506         * bfin-linux-tdep.c: Revert.
3507         * bfd-target.c: Revert.
3508         * bcache.c: Revert.
3509         * ax-general.c: Revert.
3510         * ax-gdb.h: Revert.
3511         * ax-gdb.c: Revert.
3512         * avr-tdep.c: Revert.
3513         * auxv.c: Revert.
3514         * auto-load.c: Revert.
3515         * arm-wince-tdep.c: Revert.
3516         * arm-tdep.c: Revert.
3517         * arm-symbian-tdep.c: Revert.
3518         * arm-pikeos-tdep.c: Revert.
3519         * arm-obsd-tdep.c: Revert.
3520         * arm-nbsd-tdep.c: Revert.
3521         * arm-nbsd-nat.c: Revert.
3522         * arm-linux-tdep.c: Revert.
3523         * arm-linux-nat.c: Revert.
3524         * arm-fbsd-tdep.c: Revert.
3525         * arm-fbsd-nat.c: Revert.
3526         * arm-bsd-tdep.c: Revert.
3527         * arch-utils.c: Revert.
3528         * arc-tdep.c: Revert.
3529         * arc-newlib-tdep.c: Revert.
3530         * annotate.h: Revert.
3531         * annotate.c: Revert.
3532         * amd64-windows-tdep.c: Revert.
3533         * amd64-windows-nat.c: Revert.
3534         * amd64-tdep.c: Revert.
3535         * amd64-sol2-tdep.c: Revert.
3536         * amd64-obsd-tdep.c: Revert.
3537         * amd64-obsd-nat.c: Revert.
3538         * amd64-nbsd-tdep.c: Revert.
3539         * amd64-nbsd-nat.c: Revert.
3540         * amd64-nat.c: Revert.
3541         * amd64-linux-tdep.c: Revert.
3542         * amd64-linux-nat.c: Revert.
3543         * amd64-fbsd-tdep.c: Revert.
3544         * amd64-fbsd-nat.c: Revert.
3545         * amd64-dicos-tdep.c: Revert.
3546         * amd64-darwin-tdep.c: Revert.
3547         * amd64-bsd-nat.c: Revert.
3548         * alpha-tdep.c: Revert.
3549         * alpha-obsd-tdep.c: Revert.
3550         * alpha-nbsd-tdep.c: Revert.
3551         * alpha-mdebug-tdep.c: Revert.
3552         * alpha-linux-tdep.c: Revert.
3553         * alpha-linux-nat.c: Revert.
3554         * alpha-bsd-tdep.c: Revert.
3555         * alpha-bsd-nat.c: Revert.
3556         * aix-thread.c: Revert.
3557         * agent.c: Revert.
3558         * addrmap.c: Revert.
3559         * ada-varobj.c: Revert.
3560         * ada-valprint.c: Revert.
3561         * ada-typeprint.c: Revert.
3562         * ada-tasks.c: Revert.
3563         * ada-lang.c: Revert.
3564         * aarch64-tdep.c: Revert.
3565         * aarch64-ravenscar-thread.c: Revert.
3566         * aarch64-newlib-tdep.c: Revert.
3567         * aarch64-linux-tdep.c: Revert.
3568         * aarch64-linux-nat.c: Revert.
3569         * aarch64-fbsd-tdep.c: Revert.
3570         * aarch64-fbsd-nat.c: Revert.
3571         * aarch32-linux-nat.c: Revert.
3572
3573 2019-04-05  Tom Tromey  <tom@tromey.com>
3574
3575         * ft32-tdep.c: Sort headers.
3576         * frv-tdep.c: Sort headers.
3577         * frv-linux-tdep.c: Sort headers.
3578         * frame.c: Sort headers.
3579         * frame-unwind.c: Sort headers.
3580         * frame-base.c: Sort headers.
3581         * fork-child.c: Sort headers.
3582         * findvar.c: Sort headers.
3583         * findcmd.c: Sort headers.
3584         * filesystem.c: Sort headers.
3585         * filename-seen-cache.h: Sort headers.
3586         * filename-seen-cache.c: Sort headers.
3587         * fbsd-tdep.c: Sort headers.
3588         * fbsd-nat.h: Sort headers.
3589         * fbsd-nat.c: Sort headers.
3590         * f-valprint.c: Sort headers.
3591         * f-typeprint.c: Sort headers.
3592         * f-lang.c: Sort headers.
3593         * extension.h: Sort headers.
3594         * extension.c: Sort headers.
3595         * extension-priv.h: Sort headers.
3596         * expprint.c: Sort headers.
3597         * exec.h: Sort headers.
3598         * exec.c: Sort headers.
3599         * exceptions.c: Sort headers.
3600         * event-top.c: Sort headers.
3601         * event-loop.c: Sort headers.
3602         * eval.c: Sort headers.
3603         * elfread.c: Sort headers.
3604         * dwarf2read.h: Sort headers.
3605         * dwarf2read.c: Sort headers.
3606         * dwarf2loc.c: Sort headers.
3607         * dwarf2expr.h: Sort headers.
3608         * dwarf2expr.c: Sort headers.
3609         * dwarf2-frame.c: Sort headers.
3610         * dwarf2-frame-tailcall.c: Sort headers.
3611         * dwarf-index-write.h: Sort headers.
3612         * dwarf-index-write.c: Sort headers.
3613         * dwarf-index-common.c: Sort headers.
3614         * dwarf-index-cache.h: Sort headers.
3615         * dwarf-index-cache.c: Sort headers.
3616         * dummy-frame.c: Sort headers.
3617         * dtrace-probe.c: Sort headers.
3618         * disasm.h: Sort headers.
3619         * disasm.c: Sort headers.
3620         * disasm-selftests.c: Sort headers.
3621         * dictionary.c: Sort headers.
3622         * dicos-tdep.c: Sort headers.
3623         * demangle.c: Sort headers.
3624         * dcache.h: Sort headers.
3625         * dcache.c: Sort headers.
3626         * darwin-nat.h: Sort headers.
3627         * darwin-nat.c: Sort headers.
3628         * darwin-nat-info.c: Sort headers.
3629         * d-valprint.c: Sort headers.
3630         * d-namespace.c: Sort headers.
3631         * d-lang.c: Sort headers.
3632         * ctf.c: Sort headers.
3633         * csky-tdep.c: Sort headers.
3634         * csky-linux-tdep.c: Sort headers.
3635         * cris-tdep.c: Sort headers.
3636         * cris-linux-tdep.c: Sort headers.
3637         * cp-valprint.c: Sort headers.
3638         * cp-support.c: Sort headers.
3639         * cp-namespace.c: Sort headers.
3640         * cp-abi.c: Sort headers.
3641         * corelow.c: Sort headers.
3642         * corefile.c: Sort headers.
3643         * continuations.c: Sort headers.
3644         * completer.h: Sort headers.
3645         * completer.c: Sort headers.
3646         * complaints.c: Sort headers.
3647         * coffread.c: Sort headers.
3648         * coff-pe-read.c: Sort headers.
3649         * cli-out.h: Sort headers.
3650         * cli-out.c: Sort headers.
3651         * charset.c: Sort headers.
3652         * c-varobj.c: Sort headers.
3653         * c-valprint.c: Sort headers.
3654         * c-typeprint.c: Sort headers.
3655         * c-lang.c: Sort headers.
3656         * buildsym.c: Sort headers.
3657         * buildsym-legacy.c: Sort headers.
3658         * build-id.h: Sort headers.
3659         * build-id.c: Sort headers.
3660         * btrace.c: Sort headers.
3661         * bsd-uthread.c: Sort headers.
3662         * breakpoint.h: Sort headers.
3663         * breakpoint.c: Sort headers.
3664         * break-catch-throw.c: Sort headers.
3665         * break-catch-syscall.c: Sort headers.
3666         * break-catch-sig.c: Sort headers.
3667         * blockframe.c: Sort headers.
3668         * block.c: Sort headers.
3669         * bfin-tdep.c: Sort headers.
3670         * bfin-linux-tdep.c: Sort headers.
3671         * bfd-target.c: Sort headers.
3672         * bcache.c: Sort headers.
3673         * ax-general.c: Sort headers.
3674         * ax-gdb.h: Sort headers.
3675         * ax-gdb.c: Sort headers.
3676         * avr-tdep.c: Sort headers.
3677         * auxv.c: Sort headers.
3678         * auto-load.c: Sort headers.
3679         * arm-wince-tdep.c: Sort headers.
3680         * arm-tdep.c: Sort headers.
3681         * arm-symbian-tdep.c: Sort headers.
3682         * arm-pikeos-tdep.c: Sort headers.
3683         * arm-obsd-tdep.c: Sort headers.
3684         * arm-nbsd-tdep.c: Sort headers.
3685         * arm-nbsd-nat.c: Sort headers.
3686         * arm-linux-tdep.c: Sort headers.
3687         * arm-linux-nat.c: Sort headers.
3688         * arm-fbsd-tdep.c: Sort headers.
3689         * arm-fbsd-nat.c: Sort headers.
3690         * arm-bsd-tdep.c: Sort headers.
3691         * arch-utils.c: Sort headers.
3692         * arc-tdep.c: Sort headers.
3693         * arc-newlib-tdep.c: Sort headers.
3694         * annotate.h: Sort headers.
3695         * annotate.c: Sort headers.
3696         * amd64-windows-tdep.c: Sort headers.
3697         * amd64-windows-nat.c: Sort headers.
3698         * amd64-tdep.c: Sort headers.
3699         * amd64-sol2-tdep.c: Sort headers.
3700         * amd64-obsd-tdep.c: Sort headers.
3701         * amd64-obsd-nat.c: Sort headers.
3702         * amd64-nbsd-tdep.c: Sort headers.
3703         * amd64-nbsd-nat.c: Sort headers.
3704         * amd64-nat.c: Sort headers.
3705         * amd64-linux-tdep.c: Sort headers.
3706         * amd64-linux-nat.c: Sort headers.
3707         * amd64-fbsd-tdep.c: Sort headers.
3708         * amd64-fbsd-nat.c: Sort headers.
3709         * amd64-dicos-tdep.c: Sort headers.
3710         * amd64-darwin-tdep.c: Sort headers.
3711         * amd64-bsd-nat.c: Sort headers.
3712         * alpha-tdep.c: Sort headers.
3713         * alpha-obsd-tdep.c: Sort headers.
3714         * alpha-nbsd-tdep.c: Sort headers.
3715         * alpha-mdebug-tdep.c: Sort headers.
3716         * alpha-linux-tdep.c: Sort headers.
3717         * alpha-linux-nat.c: Sort headers.
3718         * alpha-bsd-tdep.c: Sort headers.
3719         * alpha-bsd-nat.c: Sort headers.
3720         * aix-thread.c: Sort headers.
3721         * agent.c: Sort headers.
3722         * addrmap.c: Sort headers.
3723         * ada-varobj.c: Sort headers.
3724         * ada-valprint.c: Sort headers.
3725         * ada-typeprint.c: Sort headers.
3726         * ada-tasks.c: Sort headers.
3727         * ada-lang.c: Sort headers.
3728         * aarch64-tdep.c: Sort headers.
3729         * aarch64-ravenscar-thread.c: Sort headers.
3730         * aarch64-newlib-tdep.c: Sort headers.
3731         * aarch64-linux-tdep.c: Sort headers.
3732         * aarch64-linux-nat.c: Sort headers.
3733         * aarch64-fbsd-tdep.c: Sort headers.
3734         * aarch64-fbsd-nat.c: Sort headers.
3735         * aarch32-linux-nat.c: Sort headers.
3736
3737 2019-04-04  Tom Tromey  <tom@tromey.com>
3738
3739         * varobj.c (varobj_create): Update.
3740         * rust-exp.y (struct rust_parser) <update_innermost_block,
3741         lookup_symbol>: New methods.
3742         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3743         Rename.
3744         (rust_parser::rust_lookup_type)
3745         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3746         * printcmd.c (display_command, do_one_display): Update.
3747         * parser-defs.h (struct parser_state) <parser_state>: Add
3748         "tracker" parameter.
3749         (block_tracker): New member.
3750         (class innermost_block_tracker) <innermost_block_tracker>: Add
3751         "types" parameter.
3752         <reset>: Remove method.
3753         (innermost_block): Don't declare.
3754         (null_post_parser): Update.
3755         * parse.c (innermost_block): Remove global.
3756         (write_dollar_variable): Update.
3757         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3758         Remove "tracker_types" parameter.
3759         (parse_expression): Add "tracker" parameter.
3760         (parse_expression_for_completion): Update.
3761         (null_post_parser): Add "tracker" parameter.
3762         * p-exp.y: Update rules.
3763         * m2-exp.y: Update rules.
3764         * language.h (struct language_defn) <la_post_parser>: Add
3765         "tracker" parameter.
3766         * go-exp.y: Update rules.
3767         * f-exp.y: Update rules.
3768         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3769         parameter.
3770         * d-exp.y: Update rules.
3771         * c-exp.y: Update rules.
3772         * breakpoint.c (set_breakpoint_condition): Create an
3773         innermost_block_tracker.
3774         (watch_command_1): Likewise.
3775         * ada-lang.c (resolve): Add "tracker" parameter.
3776         (resolve_subexp): Likewise.
3777         * ada-exp.y (write_var_from_sym): Update.
3778
3779 2019-04-04  Tom Tromey  <tom@tromey.com>
3780
3781         * type-stack.h: New file.
3782         * type-stack.c: New file.
3783         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3784         type-stack.h.
3785         (insert_into_type_stack, insert_type, push_type, push_type_int)
3786         (insert_type_address_space, pop_type, pop_type_int)
3787         (pop_typelist, pop_type_stack, append_type_stack)
3788         (push_type_stack, get_type_stack, push_typelist)
3789         (follow_type_instance_flags, follow_types): Don't declare.
3790         * parse.c (type_stack): Remove global.
3791         (parse_exp_in_context): Update.
3792         (insert_into_type_stack, insert_type, push_type, push_type_int)
3793         (insert_type_address_space, pop_type, pop_type_int)
3794         (pop_typelist, pop_type_stack, append_type_stack)
3795         (push_type_stack, get_type_stack, push_typelist)
3796         (follow_type_instance_flags, follow_types): Remove (moved to
3797         type-stack.c).
3798         * f-exp.y (type_stack): New global.
3799         Update rules.
3800         (push_kind_type, f_parse): Update.
3801         * d-exp.y (type_stack): New global.
3802         Update rules.
3803         (d_parse): Update.
3804         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3805         Update rules.
3806         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3807         (HFILES_NO_SRCDIR): Add type-stack.h.
3808
3809 2019-04-04  Tom Tromey  <tom@tromey.com>
3810
3811         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3812         (rust_parser::convert_ast_to_expression, rust_parse)
3813         (rust_lex_test_completion, rust_lex_tests): Update.
3814         * parser-defs.h (struct expr_completion_state): New.
3815         (struct parser_state) <parser_state>: Add completion parameter.
3816         <mark_struct_expression, mark_completion_tag>: New methods.
3817         <parse_completion, m_completion_state>: New members.
3818         (prefixify_expression, null_post_parser): Update.
3819         (mark_struct_expression, mark_completion_tag): Don't declare.
3820         * parse.c (parse_completion, expout_last_struct)
3821         (expout_tag_completion_type, expout_completion_name): Remove
3822         globals.
3823         (parser_state::mark_struct_expression)
3824         (parser_state::mark_completion_tag): Now methods.
3825         (prefixify_expression): Add last_struct parameter.
3826         (prefixify_subexp): Likewise.
3827         (parse_exp_1): Update.
3828         (parse_exp_in_context): Add cstate parameter.  Update.
3829         (parse_expression_for_completion): Create an
3830         expr_completion_state.
3831         (null_post_parser): Add "completion" parameter.
3832         * p-exp.y: Update rules.
3833         (yylex): Update.
3834         * language.h (struct language_defn) <la_post_parser>: Add
3835         "completing" parameter.
3836         * go-exp.y: Update rules.
3837         (lex_one_token): Update.
3838         * expression.h (parse_completion): Don't declare.
3839         * d-exp.y: Update rules.
3840         (lex_one_token): Update rules.
3841         * c-exp.y: Update rules.
3842         (lex_one_token): Update.
3843         * ada-lang.c (resolve): Add "parse_completion" parameter.
3844         (resolve_subexp): Likewise.
3845         (ada_resolve_function): Likewise.
3846
3847 2019-04-04  Tom Tromey  <tom@tromey.com>
3848
3849         * parser-defs.h (struct parser_state) <start_arglist,
3850         end_arglist>: New methods.
3851         <arglist_len, m_funcall_chain>: New members.
3852         (arglist_len, start_arglist, end_arglist): Don't declare.
3853         * parse.c (arglist_len, funcall_chain): Remove global.
3854         (start_arglist, end_arglist): Remove functions.
3855         (parse_exp_in_context): Update.
3856         * p-exp.y: Update rules.
3857         * m2-exp.y: Update rules.
3858         * go-exp.y: Update rules.
3859         * f-exp.y: Update rules.
3860         * d-exp.y: Update rules.
3861         * c-exp.y: Update rules.
3862
3863 2019-04-04  Tom Tromey  <tom@tromey.com>
3864
3865         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3866         lex_operator, push_back>: New methods.
3867         Update all rules.
3868         (rust_parser::lex_hex, lex_escape): Rename and update.
3869         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3870         (rust_parser::lex_operator): Rename and update.
3871         (rust_parser::lex_number, rustyylex, rustyyerror)
3872         (rust_lex_test_init, rust_lex_test_sequence)
3873         (rust_lex_test_push_back, rust_lex_tests): Update.
3874         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3875         parameter.
3876         <lexptr, prev_lexptr>: New members.
3877         (lexptr, prev_lexptr): Don't declare.
3878         * parse.c (lexptr, prev_lexptr): Remove globals.
3879         (parse_exp_in_context): Update.
3880         * p-exp.y (yylex, yyerror): Update.
3881         * m2-exp.y (parse_number, yylex, yyerror): Update.
3882         * go-exp.y (lex_one_token, yyerror): Update.
3883         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3884         * d-exp.y (lex_one_token, yyerror): Update.
3885         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3886         (lex_one_token, yyerror): Update.
3887         * ada-lex.l (YY_INPUT): Update.
3888         (rewind_to_char): Update.
3889         * ada-exp.y (yyerror): Update.
3890
3891 2019-04-04  Tom Tromey  <tom@tromey.com>
3892
3893         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3894         * parser-defs.h (struct parser_state) <parser_state>: Add new
3895         parameter.
3896         <comma_terminates>: New member.
3897         (comma_terminates): Don't declare global.
3898         * parse.c (comma_terminates): Remove global.
3899         (parse_exp_in_context): Update.
3900         * p-exp.y (yylex): Update.
3901         * m2-exp.y (yylex): Update.
3902         * go-exp.y (lex_one_token): Update.
3903         * f-exp.y (yylex): Update.
3904         * d-exp.y (lex_one_token): Update.
3905         * c-exp.y (lex_one_token): Update.
3906         * ada-lex.l: Update.
3907
3908 2019-04-04  Tom Tromey  <tom@tromey.com>
3909
3910         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3911         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3912         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3913         * parser-defs.h (paren_depth): Don't declare.
3914         * parse.c (paren_depth): Remove global.
3915         (parse_exp_in_context): Update.
3916         * p-exp.y (paren_depth): New global.
3917         (pascal_parse): Initialize it.
3918         * m2-exp.y (paren_depth): New global.
3919         (m2_parse): Initialize it.
3920         * go-exp.y (paren_depth): New global.
3921         (go_parse): Initialize it.
3922         * f-exp.y (paren_depth): New global.
3923         (f_parse): Initialize it.
3924         * d-exp.y (paren_depth): New global.
3925         (d_parse): Initialize it.
3926         * c-exp.y (paren_depth): New global.
3927         (c_parse): Initialize it.
3928         * ada-lex.l (paren_depth): New global.
3929         (lexer_init): Initialize it.
3930
3931 2019-04-04  Tom Tromey  <tom@tromey.com>
3932
3933         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3934         (rust_parser::convert_ast_to_type)
3935         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3936         * parser-defs.h (struct parser_state) <parser_state>: Add
3937         parameters.  Initialize new members.
3938         <expression_context_block, expression_context_pc>: New members.
3939         * parse.c (expression_context_block, expression_context_pc):
3940         Remove globals.
3941         (parse_exp_in_context): Update.
3942         * p-exp.y: Update all rules.
3943         (yylex): Update.
3944         * m2-exp.y: Update all rules.
3945         (yylex): Update.
3946         * go-exp.y (yylex): Update.
3947         * f-exp.y (yylex): Update.
3948         * d-exp.y: Update all rules.
3949         (yylex): Update.
3950         * c-exp.y: Update all rules.
3951         (lex_one_token, classify_name, yylex, c_parse): Update.
3952         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3953
3954 2019-04-04  Tom Tromey  <tom@tromey.com>
3955
3956         * gdbarch.h, gdbarch.c: Rebuild.
3957         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3958         * stap-probe.h:
3959         (struct stap_parse_info): Replace "parser_state" with
3960         "expr_builder".
3961         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3962         (parser_state): New class.
3963         * parse.c (expr_builder): Rename.
3964         (expr_builder::release): Rename.
3965         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3966         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3967         (write_exp_elt_longcst, write_exp_elt_floatcst)
3968         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3969         (write_exp_string_vector, write_exp_bitstring)
3970         (write_exp_msymbol, mark_struct_expression)
3971         (write_dollar_variable)
3972         (insert_type_address_space, increase_expout_size): Replace
3973         "parser_state" with "expr_builder".
3974         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3975         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3976         "parser_state" with "expr_builder".
3977
3978 2019-04-04  Tom Tromey  <tom@tromey.com>
3979
3980         * rust-exp.y: Replace "parse_language" with method call.
3981         * p-exp.y:
3982         (yylex): Replace "parse_language" with method call.
3983         * m2-exp.y:
3984         (yylex): Replace "parse_language" with method call.
3985         * go-exp.y (classify_name): Replace "parse_language" with method
3986         call.
3987         * f-exp.y (yylex): Replace "parse_language" with method call.
3988         * d-exp.y (lex_one_token): Replace "parse_language" with method
3989         call.
3990         * c-exp.y:
3991         (lex_one_token, classify_name, yylex): Replace "parse_language"
3992         with method call.
3993         * ada-exp.y (find_primitive_type, type_char)
3994         (type_system_address): Replace "parse_language" with method call.
3995
3996 2019-04-04  Tom Tromey  <tom@tromey.com>
3997
3998         * rust-exp.y: Replace "parse_gdbarch" with method call.
3999         * parse.c (write_dollar_variable, insert_type_address_space):
4000         Replace "parse_gdbarch" with method call.
4001         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4002         call.
4003         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4004         call.
4005         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4006         "parse_gdbarch" with method call.
4007         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4008         with method call.
4009         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4010         "parse_gdbarch" with method call.
4011         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4012         "parse_gdbarch" with method call.
4013         * c-exp.y (parse_type, parse_number, classify_name): Replace
4014         "parse_gdbarch" with method call.
4015         * ada-lex.l: Replace "parse_gdbarch" with method call.
4016         * ada-exp.y (parse_type, find_primitive_type, type_char)
4017         (type_system_address): Replace "parse_gdbarch" with method call.
4018
4019 2019-04-04  Tom Tromey  <tom@tromey.com>
4020
4021         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4022         * stap-probe.c (stap_parse_argument): Update.
4023         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4024         initial_size parameter.
4025         * rust-exp.y (rust_lex_tests): Update.
4026         * parse.c (parser_state): Update.
4027         (parse_exp_in_context): Update.
4028         * parser-defs.h (struct parser_state) <parser_state>: Remove
4029         "initial_size" parameter.
4030
4031 2019-04-04  Tom Tromey  <tom@tromey.com>
4032
4033         * parser-defs.h (increase_expout_size): Don't declare.
4034         * parse.c (increase_expout_size): Now static.
4035
4036 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4037
4038         * gnu-nat.c (gnu_nat_target::wait): Fix
4039         target_waitstatus_to_string call.
4040
4041 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4042
4043         * eval.c (evaluate_subexp_standard): Handle internal functions
4044         during Fortran function call handling.
4045
4046 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4047
4048         * NEWS: Mention new internal functions.
4049         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4050         (read_base_type): Use dwarf2_init_complex_target_type.
4051         * value.c (creal_internal_fn): New function.
4052         (cimag_internal_fn): New function.
4053         (_initialize_values): Register new internal functions.
4054
4055 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4056
4057         * infrun.c (stop_all_threads): If debug_infrun, always
4058         trace the wait status after wait_one, using
4059         target_waitstatus_to_string and target_pid_to_str.
4060         (handle_inferior_event): Replace various trace of
4061         wait status kind by a single trace.
4062         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4063         wait status kind image by target_waitstatus_to_string.
4064         * target/waitstatus.c (target_waitstatus_to_string): Fix
4065         obsolete comment.
4066
4067 2019-04-01  Tom Tromey  <tromey@adacore.com>
4068
4069         PR symtab/23331:
4070         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4071
4072 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4073             Pedro Alves  <palves@redhat.com>
4074
4075         * top.c (quit_force): Call 'finalize_values'.
4076         * value.c (finalize_values): New function.
4077         * value.h (finalize_values): Declare.
4078
4079 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4080
4081         * NEWS: Announce $_gdb_major and $_gdb_minor.
4082
4083         * top.c (init_gdb_version_vars): New function.
4084         (gdb_init): Call init_gdb_version_vars.
4085
4086 2019-03-29  Tom Tromey  <tromey@adacore.com>
4087
4088         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4089         help text.  Remove dead code.
4090
4091 2019-03-29  Keith Seitz  <keiths@redhat.com>
4092
4093         From Siddhesh Poyarekar:
4094         * f-lang.h (f77_get_upperbound): Return LONGEST.
4095         (f77_get_lowerbound): Likewise.
4096         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4097         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4098         print them.
4099         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4100         plongest to format print it.
4101         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4102         (f77_get_upperbound): Likewise.
4103         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4104         LOWER_BOUND to LONGEST.
4105         (f77_create_arrayprint_offset_tbl): Likewise.
4106
4107 2019-03-29  Keith Seitz  <keiths@redhat.com>
4108
4109         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4110         %s/pulongest for TYPE_LENGTH instead of %d in format
4111         strings.
4112         * ada-typerint.c (ada_print_type): Likewise.
4113         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4114         * compile/compile-c-support.c (generate_register_struct): Likewise.
4115         * gdbtypes.c (recursive_dump_type): Likewise.
4116         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4117         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4118         instead of %d in format strings.
4119         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4120         to std::min to ULONGEST.
4121         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4122         instead of %d in format strings.
4123         * tracepoint.c (info_scope_command): Likewise.
4124         * typeprint.c (print_offset_data::update)
4125         (print_offset_data::finish): Likewise.
4126         * xtensa-tdep.c (xtensa_store_return_value)
4127         (xtensa_push_dummy_call): Likewise.
4128
4129 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4130
4131         * windows-nat.c (display_selector): Fixed format specifications
4132         for 64-bit Cygwin.
4133
4134 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4135
4136         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4137
4138 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4139
4140         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4141         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4142         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4143         (nios2_linux_init_abi): Install it.
4144
4145 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4146
4147         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4148
4149 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4150
4151         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4152
4153 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4154             Tom Tromey  <tromey@adacore.com>
4155
4156         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4157
4158 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4159
4160         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4161         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4162         method to compute the bounds of range types. Also print "[evaluated]"
4163         if the bounds' values come from a dynamic evaluation.
4164
4165 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4166
4167         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4168         whitespace when pretty printing is on.
4169
4170 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4171
4172         * ppc-linux-nat.c: Add include.
4173
4174 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4175
4176         * NEWS: Mention AArch64 Pointer Authentication.
4177
4178 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4179
4180         * arm-linux-nat.c: Add include.
4181
4182 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4183
4184         * source-cache.c (source_cache::get_source_lines): Re-read
4185         fullname after calling open_source_file.
4186
4187 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4188
4189         * NEWS: Mention TLS support for FreeBSD.
4190
4191 2019-03-25  Tom Tromey  <tromey@adacore.com>
4192
4193         * minsyms.c (BUNCH_SIZE): Update comment.
4194         (~minimal_symbol_reader): Remove old comment.
4195         (compact_minimal_symbols): Update comment.
4196         (minimal_symbol_reader::install): Remove old comment.  Update
4197         other comments.
4198
4199 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4200
4201         * s390-linux-nat.c: Add include.
4202
4203 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4204
4205         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4206         Call linux_get_hwcap.
4207         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4208         Likewise.
4209         (aarch64_linux_get_hwcap): Remove function.
4210         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4211         declaration.
4212         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4213         linux_get_hwcap.
4214         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4215         * linux-tdep.c (linux_get_hwcap): Add function.
4216         (linux_get_hwcap2): Likewise.
4217         * linux-tdep.h (linux_get_hwcap): Add declaration.
4218         (linux_get_hwcap2): Likewise.
4219         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4220         (ppc_linux_get_hwcap2): Likewise.
4221         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4222         linux_get_hwcap.
4223         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4224         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4225         (ppc_linux_nat_target::read_description): Likewise.
4226         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4227         * s390-linux-nat.c: Likewise.
4228         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4229
4230 2019-03-24  Tom Tromey  <tom@tromey.com>
4231
4232         * ada-lang.c (standard_lookup): Simplify initialization.
4233         (ada_lookup_symbol_nonlocal): Simplify return.
4234         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4235         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4236         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4237         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4238         initialization.
4239         * solib.c (solib_global_lookup): Simplify.
4240         * symtab.c (null_block_symbol): Remove.
4241         (symbol_cache_lookup): Simplify returns.
4242         (lookup_language_this): Simplify returns.
4243         (lookup_symbol_aux): Simplify return.
4244         (lookup_local_symbol): Simplify returns.
4245         (lookup_global_symbol_from_objfile): Simplify return.
4246         (lookup_symbol_in_objfile_symtabs)
4247         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4248         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4249         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4250         * cp-namespace.c (cp_lookup_bare_symbol)
4251         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4252         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4253         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4254         (cp_lookup_symbol_via_imports): Simplify initialization.
4255         (find_symbol_in_baseclass): Likewise.
4256         * symtab.h (null_block_symbol): Remove.
4257         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4258         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4259         (d_lookup_symbol_module): Likewise.
4260         (find_symbol_in_baseclass): Simplify initialization.
4261
4262 2019-03-24  Tom Tromey  <tom@tromey.com>
4263
4264         * expression.h: Don't include symtab.h.
4265         (struct block): Forward declare.
4266
4267 2019-03-24  Tom Tromey  <tom@tromey.com>
4268
4269         * c-exp.y (typebase): Remove casts.
4270         * gdbtypes.c (lookup_unsigned_typename, )
4271         (lookup_signed_typename): Remove cast.
4272         * eval.c (parse_to_comma_and_eval): Remove cast.
4273         * parse.c (write_dollar_variable): Remove cast.
4274         * block.h (struct block) <superblock>: Now const.
4275         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4276         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4277         (map_block): Make "block" const.
4278         * symfile.h (struct quick_symbol_functions)
4279         <map_matching_symbols>: Constify block argument to "callback".
4280         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4281         const.
4282         (find_pc_sect_compunit_symtab): Make "b" const.
4283         (find_symbol_at_address): Likewise.
4284         (search_symbols): Likewise.
4285         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4286         (dw2_debug_names_lookup_symbol): Likewise.
4287         (dw2_map_matching_symbols): Update.
4288         * p-valprint.c (pascal_val_print): Remove "block".
4289         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4290         (aux_add_nonlocal_symbols): Make "block" const.
4291         (resolve_subexp): Remove cast.
4292         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4293         const.
4294         (iterate_over_file_blocks): Likewise.
4295         * f-exp.y (%union) <bval>: Remove.
4296         * coffread.c (patch_opaque_types): Make "b" const.
4297         * spu-tdep.c (spu_catch_start): Make "block" const.
4298         * c-valprint.c (print_unpacked_pointer): Remove "block".
4299         * symmisc.c (dump_symtab_1): Make "b" const.
4300         (block_depth): Make "block" const.
4301         * d-exp.y (%union) <bval>: Remove.
4302         * cp-support.h (cp_lookup_rtti_type): Update.
4303         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4304         * psymtab.c (psym_lookup_symbol): Make "block" const.
4305         (maintenance_check_psymtabs): Make "b" const.
4306         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4307         (enumerate_locals, enumerate_args): Update.
4308         * python/py-symtab.c (stpy_global_block): Make "block" const.
4309         (stpy_static_block): Likewise.
4310         * inline-frame.c (block_starting_point_at): Make "new_block"
4311         const.
4312         * block.c (find_block_in_blockvector): Make return type const.
4313         (blockvector_for_pc_sect): Make "b" const.
4314         (find_block_in_blockvector): Make "b" const.
4315
4316 2019-03-23  Tom Tromey  <tom@tromey.com>
4317
4318         * varobj.c (varobj_create): Update.
4319         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4320         * printcmd.c (display_command, do_one_display): Don't reset
4321         innermost_block.
4322         * parser-defs.h (enum innermost_block_tracker_type): Move to
4323         expression.h.
4324         (innermost_block): Update comment.
4325         * parse.c (parse_exp_1): Add tracker_types parameter.
4326         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4327         tracker_types parameter.  Reset innermost_block.
4328         (parse_exp_in_context): Remove.
4329         (parse_expression_for_completion): Update.
4330         * objfiles.c (~objfile): Don't reset expression_context_block or
4331         innermost_block.
4332         * expression.h (enum innermost_block_tracker_type): Move from
4333         parser-defs.h.
4334         (parse_exp_1): Add tracker_types parameter.
4335         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4336         reset innermost_block.
4337
4338 2019-03-23  Tom Tromey  <tom@tromey.com>
4339
4340         * objfiles.h: Include bcache.h.
4341
4342 2019-03-23  Tom Tromey  <tom@tromey.com>
4343
4344         * linespec.c (get_current_search_block): Use
4345         scoped_restore_current_language.
4346         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4347
4348 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4349             Jiong Wang  <jiong.wang@arm.com>
4350
4351         * aarch64-linux-tdep.c
4352         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4353         section.
4354         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4355
4356 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4357             Jiong Wang  <jiong.wang@arm.com>
4358
4359         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4360         instructions.
4361         (aarch64_analyze_prologue_test): Add PACIASP test.
4362         (aarch64_prologue_prev_register): Unmask PC value.
4363
4364 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4365             Jiong Wang  <jiong.wang@arm.com>
4366
4367         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4368         (aarch64_dwarf2_prev_register): Unmask PC value.
4369         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4370         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4371         DW_CFA_AARCH64_negate_ra_state.
4372         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4373
4374 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4375             Jiong Wang  <jiong.wang@arm.com>
4376
4377         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4378         registers.
4379         (aarch64_pseudo_register_name): Likewise.
4380         (aarch64_pseudo_register_type): Likewise.
4381         (aarch64_pseudo_register_reggroup_p): Likewise.
4382         (aarch64_gdbarch_init): Add pauth registers.
4383         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4384         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4385         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4386         (struct gdbarch_tdep): Add regnum for ra_state.
4387
4388 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4389             Jiong Wang  <jiong.wang@arm.com>
4390
4391         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4392
4393 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4394             Jiong Wang  <jiong.wang@arm.com>
4395
4396         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4397         function.
4398         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4399         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4400         (aarch64_gdbarch_init): Add puth registers.
4401         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4402         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4403         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4404
4405 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4406             Jiong Wang  <jiong.wang@arm.com>
4407
4408         * aarch64-linux-nat.c
4409         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4410         * aarch64-linux-tdep.c
4411         (aarch64_linux_core_read_description): Likewise.
4412         (aarch64_linux_get_hwcap): New function.
4413         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4414         (aarch64_linux_get_hwcap): New declaration.
4415
4416 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4417             Jiong Wang  <jiong.wang@arm.com>
4418
4419         * aarch64-linux-nat.c
4420         (aarch64_linux_nat_target::read_description): Add pauth param.
4421         * aarch64-linux-tdep.c
4422         (aarch64_linux_core_read_description): Likewise.
4423         * aarch64-tdep.c (struct target_desc): Add in pauth.
4424         (aarch64_read_description): Add pauth param.
4425         (aarch64_gdbarch_init): Likewise.
4426         * aarch64-tdep.h (aarch64_read_description): Likewise.
4427         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4428         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4429         * features/Makefile: Add new files.
4430         * features/aarch64-pauth.c: New file.
4431         * features/aarch64-pauth.xml: New file.
4432
4433 2019-03-20  Tom Tromey  <tromey@adacore.com>
4434
4435         * infrun.c (handle_inferior_event): Rename from
4436         handle_inferior_event_1.  Create a scoped_value_mark.
4437         (handle_inferior_event): Remove.
4438
4439 2019-03-19  Tom Tromey  <tromey@adacore.com>
4440
4441         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4442         * infrun.h (print_stop_event): Add "displays" parameter.
4443         * infrun.c (print_stop_event): Add "displays" parameter.
4444
4445 2019-03-19  Pedro Alves  <palves@redhat.com>
4446
4447         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4448         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4449         to -1.  Fix TABs vs spaces.
4450         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4451         * tui/tui-out.h (tui_ui_out) Add intro comments.
4452         <m_line, m_start_of_line>: In-class initialize, and add describing
4453         comment.
4454
4455 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4456
4457         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4458         variable names.
4459         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4460
4461 2019-03-18  Pedro Alves  <palves@redhat.com>
4462             Eli Zaretskii <eliz@gnu.org>
4463
4464         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4465         m_line and m_start_of_line.
4466
4467 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4468
4469         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4470         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4471         it returns a newline.  This fixes a regression in TU mode, whereby
4472         the next line is output on the same screen line as the user input.
4473
4474 2019-03-18  Tom Tromey  <tromey@adacore.com>
4475
4476         * minsyms.c (minimal_symbol_reader::install): Remove call to
4477         obstack_blank.
4478
4479 2019-03-18  Pedro Alves  <palves@redhat.com>
4480
4481         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4482         New globals.
4483         (apply_style): New, factored out from ...
4484         (apply_ansi_escape): ... this.  Handle reverse video mode.
4485         (tui_set_reverse_mode): New function.
4486         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4487         * tui/tui-winsource.c (tui_show_source_line): Use
4488         tui_set_reverse_mode instead of setting A_STANDOUT.
4489         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4490         New setter methods.
4491
4492 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4493
4494         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4495         Handle tabs.
4496
4497 2019-03-18  Tom Tromey  <tromey@adacore.com>
4498
4499         * ada-lang.c (empty_array): Add "high" parameter.
4500         (ada_evaluate_subexp): Update.
4501
4502 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4503
4504         * unittests/string_view-selftests.c: Define
4505         _initialize_string_view_selftests unconditionally.
4506
4507 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4508
4509         PR gdb/24350
4510         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4511
4512 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4513
4514         PR gdb/24351
4515         * windows-nat.c (display_selector): Fix format specifiers.
4516
4517 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4518
4519         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4520         tui_refill_source_window instead of tui_refresh_win, to update the
4521         current execution line.  This fixes redisplay of the current line
4522         when stepping through the code with "next" or "step".
4523
4524 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4525
4526         * source-cache.c (source_cache::get_source_lines): Call
4527         find_source_lines to initialize s->nlines.  This fixes vertical
4528         scrolling of TUI source window when the DOWN arrow is pressed.
4529
4530 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4531
4532         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4533         linux-thread-db.c (_initialize_thread_db): Likewise.
4534
4535 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4536
4537         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4538         wclrtoeol in tui_show_source_line".  This reverts changes made in
4539         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4540
4541 2019-03-15  Tom Tromey  <tom@tromey.com>
4542
4543         * symtab.h (struct minimal_symbol): Derive from
4544         general_symbol_info.
4545         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4546         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4547         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4548         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4549         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4550         (MSYMBOL_SEARCH_NAME): Update.
4551         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4552         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4553         * minsyms.c (minimal_symbol_reader::record_full): Update.
4554
4555 2019-03-15  Tom Tromey  <tom@tromey.com>
4556
4557         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4558
4559 2019-03-15  Tom Tromey  <tom@tromey.com>
4560
4561         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4562         unique_xmalloc_ptr.
4563         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4564         Update.
4565         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4566         (build_minimal_symbol_hash_tables)
4567         (minimal_symbol_reader::install): Update.
4568
4569 2019-03-15  Tom Tromey  <tom@tromey.com>
4570
4571         * symtab.c (create_demangled_names_hash): Update.
4572         (symbol_set_names): Update.
4573         * objfiles.h (struct objfile_per_bfd_storage)
4574         <demangled_names_hash>: Now an htab_up.
4575         * objfiles.c (objfile_per_bfd_storage): Simplify.
4576
4577 2019-03-15  Tom Tromey  <tom@tromey.com>
4578
4579         * objfiles.h (struct objfile_per_bfd_storage): Declare
4580         destructor.
4581         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4582         New.
4583         (get_objfile_bfd_data): Use new.  Don't initialize
4584         language_of_main.
4585         (free_objfile_per_bfd_storage): Remove.
4586         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4587
4588 2019-03-15  Tom Tromey  <tom@tromey.com>
4589
4590         * symfile.c (reread_symbols): Update.
4591         * objfiles.c (objfile::objfile): Update.
4592         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4593         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4594         comment.
4595         (minimal_symbol_reader::install): Update.
4596         (terminate_minimal_symbol_table): Remove.
4597         * jit.c (jit_object_close_impl): Update.
4598
4599 2019-03-15  Tom Tromey  <tom@tromey.com>
4600
4601         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4602         initializations.
4603
4604 2019-03-15  Tom Tromey  <tom@tromey.com>
4605
4606         * objfiles.h (struct objfile_per_bfd_storage)
4607         <demangled_hash_languages>: Now a bitset.
4608         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4609         (lookup_minimal_symbol): Update.
4610
4611 2019-03-15  Tom Tromey  <tom@tromey.com>
4612
4613         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4614         Don't return the symbol.
4615         * coffread.c (record_minimal_symbol): Use record_full.
4616
4617 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4618
4619         The MS-Windows port of ncurses fails to switch to a color pair if
4620         one or both of the colors are the implicit default colors.  This
4621         change records the default colors when TUI is initialized, and
4622         then specifies them explicitly when a color pair uses the default
4623         colors.  This allows color styling in TUI mode on MS-Windows.
4624
4625         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4626         ncurses_norm_attr.
4627         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4628         colors in ncurses_norm_attr.
4629         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4630         "none", replace it with the default color recorded in
4631         ncurses_norm_attr.
4632
4633 2019-03-14  Tom Tromey  <tromey@adacore.com>
4634
4635         * source-cache.h (class source_cache) <get_source_lines>: Return
4636         std::string.
4637         * source-cache.c (source_cache::extract_lines): Handle case where
4638         first_pos==npos.  Return std::string.
4639         (source_cache::get_source_lines): Update.
4640
4641 2019-03-14  Tom Tromey  <tromey@adacore.com>
4642
4643         * NEWS: Add item for "style sources" commands.
4644         * source-cache.c (source_cache::get_source_lines): Check
4645         source_styling.
4646         * cli/cli-style.c (source_styling): New global.
4647         (_initialize_cli_style): Add "style sources" commands.
4648         (show_style_sources): New function.
4649         * cli/cli-style.h (source_styling): Declare.
4650
4651 2019-03-14  Pedro Alves  <palves@redhat.com>
4652             Tom Tromey  <tromey@adacore.com>
4653
4654         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4655         * tui/tui-winsource.c (tui_refill_source_window): New function,
4656         from...
4657         (tui_horizontal_source_scroll): ... here.  Move some logic.
4658         * cli/cli-style.c (set_style_enabled): Notify new observable.
4659         * tui/tui-hooks.c (tui_redisplay_source): New function.
4660         (tui_attach_detach_observers): Attach or detach
4661         tui_redisplay_source.
4662         * observable.h (source_styling_changed): New observable.
4663         * observable.c: Define source_styling_changed observable.
4664
4665 2019-03-13  Tom Tromey  <tromey@adacore.com>
4666
4667         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4668         (i386_gnu_nat_target::store_registers): Update.
4669         * target-debug.h (target_debug_print_std_string): New macro.
4670         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4671         * windows-tdep.c (display_one_tib): Update.
4672         * tui/tui-stack.c (tui_make_status_line): Update.
4673         * top.c (print_inferior_quit_action): Update.
4674         * thread.c (thr_try_catch_cmd): Update.
4675         (add_thread_with_info): Update.
4676         (thread_target_id_str): Update.
4677         (thr_try_catch_cmd): Update.
4678         (thread_command): Update.
4679         (thread_find_command): Update.
4680         * record-btrace.c (record_btrace_target::info_record)
4681         (record_btrace_resume_thread, record_btrace_target::resume)
4682         (record_btrace_cancel_resume, record_btrace_step_thread)
4683         (record_btrace_target::wait, record_btrace_target::wait)
4684         (record_btrace_target::wait, record_btrace_target::stop): Update.
4685         * progspace.c (print_program_space): Update.
4686         * process-stratum-target.c
4687         (process_stratum_target::thread_address_space): Update.
4688         * linux-fork.c (linux_fork_mourn_inferior)
4689         (detach_checkpoint_command, info_checkpoints_command)
4690         (linux_fork_context): Update.
4691         (linux_fork_detach): Update.
4692         (class scoped_switch_fork_info): Update.
4693         (delete_checkpoint_command): Update.
4694         * infrun.c (follow_fork_inferior): Update.
4695         (follow_fork_inferior): Update.
4696         (proceed_after_vfork_done): Update.
4697         (handle_vfork_child_exec_or_exit): Update.
4698         (follow_exec): Update.
4699         (displaced_step_prepare_throw): Update.
4700         (displaced_step_restore): Update.
4701         (start_step_over): Update.
4702         (resume_1): Update.
4703         (clear_proceed_status_thread): Update.
4704         (proceed): Update.
4705         (print_target_wait_results): Update.
4706         (do_target_wait): Update.
4707         (context_switch): Update.
4708         (stop_all_threads): Update.
4709         (restart_threads): Update.
4710         (finish_step_over): Update.
4711         (handle_signal_stop): Update.
4712         (switch_back_to_stepped_thread): Update.
4713         (keep_going_pass_signal): Update.
4714         (print_exited_reason): Update.
4715         (normal_stop): Update.
4716         * inferior.c (inferior_pid_to_str): Change return type.
4717         (print_selected_inferior): Update.
4718         (add_inferior): Update.
4719         (detach_inferior): Update.
4720         * dummy-frame.c (fprint_dummy_frames): Update.
4721         * dcache.c (dcache_info_1): Update.
4722         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4723         (btrace_fetch, btrace_clear): Update.
4724         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4725         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4726         type.
4727         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4728         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4729         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4730         * gdbarch.c, gdbarch.h: Rebuild.
4731         * gdbarch.sh (core_pid_to_str): Change return type.
4732         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4733         return type.
4734         (windows_nat_target::pid_to_str): Change return type.
4735         (windows_delete_thread): Update.
4736         (windows_nat_target::attach): Update.
4737         (windows_nat_target::files_info): Update.
4738         * target-delegates.c: Rebuild.
4739         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4740         return type.
4741         (sol_thread_target::pid_to_str): Change return type.
4742         * remote.c (class remote_target) <pid_to_str>: Change return
4743         type.
4744         (remote_target::pid_to_str): Change return type.
4745         (extended_remote_target::attach, remote_target::remote_stop_ns)
4746         (remote_target::remote_notif_remove_queued_reply)
4747         (remote_target::push_stop_reply, remote_target::disable_btrace):
4748         Update.
4749         (extended_remote_target::attach): Update.
4750         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4751         type.
4752         (gdbsim_target::pid_to_str): Change return type.
4753         * ravenscar-thread.c (struct ravenscar_thread_target)
4754         <pid_to_str>: Change return type.
4755         (ravenscar_thread_target::pid_to_str): Change return type.
4756         * procfs.c (class procfs_target) <pid_to_str>: Change return
4757         type.
4758         (procfs_target::pid_to_str): Change return type.
4759         (procfs_target::attach): Update.
4760         (procfs_target::detach): Update.
4761         (procfs_target::fetch_registers): Update.
4762         (procfs_target::store_registers): Update.
4763         (procfs_target::wait): Update.
4764         (procfs_target::files_info): Update.
4765         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4766         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4767         return type.
4768         (nto_procfs_target::pid_to_str): Change return type.
4769         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4770         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4771         return type.
4772         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4773         (exit_lwp): Update.
4774         (attach_proc_task_lwp_callback, get_detach_signal)
4775         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4776         (linux_nat_target::resume, wait_lwp, stop_callback)
4777         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4778         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4779         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4780         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4781         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4782         type.
4783         (inf_ptrace_target::attach): Update.
4784         (inf_ptrace_target::files_info): Update.
4785         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4786         type.
4787         (go32_nat_target::pid_to_str): Change return type.
4788         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4789         (gnu_nat_target::wait): Update.
4790         (gnu_nat_target::wait): Update.
4791         (gnu_nat_target::resume): Update.
4792         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4793         (fbsd_nat_target::wait): Update.
4794         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4795         type.
4796         (darwin_nat_target::attach): Update.
4797         * corelow.c (class core_target) <pid_to_str>: Change return type.
4798         (core_target::pid_to_str): Change return type.
4799         * target.c (normal_pid_to_str): Change return type.
4800         (default_pid_to_str): Likewise.
4801         (target_pid_to_str): Change return type.
4802         (target_translate_tls_address): Update.
4803         (target_announce_detach): Update.
4804         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4805         return type.
4806         (bsd_uthread_target::pid_to_str): Change return type.
4807         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4808         type.
4809         (bsd_kvm_target::pid_to_str): Change return type.
4810         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4811         return type.
4812         (aix_thread_target::pid_to_str): Change return type.
4813         * target.h (struct target_ops) <pid_to_str>: Change return type.
4814         (target_pid_to_str, normal_pid_to_str): Likewise.
4815         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4816         type.
4817         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4818         type.
4819         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4820         return type.
4821         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4822         type.
4823         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4824         type.
4825         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4826         return type.
4827
4828 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4829
4830         * NEWS: Mention that the new default MI version is 3.  Mention
4831         changes to the output of commands and events that deal with
4832         multi-location breakpoints.
4833         * breakpoint.c: Include "mi/mi-out.h".
4834         (print_one_breakpoint): Change output syntax if using MI version
4835         >= 3.
4836         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4837         New.
4838         (mi_multi_location_breakpoint_output_fixed): New.
4839         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4840         (mi_cmd_fix_multi_location_breakpoint_output): New.
4841         (mi_multi_location_breakpoint_output_fixed): New.
4842         * mi/mi-cmds.c (mi_cmds): Register command
4843         -fix-multi-location-breakpoint-output.
4844         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4845         interpreter "mi".
4846
4847 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4848
4849         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4850         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4851         instantiate mi_ui_out based on interpreter name.
4852         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4853         * mi/mi-main.c (mi_load_progress): Likewise.
4854
4855 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4856
4857         * NEWS: Combine separate "New targets" sections for 8.3.
4858
4859 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4860
4861         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4862         (ppcfbsd_init_abi): Install gdbarch
4863         "fetch_tls_load_module_address" and "get_thread_local_address"
4864         methods.
4865
4866 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4867
4868         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4869         (riscv_fbsd_init_abi): Install gdbarch
4870         "fetch_tls_load_module_address" and "get_thread_local_address"
4871         methods.
4872
4873 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4874
4875         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4876         (i386fbsd_init_abi): Install gdbarch
4877         "fetch_tls_load_module_address" and "get_thread_local_address"
4878         methods.
4879
4880 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4881
4882         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4883         (amd64fbsd_init_abi): Install gdbarch
4884         "fetch_tls_load_module_address" and "get_thread_local_address"
4885         methods.
4886
4887 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4888
4889         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4890         (struct fbsd_pspace_data): New type.
4891         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4892         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4893         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4894         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4895         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4896
4897 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4898
4899         * gdbtypes.c (lookup_struct_elt): New function.
4900         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4901         * gdbtypes.h (struct struct_elt): New type.
4902         (lookup_struct_elt): New prototype.
4903
4904 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4905
4906         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4907         remove disabled code block.
4908
4909 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4910
4911         * gdbarch.sh (get_thread_local_address): New method.
4912         * gdbarch.h, gdbarch.c: Regenerate.
4913         * target.c (target_translate_tls_address): Use
4914         gdbarch_get_thread_local_address if present instead of
4915         target::get_thread_local_address.
4916
4917 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4918
4919         * target.h (target::get_thread_local_address): Update comment.
4920
4921 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4922
4923         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4924         objfile->separate_debug_objfile_backlink if not NULL.
4925
4926 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4927
4928         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4929         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4930         (amd64bsd_store_inferior_registers): Likewise.
4931         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4932         Enable segment base registers.
4933         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4934         PT_GETFSBASE and PT_GETGSBASE.
4935         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4936         PT_SETGSBASE.
4937         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4938         segment base registers.
4939         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4940
4941 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4942
4943         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4944         Update calls to i386_target_description to add 'segments'
4945         parameter.
4946         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4947         add segment base registers.
4948         * arch/i386.c (i386_create_target_description): Add 'segments'
4949         parameter to enable segment base registers.
4950         * arch/i386.h (i386_create_target_description): Likewise.
4951         * features/i386/32bit-segments.xml: New file.
4952         * features/i386/32bit-segments.c: Generate.
4953         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4954         call to i386_target_description to add 'segments' parameter.
4955         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4956         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4957         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4958         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4959         if feature is present.
4960         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4961         Add 'segments' parameter to call to i386_target_description.
4962         (i386_target_description): Add 'segments' parameter to enable
4963         segment base registers.
4964         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4965         to call to i386_target_description.
4966         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4967         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4968         Define I386_NUM_REGS.
4969         (i386_target_description): Add 'segments' parameter to enable
4970         segment base registers.
4971
4972 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4973
4974         PR/24325
4975         * source-cache.c: #undef open and close, to avoid unresolved
4976         externals during linking.
4977
4978 2019-03-12  Tom Tromey  <tromey@adacore.com>
4979
4980         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4981         const.  Add initializers.
4982         (_initialize_remote): Don't initialize ptid globals.
4983
4984 2019-03-12  Pedro Alves  <palves@redhat.com>
4985
4986         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4987
4988 2019-03-12  Pedro Alves  <palves@redhat.com>
4989
4990         * cp-name-parser.y (main): Remove unused 'len' variable.
4991
4992 2019-03-12  Tom Tromey  <tromey@adacore.com>
4993
4994         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4995         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4996
4997 2019-03-12  Tom Tromey  <tromey@adacore.com>
4998
4999         * linux-nat.c (iterate_over_lwps): Update.
5000         (stop_callback): Remove parameter.
5001         (stop_wait_callback, detach_callback, resume_set_callback)
5002         (select_singlestep_lwp_callback, set_ignore_sigint)
5003         (status_callback, resumed_callback, resume_clear_callback)
5004         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5005         data parameter.
5006         (linux_nat_target::detach, linux_nat_target::resume)
5007         (linux_stop_and_wait_all_lwps, select_event_lwp)
5008         (linux_nat_filter_event, linux_nat_wait_1)
5009         (linux_nat_target::kill, linux_nat_target::stop)
5010         (linux_nat_target::stop): Update.
5011         (linux_nat_resume_callback): Change type.
5012         (resume_stopped_resumed_lwps, count_events_callback)
5013         (select_event_lwp_callback): Likewise.
5014         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5015         * arm-linux-nat.c (struct update_registers_data): Remove.
5016         (update_registers_callback): Change type.
5017         (arm_linux_insert_hw_breakpoint1): Update.
5018         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5019         parameter.
5020         (x86_linux_dr_set_addr): Update.
5021         (x86_linux_dr_set_control): Update.
5022         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5023         (iterate_over_lwps): Use gdb::function_view.
5024         * nat/aarch64-linux-hw-point.c (struct
5025         aarch64_dr_update_callback_param): Remove.
5026         (debug_reg_change_callback): Change type.
5027         (aarch64_notify_debug_reg_change): Update.
5028         * s390-linux-nat.c (s390_refresh_per_info): Update.
5029
5030 2019-03-11  Tom Tromey  <tromey@adacore.com>
5031
5032         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5033         redundant assignment to "this_cu".
5034
5035 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5036
5037         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5038
5039 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5040
5041         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5042         from...
5043         (rank_one_type): ... this.
5044
5045 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5046
5047         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5048         from...
5049         (rank_one_type): ... this.
5050
5051 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5052
5053         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5054         from...
5055         (rank_one_type): ... this.
5056
5057 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5058
5059         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5060         from...
5061         (rank_one_type): ... this.
5062
5063 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5064
5065         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5066         from...
5067         (rank_one_type): ... this.
5068
5069 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5070
5071         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5072         from...
5073         (rank_one_type): ... this.
5074
5075 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5076
5077         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5078         from...
5079         (rank_one_type): ... this.
5080
5081 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5082
5083         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5084         from...
5085         (rank_one_type): ... this.
5086
5087 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5088
5089         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5090         from...
5091         (rank_one_type): ... this.
5092
5093 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5094
5095         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5096         from...
5097         (rank_one_type): ... this.
5098
5099 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5100
5101         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5102         from...
5103         (rank_one_type): ... this.
5104
5105 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5106
5107         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5108         from...
5109         (rank_one_type): ... this.
5110
5111 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5112
5113         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5114         inferior-events' shows the example events.
5115
5116 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5117
5118         Support styling on native MS-Windows console
5119
5120         PR/24315
5121         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5122         on MS-Windows if $TERM is not defined.
5123
5124         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5125
5126         * posix-hdep.c (gdb_console_fputs):
5127         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5128         functions.
5129         * ui-file.h (gdb_console_fputs): Add prototype.
5130
5131         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5132         back to fputs only if the former returns zero.
5133
5134 2019-03-07  Tom Tromey  <tom@tromey.com>
5135
5136         * symmisc.c (print_symbol_bcache_statistics): Update.
5137         (print_objfile_statistics): Update.
5138         * symfile.c (allocate_symtab): Update.
5139         * stabsread.c: Don't include bcache.h.
5140         * psymtab.h (struct psymbol_bcache): Don't declare.
5141         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5142         (psymbol_bcache_init, psymbol_bcache_free)
5143         (psymbol_bcache_get_bcache): Don't declare.
5144         * psymtab.c (struct psymbol_bcache): Remove.
5145         (psymtab_storage::psymtab_storage): Update.
5146         (psymtab_storage::~psymtab_storage): Update.
5147         (psymbol_bcache_init, psymbol_bcache_free)
5148         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5149         (add_psymbol_to_bcache): Update.
5150         (allocate_psymtab): Update.
5151         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5152         macro_cache>: No longer pointers.
5153         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5154         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5155         * macrotab.c (macro_bcache): Update.
5156         * macroexp.c: Don't include bcache.h.
5157         * gdbtypes.c (check_types_worklist): Update.
5158         (types_deeply_equal): Remove TRY/CATCH.  Update.
5159         * elfread.c (elf_symtab_read): Update.
5160         * dwarf2read.c: Don't include bcache.h.
5161         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5162         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5163         (print_bcache_statistics, bcache_memory_used): Don't declare.
5164         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5165         methods.  Rename all data members.
5166         * bcache.c (struct bcache): Move to bcache.h.
5167         (bcache::expand_hash_table): Rename from expand_hash_table.
5168         (bcache): Remove.
5169         (bcache::insert): Rename from bcache_full.
5170         (bcache::compare): Rename from bcache_compare.
5171         (bcache_xmalloc): Remove.
5172         (bcache::~bcache): Rename from bcache_xfree.
5173         (bcache::print_statistics): Rename from print_bcache_statistics.
5174         (bcache::memory_used): Rename from bcache_memory_used.
5175
5176 2019-03-07  Pedro Alves  <palves@redhat.com>
5177
5178         * infrun.c (normal_stop): Also check for
5179         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5180
5181 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5182
5183         * f-lang.c (value_from_host_double): Moved to...
5184         * value.c (value_from_host_double): ...here.
5185         * value.h (value_from_host_double): Declare.
5186         * guile/scm-math.c (vlscm_convert_typed_number): Use
5187         value_from_host_double.
5188         (vlscm_convert_number): Likewise.
5189         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5190         * python/py-value.c (convert_value_from_python): Likewise.
5191
5192 2019-03-06  Tom Tromey  <tom@tromey.com>
5193
5194         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5195
5196 2019-03-06  Tom Tromey  <tom@tromey.com>
5197
5198         * utils.h (free_current_contents): Don't declare.
5199         * utils.c (free_current_contents): Remove.
5200
5201 2019-03-06  Tom Tromey  <tom@tromey.com>
5202
5203         * top.c (quit_force): Update.
5204         * main.c (captured_command_loop): Update.
5205         * common/new-op.c (operator new): Update.
5206         * common/common-exceptions.c (struct catcher)
5207         <save_cleanup_chain>: Remove member.
5208         (exceptions_state_mc_init): Update.
5209         (exception_try_scope_entry): Return nullptr.
5210         (exception_try_scope_exit, exception_rethrow)
5211         (throw_exception_sjlj, throw_exception_cxx): Update.
5212         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5213         (all_cleanups, do_cleanups, discard_cleanups)
5214         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5215         (restore_cleanups, restore_final_cleanups): Don't declare.
5216         (do_final_cleanups): Remove parameter.
5217         * common/cleanups.c (cleanup_chain, make_cleanup)
5218         (make_cleanup_dtor, all_cleanups, do_cleanups)
5219         (discard_my_cleanups, discard_cleanups)
5220         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5221         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5222         (null_cleanup): Remove.
5223         (do_final_cleanups): Remove parameter.
5224
5225 2019-03-06  Tom Tromey  <tom@tromey.com>
5226
5227         * remote.c (remote_target::remote_parse_stop_reply): Use
5228         unique_xmalloc_ptr.
5229
5230 2019-03-06  Tom Tromey  <tom@tromey.com>
5231
5232         * stabsread.c (struct stabs_field_info): Rename from field_info.
5233         <list, fnlist>: Add initializers.
5234         <obstack>: New member.
5235         (read_member_functions, read_struct_fields, read_baseclasses):
5236         Allocate on obstack.  Don't use cleanups.
5237         (read_one_struct_field, read_member_functions, read_struct_fields)
5238         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5239         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5240         (read_struct_type): Update.
5241
5242 2019-03-06  Tom Tromey  <tom@tromey.com>
5243
5244         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5245         * common/filestuff.h (make_cleanup_close): Don't declare.
5246         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5247         Remove.
5248
5249 2019-03-06  Tom Tromey  <tom@tromey.com>
5250
5251         * solib-aix.c: Use make_scope_exit.
5252
5253 2019-03-06  Tom Tromey  <tom@tromey.com>
5254
5255         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5256         Use make_scope_exit.
5257
5258 2019-03-06  Tom Tromey  <tom@tromey.com>
5259
5260         * solib-svr4.c (disable_probes_interface): Remove parameter.
5261         (svr4_handle_solib_event): Use make_scope_exit.
5262
5263 2019-03-06  Tom Tromey  <tom@tromey.com>
5264
5265         * remote.c (struct stop_reply_deleter): Remove.
5266         (stop_reply_up): Update.
5267         (struct stop_reply): Derive from notif_event.  Don't typedef.
5268         <regcache>: Now a std::vector.
5269         (stop_reply_xfree): Remove.
5270         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5271         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5272         (remote_target::discard_pending_stop_replies): Use delete.
5273         (remote_target::remote_parse_stop_reply): Update.
5274         (remote_target::process_stop_reply): Update.
5275         * remote-notif.h (struct notif_event): Add virtual destructor.
5276         Remove "dtr" member.
5277         (struct notif_client) <alloc_event>: Return a unique_ptr.
5278         (notif_event_xfree): Don't declare.
5279         (notif_event_up): New typedef.
5280         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5281         (notif_event_xfree, do_notif_event_xfree): Remove.
5282         (remote_notif_state_xfree): Update.
5283
5284 2019-03-06  Tom Tromey  <tom@tromey.com>
5285
5286         * infrun.c (displaced_step_clear_cleanup): Now a
5287         forward_scope_exit type.
5288         (displaced_step_prepare_throw): Update.
5289         (displaced_step_fixup): Update.
5290
5291 2019-03-06  Tom Tromey  <tom@tromey.com>
5292
5293         * inferior.h (class inferior): Update comment.
5294         * gdbthread.h (class thread_info): Update comment.
5295
5296 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5297             Tom Tromey  <tom@tromey.com>
5298
5299         * stabsread.h (struct stab_section_list): Remove.
5300         (coffstab_build_psymtabs): Update.
5301         * dbxread.c (symbuf_sections): Now a std::vector.
5302         (sect_idx): New global.
5303         (fill_symbuf): Update.
5304         (coffstab_build_psymtabs): Change type of stabsects parameter.
5305         Update.
5306         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5307         std::vector.
5308         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5309         (coff_locate_sections): Update.
5310         (coff_symfile_read): Remove cleanups.  Update.
5311         (init_stringtab): Add storage parameter.
5312         (free_stringtab, free_stringtab_cleanup): Remove.
5313         (init_lineno): Add storage parameter.
5314         (free_linetab, free_linetab_cleanup): Remove.
5315
5316 2019-03-06  Pedro Alves  <palves@redhat.com>
5317
5318         * linux-fork.c (fork_info::clobber_regs): Delete.
5319         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5320         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5321         comment.  Adjust.
5322         (scoped_switch_fork_info::scoped_switch_fork_info)
5323         (checkpoint_command, linux_fork_context): Adjust
5324         fork_save_infrun_state calls.
5325
5326 2019-03-06  Pedro Alves  <palves@redhat.com>
5327
5328         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5329         (inf_has_multiple_threads): Return 'bool' and rewrite using
5330         inferior_info::threads().
5331
5332 2019-03-06  Pedro Alves  <palves@redhat.com>
5333
5334         * linux-fork.c: Include <list>.
5335         (fork_list): Now a std::list instance.
5336         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5337         (forks_exist_p, find_last_fork): Adjust.
5338         (new_fork): Delete.
5339         (one_fork_p): New.
5340         (add_fork): Adjust.
5341         (free_fork): Delete, folded into fork_info::~fork_info().
5342         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5343         Adjust.
5344         (init_fork_list): Delete.
5345         (linux_fork_killall, linux_fork_mourn_inferior)
5346         (linux_fork_detach, info_checkpoints_command): Adjust.
5347         (_initialize_linux_fork): No longer call init_fork_list.
5348
5349 2019-03-06  Pedro Alves  <palves@redhat.com>
5350
5351         * linux-fork.c (new_fork): New, split out of ...
5352         (add_fork): ... this.  Return void.  Move "first fork" special
5353         case from here, to ...
5354         (checkpoint_command): ... here.
5355         * linux-linux.h (add_fork): Return void.
5356
5357 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5358
5359         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5360
5361 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5362             Chris January  <chris.january@arm.com>
5363             David Lecomber  <david.lecomber@arm.com>
5364
5365         * f-exp.y: New token, UNOP_INTRINSIC.
5366         (exp): New pattern using UNOP_INTRINSIC token.
5367         (f77_keywords): Add 'abs' keyword.
5368         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5369         (value_from_host_double): New function.
5370         (evaluate_subexp_f): Support UNOP_ABS.
5371
5372 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5373
5374         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5375         types.
5376
5377 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5378
5379         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5380         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5381         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5382
5383 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5384
5385         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5386
5387 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5388             Chris January  <chris.january@arm.com>
5389
5390         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5391         * f-exp.y: Define 'KIND' token.
5392         (exp): New pattern for KIND expressions.
5393         (ptype): Handle types with a kind extension.
5394         (direct_abs_decl): Extend to spot kind extensions.
5395         (f77_keywords): Add 'kind' to the list.
5396         (push_kind_type): New function.
5397         (convert_to_kind_type): New function.
5398         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5399         * parse.c (operator_length_standard): Likewise.
5400         * parser-defs.h (enum type_pieces): Add tp_kind.
5401         * std-operator.def: Add UNOP_KIND.
5402
5403 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5404
5405         * f-exp.y (f_parse): Set yydebug.
5406
5407 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5408
5409         * f-lang.c (evaluate_subexp_f): New function.
5410         (exp_descriptor_f): New global.
5411         (f_language_defn): Use exp_descriptor_f instead of
5412         exp_descriptor_standard.
5413
5414 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5415
5416         * f-exp.y (struct token): Add comments.
5417         (dot_ops): Remove uppercase versions and the end marker.
5418         (f77_keywords): Likewise.
5419         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5420         entries in the dot_ops array are case insensitive, and use
5421         strncasecmp to compare strings.  Also some whitespace cleanup in
5422         this area.  Similar for the f77_keywords array, except entries in
5423         this list might be case sensitive.
5424
5425 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5426
5427         * f-exp.y (struct f77_boolean_val): Add comments.
5428         (boolean_values): Remove uppercase versions, and end marker.
5429         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5430         and use strncasecmp to achieve case insensitivity.  Additionally,
5431         perform whitespace cleanup around this code.
5432
5433 2019-03-06  Tom Tromey  <tromey@adacore.com>
5434
5435         * remote-sim.c (gdbsim_target_open): Use result of
5436         gdb_argv::release.
5437
5438 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5439         Dirk Schubert  <dirk.schubert@arm.com>
5440         Chris January  <chris.january@arm.com>
5441
5442         * eval.c (evaluate_subexp_standard): Call Fortran argument
5443         wrapping logic.
5444         * f-lang.c (struct value): A value which can be passed into a
5445         Fortran function call.
5446         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5447         where appropriate.
5448         (struct type): Value ready for a Fortran function call.
5449         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5450         is needed.
5451         * f-lang.h (fortran_argument_convert): Declaration.
5452         (fortran_preserve_arg_pointer): Declaration.
5453         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5454
5455 2019-03-05  Tom Tromey  <tromey@adacore.com>
5456
5457         * python/py-prettyprint.c (print_string_repr): Remove #if.
5458         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5459
5460 2019-03-05  Tom Tromey  <tromey@adacore.com>
5461
5462         * target.c (the_dummy_target): Move later.  Change type to
5463         "dummy_target".
5464         (initialize_targets): Don't initialize the_dummy_target.
5465
5466 2019-03-05  Tom Tromey  <tromey@adacore.com>
5467
5468         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5469         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5470
5471 2019-03-05  Tom Tromey  <tromey@adacore.com>
5472
5473         * windows-nat.c (windows_nat_target::attach)
5474         (windows_nat_target::detach): Don't call gdb_flush.
5475         * valprint.c (generic_val_print, val_print, val_print_string):
5476         Don't call gdb_flush.
5477         * utils.c (defaulted_query): Don't call gdb_flush.
5478         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5479         * target.c (target_announce_detach): Don't call gdb_flush.
5480         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5481         * remote.c (extended_remote_target::attach): Don't call
5482         gdb_flush.
5483         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5484         * printcmd.c (do_examine): Don't call gdb_flush.
5485         (info_display_command): Don't call gdb_flush.
5486         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5487         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5488         * memattr.c (info_mem_command): Don't call gdb_flush.
5489         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5490         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5491         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5492         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5493         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5494         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5495         (gnu_nat_target::detach): Don't call gdb_flush.
5496         * f-valprint.c (f_val_print): Don't call gdb_flush.
5497         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5498         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5499         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5500         gdb_flush.
5501         * c-valprint.c (c_val_print): Don't call gdb_flush.
5502         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5503
5504 2019-03-05  Tom Tromey  <tromey@adacore.com>
5505
5506         * varobj.c (update_dynamic_varobj_children): Update.
5507         (install_default_visualizer): Use reset, not release.
5508         * value.c (set_internalvar): Update.
5509         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5510         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5511         ATTRIBUTE_UNUSED_RESULT.
5512
5513 2019-03-05  Tom Tromey  <tromey@adacore.com>
5514
5515         * remote.c (class scoped_remote_fd) <release>: Add
5516         ATTRIBUTE_UNUSED_RESULT.
5517
5518 2019-03-05  Tom Tromey  <tromey@adacore.com>
5519
5520         * macroexp.c (struct macro_buffer) <release>: Add
5521         ATTRIBUTE_UNUSED_RESULT.
5522
5523 2019-03-05  Tom Tromey  <tromey@adacore.com>
5524
5525         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5526         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5527         ATTRIBUTE_UNUSED_RESULT.
5528
5529 2019-03-05  Tom Tromey  <tromey@adacore.com>
5530
5531         * common/scoped_fd.h (class scoped_fd) <release>: Add
5532         ATTRIBUTE_UNUSED_RESULT.
5533
5534 2019-03-05  Tom Tromey  <tromey@adacore.com>
5535
5536         * parser-defs.h (struct parser_state) <release>: Add
5537         ATTRIBUTE_UNUSED_RESULT.
5538
5539 2019-03-05  Tom Tromey  <tromey@adacore.com>
5540
5541         * utils.h (class gdb_argv) <release>: Add
5542         ATTRIBUTE_UNUSED_RESULT.
5543         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5544
5545 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5546
5547         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5548         for-loop range, to avoid compiler warnings.
5549
5550         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5551         avoid compiler warnings about unused variables.
5552
5553         * NEWS: Mention end of support for native debugging on MS-Windows
5554         before XP.
5555
5556         PR gdb/24292
5557         * common/netstuff.c:
5558         * gdbserver/gdbreplay.c
5559         * gdbserver/remote-utils.c:
5560         * ser-tcp.c:
5561         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5562         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5563         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5564         'getaddrinfo' and 'freeaddrinfo' were not available before
5565         Windows XP, and mingw.org's MinGW headers by default define
5566         _WIN32_WINNT to 0x500.
5567
5568 2019-03-01  Gary Benson <gbenson@redhat.com>
5569
5570         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5571
5572 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5573             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5574
5575         PR gdb/8527
5576         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5577         set_sigint_trap, clear_sigint_trap.
5578
5579 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5580
5581         * target.c (target_detach): Clear the regcache and the
5582         frame cache.
5583
5584 2019-02-27  Pedro Alves  <palves@redhat.com>
5585
5586         * utils.c (set_screen_size): When we cap the height/width sizes,
5587         tweak the corresponding command variable to show "unlimited":
5588
5589 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5590             Pedro Alves  <palves@redhat.com>
5591
5592         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5593         before calling rl_set_screen_size.
5594
5595 2019-02-27  Tom Tromey  <tromey@adacore.com>
5596
5597         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5598         define.
5599         * python/py-value.c: Remove Python 2.4 workaround.
5600         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5601         workaround.
5602         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5603         Python 2.4 workaround.
5604         * python/python-internal.h: Remove Python 2.4 comment.
5605         (Py_ssize_t): Don't define.
5606         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5607         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5608         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5609         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5610         * python/python.c (do_start_initialization): Remove Python 2.4
5611         workaround.
5612         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5613         (print_children): Remove Python 2.4 workaround.
5614         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5615         workaround.
5616         (CHARBUFFERPROC_NAME): Remove.
5617         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5618         Python 2.4 workaround.
5619
5620 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5621
5622         * NEWS: Note minimum Python version.
5623
5624 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5625
5626         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5627         code from these functions.  Remove corresponding ifdefs.  Use
5628         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5629         Remove gotos and target of gotos.
5630         (infpy_search_memory): Likewise.
5631
5632 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5633
5634         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5635         (hppa_gdbarch_init): Don't register deleted functions with
5636         gdbarch.
5637
5638 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5639
5640         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5641         (h8300_unwind_sp): Delete.
5642         (h8300_dummy_id): Delete.
5643         (h8300_gdbarch_init): Don't register deleted functions with
5644         gdbarch.
5645
5646 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5647
5648         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5649         (ft32_unwind_pc): Delete.
5650         (ft32_unwind_sp): Delete.
5651         (ft32_gdbarch_init): Don't register deleted functions with
5652         gdbarch.
5653
5654 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5655
5656         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5657         (frv_unwind_pc): Delete.
5658         (frv_unwind_sp): Delete.
5659         (frv_gdbarch_init): Don't register deleted functions with
5660         gdbarch.
5661
5662 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5663
5664         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5665         (riscv_unwind_pc): Delete.
5666         (riscv_unwind_sp): Delete.
5667         (riscv_gdbarch_init): Don't register deleted functions with
5668         gdbarch.
5669
5670 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5671
5672         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5673         (csky_unwind_pc): Delete.
5674         (csky_unwind_sp): Delete.
5675         (csky_gdbarch_init): Don't register deleted functions with
5676         gdbarch.
5677
5678 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5679
5680         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5681         (cris_unwind_pc): Delete.
5682         (cris_unwind_sp): Delete.
5683         (cris_gdbarch_init): Don't register deleted functions with
5684         gdbarch.
5685
5686 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5687
5688         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5689         (bfin_unwind_pc): Delete.
5690         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5691
5692 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5693
5694         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5695         (arm_unwind_pc): Delete.
5696         (arm_unwind_sp): Delete.
5697         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5698
5699 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5700
5701         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5702         (arc_unwind_pc): Delete.
5703         (arc_unwind_sp): Delete.
5704         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5705
5706 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5707
5708         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5709         (alpha_unwind_pc): Delete.
5710         (alpha_gdbarch_init): Don't register deleted functions with
5711         gdbarch.
5712
5713 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5714
5715         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5716         (aarch64_unwind_pc): Delete.
5717         (aarch64_unwind_sp): Delete.
5718         (aarch64_gdbarch_init): Don't register deleted functions with
5719         gdbarch.
5720
5721 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5722
5723         * gdbtypes.c (type_align): Don't consider static members when
5724         computing structure alignment.
5725
5726 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5727
5728         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5729         return 0 for other types.
5730         * arch-utils.c (default_type_align): Always return 0.
5731         * gdbarch.h: Regenerate.
5732         * gdbarch.sh (type_align): Extend comment.
5733         * gdbtypes.c (type_align): Add additional comments, always call
5734         gdbarch_type_align before applying the default rules.
5735         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5736         generic code will then apply a suitable default.
5737         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5738         types, return 0 for other types.
5739
5740 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5741
5742         * NEWS: Create a new section for the next release branch.
5743         Rename the section of the current branch, now that it has
5744         been cut.
5745
5746 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5747
5748         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5749         * version.in: Bump version to 8.3.50.DATE-git.
5750
5751 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5752
5753         * aix-thread.c (ptid_cmp): Remove unused variable.
5754         (get_signaled_thread): Likewise.
5755         (store_regs_user_thread): Likewise.
5756         (store_regs_kernel_thread): Likewise.
5757         (fetch_regs_kernel_thread): Remove shadowed variable.
5758
5759 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5760
5761         * features/riscv/32bit-cpu.xml: Add register numbers.
5762         * features/riscv/32bit-fpu.c: Regenerate.
5763         * features/riscv/32bit-fpu.xml: Add register numbers.
5764         * features/riscv/64bit-cpu.xml: Add register numbers.
5765         * features/riscv/64bit-fpu.c: Regenerate.
5766         * features/riscv/64bit-fpu.xml: Add register numbers.
5767
5768 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5769
5770         * NEWS: Mention two argument form of gdb.Value constructor.
5771         * python/py-value.c (convert_buffer_and_type_to_value): New
5772         function.
5773         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5774         Add support for handling an optional second argument.  Call
5775         convert_buffer_and_type_to_value as appropriate.
5776         * python/python-internal.h (Py_buffer_deleter): New struct.
5777         (Py_buffer_up): New typedef.
5778
5779 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5780
5781         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5782         instead of releasing ownership.
5783
5784 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5785
5786         * dwarf2read.c (open_and_init_dwp_file): Call
5787         elf_numsections instead of bfd_count_sections to initialize
5788         dwp_file->num_sections.
5789
5790 2019-02-25  Tom Tromey  <tromey@adacore.com>
5791
5792         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5793
5794 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5795
5796         * gcore.in: Add '--readnever' option when invoking GDB.
5797
5798 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5799
5800         * MAINTAINERS: Update my email address.
5801
5802 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5803
5804         * build-id.c (build_id_to_debug_bfd_1): New function.
5805         (build_id_to_debug_bfd): Look for separate debug file in
5806         sysroot.
5807
5808 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5809
5810         * gdbarch.sh: Update the copyright year range that is placed into
5811         generated files.
5812
5813 2019-02-22  Keith Seitz  <keiths@redhat.com>
5814
5815         PR symtab/23853
5816         * linespec.c (create_sals_line_offset): Search for the default
5817         symtab's filename instead of its fullname.
5818
5819 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5820
5821         * NEWS: Update style defaults.
5822
5823 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5824
5825         * main.c (captured_main_1): Disable styling in batch mode.
5826
5827 2019-02-20  Tom Tromey  <tom@tromey.com>
5828
5829         * symtab.c (symtab_symbol_info): Fix typos.
5830
5831 2019-02-20  Tom Tromey  <tromey@adacore.com>
5832
5833         * findcmd.c (_initialize_mem_search): Use upper case for
5834         metasyntactic variables.
5835
5836 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5837
5838         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5839         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5840
5841 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5842
5843         * top.h (source_file_name): Change to std::string.
5844         * top.c (source_file_name): Likewise.
5845         (command_line_input): Adjust.
5846         * cli/cli-script.c (script_from_file): Adjust.
5847
5848 2019-02-19  Tom Tromey  <tromey@adacore.com>
5849
5850         * ravenscar-thread.c
5851         (ravenscar_thread_target::update_thread_list): Don't call
5852         ada_build_task_list.
5853         * ada-lang.h (ada_build_task_list): Don't declare.
5854         * ada-tasks.c (struct ada_tasks_inferior_data)
5855         <task_list_valid_p>: Now bool.
5856         (read_known_tasks, ada_task_list_changed)
5857         (ada_tasks_invalidate_inferior_data): Update.
5858         (read_known_tasks_array): Return bool.
5859         (read_known_tasks_list): Likewise.
5860         (read_known_tasks): Return void.
5861         (ada_build_task_list): Now static.
5862
5863 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5864
5865         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5866         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5867
5868 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5869
5870         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5871         variant for ada_tasks_pspace_data_handle and
5872         ada_tasks_inferior_data_handle.
5873         (ada_tasks_pspace_data_cleanup): New function.
5874         (ada_tasks_inferior_data_cleanup): New function.
5875
5876 2019-02-17  Tom Tromey  <tom@tromey.com>
5877
5878         * macrotab.h (macro_source_fullname): Return a std::string.
5879         * macrotab.c (macro_include, check_for_redefinition)
5880         (macro_undef, macro_lookup_definition, foreach_macro)
5881         (foreach_macro_in_scope): Update.
5882         (macro_source_fullname): Return a std::string.
5883         * macrocmd.c (show_pp_source_pos): Update.
5884
5885 2019-02-17  Tom Tromey  <tom@tromey.com>
5886
5887         * macrocmd.c (show_pp_source_pos): Style the file names.
5888
5889 2019-02-17  Tom Tromey  <tom@tromey.com>
5890
5891         PR tui/24197:
5892         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5893
5894 2019-02-17  Tom Tromey  <tom@tromey.com>
5895
5896         * ada-lang.c (user_select_syms): Use filtered printing.
5897         * utils.c (wrap_style): New global.
5898         (desired_style): Remove.
5899         (emit_style_escape): Add stream parameter.
5900         (set_output_style, reset_terminal_style, prompt_for_continue):
5901         Update.
5902         (flush_wrap_buffer): Only flush gdb_stdout.
5903         (wrap_here): Set wrap_style.
5904         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5905         treat escape sequences as a character.  Change when wrap buffer is
5906         flushed.
5907         (fputs_styled): Do not set the output style when the default is
5908         requested.
5909         * ui-style.h (struct ui_file_style) <is_default>: New method.
5910         * source.c (print_source_lines_base): Emit escape sequences in one
5911         piece.
5912
5913 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5914
5915         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5916         integers and enumeration types.
5917
5918 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5919
5920         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5921         instead of lookup_symbol_in_language
5922         (do_exact_match): New function.
5923         (ada_get_symbol_name_matcher): Return do_exact_match when
5924         doing a verbatim match.
5925
5926 2019-02-15  Tom Tromey  <tromey@adacore.com>
5927
5928         * ravenscar-thread.c (ravenscar_thread_target::resume)
5929         (ravenscar_thread_target::wait): Special case wildcard requests.
5930
5931 2019-02-15  Tom Tromey  <tromey@adacore.com>
5932
5933         * ravenscar-thread.c (base_ptid): Remove.
5934         (struct ravenscar_thread_target) <close>: New method.
5935         <m_base_ptid>: New member.
5936         <update_inferior_ptid, active_task, task_is_currently_active,
5937         runtime_initialized>: Declare methods.
5938         <ravenscar_thread_target>: Add constructor.
5939         (ravenscar_thread_target::task_is_currently_active)
5940         (ravenscar_thread_target::update_inferior_ptid)
5941         (ravenscar_runtime_initialized): Rename.  Now methods.
5942         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5943         (ravenscar_thread_target::update_thread_list): Update.
5944         (ravenscar_thread_target::active_task): Now method.
5945         (ravenscar_thread_target::store_registers)
5946         (ravenscar_thread_target::prepare_to_store)
5947         (ravenscar_thread_target::prepare_to_store)
5948         (ravenscar_thread_target::mourn_inferior): Update.
5949         (ravenscar_inferior_created): Use "new" to create target.
5950         (ravenscar_thread_target::get_ada_task_ptid): Update.
5951         (_initialize_ravenscar): Don't initialize base_ptid.
5952         (ravenscar_ops): Remove global.
5953
5954 2019-02-15  Tom Tromey  <tromey@adacore.com>
5955
5956         * target.h (push_target): Declare new overload.
5957         * target.c (push_target): New overload, taking an rvalue reference.
5958         * remote.c (remote_target::open_1): Use push_target overload.
5959         * corelow.c (core_target_open): Use push_target overload.
5960
5961 2019-02-15  Tom Tromey  <tromey@adacore.com>
5962
5963         * ravenscar-thread.c (is_ravenscar_task)
5964         (ravenscar_task_is_currently_active): Return bool.
5965         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5966         (_initialize_ravenscar): Remove "(void)".
5967         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5968         Return bool.
5969
5970 2019-02-15  Tom Tromey  <tromey@adacore.com>
5971
5972         * ravenscar-thread.c (ravenscar_runtime_initializer)
5973         (has_ravenscar_runtime, get_running_thread_id)
5974         (ravenscar_thread_target::resume): Fix indentation.
5975
5976 2019-02-15  Tom Tromey  <tromey@adacore.com>
5977
5978         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5979         from ravenscar_arch_ops.
5980         (sparc_ravenscar_ops::fetch_registers)
5981         (sparc_ravenscar_ops::store_registers): Now methods.
5982         (sparc_ravenscar_prepare_to_store): Remove.
5983         (sparc_ravenscar_ops): Redefine.
5984         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5985         methods and destructor.  Remove members.
5986         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5987         (ravenscar_thread_target::store_registers)
5988         (ravenscar_thread_target::prepare_to_store): Update.
5989         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5990         Remove.
5991         (struct ppc_ravenscar_powerpc_ops): Derive from
5992         ravenscar_arch_ops.
5993         (ppc_ravenscar_powerpc_ops::fetch_registers)
5994         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5995         (ppc_ravenscar_powerpc_ops): Redefine.
5996         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5997         (ppc_ravenscar_e500_ops::fetch_registers)
5998         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5999         (ppc_ravenscar_e500_ops): Redefine.
6000         * aarch64-ravenscar-thread.c
6001         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6002         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6003         (aarch64_ravenscar_fetch_registers)
6004         (aarch64_ravenscar_store_registers): Now methods.
6005         (aarch64_ravenscar_ops): Redefine.
6006
6007 2019-02-15  Tom Tromey  <tromey@adacore.com>
6008
6009         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6010         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6011         (ravenscar_thread_target::stopped_by_watchpoint)
6012         (ravenscar_thread_target::stopped_data_address)
6013         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6014
6015 2019-02-15  Tom Tromey  <tromey@adacore.com>
6016
6017         * ravenscar-thread.c: Fix some typos.
6018
6019 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6020             Tom Tromey  <tromey@adacore.com>
6021
6022         * ada-lang.c (ada_exception_sal): Change addr_string to a
6023         std::string.
6024         (create_ada_exception_catchpoint): Update.
6025
6026 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6027             Tom Tromey  <tromey@adacore.com>
6028
6029         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6030         (bp_location_ops): Remove.
6031         (base_breakpoint_allocate_location): Update.
6032         (free_bp_location): Update.
6033         * ada-lang.c (class ada_catchpoint_location)
6034         <ada_catchpoint_location>: Remove ops parameter.
6035         (ada_catchpoint_location_dtor): Remove.
6036         (ada_catchpoint_location_ops): Remove.
6037         (allocate_location_exception): Update.
6038         * breakpoint.h (struct bp_location_ops): Remove.
6039         (class bp_location) <bp_location>: Remove bp_location_ops
6040         parameter.
6041         <~bp_location>: Add destructor.
6042         <ops>: Remove.
6043
6044 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6045             Pedro Alves  <palves@redhat.com>
6046
6047         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6048         'PATH_MAX'.
6049
6050 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6051             Samuel Thibault  <samuel.thibault@gnu.org>
6052             Thomas Schwinge  <thomas@codesourcery.com>
6053
6054         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6055         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6056
6057 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6058
6059         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6060         (check_empty): Use "const char *".
6061
6062         * gnu-nat.c (gnu_nat_target::detach): Instead of
6063         'detach_inferior (pid)' call
6064         'detach_inferior (find_inferior_pid (pid))'.
6065
6066         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6067         'nat/fork-inferior.o'.
6068         * gnu-nat.c: #include "nat/fork-inferior.h".
6069
6070         * gnu-nat.c (gnu_nat_target::detach): Instead of
6071         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6072         * gnu-nat.h: #include "inf-child.h".
6073         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6074         'i386_gnu_nat_target::fetch_registers'.
6075         (gnu_store_registers): Rename/move to
6076         'i386_gnu_nat_target::store_registers'.
6077
6078         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6079         * gnu-nat.h (mach_thread_info): New function.
6080         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6081
6082         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6083
6084 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6085
6086         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6087
6088 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6089
6090         * windows-nat.c (windows_add_thread): Add new parameter
6091         "main_thread_p" with default value set to false.  Update
6092         function documentation as well as all callers.
6093         (windows_delete_thread): Likewise.
6094         (fake_create_process): Update call to windows_add_thread.
6095         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6096         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6097         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6098         call to windows_delete_thread.
6099
6100 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6101
6102         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6103
6104 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6105
6106         * symfile.c (find_separate_debug_file): Use canonical path of
6107         sysroot with child_path instead of gdb_sysroot if it is valid.
6108
6109 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6110
6111         * symfile.c (find_separate_debug_file): Use child_path to
6112         determine if an object file is under a sysroot.
6113
6114 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6115
6116         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6117         unittests/child-path-selftests.c.
6118         * common/pathstuff.c (child_path): New function.
6119         * common/pathstuff.h (child_path): New prototype.
6120         * unittests/child-path-selftests.c: New file.
6121
6122 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6123
6124         * symfile.c (find_separate_debug_file): Look for separate debug
6125         files in debug directories under the sysroot.
6126
6127 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6128
6129         * symtab.h (struct minimal_symbol data_p): New const method.
6130         (struct minimal_symbol text_p): Likewise.
6131         * symtab.c (output_source_filename): Use file name style
6132         to print file name.
6133         (print_symbol_info): Likewise.
6134         (print_msymbol_info): Use address style to print addresses.
6135         Use function name style to print executable text symbols.
6136         (expand_symtab_containing_pc): Use data_p.
6137         (find_pc_sect_compunit_symtab): Likewise.
6138
6139 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6140
6141         * breakpoint.c (describe_other_breakpoints): Use address style
6142         to print addresses.
6143         (say_where): Likewise.
6144
6145 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6146
6147         * ada-typeprint.c (print_func_type): Print function name
6148         style to print function name.
6149         * c-typeprint.c (c_print_type_1): Likewise.
6150
6151 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6152
6153         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6154         for execve.
6155
6156 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6157
6158         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6159         type_stack.
6160
6161 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6162
6163         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6164         TYPE_CODE_REF types.
6165
6166 2019-02-08  Jim Wilson  <jimw@sifive.com>
6167
6168         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6169         (riscv_linux_fregset): New.
6170         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6171
6172 2019-02-07  Tom Tromey  <tom@tromey.com>
6173
6174         * thread.c (thread_cancel_execution_command): Update.
6175         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6176         methods.
6177         (struct thread_fsm_ops): Remove.
6178         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6179         (thread_fsm_should_stop, thread_fsm_return_value)
6180         (thread_fsm_set_finished, thread_fsm_finished_p)
6181         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6182         Don't declare.
6183         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6184         * infrun.c (clear_proceed_status_thread)
6185         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6186         (print_stop_event): Update.
6187         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6188         Add constructor.
6189         (step_command_fsm_ops): Remove.
6190         (new_step_command_fsm): Remove.
6191         (step_1): Update.
6192         (step_command_fsm::should_stop): Rename from
6193         step_command_fsm_should_stop.
6194         (step_command_fsm::clean_up): Rename from
6195         step_command_fsm_clean_up.
6196         (step_command_fsm::do_async_reply_reason): Rename from
6197         step_command_fsm_async_reply_reason.
6198         (struct until_next_fsm): Inherit from thread_fsm.  Add
6199         constructor.
6200         (until_next_fsm_ops): Remove.
6201         (new_until_next_fsm): Remove.
6202         (until_next_fsm::should_stop): Rename from
6203         until_next_fsm_should_stop.
6204         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6205         (until_next_fsm::do_async_reply_reason): Rename from
6206         until_next_fsm_async_reply_reason.
6207         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6208         constructor.  Change type of breakpoint.
6209         (finish_command_fsm_ops): Remove.
6210         (new_finish_command_fsm): Remove.
6211         (finish_command_fsm::should_stop): Rename from
6212         finish_command_fsm_should_stop.
6213         (finish_command_fsm::clean_up): Rename from
6214         finish_command_fsm_clean_up.
6215         (finish_command_fsm::return_value): Rename from
6216         finish_command_fsm_return_value.
6217         (finish_command_fsm::do_async_reply_reason): Rename from
6218         finish_command_fsm_async_reply_reason.
6219         (finish_command): Update.
6220         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6221         Add constructor.
6222         (call_thread_fsm_ops): Remove.
6223         (call_thread_fsm::call_thread_fsm): Rename from
6224         new_call_thread_fsm.
6225         (call_thread_fsm::should_stop): Rename from
6226         call_thread_fsm_should_stop.
6227         (call_thread_fsm::should_notify_stop): Rename from
6228         call_thread_fsm_should_notify_stop.
6229         (run_inferior_call, call_function_by_hand_dummy): Update.
6230         * cli/cli-interp.c (should_print_stop_to_console): Update.
6231         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6232         Add constructor.  Change type of location_breakpoint,
6233         caller_breakpoint.
6234         (until_break_fsm_ops): Remove.
6235         (new_until_break_fsm): Remove.
6236         (until_break_fsm::should_stop): Rename from
6237         until_break_fsm_should_stop.
6238         (until_break_fsm::clean_up): Rename from
6239         until_break_fsm_clean_up.
6240         (until_break_fsm::do_async_reply_reason): Rename from
6241         until_break_fsm_async_reply_reason.
6242         (until_break_command): Update.
6243         * thread-fsm.c: Remove.
6244         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6245
6246 2019-02-07  Tom Tromey  <tom@tromey.com>
6247
6248         * yy-remap.h: Add include guard.
6249         * xtensa-tdep.h: Add include guard.
6250         * xcoffread.h: Rename include guard.
6251         * varobj-iter.h: Add include guard.
6252         * tui/tui.h: Rename include guard.
6253         * tui/tui-winsource.h: Rename include guard.
6254         * tui/tui-wingeneral.h: Rename include guard.
6255         * tui/tui-windata.h: Rename include guard.
6256         * tui/tui-win.h: Rename include guard.
6257         * tui/tui-stack.h: Rename include guard.
6258         * tui/tui-source.h: Rename include guard.
6259         * tui/tui-regs.h: Rename include guard.
6260         * tui/tui-out.h: Rename include guard.
6261         * tui/tui-layout.h: Rename include guard.
6262         * tui/tui-io.h: Rename include guard.
6263         * tui/tui-hooks.h: Rename include guard.
6264         * tui/tui-file.h: Rename include guard.
6265         * tui/tui-disasm.h: Rename include guard.
6266         * tui/tui-data.h: Rename include guard.
6267         * tui/tui-command.h: Rename include guard.
6268         * tic6x-tdep.h: Add include guard.
6269         * target/waitstatus.h: Rename include guard.
6270         * target/wait.h: Rename include guard.
6271         * target/target.h: Rename include guard.
6272         * target/resume.h: Rename include guard.
6273         * target-float.h: Rename include guard.
6274         * stabsread.h: Add include guard.
6275         * rs6000-tdep.h: Add include guard.
6276         * riscv-fbsd-tdep.h: Add include guard.
6277         * regformats/regdef.h: Rename include guard.
6278         * record.h: Rename include guard.
6279         * python/python.h: Rename include guard.
6280         * python/python-internal.h: Rename include guard.
6281         * python/py-stopevent.h: Rename include guard.
6282         * python/py-ref.h: Rename include guard.
6283         * python/py-record.h: Rename include guard.
6284         * python/py-record-full.h: Rename include guard.
6285         * python/py-record-btrace.h: Rename include guard.
6286         * python/py-instruction.h: Rename include guard.
6287         * python/py-events.h: Rename include guard.
6288         * python/py-event.h: Rename include guard.
6289         * procfs.h: Add include guard.
6290         * proc-utils.h: Add include guard.
6291         * p-lang.h: Add include guard.
6292         * or1k-tdep.h: Rename include guard.
6293         * observable.h: Rename include guard.
6294         * nto-tdep.h: Rename include guard.
6295         * nat/x86-linux.h: Rename include guard.
6296         * nat/x86-linux-dregs.h: Rename include guard.
6297         * nat/x86-gcc-cpuid.h: Add include guard.
6298         * nat/x86-dregs.h: Rename include guard.
6299         * nat/x86-cpuid.h: Rename include guard.
6300         * nat/ppc-linux.h: Rename include guard.
6301         * nat/mips-linux-watch.h: Rename include guard.
6302         * nat/linux-waitpid.h: Rename include guard.
6303         * nat/linux-ptrace.h: Rename include guard.
6304         * nat/linux-procfs.h: Rename include guard.
6305         * nat/linux-osdata.h: Rename include guard.
6306         * nat/linux-nat.h: Rename include guard.
6307         * nat/linux-namespaces.h: Rename include guard.
6308         * nat/linux-btrace.h: Rename include guard.
6309         * nat/glibc_thread_db.h: Rename include guard.
6310         * nat/gdb_thread_db.h: Rename include guard.
6311         * nat/gdb_ptrace.h: Rename include guard.
6312         * nat/fork-inferior.h: Rename include guard.
6313         * nat/amd64-linux-siginfo.h: Rename include guard.
6314         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6315         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6316         * nat/aarch64-linux.h: Rename include guard.
6317         * nat/aarch64-linux-hw-point.h: Rename include guard.
6318         * mn10300-tdep.h: Add include guard.
6319         * mips-linux-tdep.h: Add include guard.
6320         * mi/mi-parse.h: Rename include guard.
6321         * mi/mi-out.h: Rename include guard.
6322         * mi/mi-main.h: Rename include guard.
6323         * mi/mi-interp.h: Rename include guard.
6324         * mi/mi-getopt.h: Rename include guard.
6325         * mi/mi-console.h: Rename include guard.
6326         * mi/mi-common.h: Rename include guard.
6327         * mi/mi-cmds.h: Rename include guard.
6328         * mi/mi-cmd-break.h: Rename include guard.
6329         * m2-lang.h: Add include guard.
6330         * location.h: Rename include guard.
6331         * linux-record.h: Rename include guard.
6332         * linux-nat.h: Add include guard.
6333         * linux-fork.h: Add include guard.
6334         * i386-darwin-tdep.h: Rename include guard.
6335         * hppa-linux-offsets.h: Add include guard.
6336         * guile/guile.h: Rename include guard.
6337         * guile/guile-internal.h: Rename include guard.
6338         * gnu-nat.h: Rename include guard.
6339         * gdb-stabs.h: Rename include guard.
6340         * frv-tdep.h: Add include guard.
6341         * f-lang.h: Add include guard.
6342         * event-loop.h: Add include guard.
6343         * darwin-nat.h: Rename include guard.
6344         * cp-abi.h: Rename include guard.
6345         * config/sparc/nm-sol2.h: Rename include guard.
6346         * config/nm-nto.h: Rename include guard.
6347         * config/nm-linux.h: Add include guard.
6348         * config/i386/nm-i386gnu.h: Rename include guard.
6349         * config/djgpp/nl_types.h: Rename include guard.
6350         * config/djgpp/langinfo.h: Rename include guard.
6351         * compile/gcc-cp-plugin.h: Add include guard.
6352         * compile/gcc-c-plugin.h: Add include guard.
6353         * compile/compile.h: Rename include guard.
6354         * compile/compile-object-run.h: Rename include guard.
6355         * compile/compile-object-load.h: Rename include guard.
6356         * compile/compile-internal.h: Rename include guard.
6357         * compile/compile-cplus.h: Rename include guard.
6358         * compile/compile-c.h: Rename include guard.
6359         * common/xml-utils.h: Rename include guard.
6360         * common/x86-xstate.h: Rename include guard.
6361         * common/version.h: Rename include guard.
6362         * common/vec.h: Rename include guard.
6363         * common/tdesc.h: Rename include guard.
6364         * common/selftest.h: Rename include guard.
6365         * common/scoped_restore.h: Rename include guard.
6366         * common/scoped_mmap.h: Rename include guard.
6367         * common/scoped_fd.h: Rename include guard.
6368         * common/safe-iterator.h: Rename include guard.
6369         * common/run-time-clock.h: Rename include guard.
6370         * common/refcounted-object.h: Rename include guard.
6371         * common/queue.h: Rename include guard.
6372         * common/ptid.h: Rename include guard.
6373         * common/print-utils.h: Rename include guard.
6374         * common/preprocessor.h: Rename include guard.
6375         * common/pathstuff.h: Rename include guard.
6376         * common/observable.h: Rename include guard.
6377         * common/netstuff.h: Rename include guard.
6378         * common/job-control.h: Rename include guard.
6379         * common/host-defs.h: Rename include guard.
6380         * common/gdb_wait.h: Rename include guard.
6381         * common/gdb_vecs.h: Rename include guard.
6382         * common/gdb_unlinker.h: Rename include guard.
6383         * common/gdb_unique_ptr.h: Rename include guard.
6384         * common/gdb_tilde_expand.h: Rename include guard.
6385         * common/gdb_sys_time.h: Rename include guard.
6386         * common/gdb_string_view.h: Rename include guard.
6387         * common/gdb_splay_tree.h: Rename include guard.
6388         * common/gdb_setjmp.h: Rename include guard.
6389         * common/gdb_ref_ptr.h: Rename include guard.
6390         * common/gdb_optional.h: Rename include guard.
6391         * common/gdb_locale.h: Rename include guard.
6392         * common/gdb_assert.h: Rename include guard.
6393         * common/filtered-iterator.h: Rename include guard.
6394         * common/filestuff.h: Rename include guard.
6395         * common/fileio.h: Rename include guard.
6396         * common/environ.h: Rename include guard.
6397         * common/common-utils.h: Rename include guard.
6398         * common/common-types.h: Rename include guard.
6399         * common/common-regcache.h: Rename include guard.
6400         * common/common-inferior.h: Rename include guard.
6401         * common/common-gdbthread.h: Rename include guard.
6402         * common/common-exceptions.h: Rename include guard.
6403         * common/common-defs.h: Rename include guard.
6404         * common/common-debug.h: Rename include guard.
6405         * common/cleanups.h: Rename include guard.
6406         * common/buffer.h: Rename include guard.
6407         * common/btrace-common.h: Rename include guard.
6408         * common/break-common.h: Rename include guard.
6409         * cli/cli-utils.h: Rename include guard.
6410         * cli/cli-style.h: Rename include guard.
6411         * cli/cli-setshow.h: Rename include guard.
6412         * cli/cli-script.h: Rename include guard.
6413         * cli/cli-interp.h: Rename include guard.
6414         * cli/cli-decode.h: Rename include guard.
6415         * cli/cli-cmds.h: Rename include guard.
6416         * charset-list.h: Add include guard.
6417         * buildsym-legacy.h: Rename include guard.
6418         * bfin-tdep.h: Add include guard.
6419         * ax.h: Rename include guard.
6420         * arm-linux-tdep.h: Add include guard.
6421         * arm-fbsd-tdep.h: Add include guard.
6422         * arch/xtensa.h: Rename include guard.
6423         * arch/tic6x.h: Add include guard.
6424         * arch/i386.h: Add include guard.
6425         * arch/arm.h: Rename include guard.
6426         * arch/arm-linux.h: Rename include guard.
6427         * arch/arm-get-next-pcs.h: Rename include guard.
6428         * arch/amd64.h: Add include guard.
6429         * arch/aarch64-insn.h: Rename include guard.
6430         * arch-utils.h: Rename include guard.
6431         * annotate.h: Add include guard.
6432         * amd64-darwin-tdep.h: Rename include guard.
6433         * aarch64-linux-tdep.h: Add include guard.
6434         * aarch64-fbsd-tdep.h: Add include guard.
6435         * aarch32-linux-nat.h: Add include guard.
6436
6437 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6438
6439         * macrotab.c (macro_define_internal): New function that
6440         factorizes macro_define_object_internal and macro_define_function
6441         code.
6442         (macro_define_object_internal): Use macro_define_internal.
6443         (macro_define_function): Likewise.
6444
6445 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6446
6447         * macrocmd.c (extract_identifier): Return
6448         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6449         callers.
6450
6451 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6452
6453         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6454
6455 2019-02-05  Tom Tromey  <tom@tromey.com>
6456
6457         * target.c (target_stack::unpush): Move assertion earlier.
6458
6459 2019-01-30  Tom Tromey  <tom@tromey.com>
6460
6461         PR python/23615:
6462         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6463         (gdbpy_parse_and_eval): Likewise.
6464         * python/python-internal.h (gdbpy_allow_threads): New class.
6465
6466 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6467
6468         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6469         (aarch64_fbsd_fpregmap): Move earlier.
6470         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6471         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6472         instead of individual calls to trad_frame_set_reg_addr.
6473         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6474         earlier.
6475         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6476         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6477         instead of individual calls to trad_frame_set_reg_addr.
6478
6479 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6480
6481         * CONTRIBUTE: Replace contribution list with wiki link.
6482
6483 2019-01-25  Tom Tromey  <tom@tromey.com>
6484
6485         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6486
6487 2019-01-25  Tom Tromey  <tom@tromey.com>
6488
6489         * xtensa-linux-nat.c: Fix common/ includes.
6490         * xml-support.h: Fix common/ includes.
6491         * xml-support.c: Fix common/ includes.
6492         * x86-linux-nat.c: Fix common/ includes.
6493         * windows-nat.c: Fix common/ includes.
6494         * varobj.h: Fix common/ includes.
6495         * varobj.c: Fix common/ includes.
6496         * value.c: Fix common/ includes.
6497         * valops.c: Fix common/ includes.
6498         * utils.c: Fix common/ includes.
6499         * unittests/xml-utils-selftests.c: Fix common/ includes.
6500         * unittests/utils-selftests.c: Fix common/ includes.
6501         * unittests/unpack-selftests.c: Fix common/ includes.
6502         * unittests/tracepoint-selftests.c: Fix common/ includes.
6503         * unittests/style-selftests.c: Fix common/ includes.
6504         * unittests/string_view-selftests.c: Fix common/ includes.
6505         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6506         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6507         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6508         * unittests/rsp-low-selftests.c: Fix common/ includes.
6509         * unittests/parse-connection-spec-selftests.c: Fix common/
6510         includes.
6511         * unittests/optional-selftests.c: Fix common/ includes.
6512         * unittests/offset-type-selftests.c: Fix common/ includes.
6513         * unittests/observable-selftests.c: Fix common/ includes.
6514         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6515         * unittests/memrange-selftests.c: Fix common/ includes.
6516         * unittests/memory-map-selftests.c: Fix common/ includes.
6517         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6518         * unittests/function-view-selftests.c: Fix common/ includes.
6519         * unittests/environ-selftests.c: Fix common/ includes.
6520         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6521         * unittests/common-utils-selftests.c: Fix common/ includes.
6522         * unittests/cli-utils-selftests.c: Fix common/ includes.
6523         * unittests/array-view-selftests.c: Fix common/ includes.
6524         * ui-file.c: Fix common/ includes.
6525         * tui/tui-io.c: Fix common/ includes.
6526         * tracepoint.h: Fix common/ includes.
6527         * tracepoint.c: Fix common/ includes.
6528         * tracefile-tfile.c: Fix common/ includes.
6529         * top.h: Fix common/ includes.
6530         * top.c: Fix common/ includes.
6531         * thread.c: Fix common/ includes.
6532         * target/waitstatus.h: Fix common/ includes.
6533         * target/waitstatus.c: Fix common/ includes.
6534         * target.h: Fix common/ includes.
6535         * target.c: Fix common/ includes.
6536         * target-memory.c: Fix common/ includes.
6537         * target-descriptions.c: Fix common/ includes.
6538         * symtab.h: Fix common/ includes.
6539         * symfile.c: Fix common/ includes.
6540         * stap-probe.c: Fix common/ includes.
6541         * spu-linux-nat.c: Fix common/ includes.
6542         * sparc-nat.c: Fix common/ includes.
6543         * source.c: Fix common/ includes.
6544         * solib.c: Fix common/ includes.
6545         * solib-target.c: Fix common/ includes.
6546         * ser-unix.c: Fix common/ includes.
6547         * ser-tcp.c: Fix common/ includes.
6548         * ser-pipe.c: Fix common/ includes.
6549         * ser-base.c: Fix common/ includes.
6550         * selftest-arch.c: Fix common/ includes.
6551         * s12z-tdep.c: Fix common/ includes.
6552         * rust-exp.y: Fix common/ includes.
6553         * rs6000-aix-tdep.c: Fix common/ includes.
6554         * riscv-tdep.c: Fix common/ includes.
6555         * remote.c: Fix common/ includes.
6556         * remote-notif.h: Fix common/ includes.
6557         * remote-fileio.h: Fix common/ includes.
6558         * remote-fileio.c: Fix common/ includes.
6559         * regcache.h: Fix common/ includes.
6560         * regcache.c: Fix common/ includes.
6561         * record-btrace.c: Fix common/ includes.
6562         * python/python.c: Fix common/ includes.
6563         * python/py-type.c: Fix common/ includes.
6564         * python/py-inferior.c: Fix common/ includes.
6565         * progspace.h: Fix common/ includes.
6566         * producer.c: Fix common/ includes.
6567         * procfs.c: Fix common/ includes.
6568         * proc-api.c: Fix common/ includes.
6569         * printcmd.c: Fix common/ includes.
6570         * ppc-linux-nat.c: Fix common/ includes.
6571         * parser-defs.h: Fix common/ includes.
6572         * osdata.c: Fix common/ includes.
6573         * obsd-nat.c: Fix common/ includes.
6574         * nat/x86-linux.c: Fix common/ includes.
6575         * nat/x86-linux-dregs.c: Fix common/ includes.
6576         * nat/x86-dregs.h: Fix common/ includes.
6577         * nat/x86-dregs.c: Fix common/ includes.
6578         * nat/ppc-linux.c: Fix common/ includes.
6579         * nat/mips-linux-watch.h: Fix common/ includes.
6580         * nat/mips-linux-watch.c: Fix common/ includes.
6581         * nat/linux-waitpid.c: Fix common/ includes.
6582         * nat/linux-ptrace.h: Fix common/ includes.
6583         * nat/linux-ptrace.c: Fix common/ includes.
6584         * nat/linux-procfs.c: Fix common/ includes.
6585         * nat/linux-personality.c: Fix common/ includes.
6586         * nat/linux-osdata.c: Fix common/ includes.
6587         * nat/linux-namespaces.c: Fix common/ includes.
6588         * nat/linux-btrace.h: Fix common/ includes.
6589         * nat/linux-btrace.c: Fix common/ includes.
6590         * nat/fork-inferior.c: Fix common/ includes.
6591         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6592         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6593         * nat/aarch64-linux.c: Fix common/ includes.
6594         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6595         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6596         * namespace.h: Fix common/ includes.
6597         * mips-linux-tdep.c: Fix common/ includes.
6598         * minsyms.c: Fix common/ includes.
6599         * mi/mi-parse.h: Fix common/ includes.
6600         * mi/mi-main.c: Fix common/ includes.
6601         * mi/mi-cmd-env.c: Fix common/ includes.
6602         * memrange.h: Fix common/ includes.
6603         * memattr.c: Fix common/ includes.
6604         * maint.h: Fix common/ includes.
6605         * maint.c: Fix common/ includes.
6606         * main.c: Fix common/ includes.
6607         * machoread.c: Fix common/ includes.
6608         * location.c: Fix common/ includes.
6609         * linux-thread-db.c: Fix common/ includes.
6610         * linux-nat.c: Fix common/ includes.
6611         * linux-fork.c: Fix common/ includes.
6612         * inline-frame.c: Fix common/ includes.
6613         * infrun.c: Fix common/ includes.
6614         * inflow.c: Fix common/ includes.
6615         * inferior.h: Fix common/ includes.
6616         * inferior.c: Fix common/ includes.
6617         * infcmd.c: Fix common/ includes.
6618         * inf-ptrace.c: Fix common/ includes.
6619         * inf-child.c: Fix common/ includes.
6620         * ia64-linux-nat.c: Fix common/ includes.
6621         * i387-tdep.c: Fix common/ includes.
6622         * i386-tdep.c: Fix common/ includes.
6623         * i386-linux-tdep.c: Fix common/ includes.
6624         * i386-linux-nat.c: Fix common/ includes.
6625         * i386-go32-tdep.c: Fix common/ includes.
6626         * i386-fbsd-tdep.c: Fix common/ includes.
6627         * i386-fbsd-nat.c: Fix common/ includes.
6628         * guile/scm-type.c: Fix common/ includes.
6629         * guile/guile.c: Fix common/ includes.
6630         * go32-nat.c: Fix common/ includes.
6631         * gnu-nat.c: Fix common/ includes.
6632         * gdbthread.h: Fix common/ includes.
6633         * gdbarch-selftests.c: Fix common/ includes.
6634         * gdb_usleep.c: Fix common/ includes.
6635         * gdb_select.h: Fix common/ includes.
6636         * gdb_bfd.c: Fix common/ includes.
6637         * gcore.c: Fix common/ includes.
6638         * fork-child.c: Fix common/ includes.
6639         * findvar.c: Fix common/ includes.
6640         * fbsd-nat.c: Fix common/ includes.
6641         * event-top.c: Fix common/ includes.
6642         * event-loop.c: Fix common/ includes.
6643         * dwarf2read.c: Fix common/ includes.
6644         * dwarf2loc.c: Fix common/ includes.
6645         * dwarf2-frame.c: Fix common/ includes.
6646         * dwarf-index-cache.c: Fix common/ includes.
6647         * dtrace-probe.c: Fix common/ includes.
6648         * disasm-selftests.c: Fix common/ includes.
6649         * defs.h: Fix common/ includes.
6650         * csky-tdep.c: Fix common/ includes.
6651         * cp-valprint.c: Fix common/ includes.
6652         * cp-support.h: Fix common/ includes.
6653         * cp-support.c: Fix common/ includes.
6654         * corelow.c: Fix common/ includes.
6655         * completer.h: Fix common/ includes.
6656         * completer.c: Fix common/ includes.
6657         * compile/compile.c: Fix common/ includes.
6658         * compile/compile-loc2c.c: Fix common/ includes.
6659         * compile/compile-cplus-types.c: Fix common/ includes.
6660         * compile/compile-cplus-symbols.c: Fix common/ includes.
6661         * command.h: Fix common/ includes.
6662         * cli/cli-dump.c: Fix common/ includes.
6663         * cli/cli-cmds.c: Fix common/ includes.
6664         * charset.c: Fix common/ includes.
6665         * build-id.c: Fix common/ includes.
6666         * btrace.h: Fix common/ includes.
6667         * btrace.c: Fix common/ includes.
6668         * breakpoint.h: Fix common/ includes.
6669         * breakpoint.c: Fix common/ includes.
6670         * ax.h:
6671         (enum agent_op): Fix common/ includes.
6672         * ax-general.c (struct aop_map): Fix common/ includes.
6673         * ax-gdb.c: Fix common/ includes.
6674         * auxv.c: Fix common/ includes.
6675         * auto-load.c: Fix common/ includes.
6676         * arm-tdep.c: Fix common/ includes.
6677         * arch/riscv.c: Fix common/ includes.
6678         * arch/ppc-linux-common.c: Fix common/ includes.
6679         * arch/i386.c: Fix common/ includes.
6680         * arch/arm.c: Fix common/ includes.
6681         * arch/arm-linux.c: Fix common/ includes.
6682         * arch/arm-get-next-pcs.c: Fix common/ includes.
6683         * arch/amd64.c: Fix common/ includes.
6684         * arch/aarch64.c: Fix common/ includes.
6685         * arch/aarch64-insn.c: Fix common/ includes.
6686         * arch-utils.c: Fix common/ includes.
6687         * amd64-windows-tdep.c: Fix common/ includes.
6688         * amd64-tdep.c: Fix common/ includes.
6689         * amd64-sol2-tdep.c: Fix common/ includes.
6690         * amd64-obsd-tdep.c: Fix common/ includes.
6691         * amd64-nbsd-tdep.c: Fix common/ includes.
6692         * amd64-linux-tdep.c: Fix common/ includes.
6693         * amd64-linux-nat.c: Fix common/ includes.
6694         * amd64-fbsd-tdep.c: Fix common/ includes.
6695         * amd64-fbsd-nat.c: Fix common/ includes.
6696         * amd64-dicos-tdep.c: Fix common/ includes.
6697         * amd64-darwin-tdep.c: Fix common/ includes.
6698         * agent.c: Fix common/ includes.
6699         * ada-lang.h: Fix common/ includes.
6700         * ada-lang.c: Fix common/ includes.
6701         * aarch64-tdep.c: Fix common/ includes.
6702
6703 2019-01-25  Tom Tromey  <tom@tromey.com>
6704
6705         * common/create-version.sh: Use common/version.h.
6706
6707 2019-01-24  Pedro Alves  <palves@redhat.com>
6708
6709         * infrun.c (signal_stop, signal_print, signal_program)
6710         (signal_catch, signal_pass): Now arrays instead of pointers.
6711         (update_signals_program_target, do_target_resume)
6712         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6713         * linux-nat.c (linux_nat_target::pass_signals)
6714         (linux_nat_target::create_inferior, linux_nat_target::attach):
6715         Adjust.
6716         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6717         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6718         * procfs.c (procfs_target::pass_signals): Adjust.
6719         * record-full.c (record_full_target::resume): Adjust.
6720         * remote.c (remote_target::pass_signals)
6721         (remote_target::program_signals): Adjust.
6722         * target-debug.h (target_debug_print_signals): Now takes a
6723         gdb::array_view as parameter.  Adjust.
6724         * target.h (target_ops) <pass_signals, program_signals>: Replace
6725         pointer and length parameters with gdb::array_view.
6726         (target_pass_signals, target_program_signals): Likewise.
6727         * target-delegates.c: Regenerate.
6728
6729 2019-01-24  Pedro Alves  <palves@redhat.com>
6730
6731         * common/forward-scope-exit.h
6732         (forward_scope_exit::forward_scope_exit): Pass arguments to
6733         m_bind_function directly, instead of creating a std::bind and
6734         copying that.
6735
6736 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6737
6738         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6739         for static members.
6740         (pass_in_v_vfp_candidate): Likewise.
6741
6742 2019-01-23  Tom Tromey  <tom@tromey.com>
6743             Pedro Alves  <palves@redhat.com>
6744
6745         * regcache.c (class regcache_invalidator): Remove.
6746         (regcache::raw_write): Use make_scope_exit.
6747
6748 2019-01-23  Tom Tromey  <tom@tromey.com>
6749
6750         * ui-out.h (class ui_out_emit_type): Update comment.
6751
6752 2019-01-23  Tom Tromey  <tom@tromey.com>
6753
6754         * infrun.c (fetch_inferior_event): Update comment.
6755
6756 2019-01-23  Tom Tromey  <tom@tromey.com>
6757             Pedro Alves  <palves@redhat.com>
6758
6759         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6760         parameter.
6761         (fetch_inferior_event): Use SCOPE_EXIT.
6762
6763
6764 2019-01-23  Tom Tromey  <tom@tromey.com>
6765             Pedro Alves  <palves@redhat.com>
6766
6767         * infrun.c (disable_thread_events): Delete.
6768         (stop_all_threads): Use SCOPE_EXIT.
6769
6770 2019-01-23  Tom Tromey  <tom@tromey.com>
6771             Pedro Alves  <palves@redhat.com>
6772
6773         * symfile.c: Include forward-scope-exit.h.
6774         (clear_symtab_users_cleanup): Replace forward declaration with
6775         a FORWARD_SCOPE_EXIT.
6776         (syms_from_objfile_1): Use the forward_scope_exit and
6777         gdb::optional instead of cleanup_function.
6778         (reread_symbols): Use the forward_scope_exit instead of
6779         cleanup_function.
6780         (clear_symtab_users_cleanup): Remove function.
6781
6782 2019-01-23  Tom Tromey  <tom@tromey.com>
6783             Pedro Alves  <palves@redhat.com>
6784
6785         * linux-nat.c: Include scope-exit.h.
6786         (cleanup_target_stop): Remove.
6787         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6788         SCOPE_EXIT.
6789
6790 2019-01-23  Tom Tromey  <tom@tromey.com>
6791             Pedro Alves  <palves@redhat.com>
6792
6793         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6794         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6795
6796 2019-01-23  Tom Tromey  <tom@tromey.com>
6797             Andrew Burgess  <andrew.burgess@embecosm.com>
6798             Pedro Alves  <palves@redhat.com>
6799
6800         * infrun.c (fetch_inferior_event): Use scope_exit.
6801         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6802         * top.c (execute_command): Use scope_exit.
6803         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6804         * utils.c (do_bpstat_clear_actions_cleanup)
6805         (make_bpstat_clear_actions_cleanup): Remove.
6806
6807 2019-01-23  Tom Tromey  <tom@tromey.com>
6808             Pedro Alves  <palves@redhat.com>
6809
6810         * infrun.c: Include "common/scope-exit.h"
6811         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6812         (wait_for_inferior): Use SCOPE_EXIT.
6813         (fetch_inferior_event): Use scope_exit.
6814
6815 2019-01-23  Tom Tromey  <tom@tromey.com>
6816             Pedro Alves  <palves@redhat.com>
6817
6818         * breakpoint.c (create_breakpoint): Remove cleanup.
6819
6820 2019-01-23  Tom Tromey  <tom@tromey.com>
6821             Andrew Burgess  <andrew.burgess@embecosm.com>
6822             Pedro Alves  <palves@redhat.com>
6823
6824 2019-01-23  Pedro Alves  <palves@redhat.com>
6825
6826         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6827
6828 2019-01-23  Pedro Alves  <palves@redhat.com>
6829             Andrew Burgess  <andrew.burgess@embecosm.com>
6830
6831         * gdbthread.h: Include "common/forward-scope-exit.h".
6832         (scoped_finish_thread_state): Redefine custom class in terms of
6833         forward_scope_exit.
6834
6835 2019-01-23  Pedro Alves  <palves@redhat.com>
6836             Andrew Burgess  <andrew.burgess@embecosm.com>
6837
6838         * common/forward-scope-exit.h: New file.
6839
6840 2019-01-23  Pedro Alves  <palves@redhat.com>
6841             Andrew Burgess  <andrew.burgess@embecosm.com>
6842             Tom Tromey  <tom@tromey.com>
6843
6844         * common/scope-exit.h: New file.
6845
6846 2019-01-23  Pedro Alves  <palves@redhat.com>
6847
6848         * common/preprocessor.h (ESC): Rename to ...
6849         (ESC_PARENS): ... this.
6850         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6851         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6852
6853 2019-01-23  Tom Tromey  <tom@tromey.com>
6854
6855         * language.h (class scoped_switch_to_sym_language_if_auto):
6856         Initialize m_lang in both cases.
6857
6858 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6859
6860         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6861         with XCNEW.
6862
6863 2019-01-22  Tom Tromey  <tom@tromey.com>
6864
6865         * corelow.c: Do not include sys/file.h.
6866
6867 2019-01-22  Tom Tromey  <tom@tromey.com>
6868
6869         * tui/tui-wingeneral.h: Include gdb_curses.h.
6870
6871 2019-01-22  Tom Tromey  <tom@tromey.com>
6872
6873         * source-cache.h (class source_cache) <get_source_lines,
6874         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6875
6876 2019-01-22  Tom Tromey  <tom@tromey.com>
6877
6878         * remote-fileio.h (struct remote_target): Declare.
6879
6880 2019-01-22  Tom Tromey  <tom@tromey.com>
6881
6882         * python/py-arch.c: Do not include py-ref.h.
6883         * python/py-bpevent.c: Do not include py-ref.h.
6884         * python/py-cmd.c: Do not include py-ref.h.
6885         * python/py-continueevent.c: Do not include py-ref.h.
6886         * python/py-event.h: Do not include py-ref.h.
6887         * python/py-evtregistry.c: Do not include py-ref.h.
6888         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6889         * python/py-frame.c: Do not include py-ref.h.
6890         * python/py-framefilter.c: Do not include py-ref.h.
6891         * python/py-function.c: Do not include py-ref.h.
6892         * python/py-infevents.c: Do not include py-ref.h.
6893         * python/py-linetable.c: Do not include py-ref.h.
6894         * python/py-objfile.c: Do not include py-ref.h.
6895         * python/py-param.c: Do not include py-ref.h.
6896         * python/py-prettyprint.c: Do not include py-ref.h.
6897         * python/py-progspace.c: Do not include py-ref.h.
6898         * python/py-symbol.c: Do not include py-ref.h.
6899         * python/py-symtab.c: Do not include py-ref.h.
6900         * python/py-type.c: Do not include py-ref.h.
6901         * python/py-unwind.c: Do not include py-ref.h.
6902         * python/py-utils.c: Do not include py-ref.h.
6903         * python/py-value.c: Do not include py-ref.h.
6904         * python/py-varobj.c: Do not include py-ref.h.
6905         * python/py-xmethods.c: Do not include py-ref.h.
6906         * python/python.c: Do not include py-ref.h.
6907         * varobj.c: Do not include py-ref.h.
6908
6909 2019-01-22  Tom Tromey  <tom@tromey.com>
6910
6911         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6912         keyword for bcache.
6913
6914 2019-01-22  Tom Tromey  <tom@tromey.com>
6915
6916         * compile/compile-cplus-types.c: Remove a comment by #include.
6917
6918 2019-01-22  Tom Tromey  <tom@tromey.com>
6919
6920         * compile/gcc-c-plugin.h: Include compile-internal.h.
6921
6922 2019-01-22  Tom Tromey  <tom@tromey.com>
6923
6924         * stabsread.c (EXTERN): Do not define.
6925         (symnum, next_symbol_text_func, processing_gcc_compilation)
6926         (within_function, global_sym_chain, global_stabs)
6927         (previous_stab_code, this_object_header_files)
6928         (n_this_object_header_files)
6929         (n_allocated_this_object_header_files): Define.
6930         * stabsread.h (EXTERN): Never define.  Use "extern".
6931
6932 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6933
6934         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6935         history_value.
6936
6937 2019-01-21  Tom Tromey  <tom@tromey.com>
6938
6939         * ui-out.c: Fix includes.
6940         * tui/tui-source.c: Fix includes.
6941         * target.c: Fix includes.
6942         * remote.c: Fix includes.
6943         * regcache.c: Fix includes.
6944         * python/py-block.c: Fix includes.
6945         * printcmd.c: Fix includes.
6946         * or1k-tdep.c: Fix includes.
6947         * mi/mi-main.c: Fix includes.
6948         * m32r-tdep.c: Fix includes.
6949         * csky-tdep.c: Fix includes.
6950         * compile/compile-cplus-types.c: Fix includes.
6951         * cli/cli-interp.c: Fix includes.
6952
6953 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6954
6955         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6956         for padding.
6957
6958 2019-01-16  Tom Tromey  <tom@tromey.com>
6959
6960         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6961         earlier.
6962         (struct objfile) <msymbols_range>: Move from top level.
6963         <msymbols>: New method.
6964         (class objfile_msymbols): Remove.
6965         * symtab.c (default_collect_symbol_completion_matches_break_on):
6966         Update.
6967         * symmisc.c (dump_msymbols): Update.
6968         * stabsread.c (scan_file_globals): Update.
6969         * objc-lang.c (info_selectors_command, info_classes_command)
6970         (find_methods): Update.
6971         * minsyms.c (find_solib_trampoline_target): Update.
6972         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6973         * coffread.c (coff_symfile_read): Update.
6974         * ada-lang.c (ada_lookup_simple_minsym)
6975         (ada_collect_symbol_completion_matches): Update.
6976
6977 2019-01-16  Tom Tromey  <tom@tromey.com>
6978
6979         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6980         type.  Remove no-argument constructor.
6981         <iterator::operator++>: Simplify.
6982         <begin>: Update.
6983         <end>: Use minimal_symbol_count.
6984
6985 2019-01-16  Tom Tromey  <tom@tromey.com>
6986
6987         * objfiles.h (struct objfile) <psymtabs>: New method.
6988         (class objfile_psymtabs): Remove.
6989         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6990         typedef.
6991         <range>: New method.
6992         (require_partial_symbols): Change return type.
6993         * psymtab.c (require_partial_symbols)
6994         (psym_expand_symtabs_matching): Update.
6995         * mdebugread.c (parse_partial_symbols): Update.
6996         * dbxread.c (dbx_end_psymtab): Update.
6997
6998 2019-01-15  Tom Tromey  <tom@tromey.com>
6999
7000         * symtab.c (lookup_objfile_from_block)
7001         (lookup_symbol_in_objfile_symtabs)
7002         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7003         (find_line_symtab, info_sources_command)
7004         (default_collect_symbol_completion_matches_break_on)
7005         (make_source_files_completion_list): Update.
7006         * symmisc.c (print_objfile_statistics, dump_objfile)
7007         (maintenance_print_symbols, maintenance_info_symtabs)
7008         (maintenance_check_symtabs, maintenance_info_line_tables):
7009         Update.
7010         * source.c (select_source_symtab)
7011         (forget_cached_source_info_for_objfile): Update.
7012         * objfiles.h (class objfile_compunits): Remove.
7013         (struct objfile) <compunits_range>: New typedef.
7014         (compunits): New method.
7015         * objfiles.c (objfile_relocate1): Update.
7016         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7017         * maint.c (count_symtabs_and_blocks): Update.
7018         * linespec.c (iterate_over_all_matching_symtabs): Update.
7019         * cp-support.c (add_symbol_overload_list_qualified): Update.
7020         * coffread.c (coff_symtab_read): Update.
7021         * ada-lang.c (add_nonlocal_symbols)
7022         (ada_collect_symbol_completion_matches)
7023         (ada_add_global_exceptions): Update.
7024
7025 2019-01-15  Tom Tromey  <tom@tromey.com>
7026
7027         * progspace.h (program_space) <objfiles_safe_range>: New
7028         typedef.
7029         <objfiles_safe>: New method.
7030         * objfiles.h (class all_objfiles_safe): Remove.
7031         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7032         * jit.c (jit_inferior_exit_hook): Update.
7033
7034 2019-01-17  Tom Tromey  <tom@tromey.com>
7035
7036         * progspace.h (program_space) <objfiles_range>: New typedef.
7037         <objfiles>: New method.
7038         <objfiles_head>: Rename from objfiles.
7039         (object_files): Update.
7040         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7041         * guile/scm-pretty-print.c
7042         (ppscm_find_pretty_printer_from_objfiles): Update.
7043         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7044         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7045         Update.
7046         * python/py-progspace.c (pspy_get_objfiles): Update.
7047         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7048         Update.
7049         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7050         (objfpy_lookup_objfile_by_build_id): Update.
7051         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7052         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7053         Update.
7054         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7055         (expand_symtab_containing_pc, lookup_objfile_from_block)
7056         (lookup_static_symbol, basic_lookup_transparent_type)
7057         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7058         (find_line_symtab, info_sources_command)
7059         (default_collect_symbol_completion_matches_break_on)
7060         (make_source_files_completion_list, find_main_name): Update.
7061         * symmisc.c (print_symbol_bcache_statistics)
7062         (print_objfile_statistics, maintenance_print_symbols)
7063         (maintenance_print_msymbols, maintenance_print_objfiles)
7064         (maintenance_info_symtabs, maintenance_check_symtabs)
7065         (maintenance_expand_symtabs, maintenance_info_line_tables):
7066         Update.
7067         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7068         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7069         (map_overlay_command, unmap_overlay_command)
7070         (simple_overlay_update, expand_symtabs_matching)
7071         (map_symbol_filenames): Update.
7072         * symfile-debug.c (set_debug_symfile): Update.
7073         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7074         Update.
7075         * source.c (select_source_symtab, forget_cached_source_info):
7076         Update.
7077         * solib.c (solib_read_symbols): Update.
7078         * solib-spu.c (append_ocl_sos): Update.
7079         * psymtab.c (maintenance_print_psymbols)
7080         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7081         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7082         * printcmd.c (info_symbol_command): Update.
7083         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7084         Update.
7085         * objfiles.h (class all_objfiles): Remove.
7086         * objfiles.c (have_partial_symbols, have_full_symbols)
7087         (have_minimal_symbols, qsort_cmp, update_section_map)
7088         (shared_objfile_contains_address_p)
7089         (default_iterate_over_objfiles_in_search_order): Update.
7090         * objc-lang.c (info_selectors_command, info_classes_command)
7091         (find_methods): Update.
7092         * minsyms.c (find_solib_trampoline_target): Update.
7093         * maint.c (maintenance_info_sections)
7094         (maintenance_translate_address, count_symtabs_and_blocks):
7095         Update.
7096         * main.c (captured_main_1): Update.
7097         * linux-thread-db.c (try_thread_db_load_from_pdir)
7098         (has_libpthread): Update.
7099         * linespec.c (iterate_over_all_matching_symtabs)
7100         (search_minsyms_for_name): Update.
7101         * jit.c (jit_find_objf_with_entry_addr): Update.
7102         * hppa-tdep.c (find_unwind_entry)
7103         (hppa_lookup_stub_minimal_symbol): Update.
7104         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7105         Update.
7106         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7107         (elf_gnu_ifunc_resolve_by_got): Update.
7108         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7109         * dwarf-index-write.c (save_gdb_index_command): Update.
7110         * cp-support.c (add_symbol_overload_list_qualified): Update.
7111         * breakpoint.c (create_overlay_event_breakpoint)
7112         (create_longjmp_master_breakpoint)
7113         (create_std_terminate_master_breakpoint)
7114         (create_exception_master_breakpoint): Update.
7115         * blockframe.c (find_pc_partial_function): Update.
7116         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7117         (ada_collect_symbol_completion_matches)
7118         (ada_add_global_exceptions): Update.
7119
7120 2019-01-17  Tom Tromey  <tom@tromey.com>
7121
7122         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7123         declare VEC.
7124         (solib_target_parse_libraries): Change return type.
7125         (library_list_start_segment, library_list_start_section)
7126         (library_list_end_library, library_list_start_library); Update.
7127         (solib_target_free_library_list): Remove.
7128         (solib_target_parse_libraries): Remove cleanup.  Change return
7129         type.
7130         (solib_target_current_sos): Update.
7131
7132 2019-01-17  Tom Tromey  <tromey@bapiya>
7133
7134         * valprint.c: Replace "the the" with "the".
7135         * symtab.c: Replace "the the" with "the".
7136         * solib.c: Replace "the the" with "the".
7137         * solib-dsbt.c: Replace "the the" with "the".
7138         * linespec.c: Replace "the the" with "the".
7139         * dwarf2loc.h: Replace "the the" with "the".
7140         * amd64-windows-tdep.c: Replace "the the" with "the".
7141         * aarch64-tdep.c: Replace "the the" with "the".
7142
7143 2019-01-16  Keith Seitz  <keiths@redhat.com>
7144
7145         PR gdb/23773
7146         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7147         <builder>: Rename to ..
7148         <m_builder>: ... this and make private.
7149         (dwarf2_cu::get_builder): New method.  Change all users of
7150         `builder' to use this method.
7151         (dwarf2_start_symtab): Move to ...
7152         (dwarf2_cu::start_symtab): ... here.  Update all callers
7153         (setup_type_unit_groups): Move to ...
7154         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7155         callers.
7156         (dwarf2_cu::reset_builder): New method.
7157         (process_full_compunit, process_full_type_unit): Use
7158         dwarf2_cu::reset_builder.
7159         (follow_die_offset): Record the ancestor CU if it is different
7160         from the followed DIE's CU.
7161         (follow_die_sig_1): Likewise.
7162
7163 2019-01-15  Tom Tromey  <tom@tromey.com>
7164
7165         * remote.c (class remote_state) <buf>: Now a char_vector.
7166         <buf_size>: Remove.
7167         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7168         parameter.
7169         (remote_target::getpkt_or_notif_sane_1)
7170         (remote_target::getpkt_sane)
7171         (remote_target::getpkt_or_notif_sane): Likewise.
7172         (class remote_target) <putpkt>: New overload.
7173         (remote_target::read_frame): Change type of "buf_p".  Remove
7174         sizeof_p parameter.
7175         (packet_ok): New overload.
7176         (packet_check_result): New overload.
7177         Update all uses.
7178
7179 2019-01-14  Tom Tromey  <tom@tromey.com>
7180
7181         * remote-notif.c (handle_notification, remote_notif_ack)
7182         (remote_notif_parse): Make "buf" const.
7183         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7184         const.
7185         (remote_notif_parse, remote_notif_ack, handle_notification):
7186         Likewise.
7187         * remote.c (remote_notif_stop_parse): Make "buf" const.
7188         (remote_target::remote_parse_stop_reply): Make "buf" const.
7189         (remote_notif_stop_ack): Make "buf" const.
7190
7191 2019-01-14  Tom Tromey  <tom@tromey.com>
7192
7193         * remote.c (remote_console_output): Make parameter const.
7194
7195 2019-01-14  Tom Tromey  <tom@tromey.com>
7196
7197         * target-debug.h (target_debug_print_signals): Constify.
7198         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7199         * procfs.c (procfs_target::pass_signals): Update.
7200         * linux-nat.c (linux_nat_target::pass_signals): Update.
7201         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7202         * target-delegates.c: Rebuild.
7203         * remote.c (remote_target::program_signals): Update.
7204         (remote_target::pass_signals): Update.
7205         * target.c (target_pass_signals): Constify argument.
7206         (target_program_signals): Likewise.
7207         * target.h (struct target_ops) <pass_signals, program_signals>:
7208         Constify argument.
7209         (target_pass_signals, target_program_signals): Constify argument.
7210
7211 2019-01-14  Tom Tromey  <tom@tromey.com>
7212
7213         PR tui/28819:
7214         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7215
7216 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7217
7218         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7219         field.
7220         * rs6000-tdep.c: Include reggroups.h.
7221         (IS_V_ALIAS_PSEUDOREG): Define.
7222         (rs6000_register_name): Return names for the "vX" aliases.
7223         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7224         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7225         aliases.  Call default_register_reggroup_p for all other
7226         pseudo-registers.
7227         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7228         New functions.
7229         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7230         Handle "vX" aliases.
7231         (v_alias_pseudo_register_collect): New function.
7232         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7233         (rs6000_gdbarch_init): Initialize "vX" aliases as
7234         pseudo-registers.  Restore registration of
7235         rs6000_pseudo_register_reggroup_p with
7236         set_tdesc_pseudo_register_reggroup_p.
7237
7238 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7239
7240         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7241         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7242         set_gdbarch_num_pseudo_regs.
7243
7244 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7245
7246         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7247         Remove arg prefixname, add do_set and do_show.
7248         Add member functions set_list and show_list.
7249         * cli/cli-style.c (class cli_style_option): Update accordingly.
7250         (style_set_list): Move to file scope.
7251         (style_show_list): Likewise.
7252         (set_style): Call help_list.
7253         (show_style): Call cmd_show_list.
7254         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7255         Update to use the new macro.
7256
7257 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7258
7259         * ada-lang.c (_initialize_ada_language): Expand the help text
7260         for the "catch exception" command.
7261
7262 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7263
7264         * symtab.c (matching_obj_sections): Initialize obj,
7265         declare it closer to its usage.
7266
7267 2019-01-10  Tom Tromey  <tom@tromey.com>
7268
7269         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7270         (basic_inf_threads_range): Remove.
7271         (inf_threads_range, inf_non_exited_threads_range)
7272         (safe_inf_threads_range): Use next_adapter.
7273
7274 2019-01-10  Keith Seitz  <keiths@redhat.com>
7275
7276         PR gdb/23712
7277         PR symtab/23010
7278         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7279         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7280
7281 2019-01-10  Keith Seitz  <keiths@redhat.com>
7282
7283         PR gdb/23712
7284         PR symtab/23010
7285         * dictionary.c (pending_to_vector): Remove.
7286         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7287         Remove _1 suffix, replacing functions of the same name.  Update
7288         all callers.
7289         (dict_create_hashed, dict_create_hashed_expandable)
7290         (dict_create_linear, dict_create_linear_expandable, dict_free)
7291         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7292         Make functions static.
7293
7294 2019-01-10  Keith Seitz  <keiths@redhat.com>
7295
7296         PR gdb/23712
7297         PR symtab/23010
7298         * dictionary.h (struct dictionary): Replace declaration with
7299         multidictionary.
7300         (dict_create_hashed, dict_create_hashed_expandable)
7301         (dict_create_linear, dict_create_linear_expandable)
7302         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7303         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7304         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7305         taking multidictionary argument.
7306         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7307         * block.h (struct block) <dict>: Change to multidictionary
7308         and rename `multidict'.
7309         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7310         symmisc.c: Update all dictionary references to multidictionary.
7311
7312 2019-01-10  Keith Seitz  <keiths@redhat.com>
7313
7314         PR gdb/23712
7315         PR symtab/23010
7316         * dictionary.c: Include unordered_map.
7317         (pending_to_vector): New function.
7318         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7319         Rewrite the non-"_1" functions to take vector instead
7320         of linked list.
7321         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7322         "new" _1 versions of the same name.
7323         (multidictionary): Define.
7324         (std::hash<enum language): New definition.
7325         (collate_pending_symbols_by_language, mdict_create_hashed)
7326         (mdict_create_hashed_expandable, mdict_create_linear)
7327         (mdict_create_linear_expandable, mdict_free)
7328         (find_language_dictionary, create_new_language_dictionary)
7329         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7330         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7331         (mdict_size, mdict_empty): New functions.
7332         * dictionary.h (mdict_iterator): Define.
7333
7334 2019-01-10  Pedro Alves  <palves@redhat.com>
7335
7336         * breakpoint.c (read_uploaded_action)
7337         (create_tracepoint_from_upload): Adjust to use
7338         gdb::unique_xmalloc_ptr.
7339         * ctf.c (ctf_write_uploaded_tp):
7340         (SET_ARRAY_FIELD): Use emplace_back.
7341         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7342         * tracefile-tfile.c (tfile_write_uploaded_tp):
7343         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7344         gdb::unique_xmalloc_ptr.
7345         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7346         at_string, cond_string, cmd_strings>: Replace char pointers
7347         with gdb::unique_xmalloc_ptr.
7348
7349 2019-01-10  Pedro Alves  <palves@redhat.com>
7350
7351         * solib-target.c (library_list_start_library): Don't xstrdup name.
7352
7353 2019-01-10  Pedro Alves  <palves@redhat.com>
7354
7355         * mdebugread.c (parse_partial_symbols): Use
7356         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7357
7358 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7359
7360         * linux-fork.c (scoped_switch_fork_info)
7361         <~scoped_switch_fork_info>: Fix incorrect variable name.
7362
7363 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7364
7365         * linux-fork.c (scoped_switch_fork_info)
7366         <scoped_switch_fork_info>: Make explicit.
7367         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7368
7369 2019-01-10  Tom Tromey  <tom@tromey.com>
7370
7371         * objfiles.h (objfile::reset_psymtabs): Update.
7372         * objfiles.c (objfile::objfile): Update.
7373         * psymtab.h (psymtab_storage::obstack): Update.
7374         (psymtab_storage::m_obstack): Use gdb::optional.
7375         (class psymtab_storage): Update comment.  Remove objfile
7376         parameter.
7377         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7378
7379 2019-01-10  Tom Tromey  <tom@tromey.com>
7380
7381         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7382         <free_psymtabs>: Now private.
7383         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7384         (allocate_psymtab): Use new method.
7385
7386 2019-01-10  Tom Tromey  <tom@tromey.com>
7387
7388         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7389         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7390         * mdebugread.c (parse_partial_symbols): Use
7391         allocate_dependencies.
7392         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7393         allocate_dependencies.
7394         (process_psymtab_comp_unit_reader)
7395         (build_type_psymtab_dependencies): Likewise.
7396         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7397
7398 2019-01-10  Tom Tromey  <tom@tromey.com>
7399
7400         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7401         PSYMBOL_SET_LANGUAGE.
7402         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7403
7404 2019-01-10  Tom Tromey  <tom@tromey.com>
7405
7406         * psymtab.h (psymtab_storage::obstack): New method.
7407         <m_obstack>: Rename from obstack; now private.
7408         * psymtab.c (psymtab_storage): Update.
7409         * dwarf2read.c (create_addrmap_from_index)
7410         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7411         Update.
7412
7413 2019-01-10  Tom Tromey  <tom@tromey.com>
7414
7415         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7416         * objfiles.h (objfile::reset_psymtabs): New method.
7417
7418 2019-01-10  Tom Tromey  <tom@tromey.com>
7419
7420         * symmisc.c (print_symbol_bcache_statistics): Update.
7421         (print_objfile_statistics): Update.
7422         * symfile.c (reread_symbols): Update.
7423         * psymtab.h (class psymtab_storage): New.
7424         * psymtab.c (psymtab_storage): New constructor.
7425         (~psymtab_storage): New destructor.
7426         (require_partial_symbols): Update.
7427         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7428         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7429         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7430         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7431         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7432         (start_psymtab_common, end_psymtab_common)
7433         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7434         (allocate_psymtab): Update.
7435         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7436         Update.
7437         (dump_psymtab_addrmap, maintenance_print_psymbols)
7438         (maintenance_check_psymtabs): Update.
7439         (class objfile_psymtabs): Move to objfiles.h.
7440         * psympriv.h (discard_psymtab): Now inline.
7441         (psymtab_discarder::psymtab_discarder): Update.
7442         (psymtab_discarder::~psymtab_discarder): Update.
7443         (ALL_OBJFILE_PSYMTABS): Rewrite.
7444         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7445         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7446         Remove fields.
7447         <partial_symtabs>: New field.
7448         (class objfile_psymtabs): Move from psymtab.h.  Update.
7449         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7450         psymbol_cache.
7451         (objfile::~objfile): Don't destroy psymbol_cache.
7452         * mdebugread.c (parse_partial_symbols): Update.
7453         * dwarf2read.c (create_addrmap_from_index)
7454         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7455         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7456         (add_partial_subprogram, dwarf2_ranges_read): Update.
7457         * dwarf-index-write.c (write_address_map)
7458         (write_one_signatured_type, recursively_write_psymbols)
7459         (class debug_names, class debug_names, write_psymtabs_to_index):
7460         Update.
7461
7462 2019-01-10  Tom Tromey  <tom@tromey.com>
7463
7464         * symtab.h (SYMBOL_SET_NAMES): Update.
7465         (symbol_set_names): Update.
7466         (MSYMBOL_SET_NAMES): Update.
7467         * symtab.c (symbol_set_names): Change argument to be an
7468         objfile_per_bfd_storage.
7469         * psymtab.c (add_psymbol_to_bcache): Update.
7470         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7471
7472 2019-01-10  Tom Tromey  <tom@tromey.com>
7473
7474         * symtab.c (create_demangled_names_hash): Change argument to be an
7475         objfile_per_bfd_storage.
7476         (symbol_set_names): Update.
7477
7478 2019-01-10  Tom Tromey  <tom@tromey.com>
7479
7480         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7481         init_psymbol_list.
7482         * psymtab.c (init_psymbol_list): Do nothing if already called.
7483         * psympriv.h (init_psymbol_list): Add comment.
7484         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7485         init_psymbol_list.
7486         * dbxread.c (dbx_symfile_read): Unconditionally call
7487         init_psymbol_list.
7488
7489 2019-01-10  Tom Tromey  <tom@tromey.com>
7490
7491         * xcoffread.c (scan_xcoff_symtab): Update.
7492         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7493         "where".
7494         * mdebugread.c (parse_partial_symbols)
7495         (handle_psymbol_enumerators): Update.
7496         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7497         * dbxread.c (read_dbx_symtab): Update.
7498         * psympriv.h (psymbol_placement): New enum.
7499         (add_psymbol_to_list): Update.
7500
7501 2019-01-10  Tom Tromey  <tom@tromey.com>
7502
7503         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7504         static_psymbols parameters.
7505         (scan_xcoff_symtab): Update.
7506         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7507         static_psymbols parameters.
7508         * psympriv.h (start_psymtab_common): Update.
7509         * mdebugread.c (parse_partial_symbols): Update.
7510         * dwarf2read.c (create_partial_symtab): Update.
7511         * dbxread.c (read_dbx_symtab): Update.
7512         (start_psymtab): Remove global_psymbols and static_psymbols
7513         parameters.
7514
7515 2019-01-10  Tom Tromey  <tom@tromey.com>
7516
7517         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7518         * psymtab.c (allocate_psymtab): Add comment.
7519         * psympriv.h (allocate_psymtab): Add comment.
7520         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7521         initializations.
7522         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7523
7524 2019-01-10  Tom Tromey  <tom@tromey.com>
7525
7526         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7527         Don't declare.
7528         * mipsread.c: Include mdebugread.h.
7529         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7530         Declare.
7531         * elfread.c: Include mdebugread.h.
7532
7533 2019-01-09  Tom Tromey  <tom@tromey.com>
7534
7535         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7536         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7537         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7538         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7539         (psym_lookup_symbol, psym_find_last_source_symtab)
7540         (psym_forget_cached_source_info, psym_print_stats)
7541         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7542         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7543         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7544         (psym_find_compunit_symtab_by_address)
7545         (maintenance_print_psymbols, maintenance_info_psymtabs)
7546         (maintenance_check_psymtabs): Use ranged for.
7547         * psymtab.h (class objfile_psymtabs): New.
7548         (require_partial_symbols): Return objfile_psymtabs.
7549         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7550
7551 2019-01-09  Tom Tromey  <tom@tromey.com>
7552
7553         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7554         (find_pc_mapped_section, list_overlays_command)
7555         (map_overlay_command, unmap_overlay_command)
7556         (simple_overlay_update): Use all_objfiles.
7557         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7558         * printcmd.c (info_symbol_command): Use all_objfiles.
7559         * objfiles.h (ALL_OBJSECTIONS): Remove.
7560         * maint.c (maintenance_translate_address): Use all_objfiles.
7561         * gcore.c (gcore_create_callback): Use all_objfiles.
7562         (objfile_find_memory_regions): Likewise.
7563
7564 2019-01-09  Tom Tromey  <tom@tromey.com>
7565
7566         * symtab.c (find_line_symtab, info_sources_command)
7567         (make_source_files_completion_list): Use objfile_compunits.
7568         * source.c (select_source_symtab): Use objfile_compunits.
7569         * objfiles.h (struct objfile): Update comment.
7570         (ALL_OBJFILES): Remove.
7571         (ALL_FILETABS): Remove.
7572         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7573         objfile_compunits.
7574
7575 2019-01-09  Tom Tromey  <tom@tromey.com>
7576
7577         * symmisc.c (print_objfile_statistics, dump_objfile)
7578         (maintenance_print_symbols): Use compunit_filetabs.
7579         * source.c (forget_cached_source_info_for_objfile): Use
7580         compunit_filetabs.
7581         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7582         (ALL_FILETABS): Use compunit_filetabs.
7583         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7584         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7585
7586 2019-01-09  Tom Tromey  <tom@tromey.com>
7587
7588         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7589         (compunit_filetabs): New.
7590         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7591         compunit_filetabs.
7592         (info_sources_command, make_source_files_completion_list): Remove
7593         declaration.
7594         * symmisc.c (print_objfile_statistics, dump_objfile)
7595         (maintenance_print_symbols): Remove declaration.
7596         (maintenance_info_symtabs): Use compunit_filetabs.
7597         (maintenance_info_line_tables): Likewise.
7598         * source.c (select_source_symtab): Change local variable name.
7599         (forget_cached_source_info_for_objfile): Remove declaration.
7600         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7601         * objfiles.c (objfile_relocate1): Remove declaration.
7602         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7603         declaration.
7604         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7605         * coffread.c (coff_symtab_read): Remove declaration.
7606         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7607         compunit_filetabs.
7608
7609 2019-01-09  Tom Tromey  <tom@tromey.com>
7610
7611         * symtab.c (lookup_objfile_from_block)
7612         (find_pc_sect_compunit_symtab, search_symbols)
7613         (default_collect_symbol_completion_matches_break_on): Use
7614         objfile_compunits.
7615         * objfiles.h (ALL_COMPUNITS): Remove.
7616         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7617         * cp-support.c (add_symbol_overload_list_qualified): Use
7618         objfile_compunits.
7619         * ada-lang.c (ada_collect_symbol_completion_matches)
7620         (ada_add_global_exceptions): Use objfile_compunits.
7621
7622 2019-01-09  Tom Tromey  <tom@tromey.com>
7623
7624         * source.c (select_source_symtab)
7625         (forget_cached_source_info_for_objfile): Remove declaration.
7626         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7627         declaration.
7628         * maint.c (count_symtabs_and_blocks): Remove declaration.
7629         * cp-support.c (add_symbol_overload_list_qualified): Remove
7630         declaration.
7631         * coffread.c (coff_symtab_read): Remove declaration.
7632         * symtab.c (lookup_symbol_in_objfile_symtabs)
7633         (basic_lookup_transparent_type_1): Use objfile_compunits.
7634         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7635         (info_sources_command, search_symbols)
7636         (default_collect_symbol_completion_matches_break_on)
7637         (make_source_files_completion_list): Remove declaration.
7638         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7639         (ada_collect_symbol_completion_matches)
7640         (ada_add_global_exceptions): Remove declaration.
7641         * linespec.c (iterate_over_all_matching_symtabs): Use
7642         objfile_compunits.
7643         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7644         (class objfile_compunits): New.
7645         (ALL_COMPUNITS): Use objfile_compunits.
7646         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7647         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7648         objfile_compunits.
7649         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7650
7651 2019-01-09  Tom Tromey  <tom@tromey.com>
7652
7653         * symtab.c (search_symbols)
7654         (default_collect_symbol_completion_matches_break_on): Use
7655         objfile_msymbols.
7656         * ada-lang.c (ada_lookup_simple_minsym)
7657         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7658         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7659         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7660         objfile_msymbols.
7661         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7662         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7663         * objc-lang.c (find_methods): Use objfile_msymbols.
7664         (info_selectors_command, info_classes_command): Likewise.
7665         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7666         * objfiles.h (class objfile_msymbols): New.
7667         (ALL_OBJFILE_MSYMBOLS): Remove.
7668         (ALL_MSYMBOLS): Remove.
7669
7670 2019-01-09  Tom Tromey  <tom@tromey.com>
7671
7672         * common/next-iterator.h (next_adapter): Add Iterator template
7673         parameter.
7674         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7675         (class all_objfiles_safe): New.
7676         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7677         * objfiles.c (put_objfile_before): Update comment.
7678         (add_separate_debug_objfile): Likewise.
7679         (free_all_objfiles): Use all_objfiles_safe.
7680         (objfile_purge_solibs): Likewise.
7681
7682 2019-01-09  Tom Tromey  <tom@tromey.com>
7683
7684         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7685         (expand_symtab_containing_pc, lookup_static_symbol)
7686         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7687         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7688         all_objfiles.
7689         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7690         * breakpoint.c (create_overlay_event_breakpoint)
7691         (create_longjmp_master_breakpoint)
7692         (create_std_terminate_master_breakpoint)
7693         (create_exception_master_breakpoint): Use all_objfiles.
7694         * linux-thread-db.c (try_thread_db_load_from_pdir)
7695         (has_libpthread): Use all_objfiles.
7696         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7697         * linespec.c (iterate_over_all_matching_symtabs)
7698         (search_minsyms_for_name): Use all_objfiles.
7699         * maint.c (maintenance_info_sections): Use all_objfiles.
7700         * main.c (captured_main_1): Use all_objfiles.
7701         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7702         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7703         * guile/scm-pretty-print.c
7704         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7705         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7706         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7707         (maintenance_print_msymbols): Use all_objfiles.
7708         * source.c (select_source_symtab): Use all_objfiles.
7709         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7710         * symfile.c (remove_symbol_file_command)
7711         (expand_symtabs_matching, map_symbol_filenames): Use
7712         all_objfiles.
7713         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7714         all_objfiles.
7715         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7716         * objc-lang.c (find_methods): Use all_objfiles.
7717         * objfiles.c (have_partial_symbols, have_full_symbols)
7718         (have_minimal_symbols, qsort_cmp)
7719         (default_iterate_over_objfiles_in_search_order): Use
7720         all_objfiles.
7721         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7722         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7723         (maintenance_check_psymtabs): Use all_objfiles.
7724         (ALL_PSYMTABS): Remove.
7725         * compile/compile-object-run.c (do_module_cleanup): Use
7726         all_objfiles.
7727         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7728         * cp-support.c (add_symbol_overload_list_qualified): Use
7729         all_objfiles.
7730         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7731         Use all_objfiles.
7732         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7733         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7734         all_objfiles.
7735         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7736         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7737         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7738         Uses all_objfiles.
7739         * solib.c (solib_read_symbols): Use all_objfiles
7740
7741 2019-01-09  Tom Tromey  <tom@tromey.com>
7742
7743         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7744         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7745         all_objfiles.
7746         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7747         * symmisc.c (print_symbol_bcache_statistics)
7748         (print_objfile_statistics, maintenance_print_objfiles)
7749         (maintenance_info_symtabs, maintenance_check_symtabs)
7750         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7751         all_objfiles.
7752         * source.c (forget_cached_source_info): Use all_objfiles.
7753         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7754         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7755         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7756         * objfiles.c (update_section_map): Use all_objfiles.
7757         (shared_objfile_contains_address_p): Likewise.
7758         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7759         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7760
7761 2019-01-09  Tom Tromey  <tom@tromey.com>
7762
7763         * common/next-iterator.h: New file.
7764         * objfiles.h (class all_objfiles): New.
7765         (struct objfile_iterator): New.
7766
7767 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7768
7769         * NEWS: Move the description of the changed "frame", "select-frame",
7770          and "info frame" commands to the Changed commands section.
7771
7772 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7773
7774         * gdbtypes.c (check_stub_method_group): Remove handling of old
7775         mangling schemes.
7776         * linespec.c (find_methods): Likewise.
7777         * stabsread.c (read_member_functions): Likewise.
7778         * valops.c (search_struct_method): Likewise.
7779         (value_struct_elt_for_reference): Likewise.
7780         * NEWS: Mention this change.
7781
7782 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7783
7784         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7785         print_source_lines.
7786         * source.c (print_source_lines_base): Update line number check.
7787         (print_source_lines): New function.
7788         (source_lines_range::source_lines_range): New function.
7789         * source.h (class source_lines_range): New class.
7790         (print_source_lines): New declaration.
7791
7792 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7793
7794         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7795
7796 2019-01-08  Tom Tromey  <tom@tromey.com>
7797             Simon Marchi  <simon.marchi@ericsson.com>
7798
7799         PR gdb/24060
7800         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7801         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7802         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7803         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7804         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7805         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7806
7807 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7808
7809         * source.c (select_source_symtab): Move header comment to
7810         declaration in source.h.
7811         (forget_cached_source_info_for_objfile): Likewise.
7812         (forget_cached_source_info): Likewise.
7813         (identify_source_line): Likewise.
7814         * source.h (identify_source_line): Move declaration from symtab.h
7815         and add comment from source.c
7816         (print_source_lines): Likewise.
7817         (forget_cached_source_info_for_objfile): Likewise.
7818         (forget_cached_source_info): Likewise.
7819         (select_source_symtab): Likewise.
7820         (enum print_source_lines_flag): Move definition from symtab.h.
7821         * symtab.h (identify_source_line): Move declaration to source.h.
7822         (print_source_lines): Likewise.
7823         (forget_cached_source_info_for_objfile): Likewise.
7824         (forget_cached_source_info): Likewise.
7825         (select_source_symtab): Likewise.
7826         (enum print_source_lines_flag): Move definition to source.h.
7827         * tui/tui-hooks.c: Add 'source.h' include.
7828
7829 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7830
7831         * source.c (print_source_lines_base): Handle requests to print
7832         reverse line number sequences, and guard against empty lines
7833         string.
7834
7835 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7836
7837         * source.c (print_source_lines_base): Fix skip of '\r' if next
7838         character is '\n'.
7839
7840 2019-01-06  Tom Tromey  <tom@tromey.com>
7841
7842         * c-exp.y (struct c_parse_state) <macro_original_text,
7843         expansion_obstack>: New member.
7844         (macro_original_text, expansion_obstack): Remove globals.
7845         (scan_macro_expansion, scanning_macro_expansion)
7846         (finished_macro_expansion): Update.
7847         (scan_macro_cleanup): Remove.
7848         (yylex, c_parse): Update.
7849
7850 2019-01-06  Tom Tromey  <tom@tromey.com>
7851
7852         * c-exp.y (struct c_parse_state) <strings>: New member.
7853         (operator_stoken): Update.
7854
7855 2019-01-06  Tom Tromey  <tom@tromey.com>
7856
7857         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7858         (union type_stack_elt) <typelist_val>: Now a pointer to
7859         std::vector.
7860         (type_stack_cleanup): Don't declare.
7861         (push_typelist): Update.
7862         * parse.c (pop_typelist): Return a std::vector.
7863         (push_typelist): Take a std::vector.
7864         (follow_types): Update.  Do not free args.
7865         (type_stack_cleanup): Remove.
7866         * c-exp.y (struct c_parse_state): New.
7867         (cpstate): New global.
7868         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7869         (nonempty_typelist): Update.
7870         (func_mod): Create a new vector.
7871         (c_parse): Create a c_parse_state.
7872         (check_parameter_typelist): Do not delete params.
7873         (function_method): Update.  Do not delete type_list.
7874
7875 2019-01-06  Tom Tromey  <tom@tromey.com>
7876
7877         PR gdb/28155:
7878         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7879         check_typedef.
7880         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7881         (print_return_value): Likewise.
7882
7883 2019-01-05  Tom Tromey  <tom@tromey.com>
7884
7885         * contrib/cleanup_check.py: Remove.
7886         * contrib/gcc-with-excheck: Remove.
7887         * contrib/exsummary.py: Remove.
7888         * contrib/excheck.py: Remove.
7889
7890 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7891
7892         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7893         NULL. Initialize tpprev to NULL instead of assigning it
7894         to NULL on the next statement.
7895         * windows-nat.c (windows_delete_thread): Remove check for
7896         main_thread_id before printing thread exit notifications.
7897         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7898         Remove thread ID check against main_thread_id.
7899         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7900         windows_delete_thread.
7901         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7902
7903 2019-01-04  Tom Tromey  <tom@tromey.com>
7904
7905         * compile/compile.c (_initialize_compile): Use upper case for
7906         metasyntactic variables.
7907         * symmisc.c (_initialize_symmisc): Use upper case for
7908         metasyntactic variables.
7909         * psymtab.c (_initialize_psymtab): Use upper case for
7910         metasyntactic variables.
7911         * demangle.c (demangle_command): Use upper case for metasyntactic
7912         variables.
7913         (_initialize_demangler): Likewise.
7914         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7915         variables.
7916
7917 2019-01-03  Tom Tromey  <tom@tromey.com>
7918
7919         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7920
7921 2019-01-03  Tom Tromey  <tom@tromey.com>
7922
7923         * python/py-symtab.c (salpy_str): Update.
7924         (struct salpy_sal_object) <symtab>: Now a PyObject.
7925         (salpy_dealloc): Update.
7926         (del_objfile_sal): Use gdbpy_ref.
7927
7928 2019-01-03  Tom Tromey  <tom@tromey.com>
7929
7930         * python/py-type.c (convert_field): Use new_reference.  Return
7931         gdbpy_ref.
7932         (make_fielditem): Return gdbpy_ref.
7933         (typy_fields): Update.
7934         (typy_getitem): Update.
7935         (field_name): Return gdbpy_ref.  Use new_reference.
7936         (typy_iterator_iternext): Update.
7937
7938 2019-01-03  Tom Tromey  <tom@tromey.com>
7939
7940         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7941
7942 2019-01-03  Tom Tromey  <tom@tromey.com>
7943
7944         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7945         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7946         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7947         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7948         (pspy_set_type_printers): Likewise.
7949         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7950         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7951         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7952         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7953         (objfpy_set_type_printers): Likewise.
7954
7955 2019-01-03  Tom Tromey  <tom@tromey.com>
7956
7957         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7958         (gdbpy_print_stack): Use gdbpy_err_fetch.
7959         * python/python-internal.h (class gdbpy_err_fetch): New class.
7960         (class gdbpy_enter) <m_error_type, m_error_value,
7961         m_error_traceback>: Remove.
7962         <m_error>: New member.
7963         (gdbpy_exception_to_string): Don't declare.
7964         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7965         * python/py-value.c (convert_value_from_python): Use
7966         gdbpy_err_fetch.
7967         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7968         gdbpy_exception_to_string.
7969         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7970         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7971         gdbpy_err_fetch.
7972
7973 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7974
7975         * linux-nat.c (delete_lwp_cleanup): Delete.
7976         (struct lwp_deleter): New struct.
7977         (lwp_info_up): New typedef.
7978         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7979         lwp_info_up.
7980
7981 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7982
7983         * linux-fork.c (class scoped_switch_fork_info): New class.
7984         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7985
7986 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7987
7988         * valops.c (find_overload_match): Remove use of null_cleanup, and
7989         calls to do_cleanups.
7990
7991 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7992
7993         * compile/compile-cplus-types.c
7994         (compile_cplus_instance::decl_name): Handle changes to
7995         cp_func_name.
7996         * cp-support.c (cp_func_name): Update header comment, update
7997         return type.
7998         * cp-support.h (cp_func_name): Update return type in declaration.
7999         * valops.c (find_overload_match): Move temp_func local to top
8000         level of function and change its type.  Use temp_func to hold and
8001         delete temporary string obtained from cp_func_name.
8002
8003 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8004
8005         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8006         gdb::char_vector, remove cleanup, and update uses of `msg`.
8007
8008 2019-01-03  Jim Wilson  <jimw@sifive.com>
8009
8010         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8011
8012 2019-01-02  Tom Tromey  <tom@tromey.com>
8013
8014         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8015         (tdesc_parse_xml): Remove cleanups.
8016         * target-descriptions.h (make_cleanup_free_target_description):
8017         Don't declare.
8018         (target_desc_deleter): New struct.
8019         (target_desc_up): New typedef.
8020         * target-descriptions.c (target_desc_deleter::operator()): Rename
8021         from free_target_description.
8022         (make_cleanup_free_target_description): Remove.
8023
8024 2019-01-02  Tom Tromey  <tom@tromey.com>
8025
8026         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8027         constructor, destructor.
8028         (linespec_parser): Remove typedef.
8029         (~linespec_parser): Rename from linespec_parser_delete.
8030         (linespec_lex_to_end, linespec_complete_label)
8031         (linespec_complete): Update.
8032         (decode_line_full): Remove cleanups.
8033         (decode_line_1): Update.
8034
8035 2019-01-02  Tom Tromey  <tom@tromey.com>
8036
8037         * python/python-internal.h (inferior_to_inferior_object): Change
8038         return type.
8039         * python/py-exitedevent.c (create_exited_event_object): Update.
8040         * python/py-inferior.c (inferior_to_inferior_object): Return
8041         gdbpy_ref.
8042         (python_new_inferior, python_inferior_deleted)
8043         (thread_to_thread_object, delete_thread_object)
8044         (build_inferior_list, gdbpy_selected_inferior): Update.
8045         * python/py-infthread.c (create_thread_object): Update.  Also fail
8046         if inferior_to_inferior_object fails.
8047
8048 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8049
8050         * inferior.h (class inferior) <displaced_step_state>: New field.
8051         * infrun.h (struct displaced_step_state): Move here from
8052         infrun.c.  Initialize fields, add constructor.
8053         <inf>: Remove field.
8054         <reset>: New method.
8055         * infrun.c (struct displaced_step_inferior_state): Move to
8056         infrun.h.
8057         (displaced_step_inferior_states): Remove.
8058         (get_displaced_stepping_state): Adust.
8059         (displaced_step_in_progress_any_inferior): Adjust.
8060         (displaced_step_in_progress_thread): Adjust.
8061         (displaced_step_in_progress): Adjust.
8062         (add_displaced_stepping_state): Remove.
8063         (get_displaced_step_closure_by_addr): Adjust.
8064         (remove_displaced_stepping_state): Remove.
8065         (infrun_inferior_exit): Call displaced_step_state.reset.
8066         (use_displaced_stepping): Don't check for NULL.
8067         (displaced_step_prepare_throw): Call
8068         get_displaced_stepping_state.
8069         (displaced_step_fixup): Don't check for NULL.
8070         (prepare_for_detach): Don't check for NULL.
8071
8072 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8073
8074         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8075          in case of call that did not complete.
8076
8077 2019-01-02  Andrey Utkin  <autkin@undo.io>
8078
8079         * symfile.c (find_separate_debug_file): Fix search of debug files for
8080         remote debuggee.
8081
8082 2019-01-02  Tom Tromey  <tom@tromey.com>
8083
8084         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8085         indentation.
8086         * python/py-frame.c (frapy_older): Remove cast.
8087         (frapy_newer): Likewise.
8088         * python/py-breakpoint.c (local_setattro): Remove cast.
8089         * python/py-arch.c (archpy_name): Remove local variable.
8090         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8091
8092 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8093
8094         * unittests/basic_string_view/element_access/char/empty.cc:
8095         Fix year range in copyright header.
8096
8097 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8098
8099         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8100         Delete.
8101         <operator==>: Update with for removed field.
8102         <hash>: Likewise.
8103         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8104         <isa_features>: ...this.
8105         <abi_features>: New field.
8106         (riscv_isa_flen): Update comment.
8107         (riscv_abi_xlen): New declaration.
8108         (riscv_abi_flen): New declaration.
8109         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8110         isa_features.
8111         (riscv_abi_xlen): New function.
8112         (riscv_isa_flen): Update to get answer from isa_features.
8113         (riscv_abi_flen): New function.
8114         (riscv_has_fp_abi): Update to get answer from abi_features.
8115         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8116         xlen and flen.
8117         (riscv_call_info) <xlen, flen>: Update comment.
8118         (riscv_call_arg_struct): Remove invalid assertions
8119         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8120         is removed.
8121         (riscv_gdbarch_init): Gather isa features and abi features
8122         separately, ensure both match on the gdbarch when reusing an old
8123         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8124         a target with 64-bit float hardware.
8125
8126 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8127
8128         * source.c (search_command_helper): Stop reverse search
8129         when line 1 has been searched.
8130
8131 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8132
8133         * record-full.c (record_full_base_target::close): Rewrite
8134         record_full_core_buf_list free logic.
8135
8136 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8137
8138         * break-catch-syscall.c (print_one_catch_syscall): xfree
8139         the last text.
8140
8141 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8142
8143         * top.c (print_gdb_version): Update Copyright year in version
8144         message.
8145
8146 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8147
8148         Update copyright year range in all GDB files.
8149
8150 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8151
8152         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8153
8154 For older changes see ChangeLog-2018.
8155 \f
8156 Local Variables:
8157 mode: change-log
8158 left-margin: 8
8159 fill-column: 74
8160 version-control: never
8161 coding: utf-8
8162 End:
8163