gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tom@tromey.com>
   2
   3         * remote.c (remote_pspace_data): Change type.
   4         (remote_pspace_data_cleanup): Remove.
   5         (get_remote_exec_file, set_pspace_remote_exec_file)
   6         (_initialize_remote): Update.
   7
   8 2019-05-08  Tom Tromey  <tom@tromey.com>
   9
  10         * breakpoint.c (breakpoint_objfile_key): Change type.
  11         (get_breakpoint_objfile_data): Update.
  12         (free_breakpoint_objfile_data): Remove.
  13         (_initialize_breakpoint): Update.
  14
  15 2019-05-08  Tom Tromey  <tom@tromey.com>
  16
  17         * linux-tdep.c (struct linux_info): Add initializers.
  18         (linux_inferior_data): Move.  Change type.
  19         (invalidate_linux_cache_inf): Update.
  20         (linux_inferior_data_cleanup): Remove.
  21         (get_linux_inferior_data, _initialize_linux_tdep): Update.
  22
  23 2019-05-08  Tom Tromey  <tom@tromey.com>
  24
  25         * auxv.c (auxv_inferior_data): Move.  Change type.
  26         (auxv_inferior_data_cleanup): Remove.
  27         (invalidate_auxv_cache_inf): Rewrite.
  28         (get_auxv_inferior_data, _initialize_auxv): Update.
  29
  30 2019-05-08  Tom Tromey  <tom@tromey.com>
  31
  32         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
  33         (symfile_debug_objfile_data_key): Change type.
  34         (symfile_debug_installed, debug_qf_has_symbols)
  35         (debug_qf_find_last_source_symtab)
  36         (debug_qf_forget_cached_source_info)
  37         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
  38         (debug_qf_print_stats, debug_qf_dump)
  39         (debug_qf_expand_symtabs_for_function)
  40         (debug_qf_expand_all_symtabs)
  41         (debug_qf_expand_symtabs_with_fullname)
  42         (debug_qf_map_matching_symbols)
  43         (debug_qf_expand_symtabs_matching)
  44         (debug_qf_find_pc_sect_compunit_symtab)
  45         (debug_qf_map_symbol_filenames)
  46         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
  47         (debug_sym_new_init, debug_sym_init, debug_sym_read)
  48         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
  49         (debug_sym_read_linetable, debug_sym_relocate): Update.
  50         (symfile_debug_free_objfile): Remove.
  51         (install_symfile_debug_logging, _initialize_symfile_debug):
  52         Update.
  53
  54 2019-05-08  Tom Tromey  <tom@tromey.com>
  55
  56         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
  57         allocate_on_obstack.
  58         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
  59         (get_dwarf2_per_objfile): Update.
  60         (set_dwarf2_per_objfile): Remove.
  61         (dwarf2_has_info, dwarf2_get_section_info): Update.
  62         (dwarf2_free_objfile): Remove.
  63         (_initialize_dwarf2_read): Update.
  64
  65 2019-05-08  Tom Tromey  <tom@tromey.com>
  66
  67         * auto-load.c (struct auto_load_pspace_info): Add destructor and
  68         initializers.
  69         <unsupported_script_warning_printed,
  70         script_not_found_warning_printed>: Now bool.
  71         (auto_load_pspace_data): Change type.
  72         (~auto_load_pspace_info): Rename from
  73         auto_load_pspace_data_cleanup.
  74         (get_auto_load_pspace_data, init_loaded_scripts_info)
  75         (clear_section_scripts, maybe_print_unsupported_script_warning)
  76         (maybe_print_script_not_found_warning, _initialize_auto_load):
  77         Update.
  78
  79 2019-05-08  Tom Tromey  <tom@tromey.com>
  80
  81         * objfiles.c (objfile_pspace_info): Add destructor and
  82         initializers.
  83         (objfiles_pspace_data): Change type.
  84         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
  85         (get_objfile_pspace_data): Update.
  86         (objfiles_bfd_data): Change type.
  87         (get_objfile_bfd_data): Update.
  88         (objfile_bfd_data_free, _initialize_objfiles): Remove.
  89
  90 2019-05-08  Tom Tromey  <tom@tromey.com>
  91
  92         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
  93         Change type.
  94         (get_catch_syscall_inferior_data): Update.
  95         (catch_syscall_inferior_data_cleanup): Remove.
  96         (_initialize_break_catch_syscall): Update.
  97
  98 2019-05-08  Tom Tromey  <tom@tromey.com>
  99
 100         * inflow.c (struct terminal_info): Add destructor and
 101         initializers.
 102         (inflow_inferior_data): Change type.
 103         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 104         (get_inflow_inferior_data, inflow_inferior_exit)
 105         (swap_terminal_info, _initialize_inflow): Update.
 106
 107 2019-05-08  Tom Tromey  <tom@tromey.com>
 108
 109         * target-dcache.c (target_dcache_cleanup): Remove.
 110         (target_dcache_aspace_key): Change type.
 111         (target_dcache_init_p, target_dcache_invalidate)
 112         (target_dcache_get, target_dcache_get_or_init)
 113         (_initialize_target_dcache): Update.
 114         * dcache.h (struct dcache_deleter): New.
 115
 116 2019-05-08  Tom Tromey  <tom@tromey.com>
 117
 118         * symtab.c (struct symbol_cache): Add destructor and
 119         initializers.
 120         (symbol_cache_key): Move.  Change type.
 121         (make_symbol_cache, free_symbol_cache): Remove.
 122         (get_symbol_cache): Update.
 123         (symbol_cache_cleanup): Remove.
 124         (ALL_PSPACES, symbol_cache_flush)
 125         (maintenance_print_symbol_cache)
 126         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 127         Update.
 128
 129 2019-05-08  Tom Tromey  <tom@tromey.com>
 130
 131         * symtab.c (struct main_info): Add destructor and initializers.
 132         (main_progspace_key): Move.  Change type.
 133         (get_main_info): Update.
 134         (main_info_cleanup): Remove.
 135         (_initialize_symtab): Update.
 136
 137 2019-05-08  Tom Tromey  <tom@tromey.com>
 138
 139         * registry.h (DECLARE_REGISTRY): Define the _key class.
 140
 141 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 142
 143         * NEWS: Merge two 'New commands' sections.
 144
 145 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 146
 147         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 148         parameter and use Ada language definition instead.
 149         (ada_val_print_ptr): Remove unused language parameter.
 150         (ada_val_print_num): Remove language parameter and use Ada language
 151         definition instead.
 152         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 153         parameter.
 154         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 155         parameter and use Ada language definition instead.
 156         (ada_val_print_1): Update all ada_val_print_xxx calls.
 157         Remove language parameter.
 158         (ada_val_print): Update ada_val_print_1 call.
 159
 160 2019-05-08  Tom Tromey  <tromey@adacore.com>
 161
 162         * remote.c (remote_hw_watchpoint_limit)
 163         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 164         Now static.
 165
 166 2019-05-08  Tom Tromey  <tromey@adacore.com>
 167
 168         * maint.c (_initialize_maint_cmds): Move initialization code to
 169         remote.c.
 170         (watchdog, show_watchdog): Move to remote.c.
 171         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 172         "watchdog" static.
 173         (_initialize_remote): Move initialization code from maint.c.
 174         * defs.h (watchdog): Don't declare.
 175
 176 2019-05-08  Tom Tromey  <tromey@adacore.com>
 177
 178         * tui/tui-interp.c: Include main.h.
 179         * interps.c: Include main.h.
 180         * main.h (interpreter_p): Declare.
 181         * defs.h (interpreter_p): Don't declare.
 182
 183 2019-05-08  Tom Tromey  <tromey@adacore.com>
 184
 185         * dwarf2loc.c: Include dwarf2read.h.
 186         * defs.h (read_unsigned_leb128): Don't declare.
 187         * dwarf2read.h (read_unsigned_leb128): Declare.
 188
 189 2019-05-08  Tom Tromey  <tromey@adacore.com>
 190
 191         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 192         method.
 193
 194 2019-05-08  Tom Tromey  <tromey@adacore.com>
 195
 196         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 197         when no wrap column is set.
 198
 199 2019-05-08  Tom Tromey  <tromey@adacore.com>
 200
 201         * c-lang.c (c_get_string): Handle non-C-style arrays.
 202
 203 2019-05-08  Tom Tromey  <tromey@adacore.com>
 204
 205         * typeprint.c (print_offset_data::update): Print the bit offset,
 206         not the number of bits remaining.
 207
 208 2019-05-08  Tom Tromey  <tromey@adacore.com>
 209
 210         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 211         padding at end of comment.
 212
 213 2019-05-08  Tom Tromey  <tromey@adacore.com>
 214
 215         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 216         Compare main types.
 217
 218 2019-05-06  Tom Tromey  <tom@tromey.com>
 219
 220         * common/scoped_mmap.c: Include common-defs.h.
 221         * common/scoped_mmap.h: Don't include config.h.
 222
 223 2019-05-04  Tom Tromey  <tom@tromey.com>
 224
 225         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 226         (struct aarch64_call_info): Add initializers.
 227         <si>: Now a std::vector.
 228         (pass_on_stack, aarch64_push_dummy_call): Update.
 229
 230 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 231             Tom Tromey  <tom@tromey.com>
 232
 233         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 234         (ppc_threads): Now a std::vector.  Now static.
 235         (hwdebug_find_thread_points_by_tid)
 236         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 237         Update.
 238
 239 2019-05-04  Tom Tromey  <tom@tromey.com>
 240
 241         * arc-tdep.c (arc_tdesc_init): Return bool.
 242
 243 2019-05-04  Tom Tromey  <tom@tromey.com>
 244
 245         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 246         Use gdb_assert_not_reached.
 247
 248 2019-05-04  Tom Tromey  <tom@tromey.com>
 249
 250         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 251         "false".
 252
 253 2019-05-04  Tom Tromey  <tom@tromey.com>
 254
 255         * arc-tdep.c (arc_tdesc_init): Use bool.
 256
 257 2019-05-04  Tom Tromey  <tom@tromey.com>
 258
 259         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 260
 261 2019-05-04  Tom Tromey  <tom@tromey.com>
 262
 263         * cli/cli-cmds.c (valid_command_p): Return bool.
 264
 265 2019-05-04  Tom Tromey  <tom@tromey.com>
 266
 267         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 268         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 269
 270 2019-05-04  Raul Tambre  <raul@tambre.ee>
 271
 272         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 273         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 274         operator for comparison.
 275
 276 2019-05-04  Tom Tromey  <tom@tromey.com>
 277
 278         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 279         (lookup_partial_symbol, print_partial_symbols)
 280         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 281         (psymbol_compare): Update.
 282         (add_psymbol_to_bcache): Clear the entire psymbol.
 283         (maintenance_check_psymtabs): Update.
 284         * psympriv.h (struct partial_symbol): Don't derive from
 285         general_symbol_info.
 286         <obj_section, unrelocated_address, address,
 287         set_unrelocated_address>: Update.
 288         <ginfo>: New member.
 289         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 290         (debug_names::write_psymbols): Update.
 291
 292 2019-05-04  Tom de Vries  <tdevries@suse.de>
 293
 294         * contrib/cc-with-tweaks.sh: Support -n arg.
 295
 296 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 297
 298         * corelow.c (core_target::detach): Ensure frame cache and
 299         register caches are cleared.
 300         inferior.c (exit_inferior_1): Likewise.
 301
 302 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 303             Tom Tromey  <tom@tromey.com>
 304
 305         * dictionary.c (collate_pending_symbols_by_language): Remove
 306         "struct" from foreach.
 307         * symtab.c (lookup_global_symbol_from_objfile)
 308         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 309         foreach.
 310         * ser-tcp.c (net_open): Remove "struct" from foreach.
 311         * objfiles.c (objfile_relocate, objfile_rebase)
 312         (objfile_has_symbols): Remove "struct" from foreach.
 313         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 314         from foreach.
 315         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 316         foreach.
 317         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 318         "struct" from foreach.
 319         * ada-lang.c (create_excep_cond_exprs)
 320         (ada_exception_catchpoint_cond_string): Remove "struct" from
 321         foreach.
 322
 323 2019-05-03  Tom Tromey  <tromey@adacore.com>
 324
 325         * ada-exp.y (convert_char_literal): Check suffix of each
 326         enumerator.
 327
 328 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 329
 330         PR ada/21406:
 331         * ada-exp.y (yywrap): Don't define.
 332         * ada-lex.l (%option): Add noyywrap
 333         (yywrap): Remove.
 334
 335 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 336
 337         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 338         _WIN32_WINNT to the XP level, unless already defined to a higher
 339         level.
 340
 341         * unittests/parse-connection-spec-selftests.c:
 342         * ser-tcp.c:
 343         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 344         override.
 345
 346         * symfile.c (find_separate_debug_file): Remove colon from the
 347         drive spec of DOS/Windows file names of the target, so that the
 348         file name produced from DEBUGDIR and the target's directory will
 349         be valid on DOS/Windows systems.
 350
 351 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 352
 353         * rust-lang.c (val_print_struct): Handle printing structures
 354         containing strings.
 355
 356 2019-05-02  Tom Tromey  <tromey@adacore.com>
 357
 358         * valarith.c (_initialize_valarith): Remove.
 359
 360 2019-05-01  Tom Tromey  <tromey@adacore.com>
 361
 362         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 363         bitfields.
 364
 365 2019-05-01  Tom Tromey  <tromey@adacore.com>
 366
 367         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 368         for big-endian copies.
 369
 370 2019-04-30  Ali Tamur  <tamur@google.com>
 371         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 372         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 373         (read_3_bytes): New function.
 374
 375 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 376
 377         * windows-nat.c (main_thread_id): Delete.
 378         (handle_output_debug_string): Replace main_thread_id by
 379         current_event.dwThreadId.
 380         (fake_create_process): Likewise.
 381         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 382         Do not set main_thread_id.
 383         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 384         current_event.dwThreadId.
 385         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 386
 387 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 388
 389         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 390         Use current_event.dwThreadId instead of main_thread_id.
 391
 392 2019-04-30  Tom Tromey  <tromey@adacore.com>
 393
 394         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 395         (create_excep_cond_exprs): Iterate over program spaces.
 396         (ada_exception_catchpoint_cond_string): Examine all minimal
 397         symbols for exception types.
 398
 399 2019-04-30  Tom Tromey  <tromey@adacore.com>
 400
 401         PR c++/24470:
 402         * dwarf2read.c (process_structure_scope): Handle case where type
 403         has template parameters but no symbol was created.
 404
 405 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 406             Chris January  <chris.january@arm.com>
 407
 408         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 409         qualifier.
 410         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 411
 412 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 413
 414         * f-typeprint.c (f_print_type): Update rules for printing
 415         whitespace.
 416         (f_type_print_varspec_suffix): Likewise.
 417
 418 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 419             Chris January  <chris.january@arm.com>
 420
 421         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 422         function arguments.
 423
 424 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 425
 426         * f-lang.c (build_fortran_types): Change name of void type to
 427         lower case.
 428         * f-typeprint.c (f_type_print_base): Print the name of the void
 429         type, rather than a fixed string.
 430         * f-valprint.c (f_decorations): Use lower case void string.
 431
 432 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 433             Chris January  <chris.january@arm.com>
 434
 435         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 436         types for Fortran.
 437
 438 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 439             Chris January  <chris.january@arm.com>
 440             David Lecomber  <david.lecomber@arm.com>
 441
 442         * f-exp.y (BINOP_INTRINSIC): New token.
 443         (exp): New parser rule handling BINOP_INTRINSIC.
 444         (f77_keywords): Add new builtin procedures.
 445         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 446         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 447         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 448         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 449         (print_unop_subexp_f): New function.
 450         (print_binop_subexp_f): New function.
 451         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 452         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 453         (dump_subexp_body_f): Likewise.
 454         (operator_check_f): Likewise.
 455         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 456         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 457
 458 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 459
 460         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 461         UNOP_KIND.
 462         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 463         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 464         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 465         (operator_length_f): New fuction.
 466         (print_subexp_f): New function.
 467         (op_name_f): New function.
 468         (dump_subexp_body_f): New function.
 469         (operator_check_f): New function.
 470         (exp_descriptor_f): Replace standard expression handling functions
 471         with new functions.
 472         * gdb/fortran-operator.def: New file.
 473         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 474         * gdb/std-operator.def: Remove UNOP_KIND.
 475
 476 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 477
 478         * std-operator.def: Remove unbalanced, stray double quote
 479         character.
 480
 481 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 482             Chris January  <chris.january@arm.com>
 483             Daniel Everett  <daniel.everett@arm.com>
 484             Nick Forrington  <nick.forrington@arm.com>
 485             Richard Bunt  <richard.bunt@arm.com>
 486
 487         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 488         of depth when printing anonymous structs or unions.
 489         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 490         Don't print either the top-level value, or the children if the
 491         max-depth is exceeded.
 492         (ppscm_print_children): When printing the key of a map, allow one
 493         extra level of depth.
 494         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 495         print either the top-level value, or the children if the max-depth
 496         is exceeded.
 497         (print_children): When printing the key of a map, allow one extra
 498         level of depth.
 499         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 500         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 501         (user_print_options): Initialise max_depth field.
 502         (val_print_scalar_or_string_type_p): New function.
 503         (val_print): Check to see if the max depth has been reached.
 504         (val_print_check_max_depth): Define new function.
 505         (show_print_max_depth): New function.
 506         (_initialize_valprint): Add 'print max-depth' option.
 507         * valprint.h (struct value_print_options) <max_depth>: New field.
 508         (val_print_check_max_depth): Declare new function.
 509         * NEWS: Document new feature.
 510
 511 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 512
 513         * ada-lang.c (ada_language_defn): Initialise new field.
 514         * c-lang.c (c_is_string_type_p): New function.
 515         (c_language_defn): Initialise new field.
 516         (cplus_language_defn): Initialise new field.
 517         (asm_language_defn): Initialise new field.
 518         (minimal_language_defn): Initialise new field.
 519         * c-lang.h (c_is_string_type_p): Declare new function.
 520         * d-lang.c (d_language_defn): Initialise new field.
 521         * f-lang.c (f_is_string_type_p): New function.
 522         (f_language_defn): Initialise new field.
 523         * go-lang.c (go_is_string_type_p): New function.
 524         (go_language_defn): Initialise new field.
 525         * language.c (default_is_string_type_p): New function.
 526         (unknown_language_defn): Initialise new field.
 527         (auto_language_defn): Initialise new field.
 528         * language.h (struct language_defn) <la_is_string_type_p>: New
 529         member variable.
 530         (default_is_string_type_p): Declare new function.
 531         * m2-lang.c (m2_language_defn): Initialise new field.
 532         * objc-lang.c (objc_language_defn): Initialise new field.
 533         * opencl-lang.c (opencl_language_defn): Initialise new field.
 534         * p-lang.c (pascal_is_string_type_p): New function.
 535         (pascal_language_defn): Initialise new field.
 536         * rust-lang.c (rust_is_string_type_p): New function.
 537         (rust_language_defn): Initialise new field.
 538
 539 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 540
 541         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 542         New field.
 543         * ada-lang.c (ada_language_defn): Initialise new field.
 544         * c-lang.c (c_language_defn): Likewise.
 545         (cplus_language_defn): Likewise.
 546         (asm_language_defn): Likewise.
 547         (minimal_language_defn): Likewise.
 548         * d-lang.c (d_language_defn): Likewise.
 549         * f-lang.c (f_language_defn): Likewise.
 550         * go-lang.c (go_language_defn): Likewise.
 551         * language.c (unknown_language_defn): Likewise.
 552         (auto_language_defn): Likewise.
 553         * m2-lang.c (m2_language_defn): Likewise.
 554         * objc-lang.c (objc_language_defn): Likewise.
 555         * opencl-lang.c (opencl_language_defn): Likewise.
 556         * p-lang.c (pascal_language_defn): Likewise.
 557         * rust-lang.c (rust_language_defn): Likewise.
 558
 559 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 560
 561         * ada-lang.c (ada_is_character_type): Change return type to bool.
 562         (ada_is_string_type): Likewise.
 563         * ada-lang.h (ada_is_character_type): Update declaration
 564         (ada_is_string_type): Likewise.
 565
 566 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 567
 568         Support style in 'frame|thread apply'
 569
 570         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 571         * record.c (record_start, record_stop): Update callers of
 572         execute_command_to_string with false.
 573         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 574         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 575         methods.
 576         (class string_file): New constructor with term_out parameter.
 577         Override methods term_out and can_emit_style_escape.  New member
 578         term_out.
 579         (class stdio_file): Override can_emit_style_escape.
 580         (class tee_file): Override term_out and can_emit_style_escape.
 581         * utils.h (can_emit_style_escape): Remove.
 582         * utils.c (can_emit_style_escape): Likewise.
 583         Update all callers of can_emit_style_escape (SOMESTREAM) to
 584         SOMESTREAM->can_emit_style_escape.
 585         * source-cache.c (source_cache::get_source_lines): Likewise.
 586         * stack.c (frame_apply_command_count): Call execute_command_to_string
 587         passing the term_out characteristic of the current gdb_stdout.
 588         * thread.c (thr_try_catch_cmd): Likewise.
 589         * top.c (execute_command_to_string): pass term_out parameter
 590         to construct the string_file for the command output.
 591         * ui-file.c (term_cli_styling): New function (most code moved
 592         from utils.c can_emit_style_escape).
 593         (string_file::string_file, string_file::can_emit_style_escape,
 594         stdio_file::can_emit_style_escape, tee_file::term_out,
 595         tee_file::can_emit_style_escape): New functions.
 596
 597 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 598
 599         * NEWS: Mention the new set|show may-call-functions.
 600         * infcall.c (may_call_functions_p): New variable.
 601         (show_may_call_functions_p): New function.
 602         (call_function_by_hand_dummy): Throws an error if not
 603         may-call-functions.
 604         (_initialize_infcall): Call add_setshow_boolean_cmd for
 605         may-call-functions.
 606
 607 2019-04-25  Keith Seitz  <keiths@redhat.com>
 608
 609         PR c++/24367
 610         * cp-support.c (inspect_type): Don't attempt substitutions
 611         of symbol with the same name.
 612
 613 2019-04-25  Tom Tromey  <tromey@adacore.com>
 614
 615         PR gdb/24475:
 616         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 617         static.
 618
 619 2019-04-25  Tom Tromey  <tromey@adacore.com>
 620
 621         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 622         rvalue reference.
 623         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 624         (gdb_xml_parser::parse): Use std::move.
 625         * python/python-internal.h (gdbpy_convert_exception): Take a const
 626         reference.
 627         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 628         std::move.
 629         * python/py-utils.c (gdbpy_convert_exception): Take a const
 630         reference.
 631         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 632         Use std::move.
 633         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 634         Use std::move.
 635         * mi/mi-main.c (mi_print_exception): Take a const reference.
 636         * main.c (handle_command_errors): Take a const reference.
 637         * linespec.c (parse_linespec): Use std::move.
 638         * infcall.c (run_inferior_call): Use std::move.
 639         (call_function_by_hand_dummy): Use std::move.
 640         * exec.c (try_open_exec_file): Use std::move.
 641         * exceptions.h (exception_print, exception_fprintf)
 642         (exception_print_same): Update.
 643         * exceptions.c (print_exception, exception_print)
 644         (exception_fprintf, exception_print_same): Change parameters to
 645         const reference.
 646         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 647         * common/new-op.c: Use std::move.
 648         * common/common-exceptions.h (struct gdb_exception): Add move
 649         constructor.
 650         (struct gdb_exception_error, struct gdb_exception_quit, struct
 651         gdb_quit_bad_alloc): Change constructor to move constructor.
 652         (throw_exception): Change parameter to rvalue reference.
 653         * common/common-exceptions.c (throw_exception): Take rvalue
 654         reference.
 655         * cli/cli-interp.c (safe_execute_command): Use std::move.
 656         * breakpoint.c (insert_bp_location, location_to_sals): Use
 657         std::move.
 658
 659 2019-04-25  Tom Tromey  <tromey@adacore.com>
 660
 661         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 662         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 663         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 664         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 665         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 666         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 667         guile/scm-value.c: Use unpack.
 668         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 669         gdbscm_gdb_exception.
 670         (gdbscm_throw_gdb_exception): Likewise.
 671         (struct gdbscm_gdb_exception): New.
 672         (unpack): New function.
 673         (gdbscm_wrap): Use unpack.
 674
 675 2019-04-25  Tom Tromey  <tromey@adacore.com>
 676
 677         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 678         (gdb_rl_callback_handler): Use std::move.
 679         * common/common-exceptions.h (struct gdb_exception): Add move
 680         assignment operator.
 681         (throw_exception_sjlj): Change "exception" to const reference.
 682         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 683         (throw_exception_sjlj): Change "exception" to const reference.
 684
 685 2019-04-25  Tom Tromey  <tromey@adacore.com>
 686
 687         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 688         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 689         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 690         Update.
 691         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 692         Update.
 693         * mi/mi-interp.c (mi_interp::exec): Update.
 694         * linespec.c (parse_linespec): Update.
 695         * infcall.c (run_inferior_call): Update.
 696         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 697         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 698         (gdbscm_lookup_global_symbol): Update.
 699         * guile/scm-param.c (gdbscm_parameter_value): Update.
 700         * guile/scm-frame.c (gdbscm_frame_read_register)
 701         (gdbscm_frame_read_var): Update.
 702         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 703         * exec.c (try_open_exec_file): Update.
 704         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 705         (gdb_rl_callback_handler): Update.
 706         * common/common-exceptions.h (exception_none): Don't declare.
 707         * common/common-exceptions.c (exception_none): Don't define.
 708         (struct catcher) <exception>: Update.
 709         * cli/cli-interp.c (safe_execute_command): Update.
 710         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 711
 712 2019-04-25  Ali Tamur  <tamur@google.com>
 713
 714         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 715         (read_attribute_value): Likewise.
 716         (dwarf2_read_addr_index): Update comment.
 717         (read_str_index): Add DW_FORM_strx.
 718         (dwarf2_string_attr): Likewise.
 719         (dwarf2_const_value_attr): Likewise.
 720         (dump_die_shallow): Likewise.
 721         (dwarf2_fetch_constant_bytes): Likewise.
 722         (skip_form_bytes): Likewise.
 723         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 724
 725 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 726
 727         PR corefiles/11608
 728         PR corefiles/18187
 729         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 730         OFFSET.  Verify if current mapping contains an ELF header.
 731         (linux_find_memory_regions_full): Adjust call to
 732         dump_mapping_p.
 733
 734 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 735             Kang Li <kanglictf@gmail.com>
 736
 737         PR gdb/21600
 738
 739         * dwarf2-frame.c (read_initial_length): Be consistent about using
 740         unsigned representation of length.
 741         (decode_frame_entry_1): Likewise.  Check for wraparound of
 742         end pointer as well as buffer overflow.
 743
 744 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 745
 746         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 747         "vq".
 748
 749 2019-04-24  Tom Tromey  <tromey@adacore.com>
 750
 751         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 752
 753 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 754
 755         * s12z-tdep.c (s12z_unwind_pc): Delete.
 756         (s12z_unwind_sp): Delete.
 757         (s12z_gdbarch_init): Don't register deleted functions with
 758         gdbarch.
 759
 760 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 761
 762         * rl78-tdep.c (rl78_unwind_sp): Delete.
 763         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 764
 765 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 766
 767         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 768         (xstormy16_unwind_pc): Delete.
 769         (xstormy16_dummy_id): Delete.
 770         (xstormy16_gdbarch_init): Don't register deleted functions with
 771         gdbarch.
 772
 773 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 774
 775         * vax-tdep.c (vax_unwind_pc): Delete.
 776         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 777
 778 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 779
 780         * v850-tdep.c (v850_unwind_sp): Delete.
 781         (v850_unwind_pc): Delete.
 782         (v850_dummy_id): Delete.
 783         (v850_gdbarch_init): Don't register deleted functions with
 784         gdbarch.
 785
 786 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 787
 788         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 789         (tilegx_unwind_pc): Delete.
 790         (tilegx_unwind_dummy_id): Delete.
 791         (tilegx_gdbarch_init): Don't register deleted functions with
 792         gdbarch.
 793
 794 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 795
 796         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 797         (tic6x_dummy_id): Delete.
 798         (tic6x_gdbarch_init): Don't register deleted functions with
 799         gdbarch.
 800
 801 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 802
 803         * sparc-tdep.c (sparc_unwind_pc): Delete.
 804         (sparc32_gdbarch_init): Don't register deleted function with
 805         gdbarch.
 806
 807 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 808
 809         * sh-tdep.c (sh_unwind_sp): Delete.
 810         (sh_unwind_pc): Delete.
 811         (sh_dummy_id): Delete.
 812         (sh_gdbarch_init): Don't register deleted functions with
 813         gdbarch.
 814
 815 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 816
 817         * score-tdep.c (score_unwind_sp): Delete.
 818         (score_unwind_pc): Delete.
 819         (score_dummy_id): Delete.
 820         (score_gdbarch_init): Don't register deleted functions with
 821         gdbarch.
 822
 823 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 824
 825         * rx-tdep.c (rx_unwind_pc): Delete.
 826         (rx_unwind_sp): Delete.
 827         (rx_dummy_id): Delete.
 828         (rx_gdbarch_init): Don't register deleted functions with
 829         gdbarch.  Update comment.
 830
 831 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 832
 833         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 834         (rs6000_dummy_id): Delete.
 835         (rs6000_gdbarch_init): Don't register deleted functions with
 836         gdbarch.
 837
 838 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 839
 840         * or1k-tdep.c (or1k_dummy_id): Delete.
 841         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 842
 843 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 844
 845         * nios2-tdep.c (nios2_dummy_id): Delete.
 846         (nios2_unwind_sp): Delete.
 847         (nios2_gdbarch_init): Don't register deleted functions with
 848         gdbarch.
 849
 850 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 851
 852         * nds32-tdep.c (nds32_dummy_id): Delete.
 853         (nds32_unwind_pc): Delete.
 854         (nds32_unwind_sp): Delete.
 855         (nds32_gdbarch_init): Don't register deleted functions with
 856         gdbarch.
 857
 858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 859
 860         * msp430-tdep.c (msp430_unwind_pc): Delete.
 861         (msp430_unwind_sp): Delete.
 862         (msp430_dummy_id): Delete.
 863         (msp430_gdbarch_init): Don't register deleted functions with
 864         gdbarch.
 865
 866 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 867
 868         * moxie-tdep.c (moxie_unwind_sp): Delete.
 869         (moxie_unwind_pc): Delete.
 870         (moxie_dummy_id): Delete.
 871         (moxie_gdbarch_init): Don't register deleted functions with
 872         gdbarch.
 873
 874 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 875
 876         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 877         (mn10300_unwind_pc): Delete.
 878         (mn10300_unwind_sp): Delete.
 879         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 880         mn10300_unwind_sp.
 881         (mn10300_frame_unwind_init): Don't register deleted functions with
 882         gdbarch.
 883
 884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 885
 886         * mep-tdep.c (mep_unwind_pc): Delete.
 887         (mep_unwind_sp): Delete.
 888         (mep_dummy_id): Delete.
 889         (mep_gdbarch_init): Don't register deleted functions with
 890         gdbarch.
 891
 892 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 893
 894         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 895         (m68hc11_unwind_sp): Delete.
 896         (m68hc11_gdbarch_init): Don't register deleted functions with
 897         gdbarch.
 898
 899 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 900
 901         * m32r-tdep.c (m32r_unwind_sp): Delete.
 902         (m32r_unwind_pc): Delete.
 903         (m32r_dummy_id): Delete.
 904         (m32r_gdbarch_init): Don't register deleted functions with
 905         gdbarch.
 906
 907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 908
 909         * m32c-tdep.c (m32c_unwind_pc): Delete.
 910         (m32c_unwind_sp): Delete.
 911         (m32c_dummy_id): Delete.
 912         (m32c_gdbarch_init): Don't register deleted functions with
 913         gdbarch.
 914
 915 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 916
 917         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 918         (lm32_unwind_pc): Delete.
 919         (lm32_dummy_id): Delete.
 920         (lm32_gdbarch_init): Don't register deleted functions with
 921         gdbarch.
 922
 923 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 924
 925         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 926         (iq2000_unwind_pc): Delete.
 927         (iq2000_dummy_id): Delete.
 928         (iq2000_gdbarch_init): Don't register deleted functions with
 929         gdbarch.
 930
 931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 932
 933         * nds32-tdep.c (nds32_type_align): Delete.
 934         (nds32_push_dummy_call): Use type_align instead.
 935
 936 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 937
 938         * arm-tdep.c (arm_type_align): Only handle vector override case.
 939         (arm_push_dummy_call): Use type_align.
 940         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 941
 942 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 943
 944         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 945         case.
 946         (pass_on_stack): Use type_align.
 947         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 948         function.
 949
 950 2019-04-23  Tom Tromey  <tromey@adacore.com>
 951
 952         * dwarf2read.c (line_header::file_name_at): Remove unused
 953         overload.
 954
 955 2019-04-23  Tom de Vries  <tdevries@suse.de>
 956
 957         PR gdb/24438
 958         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 959         invocation.
 960
 961
 962 2019-03-27  Ali Tamur  <tamur@google.com>
 963
 964         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 965         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 966         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 967         (dwarf_expr_context::get_addr_index): Likewise
 968         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 969         (symbol_needs_eval_context::get_addr_index): Likewise
 970         (disassemble_dwarf_expression): Add DW_OP_addrx
 971         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 972         (read_cutu_die_from_dwo): Update comment
 973         (skip_one_die): Add DW_FORM_addrx
 974         (read_attribute_value): Likewise
 975         (var_decode_location): Add DW_OP_addrx
 976         (dwarf2_const_value_attr): Add DW_FORM_addrx
 977         (dump_die_shallow): Likewise
 978         (dwarf2_fetch_constant_bytes): Likewise
 979         (decode_locdesc): Add DW_OP_addrx
 980         (skip_form_bytes): Add DW_FORM_addrx
 981
 982 2019-04-22  Ali Tamur  <tamur@google.com>
 983
 984         * MAINTAINERS (Write After Approval): Add self.
 985
 986 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 987
 988         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 989         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 990         (open_symbol_file_object): Likewise.
 991         (svr4_default_sos): Add info parameter.
 992         (svr4_read_so_list): Likewise.
 993         (svr4_current_sos_direct): Adjust functions calls to pass down
 994         info.
 995         (svr4_current_sos_1): Add info parameter.
 996         (svr4_current_sos): Call get_svr4_info, pass info down to
 997         svr4_current_sos_1.
 998         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 999         get_svr4_info.
1000         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1001         get_svr4_info.
1002         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1003         to get_svr4_info.
1004         (probes_table_remove_objfile_probes): Likewise.
1005         (register_solib_event_probe): Add info parameter.
1006         (solist_update_incremental): Pass info parameter down to
1007         svr4_read_so_list.
1008         (disable_probes_interface): Add info parameter.
1009         (svr4_handle_solib_event): Pass current_program_space to
1010         get_svr4_info.  Adjust disable_probes_interface cleanup.
1011         (svr4_create_probe_breakpoints): Add info parameter, pass it
1012         down to register_solib_event_probe.
1013         (svr4_create_solib_event_breakpoints): Add info parameter,
1014         pass it down to svr4_create_probe_breakpoints.
1015         (enable_break): Pass info down to
1016         svr4_create_solib_event_breakpoints.
1017         (svr4_solib_create_inferior_hook): Pass current_program_space to
1018         get_svr4_info.
1019         (svr4_clear_solib): Likewise.
1020
1021 2019-04-22  Pedro Alves  <palves@redhat.com>
1022
1023         * solib-svr4.c (svr4_free_objfile_observer): New.
1024         (probe_and_action::objfile): New field.
1025         (probes_table_htab_remove_objfile_probes)
1026         (probes_table_remove_objfile_probes): New functions.
1027         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1028         in the new probe_and_action.  Don't store the probe in 'lookup'.
1029         (svr4_create_probe_breakpoints): Pass objfile to
1030         register_solib_event_probe.
1031         (_initialize_svr4_solib): Register a free_objfile observer.
1032
1033 2019-04-19  Tom Tromey  <tom@tromey.com>
1034
1035         * common/queue.h: Remove.
1036
1037 2019-04-19  Tom Tromey  <tom@tromey.com>
1038
1039         * event-loop.c: Don't include "common/queue.h".
1040
1041 2019-04-19  Tom Tromey  <tom@tromey.com>
1042
1043         * remote.c (remote_target): Use delete.
1044         * remote-notif.h: Include <list>, not "common/queue.h".
1045         (notif_client_p): Remove typedef.
1046         (remote_notif_state): Add constructor, destructor, initializer.
1047         <notif_queue>: Now a std::list.
1048         (remote_notif_state_xfree): Don't declare.
1049         * remote-notif.c (remote_notif_process, handle_notification)
1050         (remote_notif_state_allocate): Update.
1051         (~remote_notif_state): Rename from remote_notif_state_xfree.
1052
1053 2019-04-19  Tom Tromey  <tom@tromey.com>
1054
1055         * symfile.c (reread_symbols): Update.
1056         * objfiles.c (objfile_register_static_link)
1057         (objfile_lookup_static_link): Update
1058         (~objfile) Don't delete static_links.
1059         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1060
1061 2019-04-19  Tom Tromey  <tom@tromey.com>
1062
1063         * type-stack.h (struct type_stack) <insert>: Constify string.
1064         * type-stack.c (type_stack::insert): Constify string.
1065         * gdbtypes.h (lookup_template_type): Update.
1066         (address_space_name_to_int): Update.
1067         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1068         const.
1069         (lookup_template_type): Make name const.
1070         * c-exp.y: Update rules.
1071         (lex_one_token, classify_name, classify_inner_name)
1072         (c_print_token): Update.
1073         * p-exp.y: Update rules.
1074         (yylex): Update.
1075         * f-exp.y: Update rules.
1076         (yylex): Update.
1077         * d-exp.y: Update rules.
1078         (lex_one_token, classify_name, classify_inner_name): Update.
1079         * parse.c (write_dollar_variable, copy_name): Return std::string.
1080         * parser-defs.h (copy_name): Change return type.
1081         * m2-exp.y: Update rules.
1082         (yylex): Update.
1083         * go-exp.y (lex_one_token): Update.
1084         Update rules.
1085         (classify_unsafe_function, classify_packaged_name)
1086         (classify_name, yylex): Update.
1087
1088 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1089
1090         * configure.ac: add --enable-source-highlight switch.
1091         * configure: Regenerate.
1092         * top.c (print_gdb_version): plumb --enable-source-highlight
1093         status to "show configuration".
1094
1095 2019-04-19  Tom Tromey  <tromey@adacore.com>
1096
1097         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1098         Check ADA_TYPE_P.
1099         (empty_record, ada_template_to_fixed_record_type_1)
1100         (template_to_static_fixed_type)
1101         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1102         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1103         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1104         macros.
1105
1106 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1107
1108         PR symtab/24423:
1109         * source.c (print_source_lines_base): Advance "iter" when a
1110         control character is seen.
1111
1112 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1113
1114         * inferior.h (struct infcall_suspend_state_deleter):
1115         Catch exception in destructor to avoid crash.
1116
1117 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1118
1119         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1120         close to the add_com "shell".
1121
1122 2019-04-18  Tom Tromey  <tromey@adacore.com>
1123
1124         * process-stratum-target.h (class process_stratum_target)
1125         <stratum>: Add "final".
1126
1127 2019-04-17  Tom Tromey  <tromey@adacore.com>
1128
1129         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1130         against nullptr before use.
1131
1132 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1133
1134         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1135
1136 2019-04-17  Jim Wilson  <jimw@sifive.com>
1137             Andrew Burgess  <andrew.burgess@embecosm.com>
1138
1139         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1140         code read might fail, assume 4-byte breakpoint in that case.
1141
1142 2019-04-15  Leszek Swirski  <leszeks@google.com>
1143
1144         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1145         rather than a hand-rolled POD check when checking for forced MEMORY
1146         classification.
1147
1148 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1149
1150         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1151         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1152         function.
1153         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1154         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1155         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1156         declaration.
1157
1158 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1159
1160         * aarch64-linux-nat.c
1161         (aarch64_linux_nat_target::thread_architecture): Add override.
1162         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1163         each VQ.
1164
1165 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1166
1167         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1168
1169 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1170
1171         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1172         target types of size 96-bits, add some additional comments, and
1173         check that the builtin type we found was the correct size.
1174
1175 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1176
1177         * utils.c (prompt_for_continue): Don't restore the styling at the
1178         end, as applied_style has the wrong value.  This fixes styling in
1179         long lists of file names that are interrupted by the "Continue?"
1180         prompt.
1181
1182 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1183
1184         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1185         * c-lang.c (c_language_defn): Likewise.
1186         (cplus_language_defn): Likewise.
1187         (asm_language_defn): Likewise.
1188         (minimal_language_defn): Likewise.
1189         * d-lang.c (d_language_defn): Likewise.
1190         * f-lang.c (f_language_defn): Likewise.
1191         * go-lang.c (go_language_defn): Likewise.
1192         * language.c (unknown_language_defn): Likewise.
1193         (auto_language_defn): Likewise.
1194         * language.h (struct language_defn): Remove la_magic field.
1195         (LANG_MAGIC): Delete.
1196         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1197         * objc-lang.c (objc_language_defn): Likewise.
1198         * opencl-lang.c (opencl_language_defn): Likewise.
1199         * p-lang.c (pascal_language_defn): Likewise.
1200         * rust-lang.c (rust_language_defn): Likewise.
1201
1202 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1203
1204         * riscv-tdep.c (riscv_type_align): New function.
1205         (riscv_type_alignment): Delete.
1206         (riscv_arg_location): Use 'type_align'.
1207         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1208
1209 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1210
1211         * gdbtypes.c (type_align): A struct with no non-static fields also
1212         has alignment of 1.
1213
1214 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1215
1216         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1217         component to 0.
1218         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1219         member.
1220         (riscv_struct_info::analyse): New implementation using new
1221         analyse_inner member function.
1222         (riscv_struct_info::field_offset): New member function.
1223         (riscv_struct_info::m_offsets): New member variable.
1224         (riscv_struct_info::analyse_inner): New private member function,
1225         takes the old implementation of riscv_struct_info::analyse but
1226         extended to track field offsets.
1227         (riscv_call_arg_struct): Update the struct folding special cases
1228         to handle cases where empty C++ structs, which are non-zero
1229         length, are found.
1230         (riscv_arg_location): Initialise the length of each location, a
1231         non-zero length now indicates the location is in use.
1232         (riscv_push_dummy_call): Allow for the first location having a
1233         non-zero offset when setting up arguments.
1234         (riscv_return_value): Likewise, but for return values.
1235
1236 2019-04-11  Tom Tromey  <tromey@adacore.com>
1237
1238         * utils.c (internal_vproblem): Make "msg" const.
1239
1240 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1241
1242         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1243         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1244         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1245         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1246
1247 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1248
1249         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1250         function.
1251         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1252         of amd64_collect_native_gregset.
1253         (amd64_linux_nat_target::store_registers): Likewise.
1254
1255 2019-04-10  Tom Tromey  <tom@tromey.com>
1256
1257         * symtab.c (lookup_global_symbol_from_objfile)
1258         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1259         * objfiles.h (class separate_debug_iterator): New.
1260         (class separate_debug_range): New.
1261         (struct objfile) <separate_debug_objfiles>: New method.
1262         (objfile_separate_debug_iterate): Don't declare.
1263         * objfiles.c (separate_debug_iterator::operator++): Rename from
1264         objfile_separate_debug_iterate.
1265         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1266         iterator.
1267         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1268         iterator.
1269
1270 2019-04-10  Tom Tromey  <tom@tromey.com>
1271
1272         * symfile.c (reread_symbols): Remove old comment.
1273         * objfiles.c (free_all_objfiles): Fix a typo.
1274
1275 2019-04-10  Tom Tromey  <tom@tromey.com>
1276
1277         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1278         * minsyms.c (lookup_minimal_symbol): Use foreach.
1279         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1280         (lookup_minimal_symbol_solib_trampoline): Likewise.
1281         * symfile.c (reread_symbols): Use foreach.
1282
1283 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1284             Tom Tromey  <tromey@adacore.com>
1285
1286         PR rust/24414:
1287         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1288         (rust_lex_int_test): Change "value" to be LONGEST.
1289         (rust_lex_tests): Add test for long integer literal.
1290
1291 2019-04-09  Tom Tromey  <tromey@adacore.com>
1292
1293         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1294         to bool.
1295         (extended_remote_target::attach): Update.
1296         (remote_target::remote_notice_new_inferior): Update.
1297         (remote_target::add_current_inferior_and_thread): Update.
1298         * inferior.c (exit_inferior_1): Use "false".
1299         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1300
1301 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1302
1303         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1304         the "start" command.
1305
1306 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1307
1308         * python/py-inferior.c (infpy_thread_from_thread_handle):
1309         Adjust comments to reflect renaming of thread_from_thread_handle
1310         to thread_from_handle.  Adjust keywords.  Fix type error message.
1311         (inferior_object_methods): Add thread_from_handle.  Retain
1312         thread_from_thread_handle, but mark it as deprecated.
1313
1314 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1315
1316         * gdbthread.h (find_thread_by_handle): Revise declaration.
1317         * thread.c (find_thread_by_handle): Likewise.  Adjust
1318         implementation too.
1319         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1320         support for buffer objects as handles.
1321
1322 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1323
1324         * python/py-infthread.c (thpy_thread_handle): New function.
1325         (thread_object_methods): Register thpy_thread_handle.
1326
1327 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1328
1329         * gdbthread.h (thread_to_thread_handle): Declare.
1330         * thread.c (gdbtypes.h): Include.
1331         (thread_to_thread_handle): New function.
1332
1333         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1334         (target_thread_info_to_thread_handle): Declare.
1335         * target.c (target_thread_info_to_thread_handle): New function.
1336         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1337         * target-delegates.c: Regenerate.
1338
1339         * linux-thread-db.c (class thread_db_target): Add method
1340         thread_info_to_thread_handle.
1341         (thread_db_target::thread_info_to_thread_handle): Define.
1342         * remote.c (class remote_target): Add new method
1343         thread_info_to_thread_handle.
1344         (remote_target::thread_info_to_thread_handle): Define.
1345
1346 2019-04-08  Pedro Alves  <palves@redhat.com>
1347
1348         * common/common-exceptions.c (throw_exception): Don't create
1349         named object to throw; throw directly.
1350         (throw_it): Likewise.  Don't initialize gdb_exception::message
1351         here, with new; pass FMT and AP to the ctor instead.
1352         * common/common-exceptions.h: Include <string>.
1353         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1354         const char *, va_list)): New ctor.  Use std::make_shared.
1355         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1356         errors)): Delete.
1357         (gdb_exception_error::gdb_exception_error(enum errors, const char
1358         *, va_list)): New.
1359         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1360         Add assertion.
1361         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1362         errors)): Delete.
1363         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1364         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1365         Add assertion.
1366
1367 2019-04-08  Tom Tromey  <tom@tromey.com>
1368
1369         * valops.c (value_rtti_indirect_type): Replace throw_exception
1370         with throw.
1371         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1372         with throw.
1373         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1374         throw.
1375         * target.c (target_translate_tls_address): Replace throw_exception
1376         with throw.
1377         * stack.c (frame_apply_command_count): Replace throw_exception
1378         with throw.
1379         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1380         throw.
1381         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1382         with throw.
1383         * rs6000-tdep.c (rs6000_frame_cache)
1384         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1385         * remote.c: Replace throw_exception with throw.
1386         * record-full.c (record_full_message, record_full_wait_1)
1387         (record_full_restore): Replace throw_exception with throw.
1388         * record-btrace.c:
1389         (get_thread_current_frame_id, record_btrace_start_replaying)
1390         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1391         (cmd_record_btrace_start): Replace throw_exception with throw.
1392         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1393         throw.
1394         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1395         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1396         * linespec.c:
1397         (find_linespec_symbols): Replace throw_exception with throw.
1398         * infrun.c (displaced_step_prepare, resume): Replace
1399         throw_exception with throw.
1400         * infcmd.c (post_create_inferior): Replace throw_exception with
1401         throw.
1402         * inf-loop.c (inferior_event_handler): Replace throw_exception
1403         with throw.
1404         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1405         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1406         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1407         (get_prev_frame_always, get_frame_pc_if_available)
1408         (get_frame_address_in_block_if_available, get_frame_language):
1409         Replace throw_exception with throw.
1410         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1411         throw_exception with throw.
1412         * eval.c (fetch_subexp_value, evaluate_var_value)
1413         (evaluate_funcall, evaluate_subexp_standard): Replace
1414         throw_exception with throw.
1415         * dwarf2loc.c (call_site_find_chain)
1416         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1417         Replace throw_exception with throw.
1418         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1419         with throw.
1420         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1421         throw.
1422         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1423         * completer.c (complete_line_internal): Replace throw_exception
1424         with throw.
1425         * compile/compile-object-run.c (compile_object_run): Replace
1426         throw_exception with throw.
1427         * cli/cli-script.c (process_next_line): Replace throw_exception
1428         with throw.
1429         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1430         (btrace_enable, btrace_maint_update_pt_packets): Replace
1431         throw_exception with throw.
1432         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1433         throw_exception with throw.
1434         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1435         throw_exception with throw.
1436         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1437         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1438         * aarch64-tdep.c (aarch64_make_prologue_cache)
1439         (aarch64_make_stub_cache): Replace throw_exception with throw.
1440
1441 2019-04-08  Tom Tromey  <tom@tromey.com>
1442
1443         * common/common-exceptions.c (throw_exception): Rename from
1444         throw_exception_cxx.  Remove old copy.  Make argument const.
1445         (throw_it): Create and throw exception objects directly.
1446         * common/common-exceptions.h (throw_exception): Make argument
1447         const.
1448         (struct gdb_exception_error): Add constructor.
1449         (struct gdb_exception_quit): Add constructor.
1450
1451 2019-04-08  Tom Tromey  <tom@tromey.com>
1452
1453         * common/common-exceptions.h (exception_rethrow): Don't declare.
1454         (TRY_SJLJ): Update comment.
1455         (TRY, CATCH, END_CATCH): Remove.
1456         * common/common-exceptions.c (exception_rethrow): Remove.
1457
1458 2019-04-08  Tom Tromey  <tom@tromey.com>
1459
1460         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1461         Remove.
1462         (gdb_exception_error): Rename from
1463         gdb_exception_RETURN_MASK_ERROR.
1464         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1465         (gdb_quit_bad_alloc): Update.
1466         * aarch64-tdep.c: Update.
1467         * ada-lang.c: Update.
1468         * ada-typeprint.c: Update.
1469         * ada-valprint.c: Update.
1470         * amd64-tdep.c: Update.
1471         * arch-utils.c: Update.
1472         * break-catch-throw.c: Update.
1473         * breakpoint.c: Update.
1474         * btrace.c: Update.
1475         * c-varobj.c: Update.
1476         * cli/cli-cmds.c: Update.
1477         * cli/cli-interp.c: Update.
1478         * cli/cli-script.c: Update.
1479         * common/common-exceptions.c: Update.
1480         * common/new-op.c: Update.
1481         * common/selftest.c: Update.
1482         * compile/compile-c-symbols.c: Update.
1483         * compile/compile-cplus-symbols.c: Update.
1484         * compile/compile-object-load.c: Update.
1485         * compile/compile-object-run.c: Update.
1486         * completer.c: Update.
1487         * corelow.c: Update.
1488         * cp-abi.c: Update.
1489         * cp-support.c: Update.
1490         * cp-valprint.c: Update.
1491         * darwin-nat.c: Update.
1492         * disasm-selftests.c: Update.
1493         * dtrace-probe.c: Update.
1494         * dwarf-index-cache.c: Update.
1495         * dwarf-index-write.c: Update.
1496         * dwarf2-frame-tailcall.c: Update.
1497         * dwarf2-frame.c: Update.
1498         * dwarf2loc.c: Update.
1499         * dwarf2read.c: Update.
1500         * eval.c: Update.
1501         * event-loop.c: Update.
1502         * event-top.c: Update.
1503         * exec.c: Update.
1504         * f-valprint.c: Update.
1505         * fbsd-tdep.c: Update.
1506         * frame-unwind.c: Update.
1507         * frame.c: Update.
1508         * gdbtypes.c: Update.
1509         * gnu-v3-abi.c: Update.
1510         * guile/guile-internal.h: Update.
1511         * guile/scm-block.c: Update.
1512         * guile/scm-breakpoint.c: Update.
1513         * guile/scm-cmd.c: Update.
1514         * guile/scm-disasm.c: Update.
1515         * guile/scm-frame.c: Update.
1516         * guile/scm-lazy-string.c: Update.
1517         * guile/scm-math.c: Update.
1518         * guile/scm-param.c: Update.
1519         * guile/scm-ports.c: Update.
1520         * guile/scm-pretty-print.c: Update.
1521         * guile/scm-symbol.c: Update.
1522         * guile/scm-symtab.c: Update.
1523         * guile/scm-type.c: Update.
1524         * guile/scm-value.c: Update.
1525         * i386-linux-tdep.c: Update.
1526         * i386-tdep.c: Update.
1527         * inf-loop.c: Update.
1528         * infcall.c: Update.
1529         * infcmd.c: Update.
1530         * infrun.c: Update.
1531         * jit.c: Update.
1532         * language.c: Update.
1533         * linespec.c: Update.
1534         * linux-fork.c: Update.
1535         * linux-nat.c: Update.
1536         * linux-tdep.c: Update.
1537         * linux-thread-db.c: Update.
1538         * main.c: Update.
1539         * mi/mi-cmd-break.c: Update.
1540         * mi/mi-cmd-stack.c: Update.
1541         * mi/mi-interp.c: Update.
1542         * mi/mi-main.c: Update.
1543         * objc-lang.c: Update.
1544         * p-valprint.c: Update.
1545         * parse.c: Update.
1546         * ppc-linux-tdep.c: Update.
1547         * printcmd.c: Update.
1548         * python/py-arch.c: Update.
1549         * python/py-breakpoint.c: Update.
1550         * python/py-cmd.c: Update.
1551         * python/py-finishbreakpoint.c: Update.
1552         * python/py-frame.c: Update.
1553         * python/py-framefilter.c: Update.
1554         * python/py-gdb-readline.c: Update.
1555         * python/py-inferior.c: Update.
1556         * python/py-infthread.c: Update.
1557         * python/py-lazy-string.c: Update.
1558         * python/py-linetable.c: Update.
1559         * python/py-objfile.c: Update.
1560         * python/py-param.c: Update.
1561         * python/py-prettyprint.c: Update.
1562         * python/py-progspace.c: Update.
1563         * python/py-record-btrace.c: Update.
1564         * python/py-record.c: Update.
1565         * python/py-symbol.c: Update.
1566         * python/py-type.c: Update.
1567         * python/py-unwind.c: Update.
1568         * python/py-utils.c: Update.
1569         * python/py-value.c: Update.
1570         * python/python.c: Update.
1571         * record-btrace.c: Update.
1572         * record-full.c: Update.
1573         * remote-fileio.c: Update.
1574         * remote.c: Update.
1575         * riscv-tdep.c: Update.
1576         * rs6000-aix-tdep.c: Update.
1577         * rs6000-tdep.c: Update.
1578         * rust-exp.y: Update.
1579         * rust-lang.c: Update.
1580         * s390-tdep.c: Update.
1581         * selftest-arch.c: Update.
1582         * solib-dsbt.c: Update.
1583         * solib-frv.c: Update.
1584         * solib-spu.c: Update.
1585         * solib-svr4.c: Update.
1586         * solib.c: Update.
1587         * sparc64-linux-tdep.c: Update.
1588         * stack.c: Update.
1589         * symfile-mem.c: Update.
1590         * symmisc.c: Update.
1591         * target.c: Update.
1592         * thread.c: Update.
1593         * top.c: Update.
1594         * tracefile-tfile.c: Update.
1595         * tui/tui.c: Update.
1596         * typeprint.c: Update.
1597         * unittests/cli-utils-selftests.c: Update.
1598         * unittests/parse-connection-spec-selftests.c: Update.
1599         * valops.c: Update.
1600         * valprint.c: Update.
1601         * value.c: Update.
1602         * varobj.c: Update.
1603         * windows-nat.c: Update.
1604         * x86-linux-nat.c: Update.
1605         * xml-support.c: Update.
1606
1607 2019-04-08  Tom Tromey  <tom@tromey.com>
1608
1609         * xml-support.c: Use C++ exception handling.
1610         * x86-linux-nat.c: Use C++ exception handling.
1611         * windows-nat.c: Use C++ exception handling.
1612         * varobj.c: Use C++ exception handling.
1613         * value.c: Use C++ exception handling.
1614         * valprint.c: Use C++ exception handling.
1615         * valops.c: Use C++ exception handling.
1616         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1617         handling.
1618         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1619         * typeprint.c: Use C++ exception handling.
1620         * tui/tui.c: Use C++ exception handling.
1621         * tracefile-tfile.c: Use C++ exception handling.
1622         * top.c: Use C++ exception handling.
1623         * thread.c: Use C++ exception handling.
1624         * target.c: Use C++ exception handling.
1625         * symmisc.c: Use C++ exception handling.
1626         * symfile-mem.c: Use C++ exception handling.
1627         * stack.c: Use C++ exception handling.
1628         * sparc64-linux-tdep.c: Use C++ exception handling.
1629         * solib.c: Use C++ exception handling.
1630         * solib-svr4.c: Use C++ exception handling.
1631         * solib-spu.c: Use C++ exception handling.
1632         * solib-frv.c: Use C++ exception handling.
1633         * solib-dsbt.c: Use C++ exception handling.
1634         * selftest-arch.c: Use C++ exception handling.
1635         * s390-tdep.c: Use C++ exception handling.
1636         * rust-lang.c: Use C++ exception handling.
1637         * rust-exp.y: Use C++ exception handling.
1638         * rs6000-tdep.c: Use C++ exception handling.
1639         * rs6000-aix-tdep.c: Use C++ exception handling.
1640         * riscv-tdep.c: Use C++ exception handling.
1641         * remote.c: Use C++ exception handling.
1642         * remote-fileio.c: Use C++ exception handling.
1643         * record-full.c: Use C++ exception handling.
1644         * record-btrace.c: Use C++ exception handling.
1645         * python/python.c: Use C++ exception handling.
1646         * python/py-value.c: Use C++ exception handling.
1647         * python/py-utils.c: Use C++ exception handling.
1648         * python/py-unwind.c: Use C++ exception handling.
1649         * python/py-type.c: Use C++ exception handling.
1650         * python/py-symbol.c: Use C++ exception handling.
1651         * python/py-record.c: Use C++ exception handling.
1652         * python/py-record-btrace.c: Use C++ exception handling.
1653         * python/py-progspace.c: Use C++ exception handling.
1654         * python/py-prettyprint.c: Use C++ exception handling.
1655         * python/py-param.c: Use C++ exception handling.
1656         * python/py-objfile.c: Use C++ exception handling.
1657         * python/py-linetable.c: Use C++ exception handling.
1658         * python/py-lazy-string.c: Use C++ exception handling.
1659         * python/py-infthread.c: Use C++ exception handling.
1660         * python/py-inferior.c: Use C++ exception handling.
1661         * python/py-gdb-readline.c: Use C++ exception handling.
1662         * python/py-framefilter.c: Use C++ exception handling.
1663         * python/py-frame.c: Use C++ exception handling.
1664         * python/py-finishbreakpoint.c: Use C++ exception handling.
1665         * python/py-cmd.c: Use C++ exception handling.
1666         * python/py-breakpoint.c: Use C++ exception handling.
1667         * python/py-arch.c: Use C++ exception handling.
1668         * printcmd.c: Use C++ exception handling.
1669         * ppc-linux-tdep.c: Use C++ exception handling.
1670         * parse.c: Use C++ exception handling.
1671         * p-valprint.c: Use C++ exception handling.
1672         * objc-lang.c: Use C++ exception handling.
1673         * mi/mi-main.c: Use C++ exception handling.
1674         * mi/mi-interp.c: Use C++ exception handling.
1675         * mi/mi-cmd-stack.c: Use C++ exception handling.
1676         * mi/mi-cmd-break.c: Use C++ exception handling.
1677         * main.c: Use C++ exception handling.
1678         * linux-thread-db.c: Use C++ exception handling.
1679         * linux-tdep.c: Use C++ exception handling.
1680         * linux-nat.c: Use C++ exception handling.
1681         * linux-fork.c: Use C++ exception handling.
1682         * linespec.c: Use C++ exception handling.
1683         * language.c: Use C++ exception handling.
1684         * jit.c: Use C++ exception handling.
1685         * infrun.c: Use C++ exception handling.
1686         * infcmd.c: Use C++ exception handling.
1687         * infcall.c: Use C++ exception handling.
1688         * inf-loop.c: Use C++ exception handling.
1689         * i386-tdep.c: Use C++ exception handling.
1690         * i386-linux-tdep.c: Use C++ exception handling.
1691         * guile/scm-value.c: Use C++ exception handling.
1692         * guile/scm-type.c: Use C++ exception handling.
1693         * guile/scm-symtab.c: Use C++ exception handling.
1694         * guile/scm-symbol.c: Use C++ exception handling.
1695         * guile/scm-pretty-print.c: Use C++ exception handling.
1696         * guile/scm-ports.c: Use C++ exception handling.
1697         * guile/scm-param.c: Use C++ exception handling.
1698         * guile/scm-math.c: Use C++ exception handling.
1699         * guile/scm-lazy-string.c: Use C++ exception handling.
1700         * guile/scm-frame.c: Use C++ exception handling.
1701         * guile/scm-disasm.c: Use C++ exception handling.
1702         * guile/scm-cmd.c: Use C++ exception handling.
1703         * guile/scm-breakpoint.c: Use C++ exception handling.
1704         * guile/scm-block.c: Use C++ exception handling.
1705         * guile/guile-internal.h: Use C++ exception handling.
1706         * gnu-v3-abi.c: Use C++ exception handling.
1707         * gdbtypes.c: Use C++ exception handling.
1708         * frame.c: Use C++ exception handling.
1709         * frame-unwind.c: Use C++ exception handling.
1710         * fbsd-tdep.c: Use C++ exception handling.
1711         * f-valprint.c: Use C++ exception handling.
1712         * exec.c: Use C++ exception handling.
1713         * event-top.c: Use C++ exception handling.
1714         * event-loop.c: Use C++ exception handling.
1715         * eval.c: Use C++ exception handling.
1716         * dwarf2read.c: Use C++ exception handling.
1717         * dwarf2loc.c: Use C++ exception handling.
1718         * dwarf2-frame.c: Use C++ exception handling.
1719         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1720         * dwarf-index-write.c: Use C++ exception handling.
1721         * dwarf-index-cache.c: Use C++ exception handling.
1722         * dtrace-probe.c: Use C++ exception handling.
1723         * disasm-selftests.c: Use C++ exception handling.
1724         * darwin-nat.c: Use C++ exception handling.
1725         * cp-valprint.c: Use C++ exception handling.
1726         * cp-support.c: Use C++ exception handling.
1727         * cp-abi.c: Use C++ exception handling.
1728         * corelow.c: Use C++ exception handling.
1729         * completer.c: Use C++ exception handling.
1730         * compile/compile-object-run.c: Use C++ exception handling.
1731         * compile/compile-object-load.c: Use C++ exception handling.
1732         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1733         * compile/compile-c-symbols.c: Use C++ exception handling.
1734         * common/selftest.c: Use C++ exception handling.
1735         * common/new-op.c: Use C++ exception handling.
1736         * cli/cli-script.c: Use C++ exception handling.
1737         * cli/cli-interp.c: Use C++ exception handling.
1738         * cli/cli-cmds.c: Use C++ exception handling.
1739         * c-varobj.c: Use C++ exception handling.
1740         * btrace.c: Use C++ exception handling.
1741         * breakpoint.c: Use C++ exception handling.
1742         * break-catch-throw.c: Use C++ exception handling.
1743         * arch-utils.c: Use C++ exception handling.
1744         * amd64-tdep.c: Use C++ exception handling.
1745         * ada-valprint.c: Use C++ exception handling.
1746         * ada-typeprint.c: Use C++ exception handling.
1747         * ada-lang.c: Use C++ exception handling.
1748         * aarch64-tdep.c: Use C++ exception handling.
1749
1750 2019-04-08  Tom Tromey  <tom@tromey.com>
1751
1752         * xml-support.c (gdb_xml_parser::parse): Update.
1753         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1754         * value.c (show_convenience): Update.
1755         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1756         (test_parse_flags_qcs): Update.
1757         * thread.c (thr_try_catch_cmd): Update.
1758         * target.c (target_translate_tls_address): Update.
1759         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1760         (info_frame_command_core, frame_apply_command_count): Update.
1761         * rust-exp.y (rust_lex_exception_test): Update.
1762         * riscv-tdep.c (riscv_print_one_register_info): Update.
1763         * remote.c (remote_target::enable_btrace): Update.
1764         * record-btrace.c (record_btrace_enable_warn): Update.
1765         * python/py-utils.c (gdbpy_convert_exception): Update.
1766         * printcmd.c (do_one_display, print_variable_and_value): Update.
1767         * mi/mi-main.c (mi_print_exception): Update.
1768         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1769         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1770         * linux-nat.c (linux_nat_target::attach): Update.
1771         * linux-fork.c (class scoped_switch_fork_info): Update.
1772         * infrun.c (displaced_step_prepare): Update.
1773         * infcall.c (call_function_by_hand_dummy): Update.
1774         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1775         * gnu-v3-abi.c (print_one_vtable): Update.
1776         * frame.c (get_prev_frame_always): Update.
1777         * f-valprint.c (info_common_command_for_block): Update.
1778         * exec.c (try_open_exec_file): Update.
1779         * exceptions.c (print_exception, exception_print)
1780         (exception_fprintf, exception_print_same): Update.
1781         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1782         * dwarf-index-cache.c (index_cache::store)
1783         (index_cache::lookup_gdb_index): Update.
1784         * darwin-nat.c (maybe_cache_shell): Update.
1785         * cp-valprint.c (cp_print_value_fields): Update.
1786         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1787         (gcc_cplus_symbol_address): Update.
1788         * compile/compile-c-symbols.c (gcc_convert_symbol)
1789         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1790         * common/selftest.c: Update.
1791         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1792         a std::string.
1793         (exception_try_scope_entry, exception_try_scope_exit): Don't
1794         declare.
1795         (struct exception_try_scope): Remove.
1796         (TRY): Don't use exception_try_scope.
1797         (struct gdb_exception): Add constructor, operator=.
1798         <what>: New method.
1799         (struct gdb_exception_RETURN_MASK_ALL)
1800         (struct gdb_exception_RETURN_MASK_ERROR)
1801         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1802         (struct gdb_quit_bad_alloc): Update.
1803         * common/common-exceptions.c (exception_none): Change
1804         initializer.
1805         (struct catcher) <state, exception>: Initialize inline.
1806         <prev>: Remove member.
1807         (current_catcher): Remove.
1808         (catchers): New global.
1809         (exceptions_state_mc_init): Simplify.
1810         (catcher_pop): Remove.
1811         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1812         (try_scope_depth, exception_try_scope_entry)
1813         (exception_try_scope_exit): Remove.
1814         (throw_exception_sjlj): Update.
1815         (exception_messages, exception_messages_size): Remove.
1816         (throw_it): Simplify.
1817         (gdb_exception_sliced_copy): Remove.
1818         (throw_exception_cxx): Update.
1819         * cli/cli-script.c (script_from_file): Update.
1820         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1821         Update.
1822         * ada-valprint.c (ada_val_print): Update.
1823         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1824         (create_excep_cond_exprs): Update.
1825
1826 2019-04-08  Tom Tromey  <tom@tromey.com>
1827
1828         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1829         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1830         (TRY, CATCH, END_CATCH): Remove some definitions.
1831         * common/common-exceptions.c: Don't use GDB_XCPT.
1832         (catcher_list_size): Remove.
1833         (throw_exception, throw_it): Simplify.
1834
1835 2019-04-05  Tom Tromey  <tom@tromey.com>
1836
1837         Revert the header-sorting patch.
1838         * ft32-tdep.c: Revert.
1839         * frv-tdep.c: Revert.
1840         * frv-linux-tdep.c: Revert.
1841         * frame.c: Revert.
1842         * frame-unwind.c: Revert.
1843         * frame-base.c: Revert.
1844         * fork-child.c: Revert.
1845         * findvar.c: Revert.
1846         * findcmd.c: Revert.
1847         * filesystem.c: Revert.
1848         * filename-seen-cache.h: Revert.
1849         * filename-seen-cache.c: Revert.
1850         * fbsd-tdep.c: Revert.
1851         * fbsd-nat.h: Revert.
1852         * fbsd-nat.c: Revert.
1853         * f-valprint.c: Revert.
1854         * f-typeprint.c: Revert.
1855         * f-lang.c: Revert.
1856         * extension.h: Revert.
1857         * extension.c: Revert.
1858         * extension-priv.h: Revert.
1859         * expprint.c: Revert.
1860         * exec.h: Revert.
1861         * exec.c: Revert.
1862         * exceptions.c: Revert.
1863         * event-top.c: Revert.
1864         * event-loop.c: Revert.
1865         * eval.c: Revert.
1866         * elfread.c: Revert.
1867         * dwarf2read.h: Revert.
1868         * dwarf2read.c: Revert.
1869         * dwarf2loc.c: Revert.
1870         * dwarf2expr.h: Revert.
1871         * dwarf2expr.c: Revert.
1872         * dwarf2-frame.c: Revert.
1873         * dwarf2-frame-tailcall.c: Revert.
1874         * dwarf-index-write.h: Revert.
1875         * dwarf-index-write.c: Revert.
1876         * dwarf-index-common.c: Revert.
1877         * dwarf-index-cache.h: Revert.
1878         * dwarf-index-cache.c: Revert.
1879         * dummy-frame.c: Revert.
1880         * dtrace-probe.c: Revert.
1881         * disasm.h: Revert.
1882         * disasm.c: Revert.
1883         * disasm-selftests.c: Revert.
1884         * dictionary.c: Revert.
1885         * dicos-tdep.c: Revert.
1886         * demangle.c: Revert.
1887         * dcache.h: Revert.
1888         * dcache.c: Revert.
1889         * darwin-nat.h: Revert.
1890         * darwin-nat.c: Revert.
1891         * darwin-nat-info.c: Revert.
1892         * d-valprint.c: Revert.
1893         * d-namespace.c: Revert.
1894         * d-lang.c: Revert.
1895         * ctf.c: Revert.
1896         * csky-tdep.c: Revert.
1897         * csky-linux-tdep.c: Revert.
1898         * cris-tdep.c: Revert.
1899         * cris-linux-tdep.c: Revert.
1900         * cp-valprint.c: Revert.
1901         * cp-support.c: Revert.
1902         * cp-namespace.c: Revert.
1903         * cp-abi.c: Revert.
1904         * corelow.c: Revert.
1905         * corefile.c: Revert.
1906         * continuations.c: Revert.
1907         * completer.h: Revert.
1908         * completer.c: Revert.
1909         * complaints.c: Revert.
1910         * coffread.c: Revert.
1911         * coff-pe-read.c: Revert.
1912         * cli-out.h: Revert.
1913         * cli-out.c: Revert.
1914         * charset.c: Revert.
1915         * c-varobj.c: Revert.
1916         * c-valprint.c: Revert.
1917         * c-typeprint.c: Revert.
1918         * c-lang.c: Revert.
1919         * buildsym.c: Revert.
1920         * buildsym-legacy.c: Revert.
1921         * build-id.h: Revert.
1922         * build-id.c: Revert.
1923         * btrace.c: Revert.
1924         * bsd-uthread.c: Revert.
1925         * breakpoint.h: Revert.
1926         * breakpoint.c: Revert.
1927         * break-catch-throw.c: Revert.
1928         * break-catch-syscall.c: Revert.
1929         * break-catch-sig.c: Revert.
1930         * blockframe.c: Revert.
1931         * block.c: Revert.
1932         * bfin-tdep.c: Revert.
1933         * bfin-linux-tdep.c: Revert.
1934         * bfd-target.c: Revert.
1935         * bcache.c: Revert.
1936         * ax-general.c: Revert.
1937         * ax-gdb.h: Revert.
1938         * ax-gdb.c: Revert.
1939         * avr-tdep.c: Revert.
1940         * auxv.c: Revert.
1941         * auto-load.c: Revert.
1942         * arm-wince-tdep.c: Revert.
1943         * arm-tdep.c: Revert.
1944         * arm-symbian-tdep.c: Revert.
1945         * arm-pikeos-tdep.c: Revert.
1946         * arm-obsd-tdep.c: Revert.
1947         * arm-nbsd-tdep.c: Revert.
1948         * arm-nbsd-nat.c: Revert.
1949         * arm-linux-tdep.c: Revert.
1950         * arm-linux-nat.c: Revert.
1951         * arm-fbsd-tdep.c: Revert.
1952         * arm-fbsd-nat.c: Revert.
1953         * arm-bsd-tdep.c: Revert.
1954         * arch-utils.c: Revert.
1955         * arc-tdep.c: Revert.
1956         * arc-newlib-tdep.c: Revert.
1957         * annotate.h: Revert.
1958         * annotate.c: Revert.
1959         * amd64-windows-tdep.c: Revert.
1960         * amd64-windows-nat.c: Revert.
1961         * amd64-tdep.c: Revert.
1962         * amd64-sol2-tdep.c: Revert.
1963         * amd64-obsd-tdep.c: Revert.
1964         * amd64-obsd-nat.c: Revert.
1965         * amd64-nbsd-tdep.c: Revert.
1966         * amd64-nbsd-nat.c: Revert.
1967         * amd64-nat.c: Revert.
1968         * amd64-linux-tdep.c: Revert.
1969         * amd64-linux-nat.c: Revert.
1970         * amd64-fbsd-tdep.c: Revert.
1971         * amd64-fbsd-nat.c: Revert.
1972         * amd64-dicos-tdep.c: Revert.
1973         * amd64-darwin-tdep.c: Revert.
1974         * amd64-bsd-nat.c: Revert.
1975         * alpha-tdep.c: Revert.
1976         * alpha-obsd-tdep.c: Revert.
1977         * alpha-nbsd-tdep.c: Revert.
1978         * alpha-mdebug-tdep.c: Revert.
1979         * alpha-linux-tdep.c: Revert.
1980         * alpha-linux-nat.c: Revert.
1981         * alpha-bsd-tdep.c: Revert.
1982         * alpha-bsd-nat.c: Revert.
1983         * aix-thread.c: Revert.
1984         * agent.c: Revert.
1985         * addrmap.c: Revert.
1986         * ada-varobj.c: Revert.
1987         * ada-valprint.c: Revert.
1988         * ada-typeprint.c: Revert.
1989         * ada-tasks.c: Revert.
1990         * ada-lang.c: Revert.
1991         * aarch64-tdep.c: Revert.
1992         * aarch64-ravenscar-thread.c: Revert.
1993         * aarch64-newlib-tdep.c: Revert.
1994         * aarch64-linux-tdep.c: Revert.
1995         * aarch64-linux-nat.c: Revert.
1996         * aarch64-fbsd-tdep.c: Revert.
1997         * aarch64-fbsd-nat.c: Revert.
1998         * aarch32-linux-nat.c: Revert.
1999
2000 2019-04-05  Tom Tromey  <tom@tromey.com>
2001
2002         * ft32-tdep.c: Sort headers.
2003         * frv-tdep.c: Sort headers.
2004         * frv-linux-tdep.c: Sort headers.
2005         * frame.c: Sort headers.
2006         * frame-unwind.c: Sort headers.
2007         * frame-base.c: Sort headers.
2008         * fork-child.c: Sort headers.
2009         * findvar.c: Sort headers.
2010         * findcmd.c: Sort headers.
2011         * filesystem.c: Sort headers.
2012         * filename-seen-cache.h: Sort headers.
2013         * filename-seen-cache.c: Sort headers.
2014         * fbsd-tdep.c: Sort headers.
2015         * fbsd-nat.h: Sort headers.
2016         * fbsd-nat.c: Sort headers.
2017         * f-valprint.c: Sort headers.
2018         * f-typeprint.c: Sort headers.
2019         * f-lang.c: Sort headers.
2020         * extension.h: Sort headers.
2021         * extension.c: Sort headers.
2022         * extension-priv.h: Sort headers.
2023         * expprint.c: Sort headers.
2024         * exec.h: Sort headers.
2025         * exec.c: Sort headers.
2026         * exceptions.c: Sort headers.
2027         * event-top.c: Sort headers.
2028         * event-loop.c: Sort headers.
2029         * eval.c: Sort headers.
2030         * elfread.c: Sort headers.
2031         * dwarf2read.h: Sort headers.
2032         * dwarf2read.c: Sort headers.
2033         * dwarf2loc.c: Sort headers.
2034         * dwarf2expr.h: Sort headers.
2035         * dwarf2expr.c: Sort headers.
2036         * dwarf2-frame.c: Sort headers.
2037         * dwarf2-frame-tailcall.c: Sort headers.
2038         * dwarf-index-write.h: Sort headers.
2039         * dwarf-index-write.c: Sort headers.
2040         * dwarf-index-common.c: Sort headers.
2041         * dwarf-index-cache.h: Sort headers.
2042         * dwarf-index-cache.c: Sort headers.
2043         * dummy-frame.c: Sort headers.
2044         * dtrace-probe.c: Sort headers.
2045         * disasm.h: Sort headers.
2046         * disasm.c: Sort headers.
2047         * disasm-selftests.c: Sort headers.
2048         * dictionary.c: Sort headers.
2049         * dicos-tdep.c: Sort headers.
2050         * demangle.c: Sort headers.
2051         * dcache.h: Sort headers.
2052         * dcache.c: Sort headers.
2053         * darwin-nat.h: Sort headers.
2054         * darwin-nat.c: Sort headers.
2055         * darwin-nat-info.c: Sort headers.
2056         * d-valprint.c: Sort headers.
2057         * d-namespace.c: Sort headers.
2058         * d-lang.c: Sort headers.
2059         * ctf.c: Sort headers.
2060         * csky-tdep.c: Sort headers.
2061         * csky-linux-tdep.c: Sort headers.
2062         * cris-tdep.c: Sort headers.
2063         * cris-linux-tdep.c: Sort headers.
2064         * cp-valprint.c: Sort headers.
2065         * cp-support.c: Sort headers.
2066         * cp-namespace.c: Sort headers.
2067         * cp-abi.c: Sort headers.
2068         * corelow.c: Sort headers.
2069         * corefile.c: Sort headers.
2070         * continuations.c: Sort headers.
2071         * completer.h: Sort headers.
2072         * completer.c: Sort headers.
2073         * complaints.c: Sort headers.
2074         * coffread.c: Sort headers.
2075         * coff-pe-read.c: Sort headers.
2076         * cli-out.h: Sort headers.
2077         * cli-out.c: Sort headers.
2078         * charset.c: Sort headers.
2079         * c-varobj.c: Sort headers.
2080         * c-valprint.c: Sort headers.
2081         * c-typeprint.c: Sort headers.
2082         * c-lang.c: Sort headers.
2083         * buildsym.c: Sort headers.
2084         * buildsym-legacy.c: Sort headers.
2085         * build-id.h: Sort headers.
2086         * build-id.c: Sort headers.
2087         * btrace.c: Sort headers.
2088         * bsd-uthread.c: Sort headers.
2089         * breakpoint.h: Sort headers.
2090         * breakpoint.c: Sort headers.
2091         * break-catch-throw.c: Sort headers.
2092         * break-catch-syscall.c: Sort headers.
2093         * break-catch-sig.c: Sort headers.
2094         * blockframe.c: Sort headers.
2095         * block.c: Sort headers.
2096         * bfin-tdep.c: Sort headers.
2097         * bfin-linux-tdep.c: Sort headers.
2098         * bfd-target.c: Sort headers.
2099         * bcache.c: Sort headers.
2100         * ax-general.c: Sort headers.
2101         * ax-gdb.h: Sort headers.
2102         * ax-gdb.c: Sort headers.
2103         * avr-tdep.c: Sort headers.
2104         * auxv.c: Sort headers.
2105         * auto-load.c: Sort headers.
2106         * arm-wince-tdep.c: Sort headers.
2107         * arm-tdep.c: Sort headers.
2108         * arm-symbian-tdep.c: Sort headers.
2109         * arm-pikeos-tdep.c: Sort headers.
2110         * arm-obsd-tdep.c: Sort headers.
2111         * arm-nbsd-tdep.c: Sort headers.
2112         * arm-nbsd-nat.c: Sort headers.
2113         * arm-linux-tdep.c: Sort headers.
2114         * arm-linux-nat.c: Sort headers.
2115         * arm-fbsd-tdep.c: Sort headers.
2116         * arm-fbsd-nat.c: Sort headers.
2117         * arm-bsd-tdep.c: Sort headers.
2118         * arch-utils.c: Sort headers.
2119         * arc-tdep.c: Sort headers.
2120         * arc-newlib-tdep.c: Sort headers.
2121         * annotate.h: Sort headers.
2122         * annotate.c: Sort headers.
2123         * amd64-windows-tdep.c: Sort headers.
2124         * amd64-windows-nat.c: Sort headers.
2125         * amd64-tdep.c: Sort headers.
2126         * amd64-sol2-tdep.c: Sort headers.
2127         * amd64-obsd-tdep.c: Sort headers.
2128         * amd64-obsd-nat.c: Sort headers.
2129         * amd64-nbsd-tdep.c: Sort headers.
2130         * amd64-nbsd-nat.c: Sort headers.
2131         * amd64-nat.c: Sort headers.
2132         * amd64-linux-tdep.c: Sort headers.
2133         * amd64-linux-nat.c: Sort headers.
2134         * amd64-fbsd-tdep.c: Sort headers.
2135         * amd64-fbsd-nat.c: Sort headers.
2136         * amd64-dicos-tdep.c: Sort headers.
2137         * amd64-darwin-tdep.c: Sort headers.
2138         * amd64-bsd-nat.c: Sort headers.
2139         * alpha-tdep.c: Sort headers.
2140         * alpha-obsd-tdep.c: Sort headers.
2141         * alpha-nbsd-tdep.c: Sort headers.
2142         * alpha-mdebug-tdep.c: Sort headers.
2143         * alpha-linux-tdep.c: Sort headers.
2144         * alpha-linux-nat.c: Sort headers.
2145         * alpha-bsd-tdep.c: Sort headers.
2146         * alpha-bsd-nat.c: Sort headers.
2147         * aix-thread.c: Sort headers.
2148         * agent.c: Sort headers.
2149         * addrmap.c: Sort headers.
2150         * ada-varobj.c: Sort headers.
2151         * ada-valprint.c: Sort headers.
2152         * ada-typeprint.c: Sort headers.
2153         * ada-tasks.c: Sort headers.
2154         * ada-lang.c: Sort headers.
2155         * aarch64-tdep.c: Sort headers.
2156         * aarch64-ravenscar-thread.c: Sort headers.
2157         * aarch64-newlib-tdep.c: Sort headers.
2158         * aarch64-linux-tdep.c: Sort headers.
2159         * aarch64-linux-nat.c: Sort headers.
2160         * aarch64-fbsd-tdep.c: Sort headers.
2161         * aarch64-fbsd-nat.c: Sort headers.
2162         * aarch32-linux-nat.c: Sort headers.
2163
2164 2019-04-04  Tom Tromey  <tom@tromey.com>
2165
2166         * varobj.c (varobj_create): Update.
2167         * rust-exp.y (struct rust_parser) <update_innermost_block,
2168         lookup_symbol>: New methods.
2169         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2170         Rename.
2171         (rust_parser::rust_lookup_type)
2172         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2173         * printcmd.c (display_command, do_one_display): Update.
2174         * parser-defs.h (struct parser_state) <parser_state>: Add
2175         "tracker" parameter.
2176         (block_tracker): New member.
2177         (class innermost_block_tracker) <innermost_block_tracker>: Add
2178         "types" parameter.
2179         <reset>: Remove method.
2180         (innermost_block): Don't declare.
2181         (null_post_parser): Update.
2182         * parse.c (innermost_block): Remove global.
2183         (write_dollar_variable): Update.
2184         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2185         Remove "tracker_types" parameter.
2186         (parse_expression): Add "tracker" parameter.
2187         (parse_expression_for_completion): Update.
2188         (null_post_parser): Add "tracker" parameter.
2189         * p-exp.y: Update rules.
2190         * m2-exp.y: Update rules.
2191         * language.h (struct language_defn) <la_post_parser>: Add
2192         "tracker" parameter.
2193         * go-exp.y: Update rules.
2194         * f-exp.y: Update rules.
2195         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2196         parameter.
2197         * d-exp.y: Update rules.
2198         * c-exp.y: Update rules.
2199         * breakpoint.c (set_breakpoint_condition): Create an
2200         innermost_block_tracker.
2201         (watch_command_1): Likewise.
2202         * ada-lang.c (resolve): Add "tracker" parameter.
2203         (resolve_subexp): Likewise.
2204         * ada-exp.y (write_var_from_sym): Update.
2205
2206 2019-04-04  Tom Tromey  <tom@tromey.com>
2207
2208         * type-stack.h: New file.
2209         * type-stack.c: New file.
2210         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2211         type-stack.h.
2212         (insert_into_type_stack, insert_type, push_type, push_type_int)
2213         (insert_type_address_space, pop_type, pop_type_int)
2214         (pop_typelist, pop_type_stack, append_type_stack)
2215         (push_type_stack, get_type_stack, push_typelist)
2216         (follow_type_instance_flags, follow_types): Don't declare.
2217         * parse.c (type_stack): Remove global.
2218         (parse_exp_in_context): Update.
2219         (insert_into_type_stack, insert_type, push_type, push_type_int)
2220         (insert_type_address_space, pop_type, pop_type_int)
2221         (pop_typelist, pop_type_stack, append_type_stack)
2222         (push_type_stack, get_type_stack, push_typelist)
2223         (follow_type_instance_flags, follow_types): Remove (moved to
2224         type-stack.c).
2225         * f-exp.y (type_stack): New global.
2226         Update rules.
2227         (push_kind_type, f_parse): Update.
2228         * d-exp.y (type_stack): New global.
2229         Update rules.
2230         (d_parse): Update.
2231         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2232         Update rules.
2233         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2234         (HFILES_NO_SRCDIR): Add type-stack.h.
2235
2236 2019-04-04  Tom Tromey  <tom@tromey.com>
2237
2238         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2239         (rust_parser::convert_ast_to_expression, rust_parse)
2240         (rust_lex_test_completion, rust_lex_tests): Update.
2241         * parser-defs.h (struct expr_completion_state): New.
2242         (struct parser_state) <parser_state>: Add completion parameter.
2243         <mark_struct_expression, mark_completion_tag>: New methods.
2244         <parse_completion, m_completion_state>: New members.
2245         (prefixify_expression, null_post_parser): Update.
2246         (mark_struct_expression, mark_completion_tag): Don't declare.
2247         * parse.c (parse_completion, expout_last_struct)
2248         (expout_tag_completion_type, expout_completion_name): Remove
2249         globals.
2250         (parser_state::mark_struct_expression)
2251         (parser_state::mark_completion_tag): Now methods.
2252         (prefixify_expression): Add last_struct parameter.
2253         (prefixify_subexp): Likewise.
2254         (parse_exp_1): Update.
2255         (parse_exp_in_context): Add cstate parameter.  Update.
2256         (parse_expression_for_completion): Create an
2257         expr_completion_state.
2258         (null_post_parser): Add "completion" parameter.
2259         * p-exp.y: Update rules.
2260         (yylex): Update.
2261         * language.h (struct language_defn) <la_post_parser>: Add
2262         "completing" parameter.
2263         * go-exp.y: Update rules.
2264         (lex_one_token): Update.
2265         * expression.h (parse_completion): Don't declare.
2266         * d-exp.y: Update rules.
2267         (lex_one_token): Update rules.
2268         * c-exp.y: Update rules.
2269         (lex_one_token): Update.
2270         * ada-lang.c (resolve): Add "parse_completion" parameter.
2271         (resolve_subexp): Likewise.
2272         (ada_resolve_function): Likewise.
2273
2274 2019-04-04  Tom Tromey  <tom@tromey.com>
2275
2276         * parser-defs.h (struct parser_state) <start_arglist,
2277         end_arglist>: New methods.
2278         <arglist_len, m_funcall_chain>: New members.
2279         (arglist_len, start_arglist, end_arglist): Don't declare.
2280         * parse.c (arglist_len, funcall_chain): Remove global.
2281         (start_arglist, end_arglist): Remove functions.
2282         (parse_exp_in_context): Update.
2283         * p-exp.y: Update rules.
2284         * m2-exp.y: Update rules.
2285         * go-exp.y: Update rules.
2286         * f-exp.y: Update rules.
2287         * d-exp.y: Update rules.
2288         * c-exp.y: Update rules.
2289
2290 2019-04-04  Tom Tromey  <tom@tromey.com>
2291
2292         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2293         lex_operator, push_back>: New methods.
2294         Update all rules.
2295         (rust_parser::lex_hex, lex_escape): Rename and update.
2296         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2297         (rust_parser::lex_operator): Rename and update.
2298         (rust_parser::lex_number, rustyylex, rustyyerror)
2299         (rust_lex_test_init, rust_lex_test_sequence)
2300         (rust_lex_test_push_back, rust_lex_tests): Update.
2301         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2302         parameter.
2303         <lexptr, prev_lexptr>: New members.
2304         (lexptr, prev_lexptr): Don't declare.
2305         * parse.c (lexptr, prev_lexptr): Remove globals.
2306         (parse_exp_in_context): Update.
2307         * p-exp.y (yylex, yyerror): Update.
2308         * m2-exp.y (parse_number, yylex, yyerror): Update.
2309         * go-exp.y (lex_one_token, yyerror): Update.
2310         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2311         * d-exp.y (lex_one_token, yyerror): Update.
2312         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2313         (lex_one_token, yyerror): Update.
2314         * ada-lex.l (YY_INPUT): Update.
2315         (rewind_to_char): Update.
2316         * ada-exp.y (yyerror): Update.
2317
2318 2019-04-04  Tom Tromey  <tom@tromey.com>
2319
2320         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2321         * parser-defs.h (struct parser_state) <parser_state>: Add new
2322         parameter.
2323         <comma_terminates>: New member.
2324         (comma_terminates): Don't declare global.
2325         * parse.c (comma_terminates): Remove global.
2326         (parse_exp_in_context): Update.
2327         * p-exp.y (yylex): Update.
2328         * m2-exp.y (yylex): Update.
2329         * go-exp.y (lex_one_token): Update.
2330         * f-exp.y (yylex): Update.
2331         * d-exp.y (lex_one_token): Update.
2332         * c-exp.y (lex_one_token): Update.
2333         * ada-lex.l: Update.
2334
2335 2019-04-04  Tom Tromey  <tom@tromey.com>
2336
2337         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2338         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2339         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2340         * parser-defs.h (paren_depth): Don't declare.
2341         * parse.c (paren_depth): Remove global.
2342         (parse_exp_in_context): Update.
2343         * p-exp.y (paren_depth): New global.
2344         (pascal_parse): Initialize it.
2345         * m2-exp.y (paren_depth): New global.
2346         (m2_parse): Initialize it.
2347         * go-exp.y (paren_depth): New global.
2348         (go_parse): Initialize it.
2349         * f-exp.y (paren_depth): New global.
2350         (f_parse): Initialize it.
2351         * d-exp.y (paren_depth): New global.
2352         (d_parse): Initialize it.
2353         * c-exp.y (paren_depth): New global.
2354         (c_parse): Initialize it.
2355         * ada-lex.l (paren_depth): New global.
2356         (lexer_init): Initialize it.
2357
2358 2019-04-04  Tom Tromey  <tom@tromey.com>
2359
2360         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2361         (rust_parser::convert_ast_to_type)
2362         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2363         * parser-defs.h (struct parser_state) <parser_state>: Add
2364         parameters.  Initialize new members.
2365         <expression_context_block, expression_context_pc>: New members.
2366         * parse.c (expression_context_block, expression_context_pc):
2367         Remove globals.
2368         (parse_exp_in_context): Update.
2369         * p-exp.y: Update all rules.
2370         (yylex): Update.
2371         * m2-exp.y: Update all rules.
2372         (yylex): Update.
2373         * go-exp.y (yylex): Update.
2374         * f-exp.y (yylex): Update.
2375         * d-exp.y: Update all rules.
2376         (yylex): Update.
2377         * c-exp.y: Update all rules.
2378         (lex_one_token, classify_name, yylex, c_parse): Update.
2379         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2380
2381 2019-04-04  Tom Tromey  <tom@tromey.com>
2382
2383         * gdbarch.h, gdbarch.c: Rebuild.
2384         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2385         * stap-probe.h:
2386         (struct stap_parse_info): Replace "parser_state" with
2387         "expr_builder".
2388         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2389         (parser_state): New class.
2390         * parse.c (expr_builder): Rename.
2391         (expr_builder::release): Rename.
2392         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2393         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2394         (write_exp_elt_longcst, write_exp_elt_floatcst)
2395         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2396         (write_exp_string_vector, write_exp_bitstring)
2397         (write_exp_msymbol, mark_struct_expression)
2398         (write_dollar_variable)
2399         (insert_type_address_space, increase_expout_size): Replace
2400         "parser_state" with "expr_builder".
2401         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2402         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2403         "parser_state" with "expr_builder".
2404
2405 2019-04-04  Tom Tromey  <tom@tromey.com>
2406
2407         * rust-exp.y: Replace "parse_language" with method call.
2408         * p-exp.y:
2409         (yylex): Replace "parse_language" with method call.
2410         * m2-exp.y:
2411         (yylex): Replace "parse_language" with method call.
2412         * go-exp.y (classify_name): Replace "parse_language" with method
2413         call.
2414         * f-exp.y (yylex): Replace "parse_language" with method call.
2415         * d-exp.y (lex_one_token): Replace "parse_language" with method
2416         call.
2417         * c-exp.y:
2418         (lex_one_token, classify_name, yylex): Replace "parse_language"
2419         with method call.
2420         * ada-exp.y (find_primitive_type, type_char)
2421         (type_system_address): Replace "parse_language" with method call.
2422
2423 2019-04-04  Tom Tromey  <tom@tromey.com>
2424
2425         * rust-exp.y: Replace "parse_gdbarch" with method call.
2426         * parse.c (write_dollar_variable, insert_type_address_space):
2427         Replace "parse_gdbarch" with method call.
2428         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2429         call.
2430         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2431         call.
2432         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2433         "parse_gdbarch" with method call.
2434         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2435         with method call.
2436         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2437         "parse_gdbarch" with method call.
2438         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2439         "parse_gdbarch" with method call.
2440         * c-exp.y (parse_type, parse_number, classify_name): Replace
2441         "parse_gdbarch" with method call.
2442         * ada-lex.l: Replace "parse_gdbarch" with method call.
2443         * ada-exp.y (parse_type, find_primitive_type, type_char)
2444         (type_system_address): Replace "parse_gdbarch" with method call.
2445
2446 2019-04-04  Tom Tromey  <tom@tromey.com>
2447
2448         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2449         * stap-probe.c (stap_parse_argument): Update.
2450         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2451         initial_size parameter.
2452         * rust-exp.y (rust_lex_tests): Update.
2453         * parse.c (parser_state): Update.
2454         (parse_exp_in_context): Update.
2455         * parser-defs.h (struct parser_state) <parser_state>: Remove
2456         "initial_size" parameter.
2457
2458 2019-04-04  Tom Tromey  <tom@tromey.com>
2459
2460         * parser-defs.h (increase_expout_size): Don't declare.
2461         * parse.c (increase_expout_size): Now static.
2462
2463 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2464
2465         * gnu-nat.c (gnu_nat_target::wait): Fix
2466         target_waitstatus_to_string call.
2467
2468 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2469
2470         * eval.c (evaluate_subexp_standard): Handle internal functions
2471         during Fortran function call handling.
2472
2473 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2474
2475         * NEWS: Mention new internal functions.
2476         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2477         (read_base_type): Use dwarf2_init_complex_target_type.
2478         * value.c (creal_internal_fn): New function.
2479         (cimag_internal_fn): New function.
2480         (_initialize_values): Register new internal functions.
2481
2482 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2483
2484         * infrun.c (stop_all_threads): If debug_infrun, always
2485         trace the wait status after wait_one, using
2486         target_waitstatus_to_string and target_pid_to_str.
2487         (handle_inferior_event): Replace various trace of
2488         wait status kind by a single trace.
2489         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2490         wait status kind image by target_waitstatus_to_string.
2491         * target/waitstatus.c (target_waitstatus_to_string): Fix
2492         obsolete comment.
2493
2494 2019-04-01  Tom Tromey  <tromey@adacore.com>
2495
2496         PR symtab/23331:
2497         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2498
2499 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2500             Pedro Alves  <palves@redhat.com>
2501
2502         * top.c (quit_force): Call 'finalize_values'.
2503         * value.c (finalize_values): New function.
2504         * value.h (finalize_values): Declare.
2505
2506 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2507
2508         * NEWS: Announce $_gdb_major and $_gdb_minor.
2509
2510         * top.c (init_gdb_version_vars): New function.
2511         (gdb_init): Call init_gdb_version_vars.
2512
2513 2019-03-29  Tom Tromey  <tromey@adacore.com>
2514
2515         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2516         help text.  Remove dead code.
2517
2518 2019-03-29  Keith Seitz  <keiths@redhat.com>
2519
2520         From Siddhesh Poyarekar:
2521         * f-lang.h (f77_get_upperbound): Return LONGEST.
2522         (f77_get_lowerbound): Likewise.
2523         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2524         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2525         print them.
2526         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2527         plongest to format print it.
2528         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2529         (f77_get_upperbound): Likewise.
2530         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2531         LOWER_BOUND to LONGEST.
2532         (f77_create_arrayprint_offset_tbl): Likewise.
2533
2534 2019-03-29  Keith Seitz  <keiths@redhat.com>
2535
2536         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2537         %s/pulongest for TYPE_LENGTH instead of %d in format
2538         strings.
2539         * ada-typerint.c (ada_print_type): Likewise.
2540         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2541         * compile/compile-c-support.c (generate_register_struct): Likewise.
2542         * gdbtypes.c (recursive_dump_type): Likewise.
2543         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2544         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2545         instead of %d in format strings.
2546         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2547         to std::min to ULONGEST.
2548         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2549         instead of %d in format strings.
2550         * tracepoint.c (info_scope_command): Likewise.
2551         * typeprint.c (print_offset_data::update)
2552         (print_offset_data::finish): Likewise.
2553         * xtensa-tdep.c (xtensa_store_return_value)
2554         (xtensa_push_dummy_call): Likewise.
2555
2556 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2557
2558         * windows-nat.c (display_selector): Fixed format specifications
2559         for 64-bit Cygwin.
2560
2561 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2562
2563         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2564
2565 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2566
2567         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2568         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2569         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2570         (nios2_linux_init_abi): Install it.
2571
2572 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2573
2574         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2575
2576 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2577
2578         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2579
2580 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2581             Tom Tromey  <tromey@adacore.com>
2582
2583         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2584
2585 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2586
2587         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2588         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2589         method to compute the bounds of range types. Also print "[evaluated]"
2590         if the bounds' values come from a dynamic evaluation.
2591
2592 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2593
2594         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2595         whitespace when pretty printing is on.
2596
2597 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2598
2599         * ppc-linux-nat.c: Add include.
2600
2601 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2602
2603         * NEWS: Mention AArch64 Pointer Authentication.
2604
2605 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2606
2607         * arm-linux-nat.c: Add include.
2608
2609 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2610
2611         * source-cache.c (source_cache::get_source_lines): Re-read
2612         fullname after calling open_source_file.
2613
2614 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2615
2616         * NEWS: Mention TLS support for FreeBSD.
2617
2618 2019-03-25  Tom Tromey  <tromey@adacore.com>
2619
2620         * minsyms.c (BUNCH_SIZE): Update comment.
2621         (~minimal_symbol_reader): Remove old comment.
2622         (compact_minimal_symbols): Update comment.
2623         (minimal_symbol_reader::install): Remove old comment.  Update
2624         other comments.
2625
2626 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2627
2628         * s390-linux-nat.c: Add include.
2629
2630 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2631
2632         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2633         Call linux_get_hwcap.
2634         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2635         Likewise.
2636         (aarch64_linux_get_hwcap): Remove function.
2637         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2638         declaration.
2639         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2640         linux_get_hwcap.
2641         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2642         * linux-tdep.c (linux_get_hwcap): Add function.
2643         (linux_get_hwcap2): Likewise.
2644         * linux-tdep.h (linux_get_hwcap): Add declaration.
2645         (linux_get_hwcap2): Likewise.
2646         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2647         (ppc_linux_get_hwcap2): Likewise.
2648         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2649         linux_get_hwcap.
2650         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2651         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2652         (ppc_linux_nat_target::read_description): Likewise.
2653         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2654         * s390-linux-nat.c: Likewise.
2655         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2656
2657 2019-03-24  Tom Tromey  <tom@tromey.com>
2658
2659         * ada-lang.c (standard_lookup): Simplify initialization.
2660         (ada_lookup_symbol_nonlocal): Simplify return.
2661         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2662         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2663         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2664         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2665         initialization.
2666         * solib.c (solib_global_lookup): Simplify.
2667         * symtab.c (null_block_symbol): Remove.
2668         (symbol_cache_lookup): Simplify returns.
2669         (lookup_language_this): Simplify returns.
2670         (lookup_symbol_aux): Simplify return.
2671         (lookup_local_symbol): Simplify returns.
2672         (lookup_global_symbol_from_objfile): Simplify return.
2673         (lookup_symbol_in_objfile_symtabs)
2674         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2675         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2676         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2677         * cp-namespace.c (cp_lookup_bare_symbol)
2678         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2679         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2680         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2681         (cp_lookup_symbol_via_imports): Simplify initialization.
2682         (find_symbol_in_baseclass): Likewise.
2683         * symtab.h (null_block_symbol): Remove.
2684         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2685         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2686         (d_lookup_symbol_module): Likewise.
2687         (find_symbol_in_baseclass): Simplify initialization.
2688
2689 2019-03-24  Tom Tromey  <tom@tromey.com>
2690
2691         * expression.h: Don't include symtab.h.
2692         (struct block): Forward declare.
2693
2694 2019-03-24  Tom Tromey  <tom@tromey.com>
2695
2696         * c-exp.y (typebase): Remove casts.
2697         * gdbtypes.c (lookup_unsigned_typename, )
2698         (lookup_signed_typename): Remove cast.
2699         * eval.c (parse_to_comma_and_eval): Remove cast.
2700         * parse.c (write_dollar_variable): Remove cast.
2701         * block.h (struct block) <superblock>: Now const.
2702         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2703         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2704         (map_block): Make "block" const.
2705         * symfile.h (struct quick_symbol_functions)
2706         <map_matching_symbols>: Constify block argument to "callback".
2707         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2708         const.
2709         (find_pc_sect_compunit_symtab): Make "b" const.
2710         (find_symbol_at_address): Likewise.
2711         (search_symbols): Likewise.
2712         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2713         (dw2_debug_names_lookup_symbol): Likewise.
2714         (dw2_map_matching_symbols): Update.
2715         * p-valprint.c (pascal_val_print): Remove "block".
2716         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2717         (aux_add_nonlocal_symbols): Make "block" const.
2718         (resolve_subexp): Remove cast.
2719         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2720         const.
2721         (iterate_over_file_blocks): Likewise.
2722         * f-exp.y (%union) <bval>: Remove.
2723         * coffread.c (patch_opaque_types): Make "b" const.
2724         * spu-tdep.c (spu_catch_start): Make "block" const.
2725         * c-valprint.c (print_unpacked_pointer): Remove "block".
2726         * symmisc.c (dump_symtab_1): Make "b" const.
2727         (block_depth): Make "block" const.
2728         * d-exp.y (%union) <bval>: Remove.
2729         * cp-support.h (cp_lookup_rtti_type): Update.
2730         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2731         * psymtab.c (psym_lookup_symbol): Make "block" const.
2732         (maintenance_check_psymtabs): Make "b" const.
2733         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2734         (enumerate_locals, enumerate_args): Update.
2735         * python/py-symtab.c (stpy_global_block): Make "block" const.
2736         (stpy_static_block): Likewise.
2737         * inline-frame.c (block_starting_point_at): Make "new_block"
2738         const.
2739         * block.c (find_block_in_blockvector): Make return type const.
2740         (blockvector_for_pc_sect): Make "b" const.
2741         (find_block_in_blockvector): Make "b" const.
2742
2743 2019-03-23  Tom Tromey  <tom@tromey.com>
2744
2745         * varobj.c (varobj_create): Update.
2746         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2747         * printcmd.c (display_command, do_one_display): Don't reset
2748         innermost_block.
2749         * parser-defs.h (enum innermost_block_tracker_type): Move to
2750         expression.h.
2751         (innermost_block): Update comment.
2752         * parse.c (parse_exp_1): Add tracker_types parameter.
2753         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2754         tracker_types parameter.  Reset innermost_block.
2755         (parse_exp_in_context): Remove.
2756         (parse_expression_for_completion): Update.
2757         * objfiles.c (~objfile): Don't reset expression_context_block or
2758         innermost_block.
2759         * expression.h (enum innermost_block_tracker_type): Move from
2760         parser-defs.h.
2761         (parse_exp_1): Add tracker_types parameter.
2762         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2763         reset innermost_block.
2764
2765 2019-03-23  Tom Tromey  <tom@tromey.com>
2766
2767         * objfiles.h: Include bcache.h.
2768
2769 2019-03-23  Tom Tromey  <tom@tromey.com>
2770
2771         * linespec.c (get_current_search_block): Use
2772         scoped_restore_current_language.
2773         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2774
2775 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2776             Jiong Wang  <jiong.wang@arm.com>
2777
2778         * aarch64-linux-tdep.c
2779         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2780         section.
2781         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2782
2783 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2784             Jiong Wang  <jiong.wang@arm.com>
2785
2786         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2787         instructions.
2788         (aarch64_analyze_prologue_test): Add PACIASP test.
2789         (aarch64_prologue_prev_register): Unmask PC value.
2790
2791 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2792             Jiong Wang  <jiong.wang@arm.com>
2793
2794         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2795         (aarch64_dwarf2_prev_register): Unmask PC value.
2796         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2797         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2798         DW_CFA_AARCH64_negate_ra_state.
2799         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2800
2801 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2802             Jiong Wang  <jiong.wang@arm.com>
2803
2804         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2805         registers.
2806         (aarch64_pseudo_register_name): Likewise.
2807         (aarch64_pseudo_register_type): Likewise.
2808         (aarch64_pseudo_register_reggroup_p): Likewise.
2809         (aarch64_gdbarch_init): Add pauth registers.
2810         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2811         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2812         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2813         (struct gdbarch_tdep): Add regnum for ra_state.
2814
2815 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2816             Jiong Wang  <jiong.wang@arm.com>
2817
2818         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2819
2820 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2821             Jiong Wang  <jiong.wang@arm.com>
2822
2823         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2824         function.
2825         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2826         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2827         (aarch64_gdbarch_init): Add puth registers.
2828         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2829         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2830         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2831
2832 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2833             Jiong Wang  <jiong.wang@arm.com>
2834
2835         * aarch64-linux-nat.c
2836         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2837         * aarch64-linux-tdep.c
2838         (aarch64_linux_core_read_description): Likewise.
2839         (aarch64_linux_get_hwcap): New function.
2840         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2841         (aarch64_linux_get_hwcap): New declaration.
2842
2843 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2844             Jiong Wang  <jiong.wang@arm.com>
2845
2846         * aarch64-linux-nat.c
2847         (aarch64_linux_nat_target::read_description): Add pauth param.
2848         * aarch64-linux-tdep.c
2849         (aarch64_linux_core_read_description): Likewise.
2850         * aarch64-tdep.c (struct target_desc): Add in pauth.
2851         (aarch64_read_description): Add pauth param.
2852         (aarch64_gdbarch_init): Likewise.
2853         * aarch64-tdep.h (aarch64_read_description): Likewise.
2854         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2855         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2856         * features/Makefile: Add new files.
2857         * features/aarch64-pauth.c: New file.
2858         * features/aarch64-pauth.xml: New file.
2859
2860 2019-03-20  Tom Tromey  <tromey@adacore.com>
2861
2862         * infrun.c (handle_inferior_event): Rename from
2863         handle_inferior_event_1.  Create a scoped_value_mark.
2864         (handle_inferior_event): Remove.
2865
2866 2019-03-19  Tom Tromey  <tromey@adacore.com>
2867
2868         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2869         * infrun.h (print_stop_event): Add "displays" parameter.
2870         * infrun.c (print_stop_event): Add "displays" parameter.
2871
2872 2019-03-19  Pedro Alves  <palves@redhat.com>
2873
2874         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2875         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2876         to -1.  Fix TABs vs spaces.
2877         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2878         * tui/tui-out.h (tui_ui_out) Add intro comments.
2879         <m_line, m_start_of_line>: In-class initialize, and add describing
2880         comment.
2881
2882 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2883
2884         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2885         variable names.
2886         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2887
2888 2019-03-18  Pedro Alves  <palves@redhat.com>
2889             Eli Zaretskii <eliz@gnu.org>
2890
2891         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2892         m_line and m_start_of_line.
2893
2894 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2895
2896         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2897         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2898         it returns a newline.  This fixes a regression in TU mode, whereby
2899         the next line is output on the same screen line as the user input.
2900
2901 2019-03-18  Tom Tromey  <tromey@adacore.com>
2902
2903         * minsyms.c (minimal_symbol_reader::install): Remove call to
2904         obstack_blank.
2905
2906 2019-03-18  Pedro Alves  <palves@redhat.com>
2907
2908         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2909         New globals.
2910         (apply_style): New, factored out from ...
2911         (apply_ansi_escape): ... this.  Handle reverse video mode.
2912         (tui_set_reverse_mode): New function.
2913         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2914         * tui/tui-winsource.c (tui_show_source_line): Use
2915         tui_set_reverse_mode instead of setting A_STANDOUT.
2916         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2917         New setter methods.
2918
2919 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2920
2921         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2922         Handle tabs.
2923
2924 2019-03-18  Tom Tromey  <tromey@adacore.com>
2925
2926         * ada-lang.c (empty_array): Add "high" parameter.
2927         (ada_evaluate_subexp): Update.
2928
2929 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2930
2931         * unittests/string_view-selftests.c: Define
2932         _initialize_string_view_selftests unconditionally.
2933
2934 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2935
2936         PR gdb/24350
2937         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2938
2939 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2940
2941         PR gdb/24351
2942         * windows-nat.c (display_selector): Fix format specifiers.
2943
2944 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2945
2946         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2947         tui_refill_source_window instead of tui_refresh_win, to update the
2948         current execution line.  This fixes redisplay of the current line
2949         when stepping through the code with "next" or "step".
2950
2951 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2952
2953         * source-cache.c (source_cache::get_source_lines): Call
2954         find_source_lines to initialize s->nlines.  This fixes vertical
2955         scrolling of TUI source window when the DOWN arrow is pressed.
2956
2957 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2958
2959         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2960         linux-thread-db.c (_initialize_thread_db): Likewise.
2961
2962 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2963
2964         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2965         wclrtoeol in tui_show_source_line".  This reverts changes made in
2966         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2967
2968 2019-03-15  Tom Tromey  <tom@tromey.com>
2969
2970         * symtab.h (struct minimal_symbol): Derive from
2971         general_symbol_info.
2972         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2973         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2974         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2975         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2976         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2977         (MSYMBOL_SEARCH_NAME): Update.
2978         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2979         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2980         * minsyms.c (minimal_symbol_reader::record_full): Update.
2981
2982 2019-03-15  Tom Tromey  <tom@tromey.com>
2983
2984         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2985
2986 2019-03-15  Tom Tromey  <tom@tromey.com>
2987
2988         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2989         unique_xmalloc_ptr.
2990         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2991         Update.
2992         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2993         (build_minimal_symbol_hash_tables)
2994         (minimal_symbol_reader::install): Update.
2995
2996 2019-03-15  Tom Tromey  <tom@tromey.com>
2997
2998         * symtab.c (create_demangled_names_hash): Update.
2999         (symbol_set_names): Update.
3000         * objfiles.h (struct objfile_per_bfd_storage)
3001         <demangled_names_hash>: Now an htab_up.
3002         * objfiles.c (objfile_per_bfd_storage): Simplify.
3003
3004 2019-03-15  Tom Tromey  <tom@tromey.com>
3005
3006         * objfiles.h (struct objfile_per_bfd_storage): Declare
3007         destructor.
3008         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3009         New.
3010         (get_objfile_bfd_data): Use new.  Don't initialize
3011         language_of_main.
3012         (free_objfile_per_bfd_storage): Remove.
3013         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3014
3015 2019-03-15  Tom Tromey  <tom@tromey.com>
3016
3017         * symfile.c (reread_symbols): Update.
3018         * objfiles.c (objfile::objfile): Update.
3019         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3020         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3021         comment.
3022         (minimal_symbol_reader::install): Update.
3023         (terminate_minimal_symbol_table): Remove.
3024         * jit.c (jit_object_close_impl): Update.
3025
3026 2019-03-15  Tom Tromey  <tom@tromey.com>
3027
3028         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3029         initializations.
3030
3031 2019-03-15  Tom Tromey  <tom@tromey.com>
3032
3033         * objfiles.h (struct objfile_per_bfd_storage)
3034         <demangled_hash_languages>: Now a bitset.
3035         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3036         (lookup_minimal_symbol): Update.
3037
3038 2019-03-15  Tom Tromey  <tom@tromey.com>
3039
3040         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3041         Don't return the symbol.
3042         * coffread.c (record_minimal_symbol): Use record_full.
3043
3044 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3045
3046         The MS-Windows port of ncurses fails to switch to a color pair if
3047         one or both of the colors are the implicit default colors.  This
3048         change records the default colors when TUI is initialized, and
3049         then specifies them explicitly when a color pair uses the default
3050         colors.  This allows color styling in TUI mode on MS-Windows.
3051
3052         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3053         ncurses_norm_attr.
3054         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3055         colors in ncurses_norm_attr.
3056         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3057         "none", replace it with the default color recorded in
3058         ncurses_norm_attr.
3059
3060 2019-03-14  Tom Tromey  <tromey@adacore.com>
3061
3062         * source-cache.h (class source_cache) <get_source_lines>: Return
3063         std::string.
3064         * source-cache.c (source_cache::extract_lines): Handle case where
3065         first_pos==npos.  Return std::string.
3066         (source_cache::get_source_lines): Update.
3067
3068 2019-03-14  Tom Tromey  <tromey@adacore.com>
3069
3070         * NEWS: Add item for "style sources" commands.
3071         * source-cache.c (source_cache::get_source_lines): Check
3072         source_styling.
3073         * cli/cli-style.c (source_styling): New global.
3074         (_initialize_cli_style): Add "style sources" commands.
3075         (show_style_sources): New function.
3076         * cli/cli-style.h (source_styling): Declare.
3077
3078 2019-03-14  Pedro Alves  <palves@redhat.com>
3079             Tom Tromey  <tromey@adacore.com>
3080
3081         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3082         * tui/tui-winsource.c (tui_refill_source_window): New function,
3083         from...
3084         (tui_horizontal_source_scroll): ... here.  Move some logic.
3085         * cli/cli-style.c (set_style_enabled): Notify new observable.
3086         * tui/tui-hooks.c (tui_redisplay_source): New function.
3087         (tui_attach_detach_observers): Attach or detach
3088         tui_redisplay_source.
3089         * observable.h (source_styling_changed): New observable.
3090         * observable.c: Define source_styling_changed observable.
3091
3092 2019-03-13  Tom Tromey  <tromey@adacore.com>
3093
3094         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3095         (i386_gnu_nat_target::store_registers): Update.
3096         * target-debug.h (target_debug_print_std_string): New macro.
3097         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3098         * windows-tdep.c (display_one_tib): Update.
3099         * tui/tui-stack.c (tui_make_status_line): Update.
3100         * top.c (print_inferior_quit_action): Update.
3101         * thread.c (thr_try_catch_cmd): Update.
3102         (add_thread_with_info): Update.
3103         (thread_target_id_str): Update.
3104         (thr_try_catch_cmd): Update.
3105         (thread_command): Update.
3106         (thread_find_command): Update.
3107         * record-btrace.c (record_btrace_target::info_record)
3108         (record_btrace_resume_thread, record_btrace_target::resume)
3109         (record_btrace_cancel_resume, record_btrace_step_thread)
3110         (record_btrace_target::wait, record_btrace_target::wait)
3111         (record_btrace_target::wait, record_btrace_target::stop): Update.
3112         * progspace.c (print_program_space): Update.
3113         * process-stratum-target.c
3114         (process_stratum_target::thread_address_space): Update.
3115         * linux-fork.c (linux_fork_mourn_inferior)
3116         (detach_checkpoint_command, info_checkpoints_command)
3117         (linux_fork_context): Update.
3118         (linux_fork_detach): Update.
3119         (class scoped_switch_fork_info): Update.
3120         (delete_checkpoint_command): Update.
3121         * infrun.c (follow_fork_inferior): Update.
3122         (follow_fork_inferior): Update.
3123         (proceed_after_vfork_done): Update.
3124         (handle_vfork_child_exec_or_exit): Update.
3125         (follow_exec): Update.
3126         (displaced_step_prepare_throw): Update.
3127         (displaced_step_restore): Update.
3128         (start_step_over): Update.
3129         (resume_1): Update.
3130         (clear_proceed_status_thread): Update.
3131         (proceed): Update.
3132         (print_target_wait_results): Update.
3133         (do_target_wait): Update.
3134         (context_switch): Update.
3135         (stop_all_threads): Update.
3136         (restart_threads): Update.
3137         (finish_step_over): Update.
3138         (handle_signal_stop): Update.
3139         (switch_back_to_stepped_thread): Update.
3140         (keep_going_pass_signal): Update.
3141         (print_exited_reason): Update.
3142         (normal_stop): Update.
3143         * inferior.c (inferior_pid_to_str): Change return type.
3144         (print_selected_inferior): Update.
3145         (add_inferior): Update.
3146         (detach_inferior): Update.
3147         * dummy-frame.c (fprint_dummy_frames): Update.
3148         * dcache.c (dcache_info_1): Update.
3149         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3150         (btrace_fetch, btrace_clear): Update.
3151         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3152         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3153         type.
3154         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3155         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3156         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3157         * gdbarch.c, gdbarch.h: Rebuild.
3158         * gdbarch.sh (core_pid_to_str): Change return type.
3159         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3160         return type.
3161         (windows_nat_target::pid_to_str): Change return type.
3162         (windows_delete_thread): Update.
3163         (windows_nat_target::attach): Update.
3164         (windows_nat_target::files_info): Update.
3165         * target-delegates.c: Rebuild.
3166         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3167         return type.
3168         (sol_thread_target::pid_to_str): Change return type.
3169         * remote.c (class remote_target) <pid_to_str>: Change return
3170         type.
3171         (remote_target::pid_to_str): Change return type.
3172         (extended_remote_target::attach, remote_target::remote_stop_ns)
3173         (remote_target::remote_notif_remove_queued_reply)
3174         (remote_target::push_stop_reply, remote_target::disable_btrace):
3175         Update.
3176         (extended_remote_target::attach): Update.
3177         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3178         type.
3179         (gdbsim_target::pid_to_str): Change return type.
3180         * ravenscar-thread.c (struct ravenscar_thread_target)
3181         <pid_to_str>: Change return type.
3182         (ravenscar_thread_target::pid_to_str): Change return type.
3183         * procfs.c (class procfs_target) <pid_to_str>: Change return
3184         type.
3185         (procfs_target::pid_to_str): Change return type.
3186         (procfs_target::attach): Update.
3187         (procfs_target::detach): Update.
3188         (procfs_target::fetch_registers): Update.
3189         (procfs_target::store_registers): Update.
3190         (procfs_target::wait): Update.
3191         (procfs_target::files_info): Update.
3192         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3193         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3194         return type.
3195         (nto_procfs_target::pid_to_str): Change return type.
3196         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3197         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3198         return type.
3199         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3200         (exit_lwp): Update.
3201         (attach_proc_task_lwp_callback, get_detach_signal)
3202         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3203         (linux_nat_target::resume, wait_lwp, stop_callback)
3204         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3205         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3206         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3207         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3208         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3209         type.
3210         (inf_ptrace_target::attach): Update.
3211         (inf_ptrace_target::files_info): Update.
3212         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3213         type.
3214         (go32_nat_target::pid_to_str): Change return type.
3215         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3216         (gnu_nat_target::wait): Update.
3217         (gnu_nat_target::wait): Update.
3218         (gnu_nat_target::resume): Update.
3219         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3220         (fbsd_nat_target::wait): Update.
3221         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3222         type.
3223         (darwin_nat_target::attach): Update.
3224         * corelow.c (class core_target) <pid_to_str>: Change return type.
3225         (core_target::pid_to_str): Change return type.
3226         * target.c (normal_pid_to_str): Change return type.
3227         (default_pid_to_str): Likewise.
3228         (target_pid_to_str): Change return type.
3229         (target_translate_tls_address): Update.
3230         (target_announce_detach): Update.
3231         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3232         return type.
3233         (bsd_uthread_target::pid_to_str): Change return type.
3234         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3235         type.
3236         (bsd_kvm_target::pid_to_str): Change return type.
3237         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3238         return type.
3239         (aix_thread_target::pid_to_str): Change return type.
3240         * target.h (struct target_ops) <pid_to_str>: Change return type.
3241         (target_pid_to_str, normal_pid_to_str): Likewise.
3242         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3243         type.
3244         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3245         type.
3246         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3247         return type.
3248         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3249         type.
3250         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3251         type.
3252         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3253         return type.
3254
3255 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3256
3257         * NEWS: Mention that the new default MI version is 3.  Mention
3258         changes to the output of commands and events that deal with
3259         multi-location breakpoints.
3260         * breakpoint.c: Include "mi/mi-out.h".
3261         (print_one_breakpoint): Change output syntax if using MI version
3262         >= 3.
3263         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3264         New.
3265         (mi_multi_location_breakpoint_output_fixed): New.
3266         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3267         (mi_cmd_fix_multi_location_breakpoint_output): New.
3268         (mi_multi_location_breakpoint_output_fixed): New.
3269         * mi/mi-cmds.c (mi_cmds): Register command
3270         -fix-multi-location-breakpoint-output.
3271         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3272         interpreter "mi".
3273
3274 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3275
3276         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3277         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3278         instantiate mi_ui_out based on interpreter name.
3279         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3280         * mi/mi-main.c (mi_load_progress): Likewise.
3281
3282 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3283
3284         * NEWS: Combine separate "New targets" sections for 8.3.
3285
3286 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3287
3288         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3289         (ppcfbsd_init_abi): Install gdbarch
3290         "fetch_tls_load_module_address" and "get_thread_local_address"
3291         methods.
3292
3293 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3294
3295         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3296         (riscv_fbsd_init_abi): Install gdbarch
3297         "fetch_tls_load_module_address" and "get_thread_local_address"
3298         methods.
3299
3300 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3301
3302         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3303         (i386fbsd_init_abi): Install gdbarch
3304         "fetch_tls_load_module_address" and "get_thread_local_address"
3305         methods.
3306
3307 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3308
3309         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3310         (amd64fbsd_init_abi): Install gdbarch
3311         "fetch_tls_load_module_address" and "get_thread_local_address"
3312         methods.
3313
3314 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3315
3316         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3317         (struct fbsd_pspace_data): New type.
3318         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3319         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3320         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3321         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3322         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3323
3324 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3325
3326         * gdbtypes.c (lookup_struct_elt): New function.
3327         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3328         * gdbtypes.h (struct struct_elt): New type.
3329         (lookup_struct_elt): New prototype.
3330
3331 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3332
3333         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3334         remove disabled code block.
3335
3336 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3337
3338         * gdbarch.sh (get_thread_local_address): New method.
3339         * gdbarch.h, gdbarch.c: Regenerate.
3340         * target.c (target_translate_tls_address): Use
3341         gdbarch_get_thread_local_address if present instead of
3342         target::get_thread_local_address.
3343
3344 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3345
3346         * target.h (target::get_thread_local_address): Update comment.
3347
3348 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3349
3350         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3351         objfile->separate_debug_objfile_backlink if not NULL.
3352
3353 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3354
3355         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3356         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3357         (amd64bsd_store_inferior_registers): Likewise.
3358         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3359         Enable segment base registers.
3360         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3361         PT_GETFSBASE and PT_GETGSBASE.
3362         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3363         PT_SETGSBASE.
3364         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3365         segment base registers.
3366         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3367
3368 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3369
3370         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3371         Update calls to i386_target_description to add 'segments'
3372         parameter.
3373         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3374         add segment base registers.
3375         * arch/i386.c (i386_create_target_description): Add 'segments'
3376         parameter to enable segment base registers.
3377         * arch/i386.h (i386_create_target_description): Likewise.
3378         * features/i386/32bit-segments.xml: New file.
3379         * features/i386/32bit-segments.c: Generate.
3380         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3381         call to i386_target_description to add 'segments' parameter.
3382         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3383         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3384         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3385         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3386         if feature is present.
3387         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3388         Add 'segments' parameter to call to i386_target_description.
3389         (i386_target_description): Add 'segments' parameter to enable
3390         segment base registers.
3391         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3392         to call to i386_target_description.
3393         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3394         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3395         Define I386_NUM_REGS.
3396         (i386_target_description): Add 'segments' parameter to enable
3397         segment base registers.
3398
3399 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3400
3401         PR/24325
3402         * source-cache.c: #undef open and close, to avoid unresolved
3403         externals during linking.
3404
3405 2019-03-12  Tom Tromey  <tromey@adacore.com>
3406
3407         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3408         const.  Add initializers.
3409         (_initialize_remote): Don't initialize ptid globals.
3410
3411 2019-03-12  Pedro Alves  <palves@redhat.com>
3412
3413         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3414
3415 2019-03-12  Pedro Alves  <palves@redhat.com>
3416
3417         * cp-name-parser.y (main): Remove unused 'len' variable.
3418
3419 2019-03-12  Tom Tromey  <tromey@adacore.com>
3420
3421         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3422         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3423
3424 2019-03-12  Tom Tromey  <tromey@adacore.com>
3425
3426         * linux-nat.c (iterate_over_lwps): Update.
3427         (stop_callback): Remove parameter.
3428         (stop_wait_callback, detach_callback, resume_set_callback)
3429         (select_singlestep_lwp_callback, set_ignore_sigint)
3430         (status_callback, resumed_callback, resume_clear_callback)
3431         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3432         data parameter.
3433         (linux_nat_target::detach, linux_nat_target::resume)
3434         (linux_stop_and_wait_all_lwps, select_event_lwp)
3435         (linux_nat_filter_event, linux_nat_wait_1)
3436         (linux_nat_target::kill, linux_nat_target::stop)
3437         (linux_nat_target::stop): Update.
3438         (linux_nat_resume_callback): Change type.
3439         (resume_stopped_resumed_lwps, count_events_callback)
3440         (select_event_lwp_callback): Likewise.
3441         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3442         * arm-linux-nat.c (struct update_registers_data): Remove.
3443         (update_registers_callback): Change type.
3444         (arm_linux_insert_hw_breakpoint1): Update.
3445         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3446         parameter.
3447         (x86_linux_dr_set_addr): Update.
3448         (x86_linux_dr_set_control): Update.
3449         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3450         (iterate_over_lwps): Use gdb::function_view.
3451         * nat/aarch64-linux-hw-point.c (struct
3452         aarch64_dr_update_callback_param): Remove.
3453         (debug_reg_change_callback): Change type.
3454         (aarch64_notify_debug_reg_change): Update.
3455         * s390-linux-nat.c (s390_refresh_per_info): Update.
3456
3457 2019-03-11  Tom Tromey  <tromey@adacore.com>
3458
3459         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3460         redundant assignment to "this_cu".
3461
3462 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3463
3464         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3465
3466 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3467
3468         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3469         from...
3470         (rank_one_type): ... this.
3471
3472 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3473
3474         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3475         from...
3476         (rank_one_type): ... this.
3477
3478 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3479
3480         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3481         from...
3482         (rank_one_type): ... this.
3483
3484 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3485
3486         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3487         from...
3488         (rank_one_type): ... this.
3489
3490 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3491
3492         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3493         from...
3494         (rank_one_type): ... this.
3495
3496 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3497
3498         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3499         from...
3500         (rank_one_type): ... this.
3501
3502 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3503
3504         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3505         from...
3506         (rank_one_type): ... this.
3507
3508 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3509
3510         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3511         from...
3512         (rank_one_type): ... this.
3513
3514 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3515
3516         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3517         from...
3518         (rank_one_type): ... this.
3519
3520 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3521
3522         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3523         from...
3524         (rank_one_type): ... this.
3525
3526 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3527
3528         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3529         from...
3530         (rank_one_type): ... this.
3531
3532 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3533
3534         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3535         from...
3536         (rank_one_type): ... this.
3537
3538 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3539
3540         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3541         inferior-events' shows the example events.
3542
3543 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3544
3545         Support styling on native MS-Windows console
3546
3547         PR/24315
3548         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3549         on MS-Windows if $TERM is not defined.
3550
3551         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3552
3553         * posix-hdep.c (gdb_console_fputs):
3554         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3555         functions.
3556         * ui-file.h (gdb_console_fputs): Add prototype.
3557
3558         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3559         back to fputs only if the former returns zero.
3560
3561 2019-03-07  Tom Tromey  <tom@tromey.com>
3562
3563         * symmisc.c (print_symbol_bcache_statistics): Update.
3564         (print_objfile_statistics): Update.
3565         * symfile.c (allocate_symtab): Update.
3566         * stabsread.c: Don't include bcache.h.
3567         * psymtab.h (struct psymbol_bcache): Don't declare.
3568         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3569         (psymbol_bcache_init, psymbol_bcache_free)
3570         (psymbol_bcache_get_bcache): Don't declare.
3571         * psymtab.c (struct psymbol_bcache): Remove.
3572         (psymtab_storage::psymtab_storage): Update.
3573         (psymtab_storage::~psymtab_storage): Update.
3574         (psymbol_bcache_init, psymbol_bcache_free)
3575         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3576         (add_psymbol_to_bcache): Update.
3577         (allocate_psymtab): Update.
3578         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3579         macro_cache>: No longer pointers.
3580         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3581         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3582         * macrotab.c (macro_bcache): Update.
3583         * macroexp.c: Don't include bcache.h.
3584         * gdbtypes.c (check_types_worklist): Update.
3585         (types_deeply_equal): Remove TRY/CATCH.  Update.
3586         * elfread.c (elf_symtab_read): Update.
3587         * dwarf2read.c: Don't include bcache.h.
3588         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3589         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3590         (print_bcache_statistics, bcache_memory_used): Don't declare.
3591         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3592         methods.  Rename all data members.
3593         * bcache.c (struct bcache): Move to bcache.h.
3594         (bcache::expand_hash_table): Rename from expand_hash_table.
3595         (bcache): Remove.
3596         (bcache::insert): Rename from bcache_full.
3597         (bcache::compare): Rename from bcache_compare.
3598         (bcache_xmalloc): Remove.
3599         (bcache::~bcache): Rename from bcache_xfree.
3600         (bcache::print_statistics): Rename from print_bcache_statistics.
3601         (bcache::memory_used): Rename from bcache_memory_used.
3602
3603 2019-03-07  Pedro Alves  <palves@redhat.com>
3604
3605         * infrun.c (normal_stop): Also check for
3606         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3607
3608 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3609
3610         * f-lang.c (value_from_host_double): Moved to...
3611         * value.c (value_from_host_double): ...here.
3612         * value.h (value_from_host_double): Declare.
3613         * guile/scm-math.c (vlscm_convert_typed_number): Use
3614         value_from_host_double.
3615         (vlscm_convert_number): Likewise.
3616         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3617         * python/py-value.c (convert_value_from_python): Likewise.
3618
3619 2019-03-06  Tom Tromey  <tom@tromey.com>
3620
3621         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3622
3623 2019-03-06  Tom Tromey  <tom@tromey.com>
3624
3625         * utils.h (free_current_contents): Don't declare.
3626         * utils.c (free_current_contents): Remove.
3627
3628 2019-03-06  Tom Tromey  <tom@tromey.com>
3629
3630         * top.c (quit_force): Update.
3631         * main.c (captured_command_loop): Update.
3632         * common/new-op.c (operator new): Update.
3633         * common/common-exceptions.c (struct catcher)
3634         <save_cleanup_chain>: Remove member.
3635         (exceptions_state_mc_init): Update.
3636         (exception_try_scope_entry): Return nullptr.
3637         (exception_try_scope_exit, exception_rethrow)
3638         (throw_exception_sjlj, throw_exception_cxx): Update.
3639         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3640         (all_cleanups, do_cleanups, discard_cleanups)
3641         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3642         (restore_cleanups, restore_final_cleanups): Don't declare.
3643         (do_final_cleanups): Remove parameter.
3644         * common/cleanups.c (cleanup_chain, make_cleanup)
3645         (make_cleanup_dtor, all_cleanups, do_cleanups)
3646         (discard_my_cleanups, discard_cleanups)
3647         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3648         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3649         (null_cleanup): Remove.
3650         (do_final_cleanups): Remove parameter.
3651
3652 2019-03-06  Tom Tromey  <tom@tromey.com>
3653
3654         * remote.c (remote_target::remote_parse_stop_reply): Use
3655         unique_xmalloc_ptr.
3656
3657 2019-03-06  Tom Tromey  <tom@tromey.com>
3658
3659         * stabsread.c (struct stabs_field_info): Rename from field_info.
3660         <list, fnlist>: Add initializers.
3661         <obstack>: New member.
3662         (read_member_functions, read_struct_fields, read_baseclasses):
3663         Allocate on obstack.  Don't use cleanups.
3664         (read_one_struct_field, read_member_functions, read_struct_fields)
3665         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3666         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3667         (read_struct_type): Update.
3668
3669 2019-03-06  Tom Tromey  <tom@tromey.com>
3670
3671         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3672         * common/filestuff.h (make_cleanup_close): Don't declare.
3673         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3674         Remove.
3675
3676 2019-03-06  Tom Tromey  <tom@tromey.com>
3677
3678         * solib-aix.c: Use make_scope_exit.
3679
3680 2019-03-06  Tom Tromey  <tom@tromey.com>
3681
3682         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3683         Use make_scope_exit.
3684
3685 2019-03-06  Tom Tromey  <tom@tromey.com>
3686
3687         * solib-svr4.c (disable_probes_interface): Remove parameter.
3688         (svr4_handle_solib_event): Use make_scope_exit.
3689
3690 2019-03-06  Tom Tromey  <tom@tromey.com>
3691
3692         * remote.c (struct stop_reply_deleter): Remove.
3693         (stop_reply_up): Update.
3694         (struct stop_reply): Derive from notif_event.  Don't typedef.
3695         <regcache>: Now a std::vector.
3696         (stop_reply_xfree): Remove.
3697         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3698         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3699         (remote_target::discard_pending_stop_replies): Use delete.
3700         (remote_target::remote_parse_stop_reply): Update.
3701         (remote_target::process_stop_reply): Update.
3702         * remote-notif.h (struct notif_event): Add virtual destructor.
3703         Remove "dtr" member.
3704         (struct notif_client) <alloc_event>: Return a unique_ptr.
3705         (notif_event_xfree): Don't declare.
3706         (notif_event_up): New typedef.
3707         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3708         (notif_event_xfree, do_notif_event_xfree): Remove.
3709         (remote_notif_state_xfree): Update.
3710
3711 2019-03-06  Tom Tromey  <tom@tromey.com>
3712
3713         * infrun.c (displaced_step_clear_cleanup): Now a
3714         forward_scope_exit type.
3715         (displaced_step_prepare_throw): Update.
3716         (displaced_step_fixup): Update.
3717
3718 2019-03-06  Tom Tromey  <tom@tromey.com>
3719
3720         * inferior.h (class inferior): Update comment.
3721         * gdbthread.h (class thread_info): Update comment.
3722
3723 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3724             Tom Tromey  <tom@tromey.com>
3725
3726         * stabsread.h (struct stab_section_list): Remove.
3727         (coffstab_build_psymtabs): Update.
3728         * dbxread.c (symbuf_sections): Now a std::vector.
3729         (sect_idx): New global.
3730         (fill_symbuf): Update.
3731         (coffstab_build_psymtabs): Change type of stabsects parameter.
3732         Update.
3733         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3734         std::vector.
3735         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3736         (coff_locate_sections): Update.
3737         (coff_symfile_read): Remove cleanups.  Update.
3738         (init_stringtab): Add storage parameter.
3739         (free_stringtab, free_stringtab_cleanup): Remove.
3740         (init_lineno): Add storage parameter.
3741         (free_linetab, free_linetab_cleanup): Remove.
3742
3743 2019-03-06  Pedro Alves  <palves@redhat.com>
3744
3745         * linux-fork.c (fork_info::clobber_regs): Delete.
3746         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3747         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3748         comment.  Adjust.
3749         (scoped_switch_fork_info::scoped_switch_fork_info)
3750         (checkpoint_command, linux_fork_context): Adjust
3751         fork_save_infrun_state calls.
3752
3753 2019-03-06  Pedro Alves  <palves@redhat.com>
3754
3755         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3756         (inf_has_multiple_threads): Return 'bool' and rewrite using
3757         inferior_info::threads().
3758
3759 2019-03-06  Pedro Alves  <palves@redhat.com>
3760
3761         * linux-fork.c: Include <list>.
3762         (fork_list): Now a std::list instance.
3763         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3764         (forks_exist_p, find_last_fork): Adjust.
3765         (new_fork): Delete.
3766         (one_fork_p): New.
3767         (add_fork): Adjust.
3768         (free_fork): Delete, folded into fork_info::~fork_info().
3769         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3770         Adjust.
3771         (init_fork_list): Delete.
3772         (linux_fork_killall, linux_fork_mourn_inferior)
3773         (linux_fork_detach, info_checkpoints_command): Adjust.
3774         (_initialize_linux_fork): No longer call init_fork_list.
3775
3776 2019-03-06  Pedro Alves  <palves@redhat.com>
3777
3778         * linux-fork.c (new_fork): New, split out of ...
3779         (add_fork): ... this.  Return void.  Move "first fork" special
3780         case from here, to ...
3781         (checkpoint_command): ... here.
3782         * linux-linux.h (add_fork): Return void.
3783
3784 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3785
3786         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3787
3788 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3789             Chris January  <chris.january@arm.com>
3790             David Lecomber  <david.lecomber@arm.com>
3791
3792         * f-exp.y: New token, UNOP_INTRINSIC.
3793         (exp): New pattern using UNOP_INTRINSIC token.
3794         (f77_keywords): Add 'abs' keyword.
3795         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3796         (value_from_host_double): New function.
3797         (evaluate_subexp_f): Support UNOP_ABS.
3798
3799 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3800
3801         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3802         types.
3803
3804 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3805
3806         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3807         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3808         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3809
3810 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3811
3812         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3813
3814 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3815             Chris January  <chris.january@arm.com>
3816
3817         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3818         * f-exp.y: Define 'KIND' token.
3819         (exp): New pattern for KIND expressions.
3820         (ptype): Handle types with a kind extension.
3821         (direct_abs_decl): Extend to spot kind extensions.
3822         (f77_keywords): Add 'kind' to the list.
3823         (push_kind_type): New function.
3824         (convert_to_kind_type): New function.
3825         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3826         * parse.c (operator_length_standard): Likewise.
3827         * parser-defs.h (enum type_pieces): Add tp_kind.
3828         * std-operator.def: Add UNOP_KIND.
3829
3830 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3831
3832         * f-exp.y (f_parse): Set yydebug.
3833
3834 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3835
3836         * f-lang.c (evaluate_subexp_f): New function.
3837         (exp_descriptor_f): New global.
3838         (f_language_defn): Use exp_descriptor_f instead of
3839         exp_descriptor_standard.
3840
3841 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3842
3843         * f-exp.y (struct token): Add comments.
3844         (dot_ops): Remove uppercase versions and the end marker.
3845         (f77_keywords): Likewise.
3846         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3847         entries in the dot_ops array are case insensitive, and use
3848         strncasecmp to compare strings.  Also some whitespace cleanup in
3849         this area.  Similar for the f77_keywords array, except entries in
3850         this list might be case sensitive.
3851
3852 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3853
3854         * f-exp.y (struct f77_boolean_val): Add comments.
3855         (boolean_values): Remove uppercase versions, and end marker.
3856         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3857         and use strncasecmp to achieve case insensitivity.  Additionally,
3858         perform whitespace cleanup around this code.
3859
3860 2019-03-06  Tom Tromey  <tromey@adacore.com>
3861
3862         * remote-sim.c (gdbsim_target_open): Use result of
3863         gdb_argv::release.
3864
3865 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3866         Dirk Schubert  <dirk.schubert@arm.com>
3867         Chris January  <chris.january@arm.com>
3868
3869         * eval.c (evaluate_subexp_standard): Call Fortran argument
3870         wrapping logic.
3871         * f-lang.c (struct value): A value which can be passed into a
3872         Fortran function call.
3873         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3874         where appropriate.
3875         (struct type): Value ready for a Fortran function call.
3876         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3877         is needed.
3878         * f-lang.h (fortran_argument_convert): Declaration.
3879         (fortran_preserve_arg_pointer): Declaration.
3880         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3881
3882 2019-03-05  Tom Tromey  <tromey@adacore.com>
3883
3884         * python/py-prettyprint.c (print_string_repr): Remove #if.
3885         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3886
3887 2019-03-05  Tom Tromey  <tromey@adacore.com>
3888
3889         * target.c (the_dummy_target): Move later.  Change type to
3890         "dummy_target".
3891         (initialize_targets): Don't initialize the_dummy_target.
3892
3893 2019-03-05  Tom Tromey  <tromey@adacore.com>
3894
3895         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3896         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3897
3898 2019-03-05  Tom Tromey  <tromey@adacore.com>
3899
3900         * windows-nat.c (windows_nat_target::attach)
3901         (windows_nat_target::detach): Don't call gdb_flush.
3902         * valprint.c (generic_val_print, val_print, val_print_string):
3903         Don't call gdb_flush.
3904         * utils.c (defaulted_query): Don't call gdb_flush.
3905         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3906         * target.c (target_announce_detach): Don't call gdb_flush.
3907         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3908         * remote.c (extended_remote_target::attach): Don't call
3909         gdb_flush.
3910         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3911         * printcmd.c (do_examine): Don't call gdb_flush.
3912         (info_display_command): Don't call gdb_flush.
3913         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3914         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3915         * memattr.c (info_mem_command): Don't call gdb_flush.
3916         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3917         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3918         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3919         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3920         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3921         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3922         (gnu_nat_target::detach): Don't call gdb_flush.
3923         * f-valprint.c (f_val_print): Don't call gdb_flush.
3924         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3925         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3926         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3927         gdb_flush.
3928         * c-valprint.c (c_val_print): Don't call gdb_flush.
3929         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3930
3931 2019-03-05  Tom Tromey  <tromey@adacore.com>
3932
3933         * varobj.c (update_dynamic_varobj_children): Update.
3934         (install_default_visualizer): Use reset, not release.
3935         * value.c (set_internalvar): Update.
3936         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3937         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3938         ATTRIBUTE_UNUSED_RESULT.
3939
3940 2019-03-05  Tom Tromey  <tromey@adacore.com>
3941
3942         * remote.c (class scoped_remote_fd) <release>: Add
3943         ATTRIBUTE_UNUSED_RESULT.
3944
3945 2019-03-05  Tom Tromey  <tromey@adacore.com>
3946
3947         * macroexp.c (struct macro_buffer) <release>: Add
3948         ATTRIBUTE_UNUSED_RESULT.
3949
3950 2019-03-05  Tom Tromey  <tromey@adacore.com>
3951
3952         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3953         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3954         ATTRIBUTE_UNUSED_RESULT.
3955
3956 2019-03-05  Tom Tromey  <tromey@adacore.com>
3957
3958         * common/scoped_fd.h (class scoped_fd) <release>: Add
3959         ATTRIBUTE_UNUSED_RESULT.
3960
3961 2019-03-05  Tom Tromey  <tromey@adacore.com>
3962
3963         * parser-defs.h (struct parser_state) <release>: Add
3964         ATTRIBUTE_UNUSED_RESULT.
3965
3966 2019-03-05  Tom Tromey  <tromey@adacore.com>
3967
3968         * utils.h (class gdb_argv) <release>: Add
3969         ATTRIBUTE_UNUSED_RESULT.
3970         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3971
3972 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3973
3974         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3975         for-loop range, to avoid compiler warnings.
3976
3977         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3978         avoid compiler warnings about unused variables.
3979
3980         * NEWS: Mention end of support for native debugging on MS-Windows
3981         before XP.
3982
3983         PR gdb/24292
3984         * common/netstuff.c:
3985         * gdbserver/gdbreplay.c
3986         * gdbserver/remote-utils.c:
3987         * ser-tcp.c:
3988         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3989         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3990         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3991         'getaddrinfo' and 'freeaddrinfo' were not available before
3992         Windows XP, and mingw.org's MinGW headers by default define
3993         _WIN32_WINNT to 0x500.
3994
3995 2019-03-01  Gary Benson <gbenson@redhat.com>
3996
3997         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3998
3999 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4000             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4001
4002         PR gdb/8527
4003         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4004         set_sigint_trap, clear_sigint_trap.
4005
4006 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4007
4008         * target.c (target_detach): Clear the regcache and the
4009         frame cache.
4010
4011 2019-02-27  Pedro Alves  <palves@redhat.com>
4012
4013         * utils.c (set_screen_size): When we cap the height/width sizes,
4014         tweak the corresponding command variable to show "unlimited":
4015
4016 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4017             Pedro Alves  <palves@redhat.com>
4018
4019         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4020         before calling rl_set_screen_size.
4021
4022 2019-02-27  Tom Tromey  <tromey@adacore.com>
4023
4024         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4025         define.
4026         * python/py-value.c: Remove Python 2.4 workaround.
4027         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4028         workaround.
4029         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4030         Python 2.4 workaround.
4031         * python/python-internal.h: Remove Python 2.4 comment.
4032         (Py_ssize_t): Don't define.
4033         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4034         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4035         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4036         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4037         * python/python.c (do_start_initialization): Remove Python 2.4
4038         workaround.
4039         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4040         (print_children): Remove Python 2.4 workaround.
4041         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4042         workaround.
4043         (CHARBUFFERPROC_NAME): Remove.
4044         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4045         Python 2.4 workaround.
4046
4047 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4048
4049         * NEWS: Note minimum Python version.
4050
4051 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4052
4053         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4054         code from these functions.  Remove corresponding ifdefs.  Use
4055         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4056         Remove gotos and target of gotos.
4057         (infpy_search_memory): Likewise.
4058
4059 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4060
4061         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4062         (hppa_gdbarch_init): Don't register deleted functions with
4063         gdbarch.
4064
4065 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4066
4067         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4068         (h8300_unwind_sp): Delete.
4069         (h8300_dummy_id): Delete.
4070         (h8300_gdbarch_init): Don't register deleted functions with
4071         gdbarch.
4072
4073 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4074
4075         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4076         (ft32_unwind_pc): Delete.
4077         (ft32_unwind_sp): Delete.
4078         (ft32_gdbarch_init): Don't register deleted functions with
4079         gdbarch.
4080
4081 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4082
4083         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4084         (frv_unwind_pc): Delete.
4085         (frv_unwind_sp): Delete.
4086         (frv_gdbarch_init): Don't register deleted functions with
4087         gdbarch.
4088
4089 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4090
4091         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4092         (riscv_unwind_pc): Delete.
4093         (riscv_unwind_sp): Delete.
4094         (riscv_gdbarch_init): Don't register deleted functions with
4095         gdbarch.
4096
4097 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4098
4099         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4100         (csky_unwind_pc): Delete.
4101         (csky_unwind_sp): Delete.
4102         (csky_gdbarch_init): Don't register deleted functions with
4103         gdbarch.
4104
4105 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4106
4107         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4108         (cris_unwind_pc): Delete.
4109         (cris_unwind_sp): Delete.
4110         (cris_gdbarch_init): Don't register deleted functions with
4111         gdbarch.
4112
4113 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4114
4115         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4116         (bfin_unwind_pc): Delete.
4117         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4118
4119 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4120
4121         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4122         (arm_unwind_pc): Delete.
4123         (arm_unwind_sp): Delete.
4124         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4125
4126 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4127
4128         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4129         (arc_unwind_pc): Delete.
4130         (arc_unwind_sp): Delete.
4131         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4132
4133 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4134
4135         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4136         (alpha_unwind_pc): Delete.
4137         (alpha_gdbarch_init): Don't register deleted functions with
4138         gdbarch.
4139
4140 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4141
4142         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4143         (aarch64_unwind_pc): Delete.
4144         (aarch64_unwind_sp): Delete.
4145         (aarch64_gdbarch_init): Don't register deleted functions with
4146         gdbarch.
4147
4148 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4149
4150         * gdbtypes.c (type_align): Don't consider static members when
4151         computing structure alignment.
4152
4153 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4154
4155         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4156         return 0 for other types.
4157         * arch-utils.c (default_type_align): Always return 0.
4158         * gdbarch.h: Regenerate.
4159         * gdbarch.sh (type_align): Extend comment.
4160         * gdbtypes.c (type_align): Add additional comments, always call
4161         gdbarch_type_align before applying the default rules.
4162         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4163         generic code will then apply a suitable default.
4164         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4165         types, return 0 for other types.
4166
4167 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4168
4169         * NEWS: Create a new section for the next release branch.
4170         Rename the section of the current branch, now that it has
4171         been cut.
4172
4173 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4174
4175         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4176         * version.in: Bump version to 8.3.50.DATE-git.
4177
4178 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4179
4180         * aix-thread.c (ptid_cmp): Remove unused variable.
4181         (get_signaled_thread): Likewise.
4182         (store_regs_user_thread): Likewise.
4183         (store_regs_kernel_thread): Likewise.
4184         (fetch_regs_kernel_thread): Remove shadowed variable.
4185
4186 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4187
4188         * features/riscv/32bit-cpu.xml: Add register numbers.
4189         * features/riscv/32bit-fpu.c: Regenerate.
4190         * features/riscv/32bit-fpu.xml: Add register numbers.
4191         * features/riscv/64bit-cpu.xml: Add register numbers.
4192         * features/riscv/64bit-fpu.c: Regenerate.
4193         * features/riscv/64bit-fpu.xml: Add register numbers.
4194
4195 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4196
4197         * NEWS: Mention two argument form of gdb.Value constructor.
4198         * python/py-value.c (convert_buffer_and_type_to_value): New
4199         function.
4200         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4201         Add support for handling an optional second argument.  Call
4202         convert_buffer_and_type_to_value as appropriate.
4203         * python/python-internal.h (Py_buffer_deleter): New struct.
4204         (Py_buffer_up): New typedef.
4205
4206 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4207
4208         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4209         instead of releasing ownership.
4210
4211 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4212
4213         * dwarf2read.c (open_and_init_dwp_file): Call
4214         elf_numsections instead of bfd_count_sections to initialize
4215         dwp_file->num_sections.
4216
4217 2019-02-25  Tom Tromey  <tromey@adacore.com>
4218
4219         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4220
4221 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4222
4223         * gcore.in: Add '--readnever' option when invoking GDB.
4224
4225 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4226
4227         * MAINTAINERS: Update my email address.
4228
4229 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4230
4231         * build-id.c (build_id_to_debug_bfd_1): New function.
4232         (build_id_to_debug_bfd): Look for separate debug file in
4233         sysroot.
4234
4235 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4236
4237         * gdbarch.sh: Update the copyright year range that is placed into
4238         generated files.
4239
4240 2019-02-22  Keith Seitz  <keiths@redhat.com>
4241
4242         PR symtab/23853
4243         * linespec.c (create_sals_line_offset): Search for the default
4244         symtab's filename instead of its fullname.
4245
4246 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4247
4248         * NEWS: Update style defaults.
4249
4250 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4251
4252         * main.c (captured_main_1): Disable styling in batch mode.
4253
4254 2019-02-20  Tom Tromey  <tom@tromey.com>
4255
4256         * symtab.c (symtab_symbol_info): Fix typos.
4257
4258 2019-02-20  Tom Tromey  <tromey@adacore.com>
4259
4260         * findcmd.c (_initialize_mem_search): Use upper case for
4261         metasyntactic variables.
4262
4263 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4264
4265         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4266         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4267
4268 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4269
4270         * top.h (source_file_name): Change to std::string.
4271         * top.c (source_file_name): Likewise.
4272         (command_line_input): Adjust.
4273         * cli/cli-script.c (script_from_file): Adjust.
4274
4275 2019-02-19  Tom Tromey  <tromey@adacore.com>
4276
4277         * ravenscar-thread.c
4278         (ravenscar_thread_target::update_thread_list): Don't call
4279         ada_build_task_list.
4280         * ada-lang.h (ada_build_task_list): Don't declare.
4281         * ada-tasks.c (struct ada_tasks_inferior_data)
4282         <task_list_valid_p>: Now bool.
4283         (read_known_tasks, ada_task_list_changed)
4284         (ada_tasks_invalidate_inferior_data): Update.
4285         (read_known_tasks_array): Return bool.
4286         (read_known_tasks_list): Likewise.
4287         (read_known_tasks): Return void.
4288         (ada_build_task_list): Now static.
4289
4290 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4291
4292         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4293         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4294
4295 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4296
4297         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4298         variant for ada_tasks_pspace_data_handle and
4299         ada_tasks_inferior_data_handle.
4300         (ada_tasks_pspace_data_cleanup): New function.
4301         (ada_tasks_inferior_data_cleanup): New function.
4302
4303 2019-02-17  Tom Tromey  <tom@tromey.com>
4304
4305         * macrotab.h (macro_source_fullname): Return a std::string.
4306         * macrotab.c (macro_include, check_for_redefinition)
4307         (macro_undef, macro_lookup_definition, foreach_macro)
4308         (foreach_macro_in_scope): Update.
4309         (macro_source_fullname): Return a std::string.
4310         * macrocmd.c (show_pp_source_pos): Update.
4311
4312 2019-02-17  Tom Tromey  <tom@tromey.com>
4313
4314         * macrocmd.c (show_pp_source_pos): Style the file names.
4315
4316 2019-02-17  Tom Tromey  <tom@tromey.com>
4317
4318         PR tui/24197:
4319         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4320
4321 2019-02-17  Tom Tromey  <tom@tromey.com>
4322
4323         * ada-lang.c (user_select_syms): Use filtered printing.
4324         * utils.c (wrap_style): New global.
4325         (desired_style): Remove.
4326         (emit_style_escape): Add stream parameter.
4327         (set_output_style, reset_terminal_style, prompt_for_continue):
4328         Update.
4329         (flush_wrap_buffer): Only flush gdb_stdout.
4330         (wrap_here): Set wrap_style.
4331         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4332         treat escape sequences as a character.  Change when wrap buffer is
4333         flushed.
4334         (fputs_styled): Do not set the output style when the default is
4335         requested.
4336         * ui-style.h (struct ui_file_style) <is_default>: New method.
4337         * source.c (print_source_lines_base): Emit escape sequences in one
4338         piece.
4339
4340 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4341
4342         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4343         integers and enumeration types.
4344
4345 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4346
4347         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4348         instead of lookup_symbol_in_language
4349         (do_exact_match): New function.
4350         (ada_get_symbol_name_matcher): Return do_exact_match when
4351         doing a verbatim match.
4352
4353 2019-02-15  Tom Tromey  <tromey@adacore.com>
4354
4355         * ravenscar-thread.c (ravenscar_thread_target::resume)
4356         (ravenscar_thread_target::wait): Special case wildcard requests.
4357
4358 2019-02-15  Tom Tromey  <tromey@adacore.com>
4359
4360         * ravenscar-thread.c (base_ptid): Remove.
4361         (struct ravenscar_thread_target) <close>: New method.
4362         <m_base_ptid>: New member.
4363         <update_inferior_ptid, active_task, task_is_currently_active,
4364         runtime_initialized>: Declare methods.
4365         <ravenscar_thread_target>: Add constructor.
4366         (ravenscar_thread_target::task_is_currently_active)
4367         (ravenscar_thread_target::update_inferior_ptid)
4368         (ravenscar_runtime_initialized): Rename.  Now methods.
4369         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4370         (ravenscar_thread_target::update_thread_list): Update.
4371         (ravenscar_thread_target::active_task): Now method.
4372         (ravenscar_thread_target::store_registers)
4373         (ravenscar_thread_target::prepare_to_store)
4374         (ravenscar_thread_target::prepare_to_store)
4375         (ravenscar_thread_target::mourn_inferior): Update.
4376         (ravenscar_inferior_created): Use "new" to create target.
4377         (ravenscar_thread_target::get_ada_task_ptid): Update.
4378         (_initialize_ravenscar): Don't initialize base_ptid.
4379         (ravenscar_ops): Remove global.
4380
4381 2019-02-15  Tom Tromey  <tromey@adacore.com>
4382
4383         * target.h (push_target): Declare new overload.
4384         * target.c (push_target): New overload, taking an rvalue reference.
4385         * remote.c (remote_target::open_1): Use push_target overload.
4386         * corelow.c (core_target_open): Use push_target overload.
4387
4388 2019-02-15  Tom Tromey  <tromey@adacore.com>
4389
4390         * ravenscar-thread.c (is_ravenscar_task)
4391         (ravenscar_task_is_currently_active): Return bool.
4392         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4393         (_initialize_ravenscar): Remove "(void)".
4394         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4395         Return bool.
4396
4397 2019-02-15  Tom Tromey  <tromey@adacore.com>
4398
4399         * ravenscar-thread.c (ravenscar_runtime_initializer)
4400         (has_ravenscar_runtime, get_running_thread_id)
4401         (ravenscar_thread_target::resume): Fix indentation.
4402
4403 2019-02-15  Tom Tromey  <tromey@adacore.com>
4404
4405         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4406         from ravenscar_arch_ops.
4407         (sparc_ravenscar_ops::fetch_registers)
4408         (sparc_ravenscar_ops::store_registers): Now methods.
4409         (sparc_ravenscar_prepare_to_store): Remove.
4410         (sparc_ravenscar_ops): Redefine.
4411         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4412         methods and destructor.  Remove members.
4413         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4414         (ravenscar_thread_target::store_registers)
4415         (ravenscar_thread_target::prepare_to_store): Update.
4416         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4417         Remove.
4418         (struct ppc_ravenscar_powerpc_ops): Derive from
4419         ravenscar_arch_ops.
4420         (ppc_ravenscar_powerpc_ops::fetch_registers)
4421         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4422         (ppc_ravenscar_powerpc_ops): Redefine.
4423         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4424         (ppc_ravenscar_e500_ops::fetch_registers)
4425         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4426         (ppc_ravenscar_e500_ops): Redefine.
4427         * aarch64-ravenscar-thread.c
4428         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4429         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4430         (aarch64_ravenscar_fetch_registers)
4431         (aarch64_ravenscar_store_registers): Now methods.
4432         (aarch64_ravenscar_ops): Redefine.
4433
4434 2019-02-15  Tom Tromey  <tromey@adacore.com>
4435
4436         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4437         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4438         (ravenscar_thread_target::stopped_by_watchpoint)
4439         (ravenscar_thread_target::stopped_data_address)
4440         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4441
4442 2019-02-15  Tom Tromey  <tromey@adacore.com>
4443
4444         * ravenscar-thread.c: Fix some typos.
4445
4446 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4447             Tom Tromey  <tromey@adacore.com>
4448
4449         * ada-lang.c (ada_exception_sal): Change addr_string to a
4450         std::string.
4451         (create_ada_exception_catchpoint): Update.
4452
4453 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4454             Tom Tromey  <tromey@adacore.com>
4455
4456         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4457         (bp_location_ops): Remove.
4458         (base_breakpoint_allocate_location): Update.
4459         (free_bp_location): Update.
4460         * ada-lang.c (class ada_catchpoint_location)
4461         <ada_catchpoint_location>: Remove ops parameter.
4462         (ada_catchpoint_location_dtor): Remove.
4463         (ada_catchpoint_location_ops): Remove.
4464         (allocate_location_exception): Update.
4465         * breakpoint.h (struct bp_location_ops): Remove.
4466         (class bp_location) <bp_location>: Remove bp_location_ops
4467         parameter.
4468         <~bp_location>: Add destructor.
4469         <ops>: Remove.
4470
4471 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4472             Pedro Alves  <palves@redhat.com>
4473
4474         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4475         'PATH_MAX'.
4476
4477 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4478             Samuel Thibault  <samuel.thibault@gnu.org>
4479             Thomas Schwinge  <thomas@codesourcery.com>
4480
4481         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4482         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4483
4484 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4485
4486         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4487         (check_empty): Use "const char *".
4488
4489         * gnu-nat.c (gnu_nat_target::detach): Instead of
4490         'detach_inferior (pid)' call
4491         'detach_inferior (find_inferior_pid (pid))'.
4492
4493         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4494         'nat/fork-inferior.o'.
4495         * gnu-nat.c: #include "nat/fork-inferior.h".
4496
4497         * gnu-nat.c (gnu_nat_target::detach): Instead of
4498         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4499         * gnu-nat.h: #include "inf-child.h".
4500         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4501         'i386_gnu_nat_target::fetch_registers'.
4502         (gnu_store_registers): Rename/move to
4503         'i386_gnu_nat_target::store_registers'.
4504
4505         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4506         * gnu-nat.h (mach_thread_info): New function.
4507         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4508
4509         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4510
4511 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4512
4513         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4514
4515 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4516
4517         * windows-nat.c (windows_add_thread): Add new parameter
4518         "main_thread_p" with default value set to false.  Update
4519         function documentation as well as all callers.
4520         (windows_delete_thread): Likewise.
4521         (fake_create_process): Update call to windows_add_thread.
4522         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4523         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4524         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4525         call to windows_delete_thread.
4526
4527 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4528
4529         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4530
4531 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4532
4533         * symfile.c (find_separate_debug_file): Use canonical path of
4534         sysroot with child_path instead of gdb_sysroot if it is valid.
4535
4536 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4537
4538         * symfile.c (find_separate_debug_file): Use child_path to
4539         determine if an object file is under a sysroot.
4540
4541 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4542
4543         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4544         unittests/child-path-selftests.c.
4545         * common/pathstuff.c (child_path): New function.
4546         * common/pathstuff.h (child_path): New prototype.
4547         * unittests/child-path-selftests.c: New file.
4548
4549 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4550
4551         * symfile.c (find_separate_debug_file): Look for separate debug
4552         files in debug directories under the sysroot.
4553
4554 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4555
4556         * symtab.h (struct minimal_symbol data_p): New const method.
4557         (struct minimal_symbol text_p): Likewise.
4558         * symtab.c (output_source_filename): Use file name style
4559         to print file name.
4560         (print_symbol_info): Likewise.
4561         (print_msymbol_info): Use address style to print addresses.
4562         Use function name style to print executable text symbols.
4563         (expand_symtab_containing_pc): Use data_p.
4564         (find_pc_sect_compunit_symtab): Likewise.
4565
4566 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4567
4568         * breakpoint.c (describe_other_breakpoints): Use address style
4569         to print addresses.
4570         (say_where): Likewise.
4571
4572 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4573
4574         * ada-typeprint.c (print_func_type): Print function name
4575         style to print function name.
4576         * c-typeprint.c (c_print_type_1): Likewise.
4577
4578 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4579
4580         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4581         for execve.
4582
4583 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4584
4585         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4586         type_stack.
4587
4588 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4589
4590         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4591         TYPE_CODE_REF types.
4592
4593 2019-02-08  Jim Wilson  <jimw@sifive.com>
4594
4595         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4596         (riscv_linux_fregset): New.
4597         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4598
4599 2019-02-07  Tom Tromey  <tom@tromey.com>
4600
4601         * thread.c (thread_cancel_execution_command): Update.
4602         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4603         methods.
4604         (struct thread_fsm_ops): Remove.
4605         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4606         (thread_fsm_should_stop, thread_fsm_return_value)
4607         (thread_fsm_set_finished, thread_fsm_finished_p)
4608         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4609         Don't declare.
4610         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4611         * infrun.c (clear_proceed_status_thread)
4612         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4613         (print_stop_event): Update.
4614         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4615         Add constructor.
4616         (step_command_fsm_ops): Remove.
4617         (new_step_command_fsm): Remove.
4618         (step_1): Update.
4619         (step_command_fsm::should_stop): Rename from
4620         step_command_fsm_should_stop.
4621         (step_command_fsm::clean_up): Rename from
4622         step_command_fsm_clean_up.
4623         (step_command_fsm::do_async_reply_reason): Rename from
4624         step_command_fsm_async_reply_reason.
4625         (struct until_next_fsm): Inherit from thread_fsm.  Add
4626         constructor.
4627         (until_next_fsm_ops): Remove.
4628         (new_until_next_fsm): Remove.
4629         (until_next_fsm::should_stop): Rename from
4630         until_next_fsm_should_stop.
4631         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4632         (until_next_fsm::do_async_reply_reason): Rename from
4633         until_next_fsm_async_reply_reason.
4634         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4635         constructor.  Change type of breakpoint.
4636         (finish_command_fsm_ops): Remove.
4637         (new_finish_command_fsm): Remove.
4638         (finish_command_fsm::should_stop): Rename from
4639         finish_command_fsm_should_stop.
4640         (finish_command_fsm::clean_up): Rename from
4641         finish_command_fsm_clean_up.
4642         (finish_command_fsm::return_value): Rename from
4643         finish_command_fsm_return_value.
4644         (finish_command_fsm::do_async_reply_reason): Rename from
4645         finish_command_fsm_async_reply_reason.
4646         (finish_command): Update.
4647         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4648         Add constructor.
4649         (call_thread_fsm_ops): Remove.
4650         (call_thread_fsm::call_thread_fsm): Rename from
4651         new_call_thread_fsm.
4652         (call_thread_fsm::should_stop): Rename from
4653         call_thread_fsm_should_stop.
4654         (call_thread_fsm::should_notify_stop): Rename from
4655         call_thread_fsm_should_notify_stop.
4656         (run_inferior_call, call_function_by_hand_dummy): Update.
4657         * cli/cli-interp.c (should_print_stop_to_console): Update.
4658         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4659         Add constructor.  Change type of location_breakpoint,
4660         caller_breakpoint.
4661         (until_break_fsm_ops): Remove.
4662         (new_until_break_fsm): Remove.
4663         (until_break_fsm::should_stop): Rename from
4664         until_break_fsm_should_stop.
4665         (until_break_fsm::clean_up): Rename from
4666         until_break_fsm_clean_up.
4667         (until_break_fsm::do_async_reply_reason): Rename from
4668         until_break_fsm_async_reply_reason.
4669         (until_break_command): Update.
4670         * thread-fsm.c: Remove.
4671         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4672
4673 2019-02-07  Tom Tromey  <tom@tromey.com>
4674
4675         * yy-remap.h: Add include guard.
4676         * xtensa-tdep.h: Add include guard.
4677         * xcoffread.h: Rename include guard.
4678         * varobj-iter.h: Add include guard.
4679         * tui/tui.h: Rename include guard.
4680         * tui/tui-winsource.h: Rename include guard.
4681         * tui/tui-wingeneral.h: Rename include guard.
4682         * tui/tui-windata.h: Rename include guard.
4683         * tui/tui-win.h: Rename include guard.
4684         * tui/tui-stack.h: Rename include guard.
4685         * tui/tui-source.h: Rename include guard.
4686         * tui/tui-regs.h: Rename include guard.
4687         * tui/tui-out.h: Rename include guard.
4688         * tui/tui-layout.h: Rename include guard.
4689         * tui/tui-io.h: Rename include guard.
4690         * tui/tui-hooks.h: Rename include guard.
4691         * tui/tui-file.h: Rename include guard.
4692         * tui/tui-disasm.h: Rename include guard.
4693         * tui/tui-data.h: Rename include guard.
4694         * tui/tui-command.h: Rename include guard.
4695         * tic6x-tdep.h: Add include guard.
4696         * target/waitstatus.h: Rename include guard.
4697         * target/wait.h: Rename include guard.
4698         * target/target.h: Rename include guard.
4699         * target/resume.h: Rename include guard.
4700         * target-float.h: Rename include guard.
4701         * stabsread.h: Add include guard.
4702         * rs6000-tdep.h: Add include guard.
4703         * riscv-fbsd-tdep.h: Add include guard.
4704         * regformats/regdef.h: Rename include guard.
4705         * record.h: Rename include guard.
4706         * python/python.h: Rename include guard.
4707         * python/python-internal.h: Rename include guard.
4708         * python/py-stopevent.h: Rename include guard.
4709         * python/py-ref.h: Rename include guard.
4710         * python/py-record.h: Rename include guard.
4711         * python/py-record-full.h: Rename include guard.
4712         * python/py-record-btrace.h: Rename include guard.
4713         * python/py-instruction.h: Rename include guard.
4714         * python/py-events.h: Rename include guard.
4715         * python/py-event.h: Rename include guard.
4716         * procfs.h: Add include guard.
4717         * proc-utils.h: Add include guard.
4718         * p-lang.h: Add include guard.
4719         * or1k-tdep.h: Rename include guard.
4720         * observable.h: Rename include guard.
4721         * nto-tdep.h: Rename include guard.
4722         * nat/x86-linux.h: Rename include guard.
4723         * nat/x86-linux-dregs.h: Rename include guard.
4724         * nat/x86-gcc-cpuid.h: Add include guard.
4725         * nat/x86-dregs.h: Rename include guard.
4726         * nat/x86-cpuid.h: Rename include guard.
4727         * nat/ppc-linux.h: Rename include guard.
4728         * nat/mips-linux-watch.h: Rename include guard.
4729         * nat/linux-waitpid.h: Rename include guard.
4730         * nat/linux-ptrace.h: Rename include guard.
4731         * nat/linux-procfs.h: Rename include guard.
4732         * nat/linux-osdata.h: Rename include guard.
4733         * nat/linux-nat.h: Rename include guard.
4734         * nat/linux-namespaces.h: Rename include guard.
4735         * nat/linux-btrace.h: Rename include guard.
4736         * nat/glibc_thread_db.h: Rename include guard.
4737         * nat/gdb_thread_db.h: Rename include guard.
4738         * nat/gdb_ptrace.h: Rename include guard.
4739         * nat/fork-inferior.h: Rename include guard.
4740         * nat/amd64-linux-siginfo.h: Rename include guard.
4741         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4742         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4743         * nat/aarch64-linux.h: Rename include guard.
4744         * nat/aarch64-linux-hw-point.h: Rename include guard.
4745         * mn10300-tdep.h: Add include guard.
4746         * mips-linux-tdep.h: Add include guard.
4747         * mi/mi-parse.h: Rename include guard.
4748         * mi/mi-out.h: Rename include guard.
4749         * mi/mi-main.h: Rename include guard.
4750         * mi/mi-interp.h: Rename include guard.
4751         * mi/mi-getopt.h: Rename include guard.
4752         * mi/mi-console.h: Rename include guard.
4753         * mi/mi-common.h: Rename include guard.
4754         * mi/mi-cmds.h: Rename include guard.
4755         * mi/mi-cmd-break.h: Rename include guard.
4756         * m2-lang.h: Add include guard.
4757         * location.h: Rename include guard.
4758         * linux-record.h: Rename include guard.
4759         * linux-nat.h: Add include guard.
4760         * linux-fork.h: Add include guard.
4761         * i386-darwin-tdep.h: Rename include guard.
4762         * hppa-linux-offsets.h: Add include guard.
4763         * guile/guile.h: Rename include guard.
4764         * guile/guile-internal.h: Rename include guard.
4765         * gnu-nat.h: Rename include guard.
4766         * gdb-stabs.h: Rename include guard.
4767         * frv-tdep.h: Add include guard.
4768         * f-lang.h: Add include guard.
4769         * event-loop.h: Add include guard.
4770         * darwin-nat.h: Rename include guard.
4771         * cp-abi.h: Rename include guard.
4772         * config/sparc/nm-sol2.h: Rename include guard.
4773         * config/nm-nto.h: Rename include guard.
4774         * config/nm-linux.h: Add include guard.
4775         * config/i386/nm-i386gnu.h: Rename include guard.
4776         * config/djgpp/nl_types.h: Rename include guard.
4777         * config/djgpp/langinfo.h: Rename include guard.
4778         * compile/gcc-cp-plugin.h: Add include guard.
4779         * compile/gcc-c-plugin.h: Add include guard.
4780         * compile/compile.h: Rename include guard.
4781         * compile/compile-object-run.h: Rename include guard.
4782         * compile/compile-object-load.h: Rename include guard.
4783         * compile/compile-internal.h: Rename include guard.
4784         * compile/compile-cplus.h: Rename include guard.
4785         * compile/compile-c.h: Rename include guard.
4786         * common/xml-utils.h: Rename include guard.
4787         * common/x86-xstate.h: Rename include guard.
4788         * common/version.h: Rename include guard.
4789         * common/vec.h: Rename include guard.
4790         * common/tdesc.h: Rename include guard.
4791         * common/selftest.h: Rename include guard.
4792         * common/scoped_restore.h: Rename include guard.
4793         * common/scoped_mmap.h: Rename include guard.
4794         * common/scoped_fd.h: Rename include guard.
4795         * common/safe-iterator.h: Rename include guard.
4796         * common/run-time-clock.h: Rename include guard.
4797         * common/refcounted-object.h: Rename include guard.
4798         * common/queue.h: Rename include guard.
4799         * common/ptid.h: Rename include guard.
4800         * common/print-utils.h: Rename include guard.
4801         * common/preprocessor.h: Rename include guard.
4802         * common/pathstuff.h: Rename include guard.
4803         * common/observable.h: Rename include guard.
4804         * common/netstuff.h: Rename include guard.
4805         * common/job-control.h: Rename include guard.
4806         * common/host-defs.h: Rename include guard.
4807         * common/gdb_wait.h: Rename include guard.
4808         * common/gdb_vecs.h: Rename include guard.
4809         * common/gdb_unlinker.h: Rename include guard.
4810         * common/gdb_unique_ptr.h: Rename include guard.
4811         * common/gdb_tilde_expand.h: Rename include guard.
4812         * common/gdb_sys_time.h: Rename include guard.
4813         * common/gdb_string_view.h: Rename include guard.
4814         * common/gdb_splay_tree.h: Rename include guard.
4815         * common/gdb_setjmp.h: Rename include guard.
4816         * common/gdb_ref_ptr.h: Rename include guard.
4817         * common/gdb_optional.h: Rename include guard.
4818         * common/gdb_locale.h: Rename include guard.
4819         * common/gdb_assert.h: Rename include guard.
4820         * common/filtered-iterator.h: Rename include guard.
4821         * common/filestuff.h: Rename include guard.
4822         * common/fileio.h: Rename include guard.
4823         * common/environ.h: Rename include guard.
4824         * common/common-utils.h: Rename include guard.
4825         * common/common-types.h: Rename include guard.
4826         * common/common-regcache.h: Rename include guard.
4827         * common/common-inferior.h: Rename include guard.
4828         * common/common-gdbthread.h: Rename include guard.
4829         * common/common-exceptions.h: Rename include guard.
4830         * common/common-defs.h: Rename include guard.
4831         * common/common-debug.h: Rename include guard.
4832         * common/cleanups.h: Rename include guard.
4833         * common/buffer.h: Rename include guard.
4834         * common/btrace-common.h: Rename include guard.
4835         * common/break-common.h: Rename include guard.
4836         * cli/cli-utils.h: Rename include guard.
4837         * cli/cli-style.h: Rename include guard.
4838         * cli/cli-setshow.h: Rename include guard.
4839         * cli/cli-script.h: Rename include guard.
4840         * cli/cli-interp.h: Rename include guard.
4841         * cli/cli-decode.h: Rename include guard.
4842         * cli/cli-cmds.h: Rename include guard.
4843         * charset-list.h: Add include guard.
4844         * buildsym-legacy.h: Rename include guard.
4845         * bfin-tdep.h: Add include guard.
4846         * ax.h: Rename include guard.
4847         * arm-linux-tdep.h: Add include guard.
4848         * arm-fbsd-tdep.h: Add include guard.
4849         * arch/xtensa.h: Rename include guard.
4850         * arch/tic6x.h: Add include guard.
4851         * arch/i386.h: Add include guard.
4852         * arch/arm.h: Rename include guard.
4853         * arch/arm-linux.h: Rename include guard.
4854         * arch/arm-get-next-pcs.h: Rename include guard.
4855         * arch/amd64.h: Add include guard.
4856         * arch/aarch64-insn.h: Rename include guard.
4857         * arch-utils.h: Rename include guard.
4858         * annotate.h: Add include guard.
4859         * amd64-darwin-tdep.h: Rename include guard.
4860         * aarch64-linux-tdep.h: Add include guard.
4861         * aarch64-fbsd-tdep.h: Add include guard.
4862         * aarch32-linux-nat.h: Add include guard.
4863
4864 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4865
4866         * macrotab.c (macro_define_internal): New function that
4867         factorizes macro_define_object_internal and macro_define_function
4868         code.
4869         (macro_define_object_internal): Use macro_define_internal.
4870         (macro_define_function): Likewise.
4871
4872 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4873
4874         * macrocmd.c (extract_identifier): Return
4875         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4876         callers.
4877
4878 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4879
4880         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4881
4882 2019-02-05  Tom Tromey  <tom@tromey.com>
4883
4884         * target.c (target_stack::unpush): Move assertion earlier.
4885
4886 2019-01-30  Tom Tromey  <tom@tromey.com>
4887
4888         PR python/23615:
4889         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4890         (gdbpy_parse_and_eval): Likewise.
4891         * python/python-internal.h (gdbpy_allow_threads): New class.
4892
4893 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4894
4895         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4896         (aarch64_fbsd_fpregmap): Move earlier.
4897         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4898         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4899         instead of individual calls to trad_frame_set_reg_addr.
4900         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4901         earlier.
4902         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4903         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4904         instead of individual calls to trad_frame_set_reg_addr.
4905
4906 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4907
4908         * CONTRIBUTE: Replace contribution list with wiki link.
4909
4910 2019-01-25  Tom Tromey  <tom@tromey.com>
4911
4912         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4913
4914 2019-01-25  Tom Tromey  <tom@tromey.com>
4915
4916         * xtensa-linux-nat.c: Fix common/ includes.
4917         * xml-support.h: Fix common/ includes.
4918         * xml-support.c: Fix common/ includes.
4919         * x86-linux-nat.c: Fix common/ includes.
4920         * windows-nat.c: Fix common/ includes.
4921         * varobj.h: Fix common/ includes.
4922         * varobj.c: Fix common/ includes.
4923         * value.c: Fix common/ includes.
4924         * valops.c: Fix common/ includes.
4925         * utils.c: Fix common/ includes.
4926         * unittests/xml-utils-selftests.c: Fix common/ includes.
4927         * unittests/utils-selftests.c: Fix common/ includes.
4928         * unittests/unpack-selftests.c: Fix common/ includes.
4929         * unittests/tracepoint-selftests.c: Fix common/ includes.
4930         * unittests/style-selftests.c: Fix common/ includes.
4931         * unittests/string_view-selftests.c: Fix common/ includes.
4932         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4933         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4934         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4935         * unittests/rsp-low-selftests.c: Fix common/ includes.
4936         * unittests/parse-connection-spec-selftests.c: Fix common/
4937         includes.
4938         * unittests/optional-selftests.c: Fix common/ includes.
4939         * unittests/offset-type-selftests.c: Fix common/ includes.
4940         * unittests/observable-selftests.c: Fix common/ includes.
4941         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4942         * unittests/memrange-selftests.c: Fix common/ includes.
4943         * unittests/memory-map-selftests.c: Fix common/ includes.
4944         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4945         * unittests/function-view-selftests.c: Fix common/ includes.
4946         * unittests/environ-selftests.c: Fix common/ includes.
4947         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4948         * unittests/common-utils-selftests.c: Fix common/ includes.
4949         * unittests/cli-utils-selftests.c: Fix common/ includes.
4950         * unittests/array-view-selftests.c: Fix common/ includes.
4951         * ui-file.c: Fix common/ includes.
4952         * tui/tui-io.c: Fix common/ includes.
4953         * tracepoint.h: Fix common/ includes.
4954         * tracepoint.c: Fix common/ includes.
4955         * tracefile-tfile.c: Fix common/ includes.
4956         * top.h: Fix common/ includes.
4957         * top.c: Fix common/ includes.
4958         * thread.c: Fix common/ includes.
4959         * target/waitstatus.h: Fix common/ includes.
4960         * target/waitstatus.c: Fix common/ includes.
4961         * target.h: Fix common/ includes.
4962         * target.c: Fix common/ includes.
4963         * target-memory.c: Fix common/ includes.
4964         * target-descriptions.c: Fix common/ includes.
4965         * symtab.h: Fix common/ includes.
4966         * symfile.c: Fix common/ includes.
4967         * stap-probe.c: Fix common/ includes.
4968         * spu-linux-nat.c: Fix common/ includes.
4969         * sparc-nat.c: Fix common/ includes.
4970         * source.c: Fix common/ includes.
4971         * solib.c: Fix common/ includes.
4972         * solib-target.c: Fix common/ includes.
4973         * ser-unix.c: Fix common/ includes.
4974         * ser-tcp.c: Fix common/ includes.
4975         * ser-pipe.c: Fix common/ includes.
4976         * ser-base.c: Fix common/ includes.
4977         * selftest-arch.c: Fix common/ includes.
4978         * s12z-tdep.c: Fix common/ includes.
4979         * rust-exp.y: Fix common/ includes.
4980         * rs6000-aix-tdep.c: Fix common/ includes.
4981         * riscv-tdep.c: Fix common/ includes.
4982         * remote.c: Fix common/ includes.
4983         * remote-notif.h: Fix common/ includes.
4984         * remote-fileio.h: Fix common/ includes.
4985         * remote-fileio.c: Fix common/ includes.
4986         * regcache.h: Fix common/ includes.
4987         * regcache.c: Fix common/ includes.
4988         * record-btrace.c: Fix common/ includes.
4989         * python/python.c: Fix common/ includes.
4990         * python/py-type.c: Fix common/ includes.
4991         * python/py-inferior.c: Fix common/ includes.
4992         * progspace.h: Fix common/ includes.
4993         * producer.c: Fix common/ includes.
4994         * procfs.c: Fix common/ includes.
4995         * proc-api.c: Fix common/ includes.
4996         * printcmd.c: Fix common/ includes.
4997         * ppc-linux-nat.c: Fix common/ includes.
4998         * parser-defs.h: Fix common/ includes.
4999         * osdata.c: Fix common/ includes.
5000         * obsd-nat.c: Fix common/ includes.
5001         * nat/x86-linux.c: Fix common/ includes.
5002         * nat/x86-linux-dregs.c: Fix common/ includes.
5003         * nat/x86-dregs.h: Fix common/ includes.
5004         * nat/x86-dregs.c: Fix common/ includes.
5005         * nat/ppc-linux.c: Fix common/ includes.
5006         * nat/mips-linux-watch.h: Fix common/ includes.
5007         * nat/mips-linux-watch.c: Fix common/ includes.
5008         * nat/linux-waitpid.c: Fix common/ includes.
5009         * nat/linux-ptrace.h: Fix common/ includes.
5010         * nat/linux-ptrace.c: Fix common/ includes.
5011         * nat/linux-procfs.c: Fix common/ includes.
5012         * nat/linux-personality.c: Fix common/ includes.
5013         * nat/linux-osdata.c: Fix common/ includes.
5014         * nat/linux-namespaces.c: Fix common/ includes.
5015         * nat/linux-btrace.h: Fix common/ includes.
5016         * nat/linux-btrace.c: Fix common/ includes.
5017         * nat/fork-inferior.c: Fix common/ includes.
5018         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5019         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5020         * nat/aarch64-linux.c: Fix common/ includes.
5021         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5022         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5023         * namespace.h: Fix common/ includes.
5024         * mips-linux-tdep.c: Fix common/ includes.
5025         * minsyms.c: Fix common/ includes.
5026         * mi/mi-parse.h: Fix common/ includes.
5027         * mi/mi-main.c: Fix common/ includes.
5028         * mi/mi-cmd-env.c: Fix common/ includes.
5029         * memrange.h: Fix common/ includes.
5030         * memattr.c: Fix common/ includes.
5031         * maint.h: Fix common/ includes.
5032         * maint.c: Fix common/ includes.
5033         * main.c: Fix common/ includes.
5034         * machoread.c: Fix common/ includes.
5035         * location.c: Fix common/ includes.
5036         * linux-thread-db.c: Fix common/ includes.
5037         * linux-nat.c: Fix common/ includes.
5038         * linux-fork.c: Fix common/ includes.
5039         * inline-frame.c: Fix common/ includes.
5040         * infrun.c: Fix common/ includes.
5041         * inflow.c: Fix common/ includes.
5042         * inferior.h: Fix common/ includes.
5043         * inferior.c: Fix common/ includes.
5044         * infcmd.c: Fix common/ includes.
5045         * inf-ptrace.c: Fix common/ includes.
5046         * inf-child.c: Fix common/ includes.
5047         * ia64-linux-nat.c: Fix common/ includes.
5048         * i387-tdep.c: Fix common/ includes.
5049         * i386-tdep.c: Fix common/ includes.
5050         * i386-linux-tdep.c: Fix common/ includes.
5051         * i386-linux-nat.c: Fix common/ includes.
5052         * i386-go32-tdep.c: Fix common/ includes.
5053         * i386-fbsd-tdep.c: Fix common/ includes.
5054         * i386-fbsd-nat.c: Fix common/ includes.
5055         * guile/scm-type.c: Fix common/ includes.
5056         * guile/guile.c: Fix common/ includes.
5057         * go32-nat.c: Fix common/ includes.
5058         * gnu-nat.c: Fix common/ includes.
5059         * gdbthread.h: Fix common/ includes.
5060         * gdbarch-selftests.c: Fix common/ includes.
5061         * gdb_usleep.c: Fix common/ includes.
5062         * gdb_select.h: Fix common/ includes.
5063         * gdb_bfd.c: Fix common/ includes.
5064         * gcore.c: Fix common/ includes.
5065         * fork-child.c: Fix common/ includes.
5066         * findvar.c: Fix common/ includes.
5067         * fbsd-nat.c: Fix common/ includes.
5068         * event-top.c: Fix common/ includes.
5069         * event-loop.c: Fix common/ includes.
5070         * dwarf2read.c: Fix common/ includes.
5071         * dwarf2loc.c: Fix common/ includes.
5072         * dwarf2-frame.c: Fix common/ includes.
5073         * dwarf-index-cache.c: Fix common/ includes.
5074         * dtrace-probe.c: Fix common/ includes.
5075         * disasm-selftests.c: Fix common/ includes.
5076         * defs.h: Fix common/ includes.
5077         * csky-tdep.c: Fix common/ includes.
5078         * cp-valprint.c: Fix common/ includes.
5079         * cp-support.h: Fix common/ includes.
5080         * cp-support.c: Fix common/ includes.
5081         * corelow.c: Fix common/ includes.
5082         * completer.h: Fix common/ includes.
5083         * completer.c: Fix common/ includes.
5084         * compile/compile.c: Fix common/ includes.
5085         * compile/compile-loc2c.c: Fix common/ includes.
5086         * compile/compile-cplus-types.c: Fix common/ includes.
5087         * compile/compile-cplus-symbols.c: Fix common/ includes.
5088         * command.h: Fix common/ includes.
5089         * cli/cli-dump.c: Fix common/ includes.
5090         * cli/cli-cmds.c: Fix common/ includes.
5091         * charset.c: Fix common/ includes.
5092         * build-id.c: Fix common/ includes.
5093         * btrace.h: Fix common/ includes.
5094         * btrace.c: Fix common/ includes.
5095         * breakpoint.h: Fix common/ includes.
5096         * breakpoint.c: Fix common/ includes.
5097         * ax.h:
5098         (enum agent_op): Fix common/ includes.
5099         * ax-general.c (struct aop_map): Fix common/ includes.
5100         * ax-gdb.c: Fix common/ includes.
5101         * auxv.c: Fix common/ includes.
5102         * auto-load.c: Fix common/ includes.
5103         * arm-tdep.c: Fix common/ includes.
5104         * arch/riscv.c: Fix common/ includes.
5105         * arch/ppc-linux-common.c: Fix common/ includes.
5106         * arch/i386.c: Fix common/ includes.
5107         * arch/arm.c: Fix common/ includes.
5108         * arch/arm-linux.c: Fix common/ includes.
5109         * arch/arm-get-next-pcs.c: Fix common/ includes.
5110         * arch/amd64.c: Fix common/ includes.
5111         * arch/aarch64.c: Fix common/ includes.
5112         * arch/aarch64-insn.c: Fix common/ includes.
5113         * arch-utils.c: Fix common/ includes.
5114         * amd64-windows-tdep.c: Fix common/ includes.
5115         * amd64-tdep.c: Fix common/ includes.
5116         * amd64-sol2-tdep.c: Fix common/ includes.
5117         * amd64-obsd-tdep.c: Fix common/ includes.
5118         * amd64-nbsd-tdep.c: Fix common/ includes.
5119         * amd64-linux-tdep.c: Fix common/ includes.
5120         * amd64-linux-nat.c: Fix common/ includes.
5121         * amd64-fbsd-tdep.c: Fix common/ includes.
5122         * amd64-fbsd-nat.c: Fix common/ includes.
5123         * amd64-dicos-tdep.c: Fix common/ includes.
5124         * amd64-darwin-tdep.c: Fix common/ includes.
5125         * agent.c: Fix common/ includes.
5126         * ada-lang.h: Fix common/ includes.
5127         * ada-lang.c: Fix common/ includes.
5128         * aarch64-tdep.c: Fix common/ includes.
5129
5130 2019-01-25  Tom Tromey  <tom@tromey.com>
5131
5132         * common/create-version.sh: Use common/version.h.
5133
5134 2019-01-24  Pedro Alves  <palves@redhat.com>
5135
5136         * infrun.c (signal_stop, signal_print, signal_program)
5137         (signal_catch, signal_pass): Now arrays instead of pointers.
5138         (update_signals_program_target, do_target_resume)
5139         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5140         * linux-nat.c (linux_nat_target::pass_signals)
5141         (linux_nat_target::create_inferior, linux_nat_target::attach):
5142         Adjust.
5143         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5144         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5145         * procfs.c (procfs_target::pass_signals): Adjust.
5146         * record-full.c (record_full_target::resume): Adjust.
5147         * remote.c (remote_target::pass_signals)
5148         (remote_target::program_signals): Adjust.
5149         * target-debug.h (target_debug_print_signals): Now takes a
5150         gdb::array_view as parameter.  Adjust.
5151         * target.h (target_ops) <pass_signals, program_signals>: Replace
5152         pointer and length parameters with gdb::array_view.
5153         (target_pass_signals, target_program_signals): Likewise.
5154         * target-delegates.c: Regenerate.
5155
5156 2019-01-24  Pedro Alves  <palves@redhat.com>
5157
5158         * common/forward-scope-exit.h
5159         (forward_scope_exit::forward_scope_exit): Pass arguments to
5160         m_bind_function directly, instead of creating a std::bind and
5161         copying that.
5162
5163 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5164
5165         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5166         for static members.
5167         (pass_in_v_vfp_candidate): Likewise.
5168
5169 2019-01-23  Tom Tromey  <tom@tromey.com>
5170             Pedro Alves  <palves@redhat.com>
5171
5172         * regcache.c (class regcache_invalidator): Remove.
5173         (regcache::raw_write): Use make_scope_exit.
5174
5175 2019-01-23  Tom Tromey  <tom@tromey.com>
5176
5177         * ui-out.h (class ui_out_emit_type): Update comment.
5178
5179 2019-01-23  Tom Tromey  <tom@tromey.com>
5180
5181         * infrun.c (fetch_inferior_event): Update comment.
5182
5183 2019-01-23  Tom Tromey  <tom@tromey.com>
5184             Pedro Alves  <palves@redhat.com>
5185
5186         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5187         parameter.
5188         (fetch_inferior_event): Use SCOPE_EXIT.
5189
5190
5191 2019-01-23  Tom Tromey  <tom@tromey.com>
5192             Pedro Alves  <palves@redhat.com>
5193
5194         * infrun.c (disable_thread_events): Delete.
5195         (stop_all_threads): Use SCOPE_EXIT.
5196
5197 2019-01-23  Tom Tromey  <tom@tromey.com>
5198             Pedro Alves  <palves@redhat.com>
5199
5200         * symfile.c: Include forward-scope-exit.h.
5201         (clear_symtab_users_cleanup): Replace forward declaration with
5202         a FORWARD_SCOPE_EXIT.
5203         (syms_from_objfile_1): Use the forward_scope_exit and
5204         gdb::optional instead of cleanup_function.
5205         (reread_symbols): Use the forward_scope_exit instead of
5206         cleanup_function.
5207         (clear_symtab_users_cleanup): Remove function.
5208
5209 2019-01-23  Tom Tromey  <tom@tromey.com>
5210             Pedro Alves  <palves@redhat.com>
5211
5212         * linux-nat.c: Include scope-exit.h.
5213         (cleanup_target_stop): Remove.
5214         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5215         SCOPE_EXIT.
5216
5217 2019-01-23  Tom Tromey  <tom@tromey.com>
5218             Pedro Alves  <palves@redhat.com>
5219
5220         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5221         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5222
5223 2019-01-23  Tom Tromey  <tom@tromey.com>
5224             Andrew Burgess  <andrew.burgess@embecosm.com>
5225             Pedro Alves  <palves@redhat.com>
5226
5227         * infrun.c (fetch_inferior_event): Use scope_exit.
5228         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5229         * top.c (execute_command): Use scope_exit.
5230         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5231         * utils.c (do_bpstat_clear_actions_cleanup)
5232         (make_bpstat_clear_actions_cleanup): Remove.
5233
5234 2019-01-23  Tom Tromey  <tom@tromey.com>
5235             Pedro Alves  <palves@redhat.com>
5236
5237         * infrun.c: Include "common/scope-exit.h"
5238         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5239         (wait_for_inferior): Use SCOPE_EXIT.
5240         (fetch_inferior_event): Use scope_exit.
5241
5242 2019-01-23  Tom Tromey  <tom@tromey.com>
5243             Pedro Alves  <palves@redhat.com>
5244
5245         * breakpoint.c (create_breakpoint): Remove cleanup.
5246
5247 2019-01-23  Tom Tromey  <tom@tromey.com>
5248             Andrew Burgess  <andrew.burgess@embecosm.com>
5249             Pedro Alves  <palves@redhat.com>
5250
5251 2019-01-23  Pedro Alves  <palves@redhat.com>
5252
5253         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5254
5255 2019-01-23  Pedro Alves  <palves@redhat.com>
5256             Andrew Burgess  <andrew.burgess@embecosm.com>
5257
5258         * gdbthread.h: Include "common/forward-scope-exit.h".
5259         (scoped_finish_thread_state): Redefine custom class in terms of
5260         forward_scope_exit.
5261
5262 2019-01-23  Pedro Alves  <palves@redhat.com>
5263             Andrew Burgess  <andrew.burgess@embecosm.com>
5264
5265         * common/forward-scope-exit.h: New file.
5266
5267 2019-01-23  Pedro Alves  <palves@redhat.com>
5268             Andrew Burgess  <andrew.burgess@embecosm.com>
5269             Tom Tromey  <tom@tromey.com>
5270
5271         * common/scope-exit.h: New file.
5272
5273 2019-01-23  Pedro Alves  <palves@redhat.com>
5274
5275         * common/preprocessor.h (ESC): Rename to ...
5276         (ESC_PARENS): ... this.
5277         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5278         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5279
5280 2019-01-23  Tom Tromey  <tom@tromey.com>
5281
5282         * language.h (class scoped_switch_to_sym_language_if_auto):
5283         Initialize m_lang in both cases.
5284
5285 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5286
5287         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5288         with XCNEW.
5289
5290 2019-01-22  Tom Tromey  <tom@tromey.com>
5291
5292         * corelow.c: Do not include sys/file.h.
5293
5294 2019-01-22  Tom Tromey  <tom@tromey.com>
5295
5296         * tui/tui-wingeneral.h: Include gdb_curses.h.
5297
5298 2019-01-22  Tom Tromey  <tom@tromey.com>
5299
5300         * source-cache.h (class source_cache) <get_source_lines,
5301         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5302
5303 2019-01-22  Tom Tromey  <tom@tromey.com>
5304
5305         * remote-fileio.h (struct remote_target): Declare.
5306
5307 2019-01-22  Tom Tromey  <tom@tromey.com>
5308
5309         * python/py-arch.c: Do not include py-ref.h.
5310         * python/py-bpevent.c: Do not include py-ref.h.
5311         * python/py-cmd.c: Do not include py-ref.h.
5312         * python/py-continueevent.c: Do not include py-ref.h.
5313         * python/py-event.h: Do not include py-ref.h.
5314         * python/py-evtregistry.c: Do not include py-ref.h.
5315         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5316         * python/py-frame.c: Do not include py-ref.h.
5317         * python/py-framefilter.c: Do not include py-ref.h.
5318         * python/py-function.c: Do not include py-ref.h.
5319         * python/py-infevents.c: Do not include py-ref.h.
5320         * python/py-linetable.c: Do not include py-ref.h.
5321         * python/py-objfile.c: Do not include py-ref.h.
5322         * python/py-param.c: Do not include py-ref.h.
5323         * python/py-prettyprint.c: Do not include py-ref.h.
5324         * python/py-progspace.c: Do not include py-ref.h.
5325         * python/py-symbol.c: Do not include py-ref.h.
5326         * python/py-symtab.c: Do not include py-ref.h.
5327         * python/py-type.c: Do not include py-ref.h.
5328         * python/py-unwind.c: Do not include py-ref.h.
5329         * python/py-utils.c: Do not include py-ref.h.
5330         * python/py-value.c: Do not include py-ref.h.
5331         * python/py-varobj.c: Do not include py-ref.h.
5332         * python/py-xmethods.c: Do not include py-ref.h.
5333         * python/python.c: Do not include py-ref.h.
5334         * varobj.c: Do not include py-ref.h.
5335
5336 2019-01-22  Tom Tromey  <tom@tromey.com>
5337
5338         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5339         keyword for bcache.
5340
5341 2019-01-22  Tom Tromey  <tom@tromey.com>
5342
5343         * compile/compile-cplus-types.c: Remove a comment by #include.
5344
5345 2019-01-22  Tom Tromey  <tom@tromey.com>
5346
5347         * compile/gcc-c-plugin.h: Include compile-internal.h.
5348
5349 2019-01-22  Tom Tromey  <tom@tromey.com>
5350
5351         * stabsread.c (EXTERN): Do not define.
5352         (symnum, next_symbol_text_func, processing_gcc_compilation)
5353         (within_function, global_sym_chain, global_stabs)
5354         (previous_stab_code, this_object_header_files)
5355         (n_this_object_header_files)
5356         (n_allocated_this_object_header_files): Define.
5357         * stabsread.h (EXTERN): Never define.  Use "extern".
5358
5359 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5360
5361         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5362         history_value.
5363
5364 2019-01-21  Tom Tromey  <tom@tromey.com>
5365
5366         * ui-out.c: Fix includes.
5367         * tui/tui-source.c: Fix includes.
5368         * target.c: Fix includes.
5369         * remote.c: Fix includes.
5370         * regcache.c: Fix includes.
5371         * python/py-block.c: Fix includes.
5372         * printcmd.c: Fix includes.
5373         * or1k-tdep.c: Fix includes.
5374         * mi/mi-main.c: Fix includes.
5375         * m32r-tdep.c: Fix includes.
5376         * csky-tdep.c: Fix includes.
5377         * compile/compile-cplus-types.c: Fix includes.
5378         * cli/cli-interp.c: Fix includes.
5379
5380 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5381
5382         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5383         for padding.
5384
5385 2019-01-16  Tom Tromey  <tom@tromey.com>
5386
5387         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5388         earlier.
5389         (struct objfile) <msymbols_range>: Move from top level.
5390         <msymbols>: New method.
5391         (class objfile_msymbols): Remove.
5392         * symtab.c (default_collect_symbol_completion_matches_break_on):
5393         Update.
5394         * symmisc.c (dump_msymbols): Update.
5395         * stabsread.c (scan_file_globals): Update.
5396         * objc-lang.c (info_selectors_command, info_classes_command)
5397         (find_methods): Update.
5398         * minsyms.c (find_solib_trampoline_target): Update.
5399         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5400         * coffread.c (coff_symfile_read): Update.
5401         * ada-lang.c (ada_lookup_simple_minsym)
5402         (ada_collect_symbol_completion_matches): Update.
5403
5404 2019-01-16  Tom Tromey  <tom@tromey.com>
5405
5406         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5407         type.  Remove no-argument constructor.
5408         <iterator::operator++>: Simplify.
5409         <begin>: Update.
5410         <end>: Use minimal_symbol_count.
5411
5412 2019-01-16  Tom Tromey  <tom@tromey.com>
5413
5414         * objfiles.h (struct objfile) <psymtabs>: New method.
5415         (class objfile_psymtabs): Remove.
5416         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5417         typedef.
5418         <range>: New method.
5419         (require_partial_symbols): Change return type.
5420         * psymtab.c (require_partial_symbols)
5421         (psym_expand_symtabs_matching): Update.
5422         * mdebugread.c (parse_partial_symbols): Update.
5423         * dbxread.c (dbx_end_psymtab): Update.
5424
5425 2019-01-15  Tom Tromey  <tom@tromey.com>
5426
5427         * symtab.c (lookup_objfile_from_block)
5428         (lookup_symbol_in_objfile_symtabs)
5429         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5430         (find_line_symtab, info_sources_command)
5431         (default_collect_symbol_completion_matches_break_on)
5432         (make_source_files_completion_list): Update.
5433         * symmisc.c (print_objfile_statistics, dump_objfile)
5434         (maintenance_print_symbols, maintenance_info_symtabs)
5435         (maintenance_check_symtabs, maintenance_info_line_tables):
5436         Update.
5437         * source.c (select_source_symtab)
5438         (forget_cached_source_info_for_objfile): Update.
5439         * objfiles.h (class objfile_compunits): Remove.
5440         (struct objfile) <compunits_range>: New typedef.
5441         (compunits): New method.
5442         * objfiles.c (objfile_relocate1): Update.
5443         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5444         * maint.c (count_symtabs_and_blocks): Update.
5445         * linespec.c (iterate_over_all_matching_symtabs): Update.
5446         * cp-support.c (add_symbol_overload_list_qualified): Update.
5447         * coffread.c (coff_symtab_read): Update.
5448         * ada-lang.c (add_nonlocal_symbols)
5449         (ada_collect_symbol_completion_matches)
5450         (ada_add_global_exceptions): Update.
5451
5452 2019-01-15  Tom Tromey  <tom@tromey.com>
5453
5454         * progspace.h (program_space) <objfiles_safe_range>: New
5455         typedef.
5456         <objfiles_safe>: New method.
5457         * objfiles.h (class all_objfiles_safe): Remove.
5458         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5459         * jit.c (jit_inferior_exit_hook): Update.
5460
5461 2019-01-17  Tom Tromey  <tom@tromey.com>
5462
5463         * progspace.h (program_space) <objfiles_range>: New typedef.
5464         <objfiles>: New method.
5465         <objfiles_head>: Rename from objfiles.
5466         (object_files): Update.
5467         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5468         * guile/scm-pretty-print.c
5469         (ppscm_find_pretty_printer_from_objfiles): Update.
5470         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5471         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5472         Update.
5473         * python/py-progspace.c (pspy_get_objfiles): Update.
5474         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5475         Update.
5476         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5477         (objfpy_lookup_objfile_by_build_id): Update.
5478         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5479         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5480         Update.
5481         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5482         (expand_symtab_containing_pc, lookup_objfile_from_block)
5483         (lookup_static_symbol, basic_lookup_transparent_type)
5484         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5485         (find_line_symtab, info_sources_command)
5486         (default_collect_symbol_completion_matches_break_on)
5487         (make_source_files_completion_list, find_main_name): Update.
5488         * symmisc.c (print_symbol_bcache_statistics)
5489         (print_objfile_statistics, maintenance_print_symbols)
5490         (maintenance_print_msymbols, maintenance_print_objfiles)
5491         (maintenance_info_symtabs, maintenance_check_symtabs)
5492         (maintenance_expand_symtabs, maintenance_info_line_tables):
5493         Update.
5494         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5495         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5496         (map_overlay_command, unmap_overlay_command)
5497         (simple_overlay_update, expand_symtabs_matching)
5498         (map_symbol_filenames): Update.
5499         * symfile-debug.c (set_debug_symfile): Update.
5500         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5501         Update.
5502         * source.c (select_source_symtab, forget_cached_source_info):
5503         Update.
5504         * solib.c (solib_read_symbols): Update.
5505         * solib-spu.c (append_ocl_sos): Update.
5506         * psymtab.c (maintenance_print_psymbols)
5507         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5508         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5509         * printcmd.c (info_symbol_command): Update.
5510         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5511         Update.
5512         * objfiles.h (class all_objfiles): Remove.
5513         * objfiles.c (have_partial_symbols, have_full_symbols)
5514         (have_minimal_symbols, qsort_cmp, update_section_map)
5515         (shared_objfile_contains_address_p)
5516         (default_iterate_over_objfiles_in_search_order): Update.
5517         * objc-lang.c (info_selectors_command, info_classes_command)
5518         (find_methods): Update.
5519         * minsyms.c (find_solib_trampoline_target): Update.
5520         * maint.c (maintenance_info_sections)
5521         (maintenance_translate_address, count_symtabs_and_blocks):
5522         Update.
5523         * main.c (captured_main_1): Update.
5524         * linux-thread-db.c (try_thread_db_load_from_pdir)
5525         (has_libpthread): Update.
5526         * linespec.c (iterate_over_all_matching_symtabs)
5527         (search_minsyms_for_name): Update.
5528         * jit.c (jit_find_objf_with_entry_addr): Update.
5529         * hppa-tdep.c (find_unwind_entry)
5530         (hppa_lookup_stub_minimal_symbol): Update.
5531         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5532         Update.
5533         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5534         (elf_gnu_ifunc_resolve_by_got): Update.
5535         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5536         * dwarf-index-write.c (save_gdb_index_command): Update.
5537         * cp-support.c (add_symbol_overload_list_qualified): Update.
5538         * breakpoint.c (create_overlay_event_breakpoint)
5539         (create_longjmp_master_breakpoint)
5540         (create_std_terminate_master_breakpoint)
5541         (create_exception_master_breakpoint): Update.
5542         * blockframe.c (find_pc_partial_function): Update.
5543         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5544         (ada_collect_symbol_completion_matches)
5545         (ada_add_global_exceptions): Update.
5546
5547 2019-01-17  Tom Tromey  <tom@tromey.com>
5548
5549         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5550         declare VEC.
5551         (solib_target_parse_libraries): Change return type.
5552         (library_list_start_segment, library_list_start_section)
5553         (library_list_end_library, library_list_start_library); Update.
5554         (solib_target_free_library_list): Remove.
5555         (solib_target_parse_libraries): Remove cleanup.  Change return
5556         type.
5557         (solib_target_current_sos): Update.
5558
5559 2019-01-17  Tom Tromey  <tromey@bapiya>
5560
5561         * valprint.c: Replace "the the" with "the".
5562         * symtab.c: Replace "the the" with "the".
5563         * solib.c: Replace "the the" with "the".
5564         * solib-dsbt.c: Replace "the the" with "the".
5565         * linespec.c: Replace "the the" with "the".
5566         * dwarf2loc.h: Replace "the the" with "the".
5567         * amd64-windows-tdep.c: Replace "the the" with "the".
5568         * aarch64-tdep.c: Replace "the the" with "the".
5569
5570 2019-01-16  Keith Seitz  <keiths@redhat.com>
5571
5572         PR gdb/23773
5573         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5574         <builder>: Rename to ..
5575         <m_builder>: ... this and make private.
5576         (dwarf2_cu::get_builder): New method.  Change all users of
5577         `builder' to use this method.
5578         (dwarf2_start_symtab): Move to ...
5579         (dwarf2_cu::start_symtab): ... here.  Update all callers
5580         (setup_type_unit_groups): Move to ...
5581         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5582         callers.
5583         (dwarf2_cu::reset_builder): New method.
5584         (process_full_compunit, process_full_type_unit): Use
5585         dwarf2_cu::reset_builder.
5586         (follow_die_offset): Record the ancestor CU if it is different
5587         from the followed DIE's CU.
5588         (follow_die_sig_1): Likewise.
5589
5590 2019-01-15  Tom Tromey  <tom@tromey.com>
5591
5592         * remote.c (class remote_state) <buf>: Now a char_vector.
5593         <buf_size>: Remove.
5594         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5595         parameter.
5596         (remote_target::getpkt_or_notif_sane_1)
5597         (remote_target::getpkt_sane)
5598         (remote_target::getpkt_or_notif_sane): Likewise.
5599         (class remote_target) <putpkt>: New overload.
5600         (remote_target::read_frame): Change type of "buf_p".  Remove
5601         sizeof_p parameter.
5602         (packet_ok): New overload.
5603         (packet_check_result): New overload.
5604         Update all uses.
5605
5606 2019-01-14  Tom Tromey  <tom@tromey.com>
5607
5608         * remote-notif.c (handle_notification, remote_notif_ack)
5609         (remote_notif_parse): Make "buf" const.
5610         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5611         const.
5612         (remote_notif_parse, remote_notif_ack, handle_notification):
5613         Likewise.
5614         * remote.c (remote_notif_stop_parse): Make "buf" const.
5615         (remote_target::remote_parse_stop_reply): Make "buf" const.
5616         (remote_notif_stop_ack): Make "buf" const.
5617
5618 2019-01-14  Tom Tromey  <tom@tromey.com>
5619
5620         * remote.c (remote_console_output): Make parameter const.
5621
5622 2019-01-14  Tom Tromey  <tom@tromey.com>
5623
5624         * target-debug.h (target_debug_print_signals): Constify.
5625         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5626         * procfs.c (procfs_target::pass_signals): Update.
5627         * linux-nat.c (linux_nat_target::pass_signals): Update.
5628         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5629         * target-delegates.c: Rebuild.
5630         * remote.c (remote_target::program_signals): Update.
5631         (remote_target::pass_signals): Update.
5632         * target.c (target_pass_signals): Constify argument.
5633         (target_program_signals): Likewise.
5634         * target.h (struct target_ops) <pass_signals, program_signals>:
5635         Constify argument.
5636         (target_pass_signals, target_program_signals): Constify argument.
5637
5638 2019-01-14  Tom Tromey  <tom@tromey.com>
5639
5640         PR tui/28819:
5641         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5642
5643 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5644
5645         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5646         field.
5647         * rs6000-tdep.c: Include reggroups.h.
5648         (IS_V_ALIAS_PSEUDOREG): Define.
5649         (rs6000_register_name): Return names for the "vX" aliases.
5650         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5651         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5652         aliases.  Call default_register_reggroup_p for all other
5653         pseudo-registers.
5654         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5655         New functions.
5656         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5657         Handle "vX" aliases.
5658         (v_alias_pseudo_register_collect): New function.
5659         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5660         (rs6000_gdbarch_init): Initialize "vX" aliases as
5661         pseudo-registers.  Restore registration of
5662         rs6000_pseudo_register_reggroup_p with
5663         set_tdesc_pseudo_register_reggroup_p.
5664
5665 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5666
5667         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5668         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5669         set_gdbarch_num_pseudo_regs.
5670
5671 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5672
5673         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5674         Remove arg prefixname, add do_set and do_show.
5675         Add member functions set_list and show_list.
5676         * cli/cli-style.c (class cli_style_option): Update accordingly.
5677         (style_set_list): Move to file scope.
5678         (style_show_list): Likewise.
5679         (set_style): Call help_list.
5680         (show_style): Call cmd_show_list.
5681         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5682         Update to use the new macro.
5683
5684 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5685
5686         * ada-lang.c (_initialize_ada_language): Expand the help text
5687         for the "catch exception" command.
5688
5689 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5690
5691         * symtab.c (matching_obj_sections): Initialize obj,
5692         declare it closer to its usage.
5693
5694 2019-01-10  Tom Tromey  <tom@tromey.com>
5695
5696         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5697         (basic_inf_threads_range): Remove.
5698         (inf_threads_range, inf_non_exited_threads_range)
5699         (safe_inf_threads_range): Use next_adapter.
5700
5701 2019-01-10  Keith Seitz  <keiths@redhat.com>
5702
5703         PR gdb/23712
5704         PR symtab/23010
5705         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5706         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5707
5708 2019-01-10  Keith Seitz  <keiths@redhat.com>
5709
5710         PR gdb/23712
5711         PR symtab/23010
5712         * dictionary.c (pending_to_vector): Remove.
5713         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5714         Remove _1 suffix, replacing functions of the same name.  Update
5715         all callers.
5716         (dict_create_hashed, dict_create_hashed_expandable)
5717         (dict_create_linear, dict_create_linear_expandable, dict_free)
5718         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5719         Make functions static.
5720
5721 2019-01-10  Keith Seitz  <keiths@redhat.com>
5722
5723         PR gdb/23712
5724         PR symtab/23010
5725         * dictionary.h (struct dictionary): Replace declaration with
5726         multidictionary.
5727         (dict_create_hashed, dict_create_hashed_expandable)
5728         (dict_create_linear, dict_create_linear_expandable)
5729         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5730         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5731         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5732         taking multidictionary argument.
5733         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5734         * block.h (struct block) <dict>: Change to multidictionary
5735         and rename `multidict'.
5736         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5737         symmisc.c: Update all dictionary references to multidictionary.
5738
5739 2019-01-10  Keith Seitz  <keiths@redhat.com>
5740
5741         PR gdb/23712
5742         PR symtab/23010
5743         * dictionary.c: Include unordered_map.
5744         (pending_to_vector): New function.
5745         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5746         Rewrite the non-"_1" functions to take vector instead
5747         of linked list.
5748         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5749         "new" _1 versions of the same name.
5750         (multidictionary): Define.
5751         (std::hash<enum language): New definition.
5752         (collate_pending_symbols_by_language, mdict_create_hashed)
5753         (mdict_create_hashed_expandable, mdict_create_linear)
5754         (mdict_create_linear_expandable, mdict_free)
5755         (find_language_dictionary, create_new_language_dictionary)
5756         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5757         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5758         (mdict_size, mdict_empty): New functions.
5759         * dictionary.h (mdict_iterator): Define.
5760
5761 2019-01-10  Pedro Alves  <palves@redhat.com>
5762
5763         * breakpoint.c (read_uploaded_action)
5764         (create_tracepoint_from_upload): Adjust to use
5765         gdb::unique_xmalloc_ptr.
5766         * ctf.c (ctf_write_uploaded_tp):
5767         (SET_ARRAY_FIELD): Use emplace_back.
5768         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5769         * tracefile-tfile.c (tfile_write_uploaded_tp):
5770         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5771         gdb::unique_xmalloc_ptr.
5772         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5773         at_string, cond_string, cmd_strings>: Replace char pointers
5774         with gdb::unique_xmalloc_ptr.
5775
5776 2019-01-10  Pedro Alves  <palves@redhat.com>
5777
5778         * solib-target.c (library_list_start_library): Don't xstrdup name.
5779
5780 2019-01-10  Pedro Alves  <palves@redhat.com>
5781
5782         * mdebugread.c (parse_partial_symbols): Use
5783         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5784
5785 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5786
5787         * linux-fork.c (scoped_switch_fork_info)
5788         <~scoped_switch_fork_info>: Fix incorrect variable name.
5789
5790 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5791
5792         * linux-fork.c (scoped_switch_fork_info)
5793         <scoped_switch_fork_info>: Make explicit.
5794         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5795
5796 2019-01-10  Tom Tromey  <tom@tromey.com>
5797
5798         * objfiles.h (objfile::reset_psymtabs): Update.
5799         * objfiles.c (objfile::objfile): Update.
5800         * psymtab.h (psymtab_storage::obstack): Update.
5801         (psymtab_storage::m_obstack): Use gdb::optional.
5802         (class psymtab_storage): Update comment.  Remove objfile
5803         parameter.
5804         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5805
5806 2019-01-10  Tom Tromey  <tom@tromey.com>
5807
5808         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5809         <free_psymtabs>: Now private.
5810         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5811         (allocate_psymtab): Use new method.
5812
5813 2019-01-10  Tom Tromey  <tom@tromey.com>
5814
5815         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5816         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5817         * mdebugread.c (parse_partial_symbols): Use
5818         allocate_dependencies.
5819         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5820         allocate_dependencies.
5821         (process_psymtab_comp_unit_reader)
5822         (build_type_psymtab_dependencies): Likewise.
5823         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5824
5825 2019-01-10  Tom Tromey  <tom@tromey.com>
5826
5827         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5828         PSYMBOL_SET_LANGUAGE.
5829         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5830
5831 2019-01-10  Tom Tromey  <tom@tromey.com>
5832
5833         * psymtab.h (psymtab_storage::obstack): New method.
5834         <m_obstack>: Rename from obstack; now private.
5835         * psymtab.c (psymtab_storage): Update.
5836         * dwarf2read.c (create_addrmap_from_index)
5837         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5838         Update.
5839
5840 2019-01-10  Tom Tromey  <tom@tromey.com>
5841
5842         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5843         * objfiles.h (objfile::reset_psymtabs): New method.
5844
5845 2019-01-10  Tom Tromey  <tom@tromey.com>
5846
5847         * symmisc.c (print_symbol_bcache_statistics): Update.
5848         (print_objfile_statistics): Update.
5849         * symfile.c (reread_symbols): Update.
5850         * psymtab.h (class psymtab_storage): New.
5851         * psymtab.c (psymtab_storage): New constructor.
5852         (~psymtab_storage): New destructor.
5853         (require_partial_symbols): Update.
5854         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5855         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5856         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5857         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5858         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5859         (start_psymtab_common, end_psymtab_common)
5860         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5861         (allocate_psymtab): Update.
5862         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5863         Update.
5864         (dump_psymtab_addrmap, maintenance_print_psymbols)
5865         (maintenance_check_psymtabs): Update.
5866         (class objfile_psymtabs): Move to objfiles.h.
5867         * psympriv.h (discard_psymtab): Now inline.
5868         (psymtab_discarder::psymtab_discarder): Update.
5869         (psymtab_discarder::~psymtab_discarder): Update.
5870         (ALL_OBJFILE_PSYMTABS): Rewrite.
5871         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5872         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5873         Remove fields.
5874         <partial_symtabs>: New field.
5875         (class objfile_psymtabs): Move from psymtab.h.  Update.
5876         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5877         psymbol_cache.
5878         (objfile::~objfile): Don't destroy psymbol_cache.
5879         * mdebugread.c (parse_partial_symbols): Update.
5880         * dwarf2read.c (create_addrmap_from_index)
5881         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5882         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5883         (add_partial_subprogram, dwarf2_ranges_read): Update.
5884         * dwarf-index-write.c (write_address_map)
5885         (write_one_signatured_type, recursively_write_psymbols)
5886         (class debug_names, class debug_names, write_psymtabs_to_index):
5887         Update.
5888
5889 2019-01-10  Tom Tromey  <tom@tromey.com>
5890
5891         * symtab.h (SYMBOL_SET_NAMES): Update.
5892         (symbol_set_names): Update.
5893         (MSYMBOL_SET_NAMES): Update.
5894         * symtab.c (symbol_set_names): Change argument to be an
5895         objfile_per_bfd_storage.
5896         * psymtab.c (add_psymbol_to_bcache): Update.
5897         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5898
5899 2019-01-10  Tom Tromey  <tom@tromey.com>
5900
5901         * symtab.c (create_demangled_names_hash): Change argument to be an
5902         objfile_per_bfd_storage.
5903         (symbol_set_names): Update.
5904
5905 2019-01-10  Tom Tromey  <tom@tromey.com>
5906
5907         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5908         init_psymbol_list.
5909         * psymtab.c (init_psymbol_list): Do nothing if already called.
5910         * psympriv.h (init_psymbol_list): Add comment.
5911         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5912         init_psymbol_list.
5913         * dbxread.c (dbx_symfile_read): Unconditionally call
5914         init_psymbol_list.
5915
5916 2019-01-10  Tom Tromey  <tom@tromey.com>
5917
5918         * xcoffread.c (scan_xcoff_symtab): Update.
5919         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5920         "where".
5921         * mdebugread.c (parse_partial_symbols)
5922         (handle_psymbol_enumerators): Update.
5923         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5924         * dbxread.c (read_dbx_symtab): Update.
5925         * psympriv.h (psymbol_placement): New enum.
5926         (add_psymbol_to_list): Update.
5927
5928 2019-01-10  Tom Tromey  <tom@tromey.com>
5929
5930         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5931         static_psymbols parameters.
5932         (scan_xcoff_symtab): Update.
5933         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5934         static_psymbols parameters.
5935         * psympriv.h (start_psymtab_common): Update.
5936         * mdebugread.c (parse_partial_symbols): Update.
5937         * dwarf2read.c (create_partial_symtab): Update.
5938         * dbxread.c (read_dbx_symtab): Update.
5939         (start_psymtab): Remove global_psymbols and static_psymbols
5940         parameters.
5941
5942 2019-01-10  Tom Tromey  <tom@tromey.com>
5943
5944         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5945         * psymtab.c (allocate_psymtab): Add comment.
5946         * psympriv.h (allocate_psymtab): Add comment.
5947         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5948         initializations.
5949         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5950
5951 2019-01-10  Tom Tromey  <tom@tromey.com>
5952
5953         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5954         Don't declare.
5955         * mipsread.c: Include mdebugread.h.
5956         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5957         Declare.
5958         * elfread.c: Include mdebugread.h.
5959
5960 2019-01-09  Tom Tromey  <tom@tromey.com>
5961
5962         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5963         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5964         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5965         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5966         (psym_lookup_symbol, psym_find_last_source_symtab)
5967         (psym_forget_cached_source_info, psym_print_stats)
5968         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5969         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5970         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5971         (psym_find_compunit_symtab_by_address)
5972         (maintenance_print_psymbols, maintenance_info_psymtabs)
5973         (maintenance_check_psymtabs): Use ranged for.
5974         * psymtab.h (class objfile_psymtabs): New.
5975         (require_partial_symbols): Return objfile_psymtabs.
5976         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5977
5978 2019-01-09  Tom Tromey  <tom@tromey.com>
5979
5980         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5981         (find_pc_mapped_section, list_overlays_command)
5982         (map_overlay_command, unmap_overlay_command)
5983         (simple_overlay_update): Use all_objfiles.
5984         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5985         * printcmd.c (info_symbol_command): Use all_objfiles.
5986         * objfiles.h (ALL_OBJSECTIONS): Remove.
5987         * maint.c (maintenance_translate_address): Use all_objfiles.
5988         * gcore.c (gcore_create_callback): Use all_objfiles.
5989         (objfile_find_memory_regions): Likewise.
5990
5991 2019-01-09  Tom Tromey  <tom@tromey.com>
5992
5993         * symtab.c (find_line_symtab, info_sources_command)
5994         (make_source_files_completion_list): Use objfile_compunits.
5995         * source.c (select_source_symtab): Use objfile_compunits.
5996         * objfiles.h (struct objfile): Update comment.
5997         (ALL_OBJFILES): Remove.
5998         (ALL_FILETABS): Remove.
5999         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6000         objfile_compunits.
6001
6002 2019-01-09  Tom Tromey  <tom@tromey.com>
6003
6004         * symmisc.c (print_objfile_statistics, dump_objfile)
6005         (maintenance_print_symbols): Use compunit_filetabs.
6006         * source.c (forget_cached_source_info_for_objfile): Use
6007         compunit_filetabs.
6008         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6009         (ALL_FILETABS): Use compunit_filetabs.
6010         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6011         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6012
6013 2019-01-09  Tom Tromey  <tom@tromey.com>
6014
6015         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6016         (compunit_filetabs): New.
6017         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6018         compunit_filetabs.
6019         (info_sources_command, make_source_files_completion_list): Remove
6020         declaration.
6021         * symmisc.c (print_objfile_statistics, dump_objfile)
6022         (maintenance_print_symbols): Remove declaration.
6023         (maintenance_info_symtabs): Use compunit_filetabs.
6024         (maintenance_info_line_tables): Likewise.
6025         * source.c (select_source_symtab): Change local variable name.
6026         (forget_cached_source_info_for_objfile): Remove declaration.
6027         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6028         * objfiles.c (objfile_relocate1): Remove declaration.
6029         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6030         declaration.
6031         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6032         * coffread.c (coff_symtab_read): Remove declaration.
6033         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6034         compunit_filetabs.
6035
6036 2019-01-09  Tom Tromey  <tom@tromey.com>
6037
6038         * symtab.c (lookup_objfile_from_block)
6039         (find_pc_sect_compunit_symtab, search_symbols)
6040         (default_collect_symbol_completion_matches_break_on): Use
6041         objfile_compunits.
6042         * objfiles.h (ALL_COMPUNITS): Remove.
6043         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6044         * cp-support.c (add_symbol_overload_list_qualified): Use
6045         objfile_compunits.
6046         * ada-lang.c (ada_collect_symbol_completion_matches)
6047         (ada_add_global_exceptions): Use objfile_compunits.
6048
6049 2019-01-09  Tom Tromey  <tom@tromey.com>
6050
6051         * source.c (select_source_symtab)
6052         (forget_cached_source_info_for_objfile): Remove declaration.
6053         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6054         declaration.
6055         * maint.c (count_symtabs_and_blocks): Remove declaration.
6056         * cp-support.c (add_symbol_overload_list_qualified): Remove
6057         declaration.
6058         * coffread.c (coff_symtab_read): Remove declaration.
6059         * symtab.c (lookup_symbol_in_objfile_symtabs)
6060         (basic_lookup_transparent_type_1): Use objfile_compunits.
6061         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6062         (info_sources_command, search_symbols)
6063         (default_collect_symbol_completion_matches_break_on)
6064         (make_source_files_completion_list): Remove declaration.
6065         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6066         (ada_collect_symbol_completion_matches)
6067         (ada_add_global_exceptions): Remove declaration.
6068         * linespec.c (iterate_over_all_matching_symtabs): Use
6069         objfile_compunits.
6070         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6071         (class objfile_compunits): New.
6072         (ALL_COMPUNITS): Use objfile_compunits.
6073         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6074         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6075         objfile_compunits.
6076         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6077
6078 2019-01-09  Tom Tromey  <tom@tromey.com>
6079
6080         * symtab.c (search_symbols)
6081         (default_collect_symbol_completion_matches_break_on): Use
6082         objfile_msymbols.
6083         * ada-lang.c (ada_lookup_simple_minsym)
6084         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6085         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6086         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6087         objfile_msymbols.
6088         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6089         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6090         * objc-lang.c (find_methods): Use objfile_msymbols.
6091         (info_selectors_command, info_classes_command): Likewise.
6092         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6093         * objfiles.h (class objfile_msymbols): New.
6094         (ALL_OBJFILE_MSYMBOLS): Remove.
6095         (ALL_MSYMBOLS): Remove.
6096
6097 2019-01-09  Tom Tromey  <tom@tromey.com>
6098
6099         * common/next-iterator.h (next_adapter): Add Iterator template
6100         parameter.
6101         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6102         (class all_objfiles_safe): New.
6103         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6104         * objfiles.c (put_objfile_before): Update comment.
6105         (add_separate_debug_objfile): Likewise.
6106         (free_all_objfiles): Use all_objfiles_safe.
6107         (objfile_purge_solibs): Likewise.
6108
6109 2019-01-09  Tom Tromey  <tom@tromey.com>
6110
6111         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6112         (expand_symtab_containing_pc, lookup_static_symbol)
6113         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6114         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6115         all_objfiles.
6116         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6117         * breakpoint.c (create_overlay_event_breakpoint)
6118         (create_longjmp_master_breakpoint)
6119         (create_std_terminate_master_breakpoint)
6120         (create_exception_master_breakpoint): Use all_objfiles.
6121         * linux-thread-db.c (try_thread_db_load_from_pdir)
6122         (has_libpthread): Use all_objfiles.
6123         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6124         * linespec.c (iterate_over_all_matching_symtabs)
6125         (search_minsyms_for_name): Use all_objfiles.
6126         * maint.c (maintenance_info_sections): Use all_objfiles.
6127         * main.c (captured_main_1): Use all_objfiles.
6128         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6129         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6130         * guile/scm-pretty-print.c
6131         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6132         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6133         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6134         (maintenance_print_msymbols): Use all_objfiles.
6135         * source.c (select_source_symtab): Use all_objfiles.
6136         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6137         * symfile.c (remove_symbol_file_command)
6138         (expand_symtabs_matching, map_symbol_filenames): Use
6139         all_objfiles.
6140         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6141         all_objfiles.
6142         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6143         * objc-lang.c (find_methods): Use all_objfiles.
6144         * objfiles.c (have_partial_symbols, have_full_symbols)
6145         (have_minimal_symbols, qsort_cmp)
6146         (default_iterate_over_objfiles_in_search_order): Use
6147         all_objfiles.
6148         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6149         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6150         (maintenance_check_psymtabs): Use all_objfiles.
6151         (ALL_PSYMTABS): Remove.
6152         * compile/compile-object-run.c (do_module_cleanup): Use
6153         all_objfiles.
6154         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6155         * cp-support.c (add_symbol_overload_list_qualified): Use
6156         all_objfiles.
6157         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6158         Use all_objfiles.
6159         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6160         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6161         all_objfiles.
6162         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6163         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6164         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6165         Uses all_objfiles.
6166         * solib.c (solib_read_symbols): Use all_objfiles
6167
6168 2019-01-09  Tom Tromey  <tom@tromey.com>
6169
6170         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6171         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6172         all_objfiles.
6173         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6174         * symmisc.c (print_symbol_bcache_statistics)
6175         (print_objfile_statistics, maintenance_print_objfiles)
6176         (maintenance_info_symtabs, maintenance_check_symtabs)
6177         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6178         all_objfiles.
6179         * source.c (forget_cached_source_info): Use all_objfiles.
6180         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6181         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6182         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6183         * objfiles.c (update_section_map): Use all_objfiles.
6184         (shared_objfile_contains_address_p): Likewise.
6185         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6186         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6187
6188 2019-01-09  Tom Tromey  <tom@tromey.com>
6189
6190         * common/next-iterator.h: New file.
6191         * objfiles.h (class all_objfiles): New.
6192         (struct objfile_iterator): New.
6193
6194 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6195
6196         * NEWS: Move the description of the changed "frame", "select-frame",
6197          and "info frame" commands to the Changed commands section.
6198
6199 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6200
6201         * gdbtypes.c (check_stub_method_group): Remove handling of old
6202         mangling schemes.
6203         * linespec.c (find_methods): Likewise.
6204         * stabsread.c (read_member_functions): Likewise.
6205         * valops.c (search_struct_method): Likewise.
6206         (value_struct_elt_for_reference): Likewise.
6207         * NEWS: Mention this change.
6208
6209 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6210
6211         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6212         print_source_lines.
6213         * source.c (print_source_lines_base): Update line number check.
6214         (print_source_lines): New function.
6215         (source_lines_range::source_lines_range): New function.
6216         * source.h (class source_lines_range): New class.
6217         (print_source_lines): New declaration.
6218
6219 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6220
6221         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6222
6223 2019-01-08  Tom Tromey  <tom@tromey.com>
6224             Simon Marchi  <simon.marchi@ericsson.com>
6225
6226         PR gdb/24060
6227         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6228         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6229         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6230         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6231         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6232         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6233
6234 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6235
6236         * source.c (select_source_symtab): Move header comment to
6237         declaration in source.h.
6238         (forget_cached_source_info_for_objfile): Likewise.
6239         (forget_cached_source_info): Likewise.
6240         (identify_source_line): Likewise.
6241         * source.h (identify_source_line): Move declaration from symtab.h
6242         and add comment from source.c
6243         (print_source_lines): Likewise.
6244         (forget_cached_source_info_for_objfile): Likewise.
6245         (forget_cached_source_info): Likewise.
6246         (select_source_symtab): Likewise.
6247         (enum print_source_lines_flag): Move definition from symtab.h.
6248         * symtab.h (identify_source_line): Move declaration to source.h.
6249         (print_source_lines): Likewise.
6250         (forget_cached_source_info_for_objfile): Likewise.
6251         (forget_cached_source_info): Likewise.
6252         (select_source_symtab): Likewise.
6253         (enum print_source_lines_flag): Move definition to source.h.
6254         * tui/tui-hooks.c: Add 'source.h' include.
6255
6256 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6257
6258         * source.c (print_source_lines_base): Handle requests to print
6259         reverse line number sequences, and guard against empty lines
6260         string.
6261
6262 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6263
6264         * source.c (print_source_lines_base): Fix skip of '\r' if next
6265         character is '\n'.
6266
6267 2019-01-06  Tom Tromey  <tom@tromey.com>
6268
6269         * c-exp.y (struct c_parse_state) <macro_original_text,
6270         expansion_obstack>: New member.
6271         (macro_original_text, expansion_obstack): Remove globals.
6272         (scan_macro_expansion, scanning_macro_expansion)
6273         (finished_macro_expansion): Update.
6274         (scan_macro_cleanup): Remove.
6275         (yylex, c_parse): Update.
6276
6277 2019-01-06  Tom Tromey  <tom@tromey.com>
6278
6279         * c-exp.y (struct c_parse_state) <strings>: New member.
6280         (operator_stoken): Update.
6281
6282 2019-01-06  Tom Tromey  <tom@tromey.com>
6283
6284         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6285         (union type_stack_elt) <typelist_val>: Now a pointer to
6286         std::vector.
6287         (type_stack_cleanup): Don't declare.
6288         (push_typelist): Update.
6289         * parse.c (pop_typelist): Return a std::vector.
6290         (push_typelist): Take a std::vector.
6291         (follow_types): Update.  Do not free args.
6292         (type_stack_cleanup): Remove.
6293         * c-exp.y (struct c_parse_state): New.
6294         (cpstate): New global.
6295         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6296         (nonempty_typelist): Update.
6297         (func_mod): Create a new vector.
6298         (c_parse): Create a c_parse_state.
6299         (check_parameter_typelist): Do not delete params.
6300         (function_method): Update.  Do not delete type_list.
6301
6302 2019-01-06  Tom Tromey  <tom@tromey.com>
6303
6304         PR gdb/28155:
6305         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6306         check_typedef.
6307         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6308         (print_return_value): Likewise.
6309
6310 2019-01-05  Tom Tromey  <tom@tromey.com>
6311
6312         * contrib/cleanup_check.py: Remove.
6313         * contrib/gcc-with-excheck: Remove.
6314         * contrib/exsummary.py: Remove.
6315         * contrib/excheck.py: Remove.
6316
6317 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6318
6319         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6320         NULL. Initialize tpprev to NULL instead of assigning it
6321         to NULL on the next statement.
6322         * windows-nat.c (windows_delete_thread): Remove check for
6323         main_thread_id before printing thread exit notifications.
6324         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6325         Remove thread ID check against main_thread_id.
6326         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6327         windows_delete_thread.
6328         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6329
6330 2019-01-04  Tom Tromey  <tom@tromey.com>
6331
6332         * compile/compile.c (_initialize_compile): Use upper case for
6333         metasyntactic variables.
6334         * symmisc.c (_initialize_symmisc): Use upper case for
6335         metasyntactic variables.
6336         * psymtab.c (_initialize_psymtab): Use upper case for
6337         metasyntactic variables.
6338         * demangle.c (demangle_command): Use upper case for metasyntactic
6339         variables.
6340         (_initialize_demangler): Likewise.
6341         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6342         variables.
6343
6344 2019-01-03  Tom Tromey  <tom@tromey.com>
6345
6346         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6347
6348 2019-01-03  Tom Tromey  <tom@tromey.com>
6349
6350         * python/py-symtab.c (salpy_str): Update.
6351         (struct salpy_sal_object) <symtab>: Now a PyObject.
6352         (salpy_dealloc): Update.
6353         (del_objfile_sal): Use gdbpy_ref.
6354
6355 2019-01-03  Tom Tromey  <tom@tromey.com>
6356
6357         * python/py-type.c (convert_field): Use new_reference.  Return
6358         gdbpy_ref.
6359         (make_fielditem): Return gdbpy_ref.
6360         (typy_fields): Update.
6361         (typy_getitem): Update.
6362         (field_name): Return gdbpy_ref.  Use new_reference.
6363         (typy_iterator_iternext): Update.
6364
6365 2019-01-03  Tom Tromey  <tom@tromey.com>
6366
6367         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6368
6369 2019-01-03  Tom Tromey  <tom@tromey.com>
6370
6371         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6372         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6373         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6374         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6375         (pspy_set_type_printers): Likewise.
6376         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6377         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6378         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6379         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6380         (objfpy_set_type_printers): Likewise.
6381
6382 2019-01-03  Tom Tromey  <tom@tromey.com>
6383
6384         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6385         (gdbpy_print_stack): Use gdbpy_err_fetch.
6386         * python/python-internal.h (class gdbpy_err_fetch): New class.
6387         (class gdbpy_enter) <m_error_type, m_error_value,
6388         m_error_traceback>: Remove.
6389         <m_error>: New member.
6390         (gdbpy_exception_to_string): Don't declare.
6391         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6392         * python/py-value.c (convert_value_from_python): Use
6393         gdbpy_err_fetch.
6394         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6395         gdbpy_exception_to_string.
6396         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6397         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6398         gdbpy_err_fetch.
6399
6400 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6401
6402         * linux-nat.c (delete_lwp_cleanup): Delete.
6403         (struct lwp_deleter): New struct.
6404         (lwp_info_up): New typedef.
6405         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6406         lwp_info_up.
6407
6408 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6409
6410         * linux-fork.c (class scoped_switch_fork_info): New class.
6411         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6412
6413 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6414
6415         * valops.c (find_overload_match): Remove use of null_cleanup, and
6416         calls to do_cleanups.
6417
6418 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6419
6420         * compile/compile-cplus-types.c
6421         (compile_cplus_instance::decl_name): Handle changes to
6422         cp_func_name.
6423         * cp-support.c (cp_func_name): Update header comment, update
6424         return type.
6425         * cp-support.h (cp_func_name): Update return type in declaration.
6426         * valops.c (find_overload_match): Move temp_func local to top
6427         level of function and change its type.  Use temp_func to hold and
6428         delete temporary string obtained from cp_func_name.
6429
6430 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6431
6432         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6433         gdb::char_vector, remove cleanup, and update uses of `msg`.
6434
6435 2019-01-03  Jim Wilson  <jimw@sifive.com>
6436
6437         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6438
6439 2019-01-02  Tom Tromey  <tom@tromey.com>
6440
6441         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6442         (tdesc_parse_xml): Remove cleanups.
6443         * target-descriptions.h (make_cleanup_free_target_description):
6444         Don't declare.
6445         (target_desc_deleter): New struct.
6446         (target_desc_up): New typedef.
6447         * target-descriptions.c (target_desc_deleter::operator()): Rename
6448         from free_target_description.
6449         (make_cleanup_free_target_description): Remove.
6450
6451 2019-01-02  Tom Tromey  <tom@tromey.com>
6452
6453         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6454         constructor, destructor.
6455         (linespec_parser): Remove typedef.
6456         (~linespec_parser): Rename from linespec_parser_delete.
6457         (linespec_lex_to_end, linespec_complete_label)
6458         (linespec_complete): Update.
6459         (decode_line_full): Remove cleanups.
6460         (decode_line_1): Update.
6461
6462 2019-01-02  Tom Tromey  <tom@tromey.com>
6463
6464         * python/python-internal.h (inferior_to_inferior_object): Change
6465         return type.
6466         * python/py-exitedevent.c (create_exited_event_object): Update.
6467         * python/py-inferior.c (inferior_to_inferior_object): Return
6468         gdbpy_ref.
6469         (python_new_inferior, python_inferior_deleted)
6470         (thread_to_thread_object, delete_thread_object)
6471         (build_inferior_list, gdbpy_selected_inferior): Update.
6472         * python/py-infthread.c (create_thread_object): Update.  Also fail
6473         if inferior_to_inferior_object fails.
6474
6475 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6476
6477         * inferior.h (class inferior) <displaced_step_state>: New field.
6478         * infrun.h (struct displaced_step_state): Move here from
6479         infrun.c.  Initialize fields, add constructor.
6480         <inf>: Remove field.
6481         <reset>: New method.
6482         * infrun.c (struct displaced_step_inferior_state): Move to
6483         infrun.h.
6484         (displaced_step_inferior_states): Remove.
6485         (get_displaced_stepping_state): Adust.
6486         (displaced_step_in_progress_any_inferior): Adjust.
6487         (displaced_step_in_progress_thread): Adjust.
6488         (displaced_step_in_progress): Adjust.
6489         (add_displaced_stepping_state): Remove.
6490         (get_displaced_step_closure_by_addr): Adjust.
6491         (remove_displaced_stepping_state): Remove.
6492         (infrun_inferior_exit): Call displaced_step_state.reset.
6493         (use_displaced_stepping): Don't check for NULL.
6494         (displaced_step_prepare_throw): Call
6495         get_displaced_stepping_state.
6496         (displaced_step_fixup): Don't check for NULL.
6497         (prepare_for_detach): Don't check for NULL.
6498
6499 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6500
6501         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6502          in case of call that did not complete.
6503
6504 2019-01-02  Andrey Utkin  <autkin@undo.io>
6505
6506         * symfile.c (find_separate_debug_file): Fix search of debug files for
6507         remote debuggee.
6508
6509 2019-01-02  Tom Tromey  <tom@tromey.com>
6510
6511         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6512         indentation.
6513         * python/py-frame.c (frapy_older): Remove cast.
6514         (frapy_newer): Likewise.
6515         * python/py-breakpoint.c (local_setattro): Remove cast.
6516         * python/py-arch.c (archpy_name): Remove local variable.
6517         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6518
6519 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6520
6521         * unittests/basic_string_view/element_access/char/empty.cc:
6522         Fix year range in copyright header.
6523
6524 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6525
6526         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6527         Delete.
6528         <operator==>: Update with for removed field.
6529         <hash>: Likewise.
6530         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6531         <isa_features>: ...this.
6532         <abi_features>: New field.
6533         (riscv_isa_flen): Update comment.
6534         (riscv_abi_xlen): New declaration.
6535         (riscv_abi_flen): New declaration.
6536         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6537         isa_features.
6538         (riscv_abi_xlen): New function.
6539         (riscv_isa_flen): Update to get answer from isa_features.
6540         (riscv_abi_flen): New function.
6541         (riscv_has_fp_abi): Update to get answer from abi_features.
6542         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6543         xlen and flen.
6544         (riscv_call_info) <xlen, flen>: Update comment.
6545         (riscv_call_arg_struct): Remove invalid assertions
6546         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6547         is removed.
6548         (riscv_gdbarch_init): Gather isa features and abi features
6549         separately, ensure both match on the gdbarch when reusing an old
6550         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6551         a target with 64-bit float hardware.
6552
6553 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6554
6555         * source.c (search_command_helper): Stop reverse search
6556         when line 1 has been searched.
6557
6558 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6559
6560         * record-full.c (record_full_base_target::close): Rewrite
6561         record_full_core_buf_list free logic.
6562
6563 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6564
6565         * break-catch-syscall.c (print_one_catch_syscall): xfree
6566         the last text.
6567
6568 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6569
6570         * top.c (print_gdb_version): Update Copyright year in version
6571         message.
6572
6573 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6574
6575         Update copyright year range in all GDB files.
6576
6577 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6578
6579         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6580
6581 For older changes see ChangeLog-2018.
6582 \f
6583 Local Variables:
6584 mode: change-log
6585 left-margin: 8
6586 fill-column: 74
6587 version-control: never
6588 coding: utf-8
6589 End:
6590