gdb/ChangeLog

   1 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
   2
   3         PR breakpoints/24541
   4         * gdbarch.c: Regenerate.
   5         * gdbarch.h: Regenerate.
   6         * gdbarch.sh: Add 'stap_adjust_register'.
   7         * i386-tdep.c: Include '<unordered_set>'.
   8         (i386_stap_adjust_register): New function.
   9         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
  10         * stap-probe.c (stap_parse_register_operand): Call
  11         'gdbarch_stap_adjust_register'.
  12
  13 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
  14
  15         PR python/24742
  16         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
  17         * python/python.c (do_start_initialization): Use 'xmalloc'
  18         instead of 'PyMem_Malloc'.
  19
  20 2019-06-28  Tom Tromey  <tromey@adacore.com>
  21
  22         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
  23         for Ada.
  24
  25 2019-06-27  Tom Tromey  <tromey@adacore.com>
  26
  27         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
  28         objfile_key.
  29         (arm_find_mapping_symbol, arm_record_special_symbol)
  30         (_initialize_arm_tdep): Update.
  31         (arm_objfile_data_free): Remove.
  32
  33 2019-06-27  Tom Tromey  <tromey@adacore.com>
  34
  35         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
  36         to cp_print_static_field.
  37
  38 2019-06-26  Tom Tromey  <tromey@adacore.com>
  39
  40         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
  41         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
  42         declare.
  43
  44 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
  45
  46         * features/aarch64-core.c (create_feature_aarch64_core):
  47         Regenerate.
  48         * features/aarch64-core.xml: Add cpsr flags.
  49
  50 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
  51
  52         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
  53         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
  54
  55 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
  56
  57         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
  58         field.
  59         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
  60         use.
  61         (arm_record_special_symbol): Don't insert new symbol in sorted
  62         position, push it at the end.
  63
  64 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
  65
  66         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
  67         (arm_mapping_symbol_s): Remove.
  68         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
  69         (arm_mapping_symbol_vec): New typedef.
  70         (struct arm_per_objfile): Add constructor.
  71         <section_maps>: Change type to
  72         std::unique_ptr<arm_mapping_symbol_vec[]>.
  73         (arm_compare_mapping_symbols): Remove.
  74         (arm_find_mapping_symbol): Adjust to section_maps type change.
  75         (arm_objfile_data_free): Call delete on arm_per_objfile.
  76         (arm_record_special_symbol): Adjust to section_maps type change.
  77         Allocate arm_per_objfile with new.
  78
  79 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  80
  81         * cli/cli-cmds.c (alias_command): Compare the alias prefix
  82         with the command prefix.
  83
  84 2019-06-25  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
  87         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
  88
  89 2019-06-25  Tom Tromey  <tom@tromey.com>
  90
  91         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
  92         type.
  93         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
  94         protected.
  95
  96 2019-06-25  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-winsource.c
  99         (tui_source_window_base::set_is_exec_point_at): Add check against
 100         LOA_ADDRESS.
 101
 102 2019-06-25  Tom Tromey  <tom@tromey.com>
 103
 104         * tui/tui-source.c (tui_set_source_content): Don't check before
 105         xfree.
 106         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 107
 108 2019-06-25  Tom Tromey  <tom@tromey.com>
 109
 110         * tui/tui-winsource.h (tui_update_source_window_as_is)
 111         (tui_alloc_source_buffer, tui_line_is_displayed)
 112         (tui_addr_is_displayed): Change type of win_info.
 113         * tui/tui-winsource.c (tui_update_source_window_as_is)
 114         (tui_clear_source_content, tui_show_source_line)
 115         (tui_show_source_content, tui_source_window_base::refill)
 116         (tui_source_window_base::set_is_exec_point_at)
 117         (tui_source_window_base::set_is_exec_point_at)
 118         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 119         (tui_alloc_source_buffer, tui_line_is_displayed)
 120         (tui_addr_is_displayed): Change type of win_info.  Update.
 121         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 122         (tui_source_window_base::do_make_visible_with_new_height):
 123         Update.
 124         * tui/tui-source.c (tui_set_source_content)
 125         (tui_set_source_content_nil)
 126         (tui_source_window::do_scroll_vertical): Update.
 127         * tui/tui-layout.c (show_layout): Update.
 128         * tui/tui-disasm.c (tui_set_disassem_content)
 129         (tui_disasm_window::do_scroll_vertical): Update.
 130         * tui/tui-data.h (tui_win_content): Remove.
 131         (struct tui_gen_win_info) <content, content_size>: Remove.
 132         (struct tui_source_element): Add initializers and destructor.
 133         (union tui_which_element, struct tui_win_element): Remove.
 134         (struct tui_source_window_base) <content>: New field.
 135         (struct tui_data_window): Remove destructor.
 136         (tui_alloc_content, tui_free_win_content)
 137         (tui_free_all_source_wins_content): Don't declare.
 138         * tui/tui-data.c (tui_initialize_static_data): Update.
 139         (init_content_element, tui_alloc_content): Remove.
 140         (~tui_gen_win_info): Update.
 141         (~tui_data_window, tui_free_all_source_wins_content)
 142         (tui_free_win_content, free_content, free_content_elements):
 143         Remove.
 144
 145 2019-06-25  Tom Tromey  <tom@tromey.com>
 146
 147         * tui/tui-winsource.h (tui_clear_source_content)
 148         (tui_erase_source_content, tui_show_source_content): Change type
 149         of win_info.
 150         * tui/tui-winsource.c (tui_clear_source_content)
 151         (tui_erase_source_content, tui_show_source_content): Change type
 152         of win_info.
 153         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 154         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 155         win_info.
 156         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 157         win_info.
 158         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 159
 160 2019-06-25  Tom Tromey  <tom@tromey.com>
 161
 162         * tui/tui-winsource.c (tui_clear_source_content)
 163         (tui_source_window_base::set_is_exec_point_at): Update.
 164         * tui/tui-source.c (tui_set_source_content_nil): Update.
 165         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 166         a bool.
 167         * tui/tui-data.c (init_content_element): Update.
 168
 169 2019-06-25  Tom Tromey  <tom@tromey.com>
 170
 171         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 172         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 173         * tui/tui-layout.c (init_and_make_win): Update.
 174         * tui/tui.h (enum tui_win_type): Update.
 175         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 176         tui_win_is_auxillary.
 177         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 178         tui_win_is_auxillary.
 179
 180 2019-06-25  Tom Tromey  <tom@tromey.com>
 181
 182         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 183         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 184         (tui_delete_data_content_windows, tui_display_all_data)
 185         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 186         Update.
 187         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 188         * tui/tui-regs.c (tui_last_regs_line_no)
 189         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 190         (tui_show_registers): Update.
 191         (tui_show_register_group): Return void.  Update.
 192         (tui_display_registers_from, tui_display_reg_element_at_line)
 193         (tui_display_registers_from_line, tui_check_register_values):
 194         Update.
 195         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 196         member.
 197         (struct tui_data_window) <regs_content>: Now a std::vector.
 198         <regs_content_count>: Remove.
 199         (tui_add_content_elements, tui_free_data_content): Don't declare.
 200         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 201         (init_content_element): Remove DATA_WIN case.  Add assert.
 202         (tui_add_content_elements): Remove.
 203         (tui_data_window): Update.
 204         (tui_free_data_content): Remove.
 205         (free_content_elements): Remove DATA_WIN case.
 206
 207 2019-06-25  Tom Tromey  <tom@tromey.com>
 208
 209         * tui/tui-data.c (tui_data_item_window): Update.
 210         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 211         * tui/tui-windata.c (tui_display_all_data)
 212         (tui_display_data_from_line): Update.
 213         (tui_check_data_values): Remove.
 214         * tui/tui-regs.c (tui_show_register_group)
 215         (tui_display_reg_element_at_line): Update.
 216         * tui/tui-hooks.c (tui_register_changed)
 217         (tui_refresh_frame_and_register_information): Call
 218         tui_check_register_values.
 219         * tui/tui-data.h (struct tui_data_window) <data_content,
 220         data_content_count, data_type>: Remove.
 221         (enum tui_data_type): Remove.
 222
 223         * tui/tui-data.c (tui_data_window::clear_detail)
 224         (~tui_data_window): Update.
 225
 226 2019-06-25  Tom Tromey  <tom@tromey.com>
 227
 228         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 229         declare.
 230         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 231         Rename from tui_first_data_item_displayed.  Update.
 232         (tui_data_window::refresh_all)
 233         (tui_data_window::do_scroll_vertical): Update.
 234         * tui/tui-data.h (struct tui_data_window)
 235         <first_data_item_displayed>: Declare new method.
 236
 237 2019-06-25  Tom Tromey  <tom@tromey.com>
 238
 239         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 240         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 241         contents...
 242         (tui_initialize_static_data): ...here.
 243
 244 2019-06-25  Tom Tromey  <tom@tromey.com>
 245
 246         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 247         (tui_display_registers_from, tui_check_register_values): Update.
 248         (tui_display_register): Remove win_info parameter; update.
 249         (tui_get_register): Change type of parameters.
 250         * tui/tui-data.h (struct tui_data_element): Remove.
 251         (union tui_which_element) <data>: Remove.
 252         <data_window>: Change type.
 253         (struct tui_data_item_window): New.
 254         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 255         case.  Add assert.
 256         (~tui_data_item_window): New destructor.
 257         (free_content_elements): Remove DATA_ITEM_WIN case.
 258
 259 2019-06-25  Tom Tromey  <tom@tromey.com>
 260
 261         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 262         Remove.
 263
 264 2019-06-25  Tom Tromey  <tom@tromey.com>
 265
 266         * tui/tui-data.h (struct tui_command_element): Remove.
 267         (union tui_which_element) <command>: Remove.
 268         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 269         assert.
 270         (free_content_elements): Remove CMD_WIN case.
 271
 272 2019-06-25  Tom Tromey  <tom@tromey.com>
 273
 274         * tui/tui-layout.c (tui_set_layout): Update.
 275         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 276         * tui/tui-data.c (layout_def): Update.
 277
 278 2019-06-25  Tom Tromey  <tom@tromey.com>
 279
 280         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 281         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 282         (tui_source_window_base::set_new_height): Update.
 283         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 284         Update.
 285         (tui_set_locator_fullname, tui_set_locator_info)
 286         (tui_show_frame_info): Update.
 287         * tui/tui-source.c (tui_set_source_content)
 288         (tui_source_is_displayed): Update.
 289         * tui/tui-layout.c (show_source_disasm_command, show_data)
 290         (show_source_or_disasm_and_command): Update.
 291         * tui/tui-disasm.c (tui_set_disassem_content)
 292         (tui_get_begin_asm_address): Update.
 293         * tui/tui-data.h (struct tui_locator_element): Remove.
 294         (union tui_which_element) <locator>: Remove.
 295         (struct tui_locator_window): New.
 296         (tui_locator_win_info_ptr): Change return type.
 297         * tui/tui-data.c (_locator): Change type.
 298         (tui_locator_win_info_ptr): Change return type.
 299         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 300         (tui_alloc_content): Add assert.
 301
 302 2019-06-25  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui-winsource.c
 305         (tui_exec_info_window::maybe_allocate_content): New method.
 306         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 307         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 308         (make_source_or_disasm_window): Add cast.
 309         * tui/tui-data.h (union tui_which_element) <simple_string>:
 310         Remove.
 311         (struct tui_source_info): New.
 312         (struct tui_source_window_base) <execution_info>: Change type.
 313         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 314         case, and add assert.
 315         (tui_alloc_content): Add assert.
 316
 317 2019-06-25  Tom Tromey  <tom@tromey.com>
 318
 319         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 320         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 321         * tui/tui-data.c (tui_alloc_win_info): Remove.
 322
 323 2019-06-25  Tom Tromey  <tom@tromey.com>
 324
 325         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 326         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 327         can_highlight.
 328
 329 2019-06-25  Tom Tromey  <tom@tromey.com>
 330
 331         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 332         make_visible_with_new_height method.
 333         (tui_win_info::make_visible_with_new_height): New method.
 334         (tui_source_window_base::do_make_visible_with_new_height)
 335         (tui_data_window::do_make_visible_with_new_height)
 336         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 337         (make_visible_with_new_height): Remove.
 338         (tui_resize_all, tui_adjust_win_heights): Use
 339         make_visible_with_new_height method.
 340         * tui/tui-data.h (struct tui_win_info)
 341         <do_make_visible_with_new_height, make_visible_with_new_height>:
 342         New methods.
 343         (struct tui_source_window_base, struct tui_data_window)
 344         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 345         methods.
 346
 347 2019-06-25  Tom Tromey  <tom@tromey.com>
 348
 349         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 350         method.
 351         (update_tab_width): Call update_tab_width method.
 352         * tui/tui-data.h (struct tui_win_info)
 353         (struct tui_source_window_base) <update_tab_width>: New methods.
 354
 355 2019-06-25  Tom Tromey  <tom@tromey.com>
 356
 357         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 358         parameter.
 359         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 360         parameter.
 361         (tui_gen_win_info::make_visible): Update.
 362         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 363         parameter.
 364         * tui/tui-data.h (enum tui_box): New enum.
 365         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 366
 367 2019-06-25  Tom Tromey  <tom@tromey.com>
 368
 369         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 370         init_and_make_win for EXEC_INFO_WIN.
 371         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 372         longer inline.
 373         (struct tui_win_info) <~tui_win_info>: Inline.
 374         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 375         Don't declare.
 376         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 377         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 378         Remove.
 379         (tui_initialize_static_data): Update.
 380         (~tui_gen_win_info): Handle more cleanup here.
 381         (~tui_source_window_base): Delete "execution_info".
 382         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 383
 384 2019-06-25  Tom Tromey  <tom@tromey.com>
 385
 386         * tui/tui-layout.c (make_command_window): Don't set
 387         can_highlight.
 388         (show_source_disasm_command): Call the reset method.
 389         (show_data): Don't set can_highlight.  Call the reset method.
 390         (tui_gen_win_info::reset): Rename from init_gen_win_info
 391         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 392         (show_source_or_disasm_and_command): Call the reset method.
 393         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 394         (struct tui_cmd_window): Set can_highlight.
 395
 396 2019-06-25  Tom Tromey  <tom@tromey.com>
 397
 398         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 399         from make_visible.
 400         (tui_make_visible, tui_make_invisible): Rewrite.
 401         (tui_win_info::make_visible): Remove.
 402         (tui_source_window_base::make_visible): Update.
 403         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 404         method.  Moved from...
 405         (struct tui_win_info) <make_visible>: ...here.
 406
 407 2019-06-25  Tom Tromey  <tom@tromey.com>
 408
 409         * tui/tui-winsource.c
 410         (tui_source_window_base::do_scroll_horizontal): Remove direction
 411         parameter.
 412         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 413         direction parameter.
 414         * tui/tui-win.c (tui_win_info::forward_scroll)
 415         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 416         (tui_win_info::right_scroll): Update.
 417         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 418         direction parameter.
 419         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 420         direction parameter.
 421         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 422         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 423         Remove direction parameter.
 424         (struct tui_source_window_base, struct tui_source_window)
 425         (struct tui_disasm_window, struct tui_data_window)
 426         (struct tui_cmd_window): Update.
 427
 428 2019-06-25  Tom Tromey  <tom@tromey.com>
 429
 430         * tui/tui-winsource.h (tui_set_exec_info_content)
 431         (tui_show_exec_info_content, tui_erase_exec_info_content)
 432         (tui_clear_exec_info_content, tui_update_exec_info): Change
 433         argument to tui_source_window_base.
 434         * tui/tui-winsource.c (tui_set_exec_info_content)
 435         (tui_show_exec_info_content, tui_erase_exec_info_content)
 436         (tui_clear_exec_info_content, tui_update_exec_info): Change
 437         argument to tui_source_window_base.
 438
 439 2019-06-25  Tom Tromey  <tom@tromey.com>
 440
 441         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 442         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 443
 444 2019-06-25  Tom Tromey  <tom@tromey.com>
 445
 446         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 447         check.
 448
 449 2019-06-25  Tom Tromey  <tom@tromey.com>
 450
 451         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 452         type to void.
 453         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 454         type to void.
 455         * tui/tui-source.c (tui_set_source_content): Update.
 456         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 457
 458 2019-06-25  Tom Tromey  <tom@tromey.com>
 459
 460         * tui/tui-win.c (window_name_completer, tui_set_focus)
 461         (tui_all_windows_info): Use name method.
 462         * tui/tui-data.h (struct tui_gen_win_info)
 463         (struct tui_source_window, struct tui_disasm_window)
 464         (struct tui_data_window, struct tui_cmd_window) <name>: New
 465         method.
 466         (tui_win_name): Don't declare.
 467         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 468         (tui_win_name): Remove.
 469
 470 2019-06-25  Tom Tromey  <tom@tromey.com>
 471
 472         * tui/tui-winsource.h (tui_update_source_window)
 473         (tui_update_source_window_as_is): Change parameter type.
 474         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 475         to be a tui_source_window_base.
 476         (tui_update_source_window_as_is): Likewise.
 477         * tui/tui-win.c (make_visible_with_new_height): Update.
 478
 479 2019-06-25  Tom Tromey  <tom@tromey.com>
 480
 481         * tui/tui-winsource.c (tui_erase_source_content)
 482         (tui_show_source_content, tui_show_exec_info_content)
 483         (tui_erase_exec_info_content): Use refresh_window method.
 484         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 485         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 486         from tui_refresh_win.
 487         (tui_data_window::refresh_window): New method.
 488         (tui_win_info::refresh, tui_source_window_base::refresh)
 489         (tui_refresh_all): Use refresh_window method.
 490         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 491         method.
 492         * tui/tui-regs.c (tui_display_register): Call refresh_window
 493         method.
 494         * tui/tui-layout.c (show_source_disasm_command)
 495         (show_source_or_disasm_and_command): Call refresh_window method.
 496         * tui/tui-data.h (struct tui_gen_win_info)
 497         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 498         New method.
 499
 500 2019-06-25  Tom Tromey  <tom@tromey.com>
 501
 502         * tui/tui.c (tui_rl_other_window, tui_enable)
 503         (tui_is_window_visible, tui_get_command_dimension): Update.
 504         * tui/tui-winsource.c (tui_update_source_window_as_is)
 505         (tui_clear_source_content, tui_erase_source_content)
 506         (tui_show_source_line, tui_source_window_base::refill)
 507         (tui_source_window_base::do_scroll_horizontal)
 508         (tui_source_window_base::set_is_exec_point_at)
 509         (tui_update_breakpoint_info, tui_set_exec_info_content)
 510         (tui_alloc_source_buffer, tui_line_is_displayed)
 511         (tui_addr_is_displayed): Update.
 512         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 513         (tui_check_and_display_highlight_if_needed)
 514         (tui_win_info::make_visible, tui_win_info::refresh)
 515         (tui_refresh_all): Update.
 516         * tui/tui-windata.c (tui_first_data_item_displayed)
 517         (tui_delete_data_content_windows, tui_erase_data_content)
 518         (tui_display_all_data, tui_data_window::refresh_all)
 519         (tui_check_data_values): Update.
 520         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 521         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 522         (tui_win_info::backward_scroll, tui_refresh_all_win)
 523         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 524         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 525         (tui_source_window_base::set_new_height)
 526         (tui_data_window::set_new_height)
 527         (make_invisible_and_set_new_height)
 528         (make_visible_with_new_height, new_height_ok)
 529         (parse_scrolling_args): Update.
 530         * tui/tui-stack.c (tui_show_frame_info): Update.
 531         * tui/tui-source.c (tui_set_source_content)
 532         (tui_set_source_content_nil, tui_source_is_displayed)
 533         (tui_source_window::do_scroll_vertical): Update.
 534         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 535         (tui_display_registers_from, tui_display_reg_element_at_line)
 536         (tui_check_register_values, tui_reg_command): Update.
 537         * tui/tui-layout.c (tui_default_win_height)
 538         (show_source_disasm_command, show_data, init_and_make_win)
 539         (show_source_or_disasm_and_command): Update.
 540         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 541         (tui_redisplay_readline, tui_mld_flush)
 542         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 543         (tui_getc): Update.
 544         * tui/tui-disasm.c (tui_set_disassem_content)
 545         (tui_disasm_window::do_scroll_vertical): Update.
 546         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 547         Now virtual.
 548         (struct tui_win_info): Derive from tui_gen_win_info.
 549         <~tui_win_info>: Mark as override.
 550         <generic>: Remove member.
 551         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 552         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 553         (~tui_data_window, ~tui_win_info)
 554         (tui_free_all_source_wins_content): Update.
 555         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 556
 557 2019-06-25  Tom Tromey  <tom@tromey.com>
 558
 559         * tui/tui-layout.c (init_and_make_win): Use new.
 560         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 561         destructor, initializers.
 562         (tui_alloc_generic_win_info): Don't declare.
 563         * tui/tui-data.c (_locator): Add argument to constructor.
 564         (source_win, disasm_win): New globals.
 565         (exec_info): Remove.
 566         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 567         Update.
 568         (tui_alloc_generic_win_info): Remove.
 569         (init_content_element): Use new.
 570         (tui_win_info::tui_win_info): Update.
 571         (free_content_elements) <case DATA_WIN>: Use delete.
 572
 573 2019-06-25  Tom Tromey  <tom@tromey.com>
 574
 575         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 576         * tui/tui-windata.c (tui_first_data_item_displayed)
 577         (tui_delete_data_content_windows): Update.
 578         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 579         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 580         (tui_display_registers_from, tui_check_register_values): Update.
 581         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 582         pointer.
 583         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 584         window.
 585         (tui_free_data_content): Update.
 586         (free_content_elements) <case DATA_WIN>: Free the window.
 587
 588 2019-06-25  Tom Tromey  <tom@tromey.com>
 589
 590         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 591         Update.
 592         * tui/tui-layout.c (make_command_window)
 593         (show_source_disasm_command, show_data, init_and_make_win)
 594         (show_source_or_disasm_and_command): Update.
 595         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 596         method.
 597         <can_highight, is_highlighted>: Now bool.
 598         (tui_set_win_highlight): Don't declare.
 599         * tui/tui-data.c (tui_set_win_highlight): Remove.
 600
 601 2019-06-25  Tom Tromey  <tom@tromey.com>
 602
 603         * tui/tui-wingeneral.c (make_visible): Remove check of window
 604         type.
 605
 606 2019-06-25  Tom Tromey  <tom@tromey.com>
 607
 608         * tui/tui-win.c (tui_win_info::max_height)
 609         (tui_cmd_window::max_height): New methods.
 610         (new_height_ok): Call max_height.
 611         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 612         <max_height>: New method.
 613
 614 2019-06-25  Tom Tromey  <tom@tromey.com>
 615
 616         * tui/tui-win.c (tui_source_window_base::set_new_height)
 617         (tui_data_window::set_new_height): New methods.
 618         (make_invisible_and_set_new_height): Call set_new_height method.
 619         * tui/tui-data.h (struct tui_win_info)
 620         (struct tui_source_window_base, struct tui_data_window)
 621         <set_new_height>: New method.
 622
 623 2019-06-25  Tom Tromey  <tom@tromey.com>
 624
 625         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 626         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 627         tui_refresh_data_win.
 628         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 629         method.
 630         (tui_refresh_all_win): Call the refresh_all method.
 631         (tui_set_focus): Likewise.
 632         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 633         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 634         Likewise.
 635
 636 2019-06-25  Tom Tromey  <tom@tromey.com>
 637
 638         * tui/tui-winsource.h (tui_refill_source_window)
 639         (tui_set_is_exec_point_at): Don't declare.
 640         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 641         (tui_source_window_base::refill): Rename from
 642         tui_refill_source_window.
 643         (tui_source_window_base::do_scroll_horizontal): Update.
 644         (tui_source_window_base::set_is_exec_point_at): Rename from
 645         tui_set_is_exec_point_at.
 646         (tui_update_all_breakpoint_info): Update.
 647         * tui/tui-stack.c (tui_show_frame_info): Update.
 648         * tui/tui-layout.c (show_data): Add cast.
 649         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 650         * tui/tui-data.h (struct tui_source_window_base) <refill,
 651         set_is_exec_point_at>: New methods.
 652         (tui_source_windows, tui_add_to_source_windows): Update types.
 653         (tui_add_to_source_windows): Remove redundant declaration.
 654         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 655         (tui_source_windows): Change return type.
 656         (tui_clear_source_windows_detail): Update.
 657         (tui_add_to_source_windows): Change type of parameter.
 658         (tui_free_all_source_wins_content): Update.
 659
 660 2019-06-25  Tom Tromey  <tom@tromey.com>
 661
 662         * tui/tui-wingeneral.c (tui_win_info::refresh)
 663         (tui_source_window_base::refresh): New methods.
 664         (tui_refresh_all): Call the refresh method.
 665         * tui/tui-data.h (struct tui_win_info)
 666         (struct tui_source_window_base) <refresh>: New method.
 667
 668 2019-06-25  Tom Tromey  <tom@tromey.com>
 669
 670         * tui/tui.h (tui_is_window_visible): Return bool.
 671         * tui/tui.c (tui_is_window_visible): Return bool.
 672         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 673         (tui_make_visible, tui_make_invisible)
 674         (tui_win_info::make_visible)
 675         (tui_source_window_base::make_visible, make_all_visible)
 676         (tui_make_all_visible, tui_make_all_invisible): Update.
 677         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 678         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 679         bool.
 680         (struct tui_win_info, struct tui_source_window_base)
 681         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 682         * tui/tui-data.c (tui_init_generic_part): Update.
 683
 684 2019-06-25  Tom Tromey  <tom@tromey.com>
 685
 686         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 687         (tui_source_window_base::make_visible): New methods.
 688         (make_all_visible): Make method call.
 689         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 690         (struct tui_source_window_base, struct tui_cmd_window): Override
 691         make_visible.
 692         (tui_win_is_source_type): Don't declare.
 693         * tui/tui-data.c (tui_win_is_source_type): Remove.
 694
 695 2019-06-25  Tom Tromey  <tom@tromey.com>
 696
 697         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 698         NULL check.
 699
 700 2019-06-25  Tom Tromey  <tom@tromey.com>
 701
 702         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 703         Inline constructor.  Add initializers for members.
 704         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 705         constructors; now inline in class.
 706
 707 2019-06-25  Tom Tromey  <tom@tromey.com>
 708
 709         * tui/tui-regs.c (tui_show_registers): Update.
 710         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 711         bool.
 712         * tui/tui-data.c (tui_data_window::clear_detail)
 713         (tui_data_window): Update.
 714
 715 2019-06-25  Tom Tromey  <tom@tromey.com>
 716
 717         * tui/tui-windata.c (tui_display_all_data)
 718         (tui_display_data_from_line, tui_display_data_from)
 719         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 720         Update.
 721         * tui/tui-regs.c (tui_last_regs_line_no)
 722         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 723         (tui_show_registers, tui_show_register_group)
 724         (tui_display_registers_from, tui_display_reg_element_at_line)
 725         (tui_display_registers_from_line, tui_check_register_values)
 726         (tui_reg_next, tui_reg_prev): Update.
 727         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 728         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 729         tui_data_window.
 730         (struct tui_win_info) <detail>: Remove.  Add new fields from
 731         tui_data_info.
 732         (TUI_DATA_WIN): Add cast.
 733         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 734         (~tui_data_window): Simplify.
 735
 736 2019-06-25  Tom Tromey  <tom@tromey.com>
 737
 738         * tui/tui-layout.c (show_source_disasm_command)
 739         (show_source_or_disasm_and_command): Update.
 740         * tui/tui-io.c (update_cmdwin_start_line)
 741         (tui_redisplay_readline): Update.
 742         * tui/tui-data.h (struct tui_command_info): Remove.
 743         (struct tui_win_info) <detail>: Remove command_info member.
 744         (struct tui_data_window) <start_line>: New member, from
 745         tui_command_info.
 746         (TUI_CMD_WIN): Add casts.
 747
 748 2019-06-25  Tom Tromey  <tom@tromey.com>
 749
 750         * tui/tui-winsource.c (tui_update_source_window)
 751         (tui_refill_source_window)
 752         (tui_source_window_base::do_scroll_horizontal)
 753         (tui_update_breakpoint_info, tui_set_exec_info_content)
 754         (tui_show_exec_info_content, tui_erase_exec_info_content)
 755         (tui_clear_exec_info_content): Update.
 756         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 757         Update.
 758         * tui/tui-win.c (make_invisible_and_set_new_height)
 759         (make_visible_with_new_height): Update.
 760         * tui/tui-source.c (tui_set_source_content)
 761         (tui_show_symtab_source): Update.
 762         * tui/tui-layout.c (extract_display_start_addr)
 763         (show_source_disasm_command, show_data)
 764         (make_source_or_disasm_window)
 765         (show_source_or_disasm_and_command): Update.
 766         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 767         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 768         "gdbarch".
 769         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 770         to tui_source_window_base.
 771         (struct tui_win_info) <detail>: Remove source_info member.
 772         (struct tui_source_window_base) <has_locator>: Inline.
 773         Move contents from tui_source_info; rename has_locator member to
 774         m_has_locator.
 775         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 776         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 777         header file.
 778         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 779         Simplify.
 780         (tui_free_all_source_wins_content): Cast to
 781         tui_source_window_base.
 782
 783 2019-06-25  Tom Tromey  <tom@tromey.com>
 784
 785         * tui/tui-win.c (make_invisible_and_set_new_height)
 786         (make_visible_with_new_height): Call has_locator method.
 787         * tui/tui-layout.c (show_source_disasm_command, show_data)
 788         (show_source_or_disasm_and_command): Update for bool change.
 789         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 790         (tui_win_info) <has_locator>: New method.
 791         (struct tui_source_window_base) <has_locator>: New method.
 792         (tui_win_has_locator): Don't declare.
 793         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 794         from tui_win_has_locator.
 795         (tui_source_window_base): Use false, not FALSE.
 796
 797 2019-06-25  Tom Tromey  <tom@tromey.com>
 798
 799         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 800         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 801         clear_detail method directly.
 802         (tui_clear_win_detail): Remove.
 803
 804 2019-06-25  Tom Tromey  <tom@tromey.com>
 805
 806         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 807         "this", not TUI_DISASM_WIN.
 808
 809 2019-06-25  Tom Tromey  <tom@tromey.com>
 810
 811         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 812         declare.
 813         * tui/tui-winsource.c
 814         (tui_source_window_base::do_scroll_horizontal): Rename from
 815         tui_horizontal_source_scroll.
 816         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 817         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 818         from tui_vertical_data_scroll.
 819         * tui/tui-win.h (tui_scroll): Don't declare.
 820         * tui/tui-win.c (tui_win_info::forward_scroll)
 821         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 822         (tui_win_info::right_scroll): Rename and update.
 823         (tui_scroll_forward_command, tui_scroll_backward_command)
 824         (tui_scroll_left_command, tui_scroll_right_command): Update.
 825         (tui_scroll): Remove.
 826         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 827         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 828         from tui_vertical_source_scroll.
 829         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 830         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 831         from tui_vertical_disassem_scroll.
 832         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 833         do_scroll_horizontal>: New methods.
 834         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 835         Likewise.
 836         (struct tui_source_window_base): Add do_scroll_horizontal.
 837         (struct tui_source_window, struct tui_disasm_window): Add
 838         do_scroll_vertical.
 839         (struct tui_data_window, struct tui_cmd_window): Add
 840         do_scroll_horizontal and do_scroll_vertical.
 841         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 842
 843 2019-06-25  Tom Tromey  <tom@tromey.com>
 844
 845         * tui/tui-data.h (struct tui_source_window_base): New struct.
 846         (struct tui_source_window): Derive from tui_source_window_base.
 847         (struct tui_disasm_window): New struct.
 848         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 849         from tui_source_window::clear_detail.
 850         (tui_source_window_base): Rename from tui_source_window.
 851         (~tui_source_window_base): Rename from ~tui_source_window.
 852         (tui_alloc_win_info): Create a tui_disasm_window.
 853
 854 2019-06-25  Tom Tromey  <tom@tromey.com>
 855
 856         * tui/tui-data.h (struct tui_source_window)
 857         (struct tui_data_window): Declare destructors.
 858         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 859         destructors.
 860         (tui_win_info): Simplify.
 861
 862 2019-06-25  Tom Tromey  <tom@tromey.com>
 863
 864         * tui/tui-winsource.c (tui_display_main)
 865         (tui_update_source_windows_with_addr)
 866         (tui_update_all_breakpoint_info): Update.
 867         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 868         (new_height_ok, parse_scrolling_args): Update.
 869         * tui/tui-stack.c (tui_show_frame_info): Update.
 870         * tui/tui-data.h (struct tui_list): Remove.
 871         (tui_source_windows): Return a reference to a std::vector.
 872         * tui/tui-data.c (source_windows): Now a std::vector.
 873         (tui_source_windows): Change return type.
 874         (tui_clear_source_windows): Rewrite.
 875         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 876         (tui_free_all_source_wins_content): Rewrite.
 877
 878 2019-06-25  Tom Tromey  <tom@tromey.com>
 879
 880         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 881         (struct tui_data_window, struct tui_cmd_window): Declare
 882         clear_detail method.
 883         * tui/tui-data.c (tui_source_window::clear_detail)
 884         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 885         methods.
 886         (tui_clear_win_detail): Simplify.
 887
 888 2019-06-25  Tom Tromey  <tom@tromey.com>
 889
 890         * tui/tui-layout.c (make_source_window, make_disasm_window)
 891         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 892         Return the new window.
 893         (show_source_disasm_command, show_data)
 894         (show_source_or_disasm_and_command): Update.
 895
 896 2019-06-25  Tom Tromey  <tom@tromey.com>
 897
 898         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 899         parameter.  Return the new window.
 900         (show_source_disasm_command): Update and remove NULL check.
 901         (show_source_or_disasm_and_command): Update.
 902
 903 2019-06-25  Tom Tromey  <tom@tromey.com>
 904
 905         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 906
 907 2019-06-25  Tom Tromey  <tom@tromey.com>
 908
 909         * tui/tui-data.h (struct tui_win_info): Make constructor
 910         protected.  Make destructor virtual.  Add initializers.
 911         (tui_source_window, tui_data_window, tui_cmd_window): New
 912         classes.
 913         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 914         constructor.  Add "type" parameter.
 915         (tui_source_window, tui_data_window, tui_cmd_window): New
 916         constructors.
 917         (tui_alloc_win_info): Instantiate the appropriate subclass.
 918
 919 2019-06-25  Tom Tromey  <tom@tromey.com>
 920
 921         * tui/tui-win.c (tui_resize_all): Use delete.
 922         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 923         destructor.
 924         (tui_free_window): Don't declare.
 925         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 926         Update.
 927
 928 2019-06-25  Tom Tromey  <tom@tromey.com>
 929
 930         * tui/tui-data.h (struct tui_win_info): Add constructor.
 931         * tui/tui-data.c (tui_alloc_win_info): Use new.
 932         (tui_free_window): Use delete.
 933
 934 2019-06-22  Tom Tromey  <tom@tromey.com>
 935
 936         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 937         declare.
 938         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 939
 940 2019-06-22  Tom Tromey  <tom@tromey.com>
 941
 942         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 943         declare.
 944         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 945
 946 2019-06-22  Tom de Vries  <tdevries@suse.de>
 947
 948         * dwarf2read.c (create_addrmap_from_aranges)
 949         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 950         instead of '%zu'.
 951
 952 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 953
 954         * dwarf2read.h (dwarf2_section_info_def): Remove.
 955         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 956         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 957         std::vector<dwarf2_section_info>.
 958         (struct dwo_file) <~dwo_file>: Remove.
 959         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 960         types field.
 961         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 962         (dwarf2_read_debug_names): Likewise.
 963         (create_debug_types_hash_table): Change parameter type to
 964         array_view, adjust code accordingly.
 965         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 966         (partial_die_info::fixup): Likewise.
 967         (determine_prefix): Likewise.
 968         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 969
 970 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 971
 972         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 973         gdb_bfd_ref_ptr.
 974         <~dwo_file>: Remove call to gdb_bfd_unref.
 975         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 976         gdb_bfd_ref_ptr::get.
 977
 978 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 979
 980         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 981         type to htab_up.
 982         * dwarf2read.c (struct dwo_file): Initialize fields.
 983         <~dwo_file>: New.
 984         (free_dwo_file): Remove, move content to ~dwo_file.
 985         (struct dwo_file_deleter): Remove.
 986         (dwo_file_up>: Remove custom deleter.
 987         (free_dwo_files): Remove.
 988         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 989         dwo_files.
 990         (process_skeletonless_type_units): Call unique_ptr::get.
 991         (allocate_dwo_file_hash_table): Add deleter to created hash
 992         table.  Change return type to htab_up.
 993         (lookup_dwo_file_slot): Don't memset dwo_file, call
 994         unique_ptr::get.
 995         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 996         (create_dwo_unit_in_dwp_v2): Likewise.
 997         (open_and_init_dwo_file): Likewise.
 998         (free_dwo_file_from_slot): Remove.
 999
1000 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1001
1002         * dwarf2read.h (struct dwarf2_section_info) <readin,
1003         is_virtual>: Change type to bool.
1004         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1005         true instead of 1.
1006
1007 2019-06-19  Tom Tromey  <tom@tromey.com>
1008
1009         * tui/tui-data.h (tui_init_content_element): Don't declare.
1010
1011 2019-06-19  Tom Tromey  <tom@tromey.com>
1012
1013         * tui/tui-data.h (tui_init_win_info): Don't declare.
1014
1015 2019-06-19  Tom de Vries  <tdevries@suse.de>
1016
1017         * dwarf2read.h (abstract_to_concrete): Change type to
1018         std::unordered_map<sect_offset, std::vector<sect_offset>,
1019         gdb::hash_enum<sect_offset>>.
1020
1021 2019-06-19  Tom Tromey  <tromey@adacore.com>
1022
1023         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1024         EVAL_AVOID_SIDE_EFFECTS specially.
1025
1026 2019-06-19  Tom Tromey  <tromey@adacore.com>
1027
1028         * source-cache.c (highlighter): New global.
1029         (source_cache::get_source_lines): Create a highlighter on demand.
1030
1031 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1032
1033         * defs.h (deprecated_interactive_hook): Delete declaration.
1034         * interps.c (clear_interpreter_hooks): Remove use of
1035         deprecated_interactive_hook.
1036         * top.c (deprecated_interactive_hook): Delete definition.
1037         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1038
1039 2019-06-18  Tom de Vries  <tdevries@suse.de>
1040
1041         PR gdb/24515
1042         * dwarf2read.h (abstract_to_concrete): Change type from
1043         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1044         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1045         * dwarf2read.c (read_variable): Update.
1046         (dwarf2_fetch_die_loc_sect_off): Update.
1047
1048 2019-06-17  Tom de Vries  <tdevries@suse.de>
1049
1050         PR gdb/24617
1051         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1052         accessing parent[parent_len - 1].
1053
1054 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1055
1056         PR gdb/24364
1057         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1058         call dtrace_process_dof with NULL dof.
1059
1060 2019-06-16  Tom de Vries  <tdevries@suse.de>
1061
1062         PR gdb/24445
1063         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1064
1065 2019-06-16  Tom Tromey  <tom@tromey.com>
1066
1067         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1068         (make_all_visible): Use address of member.
1069
1070 2019-06-16  Tom Tromey  <tom@tromey.com>
1071
1072         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1073         (tui_free_window, free_content, free_content_elements): Remove
1074         unnecessary cast.
1075         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1076         cast.
1077         * tui/tui-regs.c (tui_show_register_group)
1078         (tui_display_registers_from, tui_display_reg_element_at_line):
1079         Remove unnecessary cast.
1080
1081 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1082
1083         * linux-nat.c (normal_mask): Delete.
1084         (_initialize_linux_nat): Don't initialise normal_mask.
1085
1086 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1087
1088         PR gdb/24445
1089         * dwarf-index-write.h (write_psymtabs_to_index): Add
1090         dwz_basename parameter.
1091         * dwarf-index-write.c (write_gdbindex): Move file writing to
1092         write_gdbindex_1.  Change return type void.
1093         (assert_file_size): Move up, remove filename parameter.
1094         (write_gdbindex_1): New function.
1095         (write_debug_names): Change return type to void, call
1096         assert_file_size.
1097         (struct index_wip_file): New struct.
1098         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1099         file logic to index_wip_file.  Write index for dwz file if
1100         needed.
1101         (save_gdb_index_command): Pass basename of dwz file, if present.
1102         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1103         build-id of dwz file, if present.
1104         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1105         (dwarf2_get_dwz_file): Likewise.
1106         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1107         (dwarf2_get_dwz_file): Likewise.
1108
1109 2019-06-16  Tom Tromey  <tom@tromey.com>
1110
1111         * coffread.c (process_coff_symbol): Use xstrdup.
1112         * value.c (create_internalvar): Use xstrdup.
1113
1114 2019-06-16  Tom Tromey  <tom@tromey.com>
1115
1116         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1117         * breakpoint.c (stopin_command, stopat_command)
1118         (until_break_command, decode_location_default): Remove unnecessary
1119         cast.
1120         * utils.c (subset_compare): Remove unnecessary cast.
1121         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1122         cast.
1123         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1124         cast.
1125         * infcmd.c (path_command): Remove unnecessary cast.
1126         * coffread.c (decode_type): Remove unnecessary cast.
1127         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1128         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1129         * tui/tui-stack.c (tui_show_locator_content)
1130         (tui_show_frame_info): Remove unnecessary cast.
1131         * tui/tui-win.c (tui_scroll_forward_command)
1132         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1133         (parse_scrolling_args): Remove unnecessary cast.
1134         * tui/tui-data.c (init_win_info, tui_del_window)
1135         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1136         (free_content_elements): Remove unnecessary cast.
1137         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1138         unnecessary cast.
1139         * tui/tui-source.c (tui_set_source_content)
1140         (tui_vertical_source_scroll): Remove unnecessary cast.
1141         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1142         cast.
1143         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1144         * tui/tui-regs.c (tui_display_registers_from)
1145         (tui_display_register): Remove unnecessary cast.
1146         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1147         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1148         (make_visible): Remove unnecessary cast.
1149         * tui/tui-winsource.c (tui_erase_source_content)
1150         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1151         unnecessary cast.
1152         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1153         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1154         * stabsread.c (read_type, read_array_type, read_range_type):
1155         Remove unnecessary cast.
1156         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1157         (parse_symbol, parse_type, upgrade_type, parse_external)
1158         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1159         unnecessary cast.
1160         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1161
1162 2019-06-16  Tom Tromey  <tom@tromey.com>
1163
1164         * tui/tui-data.c (tui_alloc_generic_win_info)
1165         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1166         checks.
1167
1168 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1169             Andrew Burgess  <andrew.burgess@embecosm.com>
1170
1171         * f-typeprint.c (f_print_type): Don't return early for not
1172         associated or not allocated types.
1173         (f_type_print_varspec_suffix): Add print_rank parameter and print
1174         ranks of array types in case they dangling.
1175         (f_type_print_base): Add print_rank parameter.
1176
1177 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1178
1179         * NEWS: Mention new MI commands.
1180         * break-catch-throw.c (enum exception_event_kind): Move to
1181         breakpoint.h.
1182         (print_mention_exception_catchpoint): Output text as a single
1183         message.
1184         (catch_exception_command_1): Rename to...
1185         (catch_exception_event): ...this, make non-static, update header
1186         command, and change some parameter types.
1187         (catch_catch_command): Update for changes to
1188         catch_exception_command_1.
1189         (catch_throw_command): Likewise.
1190         (catch_rethrow_command): Likewise.
1191         * breakpoint.c (enum exception_event_kind): Delete.
1192         * breakpoint.h (enum exception_event_kind): Moved here from
1193         break-catch-throw.c.
1194         (catch_exception_event): Declare.
1195         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1196         (mi_cmd_catch_throw): New function.
1197         (mi_cmd_catch_rethrow): New function.
1198         (mi_cmd_catch_catch): New function.
1199         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1200         'catch-catch' entries.
1201         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1202         (mi_cmd_catch_rethrow): Declare.
1203         (mi_cmd_catch_catch): Declare.
1204
1205 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1206
1207         * annotate.c (annotate_source_line): Change return type to void,
1208         update implementation to match.
1209         * annotate.h (annotate_source_line): Change return type to void,
1210         update header comment.
1211         * stack.c (print_frame_info): Don't change what frame information
1212         is printed based on whether annotations are on or not.
1213
1214 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1215
1216         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1217         (annotate_source): Make static.
1218         (annotate_source_line): Moved from source.c and renamed from
1219         identify_source_line.  Update the return type.
1220         * annotate.h (annotate_source): Delete declaration.
1221         (annotate_source_line): Declaration moved from source.h, and
1222         renamed from identify_source_line.  Return type updated.
1223         * source.c (identify_source_line): Moved to annotate.c and renamed
1224         to annotate_source_line.
1225         (info_line_command): Remove check of annotation_level.
1226         * source.h (identify_source_line): Move declaration to annotate.h
1227         and rename to annotate_source_line.
1228         * stack.c: Add 'annotate.h' include.
1229         (print_frame_info): Remove check of annotation_level before
1230         calling annotate_source_line.
1231
1232 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1233
1234         * source-cache.c (source_cache::get_plain_source_lines): Use
1235         open_source_file_with_line_charpos instead of just
1236         open_source_file, remove call to find_source_lines.
1237         (source_cache::get_source_lines): Likewise.
1238         * source.c (find_source_lines): Make static.
1239         (get_filename_and_charpos): Renamed into...
1240         (open_source_file_with_line_charpos): ..this along with changes to
1241         return a scoped_fd, and some other minor clean ups.
1242         (identify_source_line): Use open_source_file_with_line_charpos.
1243         (search_command_helper): Use open_source_file_with_line_charpos
1244         instead of just open_source_file, remove call to
1245         find_source_lines.
1246         * source.h (open_source_file_with_line_charpos): Declare new
1247         function.
1248         (find_source_lines): Delete declaration.
1249
1250 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1251
1252         * source.c (get_filename_and_charpos): Remove fullname
1253         parameter.
1254         (identify_source_line): Update call to get_filename_and_charpos.
1255
1256 2019-06-14  Tom Tromey  <tromey@adacore.com>
1257
1258         PR gdb/24502:
1259         * ui-style.h (skip_ansi_escape): Update comment.
1260         * ui-file.h (class no_terminal_escape_file): New class.
1261         * ui-file.c (no_terminal_escape_file::write)
1262         (no_terminal_escape_file::puts): New methods.
1263         * cli/cli-logging.c (handle_redirections): Use
1264         no_terminal_escape_file.
1265
1266 2019-06-14  Tom Tromey  <tromey@adacore.com>
1267
1268         * NEWS: Move convenience variable news above Python news.
1269
1270 2019-06-14  Tom Tromey  <tom@tromey.com>
1271
1272         * gnulib: Move directory to top-level.
1273         * configure.ac: Don't configure gnulib.
1274         * configure: Rebuild.
1275         * common/common-defs.h: Use new path to gnulib.
1276         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1277         (GNULIB_H): Remove.
1278         (INCGNU): Look in new gnulib location.
1279         (HFILES_NO_SRCDIR): Remove gnulib files.
1280         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1281         (generated_files): Remove GNULIB_H.
1282         ($(LIBGNU), all-lib): Remove targets.
1283         (distclean): Don't mention GNULIB_BUILDDIR.
1284         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1285
1286 2019-06-14  Tom Tromey  <tromey@adacore.com>
1287
1288         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1289         Warn if symbol file does not provide any symbols.
1290
1291 2019-06-14  Tom Tromey  <tromey@adacore.com>
1292
1293         * source.c (find_and_open_source): Respect basenames_may_differ.
1294
1295 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1296
1297         * annotate.c (annotate_breakpoints_invalid): Make use of
1298         scoped_restore_terminal_state.
1299         (annotate_frames_invalid): Likewise.
1300
1301 2019-06-14  Tom Tromey  <tromey@adacore.com>
1302
1303         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1304         allow assignment to an internalvar.
1305
1306 2019-06-14  Tom Tromey  <tromey@adacore.com>
1307
1308         * ada-lex.l: Allow "_" in attribute names.
1309
1310 2019-06-14  Tom Tromey  <tromey@adacore.com>
1311
1312         PR gdb/24653:
1313         * regcache.c (registers_changed): Don't call alloca.
1314         * top.c (execute_command): Don't call alloca.
1315
1316 2019-06-13  Pedro Alves  <palves@redhat.com>
1317
1318         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1319         'expression'.  When parsing an expression, error out if there's
1320         junk after "unlimited".
1321         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1322         (do_set_command): Adjust calls to is_unlimited_literal.
1323
1324 2019-06-13  Pedro Alves  <palves@redhat.com>
1325
1326         * compile/compile.c (make_compile_options_def_group): Add braces
1327         around array_view initializer.
1328         * thread.c (make_thread_apply_all_options_def_group)
1329         (make_thread_apply_all_options_def_group): Likewise.
1330
1331 2019-06-13  Pedro Alves  <palves@redhat.com>
1332
1333         * NEWS (New commands): Mention "maint test-options
1334         require-delimiter", "maint test-options unknown-is-error", "maint
1335         test-options unknown-is-operand" and "maint show
1336         test-options-completion-result".
1337         (New command options, command completion): New section.
1338         (Completion improvements): New section.
1339         Mention that you can abbreviate "unlimited".
1340
1341 2019-06-13  Pedro Alves  <palves@redhat.com>
1342
1343         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1344         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1345         * unittests/cli-utils-selftests.c (test_parse_flags)
1346         (test_parse_flags_qcs): Delete.
1347         (test_cli_utils): Don't call deleted functions.
1348
1349 2019-06-13  Pedro Alves  <palves@redhat.com>
1350
1351         * thread.c: Include "cli/cli-option.h".
1352         (tp_array_compar_ascending): Global.
1353         (tp_array_compar): Delete function.
1354         (tp_array_compar_ascending, tp_array_compar_descending): New
1355         functions.
1356         (ascending_option_def, qcs_flag_option_def)
1357         (thr_qcs_flags_option_defs)
1358         (make_thread_apply_all_options_def_group)
1359         (make_thread_apply_options_def_group): New.
1360         (thread_apply_all_command): Use gdb::option::process_options.
1361         (thread_apply_command_completer)
1362         (thread_apply_all_command_completer): New.
1363         (thread_apply_command): Use gdb::option::process_options.
1364         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1365         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1366         to generate help text of "thread apply".  Adjust "taas"'s help.
1367         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1368         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1369
1370 2019-06-13  Pedro Alves  <palves@redhat.com>
1371
1372         * thread.c (thread_apply_command): Check for invalid TID with
1373         isdigit instead of !isalpha.
1374
1375 2019-06-13  Pedro Alves  <palves@redhat.com>
1376
1377         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1378         (validate_flags_qcs): New.
1379         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1380         (validate_flags_qcs): Declare.
1381         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1382         (make_frame_apply_options_def_group): New.
1383         (frame_apply_command_count): Process options with
1384         gdb::option::process_options.
1385         (frame_apply_completer): New.
1386         (frame_apply_level_completer, frame_apply_all_completer)
1387         (frame_apply_completer): New.
1388         (_initialize_stack): Update help of "frame apply", "frame apply
1389         level", "frame apply all" and "faas" to mention supported options
1390         and install command completers.
1391         * stack.h (frame_apply_all_completer): Declare.
1392         * thread.c: Include "stack.h".
1393         (tfaas_command): Add "--".
1394         (_initialize_thread): Update help "tfaas" to mention supported
1395         options and install command completer.
1396
1397 2019-06-13  Pedro Alves  <palves@redhat.com>
1398
1399         * completer.c (complete_nested_command_line): New.
1400         (gdb_completion_word_break_characters_throw): Add assertion.
1401         * completer.h (complete_nested_command_line): Declare.
1402
1403 2019-06-13  Pedro Alves  <palves@redhat.com>
1404
1405         * stack.c (parse_backtrace_qualifiers): New.
1406         (backtrace_command): Use it.
1407         (backtrace_command_completer): Complete on qualifiers.
1408
1409 2019-06-13  Pedro Alves  <palves@redhat.com>
1410
1411         * frame.c: Include "cli/cli-option.h.
1412         (user_set_backtrace_options): New.
1413         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1414         Delete.
1415         (get_prev_frame): Adjust.
1416         (boolean_option_def, uinteger_option_def)
1417         (set_backtrace_option_defs): New.
1418         (_initialize_frame): Adjust and use
1419         gdb::option::add_setshow_cmds_for_options to install "set
1420         backtrace past-main" and "set backtrace past-entry".
1421         * frame.h: Include "cli/cli-option.h".
1422         (struct frame_print_options): Forward declare.
1423         (print_frame_arguments_all, print_frame_arguments_scalars)
1424         (print_frame_arguments_none): Declare.
1425         (print_entry_values): Delete declaration.
1426         (struct frame_print_options, user_frame_print_options): New.
1427         (struct set_backtrace_options): New.
1428         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1429         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1430         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1431         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1432         (list_args_or_locals): Add frame_print_options parameter.
1433         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1434         * python/py-framefilter.c (enumerate_args): Pass down
1435         USER_FRAME_PRINT_OPTIONS.
1436         * stack.c: Include "cli/cli-option.h".
1437         (print_frame_arguments_all, print_frame_arguments_scalars)
1438         (print_frame_arguments_none): Declare.
1439         (print_raw_frame_arguments, print_entry_values): Delete.
1440         (user_frame_print_options): New.
1441         (boolean_option_def, enum_option_def, frame_print_option_defs):
1442         New.
1443         (struct backtrace_cmd_options): New.
1444         (bt_flag_option_def): New.
1445         (backtrace_command_option_defs): New.
1446         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1447         (print_frame_arg, read_frame_arg, print_frame_args)
1448         (print_frame_info, print_frame): Add frame_print_options parameter
1449         and use it.
1450         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1451         (backtrace_command_1): Add frame_print_options and
1452         backtrace_cmd_options parameters and use them.
1453         (make_backtrace_options_def_group): New.
1454         (backtrace_command): Process command options with
1455         gdb::option::process_options.
1456         (backtrace_command_completer): New.
1457         (_initialize_stack): Extend "backtrace"'s help to mention
1458         supported options.  Install completer for "backtrace".
1459         Install some settings commands with add_setshow_cmds_for_options.
1460
1461 2019-06-13  Pedro Alves  <palves@redhat.com>
1462
1463         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1464         and that "set/show print raw frame-arguments" are now deprecated.
1465
1466         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1467         command.
1468         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1469         * stack.c (_initialize_stack): Install "set/show print
1470         raw-frame-arguments", and deprecate "set/show print raw
1471         frame-arguments".
1472         * valprint.c (_initialize_valprint): Deprecate "set/show print
1473         raw".
1474
1475 2019-06-13  Pedro Alves  <palves@redhat.com>
1476
1477         * compile/compile.c (struct compile_options): New.
1478         (compile_flag_option_def, compile_command_option_defs)
1479         (make_compile_options_def_group): New.
1480         (compile_file_command): Handle options with
1481         gdb::option::process_options.
1482         (compile_file_command_completer): New function.
1483         (compile_code_command): Handle options with
1484         gdb::option::process_options.
1485         (compile_code_command_completer): New function.
1486         (_initialize_compiler): Install completers for "compile code" and
1487         "compile file".  Mention available options in "compile code" and
1488         "compile code"'s help.
1489         * completer.c (advance_to_completion_word): New, factored out from
1490         ...
1491         (advance_to_expression_complete_word_point): ... this.
1492         (advance_to_filename_complete_word_point): New.
1493         * completer.h (advance_to_filename_complete_word_point): New
1494         declaration.
1495
1496 2019-06-13  Pedro Alves  <palves@redhat.com>
1497
1498         * compile/compile.c: Include "cli/cli-option.h".
1499         (compile_print_value): Scope data pointer is now a
1500         value_print_options pointer; adjust.
1501         (compile_print_command): Process options.  Scope data pointer is
1502         now a value_print_options pointer; adjust.
1503         (_initialize_compile): Update "compile print"'s help to include
1504         supported options.  Install a completer for "compile print".
1505         * cp-valprint.c (show_vtblprint, show_objectprint)
1506         (show_static_field_print): Delete.
1507         (_initialize_cp_valprint): Don't install "set print
1508         static-members", "set print vtbl", "set print object" here.
1509         * printcmd.c: Include "cli/cli-option.h" and
1510         "common/gdb_optional.h".
1511         (print_command_parse_format): Rework to fill in a
1512         value_print_options instead of a format_data.
1513         (print_value): Change parameter type from format_data pointer to
1514         value_print_options reference.  Adjust.
1515         (print_command_1): Process options.  Adjust to pass down a
1516         value_print_options.
1517         (print_command_completer): New.
1518         (_initialize_printcmd): Install print_command_completer as
1519         handle_brkchars completer for the "print" command.  Update
1520         "print"'s help to include supported options.
1521         * valprint.c: Include "cli/cli-option.h".
1522         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1523         here from cp-valprint.c.
1524         (boolean_option_def, uinteger_option_def)
1525         (value_print_option_defs, make_value_print_options_def_group):
1526         New.  Use gdb::option::add_setshow_cmds_for_options to install
1527         "set print elements", "set print null-stop", "set print repeats",
1528         "set print pretty", "set print union", "set print array", "set
1529         print address", "set print symbol", "set print array-indexes".
1530         * valprint.h: Include <string> and "cli/cli-option.h".
1531         (make_value_print_options_def_group): Declare.
1532         (print_value): Change parameter type from format_data pointer to
1533         value_print_options reference.
1534         (print_command_completer): Declare.
1535
1536 2019-06-13  Pedro Alves  <palves@redhat.com>
1537
1538         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1539         (COMMON_SFILES): Add maint-test-settings.c.
1540         * cli/cli-decode.c (boolean_enums): New global, factored out from
1541         ...
1542         (add_setshow_boolean_cmd): ... here.
1543         * cli/cli-decode.h (boolean_enums): Declare.
1544         * cli/cli-option.c: New file.
1545         * cli/cli-option.h: New file.
1546         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1547         factored out from ...
1548         (parse_cli_boolean_value(const char *)): ... this.
1549         (is_unlimited_literal): Change parameter type to pointer to
1550         pointer.  Adjust and advance ARG pointer.
1551         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1552         (parse_cli_var_enum): New, factored out from ...
1553         (do_set_command): ... this.  Adjust.
1554         * cli/cli-setshow.h (parse_cli_boolean_value)
1555         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1556         (parse_cli_var_enum): Declare.
1557         * cli/cli-utils.c: Include "cli/cli-option.h".
1558         (get_ulongest): New.
1559         * cli/cli-utils.h (get_ulongest): Declare.
1560         (check_for_argument): New overloads.
1561         * maint-test-options.c: New file.
1562
1563 2019-06-13  Pedro Alves  <palves@redhat.com>
1564
1565         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1566         parse a range if "-" is at the end of the string.
1567
1568 2019-06-13  Pedro Alves  <palves@redhat.com>
1569
1570         * cli/cli-setshow.c (parse_auto_binary_operation)
1571         (parse_cli_boolean_value): Don't allow "o".
1572
1573 2019-06-13  Pedro Alves  <palves@redhat.com>
1574
1575         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1576         * NEWS: Mention maint test-settings KIND.
1577         * maint-test-settings.c: New file.
1578
1579 2019-06-13  Pedro Alves  <palves@redhat.com>
1580
1581         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1582         completer.
1583         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1584         "set" completers.
1585
1586 2019-06-13  Pedro Alves  <palves@redhat.com>
1587
1588         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1589         after item.
1590
1591 2019-06-13  Pedro Alves  <palves@redhat.com>
1592
1593         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1594
1595 2019-06-13  Pedro Alves <palves@redhat.com>
1596
1597         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1598         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1599         call.
1600         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1601         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1602         calls.
1603         (check_for_argument): Skip spaces after argument.
1604
1605 2019-06-13  Pedro Alves  <palves@redhat.com>
1606
1607         * thread.c (thread_apply_command): Adjust TID parsing.
1608         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1609         detected before end of string.
1610         (tid_is_in_list): Error out if LIST is invalid.
1611
1612 2019-06-13  Pedro Alves  <palves@redhat.com>
1613
1614         * completer.c (complete_line_internal_1): Rewind completion word
1615         point.
1616         (completion_tracker::advance_custom_word_point_by): Change
1617         parameter type to int.
1618         * completer.h (completion_tracker::advance_custom_word_point_by):
1619         Likewise.
1620
1621 2019-06-13  Pedro Alves  <palves@redhat.com>
1622
1623         * completer.c (advance_to_completion_word): Handle delimiters.
1624
1625 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1626
1627         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1628
1629 2019-06-11  Tom Tromey  <tom@tromey.com>
1630
1631         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1632         (xmalloc_failed): Move to alloc.c.
1633         * alloc.c: New file.
1634         * Makefile.in (COMMON_SFILES): Add alloc.c.
1635
1636 2019-06-11  Tom Tromey  <tom@tromey.com>
1637
1638         * nat/linux-waitpid.c: Don't include server.h.
1639         (linux_debug): Remove.
1640         (my_waitpid): Update.
1641
1642 2019-06-11  Tom Tromey  <tromey@adacore.com>
1643
1644         * infcall.c (_initialize_infcall): Remove trailing newline from
1645         help.
1646         * user-regs.c (_initialize_user_regs): Remove trailing newline
1647         from help.
1648         * typeprint.c (_initialize_typeprint): Remove trailing newline
1649         from help.
1650         * reverse.c (_initialize_reverse): Remove trailing newlines from
1651         help.
1652         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1653         from help.
1654         * language.c (add_set_language_command): Remove trailing newline
1655         from help.
1656         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1657         help.
1658         * disasm.c (_initialize_disasm): Remove trailing newline from
1659         help.
1660         * top.c (init_main): Remove trailing newline from help.
1661         * interps.c (_initialize_interpreter): Remove trailing newline
1662         from help.
1663         * btrace.c (_initialize_btrace): Remove trailing newlines from
1664         help.
1665         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1666         from help.
1667         * python/python.c (_initialize_python): Remove trailing newline
1668         from help.
1669         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1670         help.
1671         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1672         from help.  Reformat some text.
1673         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1674         from help.
1675         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1676         newline from help.
1677
1678 2019-06-11  Tom Tromey  <tromey@adacore.com>
1679
1680         * darwin-nat.c (darwin_decode_exception_message)
1681         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1682
1683 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1684
1685         * valops.c (value_slice): Check for not allocated or not
1686         associated values.
1687
1688 2019-06-10  Tom de Vries  <tdevries@suse.de>
1689
1690         PR gdb/24618
1691         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1692         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1693         invalid.
1694
1695 2019-06-10  Tom de Vries  <tdevries@suse.de>
1696
1697         PR gdb/24611
1698         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1699         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1700
1701 2019-06-10  Tom de Vries  <tdevries@suse.de>
1702
1703         PR symtab/24545
1704         * symtab.c (struct demangled_name_entry): Add language field.
1705         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1706         static minimal symbol".  Set and use language field.
1707
1708 2019-06-10  Tom Tromey  <tromey@adacore.com>
1709
1710         * ada-lang.c (_initialize_ada_language): Update help text.
1711
1712 2019-06-10  Tom Tromey  <tromey@adacore.com>
1713
1714         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1715         with a newline.
1716         * guile/guile.c (handle_boot_error): Don't end warning with a
1717         newline.
1718         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1719         warning with a newline.
1720         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1721         newline.
1722         (s12z_frame_cache): Likewise.
1723         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1724         a newline.
1725         * solib-svr4.c (disable_probes_interface): Don't end warning with
1726         a newline.
1727         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1728         newline.
1729         * python/python.c (do_finish_initialization): Don't end warning
1730         with a newline.
1731
1732 2019-06-10  Tom Tromey  <tom@tromey.com>
1733
1734         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1735         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1736         gdbpy_enter.
1737
1738 2019-06-10  Tom Tromey  <tromey@adacore.com>
1739
1740         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1741         data.
1742         (elf_new_init): Don't call stabsread_new_init.
1743         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1744         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1745         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1746
1747 2019-06-10  Tom de Vries  <tdevries@suse.de>
1748
1749         PR symtab/16264
1750         PR symtab/24517
1751         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1752
1753 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1754
1755         * source.c (find_and_open_source): Also rewrite relative file
1756         names.
1757
1758 2019-04-26  Amos Bird  <amosbird@gmail.com>
1759
1760         * annotate.c (annotate_thread_exited): Add "thread-exited"
1761         annotation.
1762
1763 2019-06-06  Tom Tromey  <tromey@adacore.com>
1764
1765         * maint.h (class scoped_command_stats): Use
1766         DISABLE_COPY_AND_ASSIGN.
1767         <print_time>: New method.
1768         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1769         print_time.
1770         (scoped_command_stats::print_time): New method.
1771
1772 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1773
1774         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1775         instructions of lengths 6 or 8 bytes.
1776
1777 2019-06-04  Pedro Alves  <palves@redhat.com>
1778
1779         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1780
1781         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1782         * breakpoint.c (condition_completer): Likewise.
1783         * cli/cli-dump.c (scan_expression): Likewise.
1784         * common/filestuff.c (mkdir_recursive): Likewise.
1785         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1786         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1787         (gdb_abspath): Likewise.
1788         * compile/compile-cplus-types.c
1789         (compile_cplus_instance::decl_name): Likewise.
1790         * completer.c (complete_explicit_location):
1791         (signal_completer, reg_or_group_completer_1): Likewise.
1792         * cp-support.c (cp_remove_params_if_any): Likewise.
1793         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1794         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1795         * infcmd.c (strip_bg_char): Likewise.
1796         * linespec.c (copy_token_string): Likewise.
1797         * mi/mi-main.c (output_cores): Likewise.
1798         * psymtab.c (psymtab_search_name):
1799         * symfile.c (test_set_ext_lang_command): Likewise.
1800         * target.c (target_fileio_read_stralloc): Likewise.
1801         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1802         * value.c (complete_internalvar): Likewise.
1803
1804 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1805
1806         Add objfile property to gdb.Type.
1807         * NEWS: Mention Python API addition.
1808         * python/py-type.c (typy_get_objfile): New method.
1809
1810 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1811
1812         * NEWS: Mention the new set|show style [title|highlight].
1813         Mention changes to "show style", "help" and "apropos".
1814
1815 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1816
1817         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1818         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1819         instead of print_help_for_command.
1820         (print_doc_of_command): New function.
1821         (help_list): Add 'apropos -v word' suggestion.
1822         (print_help_for_command): Style the command name using title style.
1823         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1824         (_initialize_cli_cmds): Describe -v in apropos_command help.
1825
1826 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1827
1828         * cli/cli-style.h (cli_style_option): Add name in constructor,
1829         add m_name class member, add constructor with intensity,
1830         add name class function.
1831         (cli_style_option::add_setshow_commands): Remove name argument.
1832         (highlight_style, title_style): New styles.
1833         * cli/cli-style.c (do_show): New function that shows a style
1834         characteristic styling the style name with itself.
1835         (set_style_name): New function.
1836         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1837         Update all callers according to the changes in cli/cli-style.h.
1838         * utils.h (fputs_highlighted): New function.
1839         * utils.c (fputs_highlighted): Likewise.
1840
1841 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1842
1843         * NEWS: Mention new pipe command and new convenience variables.
1844
1845 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1846
1847         * cli/cli-cmds.c (pipe_command): New function.
1848         (_initialize_cli_cmds): Call add_com for pipe_command.
1849         Define | as an alias for pipe.
1850         (exit_status_set_internal_vars): New function.
1851         (shell_escape): Call exit_status_set_internal_vars.
1852         cli/cli-decode.c (find_command_name_length): Recognize | as
1853         a single character command.
1854
1855 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1856
1857         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1858         top.c (execute_command_to_ui_file): New function, mostly a copy
1859         of execute_command_to_string.
1860         (execute_command_to_string): Implement by calling
1861         execute_command_to_ui_file.
1862
1863 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1864
1865         * top.h (saved_command_line): Remove declaration.
1866         * top.c (previous_saved_command_line, previous_repeat_arguments):
1867         New variables.
1868         (saved_command_line): Make static, define together with other
1869         'repeat variables'.
1870         (dont_repeat): Clear repeat_arguments.
1871         (repeat_previous, get_saved_command_line, save_command_line):
1872         New functions.
1873         (gdb_init): Initialize saved_command_line
1874         and previous_saved_command_line.
1875         * main.c (captured_main_1): Remove saved_command_line initialization.
1876         * event-top.c (handle_line_of_input): Update to use
1877         the new 'repeat' related functions instead of direct access to
1878         saved_command_line.
1879         * command.h (repeat_previous, get_saved_command_line,
1880         save_command_line): New declarations.
1881         (dont_repeat): Add comment.
1882
1883 2019-05-30  Tom Tromey  <tromey@adacore.com>
1884
1885         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1886         Fix comment.
1887         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1888
1889 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1890
1891         PR cli/24587
1892         * completer.c (complete): Initialize variable word.
1893
1894 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1895
1896         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1897         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1898         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1899         'body' is NULL to the outter 'if', protecting the '!is_define'
1900         situation as well.
1901
1902 2019-05-29  Tom Tromey  <tromey@adacore.com>
1903
1904         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1905         (dwarf_unknown): New function.
1906         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1907         (dwarf_type_encoding_name): Use dwarf_unknown.
1908
1909 2019-05-29  Tom Tromey  <tromey@adacore.com>
1910
1911         PR c++/20020:
1912         * cp-valprint.c (cp_print_value_fields): Call
1913         cp_print_static_field inside "try".
1914
1915 2019-05-29  Tom Tromey  <tromey@adacore.com>
1916
1917         * inflow.c (struct terminal_info): Add default operator=.
1918         * configure: Rebuild.
1919         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1920         -Wdeprecated-copy-dtor, -Wredundant-move.
1921
1922 2019-05-29  Tom Tromey  <tromey@adacore.com>
1923
1924         * NEWS: Add entry.
1925         * infcmd.c (print_return_value_1): Handle finish_print
1926         option.
1927         (show_print_finish): New function.
1928         (_initialize_infcmd): Add "set/show print finish" commands.
1929         * valprint.c (user_print_options): Initialize new member.
1930         * valprint.h (struct value_print_options) <finish_print>: New
1931         member.
1932
1933 2019-05-28  Tom Tromey  <tromey@adacore.com>
1934
1935         * ada-lang.c (ada_remove_Xbn_suffix)
1936         (find_old_style_renaming_symbol)
1937         (parse_old_style_renaming): Remove.
1938         (ada_find_renaming_symbol): Don't call
1939         find_old_style_renaming_symbol.
1940         (ada_is_renaming_symbol): Rename from
1941         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1942         bool.  Now static.
1943         (ada_read_var_value): Update and simplify.
1944         * ada-exp.y (write_var_or_type): Remove old code.
1945
1946 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1947
1948         * event-top.c: Remove include comment.
1949         * inflow.c (class scoped_ignore_sigttou): Move from here...
1950         * inflow.h (class scoped_ignore_sigttou): ...to here.
1951         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1952         * top.c:  Remove include comment.
1953
1954 2019-05-27  Tom Tromey  <tom@tromey.com>
1955
1956         * NEWS: Fix typo.
1957
1958 2019-05-22  Tom Tromey  <tromey@adacore.com>
1959
1960         * target.c (target_follow_exec): Constify parameter.
1961         * target-delegates.c: Rebuild.
1962         * remote.c (remote_target::follow_exec): Constify parameter.
1963         * infrun.c (follow_exec): Constify parameter.
1964         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1965         (target_follow_exec): Likewise.
1966
1967 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1968
1969         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1970         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1971
1972 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1973
1974         * NEWS: Add debugredirect and testsuite sections.
1975
1976 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1977
1978         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1979         target descriptions using exclusively floating point register name
1980         aliases.
1981
1982 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1983
1984         PR gdb/18644:
1985         * f-lang.c (build_fortran_types): Handle the case where
1986         gdbarch_floatformat_for_type returns a nullptr.
1987
1988 2019-05-21  Tom de Vries  <tdevries@suse.de>
1989
1990         PR cli/24587
1991         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1992
1993 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1994
1995         PR gdb/18644:
1996         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1997         16-byte floats.
1998         * i386-tdep.c (i386_floatformat_for_type): Use
1999         floatformats_ia64_quad for the 16-byte floating point component
2000         within a fortran 32-byte complex number.
2001
2002 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2003
2004         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2005         delete default constructor.
2006         (find_partial_die): Update to return const struct.
2007         (partial_die_parent_scope): Move variable declaration into scope
2008         of its use and change its type to auto.
2009         (guess_partial_die_structure_name): Likewise.
2010         (partial_die_info::fixup): Likewise.
2011
2012 2019-05-17  Tom Tromey  <tromey@adacore.com>
2013
2014         * source.c (find_and_open_source): Remove cast.
2015
2016 2019-05-17  Tom Tromey  <tromey@adacore.com>
2017
2018         * annotate.c (annotate_source): Make "filename" const.
2019         * annotate.h (annotate_source): Use const.
2020
2021 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2022
2023         * disasm.c (set_disassembler_options): Send errors to stderr.
2024
2025 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2026
2027         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2028         (cli_interp_base::set_logging): Check debug_redirect.
2029         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2030         * cli/cli-logging.c (debug_redirect): Add static variable.
2031         (pop_output_files): Add default param.
2032         (handle_redirections): Print debug setting.
2033         (show_logging_command): Likewise.
2034         (_initialize_cli_logging): Add debugredirect command.
2035         * interps.c (current_interp_set_logging): Add debug_redirect
2036         parameter.
2037         * interps.h (set_logging): Add debug_redirect parameter.
2038         (current_interp_set_logging): Likewise.
2039         * mi/mi-common.h: Likewise.
2040         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2041
2042 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2043             Tom Tromey  <tromey@adacore.com>
2044
2045         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2046         directly.
2047         * cli/cli-interp.h (make_logging_output): Remove declaration.
2048         * cli/cli-logging.c (make_logging_output): Remove function.
2049         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2050         directly.
2051         * ui-file.c (tee_file::tee_file): Remove bools.
2052         (tee_file::~tee_file): Remove deletes.
2053         * ui-file.h (tee_file): Remove bools.
2054
2055 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2056
2057         * mi/mi-cmds.h (mi_cmd_complete): New function.
2058         * mi/mi-main.c (mi_cmd_complete): Likewise.
2059         * mi/mi-cmds.c: Define new MI command -complete.
2060         * NEWS: Mention new -complete command.
2061
2062 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2063
2064         * completer.h (complete): New function.
2065         * completer.c (complete): Likewise.
2066         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2067         function defined in completer.h.
2068
2069 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2070
2071         * MAINTAINERS (Write After Approval): Add myself.
2072
2073 2019-05-17  Tom de Vries  <tdevries@suse.de>
2074
2075         PR gdb/24094
2076         * dwarf2read.c (struct cu_partial_die_info): New struct.
2077         (find_partial_die): Return cu_partial_die_info.
2078         (partial_die_parent_scope, guess_partial_die_structure_name)
2079         (partial_die_info::fixup): Handle new return type of find_partial_die.
2080
2081 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2082
2083         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2084         "std::string", simplifying the algorithm.
2085
2086 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2087
2088         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2089         (stap_static_probe_ops::get_probes): Likewise.
2090
2091 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2092
2093         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2094         '-')" and "else if".
2095         (stap_parse_single_operand): Join checks for
2096         "gdbarch_stap_parse_special_token_p" and
2097         "gdbarch_stap_parse_special_token" in the same "if" statement.
2098         Invert check when verifying for operation on register
2099         displacement.
2100
2101 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2102
2103         * stap-probe.c (stap_get_opcode): Update comment.
2104         (stap_get_expected_argument_type): Likewise.
2105         (handle_stap_probe): Likewise.
2106
2107 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2108
2109         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2110         return type to 'bool'.  Adjust comment.  Use 'bool' when
2111         appropriate.
2112         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2113         * stap-probe.c (stap_parse_argument_1): Likewise.
2114         (stap_is_operator): Likewise.
2115         (stap_is_generic_prefix): Likewise.
2116         (stap_is_register_prefix): Likewise.
2117         (stap_is_register_indirection_prefix): Likewise.
2118         (stap_is_integer_prefix): Likewise.
2119         (stap_generic_check_suffix): Likewise.
2120         (stap_check_integer_suffix): Likewise.
2121         (stap_check_register_suffix): Likewise.
2122         (stap_check_register_indirection_suffix): Likewise.
2123         (stap_parse_register_operand): Likewise.
2124         (stap_parse_single_operand): Likewise.
2125         (stap_parse_argument_1): Likewise.
2126         (stap_probe::get_argument_count): Likewise.
2127         (stap_is_operator): Likewise.
2128
2129 2019-05-16  Tom Tromey  <tromey@adacore.com>
2130
2131         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2132         keyword to foreach.
2133
2134 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2135
2136         * linux-thread-db.c (try_thread_db_load_1): Change return type
2137         to bool.
2138         (try_thread_db_load): Likewise.
2139         (try_thread_db_load_from_pdir_1): Likewise.
2140         (try_thread_db_load_from_pdir): Likewise.
2141         (try_thread_db_load_from_sdir): Likewise.
2142         (try_thread_db_load_from_dir): Likewise.
2143         (thread_db_load_search): Likewise.
2144         (has_libpthread): Likewise.
2145         (thread_db_load): Likewise.
2146
2147 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2148
2149         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2150         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2151         NULL, and complain/return if that's the case.
2152
2153 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2154
2155         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2156         (advance, posn, abstract_read_memory): New functions.
2157         [struct mem_read_abstraction]: New struct.
2158         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2159
2160 2019-05-14  Tom Tromey  <tromey@adacore.com>
2161
2162         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2163         value is not lval_memory.
2164
2165 2019-05-14  Tom Tromey  <tromey@adacore.com>
2166
2167         * solib.c (info_sharedlibrary_command): Style the file name.
2168
2169 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2170
2171         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2172         (aarch64_vnv_type): Likewise.
2173         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2174         * common/tdesc.c: Likewise.
2175         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2176         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2177         * features/aarch64-fpu.xml: Add ieee half view.
2178         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2179         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2180         * gdbtypes.h (struct builtin_type): Likewise.
2181         (struct objfile_type): Likewise.
2182
2183 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2184
2185         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2186         typo.
2187         * location.h (string_to_event_location): Likewise.
2188
2189 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2190
2191         GDB 8.3 released.
2192
2193 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2194
2195         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2196         New variable declaration.
2197         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2198         New variable.
2199         (print_one_breakpoint): Use ui_out::test_flags and new global
2200         variable to compute use_fixed_output.
2201         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2202         Remove.
2203         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2204         (mi_multi_location_breakpoint_output_fixed): Remove.
2205         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2206         new variable.
2207         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2208         fix_multi_location_breakpoint_output flag if version >= 3.
2209         * ui-out.h (enum ui_out_flag)
2210         <fix_multi_location_breakpoint_output>: New enumerator.
2211
2212 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2213
2214         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2215
2216 2019-05-10  Tom Tromey  <tromey@adacore.com>
2217
2218         * ada-lang.c (catch_ada_completer): New function.
2219         (_initialize_ada_language): Use it.
2220
2221 2019-05-10  Tom Tromey  <tromey@adacore.com>
2222
2223         * thread.c (print_thread_info): Make "requested_threads" const.
2224         * gdbthread.h (print_thread_info): Make "requested_threads"
2225         const.
2226         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2227         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2228
2229 2019-05-08  Tom Tromey  <tom@tromey.com>
2230
2231         * gdbtypes.c (objfile_type_data): Change type.
2232         (objfile_type, _initialize_gdbtypes): Update.
2233
2234 2019-05-08  Tom Tromey  <tom@tromey.com>
2235
2236         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2237         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2238         (_initialize_dwarf2_frame): Update.
2239
2240 2019-05-08  Tom Tromey  <tom@tromey.com>
2241
2242         * objc-lang.c (objc_objfile_data): Change type.
2243         (find_methods): Update.
2244         (_initialize_objc_lang): Remove.
2245
2246 2019-05-08  Tom Tromey  <tom@tromey.com>
2247
2248         * stabsread.c (rs6000_builtin_type_data): Change type.
2249         (rs6000_builtin_type, _initialize_stabsread): Update.
2250
2251 2019-05-08  Tom Tromey  <tom@tromey.com>
2252
2253         * mips-tdep.c (mips_pdr_data): Remove.
2254         (_initialize_mips_tdep): Update.
2255
2256 2019-05-08  Tom Tromey  <tom@tromey.com>
2257
2258         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2259         (hppa_init_objfile_priv_data, read_unwind_info)
2260         (find_unwind_entry, _initialize_hppa_tdep): Update.
2261
2262 2019-05-08  Tom Tromey  <tom@tromey.com>
2263
2264         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2265         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2266         on obstack.
2267         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2268
2269 2019-05-08  Tom Tromey  <tom@tromey.com>
2270
2271         * mdebugread.c (basic_type_data): Change type.
2272         (basic_type, _initialize_mdebugread): Update.
2273
2274 2019-05-08  Tom Tromey  <tom@tromey.com>
2275
2276         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2277
2278 2019-05-08  Tom Tromey  <tom@tromey.com>
2279
2280         * nto-tdep.c (nto_inferior_data_reg): Change type.
2281         (nto_inferior_data): Update.
2282         (nto_inferior_data_cleanup, nto_new_inferior_data)
2283         (_initialize_nto_tdep): Remove.
2284         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2285
2286 2019-05-08  Tom Tromey  <tom@tromey.com>
2287
2288         * ada-lang.c (struct ada_inferior_data): Add initializers.
2289         (ada_inferior_data): Change type.
2290         (ada_inferior_data_cleanup): Remove.
2291         (get_ada_inferior_data, ada_inferior_exit)
2292         (struct ada_pspace_data): Add initializers, destructor.
2293         (ada_pspace_data_handle): Change type.
2294         (get_ada_pspace_data): Update.
2295         (ada_pspace_data_cleanup): Remove.
2296
2297 2019-05-08  Tom Tromey  <tom@tromey.com>
2298
2299         * coffread.c (struct coff_symfile_info): Add initializers.
2300         (coff_objfile_data_key): Move lower.  Change type.
2301         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2302         Update.
2303         (coff_free_info): Remove.
2304
2305 2019-05-08  Tom Tromey  <tom@tromey.com>
2306
2307         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2308         (fbsd_pspace_data_handle): Move lower.  Change type.
2309         (get_fbsd_pspace_data): Update.
2310         (fbsd_pspace_data_cleanup): Remove.
2311         (_initialize_fbsd_tdep): Update.
2312
2313 2019-05-08  Tom Tromey  <tom@tromey.com>
2314
2315         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2316         (get_ada_tasks_pspace_data): Update.
2317         (ada_tasks_pspace_data_cleanup): Remove.
2318         (_initialize_tasks): Update.
2319         (ada_tasks_inferior_data_handle): Change type.
2320         (get_ada_tasks_inferior_data): Update.
2321         (ada_tasks_inferior_data_cleanup): Remove.
2322         (struct ada_tasks_pspace_data): Add initializers.
2323
2324 2019-05-08  Tom Tromey  <tom@tromey.com>
2325
2326         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2327         * symfile-debug.c (debug_sym_get_probes): Change type.
2328         * stap-probe.c (handle_stap_probe):
2329         (stap_static_probe_ops::get_probes): Change type.
2330         * probe.h (class static_probe_ops) <get_probes>: Change type.
2331         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2332         (parse_probes_in_pspace): Update.
2333         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2334         Update.
2335         (any_static_probe_ops::get_probes): Change type.
2336         * elfread.c (elfread_data): New typedef.
2337         (probe_key): Change type.
2338         (elf_get_probes): Likewise.  Update.
2339         (probe_key_free): Remove.
2340         (_initialize_elfread): Update.
2341         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2342         Change type.
2343         (dtrace_process_dof_probe, dtrace_process_dof)
2344         (dtrace_static_probe_ops::get_probe): Change type.
2345
2346 2019-05-08  Tom Tromey  <tom@tromey.com>
2347
2348         * xcoffread.c (struct xcoff_symfile_info): Rename from
2349         coff_symfile_info.  Add initializers.
2350         (xcoff_objfile_data_key): Move lower.  Change type.
2351         (XCOFF_DATA): Rewrite.
2352         (xcoff_free_info): Remove.
2353         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2354         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2355         (xcoff_initial_scan): Update.
2356
2357 2019-05-08  Tom Tromey  <tom@tromey.com>
2358
2359         * solib-svr4.c (struct svr4_info): Add initializers and
2360         destructor.
2361         <probes_table>: Now an htab_up.
2362         (solib_svr4_pspace_data): Change type.
2363         (free_probes_table): Simplify.
2364         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2365         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2366         (probes_table_remove_objfile_probes, register_solib_event_probe)
2367         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2368         (_initialize_svr4_solib): Update.
2369
2370 2019-05-08  Tom Tromey  <tom@tromey.com>
2371
2372         * remote.c (remote_pspace_data): Change type.
2373         (remote_pspace_data_cleanup): Remove.
2374         (get_remote_exec_file, set_pspace_remote_exec_file)
2375         (_initialize_remote): Update.
2376
2377 2019-05-08  Tom Tromey  <tom@tromey.com>
2378
2379         * breakpoint.c (breakpoint_objfile_key): Change type.
2380         (get_breakpoint_objfile_data): Update.
2381         (free_breakpoint_objfile_data): Remove.
2382         (_initialize_breakpoint): Update.
2383
2384 2019-05-08  Tom Tromey  <tom@tromey.com>
2385
2386         * linux-tdep.c (struct linux_info): Add initializers.
2387         (linux_inferior_data): Move.  Change type.
2388         (invalidate_linux_cache_inf): Update.
2389         (linux_inferior_data_cleanup): Remove.
2390         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2391
2392 2019-05-08  Tom Tromey  <tom@tromey.com>
2393
2394         * auxv.c (auxv_inferior_data): Move.  Change type.
2395         (auxv_inferior_data_cleanup): Remove.
2396         (invalidate_auxv_cache_inf): Rewrite.
2397         (get_auxv_inferior_data, _initialize_auxv): Update.
2398
2399 2019-05-08  Tom Tromey  <tom@tromey.com>
2400
2401         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2402         (symfile_debug_objfile_data_key): Change type.
2403         (symfile_debug_installed, debug_qf_has_symbols)
2404         (debug_qf_find_last_source_symtab)
2405         (debug_qf_forget_cached_source_info)
2406         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2407         (debug_qf_print_stats, debug_qf_dump)
2408         (debug_qf_expand_symtabs_for_function)
2409         (debug_qf_expand_all_symtabs)
2410         (debug_qf_expand_symtabs_with_fullname)
2411         (debug_qf_map_matching_symbols)
2412         (debug_qf_expand_symtabs_matching)
2413         (debug_qf_find_pc_sect_compunit_symtab)
2414         (debug_qf_map_symbol_filenames)
2415         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2416         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2417         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2418         (debug_sym_read_linetable, debug_sym_relocate): Update.
2419         (symfile_debug_free_objfile): Remove.
2420         (install_symfile_debug_logging, _initialize_symfile_debug):
2421         Update.
2422
2423 2019-05-08  Tom Tromey  <tom@tromey.com>
2424
2425         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2426         allocate_on_obstack.
2427         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2428         (get_dwarf2_per_objfile): Update.
2429         (set_dwarf2_per_objfile): Remove.
2430         (dwarf2_has_info, dwarf2_get_section_info): Update.
2431         (dwarf2_free_objfile): Remove.
2432         (_initialize_dwarf2_read): Update.
2433
2434 2019-05-08  Tom Tromey  <tom@tromey.com>
2435
2436         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2437         initializers.
2438         <unsupported_script_warning_printed,
2439         script_not_found_warning_printed>: Now bool.
2440         (auto_load_pspace_data): Change type.
2441         (~auto_load_pspace_info): Rename from
2442         auto_load_pspace_data_cleanup.
2443         (get_auto_load_pspace_data, init_loaded_scripts_info)
2444         (clear_section_scripts, maybe_print_unsupported_script_warning)
2445         (maybe_print_script_not_found_warning, _initialize_auto_load):
2446         Update.
2447
2448 2019-05-08  Tom Tromey  <tom@tromey.com>
2449
2450         * objfiles.c (objfile_pspace_info): Add destructor and
2451         initializers.
2452         (objfiles_pspace_data): Change type.
2453         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2454         (get_objfile_pspace_data): Update.
2455         (objfiles_bfd_data): Change type.
2456         (get_objfile_bfd_data): Update.
2457         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2458
2459 2019-05-08  Tom Tromey  <tom@tromey.com>
2460
2461         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2462         Change type.
2463         (get_catch_syscall_inferior_data): Update.
2464         (catch_syscall_inferior_data_cleanup): Remove.
2465         (_initialize_break_catch_syscall): Update.
2466
2467 2019-05-08  Tom Tromey  <tom@tromey.com>
2468
2469         * inflow.c (struct terminal_info): Add destructor and
2470         initializers.
2471         (inflow_inferior_data): Change type.
2472         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2473         (get_inflow_inferior_data, inflow_inferior_exit)
2474         (swap_terminal_info, _initialize_inflow): Update.
2475
2476 2019-05-08  Tom Tromey  <tom@tromey.com>
2477
2478         * target-dcache.c (target_dcache_cleanup): Remove.
2479         (target_dcache_aspace_key): Change type.
2480         (target_dcache_init_p, target_dcache_invalidate)
2481         (target_dcache_get, target_dcache_get_or_init)
2482         (_initialize_target_dcache): Update.
2483         * dcache.h (struct dcache_deleter): New.
2484
2485 2019-05-08  Tom Tromey  <tom@tromey.com>
2486
2487         * symtab.c (struct symbol_cache): Add destructor and
2488         initializers.
2489         (symbol_cache_key): Move.  Change type.
2490         (make_symbol_cache, free_symbol_cache): Remove.
2491         (get_symbol_cache): Update.
2492         (symbol_cache_cleanup): Remove.
2493         (ALL_PSPACES, symbol_cache_flush)
2494         (maintenance_print_symbol_cache)
2495         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2496         Update.
2497
2498 2019-05-08  Tom Tromey  <tom@tromey.com>
2499
2500         * symtab.c (struct main_info): Add destructor and initializers.
2501         (main_progspace_key): Move.  Change type.
2502         (get_main_info): Update.
2503         (main_info_cleanup): Remove.
2504         (_initialize_symtab): Update.
2505
2506 2019-05-08  Tom Tromey  <tom@tromey.com>
2507
2508         * registry.h (DECLARE_REGISTRY): Define the _key class.
2509
2510 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2511
2512         * NEWS: Merge two 'New commands' sections.
2513
2514 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2515
2516         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2517         parameter and use Ada language definition instead.
2518         (ada_val_print_ptr): Remove unused language parameter.
2519         (ada_val_print_num): Remove language parameter and use Ada language
2520         definition instead.
2521         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2522         parameter.
2523         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2524         parameter and use Ada language definition instead.
2525         (ada_val_print_1): Update all ada_val_print_xxx calls.
2526         Remove language parameter.
2527         (ada_val_print): Update ada_val_print_1 call.
2528
2529 2019-05-08  Tom Tromey  <tromey@adacore.com>
2530
2531         * remote.c (remote_hw_watchpoint_limit)
2532         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2533         Now static.
2534
2535 2019-05-08  Tom Tromey  <tromey@adacore.com>
2536
2537         * maint.c (_initialize_maint_cmds): Move initialization code to
2538         remote.c.
2539         (watchdog, show_watchdog): Move to remote.c.
2540         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2541         "watchdog" static.
2542         (_initialize_remote): Move initialization code from maint.c.
2543         * defs.h (watchdog): Don't declare.
2544
2545 2019-05-08  Tom Tromey  <tromey@adacore.com>
2546
2547         * tui/tui-interp.c: Include main.h.
2548         * interps.c: Include main.h.
2549         * main.h (interpreter_p): Declare.
2550         * defs.h (interpreter_p): Don't declare.
2551
2552 2019-05-08  Tom Tromey  <tromey@adacore.com>
2553
2554         * dwarf2loc.c: Include dwarf2read.h.
2555         * defs.h (read_unsigned_leb128): Don't declare.
2556         * dwarf2read.h (read_unsigned_leb128): Declare.
2557
2558 2019-05-08  Tom Tromey  <tromey@adacore.com>
2559
2560         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2561         method.
2562
2563 2019-05-08  Tom Tromey  <tromey@adacore.com>
2564
2565         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2566         when no wrap column is set.
2567
2568 2019-05-08  Tom Tromey  <tromey@adacore.com>
2569
2570         * c-lang.c (c_get_string): Handle non-C-style arrays.
2571
2572 2019-05-08  Tom Tromey  <tromey@adacore.com>
2573
2574         * typeprint.c (print_offset_data::update): Print the bit offset,
2575         not the number of bits remaining.
2576
2577 2019-05-08  Tom Tromey  <tromey@adacore.com>
2578
2579         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2580         padding at end of comment.
2581
2582 2019-05-08  Tom Tromey  <tromey@adacore.com>
2583
2584         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2585         Compare main types.
2586
2587 2019-05-06  Tom Tromey  <tom@tromey.com>
2588
2589         * common/scoped_mmap.c: Include common-defs.h.
2590         * common/scoped_mmap.h: Don't include config.h.
2591
2592 2019-05-04  Tom Tromey  <tom@tromey.com>
2593
2594         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2595         (struct aarch64_call_info): Add initializers.
2596         <si>: Now a std::vector.
2597         (pass_on_stack, aarch64_push_dummy_call): Update.
2598
2599 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2600             Tom Tromey  <tom@tromey.com>
2601
2602         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2603         (ppc_threads): Now a std::vector.  Now static.
2604         (hwdebug_find_thread_points_by_tid)
2605         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2606         Update.
2607
2608 2019-05-04  Tom Tromey  <tom@tromey.com>
2609
2610         * arc-tdep.c (arc_tdesc_init): Return bool.
2611
2612 2019-05-04  Tom Tromey  <tom@tromey.com>
2613
2614         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2615         Use gdb_assert_not_reached.
2616
2617 2019-05-04  Tom Tromey  <tom@tromey.com>
2618
2619         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2620         "false".
2621
2622 2019-05-04  Tom Tromey  <tom@tromey.com>
2623
2624         * arc-tdep.c (arc_tdesc_init): Use bool.
2625
2626 2019-05-04  Tom Tromey  <tom@tromey.com>
2627
2628         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2629
2630 2019-05-04  Tom Tromey  <tom@tromey.com>
2631
2632         * cli/cli-cmds.c (valid_command_p): Return bool.
2633
2634 2019-05-04  Tom Tromey  <tom@tromey.com>
2635
2636         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2637         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2638
2639 2019-05-04  Raul Tambre  <raul@tambre.ee>
2640
2641         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2642         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2643         operator for comparison.
2644
2645 2019-05-04  Tom Tromey  <tom@tromey.com>
2646
2647         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2648         (lookup_partial_symbol, print_partial_symbols)
2649         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2650         (psymbol_compare): Update.
2651         (add_psymbol_to_bcache): Clear the entire psymbol.
2652         (maintenance_check_psymtabs): Update.
2653         * psympriv.h (struct partial_symbol): Don't derive from
2654         general_symbol_info.
2655         <obj_section, unrelocated_address, address,
2656         set_unrelocated_address>: Update.
2657         <ginfo>: New member.
2658         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2659         (debug_names::write_psymbols): Update.
2660
2661 2019-05-04  Tom de Vries  <tdevries@suse.de>
2662
2663         * contrib/cc-with-tweaks.sh: Support -n arg.
2664
2665 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2666
2667         * corelow.c (core_target::detach): Ensure frame cache and
2668         register caches are cleared.
2669         inferior.c (exit_inferior_1): Likewise.
2670
2671 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2672             Tom Tromey  <tom@tromey.com>
2673
2674         * dictionary.c (collate_pending_symbols_by_language): Remove
2675         "struct" from foreach.
2676         * symtab.c (lookup_global_symbol_from_objfile)
2677         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2678         foreach.
2679         * ser-tcp.c (net_open): Remove "struct" from foreach.
2680         * objfiles.c (objfile_relocate, objfile_rebase)
2681         (objfile_has_symbols): Remove "struct" from foreach.
2682         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2683         from foreach.
2684         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2685         foreach.
2686         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2687         "struct" from foreach.
2688         * ada-lang.c (create_excep_cond_exprs)
2689         (ada_exception_catchpoint_cond_string): Remove "struct" from
2690         foreach.
2691
2692 2019-05-03  Tom Tromey  <tromey@adacore.com>
2693
2694         * ada-exp.y (convert_char_literal): Check suffix of each
2695         enumerator.
2696
2697 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2698
2699         PR ada/21406:
2700         * ada-exp.y (yywrap): Don't define.
2701         * ada-lex.l (%option): Add noyywrap
2702         (yywrap): Remove.
2703
2704 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2705
2706         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2707         _WIN32_WINNT to the XP level, unless already defined to a higher
2708         level.
2709
2710         * unittests/parse-connection-spec-selftests.c:
2711         * ser-tcp.c:
2712         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2713         override.
2714
2715         * symfile.c (find_separate_debug_file): Remove colon from the
2716         drive spec of DOS/Windows file names of the target, so that the
2717         file name produced from DEBUGDIR and the target's directory will
2718         be valid on DOS/Windows systems.
2719
2720 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2721
2722         * rust-lang.c (val_print_struct): Handle printing structures
2723         containing strings.
2724
2725 2019-05-02  Tom Tromey  <tromey@adacore.com>
2726
2727         * valarith.c (_initialize_valarith): Remove.
2728
2729 2019-05-01  Tom Tromey  <tromey@adacore.com>
2730
2731         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2732         bitfields.
2733
2734 2019-05-01  Tom Tromey  <tromey@adacore.com>
2735
2736         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2737         for big-endian copies.
2738
2739 2019-04-30  Ali Tamur  <tamur@google.com>
2740         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2741         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2742         (read_3_bytes): New function.
2743
2744 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2745
2746         * windows-nat.c (main_thread_id): Delete.
2747         (handle_output_debug_string): Replace main_thread_id by
2748         current_event.dwThreadId.
2749         (fake_create_process): Likewise.
2750         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2751         Do not set main_thread_id.
2752         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2753         current_event.dwThreadId.
2754         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2755
2756 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2757
2758         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2759         Use current_event.dwThreadId instead of main_thread_id.
2760
2761 2019-04-30  Tom Tromey  <tromey@adacore.com>
2762
2763         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2764         (create_excep_cond_exprs): Iterate over program spaces.
2765         (ada_exception_catchpoint_cond_string): Examine all minimal
2766         symbols for exception types.
2767
2768 2019-04-30  Tom Tromey  <tromey@adacore.com>
2769
2770         PR c++/24470:
2771         * dwarf2read.c (process_structure_scope): Handle case where type
2772         has template parameters but no symbol was created.
2773
2774 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2775             Chris January  <chris.january@arm.com>
2776
2777         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2778         qualifier.
2779         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2780
2781 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2782
2783         * f-typeprint.c (f_print_type): Update rules for printing
2784         whitespace.
2785         (f_type_print_varspec_suffix): Likewise.
2786
2787 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2788             Chris January  <chris.january@arm.com>
2789
2790         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2791         function arguments.
2792
2793 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2794
2795         * f-lang.c (build_fortran_types): Change name of void type to
2796         lower case.
2797         * f-typeprint.c (f_type_print_base): Print the name of the void
2798         type, rather than a fixed string.
2799         * f-valprint.c (f_decorations): Use lower case void string.
2800
2801 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2802             Chris January  <chris.january@arm.com>
2803
2804         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2805         types for Fortran.
2806
2807 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2808             Chris January  <chris.january@arm.com>
2809             David Lecomber  <david.lecomber@arm.com>
2810
2811         * f-exp.y (BINOP_INTRINSIC): New token.
2812         (exp): New parser rule handling BINOP_INTRINSIC.
2813         (f77_keywords): Add new builtin procedures.
2814         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2815         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2816         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2817         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2818         (print_unop_subexp_f): New function.
2819         (print_binop_subexp_f): New function.
2820         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2821         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2822         (dump_subexp_body_f): Likewise.
2823         (operator_check_f): Likewise.
2824         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2825         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2826
2827 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2828
2829         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2830         UNOP_KIND.
2831         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2832         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2833         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2834         (operator_length_f): New fuction.
2835         (print_subexp_f): New function.
2836         (op_name_f): New function.
2837         (dump_subexp_body_f): New function.
2838         (operator_check_f): New function.
2839         (exp_descriptor_f): Replace standard expression handling functions
2840         with new functions.
2841         * gdb/fortran-operator.def: New file.
2842         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2843         * gdb/std-operator.def: Remove UNOP_KIND.
2844
2845 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2846
2847         * std-operator.def: Remove unbalanced, stray double quote
2848         character.
2849
2850 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2851             Chris January  <chris.january@arm.com>
2852             Daniel Everett  <daniel.everett@arm.com>
2853             Nick Forrington  <nick.forrington@arm.com>
2854             Richard Bunt  <richard.bunt@arm.com>
2855
2856         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2857         of depth when printing anonymous structs or unions.
2858         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2859         Don't print either the top-level value, or the children if the
2860         max-depth is exceeded.
2861         (ppscm_print_children): When printing the key of a map, allow one
2862         extra level of depth.
2863         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2864         print either the top-level value, or the children if the max-depth
2865         is exceeded.
2866         (print_children): When printing the key of a map, allow one extra
2867         level of depth.
2868         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2869         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2870         (user_print_options): Initialise max_depth field.
2871         (val_print_scalar_or_string_type_p): New function.
2872         (val_print): Check to see if the max depth has been reached.
2873         (val_print_check_max_depth): Define new function.
2874         (show_print_max_depth): New function.
2875         (_initialize_valprint): Add 'print max-depth' option.
2876         * valprint.h (struct value_print_options) <max_depth>: New field.
2877         (val_print_check_max_depth): Declare new function.
2878         * NEWS: Document new feature.
2879
2880 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2881
2882         * ada-lang.c (ada_language_defn): Initialise new field.
2883         * c-lang.c (c_is_string_type_p): New function.
2884         (c_language_defn): Initialise new field.
2885         (cplus_language_defn): Initialise new field.
2886         (asm_language_defn): Initialise new field.
2887         (minimal_language_defn): Initialise new field.
2888         * c-lang.h (c_is_string_type_p): Declare new function.
2889         * d-lang.c (d_language_defn): Initialise new field.
2890         * f-lang.c (f_is_string_type_p): New function.
2891         (f_language_defn): Initialise new field.
2892         * go-lang.c (go_is_string_type_p): New function.
2893         (go_language_defn): Initialise new field.
2894         * language.c (default_is_string_type_p): New function.
2895         (unknown_language_defn): Initialise new field.
2896         (auto_language_defn): Initialise new field.
2897         * language.h (struct language_defn) <la_is_string_type_p>: New
2898         member variable.
2899         (default_is_string_type_p): Declare new function.
2900         * m2-lang.c (m2_language_defn): Initialise new field.
2901         * objc-lang.c (objc_language_defn): Initialise new field.
2902         * opencl-lang.c (opencl_language_defn): Initialise new field.
2903         * p-lang.c (pascal_is_string_type_p): New function.
2904         (pascal_language_defn): Initialise new field.
2905         * rust-lang.c (rust_is_string_type_p): New function.
2906         (rust_language_defn): Initialise new field.
2907
2908 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2909
2910         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2911         New field.
2912         * ada-lang.c (ada_language_defn): Initialise new field.
2913         * c-lang.c (c_language_defn): Likewise.
2914         (cplus_language_defn): Likewise.
2915         (asm_language_defn): Likewise.
2916         (minimal_language_defn): Likewise.
2917         * d-lang.c (d_language_defn): Likewise.
2918         * f-lang.c (f_language_defn): Likewise.
2919         * go-lang.c (go_language_defn): Likewise.
2920         * language.c (unknown_language_defn): Likewise.
2921         (auto_language_defn): Likewise.
2922         * m2-lang.c (m2_language_defn): Likewise.
2923         * objc-lang.c (objc_language_defn): Likewise.
2924         * opencl-lang.c (opencl_language_defn): Likewise.
2925         * p-lang.c (pascal_language_defn): Likewise.
2926         * rust-lang.c (rust_language_defn): Likewise.
2927
2928 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2929
2930         * ada-lang.c (ada_is_character_type): Change return type to bool.
2931         (ada_is_string_type): Likewise.
2932         * ada-lang.h (ada_is_character_type): Update declaration
2933         (ada_is_string_type): Likewise.
2934
2935 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2936
2937         Support style in 'frame|thread apply'
2938
2939         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2940         * record.c (record_start, record_stop): Update callers of
2941         execute_command_to_string with false.
2942         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2943         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2944         methods.
2945         (class string_file): New constructor with term_out parameter.
2946         Override methods term_out and can_emit_style_escape.  New member
2947         term_out.
2948         (class stdio_file): Override can_emit_style_escape.
2949         (class tee_file): Override term_out and can_emit_style_escape.
2950         * utils.h (can_emit_style_escape): Remove.
2951         * utils.c (can_emit_style_escape): Likewise.
2952         Update all callers of can_emit_style_escape (SOMESTREAM) to
2953         SOMESTREAM->can_emit_style_escape.
2954         * source-cache.c (source_cache::get_source_lines): Likewise.
2955         * stack.c (frame_apply_command_count): Call execute_command_to_string
2956         passing the term_out characteristic of the current gdb_stdout.
2957         * thread.c (thr_try_catch_cmd): Likewise.
2958         * top.c (execute_command_to_string): pass term_out parameter
2959         to construct the string_file for the command output.
2960         * ui-file.c (term_cli_styling): New function (most code moved
2961         from utils.c can_emit_style_escape).
2962         (string_file::string_file, string_file::can_emit_style_escape,
2963         stdio_file::can_emit_style_escape, tee_file::term_out,
2964         tee_file::can_emit_style_escape): New functions.
2965
2966 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2967
2968         * NEWS: Mention the new set|show may-call-functions.
2969         * infcall.c (may_call_functions_p): New variable.
2970         (show_may_call_functions_p): New function.
2971         (call_function_by_hand_dummy): Throws an error if not
2972         may-call-functions.
2973         (_initialize_infcall): Call add_setshow_boolean_cmd for
2974         may-call-functions.
2975
2976 2019-04-25  Keith Seitz  <keiths@redhat.com>
2977
2978         PR c++/24367
2979         * cp-support.c (inspect_type): Don't attempt substitutions
2980         of symbol with the same name.
2981
2982 2019-04-25  Tom Tromey  <tromey@adacore.com>
2983
2984         PR gdb/24475:
2985         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2986         static.
2987
2988 2019-04-25  Tom Tromey  <tromey@adacore.com>
2989
2990         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2991         rvalue reference.
2992         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2993         (gdb_xml_parser::parse): Use std::move.
2994         * python/python-internal.h (gdbpy_convert_exception): Take a const
2995         reference.
2996         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2997         std::move.
2998         * python/py-utils.c (gdbpy_convert_exception): Take a const
2999         reference.
3000         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3001         Use std::move.
3002         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3003         Use std::move.
3004         * mi/mi-main.c (mi_print_exception): Take a const reference.
3005         * main.c (handle_command_errors): Take a const reference.
3006         * linespec.c (parse_linespec): Use std::move.
3007         * infcall.c (run_inferior_call): Use std::move.
3008         (call_function_by_hand_dummy): Use std::move.
3009         * exec.c (try_open_exec_file): Use std::move.
3010         * exceptions.h (exception_print, exception_fprintf)
3011         (exception_print_same): Update.
3012         * exceptions.c (print_exception, exception_print)
3013         (exception_fprintf, exception_print_same): Change parameters to
3014         const reference.
3015         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3016         * common/new-op.c: Use std::move.
3017         * common/common-exceptions.h (struct gdb_exception): Add move
3018         constructor.
3019         (struct gdb_exception_error, struct gdb_exception_quit, struct
3020         gdb_quit_bad_alloc): Change constructor to move constructor.
3021         (throw_exception): Change parameter to rvalue reference.
3022         * common/common-exceptions.c (throw_exception): Take rvalue
3023         reference.
3024         * cli/cli-interp.c (safe_execute_command): Use std::move.
3025         * breakpoint.c (insert_bp_location, location_to_sals): Use
3026         std::move.
3027
3028 2019-04-25  Tom Tromey  <tromey@adacore.com>
3029
3030         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3031         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3032         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3033         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3034         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3035         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3036         guile/scm-value.c: Use unpack.
3037         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3038         gdbscm_gdb_exception.
3039         (gdbscm_throw_gdb_exception): Likewise.
3040         (struct gdbscm_gdb_exception): New.
3041         (unpack): New function.
3042         (gdbscm_wrap): Use unpack.
3043
3044 2019-04-25  Tom Tromey  <tromey@adacore.com>
3045
3046         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3047         (gdb_rl_callback_handler): Use std::move.
3048         * common/common-exceptions.h (struct gdb_exception): Add move
3049         assignment operator.
3050         (throw_exception_sjlj): Change "exception" to const reference.
3051         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3052         (throw_exception_sjlj): Change "exception" to const reference.
3053
3054 2019-04-25  Tom Tromey  <tromey@adacore.com>
3055
3056         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3057         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3058         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3059         Update.
3060         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3061         Update.
3062         * mi/mi-interp.c (mi_interp::exec): Update.
3063         * linespec.c (parse_linespec): Update.
3064         * infcall.c (run_inferior_call): Update.
3065         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3066         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3067         (gdbscm_lookup_global_symbol): Update.
3068         * guile/scm-param.c (gdbscm_parameter_value): Update.
3069         * guile/scm-frame.c (gdbscm_frame_read_register)
3070         (gdbscm_frame_read_var): Update.
3071         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3072         * exec.c (try_open_exec_file): Update.
3073         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3074         (gdb_rl_callback_handler): Update.
3075         * common/common-exceptions.h (exception_none): Don't declare.
3076         * common/common-exceptions.c (exception_none): Don't define.
3077         (struct catcher) <exception>: Update.
3078         * cli/cli-interp.c (safe_execute_command): Update.
3079         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3080
3081 2019-04-25  Ali Tamur  <tamur@google.com>
3082
3083         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3084         (read_attribute_value): Likewise.
3085         (dwarf2_read_addr_index): Update comment.
3086         (read_str_index): Add DW_FORM_strx.
3087         (dwarf2_string_attr): Likewise.
3088         (dwarf2_const_value_attr): Likewise.
3089         (dump_die_shallow): Likewise.
3090         (dwarf2_fetch_constant_bytes): Likewise.
3091         (skip_form_bytes): Likewise.
3092         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3093
3094 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3095
3096         PR corefiles/11608
3097         PR corefiles/18187
3098         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3099         OFFSET.  Verify if current mapping contains an ELF header.
3100         (linux_find_memory_regions_full): Adjust call to
3101         dump_mapping_p.
3102
3103 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3104             Kang Li <kanglictf@gmail.com>
3105
3106         PR gdb/21600
3107
3108         * dwarf2-frame.c (read_initial_length): Be consistent about using
3109         unsigned representation of length.
3110         (decode_frame_entry_1): Likewise.  Check for wraparound of
3111         end pointer as well as buffer overflow.
3112
3113 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3114
3115         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3116         "vq".
3117
3118 2019-04-24  Tom Tromey  <tromey@adacore.com>
3119
3120         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3121
3122 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3123
3124         * s12z-tdep.c (s12z_unwind_pc): Delete.
3125         (s12z_unwind_sp): Delete.
3126         (s12z_gdbarch_init): Don't register deleted functions with
3127         gdbarch.
3128
3129 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3130
3131         * rl78-tdep.c (rl78_unwind_sp): Delete.
3132         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3133
3134 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3135
3136         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3137         (xstormy16_unwind_pc): Delete.
3138         (xstormy16_dummy_id): Delete.
3139         (xstormy16_gdbarch_init): Don't register deleted functions with
3140         gdbarch.
3141
3142 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3143
3144         * vax-tdep.c (vax_unwind_pc): Delete.
3145         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3146
3147 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3148
3149         * v850-tdep.c (v850_unwind_sp): Delete.
3150         (v850_unwind_pc): Delete.
3151         (v850_dummy_id): Delete.
3152         (v850_gdbarch_init): Don't register deleted functions with
3153         gdbarch.
3154
3155 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3156
3157         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3158         (tilegx_unwind_pc): Delete.
3159         (tilegx_unwind_dummy_id): Delete.
3160         (tilegx_gdbarch_init): Don't register deleted functions with
3161         gdbarch.
3162
3163 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3164
3165         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3166         (tic6x_dummy_id): Delete.
3167         (tic6x_gdbarch_init): Don't register deleted functions with
3168         gdbarch.
3169
3170 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3171
3172         * sparc-tdep.c (sparc_unwind_pc): Delete.
3173         (sparc32_gdbarch_init): Don't register deleted function with
3174         gdbarch.
3175
3176 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3177
3178         * sh-tdep.c (sh_unwind_sp): Delete.
3179         (sh_unwind_pc): Delete.
3180         (sh_dummy_id): Delete.
3181         (sh_gdbarch_init): Don't register deleted functions with
3182         gdbarch.
3183
3184 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3185
3186         * score-tdep.c (score_unwind_sp): Delete.
3187         (score_unwind_pc): Delete.
3188         (score_dummy_id): Delete.
3189         (score_gdbarch_init): Don't register deleted functions with
3190         gdbarch.
3191
3192 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3193
3194         * rx-tdep.c (rx_unwind_pc): Delete.
3195         (rx_unwind_sp): Delete.
3196         (rx_dummy_id): Delete.
3197         (rx_gdbarch_init): Don't register deleted functions with
3198         gdbarch.  Update comment.
3199
3200 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3201
3202         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3203         (rs6000_dummy_id): Delete.
3204         (rs6000_gdbarch_init): Don't register deleted functions with
3205         gdbarch.
3206
3207 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3208
3209         * or1k-tdep.c (or1k_dummy_id): Delete.
3210         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3211
3212 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3213
3214         * nios2-tdep.c (nios2_dummy_id): Delete.
3215         (nios2_unwind_sp): Delete.
3216         (nios2_gdbarch_init): Don't register deleted functions with
3217         gdbarch.
3218
3219 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3220
3221         * nds32-tdep.c (nds32_dummy_id): Delete.
3222         (nds32_unwind_pc): Delete.
3223         (nds32_unwind_sp): Delete.
3224         (nds32_gdbarch_init): Don't register deleted functions with
3225         gdbarch.
3226
3227 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3228
3229         * msp430-tdep.c (msp430_unwind_pc): Delete.
3230         (msp430_unwind_sp): Delete.
3231         (msp430_dummy_id): Delete.
3232         (msp430_gdbarch_init): Don't register deleted functions with
3233         gdbarch.
3234
3235 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3236
3237         * moxie-tdep.c (moxie_unwind_sp): Delete.
3238         (moxie_unwind_pc): Delete.
3239         (moxie_dummy_id): Delete.
3240         (moxie_gdbarch_init): Don't register deleted functions with
3241         gdbarch.
3242
3243 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3244
3245         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3246         (mn10300_unwind_pc): Delete.
3247         (mn10300_unwind_sp): Delete.
3248         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3249         mn10300_unwind_sp.
3250         (mn10300_frame_unwind_init): Don't register deleted functions with
3251         gdbarch.
3252
3253 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3254
3255         * mep-tdep.c (mep_unwind_pc): Delete.
3256         (mep_unwind_sp): Delete.
3257         (mep_dummy_id): Delete.
3258         (mep_gdbarch_init): Don't register deleted functions with
3259         gdbarch.
3260
3261 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3262
3263         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3264         (m68hc11_unwind_sp): Delete.
3265         (m68hc11_gdbarch_init): Don't register deleted functions with
3266         gdbarch.
3267
3268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3269
3270         * m32r-tdep.c (m32r_unwind_sp): Delete.
3271         (m32r_unwind_pc): Delete.
3272         (m32r_dummy_id): Delete.
3273         (m32r_gdbarch_init): Don't register deleted functions with
3274         gdbarch.
3275
3276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3277
3278         * m32c-tdep.c (m32c_unwind_pc): Delete.
3279         (m32c_unwind_sp): Delete.
3280         (m32c_dummy_id): Delete.
3281         (m32c_gdbarch_init): Don't register deleted functions with
3282         gdbarch.
3283
3284 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3285
3286         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3287         (lm32_unwind_pc): Delete.
3288         (lm32_dummy_id): Delete.
3289         (lm32_gdbarch_init): Don't register deleted functions with
3290         gdbarch.
3291
3292 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3293
3294         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3295         (iq2000_unwind_pc): Delete.
3296         (iq2000_dummy_id): Delete.
3297         (iq2000_gdbarch_init): Don't register deleted functions with
3298         gdbarch.
3299
3300 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3301
3302         * nds32-tdep.c (nds32_type_align): Delete.
3303         (nds32_push_dummy_call): Use type_align instead.
3304
3305 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3306
3307         * arm-tdep.c (arm_type_align): Only handle vector override case.
3308         (arm_push_dummy_call): Use type_align.
3309         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3310
3311 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3312
3313         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3314         case.
3315         (pass_on_stack): Use type_align.
3316         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3317         function.
3318
3319 2019-04-23  Tom Tromey  <tromey@adacore.com>
3320
3321         * dwarf2read.c (line_header::file_name_at): Remove unused
3322         overload.
3323
3324 2019-04-23  Tom de Vries  <tdevries@suse.de>
3325
3326         PR gdb/24438
3327         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3328         invocation.
3329
3330
3331 2019-03-27  Ali Tamur  <tamur@google.com>
3332
3333         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3334         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3335         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3336         (dwarf_expr_context::get_addr_index): Likewise
3337         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3338         (symbol_needs_eval_context::get_addr_index): Likewise
3339         (disassemble_dwarf_expression): Add DW_OP_addrx
3340         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3341         (read_cutu_die_from_dwo): Update comment
3342         (skip_one_die): Add DW_FORM_addrx
3343         (read_attribute_value): Likewise
3344         (var_decode_location): Add DW_OP_addrx
3345         (dwarf2_const_value_attr): Add DW_FORM_addrx
3346         (dump_die_shallow): Likewise
3347         (dwarf2_fetch_constant_bytes): Likewise
3348         (decode_locdesc): Add DW_OP_addrx
3349         (skip_form_bytes): Add DW_FORM_addrx
3350
3351 2019-04-22  Ali Tamur  <tamur@google.com>
3352
3353         * MAINTAINERS (Write After Approval): Add self.
3354
3355 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3356
3357         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3358         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3359         (open_symbol_file_object): Likewise.
3360         (svr4_default_sos): Add info parameter.
3361         (svr4_read_so_list): Likewise.
3362         (svr4_current_sos_direct): Adjust functions calls to pass down
3363         info.
3364         (svr4_current_sos_1): Add info parameter.
3365         (svr4_current_sos): Call get_svr4_info, pass info down to
3366         svr4_current_sos_1.
3367         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3368         get_svr4_info.
3369         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3370         get_svr4_info.
3371         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3372         to get_svr4_info.
3373         (probes_table_remove_objfile_probes): Likewise.
3374         (register_solib_event_probe): Add info parameter.
3375         (solist_update_incremental): Pass info parameter down to
3376         svr4_read_so_list.
3377         (disable_probes_interface): Add info parameter.
3378         (svr4_handle_solib_event): Pass current_program_space to
3379         get_svr4_info.  Adjust disable_probes_interface cleanup.
3380         (svr4_create_probe_breakpoints): Add info parameter, pass it
3381         down to register_solib_event_probe.
3382         (svr4_create_solib_event_breakpoints): Add info parameter,
3383         pass it down to svr4_create_probe_breakpoints.
3384         (enable_break): Pass info down to
3385         svr4_create_solib_event_breakpoints.
3386         (svr4_solib_create_inferior_hook): Pass current_program_space to
3387         get_svr4_info.
3388         (svr4_clear_solib): Likewise.
3389
3390 2019-04-22  Pedro Alves  <palves@redhat.com>
3391
3392         * solib-svr4.c (svr4_free_objfile_observer): New.
3393         (probe_and_action::objfile): New field.
3394         (probes_table_htab_remove_objfile_probes)
3395         (probes_table_remove_objfile_probes): New functions.
3396         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3397         in the new probe_and_action.  Don't store the probe in 'lookup'.
3398         (svr4_create_probe_breakpoints): Pass objfile to
3399         register_solib_event_probe.
3400         (_initialize_svr4_solib): Register a free_objfile observer.
3401
3402 2019-04-19  Tom Tromey  <tom@tromey.com>
3403
3404         * common/queue.h: Remove.
3405
3406 2019-04-19  Tom Tromey  <tom@tromey.com>
3407
3408         * event-loop.c: Don't include "common/queue.h".
3409
3410 2019-04-19  Tom Tromey  <tom@tromey.com>
3411
3412         * remote.c (remote_target): Use delete.
3413         * remote-notif.h: Include <list>, not "common/queue.h".
3414         (notif_client_p): Remove typedef.
3415         (remote_notif_state): Add constructor, destructor, initializer.
3416         <notif_queue>: Now a std::list.
3417         (remote_notif_state_xfree): Don't declare.
3418         * remote-notif.c (remote_notif_process, handle_notification)
3419         (remote_notif_state_allocate): Update.
3420         (~remote_notif_state): Rename from remote_notif_state_xfree.
3421
3422 2019-04-19  Tom Tromey  <tom@tromey.com>
3423
3424         * symfile.c (reread_symbols): Update.
3425         * objfiles.c (objfile_register_static_link)
3426         (objfile_lookup_static_link): Update
3427         (~objfile) Don't delete static_links.
3428         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3429
3430 2019-04-19  Tom Tromey  <tom@tromey.com>
3431
3432         * type-stack.h (struct type_stack) <insert>: Constify string.
3433         * type-stack.c (type_stack::insert): Constify string.
3434         * gdbtypes.h (lookup_template_type): Update.
3435         (address_space_name_to_int): Update.
3436         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3437         const.
3438         (lookup_template_type): Make name const.
3439         * c-exp.y: Update rules.
3440         (lex_one_token, classify_name, classify_inner_name)
3441         (c_print_token): Update.
3442         * p-exp.y: Update rules.
3443         (yylex): Update.
3444         * f-exp.y: Update rules.
3445         (yylex): Update.
3446         * d-exp.y: Update rules.
3447         (lex_one_token, classify_name, classify_inner_name): Update.
3448         * parse.c (write_dollar_variable, copy_name): Return std::string.
3449         * parser-defs.h (copy_name): Change return type.
3450         * m2-exp.y: Update rules.
3451         (yylex): Update.
3452         * go-exp.y (lex_one_token): Update.
3453         Update rules.
3454         (classify_unsafe_function, classify_packaged_name)
3455         (classify_name, yylex): Update.
3456
3457 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3458
3459         * configure.ac: add --enable-source-highlight switch.
3460         * configure: Regenerate.
3461         * top.c (print_gdb_version): plumb --enable-source-highlight
3462         status to "show configuration".
3463
3464 2019-04-19  Tom Tromey  <tromey@adacore.com>
3465
3466         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3467         Check ADA_TYPE_P.
3468         (empty_record, ada_template_to_fixed_record_type_1)
3469         (template_to_static_fixed_type)
3470         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3471         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3472         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3473         macros.
3474
3475 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3476
3477         PR symtab/24423:
3478         * source.c (print_source_lines_base): Advance "iter" when a
3479         control character is seen.
3480
3481 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3482
3483         * inferior.h (struct infcall_suspend_state_deleter):
3484         Catch exception in destructor to avoid crash.
3485
3486 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3487
3488         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3489         close to the add_com "shell".
3490
3491 2019-04-18  Tom Tromey  <tromey@adacore.com>
3492
3493         * process-stratum-target.h (class process_stratum_target)
3494         <stratum>: Add "final".
3495
3496 2019-04-17  Tom Tromey  <tromey@adacore.com>
3497
3498         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3499         against nullptr before use.
3500
3501 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3502
3503         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3504
3505 2019-04-17  Jim Wilson  <jimw@sifive.com>
3506             Andrew Burgess  <andrew.burgess@embecosm.com>
3507
3508         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3509         code read might fail, assume 4-byte breakpoint in that case.
3510
3511 2019-04-15  Leszek Swirski  <leszeks@google.com>
3512
3513         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3514         rather than a hand-rolled POD check when checking for forced MEMORY
3515         classification.
3516
3517 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3518
3519         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3520         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3521         function.
3522         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3523         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3524         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3525         declaration.
3526
3527 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3528
3529         * aarch64-linux-nat.c
3530         (aarch64_linux_nat_target::thread_architecture): Add override.
3531         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3532         each VQ.
3533
3534 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3535
3536         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3537
3538 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3539
3540         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3541         target types of size 96-bits, add some additional comments, and
3542         check that the builtin type we found was the correct size.
3543
3544 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3545
3546         * utils.c (prompt_for_continue): Don't restore the styling at the
3547         end, as applied_style has the wrong value.  This fixes styling in
3548         long lists of file names that are interrupted by the "Continue?"
3549         prompt.
3550
3551 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3552
3553         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3554         * c-lang.c (c_language_defn): Likewise.
3555         (cplus_language_defn): Likewise.
3556         (asm_language_defn): Likewise.
3557         (minimal_language_defn): Likewise.
3558         * d-lang.c (d_language_defn): Likewise.
3559         * f-lang.c (f_language_defn): Likewise.
3560         * go-lang.c (go_language_defn): Likewise.
3561         * language.c (unknown_language_defn): Likewise.
3562         (auto_language_defn): Likewise.
3563         * language.h (struct language_defn): Remove la_magic field.
3564         (LANG_MAGIC): Delete.
3565         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3566         * objc-lang.c (objc_language_defn): Likewise.
3567         * opencl-lang.c (opencl_language_defn): Likewise.
3568         * p-lang.c (pascal_language_defn): Likewise.
3569         * rust-lang.c (rust_language_defn): Likewise.
3570
3571 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3572
3573         * riscv-tdep.c (riscv_type_align): New function.
3574         (riscv_type_alignment): Delete.
3575         (riscv_arg_location): Use 'type_align'.
3576         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3577
3578 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3579
3580         * gdbtypes.c (type_align): A struct with no non-static fields also
3581         has alignment of 1.
3582
3583 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3584
3585         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3586         component to 0.
3587         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3588         member.
3589         (riscv_struct_info::analyse): New implementation using new
3590         analyse_inner member function.
3591         (riscv_struct_info::field_offset): New member function.
3592         (riscv_struct_info::m_offsets): New member variable.
3593         (riscv_struct_info::analyse_inner): New private member function,
3594         takes the old implementation of riscv_struct_info::analyse but
3595         extended to track field offsets.
3596         (riscv_call_arg_struct): Update the struct folding special cases
3597         to handle cases where empty C++ structs, which are non-zero
3598         length, are found.
3599         (riscv_arg_location): Initialise the length of each location, a
3600         non-zero length now indicates the location is in use.
3601         (riscv_push_dummy_call): Allow for the first location having a
3602         non-zero offset when setting up arguments.
3603         (riscv_return_value): Likewise, but for return values.
3604
3605 2019-04-11  Tom Tromey  <tromey@adacore.com>
3606
3607         * utils.c (internal_vproblem): Make "msg" const.
3608
3609 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3610
3611         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3612         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3613         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3614         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3615
3616 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3617
3618         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3619         function.
3620         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3621         of amd64_collect_native_gregset.
3622         (amd64_linux_nat_target::store_registers): Likewise.
3623
3624 2019-04-10  Tom Tromey  <tom@tromey.com>
3625
3626         * symtab.c (lookup_global_symbol_from_objfile)
3627         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3628         * objfiles.h (class separate_debug_iterator): New.
3629         (class separate_debug_range): New.
3630         (struct objfile) <separate_debug_objfiles>: New method.
3631         (objfile_separate_debug_iterate): Don't declare.
3632         * objfiles.c (separate_debug_iterator::operator++): Rename from
3633         objfile_separate_debug_iterate.
3634         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3635         iterator.
3636         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3637         iterator.
3638
3639 2019-04-10  Tom Tromey  <tom@tromey.com>
3640
3641         * symfile.c (reread_symbols): Remove old comment.
3642         * objfiles.c (free_all_objfiles): Fix a typo.
3643
3644 2019-04-10  Tom Tromey  <tom@tromey.com>
3645
3646         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3647         * minsyms.c (lookup_minimal_symbol): Use foreach.
3648         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3649         (lookup_minimal_symbol_solib_trampoline): Likewise.
3650         * symfile.c (reread_symbols): Use foreach.
3651
3652 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3653             Tom Tromey  <tromey@adacore.com>
3654
3655         PR rust/24414:
3656         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3657         (rust_lex_int_test): Change "value" to be LONGEST.
3658         (rust_lex_tests): Add test for long integer literal.
3659
3660 2019-04-09  Tom Tromey  <tromey@adacore.com>
3661
3662         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3663         to bool.
3664         (extended_remote_target::attach): Update.
3665         (remote_target::remote_notice_new_inferior): Update.
3666         (remote_target::add_current_inferior_and_thread): Update.
3667         * inferior.c (exit_inferior_1): Use "false".
3668         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3669
3670 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3671
3672         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3673         the "start" command.
3674
3675 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3676
3677         * python/py-inferior.c (infpy_thread_from_thread_handle):
3678         Adjust comments to reflect renaming of thread_from_thread_handle
3679         to thread_from_handle.  Adjust keywords.  Fix type error message.
3680         (inferior_object_methods): Add thread_from_handle.  Retain
3681         thread_from_thread_handle, but mark it as deprecated.
3682
3683 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3684
3685         * gdbthread.h (find_thread_by_handle): Revise declaration.
3686         * thread.c (find_thread_by_handle): Likewise.  Adjust
3687         implementation too.
3688         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3689         support for buffer objects as handles.
3690
3691 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3692
3693         * python/py-infthread.c (thpy_thread_handle): New function.
3694         (thread_object_methods): Register thpy_thread_handle.
3695
3696 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3697
3698         * gdbthread.h (thread_to_thread_handle): Declare.
3699         * thread.c (gdbtypes.h): Include.
3700         (thread_to_thread_handle): New function.
3701
3702         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3703         (target_thread_info_to_thread_handle): Declare.
3704         * target.c (target_thread_info_to_thread_handle): New function.
3705         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3706         * target-delegates.c: Regenerate.
3707
3708         * linux-thread-db.c (class thread_db_target): Add method
3709         thread_info_to_thread_handle.
3710         (thread_db_target::thread_info_to_thread_handle): Define.
3711         * remote.c (class remote_target): Add new method
3712         thread_info_to_thread_handle.
3713         (remote_target::thread_info_to_thread_handle): Define.
3714
3715 2019-04-08  Pedro Alves  <palves@redhat.com>
3716
3717         * common/common-exceptions.c (throw_exception): Don't create
3718         named object to throw; throw directly.
3719         (throw_it): Likewise.  Don't initialize gdb_exception::message
3720         here, with new; pass FMT and AP to the ctor instead.
3721         * common/common-exceptions.h: Include <string>.
3722         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3723         const char *, va_list)): New ctor.  Use std::make_shared.
3724         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3725         errors)): Delete.
3726         (gdb_exception_error::gdb_exception_error(enum errors, const char
3727         *, va_list)): New.
3728         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3729         Add assertion.
3730         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3731         errors)): Delete.
3732         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3733         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3734         Add assertion.
3735
3736 2019-04-08  Tom Tromey  <tom@tromey.com>
3737
3738         * valops.c (value_rtti_indirect_type): Replace throw_exception
3739         with throw.
3740         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3741         with throw.
3742         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3743         throw.
3744         * target.c (target_translate_tls_address): Replace throw_exception
3745         with throw.
3746         * stack.c (frame_apply_command_count): Replace throw_exception
3747         with throw.
3748         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3749         throw.
3750         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3751         with throw.
3752         * rs6000-tdep.c (rs6000_frame_cache)
3753         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3754         * remote.c: Replace throw_exception with throw.
3755         * record-full.c (record_full_message, record_full_wait_1)
3756         (record_full_restore): Replace throw_exception with throw.
3757         * record-btrace.c:
3758         (get_thread_current_frame_id, record_btrace_start_replaying)
3759         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3760         (cmd_record_btrace_start): Replace throw_exception with throw.
3761         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3762         throw.
3763         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3764         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3765         * linespec.c:
3766         (find_linespec_symbols): Replace throw_exception with throw.
3767         * infrun.c (displaced_step_prepare, resume): Replace
3768         throw_exception with throw.
3769         * infcmd.c (post_create_inferior): Replace throw_exception with
3770         throw.
3771         * inf-loop.c (inferior_event_handler): Replace throw_exception
3772         with throw.
3773         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3774         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3775         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3776         (get_prev_frame_always, get_frame_pc_if_available)
3777         (get_frame_address_in_block_if_available, get_frame_language):
3778         Replace throw_exception with throw.
3779         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3780         throw_exception with throw.
3781         * eval.c (fetch_subexp_value, evaluate_var_value)
3782         (evaluate_funcall, evaluate_subexp_standard): Replace
3783         throw_exception with throw.
3784         * dwarf2loc.c (call_site_find_chain)
3785         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3786         Replace throw_exception with throw.
3787         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3788         with throw.
3789         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3790         throw.
3791         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3792         * completer.c (complete_line_internal): Replace throw_exception
3793         with throw.
3794         * compile/compile-object-run.c (compile_object_run): Replace
3795         throw_exception with throw.
3796         * cli/cli-script.c (process_next_line): Replace throw_exception
3797         with throw.
3798         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3799         (btrace_enable, btrace_maint_update_pt_packets): Replace
3800         throw_exception with throw.
3801         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3802         throw_exception with throw.
3803         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3804         throw_exception with throw.
3805         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3806         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3807         * aarch64-tdep.c (aarch64_make_prologue_cache)
3808         (aarch64_make_stub_cache): Replace throw_exception with throw.
3809
3810 2019-04-08  Tom Tromey  <tom@tromey.com>
3811
3812         * common/common-exceptions.c (throw_exception): Rename from
3813         throw_exception_cxx.  Remove old copy.  Make argument const.
3814         (throw_it): Create and throw exception objects directly.
3815         * common/common-exceptions.h (throw_exception): Make argument
3816         const.
3817         (struct gdb_exception_error): Add constructor.
3818         (struct gdb_exception_quit): Add constructor.
3819
3820 2019-04-08  Tom Tromey  <tom@tromey.com>
3821
3822         * common/common-exceptions.h (exception_rethrow): Don't declare.
3823         (TRY_SJLJ): Update comment.
3824         (TRY, CATCH, END_CATCH): Remove.
3825         * common/common-exceptions.c (exception_rethrow): Remove.
3826
3827 2019-04-08  Tom Tromey  <tom@tromey.com>
3828
3829         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3830         Remove.
3831         (gdb_exception_error): Rename from
3832         gdb_exception_RETURN_MASK_ERROR.
3833         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3834         (gdb_quit_bad_alloc): Update.
3835         * aarch64-tdep.c: Update.
3836         * ada-lang.c: Update.
3837         * ada-typeprint.c: Update.
3838         * ada-valprint.c: Update.
3839         * amd64-tdep.c: Update.
3840         * arch-utils.c: Update.
3841         * break-catch-throw.c: Update.
3842         * breakpoint.c: Update.
3843         * btrace.c: Update.
3844         * c-varobj.c: Update.
3845         * cli/cli-cmds.c: Update.
3846         * cli/cli-interp.c: Update.
3847         * cli/cli-script.c: Update.
3848         * common/common-exceptions.c: Update.
3849         * common/new-op.c: Update.
3850         * common/selftest.c: Update.
3851         * compile/compile-c-symbols.c: Update.
3852         * compile/compile-cplus-symbols.c: Update.
3853         * compile/compile-object-load.c: Update.
3854         * compile/compile-object-run.c: Update.
3855         * completer.c: Update.
3856         * corelow.c: Update.
3857         * cp-abi.c: Update.
3858         * cp-support.c: Update.
3859         * cp-valprint.c: Update.
3860         * darwin-nat.c: Update.
3861         * disasm-selftests.c: Update.
3862         * dtrace-probe.c: Update.
3863         * dwarf-index-cache.c: Update.
3864         * dwarf-index-write.c: Update.
3865         * dwarf2-frame-tailcall.c: Update.
3866         * dwarf2-frame.c: Update.
3867         * dwarf2loc.c: Update.
3868         * dwarf2read.c: Update.
3869         * eval.c: Update.
3870         * event-loop.c: Update.
3871         * event-top.c: Update.
3872         * exec.c: Update.
3873         * f-valprint.c: Update.
3874         * fbsd-tdep.c: Update.
3875         * frame-unwind.c: Update.
3876         * frame.c: Update.
3877         * gdbtypes.c: Update.
3878         * gnu-v3-abi.c: Update.
3879         * guile/guile-internal.h: Update.
3880         * guile/scm-block.c: Update.
3881         * guile/scm-breakpoint.c: Update.
3882         * guile/scm-cmd.c: Update.
3883         * guile/scm-disasm.c: Update.
3884         * guile/scm-frame.c: Update.
3885         * guile/scm-lazy-string.c: Update.
3886         * guile/scm-math.c: Update.
3887         * guile/scm-param.c: Update.
3888         * guile/scm-ports.c: Update.
3889         * guile/scm-pretty-print.c: Update.
3890         * guile/scm-symbol.c: Update.
3891         * guile/scm-symtab.c: Update.
3892         * guile/scm-type.c: Update.
3893         * guile/scm-value.c: Update.
3894         * i386-linux-tdep.c: Update.
3895         * i386-tdep.c: Update.
3896         * inf-loop.c: Update.
3897         * infcall.c: Update.
3898         * infcmd.c: Update.
3899         * infrun.c: Update.
3900         * jit.c: Update.
3901         * language.c: Update.
3902         * linespec.c: Update.
3903         * linux-fork.c: Update.
3904         * linux-nat.c: Update.
3905         * linux-tdep.c: Update.
3906         * linux-thread-db.c: Update.
3907         * main.c: Update.
3908         * mi/mi-cmd-break.c: Update.
3909         * mi/mi-cmd-stack.c: Update.
3910         * mi/mi-interp.c: Update.
3911         * mi/mi-main.c: Update.
3912         * objc-lang.c: Update.
3913         * p-valprint.c: Update.
3914         * parse.c: Update.
3915         * ppc-linux-tdep.c: Update.
3916         * printcmd.c: Update.
3917         * python/py-arch.c: Update.
3918         * python/py-breakpoint.c: Update.
3919         * python/py-cmd.c: Update.
3920         * python/py-finishbreakpoint.c: Update.
3921         * python/py-frame.c: Update.
3922         * python/py-framefilter.c: Update.
3923         * python/py-gdb-readline.c: Update.
3924         * python/py-inferior.c: Update.
3925         * python/py-infthread.c: Update.
3926         * python/py-lazy-string.c: Update.
3927         * python/py-linetable.c: Update.
3928         * python/py-objfile.c: Update.
3929         * python/py-param.c: Update.
3930         * python/py-prettyprint.c: Update.
3931         * python/py-progspace.c: Update.
3932         * python/py-record-btrace.c: Update.
3933         * python/py-record.c: Update.
3934         * python/py-symbol.c: Update.
3935         * python/py-type.c: Update.
3936         * python/py-unwind.c: Update.
3937         * python/py-utils.c: Update.
3938         * python/py-value.c: Update.
3939         * python/python.c: Update.
3940         * record-btrace.c: Update.
3941         * record-full.c: Update.
3942         * remote-fileio.c: Update.
3943         * remote.c: Update.
3944         * riscv-tdep.c: Update.
3945         * rs6000-aix-tdep.c: Update.
3946         * rs6000-tdep.c: Update.
3947         * rust-exp.y: Update.
3948         * rust-lang.c: Update.
3949         * s390-tdep.c: Update.
3950         * selftest-arch.c: Update.
3951         * solib-dsbt.c: Update.
3952         * solib-frv.c: Update.
3953         * solib-spu.c: Update.
3954         * solib-svr4.c: Update.
3955         * solib.c: Update.
3956         * sparc64-linux-tdep.c: Update.
3957         * stack.c: Update.
3958         * symfile-mem.c: Update.
3959         * symmisc.c: Update.
3960         * target.c: Update.
3961         * thread.c: Update.
3962         * top.c: Update.
3963         * tracefile-tfile.c: Update.
3964         * tui/tui.c: Update.
3965         * typeprint.c: Update.
3966         * unittests/cli-utils-selftests.c: Update.
3967         * unittests/parse-connection-spec-selftests.c: Update.
3968         * valops.c: Update.
3969         * valprint.c: Update.
3970         * value.c: Update.
3971         * varobj.c: Update.
3972         * windows-nat.c: Update.
3973         * x86-linux-nat.c: Update.
3974         * xml-support.c: Update.
3975
3976 2019-04-08  Tom Tromey  <tom@tromey.com>
3977
3978         * xml-support.c: Use C++ exception handling.
3979         * x86-linux-nat.c: Use C++ exception handling.
3980         * windows-nat.c: Use C++ exception handling.
3981         * varobj.c: Use C++ exception handling.
3982         * value.c: Use C++ exception handling.
3983         * valprint.c: Use C++ exception handling.
3984         * valops.c: Use C++ exception handling.
3985         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3986         handling.
3987         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3988         * typeprint.c: Use C++ exception handling.
3989         * tui/tui.c: Use C++ exception handling.
3990         * tracefile-tfile.c: Use C++ exception handling.
3991         * top.c: Use C++ exception handling.
3992         * thread.c: Use C++ exception handling.
3993         * target.c: Use C++ exception handling.
3994         * symmisc.c: Use C++ exception handling.
3995         * symfile-mem.c: Use C++ exception handling.
3996         * stack.c: Use C++ exception handling.
3997         * sparc64-linux-tdep.c: Use C++ exception handling.
3998         * solib.c: Use C++ exception handling.
3999         * solib-svr4.c: Use C++ exception handling.
4000         * solib-spu.c: Use C++ exception handling.
4001         * solib-frv.c: Use C++ exception handling.
4002         * solib-dsbt.c: Use C++ exception handling.
4003         * selftest-arch.c: Use C++ exception handling.
4004         * s390-tdep.c: Use C++ exception handling.
4005         * rust-lang.c: Use C++ exception handling.
4006         * rust-exp.y: Use C++ exception handling.
4007         * rs6000-tdep.c: Use C++ exception handling.
4008         * rs6000-aix-tdep.c: Use C++ exception handling.
4009         * riscv-tdep.c: Use C++ exception handling.
4010         * remote.c: Use C++ exception handling.
4011         * remote-fileio.c: Use C++ exception handling.
4012         * record-full.c: Use C++ exception handling.
4013         * record-btrace.c: Use C++ exception handling.
4014         * python/python.c: Use C++ exception handling.
4015         * python/py-value.c: Use C++ exception handling.
4016         * python/py-utils.c: Use C++ exception handling.
4017         * python/py-unwind.c: Use C++ exception handling.
4018         * python/py-type.c: Use C++ exception handling.
4019         * python/py-symbol.c: Use C++ exception handling.
4020         * python/py-record.c: Use C++ exception handling.
4021         * python/py-record-btrace.c: Use C++ exception handling.
4022         * python/py-progspace.c: Use C++ exception handling.
4023         * python/py-prettyprint.c: Use C++ exception handling.
4024         * python/py-param.c: Use C++ exception handling.
4025         * python/py-objfile.c: Use C++ exception handling.
4026         * python/py-linetable.c: Use C++ exception handling.
4027         * python/py-lazy-string.c: Use C++ exception handling.
4028         * python/py-infthread.c: Use C++ exception handling.
4029         * python/py-inferior.c: Use C++ exception handling.
4030         * python/py-gdb-readline.c: Use C++ exception handling.
4031         * python/py-framefilter.c: Use C++ exception handling.
4032         * python/py-frame.c: Use C++ exception handling.
4033         * python/py-finishbreakpoint.c: Use C++ exception handling.
4034         * python/py-cmd.c: Use C++ exception handling.
4035         * python/py-breakpoint.c: Use C++ exception handling.
4036         * python/py-arch.c: Use C++ exception handling.
4037         * printcmd.c: Use C++ exception handling.
4038         * ppc-linux-tdep.c: Use C++ exception handling.
4039         * parse.c: Use C++ exception handling.
4040         * p-valprint.c: Use C++ exception handling.
4041         * objc-lang.c: Use C++ exception handling.
4042         * mi/mi-main.c: Use C++ exception handling.
4043         * mi/mi-interp.c: Use C++ exception handling.
4044         * mi/mi-cmd-stack.c: Use C++ exception handling.
4045         * mi/mi-cmd-break.c: Use C++ exception handling.
4046         * main.c: Use C++ exception handling.
4047         * linux-thread-db.c: Use C++ exception handling.
4048         * linux-tdep.c: Use C++ exception handling.
4049         * linux-nat.c: Use C++ exception handling.
4050         * linux-fork.c: Use C++ exception handling.
4051         * linespec.c: Use C++ exception handling.
4052         * language.c: Use C++ exception handling.
4053         * jit.c: Use C++ exception handling.
4054         * infrun.c: Use C++ exception handling.
4055         * infcmd.c: Use C++ exception handling.
4056         * infcall.c: Use C++ exception handling.
4057         * inf-loop.c: Use C++ exception handling.
4058         * i386-tdep.c: Use C++ exception handling.
4059         * i386-linux-tdep.c: Use C++ exception handling.
4060         * guile/scm-value.c: Use C++ exception handling.
4061         * guile/scm-type.c: Use C++ exception handling.
4062         * guile/scm-symtab.c: Use C++ exception handling.
4063         * guile/scm-symbol.c: Use C++ exception handling.
4064         * guile/scm-pretty-print.c: Use C++ exception handling.
4065         * guile/scm-ports.c: Use C++ exception handling.
4066         * guile/scm-param.c: Use C++ exception handling.
4067         * guile/scm-math.c: Use C++ exception handling.
4068         * guile/scm-lazy-string.c: Use C++ exception handling.
4069         * guile/scm-frame.c: Use C++ exception handling.
4070         * guile/scm-disasm.c: Use C++ exception handling.
4071         * guile/scm-cmd.c: Use C++ exception handling.
4072         * guile/scm-breakpoint.c: Use C++ exception handling.
4073         * guile/scm-block.c: Use C++ exception handling.
4074         * guile/guile-internal.h: Use C++ exception handling.
4075         * gnu-v3-abi.c: Use C++ exception handling.
4076         * gdbtypes.c: Use C++ exception handling.
4077         * frame.c: Use C++ exception handling.
4078         * frame-unwind.c: Use C++ exception handling.
4079         * fbsd-tdep.c: Use C++ exception handling.
4080         * f-valprint.c: Use C++ exception handling.
4081         * exec.c: Use C++ exception handling.
4082         * event-top.c: Use C++ exception handling.
4083         * event-loop.c: Use C++ exception handling.
4084         * eval.c: Use C++ exception handling.
4085         * dwarf2read.c: Use C++ exception handling.
4086         * dwarf2loc.c: Use C++ exception handling.
4087         * dwarf2-frame.c: Use C++ exception handling.
4088         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4089         * dwarf-index-write.c: Use C++ exception handling.
4090         * dwarf-index-cache.c: Use C++ exception handling.
4091         * dtrace-probe.c: Use C++ exception handling.
4092         * disasm-selftests.c: Use C++ exception handling.
4093         * darwin-nat.c: Use C++ exception handling.
4094         * cp-valprint.c: Use C++ exception handling.
4095         * cp-support.c: Use C++ exception handling.
4096         * cp-abi.c: Use C++ exception handling.
4097         * corelow.c: Use C++ exception handling.
4098         * completer.c: Use C++ exception handling.
4099         * compile/compile-object-run.c: Use C++ exception handling.
4100         * compile/compile-object-load.c: Use C++ exception handling.
4101         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4102         * compile/compile-c-symbols.c: Use C++ exception handling.
4103         * common/selftest.c: Use C++ exception handling.
4104         * common/new-op.c: Use C++ exception handling.
4105         * cli/cli-script.c: Use C++ exception handling.
4106         * cli/cli-interp.c: Use C++ exception handling.
4107         * cli/cli-cmds.c: Use C++ exception handling.
4108         * c-varobj.c: Use C++ exception handling.
4109         * btrace.c: Use C++ exception handling.
4110         * breakpoint.c: Use C++ exception handling.
4111         * break-catch-throw.c: Use C++ exception handling.
4112         * arch-utils.c: Use C++ exception handling.
4113         * amd64-tdep.c: Use C++ exception handling.
4114         * ada-valprint.c: Use C++ exception handling.
4115         * ada-typeprint.c: Use C++ exception handling.
4116         * ada-lang.c: Use C++ exception handling.
4117         * aarch64-tdep.c: Use C++ exception handling.
4118
4119 2019-04-08  Tom Tromey  <tom@tromey.com>
4120
4121         * xml-support.c (gdb_xml_parser::parse): Update.
4122         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4123         * value.c (show_convenience): Update.
4124         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4125         (test_parse_flags_qcs): Update.
4126         * thread.c (thr_try_catch_cmd): Update.
4127         * target.c (target_translate_tls_address): Update.
4128         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4129         (info_frame_command_core, frame_apply_command_count): Update.
4130         * rust-exp.y (rust_lex_exception_test): Update.
4131         * riscv-tdep.c (riscv_print_one_register_info): Update.
4132         * remote.c (remote_target::enable_btrace): Update.
4133         * record-btrace.c (record_btrace_enable_warn): Update.
4134         * python/py-utils.c (gdbpy_convert_exception): Update.
4135         * printcmd.c (do_one_display, print_variable_and_value): Update.
4136         * mi/mi-main.c (mi_print_exception): Update.
4137         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4138         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4139         * linux-nat.c (linux_nat_target::attach): Update.
4140         * linux-fork.c (class scoped_switch_fork_info): Update.
4141         * infrun.c (displaced_step_prepare): Update.
4142         * infcall.c (call_function_by_hand_dummy): Update.
4143         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4144         * gnu-v3-abi.c (print_one_vtable): Update.
4145         * frame.c (get_prev_frame_always): Update.
4146         * f-valprint.c (info_common_command_for_block): Update.
4147         * exec.c (try_open_exec_file): Update.
4148         * exceptions.c (print_exception, exception_print)
4149         (exception_fprintf, exception_print_same): Update.
4150         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4151         * dwarf-index-cache.c (index_cache::store)
4152         (index_cache::lookup_gdb_index): Update.
4153         * darwin-nat.c (maybe_cache_shell): Update.
4154         * cp-valprint.c (cp_print_value_fields): Update.
4155         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4156         (gcc_cplus_symbol_address): Update.
4157         * compile/compile-c-symbols.c (gcc_convert_symbol)
4158         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4159         * common/selftest.c: Update.
4160         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4161         a std::string.
4162         (exception_try_scope_entry, exception_try_scope_exit): Don't
4163         declare.
4164         (struct exception_try_scope): Remove.
4165         (TRY): Don't use exception_try_scope.
4166         (struct gdb_exception): Add constructor, operator=.
4167         <what>: New method.
4168         (struct gdb_exception_RETURN_MASK_ALL)
4169         (struct gdb_exception_RETURN_MASK_ERROR)
4170         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4171         (struct gdb_quit_bad_alloc): Update.
4172         * common/common-exceptions.c (exception_none): Change
4173         initializer.
4174         (struct catcher) <state, exception>: Initialize inline.
4175         <prev>: Remove member.
4176         (current_catcher): Remove.
4177         (catchers): New global.
4178         (exceptions_state_mc_init): Simplify.
4179         (catcher_pop): Remove.
4180         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4181         (try_scope_depth, exception_try_scope_entry)
4182         (exception_try_scope_exit): Remove.
4183         (throw_exception_sjlj): Update.
4184         (exception_messages, exception_messages_size): Remove.
4185         (throw_it): Simplify.
4186         (gdb_exception_sliced_copy): Remove.
4187         (throw_exception_cxx): Update.
4188         * cli/cli-script.c (script_from_file): Update.
4189         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4190         Update.
4191         * ada-valprint.c (ada_val_print): Update.
4192         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4193         (create_excep_cond_exprs): Update.
4194
4195 2019-04-08  Tom Tromey  <tom@tromey.com>
4196
4197         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4198         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4199         (TRY, CATCH, END_CATCH): Remove some definitions.
4200         * common/common-exceptions.c: Don't use GDB_XCPT.
4201         (catcher_list_size): Remove.
4202         (throw_exception, throw_it): Simplify.
4203
4204 2019-04-05  Tom Tromey  <tom@tromey.com>
4205
4206         Revert the header-sorting patch.
4207         * ft32-tdep.c: Revert.
4208         * frv-tdep.c: Revert.
4209         * frv-linux-tdep.c: Revert.
4210         * frame.c: Revert.
4211         * frame-unwind.c: Revert.
4212         * frame-base.c: Revert.
4213         * fork-child.c: Revert.
4214         * findvar.c: Revert.
4215         * findcmd.c: Revert.
4216         * filesystem.c: Revert.
4217         * filename-seen-cache.h: Revert.
4218         * filename-seen-cache.c: Revert.
4219         * fbsd-tdep.c: Revert.
4220         * fbsd-nat.h: Revert.
4221         * fbsd-nat.c: Revert.
4222         * f-valprint.c: Revert.
4223         * f-typeprint.c: Revert.
4224         * f-lang.c: Revert.
4225         * extension.h: Revert.
4226         * extension.c: Revert.
4227         * extension-priv.h: Revert.
4228         * expprint.c: Revert.
4229         * exec.h: Revert.
4230         * exec.c: Revert.
4231         * exceptions.c: Revert.
4232         * event-top.c: Revert.
4233         * event-loop.c: Revert.
4234         * eval.c: Revert.
4235         * elfread.c: Revert.
4236         * dwarf2read.h: Revert.
4237         * dwarf2read.c: Revert.
4238         * dwarf2loc.c: Revert.
4239         * dwarf2expr.h: Revert.
4240         * dwarf2expr.c: Revert.
4241         * dwarf2-frame.c: Revert.
4242         * dwarf2-frame-tailcall.c: Revert.
4243         * dwarf-index-write.h: Revert.
4244         * dwarf-index-write.c: Revert.
4245         * dwarf-index-common.c: Revert.
4246         * dwarf-index-cache.h: Revert.
4247         * dwarf-index-cache.c: Revert.
4248         * dummy-frame.c: Revert.
4249         * dtrace-probe.c: Revert.
4250         * disasm.h: Revert.
4251         * disasm.c: Revert.
4252         * disasm-selftests.c: Revert.
4253         * dictionary.c: Revert.
4254         * dicos-tdep.c: Revert.
4255         * demangle.c: Revert.
4256         * dcache.h: Revert.
4257         * dcache.c: Revert.
4258         * darwin-nat.h: Revert.
4259         * darwin-nat.c: Revert.
4260         * darwin-nat-info.c: Revert.
4261         * d-valprint.c: Revert.
4262         * d-namespace.c: Revert.
4263         * d-lang.c: Revert.
4264         * ctf.c: Revert.
4265         * csky-tdep.c: Revert.
4266         * csky-linux-tdep.c: Revert.
4267         * cris-tdep.c: Revert.
4268         * cris-linux-tdep.c: Revert.
4269         * cp-valprint.c: Revert.
4270         * cp-support.c: Revert.
4271         * cp-namespace.c: Revert.
4272         * cp-abi.c: Revert.
4273         * corelow.c: Revert.
4274         * corefile.c: Revert.
4275         * continuations.c: Revert.
4276         * completer.h: Revert.
4277         * completer.c: Revert.
4278         * complaints.c: Revert.
4279         * coffread.c: Revert.
4280         * coff-pe-read.c: Revert.
4281         * cli-out.h: Revert.
4282         * cli-out.c: Revert.
4283         * charset.c: Revert.
4284         * c-varobj.c: Revert.
4285         * c-valprint.c: Revert.
4286         * c-typeprint.c: Revert.
4287         * c-lang.c: Revert.
4288         * buildsym.c: Revert.
4289         * buildsym-legacy.c: Revert.
4290         * build-id.h: Revert.
4291         * build-id.c: Revert.
4292         * btrace.c: Revert.
4293         * bsd-uthread.c: Revert.
4294         * breakpoint.h: Revert.
4295         * breakpoint.c: Revert.
4296         * break-catch-throw.c: Revert.
4297         * break-catch-syscall.c: Revert.
4298         * break-catch-sig.c: Revert.
4299         * blockframe.c: Revert.
4300         * block.c: Revert.
4301         * bfin-tdep.c: Revert.
4302         * bfin-linux-tdep.c: Revert.
4303         * bfd-target.c: Revert.
4304         * bcache.c: Revert.
4305         * ax-general.c: Revert.
4306         * ax-gdb.h: Revert.
4307         * ax-gdb.c: Revert.
4308         * avr-tdep.c: Revert.
4309         * auxv.c: Revert.
4310         * auto-load.c: Revert.
4311         * arm-wince-tdep.c: Revert.
4312         * arm-tdep.c: Revert.
4313         * arm-symbian-tdep.c: Revert.
4314         * arm-pikeos-tdep.c: Revert.
4315         * arm-obsd-tdep.c: Revert.
4316         * arm-nbsd-tdep.c: Revert.
4317         * arm-nbsd-nat.c: Revert.
4318         * arm-linux-tdep.c: Revert.
4319         * arm-linux-nat.c: Revert.
4320         * arm-fbsd-tdep.c: Revert.
4321         * arm-fbsd-nat.c: Revert.
4322         * arm-bsd-tdep.c: Revert.
4323         * arch-utils.c: Revert.
4324         * arc-tdep.c: Revert.
4325         * arc-newlib-tdep.c: Revert.
4326         * annotate.h: Revert.
4327         * annotate.c: Revert.
4328         * amd64-windows-tdep.c: Revert.
4329         * amd64-windows-nat.c: Revert.
4330         * amd64-tdep.c: Revert.
4331         * amd64-sol2-tdep.c: Revert.
4332         * amd64-obsd-tdep.c: Revert.
4333         * amd64-obsd-nat.c: Revert.
4334         * amd64-nbsd-tdep.c: Revert.
4335         * amd64-nbsd-nat.c: Revert.
4336         * amd64-nat.c: Revert.
4337         * amd64-linux-tdep.c: Revert.
4338         * amd64-linux-nat.c: Revert.
4339         * amd64-fbsd-tdep.c: Revert.
4340         * amd64-fbsd-nat.c: Revert.
4341         * amd64-dicos-tdep.c: Revert.
4342         * amd64-darwin-tdep.c: Revert.
4343         * amd64-bsd-nat.c: Revert.
4344         * alpha-tdep.c: Revert.
4345         * alpha-obsd-tdep.c: Revert.
4346         * alpha-nbsd-tdep.c: Revert.
4347         * alpha-mdebug-tdep.c: Revert.
4348         * alpha-linux-tdep.c: Revert.
4349         * alpha-linux-nat.c: Revert.
4350         * alpha-bsd-tdep.c: Revert.
4351         * alpha-bsd-nat.c: Revert.
4352         * aix-thread.c: Revert.
4353         * agent.c: Revert.
4354         * addrmap.c: Revert.
4355         * ada-varobj.c: Revert.
4356         * ada-valprint.c: Revert.
4357         * ada-typeprint.c: Revert.
4358         * ada-tasks.c: Revert.
4359         * ada-lang.c: Revert.
4360         * aarch64-tdep.c: Revert.
4361         * aarch64-ravenscar-thread.c: Revert.
4362         * aarch64-newlib-tdep.c: Revert.
4363         * aarch64-linux-tdep.c: Revert.
4364         * aarch64-linux-nat.c: Revert.
4365         * aarch64-fbsd-tdep.c: Revert.
4366         * aarch64-fbsd-nat.c: Revert.
4367         * aarch32-linux-nat.c: Revert.
4368
4369 2019-04-05  Tom Tromey  <tom@tromey.com>
4370
4371         * ft32-tdep.c: Sort headers.
4372         * frv-tdep.c: Sort headers.
4373         * frv-linux-tdep.c: Sort headers.
4374         * frame.c: Sort headers.
4375         * frame-unwind.c: Sort headers.
4376         * frame-base.c: Sort headers.
4377         * fork-child.c: Sort headers.
4378         * findvar.c: Sort headers.
4379         * findcmd.c: Sort headers.
4380         * filesystem.c: Sort headers.
4381         * filename-seen-cache.h: Sort headers.
4382         * filename-seen-cache.c: Sort headers.
4383         * fbsd-tdep.c: Sort headers.
4384         * fbsd-nat.h: Sort headers.
4385         * fbsd-nat.c: Sort headers.
4386         * f-valprint.c: Sort headers.
4387         * f-typeprint.c: Sort headers.
4388         * f-lang.c: Sort headers.
4389         * extension.h: Sort headers.
4390         * extension.c: Sort headers.
4391         * extension-priv.h: Sort headers.
4392         * expprint.c: Sort headers.
4393         * exec.h: Sort headers.
4394         * exec.c: Sort headers.
4395         * exceptions.c: Sort headers.
4396         * event-top.c: Sort headers.
4397         * event-loop.c: Sort headers.
4398         * eval.c: Sort headers.
4399         * elfread.c: Sort headers.
4400         * dwarf2read.h: Sort headers.
4401         * dwarf2read.c: Sort headers.
4402         * dwarf2loc.c: Sort headers.
4403         * dwarf2expr.h: Sort headers.
4404         * dwarf2expr.c: Sort headers.
4405         * dwarf2-frame.c: Sort headers.
4406         * dwarf2-frame-tailcall.c: Sort headers.
4407         * dwarf-index-write.h: Sort headers.
4408         * dwarf-index-write.c: Sort headers.
4409         * dwarf-index-common.c: Sort headers.
4410         * dwarf-index-cache.h: Sort headers.
4411         * dwarf-index-cache.c: Sort headers.
4412         * dummy-frame.c: Sort headers.
4413         * dtrace-probe.c: Sort headers.
4414         * disasm.h: Sort headers.
4415         * disasm.c: Sort headers.
4416         * disasm-selftests.c: Sort headers.
4417         * dictionary.c: Sort headers.
4418         * dicos-tdep.c: Sort headers.
4419         * demangle.c: Sort headers.
4420         * dcache.h: Sort headers.
4421         * dcache.c: Sort headers.
4422         * darwin-nat.h: Sort headers.
4423         * darwin-nat.c: Sort headers.
4424         * darwin-nat-info.c: Sort headers.
4425         * d-valprint.c: Sort headers.
4426         * d-namespace.c: Sort headers.
4427         * d-lang.c: Sort headers.
4428         * ctf.c: Sort headers.
4429         * csky-tdep.c: Sort headers.
4430         * csky-linux-tdep.c: Sort headers.
4431         * cris-tdep.c: Sort headers.
4432         * cris-linux-tdep.c: Sort headers.
4433         * cp-valprint.c: Sort headers.
4434         * cp-support.c: Sort headers.
4435         * cp-namespace.c: Sort headers.
4436         * cp-abi.c: Sort headers.
4437         * corelow.c: Sort headers.
4438         * corefile.c: Sort headers.
4439         * continuations.c: Sort headers.
4440         * completer.h: Sort headers.
4441         * completer.c: Sort headers.
4442         * complaints.c: Sort headers.
4443         * coffread.c: Sort headers.
4444         * coff-pe-read.c: Sort headers.
4445         * cli-out.h: Sort headers.
4446         * cli-out.c: Sort headers.
4447         * charset.c: Sort headers.
4448         * c-varobj.c: Sort headers.
4449         * c-valprint.c: Sort headers.
4450         * c-typeprint.c: Sort headers.
4451         * c-lang.c: Sort headers.
4452         * buildsym.c: Sort headers.
4453         * buildsym-legacy.c: Sort headers.
4454         * build-id.h: Sort headers.
4455         * build-id.c: Sort headers.
4456         * btrace.c: Sort headers.
4457         * bsd-uthread.c: Sort headers.
4458         * breakpoint.h: Sort headers.
4459         * breakpoint.c: Sort headers.
4460         * break-catch-throw.c: Sort headers.
4461         * break-catch-syscall.c: Sort headers.
4462         * break-catch-sig.c: Sort headers.
4463         * blockframe.c: Sort headers.
4464         * block.c: Sort headers.
4465         * bfin-tdep.c: Sort headers.
4466         * bfin-linux-tdep.c: Sort headers.
4467         * bfd-target.c: Sort headers.
4468         * bcache.c: Sort headers.
4469         * ax-general.c: Sort headers.
4470         * ax-gdb.h: Sort headers.
4471         * ax-gdb.c: Sort headers.
4472         * avr-tdep.c: Sort headers.
4473         * auxv.c: Sort headers.
4474         * auto-load.c: Sort headers.
4475         * arm-wince-tdep.c: Sort headers.
4476         * arm-tdep.c: Sort headers.
4477         * arm-symbian-tdep.c: Sort headers.
4478         * arm-pikeos-tdep.c: Sort headers.
4479         * arm-obsd-tdep.c: Sort headers.
4480         * arm-nbsd-tdep.c: Sort headers.
4481         * arm-nbsd-nat.c: Sort headers.
4482         * arm-linux-tdep.c: Sort headers.
4483         * arm-linux-nat.c: Sort headers.
4484         * arm-fbsd-tdep.c: Sort headers.
4485         * arm-fbsd-nat.c: Sort headers.
4486         * arm-bsd-tdep.c: Sort headers.
4487         * arch-utils.c: Sort headers.
4488         * arc-tdep.c: Sort headers.
4489         * arc-newlib-tdep.c: Sort headers.
4490         * annotate.h: Sort headers.
4491         * annotate.c: Sort headers.
4492         * amd64-windows-tdep.c: Sort headers.
4493         * amd64-windows-nat.c: Sort headers.
4494         * amd64-tdep.c: Sort headers.
4495         * amd64-sol2-tdep.c: Sort headers.
4496         * amd64-obsd-tdep.c: Sort headers.
4497         * amd64-obsd-nat.c: Sort headers.
4498         * amd64-nbsd-tdep.c: Sort headers.
4499         * amd64-nbsd-nat.c: Sort headers.
4500         * amd64-nat.c: Sort headers.
4501         * amd64-linux-tdep.c: Sort headers.
4502         * amd64-linux-nat.c: Sort headers.
4503         * amd64-fbsd-tdep.c: Sort headers.
4504         * amd64-fbsd-nat.c: Sort headers.
4505         * amd64-dicos-tdep.c: Sort headers.
4506         * amd64-darwin-tdep.c: Sort headers.
4507         * amd64-bsd-nat.c: Sort headers.
4508         * alpha-tdep.c: Sort headers.
4509         * alpha-obsd-tdep.c: Sort headers.
4510         * alpha-nbsd-tdep.c: Sort headers.
4511         * alpha-mdebug-tdep.c: Sort headers.
4512         * alpha-linux-tdep.c: Sort headers.
4513         * alpha-linux-nat.c: Sort headers.
4514         * alpha-bsd-tdep.c: Sort headers.
4515         * alpha-bsd-nat.c: Sort headers.
4516         * aix-thread.c: Sort headers.
4517         * agent.c: Sort headers.
4518         * addrmap.c: Sort headers.
4519         * ada-varobj.c: Sort headers.
4520         * ada-valprint.c: Sort headers.
4521         * ada-typeprint.c: Sort headers.
4522         * ada-tasks.c: Sort headers.
4523         * ada-lang.c: Sort headers.
4524         * aarch64-tdep.c: Sort headers.
4525         * aarch64-ravenscar-thread.c: Sort headers.
4526         * aarch64-newlib-tdep.c: Sort headers.
4527         * aarch64-linux-tdep.c: Sort headers.
4528         * aarch64-linux-nat.c: Sort headers.
4529         * aarch64-fbsd-tdep.c: Sort headers.
4530         * aarch64-fbsd-nat.c: Sort headers.
4531         * aarch32-linux-nat.c: Sort headers.
4532
4533 2019-04-04  Tom Tromey  <tom@tromey.com>
4534
4535         * varobj.c (varobj_create): Update.
4536         * rust-exp.y (struct rust_parser) <update_innermost_block,
4537         lookup_symbol>: New methods.
4538         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4539         Rename.
4540         (rust_parser::rust_lookup_type)
4541         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4542         * printcmd.c (display_command, do_one_display): Update.
4543         * parser-defs.h (struct parser_state) <parser_state>: Add
4544         "tracker" parameter.
4545         (block_tracker): New member.
4546         (class innermost_block_tracker) <innermost_block_tracker>: Add
4547         "types" parameter.
4548         <reset>: Remove method.
4549         (innermost_block): Don't declare.
4550         (null_post_parser): Update.
4551         * parse.c (innermost_block): Remove global.
4552         (write_dollar_variable): Update.
4553         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4554         Remove "tracker_types" parameter.
4555         (parse_expression): Add "tracker" parameter.
4556         (parse_expression_for_completion): Update.
4557         (null_post_parser): Add "tracker" parameter.
4558         * p-exp.y: Update rules.
4559         * m2-exp.y: Update rules.
4560         * language.h (struct language_defn) <la_post_parser>: Add
4561         "tracker" parameter.
4562         * go-exp.y: Update rules.
4563         * f-exp.y: Update rules.
4564         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4565         parameter.
4566         * d-exp.y: Update rules.
4567         * c-exp.y: Update rules.
4568         * breakpoint.c (set_breakpoint_condition): Create an
4569         innermost_block_tracker.
4570         (watch_command_1): Likewise.
4571         * ada-lang.c (resolve): Add "tracker" parameter.
4572         (resolve_subexp): Likewise.
4573         * ada-exp.y (write_var_from_sym): Update.
4574
4575 2019-04-04  Tom Tromey  <tom@tromey.com>
4576
4577         * type-stack.h: New file.
4578         * type-stack.c: New file.
4579         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4580         type-stack.h.
4581         (insert_into_type_stack, insert_type, push_type, push_type_int)
4582         (insert_type_address_space, pop_type, pop_type_int)
4583         (pop_typelist, pop_type_stack, append_type_stack)
4584         (push_type_stack, get_type_stack, push_typelist)
4585         (follow_type_instance_flags, follow_types): Don't declare.
4586         * parse.c (type_stack): Remove global.
4587         (parse_exp_in_context): Update.
4588         (insert_into_type_stack, insert_type, push_type, push_type_int)
4589         (insert_type_address_space, pop_type, pop_type_int)
4590         (pop_typelist, pop_type_stack, append_type_stack)
4591         (push_type_stack, get_type_stack, push_typelist)
4592         (follow_type_instance_flags, follow_types): Remove (moved to
4593         type-stack.c).
4594         * f-exp.y (type_stack): New global.
4595         Update rules.
4596         (push_kind_type, f_parse): Update.
4597         * d-exp.y (type_stack): New global.
4598         Update rules.
4599         (d_parse): Update.
4600         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4601         Update rules.
4602         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4603         (HFILES_NO_SRCDIR): Add type-stack.h.
4604
4605 2019-04-04  Tom Tromey  <tom@tromey.com>
4606
4607         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4608         (rust_parser::convert_ast_to_expression, rust_parse)
4609         (rust_lex_test_completion, rust_lex_tests): Update.
4610         * parser-defs.h (struct expr_completion_state): New.
4611         (struct parser_state) <parser_state>: Add completion parameter.
4612         <mark_struct_expression, mark_completion_tag>: New methods.
4613         <parse_completion, m_completion_state>: New members.
4614         (prefixify_expression, null_post_parser): Update.
4615         (mark_struct_expression, mark_completion_tag): Don't declare.
4616         * parse.c (parse_completion, expout_last_struct)
4617         (expout_tag_completion_type, expout_completion_name): Remove
4618         globals.
4619         (parser_state::mark_struct_expression)
4620         (parser_state::mark_completion_tag): Now methods.
4621         (prefixify_expression): Add last_struct parameter.
4622         (prefixify_subexp): Likewise.
4623         (parse_exp_1): Update.
4624         (parse_exp_in_context): Add cstate parameter.  Update.
4625         (parse_expression_for_completion): Create an
4626         expr_completion_state.
4627         (null_post_parser): Add "completion" parameter.
4628         * p-exp.y: Update rules.
4629         (yylex): Update.
4630         * language.h (struct language_defn) <la_post_parser>: Add
4631         "completing" parameter.
4632         * go-exp.y: Update rules.
4633         (lex_one_token): Update.
4634         * expression.h (parse_completion): Don't declare.
4635         * d-exp.y: Update rules.
4636         (lex_one_token): Update rules.
4637         * c-exp.y: Update rules.
4638         (lex_one_token): Update.
4639         * ada-lang.c (resolve): Add "parse_completion" parameter.
4640         (resolve_subexp): Likewise.
4641         (ada_resolve_function): Likewise.
4642
4643 2019-04-04  Tom Tromey  <tom@tromey.com>
4644
4645         * parser-defs.h (struct parser_state) <start_arglist,
4646         end_arglist>: New methods.
4647         <arglist_len, m_funcall_chain>: New members.
4648         (arglist_len, start_arglist, end_arglist): Don't declare.
4649         * parse.c (arglist_len, funcall_chain): Remove global.
4650         (start_arglist, end_arglist): Remove functions.
4651         (parse_exp_in_context): Update.
4652         * p-exp.y: Update rules.
4653         * m2-exp.y: Update rules.
4654         * go-exp.y: Update rules.
4655         * f-exp.y: Update rules.
4656         * d-exp.y: Update rules.
4657         * c-exp.y: Update rules.
4658
4659 2019-04-04  Tom Tromey  <tom@tromey.com>
4660
4661         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4662         lex_operator, push_back>: New methods.
4663         Update all rules.
4664         (rust_parser::lex_hex, lex_escape): Rename and update.
4665         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4666         (rust_parser::lex_operator): Rename and update.
4667         (rust_parser::lex_number, rustyylex, rustyyerror)
4668         (rust_lex_test_init, rust_lex_test_sequence)
4669         (rust_lex_test_push_back, rust_lex_tests): Update.
4670         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4671         parameter.
4672         <lexptr, prev_lexptr>: New members.
4673         (lexptr, prev_lexptr): Don't declare.
4674         * parse.c (lexptr, prev_lexptr): Remove globals.
4675         (parse_exp_in_context): Update.
4676         * p-exp.y (yylex, yyerror): Update.
4677         * m2-exp.y (parse_number, yylex, yyerror): Update.
4678         * go-exp.y (lex_one_token, yyerror): Update.
4679         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4680         * d-exp.y (lex_one_token, yyerror): Update.
4681         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4682         (lex_one_token, yyerror): Update.
4683         * ada-lex.l (YY_INPUT): Update.
4684         (rewind_to_char): Update.
4685         * ada-exp.y (yyerror): Update.
4686
4687 2019-04-04  Tom Tromey  <tom@tromey.com>
4688
4689         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4690         * parser-defs.h (struct parser_state) <parser_state>: Add new
4691         parameter.
4692         <comma_terminates>: New member.
4693         (comma_terminates): Don't declare global.
4694         * parse.c (comma_terminates): Remove global.
4695         (parse_exp_in_context): Update.
4696         * p-exp.y (yylex): Update.
4697         * m2-exp.y (yylex): Update.
4698         * go-exp.y (lex_one_token): Update.
4699         * f-exp.y (yylex): Update.
4700         * d-exp.y (lex_one_token): Update.
4701         * c-exp.y (lex_one_token): Update.
4702         * ada-lex.l: Update.
4703
4704 2019-04-04  Tom Tromey  <tom@tromey.com>
4705
4706         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4707         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4708         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4709         * parser-defs.h (paren_depth): Don't declare.
4710         * parse.c (paren_depth): Remove global.
4711         (parse_exp_in_context): Update.
4712         * p-exp.y (paren_depth): New global.
4713         (pascal_parse): Initialize it.
4714         * m2-exp.y (paren_depth): New global.
4715         (m2_parse): Initialize it.
4716         * go-exp.y (paren_depth): New global.
4717         (go_parse): Initialize it.
4718         * f-exp.y (paren_depth): New global.
4719         (f_parse): Initialize it.
4720         * d-exp.y (paren_depth): New global.
4721         (d_parse): Initialize it.
4722         * c-exp.y (paren_depth): New global.
4723         (c_parse): Initialize it.
4724         * ada-lex.l (paren_depth): New global.
4725         (lexer_init): Initialize it.
4726
4727 2019-04-04  Tom Tromey  <tom@tromey.com>
4728
4729         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4730         (rust_parser::convert_ast_to_type)
4731         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4732         * parser-defs.h (struct parser_state) <parser_state>: Add
4733         parameters.  Initialize new members.
4734         <expression_context_block, expression_context_pc>: New members.
4735         * parse.c (expression_context_block, expression_context_pc):
4736         Remove globals.
4737         (parse_exp_in_context): Update.
4738         * p-exp.y: Update all rules.
4739         (yylex): Update.
4740         * m2-exp.y: Update all rules.
4741         (yylex): Update.
4742         * go-exp.y (yylex): Update.
4743         * f-exp.y (yylex): Update.
4744         * d-exp.y: Update all rules.
4745         (yylex): Update.
4746         * c-exp.y: Update all rules.
4747         (lex_one_token, classify_name, yylex, c_parse): Update.
4748         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4749
4750 2019-04-04  Tom Tromey  <tom@tromey.com>
4751
4752         * gdbarch.h, gdbarch.c: Rebuild.
4753         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4754         * stap-probe.h:
4755         (struct stap_parse_info): Replace "parser_state" with
4756         "expr_builder".
4757         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4758         (parser_state): New class.
4759         * parse.c (expr_builder): Rename.
4760         (expr_builder::release): Rename.
4761         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4762         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4763         (write_exp_elt_longcst, write_exp_elt_floatcst)
4764         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4765         (write_exp_string_vector, write_exp_bitstring)
4766         (write_exp_msymbol, mark_struct_expression)
4767         (write_dollar_variable)
4768         (insert_type_address_space, increase_expout_size): Replace
4769         "parser_state" with "expr_builder".
4770         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4771         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4772         "parser_state" with "expr_builder".
4773
4774 2019-04-04  Tom Tromey  <tom@tromey.com>
4775
4776         * rust-exp.y: Replace "parse_language" with method call.
4777         * p-exp.y:
4778         (yylex): Replace "parse_language" with method call.
4779         * m2-exp.y:
4780         (yylex): Replace "parse_language" with method call.
4781         * go-exp.y (classify_name): Replace "parse_language" with method
4782         call.
4783         * f-exp.y (yylex): Replace "parse_language" with method call.
4784         * d-exp.y (lex_one_token): Replace "parse_language" with method
4785         call.
4786         * c-exp.y:
4787         (lex_one_token, classify_name, yylex): Replace "parse_language"
4788         with method call.
4789         * ada-exp.y (find_primitive_type, type_char)
4790         (type_system_address): Replace "parse_language" with method call.
4791
4792 2019-04-04  Tom Tromey  <tom@tromey.com>
4793
4794         * rust-exp.y: Replace "parse_gdbarch" with method call.
4795         * parse.c (write_dollar_variable, insert_type_address_space):
4796         Replace "parse_gdbarch" with method call.
4797         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4798         call.
4799         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4800         call.
4801         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4802         "parse_gdbarch" with method call.
4803         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4804         with method call.
4805         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4806         "parse_gdbarch" with method call.
4807         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4808         "parse_gdbarch" with method call.
4809         * c-exp.y (parse_type, parse_number, classify_name): Replace
4810         "parse_gdbarch" with method call.
4811         * ada-lex.l: Replace "parse_gdbarch" with method call.
4812         * ada-exp.y (parse_type, find_primitive_type, type_char)
4813         (type_system_address): Replace "parse_gdbarch" with method call.
4814
4815 2019-04-04  Tom Tromey  <tom@tromey.com>
4816
4817         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4818         * stap-probe.c (stap_parse_argument): Update.
4819         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4820         initial_size parameter.
4821         * rust-exp.y (rust_lex_tests): Update.
4822         * parse.c (parser_state): Update.
4823         (parse_exp_in_context): Update.
4824         * parser-defs.h (struct parser_state) <parser_state>: Remove
4825         "initial_size" parameter.
4826
4827 2019-04-04  Tom Tromey  <tom@tromey.com>
4828
4829         * parser-defs.h (increase_expout_size): Don't declare.
4830         * parse.c (increase_expout_size): Now static.
4831
4832 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4833
4834         * gnu-nat.c (gnu_nat_target::wait): Fix
4835         target_waitstatus_to_string call.
4836
4837 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4838
4839         * eval.c (evaluate_subexp_standard): Handle internal functions
4840         during Fortran function call handling.
4841
4842 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4843
4844         * NEWS: Mention new internal functions.
4845         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4846         (read_base_type): Use dwarf2_init_complex_target_type.
4847         * value.c (creal_internal_fn): New function.
4848         (cimag_internal_fn): New function.
4849         (_initialize_values): Register new internal functions.
4850
4851 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4852
4853         * infrun.c (stop_all_threads): If debug_infrun, always
4854         trace the wait status after wait_one, using
4855         target_waitstatus_to_string and target_pid_to_str.
4856         (handle_inferior_event): Replace various trace of
4857         wait status kind by a single trace.
4858         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4859         wait status kind image by target_waitstatus_to_string.
4860         * target/waitstatus.c (target_waitstatus_to_string): Fix
4861         obsolete comment.
4862
4863 2019-04-01  Tom Tromey  <tromey@adacore.com>
4864
4865         PR symtab/23331:
4866         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4867
4868 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4869             Pedro Alves  <palves@redhat.com>
4870
4871         * top.c (quit_force): Call 'finalize_values'.
4872         * value.c (finalize_values): New function.
4873         * value.h (finalize_values): Declare.
4874
4875 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4876
4877         * NEWS: Announce $_gdb_major and $_gdb_minor.
4878
4879         * top.c (init_gdb_version_vars): New function.
4880         (gdb_init): Call init_gdb_version_vars.
4881
4882 2019-03-29  Tom Tromey  <tromey@adacore.com>
4883
4884         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4885         help text.  Remove dead code.
4886
4887 2019-03-29  Keith Seitz  <keiths@redhat.com>
4888
4889         From Siddhesh Poyarekar:
4890         * f-lang.h (f77_get_upperbound): Return LONGEST.
4891         (f77_get_lowerbound): Likewise.
4892         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4893         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4894         print them.
4895         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4896         plongest to format print it.
4897         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4898         (f77_get_upperbound): Likewise.
4899         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4900         LOWER_BOUND to LONGEST.
4901         (f77_create_arrayprint_offset_tbl): Likewise.
4902
4903 2019-03-29  Keith Seitz  <keiths@redhat.com>
4904
4905         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4906         %s/pulongest for TYPE_LENGTH instead of %d in format
4907         strings.
4908         * ada-typerint.c (ada_print_type): Likewise.
4909         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4910         * compile/compile-c-support.c (generate_register_struct): Likewise.
4911         * gdbtypes.c (recursive_dump_type): Likewise.
4912         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4913         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4914         instead of %d in format strings.
4915         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4916         to std::min to ULONGEST.
4917         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4918         instead of %d in format strings.
4919         * tracepoint.c (info_scope_command): Likewise.
4920         * typeprint.c (print_offset_data::update)
4921         (print_offset_data::finish): Likewise.
4922         * xtensa-tdep.c (xtensa_store_return_value)
4923         (xtensa_push_dummy_call): Likewise.
4924
4925 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4926
4927         * windows-nat.c (display_selector): Fixed format specifications
4928         for 64-bit Cygwin.
4929
4930 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4931
4932         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4933
4934 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4935
4936         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4937         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4938         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4939         (nios2_linux_init_abi): Install it.
4940
4941 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4942
4943         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4944
4945 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4946
4947         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4948
4949 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4950             Tom Tromey  <tromey@adacore.com>
4951
4952         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4953
4954 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4955
4956         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4957         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4958         method to compute the bounds of range types. Also print "[evaluated]"
4959         if the bounds' values come from a dynamic evaluation.
4960
4961 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4962
4963         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4964         whitespace when pretty printing is on.
4965
4966 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4967
4968         * ppc-linux-nat.c: Add include.
4969
4970 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4971
4972         * NEWS: Mention AArch64 Pointer Authentication.
4973
4974 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4975
4976         * arm-linux-nat.c: Add include.
4977
4978 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4979
4980         * source-cache.c (source_cache::get_source_lines): Re-read
4981         fullname after calling open_source_file.
4982
4983 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4984
4985         * NEWS: Mention TLS support for FreeBSD.
4986
4987 2019-03-25  Tom Tromey  <tromey@adacore.com>
4988
4989         * minsyms.c (BUNCH_SIZE): Update comment.
4990         (~minimal_symbol_reader): Remove old comment.
4991         (compact_minimal_symbols): Update comment.
4992         (minimal_symbol_reader::install): Remove old comment.  Update
4993         other comments.
4994
4995 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4996
4997         * s390-linux-nat.c: Add include.
4998
4999 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5000
5001         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5002         Call linux_get_hwcap.
5003         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5004         Likewise.
5005         (aarch64_linux_get_hwcap): Remove function.
5006         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5007         declaration.
5008         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5009         linux_get_hwcap.
5010         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5011         * linux-tdep.c (linux_get_hwcap): Add function.
5012         (linux_get_hwcap2): Likewise.
5013         * linux-tdep.h (linux_get_hwcap): Add declaration.
5014         (linux_get_hwcap2): Likewise.
5015         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5016         (ppc_linux_get_hwcap2): Likewise.
5017         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5018         linux_get_hwcap.
5019         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5020         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5021         (ppc_linux_nat_target::read_description): Likewise.
5022         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5023         * s390-linux-nat.c: Likewise.
5024         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5025
5026 2019-03-24  Tom Tromey  <tom@tromey.com>
5027
5028         * ada-lang.c (standard_lookup): Simplify initialization.
5029         (ada_lookup_symbol_nonlocal): Simplify return.
5030         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5031         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5032         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5033         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5034         initialization.
5035         * solib.c (solib_global_lookup): Simplify.
5036         * symtab.c (null_block_symbol): Remove.
5037         (symbol_cache_lookup): Simplify returns.
5038         (lookup_language_this): Simplify returns.
5039         (lookup_symbol_aux): Simplify return.
5040         (lookup_local_symbol): Simplify returns.
5041         (lookup_global_symbol_from_objfile): Simplify return.
5042         (lookup_symbol_in_objfile_symtabs)
5043         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5044         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5045         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5046         * cp-namespace.c (cp_lookup_bare_symbol)
5047         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5048         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5049         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5050         (cp_lookup_symbol_via_imports): Simplify initialization.
5051         (find_symbol_in_baseclass): Likewise.
5052         * symtab.h (null_block_symbol): Remove.
5053         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5054         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5055         (d_lookup_symbol_module): Likewise.
5056         (find_symbol_in_baseclass): Simplify initialization.
5057
5058 2019-03-24  Tom Tromey  <tom@tromey.com>
5059
5060         * expression.h: Don't include symtab.h.
5061         (struct block): Forward declare.
5062
5063 2019-03-24  Tom Tromey  <tom@tromey.com>
5064
5065         * c-exp.y (typebase): Remove casts.
5066         * gdbtypes.c (lookup_unsigned_typename, )
5067         (lookup_signed_typename): Remove cast.
5068         * eval.c (parse_to_comma_and_eval): Remove cast.
5069         * parse.c (write_dollar_variable): Remove cast.
5070         * block.h (struct block) <superblock>: Now const.
5071         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5072         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5073         (map_block): Make "block" const.
5074         * symfile.h (struct quick_symbol_functions)
5075         <map_matching_symbols>: Constify block argument to "callback".
5076         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5077         const.
5078         (find_pc_sect_compunit_symtab): Make "b" const.
5079         (find_symbol_at_address): Likewise.
5080         (search_symbols): Likewise.
5081         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5082         (dw2_debug_names_lookup_symbol): Likewise.
5083         (dw2_map_matching_symbols): Update.
5084         * p-valprint.c (pascal_val_print): Remove "block".
5085         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5086         (aux_add_nonlocal_symbols): Make "block" const.
5087         (resolve_subexp): Remove cast.
5088         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5089         const.
5090         (iterate_over_file_blocks): Likewise.
5091         * f-exp.y (%union) <bval>: Remove.
5092         * coffread.c (patch_opaque_types): Make "b" const.
5093         * spu-tdep.c (spu_catch_start): Make "block" const.
5094         * c-valprint.c (print_unpacked_pointer): Remove "block".
5095         * symmisc.c (dump_symtab_1): Make "b" const.
5096         (block_depth): Make "block" const.
5097         * d-exp.y (%union) <bval>: Remove.
5098         * cp-support.h (cp_lookup_rtti_type): Update.
5099         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5100         * psymtab.c (psym_lookup_symbol): Make "block" const.
5101         (maintenance_check_psymtabs): Make "b" const.
5102         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5103         (enumerate_locals, enumerate_args): Update.
5104         * python/py-symtab.c (stpy_global_block): Make "block" const.
5105         (stpy_static_block): Likewise.
5106         * inline-frame.c (block_starting_point_at): Make "new_block"
5107         const.
5108         * block.c (find_block_in_blockvector): Make return type const.
5109         (blockvector_for_pc_sect): Make "b" const.
5110         (find_block_in_blockvector): Make "b" const.
5111
5112 2019-03-23  Tom Tromey  <tom@tromey.com>
5113
5114         * varobj.c (varobj_create): Update.
5115         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5116         * printcmd.c (display_command, do_one_display): Don't reset
5117         innermost_block.
5118         * parser-defs.h (enum innermost_block_tracker_type): Move to
5119         expression.h.
5120         (innermost_block): Update comment.
5121         * parse.c (parse_exp_1): Add tracker_types parameter.
5122         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5123         tracker_types parameter.  Reset innermost_block.
5124         (parse_exp_in_context): Remove.
5125         (parse_expression_for_completion): Update.
5126         * objfiles.c (~objfile): Don't reset expression_context_block or
5127         innermost_block.
5128         * expression.h (enum innermost_block_tracker_type): Move from
5129         parser-defs.h.
5130         (parse_exp_1): Add tracker_types parameter.
5131         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5132         reset innermost_block.
5133
5134 2019-03-23  Tom Tromey  <tom@tromey.com>
5135
5136         * objfiles.h: Include bcache.h.
5137
5138 2019-03-23  Tom Tromey  <tom@tromey.com>
5139
5140         * linespec.c (get_current_search_block): Use
5141         scoped_restore_current_language.
5142         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5143
5144 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5145             Jiong Wang  <jiong.wang@arm.com>
5146
5147         * aarch64-linux-tdep.c
5148         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5149         section.
5150         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5151
5152 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5153             Jiong Wang  <jiong.wang@arm.com>
5154
5155         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5156         instructions.
5157         (aarch64_analyze_prologue_test): Add PACIASP test.
5158         (aarch64_prologue_prev_register): Unmask PC value.
5159
5160 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5161             Jiong Wang  <jiong.wang@arm.com>
5162
5163         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5164         (aarch64_dwarf2_prev_register): Unmask PC value.
5165         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5166         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5167         DW_CFA_AARCH64_negate_ra_state.
5168         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5169
5170 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5171             Jiong Wang  <jiong.wang@arm.com>
5172
5173         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5174         registers.
5175         (aarch64_pseudo_register_name): Likewise.
5176         (aarch64_pseudo_register_type): Likewise.
5177         (aarch64_pseudo_register_reggroup_p): Likewise.
5178         (aarch64_gdbarch_init): Add pauth registers.
5179         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5180         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5181         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5182         (struct gdbarch_tdep): Add regnum for ra_state.
5183
5184 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5185             Jiong Wang  <jiong.wang@arm.com>
5186
5187         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5188
5189 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5190             Jiong Wang  <jiong.wang@arm.com>
5191
5192         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5193         function.
5194         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5195         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5196         (aarch64_gdbarch_init): Add puth registers.
5197         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5198         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5199         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5200
5201 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5202             Jiong Wang  <jiong.wang@arm.com>
5203
5204         * aarch64-linux-nat.c
5205         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5206         * aarch64-linux-tdep.c
5207         (aarch64_linux_core_read_description): Likewise.
5208         (aarch64_linux_get_hwcap): New function.
5209         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5210         (aarch64_linux_get_hwcap): New declaration.
5211
5212 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5213             Jiong Wang  <jiong.wang@arm.com>
5214
5215         * aarch64-linux-nat.c
5216         (aarch64_linux_nat_target::read_description): Add pauth param.
5217         * aarch64-linux-tdep.c
5218         (aarch64_linux_core_read_description): Likewise.
5219         * aarch64-tdep.c (struct target_desc): Add in pauth.
5220         (aarch64_read_description): Add pauth param.
5221         (aarch64_gdbarch_init): Likewise.
5222         * aarch64-tdep.h (aarch64_read_description): Likewise.
5223         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5224         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5225         * features/Makefile: Add new files.
5226         * features/aarch64-pauth.c: New file.
5227         * features/aarch64-pauth.xml: New file.
5228
5229 2019-03-20  Tom Tromey  <tromey@adacore.com>
5230
5231         * infrun.c (handle_inferior_event): Rename from
5232         handle_inferior_event_1.  Create a scoped_value_mark.
5233         (handle_inferior_event): Remove.
5234
5235 2019-03-19  Tom Tromey  <tromey@adacore.com>
5236
5237         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5238         * infrun.h (print_stop_event): Add "displays" parameter.
5239         * infrun.c (print_stop_event): Add "displays" parameter.
5240
5241 2019-03-19  Pedro Alves  <palves@redhat.com>
5242
5243         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5244         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5245         to -1.  Fix TABs vs spaces.
5246         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5247         * tui/tui-out.h (tui_ui_out) Add intro comments.
5248         <m_line, m_start_of_line>: In-class initialize, and add describing
5249         comment.
5250
5251 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5252
5253         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5254         variable names.
5255         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5256
5257 2019-03-18  Pedro Alves  <palves@redhat.com>
5258             Eli Zaretskii <eliz@gnu.org>
5259
5260         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5261         m_line and m_start_of_line.
5262
5263 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5264
5265         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5266         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5267         it returns a newline.  This fixes a regression in TU mode, whereby
5268         the next line is output on the same screen line as the user input.
5269
5270 2019-03-18  Tom Tromey  <tromey@adacore.com>
5271
5272         * minsyms.c (minimal_symbol_reader::install): Remove call to
5273         obstack_blank.
5274
5275 2019-03-18  Pedro Alves  <palves@redhat.com>
5276
5277         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5278         New globals.
5279         (apply_style): New, factored out from ...
5280         (apply_ansi_escape): ... this.  Handle reverse video mode.
5281         (tui_set_reverse_mode): New function.
5282         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5283         * tui/tui-winsource.c (tui_show_source_line): Use
5284         tui_set_reverse_mode instead of setting A_STANDOUT.
5285         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5286         New setter methods.
5287
5288 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5289
5290         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5291         Handle tabs.
5292
5293 2019-03-18  Tom Tromey  <tromey@adacore.com>
5294
5295         * ada-lang.c (empty_array): Add "high" parameter.
5296         (ada_evaluate_subexp): Update.
5297
5298 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5299
5300         * unittests/string_view-selftests.c: Define
5301         _initialize_string_view_selftests unconditionally.
5302
5303 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5304
5305         PR gdb/24350
5306         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5307
5308 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5309
5310         PR gdb/24351
5311         * windows-nat.c (display_selector): Fix format specifiers.
5312
5313 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5314
5315         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5316         tui_refill_source_window instead of tui_refresh_win, to update the
5317         current execution line.  This fixes redisplay of the current line
5318         when stepping through the code with "next" or "step".
5319
5320 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5321
5322         * source-cache.c (source_cache::get_source_lines): Call
5323         find_source_lines to initialize s->nlines.  This fixes vertical
5324         scrolling of TUI source window when the DOWN arrow is pressed.
5325
5326 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5327
5328         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5329         linux-thread-db.c (_initialize_thread_db): Likewise.
5330
5331 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5332
5333         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5334         wclrtoeol in tui_show_source_line".  This reverts changes made in
5335         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5336
5337 2019-03-15  Tom Tromey  <tom@tromey.com>
5338
5339         * symtab.h (struct minimal_symbol): Derive from
5340         general_symbol_info.
5341         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5342         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5343         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5344         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5345         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5346         (MSYMBOL_SEARCH_NAME): Update.
5347         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5348         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5349         * minsyms.c (minimal_symbol_reader::record_full): Update.
5350
5351 2019-03-15  Tom Tromey  <tom@tromey.com>
5352
5353         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5354
5355 2019-03-15  Tom Tromey  <tom@tromey.com>
5356
5357         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5358         unique_xmalloc_ptr.
5359         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5360         Update.
5361         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5362         (build_minimal_symbol_hash_tables)
5363         (minimal_symbol_reader::install): Update.
5364
5365 2019-03-15  Tom Tromey  <tom@tromey.com>
5366
5367         * symtab.c (create_demangled_names_hash): Update.
5368         (symbol_set_names): Update.
5369         * objfiles.h (struct objfile_per_bfd_storage)
5370         <demangled_names_hash>: Now an htab_up.
5371         * objfiles.c (objfile_per_bfd_storage): Simplify.
5372
5373 2019-03-15  Tom Tromey  <tom@tromey.com>
5374
5375         * objfiles.h (struct objfile_per_bfd_storage): Declare
5376         destructor.
5377         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5378         New.
5379         (get_objfile_bfd_data): Use new.  Don't initialize
5380         language_of_main.
5381         (free_objfile_per_bfd_storage): Remove.
5382         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5383
5384 2019-03-15  Tom Tromey  <tom@tromey.com>
5385
5386         * symfile.c (reread_symbols): Update.
5387         * objfiles.c (objfile::objfile): Update.
5388         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5389         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5390         comment.
5391         (minimal_symbol_reader::install): Update.
5392         (terminate_minimal_symbol_table): Remove.
5393         * jit.c (jit_object_close_impl): Update.
5394
5395 2019-03-15  Tom Tromey  <tom@tromey.com>
5396
5397         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5398         initializations.
5399
5400 2019-03-15  Tom Tromey  <tom@tromey.com>
5401
5402         * objfiles.h (struct objfile_per_bfd_storage)
5403         <demangled_hash_languages>: Now a bitset.
5404         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5405         (lookup_minimal_symbol): Update.
5406
5407 2019-03-15  Tom Tromey  <tom@tromey.com>
5408
5409         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5410         Don't return the symbol.
5411         * coffread.c (record_minimal_symbol): Use record_full.
5412
5413 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5414
5415         The MS-Windows port of ncurses fails to switch to a color pair if
5416         one or both of the colors are the implicit default colors.  This
5417         change records the default colors when TUI is initialized, and
5418         then specifies them explicitly when a color pair uses the default
5419         colors.  This allows color styling in TUI mode on MS-Windows.
5420
5421         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5422         ncurses_norm_attr.
5423         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5424         colors in ncurses_norm_attr.
5425         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5426         "none", replace it with the default color recorded in
5427         ncurses_norm_attr.
5428
5429 2019-03-14  Tom Tromey  <tromey@adacore.com>
5430
5431         * source-cache.h (class source_cache) <get_source_lines>: Return
5432         std::string.
5433         * source-cache.c (source_cache::extract_lines): Handle case where
5434         first_pos==npos.  Return std::string.
5435         (source_cache::get_source_lines): Update.
5436
5437 2019-03-14  Tom Tromey  <tromey@adacore.com>
5438
5439         * NEWS: Add item for "style sources" commands.
5440         * source-cache.c (source_cache::get_source_lines): Check
5441         source_styling.
5442         * cli/cli-style.c (source_styling): New global.
5443         (_initialize_cli_style): Add "style sources" commands.
5444         (show_style_sources): New function.
5445         * cli/cli-style.h (source_styling): Declare.
5446
5447 2019-03-14  Pedro Alves  <palves@redhat.com>
5448             Tom Tromey  <tromey@adacore.com>
5449
5450         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5451         * tui/tui-winsource.c (tui_refill_source_window): New function,
5452         from...
5453         (tui_horizontal_source_scroll): ... here.  Move some logic.
5454         * cli/cli-style.c (set_style_enabled): Notify new observable.
5455         * tui/tui-hooks.c (tui_redisplay_source): New function.
5456         (tui_attach_detach_observers): Attach or detach
5457         tui_redisplay_source.
5458         * observable.h (source_styling_changed): New observable.
5459         * observable.c: Define source_styling_changed observable.
5460
5461 2019-03-13  Tom Tromey  <tromey@adacore.com>
5462
5463         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5464         (i386_gnu_nat_target::store_registers): Update.
5465         * target-debug.h (target_debug_print_std_string): New macro.
5466         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5467         * windows-tdep.c (display_one_tib): Update.
5468         * tui/tui-stack.c (tui_make_status_line): Update.
5469         * top.c (print_inferior_quit_action): Update.
5470         * thread.c (thr_try_catch_cmd): Update.
5471         (add_thread_with_info): Update.
5472         (thread_target_id_str): Update.
5473         (thr_try_catch_cmd): Update.
5474         (thread_command): Update.
5475         (thread_find_command): Update.
5476         * record-btrace.c (record_btrace_target::info_record)
5477         (record_btrace_resume_thread, record_btrace_target::resume)
5478         (record_btrace_cancel_resume, record_btrace_step_thread)
5479         (record_btrace_target::wait, record_btrace_target::wait)
5480         (record_btrace_target::wait, record_btrace_target::stop): Update.
5481         * progspace.c (print_program_space): Update.
5482         * process-stratum-target.c
5483         (process_stratum_target::thread_address_space): Update.
5484         * linux-fork.c (linux_fork_mourn_inferior)
5485         (detach_checkpoint_command, info_checkpoints_command)
5486         (linux_fork_context): Update.
5487         (linux_fork_detach): Update.
5488         (class scoped_switch_fork_info): Update.
5489         (delete_checkpoint_command): Update.
5490         * infrun.c (follow_fork_inferior): Update.
5491         (follow_fork_inferior): Update.
5492         (proceed_after_vfork_done): Update.
5493         (handle_vfork_child_exec_or_exit): Update.
5494         (follow_exec): Update.
5495         (displaced_step_prepare_throw): Update.
5496         (displaced_step_restore): Update.
5497         (start_step_over): Update.
5498         (resume_1): Update.
5499         (clear_proceed_status_thread): Update.
5500         (proceed): Update.
5501         (print_target_wait_results): Update.
5502         (do_target_wait): Update.
5503         (context_switch): Update.
5504         (stop_all_threads): Update.
5505         (restart_threads): Update.
5506         (finish_step_over): Update.
5507         (handle_signal_stop): Update.
5508         (switch_back_to_stepped_thread): Update.
5509         (keep_going_pass_signal): Update.
5510         (print_exited_reason): Update.
5511         (normal_stop): Update.
5512         * inferior.c (inferior_pid_to_str): Change return type.
5513         (print_selected_inferior): Update.
5514         (add_inferior): Update.
5515         (detach_inferior): Update.
5516         * dummy-frame.c (fprint_dummy_frames): Update.
5517         * dcache.c (dcache_info_1): Update.
5518         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5519         (btrace_fetch, btrace_clear): Update.
5520         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5521         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5522         type.
5523         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5524         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5525         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5526         * gdbarch.c, gdbarch.h: Rebuild.
5527         * gdbarch.sh (core_pid_to_str): Change return type.
5528         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5529         return type.
5530         (windows_nat_target::pid_to_str): Change return type.
5531         (windows_delete_thread): Update.
5532         (windows_nat_target::attach): Update.
5533         (windows_nat_target::files_info): Update.
5534         * target-delegates.c: Rebuild.
5535         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5536         return type.
5537         (sol_thread_target::pid_to_str): Change return type.
5538         * remote.c (class remote_target) <pid_to_str>: Change return
5539         type.
5540         (remote_target::pid_to_str): Change return type.
5541         (extended_remote_target::attach, remote_target::remote_stop_ns)
5542         (remote_target::remote_notif_remove_queued_reply)
5543         (remote_target::push_stop_reply, remote_target::disable_btrace):
5544         Update.
5545         (extended_remote_target::attach): Update.
5546         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5547         type.
5548         (gdbsim_target::pid_to_str): Change return type.
5549         * ravenscar-thread.c (struct ravenscar_thread_target)
5550         <pid_to_str>: Change return type.
5551         (ravenscar_thread_target::pid_to_str): Change return type.
5552         * procfs.c (class procfs_target) <pid_to_str>: Change return
5553         type.
5554         (procfs_target::pid_to_str): Change return type.
5555         (procfs_target::attach): Update.
5556         (procfs_target::detach): Update.
5557         (procfs_target::fetch_registers): Update.
5558         (procfs_target::store_registers): Update.
5559         (procfs_target::wait): Update.
5560         (procfs_target::files_info): Update.
5561         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5562         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5563         return type.
5564         (nto_procfs_target::pid_to_str): Change return type.
5565         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5566         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5567         return type.
5568         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5569         (exit_lwp): Update.
5570         (attach_proc_task_lwp_callback, get_detach_signal)
5571         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5572         (linux_nat_target::resume, wait_lwp, stop_callback)
5573         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5574         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5575         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5576         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5577         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5578         type.
5579         (inf_ptrace_target::attach): Update.
5580         (inf_ptrace_target::files_info): Update.
5581         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5582         type.
5583         (go32_nat_target::pid_to_str): Change return type.
5584         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5585         (gnu_nat_target::wait): Update.
5586         (gnu_nat_target::wait): Update.
5587         (gnu_nat_target::resume): Update.
5588         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5589         (fbsd_nat_target::wait): Update.
5590         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5591         type.
5592         (darwin_nat_target::attach): Update.
5593         * corelow.c (class core_target) <pid_to_str>: Change return type.
5594         (core_target::pid_to_str): Change return type.
5595         * target.c (normal_pid_to_str): Change return type.
5596         (default_pid_to_str): Likewise.
5597         (target_pid_to_str): Change return type.
5598         (target_translate_tls_address): Update.
5599         (target_announce_detach): Update.
5600         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5601         return type.
5602         (bsd_uthread_target::pid_to_str): Change return type.
5603         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5604         type.
5605         (bsd_kvm_target::pid_to_str): Change return type.
5606         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5607         return type.
5608         (aix_thread_target::pid_to_str): Change return type.
5609         * target.h (struct target_ops) <pid_to_str>: Change return type.
5610         (target_pid_to_str, normal_pid_to_str): Likewise.
5611         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5612         type.
5613         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5614         type.
5615         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5616         return type.
5617         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5618         type.
5619         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5620         type.
5621         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5622         return type.
5623
5624 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5625
5626         * NEWS: Mention that the new default MI version is 3.  Mention
5627         changes to the output of commands and events that deal with
5628         multi-location breakpoints.
5629         * breakpoint.c: Include "mi/mi-out.h".
5630         (print_one_breakpoint): Change output syntax if using MI version
5631         >= 3.
5632         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5633         New.
5634         (mi_multi_location_breakpoint_output_fixed): New.
5635         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5636         (mi_cmd_fix_multi_location_breakpoint_output): New.
5637         (mi_multi_location_breakpoint_output_fixed): New.
5638         * mi/mi-cmds.c (mi_cmds): Register command
5639         -fix-multi-location-breakpoint-output.
5640         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5641         interpreter "mi".
5642
5643 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5644
5645         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5646         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5647         instantiate mi_ui_out based on interpreter name.
5648         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5649         * mi/mi-main.c (mi_load_progress): Likewise.
5650
5651 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5652
5653         * NEWS: Combine separate "New targets" sections for 8.3.
5654
5655 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5656
5657         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5658         (ppcfbsd_init_abi): Install gdbarch
5659         "fetch_tls_load_module_address" and "get_thread_local_address"
5660         methods.
5661
5662 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5663
5664         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5665         (riscv_fbsd_init_abi): Install gdbarch
5666         "fetch_tls_load_module_address" and "get_thread_local_address"
5667         methods.
5668
5669 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5670
5671         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5672         (i386fbsd_init_abi): Install gdbarch
5673         "fetch_tls_load_module_address" and "get_thread_local_address"
5674         methods.
5675
5676 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5677
5678         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5679         (amd64fbsd_init_abi): Install gdbarch
5680         "fetch_tls_load_module_address" and "get_thread_local_address"
5681         methods.
5682
5683 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5684
5685         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5686         (struct fbsd_pspace_data): New type.
5687         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5688         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5689         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5690         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5691         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5692
5693 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5694
5695         * gdbtypes.c (lookup_struct_elt): New function.
5696         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5697         * gdbtypes.h (struct struct_elt): New type.
5698         (lookup_struct_elt): New prototype.
5699
5700 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5701
5702         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5703         remove disabled code block.
5704
5705 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5706
5707         * gdbarch.sh (get_thread_local_address): New method.
5708         * gdbarch.h, gdbarch.c: Regenerate.
5709         * target.c (target_translate_tls_address): Use
5710         gdbarch_get_thread_local_address if present instead of
5711         target::get_thread_local_address.
5712
5713 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5714
5715         * target.h (target::get_thread_local_address): Update comment.
5716
5717 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5718
5719         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5720         objfile->separate_debug_objfile_backlink if not NULL.
5721
5722 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5723
5724         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5725         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5726         (amd64bsd_store_inferior_registers): Likewise.
5727         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5728         Enable segment base registers.
5729         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5730         PT_GETFSBASE and PT_GETGSBASE.
5731         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5732         PT_SETGSBASE.
5733         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5734         segment base registers.
5735         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5736
5737 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5738
5739         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5740         Update calls to i386_target_description to add 'segments'
5741         parameter.
5742         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5743         add segment base registers.
5744         * arch/i386.c (i386_create_target_description): Add 'segments'
5745         parameter to enable segment base registers.
5746         * arch/i386.h (i386_create_target_description): Likewise.
5747         * features/i386/32bit-segments.xml: New file.
5748         * features/i386/32bit-segments.c: Generate.
5749         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5750         call to i386_target_description to add 'segments' parameter.
5751         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5752         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5753         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5754         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5755         if feature is present.
5756         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5757         Add 'segments' parameter to call to i386_target_description.
5758         (i386_target_description): Add 'segments' parameter to enable
5759         segment base registers.
5760         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5761         to call to i386_target_description.
5762         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5763         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5764         Define I386_NUM_REGS.
5765         (i386_target_description): Add 'segments' parameter to enable
5766         segment base registers.
5767
5768 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5769
5770         PR/24325
5771         * source-cache.c: #undef open and close, to avoid unresolved
5772         externals during linking.
5773
5774 2019-03-12  Tom Tromey  <tromey@adacore.com>
5775
5776         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5777         const.  Add initializers.
5778         (_initialize_remote): Don't initialize ptid globals.
5779
5780 2019-03-12  Pedro Alves  <palves@redhat.com>
5781
5782         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5783
5784 2019-03-12  Pedro Alves  <palves@redhat.com>
5785
5786         * cp-name-parser.y (main): Remove unused 'len' variable.
5787
5788 2019-03-12  Tom Tromey  <tromey@adacore.com>
5789
5790         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5791         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5792
5793 2019-03-12  Tom Tromey  <tromey@adacore.com>
5794
5795         * linux-nat.c (iterate_over_lwps): Update.
5796         (stop_callback): Remove parameter.
5797         (stop_wait_callback, detach_callback, resume_set_callback)
5798         (select_singlestep_lwp_callback, set_ignore_sigint)
5799         (status_callback, resumed_callback, resume_clear_callback)
5800         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5801         data parameter.
5802         (linux_nat_target::detach, linux_nat_target::resume)
5803         (linux_stop_and_wait_all_lwps, select_event_lwp)
5804         (linux_nat_filter_event, linux_nat_wait_1)
5805         (linux_nat_target::kill, linux_nat_target::stop)
5806         (linux_nat_target::stop): Update.
5807         (linux_nat_resume_callback): Change type.
5808         (resume_stopped_resumed_lwps, count_events_callback)
5809         (select_event_lwp_callback): Likewise.
5810         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5811         * arm-linux-nat.c (struct update_registers_data): Remove.
5812         (update_registers_callback): Change type.
5813         (arm_linux_insert_hw_breakpoint1): Update.
5814         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5815         parameter.
5816         (x86_linux_dr_set_addr): Update.
5817         (x86_linux_dr_set_control): Update.
5818         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5819         (iterate_over_lwps): Use gdb::function_view.
5820         * nat/aarch64-linux-hw-point.c (struct
5821         aarch64_dr_update_callback_param): Remove.
5822         (debug_reg_change_callback): Change type.
5823         (aarch64_notify_debug_reg_change): Update.
5824         * s390-linux-nat.c (s390_refresh_per_info): Update.
5825
5826 2019-03-11  Tom Tromey  <tromey@adacore.com>
5827
5828         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5829         redundant assignment to "this_cu".
5830
5831 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5832
5833         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5834
5835 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5836
5837         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5838         from...
5839         (rank_one_type): ... this.
5840
5841 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5842
5843         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5844         from...
5845         (rank_one_type): ... this.
5846
5847 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5848
5849         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5850         from...
5851         (rank_one_type): ... this.
5852
5853 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5854
5855         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5856         from...
5857         (rank_one_type): ... this.
5858
5859 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5860
5861         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5862         from...
5863         (rank_one_type): ... this.
5864
5865 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5866
5867         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5868         from...
5869         (rank_one_type): ... this.
5870
5871 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5872
5873         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5874         from...
5875         (rank_one_type): ... this.
5876
5877 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5878
5879         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5880         from...
5881         (rank_one_type): ... this.
5882
5883 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5884
5885         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5886         from...
5887         (rank_one_type): ... this.
5888
5889 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5890
5891         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5892         from...
5893         (rank_one_type): ... this.
5894
5895 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5896
5897         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5898         from...
5899         (rank_one_type): ... this.
5900
5901 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5902
5903         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5904         from...
5905         (rank_one_type): ... this.
5906
5907 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5908
5909         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5910         inferior-events' shows the example events.
5911
5912 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5913
5914         Support styling on native MS-Windows console
5915
5916         PR/24315
5917         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5918         on MS-Windows if $TERM is not defined.
5919
5920         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5921
5922         * posix-hdep.c (gdb_console_fputs):
5923         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5924         functions.
5925         * ui-file.h (gdb_console_fputs): Add prototype.
5926
5927         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5928         back to fputs only if the former returns zero.
5929
5930 2019-03-07  Tom Tromey  <tom@tromey.com>
5931
5932         * symmisc.c (print_symbol_bcache_statistics): Update.
5933         (print_objfile_statistics): Update.
5934         * symfile.c (allocate_symtab): Update.
5935         * stabsread.c: Don't include bcache.h.
5936         * psymtab.h (struct psymbol_bcache): Don't declare.
5937         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5938         (psymbol_bcache_init, psymbol_bcache_free)
5939         (psymbol_bcache_get_bcache): Don't declare.
5940         * psymtab.c (struct psymbol_bcache): Remove.
5941         (psymtab_storage::psymtab_storage): Update.
5942         (psymtab_storage::~psymtab_storage): Update.
5943         (psymbol_bcache_init, psymbol_bcache_free)
5944         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5945         (add_psymbol_to_bcache): Update.
5946         (allocate_psymtab): Update.
5947         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5948         macro_cache>: No longer pointers.
5949         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5950         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5951         * macrotab.c (macro_bcache): Update.
5952         * macroexp.c: Don't include bcache.h.
5953         * gdbtypes.c (check_types_worklist): Update.
5954         (types_deeply_equal): Remove TRY/CATCH.  Update.
5955         * elfread.c (elf_symtab_read): Update.
5956         * dwarf2read.c: Don't include bcache.h.
5957         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5958         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5959         (print_bcache_statistics, bcache_memory_used): Don't declare.
5960         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5961         methods.  Rename all data members.
5962         * bcache.c (struct bcache): Move to bcache.h.
5963         (bcache::expand_hash_table): Rename from expand_hash_table.
5964         (bcache): Remove.
5965         (bcache::insert): Rename from bcache_full.
5966         (bcache::compare): Rename from bcache_compare.
5967         (bcache_xmalloc): Remove.
5968         (bcache::~bcache): Rename from bcache_xfree.
5969         (bcache::print_statistics): Rename from print_bcache_statistics.
5970         (bcache::memory_used): Rename from bcache_memory_used.
5971
5972 2019-03-07  Pedro Alves  <palves@redhat.com>
5973
5974         * infrun.c (normal_stop): Also check for
5975         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5976
5977 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5978
5979         * f-lang.c (value_from_host_double): Moved to...
5980         * value.c (value_from_host_double): ...here.
5981         * value.h (value_from_host_double): Declare.
5982         * guile/scm-math.c (vlscm_convert_typed_number): Use
5983         value_from_host_double.
5984         (vlscm_convert_number): Likewise.
5985         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5986         * python/py-value.c (convert_value_from_python): Likewise.
5987
5988 2019-03-06  Tom Tromey  <tom@tromey.com>
5989
5990         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5991
5992 2019-03-06  Tom Tromey  <tom@tromey.com>
5993
5994         * utils.h (free_current_contents): Don't declare.
5995         * utils.c (free_current_contents): Remove.
5996
5997 2019-03-06  Tom Tromey  <tom@tromey.com>
5998
5999         * top.c (quit_force): Update.
6000         * main.c (captured_command_loop): Update.
6001         * common/new-op.c (operator new): Update.
6002         * common/common-exceptions.c (struct catcher)
6003         <save_cleanup_chain>: Remove member.
6004         (exceptions_state_mc_init): Update.
6005         (exception_try_scope_entry): Return nullptr.
6006         (exception_try_scope_exit, exception_rethrow)
6007         (throw_exception_sjlj, throw_exception_cxx): Update.
6008         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6009         (all_cleanups, do_cleanups, discard_cleanups)
6010         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6011         (restore_cleanups, restore_final_cleanups): Don't declare.
6012         (do_final_cleanups): Remove parameter.
6013         * common/cleanups.c (cleanup_chain, make_cleanup)
6014         (make_cleanup_dtor, all_cleanups, do_cleanups)
6015         (discard_my_cleanups, discard_cleanups)
6016         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6017         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6018         (null_cleanup): Remove.
6019         (do_final_cleanups): Remove parameter.
6020
6021 2019-03-06  Tom Tromey  <tom@tromey.com>
6022
6023         * remote.c (remote_target::remote_parse_stop_reply): Use
6024         unique_xmalloc_ptr.
6025
6026 2019-03-06  Tom Tromey  <tom@tromey.com>
6027
6028         * stabsread.c (struct stabs_field_info): Rename from field_info.
6029         <list, fnlist>: Add initializers.
6030         <obstack>: New member.
6031         (read_member_functions, read_struct_fields, read_baseclasses):
6032         Allocate on obstack.  Don't use cleanups.
6033         (read_one_struct_field, read_member_functions, read_struct_fields)
6034         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6035         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6036         (read_struct_type): Update.
6037
6038 2019-03-06  Tom Tromey  <tom@tromey.com>
6039
6040         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6041         * common/filestuff.h (make_cleanup_close): Don't declare.
6042         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6043         Remove.
6044
6045 2019-03-06  Tom Tromey  <tom@tromey.com>
6046
6047         * solib-aix.c: Use make_scope_exit.
6048
6049 2019-03-06  Tom Tromey  <tom@tromey.com>
6050
6051         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6052         Use make_scope_exit.
6053
6054 2019-03-06  Tom Tromey  <tom@tromey.com>
6055
6056         * solib-svr4.c (disable_probes_interface): Remove parameter.
6057         (svr4_handle_solib_event): Use make_scope_exit.
6058
6059 2019-03-06  Tom Tromey  <tom@tromey.com>
6060
6061         * remote.c (struct stop_reply_deleter): Remove.
6062         (stop_reply_up): Update.
6063         (struct stop_reply): Derive from notif_event.  Don't typedef.
6064         <regcache>: Now a std::vector.
6065         (stop_reply_xfree): Remove.
6066         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6067         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6068         (remote_target::discard_pending_stop_replies): Use delete.
6069         (remote_target::remote_parse_stop_reply): Update.
6070         (remote_target::process_stop_reply): Update.
6071         * remote-notif.h (struct notif_event): Add virtual destructor.
6072         Remove "dtr" member.
6073         (struct notif_client) <alloc_event>: Return a unique_ptr.
6074         (notif_event_xfree): Don't declare.
6075         (notif_event_up): New typedef.
6076         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6077         (notif_event_xfree, do_notif_event_xfree): Remove.
6078         (remote_notif_state_xfree): Update.
6079
6080 2019-03-06  Tom Tromey  <tom@tromey.com>
6081
6082         * infrun.c (displaced_step_clear_cleanup): Now a
6083         forward_scope_exit type.
6084         (displaced_step_prepare_throw): Update.
6085         (displaced_step_fixup): Update.
6086
6087 2019-03-06  Tom Tromey  <tom@tromey.com>
6088
6089         * inferior.h (class inferior): Update comment.
6090         * gdbthread.h (class thread_info): Update comment.
6091
6092 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6093             Tom Tromey  <tom@tromey.com>
6094
6095         * stabsread.h (struct stab_section_list): Remove.
6096         (coffstab_build_psymtabs): Update.
6097         * dbxread.c (symbuf_sections): Now a std::vector.
6098         (sect_idx): New global.
6099         (fill_symbuf): Update.
6100         (coffstab_build_psymtabs): Change type of stabsects parameter.
6101         Update.
6102         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6103         std::vector.
6104         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6105         (coff_locate_sections): Update.
6106         (coff_symfile_read): Remove cleanups.  Update.
6107         (init_stringtab): Add storage parameter.
6108         (free_stringtab, free_stringtab_cleanup): Remove.
6109         (init_lineno): Add storage parameter.
6110         (free_linetab, free_linetab_cleanup): Remove.
6111
6112 2019-03-06  Pedro Alves  <palves@redhat.com>
6113
6114         * linux-fork.c (fork_info::clobber_regs): Delete.
6115         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6116         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6117         comment.  Adjust.
6118         (scoped_switch_fork_info::scoped_switch_fork_info)
6119         (checkpoint_command, linux_fork_context): Adjust
6120         fork_save_infrun_state calls.
6121
6122 2019-03-06  Pedro Alves  <palves@redhat.com>
6123
6124         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6125         (inf_has_multiple_threads): Return 'bool' and rewrite using
6126         inferior_info::threads().
6127
6128 2019-03-06  Pedro Alves  <palves@redhat.com>
6129
6130         * linux-fork.c: Include <list>.
6131         (fork_list): Now a std::list instance.
6132         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6133         (forks_exist_p, find_last_fork): Adjust.
6134         (new_fork): Delete.
6135         (one_fork_p): New.
6136         (add_fork): Adjust.
6137         (free_fork): Delete, folded into fork_info::~fork_info().
6138         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6139         Adjust.
6140         (init_fork_list): Delete.
6141         (linux_fork_killall, linux_fork_mourn_inferior)
6142         (linux_fork_detach, info_checkpoints_command): Adjust.
6143         (_initialize_linux_fork): No longer call init_fork_list.
6144
6145 2019-03-06  Pedro Alves  <palves@redhat.com>
6146
6147         * linux-fork.c (new_fork): New, split out of ...
6148         (add_fork): ... this.  Return void.  Move "first fork" special
6149         case from here, to ...
6150         (checkpoint_command): ... here.
6151         * linux-linux.h (add_fork): Return void.
6152
6153 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6154
6155         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6156
6157 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6158             Chris January  <chris.january@arm.com>
6159             David Lecomber  <david.lecomber@arm.com>
6160
6161         * f-exp.y: New token, UNOP_INTRINSIC.
6162         (exp): New pattern using UNOP_INTRINSIC token.
6163         (f77_keywords): Add 'abs' keyword.
6164         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6165         (value_from_host_double): New function.
6166         (evaluate_subexp_f): Support UNOP_ABS.
6167
6168 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6169
6170         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6171         types.
6172
6173 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6174
6175         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6176         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6177         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6178
6179 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6180
6181         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6182
6183 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6184             Chris January  <chris.january@arm.com>
6185
6186         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6187         * f-exp.y: Define 'KIND' token.
6188         (exp): New pattern for KIND expressions.
6189         (ptype): Handle types with a kind extension.
6190         (direct_abs_decl): Extend to spot kind extensions.
6191         (f77_keywords): Add 'kind' to the list.
6192         (push_kind_type): New function.
6193         (convert_to_kind_type): New function.
6194         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6195         * parse.c (operator_length_standard): Likewise.
6196         * parser-defs.h (enum type_pieces): Add tp_kind.
6197         * std-operator.def: Add UNOP_KIND.
6198
6199 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6200
6201         * f-exp.y (f_parse): Set yydebug.
6202
6203 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6204
6205         * f-lang.c (evaluate_subexp_f): New function.
6206         (exp_descriptor_f): New global.
6207         (f_language_defn): Use exp_descriptor_f instead of
6208         exp_descriptor_standard.
6209
6210 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6211
6212         * f-exp.y (struct token): Add comments.
6213         (dot_ops): Remove uppercase versions and the end marker.
6214         (f77_keywords): Likewise.
6215         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6216         entries in the dot_ops array are case insensitive, and use
6217         strncasecmp to compare strings.  Also some whitespace cleanup in
6218         this area.  Similar for the f77_keywords array, except entries in
6219         this list might be case sensitive.
6220
6221 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6222
6223         * f-exp.y (struct f77_boolean_val): Add comments.
6224         (boolean_values): Remove uppercase versions, and end marker.
6225         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6226         and use strncasecmp to achieve case insensitivity.  Additionally,
6227         perform whitespace cleanup around this code.
6228
6229 2019-03-06  Tom Tromey  <tromey@adacore.com>
6230
6231         * remote-sim.c (gdbsim_target_open): Use result of
6232         gdb_argv::release.
6233
6234 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6235         Dirk Schubert  <dirk.schubert@arm.com>
6236         Chris January  <chris.january@arm.com>
6237
6238         * eval.c (evaluate_subexp_standard): Call Fortran argument
6239         wrapping logic.
6240         * f-lang.c (struct value): A value which can be passed into a
6241         Fortran function call.
6242         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6243         where appropriate.
6244         (struct type): Value ready for a Fortran function call.
6245         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6246         is needed.
6247         * f-lang.h (fortran_argument_convert): Declaration.
6248         (fortran_preserve_arg_pointer): Declaration.
6249         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6250
6251 2019-03-05  Tom Tromey  <tromey@adacore.com>
6252
6253         * python/py-prettyprint.c (print_string_repr): Remove #if.
6254         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6255
6256 2019-03-05  Tom Tromey  <tromey@adacore.com>
6257
6258         * target.c (the_dummy_target): Move later.  Change type to
6259         "dummy_target".
6260         (initialize_targets): Don't initialize the_dummy_target.
6261
6262 2019-03-05  Tom Tromey  <tromey@adacore.com>
6263
6264         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6265         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6266
6267 2019-03-05  Tom Tromey  <tromey@adacore.com>
6268
6269         * windows-nat.c (windows_nat_target::attach)
6270         (windows_nat_target::detach): Don't call gdb_flush.
6271         * valprint.c (generic_val_print, val_print, val_print_string):
6272         Don't call gdb_flush.
6273         * utils.c (defaulted_query): Don't call gdb_flush.
6274         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6275         * target.c (target_announce_detach): Don't call gdb_flush.
6276         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6277         * remote.c (extended_remote_target::attach): Don't call
6278         gdb_flush.
6279         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6280         * printcmd.c (do_examine): Don't call gdb_flush.
6281         (info_display_command): Don't call gdb_flush.
6282         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6283         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6284         * memattr.c (info_mem_command): Don't call gdb_flush.
6285         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6286         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6287         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6288         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6289         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6290         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6291         (gnu_nat_target::detach): Don't call gdb_flush.
6292         * f-valprint.c (f_val_print): Don't call gdb_flush.
6293         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6294         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6295         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6296         gdb_flush.
6297         * c-valprint.c (c_val_print): Don't call gdb_flush.
6298         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6299
6300 2019-03-05  Tom Tromey  <tromey@adacore.com>
6301
6302         * varobj.c (update_dynamic_varobj_children): Update.
6303         (install_default_visualizer): Use reset, not release.
6304         * value.c (set_internalvar): Update.
6305         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6306         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6307         ATTRIBUTE_UNUSED_RESULT.
6308
6309 2019-03-05  Tom Tromey  <tromey@adacore.com>
6310
6311         * remote.c (class scoped_remote_fd) <release>: Add
6312         ATTRIBUTE_UNUSED_RESULT.
6313
6314 2019-03-05  Tom Tromey  <tromey@adacore.com>
6315
6316         * macroexp.c (struct macro_buffer) <release>: Add
6317         ATTRIBUTE_UNUSED_RESULT.
6318
6319 2019-03-05  Tom Tromey  <tromey@adacore.com>
6320
6321         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6322         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6323         ATTRIBUTE_UNUSED_RESULT.
6324
6325 2019-03-05  Tom Tromey  <tromey@adacore.com>
6326
6327         * common/scoped_fd.h (class scoped_fd) <release>: Add
6328         ATTRIBUTE_UNUSED_RESULT.
6329
6330 2019-03-05  Tom Tromey  <tromey@adacore.com>
6331
6332         * parser-defs.h (struct parser_state) <release>: Add
6333         ATTRIBUTE_UNUSED_RESULT.
6334
6335 2019-03-05  Tom Tromey  <tromey@adacore.com>
6336
6337         * utils.h (class gdb_argv) <release>: Add
6338         ATTRIBUTE_UNUSED_RESULT.
6339         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6340
6341 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6342
6343         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6344         for-loop range, to avoid compiler warnings.
6345
6346         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6347         avoid compiler warnings about unused variables.
6348
6349         * NEWS: Mention end of support for native debugging on MS-Windows
6350         before XP.
6351
6352         PR gdb/24292
6353         * common/netstuff.c:
6354         * gdbserver/gdbreplay.c
6355         * gdbserver/remote-utils.c:
6356         * ser-tcp.c:
6357         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6358         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6359         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6360         'getaddrinfo' and 'freeaddrinfo' were not available before
6361         Windows XP, and mingw.org's MinGW headers by default define
6362         _WIN32_WINNT to 0x500.
6363
6364 2019-03-01  Gary Benson <gbenson@redhat.com>
6365
6366         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6367
6368 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6369             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6370
6371         PR gdb/8527
6372         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6373         set_sigint_trap, clear_sigint_trap.
6374
6375 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6376
6377         * target.c (target_detach): Clear the regcache and the
6378         frame cache.
6379
6380 2019-02-27  Pedro Alves  <palves@redhat.com>
6381
6382         * utils.c (set_screen_size): When we cap the height/width sizes,
6383         tweak the corresponding command variable to show "unlimited":
6384
6385 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6386             Pedro Alves  <palves@redhat.com>
6387
6388         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6389         before calling rl_set_screen_size.
6390
6391 2019-02-27  Tom Tromey  <tromey@adacore.com>
6392
6393         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6394         define.
6395         * python/py-value.c: Remove Python 2.4 workaround.
6396         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6397         workaround.
6398         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6399         Python 2.4 workaround.
6400         * python/python-internal.h: Remove Python 2.4 comment.
6401         (Py_ssize_t): Don't define.
6402         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6403         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6404         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6405         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6406         * python/python.c (do_start_initialization): Remove Python 2.4
6407         workaround.
6408         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6409         (print_children): Remove Python 2.4 workaround.
6410         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6411         workaround.
6412         (CHARBUFFERPROC_NAME): Remove.
6413         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6414         Python 2.4 workaround.
6415
6416 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6417
6418         * NEWS: Note minimum Python version.
6419
6420 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6421
6422         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6423         code from these functions.  Remove corresponding ifdefs.  Use
6424         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6425         Remove gotos and target of gotos.
6426         (infpy_search_memory): Likewise.
6427
6428 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6429
6430         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6431         (hppa_gdbarch_init): Don't register deleted functions with
6432         gdbarch.
6433
6434 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6435
6436         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6437         (h8300_unwind_sp): Delete.
6438         (h8300_dummy_id): Delete.
6439         (h8300_gdbarch_init): Don't register deleted functions with
6440         gdbarch.
6441
6442 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6443
6444         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6445         (ft32_unwind_pc): Delete.
6446         (ft32_unwind_sp): Delete.
6447         (ft32_gdbarch_init): Don't register deleted functions with
6448         gdbarch.
6449
6450 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6451
6452         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6453         (frv_unwind_pc): Delete.
6454         (frv_unwind_sp): Delete.
6455         (frv_gdbarch_init): Don't register deleted functions with
6456         gdbarch.
6457
6458 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6459
6460         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6461         (riscv_unwind_pc): Delete.
6462         (riscv_unwind_sp): Delete.
6463         (riscv_gdbarch_init): Don't register deleted functions with
6464         gdbarch.
6465
6466 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6467
6468         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6469         (csky_unwind_pc): Delete.
6470         (csky_unwind_sp): Delete.
6471         (csky_gdbarch_init): Don't register deleted functions with
6472         gdbarch.
6473
6474 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6475
6476         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6477         (cris_unwind_pc): Delete.
6478         (cris_unwind_sp): Delete.
6479         (cris_gdbarch_init): Don't register deleted functions with
6480         gdbarch.
6481
6482 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6483
6484         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6485         (bfin_unwind_pc): Delete.
6486         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6487
6488 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6489
6490         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6491         (arm_unwind_pc): Delete.
6492         (arm_unwind_sp): Delete.
6493         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6494
6495 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6496
6497         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6498         (arc_unwind_pc): Delete.
6499         (arc_unwind_sp): Delete.
6500         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6501
6502 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6503
6504         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6505         (alpha_unwind_pc): Delete.
6506         (alpha_gdbarch_init): Don't register deleted functions with
6507         gdbarch.
6508
6509 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6510
6511         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6512         (aarch64_unwind_pc): Delete.
6513         (aarch64_unwind_sp): Delete.
6514         (aarch64_gdbarch_init): Don't register deleted functions with
6515         gdbarch.
6516
6517 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6518
6519         * gdbtypes.c (type_align): Don't consider static members when
6520         computing structure alignment.
6521
6522 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6523
6524         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6525         return 0 for other types.
6526         * arch-utils.c (default_type_align): Always return 0.
6527         * gdbarch.h: Regenerate.
6528         * gdbarch.sh (type_align): Extend comment.
6529         * gdbtypes.c (type_align): Add additional comments, always call
6530         gdbarch_type_align before applying the default rules.
6531         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6532         generic code will then apply a suitable default.
6533         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6534         types, return 0 for other types.
6535
6536 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6537
6538         * NEWS: Create a new section for the next release branch.
6539         Rename the section of the current branch, now that it has
6540         been cut.
6541
6542 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6543
6544         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6545         * version.in: Bump version to 8.3.50.DATE-git.
6546
6547 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6548
6549         * aix-thread.c (ptid_cmp): Remove unused variable.
6550         (get_signaled_thread): Likewise.
6551         (store_regs_user_thread): Likewise.
6552         (store_regs_kernel_thread): Likewise.
6553         (fetch_regs_kernel_thread): Remove shadowed variable.
6554
6555 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6556
6557         * features/riscv/32bit-cpu.xml: Add register numbers.
6558         * features/riscv/32bit-fpu.c: Regenerate.
6559         * features/riscv/32bit-fpu.xml: Add register numbers.
6560         * features/riscv/64bit-cpu.xml: Add register numbers.
6561         * features/riscv/64bit-fpu.c: Regenerate.
6562         * features/riscv/64bit-fpu.xml: Add register numbers.
6563
6564 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6565
6566         * NEWS: Mention two argument form of gdb.Value constructor.
6567         * python/py-value.c (convert_buffer_and_type_to_value): New
6568         function.
6569         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6570         Add support for handling an optional second argument.  Call
6571         convert_buffer_and_type_to_value as appropriate.
6572         * python/python-internal.h (Py_buffer_deleter): New struct.
6573         (Py_buffer_up): New typedef.
6574
6575 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6576
6577         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6578         instead of releasing ownership.
6579
6580 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6581
6582         * dwarf2read.c (open_and_init_dwp_file): Call
6583         elf_numsections instead of bfd_count_sections to initialize
6584         dwp_file->num_sections.
6585
6586 2019-02-25  Tom Tromey  <tromey@adacore.com>
6587
6588         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6589
6590 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6591
6592         * gcore.in: Add '--readnever' option when invoking GDB.
6593
6594 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6595
6596         * MAINTAINERS: Update my email address.
6597
6598 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6599
6600         * build-id.c (build_id_to_debug_bfd_1): New function.
6601         (build_id_to_debug_bfd): Look for separate debug file in
6602         sysroot.
6603
6604 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6605
6606         * gdbarch.sh: Update the copyright year range that is placed into
6607         generated files.
6608
6609 2019-02-22  Keith Seitz  <keiths@redhat.com>
6610
6611         PR symtab/23853
6612         * linespec.c (create_sals_line_offset): Search for the default
6613         symtab's filename instead of its fullname.
6614
6615 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6616
6617         * NEWS: Update style defaults.
6618
6619 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6620
6621         * main.c (captured_main_1): Disable styling in batch mode.
6622
6623 2019-02-20  Tom Tromey  <tom@tromey.com>
6624
6625         * symtab.c (symtab_symbol_info): Fix typos.
6626
6627 2019-02-20  Tom Tromey  <tromey@adacore.com>
6628
6629         * findcmd.c (_initialize_mem_search): Use upper case for
6630         metasyntactic variables.
6631
6632 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6633
6634         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6635         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6636
6637 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6638
6639         * top.h (source_file_name): Change to std::string.
6640         * top.c (source_file_name): Likewise.
6641         (command_line_input): Adjust.
6642         * cli/cli-script.c (script_from_file): Adjust.
6643
6644 2019-02-19  Tom Tromey  <tromey@adacore.com>
6645
6646         * ravenscar-thread.c
6647         (ravenscar_thread_target::update_thread_list): Don't call
6648         ada_build_task_list.
6649         * ada-lang.h (ada_build_task_list): Don't declare.
6650         * ada-tasks.c (struct ada_tasks_inferior_data)
6651         <task_list_valid_p>: Now bool.
6652         (read_known_tasks, ada_task_list_changed)
6653         (ada_tasks_invalidate_inferior_data): Update.
6654         (read_known_tasks_array): Return bool.
6655         (read_known_tasks_list): Likewise.
6656         (read_known_tasks): Return void.
6657         (ada_build_task_list): Now static.
6658
6659 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6660
6661         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6662         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6663
6664 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6665
6666         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6667         variant for ada_tasks_pspace_data_handle and
6668         ada_tasks_inferior_data_handle.
6669         (ada_tasks_pspace_data_cleanup): New function.
6670         (ada_tasks_inferior_data_cleanup): New function.
6671
6672 2019-02-17  Tom Tromey  <tom@tromey.com>
6673
6674         * macrotab.h (macro_source_fullname): Return a std::string.
6675         * macrotab.c (macro_include, check_for_redefinition)
6676         (macro_undef, macro_lookup_definition, foreach_macro)
6677         (foreach_macro_in_scope): Update.
6678         (macro_source_fullname): Return a std::string.
6679         * macrocmd.c (show_pp_source_pos): Update.
6680
6681 2019-02-17  Tom Tromey  <tom@tromey.com>
6682
6683         * macrocmd.c (show_pp_source_pos): Style the file names.
6684
6685 2019-02-17  Tom Tromey  <tom@tromey.com>
6686
6687         PR tui/24197:
6688         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6689
6690 2019-02-17  Tom Tromey  <tom@tromey.com>
6691
6692         * ada-lang.c (user_select_syms): Use filtered printing.
6693         * utils.c (wrap_style): New global.
6694         (desired_style): Remove.
6695         (emit_style_escape): Add stream parameter.
6696         (set_output_style, reset_terminal_style, prompt_for_continue):
6697         Update.
6698         (flush_wrap_buffer): Only flush gdb_stdout.
6699         (wrap_here): Set wrap_style.
6700         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6701         treat escape sequences as a character.  Change when wrap buffer is
6702         flushed.
6703         (fputs_styled): Do not set the output style when the default is
6704         requested.
6705         * ui-style.h (struct ui_file_style) <is_default>: New method.
6706         * source.c (print_source_lines_base): Emit escape sequences in one
6707         piece.
6708
6709 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6710
6711         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6712         integers and enumeration types.
6713
6714 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6715
6716         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6717         instead of lookup_symbol_in_language
6718         (do_exact_match): New function.
6719         (ada_get_symbol_name_matcher): Return do_exact_match when
6720         doing a verbatim match.
6721
6722 2019-02-15  Tom Tromey  <tromey@adacore.com>
6723
6724         * ravenscar-thread.c (ravenscar_thread_target::resume)
6725         (ravenscar_thread_target::wait): Special case wildcard requests.
6726
6727 2019-02-15  Tom Tromey  <tromey@adacore.com>
6728
6729         * ravenscar-thread.c (base_ptid): Remove.
6730         (struct ravenscar_thread_target) <close>: New method.
6731         <m_base_ptid>: New member.
6732         <update_inferior_ptid, active_task, task_is_currently_active,
6733         runtime_initialized>: Declare methods.
6734         <ravenscar_thread_target>: Add constructor.
6735         (ravenscar_thread_target::task_is_currently_active)
6736         (ravenscar_thread_target::update_inferior_ptid)
6737         (ravenscar_runtime_initialized): Rename.  Now methods.
6738         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6739         (ravenscar_thread_target::update_thread_list): Update.
6740         (ravenscar_thread_target::active_task): Now method.
6741         (ravenscar_thread_target::store_registers)
6742         (ravenscar_thread_target::prepare_to_store)
6743         (ravenscar_thread_target::prepare_to_store)
6744         (ravenscar_thread_target::mourn_inferior): Update.
6745         (ravenscar_inferior_created): Use "new" to create target.
6746         (ravenscar_thread_target::get_ada_task_ptid): Update.
6747         (_initialize_ravenscar): Don't initialize base_ptid.
6748         (ravenscar_ops): Remove global.
6749
6750 2019-02-15  Tom Tromey  <tromey@adacore.com>
6751
6752         * target.h (push_target): Declare new overload.
6753         * target.c (push_target): New overload, taking an rvalue reference.
6754         * remote.c (remote_target::open_1): Use push_target overload.
6755         * corelow.c (core_target_open): Use push_target overload.
6756
6757 2019-02-15  Tom Tromey  <tromey@adacore.com>
6758
6759         * ravenscar-thread.c (is_ravenscar_task)
6760         (ravenscar_task_is_currently_active): Return bool.
6761         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6762         (_initialize_ravenscar): Remove "(void)".
6763         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6764         Return bool.
6765
6766 2019-02-15  Tom Tromey  <tromey@adacore.com>
6767
6768         * ravenscar-thread.c (ravenscar_runtime_initializer)
6769         (has_ravenscar_runtime, get_running_thread_id)
6770         (ravenscar_thread_target::resume): Fix indentation.
6771
6772 2019-02-15  Tom Tromey  <tromey@adacore.com>
6773
6774         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6775         from ravenscar_arch_ops.
6776         (sparc_ravenscar_ops::fetch_registers)
6777         (sparc_ravenscar_ops::store_registers): Now methods.
6778         (sparc_ravenscar_prepare_to_store): Remove.
6779         (sparc_ravenscar_ops): Redefine.
6780         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6781         methods and destructor.  Remove members.
6782         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6783         (ravenscar_thread_target::store_registers)
6784         (ravenscar_thread_target::prepare_to_store): Update.
6785         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6786         Remove.
6787         (struct ppc_ravenscar_powerpc_ops): Derive from
6788         ravenscar_arch_ops.
6789         (ppc_ravenscar_powerpc_ops::fetch_registers)
6790         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6791         (ppc_ravenscar_powerpc_ops): Redefine.
6792         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6793         (ppc_ravenscar_e500_ops::fetch_registers)
6794         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6795         (ppc_ravenscar_e500_ops): Redefine.
6796         * aarch64-ravenscar-thread.c
6797         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6798         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6799         (aarch64_ravenscar_fetch_registers)
6800         (aarch64_ravenscar_store_registers): Now methods.
6801         (aarch64_ravenscar_ops): Redefine.
6802
6803 2019-02-15  Tom Tromey  <tromey@adacore.com>
6804
6805         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6806         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6807         (ravenscar_thread_target::stopped_by_watchpoint)
6808         (ravenscar_thread_target::stopped_data_address)
6809         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6810
6811 2019-02-15  Tom Tromey  <tromey@adacore.com>
6812
6813         * ravenscar-thread.c: Fix some typos.
6814
6815 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6816             Tom Tromey  <tromey@adacore.com>
6817
6818         * ada-lang.c (ada_exception_sal): Change addr_string to a
6819         std::string.
6820         (create_ada_exception_catchpoint): Update.
6821
6822 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6823             Tom Tromey  <tromey@adacore.com>
6824
6825         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6826         (bp_location_ops): Remove.
6827         (base_breakpoint_allocate_location): Update.
6828         (free_bp_location): Update.
6829         * ada-lang.c (class ada_catchpoint_location)
6830         <ada_catchpoint_location>: Remove ops parameter.
6831         (ada_catchpoint_location_dtor): Remove.
6832         (ada_catchpoint_location_ops): Remove.
6833         (allocate_location_exception): Update.
6834         * breakpoint.h (struct bp_location_ops): Remove.
6835         (class bp_location) <bp_location>: Remove bp_location_ops
6836         parameter.
6837         <~bp_location>: Add destructor.
6838         <ops>: Remove.
6839
6840 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6841             Pedro Alves  <palves@redhat.com>
6842
6843         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6844         'PATH_MAX'.
6845
6846 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6847             Samuel Thibault  <samuel.thibault@gnu.org>
6848             Thomas Schwinge  <thomas@codesourcery.com>
6849
6850         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6851         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6852
6853 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6854
6855         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6856         (check_empty): Use "const char *".
6857
6858         * gnu-nat.c (gnu_nat_target::detach): Instead of
6859         'detach_inferior (pid)' call
6860         'detach_inferior (find_inferior_pid (pid))'.
6861
6862         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6863         'nat/fork-inferior.o'.
6864         * gnu-nat.c: #include "nat/fork-inferior.h".
6865
6866         * gnu-nat.c (gnu_nat_target::detach): Instead of
6867         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6868         * gnu-nat.h: #include "inf-child.h".
6869         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6870         'i386_gnu_nat_target::fetch_registers'.
6871         (gnu_store_registers): Rename/move to
6872         'i386_gnu_nat_target::store_registers'.
6873
6874         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6875         * gnu-nat.h (mach_thread_info): New function.
6876         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6877
6878         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6879
6880 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6881
6882         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6883
6884 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6885
6886         * windows-nat.c (windows_add_thread): Add new parameter
6887         "main_thread_p" with default value set to false.  Update
6888         function documentation as well as all callers.
6889         (windows_delete_thread): Likewise.
6890         (fake_create_process): Update call to windows_add_thread.
6891         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6892         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6893         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6894         call to windows_delete_thread.
6895
6896 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6897
6898         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6899
6900 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6901
6902         * symfile.c (find_separate_debug_file): Use canonical path of
6903         sysroot with child_path instead of gdb_sysroot if it is valid.
6904
6905 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6906
6907         * symfile.c (find_separate_debug_file): Use child_path to
6908         determine if an object file is under a sysroot.
6909
6910 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6911
6912         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6913         unittests/child-path-selftests.c.
6914         * common/pathstuff.c (child_path): New function.
6915         * common/pathstuff.h (child_path): New prototype.
6916         * unittests/child-path-selftests.c: New file.
6917
6918 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6919
6920         * symfile.c (find_separate_debug_file): Look for separate debug
6921         files in debug directories under the sysroot.
6922
6923 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6924
6925         * symtab.h (struct minimal_symbol data_p): New const method.
6926         (struct minimal_symbol text_p): Likewise.
6927         * symtab.c (output_source_filename): Use file name style
6928         to print file name.
6929         (print_symbol_info): Likewise.
6930         (print_msymbol_info): Use address style to print addresses.
6931         Use function name style to print executable text symbols.
6932         (expand_symtab_containing_pc): Use data_p.
6933         (find_pc_sect_compunit_symtab): Likewise.
6934
6935 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6936
6937         * breakpoint.c (describe_other_breakpoints): Use address style
6938         to print addresses.
6939         (say_where): Likewise.
6940
6941 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6942
6943         * ada-typeprint.c (print_func_type): Print function name
6944         style to print function name.
6945         * c-typeprint.c (c_print_type_1): Likewise.
6946
6947 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6948
6949         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6950         for execve.
6951
6952 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6953
6954         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6955         type_stack.
6956
6957 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6958
6959         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6960         TYPE_CODE_REF types.
6961
6962 2019-02-08  Jim Wilson  <jimw@sifive.com>
6963
6964         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6965         (riscv_linux_fregset): New.
6966         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6967
6968 2019-02-07  Tom Tromey  <tom@tromey.com>
6969
6970         * thread.c (thread_cancel_execution_command): Update.
6971         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6972         methods.
6973         (struct thread_fsm_ops): Remove.
6974         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6975         (thread_fsm_should_stop, thread_fsm_return_value)
6976         (thread_fsm_set_finished, thread_fsm_finished_p)
6977         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6978         Don't declare.
6979         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6980         * infrun.c (clear_proceed_status_thread)
6981         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6982         (print_stop_event): Update.
6983         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6984         Add constructor.
6985         (step_command_fsm_ops): Remove.
6986         (new_step_command_fsm): Remove.
6987         (step_1): Update.
6988         (step_command_fsm::should_stop): Rename from
6989         step_command_fsm_should_stop.
6990         (step_command_fsm::clean_up): Rename from
6991         step_command_fsm_clean_up.
6992         (step_command_fsm::do_async_reply_reason): Rename from
6993         step_command_fsm_async_reply_reason.
6994         (struct until_next_fsm): Inherit from thread_fsm.  Add
6995         constructor.
6996         (until_next_fsm_ops): Remove.
6997         (new_until_next_fsm): Remove.
6998         (until_next_fsm::should_stop): Rename from
6999         until_next_fsm_should_stop.
7000         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7001         (until_next_fsm::do_async_reply_reason): Rename from
7002         until_next_fsm_async_reply_reason.
7003         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7004         constructor.  Change type of breakpoint.
7005         (finish_command_fsm_ops): Remove.
7006         (new_finish_command_fsm): Remove.
7007         (finish_command_fsm::should_stop): Rename from
7008         finish_command_fsm_should_stop.
7009         (finish_command_fsm::clean_up): Rename from
7010         finish_command_fsm_clean_up.
7011         (finish_command_fsm::return_value): Rename from
7012         finish_command_fsm_return_value.
7013         (finish_command_fsm::do_async_reply_reason): Rename from
7014         finish_command_fsm_async_reply_reason.
7015         (finish_command): Update.
7016         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7017         Add constructor.
7018         (call_thread_fsm_ops): Remove.
7019         (call_thread_fsm::call_thread_fsm): Rename from
7020         new_call_thread_fsm.
7021         (call_thread_fsm::should_stop): Rename from
7022         call_thread_fsm_should_stop.
7023         (call_thread_fsm::should_notify_stop): Rename from
7024         call_thread_fsm_should_notify_stop.
7025         (run_inferior_call, call_function_by_hand_dummy): Update.
7026         * cli/cli-interp.c (should_print_stop_to_console): Update.
7027         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7028         Add constructor.  Change type of location_breakpoint,
7029         caller_breakpoint.
7030         (until_break_fsm_ops): Remove.
7031         (new_until_break_fsm): Remove.
7032         (until_break_fsm::should_stop): Rename from
7033         until_break_fsm_should_stop.
7034         (until_break_fsm::clean_up): Rename from
7035         until_break_fsm_clean_up.
7036         (until_break_fsm::do_async_reply_reason): Rename from
7037         until_break_fsm_async_reply_reason.
7038         (until_break_command): Update.
7039         * thread-fsm.c: Remove.
7040         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7041
7042 2019-02-07  Tom Tromey  <tom@tromey.com>
7043
7044         * yy-remap.h: Add include guard.
7045         * xtensa-tdep.h: Add include guard.
7046         * xcoffread.h: Rename include guard.
7047         * varobj-iter.h: Add include guard.
7048         * tui/tui.h: Rename include guard.
7049         * tui/tui-winsource.h: Rename include guard.
7050         * tui/tui-wingeneral.h: Rename include guard.
7051         * tui/tui-windata.h: Rename include guard.
7052         * tui/tui-win.h: Rename include guard.
7053         * tui/tui-stack.h: Rename include guard.
7054         * tui/tui-source.h: Rename include guard.
7055         * tui/tui-regs.h: Rename include guard.
7056         * tui/tui-out.h: Rename include guard.
7057         * tui/tui-layout.h: Rename include guard.
7058         * tui/tui-io.h: Rename include guard.
7059         * tui/tui-hooks.h: Rename include guard.
7060         * tui/tui-file.h: Rename include guard.
7061         * tui/tui-disasm.h: Rename include guard.
7062         * tui/tui-data.h: Rename include guard.
7063         * tui/tui-command.h: Rename include guard.
7064         * tic6x-tdep.h: Add include guard.
7065         * target/waitstatus.h: Rename include guard.
7066         * target/wait.h: Rename include guard.
7067         * target/target.h: Rename include guard.
7068         * target/resume.h: Rename include guard.
7069         * target-float.h: Rename include guard.
7070         * stabsread.h: Add include guard.
7071         * rs6000-tdep.h: Add include guard.
7072         * riscv-fbsd-tdep.h: Add include guard.
7073         * regformats/regdef.h: Rename include guard.
7074         * record.h: Rename include guard.
7075         * python/python.h: Rename include guard.
7076         * python/python-internal.h: Rename include guard.
7077         * python/py-stopevent.h: Rename include guard.
7078         * python/py-ref.h: Rename include guard.
7079         * python/py-record.h: Rename include guard.
7080         * python/py-record-full.h: Rename include guard.
7081         * python/py-record-btrace.h: Rename include guard.
7082         * python/py-instruction.h: Rename include guard.
7083         * python/py-events.h: Rename include guard.
7084         * python/py-event.h: Rename include guard.
7085         * procfs.h: Add include guard.
7086         * proc-utils.h: Add include guard.
7087         * p-lang.h: Add include guard.
7088         * or1k-tdep.h: Rename include guard.
7089         * observable.h: Rename include guard.
7090         * nto-tdep.h: Rename include guard.
7091         * nat/x86-linux.h: Rename include guard.
7092         * nat/x86-linux-dregs.h: Rename include guard.
7093         * nat/x86-gcc-cpuid.h: Add include guard.
7094         * nat/x86-dregs.h: Rename include guard.
7095         * nat/x86-cpuid.h: Rename include guard.
7096         * nat/ppc-linux.h: Rename include guard.
7097         * nat/mips-linux-watch.h: Rename include guard.
7098         * nat/linux-waitpid.h: Rename include guard.
7099         * nat/linux-ptrace.h: Rename include guard.
7100         * nat/linux-procfs.h: Rename include guard.
7101         * nat/linux-osdata.h: Rename include guard.
7102         * nat/linux-nat.h: Rename include guard.
7103         * nat/linux-namespaces.h: Rename include guard.
7104         * nat/linux-btrace.h: Rename include guard.
7105         * nat/glibc_thread_db.h: Rename include guard.
7106         * nat/gdb_thread_db.h: Rename include guard.
7107         * nat/gdb_ptrace.h: Rename include guard.
7108         * nat/fork-inferior.h: Rename include guard.
7109         * nat/amd64-linux-siginfo.h: Rename include guard.
7110         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7111         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7112         * nat/aarch64-linux.h: Rename include guard.
7113         * nat/aarch64-linux-hw-point.h: Rename include guard.
7114         * mn10300-tdep.h: Add include guard.
7115         * mips-linux-tdep.h: Add include guard.
7116         * mi/mi-parse.h: Rename include guard.
7117         * mi/mi-out.h: Rename include guard.
7118         * mi/mi-main.h: Rename include guard.
7119         * mi/mi-interp.h: Rename include guard.
7120         * mi/mi-getopt.h: Rename include guard.
7121         * mi/mi-console.h: Rename include guard.
7122         * mi/mi-common.h: Rename include guard.
7123         * mi/mi-cmds.h: Rename include guard.
7124         * mi/mi-cmd-break.h: Rename include guard.
7125         * m2-lang.h: Add include guard.
7126         * location.h: Rename include guard.
7127         * linux-record.h: Rename include guard.
7128         * linux-nat.h: Add include guard.
7129         * linux-fork.h: Add include guard.
7130         * i386-darwin-tdep.h: Rename include guard.
7131         * hppa-linux-offsets.h: Add include guard.
7132         * guile/guile.h: Rename include guard.
7133         * guile/guile-internal.h: Rename include guard.
7134         * gnu-nat.h: Rename include guard.
7135         * gdb-stabs.h: Rename include guard.
7136         * frv-tdep.h: Add include guard.
7137         * f-lang.h: Add include guard.
7138         * event-loop.h: Add include guard.
7139         * darwin-nat.h: Rename include guard.
7140         * cp-abi.h: Rename include guard.
7141         * config/sparc/nm-sol2.h: Rename include guard.
7142         * config/nm-nto.h: Rename include guard.
7143         * config/nm-linux.h: Add include guard.
7144         * config/i386/nm-i386gnu.h: Rename include guard.
7145         * config/djgpp/nl_types.h: Rename include guard.
7146         * config/djgpp/langinfo.h: Rename include guard.
7147         * compile/gcc-cp-plugin.h: Add include guard.
7148         * compile/gcc-c-plugin.h: Add include guard.
7149         * compile/compile.h: Rename include guard.
7150         * compile/compile-object-run.h: Rename include guard.
7151         * compile/compile-object-load.h: Rename include guard.
7152         * compile/compile-internal.h: Rename include guard.
7153         * compile/compile-cplus.h: Rename include guard.
7154         * compile/compile-c.h: Rename include guard.
7155         * common/xml-utils.h: Rename include guard.
7156         * common/x86-xstate.h: Rename include guard.
7157         * common/version.h: Rename include guard.
7158         * common/vec.h: Rename include guard.
7159         * common/tdesc.h: Rename include guard.
7160         * common/selftest.h: Rename include guard.
7161         * common/scoped_restore.h: Rename include guard.
7162         * common/scoped_mmap.h: Rename include guard.
7163         * common/scoped_fd.h: Rename include guard.
7164         * common/safe-iterator.h: Rename include guard.
7165         * common/run-time-clock.h: Rename include guard.
7166         * common/refcounted-object.h: Rename include guard.
7167         * common/queue.h: Rename include guard.
7168         * common/ptid.h: Rename include guard.
7169         * common/print-utils.h: Rename include guard.
7170         * common/preprocessor.h: Rename include guard.
7171         * common/pathstuff.h: Rename include guard.
7172         * common/observable.h: Rename include guard.
7173         * common/netstuff.h: Rename include guard.
7174         * common/job-control.h: Rename include guard.
7175         * common/host-defs.h: Rename include guard.
7176         * common/gdb_wait.h: Rename include guard.
7177         * common/gdb_vecs.h: Rename include guard.
7178         * common/gdb_unlinker.h: Rename include guard.
7179         * common/gdb_unique_ptr.h: Rename include guard.
7180         * common/gdb_tilde_expand.h: Rename include guard.
7181         * common/gdb_sys_time.h: Rename include guard.
7182         * common/gdb_string_view.h: Rename include guard.
7183         * common/gdb_splay_tree.h: Rename include guard.
7184         * common/gdb_setjmp.h: Rename include guard.
7185         * common/gdb_ref_ptr.h: Rename include guard.
7186         * common/gdb_optional.h: Rename include guard.
7187         * common/gdb_locale.h: Rename include guard.
7188         * common/gdb_assert.h: Rename include guard.
7189         * common/filtered-iterator.h: Rename include guard.
7190         * common/filestuff.h: Rename include guard.
7191         * common/fileio.h: Rename include guard.
7192         * common/environ.h: Rename include guard.
7193         * common/common-utils.h: Rename include guard.
7194         * common/common-types.h: Rename include guard.
7195         * common/common-regcache.h: Rename include guard.
7196         * common/common-inferior.h: Rename include guard.
7197         * common/common-gdbthread.h: Rename include guard.
7198         * common/common-exceptions.h: Rename include guard.
7199         * common/common-defs.h: Rename include guard.
7200         * common/common-debug.h: Rename include guard.
7201         * common/cleanups.h: Rename include guard.
7202         * common/buffer.h: Rename include guard.
7203         * common/btrace-common.h: Rename include guard.
7204         * common/break-common.h: Rename include guard.
7205         * cli/cli-utils.h: Rename include guard.
7206         * cli/cli-style.h: Rename include guard.
7207         * cli/cli-setshow.h: Rename include guard.
7208         * cli/cli-script.h: Rename include guard.
7209         * cli/cli-interp.h: Rename include guard.
7210         * cli/cli-decode.h: Rename include guard.
7211         * cli/cli-cmds.h: Rename include guard.
7212         * charset-list.h: Add include guard.
7213         * buildsym-legacy.h: Rename include guard.
7214         * bfin-tdep.h: Add include guard.
7215         * ax.h: Rename include guard.
7216         * arm-linux-tdep.h: Add include guard.
7217         * arm-fbsd-tdep.h: Add include guard.
7218         * arch/xtensa.h: Rename include guard.
7219         * arch/tic6x.h: Add include guard.
7220         * arch/i386.h: Add include guard.
7221         * arch/arm.h: Rename include guard.
7222         * arch/arm-linux.h: Rename include guard.
7223         * arch/arm-get-next-pcs.h: Rename include guard.
7224         * arch/amd64.h: Add include guard.
7225         * arch/aarch64-insn.h: Rename include guard.
7226         * arch-utils.h: Rename include guard.
7227         * annotate.h: Add include guard.
7228         * amd64-darwin-tdep.h: Rename include guard.
7229         * aarch64-linux-tdep.h: Add include guard.
7230         * aarch64-fbsd-tdep.h: Add include guard.
7231         * aarch32-linux-nat.h: Add include guard.
7232
7233 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7234
7235         * macrotab.c (macro_define_internal): New function that
7236         factorizes macro_define_object_internal and macro_define_function
7237         code.
7238         (macro_define_object_internal): Use macro_define_internal.
7239         (macro_define_function): Likewise.
7240
7241 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7242
7243         * macrocmd.c (extract_identifier): Return
7244         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7245         callers.
7246
7247 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7248
7249         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7250
7251 2019-02-05  Tom Tromey  <tom@tromey.com>
7252
7253         * target.c (target_stack::unpush): Move assertion earlier.
7254
7255 2019-01-30  Tom Tromey  <tom@tromey.com>
7256
7257         PR python/23615:
7258         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7259         (gdbpy_parse_and_eval): Likewise.
7260         * python/python-internal.h (gdbpy_allow_threads): New class.
7261
7262 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7263
7264         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7265         (aarch64_fbsd_fpregmap): Move earlier.
7266         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7267         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7268         instead of individual calls to trad_frame_set_reg_addr.
7269         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7270         earlier.
7271         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7272         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7273         instead of individual calls to trad_frame_set_reg_addr.
7274
7275 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7276
7277         * CONTRIBUTE: Replace contribution list with wiki link.
7278
7279 2019-01-25  Tom Tromey  <tom@tromey.com>
7280
7281         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7282
7283 2019-01-25  Tom Tromey  <tom@tromey.com>
7284
7285         * xtensa-linux-nat.c: Fix common/ includes.
7286         * xml-support.h: Fix common/ includes.
7287         * xml-support.c: Fix common/ includes.
7288         * x86-linux-nat.c: Fix common/ includes.
7289         * windows-nat.c: Fix common/ includes.
7290         * varobj.h: Fix common/ includes.
7291         * varobj.c: Fix common/ includes.
7292         * value.c: Fix common/ includes.
7293         * valops.c: Fix common/ includes.
7294         * utils.c: Fix common/ includes.
7295         * unittests/xml-utils-selftests.c: Fix common/ includes.
7296         * unittests/utils-selftests.c: Fix common/ includes.
7297         * unittests/unpack-selftests.c: Fix common/ includes.
7298         * unittests/tracepoint-selftests.c: Fix common/ includes.
7299         * unittests/style-selftests.c: Fix common/ includes.
7300         * unittests/string_view-selftests.c: Fix common/ includes.
7301         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7302         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7303         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7304         * unittests/rsp-low-selftests.c: Fix common/ includes.
7305         * unittests/parse-connection-spec-selftests.c: Fix common/
7306         includes.
7307         * unittests/optional-selftests.c: Fix common/ includes.
7308         * unittests/offset-type-selftests.c: Fix common/ includes.
7309         * unittests/observable-selftests.c: Fix common/ includes.
7310         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7311         * unittests/memrange-selftests.c: Fix common/ includes.
7312         * unittests/memory-map-selftests.c: Fix common/ includes.
7313         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7314         * unittests/function-view-selftests.c: Fix common/ includes.
7315         * unittests/environ-selftests.c: Fix common/ includes.
7316         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7317         * unittests/common-utils-selftests.c: Fix common/ includes.
7318         * unittests/cli-utils-selftests.c: Fix common/ includes.
7319         * unittests/array-view-selftests.c: Fix common/ includes.
7320         * ui-file.c: Fix common/ includes.
7321         * tui/tui-io.c: Fix common/ includes.
7322         * tracepoint.h: Fix common/ includes.
7323         * tracepoint.c: Fix common/ includes.
7324         * tracefile-tfile.c: Fix common/ includes.
7325         * top.h: Fix common/ includes.
7326         * top.c: Fix common/ includes.
7327         * thread.c: Fix common/ includes.
7328         * target/waitstatus.h: Fix common/ includes.
7329         * target/waitstatus.c: Fix common/ includes.
7330         * target.h: Fix common/ includes.
7331         * target.c: Fix common/ includes.
7332         * target-memory.c: Fix common/ includes.
7333         * target-descriptions.c: Fix common/ includes.
7334         * symtab.h: Fix common/ includes.
7335         * symfile.c: Fix common/ includes.
7336         * stap-probe.c: Fix common/ includes.
7337         * spu-linux-nat.c: Fix common/ includes.
7338         * sparc-nat.c: Fix common/ includes.
7339         * source.c: Fix common/ includes.
7340         * solib.c: Fix common/ includes.
7341         * solib-target.c: Fix common/ includes.
7342         * ser-unix.c: Fix common/ includes.
7343         * ser-tcp.c: Fix common/ includes.
7344         * ser-pipe.c: Fix common/ includes.
7345         * ser-base.c: Fix common/ includes.
7346         * selftest-arch.c: Fix common/ includes.
7347         * s12z-tdep.c: Fix common/ includes.
7348         * rust-exp.y: Fix common/ includes.
7349         * rs6000-aix-tdep.c: Fix common/ includes.
7350         * riscv-tdep.c: Fix common/ includes.
7351         * remote.c: Fix common/ includes.
7352         * remote-notif.h: Fix common/ includes.
7353         * remote-fileio.h: Fix common/ includes.
7354         * remote-fileio.c: Fix common/ includes.
7355         * regcache.h: Fix common/ includes.
7356         * regcache.c: Fix common/ includes.
7357         * record-btrace.c: Fix common/ includes.
7358         * python/python.c: Fix common/ includes.
7359         * python/py-type.c: Fix common/ includes.
7360         * python/py-inferior.c: Fix common/ includes.
7361         * progspace.h: Fix common/ includes.
7362         * producer.c: Fix common/ includes.
7363         * procfs.c: Fix common/ includes.
7364         * proc-api.c: Fix common/ includes.
7365         * printcmd.c: Fix common/ includes.
7366         * ppc-linux-nat.c: Fix common/ includes.
7367         * parser-defs.h: Fix common/ includes.
7368         * osdata.c: Fix common/ includes.
7369         * obsd-nat.c: Fix common/ includes.
7370         * nat/x86-linux.c: Fix common/ includes.
7371         * nat/x86-linux-dregs.c: Fix common/ includes.
7372         * nat/x86-dregs.h: Fix common/ includes.
7373         * nat/x86-dregs.c: Fix common/ includes.
7374         * nat/ppc-linux.c: Fix common/ includes.
7375         * nat/mips-linux-watch.h: Fix common/ includes.
7376         * nat/mips-linux-watch.c: Fix common/ includes.
7377         * nat/linux-waitpid.c: Fix common/ includes.
7378         * nat/linux-ptrace.h: Fix common/ includes.
7379         * nat/linux-ptrace.c: Fix common/ includes.
7380         * nat/linux-procfs.c: Fix common/ includes.
7381         * nat/linux-personality.c: Fix common/ includes.
7382         * nat/linux-osdata.c: Fix common/ includes.
7383         * nat/linux-namespaces.c: Fix common/ includes.
7384         * nat/linux-btrace.h: Fix common/ includes.
7385         * nat/linux-btrace.c: Fix common/ includes.
7386         * nat/fork-inferior.c: Fix common/ includes.
7387         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7388         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7389         * nat/aarch64-linux.c: Fix common/ includes.
7390         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7391         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7392         * namespace.h: Fix common/ includes.
7393         * mips-linux-tdep.c: Fix common/ includes.
7394         * minsyms.c: Fix common/ includes.
7395         * mi/mi-parse.h: Fix common/ includes.
7396         * mi/mi-main.c: Fix common/ includes.
7397         * mi/mi-cmd-env.c: Fix common/ includes.
7398         * memrange.h: Fix common/ includes.
7399         * memattr.c: Fix common/ includes.
7400         * maint.h: Fix common/ includes.
7401         * maint.c: Fix common/ includes.
7402         * main.c: Fix common/ includes.
7403         * machoread.c: Fix common/ includes.
7404         * location.c: Fix common/ includes.
7405         * linux-thread-db.c: Fix common/ includes.
7406         * linux-nat.c: Fix common/ includes.
7407         * linux-fork.c: Fix common/ includes.
7408         * inline-frame.c: Fix common/ includes.
7409         * infrun.c: Fix common/ includes.
7410         * inflow.c: Fix common/ includes.
7411         * inferior.h: Fix common/ includes.
7412         * inferior.c: Fix common/ includes.
7413         * infcmd.c: Fix common/ includes.
7414         * inf-ptrace.c: Fix common/ includes.
7415         * inf-child.c: Fix common/ includes.
7416         * ia64-linux-nat.c: Fix common/ includes.
7417         * i387-tdep.c: Fix common/ includes.
7418         * i386-tdep.c: Fix common/ includes.
7419         * i386-linux-tdep.c: Fix common/ includes.
7420         * i386-linux-nat.c: Fix common/ includes.
7421         * i386-go32-tdep.c: Fix common/ includes.
7422         * i386-fbsd-tdep.c: Fix common/ includes.
7423         * i386-fbsd-nat.c: Fix common/ includes.
7424         * guile/scm-type.c: Fix common/ includes.
7425         * guile/guile.c: Fix common/ includes.
7426         * go32-nat.c: Fix common/ includes.
7427         * gnu-nat.c: Fix common/ includes.
7428         * gdbthread.h: Fix common/ includes.
7429         * gdbarch-selftests.c: Fix common/ includes.
7430         * gdb_usleep.c: Fix common/ includes.
7431         * gdb_select.h: Fix common/ includes.
7432         * gdb_bfd.c: Fix common/ includes.
7433         * gcore.c: Fix common/ includes.
7434         * fork-child.c: Fix common/ includes.
7435         * findvar.c: Fix common/ includes.
7436         * fbsd-nat.c: Fix common/ includes.
7437         * event-top.c: Fix common/ includes.
7438         * event-loop.c: Fix common/ includes.
7439         * dwarf2read.c: Fix common/ includes.
7440         * dwarf2loc.c: Fix common/ includes.
7441         * dwarf2-frame.c: Fix common/ includes.
7442         * dwarf-index-cache.c: Fix common/ includes.
7443         * dtrace-probe.c: Fix common/ includes.
7444         * disasm-selftests.c: Fix common/ includes.
7445         * defs.h: Fix common/ includes.
7446         * csky-tdep.c: Fix common/ includes.
7447         * cp-valprint.c: Fix common/ includes.
7448         * cp-support.h: Fix common/ includes.
7449         * cp-support.c: Fix common/ includes.
7450         * corelow.c: Fix common/ includes.
7451         * completer.h: Fix common/ includes.
7452         * completer.c: Fix common/ includes.
7453         * compile/compile.c: Fix common/ includes.
7454         * compile/compile-loc2c.c: Fix common/ includes.
7455         * compile/compile-cplus-types.c: Fix common/ includes.
7456         * compile/compile-cplus-symbols.c: Fix common/ includes.
7457         * command.h: Fix common/ includes.
7458         * cli/cli-dump.c: Fix common/ includes.
7459         * cli/cli-cmds.c: Fix common/ includes.
7460         * charset.c: Fix common/ includes.
7461         * build-id.c: Fix common/ includes.
7462         * btrace.h: Fix common/ includes.
7463         * btrace.c: Fix common/ includes.
7464         * breakpoint.h: Fix common/ includes.
7465         * breakpoint.c: Fix common/ includes.
7466         * ax.h:
7467         (enum agent_op): Fix common/ includes.
7468         * ax-general.c (struct aop_map): Fix common/ includes.
7469         * ax-gdb.c: Fix common/ includes.
7470         * auxv.c: Fix common/ includes.
7471         * auto-load.c: Fix common/ includes.
7472         * arm-tdep.c: Fix common/ includes.
7473         * arch/riscv.c: Fix common/ includes.
7474         * arch/ppc-linux-common.c: Fix common/ includes.
7475         * arch/i386.c: Fix common/ includes.
7476         * arch/arm.c: Fix common/ includes.
7477         * arch/arm-linux.c: Fix common/ includes.
7478         * arch/arm-get-next-pcs.c: Fix common/ includes.
7479         * arch/amd64.c: Fix common/ includes.
7480         * arch/aarch64.c: Fix common/ includes.
7481         * arch/aarch64-insn.c: Fix common/ includes.
7482         * arch-utils.c: Fix common/ includes.
7483         * amd64-windows-tdep.c: Fix common/ includes.
7484         * amd64-tdep.c: Fix common/ includes.
7485         * amd64-sol2-tdep.c: Fix common/ includes.
7486         * amd64-obsd-tdep.c: Fix common/ includes.
7487         * amd64-nbsd-tdep.c: Fix common/ includes.
7488         * amd64-linux-tdep.c: Fix common/ includes.
7489         * amd64-linux-nat.c: Fix common/ includes.
7490         * amd64-fbsd-tdep.c: Fix common/ includes.
7491         * amd64-fbsd-nat.c: Fix common/ includes.
7492         * amd64-dicos-tdep.c: Fix common/ includes.
7493         * amd64-darwin-tdep.c: Fix common/ includes.
7494         * agent.c: Fix common/ includes.
7495         * ada-lang.h: Fix common/ includes.
7496         * ada-lang.c: Fix common/ includes.
7497         * aarch64-tdep.c: Fix common/ includes.
7498
7499 2019-01-25  Tom Tromey  <tom@tromey.com>
7500
7501         * common/create-version.sh: Use common/version.h.
7502
7503 2019-01-24  Pedro Alves  <palves@redhat.com>
7504
7505         * infrun.c (signal_stop, signal_print, signal_program)
7506         (signal_catch, signal_pass): Now arrays instead of pointers.
7507         (update_signals_program_target, do_target_resume)
7508         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7509         * linux-nat.c (linux_nat_target::pass_signals)
7510         (linux_nat_target::create_inferior, linux_nat_target::attach):
7511         Adjust.
7512         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7513         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7514         * procfs.c (procfs_target::pass_signals): Adjust.
7515         * record-full.c (record_full_target::resume): Adjust.
7516         * remote.c (remote_target::pass_signals)
7517         (remote_target::program_signals): Adjust.
7518         * target-debug.h (target_debug_print_signals): Now takes a
7519         gdb::array_view as parameter.  Adjust.
7520         * target.h (target_ops) <pass_signals, program_signals>: Replace
7521         pointer and length parameters with gdb::array_view.
7522         (target_pass_signals, target_program_signals): Likewise.
7523         * target-delegates.c: Regenerate.
7524
7525 2019-01-24  Pedro Alves  <palves@redhat.com>
7526
7527         * common/forward-scope-exit.h
7528         (forward_scope_exit::forward_scope_exit): Pass arguments to
7529         m_bind_function directly, instead of creating a std::bind and
7530         copying that.
7531
7532 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7533
7534         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7535         for static members.
7536         (pass_in_v_vfp_candidate): Likewise.
7537
7538 2019-01-23  Tom Tromey  <tom@tromey.com>
7539             Pedro Alves  <palves@redhat.com>
7540
7541         * regcache.c (class regcache_invalidator): Remove.
7542         (regcache::raw_write): Use make_scope_exit.
7543
7544 2019-01-23  Tom Tromey  <tom@tromey.com>
7545
7546         * ui-out.h (class ui_out_emit_type): Update comment.
7547
7548 2019-01-23  Tom Tromey  <tom@tromey.com>
7549
7550         * infrun.c (fetch_inferior_event): Update comment.
7551
7552 2019-01-23  Tom Tromey  <tom@tromey.com>
7553             Pedro Alves  <palves@redhat.com>
7554
7555         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7556         parameter.
7557         (fetch_inferior_event): Use SCOPE_EXIT.
7558
7559
7560 2019-01-23  Tom Tromey  <tom@tromey.com>
7561             Pedro Alves  <palves@redhat.com>
7562
7563         * infrun.c (disable_thread_events): Delete.
7564         (stop_all_threads): Use SCOPE_EXIT.
7565
7566 2019-01-23  Tom Tromey  <tom@tromey.com>
7567             Pedro Alves  <palves@redhat.com>
7568
7569         * symfile.c: Include forward-scope-exit.h.
7570         (clear_symtab_users_cleanup): Replace forward declaration with
7571         a FORWARD_SCOPE_EXIT.
7572         (syms_from_objfile_1): Use the forward_scope_exit and
7573         gdb::optional instead of cleanup_function.
7574         (reread_symbols): Use the forward_scope_exit instead of
7575         cleanup_function.
7576         (clear_symtab_users_cleanup): Remove function.
7577
7578 2019-01-23  Tom Tromey  <tom@tromey.com>
7579             Pedro Alves  <palves@redhat.com>
7580
7581         * linux-nat.c: Include scope-exit.h.
7582         (cleanup_target_stop): Remove.
7583         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7584         SCOPE_EXIT.
7585
7586 2019-01-23  Tom Tromey  <tom@tromey.com>
7587             Pedro Alves  <palves@redhat.com>
7588
7589         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7590         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7591
7592 2019-01-23  Tom Tromey  <tom@tromey.com>
7593             Andrew Burgess  <andrew.burgess@embecosm.com>
7594             Pedro Alves  <palves@redhat.com>
7595
7596         * infrun.c (fetch_inferior_event): Use scope_exit.
7597         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7598         * top.c (execute_command): Use scope_exit.
7599         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7600         * utils.c (do_bpstat_clear_actions_cleanup)
7601         (make_bpstat_clear_actions_cleanup): Remove.
7602
7603 2019-01-23  Tom Tromey  <tom@tromey.com>
7604             Pedro Alves  <palves@redhat.com>
7605
7606         * infrun.c: Include "common/scope-exit.h"
7607         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7608         (wait_for_inferior): Use SCOPE_EXIT.
7609         (fetch_inferior_event): Use scope_exit.
7610
7611 2019-01-23  Tom Tromey  <tom@tromey.com>
7612             Pedro Alves  <palves@redhat.com>
7613
7614         * breakpoint.c (create_breakpoint): Remove cleanup.
7615
7616 2019-01-23  Tom Tromey  <tom@tromey.com>
7617             Andrew Burgess  <andrew.burgess@embecosm.com>
7618             Pedro Alves  <palves@redhat.com>
7619
7620 2019-01-23  Pedro Alves  <palves@redhat.com>
7621
7622         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7623
7624 2019-01-23  Pedro Alves  <palves@redhat.com>
7625             Andrew Burgess  <andrew.burgess@embecosm.com>
7626
7627         * gdbthread.h: Include "common/forward-scope-exit.h".
7628         (scoped_finish_thread_state): Redefine custom class in terms of
7629         forward_scope_exit.
7630
7631 2019-01-23  Pedro Alves  <palves@redhat.com>
7632             Andrew Burgess  <andrew.burgess@embecosm.com>
7633
7634         * common/forward-scope-exit.h: New file.
7635
7636 2019-01-23  Pedro Alves  <palves@redhat.com>
7637             Andrew Burgess  <andrew.burgess@embecosm.com>
7638             Tom Tromey  <tom@tromey.com>
7639
7640         * common/scope-exit.h: New file.
7641
7642 2019-01-23  Pedro Alves  <palves@redhat.com>
7643
7644         * common/preprocessor.h (ESC): Rename to ...
7645         (ESC_PARENS): ... this.
7646         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7647         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7648
7649 2019-01-23  Tom Tromey  <tom@tromey.com>
7650
7651         * language.h (class scoped_switch_to_sym_language_if_auto):
7652         Initialize m_lang in both cases.
7653
7654 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7655
7656         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7657         with XCNEW.
7658
7659 2019-01-22  Tom Tromey  <tom@tromey.com>
7660
7661         * corelow.c: Do not include sys/file.h.
7662
7663 2019-01-22  Tom Tromey  <tom@tromey.com>
7664
7665         * tui/tui-wingeneral.h: Include gdb_curses.h.
7666
7667 2019-01-22  Tom Tromey  <tom@tromey.com>
7668
7669         * source-cache.h (class source_cache) <get_source_lines,
7670         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7671
7672 2019-01-22  Tom Tromey  <tom@tromey.com>
7673
7674         * remote-fileio.h (struct remote_target): Declare.
7675
7676 2019-01-22  Tom Tromey  <tom@tromey.com>
7677
7678         * python/py-arch.c: Do not include py-ref.h.
7679         * python/py-bpevent.c: Do not include py-ref.h.
7680         * python/py-cmd.c: Do not include py-ref.h.
7681         * python/py-continueevent.c: Do not include py-ref.h.
7682         * python/py-event.h: Do not include py-ref.h.
7683         * python/py-evtregistry.c: Do not include py-ref.h.
7684         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7685         * python/py-frame.c: Do not include py-ref.h.
7686         * python/py-framefilter.c: Do not include py-ref.h.
7687         * python/py-function.c: Do not include py-ref.h.
7688         * python/py-infevents.c: Do not include py-ref.h.
7689         * python/py-linetable.c: Do not include py-ref.h.
7690         * python/py-objfile.c: Do not include py-ref.h.
7691         * python/py-param.c: Do not include py-ref.h.
7692         * python/py-prettyprint.c: Do not include py-ref.h.
7693         * python/py-progspace.c: Do not include py-ref.h.
7694         * python/py-symbol.c: Do not include py-ref.h.
7695         * python/py-symtab.c: Do not include py-ref.h.
7696         * python/py-type.c: Do not include py-ref.h.
7697         * python/py-unwind.c: Do not include py-ref.h.
7698         * python/py-utils.c: Do not include py-ref.h.
7699         * python/py-value.c: Do not include py-ref.h.
7700         * python/py-varobj.c: Do not include py-ref.h.
7701         * python/py-xmethods.c: Do not include py-ref.h.
7702         * python/python.c: Do not include py-ref.h.
7703         * varobj.c: Do not include py-ref.h.
7704
7705 2019-01-22  Tom Tromey  <tom@tromey.com>
7706
7707         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7708         keyword for bcache.
7709
7710 2019-01-22  Tom Tromey  <tom@tromey.com>
7711
7712         * compile/compile-cplus-types.c: Remove a comment by #include.
7713
7714 2019-01-22  Tom Tromey  <tom@tromey.com>
7715
7716         * compile/gcc-c-plugin.h: Include compile-internal.h.
7717
7718 2019-01-22  Tom Tromey  <tom@tromey.com>
7719
7720         * stabsread.c (EXTERN): Do not define.
7721         (symnum, next_symbol_text_func, processing_gcc_compilation)
7722         (within_function, global_sym_chain, global_stabs)
7723         (previous_stab_code, this_object_header_files)
7724         (n_this_object_header_files)
7725         (n_allocated_this_object_header_files): Define.
7726         * stabsread.h (EXTERN): Never define.  Use "extern".
7727
7728 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7729
7730         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7731         history_value.
7732
7733 2019-01-21  Tom Tromey  <tom@tromey.com>
7734
7735         * ui-out.c: Fix includes.
7736         * tui/tui-source.c: Fix includes.
7737         * target.c: Fix includes.
7738         * remote.c: Fix includes.
7739         * regcache.c: Fix includes.
7740         * python/py-block.c: Fix includes.
7741         * printcmd.c: Fix includes.
7742         * or1k-tdep.c: Fix includes.
7743         * mi/mi-main.c: Fix includes.
7744         * m32r-tdep.c: Fix includes.
7745         * csky-tdep.c: Fix includes.
7746         * compile/compile-cplus-types.c: Fix includes.
7747         * cli/cli-interp.c: Fix includes.
7748
7749 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7750
7751         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7752         for padding.
7753
7754 2019-01-16  Tom Tromey  <tom@tromey.com>
7755
7756         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7757         earlier.
7758         (struct objfile) <msymbols_range>: Move from top level.
7759         <msymbols>: New method.
7760         (class objfile_msymbols): Remove.
7761         * symtab.c (default_collect_symbol_completion_matches_break_on):
7762         Update.
7763         * symmisc.c (dump_msymbols): Update.
7764         * stabsread.c (scan_file_globals): Update.
7765         * objc-lang.c (info_selectors_command, info_classes_command)
7766         (find_methods): Update.
7767         * minsyms.c (find_solib_trampoline_target): Update.
7768         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7769         * coffread.c (coff_symfile_read): Update.
7770         * ada-lang.c (ada_lookup_simple_minsym)
7771         (ada_collect_symbol_completion_matches): Update.
7772
7773 2019-01-16  Tom Tromey  <tom@tromey.com>
7774
7775         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7776         type.  Remove no-argument constructor.
7777         <iterator::operator++>: Simplify.
7778         <begin>: Update.
7779         <end>: Use minimal_symbol_count.
7780
7781 2019-01-16  Tom Tromey  <tom@tromey.com>
7782
7783         * objfiles.h (struct objfile) <psymtabs>: New method.
7784         (class objfile_psymtabs): Remove.
7785         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7786         typedef.
7787         <range>: New method.
7788         (require_partial_symbols): Change return type.
7789         * psymtab.c (require_partial_symbols)
7790         (psym_expand_symtabs_matching): Update.
7791         * mdebugread.c (parse_partial_symbols): Update.
7792         * dbxread.c (dbx_end_psymtab): Update.
7793
7794 2019-01-15  Tom Tromey  <tom@tromey.com>
7795
7796         * symtab.c (lookup_objfile_from_block)
7797         (lookup_symbol_in_objfile_symtabs)
7798         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7799         (find_line_symtab, info_sources_command)
7800         (default_collect_symbol_completion_matches_break_on)
7801         (make_source_files_completion_list): Update.
7802         * symmisc.c (print_objfile_statistics, dump_objfile)
7803         (maintenance_print_symbols, maintenance_info_symtabs)
7804         (maintenance_check_symtabs, maintenance_info_line_tables):
7805         Update.
7806         * source.c (select_source_symtab)
7807         (forget_cached_source_info_for_objfile): Update.
7808         * objfiles.h (class objfile_compunits): Remove.
7809         (struct objfile) <compunits_range>: New typedef.
7810         (compunits): New method.
7811         * objfiles.c (objfile_relocate1): Update.
7812         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7813         * maint.c (count_symtabs_and_blocks): Update.
7814         * linespec.c (iterate_over_all_matching_symtabs): Update.
7815         * cp-support.c (add_symbol_overload_list_qualified): Update.
7816         * coffread.c (coff_symtab_read): Update.
7817         * ada-lang.c (add_nonlocal_symbols)
7818         (ada_collect_symbol_completion_matches)
7819         (ada_add_global_exceptions): Update.
7820
7821 2019-01-15  Tom Tromey  <tom@tromey.com>
7822
7823         * progspace.h (program_space) <objfiles_safe_range>: New
7824         typedef.
7825         <objfiles_safe>: New method.
7826         * objfiles.h (class all_objfiles_safe): Remove.
7827         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7828         * jit.c (jit_inferior_exit_hook): Update.
7829
7830 2019-01-17  Tom Tromey  <tom@tromey.com>
7831
7832         * progspace.h (program_space) <objfiles_range>: New typedef.
7833         <objfiles>: New method.
7834         <objfiles_head>: Rename from objfiles.
7835         (object_files): Update.
7836         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7837         * guile/scm-pretty-print.c
7838         (ppscm_find_pretty_printer_from_objfiles): Update.
7839         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7840         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7841         Update.
7842         * python/py-progspace.c (pspy_get_objfiles): Update.
7843         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7844         Update.
7845         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7846         (objfpy_lookup_objfile_by_build_id): Update.
7847         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7848         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7849         Update.
7850         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7851         (expand_symtab_containing_pc, lookup_objfile_from_block)
7852         (lookup_static_symbol, basic_lookup_transparent_type)
7853         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7854         (find_line_symtab, info_sources_command)
7855         (default_collect_symbol_completion_matches_break_on)
7856         (make_source_files_completion_list, find_main_name): Update.
7857         * symmisc.c (print_symbol_bcache_statistics)
7858         (print_objfile_statistics, maintenance_print_symbols)
7859         (maintenance_print_msymbols, maintenance_print_objfiles)
7860         (maintenance_info_symtabs, maintenance_check_symtabs)
7861         (maintenance_expand_symtabs, maintenance_info_line_tables):
7862         Update.
7863         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7864         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7865         (map_overlay_command, unmap_overlay_command)
7866         (simple_overlay_update, expand_symtabs_matching)
7867         (map_symbol_filenames): Update.
7868         * symfile-debug.c (set_debug_symfile): Update.
7869         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7870         Update.
7871         * source.c (select_source_symtab, forget_cached_source_info):
7872         Update.
7873         * solib.c (solib_read_symbols): Update.
7874         * solib-spu.c (append_ocl_sos): Update.
7875         * psymtab.c (maintenance_print_psymbols)
7876         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7877         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7878         * printcmd.c (info_symbol_command): Update.
7879         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7880         Update.
7881         * objfiles.h (class all_objfiles): Remove.
7882         * objfiles.c (have_partial_symbols, have_full_symbols)
7883         (have_minimal_symbols, qsort_cmp, update_section_map)
7884         (shared_objfile_contains_address_p)
7885         (default_iterate_over_objfiles_in_search_order): Update.
7886         * objc-lang.c (info_selectors_command, info_classes_command)
7887         (find_methods): Update.
7888         * minsyms.c (find_solib_trampoline_target): Update.
7889         * maint.c (maintenance_info_sections)
7890         (maintenance_translate_address, count_symtabs_and_blocks):
7891         Update.
7892         * main.c (captured_main_1): Update.
7893         * linux-thread-db.c (try_thread_db_load_from_pdir)
7894         (has_libpthread): Update.
7895         * linespec.c (iterate_over_all_matching_symtabs)
7896         (search_minsyms_for_name): Update.
7897         * jit.c (jit_find_objf_with_entry_addr): Update.
7898         * hppa-tdep.c (find_unwind_entry)
7899         (hppa_lookup_stub_minimal_symbol): Update.
7900         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7901         Update.
7902         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7903         (elf_gnu_ifunc_resolve_by_got): Update.
7904         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7905         * dwarf-index-write.c (save_gdb_index_command): Update.
7906         * cp-support.c (add_symbol_overload_list_qualified): Update.
7907         * breakpoint.c (create_overlay_event_breakpoint)
7908         (create_longjmp_master_breakpoint)
7909         (create_std_terminate_master_breakpoint)
7910         (create_exception_master_breakpoint): Update.
7911         * blockframe.c (find_pc_partial_function): Update.
7912         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7913         (ada_collect_symbol_completion_matches)
7914         (ada_add_global_exceptions): Update.
7915
7916 2019-01-17  Tom Tromey  <tom@tromey.com>
7917
7918         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7919         declare VEC.
7920         (solib_target_parse_libraries): Change return type.
7921         (library_list_start_segment, library_list_start_section)
7922         (library_list_end_library, library_list_start_library); Update.
7923         (solib_target_free_library_list): Remove.
7924         (solib_target_parse_libraries): Remove cleanup.  Change return
7925         type.
7926         (solib_target_current_sos): Update.
7927
7928 2019-01-17  Tom Tromey  <tromey@bapiya>
7929
7930         * valprint.c: Replace "the the" with "the".
7931         * symtab.c: Replace "the the" with "the".
7932         * solib.c: Replace "the the" with "the".
7933         * solib-dsbt.c: Replace "the the" with "the".
7934         * linespec.c: Replace "the the" with "the".
7935         * dwarf2loc.h: Replace "the the" with "the".
7936         * amd64-windows-tdep.c: Replace "the the" with "the".
7937         * aarch64-tdep.c: Replace "the the" with "the".
7938
7939 2019-01-16  Keith Seitz  <keiths@redhat.com>
7940
7941         PR gdb/23773
7942         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7943         <builder>: Rename to ..
7944         <m_builder>: ... this and make private.
7945         (dwarf2_cu::get_builder): New method.  Change all users of
7946         `builder' to use this method.
7947         (dwarf2_start_symtab): Move to ...
7948         (dwarf2_cu::start_symtab): ... here.  Update all callers
7949         (setup_type_unit_groups): Move to ...
7950         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7951         callers.
7952         (dwarf2_cu::reset_builder): New method.
7953         (process_full_compunit, process_full_type_unit): Use
7954         dwarf2_cu::reset_builder.
7955         (follow_die_offset): Record the ancestor CU if it is different
7956         from the followed DIE's CU.
7957         (follow_die_sig_1): Likewise.
7958
7959 2019-01-15  Tom Tromey  <tom@tromey.com>
7960
7961         * remote.c (class remote_state) <buf>: Now a char_vector.
7962         <buf_size>: Remove.
7963         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7964         parameter.
7965         (remote_target::getpkt_or_notif_sane_1)
7966         (remote_target::getpkt_sane)
7967         (remote_target::getpkt_or_notif_sane): Likewise.
7968         (class remote_target) <putpkt>: New overload.
7969         (remote_target::read_frame): Change type of "buf_p".  Remove
7970         sizeof_p parameter.
7971         (packet_ok): New overload.
7972         (packet_check_result): New overload.
7973         Update all uses.
7974
7975 2019-01-14  Tom Tromey  <tom@tromey.com>
7976
7977         * remote-notif.c (handle_notification, remote_notif_ack)
7978         (remote_notif_parse): Make "buf" const.
7979         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7980         const.
7981         (remote_notif_parse, remote_notif_ack, handle_notification):
7982         Likewise.
7983         * remote.c (remote_notif_stop_parse): Make "buf" const.
7984         (remote_target::remote_parse_stop_reply): Make "buf" const.
7985         (remote_notif_stop_ack): Make "buf" const.
7986
7987 2019-01-14  Tom Tromey  <tom@tromey.com>
7988
7989         * remote.c (remote_console_output): Make parameter const.
7990
7991 2019-01-14  Tom Tromey  <tom@tromey.com>
7992
7993         * target-debug.h (target_debug_print_signals): Constify.
7994         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7995         * procfs.c (procfs_target::pass_signals): Update.
7996         * linux-nat.c (linux_nat_target::pass_signals): Update.
7997         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7998         * target-delegates.c: Rebuild.
7999         * remote.c (remote_target::program_signals): Update.
8000         (remote_target::pass_signals): Update.
8001         * target.c (target_pass_signals): Constify argument.
8002         (target_program_signals): Likewise.
8003         * target.h (struct target_ops) <pass_signals, program_signals>:
8004         Constify argument.
8005         (target_pass_signals, target_program_signals): Constify argument.
8006
8007 2019-01-14  Tom Tromey  <tom@tromey.com>
8008
8009         PR tui/28819:
8010         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8011
8012 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8013
8014         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8015         field.
8016         * rs6000-tdep.c: Include reggroups.h.
8017         (IS_V_ALIAS_PSEUDOREG): Define.
8018         (rs6000_register_name): Return names for the "vX" aliases.
8019         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8020         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8021         aliases.  Call default_register_reggroup_p for all other
8022         pseudo-registers.
8023         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8024         New functions.
8025         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8026         Handle "vX" aliases.
8027         (v_alias_pseudo_register_collect): New function.
8028         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8029         (rs6000_gdbarch_init): Initialize "vX" aliases as
8030         pseudo-registers.  Restore registration of
8031         rs6000_pseudo_register_reggroup_p with
8032         set_tdesc_pseudo_register_reggroup_p.
8033
8034 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8035
8036         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8037         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8038         set_gdbarch_num_pseudo_regs.
8039
8040 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8041
8042         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8043         Remove arg prefixname, add do_set and do_show.
8044         Add member functions set_list and show_list.
8045         * cli/cli-style.c (class cli_style_option): Update accordingly.
8046         (style_set_list): Move to file scope.
8047         (style_show_list): Likewise.
8048         (set_style): Call help_list.
8049         (show_style): Call cmd_show_list.
8050         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8051         Update to use the new macro.
8052
8053 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8054
8055         * ada-lang.c (_initialize_ada_language): Expand the help text
8056         for the "catch exception" command.
8057
8058 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8059
8060         * symtab.c (matching_obj_sections): Initialize obj,
8061         declare it closer to its usage.
8062
8063 2019-01-10  Tom Tromey  <tom@tromey.com>
8064
8065         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8066         (basic_inf_threads_range): Remove.
8067         (inf_threads_range, inf_non_exited_threads_range)
8068         (safe_inf_threads_range): Use next_adapter.
8069
8070 2019-01-10  Keith Seitz  <keiths@redhat.com>
8071
8072         PR gdb/23712
8073         PR symtab/23010
8074         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8075         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8076
8077 2019-01-10  Keith Seitz  <keiths@redhat.com>
8078
8079         PR gdb/23712
8080         PR symtab/23010
8081         * dictionary.c (pending_to_vector): Remove.
8082         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8083         Remove _1 suffix, replacing functions of the same name.  Update
8084         all callers.
8085         (dict_create_hashed, dict_create_hashed_expandable)
8086         (dict_create_linear, dict_create_linear_expandable, dict_free)
8087         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8088         Make functions static.
8089
8090 2019-01-10  Keith Seitz  <keiths@redhat.com>
8091
8092         PR gdb/23712
8093         PR symtab/23010
8094         * dictionary.h (struct dictionary): Replace declaration with
8095         multidictionary.
8096         (dict_create_hashed, dict_create_hashed_expandable)
8097         (dict_create_linear, dict_create_linear_expandable)
8098         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8099         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8100         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8101         taking multidictionary argument.
8102         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8103         * block.h (struct block) <dict>: Change to multidictionary
8104         and rename `multidict'.
8105         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8106         symmisc.c: Update all dictionary references to multidictionary.
8107
8108 2019-01-10  Keith Seitz  <keiths@redhat.com>
8109
8110         PR gdb/23712
8111         PR symtab/23010
8112         * dictionary.c: Include unordered_map.
8113         (pending_to_vector): New function.
8114         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8115         Rewrite the non-"_1" functions to take vector instead
8116         of linked list.
8117         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8118         "new" _1 versions of the same name.
8119         (multidictionary): Define.
8120         (std::hash<enum language): New definition.
8121         (collate_pending_symbols_by_language, mdict_create_hashed)
8122         (mdict_create_hashed_expandable, mdict_create_linear)
8123         (mdict_create_linear_expandable, mdict_free)
8124         (find_language_dictionary, create_new_language_dictionary)
8125         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8126         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8127         (mdict_size, mdict_empty): New functions.
8128         * dictionary.h (mdict_iterator): Define.
8129
8130 2019-01-10  Pedro Alves  <palves@redhat.com>
8131
8132         * breakpoint.c (read_uploaded_action)
8133         (create_tracepoint_from_upload): Adjust to use
8134         gdb::unique_xmalloc_ptr.
8135         * ctf.c (ctf_write_uploaded_tp):
8136         (SET_ARRAY_FIELD): Use emplace_back.
8137         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8138         * tracefile-tfile.c (tfile_write_uploaded_tp):
8139         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8140         gdb::unique_xmalloc_ptr.
8141         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8142         at_string, cond_string, cmd_strings>: Replace char pointers
8143         with gdb::unique_xmalloc_ptr.
8144
8145 2019-01-10  Pedro Alves  <palves@redhat.com>
8146
8147         * solib-target.c (library_list_start_library): Don't xstrdup name.
8148
8149 2019-01-10  Pedro Alves  <palves@redhat.com>
8150
8151         * mdebugread.c (parse_partial_symbols): Use
8152         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8153
8154 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8155
8156         * linux-fork.c (scoped_switch_fork_info)
8157         <~scoped_switch_fork_info>: Fix incorrect variable name.
8158
8159 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8160
8161         * linux-fork.c (scoped_switch_fork_info)
8162         <scoped_switch_fork_info>: Make explicit.
8163         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8164
8165 2019-01-10  Tom Tromey  <tom@tromey.com>
8166
8167         * objfiles.h (objfile::reset_psymtabs): Update.
8168         * objfiles.c (objfile::objfile): Update.
8169         * psymtab.h (psymtab_storage::obstack): Update.
8170         (psymtab_storage::m_obstack): Use gdb::optional.
8171         (class psymtab_storage): Update comment.  Remove objfile
8172         parameter.
8173         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8174
8175 2019-01-10  Tom Tromey  <tom@tromey.com>
8176
8177         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8178         <free_psymtabs>: Now private.
8179         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8180         (allocate_psymtab): Use new method.
8181
8182 2019-01-10  Tom Tromey  <tom@tromey.com>
8183
8184         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8185         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8186         * mdebugread.c (parse_partial_symbols): Use
8187         allocate_dependencies.
8188         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8189         allocate_dependencies.
8190         (process_psymtab_comp_unit_reader)
8191         (build_type_psymtab_dependencies): Likewise.
8192         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8193
8194 2019-01-10  Tom Tromey  <tom@tromey.com>
8195
8196         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8197         PSYMBOL_SET_LANGUAGE.
8198         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8199
8200 2019-01-10  Tom Tromey  <tom@tromey.com>
8201
8202         * psymtab.h (psymtab_storage::obstack): New method.
8203         <m_obstack>: Rename from obstack; now private.
8204         * psymtab.c (psymtab_storage): Update.
8205         * dwarf2read.c (create_addrmap_from_index)
8206         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8207         Update.
8208
8209 2019-01-10  Tom Tromey  <tom@tromey.com>
8210
8211         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8212         * objfiles.h (objfile::reset_psymtabs): New method.
8213
8214 2019-01-10  Tom Tromey  <tom@tromey.com>
8215
8216         * symmisc.c (print_symbol_bcache_statistics): Update.
8217         (print_objfile_statistics): Update.
8218         * symfile.c (reread_symbols): Update.
8219         * psymtab.h (class psymtab_storage): New.
8220         * psymtab.c (psymtab_storage): New constructor.
8221         (~psymtab_storage): New destructor.
8222         (require_partial_symbols): Update.
8223         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8224         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8225         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8226         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8227         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8228         (start_psymtab_common, end_psymtab_common)
8229         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8230         (allocate_psymtab): Update.
8231         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8232         Update.
8233         (dump_psymtab_addrmap, maintenance_print_psymbols)
8234         (maintenance_check_psymtabs): Update.
8235         (class objfile_psymtabs): Move to objfiles.h.
8236         * psympriv.h (discard_psymtab): Now inline.
8237         (psymtab_discarder::psymtab_discarder): Update.
8238         (psymtab_discarder::~psymtab_discarder): Update.
8239         (ALL_OBJFILE_PSYMTABS): Rewrite.
8240         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8241         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8242         Remove fields.
8243         <partial_symtabs>: New field.
8244         (class objfile_psymtabs): Move from psymtab.h.  Update.
8245         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8246         psymbol_cache.
8247         (objfile::~objfile): Don't destroy psymbol_cache.
8248         * mdebugread.c (parse_partial_symbols): Update.
8249         * dwarf2read.c (create_addrmap_from_index)
8250         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8251         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8252         (add_partial_subprogram, dwarf2_ranges_read): Update.
8253         * dwarf-index-write.c (write_address_map)
8254         (write_one_signatured_type, recursively_write_psymbols)
8255         (class debug_names, class debug_names, write_psymtabs_to_index):
8256         Update.
8257
8258 2019-01-10  Tom Tromey  <tom@tromey.com>
8259
8260         * symtab.h (SYMBOL_SET_NAMES): Update.
8261         (symbol_set_names): Update.
8262         (MSYMBOL_SET_NAMES): Update.
8263         * symtab.c (symbol_set_names): Change argument to be an
8264         objfile_per_bfd_storage.
8265         * psymtab.c (add_psymbol_to_bcache): Update.
8266         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8267
8268 2019-01-10  Tom Tromey  <tom@tromey.com>
8269
8270         * symtab.c (create_demangled_names_hash): Change argument to be an
8271         objfile_per_bfd_storage.
8272         (symbol_set_names): Update.
8273
8274 2019-01-10  Tom Tromey  <tom@tromey.com>
8275
8276         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8277         init_psymbol_list.
8278         * psymtab.c (init_psymbol_list): Do nothing if already called.
8279         * psympriv.h (init_psymbol_list): Add comment.
8280         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8281         init_psymbol_list.
8282         * dbxread.c (dbx_symfile_read): Unconditionally call
8283         init_psymbol_list.
8284
8285 2019-01-10  Tom Tromey  <tom@tromey.com>
8286
8287         * xcoffread.c (scan_xcoff_symtab): Update.
8288         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8289         "where".
8290         * mdebugread.c (parse_partial_symbols)
8291         (handle_psymbol_enumerators): Update.
8292         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8293         * dbxread.c (read_dbx_symtab): Update.
8294         * psympriv.h (psymbol_placement): New enum.
8295         (add_psymbol_to_list): Update.
8296
8297 2019-01-10  Tom Tromey  <tom@tromey.com>
8298
8299         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8300         static_psymbols parameters.
8301         (scan_xcoff_symtab): Update.
8302         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8303         static_psymbols parameters.
8304         * psympriv.h (start_psymtab_common): Update.
8305         * mdebugread.c (parse_partial_symbols): Update.
8306         * dwarf2read.c (create_partial_symtab): Update.
8307         * dbxread.c (read_dbx_symtab): Update.
8308         (start_psymtab): Remove global_psymbols and static_psymbols
8309         parameters.
8310
8311 2019-01-10  Tom Tromey  <tom@tromey.com>
8312
8313         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8314         * psymtab.c (allocate_psymtab): Add comment.
8315         * psympriv.h (allocate_psymtab): Add comment.
8316         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8317         initializations.
8318         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8319
8320 2019-01-10  Tom Tromey  <tom@tromey.com>
8321
8322         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8323         Don't declare.
8324         * mipsread.c: Include mdebugread.h.
8325         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8326         Declare.
8327         * elfread.c: Include mdebugread.h.
8328
8329 2019-01-09  Tom Tromey  <tom@tromey.com>
8330
8331         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8332         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8333         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8334         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8335         (psym_lookup_symbol, psym_find_last_source_symtab)
8336         (psym_forget_cached_source_info, psym_print_stats)
8337         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8338         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8339         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8340         (psym_find_compunit_symtab_by_address)
8341         (maintenance_print_psymbols, maintenance_info_psymtabs)
8342         (maintenance_check_psymtabs): Use ranged for.
8343         * psymtab.h (class objfile_psymtabs): New.
8344         (require_partial_symbols): Return objfile_psymtabs.
8345         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8346
8347 2019-01-09  Tom Tromey  <tom@tromey.com>
8348
8349         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8350         (find_pc_mapped_section, list_overlays_command)
8351         (map_overlay_command, unmap_overlay_command)
8352         (simple_overlay_update): Use all_objfiles.
8353         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8354         * printcmd.c (info_symbol_command): Use all_objfiles.
8355         * objfiles.h (ALL_OBJSECTIONS): Remove.
8356         * maint.c (maintenance_translate_address): Use all_objfiles.
8357         * gcore.c (gcore_create_callback): Use all_objfiles.
8358         (objfile_find_memory_regions): Likewise.
8359
8360 2019-01-09  Tom Tromey  <tom@tromey.com>
8361
8362         * symtab.c (find_line_symtab, info_sources_command)
8363         (make_source_files_completion_list): Use objfile_compunits.
8364         * source.c (select_source_symtab): Use objfile_compunits.
8365         * objfiles.h (struct objfile): Update comment.
8366         (ALL_OBJFILES): Remove.
8367         (ALL_FILETABS): Remove.
8368         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8369         objfile_compunits.
8370
8371 2019-01-09  Tom Tromey  <tom@tromey.com>
8372
8373         * symmisc.c (print_objfile_statistics, dump_objfile)
8374         (maintenance_print_symbols): Use compunit_filetabs.
8375         * source.c (forget_cached_source_info_for_objfile): Use
8376         compunit_filetabs.
8377         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8378         (ALL_FILETABS): Use compunit_filetabs.
8379         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8380         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8381
8382 2019-01-09  Tom Tromey  <tom@tromey.com>
8383
8384         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8385         (compunit_filetabs): New.
8386         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8387         compunit_filetabs.
8388         (info_sources_command, make_source_files_completion_list): Remove
8389         declaration.
8390         * symmisc.c (print_objfile_statistics, dump_objfile)
8391         (maintenance_print_symbols): Remove declaration.
8392         (maintenance_info_symtabs): Use compunit_filetabs.
8393         (maintenance_info_line_tables): Likewise.
8394         * source.c (select_source_symtab): Change local variable name.
8395         (forget_cached_source_info_for_objfile): Remove declaration.
8396         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8397         * objfiles.c (objfile_relocate1): Remove declaration.
8398         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8399         declaration.
8400         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8401         * coffread.c (coff_symtab_read): Remove declaration.
8402         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8403         compunit_filetabs.
8404
8405 2019-01-09  Tom Tromey  <tom@tromey.com>
8406
8407         * symtab.c (lookup_objfile_from_block)
8408         (find_pc_sect_compunit_symtab, search_symbols)
8409         (default_collect_symbol_completion_matches_break_on): Use
8410         objfile_compunits.
8411         * objfiles.h (ALL_COMPUNITS): Remove.
8412         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8413         * cp-support.c (add_symbol_overload_list_qualified): Use
8414         objfile_compunits.
8415         * ada-lang.c (ada_collect_symbol_completion_matches)
8416         (ada_add_global_exceptions): Use objfile_compunits.
8417
8418 2019-01-09  Tom Tromey  <tom@tromey.com>
8419
8420         * source.c (select_source_symtab)
8421         (forget_cached_source_info_for_objfile): Remove declaration.
8422         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8423         declaration.
8424         * maint.c (count_symtabs_and_blocks): Remove declaration.
8425         * cp-support.c (add_symbol_overload_list_qualified): Remove
8426         declaration.
8427         * coffread.c (coff_symtab_read): Remove declaration.
8428         * symtab.c (lookup_symbol_in_objfile_symtabs)
8429         (basic_lookup_transparent_type_1): Use objfile_compunits.
8430         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8431         (info_sources_command, search_symbols)
8432         (default_collect_symbol_completion_matches_break_on)
8433         (make_source_files_completion_list): Remove declaration.
8434         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8435         (ada_collect_symbol_completion_matches)
8436         (ada_add_global_exceptions): Remove declaration.
8437         * linespec.c (iterate_over_all_matching_symtabs): Use
8438         objfile_compunits.
8439         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8440         (class objfile_compunits): New.
8441         (ALL_COMPUNITS): Use objfile_compunits.
8442         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8443         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8444         objfile_compunits.
8445         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8446
8447 2019-01-09  Tom Tromey  <tom@tromey.com>
8448
8449         * symtab.c (search_symbols)
8450         (default_collect_symbol_completion_matches_break_on): Use
8451         objfile_msymbols.
8452         * ada-lang.c (ada_lookup_simple_minsym)
8453         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8454         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8455         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8456         objfile_msymbols.
8457         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8458         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8459         * objc-lang.c (find_methods): Use objfile_msymbols.
8460         (info_selectors_command, info_classes_command): Likewise.
8461         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8462         * objfiles.h (class objfile_msymbols): New.
8463         (ALL_OBJFILE_MSYMBOLS): Remove.
8464         (ALL_MSYMBOLS): Remove.
8465
8466 2019-01-09  Tom Tromey  <tom@tromey.com>
8467
8468         * common/next-iterator.h (next_adapter): Add Iterator template
8469         parameter.
8470         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8471         (class all_objfiles_safe): New.
8472         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8473         * objfiles.c (put_objfile_before): Update comment.
8474         (add_separate_debug_objfile): Likewise.
8475         (free_all_objfiles): Use all_objfiles_safe.
8476         (objfile_purge_solibs): Likewise.
8477
8478 2019-01-09  Tom Tromey  <tom@tromey.com>
8479
8480         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8481         (expand_symtab_containing_pc, lookup_static_symbol)
8482         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8483         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8484         all_objfiles.
8485         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8486         * breakpoint.c (create_overlay_event_breakpoint)
8487         (create_longjmp_master_breakpoint)
8488         (create_std_terminate_master_breakpoint)
8489         (create_exception_master_breakpoint): Use all_objfiles.
8490         * linux-thread-db.c (try_thread_db_load_from_pdir)
8491         (has_libpthread): Use all_objfiles.
8492         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8493         * linespec.c (iterate_over_all_matching_symtabs)
8494         (search_minsyms_for_name): Use all_objfiles.
8495         * maint.c (maintenance_info_sections): Use all_objfiles.
8496         * main.c (captured_main_1): Use all_objfiles.
8497         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8498         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8499         * guile/scm-pretty-print.c
8500         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8501         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8502         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8503         (maintenance_print_msymbols): Use all_objfiles.
8504         * source.c (select_source_symtab): Use all_objfiles.
8505         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8506         * symfile.c (remove_symbol_file_command)
8507         (expand_symtabs_matching, map_symbol_filenames): Use
8508         all_objfiles.
8509         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8510         all_objfiles.
8511         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8512         * objc-lang.c (find_methods): Use all_objfiles.
8513         * objfiles.c (have_partial_symbols, have_full_symbols)
8514         (have_minimal_symbols, qsort_cmp)
8515         (default_iterate_over_objfiles_in_search_order): Use
8516         all_objfiles.
8517         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8518         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8519         (maintenance_check_psymtabs): Use all_objfiles.
8520         (ALL_PSYMTABS): Remove.
8521         * compile/compile-object-run.c (do_module_cleanup): Use
8522         all_objfiles.
8523         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8524         * cp-support.c (add_symbol_overload_list_qualified): Use
8525         all_objfiles.
8526         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8527         Use all_objfiles.
8528         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8529         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8530         all_objfiles.
8531         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8532         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8533         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8534         Uses all_objfiles.
8535         * solib.c (solib_read_symbols): Use all_objfiles
8536
8537 2019-01-09  Tom Tromey  <tom@tromey.com>
8538
8539         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8540         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8541         all_objfiles.
8542         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8543         * symmisc.c (print_symbol_bcache_statistics)
8544         (print_objfile_statistics, maintenance_print_objfiles)
8545         (maintenance_info_symtabs, maintenance_check_symtabs)
8546         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8547         all_objfiles.
8548         * source.c (forget_cached_source_info): Use all_objfiles.
8549         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8550         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8551         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8552         * objfiles.c (update_section_map): Use all_objfiles.
8553         (shared_objfile_contains_address_p): Likewise.
8554         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8555         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8556
8557 2019-01-09  Tom Tromey  <tom@tromey.com>
8558
8559         * common/next-iterator.h: New file.
8560         * objfiles.h (class all_objfiles): New.
8561         (struct objfile_iterator): New.
8562
8563 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8564
8565         * NEWS: Move the description of the changed "frame", "select-frame",
8566          and "info frame" commands to the Changed commands section.
8567
8568 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8569
8570         * gdbtypes.c (check_stub_method_group): Remove handling of old
8571         mangling schemes.
8572         * linespec.c (find_methods): Likewise.
8573         * stabsread.c (read_member_functions): Likewise.
8574         * valops.c (search_struct_method): Likewise.
8575         (value_struct_elt_for_reference): Likewise.
8576         * NEWS: Mention this change.
8577
8578 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8579
8580         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8581         print_source_lines.
8582         * source.c (print_source_lines_base): Update line number check.
8583         (print_source_lines): New function.
8584         (source_lines_range::source_lines_range): New function.
8585         * source.h (class source_lines_range): New class.
8586         (print_source_lines): New declaration.
8587
8588 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8589
8590         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8591
8592 2019-01-08  Tom Tromey  <tom@tromey.com>
8593             Simon Marchi  <simon.marchi@ericsson.com>
8594
8595         PR gdb/24060
8596         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8597         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8598         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8599         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8600         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8601         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8602
8603 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8604
8605         * source.c (select_source_symtab): Move header comment to
8606         declaration in source.h.
8607         (forget_cached_source_info_for_objfile): Likewise.
8608         (forget_cached_source_info): Likewise.
8609         (identify_source_line): Likewise.
8610         * source.h (identify_source_line): Move declaration from symtab.h
8611         and add comment from source.c
8612         (print_source_lines): Likewise.
8613         (forget_cached_source_info_for_objfile): Likewise.
8614         (forget_cached_source_info): Likewise.
8615         (select_source_symtab): Likewise.
8616         (enum print_source_lines_flag): Move definition from symtab.h.
8617         * symtab.h (identify_source_line): Move declaration to source.h.
8618         (print_source_lines): Likewise.
8619         (forget_cached_source_info_for_objfile): Likewise.
8620         (forget_cached_source_info): Likewise.
8621         (select_source_symtab): Likewise.
8622         (enum print_source_lines_flag): Move definition to source.h.
8623         * tui/tui-hooks.c: Add 'source.h' include.
8624
8625 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8626
8627         * source.c (print_source_lines_base): Handle requests to print
8628         reverse line number sequences, and guard against empty lines
8629         string.
8630
8631 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8632
8633         * source.c (print_source_lines_base): Fix skip of '\r' if next
8634         character is '\n'.
8635
8636 2019-01-06  Tom Tromey  <tom@tromey.com>
8637
8638         * c-exp.y (struct c_parse_state) <macro_original_text,
8639         expansion_obstack>: New member.
8640         (macro_original_text, expansion_obstack): Remove globals.
8641         (scan_macro_expansion, scanning_macro_expansion)
8642         (finished_macro_expansion): Update.
8643         (scan_macro_cleanup): Remove.
8644         (yylex, c_parse): Update.
8645
8646 2019-01-06  Tom Tromey  <tom@tromey.com>
8647
8648         * c-exp.y (struct c_parse_state) <strings>: New member.
8649         (operator_stoken): Update.
8650
8651 2019-01-06  Tom Tromey  <tom@tromey.com>
8652
8653         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8654         (union type_stack_elt) <typelist_val>: Now a pointer to
8655         std::vector.
8656         (type_stack_cleanup): Don't declare.
8657         (push_typelist): Update.
8658         * parse.c (pop_typelist): Return a std::vector.
8659         (push_typelist): Take a std::vector.
8660         (follow_types): Update.  Do not free args.
8661         (type_stack_cleanup): Remove.
8662         * c-exp.y (struct c_parse_state): New.
8663         (cpstate): New global.
8664         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8665         (nonempty_typelist): Update.
8666         (func_mod): Create a new vector.
8667         (c_parse): Create a c_parse_state.
8668         (check_parameter_typelist): Do not delete params.
8669         (function_method): Update.  Do not delete type_list.
8670
8671 2019-01-06  Tom Tromey  <tom@tromey.com>
8672
8673         PR gdb/28155:
8674         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8675         check_typedef.
8676         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8677         (print_return_value): Likewise.
8678
8679 2019-01-05  Tom Tromey  <tom@tromey.com>
8680
8681         * contrib/cleanup_check.py: Remove.
8682         * contrib/gcc-with-excheck: Remove.
8683         * contrib/exsummary.py: Remove.
8684         * contrib/excheck.py: Remove.
8685
8686 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8687
8688         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8689         NULL. Initialize tpprev to NULL instead of assigning it
8690         to NULL on the next statement.
8691         * windows-nat.c (windows_delete_thread): Remove check for
8692         main_thread_id before printing thread exit notifications.
8693         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8694         Remove thread ID check against main_thread_id.
8695         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8696         windows_delete_thread.
8697         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8698
8699 2019-01-04  Tom Tromey  <tom@tromey.com>
8700
8701         * compile/compile.c (_initialize_compile): Use upper case for
8702         metasyntactic variables.
8703         * symmisc.c (_initialize_symmisc): Use upper case for
8704         metasyntactic variables.
8705         * psymtab.c (_initialize_psymtab): Use upper case for
8706         metasyntactic variables.
8707         * demangle.c (demangle_command): Use upper case for metasyntactic
8708         variables.
8709         (_initialize_demangler): Likewise.
8710         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8711         variables.
8712
8713 2019-01-03  Tom Tromey  <tom@tromey.com>
8714
8715         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8716
8717 2019-01-03  Tom Tromey  <tom@tromey.com>
8718
8719         * python/py-symtab.c (salpy_str): Update.
8720         (struct salpy_sal_object) <symtab>: Now a PyObject.
8721         (salpy_dealloc): Update.
8722         (del_objfile_sal): Use gdbpy_ref.
8723
8724 2019-01-03  Tom Tromey  <tom@tromey.com>
8725
8726         * python/py-type.c (convert_field): Use new_reference.  Return
8727         gdbpy_ref.
8728         (make_fielditem): Return gdbpy_ref.
8729         (typy_fields): Update.
8730         (typy_getitem): Update.
8731         (field_name): Return gdbpy_ref.  Use new_reference.
8732         (typy_iterator_iternext): Update.
8733
8734 2019-01-03  Tom Tromey  <tom@tromey.com>
8735
8736         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8737
8738 2019-01-03  Tom Tromey  <tom@tromey.com>
8739
8740         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8741         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8742         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8743         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8744         (pspy_set_type_printers): Likewise.
8745         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8746         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8747         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8748         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8749         (objfpy_set_type_printers): Likewise.
8750
8751 2019-01-03  Tom Tromey  <tom@tromey.com>
8752
8753         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8754         (gdbpy_print_stack): Use gdbpy_err_fetch.
8755         * python/python-internal.h (class gdbpy_err_fetch): New class.
8756         (class gdbpy_enter) <m_error_type, m_error_value,
8757         m_error_traceback>: Remove.
8758         <m_error>: New member.
8759         (gdbpy_exception_to_string): Don't declare.
8760         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8761         * python/py-value.c (convert_value_from_python): Use
8762         gdbpy_err_fetch.
8763         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8764         gdbpy_exception_to_string.
8765         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8766         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8767         gdbpy_err_fetch.
8768
8769 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8770
8771         * linux-nat.c (delete_lwp_cleanup): Delete.
8772         (struct lwp_deleter): New struct.
8773         (lwp_info_up): New typedef.
8774         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8775         lwp_info_up.
8776
8777 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8778
8779         * linux-fork.c (class scoped_switch_fork_info): New class.
8780         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8781
8782 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8783
8784         * valops.c (find_overload_match): Remove use of null_cleanup, and
8785         calls to do_cleanups.
8786
8787 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8788
8789         * compile/compile-cplus-types.c
8790         (compile_cplus_instance::decl_name): Handle changes to
8791         cp_func_name.
8792         * cp-support.c (cp_func_name): Update header comment, update
8793         return type.
8794         * cp-support.h (cp_func_name): Update return type in declaration.
8795         * valops.c (find_overload_match): Move temp_func local to top
8796         level of function and change its type.  Use temp_func to hold and
8797         delete temporary string obtained from cp_func_name.
8798
8799 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8800
8801         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8802         gdb::char_vector, remove cleanup, and update uses of `msg`.
8803
8804 2019-01-03  Jim Wilson  <jimw@sifive.com>
8805
8806         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8807
8808 2019-01-02  Tom Tromey  <tom@tromey.com>
8809
8810         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8811         (tdesc_parse_xml): Remove cleanups.
8812         * target-descriptions.h (make_cleanup_free_target_description):
8813         Don't declare.
8814         (target_desc_deleter): New struct.
8815         (target_desc_up): New typedef.
8816         * target-descriptions.c (target_desc_deleter::operator()): Rename
8817         from free_target_description.
8818         (make_cleanup_free_target_description): Remove.
8819
8820 2019-01-02  Tom Tromey  <tom@tromey.com>
8821
8822         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8823         constructor, destructor.
8824         (linespec_parser): Remove typedef.
8825         (~linespec_parser): Rename from linespec_parser_delete.
8826         (linespec_lex_to_end, linespec_complete_label)
8827         (linespec_complete): Update.
8828         (decode_line_full): Remove cleanups.
8829         (decode_line_1): Update.
8830
8831 2019-01-02  Tom Tromey  <tom@tromey.com>
8832
8833         * python/python-internal.h (inferior_to_inferior_object): Change
8834         return type.
8835         * python/py-exitedevent.c (create_exited_event_object): Update.
8836         * python/py-inferior.c (inferior_to_inferior_object): Return
8837         gdbpy_ref.
8838         (python_new_inferior, python_inferior_deleted)
8839         (thread_to_thread_object, delete_thread_object)
8840         (build_inferior_list, gdbpy_selected_inferior): Update.
8841         * python/py-infthread.c (create_thread_object): Update.  Also fail
8842         if inferior_to_inferior_object fails.
8843
8844 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8845
8846         * inferior.h (class inferior) <displaced_step_state>: New field.
8847         * infrun.h (struct displaced_step_state): Move here from
8848         infrun.c.  Initialize fields, add constructor.
8849         <inf>: Remove field.
8850         <reset>: New method.
8851         * infrun.c (struct displaced_step_inferior_state): Move to
8852         infrun.h.
8853         (displaced_step_inferior_states): Remove.
8854         (get_displaced_stepping_state): Adust.
8855         (displaced_step_in_progress_any_inferior): Adjust.
8856         (displaced_step_in_progress_thread): Adjust.
8857         (displaced_step_in_progress): Adjust.
8858         (add_displaced_stepping_state): Remove.
8859         (get_displaced_step_closure_by_addr): Adjust.
8860         (remove_displaced_stepping_state): Remove.
8861         (infrun_inferior_exit): Call displaced_step_state.reset.
8862         (use_displaced_stepping): Don't check for NULL.
8863         (displaced_step_prepare_throw): Call
8864         get_displaced_stepping_state.
8865         (displaced_step_fixup): Don't check for NULL.
8866         (prepare_for_detach): Don't check for NULL.
8867
8868 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8869
8870         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8871          in case of call that did not complete.
8872
8873 2019-01-02  Andrey Utkin  <autkin@undo.io>
8874
8875         * symfile.c (find_separate_debug_file): Fix search of debug files for
8876         remote debuggee.
8877
8878 2019-01-02  Tom Tromey  <tom@tromey.com>
8879
8880         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8881         indentation.
8882         * python/py-frame.c (frapy_older): Remove cast.
8883         (frapy_newer): Likewise.
8884         * python/py-breakpoint.c (local_setattro): Remove cast.
8885         * python/py-arch.c (archpy_name): Remove local variable.
8886         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8887
8888 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8889
8890         * unittests/basic_string_view/element_access/char/empty.cc:
8891         Fix year range in copyright header.
8892
8893 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8894
8895         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8896         Delete.
8897         <operator==>: Update with for removed field.
8898         <hash>: Likewise.
8899         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8900         <isa_features>: ...this.
8901         <abi_features>: New field.
8902         (riscv_isa_flen): Update comment.
8903         (riscv_abi_xlen): New declaration.
8904         (riscv_abi_flen): New declaration.
8905         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8906         isa_features.
8907         (riscv_abi_xlen): New function.
8908         (riscv_isa_flen): Update to get answer from isa_features.
8909         (riscv_abi_flen): New function.
8910         (riscv_has_fp_abi): Update to get answer from abi_features.
8911         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8912         xlen and flen.
8913         (riscv_call_info) <xlen, flen>: Update comment.
8914         (riscv_call_arg_struct): Remove invalid assertions
8915         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8916         is removed.
8917         (riscv_gdbarch_init): Gather isa features and abi features
8918         separately, ensure both match on the gdbarch when reusing an old
8919         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8920         a target with 64-bit float hardware.
8921
8922 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8923
8924         * source.c (search_command_helper): Stop reverse search
8925         when line 1 has been searched.
8926
8927 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8928
8929         * record-full.c (record_full_base_target::close): Rewrite
8930         record_full_core_buf_list free logic.
8931
8932 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8933
8934         * break-catch-syscall.c (print_one_catch_syscall): xfree
8935         the last text.
8936
8937 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8938
8939         * top.c (print_gdb_version): Update Copyright year in version
8940         message.
8941
8942 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8943
8944         Update copyright year range in all GDB files.
8945
8946 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8947
8948         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8949
8950 For older changes see ChangeLog-2018.
8951 \f
8952 Local Variables:
8953 mode: change-log
8954 left-margin: 8
8955 fill-column: 74
8956 version-control: never
8957 coding: utf-8
8958 End:
8959