gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
   4         variable.
   5
   6 2019-07-17  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui.c (tui_rl_other_window): Update.
   9         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
  10         superclass method first.  Always iterate over regs_content.
  11         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
  12         method.
  13         * tui/tui-win.c (tui_set_focus_command): Update.
  14
  15 2019-07-17  Tom Tromey  <tom@tromey.com>
  16
  17         * tui/tui-win.c (tui_set_focus_command): Rename from
  18         tui_set_focus.  Call tui_enable.
  19         (tui_set_focus_command): Remove.
  20
  21 2019-07-17  Tom Tromey  <tom@tromey.com>
  22
  23         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
  24         refresh_window.
  25         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
  26         touchwin.
  27         (tui_data_window::refresh_window): Call refresh_window on data
  28         items.  Always call superclass refresh_window.
  29         (tui_win_info::refresh): Remove.
  30         (tui_source_window_base::refresh_window): Update.
  31         (tui_refresh_all): Update.
  32         * tui/tui-layout.c (show_source_disasm_command): Remove call to
  33         refresh_window.
  34         (show_source_or_disasm_and_command): Likewise.
  35         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
  36         (struct tui_source_window_base) <refresh>: Likewise.
  37
  38 2019-07-17  Tom Tromey  <tom@tromey.com>
  39
  40         * tui/tui-winsource.c (tui_clear_source_content)
  41         (tui_show_source_content): Update.
  42         * tui/tui-source.c (tui_source_window::showing_source_p): Check
  43         whether content is empty.
  44         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
  45         Remove.
  46
  47 2019-07-17  Tom Tromey  <tom@tromey.com>
  48
  49         * tui/tui-winsource.c (tui_erase_source_content): Clear the
  50         window's contents.
  51         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
  52         * tui/tui-source.c (tui_set_source_content_nil): Remove.
  53
  54 2019-07-17  Tom Tromey  <tom@tromey.com>
  55
  56         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
  57         (struct tui_data_item_window): Update.
  58
  59 2019-07-17  Tom Tromey  <tom@tromey.com>
  60
  61         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
  62         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
  63         defines.
  64
  65 2019-07-17  Tom Tromey  <tom@tromey.com>
  66
  67         * tui/tui-winsource.h (tui_erase_source_content)
  68         (tui_clear_source_content): Remove "display_prompt" parameter.
  69         * tui/tui-winsource.c (tui_update_source_window_as_is)
  70         (tui_update_source_windows_with_addr): Update.
  71         (tui_clear_source_content): Remove "display_prompt" parameter.
  72         (tui_erase_source_content): Likewise.  Simplify.
  73         (tui_show_source_content): Update.
  74         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
  75         * tui/tui-stack.c (tui_show_frame_info): Update.
  76         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
  77         Remove defines.
  78
  79 2019-07-17  Tom Tromey  <tom@tromey.com>
  80
  81         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
  82         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
  83         parameter.
  84         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
  85         parameter.
  86
  87 2019-07-17  Tom Tromey  <tom@tromey.com>
  88
  89         * tui/tui-winsource.c (tui_clear_source_content)
  90         (tui_show_source_content, tui_show_exec_info_content)
  91         (tui_clear_exec_info_content): Update.
  92         * tui/tui-stack.c (tui_show_locator_content): Update.
  93         (tui_show_frame_info): Update.
  94         * tui/tui-source.h (tui_source_window): Don't declare.
  95         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
  96         from tui_source_is_displayed.
  97         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
  98         Remove field.
  99         (struct tui_source_window_base) <content_in_use>: New field.  Now
 100         bool.
 101         (struct tui_source_window) <showing_source_p>: New method.
 102         (TUI_SRC_WIN): Change cast.
 103         * tui/tui-data.c (tui_initialize_static_data): Update.
 104
 105 2019-07-17  Tom Tromey  <tom@tromey.com>
 106
 107         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 108         location_matches_p.
 109         * tui/tui-source.c (tui_source_window::location_matches_p): New
 110         method.
 111         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 112         method.
 113         * tui/tui-data.h (struct tui_source_window_base)
 114         <location_matches_p>: New method.
 115         (struct tui_source_window, struct tui_disasm_window)
 116         <location_matches_p>: Likewise.
 117
 118 2019-07-17  Tom Tromey  <tom@tromey.com>
 119
 120         * tui/tui-win.c (tui_set_win_height_command): Rename from
 121         tui_set_win_height.
 122         (tui_set_win_height_command): Remove.
 123
 124 2019-07-17  Tom Tromey  <tom@tromey.com>
 125
 126         * tui/tui-source.c (tui_source_window): New constructor.  Add
 127         observer.
 128         (~tui_source_window): New destructor.
 129         (tui_source_window::style_changed): New method.
 130         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 131         (tui_attach_detach_observers): Update.
 132         * tui/tui-data.h (struct tui_source_window): Make constructor not
 133         inline.  Add destructor.
 134         (struct tui_source_window) <style_changed>: New method.
 135         <m_observable>: New member.
 136
 137 2019-07-17  Tom Tromey  <tom@tromey.com>
 138
 139         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 140         * tui/tui-win.c (tui_resize_all): Fix typo.
 141
 142 2019-07-17  Tom Tromey  <tom@tromey.com>
 143
 144         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 145         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 146         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 147         * tui/tui-win.c (window_name_completer): Use foreach.
 148         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 149         (update_tab_width): Likewise.
 150         * tui/tui-layout.c (show_layout): Update.
 151         * tui/tui-data.h (class tui_window_iterator): New.
 152         (struct all_tui_windows): New.
 153         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 154
 155 2019-07-17  Tom Tromey  <tom@tromey.com>
 156
 157         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 158         parameter.  Don't reference globals.
 159         (tui_reg_command): Update.
 160
 161 2019-07-17  Tom Tromey  <tom@tromey.com>
 162
 163         * tui/tui-regs.c (tui_show_registers): Simplify.
 164
 165 2019-07-17  Tom Tromey  <tom@tromey.com>
 166
 167         * tui/tui-regs.c (tui_show_registers): Update.
 168         (tui_show_register_group): Add win_info parameter.
 169
 170 2019-07-17  Tom Tromey  <tom@tromey.com>
 171
 172         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 173         Rename from tui_display_reg_element_at_line.
 174         (tui_data_window::display_registers_from_line): Update.
 175         * tui/tui-data.h (struct tui_data_window)
 176         <display_reg_element_at_line>: New method.
 177
 178 2019-07-17  Tom Tromey  <tom@tromey.com>
 179
 180         * tui/tui-regs.h (tui_display_registers_from)
 181         (tui_display_registers_from_line): Don't declare.
 182         * tui/tui-windata.c (tui_data_window::display_all_data)
 183         (tui_data_window::refresh_all)
 184         (tui_data_window::do_scroll_vertical): Update.
 185         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 186         from tui_display_registers_from.
 187         (tui_display_reg_element_at_line): Update.
 188         (tui_data_window::display_registers_from_line): Rename from
 189         tui_display_registers_from_line.
 190         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 191         display_registers_from_line>: New methods.
 192
 193 2019-07-17  Tom Tromey  <tom@tromey.com>
 194
 195         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 196         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 197         from tui_erase_data_content.
 198         (tui_data_window::display_all_data)
 199         (tui_data_window::refresh_all)
 200         (tui_data_window::do_scroll_vertical): Update.
 201         * tui/tui-regs.c (tui_show_registers): Update.
 202         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 203         New method.
 204
 205 2019-07-17  Tom Tromey  <tom@tromey.com>
 206
 207         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 208         declare.
 209         * tui/tui-windata.c
 210         (tui_data_window::delete_data_content_windows): Rename from
 211         tui_delete_data_content_windows.
 212         (tui_data_window::display_all_data)
 213         (tui_data_window::do_scroll_vertical): Update.
 214         * tui/tui-data.h (struct tui_data_window)
 215         <delete_data_content_windows>: New method.
 216
 217 2019-07-17  Tom Tromey  <tom@tromey.com>
 218
 219         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 220         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 221
 222 2019-07-17  Tom Tromey  <tom@tromey.com>
 223
 224         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 225         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 226         from tui_display_all_data.
 227         * tui/tui-win.c
 228         (tui_data_window::do_make_visible_with_new_height): Update.
 229         * tui/tui-regs.c (tui_show_registers): Update.
 230         * tui/tui-layout.c (tui_set_layout): Update.
 231         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 232         method.
 233
 234 2019-07-17  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 237         * tui/tui-windata.c (tui_display_data_from): Remove.
 238         (tui_data_window::refresh_all): Update.
 239
 240 2019-07-17  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 243         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 244         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 245         tui_display_registers_from_line.
 246         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 247         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 248         "force_display" parameter.
 249
 250 2019-07-17  Tom Tromey  <tom@tromey.com>
 251
 252         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 253         declare.
 254         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 255         Rename from tui_first_reg_element_no_inline.
 256         (tui_display_reg_element_at_line)
 257         (tui_display_registers_from_line): Update.
 258         * tui/tui-data.h (struct tui_data_window)
 259         <first_reg_element_no_inline>: New method.
 260
 261 2019-07-17  Tom Tromey  <tom@tromey.com>
 262
 263         * tui/tui-windata.c (tui_display_data_from)
 264         (tui_data_window::do_scroll_vertical): Update.
 265         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 266         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 267         Rename from tui_line_from_reg_element_no.
 268         (tui_display_registers_from_line): Update.
 269         * tui/tui-data.h (struct tui_data_window)
 270         <line_from_reg_element_no>: New method.
 271
 272 2019-07-17  Tom Tromey  <tom@tromey.com>
 273
 274         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 275         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 276         tui_last_regs_line_no.
 277         (tui_display_reg_element_at_line)
 278         (tui_display_registers_from_line): Update.
 279         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 280         method.
 281
 282 2019-07-17  Tom Tromey  <tom@tromey.com>
 283
 284         PR tui/24722:
 285         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 286         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 287         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 288         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 289         (tui_update_breakpoint_info): Likewise.
 290         * tui/tui-hooks.c (tui_event_create_breakpoint)
 291         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 292         Update.
 293
 294 2019-07-17  Tom Tromey  <tom@tromey.com>
 295
 296         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 297
 298 2019-07-17  Tom Tromey  <tom@tromey.com>
 299
 300         * tui/tui-winsource.c (tui_update_source_window_as_is)
 301         (tui_update_source_windows_with_addr): Update.
 302         * tui/tui-source.h (tui_set_source_content)
 303         (tui_show_symtab_source): Add "win_info" parameter.
 304         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 305         parameter.
 306         (tui_show_symtab_source): Likewise.
 307
 308 2019-07-17  Tom Tromey  <tom@tromey.com>
 309
 310         * tui/tui-wingeneral.c
 311         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 312
 313 2019-07-17  Tom Tromey  <tom@tromey.com>
 314
 315         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 316         (struct tui_cmd_window) <can_scroll>: New method.
 317         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 318         method.
 319
 320 2019-07-17  Tom Tromey  <tromey@adacore.com>
 321
 322         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 323         do_field_signed>: Rename.  Change type of "value".
 324         * ui-out.c (ui_out::field_signed): Rename from field_int.
 325         Change type of "value".
 326         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 327         type of "value".
 328         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 329         do_field_int.  Change type of "value".
 330         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 331         do_field_int.  Change type of "value".
 332         * tracepoint.c (trace_status_mi, tfind_1)
 333         (print_one_static_tracepoint_marker): Update.
 334         * thread.c (print_thread_info_1, print_selected_thread_frame):
 335         Update.
 336         * stack.c (print_frame, print_frame_info): Update.
 337         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 338         Update.
 339         * source.c (print_source_lines_base): Update.
 340         * skip.c (info_skip_command): Update.
 341         * record-btrace.c (btrace_ui_out_decode_error)
 342         (btrace_call_history_src_line): Update.
 343         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 344         Update.
 345         * progspace.c (print_program_space): Update.
 346         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 347         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 348         do_field_int.  Change type of "value".
 349         * mi/mi-out.c (mi_ui_out::do_table_begin)
 350         (mi_ui_out::do_table_header): Update.
 351         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 352         type of "value".
 353         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 354         (mi_cmd_data_list_changed_registers, output_register)
 355         (mi_cmd_data_read_memory, mi_load_progress)
 356         (mi_cmd_trace_frame_collected): Update.
 357         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 358         Update.
 359         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 360         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 361         (mi_cmd_var_list_children, varobj_update_one): Update.
 362         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 363         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 364         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 365         * inferior.c (print_inferior): Update.
 366         * gdb_bfd.c (print_one_bfd): Update.
 367         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 368         Update.
 369         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 370         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 371         do_field_int.  Change type of "value".
 372         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 373         do_field_int.  Change type of "value".
 374         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 375         (print_one_breakpoint_location, print_it_catch_fork)
 376         (print_one_catch_fork, print_it_catch_vfork)
 377         (print_one_catch_vfork, print_it_catch_solib)
 378         (print_it_catch_exec, print_it_ranged_breakpoint)
 379         (print_mention_watchpoint, print_mention_masked_watchpoint)
 380         (bkpt_print_it, update_static_tracepoint): Update.
 381         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 382         * break-catch-syscall.c (print_it_catch_syscall): Update.
 383         * ada-tasks.c (print_ada_task_info): Update.
 384         * ada-lang.c (print_it_exception, print_mention_exception):
 385         Update.
 386
 387 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 388
 389         PR breakpoints/24541
 390         * gdbarch.c: Regenerate.
 391         * gdbarch.h: Regenerate.
 392         * gdbarch.sh: Adjust return type and parameter types for
 393         'stap_adjust_register'.
 394         (i386_stap_adjust_register): Adjust signature and return new
 395         register name.
 396         * stap-probe.c (stap_parse_register_operand): Adjust use of
 397         'gdbarch_stap_adjust_register'.
 398
 399 2019-07-17  Tom Tromey  <tromey@adacore.com>
 400
 401         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 402         declare VEC.
 403         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 404         std::vector.
 405         (struct s390_process_info): Add initializers.
 406         (s390_add_process): Use new.
 407         (s390_linux_nat_target::low_forget_process): Use delete.
 408         (s390_linux_nat_target::low_new_fork)
 409         (s390_linux_nat_target::stopped_by_watchpoint)
 410         (s390_linux_nat_target::low_prepare_to_resume)
 411         (s390_linux_nat_target::insert_watchpoint)
 412         (s390_linux_nat_target::insert_hw_breakpoint)
 413         (s390_linux_nat_target::remove_watchpoint)
 414         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 415
 416 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 417
 418         * aarch64-fbsd-nat.c: Include regcache.h.
 419         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 420         argument.
 421         (aarch64_fbsd_nat_target::fetch_registers)
 422         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 423         variable.
 424         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 425
 426 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 427
 428         * fbsd-nat.c: Include gdbarch.h.
 429
 430 2019-07-15  Tom Tromey  <tromey@adacore.com>
 431
 432         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 433
 434 2019-07-15  Tom Tromey  <tromey@adacore.com>
 435
 436         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 437         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 438         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 439         * cli-out.c (cli_ui_out::do_field_int): New method.
 440         * ui-out.c (ui_out::field_unsigned): New method.
 441         * symfile.c (generic_load): Use field_unsigned.
 442         (print_transfer_performance): Likewise.
 443         * record-btrace.c (ui_out_field_uint): Remove.
 444         (btrace_call_history_insn_range, btrace_call_history): Use
 445         field_unsigned.
 446         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 447         field_unsigned.
 448         * ui-out.h (class ui_out) <field_unsigned>: New method.
 449         <do_field_unsigned>: Likewise.
 450
 451 2019-07-15  Tom Tromey  <tromey@adacore.com>
 452
 453         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 454         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 455         * target.c (flash_erase_command): Use field_string.
 456         * infrun.c (print_signal_received_reason): Use field_string.
 457         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 458         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 459         field_string.
 460         * ada-tasks.c (print_ada_task_info): Use field_string.
 461
 462 2019-07-15  Tom Tromey  <tromey@adacore.com>
 463
 464         * target.c (flash_erase_command): Use field_core_addr.
 465         * symfile.c (generic_load): Use field_core_addr.
 466         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 467         Use field_core_addr.
 468         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 469         field_core_addr.
 470
 471 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 472
 473         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 474         value if its desired type is smaller than a CORE_ADDR and signed.
 475
 476 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 477
 478         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 479         of changes to field names, and use new is_reference field to
 480         decide if a property is a reference or not.
 481         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 482         field.
 483         (struct dwarf2_property_baton): Update header comment, rename
 484         'referenced_type' to 'property_type' and update comments.
 485         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 486         default property type, store in property baton, update to take
 487         accound of renamed field.
 488         (read_func_scope): Update call to attr_to_dynamic_prop.
 489         (read_array_type): Likewise.
 490         (dwarf2_per_cu_addr_sized_int_type): New function.
 491         (read_subrange_index_type): Move type finding code to
 492         dwarf2_per_cu_addr_sized_int_type.
 493         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 494         (dwarf2_per_cu_addr_type): New function.
 495         (set_die_type): Update calls to attr_to_dynamic_prop.
 496
 497 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 498
 499         * dwarf2read.c (read_subrange_index_type): New function.
 500         (read_subrange_type): Move code into new function and call it.
 501         * gdbtypes.c (create_range_type): Add some asserts.
 502
 503 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 504
 505         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 506         update return statements.
 507         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 508         declaration, and update comment to match.
 509         * gdbtypes.c (resolve_dynamic_array): Update call to
 510         dwarf2_evaluate_property to match new return type.
 511
 512 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 513
 514         * valarith.c (value_subscripted_rvalue): Change lowerbound
 515         parameter type from int to LONGEST.
 516         * value.h (value_subscripted_rvalue): Likewise in declaration.
 517
 518 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 519
 520         * cli/cli-utils.c (info_print_command_completer): New function.
 521         * cli/cli-utils.h: Add 'completer.h' include, and forward
 522         declaration for 'struct cmd_list_element'.
 523         (info_print_command_completer): Declare.
 524         * stack.c (_initialize_stack): Add completer for 'info locals' and
 525         'info args'.
 526         * symtab.c (_initialize_symtab): Add completer for 'info
 527         variables' and 'info functions'.
 528         * NEWS: Mention completion for additional info commands.
 529
 530 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 531
 532         * cli/cli-utils.c (extract_info_print_args): Delete.
 533         (extract_arg_maybe_quoted): Delete.
 534         (info_print_options_defs): New variable.
 535         (make_info_print_options_def_group): New function.
 536         (extract_info_print_options): Define new function.
 537         * cli/cli-utils.h (extract_info_print_args): Delete.
 538         (struct info_print_options): New structure.
 539         (extract_info_print_options): Declare new function.
 540         * stack.c (info_locals_command): Update to use new
 541         extract_info_print_options, also add a header comment.
 542         (info_args_command): Likewise.
 543         * symtab.c (info_variables_command): Likewise.
 544         (info_functions_command): Likewise.
 545
 546 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 547
 548         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 549         to extract string arguments.
 550         * common/common-utils.c (extract_string_maybe_quoted): New function.
 551         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 552
 553 2019-07-11  Tom Tromey  <tromey@adacore.com>
 554
 555         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 556         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 557         * top.h (gdbinit): Don't declare.
 558         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 559         into...
 560         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 561         * top.c (gdb_init): Don't call init_cli_cmds.
 562         (gdbinit): Remove.
 563         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 564
 565 2019-07-11  Tom Tromey  <tromey@adacore.com>
 566
 567         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 568         after it has been moved.
 569
 570 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 571
 572         * valops.c (value_must_coerce_to_target): Change return type to
 573         bool.
 574         * value.h (value_must_coerce_to_target): Likewise.
 575
 576 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 577
 578         * breakpoint.c (is_hardware_watchpoint): Remove
 579         forward-declaration.
 580         (is_masked_watchpoint): Change return type to bool.
 581         (is_tracepoint): Likewise.
 582         (is_breakpoint): Likewise.
 583         (is_hardware_watchpoint): Likewise.
 584         (is_watchpoint): Likewise.
 585         (is_no_memory_software_watchpoint): Likewise.
 586         (is_catchpoint): Likewise.
 587         (breakpoint_1): Make FILTER parameter's return type bool.
 588         is_masked_watchpoint): Change return type to bool.
 589         (save_breakpoints): Make FILTER parameter's return type bool.
 590         * breakpoint.h (is_breakpoint): Change return type to bool.
 591         (is_watchpoint): Likewise.
 592         (is_catchpoint): Likewise.
 593         (is_tracepoint): Likewise.
 594
 595 2019-07-10  Tom Tromey  <tom@tromey.com>
 596
 597         * defs.h: Don't include gdbarch.h.
 598         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 599         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 600         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 601         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 602         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 603         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 604         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 605         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 606         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 607         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 608         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 609         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 610         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 611         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 612         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 613         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 614         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 615         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 616         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 617         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 618         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 619         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 620         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 621         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 622         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 623         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 624         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 625
 626 2019-07-10  Tom Tromey  <tromey@adacore.com>
 627
 628         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 629         * breakpoint.c (init_ada_exception_breakpoint): Register as
 630         bp_catchpoint.
 631         (print_one_breakpoint_location, print_one_breakpoint): Use
 632         is_ada_exception_catchpoint.
 633         * ada-lang.c (class ada_catchpoint_location): Pass
 634         bp_loc_software_breakpoint to bp_location constructor.
 635         (is_ada_exception_catchpoint): New function.
 636
 637 2019-07-10  Tom Tromey  <tromey@adacore.com>
 638
 639         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 640         VEC.
 641         (struct arm_exidx_entry): New method operator<.
 642         (struct arm_exidx_data) <section_maps>: Change type.
 643         (arm_exidx_data_free): Remove.
 644         (arm_exidx_data_key): Change type.  Move lower.
 645         (arm_exidx_new_objfile): Update.
 646         (arm_compare_exidx_entries): Remove.
 647         (arm_find_exidx_entry, _initialize_arm_tdep)
 648
 649 2019-07-10  Tom Tromey  <tromey@adacore.com>
 650
 651         * solib-spu.c (ocl_program_data_key): Change type.
 652         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 653         Update.
 654
 655 2019-07-10  Tom Tromey  <tromey@adacore.com>
 656
 657         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 658         (struct solib_aix_inferior_data) <library_list>: Change type.
 659         (solib_aix_inferior_data_handle): Change type.
 660         (get_solib_aix_inferior_data): Update.
 661         (solib_aix_free_library_list): Remove.
 662         (library_list_start_library): Update.
 663         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 664         return type.
 665         (solib_aix_get_library_list)
 666         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 667         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 668
 669 2019-07-10  Tom Tromey  <tromey@adacore.com>
 670
 671         * solib-dsbt.c (struct dsbt_info): Add initializers.
 672         (solib_dsbt_pspace_data): Change type.
 673         (dsbt_pspace_data_cleanup): Remove.
 674         (get_dsbt_info, _initialize_dsbt_solib): Update.
 675
 676 2019-07-10  Tom Tromey  <tromey@adacore.com>
 677
 678         * spu-tdep.c (spu_overlay_data): Change type.
 679         (spu_get_overlay_table, spu_overlay_new_objfile)
 680         (_initialize_spu_tdep): Update.
 681
 682 2019-07-10  Tom Tromey  <tromey@adacore.com>
 683
 684         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 685         destructor.
 686         (dbx_objfile_data_key): Change type and declare later.
 687         (DBX_SYMFILE_INFO): Rewrite.
 688         * dbxread.c (dbx_objfile_data_key): Change type.
 689         (dbx_symfile_init): Update.
 690         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 691         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 692         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 693
 694 2019-07-10  Tom Tromey  <tromey@adacore.com>
 695
 696         * jit.c (jit_program_space_key): Change type.  Move lower.
 697         (get_jit_program_space_data): Update.
 698         (jit_program_space_data_cleanup): Remove.
 699         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 700         Update.
 701         (struct jit_program_space_data): Add initializers.
 702
 703 2019-07-10  Tom Tromey  <tromey@adacore.com>
 704
 705         * solib-darwin.c (struct darwin_info): Add initializers.
 706         (solib_darwin_pspace_data): Change type.
 707         (darwin_pspace_data_cleanup): Remove.
 708         (get_darwin_info, _initialize_darwin_solib): Update.
 709
 710 2019-07-10  Tom Tromey  <tromey@adacore.com>
 711
 712         * remote-sim.c (struct sim_inferior_data): Add initializers,
 713         constructor, and destructor.
 714         (sim_inferior_data_key): Change type.  Move lower.
 715         (check_for_duplicate_sim_descriptor): Update.
 716         (get_sim_inferior_data): Use new.  Update.
 717         (~sim_inferior_data_cleanup): Rename from
 718         sim_inferior_data_cleanup.  Simplify.
 719         (gdbsim_close_inferior, simulator_command)
 720         (sim_command_completer, _initialize_remote_sim): Update.
 721         (next_pid, INITIAL_PID): Move earlier.
 722
 723 2019-07-10  Tom Tromey  <tromey@adacore.com>
 724
 725         * python/python-internal.h (create_thread_object): Return
 726         gdbpy_ref.
 727         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 728         * python/py-inferior.c (struct threadlist_entry): Add
 729         constructor.
 730         <thread_obj>: Now a gdbpy_ref.
 731         (thread_to_thread_object): Update.
 732         (add_thread_object): Use new.
 733         (delete_thread_object): Use delete.
 734         (infpy_threads): Update.
 735         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 736         GIL.
 737
 738 2019-07-10  Tom Tromey  <tromey@adacore.com>
 739
 740         * valops.c (value_cast): Specialize error message for Ada.
 741
 742 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 743
 744         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 745
 746 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 747
 748         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 749         bpstat_should_step): Return bool, adjust comments.
 750         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 751         bpstat_should_step): Likewise.
 752
 753 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 754
 755         * features/Makefile: Use feature target descriptions for Arm.
 756         * features/arm/arm-core.c: Generate new file.
 757         * features/arm/arm-fpa.c: Likewise.
 758         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 759         * features/arm/arm-m-profile.c: Likewise.
 760         * features/arm/arm-vfpv2.c: Likewise.
 761         * features/arm/arm-vfpv3.c: Likewise.
 762         * features/arm/xscale-iwmmxt.c: Likewise.
 763         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 764
 765 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 766
 767         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 768         ptrace earlier.
 769
 770 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 771
 772         * features/aarch64-pauth.c: Regenerate.
 773
 774 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 775
 776         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 777         bool.
 778         (bpstat_what): Use false instead of 0.
 779
 780 2019-07-09  Pedro Alves  <palves@redhat.com>
 781
 782         * break-catch-throw.c (is_exception_catchpoint): New.
 783         * breakpoint.c (print_one_breakpoint_location): New parameter
 784         'raw_loc'.  Handle it.  Use
 785         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 786         looking at the breakpoint's type.
 787         (print_one_breakpoint): If handling "maint info breakpoints", also
 788         print locations of exception catchpoints.
 789         * breakpoint.h (is_exception_catchpoint): Declare.
 790
 791 2019-07-09  Pedro Alves  <palves@redhat.com>
 792
 793         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 794         "addr" field.
 795         (allocate_location_exception_catchpoint): New.
 796         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 797         (initialize_throw_catchpoint_ops): Install
 798         allocate_location_exception_catchpoint as allocate_location
 799         method.
 800         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 801         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 802         bp_loc_other.
 803         (breakpoint_address_is_meaningful): Delete.
 804         (bl_address_is_meaningful): New.
 805         (breakpoint_locations_match): Adjust comment.
 806         (bp_location_from_bp_type): New, factored out of...
 807         (bp_location::bp_location(breakpoint *)): ... this.
 808         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 809         factored out of...
 810         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 811         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 812         breakpoint_address_is_meaningful.
 813         (bp_locations_compare): Adjust comment.
 814         (update_global_location_list): Use bl_address_is_meaningful
 815         instead of breakpoint_address_is_meaningful.
 816         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 817         explicit.
 818         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 819         * python/py-breakpoint.c (bppy_get_location): No longer check
 820         whether location is null.
 821
 822 2019-07-09  Pedro Alves  <palves@redhat.com>
 823
 824         PR c++/15468
 825         * breakpoint.c (print_one_breakpoint_location): Remove
 826         single-location assert.
 827
 828 2019-07-09  Tom Tromey  <tom@tromey.com>
 829
 830         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 831         * configure: Rebuild.
 832         * configure.ac: Change common to gdbsupport.
 833         * gdbsupport: Rename from common.
 834         * acinclude.m4: Change common to gdbsupport.
 835         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 836         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 837         gdbsupport.
 838         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 839         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 840         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 841         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 842         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 843         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 844         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 845         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 846         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 847         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 848         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 849         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 850         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 851         coff-pe-read.c, command.h, compile/compile-c-support.c,
 852         compile/compile-c.h, compile/compile-cplus-symbols.c,
 853         compile/compile-cplus-types.c, compile/compile-cplus.h,
 854         compile/compile-loc2c.c, compile/compile.c, completer.c,
 855         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 856         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 857         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 858         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 859         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 860         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 861         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 862         features/aarch64-core.c, features/aarch64-fpu.c,
 863         features/aarch64-pauth.c, features/aarch64-sve.c,
 864         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 865         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 866         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 867         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 868         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 869         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 870         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 871         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 872         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 873         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 874         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 875         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 876         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 877         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 878         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 879         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 880         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 881         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 882         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 883         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 884         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 885         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 886         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 887         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 888         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 889         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 890         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 891         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 892         minsyms.c, mips-linux-tdep.c, namespace.h,
 893         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 894         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 895         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 896         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 897         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 898         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 899         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 900         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 901         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 902         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 903         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 904         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 905         procfs.c, producer.c, progspace.h, psymtab.h,
 906         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 907         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 908         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 909         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 910         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 911         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 912         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 913         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 914         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 915         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 916         target-memory.c, target.c, target.h, target/waitstatus.c,
 917         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 918         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 919         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 920         unittests/array-view-selftests.c,
 921         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 922         unittests/common-utils-selftests.c,
 923         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 924         unittests/format_pieces-selftests.c,
 925         unittests/function-view-selftests.c,
 926         unittests/lookup_name_info-selftests.c,
 927         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 928         unittests/mkdir-recursive-selftests.c,
 929         unittests/observable-selftests.c,
 930         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 931         unittests/parse-connection-spec-selftests.c,
 932         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 933         unittests/scoped_fd-selftests.c,
 934         unittests/scoped_mmap-selftests.c,
 935         unittests/scoped_restore-selftests.c,
 936         unittests/string_view-selftests.c, unittests/style-selftests.c,
 937         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 938         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 939         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 940         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 941         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 942         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 943
 944 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 945
 946         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 947         bool value.
 948         (decode_digits_ordinary): Set explicit_line field in sal.
 949         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 950         symtab_and_line that was set on an explicit line number in
 951         assembler code.  Do always update the recorded symtab and line if
 952         we do skip the prologue.
 953
 954 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 955
 956         * breakpoint.c (set_breakpoint_location_function): Remove
 957         explicit_loc parameter.
 958         (momentary_breakpoint_from_master): Update call to
 959         set_breakpoint_location_function.
 960         (add_location_to_breakpoint): Likewise.
 961
 962 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 963
 964         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 965         required features based on default bfd type when no specific bfd
 966         is present.
 967
 968 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 969
 970         * NEWS: Mention that GDB printf and eval commands can now print
 971         C-style and Ada-style convenience var strings without
 972         calling the inferior.
 973         * printcmd.c (printf_c_string): Locally print GDB internal var
 974         instead of transiting via the inferior.
 975         (printf_wide_c_string): Likewise.
 976
 977 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 978
 979         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 980
 981 2019-07-04  Tom Tromey  <tom@tromey.com>
 982
 983         PR tui/24724:
 984         * tui/tui-winsource.c (tui_clear_source_content): Update.
 985         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 986         (tui_update_breakpoint_info): Update.
 987         (tui_set_exec_info_content): Update.
 988         * tui/tui-source.c (tui_set_source_content_nil): Update.
 989         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 990         has_break.
 991         * tui/tui-data.h (enum tui_bp_flag): New.
 992         (tui_bp_flags): New enum flags type.
 993         (struct tui_source_element) <break_mode>: Change type.  Rename
 994         from has_break.
 995         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 996         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 997         constants.
 998         * tui/tui-winsource.h: Fix comment.
 999
1000 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1001
1002         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1003         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1004         (store_fpregs_to_thread)
1005         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1006         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1007         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1008         (IWMMXT_REGS_SIZE): Add define.
1009         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1010         (fetch_vfp_regs, store_vfp_regs)
1011         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1012         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1013
1014 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1015
1016         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1017         defines.
1018         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1019         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1020         (ARM_INT_REGISTER_SIZE): ...to this.
1021         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1022         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1023         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1024         (arm_linux_collect_gregset, supply_nwfpe_register)
1025         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1026         defines.
1027         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1028         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1029         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1030         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1031         (arm_return_in_memory, arm_store_return_value)
1032         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1033         (arm_record_ld_st_multiple): Likewise.
1034         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1035         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1036
1037 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1038
1039         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1040         AARCH64_DISPLACED_MODIFIED_INSNS.
1041         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1042         (aarch64_displaced_step_copy_insn): Likewise.
1043         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1044         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1045         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1046         ARM_DISPLACED_MODIFIED_INSNS.
1047         * arm-tdep.c (arm_gdbarch_init): Likewise.
1048         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1049         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1050         (struct arm_displaced_step_closure): Use
1051         ARM_DISPLACED_MODIFIED_INSNS.
1052
1053 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1054
1055         * features/Makefile: Remove unused xml files.
1056         * features/aarch64.xml: Remove.
1057         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1058         * features/i386/amd64-avx-avx512.xml: Remove.
1059         * features/i386/amd64-avx-linux.xml: Remove.
1060         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1061         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1062         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1063         * features/i386/amd64-avx-mpx.xml: Remove.
1064         * features/i386/amd64-avx.xml: Remove.
1065         * features/i386/amd64-linux.xml: Remove.
1066         * features/i386/amd64-mpx-linux.xml: Remove.
1067         * features/i386/amd64-mpx.xml: Remove.
1068         * features/i386/amd64.xml: Remove.
1069         * features/i386/i386-avx-avx512-linux.xml: Remove.
1070         * features/i386/i386-avx-avx512.xml: Remove.
1071         * features/i386/i386-avx-linux.xml: Remove.
1072         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1073         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1074         * features/i386/i386-avx-mpx-linux.xml: Remove.
1075         * features/i386/i386-avx-mpx.xml: Remove.
1076         * features/i386/i386-avx.xml: Remove.
1077         * features/i386/i386-linux.xml: Remove.
1078         * features/i386/i386-mmx-linux.xml: Remove.
1079         * features/i386/i386-mmx.xml: Remove.
1080         * features/i386/i386-mpx-linux.xml: Remove.
1081         * features/i386/i386-mpx.xml: Remove.
1082         * features/i386/i386.xml: Remove.
1083         * features/i386/x32-avx-avx512-linux.xml: Remove.
1084         * features/i386/x32-avx-linux.xml: Remove.
1085         * features/i386/x32-linux.xml: Remove.
1086
1087 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1088
1089         * regformats/aarch64.dat: Remove.
1090         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1091         * regformats/i386/amd64-avx-linux.dat: Remove.
1092         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1093         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1094         * regformats/i386/amd64-linux.dat: Remove.
1095         * regformats/i386/amd64-mpx-linux.dat: Remove.
1096         * regformats/i386/amd64.dat: Remove.
1097         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1098         * regformats/i386/i386-avx-linux.dat: Remove.
1099         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1100         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1101         * regformats/i386/i386-linux.dat: Remove.
1102         * regformats/i386/i386-mmx-linux.dat: Remove.
1103         * regformats/i386/i386-mpx-linux.dat: Remove.
1104         * regformats/i386/i386.dat: Remove.
1105         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1106         * regformats/i386/x32-avx-linux.dat: Remove.
1107         * regformats/i386/x32-linux.dat: Remove.
1108
1109 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1110
1111         * aarch64-tdep.c: Remove xml self tests.
1112         * amd64-linux-tdep.c: Likewise.
1113         * amd64-tdep.c: Likewise.
1114         * i386-linux-tdep.c: Likewise.
1115         * i386-tdep.c: Likewise.
1116
1117 2019-07-03  Pedro Alves  <palves@redhat.com>
1118
1119         PR cli/24732
1120         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1121         (pipe_cmd_option_defs): New.
1122         (make_pipe_cmd_options_def_group): New.
1123         (pipe_command): Use gdb::option::process_options.
1124         (pipe_command_completer): New function.
1125         (_initialize_cli_cmds): Install completer for "pipe" command.
1126
1127 2019-07-03  Pedro Alves  <palves@redhat.com>
1128
1129         * cli/cli-option.c (union option_value) <string>: New field.
1130         (struct option_def_and_value): Add ctor, move ctor, dtor and
1131         use DISABLE_COPY_AND_ASSIGN.
1132         (option_def_and_value::clear_value): New.
1133         (parse_option, save_option_value_in_ctx, get_val_type_str)
1134         (add_setshow_cmds_for_options): Handle var_string.
1135         * cli-option.h (union option_def::var_address) <string>: New
1136         field.
1137         (struct string_option_def): New.
1138         * maint-test-options.c (struct test_options_opts): Add default
1139         ctor and use DISABLE_COPY_AND_ASSIGN.
1140         <string_opt>: New field.
1141         (test_options_opts::~test_options_opts): New.
1142         (test_options_opts::dump): Also dump "-string".
1143         (test_options_option_defs): Install "string.
1144
1145 2019-07-03  Pedro Alves  <palves@redhat.com>
1146
1147         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1148         option_value with a null enumeration.
1149         (complete_options): Save the option values in the context.
1150         (save_option_value_in_ctx): New, factored out from ...
1151         (process_options): ... here.
1152         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1153         of the function.
1154         * maint-test-options.c (test_options_opts::dump): New, factored
1155         out from ...
1156         (maintenance_test_options_command_mode): ... here.
1157         (maintenance_test_options_command_completion_result): Delete.
1158         (maintenance_test_options_command_completion_text): Update
1159         comment.
1160         (maintenance_show_test_options_completion_result): Change
1161         prototype.  Just print
1162         maintenance_test_options_command_completion_text.
1163         (save_completion_result): New.
1164         (maintenance_test_options_completer_mode): Pass options context to
1165         complete_options, and then save a dump.
1166         (_initialize_maint_test_options): Use add_cmd to install "maint
1167         show test-options-completion-result".
1168
1169 2019-07-03  Pedro Alves  <palves@redhat.com>
1170
1171         * NEWS (New commands): Mention "with" and "maint with".
1172         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1173         (with_command, with_command_completer): New.
1174         (pipe_command): Adjust to new repeat_previous
1175         interface.
1176         (_initialize_cli_cmds): Install the "with" command and its "w"
1177         alias.
1178         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1179         declarations.
1180         * cli/cli-setshow.c (parse_cli_var_uinteger)
1181         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1182         argument strings for all var_types.
1183         (get_setshow_command_value_string): New, factored out from ...
1184         (do_show_command): ... this.
1185         * cli/cli-setshow.h: Include <string>.
1186         (get_setshow_command_value_string): Declare.
1187         * command.h (repeat_previous): Now returns const char *.  Adjust
1188         comment.
1189         * maint.c: Include "cli/cli-cmds.h".
1190         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1191         (_initialize_maint_cmds): Register the "maintenance with" command.
1192         * top.c (repeat_previous): Move bits from pipe_command here:
1193         Return the saved command line, if any; error out if there's no
1194         command to relaunch.
1195
1196 2019-07-03  Pedro Alves  <palves@redhat.com>
1197
1198         * NEWS (New commands): Mention "maint set/show test-settings"
1199         instead of "maint test-settings".
1200         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1201         (maintenance_test_settings_set_list): Rename to ...
1202         (maintenance_set_test_settings_list): ... this.
1203         (maintenance_test_settings_show_list): Rename to  ...
1204         (maintenance_show_test_settings_list): ... this.
1205         (maintenance_test_settings_cmd): Delete.
1206         (maintenance_test_settings_set_cmd): ...
1207         (maintenance_set_test_settings_cmd): ... this.
1208         (maintenance_test_settings_show_cmd): ...
1209         (maintenance_show_test_settings_cmd): ... this.
1210         (maintenance_test_settings_show_value_cmd):
1211         (maintenance_show_test_settings_value_cmd): ... this.
1212         (_initialize_maint_test_settings): No longer install the "maint
1213         test-settings" prefix command.  Rename "maint test-settings set"
1214         to "maint set test-settings", and "maint test-settings show" to
1215         "maint show test-settings".  Adjust all subcommands.
1216
1217 2019-07-03  Pedro Alves  <palves@redhat.com>
1218
1219         * maint-test-settings.c: Fix file's intro comment.  Replace all
1220         references to "test-options" with references to "test-settings",
1221         in comments.
1222
1223 2019-07-03  Pedro Alves  <palves@redhat.com>
1224
1225         * maint-test-settings.c (maintenance_test_settings_xxx)
1226         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1227         New.
1228         (maintenance_test_settings_enums): Use them.
1229         (maintenance_test_settings_enum): Default to
1230         maintenance_test_settings_xxx.
1231         (_initialize_maint_test_settings): Initialize
1232         MAINTENANCE_TEST_SETTINGS_FILENAME.
1233
1234 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1235
1236         * breakpoint.h (remove_breakpoints_inf): Change return type to
1237         void, move function documentation here.
1238         * breakpoint.c (remove_breakpoints_inf): Change return type to
1239         void, move function documentation to header.
1240
1241 2019-07-02  Pedro Alves  <palves@redhat.com>
1242
1243         * NEWS (Completion improvements): Mention "info threads".
1244         * thread.c (struct info_threads_opts, info_threads_option_defs)
1245         (make_info_threads_options_def_group): New.
1246         (info_threads_command): Use gdb::option::process_options.
1247         (info_threads_command_completer): New.
1248         (_initialize_thread): Use gdb::option::build_help to build the
1249         help text for "info threads".
1250
1251 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1252
1253         * defs.h (generic_load): Move from here...
1254         * symfile.h (generic_load): ... to here.  Rename name parameter
1255         to args.
1256         * symfile.c (generic_load): Add comment.
1257
1258 2019-07-01  Tom Tromey  <tromey@adacore.com>
1259
1260         * dwarf2read.c
1261         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1262         declaration of without_params.  Fix formatting.
1263
1264 2019-07-01  Tom Tromey  <tromey@adacore.com>
1265
1266         * ada-exp.y (find_primitive_type): Update.
1267         * ada-lang.h (ada_lookup_symbol): Update.
1268         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1269         parameter.
1270         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1271
1272 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1273
1274         PR breakpoints/24541
1275         * gdbarch.c: Regenerate.
1276         * gdbarch.h: Regenerate.
1277         * gdbarch.sh: Add 'stap_adjust_register'.
1278         * i386-tdep.c: Include '<unordered_set>'.
1279         (i386_stap_adjust_register): New function.
1280         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1281         * stap-probe.c (stap_parse_register_operand): Call
1282         'gdbarch_stap_adjust_register'.
1283
1284 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1285
1286         PR python/24742
1287         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1288         * python/python.c (do_start_initialization): Use 'xmalloc'
1289         instead of 'PyMem_Malloc'.
1290
1291 2019-06-28  Tom Tromey  <tromey@adacore.com>
1292
1293         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1294         for Ada.
1295
1296 2019-06-27  Tom Tromey  <tromey@adacore.com>
1297
1298         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1299         objfile_key.
1300         (arm_find_mapping_symbol, arm_record_special_symbol)
1301         (_initialize_arm_tdep): Update.
1302         (arm_objfile_data_free): Remove.
1303
1304 2019-06-27  Tom Tromey  <tromey@adacore.com>
1305
1306         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1307         to cp_print_static_field.
1308
1309 2019-06-26  Tom Tromey  <tromey@adacore.com>
1310
1311         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1312         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1313         declare.
1314
1315 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1316
1317         * features/aarch64-core.c (create_feature_aarch64_core):
1318         Regenerate.
1319         * features/aarch64-core.xml: Add cpsr flags.
1320
1321 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1322
1323         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1324         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1325
1326 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1327
1328         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1329         field.
1330         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1331         use.
1332         (arm_record_special_symbol): Don't insert new symbol in sorted
1333         position, push it at the end.
1334
1335 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1336
1337         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1338         (arm_mapping_symbol_s): Remove.
1339         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1340         (arm_mapping_symbol_vec): New typedef.
1341         (struct arm_per_objfile): Add constructor.
1342         <section_maps>: Change type to
1343         std::unique_ptr<arm_mapping_symbol_vec[]>.
1344         (arm_compare_mapping_symbols): Remove.
1345         (arm_find_mapping_symbol): Adjust to section_maps type change.
1346         (arm_objfile_data_free): Call delete on arm_per_objfile.
1347         (arm_record_special_symbol): Adjust to section_maps type change.
1348         Allocate arm_per_objfile with new.
1349
1350 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1351
1352         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1353         with the command prefix.
1354
1355 2019-06-25  Tom Tromey  <tom@tromey.com>
1356
1357         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1358         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1359
1360 2019-06-25  Tom Tromey  <tom@tromey.com>
1361
1362         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1363         type.
1364         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1365         protected.
1366
1367 2019-06-25  Tom Tromey  <tom@tromey.com>
1368
1369         * tui/tui-winsource.c
1370         (tui_source_window_base::set_is_exec_point_at): Add check against
1371         LOA_ADDRESS.
1372
1373 2019-06-25  Tom Tromey  <tom@tromey.com>
1374
1375         * tui/tui-source.c (tui_set_source_content): Don't check before
1376         xfree.
1377         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1378
1379 2019-06-25  Tom Tromey  <tom@tromey.com>
1380
1381         * tui/tui-winsource.h (tui_update_source_window_as_is)
1382         (tui_alloc_source_buffer, tui_line_is_displayed)
1383         (tui_addr_is_displayed): Change type of win_info.
1384         * tui/tui-winsource.c (tui_update_source_window_as_is)
1385         (tui_clear_source_content, tui_show_source_line)
1386         (tui_show_source_content, tui_source_window_base::refill)
1387         (tui_source_window_base::set_is_exec_point_at)
1388         (tui_source_window_base::set_is_exec_point_at)
1389         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1390         (tui_alloc_source_buffer, tui_line_is_displayed)
1391         (tui_addr_is_displayed): Change type of win_info.  Update.
1392         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1393         (tui_source_window_base::do_make_visible_with_new_height):
1394         Update.
1395         * tui/tui-source.c (tui_set_source_content)
1396         (tui_set_source_content_nil)
1397         (tui_source_window::do_scroll_vertical): Update.
1398         * tui/tui-layout.c (show_layout): Update.
1399         * tui/tui-disasm.c (tui_set_disassem_content)
1400         (tui_disasm_window::do_scroll_vertical): Update.
1401         * tui/tui-data.h (tui_win_content): Remove.
1402         (struct tui_gen_win_info) <content, content_size>: Remove.
1403         (struct tui_source_element): Add initializers and destructor.
1404         (union tui_which_element, struct tui_win_element): Remove.
1405         (struct tui_source_window_base) <content>: New field.
1406         (struct tui_data_window): Remove destructor.
1407         (tui_alloc_content, tui_free_win_content)
1408         (tui_free_all_source_wins_content): Don't declare.
1409         * tui/tui-data.c (tui_initialize_static_data): Update.
1410         (init_content_element, tui_alloc_content): Remove.
1411         (~tui_gen_win_info): Update.
1412         (~tui_data_window, tui_free_all_source_wins_content)
1413         (tui_free_win_content, free_content, free_content_elements):
1414         Remove.
1415
1416 2019-06-25  Tom Tromey  <tom@tromey.com>
1417
1418         * tui/tui-winsource.h (tui_clear_source_content)
1419         (tui_erase_source_content, tui_show_source_content): Change type
1420         of win_info.
1421         * tui/tui-winsource.c (tui_clear_source_content)
1422         (tui_erase_source_content, tui_show_source_content): Change type
1423         of win_info.
1424         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1425         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1426         win_info.
1427         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1428         win_info.
1429         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1430
1431 2019-06-25  Tom Tromey  <tom@tromey.com>
1432
1433         * tui/tui-winsource.c (tui_clear_source_content)
1434         (tui_source_window_base::set_is_exec_point_at): Update.
1435         * tui/tui-source.c (tui_set_source_content_nil): Update.
1436         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1437         a bool.
1438         * tui/tui-data.c (init_content_element): Update.
1439
1440 2019-06-25  Tom Tromey  <tom@tromey.com>
1441
1442         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1443         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1444         * tui/tui-layout.c (init_and_make_win): Update.
1445         * tui/tui.h (enum tui_win_type): Update.
1446         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1447         tui_win_is_auxillary.
1448         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1449         tui_win_is_auxillary.
1450
1451 2019-06-25  Tom Tromey  <tom@tromey.com>
1452
1453         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1454         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1455         (tui_delete_data_content_windows, tui_display_all_data)
1456         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1457         Update.
1458         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1459         * tui/tui-regs.c (tui_last_regs_line_no)
1460         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1461         (tui_show_registers): Update.
1462         (tui_show_register_group): Return void.  Update.
1463         (tui_display_registers_from, tui_display_reg_element_at_line)
1464         (tui_display_registers_from_line, tui_check_register_values):
1465         Update.
1466         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1467         member.
1468         (struct tui_data_window) <regs_content>: Now a std::vector.
1469         <regs_content_count>: Remove.
1470         (tui_add_content_elements, tui_free_data_content): Don't declare.
1471         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1472         (init_content_element): Remove DATA_WIN case.  Add assert.
1473         (tui_add_content_elements): Remove.
1474         (tui_data_window): Update.
1475         (tui_free_data_content): Remove.
1476         (free_content_elements): Remove DATA_WIN case.
1477
1478 2019-06-25  Tom Tromey  <tom@tromey.com>
1479
1480         * tui/tui-data.c (tui_data_item_window): Update.
1481         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1482         * tui/tui-windata.c (tui_display_all_data)
1483         (tui_display_data_from_line): Update.
1484         (tui_check_data_values): Remove.
1485         * tui/tui-regs.c (tui_show_register_group)
1486         (tui_display_reg_element_at_line): Update.
1487         * tui/tui-hooks.c (tui_register_changed)
1488         (tui_refresh_frame_and_register_information): Call
1489         tui_check_register_values.
1490         * tui/tui-data.h (struct tui_data_window) <data_content,
1491         data_content_count, data_type>: Remove.
1492         (enum tui_data_type): Remove.
1493
1494         * tui/tui-data.c (tui_data_window::clear_detail)
1495         (~tui_data_window): Update.
1496
1497 2019-06-25  Tom Tromey  <tom@tromey.com>
1498
1499         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1500         declare.
1501         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1502         Rename from tui_first_data_item_displayed.  Update.
1503         (tui_data_window::refresh_all)
1504         (tui_data_window::do_scroll_vertical): Update.
1505         * tui/tui-data.h (struct tui_data_window)
1506         <first_data_item_displayed>: Declare new method.
1507
1508 2019-06-25  Tom Tromey  <tom@tromey.com>
1509
1510         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1511         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1512         contents...
1513         (tui_initialize_static_data): ...here.
1514
1515 2019-06-25  Tom Tromey  <tom@tromey.com>
1516
1517         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1518         (tui_display_registers_from, tui_check_register_values): Update.
1519         (tui_display_register): Remove win_info parameter; update.
1520         (tui_get_register): Change type of parameters.
1521         * tui/tui-data.h (struct tui_data_element): Remove.
1522         (union tui_which_element) <data>: Remove.
1523         <data_window>: Change type.
1524         (struct tui_data_item_window): New.
1525         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1526         case.  Add assert.
1527         (~tui_data_item_window): New destructor.
1528         (free_content_elements): Remove DATA_ITEM_WIN case.
1529
1530 2019-06-25  Tom Tromey  <tom@tromey.com>
1531
1532         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1533         Remove.
1534
1535 2019-06-25  Tom Tromey  <tom@tromey.com>
1536
1537         * tui/tui-data.h (struct tui_command_element): Remove.
1538         (union tui_which_element) <command>: Remove.
1539         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1540         assert.
1541         (free_content_elements): Remove CMD_WIN case.
1542
1543 2019-06-25  Tom Tromey  <tom@tromey.com>
1544
1545         * tui/tui-layout.c (tui_set_layout): Update.
1546         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1547         * tui/tui-data.c (layout_def): Update.
1548
1549 2019-06-25  Tom Tromey  <tom@tromey.com>
1550
1551         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1552         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1553         (tui_source_window_base::set_new_height): Update.
1554         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1555         Update.
1556         (tui_set_locator_fullname, tui_set_locator_info)
1557         (tui_show_frame_info): Update.
1558         * tui/tui-source.c (tui_set_source_content)
1559         (tui_source_is_displayed): Update.
1560         * tui/tui-layout.c (show_source_disasm_command, show_data)
1561         (show_source_or_disasm_and_command): Update.
1562         * tui/tui-disasm.c (tui_set_disassem_content)
1563         (tui_get_begin_asm_address): Update.
1564         * tui/tui-data.h (struct tui_locator_element): Remove.
1565         (union tui_which_element) <locator>: Remove.
1566         (struct tui_locator_window): New.
1567         (tui_locator_win_info_ptr): Change return type.
1568         * tui/tui-data.c (_locator): Change type.
1569         (tui_locator_win_info_ptr): Change return type.
1570         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1571         (tui_alloc_content): Add assert.
1572
1573 2019-06-25  Tom Tromey  <tom@tromey.com>
1574
1575         * tui/tui-winsource.c
1576         (tui_exec_info_window::maybe_allocate_content): New method.
1577         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1578         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1579         (make_source_or_disasm_window): Add cast.
1580         * tui/tui-data.h (union tui_which_element) <simple_string>:
1581         Remove.
1582         (struct tui_source_info): New.
1583         (struct tui_source_window_base) <execution_info>: Change type.
1584         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1585         case, and add assert.
1586         (tui_alloc_content): Add assert.
1587
1588 2019-06-25  Tom Tromey  <tom@tromey.com>
1589
1590         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1591         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1592         * tui/tui-data.c (tui_alloc_win_info): Remove.
1593
1594 2019-06-25  Tom Tromey  <tom@tromey.com>
1595
1596         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1597         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1598         can_highlight.
1599
1600 2019-06-25  Tom Tromey  <tom@tromey.com>
1601
1602         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1603         make_visible_with_new_height method.
1604         (tui_win_info::make_visible_with_new_height): New method.
1605         (tui_source_window_base::do_make_visible_with_new_height)
1606         (tui_data_window::do_make_visible_with_new_height)
1607         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1608         (make_visible_with_new_height): Remove.
1609         (tui_resize_all, tui_adjust_win_heights): Use
1610         make_visible_with_new_height method.
1611         * tui/tui-data.h (struct tui_win_info)
1612         <do_make_visible_with_new_height, make_visible_with_new_height>:
1613         New methods.
1614         (struct tui_source_window_base, struct tui_data_window)
1615         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1616         methods.
1617
1618 2019-06-25  Tom Tromey  <tom@tromey.com>
1619
1620         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1621         method.
1622         (update_tab_width): Call update_tab_width method.
1623         * tui/tui-data.h (struct tui_win_info)
1624         (struct tui_source_window_base) <update_tab_width>: New methods.
1625
1626 2019-06-25  Tom Tromey  <tom@tromey.com>
1627
1628         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1629         parameter.
1630         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1631         parameter.
1632         (tui_gen_win_info::make_visible): Update.
1633         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1634         parameter.
1635         * tui/tui-data.h (enum tui_box): New enum.
1636         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1637
1638 2019-06-25  Tom Tromey  <tom@tromey.com>
1639
1640         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1641         init_and_make_win for EXEC_INFO_WIN.
1642         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1643         longer inline.
1644         (struct tui_win_info) <~tui_win_info>: Inline.
1645         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1646         Don't declare.
1647         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1648         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1649         Remove.
1650         (tui_initialize_static_data): Update.
1651         (~tui_gen_win_info): Handle more cleanup here.
1652         (~tui_source_window_base): Delete "execution_info".
1653         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1654
1655 2019-06-25  Tom Tromey  <tom@tromey.com>
1656
1657         * tui/tui-layout.c (make_command_window): Don't set
1658         can_highlight.
1659         (show_source_disasm_command): Call the reset method.
1660         (show_data): Don't set can_highlight.  Call the reset method.
1661         (tui_gen_win_info::reset): Rename from init_gen_win_info
1662         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1663         (show_source_or_disasm_and_command): Call the reset method.
1664         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1665         (struct tui_cmd_window): Set can_highlight.
1666
1667 2019-06-25  Tom Tromey  <tom@tromey.com>
1668
1669         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1670         from make_visible.
1671         (tui_make_visible, tui_make_invisible): Rewrite.
1672         (tui_win_info::make_visible): Remove.
1673         (tui_source_window_base::make_visible): Update.
1674         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1675         method.  Moved from...
1676         (struct tui_win_info) <make_visible>: ...here.
1677
1678 2019-06-25  Tom Tromey  <tom@tromey.com>
1679
1680         * tui/tui-winsource.c
1681         (tui_source_window_base::do_scroll_horizontal): Remove direction
1682         parameter.
1683         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1684         direction parameter.
1685         * tui/tui-win.c (tui_win_info::forward_scroll)
1686         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1687         (tui_win_info::right_scroll): Update.
1688         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1689         direction parameter.
1690         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1691         direction parameter.
1692         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1693         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1694         Remove direction parameter.
1695         (struct tui_source_window_base, struct tui_source_window)
1696         (struct tui_disasm_window, struct tui_data_window)
1697         (struct tui_cmd_window): Update.
1698
1699 2019-06-25  Tom Tromey  <tom@tromey.com>
1700
1701         * tui/tui-winsource.h (tui_set_exec_info_content)
1702         (tui_show_exec_info_content, tui_erase_exec_info_content)
1703         (tui_clear_exec_info_content, tui_update_exec_info): Change
1704         argument to tui_source_window_base.
1705         * tui/tui-winsource.c (tui_set_exec_info_content)
1706         (tui_show_exec_info_content, tui_erase_exec_info_content)
1707         (tui_clear_exec_info_content, tui_update_exec_info): Change
1708         argument to tui_source_window_base.
1709
1710 2019-06-25  Tom Tromey  <tom@tromey.com>
1711
1712         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1713         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1714
1715 2019-06-25  Tom Tromey  <tom@tromey.com>
1716
1717         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1718         check.
1719
1720 2019-06-25  Tom Tromey  <tom@tromey.com>
1721
1722         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1723         type to void.
1724         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1725         type to void.
1726         * tui/tui-source.c (tui_set_source_content): Update.
1727         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1728
1729 2019-06-25  Tom Tromey  <tom@tromey.com>
1730
1731         * tui/tui-win.c (window_name_completer, tui_set_focus)
1732         (tui_all_windows_info): Use name method.
1733         * tui/tui-data.h (struct tui_gen_win_info)
1734         (struct tui_source_window, struct tui_disasm_window)
1735         (struct tui_data_window, struct tui_cmd_window) <name>: New
1736         method.
1737         (tui_win_name): Don't declare.
1738         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1739         (tui_win_name): Remove.
1740
1741 2019-06-25  Tom Tromey  <tom@tromey.com>
1742
1743         * tui/tui-winsource.h (tui_update_source_window)
1744         (tui_update_source_window_as_is): Change parameter type.
1745         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1746         to be a tui_source_window_base.
1747         (tui_update_source_window_as_is): Likewise.
1748         * tui/tui-win.c (make_visible_with_new_height): Update.
1749
1750 2019-06-25  Tom Tromey  <tom@tromey.com>
1751
1752         * tui/tui-winsource.c (tui_erase_source_content)
1753         (tui_show_source_content, tui_show_exec_info_content)
1754         (tui_erase_exec_info_content): Use refresh_window method.
1755         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1756         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1757         from tui_refresh_win.
1758         (tui_data_window::refresh_window): New method.
1759         (tui_win_info::refresh, tui_source_window_base::refresh)
1760         (tui_refresh_all): Use refresh_window method.
1761         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1762         method.
1763         * tui/tui-regs.c (tui_display_register): Call refresh_window
1764         method.
1765         * tui/tui-layout.c (show_source_disasm_command)
1766         (show_source_or_disasm_and_command): Call refresh_window method.
1767         * tui/tui-data.h (struct tui_gen_win_info)
1768         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1769         New method.
1770
1771 2019-06-25  Tom Tromey  <tom@tromey.com>
1772
1773         * tui/tui.c (tui_rl_other_window, tui_enable)
1774         (tui_is_window_visible, tui_get_command_dimension): Update.
1775         * tui/tui-winsource.c (tui_update_source_window_as_is)
1776         (tui_clear_source_content, tui_erase_source_content)
1777         (tui_show_source_line, tui_source_window_base::refill)
1778         (tui_source_window_base::do_scroll_horizontal)
1779         (tui_source_window_base::set_is_exec_point_at)
1780         (tui_update_breakpoint_info, tui_set_exec_info_content)
1781         (tui_alloc_source_buffer, tui_line_is_displayed)
1782         (tui_addr_is_displayed): Update.
1783         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1784         (tui_check_and_display_highlight_if_needed)
1785         (tui_win_info::make_visible, tui_win_info::refresh)
1786         (tui_refresh_all): Update.
1787         * tui/tui-windata.c (tui_first_data_item_displayed)
1788         (tui_delete_data_content_windows, tui_erase_data_content)
1789         (tui_display_all_data, tui_data_window::refresh_all)
1790         (tui_check_data_values): Update.
1791         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1792         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1793         (tui_win_info::backward_scroll, tui_refresh_all_win)
1794         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1795         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1796         (tui_source_window_base::set_new_height)
1797         (tui_data_window::set_new_height)
1798         (make_invisible_and_set_new_height)
1799         (make_visible_with_new_height, new_height_ok)
1800         (parse_scrolling_args): Update.
1801         * tui/tui-stack.c (tui_show_frame_info): Update.
1802         * tui/tui-source.c (tui_set_source_content)
1803         (tui_set_source_content_nil, tui_source_is_displayed)
1804         (tui_source_window::do_scroll_vertical): Update.
1805         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1806         (tui_display_registers_from, tui_display_reg_element_at_line)
1807         (tui_check_register_values, tui_reg_command): Update.
1808         * tui/tui-layout.c (tui_default_win_height)
1809         (show_source_disasm_command, show_data, init_and_make_win)
1810         (show_source_or_disasm_and_command): Update.
1811         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1812         (tui_redisplay_readline, tui_mld_flush)
1813         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1814         (tui_getc): Update.
1815         * tui/tui-disasm.c (tui_set_disassem_content)
1816         (tui_disasm_window::do_scroll_vertical): Update.
1817         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1818         Now virtual.
1819         (struct tui_win_info): Derive from tui_gen_win_info.
1820         <~tui_win_info>: Mark as override.
1821         <generic>: Remove member.
1822         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1823         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1824         (~tui_data_window, ~tui_win_info)
1825         (tui_free_all_source_wins_content): Update.
1826         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1827
1828 2019-06-25  Tom Tromey  <tom@tromey.com>
1829
1830         * tui/tui-layout.c (init_and_make_win): Use new.
1831         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1832         destructor, initializers.
1833         (tui_alloc_generic_win_info): Don't declare.
1834         * tui/tui-data.c (_locator): Add argument to constructor.
1835         (source_win, disasm_win): New globals.
1836         (exec_info): Remove.
1837         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1838         Update.
1839         (tui_alloc_generic_win_info): Remove.
1840         (init_content_element): Use new.
1841         (tui_win_info::tui_win_info): Update.
1842         (free_content_elements) <case DATA_WIN>: Use delete.
1843
1844 2019-06-25  Tom Tromey  <tom@tromey.com>
1845
1846         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1847         * tui/tui-windata.c (tui_first_data_item_displayed)
1848         (tui_delete_data_content_windows): Update.
1849         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1850         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1851         (tui_display_registers_from, tui_check_register_values): Update.
1852         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1853         pointer.
1854         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1855         window.
1856         (tui_free_data_content): Update.
1857         (free_content_elements) <case DATA_WIN>: Free the window.
1858
1859 2019-06-25  Tom Tromey  <tom@tromey.com>
1860
1861         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1862         Update.
1863         * tui/tui-layout.c (make_command_window)
1864         (show_source_disasm_command, show_data, init_and_make_win)
1865         (show_source_or_disasm_and_command): Update.
1866         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1867         method.
1868         <can_highight, is_highlighted>: Now bool.
1869         (tui_set_win_highlight): Don't declare.
1870         * tui/tui-data.c (tui_set_win_highlight): Remove.
1871
1872 2019-06-25  Tom Tromey  <tom@tromey.com>
1873
1874         * tui/tui-wingeneral.c (make_visible): Remove check of window
1875         type.
1876
1877 2019-06-25  Tom Tromey  <tom@tromey.com>
1878
1879         * tui/tui-win.c (tui_win_info::max_height)
1880         (tui_cmd_window::max_height): New methods.
1881         (new_height_ok): Call max_height.
1882         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1883         <max_height>: New method.
1884
1885 2019-06-25  Tom Tromey  <tom@tromey.com>
1886
1887         * tui/tui-win.c (tui_source_window_base::set_new_height)
1888         (tui_data_window::set_new_height): New methods.
1889         (make_invisible_and_set_new_height): Call set_new_height method.
1890         * tui/tui-data.h (struct tui_win_info)
1891         (struct tui_source_window_base, struct tui_data_window)
1892         <set_new_height>: New method.
1893
1894 2019-06-25  Tom Tromey  <tom@tromey.com>
1895
1896         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1897         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1898         tui_refresh_data_win.
1899         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1900         method.
1901         (tui_refresh_all_win): Call the refresh_all method.
1902         (tui_set_focus): Likewise.
1903         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1904         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1905         Likewise.
1906
1907 2019-06-25  Tom Tromey  <tom@tromey.com>
1908
1909         * tui/tui-winsource.h (tui_refill_source_window)
1910         (tui_set_is_exec_point_at): Don't declare.
1911         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1912         (tui_source_window_base::refill): Rename from
1913         tui_refill_source_window.
1914         (tui_source_window_base::do_scroll_horizontal): Update.
1915         (tui_source_window_base::set_is_exec_point_at): Rename from
1916         tui_set_is_exec_point_at.
1917         (tui_update_all_breakpoint_info): Update.
1918         * tui/tui-stack.c (tui_show_frame_info): Update.
1919         * tui/tui-layout.c (show_data): Add cast.
1920         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1921         * tui/tui-data.h (struct tui_source_window_base) <refill,
1922         set_is_exec_point_at>: New methods.
1923         (tui_source_windows, tui_add_to_source_windows): Update types.
1924         (tui_add_to_source_windows): Remove redundant declaration.
1925         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1926         (tui_source_windows): Change return type.
1927         (tui_clear_source_windows_detail): Update.
1928         (tui_add_to_source_windows): Change type of parameter.
1929         (tui_free_all_source_wins_content): Update.
1930
1931 2019-06-25  Tom Tromey  <tom@tromey.com>
1932
1933         * tui/tui-wingeneral.c (tui_win_info::refresh)
1934         (tui_source_window_base::refresh): New methods.
1935         (tui_refresh_all): Call the refresh method.
1936         * tui/tui-data.h (struct tui_win_info)
1937         (struct tui_source_window_base) <refresh>: New method.
1938
1939 2019-06-25  Tom Tromey  <tom@tromey.com>
1940
1941         * tui/tui.h (tui_is_window_visible): Return bool.
1942         * tui/tui.c (tui_is_window_visible): Return bool.
1943         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1944         (tui_make_visible, tui_make_invisible)
1945         (tui_win_info::make_visible)
1946         (tui_source_window_base::make_visible, make_all_visible)
1947         (tui_make_all_visible, tui_make_all_invisible): Update.
1948         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1949         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1950         bool.
1951         (struct tui_win_info, struct tui_source_window_base)
1952         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1953         * tui/tui-data.c (tui_init_generic_part): Update.
1954
1955 2019-06-25  Tom Tromey  <tom@tromey.com>
1956
1957         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1958         (tui_source_window_base::make_visible): New methods.
1959         (make_all_visible): Make method call.
1960         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1961         (struct tui_source_window_base, struct tui_cmd_window): Override
1962         make_visible.
1963         (tui_win_is_source_type): Don't declare.
1964         * tui/tui-data.c (tui_win_is_source_type): Remove.
1965
1966 2019-06-25  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1969         NULL check.
1970
1971 2019-06-25  Tom Tromey  <tom@tromey.com>
1972
1973         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1974         Inline constructor.  Add initializers for members.
1975         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1976         constructors; now inline in class.
1977
1978 2019-06-25  Tom Tromey  <tom@tromey.com>
1979
1980         * tui/tui-regs.c (tui_show_registers): Update.
1981         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1982         bool.
1983         * tui/tui-data.c (tui_data_window::clear_detail)
1984         (tui_data_window): Update.
1985
1986 2019-06-25  Tom Tromey  <tom@tromey.com>
1987
1988         * tui/tui-windata.c (tui_display_all_data)
1989         (tui_display_data_from_line, tui_display_data_from)
1990         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1991         Update.
1992         * tui/tui-regs.c (tui_last_regs_line_no)
1993         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1994         (tui_show_registers, tui_show_register_group)
1995         (tui_display_registers_from, tui_display_reg_element_at_line)
1996         (tui_display_registers_from_line, tui_check_register_values)
1997         (tui_reg_next, tui_reg_prev): Update.
1998         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1999         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2000         tui_data_window.
2001         (struct tui_win_info) <detail>: Remove.  Add new fields from
2002         tui_data_info.
2003         (TUI_DATA_WIN): Add cast.
2004         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2005         (~tui_data_window): Simplify.
2006
2007 2019-06-25  Tom Tromey  <tom@tromey.com>
2008
2009         * tui/tui-layout.c (show_source_disasm_command)
2010         (show_source_or_disasm_and_command): Update.
2011         * tui/tui-io.c (update_cmdwin_start_line)
2012         (tui_redisplay_readline): Update.
2013         * tui/tui-data.h (struct tui_command_info): Remove.
2014         (struct tui_win_info) <detail>: Remove command_info member.
2015         (struct tui_data_window) <start_line>: New member, from
2016         tui_command_info.
2017         (TUI_CMD_WIN): Add casts.
2018
2019 2019-06-25  Tom Tromey  <tom@tromey.com>
2020
2021         * tui/tui-winsource.c (tui_update_source_window)
2022         (tui_refill_source_window)
2023         (tui_source_window_base::do_scroll_horizontal)
2024         (tui_update_breakpoint_info, tui_set_exec_info_content)
2025         (tui_show_exec_info_content, tui_erase_exec_info_content)
2026         (tui_clear_exec_info_content): Update.
2027         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2028         Update.
2029         * tui/tui-win.c (make_invisible_and_set_new_height)
2030         (make_visible_with_new_height): Update.
2031         * tui/tui-source.c (tui_set_source_content)
2032         (tui_show_symtab_source): Update.
2033         * tui/tui-layout.c (extract_display_start_addr)
2034         (show_source_disasm_command, show_data)
2035         (make_source_or_disasm_window)
2036         (show_source_or_disasm_and_command): Update.
2037         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2038         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2039         "gdbarch".
2040         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2041         to tui_source_window_base.
2042         (struct tui_win_info) <detail>: Remove source_info member.
2043         (struct tui_source_window_base) <has_locator>: Inline.
2044         Move contents from tui_source_info; rename has_locator member to
2045         m_has_locator.
2046         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2047         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2048         header file.
2049         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2050         Simplify.
2051         (tui_free_all_source_wins_content): Cast to
2052         tui_source_window_base.
2053
2054 2019-06-25  Tom Tromey  <tom@tromey.com>
2055
2056         * tui/tui-win.c (make_invisible_and_set_new_height)
2057         (make_visible_with_new_height): Call has_locator method.
2058         * tui/tui-layout.c (show_source_disasm_command, show_data)
2059         (show_source_or_disasm_and_command): Update for bool change.
2060         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2061         (tui_win_info) <has_locator>: New method.
2062         (struct tui_source_window_base) <has_locator>: New method.
2063         (tui_win_has_locator): Don't declare.
2064         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2065         from tui_win_has_locator.
2066         (tui_source_window_base): Use false, not FALSE.
2067
2068 2019-06-25  Tom Tromey  <tom@tromey.com>
2069
2070         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2071         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2072         clear_detail method directly.
2073         (tui_clear_win_detail): Remove.
2074
2075 2019-06-25  Tom Tromey  <tom@tromey.com>
2076
2077         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2078         "this", not TUI_DISASM_WIN.
2079
2080 2019-06-25  Tom Tromey  <tom@tromey.com>
2081
2082         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2083         declare.
2084         * tui/tui-winsource.c
2085         (tui_source_window_base::do_scroll_horizontal): Rename from
2086         tui_horizontal_source_scroll.
2087         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2088         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2089         from tui_vertical_data_scroll.
2090         * tui/tui-win.h (tui_scroll): Don't declare.
2091         * tui/tui-win.c (tui_win_info::forward_scroll)
2092         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2093         (tui_win_info::right_scroll): Rename and update.
2094         (tui_scroll_forward_command, tui_scroll_backward_command)
2095         (tui_scroll_left_command, tui_scroll_right_command): Update.
2096         (tui_scroll): Remove.
2097         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2098         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2099         from tui_vertical_source_scroll.
2100         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2101         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2102         from tui_vertical_disassem_scroll.
2103         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2104         do_scroll_horizontal>: New methods.
2105         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2106         Likewise.
2107         (struct tui_source_window_base): Add do_scroll_horizontal.
2108         (struct tui_source_window, struct tui_disasm_window): Add
2109         do_scroll_vertical.
2110         (struct tui_data_window, struct tui_cmd_window): Add
2111         do_scroll_horizontal and do_scroll_vertical.
2112         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2113
2114 2019-06-25  Tom Tromey  <tom@tromey.com>
2115
2116         * tui/tui-data.h (struct tui_source_window_base): New struct.
2117         (struct tui_source_window): Derive from tui_source_window_base.
2118         (struct tui_disasm_window): New struct.
2119         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2120         from tui_source_window::clear_detail.
2121         (tui_source_window_base): Rename from tui_source_window.
2122         (~tui_source_window_base): Rename from ~tui_source_window.
2123         (tui_alloc_win_info): Create a tui_disasm_window.
2124
2125 2019-06-25  Tom Tromey  <tom@tromey.com>
2126
2127         * tui/tui-data.h (struct tui_source_window)
2128         (struct tui_data_window): Declare destructors.
2129         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2130         destructors.
2131         (tui_win_info): Simplify.
2132
2133 2019-06-25  Tom Tromey  <tom@tromey.com>
2134
2135         * tui/tui-winsource.c (tui_display_main)
2136         (tui_update_source_windows_with_addr)
2137         (tui_update_all_breakpoint_info): Update.
2138         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2139         (new_height_ok, parse_scrolling_args): Update.
2140         * tui/tui-stack.c (tui_show_frame_info): Update.
2141         * tui/tui-data.h (struct tui_list): Remove.
2142         (tui_source_windows): Return a reference to a std::vector.
2143         * tui/tui-data.c (source_windows): Now a std::vector.
2144         (tui_source_windows): Change return type.
2145         (tui_clear_source_windows): Rewrite.
2146         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2147         (tui_free_all_source_wins_content): Rewrite.
2148
2149 2019-06-25  Tom Tromey  <tom@tromey.com>
2150
2151         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2152         (struct tui_data_window, struct tui_cmd_window): Declare
2153         clear_detail method.
2154         * tui/tui-data.c (tui_source_window::clear_detail)
2155         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2156         methods.
2157         (tui_clear_win_detail): Simplify.
2158
2159 2019-06-25  Tom Tromey  <tom@tromey.com>
2160
2161         * tui/tui-layout.c (make_source_window, make_disasm_window)
2162         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2163         Return the new window.
2164         (show_source_disasm_command, show_data)
2165         (show_source_or_disasm_and_command): Update.
2166
2167 2019-06-25  Tom Tromey  <tom@tromey.com>
2168
2169         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2170         parameter.  Return the new window.
2171         (show_source_disasm_command): Update and remove NULL check.
2172         (show_source_or_disasm_and_command): Update.
2173
2174 2019-06-25  Tom Tromey  <tom@tromey.com>
2175
2176         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2177
2178 2019-06-25  Tom Tromey  <tom@tromey.com>
2179
2180         * tui/tui-data.h (struct tui_win_info): Make constructor
2181         protected.  Make destructor virtual.  Add initializers.
2182         (tui_source_window, tui_data_window, tui_cmd_window): New
2183         classes.
2184         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2185         constructor.  Add "type" parameter.
2186         (tui_source_window, tui_data_window, tui_cmd_window): New
2187         constructors.
2188         (tui_alloc_win_info): Instantiate the appropriate subclass.
2189
2190 2019-06-25  Tom Tromey  <tom@tromey.com>
2191
2192         * tui/tui-win.c (tui_resize_all): Use delete.
2193         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2194         destructor.
2195         (tui_free_window): Don't declare.
2196         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2197         Update.
2198
2199 2019-06-25  Tom Tromey  <tom@tromey.com>
2200
2201         * tui/tui-data.h (struct tui_win_info): Add constructor.
2202         * tui/tui-data.c (tui_alloc_win_info): Use new.
2203         (tui_free_window): Use delete.
2204
2205 2019-06-22  Tom Tromey  <tom@tromey.com>
2206
2207         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2208         declare.
2209         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2210
2211 2019-06-22  Tom Tromey  <tom@tromey.com>
2212
2213         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2214         declare.
2215         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2216
2217 2019-06-22  Tom de Vries  <tdevries@suse.de>
2218
2219         * dwarf2read.c (create_addrmap_from_aranges)
2220         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2221         instead of '%zu'.
2222
2223 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2224
2225         * dwarf2read.h (dwarf2_section_info_def): Remove.
2226         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2227         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2228         std::vector<dwarf2_section_info>.
2229         (struct dwo_file) <~dwo_file>: Remove.
2230         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2231         types field.
2232         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2233         (dwarf2_read_debug_names): Likewise.
2234         (create_debug_types_hash_table): Change parameter type to
2235         array_view, adjust code accordingly.
2236         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2237         (partial_die_info::fixup): Likewise.
2238         (determine_prefix): Likewise.
2239         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2240
2241 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2242
2243         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2244         gdb_bfd_ref_ptr.
2245         <~dwo_file>: Remove call to gdb_bfd_unref.
2246         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2247         gdb_bfd_ref_ptr::get.
2248
2249 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2250
2251         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2252         type to htab_up.
2253         * dwarf2read.c (struct dwo_file): Initialize fields.
2254         <~dwo_file>: New.
2255         (free_dwo_file): Remove, move content to ~dwo_file.
2256         (struct dwo_file_deleter): Remove.
2257         (dwo_file_up>: Remove custom deleter.
2258         (free_dwo_files): Remove.
2259         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2260         dwo_files.
2261         (process_skeletonless_type_units): Call unique_ptr::get.
2262         (allocate_dwo_file_hash_table): Add deleter to created hash
2263         table.  Change return type to htab_up.
2264         (lookup_dwo_file_slot): Don't memset dwo_file, call
2265         unique_ptr::get.
2266         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2267         (create_dwo_unit_in_dwp_v2): Likewise.
2268         (open_and_init_dwo_file): Likewise.
2269         (free_dwo_file_from_slot): Remove.
2270
2271 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2272
2273         * dwarf2read.h (struct dwarf2_section_info) <readin,
2274         is_virtual>: Change type to bool.
2275         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2276         true instead of 1.
2277
2278 2019-06-19  Tom Tromey  <tom@tromey.com>
2279
2280         * tui/tui-data.h (tui_init_content_element): Don't declare.
2281
2282 2019-06-19  Tom Tromey  <tom@tromey.com>
2283
2284         * tui/tui-data.h (tui_init_win_info): Don't declare.
2285
2286 2019-06-19  Tom de Vries  <tdevries@suse.de>
2287
2288         * dwarf2read.h (abstract_to_concrete): Change type to
2289         std::unordered_map<sect_offset, std::vector<sect_offset>,
2290         gdb::hash_enum<sect_offset>>.
2291
2292 2019-06-19  Tom Tromey  <tromey@adacore.com>
2293
2294         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2295         EVAL_AVOID_SIDE_EFFECTS specially.
2296
2297 2019-06-19  Tom Tromey  <tromey@adacore.com>
2298
2299         * source-cache.c (highlighter): New global.
2300         (source_cache::get_source_lines): Create a highlighter on demand.
2301
2302 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2303
2304         * defs.h (deprecated_interactive_hook): Delete declaration.
2305         * interps.c (clear_interpreter_hooks): Remove use of
2306         deprecated_interactive_hook.
2307         * top.c (deprecated_interactive_hook): Delete definition.
2308         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2309
2310 2019-06-18  Tom de Vries  <tdevries@suse.de>
2311
2312         PR gdb/24515
2313         * dwarf2read.h (abstract_to_concrete): Change type from
2314         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2315         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2316         * dwarf2read.c (read_variable): Update.
2317         (dwarf2_fetch_die_loc_sect_off): Update.
2318
2319 2019-06-17  Tom de Vries  <tdevries@suse.de>
2320
2321         PR gdb/24617
2322         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2323         accessing parent[parent_len - 1].
2324
2325 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2326
2327         PR gdb/24364
2328         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2329         call dtrace_process_dof with NULL dof.
2330
2331 2019-06-16  Tom de Vries  <tdevries@suse.de>
2332
2333         PR gdb/24445
2334         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2335
2336 2019-06-16  Tom Tromey  <tom@tromey.com>
2337
2338         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2339         (make_all_visible): Use address of member.
2340
2341 2019-06-16  Tom Tromey  <tom@tromey.com>
2342
2343         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2344         (tui_free_window, free_content, free_content_elements): Remove
2345         unnecessary cast.
2346         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2347         cast.
2348         * tui/tui-regs.c (tui_show_register_group)
2349         (tui_display_registers_from, tui_display_reg_element_at_line):
2350         Remove unnecessary cast.
2351
2352 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2353
2354         * linux-nat.c (normal_mask): Delete.
2355         (_initialize_linux_nat): Don't initialise normal_mask.
2356
2357 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2358
2359         PR gdb/24445
2360         * dwarf-index-write.h (write_psymtabs_to_index): Add
2361         dwz_basename parameter.
2362         * dwarf-index-write.c (write_gdbindex): Move file writing to
2363         write_gdbindex_1.  Change return type void.
2364         (assert_file_size): Move up, remove filename parameter.
2365         (write_gdbindex_1): New function.
2366         (write_debug_names): Change return type to void, call
2367         assert_file_size.
2368         (struct index_wip_file): New struct.
2369         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2370         file logic to index_wip_file.  Write index for dwz file if
2371         needed.
2372         (save_gdb_index_command): Pass basename of dwz file, if present.
2373         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2374         build-id of dwz file, if present.
2375         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2376         (dwarf2_get_dwz_file): Likewise.
2377         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2378         (dwarf2_get_dwz_file): Likewise.
2379
2380 2019-06-16  Tom Tromey  <tom@tromey.com>
2381
2382         * coffread.c (process_coff_symbol): Use xstrdup.
2383         * value.c (create_internalvar): Use xstrdup.
2384
2385 2019-06-16  Tom Tromey  <tom@tromey.com>
2386
2387         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2388         * breakpoint.c (stopin_command, stopat_command)
2389         (until_break_command, decode_location_default): Remove unnecessary
2390         cast.
2391         * utils.c (subset_compare): Remove unnecessary cast.
2392         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2393         cast.
2394         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2395         cast.
2396         * infcmd.c (path_command): Remove unnecessary cast.
2397         * coffread.c (decode_type): Remove unnecessary cast.
2398         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2399         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2400         * tui/tui-stack.c (tui_show_locator_content)
2401         (tui_show_frame_info): Remove unnecessary cast.
2402         * tui/tui-win.c (tui_scroll_forward_command)
2403         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2404         (parse_scrolling_args): Remove unnecessary cast.
2405         * tui/tui-data.c (init_win_info, tui_del_window)
2406         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2407         (free_content_elements): Remove unnecessary cast.
2408         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2409         unnecessary cast.
2410         * tui/tui-source.c (tui_set_source_content)
2411         (tui_vertical_source_scroll): Remove unnecessary cast.
2412         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2413         cast.
2414         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2415         * tui/tui-regs.c (tui_display_registers_from)
2416         (tui_display_register): Remove unnecessary cast.
2417         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2418         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2419         (make_visible): Remove unnecessary cast.
2420         * tui/tui-winsource.c (tui_erase_source_content)
2421         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2422         unnecessary cast.
2423         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2424         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2425         * stabsread.c (read_type, read_array_type, read_range_type):
2426         Remove unnecessary cast.
2427         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2428         (parse_symbol, parse_type, upgrade_type, parse_external)
2429         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2430         unnecessary cast.
2431         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2432
2433 2019-06-16  Tom Tromey  <tom@tromey.com>
2434
2435         * tui/tui-data.c (tui_alloc_generic_win_info)
2436         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2437         checks.
2438
2439 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2440             Andrew Burgess  <andrew.burgess@embecosm.com>
2441
2442         * f-typeprint.c (f_print_type): Don't return early for not
2443         associated or not allocated types.
2444         (f_type_print_varspec_suffix): Add print_rank parameter and print
2445         ranks of array types in case they dangling.
2446         (f_type_print_base): Add print_rank parameter.
2447
2448 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2449
2450         * NEWS: Mention new MI commands.
2451         * break-catch-throw.c (enum exception_event_kind): Move to
2452         breakpoint.h.
2453         (print_mention_exception_catchpoint): Output text as a single
2454         message.
2455         (catch_exception_command_1): Rename to...
2456         (catch_exception_event): ...this, make non-static, update header
2457         command, and change some parameter types.
2458         (catch_catch_command): Update for changes to
2459         catch_exception_command_1.
2460         (catch_throw_command): Likewise.
2461         (catch_rethrow_command): Likewise.
2462         * breakpoint.c (enum exception_event_kind): Delete.
2463         * breakpoint.h (enum exception_event_kind): Moved here from
2464         break-catch-throw.c.
2465         (catch_exception_event): Declare.
2466         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2467         (mi_cmd_catch_throw): New function.
2468         (mi_cmd_catch_rethrow): New function.
2469         (mi_cmd_catch_catch): New function.
2470         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2471         'catch-catch' entries.
2472         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2473         (mi_cmd_catch_rethrow): Declare.
2474         (mi_cmd_catch_catch): Declare.
2475
2476 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2477
2478         * annotate.c (annotate_source_line): Change return type to void,
2479         update implementation to match.
2480         * annotate.h (annotate_source_line): Change return type to void,
2481         update header comment.
2482         * stack.c (print_frame_info): Don't change what frame information
2483         is printed based on whether annotations are on or not.
2484
2485 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2486
2487         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2488         (annotate_source): Make static.
2489         (annotate_source_line): Moved from source.c and renamed from
2490         identify_source_line.  Update the return type.
2491         * annotate.h (annotate_source): Delete declaration.
2492         (annotate_source_line): Declaration moved from source.h, and
2493         renamed from identify_source_line.  Return type updated.
2494         * source.c (identify_source_line): Moved to annotate.c and renamed
2495         to annotate_source_line.
2496         (info_line_command): Remove check of annotation_level.
2497         * source.h (identify_source_line): Move declaration to annotate.h
2498         and rename to annotate_source_line.
2499         * stack.c: Add 'annotate.h' include.
2500         (print_frame_info): Remove check of annotation_level before
2501         calling annotate_source_line.
2502
2503 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2504
2505         * source-cache.c (source_cache::get_plain_source_lines): Use
2506         open_source_file_with_line_charpos instead of just
2507         open_source_file, remove call to find_source_lines.
2508         (source_cache::get_source_lines): Likewise.
2509         * source.c (find_source_lines): Make static.
2510         (get_filename_and_charpos): Renamed into...
2511         (open_source_file_with_line_charpos): ..this along with changes to
2512         return a scoped_fd, and some other minor clean ups.
2513         (identify_source_line): Use open_source_file_with_line_charpos.
2514         (search_command_helper): Use open_source_file_with_line_charpos
2515         instead of just open_source_file, remove call to
2516         find_source_lines.
2517         * source.h (open_source_file_with_line_charpos): Declare new
2518         function.
2519         (find_source_lines): Delete declaration.
2520
2521 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2522
2523         * source.c (get_filename_and_charpos): Remove fullname
2524         parameter.
2525         (identify_source_line): Update call to get_filename_and_charpos.
2526
2527 2019-06-14  Tom Tromey  <tromey@adacore.com>
2528
2529         PR gdb/24502:
2530         * ui-style.h (skip_ansi_escape): Update comment.
2531         * ui-file.h (class no_terminal_escape_file): New class.
2532         * ui-file.c (no_terminal_escape_file::write)
2533         (no_terminal_escape_file::puts): New methods.
2534         * cli/cli-logging.c (handle_redirections): Use
2535         no_terminal_escape_file.
2536
2537 2019-06-14  Tom Tromey  <tromey@adacore.com>
2538
2539         * NEWS: Move convenience variable news above Python news.
2540
2541 2019-06-14  Tom Tromey  <tom@tromey.com>
2542
2543         * gnulib: Move directory to top-level.
2544         * configure.ac: Don't configure gnulib.
2545         * configure: Rebuild.
2546         * common/common-defs.h: Use new path to gnulib.
2547         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2548         (GNULIB_H): Remove.
2549         (INCGNU): Look in new gnulib location.
2550         (HFILES_NO_SRCDIR): Remove gnulib files.
2551         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2552         (generated_files): Remove GNULIB_H.
2553         ($(LIBGNU), all-lib): Remove targets.
2554         (distclean): Don't mention GNULIB_BUILDDIR.
2555         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2556
2557 2019-06-14  Tom Tromey  <tromey@adacore.com>
2558
2559         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2560         Warn if symbol file does not provide any symbols.
2561
2562 2019-06-14  Tom Tromey  <tromey@adacore.com>
2563
2564         * source.c (find_and_open_source): Respect basenames_may_differ.
2565
2566 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2567
2568         * annotate.c (annotate_breakpoints_invalid): Make use of
2569         scoped_restore_terminal_state.
2570         (annotate_frames_invalid): Likewise.
2571
2572 2019-06-14  Tom Tromey  <tromey@adacore.com>
2573
2574         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2575         allow assignment to an internalvar.
2576
2577 2019-06-14  Tom Tromey  <tromey@adacore.com>
2578
2579         * ada-lex.l: Allow "_" in attribute names.
2580
2581 2019-06-14  Tom Tromey  <tromey@adacore.com>
2582
2583         PR gdb/24653:
2584         * regcache.c (registers_changed): Don't call alloca.
2585         * top.c (execute_command): Don't call alloca.
2586
2587 2019-06-13  Pedro Alves  <palves@redhat.com>
2588
2589         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2590         'expression'.  When parsing an expression, error out if there's
2591         junk after "unlimited".
2592         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2593         (do_set_command): Adjust calls to is_unlimited_literal.
2594
2595 2019-06-13  Pedro Alves  <palves@redhat.com>
2596
2597         * compile/compile.c (make_compile_options_def_group): Add braces
2598         around array_view initializer.
2599         * thread.c (make_thread_apply_all_options_def_group)
2600         (make_thread_apply_all_options_def_group): Likewise.
2601
2602 2019-06-13  Pedro Alves  <palves@redhat.com>
2603
2604         * NEWS (New commands): Mention "maint test-options
2605         require-delimiter", "maint test-options unknown-is-error", "maint
2606         test-options unknown-is-operand" and "maint show
2607         test-options-completion-result".
2608         (New command options, command completion): New section.
2609         (Completion improvements): New section.
2610         Mention that you can abbreviate "unlimited".
2611
2612 2019-06-13  Pedro Alves  <palves@redhat.com>
2613
2614         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2615         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2616         * unittests/cli-utils-selftests.c (test_parse_flags)
2617         (test_parse_flags_qcs): Delete.
2618         (test_cli_utils): Don't call deleted functions.
2619
2620 2019-06-13  Pedro Alves  <palves@redhat.com>
2621
2622         * thread.c: Include "cli/cli-option.h".
2623         (tp_array_compar_ascending): Global.
2624         (tp_array_compar): Delete function.
2625         (tp_array_compar_ascending, tp_array_compar_descending): New
2626         functions.
2627         (ascending_option_def, qcs_flag_option_def)
2628         (thr_qcs_flags_option_defs)
2629         (make_thread_apply_all_options_def_group)
2630         (make_thread_apply_options_def_group): New.
2631         (thread_apply_all_command): Use gdb::option::process_options.
2632         (thread_apply_command_completer)
2633         (thread_apply_all_command_completer): New.
2634         (thread_apply_command): Use gdb::option::process_options.
2635         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2636         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2637         to generate help text of "thread apply".  Adjust "taas"'s help.
2638         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2639         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2640
2641 2019-06-13  Pedro Alves  <palves@redhat.com>
2642
2643         * thread.c (thread_apply_command): Check for invalid TID with
2644         isdigit instead of !isalpha.
2645
2646 2019-06-13  Pedro Alves  <palves@redhat.com>
2647
2648         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2649         (validate_flags_qcs): New.
2650         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2651         (validate_flags_qcs): Declare.
2652         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2653         (make_frame_apply_options_def_group): New.
2654         (frame_apply_command_count): Process options with
2655         gdb::option::process_options.
2656         (frame_apply_completer): New.
2657         (frame_apply_level_completer, frame_apply_all_completer)
2658         (frame_apply_completer): New.
2659         (_initialize_stack): Update help of "frame apply", "frame apply
2660         level", "frame apply all" and "faas" to mention supported options
2661         and install command completers.
2662         * stack.h (frame_apply_all_completer): Declare.
2663         * thread.c: Include "stack.h".
2664         (tfaas_command): Add "--".
2665         (_initialize_thread): Update help "tfaas" to mention supported
2666         options and install command completer.
2667
2668 2019-06-13  Pedro Alves  <palves@redhat.com>
2669
2670         * completer.c (complete_nested_command_line): New.
2671         (gdb_completion_word_break_characters_throw): Add assertion.
2672         * completer.h (complete_nested_command_line): Declare.
2673
2674 2019-06-13  Pedro Alves  <palves@redhat.com>
2675
2676         * stack.c (parse_backtrace_qualifiers): New.
2677         (backtrace_command): Use it.
2678         (backtrace_command_completer): Complete on qualifiers.
2679
2680 2019-06-13  Pedro Alves  <palves@redhat.com>
2681
2682         * frame.c: Include "cli/cli-option.h.
2683         (user_set_backtrace_options): New.
2684         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2685         Delete.
2686         (get_prev_frame): Adjust.
2687         (boolean_option_def, uinteger_option_def)
2688         (set_backtrace_option_defs): New.
2689         (_initialize_frame): Adjust and use
2690         gdb::option::add_setshow_cmds_for_options to install "set
2691         backtrace past-main" and "set backtrace past-entry".
2692         * frame.h: Include "cli/cli-option.h".
2693         (struct frame_print_options): Forward declare.
2694         (print_frame_arguments_all, print_frame_arguments_scalars)
2695         (print_frame_arguments_none): Declare.
2696         (print_entry_values): Delete declaration.
2697         (struct frame_print_options, user_frame_print_options): New.
2698         (struct set_backtrace_options): New.
2699         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2700         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2701         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2702         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2703         (list_args_or_locals): Add frame_print_options parameter.
2704         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2705         * python/py-framefilter.c (enumerate_args): Pass down
2706         USER_FRAME_PRINT_OPTIONS.
2707         * stack.c: Include "cli/cli-option.h".
2708         (print_frame_arguments_all, print_frame_arguments_scalars)
2709         (print_frame_arguments_none): Declare.
2710         (print_raw_frame_arguments, print_entry_values): Delete.
2711         (user_frame_print_options): New.
2712         (boolean_option_def, enum_option_def, frame_print_option_defs):
2713         New.
2714         (struct backtrace_cmd_options): New.
2715         (bt_flag_option_def): New.
2716         (backtrace_command_option_defs): New.
2717         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2718         (print_frame_arg, read_frame_arg, print_frame_args)
2719         (print_frame_info, print_frame): Add frame_print_options parameter
2720         and use it.
2721         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2722         (backtrace_command_1): Add frame_print_options and
2723         backtrace_cmd_options parameters and use them.
2724         (make_backtrace_options_def_group): New.
2725         (backtrace_command): Process command options with
2726         gdb::option::process_options.
2727         (backtrace_command_completer): New.
2728         (_initialize_stack): Extend "backtrace"'s help to mention
2729         supported options.  Install completer for "backtrace".
2730         Install some settings commands with add_setshow_cmds_for_options.
2731
2732 2019-06-13  Pedro Alves  <palves@redhat.com>
2733
2734         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2735         and that "set/show print raw frame-arguments" are now deprecated.
2736
2737         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2738         command.
2739         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2740         * stack.c (_initialize_stack): Install "set/show print
2741         raw-frame-arguments", and deprecate "set/show print raw
2742         frame-arguments".
2743         * valprint.c (_initialize_valprint): Deprecate "set/show print
2744         raw".
2745
2746 2019-06-13  Pedro Alves  <palves@redhat.com>
2747
2748         * compile/compile.c (struct compile_options): New.
2749         (compile_flag_option_def, compile_command_option_defs)
2750         (make_compile_options_def_group): New.
2751         (compile_file_command): Handle options with
2752         gdb::option::process_options.
2753         (compile_file_command_completer): New function.
2754         (compile_code_command): Handle options with
2755         gdb::option::process_options.
2756         (compile_code_command_completer): New function.
2757         (_initialize_compiler): Install completers for "compile code" and
2758         "compile file".  Mention available options in "compile code" and
2759         "compile code"'s help.
2760         * completer.c (advance_to_completion_word): New, factored out from
2761         ...
2762         (advance_to_expression_complete_word_point): ... this.
2763         (advance_to_filename_complete_word_point): New.
2764         * completer.h (advance_to_filename_complete_word_point): New
2765         declaration.
2766
2767 2019-06-13  Pedro Alves  <palves@redhat.com>
2768
2769         * compile/compile.c: Include "cli/cli-option.h".
2770         (compile_print_value): Scope data pointer is now a
2771         value_print_options pointer; adjust.
2772         (compile_print_command): Process options.  Scope data pointer is
2773         now a value_print_options pointer; adjust.
2774         (_initialize_compile): Update "compile print"'s help to include
2775         supported options.  Install a completer for "compile print".
2776         * cp-valprint.c (show_vtblprint, show_objectprint)
2777         (show_static_field_print): Delete.
2778         (_initialize_cp_valprint): Don't install "set print
2779         static-members", "set print vtbl", "set print object" here.
2780         * printcmd.c: Include "cli/cli-option.h" and
2781         "common/gdb_optional.h".
2782         (print_command_parse_format): Rework to fill in a
2783         value_print_options instead of a format_data.
2784         (print_value): Change parameter type from format_data pointer to
2785         value_print_options reference.  Adjust.
2786         (print_command_1): Process options.  Adjust to pass down a
2787         value_print_options.
2788         (print_command_completer): New.
2789         (_initialize_printcmd): Install print_command_completer as
2790         handle_brkchars completer for the "print" command.  Update
2791         "print"'s help to include supported options.
2792         * valprint.c: Include "cli/cli-option.h".
2793         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2794         here from cp-valprint.c.
2795         (boolean_option_def, uinteger_option_def)
2796         (value_print_option_defs, make_value_print_options_def_group):
2797         New.  Use gdb::option::add_setshow_cmds_for_options to install
2798         "set print elements", "set print null-stop", "set print repeats",
2799         "set print pretty", "set print union", "set print array", "set
2800         print address", "set print symbol", "set print array-indexes".
2801         * valprint.h: Include <string> and "cli/cli-option.h".
2802         (make_value_print_options_def_group): Declare.
2803         (print_value): Change parameter type from format_data pointer to
2804         value_print_options reference.
2805         (print_command_completer): Declare.
2806
2807 2019-06-13  Pedro Alves  <palves@redhat.com>
2808
2809         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2810         (COMMON_SFILES): Add maint-test-settings.c.
2811         * cli/cli-decode.c (boolean_enums): New global, factored out from
2812         ...
2813         (add_setshow_boolean_cmd): ... here.
2814         * cli/cli-decode.h (boolean_enums): Declare.
2815         * cli/cli-option.c: New file.
2816         * cli/cli-option.h: New file.
2817         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2818         factored out from ...
2819         (parse_cli_boolean_value(const char *)): ... this.
2820         (is_unlimited_literal): Change parameter type to pointer to
2821         pointer.  Adjust and advance ARG pointer.
2822         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2823         (parse_cli_var_enum): New, factored out from ...
2824         (do_set_command): ... this.  Adjust.
2825         * cli/cli-setshow.h (parse_cli_boolean_value)
2826         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2827         (parse_cli_var_enum): Declare.
2828         * cli/cli-utils.c: Include "cli/cli-option.h".
2829         (get_ulongest): New.
2830         * cli/cli-utils.h (get_ulongest): Declare.
2831         (check_for_argument): New overloads.
2832         * maint-test-options.c: New file.
2833
2834 2019-06-13  Pedro Alves  <palves@redhat.com>
2835
2836         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2837         parse a range if "-" is at the end of the string.
2838
2839 2019-06-13  Pedro Alves  <palves@redhat.com>
2840
2841         * cli/cli-setshow.c (parse_auto_binary_operation)
2842         (parse_cli_boolean_value): Don't allow "o".
2843
2844 2019-06-13  Pedro Alves  <palves@redhat.com>
2845
2846         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2847         * NEWS: Mention maint test-settings KIND.
2848         * maint-test-settings.c: New file.
2849
2850 2019-06-13  Pedro Alves  <palves@redhat.com>
2851
2852         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2853         completer.
2854         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2855         "set" completers.
2856
2857 2019-06-13  Pedro Alves  <palves@redhat.com>
2858
2859         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2860         after item.
2861
2862 2019-06-13  Pedro Alves  <palves@redhat.com>
2863
2864         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2865
2866 2019-06-13  Pedro Alves <palves@redhat.com>
2867
2868         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2869         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2870         call.
2871         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2872         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2873         calls.
2874         (check_for_argument): Skip spaces after argument.
2875
2876 2019-06-13  Pedro Alves  <palves@redhat.com>
2877
2878         * thread.c (thread_apply_command): Adjust TID parsing.
2879         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2880         detected before end of string.
2881         (tid_is_in_list): Error out if LIST is invalid.
2882
2883 2019-06-13  Pedro Alves  <palves@redhat.com>
2884
2885         * completer.c (complete_line_internal_1): Rewind completion word
2886         point.
2887         (completion_tracker::advance_custom_word_point_by): Change
2888         parameter type to int.
2889         * completer.h (completion_tracker::advance_custom_word_point_by):
2890         Likewise.
2891
2892 2019-06-13  Pedro Alves  <palves@redhat.com>
2893
2894         * completer.c (advance_to_completion_word): Handle delimiters.
2895
2896 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2897
2898         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2899
2900 2019-06-11  Tom Tromey  <tom@tromey.com>
2901
2902         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2903         (xmalloc_failed): Move to alloc.c.
2904         * alloc.c: New file.
2905         * Makefile.in (COMMON_SFILES): Add alloc.c.
2906
2907 2019-06-11  Tom Tromey  <tom@tromey.com>
2908
2909         * nat/linux-waitpid.c: Don't include server.h.
2910         (linux_debug): Remove.
2911         (my_waitpid): Update.
2912
2913 2019-06-11  Tom Tromey  <tromey@adacore.com>
2914
2915         * infcall.c (_initialize_infcall): Remove trailing newline from
2916         help.
2917         * user-regs.c (_initialize_user_regs): Remove trailing newline
2918         from help.
2919         * typeprint.c (_initialize_typeprint): Remove trailing newline
2920         from help.
2921         * reverse.c (_initialize_reverse): Remove trailing newlines from
2922         help.
2923         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2924         from help.
2925         * language.c (add_set_language_command): Remove trailing newline
2926         from help.
2927         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2928         help.
2929         * disasm.c (_initialize_disasm): Remove trailing newline from
2930         help.
2931         * top.c (init_main): Remove trailing newline from help.
2932         * interps.c (_initialize_interpreter): Remove trailing newline
2933         from help.
2934         * btrace.c (_initialize_btrace): Remove trailing newlines from
2935         help.
2936         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2937         from help.
2938         * python/python.c (_initialize_python): Remove trailing newline
2939         from help.
2940         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2941         help.
2942         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2943         from help.  Reformat some text.
2944         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2945         from help.
2946         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2947         newline from help.
2948
2949 2019-06-11  Tom Tromey  <tromey@adacore.com>
2950
2951         * darwin-nat.c (darwin_decode_exception_message)
2952         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2953
2954 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2955
2956         * valops.c (value_slice): Check for not allocated or not
2957         associated values.
2958
2959 2019-06-10  Tom de Vries  <tdevries@suse.de>
2960
2961         PR gdb/24618
2962         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2963         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2964         invalid.
2965
2966 2019-06-10  Tom de Vries  <tdevries@suse.de>
2967
2968         PR gdb/24611
2969         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2970         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2971
2972 2019-06-10  Tom de Vries  <tdevries@suse.de>
2973
2974         PR symtab/24545
2975         * symtab.c (struct demangled_name_entry): Add language field.
2976         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2977         static minimal symbol".  Set and use language field.
2978
2979 2019-06-10  Tom Tromey  <tromey@adacore.com>
2980
2981         * ada-lang.c (_initialize_ada_language): Update help text.
2982
2983 2019-06-10  Tom Tromey  <tromey@adacore.com>
2984
2985         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2986         with a newline.
2987         * guile/guile.c (handle_boot_error): Don't end warning with a
2988         newline.
2989         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2990         warning with a newline.
2991         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2992         newline.
2993         (s12z_frame_cache): Likewise.
2994         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2995         a newline.
2996         * solib-svr4.c (disable_probes_interface): Don't end warning with
2997         a newline.
2998         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2999         newline.
3000         * python/python.c (do_finish_initialization): Don't end warning
3001         with a newline.
3002
3003 2019-06-10  Tom Tromey  <tom@tromey.com>
3004
3005         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3006         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3007         gdbpy_enter.
3008
3009 2019-06-10  Tom Tromey  <tromey@adacore.com>
3010
3011         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3012         data.
3013         (elf_new_init): Don't call stabsread_new_init.
3014         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3015         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3016         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3017
3018 2019-06-10  Tom de Vries  <tdevries@suse.de>
3019
3020         PR symtab/16264
3021         PR symtab/24517
3022         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3023
3024 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3025
3026         * source.c (find_and_open_source): Also rewrite relative file
3027         names.
3028
3029 2019-04-26  Amos Bird  <amosbird@gmail.com>
3030
3031         * annotate.c (annotate_thread_exited): Add "thread-exited"
3032         annotation.
3033
3034 2019-06-06  Tom Tromey  <tromey@adacore.com>
3035
3036         * maint.h (class scoped_command_stats): Use
3037         DISABLE_COPY_AND_ASSIGN.
3038         <print_time>: New method.
3039         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3040         print_time.
3041         (scoped_command_stats::print_time): New method.
3042
3043 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3044
3045         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3046         instructions of lengths 6 or 8 bytes.
3047
3048 2019-06-04  Pedro Alves  <palves@redhat.com>
3049
3050         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3051
3052         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3053         * breakpoint.c (condition_completer): Likewise.
3054         * cli/cli-dump.c (scan_expression): Likewise.
3055         * common/filestuff.c (mkdir_recursive): Likewise.
3056         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3057         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3058         (gdb_abspath): Likewise.
3059         * compile/compile-cplus-types.c
3060         (compile_cplus_instance::decl_name): Likewise.
3061         * completer.c (complete_explicit_location):
3062         (signal_completer, reg_or_group_completer_1): Likewise.
3063         * cp-support.c (cp_remove_params_if_any): Likewise.
3064         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3065         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3066         * infcmd.c (strip_bg_char): Likewise.
3067         * linespec.c (copy_token_string): Likewise.
3068         * mi/mi-main.c (output_cores): Likewise.
3069         * psymtab.c (psymtab_search_name):
3070         * symfile.c (test_set_ext_lang_command): Likewise.
3071         * target.c (target_fileio_read_stralloc): Likewise.
3072         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3073         * value.c (complete_internalvar): Likewise.
3074
3075 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3076
3077         Add objfile property to gdb.Type.
3078         * NEWS: Mention Python API addition.
3079         * python/py-type.c (typy_get_objfile): New method.
3080
3081 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3082
3083         * NEWS: Mention the new set|show style [title|highlight].
3084         Mention changes to "show style", "help" and "apropos".
3085
3086 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3087
3088         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3089         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3090         instead of print_help_for_command.
3091         (print_doc_of_command): New function.
3092         (help_list): Add 'apropos -v word' suggestion.
3093         (print_help_for_command): Style the command name using title style.
3094         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3095         (_initialize_cli_cmds): Describe -v in apropos_command help.
3096
3097 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3098
3099         * cli/cli-style.h (cli_style_option): Add name in constructor,
3100         add m_name class member, add constructor with intensity,
3101         add name class function.
3102         (cli_style_option::add_setshow_commands): Remove name argument.
3103         (highlight_style, title_style): New styles.
3104         * cli/cli-style.c (do_show): New function that shows a style
3105         characteristic styling the style name with itself.
3106         (set_style_name): New function.
3107         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3108         Update all callers according to the changes in cli/cli-style.h.
3109         * utils.h (fputs_highlighted): New function.
3110         * utils.c (fputs_highlighted): Likewise.
3111
3112 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3113
3114         * NEWS: Mention new pipe command and new convenience variables.
3115
3116 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3117
3118         * cli/cli-cmds.c (pipe_command): New function.
3119         (_initialize_cli_cmds): Call add_com for pipe_command.
3120         Define | as an alias for pipe.
3121         (exit_status_set_internal_vars): New function.
3122         (shell_escape): Call exit_status_set_internal_vars.
3123         cli/cli-decode.c (find_command_name_length): Recognize | as
3124         a single character command.
3125
3126 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3127
3128         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3129         top.c (execute_command_to_ui_file): New function, mostly a copy
3130         of execute_command_to_string.
3131         (execute_command_to_string): Implement by calling
3132         execute_command_to_ui_file.
3133
3134 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3135
3136         * top.h (saved_command_line): Remove declaration.
3137         * top.c (previous_saved_command_line, previous_repeat_arguments):
3138         New variables.
3139         (saved_command_line): Make static, define together with other
3140         'repeat variables'.
3141         (dont_repeat): Clear repeat_arguments.
3142         (repeat_previous, get_saved_command_line, save_command_line):
3143         New functions.
3144         (gdb_init): Initialize saved_command_line
3145         and previous_saved_command_line.
3146         * main.c (captured_main_1): Remove saved_command_line initialization.
3147         * event-top.c (handle_line_of_input): Update to use
3148         the new 'repeat' related functions instead of direct access to
3149         saved_command_line.
3150         * command.h (repeat_previous, get_saved_command_line,
3151         save_command_line): New declarations.
3152         (dont_repeat): Add comment.
3153
3154 2019-05-30  Tom Tromey  <tromey@adacore.com>
3155
3156         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3157         Fix comment.
3158         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3159
3160 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3161
3162         PR cli/24587
3163         * completer.c (complete): Initialize variable word.
3164
3165 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3166
3167         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3168         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3169         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3170         'body' is NULL to the outter 'if', protecting the '!is_define'
3171         situation as well.
3172
3173 2019-05-29  Tom Tromey  <tromey@adacore.com>
3174
3175         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3176         (dwarf_unknown): New function.
3177         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3178         (dwarf_type_encoding_name): Use dwarf_unknown.
3179
3180 2019-05-29  Tom Tromey  <tromey@adacore.com>
3181
3182         PR c++/20020:
3183         * cp-valprint.c (cp_print_value_fields): Call
3184         cp_print_static_field inside "try".
3185
3186 2019-05-29  Tom Tromey  <tromey@adacore.com>
3187
3188         * inflow.c (struct terminal_info): Add default operator=.
3189         * configure: Rebuild.
3190         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3191         -Wdeprecated-copy-dtor, -Wredundant-move.
3192
3193 2019-05-29  Tom Tromey  <tromey@adacore.com>
3194
3195         * NEWS: Add entry.
3196         * infcmd.c (print_return_value_1): Handle finish_print
3197         option.
3198         (show_print_finish): New function.
3199         (_initialize_infcmd): Add "set/show print finish" commands.
3200         * valprint.c (user_print_options): Initialize new member.
3201         * valprint.h (struct value_print_options) <finish_print>: New
3202         member.
3203
3204 2019-05-28  Tom Tromey  <tromey@adacore.com>
3205
3206         * ada-lang.c (ada_remove_Xbn_suffix)
3207         (find_old_style_renaming_symbol)
3208         (parse_old_style_renaming): Remove.
3209         (ada_find_renaming_symbol): Don't call
3210         find_old_style_renaming_symbol.
3211         (ada_is_renaming_symbol): Rename from
3212         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3213         bool.  Now static.
3214         (ada_read_var_value): Update and simplify.
3215         * ada-exp.y (write_var_or_type): Remove old code.
3216
3217 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3218
3219         * event-top.c: Remove include comment.
3220         * inflow.c (class scoped_ignore_sigttou): Move from here...
3221         * inflow.h (class scoped_ignore_sigttou): ...to here.
3222         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3223         * top.c:  Remove include comment.
3224
3225 2019-05-27  Tom Tromey  <tom@tromey.com>
3226
3227         * NEWS: Fix typo.
3228
3229 2019-05-22  Tom Tromey  <tromey@adacore.com>
3230
3231         * target.c (target_follow_exec): Constify parameter.
3232         * target-delegates.c: Rebuild.
3233         * remote.c (remote_target::follow_exec): Constify parameter.
3234         * infrun.c (follow_exec): Constify parameter.
3235         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3236         (target_follow_exec): Likewise.
3237
3238 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3239
3240         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3241         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3242
3243 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3244
3245         * NEWS: Add debugredirect and testsuite sections.
3246
3247 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3248
3249         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3250         target descriptions using exclusively floating point register name
3251         aliases.
3252
3253 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3254
3255         PR gdb/18644:
3256         * f-lang.c (build_fortran_types): Handle the case where
3257         gdbarch_floatformat_for_type returns a nullptr.
3258
3259 2019-05-21  Tom de Vries  <tdevries@suse.de>
3260
3261         PR cli/24587
3262         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3263
3264 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3265
3266         PR gdb/18644:
3267         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3268         16-byte floats.
3269         * i386-tdep.c (i386_floatformat_for_type): Use
3270         floatformats_ia64_quad for the 16-byte floating point component
3271         within a fortran 32-byte complex number.
3272
3273 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3274
3275         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3276         delete default constructor.
3277         (find_partial_die): Update to return const struct.
3278         (partial_die_parent_scope): Move variable declaration into scope
3279         of its use and change its type to auto.
3280         (guess_partial_die_structure_name): Likewise.
3281         (partial_die_info::fixup): Likewise.
3282
3283 2019-05-17  Tom Tromey  <tromey@adacore.com>
3284
3285         * source.c (find_and_open_source): Remove cast.
3286
3287 2019-05-17  Tom Tromey  <tromey@adacore.com>
3288
3289         * annotate.c (annotate_source): Make "filename" const.
3290         * annotate.h (annotate_source): Use const.
3291
3292 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3293
3294         * disasm.c (set_disassembler_options): Send errors to stderr.
3295
3296 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3297
3298         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3299         (cli_interp_base::set_logging): Check debug_redirect.
3300         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3301         * cli/cli-logging.c (debug_redirect): Add static variable.
3302         (pop_output_files): Add default param.
3303         (handle_redirections): Print debug setting.
3304         (show_logging_command): Likewise.
3305         (_initialize_cli_logging): Add debugredirect command.
3306         * interps.c (current_interp_set_logging): Add debug_redirect
3307         parameter.
3308         * interps.h (set_logging): Add debug_redirect parameter.
3309         (current_interp_set_logging): Likewise.
3310         * mi/mi-common.h: Likewise.
3311         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3312
3313 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3314             Tom Tromey  <tromey@adacore.com>
3315
3316         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3317         directly.
3318         * cli/cli-interp.h (make_logging_output): Remove declaration.
3319         * cli/cli-logging.c (make_logging_output): Remove function.
3320         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3321         directly.
3322         * ui-file.c (tee_file::tee_file): Remove bools.
3323         (tee_file::~tee_file): Remove deletes.
3324         * ui-file.h (tee_file): Remove bools.
3325
3326 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3327
3328         * mi/mi-cmds.h (mi_cmd_complete): New function.
3329         * mi/mi-main.c (mi_cmd_complete): Likewise.
3330         * mi/mi-cmds.c: Define new MI command -complete.
3331         * NEWS: Mention new -complete command.
3332
3333 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3334
3335         * completer.h (complete): New function.
3336         * completer.c (complete): Likewise.
3337         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3338         function defined in completer.h.
3339
3340 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3341
3342         * MAINTAINERS (Write After Approval): Add myself.
3343
3344 2019-05-17  Tom de Vries  <tdevries@suse.de>
3345
3346         PR gdb/24094
3347         * dwarf2read.c (struct cu_partial_die_info): New struct.
3348         (find_partial_die): Return cu_partial_die_info.
3349         (partial_die_parent_scope, guess_partial_die_structure_name)
3350         (partial_die_info::fixup): Handle new return type of find_partial_die.
3351
3352 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3353
3354         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3355         "std::string", simplifying the algorithm.
3356
3357 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3358
3359         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3360         (stap_static_probe_ops::get_probes): Likewise.
3361
3362 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3363
3364         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3365         '-')" and "else if".
3366         (stap_parse_single_operand): Join checks for
3367         "gdbarch_stap_parse_special_token_p" and
3368         "gdbarch_stap_parse_special_token" in the same "if" statement.
3369         Invert check when verifying for operation on register
3370         displacement.
3371
3372 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3373
3374         * stap-probe.c (stap_get_opcode): Update comment.
3375         (stap_get_expected_argument_type): Likewise.
3376         (handle_stap_probe): Likewise.
3377
3378 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3379
3380         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3381         return type to 'bool'.  Adjust comment.  Use 'bool' when
3382         appropriate.
3383         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3384         * stap-probe.c (stap_parse_argument_1): Likewise.
3385         (stap_is_operator): Likewise.
3386         (stap_is_generic_prefix): Likewise.
3387         (stap_is_register_prefix): Likewise.
3388         (stap_is_register_indirection_prefix): Likewise.
3389         (stap_is_integer_prefix): Likewise.
3390         (stap_generic_check_suffix): Likewise.
3391         (stap_check_integer_suffix): Likewise.
3392         (stap_check_register_suffix): Likewise.
3393         (stap_check_register_indirection_suffix): Likewise.
3394         (stap_parse_register_operand): Likewise.
3395         (stap_parse_single_operand): Likewise.
3396         (stap_parse_argument_1): Likewise.
3397         (stap_probe::get_argument_count): Likewise.
3398         (stap_is_operator): Likewise.
3399
3400 2019-05-16  Tom Tromey  <tromey@adacore.com>
3401
3402         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3403         keyword to foreach.
3404
3405 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3406
3407         * linux-thread-db.c (try_thread_db_load_1): Change return type
3408         to bool.
3409         (try_thread_db_load): Likewise.
3410         (try_thread_db_load_from_pdir_1): Likewise.
3411         (try_thread_db_load_from_pdir): Likewise.
3412         (try_thread_db_load_from_sdir): Likewise.
3413         (try_thread_db_load_from_dir): Likewise.
3414         (thread_db_load_search): Likewise.
3415         (has_libpthread): Likewise.
3416         (thread_db_load): Likewise.
3417
3418 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3419
3420         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3421         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3422         NULL, and complain/return if that's the case.
3423
3424 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3425
3426         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3427         (advance, posn, abstract_read_memory): New functions.
3428         [struct mem_read_abstraction]: New struct.
3429         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3430
3431 2019-05-14  Tom Tromey  <tromey@adacore.com>
3432
3433         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3434         value is not lval_memory.
3435
3436 2019-05-14  Tom Tromey  <tromey@adacore.com>
3437
3438         * solib.c (info_sharedlibrary_command): Style the file name.
3439
3440 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3441
3442         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3443         (aarch64_vnv_type): Likewise.
3444         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3445         * common/tdesc.c: Likewise.
3446         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3447         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3448         * features/aarch64-fpu.xml: Add ieee half view.
3449         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3450         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3451         * gdbtypes.h (struct builtin_type): Likewise.
3452         (struct objfile_type): Likewise.
3453
3454 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3455
3456         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3457         typo.
3458         * location.h (string_to_event_location): Likewise.
3459
3460 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3461
3462         GDB 8.3 released.
3463
3464 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3465
3466         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3467         New variable declaration.
3468         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3469         New variable.
3470         (print_one_breakpoint): Use ui_out::test_flags and new global
3471         variable to compute use_fixed_output.
3472         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3473         Remove.
3474         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3475         (mi_multi_location_breakpoint_output_fixed): Remove.
3476         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3477         new variable.
3478         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3479         fix_multi_location_breakpoint_output flag if version >= 3.
3480         * ui-out.h (enum ui_out_flag)
3481         <fix_multi_location_breakpoint_output>: New enumerator.
3482
3483 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3484
3485         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3486
3487 2019-05-10  Tom Tromey  <tromey@adacore.com>
3488
3489         * ada-lang.c (catch_ada_completer): New function.
3490         (_initialize_ada_language): Use it.
3491
3492 2019-05-10  Tom Tromey  <tromey@adacore.com>
3493
3494         * thread.c (print_thread_info): Make "requested_threads" const.
3495         * gdbthread.h (print_thread_info): Make "requested_threads"
3496         const.
3497         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3498         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3499
3500 2019-05-08  Tom Tromey  <tom@tromey.com>
3501
3502         * gdbtypes.c (objfile_type_data): Change type.
3503         (objfile_type, _initialize_gdbtypes): Update.
3504
3505 2019-05-08  Tom Tromey  <tom@tromey.com>
3506
3507         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3508         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3509         (_initialize_dwarf2_frame): Update.
3510
3511 2019-05-08  Tom Tromey  <tom@tromey.com>
3512
3513         * objc-lang.c (objc_objfile_data): Change type.
3514         (find_methods): Update.
3515         (_initialize_objc_lang): Remove.
3516
3517 2019-05-08  Tom Tromey  <tom@tromey.com>
3518
3519         * stabsread.c (rs6000_builtin_type_data): Change type.
3520         (rs6000_builtin_type, _initialize_stabsread): Update.
3521
3522 2019-05-08  Tom Tromey  <tom@tromey.com>
3523
3524         * mips-tdep.c (mips_pdr_data): Remove.
3525         (_initialize_mips_tdep): Update.
3526
3527 2019-05-08  Tom Tromey  <tom@tromey.com>
3528
3529         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3530         (hppa_init_objfile_priv_data, read_unwind_info)
3531         (find_unwind_entry, _initialize_hppa_tdep): Update.
3532
3533 2019-05-08  Tom Tromey  <tom@tromey.com>
3534
3535         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3536         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3537         on obstack.
3538         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3539
3540 2019-05-08  Tom Tromey  <tom@tromey.com>
3541
3542         * mdebugread.c (basic_type_data): Change type.
3543         (basic_type, _initialize_mdebugread): Update.
3544
3545 2019-05-08  Tom Tromey  <tom@tromey.com>
3546
3547         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3548
3549 2019-05-08  Tom Tromey  <tom@tromey.com>
3550
3551         * nto-tdep.c (nto_inferior_data_reg): Change type.
3552         (nto_inferior_data): Update.
3553         (nto_inferior_data_cleanup, nto_new_inferior_data)
3554         (_initialize_nto_tdep): Remove.
3555         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3556
3557 2019-05-08  Tom Tromey  <tom@tromey.com>
3558
3559         * ada-lang.c (struct ada_inferior_data): Add initializers.
3560         (ada_inferior_data): Change type.
3561         (ada_inferior_data_cleanup): Remove.
3562         (get_ada_inferior_data, ada_inferior_exit)
3563         (struct ada_pspace_data): Add initializers, destructor.
3564         (ada_pspace_data_handle): Change type.
3565         (get_ada_pspace_data): Update.
3566         (ada_pspace_data_cleanup): Remove.
3567
3568 2019-05-08  Tom Tromey  <tom@tromey.com>
3569
3570         * coffread.c (struct coff_symfile_info): Add initializers.
3571         (coff_objfile_data_key): Move lower.  Change type.
3572         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3573         Update.
3574         (coff_free_info): Remove.
3575
3576 2019-05-08  Tom Tromey  <tom@tromey.com>
3577
3578         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3579         (fbsd_pspace_data_handle): Move lower.  Change type.
3580         (get_fbsd_pspace_data): Update.
3581         (fbsd_pspace_data_cleanup): Remove.
3582         (_initialize_fbsd_tdep): Update.
3583
3584 2019-05-08  Tom Tromey  <tom@tromey.com>
3585
3586         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3587         (get_ada_tasks_pspace_data): Update.
3588         (ada_tasks_pspace_data_cleanup): Remove.
3589         (_initialize_tasks): Update.
3590         (ada_tasks_inferior_data_handle): Change type.
3591         (get_ada_tasks_inferior_data): Update.
3592         (ada_tasks_inferior_data_cleanup): Remove.
3593         (struct ada_tasks_pspace_data): Add initializers.
3594
3595 2019-05-08  Tom Tromey  <tom@tromey.com>
3596
3597         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3598         * symfile-debug.c (debug_sym_get_probes): Change type.
3599         * stap-probe.c (handle_stap_probe):
3600         (stap_static_probe_ops::get_probes): Change type.
3601         * probe.h (class static_probe_ops) <get_probes>: Change type.
3602         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3603         (parse_probes_in_pspace): Update.
3604         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3605         Update.
3606         (any_static_probe_ops::get_probes): Change type.
3607         * elfread.c (elfread_data): New typedef.
3608         (probe_key): Change type.
3609         (elf_get_probes): Likewise.  Update.
3610         (probe_key_free): Remove.
3611         (_initialize_elfread): Update.
3612         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3613         Change type.
3614         (dtrace_process_dof_probe, dtrace_process_dof)
3615         (dtrace_static_probe_ops::get_probe): Change type.
3616
3617 2019-05-08  Tom Tromey  <tom@tromey.com>
3618
3619         * xcoffread.c (struct xcoff_symfile_info): Rename from
3620         coff_symfile_info.  Add initializers.
3621         (xcoff_objfile_data_key): Move lower.  Change type.
3622         (XCOFF_DATA): Rewrite.
3623         (xcoff_free_info): Remove.
3624         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3625         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3626         (xcoff_initial_scan): Update.
3627
3628 2019-05-08  Tom Tromey  <tom@tromey.com>
3629
3630         * solib-svr4.c (struct svr4_info): Add initializers and
3631         destructor.
3632         <probes_table>: Now an htab_up.
3633         (solib_svr4_pspace_data): Change type.
3634         (free_probes_table): Simplify.
3635         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3636         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3637         (probes_table_remove_objfile_probes, register_solib_event_probe)
3638         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3639         (_initialize_svr4_solib): Update.
3640
3641 2019-05-08  Tom Tromey  <tom@tromey.com>
3642
3643         * remote.c (remote_pspace_data): Change type.
3644         (remote_pspace_data_cleanup): Remove.
3645         (get_remote_exec_file, set_pspace_remote_exec_file)
3646         (_initialize_remote): Update.
3647
3648 2019-05-08  Tom Tromey  <tom@tromey.com>
3649
3650         * breakpoint.c (breakpoint_objfile_key): Change type.
3651         (get_breakpoint_objfile_data): Update.
3652         (free_breakpoint_objfile_data): Remove.
3653         (_initialize_breakpoint): Update.
3654
3655 2019-05-08  Tom Tromey  <tom@tromey.com>
3656
3657         * linux-tdep.c (struct linux_info): Add initializers.
3658         (linux_inferior_data): Move.  Change type.
3659         (invalidate_linux_cache_inf): Update.
3660         (linux_inferior_data_cleanup): Remove.
3661         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3662
3663 2019-05-08  Tom Tromey  <tom@tromey.com>
3664
3665         * auxv.c (auxv_inferior_data): Move.  Change type.
3666         (auxv_inferior_data_cleanup): Remove.
3667         (invalidate_auxv_cache_inf): Rewrite.
3668         (get_auxv_inferior_data, _initialize_auxv): Update.
3669
3670 2019-05-08  Tom Tromey  <tom@tromey.com>
3671
3672         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3673         (symfile_debug_objfile_data_key): Change type.
3674         (symfile_debug_installed, debug_qf_has_symbols)
3675         (debug_qf_find_last_source_symtab)
3676         (debug_qf_forget_cached_source_info)
3677         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3678         (debug_qf_print_stats, debug_qf_dump)
3679         (debug_qf_expand_symtabs_for_function)
3680         (debug_qf_expand_all_symtabs)
3681         (debug_qf_expand_symtabs_with_fullname)
3682         (debug_qf_map_matching_symbols)
3683         (debug_qf_expand_symtabs_matching)
3684         (debug_qf_find_pc_sect_compunit_symtab)
3685         (debug_qf_map_symbol_filenames)
3686         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3687         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3688         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3689         (debug_sym_read_linetable, debug_sym_relocate): Update.
3690         (symfile_debug_free_objfile): Remove.
3691         (install_symfile_debug_logging, _initialize_symfile_debug):
3692         Update.
3693
3694 2019-05-08  Tom Tromey  <tom@tromey.com>
3695
3696         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3697         allocate_on_obstack.
3698         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3699         (get_dwarf2_per_objfile): Update.
3700         (set_dwarf2_per_objfile): Remove.
3701         (dwarf2_has_info, dwarf2_get_section_info): Update.
3702         (dwarf2_free_objfile): Remove.
3703         (_initialize_dwarf2_read): Update.
3704
3705 2019-05-08  Tom Tromey  <tom@tromey.com>
3706
3707         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3708         initializers.
3709         <unsupported_script_warning_printed,
3710         script_not_found_warning_printed>: Now bool.
3711         (auto_load_pspace_data): Change type.
3712         (~auto_load_pspace_info): Rename from
3713         auto_load_pspace_data_cleanup.
3714         (get_auto_load_pspace_data, init_loaded_scripts_info)
3715         (clear_section_scripts, maybe_print_unsupported_script_warning)
3716         (maybe_print_script_not_found_warning, _initialize_auto_load):
3717         Update.
3718
3719 2019-05-08  Tom Tromey  <tom@tromey.com>
3720
3721         * objfiles.c (objfile_pspace_info): Add destructor and
3722         initializers.
3723         (objfiles_pspace_data): Change type.
3724         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3725         (get_objfile_pspace_data): Update.
3726         (objfiles_bfd_data): Change type.
3727         (get_objfile_bfd_data): Update.
3728         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3729
3730 2019-05-08  Tom Tromey  <tom@tromey.com>
3731
3732         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3733         Change type.
3734         (get_catch_syscall_inferior_data): Update.
3735         (catch_syscall_inferior_data_cleanup): Remove.
3736         (_initialize_break_catch_syscall): Update.
3737
3738 2019-05-08  Tom Tromey  <tom@tromey.com>
3739
3740         * inflow.c (struct terminal_info): Add destructor and
3741         initializers.
3742         (inflow_inferior_data): Change type.
3743         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3744         (get_inflow_inferior_data, inflow_inferior_exit)
3745         (swap_terminal_info, _initialize_inflow): Update.
3746
3747 2019-05-08  Tom Tromey  <tom@tromey.com>
3748
3749         * target-dcache.c (target_dcache_cleanup): Remove.
3750         (target_dcache_aspace_key): Change type.
3751         (target_dcache_init_p, target_dcache_invalidate)
3752         (target_dcache_get, target_dcache_get_or_init)
3753         (_initialize_target_dcache): Update.
3754         * dcache.h (struct dcache_deleter): New.
3755
3756 2019-05-08  Tom Tromey  <tom@tromey.com>
3757
3758         * symtab.c (struct symbol_cache): Add destructor and
3759         initializers.
3760         (symbol_cache_key): Move.  Change type.
3761         (make_symbol_cache, free_symbol_cache): Remove.
3762         (get_symbol_cache): Update.
3763         (symbol_cache_cleanup): Remove.
3764         (ALL_PSPACES, symbol_cache_flush)
3765         (maintenance_print_symbol_cache)
3766         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3767         Update.
3768
3769 2019-05-08  Tom Tromey  <tom@tromey.com>
3770
3771         * symtab.c (struct main_info): Add destructor and initializers.
3772         (main_progspace_key): Move.  Change type.
3773         (get_main_info): Update.
3774         (main_info_cleanup): Remove.
3775         (_initialize_symtab): Update.
3776
3777 2019-05-08  Tom Tromey  <tom@tromey.com>
3778
3779         * registry.h (DECLARE_REGISTRY): Define the _key class.
3780
3781 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3782
3783         * NEWS: Merge two 'New commands' sections.
3784
3785 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3786
3787         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3788         parameter and use Ada language definition instead.
3789         (ada_val_print_ptr): Remove unused language parameter.
3790         (ada_val_print_num): Remove language parameter and use Ada language
3791         definition instead.
3792         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3793         parameter.
3794         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3795         parameter and use Ada language definition instead.
3796         (ada_val_print_1): Update all ada_val_print_xxx calls.
3797         Remove language parameter.
3798         (ada_val_print): Update ada_val_print_1 call.
3799
3800 2019-05-08  Tom Tromey  <tromey@adacore.com>
3801
3802         * remote.c (remote_hw_watchpoint_limit)
3803         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3804         Now static.
3805
3806 2019-05-08  Tom Tromey  <tromey@adacore.com>
3807
3808         * maint.c (_initialize_maint_cmds): Move initialization code to
3809         remote.c.
3810         (watchdog, show_watchdog): Move to remote.c.
3811         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3812         "watchdog" static.
3813         (_initialize_remote): Move initialization code from maint.c.
3814         * defs.h (watchdog): Don't declare.
3815
3816 2019-05-08  Tom Tromey  <tromey@adacore.com>
3817
3818         * tui/tui-interp.c: Include main.h.
3819         * interps.c: Include main.h.
3820         * main.h (interpreter_p): Declare.
3821         * defs.h (interpreter_p): Don't declare.
3822
3823 2019-05-08  Tom Tromey  <tromey@adacore.com>
3824
3825         * dwarf2loc.c: Include dwarf2read.h.
3826         * defs.h (read_unsigned_leb128): Don't declare.
3827         * dwarf2read.h (read_unsigned_leb128): Declare.
3828
3829 2019-05-08  Tom Tromey  <tromey@adacore.com>
3830
3831         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3832         method.
3833
3834 2019-05-08  Tom Tromey  <tromey@adacore.com>
3835
3836         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3837         when no wrap column is set.
3838
3839 2019-05-08  Tom Tromey  <tromey@adacore.com>
3840
3841         * c-lang.c (c_get_string): Handle non-C-style arrays.
3842
3843 2019-05-08  Tom Tromey  <tromey@adacore.com>
3844
3845         * typeprint.c (print_offset_data::update): Print the bit offset,
3846         not the number of bits remaining.
3847
3848 2019-05-08  Tom Tromey  <tromey@adacore.com>
3849
3850         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3851         padding at end of comment.
3852
3853 2019-05-08  Tom Tromey  <tromey@adacore.com>
3854
3855         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3856         Compare main types.
3857
3858 2019-05-06  Tom Tromey  <tom@tromey.com>
3859
3860         * common/scoped_mmap.c: Include common-defs.h.
3861         * common/scoped_mmap.h: Don't include config.h.
3862
3863 2019-05-04  Tom Tromey  <tom@tromey.com>
3864
3865         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3866         (struct aarch64_call_info): Add initializers.
3867         <si>: Now a std::vector.
3868         (pass_on_stack, aarch64_push_dummy_call): Update.
3869
3870 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3871             Tom Tromey  <tom@tromey.com>
3872
3873         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3874         (ppc_threads): Now a std::vector.  Now static.
3875         (hwdebug_find_thread_points_by_tid)
3876         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3877         Update.
3878
3879 2019-05-04  Tom Tromey  <tom@tromey.com>
3880
3881         * arc-tdep.c (arc_tdesc_init): Return bool.
3882
3883 2019-05-04  Tom Tromey  <tom@tromey.com>
3884
3885         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3886         Use gdb_assert_not_reached.
3887
3888 2019-05-04  Tom Tromey  <tom@tromey.com>
3889
3890         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3891         "false".
3892
3893 2019-05-04  Tom Tromey  <tom@tromey.com>
3894
3895         * arc-tdep.c (arc_tdesc_init): Use bool.
3896
3897 2019-05-04  Tom Tromey  <tom@tromey.com>
3898
3899         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3900
3901 2019-05-04  Tom Tromey  <tom@tromey.com>
3902
3903         * cli/cli-cmds.c (valid_command_p): Return bool.
3904
3905 2019-05-04  Tom Tromey  <tom@tromey.com>
3906
3907         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3908         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3909
3910 2019-05-04  Raul Tambre  <raul@tambre.ee>
3911
3912         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3913         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3914         operator for comparison.
3915
3916 2019-05-04  Tom Tromey  <tom@tromey.com>
3917
3918         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3919         (lookup_partial_symbol, print_partial_symbols)
3920         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3921         (psymbol_compare): Update.
3922         (add_psymbol_to_bcache): Clear the entire psymbol.
3923         (maintenance_check_psymtabs): Update.
3924         * psympriv.h (struct partial_symbol): Don't derive from
3925         general_symbol_info.
3926         <obj_section, unrelocated_address, address,
3927         set_unrelocated_address>: Update.
3928         <ginfo>: New member.
3929         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3930         (debug_names::write_psymbols): Update.
3931
3932 2019-05-04  Tom de Vries  <tdevries@suse.de>
3933
3934         * contrib/cc-with-tweaks.sh: Support -n arg.
3935
3936 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3937
3938         * corelow.c (core_target::detach): Ensure frame cache and
3939         register caches are cleared.
3940         inferior.c (exit_inferior_1): Likewise.
3941
3942 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3943             Tom Tromey  <tom@tromey.com>
3944
3945         * dictionary.c (collate_pending_symbols_by_language): Remove
3946         "struct" from foreach.
3947         * symtab.c (lookup_global_symbol_from_objfile)
3948         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3949         foreach.
3950         * ser-tcp.c (net_open): Remove "struct" from foreach.
3951         * objfiles.c (objfile_relocate, objfile_rebase)
3952         (objfile_has_symbols): Remove "struct" from foreach.
3953         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3954         from foreach.
3955         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3956         foreach.
3957         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3958         "struct" from foreach.
3959         * ada-lang.c (create_excep_cond_exprs)
3960         (ada_exception_catchpoint_cond_string): Remove "struct" from
3961         foreach.
3962
3963 2019-05-03  Tom Tromey  <tromey@adacore.com>
3964
3965         * ada-exp.y (convert_char_literal): Check suffix of each
3966         enumerator.
3967
3968 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3969
3970         PR ada/21406:
3971         * ada-exp.y (yywrap): Don't define.
3972         * ada-lex.l (%option): Add noyywrap
3973         (yywrap): Remove.
3974
3975 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3976
3977         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3978         _WIN32_WINNT to the XP level, unless already defined to a higher
3979         level.
3980
3981         * unittests/parse-connection-spec-selftests.c:
3982         * ser-tcp.c:
3983         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3984         override.
3985
3986         * symfile.c (find_separate_debug_file): Remove colon from the
3987         drive spec of DOS/Windows file names of the target, so that the
3988         file name produced from DEBUGDIR and the target's directory will
3989         be valid on DOS/Windows systems.
3990
3991 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3992
3993         * rust-lang.c (val_print_struct): Handle printing structures
3994         containing strings.
3995
3996 2019-05-02  Tom Tromey  <tromey@adacore.com>
3997
3998         * valarith.c (_initialize_valarith): Remove.
3999
4000 2019-05-01  Tom Tromey  <tromey@adacore.com>
4001
4002         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4003         bitfields.
4004
4005 2019-05-01  Tom Tromey  <tromey@adacore.com>
4006
4007         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4008         for big-endian copies.
4009
4010 2019-04-30  Ali Tamur  <tamur@google.com>
4011         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4012         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4013         (read_3_bytes): New function.
4014
4015 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4016
4017         * windows-nat.c (main_thread_id): Delete.
4018         (handle_output_debug_string): Replace main_thread_id by
4019         current_event.dwThreadId.
4020         (fake_create_process): Likewise.
4021         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4022         Do not set main_thread_id.
4023         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4024         current_event.dwThreadId.
4025         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4026
4027 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4028
4029         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4030         Use current_event.dwThreadId instead of main_thread_id.
4031
4032 2019-04-30  Tom Tromey  <tromey@adacore.com>
4033
4034         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4035         (create_excep_cond_exprs): Iterate over program spaces.
4036         (ada_exception_catchpoint_cond_string): Examine all minimal
4037         symbols for exception types.
4038
4039 2019-04-30  Tom Tromey  <tromey@adacore.com>
4040
4041         PR c++/24470:
4042         * dwarf2read.c (process_structure_scope): Handle case where type
4043         has template parameters but no symbol was created.
4044
4045 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4046             Chris January  <chris.january@arm.com>
4047
4048         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4049         qualifier.
4050         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4051
4052 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4053
4054         * f-typeprint.c (f_print_type): Update rules for printing
4055         whitespace.
4056         (f_type_print_varspec_suffix): Likewise.
4057
4058 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4059             Chris January  <chris.january@arm.com>
4060
4061         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4062         function arguments.
4063
4064 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4065
4066         * f-lang.c (build_fortran_types): Change name of void type to
4067         lower case.
4068         * f-typeprint.c (f_type_print_base): Print the name of the void
4069         type, rather than a fixed string.
4070         * f-valprint.c (f_decorations): Use lower case void string.
4071
4072 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4073             Chris January  <chris.january@arm.com>
4074
4075         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4076         types for Fortran.
4077
4078 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4079             Chris January  <chris.january@arm.com>
4080             David Lecomber  <david.lecomber@arm.com>
4081
4082         * f-exp.y (BINOP_INTRINSIC): New token.
4083         (exp): New parser rule handling BINOP_INTRINSIC.
4084         (f77_keywords): Add new builtin procedures.
4085         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4086         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4087         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4088         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4089         (print_unop_subexp_f): New function.
4090         (print_binop_subexp_f): New function.
4091         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4092         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4093         (dump_subexp_body_f): Likewise.
4094         (operator_check_f): Likewise.
4095         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4096         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4097
4098 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4099
4100         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4101         UNOP_KIND.
4102         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4103         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4104         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4105         (operator_length_f): New fuction.
4106         (print_subexp_f): New function.
4107         (op_name_f): New function.
4108         (dump_subexp_body_f): New function.
4109         (operator_check_f): New function.
4110         (exp_descriptor_f): Replace standard expression handling functions
4111         with new functions.
4112         * gdb/fortran-operator.def: New file.
4113         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4114         * gdb/std-operator.def: Remove UNOP_KIND.
4115
4116 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4117
4118         * std-operator.def: Remove unbalanced, stray double quote
4119         character.
4120
4121 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4122             Chris January  <chris.january@arm.com>
4123             Daniel Everett  <daniel.everett@arm.com>
4124             Nick Forrington  <nick.forrington@arm.com>
4125             Richard Bunt  <richard.bunt@arm.com>
4126
4127         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4128         of depth when printing anonymous structs or unions.
4129         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4130         Don't print either the top-level value, or the children if the
4131         max-depth is exceeded.
4132         (ppscm_print_children): When printing the key of a map, allow one
4133         extra level of depth.
4134         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4135         print either the top-level value, or the children if the max-depth
4136         is exceeded.
4137         (print_children): When printing the key of a map, allow one extra
4138         level of depth.
4139         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4140         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4141         (user_print_options): Initialise max_depth field.
4142         (val_print_scalar_or_string_type_p): New function.
4143         (val_print): Check to see if the max depth has been reached.
4144         (val_print_check_max_depth): Define new function.
4145         (show_print_max_depth): New function.
4146         (_initialize_valprint): Add 'print max-depth' option.
4147         * valprint.h (struct value_print_options) <max_depth>: New field.
4148         (val_print_check_max_depth): Declare new function.
4149         * NEWS: Document new feature.
4150
4151 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4152
4153         * ada-lang.c (ada_language_defn): Initialise new field.
4154         * c-lang.c (c_is_string_type_p): New function.
4155         (c_language_defn): Initialise new field.
4156         (cplus_language_defn): Initialise new field.
4157         (asm_language_defn): Initialise new field.
4158         (minimal_language_defn): Initialise new field.
4159         * c-lang.h (c_is_string_type_p): Declare new function.
4160         * d-lang.c (d_language_defn): Initialise new field.
4161         * f-lang.c (f_is_string_type_p): New function.
4162         (f_language_defn): Initialise new field.
4163         * go-lang.c (go_is_string_type_p): New function.
4164         (go_language_defn): Initialise new field.
4165         * language.c (default_is_string_type_p): New function.
4166         (unknown_language_defn): Initialise new field.
4167         (auto_language_defn): Initialise new field.
4168         * language.h (struct language_defn) <la_is_string_type_p>: New
4169         member variable.
4170         (default_is_string_type_p): Declare new function.
4171         * m2-lang.c (m2_language_defn): Initialise new field.
4172         * objc-lang.c (objc_language_defn): Initialise new field.
4173         * opencl-lang.c (opencl_language_defn): Initialise new field.
4174         * p-lang.c (pascal_is_string_type_p): New function.
4175         (pascal_language_defn): Initialise new field.
4176         * rust-lang.c (rust_is_string_type_p): New function.
4177         (rust_language_defn): Initialise new field.
4178
4179 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4180
4181         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4182         New field.
4183         * ada-lang.c (ada_language_defn): Initialise new field.
4184         * c-lang.c (c_language_defn): Likewise.
4185         (cplus_language_defn): Likewise.
4186         (asm_language_defn): Likewise.
4187         (minimal_language_defn): Likewise.
4188         * d-lang.c (d_language_defn): Likewise.
4189         * f-lang.c (f_language_defn): Likewise.
4190         * go-lang.c (go_language_defn): Likewise.
4191         * language.c (unknown_language_defn): Likewise.
4192         (auto_language_defn): Likewise.
4193         * m2-lang.c (m2_language_defn): Likewise.
4194         * objc-lang.c (objc_language_defn): Likewise.
4195         * opencl-lang.c (opencl_language_defn): Likewise.
4196         * p-lang.c (pascal_language_defn): Likewise.
4197         * rust-lang.c (rust_language_defn): Likewise.
4198
4199 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4200
4201         * ada-lang.c (ada_is_character_type): Change return type to bool.
4202         (ada_is_string_type): Likewise.
4203         * ada-lang.h (ada_is_character_type): Update declaration
4204         (ada_is_string_type): Likewise.
4205
4206 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4207
4208         Support style in 'frame|thread apply'
4209
4210         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4211         * record.c (record_start, record_stop): Update callers of
4212         execute_command_to_string with false.
4213         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4214         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4215         methods.
4216         (class string_file): New constructor with term_out parameter.
4217         Override methods term_out and can_emit_style_escape.  New member
4218         term_out.
4219         (class stdio_file): Override can_emit_style_escape.
4220         (class tee_file): Override term_out and can_emit_style_escape.
4221         * utils.h (can_emit_style_escape): Remove.
4222         * utils.c (can_emit_style_escape): Likewise.
4223         Update all callers of can_emit_style_escape (SOMESTREAM) to
4224         SOMESTREAM->can_emit_style_escape.
4225         * source-cache.c (source_cache::get_source_lines): Likewise.
4226         * stack.c (frame_apply_command_count): Call execute_command_to_string
4227         passing the term_out characteristic of the current gdb_stdout.
4228         * thread.c (thr_try_catch_cmd): Likewise.
4229         * top.c (execute_command_to_string): pass term_out parameter
4230         to construct the string_file for the command output.
4231         * ui-file.c (term_cli_styling): New function (most code moved
4232         from utils.c can_emit_style_escape).
4233         (string_file::string_file, string_file::can_emit_style_escape,
4234         stdio_file::can_emit_style_escape, tee_file::term_out,
4235         tee_file::can_emit_style_escape): New functions.
4236
4237 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4238
4239         * NEWS: Mention the new set|show may-call-functions.
4240         * infcall.c (may_call_functions_p): New variable.
4241         (show_may_call_functions_p): New function.
4242         (call_function_by_hand_dummy): Throws an error if not
4243         may-call-functions.
4244         (_initialize_infcall): Call add_setshow_boolean_cmd for
4245         may-call-functions.
4246
4247 2019-04-25  Keith Seitz  <keiths@redhat.com>
4248
4249         PR c++/24367
4250         * cp-support.c (inspect_type): Don't attempt substitutions
4251         of symbol with the same name.
4252
4253 2019-04-25  Tom Tromey  <tromey@adacore.com>
4254
4255         PR gdb/24475:
4256         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4257         static.
4258
4259 2019-04-25  Tom Tromey  <tromey@adacore.com>
4260
4261         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4262         rvalue reference.
4263         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4264         (gdb_xml_parser::parse): Use std::move.
4265         * python/python-internal.h (gdbpy_convert_exception): Take a const
4266         reference.
4267         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4268         std::move.
4269         * python/py-utils.c (gdbpy_convert_exception): Take a const
4270         reference.
4271         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4272         Use std::move.
4273         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4274         Use std::move.
4275         * mi/mi-main.c (mi_print_exception): Take a const reference.
4276         * main.c (handle_command_errors): Take a const reference.
4277         * linespec.c (parse_linespec): Use std::move.
4278         * infcall.c (run_inferior_call): Use std::move.
4279         (call_function_by_hand_dummy): Use std::move.
4280         * exec.c (try_open_exec_file): Use std::move.
4281         * exceptions.h (exception_print, exception_fprintf)
4282         (exception_print_same): Update.
4283         * exceptions.c (print_exception, exception_print)
4284         (exception_fprintf, exception_print_same): Change parameters to
4285         const reference.
4286         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4287         * common/new-op.c: Use std::move.
4288         * common/common-exceptions.h (struct gdb_exception): Add move
4289         constructor.
4290         (struct gdb_exception_error, struct gdb_exception_quit, struct
4291         gdb_quit_bad_alloc): Change constructor to move constructor.
4292         (throw_exception): Change parameter to rvalue reference.
4293         * common/common-exceptions.c (throw_exception): Take rvalue
4294         reference.
4295         * cli/cli-interp.c (safe_execute_command): Use std::move.
4296         * breakpoint.c (insert_bp_location, location_to_sals): Use
4297         std::move.
4298
4299 2019-04-25  Tom Tromey  <tromey@adacore.com>
4300
4301         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4302         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4303         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4304         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4305         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4306         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4307         guile/scm-value.c: Use unpack.
4308         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4309         gdbscm_gdb_exception.
4310         (gdbscm_throw_gdb_exception): Likewise.
4311         (struct gdbscm_gdb_exception): New.
4312         (unpack): New function.
4313         (gdbscm_wrap): Use unpack.
4314
4315 2019-04-25  Tom Tromey  <tromey@adacore.com>
4316
4317         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4318         (gdb_rl_callback_handler): Use std::move.
4319         * common/common-exceptions.h (struct gdb_exception): Add move
4320         assignment operator.
4321         (throw_exception_sjlj): Change "exception" to const reference.
4322         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4323         (throw_exception_sjlj): Change "exception" to const reference.
4324
4325 2019-04-25  Tom Tromey  <tromey@adacore.com>
4326
4327         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4328         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4329         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4330         Update.
4331         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4332         Update.
4333         * mi/mi-interp.c (mi_interp::exec): Update.
4334         * linespec.c (parse_linespec): Update.
4335         * infcall.c (run_inferior_call): Update.
4336         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4337         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4338         (gdbscm_lookup_global_symbol): Update.
4339         * guile/scm-param.c (gdbscm_parameter_value): Update.
4340         * guile/scm-frame.c (gdbscm_frame_read_register)
4341         (gdbscm_frame_read_var): Update.
4342         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4343         * exec.c (try_open_exec_file): Update.
4344         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4345         (gdb_rl_callback_handler): Update.
4346         * common/common-exceptions.h (exception_none): Don't declare.
4347         * common/common-exceptions.c (exception_none): Don't define.
4348         (struct catcher) <exception>: Update.
4349         * cli/cli-interp.c (safe_execute_command): Update.
4350         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4351
4352 2019-04-25  Ali Tamur  <tamur@google.com>
4353
4354         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4355         (read_attribute_value): Likewise.
4356         (dwarf2_read_addr_index): Update comment.
4357         (read_str_index): Add DW_FORM_strx.
4358         (dwarf2_string_attr): Likewise.
4359         (dwarf2_const_value_attr): Likewise.
4360         (dump_die_shallow): Likewise.
4361         (dwarf2_fetch_constant_bytes): Likewise.
4362         (skip_form_bytes): Likewise.
4363         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4364
4365 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4366
4367         PR corefiles/11608
4368         PR corefiles/18187
4369         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4370         OFFSET.  Verify if current mapping contains an ELF header.
4371         (linux_find_memory_regions_full): Adjust call to
4372         dump_mapping_p.
4373
4374 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4375             Kang Li <kanglictf@gmail.com>
4376
4377         PR gdb/21600
4378
4379         * dwarf2-frame.c (read_initial_length): Be consistent about using
4380         unsigned representation of length.
4381         (decode_frame_entry_1): Likewise.  Check for wraparound of
4382         end pointer as well as buffer overflow.
4383
4384 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4385
4386         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4387         "vq".
4388
4389 2019-04-24  Tom Tromey  <tromey@adacore.com>
4390
4391         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4392
4393 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4394
4395         * s12z-tdep.c (s12z_unwind_pc): Delete.
4396         (s12z_unwind_sp): Delete.
4397         (s12z_gdbarch_init): Don't register deleted functions with
4398         gdbarch.
4399
4400 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4401
4402         * rl78-tdep.c (rl78_unwind_sp): Delete.
4403         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4404
4405 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4406
4407         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4408         (xstormy16_unwind_pc): Delete.
4409         (xstormy16_dummy_id): Delete.
4410         (xstormy16_gdbarch_init): Don't register deleted functions with
4411         gdbarch.
4412
4413 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4414
4415         * vax-tdep.c (vax_unwind_pc): Delete.
4416         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4417
4418 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4419
4420         * v850-tdep.c (v850_unwind_sp): Delete.
4421         (v850_unwind_pc): Delete.
4422         (v850_dummy_id): Delete.
4423         (v850_gdbarch_init): Don't register deleted functions with
4424         gdbarch.
4425
4426 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4427
4428         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4429         (tilegx_unwind_pc): Delete.
4430         (tilegx_unwind_dummy_id): Delete.
4431         (tilegx_gdbarch_init): Don't register deleted functions with
4432         gdbarch.
4433
4434 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4435
4436         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4437         (tic6x_dummy_id): Delete.
4438         (tic6x_gdbarch_init): Don't register deleted functions with
4439         gdbarch.
4440
4441 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4442
4443         * sparc-tdep.c (sparc_unwind_pc): Delete.
4444         (sparc32_gdbarch_init): Don't register deleted function with
4445         gdbarch.
4446
4447 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4448
4449         * sh-tdep.c (sh_unwind_sp): Delete.
4450         (sh_unwind_pc): Delete.
4451         (sh_dummy_id): Delete.
4452         (sh_gdbarch_init): Don't register deleted functions with
4453         gdbarch.
4454
4455 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4456
4457         * score-tdep.c (score_unwind_sp): Delete.
4458         (score_unwind_pc): Delete.
4459         (score_dummy_id): Delete.
4460         (score_gdbarch_init): Don't register deleted functions with
4461         gdbarch.
4462
4463 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4464
4465         * rx-tdep.c (rx_unwind_pc): Delete.
4466         (rx_unwind_sp): Delete.
4467         (rx_dummy_id): Delete.
4468         (rx_gdbarch_init): Don't register deleted functions with
4469         gdbarch.  Update comment.
4470
4471 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4472
4473         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4474         (rs6000_dummy_id): Delete.
4475         (rs6000_gdbarch_init): Don't register deleted functions with
4476         gdbarch.
4477
4478 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4479
4480         * or1k-tdep.c (or1k_dummy_id): Delete.
4481         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4482
4483 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4484
4485         * nios2-tdep.c (nios2_dummy_id): Delete.
4486         (nios2_unwind_sp): Delete.
4487         (nios2_gdbarch_init): Don't register deleted functions with
4488         gdbarch.
4489
4490 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4491
4492         * nds32-tdep.c (nds32_dummy_id): Delete.
4493         (nds32_unwind_pc): Delete.
4494         (nds32_unwind_sp): Delete.
4495         (nds32_gdbarch_init): Don't register deleted functions with
4496         gdbarch.
4497
4498 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4499
4500         * msp430-tdep.c (msp430_unwind_pc): Delete.
4501         (msp430_unwind_sp): Delete.
4502         (msp430_dummy_id): Delete.
4503         (msp430_gdbarch_init): Don't register deleted functions with
4504         gdbarch.
4505
4506 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4507
4508         * moxie-tdep.c (moxie_unwind_sp): Delete.
4509         (moxie_unwind_pc): Delete.
4510         (moxie_dummy_id): Delete.
4511         (moxie_gdbarch_init): Don't register deleted functions with
4512         gdbarch.
4513
4514 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4515
4516         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4517         (mn10300_unwind_pc): Delete.
4518         (mn10300_unwind_sp): Delete.
4519         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4520         mn10300_unwind_sp.
4521         (mn10300_frame_unwind_init): Don't register deleted functions with
4522         gdbarch.
4523
4524 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4525
4526         * mep-tdep.c (mep_unwind_pc): Delete.
4527         (mep_unwind_sp): Delete.
4528         (mep_dummy_id): Delete.
4529         (mep_gdbarch_init): Don't register deleted functions with
4530         gdbarch.
4531
4532 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4533
4534         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4535         (m68hc11_unwind_sp): Delete.
4536         (m68hc11_gdbarch_init): Don't register deleted functions with
4537         gdbarch.
4538
4539 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4540
4541         * m32r-tdep.c (m32r_unwind_sp): Delete.
4542         (m32r_unwind_pc): Delete.
4543         (m32r_dummy_id): Delete.
4544         (m32r_gdbarch_init): Don't register deleted functions with
4545         gdbarch.
4546
4547 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4548
4549         * m32c-tdep.c (m32c_unwind_pc): Delete.
4550         (m32c_unwind_sp): Delete.
4551         (m32c_dummy_id): Delete.
4552         (m32c_gdbarch_init): Don't register deleted functions with
4553         gdbarch.
4554
4555 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4556
4557         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4558         (lm32_unwind_pc): Delete.
4559         (lm32_dummy_id): Delete.
4560         (lm32_gdbarch_init): Don't register deleted functions with
4561         gdbarch.
4562
4563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4564
4565         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4566         (iq2000_unwind_pc): Delete.
4567         (iq2000_dummy_id): Delete.
4568         (iq2000_gdbarch_init): Don't register deleted functions with
4569         gdbarch.
4570
4571 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4572
4573         * nds32-tdep.c (nds32_type_align): Delete.
4574         (nds32_push_dummy_call): Use type_align instead.
4575
4576 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4577
4578         * arm-tdep.c (arm_type_align): Only handle vector override case.
4579         (arm_push_dummy_call): Use type_align.
4580         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4581
4582 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4583
4584         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4585         case.
4586         (pass_on_stack): Use type_align.
4587         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4588         function.
4589
4590 2019-04-23  Tom Tromey  <tromey@adacore.com>
4591
4592         * dwarf2read.c (line_header::file_name_at): Remove unused
4593         overload.
4594
4595 2019-04-23  Tom de Vries  <tdevries@suse.de>
4596
4597         PR gdb/24438
4598         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4599         invocation.
4600
4601
4602 2019-03-27  Ali Tamur  <tamur@google.com>
4603
4604         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4605         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4606         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4607         (dwarf_expr_context::get_addr_index): Likewise
4608         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4609         (symbol_needs_eval_context::get_addr_index): Likewise
4610         (disassemble_dwarf_expression): Add DW_OP_addrx
4611         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4612         (read_cutu_die_from_dwo): Update comment
4613         (skip_one_die): Add DW_FORM_addrx
4614         (read_attribute_value): Likewise
4615         (var_decode_location): Add DW_OP_addrx
4616         (dwarf2_const_value_attr): Add DW_FORM_addrx
4617         (dump_die_shallow): Likewise
4618         (dwarf2_fetch_constant_bytes): Likewise
4619         (decode_locdesc): Add DW_OP_addrx
4620         (skip_form_bytes): Add DW_FORM_addrx
4621
4622 2019-04-22  Ali Tamur  <tamur@google.com>
4623
4624         * MAINTAINERS (Write After Approval): Add self.
4625
4626 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4627
4628         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4629         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4630         (open_symbol_file_object): Likewise.
4631         (svr4_default_sos): Add info parameter.
4632         (svr4_read_so_list): Likewise.
4633         (svr4_current_sos_direct): Adjust functions calls to pass down
4634         info.
4635         (svr4_current_sos_1): Add info parameter.
4636         (svr4_current_sos): Call get_svr4_info, pass info down to
4637         svr4_current_sos_1.
4638         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4639         get_svr4_info.
4640         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4641         get_svr4_info.
4642         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4643         to get_svr4_info.
4644         (probes_table_remove_objfile_probes): Likewise.
4645         (register_solib_event_probe): Add info parameter.
4646         (solist_update_incremental): Pass info parameter down to
4647         svr4_read_so_list.
4648         (disable_probes_interface): Add info parameter.
4649         (svr4_handle_solib_event): Pass current_program_space to
4650         get_svr4_info.  Adjust disable_probes_interface cleanup.
4651         (svr4_create_probe_breakpoints): Add info parameter, pass it
4652         down to register_solib_event_probe.
4653         (svr4_create_solib_event_breakpoints): Add info parameter,
4654         pass it down to svr4_create_probe_breakpoints.
4655         (enable_break): Pass info down to
4656         svr4_create_solib_event_breakpoints.
4657         (svr4_solib_create_inferior_hook): Pass current_program_space to
4658         get_svr4_info.
4659         (svr4_clear_solib): Likewise.
4660
4661 2019-04-22  Pedro Alves  <palves@redhat.com>
4662
4663         * solib-svr4.c (svr4_free_objfile_observer): New.
4664         (probe_and_action::objfile): New field.
4665         (probes_table_htab_remove_objfile_probes)
4666         (probes_table_remove_objfile_probes): New functions.
4667         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4668         in the new probe_and_action.  Don't store the probe in 'lookup'.
4669         (svr4_create_probe_breakpoints): Pass objfile to
4670         register_solib_event_probe.
4671         (_initialize_svr4_solib): Register a free_objfile observer.
4672
4673 2019-04-19  Tom Tromey  <tom@tromey.com>
4674
4675         * common/queue.h: Remove.
4676
4677 2019-04-19  Tom Tromey  <tom@tromey.com>
4678
4679         * event-loop.c: Don't include "common/queue.h".
4680
4681 2019-04-19  Tom Tromey  <tom@tromey.com>
4682
4683         * remote.c (remote_target): Use delete.
4684         * remote-notif.h: Include <list>, not "common/queue.h".
4685         (notif_client_p): Remove typedef.
4686         (remote_notif_state): Add constructor, destructor, initializer.
4687         <notif_queue>: Now a std::list.
4688         (remote_notif_state_xfree): Don't declare.
4689         * remote-notif.c (remote_notif_process, handle_notification)
4690         (remote_notif_state_allocate): Update.
4691         (~remote_notif_state): Rename from remote_notif_state_xfree.
4692
4693 2019-04-19  Tom Tromey  <tom@tromey.com>
4694
4695         * symfile.c (reread_symbols): Update.
4696         * objfiles.c (objfile_register_static_link)
4697         (objfile_lookup_static_link): Update
4698         (~objfile) Don't delete static_links.
4699         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4700
4701 2019-04-19  Tom Tromey  <tom@tromey.com>
4702
4703         * type-stack.h (struct type_stack) <insert>: Constify string.
4704         * type-stack.c (type_stack::insert): Constify string.
4705         * gdbtypes.h (lookup_template_type): Update.
4706         (address_space_name_to_int): Update.
4707         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4708         const.
4709         (lookup_template_type): Make name const.
4710         * c-exp.y: Update rules.
4711         (lex_one_token, classify_name, classify_inner_name)
4712         (c_print_token): Update.
4713         * p-exp.y: Update rules.
4714         (yylex): Update.
4715         * f-exp.y: Update rules.
4716         (yylex): Update.
4717         * d-exp.y: Update rules.
4718         (lex_one_token, classify_name, classify_inner_name): Update.
4719         * parse.c (write_dollar_variable, copy_name): Return std::string.
4720         * parser-defs.h (copy_name): Change return type.
4721         * m2-exp.y: Update rules.
4722         (yylex): Update.
4723         * go-exp.y (lex_one_token): Update.
4724         Update rules.
4725         (classify_unsafe_function, classify_packaged_name)
4726         (classify_name, yylex): Update.
4727
4728 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4729
4730         * configure.ac: add --enable-source-highlight switch.
4731         * configure: Regenerate.
4732         * top.c (print_gdb_version): plumb --enable-source-highlight
4733         status to "show configuration".
4734
4735 2019-04-19  Tom Tromey  <tromey@adacore.com>
4736
4737         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4738         Check ADA_TYPE_P.
4739         (empty_record, ada_template_to_fixed_record_type_1)
4740         (template_to_static_fixed_type)
4741         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4742         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4743         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4744         macros.
4745
4746 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4747
4748         PR symtab/24423:
4749         * source.c (print_source_lines_base): Advance "iter" when a
4750         control character is seen.
4751
4752 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4753
4754         * inferior.h (struct infcall_suspend_state_deleter):
4755         Catch exception in destructor to avoid crash.
4756
4757 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4758
4759         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4760         close to the add_com "shell".
4761
4762 2019-04-18  Tom Tromey  <tromey@adacore.com>
4763
4764         * process-stratum-target.h (class process_stratum_target)
4765         <stratum>: Add "final".
4766
4767 2019-04-17  Tom Tromey  <tromey@adacore.com>
4768
4769         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4770         against nullptr before use.
4771
4772 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4773
4774         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4775
4776 2019-04-17  Jim Wilson  <jimw@sifive.com>
4777             Andrew Burgess  <andrew.burgess@embecosm.com>
4778
4779         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4780         code read might fail, assume 4-byte breakpoint in that case.
4781
4782 2019-04-15  Leszek Swirski  <leszeks@google.com>
4783
4784         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4785         rather than a hand-rolled POD check when checking for forced MEMORY
4786         classification.
4787
4788 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4789
4790         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4791         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4792         function.
4793         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4794         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4795         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4796         declaration.
4797
4798 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4799
4800         * aarch64-linux-nat.c
4801         (aarch64_linux_nat_target::thread_architecture): Add override.
4802         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4803         each VQ.
4804
4805 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4806
4807         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4808
4809 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4810
4811         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4812         target types of size 96-bits, add some additional comments, and
4813         check that the builtin type we found was the correct size.
4814
4815 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4816
4817         * utils.c (prompt_for_continue): Don't restore the styling at the
4818         end, as applied_style has the wrong value.  This fixes styling in
4819         long lists of file names that are interrupted by the "Continue?"
4820         prompt.
4821
4822 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4823
4824         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4825         * c-lang.c (c_language_defn): Likewise.
4826         (cplus_language_defn): Likewise.
4827         (asm_language_defn): Likewise.
4828         (minimal_language_defn): Likewise.
4829         * d-lang.c (d_language_defn): Likewise.
4830         * f-lang.c (f_language_defn): Likewise.
4831         * go-lang.c (go_language_defn): Likewise.
4832         * language.c (unknown_language_defn): Likewise.
4833         (auto_language_defn): Likewise.
4834         * language.h (struct language_defn): Remove la_magic field.
4835         (LANG_MAGIC): Delete.
4836         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4837         * objc-lang.c (objc_language_defn): Likewise.
4838         * opencl-lang.c (opencl_language_defn): Likewise.
4839         * p-lang.c (pascal_language_defn): Likewise.
4840         * rust-lang.c (rust_language_defn): Likewise.
4841
4842 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4843
4844         * riscv-tdep.c (riscv_type_align): New function.
4845         (riscv_type_alignment): Delete.
4846         (riscv_arg_location): Use 'type_align'.
4847         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4848
4849 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4850
4851         * gdbtypes.c (type_align): A struct with no non-static fields also
4852         has alignment of 1.
4853
4854 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4855
4856         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4857         component to 0.
4858         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4859         member.
4860         (riscv_struct_info::analyse): New implementation using new
4861         analyse_inner member function.
4862         (riscv_struct_info::field_offset): New member function.
4863         (riscv_struct_info::m_offsets): New member variable.
4864         (riscv_struct_info::analyse_inner): New private member function,
4865         takes the old implementation of riscv_struct_info::analyse but
4866         extended to track field offsets.
4867         (riscv_call_arg_struct): Update the struct folding special cases
4868         to handle cases where empty C++ structs, which are non-zero
4869         length, are found.
4870         (riscv_arg_location): Initialise the length of each location, a
4871         non-zero length now indicates the location is in use.
4872         (riscv_push_dummy_call): Allow for the first location having a
4873         non-zero offset when setting up arguments.
4874         (riscv_return_value): Likewise, but for return values.
4875
4876 2019-04-11  Tom Tromey  <tromey@adacore.com>
4877
4878         * utils.c (internal_vproblem): Make "msg" const.
4879
4880 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4881
4882         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4883         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4884         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4885         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4886
4887 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4888
4889         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4890         function.
4891         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4892         of amd64_collect_native_gregset.
4893         (amd64_linux_nat_target::store_registers): Likewise.
4894
4895 2019-04-10  Tom Tromey  <tom@tromey.com>
4896
4897         * symtab.c (lookup_global_symbol_from_objfile)
4898         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4899         * objfiles.h (class separate_debug_iterator): New.
4900         (class separate_debug_range): New.
4901         (struct objfile) <separate_debug_objfiles>: New method.
4902         (objfile_separate_debug_iterate): Don't declare.
4903         * objfiles.c (separate_debug_iterator::operator++): Rename from
4904         objfile_separate_debug_iterate.
4905         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4906         iterator.
4907         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4908         iterator.
4909
4910 2019-04-10  Tom Tromey  <tom@tromey.com>
4911
4912         * symfile.c (reread_symbols): Remove old comment.
4913         * objfiles.c (free_all_objfiles): Fix a typo.
4914
4915 2019-04-10  Tom Tromey  <tom@tromey.com>
4916
4917         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4918         * minsyms.c (lookup_minimal_symbol): Use foreach.
4919         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4920         (lookup_minimal_symbol_solib_trampoline): Likewise.
4921         * symfile.c (reread_symbols): Use foreach.
4922
4923 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4924             Tom Tromey  <tromey@adacore.com>
4925
4926         PR rust/24414:
4927         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4928         (rust_lex_int_test): Change "value" to be LONGEST.
4929         (rust_lex_tests): Add test for long integer literal.
4930
4931 2019-04-09  Tom Tromey  <tromey@adacore.com>
4932
4933         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4934         to bool.
4935         (extended_remote_target::attach): Update.
4936         (remote_target::remote_notice_new_inferior): Update.
4937         (remote_target::add_current_inferior_and_thread): Update.
4938         * inferior.c (exit_inferior_1): Use "false".
4939         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4940
4941 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4942
4943         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4944         the "start" command.
4945
4946 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4947
4948         * python/py-inferior.c (infpy_thread_from_thread_handle):
4949         Adjust comments to reflect renaming of thread_from_thread_handle
4950         to thread_from_handle.  Adjust keywords.  Fix type error message.
4951         (inferior_object_methods): Add thread_from_handle.  Retain
4952         thread_from_thread_handle, but mark it as deprecated.
4953
4954 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4955
4956         * gdbthread.h (find_thread_by_handle): Revise declaration.
4957         * thread.c (find_thread_by_handle): Likewise.  Adjust
4958         implementation too.
4959         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4960         support for buffer objects as handles.
4961
4962 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4963
4964         * python/py-infthread.c (thpy_thread_handle): New function.
4965         (thread_object_methods): Register thpy_thread_handle.
4966
4967 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4968
4969         * gdbthread.h (thread_to_thread_handle): Declare.
4970         * thread.c (gdbtypes.h): Include.
4971         (thread_to_thread_handle): New function.
4972
4973         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4974         (target_thread_info_to_thread_handle): Declare.
4975         * target.c (target_thread_info_to_thread_handle): New function.
4976         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4977         * target-delegates.c: Regenerate.
4978
4979         * linux-thread-db.c (class thread_db_target): Add method
4980         thread_info_to_thread_handle.
4981         (thread_db_target::thread_info_to_thread_handle): Define.
4982         * remote.c (class remote_target): Add new method
4983         thread_info_to_thread_handle.
4984         (remote_target::thread_info_to_thread_handle): Define.
4985
4986 2019-04-08  Pedro Alves  <palves@redhat.com>
4987
4988         * common/common-exceptions.c (throw_exception): Don't create
4989         named object to throw; throw directly.
4990         (throw_it): Likewise.  Don't initialize gdb_exception::message
4991         here, with new; pass FMT and AP to the ctor instead.
4992         * common/common-exceptions.h: Include <string>.
4993         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4994         const char *, va_list)): New ctor.  Use std::make_shared.
4995         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4996         errors)): Delete.
4997         (gdb_exception_error::gdb_exception_error(enum errors, const char
4998         *, va_list)): New.
4999         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5000         Add assertion.
5001         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5002         errors)): Delete.
5003         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5004         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5005         Add assertion.
5006
5007 2019-04-08  Tom Tromey  <tom@tromey.com>
5008
5009         * valops.c (value_rtti_indirect_type): Replace throw_exception
5010         with throw.
5011         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5012         with throw.
5013         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5014         throw.
5015         * target.c (target_translate_tls_address): Replace throw_exception
5016         with throw.
5017         * stack.c (frame_apply_command_count): Replace throw_exception
5018         with throw.
5019         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5020         throw.
5021         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5022         with throw.
5023         * rs6000-tdep.c (rs6000_frame_cache)
5024         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5025         * remote.c: Replace throw_exception with throw.
5026         * record-full.c (record_full_message, record_full_wait_1)
5027         (record_full_restore): Replace throw_exception with throw.
5028         * record-btrace.c:
5029         (get_thread_current_frame_id, record_btrace_start_replaying)
5030         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5031         (cmd_record_btrace_start): Replace throw_exception with throw.
5032         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5033         throw.
5034         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5035         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5036         * linespec.c:
5037         (find_linespec_symbols): Replace throw_exception with throw.
5038         * infrun.c (displaced_step_prepare, resume): Replace
5039         throw_exception with throw.
5040         * infcmd.c (post_create_inferior): Replace throw_exception with
5041         throw.
5042         * inf-loop.c (inferior_event_handler): Replace throw_exception
5043         with throw.
5044         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5045         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5046         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5047         (get_prev_frame_always, get_frame_pc_if_available)
5048         (get_frame_address_in_block_if_available, get_frame_language):
5049         Replace throw_exception with throw.
5050         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5051         throw_exception with throw.
5052         * eval.c (fetch_subexp_value, evaluate_var_value)
5053         (evaluate_funcall, evaluate_subexp_standard): Replace
5054         throw_exception with throw.
5055         * dwarf2loc.c (call_site_find_chain)
5056         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5057         Replace throw_exception with throw.
5058         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5059         with throw.
5060         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5061         throw.
5062         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5063         * completer.c (complete_line_internal): Replace throw_exception
5064         with throw.
5065         * compile/compile-object-run.c (compile_object_run): Replace
5066         throw_exception with throw.
5067         * cli/cli-script.c (process_next_line): Replace throw_exception
5068         with throw.
5069         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5070         (btrace_enable, btrace_maint_update_pt_packets): Replace
5071         throw_exception with throw.
5072         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5073         throw_exception with throw.
5074         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5075         throw_exception with throw.
5076         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5077         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5078         * aarch64-tdep.c (aarch64_make_prologue_cache)
5079         (aarch64_make_stub_cache): Replace throw_exception with throw.
5080
5081 2019-04-08  Tom Tromey  <tom@tromey.com>
5082
5083         * common/common-exceptions.c (throw_exception): Rename from
5084         throw_exception_cxx.  Remove old copy.  Make argument const.
5085         (throw_it): Create and throw exception objects directly.
5086         * common/common-exceptions.h (throw_exception): Make argument
5087         const.
5088         (struct gdb_exception_error): Add constructor.
5089         (struct gdb_exception_quit): Add constructor.
5090
5091 2019-04-08  Tom Tromey  <tom@tromey.com>
5092
5093         * common/common-exceptions.h (exception_rethrow): Don't declare.
5094         (TRY_SJLJ): Update comment.
5095         (TRY, CATCH, END_CATCH): Remove.
5096         * common/common-exceptions.c (exception_rethrow): Remove.
5097
5098 2019-04-08  Tom Tromey  <tom@tromey.com>
5099
5100         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5101         Remove.
5102         (gdb_exception_error): Rename from
5103         gdb_exception_RETURN_MASK_ERROR.
5104         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5105         (gdb_quit_bad_alloc): Update.
5106         * aarch64-tdep.c: Update.
5107         * ada-lang.c: Update.
5108         * ada-typeprint.c: Update.
5109         * ada-valprint.c: Update.
5110         * amd64-tdep.c: Update.
5111         * arch-utils.c: Update.
5112         * break-catch-throw.c: Update.
5113         * breakpoint.c: Update.
5114         * btrace.c: Update.
5115         * c-varobj.c: Update.
5116         * cli/cli-cmds.c: Update.
5117         * cli/cli-interp.c: Update.
5118         * cli/cli-script.c: Update.
5119         * common/common-exceptions.c: Update.
5120         * common/new-op.c: Update.
5121         * common/selftest.c: Update.
5122         * compile/compile-c-symbols.c: Update.
5123         * compile/compile-cplus-symbols.c: Update.
5124         * compile/compile-object-load.c: Update.
5125         * compile/compile-object-run.c: Update.
5126         * completer.c: Update.
5127         * corelow.c: Update.
5128         * cp-abi.c: Update.
5129         * cp-support.c: Update.
5130         * cp-valprint.c: Update.
5131         * darwin-nat.c: Update.
5132         * disasm-selftests.c: Update.
5133         * dtrace-probe.c: Update.
5134         * dwarf-index-cache.c: Update.
5135         * dwarf-index-write.c: Update.
5136         * dwarf2-frame-tailcall.c: Update.
5137         * dwarf2-frame.c: Update.
5138         * dwarf2loc.c: Update.
5139         * dwarf2read.c: Update.
5140         * eval.c: Update.
5141         * event-loop.c: Update.
5142         * event-top.c: Update.
5143         * exec.c: Update.
5144         * f-valprint.c: Update.
5145         * fbsd-tdep.c: Update.
5146         * frame-unwind.c: Update.
5147         * frame.c: Update.
5148         * gdbtypes.c: Update.
5149         * gnu-v3-abi.c: Update.
5150         * guile/guile-internal.h: Update.
5151         * guile/scm-block.c: Update.
5152         * guile/scm-breakpoint.c: Update.
5153         * guile/scm-cmd.c: Update.
5154         * guile/scm-disasm.c: Update.
5155         * guile/scm-frame.c: Update.
5156         * guile/scm-lazy-string.c: Update.
5157         * guile/scm-math.c: Update.
5158         * guile/scm-param.c: Update.
5159         * guile/scm-ports.c: Update.
5160         * guile/scm-pretty-print.c: Update.
5161         * guile/scm-symbol.c: Update.
5162         * guile/scm-symtab.c: Update.
5163         * guile/scm-type.c: Update.
5164         * guile/scm-value.c: Update.
5165         * i386-linux-tdep.c: Update.
5166         * i386-tdep.c: Update.
5167         * inf-loop.c: Update.
5168         * infcall.c: Update.
5169         * infcmd.c: Update.
5170         * infrun.c: Update.
5171         * jit.c: Update.
5172         * language.c: Update.
5173         * linespec.c: Update.
5174         * linux-fork.c: Update.
5175         * linux-nat.c: Update.
5176         * linux-tdep.c: Update.
5177         * linux-thread-db.c: Update.
5178         * main.c: Update.
5179         * mi/mi-cmd-break.c: Update.
5180         * mi/mi-cmd-stack.c: Update.
5181         * mi/mi-interp.c: Update.
5182         * mi/mi-main.c: Update.
5183         * objc-lang.c: Update.
5184         * p-valprint.c: Update.
5185         * parse.c: Update.
5186         * ppc-linux-tdep.c: Update.
5187         * printcmd.c: Update.
5188         * python/py-arch.c: Update.
5189         * python/py-breakpoint.c: Update.
5190         * python/py-cmd.c: Update.
5191         * python/py-finishbreakpoint.c: Update.
5192         * python/py-frame.c: Update.
5193         * python/py-framefilter.c: Update.
5194         * python/py-gdb-readline.c: Update.
5195         * python/py-inferior.c: Update.
5196         * python/py-infthread.c: Update.
5197         * python/py-lazy-string.c: Update.
5198         * python/py-linetable.c: Update.
5199         * python/py-objfile.c: Update.
5200         * python/py-param.c: Update.
5201         * python/py-prettyprint.c: Update.
5202         * python/py-progspace.c: Update.
5203         * python/py-record-btrace.c: Update.
5204         * python/py-record.c: Update.
5205         * python/py-symbol.c: Update.
5206         * python/py-type.c: Update.
5207         * python/py-unwind.c: Update.
5208         * python/py-utils.c: Update.
5209         * python/py-value.c: Update.
5210         * python/python.c: Update.
5211         * record-btrace.c: Update.
5212         * record-full.c: Update.
5213         * remote-fileio.c: Update.
5214         * remote.c: Update.
5215         * riscv-tdep.c: Update.
5216         * rs6000-aix-tdep.c: Update.
5217         * rs6000-tdep.c: Update.
5218         * rust-exp.y: Update.
5219         * rust-lang.c: Update.
5220         * s390-tdep.c: Update.
5221         * selftest-arch.c: Update.
5222         * solib-dsbt.c: Update.
5223         * solib-frv.c: Update.
5224         * solib-spu.c: Update.
5225         * solib-svr4.c: Update.
5226         * solib.c: Update.
5227         * sparc64-linux-tdep.c: Update.
5228         * stack.c: Update.
5229         * symfile-mem.c: Update.
5230         * symmisc.c: Update.
5231         * target.c: Update.
5232         * thread.c: Update.
5233         * top.c: Update.
5234         * tracefile-tfile.c: Update.
5235         * tui/tui.c: Update.
5236         * typeprint.c: Update.
5237         * unittests/cli-utils-selftests.c: Update.
5238         * unittests/parse-connection-spec-selftests.c: Update.
5239         * valops.c: Update.
5240         * valprint.c: Update.
5241         * value.c: Update.
5242         * varobj.c: Update.
5243         * windows-nat.c: Update.
5244         * x86-linux-nat.c: Update.
5245         * xml-support.c: Update.
5246
5247 2019-04-08  Tom Tromey  <tom@tromey.com>
5248
5249         * xml-support.c: Use C++ exception handling.
5250         * x86-linux-nat.c: Use C++ exception handling.
5251         * windows-nat.c: Use C++ exception handling.
5252         * varobj.c: Use C++ exception handling.
5253         * value.c: Use C++ exception handling.
5254         * valprint.c: Use C++ exception handling.
5255         * valops.c: Use C++ exception handling.
5256         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5257         handling.
5258         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5259         * typeprint.c: Use C++ exception handling.
5260         * tui/tui.c: Use C++ exception handling.
5261         * tracefile-tfile.c: Use C++ exception handling.
5262         * top.c: Use C++ exception handling.
5263         * thread.c: Use C++ exception handling.
5264         * target.c: Use C++ exception handling.
5265         * symmisc.c: Use C++ exception handling.
5266         * symfile-mem.c: Use C++ exception handling.
5267         * stack.c: Use C++ exception handling.
5268         * sparc64-linux-tdep.c: Use C++ exception handling.
5269         * solib.c: Use C++ exception handling.
5270         * solib-svr4.c: Use C++ exception handling.
5271         * solib-spu.c: Use C++ exception handling.
5272         * solib-frv.c: Use C++ exception handling.
5273         * solib-dsbt.c: Use C++ exception handling.
5274         * selftest-arch.c: Use C++ exception handling.
5275         * s390-tdep.c: Use C++ exception handling.
5276         * rust-lang.c: Use C++ exception handling.
5277         * rust-exp.y: Use C++ exception handling.
5278         * rs6000-tdep.c: Use C++ exception handling.
5279         * rs6000-aix-tdep.c: Use C++ exception handling.
5280         * riscv-tdep.c: Use C++ exception handling.
5281         * remote.c: Use C++ exception handling.
5282         * remote-fileio.c: Use C++ exception handling.
5283         * record-full.c: Use C++ exception handling.
5284         * record-btrace.c: Use C++ exception handling.
5285         * python/python.c: Use C++ exception handling.
5286         * python/py-value.c: Use C++ exception handling.
5287         * python/py-utils.c: Use C++ exception handling.
5288         * python/py-unwind.c: Use C++ exception handling.
5289         * python/py-type.c: Use C++ exception handling.
5290         * python/py-symbol.c: Use C++ exception handling.
5291         * python/py-record.c: Use C++ exception handling.
5292         * python/py-record-btrace.c: Use C++ exception handling.
5293         * python/py-progspace.c: Use C++ exception handling.
5294         * python/py-prettyprint.c: Use C++ exception handling.
5295         * python/py-param.c: Use C++ exception handling.
5296         * python/py-objfile.c: Use C++ exception handling.
5297         * python/py-linetable.c: Use C++ exception handling.
5298         * python/py-lazy-string.c: Use C++ exception handling.
5299         * python/py-infthread.c: Use C++ exception handling.
5300         * python/py-inferior.c: Use C++ exception handling.
5301         * python/py-gdb-readline.c: Use C++ exception handling.
5302         * python/py-framefilter.c: Use C++ exception handling.
5303         * python/py-frame.c: Use C++ exception handling.
5304         * python/py-finishbreakpoint.c: Use C++ exception handling.
5305         * python/py-cmd.c: Use C++ exception handling.
5306         * python/py-breakpoint.c: Use C++ exception handling.
5307         * python/py-arch.c: Use C++ exception handling.
5308         * printcmd.c: Use C++ exception handling.
5309         * ppc-linux-tdep.c: Use C++ exception handling.
5310         * parse.c: Use C++ exception handling.
5311         * p-valprint.c: Use C++ exception handling.
5312         * objc-lang.c: Use C++ exception handling.
5313         * mi/mi-main.c: Use C++ exception handling.
5314         * mi/mi-interp.c: Use C++ exception handling.
5315         * mi/mi-cmd-stack.c: Use C++ exception handling.
5316         * mi/mi-cmd-break.c: Use C++ exception handling.
5317         * main.c: Use C++ exception handling.
5318         * linux-thread-db.c: Use C++ exception handling.
5319         * linux-tdep.c: Use C++ exception handling.
5320         * linux-nat.c: Use C++ exception handling.
5321         * linux-fork.c: Use C++ exception handling.
5322         * linespec.c: Use C++ exception handling.
5323         * language.c: Use C++ exception handling.
5324         * jit.c: Use C++ exception handling.
5325         * infrun.c: Use C++ exception handling.
5326         * infcmd.c: Use C++ exception handling.
5327         * infcall.c: Use C++ exception handling.
5328         * inf-loop.c: Use C++ exception handling.
5329         * i386-tdep.c: Use C++ exception handling.
5330         * i386-linux-tdep.c: Use C++ exception handling.
5331         * guile/scm-value.c: Use C++ exception handling.
5332         * guile/scm-type.c: Use C++ exception handling.
5333         * guile/scm-symtab.c: Use C++ exception handling.
5334         * guile/scm-symbol.c: Use C++ exception handling.
5335         * guile/scm-pretty-print.c: Use C++ exception handling.
5336         * guile/scm-ports.c: Use C++ exception handling.
5337         * guile/scm-param.c: Use C++ exception handling.
5338         * guile/scm-math.c: Use C++ exception handling.
5339         * guile/scm-lazy-string.c: Use C++ exception handling.
5340         * guile/scm-frame.c: Use C++ exception handling.
5341         * guile/scm-disasm.c: Use C++ exception handling.
5342         * guile/scm-cmd.c: Use C++ exception handling.
5343         * guile/scm-breakpoint.c: Use C++ exception handling.
5344         * guile/scm-block.c: Use C++ exception handling.
5345         * guile/guile-internal.h: Use C++ exception handling.
5346         * gnu-v3-abi.c: Use C++ exception handling.
5347         * gdbtypes.c: Use C++ exception handling.
5348         * frame.c: Use C++ exception handling.
5349         * frame-unwind.c: Use C++ exception handling.
5350         * fbsd-tdep.c: Use C++ exception handling.
5351         * f-valprint.c: Use C++ exception handling.
5352         * exec.c: Use C++ exception handling.
5353         * event-top.c: Use C++ exception handling.
5354         * event-loop.c: Use C++ exception handling.
5355         * eval.c: Use C++ exception handling.
5356         * dwarf2read.c: Use C++ exception handling.
5357         * dwarf2loc.c: Use C++ exception handling.
5358         * dwarf2-frame.c: Use C++ exception handling.
5359         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5360         * dwarf-index-write.c: Use C++ exception handling.
5361         * dwarf-index-cache.c: Use C++ exception handling.
5362         * dtrace-probe.c: Use C++ exception handling.
5363         * disasm-selftests.c: Use C++ exception handling.
5364         * darwin-nat.c: Use C++ exception handling.
5365         * cp-valprint.c: Use C++ exception handling.
5366         * cp-support.c: Use C++ exception handling.
5367         * cp-abi.c: Use C++ exception handling.
5368         * corelow.c: Use C++ exception handling.
5369         * completer.c: Use C++ exception handling.
5370         * compile/compile-object-run.c: Use C++ exception handling.
5371         * compile/compile-object-load.c: Use C++ exception handling.
5372         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5373         * compile/compile-c-symbols.c: Use C++ exception handling.
5374         * common/selftest.c: Use C++ exception handling.
5375         * common/new-op.c: Use C++ exception handling.
5376         * cli/cli-script.c: Use C++ exception handling.
5377         * cli/cli-interp.c: Use C++ exception handling.
5378         * cli/cli-cmds.c: Use C++ exception handling.
5379         * c-varobj.c: Use C++ exception handling.
5380         * btrace.c: Use C++ exception handling.
5381         * breakpoint.c: Use C++ exception handling.
5382         * break-catch-throw.c: Use C++ exception handling.
5383         * arch-utils.c: Use C++ exception handling.
5384         * amd64-tdep.c: Use C++ exception handling.
5385         * ada-valprint.c: Use C++ exception handling.
5386         * ada-typeprint.c: Use C++ exception handling.
5387         * ada-lang.c: Use C++ exception handling.
5388         * aarch64-tdep.c: Use C++ exception handling.
5389
5390 2019-04-08  Tom Tromey  <tom@tromey.com>
5391
5392         * xml-support.c (gdb_xml_parser::parse): Update.
5393         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5394         * value.c (show_convenience): Update.
5395         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5396         (test_parse_flags_qcs): Update.
5397         * thread.c (thr_try_catch_cmd): Update.
5398         * target.c (target_translate_tls_address): Update.
5399         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5400         (info_frame_command_core, frame_apply_command_count): Update.
5401         * rust-exp.y (rust_lex_exception_test): Update.
5402         * riscv-tdep.c (riscv_print_one_register_info): Update.
5403         * remote.c (remote_target::enable_btrace): Update.
5404         * record-btrace.c (record_btrace_enable_warn): Update.
5405         * python/py-utils.c (gdbpy_convert_exception): Update.
5406         * printcmd.c (do_one_display, print_variable_and_value): Update.
5407         * mi/mi-main.c (mi_print_exception): Update.
5408         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5409         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5410         * linux-nat.c (linux_nat_target::attach): Update.
5411         * linux-fork.c (class scoped_switch_fork_info): Update.
5412         * infrun.c (displaced_step_prepare): Update.
5413         * infcall.c (call_function_by_hand_dummy): Update.
5414         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5415         * gnu-v3-abi.c (print_one_vtable): Update.
5416         * frame.c (get_prev_frame_always): Update.
5417         * f-valprint.c (info_common_command_for_block): Update.
5418         * exec.c (try_open_exec_file): Update.
5419         * exceptions.c (print_exception, exception_print)
5420         (exception_fprintf, exception_print_same): Update.
5421         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5422         * dwarf-index-cache.c (index_cache::store)
5423         (index_cache::lookup_gdb_index): Update.
5424         * darwin-nat.c (maybe_cache_shell): Update.
5425         * cp-valprint.c (cp_print_value_fields): Update.
5426         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5427         (gcc_cplus_symbol_address): Update.
5428         * compile/compile-c-symbols.c (gcc_convert_symbol)
5429         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5430         * common/selftest.c: Update.
5431         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5432         a std::string.
5433         (exception_try_scope_entry, exception_try_scope_exit): Don't
5434         declare.
5435         (struct exception_try_scope): Remove.
5436         (TRY): Don't use exception_try_scope.
5437         (struct gdb_exception): Add constructor, operator=.
5438         <what>: New method.
5439         (struct gdb_exception_RETURN_MASK_ALL)
5440         (struct gdb_exception_RETURN_MASK_ERROR)
5441         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5442         (struct gdb_quit_bad_alloc): Update.
5443         * common/common-exceptions.c (exception_none): Change
5444         initializer.
5445         (struct catcher) <state, exception>: Initialize inline.
5446         <prev>: Remove member.
5447         (current_catcher): Remove.
5448         (catchers): New global.
5449         (exceptions_state_mc_init): Simplify.
5450         (catcher_pop): Remove.
5451         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5452         (try_scope_depth, exception_try_scope_entry)
5453         (exception_try_scope_exit): Remove.
5454         (throw_exception_sjlj): Update.
5455         (exception_messages, exception_messages_size): Remove.
5456         (throw_it): Simplify.
5457         (gdb_exception_sliced_copy): Remove.
5458         (throw_exception_cxx): Update.
5459         * cli/cli-script.c (script_from_file): Update.
5460         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5461         Update.
5462         * ada-valprint.c (ada_val_print): Update.
5463         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5464         (create_excep_cond_exprs): Update.
5465
5466 2019-04-08  Tom Tromey  <tom@tromey.com>
5467
5468         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5469         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5470         (TRY, CATCH, END_CATCH): Remove some definitions.
5471         * common/common-exceptions.c: Don't use GDB_XCPT.
5472         (catcher_list_size): Remove.
5473         (throw_exception, throw_it): Simplify.
5474
5475 2019-04-05  Tom Tromey  <tom@tromey.com>
5476
5477         Revert the header-sorting patch.
5478         * ft32-tdep.c: Revert.
5479         * frv-tdep.c: Revert.
5480         * frv-linux-tdep.c: Revert.
5481         * frame.c: Revert.
5482         * frame-unwind.c: Revert.
5483         * frame-base.c: Revert.
5484         * fork-child.c: Revert.
5485         * findvar.c: Revert.
5486         * findcmd.c: Revert.
5487         * filesystem.c: Revert.
5488         * filename-seen-cache.h: Revert.
5489         * filename-seen-cache.c: Revert.
5490         * fbsd-tdep.c: Revert.
5491         * fbsd-nat.h: Revert.
5492         * fbsd-nat.c: Revert.
5493         * f-valprint.c: Revert.
5494         * f-typeprint.c: Revert.
5495         * f-lang.c: Revert.
5496         * extension.h: Revert.
5497         * extension.c: Revert.
5498         * extension-priv.h: Revert.
5499         * expprint.c: Revert.
5500         * exec.h: Revert.
5501         * exec.c: Revert.
5502         * exceptions.c: Revert.
5503         * event-top.c: Revert.
5504         * event-loop.c: Revert.
5505         * eval.c: Revert.
5506         * elfread.c: Revert.
5507         * dwarf2read.h: Revert.
5508         * dwarf2read.c: Revert.
5509         * dwarf2loc.c: Revert.
5510         * dwarf2expr.h: Revert.
5511         * dwarf2expr.c: Revert.
5512         * dwarf2-frame.c: Revert.
5513         * dwarf2-frame-tailcall.c: Revert.
5514         * dwarf-index-write.h: Revert.
5515         * dwarf-index-write.c: Revert.
5516         * dwarf-index-common.c: Revert.
5517         * dwarf-index-cache.h: Revert.
5518         * dwarf-index-cache.c: Revert.
5519         * dummy-frame.c: Revert.
5520         * dtrace-probe.c: Revert.
5521         * disasm.h: Revert.
5522         * disasm.c: Revert.
5523         * disasm-selftests.c: Revert.
5524         * dictionary.c: Revert.
5525         * dicos-tdep.c: Revert.
5526         * demangle.c: Revert.
5527         * dcache.h: Revert.
5528         * dcache.c: Revert.
5529         * darwin-nat.h: Revert.
5530         * darwin-nat.c: Revert.
5531         * darwin-nat-info.c: Revert.
5532         * d-valprint.c: Revert.
5533         * d-namespace.c: Revert.
5534         * d-lang.c: Revert.
5535         * ctf.c: Revert.
5536         * csky-tdep.c: Revert.
5537         * csky-linux-tdep.c: Revert.
5538         * cris-tdep.c: Revert.
5539         * cris-linux-tdep.c: Revert.
5540         * cp-valprint.c: Revert.
5541         * cp-support.c: Revert.
5542         * cp-namespace.c: Revert.
5543         * cp-abi.c: Revert.
5544         * corelow.c: Revert.
5545         * corefile.c: Revert.
5546         * continuations.c: Revert.
5547         * completer.h: Revert.
5548         * completer.c: Revert.
5549         * complaints.c: Revert.
5550         * coffread.c: Revert.
5551         * coff-pe-read.c: Revert.
5552         * cli-out.h: Revert.
5553         * cli-out.c: Revert.
5554         * charset.c: Revert.
5555         * c-varobj.c: Revert.
5556         * c-valprint.c: Revert.
5557         * c-typeprint.c: Revert.
5558         * c-lang.c: Revert.
5559         * buildsym.c: Revert.
5560         * buildsym-legacy.c: Revert.
5561         * build-id.h: Revert.
5562         * build-id.c: Revert.
5563         * btrace.c: Revert.
5564         * bsd-uthread.c: Revert.
5565         * breakpoint.h: Revert.
5566         * breakpoint.c: Revert.
5567         * break-catch-throw.c: Revert.
5568         * break-catch-syscall.c: Revert.
5569         * break-catch-sig.c: Revert.
5570         * blockframe.c: Revert.
5571         * block.c: Revert.
5572         * bfin-tdep.c: Revert.
5573         * bfin-linux-tdep.c: Revert.
5574         * bfd-target.c: Revert.
5575         * bcache.c: Revert.
5576         * ax-general.c: Revert.
5577         * ax-gdb.h: Revert.
5578         * ax-gdb.c: Revert.
5579         * avr-tdep.c: Revert.
5580         * auxv.c: Revert.
5581         * auto-load.c: Revert.
5582         * arm-wince-tdep.c: Revert.
5583         * arm-tdep.c: Revert.
5584         * arm-symbian-tdep.c: Revert.
5585         * arm-pikeos-tdep.c: Revert.
5586         * arm-obsd-tdep.c: Revert.
5587         * arm-nbsd-tdep.c: Revert.
5588         * arm-nbsd-nat.c: Revert.
5589         * arm-linux-tdep.c: Revert.
5590         * arm-linux-nat.c: Revert.
5591         * arm-fbsd-tdep.c: Revert.
5592         * arm-fbsd-nat.c: Revert.
5593         * arm-bsd-tdep.c: Revert.
5594         * arch-utils.c: Revert.
5595         * arc-tdep.c: Revert.
5596         * arc-newlib-tdep.c: Revert.
5597         * annotate.h: Revert.
5598         * annotate.c: Revert.
5599         * amd64-windows-tdep.c: Revert.
5600         * amd64-windows-nat.c: Revert.
5601         * amd64-tdep.c: Revert.
5602         * amd64-sol2-tdep.c: Revert.
5603         * amd64-obsd-tdep.c: Revert.
5604         * amd64-obsd-nat.c: Revert.
5605         * amd64-nbsd-tdep.c: Revert.
5606         * amd64-nbsd-nat.c: Revert.
5607         * amd64-nat.c: Revert.
5608         * amd64-linux-tdep.c: Revert.
5609         * amd64-linux-nat.c: Revert.
5610         * amd64-fbsd-tdep.c: Revert.
5611         * amd64-fbsd-nat.c: Revert.
5612         * amd64-dicos-tdep.c: Revert.
5613         * amd64-darwin-tdep.c: Revert.
5614         * amd64-bsd-nat.c: Revert.
5615         * alpha-tdep.c: Revert.
5616         * alpha-obsd-tdep.c: Revert.
5617         * alpha-nbsd-tdep.c: Revert.
5618         * alpha-mdebug-tdep.c: Revert.
5619         * alpha-linux-tdep.c: Revert.
5620         * alpha-linux-nat.c: Revert.
5621         * alpha-bsd-tdep.c: Revert.
5622         * alpha-bsd-nat.c: Revert.
5623         * aix-thread.c: Revert.
5624         * agent.c: Revert.
5625         * addrmap.c: Revert.
5626         * ada-varobj.c: Revert.
5627         * ada-valprint.c: Revert.
5628         * ada-typeprint.c: Revert.
5629         * ada-tasks.c: Revert.
5630         * ada-lang.c: Revert.
5631         * aarch64-tdep.c: Revert.
5632         * aarch64-ravenscar-thread.c: Revert.
5633         * aarch64-newlib-tdep.c: Revert.
5634         * aarch64-linux-tdep.c: Revert.
5635         * aarch64-linux-nat.c: Revert.
5636         * aarch64-fbsd-tdep.c: Revert.
5637         * aarch64-fbsd-nat.c: Revert.
5638         * aarch32-linux-nat.c: Revert.
5639
5640 2019-04-05  Tom Tromey  <tom@tromey.com>
5641
5642         * ft32-tdep.c: Sort headers.
5643         * frv-tdep.c: Sort headers.
5644         * frv-linux-tdep.c: Sort headers.
5645         * frame.c: Sort headers.
5646         * frame-unwind.c: Sort headers.
5647         * frame-base.c: Sort headers.
5648         * fork-child.c: Sort headers.
5649         * findvar.c: Sort headers.
5650         * findcmd.c: Sort headers.
5651         * filesystem.c: Sort headers.
5652         * filename-seen-cache.h: Sort headers.
5653         * filename-seen-cache.c: Sort headers.
5654         * fbsd-tdep.c: Sort headers.
5655         * fbsd-nat.h: Sort headers.
5656         * fbsd-nat.c: Sort headers.
5657         * f-valprint.c: Sort headers.
5658         * f-typeprint.c: Sort headers.
5659         * f-lang.c: Sort headers.
5660         * extension.h: Sort headers.
5661         * extension.c: Sort headers.
5662         * extension-priv.h: Sort headers.
5663         * expprint.c: Sort headers.
5664         * exec.h: Sort headers.
5665         * exec.c: Sort headers.
5666         * exceptions.c: Sort headers.
5667         * event-top.c: Sort headers.
5668         * event-loop.c: Sort headers.
5669         * eval.c: Sort headers.
5670         * elfread.c: Sort headers.
5671         * dwarf2read.h: Sort headers.
5672         * dwarf2read.c: Sort headers.
5673         * dwarf2loc.c: Sort headers.
5674         * dwarf2expr.h: Sort headers.
5675         * dwarf2expr.c: Sort headers.
5676         * dwarf2-frame.c: Sort headers.
5677         * dwarf2-frame-tailcall.c: Sort headers.
5678         * dwarf-index-write.h: Sort headers.
5679         * dwarf-index-write.c: Sort headers.
5680         * dwarf-index-common.c: Sort headers.
5681         * dwarf-index-cache.h: Sort headers.
5682         * dwarf-index-cache.c: Sort headers.
5683         * dummy-frame.c: Sort headers.
5684         * dtrace-probe.c: Sort headers.
5685         * disasm.h: Sort headers.
5686         * disasm.c: Sort headers.
5687         * disasm-selftests.c: Sort headers.
5688         * dictionary.c: Sort headers.
5689         * dicos-tdep.c: Sort headers.
5690         * demangle.c: Sort headers.
5691         * dcache.h: Sort headers.
5692         * dcache.c: Sort headers.
5693         * darwin-nat.h: Sort headers.
5694         * darwin-nat.c: Sort headers.
5695         * darwin-nat-info.c: Sort headers.
5696         * d-valprint.c: Sort headers.
5697         * d-namespace.c: Sort headers.
5698         * d-lang.c: Sort headers.
5699         * ctf.c: Sort headers.
5700         * csky-tdep.c: Sort headers.
5701         * csky-linux-tdep.c: Sort headers.
5702         * cris-tdep.c: Sort headers.
5703         * cris-linux-tdep.c: Sort headers.
5704         * cp-valprint.c: Sort headers.
5705         * cp-support.c: Sort headers.
5706         * cp-namespace.c: Sort headers.
5707         * cp-abi.c: Sort headers.
5708         * corelow.c: Sort headers.
5709         * corefile.c: Sort headers.
5710         * continuations.c: Sort headers.
5711         * completer.h: Sort headers.
5712         * completer.c: Sort headers.
5713         * complaints.c: Sort headers.
5714         * coffread.c: Sort headers.
5715         * coff-pe-read.c: Sort headers.
5716         * cli-out.h: Sort headers.
5717         * cli-out.c: Sort headers.
5718         * charset.c: Sort headers.
5719         * c-varobj.c: Sort headers.
5720         * c-valprint.c: Sort headers.
5721         * c-typeprint.c: Sort headers.
5722         * c-lang.c: Sort headers.
5723         * buildsym.c: Sort headers.
5724         * buildsym-legacy.c: Sort headers.
5725         * build-id.h: Sort headers.
5726         * build-id.c: Sort headers.
5727         * btrace.c: Sort headers.
5728         * bsd-uthread.c: Sort headers.
5729         * breakpoint.h: Sort headers.
5730         * breakpoint.c: Sort headers.
5731         * break-catch-throw.c: Sort headers.
5732         * break-catch-syscall.c: Sort headers.
5733         * break-catch-sig.c: Sort headers.
5734         * blockframe.c: Sort headers.
5735         * block.c: Sort headers.
5736         * bfin-tdep.c: Sort headers.
5737         * bfin-linux-tdep.c: Sort headers.
5738         * bfd-target.c: Sort headers.
5739         * bcache.c: Sort headers.
5740         * ax-general.c: Sort headers.
5741         * ax-gdb.h: Sort headers.
5742         * ax-gdb.c: Sort headers.
5743         * avr-tdep.c: Sort headers.
5744         * auxv.c: Sort headers.
5745         * auto-load.c: Sort headers.
5746         * arm-wince-tdep.c: Sort headers.
5747         * arm-tdep.c: Sort headers.
5748         * arm-symbian-tdep.c: Sort headers.
5749         * arm-pikeos-tdep.c: Sort headers.
5750         * arm-obsd-tdep.c: Sort headers.
5751         * arm-nbsd-tdep.c: Sort headers.
5752         * arm-nbsd-nat.c: Sort headers.
5753         * arm-linux-tdep.c: Sort headers.
5754         * arm-linux-nat.c: Sort headers.
5755         * arm-fbsd-tdep.c: Sort headers.
5756         * arm-fbsd-nat.c: Sort headers.
5757         * arm-bsd-tdep.c: Sort headers.
5758         * arch-utils.c: Sort headers.
5759         * arc-tdep.c: Sort headers.
5760         * arc-newlib-tdep.c: Sort headers.
5761         * annotate.h: Sort headers.
5762         * annotate.c: Sort headers.
5763         * amd64-windows-tdep.c: Sort headers.
5764         * amd64-windows-nat.c: Sort headers.
5765         * amd64-tdep.c: Sort headers.
5766         * amd64-sol2-tdep.c: Sort headers.
5767         * amd64-obsd-tdep.c: Sort headers.
5768         * amd64-obsd-nat.c: Sort headers.
5769         * amd64-nbsd-tdep.c: Sort headers.
5770         * amd64-nbsd-nat.c: Sort headers.
5771         * amd64-nat.c: Sort headers.
5772         * amd64-linux-tdep.c: Sort headers.
5773         * amd64-linux-nat.c: Sort headers.
5774         * amd64-fbsd-tdep.c: Sort headers.
5775         * amd64-fbsd-nat.c: Sort headers.
5776         * amd64-dicos-tdep.c: Sort headers.
5777         * amd64-darwin-tdep.c: Sort headers.
5778         * amd64-bsd-nat.c: Sort headers.
5779         * alpha-tdep.c: Sort headers.
5780         * alpha-obsd-tdep.c: Sort headers.
5781         * alpha-nbsd-tdep.c: Sort headers.
5782         * alpha-mdebug-tdep.c: Sort headers.
5783         * alpha-linux-tdep.c: Sort headers.
5784         * alpha-linux-nat.c: Sort headers.
5785         * alpha-bsd-tdep.c: Sort headers.
5786         * alpha-bsd-nat.c: Sort headers.
5787         * aix-thread.c: Sort headers.
5788         * agent.c: Sort headers.
5789         * addrmap.c: Sort headers.
5790         * ada-varobj.c: Sort headers.
5791         * ada-valprint.c: Sort headers.
5792         * ada-typeprint.c: Sort headers.
5793         * ada-tasks.c: Sort headers.
5794         * ada-lang.c: Sort headers.
5795         * aarch64-tdep.c: Sort headers.
5796         * aarch64-ravenscar-thread.c: Sort headers.
5797         * aarch64-newlib-tdep.c: Sort headers.
5798         * aarch64-linux-tdep.c: Sort headers.
5799         * aarch64-linux-nat.c: Sort headers.
5800         * aarch64-fbsd-tdep.c: Sort headers.
5801         * aarch64-fbsd-nat.c: Sort headers.
5802         * aarch32-linux-nat.c: Sort headers.
5803
5804 2019-04-04  Tom Tromey  <tom@tromey.com>
5805
5806         * varobj.c (varobj_create): Update.
5807         * rust-exp.y (struct rust_parser) <update_innermost_block,
5808         lookup_symbol>: New methods.
5809         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5810         Rename.
5811         (rust_parser::rust_lookup_type)
5812         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5813         * printcmd.c (display_command, do_one_display): Update.
5814         * parser-defs.h (struct parser_state) <parser_state>: Add
5815         "tracker" parameter.
5816         (block_tracker): New member.
5817         (class innermost_block_tracker) <innermost_block_tracker>: Add
5818         "types" parameter.
5819         <reset>: Remove method.
5820         (innermost_block): Don't declare.
5821         (null_post_parser): Update.
5822         * parse.c (innermost_block): Remove global.
5823         (write_dollar_variable): Update.
5824         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5825         Remove "tracker_types" parameter.
5826         (parse_expression): Add "tracker" parameter.
5827         (parse_expression_for_completion): Update.
5828         (null_post_parser): Add "tracker" parameter.
5829         * p-exp.y: Update rules.
5830         * m2-exp.y: Update rules.
5831         * language.h (struct language_defn) <la_post_parser>: Add
5832         "tracker" parameter.
5833         * go-exp.y: Update rules.
5834         * f-exp.y: Update rules.
5835         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5836         parameter.
5837         * d-exp.y: Update rules.
5838         * c-exp.y: Update rules.
5839         * breakpoint.c (set_breakpoint_condition): Create an
5840         innermost_block_tracker.
5841         (watch_command_1): Likewise.
5842         * ada-lang.c (resolve): Add "tracker" parameter.
5843         (resolve_subexp): Likewise.
5844         * ada-exp.y (write_var_from_sym): Update.
5845
5846 2019-04-04  Tom Tromey  <tom@tromey.com>
5847
5848         * type-stack.h: New file.
5849         * type-stack.c: New file.
5850         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5851         type-stack.h.
5852         (insert_into_type_stack, insert_type, push_type, push_type_int)
5853         (insert_type_address_space, pop_type, pop_type_int)
5854         (pop_typelist, pop_type_stack, append_type_stack)
5855         (push_type_stack, get_type_stack, push_typelist)
5856         (follow_type_instance_flags, follow_types): Don't declare.
5857         * parse.c (type_stack): Remove global.
5858         (parse_exp_in_context): Update.
5859         (insert_into_type_stack, insert_type, push_type, push_type_int)
5860         (insert_type_address_space, pop_type, pop_type_int)
5861         (pop_typelist, pop_type_stack, append_type_stack)
5862         (push_type_stack, get_type_stack, push_typelist)
5863         (follow_type_instance_flags, follow_types): Remove (moved to
5864         type-stack.c).
5865         * f-exp.y (type_stack): New global.
5866         Update rules.
5867         (push_kind_type, f_parse): Update.
5868         * d-exp.y (type_stack): New global.
5869         Update rules.
5870         (d_parse): Update.
5871         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5872         Update rules.
5873         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5874         (HFILES_NO_SRCDIR): Add type-stack.h.
5875
5876 2019-04-04  Tom Tromey  <tom@tromey.com>
5877
5878         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5879         (rust_parser::convert_ast_to_expression, rust_parse)
5880         (rust_lex_test_completion, rust_lex_tests): Update.
5881         * parser-defs.h (struct expr_completion_state): New.
5882         (struct parser_state) <parser_state>: Add completion parameter.
5883         <mark_struct_expression, mark_completion_tag>: New methods.
5884         <parse_completion, m_completion_state>: New members.
5885         (prefixify_expression, null_post_parser): Update.
5886         (mark_struct_expression, mark_completion_tag): Don't declare.
5887         * parse.c (parse_completion, expout_last_struct)
5888         (expout_tag_completion_type, expout_completion_name): Remove
5889         globals.
5890         (parser_state::mark_struct_expression)
5891         (parser_state::mark_completion_tag): Now methods.
5892         (prefixify_expression): Add last_struct parameter.
5893         (prefixify_subexp): Likewise.
5894         (parse_exp_1): Update.
5895         (parse_exp_in_context): Add cstate parameter.  Update.
5896         (parse_expression_for_completion): Create an
5897         expr_completion_state.
5898         (null_post_parser): Add "completion" parameter.
5899         * p-exp.y: Update rules.
5900         (yylex): Update.
5901         * language.h (struct language_defn) <la_post_parser>: Add
5902         "completing" parameter.
5903         * go-exp.y: Update rules.
5904         (lex_one_token): Update.
5905         * expression.h (parse_completion): Don't declare.
5906         * d-exp.y: Update rules.
5907         (lex_one_token): Update rules.
5908         * c-exp.y: Update rules.
5909         (lex_one_token): Update.
5910         * ada-lang.c (resolve): Add "parse_completion" parameter.
5911         (resolve_subexp): Likewise.
5912         (ada_resolve_function): Likewise.
5913
5914 2019-04-04  Tom Tromey  <tom@tromey.com>
5915
5916         * parser-defs.h (struct parser_state) <start_arglist,
5917         end_arglist>: New methods.
5918         <arglist_len, m_funcall_chain>: New members.
5919         (arglist_len, start_arglist, end_arglist): Don't declare.
5920         * parse.c (arglist_len, funcall_chain): Remove global.
5921         (start_arglist, end_arglist): Remove functions.
5922         (parse_exp_in_context): Update.
5923         * p-exp.y: Update rules.
5924         * m2-exp.y: Update rules.
5925         * go-exp.y: Update rules.
5926         * f-exp.y: Update rules.
5927         * d-exp.y: Update rules.
5928         * c-exp.y: Update rules.
5929
5930 2019-04-04  Tom Tromey  <tom@tromey.com>
5931
5932         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5933         lex_operator, push_back>: New methods.
5934         Update all rules.
5935         (rust_parser::lex_hex, lex_escape): Rename and update.
5936         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5937         (rust_parser::lex_operator): Rename and update.
5938         (rust_parser::lex_number, rustyylex, rustyyerror)
5939         (rust_lex_test_init, rust_lex_test_sequence)
5940         (rust_lex_test_push_back, rust_lex_tests): Update.
5941         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5942         parameter.
5943         <lexptr, prev_lexptr>: New members.
5944         (lexptr, prev_lexptr): Don't declare.
5945         * parse.c (lexptr, prev_lexptr): Remove globals.
5946         (parse_exp_in_context): Update.
5947         * p-exp.y (yylex, yyerror): Update.
5948         * m2-exp.y (parse_number, yylex, yyerror): Update.
5949         * go-exp.y (lex_one_token, yyerror): Update.
5950         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5951         * d-exp.y (lex_one_token, yyerror): Update.
5952         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5953         (lex_one_token, yyerror): Update.
5954         * ada-lex.l (YY_INPUT): Update.
5955         (rewind_to_char): Update.
5956         * ada-exp.y (yyerror): Update.
5957
5958 2019-04-04  Tom Tromey  <tom@tromey.com>
5959
5960         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5961         * parser-defs.h (struct parser_state) <parser_state>: Add new
5962         parameter.
5963         <comma_terminates>: New member.
5964         (comma_terminates): Don't declare global.
5965         * parse.c (comma_terminates): Remove global.
5966         (parse_exp_in_context): Update.
5967         * p-exp.y (yylex): Update.
5968         * m2-exp.y (yylex): Update.
5969         * go-exp.y (lex_one_token): Update.
5970         * f-exp.y (yylex): Update.
5971         * d-exp.y (lex_one_token): Update.
5972         * c-exp.y (lex_one_token): Update.
5973         * ada-lex.l: Update.
5974
5975 2019-04-04  Tom Tromey  <tom@tromey.com>
5976
5977         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5978         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5979         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5980         * parser-defs.h (paren_depth): Don't declare.
5981         * parse.c (paren_depth): Remove global.
5982         (parse_exp_in_context): Update.
5983         * p-exp.y (paren_depth): New global.
5984         (pascal_parse): Initialize it.
5985         * m2-exp.y (paren_depth): New global.
5986         (m2_parse): Initialize it.
5987         * go-exp.y (paren_depth): New global.
5988         (go_parse): Initialize it.
5989         * f-exp.y (paren_depth): New global.
5990         (f_parse): Initialize it.
5991         * d-exp.y (paren_depth): New global.
5992         (d_parse): Initialize it.
5993         * c-exp.y (paren_depth): New global.
5994         (c_parse): Initialize it.
5995         * ada-lex.l (paren_depth): New global.
5996         (lexer_init): Initialize it.
5997
5998 2019-04-04  Tom Tromey  <tom@tromey.com>
5999
6000         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6001         (rust_parser::convert_ast_to_type)
6002         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6003         * parser-defs.h (struct parser_state) <parser_state>: Add
6004         parameters.  Initialize new members.
6005         <expression_context_block, expression_context_pc>: New members.
6006         * parse.c (expression_context_block, expression_context_pc):
6007         Remove globals.
6008         (parse_exp_in_context): Update.
6009         * p-exp.y: Update all rules.
6010         (yylex): Update.
6011         * m2-exp.y: Update all rules.
6012         (yylex): Update.
6013         * go-exp.y (yylex): Update.
6014         * f-exp.y (yylex): Update.
6015         * d-exp.y: Update all rules.
6016         (yylex): Update.
6017         * c-exp.y: Update all rules.
6018         (lex_one_token, classify_name, yylex, c_parse): Update.
6019         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6020
6021 2019-04-04  Tom Tromey  <tom@tromey.com>
6022
6023         * gdbarch.h, gdbarch.c: Rebuild.
6024         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6025         * stap-probe.h:
6026         (struct stap_parse_info): Replace "parser_state" with
6027         "expr_builder".
6028         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6029         (parser_state): New class.
6030         * parse.c (expr_builder): Rename.
6031         (expr_builder::release): Rename.
6032         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6033         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6034         (write_exp_elt_longcst, write_exp_elt_floatcst)
6035         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6036         (write_exp_string_vector, write_exp_bitstring)
6037         (write_exp_msymbol, mark_struct_expression)
6038         (write_dollar_variable)
6039         (insert_type_address_space, increase_expout_size): Replace
6040         "parser_state" with "expr_builder".
6041         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6042         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6043         "parser_state" with "expr_builder".
6044
6045 2019-04-04  Tom Tromey  <tom@tromey.com>
6046
6047         * rust-exp.y: Replace "parse_language" with method call.
6048         * p-exp.y:
6049         (yylex): Replace "parse_language" with method call.
6050         * m2-exp.y:
6051         (yylex): Replace "parse_language" with method call.
6052         * go-exp.y (classify_name): Replace "parse_language" with method
6053         call.
6054         * f-exp.y (yylex): Replace "parse_language" with method call.
6055         * d-exp.y (lex_one_token): Replace "parse_language" with method
6056         call.
6057         * c-exp.y:
6058         (lex_one_token, classify_name, yylex): Replace "parse_language"
6059         with method call.
6060         * ada-exp.y (find_primitive_type, type_char)
6061         (type_system_address): Replace "parse_language" with method call.
6062
6063 2019-04-04  Tom Tromey  <tom@tromey.com>
6064
6065         * rust-exp.y: Replace "parse_gdbarch" with method call.
6066         * parse.c (write_dollar_variable, insert_type_address_space):
6067         Replace "parse_gdbarch" with method call.
6068         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6069         call.
6070         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6071         call.
6072         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6073         "parse_gdbarch" with method call.
6074         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6075         with method call.
6076         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6077         "parse_gdbarch" with method call.
6078         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6079         "parse_gdbarch" with method call.
6080         * c-exp.y (parse_type, parse_number, classify_name): Replace
6081         "parse_gdbarch" with method call.
6082         * ada-lex.l: Replace "parse_gdbarch" with method call.
6083         * ada-exp.y (parse_type, find_primitive_type, type_char)
6084         (type_system_address): Replace "parse_gdbarch" with method call.
6085
6086 2019-04-04  Tom Tromey  <tom@tromey.com>
6087
6088         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6089         * stap-probe.c (stap_parse_argument): Update.
6090         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6091         initial_size parameter.
6092         * rust-exp.y (rust_lex_tests): Update.
6093         * parse.c (parser_state): Update.
6094         (parse_exp_in_context): Update.
6095         * parser-defs.h (struct parser_state) <parser_state>: Remove
6096         "initial_size" parameter.
6097
6098 2019-04-04  Tom Tromey  <tom@tromey.com>
6099
6100         * parser-defs.h (increase_expout_size): Don't declare.
6101         * parse.c (increase_expout_size): Now static.
6102
6103 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6104
6105         * gnu-nat.c (gnu_nat_target::wait): Fix
6106         target_waitstatus_to_string call.
6107
6108 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6109
6110         * eval.c (evaluate_subexp_standard): Handle internal functions
6111         during Fortran function call handling.
6112
6113 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6114
6115         * NEWS: Mention new internal functions.
6116         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6117         (read_base_type): Use dwarf2_init_complex_target_type.
6118         * value.c (creal_internal_fn): New function.
6119         (cimag_internal_fn): New function.
6120         (_initialize_values): Register new internal functions.
6121
6122 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6123
6124         * infrun.c (stop_all_threads): If debug_infrun, always
6125         trace the wait status after wait_one, using
6126         target_waitstatus_to_string and target_pid_to_str.
6127         (handle_inferior_event): Replace various trace of
6128         wait status kind by a single trace.
6129         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6130         wait status kind image by target_waitstatus_to_string.
6131         * target/waitstatus.c (target_waitstatus_to_string): Fix
6132         obsolete comment.
6133
6134 2019-04-01  Tom Tromey  <tromey@adacore.com>
6135
6136         PR symtab/23331:
6137         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6138
6139 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6140             Pedro Alves  <palves@redhat.com>
6141
6142         * top.c (quit_force): Call 'finalize_values'.
6143         * value.c (finalize_values): New function.
6144         * value.h (finalize_values): Declare.
6145
6146 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6147
6148         * NEWS: Announce $_gdb_major and $_gdb_minor.
6149
6150         * top.c (init_gdb_version_vars): New function.
6151         (gdb_init): Call init_gdb_version_vars.
6152
6153 2019-03-29  Tom Tromey  <tromey@adacore.com>
6154
6155         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6156         help text.  Remove dead code.
6157
6158 2019-03-29  Keith Seitz  <keiths@redhat.com>
6159
6160         From Siddhesh Poyarekar:
6161         * f-lang.h (f77_get_upperbound): Return LONGEST.
6162         (f77_get_lowerbound): Likewise.
6163         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6164         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6165         print them.
6166         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6167         plongest to format print it.
6168         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6169         (f77_get_upperbound): Likewise.
6170         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6171         LOWER_BOUND to LONGEST.
6172         (f77_create_arrayprint_offset_tbl): Likewise.
6173
6174 2019-03-29  Keith Seitz  <keiths@redhat.com>
6175
6176         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6177         %s/pulongest for TYPE_LENGTH instead of %d in format
6178         strings.
6179         * ada-typerint.c (ada_print_type): Likewise.
6180         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6181         * compile/compile-c-support.c (generate_register_struct): Likewise.
6182         * gdbtypes.c (recursive_dump_type): Likewise.
6183         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6184         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6185         instead of %d in format strings.
6186         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6187         to std::min to ULONGEST.
6188         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6189         instead of %d in format strings.
6190         * tracepoint.c (info_scope_command): Likewise.
6191         * typeprint.c (print_offset_data::update)
6192         (print_offset_data::finish): Likewise.
6193         * xtensa-tdep.c (xtensa_store_return_value)
6194         (xtensa_push_dummy_call): Likewise.
6195
6196 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6197
6198         * windows-nat.c (display_selector): Fixed format specifications
6199         for 64-bit Cygwin.
6200
6201 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6202
6203         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6204
6205 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6206
6207         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6208         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6209         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6210         (nios2_linux_init_abi): Install it.
6211
6212 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6213
6214         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6215
6216 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6217
6218         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6219
6220 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6221             Tom Tromey  <tromey@adacore.com>
6222
6223         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6224
6225 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6226
6227         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6228         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6229         method to compute the bounds of range types. Also print "[evaluated]"
6230         if the bounds' values come from a dynamic evaluation.
6231
6232 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6233
6234         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6235         whitespace when pretty printing is on.
6236
6237 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6238
6239         * ppc-linux-nat.c: Add include.
6240
6241 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6242
6243         * NEWS: Mention AArch64 Pointer Authentication.
6244
6245 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6246
6247         * arm-linux-nat.c: Add include.
6248
6249 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6250
6251         * source-cache.c (source_cache::get_source_lines): Re-read
6252         fullname after calling open_source_file.
6253
6254 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6255
6256         * NEWS: Mention TLS support for FreeBSD.
6257
6258 2019-03-25  Tom Tromey  <tromey@adacore.com>
6259
6260         * minsyms.c (BUNCH_SIZE): Update comment.
6261         (~minimal_symbol_reader): Remove old comment.
6262         (compact_minimal_symbols): Update comment.
6263         (minimal_symbol_reader::install): Remove old comment.  Update
6264         other comments.
6265
6266 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6267
6268         * s390-linux-nat.c: Add include.
6269
6270 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6271
6272         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6273         Call linux_get_hwcap.
6274         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6275         Likewise.
6276         (aarch64_linux_get_hwcap): Remove function.
6277         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6278         declaration.
6279         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6280         linux_get_hwcap.
6281         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6282         * linux-tdep.c (linux_get_hwcap): Add function.
6283         (linux_get_hwcap2): Likewise.
6284         * linux-tdep.h (linux_get_hwcap): Add declaration.
6285         (linux_get_hwcap2): Likewise.
6286         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6287         (ppc_linux_get_hwcap2): Likewise.
6288         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6289         linux_get_hwcap.
6290         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6291         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6292         (ppc_linux_nat_target::read_description): Likewise.
6293         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6294         * s390-linux-nat.c: Likewise.
6295         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6296
6297 2019-03-24  Tom Tromey  <tom@tromey.com>
6298
6299         * ada-lang.c (standard_lookup): Simplify initialization.
6300         (ada_lookup_symbol_nonlocal): Simplify return.
6301         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6302         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6303         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6304         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6305         initialization.
6306         * solib.c (solib_global_lookup): Simplify.
6307         * symtab.c (null_block_symbol): Remove.
6308         (symbol_cache_lookup): Simplify returns.
6309         (lookup_language_this): Simplify returns.
6310         (lookup_symbol_aux): Simplify return.
6311         (lookup_local_symbol): Simplify returns.
6312         (lookup_global_symbol_from_objfile): Simplify return.
6313         (lookup_symbol_in_objfile_symtabs)
6314         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6315         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6316         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6317         * cp-namespace.c (cp_lookup_bare_symbol)
6318         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6319         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6320         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6321         (cp_lookup_symbol_via_imports): Simplify initialization.
6322         (find_symbol_in_baseclass): Likewise.
6323         * symtab.h (null_block_symbol): Remove.
6324         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6325         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6326         (d_lookup_symbol_module): Likewise.
6327         (find_symbol_in_baseclass): Simplify initialization.
6328
6329 2019-03-24  Tom Tromey  <tom@tromey.com>
6330
6331         * expression.h: Don't include symtab.h.
6332         (struct block): Forward declare.
6333
6334 2019-03-24  Tom Tromey  <tom@tromey.com>
6335
6336         * c-exp.y (typebase): Remove casts.
6337         * gdbtypes.c (lookup_unsigned_typename, )
6338         (lookup_signed_typename): Remove cast.
6339         * eval.c (parse_to_comma_and_eval): Remove cast.
6340         * parse.c (write_dollar_variable): Remove cast.
6341         * block.h (struct block) <superblock>: Now const.
6342         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6343         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6344         (map_block): Make "block" const.
6345         * symfile.h (struct quick_symbol_functions)
6346         <map_matching_symbols>: Constify block argument to "callback".
6347         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6348         const.
6349         (find_pc_sect_compunit_symtab): Make "b" const.
6350         (find_symbol_at_address): Likewise.
6351         (search_symbols): Likewise.
6352         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6353         (dw2_debug_names_lookup_symbol): Likewise.
6354         (dw2_map_matching_symbols): Update.
6355         * p-valprint.c (pascal_val_print): Remove "block".
6356         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6357         (aux_add_nonlocal_symbols): Make "block" const.
6358         (resolve_subexp): Remove cast.
6359         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6360         const.
6361         (iterate_over_file_blocks): Likewise.
6362         * f-exp.y (%union) <bval>: Remove.
6363         * coffread.c (patch_opaque_types): Make "b" const.
6364         * spu-tdep.c (spu_catch_start): Make "block" const.
6365         * c-valprint.c (print_unpacked_pointer): Remove "block".
6366         * symmisc.c (dump_symtab_1): Make "b" const.
6367         (block_depth): Make "block" const.
6368         * d-exp.y (%union) <bval>: Remove.
6369         * cp-support.h (cp_lookup_rtti_type): Update.
6370         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6371         * psymtab.c (psym_lookup_symbol): Make "block" const.
6372         (maintenance_check_psymtabs): Make "b" const.
6373         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6374         (enumerate_locals, enumerate_args): Update.
6375         * python/py-symtab.c (stpy_global_block): Make "block" const.
6376         (stpy_static_block): Likewise.
6377         * inline-frame.c (block_starting_point_at): Make "new_block"
6378         const.
6379         * block.c (find_block_in_blockvector): Make return type const.
6380         (blockvector_for_pc_sect): Make "b" const.
6381         (find_block_in_blockvector): Make "b" const.
6382
6383 2019-03-23  Tom Tromey  <tom@tromey.com>
6384
6385         * varobj.c (varobj_create): Update.
6386         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6387         * printcmd.c (display_command, do_one_display): Don't reset
6388         innermost_block.
6389         * parser-defs.h (enum innermost_block_tracker_type): Move to
6390         expression.h.
6391         (innermost_block): Update comment.
6392         * parse.c (parse_exp_1): Add tracker_types parameter.
6393         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6394         tracker_types parameter.  Reset innermost_block.
6395         (parse_exp_in_context): Remove.
6396         (parse_expression_for_completion): Update.
6397         * objfiles.c (~objfile): Don't reset expression_context_block or
6398         innermost_block.
6399         * expression.h (enum innermost_block_tracker_type): Move from
6400         parser-defs.h.
6401         (parse_exp_1): Add tracker_types parameter.
6402         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6403         reset innermost_block.
6404
6405 2019-03-23  Tom Tromey  <tom@tromey.com>
6406
6407         * objfiles.h: Include bcache.h.
6408
6409 2019-03-23  Tom Tromey  <tom@tromey.com>
6410
6411         * linespec.c (get_current_search_block): Use
6412         scoped_restore_current_language.
6413         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6414
6415 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6416             Jiong Wang  <jiong.wang@arm.com>
6417
6418         * aarch64-linux-tdep.c
6419         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6420         section.
6421         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6422
6423 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6424             Jiong Wang  <jiong.wang@arm.com>
6425
6426         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6427         instructions.
6428         (aarch64_analyze_prologue_test): Add PACIASP test.
6429         (aarch64_prologue_prev_register): Unmask PC value.
6430
6431 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6432             Jiong Wang  <jiong.wang@arm.com>
6433
6434         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6435         (aarch64_dwarf2_prev_register): Unmask PC value.
6436         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6437         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6438         DW_CFA_AARCH64_negate_ra_state.
6439         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6440
6441 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6442             Jiong Wang  <jiong.wang@arm.com>
6443
6444         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6445         registers.
6446         (aarch64_pseudo_register_name): Likewise.
6447         (aarch64_pseudo_register_type): Likewise.
6448         (aarch64_pseudo_register_reggroup_p): Likewise.
6449         (aarch64_gdbarch_init): Add pauth registers.
6450         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6451         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6452         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6453         (struct gdbarch_tdep): Add regnum for ra_state.
6454
6455 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6456             Jiong Wang  <jiong.wang@arm.com>
6457
6458         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6459
6460 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6461             Jiong Wang  <jiong.wang@arm.com>
6462
6463         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6464         function.
6465         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6466         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6467         (aarch64_gdbarch_init): Add puth registers.
6468         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6469         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6470         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6471
6472 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6473             Jiong Wang  <jiong.wang@arm.com>
6474
6475         * aarch64-linux-nat.c
6476         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6477         * aarch64-linux-tdep.c
6478         (aarch64_linux_core_read_description): Likewise.
6479         (aarch64_linux_get_hwcap): New function.
6480         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6481         (aarch64_linux_get_hwcap): New declaration.
6482
6483 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6484             Jiong Wang  <jiong.wang@arm.com>
6485
6486         * aarch64-linux-nat.c
6487         (aarch64_linux_nat_target::read_description): Add pauth param.
6488         * aarch64-linux-tdep.c
6489         (aarch64_linux_core_read_description): Likewise.
6490         * aarch64-tdep.c (struct target_desc): Add in pauth.
6491         (aarch64_read_description): Add pauth param.
6492         (aarch64_gdbarch_init): Likewise.
6493         * aarch64-tdep.h (aarch64_read_description): Likewise.
6494         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6495         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6496         * features/Makefile: Add new files.
6497         * features/aarch64-pauth.c: New file.
6498         * features/aarch64-pauth.xml: New file.
6499
6500 2019-03-20  Tom Tromey  <tromey@adacore.com>
6501
6502         * infrun.c (handle_inferior_event): Rename from
6503         handle_inferior_event_1.  Create a scoped_value_mark.
6504         (handle_inferior_event): Remove.
6505
6506 2019-03-19  Tom Tromey  <tromey@adacore.com>
6507
6508         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6509         * infrun.h (print_stop_event): Add "displays" parameter.
6510         * infrun.c (print_stop_event): Add "displays" parameter.
6511
6512 2019-03-19  Pedro Alves  <palves@redhat.com>
6513
6514         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6515         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6516         to -1.  Fix TABs vs spaces.
6517         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6518         * tui/tui-out.h (tui_ui_out) Add intro comments.
6519         <m_line, m_start_of_line>: In-class initialize, and add describing
6520         comment.
6521
6522 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6523
6524         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6525         variable names.
6526         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6527
6528 2019-03-18  Pedro Alves  <palves@redhat.com>
6529             Eli Zaretskii <eliz@gnu.org>
6530
6531         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6532         m_line and m_start_of_line.
6533
6534 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6535
6536         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6537         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6538         it returns a newline.  This fixes a regression in TU mode, whereby
6539         the next line is output on the same screen line as the user input.
6540
6541 2019-03-18  Tom Tromey  <tromey@adacore.com>
6542
6543         * minsyms.c (minimal_symbol_reader::install): Remove call to
6544         obstack_blank.
6545
6546 2019-03-18  Pedro Alves  <palves@redhat.com>
6547
6548         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6549         New globals.
6550         (apply_style): New, factored out from ...
6551         (apply_ansi_escape): ... this.  Handle reverse video mode.
6552         (tui_set_reverse_mode): New function.
6553         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6554         * tui/tui-winsource.c (tui_show_source_line): Use
6555         tui_set_reverse_mode instead of setting A_STANDOUT.
6556         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6557         New setter methods.
6558
6559 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6560
6561         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6562         Handle tabs.
6563
6564 2019-03-18  Tom Tromey  <tromey@adacore.com>
6565
6566         * ada-lang.c (empty_array): Add "high" parameter.
6567         (ada_evaluate_subexp): Update.
6568
6569 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6570
6571         * unittests/string_view-selftests.c: Define
6572         _initialize_string_view_selftests unconditionally.
6573
6574 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6575
6576         PR gdb/24350
6577         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6578
6579 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6580
6581         PR gdb/24351
6582         * windows-nat.c (display_selector): Fix format specifiers.
6583
6584 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6585
6586         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6587         tui_refill_source_window instead of tui_refresh_win, to update the
6588         current execution line.  This fixes redisplay of the current line
6589         when stepping through the code with "next" or "step".
6590
6591 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6592
6593         * source-cache.c (source_cache::get_source_lines): Call
6594         find_source_lines to initialize s->nlines.  This fixes vertical
6595         scrolling of TUI source window when the DOWN arrow is pressed.
6596
6597 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6598
6599         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6600         linux-thread-db.c (_initialize_thread_db): Likewise.
6601
6602 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6603
6604         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6605         wclrtoeol in tui_show_source_line".  This reverts changes made in
6606         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6607
6608 2019-03-15  Tom Tromey  <tom@tromey.com>
6609
6610         * symtab.h (struct minimal_symbol): Derive from
6611         general_symbol_info.
6612         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6613         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6614         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6615         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6616         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6617         (MSYMBOL_SEARCH_NAME): Update.
6618         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6619         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6620         * minsyms.c (minimal_symbol_reader::record_full): Update.
6621
6622 2019-03-15  Tom Tromey  <tom@tromey.com>
6623
6624         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6625
6626 2019-03-15  Tom Tromey  <tom@tromey.com>
6627
6628         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6629         unique_xmalloc_ptr.
6630         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6631         Update.
6632         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6633         (build_minimal_symbol_hash_tables)
6634         (minimal_symbol_reader::install): Update.
6635
6636 2019-03-15  Tom Tromey  <tom@tromey.com>
6637
6638         * symtab.c (create_demangled_names_hash): Update.
6639         (symbol_set_names): Update.
6640         * objfiles.h (struct objfile_per_bfd_storage)
6641         <demangled_names_hash>: Now an htab_up.
6642         * objfiles.c (objfile_per_bfd_storage): Simplify.
6643
6644 2019-03-15  Tom Tromey  <tom@tromey.com>
6645
6646         * objfiles.h (struct objfile_per_bfd_storage): Declare
6647         destructor.
6648         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6649         New.
6650         (get_objfile_bfd_data): Use new.  Don't initialize
6651         language_of_main.
6652         (free_objfile_per_bfd_storage): Remove.
6653         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6654
6655 2019-03-15  Tom Tromey  <tom@tromey.com>
6656
6657         * symfile.c (reread_symbols): Update.
6658         * objfiles.c (objfile::objfile): Update.
6659         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6660         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6661         comment.
6662         (minimal_symbol_reader::install): Update.
6663         (terminate_minimal_symbol_table): Remove.
6664         * jit.c (jit_object_close_impl): Update.
6665
6666 2019-03-15  Tom Tromey  <tom@tromey.com>
6667
6668         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6669         initializations.
6670
6671 2019-03-15  Tom Tromey  <tom@tromey.com>
6672
6673         * objfiles.h (struct objfile_per_bfd_storage)
6674         <demangled_hash_languages>: Now a bitset.
6675         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6676         (lookup_minimal_symbol): Update.
6677
6678 2019-03-15  Tom Tromey  <tom@tromey.com>
6679
6680         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6681         Don't return the symbol.
6682         * coffread.c (record_minimal_symbol): Use record_full.
6683
6684 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6685
6686         The MS-Windows port of ncurses fails to switch to a color pair if
6687         one or both of the colors are the implicit default colors.  This
6688         change records the default colors when TUI is initialized, and
6689         then specifies them explicitly when a color pair uses the default
6690         colors.  This allows color styling in TUI mode on MS-Windows.
6691
6692         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6693         ncurses_norm_attr.
6694         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6695         colors in ncurses_norm_attr.
6696         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6697         "none", replace it with the default color recorded in
6698         ncurses_norm_attr.
6699
6700 2019-03-14  Tom Tromey  <tromey@adacore.com>
6701
6702         * source-cache.h (class source_cache) <get_source_lines>: Return
6703         std::string.
6704         * source-cache.c (source_cache::extract_lines): Handle case where
6705         first_pos==npos.  Return std::string.
6706         (source_cache::get_source_lines): Update.
6707
6708 2019-03-14  Tom Tromey  <tromey@adacore.com>
6709
6710         * NEWS: Add item for "style sources" commands.
6711         * source-cache.c (source_cache::get_source_lines): Check
6712         source_styling.
6713         * cli/cli-style.c (source_styling): New global.
6714         (_initialize_cli_style): Add "style sources" commands.
6715         (show_style_sources): New function.
6716         * cli/cli-style.h (source_styling): Declare.
6717
6718 2019-03-14  Pedro Alves  <palves@redhat.com>
6719             Tom Tromey  <tromey@adacore.com>
6720
6721         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6722         * tui/tui-winsource.c (tui_refill_source_window): New function,
6723         from...
6724         (tui_horizontal_source_scroll): ... here.  Move some logic.
6725         * cli/cli-style.c (set_style_enabled): Notify new observable.
6726         * tui/tui-hooks.c (tui_redisplay_source): New function.
6727         (tui_attach_detach_observers): Attach or detach
6728         tui_redisplay_source.
6729         * observable.h (source_styling_changed): New observable.
6730         * observable.c: Define source_styling_changed observable.
6731
6732 2019-03-13  Tom Tromey  <tromey@adacore.com>
6733
6734         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6735         (i386_gnu_nat_target::store_registers): Update.
6736         * target-debug.h (target_debug_print_std_string): New macro.
6737         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6738         * windows-tdep.c (display_one_tib): Update.
6739         * tui/tui-stack.c (tui_make_status_line): Update.
6740         * top.c (print_inferior_quit_action): Update.
6741         * thread.c (thr_try_catch_cmd): Update.
6742         (add_thread_with_info): Update.
6743         (thread_target_id_str): Update.
6744         (thr_try_catch_cmd): Update.
6745         (thread_command): Update.
6746         (thread_find_command): Update.
6747         * record-btrace.c (record_btrace_target::info_record)
6748         (record_btrace_resume_thread, record_btrace_target::resume)
6749         (record_btrace_cancel_resume, record_btrace_step_thread)
6750         (record_btrace_target::wait, record_btrace_target::wait)
6751         (record_btrace_target::wait, record_btrace_target::stop): Update.
6752         * progspace.c (print_program_space): Update.
6753         * process-stratum-target.c
6754         (process_stratum_target::thread_address_space): Update.
6755         * linux-fork.c (linux_fork_mourn_inferior)
6756         (detach_checkpoint_command, info_checkpoints_command)
6757         (linux_fork_context): Update.
6758         (linux_fork_detach): Update.
6759         (class scoped_switch_fork_info): Update.
6760         (delete_checkpoint_command): Update.
6761         * infrun.c (follow_fork_inferior): Update.
6762         (follow_fork_inferior): Update.
6763         (proceed_after_vfork_done): Update.
6764         (handle_vfork_child_exec_or_exit): Update.
6765         (follow_exec): Update.
6766         (displaced_step_prepare_throw): Update.
6767         (displaced_step_restore): Update.
6768         (start_step_over): Update.
6769         (resume_1): Update.
6770         (clear_proceed_status_thread): Update.
6771         (proceed): Update.
6772         (print_target_wait_results): Update.
6773         (do_target_wait): Update.
6774         (context_switch): Update.
6775         (stop_all_threads): Update.
6776         (restart_threads): Update.
6777         (finish_step_over): Update.
6778         (handle_signal_stop): Update.
6779         (switch_back_to_stepped_thread): Update.
6780         (keep_going_pass_signal): Update.
6781         (print_exited_reason): Update.
6782         (normal_stop): Update.
6783         * inferior.c (inferior_pid_to_str): Change return type.
6784         (print_selected_inferior): Update.
6785         (add_inferior): Update.
6786         (detach_inferior): Update.
6787         * dummy-frame.c (fprint_dummy_frames): Update.
6788         * dcache.c (dcache_info_1): Update.
6789         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6790         (btrace_fetch, btrace_clear): Update.
6791         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6792         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6793         type.
6794         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6795         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6796         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6797         * gdbarch.c, gdbarch.h: Rebuild.
6798         * gdbarch.sh (core_pid_to_str): Change return type.
6799         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6800         return type.
6801         (windows_nat_target::pid_to_str): Change return type.
6802         (windows_delete_thread): Update.
6803         (windows_nat_target::attach): Update.
6804         (windows_nat_target::files_info): Update.
6805         * target-delegates.c: Rebuild.
6806         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6807         return type.
6808         (sol_thread_target::pid_to_str): Change return type.
6809         * remote.c (class remote_target) <pid_to_str>: Change return
6810         type.
6811         (remote_target::pid_to_str): Change return type.
6812         (extended_remote_target::attach, remote_target::remote_stop_ns)
6813         (remote_target::remote_notif_remove_queued_reply)
6814         (remote_target::push_stop_reply, remote_target::disable_btrace):
6815         Update.
6816         (extended_remote_target::attach): Update.
6817         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6818         type.
6819         (gdbsim_target::pid_to_str): Change return type.
6820         * ravenscar-thread.c (struct ravenscar_thread_target)
6821         <pid_to_str>: Change return type.
6822         (ravenscar_thread_target::pid_to_str): Change return type.
6823         * procfs.c (class procfs_target) <pid_to_str>: Change return
6824         type.
6825         (procfs_target::pid_to_str): Change return type.
6826         (procfs_target::attach): Update.
6827         (procfs_target::detach): Update.
6828         (procfs_target::fetch_registers): Update.
6829         (procfs_target::store_registers): Update.
6830         (procfs_target::wait): Update.
6831         (procfs_target::files_info): Update.
6832         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6833         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6834         return type.
6835         (nto_procfs_target::pid_to_str): Change return type.
6836         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6837         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6838         return type.
6839         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6840         (exit_lwp): Update.
6841         (attach_proc_task_lwp_callback, get_detach_signal)
6842         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6843         (linux_nat_target::resume, wait_lwp, stop_callback)
6844         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6845         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6846         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6847         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6848         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6849         type.
6850         (inf_ptrace_target::attach): Update.
6851         (inf_ptrace_target::files_info): Update.
6852         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6853         type.
6854         (go32_nat_target::pid_to_str): Change return type.
6855         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6856         (gnu_nat_target::wait): Update.
6857         (gnu_nat_target::wait): Update.
6858         (gnu_nat_target::resume): Update.
6859         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6860         (fbsd_nat_target::wait): Update.
6861         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6862         type.
6863         (darwin_nat_target::attach): Update.
6864         * corelow.c (class core_target) <pid_to_str>: Change return type.
6865         (core_target::pid_to_str): Change return type.
6866         * target.c (normal_pid_to_str): Change return type.
6867         (default_pid_to_str): Likewise.
6868         (target_pid_to_str): Change return type.
6869         (target_translate_tls_address): Update.
6870         (target_announce_detach): Update.
6871         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6872         return type.
6873         (bsd_uthread_target::pid_to_str): Change return type.
6874         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6875         type.
6876         (bsd_kvm_target::pid_to_str): Change return type.
6877         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6878         return type.
6879         (aix_thread_target::pid_to_str): Change return type.
6880         * target.h (struct target_ops) <pid_to_str>: Change return type.
6881         (target_pid_to_str, normal_pid_to_str): Likewise.
6882         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6883         type.
6884         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6885         type.
6886         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6887         return type.
6888         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6889         type.
6890         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6891         type.
6892         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6893         return type.
6894
6895 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6896
6897         * NEWS: Mention that the new default MI version is 3.  Mention
6898         changes to the output of commands and events that deal with
6899         multi-location breakpoints.
6900         * breakpoint.c: Include "mi/mi-out.h".
6901         (print_one_breakpoint): Change output syntax if using MI version
6902         >= 3.
6903         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6904         New.
6905         (mi_multi_location_breakpoint_output_fixed): New.
6906         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6907         (mi_cmd_fix_multi_location_breakpoint_output): New.
6908         (mi_multi_location_breakpoint_output_fixed): New.
6909         * mi/mi-cmds.c (mi_cmds): Register command
6910         -fix-multi-location-breakpoint-output.
6911         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6912         interpreter "mi".
6913
6914 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6915
6916         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6917         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6918         instantiate mi_ui_out based on interpreter name.
6919         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6920         * mi/mi-main.c (mi_load_progress): Likewise.
6921
6922 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6923
6924         * NEWS: Combine separate "New targets" sections for 8.3.
6925
6926 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6927
6928         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6929         (ppcfbsd_init_abi): Install gdbarch
6930         "fetch_tls_load_module_address" and "get_thread_local_address"
6931         methods.
6932
6933 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6934
6935         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6936         (riscv_fbsd_init_abi): Install gdbarch
6937         "fetch_tls_load_module_address" and "get_thread_local_address"
6938         methods.
6939
6940 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6941
6942         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6943         (i386fbsd_init_abi): Install gdbarch
6944         "fetch_tls_load_module_address" and "get_thread_local_address"
6945         methods.
6946
6947 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6948
6949         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6950         (amd64fbsd_init_abi): Install gdbarch
6951         "fetch_tls_load_module_address" and "get_thread_local_address"
6952         methods.
6953
6954 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6955
6956         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6957         (struct fbsd_pspace_data): New type.
6958         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6959         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6960         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6961         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6962         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6963
6964 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6965
6966         * gdbtypes.c (lookup_struct_elt): New function.
6967         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6968         * gdbtypes.h (struct struct_elt): New type.
6969         (lookup_struct_elt): New prototype.
6970
6971 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6972
6973         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6974         remove disabled code block.
6975
6976 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6977
6978         * gdbarch.sh (get_thread_local_address): New method.
6979         * gdbarch.h, gdbarch.c: Regenerate.
6980         * target.c (target_translate_tls_address): Use
6981         gdbarch_get_thread_local_address if present instead of
6982         target::get_thread_local_address.
6983
6984 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6985
6986         * target.h (target::get_thread_local_address): Update comment.
6987
6988 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6989
6990         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6991         objfile->separate_debug_objfile_backlink if not NULL.
6992
6993 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6994
6995         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6996         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6997         (amd64bsd_store_inferior_registers): Likewise.
6998         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6999         Enable segment base registers.
7000         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7001         PT_GETFSBASE and PT_GETGSBASE.
7002         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7003         PT_SETGSBASE.
7004         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7005         segment base registers.
7006         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7007
7008 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7009
7010         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7011         Update calls to i386_target_description to add 'segments'
7012         parameter.
7013         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7014         add segment base registers.
7015         * arch/i386.c (i386_create_target_description): Add 'segments'
7016         parameter to enable segment base registers.
7017         * arch/i386.h (i386_create_target_description): Likewise.
7018         * features/i386/32bit-segments.xml: New file.
7019         * features/i386/32bit-segments.c: Generate.
7020         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7021         call to i386_target_description to add 'segments' parameter.
7022         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7023         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7024         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7025         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7026         if feature is present.
7027         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7028         Add 'segments' parameter to call to i386_target_description.
7029         (i386_target_description): Add 'segments' parameter to enable
7030         segment base registers.
7031         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7032         to call to i386_target_description.
7033         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7034         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7035         Define I386_NUM_REGS.
7036         (i386_target_description): Add 'segments' parameter to enable
7037         segment base registers.
7038
7039 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7040
7041         PR/24325
7042         * source-cache.c: #undef open and close, to avoid unresolved
7043         externals during linking.
7044
7045 2019-03-12  Tom Tromey  <tromey@adacore.com>
7046
7047         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7048         const.  Add initializers.
7049         (_initialize_remote): Don't initialize ptid globals.
7050
7051 2019-03-12  Pedro Alves  <palves@redhat.com>
7052
7053         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7054
7055 2019-03-12  Pedro Alves  <palves@redhat.com>
7056
7057         * cp-name-parser.y (main): Remove unused 'len' variable.
7058
7059 2019-03-12  Tom Tromey  <tromey@adacore.com>
7060
7061         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7062         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7063
7064 2019-03-12  Tom Tromey  <tromey@adacore.com>
7065
7066         * linux-nat.c (iterate_over_lwps): Update.
7067         (stop_callback): Remove parameter.
7068         (stop_wait_callback, detach_callback, resume_set_callback)
7069         (select_singlestep_lwp_callback, set_ignore_sigint)
7070         (status_callback, resumed_callback, resume_clear_callback)
7071         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7072         data parameter.
7073         (linux_nat_target::detach, linux_nat_target::resume)
7074         (linux_stop_and_wait_all_lwps, select_event_lwp)
7075         (linux_nat_filter_event, linux_nat_wait_1)
7076         (linux_nat_target::kill, linux_nat_target::stop)
7077         (linux_nat_target::stop): Update.
7078         (linux_nat_resume_callback): Change type.
7079         (resume_stopped_resumed_lwps, count_events_callback)
7080         (select_event_lwp_callback): Likewise.
7081         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7082         * arm-linux-nat.c (struct update_registers_data): Remove.
7083         (update_registers_callback): Change type.
7084         (arm_linux_insert_hw_breakpoint1): Update.
7085         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7086         parameter.
7087         (x86_linux_dr_set_addr): Update.
7088         (x86_linux_dr_set_control): Update.
7089         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7090         (iterate_over_lwps): Use gdb::function_view.
7091         * nat/aarch64-linux-hw-point.c (struct
7092         aarch64_dr_update_callback_param): Remove.
7093         (debug_reg_change_callback): Change type.
7094         (aarch64_notify_debug_reg_change): Update.
7095         * s390-linux-nat.c (s390_refresh_per_info): Update.
7096
7097 2019-03-11  Tom Tromey  <tromey@adacore.com>
7098
7099         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7100         redundant assignment to "this_cu".
7101
7102 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7103
7104         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7105
7106 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7107
7108         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7109         from...
7110         (rank_one_type): ... this.
7111
7112 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7113
7114         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7115         from...
7116         (rank_one_type): ... this.
7117
7118 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7119
7120         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7121         from...
7122         (rank_one_type): ... this.
7123
7124 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7125
7126         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7127         from...
7128         (rank_one_type): ... this.
7129
7130 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7131
7132         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7133         from...
7134         (rank_one_type): ... this.
7135
7136 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7137
7138         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7139         from...
7140         (rank_one_type): ... this.
7141
7142 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7143
7144         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7145         from...
7146         (rank_one_type): ... this.
7147
7148 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7149
7150         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7151         from...
7152         (rank_one_type): ... this.
7153
7154 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7155
7156         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7157         from...
7158         (rank_one_type): ... this.
7159
7160 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7161
7162         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7163         from...
7164         (rank_one_type): ... this.
7165
7166 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7167
7168         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7169         from...
7170         (rank_one_type): ... this.
7171
7172 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7173
7174         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7175         from...
7176         (rank_one_type): ... this.
7177
7178 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7179
7180         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7181         inferior-events' shows the example events.
7182
7183 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7184
7185         Support styling on native MS-Windows console
7186
7187         PR/24315
7188         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7189         on MS-Windows if $TERM is not defined.
7190
7191         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7192
7193         * posix-hdep.c (gdb_console_fputs):
7194         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7195         functions.
7196         * ui-file.h (gdb_console_fputs): Add prototype.
7197
7198         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7199         back to fputs only if the former returns zero.
7200
7201 2019-03-07  Tom Tromey  <tom@tromey.com>
7202
7203         * symmisc.c (print_symbol_bcache_statistics): Update.
7204         (print_objfile_statistics): Update.
7205         * symfile.c (allocate_symtab): Update.
7206         * stabsread.c: Don't include bcache.h.
7207         * psymtab.h (struct psymbol_bcache): Don't declare.
7208         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7209         (psymbol_bcache_init, psymbol_bcache_free)
7210         (psymbol_bcache_get_bcache): Don't declare.
7211         * psymtab.c (struct psymbol_bcache): Remove.
7212         (psymtab_storage::psymtab_storage): Update.
7213         (psymtab_storage::~psymtab_storage): Update.
7214         (psymbol_bcache_init, psymbol_bcache_free)
7215         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7216         (add_psymbol_to_bcache): Update.
7217         (allocate_psymtab): Update.
7218         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7219         macro_cache>: No longer pointers.
7220         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7221         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7222         * macrotab.c (macro_bcache): Update.
7223         * macroexp.c: Don't include bcache.h.
7224         * gdbtypes.c (check_types_worklist): Update.
7225         (types_deeply_equal): Remove TRY/CATCH.  Update.
7226         * elfread.c (elf_symtab_read): Update.
7227         * dwarf2read.c: Don't include bcache.h.
7228         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7229         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7230         (print_bcache_statistics, bcache_memory_used): Don't declare.
7231         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7232         methods.  Rename all data members.
7233         * bcache.c (struct bcache): Move to bcache.h.
7234         (bcache::expand_hash_table): Rename from expand_hash_table.
7235         (bcache): Remove.
7236         (bcache::insert): Rename from bcache_full.
7237         (bcache::compare): Rename from bcache_compare.
7238         (bcache_xmalloc): Remove.
7239         (bcache::~bcache): Rename from bcache_xfree.
7240         (bcache::print_statistics): Rename from print_bcache_statistics.
7241         (bcache::memory_used): Rename from bcache_memory_used.
7242
7243 2019-03-07  Pedro Alves  <palves@redhat.com>
7244
7245         * infrun.c (normal_stop): Also check for
7246         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7247
7248 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7249
7250         * f-lang.c (value_from_host_double): Moved to...
7251         * value.c (value_from_host_double): ...here.
7252         * value.h (value_from_host_double): Declare.
7253         * guile/scm-math.c (vlscm_convert_typed_number): Use
7254         value_from_host_double.
7255         (vlscm_convert_number): Likewise.
7256         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7257         * python/py-value.c (convert_value_from_python): Likewise.
7258
7259 2019-03-06  Tom Tromey  <tom@tromey.com>
7260
7261         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7262
7263 2019-03-06  Tom Tromey  <tom@tromey.com>
7264
7265         * utils.h (free_current_contents): Don't declare.
7266         * utils.c (free_current_contents): Remove.
7267
7268 2019-03-06  Tom Tromey  <tom@tromey.com>
7269
7270         * top.c (quit_force): Update.
7271         * main.c (captured_command_loop): Update.
7272         * common/new-op.c (operator new): Update.
7273         * common/common-exceptions.c (struct catcher)
7274         <save_cleanup_chain>: Remove member.
7275         (exceptions_state_mc_init): Update.
7276         (exception_try_scope_entry): Return nullptr.
7277         (exception_try_scope_exit, exception_rethrow)
7278         (throw_exception_sjlj, throw_exception_cxx): Update.
7279         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7280         (all_cleanups, do_cleanups, discard_cleanups)
7281         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7282         (restore_cleanups, restore_final_cleanups): Don't declare.
7283         (do_final_cleanups): Remove parameter.
7284         * common/cleanups.c (cleanup_chain, make_cleanup)
7285         (make_cleanup_dtor, all_cleanups, do_cleanups)
7286         (discard_my_cleanups, discard_cleanups)
7287         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7288         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7289         (null_cleanup): Remove.
7290         (do_final_cleanups): Remove parameter.
7291
7292 2019-03-06  Tom Tromey  <tom@tromey.com>
7293
7294         * remote.c (remote_target::remote_parse_stop_reply): Use
7295         unique_xmalloc_ptr.
7296
7297 2019-03-06  Tom Tromey  <tom@tromey.com>
7298
7299         * stabsread.c (struct stabs_field_info): Rename from field_info.
7300         <list, fnlist>: Add initializers.
7301         <obstack>: New member.
7302         (read_member_functions, read_struct_fields, read_baseclasses):
7303         Allocate on obstack.  Don't use cleanups.
7304         (read_one_struct_field, read_member_functions, read_struct_fields)
7305         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7306         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7307         (read_struct_type): Update.
7308
7309 2019-03-06  Tom Tromey  <tom@tromey.com>
7310
7311         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7312         * common/filestuff.h (make_cleanup_close): Don't declare.
7313         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7314         Remove.
7315
7316 2019-03-06  Tom Tromey  <tom@tromey.com>
7317
7318         * solib-aix.c: Use make_scope_exit.
7319
7320 2019-03-06  Tom Tromey  <tom@tromey.com>
7321
7322         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7323         Use make_scope_exit.
7324
7325 2019-03-06  Tom Tromey  <tom@tromey.com>
7326
7327         * solib-svr4.c (disable_probes_interface): Remove parameter.
7328         (svr4_handle_solib_event): Use make_scope_exit.
7329
7330 2019-03-06  Tom Tromey  <tom@tromey.com>
7331
7332         * remote.c (struct stop_reply_deleter): Remove.
7333         (stop_reply_up): Update.
7334         (struct stop_reply): Derive from notif_event.  Don't typedef.
7335         <regcache>: Now a std::vector.
7336         (stop_reply_xfree): Remove.
7337         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7338         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7339         (remote_target::discard_pending_stop_replies): Use delete.
7340         (remote_target::remote_parse_stop_reply): Update.
7341         (remote_target::process_stop_reply): Update.
7342         * remote-notif.h (struct notif_event): Add virtual destructor.
7343         Remove "dtr" member.
7344         (struct notif_client) <alloc_event>: Return a unique_ptr.
7345         (notif_event_xfree): Don't declare.
7346         (notif_event_up): New typedef.
7347         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7348         (notif_event_xfree, do_notif_event_xfree): Remove.
7349         (remote_notif_state_xfree): Update.
7350
7351 2019-03-06  Tom Tromey  <tom@tromey.com>
7352
7353         * infrun.c (displaced_step_clear_cleanup): Now a
7354         forward_scope_exit type.
7355         (displaced_step_prepare_throw): Update.
7356         (displaced_step_fixup): Update.
7357
7358 2019-03-06  Tom Tromey  <tom@tromey.com>
7359
7360         * inferior.h (class inferior): Update comment.
7361         * gdbthread.h (class thread_info): Update comment.
7362
7363 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7364             Tom Tromey  <tom@tromey.com>
7365
7366         * stabsread.h (struct stab_section_list): Remove.
7367         (coffstab_build_psymtabs): Update.
7368         * dbxread.c (symbuf_sections): Now a std::vector.
7369         (sect_idx): New global.
7370         (fill_symbuf): Update.
7371         (coffstab_build_psymtabs): Change type of stabsects parameter.
7372         Update.
7373         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7374         std::vector.
7375         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7376         (coff_locate_sections): Update.
7377         (coff_symfile_read): Remove cleanups.  Update.
7378         (init_stringtab): Add storage parameter.
7379         (free_stringtab, free_stringtab_cleanup): Remove.
7380         (init_lineno): Add storage parameter.
7381         (free_linetab, free_linetab_cleanup): Remove.
7382
7383 2019-03-06  Pedro Alves  <palves@redhat.com>
7384
7385         * linux-fork.c (fork_info::clobber_regs): Delete.
7386         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7387         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7388         comment.  Adjust.
7389         (scoped_switch_fork_info::scoped_switch_fork_info)
7390         (checkpoint_command, linux_fork_context): Adjust
7391         fork_save_infrun_state calls.
7392
7393 2019-03-06  Pedro Alves  <palves@redhat.com>
7394
7395         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7396         (inf_has_multiple_threads): Return 'bool' and rewrite using
7397         inferior_info::threads().
7398
7399 2019-03-06  Pedro Alves  <palves@redhat.com>
7400
7401         * linux-fork.c: Include <list>.
7402         (fork_list): Now a std::list instance.
7403         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7404         (forks_exist_p, find_last_fork): Adjust.
7405         (new_fork): Delete.
7406         (one_fork_p): New.
7407         (add_fork): Adjust.
7408         (free_fork): Delete, folded into fork_info::~fork_info().
7409         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7410         Adjust.
7411         (init_fork_list): Delete.
7412         (linux_fork_killall, linux_fork_mourn_inferior)
7413         (linux_fork_detach, info_checkpoints_command): Adjust.
7414         (_initialize_linux_fork): No longer call init_fork_list.
7415
7416 2019-03-06  Pedro Alves  <palves@redhat.com>
7417
7418         * linux-fork.c (new_fork): New, split out of ...
7419         (add_fork): ... this.  Return void.  Move "first fork" special
7420         case from here, to ...
7421         (checkpoint_command): ... here.
7422         * linux-linux.h (add_fork): Return void.
7423
7424 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7425
7426         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7427
7428 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7429             Chris January  <chris.january@arm.com>
7430             David Lecomber  <david.lecomber@arm.com>
7431
7432         * f-exp.y: New token, UNOP_INTRINSIC.
7433         (exp): New pattern using UNOP_INTRINSIC token.
7434         (f77_keywords): Add 'abs' keyword.
7435         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7436         (value_from_host_double): New function.
7437         (evaluate_subexp_f): Support UNOP_ABS.
7438
7439 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7440
7441         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7442         types.
7443
7444 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7445
7446         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7447         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7448         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7449
7450 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7451
7452         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7453
7454 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7455             Chris January  <chris.january@arm.com>
7456
7457         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7458         * f-exp.y: Define 'KIND' token.
7459         (exp): New pattern for KIND expressions.
7460         (ptype): Handle types with a kind extension.
7461         (direct_abs_decl): Extend to spot kind extensions.
7462         (f77_keywords): Add 'kind' to the list.
7463         (push_kind_type): New function.
7464         (convert_to_kind_type): New function.
7465         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7466         * parse.c (operator_length_standard): Likewise.
7467         * parser-defs.h (enum type_pieces): Add tp_kind.
7468         * std-operator.def: Add UNOP_KIND.
7469
7470 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7471
7472         * f-exp.y (f_parse): Set yydebug.
7473
7474 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7475
7476         * f-lang.c (evaluate_subexp_f): New function.
7477         (exp_descriptor_f): New global.
7478         (f_language_defn): Use exp_descriptor_f instead of
7479         exp_descriptor_standard.
7480
7481 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7482
7483         * f-exp.y (struct token): Add comments.
7484         (dot_ops): Remove uppercase versions and the end marker.
7485         (f77_keywords): Likewise.
7486         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7487         entries in the dot_ops array are case insensitive, and use
7488         strncasecmp to compare strings.  Also some whitespace cleanup in
7489         this area.  Similar for the f77_keywords array, except entries in
7490         this list might be case sensitive.
7491
7492 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7493
7494         * f-exp.y (struct f77_boolean_val): Add comments.
7495         (boolean_values): Remove uppercase versions, and end marker.
7496         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7497         and use strncasecmp to achieve case insensitivity.  Additionally,
7498         perform whitespace cleanup around this code.
7499
7500 2019-03-06  Tom Tromey  <tromey@adacore.com>
7501
7502         * remote-sim.c (gdbsim_target_open): Use result of
7503         gdb_argv::release.
7504
7505 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7506         Dirk Schubert  <dirk.schubert@arm.com>
7507         Chris January  <chris.january@arm.com>
7508
7509         * eval.c (evaluate_subexp_standard): Call Fortran argument
7510         wrapping logic.
7511         * f-lang.c (struct value): A value which can be passed into a
7512         Fortran function call.
7513         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7514         where appropriate.
7515         (struct type): Value ready for a Fortran function call.
7516         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7517         is needed.
7518         * f-lang.h (fortran_argument_convert): Declaration.
7519         (fortran_preserve_arg_pointer): Declaration.
7520         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7521
7522 2019-03-05  Tom Tromey  <tromey@adacore.com>
7523
7524         * python/py-prettyprint.c (print_string_repr): Remove #if.
7525         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7526
7527 2019-03-05  Tom Tromey  <tromey@adacore.com>
7528
7529         * target.c (the_dummy_target): Move later.  Change type to
7530         "dummy_target".
7531         (initialize_targets): Don't initialize the_dummy_target.
7532
7533 2019-03-05  Tom Tromey  <tromey@adacore.com>
7534
7535         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7536         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7537
7538 2019-03-05  Tom Tromey  <tromey@adacore.com>
7539
7540         * windows-nat.c (windows_nat_target::attach)
7541         (windows_nat_target::detach): Don't call gdb_flush.
7542         * valprint.c (generic_val_print, val_print, val_print_string):
7543         Don't call gdb_flush.
7544         * utils.c (defaulted_query): Don't call gdb_flush.
7545         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7546         * target.c (target_announce_detach): Don't call gdb_flush.
7547         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7548         * remote.c (extended_remote_target::attach): Don't call
7549         gdb_flush.
7550         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7551         * printcmd.c (do_examine): Don't call gdb_flush.
7552         (info_display_command): Don't call gdb_flush.
7553         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7554         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7555         * memattr.c (info_mem_command): Don't call gdb_flush.
7556         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7557         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7558         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7559         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7560         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7561         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7562         (gnu_nat_target::detach): Don't call gdb_flush.
7563         * f-valprint.c (f_val_print): Don't call gdb_flush.
7564         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7565         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7566         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7567         gdb_flush.
7568         * c-valprint.c (c_val_print): Don't call gdb_flush.
7569         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7570
7571 2019-03-05  Tom Tromey  <tromey@adacore.com>
7572
7573         * varobj.c (update_dynamic_varobj_children): Update.
7574         (install_default_visualizer): Use reset, not release.
7575         * value.c (set_internalvar): Update.
7576         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7577         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7578         ATTRIBUTE_UNUSED_RESULT.
7579
7580 2019-03-05  Tom Tromey  <tromey@adacore.com>
7581
7582         * remote.c (class scoped_remote_fd) <release>: Add
7583         ATTRIBUTE_UNUSED_RESULT.
7584
7585 2019-03-05  Tom Tromey  <tromey@adacore.com>
7586
7587         * macroexp.c (struct macro_buffer) <release>: Add
7588         ATTRIBUTE_UNUSED_RESULT.
7589
7590 2019-03-05  Tom Tromey  <tromey@adacore.com>
7591
7592         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7593         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7594         ATTRIBUTE_UNUSED_RESULT.
7595
7596 2019-03-05  Tom Tromey  <tromey@adacore.com>
7597
7598         * common/scoped_fd.h (class scoped_fd) <release>: Add
7599         ATTRIBUTE_UNUSED_RESULT.
7600
7601 2019-03-05  Tom Tromey  <tromey@adacore.com>
7602
7603         * parser-defs.h (struct parser_state) <release>: Add
7604         ATTRIBUTE_UNUSED_RESULT.
7605
7606 2019-03-05  Tom Tromey  <tromey@adacore.com>
7607
7608         * utils.h (class gdb_argv) <release>: Add
7609         ATTRIBUTE_UNUSED_RESULT.
7610         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7611
7612 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7613
7614         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7615         for-loop range, to avoid compiler warnings.
7616
7617         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7618         avoid compiler warnings about unused variables.
7619
7620         * NEWS: Mention end of support for native debugging on MS-Windows
7621         before XP.
7622
7623         PR gdb/24292
7624         * common/netstuff.c:
7625         * gdbserver/gdbreplay.c
7626         * gdbserver/remote-utils.c:
7627         * ser-tcp.c:
7628         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7629         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7630         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7631         'getaddrinfo' and 'freeaddrinfo' were not available before
7632         Windows XP, and mingw.org's MinGW headers by default define
7633         _WIN32_WINNT to 0x500.
7634
7635 2019-03-01  Gary Benson <gbenson@redhat.com>
7636
7637         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7638
7639 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7640             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7641
7642         PR gdb/8527
7643         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7644         set_sigint_trap, clear_sigint_trap.
7645
7646 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7647
7648         * target.c (target_detach): Clear the regcache and the
7649         frame cache.
7650
7651 2019-02-27  Pedro Alves  <palves@redhat.com>
7652
7653         * utils.c (set_screen_size): When we cap the height/width sizes,
7654         tweak the corresponding command variable to show "unlimited":
7655
7656 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7657             Pedro Alves  <palves@redhat.com>
7658
7659         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7660         before calling rl_set_screen_size.
7661
7662 2019-02-27  Tom Tromey  <tromey@adacore.com>
7663
7664         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7665         define.
7666         * python/py-value.c: Remove Python 2.4 workaround.
7667         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7668         workaround.
7669         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7670         Python 2.4 workaround.
7671         * python/python-internal.h: Remove Python 2.4 comment.
7672         (Py_ssize_t): Don't define.
7673         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7674         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7675         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7676         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7677         * python/python.c (do_start_initialization): Remove Python 2.4
7678         workaround.
7679         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7680         (print_children): Remove Python 2.4 workaround.
7681         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7682         workaround.
7683         (CHARBUFFERPROC_NAME): Remove.
7684         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7685         Python 2.4 workaround.
7686
7687 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7688
7689         * NEWS: Note minimum Python version.
7690
7691 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7692
7693         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7694         code from these functions.  Remove corresponding ifdefs.  Use
7695         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7696         Remove gotos and target of gotos.
7697         (infpy_search_memory): Likewise.
7698
7699 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7700
7701         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7702         (hppa_gdbarch_init): Don't register deleted functions with
7703         gdbarch.
7704
7705 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7706
7707         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7708         (h8300_unwind_sp): Delete.
7709         (h8300_dummy_id): Delete.
7710         (h8300_gdbarch_init): Don't register deleted functions with
7711         gdbarch.
7712
7713 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7714
7715         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7716         (ft32_unwind_pc): Delete.
7717         (ft32_unwind_sp): Delete.
7718         (ft32_gdbarch_init): Don't register deleted functions with
7719         gdbarch.
7720
7721 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7722
7723         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7724         (frv_unwind_pc): Delete.
7725         (frv_unwind_sp): Delete.
7726         (frv_gdbarch_init): Don't register deleted functions with
7727         gdbarch.
7728
7729 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7730
7731         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7732         (riscv_unwind_pc): Delete.
7733         (riscv_unwind_sp): Delete.
7734         (riscv_gdbarch_init): Don't register deleted functions with
7735         gdbarch.
7736
7737 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7738
7739         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7740         (csky_unwind_pc): Delete.
7741         (csky_unwind_sp): Delete.
7742         (csky_gdbarch_init): Don't register deleted functions with
7743         gdbarch.
7744
7745 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7746
7747         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7748         (cris_unwind_pc): Delete.
7749         (cris_unwind_sp): Delete.
7750         (cris_gdbarch_init): Don't register deleted functions with
7751         gdbarch.
7752
7753 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7754
7755         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7756         (bfin_unwind_pc): Delete.
7757         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7758
7759 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7760
7761         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7762         (arm_unwind_pc): Delete.
7763         (arm_unwind_sp): Delete.
7764         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7765
7766 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7767
7768         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7769         (arc_unwind_pc): Delete.
7770         (arc_unwind_sp): Delete.
7771         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7772
7773 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7774
7775         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7776         (alpha_unwind_pc): Delete.
7777         (alpha_gdbarch_init): Don't register deleted functions with
7778         gdbarch.
7779
7780 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7781
7782         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7783         (aarch64_unwind_pc): Delete.
7784         (aarch64_unwind_sp): Delete.
7785         (aarch64_gdbarch_init): Don't register deleted functions with
7786         gdbarch.
7787
7788 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7789
7790         * gdbtypes.c (type_align): Don't consider static members when
7791         computing structure alignment.
7792
7793 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7794
7795         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7796         return 0 for other types.
7797         * arch-utils.c (default_type_align): Always return 0.
7798         * gdbarch.h: Regenerate.
7799         * gdbarch.sh (type_align): Extend comment.
7800         * gdbtypes.c (type_align): Add additional comments, always call
7801         gdbarch_type_align before applying the default rules.
7802         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7803         generic code will then apply a suitable default.
7804         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7805         types, return 0 for other types.
7806
7807 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7808
7809         * NEWS: Create a new section for the next release branch.
7810         Rename the section of the current branch, now that it has
7811         been cut.
7812
7813 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7814
7815         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7816         * version.in: Bump version to 8.3.50.DATE-git.
7817
7818 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7819
7820         * aix-thread.c (ptid_cmp): Remove unused variable.
7821         (get_signaled_thread): Likewise.
7822         (store_regs_user_thread): Likewise.
7823         (store_regs_kernel_thread): Likewise.
7824         (fetch_regs_kernel_thread): Remove shadowed variable.
7825
7826 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7827
7828         * features/riscv/32bit-cpu.xml: Add register numbers.
7829         * features/riscv/32bit-fpu.c: Regenerate.
7830         * features/riscv/32bit-fpu.xml: Add register numbers.
7831         * features/riscv/64bit-cpu.xml: Add register numbers.
7832         * features/riscv/64bit-fpu.c: Regenerate.
7833         * features/riscv/64bit-fpu.xml: Add register numbers.
7834
7835 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7836
7837         * NEWS: Mention two argument form of gdb.Value constructor.
7838         * python/py-value.c (convert_buffer_and_type_to_value): New
7839         function.
7840         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7841         Add support for handling an optional second argument.  Call
7842         convert_buffer_and_type_to_value as appropriate.
7843         * python/python-internal.h (Py_buffer_deleter): New struct.
7844         (Py_buffer_up): New typedef.
7845
7846 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7847
7848         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7849         instead of releasing ownership.
7850
7851 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7852
7853         * dwarf2read.c (open_and_init_dwp_file): Call
7854         elf_numsections instead of bfd_count_sections to initialize
7855         dwp_file->num_sections.
7856
7857 2019-02-25  Tom Tromey  <tromey@adacore.com>
7858
7859         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7860
7861 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7862
7863         * gcore.in: Add '--readnever' option when invoking GDB.
7864
7865 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7866
7867         * MAINTAINERS: Update my email address.
7868
7869 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7870
7871         * build-id.c (build_id_to_debug_bfd_1): New function.
7872         (build_id_to_debug_bfd): Look for separate debug file in
7873         sysroot.
7874
7875 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7876
7877         * gdbarch.sh: Update the copyright year range that is placed into
7878         generated files.
7879
7880 2019-02-22  Keith Seitz  <keiths@redhat.com>
7881
7882         PR symtab/23853
7883         * linespec.c (create_sals_line_offset): Search for the default
7884         symtab's filename instead of its fullname.
7885
7886 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7887
7888         * NEWS: Update style defaults.
7889
7890 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7891
7892         * main.c (captured_main_1): Disable styling in batch mode.
7893
7894 2019-02-20  Tom Tromey  <tom@tromey.com>
7895
7896         * symtab.c (symtab_symbol_info): Fix typos.
7897
7898 2019-02-20  Tom Tromey  <tromey@adacore.com>
7899
7900         * findcmd.c (_initialize_mem_search): Use upper case for
7901         metasyntactic variables.
7902
7903 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7904
7905         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7906         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7907
7908 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7909
7910         * top.h (source_file_name): Change to std::string.
7911         * top.c (source_file_name): Likewise.
7912         (command_line_input): Adjust.
7913         * cli/cli-script.c (script_from_file): Adjust.
7914
7915 2019-02-19  Tom Tromey  <tromey@adacore.com>
7916
7917         * ravenscar-thread.c
7918         (ravenscar_thread_target::update_thread_list): Don't call
7919         ada_build_task_list.
7920         * ada-lang.h (ada_build_task_list): Don't declare.
7921         * ada-tasks.c (struct ada_tasks_inferior_data)
7922         <task_list_valid_p>: Now bool.
7923         (read_known_tasks, ada_task_list_changed)
7924         (ada_tasks_invalidate_inferior_data): Update.
7925         (read_known_tasks_array): Return bool.
7926         (read_known_tasks_list): Likewise.
7927         (read_known_tasks): Return void.
7928         (ada_build_task_list): Now static.
7929
7930 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7931
7932         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7933         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7934
7935 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7936
7937         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7938         variant for ada_tasks_pspace_data_handle and
7939         ada_tasks_inferior_data_handle.
7940         (ada_tasks_pspace_data_cleanup): New function.
7941         (ada_tasks_inferior_data_cleanup): New function.
7942
7943 2019-02-17  Tom Tromey  <tom@tromey.com>
7944
7945         * macrotab.h (macro_source_fullname): Return a std::string.
7946         * macrotab.c (macro_include, check_for_redefinition)
7947         (macro_undef, macro_lookup_definition, foreach_macro)
7948         (foreach_macro_in_scope): Update.
7949         (macro_source_fullname): Return a std::string.
7950         * macrocmd.c (show_pp_source_pos): Update.
7951
7952 2019-02-17  Tom Tromey  <tom@tromey.com>
7953
7954         * macrocmd.c (show_pp_source_pos): Style the file names.
7955
7956 2019-02-17  Tom Tromey  <tom@tromey.com>
7957
7958         PR tui/24197:
7959         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7960
7961 2019-02-17  Tom Tromey  <tom@tromey.com>
7962
7963         * ada-lang.c (user_select_syms): Use filtered printing.
7964         * utils.c (wrap_style): New global.
7965         (desired_style): Remove.
7966         (emit_style_escape): Add stream parameter.
7967         (set_output_style, reset_terminal_style, prompt_for_continue):
7968         Update.
7969         (flush_wrap_buffer): Only flush gdb_stdout.
7970         (wrap_here): Set wrap_style.
7971         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7972         treat escape sequences as a character.  Change when wrap buffer is
7973         flushed.
7974         (fputs_styled): Do not set the output style when the default is
7975         requested.
7976         * ui-style.h (struct ui_file_style) <is_default>: New method.
7977         * source.c (print_source_lines_base): Emit escape sequences in one
7978         piece.
7979
7980 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7981
7982         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7983         integers and enumeration types.
7984
7985 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7986
7987         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7988         instead of lookup_symbol_in_language
7989         (do_exact_match): New function.
7990         (ada_get_symbol_name_matcher): Return do_exact_match when
7991         doing a verbatim match.
7992
7993 2019-02-15  Tom Tromey  <tromey@adacore.com>
7994
7995         * ravenscar-thread.c (ravenscar_thread_target::resume)
7996         (ravenscar_thread_target::wait): Special case wildcard requests.
7997
7998 2019-02-15  Tom Tromey  <tromey@adacore.com>
7999
8000         * ravenscar-thread.c (base_ptid): Remove.
8001         (struct ravenscar_thread_target) <close>: New method.
8002         <m_base_ptid>: New member.
8003         <update_inferior_ptid, active_task, task_is_currently_active,
8004         runtime_initialized>: Declare methods.
8005         <ravenscar_thread_target>: Add constructor.
8006         (ravenscar_thread_target::task_is_currently_active)
8007         (ravenscar_thread_target::update_inferior_ptid)
8008         (ravenscar_runtime_initialized): Rename.  Now methods.
8009         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8010         (ravenscar_thread_target::update_thread_list): Update.
8011         (ravenscar_thread_target::active_task): Now method.
8012         (ravenscar_thread_target::store_registers)
8013         (ravenscar_thread_target::prepare_to_store)
8014         (ravenscar_thread_target::prepare_to_store)
8015         (ravenscar_thread_target::mourn_inferior): Update.
8016         (ravenscar_inferior_created): Use "new" to create target.
8017         (ravenscar_thread_target::get_ada_task_ptid): Update.
8018         (_initialize_ravenscar): Don't initialize base_ptid.
8019         (ravenscar_ops): Remove global.
8020
8021 2019-02-15  Tom Tromey  <tromey@adacore.com>
8022
8023         * target.h (push_target): Declare new overload.
8024         * target.c (push_target): New overload, taking an rvalue reference.
8025         * remote.c (remote_target::open_1): Use push_target overload.
8026         * corelow.c (core_target_open): Use push_target overload.
8027
8028 2019-02-15  Tom Tromey  <tromey@adacore.com>
8029
8030         * ravenscar-thread.c (is_ravenscar_task)
8031         (ravenscar_task_is_currently_active): Return bool.
8032         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8033         (_initialize_ravenscar): Remove "(void)".
8034         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8035         Return bool.
8036
8037 2019-02-15  Tom Tromey  <tromey@adacore.com>
8038
8039         * ravenscar-thread.c (ravenscar_runtime_initializer)
8040         (has_ravenscar_runtime, get_running_thread_id)
8041         (ravenscar_thread_target::resume): Fix indentation.
8042
8043 2019-02-15  Tom Tromey  <tromey@adacore.com>
8044
8045         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8046         from ravenscar_arch_ops.
8047         (sparc_ravenscar_ops::fetch_registers)
8048         (sparc_ravenscar_ops::store_registers): Now methods.
8049         (sparc_ravenscar_prepare_to_store): Remove.
8050         (sparc_ravenscar_ops): Redefine.
8051         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8052         methods and destructor.  Remove members.
8053         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8054         (ravenscar_thread_target::store_registers)
8055         (ravenscar_thread_target::prepare_to_store): Update.
8056         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8057         Remove.
8058         (struct ppc_ravenscar_powerpc_ops): Derive from
8059         ravenscar_arch_ops.
8060         (ppc_ravenscar_powerpc_ops::fetch_registers)
8061         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8062         (ppc_ravenscar_powerpc_ops): Redefine.
8063         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8064         (ppc_ravenscar_e500_ops::fetch_registers)
8065         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8066         (ppc_ravenscar_e500_ops): Redefine.
8067         * aarch64-ravenscar-thread.c
8068         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8069         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8070         (aarch64_ravenscar_fetch_registers)
8071         (aarch64_ravenscar_store_registers): Now methods.
8072         (aarch64_ravenscar_ops): Redefine.
8073
8074 2019-02-15  Tom Tromey  <tromey@adacore.com>
8075
8076         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8077         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8078         (ravenscar_thread_target::stopped_by_watchpoint)
8079         (ravenscar_thread_target::stopped_data_address)
8080         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8081
8082 2019-02-15  Tom Tromey  <tromey@adacore.com>
8083
8084         * ravenscar-thread.c: Fix some typos.
8085
8086 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8087             Tom Tromey  <tromey@adacore.com>
8088
8089         * ada-lang.c (ada_exception_sal): Change addr_string to a
8090         std::string.
8091         (create_ada_exception_catchpoint): Update.
8092
8093 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8094             Tom Tromey  <tromey@adacore.com>
8095
8096         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8097         (bp_location_ops): Remove.
8098         (base_breakpoint_allocate_location): Update.
8099         (free_bp_location): Update.
8100         * ada-lang.c (class ada_catchpoint_location)
8101         <ada_catchpoint_location>: Remove ops parameter.
8102         (ada_catchpoint_location_dtor): Remove.
8103         (ada_catchpoint_location_ops): Remove.
8104         (allocate_location_exception): Update.
8105         * breakpoint.h (struct bp_location_ops): Remove.
8106         (class bp_location) <bp_location>: Remove bp_location_ops
8107         parameter.
8108         <~bp_location>: Add destructor.
8109         <ops>: Remove.
8110
8111 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8112             Pedro Alves  <palves@redhat.com>
8113
8114         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8115         'PATH_MAX'.
8116
8117 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8118             Samuel Thibault  <samuel.thibault@gnu.org>
8119             Thomas Schwinge  <thomas@codesourcery.com>
8120
8121         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8122         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8123
8124 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8125
8126         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8127         (check_empty): Use "const char *".
8128
8129         * gnu-nat.c (gnu_nat_target::detach): Instead of
8130         'detach_inferior (pid)' call
8131         'detach_inferior (find_inferior_pid (pid))'.
8132
8133         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8134         'nat/fork-inferior.o'.
8135         * gnu-nat.c: #include "nat/fork-inferior.h".
8136
8137         * gnu-nat.c (gnu_nat_target::detach): Instead of
8138         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8139         * gnu-nat.h: #include "inf-child.h".
8140         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8141         'i386_gnu_nat_target::fetch_registers'.
8142         (gnu_store_registers): Rename/move to
8143         'i386_gnu_nat_target::store_registers'.
8144
8145         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8146         * gnu-nat.h (mach_thread_info): New function.
8147         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8148
8149         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8150
8151 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8152
8153         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8154
8155 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8156
8157         * windows-nat.c (windows_add_thread): Add new parameter
8158         "main_thread_p" with default value set to false.  Update
8159         function documentation as well as all callers.
8160         (windows_delete_thread): Likewise.
8161         (fake_create_process): Update call to windows_add_thread.
8162         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8163         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8164         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8165         call to windows_delete_thread.
8166
8167 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8168
8169         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8170
8171 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8172
8173         * symfile.c (find_separate_debug_file): Use canonical path of
8174         sysroot with child_path instead of gdb_sysroot if it is valid.
8175
8176 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8177
8178         * symfile.c (find_separate_debug_file): Use child_path to
8179         determine if an object file is under a sysroot.
8180
8181 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8182
8183         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8184         unittests/child-path-selftests.c.
8185         * common/pathstuff.c (child_path): New function.
8186         * common/pathstuff.h (child_path): New prototype.
8187         * unittests/child-path-selftests.c: New file.
8188
8189 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8190
8191         * symfile.c (find_separate_debug_file): Look for separate debug
8192         files in debug directories under the sysroot.
8193
8194 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8195
8196         * symtab.h (struct minimal_symbol data_p): New const method.
8197         (struct minimal_symbol text_p): Likewise.
8198         * symtab.c (output_source_filename): Use file name style
8199         to print file name.
8200         (print_symbol_info): Likewise.
8201         (print_msymbol_info): Use address style to print addresses.
8202         Use function name style to print executable text symbols.
8203         (expand_symtab_containing_pc): Use data_p.
8204         (find_pc_sect_compunit_symtab): Likewise.
8205
8206 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8207
8208         * breakpoint.c (describe_other_breakpoints): Use address style
8209         to print addresses.
8210         (say_where): Likewise.
8211
8212 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8213
8214         * ada-typeprint.c (print_func_type): Print function name
8215         style to print function name.
8216         * c-typeprint.c (c_print_type_1): Likewise.
8217
8218 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8219
8220         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8221         for execve.
8222
8223 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8224
8225         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8226         type_stack.
8227
8228 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8229
8230         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8231         TYPE_CODE_REF types.
8232
8233 2019-02-08  Jim Wilson  <jimw@sifive.com>
8234
8235         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8236         (riscv_linux_fregset): New.
8237         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8238
8239 2019-02-07  Tom Tromey  <tom@tromey.com>
8240
8241         * thread.c (thread_cancel_execution_command): Update.
8242         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8243         methods.
8244         (struct thread_fsm_ops): Remove.
8245         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8246         (thread_fsm_should_stop, thread_fsm_return_value)
8247         (thread_fsm_set_finished, thread_fsm_finished_p)
8248         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8249         Don't declare.
8250         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8251         * infrun.c (clear_proceed_status_thread)
8252         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8253         (print_stop_event): Update.
8254         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8255         Add constructor.
8256         (step_command_fsm_ops): Remove.
8257         (new_step_command_fsm): Remove.
8258         (step_1): Update.
8259         (step_command_fsm::should_stop): Rename from
8260         step_command_fsm_should_stop.
8261         (step_command_fsm::clean_up): Rename from
8262         step_command_fsm_clean_up.
8263         (step_command_fsm::do_async_reply_reason): Rename from
8264         step_command_fsm_async_reply_reason.
8265         (struct until_next_fsm): Inherit from thread_fsm.  Add
8266         constructor.
8267         (until_next_fsm_ops): Remove.
8268         (new_until_next_fsm): Remove.
8269         (until_next_fsm::should_stop): Rename from
8270         until_next_fsm_should_stop.
8271         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8272         (until_next_fsm::do_async_reply_reason): Rename from
8273         until_next_fsm_async_reply_reason.
8274         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8275         constructor.  Change type of breakpoint.
8276         (finish_command_fsm_ops): Remove.
8277         (new_finish_command_fsm): Remove.
8278         (finish_command_fsm::should_stop): Rename from
8279         finish_command_fsm_should_stop.
8280         (finish_command_fsm::clean_up): Rename from
8281         finish_command_fsm_clean_up.
8282         (finish_command_fsm::return_value): Rename from
8283         finish_command_fsm_return_value.
8284         (finish_command_fsm::do_async_reply_reason): Rename from
8285         finish_command_fsm_async_reply_reason.
8286         (finish_command): Update.
8287         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8288         Add constructor.
8289         (call_thread_fsm_ops): Remove.
8290         (call_thread_fsm::call_thread_fsm): Rename from
8291         new_call_thread_fsm.
8292         (call_thread_fsm::should_stop): Rename from
8293         call_thread_fsm_should_stop.
8294         (call_thread_fsm::should_notify_stop): Rename from
8295         call_thread_fsm_should_notify_stop.
8296         (run_inferior_call, call_function_by_hand_dummy): Update.
8297         * cli/cli-interp.c (should_print_stop_to_console): Update.
8298         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8299         Add constructor.  Change type of location_breakpoint,
8300         caller_breakpoint.
8301         (until_break_fsm_ops): Remove.
8302         (new_until_break_fsm): Remove.
8303         (until_break_fsm::should_stop): Rename from
8304         until_break_fsm_should_stop.
8305         (until_break_fsm::clean_up): Rename from
8306         until_break_fsm_clean_up.
8307         (until_break_fsm::do_async_reply_reason): Rename from
8308         until_break_fsm_async_reply_reason.
8309         (until_break_command): Update.
8310         * thread-fsm.c: Remove.
8311         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8312
8313 2019-02-07  Tom Tromey  <tom@tromey.com>
8314
8315         * yy-remap.h: Add include guard.
8316         * xtensa-tdep.h: Add include guard.
8317         * xcoffread.h: Rename include guard.
8318         * varobj-iter.h: Add include guard.
8319         * tui/tui.h: Rename include guard.
8320         * tui/tui-winsource.h: Rename include guard.
8321         * tui/tui-wingeneral.h: Rename include guard.
8322         * tui/tui-windata.h: Rename include guard.
8323         * tui/tui-win.h: Rename include guard.
8324         * tui/tui-stack.h: Rename include guard.
8325         * tui/tui-source.h: Rename include guard.
8326         * tui/tui-regs.h: Rename include guard.
8327         * tui/tui-out.h: Rename include guard.
8328         * tui/tui-layout.h: Rename include guard.
8329         * tui/tui-io.h: Rename include guard.
8330         * tui/tui-hooks.h: Rename include guard.
8331         * tui/tui-file.h: Rename include guard.
8332         * tui/tui-disasm.h: Rename include guard.
8333         * tui/tui-data.h: Rename include guard.
8334         * tui/tui-command.h: Rename include guard.
8335         * tic6x-tdep.h: Add include guard.
8336         * target/waitstatus.h: Rename include guard.
8337         * target/wait.h: Rename include guard.
8338         * target/target.h: Rename include guard.
8339         * target/resume.h: Rename include guard.
8340         * target-float.h: Rename include guard.
8341         * stabsread.h: Add include guard.
8342         * rs6000-tdep.h: Add include guard.
8343         * riscv-fbsd-tdep.h: Add include guard.
8344         * regformats/regdef.h: Rename include guard.
8345         * record.h: Rename include guard.
8346         * python/python.h: Rename include guard.
8347         * python/python-internal.h: Rename include guard.
8348         * python/py-stopevent.h: Rename include guard.
8349         * python/py-ref.h: Rename include guard.
8350         * python/py-record.h: Rename include guard.
8351         * python/py-record-full.h: Rename include guard.
8352         * python/py-record-btrace.h: Rename include guard.
8353         * python/py-instruction.h: Rename include guard.
8354         * python/py-events.h: Rename include guard.
8355         * python/py-event.h: Rename include guard.
8356         * procfs.h: Add include guard.
8357         * proc-utils.h: Add include guard.
8358         * p-lang.h: Add include guard.
8359         * or1k-tdep.h: Rename include guard.
8360         * observable.h: Rename include guard.
8361         * nto-tdep.h: Rename include guard.
8362         * nat/x86-linux.h: Rename include guard.
8363         * nat/x86-linux-dregs.h: Rename include guard.
8364         * nat/x86-gcc-cpuid.h: Add include guard.
8365         * nat/x86-dregs.h: Rename include guard.
8366         * nat/x86-cpuid.h: Rename include guard.
8367         * nat/ppc-linux.h: Rename include guard.
8368         * nat/mips-linux-watch.h: Rename include guard.
8369         * nat/linux-waitpid.h: Rename include guard.
8370         * nat/linux-ptrace.h: Rename include guard.
8371         * nat/linux-procfs.h: Rename include guard.
8372         * nat/linux-osdata.h: Rename include guard.
8373         * nat/linux-nat.h: Rename include guard.
8374         * nat/linux-namespaces.h: Rename include guard.
8375         * nat/linux-btrace.h: Rename include guard.
8376         * nat/glibc_thread_db.h: Rename include guard.
8377         * nat/gdb_thread_db.h: Rename include guard.
8378         * nat/gdb_ptrace.h: Rename include guard.
8379         * nat/fork-inferior.h: Rename include guard.
8380         * nat/amd64-linux-siginfo.h: Rename include guard.
8381         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8382         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8383         * nat/aarch64-linux.h: Rename include guard.
8384         * nat/aarch64-linux-hw-point.h: Rename include guard.
8385         * mn10300-tdep.h: Add include guard.
8386         * mips-linux-tdep.h: Add include guard.
8387         * mi/mi-parse.h: Rename include guard.
8388         * mi/mi-out.h: Rename include guard.
8389         * mi/mi-main.h: Rename include guard.
8390         * mi/mi-interp.h: Rename include guard.
8391         * mi/mi-getopt.h: Rename include guard.
8392         * mi/mi-console.h: Rename include guard.
8393         * mi/mi-common.h: Rename include guard.
8394         * mi/mi-cmds.h: Rename include guard.
8395         * mi/mi-cmd-break.h: Rename include guard.
8396         * m2-lang.h: Add include guard.
8397         * location.h: Rename include guard.
8398         * linux-record.h: Rename include guard.
8399         * linux-nat.h: Add include guard.
8400         * linux-fork.h: Add include guard.
8401         * i386-darwin-tdep.h: Rename include guard.
8402         * hppa-linux-offsets.h: Add include guard.
8403         * guile/guile.h: Rename include guard.
8404         * guile/guile-internal.h: Rename include guard.
8405         * gnu-nat.h: Rename include guard.
8406         * gdb-stabs.h: Rename include guard.
8407         * frv-tdep.h: Add include guard.
8408         * f-lang.h: Add include guard.
8409         * event-loop.h: Add include guard.
8410         * darwin-nat.h: Rename include guard.
8411         * cp-abi.h: Rename include guard.
8412         * config/sparc/nm-sol2.h: Rename include guard.
8413         * config/nm-nto.h: Rename include guard.
8414         * config/nm-linux.h: Add include guard.
8415         * config/i386/nm-i386gnu.h: Rename include guard.
8416         * config/djgpp/nl_types.h: Rename include guard.
8417         * config/djgpp/langinfo.h: Rename include guard.
8418         * compile/gcc-cp-plugin.h: Add include guard.
8419         * compile/gcc-c-plugin.h: Add include guard.
8420         * compile/compile.h: Rename include guard.
8421         * compile/compile-object-run.h: Rename include guard.
8422         * compile/compile-object-load.h: Rename include guard.
8423         * compile/compile-internal.h: Rename include guard.
8424         * compile/compile-cplus.h: Rename include guard.
8425         * compile/compile-c.h: Rename include guard.
8426         * common/xml-utils.h: Rename include guard.
8427         * common/x86-xstate.h: Rename include guard.
8428         * common/version.h: Rename include guard.
8429         * common/vec.h: Rename include guard.
8430         * common/tdesc.h: Rename include guard.
8431         * common/selftest.h: Rename include guard.
8432         * common/scoped_restore.h: Rename include guard.
8433         * common/scoped_mmap.h: Rename include guard.
8434         * common/scoped_fd.h: Rename include guard.
8435         * common/safe-iterator.h: Rename include guard.
8436         * common/run-time-clock.h: Rename include guard.
8437         * common/refcounted-object.h: Rename include guard.
8438         * common/queue.h: Rename include guard.
8439         * common/ptid.h: Rename include guard.
8440         * common/print-utils.h: Rename include guard.
8441         * common/preprocessor.h: Rename include guard.
8442         * common/pathstuff.h: Rename include guard.
8443         * common/observable.h: Rename include guard.
8444         * common/netstuff.h: Rename include guard.
8445         * common/job-control.h: Rename include guard.
8446         * common/host-defs.h: Rename include guard.
8447         * common/gdb_wait.h: Rename include guard.
8448         * common/gdb_vecs.h: Rename include guard.
8449         * common/gdb_unlinker.h: Rename include guard.
8450         * common/gdb_unique_ptr.h: Rename include guard.
8451         * common/gdb_tilde_expand.h: Rename include guard.
8452         * common/gdb_sys_time.h: Rename include guard.
8453         * common/gdb_string_view.h: Rename include guard.
8454         * common/gdb_splay_tree.h: Rename include guard.
8455         * common/gdb_setjmp.h: Rename include guard.
8456         * common/gdb_ref_ptr.h: Rename include guard.
8457         * common/gdb_optional.h: Rename include guard.
8458         * common/gdb_locale.h: Rename include guard.
8459         * common/gdb_assert.h: Rename include guard.
8460         * common/filtered-iterator.h: Rename include guard.
8461         * common/filestuff.h: Rename include guard.
8462         * common/fileio.h: Rename include guard.
8463         * common/environ.h: Rename include guard.
8464         * common/common-utils.h: Rename include guard.
8465         * common/common-types.h: Rename include guard.
8466         * common/common-regcache.h: Rename include guard.
8467         * common/common-inferior.h: Rename include guard.
8468         * common/common-gdbthread.h: Rename include guard.
8469         * common/common-exceptions.h: Rename include guard.
8470         * common/common-defs.h: Rename include guard.
8471         * common/common-debug.h: Rename include guard.
8472         * common/cleanups.h: Rename include guard.
8473         * common/buffer.h: Rename include guard.
8474         * common/btrace-common.h: Rename include guard.
8475         * common/break-common.h: Rename include guard.
8476         * cli/cli-utils.h: Rename include guard.
8477         * cli/cli-style.h: Rename include guard.
8478         * cli/cli-setshow.h: Rename include guard.
8479         * cli/cli-script.h: Rename include guard.
8480         * cli/cli-interp.h: Rename include guard.
8481         * cli/cli-decode.h: Rename include guard.
8482         * cli/cli-cmds.h: Rename include guard.
8483         * charset-list.h: Add include guard.
8484         * buildsym-legacy.h: Rename include guard.
8485         * bfin-tdep.h: Add include guard.
8486         * ax.h: Rename include guard.
8487         * arm-linux-tdep.h: Add include guard.
8488         * arm-fbsd-tdep.h: Add include guard.
8489         * arch/xtensa.h: Rename include guard.
8490         * arch/tic6x.h: Add include guard.
8491         * arch/i386.h: Add include guard.
8492         * arch/arm.h: Rename include guard.
8493         * arch/arm-linux.h: Rename include guard.
8494         * arch/arm-get-next-pcs.h: Rename include guard.
8495         * arch/amd64.h: Add include guard.
8496         * arch/aarch64-insn.h: Rename include guard.
8497         * arch-utils.h: Rename include guard.
8498         * annotate.h: Add include guard.
8499         * amd64-darwin-tdep.h: Rename include guard.
8500         * aarch64-linux-tdep.h: Add include guard.
8501         * aarch64-fbsd-tdep.h: Add include guard.
8502         * aarch32-linux-nat.h: Add include guard.
8503
8504 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8505
8506         * macrotab.c (macro_define_internal): New function that
8507         factorizes macro_define_object_internal and macro_define_function
8508         code.
8509         (macro_define_object_internal): Use macro_define_internal.
8510         (macro_define_function): Likewise.
8511
8512 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8513
8514         * macrocmd.c (extract_identifier): Return
8515         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8516         callers.
8517
8518 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8519
8520         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8521
8522 2019-02-05  Tom Tromey  <tom@tromey.com>
8523
8524         * target.c (target_stack::unpush): Move assertion earlier.
8525
8526 2019-01-30  Tom Tromey  <tom@tromey.com>
8527
8528         PR python/23615:
8529         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8530         (gdbpy_parse_and_eval): Likewise.
8531         * python/python-internal.h (gdbpy_allow_threads): New class.
8532
8533 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8534
8535         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8536         (aarch64_fbsd_fpregmap): Move earlier.
8537         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8538         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8539         instead of individual calls to trad_frame_set_reg_addr.
8540         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8541         earlier.
8542         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8543         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8544         instead of individual calls to trad_frame_set_reg_addr.
8545
8546 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8547
8548         * CONTRIBUTE: Replace contribution list with wiki link.
8549
8550 2019-01-25  Tom Tromey  <tom@tromey.com>
8551
8552         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8553
8554 2019-01-25  Tom Tromey  <tom@tromey.com>
8555
8556         * xtensa-linux-nat.c: Fix common/ includes.
8557         * xml-support.h: Fix common/ includes.
8558         * xml-support.c: Fix common/ includes.
8559         * x86-linux-nat.c: Fix common/ includes.
8560         * windows-nat.c: Fix common/ includes.
8561         * varobj.h: Fix common/ includes.
8562         * varobj.c: Fix common/ includes.
8563         * value.c: Fix common/ includes.
8564         * valops.c: Fix common/ includes.
8565         * utils.c: Fix common/ includes.
8566         * unittests/xml-utils-selftests.c: Fix common/ includes.
8567         * unittests/utils-selftests.c: Fix common/ includes.
8568         * unittests/unpack-selftests.c: Fix common/ includes.
8569         * unittests/tracepoint-selftests.c: Fix common/ includes.
8570         * unittests/style-selftests.c: Fix common/ includes.
8571         * unittests/string_view-selftests.c: Fix common/ includes.
8572         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8573         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8574         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8575         * unittests/rsp-low-selftests.c: Fix common/ includes.
8576         * unittests/parse-connection-spec-selftests.c: Fix common/
8577         includes.
8578         * unittests/optional-selftests.c: Fix common/ includes.
8579         * unittests/offset-type-selftests.c: Fix common/ includes.
8580         * unittests/observable-selftests.c: Fix common/ includes.
8581         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8582         * unittests/memrange-selftests.c: Fix common/ includes.
8583         * unittests/memory-map-selftests.c: Fix common/ includes.
8584         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8585         * unittests/function-view-selftests.c: Fix common/ includes.
8586         * unittests/environ-selftests.c: Fix common/ includes.
8587         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8588         * unittests/common-utils-selftests.c: Fix common/ includes.
8589         * unittests/cli-utils-selftests.c: Fix common/ includes.
8590         * unittests/array-view-selftests.c: Fix common/ includes.
8591         * ui-file.c: Fix common/ includes.
8592         * tui/tui-io.c: Fix common/ includes.
8593         * tracepoint.h: Fix common/ includes.
8594         * tracepoint.c: Fix common/ includes.
8595         * tracefile-tfile.c: Fix common/ includes.
8596         * top.h: Fix common/ includes.
8597         * top.c: Fix common/ includes.
8598         * thread.c: Fix common/ includes.
8599         * target/waitstatus.h: Fix common/ includes.
8600         * target/waitstatus.c: Fix common/ includes.
8601         * target.h: Fix common/ includes.
8602         * target.c: Fix common/ includes.
8603         * target-memory.c: Fix common/ includes.
8604         * target-descriptions.c: Fix common/ includes.
8605         * symtab.h: Fix common/ includes.
8606         * symfile.c: Fix common/ includes.
8607         * stap-probe.c: Fix common/ includes.
8608         * spu-linux-nat.c: Fix common/ includes.
8609         * sparc-nat.c: Fix common/ includes.
8610         * source.c: Fix common/ includes.
8611         * solib.c: Fix common/ includes.
8612         * solib-target.c: Fix common/ includes.
8613         * ser-unix.c: Fix common/ includes.
8614         * ser-tcp.c: Fix common/ includes.
8615         * ser-pipe.c: Fix common/ includes.
8616         * ser-base.c: Fix common/ includes.
8617         * selftest-arch.c: Fix common/ includes.
8618         * s12z-tdep.c: Fix common/ includes.
8619         * rust-exp.y: Fix common/ includes.
8620         * rs6000-aix-tdep.c: Fix common/ includes.
8621         * riscv-tdep.c: Fix common/ includes.
8622         * remote.c: Fix common/ includes.
8623         * remote-notif.h: Fix common/ includes.
8624         * remote-fileio.h: Fix common/ includes.
8625         * remote-fileio.c: Fix common/ includes.
8626         * regcache.h: Fix common/ includes.
8627         * regcache.c: Fix common/ includes.
8628         * record-btrace.c: Fix common/ includes.
8629         * python/python.c: Fix common/ includes.
8630         * python/py-type.c: Fix common/ includes.
8631         * python/py-inferior.c: Fix common/ includes.
8632         * progspace.h: Fix common/ includes.
8633         * producer.c: Fix common/ includes.
8634         * procfs.c: Fix common/ includes.
8635         * proc-api.c: Fix common/ includes.
8636         * printcmd.c: Fix common/ includes.
8637         * ppc-linux-nat.c: Fix common/ includes.
8638         * parser-defs.h: Fix common/ includes.
8639         * osdata.c: Fix common/ includes.
8640         * obsd-nat.c: Fix common/ includes.
8641         * nat/x86-linux.c: Fix common/ includes.
8642         * nat/x86-linux-dregs.c: Fix common/ includes.
8643         * nat/x86-dregs.h: Fix common/ includes.
8644         * nat/x86-dregs.c: Fix common/ includes.
8645         * nat/ppc-linux.c: Fix common/ includes.
8646         * nat/mips-linux-watch.h: Fix common/ includes.
8647         * nat/mips-linux-watch.c: Fix common/ includes.
8648         * nat/linux-waitpid.c: Fix common/ includes.
8649         * nat/linux-ptrace.h: Fix common/ includes.
8650         * nat/linux-ptrace.c: Fix common/ includes.
8651         * nat/linux-procfs.c: Fix common/ includes.
8652         * nat/linux-personality.c: Fix common/ includes.
8653         * nat/linux-osdata.c: Fix common/ includes.
8654         * nat/linux-namespaces.c: Fix common/ includes.
8655         * nat/linux-btrace.h: Fix common/ includes.
8656         * nat/linux-btrace.c: Fix common/ includes.
8657         * nat/fork-inferior.c: Fix common/ includes.
8658         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8659         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8660         * nat/aarch64-linux.c: Fix common/ includes.
8661         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8662         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8663         * namespace.h: Fix common/ includes.
8664         * mips-linux-tdep.c: Fix common/ includes.
8665         * minsyms.c: Fix common/ includes.
8666         * mi/mi-parse.h: Fix common/ includes.
8667         * mi/mi-main.c: Fix common/ includes.
8668         * mi/mi-cmd-env.c: Fix common/ includes.
8669         * memrange.h: Fix common/ includes.
8670         * memattr.c: Fix common/ includes.
8671         * maint.h: Fix common/ includes.
8672         * maint.c: Fix common/ includes.
8673         * main.c: Fix common/ includes.
8674         * machoread.c: Fix common/ includes.
8675         * location.c: Fix common/ includes.
8676         * linux-thread-db.c: Fix common/ includes.
8677         * linux-nat.c: Fix common/ includes.
8678         * linux-fork.c: Fix common/ includes.
8679         * inline-frame.c: Fix common/ includes.
8680         * infrun.c: Fix common/ includes.
8681         * inflow.c: Fix common/ includes.
8682         * inferior.h: Fix common/ includes.
8683         * inferior.c: Fix common/ includes.
8684         * infcmd.c: Fix common/ includes.
8685         * inf-ptrace.c: Fix common/ includes.
8686         * inf-child.c: Fix common/ includes.
8687         * ia64-linux-nat.c: Fix common/ includes.
8688         * i387-tdep.c: Fix common/ includes.
8689         * i386-tdep.c: Fix common/ includes.
8690         * i386-linux-tdep.c: Fix common/ includes.
8691         * i386-linux-nat.c: Fix common/ includes.
8692         * i386-go32-tdep.c: Fix common/ includes.
8693         * i386-fbsd-tdep.c: Fix common/ includes.
8694         * i386-fbsd-nat.c: Fix common/ includes.
8695         * guile/scm-type.c: Fix common/ includes.
8696         * guile/guile.c: Fix common/ includes.
8697         * go32-nat.c: Fix common/ includes.
8698         * gnu-nat.c: Fix common/ includes.
8699         * gdbthread.h: Fix common/ includes.
8700         * gdbarch-selftests.c: Fix common/ includes.
8701         * gdb_usleep.c: Fix common/ includes.
8702         * gdb_select.h: Fix common/ includes.
8703         * gdb_bfd.c: Fix common/ includes.
8704         * gcore.c: Fix common/ includes.
8705         * fork-child.c: Fix common/ includes.
8706         * findvar.c: Fix common/ includes.
8707         * fbsd-nat.c: Fix common/ includes.
8708         * event-top.c: Fix common/ includes.
8709         * event-loop.c: Fix common/ includes.
8710         * dwarf2read.c: Fix common/ includes.
8711         * dwarf2loc.c: Fix common/ includes.
8712         * dwarf2-frame.c: Fix common/ includes.
8713         * dwarf-index-cache.c: Fix common/ includes.
8714         * dtrace-probe.c: Fix common/ includes.
8715         * disasm-selftests.c: Fix common/ includes.
8716         * defs.h: Fix common/ includes.
8717         * csky-tdep.c: Fix common/ includes.
8718         * cp-valprint.c: Fix common/ includes.
8719         * cp-support.h: Fix common/ includes.
8720         * cp-support.c: Fix common/ includes.
8721         * corelow.c: Fix common/ includes.
8722         * completer.h: Fix common/ includes.
8723         * completer.c: Fix common/ includes.
8724         * compile/compile.c: Fix common/ includes.
8725         * compile/compile-loc2c.c: Fix common/ includes.
8726         * compile/compile-cplus-types.c: Fix common/ includes.
8727         * compile/compile-cplus-symbols.c: Fix common/ includes.
8728         * command.h: Fix common/ includes.
8729         * cli/cli-dump.c: Fix common/ includes.
8730         * cli/cli-cmds.c: Fix common/ includes.
8731         * charset.c: Fix common/ includes.
8732         * build-id.c: Fix common/ includes.
8733         * btrace.h: Fix common/ includes.
8734         * btrace.c: Fix common/ includes.
8735         * breakpoint.h: Fix common/ includes.
8736         * breakpoint.c: Fix common/ includes.
8737         * ax.h:
8738         (enum agent_op): Fix common/ includes.
8739         * ax-general.c (struct aop_map): Fix common/ includes.
8740         * ax-gdb.c: Fix common/ includes.
8741         * auxv.c: Fix common/ includes.
8742         * auto-load.c: Fix common/ includes.
8743         * arm-tdep.c: Fix common/ includes.
8744         * arch/riscv.c: Fix common/ includes.
8745         * arch/ppc-linux-common.c: Fix common/ includes.
8746         * arch/i386.c: Fix common/ includes.
8747         * arch/arm.c: Fix common/ includes.
8748         * arch/arm-linux.c: Fix common/ includes.
8749         * arch/arm-get-next-pcs.c: Fix common/ includes.
8750         * arch/amd64.c: Fix common/ includes.
8751         * arch/aarch64.c: Fix common/ includes.
8752         * arch/aarch64-insn.c: Fix common/ includes.
8753         * arch-utils.c: Fix common/ includes.
8754         * amd64-windows-tdep.c: Fix common/ includes.
8755         * amd64-tdep.c: Fix common/ includes.
8756         * amd64-sol2-tdep.c: Fix common/ includes.
8757         * amd64-obsd-tdep.c: Fix common/ includes.
8758         * amd64-nbsd-tdep.c: Fix common/ includes.
8759         * amd64-linux-tdep.c: Fix common/ includes.
8760         * amd64-linux-nat.c: Fix common/ includes.
8761         * amd64-fbsd-tdep.c: Fix common/ includes.
8762         * amd64-fbsd-nat.c: Fix common/ includes.
8763         * amd64-dicos-tdep.c: Fix common/ includes.
8764         * amd64-darwin-tdep.c: Fix common/ includes.
8765         * agent.c: Fix common/ includes.
8766         * ada-lang.h: Fix common/ includes.
8767         * ada-lang.c: Fix common/ includes.
8768         * aarch64-tdep.c: Fix common/ includes.
8769
8770 2019-01-25  Tom Tromey  <tom@tromey.com>
8771
8772         * common/create-version.sh: Use common/version.h.
8773
8774 2019-01-24  Pedro Alves  <palves@redhat.com>
8775
8776         * infrun.c (signal_stop, signal_print, signal_program)
8777         (signal_catch, signal_pass): Now arrays instead of pointers.
8778         (update_signals_program_target, do_target_resume)
8779         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8780         * linux-nat.c (linux_nat_target::pass_signals)
8781         (linux_nat_target::create_inferior, linux_nat_target::attach):
8782         Adjust.
8783         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8784         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8785         * procfs.c (procfs_target::pass_signals): Adjust.
8786         * record-full.c (record_full_target::resume): Adjust.
8787         * remote.c (remote_target::pass_signals)
8788         (remote_target::program_signals): Adjust.
8789         * target-debug.h (target_debug_print_signals): Now takes a
8790         gdb::array_view as parameter.  Adjust.
8791         * target.h (target_ops) <pass_signals, program_signals>: Replace
8792         pointer and length parameters with gdb::array_view.
8793         (target_pass_signals, target_program_signals): Likewise.
8794         * target-delegates.c: Regenerate.
8795
8796 2019-01-24  Pedro Alves  <palves@redhat.com>
8797
8798         * common/forward-scope-exit.h
8799         (forward_scope_exit::forward_scope_exit): Pass arguments to
8800         m_bind_function directly, instead of creating a std::bind and
8801         copying that.
8802
8803 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8804
8805         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8806         for static members.
8807         (pass_in_v_vfp_candidate): Likewise.
8808
8809 2019-01-23  Tom Tromey  <tom@tromey.com>
8810             Pedro Alves  <palves@redhat.com>
8811
8812         * regcache.c (class regcache_invalidator): Remove.
8813         (regcache::raw_write): Use make_scope_exit.
8814
8815 2019-01-23  Tom Tromey  <tom@tromey.com>
8816
8817         * ui-out.h (class ui_out_emit_type): Update comment.
8818
8819 2019-01-23  Tom Tromey  <tom@tromey.com>
8820
8821         * infrun.c (fetch_inferior_event): Update comment.
8822
8823 2019-01-23  Tom Tromey  <tom@tromey.com>
8824             Pedro Alves  <palves@redhat.com>
8825
8826         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8827         parameter.
8828         (fetch_inferior_event): Use SCOPE_EXIT.
8829
8830
8831 2019-01-23  Tom Tromey  <tom@tromey.com>
8832             Pedro Alves  <palves@redhat.com>
8833
8834         * infrun.c (disable_thread_events): Delete.
8835         (stop_all_threads): Use SCOPE_EXIT.
8836
8837 2019-01-23  Tom Tromey  <tom@tromey.com>
8838             Pedro Alves  <palves@redhat.com>
8839
8840         * symfile.c: Include forward-scope-exit.h.
8841         (clear_symtab_users_cleanup): Replace forward declaration with
8842         a FORWARD_SCOPE_EXIT.
8843         (syms_from_objfile_1): Use the forward_scope_exit and
8844         gdb::optional instead of cleanup_function.
8845         (reread_symbols): Use the forward_scope_exit instead of
8846         cleanup_function.
8847         (clear_symtab_users_cleanup): Remove function.
8848
8849 2019-01-23  Tom Tromey  <tom@tromey.com>
8850             Pedro Alves  <palves@redhat.com>
8851
8852         * linux-nat.c: Include scope-exit.h.
8853         (cleanup_target_stop): Remove.
8854         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8855         SCOPE_EXIT.
8856
8857 2019-01-23  Tom Tromey  <tom@tromey.com>
8858             Pedro Alves  <palves@redhat.com>
8859
8860         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8861         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8862
8863 2019-01-23  Tom Tromey  <tom@tromey.com>
8864             Andrew Burgess  <andrew.burgess@embecosm.com>
8865             Pedro Alves  <palves@redhat.com>
8866
8867         * infrun.c (fetch_inferior_event): Use scope_exit.
8868         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8869         * top.c (execute_command): Use scope_exit.
8870         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8871         * utils.c (do_bpstat_clear_actions_cleanup)
8872         (make_bpstat_clear_actions_cleanup): Remove.
8873
8874 2019-01-23  Tom Tromey  <tom@tromey.com>
8875             Pedro Alves  <palves@redhat.com>
8876
8877         * infrun.c: Include "common/scope-exit.h"
8878         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8879         (wait_for_inferior): Use SCOPE_EXIT.
8880         (fetch_inferior_event): Use scope_exit.
8881
8882 2019-01-23  Tom Tromey  <tom@tromey.com>
8883             Pedro Alves  <palves@redhat.com>
8884
8885         * breakpoint.c (create_breakpoint): Remove cleanup.
8886
8887 2019-01-23  Tom Tromey  <tom@tromey.com>
8888             Andrew Burgess  <andrew.burgess@embecosm.com>
8889             Pedro Alves  <palves@redhat.com>
8890
8891 2019-01-23  Pedro Alves  <palves@redhat.com>
8892
8893         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8894
8895 2019-01-23  Pedro Alves  <palves@redhat.com>
8896             Andrew Burgess  <andrew.burgess@embecosm.com>
8897
8898         * gdbthread.h: Include "common/forward-scope-exit.h".
8899         (scoped_finish_thread_state): Redefine custom class in terms of
8900         forward_scope_exit.
8901
8902 2019-01-23  Pedro Alves  <palves@redhat.com>
8903             Andrew Burgess  <andrew.burgess@embecosm.com>
8904
8905         * common/forward-scope-exit.h: New file.
8906
8907 2019-01-23  Pedro Alves  <palves@redhat.com>
8908             Andrew Burgess  <andrew.burgess@embecosm.com>
8909             Tom Tromey  <tom@tromey.com>
8910
8911         * common/scope-exit.h: New file.
8912
8913 2019-01-23  Pedro Alves  <palves@redhat.com>
8914
8915         * common/preprocessor.h (ESC): Rename to ...
8916         (ESC_PARENS): ... this.
8917         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8918         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8919
8920 2019-01-23  Tom Tromey  <tom@tromey.com>
8921
8922         * language.h (class scoped_switch_to_sym_language_if_auto):
8923         Initialize m_lang in both cases.
8924
8925 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8926
8927         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8928         with XCNEW.
8929
8930 2019-01-22  Tom Tromey  <tom@tromey.com>
8931
8932         * corelow.c: Do not include sys/file.h.
8933
8934 2019-01-22  Tom Tromey  <tom@tromey.com>
8935
8936         * tui/tui-wingeneral.h: Include gdb_curses.h.
8937
8938 2019-01-22  Tom Tromey  <tom@tromey.com>
8939
8940         * source-cache.h (class source_cache) <get_source_lines,
8941         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8942
8943 2019-01-22  Tom Tromey  <tom@tromey.com>
8944
8945         * remote-fileio.h (struct remote_target): Declare.
8946
8947 2019-01-22  Tom Tromey  <tom@tromey.com>
8948
8949         * python/py-arch.c: Do not include py-ref.h.
8950         * python/py-bpevent.c: Do not include py-ref.h.
8951         * python/py-cmd.c: Do not include py-ref.h.
8952         * python/py-continueevent.c: Do not include py-ref.h.
8953         * python/py-event.h: Do not include py-ref.h.
8954         * python/py-evtregistry.c: Do not include py-ref.h.
8955         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8956         * python/py-frame.c: Do not include py-ref.h.
8957         * python/py-framefilter.c: Do not include py-ref.h.
8958         * python/py-function.c: Do not include py-ref.h.
8959         * python/py-infevents.c: Do not include py-ref.h.
8960         * python/py-linetable.c: Do not include py-ref.h.
8961         * python/py-objfile.c: Do not include py-ref.h.
8962         * python/py-param.c: Do not include py-ref.h.
8963         * python/py-prettyprint.c: Do not include py-ref.h.
8964         * python/py-progspace.c: Do not include py-ref.h.
8965         * python/py-symbol.c: Do not include py-ref.h.
8966         * python/py-symtab.c: Do not include py-ref.h.
8967         * python/py-type.c: Do not include py-ref.h.
8968         * python/py-unwind.c: Do not include py-ref.h.
8969         * python/py-utils.c: Do not include py-ref.h.
8970         * python/py-value.c: Do not include py-ref.h.
8971         * python/py-varobj.c: Do not include py-ref.h.
8972         * python/py-xmethods.c: Do not include py-ref.h.
8973         * python/python.c: Do not include py-ref.h.
8974         * varobj.c: Do not include py-ref.h.
8975
8976 2019-01-22  Tom Tromey  <tom@tromey.com>
8977
8978         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8979         keyword for bcache.
8980
8981 2019-01-22  Tom Tromey  <tom@tromey.com>
8982
8983         * compile/compile-cplus-types.c: Remove a comment by #include.
8984
8985 2019-01-22  Tom Tromey  <tom@tromey.com>
8986
8987         * compile/gcc-c-plugin.h: Include compile-internal.h.
8988
8989 2019-01-22  Tom Tromey  <tom@tromey.com>
8990
8991         * stabsread.c (EXTERN): Do not define.
8992         (symnum, next_symbol_text_func, processing_gcc_compilation)
8993         (within_function, global_sym_chain, global_stabs)
8994         (previous_stab_code, this_object_header_files)
8995         (n_this_object_header_files)
8996         (n_allocated_this_object_header_files): Define.
8997         * stabsread.h (EXTERN): Never define.  Use "extern".
8998
8999 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9000
9001         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9002         history_value.
9003
9004 2019-01-21  Tom Tromey  <tom@tromey.com>
9005
9006         * ui-out.c: Fix includes.
9007         * tui/tui-source.c: Fix includes.
9008         * target.c: Fix includes.
9009         * remote.c: Fix includes.
9010         * regcache.c: Fix includes.
9011         * python/py-block.c: Fix includes.
9012         * printcmd.c: Fix includes.
9013         * or1k-tdep.c: Fix includes.
9014         * mi/mi-main.c: Fix includes.
9015         * m32r-tdep.c: Fix includes.
9016         * csky-tdep.c: Fix includes.
9017         * compile/compile-cplus-types.c: Fix includes.
9018         * cli/cli-interp.c: Fix includes.
9019
9020 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9021
9022         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9023         for padding.
9024
9025 2019-01-16  Tom Tromey  <tom@tromey.com>
9026
9027         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9028         earlier.
9029         (struct objfile) <msymbols_range>: Move from top level.
9030         <msymbols>: New method.
9031         (class objfile_msymbols): Remove.
9032         * symtab.c (default_collect_symbol_completion_matches_break_on):
9033         Update.
9034         * symmisc.c (dump_msymbols): Update.
9035         * stabsread.c (scan_file_globals): Update.
9036         * objc-lang.c (info_selectors_command, info_classes_command)
9037         (find_methods): Update.
9038         * minsyms.c (find_solib_trampoline_target): Update.
9039         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9040         * coffread.c (coff_symfile_read): Update.
9041         * ada-lang.c (ada_lookup_simple_minsym)
9042         (ada_collect_symbol_completion_matches): Update.
9043
9044 2019-01-16  Tom Tromey  <tom@tromey.com>
9045
9046         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9047         type.  Remove no-argument constructor.
9048         <iterator::operator++>: Simplify.
9049         <begin>: Update.
9050         <end>: Use minimal_symbol_count.
9051
9052 2019-01-16  Tom Tromey  <tom@tromey.com>
9053
9054         * objfiles.h (struct objfile) <psymtabs>: New method.
9055         (class objfile_psymtabs): Remove.
9056         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9057         typedef.
9058         <range>: New method.
9059         (require_partial_symbols): Change return type.
9060         * psymtab.c (require_partial_symbols)
9061         (psym_expand_symtabs_matching): Update.
9062         * mdebugread.c (parse_partial_symbols): Update.
9063         * dbxread.c (dbx_end_psymtab): Update.
9064
9065 2019-01-15  Tom Tromey  <tom@tromey.com>
9066
9067         * symtab.c (lookup_objfile_from_block)
9068         (lookup_symbol_in_objfile_symtabs)
9069         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9070         (find_line_symtab, info_sources_command)
9071         (default_collect_symbol_completion_matches_break_on)
9072         (make_source_files_completion_list): Update.
9073         * symmisc.c (print_objfile_statistics, dump_objfile)
9074         (maintenance_print_symbols, maintenance_info_symtabs)
9075         (maintenance_check_symtabs, maintenance_info_line_tables):
9076         Update.
9077         * source.c (select_source_symtab)
9078         (forget_cached_source_info_for_objfile): Update.
9079         * objfiles.h (class objfile_compunits): Remove.
9080         (struct objfile) <compunits_range>: New typedef.
9081         (compunits): New method.
9082         * objfiles.c (objfile_relocate1): Update.
9083         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9084         * maint.c (count_symtabs_and_blocks): Update.
9085         * linespec.c (iterate_over_all_matching_symtabs): Update.
9086         * cp-support.c (add_symbol_overload_list_qualified): Update.
9087         * coffread.c (coff_symtab_read): Update.
9088         * ada-lang.c (add_nonlocal_symbols)
9089         (ada_collect_symbol_completion_matches)
9090         (ada_add_global_exceptions): Update.
9091
9092 2019-01-15  Tom Tromey  <tom@tromey.com>
9093
9094         * progspace.h (program_space) <objfiles_safe_range>: New
9095         typedef.
9096         <objfiles_safe>: New method.
9097         * objfiles.h (class all_objfiles_safe): Remove.
9098         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9099         * jit.c (jit_inferior_exit_hook): Update.
9100
9101 2019-01-17  Tom Tromey  <tom@tromey.com>
9102
9103         * progspace.h (program_space) <objfiles_range>: New typedef.
9104         <objfiles>: New method.
9105         <objfiles_head>: Rename from objfiles.
9106         (object_files): Update.
9107         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9108         * guile/scm-pretty-print.c
9109         (ppscm_find_pretty_printer_from_objfiles): Update.
9110         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9111         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9112         Update.
9113         * python/py-progspace.c (pspy_get_objfiles): Update.
9114         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9115         Update.
9116         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9117         (objfpy_lookup_objfile_by_build_id): Update.
9118         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9119         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9120         Update.
9121         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9122         (expand_symtab_containing_pc, lookup_objfile_from_block)
9123         (lookup_static_symbol, basic_lookup_transparent_type)
9124         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9125         (find_line_symtab, info_sources_command)
9126         (default_collect_symbol_completion_matches_break_on)
9127         (make_source_files_completion_list, find_main_name): Update.
9128         * symmisc.c (print_symbol_bcache_statistics)
9129         (print_objfile_statistics, maintenance_print_symbols)
9130         (maintenance_print_msymbols, maintenance_print_objfiles)
9131         (maintenance_info_symtabs, maintenance_check_symtabs)
9132         (maintenance_expand_symtabs, maintenance_info_line_tables):
9133         Update.
9134         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9135         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9136         (map_overlay_command, unmap_overlay_command)
9137         (simple_overlay_update, expand_symtabs_matching)
9138         (map_symbol_filenames): Update.
9139         * symfile-debug.c (set_debug_symfile): Update.
9140         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9141         Update.
9142         * source.c (select_source_symtab, forget_cached_source_info):
9143         Update.
9144         * solib.c (solib_read_symbols): Update.
9145         * solib-spu.c (append_ocl_sos): Update.
9146         * psymtab.c (maintenance_print_psymbols)
9147         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9148         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9149         * printcmd.c (info_symbol_command): Update.
9150         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9151         Update.
9152         * objfiles.h (class all_objfiles): Remove.
9153         * objfiles.c (have_partial_symbols, have_full_symbols)
9154         (have_minimal_symbols, qsort_cmp, update_section_map)
9155         (shared_objfile_contains_address_p)
9156         (default_iterate_over_objfiles_in_search_order): Update.
9157         * objc-lang.c (info_selectors_command, info_classes_command)
9158         (find_methods): Update.
9159         * minsyms.c (find_solib_trampoline_target): Update.
9160         * maint.c (maintenance_info_sections)
9161         (maintenance_translate_address, count_symtabs_and_blocks):
9162         Update.
9163         * main.c (captured_main_1): Update.
9164         * linux-thread-db.c (try_thread_db_load_from_pdir)
9165         (has_libpthread): Update.
9166         * linespec.c (iterate_over_all_matching_symtabs)
9167         (search_minsyms_for_name): Update.
9168         * jit.c (jit_find_objf_with_entry_addr): Update.
9169         * hppa-tdep.c (find_unwind_entry)
9170         (hppa_lookup_stub_minimal_symbol): Update.
9171         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9172         Update.
9173         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9174         (elf_gnu_ifunc_resolve_by_got): Update.
9175         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9176         * dwarf-index-write.c (save_gdb_index_command): Update.
9177         * cp-support.c (add_symbol_overload_list_qualified): Update.
9178         * breakpoint.c (create_overlay_event_breakpoint)
9179         (create_longjmp_master_breakpoint)
9180         (create_std_terminate_master_breakpoint)
9181         (create_exception_master_breakpoint): Update.
9182         * blockframe.c (find_pc_partial_function): Update.
9183         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9184         (ada_collect_symbol_completion_matches)
9185         (ada_add_global_exceptions): Update.
9186
9187 2019-01-17  Tom Tromey  <tom@tromey.com>
9188
9189         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9190         declare VEC.
9191         (solib_target_parse_libraries): Change return type.
9192         (library_list_start_segment, library_list_start_section)
9193         (library_list_end_library, library_list_start_library); Update.
9194         (solib_target_free_library_list): Remove.
9195         (solib_target_parse_libraries): Remove cleanup.  Change return
9196         type.
9197         (solib_target_current_sos): Update.
9198
9199 2019-01-17  Tom Tromey  <tromey@bapiya>
9200
9201         * valprint.c: Replace "the the" with "the".
9202         * symtab.c: Replace "the the" with "the".
9203         * solib.c: Replace "the the" with "the".
9204         * solib-dsbt.c: Replace "the the" with "the".
9205         * linespec.c: Replace "the the" with "the".
9206         * dwarf2loc.h: Replace "the the" with "the".
9207         * amd64-windows-tdep.c: Replace "the the" with "the".
9208         * aarch64-tdep.c: Replace "the the" with "the".
9209
9210 2019-01-16  Keith Seitz  <keiths@redhat.com>
9211
9212         PR gdb/23773
9213         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9214         <builder>: Rename to ..
9215         <m_builder>: ... this and make private.
9216         (dwarf2_cu::get_builder): New method.  Change all users of
9217         `builder' to use this method.
9218         (dwarf2_start_symtab): Move to ...
9219         (dwarf2_cu::start_symtab): ... here.  Update all callers
9220         (setup_type_unit_groups): Move to ...
9221         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9222         callers.
9223         (dwarf2_cu::reset_builder): New method.
9224         (process_full_compunit, process_full_type_unit): Use
9225         dwarf2_cu::reset_builder.
9226         (follow_die_offset): Record the ancestor CU if it is different
9227         from the followed DIE's CU.
9228         (follow_die_sig_1): Likewise.
9229
9230 2019-01-15  Tom Tromey  <tom@tromey.com>
9231
9232         * remote.c (class remote_state) <buf>: Now a char_vector.
9233         <buf_size>: Remove.
9234         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9235         parameter.
9236         (remote_target::getpkt_or_notif_sane_1)
9237         (remote_target::getpkt_sane)
9238         (remote_target::getpkt_or_notif_sane): Likewise.
9239         (class remote_target) <putpkt>: New overload.
9240         (remote_target::read_frame): Change type of "buf_p".  Remove
9241         sizeof_p parameter.
9242         (packet_ok): New overload.
9243         (packet_check_result): New overload.
9244         Update all uses.
9245
9246 2019-01-14  Tom Tromey  <tom@tromey.com>
9247
9248         * remote-notif.c (handle_notification, remote_notif_ack)
9249         (remote_notif_parse): Make "buf" const.
9250         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9251         const.
9252         (remote_notif_parse, remote_notif_ack, handle_notification):
9253         Likewise.
9254         * remote.c (remote_notif_stop_parse): Make "buf" const.
9255         (remote_target::remote_parse_stop_reply): Make "buf" const.
9256         (remote_notif_stop_ack): Make "buf" const.
9257
9258 2019-01-14  Tom Tromey  <tom@tromey.com>
9259
9260         * remote.c (remote_console_output): Make parameter const.
9261
9262 2019-01-14  Tom Tromey  <tom@tromey.com>
9263
9264         * target-debug.h (target_debug_print_signals): Constify.
9265         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9266         * procfs.c (procfs_target::pass_signals): Update.
9267         * linux-nat.c (linux_nat_target::pass_signals): Update.
9268         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9269         * target-delegates.c: Rebuild.
9270         * remote.c (remote_target::program_signals): Update.
9271         (remote_target::pass_signals): Update.
9272         * target.c (target_pass_signals): Constify argument.
9273         (target_program_signals): Likewise.
9274         * target.h (struct target_ops) <pass_signals, program_signals>:
9275         Constify argument.
9276         (target_pass_signals, target_program_signals): Constify argument.
9277
9278 2019-01-14  Tom Tromey  <tom@tromey.com>
9279
9280         PR tui/28819:
9281         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9282
9283 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9284
9285         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9286         field.
9287         * rs6000-tdep.c: Include reggroups.h.
9288         (IS_V_ALIAS_PSEUDOREG): Define.
9289         (rs6000_register_name): Return names for the "vX" aliases.
9290         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9291         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9292         aliases.  Call default_register_reggroup_p for all other
9293         pseudo-registers.
9294         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9295         New functions.
9296         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9297         Handle "vX" aliases.
9298         (v_alias_pseudo_register_collect): New function.
9299         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9300         (rs6000_gdbarch_init): Initialize "vX" aliases as
9301         pseudo-registers.  Restore registration of
9302         rs6000_pseudo_register_reggroup_p with
9303         set_tdesc_pseudo_register_reggroup_p.
9304
9305 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9306
9307         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9308         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9309         set_gdbarch_num_pseudo_regs.
9310
9311 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9312
9313         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9314         Remove arg prefixname, add do_set and do_show.
9315         Add member functions set_list and show_list.
9316         * cli/cli-style.c (class cli_style_option): Update accordingly.
9317         (style_set_list): Move to file scope.
9318         (style_show_list): Likewise.
9319         (set_style): Call help_list.
9320         (show_style): Call cmd_show_list.
9321         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9322         Update to use the new macro.
9323
9324 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9325
9326         * ada-lang.c (_initialize_ada_language): Expand the help text
9327         for the "catch exception" command.
9328
9329 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9330
9331         * symtab.c (matching_obj_sections): Initialize obj,
9332         declare it closer to its usage.
9333
9334 2019-01-10  Tom Tromey  <tom@tromey.com>
9335
9336         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9337         (basic_inf_threads_range): Remove.
9338         (inf_threads_range, inf_non_exited_threads_range)
9339         (safe_inf_threads_range): Use next_adapter.
9340
9341 2019-01-10  Keith Seitz  <keiths@redhat.com>
9342
9343         PR gdb/23712
9344         PR symtab/23010
9345         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9346         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9347
9348 2019-01-10  Keith Seitz  <keiths@redhat.com>
9349
9350         PR gdb/23712
9351         PR symtab/23010
9352         * dictionary.c (pending_to_vector): Remove.
9353         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9354         Remove _1 suffix, replacing functions of the same name.  Update
9355         all callers.
9356         (dict_create_hashed, dict_create_hashed_expandable)
9357         (dict_create_linear, dict_create_linear_expandable, dict_free)
9358         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9359         Make functions static.
9360
9361 2019-01-10  Keith Seitz  <keiths@redhat.com>
9362
9363         PR gdb/23712
9364         PR symtab/23010
9365         * dictionary.h (struct dictionary): Replace declaration with
9366         multidictionary.
9367         (dict_create_hashed, dict_create_hashed_expandable)
9368         (dict_create_linear, dict_create_linear_expandable)
9369         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9370         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9371         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9372         taking multidictionary argument.
9373         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9374         * block.h (struct block) <dict>: Change to multidictionary
9375         and rename `multidict'.
9376         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9377         symmisc.c: Update all dictionary references to multidictionary.
9378
9379 2019-01-10  Keith Seitz  <keiths@redhat.com>
9380
9381         PR gdb/23712
9382         PR symtab/23010
9383         * dictionary.c: Include unordered_map.
9384         (pending_to_vector): New function.
9385         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9386         Rewrite the non-"_1" functions to take vector instead
9387         of linked list.
9388         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9389         "new" _1 versions of the same name.
9390         (multidictionary): Define.
9391         (std::hash<enum language): New definition.
9392         (collate_pending_symbols_by_language, mdict_create_hashed)
9393         (mdict_create_hashed_expandable, mdict_create_linear)
9394         (mdict_create_linear_expandable, mdict_free)
9395         (find_language_dictionary, create_new_language_dictionary)
9396         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9397         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9398         (mdict_size, mdict_empty): New functions.
9399         * dictionary.h (mdict_iterator): Define.
9400
9401 2019-01-10  Pedro Alves  <palves@redhat.com>
9402
9403         * breakpoint.c (read_uploaded_action)
9404         (create_tracepoint_from_upload): Adjust to use
9405         gdb::unique_xmalloc_ptr.
9406         * ctf.c (ctf_write_uploaded_tp):
9407         (SET_ARRAY_FIELD): Use emplace_back.
9408         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9409         * tracefile-tfile.c (tfile_write_uploaded_tp):
9410         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9411         gdb::unique_xmalloc_ptr.
9412         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9413         at_string, cond_string, cmd_strings>: Replace char pointers
9414         with gdb::unique_xmalloc_ptr.
9415
9416 2019-01-10  Pedro Alves  <palves@redhat.com>
9417
9418         * solib-target.c (library_list_start_library): Don't xstrdup name.
9419
9420 2019-01-10  Pedro Alves  <palves@redhat.com>
9421
9422         * mdebugread.c (parse_partial_symbols): Use
9423         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9424
9425 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9426
9427         * linux-fork.c (scoped_switch_fork_info)
9428         <~scoped_switch_fork_info>: Fix incorrect variable name.
9429
9430 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9431
9432         * linux-fork.c (scoped_switch_fork_info)
9433         <scoped_switch_fork_info>: Make explicit.
9434         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9435
9436 2019-01-10  Tom Tromey  <tom@tromey.com>
9437
9438         * objfiles.h (objfile::reset_psymtabs): Update.
9439         * objfiles.c (objfile::objfile): Update.
9440         * psymtab.h (psymtab_storage::obstack): Update.
9441         (psymtab_storage::m_obstack): Use gdb::optional.
9442         (class psymtab_storage): Update comment.  Remove objfile
9443         parameter.
9444         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9445
9446 2019-01-10  Tom Tromey  <tom@tromey.com>
9447
9448         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9449         <free_psymtabs>: Now private.
9450         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9451         (allocate_psymtab): Use new method.
9452
9453 2019-01-10  Tom Tromey  <tom@tromey.com>
9454
9455         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9456         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9457         * mdebugread.c (parse_partial_symbols): Use
9458         allocate_dependencies.
9459         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9460         allocate_dependencies.
9461         (process_psymtab_comp_unit_reader)
9462         (build_type_psymtab_dependencies): Likewise.
9463         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9464
9465 2019-01-10  Tom Tromey  <tom@tromey.com>
9466
9467         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9468         PSYMBOL_SET_LANGUAGE.
9469         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9470
9471 2019-01-10  Tom Tromey  <tom@tromey.com>
9472
9473         * psymtab.h (psymtab_storage::obstack): New method.
9474         <m_obstack>: Rename from obstack; now private.
9475         * psymtab.c (psymtab_storage): Update.
9476         * dwarf2read.c (create_addrmap_from_index)
9477         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9478         Update.
9479
9480 2019-01-10  Tom Tromey  <tom@tromey.com>
9481
9482         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9483         * objfiles.h (objfile::reset_psymtabs): New method.
9484
9485 2019-01-10  Tom Tromey  <tom@tromey.com>
9486
9487         * symmisc.c (print_symbol_bcache_statistics): Update.
9488         (print_objfile_statistics): Update.
9489         * symfile.c (reread_symbols): Update.
9490         * psymtab.h (class psymtab_storage): New.
9491         * psymtab.c (psymtab_storage): New constructor.
9492         (~psymtab_storage): New destructor.
9493         (require_partial_symbols): Update.
9494         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9495         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9496         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9497         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9498         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9499         (start_psymtab_common, end_psymtab_common)
9500         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9501         (allocate_psymtab): Update.
9502         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9503         Update.
9504         (dump_psymtab_addrmap, maintenance_print_psymbols)
9505         (maintenance_check_psymtabs): Update.
9506         (class objfile_psymtabs): Move to objfiles.h.
9507         * psympriv.h (discard_psymtab): Now inline.
9508         (psymtab_discarder::psymtab_discarder): Update.
9509         (psymtab_discarder::~psymtab_discarder): Update.
9510         (ALL_OBJFILE_PSYMTABS): Rewrite.
9511         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9512         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9513         Remove fields.
9514         <partial_symtabs>: New field.
9515         (class objfile_psymtabs): Move from psymtab.h.  Update.
9516         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9517         psymbol_cache.
9518         (objfile::~objfile): Don't destroy psymbol_cache.
9519         * mdebugread.c (parse_partial_symbols): Update.
9520         * dwarf2read.c (create_addrmap_from_index)
9521         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9522         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9523         (add_partial_subprogram, dwarf2_ranges_read): Update.
9524         * dwarf-index-write.c (write_address_map)
9525         (write_one_signatured_type, recursively_write_psymbols)
9526         (class debug_names, class debug_names, write_psymtabs_to_index):
9527         Update.
9528
9529 2019-01-10  Tom Tromey  <tom@tromey.com>
9530
9531         * symtab.h (SYMBOL_SET_NAMES): Update.
9532         (symbol_set_names): Update.
9533         (MSYMBOL_SET_NAMES): Update.
9534         * symtab.c (symbol_set_names): Change argument to be an
9535         objfile_per_bfd_storage.
9536         * psymtab.c (add_psymbol_to_bcache): Update.
9537         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9538
9539 2019-01-10  Tom Tromey  <tom@tromey.com>
9540
9541         * symtab.c (create_demangled_names_hash): Change argument to be an
9542         objfile_per_bfd_storage.
9543         (symbol_set_names): Update.
9544
9545 2019-01-10  Tom Tromey  <tom@tromey.com>
9546
9547         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9548         init_psymbol_list.
9549         * psymtab.c (init_psymbol_list): Do nothing if already called.
9550         * psympriv.h (init_psymbol_list): Add comment.
9551         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9552         init_psymbol_list.
9553         * dbxread.c (dbx_symfile_read): Unconditionally call
9554         init_psymbol_list.
9555
9556 2019-01-10  Tom Tromey  <tom@tromey.com>
9557
9558         * xcoffread.c (scan_xcoff_symtab): Update.
9559         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9560         "where".
9561         * mdebugread.c (parse_partial_symbols)
9562         (handle_psymbol_enumerators): Update.
9563         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9564         * dbxread.c (read_dbx_symtab): Update.
9565         * psympriv.h (psymbol_placement): New enum.
9566         (add_psymbol_to_list): Update.
9567
9568 2019-01-10  Tom Tromey  <tom@tromey.com>
9569
9570         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9571         static_psymbols parameters.
9572         (scan_xcoff_symtab): Update.
9573         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9574         static_psymbols parameters.
9575         * psympriv.h (start_psymtab_common): Update.
9576         * mdebugread.c (parse_partial_symbols): Update.
9577         * dwarf2read.c (create_partial_symtab): Update.
9578         * dbxread.c (read_dbx_symtab): Update.
9579         (start_psymtab): Remove global_psymbols and static_psymbols
9580         parameters.
9581
9582 2019-01-10  Tom Tromey  <tom@tromey.com>
9583
9584         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9585         * psymtab.c (allocate_psymtab): Add comment.
9586         * psympriv.h (allocate_psymtab): Add comment.
9587         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9588         initializations.
9589         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9590
9591 2019-01-10  Tom Tromey  <tom@tromey.com>
9592
9593         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9594         Don't declare.
9595         * mipsread.c: Include mdebugread.h.
9596         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9597         Declare.
9598         * elfread.c: Include mdebugread.h.
9599
9600 2019-01-09  Tom Tromey  <tom@tromey.com>
9601
9602         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9603         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9604         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9605         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9606         (psym_lookup_symbol, psym_find_last_source_symtab)
9607         (psym_forget_cached_source_info, psym_print_stats)
9608         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9609         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9610         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9611         (psym_find_compunit_symtab_by_address)
9612         (maintenance_print_psymbols, maintenance_info_psymtabs)
9613         (maintenance_check_psymtabs): Use ranged for.
9614         * psymtab.h (class objfile_psymtabs): New.
9615         (require_partial_symbols): Return objfile_psymtabs.
9616         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9617
9618 2019-01-09  Tom Tromey  <tom@tromey.com>
9619
9620         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9621         (find_pc_mapped_section, list_overlays_command)
9622         (map_overlay_command, unmap_overlay_command)
9623         (simple_overlay_update): Use all_objfiles.
9624         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9625         * printcmd.c (info_symbol_command): Use all_objfiles.
9626         * objfiles.h (ALL_OBJSECTIONS): Remove.
9627         * maint.c (maintenance_translate_address): Use all_objfiles.
9628         * gcore.c (gcore_create_callback): Use all_objfiles.
9629         (objfile_find_memory_regions): Likewise.
9630
9631 2019-01-09  Tom Tromey  <tom@tromey.com>
9632
9633         * symtab.c (find_line_symtab, info_sources_command)
9634         (make_source_files_completion_list): Use objfile_compunits.
9635         * source.c (select_source_symtab): Use objfile_compunits.
9636         * objfiles.h (struct objfile): Update comment.
9637         (ALL_OBJFILES): Remove.
9638         (ALL_FILETABS): Remove.
9639         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9640         objfile_compunits.
9641
9642 2019-01-09  Tom Tromey  <tom@tromey.com>
9643
9644         * symmisc.c (print_objfile_statistics, dump_objfile)
9645         (maintenance_print_symbols): Use compunit_filetabs.
9646         * source.c (forget_cached_source_info_for_objfile): Use
9647         compunit_filetabs.
9648         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9649         (ALL_FILETABS): Use compunit_filetabs.
9650         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9651         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9652
9653 2019-01-09  Tom Tromey  <tom@tromey.com>
9654
9655         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9656         (compunit_filetabs): New.
9657         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9658         compunit_filetabs.
9659         (info_sources_command, make_source_files_completion_list): Remove
9660         declaration.
9661         * symmisc.c (print_objfile_statistics, dump_objfile)
9662         (maintenance_print_symbols): Remove declaration.
9663         (maintenance_info_symtabs): Use compunit_filetabs.
9664         (maintenance_info_line_tables): Likewise.
9665         * source.c (select_source_symtab): Change local variable name.
9666         (forget_cached_source_info_for_objfile): Remove declaration.
9667         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9668         * objfiles.c (objfile_relocate1): Remove declaration.
9669         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9670         declaration.
9671         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9672         * coffread.c (coff_symtab_read): Remove declaration.
9673         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9674         compunit_filetabs.
9675
9676 2019-01-09  Tom Tromey  <tom@tromey.com>
9677
9678         * symtab.c (lookup_objfile_from_block)
9679         (find_pc_sect_compunit_symtab, search_symbols)
9680         (default_collect_symbol_completion_matches_break_on): Use
9681         objfile_compunits.
9682         * objfiles.h (ALL_COMPUNITS): Remove.
9683         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9684         * cp-support.c (add_symbol_overload_list_qualified): Use
9685         objfile_compunits.
9686         * ada-lang.c (ada_collect_symbol_completion_matches)
9687         (ada_add_global_exceptions): Use objfile_compunits.
9688
9689 2019-01-09  Tom Tromey  <tom@tromey.com>
9690
9691         * source.c (select_source_symtab)
9692         (forget_cached_source_info_for_objfile): Remove declaration.
9693         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9694         declaration.
9695         * maint.c (count_symtabs_and_blocks): Remove declaration.
9696         * cp-support.c (add_symbol_overload_list_qualified): Remove
9697         declaration.
9698         * coffread.c (coff_symtab_read): Remove declaration.
9699         * symtab.c (lookup_symbol_in_objfile_symtabs)
9700         (basic_lookup_transparent_type_1): Use objfile_compunits.
9701         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9702         (info_sources_command, search_symbols)
9703         (default_collect_symbol_completion_matches_break_on)
9704         (make_source_files_completion_list): Remove declaration.
9705         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9706         (ada_collect_symbol_completion_matches)
9707         (ada_add_global_exceptions): Remove declaration.
9708         * linespec.c (iterate_over_all_matching_symtabs): Use
9709         objfile_compunits.
9710         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9711         (class objfile_compunits): New.
9712         (ALL_COMPUNITS): Use objfile_compunits.
9713         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9714         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9715         objfile_compunits.
9716         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9717
9718 2019-01-09  Tom Tromey  <tom@tromey.com>
9719
9720         * symtab.c (search_symbols)
9721         (default_collect_symbol_completion_matches_break_on): Use
9722         objfile_msymbols.
9723         * ada-lang.c (ada_lookup_simple_minsym)
9724         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9725         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9726         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9727         objfile_msymbols.
9728         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9729         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9730         * objc-lang.c (find_methods): Use objfile_msymbols.
9731         (info_selectors_command, info_classes_command): Likewise.
9732         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9733         * objfiles.h (class objfile_msymbols): New.
9734         (ALL_OBJFILE_MSYMBOLS): Remove.
9735         (ALL_MSYMBOLS): Remove.
9736
9737 2019-01-09  Tom Tromey  <tom@tromey.com>
9738
9739         * common/next-iterator.h (next_adapter): Add Iterator template
9740         parameter.
9741         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9742         (class all_objfiles_safe): New.
9743         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9744         * objfiles.c (put_objfile_before): Update comment.
9745         (add_separate_debug_objfile): Likewise.
9746         (free_all_objfiles): Use all_objfiles_safe.
9747         (objfile_purge_solibs): Likewise.
9748
9749 2019-01-09  Tom Tromey  <tom@tromey.com>
9750
9751         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9752         (expand_symtab_containing_pc, lookup_static_symbol)
9753         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9754         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9755         all_objfiles.
9756         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9757         * breakpoint.c (create_overlay_event_breakpoint)
9758         (create_longjmp_master_breakpoint)
9759         (create_std_terminate_master_breakpoint)
9760         (create_exception_master_breakpoint): Use all_objfiles.
9761         * linux-thread-db.c (try_thread_db_load_from_pdir)
9762         (has_libpthread): Use all_objfiles.
9763         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9764         * linespec.c (iterate_over_all_matching_symtabs)
9765         (search_minsyms_for_name): Use all_objfiles.
9766         * maint.c (maintenance_info_sections): Use all_objfiles.
9767         * main.c (captured_main_1): Use all_objfiles.
9768         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9769         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9770         * guile/scm-pretty-print.c
9771         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9772         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9773         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9774         (maintenance_print_msymbols): Use all_objfiles.
9775         * source.c (select_source_symtab): Use all_objfiles.
9776         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9777         * symfile.c (remove_symbol_file_command)
9778         (expand_symtabs_matching, map_symbol_filenames): Use
9779         all_objfiles.
9780         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9781         all_objfiles.
9782         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9783         * objc-lang.c (find_methods): Use all_objfiles.
9784         * objfiles.c (have_partial_symbols, have_full_symbols)
9785         (have_minimal_symbols, qsort_cmp)
9786         (default_iterate_over_objfiles_in_search_order): Use
9787         all_objfiles.
9788         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9789         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9790         (maintenance_check_psymtabs): Use all_objfiles.
9791         (ALL_PSYMTABS): Remove.
9792         * compile/compile-object-run.c (do_module_cleanup): Use
9793         all_objfiles.
9794         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9795         * cp-support.c (add_symbol_overload_list_qualified): Use
9796         all_objfiles.
9797         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9798         Use all_objfiles.
9799         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9800         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9801         all_objfiles.
9802         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9803         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9804         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9805         Uses all_objfiles.
9806         * solib.c (solib_read_symbols): Use all_objfiles
9807
9808 2019-01-09  Tom Tromey  <tom@tromey.com>
9809
9810         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9811         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9812         all_objfiles.
9813         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9814         * symmisc.c (print_symbol_bcache_statistics)
9815         (print_objfile_statistics, maintenance_print_objfiles)
9816         (maintenance_info_symtabs, maintenance_check_symtabs)
9817         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9818         all_objfiles.
9819         * source.c (forget_cached_source_info): Use all_objfiles.
9820         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9821         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9822         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9823         * objfiles.c (update_section_map): Use all_objfiles.
9824         (shared_objfile_contains_address_p): Likewise.
9825         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9826         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9827
9828 2019-01-09  Tom Tromey  <tom@tromey.com>
9829
9830         * common/next-iterator.h: New file.
9831         * objfiles.h (class all_objfiles): New.
9832         (struct objfile_iterator): New.
9833
9834 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9835
9836         * NEWS: Move the description of the changed "frame", "select-frame",
9837          and "info frame" commands to the Changed commands section.
9838
9839 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9840
9841         * gdbtypes.c (check_stub_method_group): Remove handling of old
9842         mangling schemes.
9843         * linespec.c (find_methods): Likewise.
9844         * stabsread.c (read_member_functions): Likewise.
9845         * valops.c (search_struct_method): Likewise.
9846         (value_struct_elt_for_reference): Likewise.
9847         * NEWS: Mention this change.
9848
9849 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9850
9851         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9852         print_source_lines.
9853         * source.c (print_source_lines_base): Update line number check.
9854         (print_source_lines): New function.
9855         (source_lines_range::source_lines_range): New function.
9856         * source.h (class source_lines_range): New class.
9857         (print_source_lines): New declaration.
9858
9859 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9860
9861         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9862
9863 2019-01-08  Tom Tromey  <tom@tromey.com>
9864             Simon Marchi  <simon.marchi@ericsson.com>
9865
9866         PR gdb/24060
9867         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9868         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9869         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9870         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9871         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9872         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9873
9874 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9875
9876         * source.c (select_source_symtab): Move header comment to
9877         declaration in source.h.
9878         (forget_cached_source_info_for_objfile): Likewise.
9879         (forget_cached_source_info): Likewise.
9880         (identify_source_line): Likewise.
9881         * source.h (identify_source_line): Move declaration from symtab.h
9882         and add comment from source.c
9883         (print_source_lines): Likewise.
9884         (forget_cached_source_info_for_objfile): Likewise.
9885         (forget_cached_source_info): Likewise.
9886         (select_source_symtab): Likewise.
9887         (enum print_source_lines_flag): Move definition from symtab.h.
9888         * symtab.h (identify_source_line): Move declaration to source.h.
9889         (print_source_lines): Likewise.
9890         (forget_cached_source_info_for_objfile): Likewise.
9891         (forget_cached_source_info): Likewise.
9892         (select_source_symtab): Likewise.
9893         (enum print_source_lines_flag): Move definition to source.h.
9894         * tui/tui-hooks.c: Add 'source.h' include.
9895
9896 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9897
9898         * source.c (print_source_lines_base): Handle requests to print
9899         reverse line number sequences, and guard against empty lines
9900         string.
9901
9902 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9903
9904         * source.c (print_source_lines_base): Fix skip of '\r' if next
9905         character is '\n'.
9906
9907 2019-01-06  Tom Tromey  <tom@tromey.com>
9908
9909         * c-exp.y (struct c_parse_state) <macro_original_text,
9910         expansion_obstack>: New member.
9911         (macro_original_text, expansion_obstack): Remove globals.
9912         (scan_macro_expansion, scanning_macro_expansion)
9913         (finished_macro_expansion): Update.
9914         (scan_macro_cleanup): Remove.
9915         (yylex, c_parse): Update.
9916
9917 2019-01-06  Tom Tromey  <tom@tromey.com>
9918
9919         * c-exp.y (struct c_parse_state) <strings>: New member.
9920         (operator_stoken): Update.
9921
9922 2019-01-06  Tom Tromey  <tom@tromey.com>
9923
9924         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9925         (union type_stack_elt) <typelist_val>: Now a pointer to
9926         std::vector.
9927         (type_stack_cleanup): Don't declare.
9928         (push_typelist): Update.
9929         * parse.c (pop_typelist): Return a std::vector.
9930         (push_typelist): Take a std::vector.
9931         (follow_types): Update.  Do not free args.
9932         (type_stack_cleanup): Remove.
9933         * c-exp.y (struct c_parse_state): New.
9934         (cpstate): New global.
9935         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9936         (nonempty_typelist): Update.
9937         (func_mod): Create a new vector.
9938         (c_parse): Create a c_parse_state.
9939         (check_parameter_typelist): Do not delete params.
9940         (function_method): Update.  Do not delete type_list.
9941
9942 2019-01-06  Tom Tromey  <tom@tromey.com>
9943
9944         PR gdb/28155:
9945         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9946         check_typedef.
9947         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9948         (print_return_value): Likewise.
9949
9950 2019-01-05  Tom Tromey  <tom@tromey.com>
9951
9952         * contrib/cleanup_check.py: Remove.
9953         * contrib/gcc-with-excheck: Remove.
9954         * contrib/exsummary.py: Remove.
9955         * contrib/excheck.py: Remove.
9956
9957 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9958
9959         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9960         NULL. Initialize tpprev to NULL instead of assigning it
9961         to NULL on the next statement.
9962         * windows-nat.c (windows_delete_thread): Remove check for
9963         main_thread_id before printing thread exit notifications.
9964         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9965         Remove thread ID check against main_thread_id.
9966         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9967         windows_delete_thread.
9968         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9969
9970 2019-01-04  Tom Tromey  <tom@tromey.com>
9971
9972         * compile/compile.c (_initialize_compile): Use upper case for
9973         metasyntactic variables.
9974         * symmisc.c (_initialize_symmisc): Use upper case for
9975         metasyntactic variables.
9976         * psymtab.c (_initialize_psymtab): Use upper case for
9977         metasyntactic variables.
9978         * demangle.c (demangle_command): Use upper case for metasyntactic
9979         variables.
9980         (_initialize_demangler): Likewise.
9981         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9982         variables.
9983
9984 2019-01-03  Tom Tromey  <tom@tromey.com>
9985
9986         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9987
9988 2019-01-03  Tom Tromey  <tom@tromey.com>
9989
9990         * python/py-symtab.c (salpy_str): Update.
9991         (struct salpy_sal_object) <symtab>: Now a PyObject.
9992         (salpy_dealloc): Update.
9993         (del_objfile_sal): Use gdbpy_ref.
9994
9995 2019-01-03  Tom Tromey  <tom@tromey.com>
9996
9997         * python/py-type.c (convert_field): Use new_reference.  Return
9998         gdbpy_ref.
9999         (make_fielditem): Return gdbpy_ref.
10000         (typy_fields): Update.
10001         (typy_getitem): Update.
10002         (field_name): Return gdbpy_ref.  Use new_reference.
10003         (typy_iterator_iternext): Update.
10004
10005 2019-01-03  Tom Tromey  <tom@tromey.com>
10006
10007         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10008
10009 2019-01-03  Tom Tromey  <tom@tromey.com>
10010
10011         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10012         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10013         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10014         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10015         (pspy_set_type_printers): Likewise.
10016         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10017         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10018         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10019         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10020         (objfpy_set_type_printers): Likewise.
10021
10022 2019-01-03  Tom Tromey  <tom@tromey.com>
10023
10024         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10025         (gdbpy_print_stack): Use gdbpy_err_fetch.
10026         * python/python-internal.h (class gdbpy_err_fetch): New class.
10027         (class gdbpy_enter) <m_error_type, m_error_value,
10028         m_error_traceback>: Remove.
10029         <m_error>: New member.
10030         (gdbpy_exception_to_string): Don't declare.
10031         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10032         * python/py-value.c (convert_value_from_python): Use
10033         gdbpy_err_fetch.
10034         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10035         gdbpy_exception_to_string.
10036         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10037         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10038         gdbpy_err_fetch.
10039
10040 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10041
10042         * linux-nat.c (delete_lwp_cleanup): Delete.
10043         (struct lwp_deleter): New struct.
10044         (lwp_info_up): New typedef.
10045         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10046         lwp_info_up.
10047
10048 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10049
10050         * linux-fork.c (class scoped_switch_fork_info): New class.
10051         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10052
10053 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10054
10055         * valops.c (find_overload_match): Remove use of null_cleanup, and
10056         calls to do_cleanups.
10057
10058 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10059
10060         * compile/compile-cplus-types.c
10061         (compile_cplus_instance::decl_name): Handle changes to
10062         cp_func_name.
10063         * cp-support.c (cp_func_name): Update header comment, update
10064         return type.
10065         * cp-support.h (cp_func_name): Update return type in declaration.
10066         * valops.c (find_overload_match): Move temp_func local to top
10067         level of function and change its type.  Use temp_func to hold and
10068         delete temporary string obtained from cp_func_name.
10069
10070 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10071
10072         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10073         gdb::char_vector, remove cleanup, and update uses of `msg`.
10074
10075 2019-01-03  Jim Wilson  <jimw@sifive.com>
10076
10077         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10078
10079 2019-01-02  Tom Tromey  <tom@tromey.com>
10080
10081         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10082         (tdesc_parse_xml): Remove cleanups.
10083         * target-descriptions.h (make_cleanup_free_target_description):
10084         Don't declare.
10085         (target_desc_deleter): New struct.
10086         (target_desc_up): New typedef.
10087         * target-descriptions.c (target_desc_deleter::operator()): Rename
10088         from free_target_description.
10089         (make_cleanup_free_target_description): Remove.
10090
10091 2019-01-02  Tom Tromey  <tom@tromey.com>
10092
10093         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10094         constructor, destructor.
10095         (linespec_parser): Remove typedef.
10096         (~linespec_parser): Rename from linespec_parser_delete.
10097         (linespec_lex_to_end, linespec_complete_label)
10098         (linespec_complete): Update.
10099         (decode_line_full): Remove cleanups.
10100         (decode_line_1): Update.
10101
10102 2019-01-02  Tom Tromey  <tom@tromey.com>
10103
10104         * python/python-internal.h (inferior_to_inferior_object): Change
10105         return type.
10106         * python/py-exitedevent.c (create_exited_event_object): Update.
10107         * python/py-inferior.c (inferior_to_inferior_object): Return
10108         gdbpy_ref.
10109         (python_new_inferior, python_inferior_deleted)
10110         (thread_to_thread_object, delete_thread_object)
10111         (build_inferior_list, gdbpy_selected_inferior): Update.
10112         * python/py-infthread.c (create_thread_object): Update.  Also fail
10113         if inferior_to_inferior_object fails.
10114
10115 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10116
10117         * inferior.h (class inferior) <displaced_step_state>: New field.
10118         * infrun.h (struct displaced_step_state): Move here from
10119         infrun.c.  Initialize fields, add constructor.
10120         <inf>: Remove field.
10121         <reset>: New method.
10122         * infrun.c (struct displaced_step_inferior_state): Move to
10123         infrun.h.
10124         (displaced_step_inferior_states): Remove.
10125         (get_displaced_stepping_state): Adust.
10126         (displaced_step_in_progress_any_inferior): Adjust.
10127         (displaced_step_in_progress_thread): Adjust.
10128         (displaced_step_in_progress): Adjust.
10129         (add_displaced_stepping_state): Remove.
10130         (get_displaced_step_closure_by_addr): Adjust.
10131         (remove_displaced_stepping_state): Remove.
10132         (infrun_inferior_exit): Call displaced_step_state.reset.
10133         (use_displaced_stepping): Don't check for NULL.
10134         (displaced_step_prepare_throw): Call
10135         get_displaced_stepping_state.
10136         (displaced_step_fixup): Don't check for NULL.
10137         (prepare_for_detach): Don't check for NULL.
10138
10139 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10140
10141         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10142          in case of call that did not complete.
10143
10144 2019-01-02  Andrey Utkin  <autkin@undo.io>
10145
10146         * symfile.c (find_separate_debug_file): Fix search of debug files for
10147         remote debuggee.
10148
10149 2019-01-02  Tom Tromey  <tom@tromey.com>
10150
10151         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10152         indentation.
10153         * python/py-frame.c (frapy_older): Remove cast.
10154         (frapy_newer): Likewise.
10155         * python/py-breakpoint.c (local_setattro): Remove cast.
10156         * python/py-arch.c (archpy_name): Remove local variable.
10157         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10158
10159 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10160
10161         * unittests/basic_string_view/element_access/char/empty.cc:
10162         Fix year range in copyright header.
10163
10164 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10165
10166         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10167         Delete.
10168         <operator==>: Update with for removed field.
10169         <hash>: Likewise.
10170         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10171         <isa_features>: ...this.
10172         <abi_features>: New field.
10173         (riscv_isa_flen): Update comment.
10174         (riscv_abi_xlen): New declaration.
10175         (riscv_abi_flen): New declaration.
10176         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10177         isa_features.
10178         (riscv_abi_xlen): New function.
10179         (riscv_isa_flen): Update to get answer from isa_features.
10180         (riscv_abi_flen): New function.
10181         (riscv_has_fp_abi): Update to get answer from abi_features.
10182         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10183         xlen and flen.
10184         (riscv_call_info) <xlen, flen>: Update comment.
10185         (riscv_call_arg_struct): Remove invalid assertions
10186         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10187         is removed.
10188         (riscv_gdbarch_init): Gather isa features and abi features
10189         separately, ensure both match on the gdbarch when reusing an old
10190         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10191         a target with 64-bit float hardware.
10192
10193 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10194
10195         * source.c (search_command_helper): Stop reverse search
10196         when line 1 has been searched.
10197
10198 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10199
10200         * record-full.c (record_full_base_target::close): Rewrite
10201         record_full_core_buf_list free logic.
10202
10203 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10204
10205         * break-catch-syscall.c (print_one_catch_syscall): xfree
10206         the last text.
10207
10208 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10209
10210         * top.c (print_gdb_version): Update Copyright year in version
10211         message.
10212
10213 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10214
10215         Update copyright year range in all GDB files.
10216
10217 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10218
10219         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10220
10221 For older changes see ChangeLog-2018.
10222 \f
10223 Local Variables:
10224 mode: change-log
10225 left-margin: 8
10226 fill-column: 74
10227 version-control: never
10228 coding: utf-8
10229 End:
10230