gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-layout.c (show_source_disasm_command)
   4         (show_source_or_disasm_and_command): Update.
   5         * tui/tui-io.c (update_cmdwin_start_line)
   6         (tui_redisplay_readline): Update.
   7         * tui/tui-data.h (struct tui_command_info): Remove.
   8         (struct tui_win_info) <detail>: Remove command_info member.
   9         (struct tui_data_window) <start_line>: New member, from
  10         tui_command_info.
  11         (TUI_CMD_WIN): Add casts.
  12
  13 2019-06-25  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-winsource.c (tui_update_source_window)
  16         (tui_refill_source_window)
  17         (tui_source_window_base::do_scroll_horizontal)
  18         (tui_update_breakpoint_info, tui_set_exec_info_content)
  19         (tui_show_exec_info_content, tui_erase_exec_info_content)
  20         (tui_clear_exec_info_content): Update.
  21         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
  22         Update.
  23         * tui/tui-win.c (make_invisible_and_set_new_height)
  24         (make_visible_with_new_height): Update.
  25         * tui/tui-source.c (tui_set_source_content)
  26         (tui_show_symtab_source): Update.
  27         * tui/tui-layout.c (extract_display_start_addr)
  28         (show_source_disasm_command, show_data)
  29         (make_source_or_disasm_window)
  30         (show_source_or_disasm_and_command): Update.
  31         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
  32         (tui_disasm_window::do_scroll_vertical): Remove shadowing
  33         "gdbarch".
  34         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
  35         to tui_source_window_base.
  36         (struct tui_win_info) <detail>: Remove source_info member.
  37         (struct tui_source_window_base) <has_locator>: Inline.
  38         Move contents from tui_source_info; rename has_locator member to
  39         m_has_locator.
  40         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
  41         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
  42         header file.
  43         (tui_source_window_base::clear_detail, ~tui_source_window_base):
  44         Simplify.
  45         (tui_free_all_source_wins_content): Cast to
  46         tui_source_window_base.
  47
  48 2019-06-25  Tom Tromey  <tom@tromey.com>
  49
  50         * tui/tui-win.c (make_invisible_and_set_new_height)
  51         (make_visible_with_new_height): Call has_locator method.
  52         * tui/tui-layout.c (show_source_disasm_command, show_data)
  53         (show_source_or_disasm_and_command): Update for bool change.
  54         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
  55         (tui_win_info) <has_locator>: New method.
  56         (struct tui_source_window_base) <has_locator>: New method.
  57         (tui_win_has_locator): Don't declare.
  58         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
  59         from tui_win_has_locator.
  60         (tui_source_window_base): Use false, not FALSE.
  61
  62 2019-06-25  Tom Tromey  <tom@tromey.com>
  63
  64         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
  65         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
  66         clear_detail method directly.
  67         (tui_clear_win_detail): Remove.
  68
  69 2019-06-25  Tom Tromey  <tom@tromey.com>
  70
  71         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
  72         "this", not TUI_DISASM_WIN.
  73
  74 2019-06-25  Tom Tromey  <tom@tromey.com>
  75
  76         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
  77         declare.
  78         * tui/tui-winsource.c
  79         (tui_source_window_base::do_scroll_horizontal): Rename from
  80         tui_horizontal_source_scroll.
  81         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
  82         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
  83         from tui_vertical_data_scroll.
  84         * tui/tui-win.h (tui_scroll): Don't declare.
  85         * tui/tui-win.c (tui_win_info::forward_scroll)
  86         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
  87         (tui_win_info::right_scroll): Rename and update.
  88         (tui_scroll_forward_command, tui_scroll_backward_command)
  89         (tui_scroll_left_command, tui_scroll_right_command): Update.
  90         (tui_scroll): Remove.
  91         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
  92         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
  93         from tui_vertical_source_scroll.
  94         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
  95         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
  96         from tui_vertical_disassem_scroll.
  97         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
  98         do_scroll_horizontal>: New methods.
  99         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 100         Likewise.
 101         (struct tui_source_window_base): Add do_scroll_horizontal.
 102         (struct tui_source_window, struct tui_disasm_window): Add
 103         do_scroll_vertical.
 104         (struct tui_data_window, struct tui_cmd_window): Add
 105         do_scroll_horizontal and do_scroll_vertical.
 106         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 107
 108 2019-06-25  Tom Tromey  <tom@tromey.com>
 109
 110         * tui/tui-data.h (struct tui_source_window_base): New struct.
 111         (struct tui_source_window): Derive from tui_source_window_base.
 112         (struct tui_disasm_window): New struct.
 113         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 114         from tui_source_window::clear_detail.
 115         (tui_source_window_base): Rename from tui_source_window.
 116         (~tui_source_window_base): Rename from ~tui_source_window.
 117         (tui_alloc_win_info): Create a tui_disasm_window.
 118
 119 2019-06-25  Tom Tromey  <tom@tromey.com>
 120
 121         * tui/tui-data.h (struct tui_source_window)
 122         (struct tui_data_window): Declare destructors.
 123         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 124         destructors.
 125         (tui_win_info): Simplify.
 126
 127 2019-06-25  Tom Tromey  <tom@tromey.com>
 128
 129         * tui/tui-winsource.c (tui_display_main)
 130         (tui_update_source_windows_with_addr)
 131         (tui_update_all_breakpoint_info): Update.
 132         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 133         (new_height_ok, parse_scrolling_args): Update.
 134         * tui/tui-stack.c (tui_show_frame_info): Update.
 135         * tui/tui-data.h (struct tui_list): Remove.
 136         (tui_source_windows): Return a reference to a std::vector.
 137         * tui/tui-data.c (source_windows): Now a std::vector.
 138         (tui_source_windows): Change return type.
 139         (tui_clear_source_windows): Rewrite.
 140         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 141         (tui_free_all_source_wins_content): Rewrite.
 142
 143 2019-06-25  Tom Tromey  <tom@tromey.com>
 144
 145         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 146         (struct tui_data_window, struct tui_cmd_window): Declare
 147         clear_detail method.
 148         * tui/tui-data.c (tui_source_window::clear_detail)
 149         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 150         methods.
 151         (tui_clear_win_detail): Simplify.
 152
 153 2019-06-25  Tom Tromey  <tom@tromey.com>
 154
 155         * tui/tui-layout.c (make_source_window, make_disasm_window)
 156         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 157         Return the new window.
 158         (show_source_disasm_command, show_data)
 159         (show_source_or_disasm_and_command): Update.
 160
 161 2019-06-25  Tom Tromey  <tom@tromey.com>
 162
 163         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 164         parameter.  Return the new window.
 165         (show_source_disasm_command): Update and remove NULL check.
 166         (show_source_or_disasm_and_command): Update.
 167
 168 2019-06-25  Tom Tromey  <tom@tromey.com>
 169
 170         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 171
 172 2019-06-25  Tom Tromey  <tom@tromey.com>
 173
 174         * tui/tui-data.h (struct tui_win_info): Make constructor
 175         protected.  Make destructor virtual.  Add initializers.
 176         (tui_source_window, tui_data_window, tui_cmd_window): New
 177         classes.
 178         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 179         constructor.  Add "type" parameter.
 180         (tui_source_window, tui_data_window, tui_cmd_window): New
 181         constructors.
 182         (tui_alloc_win_info): Instantiate the appropriate subclass.
 183
 184 2019-06-25  Tom Tromey  <tom@tromey.com>
 185
 186         * tui/tui-win.c (tui_resize_all): Use delete.
 187         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 188         destructor.
 189         (tui_free_window): Don't declare.
 190         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 191         Update.
 192
 193 2019-06-25  Tom Tromey  <tom@tromey.com>
 194
 195         * tui/tui-data.h (struct tui_win_info): Add constructor.
 196         * tui/tui-data.c (tui_alloc_win_info): Use new.
 197         (tui_free_window): Use delete.
 198
 199 2019-06-22  Tom Tromey  <tom@tromey.com>
 200
 201         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 202         declare.
 203         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 204
 205 2019-06-22  Tom Tromey  <tom@tromey.com>
 206
 207         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 208         declare.
 209         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 210
 211 2019-06-22  Tom de Vries  <tdevries@suse.de>
 212
 213         * dwarf2read.c (create_addrmap_from_aranges)
 214         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 215         instead of '%zu'.
 216
 217 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 218
 219         * dwarf2read.h (dwarf2_section_info_def): Remove.
 220         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 221         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 222         std::vector<dwarf2_section_info>.
 223         (struct dwo_file) <~dwo_file>: Remove.
 224         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 225         types field.
 226         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 227         (dwarf2_read_debug_names): Likewise.
 228         (create_debug_types_hash_table): Change parameter type to
 229         array_view, adjust code accordingly.
 230         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 231         (partial_die_info::fixup): Likewise.
 232         (determine_prefix): Likewise.
 233         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 234
 235 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 236
 237         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 238         gdb_bfd_ref_ptr.
 239         <~dwo_file>: Remove call to gdb_bfd_unref.
 240         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 241         gdb_bfd_ref_ptr::get.
 242
 243 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 244
 245         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 246         type to htab_up.
 247         * dwarf2read.c (struct dwo_file): Initialize fields.
 248         <~dwo_file>: New.
 249         (free_dwo_file): Remove, move content to ~dwo_file.
 250         (struct dwo_file_deleter): Remove.
 251         (dwo_file_up>: Remove custom deleter.
 252         (free_dwo_files): Remove.
 253         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 254         dwo_files.
 255         (process_skeletonless_type_units): Call unique_ptr::get.
 256         (allocate_dwo_file_hash_table): Add deleter to created hash
 257         table.  Change return type to htab_up.
 258         (lookup_dwo_file_slot): Don't memset dwo_file, call
 259         unique_ptr::get.
 260         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 261         (create_dwo_unit_in_dwp_v2): Likewise.
 262         (open_and_init_dwo_file): Likewise.
 263         (free_dwo_file_from_slot): Remove.
 264
 265 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 266
 267         * dwarf2read.h (struct dwarf2_section_info) <readin,
 268         is_virtual>: Change type to bool.
 269         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 270         true instead of 1.
 271
 272 2019-06-19  Tom Tromey  <tom@tromey.com>
 273
 274         * tui/tui-data.h (tui_init_content_element): Don't declare.
 275
 276 2019-06-19  Tom Tromey  <tom@tromey.com>
 277
 278         * tui/tui-data.h (tui_init_win_info): Don't declare.
 279
 280 2019-06-19  Tom de Vries  <tdevries@suse.de>
 281
 282         * dwarf2read.h (abstract_to_concrete): Change type to
 283         std::unordered_map<sect_offset, std::vector<sect_offset>,
 284         gdb::hash_enum<sect_offset>>.
 285
 286 2019-06-19  Tom Tromey  <tromey@adacore.com>
 287
 288         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 289         EVAL_AVOID_SIDE_EFFECTS specially.
 290
 291 2019-06-19  Tom Tromey  <tromey@adacore.com>
 292
 293         * source-cache.c (highlighter): New global.
 294         (source_cache::get_source_lines): Create a highlighter on demand.
 295
 296 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 297
 298         * defs.h (deprecated_interactive_hook): Delete declaration.
 299         * interps.c (clear_interpreter_hooks): Remove use of
 300         deprecated_interactive_hook.
 301         * top.c (deprecated_interactive_hook): Delete definition.
 302         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 303
 304 2019-06-18  Tom de Vries  <tdevries@suse.de>
 305
 306         PR gdb/24515
 307         * dwarf2read.h (abstract_to_concrete): Change type from
 308         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 309         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 310         * dwarf2read.c (read_variable): Update.
 311         (dwarf2_fetch_die_loc_sect_off): Update.
 312
 313 2019-06-17  Tom de Vries  <tdevries@suse.de>
 314
 315         PR gdb/24617
 316         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 317         accessing parent[parent_len - 1].
 318
 319 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 320
 321         PR gdb/24364
 322         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 323         call dtrace_process_dof with NULL dof.
 324
 325 2019-06-16  Tom de Vries  <tdevries@suse.de>
 326
 327         PR gdb/24445
 328         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 329
 330 2019-06-16  Tom Tromey  <tom@tromey.com>
 331
 332         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 333         (make_all_visible): Use address of member.
 334
 335 2019-06-16  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 338         (tui_free_window, free_content, free_content_elements): Remove
 339         unnecessary cast.
 340         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 341         cast.
 342         * tui/tui-regs.c (tui_show_register_group)
 343         (tui_display_registers_from, tui_display_reg_element_at_line):
 344         Remove unnecessary cast.
 345
 346 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 347
 348         * linux-nat.c (normal_mask): Delete.
 349         (_initialize_linux_nat): Don't initialise normal_mask.
 350
 351 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 352
 353         PR gdb/24445
 354         * dwarf-index-write.h (write_psymtabs_to_index): Add
 355         dwz_basename parameter.
 356         * dwarf-index-write.c (write_gdbindex): Move file writing to
 357         write_gdbindex_1.  Change return type void.
 358         (assert_file_size): Move up, remove filename parameter.
 359         (write_gdbindex_1): New function.
 360         (write_debug_names): Change return type to void, call
 361         assert_file_size.
 362         (struct index_wip_file): New struct.
 363         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 364         file logic to index_wip_file.  Write index for dwz file if
 365         needed.
 366         (save_gdb_index_command): Pass basename of dwz file, if present.
 367         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 368         build-id of dwz file, if present.
 369         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 370         (dwarf2_get_dwz_file): Likewise.
 371         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 372         (dwarf2_get_dwz_file): Likewise.
 373
 374 2019-06-16  Tom Tromey  <tom@tromey.com>
 375
 376         * coffread.c (process_coff_symbol): Use xstrdup.
 377         * value.c (create_internalvar): Use xstrdup.
 378
 379 2019-06-16  Tom Tromey  <tom@tromey.com>
 380
 381         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 382         * breakpoint.c (stopin_command, stopat_command)
 383         (until_break_command, decode_location_default): Remove unnecessary
 384         cast.
 385         * utils.c (subset_compare): Remove unnecessary cast.
 386         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 387         cast.
 388         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 389         cast.
 390         * infcmd.c (path_command): Remove unnecessary cast.
 391         * coffread.c (decode_type): Remove unnecessary cast.
 392         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 393         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 394         * tui/tui-stack.c (tui_show_locator_content)
 395         (tui_show_frame_info): Remove unnecessary cast.
 396         * tui/tui-win.c (tui_scroll_forward_command)
 397         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 398         (parse_scrolling_args): Remove unnecessary cast.
 399         * tui/tui-data.c (init_win_info, tui_del_window)
 400         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 401         (free_content_elements): Remove unnecessary cast.
 402         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 403         unnecessary cast.
 404         * tui/tui-source.c (tui_set_source_content)
 405         (tui_vertical_source_scroll): Remove unnecessary cast.
 406         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 407         cast.
 408         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 409         * tui/tui-regs.c (tui_display_registers_from)
 410         (tui_display_register): Remove unnecessary cast.
 411         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 412         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 413         (make_visible): Remove unnecessary cast.
 414         * tui/tui-winsource.c (tui_erase_source_content)
 415         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 416         unnecessary cast.
 417         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 418         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 419         * stabsread.c (read_type, read_array_type, read_range_type):
 420         Remove unnecessary cast.
 421         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 422         (parse_symbol, parse_type, upgrade_type, parse_external)
 423         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 424         unnecessary cast.
 425         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 426
 427 2019-06-16  Tom Tromey  <tom@tromey.com>
 428
 429         * tui/tui-data.c (tui_alloc_generic_win_info)
 430         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 431         checks.
 432
 433 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 434             Andrew Burgess  <andrew.burgess@embecosm.com>
 435
 436         * f-typeprint.c (f_print_type): Don't return early for not
 437         associated or not allocated types.
 438         (f_type_print_varspec_suffix): Add print_rank parameter and print
 439         ranks of array types in case they dangling.
 440         (f_type_print_base): Add print_rank parameter.
 441
 442 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 443
 444         * NEWS: Mention new MI commands.
 445         * break-catch-throw.c (enum exception_event_kind): Move to
 446         breakpoint.h.
 447         (print_mention_exception_catchpoint): Output text as a single
 448         message.
 449         (catch_exception_command_1): Rename to...
 450         (catch_exception_event): ...this, make non-static, update header
 451         command, and change some parameter types.
 452         (catch_catch_command): Update for changes to
 453         catch_exception_command_1.
 454         (catch_throw_command): Likewise.
 455         (catch_rethrow_command): Likewise.
 456         * breakpoint.c (enum exception_event_kind): Delete.
 457         * breakpoint.h (enum exception_event_kind): Moved here from
 458         break-catch-throw.c.
 459         (catch_exception_event): Declare.
 460         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 461         (mi_cmd_catch_throw): New function.
 462         (mi_cmd_catch_rethrow): New function.
 463         (mi_cmd_catch_catch): New function.
 464         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 465         'catch-catch' entries.
 466         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 467         (mi_cmd_catch_rethrow): Declare.
 468         (mi_cmd_catch_catch): Declare.
 469
 470 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 471
 472         * annotate.c (annotate_source_line): Change return type to void,
 473         update implementation to match.
 474         * annotate.h (annotate_source_line): Change return type to void,
 475         update header comment.
 476         * stack.c (print_frame_info): Don't change what frame information
 477         is printed based on whether annotations are on or not.
 478
 479 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 480
 481         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 482         (annotate_source): Make static.
 483         (annotate_source_line): Moved from source.c and renamed from
 484         identify_source_line.  Update the return type.
 485         * annotate.h (annotate_source): Delete declaration.
 486         (annotate_source_line): Declaration moved from source.h, and
 487         renamed from identify_source_line.  Return type updated.
 488         * source.c (identify_source_line): Moved to annotate.c and renamed
 489         to annotate_source_line.
 490         (info_line_command): Remove check of annotation_level.
 491         * source.h (identify_source_line): Move declaration to annotate.h
 492         and rename to annotate_source_line.
 493         * stack.c: Add 'annotate.h' include.
 494         (print_frame_info): Remove check of annotation_level before
 495         calling annotate_source_line.
 496
 497 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 498
 499         * source-cache.c (source_cache::get_plain_source_lines): Use
 500         open_source_file_with_line_charpos instead of just
 501         open_source_file, remove call to find_source_lines.
 502         (source_cache::get_source_lines): Likewise.
 503         * source.c (find_source_lines): Make static.
 504         (get_filename_and_charpos): Renamed into...
 505         (open_source_file_with_line_charpos): ..this along with changes to
 506         return a scoped_fd, and some other minor clean ups.
 507         (identify_source_line): Use open_source_file_with_line_charpos.
 508         (search_command_helper): Use open_source_file_with_line_charpos
 509         instead of just open_source_file, remove call to
 510         find_source_lines.
 511         * source.h (open_source_file_with_line_charpos): Declare new
 512         function.
 513         (find_source_lines): Delete declaration.
 514
 515 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 516
 517         * source.c (get_filename_and_charpos): Remove fullname
 518         parameter.
 519         (identify_source_line): Update call to get_filename_and_charpos.
 520
 521 2019-06-14  Tom Tromey  <tromey@adacore.com>
 522
 523         PR gdb/24502:
 524         * ui-style.h (skip_ansi_escape): Update comment.
 525         * ui-file.h (class no_terminal_escape_file): New class.
 526         * ui-file.c (no_terminal_escape_file::write)
 527         (no_terminal_escape_file::puts): New methods.
 528         * cli/cli-logging.c (handle_redirections): Use
 529         no_terminal_escape_file.
 530
 531 2019-06-14  Tom Tromey  <tromey@adacore.com>
 532
 533         * NEWS: Move convenience variable news above Python news.
 534
 535 2019-06-14  Tom Tromey  <tom@tromey.com>
 536
 537         * gnulib: Move directory to top-level.
 538         * configure.ac: Don't configure gnulib.
 539         * configure: Rebuild.
 540         * common/common-defs.h: Use new path to gnulib.
 541         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 542         (GNULIB_H): Remove.
 543         (INCGNU): Look in new gnulib location.
 544         (HFILES_NO_SRCDIR): Remove gnulib files.
 545         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 546         (generated_files): Remove GNULIB_H.
 547         ($(LIBGNU), all-lib): Remove targets.
 548         (distclean): Don't mention GNULIB_BUILDDIR.
 549         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 550
 551 2019-06-14  Tom Tromey  <tromey@adacore.com>
 552
 553         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 554         Warn if symbol file does not provide any symbols.
 555
 556 2019-06-14  Tom Tromey  <tromey@adacore.com>
 557
 558         * source.c (find_and_open_source): Respect basenames_may_differ.
 559
 560 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 561
 562         * annotate.c (annotate_breakpoints_invalid): Make use of
 563         scoped_restore_terminal_state.
 564         (annotate_frames_invalid): Likewise.
 565
 566 2019-06-14  Tom Tromey  <tromey@adacore.com>
 567
 568         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 569         allow assignment to an internalvar.
 570
 571 2019-06-14  Tom Tromey  <tromey@adacore.com>
 572
 573         * ada-lex.l: Allow "_" in attribute names.
 574
 575 2019-06-14  Tom Tromey  <tromey@adacore.com>
 576
 577         PR gdb/24653:
 578         * regcache.c (registers_changed): Don't call alloca.
 579         * top.c (execute_command): Don't call alloca.
 580
 581 2019-06-13  Pedro Alves  <palves@redhat.com>
 582
 583         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 584         'expression'.  When parsing an expression, error out if there's
 585         junk after "unlimited".
 586         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 587         (do_set_command): Adjust calls to is_unlimited_literal.
 588
 589 2019-06-13  Pedro Alves  <palves@redhat.com>
 590
 591         * compile/compile.c (make_compile_options_def_group): Add braces
 592         around array_view initializer.
 593         * thread.c (make_thread_apply_all_options_def_group)
 594         (make_thread_apply_all_options_def_group): Likewise.
 595
 596 2019-06-13  Pedro Alves  <palves@redhat.com>
 597
 598         * NEWS (New commands): Mention "maint test-options
 599         require-delimiter", "maint test-options unknown-is-error", "maint
 600         test-options unknown-is-operand" and "maint show
 601         test-options-completion-result".
 602         (New command options, command completion): New section.
 603         (Completion improvements): New section.
 604         Mention that you can abbreviate "unlimited".
 605
 606 2019-06-13  Pedro Alves  <palves@redhat.com>
 607
 608         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 609         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 610         * unittests/cli-utils-selftests.c (test_parse_flags)
 611         (test_parse_flags_qcs): Delete.
 612         (test_cli_utils): Don't call deleted functions.
 613
 614 2019-06-13  Pedro Alves  <palves@redhat.com>
 615
 616         * thread.c: Include "cli/cli-option.h".
 617         (tp_array_compar_ascending): Global.
 618         (tp_array_compar): Delete function.
 619         (tp_array_compar_ascending, tp_array_compar_descending): New
 620         functions.
 621         (ascending_option_def, qcs_flag_option_def)
 622         (thr_qcs_flags_option_defs)
 623         (make_thread_apply_all_options_def_group)
 624         (make_thread_apply_options_def_group): New.
 625         (thread_apply_all_command): Use gdb::option::process_options.
 626         (thread_apply_command_completer)
 627         (thread_apply_all_command_completer): New.
 628         (thread_apply_command): Use gdb::option::process_options.
 629         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 630         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 631         to generate help text of "thread apply".  Adjust "taas"'s help.
 632         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 633         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 634
 635 2019-06-13  Pedro Alves  <palves@redhat.com>
 636
 637         * thread.c (thread_apply_command): Check for invalid TID with
 638         isdigit instead of !isalpha.
 639
 640 2019-06-13  Pedro Alves  <palves@redhat.com>
 641
 642         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 643         (validate_flags_qcs): New.
 644         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 645         (validate_flags_qcs): Declare.
 646         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 647         (make_frame_apply_options_def_group): New.
 648         (frame_apply_command_count): Process options with
 649         gdb::option::process_options.
 650         (frame_apply_completer): New.
 651         (frame_apply_level_completer, frame_apply_all_completer)
 652         (frame_apply_completer): New.
 653         (_initialize_stack): Update help of "frame apply", "frame apply
 654         level", "frame apply all" and "faas" to mention supported options
 655         and install command completers.
 656         * stack.h (frame_apply_all_completer): Declare.
 657         * thread.c: Include "stack.h".
 658         (tfaas_command): Add "--".
 659         (_initialize_thread): Update help "tfaas" to mention supported
 660         options and install command completer.
 661
 662 2019-06-13  Pedro Alves  <palves@redhat.com>
 663
 664         * completer.c (complete_nested_command_line): New.
 665         (gdb_completion_word_break_characters_throw): Add assertion.
 666         * completer.h (complete_nested_command_line): Declare.
 667
 668 2019-06-13  Pedro Alves  <palves@redhat.com>
 669
 670         * stack.c (parse_backtrace_qualifiers): New.
 671         (backtrace_command): Use it.
 672         (backtrace_command_completer): Complete on qualifiers.
 673
 674 2019-06-13  Pedro Alves  <palves@redhat.com>
 675
 676         * frame.c: Include "cli/cli-option.h.
 677         (user_set_backtrace_options): New.
 678         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 679         Delete.
 680         (get_prev_frame): Adjust.
 681         (boolean_option_def, uinteger_option_def)
 682         (set_backtrace_option_defs): New.
 683         (_initialize_frame): Adjust and use
 684         gdb::option::add_setshow_cmds_for_options to install "set
 685         backtrace past-main" and "set backtrace past-entry".
 686         * frame.h: Include "cli/cli-option.h".
 687         (struct frame_print_options): Forward declare.
 688         (print_frame_arguments_all, print_frame_arguments_scalars)
 689         (print_frame_arguments_none): Declare.
 690         (print_entry_values): Delete declaration.
 691         (struct frame_print_options, user_frame_print_options): New.
 692         (struct set_backtrace_options): New.
 693         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 694         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 695         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 696         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 697         (list_args_or_locals): Add frame_print_options parameter.
 698         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 699         * python/py-framefilter.c (enumerate_args): Pass down
 700         USER_FRAME_PRINT_OPTIONS.
 701         * stack.c: Include "cli/cli-option.h".
 702         (print_frame_arguments_all, print_frame_arguments_scalars)
 703         (print_frame_arguments_none): Declare.
 704         (print_raw_frame_arguments, print_entry_values): Delete.
 705         (user_frame_print_options): New.
 706         (boolean_option_def, enum_option_def, frame_print_option_defs):
 707         New.
 708         (struct backtrace_cmd_options): New.
 709         (bt_flag_option_def): New.
 710         (backtrace_command_option_defs): New.
 711         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 712         (print_frame_arg, read_frame_arg, print_frame_args)
 713         (print_frame_info, print_frame): Add frame_print_options parameter
 714         and use it.
 715         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 716         (backtrace_command_1): Add frame_print_options and
 717         backtrace_cmd_options parameters and use them.
 718         (make_backtrace_options_def_group): New.
 719         (backtrace_command): Process command options with
 720         gdb::option::process_options.
 721         (backtrace_command_completer): New.
 722         (_initialize_stack): Extend "backtrace"'s help to mention
 723         supported options.  Install completer for "backtrace".
 724         Install some settings commands with add_setshow_cmds_for_options.
 725
 726 2019-06-13  Pedro Alves  <palves@redhat.com>
 727
 728         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 729         and that "set/show print raw frame-arguments" are now deprecated.
 730
 731         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 732         command.
 733         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 734         * stack.c (_initialize_stack): Install "set/show print
 735         raw-frame-arguments", and deprecate "set/show print raw
 736         frame-arguments".
 737         * valprint.c (_initialize_valprint): Deprecate "set/show print
 738         raw".
 739
 740 2019-06-13  Pedro Alves  <palves@redhat.com>
 741
 742         * compile/compile.c (struct compile_options): New.
 743         (compile_flag_option_def, compile_command_option_defs)
 744         (make_compile_options_def_group): New.
 745         (compile_file_command): Handle options with
 746         gdb::option::process_options.
 747         (compile_file_command_completer): New function.
 748         (compile_code_command): Handle options with
 749         gdb::option::process_options.
 750         (compile_code_command_completer): New function.
 751         (_initialize_compiler): Install completers for "compile code" and
 752         "compile file".  Mention available options in "compile code" and
 753         "compile code"'s help.
 754         * completer.c (advance_to_completion_word): New, factored out from
 755         ...
 756         (advance_to_expression_complete_word_point): ... this.
 757         (advance_to_filename_complete_word_point): New.
 758         * completer.h (advance_to_filename_complete_word_point): New
 759         declaration.
 760
 761 2019-06-13  Pedro Alves  <palves@redhat.com>
 762
 763         * compile/compile.c: Include "cli/cli-option.h".
 764         (compile_print_value): Scope data pointer is now a
 765         value_print_options pointer; adjust.
 766         (compile_print_command): Process options.  Scope data pointer is
 767         now a value_print_options pointer; adjust.
 768         (_initialize_compile): Update "compile print"'s help to include
 769         supported options.  Install a completer for "compile print".
 770         * cp-valprint.c (show_vtblprint, show_objectprint)
 771         (show_static_field_print): Delete.
 772         (_initialize_cp_valprint): Don't install "set print
 773         static-members", "set print vtbl", "set print object" here.
 774         * printcmd.c: Include "cli/cli-option.h" and
 775         "common/gdb_optional.h".
 776         (print_command_parse_format): Rework to fill in a
 777         value_print_options instead of a format_data.
 778         (print_value): Change parameter type from format_data pointer to
 779         value_print_options reference.  Adjust.
 780         (print_command_1): Process options.  Adjust to pass down a
 781         value_print_options.
 782         (print_command_completer): New.
 783         (_initialize_printcmd): Install print_command_completer as
 784         handle_brkchars completer for the "print" command.  Update
 785         "print"'s help to include supported options.
 786         * valprint.c: Include "cli/cli-option.h".
 787         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 788         here from cp-valprint.c.
 789         (boolean_option_def, uinteger_option_def)
 790         (value_print_option_defs, make_value_print_options_def_group):
 791         New.  Use gdb::option::add_setshow_cmds_for_options to install
 792         "set print elements", "set print null-stop", "set print repeats",
 793         "set print pretty", "set print union", "set print array", "set
 794         print address", "set print symbol", "set print array-indexes".
 795         * valprint.h: Include <string> and "cli/cli-option.h".
 796         (make_value_print_options_def_group): Declare.
 797         (print_value): Change parameter type from format_data pointer to
 798         value_print_options reference.
 799         (print_command_completer): Declare.
 800
 801 2019-06-13  Pedro Alves  <palves@redhat.com>
 802
 803         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 804         (COMMON_SFILES): Add maint-test-settings.c.
 805         * cli/cli-decode.c (boolean_enums): New global, factored out from
 806         ...
 807         (add_setshow_boolean_cmd): ... here.
 808         * cli/cli-decode.h (boolean_enums): Declare.
 809         * cli/cli-option.c: New file.
 810         * cli/cli-option.h: New file.
 811         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 812         factored out from ...
 813         (parse_cli_boolean_value(const char *)): ... this.
 814         (is_unlimited_literal): Change parameter type to pointer to
 815         pointer.  Adjust and advance ARG pointer.
 816         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 817         (parse_cli_var_enum): New, factored out from ...
 818         (do_set_command): ... this.  Adjust.
 819         * cli/cli-setshow.h (parse_cli_boolean_value)
 820         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 821         (parse_cli_var_enum): Declare.
 822         * cli/cli-utils.c: Include "cli/cli-option.h".
 823         (get_ulongest): New.
 824         * cli/cli-utils.h (get_ulongest): Declare.
 825         (check_for_argument): New overloads.
 826         * maint-test-options.c: New file.
 827
 828 2019-06-13  Pedro Alves  <palves@redhat.com>
 829
 830         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 831         parse a range if "-" is at the end of the string.
 832
 833 2019-06-13  Pedro Alves  <palves@redhat.com>
 834
 835         * cli/cli-setshow.c (parse_auto_binary_operation)
 836         (parse_cli_boolean_value): Don't allow "o".
 837
 838 2019-06-13  Pedro Alves  <palves@redhat.com>
 839
 840         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 841         * NEWS: Mention maint test-settings KIND.
 842         * maint-test-settings.c: New file.
 843
 844 2019-06-13  Pedro Alves  <palves@redhat.com>
 845
 846         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 847         completer.
 848         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 849         "set" completers.
 850
 851 2019-06-13  Pedro Alves  <palves@redhat.com>
 852
 853         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 854         after item.
 855
 856 2019-06-13  Pedro Alves  <palves@redhat.com>
 857
 858         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 859
 860 2019-06-13  Pedro Alves <palves@redhat.com>
 861
 862         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 863         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 864         call.
 865         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 866         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 867         calls.
 868         (check_for_argument): Skip spaces after argument.
 869
 870 2019-06-13  Pedro Alves  <palves@redhat.com>
 871
 872         * thread.c (thread_apply_command): Adjust TID parsing.
 873         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 874         detected before end of string.
 875         (tid_is_in_list): Error out if LIST is invalid.
 876
 877 2019-06-13  Pedro Alves  <palves@redhat.com>
 878
 879         * completer.c (complete_line_internal_1): Rewind completion word
 880         point.
 881         (completion_tracker::advance_custom_word_point_by): Change
 882         parameter type to int.
 883         * completer.h (completion_tracker::advance_custom_word_point_by):
 884         Likewise.
 885
 886 2019-06-13  Pedro Alves  <palves@redhat.com>
 887
 888         * completer.c (advance_to_completion_word): Handle delimiters.
 889
 890 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 891
 892         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 893
 894 2019-06-11  Tom Tromey  <tom@tromey.com>
 895
 896         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 897         (xmalloc_failed): Move to alloc.c.
 898         * alloc.c: New file.
 899         * Makefile.in (COMMON_SFILES): Add alloc.c.
 900
 901 2019-06-11  Tom Tromey  <tom@tromey.com>
 902
 903         * nat/linux-waitpid.c: Don't include server.h.
 904         (linux_debug): Remove.
 905         (my_waitpid): Update.
 906
 907 2019-06-11  Tom Tromey  <tromey@adacore.com>
 908
 909         * infcall.c (_initialize_infcall): Remove trailing newline from
 910         help.
 911         * user-regs.c (_initialize_user_regs): Remove trailing newline
 912         from help.
 913         * typeprint.c (_initialize_typeprint): Remove trailing newline
 914         from help.
 915         * reverse.c (_initialize_reverse): Remove trailing newlines from
 916         help.
 917         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 918         from help.
 919         * language.c (add_set_language_command): Remove trailing newline
 920         from help.
 921         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 922         help.
 923         * disasm.c (_initialize_disasm): Remove trailing newline from
 924         help.
 925         * top.c (init_main): Remove trailing newline from help.
 926         * interps.c (_initialize_interpreter): Remove trailing newline
 927         from help.
 928         * btrace.c (_initialize_btrace): Remove trailing newlines from
 929         help.
 930         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 931         from help.
 932         * python/python.c (_initialize_python): Remove trailing newline
 933         from help.
 934         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 935         help.
 936         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 937         from help.  Reformat some text.
 938         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 939         from help.
 940         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 941         newline from help.
 942
 943 2019-06-11  Tom Tromey  <tromey@adacore.com>
 944
 945         * darwin-nat.c (darwin_decode_exception_message)
 946         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 947
 948 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 949
 950         * valops.c (value_slice): Check for not allocated or not
 951         associated values.
 952
 953 2019-06-10  Tom de Vries  <tdevries@suse.de>
 954
 955         PR gdb/24618
 956         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 957         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 958         invalid.
 959
 960 2019-06-10  Tom de Vries  <tdevries@suse.de>
 961
 962         PR gdb/24611
 963         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 964         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 965
 966 2019-06-10  Tom de Vries  <tdevries@suse.de>
 967
 968         PR symtab/24545
 969         * symtab.c (struct demangled_name_entry): Add language field.
 970         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 971         static minimal symbol".  Set and use language field.
 972
 973 2019-06-10  Tom Tromey  <tromey@adacore.com>
 974
 975         * ada-lang.c (_initialize_ada_language): Update help text.
 976
 977 2019-06-10  Tom Tromey  <tromey@adacore.com>
 978
 979         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 980         with a newline.
 981         * guile/guile.c (handle_boot_error): Don't end warning with a
 982         newline.
 983         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 984         warning with a newline.
 985         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 986         newline.
 987         (s12z_frame_cache): Likewise.
 988         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 989         a newline.
 990         * solib-svr4.c (disable_probes_interface): Don't end warning with
 991         a newline.
 992         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 993         newline.
 994         * python/python.c (do_finish_initialization): Don't end warning
 995         with a newline.
 996
 997 2019-06-10  Tom Tromey  <tom@tromey.com>
 998
 999         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1000         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1001         gdbpy_enter.
1002
1003 2019-06-10  Tom Tromey  <tromey@adacore.com>
1004
1005         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1006         data.
1007         (elf_new_init): Don't call stabsread_new_init.
1008         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1009         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1010         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1011
1012 2019-06-10  Tom de Vries  <tdevries@suse.de>
1013
1014         PR symtab/16264
1015         PR symtab/24517
1016         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1017
1018 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1019
1020         * source.c (find_and_open_source): Also rewrite relative file
1021         names.
1022
1023 2019-04-26  Amos Bird  <amosbird@gmail.com>
1024
1025         * annotate.c (annotate_thread_exited): Add "thread-exited"
1026         annotation.
1027
1028 2019-06-06  Tom Tromey  <tromey@adacore.com>
1029
1030         * maint.h (class scoped_command_stats): Use
1031         DISABLE_COPY_AND_ASSIGN.
1032         <print_time>: New method.
1033         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1034         print_time.
1035         (scoped_command_stats::print_time): New method.
1036
1037 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1038
1039         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1040         instructions of lengths 6 or 8 bytes.
1041
1042 2019-06-04  Pedro Alves  <palves@redhat.com>
1043
1044         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1045
1046         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1047         * breakpoint.c (condition_completer): Likewise.
1048         * cli/cli-dump.c (scan_expression): Likewise.
1049         * common/filestuff.c (mkdir_recursive): Likewise.
1050         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1051         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1052         (gdb_abspath): Likewise.
1053         * compile/compile-cplus-types.c
1054         (compile_cplus_instance::decl_name): Likewise.
1055         * completer.c (complete_explicit_location):
1056         (signal_completer, reg_or_group_completer_1): Likewise.
1057         * cp-support.c (cp_remove_params_if_any): Likewise.
1058         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1059         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1060         * infcmd.c (strip_bg_char): Likewise.
1061         * linespec.c (copy_token_string): Likewise.
1062         * mi/mi-main.c (output_cores): Likewise.
1063         * psymtab.c (psymtab_search_name):
1064         * symfile.c (test_set_ext_lang_command): Likewise.
1065         * target.c (target_fileio_read_stralloc): Likewise.
1066         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1067         * value.c (complete_internalvar): Likewise.
1068
1069 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1070
1071         Add objfile property to gdb.Type.
1072         * NEWS: Mention Python API addition.
1073         * python/py-type.c (typy_get_objfile): New method.
1074
1075 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1076
1077         * NEWS: Mention the new set|show style [title|highlight].
1078         Mention changes to "show style", "help" and "apropos".
1079
1080 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1081
1082         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1083         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1084         instead of print_help_for_command.
1085         (print_doc_of_command): New function.
1086         (help_list): Add 'apropos -v word' suggestion.
1087         (print_help_for_command): Style the command name using title style.
1088         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1089         (_initialize_cli_cmds): Describe -v in apropos_command help.
1090
1091 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1092
1093         * cli/cli-style.h (cli_style_option): Add name in constructor,
1094         add m_name class member, add constructor with intensity,
1095         add name class function.
1096         (cli_style_option::add_setshow_commands): Remove name argument.
1097         (highlight_style, title_style): New styles.
1098         * cli/cli-style.c (do_show): New function that shows a style
1099         characteristic styling the style name with itself.
1100         (set_style_name): New function.
1101         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1102         Update all callers according to the changes in cli/cli-style.h.
1103         * utils.h (fputs_highlighted): New function.
1104         * utils.c (fputs_highlighted): Likewise.
1105
1106 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1107
1108         * NEWS: Mention new pipe command and new convenience variables.
1109
1110 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1111
1112         * cli/cli-cmds.c (pipe_command): New function.
1113         (_initialize_cli_cmds): Call add_com for pipe_command.
1114         Define | as an alias for pipe.
1115         (exit_status_set_internal_vars): New function.
1116         (shell_escape): Call exit_status_set_internal_vars.
1117         cli/cli-decode.c (find_command_name_length): Recognize | as
1118         a single character command.
1119
1120 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1121
1122         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1123         top.c (execute_command_to_ui_file): New function, mostly a copy
1124         of execute_command_to_string.
1125         (execute_command_to_string): Implement by calling
1126         execute_command_to_ui_file.
1127
1128 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1129
1130         * top.h (saved_command_line): Remove declaration.
1131         * top.c (previous_saved_command_line, previous_repeat_arguments):
1132         New variables.
1133         (saved_command_line): Make static, define together with other
1134         'repeat variables'.
1135         (dont_repeat): Clear repeat_arguments.
1136         (repeat_previous, get_saved_command_line, save_command_line):
1137         New functions.
1138         (gdb_init): Initialize saved_command_line
1139         and previous_saved_command_line.
1140         * main.c (captured_main_1): Remove saved_command_line initialization.
1141         * event-top.c (handle_line_of_input): Update to use
1142         the new 'repeat' related functions instead of direct access to
1143         saved_command_line.
1144         * command.h (repeat_previous, get_saved_command_line,
1145         save_command_line): New declarations.
1146         (dont_repeat): Add comment.
1147
1148 2019-05-30  Tom Tromey  <tromey@adacore.com>
1149
1150         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1151         Fix comment.
1152         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1153
1154 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1155
1156         PR cli/24587
1157         * completer.c (complete): Initialize variable word.
1158
1159 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1160
1161         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1162         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1163         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1164         'body' is NULL to the outter 'if', protecting the '!is_define'
1165         situation as well.
1166
1167 2019-05-29  Tom Tromey  <tromey@adacore.com>
1168
1169         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1170         (dwarf_unknown): New function.
1171         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1172         (dwarf_type_encoding_name): Use dwarf_unknown.
1173
1174 2019-05-29  Tom Tromey  <tromey@adacore.com>
1175
1176         PR c++/20020:
1177         * cp-valprint.c (cp_print_value_fields): Call
1178         cp_print_static_field inside "try".
1179
1180 2019-05-29  Tom Tromey  <tromey@adacore.com>
1181
1182         * inflow.c (struct terminal_info): Add default operator=.
1183         * configure: Rebuild.
1184         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1185         -Wdeprecated-copy-dtor, -Wredundant-move.
1186
1187 2019-05-29  Tom Tromey  <tromey@adacore.com>
1188
1189         * NEWS: Add entry.
1190         * infcmd.c (print_return_value_1): Handle finish_print
1191         option.
1192         (show_print_finish): New function.
1193         (_initialize_infcmd): Add "set/show print finish" commands.
1194         * valprint.c (user_print_options): Initialize new member.
1195         * valprint.h (struct value_print_options) <finish_print>: New
1196         member.
1197
1198 2019-05-28  Tom Tromey  <tromey@adacore.com>
1199
1200         * ada-lang.c (ada_remove_Xbn_suffix)
1201         (find_old_style_renaming_symbol)
1202         (parse_old_style_renaming): Remove.
1203         (ada_find_renaming_symbol): Don't call
1204         find_old_style_renaming_symbol.
1205         (ada_is_renaming_symbol): Rename from
1206         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1207         bool.  Now static.
1208         (ada_read_var_value): Update and simplify.
1209         * ada-exp.y (write_var_or_type): Remove old code.
1210
1211 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1212
1213         * event-top.c: Remove include comment.
1214         * inflow.c (class scoped_ignore_sigttou): Move from here...
1215         * inflow.h (class scoped_ignore_sigttou): ...to here.
1216         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1217         * top.c:  Remove include comment.
1218
1219 2019-05-27  Tom Tromey  <tom@tromey.com>
1220
1221         * NEWS: Fix typo.
1222
1223 2019-05-22  Tom Tromey  <tromey@adacore.com>
1224
1225         * target.c (target_follow_exec): Constify parameter.
1226         * target-delegates.c: Rebuild.
1227         * remote.c (remote_target::follow_exec): Constify parameter.
1228         * infrun.c (follow_exec): Constify parameter.
1229         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1230         (target_follow_exec): Likewise.
1231
1232 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1233
1234         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1235         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1236
1237 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1238
1239         * NEWS: Add debugredirect and testsuite sections.
1240
1241 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1242
1243         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1244         target descriptions using exclusively floating point register name
1245         aliases.
1246
1247 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1248
1249         PR gdb/18644:
1250         * f-lang.c (build_fortran_types): Handle the case where
1251         gdbarch_floatformat_for_type returns a nullptr.
1252
1253 2019-05-21  Tom de Vries  <tdevries@suse.de>
1254
1255         PR cli/24587
1256         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1257
1258 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1259
1260         PR gdb/18644:
1261         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1262         16-byte floats.
1263         * i386-tdep.c (i386_floatformat_for_type): Use
1264         floatformats_ia64_quad for the 16-byte floating point component
1265         within a fortran 32-byte complex number.
1266
1267 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1268
1269         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1270         delete default constructor.
1271         (find_partial_die): Update to return const struct.
1272         (partial_die_parent_scope): Move variable declaration into scope
1273         of its use and change its type to auto.
1274         (guess_partial_die_structure_name): Likewise.
1275         (partial_die_info::fixup): Likewise.
1276
1277 2019-05-17  Tom Tromey  <tromey@adacore.com>
1278
1279         * source.c (find_and_open_source): Remove cast.
1280
1281 2019-05-17  Tom Tromey  <tromey@adacore.com>
1282
1283         * annotate.c (annotate_source): Make "filename" const.
1284         * annotate.h (annotate_source): Use const.
1285
1286 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1287
1288         * disasm.c (set_disassembler_options): Send errors to stderr.
1289
1290 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1291
1292         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1293         (cli_interp_base::set_logging): Check debug_redirect.
1294         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1295         * cli/cli-logging.c (debug_redirect): Add static variable.
1296         (pop_output_files): Add default param.
1297         (handle_redirections): Print debug setting.
1298         (show_logging_command): Likewise.
1299         (_initialize_cli_logging): Add debugredirect command.
1300         * interps.c (current_interp_set_logging): Add debug_redirect
1301         parameter.
1302         * interps.h (set_logging): Add debug_redirect parameter.
1303         (current_interp_set_logging): Likewise.
1304         * mi/mi-common.h: Likewise.
1305         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1306
1307 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1308             Tom Tromey  <tromey@adacore.com>
1309
1310         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1311         directly.
1312         * cli/cli-interp.h (make_logging_output): Remove declaration.
1313         * cli/cli-logging.c (make_logging_output): Remove function.
1314         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1315         directly.
1316         * ui-file.c (tee_file::tee_file): Remove bools.
1317         (tee_file::~tee_file): Remove deletes.
1318         * ui-file.h (tee_file): Remove bools.
1319
1320 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1321
1322         * mi/mi-cmds.h (mi_cmd_complete): New function.
1323         * mi/mi-main.c (mi_cmd_complete): Likewise.
1324         * mi/mi-cmds.c: Define new MI command -complete.
1325         * NEWS: Mention new -complete command.
1326
1327 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1328
1329         * completer.h (complete): New function.
1330         * completer.c (complete): Likewise.
1331         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1332         function defined in completer.h.
1333
1334 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1335
1336         * MAINTAINERS (Write After Approval): Add myself.
1337
1338 2019-05-17  Tom de Vries  <tdevries@suse.de>
1339
1340         PR gdb/24094
1341         * dwarf2read.c (struct cu_partial_die_info): New struct.
1342         (find_partial_die): Return cu_partial_die_info.
1343         (partial_die_parent_scope, guess_partial_die_structure_name)
1344         (partial_die_info::fixup): Handle new return type of find_partial_die.
1345
1346 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1347
1348         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1349         "std::string", simplifying the algorithm.
1350
1351 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1352
1353         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1354         (stap_static_probe_ops::get_probes): Likewise.
1355
1356 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1357
1358         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1359         '-')" and "else if".
1360         (stap_parse_single_operand): Join checks for
1361         "gdbarch_stap_parse_special_token_p" and
1362         "gdbarch_stap_parse_special_token" in the same "if" statement.
1363         Invert check when verifying for operation on register
1364         displacement.
1365
1366 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1367
1368         * stap-probe.c (stap_get_opcode): Update comment.
1369         (stap_get_expected_argument_type): Likewise.
1370         (handle_stap_probe): Likewise.
1371
1372 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1373
1374         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1375         return type to 'bool'.  Adjust comment.  Use 'bool' when
1376         appropriate.
1377         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1378         * stap-probe.c (stap_parse_argument_1): Likewise.
1379         (stap_is_operator): Likewise.
1380         (stap_is_generic_prefix): Likewise.
1381         (stap_is_register_prefix): Likewise.
1382         (stap_is_register_indirection_prefix): Likewise.
1383         (stap_is_integer_prefix): Likewise.
1384         (stap_generic_check_suffix): Likewise.
1385         (stap_check_integer_suffix): Likewise.
1386         (stap_check_register_suffix): Likewise.
1387         (stap_check_register_indirection_suffix): Likewise.
1388         (stap_parse_register_operand): Likewise.
1389         (stap_parse_single_operand): Likewise.
1390         (stap_parse_argument_1): Likewise.
1391         (stap_probe::get_argument_count): Likewise.
1392         (stap_is_operator): Likewise.
1393
1394 2019-05-16  Tom Tromey  <tromey@adacore.com>
1395
1396         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1397         keyword to foreach.
1398
1399 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1400
1401         * linux-thread-db.c (try_thread_db_load_1): Change return type
1402         to bool.
1403         (try_thread_db_load): Likewise.
1404         (try_thread_db_load_from_pdir_1): Likewise.
1405         (try_thread_db_load_from_pdir): Likewise.
1406         (try_thread_db_load_from_sdir): Likewise.
1407         (try_thread_db_load_from_dir): Likewise.
1408         (thread_db_load_search): Likewise.
1409         (has_libpthread): Likewise.
1410         (thread_db_load): Likewise.
1411
1412 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1413
1414         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1415         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1416         NULL, and complain/return if that's the case.
1417
1418 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1419
1420         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1421         (advance, posn, abstract_read_memory): New functions.
1422         [struct mem_read_abstraction]: New struct.
1423         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1424
1425 2019-05-14  Tom Tromey  <tromey@adacore.com>
1426
1427         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1428         value is not lval_memory.
1429
1430 2019-05-14  Tom Tromey  <tromey@adacore.com>
1431
1432         * solib.c (info_sharedlibrary_command): Style the file name.
1433
1434 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1435
1436         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1437         (aarch64_vnv_type): Likewise.
1438         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1439         * common/tdesc.c: Likewise.
1440         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1441         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1442         * features/aarch64-fpu.xml: Add ieee half view.
1443         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1444         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1445         * gdbtypes.h (struct builtin_type): Likewise.
1446         (struct objfile_type): Likewise.
1447
1448 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1449
1450         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1451         typo.
1452         * location.h (string_to_event_location): Likewise.
1453
1454 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1455
1456         GDB 8.3 released.
1457
1458 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1459
1460         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1461         New variable declaration.
1462         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1463         New variable.
1464         (print_one_breakpoint): Use ui_out::test_flags and new global
1465         variable to compute use_fixed_output.
1466         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1467         Remove.
1468         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1469         (mi_multi_location_breakpoint_output_fixed): Remove.
1470         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1471         new variable.
1472         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1473         fix_multi_location_breakpoint_output flag if version >= 3.
1474         * ui-out.h (enum ui_out_flag)
1475         <fix_multi_location_breakpoint_output>: New enumerator.
1476
1477 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1478
1479         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1480
1481 2019-05-10  Tom Tromey  <tromey@adacore.com>
1482
1483         * ada-lang.c (catch_ada_completer): New function.
1484         (_initialize_ada_language): Use it.
1485
1486 2019-05-10  Tom Tromey  <tromey@adacore.com>
1487
1488         * thread.c (print_thread_info): Make "requested_threads" const.
1489         * gdbthread.h (print_thread_info): Make "requested_threads"
1490         const.
1491         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1492         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1493
1494 2019-05-08  Tom Tromey  <tom@tromey.com>
1495
1496         * gdbtypes.c (objfile_type_data): Change type.
1497         (objfile_type, _initialize_gdbtypes): Update.
1498
1499 2019-05-08  Tom Tromey  <tom@tromey.com>
1500
1501         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1502         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1503         (_initialize_dwarf2_frame): Update.
1504
1505 2019-05-08  Tom Tromey  <tom@tromey.com>
1506
1507         * objc-lang.c (objc_objfile_data): Change type.
1508         (find_methods): Update.
1509         (_initialize_objc_lang): Remove.
1510
1511 2019-05-08  Tom Tromey  <tom@tromey.com>
1512
1513         * stabsread.c (rs6000_builtin_type_data): Change type.
1514         (rs6000_builtin_type, _initialize_stabsread): Update.
1515
1516 2019-05-08  Tom Tromey  <tom@tromey.com>
1517
1518         * mips-tdep.c (mips_pdr_data): Remove.
1519         (_initialize_mips_tdep): Update.
1520
1521 2019-05-08  Tom Tromey  <tom@tromey.com>
1522
1523         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1524         (hppa_init_objfile_priv_data, read_unwind_info)
1525         (find_unwind_entry, _initialize_hppa_tdep): Update.
1526
1527 2019-05-08  Tom Tromey  <tom@tromey.com>
1528
1529         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1530         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1531         on obstack.
1532         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1533
1534 2019-05-08  Tom Tromey  <tom@tromey.com>
1535
1536         * mdebugread.c (basic_type_data): Change type.
1537         (basic_type, _initialize_mdebugread): Update.
1538
1539 2019-05-08  Tom Tromey  <tom@tromey.com>
1540
1541         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1542
1543 2019-05-08  Tom Tromey  <tom@tromey.com>
1544
1545         * nto-tdep.c (nto_inferior_data_reg): Change type.
1546         (nto_inferior_data): Update.
1547         (nto_inferior_data_cleanup, nto_new_inferior_data)
1548         (_initialize_nto_tdep): Remove.
1549         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1550
1551 2019-05-08  Tom Tromey  <tom@tromey.com>
1552
1553         * ada-lang.c (struct ada_inferior_data): Add initializers.
1554         (ada_inferior_data): Change type.
1555         (ada_inferior_data_cleanup): Remove.
1556         (get_ada_inferior_data, ada_inferior_exit)
1557         (struct ada_pspace_data): Add initializers, destructor.
1558         (ada_pspace_data_handle): Change type.
1559         (get_ada_pspace_data): Update.
1560         (ada_pspace_data_cleanup): Remove.
1561
1562 2019-05-08  Tom Tromey  <tom@tromey.com>
1563
1564         * coffread.c (struct coff_symfile_info): Add initializers.
1565         (coff_objfile_data_key): Move lower.  Change type.
1566         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1567         Update.
1568         (coff_free_info): Remove.
1569
1570 2019-05-08  Tom Tromey  <tom@tromey.com>
1571
1572         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1573         (fbsd_pspace_data_handle): Move lower.  Change type.
1574         (get_fbsd_pspace_data): Update.
1575         (fbsd_pspace_data_cleanup): Remove.
1576         (_initialize_fbsd_tdep): Update.
1577
1578 2019-05-08  Tom Tromey  <tom@tromey.com>
1579
1580         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1581         (get_ada_tasks_pspace_data): Update.
1582         (ada_tasks_pspace_data_cleanup): Remove.
1583         (_initialize_tasks): Update.
1584         (ada_tasks_inferior_data_handle): Change type.
1585         (get_ada_tasks_inferior_data): Update.
1586         (ada_tasks_inferior_data_cleanup): Remove.
1587         (struct ada_tasks_pspace_data): Add initializers.
1588
1589 2019-05-08  Tom Tromey  <tom@tromey.com>
1590
1591         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1592         * symfile-debug.c (debug_sym_get_probes): Change type.
1593         * stap-probe.c (handle_stap_probe):
1594         (stap_static_probe_ops::get_probes): Change type.
1595         * probe.h (class static_probe_ops) <get_probes>: Change type.
1596         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1597         (parse_probes_in_pspace): Update.
1598         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1599         Update.
1600         (any_static_probe_ops::get_probes): Change type.
1601         * elfread.c (elfread_data): New typedef.
1602         (probe_key): Change type.
1603         (elf_get_probes): Likewise.  Update.
1604         (probe_key_free): Remove.
1605         (_initialize_elfread): Update.
1606         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1607         Change type.
1608         (dtrace_process_dof_probe, dtrace_process_dof)
1609         (dtrace_static_probe_ops::get_probe): Change type.
1610
1611 2019-05-08  Tom Tromey  <tom@tromey.com>
1612
1613         * xcoffread.c (struct xcoff_symfile_info): Rename from
1614         coff_symfile_info.  Add initializers.
1615         (xcoff_objfile_data_key): Move lower.  Change type.
1616         (XCOFF_DATA): Rewrite.
1617         (xcoff_free_info): Remove.
1618         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1619         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1620         (xcoff_initial_scan): Update.
1621
1622 2019-05-08  Tom Tromey  <tom@tromey.com>
1623
1624         * solib-svr4.c (struct svr4_info): Add initializers and
1625         destructor.
1626         <probes_table>: Now an htab_up.
1627         (solib_svr4_pspace_data): Change type.
1628         (free_probes_table): Simplify.
1629         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1630         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1631         (probes_table_remove_objfile_probes, register_solib_event_probe)
1632         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1633         (_initialize_svr4_solib): Update.
1634
1635 2019-05-08  Tom Tromey  <tom@tromey.com>
1636
1637         * remote.c (remote_pspace_data): Change type.
1638         (remote_pspace_data_cleanup): Remove.
1639         (get_remote_exec_file, set_pspace_remote_exec_file)
1640         (_initialize_remote): Update.
1641
1642 2019-05-08  Tom Tromey  <tom@tromey.com>
1643
1644         * breakpoint.c (breakpoint_objfile_key): Change type.
1645         (get_breakpoint_objfile_data): Update.
1646         (free_breakpoint_objfile_data): Remove.
1647         (_initialize_breakpoint): Update.
1648
1649 2019-05-08  Tom Tromey  <tom@tromey.com>
1650
1651         * linux-tdep.c (struct linux_info): Add initializers.
1652         (linux_inferior_data): Move.  Change type.
1653         (invalidate_linux_cache_inf): Update.
1654         (linux_inferior_data_cleanup): Remove.
1655         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1656
1657 2019-05-08  Tom Tromey  <tom@tromey.com>
1658
1659         * auxv.c (auxv_inferior_data): Move.  Change type.
1660         (auxv_inferior_data_cleanup): Remove.
1661         (invalidate_auxv_cache_inf): Rewrite.
1662         (get_auxv_inferior_data, _initialize_auxv): Update.
1663
1664 2019-05-08  Tom Tromey  <tom@tromey.com>
1665
1666         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1667         (symfile_debug_objfile_data_key): Change type.
1668         (symfile_debug_installed, debug_qf_has_symbols)
1669         (debug_qf_find_last_source_symtab)
1670         (debug_qf_forget_cached_source_info)
1671         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1672         (debug_qf_print_stats, debug_qf_dump)
1673         (debug_qf_expand_symtabs_for_function)
1674         (debug_qf_expand_all_symtabs)
1675         (debug_qf_expand_symtabs_with_fullname)
1676         (debug_qf_map_matching_symbols)
1677         (debug_qf_expand_symtabs_matching)
1678         (debug_qf_find_pc_sect_compunit_symtab)
1679         (debug_qf_map_symbol_filenames)
1680         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1681         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1682         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1683         (debug_sym_read_linetable, debug_sym_relocate): Update.
1684         (symfile_debug_free_objfile): Remove.
1685         (install_symfile_debug_logging, _initialize_symfile_debug):
1686         Update.
1687
1688 2019-05-08  Tom Tromey  <tom@tromey.com>
1689
1690         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1691         allocate_on_obstack.
1692         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1693         (get_dwarf2_per_objfile): Update.
1694         (set_dwarf2_per_objfile): Remove.
1695         (dwarf2_has_info, dwarf2_get_section_info): Update.
1696         (dwarf2_free_objfile): Remove.
1697         (_initialize_dwarf2_read): Update.
1698
1699 2019-05-08  Tom Tromey  <tom@tromey.com>
1700
1701         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1702         initializers.
1703         <unsupported_script_warning_printed,
1704         script_not_found_warning_printed>: Now bool.
1705         (auto_load_pspace_data): Change type.
1706         (~auto_load_pspace_info): Rename from
1707         auto_load_pspace_data_cleanup.
1708         (get_auto_load_pspace_data, init_loaded_scripts_info)
1709         (clear_section_scripts, maybe_print_unsupported_script_warning)
1710         (maybe_print_script_not_found_warning, _initialize_auto_load):
1711         Update.
1712
1713 2019-05-08  Tom Tromey  <tom@tromey.com>
1714
1715         * objfiles.c (objfile_pspace_info): Add destructor and
1716         initializers.
1717         (objfiles_pspace_data): Change type.
1718         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1719         (get_objfile_pspace_data): Update.
1720         (objfiles_bfd_data): Change type.
1721         (get_objfile_bfd_data): Update.
1722         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1723
1724 2019-05-08  Tom Tromey  <tom@tromey.com>
1725
1726         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1727         Change type.
1728         (get_catch_syscall_inferior_data): Update.
1729         (catch_syscall_inferior_data_cleanup): Remove.
1730         (_initialize_break_catch_syscall): Update.
1731
1732 2019-05-08  Tom Tromey  <tom@tromey.com>
1733
1734         * inflow.c (struct terminal_info): Add destructor and
1735         initializers.
1736         (inflow_inferior_data): Change type.
1737         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1738         (get_inflow_inferior_data, inflow_inferior_exit)
1739         (swap_terminal_info, _initialize_inflow): Update.
1740
1741 2019-05-08  Tom Tromey  <tom@tromey.com>
1742
1743         * target-dcache.c (target_dcache_cleanup): Remove.
1744         (target_dcache_aspace_key): Change type.
1745         (target_dcache_init_p, target_dcache_invalidate)
1746         (target_dcache_get, target_dcache_get_or_init)
1747         (_initialize_target_dcache): Update.
1748         * dcache.h (struct dcache_deleter): New.
1749
1750 2019-05-08  Tom Tromey  <tom@tromey.com>
1751
1752         * symtab.c (struct symbol_cache): Add destructor and
1753         initializers.
1754         (symbol_cache_key): Move.  Change type.
1755         (make_symbol_cache, free_symbol_cache): Remove.
1756         (get_symbol_cache): Update.
1757         (symbol_cache_cleanup): Remove.
1758         (ALL_PSPACES, symbol_cache_flush)
1759         (maintenance_print_symbol_cache)
1760         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1761         Update.
1762
1763 2019-05-08  Tom Tromey  <tom@tromey.com>
1764
1765         * symtab.c (struct main_info): Add destructor and initializers.
1766         (main_progspace_key): Move.  Change type.
1767         (get_main_info): Update.
1768         (main_info_cleanup): Remove.
1769         (_initialize_symtab): Update.
1770
1771 2019-05-08  Tom Tromey  <tom@tromey.com>
1772
1773         * registry.h (DECLARE_REGISTRY): Define the _key class.
1774
1775 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1776
1777         * NEWS: Merge two 'New commands' sections.
1778
1779 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1780
1781         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1782         parameter and use Ada language definition instead.
1783         (ada_val_print_ptr): Remove unused language parameter.
1784         (ada_val_print_num): Remove language parameter and use Ada language
1785         definition instead.
1786         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1787         parameter.
1788         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1789         parameter and use Ada language definition instead.
1790         (ada_val_print_1): Update all ada_val_print_xxx calls.
1791         Remove language parameter.
1792         (ada_val_print): Update ada_val_print_1 call.
1793
1794 2019-05-08  Tom Tromey  <tromey@adacore.com>
1795
1796         * remote.c (remote_hw_watchpoint_limit)
1797         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1798         Now static.
1799
1800 2019-05-08  Tom Tromey  <tromey@adacore.com>
1801
1802         * maint.c (_initialize_maint_cmds): Move initialization code to
1803         remote.c.
1804         (watchdog, show_watchdog): Move to remote.c.
1805         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1806         "watchdog" static.
1807         (_initialize_remote): Move initialization code from maint.c.
1808         * defs.h (watchdog): Don't declare.
1809
1810 2019-05-08  Tom Tromey  <tromey@adacore.com>
1811
1812         * tui/tui-interp.c: Include main.h.
1813         * interps.c: Include main.h.
1814         * main.h (interpreter_p): Declare.
1815         * defs.h (interpreter_p): Don't declare.
1816
1817 2019-05-08  Tom Tromey  <tromey@adacore.com>
1818
1819         * dwarf2loc.c: Include dwarf2read.h.
1820         * defs.h (read_unsigned_leb128): Don't declare.
1821         * dwarf2read.h (read_unsigned_leb128): Declare.
1822
1823 2019-05-08  Tom Tromey  <tromey@adacore.com>
1824
1825         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1826         method.
1827
1828 2019-05-08  Tom Tromey  <tromey@adacore.com>
1829
1830         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1831         when no wrap column is set.
1832
1833 2019-05-08  Tom Tromey  <tromey@adacore.com>
1834
1835         * c-lang.c (c_get_string): Handle non-C-style arrays.
1836
1837 2019-05-08  Tom Tromey  <tromey@adacore.com>
1838
1839         * typeprint.c (print_offset_data::update): Print the bit offset,
1840         not the number of bits remaining.
1841
1842 2019-05-08  Tom Tromey  <tromey@adacore.com>
1843
1844         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1845         padding at end of comment.
1846
1847 2019-05-08  Tom Tromey  <tromey@adacore.com>
1848
1849         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1850         Compare main types.
1851
1852 2019-05-06  Tom Tromey  <tom@tromey.com>
1853
1854         * common/scoped_mmap.c: Include common-defs.h.
1855         * common/scoped_mmap.h: Don't include config.h.
1856
1857 2019-05-04  Tom Tromey  <tom@tromey.com>
1858
1859         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1860         (struct aarch64_call_info): Add initializers.
1861         <si>: Now a std::vector.
1862         (pass_on_stack, aarch64_push_dummy_call): Update.
1863
1864 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1865             Tom Tromey  <tom@tromey.com>
1866
1867         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1868         (ppc_threads): Now a std::vector.  Now static.
1869         (hwdebug_find_thread_points_by_tid)
1870         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1871         Update.
1872
1873 2019-05-04  Tom Tromey  <tom@tromey.com>
1874
1875         * arc-tdep.c (arc_tdesc_init): Return bool.
1876
1877 2019-05-04  Tom Tromey  <tom@tromey.com>
1878
1879         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1880         Use gdb_assert_not_reached.
1881
1882 2019-05-04  Tom Tromey  <tom@tromey.com>
1883
1884         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1885         "false".
1886
1887 2019-05-04  Tom Tromey  <tom@tromey.com>
1888
1889         * arc-tdep.c (arc_tdesc_init): Use bool.
1890
1891 2019-05-04  Tom Tromey  <tom@tromey.com>
1892
1893         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1894
1895 2019-05-04  Tom Tromey  <tom@tromey.com>
1896
1897         * cli/cli-cmds.c (valid_command_p): Return bool.
1898
1899 2019-05-04  Tom Tromey  <tom@tromey.com>
1900
1901         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1902         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1903
1904 2019-05-04  Raul Tambre  <raul@tambre.ee>
1905
1906         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1907         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1908         operator for comparison.
1909
1910 2019-05-04  Tom Tromey  <tom@tromey.com>
1911
1912         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1913         (lookup_partial_symbol, print_partial_symbols)
1914         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1915         (psymbol_compare): Update.
1916         (add_psymbol_to_bcache): Clear the entire psymbol.
1917         (maintenance_check_psymtabs): Update.
1918         * psympriv.h (struct partial_symbol): Don't derive from
1919         general_symbol_info.
1920         <obj_section, unrelocated_address, address,
1921         set_unrelocated_address>: Update.
1922         <ginfo>: New member.
1923         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1924         (debug_names::write_psymbols): Update.
1925
1926 2019-05-04  Tom de Vries  <tdevries@suse.de>
1927
1928         * contrib/cc-with-tweaks.sh: Support -n arg.
1929
1930 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1931
1932         * corelow.c (core_target::detach): Ensure frame cache and
1933         register caches are cleared.
1934         inferior.c (exit_inferior_1): Likewise.
1935
1936 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1937             Tom Tromey  <tom@tromey.com>
1938
1939         * dictionary.c (collate_pending_symbols_by_language): Remove
1940         "struct" from foreach.
1941         * symtab.c (lookup_global_symbol_from_objfile)
1942         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1943         foreach.
1944         * ser-tcp.c (net_open): Remove "struct" from foreach.
1945         * objfiles.c (objfile_relocate, objfile_rebase)
1946         (objfile_has_symbols): Remove "struct" from foreach.
1947         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1948         from foreach.
1949         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1950         foreach.
1951         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1952         "struct" from foreach.
1953         * ada-lang.c (create_excep_cond_exprs)
1954         (ada_exception_catchpoint_cond_string): Remove "struct" from
1955         foreach.
1956
1957 2019-05-03  Tom Tromey  <tromey@adacore.com>
1958
1959         * ada-exp.y (convert_char_literal): Check suffix of each
1960         enumerator.
1961
1962 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1963
1964         PR ada/21406:
1965         * ada-exp.y (yywrap): Don't define.
1966         * ada-lex.l (%option): Add noyywrap
1967         (yywrap): Remove.
1968
1969 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1970
1971         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1972         _WIN32_WINNT to the XP level, unless already defined to a higher
1973         level.
1974
1975         * unittests/parse-connection-spec-selftests.c:
1976         * ser-tcp.c:
1977         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1978         override.
1979
1980         * symfile.c (find_separate_debug_file): Remove colon from the
1981         drive spec of DOS/Windows file names of the target, so that the
1982         file name produced from DEBUGDIR and the target's directory will
1983         be valid on DOS/Windows systems.
1984
1985 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1986
1987         * rust-lang.c (val_print_struct): Handle printing structures
1988         containing strings.
1989
1990 2019-05-02  Tom Tromey  <tromey@adacore.com>
1991
1992         * valarith.c (_initialize_valarith): Remove.
1993
1994 2019-05-01  Tom Tromey  <tromey@adacore.com>
1995
1996         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1997         bitfields.
1998
1999 2019-05-01  Tom Tromey  <tromey@adacore.com>
2000
2001         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2002         for big-endian copies.
2003
2004 2019-04-30  Ali Tamur  <tamur@google.com>
2005         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2006         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2007         (read_3_bytes): New function.
2008
2009 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2010
2011         * windows-nat.c (main_thread_id): Delete.
2012         (handle_output_debug_string): Replace main_thread_id by
2013         current_event.dwThreadId.
2014         (fake_create_process): Likewise.
2015         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2016         Do not set main_thread_id.
2017         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2018         current_event.dwThreadId.
2019         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2020
2021 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2022
2023         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2024         Use current_event.dwThreadId instead of main_thread_id.
2025
2026 2019-04-30  Tom Tromey  <tromey@adacore.com>
2027
2028         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2029         (create_excep_cond_exprs): Iterate over program spaces.
2030         (ada_exception_catchpoint_cond_string): Examine all minimal
2031         symbols for exception types.
2032
2033 2019-04-30  Tom Tromey  <tromey@adacore.com>
2034
2035         PR c++/24470:
2036         * dwarf2read.c (process_structure_scope): Handle case where type
2037         has template parameters but no symbol was created.
2038
2039 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2040             Chris January  <chris.january@arm.com>
2041
2042         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2043         qualifier.
2044         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2045
2046 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2047
2048         * f-typeprint.c (f_print_type): Update rules for printing
2049         whitespace.
2050         (f_type_print_varspec_suffix): Likewise.
2051
2052 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2053             Chris January  <chris.january@arm.com>
2054
2055         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2056         function arguments.
2057
2058 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2059
2060         * f-lang.c (build_fortran_types): Change name of void type to
2061         lower case.
2062         * f-typeprint.c (f_type_print_base): Print the name of the void
2063         type, rather than a fixed string.
2064         * f-valprint.c (f_decorations): Use lower case void string.
2065
2066 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2067             Chris January  <chris.january@arm.com>
2068
2069         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2070         types for Fortran.
2071
2072 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2073             Chris January  <chris.january@arm.com>
2074             David Lecomber  <david.lecomber@arm.com>
2075
2076         * f-exp.y (BINOP_INTRINSIC): New token.
2077         (exp): New parser rule handling BINOP_INTRINSIC.
2078         (f77_keywords): Add new builtin procedures.
2079         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2080         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2081         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2082         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2083         (print_unop_subexp_f): New function.
2084         (print_binop_subexp_f): New function.
2085         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2086         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2087         (dump_subexp_body_f): Likewise.
2088         (operator_check_f): Likewise.
2089         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2090         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2091
2092 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2093
2094         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2095         UNOP_KIND.
2096         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2097         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2098         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2099         (operator_length_f): New fuction.
2100         (print_subexp_f): New function.
2101         (op_name_f): New function.
2102         (dump_subexp_body_f): New function.
2103         (operator_check_f): New function.
2104         (exp_descriptor_f): Replace standard expression handling functions
2105         with new functions.
2106         * gdb/fortran-operator.def: New file.
2107         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2108         * gdb/std-operator.def: Remove UNOP_KIND.
2109
2110 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2111
2112         * std-operator.def: Remove unbalanced, stray double quote
2113         character.
2114
2115 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2116             Chris January  <chris.january@arm.com>
2117             Daniel Everett  <daniel.everett@arm.com>
2118             Nick Forrington  <nick.forrington@arm.com>
2119             Richard Bunt  <richard.bunt@arm.com>
2120
2121         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2122         of depth when printing anonymous structs or unions.
2123         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2124         Don't print either the top-level value, or the children if the
2125         max-depth is exceeded.
2126         (ppscm_print_children): When printing the key of a map, allow one
2127         extra level of depth.
2128         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2129         print either the top-level value, or the children if the max-depth
2130         is exceeded.
2131         (print_children): When printing the key of a map, allow one extra
2132         level of depth.
2133         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2134         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2135         (user_print_options): Initialise max_depth field.
2136         (val_print_scalar_or_string_type_p): New function.
2137         (val_print): Check to see if the max depth has been reached.
2138         (val_print_check_max_depth): Define new function.
2139         (show_print_max_depth): New function.
2140         (_initialize_valprint): Add 'print max-depth' option.
2141         * valprint.h (struct value_print_options) <max_depth>: New field.
2142         (val_print_check_max_depth): Declare new function.
2143         * NEWS: Document new feature.
2144
2145 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2146
2147         * ada-lang.c (ada_language_defn): Initialise new field.
2148         * c-lang.c (c_is_string_type_p): New function.
2149         (c_language_defn): Initialise new field.
2150         (cplus_language_defn): Initialise new field.
2151         (asm_language_defn): Initialise new field.
2152         (minimal_language_defn): Initialise new field.
2153         * c-lang.h (c_is_string_type_p): Declare new function.
2154         * d-lang.c (d_language_defn): Initialise new field.
2155         * f-lang.c (f_is_string_type_p): New function.
2156         (f_language_defn): Initialise new field.
2157         * go-lang.c (go_is_string_type_p): New function.
2158         (go_language_defn): Initialise new field.
2159         * language.c (default_is_string_type_p): New function.
2160         (unknown_language_defn): Initialise new field.
2161         (auto_language_defn): Initialise new field.
2162         * language.h (struct language_defn) <la_is_string_type_p>: New
2163         member variable.
2164         (default_is_string_type_p): Declare new function.
2165         * m2-lang.c (m2_language_defn): Initialise new field.
2166         * objc-lang.c (objc_language_defn): Initialise new field.
2167         * opencl-lang.c (opencl_language_defn): Initialise new field.
2168         * p-lang.c (pascal_is_string_type_p): New function.
2169         (pascal_language_defn): Initialise new field.
2170         * rust-lang.c (rust_is_string_type_p): New function.
2171         (rust_language_defn): Initialise new field.
2172
2173 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2174
2175         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2176         New field.
2177         * ada-lang.c (ada_language_defn): Initialise new field.
2178         * c-lang.c (c_language_defn): Likewise.
2179         (cplus_language_defn): Likewise.
2180         (asm_language_defn): Likewise.
2181         (minimal_language_defn): Likewise.
2182         * d-lang.c (d_language_defn): Likewise.
2183         * f-lang.c (f_language_defn): Likewise.
2184         * go-lang.c (go_language_defn): Likewise.
2185         * language.c (unknown_language_defn): Likewise.
2186         (auto_language_defn): Likewise.
2187         * m2-lang.c (m2_language_defn): Likewise.
2188         * objc-lang.c (objc_language_defn): Likewise.
2189         * opencl-lang.c (opencl_language_defn): Likewise.
2190         * p-lang.c (pascal_language_defn): Likewise.
2191         * rust-lang.c (rust_language_defn): Likewise.
2192
2193 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2194
2195         * ada-lang.c (ada_is_character_type): Change return type to bool.
2196         (ada_is_string_type): Likewise.
2197         * ada-lang.h (ada_is_character_type): Update declaration
2198         (ada_is_string_type): Likewise.
2199
2200 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2201
2202         Support style in 'frame|thread apply'
2203
2204         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2205         * record.c (record_start, record_stop): Update callers of
2206         execute_command_to_string with false.
2207         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2208         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2209         methods.
2210         (class string_file): New constructor with term_out parameter.
2211         Override methods term_out and can_emit_style_escape.  New member
2212         term_out.
2213         (class stdio_file): Override can_emit_style_escape.
2214         (class tee_file): Override term_out and can_emit_style_escape.
2215         * utils.h (can_emit_style_escape): Remove.
2216         * utils.c (can_emit_style_escape): Likewise.
2217         Update all callers of can_emit_style_escape (SOMESTREAM) to
2218         SOMESTREAM->can_emit_style_escape.
2219         * source-cache.c (source_cache::get_source_lines): Likewise.
2220         * stack.c (frame_apply_command_count): Call execute_command_to_string
2221         passing the term_out characteristic of the current gdb_stdout.
2222         * thread.c (thr_try_catch_cmd): Likewise.
2223         * top.c (execute_command_to_string): pass term_out parameter
2224         to construct the string_file for the command output.
2225         * ui-file.c (term_cli_styling): New function (most code moved
2226         from utils.c can_emit_style_escape).
2227         (string_file::string_file, string_file::can_emit_style_escape,
2228         stdio_file::can_emit_style_escape, tee_file::term_out,
2229         tee_file::can_emit_style_escape): New functions.
2230
2231 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2232
2233         * NEWS: Mention the new set|show may-call-functions.
2234         * infcall.c (may_call_functions_p): New variable.
2235         (show_may_call_functions_p): New function.
2236         (call_function_by_hand_dummy): Throws an error if not
2237         may-call-functions.
2238         (_initialize_infcall): Call add_setshow_boolean_cmd for
2239         may-call-functions.
2240
2241 2019-04-25  Keith Seitz  <keiths@redhat.com>
2242
2243         PR c++/24367
2244         * cp-support.c (inspect_type): Don't attempt substitutions
2245         of symbol with the same name.
2246
2247 2019-04-25  Tom Tromey  <tromey@adacore.com>
2248
2249         PR gdb/24475:
2250         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2251         static.
2252
2253 2019-04-25  Tom Tromey  <tromey@adacore.com>
2254
2255         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2256         rvalue reference.
2257         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2258         (gdb_xml_parser::parse): Use std::move.
2259         * python/python-internal.h (gdbpy_convert_exception): Take a const
2260         reference.
2261         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2262         std::move.
2263         * python/py-utils.c (gdbpy_convert_exception): Take a const
2264         reference.
2265         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2266         Use std::move.
2267         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2268         Use std::move.
2269         * mi/mi-main.c (mi_print_exception): Take a const reference.
2270         * main.c (handle_command_errors): Take a const reference.
2271         * linespec.c (parse_linespec): Use std::move.
2272         * infcall.c (run_inferior_call): Use std::move.
2273         (call_function_by_hand_dummy): Use std::move.
2274         * exec.c (try_open_exec_file): Use std::move.
2275         * exceptions.h (exception_print, exception_fprintf)
2276         (exception_print_same): Update.
2277         * exceptions.c (print_exception, exception_print)
2278         (exception_fprintf, exception_print_same): Change parameters to
2279         const reference.
2280         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2281         * common/new-op.c: Use std::move.
2282         * common/common-exceptions.h (struct gdb_exception): Add move
2283         constructor.
2284         (struct gdb_exception_error, struct gdb_exception_quit, struct
2285         gdb_quit_bad_alloc): Change constructor to move constructor.
2286         (throw_exception): Change parameter to rvalue reference.
2287         * common/common-exceptions.c (throw_exception): Take rvalue
2288         reference.
2289         * cli/cli-interp.c (safe_execute_command): Use std::move.
2290         * breakpoint.c (insert_bp_location, location_to_sals): Use
2291         std::move.
2292
2293 2019-04-25  Tom Tromey  <tromey@adacore.com>
2294
2295         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2296         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2297         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2298         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2299         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2300         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2301         guile/scm-value.c: Use unpack.
2302         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2303         gdbscm_gdb_exception.
2304         (gdbscm_throw_gdb_exception): Likewise.
2305         (struct gdbscm_gdb_exception): New.
2306         (unpack): New function.
2307         (gdbscm_wrap): Use unpack.
2308
2309 2019-04-25  Tom Tromey  <tromey@adacore.com>
2310
2311         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2312         (gdb_rl_callback_handler): Use std::move.
2313         * common/common-exceptions.h (struct gdb_exception): Add move
2314         assignment operator.
2315         (throw_exception_sjlj): Change "exception" to const reference.
2316         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2317         (throw_exception_sjlj): Change "exception" to const reference.
2318
2319 2019-04-25  Tom Tromey  <tromey@adacore.com>
2320
2321         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2322         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2323         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2324         Update.
2325         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2326         Update.
2327         * mi/mi-interp.c (mi_interp::exec): Update.
2328         * linespec.c (parse_linespec): Update.
2329         * infcall.c (run_inferior_call): Update.
2330         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2331         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2332         (gdbscm_lookup_global_symbol): Update.
2333         * guile/scm-param.c (gdbscm_parameter_value): Update.
2334         * guile/scm-frame.c (gdbscm_frame_read_register)
2335         (gdbscm_frame_read_var): Update.
2336         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2337         * exec.c (try_open_exec_file): Update.
2338         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2339         (gdb_rl_callback_handler): Update.
2340         * common/common-exceptions.h (exception_none): Don't declare.
2341         * common/common-exceptions.c (exception_none): Don't define.
2342         (struct catcher) <exception>: Update.
2343         * cli/cli-interp.c (safe_execute_command): Update.
2344         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2345
2346 2019-04-25  Ali Tamur  <tamur@google.com>
2347
2348         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2349         (read_attribute_value): Likewise.
2350         (dwarf2_read_addr_index): Update comment.
2351         (read_str_index): Add DW_FORM_strx.
2352         (dwarf2_string_attr): Likewise.
2353         (dwarf2_const_value_attr): Likewise.
2354         (dump_die_shallow): Likewise.
2355         (dwarf2_fetch_constant_bytes): Likewise.
2356         (skip_form_bytes): Likewise.
2357         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2358
2359 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2360
2361         PR corefiles/11608
2362         PR corefiles/18187
2363         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2364         OFFSET.  Verify if current mapping contains an ELF header.
2365         (linux_find_memory_regions_full): Adjust call to
2366         dump_mapping_p.
2367
2368 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2369             Kang Li <kanglictf@gmail.com>
2370
2371         PR gdb/21600
2372
2373         * dwarf2-frame.c (read_initial_length): Be consistent about using
2374         unsigned representation of length.
2375         (decode_frame_entry_1): Likewise.  Check for wraparound of
2376         end pointer as well as buffer overflow.
2377
2378 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2379
2380         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2381         "vq".
2382
2383 2019-04-24  Tom Tromey  <tromey@adacore.com>
2384
2385         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2386
2387 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2388
2389         * s12z-tdep.c (s12z_unwind_pc): Delete.
2390         (s12z_unwind_sp): Delete.
2391         (s12z_gdbarch_init): Don't register deleted functions with
2392         gdbarch.
2393
2394 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2395
2396         * rl78-tdep.c (rl78_unwind_sp): Delete.
2397         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2398
2399 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2400
2401         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2402         (xstormy16_unwind_pc): Delete.
2403         (xstormy16_dummy_id): Delete.
2404         (xstormy16_gdbarch_init): Don't register deleted functions with
2405         gdbarch.
2406
2407 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2408
2409         * vax-tdep.c (vax_unwind_pc): Delete.
2410         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2411
2412 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2413
2414         * v850-tdep.c (v850_unwind_sp): Delete.
2415         (v850_unwind_pc): Delete.
2416         (v850_dummy_id): Delete.
2417         (v850_gdbarch_init): Don't register deleted functions with
2418         gdbarch.
2419
2420 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2421
2422         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2423         (tilegx_unwind_pc): Delete.
2424         (tilegx_unwind_dummy_id): Delete.
2425         (tilegx_gdbarch_init): Don't register deleted functions with
2426         gdbarch.
2427
2428 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2429
2430         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2431         (tic6x_dummy_id): Delete.
2432         (tic6x_gdbarch_init): Don't register deleted functions with
2433         gdbarch.
2434
2435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2436
2437         * sparc-tdep.c (sparc_unwind_pc): Delete.
2438         (sparc32_gdbarch_init): Don't register deleted function with
2439         gdbarch.
2440
2441 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2442
2443         * sh-tdep.c (sh_unwind_sp): Delete.
2444         (sh_unwind_pc): Delete.
2445         (sh_dummy_id): Delete.
2446         (sh_gdbarch_init): Don't register deleted functions with
2447         gdbarch.
2448
2449 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2450
2451         * score-tdep.c (score_unwind_sp): Delete.
2452         (score_unwind_pc): Delete.
2453         (score_dummy_id): Delete.
2454         (score_gdbarch_init): Don't register deleted functions with
2455         gdbarch.
2456
2457 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2458
2459         * rx-tdep.c (rx_unwind_pc): Delete.
2460         (rx_unwind_sp): Delete.
2461         (rx_dummy_id): Delete.
2462         (rx_gdbarch_init): Don't register deleted functions with
2463         gdbarch.  Update comment.
2464
2465 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2466
2467         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2468         (rs6000_dummy_id): Delete.
2469         (rs6000_gdbarch_init): Don't register deleted functions with
2470         gdbarch.
2471
2472 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2473
2474         * or1k-tdep.c (or1k_dummy_id): Delete.
2475         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2476
2477 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2478
2479         * nios2-tdep.c (nios2_dummy_id): Delete.
2480         (nios2_unwind_sp): Delete.
2481         (nios2_gdbarch_init): Don't register deleted functions with
2482         gdbarch.
2483
2484 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2485
2486         * nds32-tdep.c (nds32_dummy_id): Delete.
2487         (nds32_unwind_pc): Delete.
2488         (nds32_unwind_sp): Delete.
2489         (nds32_gdbarch_init): Don't register deleted functions with
2490         gdbarch.
2491
2492 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2493
2494         * msp430-tdep.c (msp430_unwind_pc): Delete.
2495         (msp430_unwind_sp): Delete.
2496         (msp430_dummy_id): Delete.
2497         (msp430_gdbarch_init): Don't register deleted functions with
2498         gdbarch.
2499
2500 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2501
2502         * moxie-tdep.c (moxie_unwind_sp): Delete.
2503         (moxie_unwind_pc): Delete.
2504         (moxie_dummy_id): Delete.
2505         (moxie_gdbarch_init): Don't register deleted functions with
2506         gdbarch.
2507
2508 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2509
2510         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2511         (mn10300_unwind_pc): Delete.
2512         (mn10300_unwind_sp): Delete.
2513         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2514         mn10300_unwind_sp.
2515         (mn10300_frame_unwind_init): Don't register deleted functions with
2516         gdbarch.
2517
2518 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2519
2520         * mep-tdep.c (mep_unwind_pc): Delete.
2521         (mep_unwind_sp): Delete.
2522         (mep_dummy_id): Delete.
2523         (mep_gdbarch_init): Don't register deleted functions with
2524         gdbarch.
2525
2526 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2527
2528         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2529         (m68hc11_unwind_sp): Delete.
2530         (m68hc11_gdbarch_init): Don't register deleted functions with
2531         gdbarch.
2532
2533 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2534
2535         * m32r-tdep.c (m32r_unwind_sp): Delete.
2536         (m32r_unwind_pc): Delete.
2537         (m32r_dummy_id): Delete.
2538         (m32r_gdbarch_init): Don't register deleted functions with
2539         gdbarch.
2540
2541 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2542
2543         * m32c-tdep.c (m32c_unwind_pc): Delete.
2544         (m32c_unwind_sp): Delete.
2545         (m32c_dummy_id): Delete.
2546         (m32c_gdbarch_init): Don't register deleted functions with
2547         gdbarch.
2548
2549 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2550
2551         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2552         (lm32_unwind_pc): Delete.
2553         (lm32_dummy_id): Delete.
2554         (lm32_gdbarch_init): Don't register deleted functions with
2555         gdbarch.
2556
2557 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2558
2559         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2560         (iq2000_unwind_pc): Delete.
2561         (iq2000_dummy_id): Delete.
2562         (iq2000_gdbarch_init): Don't register deleted functions with
2563         gdbarch.
2564
2565 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2566
2567         * nds32-tdep.c (nds32_type_align): Delete.
2568         (nds32_push_dummy_call): Use type_align instead.
2569
2570 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2571
2572         * arm-tdep.c (arm_type_align): Only handle vector override case.
2573         (arm_push_dummy_call): Use type_align.
2574         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2575
2576 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2577
2578         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2579         case.
2580         (pass_on_stack): Use type_align.
2581         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2582         function.
2583
2584 2019-04-23  Tom Tromey  <tromey@adacore.com>
2585
2586         * dwarf2read.c (line_header::file_name_at): Remove unused
2587         overload.
2588
2589 2019-04-23  Tom de Vries  <tdevries@suse.de>
2590
2591         PR gdb/24438
2592         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2593         invocation.
2594
2595
2596 2019-03-27  Ali Tamur  <tamur@google.com>
2597
2598         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2599         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2600         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2601         (dwarf_expr_context::get_addr_index): Likewise
2602         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2603         (symbol_needs_eval_context::get_addr_index): Likewise
2604         (disassemble_dwarf_expression): Add DW_OP_addrx
2605         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2606         (read_cutu_die_from_dwo): Update comment
2607         (skip_one_die): Add DW_FORM_addrx
2608         (read_attribute_value): Likewise
2609         (var_decode_location): Add DW_OP_addrx
2610         (dwarf2_const_value_attr): Add DW_FORM_addrx
2611         (dump_die_shallow): Likewise
2612         (dwarf2_fetch_constant_bytes): Likewise
2613         (decode_locdesc): Add DW_OP_addrx
2614         (skip_form_bytes): Add DW_FORM_addrx
2615
2616 2019-04-22  Ali Tamur  <tamur@google.com>
2617
2618         * MAINTAINERS (Write After Approval): Add self.
2619
2620 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2621
2622         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2623         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2624         (open_symbol_file_object): Likewise.
2625         (svr4_default_sos): Add info parameter.
2626         (svr4_read_so_list): Likewise.
2627         (svr4_current_sos_direct): Adjust functions calls to pass down
2628         info.
2629         (svr4_current_sos_1): Add info parameter.
2630         (svr4_current_sos): Call get_svr4_info, pass info down to
2631         svr4_current_sos_1.
2632         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2633         get_svr4_info.
2634         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2635         get_svr4_info.
2636         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2637         to get_svr4_info.
2638         (probes_table_remove_objfile_probes): Likewise.
2639         (register_solib_event_probe): Add info parameter.
2640         (solist_update_incremental): Pass info parameter down to
2641         svr4_read_so_list.
2642         (disable_probes_interface): Add info parameter.
2643         (svr4_handle_solib_event): Pass current_program_space to
2644         get_svr4_info.  Adjust disable_probes_interface cleanup.
2645         (svr4_create_probe_breakpoints): Add info parameter, pass it
2646         down to register_solib_event_probe.
2647         (svr4_create_solib_event_breakpoints): Add info parameter,
2648         pass it down to svr4_create_probe_breakpoints.
2649         (enable_break): Pass info down to
2650         svr4_create_solib_event_breakpoints.
2651         (svr4_solib_create_inferior_hook): Pass current_program_space to
2652         get_svr4_info.
2653         (svr4_clear_solib): Likewise.
2654
2655 2019-04-22  Pedro Alves  <palves@redhat.com>
2656
2657         * solib-svr4.c (svr4_free_objfile_observer): New.
2658         (probe_and_action::objfile): New field.
2659         (probes_table_htab_remove_objfile_probes)
2660         (probes_table_remove_objfile_probes): New functions.
2661         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2662         in the new probe_and_action.  Don't store the probe in 'lookup'.
2663         (svr4_create_probe_breakpoints): Pass objfile to
2664         register_solib_event_probe.
2665         (_initialize_svr4_solib): Register a free_objfile observer.
2666
2667 2019-04-19  Tom Tromey  <tom@tromey.com>
2668
2669         * common/queue.h: Remove.
2670
2671 2019-04-19  Tom Tromey  <tom@tromey.com>
2672
2673         * event-loop.c: Don't include "common/queue.h".
2674
2675 2019-04-19  Tom Tromey  <tom@tromey.com>
2676
2677         * remote.c (remote_target): Use delete.
2678         * remote-notif.h: Include <list>, not "common/queue.h".
2679         (notif_client_p): Remove typedef.
2680         (remote_notif_state): Add constructor, destructor, initializer.
2681         <notif_queue>: Now a std::list.
2682         (remote_notif_state_xfree): Don't declare.
2683         * remote-notif.c (remote_notif_process, handle_notification)
2684         (remote_notif_state_allocate): Update.
2685         (~remote_notif_state): Rename from remote_notif_state_xfree.
2686
2687 2019-04-19  Tom Tromey  <tom@tromey.com>
2688
2689         * symfile.c (reread_symbols): Update.
2690         * objfiles.c (objfile_register_static_link)
2691         (objfile_lookup_static_link): Update
2692         (~objfile) Don't delete static_links.
2693         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2694
2695 2019-04-19  Tom Tromey  <tom@tromey.com>
2696
2697         * type-stack.h (struct type_stack) <insert>: Constify string.
2698         * type-stack.c (type_stack::insert): Constify string.
2699         * gdbtypes.h (lookup_template_type): Update.
2700         (address_space_name_to_int): Update.
2701         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2702         const.
2703         (lookup_template_type): Make name const.
2704         * c-exp.y: Update rules.
2705         (lex_one_token, classify_name, classify_inner_name)
2706         (c_print_token): Update.
2707         * p-exp.y: Update rules.
2708         (yylex): Update.
2709         * f-exp.y: Update rules.
2710         (yylex): Update.
2711         * d-exp.y: Update rules.
2712         (lex_one_token, classify_name, classify_inner_name): Update.
2713         * parse.c (write_dollar_variable, copy_name): Return std::string.
2714         * parser-defs.h (copy_name): Change return type.
2715         * m2-exp.y: Update rules.
2716         (yylex): Update.
2717         * go-exp.y (lex_one_token): Update.
2718         Update rules.
2719         (classify_unsafe_function, classify_packaged_name)
2720         (classify_name, yylex): Update.
2721
2722 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2723
2724         * configure.ac: add --enable-source-highlight switch.
2725         * configure: Regenerate.
2726         * top.c (print_gdb_version): plumb --enable-source-highlight
2727         status to "show configuration".
2728
2729 2019-04-19  Tom Tromey  <tromey@adacore.com>
2730
2731         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2732         Check ADA_TYPE_P.
2733         (empty_record, ada_template_to_fixed_record_type_1)
2734         (template_to_static_fixed_type)
2735         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2736         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2737         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2738         macros.
2739
2740 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2741
2742         PR symtab/24423:
2743         * source.c (print_source_lines_base): Advance "iter" when a
2744         control character is seen.
2745
2746 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2747
2748         * inferior.h (struct infcall_suspend_state_deleter):
2749         Catch exception in destructor to avoid crash.
2750
2751 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2752
2753         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2754         close to the add_com "shell".
2755
2756 2019-04-18  Tom Tromey  <tromey@adacore.com>
2757
2758         * process-stratum-target.h (class process_stratum_target)
2759         <stratum>: Add "final".
2760
2761 2019-04-17  Tom Tromey  <tromey@adacore.com>
2762
2763         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2764         against nullptr before use.
2765
2766 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2767
2768         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2769
2770 2019-04-17  Jim Wilson  <jimw@sifive.com>
2771             Andrew Burgess  <andrew.burgess@embecosm.com>
2772
2773         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2774         code read might fail, assume 4-byte breakpoint in that case.
2775
2776 2019-04-15  Leszek Swirski  <leszeks@google.com>
2777
2778         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2779         rather than a hand-rolled POD check when checking for forced MEMORY
2780         classification.
2781
2782 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2783
2784         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2785         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2786         function.
2787         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2788         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2789         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2790         declaration.
2791
2792 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2793
2794         * aarch64-linux-nat.c
2795         (aarch64_linux_nat_target::thread_architecture): Add override.
2796         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2797         each VQ.
2798
2799 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2800
2801         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2802
2803 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2804
2805         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2806         target types of size 96-bits, add some additional comments, and
2807         check that the builtin type we found was the correct size.
2808
2809 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2810
2811         * utils.c (prompt_for_continue): Don't restore the styling at the
2812         end, as applied_style has the wrong value.  This fixes styling in
2813         long lists of file names that are interrupted by the "Continue?"
2814         prompt.
2815
2816 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2817
2818         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2819         * c-lang.c (c_language_defn): Likewise.
2820         (cplus_language_defn): Likewise.
2821         (asm_language_defn): Likewise.
2822         (minimal_language_defn): Likewise.
2823         * d-lang.c (d_language_defn): Likewise.
2824         * f-lang.c (f_language_defn): Likewise.
2825         * go-lang.c (go_language_defn): Likewise.
2826         * language.c (unknown_language_defn): Likewise.
2827         (auto_language_defn): Likewise.
2828         * language.h (struct language_defn): Remove la_magic field.
2829         (LANG_MAGIC): Delete.
2830         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2831         * objc-lang.c (objc_language_defn): Likewise.
2832         * opencl-lang.c (opencl_language_defn): Likewise.
2833         * p-lang.c (pascal_language_defn): Likewise.
2834         * rust-lang.c (rust_language_defn): Likewise.
2835
2836 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2837
2838         * riscv-tdep.c (riscv_type_align): New function.
2839         (riscv_type_alignment): Delete.
2840         (riscv_arg_location): Use 'type_align'.
2841         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2842
2843 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2844
2845         * gdbtypes.c (type_align): A struct with no non-static fields also
2846         has alignment of 1.
2847
2848 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2849
2850         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2851         component to 0.
2852         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2853         member.
2854         (riscv_struct_info::analyse): New implementation using new
2855         analyse_inner member function.
2856         (riscv_struct_info::field_offset): New member function.
2857         (riscv_struct_info::m_offsets): New member variable.
2858         (riscv_struct_info::analyse_inner): New private member function,
2859         takes the old implementation of riscv_struct_info::analyse but
2860         extended to track field offsets.
2861         (riscv_call_arg_struct): Update the struct folding special cases
2862         to handle cases where empty C++ structs, which are non-zero
2863         length, are found.
2864         (riscv_arg_location): Initialise the length of each location, a
2865         non-zero length now indicates the location is in use.
2866         (riscv_push_dummy_call): Allow for the first location having a
2867         non-zero offset when setting up arguments.
2868         (riscv_return_value): Likewise, but for return values.
2869
2870 2019-04-11  Tom Tromey  <tromey@adacore.com>
2871
2872         * utils.c (internal_vproblem): Make "msg" const.
2873
2874 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2875
2876         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2877         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2878         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2879         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2880
2881 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2882
2883         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2884         function.
2885         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2886         of amd64_collect_native_gregset.
2887         (amd64_linux_nat_target::store_registers): Likewise.
2888
2889 2019-04-10  Tom Tromey  <tom@tromey.com>
2890
2891         * symtab.c (lookup_global_symbol_from_objfile)
2892         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2893         * objfiles.h (class separate_debug_iterator): New.
2894         (class separate_debug_range): New.
2895         (struct objfile) <separate_debug_objfiles>: New method.
2896         (objfile_separate_debug_iterate): Don't declare.
2897         * objfiles.c (separate_debug_iterator::operator++): Rename from
2898         objfile_separate_debug_iterate.
2899         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2900         iterator.
2901         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2902         iterator.
2903
2904 2019-04-10  Tom Tromey  <tom@tromey.com>
2905
2906         * symfile.c (reread_symbols): Remove old comment.
2907         * objfiles.c (free_all_objfiles): Fix a typo.
2908
2909 2019-04-10  Tom Tromey  <tom@tromey.com>
2910
2911         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2912         * minsyms.c (lookup_minimal_symbol): Use foreach.
2913         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2914         (lookup_minimal_symbol_solib_trampoline): Likewise.
2915         * symfile.c (reread_symbols): Use foreach.
2916
2917 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2918             Tom Tromey  <tromey@adacore.com>
2919
2920         PR rust/24414:
2921         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2922         (rust_lex_int_test): Change "value" to be LONGEST.
2923         (rust_lex_tests): Add test for long integer literal.
2924
2925 2019-04-09  Tom Tromey  <tromey@adacore.com>
2926
2927         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2928         to bool.
2929         (extended_remote_target::attach): Update.
2930         (remote_target::remote_notice_new_inferior): Update.
2931         (remote_target::add_current_inferior_and_thread): Update.
2932         * inferior.c (exit_inferior_1): Use "false".
2933         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2934
2935 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2936
2937         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2938         the "start" command.
2939
2940 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2941
2942         * python/py-inferior.c (infpy_thread_from_thread_handle):
2943         Adjust comments to reflect renaming of thread_from_thread_handle
2944         to thread_from_handle.  Adjust keywords.  Fix type error message.
2945         (inferior_object_methods): Add thread_from_handle.  Retain
2946         thread_from_thread_handle, but mark it as deprecated.
2947
2948 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2949
2950         * gdbthread.h (find_thread_by_handle): Revise declaration.
2951         * thread.c (find_thread_by_handle): Likewise.  Adjust
2952         implementation too.
2953         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2954         support for buffer objects as handles.
2955
2956 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2957
2958         * python/py-infthread.c (thpy_thread_handle): New function.
2959         (thread_object_methods): Register thpy_thread_handle.
2960
2961 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2962
2963         * gdbthread.h (thread_to_thread_handle): Declare.
2964         * thread.c (gdbtypes.h): Include.
2965         (thread_to_thread_handle): New function.
2966
2967         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2968         (target_thread_info_to_thread_handle): Declare.
2969         * target.c (target_thread_info_to_thread_handle): New function.
2970         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2971         * target-delegates.c: Regenerate.
2972
2973         * linux-thread-db.c (class thread_db_target): Add method
2974         thread_info_to_thread_handle.
2975         (thread_db_target::thread_info_to_thread_handle): Define.
2976         * remote.c (class remote_target): Add new method
2977         thread_info_to_thread_handle.
2978         (remote_target::thread_info_to_thread_handle): Define.
2979
2980 2019-04-08  Pedro Alves  <palves@redhat.com>
2981
2982         * common/common-exceptions.c (throw_exception): Don't create
2983         named object to throw; throw directly.
2984         (throw_it): Likewise.  Don't initialize gdb_exception::message
2985         here, with new; pass FMT and AP to the ctor instead.
2986         * common/common-exceptions.h: Include <string>.
2987         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2988         const char *, va_list)): New ctor.  Use std::make_shared.
2989         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2990         errors)): Delete.
2991         (gdb_exception_error::gdb_exception_error(enum errors, const char
2992         *, va_list)): New.
2993         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2994         Add assertion.
2995         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2996         errors)): Delete.
2997         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2998         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2999         Add assertion.
3000
3001 2019-04-08  Tom Tromey  <tom@tromey.com>
3002
3003         * valops.c (value_rtti_indirect_type): Replace throw_exception
3004         with throw.
3005         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3006         with throw.
3007         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3008         throw.
3009         * target.c (target_translate_tls_address): Replace throw_exception
3010         with throw.
3011         * stack.c (frame_apply_command_count): Replace throw_exception
3012         with throw.
3013         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3014         throw.
3015         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3016         with throw.
3017         * rs6000-tdep.c (rs6000_frame_cache)
3018         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3019         * remote.c: Replace throw_exception with throw.
3020         * record-full.c (record_full_message, record_full_wait_1)
3021         (record_full_restore): Replace throw_exception with throw.
3022         * record-btrace.c:
3023         (get_thread_current_frame_id, record_btrace_start_replaying)
3024         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3025         (cmd_record_btrace_start): Replace throw_exception with throw.
3026         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3027         throw.
3028         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3029         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3030         * linespec.c:
3031         (find_linespec_symbols): Replace throw_exception with throw.
3032         * infrun.c (displaced_step_prepare, resume): Replace
3033         throw_exception with throw.
3034         * infcmd.c (post_create_inferior): Replace throw_exception with
3035         throw.
3036         * inf-loop.c (inferior_event_handler): Replace throw_exception
3037         with throw.
3038         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3039         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3040         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3041         (get_prev_frame_always, get_frame_pc_if_available)
3042         (get_frame_address_in_block_if_available, get_frame_language):
3043         Replace throw_exception with throw.
3044         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3045         throw_exception with throw.
3046         * eval.c (fetch_subexp_value, evaluate_var_value)
3047         (evaluate_funcall, evaluate_subexp_standard): Replace
3048         throw_exception with throw.
3049         * dwarf2loc.c (call_site_find_chain)
3050         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3051         Replace throw_exception with throw.
3052         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3053         with throw.
3054         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3055         throw.
3056         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3057         * completer.c (complete_line_internal): Replace throw_exception
3058         with throw.
3059         * compile/compile-object-run.c (compile_object_run): Replace
3060         throw_exception with throw.
3061         * cli/cli-script.c (process_next_line): Replace throw_exception
3062         with throw.
3063         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3064         (btrace_enable, btrace_maint_update_pt_packets): Replace
3065         throw_exception with throw.
3066         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3067         throw_exception with throw.
3068         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3069         throw_exception with throw.
3070         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3071         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3072         * aarch64-tdep.c (aarch64_make_prologue_cache)
3073         (aarch64_make_stub_cache): Replace throw_exception with throw.
3074
3075 2019-04-08  Tom Tromey  <tom@tromey.com>
3076
3077         * common/common-exceptions.c (throw_exception): Rename from
3078         throw_exception_cxx.  Remove old copy.  Make argument const.
3079         (throw_it): Create and throw exception objects directly.
3080         * common/common-exceptions.h (throw_exception): Make argument
3081         const.
3082         (struct gdb_exception_error): Add constructor.
3083         (struct gdb_exception_quit): Add constructor.
3084
3085 2019-04-08  Tom Tromey  <tom@tromey.com>
3086
3087         * common/common-exceptions.h (exception_rethrow): Don't declare.
3088         (TRY_SJLJ): Update comment.
3089         (TRY, CATCH, END_CATCH): Remove.
3090         * common/common-exceptions.c (exception_rethrow): Remove.
3091
3092 2019-04-08  Tom Tromey  <tom@tromey.com>
3093
3094         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3095         Remove.
3096         (gdb_exception_error): Rename from
3097         gdb_exception_RETURN_MASK_ERROR.
3098         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3099         (gdb_quit_bad_alloc): Update.
3100         * aarch64-tdep.c: Update.
3101         * ada-lang.c: Update.
3102         * ada-typeprint.c: Update.
3103         * ada-valprint.c: Update.
3104         * amd64-tdep.c: Update.
3105         * arch-utils.c: Update.
3106         * break-catch-throw.c: Update.
3107         * breakpoint.c: Update.
3108         * btrace.c: Update.
3109         * c-varobj.c: Update.
3110         * cli/cli-cmds.c: Update.
3111         * cli/cli-interp.c: Update.
3112         * cli/cli-script.c: Update.
3113         * common/common-exceptions.c: Update.
3114         * common/new-op.c: Update.
3115         * common/selftest.c: Update.
3116         * compile/compile-c-symbols.c: Update.
3117         * compile/compile-cplus-symbols.c: Update.
3118         * compile/compile-object-load.c: Update.
3119         * compile/compile-object-run.c: Update.
3120         * completer.c: Update.
3121         * corelow.c: Update.
3122         * cp-abi.c: Update.
3123         * cp-support.c: Update.
3124         * cp-valprint.c: Update.
3125         * darwin-nat.c: Update.
3126         * disasm-selftests.c: Update.
3127         * dtrace-probe.c: Update.
3128         * dwarf-index-cache.c: Update.
3129         * dwarf-index-write.c: Update.
3130         * dwarf2-frame-tailcall.c: Update.
3131         * dwarf2-frame.c: Update.
3132         * dwarf2loc.c: Update.
3133         * dwarf2read.c: Update.
3134         * eval.c: Update.
3135         * event-loop.c: Update.
3136         * event-top.c: Update.
3137         * exec.c: Update.
3138         * f-valprint.c: Update.
3139         * fbsd-tdep.c: Update.
3140         * frame-unwind.c: Update.
3141         * frame.c: Update.
3142         * gdbtypes.c: Update.
3143         * gnu-v3-abi.c: Update.
3144         * guile/guile-internal.h: Update.
3145         * guile/scm-block.c: Update.
3146         * guile/scm-breakpoint.c: Update.
3147         * guile/scm-cmd.c: Update.
3148         * guile/scm-disasm.c: Update.
3149         * guile/scm-frame.c: Update.
3150         * guile/scm-lazy-string.c: Update.
3151         * guile/scm-math.c: Update.
3152         * guile/scm-param.c: Update.
3153         * guile/scm-ports.c: Update.
3154         * guile/scm-pretty-print.c: Update.
3155         * guile/scm-symbol.c: Update.
3156         * guile/scm-symtab.c: Update.
3157         * guile/scm-type.c: Update.
3158         * guile/scm-value.c: Update.
3159         * i386-linux-tdep.c: Update.
3160         * i386-tdep.c: Update.
3161         * inf-loop.c: Update.
3162         * infcall.c: Update.
3163         * infcmd.c: Update.
3164         * infrun.c: Update.
3165         * jit.c: Update.
3166         * language.c: Update.
3167         * linespec.c: Update.
3168         * linux-fork.c: Update.
3169         * linux-nat.c: Update.
3170         * linux-tdep.c: Update.
3171         * linux-thread-db.c: Update.
3172         * main.c: Update.
3173         * mi/mi-cmd-break.c: Update.
3174         * mi/mi-cmd-stack.c: Update.
3175         * mi/mi-interp.c: Update.
3176         * mi/mi-main.c: Update.
3177         * objc-lang.c: Update.
3178         * p-valprint.c: Update.
3179         * parse.c: Update.
3180         * ppc-linux-tdep.c: Update.
3181         * printcmd.c: Update.
3182         * python/py-arch.c: Update.
3183         * python/py-breakpoint.c: Update.
3184         * python/py-cmd.c: Update.
3185         * python/py-finishbreakpoint.c: Update.
3186         * python/py-frame.c: Update.
3187         * python/py-framefilter.c: Update.
3188         * python/py-gdb-readline.c: Update.
3189         * python/py-inferior.c: Update.
3190         * python/py-infthread.c: Update.
3191         * python/py-lazy-string.c: Update.
3192         * python/py-linetable.c: Update.
3193         * python/py-objfile.c: Update.
3194         * python/py-param.c: Update.
3195         * python/py-prettyprint.c: Update.
3196         * python/py-progspace.c: Update.
3197         * python/py-record-btrace.c: Update.
3198         * python/py-record.c: Update.
3199         * python/py-symbol.c: Update.
3200         * python/py-type.c: Update.
3201         * python/py-unwind.c: Update.
3202         * python/py-utils.c: Update.
3203         * python/py-value.c: Update.
3204         * python/python.c: Update.
3205         * record-btrace.c: Update.
3206         * record-full.c: Update.
3207         * remote-fileio.c: Update.
3208         * remote.c: Update.
3209         * riscv-tdep.c: Update.
3210         * rs6000-aix-tdep.c: Update.
3211         * rs6000-tdep.c: Update.
3212         * rust-exp.y: Update.
3213         * rust-lang.c: Update.
3214         * s390-tdep.c: Update.
3215         * selftest-arch.c: Update.
3216         * solib-dsbt.c: Update.
3217         * solib-frv.c: Update.
3218         * solib-spu.c: Update.
3219         * solib-svr4.c: Update.
3220         * solib.c: Update.
3221         * sparc64-linux-tdep.c: Update.
3222         * stack.c: Update.
3223         * symfile-mem.c: Update.
3224         * symmisc.c: Update.
3225         * target.c: Update.
3226         * thread.c: Update.
3227         * top.c: Update.
3228         * tracefile-tfile.c: Update.
3229         * tui/tui.c: Update.
3230         * typeprint.c: Update.
3231         * unittests/cli-utils-selftests.c: Update.
3232         * unittests/parse-connection-spec-selftests.c: Update.
3233         * valops.c: Update.
3234         * valprint.c: Update.
3235         * value.c: Update.
3236         * varobj.c: Update.
3237         * windows-nat.c: Update.
3238         * x86-linux-nat.c: Update.
3239         * xml-support.c: Update.
3240
3241 2019-04-08  Tom Tromey  <tom@tromey.com>
3242
3243         * xml-support.c: Use C++ exception handling.
3244         * x86-linux-nat.c: Use C++ exception handling.
3245         * windows-nat.c: Use C++ exception handling.
3246         * varobj.c: Use C++ exception handling.
3247         * value.c: Use C++ exception handling.
3248         * valprint.c: Use C++ exception handling.
3249         * valops.c: Use C++ exception handling.
3250         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3251         handling.
3252         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3253         * typeprint.c: Use C++ exception handling.
3254         * tui/tui.c: Use C++ exception handling.
3255         * tracefile-tfile.c: Use C++ exception handling.
3256         * top.c: Use C++ exception handling.
3257         * thread.c: Use C++ exception handling.
3258         * target.c: Use C++ exception handling.
3259         * symmisc.c: Use C++ exception handling.
3260         * symfile-mem.c: Use C++ exception handling.
3261         * stack.c: Use C++ exception handling.
3262         * sparc64-linux-tdep.c: Use C++ exception handling.
3263         * solib.c: Use C++ exception handling.
3264         * solib-svr4.c: Use C++ exception handling.
3265         * solib-spu.c: Use C++ exception handling.
3266         * solib-frv.c: Use C++ exception handling.
3267         * solib-dsbt.c: Use C++ exception handling.
3268         * selftest-arch.c: Use C++ exception handling.
3269         * s390-tdep.c: Use C++ exception handling.
3270         * rust-lang.c: Use C++ exception handling.
3271         * rust-exp.y: Use C++ exception handling.
3272         * rs6000-tdep.c: Use C++ exception handling.
3273         * rs6000-aix-tdep.c: Use C++ exception handling.
3274         * riscv-tdep.c: Use C++ exception handling.
3275         * remote.c: Use C++ exception handling.
3276         * remote-fileio.c: Use C++ exception handling.
3277         * record-full.c: Use C++ exception handling.
3278         * record-btrace.c: Use C++ exception handling.
3279         * python/python.c: Use C++ exception handling.
3280         * python/py-value.c: Use C++ exception handling.
3281         * python/py-utils.c: Use C++ exception handling.
3282         * python/py-unwind.c: Use C++ exception handling.
3283         * python/py-type.c: Use C++ exception handling.
3284         * python/py-symbol.c: Use C++ exception handling.
3285         * python/py-record.c: Use C++ exception handling.
3286         * python/py-record-btrace.c: Use C++ exception handling.
3287         * python/py-progspace.c: Use C++ exception handling.
3288         * python/py-prettyprint.c: Use C++ exception handling.
3289         * python/py-param.c: Use C++ exception handling.
3290         * python/py-objfile.c: Use C++ exception handling.
3291         * python/py-linetable.c: Use C++ exception handling.
3292         * python/py-lazy-string.c: Use C++ exception handling.
3293         * python/py-infthread.c: Use C++ exception handling.
3294         * python/py-inferior.c: Use C++ exception handling.
3295         * python/py-gdb-readline.c: Use C++ exception handling.
3296         * python/py-framefilter.c: Use C++ exception handling.
3297         * python/py-frame.c: Use C++ exception handling.
3298         * python/py-finishbreakpoint.c: Use C++ exception handling.
3299         * python/py-cmd.c: Use C++ exception handling.
3300         * python/py-breakpoint.c: Use C++ exception handling.
3301         * python/py-arch.c: Use C++ exception handling.
3302         * printcmd.c: Use C++ exception handling.
3303         * ppc-linux-tdep.c: Use C++ exception handling.
3304         * parse.c: Use C++ exception handling.
3305         * p-valprint.c: Use C++ exception handling.
3306         * objc-lang.c: Use C++ exception handling.
3307         * mi/mi-main.c: Use C++ exception handling.
3308         * mi/mi-interp.c: Use C++ exception handling.
3309         * mi/mi-cmd-stack.c: Use C++ exception handling.
3310         * mi/mi-cmd-break.c: Use C++ exception handling.
3311         * main.c: Use C++ exception handling.
3312         * linux-thread-db.c: Use C++ exception handling.
3313         * linux-tdep.c: Use C++ exception handling.
3314         * linux-nat.c: Use C++ exception handling.
3315         * linux-fork.c: Use C++ exception handling.
3316         * linespec.c: Use C++ exception handling.
3317         * language.c: Use C++ exception handling.
3318         * jit.c: Use C++ exception handling.
3319         * infrun.c: Use C++ exception handling.
3320         * infcmd.c: Use C++ exception handling.
3321         * infcall.c: Use C++ exception handling.
3322         * inf-loop.c: Use C++ exception handling.
3323         * i386-tdep.c: Use C++ exception handling.
3324         * i386-linux-tdep.c: Use C++ exception handling.
3325         * guile/scm-value.c: Use C++ exception handling.
3326         * guile/scm-type.c: Use C++ exception handling.
3327         * guile/scm-symtab.c: Use C++ exception handling.
3328         * guile/scm-symbol.c: Use C++ exception handling.
3329         * guile/scm-pretty-print.c: Use C++ exception handling.
3330         * guile/scm-ports.c: Use C++ exception handling.
3331         * guile/scm-param.c: Use C++ exception handling.
3332         * guile/scm-math.c: Use C++ exception handling.
3333         * guile/scm-lazy-string.c: Use C++ exception handling.
3334         * guile/scm-frame.c: Use C++ exception handling.
3335         * guile/scm-disasm.c: Use C++ exception handling.
3336         * guile/scm-cmd.c: Use C++ exception handling.
3337         * guile/scm-breakpoint.c: Use C++ exception handling.
3338         * guile/scm-block.c: Use C++ exception handling.
3339         * guile/guile-internal.h: Use C++ exception handling.
3340         * gnu-v3-abi.c: Use C++ exception handling.
3341         * gdbtypes.c: Use C++ exception handling.
3342         * frame.c: Use C++ exception handling.
3343         * frame-unwind.c: Use C++ exception handling.
3344         * fbsd-tdep.c: Use C++ exception handling.
3345         * f-valprint.c: Use C++ exception handling.
3346         * exec.c: Use C++ exception handling.
3347         * event-top.c: Use C++ exception handling.
3348         * event-loop.c: Use C++ exception handling.
3349         * eval.c: Use C++ exception handling.
3350         * dwarf2read.c: Use C++ exception handling.
3351         * dwarf2loc.c: Use C++ exception handling.
3352         * dwarf2-frame.c: Use C++ exception handling.
3353         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3354         * dwarf-index-write.c: Use C++ exception handling.
3355         * dwarf-index-cache.c: Use C++ exception handling.
3356         * dtrace-probe.c: Use C++ exception handling.
3357         * disasm-selftests.c: Use C++ exception handling.
3358         * darwin-nat.c: Use C++ exception handling.
3359         * cp-valprint.c: Use C++ exception handling.
3360         * cp-support.c: Use C++ exception handling.
3361         * cp-abi.c: Use C++ exception handling.
3362         * corelow.c: Use C++ exception handling.
3363         * completer.c: Use C++ exception handling.
3364         * compile/compile-object-run.c: Use C++ exception handling.
3365         * compile/compile-object-load.c: Use C++ exception handling.
3366         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3367         * compile/compile-c-symbols.c: Use C++ exception handling.
3368         * common/selftest.c: Use C++ exception handling.
3369         * common/new-op.c: Use C++ exception handling.
3370         * cli/cli-script.c: Use C++ exception handling.
3371         * cli/cli-interp.c: Use C++ exception handling.
3372         * cli/cli-cmds.c: Use C++ exception handling.
3373         * c-varobj.c: Use C++ exception handling.
3374         * btrace.c: Use C++ exception handling.
3375         * breakpoint.c: Use C++ exception handling.
3376         * break-catch-throw.c: Use C++ exception handling.
3377         * arch-utils.c: Use C++ exception handling.
3378         * amd64-tdep.c: Use C++ exception handling.
3379         * ada-valprint.c: Use C++ exception handling.
3380         * ada-typeprint.c: Use C++ exception handling.
3381         * ada-lang.c: Use C++ exception handling.
3382         * aarch64-tdep.c: Use C++ exception handling.
3383
3384 2019-04-08  Tom Tromey  <tom@tromey.com>
3385
3386         * xml-support.c (gdb_xml_parser::parse): Update.
3387         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3388         * value.c (show_convenience): Update.
3389         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3390         (test_parse_flags_qcs): Update.
3391         * thread.c (thr_try_catch_cmd): Update.
3392         * target.c (target_translate_tls_address): Update.
3393         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3394         (info_frame_command_core, frame_apply_command_count): Update.
3395         * rust-exp.y (rust_lex_exception_test): Update.
3396         * riscv-tdep.c (riscv_print_one_register_info): Update.
3397         * remote.c (remote_target::enable_btrace): Update.
3398         * record-btrace.c (record_btrace_enable_warn): Update.
3399         * python/py-utils.c (gdbpy_convert_exception): Update.
3400         * printcmd.c (do_one_display, print_variable_and_value): Update.
3401         * mi/mi-main.c (mi_print_exception): Update.
3402         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3403         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3404         * linux-nat.c (linux_nat_target::attach): Update.
3405         * linux-fork.c (class scoped_switch_fork_info): Update.
3406         * infrun.c (displaced_step_prepare): Update.
3407         * infcall.c (call_function_by_hand_dummy): Update.
3408         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3409         * gnu-v3-abi.c (print_one_vtable): Update.
3410         * frame.c (get_prev_frame_always): Update.
3411         * f-valprint.c (info_common_command_for_block): Update.
3412         * exec.c (try_open_exec_file): Update.
3413         * exceptions.c (print_exception, exception_print)
3414         (exception_fprintf, exception_print_same): Update.
3415         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3416         * dwarf-index-cache.c (index_cache::store)
3417         (index_cache::lookup_gdb_index): Update.
3418         * darwin-nat.c (maybe_cache_shell): Update.
3419         * cp-valprint.c (cp_print_value_fields): Update.
3420         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3421         (gcc_cplus_symbol_address): Update.
3422         * compile/compile-c-symbols.c (gcc_convert_symbol)
3423         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3424         * common/selftest.c: Update.
3425         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3426         a std::string.
3427         (exception_try_scope_entry, exception_try_scope_exit): Don't
3428         declare.
3429         (struct exception_try_scope): Remove.
3430         (TRY): Don't use exception_try_scope.
3431         (struct gdb_exception): Add constructor, operator=.
3432         <what>: New method.
3433         (struct gdb_exception_RETURN_MASK_ALL)
3434         (struct gdb_exception_RETURN_MASK_ERROR)
3435         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3436         (struct gdb_quit_bad_alloc): Update.
3437         * common/common-exceptions.c (exception_none): Change
3438         initializer.
3439         (struct catcher) <state, exception>: Initialize inline.
3440         <prev>: Remove member.
3441         (current_catcher): Remove.
3442         (catchers): New global.
3443         (exceptions_state_mc_init): Simplify.
3444         (catcher_pop): Remove.
3445         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3446         (try_scope_depth, exception_try_scope_entry)
3447         (exception_try_scope_exit): Remove.
3448         (throw_exception_sjlj): Update.
3449         (exception_messages, exception_messages_size): Remove.
3450         (throw_it): Simplify.
3451         (gdb_exception_sliced_copy): Remove.
3452         (throw_exception_cxx): Update.
3453         * cli/cli-script.c (script_from_file): Update.
3454         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3455         Update.
3456         * ada-valprint.c (ada_val_print): Update.
3457         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3458         (create_excep_cond_exprs): Update.
3459
3460 2019-04-08  Tom Tromey  <tom@tromey.com>
3461
3462         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3463         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3464         (TRY, CATCH, END_CATCH): Remove some definitions.
3465         * common/common-exceptions.c: Don't use GDB_XCPT.
3466         (catcher_list_size): Remove.
3467         (throw_exception, throw_it): Simplify.
3468
3469 2019-04-05  Tom Tromey  <tom@tromey.com>
3470
3471         Revert the header-sorting patch.
3472         * ft32-tdep.c: Revert.
3473         * frv-tdep.c: Revert.
3474         * frv-linux-tdep.c: Revert.
3475         * frame.c: Revert.
3476         * frame-unwind.c: Revert.
3477         * frame-base.c: Revert.
3478         * fork-child.c: Revert.
3479         * findvar.c: Revert.
3480         * findcmd.c: Revert.
3481         * filesystem.c: Revert.
3482         * filename-seen-cache.h: Revert.
3483         * filename-seen-cache.c: Revert.
3484         * fbsd-tdep.c: Revert.
3485         * fbsd-nat.h: Revert.
3486         * fbsd-nat.c: Revert.
3487         * f-valprint.c: Revert.
3488         * f-typeprint.c: Revert.
3489         * f-lang.c: Revert.
3490         * extension.h: Revert.
3491         * extension.c: Revert.
3492         * extension-priv.h: Revert.
3493         * expprint.c: Revert.
3494         * exec.h: Revert.
3495         * exec.c: Revert.
3496         * exceptions.c: Revert.
3497         * event-top.c: Revert.
3498         * event-loop.c: Revert.
3499         * eval.c: Revert.
3500         * elfread.c: Revert.
3501         * dwarf2read.h: Revert.
3502         * dwarf2read.c: Revert.
3503         * dwarf2loc.c: Revert.
3504         * dwarf2expr.h: Revert.
3505         * dwarf2expr.c: Revert.
3506         * dwarf2-frame.c: Revert.
3507         * dwarf2-frame-tailcall.c: Revert.
3508         * dwarf-index-write.h: Revert.
3509         * dwarf-index-write.c: Revert.
3510         * dwarf-index-common.c: Revert.
3511         * dwarf-index-cache.h: Revert.
3512         * dwarf-index-cache.c: Revert.
3513         * dummy-frame.c: Revert.
3514         * dtrace-probe.c: Revert.
3515         * disasm.h: Revert.
3516         * disasm.c: Revert.
3517         * disasm-selftests.c: Revert.
3518         * dictionary.c: Revert.
3519         * dicos-tdep.c: Revert.
3520         * demangle.c: Revert.
3521         * dcache.h: Revert.
3522         * dcache.c: Revert.
3523         * darwin-nat.h: Revert.
3524         * darwin-nat.c: Revert.
3525         * darwin-nat-info.c: Revert.
3526         * d-valprint.c: Revert.
3527         * d-namespace.c: Revert.
3528         * d-lang.c: Revert.
3529         * ctf.c: Revert.
3530         * csky-tdep.c: Revert.
3531         * csky-linux-tdep.c: Revert.
3532         * cris-tdep.c: Revert.
3533         * cris-linux-tdep.c: Revert.
3534         * cp-valprint.c: Revert.
3535         * cp-support.c: Revert.
3536         * cp-namespace.c: Revert.
3537         * cp-abi.c: Revert.
3538         * corelow.c: Revert.
3539         * corefile.c: Revert.
3540         * continuations.c: Revert.
3541         * completer.h: Revert.
3542         * completer.c: Revert.
3543         * complaints.c: Revert.
3544         * coffread.c: Revert.
3545         * coff-pe-read.c: Revert.
3546         * cli-out.h: Revert.
3547         * cli-out.c: Revert.
3548         * charset.c: Revert.
3549         * c-varobj.c: Revert.
3550         * c-valprint.c: Revert.
3551         * c-typeprint.c: Revert.
3552         * c-lang.c: Revert.
3553         * buildsym.c: Revert.
3554         * buildsym-legacy.c: Revert.
3555         * build-id.h: Revert.
3556         * build-id.c: Revert.
3557         * btrace.c: Revert.
3558         * bsd-uthread.c: Revert.
3559         * breakpoint.h: Revert.
3560         * breakpoint.c: Revert.
3561         * break-catch-throw.c: Revert.
3562         * break-catch-syscall.c: Revert.
3563         * break-catch-sig.c: Revert.
3564         * blockframe.c: Revert.
3565         * block.c: Revert.
3566         * bfin-tdep.c: Revert.
3567         * bfin-linux-tdep.c: Revert.
3568         * bfd-target.c: Revert.
3569         * bcache.c: Revert.
3570         * ax-general.c: Revert.
3571         * ax-gdb.h: Revert.
3572         * ax-gdb.c: Revert.
3573         * avr-tdep.c: Revert.
3574         * auxv.c: Revert.
3575         * auto-load.c: Revert.
3576         * arm-wince-tdep.c: Revert.
3577         * arm-tdep.c: Revert.
3578         * arm-symbian-tdep.c: Revert.
3579         * arm-pikeos-tdep.c: Revert.
3580         * arm-obsd-tdep.c: Revert.
3581         * arm-nbsd-tdep.c: Revert.
3582         * arm-nbsd-nat.c: Revert.
3583         * arm-linux-tdep.c: Revert.
3584         * arm-linux-nat.c: Revert.
3585         * arm-fbsd-tdep.c: Revert.
3586         * arm-fbsd-nat.c: Revert.
3587         * arm-bsd-tdep.c: Revert.
3588         * arch-utils.c: Revert.
3589         * arc-tdep.c: Revert.
3590         * arc-newlib-tdep.c: Revert.
3591         * annotate.h: Revert.
3592         * annotate.c: Revert.
3593         * amd64-windows-tdep.c: Revert.
3594         * amd64-windows-nat.c: Revert.
3595         * amd64-tdep.c: Revert.
3596         * amd64-sol2-tdep.c: Revert.
3597         * amd64-obsd-tdep.c: Revert.
3598         * amd64-obsd-nat.c: Revert.
3599         * amd64-nbsd-tdep.c: Revert.
3600         * amd64-nbsd-nat.c: Revert.
3601         * amd64-nat.c: Revert.
3602         * amd64-linux-tdep.c: Revert.
3603         * amd64-linux-nat.c: Revert.
3604         * amd64-fbsd-tdep.c: Revert.
3605         * amd64-fbsd-nat.c: Revert.
3606         * amd64-dicos-tdep.c: Revert.
3607         * amd64-darwin-tdep.c: Revert.
3608         * amd64-bsd-nat.c: Revert.
3609         * alpha-tdep.c: Revert.
3610         * alpha-obsd-tdep.c: Revert.
3611         * alpha-nbsd-tdep.c: Revert.
3612         * alpha-mdebug-tdep.c: Revert.
3613         * alpha-linux-tdep.c: Revert.
3614         * alpha-linux-nat.c: Revert.
3615         * alpha-bsd-tdep.c: Revert.
3616         * alpha-bsd-nat.c: Revert.
3617         * aix-thread.c: Revert.
3618         * agent.c: Revert.
3619         * addrmap.c: Revert.
3620         * ada-varobj.c: Revert.
3621         * ada-valprint.c: Revert.
3622         * ada-typeprint.c: Revert.
3623         * ada-tasks.c: Revert.
3624         * ada-lang.c: Revert.
3625         * aarch64-tdep.c: Revert.
3626         * aarch64-ravenscar-thread.c: Revert.
3627         * aarch64-newlib-tdep.c: Revert.
3628         * aarch64-linux-tdep.c: Revert.
3629         * aarch64-linux-nat.c: Revert.
3630         * aarch64-fbsd-tdep.c: Revert.
3631         * aarch64-fbsd-nat.c: Revert.
3632         * aarch32-linux-nat.c: Revert.
3633
3634 2019-04-05  Tom Tromey  <tom@tromey.com>
3635
3636         * ft32-tdep.c: Sort headers.
3637         * frv-tdep.c: Sort headers.
3638         * frv-linux-tdep.c: Sort headers.
3639         * frame.c: Sort headers.
3640         * frame-unwind.c: Sort headers.
3641         * frame-base.c: Sort headers.
3642         * fork-child.c: Sort headers.
3643         * findvar.c: Sort headers.
3644         * findcmd.c: Sort headers.
3645         * filesystem.c: Sort headers.
3646         * filename-seen-cache.h: Sort headers.
3647         * filename-seen-cache.c: Sort headers.
3648         * fbsd-tdep.c: Sort headers.
3649         * fbsd-nat.h: Sort headers.
3650         * fbsd-nat.c: Sort headers.
3651         * f-valprint.c: Sort headers.
3652         * f-typeprint.c: Sort headers.
3653         * f-lang.c: Sort headers.
3654         * extension.h: Sort headers.
3655         * extension.c: Sort headers.
3656         * extension-priv.h: Sort headers.
3657         * expprint.c: Sort headers.
3658         * exec.h: Sort headers.
3659         * exec.c: Sort headers.
3660         * exceptions.c: Sort headers.
3661         * event-top.c: Sort headers.
3662         * event-loop.c: Sort headers.
3663         * eval.c: Sort headers.
3664         * elfread.c: Sort headers.
3665         * dwarf2read.h: Sort headers.
3666         * dwarf2read.c: Sort headers.
3667         * dwarf2loc.c: Sort headers.
3668         * dwarf2expr.h: Sort headers.
3669         * dwarf2expr.c: Sort headers.
3670         * dwarf2-frame.c: Sort headers.
3671         * dwarf2-frame-tailcall.c: Sort headers.
3672         * dwarf-index-write.h: Sort headers.
3673         * dwarf-index-write.c: Sort headers.
3674         * dwarf-index-common.c: Sort headers.
3675         * dwarf-index-cache.h: Sort headers.
3676         * dwarf-index-cache.c: Sort headers.
3677         * dummy-frame.c: Sort headers.
3678         * dtrace-probe.c: Sort headers.
3679         * disasm.h: Sort headers.
3680         * disasm.c: Sort headers.
3681         * disasm-selftests.c: Sort headers.
3682         * dictionary.c: Sort headers.
3683         * dicos-tdep.c: Sort headers.
3684         * demangle.c: Sort headers.
3685         * dcache.h: Sort headers.
3686         * dcache.c: Sort headers.
3687         * darwin-nat.h: Sort headers.
3688         * darwin-nat.c: Sort headers.
3689         * darwin-nat-info.c: Sort headers.
3690         * d-valprint.c: Sort headers.
3691         * d-namespace.c: Sort headers.
3692         * d-lang.c: Sort headers.
3693         * ctf.c: Sort headers.
3694         * csky-tdep.c: Sort headers.
3695         * csky-linux-tdep.c: Sort headers.
3696         * cris-tdep.c: Sort headers.
3697         * cris-linux-tdep.c: Sort headers.
3698         * cp-valprint.c: Sort headers.
3699         * cp-support.c: Sort headers.
3700         * cp-namespace.c: Sort headers.
3701         * cp-abi.c: Sort headers.
3702         * corelow.c: Sort headers.
3703         * corefile.c: Sort headers.
3704         * continuations.c: Sort headers.
3705         * completer.h: Sort headers.
3706         * completer.c: Sort headers.
3707         * complaints.c: Sort headers.
3708         * coffread.c: Sort headers.
3709         * coff-pe-read.c: Sort headers.
3710         * cli-out.h: Sort headers.
3711         * cli-out.c: Sort headers.
3712         * charset.c: Sort headers.
3713         * c-varobj.c: Sort headers.
3714         * c-valprint.c: Sort headers.
3715         * c-typeprint.c: Sort headers.
3716         * c-lang.c: Sort headers.
3717         * buildsym.c: Sort headers.
3718         * buildsym-legacy.c: Sort headers.
3719         * build-id.h: Sort headers.
3720         * build-id.c: Sort headers.
3721         * btrace.c: Sort headers.
3722         * bsd-uthread.c: Sort headers.
3723         * breakpoint.h: Sort headers.
3724         * breakpoint.c: Sort headers.
3725         * break-catch-throw.c: Sort headers.
3726         * break-catch-syscall.c: Sort headers.
3727         * break-catch-sig.c: Sort headers.
3728         * blockframe.c: Sort headers.
3729         * block.c: Sort headers.
3730         * bfin-tdep.c: Sort headers.
3731         * bfin-linux-tdep.c: Sort headers.
3732         * bfd-target.c: Sort headers.
3733         * bcache.c: Sort headers.
3734         * ax-general.c: Sort headers.
3735         * ax-gdb.h: Sort headers.
3736         * ax-gdb.c: Sort headers.
3737         * avr-tdep.c: Sort headers.
3738         * auxv.c: Sort headers.
3739         * auto-load.c: Sort headers.
3740         * arm-wince-tdep.c: Sort headers.
3741         * arm-tdep.c: Sort headers.
3742         * arm-symbian-tdep.c: Sort headers.
3743         * arm-pikeos-tdep.c: Sort headers.
3744         * arm-obsd-tdep.c: Sort headers.
3745         * arm-nbsd-tdep.c: Sort headers.
3746         * arm-nbsd-nat.c: Sort headers.
3747         * arm-linux-tdep.c: Sort headers.
3748         * arm-linux-nat.c: Sort headers.
3749         * arm-fbsd-tdep.c: Sort headers.
3750         * arm-fbsd-nat.c: Sort headers.
3751         * arm-bsd-tdep.c: Sort headers.
3752         * arch-utils.c: Sort headers.
3753         * arc-tdep.c: Sort headers.
3754         * arc-newlib-tdep.c: Sort headers.
3755         * annotate.h: Sort headers.
3756         * annotate.c: Sort headers.
3757         * amd64-windows-tdep.c: Sort headers.
3758         * amd64-windows-nat.c: Sort headers.
3759         * amd64-tdep.c: Sort headers.
3760         * amd64-sol2-tdep.c: Sort headers.
3761         * amd64-obsd-tdep.c: Sort headers.
3762         * amd64-obsd-nat.c: Sort headers.
3763         * amd64-nbsd-tdep.c: Sort headers.
3764         * amd64-nbsd-nat.c: Sort headers.
3765         * amd64-nat.c: Sort headers.
3766         * amd64-linux-tdep.c: Sort headers.
3767         * amd64-linux-nat.c: Sort headers.
3768         * amd64-fbsd-tdep.c: Sort headers.
3769         * amd64-fbsd-nat.c: Sort headers.
3770         * amd64-dicos-tdep.c: Sort headers.
3771         * amd64-darwin-tdep.c: Sort headers.
3772         * amd64-bsd-nat.c: Sort headers.
3773         * alpha-tdep.c: Sort headers.
3774         * alpha-obsd-tdep.c: Sort headers.
3775         * alpha-nbsd-tdep.c: Sort headers.
3776         * alpha-mdebug-tdep.c: Sort headers.
3777         * alpha-linux-tdep.c: Sort headers.
3778         * alpha-linux-nat.c: Sort headers.
3779         * alpha-bsd-tdep.c: Sort headers.
3780         * alpha-bsd-nat.c: Sort headers.
3781         * aix-thread.c: Sort headers.
3782         * agent.c: Sort headers.
3783         * addrmap.c: Sort headers.
3784         * ada-varobj.c: Sort headers.
3785         * ada-valprint.c: Sort headers.
3786         * ada-typeprint.c: Sort headers.
3787         * ada-tasks.c: Sort headers.
3788         * ada-lang.c: Sort headers.
3789         * aarch64-tdep.c: Sort headers.
3790         * aarch64-ravenscar-thread.c: Sort headers.
3791         * aarch64-newlib-tdep.c: Sort headers.
3792         * aarch64-linux-tdep.c: Sort headers.
3793         * aarch64-linux-nat.c: Sort headers.
3794         * aarch64-fbsd-tdep.c: Sort headers.
3795         * aarch64-fbsd-nat.c: Sort headers.
3796         * aarch32-linux-nat.c: Sort headers.
3797
3798 2019-04-04  Tom Tromey  <tom@tromey.com>
3799
3800         * varobj.c (varobj_create): Update.
3801         * rust-exp.y (struct rust_parser) <update_innermost_block,
3802         lookup_symbol>: New methods.
3803         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3804         Rename.
3805         (rust_parser::rust_lookup_type)
3806         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3807         * printcmd.c (display_command, do_one_display): Update.
3808         * parser-defs.h (struct parser_state) <parser_state>: Add
3809         "tracker" parameter.
3810         (block_tracker): New member.
3811         (class innermost_block_tracker) <innermost_block_tracker>: Add
3812         "types" parameter.
3813         <reset>: Remove method.
3814         (innermost_block): Don't declare.
3815         (null_post_parser): Update.
3816         * parse.c (innermost_block): Remove global.
3817         (write_dollar_variable): Update.
3818         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3819         Remove "tracker_types" parameter.
3820         (parse_expression): Add "tracker" parameter.
3821         (parse_expression_for_completion): Update.
3822         (null_post_parser): Add "tracker" parameter.
3823         * p-exp.y: Update rules.
3824         * m2-exp.y: Update rules.
3825         * language.h (struct language_defn) <la_post_parser>: Add
3826         "tracker" parameter.
3827         * go-exp.y: Update rules.
3828         * f-exp.y: Update rules.
3829         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3830         parameter.
3831         * d-exp.y: Update rules.
3832         * c-exp.y: Update rules.
3833         * breakpoint.c (set_breakpoint_condition): Create an
3834         innermost_block_tracker.
3835         (watch_command_1): Likewise.
3836         * ada-lang.c (resolve): Add "tracker" parameter.
3837         (resolve_subexp): Likewise.
3838         * ada-exp.y (write_var_from_sym): Update.
3839
3840 2019-04-04  Tom Tromey  <tom@tromey.com>
3841
3842         * type-stack.h: New file.
3843         * type-stack.c: New file.
3844         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3845         type-stack.h.
3846         (insert_into_type_stack, insert_type, push_type, push_type_int)
3847         (insert_type_address_space, pop_type, pop_type_int)
3848         (pop_typelist, pop_type_stack, append_type_stack)
3849         (push_type_stack, get_type_stack, push_typelist)
3850         (follow_type_instance_flags, follow_types): Don't declare.
3851         * parse.c (type_stack): Remove global.
3852         (parse_exp_in_context): Update.
3853         (insert_into_type_stack, insert_type, push_type, push_type_int)
3854         (insert_type_address_space, pop_type, pop_type_int)
3855         (pop_typelist, pop_type_stack, append_type_stack)
3856         (push_type_stack, get_type_stack, push_typelist)
3857         (follow_type_instance_flags, follow_types): Remove (moved to
3858         type-stack.c).
3859         * f-exp.y (type_stack): New global.
3860         Update rules.
3861         (push_kind_type, f_parse): Update.
3862         * d-exp.y (type_stack): New global.
3863         Update rules.
3864         (d_parse): Update.
3865         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3866         Update rules.
3867         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3868         (HFILES_NO_SRCDIR): Add type-stack.h.
3869
3870 2019-04-04  Tom Tromey  <tom@tromey.com>
3871
3872         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3873         (rust_parser::convert_ast_to_expression, rust_parse)
3874         (rust_lex_test_completion, rust_lex_tests): Update.
3875         * parser-defs.h (struct expr_completion_state): New.
3876         (struct parser_state) <parser_state>: Add completion parameter.
3877         <mark_struct_expression, mark_completion_tag>: New methods.
3878         <parse_completion, m_completion_state>: New members.
3879         (prefixify_expression, null_post_parser): Update.
3880         (mark_struct_expression, mark_completion_tag): Don't declare.
3881         * parse.c (parse_completion, expout_last_struct)
3882         (expout_tag_completion_type, expout_completion_name): Remove
3883         globals.
3884         (parser_state::mark_struct_expression)
3885         (parser_state::mark_completion_tag): Now methods.
3886         (prefixify_expression): Add last_struct parameter.
3887         (prefixify_subexp): Likewise.
3888         (parse_exp_1): Update.
3889         (parse_exp_in_context): Add cstate parameter.  Update.
3890         (parse_expression_for_completion): Create an
3891         expr_completion_state.
3892         (null_post_parser): Add "completion" parameter.
3893         * p-exp.y: Update rules.
3894         (yylex): Update.
3895         * language.h (struct language_defn) <la_post_parser>: Add
3896         "completing" parameter.
3897         * go-exp.y: Update rules.
3898         (lex_one_token): Update.
3899         * expression.h (parse_completion): Don't declare.
3900         * d-exp.y: Update rules.
3901         (lex_one_token): Update rules.
3902         * c-exp.y: Update rules.
3903         (lex_one_token): Update.
3904         * ada-lang.c (resolve): Add "parse_completion" parameter.
3905         (resolve_subexp): Likewise.
3906         (ada_resolve_function): Likewise.
3907
3908 2019-04-04  Tom Tromey  <tom@tromey.com>
3909
3910         * parser-defs.h (struct parser_state) <start_arglist,
3911         end_arglist>: New methods.
3912         <arglist_len, m_funcall_chain>: New members.
3913         (arglist_len, start_arglist, end_arglist): Don't declare.
3914         * parse.c (arglist_len, funcall_chain): Remove global.
3915         (start_arglist, end_arglist): Remove functions.
3916         (parse_exp_in_context): Update.
3917         * p-exp.y: Update rules.
3918         * m2-exp.y: Update rules.
3919         * go-exp.y: Update rules.
3920         * f-exp.y: Update rules.
3921         * d-exp.y: Update rules.
3922         * c-exp.y: Update rules.
3923
3924 2019-04-04  Tom Tromey  <tom@tromey.com>
3925
3926         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3927         lex_operator, push_back>: New methods.
3928         Update all rules.
3929         (rust_parser::lex_hex, lex_escape): Rename and update.
3930         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3931         (rust_parser::lex_operator): Rename and update.
3932         (rust_parser::lex_number, rustyylex, rustyyerror)
3933         (rust_lex_test_init, rust_lex_test_sequence)
3934         (rust_lex_test_push_back, rust_lex_tests): Update.
3935         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3936         parameter.
3937         <lexptr, prev_lexptr>: New members.
3938         (lexptr, prev_lexptr): Don't declare.
3939         * parse.c (lexptr, prev_lexptr): Remove globals.
3940         (parse_exp_in_context): Update.
3941         * p-exp.y (yylex, yyerror): Update.
3942         * m2-exp.y (parse_number, yylex, yyerror): Update.
3943         * go-exp.y (lex_one_token, yyerror): Update.
3944         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3945         * d-exp.y (lex_one_token, yyerror): Update.
3946         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3947         (lex_one_token, yyerror): Update.
3948         * ada-lex.l (YY_INPUT): Update.
3949         (rewind_to_char): Update.
3950         * ada-exp.y (yyerror): Update.
3951
3952 2019-04-04  Tom Tromey  <tom@tromey.com>
3953
3954         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3955         * parser-defs.h (struct parser_state) <parser_state>: Add new
3956         parameter.
3957         <comma_terminates>: New member.
3958         (comma_terminates): Don't declare global.
3959         * parse.c (comma_terminates): Remove global.
3960         (parse_exp_in_context): Update.
3961         * p-exp.y (yylex): Update.
3962         * m2-exp.y (yylex): Update.
3963         * go-exp.y (lex_one_token): Update.
3964         * f-exp.y (yylex): Update.
3965         * d-exp.y (lex_one_token): Update.
3966         * c-exp.y (lex_one_token): Update.
3967         * ada-lex.l: Update.
3968
3969 2019-04-04  Tom Tromey  <tom@tromey.com>
3970
3971         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3972         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3973         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3974         * parser-defs.h (paren_depth): Don't declare.
3975         * parse.c (paren_depth): Remove global.
3976         (parse_exp_in_context): Update.
3977         * p-exp.y (paren_depth): New global.
3978         (pascal_parse): Initialize it.
3979         * m2-exp.y (paren_depth): New global.
3980         (m2_parse): Initialize it.
3981         * go-exp.y (paren_depth): New global.
3982         (go_parse): Initialize it.
3983         * f-exp.y (paren_depth): New global.
3984         (f_parse): Initialize it.
3985         * d-exp.y (paren_depth): New global.
3986         (d_parse): Initialize it.
3987         * c-exp.y (paren_depth): New global.
3988         (c_parse): Initialize it.
3989         * ada-lex.l (paren_depth): New global.
3990         (lexer_init): Initialize it.
3991
3992 2019-04-04  Tom Tromey  <tom@tromey.com>
3993
3994         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3995         (rust_parser::convert_ast_to_type)
3996         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3997         * parser-defs.h (struct parser_state) <parser_state>: Add
3998         parameters.  Initialize new members.
3999         <expression_context_block, expression_context_pc>: New members.
4000         * parse.c (expression_context_block, expression_context_pc):
4001         Remove globals.
4002         (parse_exp_in_context): Update.
4003         * p-exp.y: Update all rules.
4004         (yylex): Update.
4005         * m2-exp.y: Update all rules.
4006         (yylex): Update.
4007         * go-exp.y (yylex): Update.
4008         * f-exp.y (yylex): Update.
4009         * d-exp.y: Update all rules.
4010         (yylex): Update.
4011         * c-exp.y: Update all rules.
4012         (lex_one_token, classify_name, yylex, c_parse): Update.
4013         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4014
4015 2019-04-04  Tom Tromey  <tom@tromey.com>
4016
4017         * gdbarch.h, gdbarch.c: Rebuild.
4018         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4019         * stap-probe.h:
4020         (struct stap_parse_info): Replace "parser_state" with
4021         "expr_builder".
4022         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4023         (parser_state): New class.
4024         * parse.c (expr_builder): Rename.
4025         (expr_builder::release): Rename.
4026         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4027         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4028         (write_exp_elt_longcst, write_exp_elt_floatcst)
4029         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4030         (write_exp_string_vector, write_exp_bitstring)
4031         (write_exp_msymbol, mark_struct_expression)
4032         (write_dollar_variable)
4033         (insert_type_address_space, increase_expout_size): Replace
4034         "parser_state" with "expr_builder".
4035         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4036         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4037         "parser_state" with "expr_builder".
4038
4039 2019-04-04  Tom Tromey  <tom@tromey.com>
4040
4041         * rust-exp.y: Replace "parse_language" with method call.
4042         * p-exp.y:
4043         (yylex): Replace "parse_language" with method call.
4044         * m2-exp.y:
4045         (yylex): Replace "parse_language" with method call.
4046         * go-exp.y (classify_name): Replace "parse_language" with method
4047         call.
4048         * f-exp.y (yylex): Replace "parse_language" with method call.
4049         * d-exp.y (lex_one_token): Replace "parse_language" with method
4050         call.
4051         * c-exp.y:
4052         (lex_one_token, classify_name, yylex): Replace "parse_language"
4053         with method call.
4054         * ada-exp.y (find_primitive_type, type_char)
4055         (type_system_address): Replace "parse_language" with method call.
4056
4057 2019-04-04  Tom Tromey  <tom@tromey.com>
4058
4059         * rust-exp.y: Replace "parse_gdbarch" with method call.
4060         * parse.c (write_dollar_variable, insert_type_address_space):
4061         Replace "parse_gdbarch" with method call.
4062         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4063         call.
4064         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4065         call.
4066         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4067         "parse_gdbarch" with method call.
4068         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4069         with method call.
4070         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4071         "parse_gdbarch" with method call.
4072         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4073         "parse_gdbarch" with method call.
4074         * c-exp.y (parse_type, parse_number, classify_name): Replace
4075         "parse_gdbarch" with method call.
4076         * ada-lex.l: Replace "parse_gdbarch" with method call.
4077         * ada-exp.y (parse_type, find_primitive_type, type_char)
4078         (type_system_address): Replace "parse_gdbarch" with method call.
4079
4080 2019-04-04  Tom Tromey  <tom@tromey.com>
4081
4082         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4083         * stap-probe.c (stap_parse_argument): Update.
4084         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4085         initial_size parameter.
4086         * rust-exp.y (rust_lex_tests): Update.
4087         * parse.c (parser_state): Update.
4088         (parse_exp_in_context): Update.
4089         * parser-defs.h (struct parser_state) <parser_state>: Remove
4090         "initial_size" parameter.
4091
4092 2019-04-04  Tom Tromey  <tom@tromey.com>
4093
4094         * parser-defs.h (increase_expout_size): Don't declare.
4095         * parse.c (increase_expout_size): Now static.
4096
4097 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4098
4099         * gnu-nat.c (gnu_nat_target::wait): Fix
4100         target_waitstatus_to_string call.
4101
4102 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4103
4104         * eval.c (evaluate_subexp_standard): Handle internal functions
4105         during Fortran function call handling.
4106
4107 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4108
4109         * NEWS: Mention new internal functions.
4110         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4111         (read_base_type): Use dwarf2_init_complex_target_type.
4112         * value.c (creal_internal_fn): New function.
4113         (cimag_internal_fn): New function.
4114         (_initialize_values): Register new internal functions.
4115
4116 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4117
4118         * infrun.c (stop_all_threads): If debug_infrun, always
4119         trace the wait status after wait_one, using
4120         target_waitstatus_to_string and target_pid_to_str.
4121         (handle_inferior_event): Replace various trace of
4122         wait status kind by a single trace.
4123         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4124         wait status kind image by target_waitstatus_to_string.
4125         * target/waitstatus.c (target_waitstatus_to_string): Fix
4126         obsolete comment.
4127
4128 2019-04-01  Tom Tromey  <tromey@adacore.com>
4129
4130         PR symtab/23331:
4131         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4132
4133 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4134             Pedro Alves  <palves@redhat.com>
4135
4136         * top.c (quit_force): Call 'finalize_values'.
4137         * value.c (finalize_values): New function.
4138         * value.h (finalize_values): Declare.
4139
4140 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4141
4142         * NEWS: Announce $_gdb_major and $_gdb_minor.
4143
4144         * top.c (init_gdb_version_vars): New function.
4145         (gdb_init): Call init_gdb_version_vars.
4146
4147 2019-03-29  Tom Tromey  <tromey@adacore.com>
4148
4149         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4150         help text.  Remove dead code.
4151
4152 2019-03-29  Keith Seitz  <keiths@redhat.com>
4153
4154         From Siddhesh Poyarekar:
4155         * f-lang.h (f77_get_upperbound): Return LONGEST.
4156         (f77_get_lowerbound): Likewise.
4157         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4158         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4159         print them.
4160         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4161         plongest to format print it.
4162         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4163         (f77_get_upperbound): Likewise.
4164         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4165         LOWER_BOUND to LONGEST.
4166         (f77_create_arrayprint_offset_tbl): Likewise.
4167
4168 2019-03-29  Keith Seitz  <keiths@redhat.com>
4169
4170         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4171         %s/pulongest for TYPE_LENGTH instead of %d in format
4172         strings.
4173         * ada-typerint.c (ada_print_type): Likewise.
4174         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4175         * compile/compile-c-support.c (generate_register_struct): Likewise.
4176         * gdbtypes.c (recursive_dump_type): Likewise.
4177         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4178         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4179         instead of %d in format strings.
4180         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4181         to std::min to ULONGEST.
4182         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4183         instead of %d in format strings.
4184         * tracepoint.c (info_scope_command): Likewise.
4185         * typeprint.c (print_offset_data::update)
4186         (print_offset_data::finish): Likewise.
4187         * xtensa-tdep.c (xtensa_store_return_value)
4188         (xtensa_push_dummy_call): Likewise.
4189
4190 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4191
4192         * windows-nat.c (display_selector): Fixed format specifications
4193         for 64-bit Cygwin.
4194
4195 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4196
4197         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4198
4199 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4200
4201         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4202         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4203         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4204         (nios2_linux_init_abi): Install it.
4205
4206 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4207
4208         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4209
4210 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4211
4212         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4213
4214 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4215             Tom Tromey  <tromey@adacore.com>
4216
4217         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4218
4219 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4220
4221         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4222         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4223         method to compute the bounds of range types. Also print "[evaluated]"
4224         if the bounds' values come from a dynamic evaluation.
4225
4226 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4227
4228         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4229         whitespace when pretty printing is on.
4230
4231 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4232
4233         * ppc-linux-nat.c: Add include.
4234
4235 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4236
4237         * NEWS: Mention AArch64 Pointer Authentication.
4238
4239 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4240
4241         * arm-linux-nat.c: Add include.
4242
4243 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4244
4245         * source-cache.c (source_cache::get_source_lines): Re-read
4246         fullname after calling open_source_file.
4247
4248 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4249
4250         * NEWS: Mention TLS support for FreeBSD.
4251
4252 2019-03-25  Tom Tromey  <tromey@adacore.com>
4253
4254         * minsyms.c (BUNCH_SIZE): Update comment.
4255         (~minimal_symbol_reader): Remove old comment.
4256         (compact_minimal_symbols): Update comment.
4257         (minimal_symbol_reader::install): Remove old comment.  Update
4258         other comments.
4259
4260 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4261
4262         * s390-linux-nat.c: Add include.
4263
4264 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4265
4266         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4267         Call linux_get_hwcap.
4268         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4269         Likewise.
4270         (aarch64_linux_get_hwcap): Remove function.
4271         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4272         declaration.
4273         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4274         linux_get_hwcap.
4275         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4276         * linux-tdep.c (linux_get_hwcap): Add function.
4277         (linux_get_hwcap2): Likewise.
4278         * linux-tdep.h (linux_get_hwcap): Add declaration.
4279         (linux_get_hwcap2): Likewise.
4280         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4281         (ppc_linux_get_hwcap2): Likewise.
4282         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4283         linux_get_hwcap.
4284         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4285         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4286         (ppc_linux_nat_target::read_description): Likewise.
4287         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4288         * s390-linux-nat.c: Likewise.
4289         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4290
4291 2019-03-24  Tom Tromey  <tom@tromey.com>
4292
4293         * ada-lang.c (standard_lookup): Simplify initialization.
4294         (ada_lookup_symbol_nonlocal): Simplify return.
4295         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4296         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4297         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4298         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4299         initialization.
4300         * solib.c (solib_global_lookup): Simplify.
4301         * symtab.c (null_block_symbol): Remove.
4302         (symbol_cache_lookup): Simplify returns.
4303         (lookup_language_this): Simplify returns.
4304         (lookup_symbol_aux): Simplify return.
4305         (lookup_local_symbol): Simplify returns.
4306         (lookup_global_symbol_from_objfile): Simplify return.
4307         (lookup_symbol_in_objfile_symtabs)
4308         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4309         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4310         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4311         * cp-namespace.c (cp_lookup_bare_symbol)
4312         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4313         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4314         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4315         (cp_lookup_symbol_via_imports): Simplify initialization.
4316         (find_symbol_in_baseclass): Likewise.
4317         * symtab.h (null_block_symbol): Remove.
4318         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4319         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4320         (d_lookup_symbol_module): Likewise.
4321         (find_symbol_in_baseclass): Simplify initialization.
4322
4323 2019-03-24  Tom Tromey  <tom@tromey.com>
4324
4325         * expression.h: Don't include symtab.h.
4326         (struct block): Forward declare.
4327
4328 2019-03-24  Tom Tromey  <tom@tromey.com>
4329
4330         * c-exp.y (typebase): Remove casts.
4331         * gdbtypes.c (lookup_unsigned_typename, )
4332         (lookup_signed_typename): Remove cast.
4333         * eval.c (parse_to_comma_and_eval): Remove cast.
4334         * parse.c (write_dollar_variable): Remove cast.
4335         * block.h (struct block) <superblock>: Now const.
4336         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4337         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4338         (map_block): Make "block" const.
4339         * symfile.h (struct quick_symbol_functions)
4340         <map_matching_symbols>: Constify block argument to "callback".
4341         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4342         const.
4343         (find_pc_sect_compunit_symtab): Make "b" const.
4344         (find_symbol_at_address): Likewise.
4345         (search_symbols): Likewise.
4346         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4347         (dw2_debug_names_lookup_symbol): Likewise.
4348         (dw2_map_matching_symbols): Update.
4349         * p-valprint.c (pascal_val_print): Remove "block".
4350         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4351         (aux_add_nonlocal_symbols): Make "block" const.
4352         (resolve_subexp): Remove cast.
4353         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4354         const.
4355         (iterate_over_file_blocks): Likewise.
4356         * f-exp.y (%union) <bval>: Remove.
4357         * coffread.c (patch_opaque_types): Make "b" const.
4358         * spu-tdep.c (spu_catch_start): Make "block" const.
4359         * c-valprint.c (print_unpacked_pointer): Remove "block".
4360         * symmisc.c (dump_symtab_1): Make "b" const.
4361         (block_depth): Make "block" const.
4362         * d-exp.y (%union) <bval>: Remove.
4363         * cp-support.h (cp_lookup_rtti_type): Update.
4364         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4365         * psymtab.c (psym_lookup_symbol): Make "block" const.
4366         (maintenance_check_psymtabs): Make "b" const.
4367         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4368         (enumerate_locals, enumerate_args): Update.
4369         * python/py-symtab.c (stpy_global_block): Make "block" const.
4370         (stpy_static_block): Likewise.
4371         * inline-frame.c (block_starting_point_at): Make "new_block"
4372         const.
4373         * block.c (find_block_in_blockvector): Make return type const.
4374         (blockvector_for_pc_sect): Make "b" const.
4375         (find_block_in_blockvector): Make "b" const.
4376
4377 2019-03-23  Tom Tromey  <tom@tromey.com>
4378
4379         * varobj.c (varobj_create): Update.
4380         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4381         * printcmd.c (display_command, do_one_display): Don't reset
4382         innermost_block.
4383         * parser-defs.h (enum innermost_block_tracker_type): Move to
4384         expression.h.
4385         (innermost_block): Update comment.
4386         * parse.c (parse_exp_1): Add tracker_types parameter.
4387         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4388         tracker_types parameter.  Reset innermost_block.
4389         (parse_exp_in_context): Remove.
4390         (parse_expression_for_completion): Update.
4391         * objfiles.c (~objfile): Don't reset expression_context_block or
4392         innermost_block.
4393         * expression.h (enum innermost_block_tracker_type): Move from
4394         parser-defs.h.
4395         (parse_exp_1): Add tracker_types parameter.
4396         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4397         reset innermost_block.
4398
4399 2019-03-23  Tom Tromey  <tom@tromey.com>
4400
4401         * objfiles.h: Include bcache.h.
4402
4403 2019-03-23  Tom Tromey  <tom@tromey.com>
4404
4405         * linespec.c (get_current_search_block): Use
4406         scoped_restore_current_language.
4407         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4408
4409 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4410             Jiong Wang  <jiong.wang@arm.com>
4411
4412         * aarch64-linux-tdep.c
4413         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4414         section.
4415         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4416
4417 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4418             Jiong Wang  <jiong.wang@arm.com>
4419
4420         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4421         instructions.
4422         (aarch64_analyze_prologue_test): Add PACIASP test.
4423         (aarch64_prologue_prev_register): Unmask PC value.
4424
4425 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4426             Jiong Wang  <jiong.wang@arm.com>
4427
4428         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4429         (aarch64_dwarf2_prev_register): Unmask PC value.
4430         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4431         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4432         DW_CFA_AARCH64_negate_ra_state.
4433         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4434
4435 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4436             Jiong Wang  <jiong.wang@arm.com>
4437
4438         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4439         registers.
4440         (aarch64_pseudo_register_name): Likewise.
4441         (aarch64_pseudo_register_type): Likewise.
4442         (aarch64_pseudo_register_reggroup_p): Likewise.
4443         (aarch64_gdbarch_init): Add pauth registers.
4444         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4445         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4446         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4447         (struct gdbarch_tdep): Add regnum for ra_state.
4448
4449 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4450             Jiong Wang  <jiong.wang@arm.com>
4451
4452         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4453
4454 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4455             Jiong Wang  <jiong.wang@arm.com>
4456
4457         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4458         function.
4459         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4460         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4461         (aarch64_gdbarch_init): Add puth registers.
4462         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4463         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4464         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4465
4466 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4467             Jiong Wang  <jiong.wang@arm.com>
4468
4469         * aarch64-linux-nat.c
4470         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4471         * aarch64-linux-tdep.c
4472         (aarch64_linux_core_read_description): Likewise.
4473         (aarch64_linux_get_hwcap): New function.
4474         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4475         (aarch64_linux_get_hwcap): New declaration.
4476
4477 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4478             Jiong Wang  <jiong.wang@arm.com>
4479
4480         * aarch64-linux-nat.c
4481         (aarch64_linux_nat_target::read_description): Add pauth param.
4482         * aarch64-linux-tdep.c
4483         (aarch64_linux_core_read_description): Likewise.
4484         * aarch64-tdep.c (struct target_desc): Add in pauth.
4485         (aarch64_read_description): Add pauth param.
4486         (aarch64_gdbarch_init): Likewise.
4487         * aarch64-tdep.h (aarch64_read_description): Likewise.
4488         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4489         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4490         * features/Makefile: Add new files.
4491         * features/aarch64-pauth.c: New file.
4492         * features/aarch64-pauth.xml: New file.
4493
4494 2019-03-20  Tom Tromey  <tromey@adacore.com>
4495
4496         * infrun.c (handle_inferior_event): Rename from
4497         handle_inferior_event_1.  Create a scoped_value_mark.
4498         (handle_inferior_event): Remove.
4499
4500 2019-03-19  Tom Tromey  <tromey@adacore.com>
4501
4502         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4503         * infrun.h (print_stop_event): Add "displays" parameter.
4504         * infrun.c (print_stop_event): Add "displays" parameter.
4505
4506 2019-03-19  Pedro Alves  <palves@redhat.com>
4507
4508         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4509         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4510         to -1.  Fix TABs vs spaces.
4511         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4512         * tui/tui-out.h (tui_ui_out) Add intro comments.
4513         <m_line, m_start_of_line>: In-class initialize, and add describing
4514         comment.
4515
4516 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4517
4518         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4519         variable names.
4520         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4521
4522 2019-03-18  Pedro Alves  <palves@redhat.com>
4523             Eli Zaretskii <eliz@gnu.org>
4524
4525         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4526         m_line and m_start_of_line.
4527
4528 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4529
4530         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4531         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4532         it returns a newline.  This fixes a regression in TU mode, whereby
4533         the next line is output on the same screen line as the user input.
4534
4535 2019-03-18  Tom Tromey  <tromey@adacore.com>
4536
4537         * minsyms.c (minimal_symbol_reader::install): Remove call to
4538         obstack_blank.
4539
4540 2019-03-18  Pedro Alves  <palves@redhat.com>
4541
4542         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4543         New globals.
4544         (apply_style): New, factored out from ...
4545         (apply_ansi_escape): ... this.  Handle reverse video mode.
4546         (tui_set_reverse_mode): New function.
4547         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4548         * tui/tui-winsource.c (tui_show_source_line): Use
4549         tui_set_reverse_mode instead of setting A_STANDOUT.
4550         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4551         New setter methods.
4552
4553 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4554
4555         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4556         Handle tabs.
4557
4558 2019-03-18  Tom Tromey  <tromey@adacore.com>
4559
4560         * ada-lang.c (empty_array): Add "high" parameter.
4561         (ada_evaluate_subexp): Update.
4562
4563 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4564
4565         * unittests/string_view-selftests.c: Define
4566         _initialize_string_view_selftests unconditionally.
4567
4568 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4569
4570         PR gdb/24350
4571         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4572
4573 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4574
4575         PR gdb/24351
4576         * windows-nat.c (display_selector): Fix format specifiers.
4577
4578 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4579
4580         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4581         tui_refill_source_window instead of tui_refresh_win, to update the
4582         current execution line.  This fixes redisplay of the current line
4583         when stepping through the code with "next" or "step".
4584
4585 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4586
4587         * source-cache.c (source_cache::get_source_lines): Call
4588         find_source_lines to initialize s->nlines.  This fixes vertical
4589         scrolling of TUI source window when the DOWN arrow is pressed.
4590
4591 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4592
4593         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4594         linux-thread-db.c (_initialize_thread_db): Likewise.
4595
4596 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4597
4598         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4599         wclrtoeol in tui_show_source_line".  This reverts changes made in
4600         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4601
4602 2019-03-15  Tom Tromey  <tom@tromey.com>
4603
4604         * symtab.h (struct minimal_symbol): Derive from
4605         general_symbol_info.
4606         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4607         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4608         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4609         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4610         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4611         (MSYMBOL_SEARCH_NAME): Update.
4612         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4613         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4614         * minsyms.c (minimal_symbol_reader::record_full): Update.
4615
4616 2019-03-15  Tom Tromey  <tom@tromey.com>
4617
4618         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4619
4620 2019-03-15  Tom Tromey  <tom@tromey.com>
4621
4622         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4623         unique_xmalloc_ptr.
4624         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4625         Update.
4626         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4627         (build_minimal_symbol_hash_tables)
4628         (minimal_symbol_reader::install): Update.
4629
4630 2019-03-15  Tom Tromey  <tom@tromey.com>
4631
4632         * symtab.c (create_demangled_names_hash): Update.
4633         (symbol_set_names): Update.
4634         * objfiles.h (struct objfile_per_bfd_storage)
4635         <demangled_names_hash>: Now an htab_up.
4636         * objfiles.c (objfile_per_bfd_storage): Simplify.
4637
4638 2019-03-15  Tom Tromey  <tom@tromey.com>
4639
4640         * objfiles.h (struct objfile_per_bfd_storage): Declare
4641         destructor.
4642         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4643         New.
4644         (get_objfile_bfd_data): Use new.  Don't initialize
4645         language_of_main.
4646         (free_objfile_per_bfd_storage): Remove.
4647         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4648
4649 2019-03-15  Tom Tromey  <tom@tromey.com>
4650
4651         * symfile.c (reread_symbols): Update.
4652         * objfiles.c (objfile::objfile): Update.
4653         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4654         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4655         comment.
4656         (minimal_symbol_reader::install): Update.
4657         (terminate_minimal_symbol_table): Remove.
4658         * jit.c (jit_object_close_impl): Update.
4659
4660 2019-03-15  Tom Tromey  <tom@tromey.com>
4661
4662         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4663         initializations.
4664
4665 2019-03-15  Tom Tromey  <tom@tromey.com>
4666
4667         * objfiles.h (struct objfile_per_bfd_storage)
4668         <demangled_hash_languages>: Now a bitset.
4669         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4670         (lookup_minimal_symbol): Update.
4671
4672 2019-03-15  Tom Tromey  <tom@tromey.com>
4673
4674         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4675         Don't return the symbol.
4676         * coffread.c (record_minimal_symbol): Use record_full.
4677
4678 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4679
4680         The MS-Windows port of ncurses fails to switch to a color pair if
4681         one or both of the colors are the implicit default colors.  This
4682         change records the default colors when TUI is initialized, and
4683         then specifies them explicitly when a color pair uses the default
4684         colors.  This allows color styling in TUI mode on MS-Windows.
4685
4686         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4687         ncurses_norm_attr.
4688         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4689         colors in ncurses_norm_attr.
4690         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4691         "none", replace it with the default color recorded in
4692         ncurses_norm_attr.
4693
4694 2019-03-14  Tom Tromey  <tromey@adacore.com>
4695
4696         * source-cache.h (class source_cache) <get_source_lines>: Return
4697         std::string.
4698         * source-cache.c (source_cache::extract_lines): Handle case where
4699         first_pos==npos.  Return std::string.
4700         (source_cache::get_source_lines): Update.
4701
4702 2019-03-14  Tom Tromey  <tromey@adacore.com>
4703
4704         * NEWS: Add item for "style sources" commands.
4705         * source-cache.c (source_cache::get_source_lines): Check
4706         source_styling.
4707         * cli/cli-style.c (source_styling): New global.
4708         (_initialize_cli_style): Add "style sources" commands.
4709         (show_style_sources): New function.
4710         * cli/cli-style.h (source_styling): Declare.
4711
4712 2019-03-14  Pedro Alves  <palves@redhat.com>
4713             Tom Tromey  <tromey@adacore.com>
4714
4715         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4716         * tui/tui-winsource.c (tui_refill_source_window): New function,
4717         from...
4718         (tui_horizontal_source_scroll): ... here.  Move some logic.
4719         * cli/cli-style.c (set_style_enabled): Notify new observable.
4720         * tui/tui-hooks.c (tui_redisplay_source): New function.
4721         (tui_attach_detach_observers): Attach or detach
4722         tui_redisplay_source.
4723         * observable.h (source_styling_changed): New observable.
4724         * observable.c: Define source_styling_changed observable.
4725
4726 2019-03-13  Tom Tromey  <tromey@adacore.com>
4727
4728         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4729         (i386_gnu_nat_target::store_registers): Update.
4730         * target-debug.h (target_debug_print_std_string): New macro.
4731         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4732         * windows-tdep.c (display_one_tib): Update.
4733         * tui/tui-stack.c (tui_make_status_line): Update.
4734         * top.c (print_inferior_quit_action): Update.
4735         * thread.c (thr_try_catch_cmd): Update.
4736         (add_thread_with_info): Update.
4737         (thread_target_id_str): Update.
4738         (thr_try_catch_cmd): Update.
4739         (thread_command): Update.
4740         (thread_find_command): Update.
4741         * record-btrace.c (record_btrace_target::info_record)
4742         (record_btrace_resume_thread, record_btrace_target::resume)
4743         (record_btrace_cancel_resume, record_btrace_step_thread)
4744         (record_btrace_target::wait, record_btrace_target::wait)
4745         (record_btrace_target::wait, record_btrace_target::stop): Update.
4746         * progspace.c (print_program_space): Update.
4747         * process-stratum-target.c
4748         (process_stratum_target::thread_address_space): Update.
4749         * linux-fork.c (linux_fork_mourn_inferior)
4750         (detach_checkpoint_command, info_checkpoints_command)
4751         (linux_fork_context): Update.
4752         (linux_fork_detach): Update.
4753         (class scoped_switch_fork_info): Update.
4754         (delete_checkpoint_command): Update.
4755         * infrun.c (follow_fork_inferior): Update.
4756         (follow_fork_inferior): Update.
4757         (proceed_after_vfork_done): Update.
4758         (handle_vfork_child_exec_or_exit): Update.
4759         (follow_exec): Update.
4760         (displaced_step_prepare_throw): Update.
4761         (displaced_step_restore): Update.
4762         (start_step_over): Update.
4763         (resume_1): Update.
4764         (clear_proceed_status_thread): Update.
4765         (proceed): Update.
4766         (print_target_wait_results): Update.
4767         (do_target_wait): Update.
4768         (context_switch): Update.
4769         (stop_all_threads): Update.
4770         (restart_threads): Update.
4771         (finish_step_over): Update.
4772         (handle_signal_stop): Update.
4773         (switch_back_to_stepped_thread): Update.
4774         (keep_going_pass_signal): Update.
4775         (print_exited_reason): Update.
4776         (normal_stop): Update.
4777         * inferior.c (inferior_pid_to_str): Change return type.
4778         (print_selected_inferior): Update.
4779         (add_inferior): Update.
4780         (detach_inferior): Update.
4781         * dummy-frame.c (fprint_dummy_frames): Update.
4782         * dcache.c (dcache_info_1): Update.
4783         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4784         (btrace_fetch, btrace_clear): Update.
4785         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4786         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4787         type.
4788         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4789         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4790         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4791         * gdbarch.c, gdbarch.h: Rebuild.
4792         * gdbarch.sh (core_pid_to_str): Change return type.
4793         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4794         return type.
4795         (windows_nat_target::pid_to_str): Change return type.
4796         (windows_delete_thread): Update.
4797         (windows_nat_target::attach): Update.
4798         (windows_nat_target::files_info): Update.
4799         * target-delegates.c: Rebuild.
4800         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4801         return type.
4802         (sol_thread_target::pid_to_str): Change return type.
4803         * remote.c (class remote_target) <pid_to_str>: Change return
4804         type.
4805         (remote_target::pid_to_str): Change return type.
4806         (extended_remote_target::attach, remote_target::remote_stop_ns)
4807         (remote_target::remote_notif_remove_queued_reply)
4808         (remote_target::push_stop_reply, remote_target::disable_btrace):
4809         Update.
4810         (extended_remote_target::attach): Update.
4811         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4812         type.
4813         (gdbsim_target::pid_to_str): Change return type.
4814         * ravenscar-thread.c (struct ravenscar_thread_target)
4815         <pid_to_str>: Change return type.
4816         (ravenscar_thread_target::pid_to_str): Change return type.
4817         * procfs.c (class procfs_target) <pid_to_str>: Change return
4818         type.
4819         (procfs_target::pid_to_str): Change return type.
4820         (procfs_target::attach): Update.
4821         (procfs_target::detach): Update.
4822         (procfs_target::fetch_registers): Update.
4823         (procfs_target::store_registers): Update.
4824         (procfs_target::wait): Update.
4825         (procfs_target::files_info): Update.
4826         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4827         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4828         return type.
4829         (nto_procfs_target::pid_to_str): Change return type.
4830         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4831         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4832         return type.
4833         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4834         (exit_lwp): Update.
4835         (attach_proc_task_lwp_callback, get_detach_signal)
4836         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4837         (linux_nat_target::resume, wait_lwp, stop_callback)
4838         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4839         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4840         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4841         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4842         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4843         type.
4844         (inf_ptrace_target::attach): Update.
4845         (inf_ptrace_target::files_info): Update.
4846         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4847         type.
4848         (go32_nat_target::pid_to_str): Change return type.
4849         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4850         (gnu_nat_target::wait): Update.
4851         (gnu_nat_target::wait): Update.
4852         (gnu_nat_target::resume): Update.
4853         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4854         (fbsd_nat_target::wait): Update.
4855         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4856         type.
4857         (darwin_nat_target::attach): Update.
4858         * corelow.c (class core_target) <pid_to_str>: Change return type.
4859         (core_target::pid_to_str): Change return type.
4860         * target.c (normal_pid_to_str): Change return type.
4861         (default_pid_to_str): Likewise.
4862         (target_pid_to_str): Change return type.
4863         (target_translate_tls_address): Update.
4864         (target_announce_detach): Update.
4865         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4866         return type.
4867         (bsd_uthread_target::pid_to_str): Change return type.
4868         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4869         type.
4870         (bsd_kvm_target::pid_to_str): Change return type.
4871         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4872         return type.
4873         (aix_thread_target::pid_to_str): Change return type.
4874         * target.h (struct target_ops) <pid_to_str>: Change return type.
4875         (target_pid_to_str, normal_pid_to_str): Likewise.
4876         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4877         type.
4878         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4879         type.
4880         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4881         return type.
4882         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4883         type.
4884         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4885         type.
4886         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4887         return type.
4888
4889 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4890
4891         * NEWS: Mention that the new default MI version is 3.  Mention
4892         changes to the output of commands and events that deal with
4893         multi-location breakpoints.
4894         * breakpoint.c: Include "mi/mi-out.h".
4895         (print_one_breakpoint): Change output syntax if using MI version
4896         >= 3.
4897         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4898         New.
4899         (mi_multi_location_breakpoint_output_fixed): New.
4900         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4901         (mi_cmd_fix_multi_location_breakpoint_output): New.
4902         (mi_multi_location_breakpoint_output_fixed): New.
4903         * mi/mi-cmds.c (mi_cmds): Register command
4904         -fix-multi-location-breakpoint-output.
4905         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4906         interpreter "mi".
4907
4908 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4909
4910         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4911         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4912         instantiate mi_ui_out based on interpreter name.
4913         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4914         * mi/mi-main.c (mi_load_progress): Likewise.
4915
4916 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4917
4918         * NEWS: Combine separate "New targets" sections for 8.3.
4919
4920 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4921
4922         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4923         (ppcfbsd_init_abi): Install gdbarch
4924         "fetch_tls_load_module_address" and "get_thread_local_address"
4925         methods.
4926
4927 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4928
4929         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4930         (riscv_fbsd_init_abi): Install gdbarch
4931         "fetch_tls_load_module_address" and "get_thread_local_address"
4932         methods.
4933
4934 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4935
4936         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4937         (i386fbsd_init_abi): Install gdbarch
4938         "fetch_tls_load_module_address" and "get_thread_local_address"
4939         methods.
4940
4941 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4942
4943         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4944         (amd64fbsd_init_abi): Install gdbarch
4945         "fetch_tls_load_module_address" and "get_thread_local_address"
4946         methods.
4947
4948 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4949
4950         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4951         (struct fbsd_pspace_data): New type.
4952         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4953         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4954         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4955         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4956         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4957
4958 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4959
4960         * gdbtypes.c (lookup_struct_elt): New function.
4961         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4962         * gdbtypes.h (struct struct_elt): New type.
4963         (lookup_struct_elt): New prototype.
4964
4965 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4966
4967         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4968         remove disabled code block.
4969
4970 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4971
4972         * gdbarch.sh (get_thread_local_address): New method.
4973         * gdbarch.h, gdbarch.c: Regenerate.
4974         * target.c (target_translate_tls_address): Use
4975         gdbarch_get_thread_local_address if present instead of
4976         target::get_thread_local_address.
4977
4978 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4979
4980         * target.h (target::get_thread_local_address): Update comment.
4981
4982 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4983
4984         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4985         objfile->separate_debug_objfile_backlink if not NULL.
4986
4987 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4988
4989         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4990         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4991         (amd64bsd_store_inferior_registers): Likewise.
4992         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4993         Enable segment base registers.
4994         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4995         PT_GETFSBASE and PT_GETGSBASE.
4996         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4997         PT_SETGSBASE.
4998         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4999         segment base registers.
5000         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5001
5002 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5003
5004         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5005         Update calls to i386_target_description to add 'segments'
5006         parameter.
5007         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5008         add segment base registers.
5009         * arch/i386.c (i386_create_target_description): Add 'segments'
5010         parameter to enable segment base registers.
5011         * arch/i386.h (i386_create_target_description): Likewise.
5012         * features/i386/32bit-segments.xml: New file.
5013         * features/i386/32bit-segments.c: Generate.
5014         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5015         call to i386_target_description to add 'segments' parameter.
5016         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5017         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5018         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5019         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5020         if feature is present.
5021         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5022         Add 'segments' parameter to call to i386_target_description.
5023         (i386_target_description): Add 'segments' parameter to enable
5024         segment base registers.
5025         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5026         to call to i386_target_description.
5027         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5028         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5029         Define I386_NUM_REGS.
5030         (i386_target_description): Add 'segments' parameter to enable
5031         segment base registers.
5032
5033 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5034
5035         PR/24325
5036         * source-cache.c: #undef open and close, to avoid unresolved
5037         externals during linking.
5038
5039 2019-03-12  Tom Tromey  <tromey@adacore.com>
5040
5041         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5042         const.  Add initializers.
5043         (_initialize_remote): Don't initialize ptid globals.
5044
5045 2019-03-12  Pedro Alves  <palves@redhat.com>
5046
5047         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5048
5049 2019-03-12  Pedro Alves  <palves@redhat.com>
5050
5051         * cp-name-parser.y (main): Remove unused 'len' variable.
5052
5053 2019-03-12  Tom Tromey  <tromey@adacore.com>
5054
5055         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5056         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5057
5058 2019-03-12  Tom Tromey  <tromey@adacore.com>
5059
5060         * linux-nat.c (iterate_over_lwps): Update.
5061         (stop_callback): Remove parameter.
5062         (stop_wait_callback, detach_callback, resume_set_callback)
5063         (select_singlestep_lwp_callback, set_ignore_sigint)
5064         (status_callback, resumed_callback, resume_clear_callback)
5065         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5066         data parameter.
5067         (linux_nat_target::detach, linux_nat_target::resume)
5068         (linux_stop_and_wait_all_lwps, select_event_lwp)
5069         (linux_nat_filter_event, linux_nat_wait_1)
5070         (linux_nat_target::kill, linux_nat_target::stop)
5071         (linux_nat_target::stop): Update.
5072         (linux_nat_resume_callback): Change type.
5073         (resume_stopped_resumed_lwps, count_events_callback)
5074         (select_event_lwp_callback): Likewise.
5075         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5076         * arm-linux-nat.c (struct update_registers_data): Remove.
5077         (update_registers_callback): Change type.
5078         (arm_linux_insert_hw_breakpoint1): Update.
5079         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5080         parameter.
5081         (x86_linux_dr_set_addr): Update.
5082         (x86_linux_dr_set_control): Update.
5083         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5084         (iterate_over_lwps): Use gdb::function_view.
5085         * nat/aarch64-linux-hw-point.c (struct
5086         aarch64_dr_update_callback_param): Remove.
5087         (debug_reg_change_callback): Change type.
5088         (aarch64_notify_debug_reg_change): Update.
5089         * s390-linux-nat.c (s390_refresh_per_info): Update.
5090
5091 2019-03-11  Tom Tromey  <tromey@adacore.com>
5092
5093         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5094         redundant assignment to "this_cu".
5095
5096 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5097
5098         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5099
5100 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5101
5102         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5103         from...
5104         (rank_one_type): ... this.
5105
5106 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5107
5108         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5109         from...
5110         (rank_one_type): ... this.
5111
5112 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5113
5114         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5115         from...
5116         (rank_one_type): ... this.
5117
5118 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5119
5120         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5121         from...
5122         (rank_one_type): ... this.
5123
5124 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5125
5126         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5127         from...
5128         (rank_one_type): ... this.
5129
5130 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5131
5132         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5133         from...
5134         (rank_one_type): ... this.
5135
5136 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5137
5138         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5139         from...
5140         (rank_one_type): ... this.
5141
5142 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5143
5144         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5145         from...
5146         (rank_one_type): ... this.
5147
5148 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5149
5150         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5151         from...
5152         (rank_one_type): ... this.
5153
5154 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5155
5156         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5157         from...
5158         (rank_one_type): ... this.
5159
5160 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5161
5162         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5163         from...
5164         (rank_one_type): ... this.
5165
5166 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5167
5168         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5169         from...
5170         (rank_one_type): ... this.
5171
5172 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5173
5174         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5175         inferior-events' shows the example events.
5176
5177 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5178
5179         Support styling on native MS-Windows console
5180
5181         PR/24315
5182         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5183         on MS-Windows if $TERM is not defined.
5184
5185         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5186
5187         * posix-hdep.c (gdb_console_fputs):
5188         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5189         functions.
5190         * ui-file.h (gdb_console_fputs): Add prototype.
5191
5192         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5193         back to fputs only if the former returns zero.
5194
5195 2019-03-07  Tom Tromey  <tom@tromey.com>
5196
5197         * symmisc.c (print_symbol_bcache_statistics): Update.
5198         (print_objfile_statistics): Update.
5199         * symfile.c (allocate_symtab): Update.
5200         * stabsread.c: Don't include bcache.h.
5201         * psymtab.h (struct psymbol_bcache): Don't declare.
5202         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5203         (psymbol_bcache_init, psymbol_bcache_free)
5204         (psymbol_bcache_get_bcache): Don't declare.
5205         * psymtab.c (struct psymbol_bcache): Remove.
5206         (psymtab_storage::psymtab_storage): Update.
5207         (psymtab_storage::~psymtab_storage): Update.
5208         (psymbol_bcache_init, psymbol_bcache_free)
5209         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5210         (add_psymbol_to_bcache): Update.
5211         (allocate_psymtab): Update.
5212         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5213         macro_cache>: No longer pointers.
5214         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5215         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5216         * macrotab.c (macro_bcache): Update.
5217         * macroexp.c: Don't include bcache.h.
5218         * gdbtypes.c (check_types_worklist): Update.
5219         (types_deeply_equal): Remove TRY/CATCH.  Update.
5220         * elfread.c (elf_symtab_read): Update.
5221         * dwarf2read.c: Don't include bcache.h.
5222         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5223         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5224         (print_bcache_statistics, bcache_memory_used): Don't declare.
5225         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5226         methods.  Rename all data members.
5227         * bcache.c (struct bcache): Move to bcache.h.
5228         (bcache::expand_hash_table): Rename from expand_hash_table.
5229         (bcache): Remove.
5230         (bcache::insert): Rename from bcache_full.
5231         (bcache::compare): Rename from bcache_compare.
5232         (bcache_xmalloc): Remove.
5233         (bcache::~bcache): Rename from bcache_xfree.
5234         (bcache::print_statistics): Rename from print_bcache_statistics.
5235         (bcache::memory_used): Rename from bcache_memory_used.
5236
5237 2019-03-07  Pedro Alves  <palves@redhat.com>
5238
5239         * infrun.c (normal_stop): Also check for
5240         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5241
5242 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5243
5244         * f-lang.c (value_from_host_double): Moved to...
5245         * value.c (value_from_host_double): ...here.
5246         * value.h (value_from_host_double): Declare.
5247         * guile/scm-math.c (vlscm_convert_typed_number): Use
5248         value_from_host_double.
5249         (vlscm_convert_number): Likewise.
5250         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5251         * python/py-value.c (convert_value_from_python): Likewise.
5252
5253 2019-03-06  Tom Tromey  <tom@tromey.com>
5254
5255         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5256
5257 2019-03-06  Tom Tromey  <tom@tromey.com>
5258
5259         * utils.h (free_current_contents): Don't declare.
5260         * utils.c (free_current_contents): Remove.
5261
5262 2019-03-06  Tom Tromey  <tom@tromey.com>
5263
5264         * top.c (quit_force): Update.
5265         * main.c (captured_command_loop): Update.
5266         * common/new-op.c (operator new): Update.
5267         * common/common-exceptions.c (struct catcher)
5268         <save_cleanup_chain>: Remove member.
5269         (exceptions_state_mc_init): Update.
5270         (exception_try_scope_entry): Return nullptr.
5271         (exception_try_scope_exit, exception_rethrow)
5272         (throw_exception_sjlj, throw_exception_cxx): Update.
5273         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5274         (all_cleanups, do_cleanups, discard_cleanups)
5275         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5276         (restore_cleanups, restore_final_cleanups): Don't declare.
5277         (do_final_cleanups): Remove parameter.
5278         * common/cleanups.c (cleanup_chain, make_cleanup)
5279         (make_cleanup_dtor, all_cleanups, do_cleanups)
5280         (discard_my_cleanups, discard_cleanups)
5281         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5282         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5283         (null_cleanup): Remove.
5284         (do_final_cleanups): Remove parameter.
5285
5286 2019-03-06  Tom Tromey  <tom@tromey.com>
5287
5288         * remote.c (remote_target::remote_parse_stop_reply): Use
5289         unique_xmalloc_ptr.
5290
5291 2019-03-06  Tom Tromey  <tom@tromey.com>
5292
5293         * stabsread.c (struct stabs_field_info): Rename from field_info.
5294         <list, fnlist>: Add initializers.
5295         <obstack>: New member.
5296         (read_member_functions, read_struct_fields, read_baseclasses):
5297         Allocate on obstack.  Don't use cleanups.
5298         (read_one_struct_field, read_member_functions, read_struct_fields)
5299         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5300         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5301         (read_struct_type): Update.
5302
5303 2019-03-06  Tom Tromey  <tom@tromey.com>
5304
5305         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5306         * common/filestuff.h (make_cleanup_close): Don't declare.
5307         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5308         Remove.
5309
5310 2019-03-06  Tom Tromey  <tom@tromey.com>
5311
5312         * solib-aix.c: Use make_scope_exit.
5313
5314 2019-03-06  Tom Tromey  <tom@tromey.com>
5315
5316         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5317         Use make_scope_exit.
5318
5319 2019-03-06  Tom Tromey  <tom@tromey.com>
5320
5321         * solib-svr4.c (disable_probes_interface): Remove parameter.
5322         (svr4_handle_solib_event): Use make_scope_exit.
5323
5324 2019-03-06  Tom Tromey  <tom@tromey.com>
5325
5326         * remote.c (struct stop_reply_deleter): Remove.
5327         (stop_reply_up): Update.
5328         (struct stop_reply): Derive from notif_event.  Don't typedef.
5329         <regcache>: Now a std::vector.
5330         (stop_reply_xfree): Remove.
5331         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5332         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5333         (remote_target::discard_pending_stop_replies): Use delete.
5334         (remote_target::remote_parse_stop_reply): Update.
5335         (remote_target::process_stop_reply): Update.
5336         * remote-notif.h (struct notif_event): Add virtual destructor.
5337         Remove "dtr" member.
5338         (struct notif_client) <alloc_event>: Return a unique_ptr.
5339         (notif_event_xfree): Don't declare.
5340         (notif_event_up): New typedef.
5341         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5342         (notif_event_xfree, do_notif_event_xfree): Remove.
5343         (remote_notif_state_xfree): Update.
5344
5345 2019-03-06  Tom Tromey  <tom@tromey.com>
5346
5347         * infrun.c (displaced_step_clear_cleanup): Now a
5348         forward_scope_exit type.
5349         (displaced_step_prepare_throw): Update.
5350         (displaced_step_fixup): Update.
5351
5352 2019-03-06  Tom Tromey  <tom@tromey.com>
5353
5354         * inferior.h (class inferior): Update comment.
5355         * gdbthread.h (class thread_info): Update comment.
5356
5357 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5358             Tom Tromey  <tom@tromey.com>
5359
5360         * stabsread.h (struct stab_section_list): Remove.
5361         (coffstab_build_psymtabs): Update.
5362         * dbxread.c (symbuf_sections): Now a std::vector.
5363         (sect_idx): New global.
5364         (fill_symbuf): Update.
5365         (coffstab_build_psymtabs): Change type of stabsects parameter.
5366         Update.
5367         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5368         std::vector.
5369         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5370         (coff_locate_sections): Update.
5371         (coff_symfile_read): Remove cleanups.  Update.
5372         (init_stringtab): Add storage parameter.
5373         (free_stringtab, free_stringtab_cleanup): Remove.
5374         (init_lineno): Add storage parameter.
5375         (free_linetab, free_linetab_cleanup): Remove.
5376
5377 2019-03-06  Pedro Alves  <palves@redhat.com>
5378
5379         * linux-fork.c (fork_info::clobber_regs): Delete.
5380         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5381         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5382         comment.  Adjust.
5383         (scoped_switch_fork_info::scoped_switch_fork_info)
5384         (checkpoint_command, linux_fork_context): Adjust
5385         fork_save_infrun_state calls.
5386
5387 2019-03-06  Pedro Alves  <palves@redhat.com>
5388
5389         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5390         (inf_has_multiple_threads): Return 'bool' and rewrite using
5391         inferior_info::threads().
5392
5393 2019-03-06  Pedro Alves  <palves@redhat.com>
5394
5395         * linux-fork.c: Include <list>.
5396         (fork_list): Now a std::list instance.
5397         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5398         (forks_exist_p, find_last_fork): Adjust.
5399         (new_fork): Delete.
5400         (one_fork_p): New.
5401         (add_fork): Adjust.
5402         (free_fork): Delete, folded into fork_info::~fork_info().
5403         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5404         Adjust.
5405         (init_fork_list): Delete.
5406         (linux_fork_killall, linux_fork_mourn_inferior)
5407         (linux_fork_detach, info_checkpoints_command): Adjust.
5408         (_initialize_linux_fork): No longer call init_fork_list.
5409
5410 2019-03-06  Pedro Alves  <palves@redhat.com>
5411
5412         * linux-fork.c (new_fork): New, split out of ...
5413         (add_fork): ... this.  Return void.  Move "first fork" special
5414         case from here, to ...
5415         (checkpoint_command): ... here.
5416         * linux-linux.h (add_fork): Return void.
5417
5418 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5419
5420         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5421
5422 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5423             Chris January  <chris.january@arm.com>
5424             David Lecomber  <david.lecomber@arm.com>
5425
5426         * f-exp.y: New token, UNOP_INTRINSIC.
5427         (exp): New pattern using UNOP_INTRINSIC token.
5428         (f77_keywords): Add 'abs' keyword.
5429         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5430         (value_from_host_double): New function.
5431         (evaluate_subexp_f): Support UNOP_ABS.
5432
5433 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5434
5435         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5436         types.
5437
5438 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5439
5440         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5441         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5442         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5443
5444 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5445
5446         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5447
5448 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5449             Chris January  <chris.january@arm.com>
5450
5451         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5452         * f-exp.y: Define 'KIND' token.
5453         (exp): New pattern for KIND expressions.
5454         (ptype): Handle types with a kind extension.
5455         (direct_abs_decl): Extend to spot kind extensions.
5456         (f77_keywords): Add 'kind' to the list.
5457         (push_kind_type): New function.
5458         (convert_to_kind_type): New function.
5459         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5460         * parse.c (operator_length_standard): Likewise.
5461         * parser-defs.h (enum type_pieces): Add tp_kind.
5462         * std-operator.def: Add UNOP_KIND.
5463
5464 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5465
5466         * f-exp.y (f_parse): Set yydebug.
5467
5468 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5469
5470         * f-lang.c (evaluate_subexp_f): New function.
5471         (exp_descriptor_f): New global.
5472         (f_language_defn): Use exp_descriptor_f instead of
5473         exp_descriptor_standard.
5474
5475 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5476
5477         * f-exp.y (struct token): Add comments.
5478         (dot_ops): Remove uppercase versions and the end marker.
5479         (f77_keywords): Likewise.
5480         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5481         entries in the dot_ops array are case insensitive, and use
5482         strncasecmp to compare strings.  Also some whitespace cleanup in
5483         this area.  Similar for the f77_keywords array, except entries in
5484         this list might be case sensitive.
5485
5486 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5487
5488         * f-exp.y (struct f77_boolean_val): Add comments.
5489         (boolean_values): Remove uppercase versions, and end marker.
5490         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5491         and use strncasecmp to achieve case insensitivity.  Additionally,
5492         perform whitespace cleanup around this code.
5493
5494 2019-03-06  Tom Tromey  <tromey@adacore.com>
5495
5496         * remote-sim.c (gdbsim_target_open): Use result of
5497         gdb_argv::release.
5498
5499 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5500         Dirk Schubert  <dirk.schubert@arm.com>
5501         Chris January  <chris.january@arm.com>
5502
5503         * eval.c (evaluate_subexp_standard): Call Fortran argument
5504         wrapping logic.
5505         * f-lang.c (struct value): A value which can be passed into a
5506         Fortran function call.
5507         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5508         where appropriate.
5509         (struct type): Value ready for a Fortran function call.
5510         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5511         is needed.
5512         * f-lang.h (fortran_argument_convert): Declaration.
5513         (fortran_preserve_arg_pointer): Declaration.
5514         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5515
5516 2019-03-05  Tom Tromey  <tromey@adacore.com>
5517
5518         * python/py-prettyprint.c (print_string_repr): Remove #if.
5519         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5520
5521 2019-03-05  Tom Tromey  <tromey@adacore.com>
5522
5523         * target.c (the_dummy_target): Move later.  Change type to
5524         "dummy_target".
5525         (initialize_targets): Don't initialize the_dummy_target.
5526
5527 2019-03-05  Tom Tromey  <tromey@adacore.com>
5528
5529         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5530         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5531
5532 2019-03-05  Tom Tromey  <tromey@adacore.com>
5533
5534         * windows-nat.c (windows_nat_target::attach)
5535         (windows_nat_target::detach): Don't call gdb_flush.
5536         * valprint.c (generic_val_print, val_print, val_print_string):
5537         Don't call gdb_flush.
5538         * utils.c (defaulted_query): Don't call gdb_flush.
5539         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5540         * target.c (target_announce_detach): Don't call gdb_flush.
5541         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5542         * remote.c (extended_remote_target::attach): Don't call
5543         gdb_flush.
5544         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5545         * printcmd.c (do_examine): Don't call gdb_flush.
5546         (info_display_command): Don't call gdb_flush.
5547         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5548         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5549         * memattr.c (info_mem_command): Don't call gdb_flush.
5550         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5551         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5552         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5553         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5554         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5555         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5556         (gnu_nat_target::detach): Don't call gdb_flush.
5557         * f-valprint.c (f_val_print): Don't call gdb_flush.
5558         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5559         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5560         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5561         gdb_flush.
5562         * c-valprint.c (c_val_print): Don't call gdb_flush.
5563         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5564
5565 2019-03-05  Tom Tromey  <tromey@adacore.com>
5566
5567         * varobj.c (update_dynamic_varobj_children): Update.
5568         (install_default_visualizer): Use reset, not release.
5569         * value.c (set_internalvar): Update.
5570         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5571         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5572         ATTRIBUTE_UNUSED_RESULT.
5573
5574 2019-03-05  Tom Tromey  <tromey@adacore.com>
5575
5576         * remote.c (class scoped_remote_fd) <release>: Add
5577         ATTRIBUTE_UNUSED_RESULT.
5578
5579 2019-03-05  Tom Tromey  <tromey@adacore.com>
5580
5581         * macroexp.c (struct macro_buffer) <release>: Add
5582         ATTRIBUTE_UNUSED_RESULT.
5583
5584 2019-03-05  Tom Tromey  <tromey@adacore.com>
5585
5586         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5587         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5588         ATTRIBUTE_UNUSED_RESULT.
5589
5590 2019-03-05  Tom Tromey  <tromey@adacore.com>
5591
5592         * common/scoped_fd.h (class scoped_fd) <release>: Add
5593         ATTRIBUTE_UNUSED_RESULT.
5594
5595 2019-03-05  Tom Tromey  <tromey@adacore.com>
5596
5597         * parser-defs.h (struct parser_state) <release>: Add
5598         ATTRIBUTE_UNUSED_RESULT.
5599
5600 2019-03-05  Tom Tromey  <tromey@adacore.com>
5601
5602         * utils.h (class gdb_argv) <release>: Add
5603         ATTRIBUTE_UNUSED_RESULT.
5604         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5605
5606 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5607
5608         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5609         for-loop range, to avoid compiler warnings.
5610
5611         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5612         avoid compiler warnings about unused variables.
5613
5614         * NEWS: Mention end of support for native debugging on MS-Windows
5615         before XP.
5616
5617         PR gdb/24292
5618         * common/netstuff.c:
5619         * gdbserver/gdbreplay.c
5620         * gdbserver/remote-utils.c:
5621         * ser-tcp.c:
5622         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5623         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5624         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5625         'getaddrinfo' and 'freeaddrinfo' were not available before
5626         Windows XP, and mingw.org's MinGW headers by default define
5627         _WIN32_WINNT to 0x500.
5628
5629 2019-03-01  Gary Benson <gbenson@redhat.com>
5630
5631         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5632
5633 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5634             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5635
5636         PR gdb/8527
5637         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5638         set_sigint_trap, clear_sigint_trap.
5639
5640 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5641
5642         * target.c (target_detach): Clear the regcache and the
5643         frame cache.
5644
5645 2019-02-27  Pedro Alves  <palves@redhat.com>
5646
5647         * utils.c (set_screen_size): When we cap the height/width sizes,
5648         tweak the corresponding command variable to show "unlimited":
5649
5650 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5651             Pedro Alves  <palves@redhat.com>
5652
5653         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5654         before calling rl_set_screen_size.
5655
5656 2019-02-27  Tom Tromey  <tromey@adacore.com>
5657
5658         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5659         define.
5660         * python/py-value.c: Remove Python 2.4 workaround.
5661         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5662         workaround.
5663         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5664         Python 2.4 workaround.
5665         * python/python-internal.h: Remove Python 2.4 comment.
5666         (Py_ssize_t): Don't define.
5667         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5668         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5669         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5670         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5671         * python/python.c (do_start_initialization): Remove Python 2.4
5672         workaround.
5673         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5674         (print_children): Remove Python 2.4 workaround.
5675         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5676         workaround.
5677         (CHARBUFFERPROC_NAME): Remove.
5678         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5679         Python 2.4 workaround.
5680
5681 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5682
5683         * NEWS: Note minimum Python version.
5684
5685 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5686
5687         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5688         code from these functions.  Remove corresponding ifdefs.  Use
5689         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5690         Remove gotos and target of gotos.
5691         (infpy_search_memory): Likewise.
5692
5693 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5694
5695         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5696         (hppa_gdbarch_init): Don't register deleted functions with
5697         gdbarch.
5698
5699 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5700
5701         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5702         (h8300_unwind_sp): Delete.
5703         (h8300_dummy_id): Delete.
5704         (h8300_gdbarch_init): Don't register deleted functions with
5705         gdbarch.
5706
5707 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5708
5709         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5710         (ft32_unwind_pc): Delete.
5711         (ft32_unwind_sp): Delete.
5712         (ft32_gdbarch_init): Don't register deleted functions with
5713         gdbarch.
5714
5715 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5716
5717         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5718         (frv_unwind_pc): Delete.
5719         (frv_unwind_sp): Delete.
5720         (frv_gdbarch_init): Don't register deleted functions with
5721         gdbarch.
5722
5723 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5724
5725         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5726         (riscv_unwind_pc): Delete.
5727         (riscv_unwind_sp): Delete.
5728         (riscv_gdbarch_init): Don't register deleted functions with
5729         gdbarch.
5730
5731 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5732
5733         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5734         (csky_unwind_pc): Delete.
5735         (csky_unwind_sp): Delete.
5736         (csky_gdbarch_init): Don't register deleted functions with
5737         gdbarch.
5738
5739 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5740
5741         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5742         (cris_unwind_pc): Delete.
5743         (cris_unwind_sp): Delete.
5744         (cris_gdbarch_init): Don't register deleted functions with
5745         gdbarch.
5746
5747 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5748
5749         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5750         (bfin_unwind_pc): Delete.
5751         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5752
5753 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5754
5755         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5756         (arm_unwind_pc): Delete.
5757         (arm_unwind_sp): Delete.
5758         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5759
5760 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5761
5762         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5763         (arc_unwind_pc): Delete.
5764         (arc_unwind_sp): Delete.
5765         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5766
5767 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5768
5769         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5770         (alpha_unwind_pc): Delete.
5771         (alpha_gdbarch_init): Don't register deleted functions with
5772         gdbarch.
5773
5774 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5775
5776         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5777         (aarch64_unwind_pc): Delete.
5778         (aarch64_unwind_sp): Delete.
5779         (aarch64_gdbarch_init): Don't register deleted functions with
5780         gdbarch.
5781
5782 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5783
5784         * gdbtypes.c (type_align): Don't consider static members when
5785         computing structure alignment.
5786
5787 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5788
5789         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5790         return 0 for other types.
5791         * arch-utils.c (default_type_align): Always return 0.
5792         * gdbarch.h: Regenerate.
5793         * gdbarch.sh (type_align): Extend comment.
5794         * gdbtypes.c (type_align): Add additional comments, always call
5795         gdbarch_type_align before applying the default rules.
5796         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5797         generic code will then apply a suitable default.
5798         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5799         types, return 0 for other types.
5800
5801 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5802
5803         * NEWS: Create a new section for the next release branch.
5804         Rename the section of the current branch, now that it has
5805         been cut.
5806
5807 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5808
5809         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5810         * version.in: Bump version to 8.3.50.DATE-git.
5811
5812 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5813
5814         * aix-thread.c (ptid_cmp): Remove unused variable.
5815         (get_signaled_thread): Likewise.
5816         (store_regs_user_thread): Likewise.
5817         (store_regs_kernel_thread): Likewise.
5818         (fetch_regs_kernel_thread): Remove shadowed variable.
5819
5820 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5821
5822         * features/riscv/32bit-cpu.xml: Add register numbers.
5823         * features/riscv/32bit-fpu.c: Regenerate.
5824         * features/riscv/32bit-fpu.xml: Add register numbers.
5825         * features/riscv/64bit-cpu.xml: Add register numbers.
5826         * features/riscv/64bit-fpu.c: Regenerate.
5827         * features/riscv/64bit-fpu.xml: Add register numbers.
5828
5829 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5830
5831         * NEWS: Mention two argument form of gdb.Value constructor.
5832         * python/py-value.c (convert_buffer_and_type_to_value): New
5833         function.
5834         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5835         Add support for handling an optional second argument.  Call
5836         convert_buffer_and_type_to_value as appropriate.
5837         * python/python-internal.h (Py_buffer_deleter): New struct.
5838         (Py_buffer_up): New typedef.
5839
5840 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5841
5842         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5843         instead of releasing ownership.
5844
5845 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5846
5847         * dwarf2read.c (open_and_init_dwp_file): Call
5848         elf_numsections instead of bfd_count_sections to initialize
5849         dwp_file->num_sections.
5850
5851 2019-02-25  Tom Tromey  <tromey@adacore.com>
5852
5853         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5854
5855 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5856
5857         * gcore.in: Add '--readnever' option when invoking GDB.
5858
5859 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5860
5861         * MAINTAINERS: Update my email address.
5862
5863 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5864
5865         * build-id.c (build_id_to_debug_bfd_1): New function.
5866         (build_id_to_debug_bfd): Look for separate debug file in
5867         sysroot.
5868
5869 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5870
5871         * gdbarch.sh: Update the copyright year range that is placed into
5872         generated files.
5873
5874 2019-02-22  Keith Seitz  <keiths@redhat.com>
5875
5876         PR symtab/23853
5877         * linespec.c (create_sals_line_offset): Search for the default
5878         symtab's filename instead of its fullname.
5879
5880 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5881
5882         * NEWS: Update style defaults.
5883
5884 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5885
5886         * main.c (captured_main_1): Disable styling in batch mode.
5887
5888 2019-02-20  Tom Tromey  <tom@tromey.com>
5889
5890         * symtab.c (symtab_symbol_info): Fix typos.
5891
5892 2019-02-20  Tom Tromey  <tromey@adacore.com>
5893
5894         * findcmd.c (_initialize_mem_search): Use upper case for
5895         metasyntactic variables.
5896
5897 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5898
5899         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5900         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5901
5902 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5903
5904         * top.h (source_file_name): Change to std::string.
5905         * top.c (source_file_name): Likewise.
5906         (command_line_input): Adjust.
5907         * cli/cli-script.c (script_from_file): Adjust.
5908
5909 2019-02-19  Tom Tromey  <tromey@adacore.com>
5910
5911         * ravenscar-thread.c
5912         (ravenscar_thread_target::update_thread_list): Don't call
5913         ada_build_task_list.
5914         * ada-lang.h (ada_build_task_list): Don't declare.
5915         * ada-tasks.c (struct ada_tasks_inferior_data)
5916         <task_list_valid_p>: Now bool.
5917         (read_known_tasks, ada_task_list_changed)
5918         (ada_tasks_invalidate_inferior_data): Update.
5919         (read_known_tasks_array): Return bool.
5920         (read_known_tasks_list): Likewise.
5921         (read_known_tasks): Return void.
5922         (ada_build_task_list): Now static.
5923
5924 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5925
5926         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5927         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5928
5929 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5930
5931         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5932         variant for ada_tasks_pspace_data_handle and
5933         ada_tasks_inferior_data_handle.
5934         (ada_tasks_pspace_data_cleanup): New function.
5935         (ada_tasks_inferior_data_cleanup): New function.
5936
5937 2019-02-17  Tom Tromey  <tom@tromey.com>
5938
5939         * macrotab.h (macro_source_fullname): Return a std::string.
5940         * macrotab.c (macro_include, check_for_redefinition)
5941         (macro_undef, macro_lookup_definition, foreach_macro)
5942         (foreach_macro_in_scope): Update.
5943         (macro_source_fullname): Return a std::string.
5944         * macrocmd.c (show_pp_source_pos): Update.
5945
5946 2019-02-17  Tom Tromey  <tom@tromey.com>
5947
5948         * macrocmd.c (show_pp_source_pos): Style the file names.
5949
5950 2019-02-17  Tom Tromey  <tom@tromey.com>
5951
5952         PR tui/24197:
5953         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5954
5955 2019-02-17  Tom Tromey  <tom@tromey.com>
5956
5957         * ada-lang.c (user_select_syms): Use filtered printing.
5958         * utils.c (wrap_style): New global.
5959         (desired_style): Remove.
5960         (emit_style_escape): Add stream parameter.
5961         (set_output_style, reset_terminal_style, prompt_for_continue):
5962         Update.
5963         (flush_wrap_buffer): Only flush gdb_stdout.
5964         (wrap_here): Set wrap_style.
5965         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5966         treat escape sequences as a character.  Change when wrap buffer is
5967         flushed.
5968         (fputs_styled): Do not set the output style when the default is
5969         requested.
5970         * ui-style.h (struct ui_file_style) <is_default>: New method.
5971         * source.c (print_source_lines_base): Emit escape sequences in one
5972         piece.
5973
5974 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5975
5976         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5977         integers and enumeration types.
5978
5979 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5980
5981         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5982         instead of lookup_symbol_in_language
5983         (do_exact_match): New function.
5984         (ada_get_symbol_name_matcher): Return do_exact_match when
5985         doing a verbatim match.
5986
5987 2019-02-15  Tom Tromey  <tromey@adacore.com>
5988
5989         * ravenscar-thread.c (ravenscar_thread_target::resume)
5990         (ravenscar_thread_target::wait): Special case wildcard requests.
5991
5992 2019-02-15  Tom Tromey  <tromey@adacore.com>
5993
5994         * ravenscar-thread.c (base_ptid): Remove.
5995         (struct ravenscar_thread_target) <close>: New method.
5996         <m_base_ptid>: New member.
5997         <update_inferior_ptid, active_task, task_is_currently_active,
5998         runtime_initialized>: Declare methods.
5999         <ravenscar_thread_target>: Add constructor.
6000         (ravenscar_thread_target::task_is_currently_active)
6001         (ravenscar_thread_target::update_inferior_ptid)
6002         (ravenscar_runtime_initialized): Rename.  Now methods.
6003         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6004         (ravenscar_thread_target::update_thread_list): Update.
6005         (ravenscar_thread_target::active_task): Now method.
6006         (ravenscar_thread_target::store_registers)
6007         (ravenscar_thread_target::prepare_to_store)
6008         (ravenscar_thread_target::prepare_to_store)
6009         (ravenscar_thread_target::mourn_inferior): Update.
6010         (ravenscar_inferior_created): Use "new" to create target.
6011         (ravenscar_thread_target::get_ada_task_ptid): Update.
6012         (_initialize_ravenscar): Don't initialize base_ptid.
6013         (ravenscar_ops): Remove global.
6014
6015 2019-02-15  Tom Tromey  <tromey@adacore.com>
6016
6017         * target.h (push_target): Declare new overload.
6018         * target.c (push_target): New overload, taking an rvalue reference.
6019         * remote.c (remote_target::open_1): Use push_target overload.
6020         * corelow.c (core_target_open): Use push_target overload.
6021
6022 2019-02-15  Tom Tromey  <tromey@adacore.com>
6023
6024         * ravenscar-thread.c (is_ravenscar_task)
6025         (ravenscar_task_is_currently_active): Return bool.
6026         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6027         (_initialize_ravenscar): Remove "(void)".
6028         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6029         Return bool.
6030
6031 2019-02-15  Tom Tromey  <tromey@adacore.com>
6032
6033         * ravenscar-thread.c (ravenscar_runtime_initializer)
6034         (has_ravenscar_runtime, get_running_thread_id)
6035         (ravenscar_thread_target::resume): Fix indentation.
6036
6037 2019-02-15  Tom Tromey  <tromey@adacore.com>
6038
6039         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6040         from ravenscar_arch_ops.
6041         (sparc_ravenscar_ops::fetch_registers)
6042         (sparc_ravenscar_ops::store_registers): Now methods.
6043         (sparc_ravenscar_prepare_to_store): Remove.
6044         (sparc_ravenscar_ops): Redefine.
6045         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6046         methods and destructor.  Remove members.
6047         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6048         (ravenscar_thread_target::store_registers)
6049         (ravenscar_thread_target::prepare_to_store): Update.
6050         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6051         Remove.
6052         (struct ppc_ravenscar_powerpc_ops): Derive from
6053         ravenscar_arch_ops.
6054         (ppc_ravenscar_powerpc_ops::fetch_registers)
6055         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6056         (ppc_ravenscar_powerpc_ops): Redefine.
6057         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6058         (ppc_ravenscar_e500_ops::fetch_registers)
6059         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6060         (ppc_ravenscar_e500_ops): Redefine.
6061         * aarch64-ravenscar-thread.c
6062         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6063         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6064         (aarch64_ravenscar_fetch_registers)
6065         (aarch64_ravenscar_store_registers): Now methods.
6066         (aarch64_ravenscar_ops): Redefine.
6067
6068 2019-02-15  Tom Tromey  <tromey@adacore.com>
6069
6070         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6071         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6072         (ravenscar_thread_target::stopped_by_watchpoint)
6073         (ravenscar_thread_target::stopped_data_address)
6074         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6075
6076 2019-02-15  Tom Tromey  <tromey@adacore.com>
6077
6078         * ravenscar-thread.c: Fix some typos.
6079
6080 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6081             Tom Tromey  <tromey@adacore.com>
6082
6083         * ada-lang.c (ada_exception_sal): Change addr_string to a
6084         std::string.
6085         (create_ada_exception_catchpoint): Update.
6086
6087 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6088             Tom Tromey  <tromey@adacore.com>
6089
6090         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6091         (bp_location_ops): Remove.
6092         (base_breakpoint_allocate_location): Update.
6093         (free_bp_location): Update.
6094         * ada-lang.c (class ada_catchpoint_location)
6095         <ada_catchpoint_location>: Remove ops parameter.
6096         (ada_catchpoint_location_dtor): Remove.
6097         (ada_catchpoint_location_ops): Remove.
6098         (allocate_location_exception): Update.
6099         * breakpoint.h (struct bp_location_ops): Remove.
6100         (class bp_location) <bp_location>: Remove bp_location_ops
6101         parameter.
6102         <~bp_location>: Add destructor.
6103         <ops>: Remove.
6104
6105 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6106             Pedro Alves  <palves@redhat.com>
6107
6108         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6109         'PATH_MAX'.
6110
6111 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6112             Samuel Thibault  <samuel.thibault@gnu.org>
6113             Thomas Schwinge  <thomas@codesourcery.com>
6114
6115         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6116         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6117
6118 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6119
6120         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6121         (check_empty): Use "const char *".
6122
6123         * gnu-nat.c (gnu_nat_target::detach): Instead of
6124         'detach_inferior (pid)' call
6125         'detach_inferior (find_inferior_pid (pid))'.
6126
6127         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6128         'nat/fork-inferior.o'.
6129         * gnu-nat.c: #include "nat/fork-inferior.h".
6130
6131         * gnu-nat.c (gnu_nat_target::detach): Instead of
6132         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6133         * gnu-nat.h: #include "inf-child.h".
6134         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6135         'i386_gnu_nat_target::fetch_registers'.
6136         (gnu_store_registers): Rename/move to
6137         'i386_gnu_nat_target::store_registers'.
6138
6139         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6140         * gnu-nat.h (mach_thread_info): New function.
6141         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6142
6143         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6144
6145 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6146
6147         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6148
6149 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6150
6151         * windows-nat.c (windows_add_thread): Add new parameter
6152         "main_thread_p" with default value set to false.  Update
6153         function documentation as well as all callers.
6154         (windows_delete_thread): Likewise.
6155         (fake_create_process): Update call to windows_add_thread.
6156         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6157         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6158         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6159         call to windows_delete_thread.
6160
6161 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6162
6163         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6164
6165 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6166
6167         * symfile.c (find_separate_debug_file): Use canonical path of
6168         sysroot with child_path instead of gdb_sysroot if it is valid.
6169
6170 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6171
6172         * symfile.c (find_separate_debug_file): Use child_path to
6173         determine if an object file is under a sysroot.
6174
6175 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6176
6177         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6178         unittests/child-path-selftests.c.
6179         * common/pathstuff.c (child_path): New function.
6180         * common/pathstuff.h (child_path): New prototype.
6181         * unittests/child-path-selftests.c: New file.
6182
6183 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6184
6185         * symfile.c (find_separate_debug_file): Look for separate debug
6186         files in debug directories under the sysroot.
6187
6188 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6189
6190         * symtab.h (struct minimal_symbol data_p): New const method.
6191         (struct minimal_symbol text_p): Likewise.
6192         * symtab.c (output_source_filename): Use file name style
6193         to print file name.
6194         (print_symbol_info): Likewise.
6195         (print_msymbol_info): Use address style to print addresses.
6196         Use function name style to print executable text symbols.
6197         (expand_symtab_containing_pc): Use data_p.
6198         (find_pc_sect_compunit_symtab): Likewise.
6199
6200 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6201
6202         * breakpoint.c (describe_other_breakpoints): Use address style
6203         to print addresses.
6204         (say_where): Likewise.
6205
6206 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6207
6208         * ada-typeprint.c (print_func_type): Print function name
6209         style to print function name.
6210         * c-typeprint.c (c_print_type_1): Likewise.
6211
6212 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6213
6214         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6215         for execve.
6216
6217 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6218
6219         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6220         type_stack.
6221
6222 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6223
6224         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6225         TYPE_CODE_REF types.
6226
6227 2019-02-08  Jim Wilson  <jimw@sifive.com>
6228
6229         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6230         (riscv_linux_fregset): New.
6231         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6232
6233 2019-02-07  Tom Tromey  <tom@tromey.com>
6234
6235         * thread.c (thread_cancel_execution_command): Update.
6236         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6237         methods.
6238         (struct thread_fsm_ops): Remove.
6239         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6240         (thread_fsm_should_stop, thread_fsm_return_value)
6241         (thread_fsm_set_finished, thread_fsm_finished_p)
6242         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6243         Don't declare.
6244         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6245         * infrun.c (clear_proceed_status_thread)
6246         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6247         (print_stop_event): Update.
6248         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6249         Add constructor.
6250         (step_command_fsm_ops): Remove.
6251         (new_step_command_fsm): Remove.
6252         (step_1): Update.
6253         (step_command_fsm::should_stop): Rename from
6254         step_command_fsm_should_stop.
6255         (step_command_fsm::clean_up): Rename from
6256         step_command_fsm_clean_up.
6257         (step_command_fsm::do_async_reply_reason): Rename from
6258         step_command_fsm_async_reply_reason.
6259         (struct until_next_fsm): Inherit from thread_fsm.  Add
6260         constructor.
6261         (until_next_fsm_ops): Remove.
6262         (new_until_next_fsm): Remove.
6263         (until_next_fsm::should_stop): Rename from
6264         until_next_fsm_should_stop.
6265         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6266         (until_next_fsm::do_async_reply_reason): Rename from
6267         until_next_fsm_async_reply_reason.
6268         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6269         constructor.  Change type of breakpoint.
6270         (finish_command_fsm_ops): Remove.
6271         (new_finish_command_fsm): Remove.
6272         (finish_command_fsm::should_stop): Rename from
6273         finish_command_fsm_should_stop.
6274         (finish_command_fsm::clean_up): Rename from
6275         finish_command_fsm_clean_up.
6276         (finish_command_fsm::return_value): Rename from
6277         finish_command_fsm_return_value.
6278         (finish_command_fsm::do_async_reply_reason): Rename from
6279         finish_command_fsm_async_reply_reason.
6280         (finish_command): Update.
6281         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6282         Add constructor.
6283         (call_thread_fsm_ops): Remove.
6284         (call_thread_fsm::call_thread_fsm): Rename from
6285         new_call_thread_fsm.
6286         (call_thread_fsm::should_stop): Rename from
6287         call_thread_fsm_should_stop.
6288         (call_thread_fsm::should_notify_stop): Rename from
6289         call_thread_fsm_should_notify_stop.
6290         (run_inferior_call, call_function_by_hand_dummy): Update.
6291         * cli/cli-interp.c (should_print_stop_to_console): Update.
6292         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6293         Add constructor.  Change type of location_breakpoint,
6294         caller_breakpoint.
6295         (until_break_fsm_ops): Remove.
6296         (new_until_break_fsm): Remove.
6297         (until_break_fsm::should_stop): Rename from
6298         until_break_fsm_should_stop.
6299         (until_break_fsm::clean_up): Rename from
6300         until_break_fsm_clean_up.
6301         (until_break_fsm::do_async_reply_reason): Rename from
6302         until_break_fsm_async_reply_reason.
6303         (until_break_command): Update.
6304         * thread-fsm.c: Remove.
6305         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6306
6307 2019-02-07  Tom Tromey  <tom@tromey.com>
6308
6309         * yy-remap.h: Add include guard.
6310         * xtensa-tdep.h: Add include guard.
6311         * xcoffread.h: Rename include guard.
6312         * varobj-iter.h: Add include guard.
6313         * tui/tui.h: Rename include guard.
6314         * tui/tui-winsource.h: Rename include guard.
6315         * tui/tui-wingeneral.h: Rename include guard.
6316         * tui/tui-windata.h: Rename include guard.
6317         * tui/tui-win.h: Rename include guard.
6318         * tui/tui-stack.h: Rename include guard.
6319         * tui/tui-source.h: Rename include guard.
6320         * tui/tui-regs.h: Rename include guard.
6321         * tui/tui-out.h: Rename include guard.
6322         * tui/tui-layout.h: Rename include guard.
6323         * tui/tui-io.h: Rename include guard.
6324         * tui/tui-hooks.h: Rename include guard.
6325         * tui/tui-file.h: Rename include guard.
6326         * tui/tui-disasm.h: Rename include guard.
6327         * tui/tui-data.h: Rename include guard.
6328         * tui/tui-command.h: Rename include guard.
6329         * tic6x-tdep.h: Add include guard.
6330         * target/waitstatus.h: Rename include guard.
6331         * target/wait.h: Rename include guard.
6332         * target/target.h: Rename include guard.
6333         * target/resume.h: Rename include guard.
6334         * target-float.h: Rename include guard.
6335         * stabsread.h: Add include guard.
6336         * rs6000-tdep.h: Add include guard.
6337         * riscv-fbsd-tdep.h: Add include guard.
6338         * regformats/regdef.h: Rename include guard.
6339         * record.h: Rename include guard.
6340         * python/python.h: Rename include guard.
6341         * python/python-internal.h: Rename include guard.
6342         * python/py-stopevent.h: Rename include guard.
6343         * python/py-ref.h: Rename include guard.
6344         * python/py-record.h: Rename include guard.
6345         * python/py-record-full.h: Rename include guard.
6346         * python/py-record-btrace.h: Rename include guard.
6347         * python/py-instruction.h: Rename include guard.
6348         * python/py-events.h: Rename include guard.
6349         * python/py-event.h: Rename include guard.
6350         * procfs.h: Add include guard.
6351         * proc-utils.h: Add include guard.
6352         * p-lang.h: Add include guard.
6353         * or1k-tdep.h: Rename include guard.
6354         * observable.h: Rename include guard.
6355         * nto-tdep.h: Rename include guard.
6356         * nat/x86-linux.h: Rename include guard.
6357         * nat/x86-linux-dregs.h: Rename include guard.
6358         * nat/x86-gcc-cpuid.h: Add include guard.
6359         * nat/x86-dregs.h: Rename include guard.
6360         * nat/x86-cpuid.h: Rename include guard.
6361         * nat/ppc-linux.h: Rename include guard.
6362         * nat/mips-linux-watch.h: Rename include guard.
6363         * nat/linux-waitpid.h: Rename include guard.
6364         * nat/linux-ptrace.h: Rename include guard.
6365         * nat/linux-procfs.h: Rename include guard.
6366         * nat/linux-osdata.h: Rename include guard.
6367         * nat/linux-nat.h: Rename include guard.
6368         * nat/linux-namespaces.h: Rename include guard.
6369         * nat/linux-btrace.h: Rename include guard.
6370         * nat/glibc_thread_db.h: Rename include guard.
6371         * nat/gdb_thread_db.h: Rename include guard.
6372         * nat/gdb_ptrace.h: Rename include guard.
6373         * nat/fork-inferior.h: Rename include guard.
6374         * nat/amd64-linux-siginfo.h: Rename include guard.
6375         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6376         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6377         * nat/aarch64-linux.h: Rename include guard.
6378         * nat/aarch64-linux-hw-point.h: Rename include guard.
6379         * mn10300-tdep.h: Add include guard.
6380         * mips-linux-tdep.h: Add include guard.
6381         * mi/mi-parse.h: Rename include guard.
6382         * mi/mi-out.h: Rename include guard.
6383         * mi/mi-main.h: Rename include guard.
6384         * mi/mi-interp.h: Rename include guard.
6385         * mi/mi-getopt.h: Rename include guard.
6386         * mi/mi-console.h: Rename include guard.
6387         * mi/mi-common.h: Rename include guard.
6388         * mi/mi-cmds.h: Rename include guard.
6389         * mi/mi-cmd-break.h: Rename include guard.
6390         * m2-lang.h: Add include guard.
6391         * location.h: Rename include guard.
6392         * linux-record.h: Rename include guard.
6393         * linux-nat.h: Add include guard.
6394         * linux-fork.h: Add include guard.
6395         * i386-darwin-tdep.h: Rename include guard.
6396         * hppa-linux-offsets.h: Add include guard.
6397         * guile/guile.h: Rename include guard.
6398         * guile/guile-internal.h: Rename include guard.
6399         * gnu-nat.h: Rename include guard.
6400         * gdb-stabs.h: Rename include guard.
6401         * frv-tdep.h: Add include guard.
6402         * f-lang.h: Add include guard.
6403         * event-loop.h: Add include guard.
6404         * darwin-nat.h: Rename include guard.
6405         * cp-abi.h: Rename include guard.
6406         * config/sparc/nm-sol2.h: Rename include guard.
6407         * config/nm-nto.h: Rename include guard.
6408         * config/nm-linux.h: Add include guard.
6409         * config/i386/nm-i386gnu.h: Rename include guard.
6410         * config/djgpp/nl_types.h: Rename include guard.
6411         * config/djgpp/langinfo.h: Rename include guard.
6412         * compile/gcc-cp-plugin.h: Add include guard.
6413         * compile/gcc-c-plugin.h: Add include guard.
6414         * compile/compile.h: Rename include guard.
6415         * compile/compile-object-run.h: Rename include guard.
6416         * compile/compile-object-load.h: Rename include guard.
6417         * compile/compile-internal.h: Rename include guard.
6418         * compile/compile-cplus.h: Rename include guard.
6419         * compile/compile-c.h: Rename include guard.
6420         * common/xml-utils.h: Rename include guard.
6421         * common/x86-xstate.h: Rename include guard.
6422         * common/version.h: Rename include guard.
6423         * common/vec.h: Rename include guard.
6424         * common/tdesc.h: Rename include guard.
6425         * common/selftest.h: Rename include guard.
6426         * common/scoped_restore.h: Rename include guard.
6427         * common/scoped_mmap.h: Rename include guard.
6428         * common/scoped_fd.h: Rename include guard.
6429         * common/safe-iterator.h: Rename include guard.
6430         * common/run-time-clock.h: Rename include guard.
6431         * common/refcounted-object.h: Rename include guard.
6432         * common/queue.h: Rename include guard.
6433         * common/ptid.h: Rename include guard.
6434         * common/print-utils.h: Rename include guard.
6435         * common/preprocessor.h: Rename include guard.
6436         * common/pathstuff.h: Rename include guard.
6437         * common/observable.h: Rename include guard.
6438         * common/netstuff.h: Rename include guard.
6439         * common/job-control.h: Rename include guard.
6440         * common/host-defs.h: Rename include guard.
6441         * common/gdb_wait.h: Rename include guard.
6442         * common/gdb_vecs.h: Rename include guard.
6443         * common/gdb_unlinker.h: Rename include guard.
6444         * common/gdb_unique_ptr.h: Rename include guard.
6445         * common/gdb_tilde_expand.h: Rename include guard.
6446         * common/gdb_sys_time.h: Rename include guard.
6447         * common/gdb_string_view.h: Rename include guard.
6448         * common/gdb_splay_tree.h: Rename include guard.
6449         * common/gdb_setjmp.h: Rename include guard.
6450         * common/gdb_ref_ptr.h: Rename include guard.
6451         * common/gdb_optional.h: Rename include guard.
6452         * common/gdb_locale.h: Rename include guard.
6453         * common/gdb_assert.h: Rename include guard.
6454         * common/filtered-iterator.h: Rename include guard.
6455         * common/filestuff.h: Rename include guard.
6456         * common/fileio.h: Rename include guard.
6457         * common/environ.h: Rename include guard.
6458         * common/common-utils.h: Rename include guard.
6459         * common/common-types.h: Rename include guard.
6460         * common/common-regcache.h: Rename include guard.
6461         * common/common-inferior.h: Rename include guard.
6462         * common/common-gdbthread.h: Rename include guard.
6463         * common/common-exceptions.h: Rename include guard.
6464         * common/common-defs.h: Rename include guard.
6465         * common/common-debug.h: Rename include guard.
6466         * common/cleanups.h: Rename include guard.
6467         * common/buffer.h: Rename include guard.
6468         * common/btrace-common.h: Rename include guard.
6469         * common/break-common.h: Rename include guard.
6470         * cli/cli-utils.h: Rename include guard.
6471         * cli/cli-style.h: Rename include guard.
6472         * cli/cli-setshow.h: Rename include guard.
6473         * cli/cli-script.h: Rename include guard.
6474         * cli/cli-interp.h: Rename include guard.
6475         * cli/cli-decode.h: Rename include guard.
6476         * cli/cli-cmds.h: Rename include guard.
6477         * charset-list.h: Add include guard.
6478         * buildsym-legacy.h: Rename include guard.
6479         * bfin-tdep.h: Add include guard.
6480         * ax.h: Rename include guard.
6481         * arm-linux-tdep.h: Add include guard.
6482         * arm-fbsd-tdep.h: Add include guard.
6483         * arch/xtensa.h: Rename include guard.
6484         * arch/tic6x.h: Add include guard.
6485         * arch/i386.h: Add include guard.
6486         * arch/arm.h: Rename include guard.
6487         * arch/arm-linux.h: Rename include guard.
6488         * arch/arm-get-next-pcs.h: Rename include guard.
6489         * arch/amd64.h: Add include guard.
6490         * arch/aarch64-insn.h: Rename include guard.
6491         * arch-utils.h: Rename include guard.
6492         * annotate.h: Add include guard.
6493         * amd64-darwin-tdep.h: Rename include guard.
6494         * aarch64-linux-tdep.h: Add include guard.
6495         * aarch64-fbsd-tdep.h: Add include guard.
6496         * aarch32-linux-nat.h: Add include guard.
6497
6498 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6499
6500         * macrotab.c (macro_define_internal): New function that
6501         factorizes macro_define_object_internal and macro_define_function
6502         code.
6503         (macro_define_object_internal): Use macro_define_internal.
6504         (macro_define_function): Likewise.
6505
6506 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6507
6508         * macrocmd.c (extract_identifier): Return
6509         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6510         callers.
6511
6512 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6513
6514         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6515
6516 2019-02-05  Tom Tromey  <tom@tromey.com>
6517
6518         * target.c (target_stack::unpush): Move assertion earlier.
6519
6520 2019-01-30  Tom Tromey  <tom@tromey.com>
6521
6522         PR python/23615:
6523         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6524         (gdbpy_parse_and_eval): Likewise.
6525         * python/python-internal.h (gdbpy_allow_threads): New class.
6526
6527 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6528
6529         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6530         (aarch64_fbsd_fpregmap): Move earlier.
6531         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6532         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6533         instead of individual calls to trad_frame_set_reg_addr.
6534         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6535         earlier.
6536         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6537         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6538         instead of individual calls to trad_frame_set_reg_addr.
6539
6540 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6541
6542         * CONTRIBUTE: Replace contribution list with wiki link.
6543
6544 2019-01-25  Tom Tromey  <tom@tromey.com>
6545
6546         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6547
6548 2019-01-25  Tom Tromey  <tom@tromey.com>
6549
6550         * xtensa-linux-nat.c: Fix common/ includes.
6551         * xml-support.h: Fix common/ includes.
6552         * xml-support.c: Fix common/ includes.
6553         * x86-linux-nat.c: Fix common/ includes.
6554         * windows-nat.c: Fix common/ includes.
6555         * varobj.h: Fix common/ includes.
6556         * varobj.c: Fix common/ includes.
6557         * value.c: Fix common/ includes.
6558         * valops.c: Fix common/ includes.
6559         * utils.c: Fix common/ includes.
6560         * unittests/xml-utils-selftests.c: Fix common/ includes.
6561         * unittests/utils-selftests.c: Fix common/ includes.
6562         * unittests/unpack-selftests.c: Fix common/ includes.
6563         * unittests/tracepoint-selftests.c: Fix common/ includes.
6564         * unittests/style-selftests.c: Fix common/ includes.
6565         * unittests/string_view-selftests.c: Fix common/ includes.
6566         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6567         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6568         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6569         * unittests/rsp-low-selftests.c: Fix common/ includes.
6570         * unittests/parse-connection-spec-selftests.c: Fix common/
6571         includes.
6572         * unittests/optional-selftests.c: Fix common/ includes.
6573         * unittests/offset-type-selftests.c: Fix common/ includes.
6574         * unittests/observable-selftests.c: Fix common/ includes.
6575         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6576         * unittests/memrange-selftests.c: Fix common/ includes.
6577         * unittests/memory-map-selftests.c: Fix common/ includes.
6578         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6579         * unittests/function-view-selftests.c: Fix common/ includes.
6580         * unittests/environ-selftests.c: Fix common/ includes.
6581         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6582         * unittests/common-utils-selftests.c: Fix common/ includes.
6583         * unittests/cli-utils-selftests.c: Fix common/ includes.
6584         * unittests/array-view-selftests.c: Fix common/ includes.
6585         * ui-file.c: Fix common/ includes.
6586         * tui/tui-io.c: Fix common/ includes.
6587         * tracepoint.h: Fix common/ includes.
6588         * tracepoint.c: Fix common/ includes.
6589         * tracefile-tfile.c: Fix common/ includes.
6590         * top.h: Fix common/ includes.
6591         * top.c: Fix common/ includes.
6592         * thread.c: Fix common/ includes.
6593         * target/waitstatus.h: Fix common/ includes.
6594         * target/waitstatus.c: Fix common/ includes.
6595         * target.h: Fix common/ includes.
6596         * target.c: Fix common/ includes.
6597         * target-memory.c: Fix common/ includes.
6598         * target-descriptions.c: Fix common/ includes.
6599         * symtab.h: Fix common/ includes.
6600         * symfile.c: Fix common/ includes.
6601         * stap-probe.c: Fix common/ includes.
6602         * spu-linux-nat.c: Fix common/ includes.
6603         * sparc-nat.c: Fix common/ includes.
6604         * source.c: Fix common/ includes.
6605         * solib.c: Fix common/ includes.
6606         * solib-target.c: Fix common/ includes.
6607         * ser-unix.c: Fix common/ includes.
6608         * ser-tcp.c: Fix common/ includes.
6609         * ser-pipe.c: Fix common/ includes.
6610         * ser-base.c: Fix common/ includes.
6611         * selftest-arch.c: Fix common/ includes.
6612         * s12z-tdep.c: Fix common/ includes.
6613         * rust-exp.y: Fix common/ includes.
6614         * rs6000-aix-tdep.c: Fix common/ includes.
6615         * riscv-tdep.c: Fix common/ includes.
6616         * remote.c: Fix common/ includes.
6617         * remote-notif.h: Fix common/ includes.
6618         * remote-fileio.h: Fix common/ includes.
6619         * remote-fileio.c: Fix common/ includes.
6620         * regcache.h: Fix common/ includes.
6621         * regcache.c: Fix common/ includes.
6622         * record-btrace.c: Fix common/ includes.
6623         * python/python.c: Fix common/ includes.
6624         * python/py-type.c: Fix common/ includes.
6625         * python/py-inferior.c: Fix common/ includes.
6626         * progspace.h: Fix common/ includes.
6627         * producer.c: Fix common/ includes.
6628         * procfs.c: Fix common/ includes.
6629         * proc-api.c: Fix common/ includes.
6630         * printcmd.c: Fix common/ includes.
6631         * ppc-linux-nat.c: Fix common/ includes.
6632         * parser-defs.h: Fix common/ includes.
6633         * osdata.c: Fix common/ includes.
6634         * obsd-nat.c: Fix common/ includes.
6635         * nat/x86-linux.c: Fix common/ includes.
6636         * nat/x86-linux-dregs.c: Fix common/ includes.
6637         * nat/x86-dregs.h: Fix common/ includes.
6638         * nat/x86-dregs.c: Fix common/ includes.
6639         * nat/ppc-linux.c: Fix common/ includes.
6640         * nat/mips-linux-watch.h: Fix common/ includes.
6641         * nat/mips-linux-watch.c: Fix common/ includes.
6642         * nat/linux-waitpid.c: Fix common/ includes.
6643         * nat/linux-ptrace.h: Fix common/ includes.
6644         * nat/linux-ptrace.c: Fix common/ includes.
6645         * nat/linux-procfs.c: Fix common/ includes.
6646         * nat/linux-personality.c: Fix common/ includes.
6647         * nat/linux-osdata.c: Fix common/ includes.
6648         * nat/linux-namespaces.c: Fix common/ includes.
6649         * nat/linux-btrace.h: Fix common/ includes.
6650         * nat/linux-btrace.c: Fix common/ includes.
6651         * nat/fork-inferior.c: Fix common/ includes.
6652         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6653         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6654         * nat/aarch64-linux.c: Fix common/ includes.
6655         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6656         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6657         * namespace.h: Fix common/ includes.
6658         * mips-linux-tdep.c: Fix common/ includes.
6659         * minsyms.c: Fix common/ includes.
6660         * mi/mi-parse.h: Fix common/ includes.
6661         * mi/mi-main.c: Fix common/ includes.
6662         * mi/mi-cmd-env.c: Fix common/ includes.
6663         * memrange.h: Fix common/ includes.
6664         * memattr.c: Fix common/ includes.
6665         * maint.h: Fix common/ includes.
6666         * maint.c: Fix common/ includes.
6667         * main.c: Fix common/ includes.
6668         * machoread.c: Fix common/ includes.
6669         * location.c: Fix common/ includes.
6670         * linux-thread-db.c: Fix common/ includes.
6671         * linux-nat.c: Fix common/ includes.
6672         * linux-fork.c: Fix common/ includes.
6673         * inline-frame.c: Fix common/ includes.
6674         * infrun.c: Fix common/ includes.
6675         * inflow.c: Fix common/ includes.
6676         * inferior.h: Fix common/ includes.
6677         * inferior.c: Fix common/ includes.
6678         * infcmd.c: Fix common/ includes.
6679         * inf-ptrace.c: Fix common/ includes.
6680         * inf-child.c: Fix common/ includes.
6681         * ia64-linux-nat.c: Fix common/ includes.
6682         * i387-tdep.c: Fix common/ includes.
6683         * i386-tdep.c: Fix common/ includes.
6684         * i386-linux-tdep.c: Fix common/ includes.
6685         * i386-linux-nat.c: Fix common/ includes.
6686         * i386-go32-tdep.c: Fix common/ includes.
6687         * i386-fbsd-tdep.c: Fix common/ includes.
6688         * i386-fbsd-nat.c: Fix common/ includes.
6689         * guile/scm-type.c: Fix common/ includes.
6690         * guile/guile.c: Fix common/ includes.
6691         * go32-nat.c: Fix common/ includes.
6692         * gnu-nat.c: Fix common/ includes.
6693         * gdbthread.h: Fix common/ includes.
6694         * gdbarch-selftests.c: Fix common/ includes.
6695         * gdb_usleep.c: Fix common/ includes.
6696         * gdb_select.h: Fix common/ includes.
6697         * gdb_bfd.c: Fix common/ includes.
6698         * gcore.c: Fix common/ includes.
6699         * fork-child.c: Fix common/ includes.
6700         * findvar.c: Fix common/ includes.
6701         * fbsd-nat.c: Fix common/ includes.
6702         * event-top.c: Fix common/ includes.
6703         * event-loop.c: Fix common/ includes.
6704         * dwarf2read.c: Fix common/ includes.
6705         * dwarf2loc.c: Fix common/ includes.
6706         * dwarf2-frame.c: Fix common/ includes.
6707         * dwarf-index-cache.c: Fix common/ includes.
6708         * dtrace-probe.c: Fix common/ includes.
6709         * disasm-selftests.c: Fix common/ includes.
6710         * defs.h: Fix common/ includes.
6711         * csky-tdep.c: Fix common/ includes.
6712         * cp-valprint.c: Fix common/ includes.
6713         * cp-support.h: Fix common/ includes.
6714         * cp-support.c: Fix common/ includes.
6715         * corelow.c: Fix common/ includes.
6716         * completer.h: Fix common/ includes.
6717         * completer.c: Fix common/ includes.
6718         * compile/compile.c: Fix common/ includes.
6719         * compile/compile-loc2c.c: Fix common/ includes.
6720         * compile/compile-cplus-types.c: Fix common/ includes.
6721         * compile/compile-cplus-symbols.c: Fix common/ includes.
6722         * command.h: Fix common/ includes.
6723         * cli/cli-dump.c: Fix common/ includes.
6724         * cli/cli-cmds.c: Fix common/ includes.
6725         * charset.c: Fix common/ includes.
6726         * build-id.c: Fix common/ includes.
6727         * btrace.h: Fix common/ includes.
6728         * btrace.c: Fix common/ includes.
6729         * breakpoint.h: Fix common/ includes.
6730         * breakpoint.c: Fix common/ includes.
6731         * ax.h:
6732         (enum agent_op): Fix common/ includes.
6733         * ax-general.c (struct aop_map): Fix common/ includes.
6734         * ax-gdb.c: Fix common/ includes.
6735         * auxv.c: Fix common/ includes.
6736         * auto-load.c: Fix common/ includes.
6737         * arm-tdep.c: Fix common/ includes.
6738         * arch/riscv.c: Fix common/ includes.
6739         * arch/ppc-linux-common.c: Fix common/ includes.
6740         * arch/i386.c: Fix common/ includes.
6741         * arch/arm.c: Fix common/ includes.
6742         * arch/arm-linux.c: Fix common/ includes.
6743         * arch/arm-get-next-pcs.c: Fix common/ includes.
6744         * arch/amd64.c: Fix common/ includes.
6745         * arch/aarch64.c: Fix common/ includes.
6746         * arch/aarch64-insn.c: Fix common/ includes.
6747         * arch-utils.c: Fix common/ includes.
6748         * amd64-windows-tdep.c: Fix common/ includes.
6749         * amd64-tdep.c: Fix common/ includes.
6750         * amd64-sol2-tdep.c: Fix common/ includes.
6751         * amd64-obsd-tdep.c: Fix common/ includes.
6752         * amd64-nbsd-tdep.c: Fix common/ includes.
6753         * amd64-linux-tdep.c: Fix common/ includes.
6754         * amd64-linux-nat.c: Fix common/ includes.
6755         * amd64-fbsd-tdep.c: Fix common/ includes.
6756         * amd64-fbsd-nat.c: Fix common/ includes.
6757         * amd64-dicos-tdep.c: Fix common/ includes.
6758         * amd64-darwin-tdep.c: Fix common/ includes.
6759         * agent.c: Fix common/ includes.
6760         * ada-lang.h: Fix common/ includes.
6761         * ada-lang.c: Fix common/ includes.
6762         * aarch64-tdep.c: Fix common/ includes.
6763
6764 2019-01-25  Tom Tromey  <tom@tromey.com>
6765
6766         * common/create-version.sh: Use common/version.h.
6767
6768 2019-01-24  Pedro Alves  <palves@redhat.com>
6769
6770         * infrun.c (signal_stop, signal_print, signal_program)
6771         (signal_catch, signal_pass): Now arrays instead of pointers.
6772         (update_signals_program_target, do_target_resume)
6773         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6774         * linux-nat.c (linux_nat_target::pass_signals)
6775         (linux_nat_target::create_inferior, linux_nat_target::attach):
6776         Adjust.
6777         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6778         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6779         * procfs.c (procfs_target::pass_signals): Adjust.
6780         * record-full.c (record_full_target::resume): Adjust.
6781         * remote.c (remote_target::pass_signals)
6782         (remote_target::program_signals): Adjust.
6783         * target-debug.h (target_debug_print_signals): Now takes a
6784         gdb::array_view as parameter.  Adjust.
6785         * target.h (target_ops) <pass_signals, program_signals>: Replace
6786         pointer and length parameters with gdb::array_view.
6787         (target_pass_signals, target_program_signals): Likewise.
6788         * target-delegates.c: Regenerate.
6789
6790 2019-01-24  Pedro Alves  <palves@redhat.com>
6791
6792         * common/forward-scope-exit.h
6793         (forward_scope_exit::forward_scope_exit): Pass arguments to
6794         m_bind_function directly, instead of creating a std::bind and
6795         copying that.
6796
6797 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6798
6799         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6800         for static members.
6801         (pass_in_v_vfp_candidate): Likewise.
6802
6803 2019-01-23  Tom Tromey  <tom@tromey.com>
6804             Pedro Alves  <palves@redhat.com>
6805
6806         * regcache.c (class regcache_invalidator): Remove.
6807         (regcache::raw_write): Use make_scope_exit.
6808
6809 2019-01-23  Tom Tromey  <tom@tromey.com>
6810
6811         * ui-out.h (class ui_out_emit_type): Update comment.
6812
6813 2019-01-23  Tom Tromey  <tom@tromey.com>
6814
6815         * infrun.c (fetch_inferior_event): Update comment.
6816
6817 2019-01-23  Tom Tromey  <tom@tromey.com>
6818             Pedro Alves  <palves@redhat.com>
6819
6820         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6821         parameter.
6822         (fetch_inferior_event): Use SCOPE_EXIT.
6823
6824
6825 2019-01-23  Tom Tromey  <tom@tromey.com>
6826             Pedro Alves  <palves@redhat.com>
6827
6828         * infrun.c (disable_thread_events): Delete.
6829         (stop_all_threads): Use SCOPE_EXIT.
6830
6831 2019-01-23  Tom Tromey  <tom@tromey.com>
6832             Pedro Alves  <palves@redhat.com>
6833
6834         * symfile.c: Include forward-scope-exit.h.
6835         (clear_symtab_users_cleanup): Replace forward declaration with
6836         a FORWARD_SCOPE_EXIT.
6837         (syms_from_objfile_1): Use the forward_scope_exit and
6838         gdb::optional instead of cleanup_function.
6839         (reread_symbols): Use the forward_scope_exit instead of
6840         cleanup_function.
6841         (clear_symtab_users_cleanup): Remove function.
6842
6843 2019-01-23  Tom Tromey  <tom@tromey.com>
6844             Pedro Alves  <palves@redhat.com>
6845
6846         * linux-nat.c: Include scope-exit.h.
6847         (cleanup_target_stop): Remove.
6848         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6849         SCOPE_EXIT.
6850
6851 2019-01-23  Tom Tromey  <tom@tromey.com>
6852             Pedro Alves  <palves@redhat.com>
6853
6854         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6855         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6856
6857 2019-01-23  Tom Tromey  <tom@tromey.com>
6858             Andrew Burgess  <andrew.burgess@embecosm.com>
6859             Pedro Alves  <palves@redhat.com>
6860
6861         * infrun.c (fetch_inferior_event): Use scope_exit.
6862         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6863         * top.c (execute_command): Use scope_exit.
6864         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6865         * utils.c (do_bpstat_clear_actions_cleanup)
6866         (make_bpstat_clear_actions_cleanup): Remove.
6867
6868 2019-01-23  Tom Tromey  <tom@tromey.com>
6869             Pedro Alves  <palves@redhat.com>
6870
6871         * infrun.c: Include "common/scope-exit.h"
6872         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6873         (wait_for_inferior): Use SCOPE_EXIT.
6874         (fetch_inferior_event): Use scope_exit.
6875
6876 2019-01-23  Tom Tromey  <tom@tromey.com>
6877             Pedro Alves  <palves@redhat.com>
6878
6879         * breakpoint.c (create_breakpoint): Remove cleanup.
6880
6881 2019-01-23  Tom Tromey  <tom@tromey.com>
6882             Andrew Burgess  <andrew.burgess@embecosm.com>
6883             Pedro Alves  <palves@redhat.com>
6884
6885 2019-01-23  Pedro Alves  <palves@redhat.com>
6886
6887         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6888
6889 2019-01-23  Pedro Alves  <palves@redhat.com>
6890             Andrew Burgess  <andrew.burgess@embecosm.com>
6891
6892         * gdbthread.h: Include "common/forward-scope-exit.h".
6893         (scoped_finish_thread_state): Redefine custom class in terms of
6894         forward_scope_exit.
6895
6896 2019-01-23  Pedro Alves  <palves@redhat.com>
6897             Andrew Burgess  <andrew.burgess@embecosm.com>
6898
6899         * common/forward-scope-exit.h: New file.
6900
6901 2019-01-23  Pedro Alves  <palves@redhat.com>
6902             Andrew Burgess  <andrew.burgess@embecosm.com>
6903             Tom Tromey  <tom@tromey.com>
6904
6905         * common/scope-exit.h: New file.
6906
6907 2019-01-23  Pedro Alves  <palves@redhat.com>
6908
6909         * common/preprocessor.h (ESC): Rename to ...
6910         (ESC_PARENS): ... this.
6911         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6912         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6913
6914 2019-01-23  Tom Tromey  <tom@tromey.com>
6915
6916         * language.h (class scoped_switch_to_sym_language_if_auto):
6917         Initialize m_lang in both cases.
6918
6919 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6920
6921         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6922         with XCNEW.
6923
6924 2019-01-22  Tom Tromey  <tom@tromey.com>
6925
6926         * corelow.c: Do not include sys/file.h.
6927
6928 2019-01-22  Tom Tromey  <tom@tromey.com>
6929
6930         * tui/tui-wingeneral.h: Include gdb_curses.h.
6931
6932 2019-01-22  Tom Tromey  <tom@tromey.com>
6933
6934         * source-cache.h (class source_cache) <get_source_lines,
6935         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6936
6937 2019-01-22  Tom Tromey  <tom@tromey.com>
6938
6939         * remote-fileio.h (struct remote_target): Declare.
6940
6941 2019-01-22  Tom Tromey  <tom@tromey.com>
6942
6943         * python/py-arch.c: Do not include py-ref.h.
6944         * python/py-bpevent.c: Do not include py-ref.h.
6945         * python/py-cmd.c: Do not include py-ref.h.
6946         * python/py-continueevent.c: Do not include py-ref.h.
6947         * python/py-event.h: Do not include py-ref.h.
6948         * python/py-evtregistry.c: Do not include py-ref.h.
6949         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6950         * python/py-frame.c: Do not include py-ref.h.
6951         * python/py-framefilter.c: Do not include py-ref.h.
6952         * python/py-function.c: Do not include py-ref.h.
6953         * python/py-infevents.c: Do not include py-ref.h.
6954         * python/py-linetable.c: Do not include py-ref.h.
6955         * python/py-objfile.c: Do not include py-ref.h.
6956         * python/py-param.c: Do not include py-ref.h.
6957         * python/py-prettyprint.c: Do not include py-ref.h.
6958         * python/py-progspace.c: Do not include py-ref.h.
6959         * python/py-symbol.c: Do not include py-ref.h.
6960         * python/py-symtab.c: Do not include py-ref.h.
6961         * python/py-type.c: Do not include py-ref.h.
6962         * python/py-unwind.c: Do not include py-ref.h.
6963         * python/py-utils.c: Do not include py-ref.h.
6964         * python/py-value.c: Do not include py-ref.h.
6965         * python/py-varobj.c: Do not include py-ref.h.
6966         * python/py-xmethods.c: Do not include py-ref.h.
6967         * python/python.c: Do not include py-ref.h.
6968         * varobj.c: Do not include py-ref.h.
6969
6970 2019-01-22  Tom Tromey  <tom@tromey.com>
6971
6972         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6973         keyword for bcache.
6974
6975 2019-01-22  Tom Tromey  <tom@tromey.com>
6976
6977         * compile/compile-cplus-types.c: Remove a comment by #include.
6978
6979 2019-01-22  Tom Tromey  <tom@tromey.com>
6980
6981         * compile/gcc-c-plugin.h: Include compile-internal.h.
6982
6983 2019-01-22  Tom Tromey  <tom@tromey.com>
6984
6985         * stabsread.c (EXTERN): Do not define.
6986         (symnum, next_symbol_text_func, processing_gcc_compilation)
6987         (within_function, global_sym_chain, global_stabs)
6988         (previous_stab_code, this_object_header_files)
6989         (n_this_object_header_files)
6990         (n_allocated_this_object_header_files): Define.
6991         * stabsread.h (EXTERN): Never define.  Use "extern".
6992
6993 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6994
6995         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6996         history_value.
6997
6998 2019-01-21  Tom Tromey  <tom@tromey.com>
6999
7000         * ui-out.c: Fix includes.
7001         * tui/tui-source.c: Fix includes.
7002         * target.c: Fix includes.
7003         * remote.c: Fix includes.
7004         * regcache.c: Fix includes.
7005         * python/py-block.c: Fix includes.
7006         * printcmd.c: Fix includes.
7007         * or1k-tdep.c: Fix includes.
7008         * mi/mi-main.c: Fix includes.
7009         * m32r-tdep.c: Fix includes.
7010         * csky-tdep.c: Fix includes.
7011         * compile/compile-cplus-types.c: Fix includes.
7012         * cli/cli-interp.c: Fix includes.
7013
7014 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7015
7016         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7017         for padding.
7018
7019 2019-01-16  Tom Tromey  <tom@tromey.com>
7020
7021         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7022         earlier.
7023         (struct objfile) <msymbols_range>: Move from top level.
7024         <msymbols>: New method.
7025         (class objfile_msymbols): Remove.
7026         * symtab.c (default_collect_symbol_completion_matches_break_on):
7027         Update.
7028         * symmisc.c (dump_msymbols): Update.
7029         * stabsread.c (scan_file_globals): Update.
7030         * objc-lang.c (info_selectors_command, info_classes_command)
7031         (find_methods): Update.
7032         * minsyms.c (find_solib_trampoline_target): Update.
7033         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7034         * coffread.c (coff_symfile_read): Update.
7035         * ada-lang.c (ada_lookup_simple_minsym)
7036         (ada_collect_symbol_completion_matches): Update.
7037
7038 2019-01-16  Tom Tromey  <tom@tromey.com>
7039
7040         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7041         type.  Remove no-argument constructor.
7042         <iterator::operator++>: Simplify.
7043         <begin>: Update.
7044         <end>: Use minimal_symbol_count.
7045
7046 2019-01-16  Tom Tromey  <tom@tromey.com>
7047
7048         * objfiles.h (struct objfile) <psymtabs>: New method.
7049         (class objfile_psymtabs): Remove.
7050         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7051         typedef.
7052         <range>: New method.
7053         (require_partial_symbols): Change return type.
7054         * psymtab.c (require_partial_symbols)
7055         (psym_expand_symtabs_matching): Update.
7056         * mdebugread.c (parse_partial_symbols): Update.
7057         * dbxread.c (dbx_end_psymtab): Update.
7058
7059 2019-01-15  Tom Tromey  <tom@tromey.com>
7060
7061         * symtab.c (lookup_objfile_from_block)
7062         (lookup_symbol_in_objfile_symtabs)
7063         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7064         (find_line_symtab, info_sources_command)
7065         (default_collect_symbol_completion_matches_break_on)
7066         (make_source_files_completion_list): Update.
7067         * symmisc.c (print_objfile_statistics, dump_objfile)
7068         (maintenance_print_symbols, maintenance_info_symtabs)
7069         (maintenance_check_symtabs, maintenance_info_line_tables):
7070         Update.
7071         * source.c (select_source_symtab)
7072         (forget_cached_source_info_for_objfile): Update.
7073         * objfiles.h (class objfile_compunits): Remove.
7074         (struct objfile) <compunits_range>: New typedef.
7075         (compunits): New method.
7076         * objfiles.c (objfile_relocate1): Update.
7077         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7078         * maint.c (count_symtabs_and_blocks): Update.
7079         * linespec.c (iterate_over_all_matching_symtabs): Update.
7080         * cp-support.c (add_symbol_overload_list_qualified): Update.
7081         * coffread.c (coff_symtab_read): Update.
7082         * ada-lang.c (add_nonlocal_symbols)
7083         (ada_collect_symbol_completion_matches)
7084         (ada_add_global_exceptions): Update.
7085
7086 2019-01-15  Tom Tromey  <tom@tromey.com>
7087
7088         * progspace.h (program_space) <objfiles_safe_range>: New
7089         typedef.
7090         <objfiles_safe>: New method.
7091         * objfiles.h (class all_objfiles_safe): Remove.
7092         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7093         * jit.c (jit_inferior_exit_hook): Update.
7094
7095 2019-01-17  Tom Tromey  <tom@tromey.com>
7096
7097         * progspace.h (program_space) <objfiles_range>: New typedef.
7098         <objfiles>: New method.
7099         <objfiles_head>: Rename from objfiles.
7100         (object_files): Update.
7101         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7102         * guile/scm-pretty-print.c
7103         (ppscm_find_pretty_printer_from_objfiles): Update.
7104         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7105         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7106         Update.
7107         * python/py-progspace.c (pspy_get_objfiles): Update.
7108         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7109         Update.
7110         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7111         (objfpy_lookup_objfile_by_build_id): Update.
7112         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7113         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7114         Update.
7115         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7116         (expand_symtab_containing_pc, lookup_objfile_from_block)
7117         (lookup_static_symbol, basic_lookup_transparent_type)
7118         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7119         (find_line_symtab, info_sources_command)
7120         (default_collect_symbol_completion_matches_break_on)
7121         (make_source_files_completion_list, find_main_name): Update.
7122         * symmisc.c (print_symbol_bcache_statistics)
7123         (print_objfile_statistics, maintenance_print_symbols)
7124         (maintenance_print_msymbols, maintenance_print_objfiles)
7125         (maintenance_info_symtabs, maintenance_check_symtabs)
7126         (maintenance_expand_symtabs, maintenance_info_line_tables):
7127         Update.
7128         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7129         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7130         (map_overlay_command, unmap_overlay_command)
7131         (simple_overlay_update, expand_symtabs_matching)
7132         (map_symbol_filenames): Update.
7133         * symfile-debug.c (set_debug_symfile): Update.
7134         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7135         Update.
7136         * source.c (select_source_symtab, forget_cached_source_info):
7137         Update.
7138         * solib.c (solib_read_symbols): Update.
7139         * solib-spu.c (append_ocl_sos): Update.
7140         * psymtab.c (maintenance_print_psymbols)
7141         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7142         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7143         * printcmd.c (info_symbol_command): Update.
7144         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7145         Update.
7146         * objfiles.h (class all_objfiles): Remove.
7147         * objfiles.c (have_partial_symbols, have_full_symbols)
7148         (have_minimal_symbols, qsort_cmp, update_section_map)
7149         (shared_objfile_contains_address_p)
7150         (default_iterate_over_objfiles_in_search_order): Update.
7151         * objc-lang.c (info_selectors_command, info_classes_command)
7152         (find_methods): Update.
7153         * minsyms.c (find_solib_trampoline_target): Update.
7154         * maint.c (maintenance_info_sections)
7155         (maintenance_translate_address, count_symtabs_and_blocks):
7156         Update.
7157         * main.c (captured_main_1): Update.
7158         * linux-thread-db.c (try_thread_db_load_from_pdir)
7159         (has_libpthread): Update.
7160         * linespec.c (iterate_over_all_matching_symtabs)
7161         (search_minsyms_for_name): Update.
7162         * jit.c (jit_find_objf_with_entry_addr): Update.
7163         * hppa-tdep.c (find_unwind_entry)
7164         (hppa_lookup_stub_minimal_symbol): Update.
7165         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7166         Update.
7167         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7168         (elf_gnu_ifunc_resolve_by_got): Update.
7169         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7170         * dwarf-index-write.c (save_gdb_index_command): Update.
7171         * cp-support.c (add_symbol_overload_list_qualified): Update.
7172         * breakpoint.c (create_overlay_event_breakpoint)
7173         (create_longjmp_master_breakpoint)
7174         (create_std_terminate_master_breakpoint)
7175         (create_exception_master_breakpoint): Update.
7176         * blockframe.c (find_pc_partial_function): Update.
7177         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7178         (ada_collect_symbol_completion_matches)
7179         (ada_add_global_exceptions): Update.
7180
7181 2019-01-17  Tom Tromey  <tom@tromey.com>
7182
7183         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7184         declare VEC.
7185         (solib_target_parse_libraries): Change return type.
7186         (library_list_start_segment, library_list_start_section)
7187         (library_list_end_library, library_list_start_library); Update.
7188         (solib_target_free_library_list): Remove.
7189         (solib_target_parse_libraries): Remove cleanup.  Change return
7190         type.
7191         (solib_target_current_sos): Update.
7192
7193 2019-01-17  Tom Tromey  <tromey@bapiya>
7194
7195         * valprint.c: Replace "the the" with "the".
7196         * symtab.c: Replace "the the" with "the".
7197         * solib.c: Replace "the the" with "the".
7198         * solib-dsbt.c: Replace "the the" with "the".
7199         * linespec.c: Replace "the the" with "the".
7200         * dwarf2loc.h: Replace "the the" with "the".
7201         * amd64-windows-tdep.c: Replace "the the" with "the".
7202         * aarch64-tdep.c: Replace "the the" with "the".
7203
7204 2019-01-16  Keith Seitz  <keiths@redhat.com>
7205
7206         PR gdb/23773
7207         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7208         <builder>: Rename to ..
7209         <m_builder>: ... this and make private.
7210         (dwarf2_cu::get_builder): New method.  Change all users of
7211         `builder' to use this method.
7212         (dwarf2_start_symtab): Move to ...
7213         (dwarf2_cu::start_symtab): ... here.  Update all callers
7214         (setup_type_unit_groups): Move to ...
7215         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7216         callers.
7217         (dwarf2_cu::reset_builder): New method.
7218         (process_full_compunit, process_full_type_unit): Use
7219         dwarf2_cu::reset_builder.
7220         (follow_die_offset): Record the ancestor CU if it is different
7221         from the followed DIE's CU.
7222         (follow_die_sig_1): Likewise.
7223
7224 2019-01-15  Tom Tromey  <tom@tromey.com>
7225
7226         * remote.c (class remote_state) <buf>: Now a char_vector.
7227         <buf_size>: Remove.
7228         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7229         parameter.
7230         (remote_target::getpkt_or_notif_sane_1)
7231         (remote_target::getpkt_sane)
7232         (remote_target::getpkt_or_notif_sane): Likewise.
7233         (class remote_target) <putpkt>: New overload.
7234         (remote_target::read_frame): Change type of "buf_p".  Remove
7235         sizeof_p parameter.
7236         (packet_ok): New overload.
7237         (packet_check_result): New overload.
7238         Update all uses.
7239
7240 2019-01-14  Tom Tromey  <tom@tromey.com>
7241
7242         * remote-notif.c (handle_notification, remote_notif_ack)
7243         (remote_notif_parse): Make "buf" const.
7244         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7245         const.
7246         (remote_notif_parse, remote_notif_ack, handle_notification):
7247         Likewise.
7248         * remote.c (remote_notif_stop_parse): Make "buf" const.
7249         (remote_target::remote_parse_stop_reply): Make "buf" const.
7250         (remote_notif_stop_ack): Make "buf" const.
7251
7252 2019-01-14  Tom Tromey  <tom@tromey.com>
7253
7254         * remote.c (remote_console_output): Make parameter const.
7255
7256 2019-01-14  Tom Tromey  <tom@tromey.com>
7257
7258         * target-debug.h (target_debug_print_signals): Constify.
7259         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7260         * procfs.c (procfs_target::pass_signals): Update.
7261         * linux-nat.c (linux_nat_target::pass_signals): Update.
7262         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7263         * target-delegates.c: Rebuild.
7264         * remote.c (remote_target::program_signals): Update.
7265         (remote_target::pass_signals): Update.
7266         * target.c (target_pass_signals): Constify argument.
7267         (target_program_signals): Likewise.
7268         * target.h (struct target_ops) <pass_signals, program_signals>:
7269         Constify argument.
7270         (target_pass_signals, target_program_signals): Constify argument.
7271
7272 2019-01-14  Tom Tromey  <tom@tromey.com>
7273
7274         PR tui/28819:
7275         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7276
7277 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7278
7279         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7280         field.
7281         * rs6000-tdep.c: Include reggroups.h.
7282         (IS_V_ALIAS_PSEUDOREG): Define.
7283         (rs6000_register_name): Return names for the "vX" aliases.
7284         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7285         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7286         aliases.  Call default_register_reggroup_p for all other
7287         pseudo-registers.
7288         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7289         New functions.
7290         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7291         Handle "vX" aliases.
7292         (v_alias_pseudo_register_collect): New function.
7293         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7294         (rs6000_gdbarch_init): Initialize "vX" aliases as
7295         pseudo-registers.  Restore registration of
7296         rs6000_pseudo_register_reggroup_p with
7297         set_tdesc_pseudo_register_reggroup_p.
7298
7299 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7300
7301         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7302         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7303         set_gdbarch_num_pseudo_regs.
7304
7305 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7306
7307         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7308         Remove arg prefixname, add do_set and do_show.
7309         Add member functions set_list and show_list.
7310         * cli/cli-style.c (class cli_style_option): Update accordingly.
7311         (style_set_list): Move to file scope.
7312         (style_show_list): Likewise.
7313         (set_style): Call help_list.
7314         (show_style): Call cmd_show_list.
7315         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7316         Update to use the new macro.
7317
7318 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7319
7320         * ada-lang.c (_initialize_ada_language): Expand the help text
7321         for the "catch exception" command.
7322
7323 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7324
7325         * symtab.c (matching_obj_sections): Initialize obj,
7326         declare it closer to its usage.
7327
7328 2019-01-10  Tom Tromey  <tom@tromey.com>
7329
7330         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7331         (basic_inf_threads_range): Remove.
7332         (inf_threads_range, inf_non_exited_threads_range)
7333         (safe_inf_threads_range): Use next_adapter.
7334
7335 2019-01-10  Keith Seitz  <keiths@redhat.com>
7336
7337         PR gdb/23712
7338         PR symtab/23010
7339         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7340         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7341
7342 2019-01-10  Keith Seitz  <keiths@redhat.com>
7343
7344         PR gdb/23712
7345         PR symtab/23010
7346         * dictionary.c (pending_to_vector): Remove.
7347         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7348         Remove _1 suffix, replacing functions of the same name.  Update
7349         all callers.
7350         (dict_create_hashed, dict_create_hashed_expandable)
7351         (dict_create_linear, dict_create_linear_expandable, dict_free)
7352         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7353         Make functions static.
7354
7355 2019-01-10  Keith Seitz  <keiths@redhat.com>
7356
7357         PR gdb/23712
7358         PR symtab/23010
7359         * dictionary.h (struct dictionary): Replace declaration with
7360         multidictionary.
7361         (dict_create_hashed, dict_create_hashed_expandable)
7362         (dict_create_linear, dict_create_linear_expandable)
7363         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7364         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7365         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7366         taking multidictionary argument.
7367         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7368         * block.h (struct block) <dict>: Change to multidictionary
7369         and rename `multidict'.
7370         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7371         symmisc.c: Update all dictionary references to multidictionary.
7372
7373 2019-01-10  Keith Seitz  <keiths@redhat.com>
7374
7375         PR gdb/23712
7376         PR symtab/23010
7377         * dictionary.c: Include unordered_map.
7378         (pending_to_vector): New function.
7379         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7380         Rewrite the non-"_1" functions to take vector instead
7381         of linked list.
7382         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7383         "new" _1 versions of the same name.
7384         (multidictionary): Define.
7385         (std::hash<enum language): New definition.
7386         (collate_pending_symbols_by_language, mdict_create_hashed)
7387         (mdict_create_hashed_expandable, mdict_create_linear)
7388         (mdict_create_linear_expandable, mdict_free)
7389         (find_language_dictionary, create_new_language_dictionary)
7390         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7391         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7392         (mdict_size, mdict_empty): New functions.
7393         * dictionary.h (mdict_iterator): Define.
7394
7395 2019-01-10  Pedro Alves  <palves@redhat.com>
7396
7397         * breakpoint.c (read_uploaded_action)
7398         (create_tracepoint_from_upload): Adjust to use
7399         gdb::unique_xmalloc_ptr.
7400         * ctf.c (ctf_write_uploaded_tp):
7401         (SET_ARRAY_FIELD): Use emplace_back.
7402         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7403         * tracefile-tfile.c (tfile_write_uploaded_tp):
7404         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7405         gdb::unique_xmalloc_ptr.
7406         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7407         at_string, cond_string, cmd_strings>: Replace char pointers
7408         with gdb::unique_xmalloc_ptr.
7409
7410 2019-01-10  Pedro Alves  <palves@redhat.com>
7411
7412         * solib-target.c (library_list_start_library): Don't xstrdup name.
7413
7414 2019-01-10  Pedro Alves  <palves@redhat.com>
7415
7416         * mdebugread.c (parse_partial_symbols): Use
7417         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7418
7419 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7420
7421         * linux-fork.c (scoped_switch_fork_info)
7422         <~scoped_switch_fork_info>: Fix incorrect variable name.
7423
7424 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7425
7426         * linux-fork.c (scoped_switch_fork_info)
7427         <scoped_switch_fork_info>: Make explicit.
7428         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7429
7430 2019-01-10  Tom Tromey  <tom@tromey.com>
7431
7432         * objfiles.h (objfile::reset_psymtabs): Update.
7433         * objfiles.c (objfile::objfile): Update.
7434         * psymtab.h (psymtab_storage::obstack): Update.
7435         (psymtab_storage::m_obstack): Use gdb::optional.
7436         (class psymtab_storage): Update comment.  Remove objfile
7437         parameter.
7438         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7439
7440 2019-01-10  Tom Tromey  <tom@tromey.com>
7441
7442         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7443         <free_psymtabs>: Now private.
7444         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7445         (allocate_psymtab): Use new method.
7446
7447 2019-01-10  Tom Tromey  <tom@tromey.com>
7448
7449         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7450         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7451         * mdebugread.c (parse_partial_symbols): Use
7452         allocate_dependencies.
7453         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7454         allocate_dependencies.
7455         (process_psymtab_comp_unit_reader)
7456         (build_type_psymtab_dependencies): Likewise.
7457         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7458
7459 2019-01-10  Tom Tromey  <tom@tromey.com>
7460
7461         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7462         PSYMBOL_SET_LANGUAGE.
7463         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7464
7465 2019-01-10  Tom Tromey  <tom@tromey.com>
7466
7467         * psymtab.h (psymtab_storage::obstack): New method.
7468         <m_obstack>: Rename from obstack; now private.
7469         * psymtab.c (psymtab_storage): Update.
7470         * dwarf2read.c (create_addrmap_from_index)
7471         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7472         Update.
7473
7474 2019-01-10  Tom Tromey  <tom@tromey.com>
7475
7476         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7477         * objfiles.h (objfile::reset_psymtabs): New method.
7478
7479 2019-01-10  Tom Tromey  <tom@tromey.com>
7480
7481         * symmisc.c (print_symbol_bcache_statistics): Update.
7482         (print_objfile_statistics): Update.
7483         * symfile.c (reread_symbols): Update.
7484         * psymtab.h (class psymtab_storage): New.
7485         * psymtab.c (psymtab_storage): New constructor.
7486         (~psymtab_storage): New destructor.
7487         (require_partial_symbols): Update.
7488         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7489         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7490         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7491         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7492         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7493         (start_psymtab_common, end_psymtab_common)
7494         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7495         (allocate_psymtab): Update.
7496         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7497         Update.
7498         (dump_psymtab_addrmap, maintenance_print_psymbols)
7499         (maintenance_check_psymtabs): Update.
7500         (class objfile_psymtabs): Move to objfiles.h.
7501         * psympriv.h (discard_psymtab): Now inline.
7502         (psymtab_discarder::psymtab_discarder): Update.
7503         (psymtab_discarder::~psymtab_discarder): Update.
7504         (ALL_OBJFILE_PSYMTABS): Rewrite.
7505         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7506         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7507         Remove fields.
7508         <partial_symtabs>: New field.
7509         (class objfile_psymtabs): Move from psymtab.h.  Update.
7510         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7511         psymbol_cache.
7512         (objfile::~objfile): Don't destroy psymbol_cache.
7513         * mdebugread.c (parse_partial_symbols): Update.
7514         * dwarf2read.c (create_addrmap_from_index)
7515         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7516         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7517         (add_partial_subprogram, dwarf2_ranges_read): Update.
7518         * dwarf-index-write.c (write_address_map)
7519         (write_one_signatured_type, recursively_write_psymbols)
7520         (class debug_names, class debug_names, write_psymtabs_to_index):
7521         Update.
7522
7523 2019-01-10  Tom Tromey  <tom@tromey.com>
7524
7525         * symtab.h (SYMBOL_SET_NAMES): Update.
7526         (symbol_set_names): Update.
7527         (MSYMBOL_SET_NAMES): Update.
7528         * symtab.c (symbol_set_names): Change argument to be an
7529         objfile_per_bfd_storage.
7530         * psymtab.c (add_psymbol_to_bcache): Update.
7531         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7532
7533 2019-01-10  Tom Tromey  <tom@tromey.com>
7534
7535         * symtab.c (create_demangled_names_hash): Change argument to be an
7536         objfile_per_bfd_storage.
7537         (symbol_set_names): Update.
7538
7539 2019-01-10  Tom Tromey  <tom@tromey.com>
7540
7541         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7542         init_psymbol_list.
7543         * psymtab.c (init_psymbol_list): Do nothing if already called.
7544         * psympriv.h (init_psymbol_list): Add comment.
7545         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7546         init_psymbol_list.
7547         * dbxread.c (dbx_symfile_read): Unconditionally call
7548         init_psymbol_list.
7549
7550 2019-01-10  Tom Tromey  <tom@tromey.com>
7551
7552         * xcoffread.c (scan_xcoff_symtab): Update.
7553         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7554         "where".
7555         * mdebugread.c (parse_partial_symbols)
7556         (handle_psymbol_enumerators): Update.
7557         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7558         * dbxread.c (read_dbx_symtab): Update.
7559         * psympriv.h (psymbol_placement): New enum.
7560         (add_psymbol_to_list): Update.
7561
7562 2019-01-10  Tom Tromey  <tom@tromey.com>
7563
7564         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7565         static_psymbols parameters.
7566         (scan_xcoff_symtab): Update.
7567         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7568         static_psymbols parameters.
7569         * psympriv.h (start_psymtab_common): Update.
7570         * mdebugread.c (parse_partial_symbols): Update.
7571         * dwarf2read.c (create_partial_symtab): Update.
7572         * dbxread.c (read_dbx_symtab): Update.
7573         (start_psymtab): Remove global_psymbols and static_psymbols
7574         parameters.
7575
7576 2019-01-10  Tom Tromey  <tom@tromey.com>
7577
7578         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7579         * psymtab.c (allocate_psymtab): Add comment.
7580         * psympriv.h (allocate_psymtab): Add comment.
7581         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7582         initializations.
7583         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7584
7585 2019-01-10  Tom Tromey  <tom@tromey.com>
7586
7587         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7588         Don't declare.
7589         * mipsread.c: Include mdebugread.h.
7590         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7591         Declare.
7592         * elfread.c: Include mdebugread.h.
7593
7594 2019-01-09  Tom Tromey  <tom@tromey.com>
7595
7596         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7597         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7598         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7599         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7600         (psym_lookup_symbol, psym_find_last_source_symtab)
7601         (psym_forget_cached_source_info, psym_print_stats)
7602         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7603         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7604         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7605         (psym_find_compunit_symtab_by_address)
7606         (maintenance_print_psymbols, maintenance_info_psymtabs)
7607         (maintenance_check_psymtabs): Use ranged for.
7608         * psymtab.h (class objfile_psymtabs): New.
7609         (require_partial_symbols): Return objfile_psymtabs.
7610         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7611
7612 2019-01-09  Tom Tromey  <tom@tromey.com>
7613
7614         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7615         (find_pc_mapped_section, list_overlays_command)
7616         (map_overlay_command, unmap_overlay_command)
7617         (simple_overlay_update): Use all_objfiles.
7618         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7619         * printcmd.c (info_symbol_command): Use all_objfiles.
7620         * objfiles.h (ALL_OBJSECTIONS): Remove.
7621         * maint.c (maintenance_translate_address): Use all_objfiles.
7622         * gcore.c (gcore_create_callback): Use all_objfiles.
7623         (objfile_find_memory_regions): Likewise.
7624
7625 2019-01-09  Tom Tromey  <tom@tromey.com>
7626
7627         * symtab.c (find_line_symtab, info_sources_command)
7628         (make_source_files_completion_list): Use objfile_compunits.
7629         * source.c (select_source_symtab): Use objfile_compunits.
7630         * objfiles.h (struct objfile): Update comment.
7631         (ALL_OBJFILES): Remove.
7632         (ALL_FILETABS): Remove.
7633         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7634         objfile_compunits.
7635
7636 2019-01-09  Tom Tromey  <tom@tromey.com>
7637
7638         * symmisc.c (print_objfile_statistics, dump_objfile)
7639         (maintenance_print_symbols): Use compunit_filetabs.
7640         * source.c (forget_cached_source_info_for_objfile): Use
7641         compunit_filetabs.
7642         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7643         (ALL_FILETABS): Use compunit_filetabs.
7644         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7645         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7646
7647 2019-01-09  Tom Tromey  <tom@tromey.com>
7648
7649         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7650         (compunit_filetabs): New.
7651         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7652         compunit_filetabs.
7653         (info_sources_command, make_source_files_completion_list): Remove
7654         declaration.
7655         * symmisc.c (print_objfile_statistics, dump_objfile)
7656         (maintenance_print_symbols): Remove declaration.
7657         (maintenance_info_symtabs): Use compunit_filetabs.
7658         (maintenance_info_line_tables): Likewise.
7659         * source.c (select_source_symtab): Change local variable name.
7660         (forget_cached_source_info_for_objfile): Remove declaration.
7661         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7662         * objfiles.c (objfile_relocate1): Remove declaration.
7663         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7664         declaration.
7665         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7666         * coffread.c (coff_symtab_read): Remove declaration.
7667         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7668         compunit_filetabs.
7669
7670 2019-01-09  Tom Tromey  <tom@tromey.com>
7671
7672         * symtab.c (lookup_objfile_from_block)
7673         (find_pc_sect_compunit_symtab, search_symbols)
7674         (default_collect_symbol_completion_matches_break_on): Use
7675         objfile_compunits.
7676         * objfiles.h (ALL_COMPUNITS): Remove.
7677         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7678         * cp-support.c (add_symbol_overload_list_qualified): Use
7679         objfile_compunits.
7680         * ada-lang.c (ada_collect_symbol_completion_matches)
7681         (ada_add_global_exceptions): Use objfile_compunits.
7682
7683 2019-01-09  Tom Tromey  <tom@tromey.com>
7684
7685         * source.c (select_source_symtab)
7686         (forget_cached_source_info_for_objfile): Remove declaration.
7687         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7688         declaration.
7689         * maint.c (count_symtabs_and_blocks): Remove declaration.
7690         * cp-support.c (add_symbol_overload_list_qualified): Remove
7691         declaration.
7692         * coffread.c (coff_symtab_read): Remove declaration.
7693         * symtab.c (lookup_symbol_in_objfile_symtabs)
7694         (basic_lookup_transparent_type_1): Use objfile_compunits.
7695         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7696         (info_sources_command, search_symbols)
7697         (default_collect_symbol_completion_matches_break_on)
7698         (make_source_files_completion_list): Remove declaration.
7699         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7700         (ada_collect_symbol_completion_matches)
7701         (ada_add_global_exceptions): Remove declaration.
7702         * linespec.c (iterate_over_all_matching_symtabs): Use
7703         objfile_compunits.
7704         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7705         (class objfile_compunits): New.
7706         (ALL_COMPUNITS): Use objfile_compunits.
7707         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7708         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7709         objfile_compunits.
7710         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7711
7712 2019-01-09  Tom Tromey  <tom@tromey.com>
7713
7714         * symtab.c (search_symbols)
7715         (default_collect_symbol_completion_matches_break_on): Use
7716         objfile_msymbols.
7717         * ada-lang.c (ada_lookup_simple_minsym)
7718         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7719         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7720         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7721         objfile_msymbols.
7722         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7723         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7724         * objc-lang.c (find_methods): Use objfile_msymbols.
7725         (info_selectors_command, info_classes_command): Likewise.
7726         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7727         * objfiles.h (class objfile_msymbols): New.
7728         (ALL_OBJFILE_MSYMBOLS): Remove.
7729         (ALL_MSYMBOLS): Remove.
7730
7731 2019-01-09  Tom Tromey  <tom@tromey.com>
7732
7733         * common/next-iterator.h (next_adapter): Add Iterator template
7734         parameter.
7735         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7736         (class all_objfiles_safe): New.
7737         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7738         * objfiles.c (put_objfile_before): Update comment.
7739         (add_separate_debug_objfile): Likewise.
7740         (free_all_objfiles): Use all_objfiles_safe.
7741         (objfile_purge_solibs): Likewise.
7742
7743 2019-01-09  Tom Tromey  <tom@tromey.com>
7744
7745         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7746         (expand_symtab_containing_pc, lookup_static_symbol)
7747         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7748         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7749         all_objfiles.
7750         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7751         * breakpoint.c (create_overlay_event_breakpoint)
7752         (create_longjmp_master_breakpoint)
7753         (create_std_terminate_master_breakpoint)
7754         (create_exception_master_breakpoint): Use all_objfiles.
7755         * linux-thread-db.c (try_thread_db_load_from_pdir)
7756         (has_libpthread): Use all_objfiles.
7757         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7758         * linespec.c (iterate_over_all_matching_symtabs)
7759         (search_minsyms_for_name): Use all_objfiles.
7760         * maint.c (maintenance_info_sections): Use all_objfiles.
7761         * main.c (captured_main_1): Use all_objfiles.
7762         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7763         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7764         * guile/scm-pretty-print.c
7765         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7766         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7767         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7768         (maintenance_print_msymbols): Use all_objfiles.
7769         * source.c (select_source_symtab): Use all_objfiles.
7770         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7771         * symfile.c (remove_symbol_file_command)
7772         (expand_symtabs_matching, map_symbol_filenames): Use
7773         all_objfiles.
7774         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7775         all_objfiles.
7776         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7777         * objc-lang.c (find_methods): Use all_objfiles.
7778         * objfiles.c (have_partial_symbols, have_full_symbols)
7779         (have_minimal_symbols, qsort_cmp)
7780         (default_iterate_over_objfiles_in_search_order): Use
7781         all_objfiles.
7782         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7783         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7784         (maintenance_check_psymtabs): Use all_objfiles.
7785         (ALL_PSYMTABS): Remove.
7786         * compile/compile-object-run.c (do_module_cleanup): Use
7787         all_objfiles.
7788         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7789         * cp-support.c (add_symbol_overload_list_qualified): Use
7790         all_objfiles.
7791         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7792         Use all_objfiles.
7793         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7794         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7795         all_objfiles.
7796         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7797         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7798         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7799         Uses all_objfiles.
7800         * solib.c (solib_read_symbols): Use all_objfiles
7801
7802 2019-01-09  Tom Tromey  <tom@tromey.com>
7803
7804         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7805         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7806         all_objfiles.
7807         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7808         * symmisc.c (print_symbol_bcache_statistics)
7809         (print_objfile_statistics, maintenance_print_objfiles)
7810         (maintenance_info_symtabs, maintenance_check_symtabs)
7811         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7812         all_objfiles.
7813         * source.c (forget_cached_source_info): Use all_objfiles.
7814         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7815         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7816         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7817         * objfiles.c (update_section_map): Use all_objfiles.
7818         (shared_objfile_contains_address_p): Likewise.
7819         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7820         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7821
7822 2019-01-09  Tom Tromey  <tom@tromey.com>
7823
7824         * common/next-iterator.h: New file.
7825         * objfiles.h (class all_objfiles): New.
7826         (struct objfile_iterator): New.
7827
7828 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7829
7830         * NEWS: Move the description of the changed "frame", "select-frame",
7831          and "info frame" commands to the Changed commands section.
7832
7833 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7834
7835         * gdbtypes.c (check_stub_method_group): Remove handling of old
7836         mangling schemes.
7837         * linespec.c (find_methods): Likewise.
7838         * stabsread.c (read_member_functions): Likewise.
7839         * valops.c (search_struct_method): Likewise.
7840         (value_struct_elt_for_reference): Likewise.
7841         * NEWS: Mention this change.
7842
7843 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7844
7845         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7846         print_source_lines.
7847         * source.c (print_source_lines_base): Update line number check.
7848         (print_source_lines): New function.
7849         (source_lines_range::source_lines_range): New function.
7850         * source.h (class source_lines_range): New class.
7851         (print_source_lines): New declaration.
7852
7853 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7854
7855         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7856
7857 2019-01-08  Tom Tromey  <tom@tromey.com>
7858             Simon Marchi  <simon.marchi@ericsson.com>
7859
7860         PR gdb/24060
7861         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7862         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7863         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7864         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7865         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7866         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7867
7868 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7869
7870         * source.c (select_source_symtab): Move header comment to
7871         declaration in source.h.
7872         (forget_cached_source_info_for_objfile): Likewise.
7873         (forget_cached_source_info): Likewise.
7874         (identify_source_line): Likewise.
7875         * source.h (identify_source_line): Move declaration from symtab.h
7876         and add comment from source.c
7877         (print_source_lines): Likewise.
7878         (forget_cached_source_info_for_objfile): Likewise.
7879         (forget_cached_source_info): Likewise.
7880         (select_source_symtab): Likewise.
7881         (enum print_source_lines_flag): Move definition from symtab.h.
7882         * symtab.h (identify_source_line): Move declaration to source.h.
7883         (print_source_lines): Likewise.
7884         (forget_cached_source_info_for_objfile): Likewise.
7885         (forget_cached_source_info): Likewise.
7886         (select_source_symtab): Likewise.
7887         (enum print_source_lines_flag): Move definition to source.h.
7888         * tui/tui-hooks.c: Add 'source.h' include.
7889
7890 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7891
7892         * source.c (print_source_lines_base): Handle requests to print
7893         reverse line number sequences, and guard against empty lines
7894         string.
7895
7896 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7897
7898         * source.c (print_source_lines_base): Fix skip of '\r' if next
7899         character is '\n'.
7900
7901 2019-01-06  Tom Tromey  <tom@tromey.com>
7902
7903         * c-exp.y (struct c_parse_state) <macro_original_text,
7904         expansion_obstack>: New member.
7905         (macro_original_text, expansion_obstack): Remove globals.
7906         (scan_macro_expansion, scanning_macro_expansion)
7907         (finished_macro_expansion): Update.
7908         (scan_macro_cleanup): Remove.
7909         (yylex, c_parse): Update.
7910
7911 2019-01-06  Tom Tromey  <tom@tromey.com>
7912
7913         * c-exp.y (struct c_parse_state) <strings>: New member.
7914         (operator_stoken): Update.
7915
7916 2019-01-06  Tom Tromey  <tom@tromey.com>
7917
7918         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7919         (union type_stack_elt) <typelist_val>: Now a pointer to
7920         std::vector.
7921         (type_stack_cleanup): Don't declare.
7922         (push_typelist): Update.
7923         * parse.c (pop_typelist): Return a std::vector.
7924         (push_typelist): Take a std::vector.
7925         (follow_types): Update.  Do not free args.
7926         (type_stack_cleanup): Remove.
7927         * c-exp.y (struct c_parse_state): New.
7928         (cpstate): New global.
7929         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7930         (nonempty_typelist): Update.
7931         (func_mod): Create a new vector.
7932         (c_parse): Create a c_parse_state.
7933         (check_parameter_typelist): Do not delete params.
7934         (function_method): Update.  Do not delete type_list.
7935
7936 2019-01-06  Tom Tromey  <tom@tromey.com>
7937
7938         PR gdb/28155:
7939         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7940         check_typedef.
7941         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7942         (print_return_value): Likewise.
7943
7944 2019-01-05  Tom Tromey  <tom@tromey.com>
7945
7946         * contrib/cleanup_check.py: Remove.
7947         * contrib/gcc-with-excheck: Remove.
7948         * contrib/exsummary.py: Remove.
7949         * contrib/excheck.py: Remove.
7950
7951 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7952
7953         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7954         NULL. Initialize tpprev to NULL instead of assigning it
7955         to NULL on the next statement.
7956         * windows-nat.c (windows_delete_thread): Remove check for
7957         main_thread_id before printing thread exit notifications.
7958         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7959         Remove thread ID check against main_thread_id.
7960         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7961         windows_delete_thread.
7962         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7963
7964 2019-01-04  Tom Tromey  <tom@tromey.com>
7965
7966         * compile/compile.c (_initialize_compile): Use upper case for
7967         metasyntactic variables.
7968         * symmisc.c (_initialize_symmisc): Use upper case for
7969         metasyntactic variables.
7970         * psymtab.c (_initialize_psymtab): Use upper case for
7971         metasyntactic variables.
7972         * demangle.c (demangle_command): Use upper case for metasyntactic
7973         variables.
7974         (_initialize_demangler): Likewise.
7975         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7976         variables.
7977
7978 2019-01-03  Tom Tromey  <tom@tromey.com>
7979
7980         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7981
7982 2019-01-03  Tom Tromey  <tom@tromey.com>
7983
7984         * python/py-symtab.c (salpy_str): Update.
7985         (struct salpy_sal_object) <symtab>: Now a PyObject.
7986         (salpy_dealloc): Update.
7987         (del_objfile_sal): Use gdbpy_ref.
7988
7989 2019-01-03  Tom Tromey  <tom@tromey.com>
7990
7991         * python/py-type.c (convert_field): Use new_reference.  Return
7992         gdbpy_ref.
7993         (make_fielditem): Return gdbpy_ref.
7994         (typy_fields): Update.
7995         (typy_getitem): Update.
7996         (field_name): Return gdbpy_ref.  Use new_reference.
7997         (typy_iterator_iternext): Update.
7998
7999 2019-01-03  Tom Tromey  <tom@tromey.com>
8000
8001         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8002
8003 2019-01-03  Tom Tromey  <tom@tromey.com>
8004
8005         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8006         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8007         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8008         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8009         (pspy_set_type_printers): Likewise.
8010         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8011         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8012         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8013         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8014         (objfpy_set_type_printers): Likewise.
8015
8016 2019-01-03  Tom Tromey  <tom@tromey.com>
8017
8018         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8019         (gdbpy_print_stack): Use gdbpy_err_fetch.
8020         * python/python-internal.h (class gdbpy_err_fetch): New class.
8021         (class gdbpy_enter) <m_error_type, m_error_value,
8022         m_error_traceback>: Remove.
8023         <m_error>: New member.
8024         (gdbpy_exception_to_string): Don't declare.
8025         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8026         * python/py-value.c (convert_value_from_python): Use
8027         gdbpy_err_fetch.
8028         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8029         gdbpy_exception_to_string.
8030         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8031         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8032         gdbpy_err_fetch.
8033
8034 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8035
8036         * linux-nat.c (delete_lwp_cleanup): Delete.
8037         (struct lwp_deleter): New struct.
8038         (lwp_info_up): New typedef.
8039         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8040         lwp_info_up.
8041
8042 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8043
8044         * linux-fork.c (class scoped_switch_fork_info): New class.
8045         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8046
8047 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8048
8049         * valops.c (find_overload_match): Remove use of null_cleanup, and
8050         calls to do_cleanups.
8051
8052 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8053
8054         * compile/compile-cplus-types.c
8055         (compile_cplus_instance::decl_name): Handle changes to
8056         cp_func_name.
8057         * cp-support.c (cp_func_name): Update header comment, update
8058         return type.
8059         * cp-support.h (cp_func_name): Update return type in declaration.
8060         * valops.c (find_overload_match): Move temp_func local to top
8061         level of function and change its type.  Use temp_func to hold and
8062         delete temporary string obtained from cp_func_name.
8063
8064 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8065
8066         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8067         gdb::char_vector, remove cleanup, and update uses of `msg`.
8068
8069 2019-01-03  Jim Wilson  <jimw@sifive.com>
8070
8071         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8072
8073 2019-01-02  Tom Tromey  <tom@tromey.com>
8074
8075         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8076         (tdesc_parse_xml): Remove cleanups.
8077         * target-descriptions.h (make_cleanup_free_target_description):
8078         Don't declare.
8079         (target_desc_deleter): New struct.
8080         (target_desc_up): New typedef.
8081         * target-descriptions.c (target_desc_deleter::operator()): Rename
8082         from free_target_description.
8083         (make_cleanup_free_target_description): Remove.
8084
8085 2019-01-02  Tom Tromey  <tom@tromey.com>
8086
8087         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8088         constructor, destructor.
8089         (linespec_parser): Remove typedef.
8090         (~linespec_parser): Rename from linespec_parser_delete.
8091         (linespec_lex_to_end, linespec_complete_label)
8092         (linespec_complete): Update.
8093         (decode_line_full): Remove cleanups.
8094         (decode_line_1): Update.
8095
8096 2019-01-02  Tom Tromey  <tom@tromey.com>
8097
8098         * python/python-internal.h (inferior_to_inferior_object): Change
8099         return type.
8100         * python/py-exitedevent.c (create_exited_event_object): Update.
8101         * python/py-inferior.c (inferior_to_inferior_object): Return
8102         gdbpy_ref.
8103         (python_new_inferior, python_inferior_deleted)
8104         (thread_to_thread_object, delete_thread_object)
8105         (build_inferior_list, gdbpy_selected_inferior): Update.
8106         * python/py-infthread.c (create_thread_object): Update.  Also fail
8107         if inferior_to_inferior_object fails.
8108
8109 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8110
8111         * inferior.h (class inferior) <displaced_step_state>: New field.
8112         * infrun.h (struct displaced_step_state): Move here from
8113         infrun.c.  Initialize fields, add constructor.
8114         <inf>: Remove field.
8115         <reset>: New method.
8116         * infrun.c (struct displaced_step_inferior_state): Move to
8117         infrun.h.
8118         (displaced_step_inferior_states): Remove.
8119         (get_displaced_stepping_state): Adust.
8120         (displaced_step_in_progress_any_inferior): Adjust.
8121         (displaced_step_in_progress_thread): Adjust.
8122         (displaced_step_in_progress): Adjust.
8123         (add_displaced_stepping_state): Remove.
8124         (get_displaced_step_closure_by_addr): Adjust.
8125         (remove_displaced_stepping_state): Remove.
8126         (infrun_inferior_exit): Call displaced_step_state.reset.
8127         (use_displaced_stepping): Don't check for NULL.
8128         (displaced_step_prepare_throw): Call
8129         get_displaced_stepping_state.
8130         (displaced_step_fixup): Don't check for NULL.
8131         (prepare_for_detach): Don't check for NULL.
8132
8133 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8134
8135         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8136          in case of call that did not complete.
8137
8138 2019-01-02  Andrey Utkin  <autkin@undo.io>
8139
8140         * symfile.c (find_separate_debug_file): Fix search of debug files for
8141         remote debuggee.
8142
8143 2019-01-02  Tom Tromey  <tom@tromey.com>
8144
8145         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8146         indentation.
8147         * python/py-frame.c (frapy_older): Remove cast.
8148         (frapy_newer): Likewise.
8149         * python/py-breakpoint.c (local_setattro): Remove cast.
8150         * python/py-arch.c (archpy_name): Remove local variable.
8151         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8152
8153 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8154
8155         * unittests/basic_string_view/element_access/char/empty.cc:
8156         Fix year range in copyright header.
8157
8158 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8159
8160         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8161         Delete.
8162         <operator==>: Update with for removed field.
8163         <hash>: Likewise.
8164         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8165         <isa_features>: ...this.
8166         <abi_features>: New field.
8167         (riscv_isa_flen): Update comment.
8168         (riscv_abi_xlen): New declaration.
8169         (riscv_abi_flen): New declaration.
8170         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8171         isa_features.
8172         (riscv_abi_xlen): New function.
8173         (riscv_isa_flen): Update to get answer from isa_features.
8174         (riscv_abi_flen): New function.
8175         (riscv_has_fp_abi): Update to get answer from abi_features.
8176         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8177         xlen and flen.
8178         (riscv_call_info) <xlen, flen>: Update comment.
8179         (riscv_call_arg_struct): Remove invalid assertions
8180         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8181         is removed.
8182         (riscv_gdbarch_init): Gather isa features and abi features
8183         separately, ensure both match on the gdbarch when reusing an old
8184         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8185         a target with 64-bit float hardware.
8186
8187 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8188
8189         * source.c (search_command_helper): Stop reverse search
8190         when line 1 has been searched.
8191
8192 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8193
8194         * record-full.c (record_full_base_target::close): Rewrite
8195         record_full_core_buf_list free logic.
8196
8197 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8198
8199         * break-catch-syscall.c (print_one_catch_syscall): xfree
8200         the last text.
8201
8202 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8203
8204         * top.c (print_gdb_version): Update Copyright year in version
8205         message.
8206
8207 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8208
8209         Update copyright year range in all GDB files.
8210
8211 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8212
8213         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8214
8215 For older changes see ChangeLog-2018.
8216 \f
8217 Local Variables:
8218 mode: change-log
8219 left-margin: 8
8220 fill-column: 74
8221 version-control: never
8222 coding: utf-8
8223 End:
8224