gdb/ChangeLog

   1 2019-08-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
   4         field.
   5         * tui/tui-regs.c (~tui_data_item_window): Update.
   6
   7 2019-08-20  Tom Tromey  <tom@tromey.com>
   8
   9         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
  10         earlier.
  11
  12 2019-08-20  Tom Tromey  <tom@tromey.com>
  13
  14         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
  15
  16 2019-08-20  Tom Tromey  <tom@tromey.com>
  17
  18         * tui/tui-source.h (struct tui_source_window): Update.
  19         * tui/tui-regs.c (tui_show_registers): Update.
  20         * tui/tui-disasm.h (struct tui_disasm_window): Update.
  21         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
  22         (NO_REGS_STRING): Remove defines.
  23
  24 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
  25
  26         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
  27         unnecessary thread walk if remote doesn't support the packet.
  28
  29 2019-08-19  Tom Tromey  <tromey@adacore.com>
  30
  31         * python/py-value.c (value_has_field): Fix indentation.
  32
  33 2019-08-19  Tom Tromey  <tromey@adacore.com>
  34
  35         * printcmd.c (do_one_display, info_display_command): Update.
  36         * block.h (contained_in): Return bool.  Add allow_nested
  37         parameter.
  38         * block.c (contained_in): Return bool.  Add allow_nested
  39         parameter.
  40
  41 2019-08-19  Tom Tromey  <tom@tromey.com>
  42
  43         * configure: Rebuild.
  44         * configure.ac: Disallow the combination of -static-libstdc++ and
  45         source highlight.
  46         * source-cache.c (get_language_name): Handle rust.
  47         (source_cache::get_source_lines): Ignore highlighting exceptions.
  48
  49 2019-08-16  Tom Tromey  <tom@tromey.com>
  50
  51         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
  52         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
  53         (struct tui_source_window_base) <make_visible, refresh_window,
  54         resize>: Remove methods.
  55         <execution_info>: Remove field.
  56         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
  57         (tui_show_source_line, tui_source_window_base)
  58         (~tui_source_window_base): Update.
  59         (tui_source_window_base::resize)
  60         (tui_source_window_base::make_visible)
  61         (tui_source_window_base::refresh_window): Remove.
  62         (tui_source_window_base::update_exec_info): Update.
  63         * tui/tui-source.c (tui_source_window::set_contents): Update.
  64         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
  65
  66 2019-08-16  Tom Tromey  <tom@tromey.com>
  67
  68         * tui/tui-hooks.c (tui_remove_hooks): Don't set
  69         deprecated_query_hook.
  70
  71 2019-08-16  Tom Tromey  <tom@tromey.com>
  72
  73         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
  74         (tui_update_source_windows_with_line): Update.
  75         * tui/tui-source.h (struct tui_source_window)
  76         <show_symtab_source>: Declare.
  77         (tui_show_symtab_source): Don't declare.
  78         * tui/tui-source.c (tui_show_symtab_source): Rename from
  79         tui_show_symtab_source.
  80
  81 2019-08-16  Tom Tromey  <tom@tromey.com>
  82
  83         * tui/tui-winsource.h (struct tui_source_window_base)
  84         <set_contents>: Declare.
  85         * tui/tui-winsource.c
  86         (tui_source_window_base::update_source_window_as_is): Update.
  87         * tui/tui-source.h (struct tui_source_window) <set_contents>:
  88         Declare.
  89         (tui_set_source_content): Don't declare.
  90         * tui/tui-source.c (tui_source_window::set_contents): Rename from
  91         tui_set_source_content.
  92         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
  93         Declare.
  94         (tui_set_disassem_content): Don't declare.
  95         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
  96         tui_set_disassem_content.
  97
  98 2019-08-16  Tom Tromey  <tom@tromey.com>
  99
 100         * tui/tui-winsource.h (struct tui_source_window_base)
 101         <update_breakpoint_info>: Declare.
 102         (tui_update_breakpoint_info): Don't declare.
 103         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 104         (tui_update_all_breakpoint_info): Update.
 105         (tui_source_window_base::update_breakpoint_info): Rename from
 106         tui_update_breakpoint_info.
 107         (tui_source_window_base::update_exec_info): Update.
 108
 109 2019-08-16  Tom Tromey  <tom@tromey.com>
 110
 111         * tui/tui-winsource.h (struct tui_source_window_base)
 112         <update_source_window>: Declare.
 113         (tui_update_source_window): Don't declare.
 114         * tui/tui-winsource.c
 115         (tui_source_window_base::update_source_window): Rename from
 116         tui_update_source_window.
 117         (tui_source_window_base::rerender): Update.
 118         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 119         * tui/tui-disasm.c (tui_show_disassem)
 120         (tui_show_disassem_and_update_source)
 121         (tui_disasm_window::maybe_update): Update.
 122
 123 2019-08-16  Tom Tromey  <tom@tromey.com>
 124
 125         * tui/tui-winsource.h (struct tui_source_window_base)
 126         <update_source_window_as_is>: Declare.
 127         (tui_update_source_window_as_is): Don't declare.
 128         * tui/tui-winsource.c (tui_update_source_window): Update
 129         (tui_source_window_base::update_source_window_as_is): Rename from
 130         tui_update_source_window_as_is.
 131         (tui_source_window_base::refill): Update.
 132         * tui/tui-source.c (tui_show_symtab_source): Update.
 133         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 134         Update.
 135
 136 2019-08-16  Tom Tromey  <tom@tromey.com>
 137
 138         * tui/tui-winsource.h (tui_update_source_window)
 139         (tui_update_source_window_as_is): Remove "noerror" parameter.
 140         * tui/tui-winsource.c (tui_update_source_window)
 141         (tui_update_source_window_as_is): Remove "noerror" parameter.
 142         (tui_update_source_windows_with_addr)
 143         (tui_update_source_windows_with_line)
 144         (tui_source_window_base::rerender)
 145         (tui_source_window_base::refill): Update.
 146         * tui/tui-source.h (tui_set_source_content)
 147         (tui_show_symtab_source): Remove "noerror" parameter.
 148         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 149         parameter.
 150         (tui_show_symtab_source): Likewise.
 151         (tui_source_window::maybe_update): Update.
 152         * tui/tui-disasm.c (tui_show_disassem)
 153         (tui_show_disassem_and_update_source)
 154         (tui_disasm_window::do_scroll_vertical)
 155         (tui_disasm_window::maybe_update): Update.
 156
 157 2019-08-16  Tom Tromey  <tom@tromey.com>
 158
 159         * tui/tui.c (tui_is_window_visible): Update.
 160         * tui/tui-wingeneral.c (tui_make_window)
 161         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 162         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 163         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 164         (tui_set_win_height_command, parse_scrolling_args): Update.
 165         * tui/tui-source.c (tui_source_window::style_changed): Update.
 166         * tui/tui-regs.c (tui_show_registers)
 167         (tui_data_window::first_data_item_displayed)
 168         (tui_data_window::delete_data_content_windows)
 169         (tui_check_register_values, tui_reg_command): Update.
 170         * tui/tui-disasm.c (tui_show_disassem): Update.
 171         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 172         method.
 173         <is_visible>: Remove field.
 174         * tui/tui-data.c (tui_next_win, tui_prev_win)
 175         (tui_delete_invisible_windows): Update.
 176
 177 2019-08-16  Tom Tromey  <tom@tromey.com>
 178
 179         * tui/tui-winsource.h (struct tui_source_window_base)
 180         <m_has_locator>: Remove.
 181         * tui/tui-layout.c (show_source_disasm_command, show_data)
 182         (show_source_or_disasm_and_command): Update.
 183
 184 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 185
 186         * NEWS (Other MI changes): New subsection.
 187         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 188         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 189         * arch-utils.c (default_get_pc_address_flags): New function.
 190         * arch-utils.h (default_get_pc_address_flags): New declaration.
 191         * gdbarch.sh: Add get_pc_address_flags.
 192         * gdbarch.c: Regenerate.
 193         * gdbarch.h: Likewise.
 194         * stack.c (print_pc): New function.
 195         (print_frame_info) (print_frame): Call print_pc.
 196
 197 2019-08-16  Tom de Vries  <tdevries@suse.de>
 198
 199         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 200         print_objfile_section_info.
 201
 202 2019-08-15  Tom Tromey  <tom@tromey.com>
 203
 204         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 205         calling update_cmdwin_start_line.
 206         * tui/tui-winsource.h (struct tui_source_window_base)
 207         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 208         <rerender>: Declare.
 209         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 210         Call rerender.
 211         (tui_source_window_base::set_new_height): Remove.
 212         (tui_source_window_base::rerender): Rename from
 213         do_make_visible_with_new_height.
 214         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 215         resize method.
 216         (tui_win_info::make_invisible_and_set_new_height)
 217         (tui_win_info::make_visible_with_new_height): Remove.
 218         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 219         Declare.
 220         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 221         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 222         do_make_visible_with_new_height>: Don't declare.
 223         <rerender>: Declare.
 224         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 225         set_new_height.
 226         (tui_data_window::do_make_visible_with_new_height): Remove.
 227         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 228         call tui_show_locator_content.
 229         (tui_gen_win_info::resize): Call rerender.
 230         (show_source_or_disasm_and_command): Don't call
 231         tui_show_locator_content.
 232         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 233         method.
 234         (struct tui_win_info) <rerender>: Declare.
 235         <set_new_height, make_invisible_and_set_new_height,
 236         make_visible_with_new_height>: Don't declare.
 237         * tui/tui-data.c (tui_win_list::rerender): New method.
 238         * tui/tui-command.h (struct tui_cmd_window)
 239         <do_make_visible_with_new_height>: Don't declare.
 240         * tui/tui-command.c
 241         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 242
 243 2019-08-15  Tom Tromey  <tromey@adacore.com>
 244
 245         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 246         * ada-lang.c (ada_enum_name): Likewise.
 247
 248 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 249
 250         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 251         leading underscore.
 252         (GdbOutputErrorFile): Likewise.
 253         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 254         accordingly.
 255         (execute_unwinders): Rename to have a leading underscore.
 256         (auto_load_packages): Likewise.
 257         (global scope): Adjust call to auto_load_packages accordingly.
 258         (GdbSetPythonDirectory): Likewise.
 259         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 260         instead of execute_unwinders.
 261
 262 2019-08-15  Tom Tromey  <tom@tromey.com>
 263
 264         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 265         (show_data): Don't change window visibility.
 266         (tui_gen_win_info::resize): Remove special case for command
 267         window.  Use wresize, when available.
 268         (show_source_or_disasm_and_command): Don't change window
 269         visibility.
 270         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 271         <make_visible>: New method.
 272         * tui/tui-command.c (tui_cmd_window::resize): New method.
 273
 274 2019-08-15  Tom Tromey  <tom@tromey.com>
 275
 276         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 277         (struct tui_source_windows): New.
 278         * tui/tui-winsource.c (tui_display_main): Update.
 279         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 280         (new_height_ok, parse_scrolling_args): Update.
 281         * tui/tui-layout.c (show_layout, show_data): Update.
 282         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 283         (tui_add_to_source_windows): Don't declare.
 284         * tui/tui-data.c (source_windows, tui_source_windows)
 285         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 286
 287 2019-08-15  Tom Tromey  <tom@tromey.com>
 288
 289         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 290         Rename from reset.
 291         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 292         * tui/tui-layout.c (show_source_disasm_command, show_data):
 293         Update.
 294         (tui_gen_win_info::resize): Rename.
 295         (show_source_or_disasm_and_command): Update.
 296         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 297         reset.
 298
 299 2019-08-15  Tom Tromey  <tom@tromey.com>
 300
 301         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 302         * tui/tui-interp.c (tui_interp::init): Don't call
 303         tui_initialize_static_data.
 304         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 305
 306 2019-08-15  Tom Tromey  <tom@tromey.com>
 307
 308         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 309         examine tui_win_list.
 310
 311 2019-08-15  Tom Tromey  <tom@tromey.com>
 312
 313         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 314         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 315         tui_clear_source_content.
 316         (tui_clear_source_content): Remove.
 317         (tui_source_window_base::do_erase_source_content): Hoist call to
 318         content.clear().
 319         * tui/tui-stack.c (tui_show_frame_info): Don't call
 320         tui_clear_source_content.
 321
 322 2019-08-15  Tom Tromey  <tom@tromey.com>
 323
 324         * tui/tui-winsource.h (struct tui_source_window_base)
 325         <do_erase_source_content>: New method.
 326         <erase_source_content>: New method.
 327         (tui_erase_source_content): Don't declare.
 328         * tui/tui-winsource.c (tui_clear_source_content): Update.
 329         (tui_source_window_base::do_erase_source_content): Rename from
 330         tui_erase_source_content.
 331         (tui_source_window_base::show_source_content): Update.
 332         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 333         * tui/tui-source.h (struct tui_source_window)
 334         <erase_source_content>: New method.
 335         * tui/tui-disasm.h (struct tui_disasm_window)
 336         <erase_source_content>: New method.
 337
 338 2019-08-15  Tom Tromey  <tom@tromey.com>
 339
 340         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 341         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 342         constructor.
 343         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 344         * tui/tui-source.c (tui_set_source_content): Update.
 345         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 346
 347 2019-08-15  Tom Tromey  <tom@tromey.com>
 348
 349         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 350         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 351         tui-source.c.
 352         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 353         Declare.
 354         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 355         method.
 356         (tui_source_window::maybe_update): Update.
 357
 358 2019-08-15  Tom Tromey  <tom@tromey.com>
 359
 360         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 361         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 362         tui-disasm.c.
 363         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 364         Declare.
 365         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 366         method.
 367         (tui_disasm_window::maybe_update): Update.
 368
 369 2019-08-15  Tom Tromey  <tom@tromey.com>
 370
 371         * tui/tui-winsource.h (struct tui_source_window_base)
 372         <maybe_update>: Declare.
 373         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 374         method.
 375         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 376         Declare.
 377         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 378         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 379         Declare.
 380         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 381
 382 2019-08-15  Tom Tromey  <tom@tromey.com>
 383
 384         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 385
 386 2019-08-15  Tom Tromey  <tom@tromey.com>
 387
 388         * tui/tui-wingeneral.c: Include tui-stack.h.
 389         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 390         (struct tui_locator_window): Move from tui-data.h.
 391         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 392         (tui_initialize_static_data): Move from tui-data.c.
 393         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 394         (struct tui_locator_window): Move to tui-stack.c.
 395         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 396         (tui_initialize_static_data): Move to tui-stack.c.
 397
 398 2019-08-15  Tom Tromey  <tom@tromey.com>
 399
 400         * tui/tui-layout.c (show_source_disasm_command)
 401         (show_source_or_disasm_and_command): Use make_visible method, not
 402         tui_make_window.
 403         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 404         Remove.
 405
 406 2019-08-15  Tom Tromey  <tom@tromey.com>
 407
 408         * tui/tui-wingeneral.h (tui_make_window): Update.
 409         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 410         parameter.
 411         (tui_gen_win_info::make_visible): Update.
 412         * tui/tui-regs.c (tui_data_window::display_registers_from):
 413         Update.
 414         * tui/tui-layout.c (show_source_disasm_command)
 415         (show_source_or_disasm_and_command): Update.
 416         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 417         (enum tui_box): Remove.
 418         (struct tui_win_info) <can_box>: New method.
 419         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 420         method.
 421
 422 2019-08-15  Tom de Vries  <tdevries@suse.de>
 423
 424         * linux-nat-trad.c: Include gdbarch.h.
 425
 426 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 427
 428         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 429         register sizes.
 430
 431 2019-08-14  Tom Tromey  <tromey@adacore.com>
 432
 433         * darwin-nat.c: Include gdbarch.h.
 434         * darwin-nat-info.c: Include gdbarch.h.
 435
 436 2019-08-13  Tom Tromey  <tom@tromey.com>
 437
 438         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 439         Remove.
 440         * tui/tui-data.c (tui_initialize_static_data): Update.
 441
 442 2019-08-13  Tom Tromey  <tom@tromey.com>
 443
 444         * tui/tui-winsource.h (struct tui_exec_info_window)
 445         <~tui_exec_info_window, maybe_allocate_content, get_content,
 446         m_content>: Remove.
 447         (struct tui_source_window_base) <set_exec_info_content,
 448         show_exec_info_content>: Don't declare.
 449         * tui/tui-winsource.c
 450         (tui_exec_info_window::maybe_allocate_content): Remove.
 451         (tui_source_window_base::update_exec_info): Rename from
 452         set_exec_info_content.
 453         (tui_source_window_base::show_exec_info_content)
 454         (tui_source_window_base::update_exec_info): Remove.
 455
 456 2019-08-13  Tom Tromey  <tom@tromey.com>
 457
 458         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 459         declare.
 460         * tui/tui-winsource.c (tui_update_source_window_as_is)
 461         (tui_update_source_windows_with_addr, tui_erase_source_content):
 462         Update.
 463         (tui_clear_exec_info_content): Remove.
 464
 465 2019-08-13  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 468         declare.
 469         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 470         call tui_erase_exec_info_content.
 471         (tui_clear_exec_info_content): Rename from
 472         tui_erase_exec_info_content.
 473         (tui_clear_exec_info_content): Delete.
 474
 475 2019-08-13  Tom Tromey  <tom@tromey.com>
 476
 477         * tui/tui-winsource.h (struct tui_source_window_base)
 478         <show_exec_info_content>: Declare.
 479         (tui_show_exec_info_content): Don't declare.
 480         * tui/tui-winsource.c
 481         (tui_source_window_base::show_exec_info_content): Rename from
 482         tui_show_exec_info_content.
 483         (tui_source_window_base::update_exec_info): Update.
 484
 485 2019-08-13  Tom Tromey  <tom@tromey.com>
 486
 487         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 488         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 489         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 490         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 491         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 492         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 493         ... here.
 494
 495 2019-08-13  Tom Tromey  <tom@tromey.com>
 496
 497         * tui/tui-winsource.h (struct tui_source_window_base)
 498         <update_exec_info>: Declare.
 499         (tui_update_exec_info): Don't declare.
 500         * tui/tui-winsource.c (tui_update_source_window_as_is)
 501         (tui_source_window_base::refresh_all)
 502         (tui_update_all_breakpoint_info): Update.
 503         (tui_source_window_base::update_exec_info): Rename from
 504         tui_update_exec_info.
 505         * tui/tui-stack.c (tui_show_frame_info): Update.
 506
 507 2019-08-13  Tom Tromey  <tom@tromey.com>
 508
 509         * tui/tui-winsource.h (struct tui_source_window_base)
 510         <set_exec_info_content>: Declare.
 511         (tui_set_exec_info_content): Don't declare.
 512         * tui/tui-winsource.c
 513         (tui_source_window_base::set_exec_info_content): Rename from
 514         tui_set_exec_info_content.
 515         (tui_update_exec_info): Update.
 516
 517 2019-08-13  Tom Tromey  <tom@tromey.com>
 518
 519         * tui/tui-winsource.h (struct tui_source_window_base)
 520         <show_source_content>: Declare.
 521         (tui_show_source_content): Don't declare.
 522         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 523         (tui_source_window_base::show_source_content): Rename from
 524         tui_show_source_content.
 525         (tui_source_window_base::refresh_all): Update.
 526         * tui/tui-layout.c (show_source_disasm_command)
 527         (show_source_or_disasm_and_command): Update.
 528
 529 2019-08-13  Tom Tromey  <tom@tromey.com>
 530
 531         * tui/tui-winsource.c (tui_erase_source_content)
 532         (tui_show_source_content, tui_source_window_base::refresh_all):
 533         Update.
 534         * tui/tui-wingeneral.h
 535         (tui_check_and_display_highlight_if_needed): Don't declare.
 536         * tui/tui-wingeneral.c
 537         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 538         check_and_display_highlight_if_needed.
 539         * tui/tui-win.c (tui_rehighlight_all)
 540         (tui_win_info::make_visible_with_new_height): Update.
 541         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 542         (tui_data_window::erase_data_content)
 543         (tui_data_window::display_all_data): Update.
 544         * tui/tui-data.h (struct tui_win_info)
 545         <check_and_display_highlight_if_needed>: Declare.
 546
 547 2019-08-13  Tom Tromey  <tom@tromey.com>
 548
 549         * tui/tui-win.c (tui_resize_all): Call
 550         tui_delete_invisible_windows.
 551         * tui/tui-layout.c (show_layout): Call
 552         tui_delete_invisible_windows.
 553         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 554         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 555
 556 2019-08-13  Tom Tromey  <tom@tromey.com>
 557
 558         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 559         tui_add_win_to_layout.
 560
 561 2019-08-13  Tom Tromey  <tom@tromey.com>
 562
 563         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 564         * tui/tui-layout.c (tui_default_win_height): Now static.
 565
 566 2019-08-13  Tom Tromey  <tom@tromey.com>
 567
 568         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 569         single switch.
 570         (show_source_disasm_command, show_source_or_disasm_and_command):
 571         Don't check current layout.
 572
 573 2019-08-13  Tom Tromey  <tom@tromey.com>
 574
 575         * tui/tui-wingeneral.c (make_all_visible): Remove.
 576         (tui_make_all_invisible): Simplify.
 577         * tui/tui-layout.c (tui_make_all_invisible): Move from
 578         tui-wingeneral.c; simplify.
 579         (show_layout): Hoist call to tui_make_all_invisible.
 580         (show_data): Don't call tui_make_all_invisible.
 581
 582 2019-08-13  Tom Tromey  <tom@tromey.com>
 583
 584         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 585         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 586
 587 2019-08-13  Tom Tromey  <tom@tromey.com>
 588
 589         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 590         tui-data.c.
 591         (show_source_disasm_command, show_data)
 592         (show_source_or_disasm_and_command): Don't use
 593         tui_set_current_layout_to.
 594         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 595         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 596         tui-layout.c.
 597         (tui_set_current_layout_to): Remove.
 598
 599 2019-08-13  Tom Tromey  <tom@tromey.com>
 600
 601         * tui/tui-layout.c (tui_set_layout): Update.
 602         * tui/tui-data.h (struct tui_layout_def): Remove.
 603         (tui_layout_def): Don't declare.
 604         * tui/tui-data.c (layout_def): Remove.
 605         (tui_layout_def): Remove.
 606
 607 2019-08-13  Tom Tromey  <tom@tromey.com>
 608
 609         * tui/tui-winsource.h (struct tui_source_window_base)
 610         <clear_detail>: No longer "override".
 611         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 612         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 613         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 614         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 615         Remove.
 616         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 617
 618 2019-08-13  Tom Tromey  <tromey@adacore.com>
 619
 620         * tracepoint.c: Don't include readline.h or history.h.
 621
 622 2019-08-12  Tom Tromey  <tom@tromey.com>
 623
 624         * configure: Rebuild.
 625         * configure.ac: Check for readline 7.
 626         * NEWS: Mention readline 7 requirement.
 627         * README: Update.
 628
 629 2019-08-12  Tom Tromey  <tom@tromey.com>
 630
 631         * mingw-hdep.c (gdb_select): Remove readline hack.
 632
 633 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 634
 635         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 636         when the function fails.
 637
 638 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 639
 640         * s390-tdep.c (s390_type_align): New function.
 641         (s390_gdbarch_init): Set it as type_align gdbarch method.
 642
 643 2019-08-09  Tom de Vries  <tdevries@suse.de>
 644
 645         PR gdb/24591
 646         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 647         pc_low with relocation offset.
 648
 649 2019-08-07  Tom Tromey  <tromey@adacore.com>
 650
 651         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 652         (print_frame_args): Update.
 653         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 654         Update.
 655         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 656         * frame.h (struct frame_arg): Add initializers.
 657         <error>: Now a unique_xmalloc_ptr.
 658
 659 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 660
 661         * NEWS: Expand the Pointer Authentication entry.
 662         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 663         (aarch64_frame_unmask_lr): ... to this.
 664         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 665         Call aarch64_frame_unmask_lr.
 666         * frame.c (struct frame_info): Add "masked" variable.
 667         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 668         (fprint_frame): Check for masked pc.
 669         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 670         declarations.
 671         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 672         * stack.c (print_frame): Check for masked pc.
 673
 674 2019-08-06  Tom Tromey  <tom@tromey.com>
 675
 676         * stabsread.c (patch_block_stabs, read_one_struct_field)
 677         (read_enum_type): Use obstack_strndup.
 678         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 679         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 680         * dwarf2read.c (guess_full_die_structure_name)
 681         (anonymous_struct_prefix): Use obstack_strndup.
 682         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 683         * c-exp.y (yylex): Use obstack_strndup.
 684         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 685         (write_var_or_type): Use obstack_strndup.
 686
 687 2019-08-06  Tom Tromey  <tom@tromey.com>
 688
 689         * symfile.c (reread_symbols): Use obstack_strdup.
 690         * stabsread.c (read_type): Use obstack_strdup.
 691         * gdb_obstack.h (obstack_strdup): New overload.
 692         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 693         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 694         (dwarf2_canonicalize_name): Use obstack_strdup.
 695         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 696         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 697         Use obstack_strdup.
 698
 699 2019-08-06  Tom Tromey  <tom@tromey.com>
 700
 701         * gdb_obstack.h (obstack_strdup): Define.
 702         * gdb_obstack.c (obstack_strdup): Don't define.
 703
 704 2019-08-06  Tom Tromey  <tom@tromey.com>
 705
 706         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 707         obstack_strdup.
 708         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 709         obstack_strdup.
 710         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 711         * stabsread.c (common_block_start): Use obstack_strdup.
 712         * objfiles.c (set_objfile_main_name, objfile): Use
 713         obstack_strdup.
 714         * namespace.c (add_using_directive): Use obstack_strdup.
 715         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 716         * jit.c (finalize_symtab): Use obstack_strdup.
 717         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 718         (guess_partial_die_structure_name, partial_die_info::fixup)
 719         (dwarf2_name): Use obstack_strdup.
 720         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 721         obstack_strdup.
 722         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 723         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 724         obstack_strdup.
 725         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 726
 727 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 728
 729         * unittests/help-doc-selftests.c: New file.
 730         * Makefile.in: Add the new file.
 731
 732 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 733
 734         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 735         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 736         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 737         the trailing '.' is not output, and the first character is uppercased.
 738         (print_help_for_command): Update call to print_doc_line.
 739         (print_doc_of_command): Likewise.
 740         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 741         * cli/cli-option.c (append_indented_doc): Do not append newline.
 742         (build_help_option): Append newline after first appended_indented_doc
 743         only if a second call is done.
 744         (build_help): Append 2 new lines before each option, except the first
 745         one.
 746         * compile/compile.c (_initialize_compile): Add new lines after
 747         %OPTIONS%, when not at the end of the help.
 748         Change help doc or code
 749         producing the help doc to respect the invariants.
 750         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 751         Also removed the new line after 'Options:', as all other commands
 752         do not put an empty line between 'Options:' and the first option.
 753         * printcmd.c (_initialize_printcmd): Likewise.
 754         * stack.c (_initialize_stack): Likewise.
 755         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 756         incorrectly telling COMMAND is optional.
 757         * ada-lang.c (_initialize_ada_language): Change help doc or code
 758         producing the help doc to respect the invariants.
 759         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 760         * breakpoint.c (_initialize_breakpoint): Likewise.
 761         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 762         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 763         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 764         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 765         _initialize_cli_style): Likewise.
 766         * corelow.c (core_target_info): Likewise.
 767         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 768         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 769         * filesystem.c (_initialize_filesystem): Likewise.
 770         * frame.c (_initialize_frame): Likewise.
 771         * gnu-nat.c (add_task_commands): Likewise.
 772         * infcall.c (_initialize_infcall): Likewise.
 773         * infcmd.c (_initialize_infcmd): Likewise.
 774         * interps.c (_initialize_interpreter): Likewise.
 775         * language.c (_initialize_language): Likewise.
 776         * linux-fork.c (_initialize_linux_fork): Likewise.
 777         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 778         * maint.c (_initialize_maint_cmds): Likewise.
 779         * memattr.c (_initialize_mem): Likewise.
 780         * printcmd.c (_initialize_printcmd): Likewise.
 781         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 782         _RegEx): Likewise.
 783         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 784         * record-btrace.c (_initialize_record_btrace): Likewise.
 785         * record-full.c (_initialize_record_full): Likewise.
 786         * record.c (_initialize_record): Likewise.
 787         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 788         * regcache.c (_initialize_regcache): Likewise.
 789         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 790         _initialize_remote): Likewise.
 791         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 792         * serial.c (_initialize_serial): Likewise.
 793         * skip.c (_initialize_step_skip): Likewise.
 794         * source.c (_initialize_source): Likewise.
 795         * stack.c (_initialize_stack): Likewise.
 796         * symfile.c (_initialize_symfile): Likewise.
 797         * symtab.c (_initialize_symtab): Likewise.
 798         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 799         * top.c (init_main): Likewise.
 800         * tracefile-tfile.c (tfile_target_info): Likewise.
 801         * tracepoint.c (_initialize_tracepoint): Likewise.
 802         * tui/tui-win.c (_initialize_tui_win): Likewise.
 803         * utils.c (add_internal_problem_command): Likewise.
 804         * valprint.c (value_print_option_defs): Likewise.
 805
 806 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 807
 808         PR build/24886
 809         * configure.ac: Drop enable-libmcheck support.
 810         * configure, config.in: Rebuild.
 811         * libmcheck.m4: Remove.
 812         * acinclude.m4: Don't include it.
 813         * Makefile.in: Don't distribute it.
 814         * top.c (print_gdb_configuration): Don't mention it.
 815
 816 2019-08-06  Tom Tromey  <tom@tromey.com>
 817
 818         * utils.c (set_output_style): Sometimes pass stream to
 819         emit_style_escape.
 820         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 821         * record-btrace.c (btrace_insn_history): Update.
 822         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 823         method.
 824         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 825         Update initializers.
 826         <m_uiout>: New field.
 827         <m_di>: Move lower.
 828         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 829         Remove "uiout" parameter.
 830         (dump_insns): Update.
 831         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 832         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 833
 834 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 835
 836         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 837         (error_in_psymtab_expansion): Likewise.
 838         (lookup_symbol_via_quick_fns): Likewise.
 839         (basic_lookup_transparent_type_quick): Likewise.
 840         (basic_lookup_transparent_type_1): Likewise.
 841
 842 2019-08-06  Tom Tromey  <tromey@adacore.com>
 843
 844         * source.c (last_source_error): Now bool.
 845         (print_source_lines_base): Make "noprint" bool.  Only open
 846         source file when last_source_visited changes.
 847
 848 2019-08-06  Tom Tromey  <tromey@adacore.com>
 849
 850         * annotate.c (annotate_source_line): Use g_source_cache.
 851         * source-cache.c (source_cache::get_plain_source_lines): Change
 852         parameters.  Populate m_offset_cache.
 853         (source_cache::ensure): New method.
 854         (source_cache::get_line_charpos): New method.
 855         (extract_lines): Move lower.  Change parameters.
 856         (source_cache::get_source_lines): Move lower.
 857         * source-cache.h (class source_cache): Update comment.
 858         <get_line_charpos>: New method.
 859         <get_source_lines>: Update comment.
 860         <clear>: Clear m_offset_cache.
 861         <get_plain_source_lines>: Change parameters.
 862         <ensure>: New method
 863         <m_offset_cache>: New member.
 864         * source.c (forget_cached_source_info_for_objfile): Update.
 865         (info_source_command): Use g_source_cache.
 866         (find_source_lines, open_source_file_with_line_charpos): Remove.
 867         (print_source_lines_base, search_command_helper): Use g_source_cache.
 868         * source.h (open_source_file_with_line_charpos): Don't declare.
 869         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 870         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 871         Use g_source_cache.
 872
 873 2019-08-06  Tom Tromey  <tromey@adacore.com>
 874
 875         * source-cache.c (source_cache::get_plain_source_lines):
 876         Remove "first_line" and "last_line" parameters.
 877         (source_cache::get_source_lines): Cache plain text.
 878         * source-cache.h (class source_cache)
 879         <get_plain_source_lines>: Update.
 880
 881 2019-08-06  Tom Tromey  <tromey@adacore.com>
 882
 883         * source-cache.c (extract_lines): No longer a method.
 884         Changed type of parameter.  Include final newline.
 885         (selftests::extract_lines_test): New function.
 886         (_initialize_source_cache): Likewise.
 887         * source-cache.h (class source_cache)
 888         <extract_lines>: Don't declare.
 889
 890 2019-08-06  Tom Tromey  <tromey@adacore.com>
 891
 892         * breakpoint.c (init_breakpoint_sal): Update.
 893         (breakpoint): Update.
 894         * breakpoint.h (struct breakpoint) <filter>: Now a
 895         unique_xmalloc_ptr.
 896
 897 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 898
 899         * NEWS: Mention dictionary access on blocks.
 900         * python/py-block.c (blpy_getitem): New function.
 901         (block_object_as_mapping): New struct.
 902         (block_object_type): Use new struct for tp_as_mapping field.
 903
 904 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 905
 906         * objfiles.h (objfile): Add a comment describing partial symbols.
 907
 908 2019-08-05  Tom Tromey  <tromey@adacore.com>
 909
 910         * compile/compile.c (_initialize_compile): Use _(), not N_().
 911         * thread.c (_initialize_thread): Use _(), not N_().
 912         * stack.c (_initialize_stack): Use _(), not N_().
 913         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 914
 915 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 916
 917         * dwarf2read.c (struct dw2_symtab_iterator):
 918         <want_specific_block>: Remove.
 919         <block_index>: Change type to gdb::optional.
 920         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 921         change type of BLOCK_INDEX parameter to gdb::optional.
 922         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 923         (dw2_lookup_symbol): Don't pass argument for
 924         WANT_SPECIFIC_BLOCK.
 925         (dw2_expand_symtabs_for_function): Don't pass argument for
 926         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 927         (class dw2_debug_names_iterator)
 928         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 929         parameter, change BLOCK_INDEX type to gdb::optional.
 930         <m_want_specific_block>: Remove.
 931         <m_block_index>: Change type to gdb::optional.
 932         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 933         gdb::optional.  Re-write in function of gdb::optional.
 934         (dw2_debug_names_lookup_symbol): Don't pass argument for
 935         WANT_SPECIFIC_BLOCK.
 936         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 937         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 938         BLOCK_INDEX.
 939
 940 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 941
 942         * NEWS: Mention changes to "info sources" command.
 943
 944 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 945
 946         * symtab.c (filename_partial_match_opts): New struct type.
 947         (struct output_source_filename_data): New members
 948         regexp, c_regexp, partial_match.
 949         (output_source_filename): Use new members to decide to print file.
 950         (info_sources_option_defs): New variable.
 951         (make_info_sources_options_def_group, print_info_sources_header,
 952         info_sources_command_completer):
 953         New functions.
 954         (info_sources_command): Read new optional arguments.
 955         (_initialize_symtab): Update info sources help.
 956
 957 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 958
 959         * ada-lang.c (exception_support_info_v0): Renamed from...
 960         (default_exception_support_info): ... this.  Create new
 961         definition for v1.
 962         (ada_has_this_exception_support): Look up catch_handlers_sym.
 963         (ada_exception_support_info_sniffer): Try v0 after default.
 964
 965 2019-08-01  Tom Tromey  <tromey@adacore.com>
 966
 967         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 968         gdbarch.h.
 969
 970 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 971
 972         * s12z-tdep.c: Fix include path for s12z-opc.h.
 973
 974 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 975
 976         * NEWS: Require GNU make 3.82.
 977
 978 2019-07-16  Tom Tromey  <tom@tromey.com>
 979
 980         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 981         declare.
 982
 983 2019-07-30  Tom Tromey  <tromey@adacore.com>
 984
 985         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 986
 987 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 988
 989         * printcmd.c (print_address_symbolic): Print negative offsets.
 990         (build_address_symbolic): Force signed arithmetic when computing
 991         offset.
 992
 993 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 994
 995         PR/24474: Add a function to lookup static variables.
 996         * NEWS: Mention this new function.
 997         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 998         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 999         * python/python.c (python_GdbMethods): Add new function.
1000
1001 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1002
1003         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1004         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1005         (objfpy_lookup_static_symbol): New function.
1006         (objfile_object_methods): Add new functions.
1007
1008 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1009
1010         * NEWS: Mention 'set|show print frame-info'.  Mention new
1011         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1012         backtrace argument.  Mention that python frame filtering code
1013         is now consistent with what 'backtrace' command prints.
1014
1015 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1016
1017         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1018         comments.
1019         (print_frame_info_auto, print_frame_info_source_line,
1020         print_frame_info_location, print_frame_info_source_and_location,
1021         print_frame_info_location_and_address, print_frame_info_short_location):
1022         New declarations.
1023         (struct frame_print_options): New member print_frame_info.
1024         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1025         * stack.h (get_user_print_what_frame_info): New declaration.
1026         (frame_show_address): New declaration.
1027         * stack.c (print_frame_arguments_choices): New value 'presence'.
1028         (print_frame_info_auto, print_frame_info_source_line,
1029         print_frame_info_location, print_frame_info_source_and_location,
1030         print_frame_info_location_and_address, print_frame_info_short_location,
1031         print_frame_info_choices, print_frame_info_print_what): New definitions.
1032         (print_frame_args): Only print dots for args if print frame-arguments
1033         is 'presence'.
1034         (frame_print_option_defs): New element for "frame-info".
1035         (get_user_print_what_frame_info): New function.
1036         (frame_show_address): Make non static.  Move comment to stack.h.
1037         (print_frame_info_to_print_what): New function.
1038         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1039         to decide what to print.
1040         (backtrace_command_1): Handle the new print_frame_arguments_presence
1041         value.
1042         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1043         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1044         (py_print_frame): In non-mi mode, use LOCATION as default for
1045         print_what, similarly to frame information printed directly by
1046         backtrace command. Handle frame-info user option in non MI mode.
1047
1048 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1049
1050         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1051         Add case for debugging 32-bit target on 64-bit host.  Revise
1052         comment.
1053
1054 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1055
1056         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1057         instead of find_function_entry_range_from_pc.
1058
1059 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1060
1061         * stack.c (find_frame_funname): Remove code which preferred
1062         minsym over symtab sym in "certain pathological cases".
1063
1064         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1065         parameter.  Change type of "do_demangle" to bool.
1066         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1067         Pass suitable "prefer_sym_over_minsym" flag to
1068         build_address_symbolic().  Don't output "+" for negative offsets.
1069         * printcmd.c (print_address_symbolic): Update invocation of
1070         build_address_symbolic to include a "prefer_sym_over_minsym"
1071         flag.
1072         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1073         Restrict cases in which use of minimal symbol is preferred to that
1074         of a found symbol.  Update comments.
1075
1076         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1077         for entry pc when entry pc is out of range for that FDE.
1078
1079 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1080
1081         PR gdb/24839:
1082         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1083         type.
1084
1085 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1086
1087         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1088         this function's Python signature.
1089
1090
1091 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1092
1093         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1094         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1095         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1096         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1097         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1098
1099
1100 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1101
1102         * h8300-tdep.c (h8300_register_name_common): New.
1103         h8300_register_name): Use h8300_register_name_common.
1104         (h8300s_register_name): Likewise.
1105         (h8300sx_register_name): Likewise.
1106         (h8300h_register_nam): New.
1107         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1108
1109
1110 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1111
1112         * arm-tdep.c (arm_skip_cmse_entry): New function.
1113         (arm_is_sgstubs_section): New function.
1114         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1115
1116 2019-07-22  Tom Tromey  <tom@tromey.com>
1117
1118         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1119         Don't self-assign.
1120
1121 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1122
1123         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1124         type_print.
1125
1126 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1127
1128         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1129         so that GDB doesn't match any msymbols when searching in the
1130         TYPES_DOMAIN.
1131         (print_symbol_info): Print using typedef_print or type_print based
1132         on the type of the symbol.  Add updated FIXME comment moved from...
1133         (_initialize_symtab): ... move and update FIXME comment to above.
1134
1135 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1136
1137         * NEWS: Mention adding -q option to "info types".
1138         * symtab.c (struct info_types_options): New struct.
1139         (info_types_options_defs): New variable.
1140         (make_info_types_options_def_group): New function.
1141         (info_types_command): Use gdb::option framework to parse options.
1142         (info_types_command_completer): New function.
1143         (_initialize_symtab): Extend the help text on "info types" and
1144         register command completer.
1145
1146 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1147
1148         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1149         (lookup_symbol_in_objfile): Change int to block_enum and add a
1150         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1151
1152 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1153
1154         * MAINTAINERS (Write After Approval): Add self.
1155
1156 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1157
1158         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1159         instruction to the dummy code region.
1160
1161 2019-07-19  Tom Tromey  <tromey@adacore.com>
1162
1163         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1164         (ARGSUSED, PARAMS, __func__): Remove rules.
1165
1166 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1167
1168         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1169         * features/arm/arm-with-iwmmxt.c: Remove.
1170         * features/arm/arm-with-iwmmxt.xml: Remove.
1171         * features/arm/arm-with-m-fpa-layout.c: Remove.
1172         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1173         * features/arm/arm-with-m-vfp-d16.c: Remove.
1174         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1175         * features/arm/arm-with-m.c: Remove.
1176         * features/arm/arm-with-m.xml: Remove.
1177         * features/arm/arm-with-neon.c: Remove.
1178         * features/arm/arm-with-neon.xml: Remove.
1179         * features/arm/arm-with-vfpv2.c: Remove.
1180         * features/arm/arm-with-vfpv2.xml: Remove.
1181         * features/arm/arm-with-vfpv3.c: Remove.
1182         * features/arm/arm-with-vfpv3.xml: Remove.
1183
1184 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1185
1186         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1187
1188 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1189
1190         * arch/aarch32.c (aarch32_create_target_description): Create
1191         target descriptions using features.
1192         * arch/arm.c (arm_create_target_description)
1193         (arm_create_mprofile_target_description): Likewise.
1194         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1195
1196 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1197
1198         * Makefile.in: Add new files.
1199         * aarch32-tdep.c: New file.
1200         * aarch32-tdep.h: New file.
1201         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1202         Call aarch32_read_description.
1203         * arch/aarch32.c: New file.
1204         * arch/aarch32.h: New file.
1205         * arch/arm.c (arm_create_target_description)
1206         (arm_create_mprofile_target_description): New function.
1207         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1208         (arm_create_target_description)
1209         (arm_create_mprofile_target_description): New declaration.
1210         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1211         read_description functions.
1212         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1213         Likewise.
1214         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1215         * arm-tdep.c (tdesc_arm_list): New variable.
1216         (arm_register_g_packet_guesses): Call create description functions.
1217         (arm_read_description) (arm_read_mprofile_description): New
1218         function.
1219         * arm-tdep.h (arm_read_description)
1220         (arm_read_mprofile_description): Add declaration.
1221         * configure.tgt: Add new files.
1222
1223 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1224
1225         * top.c (new_ui_command): Open specified terminal just once.
1226
1227 2019-07-18  Tom Tromey  <tromey@adacore.com>
1228
1229         * symtab.c (main_name): Constify return type.
1230         * symfile.c (set_initial_language): Update.
1231         * symtab.h (main_name): Constify return type.
1232
1233 2019-07-17  Tom Tromey  <tom@tromey.com>
1234
1235         * tui/tui-winsource.c (tui_update_source_window)
1236         (tui_update_source_window_as_is)
1237         (tui_update_source_windows_with_line): Remove return.
1238         * tui/tui-disasm.c (tui_show_disassem)
1239         (tui_show_disassem_and_update_source): Remove return.
1240         * tui/tui.c (tui_reset): Remove return.
1241         * tui/tui-wingeneral.c
1242         (tui_check_and_display_highlight_if_needed): Remove return.
1243
1244 2019-07-17  Tom Tromey  <tom@tromey.com>
1245
1246         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1247
1248 2019-07-17  Tom Tromey  <tom@tromey.com>
1249
1250         * tui/tui-winsource.h (struct tui_exec_info_window)
1251         (struct tui_source_window_base): Move from tui-data.h.
1252         * tui/tui-winsource.c: Move many method definitions from
1253         elsewhere.  Remove "structuring" comments.
1254         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1255         (tui_source_window_base::refresh_window): Move to
1256         tui-winsource.c.
1257         * tui/tui-win.c (tui_source_window_base::refresh_all)
1258         (tui_source_window_base::update_tab_width)
1259         (tui_source_window_base::set_new_height)
1260         (tui_source_window_base::do_make_visible_with_new_height): Move to
1261         tui-winsource.c.
1262         * tui/tui-source.h: Update.
1263         * tui/tui-source.c (tui_source_window_base::reset): Move to
1264         tui-winsource.c.
1265         * tui/tui-disasm.h: Update.
1266         * tui/tui-data.h (struct tui_exec_info_window): Move to
1267         tui-winsource.h.
1268         (struct tui_source_window_base): Likewise.
1269         * tui/tui-data.c (tui_source_window_base::clear_detail)
1270         (tui_source_window_base, ~tui_source_window_base): Move to
1271         tui-winsource.c.
1272
1273 2019-07-17  Tom Tromey  <tom@tromey.com>
1274
1275         * tui/tui-win.c (tui_resize_all)
1276         (tui_source_window_base::update_tab_width)
1277         (tui_adjust_win_heights): Update.
1278         (tui_win_info::make_invisible_and_set_new_height): Rename from
1279         make_invisible_and_set_new_height.
1280         * tui/tui-data.h (struct tui_win_info)
1281         <make_invisible_and_set_new_height>: New method.
1282
1283 2019-07-17  Tom Tromey  <tom@tromey.com>
1284
1285         * tui/tui.c: Update.
1286         * tui/tui-source.h (struct tui_source_window): Move from
1287         tui-data.h.
1288         * tui/tui-layout.c: Update.
1289         * tui/tui-disasm.c: Update.
1290         * tui/tui-data.h (struct tui_source_window): Move to
1291         tui-source.h.
1292
1293 2019-07-17  Tom Tromey  <tom@tromey.com>
1294
1295         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1296         tui-data.h.
1297         * tui/tui-data.h (struct tui_disasm_window): Move to
1298         tui-disasm.h.
1299
1300 2019-07-17  Tom Tromey  <tom@tromey.com>
1301
1302         * tui/tui-regs.h (struct tui_data_item_window): Move from
1303         tui-data.h.
1304         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1305         * tui/tui-data.h (struct tui_data_item_window): Move to
1306         tui-regs.h.
1307         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1308
1309 2019-07-17  Tom Tromey  <tom@tromey.com>
1310
1311         * tui/tui.c: Update.
1312         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1313         (tui_cmd_window::max_height): Move to tui-command.c.
1314         * tui/tui-layout.c: Update.
1315         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1316         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1317         tui-command.c.
1318         * tui/tui-command.h (struct tui_cmd_window): Move from
1319         tui-data.h.
1320         * tui/tui-command.c: Remove "structuring" comments.
1321         (tui_cmd_window::clear_detail)
1322         (tui_cmd_window::do_make_visible_with_new_height)
1323         (tui_cmd_window::max_height): Move from elsewhere.
1324
1325 2019-07-17  Tom Tromey  <tom@tromey.com>
1326
1327         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1328         Now static.
1329         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1330         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1331
1332 2019-07-17  Tom Tromey  <tom@tromey.com>
1333
1334         * tui/tui.c: Update.
1335         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1336         tui-regs.c.
1337         * tui/tui-windata.h: Remove file.
1338         * tui/tui-windata.c: Remove file.
1339         * tui/tui-win.c (tui_data_window::set_new_height)
1340         (tui_data_window::do_make_visible_with_new_height): Move to
1341         tui-regs.c.
1342         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1343         * tui/tui-regs.c: Remove "structuring" comments.
1344         (tui_data_window::first_data_item_displayed)
1345         (tui_data_window::delete_data_content_windows)
1346         (tui_data_window::erase_data_content)
1347         (tui_data_window::display_all_data)
1348         (tui_data_window::refresh_all)
1349         (tui_data_window::do_scroll_vertical)
1350         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1351         (tui_data_window::do_make_visible_with_new_height)
1352         (tui_data_window::refresh_window): Move from elsewhere.
1353         (_initialize_tui_regs): Move to end of file.
1354         * tui/tui-layout.c: Update.
1355         * tui/tui-hooks.c: Update.
1356         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1357         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1358         tui-regs.c.
1359         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1360
1361 2019-07-17  Tom Tromey  <tom@tromey.com>
1362
1363         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1364         seen.
1365
1366 2019-07-17  Tom Tromey  <tom@tromey.com>
1367
1368         * tui/tui-win.c (tui_source_window_base::set_new_height)
1369         (tui_source_window_base::do_make_visible_with_new_height): Use
1370         m_has_locator field directly.
1371         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1372         method.
1373         (struct tui_source_window_base) <has_locator>: Likewise.
1374
1375 2019-07-17  Tom Tromey  <tom@tromey.com>
1376
1377         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1378         Don't declare.
1379         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1380         Remove.
1381         * tui/tui-win.c (tui_source_window_base::set_new_height)
1382         (tui_source_window_base::set_new_height)
1383         (make_invisible_and_set_new_height)
1384         (tui_source_window_base::do_make_visible_with_new_height)
1385         (tui_source_window_base::do_make_visible_with_new_height):
1386         Update.
1387         * tui/tui-layout.c (show_source_disasm_command, show_data)
1388         (show_source_or_disasm_and_command): Update.
1389         * tui/tui-layout.c (show_layout): Update.
1390
1391 2019-07-17  Tom Tromey  <tom@tromey.com>
1392
1393         * tui/tui-layout.c (make_data_window): Remove.
1394         (show_data): Unify creation and re-initialization cases.
1395
1396 2019-07-17  Tom Tromey  <tom@tromey.com>
1397
1398         * tui/tui-layout.c (make_source_window, make_disasm_window):
1399         Remove.
1400         (show_data): Unify creation and re-initialization cases.
1401
1402 2019-07-17  Tom Tromey  <tom@tromey.com>
1403
1404         * tui/tui-layout.c (make_command_window): Remove.
1405         (show_source_disasm_command, show_source_or_disasm_and_command):
1406         Unify creation and re-initialization cases.
1407
1408 2019-07-17  Tom Tromey  <tom@tromey.com>
1409
1410         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1411         creation and re-initialization cases.
1412
1413 2019-07-17  Tom Tromey  <tom@tromey.com>
1414
1415         * tui/tui-regs.c (tui_get_register): Return void.
1416
1417 2019-07-17  Tom Tromey  <tom@tromey.com>
1418
1419         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1420         Simplify.
1421
1422 2019-07-17  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1425         resetting.
1426
1427 2019-07-17  Tom Tromey  <tom@tromey.com>
1428
1429         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1430         * tui/tui-regs.c (tui_reg_layout): New function.
1431         (tui_show_registers, tui_reg_command): Use it.
1432         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1433         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1434         parameters.
1435         (tui_layout_command): Remove.
1436
1437 2019-07-17  Tom Tromey  <tom@tromey.com>
1438
1439         * tui/tui-layout.h (tui/tui-layout): Return void.
1440         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1441
1442 2019-07-17  Tom Tromey  <tom@tromey.com>
1443
1444         * tui/tui-layout.c (show_source_disasm_command, show_data):
1445         Update.
1446         (reset_locator): Remove.
1447         (show_source_or_disasm_and_command): Update.
1448
1449 2019-07-17  Tom Tromey  <tom@tromey.com>
1450
1451         * tui/tui-source.c (tui_source_window_base::reset): Remove
1452         win_type parameter.
1453         * tui/tui-layout.c (make_command_window, make_source_window)
1454         (make_disasm_window, make_data_window)
1455         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1456         (reset_locator, show_source_or_disasm_and_command): Update.
1457         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1458         win_type parameter.
1459         (struct tui_source_window_base) <reset>: Likewise.
1460
1461 2019-07-17  Tom Tromey  <tom@tromey.com>
1462
1463         * tui/tui-layout.c (show_source_disasm_command): Use
1464         reset_locator.
1465         (reset_locator): New function.
1466         (init_and_make_win): Remove.
1467         (show_source_or_disasm_and_command): Use reset_locator.
1468
1469 2019-07-17  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1472         condition.
1473         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1474         Remove condition.
1475         * tui/tui-source.c (tui_source_window_base::reset): New method.
1476         * tui/tui-layout.c (make_command_window): Don't call
1477         init_and_make_win.
1478         (make_source_window, make_disasm_window): Don't call
1479         make_source_or_disasm_window.
1480         (make_data_window): Don't call init_and_make_win.  Change calling
1481         convention.
1482         (show_source_disasm_command, show_data): Simplify.
1483         (make_source_or_disasm_window): Remove.
1484         (show_source_or_disasm_and_command): Simplify.
1485         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1486         (struct tui_source_window_base) <reset>: Likewise.
1487         <execution_info>: Remove initializer.
1488         * tui/tui-data.c (tui_source_window_base): Initialize
1489         execution_info.
1490
1491 2019-07-17  Tom Tromey  <tom@tromey.com>
1492
1493         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1494         variable.
1495
1496 2019-07-17  Tom Tromey  <tom@tromey.com>
1497
1498         * tui/tui.c (tui_rl_other_window): Update.
1499         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1500         superclass method first.  Always iterate over regs_content.
1501         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1502         method.
1503         * tui/tui-win.c (tui_set_focus_command): Update.
1504
1505 2019-07-17  Tom Tromey  <tom@tromey.com>
1506
1507         * tui/tui-win.c (tui_set_focus_command): Rename from
1508         tui_set_focus.  Call tui_enable.
1509         (tui_set_focus_command): Remove.
1510
1511 2019-07-17  Tom Tromey  <tom@tromey.com>
1512
1513         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1514         refresh_window.
1515         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1516         touchwin.
1517         (tui_data_window::refresh_window): Call refresh_window on data
1518         items.  Always call superclass refresh_window.
1519         (tui_win_info::refresh): Remove.
1520         (tui_source_window_base::refresh_window): Update.
1521         (tui_refresh_all): Update.
1522         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1523         refresh_window.
1524         (show_source_or_disasm_and_command): Likewise.
1525         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1526         (struct tui_source_window_base) <refresh>: Likewise.
1527
1528 2019-07-17  Tom Tromey  <tom@tromey.com>
1529
1530         * tui/tui-winsource.c (tui_clear_source_content)
1531         (tui_show_source_content): Update.
1532         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1533         whether content is empty.
1534         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1535         Remove.
1536
1537 2019-07-17  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1540         window's contents.
1541         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1542         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1543
1544 2019-07-17  Tom Tromey  <tom@tromey.com>
1545
1546         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1547         (struct tui_data_item_window): Update.
1548
1549 2019-07-17  Tom Tromey  <tom@tromey.com>
1550
1551         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1552         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1553         defines.
1554
1555 2019-07-17  Tom Tromey  <tom@tromey.com>
1556
1557         * tui/tui-winsource.h (tui_erase_source_content)
1558         (tui_clear_source_content): Remove "display_prompt" parameter.
1559         * tui/tui-winsource.c (tui_update_source_window_as_is)
1560         (tui_update_source_windows_with_addr): Update.
1561         (tui_clear_source_content): Remove "display_prompt" parameter.
1562         (tui_erase_source_content): Likewise.  Simplify.
1563         (tui_show_source_content): Update.
1564         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1565         * tui/tui-stack.c (tui_show_frame_info): Update.
1566         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1567         Remove defines.
1568
1569 2019-07-17  Tom Tromey  <tom@tromey.com>
1570
1571         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1572         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1573         parameter.
1574         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1575         parameter.
1576
1577 2019-07-17  Tom Tromey  <tom@tromey.com>
1578
1579         * tui/tui-winsource.c (tui_clear_source_content)
1580         (tui_show_source_content, tui_show_exec_info_content)
1581         (tui_clear_exec_info_content): Update.
1582         * tui/tui-stack.c (tui_show_locator_content): Update.
1583         (tui_show_frame_info): Update.
1584         * tui/tui-source.h (tui_source_window): Don't declare.
1585         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1586         from tui_source_is_displayed.
1587         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1588         Remove field.
1589         (struct tui_source_window_base) <content_in_use>: New field.  Now
1590         bool.
1591         (struct tui_source_window) <showing_source_p>: New method.
1592         (TUI_SRC_WIN): Change cast.
1593         * tui/tui-data.c (tui_initialize_static_data): Update.
1594
1595 2019-07-17  Tom Tromey  <tom@tromey.com>
1596
1597         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1598         location_matches_p.
1599         * tui/tui-source.c (tui_source_window::location_matches_p): New
1600         method.
1601         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1602         method.
1603         * tui/tui-data.h (struct tui_source_window_base)
1604         <location_matches_p>: New method.
1605         (struct tui_source_window, struct tui_disasm_window)
1606         <location_matches_p>: Likewise.
1607
1608 2019-07-17  Tom Tromey  <tom@tromey.com>
1609
1610         * tui/tui-win.c (tui_set_win_height_command): Rename from
1611         tui_set_win_height.
1612         (tui_set_win_height_command): Remove.
1613
1614 2019-07-17  Tom Tromey  <tom@tromey.com>
1615
1616         * tui/tui-source.c (tui_source_window): New constructor.  Add
1617         observer.
1618         (~tui_source_window): New destructor.
1619         (tui_source_window::style_changed): New method.
1620         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1621         (tui_attach_detach_observers): Update.
1622         * tui/tui-data.h (struct tui_source_window): Make constructor not
1623         inline.  Add destructor.
1624         (struct tui_source_window) <style_changed>: New method.
1625         <m_observable>: New member.
1626
1627 2019-07-17  Tom Tromey  <tom@tromey.com>
1628
1629         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1630         * tui/tui-win.c (tui_resize_all): Fix typo.
1631
1632 2019-07-17  Tom Tromey  <tom@tromey.com>
1633
1634         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1635         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1636         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1637         * tui/tui-win.c (window_name_completer): Use foreach.
1638         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1639         (update_tab_width): Likewise.
1640         * tui/tui-layout.c (show_layout): Update.
1641         * tui/tui-data.h (class tui_window_iterator): New.
1642         (struct all_tui_windows): New.
1643         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1644
1645 2019-07-17  Tom Tromey  <tom@tromey.com>
1646
1647         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1648         parameter.  Don't reference globals.
1649         (tui_reg_command): Update.
1650
1651 2019-07-17  Tom Tromey  <tom@tromey.com>
1652
1653         * tui/tui-regs.c (tui_show_registers): Simplify.
1654
1655 2019-07-17  Tom Tromey  <tom@tromey.com>
1656
1657         * tui/tui-regs.c (tui_show_registers): Update.
1658         (tui_show_register_group): Add win_info parameter.
1659
1660 2019-07-17  Tom Tromey  <tom@tromey.com>
1661
1662         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1663         Rename from tui_display_reg_element_at_line.
1664         (tui_data_window::display_registers_from_line): Update.
1665         * tui/tui-data.h (struct tui_data_window)
1666         <display_reg_element_at_line>: New method.
1667
1668 2019-07-17  Tom Tromey  <tom@tromey.com>
1669
1670         * tui/tui-regs.h (tui_display_registers_from)
1671         (tui_display_registers_from_line): Don't declare.
1672         * tui/tui-windata.c (tui_data_window::display_all_data)
1673         (tui_data_window::refresh_all)
1674         (tui_data_window::do_scroll_vertical): Update.
1675         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1676         from tui_display_registers_from.
1677         (tui_display_reg_element_at_line): Update.
1678         (tui_data_window::display_registers_from_line): Rename from
1679         tui_display_registers_from_line.
1680         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1681         display_registers_from_line>: New methods.
1682
1683 2019-07-17  Tom Tromey  <tom@tromey.com>
1684
1685         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1686         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1687         from tui_erase_data_content.
1688         (tui_data_window::display_all_data)
1689         (tui_data_window::refresh_all)
1690         (tui_data_window::do_scroll_vertical): Update.
1691         * tui/tui-regs.c (tui_show_registers): Update.
1692         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1693         New method.
1694
1695 2019-07-17  Tom Tromey  <tom@tromey.com>
1696
1697         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1698         declare.
1699         * tui/tui-windata.c
1700         (tui_data_window::delete_data_content_windows): Rename from
1701         tui_delete_data_content_windows.
1702         (tui_data_window::display_all_data)
1703         (tui_data_window::do_scroll_vertical): Update.
1704         * tui/tui-data.h (struct tui_data_window)
1705         <delete_data_content_windows>: New method.
1706
1707 2019-07-17  Tom Tromey  <tom@tromey.com>
1708
1709         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1710         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1711
1712 2019-07-17  Tom Tromey  <tom@tromey.com>
1713
1714         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1715         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1716         from tui_display_all_data.
1717         * tui/tui-win.c
1718         (tui_data_window::do_make_visible_with_new_height): Update.
1719         * tui/tui-regs.c (tui_show_registers): Update.
1720         * tui/tui-layout.c (tui_set_layout): Update.
1721         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1722         method.
1723
1724 2019-07-17  Tom Tromey  <tom@tromey.com>
1725
1726         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1727         * tui/tui-windata.c (tui_display_data_from): Remove.
1728         (tui_data_window::refresh_all): Update.
1729
1730 2019-07-17  Tom Tromey  <tom@tromey.com>
1731
1732         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1733         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1734         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1735         tui_display_registers_from_line.
1736         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1737         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1738         "force_display" parameter.
1739
1740 2019-07-17  Tom Tromey  <tom@tromey.com>
1741
1742         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1743         declare.
1744         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1745         Rename from tui_first_reg_element_no_inline.
1746         (tui_display_reg_element_at_line)
1747         (tui_display_registers_from_line): Update.
1748         * tui/tui-data.h (struct tui_data_window)
1749         <first_reg_element_no_inline>: New method.
1750
1751 2019-07-17  Tom Tromey  <tom@tromey.com>
1752
1753         * tui/tui-windata.c (tui_display_data_from)
1754         (tui_data_window::do_scroll_vertical): Update.
1755         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1756         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1757         Rename from tui_line_from_reg_element_no.
1758         (tui_display_registers_from_line): Update.
1759         * tui/tui-data.h (struct tui_data_window)
1760         <line_from_reg_element_no>: New method.
1761
1762 2019-07-17  Tom Tromey  <tom@tromey.com>
1763
1764         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1765         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1766         tui_last_regs_line_no.
1767         (tui_display_reg_element_at_line)
1768         (tui_display_registers_from_line): Update.
1769         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1770         method.
1771
1772 2019-07-17  Tom Tromey  <tom@tromey.com>
1773
1774         PR tui/24722:
1775         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1776         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1777         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1778         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1779         (tui_update_breakpoint_info): Likewise.
1780         * tui/tui-hooks.c (tui_event_create_breakpoint)
1781         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1782         Update.
1783
1784 2019-07-17  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1787
1788 2019-07-17  Tom Tromey  <tom@tromey.com>
1789
1790         * tui/tui-winsource.c (tui_update_source_window_as_is)
1791         (tui_update_source_windows_with_addr): Update.
1792         * tui/tui-source.h (tui_set_source_content)
1793         (tui_show_symtab_source): Add "win_info" parameter.
1794         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1795         parameter.
1796         (tui_show_symtab_source): Likewise.
1797
1798 2019-07-17  Tom Tromey  <tom@tromey.com>
1799
1800         * tui/tui-wingeneral.c
1801         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1802
1803 2019-07-17  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1806         (struct tui_cmd_window) <can_scroll>: New method.
1807         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1808         method.
1809
1810 2019-07-17  Tom Tromey  <tromey@adacore.com>
1811
1812         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1813         do_field_signed>: Rename.  Change type of "value".
1814         * ui-out.c (ui_out::field_signed): Rename from field_int.
1815         Change type of "value".
1816         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1817         type of "value".
1818         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1819         do_field_int.  Change type of "value".
1820         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1821         do_field_int.  Change type of "value".
1822         * tracepoint.c (trace_status_mi, tfind_1)
1823         (print_one_static_tracepoint_marker): Update.
1824         * thread.c (print_thread_info_1, print_selected_thread_frame):
1825         Update.
1826         * stack.c (print_frame, print_frame_info): Update.
1827         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1828         Update.
1829         * source.c (print_source_lines_base): Update.
1830         * skip.c (info_skip_command): Update.
1831         * record-btrace.c (btrace_ui_out_decode_error)
1832         (btrace_call_history_src_line): Update.
1833         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1834         Update.
1835         * progspace.c (print_program_space): Update.
1836         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1837         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1838         do_field_int.  Change type of "value".
1839         * mi/mi-out.c (mi_ui_out::do_table_begin)
1840         (mi_ui_out::do_table_header): Update.
1841         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1842         type of "value".
1843         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1844         (mi_cmd_data_list_changed_registers, output_register)
1845         (mi_cmd_data_read_memory, mi_load_progress)
1846         (mi_cmd_trace_frame_collected): Update.
1847         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1848         Update.
1849         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1850         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1851         (mi_cmd_var_list_children, varobj_update_one): Update.
1852         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1853         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1854         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1855         * inferior.c (print_inferior): Update.
1856         * gdb_bfd.c (print_one_bfd): Update.
1857         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1858         Update.
1859         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1860         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1861         do_field_int.  Change type of "value".
1862         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1863         do_field_int.  Change type of "value".
1864         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1865         (print_one_breakpoint_location, print_it_catch_fork)
1866         (print_one_catch_fork, print_it_catch_vfork)
1867         (print_one_catch_vfork, print_it_catch_solib)
1868         (print_it_catch_exec, print_it_ranged_breakpoint)
1869         (print_mention_watchpoint, print_mention_masked_watchpoint)
1870         (bkpt_print_it, update_static_tracepoint): Update.
1871         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1872         * break-catch-syscall.c (print_it_catch_syscall): Update.
1873         * ada-tasks.c (print_ada_task_info): Update.
1874         * ada-lang.c (print_it_exception, print_mention_exception):
1875         Update.
1876
1877 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1878
1879         PR breakpoints/24541
1880         * gdbarch.c: Regenerate.
1881         * gdbarch.h: Regenerate.
1882         * gdbarch.sh: Adjust return type and parameter types for
1883         'stap_adjust_register'.
1884         (i386_stap_adjust_register): Adjust signature and return new
1885         register name.
1886         * stap-probe.c (stap_parse_register_operand): Adjust use of
1887         'gdbarch_stap_adjust_register'.
1888
1889 2019-07-17  Tom Tromey  <tromey@adacore.com>
1890
1891         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1892         declare VEC.
1893         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1894         std::vector.
1895         (struct s390_process_info): Add initializers.
1896         (s390_add_process): Use new.
1897         (s390_linux_nat_target::low_forget_process): Use delete.
1898         (s390_linux_nat_target::low_new_fork)
1899         (s390_linux_nat_target::stopped_by_watchpoint)
1900         (s390_linux_nat_target::low_prepare_to_resume)
1901         (s390_linux_nat_target::insert_watchpoint)
1902         (s390_linux_nat_target::insert_hw_breakpoint)
1903         (s390_linux_nat_target::remove_watchpoint)
1904         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1905
1906 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1907
1908         * aarch64-fbsd-nat.c: Include regcache.h.
1909         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1910         argument.
1911         (aarch64_fbsd_nat_target::fetch_registers)
1912         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1913         variable.
1914         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1915
1916 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1917
1918         * fbsd-nat.c: Include gdbarch.h.
1919
1920 2019-07-15  Tom Tromey  <tromey@adacore.com>
1921
1922         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1923
1924 2019-07-15  Tom Tromey  <tromey@adacore.com>
1925
1926         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1927         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1928         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1929         * cli-out.c (cli_ui_out::do_field_int): New method.
1930         * ui-out.c (ui_out::field_unsigned): New method.
1931         * symfile.c (generic_load): Use field_unsigned.
1932         (print_transfer_performance): Likewise.
1933         * record-btrace.c (ui_out_field_uint): Remove.
1934         (btrace_call_history_insn_range, btrace_call_history): Use
1935         field_unsigned.
1936         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1937         field_unsigned.
1938         * ui-out.h (class ui_out) <field_unsigned>: New method.
1939         <do_field_unsigned>: Likewise.
1940
1941 2019-07-15  Tom Tromey  <tromey@adacore.com>
1942
1943         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1944         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1945         * target.c (flash_erase_command): Use field_string.
1946         * infrun.c (print_signal_received_reason): Use field_string.
1947         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1948         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1949         field_string.
1950         * ada-tasks.c (print_ada_task_info): Use field_string.
1951
1952 2019-07-15  Tom Tromey  <tromey@adacore.com>
1953
1954         * target.c (flash_erase_command): Use field_core_addr.
1955         * symfile.c (generic_load): Use field_core_addr.
1956         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1957         Use field_core_addr.
1958         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1959         field_core_addr.
1960
1961 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1962
1963         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1964         value if its desired type is smaller than a CORE_ADDR and signed.
1965
1966 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1967
1968         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1969         of changes to field names, and use new is_reference field to
1970         decide if a property is a reference or not.
1971         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1972         field.
1973         (struct dwarf2_property_baton): Update header comment, rename
1974         'referenced_type' to 'property_type' and update comments.
1975         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1976         default property type, store in property baton, update to take
1977         accound of renamed field.
1978         (read_func_scope): Update call to attr_to_dynamic_prop.
1979         (read_array_type): Likewise.
1980         (dwarf2_per_cu_addr_sized_int_type): New function.
1981         (read_subrange_index_type): Move type finding code to
1982         dwarf2_per_cu_addr_sized_int_type.
1983         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1984         (dwarf2_per_cu_addr_type): New function.
1985         (set_die_type): Update calls to attr_to_dynamic_prop.
1986
1987 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1988
1989         * dwarf2read.c (read_subrange_index_type): New function.
1990         (read_subrange_type): Move code into new function and call it.
1991         * gdbtypes.c (create_range_type): Add some asserts.
1992
1993 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1994
1995         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1996         update return statements.
1997         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1998         declaration, and update comment to match.
1999         * gdbtypes.c (resolve_dynamic_array): Update call to
2000         dwarf2_evaluate_property to match new return type.
2001
2002 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2003
2004         * valarith.c (value_subscripted_rvalue): Change lowerbound
2005         parameter type from int to LONGEST.
2006         * value.h (value_subscripted_rvalue): Likewise in declaration.
2007
2008 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2009
2010         * cli/cli-utils.c (info_print_command_completer): New function.
2011         * cli/cli-utils.h: Add 'completer.h' include, and forward
2012         declaration for 'struct cmd_list_element'.
2013         (info_print_command_completer): Declare.
2014         * stack.c (_initialize_stack): Add completer for 'info locals' and
2015         'info args'.
2016         * symtab.c (_initialize_symtab): Add completer for 'info
2017         variables' and 'info functions'.
2018         * NEWS: Mention completion for additional info commands.
2019
2020 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2021
2022         * cli/cli-utils.c (extract_info_print_args): Delete.
2023         (extract_arg_maybe_quoted): Delete.
2024         (info_print_options_defs): New variable.
2025         (make_info_print_options_def_group): New function.
2026         (extract_info_print_options): Define new function.
2027         * cli/cli-utils.h (extract_info_print_args): Delete.
2028         (struct info_print_options): New structure.
2029         (extract_info_print_options): Declare new function.
2030         * stack.c (info_locals_command): Update to use new
2031         extract_info_print_options, also add a header comment.
2032         (info_args_command): Likewise.
2033         * symtab.c (info_variables_command): Likewise.
2034         (info_functions_command): Likewise.
2035
2036 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2037
2038         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2039         to extract string arguments.
2040         * common/common-utils.c (extract_string_maybe_quoted): New function.
2041         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2042
2043 2019-07-11  Tom Tromey  <tromey@adacore.com>
2044
2045         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2046         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2047         * top.h (gdbinit): Don't declare.
2048         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2049         into...
2050         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2051         * top.c (gdb_init): Don't call init_cli_cmds.
2052         (gdbinit): Remove.
2053         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2054
2055 2019-07-11  Tom Tromey  <tromey@adacore.com>
2056
2057         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2058         after it has been moved.
2059
2060 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2061
2062         * valops.c (value_must_coerce_to_target): Change return type to
2063         bool.
2064         * value.h (value_must_coerce_to_target): Likewise.
2065
2066 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2067
2068         * breakpoint.c (is_hardware_watchpoint): Remove
2069         forward-declaration.
2070         (is_masked_watchpoint): Change return type to bool.
2071         (is_tracepoint): Likewise.
2072         (is_breakpoint): Likewise.
2073         (is_hardware_watchpoint): Likewise.
2074         (is_watchpoint): Likewise.
2075         (is_no_memory_software_watchpoint): Likewise.
2076         (is_catchpoint): Likewise.
2077         (breakpoint_1): Make FILTER parameter's return type bool.
2078         is_masked_watchpoint): Change return type to bool.
2079         (save_breakpoints): Make FILTER parameter's return type bool.
2080         * breakpoint.h (is_breakpoint): Change return type to bool.
2081         (is_watchpoint): Likewise.
2082         (is_catchpoint): Likewise.
2083         (is_tracepoint): Likewise.
2084
2085 2019-07-10  Tom Tromey  <tom@tromey.com>
2086
2087         * defs.h: Don't include gdbarch.h.
2088         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2089         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2090         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2091         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2092         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2093         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2094         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2095         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2096         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2097         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2098         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2099         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2100         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2101         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2102         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2103         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2104         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2105         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2106         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2107         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2108         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2109         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2110         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2111         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2112         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2113         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2114         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2115
2116 2019-07-10  Tom Tromey  <tromey@adacore.com>
2117
2118         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2119         * breakpoint.c (init_ada_exception_breakpoint): Register as
2120         bp_catchpoint.
2121         (print_one_breakpoint_location, print_one_breakpoint): Use
2122         is_ada_exception_catchpoint.
2123         * ada-lang.c (class ada_catchpoint_location): Pass
2124         bp_loc_software_breakpoint to bp_location constructor.
2125         (is_ada_exception_catchpoint): New function.
2126
2127 2019-07-10  Tom Tromey  <tromey@adacore.com>
2128
2129         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2130         VEC.
2131         (struct arm_exidx_entry): New method operator<.
2132         (struct arm_exidx_data) <section_maps>: Change type.
2133         (arm_exidx_data_free): Remove.
2134         (arm_exidx_data_key): Change type.  Move lower.
2135         (arm_exidx_new_objfile): Update.
2136         (arm_compare_exidx_entries): Remove.
2137         (arm_find_exidx_entry, _initialize_arm_tdep)
2138
2139 2019-07-10  Tom Tromey  <tromey@adacore.com>
2140
2141         * solib-spu.c (ocl_program_data_key): Change type.
2142         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2143         Update.
2144
2145 2019-07-10  Tom Tromey  <tromey@adacore.com>
2146
2147         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2148         (struct solib_aix_inferior_data) <library_list>: Change type.
2149         (solib_aix_inferior_data_handle): Change type.
2150         (get_solib_aix_inferior_data): Update.
2151         (solib_aix_free_library_list): Remove.
2152         (library_list_start_library): Update.
2153         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2154         return type.
2155         (solib_aix_get_library_list)
2156         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2157         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2158
2159 2019-07-10  Tom Tromey  <tromey@adacore.com>
2160
2161         * solib-dsbt.c (struct dsbt_info): Add initializers.
2162         (solib_dsbt_pspace_data): Change type.
2163         (dsbt_pspace_data_cleanup): Remove.
2164         (get_dsbt_info, _initialize_dsbt_solib): Update.
2165
2166 2019-07-10  Tom Tromey  <tromey@adacore.com>
2167
2168         * spu-tdep.c (spu_overlay_data): Change type.
2169         (spu_get_overlay_table, spu_overlay_new_objfile)
2170         (_initialize_spu_tdep): Update.
2171
2172 2019-07-10  Tom Tromey  <tromey@adacore.com>
2173
2174         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2175         destructor.
2176         (dbx_objfile_data_key): Change type and declare later.
2177         (DBX_SYMFILE_INFO): Rewrite.
2178         * dbxread.c (dbx_objfile_data_key): Change type.
2179         (dbx_symfile_init): Update.
2180         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2181         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2182         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2183
2184 2019-07-10  Tom Tromey  <tromey@adacore.com>
2185
2186         * jit.c (jit_program_space_key): Change type.  Move lower.
2187         (get_jit_program_space_data): Update.
2188         (jit_program_space_data_cleanup): Remove.
2189         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2190         Update.
2191         (struct jit_program_space_data): Add initializers.
2192
2193 2019-07-10  Tom Tromey  <tromey@adacore.com>
2194
2195         * solib-darwin.c (struct darwin_info): Add initializers.
2196         (solib_darwin_pspace_data): Change type.
2197         (darwin_pspace_data_cleanup): Remove.
2198         (get_darwin_info, _initialize_darwin_solib): Update.
2199
2200 2019-07-10  Tom Tromey  <tromey@adacore.com>
2201
2202         * remote-sim.c (struct sim_inferior_data): Add initializers,
2203         constructor, and destructor.
2204         (sim_inferior_data_key): Change type.  Move lower.
2205         (check_for_duplicate_sim_descriptor): Update.
2206         (get_sim_inferior_data): Use new.  Update.
2207         (~sim_inferior_data_cleanup): Rename from
2208         sim_inferior_data_cleanup.  Simplify.
2209         (gdbsim_close_inferior, simulator_command)
2210         (sim_command_completer, _initialize_remote_sim): Update.
2211         (next_pid, INITIAL_PID): Move earlier.
2212
2213 2019-07-10  Tom Tromey  <tromey@adacore.com>
2214
2215         * python/python-internal.h (create_thread_object): Return
2216         gdbpy_ref.
2217         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2218         * python/py-inferior.c (struct threadlist_entry): Add
2219         constructor.
2220         <thread_obj>: Now a gdbpy_ref.
2221         (thread_to_thread_object): Update.
2222         (add_thread_object): Use new.
2223         (delete_thread_object): Use delete.
2224         (infpy_threads): Update.
2225         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2226         GIL.
2227
2228 2019-07-10  Tom Tromey  <tromey@adacore.com>
2229
2230         * valops.c (value_cast): Specialize error message for Ada.
2231
2232 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2233
2234         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2235
2236 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2237
2238         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2239         bpstat_should_step): Return bool, adjust comments.
2240         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2241         bpstat_should_step): Likewise.
2242
2243 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2244
2245         * features/Makefile: Use feature target descriptions for Arm.
2246         * features/arm/arm-core.c: Generate new file.
2247         * features/arm/arm-fpa.c: Likewise.
2248         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2249         * features/arm/arm-m-profile.c: Likewise.
2250         * features/arm/arm-vfpv2.c: Likewise.
2251         * features/arm/arm-vfpv3.c: Likewise.
2252         * features/arm/xscale-iwmmxt.c: Likewise.
2253         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2254
2255 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2256
2257         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2258         ptrace earlier.
2259
2260 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2261
2262         * features/aarch64-pauth.c: Regenerate.
2263
2264 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2265
2266         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2267         bool.
2268         (bpstat_what): Use false instead of 0.
2269
2270 2019-07-09  Pedro Alves  <palves@redhat.com>
2271
2272         * break-catch-throw.c (is_exception_catchpoint): New.
2273         * breakpoint.c (print_one_breakpoint_location): New parameter
2274         'raw_loc'.  Handle it.  Use
2275         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2276         looking at the breakpoint's type.
2277         (print_one_breakpoint): If handling "maint info breakpoints", also
2278         print locations of exception catchpoints.
2279         * breakpoint.h (is_exception_catchpoint): Declare.
2280
2281 2019-07-09  Pedro Alves  <palves@redhat.com>
2282
2283         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2284         "addr" field.
2285         (allocate_location_exception_catchpoint): New.
2286         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2287         (initialize_throw_catchpoint_ops): Install
2288         allocate_location_exception_catchpoint as allocate_location
2289         method.
2290         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2291         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2292         bp_loc_other.
2293         (breakpoint_address_is_meaningful): Delete.
2294         (bl_address_is_meaningful): New.
2295         (breakpoint_locations_match): Adjust comment.
2296         (bp_location_from_bp_type): New, factored out of...
2297         (bp_location::bp_location(breakpoint *)): ... this.
2298         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2299         factored out of...
2300         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2301         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2302         breakpoint_address_is_meaningful.
2303         (bp_locations_compare): Adjust comment.
2304         (update_global_location_list): Use bl_address_is_meaningful
2305         instead of breakpoint_address_is_meaningful.
2306         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2307         explicit.
2308         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2309         * python/py-breakpoint.c (bppy_get_location): No longer check
2310         whether location is null.
2311
2312 2019-07-09  Pedro Alves  <palves@redhat.com>
2313
2314         PR c++/15468
2315         * breakpoint.c (print_one_breakpoint_location): Remove
2316         single-location assert.
2317
2318 2019-07-09  Tom Tromey  <tom@tromey.com>
2319
2320         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2321         * configure: Rebuild.
2322         * configure.ac: Change common to gdbsupport.
2323         * gdbsupport: Rename from common.
2324         * acinclude.m4: Change common to gdbsupport.
2325         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2326         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2327         gdbsupport.
2328         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2329         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2330         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2331         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2332         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2333         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2334         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2335         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2336         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2337         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2338         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2339         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2340         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2341         coff-pe-read.c, command.h, compile/compile-c-support.c,
2342         compile/compile-c.h, compile/compile-cplus-symbols.c,
2343         compile/compile-cplus-types.c, compile/compile-cplus.h,
2344         compile/compile-loc2c.c, compile/compile.c, completer.c,
2345         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2346         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2347         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2348         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2349         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2350         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2351         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2352         features/aarch64-core.c, features/aarch64-fpu.c,
2353         features/aarch64-pauth.c, features/aarch64-sve.c,
2354         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2355         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2356         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2357         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2358         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2359         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2360         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2361         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2362         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2363         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2364         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2365         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2366         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2367         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2368         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2369         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2370         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2371         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2372         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2373         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2374         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2375         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2376         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2377         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2378         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2379         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2380         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2381         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2382         minsyms.c, mips-linux-tdep.c, namespace.h,
2383         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2384         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2385         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2386         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2387         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2388         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2389         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2390         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2391         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2392         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2393         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2394         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2395         procfs.c, producer.c, progspace.h, psymtab.h,
2396         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2397         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2398         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2399         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2400         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2401         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2402         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2403         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2404         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2405         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2406         target-memory.c, target.c, target.h, target/waitstatus.c,
2407         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2408         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2409         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2410         unittests/array-view-selftests.c,
2411         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2412         unittests/common-utils-selftests.c,
2413         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2414         unittests/format_pieces-selftests.c,
2415         unittests/function-view-selftests.c,
2416         unittests/lookup_name_info-selftests.c,
2417         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2418         unittests/mkdir-recursive-selftests.c,
2419         unittests/observable-selftests.c,
2420         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2421         unittests/parse-connection-spec-selftests.c,
2422         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2423         unittests/scoped_fd-selftests.c,
2424         unittests/scoped_mmap-selftests.c,
2425         unittests/scoped_restore-selftests.c,
2426         unittests/string_view-selftests.c, unittests/style-selftests.c,
2427         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2428         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2429         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2430         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2431         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2432         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2433
2434 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2435
2436         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2437         bool value.
2438         (decode_digits_ordinary): Set explicit_line field in sal.
2439         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2440         symtab_and_line that was set on an explicit line number in
2441         assembler code.  Do always update the recorded symtab and line if
2442         we do skip the prologue.
2443
2444 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2445
2446         * breakpoint.c (set_breakpoint_location_function): Remove
2447         explicit_loc parameter.
2448         (momentary_breakpoint_from_master): Update call to
2449         set_breakpoint_location_function.
2450         (add_location_to_breakpoint): Likewise.
2451
2452 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2453
2454         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2455         required features based on default bfd type when no specific bfd
2456         is present.
2457
2458 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2459
2460         * NEWS: Mention that GDB printf and eval commands can now print
2461         C-style and Ada-style convenience var strings without
2462         calling the inferior.
2463         * printcmd.c (printf_c_string): Locally print GDB internal var
2464         instead of transiting via the inferior.
2465         (printf_wide_c_string): Likewise.
2466
2467 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2468
2469         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2470
2471 2019-07-04  Tom Tromey  <tom@tromey.com>
2472
2473         PR tui/24724:
2474         * tui/tui-winsource.c (tui_clear_source_content): Update.
2475         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2476         (tui_update_breakpoint_info): Update.
2477         (tui_set_exec_info_content): Update.
2478         * tui/tui-source.c (tui_set_source_content_nil): Update.
2479         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2480         has_break.
2481         * tui/tui-data.h (enum tui_bp_flag): New.
2482         (tui_bp_flags): New enum flags type.
2483         (struct tui_source_element) <break_mode>: Change type.  Rename
2484         from has_break.
2485         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2486         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2487         constants.
2488         * tui/tui-winsource.h: Fix comment.
2489
2490 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2491
2492         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2493         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2494         (store_fpregs_to_thread)
2495         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2496         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2497         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2498         (IWMMXT_REGS_SIZE): Add define.
2499         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2500         (fetch_vfp_regs, store_vfp_regs)
2501         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2502         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2503
2504 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2505
2506         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2507         defines.
2508         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2509         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2510         (ARM_INT_REGISTER_SIZE): ...to this.
2511         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2512         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2513         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2514         (arm_linux_collect_gregset, supply_nwfpe_register)
2515         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2516         defines.
2517         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2518         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2519         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2520         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2521         (arm_return_in_memory, arm_store_return_value)
2522         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2523         (arm_record_ld_st_multiple): Likewise.
2524         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2525         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2526
2527 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2528
2529         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2530         AARCH64_DISPLACED_MODIFIED_INSNS.
2531         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2532         (aarch64_displaced_step_copy_insn): Likewise.
2533         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2534         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2535         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2536         ARM_DISPLACED_MODIFIED_INSNS.
2537         * arm-tdep.c (arm_gdbarch_init): Likewise.
2538         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2539         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2540         (struct arm_displaced_step_closure): Use
2541         ARM_DISPLACED_MODIFIED_INSNS.
2542
2543 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2544
2545         * features/Makefile: Remove unused xml files.
2546         * features/aarch64.xml: Remove.
2547         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2548         * features/i386/amd64-avx-avx512.xml: Remove.
2549         * features/i386/amd64-avx-linux.xml: Remove.
2550         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2551         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2552         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2553         * features/i386/amd64-avx-mpx.xml: Remove.
2554         * features/i386/amd64-avx.xml: Remove.
2555         * features/i386/amd64-linux.xml: Remove.
2556         * features/i386/amd64-mpx-linux.xml: Remove.
2557         * features/i386/amd64-mpx.xml: Remove.
2558         * features/i386/amd64.xml: Remove.
2559         * features/i386/i386-avx-avx512-linux.xml: Remove.
2560         * features/i386/i386-avx-avx512.xml: Remove.
2561         * features/i386/i386-avx-linux.xml: Remove.
2562         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2563         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2564         * features/i386/i386-avx-mpx-linux.xml: Remove.
2565         * features/i386/i386-avx-mpx.xml: Remove.
2566         * features/i386/i386-avx.xml: Remove.
2567         * features/i386/i386-linux.xml: Remove.
2568         * features/i386/i386-mmx-linux.xml: Remove.
2569         * features/i386/i386-mmx.xml: Remove.
2570         * features/i386/i386-mpx-linux.xml: Remove.
2571         * features/i386/i386-mpx.xml: Remove.
2572         * features/i386/i386.xml: Remove.
2573         * features/i386/x32-avx-avx512-linux.xml: Remove.
2574         * features/i386/x32-avx-linux.xml: Remove.
2575         * features/i386/x32-linux.xml: Remove.
2576
2577 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2578
2579         * regformats/aarch64.dat: Remove.
2580         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2581         * regformats/i386/amd64-avx-linux.dat: Remove.
2582         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2583         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2584         * regformats/i386/amd64-linux.dat: Remove.
2585         * regformats/i386/amd64-mpx-linux.dat: Remove.
2586         * regformats/i386/amd64.dat: Remove.
2587         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2588         * regformats/i386/i386-avx-linux.dat: Remove.
2589         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2590         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2591         * regformats/i386/i386-linux.dat: Remove.
2592         * regformats/i386/i386-mmx-linux.dat: Remove.
2593         * regformats/i386/i386-mpx-linux.dat: Remove.
2594         * regformats/i386/i386.dat: Remove.
2595         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2596         * regformats/i386/x32-avx-linux.dat: Remove.
2597         * regformats/i386/x32-linux.dat: Remove.
2598
2599 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2600
2601         * aarch64-tdep.c: Remove xml self tests.
2602         * amd64-linux-tdep.c: Likewise.
2603         * amd64-tdep.c: Likewise.
2604         * i386-linux-tdep.c: Likewise.
2605         * i386-tdep.c: Likewise.
2606
2607 2019-07-03  Pedro Alves  <palves@redhat.com>
2608
2609         PR cli/24732
2610         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2611         (pipe_cmd_option_defs): New.
2612         (make_pipe_cmd_options_def_group): New.
2613         (pipe_command): Use gdb::option::process_options.
2614         (pipe_command_completer): New function.
2615         (_initialize_cli_cmds): Install completer for "pipe" command.
2616
2617 2019-07-03  Pedro Alves  <palves@redhat.com>
2618
2619         * cli/cli-option.c (union option_value) <string>: New field.
2620         (struct option_def_and_value): Add ctor, move ctor, dtor and
2621         use DISABLE_COPY_AND_ASSIGN.
2622         (option_def_and_value::clear_value): New.
2623         (parse_option, save_option_value_in_ctx, get_val_type_str)
2624         (add_setshow_cmds_for_options): Handle var_string.
2625         * cli-option.h (union option_def::var_address) <string>: New
2626         field.
2627         (struct string_option_def): New.
2628         * maint-test-options.c (struct test_options_opts): Add default
2629         ctor and use DISABLE_COPY_AND_ASSIGN.
2630         <string_opt>: New field.
2631         (test_options_opts::~test_options_opts): New.
2632         (test_options_opts::dump): Also dump "-string".
2633         (test_options_option_defs): Install "string.
2634
2635 2019-07-03  Pedro Alves  <palves@redhat.com>
2636
2637         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2638         option_value with a null enumeration.
2639         (complete_options): Save the option values in the context.
2640         (save_option_value_in_ctx): New, factored out from ...
2641         (process_options): ... here.
2642         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2643         of the function.
2644         * maint-test-options.c (test_options_opts::dump): New, factored
2645         out from ...
2646         (maintenance_test_options_command_mode): ... here.
2647         (maintenance_test_options_command_completion_result): Delete.
2648         (maintenance_test_options_command_completion_text): Update
2649         comment.
2650         (maintenance_show_test_options_completion_result): Change
2651         prototype.  Just print
2652         maintenance_test_options_command_completion_text.
2653         (save_completion_result): New.
2654         (maintenance_test_options_completer_mode): Pass options context to
2655         complete_options, and then save a dump.
2656         (_initialize_maint_test_options): Use add_cmd to install "maint
2657         show test-options-completion-result".
2658
2659 2019-07-03  Pedro Alves  <palves@redhat.com>
2660
2661         * NEWS (New commands): Mention "with" and "maint with".
2662         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2663         (with_command, with_command_completer): New.
2664         (pipe_command): Adjust to new repeat_previous
2665         interface.
2666         (_initialize_cli_cmds): Install the "with" command and its "w"
2667         alias.
2668         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2669         declarations.
2670         * cli/cli-setshow.c (parse_cli_var_uinteger)
2671         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2672         argument strings for all var_types.
2673         (get_setshow_command_value_string): New, factored out from ...
2674         (do_show_command): ... this.
2675         * cli/cli-setshow.h: Include <string>.
2676         (get_setshow_command_value_string): Declare.
2677         * command.h (repeat_previous): Now returns const char *.  Adjust
2678         comment.
2679         * maint.c: Include "cli/cli-cmds.h".
2680         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2681         (_initialize_maint_cmds): Register the "maintenance with" command.
2682         * top.c (repeat_previous): Move bits from pipe_command here:
2683         Return the saved command line, if any; error out if there's no
2684         command to relaunch.
2685
2686 2019-07-03  Pedro Alves  <palves@redhat.com>
2687
2688         * NEWS (New commands): Mention "maint set/show test-settings"
2689         instead of "maint test-settings".
2690         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2691         (maintenance_test_settings_set_list): Rename to ...
2692         (maintenance_set_test_settings_list): ... this.
2693         (maintenance_test_settings_show_list): Rename to  ...
2694         (maintenance_show_test_settings_list): ... this.
2695         (maintenance_test_settings_cmd): Delete.
2696         (maintenance_test_settings_set_cmd): ...
2697         (maintenance_set_test_settings_cmd): ... this.
2698         (maintenance_test_settings_show_cmd): ...
2699         (maintenance_show_test_settings_cmd): ... this.
2700         (maintenance_test_settings_show_value_cmd):
2701         (maintenance_show_test_settings_value_cmd): ... this.
2702         (_initialize_maint_test_settings): No longer install the "maint
2703         test-settings" prefix command.  Rename "maint test-settings set"
2704         to "maint set test-settings", and "maint test-settings show" to
2705         "maint show test-settings".  Adjust all subcommands.
2706
2707 2019-07-03  Pedro Alves  <palves@redhat.com>
2708
2709         * maint-test-settings.c: Fix file's intro comment.  Replace all
2710         references to "test-options" with references to "test-settings",
2711         in comments.
2712
2713 2019-07-03  Pedro Alves  <palves@redhat.com>
2714
2715         * maint-test-settings.c (maintenance_test_settings_xxx)
2716         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2717         New.
2718         (maintenance_test_settings_enums): Use them.
2719         (maintenance_test_settings_enum): Default to
2720         maintenance_test_settings_xxx.
2721         (_initialize_maint_test_settings): Initialize
2722         MAINTENANCE_TEST_SETTINGS_FILENAME.
2723
2724 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2725
2726         * breakpoint.h (remove_breakpoints_inf): Change return type to
2727         void, move function documentation here.
2728         * breakpoint.c (remove_breakpoints_inf): Change return type to
2729         void, move function documentation to header.
2730
2731 2019-07-02  Pedro Alves  <palves@redhat.com>
2732
2733         * NEWS (Completion improvements): Mention "info threads".
2734         * thread.c (struct info_threads_opts, info_threads_option_defs)
2735         (make_info_threads_options_def_group): New.
2736         (info_threads_command): Use gdb::option::process_options.
2737         (info_threads_command_completer): New.
2738         (_initialize_thread): Use gdb::option::build_help to build the
2739         help text for "info threads".
2740
2741 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2742
2743         * defs.h (generic_load): Move from here...
2744         * symfile.h (generic_load): ... to here.  Rename name parameter
2745         to args.
2746         * symfile.c (generic_load): Add comment.
2747
2748 2019-07-01  Tom Tromey  <tromey@adacore.com>
2749
2750         * dwarf2read.c
2751         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2752         declaration of without_params.  Fix formatting.
2753
2754 2019-07-01  Tom Tromey  <tromey@adacore.com>
2755
2756         * ada-exp.y (find_primitive_type): Update.
2757         * ada-lang.h (ada_lookup_symbol): Update.
2758         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2759         parameter.
2760         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2761
2762 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2763
2764         PR breakpoints/24541
2765         * gdbarch.c: Regenerate.
2766         * gdbarch.h: Regenerate.
2767         * gdbarch.sh: Add 'stap_adjust_register'.
2768         * i386-tdep.c: Include '<unordered_set>'.
2769         (i386_stap_adjust_register): New function.
2770         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2771         * stap-probe.c (stap_parse_register_operand): Call
2772         'gdbarch_stap_adjust_register'.
2773
2774 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2775
2776         PR python/24742
2777         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2778         * python/python.c (do_start_initialization): Use 'xmalloc'
2779         instead of 'PyMem_Malloc'.
2780
2781 2019-06-28  Tom Tromey  <tromey@adacore.com>
2782
2783         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2784         for Ada.
2785
2786 2019-06-27  Tom Tromey  <tromey@adacore.com>
2787
2788         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2789         objfile_key.
2790         (arm_find_mapping_symbol, arm_record_special_symbol)
2791         (_initialize_arm_tdep): Update.
2792         (arm_objfile_data_free): Remove.
2793
2794 2019-06-27  Tom Tromey  <tromey@adacore.com>
2795
2796         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2797         to cp_print_static_field.
2798
2799 2019-06-26  Tom Tromey  <tromey@adacore.com>
2800
2801         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2802         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2803         declare.
2804
2805 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2806
2807         * features/aarch64-core.c (create_feature_aarch64_core):
2808         Regenerate.
2809         * features/aarch64-core.xml: Add cpsr flags.
2810
2811 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2812
2813         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2814         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2815
2816 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2817
2818         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2819         field.
2820         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2821         use.
2822         (arm_record_special_symbol): Don't insert new symbol in sorted
2823         position, push it at the end.
2824
2825 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2826
2827         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2828         (arm_mapping_symbol_s): Remove.
2829         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2830         (arm_mapping_symbol_vec): New typedef.
2831         (struct arm_per_objfile): Add constructor.
2832         <section_maps>: Change type to
2833         std::unique_ptr<arm_mapping_symbol_vec[]>.
2834         (arm_compare_mapping_symbols): Remove.
2835         (arm_find_mapping_symbol): Adjust to section_maps type change.
2836         (arm_objfile_data_free): Call delete on arm_per_objfile.
2837         (arm_record_special_symbol): Adjust to section_maps type change.
2838         Allocate arm_per_objfile with new.
2839
2840 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2841
2842         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2843         with the command prefix.
2844
2845 2019-06-25  Tom Tromey  <tom@tromey.com>
2846
2847         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2848         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2849
2850 2019-06-25  Tom Tromey  <tom@tromey.com>
2851
2852         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2853         type.
2854         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2855         protected.
2856
2857 2019-06-25  Tom Tromey  <tom@tromey.com>
2858
2859         * tui/tui-winsource.c
2860         (tui_source_window_base::set_is_exec_point_at): Add check against
2861         LOA_ADDRESS.
2862
2863 2019-06-25  Tom Tromey  <tom@tromey.com>
2864
2865         * tui/tui-source.c (tui_set_source_content): Don't check before
2866         xfree.
2867         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2868
2869 2019-06-25  Tom Tromey  <tom@tromey.com>
2870
2871         * tui/tui-winsource.h (tui_update_source_window_as_is)
2872         (tui_alloc_source_buffer, tui_line_is_displayed)
2873         (tui_addr_is_displayed): Change type of win_info.
2874         * tui/tui-winsource.c (tui_update_source_window_as_is)
2875         (tui_clear_source_content, tui_show_source_line)
2876         (tui_show_source_content, tui_source_window_base::refill)
2877         (tui_source_window_base::set_is_exec_point_at)
2878         (tui_source_window_base::set_is_exec_point_at)
2879         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2880         (tui_alloc_source_buffer, tui_line_is_displayed)
2881         (tui_addr_is_displayed): Change type of win_info.  Update.
2882         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2883         (tui_source_window_base::do_make_visible_with_new_height):
2884         Update.
2885         * tui/tui-source.c (tui_set_source_content)
2886         (tui_set_source_content_nil)
2887         (tui_source_window::do_scroll_vertical): Update.
2888         * tui/tui-layout.c (show_layout): Update.
2889         * tui/tui-disasm.c (tui_set_disassem_content)
2890         (tui_disasm_window::do_scroll_vertical): Update.
2891         * tui/tui-data.h (tui_win_content): Remove.
2892         (struct tui_gen_win_info) <content, content_size>: Remove.
2893         (struct tui_source_element): Add initializers and destructor.
2894         (union tui_which_element, struct tui_win_element): Remove.
2895         (struct tui_source_window_base) <content>: New field.
2896         (struct tui_data_window): Remove destructor.
2897         (tui_alloc_content, tui_free_win_content)
2898         (tui_free_all_source_wins_content): Don't declare.
2899         * tui/tui-data.c (tui_initialize_static_data): Update.
2900         (init_content_element, tui_alloc_content): Remove.
2901         (~tui_gen_win_info): Update.
2902         (~tui_data_window, tui_free_all_source_wins_content)
2903         (tui_free_win_content, free_content, free_content_elements):
2904         Remove.
2905
2906 2019-06-25  Tom Tromey  <tom@tromey.com>
2907
2908         * tui/tui-winsource.h (tui_clear_source_content)
2909         (tui_erase_source_content, tui_show_source_content): Change type
2910         of win_info.
2911         * tui/tui-winsource.c (tui_clear_source_content)
2912         (tui_erase_source_content, tui_show_source_content): Change type
2913         of win_info.
2914         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2915         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2916         win_info.
2917         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2918         win_info.
2919         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2920
2921 2019-06-25  Tom Tromey  <tom@tromey.com>
2922
2923         * tui/tui-winsource.c (tui_clear_source_content)
2924         (tui_source_window_base::set_is_exec_point_at): Update.
2925         * tui/tui-source.c (tui_set_source_content_nil): Update.
2926         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2927         a bool.
2928         * tui/tui-data.c (init_content_element): Update.
2929
2930 2019-06-25  Tom Tromey  <tom@tromey.com>
2931
2932         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2933         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2934         * tui/tui-layout.c (init_and_make_win): Update.
2935         * tui/tui.h (enum tui_win_type): Update.
2936         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2937         tui_win_is_auxillary.
2938         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2939         tui_win_is_auxillary.
2940
2941 2019-06-25  Tom Tromey  <tom@tromey.com>
2942
2943         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2944         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2945         (tui_delete_data_content_windows, tui_display_all_data)
2946         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2947         Update.
2948         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2949         * tui/tui-regs.c (tui_last_regs_line_no)
2950         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2951         (tui_show_registers): Update.
2952         (tui_show_register_group): Return void.  Update.
2953         (tui_display_registers_from, tui_display_reg_element_at_line)
2954         (tui_display_registers_from_line, tui_check_register_values):
2955         Update.
2956         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2957         member.
2958         (struct tui_data_window) <regs_content>: Now a std::vector.
2959         <regs_content_count>: Remove.
2960         (tui_add_content_elements, tui_free_data_content): Don't declare.
2961         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2962         (init_content_element): Remove DATA_WIN case.  Add assert.
2963         (tui_add_content_elements): Remove.
2964         (tui_data_window): Update.
2965         (tui_free_data_content): Remove.
2966         (free_content_elements): Remove DATA_WIN case.
2967
2968 2019-06-25  Tom Tromey  <tom@tromey.com>
2969
2970         * tui/tui-data.c (tui_data_item_window): Update.
2971         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2972         * tui/tui-windata.c (tui_display_all_data)
2973         (tui_display_data_from_line): Update.
2974         (tui_check_data_values): Remove.
2975         * tui/tui-regs.c (tui_show_register_group)
2976         (tui_display_reg_element_at_line): Update.
2977         * tui/tui-hooks.c (tui_register_changed)
2978         (tui_refresh_frame_and_register_information): Call
2979         tui_check_register_values.
2980         * tui/tui-data.h (struct tui_data_window) <data_content,
2981         data_content_count, data_type>: Remove.
2982         (enum tui_data_type): Remove.
2983
2984         * tui/tui-data.c (tui_data_window::clear_detail)
2985         (~tui_data_window): Update.
2986
2987 2019-06-25  Tom Tromey  <tom@tromey.com>
2988
2989         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2990         declare.
2991         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2992         Rename from tui_first_data_item_displayed.  Update.
2993         (tui_data_window::refresh_all)
2994         (tui_data_window::do_scroll_vertical): Update.
2995         * tui/tui-data.h (struct tui_data_window)
2996         <first_data_item_displayed>: Declare new method.
2997
2998 2019-06-25  Tom Tromey  <tom@tromey.com>
2999
3000         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3001         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3002         contents...
3003         (tui_initialize_static_data): ...here.
3004
3005 2019-06-25  Tom Tromey  <tom@tromey.com>
3006
3007         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3008         (tui_display_registers_from, tui_check_register_values): Update.
3009         (tui_display_register): Remove win_info parameter; update.
3010         (tui_get_register): Change type of parameters.
3011         * tui/tui-data.h (struct tui_data_element): Remove.
3012         (union tui_which_element) <data>: Remove.
3013         <data_window>: Change type.
3014         (struct tui_data_item_window): New.
3015         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3016         case.  Add assert.
3017         (~tui_data_item_window): New destructor.
3018         (free_content_elements): Remove DATA_ITEM_WIN case.
3019
3020 2019-06-25  Tom Tromey  <tom@tromey.com>
3021
3022         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3023         Remove.
3024
3025 2019-06-25  Tom Tromey  <tom@tromey.com>
3026
3027         * tui/tui-data.h (struct tui_command_element): Remove.
3028         (union tui_which_element) <command>: Remove.
3029         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3030         assert.
3031         (free_content_elements): Remove CMD_WIN case.
3032
3033 2019-06-25  Tom Tromey  <tom@tromey.com>
3034
3035         * tui/tui-layout.c (tui_set_layout): Update.
3036         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3037         * tui/tui-data.c (layout_def): Update.
3038
3039 2019-06-25  Tom Tromey  <tom@tromey.com>
3040
3041         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3042         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3043         (tui_source_window_base::set_new_height): Update.
3044         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3045         Update.
3046         (tui_set_locator_fullname, tui_set_locator_info)
3047         (tui_show_frame_info): Update.
3048         * tui/tui-source.c (tui_set_source_content)
3049         (tui_source_is_displayed): Update.
3050         * tui/tui-layout.c (show_source_disasm_command, show_data)
3051         (show_source_or_disasm_and_command): Update.
3052         * tui/tui-disasm.c (tui_set_disassem_content)
3053         (tui_get_begin_asm_address): Update.
3054         * tui/tui-data.h (struct tui_locator_element): Remove.
3055         (union tui_which_element) <locator>: Remove.
3056         (struct tui_locator_window): New.
3057         (tui_locator_win_info_ptr): Change return type.
3058         * tui/tui-data.c (_locator): Change type.
3059         (tui_locator_win_info_ptr): Change return type.
3060         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3061         (tui_alloc_content): Add assert.
3062
3063 2019-06-25  Tom Tromey  <tom@tromey.com>
3064
3065         * tui/tui-winsource.c
3066         (tui_exec_info_window::maybe_allocate_content): New method.
3067         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3068         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3069         (make_source_or_disasm_window): Add cast.
3070         * tui/tui-data.h (union tui_which_element) <simple_string>:
3071         Remove.
3072         (struct tui_source_info): New.
3073         (struct tui_source_window_base) <execution_info>: Change type.
3074         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3075         case, and add assert.
3076         (tui_alloc_content): Add assert.
3077
3078 2019-06-25  Tom Tromey  <tom@tromey.com>
3079
3080         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3081         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3082         * tui/tui-data.c (tui_alloc_win_info): Remove.
3083
3084 2019-06-25  Tom Tromey  <tom@tromey.com>
3085
3086         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3087         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3088         can_highlight.
3089
3090 2019-06-25  Tom Tromey  <tom@tromey.com>
3091
3092         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3093         make_visible_with_new_height method.
3094         (tui_win_info::make_visible_with_new_height): New method.
3095         (tui_source_window_base::do_make_visible_with_new_height)
3096         (tui_data_window::do_make_visible_with_new_height)
3097         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3098         (make_visible_with_new_height): Remove.
3099         (tui_resize_all, tui_adjust_win_heights): Use
3100         make_visible_with_new_height method.
3101         * tui/tui-data.h (struct tui_win_info)
3102         <do_make_visible_with_new_height, make_visible_with_new_height>:
3103         New methods.
3104         (struct tui_source_window_base, struct tui_data_window)
3105         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3106         methods.
3107
3108 2019-06-25  Tom Tromey  <tom@tromey.com>
3109
3110         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3111         method.
3112         (update_tab_width): Call update_tab_width method.
3113         * tui/tui-data.h (struct tui_win_info)
3114         (struct tui_source_window_base) <update_tab_width>: New methods.
3115
3116 2019-06-25  Tom Tromey  <tom@tromey.com>
3117
3118         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3119         parameter.
3120         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3121         parameter.
3122         (tui_gen_win_info::make_visible): Update.
3123         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3124         parameter.
3125         * tui/tui-data.h (enum tui_box): New enum.
3126         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3127
3128 2019-06-25  Tom Tromey  <tom@tromey.com>
3129
3130         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3131         init_and_make_win for EXEC_INFO_WIN.
3132         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3133         longer inline.
3134         (struct tui_win_info) <~tui_win_info>: Inline.
3135         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3136         Don't declare.
3137         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3138         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3139         Remove.
3140         (tui_initialize_static_data): Update.
3141         (~tui_gen_win_info): Handle more cleanup here.
3142         (~tui_source_window_base): Delete "execution_info".
3143         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3144
3145 2019-06-25  Tom Tromey  <tom@tromey.com>
3146
3147         * tui/tui-layout.c (make_command_window): Don't set
3148         can_highlight.
3149         (show_source_disasm_command): Call the reset method.
3150         (show_data): Don't set can_highlight.  Call the reset method.
3151         (tui_gen_win_info::reset): Rename from init_gen_win_info
3152         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3153         (show_source_or_disasm_and_command): Call the reset method.
3154         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3155         (struct tui_cmd_window): Set can_highlight.
3156
3157 2019-06-25  Tom Tromey  <tom@tromey.com>
3158
3159         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3160         from make_visible.
3161         (tui_make_visible, tui_make_invisible): Rewrite.
3162         (tui_win_info::make_visible): Remove.
3163         (tui_source_window_base::make_visible): Update.
3164         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3165         method.  Moved from...
3166         (struct tui_win_info) <make_visible>: ...here.
3167
3168 2019-06-25  Tom Tromey  <tom@tromey.com>
3169
3170         * tui/tui-winsource.c
3171         (tui_source_window_base::do_scroll_horizontal): Remove direction
3172         parameter.
3173         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3174         direction parameter.
3175         * tui/tui-win.c (tui_win_info::forward_scroll)
3176         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3177         (tui_win_info::right_scroll): Update.
3178         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3179         direction parameter.
3180         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3181         direction parameter.
3182         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3183         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3184         Remove direction parameter.
3185         (struct tui_source_window_base, struct tui_source_window)
3186         (struct tui_disasm_window, struct tui_data_window)
3187         (struct tui_cmd_window): Update.
3188
3189 2019-06-25  Tom Tromey  <tom@tromey.com>
3190
3191         * tui/tui-winsource.h (tui_set_exec_info_content)
3192         (tui_show_exec_info_content, tui_erase_exec_info_content)
3193         (tui_clear_exec_info_content, tui_update_exec_info): Change
3194         argument to tui_source_window_base.
3195         * tui/tui-winsource.c (tui_set_exec_info_content)
3196         (tui_show_exec_info_content, tui_erase_exec_info_content)
3197         (tui_clear_exec_info_content, tui_update_exec_info): Change
3198         argument to tui_source_window_base.
3199
3200 2019-06-25  Tom Tromey  <tom@tromey.com>
3201
3202         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3203         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3204
3205 2019-06-25  Tom Tromey  <tom@tromey.com>
3206
3207         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3208         check.
3209
3210 2019-06-25  Tom Tromey  <tom@tromey.com>
3211
3212         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3213         type to void.
3214         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3215         type to void.
3216         * tui/tui-source.c (tui_set_source_content): Update.
3217         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3218
3219 2019-06-25  Tom Tromey  <tom@tromey.com>
3220
3221         * tui/tui-win.c (window_name_completer, tui_set_focus)
3222         (tui_all_windows_info): Use name method.
3223         * tui/tui-data.h (struct tui_gen_win_info)
3224         (struct tui_source_window, struct tui_disasm_window)
3225         (struct tui_data_window, struct tui_cmd_window) <name>: New
3226         method.
3227         (tui_win_name): Don't declare.
3228         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3229         (tui_win_name): Remove.
3230
3231 2019-06-25  Tom Tromey  <tom@tromey.com>
3232
3233         * tui/tui-winsource.h (tui_update_source_window)
3234         (tui_update_source_window_as_is): Change parameter type.
3235         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3236         to be a tui_source_window_base.
3237         (tui_update_source_window_as_is): Likewise.
3238         * tui/tui-win.c (make_visible_with_new_height): Update.
3239
3240 2019-06-25  Tom Tromey  <tom@tromey.com>
3241
3242         * tui/tui-winsource.c (tui_erase_source_content)
3243         (tui_show_source_content, tui_show_exec_info_content)
3244         (tui_erase_exec_info_content): Use refresh_window method.
3245         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3246         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3247         from tui_refresh_win.
3248         (tui_data_window::refresh_window): New method.
3249         (tui_win_info::refresh, tui_source_window_base::refresh)
3250         (tui_refresh_all): Use refresh_window method.
3251         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3252         method.
3253         * tui/tui-regs.c (tui_display_register): Call refresh_window
3254         method.
3255         * tui/tui-layout.c (show_source_disasm_command)
3256         (show_source_or_disasm_and_command): Call refresh_window method.
3257         * tui/tui-data.h (struct tui_gen_win_info)
3258         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3259         New method.
3260
3261 2019-06-25  Tom Tromey  <tom@tromey.com>
3262
3263         * tui/tui.c (tui_rl_other_window, tui_enable)
3264         (tui_is_window_visible, tui_get_command_dimension): Update.
3265         * tui/tui-winsource.c (tui_update_source_window_as_is)
3266         (tui_clear_source_content, tui_erase_source_content)
3267         (tui_show_source_line, tui_source_window_base::refill)
3268         (tui_source_window_base::do_scroll_horizontal)
3269         (tui_source_window_base::set_is_exec_point_at)
3270         (tui_update_breakpoint_info, tui_set_exec_info_content)
3271         (tui_alloc_source_buffer, tui_line_is_displayed)
3272         (tui_addr_is_displayed): Update.
3273         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3274         (tui_check_and_display_highlight_if_needed)
3275         (tui_win_info::make_visible, tui_win_info::refresh)
3276         (tui_refresh_all): Update.
3277         * tui/tui-windata.c (tui_first_data_item_displayed)
3278         (tui_delete_data_content_windows, tui_erase_data_content)
3279         (tui_display_all_data, tui_data_window::refresh_all)
3280         (tui_check_data_values): Update.
3281         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3282         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3283         (tui_win_info::backward_scroll, tui_refresh_all_win)
3284         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3285         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3286         (tui_source_window_base::set_new_height)
3287         (tui_data_window::set_new_height)
3288         (make_invisible_and_set_new_height)
3289         (make_visible_with_new_height, new_height_ok)
3290         (parse_scrolling_args): Update.
3291         * tui/tui-stack.c (tui_show_frame_info): Update.
3292         * tui/tui-source.c (tui_set_source_content)
3293         (tui_set_source_content_nil, tui_source_is_displayed)
3294         (tui_source_window::do_scroll_vertical): Update.
3295         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3296         (tui_display_registers_from, tui_display_reg_element_at_line)
3297         (tui_check_register_values, tui_reg_command): Update.
3298         * tui/tui-layout.c (tui_default_win_height)
3299         (show_source_disasm_command, show_data, init_and_make_win)
3300         (show_source_or_disasm_and_command): Update.
3301         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3302         (tui_redisplay_readline, tui_mld_flush)
3303         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3304         (tui_getc): Update.
3305         * tui/tui-disasm.c (tui_set_disassem_content)
3306         (tui_disasm_window::do_scroll_vertical): Update.
3307         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3308         Now virtual.
3309         (struct tui_win_info): Derive from tui_gen_win_info.
3310         <~tui_win_info>: Mark as override.
3311         <generic>: Remove member.
3312         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3313         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3314         (~tui_data_window, ~tui_win_info)
3315         (tui_free_all_source_wins_content): Update.
3316         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3317
3318 2019-06-25  Tom Tromey  <tom@tromey.com>
3319
3320         * tui/tui-layout.c (init_and_make_win): Use new.
3321         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3322         destructor, initializers.
3323         (tui_alloc_generic_win_info): Don't declare.
3324         * tui/tui-data.c (_locator): Add argument to constructor.
3325         (source_win, disasm_win): New globals.
3326         (exec_info): Remove.
3327         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3328         Update.
3329         (tui_alloc_generic_win_info): Remove.
3330         (init_content_element): Use new.
3331         (tui_win_info::tui_win_info): Update.
3332         (free_content_elements) <case DATA_WIN>: Use delete.
3333
3334 2019-06-25  Tom Tromey  <tom@tromey.com>
3335
3336         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3337         * tui/tui-windata.c (tui_first_data_item_displayed)
3338         (tui_delete_data_content_windows): Update.
3339         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3340         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3341         (tui_display_registers_from, tui_check_register_values): Update.
3342         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3343         pointer.
3344         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3345         window.
3346         (tui_free_data_content): Update.
3347         (free_content_elements) <case DATA_WIN>: Free the window.
3348
3349 2019-06-25  Tom Tromey  <tom@tromey.com>
3350
3351         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3352         Update.
3353         * tui/tui-layout.c (make_command_window)
3354         (show_source_disasm_command, show_data, init_and_make_win)
3355         (show_source_or_disasm_and_command): Update.
3356         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3357         method.
3358         <can_highight, is_highlighted>: Now bool.
3359         (tui_set_win_highlight): Don't declare.
3360         * tui/tui-data.c (tui_set_win_highlight): Remove.
3361
3362 2019-06-25  Tom Tromey  <tom@tromey.com>
3363
3364         * tui/tui-wingeneral.c (make_visible): Remove check of window
3365         type.
3366
3367 2019-06-25  Tom Tromey  <tom@tromey.com>
3368
3369         * tui/tui-win.c (tui_win_info::max_height)
3370         (tui_cmd_window::max_height): New methods.
3371         (new_height_ok): Call max_height.
3372         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3373         <max_height>: New method.
3374
3375 2019-06-25  Tom Tromey  <tom@tromey.com>
3376
3377         * tui/tui-win.c (tui_source_window_base::set_new_height)
3378         (tui_data_window::set_new_height): New methods.
3379         (make_invisible_and_set_new_height): Call set_new_height method.
3380         * tui/tui-data.h (struct tui_win_info)
3381         (struct tui_source_window_base, struct tui_data_window)
3382         <set_new_height>: New method.
3383
3384 2019-06-25  Tom Tromey  <tom@tromey.com>
3385
3386         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3387         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3388         tui_refresh_data_win.
3389         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3390         method.
3391         (tui_refresh_all_win): Call the refresh_all method.
3392         (tui_set_focus): Likewise.
3393         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3394         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3395         Likewise.
3396
3397 2019-06-25  Tom Tromey  <tom@tromey.com>
3398
3399         * tui/tui-winsource.h (tui_refill_source_window)
3400         (tui_set_is_exec_point_at): Don't declare.
3401         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3402         (tui_source_window_base::refill): Rename from
3403         tui_refill_source_window.
3404         (tui_source_window_base::do_scroll_horizontal): Update.
3405         (tui_source_window_base::set_is_exec_point_at): Rename from
3406         tui_set_is_exec_point_at.
3407         (tui_update_all_breakpoint_info): Update.
3408         * tui/tui-stack.c (tui_show_frame_info): Update.
3409         * tui/tui-layout.c (show_data): Add cast.
3410         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3411         * tui/tui-data.h (struct tui_source_window_base) <refill,
3412         set_is_exec_point_at>: New methods.
3413         (tui_source_windows, tui_add_to_source_windows): Update types.
3414         (tui_add_to_source_windows): Remove redundant declaration.
3415         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3416         (tui_source_windows): Change return type.
3417         (tui_clear_source_windows_detail): Update.
3418         (tui_add_to_source_windows): Change type of parameter.
3419         (tui_free_all_source_wins_content): Update.
3420
3421 2019-06-25  Tom Tromey  <tom@tromey.com>
3422
3423         * tui/tui-wingeneral.c (tui_win_info::refresh)
3424         (tui_source_window_base::refresh): New methods.
3425         (tui_refresh_all): Call the refresh method.
3426         * tui/tui-data.h (struct tui_win_info)
3427         (struct tui_source_window_base) <refresh>: New method.
3428
3429 2019-06-25  Tom Tromey  <tom@tromey.com>
3430
3431         * tui/tui.h (tui_is_window_visible): Return bool.
3432         * tui/tui.c (tui_is_window_visible): Return bool.
3433         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3434         (tui_make_visible, tui_make_invisible)
3435         (tui_win_info::make_visible)
3436         (tui_source_window_base::make_visible, make_all_visible)
3437         (tui_make_all_visible, tui_make_all_invisible): Update.
3438         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3439         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3440         bool.
3441         (struct tui_win_info, struct tui_source_window_base)
3442         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3443         * tui/tui-data.c (tui_init_generic_part): Update.
3444
3445 2019-06-25  Tom Tromey  <tom@tromey.com>
3446
3447         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3448         (tui_source_window_base::make_visible): New methods.
3449         (make_all_visible): Make method call.
3450         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3451         (struct tui_source_window_base, struct tui_cmd_window): Override
3452         make_visible.
3453         (tui_win_is_source_type): Don't declare.
3454         * tui/tui-data.c (tui_win_is_source_type): Remove.
3455
3456 2019-06-25  Tom Tromey  <tom@tromey.com>
3457
3458         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3459         NULL check.
3460
3461 2019-06-25  Tom Tromey  <tom@tromey.com>
3462
3463         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3464         Inline constructor.  Add initializers for members.
3465         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3466         constructors; now inline in class.
3467
3468 2019-06-25  Tom Tromey  <tom@tromey.com>
3469
3470         * tui/tui-regs.c (tui_show_registers): Update.
3471         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3472         bool.
3473         * tui/tui-data.c (tui_data_window::clear_detail)
3474         (tui_data_window): Update.
3475
3476 2019-06-25  Tom Tromey  <tom@tromey.com>
3477
3478         * tui/tui-windata.c (tui_display_all_data)
3479         (tui_display_data_from_line, tui_display_data_from)
3480         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3481         Update.
3482         * tui/tui-regs.c (tui_last_regs_line_no)
3483         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3484         (tui_show_registers, tui_show_register_group)
3485         (tui_display_registers_from, tui_display_reg_element_at_line)
3486         (tui_display_registers_from_line, tui_check_register_values)
3487         (tui_reg_next, tui_reg_prev): Update.
3488         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3489         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3490         tui_data_window.
3491         (struct tui_win_info) <detail>: Remove.  Add new fields from
3492         tui_data_info.
3493         (TUI_DATA_WIN): Add cast.
3494         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3495         (~tui_data_window): Simplify.
3496
3497 2019-06-25  Tom Tromey  <tom@tromey.com>
3498
3499         * tui/tui-layout.c (show_source_disasm_command)
3500         (show_source_or_disasm_and_command): Update.
3501         * tui/tui-io.c (update_cmdwin_start_line)
3502         (tui_redisplay_readline): Update.
3503         * tui/tui-data.h (struct tui_command_info): Remove.
3504         (struct tui_win_info) <detail>: Remove command_info member.
3505         (struct tui_data_window) <start_line>: New member, from
3506         tui_command_info.
3507         (TUI_CMD_WIN): Add casts.
3508
3509 2019-06-25  Tom Tromey  <tom@tromey.com>
3510
3511         * tui/tui-winsource.c (tui_update_source_window)
3512         (tui_refill_source_window)
3513         (tui_source_window_base::do_scroll_horizontal)
3514         (tui_update_breakpoint_info, tui_set_exec_info_content)
3515         (tui_show_exec_info_content, tui_erase_exec_info_content)
3516         (tui_clear_exec_info_content): Update.
3517         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3518         Update.
3519         * tui/tui-win.c (make_invisible_and_set_new_height)
3520         (make_visible_with_new_height): Update.
3521         * tui/tui-source.c (tui_set_source_content)
3522         (tui_show_symtab_source): Update.
3523         * tui/tui-layout.c (extract_display_start_addr)
3524         (show_source_disasm_command, show_data)
3525         (make_source_or_disasm_window)
3526         (show_source_or_disasm_and_command): Update.
3527         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3528         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3529         "gdbarch".
3530         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3531         to tui_source_window_base.
3532         (struct tui_win_info) <detail>: Remove source_info member.
3533         (struct tui_source_window_base) <has_locator>: Inline.
3534         Move contents from tui_source_info; rename has_locator member to
3535         m_has_locator.
3536         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3537         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3538         header file.
3539         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3540         Simplify.
3541         (tui_free_all_source_wins_content): Cast to
3542         tui_source_window_base.
3543
3544 2019-06-25  Tom Tromey  <tom@tromey.com>
3545
3546         * tui/tui-win.c (make_invisible_and_set_new_height)
3547         (make_visible_with_new_height): Call has_locator method.
3548         * tui/tui-layout.c (show_source_disasm_command, show_data)
3549         (show_source_or_disasm_and_command): Update for bool change.
3550         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3551         (tui_win_info) <has_locator>: New method.
3552         (struct tui_source_window_base) <has_locator>: New method.
3553         (tui_win_has_locator): Don't declare.
3554         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3555         from tui_win_has_locator.
3556         (tui_source_window_base): Use false, not FALSE.
3557
3558 2019-06-25  Tom Tromey  <tom@tromey.com>
3559
3560         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3561         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3562         clear_detail method directly.
3563         (tui_clear_win_detail): Remove.
3564
3565 2019-06-25  Tom Tromey  <tom@tromey.com>
3566
3567         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3568         "this", not TUI_DISASM_WIN.
3569
3570 2019-06-25  Tom Tromey  <tom@tromey.com>
3571
3572         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3573         declare.
3574         * tui/tui-winsource.c
3575         (tui_source_window_base::do_scroll_horizontal): Rename from
3576         tui_horizontal_source_scroll.
3577         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3578         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3579         from tui_vertical_data_scroll.
3580         * tui/tui-win.h (tui_scroll): Don't declare.
3581         * tui/tui-win.c (tui_win_info::forward_scroll)
3582         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3583         (tui_win_info::right_scroll): Rename and update.
3584         (tui_scroll_forward_command, tui_scroll_backward_command)
3585         (tui_scroll_left_command, tui_scroll_right_command): Update.
3586         (tui_scroll): Remove.
3587         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3588         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3589         from tui_vertical_source_scroll.
3590         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3591         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3592         from tui_vertical_disassem_scroll.
3593         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3594         do_scroll_horizontal>: New methods.
3595         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3596         Likewise.
3597         (struct tui_source_window_base): Add do_scroll_horizontal.
3598         (struct tui_source_window, struct tui_disasm_window): Add
3599         do_scroll_vertical.
3600         (struct tui_data_window, struct tui_cmd_window): Add
3601         do_scroll_horizontal and do_scroll_vertical.
3602         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3603
3604 2019-06-25  Tom Tromey  <tom@tromey.com>
3605
3606         * tui/tui-data.h (struct tui_source_window_base): New struct.
3607         (struct tui_source_window): Derive from tui_source_window_base.
3608         (struct tui_disasm_window): New struct.
3609         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3610         from tui_source_window::clear_detail.
3611         (tui_source_window_base): Rename from tui_source_window.
3612         (~tui_source_window_base): Rename from ~tui_source_window.
3613         (tui_alloc_win_info): Create a tui_disasm_window.
3614
3615 2019-06-25  Tom Tromey  <tom@tromey.com>
3616
3617         * tui/tui-data.h (struct tui_source_window)
3618         (struct tui_data_window): Declare destructors.
3619         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3620         destructors.
3621         (tui_win_info): Simplify.
3622
3623 2019-06-25  Tom Tromey  <tom@tromey.com>
3624
3625         * tui/tui-winsource.c (tui_display_main)
3626         (tui_update_source_windows_with_addr)
3627         (tui_update_all_breakpoint_info): Update.
3628         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3629         (new_height_ok, parse_scrolling_args): Update.
3630         * tui/tui-stack.c (tui_show_frame_info): Update.
3631         * tui/tui-data.h (struct tui_list): Remove.
3632         (tui_source_windows): Return a reference to a std::vector.
3633         * tui/tui-data.c (source_windows): Now a std::vector.
3634         (tui_source_windows): Change return type.
3635         (tui_clear_source_windows): Rewrite.
3636         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3637         (tui_free_all_source_wins_content): Rewrite.
3638
3639 2019-06-25  Tom Tromey  <tom@tromey.com>
3640
3641         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3642         (struct tui_data_window, struct tui_cmd_window): Declare
3643         clear_detail method.
3644         * tui/tui-data.c (tui_source_window::clear_detail)
3645         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3646         methods.
3647         (tui_clear_win_detail): Simplify.
3648
3649 2019-06-25  Tom Tromey  <tom@tromey.com>
3650
3651         * tui/tui-layout.c (make_source_window, make_disasm_window)
3652         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3653         Return the new window.
3654         (show_source_disasm_command, show_data)
3655         (show_source_or_disasm_and_command): Update.
3656
3657 2019-06-25  Tom Tromey  <tom@tromey.com>
3658
3659         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3660         parameter.  Return the new window.
3661         (show_source_disasm_command): Update and remove NULL check.
3662         (show_source_or_disasm_and_command): Update.
3663
3664 2019-06-25  Tom Tromey  <tom@tromey.com>
3665
3666         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3667
3668 2019-06-25  Tom Tromey  <tom@tromey.com>
3669
3670         * tui/tui-data.h (struct tui_win_info): Make constructor
3671         protected.  Make destructor virtual.  Add initializers.
3672         (tui_source_window, tui_data_window, tui_cmd_window): New
3673         classes.
3674         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3675         constructor.  Add "type" parameter.
3676         (tui_source_window, tui_data_window, tui_cmd_window): New
3677         constructors.
3678         (tui_alloc_win_info): Instantiate the appropriate subclass.
3679
3680 2019-06-25  Tom Tromey  <tom@tromey.com>
3681
3682         * tui/tui-win.c (tui_resize_all): Use delete.
3683         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3684         destructor.
3685         (tui_free_window): Don't declare.
3686         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3687         Update.
3688
3689 2019-06-25  Tom Tromey  <tom@tromey.com>
3690
3691         * tui/tui-data.h (struct tui_win_info): Add constructor.
3692         * tui/tui-data.c (tui_alloc_win_info): Use new.
3693         (tui_free_window): Use delete.
3694
3695 2019-06-22  Tom Tromey  <tom@tromey.com>
3696
3697         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3698         declare.
3699         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3700
3701 2019-06-22  Tom Tromey  <tom@tromey.com>
3702
3703         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3704         declare.
3705         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3706
3707 2019-06-22  Tom de Vries  <tdevries@suse.de>
3708
3709         * dwarf2read.c (create_addrmap_from_aranges)
3710         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3711         instead of '%zu'.
3712
3713 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3714
3715         * dwarf2read.h (dwarf2_section_info_def): Remove.
3716         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3717         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3718         std::vector<dwarf2_section_info>.
3719         (struct dwo_file) <~dwo_file>: Remove.
3720         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3721         types field.
3722         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3723         (dwarf2_read_debug_names): Likewise.
3724         (create_debug_types_hash_table): Change parameter type to
3725         array_view, adjust code accordingly.
3726         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3727         (partial_die_info::fixup): Likewise.
3728         (determine_prefix): Likewise.
3729         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3730
3731 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3732
3733         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3734         gdb_bfd_ref_ptr.
3735         <~dwo_file>: Remove call to gdb_bfd_unref.
3736         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3737         gdb_bfd_ref_ptr::get.
3738
3739 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3740
3741         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3742         type to htab_up.
3743         * dwarf2read.c (struct dwo_file): Initialize fields.
3744         <~dwo_file>: New.
3745         (free_dwo_file): Remove, move content to ~dwo_file.
3746         (struct dwo_file_deleter): Remove.
3747         (dwo_file_up>: Remove custom deleter.
3748         (free_dwo_files): Remove.
3749         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3750         dwo_files.
3751         (process_skeletonless_type_units): Call unique_ptr::get.
3752         (allocate_dwo_file_hash_table): Add deleter to created hash
3753         table.  Change return type to htab_up.
3754         (lookup_dwo_file_slot): Don't memset dwo_file, call
3755         unique_ptr::get.
3756         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3757         (create_dwo_unit_in_dwp_v2): Likewise.
3758         (open_and_init_dwo_file): Likewise.
3759         (free_dwo_file_from_slot): Remove.
3760
3761 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3762
3763         * dwarf2read.h (struct dwarf2_section_info) <readin,
3764         is_virtual>: Change type to bool.
3765         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3766         true instead of 1.
3767
3768 2019-06-19  Tom Tromey  <tom@tromey.com>
3769
3770         * tui/tui-data.h (tui_init_content_element): Don't declare.
3771
3772 2019-06-19  Tom Tromey  <tom@tromey.com>
3773
3774         * tui/tui-data.h (tui_init_win_info): Don't declare.
3775
3776 2019-06-19  Tom de Vries  <tdevries@suse.de>
3777
3778         * dwarf2read.h (abstract_to_concrete): Change type to
3779         std::unordered_map<sect_offset, std::vector<sect_offset>,
3780         gdb::hash_enum<sect_offset>>.
3781
3782 2019-06-19  Tom Tromey  <tromey@adacore.com>
3783
3784         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3785         EVAL_AVOID_SIDE_EFFECTS specially.
3786
3787 2019-06-19  Tom Tromey  <tromey@adacore.com>
3788
3789         * source-cache.c (highlighter): New global.
3790         (source_cache::get_source_lines): Create a highlighter on demand.
3791
3792 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3793
3794         * defs.h (deprecated_interactive_hook): Delete declaration.
3795         * interps.c (clear_interpreter_hooks): Remove use of
3796         deprecated_interactive_hook.
3797         * top.c (deprecated_interactive_hook): Delete definition.
3798         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3799
3800 2019-06-18  Tom de Vries  <tdevries@suse.de>
3801
3802         PR gdb/24515
3803         * dwarf2read.h (abstract_to_concrete): Change type from
3804         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3805         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3806         * dwarf2read.c (read_variable): Update.
3807         (dwarf2_fetch_die_loc_sect_off): Update.
3808
3809 2019-06-17  Tom de Vries  <tdevries@suse.de>
3810
3811         PR gdb/24617
3812         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3813         accessing parent[parent_len - 1].
3814
3815 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3816
3817         PR gdb/24364
3818         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3819         call dtrace_process_dof with NULL dof.
3820
3821 2019-06-16  Tom de Vries  <tdevries@suse.de>
3822
3823         PR gdb/24445
3824         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3825
3826 2019-06-16  Tom Tromey  <tom@tromey.com>
3827
3828         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3829         (make_all_visible): Use address of member.
3830
3831 2019-06-16  Tom Tromey  <tom@tromey.com>
3832
3833         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3834         (tui_free_window, free_content, free_content_elements): Remove
3835         unnecessary cast.
3836         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3837         cast.
3838         * tui/tui-regs.c (tui_show_register_group)
3839         (tui_display_registers_from, tui_display_reg_element_at_line):
3840         Remove unnecessary cast.
3841
3842 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3843
3844         * linux-nat.c (normal_mask): Delete.
3845         (_initialize_linux_nat): Don't initialise normal_mask.
3846
3847 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3848
3849         PR gdb/24445
3850         * dwarf-index-write.h (write_psymtabs_to_index): Add
3851         dwz_basename parameter.
3852         * dwarf-index-write.c (write_gdbindex): Move file writing to
3853         write_gdbindex_1.  Change return type void.
3854         (assert_file_size): Move up, remove filename parameter.
3855         (write_gdbindex_1): New function.
3856         (write_debug_names): Change return type to void, call
3857         assert_file_size.
3858         (struct index_wip_file): New struct.
3859         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3860         file logic to index_wip_file.  Write index for dwz file if
3861         needed.
3862         (save_gdb_index_command): Pass basename of dwz file, if present.
3863         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3864         build-id of dwz file, if present.
3865         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3866         (dwarf2_get_dwz_file): Likewise.
3867         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3868         (dwarf2_get_dwz_file): Likewise.
3869
3870 2019-06-16  Tom Tromey  <tom@tromey.com>
3871
3872         * coffread.c (process_coff_symbol): Use xstrdup.
3873         * value.c (create_internalvar): Use xstrdup.
3874
3875 2019-06-16  Tom Tromey  <tom@tromey.com>
3876
3877         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3878         * breakpoint.c (stopin_command, stopat_command)
3879         (until_break_command, decode_location_default): Remove unnecessary
3880         cast.
3881         * utils.c (subset_compare): Remove unnecessary cast.
3882         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3883         cast.
3884         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3885         cast.
3886         * infcmd.c (path_command): Remove unnecessary cast.
3887         * coffread.c (decode_type): Remove unnecessary cast.
3888         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3889         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3890         * tui/tui-stack.c (tui_show_locator_content)
3891         (tui_show_frame_info): Remove unnecessary cast.
3892         * tui/tui-win.c (tui_scroll_forward_command)
3893         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3894         (parse_scrolling_args): Remove unnecessary cast.
3895         * tui/tui-data.c (init_win_info, tui_del_window)
3896         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3897         (free_content_elements): Remove unnecessary cast.
3898         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3899         unnecessary cast.
3900         * tui/tui-source.c (tui_set_source_content)
3901         (tui_vertical_source_scroll): Remove unnecessary cast.
3902         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3903         cast.
3904         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3905         * tui/tui-regs.c (tui_display_registers_from)
3906         (tui_display_register): Remove unnecessary cast.
3907         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3908         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3909         (make_visible): Remove unnecessary cast.
3910         * tui/tui-winsource.c (tui_erase_source_content)
3911         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3912         unnecessary cast.
3913         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3914         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3915         * stabsread.c (read_type, read_array_type, read_range_type):
3916         Remove unnecessary cast.
3917         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3918         (parse_symbol, parse_type, upgrade_type, parse_external)
3919         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3920         unnecessary cast.
3921         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3922
3923 2019-06-16  Tom Tromey  <tom@tromey.com>
3924
3925         * tui/tui-data.c (tui_alloc_generic_win_info)
3926         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3927         checks.
3928
3929 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3930             Andrew Burgess  <andrew.burgess@embecosm.com>
3931
3932         * f-typeprint.c (f_print_type): Don't return early for not
3933         associated or not allocated types.
3934         (f_type_print_varspec_suffix): Add print_rank parameter and print
3935         ranks of array types in case they dangling.
3936         (f_type_print_base): Add print_rank parameter.
3937
3938 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3939
3940         * NEWS: Mention new MI commands.
3941         * break-catch-throw.c (enum exception_event_kind): Move to
3942         breakpoint.h.
3943         (print_mention_exception_catchpoint): Output text as a single
3944         message.
3945         (catch_exception_command_1): Rename to...
3946         (catch_exception_event): ...this, make non-static, update header
3947         command, and change some parameter types.
3948         (catch_catch_command): Update for changes to
3949         catch_exception_command_1.
3950         (catch_throw_command): Likewise.
3951         (catch_rethrow_command): Likewise.
3952         * breakpoint.c (enum exception_event_kind): Delete.
3953         * breakpoint.h (enum exception_event_kind): Moved here from
3954         break-catch-throw.c.
3955         (catch_exception_event): Declare.
3956         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3957         (mi_cmd_catch_throw): New function.
3958         (mi_cmd_catch_rethrow): New function.
3959         (mi_cmd_catch_catch): New function.
3960         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3961         'catch-catch' entries.
3962         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3963         (mi_cmd_catch_rethrow): Declare.
3964         (mi_cmd_catch_catch): Declare.
3965
3966 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3967
3968         * annotate.c (annotate_source_line): Change return type to void,
3969         update implementation to match.
3970         * annotate.h (annotate_source_line): Change return type to void,
3971         update header comment.
3972         * stack.c (print_frame_info): Don't change what frame information
3973         is printed based on whether annotations are on or not.
3974
3975 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3976
3977         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3978         (annotate_source): Make static.
3979         (annotate_source_line): Moved from source.c and renamed from
3980         identify_source_line.  Update the return type.
3981         * annotate.h (annotate_source): Delete declaration.
3982         (annotate_source_line): Declaration moved from source.h, and
3983         renamed from identify_source_line.  Return type updated.
3984         * source.c (identify_source_line): Moved to annotate.c and renamed
3985         to annotate_source_line.
3986         (info_line_command): Remove check of annotation_level.
3987         * source.h (identify_source_line): Move declaration to annotate.h
3988         and rename to annotate_source_line.
3989         * stack.c: Add 'annotate.h' include.
3990         (print_frame_info): Remove check of annotation_level before
3991         calling annotate_source_line.
3992
3993 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3994
3995         * source-cache.c (source_cache::get_plain_source_lines): Use
3996         open_source_file_with_line_charpos instead of just
3997         open_source_file, remove call to find_source_lines.
3998         (source_cache::get_source_lines): Likewise.
3999         * source.c (find_source_lines): Make static.
4000         (get_filename_and_charpos): Renamed into...
4001         (open_source_file_with_line_charpos): ..this along with changes to
4002         return a scoped_fd, and some other minor clean ups.
4003         (identify_source_line): Use open_source_file_with_line_charpos.
4004         (search_command_helper): Use open_source_file_with_line_charpos
4005         instead of just open_source_file, remove call to
4006         find_source_lines.
4007         * source.h (open_source_file_with_line_charpos): Declare new
4008         function.
4009         (find_source_lines): Delete declaration.
4010
4011 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4012
4013         * source.c (get_filename_and_charpos): Remove fullname
4014         parameter.
4015         (identify_source_line): Update call to get_filename_and_charpos.
4016
4017 2019-06-14  Tom Tromey  <tromey@adacore.com>
4018
4019         PR gdb/24502:
4020         * ui-style.h (skip_ansi_escape): Update comment.
4021         * ui-file.h (class no_terminal_escape_file): New class.
4022         * ui-file.c (no_terminal_escape_file::write)
4023         (no_terminal_escape_file::puts): New methods.
4024         * cli/cli-logging.c (handle_redirections): Use
4025         no_terminal_escape_file.
4026
4027 2019-06-14  Tom Tromey  <tromey@adacore.com>
4028
4029         * NEWS: Move convenience variable news above Python news.
4030
4031 2019-06-14  Tom Tromey  <tom@tromey.com>
4032
4033         * gnulib: Move directory to top-level.
4034         * configure.ac: Don't configure gnulib.
4035         * configure: Rebuild.
4036         * common/common-defs.h: Use new path to gnulib.
4037         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4038         (GNULIB_H): Remove.
4039         (INCGNU): Look in new gnulib location.
4040         (HFILES_NO_SRCDIR): Remove gnulib files.
4041         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4042         (generated_files): Remove GNULIB_H.
4043         ($(LIBGNU), all-lib): Remove targets.
4044         (distclean): Don't mention GNULIB_BUILDDIR.
4045         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4046
4047 2019-06-14  Tom Tromey  <tromey@adacore.com>
4048
4049         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4050         Warn if symbol file does not provide any symbols.
4051
4052 2019-06-14  Tom Tromey  <tromey@adacore.com>
4053
4054         * source.c (find_and_open_source): Respect basenames_may_differ.
4055
4056 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4057
4058         * annotate.c (annotate_breakpoints_invalid): Make use of
4059         scoped_restore_terminal_state.
4060         (annotate_frames_invalid): Likewise.
4061
4062 2019-06-14  Tom Tromey  <tromey@adacore.com>
4063
4064         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4065         allow assignment to an internalvar.
4066
4067 2019-06-14  Tom Tromey  <tromey@adacore.com>
4068
4069         * ada-lex.l: Allow "_" in attribute names.
4070
4071 2019-06-14  Tom Tromey  <tromey@adacore.com>
4072
4073         PR gdb/24653:
4074         * regcache.c (registers_changed): Don't call alloca.
4075         * top.c (execute_command): Don't call alloca.
4076
4077 2019-06-13  Pedro Alves  <palves@redhat.com>
4078
4079         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4080         'expression'.  When parsing an expression, error out if there's
4081         junk after "unlimited".
4082         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4083         (do_set_command): Adjust calls to is_unlimited_literal.
4084
4085 2019-06-13  Pedro Alves  <palves@redhat.com>
4086
4087         * compile/compile.c (make_compile_options_def_group): Add braces
4088         around array_view initializer.
4089         * thread.c (make_thread_apply_all_options_def_group)
4090         (make_thread_apply_all_options_def_group): Likewise.
4091
4092 2019-06-13  Pedro Alves  <palves@redhat.com>
4093
4094         * NEWS (New commands): Mention "maint test-options
4095         require-delimiter", "maint test-options unknown-is-error", "maint
4096         test-options unknown-is-operand" and "maint show
4097         test-options-completion-result".
4098         (New command options, command completion): New section.
4099         (Completion improvements): New section.
4100         Mention that you can abbreviate "unlimited".
4101
4102 2019-06-13  Pedro Alves  <palves@redhat.com>
4103
4104         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4105         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4106         * unittests/cli-utils-selftests.c (test_parse_flags)
4107         (test_parse_flags_qcs): Delete.
4108         (test_cli_utils): Don't call deleted functions.
4109
4110 2019-06-13  Pedro Alves  <palves@redhat.com>
4111
4112         * thread.c: Include "cli/cli-option.h".
4113         (tp_array_compar_ascending): Global.
4114         (tp_array_compar): Delete function.
4115         (tp_array_compar_ascending, tp_array_compar_descending): New
4116         functions.
4117         (ascending_option_def, qcs_flag_option_def)
4118         (thr_qcs_flags_option_defs)
4119         (make_thread_apply_all_options_def_group)
4120         (make_thread_apply_options_def_group): New.
4121         (thread_apply_all_command): Use gdb::option::process_options.
4122         (thread_apply_command_completer)
4123         (thread_apply_all_command_completer): New.
4124         (thread_apply_command): Use gdb::option::process_options.
4125         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4126         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4127         to generate help text of "thread apply".  Adjust "taas"'s help.
4128         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4129         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4130
4131 2019-06-13  Pedro Alves  <palves@redhat.com>
4132
4133         * thread.c (thread_apply_command): Check for invalid TID with
4134         isdigit instead of !isalpha.
4135
4136 2019-06-13  Pedro Alves  <palves@redhat.com>
4137
4138         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4139         (validate_flags_qcs): New.
4140         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4141         (validate_flags_qcs): Declare.
4142         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4143         (make_frame_apply_options_def_group): New.
4144         (frame_apply_command_count): Process options with
4145         gdb::option::process_options.
4146         (frame_apply_completer): New.
4147         (frame_apply_level_completer, frame_apply_all_completer)
4148         (frame_apply_completer): New.
4149         (_initialize_stack): Update help of "frame apply", "frame apply
4150         level", "frame apply all" and "faas" to mention supported options
4151         and install command completers.
4152         * stack.h (frame_apply_all_completer): Declare.
4153         * thread.c: Include "stack.h".
4154         (tfaas_command): Add "--".
4155         (_initialize_thread): Update help "tfaas" to mention supported
4156         options and install command completer.
4157
4158 2019-06-13  Pedro Alves  <palves@redhat.com>
4159
4160         * completer.c (complete_nested_command_line): New.
4161         (gdb_completion_word_break_characters_throw): Add assertion.
4162         * completer.h (complete_nested_command_line): Declare.
4163
4164 2019-06-13  Pedro Alves  <palves@redhat.com>
4165
4166         * stack.c (parse_backtrace_qualifiers): New.
4167         (backtrace_command): Use it.
4168         (backtrace_command_completer): Complete on qualifiers.
4169
4170 2019-06-13  Pedro Alves  <palves@redhat.com>
4171
4172         * frame.c: Include "cli/cli-option.h.
4173         (user_set_backtrace_options): New.
4174         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4175         Delete.
4176         (get_prev_frame): Adjust.
4177         (boolean_option_def, uinteger_option_def)
4178         (set_backtrace_option_defs): New.
4179         (_initialize_frame): Adjust and use
4180         gdb::option::add_setshow_cmds_for_options to install "set
4181         backtrace past-main" and "set backtrace past-entry".
4182         * frame.h: Include "cli/cli-option.h".
4183         (struct frame_print_options): Forward declare.
4184         (print_frame_arguments_all, print_frame_arguments_scalars)
4185         (print_frame_arguments_none): Declare.
4186         (print_entry_values): Delete declaration.
4187         (struct frame_print_options, user_frame_print_options): New.
4188         (struct set_backtrace_options): New.
4189         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4190         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4191         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4192         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4193         (list_args_or_locals): Add frame_print_options parameter.
4194         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4195         * python/py-framefilter.c (enumerate_args): Pass down
4196         USER_FRAME_PRINT_OPTIONS.
4197         * stack.c: Include "cli/cli-option.h".
4198         (print_frame_arguments_all, print_frame_arguments_scalars)
4199         (print_frame_arguments_none): Declare.
4200         (print_raw_frame_arguments, print_entry_values): Delete.
4201         (user_frame_print_options): New.
4202         (boolean_option_def, enum_option_def, frame_print_option_defs):
4203         New.
4204         (struct backtrace_cmd_options): New.
4205         (bt_flag_option_def): New.
4206         (backtrace_command_option_defs): New.
4207         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4208         (print_frame_arg, read_frame_arg, print_frame_args)
4209         (print_frame_info, print_frame): Add frame_print_options parameter
4210         and use it.
4211         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4212         (backtrace_command_1): Add frame_print_options and
4213         backtrace_cmd_options parameters and use them.
4214         (make_backtrace_options_def_group): New.
4215         (backtrace_command): Process command options with
4216         gdb::option::process_options.
4217         (backtrace_command_completer): New.
4218         (_initialize_stack): Extend "backtrace"'s help to mention
4219         supported options.  Install completer for "backtrace".
4220         Install some settings commands with add_setshow_cmds_for_options.
4221
4222 2019-06-13  Pedro Alves  <palves@redhat.com>
4223
4224         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4225         and that "set/show print raw frame-arguments" are now deprecated.
4226
4227         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4228         command.
4229         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4230         * stack.c (_initialize_stack): Install "set/show print
4231         raw-frame-arguments", and deprecate "set/show print raw
4232         frame-arguments".
4233         * valprint.c (_initialize_valprint): Deprecate "set/show print
4234         raw".
4235
4236 2019-06-13  Pedro Alves  <palves@redhat.com>
4237
4238         * compile/compile.c (struct compile_options): New.
4239         (compile_flag_option_def, compile_command_option_defs)
4240         (make_compile_options_def_group): New.
4241         (compile_file_command): Handle options with
4242         gdb::option::process_options.
4243         (compile_file_command_completer): New function.
4244         (compile_code_command): Handle options with
4245         gdb::option::process_options.
4246         (compile_code_command_completer): New function.
4247         (_initialize_compiler): Install completers for "compile code" and
4248         "compile file".  Mention available options in "compile code" and
4249         "compile code"'s help.
4250         * completer.c (advance_to_completion_word): New, factored out from
4251         ...
4252         (advance_to_expression_complete_word_point): ... this.
4253         (advance_to_filename_complete_word_point): New.
4254         * completer.h (advance_to_filename_complete_word_point): New
4255         declaration.
4256
4257 2019-06-13  Pedro Alves  <palves@redhat.com>
4258
4259         * compile/compile.c: Include "cli/cli-option.h".
4260         (compile_print_value): Scope data pointer is now a
4261         value_print_options pointer; adjust.
4262         (compile_print_command): Process options.  Scope data pointer is
4263         now a value_print_options pointer; adjust.
4264         (_initialize_compile): Update "compile print"'s help to include
4265         supported options.  Install a completer for "compile print".
4266         * cp-valprint.c (show_vtblprint, show_objectprint)
4267         (show_static_field_print): Delete.
4268         (_initialize_cp_valprint): Don't install "set print
4269         static-members", "set print vtbl", "set print object" here.
4270         * printcmd.c: Include "cli/cli-option.h" and
4271         "common/gdb_optional.h".
4272         (print_command_parse_format): Rework to fill in a
4273         value_print_options instead of a format_data.
4274         (print_value): Change parameter type from format_data pointer to
4275         value_print_options reference.  Adjust.
4276         (print_command_1): Process options.  Adjust to pass down a
4277         value_print_options.
4278         (print_command_completer): New.
4279         (_initialize_printcmd): Install print_command_completer as
4280         handle_brkchars completer for the "print" command.  Update
4281         "print"'s help to include supported options.
4282         * valprint.c: Include "cli/cli-option.h".
4283         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4284         here from cp-valprint.c.
4285         (boolean_option_def, uinteger_option_def)
4286         (value_print_option_defs, make_value_print_options_def_group):
4287         New.  Use gdb::option::add_setshow_cmds_for_options to install
4288         "set print elements", "set print null-stop", "set print repeats",
4289         "set print pretty", "set print union", "set print array", "set
4290         print address", "set print symbol", "set print array-indexes".
4291         * valprint.h: Include <string> and "cli/cli-option.h".
4292         (make_value_print_options_def_group): Declare.
4293         (print_value): Change parameter type from format_data pointer to
4294         value_print_options reference.
4295         (print_command_completer): Declare.
4296
4297 2019-06-13  Pedro Alves  <palves@redhat.com>
4298
4299         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4300         (COMMON_SFILES): Add maint-test-settings.c.
4301         * cli/cli-decode.c (boolean_enums): New global, factored out from
4302         ...
4303         (add_setshow_boolean_cmd): ... here.
4304         * cli/cli-decode.h (boolean_enums): Declare.
4305         * cli/cli-option.c: New file.
4306         * cli/cli-option.h: New file.
4307         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4308         factored out from ...
4309         (parse_cli_boolean_value(const char *)): ... this.
4310         (is_unlimited_literal): Change parameter type to pointer to
4311         pointer.  Adjust and advance ARG pointer.
4312         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4313         (parse_cli_var_enum): New, factored out from ...
4314         (do_set_command): ... this.  Adjust.
4315         * cli/cli-setshow.h (parse_cli_boolean_value)
4316         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4317         (parse_cli_var_enum): Declare.
4318         * cli/cli-utils.c: Include "cli/cli-option.h".
4319         (get_ulongest): New.
4320         * cli/cli-utils.h (get_ulongest): Declare.
4321         (check_for_argument): New overloads.
4322         * maint-test-options.c: New file.
4323
4324 2019-06-13  Pedro Alves  <palves@redhat.com>
4325
4326         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4327         parse a range if "-" is at the end of the string.
4328
4329 2019-06-13  Pedro Alves  <palves@redhat.com>
4330
4331         * cli/cli-setshow.c (parse_auto_binary_operation)
4332         (parse_cli_boolean_value): Don't allow "o".
4333
4334 2019-06-13  Pedro Alves  <palves@redhat.com>
4335
4336         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4337         * NEWS: Mention maint test-settings KIND.
4338         * maint-test-settings.c: New file.
4339
4340 2019-06-13  Pedro Alves  <palves@redhat.com>
4341
4342         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4343         completer.
4344         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4345         "set" completers.
4346
4347 2019-06-13  Pedro Alves  <palves@redhat.com>
4348
4349         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4350         after item.
4351
4352 2019-06-13  Pedro Alves  <palves@redhat.com>
4353
4354         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4355
4356 2019-06-13  Pedro Alves <palves@redhat.com>
4357
4358         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4359         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4360         call.
4361         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4362         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4363         calls.
4364         (check_for_argument): Skip spaces after argument.
4365
4366 2019-06-13  Pedro Alves  <palves@redhat.com>
4367
4368         * thread.c (thread_apply_command): Adjust TID parsing.
4369         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4370         detected before end of string.
4371         (tid_is_in_list): Error out if LIST is invalid.
4372
4373 2019-06-13  Pedro Alves  <palves@redhat.com>
4374
4375         * completer.c (complete_line_internal_1): Rewind completion word
4376         point.
4377         (completion_tracker::advance_custom_word_point_by): Change
4378         parameter type to int.
4379         * completer.h (completion_tracker::advance_custom_word_point_by):
4380         Likewise.
4381
4382 2019-06-13  Pedro Alves  <palves@redhat.com>
4383
4384         * completer.c (advance_to_completion_word): Handle delimiters.
4385
4386 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4387
4388         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4389
4390 2019-06-11  Tom Tromey  <tom@tromey.com>
4391
4392         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4393         (xmalloc_failed): Move to alloc.c.
4394         * alloc.c: New file.
4395         * Makefile.in (COMMON_SFILES): Add alloc.c.
4396
4397 2019-06-11  Tom Tromey  <tom@tromey.com>
4398
4399         * nat/linux-waitpid.c: Don't include server.h.
4400         (linux_debug): Remove.
4401         (my_waitpid): Update.
4402
4403 2019-06-11  Tom Tromey  <tromey@adacore.com>
4404
4405         * infcall.c (_initialize_infcall): Remove trailing newline from
4406         help.
4407         * user-regs.c (_initialize_user_regs): Remove trailing newline
4408         from help.
4409         * typeprint.c (_initialize_typeprint): Remove trailing newline
4410         from help.
4411         * reverse.c (_initialize_reverse): Remove trailing newlines from
4412         help.
4413         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4414         from help.
4415         * language.c (add_set_language_command): Remove trailing newline
4416         from help.
4417         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4418         help.
4419         * disasm.c (_initialize_disasm): Remove trailing newline from
4420         help.
4421         * top.c (init_main): Remove trailing newline from help.
4422         * interps.c (_initialize_interpreter): Remove trailing newline
4423         from help.
4424         * btrace.c (_initialize_btrace): Remove trailing newlines from
4425         help.
4426         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4427         from help.
4428         * python/python.c (_initialize_python): Remove trailing newline
4429         from help.
4430         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4431         help.
4432         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4433         from help.  Reformat some text.
4434         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4435         from help.
4436         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4437         newline from help.
4438
4439 2019-06-11  Tom Tromey  <tromey@adacore.com>
4440
4441         * darwin-nat.c (darwin_decode_exception_message)
4442         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4443
4444 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4445
4446         * valops.c (value_slice): Check for not allocated or not
4447         associated values.
4448
4449 2019-06-10  Tom de Vries  <tdevries@suse.de>
4450
4451         PR gdb/24618
4452         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4453         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4454         invalid.
4455
4456 2019-06-10  Tom de Vries  <tdevries@suse.de>
4457
4458         PR gdb/24611
4459         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4460         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4461
4462 2019-06-10  Tom de Vries  <tdevries@suse.de>
4463
4464         PR symtab/24545
4465         * symtab.c (struct demangled_name_entry): Add language field.
4466         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4467         static minimal symbol".  Set and use language field.
4468
4469 2019-06-10  Tom Tromey  <tromey@adacore.com>
4470
4471         * ada-lang.c (_initialize_ada_language): Update help text.
4472
4473 2019-06-10  Tom Tromey  <tromey@adacore.com>
4474
4475         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4476         with a newline.
4477         * guile/guile.c (handle_boot_error): Don't end warning with a
4478         newline.
4479         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4480         warning with a newline.
4481         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4482         newline.
4483         (s12z_frame_cache): Likewise.
4484         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4485         a newline.
4486         * solib-svr4.c (disable_probes_interface): Don't end warning with
4487         a newline.
4488         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4489         newline.
4490         * python/python.c (do_finish_initialization): Don't end warning
4491         with a newline.
4492
4493 2019-06-10  Tom Tromey  <tom@tromey.com>
4494
4495         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4496         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4497         gdbpy_enter.
4498
4499 2019-06-10  Tom Tromey  <tromey@adacore.com>
4500
4501         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4502         data.
4503         (elf_new_init): Don't call stabsread_new_init.
4504         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4505         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4506         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4507
4508 2019-06-10  Tom de Vries  <tdevries@suse.de>
4509
4510         PR symtab/16264
4511         PR symtab/24517
4512         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4513
4514 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4515
4516         * source.c (find_and_open_source): Also rewrite relative file
4517         names.
4518
4519 2019-04-26  Amos Bird  <amosbird@gmail.com>
4520
4521         * annotate.c (annotate_thread_exited): Add "thread-exited"
4522         annotation.
4523
4524 2019-06-06  Tom Tromey  <tromey@adacore.com>
4525
4526         * maint.h (class scoped_command_stats): Use
4527         DISABLE_COPY_AND_ASSIGN.
4528         <print_time>: New method.
4529         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4530         print_time.
4531         (scoped_command_stats::print_time): New method.
4532
4533 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4534
4535         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4536         instructions of lengths 6 or 8 bytes.
4537
4538 2019-06-04  Pedro Alves  <palves@redhat.com>
4539
4540         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4541
4542         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4543         * breakpoint.c (condition_completer): Likewise.
4544         * cli/cli-dump.c (scan_expression): Likewise.
4545         * common/filestuff.c (mkdir_recursive): Likewise.
4546         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4547         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4548         (gdb_abspath): Likewise.
4549         * compile/compile-cplus-types.c
4550         (compile_cplus_instance::decl_name): Likewise.
4551         * completer.c (complete_explicit_location):
4552         (signal_completer, reg_or_group_completer_1): Likewise.
4553         * cp-support.c (cp_remove_params_if_any): Likewise.
4554         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4555         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4556         * infcmd.c (strip_bg_char): Likewise.
4557         * linespec.c (copy_token_string): Likewise.
4558         * mi/mi-main.c (output_cores): Likewise.
4559         * psymtab.c (psymtab_search_name):
4560         * symfile.c (test_set_ext_lang_command): Likewise.
4561         * target.c (target_fileio_read_stralloc): Likewise.
4562         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4563         * value.c (complete_internalvar): Likewise.
4564
4565 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4566
4567         Add objfile property to gdb.Type.
4568         * NEWS: Mention Python API addition.
4569         * python/py-type.c (typy_get_objfile): New method.
4570
4571 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4572
4573         * NEWS: Mention the new set|show style [title|highlight].
4574         Mention changes to "show style", "help" and "apropos".
4575
4576 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4577
4578         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4579         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4580         instead of print_help_for_command.
4581         (print_doc_of_command): New function.
4582         (help_list): Add 'apropos -v word' suggestion.
4583         (print_help_for_command): Style the command name using title style.
4584         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4585         (_initialize_cli_cmds): Describe -v in apropos_command help.
4586
4587 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4588
4589         * cli/cli-style.h (cli_style_option): Add name in constructor,
4590         add m_name class member, add constructor with intensity,
4591         add name class function.
4592         (cli_style_option::add_setshow_commands): Remove name argument.
4593         (highlight_style, title_style): New styles.
4594         * cli/cli-style.c (do_show): New function that shows a style
4595         characteristic styling the style name with itself.
4596         (set_style_name): New function.
4597         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4598         Update all callers according to the changes in cli/cli-style.h.
4599         * utils.h (fputs_highlighted): New function.
4600         * utils.c (fputs_highlighted): Likewise.
4601
4602 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4603
4604         * NEWS: Mention new pipe command and new convenience variables.
4605
4606 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4607
4608         * cli/cli-cmds.c (pipe_command): New function.
4609         (_initialize_cli_cmds): Call add_com for pipe_command.
4610         Define | as an alias for pipe.
4611         (exit_status_set_internal_vars): New function.
4612         (shell_escape): Call exit_status_set_internal_vars.
4613         cli/cli-decode.c (find_command_name_length): Recognize | as
4614         a single character command.
4615
4616 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4617
4618         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4619         top.c (execute_command_to_ui_file): New function, mostly a copy
4620         of execute_command_to_string.
4621         (execute_command_to_string): Implement by calling
4622         execute_command_to_ui_file.
4623
4624 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4625
4626         * top.h (saved_command_line): Remove declaration.
4627         * top.c (previous_saved_command_line, previous_repeat_arguments):
4628         New variables.
4629         (saved_command_line): Make static, define together with other
4630         'repeat variables'.
4631         (dont_repeat): Clear repeat_arguments.
4632         (repeat_previous, get_saved_command_line, save_command_line):
4633         New functions.
4634         (gdb_init): Initialize saved_command_line
4635         and previous_saved_command_line.
4636         * main.c (captured_main_1): Remove saved_command_line initialization.
4637         * event-top.c (handle_line_of_input): Update to use
4638         the new 'repeat' related functions instead of direct access to
4639         saved_command_line.
4640         * command.h (repeat_previous, get_saved_command_line,
4641         save_command_line): New declarations.
4642         (dont_repeat): Add comment.
4643
4644 2019-05-30  Tom Tromey  <tromey@adacore.com>
4645
4646         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4647         Fix comment.
4648         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4649
4650 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4651
4652         PR cli/24587
4653         * completer.c (complete): Initialize variable word.
4654
4655 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4656
4657         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4658         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4659         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4660         'body' is NULL to the outter 'if', protecting the '!is_define'
4661         situation as well.
4662
4663 2019-05-29  Tom Tromey  <tromey@adacore.com>
4664
4665         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4666         (dwarf_unknown): New function.
4667         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4668         (dwarf_type_encoding_name): Use dwarf_unknown.
4669
4670 2019-05-29  Tom Tromey  <tromey@adacore.com>
4671
4672         PR c++/20020:
4673         * cp-valprint.c (cp_print_value_fields): Call
4674         cp_print_static_field inside "try".
4675
4676 2019-05-29  Tom Tromey  <tromey@adacore.com>
4677
4678         * inflow.c (struct terminal_info): Add default operator=.
4679         * configure: Rebuild.
4680         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4681         -Wdeprecated-copy-dtor, -Wredundant-move.
4682
4683 2019-05-29  Tom Tromey  <tromey@adacore.com>
4684
4685         * NEWS: Add entry.
4686         * infcmd.c (print_return_value_1): Handle finish_print
4687         option.
4688         (show_print_finish): New function.
4689         (_initialize_infcmd): Add "set/show print finish" commands.
4690         * valprint.c (user_print_options): Initialize new member.
4691         * valprint.h (struct value_print_options) <finish_print>: New
4692         member.
4693
4694 2019-05-28  Tom Tromey  <tromey@adacore.com>
4695
4696         * ada-lang.c (ada_remove_Xbn_suffix)
4697         (find_old_style_renaming_symbol)
4698         (parse_old_style_renaming): Remove.
4699         (ada_find_renaming_symbol): Don't call
4700         find_old_style_renaming_symbol.
4701         (ada_is_renaming_symbol): Rename from
4702         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4703         bool.  Now static.
4704         (ada_read_var_value): Update and simplify.
4705         * ada-exp.y (write_var_or_type): Remove old code.
4706
4707 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4708
4709         * event-top.c: Remove include comment.
4710         * inflow.c (class scoped_ignore_sigttou): Move from here...
4711         * inflow.h (class scoped_ignore_sigttou): ...to here.
4712         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4713         * top.c:  Remove include comment.
4714
4715 2019-05-27  Tom Tromey  <tom@tromey.com>
4716
4717         * NEWS: Fix typo.
4718
4719 2019-05-22  Tom Tromey  <tromey@adacore.com>
4720
4721         * target.c (target_follow_exec): Constify parameter.
4722         * target-delegates.c: Rebuild.
4723         * remote.c (remote_target::follow_exec): Constify parameter.
4724         * infrun.c (follow_exec): Constify parameter.
4725         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4726         (target_follow_exec): Likewise.
4727
4728 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4729
4730         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4731         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4732
4733 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4734
4735         * NEWS: Add debugredirect and testsuite sections.
4736
4737 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4738
4739         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4740         target descriptions using exclusively floating point register name
4741         aliases.
4742
4743 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4744
4745         PR gdb/18644:
4746         * f-lang.c (build_fortran_types): Handle the case where
4747         gdbarch_floatformat_for_type returns a nullptr.
4748
4749 2019-05-21  Tom de Vries  <tdevries@suse.de>
4750
4751         PR cli/24587
4752         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4753
4754 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4755
4756         PR gdb/18644:
4757         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4758         16-byte floats.
4759         * i386-tdep.c (i386_floatformat_for_type): Use
4760         floatformats_ia64_quad for the 16-byte floating point component
4761         within a fortran 32-byte complex number.
4762
4763 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4764
4765         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4766         delete default constructor.
4767         (find_partial_die): Update to return const struct.
4768         (partial_die_parent_scope): Move variable declaration into scope
4769         of its use and change its type to auto.
4770         (guess_partial_die_structure_name): Likewise.
4771         (partial_die_info::fixup): Likewise.
4772
4773 2019-05-17  Tom Tromey  <tromey@adacore.com>
4774
4775         * source.c (find_and_open_source): Remove cast.
4776
4777 2019-05-17  Tom Tromey  <tromey@adacore.com>
4778
4779         * annotate.c (annotate_source): Make "filename" const.
4780         * annotate.h (annotate_source): Use const.
4781
4782 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4783
4784         * disasm.c (set_disassembler_options): Send errors to stderr.
4785
4786 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4787
4788         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4789         (cli_interp_base::set_logging): Check debug_redirect.
4790         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4791         * cli/cli-logging.c (debug_redirect): Add static variable.
4792         (pop_output_files): Add default param.
4793         (handle_redirections): Print debug setting.
4794         (show_logging_command): Likewise.
4795         (_initialize_cli_logging): Add debugredirect command.
4796         * interps.c (current_interp_set_logging): Add debug_redirect
4797         parameter.
4798         * interps.h (set_logging): Add debug_redirect parameter.
4799         (current_interp_set_logging): Likewise.
4800         * mi/mi-common.h: Likewise.
4801         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4802
4803 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4804             Tom Tromey  <tromey@adacore.com>
4805
4806         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4807         directly.
4808         * cli/cli-interp.h (make_logging_output): Remove declaration.
4809         * cli/cli-logging.c (make_logging_output): Remove function.
4810         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4811         directly.
4812         * ui-file.c (tee_file::tee_file): Remove bools.
4813         (tee_file::~tee_file): Remove deletes.
4814         * ui-file.h (tee_file): Remove bools.
4815
4816 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4817
4818         * mi/mi-cmds.h (mi_cmd_complete): New function.
4819         * mi/mi-main.c (mi_cmd_complete): Likewise.
4820         * mi/mi-cmds.c: Define new MI command -complete.
4821         * NEWS: Mention new -complete command.
4822
4823 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4824
4825         * completer.h (complete): New function.
4826         * completer.c (complete): Likewise.
4827         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4828         function defined in completer.h.
4829
4830 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4831
4832         * MAINTAINERS (Write After Approval): Add myself.
4833
4834 2019-05-17  Tom de Vries  <tdevries@suse.de>
4835
4836         PR gdb/24094
4837         * dwarf2read.c (struct cu_partial_die_info): New struct.
4838         (find_partial_die): Return cu_partial_die_info.
4839         (partial_die_parent_scope, guess_partial_die_structure_name)
4840         (partial_die_info::fixup): Handle new return type of find_partial_die.
4841
4842 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4843
4844         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4845         "std::string", simplifying the algorithm.
4846
4847 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4848
4849         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4850         (stap_static_probe_ops::get_probes): Likewise.
4851
4852 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4853
4854         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4855         '-')" and "else if".
4856         (stap_parse_single_operand): Join checks for
4857         "gdbarch_stap_parse_special_token_p" and
4858         "gdbarch_stap_parse_special_token" in the same "if" statement.
4859         Invert check when verifying for operation on register
4860         displacement.
4861
4862 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4863
4864         * stap-probe.c (stap_get_opcode): Update comment.
4865         (stap_get_expected_argument_type): Likewise.
4866         (handle_stap_probe): Likewise.
4867
4868 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4869
4870         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4871         return type to 'bool'.  Adjust comment.  Use 'bool' when
4872         appropriate.
4873         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4874         * stap-probe.c (stap_parse_argument_1): Likewise.
4875         (stap_is_operator): Likewise.
4876         (stap_is_generic_prefix): Likewise.
4877         (stap_is_register_prefix): Likewise.
4878         (stap_is_register_indirection_prefix): Likewise.
4879         (stap_is_integer_prefix): Likewise.
4880         (stap_generic_check_suffix): Likewise.
4881         (stap_check_integer_suffix): Likewise.
4882         (stap_check_register_suffix): Likewise.
4883         (stap_check_register_indirection_suffix): Likewise.
4884         (stap_parse_register_operand): Likewise.
4885         (stap_parse_single_operand): Likewise.
4886         (stap_parse_argument_1): Likewise.
4887         (stap_probe::get_argument_count): Likewise.
4888         (stap_is_operator): Likewise.
4889
4890 2019-05-16  Tom Tromey  <tromey@adacore.com>
4891
4892         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4893         keyword to foreach.
4894
4895 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4896
4897         * linux-thread-db.c (try_thread_db_load_1): Change return type
4898         to bool.
4899         (try_thread_db_load): Likewise.
4900         (try_thread_db_load_from_pdir_1): Likewise.
4901         (try_thread_db_load_from_pdir): Likewise.
4902         (try_thread_db_load_from_sdir): Likewise.
4903         (try_thread_db_load_from_dir): Likewise.
4904         (thread_db_load_search): Likewise.
4905         (has_libpthread): Likewise.
4906         (thread_db_load): Likewise.
4907
4908 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4909
4910         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4911         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4912         NULL, and complain/return if that's the case.
4913
4914 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4915
4916         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4917         (advance, posn, abstract_read_memory): New functions.
4918         [struct mem_read_abstraction]: New struct.
4919         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4920
4921 2019-05-14  Tom Tromey  <tromey@adacore.com>
4922
4923         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4924         value is not lval_memory.
4925
4926 2019-05-14  Tom Tromey  <tromey@adacore.com>
4927
4928         * solib.c (info_sharedlibrary_command): Style the file name.
4929
4930 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4931
4932         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4933         (aarch64_vnv_type): Likewise.
4934         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4935         * common/tdesc.c: Likewise.
4936         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4937         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4938         * features/aarch64-fpu.xml: Add ieee half view.
4939         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4940         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4941         * gdbtypes.h (struct builtin_type): Likewise.
4942         (struct objfile_type): Likewise.
4943
4944 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4945
4946         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4947         typo.
4948         * location.h (string_to_event_location): Likewise.
4949
4950 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4951
4952         GDB 8.3 released.
4953
4954 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4955
4956         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4957         New variable declaration.
4958         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4959         New variable.
4960         (print_one_breakpoint): Use ui_out::test_flags and new global
4961         variable to compute use_fixed_output.
4962         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4963         Remove.
4964         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4965         (mi_multi_location_breakpoint_output_fixed): Remove.
4966         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4967         new variable.
4968         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4969         fix_multi_location_breakpoint_output flag if version >= 3.
4970         * ui-out.h (enum ui_out_flag)
4971         <fix_multi_location_breakpoint_output>: New enumerator.
4972
4973 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4974
4975         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4976
4977 2019-05-10  Tom Tromey  <tromey@adacore.com>
4978
4979         * ada-lang.c (catch_ada_completer): New function.
4980         (_initialize_ada_language): Use it.
4981
4982 2019-05-10  Tom Tromey  <tromey@adacore.com>
4983
4984         * thread.c (print_thread_info): Make "requested_threads" const.
4985         * gdbthread.h (print_thread_info): Make "requested_threads"
4986         const.
4987         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4988         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4989
4990 2019-05-08  Tom Tromey  <tom@tromey.com>
4991
4992         * gdbtypes.c (objfile_type_data): Change type.
4993         (objfile_type, _initialize_gdbtypes): Update.
4994
4995 2019-05-08  Tom Tromey  <tom@tromey.com>
4996
4997         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4998         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4999         (_initialize_dwarf2_frame): Update.
5000
5001 2019-05-08  Tom Tromey  <tom@tromey.com>
5002
5003         * objc-lang.c (objc_objfile_data): Change type.
5004         (find_methods): Update.
5005         (_initialize_objc_lang): Remove.
5006
5007 2019-05-08  Tom Tromey  <tom@tromey.com>
5008
5009         * stabsread.c (rs6000_builtin_type_data): Change type.
5010         (rs6000_builtin_type, _initialize_stabsread): Update.
5011
5012 2019-05-08  Tom Tromey  <tom@tromey.com>
5013
5014         * mips-tdep.c (mips_pdr_data): Remove.
5015         (_initialize_mips_tdep): Update.
5016
5017 2019-05-08  Tom Tromey  <tom@tromey.com>
5018
5019         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5020         (hppa_init_objfile_priv_data, read_unwind_info)
5021         (find_unwind_entry, _initialize_hppa_tdep): Update.
5022
5023 2019-05-08  Tom Tromey  <tom@tromey.com>
5024
5025         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5026         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5027         on obstack.
5028         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5029
5030 2019-05-08  Tom Tromey  <tom@tromey.com>
5031
5032         * mdebugread.c (basic_type_data): Change type.
5033         (basic_type, _initialize_mdebugread): Update.
5034
5035 2019-05-08  Tom Tromey  <tom@tromey.com>
5036
5037         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5038
5039 2019-05-08  Tom Tromey  <tom@tromey.com>
5040
5041         * nto-tdep.c (nto_inferior_data_reg): Change type.
5042         (nto_inferior_data): Update.
5043         (nto_inferior_data_cleanup, nto_new_inferior_data)
5044         (_initialize_nto_tdep): Remove.
5045         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5046
5047 2019-05-08  Tom Tromey  <tom@tromey.com>
5048
5049         * ada-lang.c (struct ada_inferior_data): Add initializers.
5050         (ada_inferior_data): Change type.
5051         (ada_inferior_data_cleanup): Remove.
5052         (get_ada_inferior_data, ada_inferior_exit)
5053         (struct ada_pspace_data): Add initializers, destructor.
5054         (ada_pspace_data_handle): Change type.
5055         (get_ada_pspace_data): Update.
5056         (ada_pspace_data_cleanup): Remove.
5057
5058 2019-05-08  Tom Tromey  <tom@tromey.com>
5059
5060         * coffread.c (struct coff_symfile_info): Add initializers.
5061         (coff_objfile_data_key): Move lower.  Change type.
5062         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5063         Update.
5064         (coff_free_info): Remove.
5065
5066 2019-05-08  Tom Tromey  <tom@tromey.com>
5067
5068         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5069         (fbsd_pspace_data_handle): Move lower.  Change type.
5070         (get_fbsd_pspace_data): Update.
5071         (fbsd_pspace_data_cleanup): Remove.
5072         (_initialize_fbsd_tdep): Update.
5073
5074 2019-05-08  Tom Tromey  <tom@tromey.com>
5075
5076         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5077         (get_ada_tasks_pspace_data): Update.
5078         (ada_tasks_pspace_data_cleanup): Remove.
5079         (_initialize_tasks): Update.
5080         (ada_tasks_inferior_data_handle): Change type.
5081         (get_ada_tasks_inferior_data): Update.
5082         (ada_tasks_inferior_data_cleanup): Remove.
5083         (struct ada_tasks_pspace_data): Add initializers.
5084
5085 2019-05-08  Tom Tromey  <tom@tromey.com>
5086
5087         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5088         * symfile-debug.c (debug_sym_get_probes): Change type.
5089         * stap-probe.c (handle_stap_probe):
5090         (stap_static_probe_ops::get_probes): Change type.
5091         * probe.h (class static_probe_ops) <get_probes>: Change type.
5092         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5093         (parse_probes_in_pspace): Update.
5094         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5095         Update.
5096         (any_static_probe_ops::get_probes): Change type.
5097         * elfread.c (elfread_data): New typedef.
5098         (probe_key): Change type.
5099         (elf_get_probes): Likewise.  Update.
5100         (probe_key_free): Remove.
5101         (_initialize_elfread): Update.
5102         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5103         Change type.
5104         (dtrace_process_dof_probe, dtrace_process_dof)
5105         (dtrace_static_probe_ops::get_probe): Change type.
5106
5107 2019-05-08  Tom Tromey  <tom@tromey.com>
5108
5109         * xcoffread.c (struct xcoff_symfile_info): Rename from
5110         coff_symfile_info.  Add initializers.
5111         (xcoff_objfile_data_key): Move lower.  Change type.
5112         (XCOFF_DATA): Rewrite.
5113         (xcoff_free_info): Remove.
5114         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5115         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5116         (xcoff_initial_scan): Update.
5117
5118 2019-05-08  Tom Tromey  <tom@tromey.com>
5119
5120         * solib-svr4.c (struct svr4_info): Add initializers and
5121         destructor.
5122         <probes_table>: Now an htab_up.
5123         (solib_svr4_pspace_data): Change type.
5124         (free_probes_table): Simplify.
5125         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5126         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5127         (probes_table_remove_objfile_probes, register_solib_event_probe)
5128         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5129         (_initialize_svr4_solib): Update.
5130
5131 2019-05-08  Tom Tromey  <tom@tromey.com>
5132
5133         * remote.c (remote_pspace_data): Change type.
5134         (remote_pspace_data_cleanup): Remove.
5135         (get_remote_exec_file, set_pspace_remote_exec_file)
5136         (_initialize_remote): Update.
5137
5138 2019-05-08  Tom Tromey  <tom@tromey.com>
5139
5140         * breakpoint.c (breakpoint_objfile_key): Change type.
5141         (get_breakpoint_objfile_data): Update.
5142         (free_breakpoint_objfile_data): Remove.
5143         (_initialize_breakpoint): Update.
5144
5145 2019-05-08  Tom Tromey  <tom@tromey.com>
5146
5147         * linux-tdep.c (struct linux_info): Add initializers.
5148         (linux_inferior_data): Move.  Change type.
5149         (invalidate_linux_cache_inf): Update.
5150         (linux_inferior_data_cleanup): Remove.
5151         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5152
5153 2019-05-08  Tom Tromey  <tom@tromey.com>
5154
5155         * auxv.c (auxv_inferior_data): Move.  Change type.
5156         (auxv_inferior_data_cleanup): Remove.
5157         (invalidate_auxv_cache_inf): Rewrite.
5158         (get_auxv_inferior_data, _initialize_auxv): Update.
5159
5160 2019-05-08  Tom Tromey  <tom@tromey.com>
5161
5162         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5163         (symfile_debug_objfile_data_key): Change type.
5164         (symfile_debug_installed, debug_qf_has_symbols)
5165         (debug_qf_find_last_source_symtab)
5166         (debug_qf_forget_cached_source_info)
5167         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5168         (debug_qf_print_stats, debug_qf_dump)
5169         (debug_qf_expand_symtabs_for_function)
5170         (debug_qf_expand_all_symtabs)
5171         (debug_qf_expand_symtabs_with_fullname)
5172         (debug_qf_map_matching_symbols)
5173         (debug_qf_expand_symtabs_matching)
5174         (debug_qf_find_pc_sect_compunit_symtab)
5175         (debug_qf_map_symbol_filenames)
5176         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5177         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5178         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5179         (debug_sym_read_linetable, debug_sym_relocate): Update.
5180         (symfile_debug_free_objfile): Remove.
5181         (install_symfile_debug_logging, _initialize_symfile_debug):
5182         Update.
5183
5184 2019-05-08  Tom Tromey  <tom@tromey.com>
5185
5186         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5187         allocate_on_obstack.
5188         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5189         (get_dwarf2_per_objfile): Update.
5190         (set_dwarf2_per_objfile): Remove.
5191         (dwarf2_has_info, dwarf2_get_section_info): Update.
5192         (dwarf2_free_objfile): Remove.
5193         (_initialize_dwarf2_read): Update.
5194
5195 2019-05-08  Tom Tromey  <tom@tromey.com>
5196
5197         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5198         initializers.
5199         <unsupported_script_warning_printed,
5200         script_not_found_warning_printed>: Now bool.
5201         (auto_load_pspace_data): Change type.
5202         (~auto_load_pspace_info): Rename from
5203         auto_load_pspace_data_cleanup.
5204         (get_auto_load_pspace_data, init_loaded_scripts_info)
5205         (clear_section_scripts, maybe_print_unsupported_script_warning)
5206         (maybe_print_script_not_found_warning, _initialize_auto_load):
5207         Update.
5208
5209 2019-05-08  Tom Tromey  <tom@tromey.com>
5210
5211         * objfiles.c (objfile_pspace_info): Add destructor and
5212         initializers.
5213         (objfiles_pspace_data): Change type.
5214         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5215         (get_objfile_pspace_data): Update.
5216         (objfiles_bfd_data): Change type.
5217         (get_objfile_bfd_data): Update.
5218         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5219
5220 2019-05-08  Tom Tromey  <tom@tromey.com>
5221
5222         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5223         Change type.
5224         (get_catch_syscall_inferior_data): Update.
5225         (catch_syscall_inferior_data_cleanup): Remove.
5226         (_initialize_break_catch_syscall): Update.
5227
5228 2019-05-08  Tom Tromey  <tom@tromey.com>
5229
5230         * inflow.c (struct terminal_info): Add destructor and
5231         initializers.
5232         (inflow_inferior_data): Change type.
5233         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5234         (get_inflow_inferior_data, inflow_inferior_exit)
5235         (swap_terminal_info, _initialize_inflow): Update.
5236
5237 2019-05-08  Tom Tromey  <tom@tromey.com>
5238
5239         * target-dcache.c (target_dcache_cleanup): Remove.
5240         (target_dcache_aspace_key): Change type.
5241         (target_dcache_init_p, target_dcache_invalidate)
5242         (target_dcache_get, target_dcache_get_or_init)
5243         (_initialize_target_dcache): Update.
5244         * dcache.h (struct dcache_deleter): New.
5245
5246 2019-05-08  Tom Tromey  <tom@tromey.com>
5247
5248         * symtab.c (struct symbol_cache): Add destructor and
5249         initializers.
5250         (symbol_cache_key): Move.  Change type.
5251         (make_symbol_cache, free_symbol_cache): Remove.
5252         (get_symbol_cache): Update.
5253         (symbol_cache_cleanup): Remove.
5254         (ALL_PSPACES, symbol_cache_flush)
5255         (maintenance_print_symbol_cache)
5256         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5257         Update.
5258
5259 2019-05-08  Tom Tromey  <tom@tromey.com>
5260
5261         * symtab.c (struct main_info): Add destructor and initializers.
5262         (main_progspace_key): Move.  Change type.
5263         (get_main_info): Update.
5264         (main_info_cleanup): Remove.
5265         (_initialize_symtab): Update.
5266
5267 2019-05-08  Tom Tromey  <tom@tromey.com>
5268
5269         * registry.h (DECLARE_REGISTRY): Define the _key class.
5270
5271 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5272
5273         * NEWS: Merge two 'New commands' sections.
5274
5275 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5276
5277         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5278         parameter and use Ada language definition instead.
5279         (ada_val_print_ptr): Remove unused language parameter.
5280         (ada_val_print_num): Remove language parameter and use Ada language
5281         definition instead.
5282         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5283         parameter.
5284         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5285         parameter and use Ada language definition instead.
5286         (ada_val_print_1): Update all ada_val_print_xxx calls.
5287         Remove language parameter.
5288         (ada_val_print): Update ada_val_print_1 call.
5289
5290 2019-05-08  Tom Tromey  <tromey@adacore.com>
5291
5292         * remote.c (remote_hw_watchpoint_limit)
5293         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5294         Now static.
5295
5296 2019-05-08  Tom Tromey  <tromey@adacore.com>
5297
5298         * maint.c (_initialize_maint_cmds): Move initialization code to
5299         remote.c.
5300         (watchdog, show_watchdog): Move to remote.c.
5301         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5302         "watchdog" static.
5303         (_initialize_remote): Move initialization code from maint.c.
5304         * defs.h (watchdog): Don't declare.
5305
5306 2019-05-08  Tom Tromey  <tromey@adacore.com>
5307
5308         * tui/tui-interp.c: Include main.h.
5309         * interps.c: Include main.h.
5310         * main.h (interpreter_p): Declare.
5311         * defs.h (interpreter_p): Don't declare.
5312
5313 2019-05-08  Tom Tromey  <tromey@adacore.com>
5314
5315         * dwarf2loc.c: Include dwarf2read.h.
5316         * defs.h (read_unsigned_leb128): Don't declare.
5317         * dwarf2read.h (read_unsigned_leb128): Declare.
5318
5319 2019-05-08  Tom Tromey  <tromey@adacore.com>
5320
5321         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5322         method.
5323
5324 2019-05-08  Tom Tromey  <tromey@adacore.com>
5325
5326         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5327         when no wrap column is set.
5328
5329 2019-05-08  Tom Tromey  <tromey@adacore.com>
5330
5331         * c-lang.c (c_get_string): Handle non-C-style arrays.
5332
5333 2019-05-08  Tom Tromey  <tromey@adacore.com>
5334
5335         * typeprint.c (print_offset_data::update): Print the bit offset,
5336         not the number of bits remaining.
5337
5338 2019-05-08  Tom Tromey  <tromey@adacore.com>
5339
5340         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5341         padding at end of comment.
5342
5343 2019-05-08  Tom Tromey  <tromey@adacore.com>
5344
5345         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5346         Compare main types.
5347
5348 2019-05-06  Tom Tromey  <tom@tromey.com>
5349
5350         * common/scoped_mmap.c: Include common-defs.h.
5351         * common/scoped_mmap.h: Don't include config.h.
5352
5353 2019-05-04  Tom Tromey  <tom@tromey.com>
5354
5355         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5356         (struct aarch64_call_info): Add initializers.
5357         <si>: Now a std::vector.
5358         (pass_on_stack, aarch64_push_dummy_call): Update.
5359
5360 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5361             Tom Tromey  <tom@tromey.com>
5362
5363         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5364         (ppc_threads): Now a std::vector.  Now static.
5365         (hwdebug_find_thread_points_by_tid)
5366         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5367         Update.
5368
5369 2019-05-04  Tom Tromey  <tom@tromey.com>
5370
5371         * arc-tdep.c (arc_tdesc_init): Return bool.
5372
5373 2019-05-04  Tom Tromey  <tom@tromey.com>
5374
5375         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5376         Use gdb_assert_not_reached.
5377
5378 2019-05-04  Tom Tromey  <tom@tromey.com>
5379
5380         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5381         "false".
5382
5383 2019-05-04  Tom Tromey  <tom@tromey.com>
5384
5385         * arc-tdep.c (arc_tdesc_init): Use bool.
5386
5387 2019-05-04  Tom Tromey  <tom@tromey.com>
5388
5389         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5390
5391 2019-05-04  Tom Tromey  <tom@tromey.com>
5392
5393         * cli/cli-cmds.c (valid_command_p): Return bool.
5394
5395 2019-05-04  Tom Tromey  <tom@tromey.com>
5396
5397         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5398         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5399
5400 2019-05-04  Raul Tambre  <raul@tambre.ee>
5401
5402         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5403         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5404         operator for comparison.
5405
5406 2019-05-04  Tom Tromey  <tom@tromey.com>
5407
5408         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5409         (lookup_partial_symbol, print_partial_symbols)
5410         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5411         (psymbol_compare): Update.
5412         (add_psymbol_to_bcache): Clear the entire psymbol.
5413         (maintenance_check_psymtabs): Update.
5414         * psympriv.h (struct partial_symbol): Don't derive from
5415         general_symbol_info.
5416         <obj_section, unrelocated_address, address,
5417         set_unrelocated_address>: Update.
5418         <ginfo>: New member.
5419         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5420         (debug_names::write_psymbols): Update.
5421
5422 2019-05-04  Tom de Vries  <tdevries@suse.de>
5423
5424         * contrib/cc-with-tweaks.sh: Support -n arg.
5425
5426 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5427
5428         * corelow.c (core_target::detach): Ensure frame cache and
5429         register caches are cleared.
5430         inferior.c (exit_inferior_1): Likewise.
5431
5432 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5433             Tom Tromey  <tom@tromey.com>
5434
5435         * dictionary.c (collate_pending_symbols_by_language): Remove
5436         "struct" from foreach.
5437         * symtab.c (lookup_global_symbol_from_objfile)
5438         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5439         foreach.
5440         * ser-tcp.c (net_open): Remove "struct" from foreach.
5441         * objfiles.c (objfile_relocate, objfile_rebase)
5442         (objfile_has_symbols): Remove "struct" from foreach.
5443         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5444         from foreach.
5445         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5446         foreach.
5447         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5448         "struct" from foreach.
5449         * ada-lang.c (create_excep_cond_exprs)
5450         (ada_exception_catchpoint_cond_string): Remove "struct" from
5451         foreach.
5452
5453 2019-05-03  Tom Tromey  <tromey@adacore.com>
5454
5455         * ada-exp.y (convert_char_literal): Check suffix of each
5456         enumerator.
5457
5458 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5459
5460         PR ada/21406:
5461         * ada-exp.y (yywrap): Don't define.
5462         * ada-lex.l (%option): Add noyywrap
5463         (yywrap): Remove.
5464
5465 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5466
5467         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5468         _WIN32_WINNT to the XP level, unless already defined to a higher
5469         level.
5470
5471         * unittests/parse-connection-spec-selftests.c:
5472         * ser-tcp.c:
5473         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5474         override.
5475
5476         * symfile.c (find_separate_debug_file): Remove colon from the
5477         drive spec of DOS/Windows file names of the target, so that the
5478         file name produced from DEBUGDIR and the target's directory will
5479         be valid on DOS/Windows systems.
5480
5481 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5482
5483         * rust-lang.c (val_print_struct): Handle printing structures
5484         containing strings.
5485
5486 2019-05-02  Tom Tromey  <tromey@adacore.com>
5487
5488         * valarith.c (_initialize_valarith): Remove.
5489
5490 2019-05-01  Tom Tromey  <tromey@adacore.com>
5491
5492         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5493         bitfields.
5494
5495 2019-05-01  Tom Tromey  <tromey@adacore.com>
5496
5497         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5498         for big-endian copies.
5499
5500 2019-04-30  Ali Tamur  <tamur@google.com>
5501         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5502         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5503         (read_3_bytes): New function.
5504
5505 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5506
5507         * windows-nat.c (main_thread_id): Delete.
5508         (handle_output_debug_string): Replace main_thread_id by
5509         current_event.dwThreadId.
5510         (fake_create_process): Likewise.
5511         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5512         Do not set main_thread_id.
5513         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5514         current_event.dwThreadId.
5515         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5516
5517 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5518
5519         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5520         Use current_event.dwThreadId instead of main_thread_id.
5521
5522 2019-04-30  Tom Tromey  <tromey@adacore.com>
5523
5524         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5525         (create_excep_cond_exprs): Iterate over program spaces.
5526         (ada_exception_catchpoint_cond_string): Examine all minimal
5527         symbols for exception types.
5528
5529 2019-04-30  Tom Tromey  <tromey@adacore.com>
5530
5531         PR c++/24470:
5532         * dwarf2read.c (process_structure_scope): Handle case where type
5533         has template parameters but no symbol was created.
5534
5535 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5536             Chris January  <chris.january@arm.com>
5537
5538         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5539         qualifier.
5540         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5541
5542 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5543
5544         * f-typeprint.c (f_print_type): Update rules for printing
5545         whitespace.
5546         (f_type_print_varspec_suffix): Likewise.
5547
5548 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5549             Chris January  <chris.january@arm.com>
5550
5551         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5552         function arguments.
5553
5554 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5555
5556         * f-lang.c (build_fortran_types): Change name of void type to
5557         lower case.
5558         * f-typeprint.c (f_type_print_base): Print the name of the void
5559         type, rather than a fixed string.
5560         * f-valprint.c (f_decorations): Use lower case void string.
5561
5562 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5563             Chris January  <chris.january@arm.com>
5564
5565         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5566         types for Fortran.
5567
5568 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5569             Chris January  <chris.january@arm.com>
5570             David Lecomber  <david.lecomber@arm.com>
5571
5572         * f-exp.y (BINOP_INTRINSIC): New token.
5573         (exp): New parser rule handling BINOP_INTRINSIC.
5574         (f77_keywords): Add new builtin procedures.
5575         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5576         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5577         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5578         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5579         (print_unop_subexp_f): New function.
5580         (print_binop_subexp_f): New function.
5581         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5582         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5583         (dump_subexp_body_f): Likewise.
5584         (operator_check_f): Likewise.
5585         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5586         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5587
5588 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5589
5590         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5591         UNOP_KIND.
5592         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5593         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5594         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5595         (operator_length_f): New fuction.
5596         (print_subexp_f): New function.
5597         (op_name_f): New function.
5598         (dump_subexp_body_f): New function.
5599         (operator_check_f): New function.
5600         (exp_descriptor_f): Replace standard expression handling functions
5601         with new functions.
5602         * gdb/fortran-operator.def: New file.
5603         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5604         * gdb/std-operator.def: Remove UNOP_KIND.
5605
5606 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5607
5608         * std-operator.def: Remove unbalanced, stray double quote
5609         character.
5610
5611 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5612             Chris January  <chris.january@arm.com>
5613             Daniel Everett  <daniel.everett@arm.com>
5614             Nick Forrington  <nick.forrington@arm.com>
5615             Richard Bunt  <richard.bunt@arm.com>
5616
5617         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5618         of depth when printing anonymous structs or unions.
5619         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5620         Don't print either the top-level value, or the children if the
5621         max-depth is exceeded.
5622         (ppscm_print_children): When printing the key of a map, allow one
5623         extra level of depth.
5624         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5625         print either the top-level value, or the children if the max-depth
5626         is exceeded.
5627         (print_children): When printing the key of a map, allow one extra
5628         level of depth.
5629         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5630         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5631         (user_print_options): Initialise max_depth field.
5632         (val_print_scalar_or_string_type_p): New function.
5633         (val_print): Check to see if the max depth has been reached.
5634         (val_print_check_max_depth): Define new function.
5635         (show_print_max_depth): New function.
5636         (_initialize_valprint): Add 'print max-depth' option.
5637         * valprint.h (struct value_print_options) <max_depth>: New field.
5638         (val_print_check_max_depth): Declare new function.
5639         * NEWS: Document new feature.
5640
5641 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5642
5643         * ada-lang.c (ada_language_defn): Initialise new field.
5644         * c-lang.c (c_is_string_type_p): New function.
5645         (c_language_defn): Initialise new field.
5646         (cplus_language_defn): Initialise new field.
5647         (asm_language_defn): Initialise new field.
5648         (minimal_language_defn): Initialise new field.
5649         * c-lang.h (c_is_string_type_p): Declare new function.
5650         * d-lang.c (d_language_defn): Initialise new field.
5651         * f-lang.c (f_is_string_type_p): New function.
5652         (f_language_defn): Initialise new field.
5653         * go-lang.c (go_is_string_type_p): New function.
5654         (go_language_defn): Initialise new field.
5655         * language.c (default_is_string_type_p): New function.
5656         (unknown_language_defn): Initialise new field.
5657         (auto_language_defn): Initialise new field.
5658         * language.h (struct language_defn) <la_is_string_type_p>: New
5659         member variable.
5660         (default_is_string_type_p): Declare new function.
5661         * m2-lang.c (m2_language_defn): Initialise new field.
5662         * objc-lang.c (objc_language_defn): Initialise new field.
5663         * opencl-lang.c (opencl_language_defn): Initialise new field.
5664         * p-lang.c (pascal_is_string_type_p): New function.
5665         (pascal_language_defn): Initialise new field.
5666         * rust-lang.c (rust_is_string_type_p): New function.
5667         (rust_language_defn): Initialise new field.
5668
5669 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5670
5671         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5672         New field.
5673         * ada-lang.c (ada_language_defn): Initialise new field.
5674         * c-lang.c (c_language_defn): Likewise.
5675         (cplus_language_defn): Likewise.
5676         (asm_language_defn): Likewise.
5677         (minimal_language_defn): Likewise.
5678         * d-lang.c (d_language_defn): Likewise.
5679         * f-lang.c (f_language_defn): Likewise.
5680         * go-lang.c (go_language_defn): Likewise.
5681         * language.c (unknown_language_defn): Likewise.
5682         (auto_language_defn): Likewise.
5683         * m2-lang.c (m2_language_defn): Likewise.
5684         * objc-lang.c (objc_language_defn): Likewise.
5685         * opencl-lang.c (opencl_language_defn): Likewise.
5686         * p-lang.c (pascal_language_defn): Likewise.
5687         * rust-lang.c (rust_language_defn): Likewise.
5688
5689 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5690
5691         * ada-lang.c (ada_is_character_type): Change return type to bool.
5692         (ada_is_string_type): Likewise.
5693         * ada-lang.h (ada_is_character_type): Update declaration
5694         (ada_is_string_type): Likewise.
5695
5696 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5697
5698         Support style in 'frame|thread apply'
5699
5700         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5701         * record.c (record_start, record_stop): Update callers of
5702         execute_command_to_string with false.
5703         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5704         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5705         methods.
5706         (class string_file): New constructor with term_out parameter.
5707         Override methods term_out and can_emit_style_escape.  New member
5708         term_out.
5709         (class stdio_file): Override can_emit_style_escape.
5710         (class tee_file): Override term_out and can_emit_style_escape.
5711         * utils.h (can_emit_style_escape): Remove.
5712         * utils.c (can_emit_style_escape): Likewise.
5713         Update all callers of can_emit_style_escape (SOMESTREAM) to
5714         SOMESTREAM->can_emit_style_escape.
5715         * source-cache.c (source_cache::get_source_lines): Likewise.
5716         * stack.c (frame_apply_command_count): Call execute_command_to_string
5717         passing the term_out characteristic of the current gdb_stdout.
5718         * thread.c (thr_try_catch_cmd): Likewise.
5719         * top.c (execute_command_to_string): pass term_out parameter
5720         to construct the string_file for the command output.
5721         * ui-file.c (term_cli_styling): New function (most code moved
5722         from utils.c can_emit_style_escape).
5723         (string_file::string_file, string_file::can_emit_style_escape,
5724         stdio_file::can_emit_style_escape, tee_file::term_out,
5725         tee_file::can_emit_style_escape): New functions.
5726
5727 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5728
5729         * NEWS: Mention the new set|show may-call-functions.
5730         * infcall.c (may_call_functions_p): New variable.
5731         (show_may_call_functions_p): New function.
5732         (call_function_by_hand_dummy): Throws an error if not
5733         may-call-functions.
5734         (_initialize_infcall): Call add_setshow_boolean_cmd for
5735         may-call-functions.
5736
5737 2019-04-25  Keith Seitz  <keiths@redhat.com>
5738
5739         PR c++/24367
5740         * cp-support.c (inspect_type): Don't attempt substitutions
5741         of symbol with the same name.
5742
5743 2019-04-25  Tom Tromey  <tromey@adacore.com>
5744
5745         PR gdb/24475:
5746         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5747         static.
5748
5749 2019-04-25  Tom Tromey  <tromey@adacore.com>
5750
5751         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5752         rvalue reference.
5753         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5754         (gdb_xml_parser::parse): Use std::move.
5755         * python/python-internal.h (gdbpy_convert_exception): Take a const
5756         reference.
5757         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5758         std::move.
5759         * python/py-utils.c (gdbpy_convert_exception): Take a const
5760         reference.
5761         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5762         Use std::move.
5763         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5764         Use std::move.
5765         * mi/mi-main.c (mi_print_exception): Take a const reference.
5766         * main.c (handle_command_errors): Take a const reference.
5767         * linespec.c (parse_linespec): Use std::move.
5768         * infcall.c (run_inferior_call): Use std::move.
5769         (call_function_by_hand_dummy): Use std::move.
5770         * exec.c (try_open_exec_file): Use std::move.
5771         * exceptions.h (exception_print, exception_fprintf)
5772         (exception_print_same): Update.
5773         * exceptions.c (print_exception, exception_print)
5774         (exception_fprintf, exception_print_same): Change parameters to
5775         const reference.
5776         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5777         * common/new-op.c: Use std::move.
5778         * common/common-exceptions.h (struct gdb_exception): Add move
5779         constructor.
5780         (struct gdb_exception_error, struct gdb_exception_quit, struct
5781         gdb_quit_bad_alloc): Change constructor to move constructor.
5782         (throw_exception): Change parameter to rvalue reference.
5783         * common/common-exceptions.c (throw_exception): Take rvalue
5784         reference.
5785         * cli/cli-interp.c (safe_execute_command): Use std::move.
5786         * breakpoint.c (insert_bp_location, location_to_sals): Use
5787         std::move.
5788
5789 2019-04-25  Tom Tromey  <tromey@adacore.com>
5790
5791         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5792         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5793         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5794         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5795         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5796         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5797         guile/scm-value.c: Use unpack.
5798         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5799         gdbscm_gdb_exception.
5800         (gdbscm_throw_gdb_exception): Likewise.
5801         (struct gdbscm_gdb_exception): New.
5802         (unpack): New function.
5803         (gdbscm_wrap): Use unpack.
5804
5805 2019-04-25  Tom Tromey  <tromey@adacore.com>
5806
5807         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5808         (gdb_rl_callback_handler): Use std::move.
5809         * common/common-exceptions.h (struct gdb_exception): Add move
5810         assignment operator.
5811         (throw_exception_sjlj): Change "exception" to const reference.
5812         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5813         (throw_exception_sjlj): Change "exception" to const reference.
5814
5815 2019-04-25  Tom Tromey  <tromey@adacore.com>
5816
5817         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5818         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5819         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5820         Update.
5821         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5822         Update.
5823         * mi/mi-interp.c (mi_interp::exec): Update.
5824         * linespec.c (parse_linespec): Update.
5825         * infcall.c (run_inferior_call): Update.
5826         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5827         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5828         (gdbscm_lookup_global_symbol): Update.
5829         * guile/scm-param.c (gdbscm_parameter_value): Update.
5830         * guile/scm-frame.c (gdbscm_frame_read_register)
5831         (gdbscm_frame_read_var): Update.
5832         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5833         * exec.c (try_open_exec_file): Update.
5834         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5835         (gdb_rl_callback_handler): Update.
5836         * common/common-exceptions.h (exception_none): Don't declare.
5837         * common/common-exceptions.c (exception_none): Don't define.
5838         (struct catcher) <exception>: Update.
5839         * cli/cli-interp.c (safe_execute_command): Update.
5840         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5841
5842 2019-04-25  Ali Tamur  <tamur@google.com>
5843
5844         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5845         (read_attribute_value): Likewise.
5846         (dwarf2_read_addr_index): Update comment.
5847         (read_str_index): Add DW_FORM_strx.
5848         (dwarf2_string_attr): Likewise.
5849         (dwarf2_const_value_attr): Likewise.
5850         (dump_die_shallow): Likewise.
5851         (dwarf2_fetch_constant_bytes): Likewise.
5852         (skip_form_bytes): Likewise.
5853         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5854
5855 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5856
5857         PR corefiles/11608
5858         PR corefiles/18187
5859         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5860         OFFSET.  Verify if current mapping contains an ELF header.
5861         (linux_find_memory_regions_full): Adjust call to
5862         dump_mapping_p.
5863
5864 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5865             Kang Li <kanglictf@gmail.com>
5866
5867         PR gdb/21600
5868
5869         * dwarf2-frame.c (read_initial_length): Be consistent about using
5870         unsigned representation of length.
5871         (decode_frame_entry_1): Likewise.  Check for wraparound of
5872         end pointer as well as buffer overflow.
5873
5874 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5875
5876         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5877         "vq".
5878
5879 2019-04-24  Tom Tromey  <tromey@adacore.com>
5880
5881         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5882
5883 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5884
5885         * s12z-tdep.c (s12z_unwind_pc): Delete.
5886         (s12z_unwind_sp): Delete.
5887         (s12z_gdbarch_init): Don't register deleted functions with
5888         gdbarch.
5889
5890 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5891
5892         * rl78-tdep.c (rl78_unwind_sp): Delete.
5893         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5894
5895 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5896
5897         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5898         (xstormy16_unwind_pc): Delete.
5899         (xstormy16_dummy_id): Delete.
5900         (xstormy16_gdbarch_init): Don't register deleted functions with
5901         gdbarch.
5902
5903 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5904
5905         * vax-tdep.c (vax_unwind_pc): Delete.
5906         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5907
5908 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5909
5910         * v850-tdep.c (v850_unwind_sp): Delete.
5911         (v850_unwind_pc): Delete.
5912         (v850_dummy_id): Delete.
5913         (v850_gdbarch_init): Don't register deleted functions with
5914         gdbarch.
5915
5916 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5917
5918         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5919         (tilegx_unwind_pc): Delete.
5920         (tilegx_unwind_dummy_id): Delete.
5921         (tilegx_gdbarch_init): Don't register deleted functions with
5922         gdbarch.
5923
5924 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5925
5926         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5927         (tic6x_dummy_id): Delete.
5928         (tic6x_gdbarch_init): Don't register deleted functions with
5929         gdbarch.
5930
5931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5932
5933         * sparc-tdep.c (sparc_unwind_pc): Delete.
5934         (sparc32_gdbarch_init): Don't register deleted function with
5935         gdbarch.
5936
5937 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5938
5939         * sh-tdep.c (sh_unwind_sp): Delete.
5940         (sh_unwind_pc): Delete.
5941         (sh_dummy_id): Delete.
5942         (sh_gdbarch_init): Don't register deleted functions with
5943         gdbarch.
5944
5945 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5946
5947         * score-tdep.c (score_unwind_sp): Delete.
5948         (score_unwind_pc): Delete.
5949         (score_dummy_id): Delete.
5950         (score_gdbarch_init): Don't register deleted functions with
5951         gdbarch.
5952
5953 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5954
5955         * rx-tdep.c (rx_unwind_pc): Delete.
5956         (rx_unwind_sp): Delete.
5957         (rx_dummy_id): Delete.
5958         (rx_gdbarch_init): Don't register deleted functions with
5959         gdbarch.  Update comment.
5960
5961 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5962
5963         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5964         (rs6000_dummy_id): Delete.
5965         (rs6000_gdbarch_init): Don't register deleted functions with
5966         gdbarch.
5967
5968 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5969
5970         * or1k-tdep.c (or1k_dummy_id): Delete.
5971         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5972
5973 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5974
5975         * nios2-tdep.c (nios2_dummy_id): Delete.
5976         (nios2_unwind_sp): Delete.
5977         (nios2_gdbarch_init): Don't register deleted functions with
5978         gdbarch.
5979
5980 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5981
5982         * nds32-tdep.c (nds32_dummy_id): Delete.
5983         (nds32_unwind_pc): Delete.
5984         (nds32_unwind_sp): Delete.
5985         (nds32_gdbarch_init): Don't register deleted functions with
5986         gdbarch.
5987
5988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5989
5990         * msp430-tdep.c (msp430_unwind_pc): Delete.
5991         (msp430_unwind_sp): Delete.
5992         (msp430_dummy_id): Delete.
5993         (msp430_gdbarch_init): Don't register deleted functions with
5994         gdbarch.
5995
5996 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5997
5998         * moxie-tdep.c (moxie_unwind_sp): Delete.
5999         (moxie_unwind_pc): Delete.
6000         (moxie_dummy_id): Delete.
6001         (moxie_gdbarch_init): Don't register deleted functions with
6002         gdbarch.
6003
6004 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6005
6006         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6007         (mn10300_unwind_pc): Delete.
6008         (mn10300_unwind_sp): Delete.
6009         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6010         mn10300_unwind_sp.
6011         (mn10300_frame_unwind_init): Don't register deleted functions with
6012         gdbarch.
6013
6014 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6015
6016         * mep-tdep.c (mep_unwind_pc): Delete.
6017         (mep_unwind_sp): Delete.
6018         (mep_dummy_id): Delete.
6019         (mep_gdbarch_init): Don't register deleted functions with
6020         gdbarch.
6021
6022 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6023
6024         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6025         (m68hc11_unwind_sp): Delete.
6026         (m68hc11_gdbarch_init): Don't register deleted functions with
6027         gdbarch.
6028
6029 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6030
6031         * m32r-tdep.c (m32r_unwind_sp): Delete.
6032         (m32r_unwind_pc): Delete.
6033         (m32r_dummy_id): Delete.
6034         (m32r_gdbarch_init): Don't register deleted functions with
6035         gdbarch.
6036
6037 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6038
6039         * m32c-tdep.c (m32c_unwind_pc): Delete.
6040         (m32c_unwind_sp): Delete.
6041         (m32c_dummy_id): Delete.
6042         (m32c_gdbarch_init): Don't register deleted functions with
6043         gdbarch.
6044
6045 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6046
6047         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6048         (lm32_unwind_pc): Delete.
6049         (lm32_dummy_id): Delete.
6050         (lm32_gdbarch_init): Don't register deleted functions with
6051         gdbarch.
6052
6053 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6054
6055         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6056         (iq2000_unwind_pc): Delete.
6057         (iq2000_dummy_id): Delete.
6058         (iq2000_gdbarch_init): Don't register deleted functions with
6059         gdbarch.
6060
6061 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6062
6063         * nds32-tdep.c (nds32_type_align): Delete.
6064         (nds32_push_dummy_call): Use type_align instead.
6065
6066 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6067
6068         * arm-tdep.c (arm_type_align): Only handle vector override case.
6069         (arm_push_dummy_call): Use type_align.
6070         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6071
6072 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6073
6074         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6075         case.
6076         (pass_on_stack): Use type_align.
6077         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6078         function.
6079
6080 2019-04-23  Tom Tromey  <tromey@adacore.com>
6081
6082         * dwarf2read.c (line_header::file_name_at): Remove unused
6083         overload.
6084
6085 2019-04-23  Tom de Vries  <tdevries@suse.de>
6086
6087         PR gdb/24438
6088         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6089         invocation.
6090
6091
6092 2019-03-27  Ali Tamur  <tamur@google.com>
6093
6094         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6095         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6096         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6097         (dwarf_expr_context::get_addr_index): Likewise
6098         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6099         (symbol_needs_eval_context::get_addr_index): Likewise
6100         (disassemble_dwarf_expression): Add DW_OP_addrx
6101         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6102         (read_cutu_die_from_dwo): Update comment
6103         (skip_one_die): Add DW_FORM_addrx
6104         (read_attribute_value): Likewise
6105         (var_decode_location): Add DW_OP_addrx
6106         (dwarf2_const_value_attr): Add DW_FORM_addrx
6107         (dump_die_shallow): Likewise
6108         (dwarf2_fetch_constant_bytes): Likewise
6109         (decode_locdesc): Add DW_OP_addrx
6110         (skip_form_bytes): Add DW_FORM_addrx
6111
6112 2019-04-22  Ali Tamur  <tamur@google.com>
6113
6114         * MAINTAINERS (Write After Approval): Add self.
6115
6116 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6117
6118         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6119         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6120         (open_symbol_file_object): Likewise.
6121         (svr4_default_sos): Add info parameter.
6122         (svr4_read_so_list): Likewise.
6123         (svr4_current_sos_direct): Adjust functions calls to pass down
6124         info.
6125         (svr4_current_sos_1): Add info parameter.
6126         (svr4_current_sos): Call get_svr4_info, pass info down to
6127         svr4_current_sos_1.
6128         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6129         get_svr4_info.
6130         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6131         get_svr4_info.
6132         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6133         to get_svr4_info.
6134         (probes_table_remove_objfile_probes): Likewise.
6135         (register_solib_event_probe): Add info parameter.
6136         (solist_update_incremental): Pass info parameter down to
6137         svr4_read_so_list.
6138         (disable_probes_interface): Add info parameter.
6139         (svr4_handle_solib_event): Pass current_program_space to
6140         get_svr4_info.  Adjust disable_probes_interface cleanup.
6141         (svr4_create_probe_breakpoints): Add info parameter, pass it
6142         down to register_solib_event_probe.
6143         (svr4_create_solib_event_breakpoints): Add info parameter,
6144         pass it down to svr4_create_probe_breakpoints.
6145         (enable_break): Pass info down to
6146         svr4_create_solib_event_breakpoints.
6147         (svr4_solib_create_inferior_hook): Pass current_program_space to
6148         get_svr4_info.
6149         (svr4_clear_solib): Likewise.
6150
6151 2019-04-22  Pedro Alves  <palves@redhat.com>
6152
6153         * solib-svr4.c (svr4_free_objfile_observer): New.
6154         (probe_and_action::objfile): New field.
6155         (probes_table_htab_remove_objfile_probes)
6156         (probes_table_remove_objfile_probes): New functions.
6157         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6158         in the new probe_and_action.  Don't store the probe in 'lookup'.
6159         (svr4_create_probe_breakpoints): Pass objfile to
6160         register_solib_event_probe.
6161         (_initialize_svr4_solib): Register a free_objfile observer.
6162
6163 2019-04-19  Tom Tromey  <tom@tromey.com>
6164
6165         * common/queue.h: Remove.
6166
6167 2019-04-19  Tom Tromey  <tom@tromey.com>
6168
6169         * event-loop.c: Don't include "common/queue.h".
6170
6171 2019-04-19  Tom Tromey  <tom@tromey.com>
6172
6173         * remote.c (remote_target): Use delete.
6174         * remote-notif.h: Include <list>, not "common/queue.h".
6175         (notif_client_p): Remove typedef.
6176         (remote_notif_state): Add constructor, destructor, initializer.
6177         <notif_queue>: Now a std::list.
6178         (remote_notif_state_xfree): Don't declare.
6179         * remote-notif.c (remote_notif_process, handle_notification)
6180         (remote_notif_state_allocate): Update.
6181         (~remote_notif_state): Rename from remote_notif_state_xfree.
6182
6183 2019-04-19  Tom Tromey  <tom@tromey.com>
6184
6185         * symfile.c (reread_symbols): Update.
6186         * objfiles.c (objfile_register_static_link)
6187         (objfile_lookup_static_link): Update
6188         (~objfile) Don't delete static_links.
6189         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6190
6191 2019-04-19  Tom Tromey  <tom@tromey.com>
6192
6193         * type-stack.h (struct type_stack) <insert>: Constify string.
6194         * type-stack.c (type_stack::insert): Constify string.
6195         * gdbtypes.h (lookup_template_type): Update.
6196         (address_space_name_to_int): Update.
6197         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6198         const.
6199         (lookup_template_type): Make name const.
6200         * c-exp.y: Update rules.
6201         (lex_one_token, classify_name, classify_inner_name)
6202         (c_print_token): Update.
6203         * p-exp.y: Update rules.
6204         (yylex): Update.
6205         * f-exp.y: Update rules.
6206         (yylex): Update.
6207         * d-exp.y: Update rules.
6208         (lex_one_token, classify_name, classify_inner_name): Update.
6209         * parse.c (write_dollar_variable, copy_name): Return std::string.
6210         * parser-defs.h (copy_name): Change return type.
6211         * m2-exp.y: Update rules.
6212         (yylex): Update.
6213         * go-exp.y (lex_one_token): Update.
6214         Update rules.
6215         (classify_unsafe_function, classify_packaged_name)
6216         (classify_name, yylex): Update.
6217
6218 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6219
6220         * configure.ac: add --enable-source-highlight switch.
6221         * configure: Regenerate.
6222         * top.c (print_gdb_version): plumb --enable-source-highlight
6223         status to "show configuration".
6224
6225 2019-04-19  Tom Tromey  <tromey@adacore.com>
6226
6227         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6228         Check ADA_TYPE_P.
6229         (empty_record, ada_template_to_fixed_record_type_1)
6230         (template_to_static_fixed_type)
6231         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6232         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6233         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6234         macros.
6235
6236 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6237
6238         PR symtab/24423:
6239         * source.c (print_source_lines_base): Advance "iter" when a
6240         control character is seen.
6241
6242 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6243
6244         * inferior.h (struct infcall_suspend_state_deleter):
6245         Catch exception in destructor to avoid crash.
6246
6247 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6248
6249         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6250         close to the add_com "shell".
6251
6252 2019-04-18  Tom Tromey  <tromey@adacore.com>
6253
6254         * process-stratum-target.h (class process_stratum_target)
6255         <stratum>: Add "final".
6256
6257 2019-04-17  Tom Tromey  <tromey@adacore.com>
6258
6259         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6260         against nullptr before use.
6261
6262 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6263
6264         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6265
6266 2019-04-17  Jim Wilson  <jimw@sifive.com>
6267             Andrew Burgess  <andrew.burgess@embecosm.com>
6268
6269         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6270         code read might fail, assume 4-byte breakpoint in that case.
6271
6272 2019-04-15  Leszek Swirski  <leszeks@google.com>
6273
6274         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6275         rather than a hand-rolled POD check when checking for forced MEMORY
6276         classification.
6277
6278 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6279
6280         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6281         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6282         function.
6283         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6284         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6285         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6286         declaration.
6287
6288 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6289
6290         * aarch64-linux-nat.c
6291         (aarch64_linux_nat_target::thread_architecture): Add override.
6292         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6293         each VQ.
6294
6295 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6296
6297         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6298
6299 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6300
6301         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6302         target types of size 96-bits, add some additional comments, and
6303         check that the builtin type we found was the correct size.
6304
6305 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6306
6307         * utils.c (prompt_for_continue): Don't restore the styling at the
6308         end, as applied_style has the wrong value.  This fixes styling in
6309         long lists of file names that are interrupted by the "Continue?"
6310         prompt.
6311
6312 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6313
6314         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6315         * c-lang.c (c_language_defn): Likewise.
6316         (cplus_language_defn): Likewise.
6317         (asm_language_defn): Likewise.
6318         (minimal_language_defn): Likewise.
6319         * d-lang.c (d_language_defn): Likewise.
6320         * f-lang.c (f_language_defn): Likewise.
6321         * go-lang.c (go_language_defn): Likewise.
6322         * language.c (unknown_language_defn): Likewise.
6323         (auto_language_defn): Likewise.
6324         * language.h (struct language_defn): Remove la_magic field.
6325         (LANG_MAGIC): Delete.
6326         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6327         * objc-lang.c (objc_language_defn): Likewise.
6328         * opencl-lang.c (opencl_language_defn): Likewise.
6329         * p-lang.c (pascal_language_defn): Likewise.
6330         * rust-lang.c (rust_language_defn): Likewise.
6331
6332 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6333
6334         * riscv-tdep.c (riscv_type_align): New function.
6335         (riscv_type_alignment): Delete.
6336         (riscv_arg_location): Use 'type_align'.
6337         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6338
6339 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6340
6341         * gdbtypes.c (type_align): A struct with no non-static fields also
6342         has alignment of 1.
6343
6344 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6345
6346         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6347         component to 0.
6348         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6349         member.
6350         (riscv_struct_info::analyse): New implementation using new
6351         analyse_inner member function.
6352         (riscv_struct_info::field_offset): New member function.
6353         (riscv_struct_info::m_offsets): New member variable.
6354         (riscv_struct_info::analyse_inner): New private member function,
6355         takes the old implementation of riscv_struct_info::analyse but
6356         extended to track field offsets.
6357         (riscv_call_arg_struct): Update the struct folding special cases
6358         to handle cases where empty C++ structs, which are non-zero
6359         length, are found.
6360         (riscv_arg_location): Initialise the length of each location, a
6361         non-zero length now indicates the location is in use.
6362         (riscv_push_dummy_call): Allow for the first location having a
6363         non-zero offset when setting up arguments.
6364         (riscv_return_value): Likewise, but for return values.
6365
6366 2019-04-11  Tom Tromey  <tromey@adacore.com>
6367
6368         * utils.c (internal_vproblem): Make "msg" const.
6369
6370 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6371
6372         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6373         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6374         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6375         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6376
6377 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6378
6379         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6380         function.
6381         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6382         of amd64_collect_native_gregset.
6383         (amd64_linux_nat_target::store_registers): Likewise.
6384
6385 2019-04-10  Tom Tromey  <tom@tromey.com>
6386
6387         * symtab.c (lookup_global_symbol_from_objfile)
6388         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6389         * objfiles.h (class separate_debug_iterator): New.
6390         (class separate_debug_range): New.
6391         (struct objfile) <separate_debug_objfiles>: New method.
6392         (objfile_separate_debug_iterate): Don't declare.
6393         * objfiles.c (separate_debug_iterator::operator++): Rename from
6394         objfile_separate_debug_iterate.
6395         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6396         iterator.
6397         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6398         iterator.
6399
6400 2019-04-10  Tom Tromey  <tom@tromey.com>
6401
6402         * symfile.c (reread_symbols): Remove old comment.
6403         * objfiles.c (free_all_objfiles): Fix a typo.
6404
6405 2019-04-10  Tom Tromey  <tom@tromey.com>
6406
6407         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6408         * minsyms.c (lookup_minimal_symbol): Use foreach.
6409         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6410         (lookup_minimal_symbol_solib_trampoline): Likewise.
6411         * symfile.c (reread_symbols): Use foreach.
6412
6413 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6414             Tom Tromey  <tromey@adacore.com>
6415
6416         PR rust/24414:
6417         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6418         (rust_lex_int_test): Change "value" to be LONGEST.
6419         (rust_lex_tests): Add test for long integer literal.
6420
6421 2019-04-09  Tom Tromey  <tromey@adacore.com>
6422
6423         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6424         to bool.
6425         (extended_remote_target::attach): Update.
6426         (remote_target::remote_notice_new_inferior): Update.
6427         (remote_target::add_current_inferior_and_thread): Update.
6428         * inferior.c (exit_inferior_1): Use "false".
6429         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6430
6431 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6432
6433         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6434         the "start" command.
6435
6436 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6437
6438         * python/py-inferior.c (infpy_thread_from_thread_handle):
6439         Adjust comments to reflect renaming of thread_from_thread_handle
6440         to thread_from_handle.  Adjust keywords.  Fix type error message.
6441         (inferior_object_methods): Add thread_from_handle.  Retain
6442         thread_from_thread_handle, but mark it as deprecated.
6443
6444 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6445
6446         * gdbthread.h (find_thread_by_handle): Revise declaration.
6447         * thread.c (find_thread_by_handle): Likewise.  Adjust
6448         implementation too.
6449         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6450         support for buffer objects as handles.
6451
6452 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6453
6454         * python/py-infthread.c (thpy_thread_handle): New function.
6455         (thread_object_methods): Register thpy_thread_handle.
6456
6457 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6458
6459         * gdbthread.h (thread_to_thread_handle): Declare.
6460         * thread.c (gdbtypes.h): Include.
6461         (thread_to_thread_handle): New function.
6462
6463         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6464         (target_thread_info_to_thread_handle): Declare.
6465         * target.c (target_thread_info_to_thread_handle): New function.
6466         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6467         * target-delegates.c: Regenerate.
6468
6469         * linux-thread-db.c (class thread_db_target): Add method
6470         thread_info_to_thread_handle.
6471         (thread_db_target::thread_info_to_thread_handle): Define.
6472         * remote.c (class remote_target): Add new method
6473         thread_info_to_thread_handle.
6474         (remote_target::thread_info_to_thread_handle): Define.
6475
6476 2019-04-08  Pedro Alves  <palves@redhat.com>
6477
6478         * common/common-exceptions.c (throw_exception): Don't create
6479         named object to throw; throw directly.
6480         (throw_it): Likewise.  Don't initialize gdb_exception::message
6481         here, with new; pass FMT and AP to the ctor instead.
6482         * common/common-exceptions.h: Include <string>.
6483         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6484         const char *, va_list)): New ctor.  Use std::make_shared.
6485         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6486         errors)): Delete.
6487         (gdb_exception_error::gdb_exception_error(enum errors, const char
6488         *, va_list)): New.
6489         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6490         Add assertion.
6491         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6492         errors)): Delete.
6493         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6494         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6495         Add assertion.
6496
6497 2019-04-08  Tom Tromey  <tom@tromey.com>
6498
6499         * valops.c (value_rtti_indirect_type): Replace throw_exception
6500         with throw.
6501         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6502         with throw.
6503         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6504         throw.
6505         * target.c (target_translate_tls_address): Replace throw_exception
6506         with throw.
6507         * stack.c (frame_apply_command_count): Replace throw_exception
6508         with throw.
6509         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6510         throw.
6511         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6512         with throw.
6513         * rs6000-tdep.c (rs6000_frame_cache)
6514         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6515         * remote.c: Replace throw_exception with throw.
6516         * record-full.c (record_full_message, record_full_wait_1)
6517         (record_full_restore): Replace throw_exception with throw.
6518         * record-btrace.c:
6519         (get_thread_current_frame_id, record_btrace_start_replaying)
6520         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6521         (cmd_record_btrace_start): Replace throw_exception with throw.
6522         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6523         throw.
6524         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6525         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6526         * linespec.c:
6527         (find_linespec_symbols): Replace throw_exception with throw.
6528         * infrun.c (displaced_step_prepare, resume): Replace
6529         throw_exception with throw.
6530         * infcmd.c (post_create_inferior): Replace throw_exception with
6531         throw.
6532         * inf-loop.c (inferior_event_handler): Replace throw_exception
6533         with throw.
6534         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6535         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6536         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6537         (get_prev_frame_always, get_frame_pc_if_available)
6538         (get_frame_address_in_block_if_available, get_frame_language):
6539         Replace throw_exception with throw.
6540         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6541         throw_exception with throw.
6542         * eval.c (fetch_subexp_value, evaluate_var_value)
6543         (evaluate_funcall, evaluate_subexp_standard): Replace
6544         throw_exception with throw.
6545         * dwarf2loc.c (call_site_find_chain)
6546         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6547         Replace throw_exception with throw.
6548         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6549         with throw.
6550         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6551         throw.
6552         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6553         * completer.c (complete_line_internal): Replace throw_exception
6554         with throw.
6555         * compile/compile-object-run.c (compile_object_run): Replace
6556         throw_exception with throw.
6557         * cli/cli-script.c (process_next_line): Replace throw_exception
6558         with throw.
6559         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6560         (btrace_enable, btrace_maint_update_pt_packets): Replace
6561         throw_exception with throw.
6562         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6563         throw_exception with throw.
6564         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6565         throw_exception with throw.
6566         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6567         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6568         * aarch64-tdep.c (aarch64_make_prologue_cache)
6569         (aarch64_make_stub_cache): Replace throw_exception with throw.
6570
6571 2019-04-08  Tom Tromey  <tom@tromey.com>
6572
6573         * common/common-exceptions.c (throw_exception): Rename from
6574         throw_exception_cxx.  Remove old copy.  Make argument const.
6575         (throw_it): Create and throw exception objects directly.
6576         * common/common-exceptions.h (throw_exception): Make argument
6577         const.
6578         (struct gdb_exception_error): Add constructor.
6579         (struct gdb_exception_quit): Add constructor.
6580
6581 2019-04-08  Tom Tromey  <tom@tromey.com>
6582
6583         * common/common-exceptions.h (exception_rethrow): Don't declare.
6584         (TRY_SJLJ): Update comment.
6585         (TRY, CATCH, END_CATCH): Remove.
6586         * common/common-exceptions.c (exception_rethrow): Remove.
6587
6588 2019-04-08  Tom Tromey  <tom@tromey.com>
6589
6590         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6591         Remove.
6592         (gdb_exception_error): Rename from
6593         gdb_exception_RETURN_MASK_ERROR.
6594         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6595         (gdb_quit_bad_alloc): Update.
6596         * aarch64-tdep.c: Update.
6597         * ada-lang.c: Update.
6598         * ada-typeprint.c: Update.
6599         * ada-valprint.c: Update.
6600         * amd64-tdep.c: Update.
6601         * arch-utils.c: Update.
6602         * break-catch-throw.c: Update.
6603         * breakpoint.c: Update.
6604         * btrace.c: Update.
6605         * c-varobj.c: Update.
6606         * cli/cli-cmds.c: Update.
6607         * cli/cli-interp.c: Update.
6608         * cli/cli-script.c: Update.
6609         * common/common-exceptions.c: Update.
6610         * common/new-op.c: Update.
6611         * common/selftest.c: Update.
6612         * compile/compile-c-symbols.c: Update.
6613         * compile/compile-cplus-symbols.c: Update.
6614         * compile/compile-object-load.c: Update.
6615         * compile/compile-object-run.c: Update.
6616         * completer.c: Update.
6617         * corelow.c: Update.
6618         * cp-abi.c: Update.
6619         * cp-support.c: Update.
6620         * cp-valprint.c: Update.
6621         * darwin-nat.c: Update.
6622         * disasm-selftests.c: Update.
6623         * dtrace-probe.c: Update.
6624         * dwarf-index-cache.c: Update.
6625         * dwarf-index-write.c: Update.
6626         * dwarf2-frame-tailcall.c: Update.
6627         * dwarf2-frame.c: Update.
6628         * dwarf2loc.c: Update.
6629         * dwarf2read.c: Update.
6630         * eval.c: Update.
6631         * event-loop.c: Update.
6632         * event-top.c: Update.
6633         * exec.c: Update.
6634         * f-valprint.c: Update.
6635         * fbsd-tdep.c: Update.
6636         * frame-unwind.c: Update.
6637         * frame.c: Update.
6638         * gdbtypes.c: Update.
6639         * gnu-v3-abi.c: Update.
6640         * guile/guile-internal.h: Update.
6641         * guile/scm-block.c: Update.
6642         * guile/scm-breakpoint.c: Update.
6643         * guile/scm-cmd.c: Update.
6644         * guile/scm-disasm.c: Update.
6645         * guile/scm-frame.c: Update.
6646         * guile/scm-lazy-string.c: Update.
6647         * guile/scm-math.c: Update.
6648         * guile/scm-param.c: Update.
6649         * guile/scm-ports.c: Update.
6650         * guile/scm-pretty-print.c: Update.
6651         * guile/scm-symbol.c: Update.
6652         * guile/scm-symtab.c: Update.
6653         * guile/scm-type.c: Update.
6654         * guile/scm-value.c: Update.
6655         * i386-linux-tdep.c: Update.
6656         * i386-tdep.c: Update.
6657         * inf-loop.c: Update.
6658         * infcall.c: Update.
6659         * infcmd.c: Update.
6660         * infrun.c: Update.
6661         * jit.c: Update.
6662         * language.c: Update.
6663         * linespec.c: Update.
6664         * linux-fork.c: Update.
6665         * linux-nat.c: Update.
6666         * linux-tdep.c: Update.
6667         * linux-thread-db.c: Update.
6668         * main.c: Update.
6669         * mi/mi-cmd-break.c: Update.
6670         * mi/mi-cmd-stack.c: Update.
6671         * mi/mi-interp.c: Update.
6672         * mi/mi-main.c: Update.
6673         * objc-lang.c: Update.
6674         * p-valprint.c: Update.
6675         * parse.c: Update.
6676         * ppc-linux-tdep.c: Update.
6677         * printcmd.c: Update.
6678         * python/py-arch.c: Update.
6679         * python/py-breakpoint.c: Update.
6680         * python/py-cmd.c: Update.
6681         * python/py-finishbreakpoint.c: Update.
6682         * python/py-frame.c: Update.
6683         * python/py-framefilter.c: Update.
6684         * python/py-gdb-readline.c: Update.
6685         * python/py-inferior.c: Update.
6686         * python/py-infthread.c: Update.
6687         * python/py-lazy-string.c: Update.
6688         * python/py-linetable.c: Update.
6689         * python/py-objfile.c: Update.
6690         * python/py-param.c: Update.
6691         * python/py-prettyprint.c: Update.
6692         * python/py-progspace.c: Update.
6693         * python/py-record-btrace.c: Update.
6694         * python/py-record.c: Update.
6695         * python/py-symbol.c: Update.
6696         * python/py-type.c: Update.
6697         * python/py-unwind.c: Update.
6698         * python/py-utils.c: Update.
6699         * python/py-value.c: Update.
6700         * python/python.c: Update.
6701         * record-btrace.c: Update.
6702         * record-full.c: Update.
6703         * remote-fileio.c: Update.
6704         * remote.c: Update.
6705         * riscv-tdep.c: Update.
6706         * rs6000-aix-tdep.c: Update.
6707         * rs6000-tdep.c: Update.
6708         * rust-exp.y: Update.
6709         * rust-lang.c: Update.
6710         * s390-tdep.c: Update.
6711         * selftest-arch.c: Update.
6712         * solib-dsbt.c: Update.
6713         * solib-frv.c: Update.
6714         * solib-spu.c: Update.
6715         * solib-svr4.c: Update.
6716         * solib.c: Update.
6717         * sparc64-linux-tdep.c: Update.
6718         * stack.c: Update.
6719         * symfile-mem.c: Update.
6720         * symmisc.c: Update.
6721         * target.c: Update.
6722         * thread.c: Update.
6723         * top.c: Update.
6724         * tracefile-tfile.c: Update.
6725         * tui/tui.c: Update.
6726         * typeprint.c: Update.
6727         * unittests/cli-utils-selftests.c: Update.
6728         * unittests/parse-connection-spec-selftests.c: Update.
6729         * valops.c: Update.
6730         * valprint.c: Update.
6731         * value.c: Update.
6732         * varobj.c: Update.
6733         * windows-nat.c: Update.
6734         * x86-linux-nat.c: Update.
6735         * xml-support.c: Update.
6736
6737 2019-04-08  Tom Tromey  <tom@tromey.com>
6738
6739         * xml-support.c: Use C++ exception handling.
6740         * x86-linux-nat.c: Use C++ exception handling.
6741         * windows-nat.c: Use C++ exception handling.
6742         * varobj.c: Use C++ exception handling.
6743         * value.c: Use C++ exception handling.
6744         * valprint.c: Use C++ exception handling.
6745         * valops.c: Use C++ exception handling.
6746         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6747         handling.
6748         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6749         * typeprint.c: Use C++ exception handling.
6750         * tui/tui.c: Use C++ exception handling.
6751         * tracefile-tfile.c: Use C++ exception handling.
6752         * top.c: Use C++ exception handling.
6753         * thread.c: Use C++ exception handling.
6754         * target.c: Use C++ exception handling.
6755         * symmisc.c: Use C++ exception handling.
6756         * symfile-mem.c: Use C++ exception handling.
6757         * stack.c: Use C++ exception handling.
6758         * sparc64-linux-tdep.c: Use C++ exception handling.
6759         * solib.c: Use C++ exception handling.
6760         * solib-svr4.c: Use C++ exception handling.
6761         * solib-spu.c: Use C++ exception handling.
6762         * solib-frv.c: Use C++ exception handling.
6763         * solib-dsbt.c: Use C++ exception handling.
6764         * selftest-arch.c: Use C++ exception handling.
6765         * s390-tdep.c: Use C++ exception handling.
6766         * rust-lang.c: Use C++ exception handling.
6767         * rust-exp.y: Use C++ exception handling.
6768         * rs6000-tdep.c: Use C++ exception handling.
6769         * rs6000-aix-tdep.c: Use C++ exception handling.
6770         * riscv-tdep.c: Use C++ exception handling.
6771         * remote.c: Use C++ exception handling.
6772         * remote-fileio.c: Use C++ exception handling.
6773         * record-full.c: Use C++ exception handling.
6774         * record-btrace.c: Use C++ exception handling.
6775         * python/python.c: Use C++ exception handling.
6776         * python/py-value.c: Use C++ exception handling.
6777         * python/py-utils.c: Use C++ exception handling.
6778         * python/py-unwind.c: Use C++ exception handling.
6779         * python/py-type.c: Use C++ exception handling.
6780         * python/py-symbol.c: Use C++ exception handling.
6781         * python/py-record.c: Use C++ exception handling.
6782         * python/py-record-btrace.c: Use C++ exception handling.
6783         * python/py-progspace.c: Use C++ exception handling.
6784         * python/py-prettyprint.c: Use C++ exception handling.
6785         * python/py-param.c: Use C++ exception handling.
6786         * python/py-objfile.c: Use C++ exception handling.
6787         * python/py-linetable.c: Use C++ exception handling.
6788         * python/py-lazy-string.c: Use C++ exception handling.
6789         * python/py-infthread.c: Use C++ exception handling.
6790         * python/py-inferior.c: Use C++ exception handling.
6791         * python/py-gdb-readline.c: Use C++ exception handling.
6792         * python/py-framefilter.c: Use C++ exception handling.
6793         * python/py-frame.c: Use C++ exception handling.
6794         * python/py-finishbreakpoint.c: Use C++ exception handling.
6795         * python/py-cmd.c: Use C++ exception handling.
6796         * python/py-breakpoint.c: Use C++ exception handling.
6797         * python/py-arch.c: Use C++ exception handling.
6798         * printcmd.c: Use C++ exception handling.
6799         * ppc-linux-tdep.c: Use C++ exception handling.
6800         * parse.c: Use C++ exception handling.
6801         * p-valprint.c: Use C++ exception handling.
6802         * objc-lang.c: Use C++ exception handling.
6803         * mi/mi-main.c: Use C++ exception handling.
6804         * mi/mi-interp.c: Use C++ exception handling.
6805         * mi/mi-cmd-stack.c: Use C++ exception handling.
6806         * mi/mi-cmd-break.c: Use C++ exception handling.
6807         * main.c: Use C++ exception handling.
6808         * linux-thread-db.c: Use C++ exception handling.
6809         * linux-tdep.c: Use C++ exception handling.
6810         * linux-nat.c: Use C++ exception handling.
6811         * linux-fork.c: Use C++ exception handling.
6812         * linespec.c: Use C++ exception handling.
6813         * language.c: Use C++ exception handling.
6814         * jit.c: Use C++ exception handling.
6815         * infrun.c: Use C++ exception handling.
6816         * infcmd.c: Use C++ exception handling.
6817         * infcall.c: Use C++ exception handling.
6818         * inf-loop.c: Use C++ exception handling.
6819         * i386-tdep.c: Use C++ exception handling.
6820         * i386-linux-tdep.c: Use C++ exception handling.
6821         * guile/scm-value.c: Use C++ exception handling.
6822         * guile/scm-type.c: Use C++ exception handling.
6823         * guile/scm-symtab.c: Use C++ exception handling.
6824         * guile/scm-symbol.c: Use C++ exception handling.
6825         * guile/scm-pretty-print.c: Use C++ exception handling.
6826         * guile/scm-ports.c: Use C++ exception handling.
6827         * guile/scm-param.c: Use C++ exception handling.
6828         * guile/scm-math.c: Use C++ exception handling.
6829         * guile/scm-lazy-string.c: Use C++ exception handling.
6830         * guile/scm-frame.c: Use C++ exception handling.
6831         * guile/scm-disasm.c: Use C++ exception handling.
6832         * guile/scm-cmd.c: Use C++ exception handling.
6833         * guile/scm-breakpoint.c: Use C++ exception handling.
6834         * guile/scm-block.c: Use C++ exception handling.
6835         * guile/guile-internal.h: Use C++ exception handling.
6836         * gnu-v3-abi.c: Use C++ exception handling.
6837         * gdbtypes.c: Use C++ exception handling.
6838         * frame.c: Use C++ exception handling.
6839         * frame-unwind.c: Use C++ exception handling.
6840         * fbsd-tdep.c: Use C++ exception handling.
6841         * f-valprint.c: Use C++ exception handling.
6842         * exec.c: Use C++ exception handling.
6843         * event-top.c: Use C++ exception handling.
6844         * event-loop.c: Use C++ exception handling.
6845         * eval.c: Use C++ exception handling.
6846         * dwarf2read.c: Use C++ exception handling.
6847         * dwarf2loc.c: Use C++ exception handling.
6848         * dwarf2-frame.c: Use C++ exception handling.
6849         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6850         * dwarf-index-write.c: Use C++ exception handling.
6851         * dwarf-index-cache.c: Use C++ exception handling.
6852         * dtrace-probe.c: Use C++ exception handling.
6853         * disasm-selftests.c: Use C++ exception handling.
6854         * darwin-nat.c: Use C++ exception handling.
6855         * cp-valprint.c: Use C++ exception handling.
6856         * cp-support.c: Use C++ exception handling.
6857         * cp-abi.c: Use C++ exception handling.
6858         * corelow.c: Use C++ exception handling.
6859         * completer.c: Use C++ exception handling.
6860         * compile/compile-object-run.c: Use C++ exception handling.
6861         * compile/compile-object-load.c: Use C++ exception handling.
6862         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6863         * compile/compile-c-symbols.c: Use C++ exception handling.
6864         * common/selftest.c: Use C++ exception handling.
6865         * common/new-op.c: Use C++ exception handling.
6866         * cli/cli-script.c: Use C++ exception handling.
6867         * cli/cli-interp.c: Use C++ exception handling.
6868         * cli/cli-cmds.c: Use C++ exception handling.
6869         * c-varobj.c: Use C++ exception handling.
6870         * btrace.c: Use C++ exception handling.
6871         * breakpoint.c: Use C++ exception handling.
6872         * break-catch-throw.c: Use C++ exception handling.
6873         * arch-utils.c: Use C++ exception handling.
6874         * amd64-tdep.c: Use C++ exception handling.
6875         * ada-valprint.c: Use C++ exception handling.
6876         * ada-typeprint.c: Use C++ exception handling.
6877         * ada-lang.c: Use C++ exception handling.
6878         * aarch64-tdep.c: Use C++ exception handling.
6879
6880 2019-04-08  Tom Tromey  <tom@tromey.com>
6881
6882         * xml-support.c (gdb_xml_parser::parse): Update.
6883         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6884         * value.c (show_convenience): Update.
6885         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6886         (test_parse_flags_qcs): Update.
6887         * thread.c (thr_try_catch_cmd): Update.
6888         * target.c (target_translate_tls_address): Update.
6889         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6890         (info_frame_command_core, frame_apply_command_count): Update.
6891         * rust-exp.y (rust_lex_exception_test): Update.
6892         * riscv-tdep.c (riscv_print_one_register_info): Update.
6893         * remote.c (remote_target::enable_btrace): Update.
6894         * record-btrace.c (record_btrace_enable_warn): Update.
6895         * python/py-utils.c (gdbpy_convert_exception): Update.
6896         * printcmd.c (do_one_display, print_variable_and_value): Update.
6897         * mi/mi-main.c (mi_print_exception): Update.
6898         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6899         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6900         * linux-nat.c (linux_nat_target::attach): Update.
6901         * linux-fork.c (class scoped_switch_fork_info): Update.
6902         * infrun.c (displaced_step_prepare): Update.
6903         * infcall.c (call_function_by_hand_dummy): Update.
6904         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6905         * gnu-v3-abi.c (print_one_vtable): Update.
6906         * frame.c (get_prev_frame_always): Update.
6907         * f-valprint.c (info_common_command_for_block): Update.
6908         * exec.c (try_open_exec_file): Update.
6909         * exceptions.c (print_exception, exception_print)
6910         (exception_fprintf, exception_print_same): Update.
6911         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6912         * dwarf-index-cache.c (index_cache::store)
6913         (index_cache::lookup_gdb_index): Update.
6914         * darwin-nat.c (maybe_cache_shell): Update.
6915         * cp-valprint.c (cp_print_value_fields): Update.
6916         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6917         (gcc_cplus_symbol_address): Update.
6918         * compile/compile-c-symbols.c (gcc_convert_symbol)
6919         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6920         * common/selftest.c: Update.
6921         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6922         a std::string.
6923         (exception_try_scope_entry, exception_try_scope_exit): Don't
6924         declare.
6925         (struct exception_try_scope): Remove.
6926         (TRY): Don't use exception_try_scope.
6927         (struct gdb_exception): Add constructor, operator=.
6928         <what>: New method.
6929         (struct gdb_exception_RETURN_MASK_ALL)
6930         (struct gdb_exception_RETURN_MASK_ERROR)
6931         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6932         (struct gdb_quit_bad_alloc): Update.
6933         * common/common-exceptions.c (exception_none): Change
6934         initializer.
6935         (struct catcher) <state, exception>: Initialize inline.
6936         <prev>: Remove member.
6937         (current_catcher): Remove.
6938         (catchers): New global.
6939         (exceptions_state_mc_init): Simplify.
6940         (catcher_pop): Remove.
6941         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6942         (try_scope_depth, exception_try_scope_entry)
6943         (exception_try_scope_exit): Remove.
6944         (throw_exception_sjlj): Update.
6945         (exception_messages, exception_messages_size): Remove.
6946         (throw_it): Simplify.
6947         (gdb_exception_sliced_copy): Remove.
6948         (throw_exception_cxx): Update.
6949         * cli/cli-script.c (script_from_file): Update.
6950         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6951         Update.
6952         * ada-valprint.c (ada_val_print): Update.
6953         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6954         (create_excep_cond_exprs): Update.
6955
6956 2019-04-08  Tom Tromey  <tom@tromey.com>
6957
6958         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6959         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6960         (TRY, CATCH, END_CATCH): Remove some definitions.
6961         * common/common-exceptions.c: Don't use GDB_XCPT.
6962         (catcher_list_size): Remove.
6963         (throw_exception, throw_it): Simplify.
6964
6965 2019-04-05  Tom Tromey  <tom@tromey.com>
6966
6967         Revert the header-sorting patch.
6968         * ft32-tdep.c: Revert.
6969         * frv-tdep.c: Revert.
6970         * frv-linux-tdep.c: Revert.
6971         * frame.c: Revert.
6972         * frame-unwind.c: Revert.
6973         * frame-base.c: Revert.
6974         * fork-child.c: Revert.
6975         * findvar.c: Revert.
6976         * findcmd.c: Revert.
6977         * filesystem.c: Revert.
6978         * filename-seen-cache.h: Revert.
6979         * filename-seen-cache.c: Revert.
6980         * fbsd-tdep.c: Revert.
6981         * fbsd-nat.h: Revert.
6982         * fbsd-nat.c: Revert.
6983         * f-valprint.c: Revert.
6984         * f-typeprint.c: Revert.
6985         * f-lang.c: Revert.
6986         * extension.h: Revert.
6987         * extension.c: Revert.
6988         * extension-priv.h: Revert.
6989         * expprint.c: Revert.
6990         * exec.h: Revert.
6991         * exec.c: Revert.
6992         * exceptions.c: Revert.
6993         * event-top.c: Revert.
6994         * event-loop.c: Revert.
6995         * eval.c: Revert.
6996         * elfread.c: Revert.
6997         * dwarf2read.h: Revert.
6998         * dwarf2read.c: Revert.
6999         * dwarf2loc.c: Revert.
7000         * dwarf2expr.h: Revert.
7001         * dwarf2expr.c: Revert.
7002         * dwarf2-frame.c: Revert.
7003         * dwarf2-frame-tailcall.c: Revert.
7004         * dwarf-index-write.h: Revert.
7005         * dwarf-index-write.c: Revert.
7006         * dwarf-index-common.c: Revert.
7007         * dwarf-index-cache.h: Revert.
7008         * dwarf-index-cache.c: Revert.
7009         * dummy-frame.c: Revert.
7010         * dtrace-probe.c: Revert.
7011         * disasm.h: Revert.
7012         * disasm.c: Revert.
7013         * disasm-selftests.c: Revert.
7014         * dictionary.c: Revert.
7015         * dicos-tdep.c: Revert.
7016         * demangle.c: Revert.
7017         * dcache.h: Revert.
7018         * dcache.c: Revert.
7019         * darwin-nat.h: Revert.
7020         * darwin-nat.c: Revert.
7021         * darwin-nat-info.c: Revert.
7022         * d-valprint.c: Revert.
7023         * d-namespace.c: Revert.
7024         * d-lang.c: Revert.
7025         * ctf.c: Revert.
7026         * csky-tdep.c: Revert.
7027         * csky-linux-tdep.c: Revert.
7028         * cris-tdep.c: Revert.
7029         * cris-linux-tdep.c: Revert.
7030         * cp-valprint.c: Revert.
7031         * cp-support.c: Revert.
7032         * cp-namespace.c: Revert.
7033         * cp-abi.c: Revert.
7034         * corelow.c: Revert.
7035         * corefile.c: Revert.
7036         * continuations.c: Revert.
7037         * completer.h: Revert.
7038         * completer.c: Revert.
7039         * complaints.c: Revert.
7040         * coffread.c: Revert.
7041         * coff-pe-read.c: Revert.
7042         * cli-out.h: Revert.
7043         * cli-out.c: Revert.
7044         * charset.c: Revert.
7045         * c-varobj.c: Revert.
7046         * c-valprint.c: Revert.
7047         * c-typeprint.c: Revert.
7048         * c-lang.c: Revert.
7049         * buildsym.c: Revert.
7050         * buildsym-legacy.c: Revert.
7051         * build-id.h: Revert.
7052         * build-id.c: Revert.
7053         * btrace.c: Revert.
7054         * bsd-uthread.c: Revert.
7055         * breakpoint.h: Revert.
7056         * breakpoint.c: Revert.
7057         * break-catch-throw.c: Revert.
7058         * break-catch-syscall.c: Revert.
7059         * break-catch-sig.c: Revert.
7060         * blockframe.c: Revert.
7061         * block.c: Revert.
7062         * bfin-tdep.c: Revert.
7063         * bfin-linux-tdep.c: Revert.
7064         * bfd-target.c: Revert.
7065         * bcache.c: Revert.
7066         * ax-general.c: Revert.
7067         * ax-gdb.h: Revert.
7068         * ax-gdb.c: Revert.
7069         * avr-tdep.c: Revert.
7070         * auxv.c: Revert.
7071         * auto-load.c: Revert.
7072         * arm-wince-tdep.c: Revert.
7073         * arm-tdep.c: Revert.
7074         * arm-symbian-tdep.c: Revert.
7075         * arm-pikeos-tdep.c: Revert.
7076         * arm-obsd-tdep.c: Revert.
7077         * arm-nbsd-tdep.c: Revert.
7078         * arm-nbsd-nat.c: Revert.
7079         * arm-linux-tdep.c: Revert.
7080         * arm-linux-nat.c: Revert.
7081         * arm-fbsd-tdep.c: Revert.
7082         * arm-fbsd-nat.c: Revert.
7083         * arm-bsd-tdep.c: Revert.
7084         * arch-utils.c: Revert.
7085         * arc-tdep.c: Revert.
7086         * arc-newlib-tdep.c: Revert.
7087         * annotate.h: Revert.
7088         * annotate.c: Revert.
7089         * amd64-windows-tdep.c: Revert.
7090         * amd64-windows-nat.c: Revert.
7091         * amd64-tdep.c: Revert.
7092         * amd64-sol2-tdep.c: Revert.
7093         * amd64-obsd-tdep.c: Revert.
7094         * amd64-obsd-nat.c: Revert.
7095         * amd64-nbsd-tdep.c: Revert.
7096         * amd64-nbsd-nat.c: Revert.
7097         * amd64-nat.c: Revert.
7098         * amd64-linux-tdep.c: Revert.
7099         * amd64-linux-nat.c: Revert.
7100         * amd64-fbsd-tdep.c: Revert.
7101         * amd64-fbsd-nat.c: Revert.
7102         * amd64-dicos-tdep.c: Revert.
7103         * amd64-darwin-tdep.c: Revert.
7104         * amd64-bsd-nat.c: Revert.
7105         * alpha-tdep.c: Revert.
7106         * alpha-obsd-tdep.c: Revert.
7107         * alpha-nbsd-tdep.c: Revert.
7108         * alpha-mdebug-tdep.c: Revert.
7109         * alpha-linux-tdep.c: Revert.
7110         * alpha-linux-nat.c: Revert.
7111         * alpha-bsd-tdep.c: Revert.
7112         * alpha-bsd-nat.c: Revert.
7113         * aix-thread.c: Revert.
7114         * agent.c: Revert.
7115         * addrmap.c: Revert.
7116         * ada-varobj.c: Revert.
7117         * ada-valprint.c: Revert.
7118         * ada-typeprint.c: Revert.
7119         * ada-tasks.c: Revert.
7120         * ada-lang.c: Revert.
7121         * aarch64-tdep.c: Revert.
7122         * aarch64-ravenscar-thread.c: Revert.
7123         * aarch64-newlib-tdep.c: Revert.
7124         * aarch64-linux-tdep.c: Revert.
7125         * aarch64-linux-nat.c: Revert.
7126         * aarch64-fbsd-tdep.c: Revert.
7127         * aarch64-fbsd-nat.c: Revert.
7128         * aarch32-linux-nat.c: Revert.
7129
7130 2019-04-05  Tom Tromey  <tom@tromey.com>
7131
7132         * ft32-tdep.c: Sort headers.
7133         * frv-tdep.c: Sort headers.
7134         * frv-linux-tdep.c: Sort headers.
7135         * frame.c: Sort headers.
7136         * frame-unwind.c: Sort headers.
7137         * frame-base.c: Sort headers.
7138         * fork-child.c: Sort headers.
7139         * findvar.c: Sort headers.
7140         * findcmd.c: Sort headers.
7141         * filesystem.c: Sort headers.
7142         * filename-seen-cache.h: Sort headers.
7143         * filename-seen-cache.c: Sort headers.
7144         * fbsd-tdep.c: Sort headers.
7145         * fbsd-nat.h: Sort headers.
7146         * fbsd-nat.c: Sort headers.
7147         * f-valprint.c: Sort headers.
7148         * f-typeprint.c: Sort headers.
7149         * f-lang.c: Sort headers.
7150         * extension.h: Sort headers.
7151         * extension.c: Sort headers.
7152         * extension-priv.h: Sort headers.
7153         * expprint.c: Sort headers.
7154         * exec.h: Sort headers.
7155         * exec.c: Sort headers.
7156         * exceptions.c: Sort headers.
7157         * event-top.c: Sort headers.
7158         * event-loop.c: Sort headers.
7159         * eval.c: Sort headers.
7160         * elfread.c: Sort headers.
7161         * dwarf2read.h: Sort headers.
7162         * dwarf2read.c: Sort headers.
7163         * dwarf2loc.c: Sort headers.
7164         * dwarf2expr.h: Sort headers.
7165         * dwarf2expr.c: Sort headers.
7166         * dwarf2-frame.c: Sort headers.
7167         * dwarf2-frame-tailcall.c: Sort headers.
7168         * dwarf-index-write.h: Sort headers.
7169         * dwarf-index-write.c: Sort headers.
7170         * dwarf-index-common.c: Sort headers.
7171         * dwarf-index-cache.h: Sort headers.
7172         * dwarf-index-cache.c: Sort headers.
7173         * dummy-frame.c: Sort headers.
7174         * dtrace-probe.c: Sort headers.
7175         * disasm.h: Sort headers.
7176         * disasm.c: Sort headers.
7177         * disasm-selftests.c: Sort headers.
7178         * dictionary.c: Sort headers.
7179         * dicos-tdep.c: Sort headers.
7180         * demangle.c: Sort headers.
7181         * dcache.h: Sort headers.
7182         * dcache.c: Sort headers.
7183         * darwin-nat.h: Sort headers.
7184         * darwin-nat.c: Sort headers.
7185         * darwin-nat-info.c: Sort headers.
7186         * d-valprint.c: Sort headers.
7187         * d-namespace.c: Sort headers.
7188         * d-lang.c: Sort headers.
7189         * ctf.c: Sort headers.
7190         * csky-tdep.c: Sort headers.
7191         * csky-linux-tdep.c: Sort headers.
7192         * cris-tdep.c: Sort headers.
7193         * cris-linux-tdep.c: Sort headers.
7194         * cp-valprint.c: Sort headers.
7195         * cp-support.c: Sort headers.
7196         * cp-namespace.c: Sort headers.
7197         * cp-abi.c: Sort headers.
7198         * corelow.c: Sort headers.
7199         * corefile.c: Sort headers.
7200         * continuations.c: Sort headers.
7201         * completer.h: Sort headers.
7202         * completer.c: Sort headers.
7203         * complaints.c: Sort headers.
7204         * coffread.c: Sort headers.
7205         * coff-pe-read.c: Sort headers.
7206         * cli-out.h: Sort headers.
7207         * cli-out.c: Sort headers.
7208         * charset.c: Sort headers.
7209         * c-varobj.c: Sort headers.
7210         * c-valprint.c: Sort headers.
7211         * c-typeprint.c: Sort headers.
7212         * c-lang.c: Sort headers.
7213         * buildsym.c: Sort headers.
7214         * buildsym-legacy.c: Sort headers.
7215         * build-id.h: Sort headers.
7216         * build-id.c: Sort headers.
7217         * btrace.c: Sort headers.
7218         * bsd-uthread.c: Sort headers.
7219         * breakpoint.h: Sort headers.
7220         * breakpoint.c: Sort headers.
7221         * break-catch-throw.c: Sort headers.
7222         * break-catch-syscall.c: Sort headers.
7223         * break-catch-sig.c: Sort headers.
7224         * blockframe.c: Sort headers.
7225         * block.c: Sort headers.
7226         * bfin-tdep.c: Sort headers.
7227         * bfin-linux-tdep.c: Sort headers.
7228         * bfd-target.c: Sort headers.
7229         * bcache.c: Sort headers.
7230         * ax-general.c: Sort headers.
7231         * ax-gdb.h: Sort headers.
7232         * ax-gdb.c: Sort headers.
7233         * avr-tdep.c: Sort headers.
7234         * auxv.c: Sort headers.
7235         * auto-load.c: Sort headers.
7236         * arm-wince-tdep.c: Sort headers.
7237         * arm-tdep.c: Sort headers.
7238         * arm-symbian-tdep.c: Sort headers.
7239         * arm-pikeos-tdep.c: Sort headers.
7240         * arm-obsd-tdep.c: Sort headers.
7241         * arm-nbsd-tdep.c: Sort headers.
7242         * arm-nbsd-nat.c: Sort headers.
7243         * arm-linux-tdep.c: Sort headers.
7244         * arm-linux-nat.c: Sort headers.
7245         * arm-fbsd-tdep.c: Sort headers.
7246         * arm-fbsd-nat.c: Sort headers.
7247         * arm-bsd-tdep.c: Sort headers.
7248         * arch-utils.c: Sort headers.
7249         * arc-tdep.c: Sort headers.
7250         * arc-newlib-tdep.c: Sort headers.
7251         * annotate.h: Sort headers.
7252         * annotate.c: Sort headers.
7253         * amd64-windows-tdep.c: Sort headers.
7254         * amd64-windows-nat.c: Sort headers.
7255         * amd64-tdep.c: Sort headers.
7256         * amd64-sol2-tdep.c: Sort headers.
7257         * amd64-obsd-tdep.c: Sort headers.
7258         * amd64-obsd-nat.c: Sort headers.
7259         * amd64-nbsd-tdep.c: Sort headers.
7260         * amd64-nbsd-nat.c: Sort headers.
7261         * amd64-nat.c: Sort headers.
7262         * amd64-linux-tdep.c: Sort headers.
7263         * amd64-linux-nat.c: Sort headers.
7264         * amd64-fbsd-tdep.c: Sort headers.
7265         * amd64-fbsd-nat.c: Sort headers.
7266         * amd64-dicos-tdep.c: Sort headers.
7267         * amd64-darwin-tdep.c: Sort headers.
7268         * amd64-bsd-nat.c: Sort headers.
7269         * alpha-tdep.c: Sort headers.
7270         * alpha-obsd-tdep.c: Sort headers.
7271         * alpha-nbsd-tdep.c: Sort headers.
7272         * alpha-mdebug-tdep.c: Sort headers.
7273         * alpha-linux-tdep.c: Sort headers.
7274         * alpha-linux-nat.c: Sort headers.
7275         * alpha-bsd-tdep.c: Sort headers.
7276         * alpha-bsd-nat.c: Sort headers.
7277         * aix-thread.c: Sort headers.
7278         * agent.c: Sort headers.
7279         * addrmap.c: Sort headers.
7280         * ada-varobj.c: Sort headers.
7281         * ada-valprint.c: Sort headers.
7282         * ada-typeprint.c: Sort headers.
7283         * ada-tasks.c: Sort headers.
7284         * ada-lang.c: Sort headers.
7285         * aarch64-tdep.c: Sort headers.
7286         * aarch64-ravenscar-thread.c: Sort headers.
7287         * aarch64-newlib-tdep.c: Sort headers.
7288         * aarch64-linux-tdep.c: Sort headers.
7289         * aarch64-linux-nat.c: Sort headers.
7290         * aarch64-fbsd-tdep.c: Sort headers.
7291         * aarch64-fbsd-nat.c: Sort headers.
7292         * aarch32-linux-nat.c: Sort headers.
7293
7294 2019-04-04  Tom Tromey  <tom@tromey.com>
7295
7296         * varobj.c (varobj_create): Update.
7297         * rust-exp.y (struct rust_parser) <update_innermost_block,
7298         lookup_symbol>: New methods.
7299         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7300         Rename.
7301         (rust_parser::rust_lookup_type)
7302         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7303         * printcmd.c (display_command, do_one_display): Update.
7304         * parser-defs.h (struct parser_state) <parser_state>: Add
7305         "tracker" parameter.
7306         (block_tracker): New member.
7307         (class innermost_block_tracker) <innermost_block_tracker>: Add
7308         "types" parameter.
7309         <reset>: Remove method.
7310         (innermost_block): Don't declare.
7311         (null_post_parser): Update.
7312         * parse.c (innermost_block): Remove global.
7313         (write_dollar_variable): Update.
7314         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7315         Remove "tracker_types" parameter.
7316         (parse_expression): Add "tracker" parameter.
7317         (parse_expression_for_completion): Update.
7318         (null_post_parser): Add "tracker" parameter.
7319         * p-exp.y: Update rules.
7320         * m2-exp.y: Update rules.
7321         * language.h (struct language_defn) <la_post_parser>: Add
7322         "tracker" parameter.
7323         * go-exp.y: Update rules.
7324         * f-exp.y: Update rules.
7325         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7326         parameter.
7327         * d-exp.y: Update rules.
7328         * c-exp.y: Update rules.
7329         * breakpoint.c (set_breakpoint_condition): Create an
7330         innermost_block_tracker.
7331         (watch_command_1): Likewise.
7332         * ada-lang.c (resolve): Add "tracker" parameter.
7333         (resolve_subexp): Likewise.
7334         * ada-exp.y (write_var_from_sym): Update.
7335
7336 2019-04-04  Tom Tromey  <tom@tromey.com>
7337
7338         * type-stack.h: New file.
7339         * type-stack.c: New file.
7340         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7341         type-stack.h.
7342         (insert_into_type_stack, insert_type, push_type, push_type_int)
7343         (insert_type_address_space, pop_type, pop_type_int)
7344         (pop_typelist, pop_type_stack, append_type_stack)
7345         (push_type_stack, get_type_stack, push_typelist)
7346         (follow_type_instance_flags, follow_types): Don't declare.
7347         * parse.c (type_stack): Remove global.
7348         (parse_exp_in_context): Update.
7349         (insert_into_type_stack, insert_type, push_type, push_type_int)
7350         (insert_type_address_space, pop_type, pop_type_int)
7351         (pop_typelist, pop_type_stack, append_type_stack)
7352         (push_type_stack, get_type_stack, push_typelist)
7353         (follow_type_instance_flags, follow_types): Remove (moved to
7354         type-stack.c).
7355         * f-exp.y (type_stack): New global.
7356         Update rules.
7357         (push_kind_type, f_parse): Update.
7358         * d-exp.y (type_stack): New global.
7359         Update rules.
7360         (d_parse): Update.
7361         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7362         Update rules.
7363         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7364         (HFILES_NO_SRCDIR): Add type-stack.h.
7365
7366 2019-04-04  Tom Tromey  <tom@tromey.com>
7367
7368         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7369         (rust_parser::convert_ast_to_expression, rust_parse)
7370         (rust_lex_test_completion, rust_lex_tests): Update.
7371         * parser-defs.h (struct expr_completion_state): New.
7372         (struct parser_state) <parser_state>: Add completion parameter.
7373         <mark_struct_expression, mark_completion_tag>: New methods.
7374         <parse_completion, m_completion_state>: New members.
7375         (prefixify_expression, null_post_parser): Update.
7376         (mark_struct_expression, mark_completion_tag): Don't declare.
7377         * parse.c (parse_completion, expout_last_struct)
7378         (expout_tag_completion_type, expout_completion_name): Remove
7379         globals.
7380         (parser_state::mark_struct_expression)
7381         (parser_state::mark_completion_tag): Now methods.
7382         (prefixify_expression): Add last_struct parameter.
7383         (prefixify_subexp): Likewise.
7384         (parse_exp_1): Update.
7385         (parse_exp_in_context): Add cstate parameter.  Update.
7386         (parse_expression_for_completion): Create an
7387         expr_completion_state.
7388         (null_post_parser): Add "completion" parameter.
7389         * p-exp.y: Update rules.
7390         (yylex): Update.
7391         * language.h (struct language_defn) <la_post_parser>: Add
7392         "completing" parameter.
7393         * go-exp.y: Update rules.
7394         (lex_one_token): Update.
7395         * expression.h (parse_completion): Don't declare.
7396         * d-exp.y: Update rules.
7397         (lex_one_token): Update rules.
7398         * c-exp.y: Update rules.
7399         (lex_one_token): Update.
7400         * ada-lang.c (resolve): Add "parse_completion" parameter.
7401         (resolve_subexp): Likewise.
7402         (ada_resolve_function): Likewise.
7403
7404 2019-04-04  Tom Tromey  <tom@tromey.com>
7405
7406         * parser-defs.h (struct parser_state) <start_arglist,
7407         end_arglist>: New methods.
7408         <arglist_len, m_funcall_chain>: New members.
7409         (arglist_len, start_arglist, end_arglist): Don't declare.
7410         * parse.c (arglist_len, funcall_chain): Remove global.
7411         (start_arglist, end_arglist): Remove functions.
7412         (parse_exp_in_context): Update.
7413         * p-exp.y: Update rules.
7414         * m2-exp.y: Update rules.
7415         * go-exp.y: Update rules.
7416         * f-exp.y: Update rules.
7417         * d-exp.y: Update rules.
7418         * c-exp.y: Update rules.
7419
7420 2019-04-04  Tom Tromey  <tom@tromey.com>
7421
7422         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7423         lex_operator, push_back>: New methods.
7424         Update all rules.
7425         (rust_parser::lex_hex, lex_escape): Rename and update.
7426         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7427         (rust_parser::lex_operator): Rename and update.
7428         (rust_parser::lex_number, rustyylex, rustyyerror)
7429         (rust_lex_test_init, rust_lex_test_sequence)
7430         (rust_lex_test_push_back, rust_lex_tests): Update.
7431         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7432         parameter.
7433         <lexptr, prev_lexptr>: New members.
7434         (lexptr, prev_lexptr): Don't declare.
7435         * parse.c (lexptr, prev_lexptr): Remove globals.
7436         (parse_exp_in_context): Update.
7437         * p-exp.y (yylex, yyerror): Update.
7438         * m2-exp.y (parse_number, yylex, yyerror): Update.
7439         * go-exp.y (lex_one_token, yyerror): Update.
7440         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7441         * d-exp.y (lex_one_token, yyerror): Update.
7442         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7443         (lex_one_token, yyerror): Update.
7444         * ada-lex.l (YY_INPUT): Update.
7445         (rewind_to_char): Update.
7446         * ada-exp.y (yyerror): Update.
7447
7448 2019-04-04  Tom Tromey  <tom@tromey.com>
7449
7450         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7451         * parser-defs.h (struct parser_state) <parser_state>: Add new
7452         parameter.
7453         <comma_terminates>: New member.
7454         (comma_terminates): Don't declare global.
7455         * parse.c (comma_terminates): Remove global.
7456         (parse_exp_in_context): Update.
7457         * p-exp.y (yylex): Update.
7458         * m2-exp.y (yylex): Update.
7459         * go-exp.y (lex_one_token): Update.
7460         * f-exp.y (yylex): Update.
7461         * d-exp.y (lex_one_token): Update.
7462         * c-exp.y (lex_one_token): Update.
7463         * ada-lex.l: Update.
7464
7465 2019-04-04  Tom Tromey  <tom@tromey.com>
7466
7467         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7468         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7469         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7470         * parser-defs.h (paren_depth): Don't declare.
7471         * parse.c (paren_depth): Remove global.
7472         (parse_exp_in_context): Update.
7473         * p-exp.y (paren_depth): New global.
7474         (pascal_parse): Initialize it.
7475         * m2-exp.y (paren_depth): New global.
7476         (m2_parse): Initialize it.
7477         * go-exp.y (paren_depth): New global.
7478         (go_parse): Initialize it.
7479         * f-exp.y (paren_depth): New global.
7480         (f_parse): Initialize it.
7481         * d-exp.y (paren_depth): New global.
7482         (d_parse): Initialize it.
7483         * c-exp.y (paren_depth): New global.
7484         (c_parse): Initialize it.
7485         * ada-lex.l (paren_depth): New global.
7486         (lexer_init): Initialize it.
7487
7488 2019-04-04  Tom Tromey  <tom@tromey.com>
7489
7490         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7491         (rust_parser::convert_ast_to_type)
7492         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7493         * parser-defs.h (struct parser_state) <parser_state>: Add
7494         parameters.  Initialize new members.
7495         <expression_context_block, expression_context_pc>: New members.
7496         * parse.c (expression_context_block, expression_context_pc):
7497         Remove globals.
7498         (parse_exp_in_context): Update.
7499         * p-exp.y: Update all rules.
7500         (yylex): Update.
7501         * m2-exp.y: Update all rules.
7502         (yylex): Update.
7503         * go-exp.y (yylex): Update.
7504         * f-exp.y (yylex): Update.
7505         * d-exp.y: Update all rules.
7506         (yylex): Update.
7507         * c-exp.y: Update all rules.
7508         (lex_one_token, classify_name, yylex, c_parse): Update.
7509         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7510
7511 2019-04-04  Tom Tromey  <tom@tromey.com>
7512
7513         * gdbarch.h, gdbarch.c: Rebuild.
7514         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7515         * stap-probe.h:
7516         (struct stap_parse_info): Replace "parser_state" with
7517         "expr_builder".
7518         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7519         (parser_state): New class.
7520         * parse.c (expr_builder): Rename.
7521         (expr_builder::release): Rename.
7522         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7523         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7524         (write_exp_elt_longcst, write_exp_elt_floatcst)
7525         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7526         (write_exp_string_vector, write_exp_bitstring)
7527         (write_exp_msymbol, mark_struct_expression)
7528         (write_dollar_variable)
7529         (insert_type_address_space, increase_expout_size): Replace
7530         "parser_state" with "expr_builder".
7531         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7532         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7533         "parser_state" with "expr_builder".
7534
7535 2019-04-04  Tom Tromey  <tom@tromey.com>
7536
7537         * rust-exp.y: Replace "parse_language" with method call.
7538         * p-exp.y:
7539         (yylex): Replace "parse_language" with method call.
7540         * m2-exp.y:
7541         (yylex): Replace "parse_language" with method call.
7542         * go-exp.y (classify_name): Replace "parse_language" with method
7543         call.
7544         * f-exp.y (yylex): Replace "parse_language" with method call.
7545         * d-exp.y (lex_one_token): Replace "parse_language" with method
7546         call.
7547         * c-exp.y:
7548         (lex_one_token, classify_name, yylex): Replace "parse_language"
7549         with method call.
7550         * ada-exp.y (find_primitive_type, type_char)
7551         (type_system_address): Replace "parse_language" with method call.
7552
7553 2019-04-04  Tom Tromey  <tom@tromey.com>
7554
7555         * rust-exp.y: Replace "parse_gdbarch" with method call.
7556         * parse.c (write_dollar_variable, insert_type_address_space):
7557         Replace "parse_gdbarch" with method call.
7558         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7559         call.
7560         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7561         call.
7562         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7563         "parse_gdbarch" with method call.
7564         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7565         with method call.
7566         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7567         "parse_gdbarch" with method call.
7568         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7569         "parse_gdbarch" with method call.
7570         * c-exp.y (parse_type, parse_number, classify_name): Replace
7571         "parse_gdbarch" with method call.
7572         * ada-lex.l: Replace "parse_gdbarch" with method call.
7573         * ada-exp.y (parse_type, find_primitive_type, type_char)
7574         (type_system_address): Replace "parse_gdbarch" with method call.
7575
7576 2019-04-04  Tom Tromey  <tom@tromey.com>
7577
7578         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7579         * stap-probe.c (stap_parse_argument): Update.
7580         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7581         initial_size parameter.
7582         * rust-exp.y (rust_lex_tests): Update.
7583         * parse.c (parser_state): Update.
7584         (parse_exp_in_context): Update.
7585         * parser-defs.h (struct parser_state) <parser_state>: Remove
7586         "initial_size" parameter.
7587
7588 2019-04-04  Tom Tromey  <tom@tromey.com>
7589
7590         * parser-defs.h (increase_expout_size): Don't declare.
7591         * parse.c (increase_expout_size): Now static.
7592
7593 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7594
7595         * gnu-nat.c (gnu_nat_target::wait): Fix
7596         target_waitstatus_to_string call.
7597
7598 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7599
7600         * eval.c (evaluate_subexp_standard): Handle internal functions
7601         during Fortran function call handling.
7602
7603 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7604
7605         * NEWS: Mention new internal functions.
7606         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7607         (read_base_type): Use dwarf2_init_complex_target_type.
7608         * value.c (creal_internal_fn): New function.
7609         (cimag_internal_fn): New function.
7610         (_initialize_values): Register new internal functions.
7611
7612 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7613
7614         * infrun.c (stop_all_threads): If debug_infrun, always
7615         trace the wait status after wait_one, using
7616         target_waitstatus_to_string and target_pid_to_str.
7617         (handle_inferior_event): Replace various trace of
7618         wait status kind by a single trace.
7619         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7620         wait status kind image by target_waitstatus_to_string.
7621         * target/waitstatus.c (target_waitstatus_to_string): Fix
7622         obsolete comment.
7623
7624 2019-04-01  Tom Tromey  <tromey@adacore.com>
7625
7626         PR symtab/23331:
7627         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7628
7629 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7630             Pedro Alves  <palves@redhat.com>
7631
7632         * top.c (quit_force): Call 'finalize_values'.
7633         * value.c (finalize_values): New function.
7634         * value.h (finalize_values): Declare.
7635
7636 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7637
7638         * NEWS: Announce $_gdb_major and $_gdb_minor.
7639
7640         * top.c (init_gdb_version_vars): New function.
7641         (gdb_init): Call init_gdb_version_vars.
7642
7643 2019-03-29  Tom Tromey  <tromey@adacore.com>
7644
7645         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7646         help text.  Remove dead code.
7647
7648 2019-03-29  Keith Seitz  <keiths@redhat.com>
7649
7650         From Siddhesh Poyarekar:
7651         * f-lang.h (f77_get_upperbound): Return LONGEST.
7652         (f77_get_lowerbound): Likewise.
7653         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7654         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7655         print them.
7656         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7657         plongest to format print it.
7658         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7659         (f77_get_upperbound): Likewise.
7660         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7661         LOWER_BOUND to LONGEST.
7662         (f77_create_arrayprint_offset_tbl): Likewise.
7663
7664 2019-03-29  Keith Seitz  <keiths@redhat.com>
7665
7666         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7667         %s/pulongest for TYPE_LENGTH instead of %d in format
7668         strings.
7669         * ada-typerint.c (ada_print_type): Likewise.
7670         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7671         * compile/compile-c-support.c (generate_register_struct): Likewise.
7672         * gdbtypes.c (recursive_dump_type): Likewise.
7673         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7674         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7675         instead of %d in format strings.
7676         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7677         to std::min to ULONGEST.
7678         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7679         instead of %d in format strings.
7680         * tracepoint.c (info_scope_command): Likewise.
7681         * typeprint.c (print_offset_data::update)
7682         (print_offset_data::finish): Likewise.
7683         * xtensa-tdep.c (xtensa_store_return_value)
7684         (xtensa_push_dummy_call): Likewise.
7685
7686 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7687
7688         * windows-nat.c (display_selector): Fixed format specifications
7689         for 64-bit Cygwin.
7690
7691 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7692
7693         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7694
7695 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7696
7697         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7698         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7699         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7700         (nios2_linux_init_abi): Install it.
7701
7702 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7703
7704         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7705
7706 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7707
7708         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7709
7710 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7711             Tom Tromey  <tromey@adacore.com>
7712
7713         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7714
7715 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7716
7717         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7718         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7719         method to compute the bounds of range types. Also print "[evaluated]"
7720         if the bounds' values come from a dynamic evaluation.
7721
7722 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7723
7724         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7725         whitespace when pretty printing is on.
7726
7727 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7728
7729         * ppc-linux-nat.c: Add include.
7730
7731 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7732
7733         * NEWS: Mention AArch64 Pointer Authentication.
7734
7735 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7736
7737         * arm-linux-nat.c: Add include.
7738
7739 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7740
7741         * source-cache.c (source_cache::get_source_lines): Re-read
7742         fullname after calling open_source_file.
7743
7744 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7745
7746         * NEWS: Mention TLS support for FreeBSD.
7747
7748 2019-03-25  Tom Tromey  <tromey@adacore.com>
7749
7750         * minsyms.c (BUNCH_SIZE): Update comment.
7751         (~minimal_symbol_reader): Remove old comment.
7752         (compact_minimal_symbols): Update comment.
7753         (minimal_symbol_reader::install): Remove old comment.  Update
7754         other comments.
7755
7756 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7757
7758         * s390-linux-nat.c: Add include.
7759
7760 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7761
7762         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7763         Call linux_get_hwcap.
7764         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7765         Likewise.
7766         (aarch64_linux_get_hwcap): Remove function.
7767         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7768         declaration.
7769         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7770         linux_get_hwcap.
7771         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7772         * linux-tdep.c (linux_get_hwcap): Add function.
7773         (linux_get_hwcap2): Likewise.
7774         * linux-tdep.h (linux_get_hwcap): Add declaration.
7775         (linux_get_hwcap2): Likewise.
7776         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7777         (ppc_linux_get_hwcap2): Likewise.
7778         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7779         linux_get_hwcap.
7780         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7781         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7782         (ppc_linux_nat_target::read_description): Likewise.
7783         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7784         * s390-linux-nat.c: Likewise.
7785         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7786
7787 2019-03-24  Tom Tromey  <tom@tromey.com>
7788
7789         * ada-lang.c (standard_lookup): Simplify initialization.
7790         (ada_lookup_symbol_nonlocal): Simplify return.
7791         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7792         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7793         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7794         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7795         initialization.
7796         * solib.c (solib_global_lookup): Simplify.
7797         * symtab.c (null_block_symbol): Remove.
7798         (symbol_cache_lookup): Simplify returns.
7799         (lookup_language_this): Simplify returns.
7800         (lookup_symbol_aux): Simplify return.
7801         (lookup_local_symbol): Simplify returns.
7802         (lookup_global_symbol_from_objfile): Simplify return.
7803         (lookup_symbol_in_objfile_symtabs)
7804         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7805         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7806         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7807         * cp-namespace.c (cp_lookup_bare_symbol)
7808         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7809         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7810         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7811         (cp_lookup_symbol_via_imports): Simplify initialization.
7812         (find_symbol_in_baseclass): Likewise.
7813         * symtab.h (null_block_symbol): Remove.
7814         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7815         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7816         (d_lookup_symbol_module): Likewise.
7817         (find_symbol_in_baseclass): Simplify initialization.
7818
7819 2019-03-24  Tom Tromey  <tom@tromey.com>
7820
7821         * expression.h: Don't include symtab.h.
7822         (struct block): Forward declare.
7823
7824 2019-03-24  Tom Tromey  <tom@tromey.com>
7825
7826         * c-exp.y (typebase): Remove casts.
7827         * gdbtypes.c (lookup_unsigned_typename, )
7828         (lookup_signed_typename): Remove cast.
7829         * eval.c (parse_to_comma_and_eval): Remove cast.
7830         * parse.c (write_dollar_variable): Remove cast.
7831         * block.h (struct block) <superblock>: Now const.
7832         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7833         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7834         (map_block): Make "block" const.
7835         * symfile.h (struct quick_symbol_functions)
7836         <map_matching_symbols>: Constify block argument to "callback".
7837         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7838         const.
7839         (find_pc_sect_compunit_symtab): Make "b" const.
7840         (find_symbol_at_address): Likewise.
7841         (search_symbols): Likewise.
7842         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7843         (dw2_debug_names_lookup_symbol): Likewise.
7844         (dw2_map_matching_symbols): Update.
7845         * p-valprint.c (pascal_val_print): Remove "block".
7846         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7847         (aux_add_nonlocal_symbols): Make "block" const.
7848         (resolve_subexp): Remove cast.
7849         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7850         const.
7851         (iterate_over_file_blocks): Likewise.
7852         * f-exp.y (%union) <bval>: Remove.
7853         * coffread.c (patch_opaque_types): Make "b" const.
7854         * spu-tdep.c (spu_catch_start): Make "block" const.
7855         * c-valprint.c (print_unpacked_pointer): Remove "block".
7856         * symmisc.c (dump_symtab_1): Make "b" const.
7857         (block_depth): Make "block" const.
7858         * d-exp.y (%union) <bval>: Remove.
7859         * cp-support.h (cp_lookup_rtti_type): Update.
7860         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7861         * psymtab.c (psym_lookup_symbol): Make "block" const.
7862         (maintenance_check_psymtabs): Make "b" const.
7863         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7864         (enumerate_locals, enumerate_args): Update.
7865         * python/py-symtab.c (stpy_global_block): Make "block" const.
7866         (stpy_static_block): Likewise.
7867         * inline-frame.c (block_starting_point_at): Make "new_block"
7868         const.
7869         * block.c (find_block_in_blockvector): Make return type const.
7870         (blockvector_for_pc_sect): Make "b" const.
7871         (find_block_in_blockvector): Make "b" const.
7872
7873 2019-03-23  Tom Tromey  <tom@tromey.com>
7874
7875         * varobj.c (varobj_create): Update.
7876         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7877         * printcmd.c (display_command, do_one_display): Don't reset
7878         innermost_block.
7879         * parser-defs.h (enum innermost_block_tracker_type): Move to
7880         expression.h.
7881         (innermost_block): Update comment.
7882         * parse.c (parse_exp_1): Add tracker_types parameter.
7883         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7884         tracker_types parameter.  Reset innermost_block.
7885         (parse_exp_in_context): Remove.
7886         (parse_expression_for_completion): Update.
7887         * objfiles.c (~objfile): Don't reset expression_context_block or
7888         innermost_block.
7889         * expression.h (enum innermost_block_tracker_type): Move from
7890         parser-defs.h.
7891         (parse_exp_1): Add tracker_types parameter.
7892         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7893         reset innermost_block.
7894
7895 2019-03-23  Tom Tromey  <tom@tromey.com>
7896
7897         * objfiles.h: Include bcache.h.
7898
7899 2019-03-23  Tom Tromey  <tom@tromey.com>
7900
7901         * linespec.c (get_current_search_block): Use
7902         scoped_restore_current_language.
7903         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7904
7905 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7906             Jiong Wang  <jiong.wang@arm.com>
7907
7908         * aarch64-linux-tdep.c
7909         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7910         section.
7911         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7912
7913 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7914             Jiong Wang  <jiong.wang@arm.com>
7915
7916         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7917         instructions.
7918         (aarch64_analyze_prologue_test): Add PACIASP test.
7919         (aarch64_prologue_prev_register): Unmask PC value.
7920
7921 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7922             Jiong Wang  <jiong.wang@arm.com>
7923
7924         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7925         (aarch64_dwarf2_prev_register): Unmask PC value.
7926         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7927         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7928         DW_CFA_AARCH64_negate_ra_state.
7929         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7930
7931 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7932             Jiong Wang  <jiong.wang@arm.com>
7933
7934         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7935         registers.
7936         (aarch64_pseudo_register_name): Likewise.
7937         (aarch64_pseudo_register_type): Likewise.
7938         (aarch64_pseudo_register_reggroup_p): Likewise.
7939         (aarch64_gdbarch_init): Add pauth registers.
7940         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7941         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7942         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7943         (struct gdbarch_tdep): Add regnum for ra_state.
7944
7945 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7946             Jiong Wang  <jiong.wang@arm.com>
7947
7948         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7949
7950 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7951             Jiong Wang  <jiong.wang@arm.com>
7952
7953         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7954         function.
7955         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7956         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7957         (aarch64_gdbarch_init): Add puth registers.
7958         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7959         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7960         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7961
7962 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7963             Jiong Wang  <jiong.wang@arm.com>
7964
7965         * aarch64-linux-nat.c
7966         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7967         * aarch64-linux-tdep.c
7968         (aarch64_linux_core_read_description): Likewise.
7969         (aarch64_linux_get_hwcap): New function.
7970         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7971         (aarch64_linux_get_hwcap): New declaration.
7972
7973 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7974             Jiong Wang  <jiong.wang@arm.com>
7975
7976         * aarch64-linux-nat.c
7977         (aarch64_linux_nat_target::read_description): Add pauth param.
7978         * aarch64-linux-tdep.c
7979         (aarch64_linux_core_read_description): Likewise.
7980         * aarch64-tdep.c (struct target_desc): Add in pauth.
7981         (aarch64_read_description): Add pauth param.
7982         (aarch64_gdbarch_init): Likewise.
7983         * aarch64-tdep.h (aarch64_read_description): Likewise.
7984         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7985         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7986         * features/Makefile: Add new files.
7987         * features/aarch64-pauth.c: New file.
7988         * features/aarch64-pauth.xml: New file.
7989
7990 2019-03-20  Tom Tromey  <tromey@adacore.com>
7991
7992         * infrun.c (handle_inferior_event): Rename from
7993         handle_inferior_event_1.  Create a scoped_value_mark.
7994         (handle_inferior_event): Remove.
7995
7996 2019-03-19  Tom Tromey  <tromey@adacore.com>
7997
7998         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7999         * infrun.h (print_stop_event): Add "displays" parameter.
8000         * infrun.c (print_stop_event): Add "displays" parameter.
8001
8002 2019-03-19  Pedro Alves  <palves@redhat.com>
8003
8004         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8005         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8006         to -1.  Fix TABs vs spaces.
8007         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8008         * tui/tui-out.h (tui_ui_out) Add intro comments.
8009         <m_line, m_start_of_line>: In-class initialize, and add describing
8010         comment.
8011
8012 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8013
8014         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8015         variable names.
8016         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8017
8018 2019-03-18  Pedro Alves  <palves@redhat.com>
8019             Eli Zaretskii <eliz@gnu.org>
8020
8021         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8022         m_line and m_start_of_line.
8023
8024 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8025
8026         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8027         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8028         it returns a newline.  This fixes a regression in TU mode, whereby
8029         the next line is output on the same screen line as the user input.
8030
8031 2019-03-18  Tom Tromey  <tromey@adacore.com>
8032
8033         * minsyms.c (minimal_symbol_reader::install): Remove call to
8034         obstack_blank.
8035
8036 2019-03-18  Pedro Alves  <palves@redhat.com>
8037
8038         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8039         New globals.
8040         (apply_style): New, factored out from ...
8041         (apply_ansi_escape): ... this.  Handle reverse video mode.
8042         (tui_set_reverse_mode): New function.
8043         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8044         * tui/tui-winsource.c (tui_show_source_line): Use
8045         tui_set_reverse_mode instead of setting A_STANDOUT.
8046         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8047         New setter methods.
8048
8049 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8050
8051         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8052         Handle tabs.
8053
8054 2019-03-18  Tom Tromey  <tromey@adacore.com>
8055
8056         * ada-lang.c (empty_array): Add "high" parameter.
8057         (ada_evaluate_subexp): Update.
8058
8059 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8060
8061         * unittests/string_view-selftests.c: Define
8062         _initialize_string_view_selftests unconditionally.
8063
8064 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8065
8066         PR gdb/24350
8067         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8068
8069 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8070
8071         PR gdb/24351
8072         * windows-nat.c (display_selector): Fix format specifiers.
8073
8074 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8075
8076         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8077         tui_refill_source_window instead of tui_refresh_win, to update the
8078         current execution line.  This fixes redisplay of the current line
8079         when stepping through the code with "next" or "step".
8080
8081 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8082
8083         * source-cache.c (source_cache::get_source_lines): Call
8084         find_source_lines to initialize s->nlines.  This fixes vertical
8085         scrolling of TUI source window when the DOWN arrow is pressed.
8086
8087 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8088
8089         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8090         linux-thread-db.c (_initialize_thread_db): Likewise.
8091
8092 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8093
8094         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8095         wclrtoeol in tui_show_source_line".  This reverts changes made in
8096         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8097
8098 2019-03-15  Tom Tromey  <tom@tromey.com>
8099
8100         * symtab.h (struct minimal_symbol): Derive from
8101         general_symbol_info.
8102         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8103         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8104         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8105         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8106         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8107         (MSYMBOL_SEARCH_NAME): Update.
8108         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8109         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8110         * minsyms.c (minimal_symbol_reader::record_full): Update.
8111
8112 2019-03-15  Tom Tromey  <tom@tromey.com>
8113
8114         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8115
8116 2019-03-15  Tom Tromey  <tom@tromey.com>
8117
8118         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8119         unique_xmalloc_ptr.
8120         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8121         Update.
8122         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8123         (build_minimal_symbol_hash_tables)
8124         (minimal_symbol_reader::install): Update.
8125
8126 2019-03-15  Tom Tromey  <tom@tromey.com>
8127
8128         * symtab.c (create_demangled_names_hash): Update.
8129         (symbol_set_names): Update.
8130         * objfiles.h (struct objfile_per_bfd_storage)
8131         <demangled_names_hash>: Now an htab_up.
8132         * objfiles.c (objfile_per_bfd_storage): Simplify.
8133
8134 2019-03-15  Tom Tromey  <tom@tromey.com>
8135
8136         * objfiles.h (struct objfile_per_bfd_storage): Declare
8137         destructor.
8138         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8139         New.
8140         (get_objfile_bfd_data): Use new.  Don't initialize
8141         language_of_main.
8142         (free_objfile_per_bfd_storage): Remove.
8143         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8144
8145 2019-03-15  Tom Tromey  <tom@tromey.com>
8146
8147         * symfile.c (reread_symbols): Update.
8148         * objfiles.c (objfile::objfile): Update.
8149         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8150         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8151         comment.
8152         (minimal_symbol_reader::install): Update.
8153         (terminate_minimal_symbol_table): Remove.
8154         * jit.c (jit_object_close_impl): Update.
8155
8156 2019-03-15  Tom Tromey  <tom@tromey.com>
8157
8158         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8159         initializations.
8160
8161 2019-03-15  Tom Tromey  <tom@tromey.com>
8162
8163         * objfiles.h (struct objfile_per_bfd_storage)
8164         <demangled_hash_languages>: Now a bitset.
8165         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8166         (lookup_minimal_symbol): Update.
8167
8168 2019-03-15  Tom Tromey  <tom@tromey.com>
8169
8170         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8171         Don't return the symbol.
8172         * coffread.c (record_minimal_symbol): Use record_full.
8173
8174 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8175
8176         The MS-Windows port of ncurses fails to switch to a color pair if
8177         one or both of the colors are the implicit default colors.  This
8178         change records the default colors when TUI is initialized, and
8179         then specifies them explicitly when a color pair uses the default
8180         colors.  This allows color styling in TUI mode on MS-Windows.
8181
8182         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8183         ncurses_norm_attr.
8184         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8185         colors in ncurses_norm_attr.
8186         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8187         "none", replace it with the default color recorded in
8188         ncurses_norm_attr.
8189
8190 2019-03-14  Tom Tromey  <tromey@adacore.com>
8191
8192         * source-cache.h (class source_cache) <get_source_lines>: Return
8193         std::string.
8194         * source-cache.c (source_cache::extract_lines): Handle case where
8195         first_pos==npos.  Return std::string.
8196         (source_cache::get_source_lines): Update.
8197
8198 2019-03-14  Tom Tromey  <tromey@adacore.com>
8199
8200         * NEWS: Add item for "style sources" commands.
8201         * source-cache.c (source_cache::get_source_lines): Check
8202         source_styling.
8203         * cli/cli-style.c (source_styling): New global.
8204         (_initialize_cli_style): Add "style sources" commands.
8205         (show_style_sources): New function.
8206         * cli/cli-style.h (source_styling): Declare.
8207
8208 2019-03-14  Pedro Alves  <palves@redhat.com>
8209             Tom Tromey  <tromey@adacore.com>
8210
8211         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8212         * tui/tui-winsource.c (tui_refill_source_window): New function,
8213         from...
8214         (tui_horizontal_source_scroll): ... here.  Move some logic.
8215         * cli/cli-style.c (set_style_enabled): Notify new observable.
8216         * tui/tui-hooks.c (tui_redisplay_source): New function.
8217         (tui_attach_detach_observers): Attach or detach
8218         tui_redisplay_source.
8219         * observable.h (source_styling_changed): New observable.
8220         * observable.c: Define source_styling_changed observable.
8221
8222 2019-03-13  Tom Tromey  <tromey@adacore.com>
8223
8224         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8225         (i386_gnu_nat_target::store_registers): Update.
8226         * target-debug.h (target_debug_print_std_string): New macro.
8227         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8228         * windows-tdep.c (display_one_tib): Update.
8229         * tui/tui-stack.c (tui_make_status_line): Update.
8230         * top.c (print_inferior_quit_action): Update.
8231         * thread.c (thr_try_catch_cmd): Update.
8232         (add_thread_with_info): Update.
8233         (thread_target_id_str): Update.
8234         (thr_try_catch_cmd): Update.
8235         (thread_command): Update.
8236         (thread_find_command): Update.
8237         * record-btrace.c (record_btrace_target::info_record)
8238         (record_btrace_resume_thread, record_btrace_target::resume)
8239         (record_btrace_cancel_resume, record_btrace_step_thread)
8240         (record_btrace_target::wait, record_btrace_target::wait)
8241         (record_btrace_target::wait, record_btrace_target::stop): Update.
8242         * progspace.c (print_program_space): Update.
8243         * process-stratum-target.c
8244         (process_stratum_target::thread_address_space): Update.
8245         * linux-fork.c (linux_fork_mourn_inferior)
8246         (detach_checkpoint_command, info_checkpoints_command)
8247         (linux_fork_context): Update.
8248         (linux_fork_detach): Update.
8249         (class scoped_switch_fork_info): Update.
8250         (delete_checkpoint_command): Update.
8251         * infrun.c (follow_fork_inferior): Update.
8252         (follow_fork_inferior): Update.
8253         (proceed_after_vfork_done): Update.
8254         (handle_vfork_child_exec_or_exit): Update.
8255         (follow_exec): Update.
8256         (displaced_step_prepare_throw): Update.
8257         (displaced_step_restore): Update.
8258         (start_step_over): Update.
8259         (resume_1): Update.
8260         (clear_proceed_status_thread): Update.
8261         (proceed): Update.
8262         (print_target_wait_results): Update.
8263         (do_target_wait): Update.
8264         (context_switch): Update.
8265         (stop_all_threads): Update.
8266         (restart_threads): Update.
8267         (finish_step_over): Update.
8268         (handle_signal_stop): Update.
8269         (switch_back_to_stepped_thread): Update.
8270         (keep_going_pass_signal): Update.
8271         (print_exited_reason): Update.
8272         (normal_stop): Update.
8273         * inferior.c (inferior_pid_to_str): Change return type.
8274         (print_selected_inferior): Update.
8275         (add_inferior): Update.
8276         (detach_inferior): Update.
8277         * dummy-frame.c (fprint_dummy_frames): Update.
8278         * dcache.c (dcache_info_1): Update.
8279         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8280         (btrace_fetch, btrace_clear): Update.
8281         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8282         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8283         type.
8284         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8285         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8286         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8287         * gdbarch.c, gdbarch.h: Rebuild.
8288         * gdbarch.sh (core_pid_to_str): Change return type.
8289         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8290         return type.
8291         (windows_nat_target::pid_to_str): Change return type.
8292         (windows_delete_thread): Update.
8293         (windows_nat_target::attach): Update.
8294         (windows_nat_target::files_info): Update.
8295         * target-delegates.c: Rebuild.
8296         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8297         return type.
8298         (sol_thread_target::pid_to_str): Change return type.
8299         * remote.c (class remote_target) <pid_to_str>: Change return
8300         type.
8301         (remote_target::pid_to_str): Change return type.
8302         (extended_remote_target::attach, remote_target::remote_stop_ns)
8303         (remote_target::remote_notif_remove_queued_reply)
8304         (remote_target::push_stop_reply, remote_target::disable_btrace):
8305         Update.
8306         (extended_remote_target::attach): Update.
8307         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8308         type.
8309         (gdbsim_target::pid_to_str): Change return type.
8310         * ravenscar-thread.c (struct ravenscar_thread_target)
8311         <pid_to_str>: Change return type.
8312         (ravenscar_thread_target::pid_to_str): Change return type.
8313         * procfs.c (class procfs_target) <pid_to_str>: Change return
8314         type.
8315         (procfs_target::pid_to_str): Change return type.
8316         (procfs_target::attach): Update.
8317         (procfs_target::detach): Update.
8318         (procfs_target::fetch_registers): Update.
8319         (procfs_target::store_registers): Update.
8320         (procfs_target::wait): Update.
8321         (procfs_target::files_info): Update.
8322         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8323         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8324         return type.
8325         (nto_procfs_target::pid_to_str): Change return type.
8326         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8327         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8328         return type.
8329         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8330         (exit_lwp): Update.
8331         (attach_proc_task_lwp_callback, get_detach_signal)
8332         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8333         (linux_nat_target::resume, wait_lwp, stop_callback)
8334         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8335         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8336         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8337         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8338         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8339         type.
8340         (inf_ptrace_target::attach): Update.
8341         (inf_ptrace_target::files_info): Update.
8342         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8343         type.
8344         (go32_nat_target::pid_to_str): Change return type.
8345         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8346         (gnu_nat_target::wait): Update.
8347         (gnu_nat_target::wait): Update.
8348         (gnu_nat_target::resume): Update.
8349         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8350         (fbsd_nat_target::wait): Update.
8351         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8352         type.
8353         (darwin_nat_target::attach): Update.
8354         * corelow.c (class core_target) <pid_to_str>: Change return type.
8355         (core_target::pid_to_str): Change return type.
8356         * target.c (normal_pid_to_str): Change return type.
8357         (default_pid_to_str): Likewise.
8358         (target_pid_to_str): Change return type.
8359         (target_translate_tls_address): Update.
8360         (target_announce_detach): Update.
8361         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8362         return type.
8363         (bsd_uthread_target::pid_to_str): Change return type.
8364         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8365         type.
8366         (bsd_kvm_target::pid_to_str): Change return type.
8367         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8368         return type.
8369         (aix_thread_target::pid_to_str): Change return type.
8370         * target.h (struct target_ops) <pid_to_str>: Change return type.
8371         (target_pid_to_str, normal_pid_to_str): Likewise.
8372         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8373         type.
8374         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8375         type.
8376         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8377         return type.
8378         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8379         type.
8380         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8381         type.
8382         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8383         return type.
8384
8385 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8386
8387         * NEWS: Mention that the new default MI version is 3.  Mention
8388         changes to the output of commands and events that deal with
8389         multi-location breakpoints.
8390         * breakpoint.c: Include "mi/mi-out.h".
8391         (print_one_breakpoint): Change output syntax if using MI version
8392         >= 3.
8393         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8394         New.
8395         (mi_multi_location_breakpoint_output_fixed): New.
8396         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8397         (mi_cmd_fix_multi_location_breakpoint_output): New.
8398         (mi_multi_location_breakpoint_output_fixed): New.
8399         * mi/mi-cmds.c (mi_cmds): Register command
8400         -fix-multi-location-breakpoint-output.
8401         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8402         interpreter "mi".
8403
8404 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8405
8406         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8407         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8408         instantiate mi_ui_out based on interpreter name.
8409         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8410         * mi/mi-main.c (mi_load_progress): Likewise.
8411
8412 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8413
8414         * NEWS: Combine separate "New targets" sections for 8.3.
8415
8416 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8417
8418         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8419         (ppcfbsd_init_abi): Install gdbarch
8420         "fetch_tls_load_module_address" and "get_thread_local_address"
8421         methods.
8422
8423 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8424
8425         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8426         (riscv_fbsd_init_abi): Install gdbarch
8427         "fetch_tls_load_module_address" and "get_thread_local_address"
8428         methods.
8429
8430 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8431
8432         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8433         (i386fbsd_init_abi): Install gdbarch
8434         "fetch_tls_load_module_address" and "get_thread_local_address"
8435         methods.
8436
8437 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8438
8439         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8440         (amd64fbsd_init_abi): Install gdbarch
8441         "fetch_tls_load_module_address" and "get_thread_local_address"
8442         methods.
8443
8444 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8445
8446         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8447         (struct fbsd_pspace_data): New type.
8448         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8449         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8450         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8451         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8452         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8453
8454 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8455
8456         * gdbtypes.c (lookup_struct_elt): New function.
8457         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8458         * gdbtypes.h (struct struct_elt): New type.
8459         (lookup_struct_elt): New prototype.
8460
8461 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8462
8463         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8464         remove disabled code block.
8465
8466 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8467
8468         * gdbarch.sh (get_thread_local_address): New method.
8469         * gdbarch.h, gdbarch.c: Regenerate.
8470         * target.c (target_translate_tls_address): Use
8471         gdbarch_get_thread_local_address if present instead of
8472         target::get_thread_local_address.
8473
8474 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8475
8476         * target.h (target::get_thread_local_address): Update comment.
8477
8478 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8479
8480         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8481         objfile->separate_debug_objfile_backlink if not NULL.
8482
8483 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8484
8485         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8486         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8487         (amd64bsd_store_inferior_registers): Likewise.
8488         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8489         Enable segment base registers.
8490         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8491         PT_GETFSBASE and PT_GETGSBASE.
8492         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8493         PT_SETGSBASE.
8494         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8495         segment base registers.
8496         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8497
8498 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8499
8500         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8501         Update calls to i386_target_description to add 'segments'
8502         parameter.
8503         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8504         add segment base registers.
8505         * arch/i386.c (i386_create_target_description): Add 'segments'
8506         parameter to enable segment base registers.
8507         * arch/i386.h (i386_create_target_description): Likewise.
8508         * features/i386/32bit-segments.xml: New file.
8509         * features/i386/32bit-segments.c: Generate.
8510         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8511         call to i386_target_description to add 'segments' parameter.
8512         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8513         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8514         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8515         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8516         if feature is present.
8517         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8518         Add 'segments' parameter to call to i386_target_description.
8519         (i386_target_description): Add 'segments' parameter to enable
8520         segment base registers.
8521         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8522         to call to i386_target_description.
8523         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8524         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8525         Define I386_NUM_REGS.
8526         (i386_target_description): Add 'segments' parameter to enable
8527         segment base registers.
8528
8529 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8530
8531         PR/24325
8532         * source-cache.c: #undef open and close, to avoid unresolved
8533         externals during linking.
8534
8535 2019-03-12  Tom Tromey  <tromey@adacore.com>
8536
8537         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8538         const.  Add initializers.
8539         (_initialize_remote): Don't initialize ptid globals.
8540
8541 2019-03-12  Pedro Alves  <palves@redhat.com>
8542
8543         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8544
8545 2019-03-12  Pedro Alves  <palves@redhat.com>
8546
8547         * cp-name-parser.y (main): Remove unused 'len' variable.
8548
8549 2019-03-12  Tom Tromey  <tromey@adacore.com>
8550
8551         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8552         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8553
8554 2019-03-12  Tom Tromey  <tromey@adacore.com>
8555
8556         * linux-nat.c (iterate_over_lwps): Update.
8557         (stop_callback): Remove parameter.
8558         (stop_wait_callback, detach_callback, resume_set_callback)
8559         (select_singlestep_lwp_callback, set_ignore_sigint)
8560         (status_callback, resumed_callback, resume_clear_callback)
8561         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8562         data parameter.
8563         (linux_nat_target::detach, linux_nat_target::resume)
8564         (linux_stop_and_wait_all_lwps, select_event_lwp)
8565         (linux_nat_filter_event, linux_nat_wait_1)
8566         (linux_nat_target::kill, linux_nat_target::stop)
8567         (linux_nat_target::stop): Update.
8568         (linux_nat_resume_callback): Change type.
8569         (resume_stopped_resumed_lwps, count_events_callback)
8570         (select_event_lwp_callback): Likewise.
8571         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8572         * arm-linux-nat.c (struct update_registers_data): Remove.
8573         (update_registers_callback): Change type.
8574         (arm_linux_insert_hw_breakpoint1): Update.
8575         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8576         parameter.
8577         (x86_linux_dr_set_addr): Update.
8578         (x86_linux_dr_set_control): Update.
8579         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8580         (iterate_over_lwps): Use gdb::function_view.
8581         * nat/aarch64-linux-hw-point.c (struct
8582         aarch64_dr_update_callback_param): Remove.
8583         (debug_reg_change_callback): Change type.
8584         (aarch64_notify_debug_reg_change): Update.
8585         * s390-linux-nat.c (s390_refresh_per_info): Update.
8586
8587 2019-03-11  Tom Tromey  <tromey@adacore.com>
8588
8589         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8590         redundant assignment to "this_cu".
8591
8592 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8593
8594         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8595
8596 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8597
8598         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8599         from...
8600         (rank_one_type): ... this.
8601
8602 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8603
8604         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8605         from...
8606         (rank_one_type): ... this.
8607
8608 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8609
8610         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8611         from...
8612         (rank_one_type): ... this.
8613
8614 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8615
8616         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8617         from...
8618         (rank_one_type): ... this.
8619
8620 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8621
8622         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8623         from...
8624         (rank_one_type): ... this.
8625
8626 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8627
8628         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8629         from...
8630         (rank_one_type): ... this.
8631
8632 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8633
8634         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8635         from...
8636         (rank_one_type): ... this.
8637
8638 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8639
8640         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8641         from...
8642         (rank_one_type): ... this.
8643
8644 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8645
8646         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8647         from...
8648         (rank_one_type): ... this.
8649
8650 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8651
8652         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8653         from...
8654         (rank_one_type): ... this.
8655
8656 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8657
8658         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8659         from...
8660         (rank_one_type): ... this.
8661
8662 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8663
8664         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8665         from...
8666         (rank_one_type): ... this.
8667
8668 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8669
8670         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8671         inferior-events' shows the example events.
8672
8673 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8674
8675         Support styling on native MS-Windows console
8676
8677         PR/24315
8678         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8679         on MS-Windows if $TERM is not defined.
8680
8681         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8682
8683         * posix-hdep.c (gdb_console_fputs):
8684         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8685         functions.
8686         * ui-file.h (gdb_console_fputs): Add prototype.
8687
8688         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8689         back to fputs only if the former returns zero.
8690
8691 2019-03-07  Tom Tromey  <tom@tromey.com>
8692
8693         * symmisc.c (print_symbol_bcache_statistics): Update.
8694         (print_objfile_statistics): Update.
8695         * symfile.c (allocate_symtab): Update.
8696         * stabsread.c: Don't include bcache.h.
8697         * psymtab.h (struct psymbol_bcache): Don't declare.
8698         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8699         (psymbol_bcache_init, psymbol_bcache_free)
8700         (psymbol_bcache_get_bcache): Don't declare.
8701         * psymtab.c (struct psymbol_bcache): Remove.
8702         (psymtab_storage::psymtab_storage): Update.
8703         (psymtab_storage::~psymtab_storage): Update.
8704         (psymbol_bcache_init, psymbol_bcache_free)
8705         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8706         (add_psymbol_to_bcache): Update.
8707         (allocate_psymtab): Update.
8708         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8709         macro_cache>: No longer pointers.
8710         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8711         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8712         * macrotab.c (macro_bcache): Update.
8713         * macroexp.c: Don't include bcache.h.
8714         * gdbtypes.c (check_types_worklist): Update.
8715         (types_deeply_equal): Remove TRY/CATCH.  Update.
8716         * elfread.c (elf_symtab_read): Update.
8717         * dwarf2read.c: Don't include bcache.h.
8718         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8719         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8720         (print_bcache_statistics, bcache_memory_used): Don't declare.
8721         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8722         methods.  Rename all data members.
8723         * bcache.c (struct bcache): Move to bcache.h.
8724         (bcache::expand_hash_table): Rename from expand_hash_table.
8725         (bcache): Remove.
8726         (bcache::insert): Rename from bcache_full.
8727         (bcache::compare): Rename from bcache_compare.
8728         (bcache_xmalloc): Remove.
8729         (bcache::~bcache): Rename from bcache_xfree.
8730         (bcache::print_statistics): Rename from print_bcache_statistics.
8731         (bcache::memory_used): Rename from bcache_memory_used.
8732
8733 2019-03-07  Pedro Alves  <palves@redhat.com>
8734
8735         * infrun.c (normal_stop): Also check for
8736         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8737
8738 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8739
8740         * f-lang.c (value_from_host_double): Moved to...
8741         * value.c (value_from_host_double): ...here.
8742         * value.h (value_from_host_double): Declare.
8743         * guile/scm-math.c (vlscm_convert_typed_number): Use
8744         value_from_host_double.
8745         (vlscm_convert_number): Likewise.
8746         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8747         * python/py-value.c (convert_value_from_python): Likewise.
8748
8749 2019-03-06  Tom Tromey  <tom@tromey.com>
8750
8751         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8752
8753 2019-03-06  Tom Tromey  <tom@tromey.com>
8754
8755         * utils.h (free_current_contents): Don't declare.
8756         * utils.c (free_current_contents): Remove.
8757
8758 2019-03-06  Tom Tromey  <tom@tromey.com>
8759
8760         * top.c (quit_force): Update.
8761         * main.c (captured_command_loop): Update.
8762         * common/new-op.c (operator new): Update.
8763         * common/common-exceptions.c (struct catcher)
8764         <save_cleanup_chain>: Remove member.
8765         (exceptions_state_mc_init): Update.
8766         (exception_try_scope_entry): Return nullptr.
8767         (exception_try_scope_exit, exception_rethrow)
8768         (throw_exception_sjlj, throw_exception_cxx): Update.
8769         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8770         (all_cleanups, do_cleanups, discard_cleanups)
8771         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8772         (restore_cleanups, restore_final_cleanups): Don't declare.
8773         (do_final_cleanups): Remove parameter.
8774         * common/cleanups.c (cleanup_chain, make_cleanup)
8775         (make_cleanup_dtor, all_cleanups, do_cleanups)
8776         (discard_my_cleanups, discard_cleanups)
8777         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8778         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8779         (null_cleanup): Remove.
8780         (do_final_cleanups): Remove parameter.
8781
8782 2019-03-06  Tom Tromey  <tom@tromey.com>
8783
8784         * remote.c (remote_target::remote_parse_stop_reply): Use
8785         unique_xmalloc_ptr.
8786
8787 2019-03-06  Tom Tromey  <tom@tromey.com>
8788
8789         * stabsread.c (struct stabs_field_info): Rename from field_info.
8790         <list, fnlist>: Add initializers.
8791         <obstack>: New member.
8792         (read_member_functions, read_struct_fields, read_baseclasses):
8793         Allocate on obstack.  Don't use cleanups.
8794         (read_one_struct_field, read_member_functions, read_struct_fields)
8795         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8796         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8797         (read_struct_type): Update.
8798
8799 2019-03-06  Tom Tromey  <tom@tromey.com>
8800
8801         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8802         * common/filestuff.h (make_cleanup_close): Don't declare.
8803         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8804         Remove.
8805
8806 2019-03-06  Tom Tromey  <tom@tromey.com>
8807
8808         * solib-aix.c: Use make_scope_exit.
8809
8810 2019-03-06  Tom Tromey  <tom@tromey.com>
8811
8812         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8813         Use make_scope_exit.
8814
8815 2019-03-06  Tom Tromey  <tom@tromey.com>
8816
8817         * solib-svr4.c (disable_probes_interface): Remove parameter.
8818         (svr4_handle_solib_event): Use make_scope_exit.
8819
8820 2019-03-06  Tom Tromey  <tom@tromey.com>
8821
8822         * remote.c (struct stop_reply_deleter): Remove.
8823         (stop_reply_up): Update.
8824         (struct stop_reply): Derive from notif_event.  Don't typedef.
8825         <regcache>: Now a std::vector.
8826         (stop_reply_xfree): Remove.
8827         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8828         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8829         (remote_target::discard_pending_stop_replies): Use delete.
8830         (remote_target::remote_parse_stop_reply): Update.
8831         (remote_target::process_stop_reply): Update.
8832         * remote-notif.h (struct notif_event): Add virtual destructor.
8833         Remove "dtr" member.
8834         (struct notif_client) <alloc_event>: Return a unique_ptr.
8835         (notif_event_xfree): Don't declare.
8836         (notif_event_up): New typedef.
8837         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8838         (notif_event_xfree, do_notif_event_xfree): Remove.
8839         (remote_notif_state_xfree): Update.
8840
8841 2019-03-06  Tom Tromey  <tom@tromey.com>
8842
8843         * infrun.c (displaced_step_clear_cleanup): Now a
8844         forward_scope_exit type.
8845         (displaced_step_prepare_throw): Update.
8846         (displaced_step_fixup): Update.
8847
8848 2019-03-06  Tom Tromey  <tom@tromey.com>
8849
8850         * inferior.h (class inferior): Update comment.
8851         * gdbthread.h (class thread_info): Update comment.
8852
8853 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8854             Tom Tromey  <tom@tromey.com>
8855
8856         * stabsread.h (struct stab_section_list): Remove.
8857         (coffstab_build_psymtabs): Update.
8858         * dbxread.c (symbuf_sections): Now a std::vector.
8859         (sect_idx): New global.
8860         (fill_symbuf): Update.
8861         (coffstab_build_psymtabs): Change type of stabsects parameter.
8862         Update.
8863         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8864         std::vector.
8865         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8866         (coff_locate_sections): Update.
8867         (coff_symfile_read): Remove cleanups.  Update.
8868         (init_stringtab): Add storage parameter.
8869         (free_stringtab, free_stringtab_cleanup): Remove.
8870         (init_lineno): Add storage parameter.
8871         (free_linetab, free_linetab_cleanup): Remove.
8872
8873 2019-03-06  Pedro Alves  <palves@redhat.com>
8874
8875         * linux-fork.c (fork_info::clobber_regs): Delete.
8876         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8877         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8878         comment.  Adjust.
8879         (scoped_switch_fork_info::scoped_switch_fork_info)
8880         (checkpoint_command, linux_fork_context): Adjust
8881         fork_save_infrun_state calls.
8882
8883 2019-03-06  Pedro Alves  <palves@redhat.com>
8884
8885         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8886         (inf_has_multiple_threads): Return 'bool' and rewrite using
8887         inferior_info::threads().
8888
8889 2019-03-06  Pedro Alves  <palves@redhat.com>
8890
8891         * linux-fork.c: Include <list>.
8892         (fork_list): Now a std::list instance.
8893         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8894         (forks_exist_p, find_last_fork): Adjust.
8895         (new_fork): Delete.
8896         (one_fork_p): New.
8897         (add_fork): Adjust.
8898         (free_fork): Delete, folded into fork_info::~fork_info().
8899         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8900         Adjust.
8901         (init_fork_list): Delete.
8902         (linux_fork_killall, linux_fork_mourn_inferior)
8903         (linux_fork_detach, info_checkpoints_command): Adjust.
8904         (_initialize_linux_fork): No longer call init_fork_list.
8905
8906 2019-03-06  Pedro Alves  <palves@redhat.com>
8907
8908         * linux-fork.c (new_fork): New, split out of ...
8909         (add_fork): ... this.  Return void.  Move "first fork" special
8910         case from here, to ...
8911         (checkpoint_command): ... here.
8912         * linux-linux.h (add_fork): Return void.
8913
8914 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8915
8916         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8917
8918 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8919             Chris January  <chris.january@arm.com>
8920             David Lecomber  <david.lecomber@arm.com>
8921
8922         * f-exp.y: New token, UNOP_INTRINSIC.
8923         (exp): New pattern using UNOP_INTRINSIC token.
8924         (f77_keywords): Add 'abs' keyword.
8925         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8926         (value_from_host_double): New function.
8927         (evaluate_subexp_f): Support UNOP_ABS.
8928
8929 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8930
8931         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8932         types.
8933
8934 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8935
8936         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8937         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8938         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8939
8940 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8941
8942         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8943
8944 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8945             Chris January  <chris.january@arm.com>
8946
8947         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8948         * f-exp.y: Define 'KIND' token.
8949         (exp): New pattern for KIND expressions.
8950         (ptype): Handle types with a kind extension.
8951         (direct_abs_decl): Extend to spot kind extensions.
8952         (f77_keywords): Add 'kind' to the list.
8953         (push_kind_type): New function.
8954         (convert_to_kind_type): New function.
8955         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8956         * parse.c (operator_length_standard): Likewise.
8957         * parser-defs.h (enum type_pieces): Add tp_kind.
8958         * std-operator.def: Add UNOP_KIND.
8959
8960 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8961
8962         * f-exp.y (f_parse): Set yydebug.
8963
8964 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8965
8966         * f-lang.c (evaluate_subexp_f): New function.
8967         (exp_descriptor_f): New global.
8968         (f_language_defn): Use exp_descriptor_f instead of
8969         exp_descriptor_standard.
8970
8971 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8972
8973         * f-exp.y (struct token): Add comments.
8974         (dot_ops): Remove uppercase versions and the end marker.
8975         (f77_keywords): Likewise.
8976         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8977         entries in the dot_ops array are case insensitive, and use
8978         strncasecmp to compare strings.  Also some whitespace cleanup in
8979         this area.  Similar for the f77_keywords array, except entries in
8980         this list might be case sensitive.
8981
8982 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8983
8984         * f-exp.y (struct f77_boolean_val): Add comments.
8985         (boolean_values): Remove uppercase versions, and end marker.
8986         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8987         and use strncasecmp to achieve case insensitivity.  Additionally,
8988         perform whitespace cleanup around this code.
8989
8990 2019-03-06  Tom Tromey  <tromey@adacore.com>
8991
8992         * remote-sim.c (gdbsim_target_open): Use result of
8993         gdb_argv::release.
8994
8995 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8996         Dirk Schubert  <dirk.schubert@arm.com>
8997         Chris January  <chris.january@arm.com>
8998
8999         * eval.c (evaluate_subexp_standard): Call Fortran argument
9000         wrapping logic.
9001         * f-lang.c (struct value): A value which can be passed into a
9002         Fortran function call.
9003         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9004         where appropriate.
9005         (struct type): Value ready for a Fortran function call.
9006         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9007         is needed.
9008         * f-lang.h (fortran_argument_convert): Declaration.
9009         (fortran_preserve_arg_pointer): Declaration.
9010         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9011
9012 2019-03-05  Tom Tromey  <tromey@adacore.com>
9013
9014         * python/py-prettyprint.c (print_string_repr): Remove #if.
9015         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9016
9017 2019-03-05  Tom Tromey  <tromey@adacore.com>
9018
9019         * target.c (the_dummy_target): Move later.  Change type to
9020         "dummy_target".
9021         (initialize_targets): Don't initialize the_dummy_target.
9022
9023 2019-03-05  Tom Tromey  <tromey@adacore.com>
9024
9025         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9026         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9027
9028 2019-03-05  Tom Tromey  <tromey@adacore.com>
9029
9030         * windows-nat.c (windows_nat_target::attach)
9031         (windows_nat_target::detach): Don't call gdb_flush.
9032         * valprint.c (generic_val_print, val_print, val_print_string):
9033         Don't call gdb_flush.
9034         * utils.c (defaulted_query): Don't call gdb_flush.
9035         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9036         * target.c (target_announce_detach): Don't call gdb_flush.
9037         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9038         * remote.c (extended_remote_target::attach): Don't call
9039         gdb_flush.
9040         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9041         * printcmd.c (do_examine): Don't call gdb_flush.
9042         (info_display_command): Don't call gdb_flush.
9043         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9044         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9045         * memattr.c (info_mem_command): Don't call gdb_flush.
9046         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9047         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9048         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9049         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9050         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9051         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9052         (gnu_nat_target::detach): Don't call gdb_flush.
9053         * f-valprint.c (f_val_print): Don't call gdb_flush.
9054         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9055         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9056         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9057         gdb_flush.
9058         * c-valprint.c (c_val_print): Don't call gdb_flush.
9059         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9060
9061 2019-03-05  Tom Tromey  <tromey@adacore.com>
9062
9063         * varobj.c (update_dynamic_varobj_children): Update.
9064         (install_default_visualizer): Use reset, not release.
9065         * value.c (set_internalvar): Update.
9066         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9067         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9068         ATTRIBUTE_UNUSED_RESULT.
9069
9070 2019-03-05  Tom Tromey  <tromey@adacore.com>
9071
9072         * remote.c (class scoped_remote_fd) <release>: Add
9073         ATTRIBUTE_UNUSED_RESULT.
9074
9075 2019-03-05  Tom Tromey  <tromey@adacore.com>
9076
9077         * macroexp.c (struct macro_buffer) <release>: Add
9078         ATTRIBUTE_UNUSED_RESULT.
9079
9080 2019-03-05  Tom Tromey  <tromey@adacore.com>
9081
9082         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9083         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9084         ATTRIBUTE_UNUSED_RESULT.
9085
9086 2019-03-05  Tom Tromey  <tromey@adacore.com>
9087
9088         * common/scoped_fd.h (class scoped_fd) <release>: Add
9089         ATTRIBUTE_UNUSED_RESULT.
9090
9091 2019-03-05  Tom Tromey  <tromey@adacore.com>
9092
9093         * parser-defs.h (struct parser_state) <release>: Add
9094         ATTRIBUTE_UNUSED_RESULT.
9095
9096 2019-03-05  Tom Tromey  <tromey@adacore.com>
9097
9098         * utils.h (class gdb_argv) <release>: Add
9099         ATTRIBUTE_UNUSED_RESULT.
9100         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9101
9102 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9103
9104         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9105         for-loop range, to avoid compiler warnings.
9106
9107         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9108         avoid compiler warnings about unused variables.
9109
9110         * NEWS: Mention end of support for native debugging on MS-Windows
9111         before XP.
9112
9113         PR gdb/24292
9114         * common/netstuff.c:
9115         * gdbserver/gdbreplay.c
9116         * gdbserver/remote-utils.c:
9117         * ser-tcp.c:
9118         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9119         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9120         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9121         'getaddrinfo' and 'freeaddrinfo' were not available before
9122         Windows XP, and mingw.org's MinGW headers by default define
9123         _WIN32_WINNT to 0x500.
9124
9125 2019-03-01  Gary Benson <gbenson@redhat.com>
9126
9127         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9128
9129 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9130             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9131
9132         PR gdb/8527
9133         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9134         set_sigint_trap, clear_sigint_trap.
9135
9136 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9137
9138         * target.c (target_detach): Clear the regcache and the
9139         frame cache.
9140
9141 2019-02-27  Pedro Alves  <palves@redhat.com>
9142
9143         * utils.c (set_screen_size): When we cap the height/width sizes,
9144         tweak the corresponding command variable to show "unlimited":
9145
9146 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9147             Pedro Alves  <palves@redhat.com>
9148
9149         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9150         before calling rl_set_screen_size.
9151
9152 2019-02-27  Tom Tromey  <tromey@adacore.com>
9153
9154         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9155         define.
9156         * python/py-value.c: Remove Python 2.4 workaround.
9157         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9158         workaround.
9159         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9160         Python 2.4 workaround.
9161         * python/python-internal.h: Remove Python 2.4 comment.
9162         (Py_ssize_t): Don't define.
9163         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9164         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9165         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9166         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9167         * python/python.c (do_start_initialization): Remove Python 2.4
9168         workaround.
9169         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9170         (print_children): Remove Python 2.4 workaround.
9171         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9172         workaround.
9173         (CHARBUFFERPROC_NAME): Remove.
9174         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9175         Python 2.4 workaround.
9176
9177 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9178
9179         * NEWS: Note minimum Python version.
9180
9181 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9182
9183         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9184         code from these functions.  Remove corresponding ifdefs.  Use
9185         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9186         Remove gotos and target of gotos.
9187         (infpy_search_memory): Likewise.
9188
9189 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9190
9191         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9192         (hppa_gdbarch_init): Don't register deleted functions with
9193         gdbarch.
9194
9195 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9196
9197         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9198         (h8300_unwind_sp): Delete.
9199         (h8300_dummy_id): Delete.
9200         (h8300_gdbarch_init): Don't register deleted functions with
9201         gdbarch.
9202
9203 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9204
9205         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9206         (ft32_unwind_pc): Delete.
9207         (ft32_unwind_sp): Delete.
9208         (ft32_gdbarch_init): Don't register deleted functions with
9209         gdbarch.
9210
9211 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9212
9213         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9214         (frv_unwind_pc): Delete.
9215         (frv_unwind_sp): Delete.
9216         (frv_gdbarch_init): Don't register deleted functions with
9217         gdbarch.
9218
9219 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9220
9221         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9222         (riscv_unwind_pc): Delete.
9223         (riscv_unwind_sp): Delete.
9224         (riscv_gdbarch_init): Don't register deleted functions with
9225         gdbarch.
9226
9227 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9228
9229         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9230         (csky_unwind_pc): Delete.
9231         (csky_unwind_sp): Delete.
9232         (csky_gdbarch_init): Don't register deleted functions with
9233         gdbarch.
9234
9235 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9236
9237         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9238         (cris_unwind_pc): Delete.
9239         (cris_unwind_sp): Delete.
9240         (cris_gdbarch_init): Don't register deleted functions with
9241         gdbarch.
9242
9243 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9244
9245         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9246         (bfin_unwind_pc): Delete.
9247         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9248
9249 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9250
9251         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9252         (arm_unwind_pc): Delete.
9253         (arm_unwind_sp): Delete.
9254         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9255
9256 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9257
9258         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9259         (arc_unwind_pc): Delete.
9260         (arc_unwind_sp): Delete.
9261         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9262
9263 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9264
9265         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9266         (alpha_unwind_pc): Delete.
9267         (alpha_gdbarch_init): Don't register deleted functions with
9268         gdbarch.
9269
9270 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9271
9272         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9273         (aarch64_unwind_pc): Delete.
9274         (aarch64_unwind_sp): Delete.
9275         (aarch64_gdbarch_init): Don't register deleted functions with
9276         gdbarch.
9277
9278 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9279
9280         * gdbtypes.c (type_align): Don't consider static members when
9281         computing structure alignment.
9282
9283 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9284
9285         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9286         return 0 for other types.
9287         * arch-utils.c (default_type_align): Always return 0.
9288         * gdbarch.h: Regenerate.
9289         * gdbarch.sh (type_align): Extend comment.
9290         * gdbtypes.c (type_align): Add additional comments, always call
9291         gdbarch_type_align before applying the default rules.
9292         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9293         generic code will then apply a suitable default.
9294         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9295         types, return 0 for other types.
9296
9297 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9298
9299         * NEWS: Create a new section for the next release branch.
9300         Rename the section of the current branch, now that it has
9301         been cut.
9302
9303 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9304
9305         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9306         * version.in: Bump version to 8.3.50.DATE-git.
9307
9308 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9309
9310         * aix-thread.c (ptid_cmp): Remove unused variable.
9311         (get_signaled_thread): Likewise.
9312         (store_regs_user_thread): Likewise.
9313         (store_regs_kernel_thread): Likewise.
9314         (fetch_regs_kernel_thread): Remove shadowed variable.
9315
9316 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9317
9318         * features/riscv/32bit-cpu.xml: Add register numbers.
9319         * features/riscv/32bit-fpu.c: Regenerate.
9320         * features/riscv/32bit-fpu.xml: Add register numbers.
9321         * features/riscv/64bit-cpu.xml: Add register numbers.
9322         * features/riscv/64bit-fpu.c: Regenerate.
9323         * features/riscv/64bit-fpu.xml: Add register numbers.
9324
9325 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9326
9327         * NEWS: Mention two argument form of gdb.Value constructor.
9328         * python/py-value.c (convert_buffer_and_type_to_value): New
9329         function.
9330         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9331         Add support for handling an optional second argument.  Call
9332         convert_buffer_and_type_to_value as appropriate.
9333         * python/python-internal.h (Py_buffer_deleter): New struct.
9334         (Py_buffer_up): New typedef.
9335
9336 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9337
9338         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9339         instead of releasing ownership.
9340
9341 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9342
9343         * dwarf2read.c (open_and_init_dwp_file): Call
9344         elf_numsections instead of bfd_count_sections to initialize
9345         dwp_file->num_sections.
9346
9347 2019-02-25  Tom Tromey  <tromey@adacore.com>
9348
9349         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9350
9351 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9352
9353         * gcore.in: Add '--readnever' option when invoking GDB.
9354
9355 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9356
9357         * MAINTAINERS: Update my email address.
9358
9359 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9360
9361         * build-id.c (build_id_to_debug_bfd_1): New function.
9362         (build_id_to_debug_bfd): Look for separate debug file in
9363         sysroot.
9364
9365 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9366
9367         * gdbarch.sh: Update the copyright year range that is placed into
9368         generated files.
9369
9370 2019-02-22  Keith Seitz  <keiths@redhat.com>
9371
9372         PR symtab/23853
9373         * linespec.c (create_sals_line_offset): Search for the default
9374         symtab's filename instead of its fullname.
9375
9376 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9377
9378         * NEWS: Update style defaults.
9379
9380 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9381
9382         * main.c (captured_main_1): Disable styling in batch mode.
9383
9384 2019-02-20  Tom Tromey  <tom@tromey.com>
9385
9386         * symtab.c (symtab_symbol_info): Fix typos.
9387
9388 2019-02-20  Tom Tromey  <tromey@adacore.com>
9389
9390         * findcmd.c (_initialize_mem_search): Use upper case for
9391         metasyntactic variables.
9392
9393 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9394
9395         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9396         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9397
9398 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9399
9400         * top.h (source_file_name): Change to std::string.
9401         * top.c (source_file_name): Likewise.
9402         (command_line_input): Adjust.
9403         * cli/cli-script.c (script_from_file): Adjust.
9404
9405 2019-02-19  Tom Tromey  <tromey@adacore.com>
9406
9407         * ravenscar-thread.c
9408         (ravenscar_thread_target::update_thread_list): Don't call
9409         ada_build_task_list.
9410         * ada-lang.h (ada_build_task_list): Don't declare.
9411         * ada-tasks.c (struct ada_tasks_inferior_data)
9412         <task_list_valid_p>: Now bool.
9413         (read_known_tasks, ada_task_list_changed)
9414         (ada_tasks_invalidate_inferior_data): Update.
9415         (read_known_tasks_array): Return bool.
9416         (read_known_tasks_list): Likewise.
9417         (read_known_tasks): Return void.
9418         (ada_build_task_list): Now static.
9419
9420 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9421
9422         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9423         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9424
9425 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9426
9427         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9428         variant for ada_tasks_pspace_data_handle and
9429         ada_tasks_inferior_data_handle.
9430         (ada_tasks_pspace_data_cleanup): New function.
9431         (ada_tasks_inferior_data_cleanup): New function.
9432
9433 2019-02-17  Tom Tromey  <tom@tromey.com>
9434
9435         * macrotab.h (macro_source_fullname): Return a std::string.
9436         * macrotab.c (macro_include, check_for_redefinition)
9437         (macro_undef, macro_lookup_definition, foreach_macro)
9438         (foreach_macro_in_scope): Update.
9439         (macro_source_fullname): Return a std::string.
9440         * macrocmd.c (show_pp_source_pos): Update.
9441
9442 2019-02-17  Tom Tromey  <tom@tromey.com>
9443
9444         * macrocmd.c (show_pp_source_pos): Style the file names.
9445
9446 2019-02-17  Tom Tromey  <tom@tromey.com>
9447
9448         PR tui/24197:
9449         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9450
9451 2019-02-17  Tom Tromey  <tom@tromey.com>
9452
9453         * ada-lang.c (user_select_syms): Use filtered printing.
9454         * utils.c (wrap_style): New global.
9455         (desired_style): Remove.
9456         (emit_style_escape): Add stream parameter.
9457         (set_output_style, reset_terminal_style, prompt_for_continue):
9458         Update.
9459         (flush_wrap_buffer): Only flush gdb_stdout.
9460         (wrap_here): Set wrap_style.
9461         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9462         treat escape sequences as a character.  Change when wrap buffer is
9463         flushed.
9464         (fputs_styled): Do not set the output style when the default is
9465         requested.
9466         * ui-style.h (struct ui_file_style) <is_default>: New method.
9467         * source.c (print_source_lines_base): Emit escape sequences in one
9468         piece.
9469
9470 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9471
9472         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9473         integers and enumeration types.
9474
9475 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9476
9477         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9478         instead of lookup_symbol_in_language
9479         (do_exact_match): New function.
9480         (ada_get_symbol_name_matcher): Return do_exact_match when
9481         doing a verbatim match.
9482
9483 2019-02-15  Tom Tromey  <tromey@adacore.com>
9484
9485         * ravenscar-thread.c (ravenscar_thread_target::resume)
9486         (ravenscar_thread_target::wait): Special case wildcard requests.
9487
9488 2019-02-15  Tom Tromey  <tromey@adacore.com>
9489
9490         * ravenscar-thread.c (base_ptid): Remove.
9491         (struct ravenscar_thread_target) <close>: New method.
9492         <m_base_ptid>: New member.
9493         <update_inferior_ptid, active_task, task_is_currently_active,
9494         runtime_initialized>: Declare methods.
9495         <ravenscar_thread_target>: Add constructor.
9496         (ravenscar_thread_target::task_is_currently_active)
9497         (ravenscar_thread_target::update_inferior_ptid)
9498         (ravenscar_runtime_initialized): Rename.  Now methods.
9499         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9500         (ravenscar_thread_target::update_thread_list): Update.
9501         (ravenscar_thread_target::active_task): Now method.
9502         (ravenscar_thread_target::store_registers)
9503         (ravenscar_thread_target::prepare_to_store)
9504         (ravenscar_thread_target::prepare_to_store)
9505         (ravenscar_thread_target::mourn_inferior): Update.
9506         (ravenscar_inferior_created): Use "new" to create target.
9507         (ravenscar_thread_target::get_ada_task_ptid): Update.
9508         (_initialize_ravenscar): Don't initialize base_ptid.
9509         (ravenscar_ops): Remove global.
9510
9511 2019-02-15  Tom Tromey  <tromey@adacore.com>
9512
9513         * target.h (push_target): Declare new overload.
9514         * target.c (push_target): New overload, taking an rvalue reference.
9515         * remote.c (remote_target::open_1): Use push_target overload.
9516         * corelow.c (core_target_open): Use push_target overload.
9517
9518 2019-02-15  Tom Tromey  <tromey@adacore.com>
9519
9520         * ravenscar-thread.c (is_ravenscar_task)
9521         (ravenscar_task_is_currently_active): Return bool.
9522         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9523         (_initialize_ravenscar): Remove "(void)".
9524         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9525         Return bool.
9526
9527 2019-02-15  Tom Tromey  <tromey@adacore.com>
9528
9529         * ravenscar-thread.c (ravenscar_runtime_initializer)
9530         (has_ravenscar_runtime, get_running_thread_id)
9531         (ravenscar_thread_target::resume): Fix indentation.
9532
9533 2019-02-15  Tom Tromey  <tromey@adacore.com>
9534
9535         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9536         from ravenscar_arch_ops.
9537         (sparc_ravenscar_ops::fetch_registers)
9538         (sparc_ravenscar_ops::store_registers): Now methods.
9539         (sparc_ravenscar_prepare_to_store): Remove.
9540         (sparc_ravenscar_ops): Redefine.
9541         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9542         methods and destructor.  Remove members.
9543         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9544         (ravenscar_thread_target::store_registers)
9545         (ravenscar_thread_target::prepare_to_store): Update.
9546         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9547         Remove.
9548         (struct ppc_ravenscar_powerpc_ops): Derive from
9549         ravenscar_arch_ops.
9550         (ppc_ravenscar_powerpc_ops::fetch_registers)
9551         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9552         (ppc_ravenscar_powerpc_ops): Redefine.
9553         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9554         (ppc_ravenscar_e500_ops::fetch_registers)
9555         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9556         (ppc_ravenscar_e500_ops): Redefine.
9557         * aarch64-ravenscar-thread.c
9558         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9559         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9560         (aarch64_ravenscar_fetch_registers)
9561         (aarch64_ravenscar_store_registers): Now methods.
9562         (aarch64_ravenscar_ops): Redefine.
9563
9564 2019-02-15  Tom Tromey  <tromey@adacore.com>
9565
9566         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9567         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9568         (ravenscar_thread_target::stopped_by_watchpoint)
9569         (ravenscar_thread_target::stopped_data_address)
9570         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9571
9572 2019-02-15  Tom Tromey  <tromey@adacore.com>
9573
9574         * ravenscar-thread.c: Fix some typos.
9575
9576 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9577             Tom Tromey  <tromey@adacore.com>
9578
9579         * ada-lang.c (ada_exception_sal): Change addr_string to a
9580         std::string.
9581         (create_ada_exception_catchpoint): Update.
9582
9583 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9584             Tom Tromey  <tromey@adacore.com>
9585
9586         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9587         (bp_location_ops): Remove.
9588         (base_breakpoint_allocate_location): Update.
9589         (free_bp_location): Update.
9590         * ada-lang.c (class ada_catchpoint_location)
9591         <ada_catchpoint_location>: Remove ops parameter.
9592         (ada_catchpoint_location_dtor): Remove.
9593         (ada_catchpoint_location_ops): Remove.
9594         (allocate_location_exception): Update.
9595         * breakpoint.h (struct bp_location_ops): Remove.
9596         (class bp_location) <bp_location>: Remove bp_location_ops
9597         parameter.
9598         <~bp_location>: Add destructor.
9599         <ops>: Remove.
9600
9601 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9602             Pedro Alves  <palves@redhat.com>
9603
9604         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9605         'PATH_MAX'.
9606
9607 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9608             Samuel Thibault  <samuel.thibault@gnu.org>
9609             Thomas Schwinge  <thomas@codesourcery.com>
9610
9611         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9612         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9613
9614 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9615
9616         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9617         (check_empty): Use "const char *".
9618
9619         * gnu-nat.c (gnu_nat_target::detach): Instead of
9620         'detach_inferior (pid)' call
9621         'detach_inferior (find_inferior_pid (pid))'.
9622
9623         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9624         'nat/fork-inferior.o'.
9625         * gnu-nat.c: #include "nat/fork-inferior.h".
9626
9627         * gnu-nat.c (gnu_nat_target::detach): Instead of
9628         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9629         * gnu-nat.h: #include "inf-child.h".
9630         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9631         'i386_gnu_nat_target::fetch_registers'.
9632         (gnu_store_registers): Rename/move to
9633         'i386_gnu_nat_target::store_registers'.
9634
9635         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9636         * gnu-nat.h (mach_thread_info): New function.
9637         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9638
9639         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9640
9641 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9642
9643         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9644
9645 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9646
9647         * windows-nat.c (windows_add_thread): Add new parameter
9648         "main_thread_p" with default value set to false.  Update
9649         function documentation as well as all callers.
9650         (windows_delete_thread): Likewise.
9651         (fake_create_process): Update call to windows_add_thread.
9652         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9653         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9654         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9655         call to windows_delete_thread.
9656
9657 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9658
9659         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9660
9661 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9662
9663         * symfile.c (find_separate_debug_file): Use canonical path of
9664         sysroot with child_path instead of gdb_sysroot if it is valid.
9665
9666 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9667
9668         * symfile.c (find_separate_debug_file): Use child_path to
9669         determine if an object file is under a sysroot.
9670
9671 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9672
9673         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9674         unittests/child-path-selftests.c.
9675         * common/pathstuff.c (child_path): New function.
9676         * common/pathstuff.h (child_path): New prototype.
9677         * unittests/child-path-selftests.c: New file.
9678
9679 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9680
9681         * symfile.c (find_separate_debug_file): Look for separate debug
9682         files in debug directories under the sysroot.
9683
9684 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9685
9686         * symtab.h (struct minimal_symbol data_p): New const method.
9687         (struct minimal_symbol text_p): Likewise.
9688         * symtab.c (output_source_filename): Use file name style
9689         to print file name.
9690         (print_symbol_info): Likewise.
9691         (print_msymbol_info): Use address style to print addresses.
9692         Use function name style to print executable text symbols.
9693         (expand_symtab_containing_pc): Use data_p.
9694         (find_pc_sect_compunit_symtab): Likewise.
9695
9696 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9697
9698         * breakpoint.c (describe_other_breakpoints): Use address style
9699         to print addresses.
9700         (say_where): Likewise.
9701
9702 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9703
9704         * ada-typeprint.c (print_func_type): Print function name
9705         style to print function name.
9706         * c-typeprint.c (c_print_type_1): Likewise.
9707
9708 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9709
9710         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9711         for execve.
9712
9713 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9714
9715         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9716         type_stack.
9717
9718 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9719
9720         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9721         TYPE_CODE_REF types.
9722
9723 2019-02-08  Jim Wilson  <jimw@sifive.com>
9724
9725         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9726         (riscv_linux_fregset): New.
9727         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9728
9729 2019-02-07  Tom Tromey  <tom@tromey.com>
9730
9731         * thread.c (thread_cancel_execution_command): Update.
9732         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9733         methods.
9734         (struct thread_fsm_ops): Remove.
9735         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9736         (thread_fsm_should_stop, thread_fsm_return_value)
9737         (thread_fsm_set_finished, thread_fsm_finished_p)
9738         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9739         Don't declare.
9740         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9741         * infrun.c (clear_proceed_status_thread)
9742         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9743         (print_stop_event): Update.
9744         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9745         Add constructor.
9746         (step_command_fsm_ops): Remove.
9747         (new_step_command_fsm): Remove.
9748         (step_1): Update.
9749         (step_command_fsm::should_stop): Rename from
9750         step_command_fsm_should_stop.
9751         (step_command_fsm::clean_up): Rename from
9752         step_command_fsm_clean_up.
9753         (step_command_fsm::do_async_reply_reason): Rename from
9754         step_command_fsm_async_reply_reason.
9755         (struct until_next_fsm): Inherit from thread_fsm.  Add
9756         constructor.
9757         (until_next_fsm_ops): Remove.
9758         (new_until_next_fsm): Remove.
9759         (until_next_fsm::should_stop): Rename from
9760         until_next_fsm_should_stop.
9761         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9762         (until_next_fsm::do_async_reply_reason): Rename from
9763         until_next_fsm_async_reply_reason.
9764         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9765         constructor.  Change type of breakpoint.
9766         (finish_command_fsm_ops): Remove.
9767         (new_finish_command_fsm): Remove.
9768         (finish_command_fsm::should_stop): Rename from
9769         finish_command_fsm_should_stop.
9770         (finish_command_fsm::clean_up): Rename from
9771         finish_command_fsm_clean_up.
9772         (finish_command_fsm::return_value): Rename from
9773         finish_command_fsm_return_value.
9774         (finish_command_fsm::do_async_reply_reason): Rename from
9775         finish_command_fsm_async_reply_reason.
9776         (finish_command): Update.
9777         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9778         Add constructor.
9779         (call_thread_fsm_ops): Remove.
9780         (call_thread_fsm::call_thread_fsm): Rename from
9781         new_call_thread_fsm.
9782         (call_thread_fsm::should_stop): Rename from
9783         call_thread_fsm_should_stop.
9784         (call_thread_fsm::should_notify_stop): Rename from
9785         call_thread_fsm_should_notify_stop.
9786         (run_inferior_call, call_function_by_hand_dummy): Update.
9787         * cli/cli-interp.c (should_print_stop_to_console): Update.
9788         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9789         Add constructor.  Change type of location_breakpoint,
9790         caller_breakpoint.
9791         (until_break_fsm_ops): Remove.
9792         (new_until_break_fsm): Remove.
9793         (until_break_fsm::should_stop): Rename from
9794         until_break_fsm_should_stop.
9795         (until_break_fsm::clean_up): Rename from
9796         until_break_fsm_clean_up.
9797         (until_break_fsm::do_async_reply_reason): Rename from
9798         until_break_fsm_async_reply_reason.
9799         (until_break_command): Update.
9800         * thread-fsm.c: Remove.
9801         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9802
9803 2019-02-07  Tom Tromey  <tom@tromey.com>
9804
9805         * yy-remap.h: Add include guard.
9806         * xtensa-tdep.h: Add include guard.
9807         * xcoffread.h: Rename include guard.
9808         * varobj-iter.h: Add include guard.
9809         * tui/tui.h: Rename include guard.
9810         * tui/tui-winsource.h: Rename include guard.
9811         * tui/tui-wingeneral.h: Rename include guard.
9812         * tui/tui-windata.h: Rename include guard.
9813         * tui/tui-win.h: Rename include guard.
9814         * tui/tui-stack.h: Rename include guard.
9815         * tui/tui-source.h: Rename include guard.
9816         * tui/tui-regs.h: Rename include guard.
9817         * tui/tui-out.h: Rename include guard.
9818         * tui/tui-layout.h: Rename include guard.
9819         * tui/tui-io.h: Rename include guard.
9820         * tui/tui-hooks.h: Rename include guard.
9821         * tui/tui-file.h: Rename include guard.
9822         * tui/tui-disasm.h: Rename include guard.
9823         * tui/tui-data.h: Rename include guard.
9824         * tui/tui-command.h: Rename include guard.
9825         * tic6x-tdep.h: Add include guard.
9826         * target/waitstatus.h: Rename include guard.
9827         * target/wait.h: Rename include guard.
9828         * target/target.h: Rename include guard.
9829         * target/resume.h: Rename include guard.
9830         * target-float.h: Rename include guard.
9831         * stabsread.h: Add include guard.
9832         * rs6000-tdep.h: Add include guard.
9833         * riscv-fbsd-tdep.h: Add include guard.
9834         * regformats/regdef.h: Rename include guard.
9835         * record.h: Rename include guard.
9836         * python/python.h: Rename include guard.
9837         * python/python-internal.h: Rename include guard.
9838         * python/py-stopevent.h: Rename include guard.
9839         * python/py-ref.h: Rename include guard.
9840         * python/py-record.h: Rename include guard.
9841         * python/py-record-full.h: Rename include guard.
9842         * python/py-record-btrace.h: Rename include guard.
9843         * python/py-instruction.h: Rename include guard.
9844         * python/py-events.h: Rename include guard.
9845         * python/py-event.h: Rename include guard.
9846         * procfs.h: Add include guard.
9847         * proc-utils.h: Add include guard.
9848         * p-lang.h: Add include guard.
9849         * or1k-tdep.h: Rename include guard.
9850         * observable.h: Rename include guard.
9851         * nto-tdep.h: Rename include guard.
9852         * nat/x86-linux.h: Rename include guard.
9853         * nat/x86-linux-dregs.h: Rename include guard.
9854         * nat/x86-gcc-cpuid.h: Add include guard.
9855         * nat/x86-dregs.h: Rename include guard.
9856         * nat/x86-cpuid.h: Rename include guard.
9857         * nat/ppc-linux.h: Rename include guard.
9858         * nat/mips-linux-watch.h: Rename include guard.
9859         * nat/linux-waitpid.h: Rename include guard.
9860         * nat/linux-ptrace.h: Rename include guard.
9861         * nat/linux-procfs.h: Rename include guard.
9862         * nat/linux-osdata.h: Rename include guard.
9863         * nat/linux-nat.h: Rename include guard.
9864         * nat/linux-namespaces.h: Rename include guard.
9865         * nat/linux-btrace.h: Rename include guard.
9866         * nat/glibc_thread_db.h: Rename include guard.
9867         * nat/gdb_thread_db.h: Rename include guard.
9868         * nat/gdb_ptrace.h: Rename include guard.
9869         * nat/fork-inferior.h: Rename include guard.
9870         * nat/amd64-linux-siginfo.h: Rename include guard.
9871         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9872         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9873         * nat/aarch64-linux.h: Rename include guard.
9874         * nat/aarch64-linux-hw-point.h: Rename include guard.
9875         * mn10300-tdep.h: Add include guard.
9876         * mips-linux-tdep.h: Add include guard.
9877         * mi/mi-parse.h: Rename include guard.
9878         * mi/mi-out.h: Rename include guard.
9879         * mi/mi-main.h: Rename include guard.
9880         * mi/mi-interp.h: Rename include guard.
9881         * mi/mi-getopt.h: Rename include guard.
9882         * mi/mi-console.h: Rename include guard.
9883         * mi/mi-common.h: Rename include guard.
9884         * mi/mi-cmds.h: Rename include guard.
9885         * mi/mi-cmd-break.h: Rename include guard.
9886         * m2-lang.h: Add include guard.
9887         * location.h: Rename include guard.
9888         * linux-record.h: Rename include guard.
9889         * linux-nat.h: Add include guard.
9890         * linux-fork.h: Add include guard.
9891         * i386-darwin-tdep.h: Rename include guard.
9892         * hppa-linux-offsets.h: Add include guard.
9893         * guile/guile.h: Rename include guard.
9894         * guile/guile-internal.h: Rename include guard.
9895         * gnu-nat.h: Rename include guard.
9896         * gdb-stabs.h: Rename include guard.
9897         * frv-tdep.h: Add include guard.
9898         * f-lang.h: Add include guard.
9899         * event-loop.h: Add include guard.
9900         * darwin-nat.h: Rename include guard.
9901         * cp-abi.h: Rename include guard.
9902         * config/sparc/nm-sol2.h: Rename include guard.
9903         * config/nm-nto.h: Rename include guard.
9904         * config/nm-linux.h: Add include guard.
9905         * config/i386/nm-i386gnu.h: Rename include guard.
9906         * config/djgpp/nl_types.h: Rename include guard.
9907         * config/djgpp/langinfo.h: Rename include guard.
9908         * compile/gcc-cp-plugin.h: Add include guard.
9909         * compile/gcc-c-plugin.h: Add include guard.
9910         * compile/compile.h: Rename include guard.
9911         * compile/compile-object-run.h: Rename include guard.
9912         * compile/compile-object-load.h: Rename include guard.
9913         * compile/compile-internal.h: Rename include guard.
9914         * compile/compile-cplus.h: Rename include guard.
9915         * compile/compile-c.h: Rename include guard.
9916         * common/xml-utils.h: Rename include guard.
9917         * common/x86-xstate.h: Rename include guard.
9918         * common/version.h: Rename include guard.
9919         * common/vec.h: Rename include guard.
9920         * common/tdesc.h: Rename include guard.
9921         * common/selftest.h: Rename include guard.
9922         * common/scoped_restore.h: Rename include guard.
9923         * common/scoped_mmap.h: Rename include guard.
9924         * common/scoped_fd.h: Rename include guard.
9925         * common/safe-iterator.h: Rename include guard.
9926         * common/run-time-clock.h: Rename include guard.
9927         * common/refcounted-object.h: Rename include guard.
9928         * common/queue.h: Rename include guard.
9929         * common/ptid.h: Rename include guard.
9930         * common/print-utils.h: Rename include guard.
9931         * common/preprocessor.h: Rename include guard.
9932         * common/pathstuff.h: Rename include guard.
9933         * common/observable.h: Rename include guard.
9934         * common/netstuff.h: Rename include guard.
9935         * common/job-control.h: Rename include guard.
9936         * common/host-defs.h: Rename include guard.
9937         * common/gdb_wait.h: Rename include guard.
9938         * common/gdb_vecs.h: Rename include guard.
9939         * common/gdb_unlinker.h: Rename include guard.
9940         * common/gdb_unique_ptr.h: Rename include guard.
9941         * common/gdb_tilde_expand.h: Rename include guard.
9942         * common/gdb_sys_time.h: Rename include guard.
9943         * common/gdb_string_view.h: Rename include guard.
9944         * common/gdb_splay_tree.h: Rename include guard.
9945         * common/gdb_setjmp.h: Rename include guard.
9946         * common/gdb_ref_ptr.h: Rename include guard.
9947         * common/gdb_optional.h: Rename include guard.
9948         * common/gdb_locale.h: Rename include guard.
9949         * common/gdb_assert.h: Rename include guard.
9950         * common/filtered-iterator.h: Rename include guard.
9951         * common/filestuff.h: Rename include guard.
9952         * common/fileio.h: Rename include guard.
9953         * common/environ.h: Rename include guard.
9954         * common/common-utils.h: Rename include guard.
9955         * common/common-types.h: Rename include guard.
9956         * common/common-regcache.h: Rename include guard.
9957         * common/common-inferior.h: Rename include guard.
9958         * common/common-gdbthread.h: Rename include guard.
9959         * common/common-exceptions.h: Rename include guard.
9960         * common/common-defs.h: Rename include guard.
9961         * common/common-debug.h: Rename include guard.
9962         * common/cleanups.h: Rename include guard.
9963         * common/buffer.h: Rename include guard.
9964         * common/btrace-common.h: Rename include guard.
9965         * common/break-common.h: Rename include guard.
9966         * cli/cli-utils.h: Rename include guard.
9967         * cli/cli-style.h: Rename include guard.
9968         * cli/cli-setshow.h: Rename include guard.
9969         * cli/cli-script.h: Rename include guard.
9970         * cli/cli-interp.h: Rename include guard.
9971         * cli/cli-decode.h: Rename include guard.
9972         * cli/cli-cmds.h: Rename include guard.
9973         * charset-list.h: Add include guard.
9974         * buildsym-legacy.h: Rename include guard.
9975         * bfin-tdep.h: Add include guard.
9976         * ax.h: Rename include guard.
9977         * arm-linux-tdep.h: Add include guard.
9978         * arm-fbsd-tdep.h: Add include guard.
9979         * arch/xtensa.h: Rename include guard.
9980         * arch/tic6x.h: Add include guard.
9981         * arch/i386.h: Add include guard.
9982         * arch/arm.h: Rename include guard.
9983         * arch/arm-linux.h: Rename include guard.
9984         * arch/arm-get-next-pcs.h: Rename include guard.
9985         * arch/amd64.h: Add include guard.
9986         * arch/aarch64-insn.h: Rename include guard.
9987         * arch-utils.h: Rename include guard.
9988         * annotate.h: Add include guard.
9989         * amd64-darwin-tdep.h: Rename include guard.
9990         * aarch64-linux-tdep.h: Add include guard.
9991         * aarch64-fbsd-tdep.h: Add include guard.
9992         * aarch32-linux-nat.h: Add include guard.
9993
9994 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9995
9996         * macrotab.c (macro_define_internal): New function that
9997         factorizes macro_define_object_internal and macro_define_function
9998         code.
9999         (macro_define_object_internal): Use macro_define_internal.
10000         (macro_define_function): Likewise.
10001
10002 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10003
10004         * macrocmd.c (extract_identifier): Return
10005         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10006         callers.
10007
10008 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10009
10010         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10011
10012 2019-02-05  Tom Tromey  <tom@tromey.com>
10013
10014         * target.c (target_stack::unpush): Move assertion earlier.
10015
10016 2019-01-30  Tom Tromey  <tom@tromey.com>
10017
10018         PR python/23615:
10019         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10020         (gdbpy_parse_and_eval): Likewise.
10021         * python/python-internal.h (gdbpy_allow_threads): New class.
10022
10023 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10024
10025         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10026         (aarch64_fbsd_fpregmap): Move earlier.
10027         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10028         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10029         instead of individual calls to trad_frame_set_reg_addr.
10030         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10031         earlier.
10032         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10033         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10034         instead of individual calls to trad_frame_set_reg_addr.
10035
10036 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10037
10038         * CONTRIBUTE: Replace contribution list with wiki link.
10039
10040 2019-01-25  Tom Tromey  <tom@tromey.com>
10041
10042         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10043
10044 2019-01-25  Tom Tromey  <tom@tromey.com>
10045
10046         * xtensa-linux-nat.c: Fix common/ includes.
10047         * xml-support.h: Fix common/ includes.
10048         * xml-support.c: Fix common/ includes.
10049         * x86-linux-nat.c: Fix common/ includes.
10050         * windows-nat.c: Fix common/ includes.
10051         * varobj.h: Fix common/ includes.
10052         * varobj.c: Fix common/ includes.
10053         * value.c: Fix common/ includes.
10054         * valops.c: Fix common/ includes.
10055         * utils.c: Fix common/ includes.
10056         * unittests/xml-utils-selftests.c: Fix common/ includes.
10057         * unittests/utils-selftests.c: Fix common/ includes.
10058         * unittests/unpack-selftests.c: Fix common/ includes.
10059         * unittests/tracepoint-selftests.c: Fix common/ includes.
10060         * unittests/style-selftests.c: Fix common/ includes.
10061         * unittests/string_view-selftests.c: Fix common/ includes.
10062         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10063         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10064         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10065         * unittests/rsp-low-selftests.c: Fix common/ includes.
10066         * unittests/parse-connection-spec-selftests.c: Fix common/
10067         includes.
10068         * unittests/optional-selftests.c: Fix common/ includes.
10069         * unittests/offset-type-selftests.c: Fix common/ includes.
10070         * unittests/observable-selftests.c: Fix common/ includes.
10071         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10072         * unittests/memrange-selftests.c: Fix common/ includes.
10073         * unittests/memory-map-selftests.c: Fix common/ includes.
10074         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10075         * unittests/function-view-selftests.c: Fix common/ includes.
10076         * unittests/environ-selftests.c: Fix common/ includes.
10077         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10078         * unittests/common-utils-selftests.c: Fix common/ includes.
10079         * unittests/cli-utils-selftests.c: Fix common/ includes.
10080         * unittests/array-view-selftests.c: Fix common/ includes.
10081         * ui-file.c: Fix common/ includes.
10082         * tui/tui-io.c: Fix common/ includes.
10083         * tracepoint.h: Fix common/ includes.
10084         * tracepoint.c: Fix common/ includes.
10085         * tracefile-tfile.c: Fix common/ includes.
10086         * top.h: Fix common/ includes.
10087         * top.c: Fix common/ includes.
10088         * thread.c: Fix common/ includes.
10089         * target/waitstatus.h: Fix common/ includes.
10090         * target/waitstatus.c: Fix common/ includes.
10091         * target.h: Fix common/ includes.
10092         * target.c: Fix common/ includes.
10093         * target-memory.c: Fix common/ includes.
10094         * target-descriptions.c: Fix common/ includes.
10095         * symtab.h: Fix common/ includes.
10096         * symfile.c: Fix common/ includes.
10097         * stap-probe.c: Fix common/ includes.
10098         * spu-linux-nat.c: Fix common/ includes.
10099         * sparc-nat.c: Fix common/ includes.
10100         * source.c: Fix common/ includes.
10101         * solib.c: Fix common/ includes.
10102         * solib-target.c: Fix common/ includes.
10103         * ser-unix.c: Fix common/ includes.
10104         * ser-tcp.c: Fix common/ includes.
10105         * ser-pipe.c: Fix common/ includes.
10106         * ser-base.c: Fix common/ includes.
10107         * selftest-arch.c: Fix common/ includes.
10108         * s12z-tdep.c: Fix common/ includes.
10109         * rust-exp.y: Fix common/ includes.
10110         * rs6000-aix-tdep.c: Fix common/ includes.
10111         * riscv-tdep.c: Fix common/ includes.
10112         * remote.c: Fix common/ includes.
10113         * remote-notif.h: Fix common/ includes.
10114         * remote-fileio.h: Fix common/ includes.
10115         * remote-fileio.c: Fix common/ includes.
10116         * regcache.h: Fix common/ includes.
10117         * regcache.c: Fix common/ includes.
10118         * record-btrace.c: Fix common/ includes.
10119         * python/python.c: Fix common/ includes.
10120         * python/py-type.c: Fix common/ includes.
10121         * python/py-inferior.c: Fix common/ includes.
10122         * progspace.h: Fix common/ includes.
10123         * producer.c: Fix common/ includes.
10124         * procfs.c: Fix common/ includes.
10125         * proc-api.c: Fix common/ includes.
10126         * printcmd.c: Fix common/ includes.
10127         * ppc-linux-nat.c: Fix common/ includes.
10128         * parser-defs.h: Fix common/ includes.
10129         * osdata.c: Fix common/ includes.
10130         * obsd-nat.c: Fix common/ includes.
10131         * nat/x86-linux.c: Fix common/ includes.
10132         * nat/x86-linux-dregs.c: Fix common/ includes.
10133         * nat/x86-dregs.h: Fix common/ includes.
10134         * nat/x86-dregs.c: Fix common/ includes.
10135         * nat/ppc-linux.c: Fix common/ includes.
10136         * nat/mips-linux-watch.h: Fix common/ includes.
10137         * nat/mips-linux-watch.c: Fix common/ includes.
10138         * nat/linux-waitpid.c: Fix common/ includes.
10139         * nat/linux-ptrace.h: Fix common/ includes.
10140         * nat/linux-ptrace.c: Fix common/ includes.
10141         * nat/linux-procfs.c: Fix common/ includes.
10142         * nat/linux-personality.c: Fix common/ includes.
10143         * nat/linux-osdata.c: Fix common/ includes.
10144         * nat/linux-namespaces.c: Fix common/ includes.
10145         * nat/linux-btrace.h: Fix common/ includes.
10146         * nat/linux-btrace.c: Fix common/ includes.
10147         * nat/fork-inferior.c: Fix common/ includes.
10148         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10149         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10150         * nat/aarch64-linux.c: Fix common/ includes.
10151         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10152         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10153         * namespace.h: Fix common/ includes.
10154         * mips-linux-tdep.c: Fix common/ includes.
10155         * minsyms.c: Fix common/ includes.
10156         * mi/mi-parse.h: Fix common/ includes.
10157         * mi/mi-main.c: Fix common/ includes.
10158         * mi/mi-cmd-env.c: Fix common/ includes.
10159         * memrange.h: Fix common/ includes.
10160         * memattr.c: Fix common/ includes.
10161         * maint.h: Fix common/ includes.
10162         * maint.c: Fix common/ includes.
10163         * main.c: Fix common/ includes.
10164         * machoread.c: Fix common/ includes.
10165         * location.c: Fix common/ includes.
10166         * linux-thread-db.c: Fix common/ includes.
10167         * linux-nat.c: Fix common/ includes.
10168         * linux-fork.c: Fix common/ includes.
10169         * inline-frame.c: Fix common/ includes.
10170         * infrun.c: Fix common/ includes.
10171         * inflow.c: Fix common/ includes.
10172         * inferior.h: Fix common/ includes.
10173         * inferior.c: Fix common/ includes.
10174         * infcmd.c: Fix common/ includes.
10175         * inf-ptrace.c: Fix common/ includes.
10176         * inf-child.c: Fix common/ includes.
10177         * ia64-linux-nat.c: Fix common/ includes.
10178         * i387-tdep.c: Fix common/ includes.
10179         * i386-tdep.c: Fix common/ includes.
10180         * i386-linux-tdep.c: Fix common/ includes.
10181         * i386-linux-nat.c: Fix common/ includes.
10182         * i386-go32-tdep.c: Fix common/ includes.
10183         * i386-fbsd-tdep.c: Fix common/ includes.
10184         * i386-fbsd-nat.c: Fix common/ includes.
10185         * guile/scm-type.c: Fix common/ includes.
10186         * guile/guile.c: Fix common/ includes.
10187         * go32-nat.c: Fix common/ includes.
10188         * gnu-nat.c: Fix common/ includes.
10189         * gdbthread.h: Fix common/ includes.
10190         * gdbarch-selftests.c: Fix common/ includes.
10191         * gdb_usleep.c: Fix common/ includes.
10192         * gdb_select.h: Fix common/ includes.
10193         * gdb_bfd.c: Fix common/ includes.
10194         * gcore.c: Fix common/ includes.
10195         * fork-child.c: Fix common/ includes.
10196         * findvar.c: Fix common/ includes.
10197         * fbsd-nat.c: Fix common/ includes.
10198         * event-top.c: Fix common/ includes.
10199         * event-loop.c: Fix common/ includes.
10200         * dwarf2read.c: Fix common/ includes.
10201         * dwarf2loc.c: Fix common/ includes.
10202         * dwarf2-frame.c: Fix common/ includes.
10203         * dwarf-index-cache.c: Fix common/ includes.
10204         * dtrace-probe.c: Fix common/ includes.
10205         * disasm-selftests.c: Fix common/ includes.
10206         * defs.h: Fix common/ includes.
10207         * csky-tdep.c: Fix common/ includes.
10208         * cp-valprint.c: Fix common/ includes.
10209         * cp-support.h: Fix common/ includes.
10210         * cp-support.c: Fix common/ includes.
10211         * corelow.c: Fix common/ includes.
10212         * completer.h: Fix common/ includes.
10213         * completer.c: Fix common/ includes.
10214         * compile/compile.c: Fix common/ includes.
10215         * compile/compile-loc2c.c: Fix common/ includes.
10216         * compile/compile-cplus-types.c: Fix common/ includes.
10217         * compile/compile-cplus-symbols.c: Fix common/ includes.
10218         * command.h: Fix common/ includes.
10219         * cli/cli-dump.c: Fix common/ includes.
10220         * cli/cli-cmds.c: Fix common/ includes.
10221         * charset.c: Fix common/ includes.
10222         * build-id.c: Fix common/ includes.
10223         * btrace.h: Fix common/ includes.
10224         * btrace.c: Fix common/ includes.
10225         * breakpoint.h: Fix common/ includes.
10226         * breakpoint.c: Fix common/ includes.
10227         * ax.h:
10228         (enum agent_op): Fix common/ includes.
10229         * ax-general.c (struct aop_map): Fix common/ includes.
10230         * ax-gdb.c: Fix common/ includes.
10231         * auxv.c: Fix common/ includes.
10232         * auto-load.c: Fix common/ includes.
10233         * arm-tdep.c: Fix common/ includes.
10234         * arch/riscv.c: Fix common/ includes.
10235         * arch/ppc-linux-common.c: Fix common/ includes.
10236         * arch/i386.c: Fix common/ includes.
10237         * arch/arm.c: Fix common/ includes.
10238         * arch/arm-linux.c: Fix common/ includes.
10239         * arch/arm-get-next-pcs.c: Fix common/ includes.
10240         * arch/amd64.c: Fix common/ includes.
10241         * arch/aarch64.c: Fix common/ includes.
10242         * arch/aarch64-insn.c: Fix common/ includes.
10243         * arch-utils.c: Fix common/ includes.
10244         * amd64-windows-tdep.c: Fix common/ includes.
10245         * amd64-tdep.c: Fix common/ includes.
10246         * amd64-sol2-tdep.c: Fix common/ includes.
10247         * amd64-obsd-tdep.c: Fix common/ includes.
10248         * amd64-nbsd-tdep.c: Fix common/ includes.
10249         * amd64-linux-tdep.c: Fix common/ includes.
10250         * amd64-linux-nat.c: Fix common/ includes.
10251         * amd64-fbsd-tdep.c: Fix common/ includes.
10252         * amd64-fbsd-nat.c: Fix common/ includes.
10253         * amd64-dicos-tdep.c: Fix common/ includes.
10254         * amd64-darwin-tdep.c: Fix common/ includes.
10255         * agent.c: Fix common/ includes.
10256         * ada-lang.h: Fix common/ includes.
10257         * ada-lang.c: Fix common/ includes.
10258         * aarch64-tdep.c: Fix common/ includes.
10259
10260 2019-01-25  Tom Tromey  <tom@tromey.com>
10261
10262         * common/create-version.sh: Use common/version.h.
10263
10264 2019-01-24  Pedro Alves  <palves@redhat.com>
10265
10266         * infrun.c (signal_stop, signal_print, signal_program)
10267         (signal_catch, signal_pass): Now arrays instead of pointers.
10268         (update_signals_program_target, do_target_resume)
10269         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10270         * linux-nat.c (linux_nat_target::pass_signals)
10271         (linux_nat_target::create_inferior, linux_nat_target::attach):
10272         Adjust.
10273         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10274         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10275         * procfs.c (procfs_target::pass_signals): Adjust.
10276         * record-full.c (record_full_target::resume): Adjust.
10277         * remote.c (remote_target::pass_signals)
10278         (remote_target::program_signals): Adjust.
10279         * target-debug.h (target_debug_print_signals): Now takes a
10280         gdb::array_view as parameter.  Adjust.
10281         * target.h (target_ops) <pass_signals, program_signals>: Replace
10282         pointer and length parameters with gdb::array_view.
10283         (target_pass_signals, target_program_signals): Likewise.
10284         * target-delegates.c: Regenerate.
10285
10286 2019-01-24  Pedro Alves  <palves@redhat.com>
10287
10288         * common/forward-scope-exit.h
10289         (forward_scope_exit::forward_scope_exit): Pass arguments to
10290         m_bind_function directly, instead of creating a std::bind and
10291         copying that.
10292
10293 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10294
10295         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10296         for static members.
10297         (pass_in_v_vfp_candidate): Likewise.
10298
10299 2019-01-23  Tom Tromey  <tom@tromey.com>
10300             Pedro Alves  <palves@redhat.com>
10301
10302         * regcache.c (class regcache_invalidator): Remove.
10303         (regcache::raw_write): Use make_scope_exit.
10304
10305 2019-01-23  Tom Tromey  <tom@tromey.com>
10306
10307         * ui-out.h (class ui_out_emit_type): Update comment.
10308
10309 2019-01-23  Tom Tromey  <tom@tromey.com>
10310
10311         * infrun.c (fetch_inferior_event): Update comment.
10312
10313 2019-01-23  Tom Tromey  <tom@tromey.com>
10314             Pedro Alves  <palves@redhat.com>
10315
10316         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10317         parameter.
10318         (fetch_inferior_event): Use SCOPE_EXIT.
10319
10320
10321 2019-01-23  Tom Tromey  <tom@tromey.com>
10322             Pedro Alves  <palves@redhat.com>
10323
10324         * infrun.c (disable_thread_events): Delete.
10325         (stop_all_threads): Use SCOPE_EXIT.
10326
10327 2019-01-23  Tom Tromey  <tom@tromey.com>
10328             Pedro Alves  <palves@redhat.com>
10329
10330         * symfile.c: Include forward-scope-exit.h.
10331         (clear_symtab_users_cleanup): Replace forward declaration with
10332         a FORWARD_SCOPE_EXIT.
10333         (syms_from_objfile_1): Use the forward_scope_exit and
10334         gdb::optional instead of cleanup_function.
10335         (reread_symbols): Use the forward_scope_exit instead of
10336         cleanup_function.
10337         (clear_symtab_users_cleanup): Remove function.
10338
10339 2019-01-23  Tom Tromey  <tom@tromey.com>
10340             Pedro Alves  <palves@redhat.com>
10341
10342         * linux-nat.c: Include scope-exit.h.
10343         (cleanup_target_stop): Remove.
10344         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10345         SCOPE_EXIT.
10346
10347 2019-01-23  Tom Tromey  <tom@tromey.com>
10348             Pedro Alves  <palves@redhat.com>
10349
10350         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10351         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10352
10353 2019-01-23  Tom Tromey  <tom@tromey.com>
10354             Andrew Burgess  <andrew.burgess@embecosm.com>
10355             Pedro Alves  <palves@redhat.com>
10356
10357         * infrun.c (fetch_inferior_event): Use scope_exit.
10358         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10359         * top.c (execute_command): Use scope_exit.
10360         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10361         * utils.c (do_bpstat_clear_actions_cleanup)
10362         (make_bpstat_clear_actions_cleanup): Remove.
10363
10364 2019-01-23  Tom Tromey  <tom@tromey.com>
10365             Pedro Alves  <palves@redhat.com>
10366
10367         * infrun.c: Include "common/scope-exit.h"
10368         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10369         (wait_for_inferior): Use SCOPE_EXIT.
10370         (fetch_inferior_event): Use scope_exit.
10371
10372 2019-01-23  Tom Tromey  <tom@tromey.com>
10373             Pedro Alves  <palves@redhat.com>
10374
10375         * breakpoint.c (create_breakpoint): Remove cleanup.
10376
10377 2019-01-23  Tom Tromey  <tom@tromey.com>
10378             Andrew Burgess  <andrew.burgess@embecosm.com>
10379             Pedro Alves  <palves@redhat.com>
10380
10381 2019-01-23  Pedro Alves  <palves@redhat.com>
10382
10383         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10384
10385 2019-01-23  Pedro Alves  <palves@redhat.com>
10386             Andrew Burgess  <andrew.burgess@embecosm.com>
10387
10388         * gdbthread.h: Include "common/forward-scope-exit.h".
10389         (scoped_finish_thread_state): Redefine custom class in terms of
10390         forward_scope_exit.
10391
10392 2019-01-23  Pedro Alves  <palves@redhat.com>
10393             Andrew Burgess  <andrew.burgess@embecosm.com>
10394
10395         * common/forward-scope-exit.h: New file.
10396
10397 2019-01-23  Pedro Alves  <palves@redhat.com>
10398             Andrew Burgess  <andrew.burgess@embecosm.com>
10399             Tom Tromey  <tom@tromey.com>
10400
10401         * common/scope-exit.h: New file.
10402
10403 2019-01-23  Pedro Alves  <palves@redhat.com>
10404
10405         * common/preprocessor.h (ESC): Rename to ...
10406         (ESC_PARENS): ... this.
10407         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10408         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10409
10410 2019-01-23  Tom Tromey  <tom@tromey.com>
10411
10412         * language.h (class scoped_switch_to_sym_language_if_auto):
10413         Initialize m_lang in both cases.
10414
10415 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10416
10417         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10418         with XCNEW.
10419
10420 2019-01-22  Tom Tromey  <tom@tromey.com>
10421
10422         * corelow.c: Do not include sys/file.h.
10423
10424 2019-01-22  Tom Tromey  <tom@tromey.com>
10425
10426         * tui/tui-wingeneral.h: Include gdb_curses.h.
10427
10428 2019-01-22  Tom Tromey  <tom@tromey.com>
10429
10430         * source-cache.h (class source_cache) <get_source_lines,
10431         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10432
10433 2019-01-22  Tom Tromey  <tom@tromey.com>
10434
10435         * remote-fileio.h (struct remote_target): Declare.
10436
10437 2019-01-22  Tom Tromey  <tom@tromey.com>
10438
10439         * python/py-arch.c: Do not include py-ref.h.
10440         * python/py-bpevent.c: Do not include py-ref.h.
10441         * python/py-cmd.c: Do not include py-ref.h.
10442         * python/py-continueevent.c: Do not include py-ref.h.
10443         * python/py-event.h: Do not include py-ref.h.
10444         * python/py-evtregistry.c: Do not include py-ref.h.
10445         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10446         * python/py-frame.c: Do not include py-ref.h.
10447         * python/py-framefilter.c: Do not include py-ref.h.
10448         * python/py-function.c: Do not include py-ref.h.
10449         * python/py-infevents.c: Do not include py-ref.h.
10450         * python/py-linetable.c: Do not include py-ref.h.
10451         * python/py-objfile.c: Do not include py-ref.h.
10452         * python/py-param.c: Do not include py-ref.h.
10453         * python/py-prettyprint.c: Do not include py-ref.h.
10454         * python/py-progspace.c: Do not include py-ref.h.
10455         * python/py-symbol.c: Do not include py-ref.h.
10456         * python/py-symtab.c: Do not include py-ref.h.
10457         * python/py-type.c: Do not include py-ref.h.
10458         * python/py-unwind.c: Do not include py-ref.h.
10459         * python/py-utils.c: Do not include py-ref.h.
10460         * python/py-value.c: Do not include py-ref.h.
10461         * python/py-varobj.c: Do not include py-ref.h.
10462         * python/py-xmethods.c: Do not include py-ref.h.
10463         * python/python.c: Do not include py-ref.h.
10464         * varobj.c: Do not include py-ref.h.
10465
10466 2019-01-22  Tom Tromey  <tom@tromey.com>
10467
10468         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10469         keyword for bcache.
10470
10471 2019-01-22  Tom Tromey  <tom@tromey.com>
10472
10473         * compile/compile-cplus-types.c: Remove a comment by #include.
10474
10475 2019-01-22  Tom Tromey  <tom@tromey.com>
10476
10477         * compile/gcc-c-plugin.h: Include compile-internal.h.
10478
10479 2019-01-22  Tom Tromey  <tom@tromey.com>
10480
10481         * stabsread.c (EXTERN): Do not define.
10482         (symnum, next_symbol_text_func, processing_gcc_compilation)
10483         (within_function, global_sym_chain, global_stabs)
10484         (previous_stab_code, this_object_header_files)
10485         (n_this_object_header_files)
10486         (n_allocated_this_object_header_files): Define.
10487         * stabsread.h (EXTERN): Never define.  Use "extern".
10488
10489 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10490
10491         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10492         history_value.
10493
10494 2019-01-21  Tom Tromey  <tom@tromey.com>
10495
10496         * ui-out.c: Fix includes.
10497         * tui/tui-source.c: Fix includes.
10498         * target.c: Fix includes.
10499         * remote.c: Fix includes.
10500         * regcache.c: Fix includes.
10501         * python/py-block.c: Fix includes.
10502         * printcmd.c: Fix includes.
10503         * or1k-tdep.c: Fix includes.
10504         * mi/mi-main.c: Fix includes.
10505         * m32r-tdep.c: Fix includes.
10506         * csky-tdep.c: Fix includes.
10507         * compile/compile-cplus-types.c: Fix includes.
10508         * cli/cli-interp.c: Fix includes.
10509
10510 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10511
10512         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10513         for padding.
10514
10515 2019-01-16  Tom Tromey  <tom@tromey.com>
10516
10517         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10518         earlier.
10519         (struct objfile) <msymbols_range>: Move from top level.
10520         <msymbols>: New method.
10521         (class objfile_msymbols): Remove.
10522         * symtab.c (default_collect_symbol_completion_matches_break_on):
10523         Update.
10524         * symmisc.c (dump_msymbols): Update.
10525         * stabsread.c (scan_file_globals): Update.
10526         * objc-lang.c (info_selectors_command, info_classes_command)
10527         (find_methods): Update.
10528         * minsyms.c (find_solib_trampoline_target): Update.
10529         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10530         * coffread.c (coff_symfile_read): Update.
10531         * ada-lang.c (ada_lookup_simple_minsym)
10532         (ada_collect_symbol_completion_matches): Update.
10533
10534 2019-01-16  Tom Tromey  <tom@tromey.com>
10535
10536         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10537         type.  Remove no-argument constructor.
10538         <iterator::operator++>: Simplify.
10539         <begin>: Update.
10540         <end>: Use minimal_symbol_count.
10541
10542 2019-01-16  Tom Tromey  <tom@tromey.com>
10543
10544         * objfiles.h (struct objfile) <psymtabs>: New method.
10545         (class objfile_psymtabs): Remove.
10546         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10547         typedef.
10548         <range>: New method.
10549         (require_partial_symbols): Change return type.
10550         * psymtab.c (require_partial_symbols)
10551         (psym_expand_symtabs_matching): Update.
10552         * mdebugread.c (parse_partial_symbols): Update.
10553         * dbxread.c (dbx_end_psymtab): Update.
10554
10555 2019-01-15  Tom Tromey  <tom@tromey.com>
10556
10557         * symtab.c (lookup_objfile_from_block)
10558         (lookup_symbol_in_objfile_symtabs)
10559         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10560         (find_line_symtab, info_sources_command)
10561         (default_collect_symbol_completion_matches_break_on)
10562         (make_source_files_completion_list): Update.
10563         * symmisc.c (print_objfile_statistics, dump_objfile)
10564         (maintenance_print_symbols, maintenance_info_symtabs)
10565         (maintenance_check_symtabs, maintenance_info_line_tables):
10566         Update.
10567         * source.c (select_source_symtab)
10568         (forget_cached_source_info_for_objfile): Update.
10569         * objfiles.h (class objfile_compunits): Remove.
10570         (struct objfile) <compunits_range>: New typedef.
10571         (compunits): New method.
10572         * objfiles.c (objfile_relocate1): Update.
10573         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10574         * maint.c (count_symtabs_and_blocks): Update.
10575         * linespec.c (iterate_over_all_matching_symtabs): Update.
10576         * cp-support.c (add_symbol_overload_list_qualified): Update.
10577         * coffread.c (coff_symtab_read): Update.
10578         * ada-lang.c (add_nonlocal_symbols)
10579         (ada_collect_symbol_completion_matches)
10580         (ada_add_global_exceptions): Update.
10581
10582 2019-01-15  Tom Tromey  <tom@tromey.com>
10583
10584         * progspace.h (program_space) <objfiles_safe_range>: New
10585         typedef.
10586         <objfiles_safe>: New method.
10587         * objfiles.h (class all_objfiles_safe): Remove.
10588         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10589         * jit.c (jit_inferior_exit_hook): Update.
10590
10591 2019-01-17  Tom Tromey  <tom@tromey.com>
10592
10593         * progspace.h (program_space) <objfiles_range>: New typedef.
10594         <objfiles>: New method.
10595         <objfiles_head>: Rename from objfiles.
10596         (object_files): Update.
10597         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10598         * guile/scm-pretty-print.c
10599         (ppscm_find_pretty_printer_from_objfiles): Update.
10600         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10601         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10602         Update.
10603         * python/py-progspace.c (pspy_get_objfiles): Update.
10604         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10605         Update.
10606         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10607         (objfpy_lookup_objfile_by_build_id): Update.
10608         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10609         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10610         Update.
10611         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10612         (expand_symtab_containing_pc, lookup_objfile_from_block)
10613         (lookup_static_symbol, basic_lookup_transparent_type)
10614         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10615         (find_line_symtab, info_sources_command)
10616         (default_collect_symbol_completion_matches_break_on)
10617         (make_source_files_completion_list, find_main_name): Update.
10618         * symmisc.c (print_symbol_bcache_statistics)
10619         (print_objfile_statistics, maintenance_print_symbols)
10620         (maintenance_print_msymbols, maintenance_print_objfiles)
10621         (maintenance_info_symtabs, maintenance_check_symtabs)
10622         (maintenance_expand_symtabs, maintenance_info_line_tables):
10623         Update.
10624         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10625         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10626         (map_overlay_command, unmap_overlay_command)
10627         (simple_overlay_update, expand_symtabs_matching)
10628         (map_symbol_filenames): Update.
10629         * symfile-debug.c (set_debug_symfile): Update.
10630         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10631         Update.
10632         * source.c (select_source_symtab, forget_cached_source_info):
10633         Update.
10634         * solib.c (solib_read_symbols): Update.
10635         * solib-spu.c (append_ocl_sos): Update.
10636         * psymtab.c (maintenance_print_psymbols)
10637         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10638         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10639         * printcmd.c (info_symbol_command): Update.
10640         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10641         Update.
10642         * objfiles.h (class all_objfiles): Remove.
10643         * objfiles.c (have_partial_symbols, have_full_symbols)
10644         (have_minimal_symbols, qsort_cmp, update_section_map)
10645         (shared_objfile_contains_address_p)
10646         (default_iterate_over_objfiles_in_search_order): Update.
10647         * objc-lang.c (info_selectors_command, info_classes_command)
10648         (find_methods): Update.
10649         * minsyms.c (find_solib_trampoline_target): Update.
10650         * maint.c (maintenance_info_sections)
10651         (maintenance_translate_address, count_symtabs_and_blocks):
10652         Update.
10653         * main.c (captured_main_1): Update.
10654         * linux-thread-db.c (try_thread_db_load_from_pdir)
10655         (has_libpthread): Update.
10656         * linespec.c (iterate_over_all_matching_symtabs)
10657         (search_minsyms_for_name): Update.
10658         * jit.c (jit_find_objf_with_entry_addr): Update.
10659         * hppa-tdep.c (find_unwind_entry)
10660         (hppa_lookup_stub_minimal_symbol): Update.
10661         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10662         Update.
10663         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10664         (elf_gnu_ifunc_resolve_by_got): Update.
10665         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10666         * dwarf-index-write.c (save_gdb_index_command): Update.
10667         * cp-support.c (add_symbol_overload_list_qualified): Update.
10668         * breakpoint.c (create_overlay_event_breakpoint)
10669         (create_longjmp_master_breakpoint)
10670         (create_std_terminate_master_breakpoint)
10671         (create_exception_master_breakpoint): Update.
10672         * blockframe.c (find_pc_partial_function): Update.
10673         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10674         (ada_collect_symbol_completion_matches)
10675         (ada_add_global_exceptions): Update.
10676
10677 2019-01-17  Tom Tromey  <tom@tromey.com>
10678
10679         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10680         declare VEC.
10681         (solib_target_parse_libraries): Change return type.
10682         (library_list_start_segment, library_list_start_section)
10683         (library_list_end_library, library_list_start_library); Update.
10684         (solib_target_free_library_list): Remove.
10685         (solib_target_parse_libraries): Remove cleanup.  Change return
10686         type.
10687         (solib_target_current_sos): Update.
10688
10689 2019-01-17  Tom Tromey  <tromey@bapiya>
10690
10691         * valprint.c: Replace "the the" with "the".
10692         * symtab.c: Replace "the the" with "the".
10693         * solib.c: Replace "the the" with "the".
10694         * solib-dsbt.c: Replace "the the" with "the".
10695         * linespec.c: Replace "the the" with "the".
10696         * dwarf2loc.h: Replace "the the" with "the".
10697         * amd64-windows-tdep.c: Replace "the the" with "the".
10698         * aarch64-tdep.c: Replace "the the" with "the".
10699
10700 2019-01-16  Keith Seitz  <keiths@redhat.com>
10701
10702         PR gdb/23773
10703         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10704         <builder>: Rename to ..
10705         <m_builder>: ... this and make private.
10706         (dwarf2_cu::get_builder): New method.  Change all users of
10707         `builder' to use this method.
10708         (dwarf2_start_symtab): Move to ...
10709         (dwarf2_cu::start_symtab): ... here.  Update all callers
10710         (setup_type_unit_groups): Move to ...
10711         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10712         callers.
10713         (dwarf2_cu::reset_builder): New method.
10714         (process_full_compunit, process_full_type_unit): Use
10715         dwarf2_cu::reset_builder.
10716         (follow_die_offset): Record the ancestor CU if it is different
10717         from the followed DIE's CU.
10718         (follow_die_sig_1): Likewise.
10719
10720 2019-01-15  Tom Tromey  <tom@tromey.com>
10721
10722         * remote.c (class remote_state) <buf>: Now a char_vector.
10723         <buf_size>: Remove.
10724         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10725         parameter.
10726         (remote_target::getpkt_or_notif_sane_1)
10727         (remote_target::getpkt_sane)
10728         (remote_target::getpkt_or_notif_sane): Likewise.
10729         (class remote_target) <putpkt>: New overload.
10730         (remote_target::read_frame): Change type of "buf_p".  Remove
10731         sizeof_p parameter.
10732         (packet_ok): New overload.
10733         (packet_check_result): New overload.
10734         Update all uses.
10735
10736 2019-01-14  Tom Tromey  <tom@tromey.com>
10737
10738         * remote-notif.c (handle_notification, remote_notif_ack)
10739         (remote_notif_parse): Make "buf" const.
10740         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10741         const.
10742         (remote_notif_parse, remote_notif_ack, handle_notification):
10743         Likewise.
10744         * remote.c (remote_notif_stop_parse): Make "buf" const.
10745         (remote_target::remote_parse_stop_reply): Make "buf" const.
10746         (remote_notif_stop_ack): Make "buf" const.
10747
10748 2019-01-14  Tom Tromey  <tom@tromey.com>
10749
10750         * remote.c (remote_console_output): Make parameter const.
10751
10752 2019-01-14  Tom Tromey  <tom@tromey.com>
10753
10754         * target-debug.h (target_debug_print_signals): Constify.
10755         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10756         * procfs.c (procfs_target::pass_signals): Update.
10757         * linux-nat.c (linux_nat_target::pass_signals): Update.
10758         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10759         * target-delegates.c: Rebuild.
10760         * remote.c (remote_target::program_signals): Update.
10761         (remote_target::pass_signals): Update.
10762         * target.c (target_pass_signals): Constify argument.
10763         (target_program_signals): Likewise.
10764         * target.h (struct target_ops) <pass_signals, program_signals>:
10765         Constify argument.
10766         (target_pass_signals, target_program_signals): Constify argument.
10767
10768 2019-01-14  Tom Tromey  <tom@tromey.com>
10769
10770         PR tui/28819:
10771         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10772
10773 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10774
10775         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10776         field.
10777         * rs6000-tdep.c: Include reggroups.h.
10778         (IS_V_ALIAS_PSEUDOREG): Define.
10779         (rs6000_register_name): Return names for the "vX" aliases.
10780         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10781         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10782         aliases.  Call default_register_reggroup_p for all other
10783         pseudo-registers.
10784         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10785         New functions.
10786         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10787         Handle "vX" aliases.
10788         (v_alias_pseudo_register_collect): New function.
10789         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10790         (rs6000_gdbarch_init): Initialize "vX" aliases as
10791         pseudo-registers.  Restore registration of
10792         rs6000_pseudo_register_reggroup_p with
10793         set_tdesc_pseudo_register_reggroup_p.
10794
10795 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10796
10797         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10798         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10799         set_gdbarch_num_pseudo_regs.
10800
10801 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10802
10803         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10804         Remove arg prefixname, add do_set and do_show.
10805         Add member functions set_list and show_list.
10806         * cli/cli-style.c (class cli_style_option): Update accordingly.
10807         (style_set_list): Move to file scope.
10808         (style_show_list): Likewise.
10809         (set_style): Call help_list.
10810         (show_style): Call cmd_show_list.
10811         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10812         Update to use the new macro.
10813
10814 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10815
10816         * ada-lang.c (_initialize_ada_language): Expand the help text
10817         for the "catch exception" command.
10818
10819 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10820
10821         * symtab.c (matching_obj_sections): Initialize obj,
10822         declare it closer to its usage.
10823
10824 2019-01-10  Tom Tromey  <tom@tromey.com>
10825
10826         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10827         (basic_inf_threads_range): Remove.
10828         (inf_threads_range, inf_non_exited_threads_range)
10829         (safe_inf_threads_range): Use next_adapter.
10830
10831 2019-01-10  Keith Seitz  <keiths@redhat.com>
10832
10833         PR gdb/23712
10834         PR symtab/23010
10835         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10836         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10837
10838 2019-01-10  Keith Seitz  <keiths@redhat.com>
10839
10840         PR gdb/23712
10841         PR symtab/23010
10842         * dictionary.c (pending_to_vector): Remove.
10843         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10844         Remove _1 suffix, replacing functions of the same name.  Update
10845         all callers.
10846         (dict_create_hashed, dict_create_hashed_expandable)
10847         (dict_create_linear, dict_create_linear_expandable, dict_free)
10848         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10849         Make functions static.
10850
10851 2019-01-10  Keith Seitz  <keiths@redhat.com>
10852
10853         PR gdb/23712
10854         PR symtab/23010
10855         * dictionary.h (struct dictionary): Replace declaration with
10856         multidictionary.
10857         (dict_create_hashed, dict_create_hashed_expandable)
10858         (dict_create_linear, dict_create_linear_expandable)
10859         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10860         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10861         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10862         taking multidictionary argument.
10863         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10864         * block.h (struct block) <dict>: Change to multidictionary
10865         and rename `multidict'.
10866         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10867         symmisc.c: Update all dictionary references to multidictionary.
10868
10869 2019-01-10  Keith Seitz  <keiths@redhat.com>
10870
10871         PR gdb/23712
10872         PR symtab/23010
10873         * dictionary.c: Include unordered_map.
10874         (pending_to_vector): New function.
10875         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10876         Rewrite the non-"_1" functions to take vector instead
10877         of linked list.
10878         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10879         "new" _1 versions of the same name.
10880         (multidictionary): Define.
10881         (std::hash<enum language): New definition.
10882         (collate_pending_symbols_by_language, mdict_create_hashed)
10883         (mdict_create_hashed_expandable, mdict_create_linear)
10884         (mdict_create_linear_expandable, mdict_free)
10885         (find_language_dictionary, create_new_language_dictionary)
10886         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10887         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10888         (mdict_size, mdict_empty): New functions.
10889         * dictionary.h (mdict_iterator): Define.
10890
10891 2019-01-10  Pedro Alves  <palves@redhat.com>
10892
10893         * breakpoint.c (read_uploaded_action)
10894         (create_tracepoint_from_upload): Adjust to use
10895         gdb::unique_xmalloc_ptr.
10896         * ctf.c (ctf_write_uploaded_tp):
10897         (SET_ARRAY_FIELD): Use emplace_back.
10898         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10899         * tracefile-tfile.c (tfile_write_uploaded_tp):
10900         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10901         gdb::unique_xmalloc_ptr.
10902         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10903         at_string, cond_string, cmd_strings>: Replace char pointers
10904         with gdb::unique_xmalloc_ptr.
10905
10906 2019-01-10  Pedro Alves  <palves@redhat.com>
10907
10908         * solib-target.c (library_list_start_library): Don't xstrdup name.
10909
10910 2019-01-10  Pedro Alves  <palves@redhat.com>
10911
10912         * mdebugread.c (parse_partial_symbols): Use
10913         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10914
10915 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10916
10917         * linux-fork.c (scoped_switch_fork_info)
10918         <~scoped_switch_fork_info>: Fix incorrect variable name.
10919
10920 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10921
10922         * linux-fork.c (scoped_switch_fork_info)
10923         <scoped_switch_fork_info>: Make explicit.
10924         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10925
10926 2019-01-10  Tom Tromey  <tom@tromey.com>
10927
10928         * objfiles.h (objfile::reset_psymtabs): Update.
10929         * objfiles.c (objfile::objfile): Update.
10930         * psymtab.h (psymtab_storage::obstack): Update.
10931         (psymtab_storage::m_obstack): Use gdb::optional.
10932         (class psymtab_storage): Update comment.  Remove objfile
10933         parameter.
10934         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10935
10936 2019-01-10  Tom Tromey  <tom@tromey.com>
10937
10938         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10939         <free_psymtabs>: Now private.
10940         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10941         (allocate_psymtab): Use new method.
10942
10943 2019-01-10  Tom Tromey  <tom@tromey.com>
10944
10945         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10946         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10947         * mdebugread.c (parse_partial_symbols): Use
10948         allocate_dependencies.
10949         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10950         allocate_dependencies.
10951         (process_psymtab_comp_unit_reader)
10952         (build_type_psymtab_dependencies): Likewise.
10953         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10954
10955 2019-01-10  Tom Tromey  <tom@tromey.com>
10956
10957         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10958         PSYMBOL_SET_LANGUAGE.
10959         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10960
10961 2019-01-10  Tom Tromey  <tom@tromey.com>
10962
10963         * psymtab.h (psymtab_storage::obstack): New method.
10964         <m_obstack>: Rename from obstack; now private.
10965         * psymtab.c (psymtab_storage): Update.
10966         * dwarf2read.c (create_addrmap_from_index)
10967         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10968         Update.
10969
10970 2019-01-10  Tom Tromey  <tom@tromey.com>
10971
10972         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10973         * objfiles.h (objfile::reset_psymtabs): New method.
10974
10975 2019-01-10  Tom Tromey  <tom@tromey.com>
10976
10977         * symmisc.c (print_symbol_bcache_statistics): Update.
10978         (print_objfile_statistics): Update.
10979         * symfile.c (reread_symbols): Update.
10980         * psymtab.h (class psymtab_storage): New.
10981         * psymtab.c (psymtab_storage): New constructor.
10982         (~psymtab_storage): New destructor.
10983         (require_partial_symbols): Update.
10984         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10985         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10986         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10987         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10988         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10989         (start_psymtab_common, end_psymtab_common)
10990         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10991         (allocate_psymtab): Update.
10992         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10993         Update.
10994         (dump_psymtab_addrmap, maintenance_print_psymbols)
10995         (maintenance_check_psymtabs): Update.
10996         (class objfile_psymtabs): Move to objfiles.h.
10997         * psympriv.h (discard_psymtab): Now inline.
10998         (psymtab_discarder::psymtab_discarder): Update.
10999         (psymtab_discarder::~psymtab_discarder): Update.
11000         (ALL_OBJFILE_PSYMTABS): Rewrite.
11001         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11002         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11003         Remove fields.
11004         <partial_symtabs>: New field.
11005         (class objfile_psymtabs): Move from psymtab.h.  Update.
11006         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11007         psymbol_cache.
11008         (objfile::~objfile): Don't destroy psymbol_cache.
11009         * mdebugread.c (parse_partial_symbols): Update.
11010         * dwarf2read.c (create_addrmap_from_index)
11011         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11012         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11013         (add_partial_subprogram, dwarf2_ranges_read): Update.
11014         * dwarf-index-write.c (write_address_map)
11015         (write_one_signatured_type, recursively_write_psymbols)
11016         (class debug_names, class debug_names, write_psymtabs_to_index):
11017         Update.
11018
11019 2019-01-10  Tom Tromey  <tom@tromey.com>
11020
11021         * symtab.h (SYMBOL_SET_NAMES): Update.
11022         (symbol_set_names): Update.
11023         (MSYMBOL_SET_NAMES): Update.
11024         * symtab.c (symbol_set_names): Change argument to be an
11025         objfile_per_bfd_storage.
11026         * psymtab.c (add_psymbol_to_bcache): Update.
11027         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11028
11029 2019-01-10  Tom Tromey  <tom@tromey.com>
11030
11031         * symtab.c (create_demangled_names_hash): Change argument to be an
11032         objfile_per_bfd_storage.
11033         (symbol_set_names): Update.
11034
11035 2019-01-10  Tom Tromey  <tom@tromey.com>
11036
11037         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11038         init_psymbol_list.
11039         * psymtab.c (init_psymbol_list): Do nothing if already called.
11040         * psympriv.h (init_psymbol_list): Add comment.
11041         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11042         init_psymbol_list.
11043         * dbxread.c (dbx_symfile_read): Unconditionally call
11044         init_psymbol_list.
11045
11046 2019-01-10  Tom Tromey  <tom@tromey.com>
11047
11048         * xcoffread.c (scan_xcoff_symtab): Update.
11049         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11050         "where".
11051         * mdebugread.c (parse_partial_symbols)
11052         (handle_psymbol_enumerators): Update.
11053         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11054         * dbxread.c (read_dbx_symtab): Update.
11055         * psympriv.h (psymbol_placement): New enum.
11056         (add_psymbol_to_list): Update.
11057
11058 2019-01-10  Tom Tromey  <tom@tromey.com>
11059
11060         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11061         static_psymbols parameters.
11062         (scan_xcoff_symtab): Update.
11063         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11064         static_psymbols parameters.
11065         * psympriv.h (start_psymtab_common): Update.
11066         * mdebugread.c (parse_partial_symbols): Update.
11067         * dwarf2read.c (create_partial_symtab): Update.
11068         * dbxread.c (read_dbx_symtab): Update.
11069         (start_psymtab): Remove global_psymbols and static_psymbols
11070         parameters.
11071
11072 2019-01-10  Tom Tromey  <tom@tromey.com>
11073
11074         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11075         * psymtab.c (allocate_psymtab): Add comment.
11076         * psympriv.h (allocate_psymtab): Add comment.
11077         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11078         initializations.
11079         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11080
11081 2019-01-10  Tom Tromey  <tom@tromey.com>
11082
11083         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11084         Don't declare.
11085         * mipsread.c: Include mdebugread.h.
11086         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11087         Declare.
11088         * elfread.c: Include mdebugread.h.
11089
11090 2019-01-09  Tom Tromey  <tom@tromey.com>
11091
11092         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11093         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11094         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11095         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11096         (psym_lookup_symbol, psym_find_last_source_symtab)
11097         (psym_forget_cached_source_info, psym_print_stats)
11098         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11099         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11100         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11101         (psym_find_compunit_symtab_by_address)
11102         (maintenance_print_psymbols, maintenance_info_psymtabs)
11103         (maintenance_check_psymtabs): Use ranged for.
11104         * psymtab.h (class objfile_psymtabs): New.
11105         (require_partial_symbols): Return objfile_psymtabs.
11106         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11107
11108 2019-01-09  Tom Tromey  <tom@tromey.com>
11109
11110         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11111         (find_pc_mapped_section, list_overlays_command)
11112         (map_overlay_command, unmap_overlay_command)
11113         (simple_overlay_update): Use all_objfiles.
11114         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11115         * printcmd.c (info_symbol_command): Use all_objfiles.
11116         * objfiles.h (ALL_OBJSECTIONS): Remove.
11117         * maint.c (maintenance_translate_address): Use all_objfiles.
11118         * gcore.c (gcore_create_callback): Use all_objfiles.
11119         (objfile_find_memory_regions): Likewise.
11120
11121 2019-01-09  Tom Tromey  <tom@tromey.com>
11122
11123         * symtab.c (find_line_symtab, info_sources_command)
11124         (make_source_files_completion_list): Use objfile_compunits.
11125         * source.c (select_source_symtab): Use objfile_compunits.
11126         * objfiles.h (struct objfile): Update comment.
11127         (ALL_OBJFILES): Remove.
11128         (ALL_FILETABS): Remove.
11129         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11130         objfile_compunits.
11131
11132 2019-01-09  Tom Tromey  <tom@tromey.com>
11133
11134         * symmisc.c (print_objfile_statistics, dump_objfile)
11135         (maintenance_print_symbols): Use compunit_filetabs.
11136         * source.c (forget_cached_source_info_for_objfile): Use
11137         compunit_filetabs.
11138         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11139         (ALL_FILETABS): Use compunit_filetabs.
11140         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11141         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11142
11143 2019-01-09  Tom Tromey  <tom@tromey.com>
11144
11145         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11146         (compunit_filetabs): New.
11147         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11148         compunit_filetabs.
11149         (info_sources_command, make_source_files_completion_list): Remove
11150         declaration.
11151         * symmisc.c (print_objfile_statistics, dump_objfile)
11152         (maintenance_print_symbols): Remove declaration.
11153         (maintenance_info_symtabs): Use compunit_filetabs.
11154         (maintenance_info_line_tables): Likewise.
11155         * source.c (select_source_symtab): Change local variable name.
11156         (forget_cached_source_info_for_objfile): Remove declaration.
11157         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11158         * objfiles.c (objfile_relocate1): Remove declaration.
11159         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11160         declaration.
11161         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11162         * coffread.c (coff_symtab_read): Remove declaration.
11163         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11164         compunit_filetabs.
11165
11166 2019-01-09  Tom Tromey  <tom@tromey.com>
11167
11168         * symtab.c (lookup_objfile_from_block)
11169         (find_pc_sect_compunit_symtab, search_symbols)
11170         (default_collect_symbol_completion_matches_break_on): Use
11171         objfile_compunits.
11172         * objfiles.h (ALL_COMPUNITS): Remove.
11173         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11174         * cp-support.c (add_symbol_overload_list_qualified): Use
11175         objfile_compunits.
11176         * ada-lang.c (ada_collect_symbol_completion_matches)
11177         (ada_add_global_exceptions): Use objfile_compunits.
11178
11179 2019-01-09  Tom Tromey  <tom@tromey.com>
11180
11181         * source.c (select_source_symtab)
11182         (forget_cached_source_info_for_objfile): Remove declaration.
11183         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11184         declaration.
11185         * maint.c (count_symtabs_and_blocks): Remove declaration.
11186         * cp-support.c (add_symbol_overload_list_qualified): Remove
11187         declaration.
11188         * coffread.c (coff_symtab_read): Remove declaration.
11189         * symtab.c (lookup_symbol_in_objfile_symtabs)
11190         (basic_lookup_transparent_type_1): Use objfile_compunits.
11191         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11192         (info_sources_command, search_symbols)
11193         (default_collect_symbol_completion_matches_break_on)
11194         (make_source_files_completion_list): Remove declaration.
11195         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11196         (ada_collect_symbol_completion_matches)
11197         (ada_add_global_exceptions): Remove declaration.
11198         * linespec.c (iterate_over_all_matching_symtabs): Use
11199         objfile_compunits.
11200         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11201         (class objfile_compunits): New.
11202         (ALL_COMPUNITS): Use objfile_compunits.
11203         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11204         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11205         objfile_compunits.
11206         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11207
11208 2019-01-09  Tom Tromey  <tom@tromey.com>
11209
11210         * symtab.c (search_symbols)
11211         (default_collect_symbol_completion_matches_break_on): Use
11212         objfile_msymbols.
11213         * ada-lang.c (ada_lookup_simple_minsym)
11214         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11215         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11216         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11217         objfile_msymbols.
11218         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11219         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11220         * objc-lang.c (find_methods): Use objfile_msymbols.
11221         (info_selectors_command, info_classes_command): Likewise.
11222         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11223         * objfiles.h (class objfile_msymbols): New.
11224         (ALL_OBJFILE_MSYMBOLS): Remove.
11225         (ALL_MSYMBOLS): Remove.
11226
11227 2019-01-09  Tom Tromey  <tom@tromey.com>
11228
11229         * common/next-iterator.h (next_adapter): Add Iterator template
11230         parameter.
11231         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11232         (class all_objfiles_safe): New.
11233         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11234         * objfiles.c (put_objfile_before): Update comment.
11235         (add_separate_debug_objfile): Likewise.
11236         (free_all_objfiles): Use all_objfiles_safe.
11237         (objfile_purge_solibs): Likewise.
11238
11239 2019-01-09  Tom Tromey  <tom@tromey.com>
11240
11241         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11242         (expand_symtab_containing_pc, lookup_static_symbol)
11243         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11244         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11245         all_objfiles.
11246         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11247         * breakpoint.c (create_overlay_event_breakpoint)
11248         (create_longjmp_master_breakpoint)
11249         (create_std_terminate_master_breakpoint)
11250         (create_exception_master_breakpoint): Use all_objfiles.
11251         * linux-thread-db.c (try_thread_db_load_from_pdir)
11252         (has_libpthread): Use all_objfiles.
11253         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11254         * linespec.c (iterate_over_all_matching_symtabs)
11255         (search_minsyms_for_name): Use all_objfiles.
11256         * maint.c (maintenance_info_sections): Use all_objfiles.
11257         * main.c (captured_main_1): Use all_objfiles.
11258         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11259         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11260         * guile/scm-pretty-print.c
11261         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11262         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11263         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11264         (maintenance_print_msymbols): Use all_objfiles.
11265         * source.c (select_source_symtab): Use all_objfiles.
11266         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11267         * symfile.c (remove_symbol_file_command)
11268         (expand_symtabs_matching, map_symbol_filenames): Use
11269         all_objfiles.
11270         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11271         all_objfiles.
11272         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11273         * objc-lang.c (find_methods): Use all_objfiles.
11274         * objfiles.c (have_partial_symbols, have_full_symbols)
11275         (have_minimal_symbols, qsort_cmp)
11276         (default_iterate_over_objfiles_in_search_order): Use
11277         all_objfiles.
11278         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11279         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11280         (maintenance_check_psymtabs): Use all_objfiles.
11281         (ALL_PSYMTABS): Remove.
11282         * compile/compile-object-run.c (do_module_cleanup): Use
11283         all_objfiles.
11284         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11285         * cp-support.c (add_symbol_overload_list_qualified): Use
11286         all_objfiles.
11287         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11288         Use all_objfiles.
11289         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11290         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11291         all_objfiles.
11292         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11293         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11294         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11295         Uses all_objfiles.
11296         * solib.c (solib_read_symbols): Use all_objfiles
11297
11298 2019-01-09  Tom Tromey  <tom@tromey.com>
11299
11300         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11301         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11302         all_objfiles.
11303         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11304         * symmisc.c (print_symbol_bcache_statistics)
11305         (print_objfile_statistics, maintenance_print_objfiles)
11306         (maintenance_info_symtabs, maintenance_check_symtabs)
11307         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11308         all_objfiles.
11309         * source.c (forget_cached_source_info): Use all_objfiles.
11310         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11311         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11312         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11313         * objfiles.c (update_section_map): Use all_objfiles.
11314         (shared_objfile_contains_address_p): Likewise.
11315         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11316         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11317
11318 2019-01-09  Tom Tromey  <tom@tromey.com>
11319
11320         * common/next-iterator.h: New file.
11321         * objfiles.h (class all_objfiles): New.
11322         (struct objfile_iterator): New.
11323
11324 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11325
11326         * NEWS: Move the description of the changed "frame", "select-frame",
11327          and "info frame" commands to the Changed commands section.
11328
11329 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11330
11331         * gdbtypes.c (check_stub_method_group): Remove handling of old
11332         mangling schemes.
11333         * linespec.c (find_methods): Likewise.
11334         * stabsread.c (read_member_functions): Likewise.
11335         * valops.c (search_struct_method): Likewise.
11336         (value_struct_elt_for_reference): Likewise.
11337         * NEWS: Mention this change.
11338
11339 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11340
11341         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11342         print_source_lines.
11343         * source.c (print_source_lines_base): Update line number check.
11344         (print_source_lines): New function.
11345         (source_lines_range::source_lines_range): New function.
11346         * source.h (class source_lines_range): New class.
11347         (print_source_lines): New declaration.
11348
11349 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11350
11351         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11352
11353 2019-01-08  Tom Tromey  <tom@tromey.com>
11354             Simon Marchi  <simon.marchi@ericsson.com>
11355
11356         PR gdb/24060
11357         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11358         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11359         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11360         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11361         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11362         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11363
11364 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11365
11366         * source.c (select_source_symtab): Move header comment to
11367         declaration in source.h.
11368         (forget_cached_source_info_for_objfile): Likewise.
11369         (forget_cached_source_info): Likewise.
11370         (identify_source_line): Likewise.
11371         * source.h (identify_source_line): Move declaration from symtab.h
11372         and add comment from source.c
11373         (print_source_lines): Likewise.
11374         (forget_cached_source_info_for_objfile): Likewise.
11375         (forget_cached_source_info): Likewise.
11376         (select_source_symtab): Likewise.
11377         (enum print_source_lines_flag): Move definition from symtab.h.
11378         * symtab.h (identify_source_line): Move declaration to source.h.
11379         (print_source_lines): Likewise.
11380         (forget_cached_source_info_for_objfile): Likewise.
11381         (forget_cached_source_info): Likewise.
11382         (select_source_symtab): Likewise.
11383         (enum print_source_lines_flag): Move definition to source.h.
11384         * tui/tui-hooks.c: Add 'source.h' include.
11385
11386 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11387
11388         * source.c (print_source_lines_base): Handle requests to print
11389         reverse line number sequences, and guard against empty lines
11390         string.
11391
11392 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11393
11394         * source.c (print_source_lines_base): Fix skip of '\r' if next
11395         character is '\n'.
11396
11397 2019-01-06  Tom Tromey  <tom@tromey.com>
11398
11399         * c-exp.y (struct c_parse_state) <macro_original_text,
11400         expansion_obstack>: New member.
11401         (macro_original_text, expansion_obstack): Remove globals.
11402         (scan_macro_expansion, scanning_macro_expansion)
11403         (finished_macro_expansion): Update.
11404         (scan_macro_cleanup): Remove.
11405         (yylex, c_parse): Update.
11406
11407 2019-01-06  Tom Tromey  <tom@tromey.com>
11408
11409         * c-exp.y (struct c_parse_state) <strings>: New member.
11410         (operator_stoken): Update.
11411
11412 2019-01-06  Tom Tromey  <tom@tromey.com>
11413
11414         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11415         (union type_stack_elt) <typelist_val>: Now a pointer to
11416         std::vector.
11417         (type_stack_cleanup): Don't declare.
11418         (push_typelist): Update.
11419         * parse.c (pop_typelist): Return a std::vector.
11420         (push_typelist): Take a std::vector.
11421         (follow_types): Update.  Do not free args.
11422         (type_stack_cleanup): Remove.
11423         * c-exp.y (struct c_parse_state): New.
11424         (cpstate): New global.
11425         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11426         (nonempty_typelist): Update.
11427         (func_mod): Create a new vector.
11428         (c_parse): Create a c_parse_state.
11429         (check_parameter_typelist): Do not delete params.
11430         (function_method): Update.  Do not delete type_list.
11431
11432 2019-01-06  Tom Tromey  <tom@tromey.com>
11433
11434         PR gdb/28155:
11435         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11436         check_typedef.
11437         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11438         (print_return_value): Likewise.
11439
11440 2019-01-05  Tom Tromey  <tom@tromey.com>
11441
11442         * contrib/cleanup_check.py: Remove.
11443         * contrib/gcc-with-excheck: Remove.
11444         * contrib/exsummary.py: Remove.
11445         * contrib/excheck.py: Remove.
11446
11447 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11448
11449         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11450         NULL. Initialize tpprev to NULL instead of assigning it
11451         to NULL on the next statement.
11452         * windows-nat.c (windows_delete_thread): Remove check for
11453         main_thread_id before printing thread exit notifications.
11454         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11455         Remove thread ID check against main_thread_id.
11456         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11457         windows_delete_thread.
11458         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11459
11460 2019-01-04  Tom Tromey  <tom@tromey.com>
11461
11462         * compile/compile.c (_initialize_compile): Use upper case for
11463         metasyntactic variables.
11464         * symmisc.c (_initialize_symmisc): Use upper case for
11465         metasyntactic variables.
11466         * psymtab.c (_initialize_psymtab): Use upper case for
11467         metasyntactic variables.
11468         * demangle.c (demangle_command): Use upper case for metasyntactic
11469         variables.
11470         (_initialize_demangler): Likewise.
11471         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11472         variables.
11473
11474 2019-01-03  Tom Tromey  <tom@tromey.com>
11475
11476         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11477
11478 2019-01-03  Tom Tromey  <tom@tromey.com>
11479
11480         * python/py-symtab.c (salpy_str): Update.
11481         (struct salpy_sal_object) <symtab>: Now a PyObject.
11482         (salpy_dealloc): Update.
11483         (del_objfile_sal): Use gdbpy_ref.
11484
11485 2019-01-03  Tom Tromey  <tom@tromey.com>
11486
11487         * python/py-type.c (convert_field): Use new_reference.  Return
11488         gdbpy_ref.
11489         (make_fielditem): Return gdbpy_ref.
11490         (typy_fields): Update.
11491         (typy_getitem): Update.
11492         (field_name): Return gdbpy_ref.  Use new_reference.
11493         (typy_iterator_iternext): Update.
11494
11495 2019-01-03  Tom Tromey  <tom@tromey.com>
11496
11497         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11498
11499 2019-01-03  Tom Tromey  <tom@tromey.com>
11500
11501         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11502         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11503         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11504         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11505         (pspy_set_type_printers): Likewise.
11506         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11507         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11508         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11509         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11510         (objfpy_set_type_printers): Likewise.
11511
11512 2019-01-03  Tom Tromey  <tom@tromey.com>
11513
11514         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11515         (gdbpy_print_stack): Use gdbpy_err_fetch.
11516         * python/python-internal.h (class gdbpy_err_fetch): New class.
11517         (class gdbpy_enter) <m_error_type, m_error_value,
11518         m_error_traceback>: Remove.
11519         <m_error>: New member.
11520         (gdbpy_exception_to_string): Don't declare.
11521         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11522         * python/py-value.c (convert_value_from_python): Use
11523         gdbpy_err_fetch.
11524         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11525         gdbpy_exception_to_string.
11526         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11527         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11528         gdbpy_err_fetch.
11529
11530 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11531
11532         * linux-nat.c (delete_lwp_cleanup): Delete.
11533         (struct lwp_deleter): New struct.
11534         (lwp_info_up): New typedef.
11535         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11536         lwp_info_up.
11537
11538 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11539
11540         * linux-fork.c (class scoped_switch_fork_info): New class.
11541         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11542
11543 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11544
11545         * valops.c (find_overload_match): Remove use of null_cleanup, and
11546         calls to do_cleanups.
11547
11548 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11549
11550         * compile/compile-cplus-types.c
11551         (compile_cplus_instance::decl_name): Handle changes to
11552         cp_func_name.
11553         * cp-support.c (cp_func_name): Update header comment, update
11554         return type.
11555         * cp-support.h (cp_func_name): Update return type in declaration.
11556         * valops.c (find_overload_match): Move temp_func local to top
11557         level of function and change its type.  Use temp_func to hold and
11558         delete temporary string obtained from cp_func_name.
11559
11560 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11561
11562         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11563         gdb::char_vector, remove cleanup, and update uses of `msg`.
11564
11565 2019-01-03  Jim Wilson  <jimw@sifive.com>
11566
11567         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11568
11569 2019-01-02  Tom Tromey  <tom@tromey.com>
11570
11571         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11572         (tdesc_parse_xml): Remove cleanups.
11573         * target-descriptions.h (make_cleanup_free_target_description):
11574         Don't declare.
11575         (target_desc_deleter): New struct.
11576         (target_desc_up): New typedef.
11577         * target-descriptions.c (target_desc_deleter::operator()): Rename
11578         from free_target_description.
11579         (make_cleanup_free_target_description): Remove.
11580
11581 2019-01-02  Tom Tromey  <tom@tromey.com>
11582
11583         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11584         constructor, destructor.
11585         (linespec_parser): Remove typedef.
11586         (~linespec_parser): Rename from linespec_parser_delete.
11587         (linespec_lex_to_end, linespec_complete_label)
11588         (linespec_complete): Update.
11589         (decode_line_full): Remove cleanups.
11590         (decode_line_1): Update.
11591
11592 2019-01-02  Tom Tromey  <tom@tromey.com>
11593
11594         * python/python-internal.h (inferior_to_inferior_object): Change
11595         return type.
11596         * python/py-exitedevent.c (create_exited_event_object): Update.
11597         * python/py-inferior.c (inferior_to_inferior_object): Return
11598         gdbpy_ref.
11599         (python_new_inferior, python_inferior_deleted)
11600         (thread_to_thread_object, delete_thread_object)
11601         (build_inferior_list, gdbpy_selected_inferior): Update.
11602         * python/py-infthread.c (create_thread_object): Update.  Also fail
11603         if inferior_to_inferior_object fails.
11604
11605 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11606
11607         * inferior.h (class inferior) <displaced_step_state>: New field.
11608         * infrun.h (struct displaced_step_state): Move here from
11609         infrun.c.  Initialize fields, add constructor.
11610         <inf>: Remove field.
11611         <reset>: New method.
11612         * infrun.c (struct displaced_step_inferior_state): Move to
11613         infrun.h.
11614         (displaced_step_inferior_states): Remove.
11615         (get_displaced_stepping_state): Adust.
11616         (displaced_step_in_progress_any_inferior): Adjust.
11617         (displaced_step_in_progress_thread): Adjust.
11618         (displaced_step_in_progress): Adjust.
11619         (add_displaced_stepping_state): Remove.
11620         (get_displaced_step_closure_by_addr): Adjust.
11621         (remove_displaced_stepping_state): Remove.
11622         (infrun_inferior_exit): Call displaced_step_state.reset.
11623         (use_displaced_stepping): Don't check for NULL.
11624         (displaced_step_prepare_throw): Call
11625         get_displaced_stepping_state.
11626         (displaced_step_fixup): Don't check for NULL.
11627         (prepare_for_detach): Don't check for NULL.
11628
11629 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11630
11631         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11632          in case of call that did not complete.
11633
11634 2019-01-02  Andrey Utkin  <autkin@undo.io>
11635
11636         * symfile.c (find_separate_debug_file): Fix search of debug files for
11637         remote debuggee.
11638
11639 2019-01-02  Tom Tromey  <tom@tromey.com>
11640
11641         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11642         indentation.
11643         * python/py-frame.c (frapy_older): Remove cast.
11644         (frapy_newer): Likewise.
11645         * python/py-breakpoint.c (local_setattro): Remove cast.
11646         * python/py-arch.c (archpy_name): Remove local variable.
11647         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11648
11649 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11650
11651         * unittests/basic_string_view/element_access/char/empty.cc:
11652         Fix year range in copyright header.
11653
11654 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11655
11656         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11657         Delete.
11658         <operator==>: Update with for removed field.
11659         <hash>: Likewise.
11660         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11661         <isa_features>: ...this.
11662         <abi_features>: New field.
11663         (riscv_isa_flen): Update comment.
11664         (riscv_abi_xlen): New declaration.
11665         (riscv_abi_flen): New declaration.
11666         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11667         isa_features.
11668         (riscv_abi_xlen): New function.
11669         (riscv_isa_flen): Update to get answer from isa_features.
11670         (riscv_abi_flen): New function.
11671         (riscv_has_fp_abi): Update to get answer from abi_features.
11672         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11673         xlen and flen.
11674         (riscv_call_info) <xlen, flen>: Update comment.
11675         (riscv_call_arg_struct): Remove invalid assertions
11676         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11677         is removed.
11678         (riscv_gdbarch_init): Gather isa features and abi features
11679         separately, ensure both match on the gdbarch when reusing an old
11680         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11681         a target with 64-bit float hardware.
11682
11683 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11684
11685         * source.c (search_command_helper): Stop reverse search
11686         when line 1 has been searched.
11687
11688 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11689
11690         * record-full.c (record_full_base_target::close): Rewrite
11691         record_full_core_buf_list free logic.
11692
11693 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11694
11695         * break-catch-syscall.c (print_one_catch_syscall): xfree
11696         the last text.
11697
11698 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11699
11700         * top.c (print_gdb_version): Update Copyright year in version
11701         message.
11702
11703 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11704
11705         Update copyright year range in all GDB files.
11706
11707 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11708
11709         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11710
11711 For older changes see ChangeLog-2018.
11712 \f
11713 Local Variables:
11714 mode: change-log
11715 left-margin: 8
11716 fill-column: 74
11717 version-control: never
11718 coding: utf-8
11719 End:
11720