gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-wingeneral.c (make_visible): Remove check of window
   4         type.
   5
   6 2019-06-25  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-win.c (tui_win_info::max_height)
   9         (tui_cmd_window::max_height): New methods.
  10         (new_height_ok): Call max_height.
  11         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
  12         <max_height>: New method.
  13
  14 2019-06-25  Tom Tromey  <tom@tromey.com>
  15
  16         * tui/tui-win.c (tui_source_window_base::set_new_height)
  17         (tui_data_window::set_new_height): New methods.
  18         (make_invisible_and_set_new_height): Call set_new_height method.
  19         * tui/tui-data.h (struct tui_win_info)
  20         (struct tui_source_window_base, struct tui_data_window)
  21         <set_new_height>: New method.
  22
  23 2019-06-25  Tom Tromey  <tom@tromey.com>
  24
  25         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
  26         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
  27         tui_refresh_data_win.
  28         * tui/tui-win.c (tui_source_window_base::refresh_all): New
  29         method.
  30         (tui_refresh_all_win): Call the refresh_all method.
  31         (tui_set_focus): Likewise.
  32         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
  33         (struct tui_source_window_base, struct tui_data_window) <refresh>:
  34         Likewise.
  35
  36 2019-06-25  Tom Tromey  <tom@tromey.com>
  37
  38         * tui/tui-winsource.h (tui_refill_source_window)
  39         (tui_set_is_exec_point_at): Don't declare.
  40         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
  41         (tui_source_window_base::refill): Rename from
  42         tui_refill_source_window.
  43         (tui_source_window_base::do_scroll_horizontal): Update.
  44         (tui_source_window_base::set_is_exec_point_at): Rename from
  45         tui_set_is_exec_point_at.
  46         (tui_update_all_breakpoint_info): Update.
  47         * tui/tui-stack.c (tui_show_frame_info): Update.
  48         * tui/tui-layout.c (show_data): Add cast.
  49         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
  50         * tui/tui-data.h (struct tui_source_window_base) <refill,
  51         set_is_exec_point_at>: New methods.
  52         (tui_source_windows, tui_add_to_source_windows): Update types.
  53         (tui_add_to_source_windows): Remove redundant declaration.
  54         * tui/tui-data.c (source_windows): Store tui_source_window_base.
  55         (tui_source_windows): Change return type.
  56         (tui_clear_source_windows_detail): Update.
  57         (tui_add_to_source_windows): Change type of parameter.
  58         (tui_free_all_source_wins_content): Update.
  59
  60 2019-06-25  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-wingeneral.c (tui_win_info::refresh)
  63         (tui_source_window_base::refresh): New methods.
  64         (tui_refresh_all): Call the refresh method.
  65         * tui/tui-data.h (struct tui_win_info)
  66         (struct tui_source_window_base) <refresh>: New method.
  67
  68 2019-06-25  Tom Tromey  <tom@tromey.com>
  69
  70         * tui/tui.h (tui_is_window_visible): Return bool.
  71         * tui/tui.c (tui_is_window_visible): Return bool.
  72         * tui/tui-wingeneral.c (tui_make_window, make_visible)
  73         (tui_make_visible, tui_make_invisible)
  74         (tui_win_info::make_visible)
  75         (tui_source_window_base::make_visible, make_all_visible)
  76         (tui_make_all_visible, tui_make_all_invisible): Update.
  77         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
  78         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
  79         bool.
  80         (struct tui_win_info, struct tui_source_window_base)
  81         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
  82         * tui/tui-data.c (tui_init_generic_part): Update.
  83
  84 2019-06-25  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui-wingeneral.c (tui_win_info::make_visible)
  87         (tui_source_window_base::make_visible): New methods.
  88         (make_all_visible): Make method call.
  89         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
  90         (struct tui_source_window_base, struct tui_cmd_window): Override
  91         make_visible.
  92         (tui_win_is_source_type): Don't declare.
  93         * tui/tui-data.c (tui_win_is_source_type): Remove.
  94
  95 2019-06-25  Tom Tromey  <tom@tromey.com>
  96
  97         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
  98         NULL check.
  99
 100 2019-06-25  Tom Tromey  <tom@tromey.com>
 101
 102         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 103         Inline constructor.  Add initializers for members.
 104         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 105         constructors; now inline in class.
 106
 107 2019-06-25  Tom Tromey  <tom@tromey.com>
 108
 109         * tui/tui-regs.c (tui_show_registers): Update.
 110         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 111         bool.
 112         * tui/tui-data.c (tui_data_window::clear_detail)
 113         (tui_data_window): Update.
 114
 115 2019-06-25  Tom Tromey  <tom@tromey.com>
 116
 117         * tui/tui-windata.c (tui_display_all_data)
 118         (tui_display_data_from_line, tui_display_data_from)
 119         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 120         Update.
 121         * tui/tui-regs.c (tui_last_regs_line_no)
 122         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 123         (tui_show_registers, tui_show_register_group)
 124         (tui_display_registers_from, tui_display_reg_element_at_line)
 125         (tui_display_registers_from_line, tui_check_register_values)
 126         (tui_reg_next, tui_reg_prev): Update.
 127         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 128         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 129         tui_data_window.
 130         (struct tui_win_info) <detail>: Remove.  Add new fields from
 131         tui_data_info.
 132         (TUI_DATA_WIN): Add cast.
 133         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 134         (~tui_data_window): Simplify.
 135
 136 2019-06-25  Tom Tromey  <tom@tromey.com>
 137
 138         * tui/tui-layout.c (show_source_disasm_command)
 139         (show_source_or_disasm_and_command): Update.
 140         * tui/tui-io.c (update_cmdwin_start_line)
 141         (tui_redisplay_readline): Update.
 142         * tui/tui-data.h (struct tui_command_info): Remove.
 143         (struct tui_win_info) <detail>: Remove command_info member.
 144         (struct tui_data_window) <start_line>: New member, from
 145         tui_command_info.
 146         (TUI_CMD_WIN): Add casts.
 147
 148 2019-06-25  Tom Tromey  <tom@tromey.com>
 149
 150         * tui/tui-winsource.c (tui_update_source_window)
 151         (tui_refill_source_window)
 152         (tui_source_window_base::do_scroll_horizontal)
 153         (tui_update_breakpoint_info, tui_set_exec_info_content)
 154         (tui_show_exec_info_content, tui_erase_exec_info_content)
 155         (tui_clear_exec_info_content): Update.
 156         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 157         Update.
 158         * tui/tui-win.c (make_invisible_and_set_new_height)
 159         (make_visible_with_new_height): Update.
 160         * tui/tui-source.c (tui_set_source_content)
 161         (tui_show_symtab_source): Update.
 162         * tui/tui-layout.c (extract_display_start_addr)
 163         (show_source_disasm_command, show_data)
 164         (make_source_or_disasm_window)
 165         (show_source_or_disasm_and_command): Update.
 166         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 167         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 168         "gdbarch".
 169         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 170         to tui_source_window_base.
 171         (struct tui_win_info) <detail>: Remove source_info member.
 172         (struct tui_source_window_base) <has_locator>: Inline.
 173         Move contents from tui_source_info; rename has_locator member to
 174         m_has_locator.
 175         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 176         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 177         header file.
 178         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 179         Simplify.
 180         (tui_free_all_source_wins_content): Cast to
 181         tui_source_window_base.
 182
 183 2019-06-25  Tom Tromey  <tom@tromey.com>
 184
 185         * tui/tui-win.c (make_invisible_and_set_new_height)
 186         (make_visible_with_new_height): Call has_locator method.
 187         * tui/tui-layout.c (show_source_disasm_command, show_data)
 188         (show_source_or_disasm_and_command): Update for bool change.
 189         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 190         (tui_win_info) <has_locator>: New method.
 191         (struct tui_source_window_base) <has_locator>: New method.
 192         (tui_win_has_locator): Don't declare.
 193         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 194         from tui_win_has_locator.
 195         (tui_source_window_base): Use false, not FALSE.
 196
 197 2019-06-25  Tom Tromey  <tom@tromey.com>
 198
 199         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 200         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 201         clear_detail method directly.
 202         (tui_clear_win_detail): Remove.
 203
 204 2019-06-25  Tom Tromey  <tom@tromey.com>
 205
 206         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 207         "this", not TUI_DISASM_WIN.
 208
 209 2019-06-25  Tom Tromey  <tom@tromey.com>
 210
 211         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 212         declare.
 213         * tui/tui-winsource.c
 214         (tui_source_window_base::do_scroll_horizontal): Rename from
 215         tui_horizontal_source_scroll.
 216         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 217         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 218         from tui_vertical_data_scroll.
 219         * tui/tui-win.h (tui_scroll): Don't declare.
 220         * tui/tui-win.c (tui_win_info::forward_scroll)
 221         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 222         (tui_win_info::right_scroll): Rename and update.
 223         (tui_scroll_forward_command, tui_scroll_backward_command)
 224         (tui_scroll_left_command, tui_scroll_right_command): Update.
 225         (tui_scroll): Remove.
 226         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 227         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 228         from tui_vertical_source_scroll.
 229         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 230         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 231         from tui_vertical_disassem_scroll.
 232         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 233         do_scroll_horizontal>: New methods.
 234         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 235         Likewise.
 236         (struct tui_source_window_base): Add do_scroll_horizontal.
 237         (struct tui_source_window, struct tui_disasm_window): Add
 238         do_scroll_vertical.
 239         (struct tui_data_window, struct tui_cmd_window): Add
 240         do_scroll_horizontal and do_scroll_vertical.
 241         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 242
 243 2019-06-25  Tom Tromey  <tom@tromey.com>
 244
 245         * tui/tui-data.h (struct tui_source_window_base): New struct.
 246         (struct tui_source_window): Derive from tui_source_window_base.
 247         (struct tui_disasm_window): New struct.
 248         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 249         from tui_source_window::clear_detail.
 250         (tui_source_window_base): Rename from tui_source_window.
 251         (~tui_source_window_base): Rename from ~tui_source_window.
 252         (tui_alloc_win_info): Create a tui_disasm_window.
 253
 254 2019-06-25  Tom Tromey  <tom@tromey.com>
 255
 256         * tui/tui-data.h (struct tui_source_window)
 257         (struct tui_data_window): Declare destructors.
 258         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 259         destructors.
 260         (tui_win_info): Simplify.
 261
 262 2019-06-25  Tom Tromey  <tom@tromey.com>
 263
 264         * tui/tui-winsource.c (tui_display_main)
 265         (tui_update_source_windows_with_addr)
 266         (tui_update_all_breakpoint_info): Update.
 267         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 268         (new_height_ok, parse_scrolling_args): Update.
 269         * tui/tui-stack.c (tui_show_frame_info): Update.
 270         * tui/tui-data.h (struct tui_list): Remove.
 271         (tui_source_windows): Return a reference to a std::vector.
 272         * tui/tui-data.c (source_windows): Now a std::vector.
 273         (tui_source_windows): Change return type.
 274         (tui_clear_source_windows): Rewrite.
 275         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 276         (tui_free_all_source_wins_content): Rewrite.
 277
 278 2019-06-25  Tom Tromey  <tom@tromey.com>
 279
 280         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 281         (struct tui_data_window, struct tui_cmd_window): Declare
 282         clear_detail method.
 283         * tui/tui-data.c (tui_source_window::clear_detail)
 284         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 285         methods.
 286         (tui_clear_win_detail): Simplify.
 287
 288 2019-06-25  Tom Tromey  <tom@tromey.com>
 289
 290         * tui/tui-layout.c (make_source_window, make_disasm_window)
 291         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 292         Return the new window.
 293         (show_source_disasm_command, show_data)
 294         (show_source_or_disasm_and_command): Update.
 295
 296 2019-06-25  Tom Tromey  <tom@tromey.com>
 297
 298         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 299         parameter.  Return the new window.
 300         (show_source_disasm_command): Update and remove NULL check.
 301         (show_source_or_disasm_and_command): Update.
 302
 303 2019-06-25  Tom Tromey  <tom@tromey.com>
 304
 305         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 306
 307 2019-06-25  Tom Tromey  <tom@tromey.com>
 308
 309         * tui/tui-data.h (struct tui_win_info): Make constructor
 310         protected.  Make destructor virtual.  Add initializers.
 311         (tui_source_window, tui_data_window, tui_cmd_window): New
 312         classes.
 313         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 314         constructor.  Add "type" parameter.
 315         (tui_source_window, tui_data_window, tui_cmd_window): New
 316         constructors.
 317         (tui_alloc_win_info): Instantiate the appropriate subclass.
 318
 319 2019-06-25  Tom Tromey  <tom@tromey.com>
 320
 321         * tui/tui-win.c (tui_resize_all): Use delete.
 322         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 323         destructor.
 324         (tui_free_window): Don't declare.
 325         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 326         Update.
 327
 328 2019-06-25  Tom Tromey  <tom@tromey.com>
 329
 330         * tui/tui-data.h (struct tui_win_info): Add constructor.
 331         * tui/tui-data.c (tui_alloc_win_info): Use new.
 332         (tui_free_window): Use delete.
 333
 334 2019-06-22  Tom Tromey  <tom@tromey.com>
 335
 336         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 337         declare.
 338         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 339
 340 2019-06-22  Tom Tromey  <tom@tromey.com>
 341
 342         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 343         declare.
 344         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 345
 346 2019-06-22  Tom de Vries  <tdevries@suse.de>
 347
 348         * dwarf2read.c (create_addrmap_from_aranges)
 349         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 350         instead of '%zu'.
 351
 352 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 353
 354         * dwarf2read.h (dwarf2_section_info_def): Remove.
 355         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 356         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 357         std::vector<dwarf2_section_info>.
 358         (struct dwo_file) <~dwo_file>: Remove.
 359         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 360         types field.
 361         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 362         (dwarf2_read_debug_names): Likewise.
 363         (create_debug_types_hash_table): Change parameter type to
 364         array_view, adjust code accordingly.
 365         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 366         (partial_die_info::fixup): Likewise.
 367         (determine_prefix): Likewise.
 368         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 369
 370 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 371
 372         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 373         gdb_bfd_ref_ptr.
 374         <~dwo_file>: Remove call to gdb_bfd_unref.
 375         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 376         gdb_bfd_ref_ptr::get.
 377
 378 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 379
 380         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 381         type to htab_up.
 382         * dwarf2read.c (struct dwo_file): Initialize fields.
 383         <~dwo_file>: New.
 384         (free_dwo_file): Remove, move content to ~dwo_file.
 385         (struct dwo_file_deleter): Remove.
 386         (dwo_file_up>: Remove custom deleter.
 387         (free_dwo_files): Remove.
 388         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 389         dwo_files.
 390         (process_skeletonless_type_units): Call unique_ptr::get.
 391         (allocate_dwo_file_hash_table): Add deleter to created hash
 392         table.  Change return type to htab_up.
 393         (lookup_dwo_file_slot): Don't memset dwo_file, call
 394         unique_ptr::get.
 395         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 396         (create_dwo_unit_in_dwp_v2): Likewise.
 397         (open_and_init_dwo_file): Likewise.
 398         (free_dwo_file_from_slot): Remove.
 399
 400 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 401
 402         * dwarf2read.h (struct dwarf2_section_info) <readin,
 403         is_virtual>: Change type to bool.
 404         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 405         true instead of 1.
 406
 407 2019-06-19  Tom Tromey  <tom@tromey.com>
 408
 409         * tui/tui-data.h (tui_init_content_element): Don't declare.
 410
 411 2019-06-19  Tom Tromey  <tom@tromey.com>
 412
 413         * tui/tui-data.h (tui_init_win_info): Don't declare.
 414
 415 2019-06-19  Tom de Vries  <tdevries@suse.de>
 416
 417         * dwarf2read.h (abstract_to_concrete): Change type to
 418         std::unordered_map<sect_offset, std::vector<sect_offset>,
 419         gdb::hash_enum<sect_offset>>.
 420
 421 2019-06-19  Tom Tromey  <tromey@adacore.com>
 422
 423         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 424         EVAL_AVOID_SIDE_EFFECTS specially.
 425
 426 2019-06-19  Tom Tromey  <tromey@adacore.com>
 427
 428         * source-cache.c (highlighter): New global.
 429         (source_cache::get_source_lines): Create a highlighter on demand.
 430
 431 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 432
 433         * defs.h (deprecated_interactive_hook): Delete declaration.
 434         * interps.c (clear_interpreter_hooks): Remove use of
 435         deprecated_interactive_hook.
 436         * top.c (deprecated_interactive_hook): Delete definition.
 437         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 438
 439 2019-06-18  Tom de Vries  <tdevries@suse.de>
 440
 441         PR gdb/24515
 442         * dwarf2read.h (abstract_to_concrete): Change type from
 443         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 444         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 445         * dwarf2read.c (read_variable): Update.
 446         (dwarf2_fetch_die_loc_sect_off): Update.
 447
 448 2019-06-17  Tom de Vries  <tdevries@suse.de>
 449
 450         PR gdb/24617
 451         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 452         accessing parent[parent_len - 1].
 453
 454 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 455
 456         PR gdb/24364
 457         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 458         call dtrace_process_dof with NULL dof.
 459
 460 2019-06-16  Tom de Vries  <tdevries@suse.de>
 461
 462         PR gdb/24445
 463         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 464
 465 2019-06-16  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 468         (make_all_visible): Use address of member.
 469
 470 2019-06-16  Tom Tromey  <tom@tromey.com>
 471
 472         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 473         (tui_free_window, free_content, free_content_elements): Remove
 474         unnecessary cast.
 475         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 476         cast.
 477         * tui/tui-regs.c (tui_show_register_group)
 478         (tui_display_registers_from, tui_display_reg_element_at_line):
 479         Remove unnecessary cast.
 480
 481 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 482
 483         * linux-nat.c (normal_mask): Delete.
 484         (_initialize_linux_nat): Don't initialise normal_mask.
 485
 486 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 487
 488         PR gdb/24445
 489         * dwarf-index-write.h (write_psymtabs_to_index): Add
 490         dwz_basename parameter.
 491         * dwarf-index-write.c (write_gdbindex): Move file writing to
 492         write_gdbindex_1.  Change return type void.
 493         (assert_file_size): Move up, remove filename parameter.
 494         (write_gdbindex_1): New function.
 495         (write_debug_names): Change return type to void, call
 496         assert_file_size.
 497         (struct index_wip_file): New struct.
 498         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 499         file logic to index_wip_file.  Write index for dwz file if
 500         needed.
 501         (save_gdb_index_command): Pass basename of dwz file, if present.
 502         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 503         build-id of dwz file, if present.
 504         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 505         (dwarf2_get_dwz_file): Likewise.
 506         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 507         (dwarf2_get_dwz_file): Likewise.
 508
 509 2019-06-16  Tom Tromey  <tom@tromey.com>
 510
 511         * coffread.c (process_coff_symbol): Use xstrdup.
 512         * value.c (create_internalvar): Use xstrdup.
 513
 514 2019-06-16  Tom Tromey  <tom@tromey.com>
 515
 516         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 517         * breakpoint.c (stopin_command, stopat_command)
 518         (until_break_command, decode_location_default): Remove unnecessary
 519         cast.
 520         * utils.c (subset_compare): Remove unnecessary cast.
 521         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 522         cast.
 523         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 524         cast.
 525         * infcmd.c (path_command): Remove unnecessary cast.
 526         * coffread.c (decode_type): Remove unnecessary cast.
 527         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 528         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 529         * tui/tui-stack.c (tui_show_locator_content)
 530         (tui_show_frame_info): Remove unnecessary cast.
 531         * tui/tui-win.c (tui_scroll_forward_command)
 532         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 533         (parse_scrolling_args): Remove unnecessary cast.
 534         * tui/tui-data.c (init_win_info, tui_del_window)
 535         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 536         (free_content_elements): Remove unnecessary cast.
 537         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 538         unnecessary cast.
 539         * tui/tui-source.c (tui_set_source_content)
 540         (tui_vertical_source_scroll): Remove unnecessary cast.
 541         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 542         cast.
 543         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 544         * tui/tui-regs.c (tui_display_registers_from)
 545         (tui_display_register): Remove unnecessary cast.
 546         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 547         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 548         (make_visible): Remove unnecessary cast.
 549         * tui/tui-winsource.c (tui_erase_source_content)
 550         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 551         unnecessary cast.
 552         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 553         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 554         * stabsread.c (read_type, read_array_type, read_range_type):
 555         Remove unnecessary cast.
 556         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 557         (parse_symbol, parse_type, upgrade_type, parse_external)
 558         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 559         unnecessary cast.
 560         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 561
 562 2019-06-16  Tom Tromey  <tom@tromey.com>
 563
 564         * tui/tui-data.c (tui_alloc_generic_win_info)
 565         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 566         checks.
 567
 568 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 569             Andrew Burgess  <andrew.burgess@embecosm.com>
 570
 571         * f-typeprint.c (f_print_type): Don't return early for not
 572         associated or not allocated types.
 573         (f_type_print_varspec_suffix): Add print_rank parameter and print
 574         ranks of array types in case they dangling.
 575         (f_type_print_base): Add print_rank parameter.
 576
 577 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 578
 579         * NEWS: Mention new MI commands.
 580         * break-catch-throw.c (enum exception_event_kind): Move to
 581         breakpoint.h.
 582         (print_mention_exception_catchpoint): Output text as a single
 583         message.
 584         (catch_exception_command_1): Rename to...
 585         (catch_exception_event): ...this, make non-static, update header
 586         command, and change some parameter types.
 587         (catch_catch_command): Update for changes to
 588         catch_exception_command_1.
 589         (catch_throw_command): Likewise.
 590         (catch_rethrow_command): Likewise.
 591         * breakpoint.c (enum exception_event_kind): Delete.
 592         * breakpoint.h (enum exception_event_kind): Moved here from
 593         break-catch-throw.c.
 594         (catch_exception_event): Declare.
 595         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 596         (mi_cmd_catch_throw): New function.
 597         (mi_cmd_catch_rethrow): New function.
 598         (mi_cmd_catch_catch): New function.
 599         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 600         'catch-catch' entries.
 601         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 602         (mi_cmd_catch_rethrow): Declare.
 603         (mi_cmd_catch_catch): Declare.
 604
 605 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 606
 607         * annotate.c (annotate_source_line): Change return type to void,
 608         update implementation to match.
 609         * annotate.h (annotate_source_line): Change return type to void,
 610         update header comment.
 611         * stack.c (print_frame_info): Don't change what frame information
 612         is printed based on whether annotations are on or not.
 613
 614 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 615
 616         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 617         (annotate_source): Make static.
 618         (annotate_source_line): Moved from source.c and renamed from
 619         identify_source_line.  Update the return type.
 620         * annotate.h (annotate_source): Delete declaration.
 621         (annotate_source_line): Declaration moved from source.h, and
 622         renamed from identify_source_line.  Return type updated.
 623         * source.c (identify_source_line): Moved to annotate.c and renamed
 624         to annotate_source_line.
 625         (info_line_command): Remove check of annotation_level.
 626         * source.h (identify_source_line): Move declaration to annotate.h
 627         and rename to annotate_source_line.
 628         * stack.c: Add 'annotate.h' include.
 629         (print_frame_info): Remove check of annotation_level before
 630         calling annotate_source_line.
 631
 632 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 633
 634         * source-cache.c (source_cache::get_plain_source_lines): Use
 635         open_source_file_with_line_charpos instead of just
 636         open_source_file, remove call to find_source_lines.
 637         (source_cache::get_source_lines): Likewise.
 638         * source.c (find_source_lines): Make static.
 639         (get_filename_and_charpos): Renamed into...
 640         (open_source_file_with_line_charpos): ..this along with changes to
 641         return a scoped_fd, and some other minor clean ups.
 642         (identify_source_line): Use open_source_file_with_line_charpos.
 643         (search_command_helper): Use open_source_file_with_line_charpos
 644         instead of just open_source_file, remove call to
 645         find_source_lines.
 646         * source.h (open_source_file_with_line_charpos): Declare new
 647         function.
 648         (find_source_lines): Delete declaration.
 649
 650 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 651
 652         * source.c (get_filename_and_charpos): Remove fullname
 653         parameter.
 654         (identify_source_line): Update call to get_filename_and_charpos.
 655
 656 2019-06-14  Tom Tromey  <tromey@adacore.com>
 657
 658         PR gdb/24502:
 659         * ui-style.h (skip_ansi_escape): Update comment.
 660         * ui-file.h (class no_terminal_escape_file): New class.
 661         * ui-file.c (no_terminal_escape_file::write)
 662         (no_terminal_escape_file::puts): New methods.
 663         * cli/cli-logging.c (handle_redirections): Use
 664         no_terminal_escape_file.
 665
 666 2019-06-14  Tom Tromey  <tromey@adacore.com>
 667
 668         * NEWS: Move convenience variable news above Python news.
 669
 670 2019-06-14  Tom Tromey  <tom@tromey.com>
 671
 672         * gnulib: Move directory to top-level.
 673         * configure.ac: Don't configure gnulib.
 674         * configure: Rebuild.
 675         * common/common-defs.h: Use new path to gnulib.
 676         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 677         (GNULIB_H): Remove.
 678         (INCGNU): Look in new gnulib location.
 679         (HFILES_NO_SRCDIR): Remove gnulib files.
 680         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 681         (generated_files): Remove GNULIB_H.
 682         ($(LIBGNU), all-lib): Remove targets.
 683         (distclean): Don't mention GNULIB_BUILDDIR.
 684         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 685
 686 2019-06-14  Tom Tromey  <tromey@adacore.com>
 687
 688         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 689         Warn if symbol file does not provide any symbols.
 690
 691 2019-06-14  Tom Tromey  <tromey@adacore.com>
 692
 693         * source.c (find_and_open_source): Respect basenames_may_differ.
 694
 695 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 696
 697         * annotate.c (annotate_breakpoints_invalid): Make use of
 698         scoped_restore_terminal_state.
 699         (annotate_frames_invalid): Likewise.
 700
 701 2019-06-14  Tom Tromey  <tromey@adacore.com>
 702
 703         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 704         allow assignment to an internalvar.
 705
 706 2019-06-14  Tom Tromey  <tromey@adacore.com>
 707
 708         * ada-lex.l: Allow "_" in attribute names.
 709
 710 2019-06-14  Tom Tromey  <tromey@adacore.com>
 711
 712         PR gdb/24653:
 713         * regcache.c (registers_changed): Don't call alloca.
 714         * top.c (execute_command): Don't call alloca.
 715
 716 2019-06-13  Pedro Alves  <palves@redhat.com>
 717
 718         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 719         'expression'.  When parsing an expression, error out if there's
 720         junk after "unlimited".
 721         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 722         (do_set_command): Adjust calls to is_unlimited_literal.
 723
 724 2019-06-13  Pedro Alves  <palves@redhat.com>
 725
 726         * compile/compile.c (make_compile_options_def_group): Add braces
 727         around array_view initializer.
 728         * thread.c (make_thread_apply_all_options_def_group)
 729         (make_thread_apply_all_options_def_group): Likewise.
 730
 731 2019-06-13  Pedro Alves  <palves@redhat.com>
 732
 733         * NEWS (New commands): Mention "maint test-options
 734         require-delimiter", "maint test-options unknown-is-error", "maint
 735         test-options unknown-is-operand" and "maint show
 736         test-options-completion-result".
 737         (New command options, command completion): New section.
 738         (Completion improvements): New section.
 739         Mention that you can abbreviate "unlimited".
 740
 741 2019-06-13  Pedro Alves  <palves@redhat.com>
 742
 743         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 744         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 745         * unittests/cli-utils-selftests.c (test_parse_flags)
 746         (test_parse_flags_qcs): Delete.
 747         (test_cli_utils): Don't call deleted functions.
 748
 749 2019-06-13  Pedro Alves  <palves@redhat.com>
 750
 751         * thread.c: Include "cli/cli-option.h".
 752         (tp_array_compar_ascending): Global.
 753         (tp_array_compar): Delete function.
 754         (tp_array_compar_ascending, tp_array_compar_descending): New
 755         functions.
 756         (ascending_option_def, qcs_flag_option_def)
 757         (thr_qcs_flags_option_defs)
 758         (make_thread_apply_all_options_def_group)
 759         (make_thread_apply_options_def_group): New.
 760         (thread_apply_all_command): Use gdb::option::process_options.
 761         (thread_apply_command_completer)
 762         (thread_apply_all_command_completer): New.
 763         (thread_apply_command): Use gdb::option::process_options.
 764         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 765         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 766         to generate help text of "thread apply".  Adjust "taas"'s help.
 767         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 768         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 769
 770 2019-06-13  Pedro Alves  <palves@redhat.com>
 771
 772         * thread.c (thread_apply_command): Check for invalid TID with
 773         isdigit instead of !isalpha.
 774
 775 2019-06-13  Pedro Alves  <palves@redhat.com>
 776
 777         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 778         (validate_flags_qcs): New.
 779         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 780         (validate_flags_qcs): Declare.
 781         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 782         (make_frame_apply_options_def_group): New.
 783         (frame_apply_command_count): Process options with
 784         gdb::option::process_options.
 785         (frame_apply_completer): New.
 786         (frame_apply_level_completer, frame_apply_all_completer)
 787         (frame_apply_completer): New.
 788         (_initialize_stack): Update help of "frame apply", "frame apply
 789         level", "frame apply all" and "faas" to mention supported options
 790         and install command completers.
 791         * stack.h (frame_apply_all_completer): Declare.
 792         * thread.c: Include "stack.h".
 793         (tfaas_command): Add "--".
 794         (_initialize_thread): Update help "tfaas" to mention supported
 795         options and install command completer.
 796
 797 2019-06-13  Pedro Alves  <palves@redhat.com>
 798
 799         * completer.c (complete_nested_command_line): New.
 800         (gdb_completion_word_break_characters_throw): Add assertion.
 801         * completer.h (complete_nested_command_line): Declare.
 802
 803 2019-06-13  Pedro Alves  <palves@redhat.com>
 804
 805         * stack.c (parse_backtrace_qualifiers): New.
 806         (backtrace_command): Use it.
 807         (backtrace_command_completer): Complete on qualifiers.
 808
 809 2019-06-13  Pedro Alves  <palves@redhat.com>
 810
 811         * frame.c: Include "cli/cli-option.h.
 812         (user_set_backtrace_options): New.
 813         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 814         Delete.
 815         (get_prev_frame): Adjust.
 816         (boolean_option_def, uinteger_option_def)
 817         (set_backtrace_option_defs): New.
 818         (_initialize_frame): Adjust and use
 819         gdb::option::add_setshow_cmds_for_options to install "set
 820         backtrace past-main" and "set backtrace past-entry".
 821         * frame.h: Include "cli/cli-option.h".
 822         (struct frame_print_options): Forward declare.
 823         (print_frame_arguments_all, print_frame_arguments_scalars)
 824         (print_frame_arguments_none): Declare.
 825         (print_entry_values): Delete declaration.
 826         (struct frame_print_options, user_frame_print_options): New.
 827         (struct set_backtrace_options): New.
 828         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 829         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 830         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 831         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 832         (list_args_or_locals): Add frame_print_options parameter.
 833         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 834         * python/py-framefilter.c (enumerate_args): Pass down
 835         USER_FRAME_PRINT_OPTIONS.
 836         * stack.c: Include "cli/cli-option.h".
 837         (print_frame_arguments_all, print_frame_arguments_scalars)
 838         (print_frame_arguments_none): Declare.
 839         (print_raw_frame_arguments, print_entry_values): Delete.
 840         (user_frame_print_options): New.
 841         (boolean_option_def, enum_option_def, frame_print_option_defs):
 842         New.
 843         (struct backtrace_cmd_options): New.
 844         (bt_flag_option_def): New.
 845         (backtrace_command_option_defs): New.
 846         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 847         (print_frame_arg, read_frame_arg, print_frame_args)
 848         (print_frame_info, print_frame): Add frame_print_options parameter
 849         and use it.
 850         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 851         (backtrace_command_1): Add frame_print_options and
 852         backtrace_cmd_options parameters and use them.
 853         (make_backtrace_options_def_group): New.
 854         (backtrace_command): Process command options with
 855         gdb::option::process_options.
 856         (backtrace_command_completer): New.
 857         (_initialize_stack): Extend "backtrace"'s help to mention
 858         supported options.  Install completer for "backtrace".
 859         Install some settings commands with add_setshow_cmds_for_options.
 860
 861 2019-06-13  Pedro Alves  <palves@redhat.com>
 862
 863         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 864         and that "set/show print raw frame-arguments" are now deprecated.
 865
 866         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 867         command.
 868         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 869         * stack.c (_initialize_stack): Install "set/show print
 870         raw-frame-arguments", and deprecate "set/show print raw
 871         frame-arguments".
 872         * valprint.c (_initialize_valprint): Deprecate "set/show print
 873         raw".
 874
 875 2019-06-13  Pedro Alves  <palves@redhat.com>
 876
 877         * compile/compile.c (struct compile_options): New.
 878         (compile_flag_option_def, compile_command_option_defs)
 879         (make_compile_options_def_group): New.
 880         (compile_file_command): Handle options with
 881         gdb::option::process_options.
 882         (compile_file_command_completer): New function.
 883         (compile_code_command): Handle options with
 884         gdb::option::process_options.
 885         (compile_code_command_completer): New function.
 886         (_initialize_compiler): Install completers for "compile code" and
 887         "compile file".  Mention available options in "compile code" and
 888         "compile code"'s help.
 889         * completer.c (advance_to_completion_word): New, factored out from
 890         ...
 891         (advance_to_expression_complete_word_point): ... this.
 892         (advance_to_filename_complete_word_point): New.
 893         * completer.h (advance_to_filename_complete_word_point): New
 894         declaration.
 895
 896 2019-06-13  Pedro Alves  <palves@redhat.com>
 897
 898         * compile/compile.c: Include "cli/cli-option.h".
 899         (compile_print_value): Scope data pointer is now a
 900         value_print_options pointer; adjust.
 901         (compile_print_command): Process options.  Scope data pointer is
 902         now a value_print_options pointer; adjust.
 903         (_initialize_compile): Update "compile print"'s help to include
 904         supported options.  Install a completer for "compile print".
 905         * cp-valprint.c (show_vtblprint, show_objectprint)
 906         (show_static_field_print): Delete.
 907         (_initialize_cp_valprint): Don't install "set print
 908         static-members", "set print vtbl", "set print object" here.
 909         * printcmd.c: Include "cli/cli-option.h" and
 910         "common/gdb_optional.h".
 911         (print_command_parse_format): Rework to fill in a
 912         value_print_options instead of a format_data.
 913         (print_value): Change parameter type from format_data pointer to
 914         value_print_options reference.  Adjust.
 915         (print_command_1): Process options.  Adjust to pass down a
 916         value_print_options.
 917         (print_command_completer): New.
 918         (_initialize_printcmd): Install print_command_completer as
 919         handle_brkchars completer for the "print" command.  Update
 920         "print"'s help to include supported options.
 921         * valprint.c: Include "cli/cli-option.h".
 922         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 923         here from cp-valprint.c.
 924         (boolean_option_def, uinteger_option_def)
 925         (value_print_option_defs, make_value_print_options_def_group):
 926         New.  Use gdb::option::add_setshow_cmds_for_options to install
 927         "set print elements", "set print null-stop", "set print repeats",
 928         "set print pretty", "set print union", "set print array", "set
 929         print address", "set print symbol", "set print array-indexes".
 930         * valprint.h: Include <string> and "cli/cli-option.h".
 931         (make_value_print_options_def_group): Declare.
 932         (print_value): Change parameter type from format_data pointer to
 933         value_print_options reference.
 934         (print_command_completer): Declare.
 935
 936 2019-06-13  Pedro Alves  <palves@redhat.com>
 937
 938         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 939         (COMMON_SFILES): Add maint-test-settings.c.
 940         * cli/cli-decode.c (boolean_enums): New global, factored out from
 941         ...
 942         (add_setshow_boolean_cmd): ... here.
 943         * cli/cli-decode.h (boolean_enums): Declare.
 944         * cli/cli-option.c: New file.
 945         * cli/cli-option.h: New file.
 946         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 947         factored out from ...
 948         (parse_cli_boolean_value(const char *)): ... this.
 949         (is_unlimited_literal): Change parameter type to pointer to
 950         pointer.  Adjust and advance ARG pointer.
 951         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 952         (parse_cli_var_enum): New, factored out from ...
 953         (do_set_command): ... this.  Adjust.
 954         * cli/cli-setshow.h (parse_cli_boolean_value)
 955         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 956         (parse_cli_var_enum): Declare.
 957         * cli/cli-utils.c: Include "cli/cli-option.h".
 958         (get_ulongest): New.
 959         * cli/cli-utils.h (get_ulongest): Declare.
 960         (check_for_argument): New overloads.
 961         * maint-test-options.c: New file.
 962
 963 2019-06-13  Pedro Alves  <palves@redhat.com>
 964
 965         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 966         parse a range if "-" is at the end of the string.
 967
 968 2019-06-13  Pedro Alves  <palves@redhat.com>
 969
 970         * cli/cli-setshow.c (parse_auto_binary_operation)
 971         (parse_cli_boolean_value): Don't allow "o".
 972
 973 2019-06-13  Pedro Alves  <palves@redhat.com>
 974
 975         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 976         * NEWS: Mention maint test-settings KIND.
 977         * maint-test-settings.c: New file.
 978
 979 2019-06-13  Pedro Alves  <palves@redhat.com>
 980
 981         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 982         completer.
 983         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 984         "set" completers.
 985
 986 2019-06-13  Pedro Alves  <palves@redhat.com>
 987
 988         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 989         after item.
 990
 991 2019-06-13  Pedro Alves  <palves@redhat.com>
 992
 993         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 994
 995 2019-06-13  Pedro Alves <palves@redhat.com>
 996
 997         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 998         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 999         call.
1000         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1001         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1002         calls.
1003         (check_for_argument): Skip spaces after argument.
1004
1005 2019-06-13  Pedro Alves  <palves@redhat.com>
1006
1007         * thread.c (thread_apply_command): Adjust TID parsing.
1008         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1009         detected before end of string.
1010         (tid_is_in_list): Error out if LIST is invalid.
1011
1012 2019-06-13  Pedro Alves  <palves@redhat.com>
1013
1014         * completer.c (complete_line_internal_1): Rewind completion word
1015         point.
1016         (completion_tracker::advance_custom_word_point_by): Change
1017         parameter type to int.
1018         * completer.h (completion_tracker::advance_custom_word_point_by):
1019         Likewise.
1020
1021 2019-06-13  Pedro Alves  <palves@redhat.com>
1022
1023         * completer.c (advance_to_completion_word): Handle delimiters.
1024
1025 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1026
1027         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1028
1029 2019-06-11  Tom Tromey  <tom@tromey.com>
1030
1031         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1032         (xmalloc_failed): Move to alloc.c.
1033         * alloc.c: New file.
1034         * Makefile.in (COMMON_SFILES): Add alloc.c.
1035
1036 2019-06-11  Tom Tromey  <tom@tromey.com>
1037
1038         * nat/linux-waitpid.c: Don't include server.h.
1039         (linux_debug): Remove.
1040         (my_waitpid): Update.
1041
1042 2019-06-11  Tom Tromey  <tromey@adacore.com>
1043
1044         * infcall.c (_initialize_infcall): Remove trailing newline from
1045         help.
1046         * user-regs.c (_initialize_user_regs): Remove trailing newline
1047         from help.
1048         * typeprint.c (_initialize_typeprint): Remove trailing newline
1049         from help.
1050         * reverse.c (_initialize_reverse): Remove trailing newlines from
1051         help.
1052         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1053         from help.
1054         * language.c (add_set_language_command): Remove trailing newline
1055         from help.
1056         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1057         help.
1058         * disasm.c (_initialize_disasm): Remove trailing newline from
1059         help.
1060         * top.c (init_main): Remove trailing newline from help.
1061         * interps.c (_initialize_interpreter): Remove trailing newline
1062         from help.
1063         * btrace.c (_initialize_btrace): Remove trailing newlines from
1064         help.
1065         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1066         from help.
1067         * python/python.c (_initialize_python): Remove trailing newline
1068         from help.
1069         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1070         help.
1071         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1072         from help.  Reformat some text.
1073         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1074         from help.
1075         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1076         newline from help.
1077
1078 2019-06-11  Tom Tromey  <tromey@adacore.com>
1079
1080         * darwin-nat.c (darwin_decode_exception_message)
1081         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1082
1083 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1084
1085         * valops.c (value_slice): Check for not allocated or not
1086         associated values.
1087
1088 2019-06-10  Tom de Vries  <tdevries@suse.de>
1089
1090         PR gdb/24618
1091         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1092         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1093         invalid.
1094
1095 2019-06-10  Tom de Vries  <tdevries@suse.de>
1096
1097         PR gdb/24611
1098         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1099         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1100
1101 2019-06-10  Tom de Vries  <tdevries@suse.de>
1102
1103         PR symtab/24545
1104         * symtab.c (struct demangled_name_entry): Add language field.
1105         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1106         static minimal symbol".  Set and use language field.
1107
1108 2019-06-10  Tom Tromey  <tromey@adacore.com>
1109
1110         * ada-lang.c (_initialize_ada_language): Update help text.
1111
1112 2019-06-10  Tom Tromey  <tromey@adacore.com>
1113
1114         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1115         with a newline.
1116         * guile/guile.c (handle_boot_error): Don't end warning with a
1117         newline.
1118         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1119         warning with a newline.
1120         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1121         newline.
1122         (s12z_frame_cache): Likewise.
1123         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1124         a newline.
1125         * solib-svr4.c (disable_probes_interface): Don't end warning with
1126         a newline.
1127         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1128         newline.
1129         * python/python.c (do_finish_initialization): Don't end warning
1130         with a newline.
1131
1132 2019-06-10  Tom Tromey  <tom@tromey.com>
1133
1134         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1135         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1136         gdbpy_enter.
1137
1138 2019-06-10  Tom Tromey  <tromey@adacore.com>
1139
1140         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1141         data.
1142         (elf_new_init): Don't call stabsread_new_init.
1143         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1144         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1145         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1146
1147 2019-06-10  Tom de Vries  <tdevries@suse.de>
1148
1149         PR symtab/16264
1150         PR symtab/24517
1151         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1152
1153 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1154
1155         * source.c (find_and_open_source): Also rewrite relative file
1156         names.
1157
1158 2019-04-26  Amos Bird  <amosbird@gmail.com>
1159
1160         * annotate.c (annotate_thread_exited): Add "thread-exited"
1161         annotation.
1162
1163 2019-06-06  Tom Tromey  <tromey@adacore.com>
1164
1165         * maint.h (class scoped_command_stats): Use
1166         DISABLE_COPY_AND_ASSIGN.
1167         <print_time>: New method.
1168         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1169         print_time.
1170         (scoped_command_stats::print_time): New method.
1171
1172 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1173
1174         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1175         instructions of lengths 6 or 8 bytes.
1176
1177 2019-06-04  Pedro Alves  <palves@redhat.com>
1178
1179         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1180
1181         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1182         * breakpoint.c (condition_completer): Likewise.
1183         * cli/cli-dump.c (scan_expression): Likewise.
1184         * common/filestuff.c (mkdir_recursive): Likewise.
1185         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1186         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1187         (gdb_abspath): Likewise.
1188         * compile/compile-cplus-types.c
1189         (compile_cplus_instance::decl_name): Likewise.
1190         * completer.c (complete_explicit_location):
1191         (signal_completer, reg_or_group_completer_1): Likewise.
1192         * cp-support.c (cp_remove_params_if_any): Likewise.
1193         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1194         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1195         * infcmd.c (strip_bg_char): Likewise.
1196         * linespec.c (copy_token_string): Likewise.
1197         * mi/mi-main.c (output_cores): Likewise.
1198         * psymtab.c (psymtab_search_name):
1199         * symfile.c (test_set_ext_lang_command): Likewise.
1200         * target.c (target_fileio_read_stralloc): Likewise.
1201         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1202         * value.c (complete_internalvar): Likewise.
1203
1204 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1205
1206         Add objfile property to gdb.Type.
1207         * NEWS: Mention Python API addition.
1208         * python/py-type.c (typy_get_objfile): New method.
1209
1210 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1211
1212         * NEWS: Mention the new set|show style [title|highlight].
1213         Mention changes to "show style", "help" and "apropos".
1214
1215 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1216
1217         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1218         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1219         instead of print_help_for_command.
1220         (print_doc_of_command): New function.
1221         (help_list): Add 'apropos -v word' suggestion.
1222         (print_help_for_command): Style the command name using title style.
1223         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1224         (_initialize_cli_cmds): Describe -v in apropos_command help.
1225
1226 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1227
1228         * cli/cli-style.h (cli_style_option): Add name in constructor,
1229         add m_name class member, add constructor with intensity,
1230         add name class function.
1231         (cli_style_option::add_setshow_commands): Remove name argument.
1232         (highlight_style, title_style): New styles.
1233         * cli/cli-style.c (do_show): New function that shows a style
1234         characteristic styling the style name with itself.
1235         (set_style_name): New function.
1236         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1237         Update all callers according to the changes in cli/cli-style.h.
1238         * utils.h (fputs_highlighted): New function.
1239         * utils.c (fputs_highlighted): Likewise.
1240
1241 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1242
1243         * NEWS: Mention new pipe command and new convenience variables.
1244
1245 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1246
1247         * cli/cli-cmds.c (pipe_command): New function.
1248         (_initialize_cli_cmds): Call add_com for pipe_command.
1249         Define | as an alias for pipe.
1250         (exit_status_set_internal_vars): New function.
1251         (shell_escape): Call exit_status_set_internal_vars.
1252         cli/cli-decode.c (find_command_name_length): Recognize | as
1253         a single character command.
1254
1255 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1256
1257         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1258         top.c (execute_command_to_ui_file): New function, mostly a copy
1259         of execute_command_to_string.
1260         (execute_command_to_string): Implement by calling
1261         execute_command_to_ui_file.
1262
1263 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1264
1265         * top.h (saved_command_line): Remove declaration.
1266         * top.c (previous_saved_command_line, previous_repeat_arguments):
1267         New variables.
1268         (saved_command_line): Make static, define together with other
1269         'repeat variables'.
1270         (dont_repeat): Clear repeat_arguments.
1271         (repeat_previous, get_saved_command_line, save_command_line):
1272         New functions.
1273         (gdb_init): Initialize saved_command_line
1274         and previous_saved_command_line.
1275         * main.c (captured_main_1): Remove saved_command_line initialization.
1276         * event-top.c (handle_line_of_input): Update to use
1277         the new 'repeat' related functions instead of direct access to
1278         saved_command_line.
1279         * command.h (repeat_previous, get_saved_command_line,
1280         save_command_line): New declarations.
1281         (dont_repeat): Add comment.
1282
1283 2019-05-30  Tom Tromey  <tromey@adacore.com>
1284
1285         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1286         Fix comment.
1287         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1288
1289 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1290
1291         PR cli/24587
1292         * completer.c (complete): Initialize variable word.
1293
1294 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1295
1296         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1297         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1298         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1299         'body' is NULL to the outter 'if', protecting the '!is_define'
1300         situation as well.
1301
1302 2019-05-29  Tom Tromey  <tromey@adacore.com>
1303
1304         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1305         (dwarf_unknown): New function.
1306         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1307         (dwarf_type_encoding_name): Use dwarf_unknown.
1308
1309 2019-05-29  Tom Tromey  <tromey@adacore.com>
1310
1311         PR c++/20020:
1312         * cp-valprint.c (cp_print_value_fields): Call
1313         cp_print_static_field inside "try".
1314
1315 2019-05-29  Tom Tromey  <tromey@adacore.com>
1316
1317         * inflow.c (struct terminal_info): Add default operator=.
1318         * configure: Rebuild.
1319         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1320         -Wdeprecated-copy-dtor, -Wredundant-move.
1321
1322 2019-05-29  Tom Tromey  <tromey@adacore.com>
1323
1324         * NEWS: Add entry.
1325         * infcmd.c (print_return_value_1): Handle finish_print
1326         option.
1327         (show_print_finish): New function.
1328         (_initialize_infcmd): Add "set/show print finish" commands.
1329         * valprint.c (user_print_options): Initialize new member.
1330         * valprint.h (struct value_print_options) <finish_print>: New
1331         member.
1332
1333 2019-05-28  Tom Tromey  <tromey@adacore.com>
1334
1335         * ada-lang.c (ada_remove_Xbn_suffix)
1336         (find_old_style_renaming_symbol)
1337         (parse_old_style_renaming): Remove.
1338         (ada_find_renaming_symbol): Don't call
1339         find_old_style_renaming_symbol.
1340         (ada_is_renaming_symbol): Rename from
1341         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1342         bool.  Now static.
1343         (ada_read_var_value): Update and simplify.
1344         * ada-exp.y (write_var_or_type): Remove old code.
1345
1346 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1347
1348         * event-top.c: Remove include comment.
1349         * inflow.c (class scoped_ignore_sigttou): Move from here...
1350         * inflow.h (class scoped_ignore_sigttou): ...to here.
1351         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1352         * top.c:  Remove include comment.
1353
1354 2019-05-27  Tom Tromey  <tom@tromey.com>
1355
1356         * NEWS: Fix typo.
1357
1358 2019-05-22  Tom Tromey  <tromey@adacore.com>
1359
1360         * target.c (target_follow_exec): Constify parameter.
1361         * target-delegates.c: Rebuild.
1362         * remote.c (remote_target::follow_exec): Constify parameter.
1363         * infrun.c (follow_exec): Constify parameter.
1364         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1365         (target_follow_exec): Likewise.
1366
1367 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1368
1369         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1370         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1371
1372 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1373
1374         * NEWS: Add debugredirect and testsuite sections.
1375
1376 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1377
1378         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1379         target descriptions using exclusively floating point register name
1380         aliases.
1381
1382 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1383
1384         PR gdb/18644:
1385         * f-lang.c (build_fortran_types): Handle the case where
1386         gdbarch_floatformat_for_type returns a nullptr.
1387
1388 2019-05-21  Tom de Vries  <tdevries@suse.de>
1389
1390         PR cli/24587
1391         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1392
1393 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1394
1395         PR gdb/18644:
1396         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1397         16-byte floats.
1398         * i386-tdep.c (i386_floatformat_for_type): Use
1399         floatformats_ia64_quad for the 16-byte floating point component
1400         within a fortran 32-byte complex number.
1401
1402 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1403
1404         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1405         delete default constructor.
1406         (find_partial_die): Update to return const struct.
1407         (partial_die_parent_scope): Move variable declaration into scope
1408         of its use and change its type to auto.
1409         (guess_partial_die_structure_name): Likewise.
1410         (partial_die_info::fixup): Likewise.
1411
1412 2019-05-17  Tom Tromey  <tromey@adacore.com>
1413
1414         * source.c (find_and_open_source): Remove cast.
1415
1416 2019-05-17  Tom Tromey  <tromey@adacore.com>
1417
1418         * annotate.c (annotate_source): Make "filename" const.
1419         * annotate.h (annotate_source): Use const.
1420
1421 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1422
1423         * disasm.c (set_disassembler_options): Send errors to stderr.
1424
1425 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1426
1427         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1428         (cli_interp_base::set_logging): Check debug_redirect.
1429         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1430         * cli/cli-logging.c (debug_redirect): Add static variable.
1431         (pop_output_files): Add default param.
1432         (handle_redirections): Print debug setting.
1433         (show_logging_command): Likewise.
1434         (_initialize_cli_logging): Add debugredirect command.
1435         * interps.c (current_interp_set_logging): Add debug_redirect
1436         parameter.
1437         * interps.h (set_logging): Add debug_redirect parameter.
1438         (current_interp_set_logging): Likewise.
1439         * mi/mi-common.h: Likewise.
1440         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1441
1442 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1443             Tom Tromey  <tromey@adacore.com>
1444
1445         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1446         directly.
1447         * cli/cli-interp.h (make_logging_output): Remove declaration.
1448         * cli/cli-logging.c (make_logging_output): Remove function.
1449         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1450         directly.
1451         * ui-file.c (tee_file::tee_file): Remove bools.
1452         (tee_file::~tee_file): Remove deletes.
1453         * ui-file.h (tee_file): Remove bools.
1454
1455 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1456
1457         * mi/mi-cmds.h (mi_cmd_complete): New function.
1458         * mi/mi-main.c (mi_cmd_complete): Likewise.
1459         * mi/mi-cmds.c: Define new MI command -complete.
1460         * NEWS: Mention new -complete command.
1461
1462 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1463
1464         * completer.h (complete): New function.
1465         * completer.c (complete): Likewise.
1466         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1467         function defined in completer.h.
1468
1469 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1470
1471         * MAINTAINERS (Write After Approval): Add myself.
1472
1473 2019-05-17  Tom de Vries  <tdevries@suse.de>
1474
1475         PR gdb/24094
1476         * dwarf2read.c (struct cu_partial_die_info): New struct.
1477         (find_partial_die): Return cu_partial_die_info.
1478         (partial_die_parent_scope, guess_partial_die_structure_name)
1479         (partial_die_info::fixup): Handle new return type of find_partial_die.
1480
1481 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1482
1483         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1484         "std::string", simplifying the algorithm.
1485
1486 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1487
1488         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1489         (stap_static_probe_ops::get_probes): Likewise.
1490
1491 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1492
1493         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1494         '-')" and "else if".
1495         (stap_parse_single_operand): Join checks for
1496         "gdbarch_stap_parse_special_token_p" and
1497         "gdbarch_stap_parse_special_token" in the same "if" statement.
1498         Invert check when verifying for operation on register
1499         displacement.
1500
1501 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1502
1503         * stap-probe.c (stap_get_opcode): Update comment.
1504         (stap_get_expected_argument_type): Likewise.
1505         (handle_stap_probe): Likewise.
1506
1507 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1508
1509         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1510         return type to 'bool'.  Adjust comment.  Use 'bool' when
1511         appropriate.
1512         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1513         * stap-probe.c (stap_parse_argument_1): Likewise.
1514         (stap_is_operator): Likewise.
1515         (stap_is_generic_prefix): Likewise.
1516         (stap_is_register_prefix): Likewise.
1517         (stap_is_register_indirection_prefix): Likewise.
1518         (stap_is_integer_prefix): Likewise.
1519         (stap_generic_check_suffix): Likewise.
1520         (stap_check_integer_suffix): Likewise.
1521         (stap_check_register_suffix): Likewise.
1522         (stap_check_register_indirection_suffix): Likewise.
1523         (stap_parse_register_operand): Likewise.
1524         (stap_parse_single_operand): Likewise.
1525         (stap_parse_argument_1): Likewise.
1526         (stap_probe::get_argument_count): Likewise.
1527         (stap_is_operator): Likewise.
1528
1529 2019-05-16  Tom Tromey  <tromey@adacore.com>
1530
1531         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1532         keyword to foreach.
1533
1534 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1535
1536         * linux-thread-db.c (try_thread_db_load_1): Change return type
1537         to bool.
1538         (try_thread_db_load): Likewise.
1539         (try_thread_db_load_from_pdir_1): Likewise.
1540         (try_thread_db_load_from_pdir): Likewise.
1541         (try_thread_db_load_from_sdir): Likewise.
1542         (try_thread_db_load_from_dir): Likewise.
1543         (thread_db_load_search): Likewise.
1544         (has_libpthread): Likewise.
1545         (thread_db_load): Likewise.
1546
1547 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1548
1549         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1550         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1551         NULL, and complain/return if that's the case.
1552
1553 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1554
1555         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1556         (advance, posn, abstract_read_memory): New functions.
1557         [struct mem_read_abstraction]: New struct.
1558         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1559
1560 2019-05-14  Tom Tromey  <tromey@adacore.com>
1561
1562         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1563         value is not lval_memory.
1564
1565 2019-05-14  Tom Tromey  <tromey@adacore.com>
1566
1567         * solib.c (info_sharedlibrary_command): Style the file name.
1568
1569 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1570
1571         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1572         (aarch64_vnv_type): Likewise.
1573         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1574         * common/tdesc.c: Likewise.
1575         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1576         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1577         * features/aarch64-fpu.xml: Add ieee half view.
1578         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1579         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1580         * gdbtypes.h (struct builtin_type): Likewise.
1581         (struct objfile_type): Likewise.
1582
1583 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1584
1585         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1586         typo.
1587         * location.h (string_to_event_location): Likewise.
1588
1589 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1590
1591         GDB 8.3 released.
1592
1593 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1594
1595         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1596         New variable declaration.
1597         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1598         New variable.
1599         (print_one_breakpoint): Use ui_out::test_flags and new global
1600         variable to compute use_fixed_output.
1601         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1602         Remove.
1603         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1604         (mi_multi_location_breakpoint_output_fixed): Remove.
1605         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1606         new variable.
1607         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1608         fix_multi_location_breakpoint_output flag if version >= 3.
1609         * ui-out.h (enum ui_out_flag)
1610         <fix_multi_location_breakpoint_output>: New enumerator.
1611
1612 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1613
1614         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1615
1616 2019-05-10  Tom Tromey  <tromey@adacore.com>
1617
1618         * ada-lang.c (catch_ada_completer): New function.
1619         (_initialize_ada_language): Use it.
1620
1621 2019-05-10  Tom Tromey  <tromey@adacore.com>
1622
1623         * thread.c (print_thread_info): Make "requested_threads" const.
1624         * gdbthread.h (print_thread_info): Make "requested_threads"
1625         const.
1626         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1627         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1628
1629 2019-05-08  Tom Tromey  <tom@tromey.com>
1630
1631         * gdbtypes.c (objfile_type_data): Change type.
1632         (objfile_type, _initialize_gdbtypes): Update.
1633
1634 2019-05-08  Tom Tromey  <tom@tromey.com>
1635
1636         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1637         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1638         (_initialize_dwarf2_frame): Update.
1639
1640 2019-05-08  Tom Tromey  <tom@tromey.com>
1641
1642         * objc-lang.c (objc_objfile_data): Change type.
1643         (find_methods): Update.
1644         (_initialize_objc_lang): Remove.
1645
1646 2019-05-08  Tom Tromey  <tom@tromey.com>
1647
1648         * stabsread.c (rs6000_builtin_type_data): Change type.
1649         (rs6000_builtin_type, _initialize_stabsread): Update.
1650
1651 2019-05-08  Tom Tromey  <tom@tromey.com>
1652
1653         * mips-tdep.c (mips_pdr_data): Remove.
1654         (_initialize_mips_tdep): Update.
1655
1656 2019-05-08  Tom Tromey  <tom@tromey.com>
1657
1658         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1659         (hppa_init_objfile_priv_data, read_unwind_info)
1660         (find_unwind_entry, _initialize_hppa_tdep): Update.
1661
1662 2019-05-08  Tom Tromey  <tom@tromey.com>
1663
1664         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1665         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1666         on obstack.
1667         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1668
1669 2019-05-08  Tom Tromey  <tom@tromey.com>
1670
1671         * mdebugread.c (basic_type_data): Change type.
1672         (basic_type, _initialize_mdebugread): Update.
1673
1674 2019-05-08  Tom Tromey  <tom@tromey.com>
1675
1676         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1677
1678 2019-05-08  Tom Tromey  <tom@tromey.com>
1679
1680         * nto-tdep.c (nto_inferior_data_reg): Change type.
1681         (nto_inferior_data): Update.
1682         (nto_inferior_data_cleanup, nto_new_inferior_data)
1683         (_initialize_nto_tdep): Remove.
1684         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1685
1686 2019-05-08  Tom Tromey  <tom@tromey.com>
1687
1688         * ada-lang.c (struct ada_inferior_data): Add initializers.
1689         (ada_inferior_data): Change type.
1690         (ada_inferior_data_cleanup): Remove.
1691         (get_ada_inferior_data, ada_inferior_exit)
1692         (struct ada_pspace_data): Add initializers, destructor.
1693         (ada_pspace_data_handle): Change type.
1694         (get_ada_pspace_data): Update.
1695         (ada_pspace_data_cleanup): Remove.
1696
1697 2019-05-08  Tom Tromey  <tom@tromey.com>
1698
1699         * coffread.c (struct coff_symfile_info): Add initializers.
1700         (coff_objfile_data_key): Move lower.  Change type.
1701         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1702         Update.
1703         (coff_free_info): Remove.
1704
1705 2019-05-08  Tom Tromey  <tom@tromey.com>
1706
1707         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1708         (fbsd_pspace_data_handle): Move lower.  Change type.
1709         (get_fbsd_pspace_data): Update.
1710         (fbsd_pspace_data_cleanup): Remove.
1711         (_initialize_fbsd_tdep): Update.
1712
1713 2019-05-08  Tom Tromey  <tom@tromey.com>
1714
1715         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1716         (get_ada_tasks_pspace_data): Update.
1717         (ada_tasks_pspace_data_cleanup): Remove.
1718         (_initialize_tasks): Update.
1719         (ada_tasks_inferior_data_handle): Change type.
1720         (get_ada_tasks_inferior_data): Update.
1721         (ada_tasks_inferior_data_cleanup): Remove.
1722         (struct ada_tasks_pspace_data): Add initializers.
1723
1724 2019-05-08  Tom Tromey  <tom@tromey.com>
1725
1726         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1727         * symfile-debug.c (debug_sym_get_probes): Change type.
1728         * stap-probe.c (handle_stap_probe):
1729         (stap_static_probe_ops::get_probes): Change type.
1730         * probe.h (class static_probe_ops) <get_probes>: Change type.
1731         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1732         (parse_probes_in_pspace): Update.
1733         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1734         Update.
1735         (any_static_probe_ops::get_probes): Change type.
1736         * elfread.c (elfread_data): New typedef.
1737         (probe_key): Change type.
1738         (elf_get_probes): Likewise.  Update.
1739         (probe_key_free): Remove.
1740         (_initialize_elfread): Update.
1741         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1742         Change type.
1743         (dtrace_process_dof_probe, dtrace_process_dof)
1744         (dtrace_static_probe_ops::get_probe): Change type.
1745
1746 2019-05-08  Tom Tromey  <tom@tromey.com>
1747
1748         * xcoffread.c (struct xcoff_symfile_info): Rename from
1749         coff_symfile_info.  Add initializers.
1750         (xcoff_objfile_data_key): Move lower.  Change type.
1751         (XCOFF_DATA): Rewrite.
1752         (xcoff_free_info): Remove.
1753         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1754         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1755         (xcoff_initial_scan): Update.
1756
1757 2019-05-08  Tom Tromey  <tom@tromey.com>
1758
1759         * solib-svr4.c (struct svr4_info): Add initializers and
1760         destructor.
1761         <probes_table>: Now an htab_up.
1762         (solib_svr4_pspace_data): Change type.
1763         (free_probes_table): Simplify.
1764         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1765         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1766         (probes_table_remove_objfile_probes, register_solib_event_probe)
1767         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1768         (_initialize_svr4_solib): Update.
1769
1770 2019-05-08  Tom Tromey  <tom@tromey.com>
1771
1772         * remote.c (remote_pspace_data): Change type.
1773         (remote_pspace_data_cleanup): Remove.
1774         (get_remote_exec_file, set_pspace_remote_exec_file)
1775         (_initialize_remote): Update.
1776
1777 2019-05-08  Tom Tromey  <tom@tromey.com>
1778
1779         * breakpoint.c (breakpoint_objfile_key): Change type.
1780         (get_breakpoint_objfile_data): Update.
1781         (free_breakpoint_objfile_data): Remove.
1782         (_initialize_breakpoint): Update.
1783
1784 2019-05-08  Tom Tromey  <tom@tromey.com>
1785
1786         * linux-tdep.c (struct linux_info): Add initializers.
1787         (linux_inferior_data): Move.  Change type.
1788         (invalidate_linux_cache_inf): Update.
1789         (linux_inferior_data_cleanup): Remove.
1790         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1791
1792 2019-05-08  Tom Tromey  <tom@tromey.com>
1793
1794         * auxv.c (auxv_inferior_data): Move.  Change type.
1795         (auxv_inferior_data_cleanup): Remove.
1796         (invalidate_auxv_cache_inf): Rewrite.
1797         (get_auxv_inferior_data, _initialize_auxv): Update.
1798
1799 2019-05-08  Tom Tromey  <tom@tromey.com>
1800
1801         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1802         (symfile_debug_objfile_data_key): Change type.
1803         (symfile_debug_installed, debug_qf_has_symbols)
1804         (debug_qf_find_last_source_symtab)
1805         (debug_qf_forget_cached_source_info)
1806         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1807         (debug_qf_print_stats, debug_qf_dump)
1808         (debug_qf_expand_symtabs_for_function)
1809         (debug_qf_expand_all_symtabs)
1810         (debug_qf_expand_symtabs_with_fullname)
1811         (debug_qf_map_matching_symbols)
1812         (debug_qf_expand_symtabs_matching)
1813         (debug_qf_find_pc_sect_compunit_symtab)
1814         (debug_qf_map_symbol_filenames)
1815         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1816         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1817         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1818         (debug_sym_read_linetable, debug_sym_relocate): Update.
1819         (symfile_debug_free_objfile): Remove.
1820         (install_symfile_debug_logging, _initialize_symfile_debug):
1821         Update.
1822
1823 2019-05-08  Tom Tromey  <tom@tromey.com>
1824
1825         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1826         allocate_on_obstack.
1827         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1828         (get_dwarf2_per_objfile): Update.
1829         (set_dwarf2_per_objfile): Remove.
1830         (dwarf2_has_info, dwarf2_get_section_info): Update.
1831         (dwarf2_free_objfile): Remove.
1832         (_initialize_dwarf2_read): Update.
1833
1834 2019-05-08  Tom Tromey  <tom@tromey.com>
1835
1836         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1837         initializers.
1838         <unsupported_script_warning_printed,
1839         script_not_found_warning_printed>: Now bool.
1840         (auto_load_pspace_data): Change type.
1841         (~auto_load_pspace_info): Rename from
1842         auto_load_pspace_data_cleanup.
1843         (get_auto_load_pspace_data, init_loaded_scripts_info)
1844         (clear_section_scripts, maybe_print_unsupported_script_warning)
1845         (maybe_print_script_not_found_warning, _initialize_auto_load):
1846         Update.
1847
1848 2019-05-08  Tom Tromey  <tom@tromey.com>
1849
1850         * objfiles.c (objfile_pspace_info): Add destructor and
1851         initializers.
1852         (objfiles_pspace_data): Change type.
1853         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1854         (get_objfile_pspace_data): Update.
1855         (objfiles_bfd_data): Change type.
1856         (get_objfile_bfd_data): Update.
1857         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1858
1859 2019-05-08  Tom Tromey  <tom@tromey.com>
1860
1861         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1862         Change type.
1863         (get_catch_syscall_inferior_data): Update.
1864         (catch_syscall_inferior_data_cleanup): Remove.
1865         (_initialize_break_catch_syscall): Update.
1866
1867 2019-05-08  Tom Tromey  <tom@tromey.com>
1868
1869         * inflow.c (struct terminal_info): Add destructor and
1870         initializers.
1871         (inflow_inferior_data): Change type.
1872         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1873         (get_inflow_inferior_data, inflow_inferior_exit)
1874         (swap_terminal_info, _initialize_inflow): Update.
1875
1876 2019-05-08  Tom Tromey  <tom@tromey.com>
1877
1878         * target-dcache.c (target_dcache_cleanup): Remove.
1879         (target_dcache_aspace_key): Change type.
1880         (target_dcache_init_p, target_dcache_invalidate)
1881         (target_dcache_get, target_dcache_get_or_init)
1882         (_initialize_target_dcache): Update.
1883         * dcache.h (struct dcache_deleter): New.
1884
1885 2019-05-08  Tom Tromey  <tom@tromey.com>
1886
1887         * symtab.c (struct symbol_cache): Add destructor and
1888         initializers.
1889         (symbol_cache_key): Move.  Change type.
1890         (make_symbol_cache, free_symbol_cache): Remove.
1891         (get_symbol_cache): Update.
1892         (symbol_cache_cleanup): Remove.
1893         (ALL_PSPACES, symbol_cache_flush)
1894         (maintenance_print_symbol_cache)
1895         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1896         Update.
1897
1898 2019-05-08  Tom Tromey  <tom@tromey.com>
1899
1900         * symtab.c (struct main_info): Add destructor and initializers.
1901         (main_progspace_key): Move.  Change type.
1902         (get_main_info): Update.
1903         (main_info_cleanup): Remove.
1904         (_initialize_symtab): Update.
1905
1906 2019-05-08  Tom Tromey  <tom@tromey.com>
1907
1908         * registry.h (DECLARE_REGISTRY): Define the _key class.
1909
1910 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1911
1912         * NEWS: Merge two 'New commands' sections.
1913
1914 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1915
1916         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1917         parameter and use Ada language definition instead.
1918         (ada_val_print_ptr): Remove unused language parameter.
1919         (ada_val_print_num): Remove language parameter and use Ada language
1920         definition instead.
1921         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1922         parameter.
1923         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1924         parameter and use Ada language definition instead.
1925         (ada_val_print_1): Update all ada_val_print_xxx calls.
1926         Remove language parameter.
1927         (ada_val_print): Update ada_val_print_1 call.
1928
1929 2019-05-08  Tom Tromey  <tromey@adacore.com>
1930
1931         * remote.c (remote_hw_watchpoint_limit)
1932         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1933         Now static.
1934
1935 2019-05-08  Tom Tromey  <tromey@adacore.com>
1936
1937         * maint.c (_initialize_maint_cmds): Move initialization code to
1938         remote.c.
1939         (watchdog, show_watchdog): Move to remote.c.
1940         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1941         "watchdog" static.
1942         (_initialize_remote): Move initialization code from maint.c.
1943         * defs.h (watchdog): Don't declare.
1944
1945 2019-05-08  Tom Tromey  <tromey@adacore.com>
1946
1947         * tui/tui-interp.c: Include main.h.
1948         * interps.c: Include main.h.
1949         * main.h (interpreter_p): Declare.
1950         * defs.h (interpreter_p): Don't declare.
1951
1952 2019-05-08  Tom Tromey  <tromey@adacore.com>
1953
1954         * dwarf2loc.c: Include dwarf2read.h.
1955         * defs.h (read_unsigned_leb128): Don't declare.
1956         * dwarf2read.h (read_unsigned_leb128): Declare.
1957
1958 2019-05-08  Tom Tromey  <tromey@adacore.com>
1959
1960         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1961         method.
1962
1963 2019-05-08  Tom Tromey  <tromey@adacore.com>
1964
1965         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1966         when no wrap column is set.
1967
1968 2019-05-08  Tom Tromey  <tromey@adacore.com>
1969
1970         * c-lang.c (c_get_string): Handle non-C-style arrays.
1971
1972 2019-05-08  Tom Tromey  <tromey@adacore.com>
1973
1974         * typeprint.c (print_offset_data::update): Print the bit offset,
1975         not the number of bits remaining.
1976
1977 2019-05-08  Tom Tromey  <tromey@adacore.com>
1978
1979         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1980         padding at end of comment.
1981
1982 2019-05-08  Tom Tromey  <tromey@adacore.com>
1983
1984         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1985         Compare main types.
1986
1987 2019-05-06  Tom Tromey  <tom@tromey.com>
1988
1989         * common/scoped_mmap.c: Include common-defs.h.
1990         * common/scoped_mmap.h: Don't include config.h.
1991
1992 2019-05-04  Tom Tromey  <tom@tromey.com>
1993
1994         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1995         (struct aarch64_call_info): Add initializers.
1996         <si>: Now a std::vector.
1997         (pass_on_stack, aarch64_push_dummy_call): Update.
1998
1999 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2000             Tom Tromey  <tom@tromey.com>
2001
2002         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2003         (ppc_threads): Now a std::vector.  Now static.
2004         (hwdebug_find_thread_points_by_tid)
2005         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2006         Update.
2007
2008 2019-05-04  Tom Tromey  <tom@tromey.com>
2009
2010         * arc-tdep.c (arc_tdesc_init): Return bool.
2011
2012 2019-05-04  Tom Tromey  <tom@tromey.com>
2013
2014         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2015         Use gdb_assert_not_reached.
2016
2017 2019-05-04  Tom Tromey  <tom@tromey.com>
2018
2019         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2020         "false".
2021
2022 2019-05-04  Tom Tromey  <tom@tromey.com>
2023
2024         * arc-tdep.c (arc_tdesc_init): Use bool.
2025
2026 2019-05-04  Tom Tromey  <tom@tromey.com>
2027
2028         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2029
2030 2019-05-04  Tom Tromey  <tom@tromey.com>
2031
2032         * cli/cli-cmds.c (valid_command_p): Return bool.
2033
2034 2019-05-04  Tom Tromey  <tom@tromey.com>
2035
2036         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2037         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2038
2039 2019-05-04  Raul Tambre  <raul@tambre.ee>
2040
2041         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2042         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2043         operator for comparison.
2044
2045 2019-05-04  Tom Tromey  <tom@tromey.com>
2046
2047         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2048         (lookup_partial_symbol, print_partial_symbols)
2049         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2050         (psymbol_compare): Update.
2051         (add_psymbol_to_bcache): Clear the entire psymbol.
2052         (maintenance_check_psymtabs): Update.
2053         * psympriv.h (struct partial_symbol): Don't derive from
2054         general_symbol_info.
2055         <obj_section, unrelocated_address, address,
2056         set_unrelocated_address>: Update.
2057         <ginfo>: New member.
2058         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2059         (debug_names::write_psymbols): Update.
2060
2061 2019-05-04  Tom de Vries  <tdevries@suse.de>
2062
2063         * contrib/cc-with-tweaks.sh: Support -n arg.
2064
2065 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2066
2067         * corelow.c (core_target::detach): Ensure frame cache and
2068         register caches are cleared.
2069         inferior.c (exit_inferior_1): Likewise.
2070
2071 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2072             Tom Tromey  <tom@tromey.com>
2073
2074         * dictionary.c (collate_pending_symbols_by_language): Remove
2075         "struct" from foreach.
2076         * symtab.c (lookup_global_symbol_from_objfile)
2077         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2078         foreach.
2079         * ser-tcp.c (net_open): Remove "struct" from foreach.
2080         * objfiles.c (objfile_relocate, objfile_rebase)
2081         (objfile_has_symbols): Remove "struct" from foreach.
2082         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2083         from foreach.
2084         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2085         foreach.
2086         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2087         "struct" from foreach.
2088         * ada-lang.c (create_excep_cond_exprs)
2089         (ada_exception_catchpoint_cond_string): Remove "struct" from
2090         foreach.
2091
2092 2019-05-03  Tom Tromey  <tromey@adacore.com>
2093
2094         * ada-exp.y (convert_char_literal): Check suffix of each
2095         enumerator.
2096
2097 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2098
2099         PR ada/21406:
2100         * ada-exp.y (yywrap): Don't define.
2101         * ada-lex.l (%option): Add noyywrap
2102         (yywrap): Remove.
2103
2104 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2105
2106         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2107         _WIN32_WINNT to the XP level, unless already defined to a higher
2108         level.
2109
2110         * unittests/parse-connection-spec-selftests.c:
2111         * ser-tcp.c:
2112         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2113         override.
2114
2115         * symfile.c (find_separate_debug_file): Remove colon from the
2116         drive spec of DOS/Windows file names of the target, so that the
2117         file name produced from DEBUGDIR and the target's directory will
2118         be valid on DOS/Windows systems.
2119
2120 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2121
2122         * rust-lang.c (val_print_struct): Handle printing structures
2123         containing strings.
2124
2125 2019-05-02  Tom Tromey  <tromey@adacore.com>
2126
2127         * valarith.c (_initialize_valarith): Remove.
2128
2129 2019-05-01  Tom Tromey  <tromey@adacore.com>
2130
2131         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2132         bitfields.
2133
2134 2019-05-01  Tom Tromey  <tromey@adacore.com>
2135
2136         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2137         for big-endian copies.
2138
2139 2019-04-30  Ali Tamur  <tamur@google.com>
2140         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2141         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2142         (read_3_bytes): New function.
2143
2144 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2145
2146         * windows-nat.c (main_thread_id): Delete.
2147         (handle_output_debug_string): Replace main_thread_id by
2148         current_event.dwThreadId.
2149         (fake_create_process): Likewise.
2150         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2151         Do not set main_thread_id.
2152         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2153         current_event.dwThreadId.
2154         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2155
2156 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2157
2158         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2159         Use current_event.dwThreadId instead of main_thread_id.
2160
2161 2019-04-30  Tom Tromey  <tromey@adacore.com>
2162
2163         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2164         (create_excep_cond_exprs): Iterate over program spaces.
2165         (ada_exception_catchpoint_cond_string): Examine all minimal
2166         symbols for exception types.
2167
2168 2019-04-30  Tom Tromey  <tromey@adacore.com>
2169
2170         PR c++/24470:
2171         * dwarf2read.c (process_structure_scope): Handle case where type
2172         has template parameters but no symbol was created.
2173
2174 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2175             Chris January  <chris.january@arm.com>
2176
2177         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2178         qualifier.
2179         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2180
2181 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2182
2183         * f-typeprint.c (f_print_type): Update rules for printing
2184         whitespace.
2185         (f_type_print_varspec_suffix): Likewise.
2186
2187 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2188             Chris January  <chris.january@arm.com>
2189
2190         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2191         function arguments.
2192
2193 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2194
2195         * f-lang.c (build_fortran_types): Change name of void type to
2196         lower case.
2197         * f-typeprint.c (f_type_print_base): Print the name of the void
2198         type, rather than a fixed string.
2199         * f-valprint.c (f_decorations): Use lower case void string.
2200
2201 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2202             Chris January  <chris.january@arm.com>
2203
2204         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2205         types for Fortran.
2206
2207 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2208             Chris January  <chris.january@arm.com>
2209             David Lecomber  <david.lecomber@arm.com>
2210
2211         * f-exp.y (BINOP_INTRINSIC): New token.
2212         (exp): New parser rule handling BINOP_INTRINSIC.
2213         (f77_keywords): Add new builtin procedures.
2214         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2215         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2216         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2217         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2218         (print_unop_subexp_f): New function.
2219         (print_binop_subexp_f): New function.
2220         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2221         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2222         (dump_subexp_body_f): Likewise.
2223         (operator_check_f): Likewise.
2224         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2225         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2226
2227 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2228
2229         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2230         UNOP_KIND.
2231         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2232         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2233         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2234         (operator_length_f): New fuction.
2235         (print_subexp_f): New function.
2236         (op_name_f): New function.
2237         (dump_subexp_body_f): New function.
2238         (operator_check_f): New function.
2239         (exp_descriptor_f): Replace standard expression handling functions
2240         with new functions.
2241         * gdb/fortran-operator.def: New file.
2242         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2243         * gdb/std-operator.def: Remove UNOP_KIND.
2244
2245 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2246
2247         * std-operator.def: Remove unbalanced, stray double quote
2248         character.
2249
2250 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2251             Chris January  <chris.january@arm.com>
2252             Daniel Everett  <daniel.everett@arm.com>
2253             Nick Forrington  <nick.forrington@arm.com>
2254             Richard Bunt  <richard.bunt@arm.com>
2255
2256         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2257         of depth when printing anonymous structs or unions.
2258         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2259         Don't print either the top-level value, or the children if the
2260         max-depth is exceeded.
2261         (ppscm_print_children): When printing the key of a map, allow one
2262         extra level of depth.
2263         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2264         print either the top-level value, or the children if the max-depth
2265         is exceeded.
2266         (print_children): When printing the key of a map, allow one extra
2267         level of depth.
2268         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2269         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2270         (user_print_options): Initialise max_depth field.
2271         (val_print_scalar_or_string_type_p): New function.
2272         (val_print): Check to see if the max depth has been reached.
2273         (val_print_check_max_depth): Define new function.
2274         (show_print_max_depth): New function.
2275         (_initialize_valprint): Add 'print max-depth' option.
2276         * valprint.h (struct value_print_options) <max_depth>: New field.
2277         (val_print_check_max_depth): Declare new function.
2278         * NEWS: Document new feature.
2279
2280 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2281
2282         * ada-lang.c (ada_language_defn): Initialise new field.
2283         * c-lang.c (c_is_string_type_p): New function.
2284         (c_language_defn): Initialise new field.
2285         (cplus_language_defn): Initialise new field.
2286         (asm_language_defn): Initialise new field.
2287         (minimal_language_defn): Initialise new field.
2288         * c-lang.h (c_is_string_type_p): Declare new function.
2289         * d-lang.c (d_language_defn): Initialise new field.
2290         * f-lang.c (f_is_string_type_p): New function.
2291         (f_language_defn): Initialise new field.
2292         * go-lang.c (go_is_string_type_p): New function.
2293         (go_language_defn): Initialise new field.
2294         * language.c (default_is_string_type_p): New function.
2295         (unknown_language_defn): Initialise new field.
2296         (auto_language_defn): Initialise new field.
2297         * language.h (struct language_defn) <la_is_string_type_p>: New
2298         member variable.
2299         (default_is_string_type_p): Declare new function.
2300         * m2-lang.c (m2_language_defn): Initialise new field.
2301         * objc-lang.c (objc_language_defn): Initialise new field.
2302         * opencl-lang.c (opencl_language_defn): Initialise new field.
2303         * p-lang.c (pascal_is_string_type_p): New function.
2304         (pascal_language_defn): Initialise new field.
2305         * rust-lang.c (rust_is_string_type_p): New function.
2306         (rust_language_defn): Initialise new field.
2307
2308 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2309
2310         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2311         New field.
2312         * ada-lang.c (ada_language_defn): Initialise new field.
2313         * c-lang.c (c_language_defn): Likewise.
2314         (cplus_language_defn): Likewise.
2315         (asm_language_defn): Likewise.
2316         (minimal_language_defn): Likewise.
2317         * d-lang.c (d_language_defn): Likewise.
2318         * f-lang.c (f_language_defn): Likewise.
2319         * go-lang.c (go_language_defn): Likewise.
2320         * language.c (unknown_language_defn): Likewise.
2321         (auto_language_defn): Likewise.
2322         * m2-lang.c (m2_language_defn): Likewise.
2323         * objc-lang.c (objc_language_defn): Likewise.
2324         * opencl-lang.c (opencl_language_defn): Likewise.
2325         * p-lang.c (pascal_language_defn): Likewise.
2326         * rust-lang.c (rust_language_defn): Likewise.
2327
2328 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2329
2330         * ada-lang.c (ada_is_character_type): Change return type to bool.
2331         (ada_is_string_type): Likewise.
2332         * ada-lang.h (ada_is_character_type): Update declaration
2333         (ada_is_string_type): Likewise.
2334
2335 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2336
2337         Support style in 'frame|thread apply'
2338
2339         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2340         * record.c (record_start, record_stop): Update callers of
2341         execute_command_to_string with false.
2342         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2343         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2344         methods.
2345         (class string_file): New constructor with term_out parameter.
2346         Override methods term_out and can_emit_style_escape.  New member
2347         term_out.
2348         (class stdio_file): Override can_emit_style_escape.
2349         (class tee_file): Override term_out and can_emit_style_escape.
2350         * utils.h (can_emit_style_escape): Remove.
2351         * utils.c (can_emit_style_escape): Likewise.
2352         Update all callers of can_emit_style_escape (SOMESTREAM) to
2353         SOMESTREAM->can_emit_style_escape.
2354         * source-cache.c (source_cache::get_source_lines): Likewise.
2355         * stack.c (frame_apply_command_count): Call execute_command_to_string
2356         passing the term_out characteristic of the current gdb_stdout.
2357         * thread.c (thr_try_catch_cmd): Likewise.
2358         * top.c (execute_command_to_string): pass term_out parameter
2359         to construct the string_file for the command output.
2360         * ui-file.c (term_cli_styling): New function (most code moved
2361         from utils.c can_emit_style_escape).
2362         (string_file::string_file, string_file::can_emit_style_escape,
2363         stdio_file::can_emit_style_escape, tee_file::term_out,
2364         tee_file::can_emit_style_escape): New functions.
2365
2366 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2367
2368         * NEWS: Mention the new set|show may-call-functions.
2369         * infcall.c (may_call_functions_p): New variable.
2370         (show_may_call_functions_p): New function.
2371         (call_function_by_hand_dummy): Throws an error if not
2372         may-call-functions.
2373         (_initialize_infcall): Call add_setshow_boolean_cmd for
2374         may-call-functions.
2375
2376 2019-04-25  Keith Seitz  <keiths@redhat.com>
2377
2378         PR c++/24367
2379         * cp-support.c (inspect_type): Don't attempt substitutions
2380         of symbol with the same name.
2381
2382 2019-04-25  Tom Tromey  <tromey@adacore.com>
2383
2384         PR gdb/24475:
2385         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2386         static.
2387
2388 2019-04-25  Tom Tromey  <tromey@adacore.com>
2389
2390         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2391         rvalue reference.
2392         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2393         (gdb_xml_parser::parse): Use std::move.
2394         * python/python-internal.h (gdbpy_convert_exception): Take a const
2395         reference.
2396         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2397         std::move.
2398         * python/py-utils.c (gdbpy_convert_exception): Take a const
2399         reference.
2400         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2401         Use std::move.
2402         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2403         Use std::move.
2404         * mi/mi-main.c (mi_print_exception): Take a const reference.
2405         * main.c (handle_command_errors): Take a const reference.
2406         * linespec.c (parse_linespec): Use std::move.
2407         * infcall.c (run_inferior_call): Use std::move.
2408         (call_function_by_hand_dummy): Use std::move.
2409         * exec.c (try_open_exec_file): Use std::move.
2410         * exceptions.h (exception_print, exception_fprintf)
2411         (exception_print_same): Update.
2412         * exceptions.c (print_exception, exception_print)
2413         (exception_fprintf, exception_print_same): Change parameters to
2414         const reference.
2415         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2416         * common/new-op.c: Use std::move.
2417         * common/common-exceptions.h (struct gdb_exception): Add move
2418         constructor.
2419         (struct gdb_exception_error, struct gdb_exception_quit, struct
2420         gdb_quit_bad_alloc): Change constructor to move constructor.
2421         (throw_exception): Change parameter to rvalue reference.
2422         * common/common-exceptions.c (throw_exception): Take rvalue
2423         reference.
2424         * cli/cli-interp.c (safe_execute_command): Use std::move.
2425         * breakpoint.c (insert_bp_location, location_to_sals): Use
2426         std::move.
2427
2428 2019-04-25  Tom Tromey  <tromey@adacore.com>
2429
2430         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2431         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2432         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2433         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2434         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2435         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2436         guile/scm-value.c: Use unpack.
2437         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2438         gdbscm_gdb_exception.
2439         (gdbscm_throw_gdb_exception): Likewise.
2440         (struct gdbscm_gdb_exception): New.
2441         (unpack): New function.
2442         (gdbscm_wrap): Use unpack.
2443
2444 2019-04-25  Tom Tromey  <tromey@adacore.com>
2445
2446         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2447         (gdb_rl_callback_handler): Use std::move.
2448         * common/common-exceptions.h (struct gdb_exception): Add move
2449         assignment operator.
2450         (throw_exception_sjlj): Change "exception" to const reference.
2451         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2452         (throw_exception_sjlj): Change "exception" to const reference.
2453
2454 2019-04-25  Tom Tromey  <tromey@adacore.com>
2455
2456         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2457         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2458         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2459         Update.
2460         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2461         Update.
2462         * mi/mi-interp.c (mi_interp::exec): Update.
2463         * linespec.c (parse_linespec): Update.
2464         * infcall.c (run_inferior_call): Update.
2465         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2466         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2467         (gdbscm_lookup_global_symbol): Update.
2468         * guile/scm-param.c (gdbscm_parameter_value): Update.
2469         * guile/scm-frame.c (gdbscm_frame_read_register)
2470         (gdbscm_frame_read_var): Update.
2471         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2472         * exec.c (try_open_exec_file): Update.
2473         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2474         (gdb_rl_callback_handler): Update.
2475         * common/common-exceptions.h (exception_none): Don't declare.
2476         * common/common-exceptions.c (exception_none): Don't define.
2477         (struct catcher) <exception>: Update.
2478         * cli/cli-interp.c (safe_execute_command): Update.
2479         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2480
2481 2019-04-25  Ali Tamur  <tamur@google.com>
2482
2483         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2484         (read_attribute_value): Likewise.
2485         (dwarf2_read_addr_index): Update comment.
2486         (read_str_index): Add DW_FORM_strx.
2487         (dwarf2_string_attr): Likewise.
2488         (dwarf2_const_value_attr): Likewise.
2489         (dump_die_shallow): Likewise.
2490         (dwarf2_fetch_constant_bytes): Likewise.
2491         (skip_form_bytes): Likewise.
2492         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2493
2494 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2495
2496         PR corefiles/11608
2497         PR corefiles/18187
2498         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2499         OFFSET.  Verify if current mapping contains an ELF header.
2500         (linux_find_memory_regions_full): Adjust call to
2501         dump_mapping_p.
2502
2503 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2504             Kang Li <kanglictf@gmail.com>
2505
2506         PR gdb/21600
2507
2508         * dwarf2-frame.c (read_initial_length): Be consistent about using
2509         unsigned representation of length.
2510         (decode_frame_entry_1): Likewise.  Check for wraparound of
2511         end pointer as well as buffer overflow.
2512
2513 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2514
2515         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2516         "vq".
2517
2518 2019-04-24  Tom Tromey  <tromey@adacore.com>
2519
2520         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2521
2522 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2523
2524         * s12z-tdep.c (s12z_unwind_pc): Delete.
2525         (s12z_unwind_sp): Delete.
2526         (s12z_gdbarch_init): Don't register deleted functions with
2527         gdbarch.
2528
2529 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2530
2531         * rl78-tdep.c (rl78_unwind_sp): Delete.
2532         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2533
2534 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2535
2536         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2537         (xstormy16_unwind_pc): Delete.
2538         (xstormy16_dummy_id): Delete.
2539         (xstormy16_gdbarch_init): Don't register deleted functions with
2540         gdbarch.
2541
2542 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2543
2544         * vax-tdep.c (vax_unwind_pc): Delete.
2545         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2546
2547 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2548
2549         * v850-tdep.c (v850_unwind_sp): Delete.
2550         (v850_unwind_pc): Delete.
2551         (v850_dummy_id): Delete.
2552         (v850_gdbarch_init): Don't register deleted functions with
2553         gdbarch.
2554
2555 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2556
2557         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2558         (tilegx_unwind_pc): Delete.
2559         (tilegx_unwind_dummy_id): Delete.
2560         (tilegx_gdbarch_init): Don't register deleted functions with
2561         gdbarch.
2562
2563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2564
2565         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2566         (tic6x_dummy_id): Delete.
2567         (tic6x_gdbarch_init): Don't register deleted functions with
2568         gdbarch.
2569
2570 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2571
2572         * sparc-tdep.c (sparc_unwind_pc): Delete.
2573         (sparc32_gdbarch_init): Don't register deleted function with
2574         gdbarch.
2575
2576 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2577
2578         * sh-tdep.c (sh_unwind_sp): Delete.
2579         (sh_unwind_pc): Delete.
2580         (sh_dummy_id): Delete.
2581         (sh_gdbarch_init): Don't register deleted functions with
2582         gdbarch.
2583
2584 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2585
2586         * score-tdep.c (score_unwind_sp): Delete.
2587         (score_unwind_pc): Delete.
2588         (score_dummy_id): Delete.
2589         (score_gdbarch_init): Don't register deleted functions with
2590         gdbarch.
2591
2592 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2593
2594         * rx-tdep.c (rx_unwind_pc): Delete.
2595         (rx_unwind_sp): Delete.
2596         (rx_dummy_id): Delete.
2597         (rx_gdbarch_init): Don't register deleted functions with
2598         gdbarch.  Update comment.
2599
2600 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2601
2602         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2603         (rs6000_dummy_id): Delete.
2604         (rs6000_gdbarch_init): Don't register deleted functions with
2605         gdbarch.
2606
2607 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2608
2609         * or1k-tdep.c (or1k_dummy_id): Delete.
2610         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2611
2612 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2613
2614         * nios2-tdep.c (nios2_dummy_id): Delete.
2615         (nios2_unwind_sp): Delete.
2616         (nios2_gdbarch_init): Don't register deleted functions with
2617         gdbarch.
2618
2619 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2620
2621         * nds32-tdep.c (nds32_dummy_id): Delete.
2622         (nds32_unwind_pc): Delete.
2623         (nds32_unwind_sp): Delete.
2624         (nds32_gdbarch_init): Don't register deleted functions with
2625         gdbarch.
2626
2627 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2628
2629         * msp430-tdep.c (msp430_unwind_pc): Delete.
2630         (msp430_unwind_sp): Delete.
2631         (msp430_dummy_id): Delete.
2632         (msp430_gdbarch_init): Don't register deleted functions with
2633         gdbarch.
2634
2635 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2636
2637         * moxie-tdep.c (moxie_unwind_sp): Delete.
2638         (moxie_unwind_pc): Delete.
2639         (moxie_dummy_id): Delete.
2640         (moxie_gdbarch_init): Don't register deleted functions with
2641         gdbarch.
2642
2643 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2644
2645         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2646         (mn10300_unwind_pc): Delete.
2647         (mn10300_unwind_sp): Delete.
2648         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2649         mn10300_unwind_sp.
2650         (mn10300_frame_unwind_init): Don't register deleted functions with
2651         gdbarch.
2652
2653 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2654
2655         * mep-tdep.c (mep_unwind_pc): Delete.
2656         (mep_unwind_sp): Delete.
2657         (mep_dummy_id): Delete.
2658         (mep_gdbarch_init): Don't register deleted functions with
2659         gdbarch.
2660
2661 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2662
2663         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2664         (m68hc11_unwind_sp): Delete.
2665         (m68hc11_gdbarch_init): Don't register deleted functions with
2666         gdbarch.
2667
2668 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2669
2670         * m32r-tdep.c (m32r_unwind_sp): Delete.
2671         (m32r_unwind_pc): Delete.
2672         (m32r_dummy_id): Delete.
2673         (m32r_gdbarch_init): Don't register deleted functions with
2674         gdbarch.
2675
2676 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2677
2678         * m32c-tdep.c (m32c_unwind_pc): Delete.
2679         (m32c_unwind_sp): Delete.
2680         (m32c_dummy_id): Delete.
2681         (m32c_gdbarch_init): Don't register deleted functions with
2682         gdbarch.
2683
2684 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2685
2686         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2687         (lm32_unwind_pc): Delete.
2688         (lm32_dummy_id): Delete.
2689         (lm32_gdbarch_init): Don't register deleted functions with
2690         gdbarch.
2691
2692 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2693
2694         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2695         (iq2000_unwind_pc): Delete.
2696         (iq2000_dummy_id): Delete.
2697         (iq2000_gdbarch_init): Don't register deleted functions with
2698         gdbarch.
2699
2700 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2701
2702         * nds32-tdep.c (nds32_type_align): Delete.
2703         (nds32_push_dummy_call): Use type_align instead.
2704
2705 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2706
2707         * arm-tdep.c (arm_type_align): Only handle vector override case.
2708         (arm_push_dummy_call): Use type_align.
2709         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2710
2711 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2712
2713         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2714         case.
2715         (pass_on_stack): Use type_align.
2716         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2717         function.
2718
2719 2019-04-23  Tom Tromey  <tromey@adacore.com>
2720
2721         * dwarf2read.c (line_header::file_name_at): Remove unused
2722         overload.
2723
2724 2019-04-23  Tom de Vries  <tdevries@suse.de>
2725
2726         PR gdb/24438
2727         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2728         invocation.
2729
2730
2731 2019-03-27  Ali Tamur  <tamur@google.com>
2732
2733         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2734         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2735         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2736         (dwarf_expr_context::get_addr_index): Likewise
2737         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2738         (symbol_needs_eval_context::get_addr_index): Likewise
2739         (disassemble_dwarf_expression): Add DW_OP_addrx
2740         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2741         (read_cutu_die_from_dwo): Update comment
2742         (skip_one_die): Add DW_FORM_addrx
2743         (read_attribute_value): Likewise
2744         (var_decode_location): Add DW_OP_addrx
2745         (dwarf2_const_value_attr): Add DW_FORM_addrx
2746         (dump_die_shallow): Likewise
2747         (dwarf2_fetch_constant_bytes): Likewise
2748         (decode_locdesc): Add DW_OP_addrx
2749         (skip_form_bytes): Add DW_FORM_addrx
2750
2751 2019-04-22  Ali Tamur  <tamur@google.com>
2752
2753         * MAINTAINERS (Write After Approval): Add self.
2754
2755 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2756
2757         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2758         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2759         (open_symbol_file_object): Likewise.
2760         (svr4_default_sos): Add info parameter.
2761         (svr4_read_so_list): Likewise.
2762         (svr4_current_sos_direct): Adjust functions calls to pass down
2763         info.
2764         (svr4_current_sos_1): Add info parameter.
2765         (svr4_current_sos): Call get_svr4_info, pass info down to
2766         svr4_current_sos_1.
2767         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2768         get_svr4_info.
2769         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2770         get_svr4_info.
2771         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2772         to get_svr4_info.
2773         (probes_table_remove_objfile_probes): Likewise.
2774         (register_solib_event_probe): Add info parameter.
2775         (solist_update_incremental): Pass info parameter down to
2776         svr4_read_so_list.
2777         (disable_probes_interface): Add info parameter.
2778         (svr4_handle_solib_event): Pass current_program_space to
2779         get_svr4_info.  Adjust disable_probes_interface cleanup.
2780         (svr4_create_probe_breakpoints): Add info parameter, pass it
2781         down to register_solib_event_probe.
2782         (svr4_create_solib_event_breakpoints): Add info parameter,
2783         pass it down to svr4_create_probe_breakpoints.
2784         (enable_break): Pass info down to
2785         svr4_create_solib_event_breakpoints.
2786         (svr4_solib_create_inferior_hook): Pass current_program_space to
2787         get_svr4_info.
2788         (svr4_clear_solib): Likewise.
2789
2790 2019-04-22  Pedro Alves  <palves@redhat.com>
2791
2792         * solib-svr4.c (svr4_free_objfile_observer): New.
2793         (probe_and_action::objfile): New field.
2794         (probes_table_htab_remove_objfile_probes)
2795         (probes_table_remove_objfile_probes): New functions.
2796         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2797         in the new probe_and_action.  Don't store the probe in 'lookup'.
2798         (svr4_create_probe_breakpoints): Pass objfile to
2799         register_solib_event_probe.
2800         (_initialize_svr4_solib): Register a free_objfile observer.
2801
2802 2019-04-19  Tom Tromey  <tom@tromey.com>
2803
2804         * common/queue.h: Remove.
2805
2806 2019-04-19  Tom Tromey  <tom@tromey.com>
2807
2808         * event-loop.c: Don't include "common/queue.h".
2809
2810 2019-04-19  Tom Tromey  <tom@tromey.com>
2811
2812         * remote.c (remote_target): Use delete.
2813         * remote-notif.h: Include <list>, not "common/queue.h".
2814         (notif_client_p): Remove typedef.
2815         (remote_notif_state): Add constructor, destructor, initializer.
2816         <notif_queue>: Now a std::list.
2817         (remote_notif_state_xfree): Don't declare.
2818         * remote-notif.c (remote_notif_process, handle_notification)
2819         (remote_notif_state_allocate): Update.
2820         (~remote_notif_state): Rename from remote_notif_state_xfree.
2821
2822 2019-04-19  Tom Tromey  <tom@tromey.com>
2823
2824         * symfile.c (reread_symbols): Update.
2825         * objfiles.c (objfile_register_static_link)
2826         (objfile_lookup_static_link): Update
2827         (~objfile) Don't delete static_links.
2828         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2829
2830 2019-04-19  Tom Tromey  <tom@tromey.com>
2831
2832         * type-stack.h (struct type_stack) <insert>: Constify string.
2833         * type-stack.c (type_stack::insert): Constify string.
2834         * gdbtypes.h (lookup_template_type): Update.
2835         (address_space_name_to_int): Update.
2836         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2837         const.
2838         (lookup_template_type): Make name const.
2839         * c-exp.y: Update rules.
2840         (lex_one_token, classify_name, classify_inner_name)
2841         (c_print_token): Update.
2842         * p-exp.y: Update rules.
2843         (yylex): Update.
2844         * f-exp.y: Update rules.
2845         (yylex): Update.
2846         * d-exp.y: Update rules.
2847         (lex_one_token, classify_name, classify_inner_name): Update.
2848         * parse.c (write_dollar_variable, copy_name): Return std::string.
2849         * parser-defs.h (copy_name): Change return type.
2850         * m2-exp.y: Update rules.
2851         (yylex): Update.
2852         * go-exp.y (lex_one_token): Update.
2853         Update rules.
2854         (classify_unsafe_function, classify_packaged_name)
2855         (classify_name, yylex): Update.
2856
2857 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2858
2859         * configure.ac: add --enable-source-highlight switch.
2860         * configure: Regenerate.
2861         * top.c (print_gdb_version): plumb --enable-source-highlight
2862         status to "show configuration".
2863
2864 2019-04-19  Tom Tromey  <tromey@adacore.com>
2865
2866         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2867         Check ADA_TYPE_P.
2868         (empty_record, ada_template_to_fixed_record_type_1)
2869         (template_to_static_fixed_type)
2870         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2871         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2872         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2873         macros.
2874
2875 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2876
2877         PR symtab/24423:
2878         * source.c (print_source_lines_base): Advance "iter" when a
2879         control character is seen.
2880
2881 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2882
2883         * inferior.h (struct infcall_suspend_state_deleter):
2884         Catch exception in destructor to avoid crash.
2885
2886 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2887
2888         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2889         close to the add_com "shell".
2890
2891 2019-04-18  Tom Tromey  <tromey@adacore.com>
2892
2893         * process-stratum-target.h (class process_stratum_target)
2894         <stratum>: Add "final".
2895
2896 2019-04-17  Tom Tromey  <tromey@adacore.com>
2897
2898         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2899         against nullptr before use.
2900
2901 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2902
2903         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2904
2905 2019-04-17  Jim Wilson  <jimw@sifive.com>
2906             Andrew Burgess  <andrew.burgess@embecosm.com>
2907
2908         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2909         code read might fail, assume 4-byte breakpoint in that case.
2910
2911 2019-04-15  Leszek Swirski  <leszeks@google.com>
2912
2913         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2914         rather than a hand-rolled POD check when checking for forced MEMORY
2915         classification.
2916
2917 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2918
2919         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2920         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2921         function.
2922         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2923         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2924         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2925         declaration.
2926
2927 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2928
2929         * aarch64-linux-nat.c
2930         (aarch64_linux_nat_target::thread_architecture): Add override.
2931         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2932         each VQ.
2933
2934 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2935
2936         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2937
2938 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2939
2940         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2941         target types of size 96-bits, add some additional comments, and
2942         check that the builtin type we found was the correct size.
2943
2944 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2945
2946         * utils.c (prompt_for_continue): Don't restore the styling at the
2947         end, as applied_style has the wrong value.  This fixes styling in
2948         long lists of file names that are interrupted by the "Continue?"
2949         prompt.
2950
2951 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2952
2953         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2954         * c-lang.c (c_language_defn): Likewise.
2955         (cplus_language_defn): Likewise.
2956         (asm_language_defn): Likewise.
2957         (minimal_language_defn): Likewise.
2958         * d-lang.c (d_language_defn): Likewise.
2959         * f-lang.c (f_language_defn): Likewise.
2960         * go-lang.c (go_language_defn): Likewise.
2961         * language.c (unknown_language_defn): Likewise.
2962         (auto_language_defn): Likewise.
2963         * language.h (struct language_defn): Remove la_magic field.
2964         (LANG_MAGIC): Delete.
2965         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2966         * objc-lang.c (objc_language_defn): Likewise.
2967         * opencl-lang.c (opencl_language_defn): Likewise.
2968         * p-lang.c (pascal_language_defn): Likewise.
2969         * rust-lang.c (rust_language_defn): Likewise.
2970
2971 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2972
2973         * riscv-tdep.c (riscv_type_align): New function.
2974         (riscv_type_alignment): Delete.
2975         (riscv_arg_location): Use 'type_align'.
2976         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2977
2978 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2979
2980         * gdbtypes.c (type_align): A struct with no non-static fields also
2981         has alignment of 1.
2982
2983 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2984
2985         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2986         component to 0.
2987         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2988         member.
2989         (riscv_struct_info::analyse): New implementation using new
2990         analyse_inner member function.
2991         (riscv_struct_info::field_offset): New member function.
2992         (riscv_struct_info::m_offsets): New member variable.
2993         (riscv_struct_info::analyse_inner): New private member function,
2994         takes the old implementation of riscv_struct_info::analyse but
2995         extended to track field offsets.
2996         (riscv_call_arg_struct): Update the struct folding special cases
2997         to handle cases where empty C++ structs, which are non-zero
2998         length, are found.
2999         (riscv_arg_location): Initialise the length of each location, a
3000         non-zero length now indicates the location is in use.
3001         (riscv_push_dummy_call): Allow for the first location having a
3002         non-zero offset when setting up arguments.
3003         (riscv_return_value): Likewise, but for return values.
3004
3005 2019-04-11  Tom Tromey  <tromey@adacore.com>
3006
3007         * utils.c (internal_vproblem): Make "msg" const.
3008
3009 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3010
3011         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3012         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3013         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3014         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3015
3016 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3017
3018         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3019         function.
3020         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3021         of amd64_collect_native_gregset.
3022         (amd64_linux_nat_target::store_registers): Likewise.
3023
3024 2019-04-10  Tom Tromey  <tom@tromey.com>
3025
3026         * symtab.c (lookup_global_symbol_from_objfile)
3027         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3028         * objfiles.h (class separate_debug_iterator): New.
3029         (class separate_debug_range): New.
3030         (struct objfile) <separate_debug_objfiles>: New method.
3031         (objfile_separate_debug_iterate): Don't declare.
3032         * objfiles.c (separate_debug_iterator::operator++): Rename from
3033         objfile_separate_debug_iterate.
3034         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3035         iterator.
3036         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3037         iterator.
3038
3039 2019-04-10  Tom Tromey  <tom@tromey.com>
3040
3041         * symfile.c (reread_symbols): Remove old comment.
3042         * objfiles.c (free_all_objfiles): Fix a typo.
3043
3044 2019-04-10  Tom Tromey  <tom@tromey.com>
3045
3046         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3047         * minsyms.c (lookup_minimal_symbol): Use foreach.
3048         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3049         (lookup_minimal_symbol_solib_trampoline): Likewise.
3050         * symfile.c (reread_symbols): Use foreach.
3051
3052 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3053             Tom Tromey  <tromey@adacore.com>
3054
3055         PR rust/24414:
3056         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3057         (rust_lex_int_test): Change "value" to be LONGEST.
3058         (rust_lex_tests): Add test for long integer literal.
3059
3060 2019-04-09  Tom Tromey  <tromey@adacore.com>
3061
3062         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3063         to bool.
3064         (extended_remote_target::attach): Update.
3065         (remote_target::remote_notice_new_inferior): Update.
3066         (remote_target::add_current_inferior_and_thread): Update.
3067         * inferior.c (exit_inferior_1): Use "false".
3068         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3069
3070 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3071
3072         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3073         the "start" command.
3074
3075 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3076
3077         * python/py-inferior.c (infpy_thread_from_thread_handle):
3078         Adjust comments to reflect renaming of thread_from_thread_handle
3079         to thread_from_handle.  Adjust keywords.  Fix type error message.
3080         (inferior_object_methods): Add thread_from_handle.  Retain
3081         thread_from_thread_handle, but mark it as deprecated.
3082
3083 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3084
3085         * gdbthread.h (find_thread_by_handle): Revise declaration.
3086         * thread.c (find_thread_by_handle): Likewise.  Adjust
3087         implementation too.
3088         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3089         support for buffer objects as handles.
3090
3091 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3092
3093         * python/py-infthread.c (thpy_thread_handle): New function.
3094         (thread_object_methods): Register thpy_thread_handle.
3095
3096 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3097
3098         * gdbthread.h (thread_to_thread_handle): Declare.
3099         * thread.c (gdbtypes.h): Include.
3100         (thread_to_thread_handle): New function.
3101
3102         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3103         (target_thread_info_to_thread_handle): Declare.
3104         * target.c (target_thread_info_to_thread_handle): New function.
3105         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3106         * target-delegates.c: Regenerate.
3107
3108         * linux-thread-db.c (class thread_db_target): Add method
3109         thread_info_to_thread_handle.
3110         (thread_db_target::thread_info_to_thread_handle): Define.
3111         * remote.c (class remote_target): Add new method
3112         thread_info_to_thread_handle.
3113         (remote_target::thread_info_to_thread_handle): Define.
3114
3115 2019-04-08  Pedro Alves  <palves@redhat.com>
3116
3117         * common/common-exceptions.c (throw_exception): Don't create
3118         named object to throw; throw directly.
3119         (throw_it): Likewise.  Don't initialize gdb_exception::message
3120         here, with new; pass FMT and AP to the ctor instead.
3121         * common/common-exceptions.h: Include <string>.
3122         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3123         const char *, va_list)): New ctor.  Use std::make_shared.
3124         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3125         errors)): Delete.
3126         (gdb_exception_error::gdb_exception_error(enum errors, const char
3127         *, va_list)): New.
3128         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3129         Add assertion.
3130         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3131         errors)): Delete.
3132         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3133         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3134         Add assertion.
3135
3136 2019-04-08  Tom Tromey  <tom@tromey.com>
3137
3138         * valops.c (value_rtti_indirect_type): Replace throw_exception
3139         with throw.
3140         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3141         with throw.
3142         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3143         throw.
3144         * target.c (target_translate_tls_address): Replace throw_exception
3145         with throw.
3146         * stack.c (frame_apply_command_count): Replace throw_exception
3147         with throw.
3148         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3149         throw.
3150         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3151         with throw.
3152         * rs6000-tdep.c (rs6000_frame_cache)
3153         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3154         * remote.c: Replace throw_exception with throw.
3155         * record-full.c (record_full_message, record_full_wait_1)
3156         (record_full_restore): Replace throw_exception with throw.
3157         * record-btrace.c:
3158         (get_thread_current_frame_id, record_btrace_start_replaying)
3159         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3160         (cmd_record_btrace_start): Replace throw_exception with throw.
3161         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3162         throw.
3163         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3164         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3165         * linespec.c:
3166         (find_linespec_symbols): Replace throw_exception with throw.
3167         * infrun.c (displaced_step_prepare, resume): Replace
3168         throw_exception with throw.
3169         * infcmd.c (post_create_inferior): Replace throw_exception with
3170         throw.
3171         * inf-loop.c (inferior_event_handler): Replace throw_exception
3172         with throw.
3173         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3174         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3175         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3176         (get_prev_frame_always, get_frame_pc_if_available)
3177         (get_frame_address_in_block_if_available, get_frame_language):
3178         Replace throw_exception with throw.
3179         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3180         throw_exception with throw.
3181         * eval.c (fetch_subexp_value, evaluate_var_value)
3182         (evaluate_funcall, evaluate_subexp_standard): Replace
3183         throw_exception with throw.
3184         * dwarf2loc.c (call_site_find_chain)
3185         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3186         Replace throw_exception with throw.
3187         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3188         with throw.
3189         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3190         throw.
3191         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3192         * completer.c (complete_line_internal): Replace throw_exception
3193         with throw.
3194         * compile/compile-object-run.c (compile_object_run): Replace
3195         throw_exception with throw.
3196         * cli/cli-script.c (process_next_line): Replace throw_exception
3197         with throw.
3198         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3199         (btrace_enable, btrace_maint_update_pt_packets): Replace
3200         throw_exception with throw.
3201         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3202         throw_exception with throw.
3203         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3204         throw_exception with throw.
3205         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3206         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3207         * aarch64-tdep.c (aarch64_make_prologue_cache)
3208         (aarch64_make_stub_cache): Replace throw_exception with throw.
3209
3210 2019-04-08  Tom Tromey  <tom@tromey.com>
3211
3212         * common/common-exceptions.c (throw_exception): Rename from
3213         throw_exception_cxx.  Remove old copy.  Make argument const.
3214         (throw_it): Create and throw exception objects directly.
3215         * common/common-exceptions.h (throw_exception): Make argument
3216         const.
3217         (struct gdb_exception_error): Add constructor.
3218         (struct gdb_exception_quit): Add constructor.
3219
3220 2019-04-08  Tom Tromey  <tom@tromey.com>
3221
3222         * common/common-exceptions.h (exception_rethrow): Don't declare.
3223         (TRY_SJLJ): Update comment.
3224         (TRY, CATCH, END_CATCH): Remove.
3225         * common/common-exceptions.c (exception_rethrow): Remove.
3226
3227 2019-04-08  Tom Tromey  <tom@tromey.com>
3228
3229         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3230         Remove.
3231         (gdb_exception_error): Rename from
3232         gdb_exception_RETURN_MASK_ERROR.
3233         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3234         (gdb_quit_bad_alloc): Update.
3235         * aarch64-tdep.c: Update.
3236         * ada-lang.c: Update.
3237         * ada-typeprint.c: Update.
3238         * ada-valprint.c: Update.
3239         * amd64-tdep.c: Update.
3240         * arch-utils.c: Update.
3241         * break-catch-throw.c: Update.
3242         * breakpoint.c: Update.
3243         * btrace.c: Update.
3244         * c-varobj.c: Update.
3245         * cli/cli-cmds.c: Update.
3246         * cli/cli-interp.c: Update.
3247         * cli/cli-script.c: Update.
3248         * common/common-exceptions.c: Update.
3249         * common/new-op.c: Update.
3250         * common/selftest.c: Update.
3251         * compile/compile-c-symbols.c: Update.
3252         * compile/compile-cplus-symbols.c: Update.
3253         * compile/compile-object-load.c: Update.
3254         * compile/compile-object-run.c: Update.
3255         * completer.c: Update.
3256         * corelow.c: Update.
3257         * cp-abi.c: Update.
3258         * cp-support.c: Update.
3259         * cp-valprint.c: Update.
3260         * darwin-nat.c: Update.
3261         * disasm-selftests.c: Update.
3262         * dtrace-probe.c: Update.
3263         * dwarf-index-cache.c: Update.
3264         * dwarf-index-write.c: Update.
3265         * dwarf2-frame-tailcall.c: Update.
3266         * dwarf2-frame.c: Update.
3267         * dwarf2loc.c: Update.
3268         * dwarf2read.c: Update.
3269         * eval.c: Update.
3270         * event-loop.c: Update.
3271         * event-top.c: Update.
3272         * exec.c: Update.
3273         * f-valprint.c: Update.
3274         * fbsd-tdep.c: Update.
3275         * frame-unwind.c: Update.
3276         * frame.c: Update.
3277         * gdbtypes.c: Update.
3278         * gnu-v3-abi.c: Update.
3279         * guile/guile-internal.h: Update.
3280         * guile/scm-block.c: Update.
3281         * guile/scm-breakpoint.c: Update.
3282         * guile/scm-cmd.c: Update.
3283         * guile/scm-disasm.c: Update.
3284         * guile/scm-frame.c: Update.
3285         * guile/scm-lazy-string.c: Update.
3286         * guile/scm-math.c: Update.
3287         * guile/scm-param.c: Update.
3288         * guile/scm-ports.c: Update.
3289         * guile/scm-pretty-print.c: Update.
3290         * guile/scm-symbol.c: Update.
3291         * guile/scm-symtab.c: Update.
3292         * guile/scm-type.c: Update.
3293         * guile/scm-value.c: Update.
3294         * i386-linux-tdep.c: Update.
3295         * i386-tdep.c: Update.
3296         * inf-loop.c: Update.
3297         * infcall.c: Update.
3298         * infcmd.c: Update.
3299         * infrun.c: Update.
3300         * jit.c: Update.
3301         * language.c: Update.
3302         * linespec.c: Update.
3303         * linux-fork.c: Update.
3304         * linux-nat.c: Update.
3305         * linux-tdep.c: Update.
3306         * linux-thread-db.c: Update.
3307         * main.c: Update.
3308         * mi/mi-cmd-break.c: Update.
3309         * mi/mi-cmd-stack.c: Update.
3310         * mi/mi-interp.c: Update.
3311         * mi/mi-main.c: Update.
3312         * objc-lang.c: Update.
3313         * p-valprint.c: Update.
3314         * parse.c: Update.
3315         * ppc-linux-tdep.c: Update.
3316         * printcmd.c: Update.
3317         * python/py-arch.c: Update.
3318         * python/py-breakpoint.c: Update.
3319         * python/py-cmd.c: Update.
3320         * python/py-finishbreakpoint.c: Update.
3321         * python/py-frame.c: Update.
3322         * python/py-framefilter.c: Update.
3323         * python/py-gdb-readline.c: Update.
3324         * python/py-inferior.c: Update.
3325         * python/py-infthread.c: Update.
3326         * python/py-lazy-string.c: Update.
3327         * python/py-linetable.c: Update.
3328         * python/py-objfile.c: Update.
3329         * python/py-param.c: Update.
3330         * python/py-prettyprint.c: Update.
3331         * python/py-progspace.c: Update.
3332         * python/py-record-btrace.c: Update.
3333         * python/py-record.c: Update.
3334         * python/py-symbol.c: Update.
3335         * python/py-type.c: Update.
3336         * python/py-unwind.c: Update.
3337         * python/py-utils.c: Update.
3338         * python/py-value.c: Update.
3339         * python/python.c: Update.
3340         * record-btrace.c: Update.
3341         * record-full.c: Update.
3342         * remote-fileio.c: Update.
3343         * remote.c: Update.
3344         * riscv-tdep.c: Update.
3345         * rs6000-aix-tdep.c: Update.
3346         * rs6000-tdep.c: Update.
3347         * rust-exp.y: Update.
3348         * rust-lang.c: Update.
3349         * s390-tdep.c: Update.
3350         * selftest-arch.c: Update.
3351         * solib-dsbt.c: Update.
3352         * solib-frv.c: Update.
3353         * solib-spu.c: Update.
3354         * solib-svr4.c: Update.
3355         * solib.c: Update.
3356         * sparc64-linux-tdep.c: Update.
3357         * stack.c: Update.
3358         * symfile-mem.c: Update.
3359         * symmisc.c: Update.
3360         * target.c: Update.
3361         * thread.c: Update.
3362         * top.c: Update.
3363         * tracefile-tfile.c: Update.
3364         * tui/tui.c: Update.
3365         * typeprint.c: Update.
3366         * unittests/cli-utils-selftests.c: Update.
3367         * unittests/parse-connection-spec-selftests.c: Update.
3368         * valops.c: Update.
3369         * valprint.c: Update.
3370         * value.c: Update.
3371         * varobj.c: Update.
3372         * windows-nat.c: Update.
3373         * x86-linux-nat.c: Update.
3374         * xml-support.c: Update.
3375
3376 2019-04-08  Tom Tromey  <tom@tromey.com>
3377
3378         * xml-support.c: Use C++ exception handling.
3379         * x86-linux-nat.c: Use C++ exception handling.
3380         * windows-nat.c: Use C++ exception handling.
3381         * varobj.c: Use C++ exception handling.
3382         * value.c: Use C++ exception handling.
3383         * valprint.c: Use C++ exception handling.
3384         * valops.c: Use C++ exception handling.
3385         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3386         handling.
3387         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3388         * typeprint.c: Use C++ exception handling.
3389         * tui/tui.c: Use C++ exception handling.
3390         * tracefile-tfile.c: Use C++ exception handling.
3391         * top.c: Use C++ exception handling.
3392         * thread.c: Use C++ exception handling.
3393         * target.c: Use C++ exception handling.
3394         * symmisc.c: Use C++ exception handling.
3395         * symfile-mem.c: Use C++ exception handling.
3396         * stack.c: Use C++ exception handling.
3397         * sparc64-linux-tdep.c: Use C++ exception handling.
3398         * solib.c: Use C++ exception handling.
3399         * solib-svr4.c: Use C++ exception handling.
3400         * solib-spu.c: Use C++ exception handling.
3401         * solib-frv.c: Use C++ exception handling.
3402         * solib-dsbt.c: Use C++ exception handling.
3403         * selftest-arch.c: Use C++ exception handling.
3404         * s390-tdep.c: Use C++ exception handling.
3405         * rust-lang.c: Use C++ exception handling.
3406         * rust-exp.y: Use C++ exception handling.
3407         * rs6000-tdep.c: Use C++ exception handling.
3408         * rs6000-aix-tdep.c: Use C++ exception handling.
3409         * riscv-tdep.c: Use C++ exception handling.
3410         * remote.c: Use C++ exception handling.
3411         * remote-fileio.c: Use C++ exception handling.
3412         * record-full.c: Use C++ exception handling.
3413         * record-btrace.c: Use C++ exception handling.
3414         * python/python.c: Use C++ exception handling.
3415         * python/py-value.c: Use C++ exception handling.
3416         * python/py-utils.c: Use C++ exception handling.
3417         * python/py-unwind.c: Use C++ exception handling.
3418         * python/py-type.c: Use C++ exception handling.
3419         * python/py-symbol.c: Use C++ exception handling.
3420         * python/py-record.c: Use C++ exception handling.
3421         * python/py-record-btrace.c: Use C++ exception handling.
3422         * python/py-progspace.c: Use C++ exception handling.
3423         * python/py-prettyprint.c: Use C++ exception handling.
3424         * python/py-param.c: Use C++ exception handling.
3425         * python/py-objfile.c: Use C++ exception handling.
3426         * python/py-linetable.c: Use C++ exception handling.
3427         * python/py-lazy-string.c: Use C++ exception handling.
3428         * python/py-infthread.c: Use C++ exception handling.
3429         * python/py-inferior.c: Use C++ exception handling.
3430         * python/py-gdb-readline.c: Use C++ exception handling.
3431         * python/py-framefilter.c: Use C++ exception handling.
3432         * python/py-frame.c: Use C++ exception handling.
3433         * python/py-finishbreakpoint.c: Use C++ exception handling.
3434         * python/py-cmd.c: Use C++ exception handling.
3435         * python/py-breakpoint.c: Use C++ exception handling.
3436         * python/py-arch.c: Use C++ exception handling.
3437         * printcmd.c: Use C++ exception handling.
3438         * ppc-linux-tdep.c: Use C++ exception handling.
3439         * parse.c: Use C++ exception handling.
3440         * p-valprint.c: Use C++ exception handling.
3441         * objc-lang.c: Use C++ exception handling.
3442         * mi/mi-main.c: Use C++ exception handling.
3443         * mi/mi-interp.c: Use C++ exception handling.
3444         * mi/mi-cmd-stack.c: Use C++ exception handling.
3445         * mi/mi-cmd-break.c: Use C++ exception handling.
3446         * main.c: Use C++ exception handling.
3447         * linux-thread-db.c: Use C++ exception handling.
3448         * linux-tdep.c: Use C++ exception handling.
3449         * linux-nat.c: Use C++ exception handling.
3450         * linux-fork.c: Use C++ exception handling.
3451         * linespec.c: Use C++ exception handling.
3452         * language.c: Use C++ exception handling.
3453         * jit.c: Use C++ exception handling.
3454         * infrun.c: Use C++ exception handling.
3455         * infcmd.c: Use C++ exception handling.
3456         * infcall.c: Use C++ exception handling.
3457         * inf-loop.c: Use C++ exception handling.
3458         * i386-tdep.c: Use C++ exception handling.
3459         * i386-linux-tdep.c: Use C++ exception handling.
3460         * guile/scm-value.c: Use C++ exception handling.
3461         * guile/scm-type.c: Use C++ exception handling.
3462         * guile/scm-symtab.c: Use C++ exception handling.
3463         * guile/scm-symbol.c: Use C++ exception handling.
3464         * guile/scm-pretty-print.c: Use C++ exception handling.
3465         * guile/scm-ports.c: Use C++ exception handling.
3466         * guile/scm-param.c: Use C++ exception handling.
3467         * guile/scm-math.c: Use C++ exception handling.
3468         * guile/scm-lazy-string.c: Use C++ exception handling.
3469         * guile/scm-frame.c: Use C++ exception handling.
3470         * guile/scm-disasm.c: Use C++ exception handling.
3471         * guile/scm-cmd.c: Use C++ exception handling.
3472         * guile/scm-breakpoint.c: Use C++ exception handling.
3473         * guile/scm-block.c: Use C++ exception handling.
3474         * guile/guile-internal.h: Use C++ exception handling.
3475         * gnu-v3-abi.c: Use C++ exception handling.
3476         * gdbtypes.c: Use C++ exception handling.
3477         * frame.c: Use C++ exception handling.
3478         * frame-unwind.c: Use C++ exception handling.
3479         * fbsd-tdep.c: Use C++ exception handling.
3480         * f-valprint.c: Use C++ exception handling.
3481         * exec.c: Use C++ exception handling.
3482         * event-top.c: Use C++ exception handling.
3483         * event-loop.c: Use C++ exception handling.
3484         * eval.c: Use C++ exception handling.
3485         * dwarf2read.c: Use C++ exception handling.
3486         * dwarf2loc.c: Use C++ exception handling.
3487         * dwarf2-frame.c: Use C++ exception handling.
3488         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3489         * dwarf-index-write.c: Use C++ exception handling.
3490         * dwarf-index-cache.c: Use C++ exception handling.
3491         * dtrace-probe.c: Use C++ exception handling.
3492         * disasm-selftests.c: Use C++ exception handling.
3493         * darwin-nat.c: Use C++ exception handling.
3494         * cp-valprint.c: Use C++ exception handling.
3495         * cp-support.c: Use C++ exception handling.
3496         * cp-abi.c: Use C++ exception handling.
3497         * corelow.c: Use C++ exception handling.
3498         * completer.c: Use C++ exception handling.
3499         * compile/compile-object-run.c: Use C++ exception handling.
3500         * compile/compile-object-load.c: Use C++ exception handling.
3501         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3502         * compile/compile-c-symbols.c: Use C++ exception handling.
3503         * common/selftest.c: Use C++ exception handling.
3504         * common/new-op.c: Use C++ exception handling.
3505         * cli/cli-script.c: Use C++ exception handling.
3506         * cli/cli-interp.c: Use C++ exception handling.
3507         * cli/cli-cmds.c: Use C++ exception handling.
3508         * c-varobj.c: Use C++ exception handling.
3509         * btrace.c: Use C++ exception handling.
3510         * breakpoint.c: Use C++ exception handling.
3511         * break-catch-throw.c: Use C++ exception handling.
3512         * arch-utils.c: Use C++ exception handling.
3513         * amd64-tdep.c: Use C++ exception handling.
3514         * ada-valprint.c: Use C++ exception handling.
3515         * ada-typeprint.c: Use C++ exception handling.
3516         * ada-lang.c: Use C++ exception handling.
3517         * aarch64-tdep.c: Use C++ exception handling.
3518
3519 2019-04-08  Tom Tromey  <tom@tromey.com>
3520
3521         * xml-support.c (gdb_xml_parser::parse): Update.
3522         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3523         * value.c (show_convenience): Update.
3524         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3525         (test_parse_flags_qcs): Update.
3526         * thread.c (thr_try_catch_cmd): Update.
3527         * target.c (target_translate_tls_address): Update.
3528         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3529         (info_frame_command_core, frame_apply_command_count): Update.
3530         * rust-exp.y (rust_lex_exception_test): Update.
3531         * riscv-tdep.c (riscv_print_one_register_info): Update.
3532         * remote.c (remote_target::enable_btrace): Update.
3533         * record-btrace.c (record_btrace_enable_warn): Update.
3534         * python/py-utils.c (gdbpy_convert_exception): Update.
3535         * printcmd.c (do_one_display, print_variable_and_value): Update.
3536         * mi/mi-main.c (mi_print_exception): Update.
3537         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3538         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3539         * linux-nat.c (linux_nat_target::attach): Update.
3540         * linux-fork.c (class scoped_switch_fork_info): Update.
3541         * infrun.c (displaced_step_prepare): Update.
3542         * infcall.c (call_function_by_hand_dummy): Update.
3543         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3544         * gnu-v3-abi.c (print_one_vtable): Update.
3545         * frame.c (get_prev_frame_always): Update.
3546         * f-valprint.c (info_common_command_for_block): Update.
3547         * exec.c (try_open_exec_file): Update.
3548         * exceptions.c (print_exception, exception_print)
3549         (exception_fprintf, exception_print_same): Update.
3550         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3551         * dwarf-index-cache.c (index_cache::store)
3552         (index_cache::lookup_gdb_index): Update.
3553         * darwin-nat.c (maybe_cache_shell): Update.
3554         * cp-valprint.c (cp_print_value_fields): Update.
3555         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3556         (gcc_cplus_symbol_address): Update.
3557         * compile/compile-c-symbols.c (gcc_convert_symbol)
3558         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3559         * common/selftest.c: Update.
3560         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3561         a std::string.
3562         (exception_try_scope_entry, exception_try_scope_exit): Don't
3563         declare.
3564         (struct exception_try_scope): Remove.
3565         (TRY): Don't use exception_try_scope.
3566         (struct gdb_exception): Add constructor, operator=.
3567         <what>: New method.
3568         (struct gdb_exception_RETURN_MASK_ALL)
3569         (struct gdb_exception_RETURN_MASK_ERROR)
3570         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3571         (struct gdb_quit_bad_alloc): Update.
3572         * common/common-exceptions.c (exception_none): Change
3573         initializer.
3574         (struct catcher) <state, exception>: Initialize inline.
3575         <prev>: Remove member.
3576         (current_catcher): Remove.
3577         (catchers): New global.
3578         (exceptions_state_mc_init): Simplify.
3579         (catcher_pop): Remove.
3580         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3581         (try_scope_depth, exception_try_scope_entry)
3582         (exception_try_scope_exit): Remove.
3583         (throw_exception_sjlj): Update.
3584         (exception_messages, exception_messages_size): Remove.
3585         (throw_it): Simplify.
3586         (gdb_exception_sliced_copy): Remove.
3587         (throw_exception_cxx): Update.
3588         * cli/cli-script.c (script_from_file): Update.
3589         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3590         Update.
3591         * ada-valprint.c (ada_val_print): Update.
3592         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3593         (create_excep_cond_exprs): Update.
3594
3595 2019-04-08  Tom Tromey  <tom@tromey.com>
3596
3597         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3598         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3599         (TRY, CATCH, END_CATCH): Remove some definitions.
3600         * common/common-exceptions.c: Don't use GDB_XCPT.
3601         (catcher_list_size): Remove.
3602         (throw_exception, throw_it): Simplify.
3603
3604 2019-04-05  Tom Tromey  <tom@tromey.com>
3605
3606         Revert the header-sorting patch.
3607         * ft32-tdep.c: Revert.
3608         * frv-tdep.c: Revert.
3609         * frv-linux-tdep.c: Revert.
3610         * frame.c: Revert.
3611         * frame-unwind.c: Revert.
3612         * frame-base.c: Revert.
3613         * fork-child.c: Revert.
3614         * findvar.c: Revert.
3615         * findcmd.c: Revert.
3616         * filesystem.c: Revert.
3617         * filename-seen-cache.h: Revert.
3618         * filename-seen-cache.c: Revert.
3619         * fbsd-tdep.c: Revert.
3620         * fbsd-nat.h: Revert.
3621         * fbsd-nat.c: Revert.
3622         * f-valprint.c: Revert.
3623         * f-typeprint.c: Revert.
3624         * f-lang.c: Revert.
3625         * extension.h: Revert.
3626         * extension.c: Revert.
3627         * extension-priv.h: Revert.
3628         * expprint.c: Revert.
3629         * exec.h: Revert.
3630         * exec.c: Revert.
3631         * exceptions.c: Revert.
3632         * event-top.c: Revert.
3633         * event-loop.c: Revert.
3634         * eval.c: Revert.
3635         * elfread.c: Revert.
3636         * dwarf2read.h: Revert.
3637         * dwarf2read.c: Revert.
3638         * dwarf2loc.c: Revert.
3639         * dwarf2expr.h: Revert.
3640         * dwarf2expr.c: Revert.
3641         * dwarf2-frame.c: Revert.
3642         * dwarf2-frame-tailcall.c: Revert.
3643         * dwarf-index-write.h: Revert.
3644         * dwarf-index-write.c: Revert.
3645         * dwarf-index-common.c: Revert.
3646         * dwarf-index-cache.h: Revert.
3647         * dwarf-index-cache.c: Revert.
3648         * dummy-frame.c: Revert.
3649         * dtrace-probe.c: Revert.
3650         * disasm.h: Revert.
3651         * disasm.c: Revert.
3652         * disasm-selftests.c: Revert.
3653         * dictionary.c: Revert.
3654         * dicos-tdep.c: Revert.
3655         * demangle.c: Revert.
3656         * dcache.h: Revert.
3657         * dcache.c: Revert.
3658         * darwin-nat.h: Revert.
3659         * darwin-nat.c: Revert.
3660         * darwin-nat-info.c: Revert.
3661         * d-valprint.c: Revert.
3662         * d-namespace.c: Revert.
3663         * d-lang.c: Revert.
3664         * ctf.c: Revert.
3665         * csky-tdep.c: Revert.
3666         * csky-linux-tdep.c: Revert.
3667         * cris-tdep.c: Revert.
3668         * cris-linux-tdep.c: Revert.
3669         * cp-valprint.c: Revert.
3670         * cp-support.c: Revert.
3671         * cp-namespace.c: Revert.
3672         * cp-abi.c: Revert.
3673         * corelow.c: Revert.
3674         * corefile.c: Revert.
3675         * continuations.c: Revert.
3676         * completer.h: Revert.
3677         * completer.c: Revert.
3678         * complaints.c: Revert.
3679         * coffread.c: Revert.
3680         * coff-pe-read.c: Revert.
3681         * cli-out.h: Revert.
3682         * cli-out.c: Revert.
3683         * charset.c: Revert.
3684         * c-varobj.c: Revert.
3685         * c-valprint.c: Revert.
3686         * c-typeprint.c: Revert.
3687         * c-lang.c: Revert.
3688         * buildsym.c: Revert.
3689         * buildsym-legacy.c: Revert.
3690         * build-id.h: Revert.
3691         * build-id.c: Revert.
3692         * btrace.c: Revert.
3693         * bsd-uthread.c: Revert.
3694         * breakpoint.h: Revert.
3695         * breakpoint.c: Revert.
3696         * break-catch-throw.c: Revert.
3697         * break-catch-syscall.c: Revert.
3698         * break-catch-sig.c: Revert.
3699         * blockframe.c: Revert.
3700         * block.c: Revert.
3701         * bfin-tdep.c: Revert.
3702         * bfin-linux-tdep.c: Revert.
3703         * bfd-target.c: Revert.
3704         * bcache.c: Revert.
3705         * ax-general.c: Revert.
3706         * ax-gdb.h: Revert.
3707         * ax-gdb.c: Revert.
3708         * avr-tdep.c: Revert.
3709         * auxv.c: Revert.
3710         * auto-load.c: Revert.
3711         * arm-wince-tdep.c: Revert.
3712         * arm-tdep.c: Revert.
3713         * arm-symbian-tdep.c: Revert.
3714         * arm-pikeos-tdep.c: Revert.
3715         * arm-obsd-tdep.c: Revert.
3716         * arm-nbsd-tdep.c: Revert.
3717         * arm-nbsd-nat.c: Revert.
3718         * arm-linux-tdep.c: Revert.
3719         * arm-linux-nat.c: Revert.
3720         * arm-fbsd-tdep.c: Revert.
3721         * arm-fbsd-nat.c: Revert.
3722         * arm-bsd-tdep.c: Revert.
3723         * arch-utils.c: Revert.
3724         * arc-tdep.c: Revert.
3725         * arc-newlib-tdep.c: Revert.
3726         * annotate.h: Revert.
3727         * annotate.c: Revert.
3728         * amd64-windows-tdep.c: Revert.
3729         * amd64-windows-nat.c: Revert.
3730         * amd64-tdep.c: Revert.
3731         * amd64-sol2-tdep.c: Revert.
3732         * amd64-obsd-tdep.c: Revert.
3733         * amd64-obsd-nat.c: Revert.
3734         * amd64-nbsd-tdep.c: Revert.
3735         * amd64-nbsd-nat.c: Revert.
3736         * amd64-nat.c: Revert.
3737         * amd64-linux-tdep.c: Revert.
3738         * amd64-linux-nat.c: Revert.
3739         * amd64-fbsd-tdep.c: Revert.
3740         * amd64-fbsd-nat.c: Revert.
3741         * amd64-dicos-tdep.c: Revert.
3742         * amd64-darwin-tdep.c: Revert.
3743         * amd64-bsd-nat.c: Revert.
3744         * alpha-tdep.c: Revert.
3745         * alpha-obsd-tdep.c: Revert.
3746         * alpha-nbsd-tdep.c: Revert.
3747         * alpha-mdebug-tdep.c: Revert.
3748         * alpha-linux-tdep.c: Revert.
3749         * alpha-linux-nat.c: Revert.
3750         * alpha-bsd-tdep.c: Revert.
3751         * alpha-bsd-nat.c: Revert.
3752         * aix-thread.c: Revert.
3753         * agent.c: Revert.
3754         * addrmap.c: Revert.
3755         * ada-varobj.c: Revert.
3756         * ada-valprint.c: Revert.
3757         * ada-typeprint.c: Revert.
3758         * ada-tasks.c: Revert.
3759         * ada-lang.c: Revert.
3760         * aarch64-tdep.c: Revert.
3761         * aarch64-ravenscar-thread.c: Revert.
3762         * aarch64-newlib-tdep.c: Revert.
3763         * aarch64-linux-tdep.c: Revert.
3764         * aarch64-linux-nat.c: Revert.
3765         * aarch64-fbsd-tdep.c: Revert.
3766         * aarch64-fbsd-nat.c: Revert.
3767         * aarch32-linux-nat.c: Revert.
3768
3769 2019-04-05  Tom Tromey  <tom@tromey.com>
3770
3771         * ft32-tdep.c: Sort headers.
3772         * frv-tdep.c: Sort headers.
3773         * frv-linux-tdep.c: Sort headers.
3774         * frame.c: Sort headers.
3775         * frame-unwind.c: Sort headers.
3776         * frame-base.c: Sort headers.
3777         * fork-child.c: Sort headers.
3778         * findvar.c: Sort headers.
3779         * findcmd.c: Sort headers.
3780         * filesystem.c: Sort headers.
3781         * filename-seen-cache.h: Sort headers.
3782         * filename-seen-cache.c: Sort headers.
3783         * fbsd-tdep.c: Sort headers.
3784         * fbsd-nat.h: Sort headers.
3785         * fbsd-nat.c: Sort headers.
3786         * f-valprint.c: Sort headers.
3787         * f-typeprint.c: Sort headers.
3788         * f-lang.c: Sort headers.
3789         * extension.h: Sort headers.
3790         * extension.c: Sort headers.
3791         * extension-priv.h: Sort headers.
3792         * expprint.c: Sort headers.
3793         * exec.h: Sort headers.
3794         * exec.c: Sort headers.
3795         * exceptions.c: Sort headers.
3796         * event-top.c: Sort headers.
3797         * event-loop.c: Sort headers.
3798         * eval.c: Sort headers.
3799         * elfread.c: Sort headers.
3800         * dwarf2read.h: Sort headers.
3801         * dwarf2read.c: Sort headers.
3802         * dwarf2loc.c: Sort headers.
3803         * dwarf2expr.h: Sort headers.
3804         * dwarf2expr.c: Sort headers.
3805         * dwarf2-frame.c: Sort headers.
3806         * dwarf2-frame-tailcall.c: Sort headers.
3807         * dwarf-index-write.h: Sort headers.
3808         * dwarf-index-write.c: Sort headers.
3809         * dwarf-index-common.c: Sort headers.
3810         * dwarf-index-cache.h: Sort headers.
3811         * dwarf-index-cache.c: Sort headers.
3812         * dummy-frame.c: Sort headers.
3813         * dtrace-probe.c: Sort headers.
3814         * disasm.h: Sort headers.
3815         * disasm.c: Sort headers.
3816         * disasm-selftests.c: Sort headers.
3817         * dictionary.c: Sort headers.
3818         * dicos-tdep.c: Sort headers.
3819         * demangle.c: Sort headers.
3820         * dcache.h: Sort headers.
3821         * dcache.c: Sort headers.
3822         * darwin-nat.h: Sort headers.
3823         * darwin-nat.c: Sort headers.
3824         * darwin-nat-info.c: Sort headers.
3825         * d-valprint.c: Sort headers.
3826         * d-namespace.c: Sort headers.
3827         * d-lang.c: Sort headers.
3828         * ctf.c: Sort headers.
3829         * csky-tdep.c: Sort headers.
3830         * csky-linux-tdep.c: Sort headers.
3831         * cris-tdep.c: Sort headers.
3832         * cris-linux-tdep.c: Sort headers.
3833         * cp-valprint.c: Sort headers.
3834         * cp-support.c: Sort headers.
3835         * cp-namespace.c: Sort headers.
3836         * cp-abi.c: Sort headers.
3837         * corelow.c: Sort headers.
3838         * corefile.c: Sort headers.
3839         * continuations.c: Sort headers.
3840         * completer.h: Sort headers.
3841         * completer.c: Sort headers.
3842         * complaints.c: Sort headers.
3843         * coffread.c: Sort headers.
3844         * coff-pe-read.c: Sort headers.
3845         * cli-out.h: Sort headers.
3846         * cli-out.c: Sort headers.
3847         * charset.c: Sort headers.
3848         * c-varobj.c: Sort headers.
3849         * c-valprint.c: Sort headers.
3850         * c-typeprint.c: Sort headers.
3851         * c-lang.c: Sort headers.
3852         * buildsym.c: Sort headers.
3853         * buildsym-legacy.c: Sort headers.
3854         * build-id.h: Sort headers.
3855         * build-id.c: Sort headers.
3856         * btrace.c: Sort headers.
3857         * bsd-uthread.c: Sort headers.
3858         * breakpoint.h: Sort headers.
3859         * breakpoint.c: Sort headers.
3860         * break-catch-throw.c: Sort headers.
3861         * break-catch-syscall.c: Sort headers.
3862         * break-catch-sig.c: Sort headers.
3863         * blockframe.c: Sort headers.
3864         * block.c: Sort headers.
3865         * bfin-tdep.c: Sort headers.
3866         * bfin-linux-tdep.c: Sort headers.
3867         * bfd-target.c: Sort headers.
3868         * bcache.c: Sort headers.
3869         * ax-general.c: Sort headers.
3870         * ax-gdb.h: Sort headers.
3871         * ax-gdb.c: Sort headers.
3872         * avr-tdep.c: Sort headers.
3873         * auxv.c: Sort headers.
3874         * auto-load.c: Sort headers.
3875         * arm-wince-tdep.c: Sort headers.
3876         * arm-tdep.c: Sort headers.
3877         * arm-symbian-tdep.c: Sort headers.
3878         * arm-pikeos-tdep.c: Sort headers.
3879         * arm-obsd-tdep.c: Sort headers.
3880         * arm-nbsd-tdep.c: Sort headers.
3881         * arm-nbsd-nat.c: Sort headers.
3882         * arm-linux-tdep.c: Sort headers.
3883         * arm-linux-nat.c: Sort headers.
3884         * arm-fbsd-tdep.c: Sort headers.
3885         * arm-fbsd-nat.c: Sort headers.
3886         * arm-bsd-tdep.c: Sort headers.
3887         * arch-utils.c: Sort headers.
3888         * arc-tdep.c: Sort headers.
3889         * arc-newlib-tdep.c: Sort headers.
3890         * annotate.h: Sort headers.
3891         * annotate.c: Sort headers.
3892         * amd64-windows-tdep.c: Sort headers.
3893         * amd64-windows-nat.c: Sort headers.
3894         * amd64-tdep.c: Sort headers.
3895         * amd64-sol2-tdep.c: Sort headers.
3896         * amd64-obsd-tdep.c: Sort headers.
3897         * amd64-obsd-nat.c: Sort headers.
3898         * amd64-nbsd-tdep.c: Sort headers.
3899         * amd64-nbsd-nat.c: Sort headers.
3900         * amd64-nat.c: Sort headers.
3901         * amd64-linux-tdep.c: Sort headers.
3902         * amd64-linux-nat.c: Sort headers.
3903         * amd64-fbsd-tdep.c: Sort headers.
3904         * amd64-fbsd-nat.c: Sort headers.
3905         * amd64-dicos-tdep.c: Sort headers.
3906         * amd64-darwin-tdep.c: Sort headers.
3907         * amd64-bsd-nat.c: Sort headers.
3908         * alpha-tdep.c: Sort headers.
3909         * alpha-obsd-tdep.c: Sort headers.
3910         * alpha-nbsd-tdep.c: Sort headers.
3911         * alpha-mdebug-tdep.c: Sort headers.
3912         * alpha-linux-tdep.c: Sort headers.
3913         * alpha-linux-nat.c: Sort headers.
3914         * alpha-bsd-tdep.c: Sort headers.
3915         * alpha-bsd-nat.c: Sort headers.
3916         * aix-thread.c: Sort headers.
3917         * agent.c: Sort headers.
3918         * addrmap.c: Sort headers.
3919         * ada-varobj.c: Sort headers.
3920         * ada-valprint.c: Sort headers.
3921         * ada-typeprint.c: Sort headers.
3922         * ada-tasks.c: Sort headers.
3923         * ada-lang.c: Sort headers.
3924         * aarch64-tdep.c: Sort headers.
3925         * aarch64-ravenscar-thread.c: Sort headers.
3926         * aarch64-newlib-tdep.c: Sort headers.
3927         * aarch64-linux-tdep.c: Sort headers.
3928         * aarch64-linux-nat.c: Sort headers.
3929         * aarch64-fbsd-tdep.c: Sort headers.
3930         * aarch64-fbsd-nat.c: Sort headers.
3931         * aarch32-linux-nat.c: Sort headers.
3932
3933 2019-04-04  Tom Tromey  <tom@tromey.com>
3934
3935         * varobj.c (varobj_create): Update.
3936         * rust-exp.y (struct rust_parser) <update_innermost_block,
3937         lookup_symbol>: New methods.
3938         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3939         Rename.
3940         (rust_parser::rust_lookup_type)
3941         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3942         * printcmd.c (display_command, do_one_display): Update.
3943         * parser-defs.h (struct parser_state) <parser_state>: Add
3944         "tracker" parameter.
3945         (block_tracker): New member.
3946         (class innermost_block_tracker) <innermost_block_tracker>: Add
3947         "types" parameter.
3948         <reset>: Remove method.
3949         (innermost_block): Don't declare.
3950         (null_post_parser): Update.
3951         * parse.c (innermost_block): Remove global.
3952         (write_dollar_variable): Update.
3953         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3954         Remove "tracker_types" parameter.
3955         (parse_expression): Add "tracker" parameter.
3956         (parse_expression_for_completion): Update.
3957         (null_post_parser): Add "tracker" parameter.
3958         * p-exp.y: Update rules.
3959         * m2-exp.y: Update rules.
3960         * language.h (struct language_defn) <la_post_parser>: Add
3961         "tracker" parameter.
3962         * go-exp.y: Update rules.
3963         * f-exp.y: Update rules.
3964         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3965         parameter.
3966         * d-exp.y: Update rules.
3967         * c-exp.y: Update rules.
3968         * breakpoint.c (set_breakpoint_condition): Create an
3969         innermost_block_tracker.
3970         (watch_command_1): Likewise.
3971         * ada-lang.c (resolve): Add "tracker" parameter.
3972         (resolve_subexp): Likewise.
3973         * ada-exp.y (write_var_from_sym): Update.
3974
3975 2019-04-04  Tom Tromey  <tom@tromey.com>
3976
3977         * type-stack.h: New file.
3978         * type-stack.c: New file.
3979         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3980         type-stack.h.
3981         (insert_into_type_stack, insert_type, push_type, push_type_int)
3982         (insert_type_address_space, pop_type, pop_type_int)
3983         (pop_typelist, pop_type_stack, append_type_stack)
3984         (push_type_stack, get_type_stack, push_typelist)
3985         (follow_type_instance_flags, follow_types): Don't declare.
3986         * parse.c (type_stack): Remove global.
3987         (parse_exp_in_context): Update.
3988         (insert_into_type_stack, insert_type, push_type, push_type_int)
3989         (insert_type_address_space, pop_type, pop_type_int)
3990         (pop_typelist, pop_type_stack, append_type_stack)
3991         (push_type_stack, get_type_stack, push_typelist)
3992         (follow_type_instance_flags, follow_types): Remove (moved to
3993         type-stack.c).
3994         * f-exp.y (type_stack): New global.
3995         Update rules.
3996         (push_kind_type, f_parse): Update.
3997         * d-exp.y (type_stack): New global.
3998         Update rules.
3999         (d_parse): Update.
4000         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4001         Update rules.
4002         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4003         (HFILES_NO_SRCDIR): Add type-stack.h.
4004
4005 2019-04-04  Tom Tromey  <tom@tromey.com>
4006
4007         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4008         (rust_parser::convert_ast_to_expression, rust_parse)
4009         (rust_lex_test_completion, rust_lex_tests): Update.
4010         * parser-defs.h (struct expr_completion_state): New.
4011         (struct parser_state) <parser_state>: Add completion parameter.
4012         <mark_struct_expression, mark_completion_tag>: New methods.
4013         <parse_completion, m_completion_state>: New members.
4014         (prefixify_expression, null_post_parser): Update.
4015         (mark_struct_expression, mark_completion_tag): Don't declare.
4016         * parse.c (parse_completion, expout_last_struct)
4017         (expout_tag_completion_type, expout_completion_name): Remove
4018         globals.
4019         (parser_state::mark_struct_expression)
4020         (parser_state::mark_completion_tag): Now methods.
4021         (prefixify_expression): Add last_struct parameter.
4022         (prefixify_subexp): Likewise.
4023         (parse_exp_1): Update.
4024         (parse_exp_in_context): Add cstate parameter.  Update.
4025         (parse_expression_for_completion): Create an
4026         expr_completion_state.
4027         (null_post_parser): Add "completion" parameter.
4028         * p-exp.y: Update rules.
4029         (yylex): Update.
4030         * language.h (struct language_defn) <la_post_parser>: Add
4031         "completing" parameter.
4032         * go-exp.y: Update rules.
4033         (lex_one_token): Update.
4034         * expression.h (parse_completion): Don't declare.
4035         * d-exp.y: Update rules.
4036         (lex_one_token): Update rules.
4037         * c-exp.y: Update rules.
4038         (lex_one_token): Update.
4039         * ada-lang.c (resolve): Add "parse_completion" parameter.
4040         (resolve_subexp): Likewise.
4041         (ada_resolve_function): Likewise.
4042
4043 2019-04-04  Tom Tromey  <tom@tromey.com>
4044
4045         * parser-defs.h (struct parser_state) <start_arglist,
4046         end_arglist>: New methods.
4047         <arglist_len, m_funcall_chain>: New members.
4048         (arglist_len, start_arglist, end_arglist): Don't declare.
4049         * parse.c (arglist_len, funcall_chain): Remove global.
4050         (start_arglist, end_arglist): Remove functions.
4051         (parse_exp_in_context): Update.
4052         * p-exp.y: Update rules.
4053         * m2-exp.y: Update rules.
4054         * go-exp.y: Update rules.
4055         * f-exp.y: Update rules.
4056         * d-exp.y: Update rules.
4057         * c-exp.y: Update rules.
4058
4059 2019-04-04  Tom Tromey  <tom@tromey.com>
4060
4061         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4062         lex_operator, push_back>: New methods.
4063         Update all rules.
4064         (rust_parser::lex_hex, lex_escape): Rename and update.
4065         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4066         (rust_parser::lex_operator): Rename and update.
4067         (rust_parser::lex_number, rustyylex, rustyyerror)
4068         (rust_lex_test_init, rust_lex_test_sequence)
4069         (rust_lex_test_push_back, rust_lex_tests): Update.
4070         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4071         parameter.
4072         <lexptr, prev_lexptr>: New members.
4073         (lexptr, prev_lexptr): Don't declare.
4074         * parse.c (lexptr, prev_lexptr): Remove globals.
4075         (parse_exp_in_context): Update.
4076         * p-exp.y (yylex, yyerror): Update.
4077         * m2-exp.y (parse_number, yylex, yyerror): Update.
4078         * go-exp.y (lex_one_token, yyerror): Update.
4079         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4080         * d-exp.y (lex_one_token, yyerror): Update.
4081         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4082         (lex_one_token, yyerror): Update.
4083         * ada-lex.l (YY_INPUT): Update.
4084         (rewind_to_char): Update.
4085         * ada-exp.y (yyerror): Update.
4086
4087 2019-04-04  Tom Tromey  <tom@tromey.com>
4088
4089         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4090         * parser-defs.h (struct parser_state) <parser_state>: Add new
4091         parameter.
4092         <comma_terminates>: New member.
4093         (comma_terminates): Don't declare global.
4094         * parse.c (comma_terminates): Remove global.
4095         (parse_exp_in_context): Update.
4096         * p-exp.y (yylex): Update.
4097         * m2-exp.y (yylex): Update.
4098         * go-exp.y (lex_one_token): Update.
4099         * f-exp.y (yylex): Update.
4100         * d-exp.y (lex_one_token): Update.
4101         * c-exp.y (lex_one_token): Update.
4102         * ada-lex.l: Update.
4103
4104 2019-04-04  Tom Tromey  <tom@tromey.com>
4105
4106         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4107         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4108         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4109         * parser-defs.h (paren_depth): Don't declare.
4110         * parse.c (paren_depth): Remove global.
4111         (parse_exp_in_context): Update.
4112         * p-exp.y (paren_depth): New global.
4113         (pascal_parse): Initialize it.
4114         * m2-exp.y (paren_depth): New global.
4115         (m2_parse): Initialize it.
4116         * go-exp.y (paren_depth): New global.
4117         (go_parse): Initialize it.
4118         * f-exp.y (paren_depth): New global.
4119         (f_parse): Initialize it.
4120         * d-exp.y (paren_depth): New global.
4121         (d_parse): Initialize it.
4122         * c-exp.y (paren_depth): New global.
4123         (c_parse): Initialize it.
4124         * ada-lex.l (paren_depth): New global.
4125         (lexer_init): Initialize it.
4126
4127 2019-04-04  Tom Tromey  <tom@tromey.com>
4128
4129         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4130         (rust_parser::convert_ast_to_type)
4131         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4132         * parser-defs.h (struct parser_state) <parser_state>: Add
4133         parameters.  Initialize new members.
4134         <expression_context_block, expression_context_pc>: New members.
4135         * parse.c (expression_context_block, expression_context_pc):
4136         Remove globals.
4137         (parse_exp_in_context): Update.
4138         * p-exp.y: Update all rules.
4139         (yylex): Update.
4140         * m2-exp.y: Update all rules.
4141         (yylex): Update.
4142         * go-exp.y (yylex): Update.
4143         * f-exp.y (yylex): Update.
4144         * d-exp.y: Update all rules.
4145         (yylex): Update.
4146         * c-exp.y: Update all rules.
4147         (lex_one_token, classify_name, yylex, c_parse): Update.
4148         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4149
4150 2019-04-04  Tom Tromey  <tom@tromey.com>
4151
4152         * gdbarch.h, gdbarch.c: Rebuild.
4153         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4154         * stap-probe.h:
4155         (struct stap_parse_info): Replace "parser_state" with
4156         "expr_builder".
4157         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4158         (parser_state): New class.
4159         * parse.c (expr_builder): Rename.
4160         (expr_builder::release): Rename.
4161         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4162         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4163         (write_exp_elt_longcst, write_exp_elt_floatcst)
4164         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4165         (write_exp_string_vector, write_exp_bitstring)
4166         (write_exp_msymbol, mark_struct_expression)
4167         (write_dollar_variable)
4168         (insert_type_address_space, increase_expout_size): Replace
4169         "parser_state" with "expr_builder".
4170         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4171         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4172         "parser_state" with "expr_builder".
4173
4174 2019-04-04  Tom Tromey  <tom@tromey.com>
4175
4176         * rust-exp.y: Replace "parse_language" with method call.
4177         * p-exp.y:
4178         (yylex): Replace "parse_language" with method call.
4179         * m2-exp.y:
4180         (yylex): Replace "parse_language" with method call.
4181         * go-exp.y (classify_name): Replace "parse_language" with method
4182         call.
4183         * f-exp.y (yylex): Replace "parse_language" with method call.
4184         * d-exp.y (lex_one_token): Replace "parse_language" with method
4185         call.
4186         * c-exp.y:
4187         (lex_one_token, classify_name, yylex): Replace "parse_language"
4188         with method call.
4189         * ada-exp.y (find_primitive_type, type_char)
4190         (type_system_address): Replace "parse_language" with method call.
4191
4192 2019-04-04  Tom Tromey  <tom@tromey.com>
4193
4194         * rust-exp.y: Replace "parse_gdbarch" with method call.
4195         * parse.c (write_dollar_variable, insert_type_address_space):
4196         Replace "parse_gdbarch" with method call.
4197         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4198         call.
4199         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4200         call.
4201         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4202         "parse_gdbarch" with method call.
4203         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4204         with method call.
4205         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4206         "parse_gdbarch" with method call.
4207         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4208         "parse_gdbarch" with method call.
4209         * c-exp.y (parse_type, parse_number, classify_name): Replace
4210         "parse_gdbarch" with method call.
4211         * ada-lex.l: Replace "parse_gdbarch" with method call.
4212         * ada-exp.y (parse_type, find_primitive_type, type_char)
4213         (type_system_address): Replace "parse_gdbarch" with method call.
4214
4215 2019-04-04  Tom Tromey  <tom@tromey.com>
4216
4217         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4218         * stap-probe.c (stap_parse_argument): Update.
4219         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4220         initial_size parameter.
4221         * rust-exp.y (rust_lex_tests): Update.
4222         * parse.c (parser_state): Update.
4223         (parse_exp_in_context): Update.
4224         * parser-defs.h (struct parser_state) <parser_state>: Remove
4225         "initial_size" parameter.
4226
4227 2019-04-04  Tom Tromey  <tom@tromey.com>
4228
4229         * parser-defs.h (increase_expout_size): Don't declare.
4230         * parse.c (increase_expout_size): Now static.
4231
4232 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4233
4234         * gnu-nat.c (gnu_nat_target::wait): Fix
4235         target_waitstatus_to_string call.
4236
4237 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4238
4239         * eval.c (evaluate_subexp_standard): Handle internal functions
4240         during Fortran function call handling.
4241
4242 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4243
4244         * NEWS: Mention new internal functions.
4245         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4246         (read_base_type): Use dwarf2_init_complex_target_type.
4247         * value.c (creal_internal_fn): New function.
4248         (cimag_internal_fn): New function.
4249         (_initialize_values): Register new internal functions.
4250
4251 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4252
4253         * infrun.c (stop_all_threads): If debug_infrun, always
4254         trace the wait status after wait_one, using
4255         target_waitstatus_to_string and target_pid_to_str.
4256         (handle_inferior_event): Replace various trace of
4257         wait status kind by a single trace.
4258         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4259         wait status kind image by target_waitstatus_to_string.
4260         * target/waitstatus.c (target_waitstatus_to_string): Fix
4261         obsolete comment.
4262
4263 2019-04-01  Tom Tromey  <tromey@adacore.com>
4264
4265         PR symtab/23331:
4266         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4267
4268 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4269             Pedro Alves  <palves@redhat.com>
4270
4271         * top.c (quit_force): Call 'finalize_values'.
4272         * value.c (finalize_values): New function.
4273         * value.h (finalize_values): Declare.
4274
4275 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4276
4277         * NEWS: Announce $_gdb_major and $_gdb_minor.
4278
4279         * top.c (init_gdb_version_vars): New function.
4280         (gdb_init): Call init_gdb_version_vars.
4281
4282 2019-03-29  Tom Tromey  <tromey@adacore.com>
4283
4284         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4285         help text.  Remove dead code.
4286
4287 2019-03-29  Keith Seitz  <keiths@redhat.com>
4288
4289         From Siddhesh Poyarekar:
4290         * f-lang.h (f77_get_upperbound): Return LONGEST.
4291         (f77_get_lowerbound): Likewise.
4292         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4293         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4294         print them.
4295         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4296         plongest to format print it.
4297         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4298         (f77_get_upperbound): Likewise.
4299         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4300         LOWER_BOUND to LONGEST.
4301         (f77_create_arrayprint_offset_tbl): Likewise.
4302
4303 2019-03-29  Keith Seitz  <keiths@redhat.com>
4304
4305         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4306         %s/pulongest for TYPE_LENGTH instead of %d in format
4307         strings.
4308         * ada-typerint.c (ada_print_type): Likewise.
4309         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4310         * compile/compile-c-support.c (generate_register_struct): Likewise.
4311         * gdbtypes.c (recursive_dump_type): Likewise.
4312         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4313         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4314         instead of %d in format strings.
4315         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4316         to std::min to ULONGEST.
4317         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4318         instead of %d in format strings.
4319         * tracepoint.c (info_scope_command): Likewise.
4320         * typeprint.c (print_offset_data::update)
4321         (print_offset_data::finish): Likewise.
4322         * xtensa-tdep.c (xtensa_store_return_value)
4323         (xtensa_push_dummy_call): Likewise.
4324
4325 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4326
4327         * windows-nat.c (display_selector): Fixed format specifications
4328         for 64-bit Cygwin.
4329
4330 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4331
4332         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4333
4334 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4335
4336         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4337         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4338         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4339         (nios2_linux_init_abi): Install it.
4340
4341 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4342
4343         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4344
4345 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4346
4347         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4348
4349 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4350             Tom Tromey  <tromey@adacore.com>
4351
4352         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4353
4354 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4355
4356         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4357         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4358         method to compute the bounds of range types. Also print "[evaluated]"
4359         if the bounds' values come from a dynamic evaluation.
4360
4361 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4362
4363         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4364         whitespace when pretty printing is on.
4365
4366 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4367
4368         * ppc-linux-nat.c: Add include.
4369
4370 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4371
4372         * NEWS: Mention AArch64 Pointer Authentication.
4373
4374 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4375
4376         * arm-linux-nat.c: Add include.
4377
4378 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4379
4380         * source-cache.c (source_cache::get_source_lines): Re-read
4381         fullname after calling open_source_file.
4382
4383 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4384
4385         * NEWS: Mention TLS support for FreeBSD.
4386
4387 2019-03-25  Tom Tromey  <tromey@adacore.com>
4388
4389         * minsyms.c (BUNCH_SIZE): Update comment.
4390         (~minimal_symbol_reader): Remove old comment.
4391         (compact_minimal_symbols): Update comment.
4392         (minimal_symbol_reader::install): Remove old comment.  Update
4393         other comments.
4394
4395 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4396
4397         * s390-linux-nat.c: Add include.
4398
4399 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4400
4401         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4402         Call linux_get_hwcap.
4403         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4404         Likewise.
4405         (aarch64_linux_get_hwcap): Remove function.
4406         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4407         declaration.
4408         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4409         linux_get_hwcap.
4410         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4411         * linux-tdep.c (linux_get_hwcap): Add function.
4412         (linux_get_hwcap2): Likewise.
4413         * linux-tdep.h (linux_get_hwcap): Add declaration.
4414         (linux_get_hwcap2): Likewise.
4415         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4416         (ppc_linux_get_hwcap2): Likewise.
4417         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4418         linux_get_hwcap.
4419         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4420         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4421         (ppc_linux_nat_target::read_description): Likewise.
4422         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4423         * s390-linux-nat.c: Likewise.
4424         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4425
4426 2019-03-24  Tom Tromey  <tom@tromey.com>
4427
4428         * ada-lang.c (standard_lookup): Simplify initialization.
4429         (ada_lookup_symbol_nonlocal): Simplify return.
4430         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4431         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4432         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4433         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4434         initialization.
4435         * solib.c (solib_global_lookup): Simplify.
4436         * symtab.c (null_block_symbol): Remove.
4437         (symbol_cache_lookup): Simplify returns.
4438         (lookup_language_this): Simplify returns.
4439         (lookup_symbol_aux): Simplify return.
4440         (lookup_local_symbol): Simplify returns.
4441         (lookup_global_symbol_from_objfile): Simplify return.
4442         (lookup_symbol_in_objfile_symtabs)
4443         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4444         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4445         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4446         * cp-namespace.c (cp_lookup_bare_symbol)
4447         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4448         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4449         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4450         (cp_lookup_symbol_via_imports): Simplify initialization.
4451         (find_symbol_in_baseclass): Likewise.
4452         * symtab.h (null_block_symbol): Remove.
4453         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4454         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4455         (d_lookup_symbol_module): Likewise.
4456         (find_symbol_in_baseclass): Simplify initialization.
4457
4458 2019-03-24  Tom Tromey  <tom@tromey.com>
4459
4460         * expression.h: Don't include symtab.h.
4461         (struct block): Forward declare.
4462
4463 2019-03-24  Tom Tromey  <tom@tromey.com>
4464
4465         * c-exp.y (typebase): Remove casts.
4466         * gdbtypes.c (lookup_unsigned_typename, )
4467         (lookup_signed_typename): Remove cast.
4468         * eval.c (parse_to_comma_and_eval): Remove cast.
4469         * parse.c (write_dollar_variable): Remove cast.
4470         * block.h (struct block) <superblock>: Now const.
4471         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4472         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4473         (map_block): Make "block" const.
4474         * symfile.h (struct quick_symbol_functions)
4475         <map_matching_symbols>: Constify block argument to "callback".
4476         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4477         const.
4478         (find_pc_sect_compunit_symtab): Make "b" const.
4479         (find_symbol_at_address): Likewise.
4480         (search_symbols): Likewise.
4481         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4482         (dw2_debug_names_lookup_symbol): Likewise.
4483         (dw2_map_matching_symbols): Update.
4484         * p-valprint.c (pascal_val_print): Remove "block".
4485         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4486         (aux_add_nonlocal_symbols): Make "block" const.
4487         (resolve_subexp): Remove cast.
4488         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4489         const.
4490         (iterate_over_file_blocks): Likewise.
4491         * f-exp.y (%union) <bval>: Remove.
4492         * coffread.c (patch_opaque_types): Make "b" const.
4493         * spu-tdep.c (spu_catch_start): Make "block" const.
4494         * c-valprint.c (print_unpacked_pointer): Remove "block".
4495         * symmisc.c (dump_symtab_1): Make "b" const.
4496         (block_depth): Make "block" const.
4497         * d-exp.y (%union) <bval>: Remove.
4498         * cp-support.h (cp_lookup_rtti_type): Update.
4499         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4500         * psymtab.c (psym_lookup_symbol): Make "block" const.
4501         (maintenance_check_psymtabs): Make "b" const.
4502         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4503         (enumerate_locals, enumerate_args): Update.
4504         * python/py-symtab.c (stpy_global_block): Make "block" const.
4505         (stpy_static_block): Likewise.
4506         * inline-frame.c (block_starting_point_at): Make "new_block"
4507         const.
4508         * block.c (find_block_in_blockvector): Make return type const.
4509         (blockvector_for_pc_sect): Make "b" const.
4510         (find_block_in_blockvector): Make "b" const.
4511
4512 2019-03-23  Tom Tromey  <tom@tromey.com>
4513
4514         * varobj.c (varobj_create): Update.
4515         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4516         * printcmd.c (display_command, do_one_display): Don't reset
4517         innermost_block.
4518         * parser-defs.h (enum innermost_block_tracker_type): Move to
4519         expression.h.
4520         (innermost_block): Update comment.
4521         * parse.c (parse_exp_1): Add tracker_types parameter.
4522         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4523         tracker_types parameter.  Reset innermost_block.
4524         (parse_exp_in_context): Remove.
4525         (parse_expression_for_completion): Update.
4526         * objfiles.c (~objfile): Don't reset expression_context_block or
4527         innermost_block.
4528         * expression.h (enum innermost_block_tracker_type): Move from
4529         parser-defs.h.
4530         (parse_exp_1): Add tracker_types parameter.
4531         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4532         reset innermost_block.
4533
4534 2019-03-23  Tom Tromey  <tom@tromey.com>
4535
4536         * objfiles.h: Include bcache.h.
4537
4538 2019-03-23  Tom Tromey  <tom@tromey.com>
4539
4540         * linespec.c (get_current_search_block): Use
4541         scoped_restore_current_language.
4542         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4543
4544 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4545             Jiong Wang  <jiong.wang@arm.com>
4546
4547         * aarch64-linux-tdep.c
4548         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4549         section.
4550         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4551
4552 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4553             Jiong Wang  <jiong.wang@arm.com>
4554
4555         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4556         instructions.
4557         (aarch64_analyze_prologue_test): Add PACIASP test.
4558         (aarch64_prologue_prev_register): Unmask PC value.
4559
4560 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4561             Jiong Wang  <jiong.wang@arm.com>
4562
4563         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4564         (aarch64_dwarf2_prev_register): Unmask PC value.
4565         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4566         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4567         DW_CFA_AARCH64_negate_ra_state.
4568         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4569
4570 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4571             Jiong Wang  <jiong.wang@arm.com>
4572
4573         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4574         registers.
4575         (aarch64_pseudo_register_name): Likewise.
4576         (aarch64_pseudo_register_type): Likewise.
4577         (aarch64_pseudo_register_reggroup_p): Likewise.
4578         (aarch64_gdbarch_init): Add pauth registers.
4579         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4580         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4581         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4582         (struct gdbarch_tdep): Add regnum for ra_state.
4583
4584 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4585             Jiong Wang  <jiong.wang@arm.com>
4586
4587         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4588
4589 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4590             Jiong Wang  <jiong.wang@arm.com>
4591
4592         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4593         function.
4594         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4595         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4596         (aarch64_gdbarch_init): Add puth registers.
4597         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4598         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4599         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4600
4601 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4602             Jiong Wang  <jiong.wang@arm.com>
4603
4604         * aarch64-linux-nat.c
4605         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4606         * aarch64-linux-tdep.c
4607         (aarch64_linux_core_read_description): Likewise.
4608         (aarch64_linux_get_hwcap): New function.
4609         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4610         (aarch64_linux_get_hwcap): New declaration.
4611
4612 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4613             Jiong Wang  <jiong.wang@arm.com>
4614
4615         * aarch64-linux-nat.c
4616         (aarch64_linux_nat_target::read_description): Add pauth param.
4617         * aarch64-linux-tdep.c
4618         (aarch64_linux_core_read_description): Likewise.
4619         * aarch64-tdep.c (struct target_desc): Add in pauth.
4620         (aarch64_read_description): Add pauth param.
4621         (aarch64_gdbarch_init): Likewise.
4622         * aarch64-tdep.h (aarch64_read_description): Likewise.
4623         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4624         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4625         * features/Makefile: Add new files.
4626         * features/aarch64-pauth.c: New file.
4627         * features/aarch64-pauth.xml: New file.
4628
4629 2019-03-20  Tom Tromey  <tromey@adacore.com>
4630
4631         * infrun.c (handle_inferior_event): Rename from
4632         handle_inferior_event_1.  Create a scoped_value_mark.
4633         (handle_inferior_event): Remove.
4634
4635 2019-03-19  Tom Tromey  <tromey@adacore.com>
4636
4637         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4638         * infrun.h (print_stop_event): Add "displays" parameter.
4639         * infrun.c (print_stop_event): Add "displays" parameter.
4640
4641 2019-03-19  Pedro Alves  <palves@redhat.com>
4642
4643         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4644         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4645         to -1.  Fix TABs vs spaces.
4646         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4647         * tui/tui-out.h (tui_ui_out) Add intro comments.
4648         <m_line, m_start_of_line>: In-class initialize, and add describing
4649         comment.
4650
4651 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4652
4653         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4654         variable names.
4655         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4656
4657 2019-03-18  Pedro Alves  <palves@redhat.com>
4658             Eli Zaretskii <eliz@gnu.org>
4659
4660         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4661         m_line and m_start_of_line.
4662
4663 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4664
4665         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4666         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4667         it returns a newline.  This fixes a regression in TU mode, whereby
4668         the next line is output on the same screen line as the user input.
4669
4670 2019-03-18  Tom Tromey  <tromey@adacore.com>
4671
4672         * minsyms.c (minimal_symbol_reader::install): Remove call to
4673         obstack_blank.
4674
4675 2019-03-18  Pedro Alves  <palves@redhat.com>
4676
4677         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4678         New globals.
4679         (apply_style): New, factored out from ...
4680         (apply_ansi_escape): ... this.  Handle reverse video mode.
4681         (tui_set_reverse_mode): New function.
4682         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4683         * tui/tui-winsource.c (tui_show_source_line): Use
4684         tui_set_reverse_mode instead of setting A_STANDOUT.
4685         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4686         New setter methods.
4687
4688 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4689
4690         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4691         Handle tabs.
4692
4693 2019-03-18  Tom Tromey  <tromey@adacore.com>
4694
4695         * ada-lang.c (empty_array): Add "high" parameter.
4696         (ada_evaluate_subexp): Update.
4697
4698 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4699
4700         * unittests/string_view-selftests.c: Define
4701         _initialize_string_view_selftests unconditionally.
4702
4703 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4704
4705         PR gdb/24350
4706         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4707
4708 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4709
4710         PR gdb/24351
4711         * windows-nat.c (display_selector): Fix format specifiers.
4712
4713 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4714
4715         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4716         tui_refill_source_window instead of tui_refresh_win, to update the
4717         current execution line.  This fixes redisplay of the current line
4718         when stepping through the code with "next" or "step".
4719
4720 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4721
4722         * source-cache.c (source_cache::get_source_lines): Call
4723         find_source_lines to initialize s->nlines.  This fixes vertical
4724         scrolling of TUI source window when the DOWN arrow is pressed.
4725
4726 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4727
4728         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4729         linux-thread-db.c (_initialize_thread_db): Likewise.
4730
4731 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4732
4733         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4734         wclrtoeol in tui_show_source_line".  This reverts changes made in
4735         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4736
4737 2019-03-15  Tom Tromey  <tom@tromey.com>
4738
4739         * symtab.h (struct minimal_symbol): Derive from
4740         general_symbol_info.
4741         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4742         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4743         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4744         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4745         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4746         (MSYMBOL_SEARCH_NAME): Update.
4747         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4748         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4749         * minsyms.c (minimal_symbol_reader::record_full): Update.
4750
4751 2019-03-15  Tom Tromey  <tom@tromey.com>
4752
4753         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4754
4755 2019-03-15  Tom Tromey  <tom@tromey.com>
4756
4757         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4758         unique_xmalloc_ptr.
4759         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4760         Update.
4761         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4762         (build_minimal_symbol_hash_tables)
4763         (minimal_symbol_reader::install): Update.
4764
4765 2019-03-15  Tom Tromey  <tom@tromey.com>
4766
4767         * symtab.c (create_demangled_names_hash): Update.
4768         (symbol_set_names): Update.
4769         * objfiles.h (struct objfile_per_bfd_storage)
4770         <demangled_names_hash>: Now an htab_up.
4771         * objfiles.c (objfile_per_bfd_storage): Simplify.
4772
4773 2019-03-15  Tom Tromey  <tom@tromey.com>
4774
4775         * objfiles.h (struct objfile_per_bfd_storage): Declare
4776         destructor.
4777         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4778         New.
4779         (get_objfile_bfd_data): Use new.  Don't initialize
4780         language_of_main.
4781         (free_objfile_per_bfd_storage): Remove.
4782         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4783
4784 2019-03-15  Tom Tromey  <tom@tromey.com>
4785
4786         * symfile.c (reread_symbols): Update.
4787         * objfiles.c (objfile::objfile): Update.
4788         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4789         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4790         comment.
4791         (minimal_symbol_reader::install): Update.
4792         (terminate_minimal_symbol_table): Remove.
4793         * jit.c (jit_object_close_impl): Update.
4794
4795 2019-03-15  Tom Tromey  <tom@tromey.com>
4796
4797         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4798         initializations.
4799
4800 2019-03-15  Tom Tromey  <tom@tromey.com>
4801
4802         * objfiles.h (struct objfile_per_bfd_storage)
4803         <demangled_hash_languages>: Now a bitset.
4804         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4805         (lookup_minimal_symbol): Update.
4806
4807 2019-03-15  Tom Tromey  <tom@tromey.com>
4808
4809         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4810         Don't return the symbol.
4811         * coffread.c (record_minimal_symbol): Use record_full.
4812
4813 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4814
4815         The MS-Windows port of ncurses fails to switch to a color pair if
4816         one or both of the colors are the implicit default colors.  This
4817         change records the default colors when TUI is initialized, and
4818         then specifies them explicitly when a color pair uses the default
4819         colors.  This allows color styling in TUI mode on MS-Windows.
4820
4821         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4822         ncurses_norm_attr.
4823         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4824         colors in ncurses_norm_attr.
4825         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4826         "none", replace it with the default color recorded in
4827         ncurses_norm_attr.
4828
4829 2019-03-14  Tom Tromey  <tromey@adacore.com>
4830
4831         * source-cache.h (class source_cache) <get_source_lines>: Return
4832         std::string.
4833         * source-cache.c (source_cache::extract_lines): Handle case where
4834         first_pos==npos.  Return std::string.
4835         (source_cache::get_source_lines): Update.
4836
4837 2019-03-14  Tom Tromey  <tromey@adacore.com>
4838
4839         * NEWS: Add item for "style sources" commands.
4840         * source-cache.c (source_cache::get_source_lines): Check
4841         source_styling.
4842         * cli/cli-style.c (source_styling): New global.
4843         (_initialize_cli_style): Add "style sources" commands.
4844         (show_style_sources): New function.
4845         * cli/cli-style.h (source_styling): Declare.
4846
4847 2019-03-14  Pedro Alves  <palves@redhat.com>
4848             Tom Tromey  <tromey@adacore.com>
4849
4850         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4851         * tui/tui-winsource.c (tui_refill_source_window): New function,
4852         from...
4853         (tui_horizontal_source_scroll): ... here.  Move some logic.
4854         * cli/cli-style.c (set_style_enabled): Notify new observable.
4855         * tui/tui-hooks.c (tui_redisplay_source): New function.
4856         (tui_attach_detach_observers): Attach or detach
4857         tui_redisplay_source.
4858         * observable.h (source_styling_changed): New observable.
4859         * observable.c: Define source_styling_changed observable.
4860
4861 2019-03-13  Tom Tromey  <tromey@adacore.com>
4862
4863         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4864         (i386_gnu_nat_target::store_registers): Update.
4865         * target-debug.h (target_debug_print_std_string): New macro.
4866         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4867         * windows-tdep.c (display_one_tib): Update.
4868         * tui/tui-stack.c (tui_make_status_line): Update.
4869         * top.c (print_inferior_quit_action): Update.
4870         * thread.c (thr_try_catch_cmd): Update.
4871         (add_thread_with_info): Update.
4872         (thread_target_id_str): Update.
4873         (thr_try_catch_cmd): Update.
4874         (thread_command): Update.
4875         (thread_find_command): Update.
4876         * record-btrace.c (record_btrace_target::info_record)
4877         (record_btrace_resume_thread, record_btrace_target::resume)
4878         (record_btrace_cancel_resume, record_btrace_step_thread)
4879         (record_btrace_target::wait, record_btrace_target::wait)
4880         (record_btrace_target::wait, record_btrace_target::stop): Update.
4881         * progspace.c (print_program_space): Update.
4882         * process-stratum-target.c
4883         (process_stratum_target::thread_address_space): Update.
4884         * linux-fork.c (linux_fork_mourn_inferior)
4885         (detach_checkpoint_command, info_checkpoints_command)
4886         (linux_fork_context): Update.
4887         (linux_fork_detach): Update.
4888         (class scoped_switch_fork_info): Update.
4889         (delete_checkpoint_command): Update.
4890         * infrun.c (follow_fork_inferior): Update.
4891         (follow_fork_inferior): Update.
4892         (proceed_after_vfork_done): Update.
4893         (handle_vfork_child_exec_or_exit): Update.
4894         (follow_exec): Update.
4895         (displaced_step_prepare_throw): Update.
4896         (displaced_step_restore): Update.
4897         (start_step_over): Update.
4898         (resume_1): Update.
4899         (clear_proceed_status_thread): Update.
4900         (proceed): Update.
4901         (print_target_wait_results): Update.
4902         (do_target_wait): Update.
4903         (context_switch): Update.
4904         (stop_all_threads): Update.
4905         (restart_threads): Update.
4906         (finish_step_over): Update.
4907         (handle_signal_stop): Update.
4908         (switch_back_to_stepped_thread): Update.
4909         (keep_going_pass_signal): Update.
4910         (print_exited_reason): Update.
4911         (normal_stop): Update.
4912         * inferior.c (inferior_pid_to_str): Change return type.
4913         (print_selected_inferior): Update.
4914         (add_inferior): Update.
4915         (detach_inferior): Update.
4916         * dummy-frame.c (fprint_dummy_frames): Update.
4917         * dcache.c (dcache_info_1): Update.
4918         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4919         (btrace_fetch, btrace_clear): Update.
4920         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4921         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4922         type.
4923         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4924         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4925         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4926         * gdbarch.c, gdbarch.h: Rebuild.
4927         * gdbarch.sh (core_pid_to_str): Change return type.
4928         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4929         return type.
4930         (windows_nat_target::pid_to_str): Change return type.
4931         (windows_delete_thread): Update.
4932         (windows_nat_target::attach): Update.
4933         (windows_nat_target::files_info): Update.
4934         * target-delegates.c: Rebuild.
4935         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4936         return type.
4937         (sol_thread_target::pid_to_str): Change return type.
4938         * remote.c (class remote_target) <pid_to_str>: Change return
4939         type.
4940         (remote_target::pid_to_str): Change return type.
4941         (extended_remote_target::attach, remote_target::remote_stop_ns)
4942         (remote_target::remote_notif_remove_queued_reply)
4943         (remote_target::push_stop_reply, remote_target::disable_btrace):
4944         Update.
4945         (extended_remote_target::attach): Update.
4946         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4947         type.
4948         (gdbsim_target::pid_to_str): Change return type.
4949         * ravenscar-thread.c (struct ravenscar_thread_target)
4950         <pid_to_str>: Change return type.
4951         (ravenscar_thread_target::pid_to_str): Change return type.
4952         * procfs.c (class procfs_target) <pid_to_str>: Change return
4953         type.
4954         (procfs_target::pid_to_str): Change return type.
4955         (procfs_target::attach): Update.
4956         (procfs_target::detach): Update.
4957         (procfs_target::fetch_registers): Update.
4958         (procfs_target::store_registers): Update.
4959         (procfs_target::wait): Update.
4960         (procfs_target::files_info): Update.
4961         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4962         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4963         return type.
4964         (nto_procfs_target::pid_to_str): Change return type.
4965         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4966         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4967         return type.
4968         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4969         (exit_lwp): Update.
4970         (attach_proc_task_lwp_callback, get_detach_signal)
4971         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4972         (linux_nat_target::resume, wait_lwp, stop_callback)
4973         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4974         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4975         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4976         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4977         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4978         type.
4979         (inf_ptrace_target::attach): Update.
4980         (inf_ptrace_target::files_info): Update.
4981         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4982         type.
4983         (go32_nat_target::pid_to_str): Change return type.
4984         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4985         (gnu_nat_target::wait): Update.
4986         (gnu_nat_target::wait): Update.
4987         (gnu_nat_target::resume): Update.
4988         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4989         (fbsd_nat_target::wait): Update.
4990         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4991         type.
4992         (darwin_nat_target::attach): Update.
4993         * corelow.c (class core_target) <pid_to_str>: Change return type.
4994         (core_target::pid_to_str): Change return type.
4995         * target.c (normal_pid_to_str): Change return type.
4996         (default_pid_to_str): Likewise.
4997         (target_pid_to_str): Change return type.
4998         (target_translate_tls_address): Update.
4999         (target_announce_detach): Update.
5000         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5001         return type.
5002         (bsd_uthread_target::pid_to_str): Change return type.
5003         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5004         type.
5005         (bsd_kvm_target::pid_to_str): Change return type.
5006         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5007         return type.
5008         (aix_thread_target::pid_to_str): Change return type.
5009         * target.h (struct target_ops) <pid_to_str>: Change return type.
5010         (target_pid_to_str, normal_pid_to_str): Likewise.
5011         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5012         type.
5013         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5014         type.
5015         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5016         return type.
5017         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5018         type.
5019         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5020         type.
5021         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5022         return type.
5023
5024 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5025
5026         * NEWS: Mention that the new default MI version is 3.  Mention
5027         changes to the output of commands and events that deal with
5028         multi-location breakpoints.
5029         * breakpoint.c: Include "mi/mi-out.h".
5030         (print_one_breakpoint): Change output syntax if using MI version
5031         >= 3.
5032         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5033         New.
5034         (mi_multi_location_breakpoint_output_fixed): New.
5035         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5036         (mi_cmd_fix_multi_location_breakpoint_output): New.
5037         (mi_multi_location_breakpoint_output_fixed): New.
5038         * mi/mi-cmds.c (mi_cmds): Register command
5039         -fix-multi-location-breakpoint-output.
5040         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5041         interpreter "mi".
5042
5043 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5044
5045         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5046         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5047         instantiate mi_ui_out based on interpreter name.
5048         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5049         * mi/mi-main.c (mi_load_progress): Likewise.
5050
5051 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5052
5053         * NEWS: Combine separate "New targets" sections for 8.3.
5054
5055 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5056
5057         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5058         (ppcfbsd_init_abi): Install gdbarch
5059         "fetch_tls_load_module_address" and "get_thread_local_address"
5060         methods.
5061
5062 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5063
5064         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5065         (riscv_fbsd_init_abi): Install gdbarch
5066         "fetch_tls_load_module_address" and "get_thread_local_address"
5067         methods.
5068
5069 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5070
5071         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5072         (i386fbsd_init_abi): Install gdbarch
5073         "fetch_tls_load_module_address" and "get_thread_local_address"
5074         methods.
5075
5076 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5077
5078         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5079         (amd64fbsd_init_abi): Install gdbarch
5080         "fetch_tls_load_module_address" and "get_thread_local_address"
5081         methods.
5082
5083 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5084
5085         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5086         (struct fbsd_pspace_data): New type.
5087         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5088         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5089         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5090         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5091         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5092
5093 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5094
5095         * gdbtypes.c (lookup_struct_elt): New function.
5096         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5097         * gdbtypes.h (struct struct_elt): New type.
5098         (lookup_struct_elt): New prototype.
5099
5100 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5101
5102         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5103         remove disabled code block.
5104
5105 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5106
5107         * gdbarch.sh (get_thread_local_address): New method.
5108         * gdbarch.h, gdbarch.c: Regenerate.
5109         * target.c (target_translate_tls_address): Use
5110         gdbarch_get_thread_local_address if present instead of
5111         target::get_thread_local_address.
5112
5113 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5114
5115         * target.h (target::get_thread_local_address): Update comment.
5116
5117 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5118
5119         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5120         objfile->separate_debug_objfile_backlink if not NULL.
5121
5122 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5123
5124         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5125         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5126         (amd64bsd_store_inferior_registers): Likewise.
5127         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5128         Enable segment base registers.
5129         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5130         PT_GETFSBASE and PT_GETGSBASE.
5131         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5132         PT_SETGSBASE.
5133         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5134         segment base registers.
5135         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5136
5137 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5138
5139         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5140         Update calls to i386_target_description to add 'segments'
5141         parameter.
5142         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5143         add segment base registers.
5144         * arch/i386.c (i386_create_target_description): Add 'segments'
5145         parameter to enable segment base registers.
5146         * arch/i386.h (i386_create_target_description): Likewise.
5147         * features/i386/32bit-segments.xml: New file.
5148         * features/i386/32bit-segments.c: Generate.
5149         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5150         call to i386_target_description to add 'segments' parameter.
5151         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5152         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5153         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5154         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5155         if feature is present.
5156         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5157         Add 'segments' parameter to call to i386_target_description.
5158         (i386_target_description): Add 'segments' parameter to enable
5159         segment base registers.
5160         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5161         to call to i386_target_description.
5162         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5163         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5164         Define I386_NUM_REGS.
5165         (i386_target_description): Add 'segments' parameter to enable
5166         segment base registers.
5167
5168 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5169
5170         PR/24325
5171         * source-cache.c: #undef open and close, to avoid unresolved
5172         externals during linking.
5173
5174 2019-03-12  Tom Tromey  <tromey@adacore.com>
5175
5176         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5177         const.  Add initializers.
5178         (_initialize_remote): Don't initialize ptid globals.
5179
5180 2019-03-12  Pedro Alves  <palves@redhat.com>
5181
5182         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5183
5184 2019-03-12  Pedro Alves  <palves@redhat.com>
5185
5186         * cp-name-parser.y (main): Remove unused 'len' variable.
5187
5188 2019-03-12  Tom Tromey  <tromey@adacore.com>
5189
5190         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5191         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5192
5193 2019-03-12  Tom Tromey  <tromey@adacore.com>
5194
5195         * linux-nat.c (iterate_over_lwps): Update.
5196         (stop_callback): Remove parameter.
5197         (stop_wait_callback, detach_callback, resume_set_callback)
5198         (select_singlestep_lwp_callback, set_ignore_sigint)
5199         (status_callback, resumed_callback, resume_clear_callback)
5200         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5201         data parameter.
5202         (linux_nat_target::detach, linux_nat_target::resume)
5203         (linux_stop_and_wait_all_lwps, select_event_lwp)
5204         (linux_nat_filter_event, linux_nat_wait_1)
5205         (linux_nat_target::kill, linux_nat_target::stop)
5206         (linux_nat_target::stop): Update.
5207         (linux_nat_resume_callback): Change type.
5208         (resume_stopped_resumed_lwps, count_events_callback)
5209         (select_event_lwp_callback): Likewise.
5210         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5211         * arm-linux-nat.c (struct update_registers_data): Remove.
5212         (update_registers_callback): Change type.
5213         (arm_linux_insert_hw_breakpoint1): Update.
5214         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5215         parameter.
5216         (x86_linux_dr_set_addr): Update.
5217         (x86_linux_dr_set_control): Update.
5218         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5219         (iterate_over_lwps): Use gdb::function_view.
5220         * nat/aarch64-linux-hw-point.c (struct
5221         aarch64_dr_update_callback_param): Remove.
5222         (debug_reg_change_callback): Change type.
5223         (aarch64_notify_debug_reg_change): Update.
5224         * s390-linux-nat.c (s390_refresh_per_info): Update.
5225
5226 2019-03-11  Tom Tromey  <tromey@adacore.com>
5227
5228         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5229         redundant assignment to "this_cu".
5230
5231 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5232
5233         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5234
5235 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5236
5237         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5238         from...
5239         (rank_one_type): ... this.
5240
5241 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5242
5243         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5244         from...
5245         (rank_one_type): ... this.
5246
5247 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5248
5249         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5250         from...
5251         (rank_one_type): ... this.
5252
5253 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5254
5255         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5256         from...
5257         (rank_one_type): ... this.
5258
5259 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5260
5261         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5262         from...
5263         (rank_one_type): ... this.
5264
5265 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5266
5267         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5268         from...
5269         (rank_one_type): ... this.
5270
5271 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5272
5273         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5274         from...
5275         (rank_one_type): ... this.
5276
5277 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5278
5279         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5280         from...
5281         (rank_one_type): ... this.
5282
5283 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5284
5285         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5286         from...
5287         (rank_one_type): ... this.
5288
5289 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5290
5291         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5292         from...
5293         (rank_one_type): ... this.
5294
5295 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5296
5297         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5298         from...
5299         (rank_one_type): ... this.
5300
5301 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5302
5303         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5304         from...
5305         (rank_one_type): ... this.
5306
5307 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5308
5309         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5310         inferior-events' shows the example events.
5311
5312 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5313
5314         Support styling on native MS-Windows console
5315
5316         PR/24315
5317         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5318         on MS-Windows if $TERM is not defined.
5319
5320         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5321
5322         * posix-hdep.c (gdb_console_fputs):
5323         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5324         functions.
5325         * ui-file.h (gdb_console_fputs): Add prototype.
5326
5327         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5328         back to fputs only if the former returns zero.
5329
5330 2019-03-07  Tom Tromey  <tom@tromey.com>
5331
5332         * symmisc.c (print_symbol_bcache_statistics): Update.
5333         (print_objfile_statistics): Update.
5334         * symfile.c (allocate_symtab): Update.
5335         * stabsread.c: Don't include bcache.h.
5336         * psymtab.h (struct psymbol_bcache): Don't declare.
5337         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5338         (psymbol_bcache_init, psymbol_bcache_free)
5339         (psymbol_bcache_get_bcache): Don't declare.
5340         * psymtab.c (struct psymbol_bcache): Remove.
5341         (psymtab_storage::psymtab_storage): Update.
5342         (psymtab_storage::~psymtab_storage): Update.
5343         (psymbol_bcache_init, psymbol_bcache_free)
5344         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5345         (add_psymbol_to_bcache): Update.
5346         (allocate_psymtab): Update.
5347         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5348         macro_cache>: No longer pointers.
5349         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5350         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5351         * macrotab.c (macro_bcache): Update.
5352         * macroexp.c: Don't include bcache.h.
5353         * gdbtypes.c (check_types_worklist): Update.
5354         (types_deeply_equal): Remove TRY/CATCH.  Update.
5355         * elfread.c (elf_symtab_read): Update.
5356         * dwarf2read.c: Don't include bcache.h.
5357         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5358         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5359         (print_bcache_statistics, bcache_memory_used): Don't declare.
5360         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5361         methods.  Rename all data members.
5362         * bcache.c (struct bcache): Move to bcache.h.
5363         (bcache::expand_hash_table): Rename from expand_hash_table.
5364         (bcache): Remove.
5365         (bcache::insert): Rename from bcache_full.
5366         (bcache::compare): Rename from bcache_compare.
5367         (bcache_xmalloc): Remove.
5368         (bcache::~bcache): Rename from bcache_xfree.
5369         (bcache::print_statistics): Rename from print_bcache_statistics.
5370         (bcache::memory_used): Rename from bcache_memory_used.
5371
5372 2019-03-07  Pedro Alves  <palves@redhat.com>
5373
5374         * infrun.c (normal_stop): Also check for
5375         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5376
5377 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5378
5379         * f-lang.c (value_from_host_double): Moved to...
5380         * value.c (value_from_host_double): ...here.
5381         * value.h (value_from_host_double): Declare.
5382         * guile/scm-math.c (vlscm_convert_typed_number): Use
5383         value_from_host_double.
5384         (vlscm_convert_number): Likewise.
5385         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5386         * python/py-value.c (convert_value_from_python): Likewise.
5387
5388 2019-03-06  Tom Tromey  <tom@tromey.com>
5389
5390         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5391
5392 2019-03-06  Tom Tromey  <tom@tromey.com>
5393
5394         * utils.h (free_current_contents): Don't declare.
5395         * utils.c (free_current_contents): Remove.
5396
5397 2019-03-06  Tom Tromey  <tom@tromey.com>
5398
5399         * top.c (quit_force): Update.
5400         * main.c (captured_command_loop): Update.
5401         * common/new-op.c (operator new): Update.
5402         * common/common-exceptions.c (struct catcher)
5403         <save_cleanup_chain>: Remove member.
5404         (exceptions_state_mc_init): Update.
5405         (exception_try_scope_entry): Return nullptr.
5406         (exception_try_scope_exit, exception_rethrow)
5407         (throw_exception_sjlj, throw_exception_cxx): Update.
5408         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5409         (all_cleanups, do_cleanups, discard_cleanups)
5410         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5411         (restore_cleanups, restore_final_cleanups): Don't declare.
5412         (do_final_cleanups): Remove parameter.
5413         * common/cleanups.c (cleanup_chain, make_cleanup)
5414         (make_cleanup_dtor, all_cleanups, do_cleanups)
5415         (discard_my_cleanups, discard_cleanups)
5416         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5417         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5418         (null_cleanup): Remove.
5419         (do_final_cleanups): Remove parameter.
5420
5421 2019-03-06  Tom Tromey  <tom@tromey.com>
5422
5423         * remote.c (remote_target::remote_parse_stop_reply): Use
5424         unique_xmalloc_ptr.
5425
5426 2019-03-06  Tom Tromey  <tom@tromey.com>
5427
5428         * stabsread.c (struct stabs_field_info): Rename from field_info.
5429         <list, fnlist>: Add initializers.
5430         <obstack>: New member.
5431         (read_member_functions, read_struct_fields, read_baseclasses):
5432         Allocate on obstack.  Don't use cleanups.
5433         (read_one_struct_field, read_member_functions, read_struct_fields)
5434         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5435         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5436         (read_struct_type): Update.
5437
5438 2019-03-06  Tom Tromey  <tom@tromey.com>
5439
5440         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5441         * common/filestuff.h (make_cleanup_close): Don't declare.
5442         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5443         Remove.
5444
5445 2019-03-06  Tom Tromey  <tom@tromey.com>
5446
5447         * solib-aix.c: Use make_scope_exit.
5448
5449 2019-03-06  Tom Tromey  <tom@tromey.com>
5450
5451         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5452         Use make_scope_exit.
5453
5454 2019-03-06  Tom Tromey  <tom@tromey.com>
5455
5456         * solib-svr4.c (disable_probes_interface): Remove parameter.
5457         (svr4_handle_solib_event): Use make_scope_exit.
5458
5459 2019-03-06  Tom Tromey  <tom@tromey.com>
5460
5461         * remote.c (struct stop_reply_deleter): Remove.
5462         (stop_reply_up): Update.
5463         (struct stop_reply): Derive from notif_event.  Don't typedef.
5464         <regcache>: Now a std::vector.
5465         (stop_reply_xfree): Remove.
5466         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5467         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5468         (remote_target::discard_pending_stop_replies): Use delete.
5469         (remote_target::remote_parse_stop_reply): Update.
5470         (remote_target::process_stop_reply): Update.
5471         * remote-notif.h (struct notif_event): Add virtual destructor.
5472         Remove "dtr" member.
5473         (struct notif_client) <alloc_event>: Return a unique_ptr.
5474         (notif_event_xfree): Don't declare.
5475         (notif_event_up): New typedef.
5476         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5477         (notif_event_xfree, do_notif_event_xfree): Remove.
5478         (remote_notif_state_xfree): Update.
5479
5480 2019-03-06  Tom Tromey  <tom@tromey.com>
5481
5482         * infrun.c (displaced_step_clear_cleanup): Now a
5483         forward_scope_exit type.
5484         (displaced_step_prepare_throw): Update.
5485         (displaced_step_fixup): Update.
5486
5487 2019-03-06  Tom Tromey  <tom@tromey.com>
5488
5489         * inferior.h (class inferior): Update comment.
5490         * gdbthread.h (class thread_info): Update comment.
5491
5492 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5493             Tom Tromey  <tom@tromey.com>
5494
5495         * stabsread.h (struct stab_section_list): Remove.
5496         (coffstab_build_psymtabs): Update.
5497         * dbxread.c (symbuf_sections): Now a std::vector.
5498         (sect_idx): New global.
5499         (fill_symbuf): Update.
5500         (coffstab_build_psymtabs): Change type of stabsects parameter.
5501         Update.
5502         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5503         std::vector.
5504         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5505         (coff_locate_sections): Update.
5506         (coff_symfile_read): Remove cleanups.  Update.
5507         (init_stringtab): Add storage parameter.
5508         (free_stringtab, free_stringtab_cleanup): Remove.
5509         (init_lineno): Add storage parameter.
5510         (free_linetab, free_linetab_cleanup): Remove.
5511
5512 2019-03-06  Pedro Alves  <palves@redhat.com>
5513
5514         * linux-fork.c (fork_info::clobber_regs): Delete.
5515         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5516         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5517         comment.  Adjust.
5518         (scoped_switch_fork_info::scoped_switch_fork_info)
5519         (checkpoint_command, linux_fork_context): Adjust
5520         fork_save_infrun_state calls.
5521
5522 2019-03-06  Pedro Alves  <palves@redhat.com>
5523
5524         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5525         (inf_has_multiple_threads): Return 'bool' and rewrite using
5526         inferior_info::threads().
5527
5528 2019-03-06  Pedro Alves  <palves@redhat.com>
5529
5530         * linux-fork.c: Include <list>.
5531         (fork_list): Now a std::list instance.
5532         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5533         (forks_exist_p, find_last_fork): Adjust.
5534         (new_fork): Delete.
5535         (one_fork_p): New.
5536         (add_fork): Adjust.
5537         (free_fork): Delete, folded into fork_info::~fork_info().
5538         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5539         Adjust.
5540         (init_fork_list): Delete.
5541         (linux_fork_killall, linux_fork_mourn_inferior)
5542         (linux_fork_detach, info_checkpoints_command): Adjust.
5543         (_initialize_linux_fork): No longer call init_fork_list.
5544
5545 2019-03-06  Pedro Alves  <palves@redhat.com>
5546
5547         * linux-fork.c (new_fork): New, split out of ...
5548         (add_fork): ... this.  Return void.  Move "first fork" special
5549         case from here, to ...
5550         (checkpoint_command): ... here.
5551         * linux-linux.h (add_fork): Return void.
5552
5553 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5554
5555         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5556
5557 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5558             Chris January  <chris.january@arm.com>
5559             David Lecomber  <david.lecomber@arm.com>
5560
5561         * f-exp.y: New token, UNOP_INTRINSIC.
5562         (exp): New pattern using UNOP_INTRINSIC token.
5563         (f77_keywords): Add 'abs' keyword.
5564         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5565         (value_from_host_double): New function.
5566         (evaluate_subexp_f): Support UNOP_ABS.
5567
5568 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5569
5570         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5571         types.
5572
5573 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5574
5575         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5576         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5577         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5578
5579 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5580
5581         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5582
5583 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5584             Chris January  <chris.january@arm.com>
5585
5586         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5587         * f-exp.y: Define 'KIND' token.
5588         (exp): New pattern for KIND expressions.
5589         (ptype): Handle types with a kind extension.
5590         (direct_abs_decl): Extend to spot kind extensions.
5591         (f77_keywords): Add 'kind' to the list.
5592         (push_kind_type): New function.
5593         (convert_to_kind_type): New function.
5594         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5595         * parse.c (operator_length_standard): Likewise.
5596         * parser-defs.h (enum type_pieces): Add tp_kind.
5597         * std-operator.def: Add UNOP_KIND.
5598
5599 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5600
5601         * f-exp.y (f_parse): Set yydebug.
5602
5603 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5604
5605         * f-lang.c (evaluate_subexp_f): New function.
5606         (exp_descriptor_f): New global.
5607         (f_language_defn): Use exp_descriptor_f instead of
5608         exp_descriptor_standard.
5609
5610 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5611
5612         * f-exp.y (struct token): Add comments.
5613         (dot_ops): Remove uppercase versions and the end marker.
5614         (f77_keywords): Likewise.
5615         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5616         entries in the dot_ops array are case insensitive, and use
5617         strncasecmp to compare strings.  Also some whitespace cleanup in
5618         this area.  Similar for the f77_keywords array, except entries in
5619         this list might be case sensitive.
5620
5621 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5622
5623         * f-exp.y (struct f77_boolean_val): Add comments.
5624         (boolean_values): Remove uppercase versions, and end marker.
5625         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5626         and use strncasecmp to achieve case insensitivity.  Additionally,
5627         perform whitespace cleanup around this code.
5628
5629 2019-03-06  Tom Tromey  <tromey@adacore.com>
5630
5631         * remote-sim.c (gdbsim_target_open): Use result of
5632         gdb_argv::release.
5633
5634 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5635         Dirk Schubert  <dirk.schubert@arm.com>
5636         Chris January  <chris.january@arm.com>
5637
5638         * eval.c (evaluate_subexp_standard): Call Fortran argument
5639         wrapping logic.
5640         * f-lang.c (struct value): A value which can be passed into a
5641         Fortran function call.
5642         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5643         where appropriate.
5644         (struct type): Value ready for a Fortran function call.
5645         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5646         is needed.
5647         * f-lang.h (fortran_argument_convert): Declaration.
5648         (fortran_preserve_arg_pointer): Declaration.
5649         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5650
5651 2019-03-05  Tom Tromey  <tromey@adacore.com>
5652
5653         * python/py-prettyprint.c (print_string_repr): Remove #if.
5654         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5655
5656 2019-03-05  Tom Tromey  <tromey@adacore.com>
5657
5658         * target.c (the_dummy_target): Move later.  Change type to
5659         "dummy_target".
5660         (initialize_targets): Don't initialize the_dummy_target.
5661
5662 2019-03-05  Tom Tromey  <tromey@adacore.com>
5663
5664         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5665         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5666
5667 2019-03-05  Tom Tromey  <tromey@adacore.com>
5668
5669         * windows-nat.c (windows_nat_target::attach)
5670         (windows_nat_target::detach): Don't call gdb_flush.
5671         * valprint.c (generic_val_print, val_print, val_print_string):
5672         Don't call gdb_flush.
5673         * utils.c (defaulted_query): Don't call gdb_flush.
5674         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5675         * target.c (target_announce_detach): Don't call gdb_flush.
5676         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5677         * remote.c (extended_remote_target::attach): Don't call
5678         gdb_flush.
5679         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5680         * printcmd.c (do_examine): Don't call gdb_flush.
5681         (info_display_command): Don't call gdb_flush.
5682         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5683         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5684         * memattr.c (info_mem_command): Don't call gdb_flush.
5685         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5686         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5687         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5688         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5689         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5690         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5691         (gnu_nat_target::detach): Don't call gdb_flush.
5692         * f-valprint.c (f_val_print): Don't call gdb_flush.
5693         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5694         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5695         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5696         gdb_flush.
5697         * c-valprint.c (c_val_print): Don't call gdb_flush.
5698         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5699
5700 2019-03-05  Tom Tromey  <tromey@adacore.com>
5701
5702         * varobj.c (update_dynamic_varobj_children): Update.
5703         (install_default_visualizer): Use reset, not release.
5704         * value.c (set_internalvar): Update.
5705         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5706         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5707         ATTRIBUTE_UNUSED_RESULT.
5708
5709 2019-03-05  Tom Tromey  <tromey@adacore.com>
5710
5711         * remote.c (class scoped_remote_fd) <release>: Add
5712         ATTRIBUTE_UNUSED_RESULT.
5713
5714 2019-03-05  Tom Tromey  <tromey@adacore.com>
5715
5716         * macroexp.c (struct macro_buffer) <release>: Add
5717         ATTRIBUTE_UNUSED_RESULT.
5718
5719 2019-03-05  Tom Tromey  <tromey@adacore.com>
5720
5721         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5722         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5723         ATTRIBUTE_UNUSED_RESULT.
5724
5725 2019-03-05  Tom Tromey  <tromey@adacore.com>
5726
5727         * common/scoped_fd.h (class scoped_fd) <release>: Add
5728         ATTRIBUTE_UNUSED_RESULT.
5729
5730 2019-03-05  Tom Tromey  <tromey@adacore.com>
5731
5732         * parser-defs.h (struct parser_state) <release>: Add
5733         ATTRIBUTE_UNUSED_RESULT.
5734
5735 2019-03-05  Tom Tromey  <tromey@adacore.com>
5736
5737         * utils.h (class gdb_argv) <release>: Add
5738         ATTRIBUTE_UNUSED_RESULT.
5739         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5740
5741 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5742
5743         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5744         for-loop range, to avoid compiler warnings.
5745
5746         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5747         avoid compiler warnings about unused variables.
5748
5749         * NEWS: Mention end of support for native debugging on MS-Windows
5750         before XP.
5751
5752         PR gdb/24292
5753         * common/netstuff.c:
5754         * gdbserver/gdbreplay.c
5755         * gdbserver/remote-utils.c:
5756         * ser-tcp.c:
5757         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5758         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5759         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5760         'getaddrinfo' and 'freeaddrinfo' were not available before
5761         Windows XP, and mingw.org's MinGW headers by default define
5762         _WIN32_WINNT to 0x500.
5763
5764 2019-03-01  Gary Benson <gbenson@redhat.com>
5765
5766         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5767
5768 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5769             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5770
5771         PR gdb/8527
5772         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5773         set_sigint_trap, clear_sigint_trap.
5774
5775 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5776
5777         * target.c (target_detach): Clear the regcache and the
5778         frame cache.
5779
5780 2019-02-27  Pedro Alves  <palves@redhat.com>
5781
5782         * utils.c (set_screen_size): When we cap the height/width sizes,
5783         tweak the corresponding command variable to show "unlimited":
5784
5785 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5786             Pedro Alves  <palves@redhat.com>
5787
5788         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5789         before calling rl_set_screen_size.
5790
5791 2019-02-27  Tom Tromey  <tromey@adacore.com>
5792
5793         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5794         define.
5795         * python/py-value.c: Remove Python 2.4 workaround.
5796         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5797         workaround.
5798         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5799         Python 2.4 workaround.
5800         * python/python-internal.h: Remove Python 2.4 comment.
5801         (Py_ssize_t): Don't define.
5802         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5803         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5804         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5805         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5806         * python/python.c (do_start_initialization): Remove Python 2.4
5807         workaround.
5808         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5809         (print_children): Remove Python 2.4 workaround.
5810         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5811         workaround.
5812         (CHARBUFFERPROC_NAME): Remove.
5813         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5814         Python 2.4 workaround.
5815
5816 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5817
5818         * NEWS: Note minimum Python version.
5819
5820 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5821
5822         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5823         code from these functions.  Remove corresponding ifdefs.  Use
5824         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5825         Remove gotos and target of gotos.
5826         (infpy_search_memory): Likewise.
5827
5828 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5829
5830         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5831         (hppa_gdbarch_init): Don't register deleted functions with
5832         gdbarch.
5833
5834 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5835
5836         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5837         (h8300_unwind_sp): Delete.
5838         (h8300_dummy_id): Delete.
5839         (h8300_gdbarch_init): Don't register deleted functions with
5840         gdbarch.
5841
5842 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5843
5844         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5845         (ft32_unwind_pc): Delete.
5846         (ft32_unwind_sp): Delete.
5847         (ft32_gdbarch_init): Don't register deleted functions with
5848         gdbarch.
5849
5850 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5851
5852         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5853         (frv_unwind_pc): Delete.
5854         (frv_unwind_sp): Delete.
5855         (frv_gdbarch_init): Don't register deleted functions with
5856         gdbarch.
5857
5858 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5859
5860         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5861         (riscv_unwind_pc): Delete.
5862         (riscv_unwind_sp): Delete.
5863         (riscv_gdbarch_init): Don't register deleted functions with
5864         gdbarch.
5865
5866 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5867
5868         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5869         (csky_unwind_pc): Delete.
5870         (csky_unwind_sp): Delete.
5871         (csky_gdbarch_init): Don't register deleted functions with
5872         gdbarch.
5873
5874 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5875
5876         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5877         (cris_unwind_pc): Delete.
5878         (cris_unwind_sp): Delete.
5879         (cris_gdbarch_init): Don't register deleted functions with
5880         gdbarch.
5881
5882 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5883
5884         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5885         (bfin_unwind_pc): Delete.
5886         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5887
5888 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5889
5890         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5891         (arm_unwind_pc): Delete.
5892         (arm_unwind_sp): Delete.
5893         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5894
5895 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5896
5897         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5898         (arc_unwind_pc): Delete.
5899         (arc_unwind_sp): Delete.
5900         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5901
5902 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5903
5904         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5905         (alpha_unwind_pc): Delete.
5906         (alpha_gdbarch_init): Don't register deleted functions with
5907         gdbarch.
5908
5909 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5910
5911         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5912         (aarch64_unwind_pc): Delete.
5913         (aarch64_unwind_sp): Delete.
5914         (aarch64_gdbarch_init): Don't register deleted functions with
5915         gdbarch.
5916
5917 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5918
5919         * gdbtypes.c (type_align): Don't consider static members when
5920         computing structure alignment.
5921
5922 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5923
5924         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5925         return 0 for other types.
5926         * arch-utils.c (default_type_align): Always return 0.
5927         * gdbarch.h: Regenerate.
5928         * gdbarch.sh (type_align): Extend comment.
5929         * gdbtypes.c (type_align): Add additional comments, always call
5930         gdbarch_type_align before applying the default rules.
5931         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5932         generic code will then apply a suitable default.
5933         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5934         types, return 0 for other types.
5935
5936 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5937
5938         * NEWS: Create a new section for the next release branch.
5939         Rename the section of the current branch, now that it has
5940         been cut.
5941
5942 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5943
5944         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5945         * version.in: Bump version to 8.3.50.DATE-git.
5946
5947 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5948
5949         * aix-thread.c (ptid_cmp): Remove unused variable.
5950         (get_signaled_thread): Likewise.
5951         (store_regs_user_thread): Likewise.
5952         (store_regs_kernel_thread): Likewise.
5953         (fetch_regs_kernel_thread): Remove shadowed variable.
5954
5955 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5956
5957         * features/riscv/32bit-cpu.xml: Add register numbers.
5958         * features/riscv/32bit-fpu.c: Regenerate.
5959         * features/riscv/32bit-fpu.xml: Add register numbers.
5960         * features/riscv/64bit-cpu.xml: Add register numbers.
5961         * features/riscv/64bit-fpu.c: Regenerate.
5962         * features/riscv/64bit-fpu.xml: Add register numbers.
5963
5964 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5965
5966         * NEWS: Mention two argument form of gdb.Value constructor.
5967         * python/py-value.c (convert_buffer_and_type_to_value): New
5968         function.
5969         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5970         Add support for handling an optional second argument.  Call
5971         convert_buffer_and_type_to_value as appropriate.
5972         * python/python-internal.h (Py_buffer_deleter): New struct.
5973         (Py_buffer_up): New typedef.
5974
5975 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5976
5977         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5978         instead of releasing ownership.
5979
5980 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5981
5982         * dwarf2read.c (open_and_init_dwp_file): Call
5983         elf_numsections instead of bfd_count_sections to initialize
5984         dwp_file->num_sections.
5985
5986 2019-02-25  Tom Tromey  <tromey@adacore.com>
5987
5988         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5989
5990 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5991
5992         * gcore.in: Add '--readnever' option when invoking GDB.
5993
5994 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5995
5996         * MAINTAINERS: Update my email address.
5997
5998 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5999
6000         * build-id.c (build_id_to_debug_bfd_1): New function.
6001         (build_id_to_debug_bfd): Look for separate debug file in
6002         sysroot.
6003
6004 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6005
6006         * gdbarch.sh: Update the copyright year range that is placed into
6007         generated files.
6008
6009 2019-02-22  Keith Seitz  <keiths@redhat.com>
6010
6011         PR symtab/23853
6012         * linespec.c (create_sals_line_offset): Search for the default
6013         symtab's filename instead of its fullname.
6014
6015 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6016
6017         * NEWS: Update style defaults.
6018
6019 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6020
6021         * main.c (captured_main_1): Disable styling in batch mode.
6022
6023 2019-02-20  Tom Tromey  <tom@tromey.com>
6024
6025         * symtab.c (symtab_symbol_info): Fix typos.
6026
6027 2019-02-20  Tom Tromey  <tromey@adacore.com>
6028
6029         * findcmd.c (_initialize_mem_search): Use upper case for
6030         metasyntactic variables.
6031
6032 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6033
6034         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6035         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6036
6037 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6038
6039         * top.h (source_file_name): Change to std::string.
6040         * top.c (source_file_name): Likewise.
6041         (command_line_input): Adjust.
6042         * cli/cli-script.c (script_from_file): Adjust.
6043
6044 2019-02-19  Tom Tromey  <tromey@adacore.com>
6045
6046         * ravenscar-thread.c
6047         (ravenscar_thread_target::update_thread_list): Don't call
6048         ada_build_task_list.
6049         * ada-lang.h (ada_build_task_list): Don't declare.
6050         * ada-tasks.c (struct ada_tasks_inferior_data)
6051         <task_list_valid_p>: Now bool.
6052         (read_known_tasks, ada_task_list_changed)
6053         (ada_tasks_invalidate_inferior_data): Update.
6054         (read_known_tasks_array): Return bool.
6055         (read_known_tasks_list): Likewise.
6056         (read_known_tasks): Return void.
6057         (ada_build_task_list): Now static.
6058
6059 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6060
6061         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6062         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6063
6064 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6065
6066         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6067         variant for ada_tasks_pspace_data_handle and
6068         ada_tasks_inferior_data_handle.
6069         (ada_tasks_pspace_data_cleanup): New function.
6070         (ada_tasks_inferior_data_cleanup): New function.
6071
6072 2019-02-17  Tom Tromey  <tom@tromey.com>
6073
6074         * macrotab.h (macro_source_fullname): Return a std::string.
6075         * macrotab.c (macro_include, check_for_redefinition)
6076         (macro_undef, macro_lookup_definition, foreach_macro)
6077         (foreach_macro_in_scope): Update.
6078         (macro_source_fullname): Return a std::string.
6079         * macrocmd.c (show_pp_source_pos): Update.
6080
6081 2019-02-17  Tom Tromey  <tom@tromey.com>
6082
6083         * macrocmd.c (show_pp_source_pos): Style the file names.
6084
6085 2019-02-17  Tom Tromey  <tom@tromey.com>
6086
6087         PR tui/24197:
6088         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6089
6090 2019-02-17  Tom Tromey  <tom@tromey.com>
6091
6092         * ada-lang.c (user_select_syms): Use filtered printing.
6093         * utils.c (wrap_style): New global.
6094         (desired_style): Remove.
6095         (emit_style_escape): Add stream parameter.
6096         (set_output_style, reset_terminal_style, prompt_for_continue):
6097         Update.
6098         (flush_wrap_buffer): Only flush gdb_stdout.
6099         (wrap_here): Set wrap_style.
6100         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6101         treat escape sequences as a character.  Change when wrap buffer is
6102         flushed.
6103         (fputs_styled): Do not set the output style when the default is
6104         requested.
6105         * ui-style.h (struct ui_file_style) <is_default>: New method.
6106         * source.c (print_source_lines_base): Emit escape sequences in one
6107         piece.
6108
6109 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6110
6111         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6112         integers and enumeration types.
6113
6114 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6115
6116         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6117         instead of lookup_symbol_in_language
6118         (do_exact_match): New function.
6119         (ada_get_symbol_name_matcher): Return do_exact_match when
6120         doing a verbatim match.
6121
6122 2019-02-15  Tom Tromey  <tromey@adacore.com>
6123
6124         * ravenscar-thread.c (ravenscar_thread_target::resume)
6125         (ravenscar_thread_target::wait): Special case wildcard requests.
6126
6127 2019-02-15  Tom Tromey  <tromey@adacore.com>
6128
6129         * ravenscar-thread.c (base_ptid): Remove.
6130         (struct ravenscar_thread_target) <close>: New method.
6131         <m_base_ptid>: New member.
6132         <update_inferior_ptid, active_task, task_is_currently_active,
6133         runtime_initialized>: Declare methods.
6134         <ravenscar_thread_target>: Add constructor.
6135         (ravenscar_thread_target::task_is_currently_active)
6136         (ravenscar_thread_target::update_inferior_ptid)
6137         (ravenscar_runtime_initialized): Rename.  Now methods.
6138         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6139         (ravenscar_thread_target::update_thread_list): Update.
6140         (ravenscar_thread_target::active_task): Now method.
6141         (ravenscar_thread_target::store_registers)
6142         (ravenscar_thread_target::prepare_to_store)
6143         (ravenscar_thread_target::prepare_to_store)
6144         (ravenscar_thread_target::mourn_inferior): Update.
6145         (ravenscar_inferior_created): Use "new" to create target.
6146         (ravenscar_thread_target::get_ada_task_ptid): Update.
6147         (_initialize_ravenscar): Don't initialize base_ptid.
6148         (ravenscar_ops): Remove global.
6149
6150 2019-02-15  Tom Tromey  <tromey@adacore.com>
6151
6152         * target.h (push_target): Declare new overload.
6153         * target.c (push_target): New overload, taking an rvalue reference.
6154         * remote.c (remote_target::open_1): Use push_target overload.
6155         * corelow.c (core_target_open): Use push_target overload.
6156
6157 2019-02-15  Tom Tromey  <tromey@adacore.com>
6158
6159         * ravenscar-thread.c (is_ravenscar_task)
6160         (ravenscar_task_is_currently_active): Return bool.
6161         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6162         (_initialize_ravenscar): Remove "(void)".
6163         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6164         Return bool.
6165
6166 2019-02-15  Tom Tromey  <tromey@adacore.com>
6167
6168         * ravenscar-thread.c (ravenscar_runtime_initializer)
6169         (has_ravenscar_runtime, get_running_thread_id)
6170         (ravenscar_thread_target::resume): Fix indentation.
6171
6172 2019-02-15  Tom Tromey  <tromey@adacore.com>
6173
6174         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6175         from ravenscar_arch_ops.
6176         (sparc_ravenscar_ops::fetch_registers)
6177         (sparc_ravenscar_ops::store_registers): Now methods.
6178         (sparc_ravenscar_prepare_to_store): Remove.
6179         (sparc_ravenscar_ops): Redefine.
6180         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6181         methods and destructor.  Remove members.
6182         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6183         (ravenscar_thread_target::store_registers)
6184         (ravenscar_thread_target::prepare_to_store): Update.
6185         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6186         Remove.
6187         (struct ppc_ravenscar_powerpc_ops): Derive from
6188         ravenscar_arch_ops.
6189         (ppc_ravenscar_powerpc_ops::fetch_registers)
6190         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6191         (ppc_ravenscar_powerpc_ops): Redefine.
6192         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6193         (ppc_ravenscar_e500_ops::fetch_registers)
6194         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6195         (ppc_ravenscar_e500_ops): Redefine.
6196         * aarch64-ravenscar-thread.c
6197         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6198         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6199         (aarch64_ravenscar_fetch_registers)
6200         (aarch64_ravenscar_store_registers): Now methods.
6201         (aarch64_ravenscar_ops): Redefine.
6202
6203 2019-02-15  Tom Tromey  <tromey@adacore.com>
6204
6205         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6206         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6207         (ravenscar_thread_target::stopped_by_watchpoint)
6208         (ravenscar_thread_target::stopped_data_address)
6209         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6210
6211 2019-02-15  Tom Tromey  <tromey@adacore.com>
6212
6213         * ravenscar-thread.c: Fix some typos.
6214
6215 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6216             Tom Tromey  <tromey@adacore.com>
6217
6218         * ada-lang.c (ada_exception_sal): Change addr_string to a
6219         std::string.
6220         (create_ada_exception_catchpoint): Update.
6221
6222 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6223             Tom Tromey  <tromey@adacore.com>
6224
6225         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6226         (bp_location_ops): Remove.
6227         (base_breakpoint_allocate_location): Update.
6228         (free_bp_location): Update.
6229         * ada-lang.c (class ada_catchpoint_location)
6230         <ada_catchpoint_location>: Remove ops parameter.
6231         (ada_catchpoint_location_dtor): Remove.
6232         (ada_catchpoint_location_ops): Remove.
6233         (allocate_location_exception): Update.
6234         * breakpoint.h (struct bp_location_ops): Remove.
6235         (class bp_location) <bp_location>: Remove bp_location_ops
6236         parameter.
6237         <~bp_location>: Add destructor.
6238         <ops>: Remove.
6239
6240 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6241             Pedro Alves  <palves@redhat.com>
6242
6243         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6244         'PATH_MAX'.
6245
6246 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6247             Samuel Thibault  <samuel.thibault@gnu.org>
6248             Thomas Schwinge  <thomas@codesourcery.com>
6249
6250         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6251         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6252
6253 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6254
6255         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6256         (check_empty): Use "const char *".
6257
6258         * gnu-nat.c (gnu_nat_target::detach): Instead of
6259         'detach_inferior (pid)' call
6260         'detach_inferior (find_inferior_pid (pid))'.
6261
6262         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6263         'nat/fork-inferior.o'.
6264         * gnu-nat.c: #include "nat/fork-inferior.h".
6265
6266         * gnu-nat.c (gnu_nat_target::detach): Instead of
6267         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6268         * gnu-nat.h: #include "inf-child.h".
6269         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6270         'i386_gnu_nat_target::fetch_registers'.
6271         (gnu_store_registers): Rename/move to
6272         'i386_gnu_nat_target::store_registers'.
6273
6274         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6275         * gnu-nat.h (mach_thread_info): New function.
6276         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6277
6278         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6279
6280 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6281
6282         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6283
6284 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6285
6286         * windows-nat.c (windows_add_thread): Add new parameter
6287         "main_thread_p" with default value set to false.  Update
6288         function documentation as well as all callers.
6289         (windows_delete_thread): Likewise.
6290         (fake_create_process): Update call to windows_add_thread.
6291         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6292         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6293         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6294         call to windows_delete_thread.
6295
6296 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6297
6298         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6299
6300 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6301
6302         * symfile.c (find_separate_debug_file): Use canonical path of
6303         sysroot with child_path instead of gdb_sysroot if it is valid.
6304
6305 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6306
6307         * symfile.c (find_separate_debug_file): Use child_path to
6308         determine if an object file is under a sysroot.
6309
6310 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6311
6312         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6313         unittests/child-path-selftests.c.
6314         * common/pathstuff.c (child_path): New function.
6315         * common/pathstuff.h (child_path): New prototype.
6316         * unittests/child-path-selftests.c: New file.
6317
6318 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6319
6320         * symfile.c (find_separate_debug_file): Look for separate debug
6321         files in debug directories under the sysroot.
6322
6323 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6324
6325         * symtab.h (struct minimal_symbol data_p): New const method.
6326         (struct minimal_symbol text_p): Likewise.
6327         * symtab.c (output_source_filename): Use file name style
6328         to print file name.
6329         (print_symbol_info): Likewise.
6330         (print_msymbol_info): Use address style to print addresses.
6331         Use function name style to print executable text symbols.
6332         (expand_symtab_containing_pc): Use data_p.
6333         (find_pc_sect_compunit_symtab): Likewise.
6334
6335 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6336
6337         * breakpoint.c (describe_other_breakpoints): Use address style
6338         to print addresses.
6339         (say_where): Likewise.
6340
6341 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6342
6343         * ada-typeprint.c (print_func_type): Print function name
6344         style to print function name.
6345         * c-typeprint.c (c_print_type_1): Likewise.
6346
6347 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6348
6349         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6350         for execve.
6351
6352 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6353
6354         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6355         type_stack.
6356
6357 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6358
6359         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6360         TYPE_CODE_REF types.
6361
6362 2019-02-08  Jim Wilson  <jimw@sifive.com>
6363
6364         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6365         (riscv_linux_fregset): New.
6366         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6367
6368 2019-02-07  Tom Tromey  <tom@tromey.com>
6369
6370         * thread.c (thread_cancel_execution_command): Update.
6371         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6372         methods.
6373         (struct thread_fsm_ops): Remove.
6374         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6375         (thread_fsm_should_stop, thread_fsm_return_value)
6376         (thread_fsm_set_finished, thread_fsm_finished_p)
6377         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6378         Don't declare.
6379         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6380         * infrun.c (clear_proceed_status_thread)
6381         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6382         (print_stop_event): Update.
6383         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6384         Add constructor.
6385         (step_command_fsm_ops): Remove.
6386         (new_step_command_fsm): Remove.
6387         (step_1): Update.
6388         (step_command_fsm::should_stop): Rename from
6389         step_command_fsm_should_stop.
6390         (step_command_fsm::clean_up): Rename from
6391         step_command_fsm_clean_up.
6392         (step_command_fsm::do_async_reply_reason): Rename from
6393         step_command_fsm_async_reply_reason.
6394         (struct until_next_fsm): Inherit from thread_fsm.  Add
6395         constructor.
6396         (until_next_fsm_ops): Remove.
6397         (new_until_next_fsm): Remove.
6398         (until_next_fsm::should_stop): Rename from
6399         until_next_fsm_should_stop.
6400         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6401         (until_next_fsm::do_async_reply_reason): Rename from
6402         until_next_fsm_async_reply_reason.
6403         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6404         constructor.  Change type of breakpoint.
6405         (finish_command_fsm_ops): Remove.
6406         (new_finish_command_fsm): Remove.
6407         (finish_command_fsm::should_stop): Rename from
6408         finish_command_fsm_should_stop.
6409         (finish_command_fsm::clean_up): Rename from
6410         finish_command_fsm_clean_up.
6411         (finish_command_fsm::return_value): Rename from
6412         finish_command_fsm_return_value.
6413         (finish_command_fsm::do_async_reply_reason): Rename from
6414         finish_command_fsm_async_reply_reason.
6415         (finish_command): Update.
6416         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6417         Add constructor.
6418         (call_thread_fsm_ops): Remove.
6419         (call_thread_fsm::call_thread_fsm): Rename from
6420         new_call_thread_fsm.
6421         (call_thread_fsm::should_stop): Rename from
6422         call_thread_fsm_should_stop.
6423         (call_thread_fsm::should_notify_stop): Rename from
6424         call_thread_fsm_should_notify_stop.
6425         (run_inferior_call, call_function_by_hand_dummy): Update.
6426         * cli/cli-interp.c (should_print_stop_to_console): Update.
6427         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6428         Add constructor.  Change type of location_breakpoint,
6429         caller_breakpoint.
6430         (until_break_fsm_ops): Remove.
6431         (new_until_break_fsm): Remove.
6432         (until_break_fsm::should_stop): Rename from
6433         until_break_fsm_should_stop.
6434         (until_break_fsm::clean_up): Rename from
6435         until_break_fsm_clean_up.
6436         (until_break_fsm::do_async_reply_reason): Rename from
6437         until_break_fsm_async_reply_reason.
6438         (until_break_command): Update.
6439         * thread-fsm.c: Remove.
6440         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6441
6442 2019-02-07  Tom Tromey  <tom@tromey.com>
6443
6444         * yy-remap.h: Add include guard.
6445         * xtensa-tdep.h: Add include guard.
6446         * xcoffread.h: Rename include guard.
6447         * varobj-iter.h: Add include guard.
6448         * tui/tui.h: Rename include guard.
6449         * tui/tui-winsource.h: Rename include guard.
6450         * tui/tui-wingeneral.h: Rename include guard.
6451         * tui/tui-windata.h: Rename include guard.
6452         * tui/tui-win.h: Rename include guard.
6453         * tui/tui-stack.h: Rename include guard.
6454         * tui/tui-source.h: Rename include guard.
6455         * tui/tui-regs.h: Rename include guard.
6456         * tui/tui-out.h: Rename include guard.
6457         * tui/tui-layout.h: Rename include guard.
6458         * tui/tui-io.h: Rename include guard.
6459         * tui/tui-hooks.h: Rename include guard.
6460         * tui/tui-file.h: Rename include guard.
6461         * tui/tui-disasm.h: Rename include guard.
6462         * tui/tui-data.h: Rename include guard.
6463         * tui/tui-command.h: Rename include guard.
6464         * tic6x-tdep.h: Add include guard.
6465         * target/waitstatus.h: Rename include guard.
6466         * target/wait.h: Rename include guard.
6467         * target/target.h: Rename include guard.
6468         * target/resume.h: Rename include guard.
6469         * target-float.h: Rename include guard.
6470         * stabsread.h: Add include guard.
6471         * rs6000-tdep.h: Add include guard.
6472         * riscv-fbsd-tdep.h: Add include guard.
6473         * regformats/regdef.h: Rename include guard.
6474         * record.h: Rename include guard.
6475         * python/python.h: Rename include guard.
6476         * python/python-internal.h: Rename include guard.
6477         * python/py-stopevent.h: Rename include guard.
6478         * python/py-ref.h: Rename include guard.
6479         * python/py-record.h: Rename include guard.
6480         * python/py-record-full.h: Rename include guard.
6481         * python/py-record-btrace.h: Rename include guard.
6482         * python/py-instruction.h: Rename include guard.
6483         * python/py-events.h: Rename include guard.
6484         * python/py-event.h: Rename include guard.
6485         * procfs.h: Add include guard.
6486         * proc-utils.h: Add include guard.
6487         * p-lang.h: Add include guard.
6488         * or1k-tdep.h: Rename include guard.
6489         * observable.h: Rename include guard.
6490         * nto-tdep.h: Rename include guard.
6491         * nat/x86-linux.h: Rename include guard.
6492         * nat/x86-linux-dregs.h: Rename include guard.
6493         * nat/x86-gcc-cpuid.h: Add include guard.
6494         * nat/x86-dregs.h: Rename include guard.
6495         * nat/x86-cpuid.h: Rename include guard.
6496         * nat/ppc-linux.h: Rename include guard.
6497         * nat/mips-linux-watch.h: Rename include guard.
6498         * nat/linux-waitpid.h: Rename include guard.
6499         * nat/linux-ptrace.h: Rename include guard.
6500         * nat/linux-procfs.h: Rename include guard.
6501         * nat/linux-osdata.h: Rename include guard.
6502         * nat/linux-nat.h: Rename include guard.
6503         * nat/linux-namespaces.h: Rename include guard.
6504         * nat/linux-btrace.h: Rename include guard.
6505         * nat/glibc_thread_db.h: Rename include guard.
6506         * nat/gdb_thread_db.h: Rename include guard.
6507         * nat/gdb_ptrace.h: Rename include guard.
6508         * nat/fork-inferior.h: Rename include guard.
6509         * nat/amd64-linux-siginfo.h: Rename include guard.
6510         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6511         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6512         * nat/aarch64-linux.h: Rename include guard.
6513         * nat/aarch64-linux-hw-point.h: Rename include guard.
6514         * mn10300-tdep.h: Add include guard.
6515         * mips-linux-tdep.h: Add include guard.
6516         * mi/mi-parse.h: Rename include guard.
6517         * mi/mi-out.h: Rename include guard.
6518         * mi/mi-main.h: Rename include guard.
6519         * mi/mi-interp.h: Rename include guard.
6520         * mi/mi-getopt.h: Rename include guard.
6521         * mi/mi-console.h: Rename include guard.
6522         * mi/mi-common.h: Rename include guard.
6523         * mi/mi-cmds.h: Rename include guard.
6524         * mi/mi-cmd-break.h: Rename include guard.
6525         * m2-lang.h: Add include guard.
6526         * location.h: Rename include guard.
6527         * linux-record.h: Rename include guard.
6528         * linux-nat.h: Add include guard.
6529         * linux-fork.h: Add include guard.
6530         * i386-darwin-tdep.h: Rename include guard.
6531         * hppa-linux-offsets.h: Add include guard.
6532         * guile/guile.h: Rename include guard.
6533         * guile/guile-internal.h: Rename include guard.
6534         * gnu-nat.h: Rename include guard.
6535         * gdb-stabs.h: Rename include guard.
6536         * frv-tdep.h: Add include guard.
6537         * f-lang.h: Add include guard.
6538         * event-loop.h: Add include guard.
6539         * darwin-nat.h: Rename include guard.
6540         * cp-abi.h: Rename include guard.
6541         * config/sparc/nm-sol2.h: Rename include guard.
6542         * config/nm-nto.h: Rename include guard.
6543         * config/nm-linux.h: Add include guard.
6544         * config/i386/nm-i386gnu.h: Rename include guard.
6545         * config/djgpp/nl_types.h: Rename include guard.
6546         * config/djgpp/langinfo.h: Rename include guard.
6547         * compile/gcc-cp-plugin.h: Add include guard.
6548         * compile/gcc-c-plugin.h: Add include guard.
6549         * compile/compile.h: Rename include guard.
6550         * compile/compile-object-run.h: Rename include guard.
6551         * compile/compile-object-load.h: Rename include guard.
6552         * compile/compile-internal.h: Rename include guard.
6553         * compile/compile-cplus.h: Rename include guard.
6554         * compile/compile-c.h: Rename include guard.
6555         * common/xml-utils.h: Rename include guard.
6556         * common/x86-xstate.h: Rename include guard.
6557         * common/version.h: Rename include guard.
6558         * common/vec.h: Rename include guard.
6559         * common/tdesc.h: Rename include guard.
6560         * common/selftest.h: Rename include guard.
6561         * common/scoped_restore.h: Rename include guard.
6562         * common/scoped_mmap.h: Rename include guard.
6563         * common/scoped_fd.h: Rename include guard.
6564         * common/safe-iterator.h: Rename include guard.
6565         * common/run-time-clock.h: Rename include guard.
6566         * common/refcounted-object.h: Rename include guard.
6567         * common/queue.h: Rename include guard.
6568         * common/ptid.h: Rename include guard.
6569         * common/print-utils.h: Rename include guard.
6570         * common/preprocessor.h: Rename include guard.
6571         * common/pathstuff.h: Rename include guard.
6572         * common/observable.h: Rename include guard.
6573         * common/netstuff.h: Rename include guard.
6574         * common/job-control.h: Rename include guard.
6575         * common/host-defs.h: Rename include guard.
6576         * common/gdb_wait.h: Rename include guard.
6577         * common/gdb_vecs.h: Rename include guard.
6578         * common/gdb_unlinker.h: Rename include guard.
6579         * common/gdb_unique_ptr.h: Rename include guard.
6580         * common/gdb_tilde_expand.h: Rename include guard.
6581         * common/gdb_sys_time.h: Rename include guard.
6582         * common/gdb_string_view.h: Rename include guard.
6583         * common/gdb_splay_tree.h: Rename include guard.
6584         * common/gdb_setjmp.h: Rename include guard.
6585         * common/gdb_ref_ptr.h: Rename include guard.
6586         * common/gdb_optional.h: Rename include guard.
6587         * common/gdb_locale.h: Rename include guard.
6588         * common/gdb_assert.h: Rename include guard.
6589         * common/filtered-iterator.h: Rename include guard.
6590         * common/filestuff.h: Rename include guard.
6591         * common/fileio.h: Rename include guard.
6592         * common/environ.h: Rename include guard.
6593         * common/common-utils.h: Rename include guard.
6594         * common/common-types.h: Rename include guard.
6595         * common/common-regcache.h: Rename include guard.
6596         * common/common-inferior.h: Rename include guard.
6597         * common/common-gdbthread.h: Rename include guard.
6598         * common/common-exceptions.h: Rename include guard.
6599         * common/common-defs.h: Rename include guard.
6600         * common/common-debug.h: Rename include guard.
6601         * common/cleanups.h: Rename include guard.
6602         * common/buffer.h: Rename include guard.
6603         * common/btrace-common.h: Rename include guard.
6604         * common/break-common.h: Rename include guard.
6605         * cli/cli-utils.h: Rename include guard.
6606         * cli/cli-style.h: Rename include guard.
6607         * cli/cli-setshow.h: Rename include guard.
6608         * cli/cli-script.h: Rename include guard.
6609         * cli/cli-interp.h: Rename include guard.
6610         * cli/cli-decode.h: Rename include guard.
6611         * cli/cli-cmds.h: Rename include guard.
6612         * charset-list.h: Add include guard.
6613         * buildsym-legacy.h: Rename include guard.
6614         * bfin-tdep.h: Add include guard.
6615         * ax.h: Rename include guard.
6616         * arm-linux-tdep.h: Add include guard.
6617         * arm-fbsd-tdep.h: Add include guard.
6618         * arch/xtensa.h: Rename include guard.
6619         * arch/tic6x.h: Add include guard.
6620         * arch/i386.h: Add include guard.
6621         * arch/arm.h: Rename include guard.
6622         * arch/arm-linux.h: Rename include guard.
6623         * arch/arm-get-next-pcs.h: Rename include guard.
6624         * arch/amd64.h: Add include guard.
6625         * arch/aarch64-insn.h: Rename include guard.
6626         * arch-utils.h: Rename include guard.
6627         * annotate.h: Add include guard.
6628         * amd64-darwin-tdep.h: Rename include guard.
6629         * aarch64-linux-tdep.h: Add include guard.
6630         * aarch64-fbsd-tdep.h: Add include guard.
6631         * aarch32-linux-nat.h: Add include guard.
6632
6633 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6634
6635         * macrotab.c (macro_define_internal): New function that
6636         factorizes macro_define_object_internal and macro_define_function
6637         code.
6638         (macro_define_object_internal): Use macro_define_internal.
6639         (macro_define_function): Likewise.
6640
6641 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6642
6643         * macrocmd.c (extract_identifier): Return
6644         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6645         callers.
6646
6647 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6648
6649         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6650
6651 2019-02-05  Tom Tromey  <tom@tromey.com>
6652
6653         * target.c (target_stack::unpush): Move assertion earlier.
6654
6655 2019-01-30  Tom Tromey  <tom@tromey.com>
6656
6657         PR python/23615:
6658         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6659         (gdbpy_parse_and_eval): Likewise.
6660         * python/python-internal.h (gdbpy_allow_threads): New class.
6661
6662 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6663
6664         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6665         (aarch64_fbsd_fpregmap): Move earlier.
6666         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6667         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6668         instead of individual calls to trad_frame_set_reg_addr.
6669         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6670         earlier.
6671         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6672         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6673         instead of individual calls to trad_frame_set_reg_addr.
6674
6675 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6676
6677         * CONTRIBUTE: Replace contribution list with wiki link.
6678
6679 2019-01-25  Tom Tromey  <tom@tromey.com>
6680
6681         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6682
6683 2019-01-25  Tom Tromey  <tom@tromey.com>
6684
6685         * xtensa-linux-nat.c: Fix common/ includes.
6686         * xml-support.h: Fix common/ includes.
6687         * xml-support.c: Fix common/ includes.
6688         * x86-linux-nat.c: Fix common/ includes.
6689         * windows-nat.c: Fix common/ includes.
6690         * varobj.h: Fix common/ includes.
6691         * varobj.c: Fix common/ includes.
6692         * value.c: Fix common/ includes.
6693         * valops.c: Fix common/ includes.
6694         * utils.c: Fix common/ includes.
6695         * unittests/xml-utils-selftests.c: Fix common/ includes.
6696         * unittests/utils-selftests.c: Fix common/ includes.
6697         * unittests/unpack-selftests.c: Fix common/ includes.
6698         * unittests/tracepoint-selftests.c: Fix common/ includes.
6699         * unittests/style-selftests.c: Fix common/ includes.
6700         * unittests/string_view-selftests.c: Fix common/ includes.
6701         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6702         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6703         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6704         * unittests/rsp-low-selftests.c: Fix common/ includes.
6705         * unittests/parse-connection-spec-selftests.c: Fix common/
6706         includes.
6707         * unittests/optional-selftests.c: Fix common/ includes.
6708         * unittests/offset-type-selftests.c: Fix common/ includes.
6709         * unittests/observable-selftests.c: Fix common/ includes.
6710         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6711         * unittests/memrange-selftests.c: Fix common/ includes.
6712         * unittests/memory-map-selftests.c: Fix common/ includes.
6713         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6714         * unittests/function-view-selftests.c: Fix common/ includes.
6715         * unittests/environ-selftests.c: Fix common/ includes.
6716         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6717         * unittests/common-utils-selftests.c: Fix common/ includes.
6718         * unittests/cli-utils-selftests.c: Fix common/ includes.
6719         * unittests/array-view-selftests.c: Fix common/ includes.
6720         * ui-file.c: Fix common/ includes.
6721         * tui/tui-io.c: Fix common/ includes.
6722         * tracepoint.h: Fix common/ includes.
6723         * tracepoint.c: Fix common/ includes.
6724         * tracefile-tfile.c: Fix common/ includes.
6725         * top.h: Fix common/ includes.
6726         * top.c: Fix common/ includes.
6727         * thread.c: Fix common/ includes.
6728         * target/waitstatus.h: Fix common/ includes.
6729         * target/waitstatus.c: Fix common/ includes.
6730         * target.h: Fix common/ includes.
6731         * target.c: Fix common/ includes.
6732         * target-memory.c: Fix common/ includes.
6733         * target-descriptions.c: Fix common/ includes.
6734         * symtab.h: Fix common/ includes.
6735         * symfile.c: Fix common/ includes.
6736         * stap-probe.c: Fix common/ includes.
6737         * spu-linux-nat.c: Fix common/ includes.
6738         * sparc-nat.c: Fix common/ includes.
6739         * source.c: Fix common/ includes.
6740         * solib.c: Fix common/ includes.
6741         * solib-target.c: Fix common/ includes.
6742         * ser-unix.c: Fix common/ includes.
6743         * ser-tcp.c: Fix common/ includes.
6744         * ser-pipe.c: Fix common/ includes.
6745         * ser-base.c: Fix common/ includes.
6746         * selftest-arch.c: Fix common/ includes.
6747         * s12z-tdep.c: Fix common/ includes.
6748         * rust-exp.y: Fix common/ includes.
6749         * rs6000-aix-tdep.c: Fix common/ includes.
6750         * riscv-tdep.c: Fix common/ includes.
6751         * remote.c: Fix common/ includes.
6752         * remote-notif.h: Fix common/ includes.
6753         * remote-fileio.h: Fix common/ includes.
6754         * remote-fileio.c: Fix common/ includes.
6755         * regcache.h: Fix common/ includes.
6756         * regcache.c: Fix common/ includes.
6757         * record-btrace.c: Fix common/ includes.
6758         * python/python.c: Fix common/ includes.
6759         * python/py-type.c: Fix common/ includes.
6760         * python/py-inferior.c: Fix common/ includes.
6761         * progspace.h: Fix common/ includes.
6762         * producer.c: Fix common/ includes.
6763         * procfs.c: Fix common/ includes.
6764         * proc-api.c: Fix common/ includes.
6765         * printcmd.c: Fix common/ includes.
6766         * ppc-linux-nat.c: Fix common/ includes.
6767         * parser-defs.h: Fix common/ includes.
6768         * osdata.c: Fix common/ includes.
6769         * obsd-nat.c: Fix common/ includes.
6770         * nat/x86-linux.c: Fix common/ includes.
6771         * nat/x86-linux-dregs.c: Fix common/ includes.
6772         * nat/x86-dregs.h: Fix common/ includes.
6773         * nat/x86-dregs.c: Fix common/ includes.
6774         * nat/ppc-linux.c: Fix common/ includes.
6775         * nat/mips-linux-watch.h: Fix common/ includes.
6776         * nat/mips-linux-watch.c: Fix common/ includes.
6777         * nat/linux-waitpid.c: Fix common/ includes.
6778         * nat/linux-ptrace.h: Fix common/ includes.
6779         * nat/linux-ptrace.c: Fix common/ includes.
6780         * nat/linux-procfs.c: Fix common/ includes.
6781         * nat/linux-personality.c: Fix common/ includes.
6782         * nat/linux-osdata.c: Fix common/ includes.
6783         * nat/linux-namespaces.c: Fix common/ includes.
6784         * nat/linux-btrace.h: Fix common/ includes.
6785         * nat/linux-btrace.c: Fix common/ includes.
6786         * nat/fork-inferior.c: Fix common/ includes.
6787         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6788         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6789         * nat/aarch64-linux.c: Fix common/ includes.
6790         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6791         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6792         * namespace.h: Fix common/ includes.
6793         * mips-linux-tdep.c: Fix common/ includes.
6794         * minsyms.c: Fix common/ includes.
6795         * mi/mi-parse.h: Fix common/ includes.
6796         * mi/mi-main.c: Fix common/ includes.
6797         * mi/mi-cmd-env.c: Fix common/ includes.
6798         * memrange.h: Fix common/ includes.
6799         * memattr.c: Fix common/ includes.
6800         * maint.h: Fix common/ includes.
6801         * maint.c: Fix common/ includes.
6802         * main.c: Fix common/ includes.
6803         * machoread.c: Fix common/ includes.
6804         * location.c: Fix common/ includes.
6805         * linux-thread-db.c: Fix common/ includes.
6806         * linux-nat.c: Fix common/ includes.
6807         * linux-fork.c: Fix common/ includes.
6808         * inline-frame.c: Fix common/ includes.
6809         * infrun.c: Fix common/ includes.
6810         * inflow.c: Fix common/ includes.
6811         * inferior.h: Fix common/ includes.
6812         * inferior.c: Fix common/ includes.
6813         * infcmd.c: Fix common/ includes.
6814         * inf-ptrace.c: Fix common/ includes.
6815         * inf-child.c: Fix common/ includes.
6816         * ia64-linux-nat.c: Fix common/ includes.
6817         * i387-tdep.c: Fix common/ includes.
6818         * i386-tdep.c: Fix common/ includes.
6819         * i386-linux-tdep.c: Fix common/ includes.
6820         * i386-linux-nat.c: Fix common/ includes.
6821         * i386-go32-tdep.c: Fix common/ includes.
6822         * i386-fbsd-tdep.c: Fix common/ includes.
6823         * i386-fbsd-nat.c: Fix common/ includes.
6824         * guile/scm-type.c: Fix common/ includes.
6825         * guile/guile.c: Fix common/ includes.
6826         * go32-nat.c: Fix common/ includes.
6827         * gnu-nat.c: Fix common/ includes.
6828         * gdbthread.h: Fix common/ includes.
6829         * gdbarch-selftests.c: Fix common/ includes.
6830         * gdb_usleep.c: Fix common/ includes.
6831         * gdb_select.h: Fix common/ includes.
6832         * gdb_bfd.c: Fix common/ includes.
6833         * gcore.c: Fix common/ includes.
6834         * fork-child.c: Fix common/ includes.
6835         * findvar.c: Fix common/ includes.
6836         * fbsd-nat.c: Fix common/ includes.
6837         * event-top.c: Fix common/ includes.
6838         * event-loop.c: Fix common/ includes.
6839         * dwarf2read.c: Fix common/ includes.
6840         * dwarf2loc.c: Fix common/ includes.
6841         * dwarf2-frame.c: Fix common/ includes.
6842         * dwarf-index-cache.c: Fix common/ includes.
6843         * dtrace-probe.c: Fix common/ includes.
6844         * disasm-selftests.c: Fix common/ includes.
6845         * defs.h: Fix common/ includes.
6846         * csky-tdep.c: Fix common/ includes.
6847         * cp-valprint.c: Fix common/ includes.
6848         * cp-support.h: Fix common/ includes.
6849         * cp-support.c: Fix common/ includes.
6850         * corelow.c: Fix common/ includes.
6851         * completer.h: Fix common/ includes.
6852         * completer.c: Fix common/ includes.
6853         * compile/compile.c: Fix common/ includes.
6854         * compile/compile-loc2c.c: Fix common/ includes.
6855         * compile/compile-cplus-types.c: Fix common/ includes.
6856         * compile/compile-cplus-symbols.c: Fix common/ includes.
6857         * command.h: Fix common/ includes.
6858         * cli/cli-dump.c: Fix common/ includes.
6859         * cli/cli-cmds.c: Fix common/ includes.
6860         * charset.c: Fix common/ includes.
6861         * build-id.c: Fix common/ includes.
6862         * btrace.h: Fix common/ includes.
6863         * btrace.c: Fix common/ includes.
6864         * breakpoint.h: Fix common/ includes.
6865         * breakpoint.c: Fix common/ includes.
6866         * ax.h:
6867         (enum agent_op): Fix common/ includes.
6868         * ax-general.c (struct aop_map): Fix common/ includes.
6869         * ax-gdb.c: Fix common/ includes.
6870         * auxv.c: Fix common/ includes.
6871         * auto-load.c: Fix common/ includes.
6872         * arm-tdep.c: Fix common/ includes.
6873         * arch/riscv.c: Fix common/ includes.
6874         * arch/ppc-linux-common.c: Fix common/ includes.
6875         * arch/i386.c: Fix common/ includes.
6876         * arch/arm.c: Fix common/ includes.
6877         * arch/arm-linux.c: Fix common/ includes.
6878         * arch/arm-get-next-pcs.c: Fix common/ includes.
6879         * arch/amd64.c: Fix common/ includes.
6880         * arch/aarch64.c: Fix common/ includes.
6881         * arch/aarch64-insn.c: Fix common/ includes.
6882         * arch-utils.c: Fix common/ includes.
6883         * amd64-windows-tdep.c: Fix common/ includes.
6884         * amd64-tdep.c: Fix common/ includes.
6885         * amd64-sol2-tdep.c: Fix common/ includes.
6886         * amd64-obsd-tdep.c: Fix common/ includes.
6887         * amd64-nbsd-tdep.c: Fix common/ includes.
6888         * amd64-linux-tdep.c: Fix common/ includes.
6889         * amd64-linux-nat.c: Fix common/ includes.
6890         * amd64-fbsd-tdep.c: Fix common/ includes.
6891         * amd64-fbsd-nat.c: Fix common/ includes.
6892         * amd64-dicos-tdep.c: Fix common/ includes.
6893         * amd64-darwin-tdep.c: Fix common/ includes.
6894         * agent.c: Fix common/ includes.
6895         * ada-lang.h: Fix common/ includes.
6896         * ada-lang.c: Fix common/ includes.
6897         * aarch64-tdep.c: Fix common/ includes.
6898
6899 2019-01-25  Tom Tromey  <tom@tromey.com>
6900
6901         * common/create-version.sh: Use common/version.h.
6902
6903 2019-01-24  Pedro Alves  <palves@redhat.com>
6904
6905         * infrun.c (signal_stop, signal_print, signal_program)
6906         (signal_catch, signal_pass): Now arrays instead of pointers.
6907         (update_signals_program_target, do_target_resume)
6908         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6909         * linux-nat.c (linux_nat_target::pass_signals)
6910         (linux_nat_target::create_inferior, linux_nat_target::attach):
6911         Adjust.
6912         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6913         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6914         * procfs.c (procfs_target::pass_signals): Adjust.
6915         * record-full.c (record_full_target::resume): Adjust.
6916         * remote.c (remote_target::pass_signals)
6917         (remote_target::program_signals): Adjust.
6918         * target-debug.h (target_debug_print_signals): Now takes a
6919         gdb::array_view as parameter.  Adjust.
6920         * target.h (target_ops) <pass_signals, program_signals>: Replace
6921         pointer and length parameters with gdb::array_view.
6922         (target_pass_signals, target_program_signals): Likewise.
6923         * target-delegates.c: Regenerate.
6924
6925 2019-01-24  Pedro Alves  <palves@redhat.com>
6926
6927         * common/forward-scope-exit.h
6928         (forward_scope_exit::forward_scope_exit): Pass arguments to
6929         m_bind_function directly, instead of creating a std::bind and
6930         copying that.
6931
6932 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6933
6934         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6935         for static members.
6936         (pass_in_v_vfp_candidate): Likewise.
6937
6938 2019-01-23  Tom Tromey  <tom@tromey.com>
6939             Pedro Alves  <palves@redhat.com>
6940
6941         * regcache.c (class regcache_invalidator): Remove.
6942         (regcache::raw_write): Use make_scope_exit.
6943
6944 2019-01-23  Tom Tromey  <tom@tromey.com>
6945
6946         * ui-out.h (class ui_out_emit_type): Update comment.
6947
6948 2019-01-23  Tom Tromey  <tom@tromey.com>
6949
6950         * infrun.c (fetch_inferior_event): Update comment.
6951
6952 2019-01-23  Tom Tromey  <tom@tromey.com>
6953             Pedro Alves  <palves@redhat.com>
6954
6955         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6956         parameter.
6957         (fetch_inferior_event): Use SCOPE_EXIT.
6958
6959
6960 2019-01-23  Tom Tromey  <tom@tromey.com>
6961             Pedro Alves  <palves@redhat.com>
6962
6963         * infrun.c (disable_thread_events): Delete.
6964         (stop_all_threads): Use SCOPE_EXIT.
6965
6966 2019-01-23  Tom Tromey  <tom@tromey.com>
6967             Pedro Alves  <palves@redhat.com>
6968
6969         * symfile.c: Include forward-scope-exit.h.
6970         (clear_symtab_users_cleanup): Replace forward declaration with
6971         a FORWARD_SCOPE_EXIT.
6972         (syms_from_objfile_1): Use the forward_scope_exit and
6973         gdb::optional instead of cleanup_function.
6974         (reread_symbols): Use the forward_scope_exit instead of
6975         cleanup_function.
6976         (clear_symtab_users_cleanup): Remove function.
6977
6978 2019-01-23  Tom Tromey  <tom@tromey.com>
6979             Pedro Alves  <palves@redhat.com>
6980
6981         * linux-nat.c: Include scope-exit.h.
6982         (cleanup_target_stop): Remove.
6983         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6984         SCOPE_EXIT.
6985
6986 2019-01-23  Tom Tromey  <tom@tromey.com>
6987             Pedro Alves  <palves@redhat.com>
6988
6989         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6990         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6991
6992 2019-01-23  Tom Tromey  <tom@tromey.com>
6993             Andrew Burgess  <andrew.burgess@embecosm.com>
6994             Pedro Alves  <palves@redhat.com>
6995
6996         * infrun.c (fetch_inferior_event): Use scope_exit.
6997         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6998         * top.c (execute_command): Use scope_exit.
6999         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7000         * utils.c (do_bpstat_clear_actions_cleanup)
7001         (make_bpstat_clear_actions_cleanup): Remove.
7002
7003 2019-01-23  Tom Tromey  <tom@tromey.com>
7004             Pedro Alves  <palves@redhat.com>
7005
7006         * infrun.c: Include "common/scope-exit.h"
7007         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7008         (wait_for_inferior): Use SCOPE_EXIT.
7009         (fetch_inferior_event): Use scope_exit.
7010
7011 2019-01-23  Tom Tromey  <tom@tromey.com>
7012             Pedro Alves  <palves@redhat.com>
7013
7014         * breakpoint.c (create_breakpoint): Remove cleanup.
7015
7016 2019-01-23  Tom Tromey  <tom@tromey.com>
7017             Andrew Burgess  <andrew.burgess@embecosm.com>
7018             Pedro Alves  <palves@redhat.com>
7019
7020 2019-01-23  Pedro Alves  <palves@redhat.com>
7021
7022         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7023
7024 2019-01-23  Pedro Alves  <palves@redhat.com>
7025             Andrew Burgess  <andrew.burgess@embecosm.com>
7026
7027         * gdbthread.h: Include "common/forward-scope-exit.h".
7028         (scoped_finish_thread_state): Redefine custom class in terms of
7029         forward_scope_exit.
7030
7031 2019-01-23  Pedro Alves  <palves@redhat.com>
7032             Andrew Burgess  <andrew.burgess@embecosm.com>
7033
7034         * common/forward-scope-exit.h: New file.
7035
7036 2019-01-23  Pedro Alves  <palves@redhat.com>
7037             Andrew Burgess  <andrew.burgess@embecosm.com>
7038             Tom Tromey  <tom@tromey.com>
7039
7040         * common/scope-exit.h: New file.
7041
7042 2019-01-23  Pedro Alves  <palves@redhat.com>
7043
7044         * common/preprocessor.h (ESC): Rename to ...
7045         (ESC_PARENS): ... this.
7046         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7047         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7048
7049 2019-01-23  Tom Tromey  <tom@tromey.com>
7050
7051         * language.h (class scoped_switch_to_sym_language_if_auto):
7052         Initialize m_lang in both cases.
7053
7054 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7055
7056         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7057         with XCNEW.
7058
7059 2019-01-22  Tom Tromey  <tom@tromey.com>
7060
7061         * corelow.c: Do not include sys/file.h.
7062
7063 2019-01-22  Tom Tromey  <tom@tromey.com>
7064
7065         * tui/tui-wingeneral.h: Include gdb_curses.h.
7066
7067 2019-01-22  Tom Tromey  <tom@tromey.com>
7068
7069         * source-cache.h (class source_cache) <get_source_lines,
7070         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7071
7072 2019-01-22  Tom Tromey  <tom@tromey.com>
7073
7074         * remote-fileio.h (struct remote_target): Declare.
7075
7076 2019-01-22  Tom Tromey  <tom@tromey.com>
7077
7078         * python/py-arch.c: Do not include py-ref.h.
7079         * python/py-bpevent.c: Do not include py-ref.h.
7080         * python/py-cmd.c: Do not include py-ref.h.
7081         * python/py-continueevent.c: Do not include py-ref.h.
7082         * python/py-event.h: Do not include py-ref.h.
7083         * python/py-evtregistry.c: Do not include py-ref.h.
7084         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7085         * python/py-frame.c: Do not include py-ref.h.
7086         * python/py-framefilter.c: Do not include py-ref.h.
7087         * python/py-function.c: Do not include py-ref.h.
7088         * python/py-infevents.c: Do not include py-ref.h.
7089         * python/py-linetable.c: Do not include py-ref.h.
7090         * python/py-objfile.c: Do not include py-ref.h.
7091         * python/py-param.c: Do not include py-ref.h.
7092         * python/py-prettyprint.c: Do not include py-ref.h.
7093         * python/py-progspace.c: Do not include py-ref.h.
7094         * python/py-symbol.c: Do not include py-ref.h.
7095         * python/py-symtab.c: Do not include py-ref.h.
7096         * python/py-type.c: Do not include py-ref.h.
7097         * python/py-unwind.c: Do not include py-ref.h.
7098         * python/py-utils.c: Do not include py-ref.h.
7099         * python/py-value.c: Do not include py-ref.h.
7100         * python/py-varobj.c: Do not include py-ref.h.
7101         * python/py-xmethods.c: Do not include py-ref.h.
7102         * python/python.c: Do not include py-ref.h.
7103         * varobj.c: Do not include py-ref.h.
7104
7105 2019-01-22  Tom Tromey  <tom@tromey.com>
7106
7107         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7108         keyword for bcache.
7109
7110 2019-01-22  Tom Tromey  <tom@tromey.com>
7111
7112         * compile/compile-cplus-types.c: Remove a comment by #include.
7113
7114 2019-01-22  Tom Tromey  <tom@tromey.com>
7115
7116         * compile/gcc-c-plugin.h: Include compile-internal.h.
7117
7118 2019-01-22  Tom Tromey  <tom@tromey.com>
7119
7120         * stabsread.c (EXTERN): Do not define.
7121         (symnum, next_symbol_text_func, processing_gcc_compilation)
7122         (within_function, global_sym_chain, global_stabs)
7123         (previous_stab_code, this_object_header_files)
7124         (n_this_object_header_files)
7125         (n_allocated_this_object_header_files): Define.
7126         * stabsread.h (EXTERN): Never define.  Use "extern".
7127
7128 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7129
7130         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7131         history_value.
7132
7133 2019-01-21  Tom Tromey  <tom@tromey.com>
7134
7135         * ui-out.c: Fix includes.
7136         * tui/tui-source.c: Fix includes.
7137         * target.c: Fix includes.
7138         * remote.c: Fix includes.
7139         * regcache.c: Fix includes.
7140         * python/py-block.c: Fix includes.
7141         * printcmd.c: Fix includes.
7142         * or1k-tdep.c: Fix includes.
7143         * mi/mi-main.c: Fix includes.
7144         * m32r-tdep.c: Fix includes.
7145         * csky-tdep.c: Fix includes.
7146         * compile/compile-cplus-types.c: Fix includes.
7147         * cli/cli-interp.c: Fix includes.
7148
7149 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7150
7151         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7152         for padding.
7153
7154 2019-01-16  Tom Tromey  <tom@tromey.com>
7155
7156         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7157         earlier.
7158         (struct objfile) <msymbols_range>: Move from top level.
7159         <msymbols>: New method.
7160         (class objfile_msymbols): Remove.
7161         * symtab.c (default_collect_symbol_completion_matches_break_on):
7162         Update.
7163         * symmisc.c (dump_msymbols): Update.
7164         * stabsread.c (scan_file_globals): Update.
7165         * objc-lang.c (info_selectors_command, info_classes_command)
7166         (find_methods): Update.
7167         * minsyms.c (find_solib_trampoline_target): Update.
7168         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7169         * coffread.c (coff_symfile_read): Update.
7170         * ada-lang.c (ada_lookup_simple_minsym)
7171         (ada_collect_symbol_completion_matches): Update.
7172
7173 2019-01-16  Tom Tromey  <tom@tromey.com>
7174
7175         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7176         type.  Remove no-argument constructor.
7177         <iterator::operator++>: Simplify.
7178         <begin>: Update.
7179         <end>: Use minimal_symbol_count.
7180
7181 2019-01-16  Tom Tromey  <tom@tromey.com>
7182
7183         * objfiles.h (struct objfile) <psymtabs>: New method.
7184         (class objfile_psymtabs): Remove.
7185         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7186         typedef.
7187         <range>: New method.
7188         (require_partial_symbols): Change return type.
7189         * psymtab.c (require_partial_symbols)
7190         (psym_expand_symtabs_matching): Update.
7191         * mdebugread.c (parse_partial_symbols): Update.
7192         * dbxread.c (dbx_end_psymtab): Update.
7193
7194 2019-01-15  Tom Tromey  <tom@tromey.com>
7195
7196         * symtab.c (lookup_objfile_from_block)
7197         (lookup_symbol_in_objfile_symtabs)
7198         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7199         (find_line_symtab, info_sources_command)
7200         (default_collect_symbol_completion_matches_break_on)
7201         (make_source_files_completion_list): Update.
7202         * symmisc.c (print_objfile_statistics, dump_objfile)
7203         (maintenance_print_symbols, maintenance_info_symtabs)
7204         (maintenance_check_symtabs, maintenance_info_line_tables):
7205         Update.
7206         * source.c (select_source_symtab)
7207         (forget_cached_source_info_for_objfile): Update.
7208         * objfiles.h (class objfile_compunits): Remove.
7209         (struct objfile) <compunits_range>: New typedef.
7210         (compunits): New method.
7211         * objfiles.c (objfile_relocate1): Update.
7212         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7213         * maint.c (count_symtabs_and_blocks): Update.
7214         * linespec.c (iterate_over_all_matching_symtabs): Update.
7215         * cp-support.c (add_symbol_overload_list_qualified): Update.
7216         * coffread.c (coff_symtab_read): Update.
7217         * ada-lang.c (add_nonlocal_symbols)
7218         (ada_collect_symbol_completion_matches)
7219         (ada_add_global_exceptions): Update.
7220
7221 2019-01-15  Tom Tromey  <tom@tromey.com>
7222
7223         * progspace.h (program_space) <objfiles_safe_range>: New
7224         typedef.
7225         <objfiles_safe>: New method.
7226         * objfiles.h (class all_objfiles_safe): Remove.
7227         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7228         * jit.c (jit_inferior_exit_hook): Update.
7229
7230 2019-01-17  Tom Tromey  <tom@tromey.com>
7231
7232         * progspace.h (program_space) <objfiles_range>: New typedef.
7233         <objfiles>: New method.
7234         <objfiles_head>: Rename from objfiles.
7235         (object_files): Update.
7236         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7237         * guile/scm-pretty-print.c
7238         (ppscm_find_pretty_printer_from_objfiles): Update.
7239         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7240         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7241         Update.
7242         * python/py-progspace.c (pspy_get_objfiles): Update.
7243         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7244         Update.
7245         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7246         (objfpy_lookup_objfile_by_build_id): Update.
7247         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7248         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7249         Update.
7250         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7251         (expand_symtab_containing_pc, lookup_objfile_from_block)
7252         (lookup_static_symbol, basic_lookup_transparent_type)
7253         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7254         (find_line_symtab, info_sources_command)
7255         (default_collect_symbol_completion_matches_break_on)
7256         (make_source_files_completion_list, find_main_name): Update.
7257         * symmisc.c (print_symbol_bcache_statistics)
7258         (print_objfile_statistics, maintenance_print_symbols)
7259         (maintenance_print_msymbols, maintenance_print_objfiles)
7260         (maintenance_info_symtabs, maintenance_check_symtabs)
7261         (maintenance_expand_symtabs, maintenance_info_line_tables):
7262         Update.
7263         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7264         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7265         (map_overlay_command, unmap_overlay_command)
7266         (simple_overlay_update, expand_symtabs_matching)
7267         (map_symbol_filenames): Update.
7268         * symfile-debug.c (set_debug_symfile): Update.
7269         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7270         Update.
7271         * source.c (select_source_symtab, forget_cached_source_info):
7272         Update.
7273         * solib.c (solib_read_symbols): Update.
7274         * solib-spu.c (append_ocl_sos): Update.
7275         * psymtab.c (maintenance_print_psymbols)
7276         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7277         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7278         * printcmd.c (info_symbol_command): Update.
7279         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7280         Update.
7281         * objfiles.h (class all_objfiles): Remove.
7282         * objfiles.c (have_partial_symbols, have_full_symbols)
7283         (have_minimal_symbols, qsort_cmp, update_section_map)
7284         (shared_objfile_contains_address_p)
7285         (default_iterate_over_objfiles_in_search_order): Update.
7286         * objc-lang.c (info_selectors_command, info_classes_command)
7287         (find_methods): Update.
7288         * minsyms.c (find_solib_trampoline_target): Update.
7289         * maint.c (maintenance_info_sections)
7290         (maintenance_translate_address, count_symtabs_and_blocks):
7291         Update.
7292         * main.c (captured_main_1): Update.
7293         * linux-thread-db.c (try_thread_db_load_from_pdir)
7294         (has_libpthread): Update.
7295         * linespec.c (iterate_over_all_matching_symtabs)
7296         (search_minsyms_for_name): Update.
7297         * jit.c (jit_find_objf_with_entry_addr): Update.
7298         * hppa-tdep.c (find_unwind_entry)
7299         (hppa_lookup_stub_minimal_symbol): Update.
7300         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7301         Update.
7302         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7303         (elf_gnu_ifunc_resolve_by_got): Update.
7304         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7305         * dwarf-index-write.c (save_gdb_index_command): Update.
7306         * cp-support.c (add_symbol_overload_list_qualified): Update.
7307         * breakpoint.c (create_overlay_event_breakpoint)
7308         (create_longjmp_master_breakpoint)
7309         (create_std_terminate_master_breakpoint)
7310         (create_exception_master_breakpoint): Update.
7311         * blockframe.c (find_pc_partial_function): Update.
7312         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7313         (ada_collect_symbol_completion_matches)
7314         (ada_add_global_exceptions): Update.
7315
7316 2019-01-17  Tom Tromey  <tom@tromey.com>
7317
7318         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7319         declare VEC.
7320         (solib_target_parse_libraries): Change return type.
7321         (library_list_start_segment, library_list_start_section)
7322         (library_list_end_library, library_list_start_library); Update.
7323         (solib_target_free_library_list): Remove.
7324         (solib_target_parse_libraries): Remove cleanup.  Change return
7325         type.
7326         (solib_target_current_sos): Update.
7327
7328 2019-01-17  Tom Tromey  <tromey@bapiya>
7329
7330         * valprint.c: Replace "the the" with "the".
7331         * symtab.c: Replace "the the" with "the".
7332         * solib.c: Replace "the the" with "the".
7333         * solib-dsbt.c: Replace "the the" with "the".
7334         * linespec.c: Replace "the the" with "the".
7335         * dwarf2loc.h: Replace "the the" with "the".
7336         * amd64-windows-tdep.c: Replace "the the" with "the".
7337         * aarch64-tdep.c: Replace "the the" with "the".
7338
7339 2019-01-16  Keith Seitz  <keiths@redhat.com>
7340
7341         PR gdb/23773
7342         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7343         <builder>: Rename to ..
7344         <m_builder>: ... this and make private.
7345         (dwarf2_cu::get_builder): New method.  Change all users of
7346         `builder' to use this method.
7347         (dwarf2_start_symtab): Move to ...
7348         (dwarf2_cu::start_symtab): ... here.  Update all callers
7349         (setup_type_unit_groups): Move to ...
7350         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7351         callers.
7352         (dwarf2_cu::reset_builder): New method.
7353         (process_full_compunit, process_full_type_unit): Use
7354         dwarf2_cu::reset_builder.
7355         (follow_die_offset): Record the ancestor CU if it is different
7356         from the followed DIE's CU.
7357         (follow_die_sig_1): Likewise.
7358
7359 2019-01-15  Tom Tromey  <tom@tromey.com>
7360
7361         * remote.c (class remote_state) <buf>: Now a char_vector.
7362         <buf_size>: Remove.
7363         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7364         parameter.
7365         (remote_target::getpkt_or_notif_sane_1)
7366         (remote_target::getpkt_sane)
7367         (remote_target::getpkt_or_notif_sane): Likewise.
7368         (class remote_target) <putpkt>: New overload.
7369         (remote_target::read_frame): Change type of "buf_p".  Remove
7370         sizeof_p parameter.
7371         (packet_ok): New overload.
7372         (packet_check_result): New overload.
7373         Update all uses.
7374
7375 2019-01-14  Tom Tromey  <tom@tromey.com>
7376
7377         * remote-notif.c (handle_notification, remote_notif_ack)
7378         (remote_notif_parse): Make "buf" const.
7379         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7380         const.
7381         (remote_notif_parse, remote_notif_ack, handle_notification):
7382         Likewise.
7383         * remote.c (remote_notif_stop_parse): Make "buf" const.
7384         (remote_target::remote_parse_stop_reply): Make "buf" const.
7385         (remote_notif_stop_ack): Make "buf" const.
7386
7387 2019-01-14  Tom Tromey  <tom@tromey.com>
7388
7389         * remote.c (remote_console_output): Make parameter const.
7390
7391 2019-01-14  Tom Tromey  <tom@tromey.com>
7392
7393         * target-debug.h (target_debug_print_signals): Constify.
7394         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7395         * procfs.c (procfs_target::pass_signals): Update.
7396         * linux-nat.c (linux_nat_target::pass_signals): Update.
7397         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7398         * target-delegates.c: Rebuild.
7399         * remote.c (remote_target::program_signals): Update.
7400         (remote_target::pass_signals): Update.
7401         * target.c (target_pass_signals): Constify argument.
7402         (target_program_signals): Likewise.
7403         * target.h (struct target_ops) <pass_signals, program_signals>:
7404         Constify argument.
7405         (target_pass_signals, target_program_signals): Constify argument.
7406
7407 2019-01-14  Tom Tromey  <tom@tromey.com>
7408
7409         PR tui/28819:
7410         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7411
7412 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7413
7414         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7415         field.
7416         * rs6000-tdep.c: Include reggroups.h.
7417         (IS_V_ALIAS_PSEUDOREG): Define.
7418         (rs6000_register_name): Return names for the "vX" aliases.
7419         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7420         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7421         aliases.  Call default_register_reggroup_p for all other
7422         pseudo-registers.
7423         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7424         New functions.
7425         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7426         Handle "vX" aliases.
7427         (v_alias_pseudo_register_collect): New function.
7428         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7429         (rs6000_gdbarch_init): Initialize "vX" aliases as
7430         pseudo-registers.  Restore registration of
7431         rs6000_pseudo_register_reggroup_p with
7432         set_tdesc_pseudo_register_reggroup_p.
7433
7434 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7435
7436         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7437         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7438         set_gdbarch_num_pseudo_regs.
7439
7440 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7441
7442         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7443         Remove arg prefixname, add do_set and do_show.
7444         Add member functions set_list and show_list.
7445         * cli/cli-style.c (class cli_style_option): Update accordingly.
7446         (style_set_list): Move to file scope.
7447         (style_show_list): Likewise.
7448         (set_style): Call help_list.
7449         (show_style): Call cmd_show_list.
7450         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7451         Update to use the new macro.
7452
7453 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7454
7455         * ada-lang.c (_initialize_ada_language): Expand the help text
7456         for the "catch exception" command.
7457
7458 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7459
7460         * symtab.c (matching_obj_sections): Initialize obj,
7461         declare it closer to its usage.
7462
7463 2019-01-10  Tom Tromey  <tom@tromey.com>
7464
7465         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7466         (basic_inf_threads_range): Remove.
7467         (inf_threads_range, inf_non_exited_threads_range)
7468         (safe_inf_threads_range): Use next_adapter.
7469
7470 2019-01-10  Keith Seitz  <keiths@redhat.com>
7471
7472         PR gdb/23712
7473         PR symtab/23010
7474         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7475         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7476
7477 2019-01-10  Keith Seitz  <keiths@redhat.com>
7478
7479         PR gdb/23712
7480         PR symtab/23010
7481         * dictionary.c (pending_to_vector): Remove.
7482         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7483         Remove _1 suffix, replacing functions of the same name.  Update
7484         all callers.
7485         (dict_create_hashed, dict_create_hashed_expandable)
7486         (dict_create_linear, dict_create_linear_expandable, dict_free)
7487         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7488         Make functions static.
7489
7490 2019-01-10  Keith Seitz  <keiths@redhat.com>
7491
7492         PR gdb/23712
7493         PR symtab/23010
7494         * dictionary.h (struct dictionary): Replace declaration with
7495         multidictionary.
7496         (dict_create_hashed, dict_create_hashed_expandable)
7497         (dict_create_linear, dict_create_linear_expandable)
7498         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7499         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7500         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7501         taking multidictionary argument.
7502         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7503         * block.h (struct block) <dict>: Change to multidictionary
7504         and rename `multidict'.
7505         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7506         symmisc.c: Update all dictionary references to multidictionary.
7507
7508 2019-01-10  Keith Seitz  <keiths@redhat.com>
7509
7510         PR gdb/23712
7511         PR symtab/23010
7512         * dictionary.c: Include unordered_map.
7513         (pending_to_vector): New function.
7514         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7515         Rewrite the non-"_1" functions to take vector instead
7516         of linked list.
7517         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7518         "new" _1 versions of the same name.
7519         (multidictionary): Define.
7520         (std::hash<enum language): New definition.
7521         (collate_pending_symbols_by_language, mdict_create_hashed)
7522         (mdict_create_hashed_expandable, mdict_create_linear)
7523         (mdict_create_linear_expandable, mdict_free)
7524         (find_language_dictionary, create_new_language_dictionary)
7525         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7526         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7527         (mdict_size, mdict_empty): New functions.
7528         * dictionary.h (mdict_iterator): Define.
7529
7530 2019-01-10  Pedro Alves  <palves@redhat.com>
7531
7532         * breakpoint.c (read_uploaded_action)
7533         (create_tracepoint_from_upload): Adjust to use
7534         gdb::unique_xmalloc_ptr.
7535         * ctf.c (ctf_write_uploaded_tp):
7536         (SET_ARRAY_FIELD): Use emplace_back.
7537         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7538         * tracefile-tfile.c (tfile_write_uploaded_tp):
7539         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7540         gdb::unique_xmalloc_ptr.
7541         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7542         at_string, cond_string, cmd_strings>: Replace char pointers
7543         with gdb::unique_xmalloc_ptr.
7544
7545 2019-01-10  Pedro Alves  <palves@redhat.com>
7546
7547         * solib-target.c (library_list_start_library): Don't xstrdup name.
7548
7549 2019-01-10  Pedro Alves  <palves@redhat.com>
7550
7551         * mdebugread.c (parse_partial_symbols): Use
7552         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7553
7554 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7555
7556         * linux-fork.c (scoped_switch_fork_info)
7557         <~scoped_switch_fork_info>: Fix incorrect variable name.
7558
7559 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7560
7561         * linux-fork.c (scoped_switch_fork_info)
7562         <scoped_switch_fork_info>: Make explicit.
7563         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7564
7565 2019-01-10  Tom Tromey  <tom@tromey.com>
7566
7567         * objfiles.h (objfile::reset_psymtabs): Update.
7568         * objfiles.c (objfile::objfile): Update.
7569         * psymtab.h (psymtab_storage::obstack): Update.
7570         (psymtab_storage::m_obstack): Use gdb::optional.
7571         (class psymtab_storage): Update comment.  Remove objfile
7572         parameter.
7573         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7574
7575 2019-01-10  Tom Tromey  <tom@tromey.com>
7576
7577         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7578         <free_psymtabs>: Now private.
7579         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7580         (allocate_psymtab): Use new method.
7581
7582 2019-01-10  Tom Tromey  <tom@tromey.com>
7583
7584         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7585         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7586         * mdebugread.c (parse_partial_symbols): Use
7587         allocate_dependencies.
7588         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7589         allocate_dependencies.
7590         (process_psymtab_comp_unit_reader)
7591         (build_type_psymtab_dependencies): Likewise.
7592         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7593
7594 2019-01-10  Tom Tromey  <tom@tromey.com>
7595
7596         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7597         PSYMBOL_SET_LANGUAGE.
7598         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7599
7600 2019-01-10  Tom Tromey  <tom@tromey.com>
7601
7602         * psymtab.h (psymtab_storage::obstack): New method.
7603         <m_obstack>: Rename from obstack; now private.
7604         * psymtab.c (psymtab_storage): Update.
7605         * dwarf2read.c (create_addrmap_from_index)
7606         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7607         Update.
7608
7609 2019-01-10  Tom Tromey  <tom@tromey.com>
7610
7611         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7612         * objfiles.h (objfile::reset_psymtabs): New method.
7613
7614 2019-01-10  Tom Tromey  <tom@tromey.com>
7615
7616         * symmisc.c (print_symbol_bcache_statistics): Update.
7617         (print_objfile_statistics): Update.
7618         * symfile.c (reread_symbols): Update.
7619         * psymtab.h (class psymtab_storage): New.
7620         * psymtab.c (psymtab_storage): New constructor.
7621         (~psymtab_storage): New destructor.
7622         (require_partial_symbols): Update.
7623         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7624         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7625         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7626         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7627         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7628         (start_psymtab_common, end_psymtab_common)
7629         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7630         (allocate_psymtab): Update.
7631         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7632         Update.
7633         (dump_psymtab_addrmap, maintenance_print_psymbols)
7634         (maintenance_check_psymtabs): Update.
7635         (class objfile_psymtabs): Move to objfiles.h.
7636         * psympriv.h (discard_psymtab): Now inline.
7637         (psymtab_discarder::psymtab_discarder): Update.
7638         (psymtab_discarder::~psymtab_discarder): Update.
7639         (ALL_OBJFILE_PSYMTABS): Rewrite.
7640         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7641         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7642         Remove fields.
7643         <partial_symtabs>: New field.
7644         (class objfile_psymtabs): Move from psymtab.h.  Update.
7645         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7646         psymbol_cache.
7647         (objfile::~objfile): Don't destroy psymbol_cache.
7648         * mdebugread.c (parse_partial_symbols): Update.
7649         * dwarf2read.c (create_addrmap_from_index)
7650         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7651         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7652         (add_partial_subprogram, dwarf2_ranges_read): Update.
7653         * dwarf-index-write.c (write_address_map)
7654         (write_one_signatured_type, recursively_write_psymbols)
7655         (class debug_names, class debug_names, write_psymtabs_to_index):
7656         Update.
7657
7658 2019-01-10  Tom Tromey  <tom@tromey.com>
7659
7660         * symtab.h (SYMBOL_SET_NAMES): Update.
7661         (symbol_set_names): Update.
7662         (MSYMBOL_SET_NAMES): Update.
7663         * symtab.c (symbol_set_names): Change argument to be an
7664         objfile_per_bfd_storage.
7665         * psymtab.c (add_psymbol_to_bcache): Update.
7666         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7667
7668 2019-01-10  Tom Tromey  <tom@tromey.com>
7669
7670         * symtab.c (create_demangled_names_hash): Change argument to be an
7671         objfile_per_bfd_storage.
7672         (symbol_set_names): Update.
7673
7674 2019-01-10  Tom Tromey  <tom@tromey.com>
7675
7676         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7677         init_psymbol_list.
7678         * psymtab.c (init_psymbol_list): Do nothing if already called.
7679         * psympriv.h (init_psymbol_list): Add comment.
7680         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7681         init_psymbol_list.
7682         * dbxread.c (dbx_symfile_read): Unconditionally call
7683         init_psymbol_list.
7684
7685 2019-01-10  Tom Tromey  <tom@tromey.com>
7686
7687         * xcoffread.c (scan_xcoff_symtab): Update.
7688         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7689         "where".
7690         * mdebugread.c (parse_partial_symbols)
7691         (handle_psymbol_enumerators): Update.
7692         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7693         * dbxread.c (read_dbx_symtab): Update.
7694         * psympriv.h (psymbol_placement): New enum.
7695         (add_psymbol_to_list): Update.
7696
7697 2019-01-10  Tom Tromey  <tom@tromey.com>
7698
7699         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7700         static_psymbols parameters.
7701         (scan_xcoff_symtab): Update.
7702         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7703         static_psymbols parameters.
7704         * psympriv.h (start_psymtab_common): Update.
7705         * mdebugread.c (parse_partial_symbols): Update.
7706         * dwarf2read.c (create_partial_symtab): Update.
7707         * dbxread.c (read_dbx_symtab): Update.
7708         (start_psymtab): Remove global_psymbols and static_psymbols
7709         parameters.
7710
7711 2019-01-10  Tom Tromey  <tom@tromey.com>
7712
7713         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7714         * psymtab.c (allocate_psymtab): Add comment.
7715         * psympriv.h (allocate_psymtab): Add comment.
7716         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7717         initializations.
7718         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7719
7720 2019-01-10  Tom Tromey  <tom@tromey.com>
7721
7722         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7723         Don't declare.
7724         * mipsread.c: Include mdebugread.h.
7725         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7726         Declare.
7727         * elfread.c: Include mdebugread.h.
7728
7729 2019-01-09  Tom Tromey  <tom@tromey.com>
7730
7731         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7732         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7733         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7734         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7735         (psym_lookup_symbol, psym_find_last_source_symtab)
7736         (psym_forget_cached_source_info, psym_print_stats)
7737         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7738         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7739         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7740         (psym_find_compunit_symtab_by_address)
7741         (maintenance_print_psymbols, maintenance_info_psymtabs)
7742         (maintenance_check_psymtabs): Use ranged for.
7743         * psymtab.h (class objfile_psymtabs): New.
7744         (require_partial_symbols): Return objfile_psymtabs.
7745         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7746
7747 2019-01-09  Tom Tromey  <tom@tromey.com>
7748
7749         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7750         (find_pc_mapped_section, list_overlays_command)
7751         (map_overlay_command, unmap_overlay_command)
7752         (simple_overlay_update): Use all_objfiles.
7753         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7754         * printcmd.c (info_symbol_command): Use all_objfiles.
7755         * objfiles.h (ALL_OBJSECTIONS): Remove.
7756         * maint.c (maintenance_translate_address): Use all_objfiles.
7757         * gcore.c (gcore_create_callback): Use all_objfiles.
7758         (objfile_find_memory_regions): Likewise.
7759
7760 2019-01-09  Tom Tromey  <tom@tromey.com>
7761
7762         * symtab.c (find_line_symtab, info_sources_command)
7763         (make_source_files_completion_list): Use objfile_compunits.
7764         * source.c (select_source_symtab): Use objfile_compunits.
7765         * objfiles.h (struct objfile): Update comment.
7766         (ALL_OBJFILES): Remove.
7767         (ALL_FILETABS): Remove.
7768         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7769         objfile_compunits.
7770
7771 2019-01-09  Tom Tromey  <tom@tromey.com>
7772
7773         * symmisc.c (print_objfile_statistics, dump_objfile)
7774         (maintenance_print_symbols): Use compunit_filetabs.
7775         * source.c (forget_cached_source_info_for_objfile): Use
7776         compunit_filetabs.
7777         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7778         (ALL_FILETABS): Use compunit_filetabs.
7779         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7780         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7781
7782 2019-01-09  Tom Tromey  <tom@tromey.com>
7783
7784         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7785         (compunit_filetabs): New.
7786         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7787         compunit_filetabs.
7788         (info_sources_command, make_source_files_completion_list): Remove
7789         declaration.
7790         * symmisc.c (print_objfile_statistics, dump_objfile)
7791         (maintenance_print_symbols): Remove declaration.
7792         (maintenance_info_symtabs): Use compunit_filetabs.
7793         (maintenance_info_line_tables): Likewise.
7794         * source.c (select_source_symtab): Change local variable name.
7795         (forget_cached_source_info_for_objfile): Remove declaration.
7796         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7797         * objfiles.c (objfile_relocate1): Remove declaration.
7798         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7799         declaration.
7800         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7801         * coffread.c (coff_symtab_read): Remove declaration.
7802         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7803         compunit_filetabs.
7804
7805 2019-01-09  Tom Tromey  <tom@tromey.com>
7806
7807         * symtab.c (lookup_objfile_from_block)
7808         (find_pc_sect_compunit_symtab, search_symbols)
7809         (default_collect_symbol_completion_matches_break_on): Use
7810         objfile_compunits.
7811         * objfiles.h (ALL_COMPUNITS): Remove.
7812         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7813         * cp-support.c (add_symbol_overload_list_qualified): Use
7814         objfile_compunits.
7815         * ada-lang.c (ada_collect_symbol_completion_matches)
7816         (ada_add_global_exceptions): Use objfile_compunits.
7817
7818 2019-01-09  Tom Tromey  <tom@tromey.com>
7819
7820         * source.c (select_source_symtab)
7821         (forget_cached_source_info_for_objfile): Remove declaration.
7822         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7823         declaration.
7824         * maint.c (count_symtabs_and_blocks): Remove declaration.
7825         * cp-support.c (add_symbol_overload_list_qualified): Remove
7826         declaration.
7827         * coffread.c (coff_symtab_read): Remove declaration.
7828         * symtab.c (lookup_symbol_in_objfile_symtabs)
7829         (basic_lookup_transparent_type_1): Use objfile_compunits.
7830         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7831         (info_sources_command, search_symbols)
7832         (default_collect_symbol_completion_matches_break_on)
7833         (make_source_files_completion_list): Remove declaration.
7834         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7835         (ada_collect_symbol_completion_matches)
7836         (ada_add_global_exceptions): Remove declaration.
7837         * linespec.c (iterate_over_all_matching_symtabs): Use
7838         objfile_compunits.
7839         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7840         (class objfile_compunits): New.
7841         (ALL_COMPUNITS): Use objfile_compunits.
7842         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7843         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7844         objfile_compunits.
7845         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7846
7847 2019-01-09  Tom Tromey  <tom@tromey.com>
7848
7849         * symtab.c (search_symbols)
7850         (default_collect_symbol_completion_matches_break_on): Use
7851         objfile_msymbols.
7852         * ada-lang.c (ada_lookup_simple_minsym)
7853         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7854         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7855         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7856         objfile_msymbols.
7857         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7858         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7859         * objc-lang.c (find_methods): Use objfile_msymbols.
7860         (info_selectors_command, info_classes_command): Likewise.
7861         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7862         * objfiles.h (class objfile_msymbols): New.
7863         (ALL_OBJFILE_MSYMBOLS): Remove.
7864         (ALL_MSYMBOLS): Remove.
7865
7866 2019-01-09  Tom Tromey  <tom@tromey.com>
7867
7868         * common/next-iterator.h (next_adapter): Add Iterator template
7869         parameter.
7870         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7871         (class all_objfiles_safe): New.
7872         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7873         * objfiles.c (put_objfile_before): Update comment.
7874         (add_separate_debug_objfile): Likewise.
7875         (free_all_objfiles): Use all_objfiles_safe.
7876         (objfile_purge_solibs): Likewise.
7877
7878 2019-01-09  Tom Tromey  <tom@tromey.com>
7879
7880         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7881         (expand_symtab_containing_pc, lookup_static_symbol)
7882         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7883         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7884         all_objfiles.
7885         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7886         * breakpoint.c (create_overlay_event_breakpoint)
7887         (create_longjmp_master_breakpoint)
7888         (create_std_terminate_master_breakpoint)
7889         (create_exception_master_breakpoint): Use all_objfiles.
7890         * linux-thread-db.c (try_thread_db_load_from_pdir)
7891         (has_libpthread): Use all_objfiles.
7892         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7893         * linespec.c (iterate_over_all_matching_symtabs)
7894         (search_minsyms_for_name): Use all_objfiles.
7895         * maint.c (maintenance_info_sections): Use all_objfiles.
7896         * main.c (captured_main_1): Use all_objfiles.
7897         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7898         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7899         * guile/scm-pretty-print.c
7900         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7901         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7902         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7903         (maintenance_print_msymbols): Use all_objfiles.
7904         * source.c (select_source_symtab): Use all_objfiles.
7905         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7906         * symfile.c (remove_symbol_file_command)
7907         (expand_symtabs_matching, map_symbol_filenames): Use
7908         all_objfiles.
7909         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7910         all_objfiles.
7911         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7912         * objc-lang.c (find_methods): Use all_objfiles.
7913         * objfiles.c (have_partial_symbols, have_full_symbols)
7914         (have_minimal_symbols, qsort_cmp)
7915         (default_iterate_over_objfiles_in_search_order): Use
7916         all_objfiles.
7917         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7918         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7919         (maintenance_check_psymtabs): Use all_objfiles.
7920         (ALL_PSYMTABS): Remove.
7921         * compile/compile-object-run.c (do_module_cleanup): Use
7922         all_objfiles.
7923         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7924         * cp-support.c (add_symbol_overload_list_qualified): Use
7925         all_objfiles.
7926         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7927         Use all_objfiles.
7928         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7929         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7930         all_objfiles.
7931         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7932         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7933         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7934         Uses all_objfiles.
7935         * solib.c (solib_read_symbols): Use all_objfiles
7936
7937 2019-01-09  Tom Tromey  <tom@tromey.com>
7938
7939         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7940         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7941         all_objfiles.
7942         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7943         * symmisc.c (print_symbol_bcache_statistics)
7944         (print_objfile_statistics, maintenance_print_objfiles)
7945         (maintenance_info_symtabs, maintenance_check_symtabs)
7946         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7947         all_objfiles.
7948         * source.c (forget_cached_source_info): Use all_objfiles.
7949         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7950         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7951         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7952         * objfiles.c (update_section_map): Use all_objfiles.
7953         (shared_objfile_contains_address_p): Likewise.
7954         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7955         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7956
7957 2019-01-09  Tom Tromey  <tom@tromey.com>
7958
7959         * common/next-iterator.h: New file.
7960         * objfiles.h (class all_objfiles): New.
7961         (struct objfile_iterator): New.
7962
7963 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7964
7965         * NEWS: Move the description of the changed "frame", "select-frame",
7966          and "info frame" commands to the Changed commands section.
7967
7968 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7969
7970         * gdbtypes.c (check_stub_method_group): Remove handling of old
7971         mangling schemes.
7972         * linespec.c (find_methods): Likewise.
7973         * stabsread.c (read_member_functions): Likewise.
7974         * valops.c (search_struct_method): Likewise.
7975         (value_struct_elt_for_reference): Likewise.
7976         * NEWS: Mention this change.
7977
7978 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7979
7980         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7981         print_source_lines.
7982         * source.c (print_source_lines_base): Update line number check.
7983         (print_source_lines): New function.
7984         (source_lines_range::source_lines_range): New function.
7985         * source.h (class source_lines_range): New class.
7986         (print_source_lines): New declaration.
7987
7988 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7989
7990         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7991
7992 2019-01-08  Tom Tromey  <tom@tromey.com>
7993             Simon Marchi  <simon.marchi@ericsson.com>
7994
7995         PR gdb/24060
7996         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7997         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7998         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7999         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8000         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8001         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8002
8003 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8004
8005         * source.c (select_source_symtab): Move header comment to
8006         declaration in source.h.
8007         (forget_cached_source_info_for_objfile): Likewise.
8008         (forget_cached_source_info): Likewise.
8009         (identify_source_line): Likewise.
8010         * source.h (identify_source_line): Move declaration from symtab.h
8011         and add comment from source.c
8012         (print_source_lines): Likewise.
8013         (forget_cached_source_info_for_objfile): Likewise.
8014         (forget_cached_source_info): Likewise.
8015         (select_source_symtab): Likewise.
8016         (enum print_source_lines_flag): Move definition from symtab.h.
8017         * symtab.h (identify_source_line): Move declaration to source.h.
8018         (print_source_lines): Likewise.
8019         (forget_cached_source_info_for_objfile): Likewise.
8020         (forget_cached_source_info): Likewise.
8021         (select_source_symtab): Likewise.
8022         (enum print_source_lines_flag): Move definition to source.h.
8023         * tui/tui-hooks.c: Add 'source.h' include.
8024
8025 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8026
8027         * source.c (print_source_lines_base): Handle requests to print
8028         reverse line number sequences, and guard against empty lines
8029         string.
8030
8031 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8032
8033         * source.c (print_source_lines_base): Fix skip of '\r' if next
8034         character is '\n'.
8035
8036 2019-01-06  Tom Tromey  <tom@tromey.com>
8037
8038         * c-exp.y (struct c_parse_state) <macro_original_text,
8039         expansion_obstack>: New member.
8040         (macro_original_text, expansion_obstack): Remove globals.
8041         (scan_macro_expansion, scanning_macro_expansion)
8042         (finished_macro_expansion): Update.
8043         (scan_macro_cleanup): Remove.
8044         (yylex, c_parse): Update.
8045
8046 2019-01-06  Tom Tromey  <tom@tromey.com>
8047
8048         * c-exp.y (struct c_parse_state) <strings>: New member.
8049         (operator_stoken): Update.
8050
8051 2019-01-06  Tom Tromey  <tom@tromey.com>
8052
8053         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8054         (union type_stack_elt) <typelist_val>: Now a pointer to
8055         std::vector.
8056         (type_stack_cleanup): Don't declare.
8057         (push_typelist): Update.
8058         * parse.c (pop_typelist): Return a std::vector.
8059         (push_typelist): Take a std::vector.
8060         (follow_types): Update.  Do not free args.
8061         (type_stack_cleanup): Remove.
8062         * c-exp.y (struct c_parse_state): New.
8063         (cpstate): New global.
8064         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8065         (nonempty_typelist): Update.
8066         (func_mod): Create a new vector.
8067         (c_parse): Create a c_parse_state.
8068         (check_parameter_typelist): Do not delete params.
8069         (function_method): Update.  Do not delete type_list.
8070
8071 2019-01-06  Tom Tromey  <tom@tromey.com>
8072
8073         PR gdb/28155:
8074         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8075         check_typedef.
8076         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8077         (print_return_value): Likewise.
8078
8079 2019-01-05  Tom Tromey  <tom@tromey.com>
8080
8081         * contrib/cleanup_check.py: Remove.
8082         * contrib/gcc-with-excheck: Remove.
8083         * contrib/exsummary.py: Remove.
8084         * contrib/excheck.py: Remove.
8085
8086 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8087
8088         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8089         NULL. Initialize tpprev to NULL instead of assigning it
8090         to NULL on the next statement.
8091         * windows-nat.c (windows_delete_thread): Remove check for
8092         main_thread_id before printing thread exit notifications.
8093         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8094         Remove thread ID check against main_thread_id.
8095         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8096         windows_delete_thread.
8097         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8098
8099 2019-01-04  Tom Tromey  <tom@tromey.com>
8100
8101         * compile/compile.c (_initialize_compile): Use upper case for
8102         metasyntactic variables.
8103         * symmisc.c (_initialize_symmisc): Use upper case for
8104         metasyntactic variables.
8105         * psymtab.c (_initialize_psymtab): Use upper case for
8106         metasyntactic variables.
8107         * demangle.c (demangle_command): Use upper case for metasyntactic
8108         variables.
8109         (_initialize_demangler): Likewise.
8110         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8111         variables.
8112
8113 2019-01-03  Tom Tromey  <tom@tromey.com>
8114
8115         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8116
8117 2019-01-03  Tom Tromey  <tom@tromey.com>
8118
8119         * python/py-symtab.c (salpy_str): Update.
8120         (struct salpy_sal_object) <symtab>: Now a PyObject.
8121         (salpy_dealloc): Update.
8122         (del_objfile_sal): Use gdbpy_ref.
8123
8124 2019-01-03  Tom Tromey  <tom@tromey.com>
8125
8126         * python/py-type.c (convert_field): Use new_reference.  Return
8127         gdbpy_ref.
8128         (make_fielditem): Return gdbpy_ref.
8129         (typy_fields): Update.
8130         (typy_getitem): Update.
8131         (field_name): Return gdbpy_ref.  Use new_reference.
8132         (typy_iterator_iternext): Update.
8133
8134 2019-01-03  Tom Tromey  <tom@tromey.com>
8135
8136         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8137
8138 2019-01-03  Tom Tromey  <tom@tromey.com>
8139
8140         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8141         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8142         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8143         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8144         (pspy_set_type_printers): Likewise.
8145         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8146         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8147         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8148         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8149         (objfpy_set_type_printers): Likewise.
8150
8151 2019-01-03  Tom Tromey  <tom@tromey.com>
8152
8153         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8154         (gdbpy_print_stack): Use gdbpy_err_fetch.
8155         * python/python-internal.h (class gdbpy_err_fetch): New class.
8156         (class gdbpy_enter) <m_error_type, m_error_value,
8157         m_error_traceback>: Remove.
8158         <m_error>: New member.
8159         (gdbpy_exception_to_string): Don't declare.
8160         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8161         * python/py-value.c (convert_value_from_python): Use
8162         gdbpy_err_fetch.
8163         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8164         gdbpy_exception_to_string.
8165         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8166         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8167         gdbpy_err_fetch.
8168
8169 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8170
8171         * linux-nat.c (delete_lwp_cleanup): Delete.
8172         (struct lwp_deleter): New struct.
8173         (lwp_info_up): New typedef.
8174         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8175         lwp_info_up.
8176
8177 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8178
8179         * linux-fork.c (class scoped_switch_fork_info): New class.
8180         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8181
8182 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8183
8184         * valops.c (find_overload_match): Remove use of null_cleanup, and
8185         calls to do_cleanups.
8186
8187 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8188
8189         * compile/compile-cplus-types.c
8190         (compile_cplus_instance::decl_name): Handle changes to
8191         cp_func_name.
8192         * cp-support.c (cp_func_name): Update header comment, update
8193         return type.
8194         * cp-support.h (cp_func_name): Update return type in declaration.
8195         * valops.c (find_overload_match): Move temp_func local to top
8196         level of function and change its type.  Use temp_func to hold and
8197         delete temporary string obtained from cp_func_name.
8198
8199 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8200
8201         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8202         gdb::char_vector, remove cleanup, and update uses of `msg`.
8203
8204 2019-01-03  Jim Wilson  <jimw@sifive.com>
8205
8206         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8207
8208 2019-01-02  Tom Tromey  <tom@tromey.com>
8209
8210         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8211         (tdesc_parse_xml): Remove cleanups.
8212         * target-descriptions.h (make_cleanup_free_target_description):
8213         Don't declare.
8214         (target_desc_deleter): New struct.
8215         (target_desc_up): New typedef.
8216         * target-descriptions.c (target_desc_deleter::operator()): Rename
8217         from free_target_description.
8218         (make_cleanup_free_target_description): Remove.
8219
8220 2019-01-02  Tom Tromey  <tom@tromey.com>
8221
8222         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8223         constructor, destructor.
8224         (linespec_parser): Remove typedef.
8225         (~linespec_parser): Rename from linespec_parser_delete.
8226         (linespec_lex_to_end, linespec_complete_label)
8227         (linespec_complete): Update.
8228         (decode_line_full): Remove cleanups.
8229         (decode_line_1): Update.
8230
8231 2019-01-02  Tom Tromey  <tom@tromey.com>
8232
8233         * python/python-internal.h (inferior_to_inferior_object): Change
8234         return type.
8235         * python/py-exitedevent.c (create_exited_event_object): Update.
8236         * python/py-inferior.c (inferior_to_inferior_object): Return
8237         gdbpy_ref.
8238         (python_new_inferior, python_inferior_deleted)
8239         (thread_to_thread_object, delete_thread_object)
8240         (build_inferior_list, gdbpy_selected_inferior): Update.
8241         * python/py-infthread.c (create_thread_object): Update.  Also fail
8242         if inferior_to_inferior_object fails.
8243
8244 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8245
8246         * inferior.h (class inferior) <displaced_step_state>: New field.
8247         * infrun.h (struct displaced_step_state): Move here from
8248         infrun.c.  Initialize fields, add constructor.
8249         <inf>: Remove field.
8250         <reset>: New method.
8251         * infrun.c (struct displaced_step_inferior_state): Move to
8252         infrun.h.
8253         (displaced_step_inferior_states): Remove.
8254         (get_displaced_stepping_state): Adust.
8255         (displaced_step_in_progress_any_inferior): Adjust.
8256         (displaced_step_in_progress_thread): Adjust.
8257         (displaced_step_in_progress): Adjust.
8258         (add_displaced_stepping_state): Remove.
8259         (get_displaced_step_closure_by_addr): Adjust.
8260         (remove_displaced_stepping_state): Remove.
8261         (infrun_inferior_exit): Call displaced_step_state.reset.
8262         (use_displaced_stepping): Don't check for NULL.
8263         (displaced_step_prepare_throw): Call
8264         get_displaced_stepping_state.
8265         (displaced_step_fixup): Don't check for NULL.
8266         (prepare_for_detach): Don't check for NULL.
8267
8268 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8269
8270         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8271          in case of call that did not complete.
8272
8273 2019-01-02  Andrey Utkin  <autkin@undo.io>
8274
8275         * symfile.c (find_separate_debug_file): Fix search of debug files for
8276         remote debuggee.
8277
8278 2019-01-02  Tom Tromey  <tom@tromey.com>
8279
8280         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8281         indentation.
8282         * python/py-frame.c (frapy_older): Remove cast.
8283         (frapy_newer): Likewise.
8284         * python/py-breakpoint.c (local_setattro): Remove cast.
8285         * python/py-arch.c (archpy_name): Remove local variable.
8286         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8287
8288 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8289
8290         * unittests/basic_string_view/element_access/char/empty.cc:
8291         Fix year range in copyright header.
8292
8293 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8294
8295         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8296         Delete.
8297         <operator==>: Update with for removed field.
8298         <hash>: Likewise.
8299         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8300         <isa_features>: ...this.
8301         <abi_features>: New field.
8302         (riscv_isa_flen): Update comment.
8303         (riscv_abi_xlen): New declaration.
8304         (riscv_abi_flen): New declaration.
8305         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8306         isa_features.
8307         (riscv_abi_xlen): New function.
8308         (riscv_isa_flen): Update to get answer from isa_features.
8309         (riscv_abi_flen): New function.
8310         (riscv_has_fp_abi): Update to get answer from abi_features.
8311         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8312         xlen and flen.
8313         (riscv_call_info) <xlen, flen>: Update comment.
8314         (riscv_call_arg_struct): Remove invalid assertions
8315         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8316         is removed.
8317         (riscv_gdbarch_init): Gather isa features and abi features
8318         separately, ensure both match on the gdbarch when reusing an old
8319         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8320         a target with 64-bit float hardware.
8321
8322 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8323
8324         * source.c (search_command_helper): Stop reverse search
8325         when line 1 has been searched.
8326
8327 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8328
8329         * record-full.c (record_full_base_target::close): Rewrite
8330         record_full_core_buf_list free logic.
8331
8332 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8333
8334         * break-catch-syscall.c (print_one_catch_syscall): xfree
8335         the last text.
8336
8337 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8338
8339         * top.c (print_gdb_version): Update Copyright year in version
8340         message.
8341
8342 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8343
8344         Update copyright year range in all GDB files.
8345
8346 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8347
8348         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8349
8350 For older changes see ChangeLog-2018.
8351 \f
8352 Local Variables:
8353 mode: change-log
8354 left-margin: 8
8355 fill-column: 74
8356 version-control: never
8357 coding: utf-8
8358 End:
8359