gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
   4         Simplify.
   5
   6 2019-07-17  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-layout.c (show_source_disasm_command): Simplify window
   9         resetting.
  10
  11 2019-07-17  Tom Tromey  <tom@tromey.com>
  12
  13         * tui/tui.h (tui_set_layout_by_name): Don't declare.
  14         * tui/tui-regs.c (tui_reg_layout): New function.
  15         (tui_show_registers, tui_reg_command): Use it.
  16         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
  17         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
  18         parameters.
  19         (tui_layout_command): Remove.
  20
  21 2019-07-17  Tom Tromey  <tom@tromey.com>
  22
  23         * tui/tui-layout.h (tui/tui-layout): Return void.
  24         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
  25
  26 2019-07-17  Tom Tromey  <tom@tromey.com>
  27
  28         * tui/tui-layout.c (show_source_disasm_command, show_data):
  29         Update.
  30         (reset_locator): Remove.
  31         (show_source_or_disasm_and_command): Update.
  32
  33 2019-07-17  Tom Tromey  <tom@tromey.com>
  34
  35         * tui/tui-source.c (tui_source_window_base::reset): Remove
  36         win_type parameter.
  37         * tui/tui-layout.c (make_command_window, make_source_window)
  38         (make_disasm_window, make_data_window)
  39         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
  40         (reset_locator, show_source_or_disasm_and_command): Update.
  41         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
  42         win_type parameter.
  43         (struct tui_source_window_base) <reset>: Likewise.
  44
  45 2019-07-17  Tom Tromey  <tom@tromey.com>
  46
  47         * tui/tui-layout.c (show_source_disasm_command): Use
  48         reset_locator.
  49         (reset_locator): New function.
  50         (init_and_make_win): Remove.
  51         (show_source_or_disasm_and_command): Use reset_locator.
  52
  53 2019-07-17  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
  56         condition.
  57         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
  58         Remove condition.
  59         * tui/tui-source.c (tui_source_window_base::reset): New method.
  60         * tui/tui-layout.c (make_command_window): Don't call
  61         init_and_make_win.
  62         (make_source_window, make_disasm_window): Don't call
  63         make_source_or_disasm_window.
  64         (make_data_window): Don't call init_and_make_win.  Change calling
  65         convention.
  66         (show_source_disasm_command, show_data): Simplify.
  67         (make_source_or_disasm_window): Remove.
  68         (show_source_or_disasm_and_command): Simplify.
  69         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
  70         (struct tui_source_window_base) <reset>: Likewise.
  71         <execution_info>: Remove initializer.
  72         * tui/tui-data.c (tui_source_window_base): Initialize
  73         execution_info.
  74
  75 2019-07-17  Tom Tromey  <tom@tromey.com>
  76
  77         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
  78         variable.
  79
  80 2019-07-17  Tom Tromey  <tom@tromey.com>
  81
  82         * tui/tui.c (tui_rl_other_window): Update.
  83         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
  84         superclass method first.  Always iterate over regs_content.
  85         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
  86         method.
  87         * tui/tui-win.c (tui_set_focus_command): Update.
  88
  89 2019-07-17  Tom Tromey  <tom@tromey.com>
  90
  91         * tui/tui-win.c (tui_set_focus_command): Rename from
  92         tui_set_focus.  Call tui_enable.
  93         (tui_set_focus_command): Remove.
  94
  95 2019-07-17  Tom Tromey  <tom@tromey.com>
  96
  97         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
  98         refresh_window.
  99         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 100         touchwin.
 101         (tui_data_window::refresh_window): Call refresh_window on data
 102         items.  Always call superclass refresh_window.
 103         (tui_win_info::refresh): Remove.
 104         (tui_source_window_base::refresh_window): Update.
 105         (tui_refresh_all): Update.
 106         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 107         refresh_window.
 108         (show_source_or_disasm_and_command): Likewise.
 109         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 110         (struct tui_source_window_base) <refresh>: Likewise.
 111
 112 2019-07-17  Tom Tromey  <tom@tromey.com>
 113
 114         * tui/tui-winsource.c (tui_clear_source_content)
 115         (tui_show_source_content): Update.
 116         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 117         whether content is empty.
 118         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 119         Remove.
 120
 121 2019-07-17  Tom Tromey  <tom@tromey.com>
 122
 123         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 124         window's contents.
 125         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 126         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 127
 128 2019-07-17  Tom Tromey  <tom@tromey.com>
 129
 130         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 131         (struct tui_data_item_window): Update.
 132
 133 2019-07-17  Tom Tromey  <tom@tromey.com>
 134
 135         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 136         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 137         defines.
 138
 139 2019-07-17  Tom Tromey  <tom@tromey.com>
 140
 141         * tui/tui-winsource.h (tui_erase_source_content)
 142         (tui_clear_source_content): Remove "display_prompt" parameter.
 143         * tui/tui-winsource.c (tui_update_source_window_as_is)
 144         (tui_update_source_windows_with_addr): Update.
 145         (tui_clear_source_content): Remove "display_prompt" parameter.
 146         (tui_erase_source_content): Likewise.  Simplify.
 147         (tui_show_source_content): Update.
 148         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 149         * tui/tui-stack.c (tui_show_frame_info): Update.
 150         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 151         Remove defines.
 152
 153 2019-07-17  Tom Tromey  <tom@tromey.com>
 154
 155         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 156         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 157         parameter.
 158         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 159         parameter.
 160
 161 2019-07-17  Tom Tromey  <tom@tromey.com>
 162
 163         * tui/tui-winsource.c (tui_clear_source_content)
 164         (tui_show_source_content, tui_show_exec_info_content)
 165         (tui_clear_exec_info_content): Update.
 166         * tui/tui-stack.c (tui_show_locator_content): Update.
 167         (tui_show_frame_info): Update.
 168         * tui/tui-source.h (tui_source_window): Don't declare.
 169         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 170         from tui_source_is_displayed.
 171         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 172         Remove field.
 173         (struct tui_source_window_base) <content_in_use>: New field.  Now
 174         bool.
 175         (struct tui_source_window) <showing_source_p>: New method.
 176         (TUI_SRC_WIN): Change cast.
 177         * tui/tui-data.c (tui_initialize_static_data): Update.
 178
 179 2019-07-17  Tom Tromey  <tom@tromey.com>
 180
 181         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 182         location_matches_p.
 183         * tui/tui-source.c (tui_source_window::location_matches_p): New
 184         method.
 185         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 186         method.
 187         * tui/tui-data.h (struct tui_source_window_base)
 188         <location_matches_p>: New method.
 189         (struct tui_source_window, struct tui_disasm_window)
 190         <location_matches_p>: Likewise.
 191
 192 2019-07-17  Tom Tromey  <tom@tromey.com>
 193
 194         * tui/tui-win.c (tui_set_win_height_command): Rename from
 195         tui_set_win_height.
 196         (tui_set_win_height_command): Remove.
 197
 198 2019-07-17  Tom Tromey  <tom@tromey.com>
 199
 200         * tui/tui-source.c (tui_source_window): New constructor.  Add
 201         observer.
 202         (~tui_source_window): New destructor.
 203         (tui_source_window::style_changed): New method.
 204         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 205         (tui_attach_detach_observers): Update.
 206         * tui/tui-data.h (struct tui_source_window): Make constructor not
 207         inline.  Add destructor.
 208         (struct tui_source_window) <style_changed>: New method.
 209         <m_observable>: New member.
 210
 211 2019-07-17  Tom Tromey  <tom@tromey.com>
 212
 213         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 214         * tui/tui-win.c (tui_resize_all): Fix typo.
 215
 216 2019-07-17  Tom Tromey  <tom@tromey.com>
 217
 218         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 219         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 220         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 221         * tui/tui-win.c (window_name_completer): Use foreach.
 222         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 223         (update_tab_width): Likewise.
 224         * tui/tui-layout.c (show_layout): Update.
 225         * tui/tui-data.h (class tui_window_iterator): New.
 226         (struct all_tui_windows): New.
 227         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 228
 229 2019-07-17  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 232         parameter.  Don't reference globals.
 233         (tui_reg_command): Update.
 234
 235 2019-07-17  Tom Tromey  <tom@tromey.com>
 236
 237         * tui/tui-regs.c (tui_show_registers): Simplify.
 238
 239 2019-07-17  Tom Tromey  <tom@tromey.com>
 240
 241         * tui/tui-regs.c (tui_show_registers): Update.
 242         (tui_show_register_group): Add win_info parameter.
 243
 244 2019-07-17  Tom Tromey  <tom@tromey.com>
 245
 246         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 247         Rename from tui_display_reg_element_at_line.
 248         (tui_data_window::display_registers_from_line): Update.
 249         * tui/tui-data.h (struct tui_data_window)
 250         <display_reg_element_at_line>: New method.
 251
 252 2019-07-17  Tom Tromey  <tom@tromey.com>
 253
 254         * tui/tui-regs.h (tui_display_registers_from)
 255         (tui_display_registers_from_line): Don't declare.
 256         * tui/tui-windata.c (tui_data_window::display_all_data)
 257         (tui_data_window::refresh_all)
 258         (tui_data_window::do_scroll_vertical): Update.
 259         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 260         from tui_display_registers_from.
 261         (tui_display_reg_element_at_line): Update.
 262         (tui_data_window::display_registers_from_line): Rename from
 263         tui_display_registers_from_line.
 264         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 265         display_registers_from_line>: New methods.
 266
 267 2019-07-17  Tom Tromey  <tom@tromey.com>
 268
 269         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 270         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 271         from tui_erase_data_content.
 272         (tui_data_window::display_all_data)
 273         (tui_data_window::refresh_all)
 274         (tui_data_window::do_scroll_vertical): Update.
 275         * tui/tui-regs.c (tui_show_registers): Update.
 276         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 277         New method.
 278
 279 2019-07-17  Tom Tromey  <tom@tromey.com>
 280
 281         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 282         declare.
 283         * tui/tui-windata.c
 284         (tui_data_window::delete_data_content_windows): Rename from
 285         tui_delete_data_content_windows.
 286         (tui_data_window::display_all_data)
 287         (tui_data_window::do_scroll_vertical): Update.
 288         * tui/tui-data.h (struct tui_data_window)
 289         <delete_data_content_windows>: New method.
 290
 291 2019-07-17  Tom Tromey  <tom@tromey.com>
 292
 293         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 294         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 295
 296 2019-07-17  Tom Tromey  <tom@tromey.com>
 297
 298         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 299         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 300         from tui_display_all_data.
 301         * tui/tui-win.c
 302         (tui_data_window::do_make_visible_with_new_height): Update.
 303         * tui/tui-regs.c (tui_show_registers): Update.
 304         * tui/tui-layout.c (tui_set_layout): Update.
 305         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 306         method.
 307
 308 2019-07-17  Tom Tromey  <tom@tromey.com>
 309
 310         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 311         * tui/tui-windata.c (tui_display_data_from): Remove.
 312         (tui_data_window::refresh_all): Update.
 313
 314 2019-07-17  Tom Tromey  <tom@tromey.com>
 315
 316         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 317         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 318         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 319         tui_display_registers_from_line.
 320         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 321         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 322         "force_display" parameter.
 323
 324 2019-07-17  Tom Tromey  <tom@tromey.com>
 325
 326         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 327         declare.
 328         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 329         Rename from tui_first_reg_element_no_inline.
 330         (tui_display_reg_element_at_line)
 331         (tui_display_registers_from_line): Update.
 332         * tui/tui-data.h (struct tui_data_window)
 333         <first_reg_element_no_inline>: New method.
 334
 335 2019-07-17  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-windata.c (tui_display_data_from)
 338         (tui_data_window::do_scroll_vertical): Update.
 339         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 340         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 341         Rename from tui_line_from_reg_element_no.
 342         (tui_display_registers_from_line): Update.
 343         * tui/tui-data.h (struct tui_data_window)
 344         <line_from_reg_element_no>: New method.
 345
 346 2019-07-17  Tom Tromey  <tom@tromey.com>
 347
 348         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 349         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 350         tui_last_regs_line_no.
 351         (tui_display_reg_element_at_line)
 352         (tui_display_registers_from_line): Update.
 353         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 354         method.
 355
 356 2019-07-17  Tom Tromey  <tom@tromey.com>
 357
 358         PR tui/24722:
 359         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 360         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 361         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 362         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 363         (tui_update_breakpoint_info): Likewise.
 364         * tui/tui-hooks.c (tui_event_create_breakpoint)
 365         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 366         Update.
 367
 368 2019-07-17  Tom Tromey  <tom@tromey.com>
 369
 370         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 371
 372 2019-07-17  Tom Tromey  <tom@tromey.com>
 373
 374         * tui/tui-winsource.c (tui_update_source_window_as_is)
 375         (tui_update_source_windows_with_addr): Update.
 376         * tui/tui-source.h (tui_set_source_content)
 377         (tui_show_symtab_source): Add "win_info" parameter.
 378         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 379         parameter.
 380         (tui_show_symtab_source): Likewise.
 381
 382 2019-07-17  Tom Tromey  <tom@tromey.com>
 383
 384         * tui/tui-wingeneral.c
 385         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 386
 387 2019-07-17  Tom Tromey  <tom@tromey.com>
 388
 389         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 390         (struct tui_cmd_window) <can_scroll>: New method.
 391         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 392         method.
 393
 394 2019-07-17  Tom Tromey  <tromey@adacore.com>
 395
 396         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 397         do_field_signed>: Rename.  Change type of "value".
 398         * ui-out.c (ui_out::field_signed): Rename from field_int.
 399         Change type of "value".
 400         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 401         type of "value".
 402         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 403         do_field_int.  Change type of "value".
 404         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 405         do_field_int.  Change type of "value".
 406         * tracepoint.c (trace_status_mi, tfind_1)
 407         (print_one_static_tracepoint_marker): Update.
 408         * thread.c (print_thread_info_1, print_selected_thread_frame):
 409         Update.
 410         * stack.c (print_frame, print_frame_info): Update.
 411         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 412         Update.
 413         * source.c (print_source_lines_base): Update.
 414         * skip.c (info_skip_command): Update.
 415         * record-btrace.c (btrace_ui_out_decode_error)
 416         (btrace_call_history_src_line): Update.
 417         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 418         Update.
 419         * progspace.c (print_program_space): Update.
 420         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 421         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 422         do_field_int.  Change type of "value".
 423         * mi/mi-out.c (mi_ui_out::do_table_begin)
 424         (mi_ui_out::do_table_header): Update.
 425         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 426         type of "value".
 427         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 428         (mi_cmd_data_list_changed_registers, output_register)
 429         (mi_cmd_data_read_memory, mi_load_progress)
 430         (mi_cmd_trace_frame_collected): Update.
 431         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 432         Update.
 433         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 434         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 435         (mi_cmd_var_list_children, varobj_update_one): Update.
 436         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 437         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 438         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 439         * inferior.c (print_inferior): Update.
 440         * gdb_bfd.c (print_one_bfd): Update.
 441         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 442         Update.
 443         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 444         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 445         do_field_int.  Change type of "value".
 446         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 447         do_field_int.  Change type of "value".
 448         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 449         (print_one_breakpoint_location, print_it_catch_fork)
 450         (print_one_catch_fork, print_it_catch_vfork)
 451         (print_one_catch_vfork, print_it_catch_solib)
 452         (print_it_catch_exec, print_it_ranged_breakpoint)
 453         (print_mention_watchpoint, print_mention_masked_watchpoint)
 454         (bkpt_print_it, update_static_tracepoint): Update.
 455         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 456         * break-catch-syscall.c (print_it_catch_syscall): Update.
 457         * ada-tasks.c (print_ada_task_info): Update.
 458         * ada-lang.c (print_it_exception, print_mention_exception):
 459         Update.
 460
 461 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 462
 463         PR breakpoints/24541
 464         * gdbarch.c: Regenerate.
 465         * gdbarch.h: Regenerate.
 466         * gdbarch.sh: Adjust return type and parameter types for
 467         'stap_adjust_register'.
 468         (i386_stap_adjust_register): Adjust signature and return new
 469         register name.
 470         * stap-probe.c (stap_parse_register_operand): Adjust use of
 471         'gdbarch_stap_adjust_register'.
 472
 473 2019-07-17  Tom Tromey  <tromey@adacore.com>
 474
 475         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 476         declare VEC.
 477         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 478         std::vector.
 479         (struct s390_process_info): Add initializers.
 480         (s390_add_process): Use new.
 481         (s390_linux_nat_target::low_forget_process): Use delete.
 482         (s390_linux_nat_target::low_new_fork)
 483         (s390_linux_nat_target::stopped_by_watchpoint)
 484         (s390_linux_nat_target::low_prepare_to_resume)
 485         (s390_linux_nat_target::insert_watchpoint)
 486         (s390_linux_nat_target::insert_hw_breakpoint)
 487         (s390_linux_nat_target::remove_watchpoint)
 488         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 489
 490 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 491
 492         * aarch64-fbsd-nat.c: Include regcache.h.
 493         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 494         argument.
 495         (aarch64_fbsd_nat_target::fetch_registers)
 496         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 497         variable.
 498         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 499
 500 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 501
 502         * fbsd-nat.c: Include gdbarch.h.
 503
 504 2019-07-15  Tom Tromey  <tromey@adacore.com>
 505
 506         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 507
 508 2019-07-15  Tom Tromey  <tromey@adacore.com>
 509
 510         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 511         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 512         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 513         * cli-out.c (cli_ui_out::do_field_int): New method.
 514         * ui-out.c (ui_out::field_unsigned): New method.
 515         * symfile.c (generic_load): Use field_unsigned.
 516         (print_transfer_performance): Likewise.
 517         * record-btrace.c (ui_out_field_uint): Remove.
 518         (btrace_call_history_insn_range, btrace_call_history): Use
 519         field_unsigned.
 520         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 521         field_unsigned.
 522         * ui-out.h (class ui_out) <field_unsigned>: New method.
 523         <do_field_unsigned>: Likewise.
 524
 525 2019-07-15  Tom Tromey  <tromey@adacore.com>
 526
 527         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 528         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 529         * target.c (flash_erase_command): Use field_string.
 530         * infrun.c (print_signal_received_reason): Use field_string.
 531         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 532         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 533         field_string.
 534         * ada-tasks.c (print_ada_task_info): Use field_string.
 535
 536 2019-07-15  Tom Tromey  <tromey@adacore.com>
 537
 538         * target.c (flash_erase_command): Use field_core_addr.
 539         * symfile.c (generic_load): Use field_core_addr.
 540         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 541         Use field_core_addr.
 542         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 543         field_core_addr.
 544
 545 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 546
 547         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 548         value if its desired type is smaller than a CORE_ADDR and signed.
 549
 550 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 551
 552         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 553         of changes to field names, and use new is_reference field to
 554         decide if a property is a reference or not.
 555         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 556         field.
 557         (struct dwarf2_property_baton): Update header comment, rename
 558         'referenced_type' to 'property_type' and update comments.
 559         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 560         default property type, store in property baton, update to take
 561         accound of renamed field.
 562         (read_func_scope): Update call to attr_to_dynamic_prop.
 563         (read_array_type): Likewise.
 564         (dwarf2_per_cu_addr_sized_int_type): New function.
 565         (read_subrange_index_type): Move type finding code to
 566         dwarf2_per_cu_addr_sized_int_type.
 567         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 568         (dwarf2_per_cu_addr_type): New function.
 569         (set_die_type): Update calls to attr_to_dynamic_prop.
 570
 571 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 572
 573         * dwarf2read.c (read_subrange_index_type): New function.
 574         (read_subrange_type): Move code into new function and call it.
 575         * gdbtypes.c (create_range_type): Add some asserts.
 576
 577 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 578
 579         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 580         update return statements.
 581         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 582         declaration, and update comment to match.
 583         * gdbtypes.c (resolve_dynamic_array): Update call to
 584         dwarf2_evaluate_property to match new return type.
 585
 586 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 587
 588         * valarith.c (value_subscripted_rvalue): Change lowerbound
 589         parameter type from int to LONGEST.
 590         * value.h (value_subscripted_rvalue): Likewise in declaration.
 591
 592 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 593
 594         * cli/cli-utils.c (info_print_command_completer): New function.
 595         * cli/cli-utils.h: Add 'completer.h' include, and forward
 596         declaration for 'struct cmd_list_element'.
 597         (info_print_command_completer): Declare.
 598         * stack.c (_initialize_stack): Add completer for 'info locals' and
 599         'info args'.
 600         * symtab.c (_initialize_symtab): Add completer for 'info
 601         variables' and 'info functions'.
 602         * NEWS: Mention completion for additional info commands.
 603
 604 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 605
 606         * cli/cli-utils.c (extract_info_print_args): Delete.
 607         (extract_arg_maybe_quoted): Delete.
 608         (info_print_options_defs): New variable.
 609         (make_info_print_options_def_group): New function.
 610         (extract_info_print_options): Define new function.
 611         * cli/cli-utils.h (extract_info_print_args): Delete.
 612         (struct info_print_options): New structure.
 613         (extract_info_print_options): Declare new function.
 614         * stack.c (info_locals_command): Update to use new
 615         extract_info_print_options, also add a header comment.
 616         (info_args_command): Likewise.
 617         * symtab.c (info_variables_command): Likewise.
 618         (info_functions_command): Likewise.
 619
 620 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 621
 622         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 623         to extract string arguments.
 624         * common/common-utils.c (extract_string_maybe_quoted): New function.
 625         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 626
 627 2019-07-11  Tom Tromey  <tromey@adacore.com>
 628
 629         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 630         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 631         * top.h (gdbinit): Don't declare.
 632         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 633         into...
 634         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 635         * top.c (gdb_init): Don't call init_cli_cmds.
 636         (gdbinit): Remove.
 637         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 638
 639 2019-07-11  Tom Tromey  <tromey@adacore.com>
 640
 641         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 642         after it has been moved.
 643
 644 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 645
 646         * valops.c (value_must_coerce_to_target): Change return type to
 647         bool.
 648         * value.h (value_must_coerce_to_target): Likewise.
 649
 650 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 651
 652         * breakpoint.c (is_hardware_watchpoint): Remove
 653         forward-declaration.
 654         (is_masked_watchpoint): Change return type to bool.
 655         (is_tracepoint): Likewise.
 656         (is_breakpoint): Likewise.
 657         (is_hardware_watchpoint): Likewise.
 658         (is_watchpoint): Likewise.
 659         (is_no_memory_software_watchpoint): Likewise.
 660         (is_catchpoint): Likewise.
 661         (breakpoint_1): Make FILTER parameter's return type bool.
 662         is_masked_watchpoint): Change return type to bool.
 663         (save_breakpoints): Make FILTER parameter's return type bool.
 664         * breakpoint.h (is_breakpoint): Change return type to bool.
 665         (is_watchpoint): Likewise.
 666         (is_catchpoint): Likewise.
 667         (is_tracepoint): Likewise.
 668
 669 2019-07-10  Tom Tromey  <tom@tromey.com>
 670
 671         * defs.h: Don't include gdbarch.h.
 672         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 673         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 674         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 675         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 676         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 677         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 678         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 679         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 680         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 681         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 682         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 683         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 684         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 685         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 686         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 687         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 688         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 689         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 690         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 691         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 692         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 693         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 694         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 695         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 696         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 697         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 698         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 699
 700 2019-07-10  Tom Tromey  <tromey@adacore.com>
 701
 702         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 703         * breakpoint.c (init_ada_exception_breakpoint): Register as
 704         bp_catchpoint.
 705         (print_one_breakpoint_location, print_one_breakpoint): Use
 706         is_ada_exception_catchpoint.
 707         * ada-lang.c (class ada_catchpoint_location): Pass
 708         bp_loc_software_breakpoint to bp_location constructor.
 709         (is_ada_exception_catchpoint): New function.
 710
 711 2019-07-10  Tom Tromey  <tromey@adacore.com>
 712
 713         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 714         VEC.
 715         (struct arm_exidx_entry): New method operator<.
 716         (struct arm_exidx_data) <section_maps>: Change type.
 717         (arm_exidx_data_free): Remove.
 718         (arm_exidx_data_key): Change type.  Move lower.
 719         (arm_exidx_new_objfile): Update.
 720         (arm_compare_exidx_entries): Remove.
 721         (arm_find_exidx_entry, _initialize_arm_tdep)
 722
 723 2019-07-10  Tom Tromey  <tromey@adacore.com>
 724
 725         * solib-spu.c (ocl_program_data_key): Change type.
 726         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 727         Update.
 728
 729 2019-07-10  Tom Tromey  <tromey@adacore.com>
 730
 731         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 732         (struct solib_aix_inferior_data) <library_list>: Change type.
 733         (solib_aix_inferior_data_handle): Change type.
 734         (get_solib_aix_inferior_data): Update.
 735         (solib_aix_free_library_list): Remove.
 736         (library_list_start_library): Update.
 737         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 738         return type.
 739         (solib_aix_get_library_list)
 740         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 741         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 742
 743 2019-07-10  Tom Tromey  <tromey@adacore.com>
 744
 745         * solib-dsbt.c (struct dsbt_info): Add initializers.
 746         (solib_dsbt_pspace_data): Change type.
 747         (dsbt_pspace_data_cleanup): Remove.
 748         (get_dsbt_info, _initialize_dsbt_solib): Update.
 749
 750 2019-07-10  Tom Tromey  <tromey@adacore.com>
 751
 752         * spu-tdep.c (spu_overlay_data): Change type.
 753         (spu_get_overlay_table, spu_overlay_new_objfile)
 754         (_initialize_spu_tdep): Update.
 755
 756 2019-07-10  Tom Tromey  <tromey@adacore.com>
 757
 758         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 759         destructor.
 760         (dbx_objfile_data_key): Change type and declare later.
 761         (DBX_SYMFILE_INFO): Rewrite.
 762         * dbxread.c (dbx_objfile_data_key): Change type.
 763         (dbx_symfile_init): Update.
 764         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 765         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 766         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 767
 768 2019-07-10  Tom Tromey  <tromey@adacore.com>
 769
 770         * jit.c (jit_program_space_key): Change type.  Move lower.
 771         (get_jit_program_space_data): Update.
 772         (jit_program_space_data_cleanup): Remove.
 773         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 774         Update.
 775         (struct jit_program_space_data): Add initializers.
 776
 777 2019-07-10  Tom Tromey  <tromey@adacore.com>
 778
 779         * solib-darwin.c (struct darwin_info): Add initializers.
 780         (solib_darwin_pspace_data): Change type.
 781         (darwin_pspace_data_cleanup): Remove.
 782         (get_darwin_info, _initialize_darwin_solib): Update.
 783
 784 2019-07-10  Tom Tromey  <tromey@adacore.com>
 785
 786         * remote-sim.c (struct sim_inferior_data): Add initializers,
 787         constructor, and destructor.
 788         (sim_inferior_data_key): Change type.  Move lower.
 789         (check_for_duplicate_sim_descriptor): Update.
 790         (get_sim_inferior_data): Use new.  Update.
 791         (~sim_inferior_data_cleanup): Rename from
 792         sim_inferior_data_cleanup.  Simplify.
 793         (gdbsim_close_inferior, simulator_command)
 794         (sim_command_completer, _initialize_remote_sim): Update.
 795         (next_pid, INITIAL_PID): Move earlier.
 796
 797 2019-07-10  Tom Tromey  <tromey@adacore.com>
 798
 799         * python/python-internal.h (create_thread_object): Return
 800         gdbpy_ref.
 801         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 802         * python/py-inferior.c (struct threadlist_entry): Add
 803         constructor.
 804         <thread_obj>: Now a gdbpy_ref.
 805         (thread_to_thread_object): Update.
 806         (add_thread_object): Use new.
 807         (delete_thread_object): Use delete.
 808         (infpy_threads): Update.
 809         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 810         GIL.
 811
 812 2019-07-10  Tom Tromey  <tromey@adacore.com>
 813
 814         * valops.c (value_cast): Specialize error message for Ada.
 815
 816 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 817
 818         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 819
 820 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 821
 822         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 823         bpstat_should_step): Return bool, adjust comments.
 824         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 825         bpstat_should_step): Likewise.
 826
 827 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 828
 829         * features/Makefile: Use feature target descriptions for Arm.
 830         * features/arm/arm-core.c: Generate new file.
 831         * features/arm/arm-fpa.c: Likewise.
 832         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 833         * features/arm/arm-m-profile.c: Likewise.
 834         * features/arm/arm-vfpv2.c: Likewise.
 835         * features/arm/arm-vfpv3.c: Likewise.
 836         * features/arm/xscale-iwmmxt.c: Likewise.
 837         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 838
 839 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 840
 841         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 842         ptrace earlier.
 843
 844 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 845
 846         * features/aarch64-pauth.c: Regenerate.
 847
 848 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 849
 850         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 851         bool.
 852         (bpstat_what): Use false instead of 0.
 853
 854 2019-07-09  Pedro Alves  <palves@redhat.com>
 855
 856         * break-catch-throw.c (is_exception_catchpoint): New.
 857         * breakpoint.c (print_one_breakpoint_location): New parameter
 858         'raw_loc'.  Handle it.  Use
 859         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 860         looking at the breakpoint's type.
 861         (print_one_breakpoint): If handling "maint info breakpoints", also
 862         print locations of exception catchpoints.
 863         * breakpoint.h (is_exception_catchpoint): Declare.
 864
 865 2019-07-09  Pedro Alves  <palves@redhat.com>
 866
 867         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 868         "addr" field.
 869         (allocate_location_exception_catchpoint): New.
 870         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 871         (initialize_throw_catchpoint_ops): Install
 872         allocate_location_exception_catchpoint as allocate_location
 873         method.
 874         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 875         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 876         bp_loc_other.
 877         (breakpoint_address_is_meaningful): Delete.
 878         (bl_address_is_meaningful): New.
 879         (breakpoint_locations_match): Adjust comment.
 880         (bp_location_from_bp_type): New, factored out of...
 881         (bp_location::bp_location(breakpoint *)): ... this.
 882         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 883         factored out of...
 884         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 885         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 886         breakpoint_address_is_meaningful.
 887         (bp_locations_compare): Adjust comment.
 888         (update_global_location_list): Use bl_address_is_meaningful
 889         instead of breakpoint_address_is_meaningful.
 890         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 891         explicit.
 892         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 893         * python/py-breakpoint.c (bppy_get_location): No longer check
 894         whether location is null.
 895
 896 2019-07-09  Pedro Alves  <palves@redhat.com>
 897
 898         PR c++/15468
 899         * breakpoint.c (print_one_breakpoint_location): Remove
 900         single-location assert.
 901
 902 2019-07-09  Tom Tromey  <tom@tromey.com>
 903
 904         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 905         * configure: Rebuild.
 906         * configure.ac: Change common to gdbsupport.
 907         * gdbsupport: Rename from common.
 908         * acinclude.m4: Change common to gdbsupport.
 909         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 910         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 911         gdbsupport.
 912         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 913         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 914         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 915         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 916         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 917         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 918         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 919         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 920         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 921         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 922         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 923         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 924         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 925         coff-pe-read.c, command.h, compile/compile-c-support.c,
 926         compile/compile-c.h, compile/compile-cplus-symbols.c,
 927         compile/compile-cplus-types.c, compile/compile-cplus.h,
 928         compile/compile-loc2c.c, compile/compile.c, completer.c,
 929         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 930         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 931         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 932         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 933         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 934         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 935         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 936         features/aarch64-core.c, features/aarch64-fpu.c,
 937         features/aarch64-pauth.c, features/aarch64-sve.c,
 938         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 939         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 940         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 941         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 942         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 943         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 944         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 945         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 946         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 947         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 948         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 949         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 950         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 951         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 952         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 953         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 954         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 955         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 956         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 957         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 958         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 959         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 960         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 961         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 962         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 963         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 964         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 965         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 966         minsyms.c, mips-linux-tdep.c, namespace.h,
 967         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 968         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 969         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 970         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 971         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 972         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 973         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 974         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 975         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 976         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 977         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 978         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 979         procfs.c, producer.c, progspace.h, psymtab.h,
 980         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 981         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 982         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 983         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 984         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 985         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 986         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 987         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 988         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 989         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 990         target-memory.c, target.c, target.h, target/waitstatus.c,
 991         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 992         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 993         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 994         unittests/array-view-selftests.c,
 995         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 996         unittests/common-utils-selftests.c,
 997         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 998         unittests/format_pieces-selftests.c,
 999         unittests/function-view-selftests.c,
1000         unittests/lookup_name_info-selftests.c,
1001         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1002         unittests/mkdir-recursive-selftests.c,
1003         unittests/observable-selftests.c,
1004         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1005         unittests/parse-connection-spec-selftests.c,
1006         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1007         unittests/scoped_fd-selftests.c,
1008         unittests/scoped_mmap-selftests.c,
1009         unittests/scoped_restore-selftests.c,
1010         unittests/string_view-selftests.c, unittests/style-selftests.c,
1011         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1012         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1013         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1014         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1015         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1016         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1017
1018 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1019
1020         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1021         bool value.
1022         (decode_digits_ordinary): Set explicit_line field in sal.
1023         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1024         symtab_and_line that was set on an explicit line number in
1025         assembler code.  Do always update the recorded symtab and line if
1026         we do skip the prologue.
1027
1028 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1029
1030         * breakpoint.c (set_breakpoint_location_function): Remove
1031         explicit_loc parameter.
1032         (momentary_breakpoint_from_master): Update call to
1033         set_breakpoint_location_function.
1034         (add_location_to_breakpoint): Likewise.
1035
1036 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1037
1038         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1039         required features based on default bfd type when no specific bfd
1040         is present.
1041
1042 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1043
1044         * NEWS: Mention that GDB printf and eval commands can now print
1045         C-style and Ada-style convenience var strings without
1046         calling the inferior.
1047         * printcmd.c (printf_c_string): Locally print GDB internal var
1048         instead of transiting via the inferior.
1049         (printf_wide_c_string): Likewise.
1050
1051 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1052
1053         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1054
1055 2019-07-04  Tom Tromey  <tom@tromey.com>
1056
1057         PR tui/24724:
1058         * tui/tui-winsource.c (tui_clear_source_content): Update.
1059         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1060         (tui_update_breakpoint_info): Update.
1061         (tui_set_exec_info_content): Update.
1062         * tui/tui-source.c (tui_set_source_content_nil): Update.
1063         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1064         has_break.
1065         * tui/tui-data.h (enum tui_bp_flag): New.
1066         (tui_bp_flags): New enum flags type.
1067         (struct tui_source_element) <break_mode>: Change type.  Rename
1068         from has_break.
1069         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1070         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1071         constants.
1072         * tui/tui-winsource.h: Fix comment.
1073
1074 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1075
1076         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1077         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1078         (store_fpregs_to_thread)
1079         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1080         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1081         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1082         (IWMMXT_REGS_SIZE): Add define.
1083         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1084         (fetch_vfp_regs, store_vfp_regs)
1085         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1086         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1087
1088 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1089
1090         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1091         defines.
1092         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1093         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1094         (ARM_INT_REGISTER_SIZE): ...to this.
1095         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1096         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1097         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1098         (arm_linux_collect_gregset, supply_nwfpe_register)
1099         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1100         defines.
1101         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1102         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1103         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1104         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1105         (arm_return_in_memory, arm_store_return_value)
1106         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1107         (arm_record_ld_st_multiple): Likewise.
1108         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1109         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1110
1111 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1112
1113         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1114         AARCH64_DISPLACED_MODIFIED_INSNS.
1115         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1116         (aarch64_displaced_step_copy_insn): Likewise.
1117         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1118         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1119         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1120         ARM_DISPLACED_MODIFIED_INSNS.
1121         * arm-tdep.c (arm_gdbarch_init): Likewise.
1122         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1123         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1124         (struct arm_displaced_step_closure): Use
1125         ARM_DISPLACED_MODIFIED_INSNS.
1126
1127 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1128
1129         * features/Makefile: Remove unused xml files.
1130         * features/aarch64.xml: Remove.
1131         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1132         * features/i386/amd64-avx-avx512.xml: Remove.
1133         * features/i386/amd64-avx-linux.xml: Remove.
1134         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1135         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1136         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1137         * features/i386/amd64-avx-mpx.xml: Remove.
1138         * features/i386/amd64-avx.xml: Remove.
1139         * features/i386/amd64-linux.xml: Remove.
1140         * features/i386/amd64-mpx-linux.xml: Remove.
1141         * features/i386/amd64-mpx.xml: Remove.
1142         * features/i386/amd64.xml: Remove.
1143         * features/i386/i386-avx-avx512-linux.xml: Remove.
1144         * features/i386/i386-avx-avx512.xml: Remove.
1145         * features/i386/i386-avx-linux.xml: Remove.
1146         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1147         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1148         * features/i386/i386-avx-mpx-linux.xml: Remove.
1149         * features/i386/i386-avx-mpx.xml: Remove.
1150         * features/i386/i386-avx.xml: Remove.
1151         * features/i386/i386-linux.xml: Remove.
1152         * features/i386/i386-mmx-linux.xml: Remove.
1153         * features/i386/i386-mmx.xml: Remove.
1154         * features/i386/i386-mpx-linux.xml: Remove.
1155         * features/i386/i386-mpx.xml: Remove.
1156         * features/i386/i386.xml: Remove.
1157         * features/i386/x32-avx-avx512-linux.xml: Remove.
1158         * features/i386/x32-avx-linux.xml: Remove.
1159         * features/i386/x32-linux.xml: Remove.
1160
1161 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1162
1163         * regformats/aarch64.dat: Remove.
1164         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1165         * regformats/i386/amd64-avx-linux.dat: Remove.
1166         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1167         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1168         * regformats/i386/amd64-linux.dat: Remove.
1169         * regformats/i386/amd64-mpx-linux.dat: Remove.
1170         * regformats/i386/amd64.dat: Remove.
1171         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1172         * regformats/i386/i386-avx-linux.dat: Remove.
1173         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1174         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1175         * regformats/i386/i386-linux.dat: Remove.
1176         * regformats/i386/i386-mmx-linux.dat: Remove.
1177         * regformats/i386/i386-mpx-linux.dat: Remove.
1178         * regformats/i386/i386.dat: Remove.
1179         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1180         * regformats/i386/x32-avx-linux.dat: Remove.
1181         * regformats/i386/x32-linux.dat: Remove.
1182
1183 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1184
1185         * aarch64-tdep.c: Remove xml self tests.
1186         * amd64-linux-tdep.c: Likewise.
1187         * amd64-tdep.c: Likewise.
1188         * i386-linux-tdep.c: Likewise.
1189         * i386-tdep.c: Likewise.
1190
1191 2019-07-03  Pedro Alves  <palves@redhat.com>
1192
1193         PR cli/24732
1194         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1195         (pipe_cmd_option_defs): New.
1196         (make_pipe_cmd_options_def_group): New.
1197         (pipe_command): Use gdb::option::process_options.
1198         (pipe_command_completer): New function.
1199         (_initialize_cli_cmds): Install completer for "pipe" command.
1200
1201 2019-07-03  Pedro Alves  <palves@redhat.com>
1202
1203         * cli/cli-option.c (union option_value) <string>: New field.
1204         (struct option_def_and_value): Add ctor, move ctor, dtor and
1205         use DISABLE_COPY_AND_ASSIGN.
1206         (option_def_and_value::clear_value): New.
1207         (parse_option, save_option_value_in_ctx, get_val_type_str)
1208         (add_setshow_cmds_for_options): Handle var_string.
1209         * cli-option.h (union option_def::var_address) <string>: New
1210         field.
1211         (struct string_option_def): New.
1212         * maint-test-options.c (struct test_options_opts): Add default
1213         ctor and use DISABLE_COPY_AND_ASSIGN.
1214         <string_opt>: New field.
1215         (test_options_opts::~test_options_opts): New.
1216         (test_options_opts::dump): Also dump "-string".
1217         (test_options_option_defs): Install "string.
1218
1219 2019-07-03  Pedro Alves  <palves@redhat.com>
1220
1221         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1222         option_value with a null enumeration.
1223         (complete_options): Save the option values in the context.
1224         (save_option_value_in_ctx): New, factored out from ...
1225         (process_options): ... here.
1226         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1227         of the function.
1228         * maint-test-options.c (test_options_opts::dump): New, factored
1229         out from ...
1230         (maintenance_test_options_command_mode): ... here.
1231         (maintenance_test_options_command_completion_result): Delete.
1232         (maintenance_test_options_command_completion_text): Update
1233         comment.
1234         (maintenance_show_test_options_completion_result): Change
1235         prototype.  Just print
1236         maintenance_test_options_command_completion_text.
1237         (save_completion_result): New.
1238         (maintenance_test_options_completer_mode): Pass options context to
1239         complete_options, and then save a dump.
1240         (_initialize_maint_test_options): Use add_cmd to install "maint
1241         show test-options-completion-result".
1242
1243 2019-07-03  Pedro Alves  <palves@redhat.com>
1244
1245         * NEWS (New commands): Mention "with" and "maint with".
1246         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1247         (with_command, with_command_completer): New.
1248         (pipe_command): Adjust to new repeat_previous
1249         interface.
1250         (_initialize_cli_cmds): Install the "with" command and its "w"
1251         alias.
1252         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1253         declarations.
1254         * cli/cli-setshow.c (parse_cli_var_uinteger)
1255         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1256         argument strings for all var_types.
1257         (get_setshow_command_value_string): New, factored out from ...
1258         (do_show_command): ... this.
1259         * cli/cli-setshow.h: Include <string>.
1260         (get_setshow_command_value_string): Declare.
1261         * command.h (repeat_previous): Now returns const char *.  Adjust
1262         comment.
1263         * maint.c: Include "cli/cli-cmds.h".
1264         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1265         (_initialize_maint_cmds): Register the "maintenance with" command.
1266         * top.c (repeat_previous): Move bits from pipe_command here:
1267         Return the saved command line, if any; error out if there's no
1268         command to relaunch.
1269
1270 2019-07-03  Pedro Alves  <palves@redhat.com>
1271
1272         * NEWS (New commands): Mention "maint set/show test-settings"
1273         instead of "maint test-settings".
1274         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1275         (maintenance_test_settings_set_list): Rename to ...
1276         (maintenance_set_test_settings_list): ... this.
1277         (maintenance_test_settings_show_list): Rename to  ...
1278         (maintenance_show_test_settings_list): ... this.
1279         (maintenance_test_settings_cmd): Delete.
1280         (maintenance_test_settings_set_cmd): ...
1281         (maintenance_set_test_settings_cmd): ... this.
1282         (maintenance_test_settings_show_cmd): ...
1283         (maintenance_show_test_settings_cmd): ... this.
1284         (maintenance_test_settings_show_value_cmd):
1285         (maintenance_show_test_settings_value_cmd): ... this.
1286         (_initialize_maint_test_settings): No longer install the "maint
1287         test-settings" prefix command.  Rename "maint test-settings set"
1288         to "maint set test-settings", and "maint test-settings show" to
1289         "maint show test-settings".  Adjust all subcommands.
1290
1291 2019-07-03  Pedro Alves  <palves@redhat.com>
1292
1293         * maint-test-settings.c: Fix file's intro comment.  Replace all
1294         references to "test-options" with references to "test-settings",
1295         in comments.
1296
1297 2019-07-03  Pedro Alves  <palves@redhat.com>
1298
1299         * maint-test-settings.c (maintenance_test_settings_xxx)
1300         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1301         New.
1302         (maintenance_test_settings_enums): Use them.
1303         (maintenance_test_settings_enum): Default to
1304         maintenance_test_settings_xxx.
1305         (_initialize_maint_test_settings): Initialize
1306         MAINTENANCE_TEST_SETTINGS_FILENAME.
1307
1308 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1309
1310         * breakpoint.h (remove_breakpoints_inf): Change return type to
1311         void, move function documentation here.
1312         * breakpoint.c (remove_breakpoints_inf): Change return type to
1313         void, move function documentation to header.
1314
1315 2019-07-02  Pedro Alves  <palves@redhat.com>
1316
1317         * NEWS (Completion improvements): Mention "info threads".
1318         * thread.c (struct info_threads_opts, info_threads_option_defs)
1319         (make_info_threads_options_def_group): New.
1320         (info_threads_command): Use gdb::option::process_options.
1321         (info_threads_command_completer): New.
1322         (_initialize_thread): Use gdb::option::build_help to build the
1323         help text for "info threads".
1324
1325 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1326
1327         * defs.h (generic_load): Move from here...
1328         * symfile.h (generic_load): ... to here.  Rename name parameter
1329         to args.
1330         * symfile.c (generic_load): Add comment.
1331
1332 2019-07-01  Tom Tromey  <tromey@adacore.com>
1333
1334         * dwarf2read.c
1335         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1336         declaration of without_params.  Fix formatting.
1337
1338 2019-07-01  Tom Tromey  <tromey@adacore.com>
1339
1340         * ada-exp.y (find_primitive_type): Update.
1341         * ada-lang.h (ada_lookup_symbol): Update.
1342         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1343         parameter.
1344         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1345
1346 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1347
1348         PR breakpoints/24541
1349         * gdbarch.c: Regenerate.
1350         * gdbarch.h: Regenerate.
1351         * gdbarch.sh: Add 'stap_adjust_register'.
1352         * i386-tdep.c: Include '<unordered_set>'.
1353         (i386_stap_adjust_register): New function.
1354         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1355         * stap-probe.c (stap_parse_register_operand): Call
1356         'gdbarch_stap_adjust_register'.
1357
1358 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1359
1360         PR python/24742
1361         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1362         * python/python.c (do_start_initialization): Use 'xmalloc'
1363         instead of 'PyMem_Malloc'.
1364
1365 2019-06-28  Tom Tromey  <tromey@adacore.com>
1366
1367         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1368         for Ada.
1369
1370 2019-06-27  Tom Tromey  <tromey@adacore.com>
1371
1372         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1373         objfile_key.
1374         (arm_find_mapping_symbol, arm_record_special_symbol)
1375         (_initialize_arm_tdep): Update.
1376         (arm_objfile_data_free): Remove.
1377
1378 2019-06-27  Tom Tromey  <tromey@adacore.com>
1379
1380         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1381         to cp_print_static_field.
1382
1383 2019-06-26  Tom Tromey  <tromey@adacore.com>
1384
1385         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1386         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1387         declare.
1388
1389 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1390
1391         * features/aarch64-core.c (create_feature_aarch64_core):
1392         Regenerate.
1393         * features/aarch64-core.xml: Add cpsr flags.
1394
1395 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1396
1397         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1398         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1399
1400 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1401
1402         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1403         field.
1404         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1405         use.
1406         (arm_record_special_symbol): Don't insert new symbol in sorted
1407         position, push it at the end.
1408
1409 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1410
1411         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1412         (arm_mapping_symbol_s): Remove.
1413         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1414         (arm_mapping_symbol_vec): New typedef.
1415         (struct arm_per_objfile): Add constructor.
1416         <section_maps>: Change type to
1417         std::unique_ptr<arm_mapping_symbol_vec[]>.
1418         (arm_compare_mapping_symbols): Remove.
1419         (arm_find_mapping_symbol): Adjust to section_maps type change.
1420         (arm_objfile_data_free): Call delete on arm_per_objfile.
1421         (arm_record_special_symbol): Adjust to section_maps type change.
1422         Allocate arm_per_objfile with new.
1423
1424 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1425
1426         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1427         with the command prefix.
1428
1429 2019-06-25  Tom Tromey  <tom@tromey.com>
1430
1431         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1432         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1433
1434 2019-06-25  Tom Tromey  <tom@tromey.com>
1435
1436         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1437         type.
1438         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1439         protected.
1440
1441 2019-06-25  Tom Tromey  <tom@tromey.com>
1442
1443         * tui/tui-winsource.c
1444         (tui_source_window_base::set_is_exec_point_at): Add check against
1445         LOA_ADDRESS.
1446
1447 2019-06-25  Tom Tromey  <tom@tromey.com>
1448
1449         * tui/tui-source.c (tui_set_source_content): Don't check before
1450         xfree.
1451         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1452
1453 2019-06-25  Tom Tromey  <tom@tromey.com>
1454
1455         * tui/tui-winsource.h (tui_update_source_window_as_is)
1456         (tui_alloc_source_buffer, tui_line_is_displayed)
1457         (tui_addr_is_displayed): Change type of win_info.
1458         * tui/tui-winsource.c (tui_update_source_window_as_is)
1459         (tui_clear_source_content, tui_show_source_line)
1460         (tui_show_source_content, tui_source_window_base::refill)
1461         (tui_source_window_base::set_is_exec_point_at)
1462         (tui_source_window_base::set_is_exec_point_at)
1463         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1464         (tui_alloc_source_buffer, tui_line_is_displayed)
1465         (tui_addr_is_displayed): Change type of win_info.  Update.
1466         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1467         (tui_source_window_base::do_make_visible_with_new_height):
1468         Update.
1469         * tui/tui-source.c (tui_set_source_content)
1470         (tui_set_source_content_nil)
1471         (tui_source_window::do_scroll_vertical): Update.
1472         * tui/tui-layout.c (show_layout): Update.
1473         * tui/tui-disasm.c (tui_set_disassem_content)
1474         (tui_disasm_window::do_scroll_vertical): Update.
1475         * tui/tui-data.h (tui_win_content): Remove.
1476         (struct tui_gen_win_info) <content, content_size>: Remove.
1477         (struct tui_source_element): Add initializers and destructor.
1478         (union tui_which_element, struct tui_win_element): Remove.
1479         (struct tui_source_window_base) <content>: New field.
1480         (struct tui_data_window): Remove destructor.
1481         (tui_alloc_content, tui_free_win_content)
1482         (tui_free_all_source_wins_content): Don't declare.
1483         * tui/tui-data.c (tui_initialize_static_data): Update.
1484         (init_content_element, tui_alloc_content): Remove.
1485         (~tui_gen_win_info): Update.
1486         (~tui_data_window, tui_free_all_source_wins_content)
1487         (tui_free_win_content, free_content, free_content_elements):
1488         Remove.
1489
1490 2019-06-25  Tom Tromey  <tom@tromey.com>
1491
1492         * tui/tui-winsource.h (tui_clear_source_content)
1493         (tui_erase_source_content, tui_show_source_content): Change type
1494         of win_info.
1495         * tui/tui-winsource.c (tui_clear_source_content)
1496         (tui_erase_source_content, tui_show_source_content): Change type
1497         of win_info.
1498         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1499         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1500         win_info.
1501         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1502         win_info.
1503         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1504
1505 2019-06-25  Tom Tromey  <tom@tromey.com>
1506
1507         * tui/tui-winsource.c (tui_clear_source_content)
1508         (tui_source_window_base::set_is_exec_point_at): Update.
1509         * tui/tui-source.c (tui_set_source_content_nil): Update.
1510         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1511         a bool.
1512         * tui/tui-data.c (init_content_element): Update.
1513
1514 2019-06-25  Tom Tromey  <tom@tromey.com>
1515
1516         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1517         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1518         * tui/tui-layout.c (init_and_make_win): Update.
1519         * tui/tui.h (enum tui_win_type): Update.
1520         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1521         tui_win_is_auxillary.
1522         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1523         tui_win_is_auxillary.
1524
1525 2019-06-25  Tom Tromey  <tom@tromey.com>
1526
1527         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1528         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1529         (tui_delete_data_content_windows, tui_display_all_data)
1530         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1531         Update.
1532         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1533         * tui/tui-regs.c (tui_last_regs_line_no)
1534         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1535         (tui_show_registers): Update.
1536         (tui_show_register_group): Return void.  Update.
1537         (tui_display_registers_from, tui_display_reg_element_at_line)
1538         (tui_display_registers_from_line, tui_check_register_values):
1539         Update.
1540         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1541         member.
1542         (struct tui_data_window) <regs_content>: Now a std::vector.
1543         <regs_content_count>: Remove.
1544         (tui_add_content_elements, tui_free_data_content): Don't declare.
1545         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1546         (init_content_element): Remove DATA_WIN case.  Add assert.
1547         (tui_add_content_elements): Remove.
1548         (tui_data_window): Update.
1549         (tui_free_data_content): Remove.
1550         (free_content_elements): Remove DATA_WIN case.
1551
1552 2019-06-25  Tom Tromey  <tom@tromey.com>
1553
1554         * tui/tui-data.c (tui_data_item_window): Update.
1555         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1556         * tui/tui-windata.c (tui_display_all_data)
1557         (tui_display_data_from_line): Update.
1558         (tui_check_data_values): Remove.
1559         * tui/tui-regs.c (tui_show_register_group)
1560         (tui_display_reg_element_at_line): Update.
1561         * tui/tui-hooks.c (tui_register_changed)
1562         (tui_refresh_frame_and_register_information): Call
1563         tui_check_register_values.
1564         * tui/tui-data.h (struct tui_data_window) <data_content,
1565         data_content_count, data_type>: Remove.
1566         (enum tui_data_type): Remove.
1567
1568         * tui/tui-data.c (tui_data_window::clear_detail)
1569         (~tui_data_window): Update.
1570
1571 2019-06-25  Tom Tromey  <tom@tromey.com>
1572
1573         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1574         declare.
1575         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1576         Rename from tui_first_data_item_displayed.  Update.
1577         (tui_data_window::refresh_all)
1578         (tui_data_window::do_scroll_vertical): Update.
1579         * tui/tui-data.h (struct tui_data_window)
1580         <first_data_item_displayed>: Declare new method.
1581
1582 2019-06-25  Tom Tromey  <tom@tromey.com>
1583
1584         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1585         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1586         contents...
1587         (tui_initialize_static_data): ...here.
1588
1589 2019-06-25  Tom Tromey  <tom@tromey.com>
1590
1591         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1592         (tui_display_registers_from, tui_check_register_values): Update.
1593         (tui_display_register): Remove win_info parameter; update.
1594         (tui_get_register): Change type of parameters.
1595         * tui/tui-data.h (struct tui_data_element): Remove.
1596         (union tui_which_element) <data>: Remove.
1597         <data_window>: Change type.
1598         (struct tui_data_item_window): New.
1599         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1600         case.  Add assert.
1601         (~tui_data_item_window): New destructor.
1602         (free_content_elements): Remove DATA_ITEM_WIN case.
1603
1604 2019-06-25  Tom Tromey  <tom@tromey.com>
1605
1606         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1607         Remove.
1608
1609 2019-06-25  Tom Tromey  <tom@tromey.com>
1610
1611         * tui/tui-data.h (struct tui_command_element): Remove.
1612         (union tui_which_element) <command>: Remove.
1613         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1614         assert.
1615         (free_content_elements): Remove CMD_WIN case.
1616
1617 2019-06-25  Tom Tromey  <tom@tromey.com>
1618
1619         * tui/tui-layout.c (tui_set_layout): Update.
1620         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1621         * tui/tui-data.c (layout_def): Update.
1622
1623 2019-06-25  Tom Tromey  <tom@tromey.com>
1624
1625         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1626         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1627         (tui_source_window_base::set_new_height): Update.
1628         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1629         Update.
1630         (tui_set_locator_fullname, tui_set_locator_info)
1631         (tui_show_frame_info): Update.
1632         * tui/tui-source.c (tui_set_source_content)
1633         (tui_source_is_displayed): Update.
1634         * tui/tui-layout.c (show_source_disasm_command, show_data)
1635         (show_source_or_disasm_and_command): Update.
1636         * tui/tui-disasm.c (tui_set_disassem_content)
1637         (tui_get_begin_asm_address): Update.
1638         * tui/tui-data.h (struct tui_locator_element): Remove.
1639         (union tui_which_element) <locator>: Remove.
1640         (struct tui_locator_window): New.
1641         (tui_locator_win_info_ptr): Change return type.
1642         * tui/tui-data.c (_locator): Change type.
1643         (tui_locator_win_info_ptr): Change return type.
1644         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1645         (tui_alloc_content): Add assert.
1646
1647 2019-06-25  Tom Tromey  <tom@tromey.com>
1648
1649         * tui/tui-winsource.c
1650         (tui_exec_info_window::maybe_allocate_content): New method.
1651         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1652         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1653         (make_source_or_disasm_window): Add cast.
1654         * tui/tui-data.h (union tui_which_element) <simple_string>:
1655         Remove.
1656         (struct tui_source_info): New.
1657         (struct tui_source_window_base) <execution_info>: Change type.
1658         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1659         case, and add assert.
1660         (tui_alloc_content): Add assert.
1661
1662 2019-06-25  Tom Tromey  <tom@tromey.com>
1663
1664         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1665         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1666         * tui/tui-data.c (tui_alloc_win_info): Remove.
1667
1668 2019-06-25  Tom Tromey  <tom@tromey.com>
1669
1670         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1671         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1672         can_highlight.
1673
1674 2019-06-25  Tom Tromey  <tom@tromey.com>
1675
1676         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1677         make_visible_with_new_height method.
1678         (tui_win_info::make_visible_with_new_height): New method.
1679         (tui_source_window_base::do_make_visible_with_new_height)
1680         (tui_data_window::do_make_visible_with_new_height)
1681         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1682         (make_visible_with_new_height): Remove.
1683         (tui_resize_all, tui_adjust_win_heights): Use
1684         make_visible_with_new_height method.
1685         * tui/tui-data.h (struct tui_win_info)
1686         <do_make_visible_with_new_height, make_visible_with_new_height>:
1687         New methods.
1688         (struct tui_source_window_base, struct tui_data_window)
1689         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1690         methods.
1691
1692 2019-06-25  Tom Tromey  <tom@tromey.com>
1693
1694         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1695         method.
1696         (update_tab_width): Call update_tab_width method.
1697         * tui/tui-data.h (struct tui_win_info)
1698         (struct tui_source_window_base) <update_tab_width>: New methods.
1699
1700 2019-06-25  Tom Tromey  <tom@tromey.com>
1701
1702         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1703         parameter.
1704         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1705         parameter.
1706         (tui_gen_win_info::make_visible): Update.
1707         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1708         parameter.
1709         * tui/tui-data.h (enum tui_box): New enum.
1710         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1711
1712 2019-06-25  Tom Tromey  <tom@tromey.com>
1713
1714         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1715         init_and_make_win for EXEC_INFO_WIN.
1716         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1717         longer inline.
1718         (struct tui_win_info) <~tui_win_info>: Inline.
1719         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1720         Don't declare.
1721         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1722         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1723         Remove.
1724         (tui_initialize_static_data): Update.
1725         (~tui_gen_win_info): Handle more cleanup here.
1726         (~tui_source_window_base): Delete "execution_info".
1727         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1728
1729 2019-06-25  Tom Tromey  <tom@tromey.com>
1730
1731         * tui/tui-layout.c (make_command_window): Don't set
1732         can_highlight.
1733         (show_source_disasm_command): Call the reset method.
1734         (show_data): Don't set can_highlight.  Call the reset method.
1735         (tui_gen_win_info::reset): Rename from init_gen_win_info
1736         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1737         (show_source_or_disasm_and_command): Call the reset method.
1738         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1739         (struct tui_cmd_window): Set can_highlight.
1740
1741 2019-06-25  Tom Tromey  <tom@tromey.com>
1742
1743         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1744         from make_visible.
1745         (tui_make_visible, tui_make_invisible): Rewrite.
1746         (tui_win_info::make_visible): Remove.
1747         (tui_source_window_base::make_visible): Update.
1748         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1749         method.  Moved from...
1750         (struct tui_win_info) <make_visible>: ...here.
1751
1752 2019-06-25  Tom Tromey  <tom@tromey.com>
1753
1754         * tui/tui-winsource.c
1755         (tui_source_window_base::do_scroll_horizontal): Remove direction
1756         parameter.
1757         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1758         direction parameter.
1759         * tui/tui-win.c (tui_win_info::forward_scroll)
1760         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1761         (tui_win_info::right_scroll): Update.
1762         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1763         direction parameter.
1764         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1765         direction parameter.
1766         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1767         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1768         Remove direction parameter.
1769         (struct tui_source_window_base, struct tui_source_window)
1770         (struct tui_disasm_window, struct tui_data_window)
1771         (struct tui_cmd_window): Update.
1772
1773 2019-06-25  Tom Tromey  <tom@tromey.com>
1774
1775         * tui/tui-winsource.h (tui_set_exec_info_content)
1776         (tui_show_exec_info_content, tui_erase_exec_info_content)
1777         (tui_clear_exec_info_content, tui_update_exec_info): Change
1778         argument to tui_source_window_base.
1779         * tui/tui-winsource.c (tui_set_exec_info_content)
1780         (tui_show_exec_info_content, tui_erase_exec_info_content)
1781         (tui_clear_exec_info_content, tui_update_exec_info): Change
1782         argument to tui_source_window_base.
1783
1784 2019-06-25  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1787         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1788
1789 2019-06-25  Tom Tromey  <tom@tromey.com>
1790
1791         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1792         check.
1793
1794 2019-06-25  Tom Tromey  <tom@tromey.com>
1795
1796         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1797         type to void.
1798         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1799         type to void.
1800         * tui/tui-source.c (tui_set_source_content): Update.
1801         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1802
1803 2019-06-25  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui-win.c (window_name_completer, tui_set_focus)
1806         (tui_all_windows_info): Use name method.
1807         * tui/tui-data.h (struct tui_gen_win_info)
1808         (struct tui_source_window, struct tui_disasm_window)
1809         (struct tui_data_window, struct tui_cmd_window) <name>: New
1810         method.
1811         (tui_win_name): Don't declare.
1812         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1813         (tui_win_name): Remove.
1814
1815 2019-06-25  Tom Tromey  <tom@tromey.com>
1816
1817         * tui/tui-winsource.h (tui_update_source_window)
1818         (tui_update_source_window_as_is): Change parameter type.
1819         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1820         to be a tui_source_window_base.
1821         (tui_update_source_window_as_is): Likewise.
1822         * tui/tui-win.c (make_visible_with_new_height): Update.
1823
1824 2019-06-25  Tom Tromey  <tom@tromey.com>
1825
1826         * tui/tui-winsource.c (tui_erase_source_content)
1827         (tui_show_source_content, tui_show_exec_info_content)
1828         (tui_erase_exec_info_content): Use refresh_window method.
1829         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1830         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1831         from tui_refresh_win.
1832         (tui_data_window::refresh_window): New method.
1833         (tui_win_info::refresh, tui_source_window_base::refresh)
1834         (tui_refresh_all): Use refresh_window method.
1835         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1836         method.
1837         * tui/tui-regs.c (tui_display_register): Call refresh_window
1838         method.
1839         * tui/tui-layout.c (show_source_disasm_command)
1840         (show_source_or_disasm_and_command): Call refresh_window method.
1841         * tui/tui-data.h (struct tui_gen_win_info)
1842         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1843         New method.
1844
1845 2019-06-25  Tom Tromey  <tom@tromey.com>
1846
1847         * tui/tui.c (tui_rl_other_window, tui_enable)
1848         (tui_is_window_visible, tui_get_command_dimension): Update.
1849         * tui/tui-winsource.c (tui_update_source_window_as_is)
1850         (tui_clear_source_content, tui_erase_source_content)
1851         (tui_show_source_line, tui_source_window_base::refill)
1852         (tui_source_window_base::do_scroll_horizontal)
1853         (tui_source_window_base::set_is_exec_point_at)
1854         (tui_update_breakpoint_info, tui_set_exec_info_content)
1855         (tui_alloc_source_buffer, tui_line_is_displayed)
1856         (tui_addr_is_displayed): Update.
1857         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1858         (tui_check_and_display_highlight_if_needed)
1859         (tui_win_info::make_visible, tui_win_info::refresh)
1860         (tui_refresh_all): Update.
1861         * tui/tui-windata.c (tui_first_data_item_displayed)
1862         (tui_delete_data_content_windows, tui_erase_data_content)
1863         (tui_display_all_data, tui_data_window::refresh_all)
1864         (tui_check_data_values): Update.
1865         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1866         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1867         (tui_win_info::backward_scroll, tui_refresh_all_win)
1868         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1869         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1870         (tui_source_window_base::set_new_height)
1871         (tui_data_window::set_new_height)
1872         (make_invisible_and_set_new_height)
1873         (make_visible_with_new_height, new_height_ok)
1874         (parse_scrolling_args): Update.
1875         * tui/tui-stack.c (tui_show_frame_info): Update.
1876         * tui/tui-source.c (tui_set_source_content)
1877         (tui_set_source_content_nil, tui_source_is_displayed)
1878         (tui_source_window::do_scroll_vertical): Update.
1879         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1880         (tui_display_registers_from, tui_display_reg_element_at_line)
1881         (tui_check_register_values, tui_reg_command): Update.
1882         * tui/tui-layout.c (tui_default_win_height)
1883         (show_source_disasm_command, show_data, init_and_make_win)
1884         (show_source_or_disasm_and_command): Update.
1885         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1886         (tui_redisplay_readline, tui_mld_flush)
1887         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1888         (tui_getc): Update.
1889         * tui/tui-disasm.c (tui_set_disassem_content)
1890         (tui_disasm_window::do_scroll_vertical): Update.
1891         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1892         Now virtual.
1893         (struct tui_win_info): Derive from tui_gen_win_info.
1894         <~tui_win_info>: Mark as override.
1895         <generic>: Remove member.
1896         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1897         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1898         (~tui_data_window, ~tui_win_info)
1899         (tui_free_all_source_wins_content): Update.
1900         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1901
1902 2019-06-25  Tom Tromey  <tom@tromey.com>
1903
1904         * tui/tui-layout.c (init_and_make_win): Use new.
1905         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1906         destructor, initializers.
1907         (tui_alloc_generic_win_info): Don't declare.
1908         * tui/tui-data.c (_locator): Add argument to constructor.
1909         (source_win, disasm_win): New globals.
1910         (exec_info): Remove.
1911         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1912         Update.
1913         (tui_alloc_generic_win_info): Remove.
1914         (init_content_element): Use new.
1915         (tui_win_info::tui_win_info): Update.
1916         (free_content_elements) <case DATA_WIN>: Use delete.
1917
1918 2019-06-25  Tom Tromey  <tom@tromey.com>
1919
1920         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1921         * tui/tui-windata.c (tui_first_data_item_displayed)
1922         (tui_delete_data_content_windows): Update.
1923         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1924         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1925         (tui_display_registers_from, tui_check_register_values): Update.
1926         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1927         pointer.
1928         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1929         window.
1930         (tui_free_data_content): Update.
1931         (free_content_elements) <case DATA_WIN>: Free the window.
1932
1933 2019-06-25  Tom Tromey  <tom@tromey.com>
1934
1935         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1936         Update.
1937         * tui/tui-layout.c (make_command_window)
1938         (show_source_disasm_command, show_data, init_and_make_win)
1939         (show_source_or_disasm_and_command): Update.
1940         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1941         method.
1942         <can_highight, is_highlighted>: Now bool.
1943         (tui_set_win_highlight): Don't declare.
1944         * tui/tui-data.c (tui_set_win_highlight): Remove.
1945
1946 2019-06-25  Tom Tromey  <tom@tromey.com>
1947
1948         * tui/tui-wingeneral.c (make_visible): Remove check of window
1949         type.
1950
1951 2019-06-25  Tom Tromey  <tom@tromey.com>
1952
1953         * tui/tui-win.c (tui_win_info::max_height)
1954         (tui_cmd_window::max_height): New methods.
1955         (new_height_ok): Call max_height.
1956         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1957         <max_height>: New method.
1958
1959 2019-06-25  Tom Tromey  <tom@tromey.com>
1960
1961         * tui/tui-win.c (tui_source_window_base::set_new_height)
1962         (tui_data_window::set_new_height): New methods.
1963         (make_invisible_and_set_new_height): Call set_new_height method.
1964         * tui/tui-data.h (struct tui_win_info)
1965         (struct tui_source_window_base, struct tui_data_window)
1966         <set_new_height>: New method.
1967
1968 2019-06-25  Tom Tromey  <tom@tromey.com>
1969
1970         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1971         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1972         tui_refresh_data_win.
1973         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1974         method.
1975         (tui_refresh_all_win): Call the refresh_all method.
1976         (tui_set_focus): Likewise.
1977         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1978         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1979         Likewise.
1980
1981 2019-06-25  Tom Tromey  <tom@tromey.com>
1982
1983         * tui/tui-winsource.h (tui_refill_source_window)
1984         (tui_set_is_exec_point_at): Don't declare.
1985         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1986         (tui_source_window_base::refill): Rename from
1987         tui_refill_source_window.
1988         (tui_source_window_base::do_scroll_horizontal): Update.
1989         (tui_source_window_base::set_is_exec_point_at): Rename from
1990         tui_set_is_exec_point_at.
1991         (tui_update_all_breakpoint_info): Update.
1992         * tui/tui-stack.c (tui_show_frame_info): Update.
1993         * tui/tui-layout.c (show_data): Add cast.
1994         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1995         * tui/tui-data.h (struct tui_source_window_base) <refill,
1996         set_is_exec_point_at>: New methods.
1997         (tui_source_windows, tui_add_to_source_windows): Update types.
1998         (tui_add_to_source_windows): Remove redundant declaration.
1999         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2000         (tui_source_windows): Change return type.
2001         (tui_clear_source_windows_detail): Update.
2002         (tui_add_to_source_windows): Change type of parameter.
2003         (tui_free_all_source_wins_content): Update.
2004
2005 2019-06-25  Tom Tromey  <tom@tromey.com>
2006
2007         * tui/tui-wingeneral.c (tui_win_info::refresh)
2008         (tui_source_window_base::refresh): New methods.
2009         (tui_refresh_all): Call the refresh method.
2010         * tui/tui-data.h (struct tui_win_info)
2011         (struct tui_source_window_base) <refresh>: New method.
2012
2013 2019-06-25  Tom Tromey  <tom@tromey.com>
2014
2015         * tui/tui.h (tui_is_window_visible): Return bool.
2016         * tui/tui.c (tui_is_window_visible): Return bool.
2017         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2018         (tui_make_visible, tui_make_invisible)
2019         (tui_win_info::make_visible)
2020         (tui_source_window_base::make_visible, make_all_visible)
2021         (tui_make_all_visible, tui_make_all_invisible): Update.
2022         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2023         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2024         bool.
2025         (struct tui_win_info, struct tui_source_window_base)
2026         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2027         * tui/tui-data.c (tui_init_generic_part): Update.
2028
2029 2019-06-25  Tom Tromey  <tom@tromey.com>
2030
2031         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2032         (tui_source_window_base::make_visible): New methods.
2033         (make_all_visible): Make method call.
2034         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2035         (struct tui_source_window_base, struct tui_cmd_window): Override
2036         make_visible.
2037         (tui_win_is_source_type): Don't declare.
2038         * tui/tui-data.c (tui_win_is_source_type): Remove.
2039
2040 2019-06-25  Tom Tromey  <tom@tromey.com>
2041
2042         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2043         NULL check.
2044
2045 2019-06-25  Tom Tromey  <tom@tromey.com>
2046
2047         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2048         Inline constructor.  Add initializers for members.
2049         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2050         constructors; now inline in class.
2051
2052 2019-06-25  Tom Tromey  <tom@tromey.com>
2053
2054         * tui/tui-regs.c (tui_show_registers): Update.
2055         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2056         bool.
2057         * tui/tui-data.c (tui_data_window::clear_detail)
2058         (tui_data_window): Update.
2059
2060 2019-06-25  Tom Tromey  <tom@tromey.com>
2061
2062         * tui/tui-windata.c (tui_display_all_data)
2063         (tui_display_data_from_line, tui_display_data_from)
2064         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2065         Update.
2066         * tui/tui-regs.c (tui_last_regs_line_no)
2067         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2068         (tui_show_registers, tui_show_register_group)
2069         (tui_display_registers_from, tui_display_reg_element_at_line)
2070         (tui_display_registers_from_line, tui_check_register_values)
2071         (tui_reg_next, tui_reg_prev): Update.
2072         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2073         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2074         tui_data_window.
2075         (struct tui_win_info) <detail>: Remove.  Add new fields from
2076         tui_data_info.
2077         (TUI_DATA_WIN): Add cast.
2078         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2079         (~tui_data_window): Simplify.
2080
2081 2019-06-25  Tom Tromey  <tom@tromey.com>
2082
2083         * tui/tui-layout.c (show_source_disasm_command)
2084         (show_source_or_disasm_and_command): Update.
2085         * tui/tui-io.c (update_cmdwin_start_line)
2086         (tui_redisplay_readline): Update.
2087         * tui/tui-data.h (struct tui_command_info): Remove.
2088         (struct tui_win_info) <detail>: Remove command_info member.
2089         (struct tui_data_window) <start_line>: New member, from
2090         tui_command_info.
2091         (TUI_CMD_WIN): Add casts.
2092
2093 2019-06-25  Tom Tromey  <tom@tromey.com>
2094
2095         * tui/tui-winsource.c (tui_update_source_window)
2096         (tui_refill_source_window)
2097         (tui_source_window_base::do_scroll_horizontal)
2098         (tui_update_breakpoint_info, tui_set_exec_info_content)
2099         (tui_show_exec_info_content, tui_erase_exec_info_content)
2100         (tui_clear_exec_info_content): Update.
2101         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2102         Update.
2103         * tui/tui-win.c (make_invisible_and_set_new_height)
2104         (make_visible_with_new_height): Update.
2105         * tui/tui-source.c (tui_set_source_content)
2106         (tui_show_symtab_source): Update.
2107         * tui/tui-layout.c (extract_display_start_addr)
2108         (show_source_disasm_command, show_data)
2109         (make_source_or_disasm_window)
2110         (show_source_or_disasm_and_command): Update.
2111         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2112         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2113         "gdbarch".
2114         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2115         to tui_source_window_base.
2116         (struct tui_win_info) <detail>: Remove source_info member.
2117         (struct tui_source_window_base) <has_locator>: Inline.
2118         Move contents from tui_source_info; rename has_locator member to
2119         m_has_locator.
2120         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2121         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2122         header file.
2123         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2124         Simplify.
2125         (tui_free_all_source_wins_content): Cast to
2126         tui_source_window_base.
2127
2128 2019-06-25  Tom Tromey  <tom@tromey.com>
2129
2130         * tui/tui-win.c (make_invisible_and_set_new_height)
2131         (make_visible_with_new_height): Call has_locator method.
2132         * tui/tui-layout.c (show_source_disasm_command, show_data)
2133         (show_source_or_disasm_and_command): Update for bool change.
2134         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2135         (tui_win_info) <has_locator>: New method.
2136         (struct tui_source_window_base) <has_locator>: New method.
2137         (tui_win_has_locator): Don't declare.
2138         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2139         from tui_win_has_locator.
2140         (tui_source_window_base): Use false, not FALSE.
2141
2142 2019-06-25  Tom Tromey  <tom@tromey.com>
2143
2144         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2145         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2146         clear_detail method directly.
2147         (tui_clear_win_detail): Remove.
2148
2149 2019-06-25  Tom Tromey  <tom@tromey.com>
2150
2151         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2152         "this", not TUI_DISASM_WIN.
2153
2154 2019-06-25  Tom Tromey  <tom@tromey.com>
2155
2156         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2157         declare.
2158         * tui/tui-winsource.c
2159         (tui_source_window_base::do_scroll_horizontal): Rename from
2160         tui_horizontal_source_scroll.
2161         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2162         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2163         from tui_vertical_data_scroll.
2164         * tui/tui-win.h (tui_scroll): Don't declare.
2165         * tui/tui-win.c (tui_win_info::forward_scroll)
2166         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2167         (tui_win_info::right_scroll): Rename and update.
2168         (tui_scroll_forward_command, tui_scroll_backward_command)
2169         (tui_scroll_left_command, tui_scroll_right_command): Update.
2170         (tui_scroll): Remove.
2171         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2172         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2173         from tui_vertical_source_scroll.
2174         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2175         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2176         from tui_vertical_disassem_scroll.
2177         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2178         do_scroll_horizontal>: New methods.
2179         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2180         Likewise.
2181         (struct tui_source_window_base): Add do_scroll_horizontal.
2182         (struct tui_source_window, struct tui_disasm_window): Add
2183         do_scroll_vertical.
2184         (struct tui_data_window, struct tui_cmd_window): Add
2185         do_scroll_horizontal and do_scroll_vertical.
2186         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2187
2188 2019-06-25  Tom Tromey  <tom@tromey.com>
2189
2190         * tui/tui-data.h (struct tui_source_window_base): New struct.
2191         (struct tui_source_window): Derive from tui_source_window_base.
2192         (struct tui_disasm_window): New struct.
2193         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2194         from tui_source_window::clear_detail.
2195         (tui_source_window_base): Rename from tui_source_window.
2196         (~tui_source_window_base): Rename from ~tui_source_window.
2197         (tui_alloc_win_info): Create a tui_disasm_window.
2198
2199 2019-06-25  Tom Tromey  <tom@tromey.com>
2200
2201         * tui/tui-data.h (struct tui_source_window)
2202         (struct tui_data_window): Declare destructors.
2203         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2204         destructors.
2205         (tui_win_info): Simplify.
2206
2207 2019-06-25  Tom Tromey  <tom@tromey.com>
2208
2209         * tui/tui-winsource.c (tui_display_main)
2210         (tui_update_source_windows_with_addr)
2211         (tui_update_all_breakpoint_info): Update.
2212         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2213         (new_height_ok, parse_scrolling_args): Update.
2214         * tui/tui-stack.c (tui_show_frame_info): Update.
2215         * tui/tui-data.h (struct tui_list): Remove.
2216         (tui_source_windows): Return a reference to a std::vector.
2217         * tui/tui-data.c (source_windows): Now a std::vector.
2218         (tui_source_windows): Change return type.
2219         (tui_clear_source_windows): Rewrite.
2220         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2221         (tui_free_all_source_wins_content): Rewrite.
2222
2223 2019-06-25  Tom Tromey  <tom@tromey.com>
2224
2225         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2226         (struct tui_data_window, struct tui_cmd_window): Declare
2227         clear_detail method.
2228         * tui/tui-data.c (tui_source_window::clear_detail)
2229         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2230         methods.
2231         (tui_clear_win_detail): Simplify.
2232
2233 2019-06-25  Tom Tromey  <tom@tromey.com>
2234
2235         * tui/tui-layout.c (make_source_window, make_disasm_window)
2236         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2237         Return the new window.
2238         (show_source_disasm_command, show_data)
2239         (show_source_or_disasm_and_command): Update.
2240
2241 2019-06-25  Tom Tromey  <tom@tromey.com>
2242
2243         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2244         parameter.  Return the new window.
2245         (show_source_disasm_command): Update and remove NULL check.
2246         (show_source_or_disasm_and_command): Update.
2247
2248 2019-06-25  Tom Tromey  <tom@tromey.com>
2249
2250         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2251
2252 2019-06-25  Tom Tromey  <tom@tromey.com>
2253
2254         * tui/tui-data.h (struct tui_win_info): Make constructor
2255         protected.  Make destructor virtual.  Add initializers.
2256         (tui_source_window, tui_data_window, tui_cmd_window): New
2257         classes.
2258         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2259         constructor.  Add "type" parameter.
2260         (tui_source_window, tui_data_window, tui_cmd_window): New
2261         constructors.
2262         (tui_alloc_win_info): Instantiate the appropriate subclass.
2263
2264 2019-06-25  Tom Tromey  <tom@tromey.com>
2265
2266         * tui/tui-win.c (tui_resize_all): Use delete.
2267         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2268         destructor.
2269         (tui_free_window): Don't declare.
2270         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2271         Update.
2272
2273 2019-06-25  Tom Tromey  <tom@tromey.com>
2274
2275         * tui/tui-data.h (struct tui_win_info): Add constructor.
2276         * tui/tui-data.c (tui_alloc_win_info): Use new.
2277         (tui_free_window): Use delete.
2278
2279 2019-06-22  Tom Tromey  <tom@tromey.com>
2280
2281         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2282         declare.
2283         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2284
2285 2019-06-22  Tom Tromey  <tom@tromey.com>
2286
2287         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2288         declare.
2289         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2290
2291 2019-06-22  Tom de Vries  <tdevries@suse.de>
2292
2293         * dwarf2read.c (create_addrmap_from_aranges)
2294         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2295         instead of '%zu'.
2296
2297 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2298
2299         * dwarf2read.h (dwarf2_section_info_def): Remove.
2300         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2301         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2302         std::vector<dwarf2_section_info>.
2303         (struct dwo_file) <~dwo_file>: Remove.
2304         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2305         types field.
2306         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2307         (dwarf2_read_debug_names): Likewise.
2308         (create_debug_types_hash_table): Change parameter type to
2309         array_view, adjust code accordingly.
2310         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2311         (partial_die_info::fixup): Likewise.
2312         (determine_prefix): Likewise.
2313         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2314
2315 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2316
2317         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2318         gdb_bfd_ref_ptr.
2319         <~dwo_file>: Remove call to gdb_bfd_unref.
2320         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2321         gdb_bfd_ref_ptr::get.
2322
2323 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2324
2325         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2326         type to htab_up.
2327         * dwarf2read.c (struct dwo_file): Initialize fields.
2328         <~dwo_file>: New.
2329         (free_dwo_file): Remove, move content to ~dwo_file.
2330         (struct dwo_file_deleter): Remove.
2331         (dwo_file_up>: Remove custom deleter.
2332         (free_dwo_files): Remove.
2333         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2334         dwo_files.
2335         (process_skeletonless_type_units): Call unique_ptr::get.
2336         (allocate_dwo_file_hash_table): Add deleter to created hash
2337         table.  Change return type to htab_up.
2338         (lookup_dwo_file_slot): Don't memset dwo_file, call
2339         unique_ptr::get.
2340         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2341         (create_dwo_unit_in_dwp_v2): Likewise.
2342         (open_and_init_dwo_file): Likewise.
2343         (free_dwo_file_from_slot): Remove.
2344
2345 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2346
2347         * dwarf2read.h (struct dwarf2_section_info) <readin,
2348         is_virtual>: Change type to bool.
2349         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2350         true instead of 1.
2351
2352 2019-06-19  Tom Tromey  <tom@tromey.com>
2353
2354         * tui/tui-data.h (tui_init_content_element): Don't declare.
2355
2356 2019-06-19  Tom Tromey  <tom@tromey.com>
2357
2358         * tui/tui-data.h (tui_init_win_info): Don't declare.
2359
2360 2019-06-19  Tom de Vries  <tdevries@suse.de>
2361
2362         * dwarf2read.h (abstract_to_concrete): Change type to
2363         std::unordered_map<sect_offset, std::vector<sect_offset>,
2364         gdb::hash_enum<sect_offset>>.
2365
2366 2019-06-19  Tom Tromey  <tromey@adacore.com>
2367
2368         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2369         EVAL_AVOID_SIDE_EFFECTS specially.
2370
2371 2019-06-19  Tom Tromey  <tromey@adacore.com>
2372
2373         * source-cache.c (highlighter): New global.
2374         (source_cache::get_source_lines): Create a highlighter on demand.
2375
2376 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2377
2378         * defs.h (deprecated_interactive_hook): Delete declaration.
2379         * interps.c (clear_interpreter_hooks): Remove use of
2380         deprecated_interactive_hook.
2381         * top.c (deprecated_interactive_hook): Delete definition.
2382         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2383
2384 2019-06-18  Tom de Vries  <tdevries@suse.de>
2385
2386         PR gdb/24515
2387         * dwarf2read.h (abstract_to_concrete): Change type from
2388         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2389         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2390         * dwarf2read.c (read_variable): Update.
2391         (dwarf2_fetch_die_loc_sect_off): Update.
2392
2393 2019-06-17  Tom de Vries  <tdevries@suse.de>
2394
2395         PR gdb/24617
2396         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2397         accessing parent[parent_len - 1].
2398
2399 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2400
2401         PR gdb/24364
2402         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2403         call dtrace_process_dof with NULL dof.
2404
2405 2019-06-16  Tom de Vries  <tdevries@suse.de>
2406
2407         PR gdb/24445
2408         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2409
2410 2019-06-16  Tom Tromey  <tom@tromey.com>
2411
2412         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2413         (make_all_visible): Use address of member.
2414
2415 2019-06-16  Tom Tromey  <tom@tromey.com>
2416
2417         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2418         (tui_free_window, free_content, free_content_elements): Remove
2419         unnecessary cast.
2420         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2421         cast.
2422         * tui/tui-regs.c (tui_show_register_group)
2423         (tui_display_registers_from, tui_display_reg_element_at_line):
2424         Remove unnecessary cast.
2425
2426 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2427
2428         * linux-nat.c (normal_mask): Delete.
2429         (_initialize_linux_nat): Don't initialise normal_mask.
2430
2431 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2432
2433         PR gdb/24445
2434         * dwarf-index-write.h (write_psymtabs_to_index): Add
2435         dwz_basename parameter.
2436         * dwarf-index-write.c (write_gdbindex): Move file writing to
2437         write_gdbindex_1.  Change return type void.
2438         (assert_file_size): Move up, remove filename parameter.
2439         (write_gdbindex_1): New function.
2440         (write_debug_names): Change return type to void, call
2441         assert_file_size.
2442         (struct index_wip_file): New struct.
2443         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2444         file logic to index_wip_file.  Write index for dwz file if
2445         needed.
2446         (save_gdb_index_command): Pass basename of dwz file, if present.
2447         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2448         build-id of dwz file, if present.
2449         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2450         (dwarf2_get_dwz_file): Likewise.
2451         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2452         (dwarf2_get_dwz_file): Likewise.
2453
2454 2019-06-16  Tom Tromey  <tom@tromey.com>
2455
2456         * coffread.c (process_coff_symbol): Use xstrdup.
2457         * value.c (create_internalvar): Use xstrdup.
2458
2459 2019-06-16  Tom Tromey  <tom@tromey.com>
2460
2461         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2462         * breakpoint.c (stopin_command, stopat_command)
2463         (until_break_command, decode_location_default): Remove unnecessary
2464         cast.
2465         * utils.c (subset_compare): Remove unnecessary cast.
2466         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2467         cast.
2468         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2469         cast.
2470         * infcmd.c (path_command): Remove unnecessary cast.
2471         * coffread.c (decode_type): Remove unnecessary cast.
2472         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2473         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2474         * tui/tui-stack.c (tui_show_locator_content)
2475         (tui_show_frame_info): Remove unnecessary cast.
2476         * tui/tui-win.c (tui_scroll_forward_command)
2477         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2478         (parse_scrolling_args): Remove unnecessary cast.
2479         * tui/tui-data.c (init_win_info, tui_del_window)
2480         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2481         (free_content_elements): Remove unnecessary cast.
2482         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2483         unnecessary cast.
2484         * tui/tui-source.c (tui_set_source_content)
2485         (tui_vertical_source_scroll): Remove unnecessary cast.
2486         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2487         cast.
2488         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2489         * tui/tui-regs.c (tui_display_registers_from)
2490         (tui_display_register): Remove unnecessary cast.
2491         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2492         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2493         (make_visible): Remove unnecessary cast.
2494         * tui/tui-winsource.c (tui_erase_source_content)
2495         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2496         unnecessary cast.
2497         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2498         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2499         * stabsread.c (read_type, read_array_type, read_range_type):
2500         Remove unnecessary cast.
2501         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2502         (parse_symbol, parse_type, upgrade_type, parse_external)
2503         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2504         unnecessary cast.
2505         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2506
2507 2019-06-16  Tom Tromey  <tom@tromey.com>
2508
2509         * tui/tui-data.c (tui_alloc_generic_win_info)
2510         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2511         checks.
2512
2513 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2514             Andrew Burgess  <andrew.burgess@embecosm.com>
2515
2516         * f-typeprint.c (f_print_type): Don't return early for not
2517         associated or not allocated types.
2518         (f_type_print_varspec_suffix): Add print_rank parameter and print
2519         ranks of array types in case they dangling.
2520         (f_type_print_base): Add print_rank parameter.
2521
2522 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2523
2524         * NEWS: Mention new MI commands.
2525         * break-catch-throw.c (enum exception_event_kind): Move to
2526         breakpoint.h.
2527         (print_mention_exception_catchpoint): Output text as a single
2528         message.
2529         (catch_exception_command_1): Rename to...
2530         (catch_exception_event): ...this, make non-static, update header
2531         command, and change some parameter types.
2532         (catch_catch_command): Update for changes to
2533         catch_exception_command_1.
2534         (catch_throw_command): Likewise.
2535         (catch_rethrow_command): Likewise.
2536         * breakpoint.c (enum exception_event_kind): Delete.
2537         * breakpoint.h (enum exception_event_kind): Moved here from
2538         break-catch-throw.c.
2539         (catch_exception_event): Declare.
2540         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2541         (mi_cmd_catch_throw): New function.
2542         (mi_cmd_catch_rethrow): New function.
2543         (mi_cmd_catch_catch): New function.
2544         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2545         'catch-catch' entries.
2546         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2547         (mi_cmd_catch_rethrow): Declare.
2548         (mi_cmd_catch_catch): Declare.
2549
2550 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2551
2552         * annotate.c (annotate_source_line): Change return type to void,
2553         update implementation to match.
2554         * annotate.h (annotate_source_line): Change return type to void,
2555         update header comment.
2556         * stack.c (print_frame_info): Don't change what frame information
2557         is printed based on whether annotations are on or not.
2558
2559 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2560
2561         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2562         (annotate_source): Make static.
2563         (annotate_source_line): Moved from source.c and renamed from
2564         identify_source_line.  Update the return type.
2565         * annotate.h (annotate_source): Delete declaration.
2566         (annotate_source_line): Declaration moved from source.h, and
2567         renamed from identify_source_line.  Return type updated.
2568         * source.c (identify_source_line): Moved to annotate.c and renamed
2569         to annotate_source_line.
2570         (info_line_command): Remove check of annotation_level.
2571         * source.h (identify_source_line): Move declaration to annotate.h
2572         and rename to annotate_source_line.
2573         * stack.c: Add 'annotate.h' include.
2574         (print_frame_info): Remove check of annotation_level before
2575         calling annotate_source_line.
2576
2577 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2578
2579         * source-cache.c (source_cache::get_plain_source_lines): Use
2580         open_source_file_with_line_charpos instead of just
2581         open_source_file, remove call to find_source_lines.
2582         (source_cache::get_source_lines): Likewise.
2583         * source.c (find_source_lines): Make static.
2584         (get_filename_and_charpos): Renamed into...
2585         (open_source_file_with_line_charpos): ..this along with changes to
2586         return a scoped_fd, and some other minor clean ups.
2587         (identify_source_line): Use open_source_file_with_line_charpos.
2588         (search_command_helper): Use open_source_file_with_line_charpos
2589         instead of just open_source_file, remove call to
2590         find_source_lines.
2591         * source.h (open_source_file_with_line_charpos): Declare new
2592         function.
2593         (find_source_lines): Delete declaration.
2594
2595 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2596
2597         * source.c (get_filename_and_charpos): Remove fullname
2598         parameter.
2599         (identify_source_line): Update call to get_filename_and_charpos.
2600
2601 2019-06-14  Tom Tromey  <tromey@adacore.com>
2602
2603         PR gdb/24502:
2604         * ui-style.h (skip_ansi_escape): Update comment.
2605         * ui-file.h (class no_terminal_escape_file): New class.
2606         * ui-file.c (no_terminal_escape_file::write)
2607         (no_terminal_escape_file::puts): New methods.
2608         * cli/cli-logging.c (handle_redirections): Use
2609         no_terminal_escape_file.
2610
2611 2019-06-14  Tom Tromey  <tromey@adacore.com>
2612
2613         * NEWS: Move convenience variable news above Python news.
2614
2615 2019-06-14  Tom Tromey  <tom@tromey.com>
2616
2617         * gnulib: Move directory to top-level.
2618         * configure.ac: Don't configure gnulib.
2619         * configure: Rebuild.
2620         * common/common-defs.h: Use new path to gnulib.
2621         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2622         (GNULIB_H): Remove.
2623         (INCGNU): Look in new gnulib location.
2624         (HFILES_NO_SRCDIR): Remove gnulib files.
2625         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2626         (generated_files): Remove GNULIB_H.
2627         ($(LIBGNU), all-lib): Remove targets.
2628         (distclean): Don't mention GNULIB_BUILDDIR.
2629         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2630
2631 2019-06-14  Tom Tromey  <tromey@adacore.com>
2632
2633         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2634         Warn if symbol file does not provide any symbols.
2635
2636 2019-06-14  Tom Tromey  <tromey@adacore.com>
2637
2638         * source.c (find_and_open_source): Respect basenames_may_differ.
2639
2640 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2641
2642         * annotate.c (annotate_breakpoints_invalid): Make use of
2643         scoped_restore_terminal_state.
2644         (annotate_frames_invalid): Likewise.
2645
2646 2019-06-14  Tom Tromey  <tromey@adacore.com>
2647
2648         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2649         allow assignment to an internalvar.
2650
2651 2019-06-14  Tom Tromey  <tromey@adacore.com>
2652
2653         * ada-lex.l: Allow "_" in attribute names.
2654
2655 2019-06-14  Tom Tromey  <tromey@adacore.com>
2656
2657         PR gdb/24653:
2658         * regcache.c (registers_changed): Don't call alloca.
2659         * top.c (execute_command): Don't call alloca.
2660
2661 2019-06-13  Pedro Alves  <palves@redhat.com>
2662
2663         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2664         'expression'.  When parsing an expression, error out if there's
2665         junk after "unlimited".
2666         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2667         (do_set_command): Adjust calls to is_unlimited_literal.
2668
2669 2019-06-13  Pedro Alves  <palves@redhat.com>
2670
2671         * compile/compile.c (make_compile_options_def_group): Add braces
2672         around array_view initializer.
2673         * thread.c (make_thread_apply_all_options_def_group)
2674         (make_thread_apply_all_options_def_group): Likewise.
2675
2676 2019-06-13  Pedro Alves  <palves@redhat.com>
2677
2678         * NEWS (New commands): Mention "maint test-options
2679         require-delimiter", "maint test-options unknown-is-error", "maint
2680         test-options unknown-is-operand" and "maint show
2681         test-options-completion-result".
2682         (New command options, command completion): New section.
2683         (Completion improvements): New section.
2684         Mention that you can abbreviate "unlimited".
2685
2686 2019-06-13  Pedro Alves  <palves@redhat.com>
2687
2688         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2689         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2690         * unittests/cli-utils-selftests.c (test_parse_flags)
2691         (test_parse_flags_qcs): Delete.
2692         (test_cli_utils): Don't call deleted functions.
2693
2694 2019-06-13  Pedro Alves  <palves@redhat.com>
2695
2696         * thread.c: Include "cli/cli-option.h".
2697         (tp_array_compar_ascending): Global.
2698         (tp_array_compar): Delete function.
2699         (tp_array_compar_ascending, tp_array_compar_descending): New
2700         functions.
2701         (ascending_option_def, qcs_flag_option_def)
2702         (thr_qcs_flags_option_defs)
2703         (make_thread_apply_all_options_def_group)
2704         (make_thread_apply_options_def_group): New.
2705         (thread_apply_all_command): Use gdb::option::process_options.
2706         (thread_apply_command_completer)
2707         (thread_apply_all_command_completer): New.
2708         (thread_apply_command): Use gdb::option::process_options.
2709         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2710         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2711         to generate help text of "thread apply".  Adjust "taas"'s help.
2712         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2713         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2714
2715 2019-06-13  Pedro Alves  <palves@redhat.com>
2716
2717         * thread.c (thread_apply_command): Check for invalid TID with
2718         isdigit instead of !isalpha.
2719
2720 2019-06-13  Pedro Alves  <palves@redhat.com>
2721
2722         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2723         (validate_flags_qcs): New.
2724         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2725         (validate_flags_qcs): Declare.
2726         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2727         (make_frame_apply_options_def_group): New.
2728         (frame_apply_command_count): Process options with
2729         gdb::option::process_options.
2730         (frame_apply_completer): New.
2731         (frame_apply_level_completer, frame_apply_all_completer)
2732         (frame_apply_completer): New.
2733         (_initialize_stack): Update help of "frame apply", "frame apply
2734         level", "frame apply all" and "faas" to mention supported options
2735         and install command completers.
2736         * stack.h (frame_apply_all_completer): Declare.
2737         * thread.c: Include "stack.h".
2738         (tfaas_command): Add "--".
2739         (_initialize_thread): Update help "tfaas" to mention supported
2740         options and install command completer.
2741
2742 2019-06-13  Pedro Alves  <palves@redhat.com>
2743
2744         * completer.c (complete_nested_command_line): New.
2745         (gdb_completion_word_break_characters_throw): Add assertion.
2746         * completer.h (complete_nested_command_line): Declare.
2747
2748 2019-06-13  Pedro Alves  <palves@redhat.com>
2749
2750         * stack.c (parse_backtrace_qualifiers): New.
2751         (backtrace_command): Use it.
2752         (backtrace_command_completer): Complete on qualifiers.
2753
2754 2019-06-13  Pedro Alves  <palves@redhat.com>
2755
2756         * frame.c: Include "cli/cli-option.h.
2757         (user_set_backtrace_options): New.
2758         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2759         Delete.
2760         (get_prev_frame): Adjust.
2761         (boolean_option_def, uinteger_option_def)
2762         (set_backtrace_option_defs): New.
2763         (_initialize_frame): Adjust and use
2764         gdb::option::add_setshow_cmds_for_options to install "set
2765         backtrace past-main" and "set backtrace past-entry".
2766         * frame.h: Include "cli/cli-option.h".
2767         (struct frame_print_options): Forward declare.
2768         (print_frame_arguments_all, print_frame_arguments_scalars)
2769         (print_frame_arguments_none): Declare.
2770         (print_entry_values): Delete declaration.
2771         (struct frame_print_options, user_frame_print_options): New.
2772         (struct set_backtrace_options): New.
2773         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2774         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2775         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2776         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2777         (list_args_or_locals): Add frame_print_options parameter.
2778         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2779         * python/py-framefilter.c (enumerate_args): Pass down
2780         USER_FRAME_PRINT_OPTIONS.
2781         * stack.c: Include "cli/cli-option.h".
2782         (print_frame_arguments_all, print_frame_arguments_scalars)
2783         (print_frame_arguments_none): Declare.
2784         (print_raw_frame_arguments, print_entry_values): Delete.
2785         (user_frame_print_options): New.
2786         (boolean_option_def, enum_option_def, frame_print_option_defs):
2787         New.
2788         (struct backtrace_cmd_options): New.
2789         (bt_flag_option_def): New.
2790         (backtrace_command_option_defs): New.
2791         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2792         (print_frame_arg, read_frame_arg, print_frame_args)
2793         (print_frame_info, print_frame): Add frame_print_options parameter
2794         and use it.
2795         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2796         (backtrace_command_1): Add frame_print_options and
2797         backtrace_cmd_options parameters and use them.
2798         (make_backtrace_options_def_group): New.
2799         (backtrace_command): Process command options with
2800         gdb::option::process_options.
2801         (backtrace_command_completer): New.
2802         (_initialize_stack): Extend "backtrace"'s help to mention
2803         supported options.  Install completer for "backtrace".
2804         Install some settings commands with add_setshow_cmds_for_options.
2805
2806 2019-06-13  Pedro Alves  <palves@redhat.com>
2807
2808         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2809         and that "set/show print raw frame-arguments" are now deprecated.
2810
2811         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2812         command.
2813         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2814         * stack.c (_initialize_stack): Install "set/show print
2815         raw-frame-arguments", and deprecate "set/show print raw
2816         frame-arguments".
2817         * valprint.c (_initialize_valprint): Deprecate "set/show print
2818         raw".
2819
2820 2019-06-13  Pedro Alves  <palves@redhat.com>
2821
2822         * compile/compile.c (struct compile_options): New.
2823         (compile_flag_option_def, compile_command_option_defs)
2824         (make_compile_options_def_group): New.
2825         (compile_file_command): Handle options with
2826         gdb::option::process_options.
2827         (compile_file_command_completer): New function.
2828         (compile_code_command): Handle options with
2829         gdb::option::process_options.
2830         (compile_code_command_completer): New function.
2831         (_initialize_compiler): Install completers for "compile code" and
2832         "compile file".  Mention available options in "compile code" and
2833         "compile code"'s help.
2834         * completer.c (advance_to_completion_word): New, factored out from
2835         ...
2836         (advance_to_expression_complete_word_point): ... this.
2837         (advance_to_filename_complete_word_point): New.
2838         * completer.h (advance_to_filename_complete_word_point): New
2839         declaration.
2840
2841 2019-06-13  Pedro Alves  <palves@redhat.com>
2842
2843         * compile/compile.c: Include "cli/cli-option.h".
2844         (compile_print_value): Scope data pointer is now a
2845         value_print_options pointer; adjust.
2846         (compile_print_command): Process options.  Scope data pointer is
2847         now a value_print_options pointer; adjust.
2848         (_initialize_compile): Update "compile print"'s help to include
2849         supported options.  Install a completer for "compile print".
2850         * cp-valprint.c (show_vtblprint, show_objectprint)
2851         (show_static_field_print): Delete.
2852         (_initialize_cp_valprint): Don't install "set print
2853         static-members", "set print vtbl", "set print object" here.
2854         * printcmd.c: Include "cli/cli-option.h" and
2855         "common/gdb_optional.h".
2856         (print_command_parse_format): Rework to fill in a
2857         value_print_options instead of a format_data.
2858         (print_value): Change parameter type from format_data pointer to
2859         value_print_options reference.  Adjust.
2860         (print_command_1): Process options.  Adjust to pass down a
2861         value_print_options.
2862         (print_command_completer): New.
2863         (_initialize_printcmd): Install print_command_completer as
2864         handle_brkchars completer for the "print" command.  Update
2865         "print"'s help to include supported options.
2866         * valprint.c: Include "cli/cli-option.h".
2867         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2868         here from cp-valprint.c.
2869         (boolean_option_def, uinteger_option_def)
2870         (value_print_option_defs, make_value_print_options_def_group):
2871         New.  Use gdb::option::add_setshow_cmds_for_options to install
2872         "set print elements", "set print null-stop", "set print repeats",
2873         "set print pretty", "set print union", "set print array", "set
2874         print address", "set print symbol", "set print array-indexes".
2875         * valprint.h: Include <string> and "cli/cli-option.h".
2876         (make_value_print_options_def_group): Declare.
2877         (print_value): Change parameter type from format_data pointer to
2878         value_print_options reference.
2879         (print_command_completer): Declare.
2880
2881 2019-06-13  Pedro Alves  <palves@redhat.com>
2882
2883         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2884         (COMMON_SFILES): Add maint-test-settings.c.
2885         * cli/cli-decode.c (boolean_enums): New global, factored out from
2886         ...
2887         (add_setshow_boolean_cmd): ... here.
2888         * cli/cli-decode.h (boolean_enums): Declare.
2889         * cli/cli-option.c: New file.
2890         * cli/cli-option.h: New file.
2891         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2892         factored out from ...
2893         (parse_cli_boolean_value(const char *)): ... this.
2894         (is_unlimited_literal): Change parameter type to pointer to
2895         pointer.  Adjust and advance ARG pointer.
2896         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2897         (parse_cli_var_enum): New, factored out from ...
2898         (do_set_command): ... this.  Adjust.
2899         * cli/cli-setshow.h (parse_cli_boolean_value)
2900         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2901         (parse_cli_var_enum): Declare.
2902         * cli/cli-utils.c: Include "cli/cli-option.h".
2903         (get_ulongest): New.
2904         * cli/cli-utils.h (get_ulongest): Declare.
2905         (check_for_argument): New overloads.
2906         * maint-test-options.c: New file.
2907
2908 2019-06-13  Pedro Alves  <palves@redhat.com>
2909
2910         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2911         parse a range if "-" is at the end of the string.
2912
2913 2019-06-13  Pedro Alves  <palves@redhat.com>
2914
2915         * cli/cli-setshow.c (parse_auto_binary_operation)
2916         (parse_cli_boolean_value): Don't allow "o".
2917
2918 2019-06-13  Pedro Alves  <palves@redhat.com>
2919
2920         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2921         * NEWS: Mention maint test-settings KIND.
2922         * maint-test-settings.c: New file.
2923
2924 2019-06-13  Pedro Alves  <palves@redhat.com>
2925
2926         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2927         completer.
2928         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2929         "set" completers.
2930
2931 2019-06-13  Pedro Alves  <palves@redhat.com>
2932
2933         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2934         after item.
2935
2936 2019-06-13  Pedro Alves  <palves@redhat.com>
2937
2938         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2939
2940 2019-06-13  Pedro Alves <palves@redhat.com>
2941
2942         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2943         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2944         call.
2945         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2946         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2947         calls.
2948         (check_for_argument): Skip spaces after argument.
2949
2950 2019-06-13  Pedro Alves  <palves@redhat.com>
2951
2952         * thread.c (thread_apply_command): Adjust TID parsing.
2953         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2954         detected before end of string.
2955         (tid_is_in_list): Error out if LIST is invalid.
2956
2957 2019-06-13  Pedro Alves  <palves@redhat.com>
2958
2959         * completer.c (complete_line_internal_1): Rewind completion word
2960         point.
2961         (completion_tracker::advance_custom_word_point_by): Change
2962         parameter type to int.
2963         * completer.h (completion_tracker::advance_custom_word_point_by):
2964         Likewise.
2965
2966 2019-06-13  Pedro Alves  <palves@redhat.com>
2967
2968         * completer.c (advance_to_completion_word): Handle delimiters.
2969
2970 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2971
2972         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2973
2974 2019-06-11  Tom Tromey  <tom@tromey.com>
2975
2976         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2977         (xmalloc_failed): Move to alloc.c.
2978         * alloc.c: New file.
2979         * Makefile.in (COMMON_SFILES): Add alloc.c.
2980
2981 2019-06-11  Tom Tromey  <tom@tromey.com>
2982
2983         * nat/linux-waitpid.c: Don't include server.h.
2984         (linux_debug): Remove.
2985         (my_waitpid): Update.
2986
2987 2019-06-11  Tom Tromey  <tromey@adacore.com>
2988
2989         * infcall.c (_initialize_infcall): Remove trailing newline from
2990         help.
2991         * user-regs.c (_initialize_user_regs): Remove trailing newline
2992         from help.
2993         * typeprint.c (_initialize_typeprint): Remove trailing newline
2994         from help.
2995         * reverse.c (_initialize_reverse): Remove trailing newlines from
2996         help.
2997         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2998         from help.
2999         * language.c (add_set_language_command): Remove trailing newline
3000         from help.
3001         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3002         help.
3003         * disasm.c (_initialize_disasm): Remove trailing newline from
3004         help.
3005         * top.c (init_main): Remove trailing newline from help.
3006         * interps.c (_initialize_interpreter): Remove trailing newline
3007         from help.
3008         * btrace.c (_initialize_btrace): Remove trailing newlines from
3009         help.
3010         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3011         from help.
3012         * python/python.c (_initialize_python): Remove trailing newline
3013         from help.
3014         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3015         help.
3016         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3017         from help.  Reformat some text.
3018         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3019         from help.
3020         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3021         newline from help.
3022
3023 2019-06-11  Tom Tromey  <tromey@adacore.com>
3024
3025         * darwin-nat.c (darwin_decode_exception_message)
3026         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3027
3028 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3029
3030         * valops.c (value_slice): Check for not allocated or not
3031         associated values.
3032
3033 2019-06-10  Tom de Vries  <tdevries@suse.de>
3034
3035         PR gdb/24618
3036         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3037         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3038         invalid.
3039
3040 2019-06-10  Tom de Vries  <tdevries@suse.de>
3041
3042         PR gdb/24611
3043         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3044         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3045
3046 2019-06-10  Tom de Vries  <tdevries@suse.de>
3047
3048         PR symtab/24545
3049         * symtab.c (struct demangled_name_entry): Add language field.
3050         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3051         static minimal symbol".  Set and use language field.
3052
3053 2019-06-10  Tom Tromey  <tromey@adacore.com>
3054
3055         * ada-lang.c (_initialize_ada_language): Update help text.
3056
3057 2019-06-10  Tom Tromey  <tromey@adacore.com>
3058
3059         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3060         with a newline.
3061         * guile/guile.c (handle_boot_error): Don't end warning with a
3062         newline.
3063         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3064         warning with a newline.
3065         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3066         newline.
3067         (s12z_frame_cache): Likewise.
3068         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3069         a newline.
3070         * solib-svr4.c (disable_probes_interface): Don't end warning with
3071         a newline.
3072         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3073         newline.
3074         * python/python.c (do_finish_initialization): Don't end warning
3075         with a newline.
3076
3077 2019-06-10  Tom Tromey  <tom@tromey.com>
3078
3079         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3080         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3081         gdbpy_enter.
3082
3083 2019-06-10  Tom Tromey  <tromey@adacore.com>
3084
3085         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3086         data.
3087         (elf_new_init): Don't call stabsread_new_init.
3088         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3089         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3090         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3091
3092 2019-06-10  Tom de Vries  <tdevries@suse.de>
3093
3094         PR symtab/16264
3095         PR symtab/24517
3096         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3097
3098 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3099
3100         * source.c (find_and_open_source): Also rewrite relative file
3101         names.
3102
3103 2019-04-26  Amos Bird  <amosbird@gmail.com>
3104
3105         * annotate.c (annotate_thread_exited): Add "thread-exited"
3106         annotation.
3107
3108 2019-06-06  Tom Tromey  <tromey@adacore.com>
3109
3110         * maint.h (class scoped_command_stats): Use
3111         DISABLE_COPY_AND_ASSIGN.
3112         <print_time>: New method.
3113         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3114         print_time.
3115         (scoped_command_stats::print_time): New method.
3116
3117 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3118
3119         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3120         instructions of lengths 6 or 8 bytes.
3121
3122 2019-06-04  Pedro Alves  <palves@redhat.com>
3123
3124         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3125
3126         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3127         * breakpoint.c (condition_completer): Likewise.
3128         * cli/cli-dump.c (scan_expression): Likewise.
3129         * common/filestuff.c (mkdir_recursive): Likewise.
3130         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3131         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3132         (gdb_abspath): Likewise.
3133         * compile/compile-cplus-types.c
3134         (compile_cplus_instance::decl_name): Likewise.
3135         * completer.c (complete_explicit_location):
3136         (signal_completer, reg_or_group_completer_1): Likewise.
3137         * cp-support.c (cp_remove_params_if_any): Likewise.
3138         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3139         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3140         * infcmd.c (strip_bg_char): Likewise.
3141         * linespec.c (copy_token_string): Likewise.
3142         * mi/mi-main.c (output_cores): Likewise.
3143         * psymtab.c (psymtab_search_name):
3144         * symfile.c (test_set_ext_lang_command): Likewise.
3145         * target.c (target_fileio_read_stralloc): Likewise.
3146         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3147         * value.c (complete_internalvar): Likewise.
3148
3149 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3150
3151         Add objfile property to gdb.Type.
3152         * NEWS: Mention Python API addition.
3153         * python/py-type.c (typy_get_objfile): New method.
3154
3155 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3156
3157         * NEWS: Mention the new set|show style [title|highlight].
3158         Mention changes to "show style", "help" and "apropos".
3159
3160 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3161
3162         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3163         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3164         instead of print_help_for_command.
3165         (print_doc_of_command): New function.
3166         (help_list): Add 'apropos -v word' suggestion.
3167         (print_help_for_command): Style the command name using title style.
3168         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3169         (_initialize_cli_cmds): Describe -v in apropos_command help.
3170
3171 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3172
3173         * cli/cli-style.h (cli_style_option): Add name in constructor,
3174         add m_name class member, add constructor with intensity,
3175         add name class function.
3176         (cli_style_option::add_setshow_commands): Remove name argument.
3177         (highlight_style, title_style): New styles.
3178         * cli/cli-style.c (do_show): New function that shows a style
3179         characteristic styling the style name with itself.
3180         (set_style_name): New function.
3181         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3182         Update all callers according to the changes in cli/cli-style.h.
3183         * utils.h (fputs_highlighted): New function.
3184         * utils.c (fputs_highlighted): Likewise.
3185
3186 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3187
3188         * NEWS: Mention new pipe command and new convenience variables.
3189
3190 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3191
3192         * cli/cli-cmds.c (pipe_command): New function.
3193         (_initialize_cli_cmds): Call add_com for pipe_command.
3194         Define | as an alias for pipe.
3195         (exit_status_set_internal_vars): New function.
3196         (shell_escape): Call exit_status_set_internal_vars.
3197         cli/cli-decode.c (find_command_name_length): Recognize | as
3198         a single character command.
3199
3200 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3201
3202         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3203         top.c (execute_command_to_ui_file): New function, mostly a copy
3204         of execute_command_to_string.
3205         (execute_command_to_string): Implement by calling
3206         execute_command_to_ui_file.
3207
3208 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3209
3210         * top.h (saved_command_line): Remove declaration.
3211         * top.c (previous_saved_command_line, previous_repeat_arguments):
3212         New variables.
3213         (saved_command_line): Make static, define together with other
3214         'repeat variables'.
3215         (dont_repeat): Clear repeat_arguments.
3216         (repeat_previous, get_saved_command_line, save_command_line):
3217         New functions.
3218         (gdb_init): Initialize saved_command_line
3219         and previous_saved_command_line.
3220         * main.c (captured_main_1): Remove saved_command_line initialization.
3221         * event-top.c (handle_line_of_input): Update to use
3222         the new 'repeat' related functions instead of direct access to
3223         saved_command_line.
3224         * command.h (repeat_previous, get_saved_command_line,
3225         save_command_line): New declarations.
3226         (dont_repeat): Add comment.
3227
3228 2019-05-30  Tom Tromey  <tromey@adacore.com>
3229
3230         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3231         Fix comment.
3232         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3233
3234 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3235
3236         PR cli/24587
3237         * completer.c (complete): Initialize variable word.
3238
3239 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3240
3241         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3242         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3243         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3244         'body' is NULL to the outter 'if', protecting the '!is_define'
3245         situation as well.
3246
3247 2019-05-29  Tom Tromey  <tromey@adacore.com>
3248
3249         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3250         (dwarf_unknown): New function.
3251         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3252         (dwarf_type_encoding_name): Use dwarf_unknown.
3253
3254 2019-05-29  Tom Tromey  <tromey@adacore.com>
3255
3256         PR c++/20020:
3257         * cp-valprint.c (cp_print_value_fields): Call
3258         cp_print_static_field inside "try".
3259
3260 2019-05-29  Tom Tromey  <tromey@adacore.com>
3261
3262         * inflow.c (struct terminal_info): Add default operator=.
3263         * configure: Rebuild.
3264         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3265         -Wdeprecated-copy-dtor, -Wredundant-move.
3266
3267 2019-05-29  Tom Tromey  <tromey@adacore.com>
3268
3269         * NEWS: Add entry.
3270         * infcmd.c (print_return_value_1): Handle finish_print
3271         option.
3272         (show_print_finish): New function.
3273         (_initialize_infcmd): Add "set/show print finish" commands.
3274         * valprint.c (user_print_options): Initialize new member.
3275         * valprint.h (struct value_print_options) <finish_print>: New
3276         member.
3277
3278 2019-05-28  Tom Tromey  <tromey@adacore.com>
3279
3280         * ada-lang.c (ada_remove_Xbn_suffix)
3281         (find_old_style_renaming_symbol)
3282         (parse_old_style_renaming): Remove.
3283         (ada_find_renaming_symbol): Don't call
3284         find_old_style_renaming_symbol.
3285         (ada_is_renaming_symbol): Rename from
3286         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3287         bool.  Now static.
3288         (ada_read_var_value): Update and simplify.
3289         * ada-exp.y (write_var_or_type): Remove old code.
3290
3291 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3292
3293         * event-top.c: Remove include comment.
3294         * inflow.c (class scoped_ignore_sigttou): Move from here...
3295         * inflow.h (class scoped_ignore_sigttou): ...to here.
3296         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3297         * top.c:  Remove include comment.
3298
3299 2019-05-27  Tom Tromey  <tom@tromey.com>
3300
3301         * NEWS: Fix typo.
3302
3303 2019-05-22  Tom Tromey  <tromey@adacore.com>
3304
3305         * target.c (target_follow_exec): Constify parameter.
3306         * target-delegates.c: Rebuild.
3307         * remote.c (remote_target::follow_exec): Constify parameter.
3308         * infrun.c (follow_exec): Constify parameter.
3309         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3310         (target_follow_exec): Likewise.
3311
3312 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3313
3314         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3315         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3316
3317 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3318
3319         * NEWS: Add debugredirect and testsuite sections.
3320
3321 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3322
3323         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3324         target descriptions using exclusively floating point register name
3325         aliases.
3326
3327 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3328
3329         PR gdb/18644:
3330         * f-lang.c (build_fortran_types): Handle the case where
3331         gdbarch_floatformat_for_type returns a nullptr.
3332
3333 2019-05-21  Tom de Vries  <tdevries@suse.de>
3334
3335         PR cli/24587
3336         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3337
3338 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3339
3340         PR gdb/18644:
3341         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3342         16-byte floats.
3343         * i386-tdep.c (i386_floatformat_for_type): Use
3344         floatformats_ia64_quad for the 16-byte floating point component
3345         within a fortran 32-byte complex number.
3346
3347 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3348
3349         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3350         delete default constructor.
3351         (find_partial_die): Update to return const struct.
3352         (partial_die_parent_scope): Move variable declaration into scope
3353         of its use and change its type to auto.
3354         (guess_partial_die_structure_name): Likewise.
3355         (partial_die_info::fixup): Likewise.
3356
3357 2019-05-17  Tom Tromey  <tromey@adacore.com>
3358
3359         * source.c (find_and_open_source): Remove cast.
3360
3361 2019-05-17  Tom Tromey  <tromey@adacore.com>
3362
3363         * annotate.c (annotate_source): Make "filename" const.
3364         * annotate.h (annotate_source): Use const.
3365
3366 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3367
3368         * disasm.c (set_disassembler_options): Send errors to stderr.
3369
3370 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3371
3372         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3373         (cli_interp_base::set_logging): Check debug_redirect.
3374         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3375         * cli/cli-logging.c (debug_redirect): Add static variable.
3376         (pop_output_files): Add default param.
3377         (handle_redirections): Print debug setting.
3378         (show_logging_command): Likewise.
3379         (_initialize_cli_logging): Add debugredirect command.
3380         * interps.c (current_interp_set_logging): Add debug_redirect
3381         parameter.
3382         * interps.h (set_logging): Add debug_redirect parameter.
3383         (current_interp_set_logging): Likewise.
3384         * mi/mi-common.h: Likewise.
3385         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3386
3387 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3388             Tom Tromey  <tromey@adacore.com>
3389
3390         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3391         directly.
3392         * cli/cli-interp.h (make_logging_output): Remove declaration.
3393         * cli/cli-logging.c (make_logging_output): Remove function.
3394         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3395         directly.
3396         * ui-file.c (tee_file::tee_file): Remove bools.
3397         (tee_file::~tee_file): Remove deletes.
3398         * ui-file.h (tee_file): Remove bools.
3399
3400 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3401
3402         * mi/mi-cmds.h (mi_cmd_complete): New function.
3403         * mi/mi-main.c (mi_cmd_complete): Likewise.
3404         * mi/mi-cmds.c: Define new MI command -complete.
3405         * NEWS: Mention new -complete command.
3406
3407 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3408
3409         * completer.h (complete): New function.
3410         * completer.c (complete): Likewise.
3411         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3412         function defined in completer.h.
3413
3414 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3415
3416         * MAINTAINERS (Write After Approval): Add myself.
3417
3418 2019-05-17  Tom de Vries  <tdevries@suse.de>
3419
3420         PR gdb/24094
3421         * dwarf2read.c (struct cu_partial_die_info): New struct.
3422         (find_partial_die): Return cu_partial_die_info.
3423         (partial_die_parent_scope, guess_partial_die_structure_name)
3424         (partial_die_info::fixup): Handle new return type of find_partial_die.
3425
3426 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3427
3428         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3429         "std::string", simplifying the algorithm.
3430
3431 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3432
3433         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3434         (stap_static_probe_ops::get_probes): Likewise.
3435
3436 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3437
3438         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3439         '-')" and "else if".
3440         (stap_parse_single_operand): Join checks for
3441         "gdbarch_stap_parse_special_token_p" and
3442         "gdbarch_stap_parse_special_token" in the same "if" statement.
3443         Invert check when verifying for operation on register
3444         displacement.
3445
3446 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3447
3448         * stap-probe.c (stap_get_opcode): Update comment.
3449         (stap_get_expected_argument_type): Likewise.
3450         (handle_stap_probe): Likewise.
3451
3452 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3453
3454         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3455         return type to 'bool'.  Adjust comment.  Use 'bool' when
3456         appropriate.
3457         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3458         * stap-probe.c (stap_parse_argument_1): Likewise.
3459         (stap_is_operator): Likewise.
3460         (stap_is_generic_prefix): Likewise.
3461         (stap_is_register_prefix): Likewise.
3462         (stap_is_register_indirection_prefix): Likewise.
3463         (stap_is_integer_prefix): Likewise.
3464         (stap_generic_check_suffix): Likewise.
3465         (stap_check_integer_suffix): Likewise.
3466         (stap_check_register_suffix): Likewise.
3467         (stap_check_register_indirection_suffix): Likewise.
3468         (stap_parse_register_operand): Likewise.
3469         (stap_parse_single_operand): Likewise.
3470         (stap_parse_argument_1): Likewise.
3471         (stap_probe::get_argument_count): Likewise.
3472         (stap_is_operator): Likewise.
3473
3474 2019-05-16  Tom Tromey  <tromey@adacore.com>
3475
3476         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3477         keyword to foreach.
3478
3479 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3480
3481         * linux-thread-db.c (try_thread_db_load_1): Change return type
3482         to bool.
3483         (try_thread_db_load): Likewise.
3484         (try_thread_db_load_from_pdir_1): Likewise.
3485         (try_thread_db_load_from_pdir): Likewise.
3486         (try_thread_db_load_from_sdir): Likewise.
3487         (try_thread_db_load_from_dir): Likewise.
3488         (thread_db_load_search): Likewise.
3489         (has_libpthread): Likewise.
3490         (thread_db_load): Likewise.
3491
3492 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3493
3494         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3495         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3496         NULL, and complain/return if that's the case.
3497
3498 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3499
3500         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3501         (advance, posn, abstract_read_memory): New functions.
3502         [struct mem_read_abstraction]: New struct.
3503         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3504
3505 2019-05-14  Tom Tromey  <tromey@adacore.com>
3506
3507         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3508         value is not lval_memory.
3509
3510 2019-05-14  Tom Tromey  <tromey@adacore.com>
3511
3512         * solib.c (info_sharedlibrary_command): Style the file name.
3513
3514 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3515
3516         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3517         (aarch64_vnv_type): Likewise.
3518         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3519         * common/tdesc.c: Likewise.
3520         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3521         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3522         * features/aarch64-fpu.xml: Add ieee half view.
3523         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3524         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3525         * gdbtypes.h (struct builtin_type): Likewise.
3526         (struct objfile_type): Likewise.
3527
3528 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3529
3530         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3531         typo.
3532         * location.h (string_to_event_location): Likewise.
3533
3534 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3535
3536         GDB 8.3 released.
3537
3538 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3539
3540         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3541         New variable declaration.
3542         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3543         New variable.
3544         (print_one_breakpoint): Use ui_out::test_flags and new global
3545         variable to compute use_fixed_output.
3546         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3547         Remove.
3548         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3549         (mi_multi_location_breakpoint_output_fixed): Remove.
3550         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3551         new variable.
3552         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3553         fix_multi_location_breakpoint_output flag if version >= 3.
3554         * ui-out.h (enum ui_out_flag)
3555         <fix_multi_location_breakpoint_output>: New enumerator.
3556
3557 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3558
3559         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3560
3561 2019-05-10  Tom Tromey  <tromey@adacore.com>
3562
3563         * ada-lang.c (catch_ada_completer): New function.
3564         (_initialize_ada_language): Use it.
3565
3566 2019-05-10  Tom Tromey  <tromey@adacore.com>
3567
3568         * thread.c (print_thread_info): Make "requested_threads" const.
3569         * gdbthread.h (print_thread_info): Make "requested_threads"
3570         const.
3571         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3572         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3573
3574 2019-05-08  Tom Tromey  <tom@tromey.com>
3575
3576         * gdbtypes.c (objfile_type_data): Change type.
3577         (objfile_type, _initialize_gdbtypes): Update.
3578
3579 2019-05-08  Tom Tromey  <tom@tromey.com>
3580
3581         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3582         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3583         (_initialize_dwarf2_frame): Update.
3584
3585 2019-05-08  Tom Tromey  <tom@tromey.com>
3586
3587         * objc-lang.c (objc_objfile_data): Change type.
3588         (find_methods): Update.
3589         (_initialize_objc_lang): Remove.
3590
3591 2019-05-08  Tom Tromey  <tom@tromey.com>
3592
3593         * stabsread.c (rs6000_builtin_type_data): Change type.
3594         (rs6000_builtin_type, _initialize_stabsread): Update.
3595
3596 2019-05-08  Tom Tromey  <tom@tromey.com>
3597
3598         * mips-tdep.c (mips_pdr_data): Remove.
3599         (_initialize_mips_tdep): Update.
3600
3601 2019-05-08  Tom Tromey  <tom@tromey.com>
3602
3603         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3604         (hppa_init_objfile_priv_data, read_unwind_info)
3605         (find_unwind_entry, _initialize_hppa_tdep): Update.
3606
3607 2019-05-08  Tom Tromey  <tom@tromey.com>
3608
3609         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3610         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3611         on obstack.
3612         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3613
3614 2019-05-08  Tom Tromey  <tom@tromey.com>
3615
3616         * mdebugread.c (basic_type_data): Change type.
3617         (basic_type, _initialize_mdebugread): Update.
3618
3619 2019-05-08  Tom Tromey  <tom@tromey.com>
3620
3621         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3622
3623 2019-05-08  Tom Tromey  <tom@tromey.com>
3624
3625         * nto-tdep.c (nto_inferior_data_reg): Change type.
3626         (nto_inferior_data): Update.
3627         (nto_inferior_data_cleanup, nto_new_inferior_data)
3628         (_initialize_nto_tdep): Remove.
3629         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3630
3631 2019-05-08  Tom Tromey  <tom@tromey.com>
3632
3633         * ada-lang.c (struct ada_inferior_data): Add initializers.
3634         (ada_inferior_data): Change type.
3635         (ada_inferior_data_cleanup): Remove.
3636         (get_ada_inferior_data, ada_inferior_exit)
3637         (struct ada_pspace_data): Add initializers, destructor.
3638         (ada_pspace_data_handle): Change type.
3639         (get_ada_pspace_data): Update.
3640         (ada_pspace_data_cleanup): Remove.
3641
3642 2019-05-08  Tom Tromey  <tom@tromey.com>
3643
3644         * coffread.c (struct coff_symfile_info): Add initializers.
3645         (coff_objfile_data_key): Move lower.  Change type.
3646         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3647         Update.
3648         (coff_free_info): Remove.
3649
3650 2019-05-08  Tom Tromey  <tom@tromey.com>
3651
3652         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3653         (fbsd_pspace_data_handle): Move lower.  Change type.
3654         (get_fbsd_pspace_data): Update.
3655         (fbsd_pspace_data_cleanup): Remove.
3656         (_initialize_fbsd_tdep): Update.
3657
3658 2019-05-08  Tom Tromey  <tom@tromey.com>
3659
3660         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3661         (get_ada_tasks_pspace_data): Update.
3662         (ada_tasks_pspace_data_cleanup): Remove.
3663         (_initialize_tasks): Update.
3664         (ada_tasks_inferior_data_handle): Change type.
3665         (get_ada_tasks_inferior_data): Update.
3666         (ada_tasks_inferior_data_cleanup): Remove.
3667         (struct ada_tasks_pspace_data): Add initializers.
3668
3669 2019-05-08  Tom Tromey  <tom@tromey.com>
3670
3671         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3672         * symfile-debug.c (debug_sym_get_probes): Change type.
3673         * stap-probe.c (handle_stap_probe):
3674         (stap_static_probe_ops::get_probes): Change type.
3675         * probe.h (class static_probe_ops) <get_probes>: Change type.
3676         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3677         (parse_probes_in_pspace): Update.
3678         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3679         Update.
3680         (any_static_probe_ops::get_probes): Change type.
3681         * elfread.c (elfread_data): New typedef.
3682         (probe_key): Change type.
3683         (elf_get_probes): Likewise.  Update.
3684         (probe_key_free): Remove.
3685         (_initialize_elfread): Update.
3686         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3687         Change type.
3688         (dtrace_process_dof_probe, dtrace_process_dof)
3689         (dtrace_static_probe_ops::get_probe): Change type.
3690
3691 2019-05-08  Tom Tromey  <tom@tromey.com>
3692
3693         * xcoffread.c (struct xcoff_symfile_info): Rename from
3694         coff_symfile_info.  Add initializers.
3695         (xcoff_objfile_data_key): Move lower.  Change type.
3696         (XCOFF_DATA): Rewrite.
3697         (xcoff_free_info): Remove.
3698         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3699         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3700         (xcoff_initial_scan): Update.
3701
3702 2019-05-08  Tom Tromey  <tom@tromey.com>
3703
3704         * solib-svr4.c (struct svr4_info): Add initializers and
3705         destructor.
3706         <probes_table>: Now an htab_up.
3707         (solib_svr4_pspace_data): Change type.
3708         (free_probes_table): Simplify.
3709         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3710         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3711         (probes_table_remove_objfile_probes, register_solib_event_probe)
3712         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3713         (_initialize_svr4_solib): Update.
3714
3715 2019-05-08  Tom Tromey  <tom@tromey.com>
3716
3717         * remote.c (remote_pspace_data): Change type.
3718         (remote_pspace_data_cleanup): Remove.
3719         (get_remote_exec_file, set_pspace_remote_exec_file)
3720         (_initialize_remote): Update.
3721
3722 2019-05-08  Tom Tromey  <tom@tromey.com>
3723
3724         * breakpoint.c (breakpoint_objfile_key): Change type.
3725         (get_breakpoint_objfile_data): Update.
3726         (free_breakpoint_objfile_data): Remove.
3727         (_initialize_breakpoint): Update.
3728
3729 2019-05-08  Tom Tromey  <tom@tromey.com>
3730
3731         * linux-tdep.c (struct linux_info): Add initializers.
3732         (linux_inferior_data): Move.  Change type.
3733         (invalidate_linux_cache_inf): Update.
3734         (linux_inferior_data_cleanup): Remove.
3735         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3736
3737 2019-05-08  Tom Tromey  <tom@tromey.com>
3738
3739         * auxv.c (auxv_inferior_data): Move.  Change type.
3740         (auxv_inferior_data_cleanup): Remove.
3741         (invalidate_auxv_cache_inf): Rewrite.
3742         (get_auxv_inferior_data, _initialize_auxv): Update.
3743
3744 2019-05-08  Tom Tromey  <tom@tromey.com>
3745
3746         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3747         (symfile_debug_objfile_data_key): Change type.
3748         (symfile_debug_installed, debug_qf_has_symbols)
3749         (debug_qf_find_last_source_symtab)
3750         (debug_qf_forget_cached_source_info)
3751         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3752         (debug_qf_print_stats, debug_qf_dump)
3753         (debug_qf_expand_symtabs_for_function)
3754         (debug_qf_expand_all_symtabs)
3755         (debug_qf_expand_symtabs_with_fullname)
3756         (debug_qf_map_matching_symbols)
3757         (debug_qf_expand_symtabs_matching)
3758         (debug_qf_find_pc_sect_compunit_symtab)
3759         (debug_qf_map_symbol_filenames)
3760         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3761         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3762         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3763         (debug_sym_read_linetable, debug_sym_relocate): Update.
3764         (symfile_debug_free_objfile): Remove.
3765         (install_symfile_debug_logging, _initialize_symfile_debug):
3766         Update.
3767
3768 2019-05-08  Tom Tromey  <tom@tromey.com>
3769
3770         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3771         allocate_on_obstack.
3772         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3773         (get_dwarf2_per_objfile): Update.
3774         (set_dwarf2_per_objfile): Remove.
3775         (dwarf2_has_info, dwarf2_get_section_info): Update.
3776         (dwarf2_free_objfile): Remove.
3777         (_initialize_dwarf2_read): Update.
3778
3779 2019-05-08  Tom Tromey  <tom@tromey.com>
3780
3781         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3782         initializers.
3783         <unsupported_script_warning_printed,
3784         script_not_found_warning_printed>: Now bool.
3785         (auto_load_pspace_data): Change type.
3786         (~auto_load_pspace_info): Rename from
3787         auto_load_pspace_data_cleanup.
3788         (get_auto_load_pspace_data, init_loaded_scripts_info)
3789         (clear_section_scripts, maybe_print_unsupported_script_warning)
3790         (maybe_print_script_not_found_warning, _initialize_auto_load):
3791         Update.
3792
3793 2019-05-08  Tom Tromey  <tom@tromey.com>
3794
3795         * objfiles.c (objfile_pspace_info): Add destructor and
3796         initializers.
3797         (objfiles_pspace_data): Change type.
3798         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3799         (get_objfile_pspace_data): Update.
3800         (objfiles_bfd_data): Change type.
3801         (get_objfile_bfd_data): Update.
3802         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3803
3804 2019-05-08  Tom Tromey  <tom@tromey.com>
3805
3806         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3807         Change type.
3808         (get_catch_syscall_inferior_data): Update.
3809         (catch_syscall_inferior_data_cleanup): Remove.
3810         (_initialize_break_catch_syscall): Update.
3811
3812 2019-05-08  Tom Tromey  <tom@tromey.com>
3813
3814         * inflow.c (struct terminal_info): Add destructor and
3815         initializers.
3816         (inflow_inferior_data): Change type.
3817         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3818         (get_inflow_inferior_data, inflow_inferior_exit)
3819         (swap_terminal_info, _initialize_inflow): Update.
3820
3821 2019-05-08  Tom Tromey  <tom@tromey.com>
3822
3823         * target-dcache.c (target_dcache_cleanup): Remove.
3824         (target_dcache_aspace_key): Change type.
3825         (target_dcache_init_p, target_dcache_invalidate)
3826         (target_dcache_get, target_dcache_get_or_init)
3827         (_initialize_target_dcache): Update.
3828         * dcache.h (struct dcache_deleter): New.
3829
3830 2019-05-08  Tom Tromey  <tom@tromey.com>
3831
3832         * symtab.c (struct symbol_cache): Add destructor and
3833         initializers.
3834         (symbol_cache_key): Move.  Change type.
3835         (make_symbol_cache, free_symbol_cache): Remove.
3836         (get_symbol_cache): Update.
3837         (symbol_cache_cleanup): Remove.
3838         (ALL_PSPACES, symbol_cache_flush)
3839         (maintenance_print_symbol_cache)
3840         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3841         Update.
3842
3843 2019-05-08  Tom Tromey  <tom@tromey.com>
3844
3845         * symtab.c (struct main_info): Add destructor and initializers.
3846         (main_progspace_key): Move.  Change type.
3847         (get_main_info): Update.
3848         (main_info_cleanup): Remove.
3849         (_initialize_symtab): Update.
3850
3851 2019-05-08  Tom Tromey  <tom@tromey.com>
3852
3853         * registry.h (DECLARE_REGISTRY): Define the _key class.
3854
3855 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3856
3857         * NEWS: Merge two 'New commands' sections.
3858
3859 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3860
3861         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3862         parameter and use Ada language definition instead.
3863         (ada_val_print_ptr): Remove unused language parameter.
3864         (ada_val_print_num): Remove language parameter and use Ada language
3865         definition instead.
3866         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3867         parameter.
3868         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3869         parameter and use Ada language definition instead.
3870         (ada_val_print_1): Update all ada_val_print_xxx calls.
3871         Remove language parameter.
3872         (ada_val_print): Update ada_val_print_1 call.
3873
3874 2019-05-08  Tom Tromey  <tromey@adacore.com>
3875
3876         * remote.c (remote_hw_watchpoint_limit)
3877         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3878         Now static.
3879
3880 2019-05-08  Tom Tromey  <tromey@adacore.com>
3881
3882         * maint.c (_initialize_maint_cmds): Move initialization code to
3883         remote.c.
3884         (watchdog, show_watchdog): Move to remote.c.
3885         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3886         "watchdog" static.
3887         (_initialize_remote): Move initialization code from maint.c.
3888         * defs.h (watchdog): Don't declare.
3889
3890 2019-05-08  Tom Tromey  <tromey@adacore.com>
3891
3892         * tui/tui-interp.c: Include main.h.
3893         * interps.c: Include main.h.
3894         * main.h (interpreter_p): Declare.
3895         * defs.h (interpreter_p): Don't declare.
3896
3897 2019-05-08  Tom Tromey  <tromey@adacore.com>
3898
3899         * dwarf2loc.c: Include dwarf2read.h.
3900         * defs.h (read_unsigned_leb128): Don't declare.
3901         * dwarf2read.h (read_unsigned_leb128): Declare.
3902
3903 2019-05-08  Tom Tromey  <tromey@adacore.com>
3904
3905         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3906         method.
3907
3908 2019-05-08  Tom Tromey  <tromey@adacore.com>
3909
3910         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3911         when no wrap column is set.
3912
3913 2019-05-08  Tom Tromey  <tromey@adacore.com>
3914
3915         * c-lang.c (c_get_string): Handle non-C-style arrays.
3916
3917 2019-05-08  Tom Tromey  <tromey@adacore.com>
3918
3919         * typeprint.c (print_offset_data::update): Print the bit offset,
3920         not the number of bits remaining.
3921
3922 2019-05-08  Tom Tromey  <tromey@adacore.com>
3923
3924         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3925         padding at end of comment.
3926
3927 2019-05-08  Tom Tromey  <tromey@adacore.com>
3928
3929         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3930         Compare main types.
3931
3932 2019-05-06  Tom Tromey  <tom@tromey.com>
3933
3934         * common/scoped_mmap.c: Include common-defs.h.
3935         * common/scoped_mmap.h: Don't include config.h.
3936
3937 2019-05-04  Tom Tromey  <tom@tromey.com>
3938
3939         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3940         (struct aarch64_call_info): Add initializers.
3941         <si>: Now a std::vector.
3942         (pass_on_stack, aarch64_push_dummy_call): Update.
3943
3944 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3945             Tom Tromey  <tom@tromey.com>
3946
3947         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3948         (ppc_threads): Now a std::vector.  Now static.
3949         (hwdebug_find_thread_points_by_tid)
3950         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3951         Update.
3952
3953 2019-05-04  Tom Tromey  <tom@tromey.com>
3954
3955         * arc-tdep.c (arc_tdesc_init): Return bool.
3956
3957 2019-05-04  Tom Tromey  <tom@tromey.com>
3958
3959         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3960         Use gdb_assert_not_reached.
3961
3962 2019-05-04  Tom Tromey  <tom@tromey.com>
3963
3964         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3965         "false".
3966
3967 2019-05-04  Tom Tromey  <tom@tromey.com>
3968
3969         * arc-tdep.c (arc_tdesc_init): Use bool.
3970
3971 2019-05-04  Tom Tromey  <tom@tromey.com>
3972
3973         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3974
3975 2019-05-04  Tom Tromey  <tom@tromey.com>
3976
3977         * cli/cli-cmds.c (valid_command_p): Return bool.
3978
3979 2019-05-04  Tom Tromey  <tom@tromey.com>
3980
3981         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3982         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3983
3984 2019-05-04  Raul Tambre  <raul@tambre.ee>
3985
3986         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3987         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3988         operator for comparison.
3989
3990 2019-05-04  Tom Tromey  <tom@tromey.com>
3991
3992         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3993         (lookup_partial_symbol, print_partial_symbols)
3994         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3995         (psymbol_compare): Update.
3996         (add_psymbol_to_bcache): Clear the entire psymbol.
3997         (maintenance_check_psymtabs): Update.
3998         * psympriv.h (struct partial_symbol): Don't derive from
3999         general_symbol_info.
4000         <obj_section, unrelocated_address, address,
4001         set_unrelocated_address>: Update.
4002         <ginfo>: New member.
4003         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4004         (debug_names::write_psymbols): Update.
4005
4006 2019-05-04  Tom de Vries  <tdevries@suse.de>
4007
4008         * contrib/cc-with-tweaks.sh: Support -n arg.
4009
4010 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4011
4012         * corelow.c (core_target::detach): Ensure frame cache and
4013         register caches are cleared.
4014         inferior.c (exit_inferior_1): Likewise.
4015
4016 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4017             Tom Tromey  <tom@tromey.com>
4018
4019         * dictionary.c (collate_pending_symbols_by_language): Remove
4020         "struct" from foreach.
4021         * symtab.c (lookup_global_symbol_from_objfile)
4022         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4023         foreach.
4024         * ser-tcp.c (net_open): Remove "struct" from foreach.
4025         * objfiles.c (objfile_relocate, objfile_rebase)
4026         (objfile_has_symbols): Remove "struct" from foreach.
4027         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4028         from foreach.
4029         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4030         foreach.
4031         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4032         "struct" from foreach.
4033         * ada-lang.c (create_excep_cond_exprs)
4034         (ada_exception_catchpoint_cond_string): Remove "struct" from
4035         foreach.
4036
4037 2019-05-03  Tom Tromey  <tromey@adacore.com>
4038
4039         * ada-exp.y (convert_char_literal): Check suffix of each
4040         enumerator.
4041
4042 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4043
4044         PR ada/21406:
4045         * ada-exp.y (yywrap): Don't define.
4046         * ada-lex.l (%option): Add noyywrap
4047         (yywrap): Remove.
4048
4049 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4050
4051         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4052         _WIN32_WINNT to the XP level, unless already defined to a higher
4053         level.
4054
4055         * unittests/parse-connection-spec-selftests.c:
4056         * ser-tcp.c:
4057         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4058         override.
4059
4060         * symfile.c (find_separate_debug_file): Remove colon from the
4061         drive spec of DOS/Windows file names of the target, so that the
4062         file name produced from DEBUGDIR and the target's directory will
4063         be valid on DOS/Windows systems.
4064
4065 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4066
4067         * rust-lang.c (val_print_struct): Handle printing structures
4068         containing strings.
4069
4070 2019-05-02  Tom Tromey  <tromey@adacore.com>
4071
4072         * valarith.c (_initialize_valarith): Remove.
4073
4074 2019-05-01  Tom Tromey  <tromey@adacore.com>
4075
4076         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4077         bitfields.
4078
4079 2019-05-01  Tom Tromey  <tromey@adacore.com>
4080
4081         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4082         for big-endian copies.
4083
4084 2019-04-30  Ali Tamur  <tamur@google.com>
4085         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4086         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4087         (read_3_bytes): New function.
4088
4089 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4090
4091         * windows-nat.c (main_thread_id): Delete.
4092         (handle_output_debug_string): Replace main_thread_id by
4093         current_event.dwThreadId.
4094         (fake_create_process): Likewise.
4095         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4096         Do not set main_thread_id.
4097         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4098         current_event.dwThreadId.
4099         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4100
4101 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4102
4103         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4104         Use current_event.dwThreadId instead of main_thread_id.
4105
4106 2019-04-30  Tom Tromey  <tromey@adacore.com>
4107
4108         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4109         (create_excep_cond_exprs): Iterate over program spaces.
4110         (ada_exception_catchpoint_cond_string): Examine all minimal
4111         symbols for exception types.
4112
4113 2019-04-30  Tom Tromey  <tromey@adacore.com>
4114
4115         PR c++/24470:
4116         * dwarf2read.c (process_structure_scope): Handle case where type
4117         has template parameters but no symbol was created.
4118
4119 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4120             Chris January  <chris.january@arm.com>
4121
4122         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4123         qualifier.
4124         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4125
4126 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4127
4128         * f-typeprint.c (f_print_type): Update rules for printing
4129         whitespace.
4130         (f_type_print_varspec_suffix): Likewise.
4131
4132 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4133             Chris January  <chris.january@arm.com>
4134
4135         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4136         function arguments.
4137
4138 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4139
4140         * f-lang.c (build_fortran_types): Change name of void type to
4141         lower case.
4142         * f-typeprint.c (f_type_print_base): Print the name of the void
4143         type, rather than a fixed string.
4144         * f-valprint.c (f_decorations): Use lower case void string.
4145
4146 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4147             Chris January  <chris.january@arm.com>
4148
4149         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4150         types for Fortran.
4151
4152 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4153             Chris January  <chris.january@arm.com>
4154             David Lecomber  <david.lecomber@arm.com>
4155
4156         * f-exp.y (BINOP_INTRINSIC): New token.
4157         (exp): New parser rule handling BINOP_INTRINSIC.
4158         (f77_keywords): Add new builtin procedures.
4159         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4160         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4161         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4162         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4163         (print_unop_subexp_f): New function.
4164         (print_binop_subexp_f): New function.
4165         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4166         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4167         (dump_subexp_body_f): Likewise.
4168         (operator_check_f): Likewise.
4169         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4170         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4171
4172 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4173
4174         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4175         UNOP_KIND.
4176         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4177         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4178         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4179         (operator_length_f): New fuction.
4180         (print_subexp_f): New function.
4181         (op_name_f): New function.
4182         (dump_subexp_body_f): New function.
4183         (operator_check_f): New function.
4184         (exp_descriptor_f): Replace standard expression handling functions
4185         with new functions.
4186         * gdb/fortran-operator.def: New file.
4187         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4188         * gdb/std-operator.def: Remove UNOP_KIND.
4189
4190 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4191
4192         * std-operator.def: Remove unbalanced, stray double quote
4193         character.
4194
4195 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4196             Chris January  <chris.january@arm.com>
4197             Daniel Everett  <daniel.everett@arm.com>
4198             Nick Forrington  <nick.forrington@arm.com>
4199             Richard Bunt  <richard.bunt@arm.com>
4200
4201         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4202         of depth when printing anonymous structs or unions.
4203         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4204         Don't print either the top-level value, or the children if the
4205         max-depth is exceeded.
4206         (ppscm_print_children): When printing the key of a map, allow one
4207         extra level of depth.
4208         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4209         print either the top-level value, or the children if the max-depth
4210         is exceeded.
4211         (print_children): When printing the key of a map, allow one extra
4212         level of depth.
4213         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4214         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4215         (user_print_options): Initialise max_depth field.
4216         (val_print_scalar_or_string_type_p): New function.
4217         (val_print): Check to see if the max depth has been reached.
4218         (val_print_check_max_depth): Define new function.
4219         (show_print_max_depth): New function.
4220         (_initialize_valprint): Add 'print max-depth' option.
4221         * valprint.h (struct value_print_options) <max_depth>: New field.
4222         (val_print_check_max_depth): Declare new function.
4223         * NEWS: Document new feature.
4224
4225 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4226
4227         * ada-lang.c (ada_language_defn): Initialise new field.
4228         * c-lang.c (c_is_string_type_p): New function.
4229         (c_language_defn): Initialise new field.
4230         (cplus_language_defn): Initialise new field.
4231         (asm_language_defn): Initialise new field.
4232         (minimal_language_defn): Initialise new field.
4233         * c-lang.h (c_is_string_type_p): Declare new function.
4234         * d-lang.c (d_language_defn): Initialise new field.
4235         * f-lang.c (f_is_string_type_p): New function.
4236         (f_language_defn): Initialise new field.
4237         * go-lang.c (go_is_string_type_p): New function.
4238         (go_language_defn): Initialise new field.
4239         * language.c (default_is_string_type_p): New function.
4240         (unknown_language_defn): Initialise new field.
4241         (auto_language_defn): Initialise new field.
4242         * language.h (struct language_defn) <la_is_string_type_p>: New
4243         member variable.
4244         (default_is_string_type_p): Declare new function.
4245         * m2-lang.c (m2_language_defn): Initialise new field.
4246         * objc-lang.c (objc_language_defn): Initialise new field.
4247         * opencl-lang.c (opencl_language_defn): Initialise new field.
4248         * p-lang.c (pascal_is_string_type_p): New function.
4249         (pascal_language_defn): Initialise new field.
4250         * rust-lang.c (rust_is_string_type_p): New function.
4251         (rust_language_defn): Initialise new field.
4252
4253 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4254
4255         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4256         New field.
4257         * ada-lang.c (ada_language_defn): Initialise new field.
4258         * c-lang.c (c_language_defn): Likewise.
4259         (cplus_language_defn): Likewise.
4260         (asm_language_defn): Likewise.
4261         (minimal_language_defn): Likewise.
4262         * d-lang.c (d_language_defn): Likewise.
4263         * f-lang.c (f_language_defn): Likewise.
4264         * go-lang.c (go_language_defn): Likewise.
4265         * language.c (unknown_language_defn): Likewise.
4266         (auto_language_defn): Likewise.
4267         * m2-lang.c (m2_language_defn): Likewise.
4268         * objc-lang.c (objc_language_defn): Likewise.
4269         * opencl-lang.c (opencl_language_defn): Likewise.
4270         * p-lang.c (pascal_language_defn): Likewise.
4271         * rust-lang.c (rust_language_defn): Likewise.
4272
4273 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4274
4275         * ada-lang.c (ada_is_character_type): Change return type to bool.
4276         (ada_is_string_type): Likewise.
4277         * ada-lang.h (ada_is_character_type): Update declaration
4278         (ada_is_string_type): Likewise.
4279
4280 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4281
4282         Support style in 'frame|thread apply'
4283
4284         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4285         * record.c (record_start, record_stop): Update callers of
4286         execute_command_to_string with false.
4287         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4288         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4289         methods.
4290         (class string_file): New constructor with term_out parameter.
4291         Override methods term_out and can_emit_style_escape.  New member
4292         term_out.
4293         (class stdio_file): Override can_emit_style_escape.
4294         (class tee_file): Override term_out and can_emit_style_escape.
4295         * utils.h (can_emit_style_escape): Remove.
4296         * utils.c (can_emit_style_escape): Likewise.
4297         Update all callers of can_emit_style_escape (SOMESTREAM) to
4298         SOMESTREAM->can_emit_style_escape.
4299         * source-cache.c (source_cache::get_source_lines): Likewise.
4300         * stack.c (frame_apply_command_count): Call execute_command_to_string
4301         passing the term_out characteristic of the current gdb_stdout.
4302         * thread.c (thr_try_catch_cmd): Likewise.
4303         * top.c (execute_command_to_string): pass term_out parameter
4304         to construct the string_file for the command output.
4305         * ui-file.c (term_cli_styling): New function (most code moved
4306         from utils.c can_emit_style_escape).
4307         (string_file::string_file, string_file::can_emit_style_escape,
4308         stdio_file::can_emit_style_escape, tee_file::term_out,
4309         tee_file::can_emit_style_escape): New functions.
4310
4311 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4312
4313         * NEWS: Mention the new set|show may-call-functions.
4314         * infcall.c (may_call_functions_p): New variable.
4315         (show_may_call_functions_p): New function.
4316         (call_function_by_hand_dummy): Throws an error if not
4317         may-call-functions.
4318         (_initialize_infcall): Call add_setshow_boolean_cmd for
4319         may-call-functions.
4320
4321 2019-04-25  Keith Seitz  <keiths@redhat.com>
4322
4323         PR c++/24367
4324         * cp-support.c (inspect_type): Don't attempt substitutions
4325         of symbol with the same name.
4326
4327 2019-04-25  Tom Tromey  <tromey@adacore.com>
4328
4329         PR gdb/24475:
4330         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4331         static.
4332
4333 2019-04-25  Tom Tromey  <tromey@adacore.com>
4334
4335         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4336         rvalue reference.
4337         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4338         (gdb_xml_parser::parse): Use std::move.
4339         * python/python-internal.h (gdbpy_convert_exception): Take a const
4340         reference.
4341         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4342         std::move.
4343         * python/py-utils.c (gdbpy_convert_exception): Take a const
4344         reference.
4345         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4346         Use std::move.
4347         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4348         Use std::move.
4349         * mi/mi-main.c (mi_print_exception): Take a const reference.
4350         * main.c (handle_command_errors): Take a const reference.
4351         * linespec.c (parse_linespec): Use std::move.
4352         * infcall.c (run_inferior_call): Use std::move.
4353         (call_function_by_hand_dummy): Use std::move.
4354         * exec.c (try_open_exec_file): Use std::move.
4355         * exceptions.h (exception_print, exception_fprintf)
4356         (exception_print_same): Update.
4357         * exceptions.c (print_exception, exception_print)
4358         (exception_fprintf, exception_print_same): Change parameters to
4359         const reference.
4360         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4361         * common/new-op.c: Use std::move.
4362         * common/common-exceptions.h (struct gdb_exception): Add move
4363         constructor.
4364         (struct gdb_exception_error, struct gdb_exception_quit, struct
4365         gdb_quit_bad_alloc): Change constructor to move constructor.
4366         (throw_exception): Change parameter to rvalue reference.
4367         * common/common-exceptions.c (throw_exception): Take rvalue
4368         reference.
4369         * cli/cli-interp.c (safe_execute_command): Use std::move.
4370         * breakpoint.c (insert_bp_location, location_to_sals): Use
4371         std::move.
4372
4373 2019-04-25  Tom Tromey  <tromey@adacore.com>
4374
4375         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4376         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4377         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4378         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4379         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4380         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4381         guile/scm-value.c: Use unpack.
4382         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4383         gdbscm_gdb_exception.
4384         (gdbscm_throw_gdb_exception): Likewise.
4385         (struct gdbscm_gdb_exception): New.
4386         (unpack): New function.
4387         (gdbscm_wrap): Use unpack.
4388
4389 2019-04-25  Tom Tromey  <tromey@adacore.com>
4390
4391         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4392         (gdb_rl_callback_handler): Use std::move.
4393         * common/common-exceptions.h (struct gdb_exception): Add move
4394         assignment operator.
4395         (throw_exception_sjlj): Change "exception" to const reference.
4396         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4397         (throw_exception_sjlj): Change "exception" to const reference.
4398
4399 2019-04-25  Tom Tromey  <tromey@adacore.com>
4400
4401         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4402         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4403         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4404         Update.
4405         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4406         Update.
4407         * mi/mi-interp.c (mi_interp::exec): Update.
4408         * linespec.c (parse_linespec): Update.
4409         * infcall.c (run_inferior_call): Update.
4410         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4411         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4412         (gdbscm_lookup_global_symbol): Update.
4413         * guile/scm-param.c (gdbscm_parameter_value): Update.
4414         * guile/scm-frame.c (gdbscm_frame_read_register)
4415         (gdbscm_frame_read_var): Update.
4416         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4417         * exec.c (try_open_exec_file): Update.
4418         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4419         (gdb_rl_callback_handler): Update.
4420         * common/common-exceptions.h (exception_none): Don't declare.
4421         * common/common-exceptions.c (exception_none): Don't define.
4422         (struct catcher) <exception>: Update.
4423         * cli/cli-interp.c (safe_execute_command): Update.
4424         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4425
4426 2019-04-25  Ali Tamur  <tamur@google.com>
4427
4428         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4429         (read_attribute_value): Likewise.
4430         (dwarf2_read_addr_index): Update comment.
4431         (read_str_index): Add DW_FORM_strx.
4432         (dwarf2_string_attr): Likewise.
4433         (dwarf2_const_value_attr): Likewise.
4434         (dump_die_shallow): Likewise.
4435         (dwarf2_fetch_constant_bytes): Likewise.
4436         (skip_form_bytes): Likewise.
4437         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4438
4439 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4440
4441         PR corefiles/11608
4442         PR corefiles/18187
4443         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4444         OFFSET.  Verify if current mapping contains an ELF header.
4445         (linux_find_memory_regions_full): Adjust call to
4446         dump_mapping_p.
4447
4448 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4449             Kang Li <kanglictf@gmail.com>
4450
4451         PR gdb/21600
4452
4453         * dwarf2-frame.c (read_initial_length): Be consistent about using
4454         unsigned representation of length.
4455         (decode_frame_entry_1): Likewise.  Check for wraparound of
4456         end pointer as well as buffer overflow.
4457
4458 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4459
4460         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4461         "vq".
4462
4463 2019-04-24  Tom Tromey  <tromey@adacore.com>
4464
4465         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4466
4467 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4468
4469         * s12z-tdep.c (s12z_unwind_pc): Delete.
4470         (s12z_unwind_sp): Delete.
4471         (s12z_gdbarch_init): Don't register deleted functions with
4472         gdbarch.
4473
4474 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4475
4476         * rl78-tdep.c (rl78_unwind_sp): Delete.
4477         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4478
4479 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4480
4481         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4482         (xstormy16_unwind_pc): Delete.
4483         (xstormy16_dummy_id): Delete.
4484         (xstormy16_gdbarch_init): Don't register deleted functions with
4485         gdbarch.
4486
4487 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4488
4489         * vax-tdep.c (vax_unwind_pc): Delete.
4490         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4491
4492 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4493
4494         * v850-tdep.c (v850_unwind_sp): Delete.
4495         (v850_unwind_pc): Delete.
4496         (v850_dummy_id): Delete.
4497         (v850_gdbarch_init): Don't register deleted functions with
4498         gdbarch.
4499
4500 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4501
4502         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4503         (tilegx_unwind_pc): Delete.
4504         (tilegx_unwind_dummy_id): Delete.
4505         (tilegx_gdbarch_init): Don't register deleted functions with
4506         gdbarch.
4507
4508 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4509
4510         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4511         (tic6x_dummy_id): Delete.
4512         (tic6x_gdbarch_init): Don't register deleted functions with
4513         gdbarch.
4514
4515 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4516
4517         * sparc-tdep.c (sparc_unwind_pc): Delete.
4518         (sparc32_gdbarch_init): Don't register deleted function with
4519         gdbarch.
4520
4521 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4522
4523         * sh-tdep.c (sh_unwind_sp): Delete.
4524         (sh_unwind_pc): Delete.
4525         (sh_dummy_id): Delete.
4526         (sh_gdbarch_init): Don't register deleted functions with
4527         gdbarch.
4528
4529 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4530
4531         * score-tdep.c (score_unwind_sp): Delete.
4532         (score_unwind_pc): Delete.
4533         (score_dummy_id): Delete.
4534         (score_gdbarch_init): Don't register deleted functions with
4535         gdbarch.
4536
4537 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4538
4539         * rx-tdep.c (rx_unwind_pc): Delete.
4540         (rx_unwind_sp): Delete.
4541         (rx_dummy_id): Delete.
4542         (rx_gdbarch_init): Don't register deleted functions with
4543         gdbarch.  Update comment.
4544
4545 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4546
4547         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4548         (rs6000_dummy_id): Delete.
4549         (rs6000_gdbarch_init): Don't register deleted functions with
4550         gdbarch.
4551
4552 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4553
4554         * or1k-tdep.c (or1k_dummy_id): Delete.
4555         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4556
4557 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4558
4559         * nios2-tdep.c (nios2_dummy_id): Delete.
4560         (nios2_unwind_sp): Delete.
4561         (nios2_gdbarch_init): Don't register deleted functions with
4562         gdbarch.
4563
4564 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4565
4566         * nds32-tdep.c (nds32_dummy_id): Delete.
4567         (nds32_unwind_pc): Delete.
4568         (nds32_unwind_sp): Delete.
4569         (nds32_gdbarch_init): Don't register deleted functions with
4570         gdbarch.
4571
4572 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4573
4574         * msp430-tdep.c (msp430_unwind_pc): Delete.
4575         (msp430_unwind_sp): Delete.
4576         (msp430_dummy_id): Delete.
4577         (msp430_gdbarch_init): Don't register deleted functions with
4578         gdbarch.
4579
4580 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4581
4582         * moxie-tdep.c (moxie_unwind_sp): Delete.
4583         (moxie_unwind_pc): Delete.
4584         (moxie_dummy_id): Delete.
4585         (moxie_gdbarch_init): Don't register deleted functions with
4586         gdbarch.
4587
4588 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4589
4590         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4591         (mn10300_unwind_pc): Delete.
4592         (mn10300_unwind_sp): Delete.
4593         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4594         mn10300_unwind_sp.
4595         (mn10300_frame_unwind_init): Don't register deleted functions with
4596         gdbarch.
4597
4598 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4599
4600         * mep-tdep.c (mep_unwind_pc): Delete.
4601         (mep_unwind_sp): Delete.
4602         (mep_dummy_id): Delete.
4603         (mep_gdbarch_init): Don't register deleted functions with
4604         gdbarch.
4605
4606 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4607
4608         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4609         (m68hc11_unwind_sp): Delete.
4610         (m68hc11_gdbarch_init): Don't register deleted functions with
4611         gdbarch.
4612
4613 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4614
4615         * m32r-tdep.c (m32r_unwind_sp): Delete.
4616         (m32r_unwind_pc): Delete.
4617         (m32r_dummy_id): Delete.
4618         (m32r_gdbarch_init): Don't register deleted functions with
4619         gdbarch.
4620
4621 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4622
4623         * m32c-tdep.c (m32c_unwind_pc): Delete.
4624         (m32c_unwind_sp): Delete.
4625         (m32c_dummy_id): Delete.
4626         (m32c_gdbarch_init): Don't register deleted functions with
4627         gdbarch.
4628
4629 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4630
4631         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4632         (lm32_unwind_pc): Delete.
4633         (lm32_dummy_id): Delete.
4634         (lm32_gdbarch_init): Don't register deleted functions with
4635         gdbarch.
4636
4637 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4638
4639         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4640         (iq2000_unwind_pc): Delete.
4641         (iq2000_dummy_id): Delete.
4642         (iq2000_gdbarch_init): Don't register deleted functions with
4643         gdbarch.
4644
4645 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4646
4647         * nds32-tdep.c (nds32_type_align): Delete.
4648         (nds32_push_dummy_call): Use type_align instead.
4649
4650 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4651
4652         * arm-tdep.c (arm_type_align): Only handle vector override case.
4653         (arm_push_dummy_call): Use type_align.
4654         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4655
4656 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4657
4658         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4659         case.
4660         (pass_on_stack): Use type_align.
4661         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4662         function.
4663
4664 2019-04-23  Tom Tromey  <tromey@adacore.com>
4665
4666         * dwarf2read.c (line_header::file_name_at): Remove unused
4667         overload.
4668
4669 2019-04-23  Tom de Vries  <tdevries@suse.de>
4670
4671         PR gdb/24438
4672         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4673         invocation.
4674
4675
4676 2019-03-27  Ali Tamur  <tamur@google.com>
4677
4678         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4679         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4680         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4681         (dwarf_expr_context::get_addr_index): Likewise
4682         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4683         (symbol_needs_eval_context::get_addr_index): Likewise
4684         (disassemble_dwarf_expression): Add DW_OP_addrx
4685         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4686         (read_cutu_die_from_dwo): Update comment
4687         (skip_one_die): Add DW_FORM_addrx
4688         (read_attribute_value): Likewise
4689         (var_decode_location): Add DW_OP_addrx
4690         (dwarf2_const_value_attr): Add DW_FORM_addrx
4691         (dump_die_shallow): Likewise
4692         (dwarf2_fetch_constant_bytes): Likewise
4693         (decode_locdesc): Add DW_OP_addrx
4694         (skip_form_bytes): Add DW_FORM_addrx
4695
4696 2019-04-22  Ali Tamur  <tamur@google.com>
4697
4698         * MAINTAINERS (Write After Approval): Add self.
4699
4700 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4701
4702         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4703         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4704         (open_symbol_file_object): Likewise.
4705         (svr4_default_sos): Add info parameter.
4706         (svr4_read_so_list): Likewise.
4707         (svr4_current_sos_direct): Adjust functions calls to pass down
4708         info.
4709         (svr4_current_sos_1): Add info parameter.
4710         (svr4_current_sos): Call get_svr4_info, pass info down to
4711         svr4_current_sos_1.
4712         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4713         get_svr4_info.
4714         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4715         get_svr4_info.
4716         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4717         to get_svr4_info.
4718         (probes_table_remove_objfile_probes): Likewise.
4719         (register_solib_event_probe): Add info parameter.
4720         (solist_update_incremental): Pass info parameter down to
4721         svr4_read_so_list.
4722         (disable_probes_interface): Add info parameter.
4723         (svr4_handle_solib_event): Pass current_program_space to
4724         get_svr4_info.  Adjust disable_probes_interface cleanup.
4725         (svr4_create_probe_breakpoints): Add info parameter, pass it
4726         down to register_solib_event_probe.
4727         (svr4_create_solib_event_breakpoints): Add info parameter,
4728         pass it down to svr4_create_probe_breakpoints.
4729         (enable_break): Pass info down to
4730         svr4_create_solib_event_breakpoints.
4731         (svr4_solib_create_inferior_hook): Pass current_program_space to
4732         get_svr4_info.
4733         (svr4_clear_solib): Likewise.
4734
4735 2019-04-22  Pedro Alves  <palves@redhat.com>
4736
4737         * solib-svr4.c (svr4_free_objfile_observer): New.
4738         (probe_and_action::objfile): New field.
4739         (probes_table_htab_remove_objfile_probes)
4740         (probes_table_remove_objfile_probes): New functions.
4741         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4742         in the new probe_and_action.  Don't store the probe in 'lookup'.
4743         (svr4_create_probe_breakpoints): Pass objfile to
4744         register_solib_event_probe.
4745         (_initialize_svr4_solib): Register a free_objfile observer.
4746
4747 2019-04-19  Tom Tromey  <tom@tromey.com>
4748
4749         * common/queue.h: Remove.
4750
4751 2019-04-19  Tom Tromey  <tom@tromey.com>
4752
4753         * event-loop.c: Don't include "common/queue.h".
4754
4755 2019-04-19  Tom Tromey  <tom@tromey.com>
4756
4757         * remote.c (remote_target): Use delete.
4758         * remote-notif.h: Include <list>, not "common/queue.h".
4759         (notif_client_p): Remove typedef.
4760         (remote_notif_state): Add constructor, destructor, initializer.
4761         <notif_queue>: Now a std::list.
4762         (remote_notif_state_xfree): Don't declare.
4763         * remote-notif.c (remote_notif_process, handle_notification)
4764         (remote_notif_state_allocate): Update.
4765         (~remote_notif_state): Rename from remote_notif_state_xfree.
4766
4767 2019-04-19  Tom Tromey  <tom@tromey.com>
4768
4769         * symfile.c (reread_symbols): Update.
4770         * objfiles.c (objfile_register_static_link)
4771         (objfile_lookup_static_link): Update
4772         (~objfile) Don't delete static_links.
4773         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4774
4775 2019-04-19  Tom Tromey  <tom@tromey.com>
4776
4777         * type-stack.h (struct type_stack) <insert>: Constify string.
4778         * type-stack.c (type_stack::insert): Constify string.
4779         * gdbtypes.h (lookup_template_type): Update.
4780         (address_space_name_to_int): Update.
4781         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4782         const.
4783         (lookup_template_type): Make name const.
4784         * c-exp.y: Update rules.
4785         (lex_one_token, classify_name, classify_inner_name)
4786         (c_print_token): Update.
4787         * p-exp.y: Update rules.
4788         (yylex): Update.
4789         * f-exp.y: Update rules.
4790         (yylex): Update.
4791         * d-exp.y: Update rules.
4792         (lex_one_token, classify_name, classify_inner_name): Update.
4793         * parse.c (write_dollar_variable, copy_name): Return std::string.
4794         * parser-defs.h (copy_name): Change return type.
4795         * m2-exp.y: Update rules.
4796         (yylex): Update.
4797         * go-exp.y (lex_one_token): Update.
4798         Update rules.
4799         (classify_unsafe_function, classify_packaged_name)
4800         (classify_name, yylex): Update.
4801
4802 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4803
4804         * configure.ac: add --enable-source-highlight switch.
4805         * configure: Regenerate.
4806         * top.c (print_gdb_version): plumb --enable-source-highlight
4807         status to "show configuration".
4808
4809 2019-04-19  Tom Tromey  <tromey@adacore.com>
4810
4811         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4812         Check ADA_TYPE_P.
4813         (empty_record, ada_template_to_fixed_record_type_1)
4814         (template_to_static_fixed_type)
4815         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4816         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4817         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4818         macros.
4819
4820 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4821
4822         PR symtab/24423:
4823         * source.c (print_source_lines_base): Advance "iter" when a
4824         control character is seen.
4825
4826 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4827
4828         * inferior.h (struct infcall_suspend_state_deleter):
4829         Catch exception in destructor to avoid crash.
4830
4831 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4832
4833         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4834         close to the add_com "shell".
4835
4836 2019-04-18  Tom Tromey  <tromey@adacore.com>
4837
4838         * process-stratum-target.h (class process_stratum_target)
4839         <stratum>: Add "final".
4840
4841 2019-04-17  Tom Tromey  <tromey@adacore.com>
4842
4843         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4844         against nullptr before use.
4845
4846 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4847
4848         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4849
4850 2019-04-17  Jim Wilson  <jimw@sifive.com>
4851             Andrew Burgess  <andrew.burgess@embecosm.com>
4852
4853         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4854         code read might fail, assume 4-byte breakpoint in that case.
4855
4856 2019-04-15  Leszek Swirski  <leszeks@google.com>
4857
4858         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4859         rather than a hand-rolled POD check when checking for forced MEMORY
4860         classification.
4861
4862 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4863
4864         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4865         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4866         function.
4867         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4868         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4869         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4870         declaration.
4871
4872 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4873
4874         * aarch64-linux-nat.c
4875         (aarch64_linux_nat_target::thread_architecture): Add override.
4876         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4877         each VQ.
4878
4879 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4880
4881         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4882
4883 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4884
4885         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4886         target types of size 96-bits, add some additional comments, and
4887         check that the builtin type we found was the correct size.
4888
4889 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4890
4891         * utils.c (prompt_for_continue): Don't restore the styling at the
4892         end, as applied_style has the wrong value.  This fixes styling in
4893         long lists of file names that are interrupted by the "Continue?"
4894         prompt.
4895
4896 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4897
4898         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4899         * c-lang.c (c_language_defn): Likewise.
4900         (cplus_language_defn): Likewise.
4901         (asm_language_defn): Likewise.
4902         (minimal_language_defn): Likewise.
4903         * d-lang.c (d_language_defn): Likewise.
4904         * f-lang.c (f_language_defn): Likewise.
4905         * go-lang.c (go_language_defn): Likewise.
4906         * language.c (unknown_language_defn): Likewise.
4907         (auto_language_defn): Likewise.
4908         * language.h (struct language_defn): Remove la_magic field.
4909         (LANG_MAGIC): Delete.
4910         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4911         * objc-lang.c (objc_language_defn): Likewise.
4912         * opencl-lang.c (opencl_language_defn): Likewise.
4913         * p-lang.c (pascal_language_defn): Likewise.
4914         * rust-lang.c (rust_language_defn): Likewise.
4915
4916 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4917
4918         * riscv-tdep.c (riscv_type_align): New function.
4919         (riscv_type_alignment): Delete.
4920         (riscv_arg_location): Use 'type_align'.
4921         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4922
4923 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4924
4925         * gdbtypes.c (type_align): A struct with no non-static fields also
4926         has alignment of 1.
4927
4928 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4929
4930         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4931         component to 0.
4932         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4933         member.
4934         (riscv_struct_info::analyse): New implementation using new
4935         analyse_inner member function.
4936         (riscv_struct_info::field_offset): New member function.
4937         (riscv_struct_info::m_offsets): New member variable.
4938         (riscv_struct_info::analyse_inner): New private member function,
4939         takes the old implementation of riscv_struct_info::analyse but
4940         extended to track field offsets.
4941         (riscv_call_arg_struct): Update the struct folding special cases
4942         to handle cases where empty C++ structs, which are non-zero
4943         length, are found.
4944         (riscv_arg_location): Initialise the length of each location, a
4945         non-zero length now indicates the location is in use.
4946         (riscv_push_dummy_call): Allow for the first location having a
4947         non-zero offset when setting up arguments.
4948         (riscv_return_value): Likewise, but for return values.
4949
4950 2019-04-11  Tom Tromey  <tromey@adacore.com>
4951
4952         * utils.c (internal_vproblem): Make "msg" const.
4953
4954 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4955
4956         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4957         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4958         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4959         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4960
4961 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4962
4963         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4964         function.
4965         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4966         of amd64_collect_native_gregset.
4967         (amd64_linux_nat_target::store_registers): Likewise.
4968
4969 2019-04-10  Tom Tromey  <tom@tromey.com>
4970
4971         * symtab.c (lookup_global_symbol_from_objfile)
4972         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4973         * objfiles.h (class separate_debug_iterator): New.
4974         (class separate_debug_range): New.
4975         (struct objfile) <separate_debug_objfiles>: New method.
4976         (objfile_separate_debug_iterate): Don't declare.
4977         * objfiles.c (separate_debug_iterator::operator++): Rename from
4978         objfile_separate_debug_iterate.
4979         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4980         iterator.
4981         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4982         iterator.
4983
4984 2019-04-10  Tom Tromey  <tom@tromey.com>
4985
4986         * symfile.c (reread_symbols): Remove old comment.
4987         * objfiles.c (free_all_objfiles): Fix a typo.
4988
4989 2019-04-10  Tom Tromey  <tom@tromey.com>
4990
4991         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4992         * minsyms.c (lookup_minimal_symbol): Use foreach.
4993         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4994         (lookup_minimal_symbol_solib_trampoline): Likewise.
4995         * symfile.c (reread_symbols): Use foreach.
4996
4997 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4998             Tom Tromey  <tromey@adacore.com>
4999
5000         PR rust/24414:
5001         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5002         (rust_lex_int_test): Change "value" to be LONGEST.
5003         (rust_lex_tests): Add test for long integer literal.
5004
5005 2019-04-09  Tom Tromey  <tromey@adacore.com>
5006
5007         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5008         to bool.
5009         (extended_remote_target::attach): Update.
5010         (remote_target::remote_notice_new_inferior): Update.
5011         (remote_target::add_current_inferior_and_thread): Update.
5012         * inferior.c (exit_inferior_1): Use "false".
5013         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5014
5015 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5016
5017         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5018         the "start" command.
5019
5020 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5021
5022         * python/py-inferior.c (infpy_thread_from_thread_handle):
5023         Adjust comments to reflect renaming of thread_from_thread_handle
5024         to thread_from_handle.  Adjust keywords.  Fix type error message.
5025         (inferior_object_methods): Add thread_from_handle.  Retain
5026         thread_from_thread_handle, but mark it as deprecated.
5027
5028 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5029
5030         * gdbthread.h (find_thread_by_handle): Revise declaration.
5031         * thread.c (find_thread_by_handle): Likewise.  Adjust
5032         implementation too.
5033         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5034         support for buffer objects as handles.
5035
5036 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5037
5038         * python/py-infthread.c (thpy_thread_handle): New function.
5039         (thread_object_methods): Register thpy_thread_handle.
5040
5041 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5042
5043         * gdbthread.h (thread_to_thread_handle): Declare.
5044         * thread.c (gdbtypes.h): Include.
5045         (thread_to_thread_handle): New function.
5046
5047         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5048         (target_thread_info_to_thread_handle): Declare.
5049         * target.c (target_thread_info_to_thread_handle): New function.
5050         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5051         * target-delegates.c: Regenerate.
5052
5053         * linux-thread-db.c (class thread_db_target): Add method
5054         thread_info_to_thread_handle.
5055         (thread_db_target::thread_info_to_thread_handle): Define.
5056         * remote.c (class remote_target): Add new method
5057         thread_info_to_thread_handle.
5058         (remote_target::thread_info_to_thread_handle): Define.
5059
5060 2019-04-08  Pedro Alves  <palves@redhat.com>
5061
5062         * common/common-exceptions.c (throw_exception): Don't create
5063         named object to throw; throw directly.
5064         (throw_it): Likewise.  Don't initialize gdb_exception::message
5065         here, with new; pass FMT and AP to the ctor instead.
5066         * common/common-exceptions.h: Include <string>.
5067         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5068         const char *, va_list)): New ctor.  Use std::make_shared.
5069         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5070         errors)): Delete.
5071         (gdb_exception_error::gdb_exception_error(enum errors, const char
5072         *, va_list)): New.
5073         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5074         Add assertion.
5075         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5076         errors)): Delete.
5077         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5078         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5079         Add assertion.
5080
5081 2019-04-08  Tom Tromey  <tom@tromey.com>
5082
5083         * valops.c (value_rtti_indirect_type): Replace throw_exception
5084         with throw.
5085         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5086         with throw.
5087         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5088         throw.
5089         * target.c (target_translate_tls_address): Replace throw_exception
5090         with throw.
5091         * stack.c (frame_apply_command_count): Replace throw_exception
5092         with throw.
5093         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5094         throw.
5095         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5096         with throw.
5097         * rs6000-tdep.c (rs6000_frame_cache)
5098         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5099         * remote.c: Replace throw_exception with throw.
5100         * record-full.c (record_full_message, record_full_wait_1)
5101         (record_full_restore): Replace throw_exception with throw.
5102         * record-btrace.c:
5103         (get_thread_current_frame_id, record_btrace_start_replaying)
5104         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5105         (cmd_record_btrace_start): Replace throw_exception with throw.
5106         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5107         throw.
5108         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5109         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5110         * linespec.c:
5111         (find_linespec_symbols): Replace throw_exception with throw.
5112         * infrun.c (displaced_step_prepare, resume): Replace
5113         throw_exception with throw.
5114         * infcmd.c (post_create_inferior): Replace throw_exception with
5115         throw.
5116         * inf-loop.c (inferior_event_handler): Replace throw_exception
5117         with throw.
5118         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5119         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5120         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5121         (get_prev_frame_always, get_frame_pc_if_available)
5122         (get_frame_address_in_block_if_available, get_frame_language):
5123         Replace throw_exception with throw.
5124         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5125         throw_exception with throw.
5126         * eval.c (fetch_subexp_value, evaluate_var_value)
5127         (evaluate_funcall, evaluate_subexp_standard): Replace
5128         throw_exception with throw.
5129         * dwarf2loc.c (call_site_find_chain)
5130         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5131         Replace throw_exception with throw.
5132         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5133         with throw.
5134         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5135         throw.
5136         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5137         * completer.c (complete_line_internal): Replace throw_exception
5138         with throw.
5139         * compile/compile-object-run.c (compile_object_run): Replace
5140         throw_exception with throw.
5141         * cli/cli-script.c (process_next_line): Replace throw_exception
5142         with throw.
5143         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5144         (btrace_enable, btrace_maint_update_pt_packets): Replace
5145         throw_exception with throw.
5146         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5147         throw_exception with throw.
5148         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5149         throw_exception with throw.
5150         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5151         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5152         * aarch64-tdep.c (aarch64_make_prologue_cache)
5153         (aarch64_make_stub_cache): Replace throw_exception with throw.
5154
5155 2019-04-08  Tom Tromey  <tom@tromey.com>
5156
5157         * common/common-exceptions.c (throw_exception): Rename from
5158         throw_exception_cxx.  Remove old copy.  Make argument const.
5159         (throw_it): Create and throw exception objects directly.
5160         * common/common-exceptions.h (throw_exception): Make argument
5161         const.
5162         (struct gdb_exception_error): Add constructor.
5163         (struct gdb_exception_quit): Add constructor.
5164
5165 2019-04-08  Tom Tromey  <tom@tromey.com>
5166
5167         * common/common-exceptions.h (exception_rethrow): Don't declare.
5168         (TRY_SJLJ): Update comment.
5169         (TRY, CATCH, END_CATCH): Remove.
5170         * common/common-exceptions.c (exception_rethrow): Remove.
5171
5172 2019-04-08  Tom Tromey  <tom@tromey.com>
5173
5174         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5175         Remove.
5176         (gdb_exception_error): Rename from
5177         gdb_exception_RETURN_MASK_ERROR.
5178         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5179         (gdb_quit_bad_alloc): Update.
5180         * aarch64-tdep.c: Update.
5181         * ada-lang.c: Update.
5182         * ada-typeprint.c: Update.
5183         * ada-valprint.c: Update.
5184         * amd64-tdep.c: Update.
5185         * arch-utils.c: Update.
5186         * break-catch-throw.c: Update.
5187         * breakpoint.c: Update.
5188         * btrace.c: Update.
5189         * c-varobj.c: Update.
5190         * cli/cli-cmds.c: Update.
5191         * cli/cli-interp.c: Update.
5192         * cli/cli-script.c: Update.
5193         * common/common-exceptions.c: Update.
5194         * common/new-op.c: Update.
5195         * common/selftest.c: Update.
5196         * compile/compile-c-symbols.c: Update.
5197         * compile/compile-cplus-symbols.c: Update.
5198         * compile/compile-object-load.c: Update.
5199         * compile/compile-object-run.c: Update.
5200         * completer.c: Update.
5201         * corelow.c: Update.
5202         * cp-abi.c: Update.
5203         * cp-support.c: Update.
5204         * cp-valprint.c: Update.
5205         * darwin-nat.c: Update.
5206         * disasm-selftests.c: Update.
5207         * dtrace-probe.c: Update.
5208         * dwarf-index-cache.c: Update.
5209         * dwarf-index-write.c: Update.
5210         * dwarf2-frame-tailcall.c: Update.
5211         * dwarf2-frame.c: Update.
5212         * dwarf2loc.c: Update.
5213         * dwarf2read.c: Update.
5214         * eval.c: Update.
5215         * event-loop.c: Update.
5216         * event-top.c: Update.
5217         * exec.c: Update.
5218         * f-valprint.c: Update.
5219         * fbsd-tdep.c: Update.
5220         * frame-unwind.c: Update.
5221         * frame.c: Update.
5222         * gdbtypes.c: Update.
5223         * gnu-v3-abi.c: Update.
5224         * guile/guile-internal.h: Update.
5225         * guile/scm-block.c: Update.
5226         * guile/scm-breakpoint.c: Update.
5227         * guile/scm-cmd.c: Update.
5228         * guile/scm-disasm.c: Update.
5229         * guile/scm-frame.c: Update.
5230         * guile/scm-lazy-string.c: Update.
5231         * guile/scm-math.c: Update.
5232         * guile/scm-param.c: Update.
5233         * guile/scm-ports.c: Update.
5234         * guile/scm-pretty-print.c: Update.
5235         * guile/scm-symbol.c: Update.
5236         * guile/scm-symtab.c: Update.
5237         * guile/scm-type.c: Update.
5238         * guile/scm-value.c: Update.
5239         * i386-linux-tdep.c: Update.
5240         * i386-tdep.c: Update.
5241         * inf-loop.c: Update.
5242         * infcall.c: Update.
5243         * infcmd.c: Update.
5244         * infrun.c: Update.
5245         * jit.c: Update.
5246         * language.c: Update.
5247         * linespec.c: Update.
5248         * linux-fork.c: Update.
5249         * linux-nat.c: Update.
5250         * linux-tdep.c: Update.
5251         * linux-thread-db.c: Update.
5252         * main.c: Update.
5253         * mi/mi-cmd-break.c: Update.
5254         * mi/mi-cmd-stack.c: Update.
5255         * mi/mi-interp.c: Update.
5256         * mi/mi-main.c: Update.
5257         * objc-lang.c: Update.
5258         * p-valprint.c: Update.
5259         * parse.c: Update.
5260         * ppc-linux-tdep.c: Update.
5261         * printcmd.c: Update.
5262         * python/py-arch.c: Update.
5263         * python/py-breakpoint.c: Update.
5264         * python/py-cmd.c: Update.
5265         * python/py-finishbreakpoint.c: Update.
5266         * python/py-frame.c: Update.
5267         * python/py-framefilter.c: Update.
5268         * python/py-gdb-readline.c: Update.
5269         * python/py-inferior.c: Update.
5270         * python/py-infthread.c: Update.
5271         * python/py-lazy-string.c: Update.
5272         * python/py-linetable.c: Update.
5273         * python/py-objfile.c: Update.
5274         * python/py-param.c: Update.
5275         * python/py-prettyprint.c: Update.
5276         * python/py-progspace.c: Update.
5277         * python/py-record-btrace.c: Update.
5278         * python/py-record.c: Update.
5279         * python/py-symbol.c: Update.
5280         * python/py-type.c: Update.
5281         * python/py-unwind.c: Update.
5282         * python/py-utils.c: Update.
5283         * python/py-value.c: Update.
5284         * python/python.c: Update.
5285         * record-btrace.c: Update.
5286         * record-full.c: Update.
5287         * remote-fileio.c: Update.
5288         * remote.c: Update.
5289         * riscv-tdep.c: Update.
5290         * rs6000-aix-tdep.c: Update.
5291         * rs6000-tdep.c: Update.
5292         * rust-exp.y: Update.
5293         * rust-lang.c: Update.
5294         * s390-tdep.c: Update.
5295         * selftest-arch.c: Update.
5296         * solib-dsbt.c: Update.
5297         * solib-frv.c: Update.
5298         * solib-spu.c: Update.
5299         * solib-svr4.c: Update.
5300         * solib.c: Update.
5301         * sparc64-linux-tdep.c: Update.
5302         * stack.c: Update.
5303         * symfile-mem.c: Update.
5304         * symmisc.c: Update.
5305         * target.c: Update.
5306         * thread.c: Update.
5307         * top.c: Update.
5308         * tracefile-tfile.c: Update.
5309         * tui/tui.c: Update.
5310         * typeprint.c: Update.
5311         * unittests/cli-utils-selftests.c: Update.
5312         * unittests/parse-connection-spec-selftests.c: Update.
5313         * valops.c: Update.
5314         * valprint.c: Update.
5315         * value.c: Update.
5316         * varobj.c: Update.
5317         * windows-nat.c: Update.
5318         * x86-linux-nat.c: Update.
5319         * xml-support.c: Update.
5320
5321 2019-04-08  Tom Tromey  <tom@tromey.com>
5322
5323         * xml-support.c: Use C++ exception handling.
5324         * x86-linux-nat.c: Use C++ exception handling.
5325         * windows-nat.c: Use C++ exception handling.
5326         * varobj.c: Use C++ exception handling.
5327         * value.c: Use C++ exception handling.
5328         * valprint.c: Use C++ exception handling.
5329         * valops.c: Use C++ exception handling.
5330         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5331         handling.
5332         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5333         * typeprint.c: Use C++ exception handling.
5334         * tui/tui.c: Use C++ exception handling.
5335         * tracefile-tfile.c: Use C++ exception handling.
5336         * top.c: Use C++ exception handling.
5337         * thread.c: Use C++ exception handling.
5338         * target.c: Use C++ exception handling.
5339         * symmisc.c: Use C++ exception handling.
5340         * symfile-mem.c: Use C++ exception handling.
5341         * stack.c: Use C++ exception handling.
5342         * sparc64-linux-tdep.c: Use C++ exception handling.
5343         * solib.c: Use C++ exception handling.
5344         * solib-svr4.c: Use C++ exception handling.
5345         * solib-spu.c: Use C++ exception handling.
5346         * solib-frv.c: Use C++ exception handling.
5347         * solib-dsbt.c: Use C++ exception handling.
5348         * selftest-arch.c: Use C++ exception handling.
5349         * s390-tdep.c: Use C++ exception handling.
5350         * rust-lang.c: Use C++ exception handling.
5351         * rust-exp.y: Use C++ exception handling.
5352         * rs6000-tdep.c: Use C++ exception handling.
5353         * rs6000-aix-tdep.c: Use C++ exception handling.
5354         * riscv-tdep.c: Use C++ exception handling.
5355         * remote.c: Use C++ exception handling.
5356         * remote-fileio.c: Use C++ exception handling.
5357         * record-full.c: Use C++ exception handling.
5358         * record-btrace.c: Use C++ exception handling.
5359         * python/python.c: Use C++ exception handling.
5360         * python/py-value.c: Use C++ exception handling.
5361         * python/py-utils.c: Use C++ exception handling.
5362         * python/py-unwind.c: Use C++ exception handling.
5363         * python/py-type.c: Use C++ exception handling.
5364         * python/py-symbol.c: Use C++ exception handling.
5365         * python/py-record.c: Use C++ exception handling.
5366         * python/py-record-btrace.c: Use C++ exception handling.
5367         * python/py-progspace.c: Use C++ exception handling.
5368         * python/py-prettyprint.c: Use C++ exception handling.
5369         * python/py-param.c: Use C++ exception handling.
5370         * python/py-objfile.c: Use C++ exception handling.
5371         * python/py-linetable.c: Use C++ exception handling.
5372         * python/py-lazy-string.c: Use C++ exception handling.
5373         * python/py-infthread.c: Use C++ exception handling.
5374         * python/py-inferior.c: Use C++ exception handling.
5375         * python/py-gdb-readline.c: Use C++ exception handling.
5376         * python/py-framefilter.c: Use C++ exception handling.
5377         * python/py-frame.c: Use C++ exception handling.
5378         * python/py-finishbreakpoint.c: Use C++ exception handling.
5379         * python/py-cmd.c: Use C++ exception handling.
5380         * python/py-breakpoint.c: Use C++ exception handling.
5381         * python/py-arch.c: Use C++ exception handling.
5382         * printcmd.c: Use C++ exception handling.
5383         * ppc-linux-tdep.c: Use C++ exception handling.
5384         * parse.c: Use C++ exception handling.
5385         * p-valprint.c: Use C++ exception handling.
5386         * objc-lang.c: Use C++ exception handling.
5387         * mi/mi-main.c: Use C++ exception handling.
5388         * mi/mi-interp.c: Use C++ exception handling.
5389         * mi/mi-cmd-stack.c: Use C++ exception handling.
5390         * mi/mi-cmd-break.c: Use C++ exception handling.
5391         * main.c: Use C++ exception handling.
5392         * linux-thread-db.c: Use C++ exception handling.
5393         * linux-tdep.c: Use C++ exception handling.
5394         * linux-nat.c: Use C++ exception handling.
5395         * linux-fork.c: Use C++ exception handling.
5396         * linespec.c: Use C++ exception handling.
5397         * language.c: Use C++ exception handling.
5398         * jit.c: Use C++ exception handling.
5399         * infrun.c: Use C++ exception handling.
5400         * infcmd.c: Use C++ exception handling.
5401         * infcall.c: Use C++ exception handling.
5402         * inf-loop.c: Use C++ exception handling.
5403         * i386-tdep.c: Use C++ exception handling.
5404         * i386-linux-tdep.c: Use C++ exception handling.
5405         * guile/scm-value.c: Use C++ exception handling.
5406         * guile/scm-type.c: Use C++ exception handling.
5407         * guile/scm-symtab.c: Use C++ exception handling.
5408         * guile/scm-symbol.c: Use C++ exception handling.
5409         * guile/scm-pretty-print.c: Use C++ exception handling.
5410         * guile/scm-ports.c: Use C++ exception handling.
5411         * guile/scm-param.c: Use C++ exception handling.
5412         * guile/scm-math.c: Use C++ exception handling.
5413         * guile/scm-lazy-string.c: Use C++ exception handling.
5414         * guile/scm-frame.c: Use C++ exception handling.
5415         * guile/scm-disasm.c: Use C++ exception handling.
5416         * guile/scm-cmd.c: Use C++ exception handling.
5417         * guile/scm-breakpoint.c: Use C++ exception handling.
5418         * guile/scm-block.c: Use C++ exception handling.
5419         * guile/guile-internal.h: Use C++ exception handling.
5420         * gnu-v3-abi.c: Use C++ exception handling.
5421         * gdbtypes.c: Use C++ exception handling.
5422         * frame.c: Use C++ exception handling.
5423         * frame-unwind.c: Use C++ exception handling.
5424         * fbsd-tdep.c: Use C++ exception handling.
5425         * f-valprint.c: Use C++ exception handling.
5426         * exec.c: Use C++ exception handling.
5427         * event-top.c: Use C++ exception handling.
5428         * event-loop.c: Use C++ exception handling.
5429         * eval.c: Use C++ exception handling.
5430         * dwarf2read.c: Use C++ exception handling.
5431         * dwarf2loc.c: Use C++ exception handling.
5432         * dwarf2-frame.c: Use C++ exception handling.
5433         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5434         * dwarf-index-write.c: Use C++ exception handling.
5435         * dwarf-index-cache.c: Use C++ exception handling.
5436         * dtrace-probe.c: Use C++ exception handling.
5437         * disasm-selftests.c: Use C++ exception handling.
5438         * darwin-nat.c: Use C++ exception handling.
5439         * cp-valprint.c: Use C++ exception handling.
5440         * cp-support.c: Use C++ exception handling.
5441         * cp-abi.c: Use C++ exception handling.
5442         * corelow.c: Use C++ exception handling.
5443         * completer.c: Use C++ exception handling.
5444         * compile/compile-object-run.c: Use C++ exception handling.
5445         * compile/compile-object-load.c: Use C++ exception handling.
5446         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5447         * compile/compile-c-symbols.c: Use C++ exception handling.
5448         * common/selftest.c: Use C++ exception handling.
5449         * common/new-op.c: Use C++ exception handling.
5450         * cli/cli-script.c: Use C++ exception handling.
5451         * cli/cli-interp.c: Use C++ exception handling.
5452         * cli/cli-cmds.c: Use C++ exception handling.
5453         * c-varobj.c: Use C++ exception handling.
5454         * btrace.c: Use C++ exception handling.
5455         * breakpoint.c: Use C++ exception handling.
5456         * break-catch-throw.c: Use C++ exception handling.
5457         * arch-utils.c: Use C++ exception handling.
5458         * amd64-tdep.c: Use C++ exception handling.
5459         * ada-valprint.c: Use C++ exception handling.
5460         * ada-typeprint.c: Use C++ exception handling.
5461         * ada-lang.c: Use C++ exception handling.
5462         * aarch64-tdep.c: Use C++ exception handling.
5463
5464 2019-04-08  Tom Tromey  <tom@tromey.com>
5465
5466         * xml-support.c (gdb_xml_parser::parse): Update.
5467         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5468         * value.c (show_convenience): Update.
5469         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5470         (test_parse_flags_qcs): Update.
5471         * thread.c (thr_try_catch_cmd): Update.
5472         * target.c (target_translate_tls_address): Update.
5473         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5474         (info_frame_command_core, frame_apply_command_count): Update.
5475         * rust-exp.y (rust_lex_exception_test): Update.
5476         * riscv-tdep.c (riscv_print_one_register_info): Update.
5477         * remote.c (remote_target::enable_btrace): Update.
5478         * record-btrace.c (record_btrace_enable_warn): Update.
5479         * python/py-utils.c (gdbpy_convert_exception): Update.
5480         * printcmd.c (do_one_display, print_variable_and_value): Update.
5481         * mi/mi-main.c (mi_print_exception): Update.
5482         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5483         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5484         * linux-nat.c (linux_nat_target::attach): Update.
5485         * linux-fork.c (class scoped_switch_fork_info): Update.
5486         * infrun.c (displaced_step_prepare): Update.
5487         * infcall.c (call_function_by_hand_dummy): Update.
5488         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5489         * gnu-v3-abi.c (print_one_vtable): Update.
5490         * frame.c (get_prev_frame_always): Update.
5491         * f-valprint.c (info_common_command_for_block): Update.
5492         * exec.c (try_open_exec_file): Update.
5493         * exceptions.c (print_exception, exception_print)
5494         (exception_fprintf, exception_print_same): Update.
5495         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5496         * dwarf-index-cache.c (index_cache::store)
5497         (index_cache::lookup_gdb_index): Update.
5498         * darwin-nat.c (maybe_cache_shell): Update.
5499         * cp-valprint.c (cp_print_value_fields): Update.
5500         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5501         (gcc_cplus_symbol_address): Update.
5502         * compile/compile-c-symbols.c (gcc_convert_symbol)
5503         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5504         * common/selftest.c: Update.
5505         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5506         a std::string.
5507         (exception_try_scope_entry, exception_try_scope_exit): Don't
5508         declare.
5509         (struct exception_try_scope): Remove.
5510         (TRY): Don't use exception_try_scope.
5511         (struct gdb_exception): Add constructor, operator=.
5512         <what>: New method.
5513         (struct gdb_exception_RETURN_MASK_ALL)
5514         (struct gdb_exception_RETURN_MASK_ERROR)
5515         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5516         (struct gdb_quit_bad_alloc): Update.
5517         * common/common-exceptions.c (exception_none): Change
5518         initializer.
5519         (struct catcher) <state, exception>: Initialize inline.
5520         <prev>: Remove member.
5521         (current_catcher): Remove.
5522         (catchers): New global.
5523         (exceptions_state_mc_init): Simplify.
5524         (catcher_pop): Remove.
5525         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5526         (try_scope_depth, exception_try_scope_entry)
5527         (exception_try_scope_exit): Remove.
5528         (throw_exception_sjlj): Update.
5529         (exception_messages, exception_messages_size): Remove.
5530         (throw_it): Simplify.
5531         (gdb_exception_sliced_copy): Remove.
5532         (throw_exception_cxx): Update.
5533         * cli/cli-script.c (script_from_file): Update.
5534         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5535         Update.
5536         * ada-valprint.c (ada_val_print): Update.
5537         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5538         (create_excep_cond_exprs): Update.
5539
5540 2019-04-08  Tom Tromey  <tom@tromey.com>
5541
5542         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5543         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5544         (TRY, CATCH, END_CATCH): Remove some definitions.
5545         * common/common-exceptions.c: Don't use GDB_XCPT.
5546         (catcher_list_size): Remove.
5547         (throw_exception, throw_it): Simplify.
5548
5549 2019-04-05  Tom Tromey  <tom@tromey.com>
5550
5551         Revert the header-sorting patch.
5552         * ft32-tdep.c: Revert.
5553         * frv-tdep.c: Revert.
5554         * frv-linux-tdep.c: Revert.
5555         * frame.c: Revert.
5556         * frame-unwind.c: Revert.
5557         * frame-base.c: Revert.
5558         * fork-child.c: Revert.
5559         * findvar.c: Revert.
5560         * findcmd.c: Revert.
5561         * filesystem.c: Revert.
5562         * filename-seen-cache.h: Revert.
5563         * filename-seen-cache.c: Revert.
5564         * fbsd-tdep.c: Revert.
5565         * fbsd-nat.h: Revert.
5566         * fbsd-nat.c: Revert.
5567         * f-valprint.c: Revert.
5568         * f-typeprint.c: Revert.
5569         * f-lang.c: Revert.
5570         * extension.h: Revert.
5571         * extension.c: Revert.
5572         * extension-priv.h: Revert.
5573         * expprint.c: Revert.
5574         * exec.h: Revert.
5575         * exec.c: Revert.
5576         * exceptions.c: Revert.
5577         * event-top.c: Revert.
5578         * event-loop.c: Revert.
5579         * eval.c: Revert.
5580         * elfread.c: Revert.
5581         * dwarf2read.h: Revert.
5582         * dwarf2read.c: Revert.
5583         * dwarf2loc.c: Revert.
5584         * dwarf2expr.h: Revert.
5585         * dwarf2expr.c: Revert.
5586         * dwarf2-frame.c: Revert.
5587         * dwarf2-frame-tailcall.c: Revert.
5588         * dwarf-index-write.h: Revert.
5589         * dwarf-index-write.c: Revert.
5590         * dwarf-index-common.c: Revert.
5591         * dwarf-index-cache.h: Revert.
5592         * dwarf-index-cache.c: Revert.
5593         * dummy-frame.c: Revert.
5594         * dtrace-probe.c: Revert.
5595         * disasm.h: Revert.
5596         * disasm.c: Revert.
5597         * disasm-selftests.c: Revert.
5598         * dictionary.c: Revert.
5599         * dicos-tdep.c: Revert.
5600         * demangle.c: Revert.
5601         * dcache.h: Revert.
5602         * dcache.c: Revert.
5603         * darwin-nat.h: Revert.
5604         * darwin-nat.c: Revert.
5605         * darwin-nat-info.c: Revert.
5606         * d-valprint.c: Revert.
5607         * d-namespace.c: Revert.
5608         * d-lang.c: Revert.
5609         * ctf.c: Revert.
5610         * csky-tdep.c: Revert.
5611         * csky-linux-tdep.c: Revert.
5612         * cris-tdep.c: Revert.
5613         * cris-linux-tdep.c: Revert.
5614         * cp-valprint.c: Revert.
5615         * cp-support.c: Revert.
5616         * cp-namespace.c: Revert.
5617         * cp-abi.c: Revert.
5618         * corelow.c: Revert.
5619         * corefile.c: Revert.
5620         * continuations.c: Revert.
5621         * completer.h: Revert.
5622         * completer.c: Revert.
5623         * complaints.c: Revert.
5624         * coffread.c: Revert.
5625         * coff-pe-read.c: Revert.
5626         * cli-out.h: Revert.
5627         * cli-out.c: Revert.
5628         * charset.c: Revert.
5629         * c-varobj.c: Revert.
5630         * c-valprint.c: Revert.
5631         * c-typeprint.c: Revert.
5632         * c-lang.c: Revert.
5633         * buildsym.c: Revert.
5634         * buildsym-legacy.c: Revert.
5635         * build-id.h: Revert.
5636         * build-id.c: Revert.
5637         * btrace.c: Revert.
5638         * bsd-uthread.c: Revert.
5639         * breakpoint.h: Revert.
5640         * breakpoint.c: Revert.
5641         * break-catch-throw.c: Revert.
5642         * break-catch-syscall.c: Revert.
5643         * break-catch-sig.c: Revert.
5644         * blockframe.c: Revert.
5645         * block.c: Revert.
5646         * bfin-tdep.c: Revert.
5647         * bfin-linux-tdep.c: Revert.
5648         * bfd-target.c: Revert.
5649         * bcache.c: Revert.
5650         * ax-general.c: Revert.
5651         * ax-gdb.h: Revert.
5652         * ax-gdb.c: Revert.
5653         * avr-tdep.c: Revert.
5654         * auxv.c: Revert.
5655         * auto-load.c: Revert.
5656         * arm-wince-tdep.c: Revert.
5657         * arm-tdep.c: Revert.
5658         * arm-symbian-tdep.c: Revert.
5659         * arm-pikeos-tdep.c: Revert.
5660         * arm-obsd-tdep.c: Revert.
5661         * arm-nbsd-tdep.c: Revert.
5662         * arm-nbsd-nat.c: Revert.
5663         * arm-linux-tdep.c: Revert.
5664         * arm-linux-nat.c: Revert.
5665         * arm-fbsd-tdep.c: Revert.
5666         * arm-fbsd-nat.c: Revert.
5667         * arm-bsd-tdep.c: Revert.
5668         * arch-utils.c: Revert.
5669         * arc-tdep.c: Revert.
5670         * arc-newlib-tdep.c: Revert.
5671         * annotate.h: Revert.
5672         * annotate.c: Revert.
5673         * amd64-windows-tdep.c: Revert.
5674         * amd64-windows-nat.c: Revert.
5675         * amd64-tdep.c: Revert.
5676         * amd64-sol2-tdep.c: Revert.
5677         * amd64-obsd-tdep.c: Revert.
5678         * amd64-obsd-nat.c: Revert.
5679         * amd64-nbsd-tdep.c: Revert.
5680         * amd64-nbsd-nat.c: Revert.
5681         * amd64-nat.c: Revert.
5682         * amd64-linux-tdep.c: Revert.
5683         * amd64-linux-nat.c: Revert.
5684         * amd64-fbsd-tdep.c: Revert.
5685         * amd64-fbsd-nat.c: Revert.
5686         * amd64-dicos-tdep.c: Revert.
5687         * amd64-darwin-tdep.c: Revert.
5688         * amd64-bsd-nat.c: Revert.
5689         * alpha-tdep.c: Revert.
5690         * alpha-obsd-tdep.c: Revert.
5691         * alpha-nbsd-tdep.c: Revert.
5692         * alpha-mdebug-tdep.c: Revert.
5693         * alpha-linux-tdep.c: Revert.
5694         * alpha-linux-nat.c: Revert.
5695         * alpha-bsd-tdep.c: Revert.
5696         * alpha-bsd-nat.c: Revert.
5697         * aix-thread.c: Revert.
5698         * agent.c: Revert.
5699         * addrmap.c: Revert.
5700         * ada-varobj.c: Revert.
5701         * ada-valprint.c: Revert.
5702         * ada-typeprint.c: Revert.
5703         * ada-tasks.c: Revert.
5704         * ada-lang.c: Revert.
5705         * aarch64-tdep.c: Revert.
5706         * aarch64-ravenscar-thread.c: Revert.
5707         * aarch64-newlib-tdep.c: Revert.
5708         * aarch64-linux-tdep.c: Revert.
5709         * aarch64-linux-nat.c: Revert.
5710         * aarch64-fbsd-tdep.c: Revert.
5711         * aarch64-fbsd-nat.c: Revert.
5712         * aarch32-linux-nat.c: Revert.
5713
5714 2019-04-05  Tom Tromey  <tom@tromey.com>
5715
5716         * ft32-tdep.c: Sort headers.
5717         * frv-tdep.c: Sort headers.
5718         * frv-linux-tdep.c: Sort headers.
5719         * frame.c: Sort headers.
5720         * frame-unwind.c: Sort headers.
5721         * frame-base.c: Sort headers.
5722         * fork-child.c: Sort headers.
5723         * findvar.c: Sort headers.
5724         * findcmd.c: Sort headers.
5725         * filesystem.c: Sort headers.
5726         * filename-seen-cache.h: Sort headers.
5727         * filename-seen-cache.c: Sort headers.
5728         * fbsd-tdep.c: Sort headers.
5729         * fbsd-nat.h: Sort headers.
5730         * fbsd-nat.c: Sort headers.
5731         * f-valprint.c: Sort headers.
5732         * f-typeprint.c: Sort headers.
5733         * f-lang.c: Sort headers.
5734         * extension.h: Sort headers.
5735         * extension.c: Sort headers.
5736         * extension-priv.h: Sort headers.
5737         * expprint.c: Sort headers.
5738         * exec.h: Sort headers.
5739         * exec.c: Sort headers.
5740         * exceptions.c: Sort headers.
5741         * event-top.c: Sort headers.
5742         * event-loop.c: Sort headers.
5743         * eval.c: Sort headers.
5744         * elfread.c: Sort headers.
5745         * dwarf2read.h: Sort headers.
5746         * dwarf2read.c: Sort headers.
5747         * dwarf2loc.c: Sort headers.
5748         * dwarf2expr.h: Sort headers.
5749         * dwarf2expr.c: Sort headers.
5750         * dwarf2-frame.c: Sort headers.
5751         * dwarf2-frame-tailcall.c: Sort headers.
5752         * dwarf-index-write.h: Sort headers.
5753         * dwarf-index-write.c: Sort headers.
5754         * dwarf-index-common.c: Sort headers.
5755         * dwarf-index-cache.h: Sort headers.
5756         * dwarf-index-cache.c: Sort headers.
5757         * dummy-frame.c: Sort headers.
5758         * dtrace-probe.c: Sort headers.
5759         * disasm.h: Sort headers.
5760         * disasm.c: Sort headers.
5761         * disasm-selftests.c: Sort headers.
5762         * dictionary.c: Sort headers.
5763         * dicos-tdep.c: Sort headers.
5764         * demangle.c: Sort headers.
5765         * dcache.h: Sort headers.
5766         * dcache.c: Sort headers.
5767         * darwin-nat.h: Sort headers.
5768         * darwin-nat.c: Sort headers.
5769         * darwin-nat-info.c: Sort headers.
5770         * d-valprint.c: Sort headers.
5771         * d-namespace.c: Sort headers.
5772         * d-lang.c: Sort headers.
5773         * ctf.c: Sort headers.
5774         * csky-tdep.c: Sort headers.
5775         * csky-linux-tdep.c: Sort headers.
5776         * cris-tdep.c: Sort headers.
5777         * cris-linux-tdep.c: Sort headers.
5778         * cp-valprint.c: Sort headers.
5779         * cp-support.c: Sort headers.
5780         * cp-namespace.c: Sort headers.
5781         * cp-abi.c: Sort headers.
5782         * corelow.c: Sort headers.
5783         * corefile.c: Sort headers.
5784         * continuations.c: Sort headers.
5785         * completer.h: Sort headers.
5786         * completer.c: Sort headers.
5787         * complaints.c: Sort headers.
5788         * coffread.c: Sort headers.
5789         * coff-pe-read.c: Sort headers.
5790         * cli-out.h: Sort headers.
5791         * cli-out.c: Sort headers.
5792         * charset.c: Sort headers.
5793         * c-varobj.c: Sort headers.
5794         * c-valprint.c: Sort headers.
5795         * c-typeprint.c: Sort headers.
5796         * c-lang.c: Sort headers.
5797         * buildsym.c: Sort headers.
5798         * buildsym-legacy.c: Sort headers.
5799         * build-id.h: Sort headers.
5800         * build-id.c: Sort headers.
5801         * btrace.c: Sort headers.
5802         * bsd-uthread.c: Sort headers.
5803         * breakpoint.h: Sort headers.
5804         * breakpoint.c: Sort headers.
5805         * break-catch-throw.c: Sort headers.
5806         * break-catch-syscall.c: Sort headers.
5807         * break-catch-sig.c: Sort headers.
5808         * blockframe.c: Sort headers.
5809         * block.c: Sort headers.
5810         * bfin-tdep.c: Sort headers.
5811         * bfin-linux-tdep.c: Sort headers.
5812         * bfd-target.c: Sort headers.
5813         * bcache.c: Sort headers.
5814         * ax-general.c: Sort headers.
5815         * ax-gdb.h: Sort headers.
5816         * ax-gdb.c: Sort headers.
5817         * avr-tdep.c: Sort headers.
5818         * auxv.c: Sort headers.
5819         * auto-load.c: Sort headers.
5820         * arm-wince-tdep.c: Sort headers.
5821         * arm-tdep.c: Sort headers.
5822         * arm-symbian-tdep.c: Sort headers.
5823         * arm-pikeos-tdep.c: Sort headers.
5824         * arm-obsd-tdep.c: Sort headers.
5825         * arm-nbsd-tdep.c: Sort headers.
5826         * arm-nbsd-nat.c: Sort headers.
5827         * arm-linux-tdep.c: Sort headers.
5828         * arm-linux-nat.c: Sort headers.
5829         * arm-fbsd-tdep.c: Sort headers.
5830         * arm-fbsd-nat.c: Sort headers.
5831         * arm-bsd-tdep.c: Sort headers.
5832         * arch-utils.c: Sort headers.
5833         * arc-tdep.c: Sort headers.
5834         * arc-newlib-tdep.c: Sort headers.
5835         * annotate.h: Sort headers.
5836         * annotate.c: Sort headers.
5837         * amd64-windows-tdep.c: Sort headers.
5838         * amd64-windows-nat.c: Sort headers.
5839         * amd64-tdep.c: Sort headers.
5840         * amd64-sol2-tdep.c: Sort headers.
5841         * amd64-obsd-tdep.c: Sort headers.
5842         * amd64-obsd-nat.c: Sort headers.
5843         * amd64-nbsd-tdep.c: Sort headers.
5844         * amd64-nbsd-nat.c: Sort headers.
5845         * amd64-nat.c: Sort headers.
5846         * amd64-linux-tdep.c: Sort headers.
5847         * amd64-linux-nat.c: Sort headers.
5848         * amd64-fbsd-tdep.c: Sort headers.
5849         * amd64-fbsd-nat.c: Sort headers.
5850         * amd64-dicos-tdep.c: Sort headers.
5851         * amd64-darwin-tdep.c: Sort headers.
5852         * amd64-bsd-nat.c: Sort headers.
5853         * alpha-tdep.c: Sort headers.
5854         * alpha-obsd-tdep.c: Sort headers.
5855         * alpha-nbsd-tdep.c: Sort headers.
5856         * alpha-mdebug-tdep.c: Sort headers.
5857         * alpha-linux-tdep.c: Sort headers.
5858         * alpha-linux-nat.c: Sort headers.
5859         * alpha-bsd-tdep.c: Sort headers.
5860         * alpha-bsd-nat.c: Sort headers.
5861         * aix-thread.c: Sort headers.
5862         * agent.c: Sort headers.
5863         * addrmap.c: Sort headers.
5864         * ada-varobj.c: Sort headers.
5865         * ada-valprint.c: Sort headers.
5866         * ada-typeprint.c: Sort headers.
5867         * ada-tasks.c: Sort headers.
5868         * ada-lang.c: Sort headers.
5869         * aarch64-tdep.c: Sort headers.
5870         * aarch64-ravenscar-thread.c: Sort headers.
5871         * aarch64-newlib-tdep.c: Sort headers.
5872         * aarch64-linux-tdep.c: Sort headers.
5873         * aarch64-linux-nat.c: Sort headers.
5874         * aarch64-fbsd-tdep.c: Sort headers.
5875         * aarch64-fbsd-nat.c: Sort headers.
5876         * aarch32-linux-nat.c: Sort headers.
5877
5878 2019-04-04  Tom Tromey  <tom@tromey.com>
5879
5880         * varobj.c (varobj_create): Update.
5881         * rust-exp.y (struct rust_parser) <update_innermost_block,
5882         lookup_symbol>: New methods.
5883         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5884         Rename.
5885         (rust_parser::rust_lookup_type)
5886         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5887         * printcmd.c (display_command, do_one_display): Update.
5888         * parser-defs.h (struct parser_state) <parser_state>: Add
5889         "tracker" parameter.
5890         (block_tracker): New member.
5891         (class innermost_block_tracker) <innermost_block_tracker>: Add
5892         "types" parameter.
5893         <reset>: Remove method.
5894         (innermost_block): Don't declare.
5895         (null_post_parser): Update.
5896         * parse.c (innermost_block): Remove global.
5897         (write_dollar_variable): Update.
5898         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5899         Remove "tracker_types" parameter.
5900         (parse_expression): Add "tracker" parameter.
5901         (parse_expression_for_completion): Update.
5902         (null_post_parser): Add "tracker" parameter.
5903         * p-exp.y: Update rules.
5904         * m2-exp.y: Update rules.
5905         * language.h (struct language_defn) <la_post_parser>: Add
5906         "tracker" parameter.
5907         * go-exp.y: Update rules.
5908         * f-exp.y: Update rules.
5909         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5910         parameter.
5911         * d-exp.y: Update rules.
5912         * c-exp.y: Update rules.
5913         * breakpoint.c (set_breakpoint_condition): Create an
5914         innermost_block_tracker.
5915         (watch_command_1): Likewise.
5916         * ada-lang.c (resolve): Add "tracker" parameter.
5917         (resolve_subexp): Likewise.
5918         * ada-exp.y (write_var_from_sym): Update.
5919
5920 2019-04-04  Tom Tromey  <tom@tromey.com>
5921
5922         * type-stack.h: New file.
5923         * type-stack.c: New file.
5924         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5925         type-stack.h.
5926         (insert_into_type_stack, insert_type, push_type, push_type_int)
5927         (insert_type_address_space, pop_type, pop_type_int)
5928         (pop_typelist, pop_type_stack, append_type_stack)
5929         (push_type_stack, get_type_stack, push_typelist)
5930         (follow_type_instance_flags, follow_types): Don't declare.
5931         * parse.c (type_stack): Remove global.
5932         (parse_exp_in_context): Update.
5933         (insert_into_type_stack, insert_type, push_type, push_type_int)
5934         (insert_type_address_space, pop_type, pop_type_int)
5935         (pop_typelist, pop_type_stack, append_type_stack)
5936         (push_type_stack, get_type_stack, push_typelist)
5937         (follow_type_instance_flags, follow_types): Remove (moved to
5938         type-stack.c).
5939         * f-exp.y (type_stack): New global.
5940         Update rules.
5941         (push_kind_type, f_parse): Update.
5942         * d-exp.y (type_stack): New global.
5943         Update rules.
5944         (d_parse): Update.
5945         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5946         Update rules.
5947         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5948         (HFILES_NO_SRCDIR): Add type-stack.h.
5949
5950 2019-04-04  Tom Tromey  <tom@tromey.com>
5951
5952         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5953         (rust_parser::convert_ast_to_expression, rust_parse)
5954         (rust_lex_test_completion, rust_lex_tests): Update.
5955         * parser-defs.h (struct expr_completion_state): New.
5956         (struct parser_state) <parser_state>: Add completion parameter.
5957         <mark_struct_expression, mark_completion_tag>: New methods.
5958         <parse_completion, m_completion_state>: New members.
5959         (prefixify_expression, null_post_parser): Update.
5960         (mark_struct_expression, mark_completion_tag): Don't declare.
5961         * parse.c (parse_completion, expout_last_struct)
5962         (expout_tag_completion_type, expout_completion_name): Remove
5963         globals.
5964         (parser_state::mark_struct_expression)
5965         (parser_state::mark_completion_tag): Now methods.
5966         (prefixify_expression): Add last_struct parameter.
5967         (prefixify_subexp): Likewise.
5968         (parse_exp_1): Update.
5969         (parse_exp_in_context): Add cstate parameter.  Update.
5970         (parse_expression_for_completion): Create an
5971         expr_completion_state.
5972         (null_post_parser): Add "completion" parameter.
5973         * p-exp.y: Update rules.
5974         (yylex): Update.
5975         * language.h (struct language_defn) <la_post_parser>: Add
5976         "completing" parameter.
5977         * go-exp.y: Update rules.
5978         (lex_one_token): Update.
5979         * expression.h (parse_completion): Don't declare.
5980         * d-exp.y: Update rules.
5981         (lex_one_token): Update rules.
5982         * c-exp.y: Update rules.
5983         (lex_one_token): Update.
5984         * ada-lang.c (resolve): Add "parse_completion" parameter.
5985         (resolve_subexp): Likewise.
5986         (ada_resolve_function): Likewise.
5987
5988 2019-04-04  Tom Tromey  <tom@tromey.com>
5989
5990         * parser-defs.h (struct parser_state) <start_arglist,
5991         end_arglist>: New methods.
5992         <arglist_len, m_funcall_chain>: New members.
5993         (arglist_len, start_arglist, end_arglist): Don't declare.
5994         * parse.c (arglist_len, funcall_chain): Remove global.
5995         (start_arglist, end_arglist): Remove functions.
5996         (parse_exp_in_context): Update.
5997         * p-exp.y: Update rules.
5998         * m2-exp.y: Update rules.
5999         * go-exp.y: Update rules.
6000         * f-exp.y: Update rules.
6001         * d-exp.y: Update rules.
6002         * c-exp.y: Update rules.
6003
6004 2019-04-04  Tom Tromey  <tom@tromey.com>
6005
6006         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6007         lex_operator, push_back>: New methods.
6008         Update all rules.
6009         (rust_parser::lex_hex, lex_escape): Rename and update.
6010         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6011         (rust_parser::lex_operator): Rename and update.
6012         (rust_parser::lex_number, rustyylex, rustyyerror)
6013         (rust_lex_test_init, rust_lex_test_sequence)
6014         (rust_lex_test_push_back, rust_lex_tests): Update.
6015         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6016         parameter.
6017         <lexptr, prev_lexptr>: New members.
6018         (lexptr, prev_lexptr): Don't declare.
6019         * parse.c (lexptr, prev_lexptr): Remove globals.
6020         (parse_exp_in_context): Update.
6021         * p-exp.y (yylex, yyerror): Update.
6022         * m2-exp.y (parse_number, yylex, yyerror): Update.
6023         * go-exp.y (lex_one_token, yyerror): Update.
6024         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6025         * d-exp.y (lex_one_token, yyerror): Update.
6026         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6027         (lex_one_token, yyerror): Update.
6028         * ada-lex.l (YY_INPUT): Update.
6029         (rewind_to_char): Update.
6030         * ada-exp.y (yyerror): Update.
6031
6032 2019-04-04  Tom Tromey  <tom@tromey.com>
6033
6034         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6035         * parser-defs.h (struct parser_state) <parser_state>: Add new
6036         parameter.
6037         <comma_terminates>: New member.
6038         (comma_terminates): Don't declare global.
6039         * parse.c (comma_terminates): Remove global.
6040         (parse_exp_in_context): Update.
6041         * p-exp.y (yylex): Update.
6042         * m2-exp.y (yylex): Update.
6043         * go-exp.y (lex_one_token): Update.
6044         * f-exp.y (yylex): Update.
6045         * d-exp.y (lex_one_token): Update.
6046         * c-exp.y (lex_one_token): Update.
6047         * ada-lex.l: Update.
6048
6049 2019-04-04  Tom Tromey  <tom@tromey.com>
6050
6051         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6052         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6053         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6054         * parser-defs.h (paren_depth): Don't declare.
6055         * parse.c (paren_depth): Remove global.
6056         (parse_exp_in_context): Update.
6057         * p-exp.y (paren_depth): New global.
6058         (pascal_parse): Initialize it.
6059         * m2-exp.y (paren_depth): New global.
6060         (m2_parse): Initialize it.
6061         * go-exp.y (paren_depth): New global.
6062         (go_parse): Initialize it.
6063         * f-exp.y (paren_depth): New global.
6064         (f_parse): Initialize it.
6065         * d-exp.y (paren_depth): New global.
6066         (d_parse): Initialize it.
6067         * c-exp.y (paren_depth): New global.
6068         (c_parse): Initialize it.
6069         * ada-lex.l (paren_depth): New global.
6070         (lexer_init): Initialize it.
6071
6072 2019-04-04  Tom Tromey  <tom@tromey.com>
6073
6074         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6075         (rust_parser::convert_ast_to_type)
6076         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6077         * parser-defs.h (struct parser_state) <parser_state>: Add
6078         parameters.  Initialize new members.
6079         <expression_context_block, expression_context_pc>: New members.
6080         * parse.c (expression_context_block, expression_context_pc):
6081         Remove globals.
6082         (parse_exp_in_context): Update.
6083         * p-exp.y: Update all rules.
6084         (yylex): Update.
6085         * m2-exp.y: Update all rules.
6086         (yylex): Update.
6087         * go-exp.y (yylex): Update.
6088         * f-exp.y (yylex): Update.
6089         * d-exp.y: Update all rules.
6090         (yylex): Update.
6091         * c-exp.y: Update all rules.
6092         (lex_one_token, classify_name, yylex, c_parse): Update.
6093         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6094
6095 2019-04-04  Tom Tromey  <tom@tromey.com>
6096
6097         * gdbarch.h, gdbarch.c: Rebuild.
6098         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6099         * stap-probe.h:
6100         (struct stap_parse_info): Replace "parser_state" with
6101         "expr_builder".
6102         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6103         (parser_state): New class.
6104         * parse.c (expr_builder): Rename.
6105         (expr_builder::release): Rename.
6106         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6107         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6108         (write_exp_elt_longcst, write_exp_elt_floatcst)
6109         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6110         (write_exp_string_vector, write_exp_bitstring)
6111         (write_exp_msymbol, mark_struct_expression)
6112         (write_dollar_variable)
6113         (insert_type_address_space, increase_expout_size): Replace
6114         "parser_state" with "expr_builder".
6115         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6116         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6117         "parser_state" with "expr_builder".
6118
6119 2019-04-04  Tom Tromey  <tom@tromey.com>
6120
6121         * rust-exp.y: Replace "parse_language" with method call.
6122         * p-exp.y:
6123         (yylex): Replace "parse_language" with method call.
6124         * m2-exp.y:
6125         (yylex): Replace "parse_language" with method call.
6126         * go-exp.y (classify_name): Replace "parse_language" with method
6127         call.
6128         * f-exp.y (yylex): Replace "parse_language" with method call.
6129         * d-exp.y (lex_one_token): Replace "parse_language" with method
6130         call.
6131         * c-exp.y:
6132         (lex_one_token, classify_name, yylex): Replace "parse_language"
6133         with method call.
6134         * ada-exp.y (find_primitive_type, type_char)
6135         (type_system_address): Replace "parse_language" with method call.
6136
6137 2019-04-04  Tom Tromey  <tom@tromey.com>
6138
6139         * rust-exp.y: Replace "parse_gdbarch" with method call.
6140         * parse.c (write_dollar_variable, insert_type_address_space):
6141         Replace "parse_gdbarch" with method call.
6142         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6143         call.
6144         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6145         call.
6146         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6147         "parse_gdbarch" with method call.
6148         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6149         with method call.
6150         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6151         "parse_gdbarch" with method call.
6152         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6153         "parse_gdbarch" with method call.
6154         * c-exp.y (parse_type, parse_number, classify_name): Replace
6155         "parse_gdbarch" with method call.
6156         * ada-lex.l: Replace "parse_gdbarch" with method call.
6157         * ada-exp.y (parse_type, find_primitive_type, type_char)
6158         (type_system_address): Replace "parse_gdbarch" with method call.
6159
6160 2019-04-04  Tom Tromey  <tom@tromey.com>
6161
6162         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6163         * stap-probe.c (stap_parse_argument): Update.
6164         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6165         initial_size parameter.
6166         * rust-exp.y (rust_lex_tests): Update.
6167         * parse.c (parser_state): Update.
6168         (parse_exp_in_context): Update.
6169         * parser-defs.h (struct parser_state) <parser_state>: Remove
6170         "initial_size" parameter.
6171
6172 2019-04-04  Tom Tromey  <tom@tromey.com>
6173
6174         * parser-defs.h (increase_expout_size): Don't declare.
6175         * parse.c (increase_expout_size): Now static.
6176
6177 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6178
6179         * gnu-nat.c (gnu_nat_target::wait): Fix
6180         target_waitstatus_to_string call.
6181
6182 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6183
6184         * eval.c (evaluate_subexp_standard): Handle internal functions
6185         during Fortran function call handling.
6186
6187 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6188
6189         * NEWS: Mention new internal functions.
6190         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6191         (read_base_type): Use dwarf2_init_complex_target_type.
6192         * value.c (creal_internal_fn): New function.
6193         (cimag_internal_fn): New function.
6194         (_initialize_values): Register new internal functions.
6195
6196 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6197
6198         * infrun.c (stop_all_threads): If debug_infrun, always
6199         trace the wait status after wait_one, using
6200         target_waitstatus_to_string and target_pid_to_str.
6201         (handle_inferior_event): Replace various trace of
6202         wait status kind by a single trace.
6203         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6204         wait status kind image by target_waitstatus_to_string.
6205         * target/waitstatus.c (target_waitstatus_to_string): Fix
6206         obsolete comment.
6207
6208 2019-04-01  Tom Tromey  <tromey@adacore.com>
6209
6210         PR symtab/23331:
6211         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6212
6213 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6214             Pedro Alves  <palves@redhat.com>
6215
6216         * top.c (quit_force): Call 'finalize_values'.
6217         * value.c (finalize_values): New function.
6218         * value.h (finalize_values): Declare.
6219
6220 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6221
6222         * NEWS: Announce $_gdb_major and $_gdb_minor.
6223
6224         * top.c (init_gdb_version_vars): New function.
6225         (gdb_init): Call init_gdb_version_vars.
6226
6227 2019-03-29  Tom Tromey  <tromey@adacore.com>
6228
6229         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6230         help text.  Remove dead code.
6231
6232 2019-03-29  Keith Seitz  <keiths@redhat.com>
6233
6234         From Siddhesh Poyarekar:
6235         * f-lang.h (f77_get_upperbound): Return LONGEST.
6236         (f77_get_lowerbound): Likewise.
6237         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6238         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6239         print them.
6240         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6241         plongest to format print it.
6242         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6243         (f77_get_upperbound): Likewise.
6244         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6245         LOWER_BOUND to LONGEST.
6246         (f77_create_arrayprint_offset_tbl): Likewise.
6247
6248 2019-03-29  Keith Seitz  <keiths@redhat.com>
6249
6250         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6251         %s/pulongest for TYPE_LENGTH instead of %d in format
6252         strings.
6253         * ada-typerint.c (ada_print_type): Likewise.
6254         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6255         * compile/compile-c-support.c (generate_register_struct): Likewise.
6256         * gdbtypes.c (recursive_dump_type): Likewise.
6257         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6258         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6259         instead of %d in format strings.
6260         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6261         to std::min to ULONGEST.
6262         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6263         instead of %d in format strings.
6264         * tracepoint.c (info_scope_command): Likewise.
6265         * typeprint.c (print_offset_data::update)
6266         (print_offset_data::finish): Likewise.
6267         * xtensa-tdep.c (xtensa_store_return_value)
6268         (xtensa_push_dummy_call): Likewise.
6269
6270 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6271
6272         * windows-nat.c (display_selector): Fixed format specifications
6273         for 64-bit Cygwin.
6274
6275 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6276
6277         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6278
6279 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6280
6281         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6282         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6283         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6284         (nios2_linux_init_abi): Install it.
6285
6286 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6287
6288         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6289
6290 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6291
6292         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6293
6294 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6295             Tom Tromey  <tromey@adacore.com>
6296
6297         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6298
6299 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6300
6301         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6302         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6303         method to compute the bounds of range types. Also print "[evaluated]"
6304         if the bounds' values come from a dynamic evaluation.
6305
6306 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6307
6308         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6309         whitespace when pretty printing is on.
6310
6311 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6312
6313         * ppc-linux-nat.c: Add include.
6314
6315 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6316
6317         * NEWS: Mention AArch64 Pointer Authentication.
6318
6319 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6320
6321         * arm-linux-nat.c: Add include.
6322
6323 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6324
6325         * source-cache.c (source_cache::get_source_lines): Re-read
6326         fullname after calling open_source_file.
6327
6328 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6329
6330         * NEWS: Mention TLS support for FreeBSD.
6331
6332 2019-03-25  Tom Tromey  <tromey@adacore.com>
6333
6334         * minsyms.c (BUNCH_SIZE): Update comment.
6335         (~minimal_symbol_reader): Remove old comment.
6336         (compact_minimal_symbols): Update comment.
6337         (minimal_symbol_reader::install): Remove old comment.  Update
6338         other comments.
6339
6340 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6341
6342         * s390-linux-nat.c: Add include.
6343
6344 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6345
6346         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6347         Call linux_get_hwcap.
6348         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6349         Likewise.
6350         (aarch64_linux_get_hwcap): Remove function.
6351         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6352         declaration.
6353         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6354         linux_get_hwcap.
6355         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6356         * linux-tdep.c (linux_get_hwcap): Add function.
6357         (linux_get_hwcap2): Likewise.
6358         * linux-tdep.h (linux_get_hwcap): Add declaration.
6359         (linux_get_hwcap2): Likewise.
6360         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6361         (ppc_linux_get_hwcap2): Likewise.
6362         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6363         linux_get_hwcap.
6364         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6365         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6366         (ppc_linux_nat_target::read_description): Likewise.
6367         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6368         * s390-linux-nat.c: Likewise.
6369         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6370
6371 2019-03-24  Tom Tromey  <tom@tromey.com>
6372
6373         * ada-lang.c (standard_lookup): Simplify initialization.
6374         (ada_lookup_symbol_nonlocal): Simplify return.
6375         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6376         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6377         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6378         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6379         initialization.
6380         * solib.c (solib_global_lookup): Simplify.
6381         * symtab.c (null_block_symbol): Remove.
6382         (symbol_cache_lookup): Simplify returns.
6383         (lookup_language_this): Simplify returns.
6384         (lookup_symbol_aux): Simplify return.
6385         (lookup_local_symbol): Simplify returns.
6386         (lookup_global_symbol_from_objfile): Simplify return.
6387         (lookup_symbol_in_objfile_symtabs)
6388         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6389         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6390         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6391         * cp-namespace.c (cp_lookup_bare_symbol)
6392         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6393         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6394         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6395         (cp_lookup_symbol_via_imports): Simplify initialization.
6396         (find_symbol_in_baseclass): Likewise.
6397         * symtab.h (null_block_symbol): Remove.
6398         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6399         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6400         (d_lookup_symbol_module): Likewise.
6401         (find_symbol_in_baseclass): Simplify initialization.
6402
6403 2019-03-24  Tom Tromey  <tom@tromey.com>
6404
6405         * expression.h: Don't include symtab.h.
6406         (struct block): Forward declare.
6407
6408 2019-03-24  Tom Tromey  <tom@tromey.com>
6409
6410         * c-exp.y (typebase): Remove casts.
6411         * gdbtypes.c (lookup_unsigned_typename, )
6412         (lookup_signed_typename): Remove cast.
6413         * eval.c (parse_to_comma_and_eval): Remove cast.
6414         * parse.c (write_dollar_variable): Remove cast.
6415         * block.h (struct block) <superblock>: Now const.
6416         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6417         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6418         (map_block): Make "block" const.
6419         * symfile.h (struct quick_symbol_functions)
6420         <map_matching_symbols>: Constify block argument to "callback".
6421         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6422         const.
6423         (find_pc_sect_compunit_symtab): Make "b" const.
6424         (find_symbol_at_address): Likewise.
6425         (search_symbols): Likewise.
6426         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6427         (dw2_debug_names_lookup_symbol): Likewise.
6428         (dw2_map_matching_symbols): Update.
6429         * p-valprint.c (pascal_val_print): Remove "block".
6430         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6431         (aux_add_nonlocal_symbols): Make "block" const.
6432         (resolve_subexp): Remove cast.
6433         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6434         const.
6435         (iterate_over_file_blocks): Likewise.
6436         * f-exp.y (%union) <bval>: Remove.
6437         * coffread.c (patch_opaque_types): Make "b" const.
6438         * spu-tdep.c (spu_catch_start): Make "block" const.
6439         * c-valprint.c (print_unpacked_pointer): Remove "block".
6440         * symmisc.c (dump_symtab_1): Make "b" const.
6441         (block_depth): Make "block" const.
6442         * d-exp.y (%union) <bval>: Remove.
6443         * cp-support.h (cp_lookup_rtti_type): Update.
6444         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6445         * psymtab.c (psym_lookup_symbol): Make "block" const.
6446         (maintenance_check_psymtabs): Make "b" const.
6447         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6448         (enumerate_locals, enumerate_args): Update.
6449         * python/py-symtab.c (stpy_global_block): Make "block" const.
6450         (stpy_static_block): Likewise.
6451         * inline-frame.c (block_starting_point_at): Make "new_block"
6452         const.
6453         * block.c (find_block_in_blockvector): Make return type const.
6454         (blockvector_for_pc_sect): Make "b" const.
6455         (find_block_in_blockvector): Make "b" const.
6456
6457 2019-03-23  Tom Tromey  <tom@tromey.com>
6458
6459         * varobj.c (varobj_create): Update.
6460         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6461         * printcmd.c (display_command, do_one_display): Don't reset
6462         innermost_block.
6463         * parser-defs.h (enum innermost_block_tracker_type): Move to
6464         expression.h.
6465         (innermost_block): Update comment.
6466         * parse.c (parse_exp_1): Add tracker_types parameter.
6467         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6468         tracker_types parameter.  Reset innermost_block.
6469         (parse_exp_in_context): Remove.
6470         (parse_expression_for_completion): Update.
6471         * objfiles.c (~objfile): Don't reset expression_context_block or
6472         innermost_block.
6473         * expression.h (enum innermost_block_tracker_type): Move from
6474         parser-defs.h.
6475         (parse_exp_1): Add tracker_types parameter.
6476         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6477         reset innermost_block.
6478
6479 2019-03-23  Tom Tromey  <tom@tromey.com>
6480
6481         * objfiles.h: Include bcache.h.
6482
6483 2019-03-23  Tom Tromey  <tom@tromey.com>
6484
6485         * linespec.c (get_current_search_block): Use
6486         scoped_restore_current_language.
6487         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6488
6489 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6490             Jiong Wang  <jiong.wang@arm.com>
6491
6492         * aarch64-linux-tdep.c
6493         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6494         section.
6495         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6496
6497 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6498             Jiong Wang  <jiong.wang@arm.com>
6499
6500         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6501         instructions.
6502         (aarch64_analyze_prologue_test): Add PACIASP test.
6503         (aarch64_prologue_prev_register): Unmask PC value.
6504
6505 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6506             Jiong Wang  <jiong.wang@arm.com>
6507
6508         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6509         (aarch64_dwarf2_prev_register): Unmask PC value.
6510         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6511         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6512         DW_CFA_AARCH64_negate_ra_state.
6513         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6514
6515 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6516             Jiong Wang  <jiong.wang@arm.com>
6517
6518         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6519         registers.
6520         (aarch64_pseudo_register_name): Likewise.
6521         (aarch64_pseudo_register_type): Likewise.
6522         (aarch64_pseudo_register_reggroup_p): Likewise.
6523         (aarch64_gdbarch_init): Add pauth registers.
6524         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6525         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6526         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6527         (struct gdbarch_tdep): Add regnum for ra_state.
6528
6529 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6530             Jiong Wang  <jiong.wang@arm.com>
6531
6532         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6533
6534 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6535             Jiong Wang  <jiong.wang@arm.com>
6536
6537         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6538         function.
6539         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6540         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6541         (aarch64_gdbarch_init): Add puth registers.
6542         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6543         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6544         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6545
6546 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6547             Jiong Wang  <jiong.wang@arm.com>
6548
6549         * aarch64-linux-nat.c
6550         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6551         * aarch64-linux-tdep.c
6552         (aarch64_linux_core_read_description): Likewise.
6553         (aarch64_linux_get_hwcap): New function.
6554         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6555         (aarch64_linux_get_hwcap): New declaration.
6556
6557 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6558             Jiong Wang  <jiong.wang@arm.com>
6559
6560         * aarch64-linux-nat.c
6561         (aarch64_linux_nat_target::read_description): Add pauth param.
6562         * aarch64-linux-tdep.c
6563         (aarch64_linux_core_read_description): Likewise.
6564         * aarch64-tdep.c (struct target_desc): Add in pauth.
6565         (aarch64_read_description): Add pauth param.
6566         (aarch64_gdbarch_init): Likewise.
6567         * aarch64-tdep.h (aarch64_read_description): Likewise.
6568         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6569         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6570         * features/Makefile: Add new files.
6571         * features/aarch64-pauth.c: New file.
6572         * features/aarch64-pauth.xml: New file.
6573
6574 2019-03-20  Tom Tromey  <tromey@adacore.com>
6575
6576         * infrun.c (handle_inferior_event): Rename from
6577         handle_inferior_event_1.  Create a scoped_value_mark.
6578         (handle_inferior_event): Remove.
6579
6580 2019-03-19  Tom Tromey  <tromey@adacore.com>
6581
6582         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6583         * infrun.h (print_stop_event): Add "displays" parameter.
6584         * infrun.c (print_stop_event): Add "displays" parameter.
6585
6586 2019-03-19  Pedro Alves  <palves@redhat.com>
6587
6588         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6589         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6590         to -1.  Fix TABs vs spaces.
6591         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6592         * tui/tui-out.h (tui_ui_out) Add intro comments.
6593         <m_line, m_start_of_line>: In-class initialize, and add describing
6594         comment.
6595
6596 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6597
6598         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6599         variable names.
6600         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6601
6602 2019-03-18  Pedro Alves  <palves@redhat.com>
6603             Eli Zaretskii <eliz@gnu.org>
6604
6605         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6606         m_line and m_start_of_line.
6607
6608 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6609
6610         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6611         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6612         it returns a newline.  This fixes a regression in TU mode, whereby
6613         the next line is output on the same screen line as the user input.
6614
6615 2019-03-18  Tom Tromey  <tromey@adacore.com>
6616
6617         * minsyms.c (minimal_symbol_reader::install): Remove call to
6618         obstack_blank.
6619
6620 2019-03-18  Pedro Alves  <palves@redhat.com>
6621
6622         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6623         New globals.
6624         (apply_style): New, factored out from ...
6625         (apply_ansi_escape): ... this.  Handle reverse video mode.
6626         (tui_set_reverse_mode): New function.
6627         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6628         * tui/tui-winsource.c (tui_show_source_line): Use
6629         tui_set_reverse_mode instead of setting A_STANDOUT.
6630         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6631         New setter methods.
6632
6633 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6634
6635         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6636         Handle tabs.
6637
6638 2019-03-18  Tom Tromey  <tromey@adacore.com>
6639
6640         * ada-lang.c (empty_array): Add "high" parameter.
6641         (ada_evaluate_subexp): Update.
6642
6643 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6644
6645         * unittests/string_view-selftests.c: Define
6646         _initialize_string_view_selftests unconditionally.
6647
6648 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6649
6650         PR gdb/24350
6651         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6652
6653 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6654
6655         PR gdb/24351
6656         * windows-nat.c (display_selector): Fix format specifiers.
6657
6658 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6659
6660         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6661         tui_refill_source_window instead of tui_refresh_win, to update the
6662         current execution line.  This fixes redisplay of the current line
6663         when stepping through the code with "next" or "step".
6664
6665 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6666
6667         * source-cache.c (source_cache::get_source_lines): Call
6668         find_source_lines to initialize s->nlines.  This fixes vertical
6669         scrolling of TUI source window when the DOWN arrow is pressed.
6670
6671 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6672
6673         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6674         linux-thread-db.c (_initialize_thread_db): Likewise.
6675
6676 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6677
6678         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6679         wclrtoeol in tui_show_source_line".  This reverts changes made in
6680         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6681
6682 2019-03-15  Tom Tromey  <tom@tromey.com>
6683
6684         * symtab.h (struct minimal_symbol): Derive from
6685         general_symbol_info.
6686         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6687         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6688         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6689         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6690         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6691         (MSYMBOL_SEARCH_NAME): Update.
6692         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6693         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6694         * minsyms.c (minimal_symbol_reader::record_full): Update.
6695
6696 2019-03-15  Tom Tromey  <tom@tromey.com>
6697
6698         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6699
6700 2019-03-15  Tom Tromey  <tom@tromey.com>
6701
6702         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6703         unique_xmalloc_ptr.
6704         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6705         Update.
6706         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6707         (build_minimal_symbol_hash_tables)
6708         (minimal_symbol_reader::install): Update.
6709
6710 2019-03-15  Tom Tromey  <tom@tromey.com>
6711
6712         * symtab.c (create_demangled_names_hash): Update.
6713         (symbol_set_names): Update.
6714         * objfiles.h (struct objfile_per_bfd_storage)
6715         <demangled_names_hash>: Now an htab_up.
6716         * objfiles.c (objfile_per_bfd_storage): Simplify.
6717
6718 2019-03-15  Tom Tromey  <tom@tromey.com>
6719
6720         * objfiles.h (struct objfile_per_bfd_storage): Declare
6721         destructor.
6722         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6723         New.
6724         (get_objfile_bfd_data): Use new.  Don't initialize
6725         language_of_main.
6726         (free_objfile_per_bfd_storage): Remove.
6727         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6728
6729 2019-03-15  Tom Tromey  <tom@tromey.com>
6730
6731         * symfile.c (reread_symbols): Update.
6732         * objfiles.c (objfile::objfile): Update.
6733         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6734         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6735         comment.
6736         (minimal_symbol_reader::install): Update.
6737         (terminate_minimal_symbol_table): Remove.
6738         * jit.c (jit_object_close_impl): Update.
6739
6740 2019-03-15  Tom Tromey  <tom@tromey.com>
6741
6742         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6743         initializations.
6744
6745 2019-03-15  Tom Tromey  <tom@tromey.com>
6746
6747         * objfiles.h (struct objfile_per_bfd_storage)
6748         <demangled_hash_languages>: Now a bitset.
6749         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6750         (lookup_minimal_symbol): Update.
6751
6752 2019-03-15  Tom Tromey  <tom@tromey.com>
6753
6754         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6755         Don't return the symbol.
6756         * coffread.c (record_minimal_symbol): Use record_full.
6757
6758 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6759
6760         The MS-Windows port of ncurses fails to switch to a color pair if
6761         one or both of the colors are the implicit default colors.  This
6762         change records the default colors when TUI is initialized, and
6763         then specifies them explicitly when a color pair uses the default
6764         colors.  This allows color styling in TUI mode on MS-Windows.
6765
6766         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6767         ncurses_norm_attr.
6768         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6769         colors in ncurses_norm_attr.
6770         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6771         "none", replace it with the default color recorded in
6772         ncurses_norm_attr.
6773
6774 2019-03-14  Tom Tromey  <tromey@adacore.com>
6775
6776         * source-cache.h (class source_cache) <get_source_lines>: Return
6777         std::string.
6778         * source-cache.c (source_cache::extract_lines): Handle case where
6779         first_pos==npos.  Return std::string.
6780         (source_cache::get_source_lines): Update.
6781
6782 2019-03-14  Tom Tromey  <tromey@adacore.com>
6783
6784         * NEWS: Add item for "style sources" commands.
6785         * source-cache.c (source_cache::get_source_lines): Check
6786         source_styling.
6787         * cli/cli-style.c (source_styling): New global.
6788         (_initialize_cli_style): Add "style sources" commands.
6789         (show_style_sources): New function.
6790         * cli/cli-style.h (source_styling): Declare.
6791
6792 2019-03-14  Pedro Alves  <palves@redhat.com>
6793             Tom Tromey  <tromey@adacore.com>
6794
6795         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6796         * tui/tui-winsource.c (tui_refill_source_window): New function,
6797         from...
6798         (tui_horizontal_source_scroll): ... here.  Move some logic.
6799         * cli/cli-style.c (set_style_enabled): Notify new observable.
6800         * tui/tui-hooks.c (tui_redisplay_source): New function.
6801         (tui_attach_detach_observers): Attach or detach
6802         tui_redisplay_source.
6803         * observable.h (source_styling_changed): New observable.
6804         * observable.c: Define source_styling_changed observable.
6805
6806 2019-03-13  Tom Tromey  <tromey@adacore.com>
6807
6808         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6809         (i386_gnu_nat_target::store_registers): Update.
6810         * target-debug.h (target_debug_print_std_string): New macro.
6811         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6812         * windows-tdep.c (display_one_tib): Update.
6813         * tui/tui-stack.c (tui_make_status_line): Update.
6814         * top.c (print_inferior_quit_action): Update.
6815         * thread.c (thr_try_catch_cmd): Update.
6816         (add_thread_with_info): Update.
6817         (thread_target_id_str): Update.
6818         (thr_try_catch_cmd): Update.
6819         (thread_command): Update.
6820         (thread_find_command): Update.
6821         * record-btrace.c (record_btrace_target::info_record)
6822         (record_btrace_resume_thread, record_btrace_target::resume)
6823         (record_btrace_cancel_resume, record_btrace_step_thread)
6824         (record_btrace_target::wait, record_btrace_target::wait)
6825         (record_btrace_target::wait, record_btrace_target::stop): Update.
6826         * progspace.c (print_program_space): Update.
6827         * process-stratum-target.c
6828         (process_stratum_target::thread_address_space): Update.
6829         * linux-fork.c (linux_fork_mourn_inferior)
6830         (detach_checkpoint_command, info_checkpoints_command)
6831         (linux_fork_context): Update.
6832         (linux_fork_detach): Update.
6833         (class scoped_switch_fork_info): Update.
6834         (delete_checkpoint_command): Update.
6835         * infrun.c (follow_fork_inferior): Update.
6836         (follow_fork_inferior): Update.
6837         (proceed_after_vfork_done): Update.
6838         (handle_vfork_child_exec_or_exit): Update.
6839         (follow_exec): Update.
6840         (displaced_step_prepare_throw): Update.
6841         (displaced_step_restore): Update.
6842         (start_step_over): Update.
6843         (resume_1): Update.
6844         (clear_proceed_status_thread): Update.
6845         (proceed): Update.
6846         (print_target_wait_results): Update.
6847         (do_target_wait): Update.
6848         (context_switch): Update.
6849         (stop_all_threads): Update.
6850         (restart_threads): Update.
6851         (finish_step_over): Update.
6852         (handle_signal_stop): Update.
6853         (switch_back_to_stepped_thread): Update.
6854         (keep_going_pass_signal): Update.
6855         (print_exited_reason): Update.
6856         (normal_stop): Update.
6857         * inferior.c (inferior_pid_to_str): Change return type.
6858         (print_selected_inferior): Update.
6859         (add_inferior): Update.
6860         (detach_inferior): Update.
6861         * dummy-frame.c (fprint_dummy_frames): Update.
6862         * dcache.c (dcache_info_1): Update.
6863         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6864         (btrace_fetch, btrace_clear): Update.
6865         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6866         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6867         type.
6868         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6869         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6870         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6871         * gdbarch.c, gdbarch.h: Rebuild.
6872         * gdbarch.sh (core_pid_to_str): Change return type.
6873         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6874         return type.
6875         (windows_nat_target::pid_to_str): Change return type.
6876         (windows_delete_thread): Update.
6877         (windows_nat_target::attach): Update.
6878         (windows_nat_target::files_info): Update.
6879         * target-delegates.c: Rebuild.
6880         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6881         return type.
6882         (sol_thread_target::pid_to_str): Change return type.
6883         * remote.c (class remote_target) <pid_to_str>: Change return
6884         type.
6885         (remote_target::pid_to_str): Change return type.
6886         (extended_remote_target::attach, remote_target::remote_stop_ns)
6887         (remote_target::remote_notif_remove_queued_reply)
6888         (remote_target::push_stop_reply, remote_target::disable_btrace):
6889         Update.
6890         (extended_remote_target::attach): Update.
6891         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6892         type.
6893         (gdbsim_target::pid_to_str): Change return type.
6894         * ravenscar-thread.c (struct ravenscar_thread_target)
6895         <pid_to_str>: Change return type.
6896         (ravenscar_thread_target::pid_to_str): Change return type.
6897         * procfs.c (class procfs_target) <pid_to_str>: Change return
6898         type.
6899         (procfs_target::pid_to_str): Change return type.
6900         (procfs_target::attach): Update.
6901         (procfs_target::detach): Update.
6902         (procfs_target::fetch_registers): Update.
6903         (procfs_target::store_registers): Update.
6904         (procfs_target::wait): Update.
6905         (procfs_target::files_info): Update.
6906         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6907         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6908         return type.
6909         (nto_procfs_target::pid_to_str): Change return type.
6910         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6911         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6912         return type.
6913         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6914         (exit_lwp): Update.
6915         (attach_proc_task_lwp_callback, get_detach_signal)
6916         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6917         (linux_nat_target::resume, wait_lwp, stop_callback)
6918         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6919         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6920         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6921         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6922         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6923         type.
6924         (inf_ptrace_target::attach): Update.
6925         (inf_ptrace_target::files_info): Update.
6926         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6927         type.
6928         (go32_nat_target::pid_to_str): Change return type.
6929         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6930         (gnu_nat_target::wait): Update.
6931         (gnu_nat_target::wait): Update.
6932         (gnu_nat_target::resume): Update.
6933         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6934         (fbsd_nat_target::wait): Update.
6935         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6936         type.
6937         (darwin_nat_target::attach): Update.
6938         * corelow.c (class core_target) <pid_to_str>: Change return type.
6939         (core_target::pid_to_str): Change return type.
6940         * target.c (normal_pid_to_str): Change return type.
6941         (default_pid_to_str): Likewise.
6942         (target_pid_to_str): Change return type.
6943         (target_translate_tls_address): Update.
6944         (target_announce_detach): Update.
6945         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6946         return type.
6947         (bsd_uthread_target::pid_to_str): Change return type.
6948         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6949         type.
6950         (bsd_kvm_target::pid_to_str): Change return type.
6951         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6952         return type.
6953         (aix_thread_target::pid_to_str): Change return type.
6954         * target.h (struct target_ops) <pid_to_str>: Change return type.
6955         (target_pid_to_str, normal_pid_to_str): Likewise.
6956         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6957         type.
6958         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6959         type.
6960         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6961         return type.
6962         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6963         type.
6964         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6965         type.
6966         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6967         return type.
6968
6969 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6970
6971         * NEWS: Mention that the new default MI version is 3.  Mention
6972         changes to the output of commands and events that deal with
6973         multi-location breakpoints.
6974         * breakpoint.c: Include "mi/mi-out.h".
6975         (print_one_breakpoint): Change output syntax if using MI version
6976         >= 3.
6977         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6978         New.
6979         (mi_multi_location_breakpoint_output_fixed): New.
6980         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6981         (mi_cmd_fix_multi_location_breakpoint_output): New.
6982         (mi_multi_location_breakpoint_output_fixed): New.
6983         * mi/mi-cmds.c (mi_cmds): Register command
6984         -fix-multi-location-breakpoint-output.
6985         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6986         interpreter "mi".
6987
6988 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6989
6990         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6991         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6992         instantiate mi_ui_out based on interpreter name.
6993         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6994         * mi/mi-main.c (mi_load_progress): Likewise.
6995
6996 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6997
6998         * NEWS: Combine separate "New targets" sections for 8.3.
6999
7000 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7001
7002         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7003         (ppcfbsd_init_abi): Install gdbarch
7004         "fetch_tls_load_module_address" and "get_thread_local_address"
7005         methods.
7006
7007 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7008
7009         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7010         (riscv_fbsd_init_abi): Install gdbarch
7011         "fetch_tls_load_module_address" and "get_thread_local_address"
7012         methods.
7013
7014 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7015
7016         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7017         (i386fbsd_init_abi): Install gdbarch
7018         "fetch_tls_load_module_address" and "get_thread_local_address"
7019         methods.
7020
7021 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7022
7023         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7024         (amd64fbsd_init_abi): Install gdbarch
7025         "fetch_tls_load_module_address" and "get_thread_local_address"
7026         methods.
7027
7028 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7029
7030         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7031         (struct fbsd_pspace_data): New type.
7032         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7033         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7034         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7035         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7036         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7037
7038 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7039
7040         * gdbtypes.c (lookup_struct_elt): New function.
7041         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7042         * gdbtypes.h (struct struct_elt): New type.
7043         (lookup_struct_elt): New prototype.
7044
7045 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7046
7047         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7048         remove disabled code block.
7049
7050 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7051
7052         * gdbarch.sh (get_thread_local_address): New method.
7053         * gdbarch.h, gdbarch.c: Regenerate.
7054         * target.c (target_translate_tls_address): Use
7055         gdbarch_get_thread_local_address if present instead of
7056         target::get_thread_local_address.
7057
7058 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7059
7060         * target.h (target::get_thread_local_address): Update comment.
7061
7062 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7063
7064         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7065         objfile->separate_debug_objfile_backlink if not NULL.
7066
7067 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7068
7069         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7070         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7071         (amd64bsd_store_inferior_registers): Likewise.
7072         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7073         Enable segment base registers.
7074         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7075         PT_GETFSBASE and PT_GETGSBASE.
7076         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7077         PT_SETGSBASE.
7078         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7079         segment base registers.
7080         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7081
7082 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7083
7084         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7085         Update calls to i386_target_description to add 'segments'
7086         parameter.
7087         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7088         add segment base registers.
7089         * arch/i386.c (i386_create_target_description): Add 'segments'
7090         parameter to enable segment base registers.
7091         * arch/i386.h (i386_create_target_description): Likewise.
7092         * features/i386/32bit-segments.xml: New file.
7093         * features/i386/32bit-segments.c: Generate.
7094         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7095         call to i386_target_description to add 'segments' parameter.
7096         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7097         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7098         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7099         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7100         if feature is present.
7101         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7102         Add 'segments' parameter to call to i386_target_description.
7103         (i386_target_description): Add 'segments' parameter to enable
7104         segment base registers.
7105         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7106         to call to i386_target_description.
7107         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7108         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7109         Define I386_NUM_REGS.
7110         (i386_target_description): Add 'segments' parameter to enable
7111         segment base registers.
7112
7113 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7114
7115         PR/24325
7116         * source-cache.c: #undef open and close, to avoid unresolved
7117         externals during linking.
7118
7119 2019-03-12  Tom Tromey  <tromey@adacore.com>
7120
7121         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7122         const.  Add initializers.
7123         (_initialize_remote): Don't initialize ptid globals.
7124
7125 2019-03-12  Pedro Alves  <palves@redhat.com>
7126
7127         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7128
7129 2019-03-12  Pedro Alves  <palves@redhat.com>
7130
7131         * cp-name-parser.y (main): Remove unused 'len' variable.
7132
7133 2019-03-12  Tom Tromey  <tromey@adacore.com>
7134
7135         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7136         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7137
7138 2019-03-12  Tom Tromey  <tromey@adacore.com>
7139
7140         * linux-nat.c (iterate_over_lwps): Update.
7141         (stop_callback): Remove parameter.
7142         (stop_wait_callback, detach_callback, resume_set_callback)
7143         (select_singlestep_lwp_callback, set_ignore_sigint)
7144         (status_callback, resumed_callback, resume_clear_callback)
7145         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7146         data parameter.
7147         (linux_nat_target::detach, linux_nat_target::resume)
7148         (linux_stop_and_wait_all_lwps, select_event_lwp)
7149         (linux_nat_filter_event, linux_nat_wait_1)
7150         (linux_nat_target::kill, linux_nat_target::stop)
7151         (linux_nat_target::stop): Update.
7152         (linux_nat_resume_callback): Change type.
7153         (resume_stopped_resumed_lwps, count_events_callback)
7154         (select_event_lwp_callback): Likewise.
7155         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7156         * arm-linux-nat.c (struct update_registers_data): Remove.
7157         (update_registers_callback): Change type.
7158         (arm_linux_insert_hw_breakpoint1): Update.
7159         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7160         parameter.
7161         (x86_linux_dr_set_addr): Update.
7162         (x86_linux_dr_set_control): Update.
7163         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7164         (iterate_over_lwps): Use gdb::function_view.
7165         * nat/aarch64-linux-hw-point.c (struct
7166         aarch64_dr_update_callback_param): Remove.
7167         (debug_reg_change_callback): Change type.
7168         (aarch64_notify_debug_reg_change): Update.
7169         * s390-linux-nat.c (s390_refresh_per_info): Update.
7170
7171 2019-03-11  Tom Tromey  <tromey@adacore.com>
7172
7173         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7174         redundant assignment to "this_cu".
7175
7176 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7177
7178         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7179
7180 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7181
7182         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7183         from...
7184         (rank_one_type): ... this.
7185
7186 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7187
7188         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7189         from...
7190         (rank_one_type): ... this.
7191
7192 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7193
7194         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7195         from...
7196         (rank_one_type): ... this.
7197
7198 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7199
7200         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7201         from...
7202         (rank_one_type): ... this.
7203
7204 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7205
7206         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7207         from...
7208         (rank_one_type): ... this.
7209
7210 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7211
7212         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7213         from...
7214         (rank_one_type): ... this.
7215
7216 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7217
7218         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7219         from...
7220         (rank_one_type): ... this.
7221
7222 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7223
7224         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7225         from...
7226         (rank_one_type): ... this.
7227
7228 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7229
7230         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7231         from...
7232         (rank_one_type): ... this.
7233
7234 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7235
7236         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7237         from...
7238         (rank_one_type): ... this.
7239
7240 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7241
7242         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7243         from...
7244         (rank_one_type): ... this.
7245
7246 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7247
7248         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7249         from...
7250         (rank_one_type): ... this.
7251
7252 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7253
7254         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7255         inferior-events' shows the example events.
7256
7257 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7258
7259         Support styling on native MS-Windows console
7260
7261         PR/24315
7262         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7263         on MS-Windows if $TERM is not defined.
7264
7265         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7266
7267         * posix-hdep.c (gdb_console_fputs):
7268         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7269         functions.
7270         * ui-file.h (gdb_console_fputs): Add prototype.
7271
7272         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7273         back to fputs only if the former returns zero.
7274
7275 2019-03-07  Tom Tromey  <tom@tromey.com>
7276
7277         * symmisc.c (print_symbol_bcache_statistics): Update.
7278         (print_objfile_statistics): Update.
7279         * symfile.c (allocate_symtab): Update.
7280         * stabsread.c: Don't include bcache.h.
7281         * psymtab.h (struct psymbol_bcache): Don't declare.
7282         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7283         (psymbol_bcache_init, psymbol_bcache_free)
7284         (psymbol_bcache_get_bcache): Don't declare.
7285         * psymtab.c (struct psymbol_bcache): Remove.
7286         (psymtab_storage::psymtab_storage): Update.
7287         (psymtab_storage::~psymtab_storage): Update.
7288         (psymbol_bcache_init, psymbol_bcache_free)
7289         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7290         (add_psymbol_to_bcache): Update.
7291         (allocate_psymtab): Update.
7292         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7293         macro_cache>: No longer pointers.
7294         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7295         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7296         * macrotab.c (macro_bcache): Update.
7297         * macroexp.c: Don't include bcache.h.
7298         * gdbtypes.c (check_types_worklist): Update.
7299         (types_deeply_equal): Remove TRY/CATCH.  Update.
7300         * elfread.c (elf_symtab_read): Update.
7301         * dwarf2read.c: Don't include bcache.h.
7302         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7303         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7304         (print_bcache_statistics, bcache_memory_used): Don't declare.
7305         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7306         methods.  Rename all data members.
7307         * bcache.c (struct bcache): Move to bcache.h.
7308         (bcache::expand_hash_table): Rename from expand_hash_table.
7309         (bcache): Remove.
7310         (bcache::insert): Rename from bcache_full.
7311         (bcache::compare): Rename from bcache_compare.
7312         (bcache_xmalloc): Remove.
7313         (bcache::~bcache): Rename from bcache_xfree.
7314         (bcache::print_statistics): Rename from print_bcache_statistics.
7315         (bcache::memory_used): Rename from bcache_memory_used.
7316
7317 2019-03-07  Pedro Alves  <palves@redhat.com>
7318
7319         * infrun.c (normal_stop): Also check for
7320         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7321
7322 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7323
7324         * f-lang.c (value_from_host_double): Moved to...
7325         * value.c (value_from_host_double): ...here.
7326         * value.h (value_from_host_double): Declare.
7327         * guile/scm-math.c (vlscm_convert_typed_number): Use
7328         value_from_host_double.
7329         (vlscm_convert_number): Likewise.
7330         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7331         * python/py-value.c (convert_value_from_python): Likewise.
7332
7333 2019-03-06  Tom Tromey  <tom@tromey.com>
7334
7335         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7336
7337 2019-03-06  Tom Tromey  <tom@tromey.com>
7338
7339         * utils.h (free_current_contents): Don't declare.
7340         * utils.c (free_current_contents): Remove.
7341
7342 2019-03-06  Tom Tromey  <tom@tromey.com>
7343
7344         * top.c (quit_force): Update.
7345         * main.c (captured_command_loop): Update.
7346         * common/new-op.c (operator new): Update.
7347         * common/common-exceptions.c (struct catcher)
7348         <save_cleanup_chain>: Remove member.
7349         (exceptions_state_mc_init): Update.
7350         (exception_try_scope_entry): Return nullptr.
7351         (exception_try_scope_exit, exception_rethrow)
7352         (throw_exception_sjlj, throw_exception_cxx): Update.
7353         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7354         (all_cleanups, do_cleanups, discard_cleanups)
7355         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7356         (restore_cleanups, restore_final_cleanups): Don't declare.
7357         (do_final_cleanups): Remove parameter.
7358         * common/cleanups.c (cleanup_chain, make_cleanup)
7359         (make_cleanup_dtor, all_cleanups, do_cleanups)
7360         (discard_my_cleanups, discard_cleanups)
7361         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7362         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7363         (null_cleanup): Remove.
7364         (do_final_cleanups): Remove parameter.
7365
7366 2019-03-06  Tom Tromey  <tom@tromey.com>
7367
7368         * remote.c (remote_target::remote_parse_stop_reply): Use
7369         unique_xmalloc_ptr.
7370
7371 2019-03-06  Tom Tromey  <tom@tromey.com>
7372
7373         * stabsread.c (struct stabs_field_info): Rename from field_info.
7374         <list, fnlist>: Add initializers.
7375         <obstack>: New member.
7376         (read_member_functions, read_struct_fields, read_baseclasses):
7377         Allocate on obstack.  Don't use cleanups.
7378         (read_one_struct_field, read_member_functions, read_struct_fields)
7379         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7380         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7381         (read_struct_type): Update.
7382
7383 2019-03-06  Tom Tromey  <tom@tromey.com>
7384
7385         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7386         * common/filestuff.h (make_cleanup_close): Don't declare.
7387         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7388         Remove.
7389
7390 2019-03-06  Tom Tromey  <tom@tromey.com>
7391
7392         * solib-aix.c: Use make_scope_exit.
7393
7394 2019-03-06  Tom Tromey  <tom@tromey.com>
7395
7396         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7397         Use make_scope_exit.
7398
7399 2019-03-06  Tom Tromey  <tom@tromey.com>
7400
7401         * solib-svr4.c (disable_probes_interface): Remove parameter.
7402         (svr4_handle_solib_event): Use make_scope_exit.
7403
7404 2019-03-06  Tom Tromey  <tom@tromey.com>
7405
7406         * remote.c (struct stop_reply_deleter): Remove.
7407         (stop_reply_up): Update.
7408         (struct stop_reply): Derive from notif_event.  Don't typedef.
7409         <regcache>: Now a std::vector.
7410         (stop_reply_xfree): Remove.
7411         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7412         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7413         (remote_target::discard_pending_stop_replies): Use delete.
7414         (remote_target::remote_parse_stop_reply): Update.
7415         (remote_target::process_stop_reply): Update.
7416         * remote-notif.h (struct notif_event): Add virtual destructor.
7417         Remove "dtr" member.
7418         (struct notif_client) <alloc_event>: Return a unique_ptr.
7419         (notif_event_xfree): Don't declare.
7420         (notif_event_up): New typedef.
7421         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7422         (notif_event_xfree, do_notif_event_xfree): Remove.
7423         (remote_notif_state_xfree): Update.
7424
7425 2019-03-06  Tom Tromey  <tom@tromey.com>
7426
7427         * infrun.c (displaced_step_clear_cleanup): Now a
7428         forward_scope_exit type.
7429         (displaced_step_prepare_throw): Update.
7430         (displaced_step_fixup): Update.
7431
7432 2019-03-06  Tom Tromey  <tom@tromey.com>
7433
7434         * inferior.h (class inferior): Update comment.
7435         * gdbthread.h (class thread_info): Update comment.
7436
7437 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7438             Tom Tromey  <tom@tromey.com>
7439
7440         * stabsread.h (struct stab_section_list): Remove.
7441         (coffstab_build_psymtabs): Update.
7442         * dbxread.c (symbuf_sections): Now a std::vector.
7443         (sect_idx): New global.
7444         (fill_symbuf): Update.
7445         (coffstab_build_psymtabs): Change type of stabsects parameter.
7446         Update.
7447         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7448         std::vector.
7449         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7450         (coff_locate_sections): Update.
7451         (coff_symfile_read): Remove cleanups.  Update.
7452         (init_stringtab): Add storage parameter.
7453         (free_stringtab, free_stringtab_cleanup): Remove.
7454         (init_lineno): Add storage parameter.
7455         (free_linetab, free_linetab_cleanup): Remove.
7456
7457 2019-03-06  Pedro Alves  <palves@redhat.com>
7458
7459         * linux-fork.c (fork_info::clobber_regs): Delete.
7460         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7461         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7462         comment.  Adjust.
7463         (scoped_switch_fork_info::scoped_switch_fork_info)
7464         (checkpoint_command, linux_fork_context): Adjust
7465         fork_save_infrun_state calls.
7466
7467 2019-03-06  Pedro Alves  <palves@redhat.com>
7468
7469         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7470         (inf_has_multiple_threads): Return 'bool' and rewrite using
7471         inferior_info::threads().
7472
7473 2019-03-06  Pedro Alves  <palves@redhat.com>
7474
7475         * linux-fork.c: Include <list>.
7476         (fork_list): Now a std::list instance.
7477         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7478         (forks_exist_p, find_last_fork): Adjust.
7479         (new_fork): Delete.
7480         (one_fork_p): New.
7481         (add_fork): Adjust.
7482         (free_fork): Delete, folded into fork_info::~fork_info().
7483         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7484         Adjust.
7485         (init_fork_list): Delete.
7486         (linux_fork_killall, linux_fork_mourn_inferior)
7487         (linux_fork_detach, info_checkpoints_command): Adjust.
7488         (_initialize_linux_fork): No longer call init_fork_list.
7489
7490 2019-03-06  Pedro Alves  <palves@redhat.com>
7491
7492         * linux-fork.c (new_fork): New, split out of ...
7493         (add_fork): ... this.  Return void.  Move "first fork" special
7494         case from here, to ...
7495         (checkpoint_command): ... here.
7496         * linux-linux.h (add_fork): Return void.
7497
7498 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7499
7500         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7501
7502 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7503             Chris January  <chris.january@arm.com>
7504             David Lecomber  <david.lecomber@arm.com>
7505
7506         * f-exp.y: New token, UNOP_INTRINSIC.
7507         (exp): New pattern using UNOP_INTRINSIC token.
7508         (f77_keywords): Add 'abs' keyword.
7509         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7510         (value_from_host_double): New function.
7511         (evaluate_subexp_f): Support UNOP_ABS.
7512
7513 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7514
7515         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7516         types.
7517
7518 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7519
7520         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7521         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7522         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7523
7524 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7525
7526         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7527
7528 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7529             Chris January  <chris.january@arm.com>
7530
7531         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7532         * f-exp.y: Define 'KIND' token.
7533         (exp): New pattern for KIND expressions.
7534         (ptype): Handle types with a kind extension.
7535         (direct_abs_decl): Extend to spot kind extensions.
7536         (f77_keywords): Add 'kind' to the list.
7537         (push_kind_type): New function.
7538         (convert_to_kind_type): New function.
7539         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7540         * parse.c (operator_length_standard): Likewise.
7541         * parser-defs.h (enum type_pieces): Add tp_kind.
7542         * std-operator.def: Add UNOP_KIND.
7543
7544 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7545
7546         * f-exp.y (f_parse): Set yydebug.
7547
7548 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7549
7550         * f-lang.c (evaluate_subexp_f): New function.
7551         (exp_descriptor_f): New global.
7552         (f_language_defn): Use exp_descriptor_f instead of
7553         exp_descriptor_standard.
7554
7555 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7556
7557         * f-exp.y (struct token): Add comments.
7558         (dot_ops): Remove uppercase versions and the end marker.
7559         (f77_keywords): Likewise.
7560         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7561         entries in the dot_ops array are case insensitive, and use
7562         strncasecmp to compare strings.  Also some whitespace cleanup in
7563         this area.  Similar for the f77_keywords array, except entries in
7564         this list might be case sensitive.
7565
7566 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7567
7568         * f-exp.y (struct f77_boolean_val): Add comments.
7569         (boolean_values): Remove uppercase versions, and end marker.
7570         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7571         and use strncasecmp to achieve case insensitivity.  Additionally,
7572         perform whitespace cleanup around this code.
7573
7574 2019-03-06  Tom Tromey  <tromey@adacore.com>
7575
7576         * remote-sim.c (gdbsim_target_open): Use result of
7577         gdb_argv::release.
7578
7579 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7580         Dirk Schubert  <dirk.schubert@arm.com>
7581         Chris January  <chris.january@arm.com>
7582
7583         * eval.c (evaluate_subexp_standard): Call Fortran argument
7584         wrapping logic.
7585         * f-lang.c (struct value): A value which can be passed into a
7586         Fortran function call.
7587         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7588         where appropriate.
7589         (struct type): Value ready for a Fortran function call.
7590         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7591         is needed.
7592         * f-lang.h (fortran_argument_convert): Declaration.
7593         (fortran_preserve_arg_pointer): Declaration.
7594         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7595
7596 2019-03-05  Tom Tromey  <tromey@adacore.com>
7597
7598         * python/py-prettyprint.c (print_string_repr): Remove #if.
7599         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7600
7601 2019-03-05  Tom Tromey  <tromey@adacore.com>
7602
7603         * target.c (the_dummy_target): Move later.  Change type to
7604         "dummy_target".
7605         (initialize_targets): Don't initialize the_dummy_target.
7606
7607 2019-03-05  Tom Tromey  <tromey@adacore.com>
7608
7609         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7610         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7611
7612 2019-03-05  Tom Tromey  <tromey@adacore.com>
7613
7614         * windows-nat.c (windows_nat_target::attach)
7615         (windows_nat_target::detach): Don't call gdb_flush.
7616         * valprint.c (generic_val_print, val_print, val_print_string):
7617         Don't call gdb_flush.
7618         * utils.c (defaulted_query): Don't call gdb_flush.
7619         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7620         * target.c (target_announce_detach): Don't call gdb_flush.
7621         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7622         * remote.c (extended_remote_target::attach): Don't call
7623         gdb_flush.
7624         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7625         * printcmd.c (do_examine): Don't call gdb_flush.
7626         (info_display_command): Don't call gdb_flush.
7627         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7628         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7629         * memattr.c (info_mem_command): Don't call gdb_flush.
7630         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7631         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7632         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7633         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7634         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7635         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7636         (gnu_nat_target::detach): Don't call gdb_flush.
7637         * f-valprint.c (f_val_print): Don't call gdb_flush.
7638         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7639         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7640         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7641         gdb_flush.
7642         * c-valprint.c (c_val_print): Don't call gdb_flush.
7643         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7644
7645 2019-03-05  Tom Tromey  <tromey@adacore.com>
7646
7647         * varobj.c (update_dynamic_varobj_children): Update.
7648         (install_default_visualizer): Use reset, not release.
7649         * value.c (set_internalvar): Update.
7650         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7651         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7652         ATTRIBUTE_UNUSED_RESULT.
7653
7654 2019-03-05  Tom Tromey  <tromey@adacore.com>
7655
7656         * remote.c (class scoped_remote_fd) <release>: Add
7657         ATTRIBUTE_UNUSED_RESULT.
7658
7659 2019-03-05  Tom Tromey  <tromey@adacore.com>
7660
7661         * macroexp.c (struct macro_buffer) <release>: Add
7662         ATTRIBUTE_UNUSED_RESULT.
7663
7664 2019-03-05  Tom Tromey  <tromey@adacore.com>
7665
7666         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7667         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7668         ATTRIBUTE_UNUSED_RESULT.
7669
7670 2019-03-05  Tom Tromey  <tromey@adacore.com>
7671
7672         * common/scoped_fd.h (class scoped_fd) <release>: Add
7673         ATTRIBUTE_UNUSED_RESULT.
7674
7675 2019-03-05  Tom Tromey  <tromey@adacore.com>
7676
7677         * parser-defs.h (struct parser_state) <release>: Add
7678         ATTRIBUTE_UNUSED_RESULT.
7679
7680 2019-03-05  Tom Tromey  <tromey@adacore.com>
7681
7682         * utils.h (class gdb_argv) <release>: Add
7683         ATTRIBUTE_UNUSED_RESULT.
7684         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7685
7686 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7687
7688         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7689         for-loop range, to avoid compiler warnings.
7690
7691         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7692         avoid compiler warnings about unused variables.
7693
7694         * NEWS: Mention end of support for native debugging on MS-Windows
7695         before XP.
7696
7697         PR gdb/24292
7698         * common/netstuff.c:
7699         * gdbserver/gdbreplay.c
7700         * gdbserver/remote-utils.c:
7701         * ser-tcp.c:
7702         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7703         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7704         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7705         'getaddrinfo' and 'freeaddrinfo' were not available before
7706         Windows XP, and mingw.org's MinGW headers by default define
7707         _WIN32_WINNT to 0x500.
7708
7709 2019-03-01  Gary Benson <gbenson@redhat.com>
7710
7711         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7712
7713 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7714             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7715
7716         PR gdb/8527
7717         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7718         set_sigint_trap, clear_sigint_trap.
7719
7720 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7721
7722         * target.c (target_detach): Clear the regcache and the
7723         frame cache.
7724
7725 2019-02-27  Pedro Alves  <palves@redhat.com>
7726
7727         * utils.c (set_screen_size): When we cap the height/width sizes,
7728         tweak the corresponding command variable to show "unlimited":
7729
7730 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7731             Pedro Alves  <palves@redhat.com>
7732
7733         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7734         before calling rl_set_screen_size.
7735
7736 2019-02-27  Tom Tromey  <tromey@adacore.com>
7737
7738         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7739         define.
7740         * python/py-value.c: Remove Python 2.4 workaround.
7741         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7742         workaround.
7743         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7744         Python 2.4 workaround.
7745         * python/python-internal.h: Remove Python 2.4 comment.
7746         (Py_ssize_t): Don't define.
7747         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7748         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7749         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7750         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7751         * python/python.c (do_start_initialization): Remove Python 2.4
7752         workaround.
7753         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7754         (print_children): Remove Python 2.4 workaround.
7755         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7756         workaround.
7757         (CHARBUFFERPROC_NAME): Remove.
7758         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7759         Python 2.4 workaround.
7760
7761 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7762
7763         * NEWS: Note minimum Python version.
7764
7765 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7766
7767         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7768         code from these functions.  Remove corresponding ifdefs.  Use
7769         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7770         Remove gotos and target of gotos.
7771         (infpy_search_memory): Likewise.
7772
7773 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7774
7775         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7776         (hppa_gdbarch_init): Don't register deleted functions with
7777         gdbarch.
7778
7779 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7780
7781         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7782         (h8300_unwind_sp): Delete.
7783         (h8300_dummy_id): Delete.
7784         (h8300_gdbarch_init): Don't register deleted functions with
7785         gdbarch.
7786
7787 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7788
7789         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7790         (ft32_unwind_pc): Delete.
7791         (ft32_unwind_sp): Delete.
7792         (ft32_gdbarch_init): Don't register deleted functions with
7793         gdbarch.
7794
7795 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7796
7797         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7798         (frv_unwind_pc): Delete.
7799         (frv_unwind_sp): Delete.
7800         (frv_gdbarch_init): Don't register deleted functions with
7801         gdbarch.
7802
7803 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7804
7805         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7806         (riscv_unwind_pc): Delete.
7807         (riscv_unwind_sp): Delete.
7808         (riscv_gdbarch_init): Don't register deleted functions with
7809         gdbarch.
7810
7811 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7812
7813         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7814         (csky_unwind_pc): Delete.
7815         (csky_unwind_sp): Delete.
7816         (csky_gdbarch_init): Don't register deleted functions with
7817         gdbarch.
7818
7819 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7820
7821         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7822         (cris_unwind_pc): Delete.
7823         (cris_unwind_sp): Delete.
7824         (cris_gdbarch_init): Don't register deleted functions with
7825         gdbarch.
7826
7827 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7828
7829         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7830         (bfin_unwind_pc): Delete.
7831         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7832
7833 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7834
7835         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7836         (arm_unwind_pc): Delete.
7837         (arm_unwind_sp): Delete.
7838         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7839
7840 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7841
7842         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7843         (arc_unwind_pc): Delete.
7844         (arc_unwind_sp): Delete.
7845         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7846
7847 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7848
7849         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7850         (alpha_unwind_pc): Delete.
7851         (alpha_gdbarch_init): Don't register deleted functions with
7852         gdbarch.
7853
7854 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7855
7856         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7857         (aarch64_unwind_pc): Delete.
7858         (aarch64_unwind_sp): Delete.
7859         (aarch64_gdbarch_init): Don't register deleted functions with
7860         gdbarch.
7861
7862 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7863
7864         * gdbtypes.c (type_align): Don't consider static members when
7865         computing structure alignment.
7866
7867 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7868
7869         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7870         return 0 for other types.
7871         * arch-utils.c (default_type_align): Always return 0.
7872         * gdbarch.h: Regenerate.
7873         * gdbarch.sh (type_align): Extend comment.
7874         * gdbtypes.c (type_align): Add additional comments, always call
7875         gdbarch_type_align before applying the default rules.
7876         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7877         generic code will then apply a suitable default.
7878         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7879         types, return 0 for other types.
7880
7881 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7882
7883         * NEWS: Create a new section for the next release branch.
7884         Rename the section of the current branch, now that it has
7885         been cut.
7886
7887 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7888
7889         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7890         * version.in: Bump version to 8.3.50.DATE-git.
7891
7892 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7893
7894         * aix-thread.c (ptid_cmp): Remove unused variable.
7895         (get_signaled_thread): Likewise.
7896         (store_regs_user_thread): Likewise.
7897         (store_regs_kernel_thread): Likewise.
7898         (fetch_regs_kernel_thread): Remove shadowed variable.
7899
7900 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7901
7902         * features/riscv/32bit-cpu.xml: Add register numbers.
7903         * features/riscv/32bit-fpu.c: Regenerate.
7904         * features/riscv/32bit-fpu.xml: Add register numbers.
7905         * features/riscv/64bit-cpu.xml: Add register numbers.
7906         * features/riscv/64bit-fpu.c: Regenerate.
7907         * features/riscv/64bit-fpu.xml: Add register numbers.
7908
7909 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7910
7911         * NEWS: Mention two argument form of gdb.Value constructor.
7912         * python/py-value.c (convert_buffer_and_type_to_value): New
7913         function.
7914         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7915         Add support for handling an optional second argument.  Call
7916         convert_buffer_and_type_to_value as appropriate.
7917         * python/python-internal.h (Py_buffer_deleter): New struct.
7918         (Py_buffer_up): New typedef.
7919
7920 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7921
7922         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7923         instead of releasing ownership.
7924
7925 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7926
7927         * dwarf2read.c (open_and_init_dwp_file): Call
7928         elf_numsections instead of bfd_count_sections to initialize
7929         dwp_file->num_sections.
7930
7931 2019-02-25  Tom Tromey  <tromey@adacore.com>
7932
7933         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7934
7935 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7936
7937         * gcore.in: Add '--readnever' option when invoking GDB.
7938
7939 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7940
7941         * MAINTAINERS: Update my email address.
7942
7943 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7944
7945         * build-id.c (build_id_to_debug_bfd_1): New function.
7946         (build_id_to_debug_bfd): Look for separate debug file in
7947         sysroot.
7948
7949 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7950
7951         * gdbarch.sh: Update the copyright year range that is placed into
7952         generated files.
7953
7954 2019-02-22  Keith Seitz  <keiths@redhat.com>
7955
7956         PR symtab/23853
7957         * linespec.c (create_sals_line_offset): Search for the default
7958         symtab's filename instead of its fullname.
7959
7960 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7961
7962         * NEWS: Update style defaults.
7963
7964 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7965
7966         * main.c (captured_main_1): Disable styling in batch mode.
7967
7968 2019-02-20  Tom Tromey  <tom@tromey.com>
7969
7970         * symtab.c (symtab_symbol_info): Fix typos.
7971
7972 2019-02-20  Tom Tromey  <tromey@adacore.com>
7973
7974         * findcmd.c (_initialize_mem_search): Use upper case for
7975         metasyntactic variables.
7976
7977 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7978
7979         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7980         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7981
7982 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7983
7984         * top.h (source_file_name): Change to std::string.
7985         * top.c (source_file_name): Likewise.
7986         (command_line_input): Adjust.
7987         * cli/cli-script.c (script_from_file): Adjust.
7988
7989 2019-02-19  Tom Tromey  <tromey@adacore.com>
7990
7991         * ravenscar-thread.c
7992         (ravenscar_thread_target::update_thread_list): Don't call
7993         ada_build_task_list.
7994         * ada-lang.h (ada_build_task_list): Don't declare.
7995         * ada-tasks.c (struct ada_tasks_inferior_data)
7996         <task_list_valid_p>: Now bool.
7997         (read_known_tasks, ada_task_list_changed)
7998         (ada_tasks_invalidate_inferior_data): Update.
7999         (read_known_tasks_array): Return bool.
8000         (read_known_tasks_list): Likewise.
8001         (read_known_tasks): Return void.
8002         (ada_build_task_list): Now static.
8003
8004 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8005
8006         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8007         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8008
8009 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8010
8011         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8012         variant for ada_tasks_pspace_data_handle and
8013         ada_tasks_inferior_data_handle.
8014         (ada_tasks_pspace_data_cleanup): New function.
8015         (ada_tasks_inferior_data_cleanup): New function.
8016
8017 2019-02-17  Tom Tromey  <tom@tromey.com>
8018
8019         * macrotab.h (macro_source_fullname): Return a std::string.
8020         * macrotab.c (macro_include, check_for_redefinition)
8021         (macro_undef, macro_lookup_definition, foreach_macro)
8022         (foreach_macro_in_scope): Update.
8023         (macro_source_fullname): Return a std::string.
8024         * macrocmd.c (show_pp_source_pos): Update.
8025
8026 2019-02-17  Tom Tromey  <tom@tromey.com>
8027
8028         * macrocmd.c (show_pp_source_pos): Style the file names.
8029
8030 2019-02-17  Tom Tromey  <tom@tromey.com>
8031
8032         PR tui/24197:
8033         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8034
8035 2019-02-17  Tom Tromey  <tom@tromey.com>
8036
8037         * ada-lang.c (user_select_syms): Use filtered printing.
8038         * utils.c (wrap_style): New global.
8039         (desired_style): Remove.
8040         (emit_style_escape): Add stream parameter.
8041         (set_output_style, reset_terminal_style, prompt_for_continue):
8042         Update.
8043         (flush_wrap_buffer): Only flush gdb_stdout.
8044         (wrap_here): Set wrap_style.
8045         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8046         treat escape sequences as a character.  Change when wrap buffer is
8047         flushed.
8048         (fputs_styled): Do not set the output style when the default is
8049         requested.
8050         * ui-style.h (struct ui_file_style) <is_default>: New method.
8051         * source.c (print_source_lines_base): Emit escape sequences in one
8052         piece.
8053
8054 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8055
8056         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8057         integers and enumeration types.
8058
8059 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8060
8061         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8062         instead of lookup_symbol_in_language
8063         (do_exact_match): New function.
8064         (ada_get_symbol_name_matcher): Return do_exact_match when
8065         doing a verbatim match.
8066
8067 2019-02-15  Tom Tromey  <tromey@adacore.com>
8068
8069         * ravenscar-thread.c (ravenscar_thread_target::resume)
8070         (ravenscar_thread_target::wait): Special case wildcard requests.
8071
8072 2019-02-15  Tom Tromey  <tromey@adacore.com>
8073
8074         * ravenscar-thread.c (base_ptid): Remove.
8075         (struct ravenscar_thread_target) <close>: New method.
8076         <m_base_ptid>: New member.
8077         <update_inferior_ptid, active_task, task_is_currently_active,
8078         runtime_initialized>: Declare methods.
8079         <ravenscar_thread_target>: Add constructor.
8080         (ravenscar_thread_target::task_is_currently_active)
8081         (ravenscar_thread_target::update_inferior_ptid)
8082         (ravenscar_runtime_initialized): Rename.  Now methods.
8083         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8084         (ravenscar_thread_target::update_thread_list): Update.
8085         (ravenscar_thread_target::active_task): Now method.
8086         (ravenscar_thread_target::store_registers)
8087         (ravenscar_thread_target::prepare_to_store)
8088         (ravenscar_thread_target::prepare_to_store)
8089         (ravenscar_thread_target::mourn_inferior): Update.
8090         (ravenscar_inferior_created): Use "new" to create target.
8091         (ravenscar_thread_target::get_ada_task_ptid): Update.
8092         (_initialize_ravenscar): Don't initialize base_ptid.
8093         (ravenscar_ops): Remove global.
8094
8095 2019-02-15  Tom Tromey  <tromey@adacore.com>
8096
8097         * target.h (push_target): Declare new overload.
8098         * target.c (push_target): New overload, taking an rvalue reference.
8099         * remote.c (remote_target::open_1): Use push_target overload.
8100         * corelow.c (core_target_open): Use push_target overload.
8101
8102 2019-02-15  Tom Tromey  <tromey@adacore.com>
8103
8104         * ravenscar-thread.c (is_ravenscar_task)
8105         (ravenscar_task_is_currently_active): Return bool.
8106         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8107         (_initialize_ravenscar): Remove "(void)".
8108         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8109         Return bool.
8110
8111 2019-02-15  Tom Tromey  <tromey@adacore.com>
8112
8113         * ravenscar-thread.c (ravenscar_runtime_initializer)
8114         (has_ravenscar_runtime, get_running_thread_id)
8115         (ravenscar_thread_target::resume): Fix indentation.
8116
8117 2019-02-15  Tom Tromey  <tromey@adacore.com>
8118
8119         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8120         from ravenscar_arch_ops.
8121         (sparc_ravenscar_ops::fetch_registers)
8122         (sparc_ravenscar_ops::store_registers): Now methods.
8123         (sparc_ravenscar_prepare_to_store): Remove.
8124         (sparc_ravenscar_ops): Redefine.
8125         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8126         methods and destructor.  Remove members.
8127         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8128         (ravenscar_thread_target::store_registers)
8129         (ravenscar_thread_target::prepare_to_store): Update.
8130         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8131         Remove.
8132         (struct ppc_ravenscar_powerpc_ops): Derive from
8133         ravenscar_arch_ops.
8134         (ppc_ravenscar_powerpc_ops::fetch_registers)
8135         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8136         (ppc_ravenscar_powerpc_ops): Redefine.
8137         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8138         (ppc_ravenscar_e500_ops::fetch_registers)
8139         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8140         (ppc_ravenscar_e500_ops): Redefine.
8141         * aarch64-ravenscar-thread.c
8142         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8143         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8144         (aarch64_ravenscar_fetch_registers)
8145         (aarch64_ravenscar_store_registers): Now methods.
8146         (aarch64_ravenscar_ops): Redefine.
8147
8148 2019-02-15  Tom Tromey  <tromey@adacore.com>
8149
8150         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8151         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8152         (ravenscar_thread_target::stopped_by_watchpoint)
8153         (ravenscar_thread_target::stopped_data_address)
8154         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8155
8156 2019-02-15  Tom Tromey  <tromey@adacore.com>
8157
8158         * ravenscar-thread.c: Fix some typos.
8159
8160 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8161             Tom Tromey  <tromey@adacore.com>
8162
8163         * ada-lang.c (ada_exception_sal): Change addr_string to a
8164         std::string.
8165         (create_ada_exception_catchpoint): Update.
8166
8167 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8168             Tom Tromey  <tromey@adacore.com>
8169
8170         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8171         (bp_location_ops): Remove.
8172         (base_breakpoint_allocate_location): Update.
8173         (free_bp_location): Update.
8174         * ada-lang.c (class ada_catchpoint_location)
8175         <ada_catchpoint_location>: Remove ops parameter.
8176         (ada_catchpoint_location_dtor): Remove.
8177         (ada_catchpoint_location_ops): Remove.
8178         (allocate_location_exception): Update.
8179         * breakpoint.h (struct bp_location_ops): Remove.
8180         (class bp_location) <bp_location>: Remove bp_location_ops
8181         parameter.
8182         <~bp_location>: Add destructor.
8183         <ops>: Remove.
8184
8185 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8186             Pedro Alves  <palves@redhat.com>
8187
8188         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8189         'PATH_MAX'.
8190
8191 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8192             Samuel Thibault  <samuel.thibault@gnu.org>
8193             Thomas Schwinge  <thomas@codesourcery.com>
8194
8195         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8196         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8197
8198 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8199
8200         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8201         (check_empty): Use "const char *".
8202
8203         * gnu-nat.c (gnu_nat_target::detach): Instead of
8204         'detach_inferior (pid)' call
8205         'detach_inferior (find_inferior_pid (pid))'.
8206
8207         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8208         'nat/fork-inferior.o'.
8209         * gnu-nat.c: #include "nat/fork-inferior.h".
8210
8211         * gnu-nat.c (gnu_nat_target::detach): Instead of
8212         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8213         * gnu-nat.h: #include "inf-child.h".
8214         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8215         'i386_gnu_nat_target::fetch_registers'.
8216         (gnu_store_registers): Rename/move to
8217         'i386_gnu_nat_target::store_registers'.
8218
8219         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8220         * gnu-nat.h (mach_thread_info): New function.
8221         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8222
8223         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8224
8225 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8226
8227         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8228
8229 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8230
8231         * windows-nat.c (windows_add_thread): Add new parameter
8232         "main_thread_p" with default value set to false.  Update
8233         function documentation as well as all callers.
8234         (windows_delete_thread): Likewise.
8235         (fake_create_process): Update call to windows_add_thread.
8236         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8237         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8238         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8239         call to windows_delete_thread.
8240
8241 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8242
8243         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8244
8245 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8246
8247         * symfile.c (find_separate_debug_file): Use canonical path of
8248         sysroot with child_path instead of gdb_sysroot if it is valid.
8249
8250 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8251
8252         * symfile.c (find_separate_debug_file): Use child_path to
8253         determine if an object file is under a sysroot.
8254
8255 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8256
8257         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8258         unittests/child-path-selftests.c.
8259         * common/pathstuff.c (child_path): New function.
8260         * common/pathstuff.h (child_path): New prototype.
8261         * unittests/child-path-selftests.c: New file.
8262
8263 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8264
8265         * symfile.c (find_separate_debug_file): Look for separate debug
8266         files in debug directories under the sysroot.
8267
8268 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8269
8270         * symtab.h (struct minimal_symbol data_p): New const method.
8271         (struct minimal_symbol text_p): Likewise.
8272         * symtab.c (output_source_filename): Use file name style
8273         to print file name.
8274         (print_symbol_info): Likewise.
8275         (print_msymbol_info): Use address style to print addresses.
8276         Use function name style to print executable text symbols.
8277         (expand_symtab_containing_pc): Use data_p.
8278         (find_pc_sect_compunit_symtab): Likewise.
8279
8280 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8281
8282         * breakpoint.c (describe_other_breakpoints): Use address style
8283         to print addresses.
8284         (say_where): Likewise.
8285
8286 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8287
8288         * ada-typeprint.c (print_func_type): Print function name
8289         style to print function name.
8290         * c-typeprint.c (c_print_type_1): Likewise.
8291
8292 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8293
8294         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8295         for execve.
8296
8297 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8298
8299         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8300         type_stack.
8301
8302 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8303
8304         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8305         TYPE_CODE_REF types.
8306
8307 2019-02-08  Jim Wilson  <jimw@sifive.com>
8308
8309         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8310         (riscv_linux_fregset): New.
8311         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8312
8313 2019-02-07  Tom Tromey  <tom@tromey.com>
8314
8315         * thread.c (thread_cancel_execution_command): Update.
8316         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8317         methods.
8318         (struct thread_fsm_ops): Remove.
8319         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8320         (thread_fsm_should_stop, thread_fsm_return_value)
8321         (thread_fsm_set_finished, thread_fsm_finished_p)
8322         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8323         Don't declare.
8324         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8325         * infrun.c (clear_proceed_status_thread)
8326         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8327         (print_stop_event): Update.
8328         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8329         Add constructor.
8330         (step_command_fsm_ops): Remove.
8331         (new_step_command_fsm): Remove.
8332         (step_1): Update.
8333         (step_command_fsm::should_stop): Rename from
8334         step_command_fsm_should_stop.
8335         (step_command_fsm::clean_up): Rename from
8336         step_command_fsm_clean_up.
8337         (step_command_fsm::do_async_reply_reason): Rename from
8338         step_command_fsm_async_reply_reason.
8339         (struct until_next_fsm): Inherit from thread_fsm.  Add
8340         constructor.
8341         (until_next_fsm_ops): Remove.
8342         (new_until_next_fsm): Remove.
8343         (until_next_fsm::should_stop): Rename from
8344         until_next_fsm_should_stop.
8345         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8346         (until_next_fsm::do_async_reply_reason): Rename from
8347         until_next_fsm_async_reply_reason.
8348         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8349         constructor.  Change type of breakpoint.
8350         (finish_command_fsm_ops): Remove.
8351         (new_finish_command_fsm): Remove.
8352         (finish_command_fsm::should_stop): Rename from
8353         finish_command_fsm_should_stop.
8354         (finish_command_fsm::clean_up): Rename from
8355         finish_command_fsm_clean_up.
8356         (finish_command_fsm::return_value): Rename from
8357         finish_command_fsm_return_value.
8358         (finish_command_fsm::do_async_reply_reason): Rename from
8359         finish_command_fsm_async_reply_reason.
8360         (finish_command): Update.
8361         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8362         Add constructor.
8363         (call_thread_fsm_ops): Remove.
8364         (call_thread_fsm::call_thread_fsm): Rename from
8365         new_call_thread_fsm.
8366         (call_thread_fsm::should_stop): Rename from
8367         call_thread_fsm_should_stop.
8368         (call_thread_fsm::should_notify_stop): Rename from
8369         call_thread_fsm_should_notify_stop.
8370         (run_inferior_call, call_function_by_hand_dummy): Update.
8371         * cli/cli-interp.c (should_print_stop_to_console): Update.
8372         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8373         Add constructor.  Change type of location_breakpoint,
8374         caller_breakpoint.
8375         (until_break_fsm_ops): Remove.
8376         (new_until_break_fsm): Remove.
8377         (until_break_fsm::should_stop): Rename from
8378         until_break_fsm_should_stop.
8379         (until_break_fsm::clean_up): Rename from
8380         until_break_fsm_clean_up.
8381         (until_break_fsm::do_async_reply_reason): Rename from
8382         until_break_fsm_async_reply_reason.
8383         (until_break_command): Update.
8384         * thread-fsm.c: Remove.
8385         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8386
8387 2019-02-07  Tom Tromey  <tom@tromey.com>
8388
8389         * yy-remap.h: Add include guard.
8390         * xtensa-tdep.h: Add include guard.
8391         * xcoffread.h: Rename include guard.
8392         * varobj-iter.h: Add include guard.
8393         * tui/tui.h: Rename include guard.
8394         * tui/tui-winsource.h: Rename include guard.
8395         * tui/tui-wingeneral.h: Rename include guard.
8396         * tui/tui-windata.h: Rename include guard.
8397         * tui/tui-win.h: Rename include guard.
8398         * tui/tui-stack.h: Rename include guard.
8399         * tui/tui-source.h: Rename include guard.
8400         * tui/tui-regs.h: Rename include guard.
8401         * tui/tui-out.h: Rename include guard.
8402         * tui/tui-layout.h: Rename include guard.
8403         * tui/tui-io.h: Rename include guard.
8404         * tui/tui-hooks.h: Rename include guard.
8405         * tui/tui-file.h: Rename include guard.
8406         * tui/tui-disasm.h: Rename include guard.
8407         * tui/tui-data.h: Rename include guard.
8408         * tui/tui-command.h: Rename include guard.
8409         * tic6x-tdep.h: Add include guard.
8410         * target/waitstatus.h: Rename include guard.
8411         * target/wait.h: Rename include guard.
8412         * target/target.h: Rename include guard.
8413         * target/resume.h: Rename include guard.
8414         * target-float.h: Rename include guard.
8415         * stabsread.h: Add include guard.
8416         * rs6000-tdep.h: Add include guard.
8417         * riscv-fbsd-tdep.h: Add include guard.
8418         * regformats/regdef.h: Rename include guard.
8419         * record.h: Rename include guard.
8420         * python/python.h: Rename include guard.
8421         * python/python-internal.h: Rename include guard.
8422         * python/py-stopevent.h: Rename include guard.
8423         * python/py-ref.h: Rename include guard.
8424         * python/py-record.h: Rename include guard.
8425         * python/py-record-full.h: Rename include guard.
8426         * python/py-record-btrace.h: Rename include guard.
8427         * python/py-instruction.h: Rename include guard.
8428         * python/py-events.h: Rename include guard.
8429         * python/py-event.h: Rename include guard.
8430         * procfs.h: Add include guard.
8431         * proc-utils.h: Add include guard.
8432         * p-lang.h: Add include guard.
8433         * or1k-tdep.h: Rename include guard.
8434         * observable.h: Rename include guard.
8435         * nto-tdep.h: Rename include guard.
8436         * nat/x86-linux.h: Rename include guard.
8437         * nat/x86-linux-dregs.h: Rename include guard.
8438         * nat/x86-gcc-cpuid.h: Add include guard.
8439         * nat/x86-dregs.h: Rename include guard.
8440         * nat/x86-cpuid.h: Rename include guard.
8441         * nat/ppc-linux.h: Rename include guard.
8442         * nat/mips-linux-watch.h: Rename include guard.
8443         * nat/linux-waitpid.h: Rename include guard.
8444         * nat/linux-ptrace.h: Rename include guard.
8445         * nat/linux-procfs.h: Rename include guard.
8446         * nat/linux-osdata.h: Rename include guard.
8447         * nat/linux-nat.h: Rename include guard.
8448         * nat/linux-namespaces.h: Rename include guard.
8449         * nat/linux-btrace.h: Rename include guard.
8450         * nat/glibc_thread_db.h: Rename include guard.
8451         * nat/gdb_thread_db.h: Rename include guard.
8452         * nat/gdb_ptrace.h: Rename include guard.
8453         * nat/fork-inferior.h: Rename include guard.
8454         * nat/amd64-linux-siginfo.h: Rename include guard.
8455         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8456         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8457         * nat/aarch64-linux.h: Rename include guard.
8458         * nat/aarch64-linux-hw-point.h: Rename include guard.
8459         * mn10300-tdep.h: Add include guard.
8460         * mips-linux-tdep.h: Add include guard.
8461         * mi/mi-parse.h: Rename include guard.
8462         * mi/mi-out.h: Rename include guard.
8463         * mi/mi-main.h: Rename include guard.
8464         * mi/mi-interp.h: Rename include guard.
8465         * mi/mi-getopt.h: Rename include guard.
8466         * mi/mi-console.h: Rename include guard.
8467         * mi/mi-common.h: Rename include guard.
8468         * mi/mi-cmds.h: Rename include guard.
8469         * mi/mi-cmd-break.h: Rename include guard.
8470         * m2-lang.h: Add include guard.
8471         * location.h: Rename include guard.
8472         * linux-record.h: Rename include guard.
8473         * linux-nat.h: Add include guard.
8474         * linux-fork.h: Add include guard.
8475         * i386-darwin-tdep.h: Rename include guard.
8476         * hppa-linux-offsets.h: Add include guard.
8477         * guile/guile.h: Rename include guard.
8478         * guile/guile-internal.h: Rename include guard.
8479         * gnu-nat.h: Rename include guard.
8480         * gdb-stabs.h: Rename include guard.
8481         * frv-tdep.h: Add include guard.
8482         * f-lang.h: Add include guard.
8483         * event-loop.h: Add include guard.
8484         * darwin-nat.h: Rename include guard.
8485         * cp-abi.h: Rename include guard.
8486         * config/sparc/nm-sol2.h: Rename include guard.
8487         * config/nm-nto.h: Rename include guard.
8488         * config/nm-linux.h: Add include guard.
8489         * config/i386/nm-i386gnu.h: Rename include guard.
8490         * config/djgpp/nl_types.h: Rename include guard.
8491         * config/djgpp/langinfo.h: Rename include guard.
8492         * compile/gcc-cp-plugin.h: Add include guard.
8493         * compile/gcc-c-plugin.h: Add include guard.
8494         * compile/compile.h: Rename include guard.
8495         * compile/compile-object-run.h: Rename include guard.
8496         * compile/compile-object-load.h: Rename include guard.
8497         * compile/compile-internal.h: Rename include guard.
8498         * compile/compile-cplus.h: Rename include guard.
8499         * compile/compile-c.h: Rename include guard.
8500         * common/xml-utils.h: Rename include guard.
8501         * common/x86-xstate.h: Rename include guard.
8502         * common/version.h: Rename include guard.
8503         * common/vec.h: Rename include guard.
8504         * common/tdesc.h: Rename include guard.
8505         * common/selftest.h: Rename include guard.
8506         * common/scoped_restore.h: Rename include guard.
8507         * common/scoped_mmap.h: Rename include guard.
8508         * common/scoped_fd.h: Rename include guard.
8509         * common/safe-iterator.h: Rename include guard.
8510         * common/run-time-clock.h: Rename include guard.
8511         * common/refcounted-object.h: Rename include guard.
8512         * common/queue.h: Rename include guard.
8513         * common/ptid.h: Rename include guard.
8514         * common/print-utils.h: Rename include guard.
8515         * common/preprocessor.h: Rename include guard.
8516         * common/pathstuff.h: Rename include guard.
8517         * common/observable.h: Rename include guard.
8518         * common/netstuff.h: Rename include guard.
8519         * common/job-control.h: Rename include guard.
8520         * common/host-defs.h: Rename include guard.
8521         * common/gdb_wait.h: Rename include guard.
8522         * common/gdb_vecs.h: Rename include guard.
8523         * common/gdb_unlinker.h: Rename include guard.
8524         * common/gdb_unique_ptr.h: Rename include guard.
8525         * common/gdb_tilde_expand.h: Rename include guard.
8526         * common/gdb_sys_time.h: Rename include guard.
8527         * common/gdb_string_view.h: Rename include guard.
8528         * common/gdb_splay_tree.h: Rename include guard.
8529         * common/gdb_setjmp.h: Rename include guard.
8530         * common/gdb_ref_ptr.h: Rename include guard.
8531         * common/gdb_optional.h: Rename include guard.
8532         * common/gdb_locale.h: Rename include guard.
8533         * common/gdb_assert.h: Rename include guard.
8534         * common/filtered-iterator.h: Rename include guard.
8535         * common/filestuff.h: Rename include guard.
8536         * common/fileio.h: Rename include guard.
8537         * common/environ.h: Rename include guard.
8538         * common/common-utils.h: Rename include guard.
8539         * common/common-types.h: Rename include guard.
8540         * common/common-regcache.h: Rename include guard.
8541         * common/common-inferior.h: Rename include guard.
8542         * common/common-gdbthread.h: Rename include guard.
8543         * common/common-exceptions.h: Rename include guard.
8544         * common/common-defs.h: Rename include guard.
8545         * common/common-debug.h: Rename include guard.
8546         * common/cleanups.h: Rename include guard.
8547         * common/buffer.h: Rename include guard.
8548         * common/btrace-common.h: Rename include guard.
8549         * common/break-common.h: Rename include guard.
8550         * cli/cli-utils.h: Rename include guard.
8551         * cli/cli-style.h: Rename include guard.
8552         * cli/cli-setshow.h: Rename include guard.
8553         * cli/cli-script.h: Rename include guard.
8554         * cli/cli-interp.h: Rename include guard.
8555         * cli/cli-decode.h: Rename include guard.
8556         * cli/cli-cmds.h: Rename include guard.
8557         * charset-list.h: Add include guard.
8558         * buildsym-legacy.h: Rename include guard.
8559         * bfin-tdep.h: Add include guard.
8560         * ax.h: Rename include guard.
8561         * arm-linux-tdep.h: Add include guard.
8562         * arm-fbsd-tdep.h: Add include guard.
8563         * arch/xtensa.h: Rename include guard.
8564         * arch/tic6x.h: Add include guard.
8565         * arch/i386.h: Add include guard.
8566         * arch/arm.h: Rename include guard.
8567         * arch/arm-linux.h: Rename include guard.
8568         * arch/arm-get-next-pcs.h: Rename include guard.
8569         * arch/amd64.h: Add include guard.
8570         * arch/aarch64-insn.h: Rename include guard.
8571         * arch-utils.h: Rename include guard.
8572         * annotate.h: Add include guard.
8573         * amd64-darwin-tdep.h: Rename include guard.
8574         * aarch64-linux-tdep.h: Add include guard.
8575         * aarch64-fbsd-tdep.h: Add include guard.
8576         * aarch32-linux-nat.h: Add include guard.
8577
8578 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8579
8580         * macrotab.c (macro_define_internal): New function that
8581         factorizes macro_define_object_internal and macro_define_function
8582         code.
8583         (macro_define_object_internal): Use macro_define_internal.
8584         (macro_define_function): Likewise.
8585
8586 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8587
8588         * macrocmd.c (extract_identifier): Return
8589         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8590         callers.
8591
8592 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8593
8594         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8595
8596 2019-02-05  Tom Tromey  <tom@tromey.com>
8597
8598         * target.c (target_stack::unpush): Move assertion earlier.
8599
8600 2019-01-30  Tom Tromey  <tom@tromey.com>
8601
8602         PR python/23615:
8603         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8604         (gdbpy_parse_and_eval): Likewise.
8605         * python/python-internal.h (gdbpy_allow_threads): New class.
8606
8607 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8608
8609         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8610         (aarch64_fbsd_fpregmap): Move earlier.
8611         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8612         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8613         instead of individual calls to trad_frame_set_reg_addr.
8614         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8615         earlier.
8616         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8617         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8618         instead of individual calls to trad_frame_set_reg_addr.
8619
8620 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8621
8622         * CONTRIBUTE: Replace contribution list with wiki link.
8623
8624 2019-01-25  Tom Tromey  <tom@tromey.com>
8625
8626         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8627
8628 2019-01-25  Tom Tromey  <tom@tromey.com>
8629
8630         * xtensa-linux-nat.c: Fix common/ includes.
8631         * xml-support.h: Fix common/ includes.
8632         * xml-support.c: Fix common/ includes.
8633         * x86-linux-nat.c: Fix common/ includes.
8634         * windows-nat.c: Fix common/ includes.
8635         * varobj.h: Fix common/ includes.
8636         * varobj.c: Fix common/ includes.
8637         * value.c: Fix common/ includes.
8638         * valops.c: Fix common/ includes.
8639         * utils.c: Fix common/ includes.
8640         * unittests/xml-utils-selftests.c: Fix common/ includes.
8641         * unittests/utils-selftests.c: Fix common/ includes.
8642         * unittests/unpack-selftests.c: Fix common/ includes.
8643         * unittests/tracepoint-selftests.c: Fix common/ includes.
8644         * unittests/style-selftests.c: Fix common/ includes.
8645         * unittests/string_view-selftests.c: Fix common/ includes.
8646         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8647         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8648         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8649         * unittests/rsp-low-selftests.c: Fix common/ includes.
8650         * unittests/parse-connection-spec-selftests.c: Fix common/
8651         includes.
8652         * unittests/optional-selftests.c: Fix common/ includes.
8653         * unittests/offset-type-selftests.c: Fix common/ includes.
8654         * unittests/observable-selftests.c: Fix common/ includes.
8655         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8656         * unittests/memrange-selftests.c: Fix common/ includes.
8657         * unittests/memory-map-selftests.c: Fix common/ includes.
8658         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8659         * unittests/function-view-selftests.c: Fix common/ includes.
8660         * unittests/environ-selftests.c: Fix common/ includes.
8661         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8662         * unittests/common-utils-selftests.c: Fix common/ includes.
8663         * unittests/cli-utils-selftests.c: Fix common/ includes.
8664         * unittests/array-view-selftests.c: Fix common/ includes.
8665         * ui-file.c: Fix common/ includes.
8666         * tui/tui-io.c: Fix common/ includes.
8667         * tracepoint.h: Fix common/ includes.
8668         * tracepoint.c: Fix common/ includes.
8669         * tracefile-tfile.c: Fix common/ includes.
8670         * top.h: Fix common/ includes.
8671         * top.c: Fix common/ includes.
8672         * thread.c: Fix common/ includes.
8673         * target/waitstatus.h: Fix common/ includes.
8674         * target/waitstatus.c: Fix common/ includes.
8675         * target.h: Fix common/ includes.
8676         * target.c: Fix common/ includes.
8677         * target-memory.c: Fix common/ includes.
8678         * target-descriptions.c: Fix common/ includes.
8679         * symtab.h: Fix common/ includes.
8680         * symfile.c: Fix common/ includes.
8681         * stap-probe.c: Fix common/ includes.
8682         * spu-linux-nat.c: Fix common/ includes.
8683         * sparc-nat.c: Fix common/ includes.
8684         * source.c: Fix common/ includes.
8685         * solib.c: Fix common/ includes.
8686         * solib-target.c: Fix common/ includes.
8687         * ser-unix.c: Fix common/ includes.
8688         * ser-tcp.c: Fix common/ includes.
8689         * ser-pipe.c: Fix common/ includes.
8690         * ser-base.c: Fix common/ includes.
8691         * selftest-arch.c: Fix common/ includes.
8692         * s12z-tdep.c: Fix common/ includes.
8693         * rust-exp.y: Fix common/ includes.
8694         * rs6000-aix-tdep.c: Fix common/ includes.
8695         * riscv-tdep.c: Fix common/ includes.
8696         * remote.c: Fix common/ includes.
8697         * remote-notif.h: Fix common/ includes.
8698         * remote-fileio.h: Fix common/ includes.
8699         * remote-fileio.c: Fix common/ includes.
8700         * regcache.h: Fix common/ includes.
8701         * regcache.c: Fix common/ includes.
8702         * record-btrace.c: Fix common/ includes.
8703         * python/python.c: Fix common/ includes.
8704         * python/py-type.c: Fix common/ includes.
8705         * python/py-inferior.c: Fix common/ includes.
8706         * progspace.h: Fix common/ includes.
8707         * producer.c: Fix common/ includes.
8708         * procfs.c: Fix common/ includes.
8709         * proc-api.c: Fix common/ includes.
8710         * printcmd.c: Fix common/ includes.
8711         * ppc-linux-nat.c: Fix common/ includes.
8712         * parser-defs.h: Fix common/ includes.
8713         * osdata.c: Fix common/ includes.
8714         * obsd-nat.c: Fix common/ includes.
8715         * nat/x86-linux.c: Fix common/ includes.
8716         * nat/x86-linux-dregs.c: Fix common/ includes.
8717         * nat/x86-dregs.h: Fix common/ includes.
8718         * nat/x86-dregs.c: Fix common/ includes.
8719         * nat/ppc-linux.c: Fix common/ includes.
8720         * nat/mips-linux-watch.h: Fix common/ includes.
8721         * nat/mips-linux-watch.c: Fix common/ includes.
8722         * nat/linux-waitpid.c: Fix common/ includes.
8723         * nat/linux-ptrace.h: Fix common/ includes.
8724         * nat/linux-ptrace.c: Fix common/ includes.
8725         * nat/linux-procfs.c: Fix common/ includes.
8726         * nat/linux-personality.c: Fix common/ includes.
8727         * nat/linux-osdata.c: Fix common/ includes.
8728         * nat/linux-namespaces.c: Fix common/ includes.
8729         * nat/linux-btrace.h: Fix common/ includes.
8730         * nat/linux-btrace.c: Fix common/ includes.
8731         * nat/fork-inferior.c: Fix common/ includes.
8732         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8733         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8734         * nat/aarch64-linux.c: Fix common/ includes.
8735         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8736         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8737         * namespace.h: Fix common/ includes.
8738         * mips-linux-tdep.c: Fix common/ includes.
8739         * minsyms.c: Fix common/ includes.
8740         * mi/mi-parse.h: Fix common/ includes.
8741         * mi/mi-main.c: Fix common/ includes.
8742         * mi/mi-cmd-env.c: Fix common/ includes.
8743         * memrange.h: Fix common/ includes.
8744         * memattr.c: Fix common/ includes.
8745         * maint.h: Fix common/ includes.
8746         * maint.c: Fix common/ includes.
8747         * main.c: Fix common/ includes.
8748         * machoread.c: Fix common/ includes.
8749         * location.c: Fix common/ includes.
8750         * linux-thread-db.c: Fix common/ includes.
8751         * linux-nat.c: Fix common/ includes.
8752         * linux-fork.c: Fix common/ includes.
8753         * inline-frame.c: Fix common/ includes.
8754         * infrun.c: Fix common/ includes.
8755         * inflow.c: Fix common/ includes.
8756         * inferior.h: Fix common/ includes.
8757         * inferior.c: Fix common/ includes.
8758         * infcmd.c: Fix common/ includes.
8759         * inf-ptrace.c: Fix common/ includes.
8760         * inf-child.c: Fix common/ includes.
8761         * ia64-linux-nat.c: Fix common/ includes.
8762         * i387-tdep.c: Fix common/ includes.
8763         * i386-tdep.c: Fix common/ includes.
8764         * i386-linux-tdep.c: Fix common/ includes.
8765         * i386-linux-nat.c: Fix common/ includes.
8766         * i386-go32-tdep.c: Fix common/ includes.
8767         * i386-fbsd-tdep.c: Fix common/ includes.
8768         * i386-fbsd-nat.c: Fix common/ includes.
8769         * guile/scm-type.c: Fix common/ includes.
8770         * guile/guile.c: Fix common/ includes.
8771         * go32-nat.c: Fix common/ includes.
8772         * gnu-nat.c: Fix common/ includes.
8773         * gdbthread.h: Fix common/ includes.
8774         * gdbarch-selftests.c: Fix common/ includes.
8775         * gdb_usleep.c: Fix common/ includes.
8776         * gdb_select.h: Fix common/ includes.
8777         * gdb_bfd.c: Fix common/ includes.
8778         * gcore.c: Fix common/ includes.
8779         * fork-child.c: Fix common/ includes.
8780         * findvar.c: Fix common/ includes.
8781         * fbsd-nat.c: Fix common/ includes.
8782         * event-top.c: Fix common/ includes.
8783         * event-loop.c: Fix common/ includes.
8784         * dwarf2read.c: Fix common/ includes.
8785         * dwarf2loc.c: Fix common/ includes.
8786         * dwarf2-frame.c: Fix common/ includes.
8787         * dwarf-index-cache.c: Fix common/ includes.
8788         * dtrace-probe.c: Fix common/ includes.
8789         * disasm-selftests.c: Fix common/ includes.
8790         * defs.h: Fix common/ includes.
8791         * csky-tdep.c: Fix common/ includes.
8792         * cp-valprint.c: Fix common/ includes.
8793         * cp-support.h: Fix common/ includes.
8794         * cp-support.c: Fix common/ includes.
8795         * corelow.c: Fix common/ includes.
8796         * completer.h: Fix common/ includes.
8797         * completer.c: Fix common/ includes.
8798         * compile/compile.c: Fix common/ includes.
8799         * compile/compile-loc2c.c: Fix common/ includes.
8800         * compile/compile-cplus-types.c: Fix common/ includes.
8801         * compile/compile-cplus-symbols.c: Fix common/ includes.
8802         * command.h: Fix common/ includes.
8803         * cli/cli-dump.c: Fix common/ includes.
8804         * cli/cli-cmds.c: Fix common/ includes.
8805         * charset.c: Fix common/ includes.
8806         * build-id.c: Fix common/ includes.
8807         * btrace.h: Fix common/ includes.
8808         * btrace.c: Fix common/ includes.
8809         * breakpoint.h: Fix common/ includes.
8810         * breakpoint.c: Fix common/ includes.
8811         * ax.h:
8812         (enum agent_op): Fix common/ includes.
8813         * ax-general.c (struct aop_map): Fix common/ includes.
8814         * ax-gdb.c: Fix common/ includes.
8815         * auxv.c: Fix common/ includes.
8816         * auto-load.c: Fix common/ includes.
8817         * arm-tdep.c: Fix common/ includes.
8818         * arch/riscv.c: Fix common/ includes.
8819         * arch/ppc-linux-common.c: Fix common/ includes.
8820         * arch/i386.c: Fix common/ includes.
8821         * arch/arm.c: Fix common/ includes.
8822         * arch/arm-linux.c: Fix common/ includes.
8823         * arch/arm-get-next-pcs.c: Fix common/ includes.
8824         * arch/amd64.c: Fix common/ includes.
8825         * arch/aarch64.c: Fix common/ includes.
8826         * arch/aarch64-insn.c: Fix common/ includes.
8827         * arch-utils.c: Fix common/ includes.
8828         * amd64-windows-tdep.c: Fix common/ includes.
8829         * amd64-tdep.c: Fix common/ includes.
8830         * amd64-sol2-tdep.c: Fix common/ includes.
8831         * amd64-obsd-tdep.c: Fix common/ includes.
8832         * amd64-nbsd-tdep.c: Fix common/ includes.
8833         * amd64-linux-tdep.c: Fix common/ includes.
8834         * amd64-linux-nat.c: Fix common/ includes.
8835         * amd64-fbsd-tdep.c: Fix common/ includes.
8836         * amd64-fbsd-nat.c: Fix common/ includes.
8837         * amd64-dicos-tdep.c: Fix common/ includes.
8838         * amd64-darwin-tdep.c: Fix common/ includes.
8839         * agent.c: Fix common/ includes.
8840         * ada-lang.h: Fix common/ includes.
8841         * ada-lang.c: Fix common/ includes.
8842         * aarch64-tdep.c: Fix common/ includes.
8843
8844 2019-01-25  Tom Tromey  <tom@tromey.com>
8845
8846         * common/create-version.sh: Use common/version.h.
8847
8848 2019-01-24  Pedro Alves  <palves@redhat.com>
8849
8850         * infrun.c (signal_stop, signal_print, signal_program)
8851         (signal_catch, signal_pass): Now arrays instead of pointers.
8852         (update_signals_program_target, do_target_resume)
8853         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8854         * linux-nat.c (linux_nat_target::pass_signals)
8855         (linux_nat_target::create_inferior, linux_nat_target::attach):
8856         Adjust.
8857         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8858         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8859         * procfs.c (procfs_target::pass_signals): Adjust.
8860         * record-full.c (record_full_target::resume): Adjust.
8861         * remote.c (remote_target::pass_signals)
8862         (remote_target::program_signals): Adjust.
8863         * target-debug.h (target_debug_print_signals): Now takes a
8864         gdb::array_view as parameter.  Adjust.
8865         * target.h (target_ops) <pass_signals, program_signals>: Replace
8866         pointer and length parameters with gdb::array_view.
8867         (target_pass_signals, target_program_signals): Likewise.
8868         * target-delegates.c: Regenerate.
8869
8870 2019-01-24  Pedro Alves  <palves@redhat.com>
8871
8872         * common/forward-scope-exit.h
8873         (forward_scope_exit::forward_scope_exit): Pass arguments to
8874         m_bind_function directly, instead of creating a std::bind and
8875         copying that.
8876
8877 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8878
8879         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8880         for static members.
8881         (pass_in_v_vfp_candidate): Likewise.
8882
8883 2019-01-23  Tom Tromey  <tom@tromey.com>
8884             Pedro Alves  <palves@redhat.com>
8885
8886         * regcache.c (class regcache_invalidator): Remove.
8887         (regcache::raw_write): Use make_scope_exit.
8888
8889 2019-01-23  Tom Tromey  <tom@tromey.com>
8890
8891         * ui-out.h (class ui_out_emit_type): Update comment.
8892
8893 2019-01-23  Tom Tromey  <tom@tromey.com>
8894
8895         * infrun.c (fetch_inferior_event): Update comment.
8896
8897 2019-01-23  Tom Tromey  <tom@tromey.com>
8898             Pedro Alves  <palves@redhat.com>
8899
8900         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8901         parameter.
8902         (fetch_inferior_event): Use SCOPE_EXIT.
8903
8904
8905 2019-01-23  Tom Tromey  <tom@tromey.com>
8906             Pedro Alves  <palves@redhat.com>
8907
8908         * infrun.c (disable_thread_events): Delete.
8909         (stop_all_threads): Use SCOPE_EXIT.
8910
8911 2019-01-23  Tom Tromey  <tom@tromey.com>
8912             Pedro Alves  <palves@redhat.com>
8913
8914         * symfile.c: Include forward-scope-exit.h.
8915         (clear_symtab_users_cleanup): Replace forward declaration with
8916         a FORWARD_SCOPE_EXIT.
8917         (syms_from_objfile_1): Use the forward_scope_exit and
8918         gdb::optional instead of cleanup_function.
8919         (reread_symbols): Use the forward_scope_exit instead of
8920         cleanup_function.
8921         (clear_symtab_users_cleanup): Remove function.
8922
8923 2019-01-23  Tom Tromey  <tom@tromey.com>
8924             Pedro Alves  <palves@redhat.com>
8925
8926         * linux-nat.c: Include scope-exit.h.
8927         (cleanup_target_stop): Remove.
8928         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8929         SCOPE_EXIT.
8930
8931 2019-01-23  Tom Tromey  <tom@tromey.com>
8932             Pedro Alves  <palves@redhat.com>
8933
8934         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8935         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8936
8937 2019-01-23  Tom Tromey  <tom@tromey.com>
8938             Andrew Burgess  <andrew.burgess@embecosm.com>
8939             Pedro Alves  <palves@redhat.com>
8940
8941         * infrun.c (fetch_inferior_event): Use scope_exit.
8942         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8943         * top.c (execute_command): Use scope_exit.
8944         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8945         * utils.c (do_bpstat_clear_actions_cleanup)
8946         (make_bpstat_clear_actions_cleanup): Remove.
8947
8948 2019-01-23  Tom Tromey  <tom@tromey.com>
8949             Pedro Alves  <palves@redhat.com>
8950
8951         * infrun.c: Include "common/scope-exit.h"
8952         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8953         (wait_for_inferior): Use SCOPE_EXIT.
8954         (fetch_inferior_event): Use scope_exit.
8955
8956 2019-01-23  Tom Tromey  <tom@tromey.com>
8957             Pedro Alves  <palves@redhat.com>
8958
8959         * breakpoint.c (create_breakpoint): Remove cleanup.
8960
8961 2019-01-23  Tom Tromey  <tom@tromey.com>
8962             Andrew Burgess  <andrew.burgess@embecosm.com>
8963             Pedro Alves  <palves@redhat.com>
8964
8965 2019-01-23  Pedro Alves  <palves@redhat.com>
8966
8967         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8968
8969 2019-01-23  Pedro Alves  <palves@redhat.com>
8970             Andrew Burgess  <andrew.burgess@embecosm.com>
8971
8972         * gdbthread.h: Include "common/forward-scope-exit.h".
8973         (scoped_finish_thread_state): Redefine custom class in terms of
8974         forward_scope_exit.
8975
8976 2019-01-23  Pedro Alves  <palves@redhat.com>
8977             Andrew Burgess  <andrew.burgess@embecosm.com>
8978
8979         * common/forward-scope-exit.h: New file.
8980
8981 2019-01-23  Pedro Alves  <palves@redhat.com>
8982             Andrew Burgess  <andrew.burgess@embecosm.com>
8983             Tom Tromey  <tom@tromey.com>
8984
8985         * common/scope-exit.h: New file.
8986
8987 2019-01-23  Pedro Alves  <palves@redhat.com>
8988
8989         * common/preprocessor.h (ESC): Rename to ...
8990         (ESC_PARENS): ... this.
8991         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8992         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8993
8994 2019-01-23  Tom Tromey  <tom@tromey.com>
8995
8996         * language.h (class scoped_switch_to_sym_language_if_auto):
8997         Initialize m_lang in both cases.
8998
8999 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9000
9001         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9002         with XCNEW.
9003
9004 2019-01-22  Tom Tromey  <tom@tromey.com>
9005
9006         * corelow.c: Do not include sys/file.h.
9007
9008 2019-01-22  Tom Tromey  <tom@tromey.com>
9009
9010         * tui/tui-wingeneral.h: Include gdb_curses.h.
9011
9012 2019-01-22  Tom Tromey  <tom@tromey.com>
9013
9014         * source-cache.h (class source_cache) <get_source_lines,
9015         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9016
9017 2019-01-22  Tom Tromey  <tom@tromey.com>
9018
9019         * remote-fileio.h (struct remote_target): Declare.
9020
9021 2019-01-22  Tom Tromey  <tom@tromey.com>
9022
9023         * python/py-arch.c: Do not include py-ref.h.
9024         * python/py-bpevent.c: Do not include py-ref.h.
9025         * python/py-cmd.c: Do not include py-ref.h.
9026         * python/py-continueevent.c: Do not include py-ref.h.
9027         * python/py-event.h: Do not include py-ref.h.
9028         * python/py-evtregistry.c: Do not include py-ref.h.
9029         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9030         * python/py-frame.c: Do not include py-ref.h.
9031         * python/py-framefilter.c: Do not include py-ref.h.
9032         * python/py-function.c: Do not include py-ref.h.
9033         * python/py-infevents.c: Do not include py-ref.h.
9034         * python/py-linetable.c: Do not include py-ref.h.
9035         * python/py-objfile.c: Do not include py-ref.h.
9036         * python/py-param.c: Do not include py-ref.h.
9037         * python/py-prettyprint.c: Do not include py-ref.h.
9038         * python/py-progspace.c: Do not include py-ref.h.
9039         * python/py-symbol.c: Do not include py-ref.h.
9040         * python/py-symtab.c: Do not include py-ref.h.
9041         * python/py-type.c: Do not include py-ref.h.
9042         * python/py-unwind.c: Do not include py-ref.h.
9043         * python/py-utils.c: Do not include py-ref.h.
9044         * python/py-value.c: Do not include py-ref.h.
9045         * python/py-varobj.c: Do not include py-ref.h.
9046         * python/py-xmethods.c: Do not include py-ref.h.
9047         * python/python.c: Do not include py-ref.h.
9048         * varobj.c: Do not include py-ref.h.
9049
9050 2019-01-22  Tom Tromey  <tom@tromey.com>
9051
9052         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9053         keyword for bcache.
9054
9055 2019-01-22  Tom Tromey  <tom@tromey.com>
9056
9057         * compile/compile-cplus-types.c: Remove a comment by #include.
9058
9059 2019-01-22  Tom Tromey  <tom@tromey.com>
9060
9061         * compile/gcc-c-plugin.h: Include compile-internal.h.
9062
9063 2019-01-22  Tom Tromey  <tom@tromey.com>
9064
9065         * stabsread.c (EXTERN): Do not define.
9066         (symnum, next_symbol_text_func, processing_gcc_compilation)
9067         (within_function, global_sym_chain, global_stabs)
9068         (previous_stab_code, this_object_header_files)
9069         (n_this_object_header_files)
9070         (n_allocated_this_object_header_files): Define.
9071         * stabsread.h (EXTERN): Never define.  Use "extern".
9072
9073 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9074
9075         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9076         history_value.
9077
9078 2019-01-21  Tom Tromey  <tom@tromey.com>
9079
9080         * ui-out.c: Fix includes.
9081         * tui/tui-source.c: Fix includes.
9082         * target.c: Fix includes.
9083         * remote.c: Fix includes.
9084         * regcache.c: Fix includes.
9085         * python/py-block.c: Fix includes.
9086         * printcmd.c: Fix includes.
9087         * or1k-tdep.c: Fix includes.
9088         * mi/mi-main.c: Fix includes.
9089         * m32r-tdep.c: Fix includes.
9090         * csky-tdep.c: Fix includes.
9091         * compile/compile-cplus-types.c: Fix includes.
9092         * cli/cli-interp.c: Fix includes.
9093
9094 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9095
9096         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9097         for padding.
9098
9099 2019-01-16  Tom Tromey  <tom@tromey.com>
9100
9101         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9102         earlier.
9103         (struct objfile) <msymbols_range>: Move from top level.
9104         <msymbols>: New method.
9105         (class objfile_msymbols): Remove.
9106         * symtab.c (default_collect_symbol_completion_matches_break_on):
9107         Update.
9108         * symmisc.c (dump_msymbols): Update.
9109         * stabsread.c (scan_file_globals): Update.
9110         * objc-lang.c (info_selectors_command, info_classes_command)
9111         (find_methods): Update.
9112         * minsyms.c (find_solib_trampoline_target): Update.
9113         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9114         * coffread.c (coff_symfile_read): Update.
9115         * ada-lang.c (ada_lookup_simple_minsym)
9116         (ada_collect_symbol_completion_matches): Update.
9117
9118 2019-01-16  Tom Tromey  <tom@tromey.com>
9119
9120         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9121         type.  Remove no-argument constructor.
9122         <iterator::operator++>: Simplify.
9123         <begin>: Update.
9124         <end>: Use minimal_symbol_count.
9125
9126 2019-01-16  Tom Tromey  <tom@tromey.com>
9127
9128         * objfiles.h (struct objfile) <psymtabs>: New method.
9129         (class objfile_psymtabs): Remove.
9130         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9131         typedef.
9132         <range>: New method.
9133         (require_partial_symbols): Change return type.
9134         * psymtab.c (require_partial_symbols)
9135         (psym_expand_symtabs_matching): Update.
9136         * mdebugread.c (parse_partial_symbols): Update.
9137         * dbxread.c (dbx_end_psymtab): Update.
9138
9139 2019-01-15  Tom Tromey  <tom@tromey.com>
9140
9141         * symtab.c (lookup_objfile_from_block)
9142         (lookup_symbol_in_objfile_symtabs)
9143         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9144         (find_line_symtab, info_sources_command)
9145         (default_collect_symbol_completion_matches_break_on)
9146         (make_source_files_completion_list): Update.
9147         * symmisc.c (print_objfile_statistics, dump_objfile)
9148         (maintenance_print_symbols, maintenance_info_symtabs)
9149         (maintenance_check_symtabs, maintenance_info_line_tables):
9150         Update.
9151         * source.c (select_source_symtab)
9152         (forget_cached_source_info_for_objfile): Update.
9153         * objfiles.h (class objfile_compunits): Remove.
9154         (struct objfile) <compunits_range>: New typedef.
9155         (compunits): New method.
9156         * objfiles.c (objfile_relocate1): Update.
9157         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9158         * maint.c (count_symtabs_and_blocks): Update.
9159         * linespec.c (iterate_over_all_matching_symtabs): Update.
9160         * cp-support.c (add_symbol_overload_list_qualified): Update.
9161         * coffread.c (coff_symtab_read): Update.
9162         * ada-lang.c (add_nonlocal_symbols)
9163         (ada_collect_symbol_completion_matches)
9164         (ada_add_global_exceptions): Update.
9165
9166 2019-01-15  Tom Tromey  <tom@tromey.com>
9167
9168         * progspace.h (program_space) <objfiles_safe_range>: New
9169         typedef.
9170         <objfiles_safe>: New method.
9171         * objfiles.h (class all_objfiles_safe): Remove.
9172         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9173         * jit.c (jit_inferior_exit_hook): Update.
9174
9175 2019-01-17  Tom Tromey  <tom@tromey.com>
9176
9177         * progspace.h (program_space) <objfiles_range>: New typedef.
9178         <objfiles>: New method.
9179         <objfiles_head>: Rename from objfiles.
9180         (object_files): Update.
9181         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9182         * guile/scm-pretty-print.c
9183         (ppscm_find_pretty_printer_from_objfiles): Update.
9184         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9185         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9186         Update.
9187         * python/py-progspace.c (pspy_get_objfiles): Update.
9188         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9189         Update.
9190         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9191         (objfpy_lookup_objfile_by_build_id): Update.
9192         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9193         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9194         Update.
9195         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9196         (expand_symtab_containing_pc, lookup_objfile_from_block)
9197         (lookup_static_symbol, basic_lookup_transparent_type)
9198         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9199         (find_line_symtab, info_sources_command)
9200         (default_collect_symbol_completion_matches_break_on)
9201         (make_source_files_completion_list, find_main_name): Update.
9202         * symmisc.c (print_symbol_bcache_statistics)
9203         (print_objfile_statistics, maintenance_print_symbols)
9204         (maintenance_print_msymbols, maintenance_print_objfiles)
9205         (maintenance_info_symtabs, maintenance_check_symtabs)
9206         (maintenance_expand_symtabs, maintenance_info_line_tables):
9207         Update.
9208         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9209         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9210         (map_overlay_command, unmap_overlay_command)
9211         (simple_overlay_update, expand_symtabs_matching)
9212         (map_symbol_filenames): Update.
9213         * symfile-debug.c (set_debug_symfile): Update.
9214         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9215         Update.
9216         * source.c (select_source_symtab, forget_cached_source_info):
9217         Update.
9218         * solib.c (solib_read_symbols): Update.
9219         * solib-spu.c (append_ocl_sos): Update.
9220         * psymtab.c (maintenance_print_psymbols)
9221         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9222         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9223         * printcmd.c (info_symbol_command): Update.
9224         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9225         Update.
9226         * objfiles.h (class all_objfiles): Remove.
9227         * objfiles.c (have_partial_symbols, have_full_symbols)
9228         (have_minimal_symbols, qsort_cmp, update_section_map)
9229         (shared_objfile_contains_address_p)
9230         (default_iterate_over_objfiles_in_search_order): Update.
9231         * objc-lang.c (info_selectors_command, info_classes_command)
9232         (find_methods): Update.
9233         * minsyms.c (find_solib_trampoline_target): Update.
9234         * maint.c (maintenance_info_sections)
9235         (maintenance_translate_address, count_symtabs_and_blocks):
9236         Update.
9237         * main.c (captured_main_1): Update.
9238         * linux-thread-db.c (try_thread_db_load_from_pdir)
9239         (has_libpthread): Update.
9240         * linespec.c (iterate_over_all_matching_symtabs)
9241         (search_minsyms_for_name): Update.
9242         * jit.c (jit_find_objf_with_entry_addr): Update.
9243         * hppa-tdep.c (find_unwind_entry)
9244         (hppa_lookup_stub_minimal_symbol): Update.
9245         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9246         Update.
9247         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9248         (elf_gnu_ifunc_resolve_by_got): Update.
9249         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9250         * dwarf-index-write.c (save_gdb_index_command): Update.
9251         * cp-support.c (add_symbol_overload_list_qualified): Update.
9252         * breakpoint.c (create_overlay_event_breakpoint)
9253         (create_longjmp_master_breakpoint)
9254         (create_std_terminate_master_breakpoint)
9255         (create_exception_master_breakpoint): Update.
9256         * blockframe.c (find_pc_partial_function): Update.
9257         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9258         (ada_collect_symbol_completion_matches)
9259         (ada_add_global_exceptions): Update.
9260
9261 2019-01-17  Tom Tromey  <tom@tromey.com>
9262
9263         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9264         declare VEC.
9265         (solib_target_parse_libraries): Change return type.
9266         (library_list_start_segment, library_list_start_section)
9267         (library_list_end_library, library_list_start_library); Update.
9268         (solib_target_free_library_list): Remove.
9269         (solib_target_parse_libraries): Remove cleanup.  Change return
9270         type.
9271         (solib_target_current_sos): Update.
9272
9273 2019-01-17  Tom Tromey  <tromey@bapiya>
9274
9275         * valprint.c: Replace "the the" with "the".
9276         * symtab.c: Replace "the the" with "the".
9277         * solib.c: Replace "the the" with "the".
9278         * solib-dsbt.c: Replace "the the" with "the".
9279         * linespec.c: Replace "the the" with "the".
9280         * dwarf2loc.h: Replace "the the" with "the".
9281         * amd64-windows-tdep.c: Replace "the the" with "the".
9282         * aarch64-tdep.c: Replace "the the" with "the".
9283
9284 2019-01-16  Keith Seitz  <keiths@redhat.com>
9285
9286         PR gdb/23773
9287         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9288         <builder>: Rename to ..
9289         <m_builder>: ... this and make private.
9290         (dwarf2_cu::get_builder): New method.  Change all users of
9291         `builder' to use this method.
9292         (dwarf2_start_symtab): Move to ...
9293         (dwarf2_cu::start_symtab): ... here.  Update all callers
9294         (setup_type_unit_groups): Move to ...
9295         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9296         callers.
9297         (dwarf2_cu::reset_builder): New method.
9298         (process_full_compunit, process_full_type_unit): Use
9299         dwarf2_cu::reset_builder.
9300         (follow_die_offset): Record the ancestor CU if it is different
9301         from the followed DIE's CU.
9302         (follow_die_sig_1): Likewise.
9303
9304 2019-01-15  Tom Tromey  <tom@tromey.com>
9305
9306         * remote.c (class remote_state) <buf>: Now a char_vector.
9307         <buf_size>: Remove.
9308         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9309         parameter.
9310         (remote_target::getpkt_or_notif_sane_1)
9311         (remote_target::getpkt_sane)
9312         (remote_target::getpkt_or_notif_sane): Likewise.
9313         (class remote_target) <putpkt>: New overload.
9314         (remote_target::read_frame): Change type of "buf_p".  Remove
9315         sizeof_p parameter.
9316         (packet_ok): New overload.
9317         (packet_check_result): New overload.
9318         Update all uses.
9319
9320 2019-01-14  Tom Tromey  <tom@tromey.com>
9321
9322         * remote-notif.c (handle_notification, remote_notif_ack)
9323         (remote_notif_parse): Make "buf" const.
9324         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9325         const.
9326         (remote_notif_parse, remote_notif_ack, handle_notification):
9327         Likewise.
9328         * remote.c (remote_notif_stop_parse): Make "buf" const.
9329         (remote_target::remote_parse_stop_reply): Make "buf" const.
9330         (remote_notif_stop_ack): Make "buf" const.
9331
9332 2019-01-14  Tom Tromey  <tom@tromey.com>
9333
9334         * remote.c (remote_console_output): Make parameter const.
9335
9336 2019-01-14  Tom Tromey  <tom@tromey.com>
9337
9338         * target-debug.h (target_debug_print_signals): Constify.
9339         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9340         * procfs.c (procfs_target::pass_signals): Update.
9341         * linux-nat.c (linux_nat_target::pass_signals): Update.
9342         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9343         * target-delegates.c: Rebuild.
9344         * remote.c (remote_target::program_signals): Update.
9345         (remote_target::pass_signals): Update.
9346         * target.c (target_pass_signals): Constify argument.
9347         (target_program_signals): Likewise.
9348         * target.h (struct target_ops) <pass_signals, program_signals>:
9349         Constify argument.
9350         (target_pass_signals, target_program_signals): Constify argument.
9351
9352 2019-01-14  Tom Tromey  <tom@tromey.com>
9353
9354         PR tui/28819:
9355         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9356
9357 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9358
9359         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9360         field.
9361         * rs6000-tdep.c: Include reggroups.h.
9362         (IS_V_ALIAS_PSEUDOREG): Define.
9363         (rs6000_register_name): Return names for the "vX" aliases.
9364         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9365         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9366         aliases.  Call default_register_reggroup_p for all other
9367         pseudo-registers.
9368         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9369         New functions.
9370         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9371         Handle "vX" aliases.
9372         (v_alias_pseudo_register_collect): New function.
9373         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9374         (rs6000_gdbarch_init): Initialize "vX" aliases as
9375         pseudo-registers.  Restore registration of
9376         rs6000_pseudo_register_reggroup_p with
9377         set_tdesc_pseudo_register_reggroup_p.
9378
9379 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9380
9381         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9382         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9383         set_gdbarch_num_pseudo_regs.
9384
9385 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9386
9387         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9388         Remove arg prefixname, add do_set and do_show.
9389         Add member functions set_list and show_list.
9390         * cli/cli-style.c (class cli_style_option): Update accordingly.
9391         (style_set_list): Move to file scope.
9392         (style_show_list): Likewise.
9393         (set_style): Call help_list.
9394         (show_style): Call cmd_show_list.
9395         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9396         Update to use the new macro.
9397
9398 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9399
9400         * ada-lang.c (_initialize_ada_language): Expand the help text
9401         for the "catch exception" command.
9402
9403 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9404
9405         * symtab.c (matching_obj_sections): Initialize obj,
9406         declare it closer to its usage.
9407
9408 2019-01-10  Tom Tromey  <tom@tromey.com>
9409
9410         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9411         (basic_inf_threads_range): Remove.
9412         (inf_threads_range, inf_non_exited_threads_range)
9413         (safe_inf_threads_range): Use next_adapter.
9414
9415 2019-01-10  Keith Seitz  <keiths@redhat.com>
9416
9417         PR gdb/23712
9418         PR symtab/23010
9419         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9420         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9421
9422 2019-01-10  Keith Seitz  <keiths@redhat.com>
9423
9424         PR gdb/23712
9425         PR symtab/23010
9426         * dictionary.c (pending_to_vector): Remove.
9427         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9428         Remove _1 suffix, replacing functions of the same name.  Update
9429         all callers.
9430         (dict_create_hashed, dict_create_hashed_expandable)
9431         (dict_create_linear, dict_create_linear_expandable, dict_free)
9432         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9433         Make functions static.
9434
9435 2019-01-10  Keith Seitz  <keiths@redhat.com>
9436
9437         PR gdb/23712
9438         PR symtab/23010
9439         * dictionary.h (struct dictionary): Replace declaration with
9440         multidictionary.
9441         (dict_create_hashed, dict_create_hashed_expandable)
9442         (dict_create_linear, dict_create_linear_expandable)
9443         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9444         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9445         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9446         taking multidictionary argument.
9447         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9448         * block.h (struct block) <dict>: Change to multidictionary
9449         and rename `multidict'.
9450         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9451         symmisc.c: Update all dictionary references to multidictionary.
9452
9453 2019-01-10  Keith Seitz  <keiths@redhat.com>
9454
9455         PR gdb/23712
9456         PR symtab/23010
9457         * dictionary.c: Include unordered_map.
9458         (pending_to_vector): New function.
9459         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9460         Rewrite the non-"_1" functions to take vector instead
9461         of linked list.
9462         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9463         "new" _1 versions of the same name.
9464         (multidictionary): Define.
9465         (std::hash<enum language): New definition.
9466         (collate_pending_symbols_by_language, mdict_create_hashed)
9467         (mdict_create_hashed_expandable, mdict_create_linear)
9468         (mdict_create_linear_expandable, mdict_free)
9469         (find_language_dictionary, create_new_language_dictionary)
9470         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9471         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9472         (mdict_size, mdict_empty): New functions.
9473         * dictionary.h (mdict_iterator): Define.
9474
9475 2019-01-10  Pedro Alves  <palves@redhat.com>
9476
9477         * breakpoint.c (read_uploaded_action)
9478         (create_tracepoint_from_upload): Adjust to use
9479         gdb::unique_xmalloc_ptr.
9480         * ctf.c (ctf_write_uploaded_tp):
9481         (SET_ARRAY_FIELD): Use emplace_back.
9482         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9483         * tracefile-tfile.c (tfile_write_uploaded_tp):
9484         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9485         gdb::unique_xmalloc_ptr.
9486         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9487         at_string, cond_string, cmd_strings>: Replace char pointers
9488         with gdb::unique_xmalloc_ptr.
9489
9490 2019-01-10  Pedro Alves  <palves@redhat.com>
9491
9492         * solib-target.c (library_list_start_library): Don't xstrdup name.
9493
9494 2019-01-10  Pedro Alves  <palves@redhat.com>
9495
9496         * mdebugread.c (parse_partial_symbols): Use
9497         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9498
9499 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9500
9501         * linux-fork.c (scoped_switch_fork_info)
9502         <~scoped_switch_fork_info>: Fix incorrect variable name.
9503
9504 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9505
9506         * linux-fork.c (scoped_switch_fork_info)
9507         <scoped_switch_fork_info>: Make explicit.
9508         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9509
9510 2019-01-10  Tom Tromey  <tom@tromey.com>
9511
9512         * objfiles.h (objfile::reset_psymtabs): Update.
9513         * objfiles.c (objfile::objfile): Update.
9514         * psymtab.h (psymtab_storage::obstack): Update.
9515         (psymtab_storage::m_obstack): Use gdb::optional.
9516         (class psymtab_storage): Update comment.  Remove objfile
9517         parameter.
9518         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9519
9520 2019-01-10  Tom Tromey  <tom@tromey.com>
9521
9522         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9523         <free_psymtabs>: Now private.
9524         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9525         (allocate_psymtab): Use new method.
9526
9527 2019-01-10  Tom Tromey  <tom@tromey.com>
9528
9529         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9530         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9531         * mdebugread.c (parse_partial_symbols): Use
9532         allocate_dependencies.
9533         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9534         allocate_dependencies.
9535         (process_psymtab_comp_unit_reader)
9536         (build_type_psymtab_dependencies): Likewise.
9537         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9538
9539 2019-01-10  Tom Tromey  <tom@tromey.com>
9540
9541         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9542         PSYMBOL_SET_LANGUAGE.
9543         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9544
9545 2019-01-10  Tom Tromey  <tom@tromey.com>
9546
9547         * psymtab.h (psymtab_storage::obstack): New method.
9548         <m_obstack>: Rename from obstack; now private.
9549         * psymtab.c (psymtab_storage): Update.
9550         * dwarf2read.c (create_addrmap_from_index)
9551         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9552         Update.
9553
9554 2019-01-10  Tom Tromey  <tom@tromey.com>
9555
9556         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9557         * objfiles.h (objfile::reset_psymtabs): New method.
9558
9559 2019-01-10  Tom Tromey  <tom@tromey.com>
9560
9561         * symmisc.c (print_symbol_bcache_statistics): Update.
9562         (print_objfile_statistics): Update.
9563         * symfile.c (reread_symbols): Update.
9564         * psymtab.h (class psymtab_storage): New.
9565         * psymtab.c (psymtab_storage): New constructor.
9566         (~psymtab_storage): New destructor.
9567         (require_partial_symbols): Update.
9568         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9569         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9570         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9571         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9572         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9573         (start_psymtab_common, end_psymtab_common)
9574         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9575         (allocate_psymtab): Update.
9576         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9577         Update.
9578         (dump_psymtab_addrmap, maintenance_print_psymbols)
9579         (maintenance_check_psymtabs): Update.
9580         (class objfile_psymtabs): Move to objfiles.h.
9581         * psympriv.h (discard_psymtab): Now inline.
9582         (psymtab_discarder::psymtab_discarder): Update.
9583         (psymtab_discarder::~psymtab_discarder): Update.
9584         (ALL_OBJFILE_PSYMTABS): Rewrite.
9585         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9586         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9587         Remove fields.
9588         <partial_symtabs>: New field.
9589         (class objfile_psymtabs): Move from psymtab.h.  Update.
9590         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9591         psymbol_cache.
9592         (objfile::~objfile): Don't destroy psymbol_cache.
9593         * mdebugread.c (parse_partial_symbols): Update.
9594         * dwarf2read.c (create_addrmap_from_index)
9595         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9596         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9597         (add_partial_subprogram, dwarf2_ranges_read): Update.
9598         * dwarf-index-write.c (write_address_map)
9599         (write_one_signatured_type, recursively_write_psymbols)
9600         (class debug_names, class debug_names, write_psymtabs_to_index):
9601         Update.
9602
9603 2019-01-10  Tom Tromey  <tom@tromey.com>
9604
9605         * symtab.h (SYMBOL_SET_NAMES): Update.
9606         (symbol_set_names): Update.
9607         (MSYMBOL_SET_NAMES): Update.
9608         * symtab.c (symbol_set_names): Change argument to be an
9609         objfile_per_bfd_storage.
9610         * psymtab.c (add_psymbol_to_bcache): Update.
9611         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9612
9613 2019-01-10  Tom Tromey  <tom@tromey.com>
9614
9615         * symtab.c (create_demangled_names_hash): Change argument to be an
9616         objfile_per_bfd_storage.
9617         (symbol_set_names): Update.
9618
9619 2019-01-10  Tom Tromey  <tom@tromey.com>
9620
9621         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9622         init_psymbol_list.
9623         * psymtab.c (init_psymbol_list): Do nothing if already called.
9624         * psympriv.h (init_psymbol_list): Add comment.
9625         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9626         init_psymbol_list.
9627         * dbxread.c (dbx_symfile_read): Unconditionally call
9628         init_psymbol_list.
9629
9630 2019-01-10  Tom Tromey  <tom@tromey.com>
9631
9632         * xcoffread.c (scan_xcoff_symtab): Update.
9633         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9634         "where".
9635         * mdebugread.c (parse_partial_symbols)
9636         (handle_psymbol_enumerators): Update.
9637         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9638         * dbxread.c (read_dbx_symtab): Update.
9639         * psympriv.h (psymbol_placement): New enum.
9640         (add_psymbol_to_list): Update.
9641
9642 2019-01-10  Tom Tromey  <tom@tromey.com>
9643
9644         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9645         static_psymbols parameters.
9646         (scan_xcoff_symtab): Update.
9647         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9648         static_psymbols parameters.
9649         * psympriv.h (start_psymtab_common): Update.
9650         * mdebugread.c (parse_partial_symbols): Update.
9651         * dwarf2read.c (create_partial_symtab): Update.
9652         * dbxread.c (read_dbx_symtab): Update.
9653         (start_psymtab): Remove global_psymbols and static_psymbols
9654         parameters.
9655
9656 2019-01-10  Tom Tromey  <tom@tromey.com>
9657
9658         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9659         * psymtab.c (allocate_psymtab): Add comment.
9660         * psympriv.h (allocate_psymtab): Add comment.
9661         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9662         initializations.
9663         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9664
9665 2019-01-10  Tom Tromey  <tom@tromey.com>
9666
9667         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9668         Don't declare.
9669         * mipsread.c: Include mdebugread.h.
9670         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9671         Declare.
9672         * elfread.c: Include mdebugread.h.
9673
9674 2019-01-09  Tom Tromey  <tom@tromey.com>
9675
9676         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9677         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9678         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9679         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9680         (psym_lookup_symbol, psym_find_last_source_symtab)
9681         (psym_forget_cached_source_info, psym_print_stats)
9682         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9683         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9684         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9685         (psym_find_compunit_symtab_by_address)
9686         (maintenance_print_psymbols, maintenance_info_psymtabs)
9687         (maintenance_check_psymtabs): Use ranged for.
9688         * psymtab.h (class objfile_psymtabs): New.
9689         (require_partial_symbols): Return objfile_psymtabs.
9690         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9691
9692 2019-01-09  Tom Tromey  <tom@tromey.com>
9693
9694         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9695         (find_pc_mapped_section, list_overlays_command)
9696         (map_overlay_command, unmap_overlay_command)
9697         (simple_overlay_update): Use all_objfiles.
9698         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9699         * printcmd.c (info_symbol_command): Use all_objfiles.
9700         * objfiles.h (ALL_OBJSECTIONS): Remove.
9701         * maint.c (maintenance_translate_address): Use all_objfiles.
9702         * gcore.c (gcore_create_callback): Use all_objfiles.
9703         (objfile_find_memory_regions): Likewise.
9704
9705 2019-01-09  Tom Tromey  <tom@tromey.com>
9706
9707         * symtab.c (find_line_symtab, info_sources_command)
9708         (make_source_files_completion_list): Use objfile_compunits.
9709         * source.c (select_source_symtab): Use objfile_compunits.
9710         * objfiles.h (struct objfile): Update comment.
9711         (ALL_OBJFILES): Remove.
9712         (ALL_FILETABS): Remove.
9713         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9714         objfile_compunits.
9715
9716 2019-01-09  Tom Tromey  <tom@tromey.com>
9717
9718         * symmisc.c (print_objfile_statistics, dump_objfile)
9719         (maintenance_print_symbols): Use compunit_filetabs.
9720         * source.c (forget_cached_source_info_for_objfile): Use
9721         compunit_filetabs.
9722         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9723         (ALL_FILETABS): Use compunit_filetabs.
9724         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9725         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9726
9727 2019-01-09  Tom Tromey  <tom@tromey.com>
9728
9729         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9730         (compunit_filetabs): New.
9731         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9732         compunit_filetabs.
9733         (info_sources_command, make_source_files_completion_list): Remove
9734         declaration.
9735         * symmisc.c (print_objfile_statistics, dump_objfile)
9736         (maintenance_print_symbols): Remove declaration.
9737         (maintenance_info_symtabs): Use compunit_filetabs.
9738         (maintenance_info_line_tables): Likewise.
9739         * source.c (select_source_symtab): Change local variable name.
9740         (forget_cached_source_info_for_objfile): Remove declaration.
9741         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9742         * objfiles.c (objfile_relocate1): Remove declaration.
9743         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9744         declaration.
9745         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9746         * coffread.c (coff_symtab_read): Remove declaration.
9747         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9748         compunit_filetabs.
9749
9750 2019-01-09  Tom Tromey  <tom@tromey.com>
9751
9752         * symtab.c (lookup_objfile_from_block)
9753         (find_pc_sect_compunit_symtab, search_symbols)
9754         (default_collect_symbol_completion_matches_break_on): Use
9755         objfile_compunits.
9756         * objfiles.h (ALL_COMPUNITS): Remove.
9757         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9758         * cp-support.c (add_symbol_overload_list_qualified): Use
9759         objfile_compunits.
9760         * ada-lang.c (ada_collect_symbol_completion_matches)
9761         (ada_add_global_exceptions): Use objfile_compunits.
9762
9763 2019-01-09  Tom Tromey  <tom@tromey.com>
9764
9765         * source.c (select_source_symtab)
9766         (forget_cached_source_info_for_objfile): Remove declaration.
9767         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9768         declaration.
9769         * maint.c (count_symtabs_and_blocks): Remove declaration.
9770         * cp-support.c (add_symbol_overload_list_qualified): Remove
9771         declaration.
9772         * coffread.c (coff_symtab_read): Remove declaration.
9773         * symtab.c (lookup_symbol_in_objfile_symtabs)
9774         (basic_lookup_transparent_type_1): Use objfile_compunits.
9775         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9776         (info_sources_command, search_symbols)
9777         (default_collect_symbol_completion_matches_break_on)
9778         (make_source_files_completion_list): Remove declaration.
9779         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9780         (ada_collect_symbol_completion_matches)
9781         (ada_add_global_exceptions): Remove declaration.
9782         * linespec.c (iterate_over_all_matching_symtabs): Use
9783         objfile_compunits.
9784         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9785         (class objfile_compunits): New.
9786         (ALL_COMPUNITS): Use objfile_compunits.
9787         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9788         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9789         objfile_compunits.
9790         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9791
9792 2019-01-09  Tom Tromey  <tom@tromey.com>
9793
9794         * symtab.c (search_symbols)
9795         (default_collect_symbol_completion_matches_break_on): Use
9796         objfile_msymbols.
9797         * ada-lang.c (ada_lookup_simple_minsym)
9798         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9799         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9800         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9801         objfile_msymbols.
9802         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9803         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9804         * objc-lang.c (find_methods): Use objfile_msymbols.
9805         (info_selectors_command, info_classes_command): Likewise.
9806         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9807         * objfiles.h (class objfile_msymbols): New.
9808         (ALL_OBJFILE_MSYMBOLS): Remove.
9809         (ALL_MSYMBOLS): Remove.
9810
9811 2019-01-09  Tom Tromey  <tom@tromey.com>
9812
9813         * common/next-iterator.h (next_adapter): Add Iterator template
9814         parameter.
9815         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9816         (class all_objfiles_safe): New.
9817         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9818         * objfiles.c (put_objfile_before): Update comment.
9819         (add_separate_debug_objfile): Likewise.
9820         (free_all_objfiles): Use all_objfiles_safe.
9821         (objfile_purge_solibs): Likewise.
9822
9823 2019-01-09  Tom Tromey  <tom@tromey.com>
9824
9825         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9826         (expand_symtab_containing_pc, lookup_static_symbol)
9827         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9828         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9829         all_objfiles.
9830         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9831         * breakpoint.c (create_overlay_event_breakpoint)
9832         (create_longjmp_master_breakpoint)
9833         (create_std_terminate_master_breakpoint)
9834         (create_exception_master_breakpoint): Use all_objfiles.
9835         * linux-thread-db.c (try_thread_db_load_from_pdir)
9836         (has_libpthread): Use all_objfiles.
9837         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9838         * linespec.c (iterate_over_all_matching_symtabs)
9839         (search_minsyms_for_name): Use all_objfiles.
9840         * maint.c (maintenance_info_sections): Use all_objfiles.
9841         * main.c (captured_main_1): Use all_objfiles.
9842         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9843         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9844         * guile/scm-pretty-print.c
9845         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9846         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9847         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9848         (maintenance_print_msymbols): Use all_objfiles.
9849         * source.c (select_source_symtab): Use all_objfiles.
9850         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9851         * symfile.c (remove_symbol_file_command)
9852         (expand_symtabs_matching, map_symbol_filenames): Use
9853         all_objfiles.
9854         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9855         all_objfiles.
9856         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9857         * objc-lang.c (find_methods): Use all_objfiles.
9858         * objfiles.c (have_partial_symbols, have_full_symbols)
9859         (have_minimal_symbols, qsort_cmp)
9860         (default_iterate_over_objfiles_in_search_order): Use
9861         all_objfiles.
9862         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9863         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9864         (maintenance_check_psymtabs): Use all_objfiles.
9865         (ALL_PSYMTABS): Remove.
9866         * compile/compile-object-run.c (do_module_cleanup): Use
9867         all_objfiles.
9868         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9869         * cp-support.c (add_symbol_overload_list_qualified): Use
9870         all_objfiles.
9871         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9872         Use all_objfiles.
9873         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9874         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9875         all_objfiles.
9876         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9877         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9878         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9879         Uses all_objfiles.
9880         * solib.c (solib_read_symbols): Use all_objfiles
9881
9882 2019-01-09  Tom Tromey  <tom@tromey.com>
9883
9884         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9885         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9886         all_objfiles.
9887         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9888         * symmisc.c (print_symbol_bcache_statistics)
9889         (print_objfile_statistics, maintenance_print_objfiles)
9890         (maintenance_info_symtabs, maintenance_check_symtabs)
9891         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9892         all_objfiles.
9893         * source.c (forget_cached_source_info): Use all_objfiles.
9894         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9895         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9896         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9897         * objfiles.c (update_section_map): Use all_objfiles.
9898         (shared_objfile_contains_address_p): Likewise.
9899         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9900         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9901
9902 2019-01-09  Tom Tromey  <tom@tromey.com>
9903
9904         * common/next-iterator.h: New file.
9905         * objfiles.h (class all_objfiles): New.
9906         (struct objfile_iterator): New.
9907
9908 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9909
9910         * NEWS: Move the description of the changed "frame", "select-frame",
9911          and "info frame" commands to the Changed commands section.
9912
9913 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9914
9915         * gdbtypes.c (check_stub_method_group): Remove handling of old
9916         mangling schemes.
9917         * linespec.c (find_methods): Likewise.
9918         * stabsread.c (read_member_functions): Likewise.
9919         * valops.c (search_struct_method): Likewise.
9920         (value_struct_elt_for_reference): Likewise.
9921         * NEWS: Mention this change.
9922
9923 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9924
9925         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9926         print_source_lines.
9927         * source.c (print_source_lines_base): Update line number check.
9928         (print_source_lines): New function.
9929         (source_lines_range::source_lines_range): New function.
9930         * source.h (class source_lines_range): New class.
9931         (print_source_lines): New declaration.
9932
9933 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9934
9935         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9936
9937 2019-01-08  Tom Tromey  <tom@tromey.com>
9938             Simon Marchi  <simon.marchi@ericsson.com>
9939
9940         PR gdb/24060
9941         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9942         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9943         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9944         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9945         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9946         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9947
9948 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9949
9950         * source.c (select_source_symtab): Move header comment to
9951         declaration in source.h.
9952         (forget_cached_source_info_for_objfile): Likewise.
9953         (forget_cached_source_info): Likewise.
9954         (identify_source_line): Likewise.
9955         * source.h (identify_source_line): Move declaration from symtab.h
9956         and add comment from source.c
9957         (print_source_lines): Likewise.
9958         (forget_cached_source_info_for_objfile): Likewise.
9959         (forget_cached_source_info): Likewise.
9960         (select_source_symtab): Likewise.
9961         (enum print_source_lines_flag): Move definition from symtab.h.
9962         * symtab.h (identify_source_line): Move declaration to source.h.
9963         (print_source_lines): Likewise.
9964         (forget_cached_source_info_for_objfile): Likewise.
9965         (forget_cached_source_info): Likewise.
9966         (select_source_symtab): Likewise.
9967         (enum print_source_lines_flag): Move definition to source.h.
9968         * tui/tui-hooks.c: Add 'source.h' include.
9969
9970 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9971
9972         * source.c (print_source_lines_base): Handle requests to print
9973         reverse line number sequences, and guard against empty lines
9974         string.
9975
9976 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9977
9978         * source.c (print_source_lines_base): Fix skip of '\r' if next
9979         character is '\n'.
9980
9981 2019-01-06  Tom Tromey  <tom@tromey.com>
9982
9983         * c-exp.y (struct c_parse_state) <macro_original_text,
9984         expansion_obstack>: New member.
9985         (macro_original_text, expansion_obstack): Remove globals.
9986         (scan_macro_expansion, scanning_macro_expansion)
9987         (finished_macro_expansion): Update.
9988         (scan_macro_cleanup): Remove.
9989         (yylex, c_parse): Update.
9990
9991 2019-01-06  Tom Tromey  <tom@tromey.com>
9992
9993         * c-exp.y (struct c_parse_state) <strings>: New member.
9994         (operator_stoken): Update.
9995
9996 2019-01-06  Tom Tromey  <tom@tromey.com>
9997
9998         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9999         (union type_stack_elt) <typelist_val>: Now a pointer to
10000         std::vector.
10001         (type_stack_cleanup): Don't declare.
10002         (push_typelist): Update.
10003         * parse.c (pop_typelist): Return a std::vector.
10004         (push_typelist): Take a std::vector.
10005         (follow_types): Update.  Do not free args.
10006         (type_stack_cleanup): Remove.
10007         * c-exp.y (struct c_parse_state): New.
10008         (cpstate): New global.
10009         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10010         (nonempty_typelist): Update.
10011         (func_mod): Create a new vector.
10012         (c_parse): Create a c_parse_state.
10013         (check_parameter_typelist): Do not delete params.
10014         (function_method): Update.  Do not delete type_list.
10015
10016 2019-01-06  Tom Tromey  <tom@tromey.com>
10017
10018         PR gdb/28155:
10019         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10020         check_typedef.
10021         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10022         (print_return_value): Likewise.
10023
10024 2019-01-05  Tom Tromey  <tom@tromey.com>
10025
10026         * contrib/cleanup_check.py: Remove.
10027         * contrib/gcc-with-excheck: Remove.
10028         * contrib/exsummary.py: Remove.
10029         * contrib/excheck.py: Remove.
10030
10031 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10032
10033         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10034         NULL. Initialize tpprev to NULL instead of assigning it
10035         to NULL on the next statement.
10036         * windows-nat.c (windows_delete_thread): Remove check for
10037         main_thread_id before printing thread exit notifications.
10038         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10039         Remove thread ID check against main_thread_id.
10040         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10041         windows_delete_thread.
10042         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10043
10044 2019-01-04  Tom Tromey  <tom@tromey.com>
10045
10046         * compile/compile.c (_initialize_compile): Use upper case for
10047         metasyntactic variables.
10048         * symmisc.c (_initialize_symmisc): Use upper case for
10049         metasyntactic variables.
10050         * psymtab.c (_initialize_psymtab): Use upper case for
10051         metasyntactic variables.
10052         * demangle.c (demangle_command): Use upper case for metasyntactic
10053         variables.
10054         (_initialize_demangler): Likewise.
10055         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10056         variables.
10057
10058 2019-01-03  Tom Tromey  <tom@tromey.com>
10059
10060         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10061
10062 2019-01-03  Tom Tromey  <tom@tromey.com>
10063
10064         * python/py-symtab.c (salpy_str): Update.
10065         (struct salpy_sal_object) <symtab>: Now a PyObject.
10066         (salpy_dealloc): Update.
10067         (del_objfile_sal): Use gdbpy_ref.
10068
10069 2019-01-03  Tom Tromey  <tom@tromey.com>
10070
10071         * python/py-type.c (convert_field): Use new_reference.  Return
10072         gdbpy_ref.
10073         (make_fielditem): Return gdbpy_ref.
10074         (typy_fields): Update.
10075         (typy_getitem): Update.
10076         (field_name): Return gdbpy_ref.  Use new_reference.
10077         (typy_iterator_iternext): Update.
10078
10079 2019-01-03  Tom Tromey  <tom@tromey.com>
10080
10081         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10082
10083 2019-01-03  Tom Tromey  <tom@tromey.com>
10084
10085         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10086         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10087         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10088         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10089         (pspy_set_type_printers): Likewise.
10090         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10091         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10092         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10093         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10094         (objfpy_set_type_printers): Likewise.
10095
10096 2019-01-03  Tom Tromey  <tom@tromey.com>
10097
10098         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10099         (gdbpy_print_stack): Use gdbpy_err_fetch.
10100         * python/python-internal.h (class gdbpy_err_fetch): New class.
10101         (class gdbpy_enter) <m_error_type, m_error_value,
10102         m_error_traceback>: Remove.
10103         <m_error>: New member.
10104         (gdbpy_exception_to_string): Don't declare.
10105         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10106         * python/py-value.c (convert_value_from_python): Use
10107         gdbpy_err_fetch.
10108         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10109         gdbpy_exception_to_string.
10110         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10111         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10112         gdbpy_err_fetch.
10113
10114 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10115
10116         * linux-nat.c (delete_lwp_cleanup): Delete.
10117         (struct lwp_deleter): New struct.
10118         (lwp_info_up): New typedef.
10119         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10120         lwp_info_up.
10121
10122 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10123
10124         * linux-fork.c (class scoped_switch_fork_info): New class.
10125         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10126
10127 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10128
10129         * valops.c (find_overload_match): Remove use of null_cleanup, and
10130         calls to do_cleanups.
10131
10132 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10133
10134         * compile/compile-cplus-types.c
10135         (compile_cplus_instance::decl_name): Handle changes to
10136         cp_func_name.
10137         * cp-support.c (cp_func_name): Update header comment, update
10138         return type.
10139         * cp-support.h (cp_func_name): Update return type in declaration.
10140         * valops.c (find_overload_match): Move temp_func local to top
10141         level of function and change its type.  Use temp_func to hold and
10142         delete temporary string obtained from cp_func_name.
10143
10144 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10145
10146         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10147         gdb::char_vector, remove cleanup, and update uses of `msg`.
10148
10149 2019-01-03  Jim Wilson  <jimw@sifive.com>
10150
10151         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10152
10153 2019-01-02  Tom Tromey  <tom@tromey.com>
10154
10155         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10156         (tdesc_parse_xml): Remove cleanups.
10157         * target-descriptions.h (make_cleanup_free_target_description):
10158         Don't declare.
10159         (target_desc_deleter): New struct.
10160         (target_desc_up): New typedef.
10161         * target-descriptions.c (target_desc_deleter::operator()): Rename
10162         from free_target_description.
10163         (make_cleanup_free_target_description): Remove.
10164
10165 2019-01-02  Tom Tromey  <tom@tromey.com>
10166
10167         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10168         constructor, destructor.
10169         (linespec_parser): Remove typedef.
10170         (~linespec_parser): Rename from linespec_parser_delete.
10171         (linespec_lex_to_end, linespec_complete_label)
10172         (linespec_complete): Update.
10173         (decode_line_full): Remove cleanups.
10174         (decode_line_1): Update.
10175
10176 2019-01-02  Tom Tromey  <tom@tromey.com>
10177
10178         * python/python-internal.h (inferior_to_inferior_object): Change
10179         return type.
10180         * python/py-exitedevent.c (create_exited_event_object): Update.
10181         * python/py-inferior.c (inferior_to_inferior_object): Return
10182         gdbpy_ref.
10183         (python_new_inferior, python_inferior_deleted)
10184         (thread_to_thread_object, delete_thread_object)
10185         (build_inferior_list, gdbpy_selected_inferior): Update.
10186         * python/py-infthread.c (create_thread_object): Update.  Also fail
10187         if inferior_to_inferior_object fails.
10188
10189 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10190
10191         * inferior.h (class inferior) <displaced_step_state>: New field.
10192         * infrun.h (struct displaced_step_state): Move here from
10193         infrun.c.  Initialize fields, add constructor.
10194         <inf>: Remove field.
10195         <reset>: New method.
10196         * infrun.c (struct displaced_step_inferior_state): Move to
10197         infrun.h.
10198         (displaced_step_inferior_states): Remove.
10199         (get_displaced_stepping_state): Adust.
10200         (displaced_step_in_progress_any_inferior): Adjust.
10201         (displaced_step_in_progress_thread): Adjust.
10202         (displaced_step_in_progress): Adjust.
10203         (add_displaced_stepping_state): Remove.
10204         (get_displaced_step_closure_by_addr): Adjust.
10205         (remove_displaced_stepping_state): Remove.
10206         (infrun_inferior_exit): Call displaced_step_state.reset.
10207         (use_displaced_stepping): Don't check for NULL.
10208         (displaced_step_prepare_throw): Call
10209         get_displaced_stepping_state.
10210         (displaced_step_fixup): Don't check for NULL.
10211         (prepare_for_detach): Don't check for NULL.
10212
10213 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10214
10215         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10216          in case of call that did not complete.
10217
10218 2019-01-02  Andrey Utkin  <autkin@undo.io>
10219
10220         * symfile.c (find_separate_debug_file): Fix search of debug files for
10221         remote debuggee.
10222
10223 2019-01-02  Tom Tromey  <tom@tromey.com>
10224
10225         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10226         indentation.
10227         * python/py-frame.c (frapy_older): Remove cast.
10228         (frapy_newer): Likewise.
10229         * python/py-breakpoint.c (local_setattro): Remove cast.
10230         * python/py-arch.c (archpy_name): Remove local variable.
10231         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10232
10233 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10234
10235         * unittests/basic_string_view/element_access/char/empty.cc:
10236         Fix year range in copyright header.
10237
10238 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10239
10240         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10241         Delete.
10242         <operator==>: Update with for removed field.
10243         <hash>: Likewise.
10244         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10245         <isa_features>: ...this.
10246         <abi_features>: New field.
10247         (riscv_isa_flen): Update comment.
10248         (riscv_abi_xlen): New declaration.
10249         (riscv_abi_flen): New declaration.
10250         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10251         isa_features.
10252         (riscv_abi_xlen): New function.
10253         (riscv_isa_flen): Update to get answer from isa_features.
10254         (riscv_abi_flen): New function.
10255         (riscv_has_fp_abi): Update to get answer from abi_features.
10256         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10257         xlen and flen.
10258         (riscv_call_info) <xlen, flen>: Update comment.
10259         (riscv_call_arg_struct): Remove invalid assertions
10260         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10261         is removed.
10262         (riscv_gdbarch_init): Gather isa features and abi features
10263         separately, ensure both match on the gdbarch when reusing an old
10264         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10265         a target with 64-bit float hardware.
10266
10267 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10268
10269         * source.c (search_command_helper): Stop reverse search
10270         when line 1 has been searched.
10271
10272 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10273
10274         * record-full.c (record_full_base_target::close): Rewrite
10275         record_full_core_buf_list free logic.
10276
10277 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10278
10279         * break-catch-syscall.c (print_one_catch_syscall): xfree
10280         the last text.
10281
10282 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10283
10284         * top.c (print_gdb_version): Update Copyright year in version
10285         message.
10286
10287 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10288
10289         Update copyright year range in all GDB files.
10290
10291 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10292
10293         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10294
10295 For older changes see ChangeLog-2018.
10296 \f
10297 Local Variables:
10298 mode: change-log
10299 left-margin: 8
10300 fill-column: 74
10301 version-control: never
10302 coding: utf-8
10303 End:
10304