gdb/ChangeLog

   1 2019-06-22  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
   4         declare.
   5         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
   6
   7 2019-06-22  Tom Tromey  <tom@tromey.com>
   8
   9         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
  10         declare.
  11         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
  12
  13 2019-06-22  Tom de Vries  <tdevries@suse.de>
  14
  15         * dwarf2read.c (create_addrmap_from_aranges)
  16         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
  17         instead of '%zu'.
  18
  19 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
  20
  21         * dwarf2read.h (dwarf2_section_info_def): Remove.
  22         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
  23         * dwarf2read.c (struct dwo_sections) <types>: Change type to
  24         std::vector<dwarf2_section_info>.
  25         (struct dwo_file) <~dwo_file>: Remove.
  26         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
  27         types field.
  28         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
  29         (dwarf2_read_debug_names): Likewise.
  30         (create_debug_types_hash_table): Change parameter type to
  31         array_view, adjust code accordingly.
  32         (dwarf2_locate_dwo_sections): Adjust to std::vector.
  33         (partial_die_info::fixup): Likewise.
  34         (determine_prefix): Likewise.
  35         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
  36
  37 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  38
  39         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
  40         gdb_bfd_ref_ptr.
  41         <~dwo_file>: Remove call to gdb_bfd_unref.
  42         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
  43         gdb_bfd_ref_ptr::get.
  44
  45 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  46
  47         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
  48         type to htab_up.
  49         * dwarf2read.c (struct dwo_file): Initialize fields.
  50         <~dwo_file>: New.
  51         (free_dwo_file): Remove, move content to ~dwo_file.
  52         (struct dwo_file_deleter): Remove.
  53         (dwo_file_up>: Remove custom deleter.
  54         (free_dwo_files): Remove.
  55         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
  56         dwo_files.
  57         (process_skeletonless_type_units): Call unique_ptr::get.
  58         (allocate_dwo_file_hash_table): Add deleter to created hash
  59         table.  Change return type to htab_up.
  60         (lookup_dwo_file_slot): Don't memset dwo_file, call
  61         unique_ptr::get.
  62         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
  63         (create_dwo_unit_in_dwp_v2): Likewise.
  64         (open_and_init_dwo_file): Likewise.
  65         (free_dwo_file_from_slot): Remove.
  66
  67 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  68
  69         * dwarf2read.h (struct dwarf2_section_info) <readin,
  70         is_virtual>: Change type to bool.
  71         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
  72         true instead of 1.
  73
  74 2019-06-19  Tom Tromey  <tom@tromey.com>
  75
  76         * tui/tui-data.h (tui_init_content_element): Don't declare.
  77
  78 2019-06-19  Tom Tromey  <tom@tromey.com>
  79
  80         * tui/tui-data.h (tui_init_win_info): Don't declare.
  81
  82 2019-06-19  Tom de Vries  <tdevries@suse.de>
  83
  84         * dwarf2read.h (abstract_to_concrete): Change type to
  85         std::unordered_map<sect_offset, std::vector<sect_offset>,
  86         gdb::hash_enum<sect_offset>>.
  87
  88 2019-06-19  Tom Tromey  <tromey@adacore.com>
  89
  90         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
  91         EVAL_AVOID_SIDE_EFFECTS specially.
  92
  93 2019-06-19  Tom Tromey  <tromey@adacore.com>
  94
  95         * source-cache.c (highlighter): New global.
  96         (source_cache::get_source_lines): Create a highlighter on demand.
  97
  98 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  99
 100         * defs.h (deprecated_interactive_hook): Delete declaration.
 101         * interps.c (clear_interpreter_hooks): Remove use of
 102         deprecated_interactive_hook.
 103         * top.c (deprecated_interactive_hook): Delete definition.
 104         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 105
 106 2019-06-18  Tom de Vries  <tdevries@suse.de>
 107
 108         PR gdb/24515
 109         * dwarf2read.h (abstract_to_concrete): Change type from
 110         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 111         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 112         * dwarf2read.c (read_variable): Update.
 113         (dwarf2_fetch_die_loc_sect_off): Update.
 114
 115 2019-06-17  Tom de Vries  <tdevries@suse.de>
 116
 117         PR gdb/24617
 118         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 119         accessing parent[parent_len - 1].
 120
 121 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 122
 123         PR gdb/24364
 124         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 125         call dtrace_process_dof with NULL dof.
 126
 127 2019-06-16  Tom de Vries  <tdevries@suse.de>
 128
 129         PR gdb/24445
 130         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 131
 132 2019-06-16  Tom Tromey  <tom@tromey.com>
 133
 134         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 135         (make_all_visible): Use address of member.
 136
 137 2019-06-16  Tom Tromey  <tom@tromey.com>
 138
 139         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 140         (tui_free_window, free_content, free_content_elements): Remove
 141         unnecessary cast.
 142         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 143         cast.
 144         * tui/tui-regs.c (tui_show_register_group)
 145         (tui_display_registers_from, tui_display_reg_element_at_line):
 146         Remove unnecessary cast.
 147
 148 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 149
 150         * linux-nat.c (normal_mask): Delete.
 151         (_initialize_linux_nat): Don't initialise normal_mask.
 152
 153 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 154
 155         PR gdb/24445
 156         * dwarf-index-write.h (write_psymtabs_to_index): Add
 157         dwz_basename parameter.
 158         * dwarf-index-write.c (write_gdbindex): Move file writing to
 159         write_gdbindex_1.  Change return type void.
 160         (assert_file_size): Move up, remove filename parameter.
 161         (write_gdbindex_1): New function.
 162         (write_debug_names): Change return type to void, call
 163         assert_file_size.
 164         (struct index_wip_file): New struct.
 165         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 166         file logic to index_wip_file.  Write index for dwz file if
 167         needed.
 168         (save_gdb_index_command): Pass basename of dwz file, if present.
 169         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 170         build-id of dwz file, if present.
 171         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 172         (dwarf2_get_dwz_file): Likewise.
 173         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 174         (dwarf2_get_dwz_file): Likewise.
 175
 176 2019-06-16  Tom Tromey  <tom@tromey.com>
 177
 178         * coffread.c (process_coff_symbol): Use xstrdup.
 179         * value.c (create_internalvar): Use xstrdup.
 180
 181 2019-06-16  Tom Tromey  <tom@tromey.com>
 182
 183         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 184         * breakpoint.c (stopin_command, stopat_command)
 185         (until_break_command, decode_location_default): Remove unnecessary
 186         cast.
 187         * utils.c (subset_compare): Remove unnecessary cast.
 188         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 189         cast.
 190         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 191         cast.
 192         * infcmd.c (path_command): Remove unnecessary cast.
 193         * coffread.c (decode_type): Remove unnecessary cast.
 194         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 195         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 196         * tui/tui-stack.c (tui_show_locator_content)
 197         (tui_show_frame_info): Remove unnecessary cast.
 198         * tui/tui-win.c (tui_scroll_forward_command)
 199         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 200         (parse_scrolling_args): Remove unnecessary cast.
 201         * tui/tui-data.c (init_win_info, tui_del_window)
 202         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 203         (free_content_elements): Remove unnecessary cast.
 204         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 205         unnecessary cast.
 206         * tui/tui-source.c (tui_set_source_content)
 207         (tui_vertical_source_scroll): Remove unnecessary cast.
 208         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 209         cast.
 210         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 211         * tui/tui-regs.c (tui_display_registers_from)
 212         (tui_display_register): Remove unnecessary cast.
 213         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 214         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 215         (make_visible): Remove unnecessary cast.
 216         * tui/tui-winsource.c (tui_erase_source_content)
 217         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 218         unnecessary cast.
 219         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 220         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 221         * stabsread.c (read_type, read_array_type, read_range_type):
 222         Remove unnecessary cast.
 223         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 224         (parse_symbol, parse_type, upgrade_type, parse_external)
 225         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 226         unnecessary cast.
 227         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 228
 229 2019-06-16  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui-data.c (tui_alloc_generic_win_info)
 232         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 233         checks.
 234
 235 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 236             Andrew Burgess  <andrew.burgess@embecosm.com>
 237
 238         * f-typeprint.c (f_print_type): Don't return early for not
 239         associated or not allocated types.
 240         (f_type_print_varspec_suffix): Add print_rank parameter and print
 241         ranks of array types in case they dangling.
 242         (f_type_print_base): Add print_rank parameter.
 243
 244 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 245
 246         * NEWS: Mention new MI commands.
 247         * break-catch-throw.c (enum exception_event_kind): Move to
 248         breakpoint.h.
 249         (print_mention_exception_catchpoint): Output text as a single
 250         message.
 251         (catch_exception_command_1): Rename to...
 252         (catch_exception_event): ...this, make non-static, update header
 253         command, and change some parameter types.
 254         (catch_catch_command): Update for changes to
 255         catch_exception_command_1.
 256         (catch_throw_command): Likewise.
 257         (catch_rethrow_command): Likewise.
 258         * breakpoint.c (enum exception_event_kind): Delete.
 259         * breakpoint.h (enum exception_event_kind): Moved here from
 260         break-catch-throw.c.
 261         (catch_exception_event): Declare.
 262         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 263         (mi_cmd_catch_throw): New function.
 264         (mi_cmd_catch_rethrow): New function.
 265         (mi_cmd_catch_catch): New function.
 266         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 267         'catch-catch' entries.
 268         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 269         (mi_cmd_catch_rethrow): Declare.
 270         (mi_cmd_catch_catch): Declare.
 271
 272 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 273
 274         * annotate.c (annotate_source_line): Change return type to void,
 275         update implementation to match.
 276         * annotate.h (annotate_source_line): Change return type to void,
 277         update header comment.
 278         * stack.c (print_frame_info): Don't change what frame information
 279         is printed based on whether annotations are on or not.
 280
 281 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 282
 283         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 284         (annotate_source): Make static.
 285         (annotate_source_line): Moved from source.c and renamed from
 286         identify_source_line.  Update the return type.
 287         * annotate.h (annotate_source): Delete declaration.
 288         (annotate_source_line): Declaration moved from source.h, and
 289         renamed from identify_source_line.  Return type updated.
 290         * source.c (identify_source_line): Moved to annotate.c and renamed
 291         to annotate_source_line.
 292         (info_line_command): Remove check of annotation_level.
 293         * source.h (identify_source_line): Move declaration to annotate.h
 294         and rename to annotate_source_line.
 295         * stack.c: Add 'annotate.h' include.
 296         (print_frame_info): Remove check of annotation_level before
 297         calling annotate_source_line.
 298
 299 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 300
 301         * source-cache.c (source_cache::get_plain_source_lines): Use
 302         open_source_file_with_line_charpos instead of just
 303         open_source_file, remove call to find_source_lines.
 304         (source_cache::get_source_lines): Likewise.
 305         * source.c (find_source_lines): Make static.
 306         (get_filename_and_charpos): Renamed into...
 307         (open_source_file_with_line_charpos): ..this along with changes to
 308         return a scoped_fd, and some other minor clean ups.
 309         (identify_source_line): Use open_source_file_with_line_charpos.
 310         (search_command_helper): Use open_source_file_with_line_charpos
 311         instead of just open_source_file, remove call to
 312         find_source_lines.
 313         * source.h (open_source_file_with_line_charpos): Declare new
 314         function.
 315         (find_source_lines): Delete declaration.
 316
 317 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 318
 319         * source.c (get_filename_and_charpos): Remove fullname
 320         parameter.
 321         (identify_source_line): Update call to get_filename_and_charpos.
 322
 323 2019-06-14  Tom Tromey  <tromey@adacore.com>
 324
 325         PR gdb/24502:
 326         * ui-style.h (skip_ansi_escape): Update comment.
 327         * ui-file.h (class no_terminal_escape_file): New class.
 328         * ui-file.c (no_terminal_escape_file::write)
 329         (no_terminal_escape_file::puts): New methods.
 330         * cli/cli-logging.c (handle_redirections): Use
 331         no_terminal_escape_file.
 332
 333 2019-06-14  Tom Tromey  <tromey@adacore.com>
 334
 335         * NEWS: Move convenience variable news above Python news.
 336
 337 2019-06-14  Tom Tromey  <tom@tromey.com>
 338
 339         * gnulib: Move directory to top-level.
 340         * configure.ac: Don't configure gnulib.
 341         * configure: Rebuild.
 342         * common/common-defs.h: Use new path to gnulib.
 343         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 344         (GNULIB_H): Remove.
 345         (INCGNU): Look in new gnulib location.
 346         (HFILES_NO_SRCDIR): Remove gnulib files.
 347         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 348         (generated_files): Remove GNULIB_H.
 349         ($(LIBGNU), all-lib): Remove targets.
 350         (distclean): Don't mention GNULIB_BUILDDIR.
 351         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 352
 353 2019-06-14  Tom Tromey  <tromey@adacore.com>
 354
 355         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 356         Warn if symbol file does not provide any symbols.
 357
 358 2019-06-14  Tom Tromey  <tromey@adacore.com>
 359
 360         * source.c (find_and_open_source): Respect basenames_may_differ.
 361
 362 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 363
 364         * annotate.c (annotate_breakpoints_invalid): Make use of
 365         scoped_restore_terminal_state.
 366         (annotate_frames_invalid): Likewise.
 367
 368 2019-06-14  Tom Tromey  <tromey@adacore.com>
 369
 370         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 371         allow assignment to an internalvar.
 372
 373 2019-06-14  Tom Tromey  <tromey@adacore.com>
 374
 375         * ada-lex.l: Allow "_" in attribute names.
 376
 377 2019-06-14  Tom Tromey  <tromey@adacore.com>
 378
 379         PR gdb/24653:
 380         * regcache.c (registers_changed): Don't call alloca.
 381         * top.c (execute_command): Don't call alloca.
 382
 383 2019-06-13  Pedro Alves  <palves@redhat.com>
 384
 385         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 386         'expression'.  When parsing an expression, error out if there's
 387         junk after "unlimited".
 388         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 389         (do_set_command): Adjust calls to is_unlimited_literal.
 390
 391 2019-06-13  Pedro Alves  <palves@redhat.com>
 392
 393         * compile/compile.c (make_compile_options_def_group): Add braces
 394         around array_view initializer.
 395         * thread.c (make_thread_apply_all_options_def_group)
 396         (make_thread_apply_all_options_def_group): Likewise.
 397
 398 2019-06-13  Pedro Alves  <palves@redhat.com>
 399
 400         * NEWS (New commands): Mention "maint test-options
 401         require-delimiter", "maint test-options unknown-is-error", "maint
 402         test-options unknown-is-operand" and "maint show
 403         test-options-completion-result".
 404         (New command options, command completion): New section.
 405         (Completion improvements): New section.
 406         Mention that you can abbreviate "unlimited".
 407
 408 2019-06-13  Pedro Alves  <palves@redhat.com>
 409
 410         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 411         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 412         * unittests/cli-utils-selftests.c (test_parse_flags)
 413         (test_parse_flags_qcs): Delete.
 414         (test_cli_utils): Don't call deleted functions.
 415
 416 2019-06-13  Pedro Alves  <palves@redhat.com>
 417
 418         * thread.c: Include "cli/cli-option.h".
 419         (tp_array_compar_ascending): Global.
 420         (tp_array_compar): Delete function.
 421         (tp_array_compar_ascending, tp_array_compar_descending): New
 422         functions.
 423         (ascending_option_def, qcs_flag_option_def)
 424         (thr_qcs_flags_option_defs)
 425         (make_thread_apply_all_options_def_group)
 426         (make_thread_apply_options_def_group): New.
 427         (thread_apply_all_command): Use gdb::option::process_options.
 428         (thread_apply_command_completer)
 429         (thread_apply_all_command_completer): New.
 430         (thread_apply_command): Use gdb::option::process_options.
 431         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 432         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 433         to generate help text of "thread apply".  Adjust "taas"'s help.
 434         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 435         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 436
 437 2019-06-13  Pedro Alves  <palves@redhat.com>
 438
 439         * thread.c (thread_apply_command): Check for invalid TID with
 440         isdigit instead of !isalpha.
 441
 442 2019-06-13  Pedro Alves  <palves@redhat.com>
 443
 444         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 445         (validate_flags_qcs): New.
 446         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 447         (validate_flags_qcs): Declare.
 448         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 449         (make_frame_apply_options_def_group): New.
 450         (frame_apply_command_count): Process options with
 451         gdb::option::process_options.
 452         (frame_apply_completer): New.
 453         (frame_apply_level_completer, frame_apply_all_completer)
 454         (frame_apply_completer): New.
 455         (_initialize_stack): Update help of "frame apply", "frame apply
 456         level", "frame apply all" and "faas" to mention supported options
 457         and install command completers.
 458         * stack.h (frame_apply_all_completer): Declare.
 459         * thread.c: Include "stack.h".
 460         (tfaas_command): Add "--".
 461         (_initialize_thread): Update help "tfaas" to mention supported
 462         options and install command completer.
 463
 464 2019-06-13  Pedro Alves  <palves@redhat.com>
 465
 466         * completer.c (complete_nested_command_line): New.
 467         (gdb_completion_word_break_characters_throw): Add assertion.
 468         * completer.h (complete_nested_command_line): Declare.
 469
 470 2019-06-13  Pedro Alves  <palves@redhat.com>
 471
 472         * stack.c (parse_backtrace_qualifiers): New.
 473         (backtrace_command): Use it.
 474         (backtrace_command_completer): Complete on qualifiers.
 475
 476 2019-06-13  Pedro Alves  <palves@redhat.com>
 477
 478         * frame.c: Include "cli/cli-option.h.
 479         (user_set_backtrace_options): New.
 480         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 481         Delete.
 482         (get_prev_frame): Adjust.
 483         (boolean_option_def, uinteger_option_def)
 484         (set_backtrace_option_defs): New.
 485         (_initialize_frame): Adjust and use
 486         gdb::option::add_setshow_cmds_for_options to install "set
 487         backtrace past-main" and "set backtrace past-entry".
 488         * frame.h: Include "cli/cli-option.h".
 489         (struct frame_print_options): Forward declare.
 490         (print_frame_arguments_all, print_frame_arguments_scalars)
 491         (print_frame_arguments_none): Declare.
 492         (print_entry_values): Delete declaration.
 493         (struct frame_print_options, user_frame_print_options): New.
 494         (struct set_backtrace_options): New.
 495         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 496         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 497         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 498         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 499         (list_args_or_locals): Add frame_print_options parameter.
 500         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 501         * python/py-framefilter.c (enumerate_args): Pass down
 502         USER_FRAME_PRINT_OPTIONS.
 503         * stack.c: Include "cli/cli-option.h".
 504         (print_frame_arguments_all, print_frame_arguments_scalars)
 505         (print_frame_arguments_none): Declare.
 506         (print_raw_frame_arguments, print_entry_values): Delete.
 507         (user_frame_print_options): New.
 508         (boolean_option_def, enum_option_def, frame_print_option_defs):
 509         New.
 510         (struct backtrace_cmd_options): New.
 511         (bt_flag_option_def): New.
 512         (backtrace_command_option_defs): New.
 513         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 514         (print_frame_arg, read_frame_arg, print_frame_args)
 515         (print_frame_info, print_frame): Add frame_print_options parameter
 516         and use it.
 517         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 518         (backtrace_command_1): Add frame_print_options and
 519         backtrace_cmd_options parameters and use them.
 520         (make_backtrace_options_def_group): New.
 521         (backtrace_command): Process command options with
 522         gdb::option::process_options.
 523         (backtrace_command_completer): New.
 524         (_initialize_stack): Extend "backtrace"'s help to mention
 525         supported options.  Install completer for "backtrace".
 526         Install some settings commands with add_setshow_cmds_for_options.
 527
 528 2019-06-13  Pedro Alves  <palves@redhat.com>
 529
 530         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 531         and that "set/show print raw frame-arguments" are now deprecated.
 532
 533         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 534         command.
 535         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 536         * stack.c (_initialize_stack): Install "set/show print
 537         raw-frame-arguments", and deprecate "set/show print raw
 538         frame-arguments".
 539         * valprint.c (_initialize_valprint): Deprecate "set/show print
 540         raw".
 541
 542 2019-06-13  Pedro Alves  <palves@redhat.com>
 543
 544         * compile/compile.c (struct compile_options): New.
 545         (compile_flag_option_def, compile_command_option_defs)
 546         (make_compile_options_def_group): New.
 547         (compile_file_command): Handle options with
 548         gdb::option::process_options.
 549         (compile_file_command_completer): New function.
 550         (compile_code_command): Handle options with
 551         gdb::option::process_options.
 552         (compile_code_command_completer): New function.
 553         (_initialize_compiler): Install completers for "compile code" and
 554         "compile file".  Mention available options in "compile code" and
 555         "compile code"'s help.
 556         * completer.c (advance_to_completion_word): New, factored out from
 557         ...
 558         (advance_to_expression_complete_word_point): ... this.
 559         (advance_to_filename_complete_word_point): New.
 560         * completer.h (advance_to_filename_complete_word_point): New
 561         declaration.
 562
 563 2019-06-13  Pedro Alves  <palves@redhat.com>
 564
 565         * compile/compile.c: Include "cli/cli-option.h".
 566         (compile_print_value): Scope data pointer is now a
 567         value_print_options pointer; adjust.
 568         (compile_print_command): Process options.  Scope data pointer is
 569         now a value_print_options pointer; adjust.
 570         (_initialize_compile): Update "compile print"'s help to include
 571         supported options.  Install a completer for "compile print".
 572         * cp-valprint.c (show_vtblprint, show_objectprint)
 573         (show_static_field_print): Delete.
 574         (_initialize_cp_valprint): Don't install "set print
 575         static-members", "set print vtbl", "set print object" here.
 576         * printcmd.c: Include "cli/cli-option.h" and
 577         "common/gdb_optional.h".
 578         (print_command_parse_format): Rework to fill in a
 579         value_print_options instead of a format_data.
 580         (print_value): Change parameter type from format_data pointer to
 581         value_print_options reference.  Adjust.
 582         (print_command_1): Process options.  Adjust to pass down a
 583         value_print_options.
 584         (print_command_completer): New.
 585         (_initialize_printcmd): Install print_command_completer as
 586         handle_brkchars completer for the "print" command.  Update
 587         "print"'s help to include supported options.
 588         * valprint.c: Include "cli/cli-option.h".
 589         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 590         here from cp-valprint.c.
 591         (boolean_option_def, uinteger_option_def)
 592         (value_print_option_defs, make_value_print_options_def_group):
 593         New.  Use gdb::option::add_setshow_cmds_for_options to install
 594         "set print elements", "set print null-stop", "set print repeats",
 595         "set print pretty", "set print union", "set print array", "set
 596         print address", "set print symbol", "set print array-indexes".
 597         * valprint.h: Include <string> and "cli/cli-option.h".
 598         (make_value_print_options_def_group): Declare.
 599         (print_value): Change parameter type from format_data pointer to
 600         value_print_options reference.
 601         (print_command_completer): Declare.
 602
 603 2019-06-13  Pedro Alves  <palves@redhat.com>
 604
 605         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 606         (COMMON_SFILES): Add maint-test-settings.c.
 607         * cli/cli-decode.c (boolean_enums): New global, factored out from
 608         ...
 609         (add_setshow_boolean_cmd): ... here.
 610         * cli/cli-decode.h (boolean_enums): Declare.
 611         * cli/cli-option.c: New file.
 612         * cli/cli-option.h: New file.
 613         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 614         factored out from ...
 615         (parse_cli_boolean_value(const char *)): ... this.
 616         (is_unlimited_literal): Change parameter type to pointer to
 617         pointer.  Adjust and advance ARG pointer.
 618         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 619         (parse_cli_var_enum): New, factored out from ...
 620         (do_set_command): ... this.  Adjust.
 621         * cli/cli-setshow.h (parse_cli_boolean_value)
 622         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 623         (parse_cli_var_enum): Declare.
 624         * cli/cli-utils.c: Include "cli/cli-option.h".
 625         (get_ulongest): New.
 626         * cli/cli-utils.h (get_ulongest): Declare.
 627         (check_for_argument): New overloads.
 628         * maint-test-options.c: New file.
 629
 630 2019-06-13  Pedro Alves  <palves@redhat.com>
 631
 632         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 633         parse a range if "-" is at the end of the string.
 634
 635 2019-06-13  Pedro Alves  <palves@redhat.com>
 636
 637         * cli/cli-setshow.c (parse_auto_binary_operation)
 638         (parse_cli_boolean_value): Don't allow "o".
 639
 640 2019-06-13  Pedro Alves  <palves@redhat.com>
 641
 642         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 643         * NEWS: Mention maint test-settings KIND.
 644         * maint-test-settings.c: New file.
 645
 646 2019-06-13  Pedro Alves  <palves@redhat.com>
 647
 648         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 649         completer.
 650         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 651         "set" completers.
 652
 653 2019-06-13  Pedro Alves  <palves@redhat.com>
 654
 655         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 656         after item.
 657
 658 2019-06-13  Pedro Alves  <palves@redhat.com>
 659
 660         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 661
 662 2019-06-13  Pedro Alves <palves@redhat.com>
 663
 664         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 665         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 666         call.
 667         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 668         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 669         calls.
 670         (check_for_argument): Skip spaces after argument.
 671
 672 2019-06-13  Pedro Alves  <palves@redhat.com>
 673
 674         * thread.c (thread_apply_command): Adjust TID parsing.
 675         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 676         detected before end of string.
 677         (tid_is_in_list): Error out if LIST is invalid.
 678
 679 2019-06-13  Pedro Alves  <palves@redhat.com>
 680
 681         * completer.c (complete_line_internal_1): Rewind completion word
 682         point.
 683         (completion_tracker::advance_custom_word_point_by): Change
 684         parameter type to int.
 685         * completer.h (completion_tracker::advance_custom_word_point_by):
 686         Likewise.
 687
 688 2019-06-13  Pedro Alves  <palves@redhat.com>
 689
 690         * completer.c (advance_to_completion_word): Handle delimiters.
 691
 692 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 693
 694         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 695
 696 2019-06-11  Tom Tromey  <tom@tromey.com>
 697
 698         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 699         (xmalloc_failed): Move to alloc.c.
 700         * alloc.c: New file.
 701         * Makefile.in (COMMON_SFILES): Add alloc.c.
 702
 703 2019-06-11  Tom Tromey  <tom@tromey.com>
 704
 705         * nat/linux-waitpid.c: Don't include server.h.
 706         (linux_debug): Remove.
 707         (my_waitpid): Update.
 708
 709 2019-06-11  Tom Tromey  <tromey@adacore.com>
 710
 711         * infcall.c (_initialize_infcall): Remove trailing newline from
 712         help.
 713         * user-regs.c (_initialize_user_regs): Remove trailing newline
 714         from help.
 715         * typeprint.c (_initialize_typeprint): Remove trailing newline
 716         from help.
 717         * reverse.c (_initialize_reverse): Remove trailing newlines from
 718         help.
 719         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 720         from help.
 721         * language.c (add_set_language_command): Remove trailing newline
 722         from help.
 723         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 724         help.
 725         * disasm.c (_initialize_disasm): Remove trailing newline from
 726         help.
 727         * top.c (init_main): Remove trailing newline from help.
 728         * interps.c (_initialize_interpreter): Remove trailing newline
 729         from help.
 730         * btrace.c (_initialize_btrace): Remove trailing newlines from
 731         help.
 732         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 733         from help.
 734         * python/python.c (_initialize_python): Remove trailing newline
 735         from help.
 736         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 737         help.
 738         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 739         from help.  Reformat some text.
 740         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 741         from help.
 742         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 743         newline from help.
 744
 745 2019-06-11  Tom Tromey  <tromey@adacore.com>
 746
 747         * darwin-nat.c (darwin_decode_exception_message)
 748         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 749
 750 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 751
 752         * valops.c (value_slice): Check for not allocated or not
 753         associated values.
 754
 755 2019-06-10  Tom de Vries  <tdevries@suse.de>
 756
 757         PR gdb/24618
 758         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 759         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 760         invalid.
 761
 762 2019-06-10  Tom de Vries  <tdevries@suse.de>
 763
 764         PR gdb/24611
 765         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 766         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 767
 768 2019-06-10  Tom de Vries  <tdevries@suse.de>
 769
 770         PR symtab/24545
 771         * symtab.c (struct demangled_name_entry): Add language field.
 772         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 773         static minimal symbol".  Set and use language field.
 774
 775 2019-06-10  Tom Tromey  <tromey@adacore.com>
 776
 777         * ada-lang.c (_initialize_ada_language): Update help text.
 778
 779 2019-06-10  Tom Tromey  <tromey@adacore.com>
 780
 781         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 782         with a newline.
 783         * guile/guile.c (handle_boot_error): Don't end warning with a
 784         newline.
 785         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 786         warning with a newline.
 787         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 788         newline.
 789         (s12z_frame_cache): Likewise.
 790         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 791         a newline.
 792         * solib-svr4.c (disable_probes_interface): Don't end warning with
 793         a newline.
 794         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 795         newline.
 796         * python/python.c (do_finish_initialization): Don't end warning
 797         with a newline.
 798
 799 2019-06-10  Tom Tromey  <tom@tromey.com>
 800
 801         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 802         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 803         gdbpy_enter.
 804
 805 2019-06-10  Tom Tromey  <tromey@adacore.com>
 806
 807         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 808         data.
 809         (elf_new_init): Don't call stabsread_new_init.
 810         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 811         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 812         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 813
 814 2019-06-10  Tom de Vries  <tdevries@suse.de>
 815
 816         PR symtab/16264
 817         PR symtab/24517
 818         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 819
 820 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 821
 822         * source.c (find_and_open_source): Also rewrite relative file
 823         names.
 824
 825 2019-04-26  Amos Bird  <amosbird@gmail.com>
 826
 827         * annotate.c (annotate_thread_exited): Add "thread-exited"
 828         annotation.
 829
 830 2019-06-06  Tom Tromey  <tromey@adacore.com>
 831
 832         * maint.h (class scoped_command_stats): Use
 833         DISABLE_COPY_AND_ASSIGN.
 834         <print_time>: New method.
 835         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 836         print_time.
 837         (scoped_command_stats::print_time): New method.
 838
 839 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 840
 841         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 842         instructions of lengths 6 or 8 bytes.
 843
 844 2019-06-04  Pedro Alves  <palves@redhat.com>
 845
 846         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 847
 848         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 849         * breakpoint.c (condition_completer): Likewise.
 850         * cli/cli-dump.c (scan_expression): Likewise.
 851         * common/filestuff.c (mkdir_recursive): Likewise.
 852         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 853         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 854         (gdb_abspath): Likewise.
 855         * compile/compile-cplus-types.c
 856         (compile_cplus_instance::decl_name): Likewise.
 857         * completer.c (complete_explicit_location):
 858         (signal_completer, reg_or_group_completer_1): Likewise.
 859         * cp-support.c (cp_remove_params_if_any): Likewise.
 860         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 861         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 862         * infcmd.c (strip_bg_char): Likewise.
 863         * linespec.c (copy_token_string): Likewise.
 864         * mi/mi-main.c (output_cores): Likewise.
 865         * psymtab.c (psymtab_search_name):
 866         * symfile.c (test_set_ext_lang_command): Likewise.
 867         * target.c (target_fileio_read_stralloc): Likewise.
 868         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 869         * value.c (complete_internalvar): Likewise.
 870
 871 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 872
 873         Add objfile property to gdb.Type.
 874         * NEWS: Mention Python API addition.
 875         * python/py-type.c (typy_get_objfile): New method.
 876
 877 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 878
 879         * NEWS: Mention the new set|show style [title|highlight].
 880         Mention changes to "show style", "help" and "apropos".
 881
 882 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 883
 884         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 885         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 886         instead of print_help_for_command.
 887         (print_doc_of_command): New function.
 888         (help_list): Add 'apropos -v word' suggestion.
 889         (print_help_for_command): Style the command name using title style.
 890         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 891         (_initialize_cli_cmds): Describe -v in apropos_command help.
 892
 893 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 894
 895         * cli/cli-style.h (cli_style_option): Add name in constructor,
 896         add m_name class member, add constructor with intensity,
 897         add name class function.
 898         (cli_style_option::add_setshow_commands): Remove name argument.
 899         (highlight_style, title_style): New styles.
 900         * cli/cli-style.c (do_show): New function that shows a style
 901         characteristic styling the style name with itself.
 902         (set_style_name): New function.
 903         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 904         Update all callers according to the changes in cli/cli-style.h.
 905         * utils.h (fputs_highlighted): New function.
 906         * utils.c (fputs_highlighted): Likewise.
 907
 908 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 909
 910         * NEWS: Mention new pipe command and new convenience variables.
 911
 912 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 913
 914         * cli/cli-cmds.c (pipe_command): New function.
 915         (_initialize_cli_cmds): Call add_com for pipe_command.
 916         Define | as an alias for pipe.
 917         (exit_status_set_internal_vars): New function.
 918         (shell_escape): Call exit_status_set_internal_vars.
 919         cli/cli-decode.c (find_command_name_length): Recognize | as
 920         a single character command.
 921
 922 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 923
 924         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 925         top.c (execute_command_to_ui_file): New function, mostly a copy
 926         of execute_command_to_string.
 927         (execute_command_to_string): Implement by calling
 928         execute_command_to_ui_file.
 929
 930 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 931
 932         * top.h (saved_command_line): Remove declaration.
 933         * top.c (previous_saved_command_line, previous_repeat_arguments):
 934         New variables.
 935         (saved_command_line): Make static, define together with other
 936         'repeat variables'.
 937         (dont_repeat): Clear repeat_arguments.
 938         (repeat_previous, get_saved_command_line, save_command_line):
 939         New functions.
 940         (gdb_init): Initialize saved_command_line
 941         and previous_saved_command_line.
 942         * main.c (captured_main_1): Remove saved_command_line initialization.
 943         * event-top.c (handle_line_of_input): Update to use
 944         the new 'repeat' related functions instead of direct access to
 945         saved_command_line.
 946         * command.h (repeat_previous, get_saved_command_line,
 947         save_command_line): New declarations.
 948         (dont_repeat): Add comment.
 949
 950 2019-05-30  Tom Tromey  <tromey@adacore.com>
 951
 952         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 953         Fix comment.
 954         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 955
 956 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 957
 958         PR cli/24587
 959         * completer.c (complete): Initialize variable word.
 960
 961 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 962
 963         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 964         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 965         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 966         'body' is NULL to the outter 'if', protecting the '!is_define'
 967         situation as well.
 968
 969 2019-05-29  Tom Tromey  <tromey@adacore.com>
 970
 971         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 972         (dwarf_unknown): New function.
 973         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 974         (dwarf_type_encoding_name): Use dwarf_unknown.
 975
 976 2019-05-29  Tom Tromey  <tromey@adacore.com>
 977
 978         PR c++/20020:
 979         * cp-valprint.c (cp_print_value_fields): Call
 980         cp_print_static_field inside "try".
 981
 982 2019-05-29  Tom Tromey  <tromey@adacore.com>
 983
 984         * inflow.c (struct terminal_info): Add default operator=.
 985         * configure: Rebuild.
 986         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 987         -Wdeprecated-copy-dtor, -Wredundant-move.
 988
 989 2019-05-29  Tom Tromey  <tromey@adacore.com>
 990
 991         * NEWS: Add entry.
 992         * infcmd.c (print_return_value_1): Handle finish_print
 993         option.
 994         (show_print_finish): New function.
 995         (_initialize_infcmd): Add "set/show print finish" commands.
 996         * valprint.c (user_print_options): Initialize new member.
 997         * valprint.h (struct value_print_options) <finish_print>: New
 998         member.
 999
1000 2019-05-28  Tom Tromey  <tromey@adacore.com>
1001
1002         * ada-lang.c (ada_remove_Xbn_suffix)
1003         (find_old_style_renaming_symbol)
1004         (parse_old_style_renaming): Remove.
1005         (ada_find_renaming_symbol): Don't call
1006         find_old_style_renaming_symbol.
1007         (ada_is_renaming_symbol): Rename from
1008         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1009         bool.  Now static.
1010         (ada_read_var_value): Update and simplify.
1011         * ada-exp.y (write_var_or_type): Remove old code.
1012
1013 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1014
1015         * event-top.c: Remove include comment.
1016         * inflow.c (class scoped_ignore_sigttou): Move from here...
1017         * inflow.h (class scoped_ignore_sigttou): ...to here.
1018         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1019         * top.c:  Remove include comment.
1020
1021 2019-05-27  Tom Tromey  <tom@tromey.com>
1022
1023         * NEWS: Fix typo.
1024
1025 2019-05-22  Tom Tromey  <tromey@adacore.com>
1026
1027         * target.c (target_follow_exec): Constify parameter.
1028         * target-delegates.c: Rebuild.
1029         * remote.c (remote_target::follow_exec): Constify parameter.
1030         * infrun.c (follow_exec): Constify parameter.
1031         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1032         (target_follow_exec): Likewise.
1033
1034 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1035
1036         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1037         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1038
1039 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1040
1041         * NEWS: Add debugredirect and testsuite sections.
1042
1043 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1044
1045         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1046         target descriptions using exclusively floating point register name
1047         aliases.
1048
1049 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1050
1051         PR gdb/18644:
1052         * f-lang.c (build_fortran_types): Handle the case where
1053         gdbarch_floatformat_for_type returns a nullptr.
1054
1055 2019-05-21  Tom de Vries  <tdevries@suse.de>
1056
1057         PR cli/24587
1058         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1059
1060 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1061
1062         PR gdb/18644:
1063         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1064         16-byte floats.
1065         * i386-tdep.c (i386_floatformat_for_type): Use
1066         floatformats_ia64_quad for the 16-byte floating point component
1067         within a fortran 32-byte complex number.
1068
1069 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1070
1071         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1072         delete default constructor.
1073         (find_partial_die): Update to return const struct.
1074         (partial_die_parent_scope): Move variable declaration into scope
1075         of its use and change its type to auto.
1076         (guess_partial_die_structure_name): Likewise.
1077         (partial_die_info::fixup): Likewise.
1078
1079 2019-05-17  Tom Tromey  <tromey@adacore.com>
1080
1081         * source.c (find_and_open_source): Remove cast.
1082
1083 2019-05-17  Tom Tromey  <tromey@adacore.com>
1084
1085         * annotate.c (annotate_source): Make "filename" const.
1086         * annotate.h (annotate_source): Use const.
1087
1088 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1089
1090         * disasm.c (set_disassembler_options): Send errors to stderr.
1091
1092 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1093
1094         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1095         (cli_interp_base::set_logging): Check debug_redirect.
1096         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1097         * cli/cli-logging.c (debug_redirect): Add static variable.
1098         (pop_output_files): Add default param.
1099         (handle_redirections): Print debug setting.
1100         (show_logging_command): Likewise.
1101         (_initialize_cli_logging): Add debugredirect command.
1102         * interps.c (current_interp_set_logging): Add debug_redirect
1103         parameter.
1104         * interps.h (set_logging): Add debug_redirect parameter.
1105         (current_interp_set_logging): Likewise.
1106         * mi/mi-common.h: Likewise.
1107         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1108
1109 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1110             Tom Tromey  <tromey@adacore.com>
1111
1112         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1113         directly.
1114         * cli/cli-interp.h (make_logging_output): Remove declaration.
1115         * cli/cli-logging.c (make_logging_output): Remove function.
1116         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1117         directly.
1118         * ui-file.c (tee_file::tee_file): Remove bools.
1119         (tee_file::~tee_file): Remove deletes.
1120         * ui-file.h (tee_file): Remove bools.
1121
1122 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1123
1124         * mi/mi-cmds.h (mi_cmd_complete): New function.
1125         * mi/mi-main.c (mi_cmd_complete): Likewise.
1126         * mi/mi-cmds.c: Define new MI command -complete.
1127         * NEWS: Mention new -complete command.
1128
1129 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1130
1131         * completer.h (complete): New function.
1132         * completer.c (complete): Likewise.
1133         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1134         function defined in completer.h.
1135
1136 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1137
1138         * MAINTAINERS (Write After Approval): Add myself.
1139
1140 2019-05-17  Tom de Vries  <tdevries@suse.de>
1141
1142         PR gdb/24094
1143         * dwarf2read.c (struct cu_partial_die_info): New struct.
1144         (find_partial_die): Return cu_partial_die_info.
1145         (partial_die_parent_scope, guess_partial_die_structure_name)
1146         (partial_die_info::fixup): Handle new return type of find_partial_die.
1147
1148 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1149
1150         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1151         "std::string", simplifying the algorithm.
1152
1153 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1154
1155         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1156         (stap_static_probe_ops::get_probes): Likewise.
1157
1158 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1159
1160         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1161         '-')" and "else if".
1162         (stap_parse_single_operand): Join checks for
1163         "gdbarch_stap_parse_special_token_p" and
1164         "gdbarch_stap_parse_special_token" in the same "if" statement.
1165         Invert check when verifying for operation on register
1166         displacement.
1167
1168 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1169
1170         * stap-probe.c (stap_get_opcode): Update comment.
1171         (stap_get_expected_argument_type): Likewise.
1172         (handle_stap_probe): Likewise.
1173
1174 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1175
1176         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1177         return type to 'bool'.  Adjust comment.  Use 'bool' when
1178         appropriate.
1179         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1180         * stap-probe.c (stap_parse_argument_1): Likewise.
1181         (stap_is_operator): Likewise.
1182         (stap_is_generic_prefix): Likewise.
1183         (stap_is_register_prefix): Likewise.
1184         (stap_is_register_indirection_prefix): Likewise.
1185         (stap_is_integer_prefix): Likewise.
1186         (stap_generic_check_suffix): Likewise.
1187         (stap_check_integer_suffix): Likewise.
1188         (stap_check_register_suffix): Likewise.
1189         (stap_check_register_indirection_suffix): Likewise.
1190         (stap_parse_register_operand): Likewise.
1191         (stap_parse_single_operand): Likewise.
1192         (stap_parse_argument_1): Likewise.
1193         (stap_probe::get_argument_count): Likewise.
1194         (stap_is_operator): Likewise.
1195
1196 2019-05-16  Tom Tromey  <tromey@adacore.com>
1197
1198         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1199         keyword to foreach.
1200
1201 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1202
1203         * linux-thread-db.c (try_thread_db_load_1): Change return type
1204         to bool.
1205         (try_thread_db_load): Likewise.
1206         (try_thread_db_load_from_pdir_1): Likewise.
1207         (try_thread_db_load_from_pdir): Likewise.
1208         (try_thread_db_load_from_sdir): Likewise.
1209         (try_thread_db_load_from_dir): Likewise.
1210         (thread_db_load_search): Likewise.
1211         (has_libpthread): Likewise.
1212         (thread_db_load): Likewise.
1213
1214 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1215
1216         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1217         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1218         NULL, and complain/return if that's the case.
1219
1220 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1221
1222         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1223         (advance, posn, abstract_read_memory): New functions.
1224         [struct mem_read_abstraction]: New struct.
1225         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1226
1227 2019-05-14  Tom Tromey  <tromey@adacore.com>
1228
1229         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1230         value is not lval_memory.
1231
1232 2019-05-14  Tom Tromey  <tromey@adacore.com>
1233
1234         * solib.c (info_sharedlibrary_command): Style the file name.
1235
1236 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1237
1238         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1239         (aarch64_vnv_type): Likewise.
1240         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1241         * common/tdesc.c: Likewise.
1242         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1243         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1244         * features/aarch64-fpu.xml: Add ieee half view.
1245         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1246         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1247         * gdbtypes.h (struct builtin_type): Likewise.
1248         (struct objfile_type): Likewise.
1249
1250 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1251
1252         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1253         typo.
1254         * location.h (string_to_event_location): Likewise.
1255
1256 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1257
1258         GDB 8.3 released.
1259
1260 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1261
1262         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1263         New variable declaration.
1264         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1265         New variable.
1266         (print_one_breakpoint): Use ui_out::test_flags and new global
1267         variable to compute use_fixed_output.
1268         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1269         Remove.
1270         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1271         (mi_multi_location_breakpoint_output_fixed): Remove.
1272         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1273         new variable.
1274         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1275         fix_multi_location_breakpoint_output flag if version >= 3.
1276         * ui-out.h (enum ui_out_flag)
1277         <fix_multi_location_breakpoint_output>: New enumerator.
1278
1279 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1280
1281         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1282
1283 2019-05-10  Tom Tromey  <tromey@adacore.com>
1284
1285         * ada-lang.c (catch_ada_completer): New function.
1286         (_initialize_ada_language): Use it.
1287
1288 2019-05-10  Tom Tromey  <tromey@adacore.com>
1289
1290         * thread.c (print_thread_info): Make "requested_threads" const.
1291         * gdbthread.h (print_thread_info): Make "requested_threads"
1292         const.
1293         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1294         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1295
1296 2019-05-08  Tom Tromey  <tom@tromey.com>
1297
1298         * gdbtypes.c (objfile_type_data): Change type.
1299         (objfile_type, _initialize_gdbtypes): Update.
1300
1301 2019-05-08  Tom Tromey  <tom@tromey.com>
1302
1303         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1304         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1305         (_initialize_dwarf2_frame): Update.
1306
1307 2019-05-08  Tom Tromey  <tom@tromey.com>
1308
1309         * objc-lang.c (objc_objfile_data): Change type.
1310         (find_methods): Update.
1311         (_initialize_objc_lang): Remove.
1312
1313 2019-05-08  Tom Tromey  <tom@tromey.com>
1314
1315         * stabsread.c (rs6000_builtin_type_data): Change type.
1316         (rs6000_builtin_type, _initialize_stabsread): Update.
1317
1318 2019-05-08  Tom Tromey  <tom@tromey.com>
1319
1320         * mips-tdep.c (mips_pdr_data): Remove.
1321         (_initialize_mips_tdep): Update.
1322
1323 2019-05-08  Tom Tromey  <tom@tromey.com>
1324
1325         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1326         (hppa_init_objfile_priv_data, read_unwind_info)
1327         (find_unwind_entry, _initialize_hppa_tdep): Update.
1328
1329 2019-05-08  Tom Tromey  <tom@tromey.com>
1330
1331         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1332         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1333         on obstack.
1334         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1335
1336 2019-05-08  Tom Tromey  <tom@tromey.com>
1337
1338         * mdebugread.c (basic_type_data): Change type.
1339         (basic_type, _initialize_mdebugread): Update.
1340
1341 2019-05-08  Tom Tromey  <tom@tromey.com>
1342
1343         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1344
1345 2019-05-08  Tom Tromey  <tom@tromey.com>
1346
1347         * nto-tdep.c (nto_inferior_data_reg): Change type.
1348         (nto_inferior_data): Update.
1349         (nto_inferior_data_cleanup, nto_new_inferior_data)
1350         (_initialize_nto_tdep): Remove.
1351         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1352
1353 2019-05-08  Tom Tromey  <tom@tromey.com>
1354
1355         * ada-lang.c (struct ada_inferior_data): Add initializers.
1356         (ada_inferior_data): Change type.
1357         (ada_inferior_data_cleanup): Remove.
1358         (get_ada_inferior_data, ada_inferior_exit)
1359         (struct ada_pspace_data): Add initializers, destructor.
1360         (ada_pspace_data_handle): Change type.
1361         (get_ada_pspace_data): Update.
1362         (ada_pspace_data_cleanup): Remove.
1363
1364 2019-05-08  Tom Tromey  <tom@tromey.com>
1365
1366         * coffread.c (struct coff_symfile_info): Add initializers.
1367         (coff_objfile_data_key): Move lower.  Change type.
1368         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1369         Update.
1370         (coff_free_info): Remove.
1371
1372 2019-05-08  Tom Tromey  <tom@tromey.com>
1373
1374         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1375         (fbsd_pspace_data_handle): Move lower.  Change type.
1376         (get_fbsd_pspace_data): Update.
1377         (fbsd_pspace_data_cleanup): Remove.
1378         (_initialize_fbsd_tdep): Update.
1379
1380 2019-05-08  Tom Tromey  <tom@tromey.com>
1381
1382         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1383         (get_ada_tasks_pspace_data): Update.
1384         (ada_tasks_pspace_data_cleanup): Remove.
1385         (_initialize_tasks): Update.
1386         (ada_tasks_inferior_data_handle): Change type.
1387         (get_ada_tasks_inferior_data): Update.
1388         (ada_tasks_inferior_data_cleanup): Remove.
1389         (struct ada_tasks_pspace_data): Add initializers.
1390
1391 2019-05-08  Tom Tromey  <tom@tromey.com>
1392
1393         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1394         * symfile-debug.c (debug_sym_get_probes): Change type.
1395         * stap-probe.c (handle_stap_probe):
1396         (stap_static_probe_ops::get_probes): Change type.
1397         * probe.h (class static_probe_ops) <get_probes>: Change type.
1398         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1399         (parse_probes_in_pspace): Update.
1400         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1401         Update.
1402         (any_static_probe_ops::get_probes): Change type.
1403         * elfread.c (elfread_data): New typedef.
1404         (probe_key): Change type.
1405         (elf_get_probes): Likewise.  Update.
1406         (probe_key_free): Remove.
1407         (_initialize_elfread): Update.
1408         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1409         Change type.
1410         (dtrace_process_dof_probe, dtrace_process_dof)
1411         (dtrace_static_probe_ops::get_probe): Change type.
1412
1413 2019-05-08  Tom Tromey  <tom@tromey.com>
1414
1415         * xcoffread.c (struct xcoff_symfile_info): Rename from
1416         coff_symfile_info.  Add initializers.
1417         (xcoff_objfile_data_key): Move lower.  Change type.
1418         (XCOFF_DATA): Rewrite.
1419         (xcoff_free_info): Remove.
1420         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1421         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1422         (xcoff_initial_scan): Update.
1423
1424 2019-05-08  Tom Tromey  <tom@tromey.com>
1425
1426         * solib-svr4.c (struct svr4_info): Add initializers and
1427         destructor.
1428         <probes_table>: Now an htab_up.
1429         (solib_svr4_pspace_data): Change type.
1430         (free_probes_table): Simplify.
1431         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1432         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1433         (probes_table_remove_objfile_probes, register_solib_event_probe)
1434         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1435         (_initialize_svr4_solib): Update.
1436
1437 2019-05-08  Tom Tromey  <tom@tromey.com>
1438
1439         * remote.c (remote_pspace_data): Change type.
1440         (remote_pspace_data_cleanup): Remove.
1441         (get_remote_exec_file, set_pspace_remote_exec_file)
1442         (_initialize_remote): Update.
1443
1444 2019-05-08  Tom Tromey  <tom@tromey.com>
1445
1446         * breakpoint.c (breakpoint_objfile_key): Change type.
1447         (get_breakpoint_objfile_data): Update.
1448         (free_breakpoint_objfile_data): Remove.
1449         (_initialize_breakpoint): Update.
1450
1451 2019-05-08  Tom Tromey  <tom@tromey.com>
1452
1453         * linux-tdep.c (struct linux_info): Add initializers.
1454         (linux_inferior_data): Move.  Change type.
1455         (invalidate_linux_cache_inf): Update.
1456         (linux_inferior_data_cleanup): Remove.
1457         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1458
1459 2019-05-08  Tom Tromey  <tom@tromey.com>
1460
1461         * auxv.c (auxv_inferior_data): Move.  Change type.
1462         (auxv_inferior_data_cleanup): Remove.
1463         (invalidate_auxv_cache_inf): Rewrite.
1464         (get_auxv_inferior_data, _initialize_auxv): Update.
1465
1466 2019-05-08  Tom Tromey  <tom@tromey.com>
1467
1468         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1469         (symfile_debug_objfile_data_key): Change type.
1470         (symfile_debug_installed, debug_qf_has_symbols)
1471         (debug_qf_find_last_source_symtab)
1472         (debug_qf_forget_cached_source_info)
1473         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1474         (debug_qf_print_stats, debug_qf_dump)
1475         (debug_qf_expand_symtabs_for_function)
1476         (debug_qf_expand_all_symtabs)
1477         (debug_qf_expand_symtabs_with_fullname)
1478         (debug_qf_map_matching_symbols)
1479         (debug_qf_expand_symtabs_matching)
1480         (debug_qf_find_pc_sect_compunit_symtab)
1481         (debug_qf_map_symbol_filenames)
1482         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1483         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1484         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1485         (debug_sym_read_linetable, debug_sym_relocate): Update.
1486         (symfile_debug_free_objfile): Remove.
1487         (install_symfile_debug_logging, _initialize_symfile_debug):
1488         Update.
1489
1490 2019-05-08  Tom Tromey  <tom@tromey.com>
1491
1492         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1493         allocate_on_obstack.
1494         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1495         (get_dwarf2_per_objfile): Update.
1496         (set_dwarf2_per_objfile): Remove.
1497         (dwarf2_has_info, dwarf2_get_section_info): Update.
1498         (dwarf2_free_objfile): Remove.
1499         (_initialize_dwarf2_read): Update.
1500
1501 2019-05-08  Tom Tromey  <tom@tromey.com>
1502
1503         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1504         initializers.
1505         <unsupported_script_warning_printed,
1506         script_not_found_warning_printed>: Now bool.
1507         (auto_load_pspace_data): Change type.
1508         (~auto_load_pspace_info): Rename from
1509         auto_load_pspace_data_cleanup.
1510         (get_auto_load_pspace_data, init_loaded_scripts_info)
1511         (clear_section_scripts, maybe_print_unsupported_script_warning)
1512         (maybe_print_script_not_found_warning, _initialize_auto_load):
1513         Update.
1514
1515 2019-05-08  Tom Tromey  <tom@tromey.com>
1516
1517         * objfiles.c (objfile_pspace_info): Add destructor and
1518         initializers.
1519         (objfiles_pspace_data): Change type.
1520         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1521         (get_objfile_pspace_data): Update.
1522         (objfiles_bfd_data): Change type.
1523         (get_objfile_bfd_data): Update.
1524         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1525
1526 2019-05-08  Tom Tromey  <tom@tromey.com>
1527
1528         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1529         Change type.
1530         (get_catch_syscall_inferior_data): Update.
1531         (catch_syscall_inferior_data_cleanup): Remove.
1532         (_initialize_break_catch_syscall): Update.
1533
1534 2019-05-08  Tom Tromey  <tom@tromey.com>
1535
1536         * inflow.c (struct terminal_info): Add destructor and
1537         initializers.
1538         (inflow_inferior_data): Change type.
1539         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1540         (get_inflow_inferior_data, inflow_inferior_exit)
1541         (swap_terminal_info, _initialize_inflow): Update.
1542
1543 2019-05-08  Tom Tromey  <tom@tromey.com>
1544
1545         * target-dcache.c (target_dcache_cleanup): Remove.
1546         (target_dcache_aspace_key): Change type.
1547         (target_dcache_init_p, target_dcache_invalidate)
1548         (target_dcache_get, target_dcache_get_or_init)
1549         (_initialize_target_dcache): Update.
1550         * dcache.h (struct dcache_deleter): New.
1551
1552 2019-05-08  Tom Tromey  <tom@tromey.com>
1553
1554         * symtab.c (struct symbol_cache): Add destructor and
1555         initializers.
1556         (symbol_cache_key): Move.  Change type.
1557         (make_symbol_cache, free_symbol_cache): Remove.
1558         (get_symbol_cache): Update.
1559         (symbol_cache_cleanup): Remove.
1560         (ALL_PSPACES, symbol_cache_flush)
1561         (maintenance_print_symbol_cache)
1562         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1563         Update.
1564
1565 2019-05-08  Tom Tromey  <tom@tromey.com>
1566
1567         * symtab.c (struct main_info): Add destructor and initializers.
1568         (main_progspace_key): Move.  Change type.
1569         (get_main_info): Update.
1570         (main_info_cleanup): Remove.
1571         (_initialize_symtab): Update.
1572
1573 2019-05-08  Tom Tromey  <tom@tromey.com>
1574
1575         * registry.h (DECLARE_REGISTRY): Define the _key class.
1576
1577 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1578
1579         * NEWS: Merge two 'New commands' sections.
1580
1581 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1582
1583         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1584         parameter and use Ada language definition instead.
1585         (ada_val_print_ptr): Remove unused language parameter.
1586         (ada_val_print_num): Remove language parameter and use Ada language
1587         definition instead.
1588         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1589         parameter.
1590         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1591         parameter and use Ada language definition instead.
1592         (ada_val_print_1): Update all ada_val_print_xxx calls.
1593         Remove language parameter.
1594         (ada_val_print): Update ada_val_print_1 call.
1595
1596 2019-05-08  Tom Tromey  <tromey@adacore.com>
1597
1598         * remote.c (remote_hw_watchpoint_limit)
1599         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1600         Now static.
1601
1602 2019-05-08  Tom Tromey  <tromey@adacore.com>
1603
1604         * maint.c (_initialize_maint_cmds): Move initialization code to
1605         remote.c.
1606         (watchdog, show_watchdog): Move to remote.c.
1607         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1608         "watchdog" static.
1609         (_initialize_remote): Move initialization code from maint.c.
1610         * defs.h (watchdog): Don't declare.
1611
1612 2019-05-08  Tom Tromey  <tromey@adacore.com>
1613
1614         * tui/tui-interp.c: Include main.h.
1615         * interps.c: Include main.h.
1616         * main.h (interpreter_p): Declare.
1617         * defs.h (interpreter_p): Don't declare.
1618
1619 2019-05-08  Tom Tromey  <tromey@adacore.com>
1620
1621         * dwarf2loc.c: Include dwarf2read.h.
1622         * defs.h (read_unsigned_leb128): Don't declare.
1623         * dwarf2read.h (read_unsigned_leb128): Declare.
1624
1625 2019-05-08  Tom Tromey  <tromey@adacore.com>
1626
1627         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1628         method.
1629
1630 2019-05-08  Tom Tromey  <tromey@adacore.com>
1631
1632         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1633         when no wrap column is set.
1634
1635 2019-05-08  Tom Tromey  <tromey@adacore.com>
1636
1637         * c-lang.c (c_get_string): Handle non-C-style arrays.
1638
1639 2019-05-08  Tom Tromey  <tromey@adacore.com>
1640
1641         * typeprint.c (print_offset_data::update): Print the bit offset,
1642         not the number of bits remaining.
1643
1644 2019-05-08  Tom Tromey  <tromey@adacore.com>
1645
1646         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1647         padding at end of comment.
1648
1649 2019-05-08  Tom Tromey  <tromey@adacore.com>
1650
1651         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1652         Compare main types.
1653
1654 2019-05-06  Tom Tromey  <tom@tromey.com>
1655
1656         * common/scoped_mmap.c: Include common-defs.h.
1657         * common/scoped_mmap.h: Don't include config.h.
1658
1659 2019-05-04  Tom Tromey  <tom@tromey.com>
1660
1661         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1662         (struct aarch64_call_info): Add initializers.
1663         <si>: Now a std::vector.
1664         (pass_on_stack, aarch64_push_dummy_call): Update.
1665
1666 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1667             Tom Tromey  <tom@tromey.com>
1668
1669         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1670         (ppc_threads): Now a std::vector.  Now static.
1671         (hwdebug_find_thread_points_by_tid)
1672         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1673         Update.
1674
1675 2019-05-04  Tom Tromey  <tom@tromey.com>
1676
1677         * arc-tdep.c (arc_tdesc_init): Return bool.
1678
1679 2019-05-04  Tom Tromey  <tom@tromey.com>
1680
1681         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1682         Use gdb_assert_not_reached.
1683
1684 2019-05-04  Tom Tromey  <tom@tromey.com>
1685
1686         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1687         "false".
1688
1689 2019-05-04  Tom Tromey  <tom@tromey.com>
1690
1691         * arc-tdep.c (arc_tdesc_init): Use bool.
1692
1693 2019-05-04  Tom Tromey  <tom@tromey.com>
1694
1695         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1696
1697 2019-05-04  Tom Tromey  <tom@tromey.com>
1698
1699         * cli/cli-cmds.c (valid_command_p): Return bool.
1700
1701 2019-05-04  Tom Tromey  <tom@tromey.com>
1702
1703         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1704         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1705
1706 2019-05-04  Raul Tambre  <raul@tambre.ee>
1707
1708         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1709         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1710         operator for comparison.
1711
1712 2019-05-04  Tom Tromey  <tom@tromey.com>
1713
1714         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1715         (lookup_partial_symbol, print_partial_symbols)
1716         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1717         (psymbol_compare): Update.
1718         (add_psymbol_to_bcache): Clear the entire psymbol.
1719         (maintenance_check_psymtabs): Update.
1720         * psympriv.h (struct partial_symbol): Don't derive from
1721         general_symbol_info.
1722         <obj_section, unrelocated_address, address,
1723         set_unrelocated_address>: Update.
1724         <ginfo>: New member.
1725         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1726         (debug_names::write_psymbols): Update.
1727
1728 2019-05-04  Tom de Vries  <tdevries@suse.de>
1729
1730         * contrib/cc-with-tweaks.sh: Support -n arg.
1731
1732 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1733
1734         * corelow.c (core_target::detach): Ensure frame cache and
1735         register caches are cleared.
1736         inferior.c (exit_inferior_1): Likewise.
1737
1738 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1739             Tom Tromey  <tom@tromey.com>
1740
1741         * dictionary.c (collate_pending_symbols_by_language): Remove
1742         "struct" from foreach.
1743         * symtab.c (lookup_global_symbol_from_objfile)
1744         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1745         foreach.
1746         * ser-tcp.c (net_open): Remove "struct" from foreach.
1747         * objfiles.c (objfile_relocate, objfile_rebase)
1748         (objfile_has_symbols): Remove "struct" from foreach.
1749         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1750         from foreach.
1751         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1752         foreach.
1753         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1754         "struct" from foreach.
1755         * ada-lang.c (create_excep_cond_exprs)
1756         (ada_exception_catchpoint_cond_string): Remove "struct" from
1757         foreach.
1758
1759 2019-05-03  Tom Tromey  <tromey@adacore.com>
1760
1761         * ada-exp.y (convert_char_literal): Check suffix of each
1762         enumerator.
1763
1764 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1765
1766         PR ada/21406:
1767         * ada-exp.y (yywrap): Don't define.
1768         * ada-lex.l (%option): Add noyywrap
1769         (yywrap): Remove.
1770
1771 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1772
1773         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1774         _WIN32_WINNT to the XP level, unless already defined to a higher
1775         level.
1776
1777         * unittests/parse-connection-spec-selftests.c:
1778         * ser-tcp.c:
1779         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1780         override.
1781
1782         * symfile.c (find_separate_debug_file): Remove colon from the
1783         drive spec of DOS/Windows file names of the target, so that the
1784         file name produced from DEBUGDIR and the target's directory will
1785         be valid on DOS/Windows systems.
1786
1787 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1788
1789         * rust-lang.c (val_print_struct): Handle printing structures
1790         containing strings.
1791
1792 2019-05-02  Tom Tromey  <tromey@adacore.com>
1793
1794         * valarith.c (_initialize_valarith): Remove.
1795
1796 2019-05-01  Tom Tromey  <tromey@adacore.com>
1797
1798         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1799         bitfields.
1800
1801 2019-05-01  Tom Tromey  <tromey@adacore.com>
1802
1803         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1804         for big-endian copies.
1805
1806 2019-04-30  Ali Tamur  <tamur@google.com>
1807         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1808         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1809         (read_3_bytes): New function.
1810
1811 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1812
1813         * windows-nat.c (main_thread_id): Delete.
1814         (handle_output_debug_string): Replace main_thread_id by
1815         current_event.dwThreadId.
1816         (fake_create_process): Likewise.
1817         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1818         Do not set main_thread_id.
1819         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1820         current_event.dwThreadId.
1821         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1822
1823 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1824
1825         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1826         Use current_event.dwThreadId instead of main_thread_id.
1827
1828 2019-04-30  Tom Tromey  <tromey@adacore.com>
1829
1830         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1831         (create_excep_cond_exprs): Iterate over program spaces.
1832         (ada_exception_catchpoint_cond_string): Examine all minimal
1833         symbols for exception types.
1834
1835 2019-04-30  Tom Tromey  <tromey@adacore.com>
1836
1837         PR c++/24470:
1838         * dwarf2read.c (process_structure_scope): Handle case where type
1839         has template parameters but no symbol was created.
1840
1841 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1842             Chris January  <chris.january@arm.com>
1843
1844         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1845         qualifier.
1846         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1847
1848 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1849
1850         * f-typeprint.c (f_print_type): Update rules for printing
1851         whitespace.
1852         (f_type_print_varspec_suffix): Likewise.
1853
1854 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1855             Chris January  <chris.january@arm.com>
1856
1857         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1858         function arguments.
1859
1860 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1861
1862         * f-lang.c (build_fortran_types): Change name of void type to
1863         lower case.
1864         * f-typeprint.c (f_type_print_base): Print the name of the void
1865         type, rather than a fixed string.
1866         * f-valprint.c (f_decorations): Use lower case void string.
1867
1868 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1869             Chris January  <chris.january@arm.com>
1870
1871         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1872         types for Fortran.
1873
1874 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1875             Chris January  <chris.january@arm.com>
1876             David Lecomber  <david.lecomber@arm.com>
1877
1878         * f-exp.y (BINOP_INTRINSIC): New token.
1879         (exp): New parser rule handling BINOP_INTRINSIC.
1880         (f77_keywords): Add new builtin procedures.
1881         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1882         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1883         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1884         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1885         (print_unop_subexp_f): New function.
1886         (print_binop_subexp_f): New function.
1887         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1888         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1889         (dump_subexp_body_f): Likewise.
1890         (operator_check_f): Likewise.
1891         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1892         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1893
1894 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1895
1896         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1897         UNOP_KIND.
1898         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1899         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1900         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1901         (operator_length_f): New fuction.
1902         (print_subexp_f): New function.
1903         (op_name_f): New function.
1904         (dump_subexp_body_f): New function.
1905         (operator_check_f): New function.
1906         (exp_descriptor_f): Replace standard expression handling functions
1907         with new functions.
1908         * gdb/fortran-operator.def: New file.
1909         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1910         * gdb/std-operator.def: Remove UNOP_KIND.
1911
1912 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1913
1914         * std-operator.def: Remove unbalanced, stray double quote
1915         character.
1916
1917 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1918             Chris January  <chris.january@arm.com>
1919             Daniel Everett  <daniel.everett@arm.com>
1920             Nick Forrington  <nick.forrington@arm.com>
1921             Richard Bunt  <richard.bunt@arm.com>
1922
1923         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1924         of depth when printing anonymous structs or unions.
1925         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1926         Don't print either the top-level value, or the children if the
1927         max-depth is exceeded.
1928         (ppscm_print_children): When printing the key of a map, allow one
1929         extra level of depth.
1930         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1931         print either the top-level value, or the children if the max-depth
1932         is exceeded.
1933         (print_children): When printing the key of a map, allow one extra
1934         level of depth.
1935         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1936         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1937         (user_print_options): Initialise max_depth field.
1938         (val_print_scalar_or_string_type_p): New function.
1939         (val_print): Check to see if the max depth has been reached.
1940         (val_print_check_max_depth): Define new function.
1941         (show_print_max_depth): New function.
1942         (_initialize_valprint): Add 'print max-depth' option.
1943         * valprint.h (struct value_print_options) <max_depth>: New field.
1944         (val_print_check_max_depth): Declare new function.
1945         * NEWS: Document new feature.
1946
1947 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1948
1949         * ada-lang.c (ada_language_defn): Initialise new field.
1950         * c-lang.c (c_is_string_type_p): New function.
1951         (c_language_defn): Initialise new field.
1952         (cplus_language_defn): Initialise new field.
1953         (asm_language_defn): Initialise new field.
1954         (minimal_language_defn): Initialise new field.
1955         * c-lang.h (c_is_string_type_p): Declare new function.
1956         * d-lang.c (d_language_defn): Initialise new field.
1957         * f-lang.c (f_is_string_type_p): New function.
1958         (f_language_defn): Initialise new field.
1959         * go-lang.c (go_is_string_type_p): New function.
1960         (go_language_defn): Initialise new field.
1961         * language.c (default_is_string_type_p): New function.
1962         (unknown_language_defn): Initialise new field.
1963         (auto_language_defn): Initialise new field.
1964         * language.h (struct language_defn) <la_is_string_type_p>: New
1965         member variable.
1966         (default_is_string_type_p): Declare new function.
1967         * m2-lang.c (m2_language_defn): Initialise new field.
1968         * objc-lang.c (objc_language_defn): Initialise new field.
1969         * opencl-lang.c (opencl_language_defn): Initialise new field.
1970         * p-lang.c (pascal_is_string_type_p): New function.
1971         (pascal_language_defn): Initialise new field.
1972         * rust-lang.c (rust_is_string_type_p): New function.
1973         (rust_language_defn): Initialise new field.
1974
1975 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1976
1977         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1978         New field.
1979         * ada-lang.c (ada_language_defn): Initialise new field.
1980         * c-lang.c (c_language_defn): Likewise.
1981         (cplus_language_defn): Likewise.
1982         (asm_language_defn): Likewise.
1983         (minimal_language_defn): Likewise.
1984         * d-lang.c (d_language_defn): Likewise.
1985         * f-lang.c (f_language_defn): Likewise.
1986         * go-lang.c (go_language_defn): Likewise.
1987         * language.c (unknown_language_defn): Likewise.
1988         (auto_language_defn): Likewise.
1989         * m2-lang.c (m2_language_defn): Likewise.
1990         * objc-lang.c (objc_language_defn): Likewise.
1991         * opencl-lang.c (opencl_language_defn): Likewise.
1992         * p-lang.c (pascal_language_defn): Likewise.
1993         * rust-lang.c (rust_language_defn): Likewise.
1994
1995 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1996
1997         * ada-lang.c (ada_is_character_type): Change return type to bool.
1998         (ada_is_string_type): Likewise.
1999         * ada-lang.h (ada_is_character_type): Update declaration
2000         (ada_is_string_type): Likewise.
2001
2002 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2003
2004         Support style in 'frame|thread apply'
2005
2006         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2007         * record.c (record_start, record_stop): Update callers of
2008         execute_command_to_string with false.
2009         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2010         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2011         methods.
2012         (class string_file): New constructor with term_out parameter.
2013         Override methods term_out and can_emit_style_escape.  New member
2014         term_out.
2015         (class stdio_file): Override can_emit_style_escape.
2016         (class tee_file): Override term_out and can_emit_style_escape.
2017         * utils.h (can_emit_style_escape): Remove.
2018         * utils.c (can_emit_style_escape): Likewise.
2019         Update all callers of can_emit_style_escape (SOMESTREAM) to
2020         SOMESTREAM->can_emit_style_escape.
2021         * source-cache.c (source_cache::get_source_lines): Likewise.
2022         * stack.c (frame_apply_command_count): Call execute_command_to_string
2023         passing the term_out characteristic of the current gdb_stdout.
2024         * thread.c (thr_try_catch_cmd): Likewise.
2025         * top.c (execute_command_to_string): pass term_out parameter
2026         to construct the string_file for the command output.
2027         * ui-file.c (term_cli_styling): New function (most code moved
2028         from utils.c can_emit_style_escape).
2029         (string_file::string_file, string_file::can_emit_style_escape,
2030         stdio_file::can_emit_style_escape, tee_file::term_out,
2031         tee_file::can_emit_style_escape): New functions.
2032
2033 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2034
2035         * NEWS: Mention the new set|show may-call-functions.
2036         * infcall.c (may_call_functions_p): New variable.
2037         (show_may_call_functions_p): New function.
2038         (call_function_by_hand_dummy): Throws an error if not
2039         may-call-functions.
2040         (_initialize_infcall): Call add_setshow_boolean_cmd for
2041         may-call-functions.
2042
2043 2019-04-25  Keith Seitz  <keiths@redhat.com>
2044
2045         PR c++/24367
2046         * cp-support.c (inspect_type): Don't attempt substitutions
2047         of symbol with the same name.
2048
2049 2019-04-25  Tom Tromey  <tromey@adacore.com>
2050
2051         PR gdb/24475:
2052         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2053         static.
2054
2055 2019-04-25  Tom Tromey  <tromey@adacore.com>
2056
2057         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2058         rvalue reference.
2059         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2060         (gdb_xml_parser::parse): Use std::move.
2061         * python/python-internal.h (gdbpy_convert_exception): Take a const
2062         reference.
2063         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2064         std::move.
2065         * python/py-utils.c (gdbpy_convert_exception): Take a const
2066         reference.
2067         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2068         Use std::move.
2069         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2070         Use std::move.
2071         * mi/mi-main.c (mi_print_exception): Take a const reference.
2072         * main.c (handle_command_errors): Take a const reference.
2073         * linespec.c (parse_linespec): Use std::move.
2074         * infcall.c (run_inferior_call): Use std::move.
2075         (call_function_by_hand_dummy): Use std::move.
2076         * exec.c (try_open_exec_file): Use std::move.
2077         * exceptions.h (exception_print, exception_fprintf)
2078         (exception_print_same): Update.
2079         * exceptions.c (print_exception, exception_print)
2080         (exception_fprintf, exception_print_same): Change parameters to
2081         const reference.
2082         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2083         * common/new-op.c: Use std::move.
2084         * common/common-exceptions.h (struct gdb_exception): Add move
2085         constructor.
2086         (struct gdb_exception_error, struct gdb_exception_quit, struct
2087         gdb_quit_bad_alloc): Change constructor to move constructor.
2088         (throw_exception): Change parameter to rvalue reference.
2089         * common/common-exceptions.c (throw_exception): Take rvalue
2090         reference.
2091         * cli/cli-interp.c (safe_execute_command): Use std::move.
2092         * breakpoint.c (insert_bp_location, location_to_sals): Use
2093         std::move.
2094
2095 2019-04-25  Tom Tromey  <tromey@adacore.com>
2096
2097         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2098         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2099         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2100         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2101         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2102         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2103         guile/scm-value.c: Use unpack.
2104         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2105         gdbscm_gdb_exception.
2106         (gdbscm_throw_gdb_exception): Likewise.
2107         (struct gdbscm_gdb_exception): New.
2108         (unpack): New function.
2109         (gdbscm_wrap): Use unpack.
2110
2111 2019-04-25  Tom Tromey  <tromey@adacore.com>
2112
2113         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2114         (gdb_rl_callback_handler): Use std::move.
2115         * common/common-exceptions.h (struct gdb_exception): Add move
2116         assignment operator.
2117         (throw_exception_sjlj): Change "exception" to const reference.
2118         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2119         (throw_exception_sjlj): Change "exception" to const reference.
2120
2121 2019-04-25  Tom Tromey  <tromey@adacore.com>
2122
2123         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2124         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2125         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2126         Update.
2127         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2128         Update.
2129         * mi/mi-interp.c (mi_interp::exec): Update.
2130         * linespec.c (parse_linespec): Update.
2131         * infcall.c (run_inferior_call): Update.
2132         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2133         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2134         (gdbscm_lookup_global_symbol): Update.
2135         * guile/scm-param.c (gdbscm_parameter_value): Update.
2136         * guile/scm-frame.c (gdbscm_frame_read_register)
2137         (gdbscm_frame_read_var): Update.
2138         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2139         * exec.c (try_open_exec_file): Update.
2140         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2141         (gdb_rl_callback_handler): Update.
2142         * common/common-exceptions.h (exception_none): Don't declare.
2143         * common/common-exceptions.c (exception_none): Don't define.
2144         (struct catcher) <exception>: Update.
2145         * cli/cli-interp.c (safe_execute_command): Update.
2146         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2147
2148 2019-04-25  Ali Tamur  <tamur@google.com>
2149
2150         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2151         (read_attribute_value): Likewise.
2152         (dwarf2_read_addr_index): Update comment.
2153         (read_str_index): Add DW_FORM_strx.
2154         (dwarf2_string_attr): Likewise.
2155         (dwarf2_const_value_attr): Likewise.
2156         (dump_die_shallow): Likewise.
2157         (dwarf2_fetch_constant_bytes): Likewise.
2158         (skip_form_bytes): Likewise.
2159         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2160
2161 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2162
2163         PR corefiles/11608
2164         PR corefiles/18187
2165         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2166         OFFSET.  Verify if current mapping contains an ELF header.
2167         (linux_find_memory_regions_full): Adjust call to
2168         dump_mapping_p.
2169
2170 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2171             Kang Li <kanglictf@gmail.com>
2172
2173         PR gdb/21600
2174
2175         * dwarf2-frame.c (read_initial_length): Be consistent about using
2176         unsigned representation of length.
2177         (decode_frame_entry_1): Likewise.  Check for wraparound of
2178         end pointer as well as buffer overflow.
2179
2180 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2181
2182         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2183         "vq".
2184
2185 2019-04-24  Tom Tromey  <tromey@adacore.com>
2186
2187         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2188
2189 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2190
2191         * s12z-tdep.c (s12z_unwind_pc): Delete.
2192         (s12z_unwind_sp): Delete.
2193         (s12z_gdbarch_init): Don't register deleted functions with
2194         gdbarch.
2195
2196 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2197
2198         * rl78-tdep.c (rl78_unwind_sp): Delete.
2199         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2200
2201 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2202
2203         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2204         (xstormy16_unwind_pc): Delete.
2205         (xstormy16_dummy_id): Delete.
2206         (xstormy16_gdbarch_init): Don't register deleted functions with
2207         gdbarch.
2208
2209 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2210
2211         * vax-tdep.c (vax_unwind_pc): Delete.
2212         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2213
2214 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2215
2216         * v850-tdep.c (v850_unwind_sp): Delete.
2217         (v850_unwind_pc): Delete.
2218         (v850_dummy_id): Delete.
2219         (v850_gdbarch_init): Don't register deleted functions with
2220         gdbarch.
2221
2222 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2223
2224         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2225         (tilegx_unwind_pc): Delete.
2226         (tilegx_unwind_dummy_id): Delete.
2227         (tilegx_gdbarch_init): Don't register deleted functions with
2228         gdbarch.
2229
2230 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2231
2232         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2233         (tic6x_dummy_id): Delete.
2234         (tic6x_gdbarch_init): Don't register deleted functions with
2235         gdbarch.
2236
2237 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2238
2239         * sparc-tdep.c (sparc_unwind_pc): Delete.
2240         (sparc32_gdbarch_init): Don't register deleted function with
2241         gdbarch.
2242
2243 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2244
2245         * sh-tdep.c (sh_unwind_sp): Delete.
2246         (sh_unwind_pc): Delete.
2247         (sh_dummy_id): Delete.
2248         (sh_gdbarch_init): Don't register deleted functions with
2249         gdbarch.
2250
2251 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2252
2253         * score-tdep.c (score_unwind_sp): Delete.
2254         (score_unwind_pc): Delete.
2255         (score_dummy_id): Delete.
2256         (score_gdbarch_init): Don't register deleted functions with
2257         gdbarch.
2258
2259 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2260
2261         * rx-tdep.c (rx_unwind_pc): Delete.
2262         (rx_unwind_sp): Delete.
2263         (rx_dummy_id): Delete.
2264         (rx_gdbarch_init): Don't register deleted functions with
2265         gdbarch.  Update comment.
2266
2267 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2268
2269         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2270         (rs6000_dummy_id): Delete.
2271         (rs6000_gdbarch_init): Don't register deleted functions with
2272         gdbarch.
2273
2274 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2275
2276         * or1k-tdep.c (or1k_dummy_id): Delete.
2277         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2278
2279 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2280
2281         * nios2-tdep.c (nios2_dummy_id): Delete.
2282         (nios2_unwind_sp): Delete.
2283         (nios2_gdbarch_init): Don't register deleted functions with
2284         gdbarch.
2285
2286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2287
2288         * nds32-tdep.c (nds32_dummy_id): Delete.
2289         (nds32_unwind_pc): Delete.
2290         (nds32_unwind_sp): Delete.
2291         (nds32_gdbarch_init): Don't register deleted functions with
2292         gdbarch.
2293
2294 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2295
2296         * msp430-tdep.c (msp430_unwind_pc): Delete.
2297         (msp430_unwind_sp): Delete.
2298         (msp430_dummy_id): Delete.
2299         (msp430_gdbarch_init): Don't register deleted functions with
2300         gdbarch.
2301
2302 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2303
2304         * moxie-tdep.c (moxie_unwind_sp): Delete.
2305         (moxie_unwind_pc): Delete.
2306         (moxie_dummy_id): Delete.
2307         (moxie_gdbarch_init): Don't register deleted functions with
2308         gdbarch.
2309
2310 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2311
2312         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2313         (mn10300_unwind_pc): Delete.
2314         (mn10300_unwind_sp): Delete.
2315         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2316         mn10300_unwind_sp.
2317         (mn10300_frame_unwind_init): Don't register deleted functions with
2318         gdbarch.
2319
2320 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2321
2322         * mep-tdep.c (mep_unwind_pc): Delete.
2323         (mep_unwind_sp): Delete.
2324         (mep_dummy_id): Delete.
2325         (mep_gdbarch_init): Don't register deleted functions with
2326         gdbarch.
2327
2328 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2329
2330         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2331         (m68hc11_unwind_sp): Delete.
2332         (m68hc11_gdbarch_init): Don't register deleted functions with
2333         gdbarch.
2334
2335 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2336
2337         * m32r-tdep.c (m32r_unwind_sp): Delete.
2338         (m32r_unwind_pc): Delete.
2339         (m32r_dummy_id): Delete.
2340         (m32r_gdbarch_init): Don't register deleted functions with
2341         gdbarch.
2342
2343 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2344
2345         * m32c-tdep.c (m32c_unwind_pc): Delete.
2346         (m32c_unwind_sp): Delete.
2347         (m32c_dummy_id): Delete.
2348         (m32c_gdbarch_init): Don't register deleted functions with
2349         gdbarch.
2350
2351 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2352
2353         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2354         (lm32_unwind_pc): Delete.
2355         (lm32_dummy_id): Delete.
2356         (lm32_gdbarch_init): Don't register deleted functions with
2357         gdbarch.
2358
2359 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2360
2361         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2362         (iq2000_unwind_pc): Delete.
2363         (iq2000_dummy_id): Delete.
2364         (iq2000_gdbarch_init): Don't register deleted functions with
2365         gdbarch.
2366
2367 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2368
2369         * nds32-tdep.c (nds32_type_align): Delete.
2370         (nds32_push_dummy_call): Use type_align instead.
2371
2372 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2373
2374         * arm-tdep.c (arm_type_align): Only handle vector override case.
2375         (arm_push_dummy_call): Use type_align.
2376         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2377
2378 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2379
2380         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2381         case.
2382         (pass_on_stack): Use type_align.
2383         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2384         function.
2385
2386 2019-04-23  Tom Tromey  <tromey@adacore.com>
2387
2388         * dwarf2read.c (line_header::file_name_at): Remove unused
2389         overload.
2390
2391 2019-04-23  Tom de Vries  <tdevries@suse.de>
2392
2393         PR gdb/24438
2394         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2395         invocation.
2396
2397
2398 2019-03-27  Ali Tamur  <tamur@google.com>
2399
2400         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2401         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2402         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2403         (dwarf_expr_context::get_addr_index): Likewise
2404         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2405         (symbol_needs_eval_context::get_addr_index): Likewise
2406         (disassemble_dwarf_expression): Add DW_OP_addrx
2407         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2408         (read_cutu_die_from_dwo): Update comment
2409         (skip_one_die): Add DW_FORM_addrx
2410         (read_attribute_value): Likewise
2411         (var_decode_location): Add DW_OP_addrx
2412         (dwarf2_const_value_attr): Add DW_FORM_addrx
2413         (dump_die_shallow): Likewise
2414         (dwarf2_fetch_constant_bytes): Likewise
2415         (decode_locdesc): Add DW_OP_addrx
2416         (skip_form_bytes): Add DW_FORM_addrx
2417
2418 2019-04-22  Ali Tamur  <tamur@google.com>
2419
2420         * MAINTAINERS (Write After Approval): Add self.
2421
2422 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2423
2424         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2425         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2426         (open_symbol_file_object): Likewise.
2427         (svr4_default_sos): Add info parameter.
2428         (svr4_read_so_list): Likewise.
2429         (svr4_current_sos_direct): Adjust functions calls to pass down
2430         info.
2431         (svr4_current_sos_1): Add info parameter.
2432         (svr4_current_sos): Call get_svr4_info, pass info down to
2433         svr4_current_sos_1.
2434         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2435         get_svr4_info.
2436         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2437         get_svr4_info.
2438         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2439         to get_svr4_info.
2440         (probes_table_remove_objfile_probes): Likewise.
2441         (register_solib_event_probe): Add info parameter.
2442         (solist_update_incremental): Pass info parameter down to
2443         svr4_read_so_list.
2444         (disable_probes_interface): Add info parameter.
2445         (svr4_handle_solib_event): Pass current_program_space to
2446         get_svr4_info.  Adjust disable_probes_interface cleanup.
2447         (svr4_create_probe_breakpoints): Add info parameter, pass it
2448         down to register_solib_event_probe.
2449         (svr4_create_solib_event_breakpoints): Add info parameter,
2450         pass it down to svr4_create_probe_breakpoints.
2451         (enable_break): Pass info down to
2452         svr4_create_solib_event_breakpoints.
2453         (svr4_solib_create_inferior_hook): Pass current_program_space to
2454         get_svr4_info.
2455         (svr4_clear_solib): Likewise.
2456
2457 2019-04-22  Pedro Alves  <palves@redhat.com>
2458
2459         * solib-svr4.c (svr4_free_objfile_observer): New.
2460         (probe_and_action::objfile): New field.
2461         (probes_table_htab_remove_objfile_probes)
2462         (probes_table_remove_objfile_probes): New functions.
2463         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2464         in the new probe_and_action.  Don't store the probe in 'lookup'.
2465         (svr4_create_probe_breakpoints): Pass objfile to
2466         register_solib_event_probe.
2467         (_initialize_svr4_solib): Register a free_objfile observer.
2468
2469 2019-04-19  Tom Tromey  <tom@tromey.com>
2470
2471         * common/queue.h: Remove.
2472
2473 2019-04-19  Tom Tromey  <tom@tromey.com>
2474
2475         * event-loop.c: Don't include "common/queue.h".
2476
2477 2019-04-19  Tom Tromey  <tom@tromey.com>
2478
2479         * remote.c (remote_target): Use delete.
2480         * remote-notif.h: Include <list>, not "common/queue.h".
2481         (notif_client_p): Remove typedef.
2482         (remote_notif_state): Add constructor, destructor, initializer.
2483         <notif_queue>: Now a std::list.
2484         (remote_notif_state_xfree): Don't declare.
2485         * remote-notif.c (remote_notif_process, handle_notification)
2486         (remote_notif_state_allocate): Update.
2487         (~remote_notif_state): Rename from remote_notif_state_xfree.
2488
2489 2019-04-19  Tom Tromey  <tom@tromey.com>
2490
2491         * symfile.c (reread_symbols): Update.
2492         * objfiles.c (objfile_register_static_link)
2493         (objfile_lookup_static_link): Update
2494         (~objfile) Don't delete static_links.
2495         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2496
2497 2019-04-19  Tom Tromey  <tom@tromey.com>
2498
2499         * type-stack.h (struct type_stack) <insert>: Constify string.
2500         * type-stack.c (type_stack::insert): Constify string.
2501         * gdbtypes.h (lookup_template_type): Update.
2502         (address_space_name_to_int): Update.
2503         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2504         const.
2505         (lookup_template_type): Make name const.
2506         * c-exp.y: Update rules.
2507         (lex_one_token, classify_name, classify_inner_name)
2508         (c_print_token): Update.
2509         * p-exp.y: Update rules.
2510         (yylex): Update.
2511         * f-exp.y: Update rules.
2512         (yylex): Update.
2513         * d-exp.y: Update rules.
2514         (lex_one_token, classify_name, classify_inner_name): Update.
2515         * parse.c (write_dollar_variable, copy_name): Return std::string.
2516         * parser-defs.h (copy_name): Change return type.
2517         * m2-exp.y: Update rules.
2518         (yylex): Update.
2519         * go-exp.y (lex_one_token): Update.
2520         Update rules.
2521         (classify_unsafe_function, classify_packaged_name)
2522         (classify_name, yylex): Update.
2523
2524 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2525
2526         * configure.ac: add --enable-source-highlight switch.
2527         * configure: Regenerate.
2528         * top.c (print_gdb_version): plumb --enable-source-highlight
2529         status to "show configuration".
2530
2531 2019-04-19  Tom Tromey  <tromey@adacore.com>
2532
2533         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2534         Check ADA_TYPE_P.
2535         (empty_record, ada_template_to_fixed_record_type_1)
2536         (template_to_static_fixed_type)
2537         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2538         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2539         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2540         macros.
2541
2542 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2543
2544         PR symtab/24423:
2545         * source.c (print_source_lines_base): Advance "iter" when a
2546         control character is seen.
2547
2548 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2549
2550         * inferior.h (struct infcall_suspend_state_deleter):
2551         Catch exception in destructor to avoid crash.
2552
2553 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2554
2555         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2556         close to the add_com "shell".
2557
2558 2019-04-18  Tom Tromey  <tromey@adacore.com>
2559
2560         * process-stratum-target.h (class process_stratum_target)
2561         <stratum>: Add "final".
2562
2563 2019-04-17  Tom Tromey  <tromey@adacore.com>
2564
2565         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2566         against nullptr before use.
2567
2568 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2569
2570         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2571
2572 2019-04-17  Jim Wilson  <jimw@sifive.com>
2573             Andrew Burgess  <andrew.burgess@embecosm.com>
2574
2575         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2576         code read might fail, assume 4-byte breakpoint in that case.
2577
2578 2019-04-15  Leszek Swirski  <leszeks@google.com>
2579
2580         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2581         rather than a hand-rolled POD check when checking for forced MEMORY
2582         classification.
2583
2584 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2585
2586         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2587         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2588         function.
2589         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2590         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2591         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2592         declaration.
2593
2594 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2595
2596         * aarch64-linux-nat.c
2597         (aarch64_linux_nat_target::thread_architecture): Add override.
2598         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2599         each VQ.
2600
2601 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2602
2603         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2604
2605 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2606
2607         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2608         target types of size 96-bits, add some additional comments, and
2609         check that the builtin type we found was the correct size.
2610
2611 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2612
2613         * utils.c (prompt_for_continue): Don't restore the styling at the
2614         end, as applied_style has the wrong value.  This fixes styling in
2615         long lists of file names that are interrupted by the "Continue?"
2616         prompt.
2617
2618 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2619
2620         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2621         * c-lang.c (c_language_defn): Likewise.
2622         (cplus_language_defn): Likewise.
2623         (asm_language_defn): Likewise.
2624         (minimal_language_defn): Likewise.
2625         * d-lang.c (d_language_defn): Likewise.
2626         * f-lang.c (f_language_defn): Likewise.
2627         * go-lang.c (go_language_defn): Likewise.
2628         * language.c (unknown_language_defn): Likewise.
2629         (auto_language_defn): Likewise.
2630         * language.h (struct language_defn): Remove la_magic field.
2631         (LANG_MAGIC): Delete.
2632         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2633         * objc-lang.c (objc_language_defn): Likewise.
2634         * opencl-lang.c (opencl_language_defn): Likewise.
2635         * p-lang.c (pascal_language_defn): Likewise.
2636         * rust-lang.c (rust_language_defn): Likewise.
2637
2638 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2639
2640         * riscv-tdep.c (riscv_type_align): New function.
2641         (riscv_type_alignment): Delete.
2642         (riscv_arg_location): Use 'type_align'.
2643         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2644
2645 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2646
2647         * gdbtypes.c (type_align): A struct with no non-static fields also
2648         has alignment of 1.
2649
2650 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2651
2652         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2653         component to 0.
2654         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2655         member.
2656         (riscv_struct_info::analyse): New implementation using new
2657         analyse_inner member function.
2658         (riscv_struct_info::field_offset): New member function.
2659         (riscv_struct_info::m_offsets): New member variable.
2660         (riscv_struct_info::analyse_inner): New private member function,
2661         takes the old implementation of riscv_struct_info::analyse but
2662         extended to track field offsets.
2663         (riscv_call_arg_struct): Update the struct folding special cases
2664         to handle cases where empty C++ structs, which are non-zero
2665         length, are found.
2666         (riscv_arg_location): Initialise the length of each location, a
2667         non-zero length now indicates the location is in use.
2668         (riscv_push_dummy_call): Allow for the first location having a
2669         non-zero offset when setting up arguments.
2670         (riscv_return_value): Likewise, but for return values.
2671
2672 2019-04-11  Tom Tromey  <tromey@adacore.com>
2673
2674         * utils.c (internal_vproblem): Make "msg" const.
2675
2676 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2677
2678         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2679         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2680         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2681         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2682
2683 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2684
2685         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2686         function.
2687         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2688         of amd64_collect_native_gregset.
2689         (amd64_linux_nat_target::store_registers): Likewise.
2690
2691 2019-04-10  Tom Tromey  <tom@tromey.com>
2692
2693         * symtab.c (lookup_global_symbol_from_objfile)
2694         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2695         * objfiles.h (class separate_debug_iterator): New.
2696         (class separate_debug_range): New.
2697         (struct objfile) <separate_debug_objfiles>: New method.
2698         (objfile_separate_debug_iterate): Don't declare.
2699         * objfiles.c (separate_debug_iterator::operator++): Rename from
2700         objfile_separate_debug_iterate.
2701         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2702         iterator.
2703         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2704         iterator.
2705
2706 2019-04-10  Tom Tromey  <tom@tromey.com>
2707
2708         * symfile.c (reread_symbols): Remove old comment.
2709         * objfiles.c (free_all_objfiles): Fix a typo.
2710
2711 2019-04-10  Tom Tromey  <tom@tromey.com>
2712
2713         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2714         * minsyms.c (lookup_minimal_symbol): Use foreach.
2715         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2716         (lookup_minimal_symbol_solib_trampoline): Likewise.
2717         * symfile.c (reread_symbols): Use foreach.
2718
2719 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2720             Tom Tromey  <tromey@adacore.com>
2721
2722         PR rust/24414:
2723         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2724         (rust_lex_int_test): Change "value" to be LONGEST.
2725         (rust_lex_tests): Add test for long integer literal.
2726
2727 2019-04-09  Tom Tromey  <tromey@adacore.com>
2728
2729         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2730         to bool.
2731         (extended_remote_target::attach): Update.
2732         (remote_target::remote_notice_new_inferior): Update.
2733         (remote_target::add_current_inferior_and_thread): Update.
2734         * inferior.c (exit_inferior_1): Use "false".
2735         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2736
2737 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2738
2739         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2740         the "start" command.
2741
2742 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2743
2744         * python/py-inferior.c (infpy_thread_from_thread_handle):
2745         Adjust comments to reflect renaming of thread_from_thread_handle
2746         to thread_from_handle.  Adjust keywords.  Fix type error message.
2747         (inferior_object_methods): Add thread_from_handle.  Retain
2748         thread_from_thread_handle, but mark it as deprecated.
2749
2750 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2751
2752         * gdbthread.h (find_thread_by_handle): Revise declaration.
2753         * thread.c (find_thread_by_handle): Likewise.  Adjust
2754         implementation too.
2755         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2756         support for buffer objects as handles.
2757
2758 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2759
2760         * python/py-infthread.c (thpy_thread_handle): New function.
2761         (thread_object_methods): Register thpy_thread_handle.
2762
2763 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2764
2765         * gdbthread.h (thread_to_thread_handle): Declare.
2766         * thread.c (gdbtypes.h): Include.
2767         (thread_to_thread_handle): New function.
2768
2769         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2770         (target_thread_info_to_thread_handle): Declare.
2771         * target.c (target_thread_info_to_thread_handle): New function.
2772         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2773         * target-delegates.c: Regenerate.
2774
2775         * linux-thread-db.c (class thread_db_target): Add method
2776         thread_info_to_thread_handle.
2777         (thread_db_target::thread_info_to_thread_handle): Define.
2778         * remote.c (class remote_target): Add new method
2779         thread_info_to_thread_handle.
2780         (remote_target::thread_info_to_thread_handle): Define.
2781
2782 2019-04-08  Pedro Alves  <palves@redhat.com>
2783
2784         * common/common-exceptions.c (throw_exception): Don't create
2785         named object to throw; throw directly.
2786         (throw_it): Likewise.  Don't initialize gdb_exception::message
2787         here, with new; pass FMT and AP to the ctor instead.
2788         * common/common-exceptions.h: Include <string>.
2789         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2790         const char *, va_list)): New ctor.  Use std::make_shared.
2791         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2792         errors)): Delete.
2793         (gdb_exception_error::gdb_exception_error(enum errors, const char
2794         *, va_list)): New.
2795         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2796         Add assertion.
2797         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2798         errors)): Delete.
2799         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2800         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2801         Add assertion.
2802
2803 2019-04-08  Tom Tromey  <tom@tromey.com>
2804
2805         * valops.c (value_rtti_indirect_type): Replace throw_exception
2806         with throw.
2807         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2808         with throw.
2809         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2810         throw.
2811         * target.c (target_translate_tls_address): Replace throw_exception
2812         with throw.
2813         * stack.c (frame_apply_command_count): Replace throw_exception
2814         with throw.
2815         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2816         throw.
2817         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2818         with throw.
2819         * rs6000-tdep.c (rs6000_frame_cache)
2820         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2821         * remote.c: Replace throw_exception with throw.
2822         * record-full.c (record_full_message, record_full_wait_1)
2823         (record_full_restore): Replace throw_exception with throw.
2824         * record-btrace.c:
2825         (get_thread_current_frame_id, record_btrace_start_replaying)
2826         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2827         (cmd_record_btrace_start): Replace throw_exception with throw.
2828         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2829         throw.
2830         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2831         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2832         * linespec.c:
2833         (find_linespec_symbols): Replace throw_exception with throw.
2834         * infrun.c (displaced_step_prepare, resume): Replace
2835         throw_exception with throw.
2836         * infcmd.c (post_create_inferior): Replace throw_exception with
2837         throw.
2838         * inf-loop.c (inferior_event_handler): Replace throw_exception
2839         with throw.
2840         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2841         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2842         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2843         (get_prev_frame_always, get_frame_pc_if_available)
2844         (get_frame_address_in_block_if_available, get_frame_language):
2845         Replace throw_exception with throw.
2846         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2847         throw_exception with throw.
2848         * eval.c (fetch_subexp_value, evaluate_var_value)
2849         (evaluate_funcall, evaluate_subexp_standard): Replace
2850         throw_exception with throw.
2851         * dwarf2loc.c (call_site_find_chain)
2852         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2853         Replace throw_exception with throw.
2854         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2855         with throw.
2856         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2857         throw.
2858         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2859         * completer.c (complete_line_internal): Replace throw_exception
2860         with throw.
2861         * compile/compile-object-run.c (compile_object_run): Replace
2862         throw_exception with throw.
2863         * cli/cli-script.c (process_next_line): Replace throw_exception
2864         with throw.
2865         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2866         (btrace_enable, btrace_maint_update_pt_packets): Replace
2867         throw_exception with throw.
2868         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2869         throw_exception with throw.
2870         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2871         throw_exception with throw.
2872         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2873         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2874         * aarch64-tdep.c (aarch64_make_prologue_cache)
2875         (aarch64_make_stub_cache): Replace throw_exception with throw.
2876
2877 2019-04-08  Tom Tromey  <tom@tromey.com>
2878
2879         * common/common-exceptions.c (throw_exception): Rename from
2880         throw_exception_cxx.  Remove old copy.  Make argument const.
2881         (throw_it): Create and throw exception objects directly.
2882         * common/common-exceptions.h (throw_exception): Make argument
2883         const.
2884         (struct gdb_exception_error): Add constructor.
2885         (struct gdb_exception_quit): Add constructor.
2886
2887 2019-04-08  Tom Tromey  <tom@tromey.com>
2888
2889         * common/common-exceptions.h (exception_rethrow): Don't declare.
2890         (TRY_SJLJ): Update comment.
2891         (TRY, CATCH, END_CATCH): Remove.
2892         * common/common-exceptions.c (exception_rethrow): Remove.
2893
2894 2019-04-08  Tom Tromey  <tom@tromey.com>
2895
2896         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2897         Remove.
2898         (gdb_exception_error): Rename from
2899         gdb_exception_RETURN_MASK_ERROR.
2900         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2901         (gdb_quit_bad_alloc): Update.
2902         * aarch64-tdep.c: Update.
2903         * ada-lang.c: Update.
2904         * ada-typeprint.c: Update.
2905         * ada-valprint.c: Update.
2906         * amd64-tdep.c: Update.
2907         * arch-utils.c: Update.
2908         * break-catch-throw.c: Update.
2909         * breakpoint.c: Update.
2910         * btrace.c: Update.
2911         * c-varobj.c: Update.
2912         * cli/cli-cmds.c: Update.
2913         * cli/cli-interp.c: Update.
2914         * cli/cli-script.c: Update.
2915         * common/common-exceptions.c: Update.
2916         * common/new-op.c: Update.
2917         * common/selftest.c: Update.
2918         * compile/compile-c-symbols.c: Update.
2919         * compile/compile-cplus-symbols.c: Update.
2920         * compile/compile-object-load.c: Update.
2921         * compile/compile-object-run.c: Update.
2922         * completer.c: Update.
2923         * corelow.c: Update.
2924         * cp-abi.c: Update.
2925         * cp-support.c: Update.
2926         * cp-valprint.c: Update.
2927         * darwin-nat.c: Update.
2928         * disasm-selftests.c: Update.
2929         * dtrace-probe.c: Update.
2930         * dwarf-index-cache.c: Update.
2931         * dwarf-index-write.c: Update.
2932         * dwarf2-frame-tailcall.c: Update.
2933         * dwarf2-frame.c: Update.
2934         * dwarf2loc.c: Update.
2935         * dwarf2read.c: Update.
2936         * eval.c: Update.
2937         * event-loop.c: Update.
2938         * event-top.c: Update.
2939         * exec.c: Update.
2940         * f-valprint.c: Update.
2941         * fbsd-tdep.c: Update.
2942         * frame-unwind.c: Update.
2943         * frame.c: Update.
2944         * gdbtypes.c: Update.
2945         * gnu-v3-abi.c: Update.
2946         * guile/guile-internal.h: Update.
2947         * guile/scm-block.c: Update.
2948         * guile/scm-breakpoint.c: Update.
2949         * guile/scm-cmd.c: Update.
2950         * guile/scm-disasm.c: Update.
2951         * guile/scm-frame.c: Update.
2952         * guile/scm-lazy-string.c: Update.
2953         * guile/scm-math.c: Update.
2954         * guile/scm-param.c: Update.
2955         * guile/scm-ports.c: Update.
2956         * guile/scm-pretty-print.c: Update.
2957         * guile/scm-symbol.c: Update.
2958         * guile/scm-symtab.c: Update.
2959         * guile/scm-type.c: Update.
2960         * guile/scm-value.c: Update.
2961         * i386-linux-tdep.c: Update.
2962         * i386-tdep.c: Update.
2963         * inf-loop.c: Update.
2964         * infcall.c: Update.
2965         * infcmd.c: Update.
2966         * infrun.c: Update.
2967         * jit.c: Update.
2968         * language.c: Update.
2969         * linespec.c: Update.
2970         * linux-fork.c: Update.
2971         * linux-nat.c: Update.
2972         * linux-tdep.c: Update.
2973         * linux-thread-db.c: Update.
2974         * main.c: Update.
2975         * mi/mi-cmd-break.c: Update.
2976         * mi/mi-cmd-stack.c: Update.
2977         * mi/mi-interp.c: Update.
2978         * mi/mi-main.c: Update.
2979         * objc-lang.c: Update.
2980         * p-valprint.c: Update.
2981         * parse.c: Update.
2982         * ppc-linux-tdep.c: Update.
2983         * printcmd.c: Update.
2984         * python/py-arch.c: Update.
2985         * python/py-breakpoint.c: Update.
2986         * python/py-cmd.c: Update.
2987         * python/py-finishbreakpoint.c: Update.
2988         * python/py-frame.c: Update.
2989         * python/py-framefilter.c: Update.
2990         * python/py-gdb-readline.c: Update.
2991         * python/py-inferior.c: Update.
2992         * python/py-infthread.c: Update.
2993         * python/py-lazy-string.c: Update.
2994         * python/py-linetable.c: Update.
2995         * python/py-objfile.c: Update.
2996         * python/py-param.c: Update.
2997         * python/py-prettyprint.c: Update.
2998         * python/py-progspace.c: Update.
2999         * python/py-record-btrace.c: Update.
3000         * python/py-record.c: Update.
3001         * python/py-symbol.c: Update.
3002         * python/py-type.c: Update.
3003         * python/py-unwind.c: Update.
3004         * python/py-utils.c: Update.
3005         * python/py-value.c: Update.
3006         * python/python.c: Update.
3007         * record-btrace.c: Update.
3008         * record-full.c: Update.
3009         * remote-fileio.c: Update.
3010         * remote.c: Update.
3011         * riscv-tdep.c: Update.
3012         * rs6000-aix-tdep.c: Update.
3013         * rs6000-tdep.c: Update.
3014         * rust-exp.y: Update.
3015         * rust-lang.c: Update.
3016         * s390-tdep.c: Update.
3017         * selftest-arch.c: Update.
3018         * solib-dsbt.c: Update.
3019         * solib-frv.c: Update.
3020         * solib-spu.c: Update.
3021         * solib-svr4.c: Update.
3022         * solib.c: Update.
3023         * sparc64-linux-tdep.c: Update.
3024         * stack.c: Update.
3025         * symfile-mem.c: Update.
3026         * symmisc.c: Update.
3027         * target.c: Update.
3028         * thread.c: Update.
3029         * top.c: Update.
3030         * tracefile-tfile.c: Update.
3031         * tui/tui.c: Update.
3032         * typeprint.c: Update.
3033         * unittests/cli-utils-selftests.c: Update.
3034         * unittests/parse-connection-spec-selftests.c: Update.
3035         * valops.c: Update.
3036         * valprint.c: Update.
3037         * value.c: Update.
3038         * varobj.c: Update.
3039         * windows-nat.c: Update.
3040         * x86-linux-nat.c: Update.
3041         * xml-support.c: Update.
3042
3043 2019-04-08  Tom Tromey  <tom@tromey.com>
3044
3045         * xml-support.c: Use C++ exception handling.
3046         * x86-linux-nat.c: Use C++ exception handling.
3047         * windows-nat.c: Use C++ exception handling.
3048         * varobj.c: Use C++ exception handling.
3049         * value.c: Use C++ exception handling.
3050         * valprint.c: Use C++ exception handling.
3051         * valops.c: Use C++ exception handling.
3052         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3053         handling.
3054         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3055         * typeprint.c: Use C++ exception handling.
3056         * tui/tui.c: Use C++ exception handling.
3057         * tracefile-tfile.c: Use C++ exception handling.
3058         * top.c: Use C++ exception handling.
3059         * thread.c: Use C++ exception handling.
3060         * target.c: Use C++ exception handling.
3061         * symmisc.c: Use C++ exception handling.
3062         * symfile-mem.c: Use C++ exception handling.
3063         * stack.c: Use C++ exception handling.
3064         * sparc64-linux-tdep.c: Use C++ exception handling.
3065         * solib.c: Use C++ exception handling.
3066         * solib-svr4.c: Use C++ exception handling.
3067         * solib-spu.c: Use C++ exception handling.
3068         * solib-frv.c: Use C++ exception handling.
3069         * solib-dsbt.c: Use C++ exception handling.
3070         * selftest-arch.c: Use C++ exception handling.
3071         * s390-tdep.c: Use C++ exception handling.
3072         * rust-lang.c: Use C++ exception handling.
3073         * rust-exp.y: Use C++ exception handling.
3074         * rs6000-tdep.c: Use C++ exception handling.
3075         * rs6000-aix-tdep.c: Use C++ exception handling.
3076         * riscv-tdep.c: Use C++ exception handling.
3077         * remote.c: Use C++ exception handling.
3078         * remote-fileio.c: Use C++ exception handling.
3079         * record-full.c: Use C++ exception handling.
3080         * record-btrace.c: Use C++ exception handling.
3081         * python/python.c: Use C++ exception handling.
3082         * python/py-value.c: Use C++ exception handling.
3083         * python/py-utils.c: Use C++ exception handling.
3084         * python/py-unwind.c: Use C++ exception handling.
3085         * python/py-type.c: Use C++ exception handling.
3086         * python/py-symbol.c: Use C++ exception handling.
3087         * python/py-record.c: Use C++ exception handling.
3088         * python/py-record-btrace.c: Use C++ exception handling.
3089         * python/py-progspace.c: Use C++ exception handling.
3090         * python/py-prettyprint.c: Use C++ exception handling.
3091         * python/py-param.c: Use C++ exception handling.
3092         * python/py-objfile.c: Use C++ exception handling.
3093         * python/py-linetable.c: Use C++ exception handling.
3094         * python/py-lazy-string.c: Use C++ exception handling.
3095         * python/py-infthread.c: Use C++ exception handling.
3096         * python/py-inferior.c: Use C++ exception handling.
3097         * python/py-gdb-readline.c: Use C++ exception handling.
3098         * python/py-framefilter.c: Use C++ exception handling.
3099         * python/py-frame.c: Use C++ exception handling.
3100         * python/py-finishbreakpoint.c: Use C++ exception handling.
3101         * python/py-cmd.c: Use C++ exception handling.
3102         * python/py-breakpoint.c: Use C++ exception handling.
3103         * python/py-arch.c: Use C++ exception handling.
3104         * printcmd.c: Use C++ exception handling.
3105         * ppc-linux-tdep.c: Use C++ exception handling.
3106         * parse.c: Use C++ exception handling.
3107         * p-valprint.c: Use C++ exception handling.
3108         * objc-lang.c: Use C++ exception handling.
3109         * mi/mi-main.c: Use C++ exception handling.
3110         * mi/mi-interp.c: Use C++ exception handling.
3111         * mi/mi-cmd-stack.c: Use C++ exception handling.
3112         * mi/mi-cmd-break.c: Use C++ exception handling.
3113         * main.c: Use C++ exception handling.
3114         * linux-thread-db.c: Use C++ exception handling.
3115         * linux-tdep.c: Use C++ exception handling.
3116         * linux-nat.c: Use C++ exception handling.
3117         * linux-fork.c: Use C++ exception handling.
3118         * linespec.c: Use C++ exception handling.
3119         * language.c: Use C++ exception handling.
3120         * jit.c: Use C++ exception handling.
3121         * infrun.c: Use C++ exception handling.
3122         * infcmd.c: Use C++ exception handling.
3123         * infcall.c: Use C++ exception handling.
3124         * inf-loop.c: Use C++ exception handling.
3125         * i386-tdep.c: Use C++ exception handling.
3126         * i386-linux-tdep.c: Use C++ exception handling.
3127         * guile/scm-value.c: Use C++ exception handling.
3128         * guile/scm-type.c: Use C++ exception handling.
3129         * guile/scm-symtab.c: Use C++ exception handling.
3130         * guile/scm-symbol.c: Use C++ exception handling.
3131         * guile/scm-pretty-print.c: Use C++ exception handling.
3132         * guile/scm-ports.c: Use C++ exception handling.
3133         * guile/scm-param.c: Use C++ exception handling.
3134         * guile/scm-math.c: Use C++ exception handling.
3135         * guile/scm-lazy-string.c: Use C++ exception handling.
3136         * guile/scm-frame.c: Use C++ exception handling.
3137         * guile/scm-disasm.c: Use C++ exception handling.
3138         * guile/scm-cmd.c: Use C++ exception handling.
3139         * guile/scm-breakpoint.c: Use C++ exception handling.
3140         * guile/scm-block.c: Use C++ exception handling.
3141         * guile/guile-internal.h: Use C++ exception handling.
3142         * gnu-v3-abi.c: Use C++ exception handling.
3143         * gdbtypes.c: Use C++ exception handling.
3144         * frame.c: Use C++ exception handling.
3145         * frame-unwind.c: Use C++ exception handling.
3146         * fbsd-tdep.c: Use C++ exception handling.
3147         * f-valprint.c: Use C++ exception handling.
3148         * exec.c: Use C++ exception handling.
3149         * event-top.c: Use C++ exception handling.
3150         * event-loop.c: Use C++ exception handling.
3151         * eval.c: Use C++ exception handling.
3152         * dwarf2read.c: Use C++ exception handling.
3153         * dwarf2loc.c: Use C++ exception handling.
3154         * dwarf2-frame.c: Use C++ exception handling.
3155         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3156         * dwarf-index-write.c: Use C++ exception handling.
3157         * dwarf-index-cache.c: Use C++ exception handling.
3158         * dtrace-probe.c: Use C++ exception handling.
3159         * disasm-selftests.c: Use C++ exception handling.
3160         * darwin-nat.c: Use C++ exception handling.
3161         * cp-valprint.c: Use C++ exception handling.
3162         * cp-support.c: Use C++ exception handling.
3163         * cp-abi.c: Use C++ exception handling.
3164         * corelow.c: Use C++ exception handling.
3165         * completer.c: Use C++ exception handling.
3166         * compile/compile-object-run.c: Use C++ exception handling.
3167         * compile/compile-object-load.c: Use C++ exception handling.
3168         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3169         * compile/compile-c-symbols.c: Use C++ exception handling.
3170         * common/selftest.c: Use C++ exception handling.
3171         * common/new-op.c: Use C++ exception handling.
3172         * cli/cli-script.c: Use C++ exception handling.
3173         * cli/cli-interp.c: Use C++ exception handling.
3174         * cli/cli-cmds.c: Use C++ exception handling.
3175         * c-varobj.c: Use C++ exception handling.
3176         * btrace.c: Use C++ exception handling.
3177         * breakpoint.c: Use C++ exception handling.
3178         * break-catch-throw.c: Use C++ exception handling.
3179         * arch-utils.c: Use C++ exception handling.
3180         * amd64-tdep.c: Use C++ exception handling.
3181         * ada-valprint.c: Use C++ exception handling.
3182         * ada-typeprint.c: Use C++ exception handling.
3183         * ada-lang.c: Use C++ exception handling.
3184         * aarch64-tdep.c: Use C++ exception handling.
3185
3186 2019-04-08  Tom Tromey  <tom@tromey.com>
3187
3188         * xml-support.c (gdb_xml_parser::parse): Update.
3189         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3190         * value.c (show_convenience): Update.
3191         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3192         (test_parse_flags_qcs): Update.
3193         * thread.c (thr_try_catch_cmd): Update.
3194         * target.c (target_translate_tls_address): Update.
3195         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3196         (info_frame_command_core, frame_apply_command_count): Update.
3197         * rust-exp.y (rust_lex_exception_test): Update.
3198         * riscv-tdep.c (riscv_print_one_register_info): Update.
3199         * remote.c (remote_target::enable_btrace): Update.
3200         * record-btrace.c (record_btrace_enable_warn): Update.
3201         * python/py-utils.c (gdbpy_convert_exception): Update.
3202         * printcmd.c (do_one_display, print_variable_and_value): Update.
3203         * mi/mi-main.c (mi_print_exception): Update.
3204         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3205         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3206         * linux-nat.c (linux_nat_target::attach): Update.
3207         * linux-fork.c (class scoped_switch_fork_info): Update.
3208         * infrun.c (displaced_step_prepare): Update.
3209         * infcall.c (call_function_by_hand_dummy): Update.
3210         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3211         * gnu-v3-abi.c (print_one_vtable): Update.
3212         * frame.c (get_prev_frame_always): Update.
3213         * f-valprint.c (info_common_command_for_block): Update.
3214         * exec.c (try_open_exec_file): Update.
3215         * exceptions.c (print_exception, exception_print)
3216         (exception_fprintf, exception_print_same): Update.
3217         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3218         * dwarf-index-cache.c (index_cache::store)
3219         (index_cache::lookup_gdb_index): Update.
3220         * darwin-nat.c (maybe_cache_shell): Update.
3221         * cp-valprint.c (cp_print_value_fields): Update.
3222         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3223         (gcc_cplus_symbol_address): Update.
3224         * compile/compile-c-symbols.c (gcc_convert_symbol)
3225         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3226         * common/selftest.c: Update.
3227         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3228         a std::string.
3229         (exception_try_scope_entry, exception_try_scope_exit): Don't
3230         declare.
3231         (struct exception_try_scope): Remove.
3232         (TRY): Don't use exception_try_scope.
3233         (struct gdb_exception): Add constructor, operator=.
3234         <what>: New method.
3235         (struct gdb_exception_RETURN_MASK_ALL)
3236         (struct gdb_exception_RETURN_MASK_ERROR)
3237         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3238         (struct gdb_quit_bad_alloc): Update.
3239         * common/common-exceptions.c (exception_none): Change
3240         initializer.
3241         (struct catcher) <state, exception>: Initialize inline.
3242         <prev>: Remove member.
3243         (current_catcher): Remove.
3244         (catchers): New global.
3245         (exceptions_state_mc_init): Simplify.
3246         (catcher_pop): Remove.
3247         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3248         (try_scope_depth, exception_try_scope_entry)
3249         (exception_try_scope_exit): Remove.
3250         (throw_exception_sjlj): Update.
3251         (exception_messages, exception_messages_size): Remove.
3252         (throw_it): Simplify.
3253         (gdb_exception_sliced_copy): Remove.
3254         (throw_exception_cxx): Update.
3255         * cli/cli-script.c (script_from_file): Update.
3256         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3257         Update.
3258         * ada-valprint.c (ada_val_print): Update.
3259         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3260         (create_excep_cond_exprs): Update.
3261
3262 2019-04-08  Tom Tromey  <tom@tromey.com>
3263
3264         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3265         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3266         (TRY, CATCH, END_CATCH): Remove some definitions.
3267         * common/common-exceptions.c: Don't use GDB_XCPT.
3268         (catcher_list_size): Remove.
3269         (throw_exception, throw_it): Simplify.
3270
3271 2019-04-05  Tom Tromey  <tom@tromey.com>
3272
3273         Revert the header-sorting patch.
3274         * ft32-tdep.c: Revert.
3275         * frv-tdep.c: Revert.
3276         * frv-linux-tdep.c: Revert.
3277         * frame.c: Revert.
3278         * frame-unwind.c: Revert.
3279         * frame-base.c: Revert.
3280         * fork-child.c: Revert.
3281         * findvar.c: Revert.
3282         * findcmd.c: Revert.
3283         * filesystem.c: Revert.
3284         * filename-seen-cache.h: Revert.
3285         * filename-seen-cache.c: Revert.
3286         * fbsd-tdep.c: Revert.
3287         * fbsd-nat.h: Revert.
3288         * fbsd-nat.c: Revert.
3289         * f-valprint.c: Revert.
3290         * f-typeprint.c: Revert.
3291         * f-lang.c: Revert.
3292         * extension.h: Revert.
3293         * extension.c: Revert.
3294         * extension-priv.h: Revert.
3295         * expprint.c: Revert.
3296         * exec.h: Revert.
3297         * exec.c: Revert.
3298         * exceptions.c: Revert.
3299         * event-top.c: Revert.
3300         * event-loop.c: Revert.
3301         * eval.c: Revert.
3302         * elfread.c: Revert.
3303         * dwarf2read.h: Revert.
3304         * dwarf2read.c: Revert.
3305         * dwarf2loc.c: Revert.
3306         * dwarf2expr.h: Revert.
3307         * dwarf2expr.c: Revert.
3308         * dwarf2-frame.c: Revert.
3309         * dwarf2-frame-tailcall.c: Revert.
3310         * dwarf-index-write.h: Revert.
3311         * dwarf-index-write.c: Revert.
3312         * dwarf-index-common.c: Revert.
3313         * dwarf-index-cache.h: Revert.
3314         * dwarf-index-cache.c: Revert.
3315         * dummy-frame.c: Revert.
3316         * dtrace-probe.c: Revert.
3317         * disasm.h: Revert.
3318         * disasm.c: Revert.
3319         * disasm-selftests.c: Revert.
3320         * dictionary.c: Revert.
3321         * dicos-tdep.c: Revert.
3322         * demangle.c: Revert.
3323         * dcache.h: Revert.
3324         * dcache.c: Revert.
3325         * darwin-nat.h: Revert.
3326         * darwin-nat.c: Revert.
3327         * darwin-nat-info.c: Revert.
3328         * d-valprint.c: Revert.
3329         * d-namespace.c: Revert.
3330         * d-lang.c: Revert.
3331         * ctf.c: Revert.
3332         * csky-tdep.c: Revert.
3333         * csky-linux-tdep.c: Revert.
3334         * cris-tdep.c: Revert.
3335         * cris-linux-tdep.c: Revert.
3336         * cp-valprint.c: Revert.
3337         * cp-support.c: Revert.
3338         * cp-namespace.c: Revert.
3339         * cp-abi.c: Revert.
3340         * corelow.c: Revert.
3341         * corefile.c: Revert.
3342         * continuations.c: Revert.
3343         * completer.h: Revert.
3344         * completer.c: Revert.
3345         * complaints.c: Revert.
3346         * coffread.c: Revert.
3347         * coff-pe-read.c: Revert.
3348         * cli-out.h: Revert.
3349         * cli-out.c: Revert.
3350         * charset.c: Revert.
3351         * c-varobj.c: Revert.
3352         * c-valprint.c: Revert.
3353         * c-typeprint.c: Revert.
3354         * c-lang.c: Revert.
3355         * buildsym.c: Revert.
3356         * buildsym-legacy.c: Revert.
3357         * build-id.h: Revert.
3358         * build-id.c: Revert.
3359         * btrace.c: Revert.
3360         * bsd-uthread.c: Revert.
3361         * breakpoint.h: Revert.
3362         * breakpoint.c: Revert.
3363         * break-catch-throw.c: Revert.
3364         * break-catch-syscall.c: Revert.
3365         * break-catch-sig.c: Revert.
3366         * blockframe.c: Revert.
3367         * block.c: Revert.
3368         * bfin-tdep.c: Revert.
3369         * bfin-linux-tdep.c: Revert.
3370         * bfd-target.c: Revert.
3371         * bcache.c: Revert.
3372         * ax-general.c: Revert.
3373         * ax-gdb.h: Revert.
3374         * ax-gdb.c: Revert.
3375         * avr-tdep.c: Revert.
3376         * auxv.c: Revert.
3377         * auto-load.c: Revert.
3378         * arm-wince-tdep.c: Revert.
3379         * arm-tdep.c: Revert.
3380         * arm-symbian-tdep.c: Revert.
3381         * arm-pikeos-tdep.c: Revert.
3382         * arm-obsd-tdep.c: Revert.
3383         * arm-nbsd-tdep.c: Revert.
3384         * arm-nbsd-nat.c: Revert.
3385         * arm-linux-tdep.c: Revert.
3386         * arm-linux-nat.c: Revert.
3387         * arm-fbsd-tdep.c: Revert.
3388         * arm-fbsd-nat.c: Revert.
3389         * arm-bsd-tdep.c: Revert.
3390         * arch-utils.c: Revert.
3391         * arc-tdep.c: Revert.
3392         * arc-newlib-tdep.c: Revert.
3393         * annotate.h: Revert.
3394         * annotate.c: Revert.
3395         * amd64-windows-tdep.c: Revert.
3396         * amd64-windows-nat.c: Revert.
3397         * amd64-tdep.c: Revert.
3398         * amd64-sol2-tdep.c: Revert.
3399         * amd64-obsd-tdep.c: Revert.
3400         * amd64-obsd-nat.c: Revert.
3401         * amd64-nbsd-tdep.c: Revert.
3402         * amd64-nbsd-nat.c: Revert.
3403         * amd64-nat.c: Revert.
3404         * amd64-linux-tdep.c: Revert.
3405         * amd64-linux-nat.c: Revert.
3406         * amd64-fbsd-tdep.c: Revert.
3407         * amd64-fbsd-nat.c: Revert.
3408         * amd64-dicos-tdep.c: Revert.
3409         * amd64-darwin-tdep.c: Revert.
3410         * amd64-bsd-nat.c: Revert.
3411         * alpha-tdep.c: Revert.
3412         * alpha-obsd-tdep.c: Revert.
3413         * alpha-nbsd-tdep.c: Revert.
3414         * alpha-mdebug-tdep.c: Revert.
3415         * alpha-linux-tdep.c: Revert.
3416         * alpha-linux-nat.c: Revert.
3417         * alpha-bsd-tdep.c: Revert.
3418         * alpha-bsd-nat.c: Revert.
3419         * aix-thread.c: Revert.
3420         * agent.c: Revert.
3421         * addrmap.c: Revert.
3422         * ada-varobj.c: Revert.
3423         * ada-valprint.c: Revert.
3424         * ada-typeprint.c: Revert.
3425         * ada-tasks.c: Revert.
3426         * ada-lang.c: Revert.
3427         * aarch64-tdep.c: Revert.
3428         * aarch64-ravenscar-thread.c: Revert.
3429         * aarch64-newlib-tdep.c: Revert.
3430         * aarch64-linux-tdep.c: Revert.
3431         * aarch64-linux-nat.c: Revert.
3432         * aarch64-fbsd-tdep.c: Revert.
3433         * aarch64-fbsd-nat.c: Revert.
3434         * aarch32-linux-nat.c: Revert.
3435
3436 2019-04-05  Tom Tromey  <tom@tromey.com>
3437
3438         * ft32-tdep.c: Sort headers.
3439         * frv-tdep.c: Sort headers.
3440         * frv-linux-tdep.c: Sort headers.
3441         * frame.c: Sort headers.
3442         * frame-unwind.c: Sort headers.
3443         * frame-base.c: Sort headers.
3444         * fork-child.c: Sort headers.
3445         * findvar.c: Sort headers.
3446         * findcmd.c: Sort headers.
3447         * filesystem.c: Sort headers.
3448         * filename-seen-cache.h: Sort headers.
3449         * filename-seen-cache.c: Sort headers.
3450         * fbsd-tdep.c: Sort headers.
3451         * fbsd-nat.h: Sort headers.
3452         * fbsd-nat.c: Sort headers.
3453         * f-valprint.c: Sort headers.
3454         * f-typeprint.c: Sort headers.
3455         * f-lang.c: Sort headers.
3456         * extension.h: Sort headers.
3457         * extension.c: Sort headers.
3458         * extension-priv.h: Sort headers.
3459         * expprint.c: Sort headers.
3460         * exec.h: Sort headers.
3461         * exec.c: Sort headers.
3462         * exceptions.c: Sort headers.
3463         * event-top.c: Sort headers.
3464         * event-loop.c: Sort headers.
3465         * eval.c: Sort headers.
3466         * elfread.c: Sort headers.
3467         * dwarf2read.h: Sort headers.
3468         * dwarf2read.c: Sort headers.
3469         * dwarf2loc.c: Sort headers.
3470         * dwarf2expr.h: Sort headers.
3471         * dwarf2expr.c: Sort headers.
3472         * dwarf2-frame.c: Sort headers.
3473         * dwarf2-frame-tailcall.c: Sort headers.
3474         * dwarf-index-write.h: Sort headers.
3475         * dwarf-index-write.c: Sort headers.
3476         * dwarf-index-common.c: Sort headers.
3477         * dwarf-index-cache.h: Sort headers.
3478         * dwarf-index-cache.c: Sort headers.
3479         * dummy-frame.c: Sort headers.
3480         * dtrace-probe.c: Sort headers.
3481         * disasm.h: Sort headers.
3482         * disasm.c: Sort headers.
3483         * disasm-selftests.c: Sort headers.
3484         * dictionary.c: Sort headers.
3485         * dicos-tdep.c: Sort headers.
3486         * demangle.c: Sort headers.
3487         * dcache.h: Sort headers.
3488         * dcache.c: Sort headers.
3489         * darwin-nat.h: Sort headers.
3490         * darwin-nat.c: Sort headers.
3491         * darwin-nat-info.c: Sort headers.
3492         * d-valprint.c: Sort headers.
3493         * d-namespace.c: Sort headers.
3494         * d-lang.c: Sort headers.
3495         * ctf.c: Sort headers.
3496         * csky-tdep.c: Sort headers.
3497         * csky-linux-tdep.c: Sort headers.
3498         * cris-tdep.c: Sort headers.
3499         * cris-linux-tdep.c: Sort headers.
3500         * cp-valprint.c: Sort headers.
3501         * cp-support.c: Sort headers.
3502         * cp-namespace.c: Sort headers.
3503         * cp-abi.c: Sort headers.
3504         * corelow.c: Sort headers.
3505         * corefile.c: Sort headers.
3506         * continuations.c: Sort headers.
3507         * completer.h: Sort headers.
3508         * completer.c: Sort headers.
3509         * complaints.c: Sort headers.
3510         * coffread.c: Sort headers.
3511         * coff-pe-read.c: Sort headers.
3512         * cli-out.h: Sort headers.
3513         * cli-out.c: Sort headers.
3514         * charset.c: Sort headers.
3515         * c-varobj.c: Sort headers.
3516         * c-valprint.c: Sort headers.
3517         * c-typeprint.c: Sort headers.
3518         * c-lang.c: Sort headers.
3519         * buildsym.c: Sort headers.
3520         * buildsym-legacy.c: Sort headers.
3521         * build-id.h: Sort headers.
3522         * build-id.c: Sort headers.
3523         * btrace.c: Sort headers.
3524         * bsd-uthread.c: Sort headers.
3525         * breakpoint.h: Sort headers.
3526         * breakpoint.c: Sort headers.
3527         * break-catch-throw.c: Sort headers.
3528         * break-catch-syscall.c: Sort headers.
3529         * break-catch-sig.c: Sort headers.
3530         * blockframe.c: Sort headers.
3531         * block.c: Sort headers.
3532         * bfin-tdep.c: Sort headers.
3533         * bfin-linux-tdep.c: Sort headers.
3534         * bfd-target.c: Sort headers.
3535         * bcache.c: Sort headers.
3536         * ax-general.c: Sort headers.
3537         * ax-gdb.h: Sort headers.
3538         * ax-gdb.c: Sort headers.
3539         * avr-tdep.c: Sort headers.
3540         * auxv.c: Sort headers.
3541         * auto-load.c: Sort headers.
3542         * arm-wince-tdep.c: Sort headers.
3543         * arm-tdep.c: Sort headers.
3544         * arm-symbian-tdep.c: Sort headers.
3545         * arm-pikeos-tdep.c: Sort headers.
3546         * arm-obsd-tdep.c: Sort headers.
3547         * arm-nbsd-tdep.c: Sort headers.
3548         * arm-nbsd-nat.c: Sort headers.
3549         * arm-linux-tdep.c: Sort headers.
3550         * arm-linux-nat.c: Sort headers.
3551         * arm-fbsd-tdep.c: Sort headers.
3552         * arm-fbsd-nat.c: Sort headers.
3553         * arm-bsd-tdep.c: Sort headers.
3554         * arch-utils.c: Sort headers.
3555         * arc-tdep.c: Sort headers.
3556         * arc-newlib-tdep.c: Sort headers.
3557         * annotate.h: Sort headers.
3558         * annotate.c: Sort headers.
3559         * amd64-windows-tdep.c: Sort headers.
3560         * amd64-windows-nat.c: Sort headers.
3561         * amd64-tdep.c: Sort headers.
3562         * amd64-sol2-tdep.c: Sort headers.
3563         * amd64-obsd-tdep.c: Sort headers.
3564         * amd64-obsd-nat.c: Sort headers.
3565         * amd64-nbsd-tdep.c: Sort headers.
3566         * amd64-nbsd-nat.c: Sort headers.
3567         * amd64-nat.c: Sort headers.
3568         * amd64-linux-tdep.c: Sort headers.
3569         * amd64-linux-nat.c: Sort headers.
3570         * amd64-fbsd-tdep.c: Sort headers.
3571         * amd64-fbsd-nat.c: Sort headers.
3572         * amd64-dicos-tdep.c: Sort headers.
3573         * amd64-darwin-tdep.c: Sort headers.
3574         * amd64-bsd-nat.c: Sort headers.
3575         * alpha-tdep.c: Sort headers.
3576         * alpha-obsd-tdep.c: Sort headers.
3577         * alpha-nbsd-tdep.c: Sort headers.
3578         * alpha-mdebug-tdep.c: Sort headers.
3579         * alpha-linux-tdep.c: Sort headers.
3580         * alpha-linux-nat.c: Sort headers.
3581         * alpha-bsd-tdep.c: Sort headers.
3582         * alpha-bsd-nat.c: Sort headers.
3583         * aix-thread.c: Sort headers.
3584         * agent.c: Sort headers.
3585         * addrmap.c: Sort headers.
3586         * ada-varobj.c: Sort headers.
3587         * ada-valprint.c: Sort headers.
3588         * ada-typeprint.c: Sort headers.
3589         * ada-tasks.c: Sort headers.
3590         * ada-lang.c: Sort headers.
3591         * aarch64-tdep.c: Sort headers.
3592         * aarch64-ravenscar-thread.c: Sort headers.
3593         * aarch64-newlib-tdep.c: Sort headers.
3594         * aarch64-linux-tdep.c: Sort headers.
3595         * aarch64-linux-nat.c: Sort headers.
3596         * aarch64-fbsd-tdep.c: Sort headers.
3597         * aarch64-fbsd-nat.c: Sort headers.
3598         * aarch32-linux-nat.c: Sort headers.
3599
3600 2019-04-04  Tom Tromey  <tom@tromey.com>
3601
3602         * varobj.c (varobj_create): Update.
3603         * rust-exp.y (struct rust_parser) <update_innermost_block,
3604         lookup_symbol>: New methods.
3605         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3606         Rename.
3607         (rust_parser::rust_lookup_type)
3608         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3609         * printcmd.c (display_command, do_one_display): Update.
3610         * parser-defs.h (struct parser_state) <parser_state>: Add
3611         "tracker" parameter.
3612         (block_tracker): New member.
3613         (class innermost_block_tracker) <innermost_block_tracker>: Add
3614         "types" parameter.
3615         <reset>: Remove method.
3616         (innermost_block): Don't declare.
3617         (null_post_parser): Update.
3618         * parse.c (innermost_block): Remove global.
3619         (write_dollar_variable): Update.
3620         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3621         Remove "tracker_types" parameter.
3622         (parse_expression): Add "tracker" parameter.
3623         (parse_expression_for_completion): Update.
3624         (null_post_parser): Add "tracker" parameter.
3625         * p-exp.y: Update rules.
3626         * m2-exp.y: Update rules.
3627         * language.h (struct language_defn) <la_post_parser>: Add
3628         "tracker" parameter.
3629         * go-exp.y: Update rules.
3630         * f-exp.y: Update rules.
3631         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3632         parameter.
3633         * d-exp.y: Update rules.
3634         * c-exp.y: Update rules.
3635         * breakpoint.c (set_breakpoint_condition): Create an
3636         innermost_block_tracker.
3637         (watch_command_1): Likewise.
3638         * ada-lang.c (resolve): Add "tracker" parameter.
3639         (resolve_subexp): Likewise.
3640         * ada-exp.y (write_var_from_sym): Update.
3641
3642 2019-04-04  Tom Tromey  <tom@tromey.com>
3643
3644         * type-stack.h: New file.
3645         * type-stack.c: New file.
3646         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3647         type-stack.h.
3648         (insert_into_type_stack, insert_type, push_type, push_type_int)
3649         (insert_type_address_space, pop_type, pop_type_int)
3650         (pop_typelist, pop_type_stack, append_type_stack)
3651         (push_type_stack, get_type_stack, push_typelist)
3652         (follow_type_instance_flags, follow_types): Don't declare.
3653         * parse.c (type_stack): Remove global.
3654         (parse_exp_in_context): Update.
3655         (insert_into_type_stack, insert_type, push_type, push_type_int)
3656         (insert_type_address_space, pop_type, pop_type_int)
3657         (pop_typelist, pop_type_stack, append_type_stack)
3658         (push_type_stack, get_type_stack, push_typelist)
3659         (follow_type_instance_flags, follow_types): Remove (moved to
3660         type-stack.c).
3661         * f-exp.y (type_stack): New global.
3662         Update rules.
3663         (push_kind_type, f_parse): Update.
3664         * d-exp.y (type_stack): New global.
3665         Update rules.
3666         (d_parse): Update.
3667         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3668         Update rules.
3669         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3670         (HFILES_NO_SRCDIR): Add type-stack.h.
3671
3672 2019-04-04  Tom Tromey  <tom@tromey.com>
3673
3674         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3675         (rust_parser::convert_ast_to_expression, rust_parse)
3676         (rust_lex_test_completion, rust_lex_tests): Update.
3677         * parser-defs.h (struct expr_completion_state): New.
3678         (struct parser_state) <parser_state>: Add completion parameter.
3679         <mark_struct_expression, mark_completion_tag>: New methods.
3680         <parse_completion, m_completion_state>: New members.
3681         (prefixify_expression, null_post_parser): Update.
3682         (mark_struct_expression, mark_completion_tag): Don't declare.
3683         * parse.c (parse_completion, expout_last_struct)
3684         (expout_tag_completion_type, expout_completion_name): Remove
3685         globals.
3686         (parser_state::mark_struct_expression)
3687         (parser_state::mark_completion_tag): Now methods.
3688         (prefixify_expression): Add last_struct parameter.
3689         (prefixify_subexp): Likewise.
3690         (parse_exp_1): Update.
3691         (parse_exp_in_context): Add cstate parameter.  Update.
3692         (parse_expression_for_completion): Create an
3693         expr_completion_state.
3694         (null_post_parser): Add "completion" parameter.
3695         * p-exp.y: Update rules.
3696         (yylex): Update.
3697         * language.h (struct language_defn) <la_post_parser>: Add
3698         "completing" parameter.
3699         * go-exp.y: Update rules.
3700         (lex_one_token): Update.
3701         * expression.h (parse_completion): Don't declare.
3702         * d-exp.y: Update rules.
3703         (lex_one_token): Update rules.
3704         * c-exp.y: Update rules.
3705         (lex_one_token): Update.
3706         * ada-lang.c (resolve): Add "parse_completion" parameter.
3707         (resolve_subexp): Likewise.
3708         (ada_resolve_function): Likewise.
3709
3710 2019-04-04  Tom Tromey  <tom@tromey.com>
3711
3712         * parser-defs.h (struct parser_state) <start_arglist,
3713         end_arglist>: New methods.
3714         <arglist_len, m_funcall_chain>: New members.
3715         (arglist_len, start_arglist, end_arglist): Don't declare.
3716         * parse.c (arglist_len, funcall_chain): Remove global.
3717         (start_arglist, end_arglist): Remove functions.
3718         (parse_exp_in_context): Update.
3719         * p-exp.y: Update rules.
3720         * m2-exp.y: Update rules.
3721         * go-exp.y: Update rules.
3722         * f-exp.y: Update rules.
3723         * d-exp.y: Update rules.
3724         * c-exp.y: Update rules.
3725
3726 2019-04-04  Tom Tromey  <tom@tromey.com>
3727
3728         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3729         lex_operator, push_back>: New methods.
3730         Update all rules.
3731         (rust_parser::lex_hex, lex_escape): Rename and update.
3732         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3733         (rust_parser::lex_operator): Rename and update.
3734         (rust_parser::lex_number, rustyylex, rustyyerror)
3735         (rust_lex_test_init, rust_lex_test_sequence)
3736         (rust_lex_test_push_back, rust_lex_tests): Update.
3737         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3738         parameter.
3739         <lexptr, prev_lexptr>: New members.
3740         (lexptr, prev_lexptr): Don't declare.
3741         * parse.c (lexptr, prev_lexptr): Remove globals.
3742         (parse_exp_in_context): Update.
3743         * p-exp.y (yylex, yyerror): Update.
3744         * m2-exp.y (parse_number, yylex, yyerror): Update.
3745         * go-exp.y (lex_one_token, yyerror): Update.
3746         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3747         * d-exp.y (lex_one_token, yyerror): Update.
3748         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3749         (lex_one_token, yyerror): Update.
3750         * ada-lex.l (YY_INPUT): Update.
3751         (rewind_to_char): Update.
3752         * ada-exp.y (yyerror): Update.
3753
3754 2019-04-04  Tom Tromey  <tom@tromey.com>
3755
3756         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3757         * parser-defs.h (struct parser_state) <parser_state>: Add new
3758         parameter.
3759         <comma_terminates>: New member.
3760         (comma_terminates): Don't declare global.
3761         * parse.c (comma_terminates): Remove global.
3762         (parse_exp_in_context): Update.
3763         * p-exp.y (yylex): Update.
3764         * m2-exp.y (yylex): Update.
3765         * go-exp.y (lex_one_token): Update.
3766         * f-exp.y (yylex): Update.
3767         * d-exp.y (lex_one_token): Update.
3768         * c-exp.y (lex_one_token): Update.
3769         * ada-lex.l: Update.
3770
3771 2019-04-04  Tom Tromey  <tom@tromey.com>
3772
3773         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3774         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3775         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3776         * parser-defs.h (paren_depth): Don't declare.
3777         * parse.c (paren_depth): Remove global.
3778         (parse_exp_in_context): Update.
3779         * p-exp.y (paren_depth): New global.
3780         (pascal_parse): Initialize it.
3781         * m2-exp.y (paren_depth): New global.
3782         (m2_parse): Initialize it.
3783         * go-exp.y (paren_depth): New global.
3784         (go_parse): Initialize it.
3785         * f-exp.y (paren_depth): New global.
3786         (f_parse): Initialize it.
3787         * d-exp.y (paren_depth): New global.
3788         (d_parse): Initialize it.
3789         * c-exp.y (paren_depth): New global.
3790         (c_parse): Initialize it.
3791         * ada-lex.l (paren_depth): New global.
3792         (lexer_init): Initialize it.
3793
3794 2019-04-04  Tom Tromey  <tom@tromey.com>
3795
3796         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3797         (rust_parser::convert_ast_to_type)
3798         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3799         * parser-defs.h (struct parser_state) <parser_state>: Add
3800         parameters.  Initialize new members.
3801         <expression_context_block, expression_context_pc>: New members.
3802         * parse.c (expression_context_block, expression_context_pc):
3803         Remove globals.
3804         (parse_exp_in_context): Update.
3805         * p-exp.y: Update all rules.
3806         (yylex): Update.
3807         * m2-exp.y: Update all rules.
3808         (yylex): Update.
3809         * go-exp.y (yylex): Update.
3810         * f-exp.y (yylex): Update.
3811         * d-exp.y: Update all rules.
3812         (yylex): Update.
3813         * c-exp.y: Update all rules.
3814         (lex_one_token, classify_name, yylex, c_parse): Update.
3815         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3816
3817 2019-04-04  Tom Tromey  <tom@tromey.com>
3818
3819         * gdbarch.h, gdbarch.c: Rebuild.
3820         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3821         * stap-probe.h:
3822         (struct stap_parse_info): Replace "parser_state" with
3823         "expr_builder".
3824         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3825         (parser_state): New class.
3826         * parse.c (expr_builder): Rename.
3827         (expr_builder::release): Rename.
3828         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3829         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3830         (write_exp_elt_longcst, write_exp_elt_floatcst)
3831         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3832         (write_exp_string_vector, write_exp_bitstring)
3833         (write_exp_msymbol, mark_struct_expression)
3834         (write_dollar_variable)
3835         (insert_type_address_space, increase_expout_size): Replace
3836         "parser_state" with "expr_builder".
3837         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3838         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3839         "parser_state" with "expr_builder".
3840
3841 2019-04-04  Tom Tromey  <tom@tromey.com>
3842
3843         * rust-exp.y: Replace "parse_language" with method call.
3844         * p-exp.y:
3845         (yylex): Replace "parse_language" with method call.
3846         * m2-exp.y:
3847         (yylex): Replace "parse_language" with method call.
3848         * go-exp.y (classify_name): Replace "parse_language" with method
3849         call.
3850         * f-exp.y (yylex): Replace "parse_language" with method call.
3851         * d-exp.y (lex_one_token): Replace "parse_language" with method
3852         call.
3853         * c-exp.y:
3854         (lex_one_token, classify_name, yylex): Replace "parse_language"
3855         with method call.
3856         * ada-exp.y (find_primitive_type, type_char)
3857         (type_system_address): Replace "parse_language" with method call.
3858
3859 2019-04-04  Tom Tromey  <tom@tromey.com>
3860
3861         * rust-exp.y: Replace "parse_gdbarch" with method call.
3862         * parse.c (write_dollar_variable, insert_type_address_space):
3863         Replace "parse_gdbarch" with method call.
3864         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3865         call.
3866         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3867         call.
3868         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3869         "parse_gdbarch" with method call.
3870         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3871         with method call.
3872         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3873         "parse_gdbarch" with method call.
3874         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3875         "parse_gdbarch" with method call.
3876         * c-exp.y (parse_type, parse_number, classify_name): Replace
3877         "parse_gdbarch" with method call.
3878         * ada-lex.l: Replace "parse_gdbarch" with method call.
3879         * ada-exp.y (parse_type, find_primitive_type, type_char)
3880         (type_system_address): Replace "parse_gdbarch" with method call.
3881
3882 2019-04-04  Tom Tromey  <tom@tromey.com>
3883
3884         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3885         * stap-probe.c (stap_parse_argument): Update.
3886         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3887         initial_size parameter.
3888         * rust-exp.y (rust_lex_tests): Update.
3889         * parse.c (parser_state): Update.
3890         (parse_exp_in_context): Update.
3891         * parser-defs.h (struct parser_state) <parser_state>: Remove
3892         "initial_size" parameter.
3893
3894 2019-04-04  Tom Tromey  <tom@tromey.com>
3895
3896         * parser-defs.h (increase_expout_size): Don't declare.
3897         * parse.c (increase_expout_size): Now static.
3898
3899 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3900
3901         * gnu-nat.c (gnu_nat_target::wait): Fix
3902         target_waitstatus_to_string call.
3903
3904 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3905
3906         * eval.c (evaluate_subexp_standard): Handle internal functions
3907         during Fortran function call handling.
3908
3909 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3910
3911         * NEWS: Mention new internal functions.
3912         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3913         (read_base_type): Use dwarf2_init_complex_target_type.
3914         * value.c (creal_internal_fn): New function.
3915         (cimag_internal_fn): New function.
3916         (_initialize_values): Register new internal functions.
3917
3918 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3919
3920         * infrun.c (stop_all_threads): If debug_infrun, always
3921         trace the wait status after wait_one, using
3922         target_waitstatus_to_string and target_pid_to_str.
3923         (handle_inferior_event): Replace various trace of
3924         wait status kind by a single trace.
3925         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3926         wait status kind image by target_waitstatus_to_string.
3927         * target/waitstatus.c (target_waitstatus_to_string): Fix
3928         obsolete comment.
3929
3930 2019-04-01  Tom Tromey  <tromey@adacore.com>
3931
3932         PR symtab/23331:
3933         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3934
3935 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3936             Pedro Alves  <palves@redhat.com>
3937
3938         * top.c (quit_force): Call 'finalize_values'.
3939         * value.c (finalize_values): New function.
3940         * value.h (finalize_values): Declare.
3941
3942 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3943
3944         * NEWS: Announce $_gdb_major and $_gdb_minor.
3945
3946         * top.c (init_gdb_version_vars): New function.
3947         (gdb_init): Call init_gdb_version_vars.
3948
3949 2019-03-29  Tom Tromey  <tromey@adacore.com>
3950
3951         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3952         help text.  Remove dead code.
3953
3954 2019-03-29  Keith Seitz  <keiths@redhat.com>
3955
3956         From Siddhesh Poyarekar:
3957         * f-lang.h (f77_get_upperbound): Return LONGEST.
3958         (f77_get_lowerbound): Likewise.
3959         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3960         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3961         print them.
3962         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3963         plongest to format print it.
3964         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3965         (f77_get_upperbound): Likewise.
3966         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3967         LOWER_BOUND to LONGEST.
3968         (f77_create_arrayprint_offset_tbl): Likewise.
3969
3970 2019-03-29  Keith Seitz  <keiths@redhat.com>
3971
3972         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3973         %s/pulongest for TYPE_LENGTH instead of %d in format
3974         strings.
3975         * ada-typerint.c (ada_print_type): Likewise.
3976         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3977         * compile/compile-c-support.c (generate_register_struct): Likewise.
3978         * gdbtypes.c (recursive_dump_type): Likewise.
3979         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3980         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3981         instead of %d in format strings.
3982         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3983         to std::min to ULONGEST.
3984         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3985         instead of %d in format strings.
3986         * tracepoint.c (info_scope_command): Likewise.
3987         * typeprint.c (print_offset_data::update)
3988         (print_offset_data::finish): Likewise.
3989         * xtensa-tdep.c (xtensa_store_return_value)
3990         (xtensa_push_dummy_call): Likewise.
3991
3992 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3993
3994         * windows-nat.c (display_selector): Fixed format specifications
3995         for 64-bit Cygwin.
3996
3997 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3998
3999         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4000
4001 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4002
4003         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4004         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4005         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4006         (nios2_linux_init_abi): Install it.
4007
4008 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4009
4010         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4011
4012 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4013
4014         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4015
4016 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4017             Tom Tromey  <tromey@adacore.com>
4018
4019         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4020
4021 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4022
4023         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4024         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4025         method to compute the bounds of range types. Also print "[evaluated]"
4026         if the bounds' values come from a dynamic evaluation.
4027
4028 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4029
4030         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4031         whitespace when pretty printing is on.
4032
4033 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4034
4035         * ppc-linux-nat.c: Add include.
4036
4037 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4038
4039         * NEWS: Mention AArch64 Pointer Authentication.
4040
4041 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4042
4043         * arm-linux-nat.c: Add include.
4044
4045 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4046
4047         * source-cache.c (source_cache::get_source_lines): Re-read
4048         fullname after calling open_source_file.
4049
4050 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4051
4052         * NEWS: Mention TLS support for FreeBSD.
4053
4054 2019-03-25  Tom Tromey  <tromey@adacore.com>
4055
4056         * minsyms.c (BUNCH_SIZE): Update comment.
4057         (~minimal_symbol_reader): Remove old comment.
4058         (compact_minimal_symbols): Update comment.
4059         (minimal_symbol_reader::install): Remove old comment.  Update
4060         other comments.
4061
4062 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4063
4064         * s390-linux-nat.c: Add include.
4065
4066 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4067
4068         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4069         Call linux_get_hwcap.
4070         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4071         Likewise.
4072         (aarch64_linux_get_hwcap): Remove function.
4073         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4074         declaration.
4075         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4076         linux_get_hwcap.
4077         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4078         * linux-tdep.c (linux_get_hwcap): Add function.
4079         (linux_get_hwcap2): Likewise.
4080         * linux-tdep.h (linux_get_hwcap): Add declaration.
4081         (linux_get_hwcap2): Likewise.
4082         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4083         (ppc_linux_get_hwcap2): Likewise.
4084         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4085         linux_get_hwcap.
4086         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4087         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4088         (ppc_linux_nat_target::read_description): Likewise.
4089         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4090         * s390-linux-nat.c: Likewise.
4091         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4092
4093 2019-03-24  Tom Tromey  <tom@tromey.com>
4094
4095         * ada-lang.c (standard_lookup): Simplify initialization.
4096         (ada_lookup_symbol_nonlocal): Simplify return.
4097         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4098         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4099         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4100         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4101         initialization.
4102         * solib.c (solib_global_lookup): Simplify.
4103         * symtab.c (null_block_symbol): Remove.
4104         (symbol_cache_lookup): Simplify returns.
4105         (lookup_language_this): Simplify returns.
4106         (lookup_symbol_aux): Simplify return.
4107         (lookup_local_symbol): Simplify returns.
4108         (lookup_global_symbol_from_objfile): Simplify return.
4109         (lookup_symbol_in_objfile_symtabs)
4110         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4111         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4112         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4113         * cp-namespace.c (cp_lookup_bare_symbol)
4114         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4115         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4116         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4117         (cp_lookup_symbol_via_imports): Simplify initialization.
4118         (find_symbol_in_baseclass): Likewise.
4119         * symtab.h (null_block_symbol): Remove.
4120         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4121         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4122         (d_lookup_symbol_module): Likewise.
4123         (find_symbol_in_baseclass): Simplify initialization.
4124
4125 2019-03-24  Tom Tromey  <tom@tromey.com>
4126
4127         * expression.h: Don't include symtab.h.
4128         (struct block): Forward declare.
4129
4130 2019-03-24  Tom Tromey  <tom@tromey.com>
4131
4132         * c-exp.y (typebase): Remove casts.
4133         * gdbtypes.c (lookup_unsigned_typename, )
4134         (lookup_signed_typename): Remove cast.
4135         * eval.c (parse_to_comma_and_eval): Remove cast.
4136         * parse.c (write_dollar_variable): Remove cast.
4137         * block.h (struct block) <superblock>: Now const.
4138         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4139         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4140         (map_block): Make "block" const.
4141         * symfile.h (struct quick_symbol_functions)
4142         <map_matching_symbols>: Constify block argument to "callback".
4143         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4144         const.
4145         (find_pc_sect_compunit_symtab): Make "b" const.
4146         (find_symbol_at_address): Likewise.
4147         (search_symbols): Likewise.
4148         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4149         (dw2_debug_names_lookup_symbol): Likewise.
4150         (dw2_map_matching_symbols): Update.
4151         * p-valprint.c (pascal_val_print): Remove "block".
4152         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4153         (aux_add_nonlocal_symbols): Make "block" const.
4154         (resolve_subexp): Remove cast.
4155         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4156         const.
4157         (iterate_over_file_blocks): Likewise.
4158         * f-exp.y (%union) <bval>: Remove.
4159         * coffread.c (patch_opaque_types): Make "b" const.
4160         * spu-tdep.c (spu_catch_start): Make "block" const.
4161         * c-valprint.c (print_unpacked_pointer): Remove "block".
4162         * symmisc.c (dump_symtab_1): Make "b" const.
4163         (block_depth): Make "block" const.
4164         * d-exp.y (%union) <bval>: Remove.
4165         * cp-support.h (cp_lookup_rtti_type): Update.
4166         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4167         * psymtab.c (psym_lookup_symbol): Make "block" const.
4168         (maintenance_check_psymtabs): Make "b" const.
4169         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4170         (enumerate_locals, enumerate_args): Update.
4171         * python/py-symtab.c (stpy_global_block): Make "block" const.
4172         (stpy_static_block): Likewise.
4173         * inline-frame.c (block_starting_point_at): Make "new_block"
4174         const.
4175         * block.c (find_block_in_blockvector): Make return type const.
4176         (blockvector_for_pc_sect): Make "b" const.
4177         (find_block_in_blockvector): Make "b" const.
4178
4179 2019-03-23  Tom Tromey  <tom@tromey.com>
4180
4181         * varobj.c (varobj_create): Update.
4182         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4183         * printcmd.c (display_command, do_one_display): Don't reset
4184         innermost_block.
4185         * parser-defs.h (enum innermost_block_tracker_type): Move to
4186         expression.h.
4187         (innermost_block): Update comment.
4188         * parse.c (parse_exp_1): Add tracker_types parameter.
4189         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4190         tracker_types parameter.  Reset innermost_block.
4191         (parse_exp_in_context): Remove.
4192         (parse_expression_for_completion): Update.
4193         * objfiles.c (~objfile): Don't reset expression_context_block or
4194         innermost_block.
4195         * expression.h (enum innermost_block_tracker_type): Move from
4196         parser-defs.h.
4197         (parse_exp_1): Add tracker_types parameter.
4198         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4199         reset innermost_block.
4200
4201 2019-03-23  Tom Tromey  <tom@tromey.com>
4202
4203         * objfiles.h: Include bcache.h.
4204
4205 2019-03-23  Tom Tromey  <tom@tromey.com>
4206
4207         * linespec.c (get_current_search_block): Use
4208         scoped_restore_current_language.
4209         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4210
4211 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4212             Jiong Wang  <jiong.wang@arm.com>
4213
4214         * aarch64-linux-tdep.c
4215         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4216         section.
4217         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4218
4219 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4220             Jiong Wang  <jiong.wang@arm.com>
4221
4222         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4223         instructions.
4224         (aarch64_analyze_prologue_test): Add PACIASP test.
4225         (aarch64_prologue_prev_register): Unmask PC value.
4226
4227 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4228             Jiong Wang  <jiong.wang@arm.com>
4229
4230         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4231         (aarch64_dwarf2_prev_register): Unmask PC value.
4232         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4233         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4234         DW_CFA_AARCH64_negate_ra_state.
4235         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4236
4237 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4238             Jiong Wang  <jiong.wang@arm.com>
4239
4240         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4241         registers.
4242         (aarch64_pseudo_register_name): Likewise.
4243         (aarch64_pseudo_register_type): Likewise.
4244         (aarch64_pseudo_register_reggroup_p): Likewise.
4245         (aarch64_gdbarch_init): Add pauth registers.
4246         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4247         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4248         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4249         (struct gdbarch_tdep): Add regnum for ra_state.
4250
4251 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4252             Jiong Wang  <jiong.wang@arm.com>
4253
4254         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4255
4256 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4257             Jiong Wang  <jiong.wang@arm.com>
4258
4259         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4260         function.
4261         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4262         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4263         (aarch64_gdbarch_init): Add puth registers.
4264         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4265         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4266         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4267
4268 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4269             Jiong Wang  <jiong.wang@arm.com>
4270
4271         * aarch64-linux-nat.c
4272         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4273         * aarch64-linux-tdep.c
4274         (aarch64_linux_core_read_description): Likewise.
4275         (aarch64_linux_get_hwcap): New function.
4276         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4277         (aarch64_linux_get_hwcap): New declaration.
4278
4279 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4280             Jiong Wang  <jiong.wang@arm.com>
4281
4282         * aarch64-linux-nat.c
4283         (aarch64_linux_nat_target::read_description): Add pauth param.
4284         * aarch64-linux-tdep.c
4285         (aarch64_linux_core_read_description): Likewise.
4286         * aarch64-tdep.c (struct target_desc): Add in pauth.
4287         (aarch64_read_description): Add pauth param.
4288         (aarch64_gdbarch_init): Likewise.
4289         * aarch64-tdep.h (aarch64_read_description): Likewise.
4290         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4291         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4292         * features/Makefile: Add new files.
4293         * features/aarch64-pauth.c: New file.
4294         * features/aarch64-pauth.xml: New file.
4295
4296 2019-03-20  Tom Tromey  <tromey@adacore.com>
4297
4298         * infrun.c (handle_inferior_event): Rename from
4299         handle_inferior_event_1.  Create a scoped_value_mark.
4300         (handle_inferior_event): Remove.
4301
4302 2019-03-19  Tom Tromey  <tromey@adacore.com>
4303
4304         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4305         * infrun.h (print_stop_event): Add "displays" parameter.
4306         * infrun.c (print_stop_event): Add "displays" parameter.
4307
4308 2019-03-19  Pedro Alves  <palves@redhat.com>
4309
4310         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4311         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4312         to -1.  Fix TABs vs spaces.
4313         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4314         * tui/tui-out.h (tui_ui_out) Add intro comments.
4315         <m_line, m_start_of_line>: In-class initialize, and add describing
4316         comment.
4317
4318 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4319
4320         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4321         variable names.
4322         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4323
4324 2019-03-18  Pedro Alves  <palves@redhat.com>
4325             Eli Zaretskii <eliz@gnu.org>
4326
4327         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4328         m_line and m_start_of_line.
4329
4330 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4331
4332         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4333         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4334         it returns a newline.  This fixes a regression in TU mode, whereby
4335         the next line is output on the same screen line as the user input.
4336
4337 2019-03-18  Tom Tromey  <tromey@adacore.com>
4338
4339         * minsyms.c (minimal_symbol_reader::install): Remove call to
4340         obstack_blank.
4341
4342 2019-03-18  Pedro Alves  <palves@redhat.com>
4343
4344         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4345         New globals.
4346         (apply_style): New, factored out from ...
4347         (apply_ansi_escape): ... this.  Handle reverse video mode.
4348         (tui_set_reverse_mode): New function.
4349         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4350         * tui/tui-winsource.c (tui_show_source_line): Use
4351         tui_set_reverse_mode instead of setting A_STANDOUT.
4352         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4353         New setter methods.
4354
4355 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4356
4357         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4358         Handle tabs.
4359
4360 2019-03-18  Tom Tromey  <tromey@adacore.com>
4361
4362         * ada-lang.c (empty_array): Add "high" parameter.
4363         (ada_evaluate_subexp): Update.
4364
4365 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4366
4367         * unittests/string_view-selftests.c: Define
4368         _initialize_string_view_selftests unconditionally.
4369
4370 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4371
4372         PR gdb/24350
4373         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4374
4375 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4376
4377         PR gdb/24351
4378         * windows-nat.c (display_selector): Fix format specifiers.
4379
4380 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4381
4382         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4383         tui_refill_source_window instead of tui_refresh_win, to update the
4384         current execution line.  This fixes redisplay of the current line
4385         when stepping through the code with "next" or "step".
4386
4387 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4388
4389         * source-cache.c (source_cache::get_source_lines): Call
4390         find_source_lines to initialize s->nlines.  This fixes vertical
4391         scrolling of TUI source window when the DOWN arrow is pressed.
4392
4393 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4394
4395         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4396         linux-thread-db.c (_initialize_thread_db): Likewise.
4397
4398 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4399
4400         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4401         wclrtoeol in tui_show_source_line".  This reverts changes made in
4402         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4403
4404 2019-03-15  Tom Tromey  <tom@tromey.com>
4405
4406         * symtab.h (struct minimal_symbol): Derive from
4407         general_symbol_info.
4408         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4409         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4410         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4411         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4412         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4413         (MSYMBOL_SEARCH_NAME): Update.
4414         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4415         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4416         * minsyms.c (minimal_symbol_reader::record_full): Update.
4417
4418 2019-03-15  Tom Tromey  <tom@tromey.com>
4419
4420         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4421
4422 2019-03-15  Tom Tromey  <tom@tromey.com>
4423
4424         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4425         unique_xmalloc_ptr.
4426         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4427         Update.
4428         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4429         (build_minimal_symbol_hash_tables)
4430         (minimal_symbol_reader::install): Update.
4431
4432 2019-03-15  Tom Tromey  <tom@tromey.com>
4433
4434         * symtab.c (create_demangled_names_hash): Update.
4435         (symbol_set_names): Update.
4436         * objfiles.h (struct objfile_per_bfd_storage)
4437         <demangled_names_hash>: Now an htab_up.
4438         * objfiles.c (objfile_per_bfd_storage): Simplify.
4439
4440 2019-03-15  Tom Tromey  <tom@tromey.com>
4441
4442         * objfiles.h (struct objfile_per_bfd_storage): Declare
4443         destructor.
4444         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4445         New.
4446         (get_objfile_bfd_data): Use new.  Don't initialize
4447         language_of_main.
4448         (free_objfile_per_bfd_storage): Remove.
4449         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4450
4451 2019-03-15  Tom Tromey  <tom@tromey.com>
4452
4453         * symfile.c (reread_symbols): Update.
4454         * objfiles.c (objfile::objfile): Update.
4455         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4456         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4457         comment.
4458         (minimal_symbol_reader::install): Update.
4459         (terminate_minimal_symbol_table): Remove.
4460         * jit.c (jit_object_close_impl): Update.
4461
4462 2019-03-15  Tom Tromey  <tom@tromey.com>
4463
4464         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4465         initializations.
4466
4467 2019-03-15  Tom Tromey  <tom@tromey.com>
4468
4469         * objfiles.h (struct objfile_per_bfd_storage)
4470         <demangled_hash_languages>: Now a bitset.
4471         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4472         (lookup_minimal_symbol): Update.
4473
4474 2019-03-15  Tom Tromey  <tom@tromey.com>
4475
4476         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4477         Don't return the symbol.
4478         * coffread.c (record_minimal_symbol): Use record_full.
4479
4480 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4481
4482         The MS-Windows port of ncurses fails to switch to a color pair if
4483         one or both of the colors are the implicit default colors.  This
4484         change records the default colors when TUI is initialized, and
4485         then specifies them explicitly when a color pair uses the default
4486         colors.  This allows color styling in TUI mode on MS-Windows.
4487
4488         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4489         ncurses_norm_attr.
4490         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4491         colors in ncurses_norm_attr.
4492         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4493         "none", replace it with the default color recorded in
4494         ncurses_norm_attr.
4495
4496 2019-03-14  Tom Tromey  <tromey@adacore.com>
4497
4498         * source-cache.h (class source_cache) <get_source_lines>: Return
4499         std::string.
4500         * source-cache.c (source_cache::extract_lines): Handle case where
4501         first_pos==npos.  Return std::string.
4502         (source_cache::get_source_lines): Update.
4503
4504 2019-03-14  Tom Tromey  <tromey@adacore.com>
4505
4506         * NEWS: Add item for "style sources" commands.
4507         * source-cache.c (source_cache::get_source_lines): Check
4508         source_styling.
4509         * cli/cli-style.c (source_styling): New global.
4510         (_initialize_cli_style): Add "style sources" commands.
4511         (show_style_sources): New function.
4512         * cli/cli-style.h (source_styling): Declare.
4513
4514 2019-03-14  Pedro Alves  <palves@redhat.com>
4515             Tom Tromey  <tromey@adacore.com>
4516
4517         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4518         * tui/tui-winsource.c (tui_refill_source_window): New function,
4519         from...
4520         (tui_horizontal_source_scroll): ... here.  Move some logic.
4521         * cli/cli-style.c (set_style_enabled): Notify new observable.
4522         * tui/tui-hooks.c (tui_redisplay_source): New function.
4523         (tui_attach_detach_observers): Attach or detach
4524         tui_redisplay_source.
4525         * observable.h (source_styling_changed): New observable.
4526         * observable.c: Define source_styling_changed observable.
4527
4528 2019-03-13  Tom Tromey  <tromey@adacore.com>
4529
4530         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4531         (i386_gnu_nat_target::store_registers): Update.
4532         * target-debug.h (target_debug_print_std_string): New macro.
4533         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4534         * windows-tdep.c (display_one_tib): Update.
4535         * tui/tui-stack.c (tui_make_status_line): Update.
4536         * top.c (print_inferior_quit_action): Update.
4537         * thread.c (thr_try_catch_cmd): Update.
4538         (add_thread_with_info): Update.
4539         (thread_target_id_str): Update.
4540         (thr_try_catch_cmd): Update.
4541         (thread_command): Update.
4542         (thread_find_command): Update.
4543         * record-btrace.c (record_btrace_target::info_record)
4544         (record_btrace_resume_thread, record_btrace_target::resume)
4545         (record_btrace_cancel_resume, record_btrace_step_thread)
4546         (record_btrace_target::wait, record_btrace_target::wait)
4547         (record_btrace_target::wait, record_btrace_target::stop): Update.
4548         * progspace.c (print_program_space): Update.
4549         * process-stratum-target.c
4550         (process_stratum_target::thread_address_space): Update.
4551         * linux-fork.c (linux_fork_mourn_inferior)
4552         (detach_checkpoint_command, info_checkpoints_command)
4553         (linux_fork_context): Update.
4554         (linux_fork_detach): Update.
4555         (class scoped_switch_fork_info): Update.
4556         (delete_checkpoint_command): Update.
4557         * infrun.c (follow_fork_inferior): Update.
4558         (follow_fork_inferior): Update.
4559         (proceed_after_vfork_done): Update.
4560         (handle_vfork_child_exec_or_exit): Update.
4561         (follow_exec): Update.
4562         (displaced_step_prepare_throw): Update.
4563         (displaced_step_restore): Update.
4564         (start_step_over): Update.
4565         (resume_1): Update.
4566         (clear_proceed_status_thread): Update.
4567         (proceed): Update.
4568         (print_target_wait_results): Update.
4569         (do_target_wait): Update.
4570         (context_switch): Update.
4571         (stop_all_threads): Update.
4572         (restart_threads): Update.
4573         (finish_step_over): Update.
4574         (handle_signal_stop): Update.
4575         (switch_back_to_stepped_thread): Update.
4576         (keep_going_pass_signal): Update.
4577         (print_exited_reason): Update.
4578         (normal_stop): Update.
4579         * inferior.c (inferior_pid_to_str): Change return type.
4580         (print_selected_inferior): Update.
4581         (add_inferior): Update.
4582         (detach_inferior): Update.
4583         * dummy-frame.c (fprint_dummy_frames): Update.
4584         * dcache.c (dcache_info_1): Update.
4585         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4586         (btrace_fetch, btrace_clear): Update.
4587         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4588         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4589         type.
4590         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4591         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4592         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4593         * gdbarch.c, gdbarch.h: Rebuild.
4594         * gdbarch.sh (core_pid_to_str): Change return type.
4595         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4596         return type.
4597         (windows_nat_target::pid_to_str): Change return type.
4598         (windows_delete_thread): Update.
4599         (windows_nat_target::attach): Update.
4600         (windows_nat_target::files_info): Update.
4601         * target-delegates.c: Rebuild.
4602         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4603         return type.
4604         (sol_thread_target::pid_to_str): Change return type.
4605         * remote.c (class remote_target) <pid_to_str>: Change return
4606         type.
4607         (remote_target::pid_to_str): Change return type.
4608         (extended_remote_target::attach, remote_target::remote_stop_ns)
4609         (remote_target::remote_notif_remove_queued_reply)
4610         (remote_target::push_stop_reply, remote_target::disable_btrace):
4611         Update.
4612         (extended_remote_target::attach): Update.
4613         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4614         type.
4615         (gdbsim_target::pid_to_str): Change return type.
4616         * ravenscar-thread.c (struct ravenscar_thread_target)
4617         <pid_to_str>: Change return type.
4618         (ravenscar_thread_target::pid_to_str): Change return type.
4619         * procfs.c (class procfs_target) <pid_to_str>: Change return
4620         type.
4621         (procfs_target::pid_to_str): Change return type.
4622         (procfs_target::attach): Update.
4623         (procfs_target::detach): Update.
4624         (procfs_target::fetch_registers): Update.
4625         (procfs_target::store_registers): Update.
4626         (procfs_target::wait): Update.
4627         (procfs_target::files_info): Update.
4628         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4629         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4630         return type.
4631         (nto_procfs_target::pid_to_str): Change return type.
4632         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4633         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4634         return type.
4635         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4636         (exit_lwp): Update.
4637         (attach_proc_task_lwp_callback, get_detach_signal)
4638         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4639         (linux_nat_target::resume, wait_lwp, stop_callback)
4640         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4641         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4642         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4643         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4644         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4645         type.
4646         (inf_ptrace_target::attach): Update.
4647         (inf_ptrace_target::files_info): Update.
4648         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4649         type.
4650         (go32_nat_target::pid_to_str): Change return type.
4651         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4652         (gnu_nat_target::wait): Update.
4653         (gnu_nat_target::wait): Update.
4654         (gnu_nat_target::resume): Update.
4655         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4656         (fbsd_nat_target::wait): Update.
4657         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4658         type.
4659         (darwin_nat_target::attach): Update.
4660         * corelow.c (class core_target) <pid_to_str>: Change return type.
4661         (core_target::pid_to_str): Change return type.
4662         * target.c (normal_pid_to_str): Change return type.
4663         (default_pid_to_str): Likewise.
4664         (target_pid_to_str): Change return type.
4665         (target_translate_tls_address): Update.
4666         (target_announce_detach): Update.
4667         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4668         return type.
4669         (bsd_uthread_target::pid_to_str): Change return type.
4670         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4671         type.
4672         (bsd_kvm_target::pid_to_str): Change return type.
4673         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4674         return type.
4675         (aix_thread_target::pid_to_str): Change return type.
4676         * target.h (struct target_ops) <pid_to_str>: Change return type.
4677         (target_pid_to_str, normal_pid_to_str): Likewise.
4678         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4679         type.
4680         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4681         type.
4682         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4683         return type.
4684         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4685         type.
4686         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4687         type.
4688         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4689         return type.
4690
4691 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4692
4693         * NEWS: Mention that the new default MI version is 3.  Mention
4694         changes to the output of commands and events that deal with
4695         multi-location breakpoints.
4696         * breakpoint.c: Include "mi/mi-out.h".
4697         (print_one_breakpoint): Change output syntax if using MI version
4698         >= 3.
4699         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4700         New.
4701         (mi_multi_location_breakpoint_output_fixed): New.
4702         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4703         (mi_cmd_fix_multi_location_breakpoint_output): New.
4704         (mi_multi_location_breakpoint_output_fixed): New.
4705         * mi/mi-cmds.c (mi_cmds): Register command
4706         -fix-multi-location-breakpoint-output.
4707         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4708         interpreter "mi".
4709
4710 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4711
4712         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4713         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4714         instantiate mi_ui_out based on interpreter name.
4715         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4716         * mi/mi-main.c (mi_load_progress): Likewise.
4717
4718 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4719
4720         * NEWS: Combine separate "New targets" sections for 8.3.
4721
4722 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4723
4724         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4725         (ppcfbsd_init_abi): Install gdbarch
4726         "fetch_tls_load_module_address" and "get_thread_local_address"
4727         methods.
4728
4729 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4730
4731         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4732         (riscv_fbsd_init_abi): Install gdbarch
4733         "fetch_tls_load_module_address" and "get_thread_local_address"
4734         methods.
4735
4736 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4737
4738         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4739         (i386fbsd_init_abi): Install gdbarch
4740         "fetch_tls_load_module_address" and "get_thread_local_address"
4741         methods.
4742
4743 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4744
4745         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4746         (amd64fbsd_init_abi): Install gdbarch
4747         "fetch_tls_load_module_address" and "get_thread_local_address"
4748         methods.
4749
4750 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4751
4752         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4753         (struct fbsd_pspace_data): New type.
4754         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4755         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4756         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4757         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4758         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4759
4760 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4761
4762         * gdbtypes.c (lookup_struct_elt): New function.
4763         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4764         * gdbtypes.h (struct struct_elt): New type.
4765         (lookup_struct_elt): New prototype.
4766
4767 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4768
4769         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4770         remove disabled code block.
4771
4772 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4773
4774         * gdbarch.sh (get_thread_local_address): New method.
4775         * gdbarch.h, gdbarch.c: Regenerate.
4776         * target.c (target_translate_tls_address): Use
4777         gdbarch_get_thread_local_address if present instead of
4778         target::get_thread_local_address.
4779
4780 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4781
4782         * target.h (target::get_thread_local_address): Update comment.
4783
4784 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4785
4786         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4787         objfile->separate_debug_objfile_backlink if not NULL.
4788
4789 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4790
4791         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4792         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4793         (amd64bsd_store_inferior_registers): Likewise.
4794         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4795         Enable segment base registers.
4796         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4797         PT_GETFSBASE and PT_GETGSBASE.
4798         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4799         PT_SETGSBASE.
4800         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4801         segment base registers.
4802         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4803
4804 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4805
4806         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4807         Update calls to i386_target_description to add 'segments'
4808         parameter.
4809         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4810         add segment base registers.
4811         * arch/i386.c (i386_create_target_description): Add 'segments'
4812         parameter to enable segment base registers.
4813         * arch/i386.h (i386_create_target_description): Likewise.
4814         * features/i386/32bit-segments.xml: New file.
4815         * features/i386/32bit-segments.c: Generate.
4816         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4817         call to i386_target_description to add 'segments' parameter.
4818         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4819         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4820         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4821         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4822         if feature is present.
4823         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4824         Add 'segments' parameter to call to i386_target_description.
4825         (i386_target_description): Add 'segments' parameter to enable
4826         segment base registers.
4827         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4828         to call to i386_target_description.
4829         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4830         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4831         Define I386_NUM_REGS.
4832         (i386_target_description): Add 'segments' parameter to enable
4833         segment base registers.
4834
4835 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4836
4837         PR/24325
4838         * source-cache.c: #undef open and close, to avoid unresolved
4839         externals during linking.
4840
4841 2019-03-12  Tom Tromey  <tromey@adacore.com>
4842
4843         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4844         const.  Add initializers.
4845         (_initialize_remote): Don't initialize ptid globals.
4846
4847 2019-03-12  Pedro Alves  <palves@redhat.com>
4848
4849         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4850
4851 2019-03-12  Pedro Alves  <palves@redhat.com>
4852
4853         * cp-name-parser.y (main): Remove unused 'len' variable.
4854
4855 2019-03-12  Tom Tromey  <tromey@adacore.com>
4856
4857         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4858         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4859
4860 2019-03-12  Tom Tromey  <tromey@adacore.com>
4861
4862         * linux-nat.c (iterate_over_lwps): Update.
4863         (stop_callback): Remove parameter.
4864         (stop_wait_callback, detach_callback, resume_set_callback)
4865         (select_singlestep_lwp_callback, set_ignore_sigint)
4866         (status_callback, resumed_callback, resume_clear_callback)
4867         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4868         data parameter.
4869         (linux_nat_target::detach, linux_nat_target::resume)
4870         (linux_stop_and_wait_all_lwps, select_event_lwp)
4871         (linux_nat_filter_event, linux_nat_wait_1)
4872         (linux_nat_target::kill, linux_nat_target::stop)
4873         (linux_nat_target::stop): Update.
4874         (linux_nat_resume_callback): Change type.
4875         (resume_stopped_resumed_lwps, count_events_callback)
4876         (select_event_lwp_callback): Likewise.
4877         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4878         * arm-linux-nat.c (struct update_registers_data): Remove.
4879         (update_registers_callback): Change type.
4880         (arm_linux_insert_hw_breakpoint1): Update.
4881         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4882         parameter.
4883         (x86_linux_dr_set_addr): Update.
4884         (x86_linux_dr_set_control): Update.
4885         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4886         (iterate_over_lwps): Use gdb::function_view.
4887         * nat/aarch64-linux-hw-point.c (struct
4888         aarch64_dr_update_callback_param): Remove.
4889         (debug_reg_change_callback): Change type.
4890         (aarch64_notify_debug_reg_change): Update.
4891         * s390-linux-nat.c (s390_refresh_per_info): Update.
4892
4893 2019-03-11  Tom Tromey  <tromey@adacore.com>
4894
4895         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4896         redundant assignment to "this_cu".
4897
4898 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4899
4900         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4901
4902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4903
4904         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4905         from...
4906         (rank_one_type): ... this.
4907
4908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4909
4910         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4911         from...
4912         (rank_one_type): ... this.
4913
4914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4915
4916         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4917         from...
4918         (rank_one_type): ... this.
4919
4920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4921
4922         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4923         from...
4924         (rank_one_type): ... this.
4925
4926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4927
4928         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4929         from...
4930         (rank_one_type): ... this.
4931
4932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4933
4934         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4935         from...
4936         (rank_one_type): ... this.
4937
4938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4939
4940         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4941         from...
4942         (rank_one_type): ... this.
4943
4944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4945
4946         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4947         from...
4948         (rank_one_type): ... this.
4949
4950 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4951
4952         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4953         from...
4954         (rank_one_type): ... this.
4955
4956 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4957
4958         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4959         from...
4960         (rank_one_type): ... this.
4961
4962 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4963
4964         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4965         from...
4966         (rank_one_type): ... this.
4967
4968 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4969
4970         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4971         from...
4972         (rank_one_type): ... this.
4973
4974 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4975
4976         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4977         inferior-events' shows the example events.
4978
4979 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4980
4981         Support styling on native MS-Windows console
4982
4983         PR/24315
4984         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4985         on MS-Windows if $TERM is not defined.
4986
4987         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4988
4989         * posix-hdep.c (gdb_console_fputs):
4990         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4991         functions.
4992         * ui-file.h (gdb_console_fputs): Add prototype.
4993
4994         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4995         back to fputs only if the former returns zero.
4996
4997 2019-03-07  Tom Tromey  <tom@tromey.com>
4998
4999         * symmisc.c (print_symbol_bcache_statistics): Update.
5000         (print_objfile_statistics): Update.
5001         * symfile.c (allocate_symtab): Update.
5002         * stabsread.c: Don't include bcache.h.
5003         * psymtab.h (struct psymbol_bcache): Don't declare.
5004         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5005         (psymbol_bcache_init, psymbol_bcache_free)
5006         (psymbol_bcache_get_bcache): Don't declare.
5007         * psymtab.c (struct psymbol_bcache): Remove.
5008         (psymtab_storage::psymtab_storage): Update.
5009         (psymtab_storage::~psymtab_storage): Update.
5010         (psymbol_bcache_init, psymbol_bcache_free)
5011         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5012         (add_psymbol_to_bcache): Update.
5013         (allocate_psymtab): Update.
5014         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5015         macro_cache>: No longer pointers.
5016         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5017         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5018         * macrotab.c (macro_bcache): Update.
5019         * macroexp.c: Don't include bcache.h.
5020         * gdbtypes.c (check_types_worklist): Update.
5021         (types_deeply_equal): Remove TRY/CATCH.  Update.
5022         * elfread.c (elf_symtab_read): Update.
5023         * dwarf2read.c: Don't include bcache.h.
5024         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5025         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5026         (print_bcache_statistics, bcache_memory_used): Don't declare.
5027         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5028         methods.  Rename all data members.
5029         * bcache.c (struct bcache): Move to bcache.h.
5030         (bcache::expand_hash_table): Rename from expand_hash_table.
5031         (bcache): Remove.
5032         (bcache::insert): Rename from bcache_full.
5033         (bcache::compare): Rename from bcache_compare.
5034         (bcache_xmalloc): Remove.
5035         (bcache::~bcache): Rename from bcache_xfree.
5036         (bcache::print_statistics): Rename from print_bcache_statistics.
5037         (bcache::memory_used): Rename from bcache_memory_used.
5038
5039 2019-03-07  Pedro Alves  <palves@redhat.com>
5040
5041         * infrun.c (normal_stop): Also check for
5042         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5043
5044 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5045
5046         * f-lang.c (value_from_host_double): Moved to...
5047         * value.c (value_from_host_double): ...here.
5048         * value.h (value_from_host_double): Declare.
5049         * guile/scm-math.c (vlscm_convert_typed_number): Use
5050         value_from_host_double.
5051         (vlscm_convert_number): Likewise.
5052         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5053         * python/py-value.c (convert_value_from_python): Likewise.
5054
5055 2019-03-06  Tom Tromey  <tom@tromey.com>
5056
5057         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5058
5059 2019-03-06  Tom Tromey  <tom@tromey.com>
5060
5061         * utils.h (free_current_contents): Don't declare.
5062         * utils.c (free_current_contents): Remove.
5063
5064 2019-03-06  Tom Tromey  <tom@tromey.com>
5065
5066         * top.c (quit_force): Update.
5067         * main.c (captured_command_loop): Update.
5068         * common/new-op.c (operator new): Update.
5069         * common/common-exceptions.c (struct catcher)
5070         <save_cleanup_chain>: Remove member.
5071         (exceptions_state_mc_init): Update.
5072         (exception_try_scope_entry): Return nullptr.
5073         (exception_try_scope_exit, exception_rethrow)
5074         (throw_exception_sjlj, throw_exception_cxx): Update.
5075         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5076         (all_cleanups, do_cleanups, discard_cleanups)
5077         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5078         (restore_cleanups, restore_final_cleanups): Don't declare.
5079         (do_final_cleanups): Remove parameter.
5080         * common/cleanups.c (cleanup_chain, make_cleanup)
5081         (make_cleanup_dtor, all_cleanups, do_cleanups)
5082         (discard_my_cleanups, discard_cleanups)
5083         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5084         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5085         (null_cleanup): Remove.
5086         (do_final_cleanups): Remove parameter.
5087
5088 2019-03-06  Tom Tromey  <tom@tromey.com>
5089
5090         * remote.c (remote_target::remote_parse_stop_reply): Use
5091         unique_xmalloc_ptr.
5092
5093 2019-03-06  Tom Tromey  <tom@tromey.com>
5094
5095         * stabsread.c (struct stabs_field_info): Rename from field_info.
5096         <list, fnlist>: Add initializers.
5097         <obstack>: New member.
5098         (read_member_functions, read_struct_fields, read_baseclasses):
5099         Allocate on obstack.  Don't use cleanups.
5100         (read_one_struct_field, read_member_functions, read_struct_fields)
5101         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5102         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5103         (read_struct_type): Update.
5104
5105 2019-03-06  Tom Tromey  <tom@tromey.com>
5106
5107         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5108         * common/filestuff.h (make_cleanup_close): Don't declare.
5109         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5110         Remove.
5111
5112 2019-03-06  Tom Tromey  <tom@tromey.com>
5113
5114         * solib-aix.c: Use make_scope_exit.
5115
5116 2019-03-06  Tom Tromey  <tom@tromey.com>
5117
5118         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5119         Use make_scope_exit.
5120
5121 2019-03-06  Tom Tromey  <tom@tromey.com>
5122
5123         * solib-svr4.c (disable_probes_interface): Remove parameter.
5124         (svr4_handle_solib_event): Use make_scope_exit.
5125
5126 2019-03-06  Tom Tromey  <tom@tromey.com>
5127
5128         * remote.c (struct stop_reply_deleter): Remove.
5129         (stop_reply_up): Update.
5130         (struct stop_reply): Derive from notif_event.  Don't typedef.
5131         <regcache>: Now a std::vector.
5132         (stop_reply_xfree): Remove.
5133         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5134         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5135         (remote_target::discard_pending_stop_replies): Use delete.
5136         (remote_target::remote_parse_stop_reply): Update.
5137         (remote_target::process_stop_reply): Update.
5138         * remote-notif.h (struct notif_event): Add virtual destructor.
5139         Remove "dtr" member.
5140         (struct notif_client) <alloc_event>: Return a unique_ptr.
5141         (notif_event_xfree): Don't declare.
5142         (notif_event_up): New typedef.
5143         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5144         (notif_event_xfree, do_notif_event_xfree): Remove.
5145         (remote_notif_state_xfree): Update.
5146
5147 2019-03-06  Tom Tromey  <tom@tromey.com>
5148
5149         * infrun.c (displaced_step_clear_cleanup): Now a
5150         forward_scope_exit type.
5151         (displaced_step_prepare_throw): Update.
5152         (displaced_step_fixup): Update.
5153
5154 2019-03-06  Tom Tromey  <tom@tromey.com>
5155
5156         * inferior.h (class inferior): Update comment.
5157         * gdbthread.h (class thread_info): Update comment.
5158
5159 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5160             Tom Tromey  <tom@tromey.com>
5161
5162         * stabsread.h (struct stab_section_list): Remove.
5163         (coffstab_build_psymtabs): Update.
5164         * dbxread.c (symbuf_sections): Now a std::vector.
5165         (sect_idx): New global.
5166         (fill_symbuf): Update.
5167         (coffstab_build_psymtabs): Change type of stabsects parameter.
5168         Update.
5169         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5170         std::vector.
5171         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5172         (coff_locate_sections): Update.
5173         (coff_symfile_read): Remove cleanups.  Update.
5174         (init_stringtab): Add storage parameter.
5175         (free_stringtab, free_stringtab_cleanup): Remove.
5176         (init_lineno): Add storage parameter.
5177         (free_linetab, free_linetab_cleanup): Remove.
5178
5179 2019-03-06  Pedro Alves  <palves@redhat.com>
5180
5181         * linux-fork.c (fork_info::clobber_regs): Delete.
5182         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5183         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5184         comment.  Adjust.
5185         (scoped_switch_fork_info::scoped_switch_fork_info)
5186         (checkpoint_command, linux_fork_context): Adjust
5187         fork_save_infrun_state calls.
5188
5189 2019-03-06  Pedro Alves  <palves@redhat.com>
5190
5191         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5192         (inf_has_multiple_threads): Return 'bool' and rewrite using
5193         inferior_info::threads().
5194
5195 2019-03-06  Pedro Alves  <palves@redhat.com>
5196
5197         * linux-fork.c: Include <list>.
5198         (fork_list): Now a std::list instance.
5199         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5200         (forks_exist_p, find_last_fork): Adjust.
5201         (new_fork): Delete.
5202         (one_fork_p): New.
5203         (add_fork): Adjust.
5204         (free_fork): Delete, folded into fork_info::~fork_info().
5205         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5206         Adjust.
5207         (init_fork_list): Delete.
5208         (linux_fork_killall, linux_fork_mourn_inferior)
5209         (linux_fork_detach, info_checkpoints_command): Adjust.
5210         (_initialize_linux_fork): No longer call init_fork_list.
5211
5212 2019-03-06  Pedro Alves  <palves@redhat.com>
5213
5214         * linux-fork.c (new_fork): New, split out of ...
5215         (add_fork): ... this.  Return void.  Move "first fork" special
5216         case from here, to ...
5217         (checkpoint_command): ... here.
5218         * linux-linux.h (add_fork): Return void.
5219
5220 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5221
5222         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5223
5224 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5225             Chris January  <chris.january@arm.com>
5226             David Lecomber  <david.lecomber@arm.com>
5227
5228         * f-exp.y: New token, UNOP_INTRINSIC.
5229         (exp): New pattern using UNOP_INTRINSIC token.
5230         (f77_keywords): Add 'abs' keyword.
5231         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5232         (value_from_host_double): New function.
5233         (evaluate_subexp_f): Support UNOP_ABS.
5234
5235 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5236
5237         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5238         types.
5239
5240 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5241
5242         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5243         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5244         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5245
5246 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5247
5248         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5249
5250 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5251             Chris January  <chris.january@arm.com>
5252
5253         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5254         * f-exp.y: Define 'KIND' token.
5255         (exp): New pattern for KIND expressions.
5256         (ptype): Handle types with a kind extension.
5257         (direct_abs_decl): Extend to spot kind extensions.
5258         (f77_keywords): Add 'kind' to the list.
5259         (push_kind_type): New function.
5260         (convert_to_kind_type): New function.
5261         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5262         * parse.c (operator_length_standard): Likewise.
5263         * parser-defs.h (enum type_pieces): Add tp_kind.
5264         * std-operator.def: Add UNOP_KIND.
5265
5266 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5267
5268         * f-exp.y (f_parse): Set yydebug.
5269
5270 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5271
5272         * f-lang.c (evaluate_subexp_f): New function.
5273         (exp_descriptor_f): New global.
5274         (f_language_defn): Use exp_descriptor_f instead of
5275         exp_descriptor_standard.
5276
5277 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5278
5279         * f-exp.y (struct token): Add comments.
5280         (dot_ops): Remove uppercase versions and the end marker.
5281         (f77_keywords): Likewise.
5282         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5283         entries in the dot_ops array are case insensitive, and use
5284         strncasecmp to compare strings.  Also some whitespace cleanup in
5285         this area.  Similar for the f77_keywords array, except entries in
5286         this list might be case sensitive.
5287
5288 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5289
5290         * f-exp.y (struct f77_boolean_val): Add comments.
5291         (boolean_values): Remove uppercase versions, and end marker.
5292         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5293         and use strncasecmp to achieve case insensitivity.  Additionally,
5294         perform whitespace cleanup around this code.
5295
5296 2019-03-06  Tom Tromey  <tromey@adacore.com>
5297
5298         * remote-sim.c (gdbsim_target_open): Use result of
5299         gdb_argv::release.
5300
5301 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5302         Dirk Schubert  <dirk.schubert@arm.com>
5303         Chris January  <chris.january@arm.com>
5304
5305         * eval.c (evaluate_subexp_standard): Call Fortran argument
5306         wrapping logic.
5307         * f-lang.c (struct value): A value which can be passed into a
5308         Fortran function call.
5309         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5310         where appropriate.
5311         (struct type): Value ready for a Fortran function call.
5312         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5313         is needed.
5314         * f-lang.h (fortran_argument_convert): Declaration.
5315         (fortran_preserve_arg_pointer): Declaration.
5316         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5317
5318 2019-03-05  Tom Tromey  <tromey@adacore.com>
5319
5320         * python/py-prettyprint.c (print_string_repr): Remove #if.
5321         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5322
5323 2019-03-05  Tom Tromey  <tromey@adacore.com>
5324
5325         * target.c (the_dummy_target): Move later.  Change type to
5326         "dummy_target".
5327         (initialize_targets): Don't initialize the_dummy_target.
5328
5329 2019-03-05  Tom Tromey  <tromey@adacore.com>
5330
5331         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5332         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5333
5334 2019-03-05  Tom Tromey  <tromey@adacore.com>
5335
5336         * windows-nat.c (windows_nat_target::attach)
5337         (windows_nat_target::detach): Don't call gdb_flush.
5338         * valprint.c (generic_val_print, val_print, val_print_string):
5339         Don't call gdb_flush.
5340         * utils.c (defaulted_query): Don't call gdb_flush.
5341         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5342         * target.c (target_announce_detach): Don't call gdb_flush.
5343         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5344         * remote.c (extended_remote_target::attach): Don't call
5345         gdb_flush.
5346         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5347         * printcmd.c (do_examine): Don't call gdb_flush.
5348         (info_display_command): Don't call gdb_flush.
5349         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5350         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5351         * memattr.c (info_mem_command): Don't call gdb_flush.
5352         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5353         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5354         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5355         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5356         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5357         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5358         (gnu_nat_target::detach): Don't call gdb_flush.
5359         * f-valprint.c (f_val_print): Don't call gdb_flush.
5360         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5361         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5362         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5363         gdb_flush.
5364         * c-valprint.c (c_val_print): Don't call gdb_flush.
5365         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5366
5367 2019-03-05  Tom Tromey  <tromey@adacore.com>
5368
5369         * varobj.c (update_dynamic_varobj_children): Update.
5370         (install_default_visualizer): Use reset, not release.
5371         * value.c (set_internalvar): Update.
5372         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5373         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5374         ATTRIBUTE_UNUSED_RESULT.
5375
5376 2019-03-05  Tom Tromey  <tromey@adacore.com>
5377
5378         * remote.c (class scoped_remote_fd) <release>: Add
5379         ATTRIBUTE_UNUSED_RESULT.
5380
5381 2019-03-05  Tom Tromey  <tromey@adacore.com>
5382
5383         * macroexp.c (struct macro_buffer) <release>: Add
5384         ATTRIBUTE_UNUSED_RESULT.
5385
5386 2019-03-05  Tom Tromey  <tromey@adacore.com>
5387
5388         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5389         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5390         ATTRIBUTE_UNUSED_RESULT.
5391
5392 2019-03-05  Tom Tromey  <tromey@adacore.com>
5393
5394         * common/scoped_fd.h (class scoped_fd) <release>: Add
5395         ATTRIBUTE_UNUSED_RESULT.
5396
5397 2019-03-05  Tom Tromey  <tromey@adacore.com>
5398
5399         * parser-defs.h (struct parser_state) <release>: Add
5400         ATTRIBUTE_UNUSED_RESULT.
5401
5402 2019-03-05  Tom Tromey  <tromey@adacore.com>
5403
5404         * utils.h (class gdb_argv) <release>: Add
5405         ATTRIBUTE_UNUSED_RESULT.
5406         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5407
5408 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5409
5410         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5411         for-loop range, to avoid compiler warnings.
5412
5413         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5414         avoid compiler warnings about unused variables.
5415
5416         * NEWS: Mention end of support for native debugging on MS-Windows
5417         before XP.
5418
5419         PR gdb/24292
5420         * common/netstuff.c:
5421         * gdbserver/gdbreplay.c
5422         * gdbserver/remote-utils.c:
5423         * ser-tcp.c:
5424         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5425         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5426         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5427         'getaddrinfo' and 'freeaddrinfo' were not available before
5428         Windows XP, and mingw.org's MinGW headers by default define
5429         _WIN32_WINNT to 0x500.
5430
5431 2019-03-01  Gary Benson <gbenson@redhat.com>
5432
5433         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5434
5435 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5436             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5437
5438         PR gdb/8527
5439         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5440         set_sigint_trap, clear_sigint_trap.
5441
5442 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5443
5444         * target.c (target_detach): Clear the regcache and the
5445         frame cache.
5446
5447 2019-02-27  Pedro Alves  <palves@redhat.com>
5448
5449         * utils.c (set_screen_size): When we cap the height/width sizes,
5450         tweak the corresponding command variable to show "unlimited":
5451
5452 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5453             Pedro Alves  <palves@redhat.com>
5454
5455         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5456         before calling rl_set_screen_size.
5457
5458 2019-02-27  Tom Tromey  <tromey@adacore.com>
5459
5460         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5461         define.
5462         * python/py-value.c: Remove Python 2.4 workaround.
5463         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5464         workaround.
5465         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5466         Python 2.4 workaround.
5467         * python/python-internal.h: Remove Python 2.4 comment.
5468         (Py_ssize_t): Don't define.
5469         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5470         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5471         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5472         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5473         * python/python.c (do_start_initialization): Remove Python 2.4
5474         workaround.
5475         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5476         (print_children): Remove Python 2.4 workaround.
5477         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5478         workaround.
5479         (CHARBUFFERPROC_NAME): Remove.
5480         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5481         Python 2.4 workaround.
5482
5483 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5484
5485         * NEWS: Note minimum Python version.
5486
5487 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5488
5489         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5490         code from these functions.  Remove corresponding ifdefs.  Use
5491         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5492         Remove gotos and target of gotos.
5493         (infpy_search_memory): Likewise.
5494
5495 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5496
5497         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5498         (hppa_gdbarch_init): Don't register deleted functions with
5499         gdbarch.
5500
5501 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5502
5503         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5504         (h8300_unwind_sp): Delete.
5505         (h8300_dummy_id): Delete.
5506         (h8300_gdbarch_init): Don't register deleted functions with
5507         gdbarch.
5508
5509 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5510
5511         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5512         (ft32_unwind_pc): Delete.
5513         (ft32_unwind_sp): Delete.
5514         (ft32_gdbarch_init): Don't register deleted functions with
5515         gdbarch.
5516
5517 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5518
5519         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5520         (frv_unwind_pc): Delete.
5521         (frv_unwind_sp): Delete.
5522         (frv_gdbarch_init): Don't register deleted functions with
5523         gdbarch.
5524
5525 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5526
5527         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5528         (riscv_unwind_pc): Delete.
5529         (riscv_unwind_sp): Delete.
5530         (riscv_gdbarch_init): Don't register deleted functions with
5531         gdbarch.
5532
5533 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5534
5535         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5536         (csky_unwind_pc): Delete.
5537         (csky_unwind_sp): Delete.
5538         (csky_gdbarch_init): Don't register deleted functions with
5539         gdbarch.
5540
5541 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5542
5543         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5544         (cris_unwind_pc): Delete.
5545         (cris_unwind_sp): Delete.
5546         (cris_gdbarch_init): Don't register deleted functions with
5547         gdbarch.
5548
5549 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5550
5551         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5552         (bfin_unwind_pc): Delete.
5553         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5554
5555 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5556
5557         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5558         (arm_unwind_pc): Delete.
5559         (arm_unwind_sp): Delete.
5560         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5561
5562 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5563
5564         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5565         (arc_unwind_pc): Delete.
5566         (arc_unwind_sp): Delete.
5567         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5568
5569 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5570
5571         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5572         (alpha_unwind_pc): Delete.
5573         (alpha_gdbarch_init): Don't register deleted functions with
5574         gdbarch.
5575
5576 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5577
5578         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5579         (aarch64_unwind_pc): Delete.
5580         (aarch64_unwind_sp): Delete.
5581         (aarch64_gdbarch_init): Don't register deleted functions with
5582         gdbarch.
5583
5584 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5585
5586         * gdbtypes.c (type_align): Don't consider static members when
5587         computing structure alignment.
5588
5589 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5590
5591         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5592         return 0 for other types.
5593         * arch-utils.c (default_type_align): Always return 0.
5594         * gdbarch.h: Regenerate.
5595         * gdbarch.sh (type_align): Extend comment.
5596         * gdbtypes.c (type_align): Add additional comments, always call
5597         gdbarch_type_align before applying the default rules.
5598         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5599         generic code will then apply a suitable default.
5600         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5601         types, return 0 for other types.
5602
5603 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5604
5605         * NEWS: Create a new section for the next release branch.
5606         Rename the section of the current branch, now that it has
5607         been cut.
5608
5609 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5610
5611         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5612         * version.in: Bump version to 8.3.50.DATE-git.
5613
5614 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5615
5616         * aix-thread.c (ptid_cmp): Remove unused variable.
5617         (get_signaled_thread): Likewise.
5618         (store_regs_user_thread): Likewise.
5619         (store_regs_kernel_thread): Likewise.
5620         (fetch_regs_kernel_thread): Remove shadowed variable.
5621
5622 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5623
5624         * features/riscv/32bit-cpu.xml: Add register numbers.
5625         * features/riscv/32bit-fpu.c: Regenerate.
5626         * features/riscv/32bit-fpu.xml: Add register numbers.
5627         * features/riscv/64bit-cpu.xml: Add register numbers.
5628         * features/riscv/64bit-fpu.c: Regenerate.
5629         * features/riscv/64bit-fpu.xml: Add register numbers.
5630
5631 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5632
5633         * NEWS: Mention two argument form of gdb.Value constructor.
5634         * python/py-value.c (convert_buffer_and_type_to_value): New
5635         function.
5636         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5637         Add support for handling an optional second argument.  Call
5638         convert_buffer_and_type_to_value as appropriate.
5639         * python/python-internal.h (Py_buffer_deleter): New struct.
5640         (Py_buffer_up): New typedef.
5641
5642 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5643
5644         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5645         instead of releasing ownership.
5646
5647 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5648
5649         * dwarf2read.c (open_and_init_dwp_file): Call
5650         elf_numsections instead of bfd_count_sections to initialize
5651         dwp_file->num_sections.
5652
5653 2019-02-25  Tom Tromey  <tromey@adacore.com>
5654
5655         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5656
5657 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5658
5659         * gcore.in: Add '--readnever' option when invoking GDB.
5660
5661 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5662
5663         * MAINTAINERS: Update my email address.
5664
5665 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5666
5667         * build-id.c (build_id_to_debug_bfd_1): New function.
5668         (build_id_to_debug_bfd): Look for separate debug file in
5669         sysroot.
5670
5671 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5672
5673         * gdbarch.sh: Update the copyright year range that is placed into
5674         generated files.
5675
5676 2019-02-22  Keith Seitz  <keiths@redhat.com>
5677
5678         PR symtab/23853
5679         * linespec.c (create_sals_line_offset): Search for the default
5680         symtab's filename instead of its fullname.
5681
5682 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5683
5684         * NEWS: Update style defaults.
5685
5686 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5687
5688         * main.c (captured_main_1): Disable styling in batch mode.
5689
5690 2019-02-20  Tom Tromey  <tom@tromey.com>
5691
5692         * symtab.c (symtab_symbol_info): Fix typos.
5693
5694 2019-02-20  Tom Tromey  <tromey@adacore.com>
5695
5696         * findcmd.c (_initialize_mem_search): Use upper case for
5697         metasyntactic variables.
5698
5699 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5700
5701         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5702         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5703
5704 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5705
5706         * top.h (source_file_name): Change to std::string.
5707         * top.c (source_file_name): Likewise.
5708         (command_line_input): Adjust.
5709         * cli/cli-script.c (script_from_file): Adjust.
5710
5711 2019-02-19  Tom Tromey  <tromey@adacore.com>
5712
5713         * ravenscar-thread.c
5714         (ravenscar_thread_target::update_thread_list): Don't call
5715         ada_build_task_list.
5716         * ada-lang.h (ada_build_task_list): Don't declare.
5717         * ada-tasks.c (struct ada_tasks_inferior_data)
5718         <task_list_valid_p>: Now bool.
5719         (read_known_tasks, ada_task_list_changed)
5720         (ada_tasks_invalidate_inferior_data): Update.
5721         (read_known_tasks_array): Return bool.
5722         (read_known_tasks_list): Likewise.
5723         (read_known_tasks): Return void.
5724         (ada_build_task_list): Now static.
5725
5726 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5727
5728         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5729         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5730
5731 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5732
5733         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5734         variant for ada_tasks_pspace_data_handle and
5735         ada_tasks_inferior_data_handle.
5736         (ada_tasks_pspace_data_cleanup): New function.
5737         (ada_tasks_inferior_data_cleanup): New function.
5738
5739 2019-02-17  Tom Tromey  <tom@tromey.com>
5740
5741         * macrotab.h (macro_source_fullname): Return a std::string.
5742         * macrotab.c (macro_include, check_for_redefinition)
5743         (macro_undef, macro_lookup_definition, foreach_macro)
5744         (foreach_macro_in_scope): Update.
5745         (macro_source_fullname): Return a std::string.
5746         * macrocmd.c (show_pp_source_pos): Update.
5747
5748 2019-02-17  Tom Tromey  <tom@tromey.com>
5749
5750         * macrocmd.c (show_pp_source_pos): Style the file names.
5751
5752 2019-02-17  Tom Tromey  <tom@tromey.com>
5753
5754         PR tui/24197:
5755         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5756
5757 2019-02-17  Tom Tromey  <tom@tromey.com>
5758
5759         * ada-lang.c (user_select_syms): Use filtered printing.
5760         * utils.c (wrap_style): New global.
5761         (desired_style): Remove.
5762         (emit_style_escape): Add stream parameter.
5763         (set_output_style, reset_terminal_style, prompt_for_continue):
5764         Update.
5765         (flush_wrap_buffer): Only flush gdb_stdout.
5766         (wrap_here): Set wrap_style.
5767         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5768         treat escape sequences as a character.  Change when wrap buffer is
5769         flushed.
5770         (fputs_styled): Do not set the output style when the default is
5771         requested.
5772         * ui-style.h (struct ui_file_style) <is_default>: New method.
5773         * source.c (print_source_lines_base): Emit escape sequences in one
5774         piece.
5775
5776 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5777
5778         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5779         integers and enumeration types.
5780
5781 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5782
5783         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5784         instead of lookup_symbol_in_language
5785         (do_exact_match): New function.
5786         (ada_get_symbol_name_matcher): Return do_exact_match when
5787         doing a verbatim match.
5788
5789 2019-02-15  Tom Tromey  <tromey@adacore.com>
5790
5791         * ravenscar-thread.c (ravenscar_thread_target::resume)
5792         (ravenscar_thread_target::wait): Special case wildcard requests.
5793
5794 2019-02-15  Tom Tromey  <tromey@adacore.com>
5795
5796         * ravenscar-thread.c (base_ptid): Remove.
5797         (struct ravenscar_thread_target) <close>: New method.
5798         <m_base_ptid>: New member.
5799         <update_inferior_ptid, active_task, task_is_currently_active,
5800         runtime_initialized>: Declare methods.
5801         <ravenscar_thread_target>: Add constructor.
5802         (ravenscar_thread_target::task_is_currently_active)
5803         (ravenscar_thread_target::update_inferior_ptid)
5804         (ravenscar_runtime_initialized): Rename.  Now methods.
5805         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5806         (ravenscar_thread_target::update_thread_list): Update.
5807         (ravenscar_thread_target::active_task): Now method.
5808         (ravenscar_thread_target::store_registers)
5809         (ravenscar_thread_target::prepare_to_store)
5810         (ravenscar_thread_target::prepare_to_store)
5811         (ravenscar_thread_target::mourn_inferior): Update.
5812         (ravenscar_inferior_created): Use "new" to create target.
5813         (ravenscar_thread_target::get_ada_task_ptid): Update.
5814         (_initialize_ravenscar): Don't initialize base_ptid.
5815         (ravenscar_ops): Remove global.
5816
5817 2019-02-15  Tom Tromey  <tromey@adacore.com>
5818
5819         * target.h (push_target): Declare new overload.
5820         * target.c (push_target): New overload, taking an rvalue reference.
5821         * remote.c (remote_target::open_1): Use push_target overload.
5822         * corelow.c (core_target_open): Use push_target overload.
5823
5824 2019-02-15  Tom Tromey  <tromey@adacore.com>
5825
5826         * ravenscar-thread.c (is_ravenscar_task)
5827         (ravenscar_task_is_currently_active): Return bool.
5828         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5829         (_initialize_ravenscar): Remove "(void)".
5830         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5831         Return bool.
5832
5833 2019-02-15  Tom Tromey  <tromey@adacore.com>
5834
5835         * ravenscar-thread.c (ravenscar_runtime_initializer)
5836         (has_ravenscar_runtime, get_running_thread_id)
5837         (ravenscar_thread_target::resume): Fix indentation.
5838
5839 2019-02-15  Tom Tromey  <tromey@adacore.com>
5840
5841         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5842         from ravenscar_arch_ops.
5843         (sparc_ravenscar_ops::fetch_registers)
5844         (sparc_ravenscar_ops::store_registers): Now methods.
5845         (sparc_ravenscar_prepare_to_store): Remove.
5846         (sparc_ravenscar_ops): Redefine.
5847         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5848         methods and destructor.  Remove members.
5849         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5850         (ravenscar_thread_target::store_registers)
5851         (ravenscar_thread_target::prepare_to_store): Update.
5852         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5853         Remove.
5854         (struct ppc_ravenscar_powerpc_ops): Derive from
5855         ravenscar_arch_ops.
5856         (ppc_ravenscar_powerpc_ops::fetch_registers)
5857         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5858         (ppc_ravenscar_powerpc_ops): Redefine.
5859         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5860         (ppc_ravenscar_e500_ops::fetch_registers)
5861         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5862         (ppc_ravenscar_e500_ops): Redefine.
5863         * aarch64-ravenscar-thread.c
5864         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5865         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5866         (aarch64_ravenscar_fetch_registers)
5867         (aarch64_ravenscar_store_registers): Now methods.
5868         (aarch64_ravenscar_ops): Redefine.
5869
5870 2019-02-15  Tom Tromey  <tromey@adacore.com>
5871
5872         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5873         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5874         (ravenscar_thread_target::stopped_by_watchpoint)
5875         (ravenscar_thread_target::stopped_data_address)
5876         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5877
5878 2019-02-15  Tom Tromey  <tromey@adacore.com>
5879
5880         * ravenscar-thread.c: Fix some typos.
5881
5882 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5883             Tom Tromey  <tromey@adacore.com>
5884
5885         * ada-lang.c (ada_exception_sal): Change addr_string to a
5886         std::string.
5887         (create_ada_exception_catchpoint): Update.
5888
5889 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5890             Tom Tromey  <tromey@adacore.com>
5891
5892         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5893         (bp_location_ops): Remove.
5894         (base_breakpoint_allocate_location): Update.
5895         (free_bp_location): Update.
5896         * ada-lang.c (class ada_catchpoint_location)
5897         <ada_catchpoint_location>: Remove ops parameter.
5898         (ada_catchpoint_location_dtor): Remove.
5899         (ada_catchpoint_location_ops): Remove.
5900         (allocate_location_exception): Update.
5901         * breakpoint.h (struct bp_location_ops): Remove.
5902         (class bp_location) <bp_location>: Remove bp_location_ops
5903         parameter.
5904         <~bp_location>: Add destructor.
5905         <ops>: Remove.
5906
5907 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5908             Pedro Alves  <palves@redhat.com>
5909
5910         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5911         'PATH_MAX'.
5912
5913 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5914             Samuel Thibault  <samuel.thibault@gnu.org>
5915             Thomas Schwinge  <thomas@codesourcery.com>
5916
5917         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5918         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5919
5920 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5921
5922         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5923         (check_empty): Use "const char *".
5924
5925         * gnu-nat.c (gnu_nat_target::detach): Instead of
5926         'detach_inferior (pid)' call
5927         'detach_inferior (find_inferior_pid (pid))'.
5928
5929         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5930         'nat/fork-inferior.o'.
5931         * gnu-nat.c: #include "nat/fork-inferior.h".
5932
5933         * gnu-nat.c (gnu_nat_target::detach): Instead of
5934         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5935         * gnu-nat.h: #include "inf-child.h".
5936         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5937         'i386_gnu_nat_target::fetch_registers'.
5938         (gnu_store_registers): Rename/move to
5939         'i386_gnu_nat_target::store_registers'.
5940
5941         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5942         * gnu-nat.h (mach_thread_info): New function.
5943         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5944
5945         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5946
5947 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5948
5949         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5950
5951 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5952
5953         * windows-nat.c (windows_add_thread): Add new parameter
5954         "main_thread_p" with default value set to false.  Update
5955         function documentation as well as all callers.
5956         (windows_delete_thread): Likewise.
5957         (fake_create_process): Update call to windows_add_thread.
5958         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5959         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5960         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5961         call to windows_delete_thread.
5962
5963 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5964
5965         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5966
5967 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5968
5969         * symfile.c (find_separate_debug_file): Use canonical path of
5970         sysroot with child_path instead of gdb_sysroot if it is valid.
5971
5972 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5973
5974         * symfile.c (find_separate_debug_file): Use child_path to
5975         determine if an object file is under a sysroot.
5976
5977 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5978
5979         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5980         unittests/child-path-selftests.c.
5981         * common/pathstuff.c (child_path): New function.
5982         * common/pathstuff.h (child_path): New prototype.
5983         * unittests/child-path-selftests.c: New file.
5984
5985 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5986
5987         * symfile.c (find_separate_debug_file): Look for separate debug
5988         files in debug directories under the sysroot.
5989
5990 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5991
5992         * symtab.h (struct minimal_symbol data_p): New const method.
5993         (struct minimal_symbol text_p): Likewise.
5994         * symtab.c (output_source_filename): Use file name style
5995         to print file name.
5996         (print_symbol_info): Likewise.
5997         (print_msymbol_info): Use address style to print addresses.
5998         Use function name style to print executable text symbols.
5999         (expand_symtab_containing_pc): Use data_p.
6000         (find_pc_sect_compunit_symtab): Likewise.
6001
6002 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6003
6004         * breakpoint.c (describe_other_breakpoints): Use address style
6005         to print addresses.
6006         (say_where): Likewise.
6007
6008 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6009
6010         * ada-typeprint.c (print_func_type): Print function name
6011         style to print function name.
6012         * c-typeprint.c (c_print_type_1): Likewise.
6013
6014 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6015
6016         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6017         for execve.
6018
6019 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6020
6021         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6022         type_stack.
6023
6024 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6025
6026         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6027         TYPE_CODE_REF types.
6028
6029 2019-02-08  Jim Wilson  <jimw@sifive.com>
6030
6031         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6032         (riscv_linux_fregset): New.
6033         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6034
6035 2019-02-07  Tom Tromey  <tom@tromey.com>
6036
6037         * thread.c (thread_cancel_execution_command): Update.
6038         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6039         methods.
6040         (struct thread_fsm_ops): Remove.
6041         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6042         (thread_fsm_should_stop, thread_fsm_return_value)
6043         (thread_fsm_set_finished, thread_fsm_finished_p)
6044         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6045         Don't declare.
6046         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6047         * infrun.c (clear_proceed_status_thread)
6048         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6049         (print_stop_event): Update.
6050         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6051         Add constructor.
6052         (step_command_fsm_ops): Remove.
6053         (new_step_command_fsm): Remove.
6054         (step_1): Update.
6055         (step_command_fsm::should_stop): Rename from
6056         step_command_fsm_should_stop.
6057         (step_command_fsm::clean_up): Rename from
6058         step_command_fsm_clean_up.
6059         (step_command_fsm::do_async_reply_reason): Rename from
6060         step_command_fsm_async_reply_reason.
6061         (struct until_next_fsm): Inherit from thread_fsm.  Add
6062         constructor.
6063         (until_next_fsm_ops): Remove.
6064         (new_until_next_fsm): Remove.
6065         (until_next_fsm::should_stop): Rename from
6066         until_next_fsm_should_stop.
6067         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6068         (until_next_fsm::do_async_reply_reason): Rename from
6069         until_next_fsm_async_reply_reason.
6070         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6071         constructor.  Change type of breakpoint.
6072         (finish_command_fsm_ops): Remove.
6073         (new_finish_command_fsm): Remove.
6074         (finish_command_fsm::should_stop): Rename from
6075         finish_command_fsm_should_stop.
6076         (finish_command_fsm::clean_up): Rename from
6077         finish_command_fsm_clean_up.
6078         (finish_command_fsm::return_value): Rename from
6079         finish_command_fsm_return_value.
6080         (finish_command_fsm::do_async_reply_reason): Rename from
6081         finish_command_fsm_async_reply_reason.
6082         (finish_command): Update.
6083         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6084         Add constructor.
6085         (call_thread_fsm_ops): Remove.
6086         (call_thread_fsm::call_thread_fsm): Rename from
6087         new_call_thread_fsm.
6088         (call_thread_fsm::should_stop): Rename from
6089         call_thread_fsm_should_stop.
6090         (call_thread_fsm::should_notify_stop): Rename from
6091         call_thread_fsm_should_notify_stop.
6092         (run_inferior_call, call_function_by_hand_dummy): Update.
6093         * cli/cli-interp.c (should_print_stop_to_console): Update.
6094         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6095         Add constructor.  Change type of location_breakpoint,
6096         caller_breakpoint.
6097         (until_break_fsm_ops): Remove.
6098         (new_until_break_fsm): Remove.
6099         (until_break_fsm::should_stop): Rename from
6100         until_break_fsm_should_stop.
6101         (until_break_fsm::clean_up): Rename from
6102         until_break_fsm_clean_up.
6103         (until_break_fsm::do_async_reply_reason): Rename from
6104         until_break_fsm_async_reply_reason.
6105         (until_break_command): Update.
6106         * thread-fsm.c: Remove.
6107         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6108
6109 2019-02-07  Tom Tromey  <tom@tromey.com>
6110
6111         * yy-remap.h: Add include guard.
6112         * xtensa-tdep.h: Add include guard.
6113         * xcoffread.h: Rename include guard.
6114         * varobj-iter.h: Add include guard.
6115         * tui/tui.h: Rename include guard.
6116         * tui/tui-winsource.h: Rename include guard.
6117         * tui/tui-wingeneral.h: Rename include guard.
6118         * tui/tui-windata.h: Rename include guard.
6119         * tui/tui-win.h: Rename include guard.
6120         * tui/tui-stack.h: Rename include guard.
6121         * tui/tui-source.h: Rename include guard.
6122         * tui/tui-regs.h: Rename include guard.
6123         * tui/tui-out.h: Rename include guard.
6124         * tui/tui-layout.h: Rename include guard.
6125         * tui/tui-io.h: Rename include guard.
6126         * tui/tui-hooks.h: Rename include guard.
6127         * tui/tui-file.h: Rename include guard.
6128         * tui/tui-disasm.h: Rename include guard.
6129         * tui/tui-data.h: Rename include guard.
6130         * tui/tui-command.h: Rename include guard.
6131         * tic6x-tdep.h: Add include guard.
6132         * target/waitstatus.h: Rename include guard.
6133         * target/wait.h: Rename include guard.
6134         * target/target.h: Rename include guard.
6135         * target/resume.h: Rename include guard.
6136         * target-float.h: Rename include guard.
6137         * stabsread.h: Add include guard.
6138         * rs6000-tdep.h: Add include guard.
6139         * riscv-fbsd-tdep.h: Add include guard.
6140         * regformats/regdef.h: Rename include guard.
6141         * record.h: Rename include guard.
6142         * python/python.h: Rename include guard.
6143         * python/python-internal.h: Rename include guard.
6144         * python/py-stopevent.h: Rename include guard.
6145         * python/py-ref.h: Rename include guard.
6146         * python/py-record.h: Rename include guard.
6147         * python/py-record-full.h: Rename include guard.
6148         * python/py-record-btrace.h: Rename include guard.
6149         * python/py-instruction.h: Rename include guard.
6150         * python/py-events.h: Rename include guard.
6151         * python/py-event.h: Rename include guard.
6152         * procfs.h: Add include guard.
6153         * proc-utils.h: Add include guard.
6154         * p-lang.h: Add include guard.
6155         * or1k-tdep.h: Rename include guard.
6156         * observable.h: Rename include guard.
6157         * nto-tdep.h: Rename include guard.
6158         * nat/x86-linux.h: Rename include guard.
6159         * nat/x86-linux-dregs.h: Rename include guard.
6160         * nat/x86-gcc-cpuid.h: Add include guard.
6161         * nat/x86-dregs.h: Rename include guard.
6162         * nat/x86-cpuid.h: Rename include guard.
6163         * nat/ppc-linux.h: Rename include guard.
6164         * nat/mips-linux-watch.h: Rename include guard.
6165         * nat/linux-waitpid.h: Rename include guard.
6166         * nat/linux-ptrace.h: Rename include guard.
6167         * nat/linux-procfs.h: Rename include guard.
6168         * nat/linux-osdata.h: Rename include guard.
6169         * nat/linux-nat.h: Rename include guard.
6170         * nat/linux-namespaces.h: Rename include guard.
6171         * nat/linux-btrace.h: Rename include guard.
6172         * nat/glibc_thread_db.h: Rename include guard.
6173         * nat/gdb_thread_db.h: Rename include guard.
6174         * nat/gdb_ptrace.h: Rename include guard.
6175         * nat/fork-inferior.h: Rename include guard.
6176         * nat/amd64-linux-siginfo.h: Rename include guard.
6177         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6178         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6179         * nat/aarch64-linux.h: Rename include guard.
6180         * nat/aarch64-linux-hw-point.h: Rename include guard.
6181         * mn10300-tdep.h: Add include guard.
6182         * mips-linux-tdep.h: Add include guard.
6183         * mi/mi-parse.h: Rename include guard.
6184         * mi/mi-out.h: Rename include guard.
6185         * mi/mi-main.h: Rename include guard.
6186         * mi/mi-interp.h: Rename include guard.
6187         * mi/mi-getopt.h: Rename include guard.
6188         * mi/mi-console.h: Rename include guard.
6189         * mi/mi-common.h: Rename include guard.
6190         * mi/mi-cmds.h: Rename include guard.
6191         * mi/mi-cmd-break.h: Rename include guard.
6192         * m2-lang.h: Add include guard.
6193         * location.h: Rename include guard.
6194         * linux-record.h: Rename include guard.
6195         * linux-nat.h: Add include guard.
6196         * linux-fork.h: Add include guard.
6197         * i386-darwin-tdep.h: Rename include guard.
6198         * hppa-linux-offsets.h: Add include guard.
6199         * guile/guile.h: Rename include guard.
6200         * guile/guile-internal.h: Rename include guard.
6201         * gnu-nat.h: Rename include guard.
6202         * gdb-stabs.h: Rename include guard.
6203         * frv-tdep.h: Add include guard.
6204         * f-lang.h: Add include guard.
6205         * event-loop.h: Add include guard.
6206         * darwin-nat.h: Rename include guard.
6207         * cp-abi.h: Rename include guard.
6208         * config/sparc/nm-sol2.h: Rename include guard.
6209         * config/nm-nto.h: Rename include guard.
6210         * config/nm-linux.h: Add include guard.
6211         * config/i386/nm-i386gnu.h: Rename include guard.
6212         * config/djgpp/nl_types.h: Rename include guard.
6213         * config/djgpp/langinfo.h: Rename include guard.
6214         * compile/gcc-cp-plugin.h: Add include guard.
6215         * compile/gcc-c-plugin.h: Add include guard.
6216         * compile/compile.h: Rename include guard.
6217         * compile/compile-object-run.h: Rename include guard.
6218         * compile/compile-object-load.h: Rename include guard.
6219         * compile/compile-internal.h: Rename include guard.
6220         * compile/compile-cplus.h: Rename include guard.
6221         * compile/compile-c.h: Rename include guard.
6222         * common/xml-utils.h: Rename include guard.
6223         * common/x86-xstate.h: Rename include guard.
6224         * common/version.h: Rename include guard.
6225         * common/vec.h: Rename include guard.
6226         * common/tdesc.h: Rename include guard.
6227         * common/selftest.h: Rename include guard.
6228         * common/scoped_restore.h: Rename include guard.
6229         * common/scoped_mmap.h: Rename include guard.
6230         * common/scoped_fd.h: Rename include guard.
6231         * common/safe-iterator.h: Rename include guard.
6232         * common/run-time-clock.h: Rename include guard.
6233         * common/refcounted-object.h: Rename include guard.
6234         * common/queue.h: Rename include guard.
6235         * common/ptid.h: Rename include guard.
6236         * common/print-utils.h: Rename include guard.
6237         * common/preprocessor.h: Rename include guard.
6238         * common/pathstuff.h: Rename include guard.
6239         * common/observable.h: Rename include guard.
6240         * common/netstuff.h: Rename include guard.
6241         * common/job-control.h: Rename include guard.
6242         * common/host-defs.h: Rename include guard.
6243         * common/gdb_wait.h: Rename include guard.
6244         * common/gdb_vecs.h: Rename include guard.
6245         * common/gdb_unlinker.h: Rename include guard.
6246         * common/gdb_unique_ptr.h: Rename include guard.
6247         * common/gdb_tilde_expand.h: Rename include guard.
6248         * common/gdb_sys_time.h: Rename include guard.
6249         * common/gdb_string_view.h: Rename include guard.
6250         * common/gdb_splay_tree.h: Rename include guard.
6251         * common/gdb_setjmp.h: Rename include guard.
6252         * common/gdb_ref_ptr.h: Rename include guard.
6253         * common/gdb_optional.h: Rename include guard.
6254         * common/gdb_locale.h: Rename include guard.
6255         * common/gdb_assert.h: Rename include guard.
6256         * common/filtered-iterator.h: Rename include guard.
6257         * common/filestuff.h: Rename include guard.
6258         * common/fileio.h: Rename include guard.
6259         * common/environ.h: Rename include guard.
6260         * common/common-utils.h: Rename include guard.
6261         * common/common-types.h: Rename include guard.
6262         * common/common-regcache.h: Rename include guard.
6263         * common/common-inferior.h: Rename include guard.
6264         * common/common-gdbthread.h: Rename include guard.
6265         * common/common-exceptions.h: Rename include guard.
6266         * common/common-defs.h: Rename include guard.
6267         * common/common-debug.h: Rename include guard.
6268         * common/cleanups.h: Rename include guard.
6269         * common/buffer.h: Rename include guard.
6270         * common/btrace-common.h: Rename include guard.
6271         * common/break-common.h: Rename include guard.
6272         * cli/cli-utils.h: Rename include guard.
6273         * cli/cli-style.h: Rename include guard.
6274         * cli/cli-setshow.h: Rename include guard.
6275         * cli/cli-script.h: Rename include guard.
6276         * cli/cli-interp.h: Rename include guard.
6277         * cli/cli-decode.h: Rename include guard.
6278         * cli/cli-cmds.h: Rename include guard.
6279         * charset-list.h: Add include guard.
6280         * buildsym-legacy.h: Rename include guard.
6281         * bfin-tdep.h: Add include guard.
6282         * ax.h: Rename include guard.
6283         * arm-linux-tdep.h: Add include guard.
6284         * arm-fbsd-tdep.h: Add include guard.
6285         * arch/xtensa.h: Rename include guard.
6286         * arch/tic6x.h: Add include guard.
6287         * arch/i386.h: Add include guard.
6288         * arch/arm.h: Rename include guard.
6289         * arch/arm-linux.h: Rename include guard.
6290         * arch/arm-get-next-pcs.h: Rename include guard.
6291         * arch/amd64.h: Add include guard.
6292         * arch/aarch64-insn.h: Rename include guard.
6293         * arch-utils.h: Rename include guard.
6294         * annotate.h: Add include guard.
6295         * amd64-darwin-tdep.h: Rename include guard.
6296         * aarch64-linux-tdep.h: Add include guard.
6297         * aarch64-fbsd-tdep.h: Add include guard.
6298         * aarch32-linux-nat.h: Add include guard.
6299
6300 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6301
6302         * macrotab.c (macro_define_internal): New function that
6303         factorizes macro_define_object_internal and macro_define_function
6304         code.
6305         (macro_define_object_internal): Use macro_define_internal.
6306         (macro_define_function): Likewise.
6307
6308 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6309
6310         * macrocmd.c (extract_identifier): Return
6311         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6312         callers.
6313
6314 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6315
6316         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6317
6318 2019-02-05  Tom Tromey  <tom@tromey.com>
6319
6320         * target.c (target_stack::unpush): Move assertion earlier.
6321
6322 2019-01-30  Tom Tromey  <tom@tromey.com>
6323
6324         PR python/23615:
6325         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6326         (gdbpy_parse_and_eval): Likewise.
6327         * python/python-internal.h (gdbpy_allow_threads): New class.
6328
6329 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6330
6331         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6332         (aarch64_fbsd_fpregmap): Move earlier.
6333         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6334         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6335         instead of individual calls to trad_frame_set_reg_addr.
6336         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6337         earlier.
6338         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6339         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6340         instead of individual calls to trad_frame_set_reg_addr.
6341
6342 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6343
6344         * CONTRIBUTE: Replace contribution list with wiki link.
6345
6346 2019-01-25  Tom Tromey  <tom@tromey.com>
6347
6348         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6349
6350 2019-01-25  Tom Tromey  <tom@tromey.com>
6351
6352         * xtensa-linux-nat.c: Fix common/ includes.
6353         * xml-support.h: Fix common/ includes.
6354         * xml-support.c: Fix common/ includes.
6355         * x86-linux-nat.c: Fix common/ includes.
6356         * windows-nat.c: Fix common/ includes.
6357         * varobj.h: Fix common/ includes.
6358         * varobj.c: Fix common/ includes.
6359         * value.c: Fix common/ includes.
6360         * valops.c: Fix common/ includes.
6361         * utils.c: Fix common/ includes.
6362         * unittests/xml-utils-selftests.c: Fix common/ includes.
6363         * unittests/utils-selftests.c: Fix common/ includes.
6364         * unittests/unpack-selftests.c: Fix common/ includes.
6365         * unittests/tracepoint-selftests.c: Fix common/ includes.
6366         * unittests/style-selftests.c: Fix common/ includes.
6367         * unittests/string_view-selftests.c: Fix common/ includes.
6368         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6369         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6370         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6371         * unittests/rsp-low-selftests.c: Fix common/ includes.
6372         * unittests/parse-connection-spec-selftests.c: Fix common/
6373         includes.
6374         * unittests/optional-selftests.c: Fix common/ includes.
6375         * unittests/offset-type-selftests.c: Fix common/ includes.
6376         * unittests/observable-selftests.c: Fix common/ includes.
6377         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6378         * unittests/memrange-selftests.c: Fix common/ includes.
6379         * unittests/memory-map-selftests.c: Fix common/ includes.
6380         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6381         * unittests/function-view-selftests.c: Fix common/ includes.
6382         * unittests/environ-selftests.c: Fix common/ includes.
6383         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6384         * unittests/common-utils-selftests.c: Fix common/ includes.
6385         * unittests/cli-utils-selftests.c: Fix common/ includes.
6386         * unittests/array-view-selftests.c: Fix common/ includes.
6387         * ui-file.c: Fix common/ includes.
6388         * tui/tui-io.c: Fix common/ includes.
6389         * tracepoint.h: Fix common/ includes.
6390         * tracepoint.c: Fix common/ includes.
6391         * tracefile-tfile.c: Fix common/ includes.
6392         * top.h: Fix common/ includes.
6393         * top.c: Fix common/ includes.
6394         * thread.c: Fix common/ includes.
6395         * target/waitstatus.h: Fix common/ includes.
6396         * target/waitstatus.c: Fix common/ includes.
6397         * target.h: Fix common/ includes.
6398         * target.c: Fix common/ includes.
6399         * target-memory.c: Fix common/ includes.
6400         * target-descriptions.c: Fix common/ includes.
6401         * symtab.h: Fix common/ includes.
6402         * symfile.c: Fix common/ includes.
6403         * stap-probe.c: Fix common/ includes.
6404         * spu-linux-nat.c: Fix common/ includes.
6405         * sparc-nat.c: Fix common/ includes.
6406         * source.c: Fix common/ includes.
6407         * solib.c: Fix common/ includes.
6408         * solib-target.c: Fix common/ includes.
6409         * ser-unix.c: Fix common/ includes.
6410         * ser-tcp.c: Fix common/ includes.
6411         * ser-pipe.c: Fix common/ includes.
6412         * ser-base.c: Fix common/ includes.
6413         * selftest-arch.c: Fix common/ includes.
6414         * s12z-tdep.c: Fix common/ includes.
6415         * rust-exp.y: Fix common/ includes.
6416         * rs6000-aix-tdep.c: Fix common/ includes.
6417         * riscv-tdep.c: Fix common/ includes.
6418         * remote.c: Fix common/ includes.
6419         * remote-notif.h: Fix common/ includes.
6420         * remote-fileio.h: Fix common/ includes.
6421         * remote-fileio.c: Fix common/ includes.
6422         * regcache.h: Fix common/ includes.
6423         * regcache.c: Fix common/ includes.
6424         * record-btrace.c: Fix common/ includes.
6425         * python/python.c: Fix common/ includes.
6426         * python/py-type.c: Fix common/ includes.
6427         * python/py-inferior.c: Fix common/ includes.
6428         * progspace.h: Fix common/ includes.
6429         * producer.c: Fix common/ includes.
6430         * procfs.c: Fix common/ includes.
6431         * proc-api.c: Fix common/ includes.
6432         * printcmd.c: Fix common/ includes.
6433         * ppc-linux-nat.c: Fix common/ includes.
6434         * parser-defs.h: Fix common/ includes.
6435         * osdata.c: Fix common/ includes.
6436         * obsd-nat.c: Fix common/ includes.
6437         * nat/x86-linux.c: Fix common/ includes.
6438         * nat/x86-linux-dregs.c: Fix common/ includes.
6439         * nat/x86-dregs.h: Fix common/ includes.
6440         * nat/x86-dregs.c: Fix common/ includes.
6441         * nat/ppc-linux.c: Fix common/ includes.
6442         * nat/mips-linux-watch.h: Fix common/ includes.
6443         * nat/mips-linux-watch.c: Fix common/ includes.
6444         * nat/linux-waitpid.c: Fix common/ includes.
6445         * nat/linux-ptrace.h: Fix common/ includes.
6446         * nat/linux-ptrace.c: Fix common/ includes.
6447         * nat/linux-procfs.c: Fix common/ includes.
6448         * nat/linux-personality.c: Fix common/ includes.
6449         * nat/linux-osdata.c: Fix common/ includes.
6450         * nat/linux-namespaces.c: Fix common/ includes.
6451         * nat/linux-btrace.h: Fix common/ includes.
6452         * nat/linux-btrace.c: Fix common/ includes.
6453         * nat/fork-inferior.c: Fix common/ includes.
6454         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6455         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6456         * nat/aarch64-linux.c: Fix common/ includes.
6457         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6458         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6459         * namespace.h: Fix common/ includes.
6460         * mips-linux-tdep.c: Fix common/ includes.
6461         * minsyms.c: Fix common/ includes.
6462         * mi/mi-parse.h: Fix common/ includes.
6463         * mi/mi-main.c: Fix common/ includes.
6464         * mi/mi-cmd-env.c: Fix common/ includes.
6465         * memrange.h: Fix common/ includes.
6466         * memattr.c: Fix common/ includes.
6467         * maint.h: Fix common/ includes.
6468         * maint.c: Fix common/ includes.
6469         * main.c: Fix common/ includes.
6470         * machoread.c: Fix common/ includes.
6471         * location.c: Fix common/ includes.
6472         * linux-thread-db.c: Fix common/ includes.
6473         * linux-nat.c: Fix common/ includes.
6474         * linux-fork.c: Fix common/ includes.
6475         * inline-frame.c: Fix common/ includes.
6476         * infrun.c: Fix common/ includes.
6477         * inflow.c: Fix common/ includes.
6478         * inferior.h: Fix common/ includes.
6479         * inferior.c: Fix common/ includes.
6480         * infcmd.c: Fix common/ includes.
6481         * inf-ptrace.c: Fix common/ includes.
6482         * inf-child.c: Fix common/ includes.
6483         * ia64-linux-nat.c: Fix common/ includes.
6484         * i387-tdep.c: Fix common/ includes.
6485         * i386-tdep.c: Fix common/ includes.
6486         * i386-linux-tdep.c: Fix common/ includes.
6487         * i386-linux-nat.c: Fix common/ includes.
6488         * i386-go32-tdep.c: Fix common/ includes.
6489         * i386-fbsd-tdep.c: Fix common/ includes.
6490         * i386-fbsd-nat.c: Fix common/ includes.
6491         * guile/scm-type.c: Fix common/ includes.
6492         * guile/guile.c: Fix common/ includes.
6493         * go32-nat.c: Fix common/ includes.
6494         * gnu-nat.c: Fix common/ includes.
6495         * gdbthread.h: Fix common/ includes.
6496         * gdbarch-selftests.c: Fix common/ includes.
6497         * gdb_usleep.c: Fix common/ includes.
6498         * gdb_select.h: Fix common/ includes.
6499         * gdb_bfd.c: Fix common/ includes.
6500         * gcore.c: Fix common/ includes.
6501         * fork-child.c: Fix common/ includes.
6502         * findvar.c: Fix common/ includes.
6503         * fbsd-nat.c: Fix common/ includes.
6504         * event-top.c: Fix common/ includes.
6505         * event-loop.c: Fix common/ includes.
6506         * dwarf2read.c: Fix common/ includes.
6507         * dwarf2loc.c: Fix common/ includes.
6508         * dwarf2-frame.c: Fix common/ includes.
6509         * dwarf-index-cache.c: Fix common/ includes.
6510         * dtrace-probe.c: Fix common/ includes.
6511         * disasm-selftests.c: Fix common/ includes.
6512         * defs.h: Fix common/ includes.
6513         * csky-tdep.c: Fix common/ includes.
6514         * cp-valprint.c: Fix common/ includes.
6515         * cp-support.h: Fix common/ includes.
6516         * cp-support.c: Fix common/ includes.
6517         * corelow.c: Fix common/ includes.
6518         * completer.h: Fix common/ includes.
6519         * completer.c: Fix common/ includes.
6520         * compile/compile.c: Fix common/ includes.
6521         * compile/compile-loc2c.c: Fix common/ includes.
6522         * compile/compile-cplus-types.c: Fix common/ includes.
6523         * compile/compile-cplus-symbols.c: Fix common/ includes.
6524         * command.h: Fix common/ includes.
6525         * cli/cli-dump.c: Fix common/ includes.
6526         * cli/cli-cmds.c: Fix common/ includes.
6527         * charset.c: Fix common/ includes.
6528         * build-id.c: Fix common/ includes.
6529         * btrace.h: Fix common/ includes.
6530         * btrace.c: Fix common/ includes.
6531         * breakpoint.h: Fix common/ includes.
6532         * breakpoint.c: Fix common/ includes.
6533         * ax.h:
6534         (enum agent_op): Fix common/ includes.
6535         * ax-general.c (struct aop_map): Fix common/ includes.
6536         * ax-gdb.c: Fix common/ includes.
6537         * auxv.c: Fix common/ includes.
6538         * auto-load.c: Fix common/ includes.
6539         * arm-tdep.c: Fix common/ includes.
6540         * arch/riscv.c: Fix common/ includes.
6541         * arch/ppc-linux-common.c: Fix common/ includes.
6542         * arch/i386.c: Fix common/ includes.
6543         * arch/arm.c: Fix common/ includes.
6544         * arch/arm-linux.c: Fix common/ includes.
6545         * arch/arm-get-next-pcs.c: Fix common/ includes.
6546         * arch/amd64.c: Fix common/ includes.
6547         * arch/aarch64.c: Fix common/ includes.
6548         * arch/aarch64-insn.c: Fix common/ includes.
6549         * arch-utils.c: Fix common/ includes.
6550         * amd64-windows-tdep.c: Fix common/ includes.
6551         * amd64-tdep.c: Fix common/ includes.
6552         * amd64-sol2-tdep.c: Fix common/ includes.
6553         * amd64-obsd-tdep.c: Fix common/ includes.
6554         * amd64-nbsd-tdep.c: Fix common/ includes.
6555         * amd64-linux-tdep.c: Fix common/ includes.
6556         * amd64-linux-nat.c: Fix common/ includes.
6557         * amd64-fbsd-tdep.c: Fix common/ includes.
6558         * amd64-fbsd-nat.c: Fix common/ includes.
6559         * amd64-dicos-tdep.c: Fix common/ includes.
6560         * amd64-darwin-tdep.c: Fix common/ includes.
6561         * agent.c: Fix common/ includes.
6562         * ada-lang.h: Fix common/ includes.
6563         * ada-lang.c: Fix common/ includes.
6564         * aarch64-tdep.c: Fix common/ includes.
6565
6566 2019-01-25  Tom Tromey  <tom@tromey.com>
6567
6568         * common/create-version.sh: Use common/version.h.
6569
6570 2019-01-24  Pedro Alves  <palves@redhat.com>
6571
6572         * infrun.c (signal_stop, signal_print, signal_program)
6573         (signal_catch, signal_pass): Now arrays instead of pointers.
6574         (update_signals_program_target, do_target_resume)
6575         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6576         * linux-nat.c (linux_nat_target::pass_signals)
6577         (linux_nat_target::create_inferior, linux_nat_target::attach):
6578         Adjust.
6579         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6580         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6581         * procfs.c (procfs_target::pass_signals): Adjust.
6582         * record-full.c (record_full_target::resume): Adjust.
6583         * remote.c (remote_target::pass_signals)
6584         (remote_target::program_signals): Adjust.
6585         * target-debug.h (target_debug_print_signals): Now takes a
6586         gdb::array_view as parameter.  Adjust.
6587         * target.h (target_ops) <pass_signals, program_signals>: Replace
6588         pointer and length parameters with gdb::array_view.
6589         (target_pass_signals, target_program_signals): Likewise.
6590         * target-delegates.c: Regenerate.
6591
6592 2019-01-24  Pedro Alves  <palves@redhat.com>
6593
6594         * common/forward-scope-exit.h
6595         (forward_scope_exit::forward_scope_exit): Pass arguments to
6596         m_bind_function directly, instead of creating a std::bind and
6597         copying that.
6598
6599 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6600
6601         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6602         for static members.
6603         (pass_in_v_vfp_candidate): Likewise.
6604
6605 2019-01-23  Tom Tromey  <tom@tromey.com>
6606             Pedro Alves  <palves@redhat.com>
6607
6608         * regcache.c (class regcache_invalidator): Remove.
6609         (regcache::raw_write): Use make_scope_exit.
6610
6611 2019-01-23  Tom Tromey  <tom@tromey.com>
6612
6613         * ui-out.h (class ui_out_emit_type): Update comment.
6614
6615 2019-01-23  Tom Tromey  <tom@tromey.com>
6616
6617         * infrun.c (fetch_inferior_event): Update comment.
6618
6619 2019-01-23  Tom Tromey  <tom@tromey.com>
6620             Pedro Alves  <palves@redhat.com>
6621
6622         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6623         parameter.
6624         (fetch_inferior_event): Use SCOPE_EXIT.
6625
6626
6627 2019-01-23  Tom Tromey  <tom@tromey.com>
6628             Pedro Alves  <palves@redhat.com>
6629
6630         * infrun.c (disable_thread_events): Delete.
6631         (stop_all_threads): Use SCOPE_EXIT.
6632
6633 2019-01-23  Tom Tromey  <tom@tromey.com>
6634             Pedro Alves  <palves@redhat.com>
6635
6636         * symfile.c: Include forward-scope-exit.h.
6637         (clear_symtab_users_cleanup): Replace forward declaration with
6638         a FORWARD_SCOPE_EXIT.
6639         (syms_from_objfile_1): Use the forward_scope_exit and
6640         gdb::optional instead of cleanup_function.
6641         (reread_symbols): Use the forward_scope_exit instead of
6642         cleanup_function.
6643         (clear_symtab_users_cleanup): Remove function.
6644
6645 2019-01-23  Tom Tromey  <tom@tromey.com>
6646             Pedro Alves  <palves@redhat.com>
6647
6648         * linux-nat.c: Include scope-exit.h.
6649         (cleanup_target_stop): Remove.
6650         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6651         SCOPE_EXIT.
6652
6653 2019-01-23  Tom Tromey  <tom@tromey.com>
6654             Pedro Alves  <palves@redhat.com>
6655
6656         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6657         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6658
6659 2019-01-23  Tom Tromey  <tom@tromey.com>
6660             Andrew Burgess  <andrew.burgess@embecosm.com>
6661             Pedro Alves  <palves@redhat.com>
6662
6663         * infrun.c (fetch_inferior_event): Use scope_exit.
6664         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6665         * top.c (execute_command): Use scope_exit.
6666         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6667         * utils.c (do_bpstat_clear_actions_cleanup)
6668         (make_bpstat_clear_actions_cleanup): Remove.
6669
6670 2019-01-23  Tom Tromey  <tom@tromey.com>
6671             Pedro Alves  <palves@redhat.com>
6672
6673         * infrun.c: Include "common/scope-exit.h"
6674         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6675         (wait_for_inferior): Use SCOPE_EXIT.
6676         (fetch_inferior_event): Use scope_exit.
6677
6678 2019-01-23  Tom Tromey  <tom@tromey.com>
6679             Pedro Alves  <palves@redhat.com>
6680
6681         * breakpoint.c (create_breakpoint): Remove cleanup.
6682
6683 2019-01-23  Tom Tromey  <tom@tromey.com>
6684             Andrew Burgess  <andrew.burgess@embecosm.com>
6685             Pedro Alves  <palves@redhat.com>
6686
6687 2019-01-23  Pedro Alves  <palves@redhat.com>
6688
6689         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6690
6691 2019-01-23  Pedro Alves  <palves@redhat.com>
6692             Andrew Burgess  <andrew.burgess@embecosm.com>
6693
6694         * gdbthread.h: Include "common/forward-scope-exit.h".
6695         (scoped_finish_thread_state): Redefine custom class in terms of
6696         forward_scope_exit.
6697
6698 2019-01-23  Pedro Alves  <palves@redhat.com>
6699             Andrew Burgess  <andrew.burgess@embecosm.com>
6700
6701         * common/forward-scope-exit.h: New file.
6702
6703 2019-01-23  Pedro Alves  <palves@redhat.com>
6704             Andrew Burgess  <andrew.burgess@embecosm.com>
6705             Tom Tromey  <tom@tromey.com>
6706
6707         * common/scope-exit.h: New file.
6708
6709 2019-01-23  Pedro Alves  <palves@redhat.com>
6710
6711         * common/preprocessor.h (ESC): Rename to ...
6712         (ESC_PARENS): ... this.
6713         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6714         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6715
6716 2019-01-23  Tom Tromey  <tom@tromey.com>
6717
6718         * language.h (class scoped_switch_to_sym_language_if_auto):
6719         Initialize m_lang in both cases.
6720
6721 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6722
6723         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6724         with XCNEW.
6725
6726 2019-01-22  Tom Tromey  <tom@tromey.com>
6727
6728         * corelow.c: Do not include sys/file.h.
6729
6730 2019-01-22  Tom Tromey  <tom@tromey.com>
6731
6732         * tui/tui-wingeneral.h: Include gdb_curses.h.
6733
6734 2019-01-22  Tom Tromey  <tom@tromey.com>
6735
6736         * source-cache.h (class source_cache) <get_source_lines,
6737         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6738
6739 2019-01-22  Tom Tromey  <tom@tromey.com>
6740
6741         * remote-fileio.h (struct remote_target): Declare.
6742
6743 2019-01-22  Tom Tromey  <tom@tromey.com>
6744
6745         * python/py-arch.c: Do not include py-ref.h.
6746         * python/py-bpevent.c: Do not include py-ref.h.
6747         * python/py-cmd.c: Do not include py-ref.h.
6748         * python/py-continueevent.c: Do not include py-ref.h.
6749         * python/py-event.h: Do not include py-ref.h.
6750         * python/py-evtregistry.c: Do not include py-ref.h.
6751         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6752         * python/py-frame.c: Do not include py-ref.h.
6753         * python/py-framefilter.c: Do not include py-ref.h.
6754         * python/py-function.c: Do not include py-ref.h.
6755         * python/py-infevents.c: Do not include py-ref.h.
6756         * python/py-linetable.c: Do not include py-ref.h.
6757         * python/py-objfile.c: Do not include py-ref.h.
6758         * python/py-param.c: Do not include py-ref.h.
6759         * python/py-prettyprint.c: Do not include py-ref.h.
6760         * python/py-progspace.c: Do not include py-ref.h.
6761         * python/py-symbol.c: Do not include py-ref.h.
6762         * python/py-symtab.c: Do not include py-ref.h.
6763         * python/py-type.c: Do not include py-ref.h.
6764         * python/py-unwind.c: Do not include py-ref.h.
6765         * python/py-utils.c: Do not include py-ref.h.
6766         * python/py-value.c: Do not include py-ref.h.
6767         * python/py-varobj.c: Do not include py-ref.h.
6768         * python/py-xmethods.c: Do not include py-ref.h.
6769         * python/python.c: Do not include py-ref.h.
6770         * varobj.c: Do not include py-ref.h.
6771
6772 2019-01-22  Tom Tromey  <tom@tromey.com>
6773
6774         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6775         keyword for bcache.
6776
6777 2019-01-22  Tom Tromey  <tom@tromey.com>
6778
6779         * compile/compile-cplus-types.c: Remove a comment by #include.
6780
6781 2019-01-22  Tom Tromey  <tom@tromey.com>
6782
6783         * compile/gcc-c-plugin.h: Include compile-internal.h.
6784
6785 2019-01-22  Tom Tromey  <tom@tromey.com>
6786
6787         * stabsread.c (EXTERN): Do not define.
6788         (symnum, next_symbol_text_func, processing_gcc_compilation)
6789         (within_function, global_sym_chain, global_stabs)
6790         (previous_stab_code, this_object_header_files)
6791         (n_this_object_header_files)
6792         (n_allocated_this_object_header_files): Define.
6793         * stabsread.h (EXTERN): Never define.  Use "extern".
6794
6795 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6796
6797         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6798         history_value.
6799
6800 2019-01-21  Tom Tromey  <tom@tromey.com>
6801
6802         * ui-out.c: Fix includes.
6803         * tui/tui-source.c: Fix includes.
6804         * target.c: Fix includes.
6805         * remote.c: Fix includes.
6806         * regcache.c: Fix includes.
6807         * python/py-block.c: Fix includes.
6808         * printcmd.c: Fix includes.
6809         * or1k-tdep.c: Fix includes.
6810         * mi/mi-main.c: Fix includes.
6811         * m32r-tdep.c: Fix includes.
6812         * csky-tdep.c: Fix includes.
6813         * compile/compile-cplus-types.c: Fix includes.
6814         * cli/cli-interp.c: Fix includes.
6815
6816 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6817
6818         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6819         for padding.
6820
6821 2019-01-16  Tom Tromey  <tom@tromey.com>
6822
6823         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6824         earlier.
6825         (struct objfile) <msymbols_range>: Move from top level.
6826         <msymbols>: New method.
6827         (class objfile_msymbols): Remove.
6828         * symtab.c (default_collect_symbol_completion_matches_break_on):
6829         Update.
6830         * symmisc.c (dump_msymbols): Update.
6831         * stabsread.c (scan_file_globals): Update.
6832         * objc-lang.c (info_selectors_command, info_classes_command)
6833         (find_methods): Update.
6834         * minsyms.c (find_solib_trampoline_target): Update.
6835         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6836         * coffread.c (coff_symfile_read): Update.
6837         * ada-lang.c (ada_lookup_simple_minsym)
6838         (ada_collect_symbol_completion_matches): Update.
6839
6840 2019-01-16  Tom Tromey  <tom@tromey.com>
6841
6842         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6843         type.  Remove no-argument constructor.
6844         <iterator::operator++>: Simplify.
6845         <begin>: Update.
6846         <end>: Use minimal_symbol_count.
6847
6848 2019-01-16  Tom Tromey  <tom@tromey.com>
6849
6850         * objfiles.h (struct objfile) <psymtabs>: New method.
6851         (class objfile_psymtabs): Remove.
6852         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6853         typedef.
6854         <range>: New method.
6855         (require_partial_symbols): Change return type.
6856         * psymtab.c (require_partial_symbols)
6857         (psym_expand_symtabs_matching): Update.
6858         * mdebugread.c (parse_partial_symbols): Update.
6859         * dbxread.c (dbx_end_psymtab): Update.
6860
6861 2019-01-15  Tom Tromey  <tom@tromey.com>
6862
6863         * symtab.c (lookup_objfile_from_block)
6864         (lookup_symbol_in_objfile_symtabs)
6865         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6866         (find_line_symtab, info_sources_command)
6867         (default_collect_symbol_completion_matches_break_on)
6868         (make_source_files_completion_list): Update.
6869         * symmisc.c (print_objfile_statistics, dump_objfile)
6870         (maintenance_print_symbols, maintenance_info_symtabs)
6871         (maintenance_check_symtabs, maintenance_info_line_tables):
6872         Update.
6873         * source.c (select_source_symtab)
6874         (forget_cached_source_info_for_objfile): Update.
6875         * objfiles.h (class objfile_compunits): Remove.
6876         (struct objfile) <compunits_range>: New typedef.
6877         (compunits): New method.
6878         * objfiles.c (objfile_relocate1): Update.
6879         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6880         * maint.c (count_symtabs_and_blocks): Update.
6881         * linespec.c (iterate_over_all_matching_symtabs): Update.
6882         * cp-support.c (add_symbol_overload_list_qualified): Update.
6883         * coffread.c (coff_symtab_read): Update.
6884         * ada-lang.c (add_nonlocal_symbols)
6885         (ada_collect_symbol_completion_matches)
6886         (ada_add_global_exceptions): Update.
6887
6888 2019-01-15  Tom Tromey  <tom@tromey.com>
6889
6890         * progspace.h (program_space) <objfiles_safe_range>: New
6891         typedef.
6892         <objfiles_safe>: New method.
6893         * objfiles.h (class all_objfiles_safe): Remove.
6894         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6895         * jit.c (jit_inferior_exit_hook): Update.
6896
6897 2019-01-17  Tom Tromey  <tom@tromey.com>
6898
6899         * progspace.h (program_space) <objfiles_range>: New typedef.
6900         <objfiles>: New method.
6901         <objfiles_head>: Rename from objfiles.
6902         (object_files): Update.
6903         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6904         * guile/scm-pretty-print.c
6905         (ppscm_find_pretty_printer_from_objfiles): Update.
6906         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6907         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6908         Update.
6909         * python/py-progspace.c (pspy_get_objfiles): Update.
6910         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6911         Update.
6912         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6913         (objfpy_lookup_objfile_by_build_id): Update.
6914         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6915         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6916         Update.
6917         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6918         (expand_symtab_containing_pc, lookup_objfile_from_block)
6919         (lookup_static_symbol, basic_lookup_transparent_type)
6920         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6921         (find_line_symtab, info_sources_command)
6922         (default_collect_symbol_completion_matches_break_on)
6923         (make_source_files_completion_list, find_main_name): Update.
6924         * symmisc.c (print_symbol_bcache_statistics)
6925         (print_objfile_statistics, maintenance_print_symbols)
6926         (maintenance_print_msymbols, maintenance_print_objfiles)
6927         (maintenance_info_symtabs, maintenance_check_symtabs)
6928         (maintenance_expand_symtabs, maintenance_info_line_tables):
6929         Update.
6930         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6931         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6932         (map_overlay_command, unmap_overlay_command)
6933         (simple_overlay_update, expand_symtabs_matching)
6934         (map_symbol_filenames): Update.
6935         * symfile-debug.c (set_debug_symfile): Update.
6936         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6937         Update.
6938         * source.c (select_source_symtab, forget_cached_source_info):
6939         Update.
6940         * solib.c (solib_read_symbols): Update.
6941         * solib-spu.c (append_ocl_sos): Update.
6942         * psymtab.c (maintenance_print_psymbols)
6943         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6944         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6945         * printcmd.c (info_symbol_command): Update.
6946         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6947         Update.
6948         * objfiles.h (class all_objfiles): Remove.
6949         * objfiles.c (have_partial_symbols, have_full_symbols)
6950         (have_minimal_symbols, qsort_cmp, update_section_map)
6951         (shared_objfile_contains_address_p)
6952         (default_iterate_over_objfiles_in_search_order): Update.
6953         * objc-lang.c (info_selectors_command, info_classes_command)
6954         (find_methods): Update.
6955         * minsyms.c (find_solib_trampoline_target): Update.
6956         * maint.c (maintenance_info_sections)
6957         (maintenance_translate_address, count_symtabs_and_blocks):
6958         Update.
6959         * main.c (captured_main_1): Update.
6960         * linux-thread-db.c (try_thread_db_load_from_pdir)
6961         (has_libpthread): Update.
6962         * linespec.c (iterate_over_all_matching_symtabs)
6963         (search_minsyms_for_name): Update.
6964         * jit.c (jit_find_objf_with_entry_addr): Update.
6965         * hppa-tdep.c (find_unwind_entry)
6966         (hppa_lookup_stub_minimal_symbol): Update.
6967         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6968         Update.
6969         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6970         (elf_gnu_ifunc_resolve_by_got): Update.
6971         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6972         * dwarf-index-write.c (save_gdb_index_command): Update.
6973         * cp-support.c (add_symbol_overload_list_qualified): Update.
6974         * breakpoint.c (create_overlay_event_breakpoint)
6975         (create_longjmp_master_breakpoint)
6976         (create_std_terminate_master_breakpoint)
6977         (create_exception_master_breakpoint): Update.
6978         * blockframe.c (find_pc_partial_function): Update.
6979         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6980         (ada_collect_symbol_completion_matches)
6981         (ada_add_global_exceptions): Update.
6982
6983 2019-01-17  Tom Tromey  <tom@tromey.com>
6984
6985         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6986         declare VEC.
6987         (solib_target_parse_libraries): Change return type.
6988         (library_list_start_segment, library_list_start_section)
6989         (library_list_end_library, library_list_start_library); Update.
6990         (solib_target_free_library_list): Remove.
6991         (solib_target_parse_libraries): Remove cleanup.  Change return
6992         type.
6993         (solib_target_current_sos): Update.
6994
6995 2019-01-17  Tom Tromey  <tromey@bapiya>
6996
6997         * valprint.c: Replace "the the" with "the".
6998         * symtab.c: Replace "the the" with "the".
6999         * solib.c: Replace "the the" with "the".
7000         * solib-dsbt.c: Replace "the the" with "the".
7001         * linespec.c: Replace "the the" with "the".
7002         * dwarf2loc.h: Replace "the the" with "the".
7003         * amd64-windows-tdep.c: Replace "the the" with "the".
7004         * aarch64-tdep.c: Replace "the the" with "the".
7005
7006 2019-01-16  Keith Seitz  <keiths@redhat.com>
7007
7008         PR gdb/23773
7009         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7010         <builder>: Rename to ..
7011         <m_builder>: ... this and make private.
7012         (dwarf2_cu::get_builder): New method.  Change all users of
7013         `builder' to use this method.
7014         (dwarf2_start_symtab): Move to ...
7015         (dwarf2_cu::start_symtab): ... here.  Update all callers
7016         (setup_type_unit_groups): Move to ...
7017         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7018         callers.
7019         (dwarf2_cu::reset_builder): New method.
7020         (process_full_compunit, process_full_type_unit): Use
7021         dwarf2_cu::reset_builder.
7022         (follow_die_offset): Record the ancestor CU if it is different
7023         from the followed DIE's CU.
7024         (follow_die_sig_1): Likewise.
7025
7026 2019-01-15  Tom Tromey  <tom@tromey.com>
7027
7028         * remote.c (class remote_state) <buf>: Now a char_vector.
7029         <buf_size>: Remove.
7030         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7031         parameter.
7032         (remote_target::getpkt_or_notif_sane_1)
7033         (remote_target::getpkt_sane)
7034         (remote_target::getpkt_or_notif_sane): Likewise.
7035         (class remote_target) <putpkt>: New overload.
7036         (remote_target::read_frame): Change type of "buf_p".  Remove
7037         sizeof_p parameter.
7038         (packet_ok): New overload.
7039         (packet_check_result): New overload.
7040         Update all uses.
7041
7042 2019-01-14  Tom Tromey  <tom@tromey.com>
7043
7044         * remote-notif.c (handle_notification, remote_notif_ack)
7045         (remote_notif_parse): Make "buf" const.
7046         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7047         const.
7048         (remote_notif_parse, remote_notif_ack, handle_notification):
7049         Likewise.
7050         * remote.c (remote_notif_stop_parse): Make "buf" const.
7051         (remote_target::remote_parse_stop_reply): Make "buf" const.
7052         (remote_notif_stop_ack): Make "buf" const.
7053
7054 2019-01-14  Tom Tromey  <tom@tromey.com>
7055
7056         * remote.c (remote_console_output): Make parameter const.
7057
7058 2019-01-14  Tom Tromey  <tom@tromey.com>
7059
7060         * target-debug.h (target_debug_print_signals): Constify.
7061         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7062         * procfs.c (procfs_target::pass_signals): Update.
7063         * linux-nat.c (linux_nat_target::pass_signals): Update.
7064         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7065         * target-delegates.c: Rebuild.
7066         * remote.c (remote_target::program_signals): Update.
7067         (remote_target::pass_signals): Update.
7068         * target.c (target_pass_signals): Constify argument.
7069         (target_program_signals): Likewise.
7070         * target.h (struct target_ops) <pass_signals, program_signals>:
7071         Constify argument.
7072         (target_pass_signals, target_program_signals): Constify argument.
7073
7074 2019-01-14  Tom Tromey  <tom@tromey.com>
7075
7076         PR tui/28819:
7077         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7078
7079 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7080
7081         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7082         field.
7083         * rs6000-tdep.c: Include reggroups.h.
7084         (IS_V_ALIAS_PSEUDOREG): Define.
7085         (rs6000_register_name): Return names for the "vX" aliases.
7086         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7087         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7088         aliases.  Call default_register_reggroup_p for all other
7089         pseudo-registers.
7090         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7091         New functions.
7092         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7093         Handle "vX" aliases.
7094         (v_alias_pseudo_register_collect): New function.
7095         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7096         (rs6000_gdbarch_init): Initialize "vX" aliases as
7097         pseudo-registers.  Restore registration of
7098         rs6000_pseudo_register_reggroup_p with
7099         set_tdesc_pseudo_register_reggroup_p.
7100
7101 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7102
7103         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7104         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7105         set_gdbarch_num_pseudo_regs.
7106
7107 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7108
7109         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7110         Remove arg prefixname, add do_set and do_show.
7111         Add member functions set_list and show_list.
7112         * cli/cli-style.c (class cli_style_option): Update accordingly.
7113         (style_set_list): Move to file scope.
7114         (style_show_list): Likewise.
7115         (set_style): Call help_list.
7116         (show_style): Call cmd_show_list.
7117         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7118         Update to use the new macro.
7119
7120 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7121
7122         * ada-lang.c (_initialize_ada_language): Expand the help text
7123         for the "catch exception" command.
7124
7125 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7126
7127         * symtab.c (matching_obj_sections): Initialize obj,
7128         declare it closer to its usage.
7129
7130 2019-01-10  Tom Tromey  <tom@tromey.com>
7131
7132         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7133         (basic_inf_threads_range): Remove.
7134         (inf_threads_range, inf_non_exited_threads_range)
7135         (safe_inf_threads_range): Use next_adapter.
7136
7137 2019-01-10  Keith Seitz  <keiths@redhat.com>
7138
7139         PR gdb/23712
7140         PR symtab/23010
7141         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7142         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7143
7144 2019-01-10  Keith Seitz  <keiths@redhat.com>
7145
7146         PR gdb/23712
7147         PR symtab/23010
7148         * dictionary.c (pending_to_vector): Remove.
7149         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7150         Remove _1 suffix, replacing functions of the same name.  Update
7151         all callers.
7152         (dict_create_hashed, dict_create_hashed_expandable)
7153         (dict_create_linear, dict_create_linear_expandable, dict_free)
7154         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7155         Make functions static.
7156
7157 2019-01-10  Keith Seitz  <keiths@redhat.com>
7158
7159         PR gdb/23712
7160         PR symtab/23010
7161         * dictionary.h (struct dictionary): Replace declaration with
7162         multidictionary.
7163         (dict_create_hashed, dict_create_hashed_expandable)
7164         (dict_create_linear, dict_create_linear_expandable)
7165         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7166         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7167         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7168         taking multidictionary argument.
7169         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7170         * block.h (struct block) <dict>: Change to multidictionary
7171         and rename `multidict'.
7172         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7173         symmisc.c: Update all dictionary references to multidictionary.
7174
7175 2019-01-10  Keith Seitz  <keiths@redhat.com>
7176
7177         PR gdb/23712
7178         PR symtab/23010
7179         * dictionary.c: Include unordered_map.
7180         (pending_to_vector): New function.
7181         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7182         Rewrite the non-"_1" functions to take vector instead
7183         of linked list.
7184         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7185         "new" _1 versions of the same name.
7186         (multidictionary): Define.
7187         (std::hash<enum language): New definition.
7188         (collate_pending_symbols_by_language, mdict_create_hashed)
7189         (mdict_create_hashed_expandable, mdict_create_linear)
7190         (mdict_create_linear_expandable, mdict_free)
7191         (find_language_dictionary, create_new_language_dictionary)
7192         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7193         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7194         (mdict_size, mdict_empty): New functions.
7195         * dictionary.h (mdict_iterator): Define.
7196
7197 2019-01-10  Pedro Alves  <palves@redhat.com>
7198
7199         * breakpoint.c (read_uploaded_action)
7200         (create_tracepoint_from_upload): Adjust to use
7201         gdb::unique_xmalloc_ptr.
7202         * ctf.c (ctf_write_uploaded_tp):
7203         (SET_ARRAY_FIELD): Use emplace_back.
7204         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7205         * tracefile-tfile.c (tfile_write_uploaded_tp):
7206         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7207         gdb::unique_xmalloc_ptr.
7208         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7209         at_string, cond_string, cmd_strings>: Replace char pointers
7210         with gdb::unique_xmalloc_ptr.
7211
7212 2019-01-10  Pedro Alves  <palves@redhat.com>
7213
7214         * solib-target.c (library_list_start_library): Don't xstrdup name.
7215
7216 2019-01-10  Pedro Alves  <palves@redhat.com>
7217
7218         * mdebugread.c (parse_partial_symbols): Use
7219         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7220
7221 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7222
7223         * linux-fork.c (scoped_switch_fork_info)
7224         <~scoped_switch_fork_info>: Fix incorrect variable name.
7225
7226 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7227
7228         * linux-fork.c (scoped_switch_fork_info)
7229         <scoped_switch_fork_info>: Make explicit.
7230         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7231
7232 2019-01-10  Tom Tromey  <tom@tromey.com>
7233
7234         * objfiles.h (objfile::reset_psymtabs): Update.
7235         * objfiles.c (objfile::objfile): Update.
7236         * psymtab.h (psymtab_storage::obstack): Update.
7237         (psymtab_storage::m_obstack): Use gdb::optional.
7238         (class psymtab_storage): Update comment.  Remove objfile
7239         parameter.
7240         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7241
7242 2019-01-10  Tom Tromey  <tom@tromey.com>
7243
7244         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7245         <free_psymtabs>: Now private.
7246         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7247         (allocate_psymtab): Use new method.
7248
7249 2019-01-10  Tom Tromey  <tom@tromey.com>
7250
7251         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7252         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7253         * mdebugread.c (parse_partial_symbols): Use
7254         allocate_dependencies.
7255         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7256         allocate_dependencies.
7257         (process_psymtab_comp_unit_reader)
7258         (build_type_psymtab_dependencies): Likewise.
7259         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7260
7261 2019-01-10  Tom Tromey  <tom@tromey.com>
7262
7263         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7264         PSYMBOL_SET_LANGUAGE.
7265         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7266
7267 2019-01-10  Tom Tromey  <tom@tromey.com>
7268
7269         * psymtab.h (psymtab_storage::obstack): New method.
7270         <m_obstack>: Rename from obstack; now private.
7271         * psymtab.c (psymtab_storage): Update.
7272         * dwarf2read.c (create_addrmap_from_index)
7273         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7274         Update.
7275
7276 2019-01-10  Tom Tromey  <tom@tromey.com>
7277
7278         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7279         * objfiles.h (objfile::reset_psymtabs): New method.
7280
7281 2019-01-10  Tom Tromey  <tom@tromey.com>
7282
7283         * symmisc.c (print_symbol_bcache_statistics): Update.
7284         (print_objfile_statistics): Update.
7285         * symfile.c (reread_symbols): Update.
7286         * psymtab.h (class psymtab_storage): New.
7287         * psymtab.c (psymtab_storage): New constructor.
7288         (~psymtab_storage): New destructor.
7289         (require_partial_symbols): Update.
7290         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7291         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7292         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7293         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7294         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7295         (start_psymtab_common, end_psymtab_common)
7296         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7297         (allocate_psymtab): Update.
7298         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7299         Update.
7300         (dump_psymtab_addrmap, maintenance_print_psymbols)
7301         (maintenance_check_psymtabs): Update.
7302         (class objfile_psymtabs): Move to objfiles.h.
7303         * psympriv.h (discard_psymtab): Now inline.
7304         (psymtab_discarder::psymtab_discarder): Update.
7305         (psymtab_discarder::~psymtab_discarder): Update.
7306         (ALL_OBJFILE_PSYMTABS): Rewrite.
7307         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7308         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7309         Remove fields.
7310         <partial_symtabs>: New field.
7311         (class objfile_psymtabs): Move from psymtab.h.  Update.
7312         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7313         psymbol_cache.
7314         (objfile::~objfile): Don't destroy psymbol_cache.
7315         * mdebugread.c (parse_partial_symbols): Update.
7316         * dwarf2read.c (create_addrmap_from_index)
7317         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7318         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7319         (add_partial_subprogram, dwarf2_ranges_read): Update.
7320         * dwarf-index-write.c (write_address_map)
7321         (write_one_signatured_type, recursively_write_psymbols)
7322         (class debug_names, class debug_names, write_psymtabs_to_index):
7323         Update.
7324
7325 2019-01-10  Tom Tromey  <tom@tromey.com>
7326
7327         * symtab.h (SYMBOL_SET_NAMES): Update.
7328         (symbol_set_names): Update.
7329         (MSYMBOL_SET_NAMES): Update.
7330         * symtab.c (symbol_set_names): Change argument to be an
7331         objfile_per_bfd_storage.
7332         * psymtab.c (add_psymbol_to_bcache): Update.
7333         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7334
7335 2019-01-10  Tom Tromey  <tom@tromey.com>
7336
7337         * symtab.c (create_demangled_names_hash): Change argument to be an
7338         objfile_per_bfd_storage.
7339         (symbol_set_names): Update.
7340
7341 2019-01-10  Tom Tromey  <tom@tromey.com>
7342
7343         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7344         init_psymbol_list.
7345         * psymtab.c (init_psymbol_list): Do nothing if already called.
7346         * psympriv.h (init_psymbol_list): Add comment.
7347         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7348         init_psymbol_list.
7349         * dbxread.c (dbx_symfile_read): Unconditionally call
7350         init_psymbol_list.
7351
7352 2019-01-10  Tom Tromey  <tom@tromey.com>
7353
7354         * xcoffread.c (scan_xcoff_symtab): Update.
7355         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7356         "where".
7357         * mdebugread.c (parse_partial_symbols)
7358         (handle_psymbol_enumerators): Update.
7359         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7360         * dbxread.c (read_dbx_symtab): Update.
7361         * psympriv.h (psymbol_placement): New enum.
7362         (add_psymbol_to_list): Update.
7363
7364 2019-01-10  Tom Tromey  <tom@tromey.com>
7365
7366         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7367         static_psymbols parameters.
7368         (scan_xcoff_symtab): Update.
7369         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7370         static_psymbols parameters.
7371         * psympriv.h (start_psymtab_common): Update.
7372         * mdebugread.c (parse_partial_symbols): Update.
7373         * dwarf2read.c (create_partial_symtab): Update.
7374         * dbxread.c (read_dbx_symtab): Update.
7375         (start_psymtab): Remove global_psymbols and static_psymbols
7376         parameters.
7377
7378 2019-01-10  Tom Tromey  <tom@tromey.com>
7379
7380         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7381         * psymtab.c (allocate_psymtab): Add comment.
7382         * psympriv.h (allocate_psymtab): Add comment.
7383         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7384         initializations.
7385         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7386
7387 2019-01-10  Tom Tromey  <tom@tromey.com>
7388
7389         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7390         Don't declare.
7391         * mipsread.c: Include mdebugread.h.
7392         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7393         Declare.
7394         * elfread.c: Include mdebugread.h.
7395
7396 2019-01-09  Tom Tromey  <tom@tromey.com>
7397
7398         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7399         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7400         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7401         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7402         (psym_lookup_symbol, psym_find_last_source_symtab)
7403         (psym_forget_cached_source_info, psym_print_stats)
7404         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7405         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7406         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7407         (psym_find_compunit_symtab_by_address)
7408         (maintenance_print_psymbols, maintenance_info_psymtabs)
7409         (maintenance_check_psymtabs): Use ranged for.
7410         * psymtab.h (class objfile_psymtabs): New.
7411         (require_partial_symbols): Return objfile_psymtabs.
7412         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7413
7414 2019-01-09  Tom Tromey  <tom@tromey.com>
7415
7416         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7417         (find_pc_mapped_section, list_overlays_command)
7418         (map_overlay_command, unmap_overlay_command)
7419         (simple_overlay_update): Use all_objfiles.
7420         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7421         * printcmd.c (info_symbol_command): Use all_objfiles.
7422         * objfiles.h (ALL_OBJSECTIONS): Remove.
7423         * maint.c (maintenance_translate_address): Use all_objfiles.
7424         * gcore.c (gcore_create_callback): Use all_objfiles.
7425         (objfile_find_memory_regions): Likewise.
7426
7427 2019-01-09  Tom Tromey  <tom@tromey.com>
7428
7429         * symtab.c (find_line_symtab, info_sources_command)
7430         (make_source_files_completion_list): Use objfile_compunits.
7431         * source.c (select_source_symtab): Use objfile_compunits.
7432         * objfiles.h (struct objfile): Update comment.
7433         (ALL_OBJFILES): Remove.
7434         (ALL_FILETABS): Remove.
7435         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7436         objfile_compunits.
7437
7438 2019-01-09  Tom Tromey  <tom@tromey.com>
7439
7440         * symmisc.c (print_objfile_statistics, dump_objfile)
7441         (maintenance_print_symbols): Use compunit_filetabs.
7442         * source.c (forget_cached_source_info_for_objfile): Use
7443         compunit_filetabs.
7444         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7445         (ALL_FILETABS): Use compunit_filetabs.
7446         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7447         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7448
7449 2019-01-09  Tom Tromey  <tom@tromey.com>
7450
7451         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7452         (compunit_filetabs): New.
7453         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7454         compunit_filetabs.
7455         (info_sources_command, make_source_files_completion_list): Remove
7456         declaration.
7457         * symmisc.c (print_objfile_statistics, dump_objfile)
7458         (maintenance_print_symbols): Remove declaration.
7459         (maintenance_info_symtabs): Use compunit_filetabs.
7460         (maintenance_info_line_tables): Likewise.
7461         * source.c (select_source_symtab): Change local variable name.
7462         (forget_cached_source_info_for_objfile): Remove declaration.
7463         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7464         * objfiles.c (objfile_relocate1): Remove declaration.
7465         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7466         declaration.
7467         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7468         * coffread.c (coff_symtab_read): Remove declaration.
7469         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7470         compunit_filetabs.
7471
7472 2019-01-09  Tom Tromey  <tom@tromey.com>
7473
7474         * symtab.c (lookup_objfile_from_block)
7475         (find_pc_sect_compunit_symtab, search_symbols)
7476         (default_collect_symbol_completion_matches_break_on): Use
7477         objfile_compunits.
7478         * objfiles.h (ALL_COMPUNITS): Remove.
7479         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7480         * cp-support.c (add_symbol_overload_list_qualified): Use
7481         objfile_compunits.
7482         * ada-lang.c (ada_collect_symbol_completion_matches)
7483         (ada_add_global_exceptions): Use objfile_compunits.
7484
7485 2019-01-09  Tom Tromey  <tom@tromey.com>
7486
7487         * source.c (select_source_symtab)
7488         (forget_cached_source_info_for_objfile): Remove declaration.
7489         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7490         declaration.
7491         * maint.c (count_symtabs_and_blocks): Remove declaration.
7492         * cp-support.c (add_symbol_overload_list_qualified): Remove
7493         declaration.
7494         * coffread.c (coff_symtab_read): Remove declaration.
7495         * symtab.c (lookup_symbol_in_objfile_symtabs)
7496         (basic_lookup_transparent_type_1): Use objfile_compunits.
7497         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7498         (info_sources_command, search_symbols)
7499         (default_collect_symbol_completion_matches_break_on)
7500         (make_source_files_completion_list): Remove declaration.
7501         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7502         (ada_collect_symbol_completion_matches)
7503         (ada_add_global_exceptions): Remove declaration.
7504         * linespec.c (iterate_over_all_matching_symtabs): Use
7505         objfile_compunits.
7506         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7507         (class objfile_compunits): New.
7508         (ALL_COMPUNITS): Use objfile_compunits.
7509         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7510         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7511         objfile_compunits.
7512         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7513
7514 2019-01-09  Tom Tromey  <tom@tromey.com>
7515
7516         * symtab.c (search_symbols)
7517         (default_collect_symbol_completion_matches_break_on): Use
7518         objfile_msymbols.
7519         * ada-lang.c (ada_lookup_simple_minsym)
7520         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7521         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7522         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7523         objfile_msymbols.
7524         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7525         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7526         * objc-lang.c (find_methods): Use objfile_msymbols.
7527         (info_selectors_command, info_classes_command): Likewise.
7528         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7529         * objfiles.h (class objfile_msymbols): New.
7530         (ALL_OBJFILE_MSYMBOLS): Remove.
7531         (ALL_MSYMBOLS): Remove.
7532
7533 2019-01-09  Tom Tromey  <tom@tromey.com>
7534
7535         * common/next-iterator.h (next_adapter): Add Iterator template
7536         parameter.
7537         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7538         (class all_objfiles_safe): New.
7539         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7540         * objfiles.c (put_objfile_before): Update comment.
7541         (add_separate_debug_objfile): Likewise.
7542         (free_all_objfiles): Use all_objfiles_safe.
7543         (objfile_purge_solibs): Likewise.
7544
7545 2019-01-09  Tom Tromey  <tom@tromey.com>
7546
7547         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7548         (expand_symtab_containing_pc, lookup_static_symbol)
7549         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7550         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7551         all_objfiles.
7552         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7553         * breakpoint.c (create_overlay_event_breakpoint)
7554         (create_longjmp_master_breakpoint)
7555         (create_std_terminate_master_breakpoint)
7556         (create_exception_master_breakpoint): Use all_objfiles.
7557         * linux-thread-db.c (try_thread_db_load_from_pdir)
7558         (has_libpthread): Use all_objfiles.
7559         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7560         * linespec.c (iterate_over_all_matching_symtabs)
7561         (search_minsyms_for_name): Use all_objfiles.
7562         * maint.c (maintenance_info_sections): Use all_objfiles.
7563         * main.c (captured_main_1): Use all_objfiles.
7564         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7565         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7566         * guile/scm-pretty-print.c
7567         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7568         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7569         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7570         (maintenance_print_msymbols): Use all_objfiles.
7571         * source.c (select_source_symtab): Use all_objfiles.
7572         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7573         * symfile.c (remove_symbol_file_command)
7574         (expand_symtabs_matching, map_symbol_filenames): Use
7575         all_objfiles.
7576         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7577         all_objfiles.
7578         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7579         * objc-lang.c (find_methods): Use all_objfiles.
7580         * objfiles.c (have_partial_symbols, have_full_symbols)
7581         (have_minimal_symbols, qsort_cmp)
7582         (default_iterate_over_objfiles_in_search_order): Use
7583         all_objfiles.
7584         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7585         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7586         (maintenance_check_psymtabs): Use all_objfiles.
7587         (ALL_PSYMTABS): Remove.
7588         * compile/compile-object-run.c (do_module_cleanup): Use
7589         all_objfiles.
7590         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7591         * cp-support.c (add_symbol_overload_list_qualified): Use
7592         all_objfiles.
7593         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7594         Use all_objfiles.
7595         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7596         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7597         all_objfiles.
7598         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7599         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7600         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7601         Uses all_objfiles.
7602         * solib.c (solib_read_symbols): Use all_objfiles
7603
7604 2019-01-09  Tom Tromey  <tom@tromey.com>
7605
7606         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7607         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7608         all_objfiles.
7609         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7610         * symmisc.c (print_symbol_bcache_statistics)
7611         (print_objfile_statistics, maintenance_print_objfiles)
7612         (maintenance_info_symtabs, maintenance_check_symtabs)
7613         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7614         all_objfiles.
7615         * source.c (forget_cached_source_info): Use all_objfiles.
7616         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7617         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7618         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7619         * objfiles.c (update_section_map): Use all_objfiles.
7620         (shared_objfile_contains_address_p): Likewise.
7621         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7622         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7623
7624 2019-01-09  Tom Tromey  <tom@tromey.com>
7625
7626         * common/next-iterator.h: New file.
7627         * objfiles.h (class all_objfiles): New.
7628         (struct objfile_iterator): New.
7629
7630 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7631
7632         * NEWS: Move the description of the changed "frame", "select-frame",
7633          and "info frame" commands to the Changed commands section.
7634
7635 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7636
7637         * gdbtypes.c (check_stub_method_group): Remove handling of old
7638         mangling schemes.
7639         * linespec.c (find_methods): Likewise.
7640         * stabsread.c (read_member_functions): Likewise.
7641         * valops.c (search_struct_method): Likewise.
7642         (value_struct_elt_for_reference): Likewise.
7643         * NEWS: Mention this change.
7644
7645 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7646
7647         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7648         print_source_lines.
7649         * source.c (print_source_lines_base): Update line number check.
7650         (print_source_lines): New function.
7651         (source_lines_range::source_lines_range): New function.
7652         * source.h (class source_lines_range): New class.
7653         (print_source_lines): New declaration.
7654
7655 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7656
7657         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7658
7659 2019-01-08  Tom Tromey  <tom@tromey.com>
7660             Simon Marchi  <simon.marchi@ericsson.com>
7661
7662         PR gdb/24060
7663         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7664         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7665         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7666         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7667         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7668         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7669
7670 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7671
7672         * source.c (select_source_symtab): Move header comment to
7673         declaration in source.h.
7674         (forget_cached_source_info_for_objfile): Likewise.
7675         (forget_cached_source_info): Likewise.
7676         (identify_source_line): Likewise.
7677         * source.h (identify_source_line): Move declaration from symtab.h
7678         and add comment from source.c
7679         (print_source_lines): Likewise.
7680         (forget_cached_source_info_for_objfile): Likewise.
7681         (forget_cached_source_info): Likewise.
7682         (select_source_symtab): Likewise.
7683         (enum print_source_lines_flag): Move definition from symtab.h.
7684         * symtab.h (identify_source_line): Move declaration to source.h.
7685         (print_source_lines): Likewise.
7686         (forget_cached_source_info_for_objfile): Likewise.
7687         (forget_cached_source_info): Likewise.
7688         (select_source_symtab): Likewise.
7689         (enum print_source_lines_flag): Move definition to source.h.
7690         * tui/tui-hooks.c: Add 'source.h' include.
7691
7692 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7693
7694         * source.c (print_source_lines_base): Handle requests to print
7695         reverse line number sequences, and guard against empty lines
7696         string.
7697
7698 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7699
7700         * source.c (print_source_lines_base): Fix skip of '\r' if next
7701         character is '\n'.
7702
7703 2019-01-06  Tom Tromey  <tom@tromey.com>
7704
7705         * c-exp.y (struct c_parse_state) <macro_original_text,
7706         expansion_obstack>: New member.
7707         (macro_original_text, expansion_obstack): Remove globals.
7708         (scan_macro_expansion, scanning_macro_expansion)
7709         (finished_macro_expansion): Update.
7710         (scan_macro_cleanup): Remove.
7711         (yylex, c_parse): Update.
7712
7713 2019-01-06  Tom Tromey  <tom@tromey.com>
7714
7715         * c-exp.y (struct c_parse_state) <strings>: New member.
7716         (operator_stoken): Update.
7717
7718 2019-01-06  Tom Tromey  <tom@tromey.com>
7719
7720         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7721         (union type_stack_elt) <typelist_val>: Now a pointer to
7722         std::vector.
7723         (type_stack_cleanup): Don't declare.
7724         (push_typelist): Update.
7725         * parse.c (pop_typelist): Return a std::vector.
7726         (push_typelist): Take a std::vector.
7727         (follow_types): Update.  Do not free args.
7728         (type_stack_cleanup): Remove.
7729         * c-exp.y (struct c_parse_state): New.
7730         (cpstate): New global.
7731         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7732         (nonempty_typelist): Update.
7733         (func_mod): Create a new vector.
7734         (c_parse): Create a c_parse_state.
7735         (check_parameter_typelist): Do not delete params.
7736         (function_method): Update.  Do not delete type_list.
7737
7738 2019-01-06  Tom Tromey  <tom@tromey.com>
7739
7740         PR gdb/28155:
7741         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7742         check_typedef.
7743         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7744         (print_return_value): Likewise.
7745
7746 2019-01-05  Tom Tromey  <tom@tromey.com>
7747
7748         * contrib/cleanup_check.py: Remove.
7749         * contrib/gcc-with-excheck: Remove.
7750         * contrib/exsummary.py: Remove.
7751         * contrib/excheck.py: Remove.
7752
7753 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7754
7755         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7756         NULL. Initialize tpprev to NULL instead of assigning it
7757         to NULL on the next statement.
7758         * windows-nat.c (windows_delete_thread): Remove check for
7759         main_thread_id before printing thread exit notifications.
7760         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7761         Remove thread ID check against main_thread_id.
7762         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7763         windows_delete_thread.
7764         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7765
7766 2019-01-04  Tom Tromey  <tom@tromey.com>
7767
7768         * compile/compile.c (_initialize_compile): Use upper case for
7769         metasyntactic variables.
7770         * symmisc.c (_initialize_symmisc): Use upper case for
7771         metasyntactic variables.
7772         * psymtab.c (_initialize_psymtab): Use upper case for
7773         metasyntactic variables.
7774         * demangle.c (demangle_command): Use upper case for metasyntactic
7775         variables.
7776         (_initialize_demangler): Likewise.
7777         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7778         variables.
7779
7780 2019-01-03  Tom Tromey  <tom@tromey.com>
7781
7782         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7783
7784 2019-01-03  Tom Tromey  <tom@tromey.com>
7785
7786         * python/py-symtab.c (salpy_str): Update.
7787         (struct salpy_sal_object) <symtab>: Now a PyObject.
7788         (salpy_dealloc): Update.
7789         (del_objfile_sal): Use gdbpy_ref.
7790
7791 2019-01-03  Tom Tromey  <tom@tromey.com>
7792
7793         * python/py-type.c (convert_field): Use new_reference.  Return
7794         gdbpy_ref.
7795         (make_fielditem): Return gdbpy_ref.
7796         (typy_fields): Update.
7797         (typy_getitem): Update.
7798         (field_name): Return gdbpy_ref.  Use new_reference.
7799         (typy_iterator_iternext): Update.
7800
7801 2019-01-03  Tom Tromey  <tom@tromey.com>
7802
7803         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7804
7805 2019-01-03  Tom Tromey  <tom@tromey.com>
7806
7807         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7808         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7809         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7810         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7811         (pspy_set_type_printers): Likewise.
7812         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7813         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7814         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7815         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7816         (objfpy_set_type_printers): Likewise.
7817
7818 2019-01-03  Tom Tromey  <tom@tromey.com>
7819
7820         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7821         (gdbpy_print_stack): Use gdbpy_err_fetch.
7822         * python/python-internal.h (class gdbpy_err_fetch): New class.
7823         (class gdbpy_enter) <m_error_type, m_error_value,
7824         m_error_traceback>: Remove.
7825         <m_error>: New member.
7826         (gdbpy_exception_to_string): Don't declare.
7827         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7828         * python/py-value.c (convert_value_from_python): Use
7829         gdbpy_err_fetch.
7830         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7831         gdbpy_exception_to_string.
7832         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7833         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7834         gdbpy_err_fetch.
7835
7836 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7837
7838         * linux-nat.c (delete_lwp_cleanup): Delete.
7839         (struct lwp_deleter): New struct.
7840         (lwp_info_up): New typedef.
7841         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7842         lwp_info_up.
7843
7844 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7845
7846         * linux-fork.c (class scoped_switch_fork_info): New class.
7847         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7848
7849 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7850
7851         * valops.c (find_overload_match): Remove use of null_cleanup, and
7852         calls to do_cleanups.
7853
7854 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7855
7856         * compile/compile-cplus-types.c
7857         (compile_cplus_instance::decl_name): Handle changes to
7858         cp_func_name.
7859         * cp-support.c (cp_func_name): Update header comment, update
7860         return type.
7861         * cp-support.h (cp_func_name): Update return type in declaration.
7862         * valops.c (find_overload_match): Move temp_func local to top
7863         level of function and change its type.  Use temp_func to hold and
7864         delete temporary string obtained from cp_func_name.
7865
7866 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7867
7868         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7869         gdb::char_vector, remove cleanup, and update uses of `msg`.
7870
7871 2019-01-03  Jim Wilson  <jimw@sifive.com>
7872
7873         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7874
7875 2019-01-02  Tom Tromey  <tom@tromey.com>
7876
7877         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7878         (tdesc_parse_xml): Remove cleanups.
7879         * target-descriptions.h (make_cleanup_free_target_description):
7880         Don't declare.
7881         (target_desc_deleter): New struct.
7882         (target_desc_up): New typedef.
7883         * target-descriptions.c (target_desc_deleter::operator()): Rename
7884         from free_target_description.
7885         (make_cleanup_free_target_description): Remove.
7886
7887 2019-01-02  Tom Tromey  <tom@tromey.com>
7888
7889         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7890         constructor, destructor.
7891         (linespec_parser): Remove typedef.
7892         (~linespec_parser): Rename from linespec_parser_delete.
7893         (linespec_lex_to_end, linespec_complete_label)
7894         (linespec_complete): Update.
7895         (decode_line_full): Remove cleanups.
7896         (decode_line_1): Update.
7897
7898 2019-01-02  Tom Tromey  <tom@tromey.com>
7899
7900         * python/python-internal.h (inferior_to_inferior_object): Change
7901         return type.
7902         * python/py-exitedevent.c (create_exited_event_object): Update.
7903         * python/py-inferior.c (inferior_to_inferior_object): Return
7904         gdbpy_ref.
7905         (python_new_inferior, python_inferior_deleted)
7906         (thread_to_thread_object, delete_thread_object)
7907         (build_inferior_list, gdbpy_selected_inferior): Update.
7908         * python/py-infthread.c (create_thread_object): Update.  Also fail
7909         if inferior_to_inferior_object fails.
7910
7911 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7912
7913         * inferior.h (class inferior) <displaced_step_state>: New field.
7914         * infrun.h (struct displaced_step_state): Move here from
7915         infrun.c.  Initialize fields, add constructor.
7916         <inf>: Remove field.
7917         <reset>: New method.
7918         * infrun.c (struct displaced_step_inferior_state): Move to
7919         infrun.h.
7920         (displaced_step_inferior_states): Remove.
7921         (get_displaced_stepping_state): Adust.
7922         (displaced_step_in_progress_any_inferior): Adjust.
7923         (displaced_step_in_progress_thread): Adjust.
7924         (displaced_step_in_progress): Adjust.
7925         (add_displaced_stepping_state): Remove.
7926         (get_displaced_step_closure_by_addr): Adjust.
7927         (remove_displaced_stepping_state): Remove.
7928         (infrun_inferior_exit): Call displaced_step_state.reset.
7929         (use_displaced_stepping): Don't check for NULL.
7930         (displaced_step_prepare_throw): Call
7931         get_displaced_stepping_state.
7932         (displaced_step_fixup): Don't check for NULL.
7933         (prepare_for_detach): Don't check for NULL.
7934
7935 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7936
7937         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7938          in case of call that did not complete.
7939
7940 2019-01-02  Andrey Utkin  <autkin@undo.io>
7941
7942         * symfile.c (find_separate_debug_file): Fix search of debug files for
7943         remote debuggee.
7944
7945 2019-01-02  Tom Tromey  <tom@tromey.com>
7946
7947         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7948         indentation.
7949         * python/py-frame.c (frapy_older): Remove cast.
7950         (frapy_newer): Likewise.
7951         * python/py-breakpoint.c (local_setattro): Remove cast.
7952         * python/py-arch.c (archpy_name): Remove local variable.
7953         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7954
7955 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7956
7957         * unittests/basic_string_view/element_access/char/empty.cc:
7958         Fix year range in copyright header.
7959
7960 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7961
7962         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7963         Delete.
7964         <operator==>: Update with for removed field.
7965         <hash>: Likewise.
7966         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7967         <isa_features>: ...this.
7968         <abi_features>: New field.
7969         (riscv_isa_flen): Update comment.
7970         (riscv_abi_xlen): New declaration.
7971         (riscv_abi_flen): New declaration.
7972         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7973         isa_features.
7974         (riscv_abi_xlen): New function.
7975         (riscv_isa_flen): Update to get answer from isa_features.
7976         (riscv_abi_flen): New function.
7977         (riscv_has_fp_abi): Update to get answer from abi_features.
7978         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7979         xlen and flen.
7980         (riscv_call_info) <xlen, flen>: Update comment.
7981         (riscv_call_arg_struct): Remove invalid assertions
7982         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7983         is removed.
7984         (riscv_gdbarch_init): Gather isa features and abi features
7985         separately, ensure both match on the gdbarch when reusing an old
7986         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7987         a target with 64-bit float hardware.
7988
7989 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7990
7991         * source.c (search_command_helper): Stop reverse search
7992         when line 1 has been searched.
7993
7994 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7995
7996         * record-full.c (record_full_base_target::close): Rewrite
7997         record_full_core_buf_list free logic.
7998
7999 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8000
8001         * break-catch-syscall.c (print_one_catch_syscall): xfree
8002         the last text.
8003
8004 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8005
8006         * top.c (print_gdb_version): Update Copyright year in version
8007         message.
8008
8009 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8010
8011         Update copyright year range in all GDB files.
8012
8013 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8014
8015         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8016
8017 For older changes see ChangeLog-2018.
8018 \f
8019 Local Variables:
8020 mode: change-log
8021 left-margin: 8
8022 fill-column: 74
8023 version-control: never
8024 coding: utf-8
8025 End:
8026