gdb/ChangeLog

   1 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * breakpoint.c (iterate_over_breakpoints): Change function pointer
   4         to a gdb::function_view and return value to bool.
   5         * breakpoint.h (iterate_over_breakpoints): Likewise.
   6         * dummy-frame.c (pop_dummy_frame_bpt): Update.
   7         (pop_dummy_frame): Update.
   8         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
   9         (gdbscm_breakpoints): Update.
  10         * python/py-breakpoint.c (build_bp_list): Update.
  11         (gdbpy_breakpoints): Update.
  12         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
  13         Update.
  14         (bpfinishpy_handle_stop): Update.
  15         (bpfinishpy_handle_exit): Update.
  16         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
  17         (svr4_update_solib_event_breakpoints): Update.
  18
  19 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
  20
  21         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
  22         when unwrapping single-field structs.
  23
  24 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
  25
  26         * dwarf2read.c: Remove includes.
  27
  28 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
  29
  30         * ui-out.c (ui_out::call_do_message): Silence
  31         -Wformat-nonliteral warning.
  32
  33 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
  34
  35         * breakpoint.c: Remove some includes: continuations.h, skip.h,
  36         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
  37         include: readline/tilde.h.
  38
  39 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
  40
  41         * remote.c (remote_target::get_trace_status): Remove declaration of
  42         trace_regblock_size.
  43
  44 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
  45
  46         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
  47         (show_user): Remove declaration of cmdlist.
  48         * cli/cli-cmds.h (max_user_call_depth): Declare.
  49         * cli/cli-script.c (execute_user_command): Remove declaration
  50         of max_user_call_depth.
  51
  52 2019-10-11  Jim Wilson  <jimw@sifive.com>
  53
  54         * gdbsupport/print-utils.h (pulongest): Fix comment.
  55         (plongest): Likewise.
  56         (phex): Add missing comment, mention leading zeros.
  57         (phex_nz): Add mention of no leading zeros to comment.
  58
  59         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
  60         plongest instead of unsigned long long cast.
  61
  62 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
  63
  64         * main.c (captured_main_1): Include gdbtk.h and remove declarations
  65         for external_editor_command and gdbtk_test.
  66
  67 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
  68
  69         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
  70         * varobj.c (varobjdebug): Move comment to...
  71         * varobj.h (varobjdebug): ...here, and declare.
  72
  73 2019-10-09  Tom Tromey  <tom@tromey.com>
  74
  75         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
  76         erase_data_content.
  77
  78 2019-10-09  Tom Tromey  <tom@tromey.com>
  79
  80         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
  81         * tui/tui-stack.c (tui_locator_window::rerender): Update.
  82         * tui/tui-command.c (tui_cmd_window::resize)
  83         (tui_refresh_cmd_win): Update.
  84         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
  85         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
  86         * tui/tui-data.c (~tui_gen_win_info): Remove.
  87         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
  88         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
  89         (tui_redisplay_readline, tui_mld_flush)
  90         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
  91         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
  92         (tui_data_window::erase_data_content)
  93         (tui_data_item_window::rerender)
  94         (tui_data_item_window::refresh_window): Update.
  95         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
  96         (box_win, tui_gen_win_info::make_window)
  97         (tui_gen_win_info::make_visible): Update.
  98         (tui_delete_win): Remove.
  99         * tui/tui-winsource.c
 100         (tui_source_window_base::do_erase_source_content): Update.
 101         (tui_show_source_line, tui_source_window_base::update_tab_width)
 102         (tui_source_window_base::update_exec_info): Update.
 103         * tui/tui-data.h (struct curses_deleter): New.
 104         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 105         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 106
 107 2019-10-09  Tom Tromey  <tom@tromey.com>
 108
 109         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 110
 111 2019-10-09  Tom Tromey  <tom@tromey.com>
 112
 113         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 114         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 115
 116 2019-10-09  Tom Tromey  <tom@tromey.com>
 117
 118         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 119         window height directly.
 120         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 121         declare.
 122         * tui/tui-layout.c (tui_default_win_height): Remove.
 123         (tui_default_win_viewport_height): Remove.
 124
 125 2019-10-09  Tom Tromey  <tom@tromey.com>
 126
 127         * tui/tui.h: Remove comments.
 128
 129 2019-10-09  Tom de Vries  <tdevries@suse.de>
 130
 131         * python/lib/gdb/printer/bound_registers.py: Use
 132         '^builtin_type_bound128' as regexp argument for
 133         add_builtin_pretty_printer.
 134
 135 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 136
 137         * guile/guile.c (guile_extension_script_ops): Remove forward
 138         declaration and mark as static.
 139         (guile_script_ops): Likewise.
 140         (extension_language_guile): Move further down in the file so
 141         it can reference the definitions for guile_{extension_,}script_ops.
 142
 143 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 144
 145         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 146         except SORTL, DFLTCC, and KDSA.
 147
 148 2019-10-08  Tom Tromey  <tromey@adacore.com>
 149
 150         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 151         (struct safe_symbol_file_add_args): Remove.
 152
 153 2019-10-08  Tom Tromey  <tromey@adacore.com>
 154
 155         * windows-nat.c: Don't include buildsym-legacy.h.
 156
 157 2019-10-08  Tom Tromey  <tromey@adacore.com>
 158
 159         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 160
 161 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 162
 163         * gdbtypes.c (overload_debug): Move comment to header.
 164         * gdbtypes.h (overload_debug): Declare.
 165         * valops.c: Remove declaration of overload_debug, instead
 166         include gdbtypes.h.
 167
 168 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 169
 170         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 171         through _().
 172         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 173         move comment...
 174         * language.h (lang_frame_mismatch_warn): ... here. Also add
 175         declaration.
 176         * top.c (lang_frame_mismatch_warn): Remove declaration.
 177         (check_frame_language_change): Pass lang_frame_mismatch_warn
 178         through _().
 179
 180 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 181
 182         * c-lang.h (vtbl_ptr_name): Declare.
 183         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 184         it from the header.
 185         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 186
 187 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 188
 189         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 190         gdb_static_assert.
 191
 192 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 193
 194         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 195         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 196         * ctfread.c: New file.
 197         * ctfread.h: New file.
 198         * elfread.c: Include ctfread.h.
 199         (struct elfinfo text_p): New member ctfsect.
 200         (elf_locate_sections): Mark CTF section.
 201         (elf_symfile_read): Call elfctf_build_psymtabs.
 202         * Makefile.in (LIBCTF): Add.
 203         (CLIBS): Use it.
 204         (CDEPS): Likewise.
 205         (DIST): Add ctfread.c.
 206
 207 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 208
 209         * ctfread.c (struct nextfield): Renamed to ...
 210         (struct ctf_nextfield): ... this.
 211         (struct field_info): Renamed to ...
 212         (strut ctf_field_info): ... this.
 213         (attach_fields_to_type): Update for renamed structures.
 214         (ctf_add_member_cb): Likewise.
 215         (ctf_add_enum_member_cb): Likewise.
 216         (process_struct_members): Likewise.
 217         (process_enum_type): Likewise.
 218
 219 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 220
 221         * tracectf.h: Rename, was ctf.h.
 222         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 223         * tracefile.c: Likewise.
 224         * tracepoint.c: Remove unused include ctf.h.
 225         * mi/mi-main.c: Likewise.
 226         * Makefile.in Replace ctf.c with tracectf.c.
 227
 228 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 229
 230         * version.in: Change version number to "9.0.50.DATE-git".
 231
 232 2019-10-03  Tom Tromey  <tom@tromey.com>
 233
 234         PR rust/24976:
 235         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 236
 237 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 238
 239         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 240         cp_search_name_hash.
 241         * NEWS: Add entry about nested function support.
 242
 243 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 244             Andrew Burgess  <andrew.burgess@embecosm.com>
 245
 246         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 247         for nested static variables when searchin VAR_DOMAIN.
 248         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 249         global scope, update comment.
 250         (add_partial_subprogram): Call add_partial_subprogram recursively
 251         for nested subroutines when processinng Fortran.
 252         (load_partial_dies): Process the child entities of a subprogram
 253         when processing Fortran.
 254         (partial_die_parent_scope): Handle building scope
 255         for Fortran nested functions.
 256         (process_die): Record that nested functions have a scope.
 257         (new_symbol): Always record Fortran subprograms on the global
 258         symbol list.
 259         (determine_prefix): How to build the prefix for Fortran
 260         subprograms.
 261
 262 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 263
 264         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 265         have just sent the thread a SIGSTOP and are waiting for it to
 266         arrive.
 267
 268 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 269
 270         * btrace.c (btrace_add_pc): Remove whitespace before the template
 271         parameter in 'std::vector <...>'.
 272         (parse_xml_btrace_block): Likewise.
 273         (btrace_maint_decode_pt): Likewise.
 274         (btrace_maint_update_packets): Likewise.
 275         (btrace_maint_print_packets): Likewise.
 276         * btrace.h (struct btrace_maint_info): Likewise.
 277         * dwarf2read.c (struct type_unit_group): Likewise.
 278         (build_type_psymtabs_reader): Likewise.
 279         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 280         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 281         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 282
 283 2019-10-03  Tom de Vries  <tdevries@suse.de>
 284
 285         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 286         the first line of the help text for set/show style metadata.
 287
 288 2019-10-02  Tom Tromey  <tromey@adacore.com>
 289
 290         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 291         * gdbsupport/common-inferior.c: New file.
 292         * infcmd.c (startup_with_shell): Don't define.
 293         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 294         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 295         * inferior.h (startup_with_shell): Don't declare.
 296
 297 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 298
 299         * gdbsupport/gdb_assert.h: Include errors.h.
 300         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 301
 302 2019-10-02  Tom Tromey  <tromey@adacore.com>
 303
 304         * NEWS: Add $_ada_exception entry.
 305         * ada-lang.c (struct ada_catchpoint): Add constructor.
 306         <m_kind>: New member.
 307         (allocate_location_exception, re_set_exception): Remove
 308         "ex" parameter.
 309         (should_stop_exception): Compute $_ada_exception.
 310         (check_status_exception, print_it_exception)
 311         (print_one_exception, print_mention_exception): Remove
 312         "ex" parameter.
 313         (allocate_location_catch_exception, re_set_catch_exception)
 314         (check_status_exception, print_it_catch_exception)
 315         (print_one_catch_exception, print_mention_catch_exception)
 316         (print_recreate_catch_exception)
 317         (allocate_location_catch_exception_unhandled)
 318         (re_set_catch_exception_unhandled)
 319         (check_status_exception, print_it_catch_exception_unhandled)
 320         (print_one_catch_exception_unhandled)
 321         (print_mention_catch_exception_unhandled)
 322         (print_recreate_catch_exception_unhandled)
 323         (allocate_location_catch_assert, re_set_catch_assert)
 324         (check_status_assert, print_it_catch_assert)
 325         (print_one_catch_assert, print_mention_catch_assert)
 326         (print_recreate_catch_assert)
 327         (allocate_location_catch_handlers, re_set_catch_handlers)
 328         (check_status_handlers, print_it_catch_handlers)
 329         (print_one_catch_handlers, print_mention_catch_handlers)
 330         (print_recreate_catch_handlers): Remove.
 331         (create_ada_exception_catchpoint): Update.
 332         (initialize_ada_catchpoint_ops): Update.
 333
 334 2019-10-02  Tom Tromey  <tromey@adacore.com>
 335
 336         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 337         (create_excep_cond_exprs): Simplify exception string computation.
 338         (ada_exception_catchpoint_cond_string): Likewise.
 339
 340 2019-10-02  Tom Tromey  <tromey@adacore.com>
 341
 342         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 343         * ada-lang.c (lesseq_defined_than): Handle
 344         LOC_STATIC.
 345         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 346         parameter.
 347         (dwarf2_has_info): Likewise.
 348         (new_symbol): Set maybe_copied on symbol when
 349         appropriate.
 350         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 351         parameter.
 352         <can_copy>: New member.
 353         * elfread.c (record_minimal_symbol): Set maybe_copied
 354         on symbol when appropriate.
 355         (elf_symfile_read): Update call to dwarf2_has_info.
 356         * minsyms.c (lookup_minimal_symbol_linkage): New
 357         function.
 358         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 359         * symtab.c (get_symbol_address, get_msymbol_address):
 360         New functions.
 361         * symtab.h (get_symbol_address, get_msymbol_address):
 362         Declare.
 363         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 364         maybe_copied.
 365         (struct symbol, struct minimal_symbol) <maybe_copied>:
 366         New member.
 367
 368 2019-10-02  Tom Tromey  <tromey@adacore.com>
 369
 370         * source.c (struct current_source_location): New.
 371         (current_source_key): New global.
 372         (current_source_symtab, current_source_line)
 373         (current_source_pspace): Remove.
 374         (get_source_location): New function.
 375         (get_current_source_symtab_and_line)
 376         (set_default_source_symtab_and_line)
 377         (set_current_source_symtab_and_line)
 378         (clear_current_source_symtab_and_line, select_source_symtab)
 379         (info_source_command, print_source_lines_base)
 380         (info_line_command, search_command_helper, _initialize_source):
 381         Update.
 382
 383 2019-10-02  Tom Tromey  <tromey@adacore.com>
 384
 385         * source.c (select_source_symtab): Don't call
 386         decode_line_with_current_source.
 387
 388 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 389
 390         * symtab.c (lookup_global_symbol): Search global block.
 391
 392 2019-10-02  Tom Tromey  <tromey@adacore.com>
 393
 394         * coffread.c (process_coff_symbol): Update.
 395         * dwarf2read.c (var_decode_location, new_symbol): Update.
 396         * mdebugread.c (parse_symbol): Update.
 397         * objfiles.c (relocate_one_symbol): Update.
 398         * stabsread.c (define_symbol, fix_common_block)
 399         (scan_file_globals): Update.
 400         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 401         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 402         * xcoffread.c (process_xcoff_symbol): Update.
 403
 404 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 405
 406         * MAINTAINERS: Update my email address.
 407
 408 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 409
 410         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 411         std::vector.
 412         (build_type_psymtabs_reader): Update for std::vector.
 413         (build_type_psymtab_dependencies): Likewise.
 414         * dwarf2read.h: Remove use of DEF_VEC_P.
 415         (typedef sig_type_ptr): Delete.
 416
 417 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 418
 419         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 420         to std::vector.
 421         (btrace_maint_decode_pt): Likewise, and move allocation of the
 422         vector outside of the loop.
 423         (btrace_maint_update_packets): Update to handle change from VEC to
 424         std::vector.
 425         (btrace_maint_print_packets): Likewise.
 426         (maint_info_btrace_cmd): Likewise.
 427         * btrace.h: Remove use of DEF_VEC_O.
 428         (typedef btrace_pt_packet_s): Delete.
 429         (struct btrace_maint_info) <packets>: Change fromm VEC to
 430         std::vector.
 431         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 432
 433 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 434
 435         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 436         make accesses into the vector constant references.
 437         (btrace_add_pc): Update for std::vector.
 438         (btrace_stitch_bts): Likewise.
 439         (parse_xml_btrace_block): Likewise.
 440         (btrace_maint_update_packets): Likewise.
 441         (btrace_maint_print_packets): Likewise.
 442         (maint_info_btrace_cmd): Likewise.
 443         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 444         std::vector.
 445         (btrace_data::empty): Likewise.
 446         (btrace_data_append): Likewise.
 447         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 448         (typedef btrace_block_s): Delete.
 449         (struct btrace_block): Add constructor.
 450         (struct btrace_data_bts) <blocks>: Change to std::vector.
 451         * nat/linux-btrace.c (perf_event_read_bts): Update for
 452         std::vector.
 453         (linux_read_bts): Likewise.
 454
 455 2019-10-01  Tom Tromey  <tom@tromey.com>
 456
 457         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 458
 459 2019-10-01  Tom Tromey  <tom@tromey.com>
 460
 461         * stack.c (print_frame, info_frame_command_core): Use
 462         styled_string.
 463         * linux-thread-db.c (try_thread_db_load_1)
 464         (try_thread_db_load_from_pdir_1): Use styled_string.
 465         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 466         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 467         (maybe_print_unsupported_script_warning)
 468         (maybe_print_script_not_found_warning): Use styled_string.
 469         * ada-lang.c (user_select_syms): Use styled_string.
 470
 471 2019-10-01  Tom Tromey  <tom@tromey.com>
 472
 473         * p-lang.c (pascal_printstr): Use metadata style.
 474         * value.c (show_convenience): Use metadata style.
 475         * valprint.c (valprint_check_validity, val_print_optimized_out)
 476         (val_print_not_saved, val_print_unavailable)
 477         (val_print_invalid_address, generic_val_print, val_print)
 478         (value_check_printable, val_print_array_elements): Use metadata
 479         style.
 480         * ui-out.h (class ui_out) <field_fmt>: New overload.
 481         <do_field_fmt>: Add style parameter.
 482         * ui-out.c (ui_out::field_fmt): New overload.
 483         * typeprint.c (type_print_unknown_return_type)
 484         (val_print_not_allocated, val_print_not_associated): Use metadata
 485         style.
 486         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 487         parameter.
 488         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 489         * tracepoint.c (tvariables_info_1): Use metadata style.
 490         * stack.c (print_frame_arg, print_frame_info, print_frame)
 491         (info_frame_command_core): Use metadata style.
 492         * skip.c (info_skip_command): Use metadata style.
 493         * rust-lang.c (rust_print_enum): Use metadata style.
 494         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 495         metadata style.
 496         * python/py-framefilter.c (py_print_single_arg): Use metadata
 497         style.
 498         * printcmd.c (do_one_display, print_variable_and_value): Use
 499         metadata style.
 500         * p-valprint.c (pascal_val_print)
 501         (pascal_object_print_value_fields): Use metadata style.
 502         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 503         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 504         parameter.
 505         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 506         * m2-valprint.c (m2_print_long_set): Use metadata style.
 507         * m2-typeprint.c (m2_print_type): Use metadata style.
 508         * infcmd.c (print_return_value_1): Use metadata style.
 509         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 510         * f-valprint.c (info_common_command_for_block): Use metadata
 511         style.
 512         * f-typeprint.c (f_type_print_base): Use metadata style.
 513         * expprint.c (print_subexp_standard): Use metadata style.
 514         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 515         * cli/cli-style.h (class cli_style_option): Add constructor.
 516         (metadata_style): Declare.
 517         * cli/cli-style.c (metadata_style): New global.
 518         (_initialize_cli_style): Register metadata style.
 519         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 520         parameter.
 521         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 522         * c-typeprint.c (c_type_print_base_struct_union)
 523         (c_type_print_base_1): Use metadata style.
 524         * breakpoint.c (watchpoint_value_print)
 525         (print_one_breakpoint_location): Use metadata style.
 526         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 527         style.
 528         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 529         style.
 530         * ada-valprint.c (val_print_packed_array_elements, printstr)
 531         (print_field_values, ada_val_print_ref, ada_val_print): Use
 532         metadata style.
 533         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 534         style.
 535         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 536         style.
 537         * ada-lang.c (user_select_syms): Use metadata style.
 538
 539 2019-10-01  Tom Tromey  <tom@tromey.com>
 540
 541         * cli/cli-cmds.c (pwd_command): Style output.
 542
 543 2019-10-01  Pedro Alves  <palves@redhat.com>
 544             Tom Tromey  <tom@tromey.com>
 545
 546         * symtab.c (print_symbol_info): Use %ps.
 547         (print_msymbol_info): Use %ps.
 548         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 549         * printcmd.c (print_variable_and_value): Use %ps.
 550         * macrocmd.c (show_pp_source_pos): Use %ps.
 551         * infrun.c (print_exited_reason): Use ui_out::message.
 552         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 553         (describe_other_breakpoints): Use ui_out::message and new
 554         formats.
 555         (say_where): Use new formats.
 556         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 557         and new formats.
 558
 559 2019-10-01  Pedro Alves  <palves@redhat.com>
 560             Tom Tromey  <tom@tromey.com>
 561
 562         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 563         (test_gdb_formats): New function.
 564         (run_tests): Call it.
 565         (test_format_specifier): Update.
 566         * utils.h (fputs_filtered): Update comment.
 567         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 568         (fputs_styled_unfiltered): Declare.
 569         * utils.c (fputs_styled_unfiltered): New function.
 570         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 571         (vfprintf_filtered): Update.
 572         (vfprintf_unfiltered, vprintf_filtered): Update.
 573         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 574         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 575         disallow_ui_out_field>: New constants.
 576         (enum class field_kind): New.
 577         (struct base_field_s, struct signed_field_s): New.
 578         (signed_field): New function.
 579         (struct string_field_s): New.
 580         (string_field): New function.
 581         (struct styled_string_s): New.
 582         (styled_string): New function.
 583         (class ui_out) <message>: Add comment.
 584         <vmessage, call_do_message>: New methods.
 585         <do_message>: Add style parameter.
 586         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 587         methods.
 588         (ui_out::message): Rewrite.
 589         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 590         parameter.
 591         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 592         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 593         gdb_extensions parameter.
 594         (class format_piece): Add parameter to constructor.
 595         (n_int_args): New field.
 596         * gdbsupport/format.c (format_pieces::format_pieces): Add
 597         gdb_extensions parameter.  Handle '*'.
 598         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 599         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 600         vfprintf_styled_no_gdbfmt.
 601         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 602         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 603         unfiltered output.
 604         * ui-style.h (struct ui_file_style) <ptr>: New method.
 605
 606 2019-10-01  Tom Tromey  <tom@tromey.com>
 607
 608         * unittests/format_pieces-selftests.c: Update.  Add final format.
 609         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 610         empty literal pieces.
 611
 612 2019-10-01  Tom Tromey  <tom@tromey.com>
 613
 614         * ui-out.h (enum class ui_out_style_kind): Remove.
 615         (class ui_out) <field_string, field_stsream, do_field_string>:
 616         Change type of "style".
 617         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 618         (ui_out::field_string): Update.
 619         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 620         of "style".
 621         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 622         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 623         * stack.c (print_frame_arg, print_frame_info, print_frame):
 624         Update.
 625         * source.c (print_source_lines_base): Update.
 626         * solib.c (info_sharedlibrary_command): Update.
 627         * skip.c (info_skip_command): Update.
 628         * record-btrace.c (btrace_call_history_src_line)
 629         (btrace_call_history): Update.
 630         * python/py-framefilter.c (py_print_frame): Update.
 631         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 632         "style".
 633         * mi/mi-out.c (mi_ui_out::do_table_header)
 634         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 635         (mi_ui_out::do_field_string): Update.
 636         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 637         Update.
 638         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 639         "style".
 640         * cli-out.c (cli_ui_out::do_table_header)
 641         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 642         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 643         (cli_ui_out::do_field_fmt): Update.
 644         * breakpoint.c (print_breakpoint_location): Update.
 645         (update_static_tracepoint): Update.
 646
 647 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 648
 649         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 650         conversion of gdb_datadir.
 651         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 652         remove not needed c_str ().
 653
 654 2019-09-30  Ali Tamur <tamur@google.com>
 655
 656         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 657         (dwarf2_string_attr): Likewise.
 658
 659 2019-09-30  Ali Tamur <tamur@google.com>
 660
 661         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 662         (process_full_type_unit): Likewise.
 663         (dump_die_shallow): Likewise.
 664         (cu_debug_loc_section): Likewise.
 665
 666 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 667
 668         * minsyms.c (compare_minimal_symbols): Rename to...
 669         (minimal_symbol_is_less_than): ...this, and adjust to STL
 670         conventions (return bool, take arguments as references)
 671         (minimal_symbol_reader::install): Call std::sort instead
 672         of qsort.
 673
 674 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 675
 676         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 677         hash and why.
 678         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 679         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 680
 681 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 682
 683         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 684         * psympriv.h (add_psymbol_to_list): Move comment here and update
 685         it.
 686
 687 2019-09-29  Tom de Vries  <tdevries@suse.de>
 688
 689         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 690         Use $tmpdir/$(basename "$output_file").dwz instead of
 691         "${output_file}.dwz".
 692
 693 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 694
 695         PR gdb/25045
 696         * hppa-linux-nat.c: Include gdbarch.h.
 697
 698 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 699
 700         * blockframe.c (find_pc_partial_function): Change return type to bool.
 701         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 702         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 703         (stub_gnu_ifunc_resolve_name): Likewise.
 704         * symtab.c (compare_filenames_for_search): Likewise.
 705         (compare_glob_filenames_for_search): Likewise.
 706         (matching_obj_sections): Likewise.
 707         (symbol_matches_domain): Likewise.
 708         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 709         (find_line_pc): Change return type to bool.
 710         (find_line_pc_range): Likewise.
 711         (producer_is_realview): Likewise.
 712         * symtab.h (symbol_matches_domain): Likewise.
 713         (find_pc_partial_function): Likewise.
 714         (find_pc_line_pc_range): Likewise.
 715         (in_gnu_ifunc_stub): Likewise.
 716         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 717         (find_line_pc): Likewise.
 718         (find_line_pc_range): Likewise.
 719         (matching_obj_sections): Likewise.
 720         (find_line_symtab): Change out parameter to bool.
 721         (producer_is_realview): Change return type to bool.
 722         (compare_filenames_for_search): Likewise.
 723         (compare_glob_filenames_for_search): Likewise.
 724
 725 2019-09-26  Tom Tromey  <tom@tromey.com>
 726
 727         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 728         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 729         * gdb_usleep.h: Remove.
 730         * gdb_usleep.c: Remove.
 731         * utils.c: Don't include gdb_usleep.h.
 732
 733 2019-09-26  Tom Tromey  <tromey@adacore.com>
 734
 735         * python/py-type.c (type_to_type_object): Call check_typedef
 736         for stub types.
 737
 738 2019-09-26  Tom Tromey  <tom@tromey.com>
 739
 740         * utils.h (initialize_utils): Don't declare.
 741         * top.c (gdb_init): Don't call initialize_utils.
 742         * utils.c (initialize_utils): Remove.  Move contents...
 743         (_initialize_utils): ... here.
 744
 745 2019-09-25  Tom Tromey  <tom@tromey.com>
 746
 747         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 748         * utils.h (make_hex_string): Don't declare.
 749         * utils.c (make_hex_string): Remove.
 750
 751 2019-09-24  Tom de Vries  <tdevries@suse.de>
 752
 753         PR gdb/23815
 754         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 755         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 756
 757 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 758
 759         * NEWS: Mention new simulator port for PRU.
 760
 761 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 762
 763         * ada-exp.y (write_object_remaining): Update.
 764         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 765         and eliminate the static buffer.
 766         (ada_decode_symbol): Update.
 767         (ada_la_decode): Update.
 768         (ada_sniff_from_mangled_name): Update.
 769         (is_valid_name_for_wild_match): Update.
 770         (ada_lookup_name_info::matches): Update and simplify.
 771         (name_matches_regex): Update.
 772         (ada_add_global_exceptions): Update.
 773         * ada-lang.h (ada_decode): Update signature.
 774         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 775         * dwarf-index-write.c (debug_names::insert): Update.
 776
 777 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 778
 779         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 780         formatting.
 781
 782 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 783
 784         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 785         Change "nonzero" to "true" in documentation.
 786
 787 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 788
 789         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 790         (_initialize_darwin_solib): Don't set
 791         darwin_so_ops.lookup_lib_global_symbol.
 792         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 793         set_gdbarch_iterate_over_objfiles_in_search_order.
 794         (elf_lookup_lib_symbol): Rename to...
 795         (svr4_iterate_over_objfiles_in_search_order): this, and update
 796         to iterate semantics.
 797         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 798         * solib.c (solib_global_lookup): Remove.
 799         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 800         (solib_global_lookup): Remove.
 801         * symtab.c (lookup_global_or_static_symbol): Remove call to
 802         solib_global_lookup.
 803
 804 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 805
 806         * NEWS: Move entries about default MI version now being
 807         version 3, and about the GDB/MI fix for multi-location
 808         breakpoints to the "since GDB 8.3" section.
 809
 810 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 811
 812         GDB 8.3.1 released.
 813
 814 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 815
 816         * NEWS: Mention that Cell/B.E. debugging support was removed.
 817         * MAINTAINERS: Remove spu target.
 818
 819         * config/djgpp/fnchange.lst: Remove entries for removed files.
 820
 821         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 822         spu-multiarch.o, and spu-tdep.o.
 823         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 824         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 825         spu-multiarch.c, and spu-tdep.c.
 826         * spu-linux-nat.c: Remove file.
 827         * spu-multiarch.c: Remove file.
 828         * spu-tdep.c: Remove file.
 829         * spu-tdep.h: Remove file.
 830         * solib-spu.c: Remove file.
 831         * solib-spu.h: Remove file.
 832
 833         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 834         * configure.nat (spu-linux): Remove.
 835         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 836         solib-multiarch.o from gdb_target_obs.
 837         (spu*-*-*): Remove.
 838
 839         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 840         feature flag.
 841         (ppc_linux_no_features): Update.
 842         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 843         Cell/B.E. support.
 844         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 845         (tdesc_powerpc_cell64l): Likewise.
 846         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 847         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 848         Cell/B.E. support.
 849         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 850         Do not include "features/rs6000/powerpc-cell32l.c" or
 851         "features/rs6000/powerpc-cell64l.c".
 852         (ppc_linux_spu_section): Remove.
 853         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 854         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 855         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 856         (ppc_linux_spe_context_lookup): Remove.
 857         (ppc_linux_spe_context_inferior_created): Remove.
 858         (ppc_linux_spe_context_solib_loaded): Remove.
 859         (ppc_linux_spe_context_solib_unloaded): Remove.
 860         (ppc_linux_spe_context): Remove.
 861         (struct ppu2spu_cache): Remove.
 862         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 863         (struct ppu2spu_data): Remove.
 864         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 865         ppu2spu_unwind): Remove.
 866         (ppc_linux_init_abi): Remove Cell/B.E. support.
 867         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 868
 869         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 870         (rs6000/powerpc-cell64l-expedite): Likewise
 871         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 872         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 873         rs6000/powerpc-cell64l.xml.
 874         * features/rs6000/powerpc-cell32l.xml: Remove.
 875         * features/rs6000/powerpc-cell64l.xml: Likewise.
 876         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 877         * features/rs6000/powerpc-cell64l.c: Likewise.
 878         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 879         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 880         * regformats/reg-spu.dat: Remove.
 881
 882         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 883         * corelow.c (struct spuid_list): Remove.
 884         (add_to_spuid_list): Remove.
 885         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 886         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 887         (remote_protocol_features): Remove associated entries.
 888         (_initialize_remote): No longer initialize them.
 889         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 890         * linux-nat.c (SPUFS_MAGIC): Remove.
 891         (linux_proc_xfer_spu): Remove.
 892         (spu_enumerate_spu_ids): Remove.
 893         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 894         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 895         (linux_make_corefile_notes): No longer call it.
 896
 897         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 898         (cooked_write_test): Likewise.
 899
 900 2019-09-20  Tom Tromey  <tom@tromey.com>
 901
 902         * NEWS: Mention case-sensitivity of TUI commands.
 903         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 904         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 905         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 906
 907 2019-09-20  Tom Tromey  <tom@tromey.com>
 908
 909         * tui/tui-source.c (tui_source_window::set_contents): Use
 910         make_unique_xstrdup.
 911         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 912         make_unique_xstrdup.
 913
 914 2019-09-20  Tom Tromey  <tom@tromey.com>
 915
 916         * tui/tui-data.c: Remove separator comments.
 917         * tui/tui-layout.c: Remove separator comments.
 918         * tui/tui-win.c: Remove separator comments.
 919         * tui/tui-wingeneral.c: Remove separator comments.
 920
 921 2019-09-20  Tom Tromey  <tom@tromey.com>
 922
 923         * tui/tui.h (strcat_to_buf): Don't declare.
 924         * tui/tui.c (strcat_to_buf): Remove.
 925
 926 2019-09-20  Tom Tromey  <tom@tromey.com>
 927
 928         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 929         from "fullname".
 930         * tui/tui-source.c (tui_source_window::set_contents)
 931         (tui_source_window::location_matches_p)
 932         (tui_source_window::maybe_update): Update.
 933
 934 2019-09-20  Tom Tromey  <tom@tromey.com>
 935
 936         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 937         Update.
 938         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 939         prefix.
 940         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 941         (tui_data_window::line_from_reg_element_no)
 942         (tui_data_window::first_reg_element_no_inline)
 943         (tui_data_window::show_registers)
 944         (tui_data_window::show_register_group)
 945         (tui_data_window::display_registers_from)
 946         (tui_data_window::display_registers_from_line)
 947         (tui_data_window::first_data_item_displayed)
 948         (tui_data_window::delete_data_content_windows)
 949         (tui_data_window::erase_data_content)
 950         (tui_data_window::do_scroll_vertical)
 951         (tui_data_window::refresh_window)
 952         (tui_data_window::check_register_values): Update.
 953
 954 2019-09-20  Tom Tromey  <tom@tromey.com>
 955
 956         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 957         (struct tui_locator_window) <full_name, proc_name>: Now
 958         std::string.
 959         * tui/tui-stack.c (tui_locator_window::make_status_line)
 960         (tui_locator_window::set_locator_fullname)
 961         (tui_locator_window::set_locator_info): Update.
 962         * tui/tui-source.c (tui_source_window::set_contents)
 963         (tui_source_window::showing_source_p): Update.
 964
 965 2019-09-20  Tom Tromey  <tom@tromey.com>
 966
 967         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 968         Don't call tui_locator_win_info_ptr.
 969
 970 2019-09-20  Tom Tromey  <tom@tromey.com>
 971
 972         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 973
 974 2019-09-20  Tom Tromey  <tom@tromey.com>
 975
 976         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 977         height for locator.
 978         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 979         * tui/tui-layout.c (show_source_disasm_command, show_data)
 980         (show_source_or_disasm_and_command): Use 1 as height for locator.
 981
 982 2019-09-20  Tom Tromey  <tom@tromey.com>
 983
 984         * tui/tui.c (tui_enable): Update.
 985         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 986         Update.
 987         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 988         Update.
 989         * tui/tui-data.c (win_resized): Now bool.
 990         (tui_win_resized): Return bool.
 991         (tui_set_win_resized_to): Accept a bool.
 992
 993 2019-09-20  Tom Tromey  <tom@tromey.com>
 994
 995         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 996         Change type of "refresh_values_only".
 997         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 998         type of "refresh_values_only".
 999
1000 2019-09-20  Tom Tromey  <tom@tromey.com>
1001
1002         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1003         std::string.
1004         (tui_disassemble): Add "pos" parameter.
1005         (tui_disasm_window::set_contents): Simplify.
1006
1007 2019-09-20  Tom Tromey  <tom@tromey.com>
1008
1009         * tui/tui-winsource.h (struct tui_source_window_base)
1010         <show_source_content>: Now private.
1011         * tui/tui-winsource.c
1012         (tui_source_window_base::show_source_content): Don't handle empty
1013         content case.
1014
1015 2019-09-20  Tom Tromey  <tom@tromey.com>
1016
1017         * tui/tui-layout.c (show_source_disasm_command)
1018         (show_source_or_disasm_and_command): Don't call
1019         show_source_content.
1020
1021 2019-09-20  Tom Tromey  <tom@tromey.com>
1022
1023         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1024         Declare.
1025         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1026         from tui_make_status_line.
1027         (tui_locator_window::rerender): Update.
1028
1029 2019-09-20  Tom Tromey  <tom@tromey.com>
1030
1031         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1032         (tui_locator_window::rerender): Update.
1033
1034 2019-09-20  Tom Tromey  <tom@tromey.com>
1035
1036         * tui/tui-winsource.h (struct tui_source_window_base)
1037         <~tui_source_window_base>: Don't declare.
1038         <fullname>: Remove.
1039         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1040         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1041         member.
1042         * tui/tui-source.c (tui_source_window::set_contents): Update.
1043         (tui_source_window::location_matches_p)
1044         (tui_source_window::maybe_update): Update.
1045
1046 2019-09-20  Tom Tromey  <tom@tromey.com>
1047
1048         * tui/tui-winsource.h (~tui_source_element): Remove.
1049         (tui_source_element): Update.
1050         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1051         * tui/tui-winsource.c (tui_show_source_line): Update.
1052         * tui/tui-source.c (tui_source_window::set_contents): Update.
1053         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1054
1055 2019-09-20  Tom Tromey  <tom@tromey.com>
1056
1057         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1058         declare.
1059         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1060         tui_clear_source_windows_detail.
1061         * tui/tui-winsource.h (struct tui_source_window_base)
1062         <clear_detail>: Don't declare.
1063         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1064         Remove.
1065         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1066
1067 2019-09-20  Tom Tromey  <tromey@adacore.com>
1068
1069         PR ada/24919:
1070         * block.c (contained_in): Fix final return value.
1071
1072 2019-09-20  Alan Modra  <amodra@gmail.com>
1073
1074         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1075         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1076         (read_indirect_string_from_dwz): Use bfd accessor.
1077         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1078         * machoread.c (macho_symfile_read_all_oso): Likewise.
1079         * solib.c (solib_bfd_open): Likewise.
1080
1081 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1082
1083         * eval.c: Move declaration of overload_resolution to...
1084         * value.h: ...here.
1085
1086 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1087
1088         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1089         * arm-linux-tdep.c: Likewise.
1090         * arm-nbsd-nat.c: Likewise.
1091         * arm-tdep.h: Declare arm_apcs_32.
1092         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1093
1094 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1095
1096         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1097         * dwarf2read.h: Declare dwarf_always_disassemble.
1098
1099 2019-09-19  Tom de Vries  <tdevries@suse.de>
1100
1101         PR gdb/25009
1102         * source-cache.c (source_cache::ensure): Catch exception thrown during
1103         construction of the highlighter.
1104
1105 2019-09-18  Alan Modra  <amodra@gmail.com>
1106
1107         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1108         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1109         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1110         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1111         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1112         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1113         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1114         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1115         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1116         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1117         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1118         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1119         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1120         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1121         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1122         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1123         * mi/mi-interp.c: Update throughout for bfd section macro and
1124         function changes.
1125         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1126         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1127
1128 2019-09-18  Tom Tromey  <tom@tromey.com>
1129
1130         * NEWS: Add entry.
1131         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1132         call rl_initialize.
1133         (tui_enable): Do not call rl_initialize.
1134
1135 2019-09-18  Christian Groessler  <chris@groessler.org>
1136
1137         * alpha-linux-nat.c: Include gdbarch.h.
1138
1139 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1140
1141         * ui-file.c: Include cli/cli-style.h.
1142         (term_cli_styling): Remove cli_styling declaration.
1143
1144 2019-09-18  Alan Modra  <amodra@gmail.com>
1145
1146         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1147         to bfd_asymbol_section.
1148
1149 2019-09-18  Alan Modra  <amodra@gmail.com>
1150
1151         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1152         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1153         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1154
1155 2019-09-18  Alan Modra  <amodra@gmail.com>
1156
1157         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1158         * spu-linux-nat.c (spu_bfd_open): Likewise.
1159
1160 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1161
1162         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1163         to bool to match definition in dwarf2read.c.
1164
1165 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1166
1167         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1168         (print_signatures): Likewise.
1169         (trust_pad_over_xvs): Likewise.
1170         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1171         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1172         * arm-linux-nat.c (arm_apcs_32): Likewise.
1173         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1174         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1175         * arm-tdep.c (arm_debug): Likewise.
1176         (arm_apcs_32): Likewise.
1177         * auto-load.c (debug_auto_load): Likewise.
1178         (auto_load_gdb_scripts): Likewise.
1179         (global_auto_load): Likewise.
1180         (auto_load_local_gdbinit): Likewise.
1181         (auto_load_local_gdbinit_loaded): Likewise.
1182         * auto-load.h (global_auto_load): Likewise.
1183         (auto_load_local_gdbinit): Likewise.
1184         (auto_load_local_gdbinit_loaded): Likewise.
1185         * breakpoint.c (disconnected_dprintf): Likewise.
1186         (breakpoint_proceeded): Likewise.
1187         (automatic_hardware_breakpoints): Likewise.
1188         (always_inserted_mode): Likewise.
1189         (target_exact_watchpoints): Likewise.
1190         (_initialize_breakpoint): Update.
1191         * breakpoint.h (target_exact_watchpoints): Change to bool.
1192         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1193         * cli/cli-cmds.c (trace_commands): Likewise.
1194         * cli/cli-cmds.h (trace_commands): Likewise.
1195         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1196         to bool*.
1197         * cli/cli-logging.c (logging_overwrite): Change to bool.
1198         (logging_redirect): Likewise.
1199         (debug_redirect): Likewise.
1200         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1201         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1202         to bool.
1203         <boolean_option_def>: Update.
1204         (struct flag_option_def): Change default type of Context to bool
1205         from int.
1206         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1207         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1208         (get_setshow_command_value_string): Likewise.
1209         * cli/cli-style.c (cli_styling): Change to bool.
1210         (source_styling): Likewise.
1211         * cli/cli-style.h (source_styling): Likewise.
1212         (cli_styling): Likewise.
1213         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1214         to bool.
1215         * command.h (var_types): Update comment.
1216         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1217         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1218         bool.
1219         (debug_compile_cplus_scopes): Likewise.
1220         * compile/compile-internal.h (compile_debug): Likewise.
1221         * compile/compile.c (compile_debug): Likewise.
1222         (struct compile_options) <raw>: Likewise.
1223         * cp-support.c (catch_demangler_crashes): Likewise.
1224         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1225         (usr_cmd_cris_dwarf2_cfi): Likewise.
1226         * csky-tdep.c (csky_debug): Likewise.
1227         * darwin-nat.c (enable_mach_exceptions): Likewise.
1228         * dcache.c (dcache_enabled_p): Likewise.
1229         * defs.h (info_verbose): Likewise.
1230         * demangle.c (demangle): Likewise.
1231         (asm_demangle): Likewise.
1232         * dwarf-index-cache.c (debug_index_cache): Likewise.
1233         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1234         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1235         * dwarf2read.c (check_physname): Likewise.
1236         (use_deprecated_index_sections): Likewise.
1237         (dwarf_always_disassemble): Likewise.
1238         * eval.c (overload_resolution): Likewise.
1239         * event-top.c (set_editing_cmd_var): Likewise.
1240         (exec_done_display_p): Likewise.
1241         * event-top.h (set_editing_cmd_var): Likewise.
1242         (exec_done_display_p): Likewise.
1243         * exec.c (write_files): Likewise.
1244         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1245         (debug_fbsd_nat): Likewise.
1246         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1247         Likewise.
1248         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1249         <backtrace_past_entry> Likewise.
1250         * gdb-demangle.h (demangle): Likewise.
1251         (asm_demangle): Likewise.
1252         * gdb_bfd.c (bfd_sharing): Likewise.
1253         * gdbcore.h (write_files): Likewise.
1254         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1255         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1256         * gdbthread.h (print_thread_events): Likewise.
1257         * gdbtypes.c (opaque_type_resolution): Likewise.
1258         (strict_type_checking): Likewise.
1259         * gnu-nat.c (gnu_debug_flag): Likewise.
1260         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1261         * guile/scm-param.c (pascm_variable): Add boolval.
1262         (add_setshow_generic): Update.
1263         (pascm_param_value): Update.
1264         (pascm_set_param_value_x): Update.
1265         * hppa-tdep.c (hppa_debug): Change to bool..
1266         * infcall.c (may_call_functions_p): Likewise.
1267         (coerce_float_to_double_p): Likewise.
1268         (unwind_on_signal_p): Likewise.
1269         (unwind_on_terminating_exception_p): Likewise.
1270         * infcmd.c (startup_with_shell): Likewise.
1271         * inferior.c (print_inferior_events): Likewise.
1272         * inferior.h (startup_with_shell): Likewise.
1273         (print_inferior_events): Likewise.
1274         * infrun.c (step_stop_if_no_debug): Likewise.
1275         (detach_fork): Likewise.
1276         (debug_displaced): Likewise.
1277         (disable_randomization): Likewise.
1278         (non_stop): Likewise.
1279         (non_stop_1): Likewise.
1280         (observer_mode): Likewise.
1281         (observer_mode_1): Likewise.
1282         (set_observer_mode): Update.
1283         (sched_multi): Change to bool.
1284         * infrun.h (debug_displaced): Likewise.
1285         (sched_multi): Likewise.
1286         (step_stop_if_no_debug): Likewise.
1287         (non_stop): Likewise.
1288         (disable_randomization): Likewise.
1289         * linux-tdep.c (use_coredump_filter): Likewise.
1290         (dump_excluded_mappings): Likewise.
1291         * linux-thread-db.c (auto_load_thread_db): Likewise.
1292         (check_thread_db_on_load): Likewise.
1293         * main.c (captured_main_1): Update.
1294         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1295         xx2_opt, boolean_opt>: Change to bool.
1296         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1297         * maint.c (maintenance_profile_p): Likewise.
1298         (per_command_time): Likewise.
1299         (per_command_space): Likewise.
1300         (per_command_symtab): Likewise.
1301         * memattr.c (inaccessible_by_default): Likewise.
1302         * mi/mi-main.c (mi_async): Likewise.
1303         (mi_async_1): Likewise.
1304         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1305         * nat/fork-inferior.h (startup_with_shell): Likewise.
1306         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1307         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1308         * nios2-tdep.c (nios2_debug): Likewise.
1309         * or1k-tdep.c (or1k_debug): Likewise.
1310         * parse.c (parser_debug): Likewise.
1311         * parser-defs.h (parser_debug): Likewise.
1312         * printcmd.c (print_symbol_filename): Likewise.
1313         * proc-api.c (procfs_trace): Likewise.
1314         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1315         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1316         (set_parameter_value): Update.
1317         (add_setshow_generic): Update.
1318         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1319         to bool*.
1320         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1321         int*.
1322         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1323         * record-btrace.c (record_btrace_target::store_registers): Update.
1324         * record-full.c (record_full_memory_query): Change to bool.
1325         (record_full_stop_at_limit): Likewise.
1326         * record-full.h (record_full_memory_query): Likewise.
1327         * remote-notif.c (notif_debug): Likewise.
1328         * remote-notif.h (notif_debug): Likewise.
1329         * remote.c (use_range_stepping): Likewise.
1330         (interrupt_on_connect): Likewise.
1331         (remote_break): Likewise.
1332         * ser-tcp.c (tcp_auto_retry): Likewise.
1333         * ser-unix.c (serial_hwflow): Likewise.
1334         * skip.c (debug_skip): Likewise.
1335         * solib-aix.c (solib_aix_debug): Likewise.
1336         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1337         (spu_auto_flush_cache_p): Likewise.
1338         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1339         Likewise.
1340         (struct info_print_options) <quiet>: Likewise.
1341         * symfile-debug.c (debug_symfile): Likewise.
1342         * symfile.c (auto_solib_add): Likewise.
1343         (separate_debug_file_debug): Likewise.
1344         * symfile.h (auto_solib_add): Likewise.
1345         (separate_debug_file_debug): Likewise.
1346         * symtab.c (basenames_may_differ): Likewise.
1347         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1348         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1349         (struct info_types_options) <quiet>: Likewise.
1350         * symtab.h (demangle): Likewise.
1351         (basenames_may_differ): Likewise.
1352         * target-dcache.c (stack_cache_enabled_1): Likewise.
1353         (code_cache_enabled_1): Likewise.
1354         * target.c (trust_readonly): Likewise.
1355         (may_write_registers): Likewise.
1356         (may_write_memory): Likewise.
1357         (may_insert_breakpoints): Likewise.
1358         (may_insert_tracepoints): Likewise.
1359         (may_insert_fast_tracepoints): Likewise.
1360         (may_stop): Likewise.
1361         (auto_connect_native_target): Likewise.
1362         (target_stop_and_wait): Update.
1363         (target_async_permitted): Change to bool.
1364         (target_async_permitted_1): Likewise.
1365         (may_write_registers_1): Likewise.
1366         (may_write_memory_1): Likewise.
1367         (may_insert_breakpoints_1): Likewise.
1368         (may_insert_tracepoints_1): Likewise.
1369         (may_insert_fast_tracepoints_1): Likewise.
1370         (may_stop_1): Likewise.
1371         * target.h (target_async_permitted): Likewise.
1372         (may_write_registers): Likewise.
1373         (may_write_memory): Likewise.
1374         (may_insert_breakpoints): Likewise.
1375         (may_insert_tracepoints): Likewise.
1376         (may_insert_fast_tracepoints): Likewise.
1377         (may_stop): Likewise.
1378         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1379         (make_thread_apply_all_options_def_group): Change argument from int*
1380         to bool*.
1381         (thread_apply_all_command): Update.
1382         (print_thread_events): Change to bool.
1383         * top.c (confirm): Likewise.
1384         (command_editing_p): Likewise.
1385         (history_expansion_p): Likewise.
1386         (write_history_p): Likewise.
1387         (info_verbose): Likewise.
1388         * top.h (confirm): Likewise.
1389         (history_expansion_p): Likewise.
1390         * tracepoint.c (disconnected_tracing): Likewise.
1391         (circular_trace_buffer): Likewise.
1392         * typeprint.c (print_methods): Likewise.
1393         (print_typedefs): Likewise.
1394         * utils.c (debug_timestamp): Likewise.
1395         (sevenbit_strings): Likewise.
1396         (pagination_enabled): Likewise.
1397         * utils.h (sevenbit_strings): Likewise.
1398         (pagination_enabled): Likewise.
1399         * valops.c (overload_resolution): Likewise.
1400         * valprint.h (struct value_print_options) <prettyformat_arrays,
1401         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1402         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1403         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1404         Likewise.
1405         * windows-nat.c (new_console): Likewise.
1406         (cygwin_exceptions): Likewise.
1407         (new_group): Likewise.
1408         (debug_exec): Likewise.
1409         (debug_events): Likewise.
1410         (debug_memory): Likewise.
1411         (debug_exceptions): Likewise.
1412         (useshell): Likewise.
1413         * windows-tdep.c (maint_display_all_tib): Likewise.
1414         * xml-support.c (debug_xml): Likewise.
1415
1416 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1417
1418         * source.c (prepare_path_for_appending): New function.
1419         (openp): Make use of new function.
1420         (find_and_open_source): Search for the compilation directory and
1421         source file as a relative path beneath the directory search path.
1422
1423 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1424
1425         * source-cache.c (source_cache::get_line_charpos): Catch
1426         exceptions and return false, this matches the behaviour documented
1427         in the header file.
1428
1429 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1430
1431         * ada-tasks.c (info_task): Remove quoting of the task's name.
1432
1433 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1434
1435         * symfile.c (auto_solib_add): Replace comment with a reference
1436         to the header file.
1437
1438 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1439
1440         * NEWS: Mention that gdb can now be compiled with Python 3
1441         on Windows.
1442
1443 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1444
1445         * maint.c (maint_print_section_data::maint_print_section_data):
1446         Force use of 'float log10 (float)' by casting the argument to
1447         float.
1448
1449 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1450
1451         * maint.c: Add 'cmath' include.
1452         (struct maint_print_section_data): New structure.
1453         (print_section_index): New function.
1454         (print_bfd_section_info): Add header comment, small whitespace
1455         cleanup, and update to call new print_section_index function.
1456         (print_objfile_section_info): Likewise.
1457         (maint_obj_section_from_bfd_section): New function.
1458         (print_bfd_section_info_maybe_relocated): New function.
1459         (maintenance_info_sections): Add header comment, always use
1460         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1461
1462 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1463
1464         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1465         inner scope, add check that the objfile has psymtabs before
1466         checking psymtabs_addrmap.
1467         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1468
1469 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1470
1471         * NEWS: Announce that Ada task names are now shown at more places,
1472         and between quotes (except in info task output).
1473         * gdb/ada-tasks.c (task_to_str): New function.
1474         (display_current_task_id): Call task_to_str.
1475         (task_command_1): Likewise.
1476         (print_ada_task_info): In non-mi mode, Properly align headers and data
1477         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1478
1479 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1480
1481         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1482         prstatus.pr_lwp.pr_info instead of making it up.
1483
1484 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1485
1486         * auto-load.c (auto_load_expand_dir_vars): Update.
1487         * defs.h (gdb_datadir): Change to std::string.
1488         (python_libdir): Likewise.
1489         (relocate_gdb_directory): Change return type to std::string.
1490         * guile/guile.c (gdbscm_data_directory): Update.
1491         (initialize_scheme_side): Update.
1492         * jit.c (jit_reader_dir): Change to std::string.
1493         (jit_reader_load_command): Update.
1494         * main.c (gdb_datadir): Change to std::string.
1495         (python_libdir): Likewise.
1496         (set_gdb_data_directory): Update.
1497         (relocate_path): Change to return std::string.
1498         (relocate_gdb_directory): Change to return std::string.
1499         (relocate_gdbinit_path_maybe_in_datadir): Update.
1500         (captured_main_1): Update.
1501         * python/python.c (do_start_initialization): Update.
1502         * top.c (show_gdb_datadir): Update.
1503         * xml-syscall.c (xml_init_syscalls_info): Update.
1504         (init_syscalls_info): Update.
1505
1506 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1507
1508         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1509         out of get_init_files.
1510         (get_init_files): Update.
1511
1512 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1513
1514         * main.c (get_init_files): Change to use std::string.
1515         (captured_main_1): Update.
1516         (print_gdb_help): Update.
1517
1518 2019-09-11  Ali Tamur  <tamur@google.com>
1519
1520         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1521         implementation.
1522
1523 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1524
1525         * dbxread.c (read_dbx_symtab): Update.
1526         * dwarf2read.c (load_partial_dies): Update.
1527         * mdebugread.c (parse_partial_symbols): Update.
1528         (handle_psymbol_enumerators): Update.
1529         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1530         * psymtab.c (add_psymbol_to_bcache): Likewise.
1531         (add_psymbol_to_list): Likewise.
1532         * symtab.c (symbol_set_names): Likewise.
1533         * symtab.h (symbol_set_names): Likewise.
1534         * xcoffread.c (scan_xcoff_symtab): Update.
1535
1536 2019-09-11  Tom Tromey  <tom@tromey.com>
1537
1538         * symfile-mem.c (symbol_file_add_from_memory): Use
1539         bfd_set_filename.
1540         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1541         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1542
1543 2019-09-10  Tom Tromey  <tromey@adacore.com>
1544
1545         * dwarf-index-write.c (write_psymbols): Extend error message.
1546         (debug_names::insert): Add Ada code.
1547         (debug_names::write_psymbols): Remove Ada check.
1548         (debug_names) <m_string_obstack>: New member.
1549         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1550         (gdb_index_symbol_name_matcher::matches): Remove.
1551         (mapped_index_base::find_name_components_bounds): Add "lang"
1552         parameter.
1553         (mapped_index_base::build_name_components): Also split names
1554         according to Ada syntax.
1555         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1556         type of "match_callback".
1557         (check_match, check_find_bounds_finds)
1558         (dw2_expand_symtabs_matching): Update.
1559         (dw2_debug_names_iterator): Add new constructor.
1560         (dw2_debug_names_map_matching_symbols): New function.
1561         (dw2_debug_names_expand_symtabs_matching): Update.
1562         (dwarf2_debug_names_functions): Use
1563         dw2_debug_names_map_matching_symbols.
1564
1565 2019-09-10  Tom Tromey  <tromey@adacore.com>
1566
1567         * dwarf2read.c (dw2_get_file_names_reader): Add the
1568         CU's file name to the results.
1569
1570 2019-09-10  Tom Tromey  <tromey@adacore.com>
1571
1572         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1573         map_matching_symbols.  Update.
1574         * dwarf2read.c (dw2_map_matching_symbols): Update.
1575         * psymtab.c (match_partial_symbol): Change type; update.
1576         (psym_map_matching_symbols): Likewise.
1577         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1578         type; update.
1579         * symfile.h (struct quick_symbol_functions)
1580         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1581         Remove "match".
1582
1583 2019-09-10  Tom Tromey  <tromey@adacore.com>
1584
1585         * psymtab.c (map_block): Remove.
1586         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1587         * symtab.c (iterate_over_symbols_terminated): New function.
1588         * symtab.c (iterate_over_symbols_terminated): Declare.
1589
1590 2019-09-10  Tom Tromey  <tromey@adacore.com>
1591
1592         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1593         * language.h (struct language_defn) <la_iterate_over_symbols>:
1594         Return bool.
1595         * symtab.c (iterate_over_symbols): Return bool.
1596         * symtab.h (iterate_over_symbols): Return bool.
1597
1598 2019-09-10  Tom Tromey  <tromey@adacore.com>
1599
1600         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1601         (add_nonlocal_symbols): Update.
1602         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1603         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1604         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1605         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1606         Change type of "callback".  Remove "data".
1607
1608
1609 2019-09-09  Ali Tamur  <tamur@google.com>
1610
1611         * dwarf2read.c (comp_unit_head): Update comment.
1612         (dwarf2_dwo_name): New function declaration.
1613         (dwarf_unit_type_name): New function declaration.
1614         (read_comp_unit_head): Add support for new compilation units,
1615         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1616         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1617         (currently named as "signature") in their header. Also clarify error
1618         messages.
1619         (lookup_dwo_id): New function. Returns the dwo id of the given
1620         compile unit.
1621         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1622         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1623         functions.
1624         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1625         (dwarf2_dwo_name): Get the dwo name if present.
1626         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1627         purposes.
1628
1629 2019-09-09  Tom Tromey  <tom@tromey.com>
1630
1631         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1632
1633 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1634
1635         * python/python.c (do_start_initialization): Make progname_copy static,
1636         to avoid a leak report.
1637
1638 2019-09-08  Tom Tromey  <tom@tromey.com>
1639
1640         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1641
1642 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1643
1644         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1645         Change type to gdb::optional<block_enum>.
1646         (dw2_symtab_iter_init): Change block_index parameter type
1647         to gdb::optional<block_enum>.
1648         (dw2_lookup_symbol): Change block_index parameter
1649         type to block_enum.c
1650         (dw2_debug_names_lookup_symbol): Likewise.
1651         * psymtab.c (psym_lookup_symbol): Likewise.
1652         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1653         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1654         Likewise.
1655
1656 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1657
1658         * defs.h (relocate_gdb_directory): Change int to bool in
1659         signature and rename flag to relocatable.
1660         * main.c (relocate_path): Likewise.
1661         (relocate_gdb_directory): Likewise.
1662
1663 2019-09-06  Alan Modra  <amodra@gmail.com>
1664
1665         * coffread.c (coff_symfile_read): Constify filename variable.
1666         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1667         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1668         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1669         * solib.c (reload_shared_libraries_1): Likewise.
1670         * symfile.c (reread_symbols): Likewise.
1671         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1672         * solib-darwin.c (darwin_bfd_open): Likewise.
1673         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1674
1675 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1676
1677         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1678         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1679
1680 2019-09-03  Tom Tromey  <tromey@adacore.com>
1681
1682         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1683         types.
1684         (has_negatives): Unbias a range type bound.
1685         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1686         * gdbtypes.c (operator==): Handle new field.
1687         (create_range_type): Add "bias" parameter.
1688         (create_static_range_type, resolve_dynamic_range): Update.
1689         * gdbtypes.h (struct range_bounds) <bias>: New member.
1690         (create_range_type): Add bias parameter.
1691         * printcmd.c (print_scalar_formatted): Unbias range types.
1692         * value.c (unpack_long): Unbias range types.
1693         (pack_long): Bias range types.
1694
1695 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1696
1697         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1698         probe arguments.
1699
1700 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1701
1702         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1703         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1704         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1705         (compile_probe_arg): Likewise.
1706         * probe.h (get_argument_count): Likewise.
1707         * solib-svr4.c (solib_event_probe_action): Likewise.
1708         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1709
1710 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1711
1712         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1713         code to here...
1714         (svr4_create_solib_event_breakpoints): ...from here.
1715
1716 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1717
1718         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1719         suffix from warning message.
1720
1721 2019-08-30  Tom Tromey  <tom@tromey.com>
1722
1723         * tui/tui-winsource.h (struct tui_source_window_base)
1724         <refresh_all>: Don't declare.
1725         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1726         Remove.
1727         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1728         tui_show_locator_content.
1729         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1730         declare.
1731         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1732         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1733         declare.
1734
1735 2019-08-30  Tom Tromey  <tom@tromey.com>
1736
1737         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1738
1739 2019-08-30  Tom Tromey  <tom@tromey.com>
1740
1741         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1742         Remove unnecessary forward declarations.
1743
1744 2019-08-30  Tom Tromey  <tom@tromey.com>
1745
1746         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1747         rerender.
1748         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1749         tui_show_locator_content.
1750
1751 2019-08-30  Tom Tromey  <tom@tromey.com>
1752
1753         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1754         (tui_locator_window::rerender): Rewrite using body of previous
1755         tui_show_locator_content.
1756
1757 2019-08-30  Tom Tromey  <tom@tromey.com>
1758
1759         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1760         set_locator_fullname>: New methods.
1761         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1762         Rename from tui_set_locator_fullname.
1763         (tui_locator_window::set_locator_info): Rename from
1764         tui_set_locator_info.  Return bool.
1765         (tui_update_locator_fullname, tui_show_frame_info): Update.
1766
1767 2019-08-30  Tom Tromey  <tom@tromey.com>
1768
1769         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1770
1771 2019-08-30  Tom Tromey  <tom@tromey.com>
1772
1773         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1774         call touchwin.
1775
1776 2019-08-30  Tom Tromey  <tom@tromey.com>
1777
1778         * tui/tui-wingeneral.c (box_win): Assume win_info and
1779         win_info->handle cannot be NULL.
1780
1781 2019-08-30  Tom Tromey  <tom@tromey.com>
1782
1783         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1784         refresh_window>: Declare.
1785         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1786         resize.
1787         (tui_data_item_window::rerender): Rename from
1788         tui_display_register.
1789         (tui_data_item_window::refresh_window): New method.
1790         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1791         no-op.
1792
1793 2019-08-30  Tom Tromey  <tom@tromey.com>
1794
1795         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1796         regs_column_count, current_group>: Move later.  Now private.
1797         <get_current_group>: New method.
1798         * tui/tui-regs.c (tui_reg_command): Update.
1799         * tui/tui-layout.c (tui_set_layout): Update.
1800
1801 2019-08-30  Tom Tromey  <tom@tromey.com>
1802
1803         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1804         (tui_data_window::rerender): Don't call
1805         check_and_display_highlight_if_needed.
1806         (tui_data_window::refresh_all): Remove call to
1807         erase_data_content.
1808
1809 2019-08-30  Tom Tromey  <tom@tromey.com>
1810
1811         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1812         (tui_data_window::display_registers_from)
1813         (tui_data_window::display_reg_element_at_line)
1814         (tui_data_window::display_registers_from_line): Remove checks of
1815         "empty".
1816
1817 2019-08-30  Tom Tromey  <tom@tromey.com>
1818
1819         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1820         Don't declare.
1821         * tui/tui-regs.c (tui_data_window::show_registers): Call
1822         rerender.
1823         (tui_data_window::rerender): Rename from display_all_data.
1824         (tui_data_window::rerender): Remove old implementation.
1825
1826 2019-08-30  Tom Tromey  <tom@tromey.com>
1827
1828         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1829         text.
1830         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1831
1832 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1833             Sergio Durigan Junior  <sergiodj@redhat.com>
1834
1835         PR win32/24284
1836         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1837
1838 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1839
1840         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1841         when searching for types.
1842
1843 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1844
1845         * f-lang.c (f_language_defn): Use f_print_typedef.
1846         * f-lang.h (f_print_typedef): Declare.
1847         * f-typeprint.c (f_print_typedef): Define.
1848
1849 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1850
1851         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1852
1853 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1854
1855         * cli/cli-utils.c (info_print_options_defs): Delete.
1856         (make_info_print_options_def_group): Delete.
1857         (extract_info_print_options): Delete.
1858         (info_print_command_completer): Delete.
1859         (info_print_args_help): Add extra parameter, and optionally
1860         include text about -n flag.
1861         * cli/cli-utils.h (struct info_print_options): Delete.
1862         (extract_info_print_options): Delete declaration.
1863         (info_print_command_completer): Delete declaration.
1864         (info_print_args_help): Add extra parameter, extend header
1865         comment.
1866         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1867         search_symbols.
1868         * stack.c (struct info_print_options): New type.
1869         (info_print_options_defs): New file scoped variable.
1870         (make_info_print_options_def_group): New static function.
1871         (info_print_command_completer): New static function.
1872         (info_locals_command): Update to use new local functions.
1873         (info_args_command): Likewise.
1874         (_initialize_stack): Add extra parameter to calls to
1875         info_print_args_help.
1876         * symtab.c (search_symbols): Add extra parameter, use this to
1877         possibly excluse non-debug symbols.
1878         (symtab_symbol_info): Add extra parameter, which is passed on to
1879         search_symbols.
1880         (struct info_print_options): New type.
1881         (info_print_options_defs): New file scoped variable.
1882         (make_info_print_options_def_group): New static function.
1883         (info_print_command_completer): New static function.
1884         (info_variables_command): Update to use local functions, and pass
1885         extra parameter through to symtab_symbol_info.
1886         (info_functions_command): Likewise.
1887         (info_types_command): Pass additional argument through to
1888         symtab_symbol_info.
1889         (rbreak_command): Pass extra argument to search_symbols.
1890         (_initialize_symtab): Add extra arguments for calls to
1891         info_print_args_help, and update help text for 'info variables',
1892         'whereis', and 'info functions' commands.
1893         * symtab.h (search_symbols): Add extra argument to declaration.
1894         * NEWS: Mention new flags.
1895
1896 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1897
1898         * symtab.c (lookup_static_symbol): Call the new function (and move
1899         it down to be next to lookup_global_symbol).
1900         (struct global_sym_lookup_data): Add block_enum member and rename to...
1901         (struct global_or_static_sym_lookup_data): ...this.
1902         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1903         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1904         (lookup_symbol_global_or_static_iterator_cb): ...this.
1905         (lookup_global_or_static_symbol): New function.
1906         (lookup_global_symbol): Call new function.
1907
1908 2019-08-26  Tom de Vries  <tdevries@suse.de>
1909
1910         PR c++/24852
1911         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1912         when pc_probe.prob == NULL.
1913
1914 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1915
1916         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1917         variable symbol_linkage to symbol_linkage_.
1918
1919 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1920
1921         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1922         represent whether the symbol is static, dynamic, or we don't
1923         know.
1924
1925 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1926
1927         * gdb/rx-tdep.c (rx_register_names): New.
1928         (rx_register_name): Delete.
1929         (rx_psw_type): Delete.
1930         (rx_fpsw_type): Delete.
1931         (rx_register_type): Delete.
1932         (rx_gdbarch_init): Convert target-descriptions.
1933         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1934         * gdb/features/Makefile: Add rx.xml.
1935         * gdb/features/rx.xml: New.
1936         * gdb/features/rx.c: Generated.
1937         * gdb/NEWS: Mention target description support.
1938
1939 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1940
1941         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1942         *slot_ptr.
1943
1944 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1945
1946         * configure.ac: Don't check for 'dlfcn.h' (moved to
1947         gdbsupport/common.m4).
1948         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1949         'gdbsupport/'.
1950         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1951         * compile/compile-c-support.c: Include
1952         'gdbsupport/gdb-dlfcn.h'.
1953         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1954         * gdb-dlfcn.c: Move to...
1955         * gdbsupport/gdb-dlfcn.c: ... here.
1956         * gdb-dlfcn.h: Move to...
1957         * gdbsupport/gdb-dlfcn.h: ... here.
1958
1959 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1960
1961         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1962         the offset field signed.
1963
1964 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1965
1966         * python/lib/gdb/__init__.py (_execute_file): New function.
1967         * python/python.c (python_run_simple_file): Call gdb._execute_file
1968         on Windows.
1969
1970 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1971
1972         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1973         all uses as this was never set to anything but a zero value.
1974
1975 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1976
1977         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1978
1979 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1980
1981         * tui/tui-data.h (tui_gen_win_info): Add an =default
1982         move constructor, required by some GCC versions.
1983
1984 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1985
1986         * go32-nat.c (go32_sysinfo): Add hygon_p.
1987
1988 2019-08-20  Tom Tromey  <tom@tromey.com>
1989
1990         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1991         line_from_reg_element_no, first_reg_element_no_inline,
1992         display_all_data, delete_data_content_windows,
1993         erase_data_content>: Now private.
1994
1995 2019-08-20  Tom Tromey  <tom@tromey.com>
1996
1997         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1998         (tui_unhighlight_win, tui_highlight_win)
1999         (tui_win_info::make_window): Update.
2000         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2001
2002 2019-08-20  Tom Tromey  <tom@tromey.com>
2003
2004         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2005         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2006         (MAX_PID_WIDTH): Move to tui-stack.c.
2007         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2008         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2009         (MAX_PID_WIDTH): Move from tui-data.h.
2010
2011 2019-08-20  Tom Tromey  <tom@tromey.com>
2012
2013         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2014         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2015         (box_win): Update.
2016         (tui_gen_win_info::make_window): Rename from tui_make_window.
2017         (tui_win_info::make_window): New method.
2018         (tui_gen_win_info::make_visible): Update.
2019         * tui/tui-source.c (tui_source_window::set_contents): Update.
2020         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2021         (tui_data_window::display_registers_from): Update.
2022         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2023         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2024         Declare.
2025         <can_box>: Remove.
2026         <title>: Remove.
2027         (struct tui_win_info) <make_window>: Declare.
2028         <can_box>: Now virtual.
2029         <title>: New member.
2030         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2031         * tui/tui-command.c (tui_cmd_window::resize): Update.
2032
2033 2019-08-20  Tom Tromey  <tom@tromey.com>
2034
2035         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2036         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2037         (tui_data_window::check_register_values): Update.
2038
2039 2019-08-20  Tom Tromey  <tom@tromey.com>
2040
2041         * tui/tui-regs.h (struct tui_data_window): Use
2042         DISABLE_COPY_AND_ASSIGN.
2043         <regs_content>: Change type, removing unique_ptr.
2044         <tui_data_window>: Add move constructor.
2045         * tui/tui-regs.c (tui_data_window::show_registers)
2046         (tui_data_window::show_register_group)
2047         (tui_data_window::display_registers_from)
2048         (tui_data_window::display_registers_from)
2049         (tui_data_window::first_data_item_displayed)
2050         (tui_data_window::delete_data_content_windows)
2051         (tui_data_window::rerender, tui_data_window::refresh_window)
2052         (tui_data_window::check_register_values): Update.
2053
2054 2019-08-20  Tom Tromey  <tom@tromey.com>
2055
2056         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2057         show_register_group>: Declare.
2058         (tui_show_register_group): Don't declare.
2059         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2060         tui_show_registers.
2061         (tui_data_window::show_register_group): Rename from
2062         tui_show_register_group.
2063         (tui_data_window::check_register_values, tui_reg_command):
2064         Update.
2065         * tui/tui-layout.c (tui_set_layout): Update.
2066
2067 2019-08-20  Tom Tromey  <tom@tromey.com>
2068
2069         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2070         Declare.
2071         (tui_check_register_values): Don't declare.
2072         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2073         from tui_check_register_values.
2074         * tui/tui-hooks.c (tui_register_changed): Update.
2075
2076 2019-08-20  Tom Tromey  <tom@tromey.com>
2077
2078         * tui/tui-regs.c (tui_reg_layout): Move later.
2079         (tui_show_registers): Don't enable TUI mode or change layout.
2080
2081 2019-08-20  Tom Tromey  <tom@tromey.com>
2082
2083         * tui/tui-regs.h (struct tui_data_item_window)
2084         <~tui_data_item_window>: Remove.
2085         <content>: Now a unique_xmalloc_ptr.
2086         * tui/tui-regs.c (tui_register_format): Return a
2087         unique_xmalloc_ptr.
2088         (tui_get_register): Update.
2089         (~tui_data_item_window): Remove.
2090         (tui_data_window::display_registers_from, tui_display_register):
2091         Update.
2092         * tui/tui-io.h (tui_expand_tabs): Update.
2093         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2094         Remove "col" parameter.
2095
2096 2019-08-20  Tom Tromey  <tom@tromey.com>
2097
2098         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2099         field.
2100         * tui/tui-regs.c (~tui_data_item_window): Update.
2101
2102 2019-08-20  Tom Tromey  <tom@tromey.com>
2103
2104         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2105         earlier.
2106
2107 2019-08-20  Tom Tromey  <tom@tromey.com>
2108
2109         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2110
2111 2019-08-20  Tom Tromey  <tom@tromey.com>
2112
2113         * tui/tui-source.h (struct tui_source_window): Update.
2114         * tui/tui-regs.c (tui_show_registers): Update.
2115         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2116         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2117         (NO_REGS_STRING): Remove defines.
2118
2119 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2120
2121         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2122         unnecessary thread walk if remote doesn't support the packet.
2123
2124 2019-08-19  Tom Tromey  <tromey@adacore.com>
2125
2126         * python/py-value.c (value_has_field): Fix indentation.
2127
2128 2019-08-19  Tom Tromey  <tromey@adacore.com>
2129
2130         * printcmd.c (do_one_display, info_display_command): Update.
2131         * block.h (contained_in): Return bool.  Add allow_nested
2132         parameter.
2133         * block.c (contained_in): Return bool.  Add allow_nested
2134         parameter.
2135
2136 2019-08-19  Tom Tromey  <tom@tromey.com>
2137
2138         * configure: Rebuild.
2139         * configure.ac: Disallow the combination of -static-libstdc++ and
2140         source highlight.
2141         * source-cache.c (get_language_name): Handle rust.
2142         (source_cache::get_source_lines): Ignore highlighting exceptions.
2143
2144 2019-08-16  Tom Tromey  <tom@tromey.com>
2145
2146         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2147         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2148         (struct tui_source_window_base) <make_visible, refresh_window,
2149         resize>: Remove methods.
2150         <execution_info>: Remove field.
2151         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2152         (tui_show_source_line, tui_source_window_base)
2153         (~tui_source_window_base): Update.
2154         (tui_source_window_base::resize)
2155         (tui_source_window_base::make_visible)
2156         (tui_source_window_base::refresh_window): Remove.
2157         (tui_source_window_base::update_exec_info): Update.
2158         * tui/tui-source.c (tui_source_window::set_contents): Update.
2159         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2160
2161 2019-08-16  Tom Tromey  <tom@tromey.com>
2162
2163         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2164         deprecated_query_hook.
2165
2166 2019-08-16  Tom Tromey  <tom@tromey.com>
2167
2168         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2169         (tui_update_source_windows_with_line): Update.
2170         * tui/tui-source.h (struct tui_source_window)
2171         <show_symtab_source>: Declare.
2172         (tui_show_symtab_source): Don't declare.
2173         * tui/tui-source.c (tui_show_symtab_source): Rename from
2174         tui_show_symtab_source.
2175
2176 2019-08-16  Tom Tromey  <tom@tromey.com>
2177
2178         * tui/tui-winsource.h (struct tui_source_window_base)
2179         <set_contents>: Declare.
2180         * tui/tui-winsource.c
2181         (tui_source_window_base::update_source_window_as_is): Update.
2182         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2183         Declare.
2184         (tui_set_source_content): Don't declare.
2185         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2186         tui_set_source_content.
2187         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2188         Declare.
2189         (tui_set_disassem_content): Don't declare.
2190         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2191         tui_set_disassem_content.
2192
2193 2019-08-16  Tom Tromey  <tom@tromey.com>
2194
2195         * tui/tui-winsource.h (struct tui_source_window_base)
2196         <update_breakpoint_info>: Declare.
2197         (tui_update_breakpoint_info): Don't declare.
2198         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2199         (tui_update_all_breakpoint_info): Update.
2200         (tui_source_window_base::update_breakpoint_info): Rename from
2201         tui_update_breakpoint_info.
2202         (tui_source_window_base::update_exec_info): Update.
2203
2204 2019-08-16  Tom Tromey  <tom@tromey.com>
2205
2206         * tui/tui-winsource.h (struct tui_source_window_base)
2207         <update_source_window>: Declare.
2208         (tui_update_source_window): Don't declare.
2209         * tui/tui-winsource.c
2210         (tui_source_window_base::update_source_window): Rename from
2211         tui_update_source_window.
2212         (tui_source_window_base::rerender): Update.
2213         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2214         * tui/tui-disasm.c (tui_show_disassem)
2215         (tui_show_disassem_and_update_source)
2216         (tui_disasm_window::maybe_update): Update.
2217
2218 2019-08-16  Tom Tromey  <tom@tromey.com>
2219
2220         * tui/tui-winsource.h (struct tui_source_window_base)
2221         <update_source_window_as_is>: Declare.
2222         (tui_update_source_window_as_is): Don't declare.
2223         * tui/tui-winsource.c (tui_update_source_window): Update
2224         (tui_source_window_base::update_source_window_as_is): Rename from
2225         tui_update_source_window_as_is.
2226         (tui_source_window_base::refill): Update.
2227         * tui/tui-source.c (tui_show_symtab_source): Update.
2228         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2229         Update.
2230
2231 2019-08-16  Tom Tromey  <tom@tromey.com>
2232
2233         * tui/tui-winsource.h (tui_update_source_window)
2234         (tui_update_source_window_as_is): Remove "noerror" parameter.
2235         * tui/tui-winsource.c (tui_update_source_window)
2236         (tui_update_source_window_as_is): Remove "noerror" parameter.
2237         (tui_update_source_windows_with_addr)
2238         (tui_update_source_windows_with_line)
2239         (tui_source_window_base::rerender)
2240         (tui_source_window_base::refill): Update.
2241         * tui/tui-source.h (tui_set_source_content)
2242         (tui_show_symtab_source): Remove "noerror" parameter.
2243         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2244         parameter.
2245         (tui_show_symtab_source): Likewise.
2246         (tui_source_window::maybe_update): Update.
2247         * tui/tui-disasm.c (tui_show_disassem)
2248         (tui_show_disassem_and_update_source)
2249         (tui_disasm_window::do_scroll_vertical)
2250         (tui_disasm_window::maybe_update): Update.
2251
2252 2019-08-16  Tom Tromey  <tom@tromey.com>
2253
2254         * tui/tui.c (tui_is_window_visible): Update.
2255         * tui/tui-wingeneral.c (tui_make_window)
2256         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2257         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2258         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2259         (tui_set_win_height_command, parse_scrolling_args): Update.
2260         * tui/tui-source.c (tui_source_window::style_changed): Update.
2261         * tui/tui-regs.c (tui_show_registers)
2262         (tui_data_window::first_data_item_displayed)
2263         (tui_data_window::delete_data_content_windows)
2264         (tui_check_register_values, tui_reg_command): Update.
2265         * tui/tui-disasm.c (tui_show_disassem): Update.
2266         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2267         method.
2268         <is_visible>: Remove field.
2269         * tui/tui-data.c (tui_next_win, tui_prev_win)
2270         (tui_delete_invisible_windows): Update.
2271
2272 2019-08-16  Tom Tromey  <tom@tromey.com>
2273
2274         * tui/tui-winsource.h (struct tui_source_window_base)
2275         <m_has_locator>: Remove.
2276         * tui/tui-layout.c (show_source_disasm_command, show_data)
2277         (show_source_or_disasm_and_command): Update.
2278
2279 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2280
2281         * NEWS (Other MI changes): New subsection.
2282         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2283         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2284         * arch-utils.c (default_get_pc_address_flags): New function.
2285         * arch-utils.h (default_get_pc_address_flags): New declaration.
2286         * gdbarch.sh: Add get_pc_address_flags.
2287         * gdbarch.c: Regenerate.
2288         * gdbarch.h: Likewise.
2289         * stack.c (print_pc): New function.
2290         (print_frame_info) (print_frame): Call print_pc.
2291
2292 2019-08-16  Tom de Vries  <tdevries@suse.de>
2293
2294         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2295         print_objfile_section_info.
2296
2297 2019-08-15  Tom Tromey  <tom@tromey.com>
2298
2299         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2300         calling update_cmdwin_start_line.
2301         * tui/tui-winsource.h (struct tui_source_window_base)
2302         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2303         <rerender>: Declare.
2304         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2305         Call rerender.
2306         (tui_source_window_base::set_new_height): Remove.
2307         (tui_source_window_base::rerender): Rename from
2308         do_make_visible_with_new_height.
2309         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2310         resize method.
2311         (tui_win_info::make_invisible_and_set_new_height)
2312         (tui_win_info::make_visible_with_new_height): Remove.
2313         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2314         Declare.
2315         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2316         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2317         do_make_visible_with_new_height>: Don't declare.
2318         <rerender>: Declare.
2319         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2320         set_new_height.
2321         (tui_data_window::do_make_visible_with_new_height): Remove.
2322         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2323         call tui_show_locator_content.
2324         (tui_gen_win_info::resize): Call rerender.
2325         (show_source_or_disasm_and_command): Don't call
2326         tui_show_locator_content.
2327         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2328         method.
2329         (struct tui_win_info) <rerender>: Declare.
2330         <set_new_height, make_invisible_and_set_new_height,
2331         make_visible_with_new_height>: Don't declare.
2332         * tui/tui-data.c (tui_win_list::rerender): New method.
2333         * tui/tui-command.h (struct tui_cmd_window)
2334         <do_make_visible_with_new_height>: Don't declare.
2335         * tui/tui-command.c
2336         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2337
2338 2019-08-15  Tom Tromey  <tromey@adacore.com>
2339
2340         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2341         * ada-lang.c (ada_enum_name): Likewise.
2342
2343 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2344
2345         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2346         leading underscore.
2347         (GdbOutputErrorFile): Likewise.
2348         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2349         accordingly.
2350         (execute_unwinders): Rename to have a leading underscore.
2351         (auto_load_packages): Likewise.
2352         (global scope): Adjust call to auto_load_packages accordingly.
2353         (GdbSetPythonDirectory): Likewise.
2354         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2355         instead of execute_unwinders.
2356
2357 2019-08-15  Tom Tromey  <tom@tromey.com>
2358
2359         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2360         (show_data): Don't change window visibility.
2361         (tui_gen_win_info::resize): Remove special case for command
2362         window.  Use wresize, when available.
2363         (show_source_or_disasm_and_command): Don't change window
2364         visibility.
2365         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2366         <make_visible>: New method.
2367         * tui/tui-command.c (tui_cmd_window::resize): New method.
2368
2369 2019-08-15  Tom Tromey  <tom@tromey.com>
2370
2371         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2372         (struct tui_source_windows): New.
2373         * tui/tui-winsource.c (tui_display_main): Update.
2374         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2375         (new_height_ok, parse_scrolling_args): Update.
2376         * tui/tui-layout.c (show_layout, show_data): Update.
2377         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2378         (tui_add_to_source_windows): Don't declare.
2379         * tui/tui-data.c (source_windows, tui_source_windows)
2380         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2381
2382 2019-08-15  Tom Tromey  <tom@tromey.com>
2383
2384         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2385         Rename from reset.
2386         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2387         * tui/tui-layout.c (show_source_disasm_command, show_data):
2388         Update.
2389         (tui_gen_win_info::resize): Rename.
2390         (show_source_or_disasm_and_command): Update.
2391         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2392         reset.
2393
2394 2019-08-15  Tom Tromey  <tom@tromey.com>
2395
2396         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2397         * tui/tui-interp.c (tui_interp::init): Don't call
2398         tui_initialize_static_data.
2399         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2400
2401 2019-08-15  Tom Tromey  <tom@tromey.com>
2402
2403         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2404         examine tui_win_list.
2405
2406 2019-08-15  Tom Tromey  <tom@tromey.com>
2407
2408         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2409         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2410         tui_clear_source_content.
2411         (tui_clear_source_content): Remove.
2412         (tui_source_window_base::do_erase_source_content): Hoist call to
2413         content.clear().
2414         * tui/tui-stack.c (tui_show_frame_info): Don't call
2415         tui_clear_source_content.
2416
2417 2019-08-15  Tom Tromey  <tom@tromey.com>
2418
2419         * tui/tui-winsource.h (struct tui_source_window_base)
2420         <do_erase_source_content>: New method.
2421         <erase_source_content>: New method.
2422         (tui_erase_source_content): Don't declare.
2423         * tui/tui-winsource.c (tui_clear_source_content): Update.
2424         (tui_source_window_base::do_erase_source_content): Rename from
2425         tui_erase_source_content.
2426         (tui_source_window_base::show_source_content): Update.
2427         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2428         * tui/tui-source.h (struct tui_source_window)
2429         <erase_source_content>: New method.
2430         * tui/tui-disasm.h (struct tui_disasm_window)
2431         <erase_source_content>: New method.
2432
2433 2019-08-15  Tom Tromey  <tom@tromey.com>
2434
2435         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2436         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2437         constructor.
2438         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2439         * tui/tui-source.c (tui_set_source_content): Update.
2440         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2441
2442 2019-08-15  Tom Tromey  <tom@tromey.com>
2443
2444         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2445         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2446         tui-source.c.
2447         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2448         Declare.
2449         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2450         method.
2451         (tui_source_window::maybe_update): Update.
2452
2453 2019-08-15  Tom Tromey  <tom@tromey.com>
2454
2455         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2456         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2457         tui-disasm.c.
2458         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2459         Declare.
2460         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2461         method.
2462         (tui_disasm_window::maybe_update): Update.
2463
2464 2019-08-15  Tom Tromey  <tom@tromey.com>
2465
2466         * tui/tui-winsource.h (struct tui_source_window_base)
2467         <maybe_update>: Declare.
2468         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2469         method.
2470         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2471         Declare.
2472         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2473         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2474         Declare.
2475         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2476
2477 2019-08-15  Tom Tromey  <tom@tromey.com>
2478
2479         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2480
2481 2019-08-15  Tom Tromey  <tom@tromey.com>
2482
2483         * tui/tui-wingeneral.c: Include tui-stack.h.
2484         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2485         (struct tui_locator_window): Move from tui-data.h.
2486         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2487         (tui_initialize_static_data): Move from tui-data.c.
2488         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2489         (struct tui_locator_window): Move to tui-stack.c.
2490         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2491         (tui_initialize_static_data): Move to tui-stack.c.
2492
2493 2019-08-15  Tom Tromey  <tom@tromey.com>
2494
2495         * tui/tui-layout.c (show_source_disasm_command)
2496         (show_source_or_disasm_and_command): Use make_visible method, not
2497         tui_make_window.
2498         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2499         Remove.
2500
2501 2019-08-15  Tom Tromey  <tom@tromey.com>
2502
2503         * tui/tui-wingeneral.h (tui_make_window): Update.
2504         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2505         parameter.
2506         (tui_gen_win_info::make_visible): Update.
2507         * tui/tui-regs.c (tui_data_window::display_registers_from):
2508         Update.
2509         * tui/tui-layout.c (show_source_disasm_command)
2510         (show_source_or_disasm_and_command): Update.
2511         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2512         (enum tui_box): Remove.
2513         (struct tui_win_info) <can_box>: New method.
2514         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2515         method.
2516
2517 2019-08-15  Tom de Vries  <tdevries@suse.de>
2518
2519         * linux-nat-trad.c: Include gdbarch.h.
2520
2521 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2522
2523         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2524         register sizes.
2525
2526 2019-08-14  Tom Tromey  <tromey@adacore.com>
2527
2528         * darwin-nat.c: Include gdbarch.h.
2529         * darwin-nat-info.c: Include gdbarch.h.
2530
2531 2019-08-13  Tom Tromey  <tom@tromey.com>
2532
2533         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2534         Remove.
2535         * tui/tui-data.c (tui_initialize_static_data): Update.
2536
2537 2019-08-13  Tom Tromey  <tom@tromey.com>
2538
2539         * tui/tui-winsource.h (struct tui_exec_info_window)
2540         <~tui_exec_info_window, maybe_allocate_content, get_content,
2541         m_content>: Remove.
2542         (struct tui_source_window_base) <set_exec_info_content,
2543         show_exec_info_content>: Don't declare.
2544         * tui/tui-winsource.c
2545         (tui_exec_info_window::maybe_allocate_content): Remove.
2546         (tui_source_window_base::update_exec_info): Rename from
2547         set_exec_info_content.
2548         (tui_source_window_base::show_exec_info_content)
2549         (tui_source_window_base::update_exec_info): Remove.
2550
2551 2019-08-13  Tom Tromey  <tom@tromey.com>
2552
2553         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2554         declare.
2555         * tui/tui-winsource.c (tui_update_source_window_as_is)
2556         (tui_update_source_windows_with_addr, tui_erase_source_content):
2557         Update.
2558         (tui_clear_exec_info_content): Remove.
2559
2560 2019-08-13  Tom Tromey  <tom@tromey.com>
2561
2562         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2563         declare.
2564         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2565         call tui_erase_exec_info_content.
2566         (tui_clear_exec_info_content): Rename from
2567         tui_erase_exec_info_content.
2568         (tui_clear_exec_info_content): Delete.
2569
2570 2019-08-13  Tom Tromey  <tom@tromey.com>
2571
2572         * tui/tui-winsource.h (struct tui_source_window_base)
2573         <show_exec_info_content>: Declare.
2574         (tui_show_exec_info_content): Don't declare.
2575         * tui/tui-winsource.c
2576         (tui_source_window_base::show_exec_info_content): Rename from
2577         tui_show_exec_info_content.
2578         (tui_source_window_base::update_exec_info): Update.
2579
2580 2019-08-13  Tom Tromey  <tom@tromey.com>
2581
2582         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2583         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2584         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2585         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2586         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2587         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2588         ... here.
2589
2590 2019-08-13  Tom Tromey  <tom@tromey.com>
2591
2592         * tui/tui-winsource.h (struct tui_source_window_base)
2593         <update_exec_info>: Declare.
2594         (tui_update_exec_info): Don't declare.
2595         * tui/tui-winsource.c (tui_update_source_window_as_is)
2596         (tui_source_window_base::refresh_all)
2597         (tui_update_all_breakpoint_info): Update.
2598         (tui_source_window_base::update_exec_info): Rename from
2599         tui_update_exec_info.
2600         * tui/tui-stack.c (tui_show_frame_info): Update.
2601
2602 2019-08-13  Tom Tromey  <tom@tromey.com>
2603
2604         * tui/tui-winsource.h (struct tui_source_window_base)
2605         <set_exec_info_content>: Declare.
2606         (tui_set_exec_info_content): Don't declare.
2607         * tui/tui-winsource.c
2608         (tui_source_window_base::set_exec_info_content): Rename from
2609         tui_set_exec_info_content.
2610         (tui_update_exec_info): Update.
2611
2612 2019-08-13  Tom Tromey  <tom@tromey.com>
2613
2614         * tui/tui-winsource.h (struct tui_source_window_base)
2615         <show_source_content>: Declare.
2616         (tui_show_source_content): Don't declare.
2617         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2618         (tui_source_window_base::show_source_content): Rename from
2619         tui_show_source_content.
2620         (tui_source_window_base::refresh_all): Update.
2621         * tui/tui-layout.c (show_source_disasm_command)
2622         (show_source_or_disasm_and_command): Update.
2623
2624 2019-08-13  Tom Tromey  <tom@tromey.com>
2625
2626         * tui/tui-winsource.c (tui_erase_source_content)
2627         (tui_show_source_content, tui_source_window_base::refresh_all):
2628         Update.
2629         * tui/tui-wingeneral.h
2630         (tui_check_and_display_highlight_if_needed): Don't declare.
2631         * tui/tui-wingeneral.c
2632         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2633         check_and_display_highlight_if_needed.
2634         * tui/tui-win.c (tui_rehighlight_all)
2635         (tui_win_info::make_visible_with_new_height): Update.
2636         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2637         (tui_data_window::erase_data_content)
2638         (tui_data_window::display_all_data): Update.
2639         * tui/tui-data.h (struct tui_win_info)
2640         <check_and_display_highlight_if_needed>: Declare.
2641
2642 2019-08-13  Tom Tromey  <tom@tromey.com>
2643
2644         * tui/tui-win.c (tui_resize_all): Call
2645         tui_delete_invisible_windows.
2646         * tui/tui-layout.c (show_layout): Call
2647         tui_delete_invisible_windows.
2648         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2649         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2650
2651 2019-08-13  Tom Tromey  <tom@tromey.com>
2652
2653         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2654         tui_add_win_to_layout.
2655
2656 2019-08-13  Tom Tromey  <tom@tromey.com>
2657
2658         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2659         * tui/tui-layout.c (tui_default_win_height): Now static.
2660
2661 2019-08-13  Tom Tromey  <tom@tromey.com>
2662
2663         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2664         single switch.
2665         (show_source_disasm_command, show_source_or_disasm_and_command):
2666         Don't check current layout.
2667
2668 2019-08-13  Tom Tromey  <tom@tromey.com>
2669
2670         * tui/tui-wingeneral.c (make_all_visible): Remove.
2671         (tui_make_all_invisible): Simplify.
2672         * tui/tui-layout.c (tui_make_all_invisible): Move from
2673         tui-wingeneral.c; simplify.
2674         (show_layout): Hoist call to tui_make_all_invisible.
2675         (show_data): Don't call tui_make_all_invisible.
2676
2677 2019-08-13  Tom Tromey  <tom@tromey.com>
2678
2679         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2680         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2681
2682 2019-08-13  Tom Tromey  <tom@tromey.com>
2683
2684         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2685         tui-data.c.
2686         (show_source_disasm_command, show_data)
2687         (show_source_or_disasm_and_command): Don't use
2688         tui_set_current_layout_to.
2689         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2690         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2691         tui-layout.c.
2692         (tui_set_current_layout_to): Remove.
2693
2694 2019-08-13  Tom Tromey  <tom@tromey.com>
2695
2696         * tui/tui-layout.c (tui_set_layout): Update.
2697         * tui/tui-data.h (struct tui_layout_def): Remove.
2698         (tui_layout_def): Don't declare.
2699         * tui/tui-data.c (layout_def): Remove.
2700         (tui_layout_def): Remove.
2701
2702 2019-08-13  Tom Tromey  <tom@tromey.com>
2703
2704         * tui/tui-winsource.h (struct tui_source_window_base)
2705         <clear_detail>: No longer "override".
2706         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2707         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2708         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2709         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2710         Remove.
2711         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2712
2713 2019-08-13  Tom Tromey  <tromey@adacore.com>
2714
2715         * tracepoint.c: Don't include readline.h or history.h.
2716
2717 2019-08-12  Tom Tromey  <tom@tromey.com>
2718
2719         * configure: Rebuild.
2720         * configure.ac: Check for readline 7.
2721         * NEWS: Mention readline 7 requirement.
2722         * README: Update.
2723
2724 2019-08-12  Tom Tromey  <tom@tromey.com>
2725
2726         * mingw-hdep.c (gdb_select): Remove readline hack.
2727
2728 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2729
2730         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2731         when the function fails.
2732
2733 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2734
2735         * s390-tdep.c (s390_type_align): New function.
2736         (s390_gdbarch_init): Set it as type_align gdbarch method.
2737
2738 2019-08-09  Tom de Vries  <tdevries@suse.de>
2739
2740         PR gdb/24591
2741         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2742         pc_low with relocation offset.
2743
2744 2019-08-07  Tom Tromey  <tromey@adacore.com>
2745
2746         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2747         (print_frame_args): Update.
2748         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2749         Update.
2750         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2751         * frame.h (struct frame_arg): Add initializers.
2752         <error>: Now a unique_xmalloc_ptr.
2753
2754 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2755
2756         * NEWS: Expand the Pointer Authentication entry.
2757         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2758         (aarch64_frame_unmask_lr): ... to this.
2759         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2760         Call aarch64_frame_unmask_lr.
2761         * frame.c (struct frame_info): Add "masked" variable.
2762         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2763         (fprint_frame): Check for masked pc.
2764         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2765         declarations.
2766         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2767         * stack.c (print_frame): Check for masked pc.
2768
2769 2019-08-06  Tom Tromey  <tom@tromey.com>
2770
2771         * stabsread.c (patch_block_stabs, read_one_struct_field)
2772         (read_enum_type): Use obstack_strndup.
2773         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2774         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2775         * dwarf2read.c (guess_full_die_structure_name)
2776         (anonymous_struct_prefix): Use obstack_strndup.
2777         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2778         * c-exp.y (yylex): Use obstack_strndup.
2779         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2780         (write_var_or_type): Use obstack_strndup.
2781
2782 2019-08-06  Tom Tromey  <tom@tromey.com>
2783
2784         * symfile.c (reread_symbols): Use obstack_strdup.
2785         * stabsread.c (read_type): Use obstack_strdup.
2786         * gdb_obstack.h (obstack_strdup): New overload.
2787         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2788         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2789         (dwarf2_canonicalize_name): Use obstack_strdup.
2790         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2791         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2792         Use obstack_strdup.
2793
2794 2019-08-06  Tom Tromey  <tom@tromey.com>
2795
2796         * gdb_obstack.h (obstack_strdup): Define.
2797         * gdb_obstack.c (obstack_strdup): Don't define.
2798
2799 2019-08-06  Tom Tromey  <tom@tromey.com>
2800
2801         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2802         obstack_strdup.
2803         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2804         obstack_strdup.
2805         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2806         * stabsread.c (common_block_start): Use obstack_strdup.
2807         * objfiles.c (set_objfile_main_name, objfile): Use
2808         obstack_strdup.
2809         * namespace.c (add_using_directive): Use obstack_strdup.
2810         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2811         * jit.c (finalize_symtab): Use obstack_strdup.
2812         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2813         (guess_partial_die_structure_name, partial_die_info::fixup)
2814         (dwarf2_name): Use obstack_strdup.
2815         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2816         obstack_strdup.
2817         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2818         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2819         obstack_strdup.
2820         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2821
2822 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2823
2824         * unittests/help-doc-selftests.c: New file.
2825         * Makefile.in: Add the new file.
2826
2827 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2828
2829         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2830         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2831         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2832         the trailing '.' is not output, and the first character is uppercased.
2833         (print_help_for_command): Update call to print_doc_line.
2834         (print_doc_of_command): Likewise.
2835         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2836         * cli/cli-option.c (append_indented_doc): Do not append newline.
2837         (build_help_option): Append newline after first appended_indented_doc
2838         only if a second call is done.
2839         (build_help): Append 2 new lines before each option, except the first
2840         one.
2841         * compile/compile.c (_initialize_compile): Add new lines after
2842         %OPTIONS%, when not at the end of the help.
2843         Change help doc or code
2844         producing the help doc to respect the invariants.
2845         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2846         Also removed the new line after 'Options:', as all other commands
2847         do not put an empty line between 'Options:' and the first option.
2848         * printcmd.c (_initialize_printcmd): Likewise.
2849         * stack.c (_initialize_stack): Likewise.
2850         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2851         incorrectly telling COMMAND is optional.
2852         * ada-lang.c (_initialize_ada_language): Change help doc or code
2853         producing the help doc to respect the invariants.
2854         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2855         * breakpoint.c (_initialize_breakpoint): Likewise.
2856         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2857         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2858         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2859         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2860         _initialize_cli_style): Likewise.
2861         * corelow.c (core_target_info): Likewise.
2862         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2863         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2864         * filesystem.c (_initialize_filesystem): Likewise.
2865         * frame.c (_initialize_frame): Likewise.
2866         * gnu-nat.c (add_task_commands): Likewise.
2867         * infcall.c (_initialize_infcall): Likewise.
2868         * infcmd.c (_initialize_infcmd): Likewise.
2869         * interps.c (_initialize_interpreter): Likewise.
2870         * language.c (_initialize_language): Likewise.
2871         * linux-fork.c (_initialize_linux_fork): Likewise.
2872         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2873         * maint.c (_initialize_maint_cmds): Likewise.
2874         * memattr.c (_initialize_mem): Likewise.
2875         * printcmd.c (_initialize_printcmd): Likewise.
2876         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2877         _RegEx): Likewise.
2878         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2879         * record-btrace.c (_initialize_record_btrace): Likewise.
2880         * record-full.c (_initialize_record_full): Likewise.
2881         * record.c (_initialize_record): Likewise.
2882         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2883         * regcache.c (_initialize_regcache): Likewise.
2884         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2885         _initialize_remote): Likewise.
2886         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2887         * serial.c (_initialize_serial): Likewise.
2888         * skip.c (_initialize_step_skip): Likewise.
2889         * source.c (_initialize_source): Likewise.
2890         * stack.c (_initialize_stack): Likewise.
2891         * symfile.c (_initialize_symfile): Likewise.
2892         * symtab.c (_initialize_symtab): Likewise.
2893         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2894         * top.c (init_main): Likewise.
2895         * tracefile-tfile.c (tfile_target_info): Likewise.
2896         * tracepoint.c (_initialize_tracepoint): Likewise.
2897         * tui/tui-win.c (_initialize_tui_win): Likewise.
2898         * utils.c (add_internal_problem_command): Likewise.
2899         * valprint.c (value_print_option_defs): Likewise.
2900
2901 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2902
2903         PR build/24886
2904         * configure.ac: Drop enable-libmcheck support.
2905         * configure, config.in: Rebuild.
2906         * libmcheck.m4: Remove.
2907         * acinclude.m4: Don't include it.
2908         * Makefile.in: Don't distribute it.
2909         * top.c (print_gdb_configuration): Don't mention it.
2910
2911 2019-08-06  Tom Tromey  <tom@tromey.com>
2912
2913         * utils.c (set_output_style): Sometimes pass stream to
2914         emit_style_escape.
2915         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2916         * record-btrace.c (btrace_insn_history): Update.
2917         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2918         method.
2919         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2920         Update initializers.
2921         <m_uiout>: New field.
2922         <m_di>: Move lower.
2923         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2924         Remove "uiout" parameter.
2925         (dump_insns): Update.
2926         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2927         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2928
2929 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2930
2931         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2932         (error_in_psymtab_expansion): Likewise.
2933         (lookup_symbol_via_quick_fns): Likewise.
2934         (basic_lookup_transparent_type_quick): Likewise.
2935         (basic_lookup_transparent_type_1): Likewise.
2936
2937 2019-08-06  Tom Tromey  <tromey@adacore.com>
2938
2939         * source.c (last_source_error): Now bool.
2940         (print_source_lines_base): Make "noprint" bool.  Only open
2941         source file when last_source_visited changes.
2942
2943 2019-08-06  Tom Tromey  <tromey@adacore.com>
2944
2945         * annotate.c (annotate_source_line): Use g_source_cache.
2946         * source-cache.c (source_cache::get_plain_source_lines): Change
2947         parameters.  Populate m_offset_cache.
2948         (source_cache::ensure): New method.
2949         (source_cache::get_line_charpos): New method.
2950         (extract_lines): Move lower.  Change parameters.
2951         (source_cache::get_source_lines): Move lower.
2952         * source-cache.h (class source_cache): Update comment.
2953         <get_line_charpos>: New method.
2954         <get_source_lines>: Update comment.
2955         <clear>: Clear m_offset_cache.
2956         <get_plain_source_lines>: Change parameters.
2957         <ensure>: New method
2958         <m_offset_cache>: New member.
2959         * source.c (forget_cached_source_info_for_objfile): Update.
2960         (info_source_command): Use g_source_cache.
2961         (find_source_lines, open_source_file_with_line_charpos): Remove.
2962         (print_source_lines_base, search_command_helper): Use g_source_cache.
2963         * source.h (open_source_file_with_line_charpos): Don't declare.
2964         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2965         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2966         Use g_source_cache.
2967
2968 2019-08-06  Tom Tromey  <tromey@adacore.com>
2969
2970         * source-cache.c (source_cache::get_plain_source_lines):
2971         Remove "first_line" and "last_line" parameters.
2972         (source_cache::get_source_lines): Cache plain text.
2973         * source-cache.h (class source_cache)
2974         <get_plain_source_lines>: Update.
2975
2976 2019-08-06  Tom Tromey  <tromey@adacore.com>
2977
2978         * source-cache.c (extract_lines): No longer a method.
2979         Changed type of parameter.  Include final newline.
2980         (selftests::extract_lines_test): New function.
2981         (_initialize_source_cache): Likewise.
2982         * source-cache.h (class source_cache)
2983         <extract_lines>: Don't declare.
2984
2985 2019-08-06  Tom Tromey  <tromey@adacore.com>
2986
2987         * breakpoint.c (init_breakpoint_sal): Update.
2988         (breakpoint): Update.
2989         * breakpoint.h (struct breakpoint) <filter>: Now a
2990         unique_xmalloc_ptr.
2991
2992 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2993
2994         * NEWS: Mention dictionary access on blocks.
2995         * python/py-block.c (blpy_getitem): New function.
2996         (block_object_as_mapping): New struct.
2997         (block_object_type): Use new struct for tp_as_mapping field.
2998
2999 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3000
3001         * objfiles.h (objfile): Add a comment describing partial symbols.
3002
3003 2019-08-05  Tom Tromey  <tromey@adacore.com>
3004
3005         * compile/compile.c (_initialize_compile): Use _(), not N_().
3006         * thread.c (_initialize_thread): Use _(), not N_().
3007         * stack.c (_initialize_stack): Use _(), not N_().
3008         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3009
3010 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3011
3012         * dwarf2read.c (struct dw2_symtab_iterator):
3013         <want_specific_block>: Remove.
3014         <block_index>: Change type to gdb::optional.
3015         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3016         change type of BLOCK_INDEX parameter to gdb::optional.
3017         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3018         (dw2_lookup_symbol): Don't pass argument for
3019         WANT_SPECIFIC_BLOCK.
3020         (dw2_expand_symtabs_for_function): Don't pass argument for
3021         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3022         (class dw2_debug_names_iterator)
3023         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3024         parameter, change BLOCK_INDEX type to gdb::optional.
3025         <m_want_specific_block>: Remove.
3026         <m_block_index>: Change type to gdb::optional.
3027         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3028         gdb::optional.  Re-write in function of gdb::optional.
3029         (dw2_debug_names_lookup_symbol): Don't pass argument for
3030         WANT_SPECIFIC_BLOCK.
3031         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3032         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3033         BLOCK_INDEX.
3034
3035 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3036
3037         * NEWS: Mention changes to "info sources" command.
3038
3039 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3040
3041         * symtab.c (filename_partial_match_opts): New struct type.
3042         (struct output_source_filename_data): New members
3043         regexp, c_regexp, partial_match.
3044         (output_source_filename): Use new members to decide to print file.
3045         (info_sources_option_defs): New variable.
3046         (make_info_sources_options_def_group, print_info_sources_header,
3047         info_sources_command_completer):
3048         New functions.
3049         (info_sources_command): Read new optional arguments.
3050         (_initialize_symtab): Update info sources help.
3051
3052 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3053
3054         * ada-lang.c (exception_support_info_v0): Renamed from...
3055         (default_exception_support_info): ... this.  Create new
3056         definition for v1.
3057         (ada_has_this_exception_support): Look up catch_handlers_sym.
3058         (ada_exception_support_info_sniffer): Try v0 after default.
3059
3060 2019-08-01  Tom Tromey  <tromey@adacore.com>
3061
3062         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3063         gdbarch.h.
3064
3065 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3066
3067         * s12z-tdep.c: Fix include path for s12z-opc.h.
3068
3069 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3070
3071         * NEWS: Require GNU make 3.82.
3072
3073 2019-07-16  Tom Tromey  <tom@tromey.com>
3074
3075         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3076         declare.
3077
3078 2019-07-30  Tom Tromey  <tromey@adacore.com>
3079
3080         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3081
3082 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3083
3084         * printcmd.c (print_address_symbolic): Print negative offsets.
3085         (build_address_symbolic): Force signed arithmetic when computing
3086         offset.
3087
3088 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3089
3090         PR/24474: Add a function to lookup static variables.
3091         * NEWS: Mention this new function.
3092         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3093         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3094         * python/python.c (python_GdbMethods): Add new function.
3095
3096 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3097
3098         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3099         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3100         (objfpy_lookup_static_symbol): New function.
3101         (objfile_object_methods): Add new functions.
3102
3103 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3104
3105         * NEWS: Mention 'set|show print frame-info'.  Mention new
3106         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3107         backtrace argument.  Mention that python frame filtering code
3108         is now consistent with what 'backtrace' command prints.
3109
3110 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3111
3112         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3113         comments.
3114         (print_frame_info_auto, print_frame_info_source_line,
3115         print_frame_info_location, print_frame_info_source_and_location,
3116         print_frame_info_location_and_address, print_frame_info_short_location):
3117         New declarations.
3118         (struct frame_print_options): New member print_frame_info.
3119         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3120         * stack.h (get_user_print_what_frame_info): New declaration.
3121         (frame_show_address): New declaration.
3122         * stack.c (print_frame_arguments_choices): New value 'presence'.
3123         (print_frame_info_auto, print_frame_info_source_line,
3124         print_frame_info_location, print_frame_info_source_and_location,
3125         print_frame_info_location_and_address, print_frame_info_short_location,
3126         print_frame_info_choices, print_frame_info_print_what): New definitions.
3127         (print_frame_args): Only print dots for args if print frame-arguments
3128         is 'presence'.
3129         (frame_print_option_defs): New element for "frame-info".
3130         (get_user_print_what_frame_info): New function.
3131         (frame_show_address): Make non static.  Move comment to stack.h.
3132         (print_frame_info_to_print_what): New function.
3133         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3134         to decide what to print.
3135         (backtrace_command_1): Handle the new print_frame_arguments_presence
3136         value.
3137         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3138         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3139         (py_print_frame): In non-mi mode, use LOCATION as default for
3140         print_what, similarly to frame information printed directly by
3141         backtrace command. Handle frame-info user option in non MI mode.
3142
3143 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3144
3145         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3146         Add case for debugging 32-bit target on 64-bit host.  Revise
3147         comment.
3148
3149 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3150
3151         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3152         instead of find_function_entry_range_from_pc.
3153
3154 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3155
3156         * stack.c (find_frame_funname): Remove code which preferred
3157         minsym over symtab sym in "certain pathological cases".
3158
3159         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3160         parameter.  Change type of "do_demangle" to bool.
3161         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3162         Pass suitable "prefer_sym_over_minsym" flag to
3163         build_address_symbolic().  Don't output "+" for negative offsets.
3164         * printcmd.c (print_address_symbolic): Update invocation of
3165         build_address_symbolic to include a "prefer_sym_over_minsym"
3166         flag.
3167         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3168         Restrict cases in which use of minimal symbol is preferred to that
3169         of a found symbol.  Update comments.
3170
3171         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3172         for entry pc when entry pc is out of range for that FDE.
3173
3174 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3175
3176         PR gdb/24839:
3177         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3178         type.
3179
3180 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3181
3182         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3183         this function's Python signature.
3184
3185
3186 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3187
3188         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3189         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3190         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3191         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3192         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3193
3194
3195 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3196
3197         * h8300-tdep.c (h8300_register_name_common): New.
3198         h8300_register_name): Use h8300_register_name_common.
3199         (h8300s_register_name): Likewise.
3200         (h8300sx_register_name): Likewise.
3201         (h8300h_register_nam): New.
3202         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3203
3204
3205 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3206
3207         * arm-tdep.c (arm_skip_cmse_entry): New function.
3208         (arm_is_sgstubs_section): New function.
3209         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3210
3211 2019-07-22  Tom Tromey  <tom@tromey.com>
3212
3213         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3214         Don't self-assign.
3215
3216 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3217
3218         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3219         type_print.
3220
3221 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3222
3223         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3224         so that GDB doesn't match any msymbols when searching in the
3225         TYPES_DOMAIN.
3226         (print_symbol_info): Print using typedef_print or type_print based
3227         on the type of the symbol.  Add updated FIXME comment moved from...
3228         (_initialize_symtab): ... move and update FIXME comment to above.
3229
3230 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3231
3232         * NEWS: Mention adding -q option to "info types".
3233         * symtab.c (struct info_types_options): New struct.
3234         (info_types_options_defs): New variable.
3235         (make_info_types_options_def_group): New function.
3236         (info_types_command): Use gdb::option framework to parse options.
3237         (info_types_command_completer): New function.
3238         (_initialize_symtab): Extend the help text on "info types" and
3239         register command completer.
3240
3241 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3242
3243         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3244         (lookup_symbol_in_objfile): Change int to block_enum and add a
3245         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3246
3247 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3248
3249         * MAINTAINERS (Write After Approval): Add self.
3250
3251 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3252
3253         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3254         instruction to the dummy code region.
3255
3256 2019-07-19  Tom Tromey  <tromey@adacore.com>
3257
3258         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3259         (ARGSUSED, PARAMS, __func__): Remove rules.
3260
3261 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3262
3263         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3264         * features/arm/arm-with-iwmmxt.c: Remove.
3265         * features/arm/arm-with-iwmmxt.xml: Remove.
3266         * features/arm/arm-with-m-fpa-layout.c: Remove.
3267         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3268         * features/arm/arm-with-m-vfp-d16.c: Remove.
3269         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3270         * features/arm/arm-with-m.c: Remove.
3271         * features/arm/arm-with-m.xml: Remove.
3272         * features/arm/arm-with-neon.c: Remove.
3273         * features/arm/arm-with-neon.xml: Remove.
3274         * features/arm/arm-with-vfpv2.c: Remove.
3275         * features/arm/arm-with-vfpv2.xml: Remove.
3276         * features/arm/arm-with-vfpv3.c: Remove.
3277         * features/arm/arm-with-vfpv3.xml: Remove.
3278
3279 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3280
3281         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3282
3283 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3284
3285         * arch/aarch32.c (aarch32_create_target_description): Create
3286         target descriptions using features.
3287         * arch/arm.c (arm_create_target_description)
3288         (arm_create_mprofile_target_description): Likewise.
3289         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3290
3291 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3292
3293         * Makefile.in: Add new files.
3294         * aarch32-tdep.c: New file.
3295         * aarch32-tdep.h: New file.
3296         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3297         Call aarch32_read_description.
3298         * arch/aarch32.c: New file.
3299         * arch/aarch32.h: New file.
3300         * arch/arm.c (arm_create_target_description)
3301         (arm_create_mprofile_target_description): New function.
3302         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3303         (arm_create_target_description)
3304         (arm_create_mprofile_target_description): New declaration.
3305         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3306         read_description functions.
3307         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3308         Likewise.
3309         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3310         * arm-tdep.c (tdesc_arm_list): New variable.
3311         (arm_register_g_packet_guesses): Call create description functions.
3312         (arm_read_description) (arm_read_mprofile_description): New
3313         function.
3314         * arm-tdep.h (arm_read_description)
3315         (arm_read_mprofile_description): Add declaration.
3316         * configure.tgt: Add new files.
3317
3318 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3319
3320         * top.c (new_ui_command): Open specified terminal just once.
3321
3322 2019-07-18  Tom Tromey  <tromey@adacore.com>
3323
3324         * symtab.c (main_name): Constify return type.
3325         * symfile.c (set_initial_language): Update.
3326         * symtab.h (main_name): Constify return type.
3327
3328 2019-07-17  Tom Tromey  <tom@tromey.com>
3329
3330         * tui/tui-winsource.c (tui_update_source_window)
3331         (tui_update_source_window_as_is)
3332         (tui_update_source_windows_with_line): Remove return.
3333         * tui/tui-disasm.c (tui_show_disassem)
3334         (tui_show_disassem_and_update_source): Remove return.
3335         * tui/tui.c (tui_reset): Remove return.
3336         * tui/tui-wingeneral.c
3337         (tui_check_and_display_highlight_if_needed): Remove return.
3338
3339 2019-07-17  Tom Tromey  <tom@tromey.com>
3340
3341         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3342
3343 2019-07-17  Tom Tromey  <tom@tromey.com>
3344
3345         * tui/tui-winsource.h (struct tui_exec_info_window)
3346         (struct tui_source_window_base): Move from tui-data.h.
3347         * tui/tui-winsource.c: Move many method definitions from
3348         elsewhere.  Remove "structuring" comments.
3349         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3350         (tui_source_window_base::refresh_window): Move to
3351         tui-winsource.c.
3352         * tui/tui-win.c (tui_source_window_base::refresh_all)
3353         (tui_source_window_base::update_tab_width)
3354         (tui_source_window_base::set_new_height)
3355         (tui_source_window_base::do_make_visible_with_new_height): Move to
3356         tui-winsource.c.
3357         * tui/tui-source.h: Update.
3358         * tui/tui-source.c (tui_source_window_base::reset): Move to
3359         tui-winsource.c.
3360         * tui/tui-disasm.h: Update.
3361         * tui/tui-data.h (struct tui_exec_info_window): Move to
3362         tui-winsource.h.
3363         (struct tui_source_window_base): Likewise.
3364         * tui/tui-data.c (tui_source_window_base::clear_detail)
3365         (tui_source_window_base, ~tui_source_window_base): Move to
3366         tui-winsource.c.
3367
3368 2019-07-17  Tom Tromey  <tom@tromey.com>
3369
3370         * tui/tui-win.c (tui_resize_all)
3371         (tui_source_window_base::update_tab_width)
3372         (tui_adjust_win_heights): Update.
3373         (tui_win_info::make_invisible_and_set_new_height): Rename from
3374         make_invisible_and_set_new_height.
3375         * tui/tui-data.h (struct tui_win_info)
3376         <make_invisible_and_set_new_height>: New method.
3377
3378 2019-07-17  Tom Tromey  <tom@tromey.com>
3379
3380         * tui/tui.c: Update.
3381         * tui/tui-source.h (struct tui_source_window): Move from
3382         tui-data.h.
3383         * tui/tui-layout.c: Update.
3384         * tui/tui-disasm.c: Update.
3385         * tui/tui-data.h (struct tui_source_window): Move to
3386         tui-source.h.
3387
3388 2019-07-17  Tom Tromey  <tom@tromey.com>
3389
3390         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3391         tui-data.h.
3392         * tui/tui-data.h (struct tui_disasm_window): Move to
3393         tui-disasm.h.
3394
3395 2019-07-17  Tom Tromey  <tom@tromey.com>
3396
3397         * tui/tui-regs.h (struct tui_data_item_window): Move from
3398         tui-data.h.
3399         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3400         * tui/tui-data.h (struct tui_data_item_window): Move to
3401         tui-regs.h.
3402         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3403
3404 2019-07-17  Tom Tromey  <tom@tromey.com>
3405
3406         * tui/tui.c: Update.
3407         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3408         (tui_cmd_window::max_height): Move to tui-command.c.
3409         * tui/tui-layout.c: Update.
3410         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3411         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3412         tui-command.c.
3413         * tui/tui-command.h (struct tui_cmd_window): Move from
3414         tui-data.h.
3415         * tui/tui-command.c: Remove "structuring" comments.
3416         (tui_cmd_window::clear_detail)
3417         (tui_cmd_window::do_make_visible_with_new_height)
3418         (tui_cmd_window::max_height): Move from elsewhere.
3419
3420 2019-07-17  Tom Tromey  <tom@tromey.com>
3421
3422         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3423         Now static.
3424         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3425         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3426
3427 2019-07-17  Tom Tromey  <tom@tromey.com>
3428
3429         * tui/tui.c: Update.
3430         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3431         tui-regs.c.
3432         * tui/tui-windata.h: Remove file.
3433         * tui/tui-windata.c: Remove file.
3434         * tui/tui-win.c (tui_data_window::set_new_height)
3435         (tui_data_window::do_make_visible_with_new_height): Move to
3436         tui-regs.c.
3437         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3438         * tui/tui-regs.c: Remove "structuring" comments.
3439         (tui_data_window::first_data_item_displayed)
3440         (tui_data_window::delete_data_content_windows)
3441         (tui_data_window::erase_data_content)
3442         (tui_data_window::display_all_data)
3443         (tui_data_window::refresh_all)
3444         (tui_data_window::do_scroll_vertical)
3445         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3446         (tui_data_window::do_make_visible_with_new_height)
3447         (tui_data_window::refresh_window): Move from elsewhere.
3448         (_initialize_tui_regs): Move to end of file.
3449         * tui/tui-layout.c: Update.
3450         * tui/tui-hooks.c: Update.
3451         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3452         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3453         tui-regs.c.
3454         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3455
3456 2019-07-17  Tom Tromey  <tom@tromey.com>
3457
3458         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3459         seen.
3460
3461 2019-07-17  Tom Tromey  <tom@tromey.com>
3462
3463         * tui/tui-win.c (tui_source_window_base::set_new_height)
3464         (tui_source_window_base::do_make_visible_with_new_height): Use
3465         m_has_locator field directly.
3466         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3467         method.
3468         (struct tui_source_window_base) <has_locator>: Likewise.
3469
3470 2019-07-17  Tom Tromey  <tom@tromey.com>
3471
3472         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3473         Don't declare.
3474         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3475         Remove.
3476         * tui/tui-win.c (tui_source_window_base::set_new_height)
3477         (tui_source_window_base::set_new_height)
3478         (make_invisible_and_set_new_height)
3479         (tui_source_window_base::do_make_visible_with_new_height)
3480         (tui_source_window_base::do_make_visible_with_new_height):
3481         Update.
3482         * tui/tui-layout.c (show_source_disasm_command, show_data)
3483         (show_source_or_disasm_and_command): Update.
3484         * tui/tui-layout.c (show_layout): Update.
3485
3486 2019-07-17  Tom Tromey  <tom@tromey.com>
3487
3488         * tui/tui-layout.c (make_data_window): Remove.
3489         (show_data): Unify creation and re-initialization cases.
3490
3491 2019-07-17  Tom Tromey  <tom@tromey.com>
3492
3493         * tui/tui-layout.c (make_source_window, make_disasm_window):
3494         Remove.
3495         (show_data): Unify creation and re-initialization cases.
3496
3497 2019-07-17  Tom Tromey  <tom@tromey.com>
3498
3499         * tui/tui-layout.c (make_command_window): Remove.
3500         (show_source_disasm_command, show_source_or_disasm_and_command):
3501         Unify creation and re-initialization cases.
3502
3503 2019-07-17  Tom Tromey  <tom@tromey.com>
3504
3505         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3506         creation and re-initialization cases.
3507
3508 2019-07-17  Tom Tromey  <tom@tromey.com>
3509
3510         * tui/tui-regs.c (tui_get_register): Return void.
3511
3512 2019-07-17  Tom Tromey  <tom@tromey.com>
3513
3514         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3515         Simplify.
3516
3517 2019-07-17  Tom Tromey  <tom@tromey.com>
3518
3519         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3520         resetting.
3521
3522 2019-07-17  Tom Tromey  <tom@tromey.com>
3523
3524         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3525         * tui/tui-regs.c (tui_reg_layout): New function.
3526         (tui_show_registers, tui_reg_command): Use it.
3527         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3528         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3529         parameters.
3530         (tui_layout_command): Remove.
3531
3532 2019-07-17  Tom Tromey  <tom@tromey.com>
3533
3534         * tui/tui-layout.h (tui/tui-layout): Return void.
3535         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3536
3537 2019-07-17  Tom Tromey  <tom@tromey.com>
3538
3539         * tui/tui-layout.c (show_source_disasm_command, show_data):
3540         Update.
3541         (reset_locator): Remove.
3542         (show_source_or_disasm_and_command): Update.
3543
3544 2019-07-17  Tom Tromey  <tom@tromey.com>
3545
3546         * tui/tui-source.c (tui_source_window_base::reset): Remove
3547         win_type parameter.
3548         * tui/tui-layout.c (make_command_window, make_source_window)
3549         (make_disasm_window, make_data_window)
3550         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3551         (reset_locator, show_source_or_disasm_and_command): Update.
3552         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3553         win_type parameter.
3554         (struct tui_source_window_base) <reset>: Likewise.
3555
3556 2019-07-17  Tom Tromey  <tom@tromey.com>
3557
3558         * tui/tui-layout.c (show_source_disasm_command): Use
3559         reset_locator.
3560         (reset_locator): New function.
3561         (init_and_make_win): Remove.
3562         (show_source_or_disasm_and_command): Use reset_locator.
3563
3564 2019-07-17  Tom Tromey  <tom@tromey.com>
3565
3566         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3567         condition.
3568         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3569         Remove condition.
3570         * tui/tui-source.c (tui_source_window_base::reset): New method.
3571         * tui/tui-layout.c (make_command_window): Don't call
3572         init_and_make_win.
3573         (make_source_window, make_disasm_window): Don't call
3574         make_source_or_disasm_window.
3575         (make_data_window): Don't call init_and_make_win.  Change calling
3576         convention.
3577         (show_source_disasm_command, show_data): Simplify.
3578         (make_source_or_disasm_window): Remove.
3579         (show_source_or_disasm_and_command): Simplify.
3580         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3581         (struct tui_source_window_base) <reset>: Likewise.
3582         <execution_info>: Remove initializer.
3583         * tui/tui-data.c (tui_source_window_base): Initialize
3584         execution_info.
3585
3586 2019-07-17  Tom Tromey  <tom@tromey.com>
3587
3588         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3589         variable.
3590
3591 2019-07-17  Tom Tromey  <tom@tromey.com>
3592
3593         * tui/tui.c (tui_rl_other_window): Update.
3594         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3595         superclass method first.  Always iterate over regs_content.
3596         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3597         method.
3598         * tui/tui-win.c (tui_set_focus_command): Update.
3599
3600 2019-07-17  Tom Tromey  <tom@tromey.com>
3601
3602         * tui/tui-win.c (tui_set_focus_command): Rename from
3603         tui_set_focus.  Call tui_enable.
3604         (tui_set_focus_command): Remove.
3605
3606 2019-07-17  Tom Tromey  <tom@tromey.com>
3607
3608         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3609         refresh_window.
3610         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3611         touchwin.
3612         (tui_data_window::refresh_window): Call refresh_window on data
3613         items.  Always call superclass refresh_window.
3614         (tui_win_info::refresh): Remove.
3615         (tui_source_window_base::refresh_window): Update.
3616         (tui_refresh_all): Update.
3617         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3618         refresh_window.
3619         (show_source_or_disasm_and_command): Likewise.
3620         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3621         (struct tui_source_window_base) <refresh>: Likewise.
3622
3623 2019-07-17  Tom Tromey  <tom@tromey.com>
3624
3625         * tui/tui-winsource.c (tui_clear_source_content)
3626         (tui_show_source_content): Update.
3627         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3628         whether content is empty.
3629         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3630         Remove.
3631
3632 2019-07-17  Tom Tromey  <tom@tromey.com>
3633
3634         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3635         window's contents.
3636         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3637         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3638
3639 2019-07-17  Tom Tromey  <tom@tromey.com>
3640
3641         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3642         (struct tui_data_item_window): Update.
3643
3644 2019-07-17  Tom Tromey  <tom@tromey.com>
3645
3646         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3647         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3648         defines.
3649
3650 2019-07-17  Tom Tromey  <tom@tromey.com>
3651
3652         * tui/tui-winsource.h (tui_erase_source_content)
3653         (tui_clear_source_content): Remove "display_prompt" parameter.
3654         * tui/tui-winsource.c (tui_update_source_window_as_is)
3655         (tui_update_source_windows_with_addr): Update.
3656         (tui_clear_source_content): Remove "display_prompt" parameter.
3657         (tui_erase_source_content): Likewise.  Simplify.
3658         (tui_show_source_content): Update.
3659         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3660         * tui/tui-stack.c (tui_show_frame_info): Update.
3661         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3662         Remove defines.
3663
3664 2019-07-17  Tom Tromey  <tom@tromey.com>
3665
3666         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3667         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3668         parameter.
3669         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3670         parameter.
3671
3672 2019-07-17  Tom Tromey  <tom@tromey.com>
3673
3674         * tui/tui-winsource.c (tui_clear_source_content)
3675         (tui_show_source_content, tui_show_exec_info_content)
3676         (tui_clear_exec_info_content): Update.
3677         * tui/tui-stack.c (tui_show_locator_content): Update.
3678         (tui_show_frame_info): Update.
3679         * tui/tui-source.h (tui_source_window): Don't declare.
3680         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3681         from tui_source_is_displayed.
3682         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3683         Remove field.
3684         (struct tui_source_window_base) <content_in_use>: New field.  Now
3685         bool.
3686         (struct tui_source_window) <showing_source_p>: New method.
3687         (TUI_SRC_WIN): Change cast.
3688         * tui/tui-data.c (tui_initialize_static_data): Update.
3689
3690 2019-07-17  Tom Tromey  <tom@tromey.com>
3691
3692         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3693         location_matches_p.
3694         * tui/tui-source.c (tui_source_window::location_matches_p): New
3695         method.
3696         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3697         method.
3698         * tui/tui-data.h (struct tui_source_window_base)
3699         <location_matches_p>: New method.
3700         (struct tui_source_window, struct tui_disasm_window)
3701         <location_matches_p>: Likewise.
3702
3703 2019-07-17  Tom Tromey  <tom@tromey.com>
3704
3705         * tui/tui-win.c (tui_set_win_height_command): Rename from
3706         tui_set_win_height.
3707         (tui_set_win_height_command): Remove.
3708
3709 2019-07-17  Tom Tromey  <tom@tromey.com>
3710
3711         * tui/tui-source.c (tui_source_window): New constructor.  Add
3712         observer.
3713         (~tui_source_window): New destructor.
3714         (tui_source_window::style_changed): New method.
3715         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3716         (tui_attach_detach_observers): Update.
3717         * tui/tui-data.h (struct tui_source_window): Make constructor not
3718         inline.  Add destructor.
3719         (struct tui_source_window) <style_changed>: New method.
3720         <m_observable>: New member.
3721
3722 2019-07-17  Tom Tromey  <tom@tromey.com>
3723
3724         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3725         * tui/tui-win.c (tui_resize_all): Fix typo.
3726
3727 2019-07-17  Tom Tromey  <tom@tromey.com>
3728
3729         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3730         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3731         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3732         * tui/tui-win.c (window_name_completer): Use foreach.
3733         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3734         (update_tab_width): Likewise.
3735         * tui/tui-layout.c (show_layout): Update.
3736         * tui/tui-data.h (class tui_window_iterator): New.
3737         (struct all_tui_windows): New.
3738         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3739
3740 2019-07-17  Tom Tromey  <tom@tromey.com>
3741
3742         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3743         parameter.  Don't reference globals.
3744         (tui_reg_command): Update.
3745
3746 2019-07-17  Tom Tromey  <tom@tromey.com>
3747
3748         * tui/tui-regs.c (tui_show_registers): Simplify.
3749
3750 2019-07-17  Tom Tromey  <tom@tromey.com>
3751
3752         * tui/tui-regs.c (tui_show_registers): Update.
3753         (tui_show_register_group): Add win_info parameter.
3754
3755 2019-07-17  Tom Tromey  <tom@tromey.com>
3756
3757         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3758         Rename from tui_display_reg_element_at_line.
3759         (tui_data_window::display_registers_from_line): Update.
3760         * tui/tui-data.h (struct tui_data_window)
3761         <display_reg_element_at_line>: New method.
3762
3763 2019-07-17  Tom Tromey  <tom@tromey.com>
3764
3765         * tui/tui-regs.h (tui_display_registers_from)
3766         (tui_display_registers_from_line): Don't declare.
3767         * tui/tui-windata.c (tui_data_window::display_all_data)
3768         (tui_data_window::refresh_all)
3769         (tui_data_window::do_scroll_vertical): Update.
3770         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3771         from tui_display_registers_from.
3772         (tui_display_reg_element_at_line): Update.
3773         (tui_data_window::display_registers_from_line): Rename from
3774         tui_display_registers_from_line.
3775         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3776         display_registers_from_line>: New methods.
3777
3778 2019-07-17  Tom Tromey  <tom@tromey.com>
3779
3780         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3781         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3782         from tui_erase_data_content.
3783         (tui_data_window::display_all_data)
3784         (tui_data_window::refresh_all)
3785         (tui_data_window::do_scroll_vertical): Update.
3786         * tui/tui-regs.c (tui_show_registers): Update.
3787         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3788         New method.
3789
3790 2019-07-17  Tom Tromey  <tom@tromey.com>
3791
3792         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3793         declare.
3794         * tui/tui-windata.c
3795         (tui_data_window::delete_data_content_windows): Rename from
3796         tui_delete_data_content_windows.
3797         (tui_data_window::display_all_data)
3798         (tui_data_window::do_scroll_vertical): Update.
3799         * tui/tui-data.h (struct tui_data_window)
3800         <delete_data_content_windows>: New method.
3801
3802 2019-07-17  Tom Tromey  <tom@tromey.com>
3803
3804         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3805         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3806
3807 2019-07-17  Tom Tromey  <tom@tromey.com>
3808
3809         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3810         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3811         from tui_display_all_data.
3812         * tui/tui-win.c
3813         (tui_data_window::do_make_visible_with_new_height): Update.
3814         * tui/tui-regs.c (tui_show_registers): Update.
3815         * tui/tui-layout.c (tui_set_layout): Update.
3816         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3817         method.
3818
3819 2019-07-17  Tom Tromey  <tom@tromey.com>
3820
3821         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3822         * tui/tui-windata.c (tui_display_data_from): Remove.
3823         (tui_data_window::refresh_all): Update.
3824
3825 2019-07-17  Tom Tromey  <tom@tromey.com>
3826
3827         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3828         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3829         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3830         tui_display_registers_from_line.
3831         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3832         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3833         "force_display" parameter.
3834
3835 2019-07-17  Tom Tromey  <tom@tromey.com>
3836
3837         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3838         declare.
3839         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3840         Rename from tui_first_reg_element_no_inline.
3841         (tui_display_reg_element_at_line)
3842         (tui_display_registers_from_line): Update.
3843         * tui/tui-data.h (struct tui_data_window)
3844         <first_reg_element_no_inline>: New method.
3845
3846 2019-07-17  Tom Tromey  <tom@tromey.com>
3847
3848         * tui/tui-windata.c (tui_display_data_from)
3849         (tui_data_window::do_scroll_vertical): Update.
3850         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3851         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3852         Rename from tui_line_from_reg_element_no.
3853         (tui_display_registers_from_line): Update.
3854         * tui/tui-data.h (struct tui_data_window)
3855         <line_from_reg_element_no>: New method.
3856
3857 2019-07-17  Tom Tromey  <tom@tromey.com>
3858
3859         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3860         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3861         tui_last_regs_line_no.
3862         (tui_display_reg_element_at_line)
3863         (tui_display_registers_from_line): Update.
3864         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3865         method.
3866
3867 2019-07-17  Tom Tromey  <tom@tromey.com>
3868
3869         PR tui/24722:
3870         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3871         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3872         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3873         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3874         (tui_update_breakpoint_info): Likewise.
3875         * tui/tui-hooks.c (tui_event_create_breakpoint)
3876         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3877         Update.
3878
3879 2019-07-17  Tom Tromey  <tom@tromey.com>
3880
3881         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3882
3883 2019-07-17  Tom Tromey  <tom@tromey.com>
3884
3885         * tui/tui-winsource.c (tui_update_source_window_as_is)
3886         (tui_update_source_windows_with_addr): Update.
3887         * tui/tui-source.h (tui_set_source_content)
3888         (tui_show_symtab_source): Add "win_info" parameter.
3889         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3890         parameter.
3891         (tui_show_symtab_source): Likewise.
3892
3893 2019-07-17  Tom Tromey  <tom@tromey.com>
3894
3895         * tui/tui-wingeneral.c
3896         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3897
3898 2019-07-17  Tom Tromey  <tom@tromey.com>
3899
3900         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3901         (struct tui_cmd_window) <can_scroll>: New method.
3902         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3903         method.
3904
3905 2019-07-17  Tom Tromey  <tromey@adacore.com>
3906
3907         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3908         do_field_signed>: Rename.  Change type of "value".
3909         * ui-out.c (ui_out::field_signed): Rename from field_int.
3910         Change type of "value".
3911         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3912         type of "value".
3913         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3914         do_field_int.  Change type of "value".
3915         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3916         do_field_int.  Change type of "value".
3917         * tracepoint.c (trace_status_mi, tfind_1)
3918         (print_one_static_tracepoint_marker): Update.
3919         * thread.c (print_thread_info_1, print_selected_thread_frame):
3920         Update.
3921         * stack.c (print_frame, print_frame_info): Update.
3922         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3923         Update.
3924         * source.c (print_source_lines_base): Update.
3925         * skip.c (info_skip_command): Update.
3926         * record-btrace.c (btrace_ui_out_decode_error)
3927         (btrace_call_history_src_line): Update.
3928         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3929         Update.
3930         * progspace.c (print_program_space): Update.
3931         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3932         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3933         do_field_int.  Change type of "value".
3934         * mi/mi-out.c (mi_ui_out::do_table_begin)
3935         (mi_ui_out::do_table_header): Update.
3936         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3937         type of "value".
3938         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3939         (mi_cmd_data_list_changed_registers, output_register)
3940         (mi_cmd_data_read_memory, mi_load_progress)
3941         (mi_cmd_trace_frame_collected): Update.
3942         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3943         Update.
3944         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3945         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3946         (mi_cmd_var_list_children, varobj_update_one): Update.
3947         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3948         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3949         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3950         * inferior.c (print_inferior): Update.
3951         * gdb_bfd.c (print_one_bfd): Update.
3952         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3953         Update.
3954         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3955         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3956         do_field_int.  Change type of "value".
3957         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3958         do_field_int.  Change type of "value".
3959         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3960         (print_one_breakpoint_location, print_it_catch_fork)
3961         (print_one_catch_fork, print_it_catch_vfork)
3962         (print_one_catch_vfork, print_it_catch_solib)
3963         (print_it_catch_exec, print_it_ranged_breakpoint)
3964         (print_mention_watchpoint, print_mention_masked_watchpoint)
3965         (bkpt_print_it, update_static_tracepoint): Update.
3966         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3967         * break-catch-syscall.c (print_it_catch_syscall): Update.
3968         * ada-tasks.c (print_ada_task_info): Update.
3969         * ada-lang.c (print_it_exception, print_mention_exception):
3970         Update.
3971
3972 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3973
3974         PR breakpoints/24541
3975         * gdbarch.c: Regenerate.
3976         * gdbarch.h: Regenerate.
3977         * gdbarch.sh: Adjust return type and parameter types for
3978         'stap_adjust_register'.
3979         (i386_stap_adjust_register): Adjust signature and return new
3980         register name.
3981         * stap-probe.c (stap_parse_register_operand): Adjust use of
3982         'gdbarch_stap_adjust_register'.
3983
3984 2019-07-17  Tom Tromey  <tromey@adacore.com>
3985
3986         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3987         declare VEC.
3988         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3989         std::vector.
3990         (struct s390_process_info): Add initializers.
3991         (s390_add_process): Use new.
3992         (s390_linux_nat_target::low_forget_process): Use delete.
3993         (s390_linux_nat_target::low_new_fork)
3994         (s390_linux_nat_target::stopped_by_watchpoint)
3995         (s390_linux_nat_target::low_prepare_to_resume)
3996         (s390_linux_nat_target::insert_watchpoint)
3997         (s390_linux_nat_target::insert_hw_breakpoint)
3998         (s390_linux_nat_target::remove_watchpoint)
3999         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4000
4001 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4002
4003         * aarch64-fbsd-nat.c: Include regcache.h.
4004         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4005         argument.
4006         (aarch64_fbsd_nat_target::fetch_registers)
4007         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4008         variable.
4009         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4010
4011 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4012
4013         * fbsd-nat.c: Include gdbarch.h.
4014
4015 2019-07-15  Tom Tromey  <tromey@adacore.com>
4016
4017         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4018
4019 2019-07-15  Tom Tromey  <tromey@adacore.com>
4020
4021         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4022         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4023         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4024         * cli-out.c (cli_ui_out::do_field_int): New method.
4025         * ui-out.c (ui_out::field_unsigned): New method.
4026         * symfile.c (generic_load): Use field_unsigned.
4027         (print_transfer_performance): Likewise.
4028         * record-btrace.c (ui_out_field_uint): Remove.
4029         (btrace_call_history_insn_range, btrace_call_history): Use
4030         field_unsigned.
4031         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4032         field_unsigned.
4033         * ui-out.h (class ui_out) <field_unsigned>: New method.
4034         <do_field_unsigned>: Likewise.
4035
4036 2019-07-15  Tom Tromey  <tromey@adacore.com>
4037
4038         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4039         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4040         * target.c (flash_erase_command): Use field_string.
4041         * infrun.c (print_signal_received_reason): Use field_string.
4042         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4043         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4044         field_string.
4045         * ada-tasks.c (print_ada_task_info): Use field_string.
4046
4047 2019-07-15  Tom Tromey  <tromey@adacore.com>
4048
4049         * target.c (flash_erase_command): Use field_core_addr.
4050         * symfile.c (generic_load): Use field_core_addr.
4051         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4052         Use field_core_addr.
4053         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4054         field_core_addr.
4055
4056 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4057
4058         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4059         value if its desired type is smaller than a CORE_ADDR and signed.
4060
4061 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4062
4063         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4064         of changes to field names, and use new is_reference field to
4065         decide if a property is a reference or not.
4066         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4067         field.
4068         (struct dwarf2_property_baton): Update header comment, rename
4069         'referenced_type' to 'property_type' and update comments.
4070         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4071         default property type, store in property baton, update to take
4072         accound of renamed field.
4073         (read_func_scope): Update call to attr_to_dynamic_prop.
4074         (read_array_type): Likewise.
4075         (dwarf2_per_cu_addr_sized_int_type): New function.
4076         (read_subrange_index_type): Move type finding code to
4077         dwarf2_per_cu_addr_sized_int_type.
4078         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4079         (dwarf2_per_cu_addr_type): New function.
4080         (set_die_type): Update calls to attr_to_dynamic_prop.
4081
4082 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4083
4084         * dwarf2read.c (read_subrange_index_type): New function.
4085         (read_subrange_type): Move code into new function and call it.
4086         * gdbtypes.c (create_range_type): Add some asserts.
4087
4088 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4089
4090         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4091         update return statements.
4092         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4093         declaration, and update comment to match.
4094         * gdbtypes.c (resolve_dynamic_array): Update call to
4095         dwarf2_evaluate_property to match new return type.
4096
4097 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4098
4099         * valarith.c (value_subscripted_rvalue): Change lowerbound
4100         parameter type from int to LONGEST.
4101         * value.h (value_subscripted_rvalue): Likewise in declaration.
4102
4103 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4104
4105         * cli/cli-utils.c (info_print_command_completer): New function.
4106         * cli/cli-utils.h: Add 'completer.h' include, and forward
4107         declaration for 'struct cmd_list_element'.
4108         (info_print_command_completer): Declare.
4109         * stack.c (_initialize_stack): Add completer for 'info locals' and
4110         'info args'.
4111         * symtab.c (_initialize_symtab): Add completer for 'info
4112         variables' and 'info functions'.
4113         * NEWS: Mention completion for additional info commands.
4114
4115 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4116
4117         * cli/cli-utils.c (extract_info_print_args): Delete.
4118         (extract_arg_maybe_quoted): Delete.
4119         (info_print_options_defs): New variable.
4120         (make_info_print_options_def_group): New function.
4121         (extract_info_print_options): Define new function.
4122         * cli/cli-utils.h (extract_info_print_args): Delete.
4123         (struct info_print_options): New structure.
4124         (extract_info_print_options): Declare new function.
4125         * stack.c (info_locals_command): Update to use new
4126         extract_info_print_options, also add a header comment.
4127         (info_args_command): Likewise.
4128         * symtab.c (info_variables_command): Likewise.
4129         (info_functions_command): Likewise.
4130
4131 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4132
4133         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4134         to extract string arguments.
4135         * common/common-utils.c (extract_string_maybe_quoted): New function.
4136         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4137
4138 2019-07-11  Tom Tromey  <tromey@adacore.com>
4139
4140         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4141         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4142         * top.h (gdbinit): Don't declare.
4143         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4144         into...
4145         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4146         * top.c (gdb_init): Don't call init_cli_cmds.
4147         (gdbinit): Remove.
4148         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4149
4150 2019-07-11  Tom Tromey  <tromey@adacore.com>
4151
4152         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4153         after it has been moved.
4154
4155 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4156
4157         * valops.c (value_must_coerce_to_target): Change return type to
4158         bool.
4159         * value.h (value_must_coerce_to_target): Likewise.
4160
4161 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4162
4163         * breakpoint.c (is_hardware_watchpoint): Remove
4164         forward-declaration.
4165         (is_masked_watchpoint): Change return type to bool.
4166         (is_tracepoint): Likewise.
4167         (is_breakpoint): Likewise.
4168         (is_hardware_watchpoint): Likewise.
4169         (is_watchpoint): Likewise.
4170         (is_no_memory_software_watchpoint): Likewise.
4171         (is_catchpoint): Likewise.
4172         (breakpoint_1): Make FILTER parameter's return type bool.
4173         is_masked_watchpoint): Change return type to bool.
4174         (save_breakpoints): Make FILTER parameter's return type bool.
4175         * breakpoint.h (is_breakpoint): Change return type to bool.
4176         (is_watchpoint): Likewise.
4177         (is_catchpoint): Likewise.
4178         (is_tracepoint): Likewise.
4179
4180 2019-07-10  Tom Tromey  <tom@tromey.com>
4181
4182         * defs.h: Don't include gdbarch.h.
4183         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4184         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4185         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4186         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4187         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4188         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4189         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4190         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4191         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4192         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4193         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4194         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4195         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4196         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4197         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4198         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4199         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4200         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4201         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4202         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4203         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4204         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4205         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4206         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4207         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4208         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4209         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4210
4211 2019-07-10  Tom Tromey  <tromey@adacore.com>
4212
4213         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4214         * breakpoint.c (init_ada_exception_breakpoint): Register as
4215         bp_catchpoint.
4216         (print_one_breakpoint_location, print_one_breakpoint): Use
4217         is_ada_exception_catchpoint.
4218         * ada-lang.c (class ada_catchpoint_location): Pass
4219         bp_loc_software_breakpoint to bp_location constructor.
4220         (is_ada_exception_catchpoint): New function.
4221
4222 2019-07-10  Tom Tromey  <tromey@adacore.com>
4223
4224         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4225         VEC.
4226         (struct arm_exidx_entry): New method operator<.
4227         (struct arm_exidx_data) <section_maps>: Change type.
4228         (arm_exidx_data_free): Remove.
4229         (arm_exidx_data_key): Change type.  Move lower.
4230         (arm_exidx_new_objfile): Update.
4231         (arm_compare_exidx_entries): Remove.
4232         (arm_find_exidx_entry, _initialize_arm_tdep)
4233
4234 2019-07-10  Tom Tromey  <tromey@adacore.com>
4235
4236         * solib-spu.c (ocl_program_data_key): Change type.
4237         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4238         Update.
4239
4240 2019-07-10  Tom Tromey  <tromey@adacore.com>
4241
4242         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4243         (struct solib_aix_inferior_data) <library_list>: Change type.
4244         (solib_aix_inferior_data_handle): Change type.
4245         (get_solib_aix_inferior_data): Update.
4246         (solib_aix_free_library_list): Remove.
4247         (library_list_start_library): Update.
4248         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4249         return type.
4250         (solib_aix_get_library_list)
4251         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4252         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4253
4254 2019-07-10  Tom Tromey  <tromey@adacore.com>
4255
4256         * solib-dsbt.c (struct dsbt_info): Add initializers.
4257         (solib_dsbt_pspace_data): Change type.
4258         (dsbt_pspace_data_cleanup): Remove.
4259         (get_dsbt_info, _initialize_dsbt_solib): Update.
4260
4261 2019-07-10  Tom Tromey  <tromey@adacore.com>
4262
4263         * spu-tdep.c (spu_overlay_data): Change type.
4264         (spu_get_overlay_table, spu_overlay_new_objfile)
4265         (_initialize_spu_tdep): Update.
4266
4267 2019-07-10  Tom Tromey  <tromey@adacore.com>
4268
4269         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4270         destructor.
4271         (dbx_objfile_data_key): Change type and declare later.
4272         (DBX_SYMFILE_INFO): Rewrite.
4273         * dbxread.c (dbx_objfile_data_key): Change type.
4274         (dbx_symfile_init): Update.
4275         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4276         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4277         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4278
4279 2019-07-10  Tom Tromey  <tromey@adacore.com>
4280
4281         * jit.c (jit_program_space_key): Change type.  Move lower.
4282         (get_jit_program_space_data): Update.
4283         (jit_program_space_data_cleanup): Remove.
4284         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4285         Update.
4286         (struct jit_program_space_data): Add initializers.
4287
4288 2019-07-10  Tom Tromey  <tromey@adacore.com>
4289
4290         * solib-darwin.c (struct darwin_info): Add initializers.
4291         (solib_darwin_pspace_data): Change type.
4292         (darwin_pspace_data_cleanup): Remove.
4293         (get_darwin_info, _initialize_darwin_solib): Update.
4294
4295 2019-07-10  Tom Tromey  <tromey@adacore.com>
4296
4297         * remote-sim.c (struct sim_inferior_data): Add initializers,
4298         constructor, and destructor.
4299         (sim_inferior_data_key): Change type.  Move lower.
4300         (check_for_duplicate_sim_descriptor): Update.
4301         (get_sim_inferior_data): Use new.  Update.
4302         (~sim_inferior_data_cleanup): Rename from
4303         sim_inferior_data_cleanup.  Simplify.
4304         (gdbsim_close_inferior, simulator_command)
4305         (sim_command_completer, _initialize_remote_sim): Update.
4306         (next_pid, INITIAL_PID): Move earlier.
4307
4308 2019-07-10  Tom Tromey  <tromey@adacore.com>
4309
4310         * python/python-internal.h (create_thread_object): Return
4311         gdbpy_ref.
4312         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4313         * python/py-inferior.c (struct threadlist_entry): Add
4314         constructor.
4315         <thread_obj>: Now a gdbpy_ref.
4316         (thread_to_thread_object): Update.
4317         (add_thread_object): Use new.
4318         (delete_thread_object): Use delete.
4319         (infpy_threads): Update.
4320         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4321         GIL.
4322
4323 2019-07-10  Tom Tromey  <tromey@adacore.com>
4324
4325         * valops.c (value_cast): Specialize error message for Ada.
4326
4327 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4328
4329         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4330
4331 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4332
4333         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4334         bpstat_should_step): Return bool, adjust comments.
4335         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4336         bpstat_should_step): Likewise.
4337
4338 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4339
4340         * features/Makefile: Use feature target descriptions for Arm.
4341         * features/arm/arm-core.c: Generate new file.
4342         * features/arm/arm-fpa.c: Likewise.
4343         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4344         * features/arm/arm-m-profile.c: Likewise.
4345         * features/arm/arm-vfpv2.c: Likewise.
4346         * features/arm/arm-vfpv3.c: Likewise.
4347         * features/arm/xscale-iwmmxt.c: Likewise.
4348         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4349
4350 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4351
4352         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4353         ptrace earlier.
4354
4355 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4356
4357         * features/aarch64-pauth.c: Regenerate.
4358
4359 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4360
4361         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4362         bool.
4363         (bpstat_what): Use false instead of 0.
4364
4365 2019-07-09  Pedro Alves  <palves@redhat.com>
4366
4367         * break-catch-throw.c (is_exception_catchpoint): New.
4368         * breakpoint.c (print_one_breakpoint_location): New parameter
4369         'raw_loc'.  Handle it.  Use
4370         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4371         looking at the breakpoint's type.
4372         (print_one_breakpoint): If handling "maint info breakpoints", also
4373         print locations of exception catchpoints.
4374         * breakpoint.h (is_exception_catchpoint): Declare.
4375
4376 2019-07-09  Pedro Alves  <palves@redhat.com>
4377
4378         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4379         "addr" field.
4380         (allocate_location_exception_catchpoint): New.
4381         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4382         (initialize_throw_catchpoint_ops): Install
4383         allocate_location_exception_catchpoint as allocate_location
4384         method.
4385         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4386         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4387         bp_loc_other.
4388         (breakpoint_address_is_meaningful): Delete.
4389         (bl_address_is_meaningful): New.
4390         (breakpoint_locations_match): Adjust comment.
4391         (bp_location_from_bp_type): New, factored out of...
4392         (bp_location::bp_location(breakpoint *)): ... this.
4393         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4394         factored out of...
4395         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4396         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4397         breakpoint_address_is_meaningful.
4398         (bp_locations_compare): Adjust comment.
4399         (update_global_location_list): Use bl_address_is_meaningful
4400         instead of breakpoint_address_is_meaningful.
4401         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4402         explicit.
4403         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4404         * python/py-breakpoint.c (bppy_get_location): No longer check
4405         whether location is null.
4406
4407 2019-07-09  Pedro Alves  <palves@redhat.com>
4408
4409         PR c++/15468
4410         * breakpoint.c (print_one_breakpoint_location): Remove
4411         single-location assert.
4412
4413 2019-07-09  Tom Tromey  <tom@tromey.com>
4414
4415         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4416         * configure: Rebuild.
4417         * configure.ac: Change common to gdbsupport.
4418         * gdbsupport: Rename from common.
4419         * acinclude.m4: Change common to gdbsupport.
4420         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4421         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4422         gdbsupport.
4423         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4424         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4425         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4426         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4427         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4428         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4429         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4430         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4431         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4432         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4433         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4434         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4435         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4436         coff-pe-read.c, command.h, compile/compile-c-support.c,
4437         compile/compile-c.h, compile/compile-cplus-symbols.c,
4438         compile/compile-cplus-types.c, compile/compile-cplus.h,
4439         compile/compile-loc2c.c, compile/compile.c, completer.c,
4440         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4441         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4442         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4443         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4444         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4445         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4446         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4447         features/aarch64-core.c, features/aarch64-fpu.c,
4448         features/aarch64-pauth.c, features/aarch64-sve.c,
4449         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4450         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4451         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4452         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4453         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4454         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4455         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4456         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4457         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4458         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4459         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4460         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4461         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4462         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4463         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4464         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4465         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4466         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4467         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4468         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4469         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4470         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4471         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4472         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4473         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4474         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4475         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4476         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4477         minsyms.c, mips-linux-tdep.c, namespace.h,
4478         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4479         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4480         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4481         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4482         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4483         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4484         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4485         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4486         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4487         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4488         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4489         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4490         procfs.c, producer.c, progspace.h, psymtab.h,
4491         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4492         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4493         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4494         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4495         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4496         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4497         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4498         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4499         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4500         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4501         target-memory.c, target.c, target.h, target/waitstatus.c,
4502         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4503         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4504         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4505         unittests/array-view-selftests.c,
4506         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4507         unittests/common-utils-selftests.c,
4508         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4509         unittests/format_pieces-selftests.c,
4510         unittests/function-view-selftests.c,
4511         unittests/lookup_name_info-selftests.c,
4512         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4513         unittests/mkdir-recursive-selftests.c,
4514         unittests/observable-selftests.c,
4515         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4516         unittests/parse-connection-spec-selftests.c,
4517         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4518         unittests/scoped_fd-selftests.c,
4519         unittests/scoped_mmap-selftests.c,
4520         unittests/scoped_restore-selftests.c,
4521         unittests/string_view-selftests.c, unittests/style-selftests.c,
4522         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4523         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4524         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4525         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4526         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4527         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4528
4529 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4530
4531         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4532         bool value.
4533         (decode_digits_ordinary): Set explicit_line field in sal.
4534         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4535         symtab_and_line that was set on an explicit line number in
4536         assembler code.  Do always update the recorded symtab and line if
4537         we do skip the prologue.
4538
4539 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4540
4541         * breakpoint.c (set_breakpoint_location_function): Remove
4542         explicit_loc parameter.
4543         (momentary_breakpoint_from_master): Update call to
4544         set_breakpoint_location_function.
4545         (add_location_to_breakpoint): Likewise.
4546
4547 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4548
4549         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4550         required features based on default bfd type when no specific bfd
4551         is present.
4552
4553 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4554
4555         * NEWS: Mention that GDB printf and eval commands can now print
4556         C-style and Ada-style convenience var strings without
4557         calling the inferior.
4558         * printcmd.c (printf_c_string): Locally print GDB internal var
4559         instead of transiting via the inferior.
4560         (printf_wide_c_string): Likewise.
4561
4562 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4563
4564         PR breakpoints/25011
4565         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4566
4567 2019-07-04  Tom Tromey  <tom@tromey.com>
4568
4569         PR tui/24724:
4570         * tui/tui-winsource.c (tui_clear_source_content): Update.
4571         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4572         (tui_update_breakpoint_info): Update.
4573         (tui_set_exec_info_content): Update.
4574         * tui/tui-source.c (tui_set_source_content_nil): Update.
4575         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4576         has_break.
4577         * tui/tui-data.h (enum tui_bp_flag): New.
4578         (tui_bp_flags): New enum flags type.
4579         (struct tui_source_element) <break_mode>: Change type.  Rename
4580         from has_break.
4581         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4582         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4583         constants.
4584         * tui/tui-winsource.h: Fix comment.
4585
4586 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4587
4588         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4589         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4590         (store_fpregs_to_thread)
4591         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4592         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4593         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4594         (IWMMXT_REGS_SIZE): Add define.
4595         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4596         (fetch_vfp_regs, store_vfp_regs)
4597         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4598         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4599
4600 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4601
4602         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4603         defines.
4604         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4605         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4606         (ARM_INT_REGISTER_SIZE): ...to this.
4607         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4608         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4609         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4610         (arm_linux_collect_gregset, supply_nwfpe_register)
4611         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4612         defines.
4613         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4614         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4615         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4616         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4617         (arm_return_in_memory, arm_store_return_value)
4618         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4619         (arm_record_ld_st_multiple): Likewise.
4620         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4621         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4622
4623 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4624
4625         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4626         AARCH64_DISPLACED_MODIFIED_INSNS.
4627         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4628         (aarch64_displaced_step_copy_insn): Likewise.
4629         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4630         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4631         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4632         ARM_DISPLACED_MODIFIED_INSNS.
4633         * arm-tdep.c (arm_gdbarch_init): Likewise.
4634         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4635         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4636         (struct arm_displaced_step_closure): Use
4637         ARM_DISPLACED_MODIFIED_INSNS.
4638
4639 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4640
4641         * features/Makefile: Remove unused xml files.
4642         * features/aarch64.xml: Remove.
4643         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4644         * features/i386/amd64-avx-avx512.xml: Remove.
4645         * features/i386/amd64-avx-linux.xml: Remove.
4646         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4647         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4648         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4649         * features/i386/amd64-avx-mpx.xml: Remove.
4650         * features/i386/amd64-avx.xml: Remove.
4651         * features/i386/amd64-linux.xml: Remove.
4652         * features/i386/amd64-mpx-linux.xml: Remove.
4653         * features/i386/amd64-mpx.xml: Remove.
4654         * features/i386/amd64.xml: Remove.
4655         * features/i386/i386-avx-avx512-linux.xml: Remove.
4656         * features/i386/i386-avx-avx512.xml: Remove.
4657         * features/i386/i386-avx-linux.xml: Remove.
4658         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4659         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4660         * features/i386/i386-avx-mpx-linux.xml: Remove.
4661         * features/i386/i386-avx-mpx.xml: Remove.
4662         * features/i386/i386-avx.xml: Remove.
4663         * features/i386/i386-linux.xml: Remove.
4664         * features/i386/i386-mmx-linux.xml: Remove.
4665         * features/i386/i386-mmx.xml: Remove.
4666         * features/i386/i386-mpx-linux.xml: Remove.
4667         * features/i386/i386-mpx.xml: Remove.
4668         * features/i386/i386.xml: Remove.
4669         * features/i386/x32-avx-avx512-linux.xml: Remove.
4670         * features/i386/x32-avx-linux.xml: Remove.
4671         * features/i386/x32-linux.xml: Remove.
4672
4673 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4674
4675         * regformats/aarch64.dat: Remove.
4676         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4677         * regformats/i386/amd64-avx-linux.dat: Remove.
4678         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4679         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4680         * regformats/i386/amd64-linux.dat: Remove.
4681         * regformats/i386/amd64-mpx-linux.dat: Remove.
4682         * regformats/i386/amd64.dat: Remove.
4683         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4684         * regformats/i386/i386-avx-linux.dat: Remove.
4685         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4686         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4687         * regformats/i386/i386-linux.dat: Remove.
4688         * regformats/i386/i386-mmx-linux.dat: Remove.
4689         * regformats/i386/i386-mpx-linux.dat: Remove.
4690         * regformats/i386/i386.dat: Remove.
4691         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4692         * regformats/i386/x32-avx-linux.dat: Remove.
4693         * regformats/i386/x32-linux.dat: Remove.
4694
4695 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4696
4697         * aarch64-tdep.c: Remove xml self tests.
4698         * amd64-linux-tdep.c: Likewise.
4699         * amd64-tdep.c: Likewise.
4700         * i386-linux-tdep.c: Likewise.
4701         * i386-tdep.c: Likewise.
4702
4703 2019-07-03  Pedro Alves  <palves@redhat.com>
4704
4705         PR cli/24732
4706         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4707         (pipe_cmd_option_defs): New.
4708         (make_pipe_cmd_options_def_group): New.
4709         (pipe_command): Use gdb::option::process_options.
4710         (pipe_command_completer): New function.
4711         (_initialize_cli_cmds): Install completer for "pipe" command.
4712
4713 2019-07-03  Pedro Alves  <palves@redhat.com>
4714
4715         * cli/cli-option.c (union option_value) <string>: New field.
4716         (struct option_def_and_value): Add ctor, move ctor, dtor and
4717         use DISABLE_COPY_AND_ASSIGN.
4718         (option_def_and_value::clear_value): New.
4719         (parse_option, save_option_value_in_ctx, get_val_type_str)
4720         (add_setshow_cmds_for_options): Handle var_string.
4721         * cli-option.h (union option_def::var_address) <string>: New
4722         field.
4723         (struct string_option_def): New.
4724         * maint-test-options.c (struct test_options_opts): Add default
4725         ctor and use DISABLE_COPY_AND_ASSIGN.
4726         <string_opt>: New field.
4727         (test_options_opts::~test_options_opts): New.
4728         (test_options_opts::dump): Also dump "-string".
4729         (test_options_option_defs): Install "string.
4730
4731 2019-07-03  Pedro Alves  <palves@redhat.com>
4732
4733         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4734         option_value with a null enumeration.
4735         (complete_options): Save the option values in the context.
4736         (save_option_value_in_ctx): New, factored out from ...
4737         (process_options): ... here.
4738         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4739         of the function.
4740         * maint-test-options.c (test_options_opts::dump): New, factored
4741         out from ...
4742         (maintenance_test_options_command_mode): ... here.
4743         (maintenance_test_options_command_completion_result): Delete.
4744         (maintenance_test_options_command_completion_text): Update
4745         comment.
4746         (maintenance_show_test_options_completion_result): Change
4747         prototype.  Just print
4748         maintenance_test_options_command_completion_text.
4749         (save_completion_result): New.
4750         (maintenance_test_options_completer_mode): Pass options context to
4751         complete_options, and then save a dump.
4752         (_initialize_maint_test_options): Use add_cmd to install "maint
4753         show test-options-completion-result".
4754
4755 2019-07-03  Pedro Alves  <palves@redhat.com>
4756
4757         * NEWS (New commands): Mention "with" and "maint with".
4758         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4759         (with_command, with_command_completer): New.
4760         (pipe_command): Adjust to new repeat_previous
4761         interface.
4762         (_initialize_cli_cmds): Install the "with" command and its "w"
4763         alias.
4764         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4765         declarations.
4766         * cli/cli-setshow.c (parse_cli_var_uinteger)
4767         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4768         argument strings for all var_types.
4769         (get_setshow_command_value_string): New, factored out from ...
4770         (do_show_command): ... this.
4771         * cli/cli-setshow.h: Include <string>.
4772         (get_setshow_command_value_string): Declare.
4773         * command.h (repeat_previous): Now returns const char *.  Adjust
4774         comment.
4775         * maint.c: Include "cli/cli-cmds.h".
4776         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4777         (_initialize_maint_cmds): Register the "maintenance with" command.
4778         * top.c (repeat_previous): Move bits from pipe_command here:
4779         Return the saved command line, if any; error out if there's no
4780         command to relaunch.
4781
4782 2019-07-03  Pedro Alves  <palves@redhat.com>
4783
4784         * NEWS (New commands): Mention "maint set/show test-settings"
4785         instead of "maint test-settings".
4786         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4787         (maintenance_test_settings_set_list): Rename to ...
4788         (maintenance_set_test_settings_list): ... this.
4789         (maintenance_test_settings_show_list): Rename to  ...
4790         (maintenance_show_test_settings_list): ... this.
4791         (maintenance_test_settings_cmd): Delete.
4792         (maintenance_test_settings_set_cmd): ...
4793         (maintenance_set_test_settings_cmd): ... this.
4794         (maintenance_test_settings_show_cmd): ...
4795         (maintenance_show_test_settings_cmd): ... this.
4796         (maintenance_test_settings_show_value_cmd):
4797         (maintenance_show_test_settings_value_cmd): ... this.
4798         (_initialize_maint_test_settings): No longer install the "maint
4799         test-settings" prefix command.  Rename "maint test-settings set"
4800         to "maint set test-settings", and "maint test-settings show" to
4801         "maint show test-settings".  Adjust all subcommands.
4802
4803 2019-07-03  Pedro Alves  <palves@redhat.com>
4804
4805         * maint-test-settings.c: Fix file's intro comment.  Replace all
4806         references to "test-options" with references to "test-settings",
4807         in comments.
4808
4809 2019-07-03  Pedro Alves  <palves@redhat.com>
4810
4811         * maint-test-settings.c (maintenance_test_settings_xxx)
4812         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4813         New.
4814         (maintenance_test_settings_enums): Use them.
4815         (maintenance_test_settings_enum): Default to
4816         maintenance_test_settings_xxx.
4817         (_initialize_maint_test_settings): Initialize
4818         MAINTENANCE_TEST_SETTINGS_FILENAME.
4819
4820 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4821
4822         * breakpoint.h (remove_breakpoints_inf): Change return type to
4823         void, move function documentation here.
4824         * breakpoint.c (remove_breakpoints_inf): Change return type to
4825         void, move function documentation to header.
4826
4827 2019-07-02  Pedro Alves  <palves@redhat.com>
4828
4829         * NEWS (Completion improvements): Mention "info threads".
4830         * thread.c (struct info_threads_opts, info_threads_option_defs)
4831         (make_info_threads_options_def_group): New.
4832         (info_threads_command): Use gdb::option::process_options.
4833         (info_threads_command_completer): New.
4834         (_initialize_thread): Use gdb::option::build_help to build the
4835         help text for "info threads".
4836
4837 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4838
4839         * defs.h (generic_load): Move from here...
4840         * symfile.h (generic_load): ... to here.  Rename name parameter
4841         to args.
4842         * symfile.c (generic_load): Add comment.
4843
4844 2019-07-01  Tom Tromey  <tromey@adacore.com>
4845
4846         * dwarf2read.c
4847         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4848         declaration of without_params.  Fix formatting.
4849
4850 2019-07-01  Tom Tromey  <tromey@adacore.com>
4851
4852         * ada-exp.y (find_primitive_type): Update.
4853         * ada-lang.h (ada_lookup_symbol): Update.
4854         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4855         parameter.
4856         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4857
4858 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4859
4860         PR breakpoints/24541
4861         * gdbarch.c: Regenerate.
4862         * gdbarch.h: Regenerate.
4863         * gdbarch.sh: Add 'stap_adjust_register'.
4864         * i386-tdep.c: Include '<unordered_set>'.
4865         (i386_stap_adjust_register): New function.
4866         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4867         * stap-probe.c (stap_parse_register_operand): Call
4868         'gdbarch_stap_adjust_register'.
4869
4870 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4871
4872         PR python/24742
4873         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4874         * python/python.c (do_start_initialization): Use 'xmalloc'
4875         instead of 'PyMem_Malloc'.
4876
4877 2019-06-28  Tom Tromey  <tromey@adacore.com>
4878
4879         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4880         for Ada.
4881
4882 2019-06-27  Tom Tromey  <tromey@adacore.com>
4883
4884         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4885         objfile_key.
4886         (arm_find_mapping_symbol, arm_record_special_symbol)
4887         (_initialize_arm_tdep): Update.
4888         (arm_objfile_data_free): Remove.
4889
4890 2019-06-27  Tom Tromey  <tromey@adacore.com>
4891
4892         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4893         to cp_print_static_field.
4894
4895 2019-06-26  Tom Tromey  <tromey@adacore.com>
4896
4897         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4898         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4899         declare.
4900
4901 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4902
4903         * features/aarch64-core.c (create_feature_aarch64_core):
4904         Regenerate.
4905         * features/aarch64-core.xml: Add cpsr flags.
4906
4907 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4908
4909         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4910         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4911
4912 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4913
4914         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4915         field.
4916         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4917         use.
4918         (arm_record_special_symbol): Don't insert new symbol in sorted
4919         position, push it at the end.
4920
4921 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4922
4923         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4924         (arm_mapping_symbol_s): Remove.
4925         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4926         (arm_mapping_symbol_vec): New typedef.
4927         (struct arm_per_objfile): Add constructor.
4928         <section_maps>: Change type to
4929         std::unique_ptr<arm_mapping_symbol_vec[]>.
4930         (arm_compare_mapping_symbols): Remove.
4931         (arm_find_mapping_symbol): Adjust to section_maps type change.
4932         (arm_objfile_data_free): Call delete on arm_per_objfile.
4933         (arm_record_special_symbol): Adjust to section_maps type change.
4934         Allocate arm_per_objfile with new.
4935
4936 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4937
4938         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4939         with the command prefix.
4940
4941 2019-06-25  Tom Tromey  <tom@tromey.com>
4942
4943         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4944         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4945
4946 2019-06-25  Tom Tromey  <tom@tromey.com>
4947
4948         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4949         type.
4950         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4951         protected.
4952
4953 2019-06-25  Tom Tromey  <tom@tromey.com>
4954
4955         * tui/tui-winsource.c
4956         (tui_source_window_base::set_is_exec_point_at): Add check against
4957         LOA_ADDRESS.
4958
4959 2019-06-25  Tom Tromey  <tom@tromey.com>
4960
4961         * tui/tui-source.c (tui_set_source_content): Don't check before
4962         xfree.
4963         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4964
4965 2019-06-25  Tom Tromey  <tom@tromey.com>
4966
4967         * tui/tui-winsource.h (tui_update_source_window_as_is)
4968         (tui_alloc_source_buffer, tui_line_is_displayed)
4969         (tui_addr_is_displayed): Change type of win_info.
4970         * tui/tui-winsource.c (tui_update_source_window_as_is)
4971         (tui_clear_source_content, tui_show_source_line)
4972         (tui_show_source_content, tui_source_window_base::refill)
4973         (tui_source_window_base::set_is_exec_point_at)
4974         (tui_source_window_base::set_is_exec_point_at)
4975         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4976         (tui_alloc_source_buffer, tui_line_is_displayed)
4977         (tui_addr_is_displayed): Change type of win_info.  Update.
4978         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4979         (tui_source_window_base::do_make_visible_with_new_height):
4980         Update.
4981         * tui/tui-source.c (tui_set_source_content)
4982         (tui_set_source_content_nil)
4983         (tui_source_window::do_scroll_vertical): Update.
4984         * tui/tui-layout.c (show_layout): Update.
4985         * tui/tui-disasm.c (tui_set_disassem_content)
4986         (tui_disasm_window::do_scroll_vertical): Update.
4987         * tui/tui-data.h (tui_win_content): Remove.
4988         (struct tui_gen_win_info) <content, content_size>: Remove.
4989         (struct tui_source_element): Add initializers and destructor.
4990         (union tui_which_element, struct tui_win_element): Remove.
4991         (struct tui_source_window_base) <content>: New field.
4992         (struct tui_data_window): Remove destructor.
4993         (tui_alloc_content, tui_free_win_content)
4994         (tui_free_all_source_wins_content): Don't declare.
4995         * tui/tui-data.c (tui_initialize_static_data): Update.
4996         (init_content_element, tui_alloc_content): Remove.
4997         (~tui_gen_win_info): Update.
4998         (~tui_data_window, tui_free_all_source_wins_content)
4999         (tui_free_win_content, free_content, free_content_elements):
5000         Remove.
5001
5002 2019-06-25  Tom Tromey  <tom@tromey.com>
5003
5004         * tui/tui-winsource.h (tui_clear_source_content)
5005         (tui_erase_source_content, tui_show_source_content): Change type
5006         of win_info.
5007         * tui/tui-winsource.c (tui_clear_source_content)
5008         (tui_erase_source_content, tui_show_source_content): Change type
5009         of win_info.
5010         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5011         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5012         win_info.
5013         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5014         win_info.
5015         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5016
5017 2019-06-25  Tom Tromey  <tom@tromey.com>
5018
5019         * tui/tui-winsource.c (tui_clear_source_content)
5020         (tui_source_window_base::set_is_exec_point_at): Update.
5021         * tui/tui-source.c (tui_set_source_content_nil): Update.
5022         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5023         a bool.
5024         * tui/tui-data.c (init_content_element): Update.
5025
5026 2019-06-25  Tom Tromey  <tom@tromey.com>
5027
5028         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5029         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5030         * tui/tui-layout.c (init_and_make_win): Update.
5031         * tui/tui.h (enum tui_win_type): Update.
5032         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5033         tui_win_is_auxillary.
5034         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5035         tui_win_is_auxillary.
5036
5037 2019-06-25  Tom Tromey  <tom@tromey.com>
5038
5039         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5040         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5041         (tui_delete_data_content_windows, tui_display_all_data)
5042         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5043         Update.
5044         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5045         * tui/tui-regs.c (tui_last_regs_line_no)
5046         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5047         (tui_show_registers): Update.
5048         (tui_show_register_group): Return void.  Update.
5049         (tui_display_registers_from, tui_display_reg_element_at_line)
5050         (tui_display_registers_from_line, tui_check_register_values):
5051         Update.
5052         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5053         member.
5054         (struct tui_data_window) <regs_content>: Now a std::vector.
5055         <regs_content_count>: Remove.
5056         (tui_add_content_elements, tui_free_data_content): Don't declare.
5057         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5058         (init_content_element): Remove DATA_WIN case.  Add assert.
5059         (tui_add_content_elements): Remove.
5060         (tui_data_window): Update.
5061         (tui_free_data_content): Remove.
5062         (free_content_elements): Remove DATA_WIN case.
5063
5064 2019-06-25  Tom Tromey  <tom@tromey.com>
5065
5066         * tui/tui-data.c (tui_data_item_window): Update.
5067         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5068         * tui/tui-windata.c (tui_display_all_data)
5069         (tui_display_data_from_line): Update.
5070         (tui_check_data_values): Remove.
5071         * tui/tui-regs.c (tui_show_register_group)
5072         (tui_display_reg_element_at_line): Update.
5073         * tui/tui-hooks.c (tui_register_changed)
5074         (tui_refresh_frame_and_register_information): Call
5075         tui_check_register_values.
5076         * tui/tui-data.h (struct tui_data_window) <data_content,
5077         data_content_count, data_type>: Remove.
5078         (enum tui_data_type): Remove.
5079
5080         * tui/tui-data.c (tui_data_window::clear_detail)
5081         (~tui_data_window): Update.
5082
5083 2019-06-25  Tom Tromey  <tom@tromey.com>
5084
5085         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5086         declare.
5087         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5088         Rename from tui_first_data_item_displayed.  Update.
5089         (tui_data_window::refresh_all)
5090         (tui_data_window::do_scroll_vertical): Update.
5091         * tui/tui-data.h (struct tui_data_window)
5092         <first_data_item_displayed>: Declare new method.
5093
5094 2019-06-25  Tom Tromey  <tom@tromey.com>
5095
5096         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5097         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5098         contents...
5099         (tui_initialize_static_data): ...here.
5100
5101 2019-06-25  Tom Tromey  <tom@tromey.com>
5102
5103         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5104         (tui_display_registers_from, tui_check_register_values): Update.
5105         (tui_display_register): Remove win_info parameter; update.
5106         (tui_get_register): Change type of parameters.
5107         * tui/tui-data.h (struct tui_data_element): Remove.
5108         (union tui_which_element) <data>: Remove.
5109         <data_window>: Change type.
5110         (struct tui_data_item_window): New.
5111         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5112         case.  Add assert.
5113         (~tui_data_item_window): New destructor.
5114         (free_content_elements): Remove DATA_ITEM_WIN case.
5115
5116 2019-06-25  Tom Tromey  <tom@tromey.com>
5117
5118         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5119         Remove.
5120
5121 2019-06-25  Tom Tromey  <tom@tromey.com>
5122
5123         * tui/tui-data.h (struct tui_command_element): Remove.
5124         (union tui_which_element) <command>: Remove.
5125         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5126         assert.
5127         (free_content_elements): Remove CMD_WIN case.
5128
5129 2019-06-25  Tom Tromey  <tom@tromey.com>
5130
5131         * tui/tui-layout.c (tui_set_layout): Update.
5132         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5133         * tui/tui-data.c (layout_def): Update.
5134
5135 2019-06-25  Tom Tromey  <tom@tromey.com>
5136
5137         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5138         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5139         (tui_source_window_base::set_new_height): Update.
5140         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5141         Update.
5142         (tui_set_locator_fullname, tui_set_locator_info)
5143         (tui_show_frame_info): Update.
5144         * tui/tui-source.c (tui_set_source_content)
5145         (tui_source_is_displayed): Update.
5146         * tui/tui-layout.c (show_source_disasm_command, show_data)
5147         (show_source_or_disasm_and_command): Update.
5148         * tui/tui-disasm.c (tui_set_disassem_content)
5149         (tui_get_begin_asm_address): Update.
5150         * tui/tui-data.h (struct tui_locator_element): Remove.
5151         (union tui_which_element) <locator>: Remove.
5152         (struct tui_locator_window): New.
5153         (tui_locator_win_info_ptr): Change return type.
5154         * tui/tui-data.c (_locator): Change type.
5155         (tui_locator_win_info_ptr): Change return type.
5156         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5157         (tui_alloc_content): Add assert.
5158
5159 2019-06-25  Tom Tromey  <tom@tromey.com>
5160
5161         * tui/tui-winsource.c
5162         (tui_exec_info_window::maybe_allocate_content): New method.
5163         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5164         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5165         (make_source_or_disasm_window): Add cast.
5166         * tui/tui-data.h (union tui_which_element) <simple_string>:
5167         Remove.
5168         (struct tui_source_info): New.
5169         (struct tui_source_window_base) <execution_info>: Change type.
5170         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5171         case, and add assert.
5172         (tui_alloc_content): Add assert.
5173
5174 2019-06-25  Tom Tromey  <tom@tromey.com>
5175
5176         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5177         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5178         * tui/tui-data.c (tui_alloc_win_info): Remove.
5179
5180 2019-06-25  Tom Tromey  <tom@tromey.com>
5181
5182         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5183         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5184         can_highlight.
5185
5186 2019-06-25  Tom Tromey  <tom@tromey.com>
5187
5188         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5189         make_visible_with_new_height method.
5190         (tui_win_info::make_visible_with_new_height): New method.
5191         (tui_source_window_base::do_make_visible_with_new_height)
5192         (tui_data_window::do_make_visible_with_new_height)
5193         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5194         (make_visible_with_new_height): Remove.
5195         (tui_resize_all, tui_adjust_win_heights): Use
5196         make_visible_with_new_height method.
5197         * tui/tui-data.h (struct tui_win_info)
5198         <do_make_visible_with_new_height, make_visible_with_new_height>:
5199         New methods.
5200         (struct tui_source_window_base, struct tui_data_window)
5201         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5202         methods.
5203
5204 2019-06-25  Tom Tromey  <tom@tromey.com>
5205
5206         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5207         method.
5208         (update_tab_width): Call update_tab_width method.
5209         * tui/tui-data.h (struct tui_win_info)
5210         (struct tui_source_window_base) <update_tab_width>: New methods.
5211
5212 2019-06-25  Tom Tromey  <tom@tromey.com>
5213
5214         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5215         parameter.
5216         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5217         parameter.
5218         (tui_gen_win_info::make_visible): Update.
5219         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5220         parameter.
5221         * tui/tui-data.h (enum tui_box): New enum.
5222         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5223
5224 2019-06-25  Tom Tromey  <tom@tromey.com>
5225
5226         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5227         init_and_make_win for EXEC_INFO_WIN.
5228         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5229         longer inline.
5230         (struct tui_win_info) <~tui_win_info>: Inline.
5231         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5232         Don't declare.
5233         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5234         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5235         Remove.
5236         (tui_initialize_static_data): Update.
5237         (~tui_gen_win_info): Handle more cleanup here.
5238         (~tui_source_window_base): Delete "execution_info".
5239         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5240
5241 2019-06-25  Tom Tromey  <tom@tromey.com>
5242
5243         * tui/tui-layout.c (make_command_window): Don't set
5244         can_highlight.
5245         (show_source_disasm_command): Call the reset method.
5246         (show_data): Don't set can_highlight.  Call the reset method.
5247         (tui_gen_win_info::reset): Rename from init_gen_win_info
5248         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5249         (show_source_or_disasm_and_command): Call the reset method.
5250         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5251         (struct tui_cmd_window): Set can_highlight.
5252
5253 2019-06-25  Tom Tromey  <tom@tromey.com>
5254
5255         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5256         from make_visible.
5257         (tui_make_visible, tui_make_invisible): Rewrite.
5258         (tui_win_info::make_visible): Remove.
5259         (tui_source_window_base::make_visible): Update.
5260         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5261         method.  Moved from...
5262         (struct tui_win_info) <make_visible>: ...here.
5263
5264 2019-06-25  Tom Tromey  <tom@tromey.com>
5265
5266         * tui/tui-winsource.c
5267         (tui_source_window_base::do_scroll_horizontal): Remove direction
5268         parameter.
5269         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5270         direction parameter.
5271         * tui/tui-win.c (tui_win_info::forward_scroll)
5272         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5273         (tui_win_info::right_scroll): Update.
5274         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5275         direction parameter.
5276         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5277         direction parameter.
5278         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5279         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5280         Remove direction parameter.
5281         (struct tui_source_window_base, struct tui_source_window)
5282         (struct tui_disasm_window, struct tui_data_window)
5283         (struct tui_cmd_window): Update.
5284
5285 2019-06-25  Tom Tromey  <tom@tromey.com>
5286
5287         * tui/tui-winsource.h (tui_set_exec_info_content)
5288         (tui_show_exec_info_content, tui_erase_exec_info_content)
5289         (tui_clear_exec_info_content, tui_update_exec_info): Change
5290         argument to tui_source_window_base.
5291         * tui/tui-winsource.c (tui_set_exec_info_content)
5292         (tui_show_exec_info_content, tui_erase_exec_info_content)
5293         (tui_clear_exec_info_content, tui_update_exec_info): Change
5294         argument to tui_source_window_base.
5295
5296 2019-06-25  Tom Tromey  <tom@tromey.com>
5297
5298         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5299         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5300
5301 2019-06-25  Tom Tromey  <tom@tromey.com>
5302
5303         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5304         check.
5305
5306 2019-06-25  Tom Tromey  <tom@tromey.com>
5307
5308         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5309         type to void.
5310         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5311         type to void.
5312         * tui/tui-source.c (tui_set_source_content): Update.
5313         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5314
5315 2019-06-25  Tom Tromey  <tom@tromey.com>
5316
5317         * tui/tui-win.c (window_name_completer, tui_set_focus)
5318         (tui_all_windows_info): Use name method.
5319         * tui/tui-data.h (struct tui_gen_win_info)
5320         (struct tui_source_window, struct tui_disasm_window)
5321         (struct tui_data_window, struct tui_cmd_window) <name>: New
5322         method.
5323         (tui_win_name): Don't declare.
5324         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5325         (tui_win_name): Remove.
5326
5327 2019-06-25  Tom Tromey  <tom@tromey.com>
5328
5329         * tui/tui-winsource.h (tui_update_source_window)
5330         (tui_update_source_window_as_is): Change parameter type.
5331         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5332         to be a tui_source_window_base.
5333         (tui_update_source_window_as_is): Likewise.
5334         * tui/tui-win.c (make_visible_with_new_height): Update.
5335
5336 2019-06-25  Tom Tromey  <tom@tromey.com>
5337
5338         * tui/tui-winsource.c (tui_erase_source_content)
5339         (tui_show_source_content, tui_show_exec_info_content)
5340         (tui_erase_exec_info_content): Use refresh_window method.
5341         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5342         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5343         from tui_refresh_win.
5344         (tui_data_window::refresh_window): New method.
5345         (tui_win_info::refresh, tui_source_window_base::refresh)
5346         (tui_refresh_all): Use refresh_window method.
5347         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5348         method.
5349         * tui/tui-regs.c (tui_display_register): Call refresh_window
5350         method.
5351         * tui/tui-layout.c (show_source_disasm_command)
5352         (show_source_or_disasm_and_command): Call refresh_window method.
5353         * tui/tui-data.h (struct tui_gen_win_info)
5354         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5355         New method.
5356
5357 2019-06-25  Tom Tromey  <tom@tromey.com>
5358
5359         * tui/tui.c (tui_rl_other_window, tui_enable)
5360         (tui_is_window_visible, tui_get_command_dimension): Update.
5361         * tui/tui-winsource.c (tui_update_source_window_as_is)
5362         (tui_clear_source_content, tui_erase_source_content)
5363         (tui_show_source_line, tui_source_window_base::refill)
5364         (tui_source_window_base::do_scroll_horizontal)
5365         (tui_source_window_base::set_is_exec_point_at)
5366         (tui_update_breakpoint_info, tui_set_exec_info_content)
5367         (tui_alloc_source_buffer, tui_line_is_displayed)
5368         (tui_addr_is_displayed): Update.
5369         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5370         (tui_check_and_display_highlight_if_needed)
5371         (tui_win_info::make_visible, tui_win_info::refresh)
5372         (tui_refresh_all): Update.
5373         * tui/tui-windata.c (tui_first_data_item_displayed)
5374         (tui_delete_data_content_windows, tui_erase_data_content)
5375         (tui_display_all_data, tui_data_window::refresh_all)
5376         (tui_check_data_values): Update.
5377         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5378         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5379         (tui_win_info::backward_scroll, tui_refresh_all_win)
5380         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5381         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5382         (tui_source_window_base::set_new_height)
5383         (tui_data_window::set_new_height)
5384         (make_invisible_and_set_new_height)
5385         (make_visible_with_new_height, new_height_ok)
5386         (parse_scrolling_args): Update.
5387         * tui/tui-stack.c (tui_show_frame_info): Update.
5388         * tui/tui-source.c (tui_set_source_content)
5389         (tui_set_source_content_nil, tui_source_is_displayed)
5390         (tui_source_window::do_scroll_vertical): Update.
5391         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5392         (tui_display_registers_from, tui_display_reg_element_at_line)
5393         (tui_check_register_values, tui_reg_command): Update.
5394         * tui/tui-layout.c (tui_default_win_height)
5395         (show_source_disasm_command, show_data, init_and_make_win)
5396         (show_source_or_disasm_and_command): Update.
5397         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5398         (tui_redisplay_readline, tui_mld_flush)
5399         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5400         (tui_getc): Update.
5401         * tui/tui-disasm.c (tui_set_disassem_content)
5402         (tui_disasm_window::do_scroll_vertical): Update.
5403         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5404         Now virtual.
5405         (struct tui_win_info): Derive from tui_gen_win_info.
5406         <~tui_win_info>: Mark as override.
5407         <generic>: Remove member.
5408         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5409         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5410         (~tui_data_window, ~tui_win_info)
5411         (tui_free_all_source_wins_content): Update.
5412         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5413
5414 2019-06-25  Tom Tromey  <tom@tromey.com>
5415
5416         * tui/tui-layout.c (init_and_make_win): Use new.
5417         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5418         destructor, initializers.
5419         (tui_alloc_generic_win_info): Don't declare.
5420         * tui/tui-data.c (_locator): Add argument to constructor.
5421         (source_win, disasm_win): New globals.
5422         (exec_info): Remove.
5423         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5424         Update.
5425         (tui_alloc_generic_win_info): Remove.
5426         (init_content_element): Use new.
5427         (tui_win_info::tui_win_info): Update.
5428         (free_content_elements) <case DATA_WIN>: Use delete.
5429
5430 2019-06-25  Tom Tromey  <tom@tromey.com>
5431
5432         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5433         * tui/tui-windata.c (tui_first_data_item_displayed)
5434         (tui_delete_data_content_windows): Update.
5435         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5436         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5437         (tui_display_registers_from, tui_check_register_values): Update.
5438         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5439         pointer.
5440         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5441         window.
5442         (tui_free_data_content): Update.
5443         (free_content_elements) <case DATA_WIN>: Free the window.
5444
5445 2019-06-25  Tom Tromey  <tom@tromey.com>
5446
5447         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5448         Update.
5449         * tui/tui-layout.c (make_command_window)
5450         (show_source_disasm_command, show_data, init_and_make_win)
5451         (show_source_or_disasm_and_command): Update.
5452         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5453         method.
5454         <can_highight, is_highlighted>: Now bool.
5455         (tui_set_win_highlight): Don't declare.
5456         * tui/tui-data.c (tui_set_win_highlight): Remove.
5457
5458 2019-06-25  Tom Tromey  <tom@tromey.com>
5459
5460         * tui/tui-wingeneral.c (make_visible): Remove check of window
5461         type.
5462
5463 2019-06-25  Tom Tromey  <tom@tromey.com>
5464
5465         * tui/tui-win.c (tui_win_info::max_height)
5466         (tui_cmd_window::max_height): New methods.
5467         (new_height_ok): Call max_height.
5468         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5469         <max_height>: New method.
5470
5471 2019-06-25  Tom Tromey  <tom@tromey.com>
5472
5473         * tui/tui-win.c (tui_source_window_base::set_new_height)
5474         (tui_data_window::set_new_height): New methods.
5475         (make_invisible_and_set_new_height): Call set_new_height method.
5476         * tui/tui-data.h (struct tui_win_info)
5477         (struct tui_source_window_base, struct tui_data_window)
5478         <set_new_height>: New method.
5479
5480 2019-06-25  Tom Tromey  <tom@tromey.com>
5481
5482         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5483         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5484         tui_refresh_data_win.
5485         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5486         method.
5487         (tui_refresh_all_win): Call the refresh_all method.
5488         (tui_set_focus): Likewise.
5489         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5490         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5491         Likewise.
5492
5493 2019-06-25  Tom Tromey  <tom@tromey.com>
5494
5495         * tui/tui-winsource.h (tui_refill_source_window)
5496         (tui_set_is_exec_point_at): Don't declare.
5497         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5498         (tui_source_window_base::refill): Rename from
5499         tui_refill_source_window.
5500         (tui_source_window_base::do_scroll_horizontal): Update.
5501         (tui_source_window_base::set_is_exec_point_at): Rename from
5502         tui_set_is_exec_point_at.
5503         (tui_update_all_breakpoint_info): Update.
5504         * tui/tui-stack.c (tui_show_frame_info): Update.
5505         * tui/tui-layout.c (show_data): Add cast.
5506         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5507         * tui/tui-data.h (struct tui_source_window_base) <refill,
5508         set_is_exec_point_at>: New methods.
5509         (tui_source_windows, tui_add_to_source_windows): Update types.
5510         (tui_add_to_source_windows): Remove redundant declaration.
5511         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5512         (tui_source_windows): Change return type.
5513         (tui_clear_source_windows_detail): Update.
5514         (tui_add_to_source_windows): Change type of parameter.
5515         (tui_free_all_source_wins_content): Update.
5516
5517 2019-06-25  Tom Tromey  <tom@tromey.com>
5518
5519         * tui/tui-wingeneral.c (tui_win_info::refresh)
5520         (tui_source_window_base::refresh): New methods.
5521         (tui_refresh_all): Call the refresh method.
5522         * tui/tui-data.h (struct tui_win_info)
5523         (struct tui_source_window_base) <refresh>: New method.
5524
5525 2019-06-25  Tom Tromey  <tom@tromey.com>
5526
5527         * tui/tui.h (tui_is_window_visible): Return bool.
5528         * tui/tui.c (tui_is_window_visible): Return bool.
5529         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5530         (tui_make_visible, tui_make_invisible)
5531         (tui_win_info::make_visible)
5532         (tui_source_window_base::make_visible, make_all_visible)
5533         (tui_make_all_visible, tui_make_all_invisible): Update.
5534         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5535         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5536         bool.
5537         (struct tui_win_info, struct tui_source_window_base)
5538         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5539         * tui/tui-data.c (tui_init_generic_part): Update.
5540
5541 2019-06-25  Tom Tromey  <tom@tromey.com>
5542
5543         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5544         (tui_source_window_base::make_visible): New methods.
5545         (make_all_visible): Make method call.
5546         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5547         (struct tui_source_window_base, struct tui_cmd_window): Override
5548         make_visible.
5549         (tui_win_is_source_type): Don't declare.
5550         * tui/tui-data.c (tui_win_is_source_type): Remove.
5551
5552 2019-06-25  Tom Tromey  <tom@tromey.com>
5553
5554         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5555         NULL check.
5556
5557 2019-06-25  Tom Tromey  <tom@tromey.com>
5558
5559         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5560         Inline constructor.  Add initializers for members.
5561         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5562         constructors; now inline in class.
5563
5564 2019-06-25  Tom Tromey  <tom@tromey.com>
5565
5566         * tui/tui-regs.c (tui_show_registers): Update.
5567         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5568         bool.
5569         * tui/tui-data.c (tui_data_window::clear_detail)
5570         (tui_data_window): Update.
5571
5572 2019-06-25  Tom Tromey  <tom@tromey.com>
5573
5574         * tui/tui-windata.c (tui_display_all_data)
5575         (tui_display_data_from_line, tui_display_data_from)
5576         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5577         Update.
5578         * tui/tui-regs.c (tui_last_regs_line_no)
5579         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5580         (tui_show_registers, tui_show_register_group)
5581         (tui_display_registers_from, tui_display_reg_element_at_line)
5582         (tui_display_registers_from_line, tui_check_register_values)
5583         (tui_reg_next, tui_reg_prev): Update.
5584         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5585         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5586         tui_data_window.
5587         (struct tui_win_info) <detail>: Remove.  Add new fields from
5588         tui_data_info.
5589         (TUI_DATA_WIN): Add cast.
5590         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5591         (~tui_data_window): Simplify.
5592
5593 2019-06-25  Tom Tromey  <tom@tromey.com>
5594
5595         * tui/tui-layout.c (show_source_disasm_command)
5596         (show_source_or_disasm_and_command): Update.
5597         * tui/tui-io.c (update_cmdwin_start_line)
5598         (tui_redisplay_readline): Update.
5599         * tui/tui-data.h (struct tui_command_info): Remove.
5600         (struct tui_win_info) <detail>: Remove command_info member.
5601         (struct tui_data_window) <start_line>: New member, from
5602         tui_command_info.
5603         (TUI_CMD_WIN): Add casts.
5604
5605 2019-06-25  Tom Tromey  <tom@tromey.com>
5606
5607         * tui/tui-winsource.c (tui_update_source_window)
5608         (tui_refill_source_window)
5609         (tui_source_window_base::do_scroll_horizontal)
5610         (tui_update_breakpoint_info, tui_set_exec_info_content)
5611         (tui_show_exec_info_content, tui_erase_exec_info_content)
5612         (tui_clear_exec_info_content): Update.
5613         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5614         Update.
5615         * tui/tui-win.c (make_invisible_and_set_new_height)
5616         (make_visible_with_new_height): Update.
5617         * tui/tui-source.c (tui_set_source_content)
5618         (tui_show_symtab_source): Update.
5619         * tui/tui-layout.c (extract_display_start_addr)
5620         (show_source_disasm_command, show_data)
5621         (make_source_or_disasm_window)
5622         (show_source_or_disasm_and_command): Update.
5623         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5624         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5625         "gdbarch".
5626         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5627         to tui_source_window_base.
5628         (struct tui_win_info) <detail>: Remove source_info member.
5629         (struct tui_source_window_base) <has_locator>: Inline.
5630         Move contents from tui_source_info; rename has_locator member to
5631         m_has_locator.
5632         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5633         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5634         header file.
5635         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5636         Simplify.
5637         (tui_free_all_source_wins_content): Cast to
5638         tui_source_window_base.
5639
5640 2019-06-25  Tom Tromey  <tom@tromey.com>
5641
5642         * tui/tui-win.c (make_invisible_and_set_new_height)
5643         (make_visible_with_new_height): Call has_locator method.
5644         * tui/tui-layout.c (show_source_disasm_command, show_data)
5645         (show_source_or_disasm_and_command): Update for bool change.
5646         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5647         (tui_win_info) <has_locator>: New method.
5648         (struct tui_source_window_base) <has_locator>: New method.
5649         (tui_win_has_locator): Don't declare.
5650         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5651         from tui_win_has_locator.
5652         (tui_source_window_base): Use false, not FALSE.
5653
5654 2019-06-25  Tom Tromey  <tom@tromey.com>
5655
5656         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5657         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5658         clear_detail method directly.
5659         (tui_clear_win_detail): Remove.
5660
5661 2019-06-25  Tom Tromey  <tom@tromey.com>
5662
5663         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5664         "this", not TUI_DISASM_WIN.
5665
5666 2019-06-25  Tom Tromey  <tom@tromey.com>
5667
5668         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5669         declare.
5670         * tui/tui-winsource.c
5671         (tui_source_window_base::do_scroll_horizontal): Rename from
5672         tui_horizontal_source_scroll.
5673         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5674         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5675         from tui_vertical_data_scroll.
5676         * tui/tui-win.h (tui_scroll): Don't declare.
5677         * tui/tui-win.c (tui_win_info::forward_scroll)
5678         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5679         (tui_win_info::right_scroll): Rename and update.
5680         (tui_scroll_forward_command, tui_scroll_backward_command)
5681         (tui_scroll_left_command, tui_scroll_right_command): Update.
5682         (tui_scroll): Remove.
5683         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5684         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5685         from tui_vertical_source_scroll.
5686         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5687         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5688         from tui_vertical_disassem_scroll.
5689         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5690         do_scroll_horizontal>: New methods.
5691         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5692         Likewise.
5693         (struct tui_source_window_base): Add do_scroll_horizontal.
5694         (struct tui_source_window, struct tui_disasm_window): Add
5695         do_scroll_vertical.
5696         (struct tui_data_window, struct tui_cmd_window): Add
5697         do_scroll_horizontal and do_scroll_vertical.
5698         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5699
5700 2019-06-25  Tom Tromey  <tom@tromey.com>
5701
5702         * tui/tui-data.h (struct tui_source_window_base): New struct.
5703         (struct tui_source_window): Derive from tui_source_window_base.
5704         (struct tui_disasm_window): New struct.
5705         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5706         from tui_source_window::clear_detail.
5707         (tui_source_window_base): Rename from tui_source_window.
5708         (~tui_source_window_base): Rename from ~tui_source_window.
5709         (tui_alloc_win_info): Create a tui_disasm_window.
5710
5711 2019-06-25  Tom Tromey  <tom@tromey.com>
5712
5713         * tui/tui-data.h (struct tui_source_window)
5714         (struct tui_data_window): Declare destructors.
5715         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5716         destructors.
5717         (tui_win_info): Simplify.
5718
5719 2019-06-25  Tom Tromey  <tom@tromey.com>
5720
5721         * tui/tui-winsource.c (tui_display_main)
5722         (tui_update_source_windows_with_addr)
5723         (tui_update_all_breakpoint_info): Update.
5724         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5725         (new_height_ok, parse_scrolling_args): Update.
5726         * tui/tui-stack.c (tui_show_frame_info): Update.
5727         * tui/tui-data.h (struct tui_list): Remove.
5728         (tui_source_windows): Return a reference to a std::vector.
5729         * tui/tui-data.c (source_windows): Now a std::vector.
5730         (tui_source_windows): Change return type.
5731         (tui_clear_source_windows): Rewrite.
5732         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5733         (tui_free_all_source_wins_content): Rewrite.
5734
5735 2019-06-25  Tom Tromey  <tom@tromey.com>
5736
5737         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5738         (struct tui_data_window, struct tui_cmd_window): Declare
5739         clear_detail method.
5740         * tui/tui-data.c (tui_source_window::clear_detail)
5741         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5742         methods.
5743         (tui_clear_win_detail): Simplify.
5744
5745 2019-06-25  Tom Tromey  <tom@tromey.com>
5746
5747         * tui/tui-layout.c (make_source_window, make_disasm_window)
5748         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5749         Return the new window.
5750         (show_source_disasm_command, show_data)
5751         (show_source_or_disasm_and_command): Update.
5752
5753 2019-06-25  Tom Tromey  <tom@tromey.com>
5754
5755         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5756         parameter.  Return the new window.
5757         (show_source_disasm_command): Update and remove NULL check.
5758         (show_source_or_disasm_and_command): Update.
5759
5760 2019-06-25  Tom Tromey  <tom@tromey.com>
5761
5762         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5763
5764 2019-06-25  Tom Tromey  <tom@tromey.com>
5765
5766         * tui/tui-data.h (struct tui_win_info): Make constructor
5767         protected.  Make destructor virtual.  Add initializers.
5768         (tui_source_window, tui_data_window, tui_cmd_window): New
5769         classes.
5770         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5771         constructor.  Add "type" parameter.
5772         (tui_source_window, tui_data_window, tui_cmd_window): New
5773         constructors.
5774         (tui_alloc_win_info): Instantiate the appropriate subclass.
5775
5776 2019-06-25  Tom Tromey  <tom@tromey.com>
5777
5778         * tui/tui-win.c (tui_resize_all): Use delete.
5779         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5780         destructor.
5781         (tui_free_window): Don't declare.
5782         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5783         Update.
5784
5785 2019-06-25  Tom Tromey  <tom@tromey.com>
5786
5787         * tui/tui-data.h (struct tui_win_info): Add constructor.
5788         * tui/tui-data.c (tui_alloc_win_info): Use new.
5789         (tui_free_window): Use delete.
5790
5791 2019-06-22  Tom Tromey  <tom@tromey.com>
5792
5793         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5794         declare.
5795         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5796
5797 2019-06-22  Tom Tromey  <tom@tromey.com>
5798
5799         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5800         declare.
5801         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5802
5803 2019-06-22  Tom de Vries  <tdevries@suse.de>
5804
5805         * dwarf2read.c (create_addrmap_from_aranges)
5806         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5807         instead of '%zu'.
5808
5809 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5810
5811         * dwarf2read.h (dwarf2_section_info_def): Remove.
5812         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5813         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5814         std::vector<dwarf2_section_info>.
5815         (struct dwo_file) <~dwo_file>: Remove.
5816         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5817         types field.
5818         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5819         (dwarf2_read_debug_names): Likewise.
5820         (create_debug_types_hash_table): Change parameter type to
5821         array_view, adjust code accordingly.
5822         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5823         (partial_die_info::fixup): Likewise.
5824         (determine_prefix): Likewise.
5825         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5826
5827 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5828
5829         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5830         gdb_bfd_ref_ptr.
5831         <~dwo_file>: Remove call to gdb_bfd_unref.
5832         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5833         gdb_bfd_ref_ptr::get.
5834
5835 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5836
5837         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5838         type to htab_up.
5839         * dwarf2read.c (struct dwo_file): Initialize fields.
5840         <~dwo_file>: New.
5841         (free_dwo_file): Remove, move content to ~dwo_file.
5842         (struct dwo_file_deleter): Remove.
5843         (dwo_file_up>: Remove custom deleter.
5844         (free_dwo_files): Remove.
5845         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5846         dwo_files.
5847         (process_skeletonless_type_units): Call unique_ptr::get.
5848         (allocate_dwo_file_hash_table): Add deleter to created hash
5849         table.  Change return type to htab_up.
5850         (lookup_dwo_file_slot): Don't memset dwo_file, call
5851         unique_ptr::get.
5852         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5853         (create_dwo_unit_in_dwp_v2): Likewise.
5854         (open_and_init_dwo_file): Likewise.
5855         (free_dwo_file_from_slot): Remove.
5856
5857 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5858
5859         * dwarf2read.h (struct dwarf2_section_info) <readin,
5860         is_virtual>: Change type to bool.
5861         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5862         true instead of 1.
5863
5864 2019-06-19  Tom Tromey  <tom@tromey.com>
5865
5866         * tui/tui-data.h (tui_init_content_element): Don't declare.
5867
5868 2019-06-19  Tom Tromey  <tom@tromey.com>
5869
5870         * tui/tui-data.h (tui_init_win_info): Don't declare.
5871
5872 2019-06-19  Tom de Vries  <tdevries@suse.de>
5873
5874         * dwarf2read.h (abstract_to_concrete): Change type to
5875         std::unordered_map<sect_offset, std::vector<sect_offset>,
5876         gdb::hash_enum<sect_offset>>.
5877
5878 2019-06-19  Tom Tromey  <tromey@adacore.com>
5879
5880         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5881         EVAL_AVOID_SIDE_EFFECTS specially.
5882
5883 2019-06-19  Tom Tromey  <tromey@adacore.com>
5884
5885         * source-cache.c (highlighter): New global.
5886         (source_cache::get_source_lines): Create a highlighter on demand.
5887
5888 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5889
5890         * defs.h (deprecated_interactive_hook): Delete declaration.
5891         * interps.c (clear_interpreter_hooks): Remove use of
5892         deprecated_interactive_hook.
5893         * top.c (deprecated_interactive_hook): Delete definition.
5894         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5895
5896 2019-06-18  Tom de Vries  <tdevries@suse.de>
5897
5898         PR gdb/24515
5899         * dwarf2read.h (abstract_to_concrete): Change type from
5900         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5901         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5902         * dwarf2read.c (read_variable): Update.
5903         (dwarf2_fetch_die_loc_sect_off): Update.
5904
5905 2019-06-17  Tom de Vries  <tdevries@suse.de>
5906
5907         PR gdb/24617
5908         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5909         accessing parent[parent_len - 1].
5910
5911 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5912
5913         PR gdb/24364
5914         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5915         call dtrace_process_dof with NULL dof.
5916
5917 2019-06-16  Tom de Vries  <tdevries@suse.de>
5918
5919         PR gdb/24445
5920         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5921
5922 2019-06-16  Tom Tromey  <tom@tromey.com>
5923
5924         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5925         (make_all_visible): Use address of member.
5926
5927 2019-06-16  Tom Tromey  <tom@tromey.com>
5928
5929         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5930         (tui_free_window, free_content, free_content_elements): Remove
5931         unnecessary cast.
5932         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5933         cast.
5934         * tui/tui-regs.c (tui_show_register_group)
5935         (tui_display_registers_from, tui_display_reg_element_at_line):
5936         Remove unnecessary cast.
5937
5938 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5939
5940         * linux-nat.c (normal_mask): Delete.
5941         (_initialize_linux_nat): Don't initialise normal_mask.
5942
5943 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5944
5945         PR gdb/24445
5946         * dwarf-index-write.h (write_psymtabs_to_index): Add
5947         dwz_basename parameter.
5948         * dwarf-index-write.c (write_gdbindex): Move file writing to
5949         write_gdbindex_1.  Change return type void.
5950         (assert_file_size): Move up, remove filename parameter.
5951         (write_gdbindex_1): New function.
5952         (write_debug_names): Change return type to void, call
5953         assert_file_size.
5954         (struct index_wip_file): New struct.
5955         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5956         file logic to index_wip_file.  Write index for dwz file if
5957         needed.
5958         (save_gdb_index_command): Pass basename of dwz file, if present.
5959         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5960         build-id of dwz file, if present.
5961         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5962         (dwarf2_get_dwz_file): Likewise.
5963         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5964         (dwarf2_get_dwz_file): Likewise.
5965
5966 2019-06-16  Tom Tromey  <tom@tromey.com>
5967
5968         * coffread.c (process_coff_symbol): Use xstrdup.
5969         * value.c (create_internalvar): Use xstrdup.
5970
5971 2019-06-16  Tom Tromey  <tom@tromey.com>
5972
5973         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5974         * breakpoint.c (stopin_command, stopat_command)
5975         (until_break_command, decode_location_default): Remove unnecessary
5976         cast.
5977         * utils.c (subset_compare): Remove unnecessary cast.
5978         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5979         cast.
5980         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5981         cast.
5982         * infcmd.c (path_command): Remove unnecessary cast.
5983         * coffread.c (decode_type): Remove unnecessary cast.
5984         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5985         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5986         * tui/tui-stack.c (tui_show_locator_content)
5987         (tui_show_frame_info): Remove unnecessary cast.
5988         * tui/tui-win.c (tui_scroll_forward_command)
5989         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5990         (parse_scrolling_args): Remove unnecessary cast.
5991         * tui/tui-data.c (init_win_info, tui_del_window)
5992         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5993         (free_content_elements): Remove unnecessary cast.
5994         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5995         unnecessary cast.
5996         * tui/tui-source.c (tui_set_source_content)
5997         (tui_vertical_source_scroll): Remove unnecessary cast.
5998         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5999         cast.
6000         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6001         * tui/tui-regs.c (tui_display_registers_from)
6002         (tui_display_register): Remove unnecessary cast.
6003         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6004         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6005         (make_visible): Remove unnecessary cast.
6006         * tui/tui-winsource.c (tui_erase_source_content)
6007         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6008         unnecessary cast.
6009         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6010         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6011         * stabsread.c (read_type, read_array_type, read_range_type):
6012         Remove unnecessary cast.
6013         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6014         (parse_symbol, parse_type, upgrade_type, parse_external)
6015         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6016         unnecessary cast.
6017         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6018
6019 2019-06-16  Tom Tromey  <tom@tromey.com>
6020
6021         * tui/tui-data.c (tui_alloc_generic_win_info)
6022         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6023         checks.
6024
6025 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6026             Andrew Burgess  <andrew.burgess@embecosm.com>
6027
6028         * f-typeprint.c (f_print_type): Don't return early for not
6029         associated or not allocated types.
6030         (f_type_print_varspec_suffix): Add print_rank parameter and print
6031         ranks of array types in case they dangling.
6032         (f_type_print_base): Add print_rank parameter.
6033
6034 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6035
6036         * NEWS: Mention new MI commands.
6037         * break-catch-throw.c (enum exception_event_kind): Move to
6038         breakpoint.h.
6039         (print_mention_exception_catchpoint): Output text as a single
6040         message.
6041         (catch_exception_command_1): Rename to...
6042         (catch_exception_event): ...this, make non-static, update header
6043         command, and change some parameter types.
6044         (catch_catch_command): Update for changes to
6045         catch_exception_command_1.
6046         (catch_throw_command): Likewise.
6047         (catch_rethrow_command): Likewise.
6048         * breakpoint.c (enum exception_event_kind): Delete.
6049         * breakpoint.h (enum exception_event_kind): Moved here from
6050         break-catch-throw.c.
6051         (catch_exception_event): Declare.
6052         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6053         (mi_cmd_catch_throw): New function.
6054         (mi_cmd_catch_rethrow): New function.
6055         (mi_cmd_catch_catch): New function.
6056         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6057         'catch-catch' entries.
6058         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6059         (mi_cmd_catch_rethrow): Declare.
6060         (mi_cmd_catch_catch): Declare.
6061
6062 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6063
6064         * annotate.c (annotate_source_line): Change return type to void,
6065         update implementation to match.
6066         * annotate.h (annotate_source_line): Change return type to void,
6067         update header comment.
6068         * stack.c (print_frame_info): Don't change what frame information
6069         is printed based on whether annotations are on or not.
6070
6071 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6072
6073         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6074         (annotate_source): Make static.
6075         (annotate_source_line): Moved from source.c and renamed from
6076         identify_source_line.  Update the return type.
6077         * annotate.h (annotate_source): Delete declaration.
6078         (annotate_source_line): Declaration moved from source.h, and
6079         renamed from identify_source_line.  Return type updated.
6080         * source.c (identify_source_line): Moved to annotate.c and renamed
6081         to annotate_source_line.
6082         (info_line_command): Remove check of annotation_level.
6083         * source.h (identify_source_line): Move declaration to annotate.h
6084         and rename to annotate_source_line.
6085         * stack.c: Add 'annotate.h' include.
6086         (print_frame_info): Remove check of annotation_level before
6087         calling annotate_source_line.
6088
6089 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6090
6091         * source-cache.c (source_cache::get_plain_source_lines): Use
6092         open_source_file_with_line_charpos instead of just
6093         open_source_file, remove call to find_source_lines.
6094         (source_cache::get_source_lines): Likewise.
6095         * source.c (find_source_lines): Make static.
6096         (get_filename_and_charpos): Renamed into...
6097         (open_source_file_with_line_charpos): ..this along with changes to
6098         return a scoped_fd, and some other minor clean ups.
6099         (identify_source_line): Use open_source_file_with_line_charpos.
6100         (search_command_helper): Use open_source_file_with_line_charpos
6101         instead of just open_source_file, remove call to
6102         find_source_lines.
6103         * source.h (open_source_file_with_line_charpos): Declare new
6104         function.
6105         (find_source_lines): Delete declaration.
6106
6107 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6108
6109         * source.c (get_filename_and_charpos): Remove fullname
6110         parameter.
6111         (identify_source_line): Update call to get_filename_and_charpos.
6112
6113 2019-06-14  Tom Tromey  <tromey@adacore.com>
6114
6115         PR gdb/24502:
6116         * ui-style.h (skip_ansi_escape): Update comment.
6117         * ui-file.h (class no_terminal_escape_file): New class.
6118         * ui-file.c (no_terminal_escape_file::write)
6119         (no_terminal_escape_file::puts): New methods.
6120         * cli/cli-logging.c (handle_redirections): Use
6121         no_terminal_escape_file.
6122
6123 2019-06-14  Tom Tromey  <tromey@adacore.com>
6124
6125         * NEWS: Move convenience variable news above Python news.
6126
6127 2019-06-14  Tom Tromey  <tom@tromey.com>
6128
6129         * gnulib: Move directory to top-level.
6130         * configure.ac: Don't configure gnulib.
6131         * configure: Rebuild.
6132         * common/common-defs.h: Use new path to gnulib.
6133         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6134         (GNULIB_H): Remove.
6135         (INCGNU): Look in new gnulib location.
6136         (HFILES_NO_SRCDIR): Remove gnulib files.
6137         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6138         (generated_files): Remove GNULIB_H.
6139         ($(LIBGNU), all-lib): Remove targets.
6140         (distclean): Don't mention GNULIB_BUILDDIR.
6141         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6142
6143 2019-06-14  Tom Tromey  <tromey@adacore.com>
6144
6145         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6146         Warn if symbol file does not provide any symbols.
6147
6148 2019-06-14  Tom Tromey  <tromey@adacore.com>
6149
6150         * source.c (find_and_open_source): Respect basenames_may_differ.
6151
6152 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6153
6154         * annotate.c (annotate_breakpoints_invalid): Make use of
6155         scoped_restore_terminal_state.
6156         (annotate_frames_invalid): Likewise.
6157
6158 2019-06-14  Tom Tromey  <tromey@adacore.com>
6159
6160         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6161         allow assignment to an internalvar.
6162
6163 2019-06-14  Tom Tromey  <tromey@adacore.com>
6164
6165         * ada-lex.l: Allow "_" in attribute names.
6166
6167 2019-06-14  Tom Tromey  <tromey@adacore.com>
6168
6169         PR gdb/24653:
6170         * regcache.c (registers_changed): Don't call alloca.
6171         * top.c (execute_command): Don't call alloca.
6172
6173 2019-06-13  Pedro Alves  <palves@redhat.com>
6174
6175         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6176         'expression'.  When parsing an expression, error out if there's
6177         junk after "unlimited".
6178         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6179         (do_set_command): Adjust calls to is_unlimited_literal.
6180
6181 2019-06-13  Pedro Alves  <palves@redhat.com>
6182
6183         * compile/compile.c (make_compile_options_def_group): Add braces
6184         around array_view initializer.
6185         * thread.c (make_thread_apply_all_options_def_group)
6186         (make_thread_apply_all_options_def_group): Likewise.
6187
6188 2019-06-13  Pedro Alves  <palves@redhat.com>
6189
6190         * NEWS (New commands): Mention "maint test-options
6191         require-delimiter", "maint test-options unknown-is-error", "maint
6192         test-options unknown-is-operand" and "maint show
6193         test-options-completion-result".
6194         (New command options, command completion): New section.
6195         (Completion improvements): New section.
6196         Mention that you can abbreviate "unlimited".
6197
6198 2019-06-13  Pedro Alves  <palves@redhat.com>
6199
6200         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6201         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6202         * unittests/cli-utils-selftests.c (test_parse_flags)
6203         (test_parse_flags_qcs): Delete.
6204         (test_cli_utils): Don't call deleted functions.
6205
6206 2019-06-13  Pedro Alves  <palves@redhat.com>
6207
6208         * thread.c: Include "cli/cli-option.h".
6209         (tp_array_compar_ascending): Global.
6210         (tp_array_compar): Delete function.
6211         (tp_array_compar_ascending, tp_array_compar_descending): New
6212         functions.
6213         (ascending_option_def, qcs_flag_option_def)
6214         (thr_qcs_flags_option_defs)
6215         (make_thread_apply_all_options_def_group)
6216         (make_thread_apply_options_def_group): New.
6217         (thread_apply_all_command): Use gdb::option::process_options.
6218         (thread_apply_command_completer)
6219         (thread_apply_all_command_completer): New.
6220         (thread_apply_command): Use gdb::option::process_options.
6221         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6222         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6223         to generate help text of "thread apply".  Adjust "taas"'s help.
6224         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6225         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6226
6227 2019-06-13  Pedro Alves  <palves@redhat.com>
6228
6229         * thread.c (thread_apply_command): Check for invalid TID with
6230         isdigit instead of !isalpha.
6231
6232 2019-06-13  Pedro Alves  <palves@redhat.com>
6233
6234         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6235         (validate_flags_qcs): New.
6236         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6237         (validate_flags_qcs): Declare.
6238         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6239         (make_frame_apply_options_def_group): New.
6240         (frame_apply_command_count): Process options with
6241         gdb::option::process_options.
6242         (frame_apply_completer): New.
6243         (frame_apply_level_completer, frame_apply_all_completer)
6244         (frame_apply_completer): New.
6245         (_initialize_stack): Update help of "frame apply", "frame apply
6246         level", "frame apply all" and "faas" to mention supported options
6247         and install command completers.
6248         * stack.h (frame_apply_all_completer): Declare.
6249         * thread.c: Include "stack.h".
6250         (tfaas_command): Add "--".
6251         (_initialize_thread): Update help "tfaas" to mention supported
6252         options and install command completer.
6253
6254 2019-06-13  Pedro Alves  <palves@redhat.com>
6255
6256         * completer.c (complete_nested_command_line): New.
6257         (gdb_completion_word_break_characters_throw): Add assertion.
6258         * completer.h (complete_nested_command_line): Declare.
6259
6260 2019-06-13  Pedro Alves  <palves@redhat.com>
6261
6262         * stack.c (parse_backtrace_qualifiers): New.
6263         (backtrace_command): Use it.
6264         (backtrace_command_completer): Complete on qualifiers.
6265
6266 2019-06-13  Pedro Alves  <palves@redhat.com>
6267
6268         * frame.c: Include "cli/cli-option.h.
6269         (user_set_backtrace_options): New.
6270         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6271         Delete.
6272         (get_prev_frame): Adjust.
6273         (boolean_option_def, uinteger_option_def)
6274         (set_backtrace_option_defs): New.
6275         (_initialize_frame): Adjust and use
6276         gdb::option::add_setshow_cmds_for_options to install "set
6277         backtrace past-main" and "set backtrace past-entry".
6278         * frame.h: Include "cli/cli-option.h".
6279         (struct frame_print_options): Forward declare.
6280         (print_frame_arguments_all, print_frame_arguments_scalars)
6281         (print_frame_arguments_none): Declare.
6282         (print_entry_values): Delete declaration.
6283         (struct frame_print_options, user_frame_print_options): New.
6284         (struct set_backtrace_options): New.
6285         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6286         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6287         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6288         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6289         (list_args_or_locals): Add frame_print_options parameter.
6290         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6291         * python/py-framefilter.c (enumerate_args): Pass down
6292         USER_FRAME_PRINT_OPTIONS.
6293         * stack.c: Include "cli/cli-option.h".
6294         (print_frame_arguments_all, print_frame_arguments_scalars)
6295         (print_frame_arguments_none): Declare.
6296         (print_raw_frame_arguments, print_entry_values): Delete.
6297         (user_frame_print_options): New.
6298         (boolean_option_def, enum_option_def, frame_print_option_defs):
6299         New.
6300         (struct backtrace_cmd_options): New.
6301         (bt_flag_option_def): New.
6302         (backtrace_command_option_defs): New.
6303         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6304         (print_frame_arg, read_frame_arg, print_frame_args)
6305         (print_frame_info, print_frame): Add frame_print_options parameter
6306         and use it.
6307         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6308         (backtrace_command_1): Add frame_print_options and
6309         backtrace_cmd_options parameters and use them.
6310         (make_backtrace_options_def_group): New.
6311         (backtrace_command): Process command options with
6312         gdb::option::process_options.
6313         (backtrace_command_completer): New.
6314         (_initialize_stack): Extend "backtrace"'s help to mention
6315         supported options.  Install completer for "backtrace".
6316         Install some settings commands with add_setshow_cmds_for_options.
6317
6318 2019-06-13  Pedro Alves  <palves@redhat.com>
6319
6320         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6321         and that "set/show print raw frame-arguments" are now deprecated.
6322
6323         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6324         command.
6325         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6326         * stack.c (_initialize_stack): Install "set/show print
6327         raw-frame-arguments", and deprecate "set/show print raw
6328         frame-arguments".
6329         * valprint.c (_initialize_valprint): Deprecate "set/show print
6330         raw".
6331
6332 2019-06-13  Pedro Alves  <palves@redhat.com>
6333
6334         * compile/compile.c (struct compile_options): New.
6335         (compile_flag_option_def, compile_command_option_defs)
6336         (make_compile_options_def_group): New.
6337         (compile_file_command): Handle options with
6338         gdb::option::process_options.
6339         (compile_file_command_completer): New function.
6340         (compile_code_command): Handle options with
6341         gdb::option::process_options.
6342         (compile_code_command_completer): New function.
6343         (_initialize_compiler): Install completers for "compile code" and
6344         "compile file".  Mention available options in "compile code" and
6345         "compile code"'s help.
6346         * completer.c (advance_to_completion_word): New, factored out from
6347         ...
6348         (advance_to_expression_complete_word_point): ... this.
6349         (advance_to_filename_complete_word_point): New.
6350         * completer.h (advance_to_filename_complete_word_point): New
6351         declaration.
6352
6353 2019-06-13  Pedro Alves  <palves@redhat.com>
6354
6355         * compile/compile.c: Include "cli/cli-option.h".
6356         (compile_print_value): Scope data pointer is now a
6357         value_print_options pointer; adjust.
6358         (compile_print_command): Process options.  Scope data pointer is
6359         now a value_print_options pointer; adjust.
6360         (_initialize_compile): Update "compile print"'s help to include
6361         supported options.  Install a completer for "compile print".
6362         * cp-valprint.c (show_vtblprint, show_objectprint)
6363         (show_static_field_print): Delete.
6364         (_initialize_cp_valprint): Don't install "set print
6365         static-members", "set print vtbl", "set print object" here.
6366         * printcmd.c: Include "cli/cli-option.h" and
6367         "common/gdb_optional.h".
6368         (print_command_parse_format): Rework to fill in a
6369         value_print_options instead of a format_data.
6370         (print_value): Change parameter type from format_data pointer to
6371         value_print_options reference.  Adjust.
6372         (print_command_1): Process options.  Adjust to pass down a
6373         value_print_options.
6374         (print_command_completer): New.
6375         (_initialize_printcmd): Install print_command_completer as
6376         handle_brkchars completer for the "print" command.  Update
6377         "print"'s help to include supported options.
6378         * valprint.c: Include "cli/cli-option.h".
6379         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6380         here from cp-valprint.c.
6381         (boolean_option_def, uinteger_option_def)
6382         (value_print_option_defs, make_value_print_options_def_group):
6383         New.  Use gdb::option::add_setshow_cmds_for_options to install
6384         "set print elements", "set print null-stop", "set print repeats",
6385         "set print pretty", "set print union", "set print array", "set
6386         print address", "set print symbol", "set print array-indexes".
6387         * valprint.h: Include <string> and "cli/cli-option.h".
6388         (make_value_print_options_def_group): Declare.
6389         (print_value): Change parameter type from format_data pointer to
6390         value_print_options reference.
6391         (print_command_completer): Declare.
6392
6393 2019-06-13  Pedro Alves  <palves@redhat.com>
6394
6395         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6396         (COMMON_SFILES): Add maint-test-settings.c.
6397         * cli/cli-decode.c (boolean_enums): New global, factored out from
6398         ...
6399         (add_setshow_boolean_cmd): ... here.
6400         * cli/cli-decode.h (boolean_enums): Declare.
6401         * cli/cli-option.c: New file.
6402         * cli/cli-option.h: New file.
6403         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6404         factored out from ...
6405         (parse_cli_boolean_value(const char *)): ... this.
6406         (is_unlimited_literal): Change parameter type to pointer to
6407         pointer.  Adjust and advance ARG pointer.
6408         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6409         (parse_cli_var_enum): New, factored out from ...
6410         (do_set_command): ... this.  Adjust.
6411         * cli/cli-setshow.h (parse_cli_boolean_value)
6412         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6413         (parse_cli_var_enum): Declare.
6414         * cli/cli-utils.c: Include "cli/cli-option.h".
6415         (get_ulongest): New.
6416         * cli/cli-utils.h (get_ulongest): Declare.
6417         (check_for_argument): New overloads.
6418         * maint-test-options.c: New file.
6419
6420 2019-06-13  Pedro Alves  <palves@redhat.com>
6421
6422         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6423         parse a range if "-" is at the end of the string.
6424
6425 2019-06-13  Pedro Alves  <palves@redhat.com>
6426
6427         * cli/cli-setshow.c (parse_auto_binary_operation)
6428         (parse_cli_boolean_value): Don't allow "o".
6429
6430 2019-06-13  Pedro Alves  <palves@redhat.com>
6431
6432         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6433         * NEWS: Mention maint test-settings KIND.
6434         * maint-test-settings.c: New file.
6435
6436 2019-06-13  Pedro Alves  <palves@redhat.com>
6437
6438         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6439         completer.
6440         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6441         "set" completers.
6442
6443 2019-06-13  Pedro Alves  <palves@redhat.com>
6444
6445         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6446         after item.
6447
6448 2019-06-13  Pedro Alves  <palves@redhat.com>
6449
6450         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6451
6452 2019-06-13  Pedro Alves <palves@redhat.com>
6453
6454         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6455         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6456         call.
6457         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6458         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6459         calls.
6460         (check_for_argument): Skip spaces after argument.
6461
6462 2019-06-13  Pedro Alves  <palves@redhat.com>
6463
6464         * thread.c (thread_apply_command): Adjust TID parsing.
6465         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6466         detected before end of string.
6467         (tid_is_in_list): Error out if LIST is invalid.
6468
6469 2019-06-13  Pedro Alves  <palves@redhat.com>
6470
6471         * completer.c (complete_line_internal_1): Rewind completion word
6472         point.
6473         (completion_tracker::advance_custom_word_point_by): Change
6474         parameter type to int.
6475         * completer.h (completion_tracker::advance_custom_word_point_by):
6476         Likewise.
6477
6478 2019-06-13  Pedro Alves  <palves@redhat.com>
6479
6480         * completer.c (advance_to_completion_word): Handle delimiters.
6481
6482 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6483
6484         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6485
6486 2019-06-11  Tom Tromey  <tom@tromey.com>
6487
6488         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6489         (xmalloc_failed): Move to alloc.c.
6490         * alloc.c: New file.
6491         * Makefile.in (COMMON_SFILES): Add alloc.c.
6492
6493 2019-06-11  Tom Tromey  <tom@tromey.com>
6494
6495         * nat/linux-waitpid.c: Don't include server.h.
6496         (linux_debug): Remove.
6497         (my_waitpid): Update.
6498
6499 2019-06-11  Tom Tromey  <tromey@adacore.com>
6500
6501         * infcall.c (_initialize_infcall): Remove trailing newline from
6502         help.
6503         * user-regs.c (_initialize_user_regs): Remove trailing newline
6504         from help.
6505         * typeprint.c (_initialize_typeprint): Remove trailing newline
6506         from help.
6507         * reverse.c (_initialize_reverse): Remove trailing newlines from
6508         help.
6509         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6510         from help.
6511         * language.c (add_set_language_command): Remove trailing newline
6512         from help.
6513         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6514         help.
6515         * disasm.c (_initialize_disasm): Remove trailing newline from
6516         help.
6517         * top.c (init_main): Remove trailing newline from help.
6518         * interps.c (_initialize_interpreter): Remove trailing newline
6519         from help.
6520         * btrace.c (_initialize_btrace): Remove trailing newlines from
6521         help.
6522         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6523         from help.
6524         * python/python.c (_initialize_python): Remove trailing newline
6525         from help.
6526         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6527         help.
6528         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6529         from help.  Reformat some text.
6530         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6531         from help.
6532         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6533         newline from help.
6534
6535 2019-06-11  Tom Tromey  <tromey@adacore.com>
6536
6537         * darwin-nat.c (darwin_decode_exception_message)
6538         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6539
6540 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6541
6542         * valops.c (value_slice): Check for not allocated or not
6543         associated values.
6544
6545 2019-06-10  Tom de Vries  <tdevries@suse.de>
6546
6547         PR gdb/24618
6548         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6549         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6550         invalid.
6551
6552 2019-06-10  Tom de Vries  <tdevries@suse.de>
6553
6554         PR gdb/24611
6555         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6556         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6557
6558 2019-06-10  Tom de Vries  <tdevries@suse.de>
6559
6560         PR symtab/24545
6561         * symtab.c (struct demangled_name_entry): Add language field.
6562         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6563         static minimal symbol".  Set and use language field.
6564
6565 2019-06-10  Tom Tromey  <tromey@adacore.com>
6566
6567         * ada-lang.c (_initialize_ada_language): Update help text.
6568
6569 2019-06-10  Tom Tromey  <tromey@adacore.com>
6570
6571         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6572         with a newline.
6573         * guile/guile.c (handle_boot_error): Don't end warning with a
6574         newline.
6575         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6576         warning with a newline.
6577         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6578         newline.
6579         (s12z_frame_cache): Likewise.
6580         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6581         a newline.
6582         * solib-svr4.c (disable_probes_interface): Don't end warning with
6583         a newline.
6584         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6585         newline.
6586         * python/python.c (do_finish_initialization): Don't end warning
6587         with a newline.
6588
6589 2019-06-10  Tom Tromey  <tom@tromey.com>
6590
6591         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6592         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6593         gdbpy_enter.
6594
6595 2019-06-10  Tom Tromey  <tromey@adacore.com>
6596
6597         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6598         data.
6599         (elf_new_init): Don't call stabsread_new_init.
6600         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6601         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6602         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6603
6604 2019-06-10  Tom de Vries  <tdevries@suse.de>
6605
6606         PR symtab/16264
6607         PR symtab/24517
6608         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6609
6610 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6611
6612         * source.c (find_and_open_source): Also rewrite relative file
6613         names.
6614
6615 2019-04-26  Amos Bird  <amosbird@gmail.com>
6616
6617         * annotate.c (annotate_thread_exited): Add "thread-exited"
6618         annotation.
6619
6620 2019-06-06  Tom Tromey  <tromey@adacore.com>
6621
6622         * maint.h (class scoped_command_stats): Use
6623         DISABLE_COPY_AND_ASSIGN.
6624         <print_time>: New method.
6625         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6626         print_time.
6627         (scoped_command_stats::print_time): New method.
6628
6629 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6630
6631         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6632         instructions of lengths 6 or 8 bytes.
6633
6634 2019-06-04  Pedro Alves  <palves@redhat.com>
6635
6636         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6637
6638         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6639         * breakpoint.c (condition_completer): Likewise.
6640         * cli/cli-dump.c (scan_expression): Likewise.
6641         * common/filestuff.c (mkdir_recursive): Likewise.
6642         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6643         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6644         (gdb_abspath): Likewise.
6645         * compile/compile-cplus-types.c
6646         (compile_cplus_instance::decl_name): Likewise.
6647         * completer.c (complete_explicit_location):
6648         (signal_completer, reg_or_group_completer_1): Likewise.
6649         * cp-support.c (cp_remove_params_if_any): Likewise.
6650         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6651         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6652         * infcmd.c (strip_bg_char): Likewise.
6653         * linespec.c (copy_token_string): Likewise.
6654         * mi/mi-main.c (output_cores): Likewise.
6655         * psymtab.c (psymtab_search_name):
6656         * symfile.c (test_set_ext_lang_command): Likewise.
6657         * target.c (target_fileio_read_stralloc): Likewise.
6658         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6659         * value.c (complete_internalvar): Likewise.
6660
6661 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6662
6663         Add objfile property to gdb.Type.
6664         * NEWS: Mention Python API addition.
6665         * python/py-type.c (typy_get_objfile): New method.
6666
6667 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6668
6669         * NEWS: Mention the new set|show style [title|highlight].
6670         Mention changes to "show style", "help" and "apropos".
6671
6672 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6673
6674         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6675         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6676         instead of print_help_for_command.
6677         (print_doc_of_command): New function.
6678         (help_list): Add 'apropos -v word' suggestion.
6679         (print_help_for_command): Style the command name using title style.
6680         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6681         (_initialize_cli_cmds): Describe -v in apropos_command help.
6682
6683 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6684
6685         * cli/cli-style.h (cli_style_option): Add name in constructor,
6686         add m_name class member, add constructor with intensity,
6687         add name class function.
6688         (cli_style_option::add_setshow_commands): Remove name argument.
6689         (highlight_style, title_style): New styles.
6690         * cli/cli-style.c (do_show): New function that shows a style
6691         characteristic styling the style name with itself.
6692         (set_style_name): New function.
6693         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6694         Update all callers according to the changes in cli/cli-style.h.
6695         * utils.h (fputs_highlighted): New function.
6696         * utils.c (fputs_highlighted): Likewise.
6697
6698 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6699
6700         * NEWS: Mention new pipe command and new convenience variables.
6701
6702 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6703
6704         * cli/cli-cmds.c (pipe_command): New function.
6705         (_initialize_cli_cmds): Call add_com for pipe_command.
6706         Define | as an alias for pipe.
6707         (exit_status_set_internal_vars): New function.
6708         (shell_escape): Call exit_status_set_internal_vars.
6709         cli/cli-decode.c (find_command_name_length): Recognize | as
6710         a single character command.
6711
6712 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6713
6714         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6715         top.c (execute_command_to_ui_file): New function, mostly a copy
6716         of execute_command_to_string.
6717         (execute_command_to_string): Implement by calling
6718         execute_command_to_ui_file.
6719
6720 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6721
6722         * top.h (saved_command_line): Remove declaration.
6723         * top.c (previous_saved_command_line, previous_repeat_arguments):
6724         New variables.
6725         (saved_command_line): Make static, define together with other
6726         'repeat variables'.
6727         (dont_repeat): Clear repeat_arguments.
6728         (repeat_previous, get_saved_command_line, save_command_line):
6729         New functions.
6730         (gdb_init): Initialize saved_command_line
6731         and previous_saved_command_line.
6732         * main.c (captured_main_1): Remove saved_command_line initialization.
6733         * event-top.c (handle_line_of_input): Update to use
6734         the new 'repeat' related functions instead of direct access to
6735         saved_command_line.
6736         * command.h (repeat_previous, get_saved_command_line,
6737         save_command_line): New declarations.
6738         (dont_repeat): Add comment.
6739
6740 2019-05-30  Tom Tromey  <tromey@adacore.com>
6741
6742         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6743         Fix comment.
6744         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6745
6746 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6747
6748         PR cli/24587
6749         * completer.c (complete): Initialize variable word.
6750
6751 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6752
6753         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6754         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6755         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6756         'body' is NULL to the outter 'if', protecting the '!is_define'
6757         situation as well.
6758
6759 2019-05-29  Tom Tromey  <tromey@adacore.com>
6760
6761         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6762         (dwarf_unknown): New function.
6763         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6764         (dwarf_type_encoding_name): Use dwarf_unknown.
6765
6766 2019-05-29  Tom Tromey  <tromey@adacore.com>
6767
6768         PR c++/20020:
6769         * cp-valprint.c (cp_print_value_fields): Call
6770         cp_print_static_field inside "try".
6771
6772 2019-05-29  Tom Tromey  <tromey@adacore.com>
6773
6774         * inflow.c (struct terminal_info): Add default operator=.
6775         * configure: Rebuild.
6776         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6777         -Wdeprecated-copy-dtor, -Wredundant-move.
6778
6779 2019-05-29  Tom Tromey  <tromey@adacore.com>
6780
6781         * NEWS: Add entry.
6782         * infcmd.c (print_return_value_1): Handle finish_print
6783         option.
6784         (show_print_finish): New function.
6785         (_initialize_infcmd): Add "set/show print finish" commands.
6786         * valprint.c (user_print_options): Initialize new member.
6787         * valprint.h (struct value_print_options) <finish_print>: New
6788         member.
6789
6790 2019-05-28  Tom Tromey  <tromey@adacore.com>
6791
6792         * ada-lang.c (ada_remove_Xbn_suffix)
6793         (find_old_style_renaming_symbol)
6794         (parse_old_style_renaming): Remove.
6795         (ada_find_renaming_symbol): Don't call
6796         find_old_style_renaming_symbol.
6797         (ada_is_renaming_symbol): Rename from
6798         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6799         bool.  Now static.
6800         (ada_read_var_value): Update and simplify.
6801         * ada-exp.y (write_var_or_type): Remove old code.
6802
6803 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6804
6805         PR gdb/25010
6806         * event-top.c: Remove include comment.
6807         * inflow.c (class scoped_ignore_sigttou): Move from here...
6808         * inflow.h (class scoped_ignore_sigttou): ...to here.
6809         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6810         * top.c:  Remove include comment.
6811
6812 2019-05-27  Tom Tromey  <tom@tromey.com>
6813
6814         * NEWS: Fix typo.
6815
6816 2019-05-22  Tom Tromey  <tromey@adacore.com>
6817
6818         * target.c (target_follow_exec): Constify parameter.
6819         * target-delegates.c: Rebuild.
6820         * remote.c (remote_target::follow_exec): Constify parameter.
6821         * infrun.c (follow_exec): Constify parameter.
6822         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6823         (target_follow_exec): Likewise.
6824
6825 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6826
6827         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6828         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6829
6830 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6831
6832         * NEWS: Add debugredirect and testsuite sections.
6833
6834 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6835
6836         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6837         target descriptions using exclusively floating point register name
6838         aliases.
6839
6840 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6841
6842         PR gdb/18644:
6843         * f-lang.c (build_fortran_types): Handle the case where
6844         gdbarch_floatformat_for_type returns a nullptr.
6845
6846 2019-05-21  Tom de Vries  <tdevries@suse.de>
6847
6848         PR cli/24587
6849         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6850
6851 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6852
6853         PR gdb/18644:
6854         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6855         16-byte floats.
6856         * i386-tdep.c (i386_floatformat_for_type): Use
6857         floatformats_ia64_quad for the 16-byte floating point component
6858         within a fortran 32-byte complex number.
6859
6860 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6861
6862         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6863         delete default constructor.
6864         (find_partial_die): Update to return const struct.
6865         (partial_die_parent_scope): Move variable declaration into scope
6866         of its use and change its type to auto.
6867         (guess_partial_die_structure_name): Likewise.
6868         (partial_die_info::fixup): Likewise.
6869
6870 2019-05-17  Tom Tromey  <tromey@adacore.com>
6871
6872         * source.c (find_and_open_source): Remove cast.
6873
6874 2019-05-17  Tom Tromey  <tromey@adacore.com>
6875
6876         * annotate.c (annotate_source): Make "filename" const.
6877         * annotate.h (annotate_source): Use const.
6878
6879 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6880
6881         * disasm.c (set_disassembler_options): Send errors to stderr.
6882
6883 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6884
6885         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6886         (cli_interp_base::set_logging): Check debug_redirect.
6887         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6888         * cli/cli-logging.c (debug_redirect): Add static variable.
6889         (pop_output_files): Add default param.
6890         (handle_redirections): Print debug setting.
6891         (show_logging_command): Likewise.
6892         (_initialize_cli_logging): Add debugredirect command.
6893         * interps.c (current_interp_set_logging): Add debug_redirect
6894         parameter.
6895         * interps.h (set_logging): Add debug_redirect parameter.
6896         (current_interp_set_logging): Likewise.
6897         * mi/mi-common.h: Likewise.
6898         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6899
6900 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6901             Tom Tromey  <tromey@adacore.com>
6902
6903         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6904         directly.
6905         * cli/cli-interp.h (make_logging_output): Remove declaration.
6906         * cli/cli-logging.c (make_logging_output): Remove function.
6907         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6908         directly.
6909         * ui-file.c (tee_file::tee_file): Remove bools.
6910         (tee_file::~tee_file): Remove deletes.
6911         * ui-file.h (tee_file): Remove bools.
6912
6913 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6914
6915         * mi/mi-cmds.h (mi_cmd_complete): New function.
6916         * mi/mi-main.c (mi_cmd_complete): Likewise.
6917         * mi/mi-cmds.c: Define new MI command -complete.
6918         * NEWS: Mention new -complete command.
6919
6920 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6921
6922         * completer.h (complete): New function.
6923         * completer.c (complete): Likewise.
6924         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6925         function defined in completer.h.
6926
6927 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6928
6929         * MAINTAINERS (Write After Approval): Add myself.
6930
6931 2019-05-17  Tom de Vries  <tdevries@suse.de>
6932
6933         PR gdb/24094
6934         * dwarf2read.c (struct cu_partial_die_info): New struct.
6935         (find_partial_die): Return cu_partial_die_info.
6936         (partial_die_parent_scope, guess_partial_die_structure_name)
6937         (partial_die_info::fixup): Handle new return type of find_partial_die.
6938
6939 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6940
6941         PR breakpoints/24541
6942         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6943         "std::string", simplifying the algorithm.
6944
6945 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6946
6947         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6948         (stap_static_probe_ops::get_probes): Likewise.
6949
6950 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6951
6952         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6953         '-')" and "else if".
6954         (stap_parse_single_operand): Join checks for
6955         "gdbarch_stap_parse_special_token_p" and
6956         "gdbarch_stap_parse_special_token" in the same "if" statement.
6957         Invert check when verifying for operation on register
6958         displacement.
6959
6960 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6961
6962         * stap-probe.c (stap_get_opcode): Update comment.
6963         (stap_get_expected_argument_type): Likewise.
6964         (handle_stap_probe): Likewise.
6965
6966 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6967
6968         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6969         return type to 'bool'.  Adjust comment.  Use 'bool' when
6970         appropriate.
6971         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6972         * stap-probe.c (stap_parse_argument_1): Likewise.
6973         (stap_is_operator): Likewise.
6974         (stap_is_generic_prefix): Likewise.
6975         (stap_is_register_prefix): Likewise.
6976         (stap_is_register_indirection_prefix): Likewise.
6977         (stap_is_integer_prefix): Likewise.
6978         (stap_generic_check_suffix): Likewise.
6979         (stap_check_integer_suffix): Likewise.
6980         (stap_check_register_suffix): Likewise.
6981         (stap_check_register_indirection_suffix): Likewise.
6982         (stap_parse_register_operand): Likewise.
6983         (stap_parse_single_operand): Likewise.
6984         (stap_parse_argument_1): Likewise.
6985         (stap_probe::get_argument_count): Likewise.
6986         (stap_is_operator): Likewise.
6987
6988 2019-05-16  Tom Tromey  <tromey@adacore.com>
6989
6990         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6991         keyword to foreach.
6992
6993 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6994
6995         * linux-thread-db.c (try_thread_db_load_1): Change return type
6996         to bool.
6997         (try_thread_db_load): Likewise.
6998         (try_thread_db_load_from_pdir_1): Likewise.
6999         (try_thread_db_load_from_pdir): Likewise.
7000         (try_thread_db_load_from_sdir): Likewise.
7001         (try_thread_db_load_from_dir): Likewise.
7002         (thread_db_load_search): Likewise.
7003         (has_libpthread): Likewise.
7004         (thread_db_load): Likewise.
7005
7006 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7007
7008         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7009         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7010         NULL, and complain/return if that's the case.
7011
7012 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7013
7014         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7015         (advance, posn, abstract_read_memory): New functions.
7016         [struct mem_read_abstraction]: New struct.
7017         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7018
7019 2019-05-14  Tom Tromey  <tromey@adacore.com>
7020
7021         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7022         value is not lval_memory.
7023
7024 2019-05-14  Tom Tromey  <tromey@adacore.com>
7025
7026         * solib.c (info_sharedlibrary_command): Style the file name.
7027
7028 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7029
7030         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7031         (aarch64_vnv_type): Likewise.
7032         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7033         * common/tdesc.c: Likewise.
7034         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7035         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7036         * features/aarch64-fpu.xml: Add ieee half view.
7037         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7038         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7039         * gdbtypes.h (struct builtin_type): Likewise.
7040         (struct objfile_type): Likewise.
7041
7042 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7043
7044         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7045         typo.
7046         * location.h (string_to_event_location): Likewise.
7047
7048 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7049
7050         GDB 8.3 released.
7051
7052 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7053
7054         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7055         New variable declaration.
7056         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7057         New variable.
7058         (print_one_breakpoint): Use ui_out::test_flags and new global
7059         variable to compute use_fixed_output.
7060         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7061         Remove.
7062         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7063         (mi_multi_location_breakpoint_output_fixed): Remove.
7064         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7065         new variable.
7066         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7067         fix_multi_location_breakpoint_output flag if version >= 3.
7068         * ui-out.h (enum ui_out_flag)
7069         <fix_multi_location_breakpoint_output>: New enumerator.
7070
7071 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7072
7073         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7074
7075 2019-05-10  Tom Tromey  <tromey@adacore.com>
7076
7077         * ada-lang.c (catch_ada_completer): New function.
7078         (_initialize_ada_language): Use it.
7079
7080 2019-05-10  Tom Tromey  <tromey@adacore.com>
7081
7082         * thread.c (print_thread_info): Make "requested_threads" const.
7083         * gdbthread.h (print_thread_info): Make "requested_threads"
7084         const.
7085         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7086         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7087
7088 2019-05-08  Tom Tromey  <tom@tromey.com>
7089
7090         * gdbtypes.c (objfile_type_data): Change type.
7091         (objfile_type, _initialize_gdbtypes): Update.
7092
7093 2019-05-08  Tom Tromey  <tom@tromey.com>
7094
7095         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7096         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7097         (_initialize_dwarf2_frame): Update.
7098
7099 2019-05-08  Tom Tromey  <tom@tromey.com>
7100
7101         * objc-lang.c (objc_objfile_data): Change type.
7102         (find_methods): Update.
7103         (_initialize_objc_lang): Remove.
7104
7105 2019-05-08  Tom Tromey  <tom@tromey.com>
7106
7107         * stabsread.c (rs6000_builtin_type_data): Change type.
7108         (rs6000_builtin_type, _initialize_stabsread): Update.
7109
7110 2019-05-08  Tom Tromey  <tom@tromey.com>
7111
7112         * mips-tdep.c (mips_pdr_data): Remove.
7113         (_initialize_mips_tdep): Update.
7114
7115 2019-05-08  Tom Tromey  <tom@tromey.com>
7116
7117         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7118         (hppa_init_objfile_priv_data, read_unwind_info)
7119         (find_unwind_entry, _initialize_hppa_tdep): Update.
7120
7121 2019-05-08  Tom Tromey  <tom@tromey.com>
7122
7123         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7124         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7125         on obstack.
7126         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7127
7128 2019-05-08  Tom Tromey  <tom@tromey.com>
7129
7130         * mdebugread.c (basic_type_data): Change type.
7131         (basic_type, _initialize_mdebugread): Update.
7132
7133 2019-05-08  Tom Tromey  <tom@tromey.com>
7134
7135         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7136
7137 2019-05-08  Tom Tromey  <tom@tromey.com>
7138
7139         * nto-tdep.c (nto_inferior_data_reg): Change type.
7140         (nto_inferior_data): Update.
7141         (nto_inferior_data_cleanup, nto_new_inferior_data)
7142         (_initialize_nto_tdep): Remove.
7143         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7144
7145 2019-05-08  Tom Tromey  <tom@tromey.com>
7146
7147         * ada-lang.c (struct ada_inferior_data): Add initializers.
7148         (ada_inferior_data): Change type.
7149         (ada_inferior_data_cleanup): Remove.
7150         (get_ada_inferior_data, ada_inferior_exit)
7151         (struct ada_pspace_data): Add initializers, destructor.
7152         (ada_pspace_data_handle): Change type.
7153         (get_ada_pspace_data): Update.
7154         (ada_pspace_data_cleanup): Remove.
7155
7156 2019-05-08  Tom Tromey  <tom@tromey.com>
7157
7158         * coffread.c (struct coff_symfile_info): Add initializers.
7159         (coff_objfile_data_key): Move lower.  Change type.
7160         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7161         Update.
7162         (coff_free_info): Remove.
7163
7164 2019-05-08  Tom Tromey  <tom@tromey.com>
7165
7166         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7167         (fbsd_pspace_data_handle): Move lower.  Change type.
7168         (get_fbsd_pspace_data): Update.
7169         (fbsd_pspace_data_cleanup): Remove.
7170         (_initialize_fbsd_tdep): Update.
7171
7172 2019-05-08  Tom Tromey  <tom@tromey.com>
7173
7174         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7175         (get_ada_tasks_pspace_data): Update.
7176         (ada_tasks_pspace_data_cleanup): Remove.
7177         (_initialize_tasks): Update.
7178         (ada_tasks_inferior_data_handle): Change type.
7179         (get_ada_tasks_inferior_data): Update.
7180         (ada_tasks_inferior_data_cleanup): Remove.
7181         (struct ada_tasks_pspace_data): Add initializers.
7182
7183 2019-05-08  Tom Tromey  <tom@tromey.com>
7184
7185         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7186         * symfile-debug.c (debug_sym_get_probes): Change type.
7187         * stap-probe.c (handle_stap_probe):
7188         (stap_static_probe_ops::get_probes): Change type.
7189         * probe.h (class static_probe_ops) <get_probes>: Change type.
7190         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7191         (parse_probes_in_pspace): Update.
7192         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7193         Update.
7194         (any_static_probe_ops::get_probes): Change type.
7195         * elfread.c (elfread_data): New typedef.
7196         (probe_key): Change type.
7197         (elf_get_probes): Likewise.  Update.
7198         (probe_key_free): Remove.
7199         (_initialize_elfread): Update.
7200         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7201         Change type.
7202         (dtrace_process_dof_probe, dtrace_process_dof)
7203         (dtrace_static_probe_ops::get_probe): Change type.
7204
7205 2019-05-08  Tom Tromey  <tom@tromey.com>
7206
7207         * xcoffread.c (struct xcoff_symfile_info): Rename from
7208         coff_symfile_info.  Add initializers.
7209         (xcoff_objfile_data_key): Move lower.  Change type.
7210         (XCOFF_DATA): Rewrite.
7211         (xcoff_free_info): Remove.
7212         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7213         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7214         (xcoff_initial_scan): Update.
7215
7216 2019-05-08  Tom Tromey  <tom@tromey.com>
7217
7218         * solib-svr4.c (struct svr4_info): Add initializers and
7219         destructor.
7220         <probes_table>: Now an htab_up.
7221         (solib_svr4_pspace_data): Change type.
7222         (free_probes_table): Simplify.
7223         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7224         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7225         (probes_table_remove_objfile_probes, register_solib_event_probe)
7226         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7227         (_initialize_svr4_solib): Update.
7228
7229 2019-05-08  Tom Tromey  <tom@tromey.com>
7230
7231         * remote.c (remote_pspace_data): Change type.
7232         (remote_pspace_data_cleanup): Remove.
7233         (get_remote_exec_file, set_pspace_remote_exec_file)
7234         (_initialize_remote): Update.
7235
7236 2019-05-08  Tom Tromey  <tom@tromey.com>
7237
7238         * breakpoint.c (breakpoint_objfile_key): Change type.
7239         (get_breakpoint_objfile_data): Update.
7240         (free_breakpoint_objfile_data): Remove.
7241         (_initialize_breakpoint): Update.
7242
7243 2019-05-08  Tom Tromey  <tom@tromey.com>
7244
7245         * linux-tdep.c (struct linux_info): Add initializers.
7246         (linux_inferior_data): Move.  Change type.
7247         (invalidate_linux_cache_inf): Update.
7248         (linux_inferior_data_cleanup): Remove.
7249         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7250
7251 2019-05-08  Tom Tromey  <tom@tromey.com>
7252
7253         * auxv.c (auxv_inferior_data): Move.  Change type.
7254         (auxv_inferior_data_cleanup): Remove.
7255         (invalidate_auxv_cache_inf): Rewrite.
7256         (get_auxv_inferior_data, _initialize_auxv): Update.
7257
7258 2019-05-08  Tom Tromey  <tom@tromey.com>
7259
7260         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7261         (symfile_debug_objfile_data_key): Change type.
7262         (symfile_debug_installed, debug_qf_has_symbols)
7263         (debug_qf_find_last_source_symtab)
7264         (debug_qf_forget_cached_source_info)
7265         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7266         (debug_qf_print_stats, debug_qf_dump)
7267         (debug_qf_expand_symtabs_for_function)
7268         (debug_qf_expand_all_symtabs)
7269         (debug_qf_expand_symtabs_with_fullname)
7270         (debug_qf_map_matching_symbols)
7271         (debug_qf_expand_symtabs_matching)
7272         (debug_qf_find_pc_sect_compunit_symtab)
7273         (debug_qf_map_symbol_filenames)
7274         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7275         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7276         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7277         (debug_sym_read_linetable, debug_sym_relocate): Update.
7278         (symfile_debug_free_objfile): Remove.
7279         (install_symfile_debug_logging, _initialize_symfile_debug):
7280         Update.
7281
7282 2019-05-08  Tom Tromey  <tom@tromey.com>
7283
7284         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7285         allocate_on_obstack.
7286         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7287         (get_dwarf2_per_objfile): Update.
7288         (set_dwarf2_per_objfile): Remove.
7289         (dwarf2_has_info, dwarf2_get_section_info): Update.
7290         (dwarf2_free_objfile): Remove.
7291         (_initialize_dwarf2_read): Update.
7292
7293 2019-05-08  Tom Tromey  <tom@tromey.com>
7294
7295         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7296         initializers.
7297         <unsupported_script_warning_printed,
7298         script_not_found_warning_printed>: Now bool.
7299         (auto_load_pspace_data): Change type.
7300         (~auto_load_pspace_info): Rename from
7301         auto_load_pspace_data_cleanup.
7302         (get_auto_load_pspace_data, init_loaded_scripts_info)
7303         (clear_section_scripts, maybe_print_unsupported_script_warning)
7304         (maybe_print_script_not_found_warning, _initialize_auto_load):
7305         Update.
7306
7307 2019-05-08  Tom Tromey  <tom@tromey.com>
7308
7309         * objfiles.c (objfile_pspace_info): Add destructor and
7310         initializers.
7311         (objfiles_pspace_data): Change type.
7312         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7313         (get_objfile_pspace_data): Update.
7314         (objfiles_bfd_data): Change type.
7315         (get_objfile_bfd_data): Update.
7316         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7317
7318 2019-05-08  Tom Tromey  <tom@tromey.com>
7319
7320         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7321         Change type.
7322         (get_catch_syscall_inferior_data): Update.
7323         (catch_syscall_inferior_data_cleanup): Remove.
7324         (_initialize_break_catch_syscall): Update.
7325
7326 2019-05-08  Tom Tromey  <tom@tromey.com>
7327
7328         * inflow.c (struct terminal_info): Add destructor and
7329         initializers.
7330         (inflow_inferior_data): Change type.
7331         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7332         (get_inflow_inferior_data, inflow_inferior_exit)
7333         (swap_terminal_info, _initialize_inflow): Update.
7334
7335 2019-05-08  Tom Tromey  <tom@tromey.com>
7336
7337         * target-dcache.c (target_dcache_cleanup): Remove.
7338         (target_dcache_aspace_key): Change type.
7339         (target_dcache_init_p, target_dcache_invalidate)
7340         (target_dcache_get, target_dcache_get_or_init)
7341         (_initialize_target_dcache): Update.
7342         * dcache.h (struct dcache_deleter): New.
7343
7344 2019-05-08  Tom Tromey  <tom@tromey.com>
7345
7346         * symtab.c (struct symbol_cache): Add destructor and
7347         initializers.
7348         (symbol_cache_key): Move.  Change type.
7349         (make_symbol_cache, free_symbol_cache): Remove.
7350         (get_symbol_cache): Update.
7351         (symbol_cache_cleanup): Remove.
7352         (ALL_PSPACES, symbol_cache_flush)
7353         (maintenance_print_symbol_cache)
7354         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7355         Update.
7356
7357 2019-05-08  Tom Tromey  <tom@tromey.com>
7358
7359         * symtab.c (struct main_info): Add destructor and initializers.
7360         (main_progspace_key): Move.  Change type.
7361         (get_main_info): Update.
7362         (main_info_cleanup): Remove.
7363         (_initialize_symtab): Update.
7364
7365 2019-05-08  Tom Tromey  <tom@tromey.com>
7366
7367         * registry.h (DECLARE_REGISTRY): Define the _key class.
7368
7369 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7370
7371         * NEWS: Merge two 'New commands' sections.
7372
7373 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7374
7375         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7376         parameter and use Ada language definition instead.
7377         (ada_val_print_ptr): Remove unused language parameter.
7378         (ada_val_print_num): Remove language parameter and use Ada language
7379         definition instead.
7380         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7381         parameter.
7382         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7383         parameter and use Ada language definition instead.
7384         (ada_val_print_1): Update all ada_val_print_xxx calls.
7385         Remove language parameter.
7386         (ada_val_print): Update ada_val_print_1 call.
7387
7388 2019-05-08  Tom Tromey  <tromey@adacore.com>
7389
7390         * remote.c (remote_hw_watchpoint_limit)
7391         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7392         Now static.
7393
7394 2019-05-08  Tom Tromey  <tromey@adacore.com>
7395
7396         * maint.c (_initialize_maint_cmds): Move initialization code to
7397         remote.c.
7398         (watchdog, show_watchdog): Move to remote.c.
7399         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7400         "watchdog" static.
7401         (_initialize_remote): Move initialization code from maint.c.
7402         * defs.h (watchdog): Don't declare.
7403
7404 2019-05-08  Tom Tromey  <tromey@adacore.com>
7405
7406         * tui/tui-interp.c: Include main.h.
7407         * interps.c: Include main.h.
7408         * main.h (interpreter_p): Declare.
7409         * defs.h (interpreter_p): Don't declare.
7410
7411 2019-05-08  Tom Tromey  <tromey@adacore.com>
7412
7413         * dwarf2loc.c: Include dwarf2read.h.
7414         * defs.h (read_unsigned_leb128): Don't declare.
7415         * dwarf2read.h (read_unsigned_leb128): Declare.
7416
7417 2019-05-08  Tom Tromey  <tromey@adacore.com>
7418
7419         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7420         method.
7421
7422 2019-05-08  Tom Tromey  <tromey@adacore.com>
7423
7424         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7425         when no wrap column is set.
7426
7427 2019-05-08  Tom Tromey  <tromey@adacore.com>
7428
7429         * c-lang.c (c_get_string): Handle non-C-style arrays.
7430
7431 2019-05-08  Tom Tromey  <tromey@adacore.com>
7432
7433         * typeprint.c (print_offset_data::update): Print the bit offset,
7434         not the number of bits remaining.
7435
7436 2019-05-08  Tom Tromey  <tromey@adacore.com>
7437
7438         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7439         padding at end of comment.
7440
7441 2019-05-08  Tom Tromey  <tromey@adacore.com>
7442
7443         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7444         Compare main types.
7445
7446 2019-05-06  Tom Tromey  <tom@tromey.com>
7447
7448         * common/scoped_mmap.c: Include common-defs.h.
7449         * common/scoped_mmap.h: Don't include config.h.
7450
7451 2019-05-04  Tom Tromey  <tom@tromey.com>
7452
7453         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7454         (struct aarch64_call_info): Add initializers.
7455         <si>: Now a std::vector.
7456         (pass_on_stack, aarch64_push_dummy_call): Update.
7457
7458 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7459             Tom Tromey  <tom@tromey.com>
7460
7461         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7462         (ppc_threads): Now a std::vector.  Now static.
7463         (hwdebug_find_thread_points_by_tid)
7464         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7465         Update.
7466
7467 2019-05-04  Tom Tromey  <tom@tromey.com>
7468
7469         * arc-tdep.c (arc_tdesc_init): Return bool.
7470
7471 2019-05-04  Tom Tromey  <tom@tromey.com>
7472
7473         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7474         Use gdb_assert_not_reached.
7475
7476 2019-05-04  Tom Tromey  <tom@tromey.com>
7477
7478         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7479         "false".
7480
7481 2019-05-04  Tom Tromey  <tom@tromey.com>
7482
7483         * arc-tdep.c (arc_tdesc_init): Use bool.
7484
7485 2019-05-04  Tom Tromey  <tom@tromey.com>
7486
7487         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7488
7489 2019-05-04  Tom Tromey  <tom@tromey.com>
7490
7491         * cli/cli-cmds.c (valid_command_p): Return bool.
7492
7493 2019-05-04  Tom Tromey  <tom@tromey.com>
7494
7495         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7496         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7497
7498 2019-05-04  Raul Tambre  <raul@tambre.ee>
7499
7500         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7501         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7502         operator for comparison.
7503
7504 2019-05-04  Tom Tromey  <tom@tromey.com>
7505
7506         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7507         (lookup_partial_symbol, print_partial_symbols)
7508         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7509         (psymbol_compare): Update.
7510         (add_psymbol_to_bcache): Clear the entire psymbol.
7511         (maintenance_check_psymtabs): Update.
7512         * psympriv.h (struct partial_symbol): Don't derive from
7513         general_symbol_info.
7514         <obj_section, unrelocated_address, address,
7515         set_unrelocated_address>: Update.
7516         <ginfo>: New member.
7517         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7518         (debug_names::write_psymbols): Update.
7519
7520 2019-05-04  Tom de Vries  <tdevries@suse.de>
7521
7522         * contrib/cc-with-tweaks.sh: Support -n arg.
7523
7524 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7525
7526         * corelow.c (core_target::detach): Ensure frame cache and
7527         register caches are cleared.
7528         inferior.c (exit_inferior_1): Likewise.
7529
7530 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7531             Tom Tromey  <tom@tromey.com>
7532
7533         * dictionary.c (collate_pending_symbols_by_language): Remove
7534         "struct" from foreach.
7535         * symtab.c (lookup_global_symbol_from_objfile)
7536         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7537         foreach.
7538         * ser-tcp.c (net_open): Remove "struct" from foreach.
7539         * objfiles.c (objfile_relocate, objfile_rebase)
7540         (objfile_has_symbols): Remove "struct" from foreach.
7541         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7542         from foreach.
7543         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7544         foreach.
7545         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7546         "struct" from foreach.
7547         * ada-lang.c (create_excep_cond_exprs)
7548         (ada_exception_catchpoint_cond_string): Remove "struct" from
7549         foreach.
7550
7551 2019-05-03  Tom Tromey  <tromey@adacore.com>
7552
7553         * ada-exp.y (convert_char_literal): Check suffix of each
7554         enumerator.
7555
7556 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7557
7558         PR ada/21406:
7559         * ada-exp.y (yywrap): Don't define.
7560         * ada-lex.l (%option): Add noyywrap
7561         (yywrap): Remove.
7562
7563 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7564
7565         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7566         _WIN32_WINNT to the XP level, unless already defined to a higher
7567         level.
7568
7569         * unittests/parse-connection-spec-selftests.c:
7570         * ser-tcp.c:
7571         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7572         override.
7573
7574         * symfile.c (find_separate_debug_file): Remove colon from the
7575         drive spec of DOS/Windows file names of the target, so that the
7576         file name produced from DEBUGDIR and the target's directory will
7577         be valid on DOS/Windows systems.
7578
7579 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7580
7581         * rust-lang.c (val_print_struct): Handle printing structures
7582         containing strings.
7583
7584 2019-05-02  Tom Tromey  <tromey@adacore.com>
7585
7586         * valarith.c (_initialize_valarith): Remove.
7587
7588 2019-05-01  Tom Tromey  <tromey@adacore.com>
7589
7590         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7591         bitfields.
7592
7593 2019-05-01  Tom Tromey  <tromey@adacore.com>
7594
7595         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7596         for big-endian copies.
7597
7598 2019-04-30  Ali Tamur  <tamur@google.com>
7599         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7600         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7601         (read_3_bytes): New function.
7602
7603 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7604
7605         * windows-nat.c (main_thread_id): Delete.
7606         (handle_output_debug_string): Replace main_thread_id by
7607         current_event.dwThreadId.
7608         (fake_create_process): Likewise.
7609         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7610         Do not set main_thread_id.
7611         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7612         current_event.dwThreadId.
7613         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7614
7615 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7616
7617         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7618         Use current_event.dwThreadId instead of main_thread_id.
7619
7620 2019-04-30  Tom Tromey  <tromey@adacore.com>
7621
7622         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7623         (create_excep_cond_exprs): Iterate over program spaces.
7624         (ada_exception_catchpoint_cond_string): Examine all minimal
7625         symbols for exception types.
7626
7627 2019-04-30  Tom Tromey  <tromey@adacore.com>
7628
7629         PR c++/24470:
7630         * dwarf2read.c (process_structure_scope): Handle case where type
7631         has template parameters but no symbol was created.
7632
7633 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7634             Chris January  <chris.january@arm.com>
7635
7636         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7637         qualifier.
7638         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7639
7640 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7641
7642         * f-typeprint.c (f_print_type): Update rules for printing
7643         whitespace.
7644         (f_type_print_varspec_suffix): Likewise.
7645
7646 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7647             Chris January  <chris.january@arm.com>
7648
7649         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7650         function arguments.
7651
7652 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7653
7654         * f-lang.c (build_fortran_types): Change name of void type to
7655         lower case.
7656         * f-typeprint.c (f_type_print_base): Print the name of the void
7657         type, rather than a fixed string.
7658         * f-valprint.c (f_decorations): Use lower case void string.
7659
7660 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7661             Chris January  <chris.january@arm.com>
7662
7663         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7664         types for Fortran.
7665
7666 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7667             Chris January  <chris.january@arm.com>
7668             David Lecomber  <david.lecomber@arm.com>
7669
7670         * f-exp.y (BINOP_INTRINSIC): New token.
7671         (exp): New parser rule handling BINOP_INTRINSIC.
7672         (f77_keywords): Add new builtin procedures.
7673         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7674         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7675         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7676         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7677         (print_unop_subexp_f): New function.
7678         (print_binop_subexp_f): New function.
7679         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7680         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7681         (dump_subexp_body_f): Likewise.
7682         (operator_check_f): Likewise.
7683         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7684         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7685
7686 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7687
7688         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7689         UNOP_KIND.
7690         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7691         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7692         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7693         (operator_length_f): New fuction.
7694         (print_subexp_f): New function.
7695         (op_name_f): New function.
7696         (dump_subexp_body_f): New function.
7697         (operator_check_f): New function.
7698         (exp_descriptor_f): Replace standard expression handling functions
7699         with new functions.
7700         * gdb/fortran-operator.def: New file.
7701         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7702         * gdb/std-operator.def: Remove UNOP_KIND.
7703
7704 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7705
7706         * std-operator.def: Remove unbalanced, stray double quote
7707         character.
7708
7709 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7710             Chris January  <chris.january@arm.com>
7711             Daniel Everett  <daniel.everett@arm.com>
7712             Nick Forrington  <nick.forrington@arm.com>
7713             Richard Bunt  <richard.bunt@arm.com>
7714
7715         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7716         of depth when printing anonymous structs or unions.
7717         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7718         Don't print either the top-level value, or the children if the
7719         max-depth is exceeded.
7720         (ppscm_print_children): When printing the key of a map, allow one
7721         extra level of depth.
7722         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7723         print either the top-level value, or the children if the max-depth
7724         is exceeded.
7725         (print_children): When printing the key of a map, allow one extra
7726         level of depth.
7727         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7728         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7729         (user_print_options): Initialise max_depth field.
7730         (val_print_scalar_or_string_type_p): New function.
7731         (val_print): Check to see if the max depth has been reached.
7732         (val_print_check_max_depth): Define new function.
7733         (show_print_max_depth): New function.
7734         (_initialize_valprint): Add 'print max-depth' option.
7735         * valprint.h (struct value_print_options) <max_depth>: New field.
7736         (val_print_check_max_depth): Declare new function.
7737         * NEWS: Document new feature.
7738
7739 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7740
7741         * ada-lang.c (ada_language_defn): Initialise new field.
7742         * c-lang.c (c_is_string_type_p): New function.
7743         (c_language_defn): Initialise new field.
7744         (cplus_language_defn): Initialise new field.
7745         (asm_language_defn): Initialise new field.
7746         (minimal_language_defn): Initialise new field.
7747         * c-lang.h (c_is_string_type_p): Declare new function.
7748         * d-lang.c (d_language_defn): Initialise new field.
7749         * f-lang.c (f_is_string_type_p): New function.
7750         (f_language_defn): Initialise new field.
7751         * go-lang.c (go_is_string_type_p): New function.
7752         (go_language_defn): Initialise new field.
7753         * language.c (default_is_string_type_p): New function.
7754         (unknown_language_defn): Initialise new field.
7755         (auto_language_defn): Initialise new field.
7756         * language.h (struct language_defn) <la_is_string_type_p>: New
7757         member variable.
7758         (default_is_string_type_p): Declare new function.
7759         * m2-lang.c (m2_language_defn): Initialise new field.
7760         * objc-lang.c (objc_language_defn): Initialise new field.
7761         * opencl-lang.c (opencl_language_defn): Initialise new field.
7762         * p-lang.c (pascal_is_string_type_p): New function.
7763         (pascal_language_defn): Initialise new field.
7764         * rust-lang.c (rust_is_string_type_p): New function.
7765         (rust_language_defn): Initialise new field.
7766
7767 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7768
7769         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7770         New field.
7771         * ada-lang.c (ada_language_defn): Initialise new field.
7772         * c-lang.c (c_language_defn): Likewise.
7773         (cplus_language_defn): Likewise.
7774         (asm_language_defn): Likewise.
7775         (minimal_language_defn): Likewise.
7776         * d-lang.c (d_language_defn): Likewise.
7777         * f-lang.c (f_language_defn): Likewise.
7778         * go-lang.c (go_language_defn): Likewise.
7779         * language.c (unknown_language_defn): Likewise.
7780         (auto_language_defn): Likewise.
7781         * m2-lang.c (m2_language_defn): Likewise.
7782         * objc-lang.c (objc_language_defn): Likewise.
7783         * opencl-lang.c (opencl_language_defn): Likewise.
7784         * p-lang.c (pascal_language_defn): Likewise.
7785         * rust-lang.c (rust_language_defn): Likewise.
7786
7787 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7788
7789         * ada-lang.c (ada_is_character_type): Change return type to bool.
7790         (ada_is_string_type): Likewise.
7791         * ada-lang.h (ada_is_character_type): Update declaration
7792         (ada_is_string_type): Likewise.
7793
7794 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7795
7796         Support style in 'frame|thread apply'
7797
7798         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7799         * record.c (record_start, record_stop): Update callers of
7800         execute_command_to_string with false.
7801         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7802         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7803         methods.
7804         (class string_file): New constructor with term_out parameter.
7805         Override methods term_out and can_emit_style_escape.  New member
7806         term_out.
7807         (class stdio_file): Override can_emit_style_escape.
7808         (class tee_file): Override term_out and can_emit_style_escape.
7809         * utils.h (can_emit_style_escape): Remove.
7810         * utils.c (can_emit_style_escape): Likewise.
7811         Update all callers of can_emit_style_escape (SOMESTREAM) to
7812         SOMESTREAM->can_emit_style_escape.
7813         * source-cache.c (source_cache::get_source_lines): Likewise.
7814         * stack.c (frame_apply_command_count): Call execute_command_to_string
7815         passing the term_out characteristic of the current gdb_stdout.
7816         * thread.c (thr_try_catch_cmd): Likewise.
7817         * top.c (execute_command_to_string): pass term_out parameter
7818         to construct the string_file for the command output.
7819         * ui-file.c (term_cli_styling): New function (most code moved
7820         from utils.c can_emit_style_escape).
7821         (string_file::string_file, string_file::can_emit_style_escape,
7822         stdio_file::can_emit_style_escape, tee_file::term_out,
7823         tee_file::can_emit_style_escape): New functions.
7824
7825 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7826
7827         * NEWS: Mention the new set|show may-call-functions.
7828         * infcall.c (may_call_functions_p): New variable.
7829         (show_may_call_functions_p): New function.
7830         (call_function_by_hand_dummy): Throws an error if not
7831         may-call-functions.
7832         (_initialize_infcall): Call add_setshow_boolean_cmd for
7833         may-call-functions.
7834
7835 2019-04-25  Keith Seitz  <keiths@redhat.com>
7836
7837         PR c++/24367
7838         * cp-support.c (inspect_type): Don't attempt substitutions
7839         of symbol with the same name.
7840
7841 2019-04-25  Tom Tromey  <tromey@adacore.com>
7842
7843         PR gdb/24475:
7844         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7845         static.
7846
7847 2019-04-25  Tom Tromey  <tromey@adacore.com>
7848
7849         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7850         rvalue reference.
7851         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7852         (gdb_xml_parser::parse): Use std::move.
7853         * python/python-internal.h (gdbpy_convert_exception): Take a const
7854         reference.
7855         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7856         std::move.
7857         * python/py-utils.c (gdbpy_convert_exception): Take a const
7858         reference.
7859         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7860         Use std::move.
7861         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7862         Use std::move.
7863         * mi/mi-main.c (mi_print_exception): Take a const reference.
7864         * main.c (handle_command_errors): Take a const reference.
7865         * linespec.c (parse_linespec): Use std::move.
7866         * infcall.c (run_inferior_call): Use std::move.
7867         (call_function_by_hand_dummy): Use std::move.
7868         * exec.c (try_open_exec_file): Use std::move.
7869         * exceptions.h (exception_print, exception_fprintf)
7870         (exception_print_same): Update.
7871         * exceptions.c (print_exception, exception_print)
7872         (exception_fprintf, exception_print_same): Change parameters to
7873         const reference.
7874         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7875         * common/new-op.c: Use std::move.
7876         * common/common-exceptions.h (struct gdb_exception): Add move
7877         constructor.
7878         (struct gdb_exception_error, struct gdb_exception_quit, struct
7879         gdb_quit_bad_alloc): Change constructor to move constructor.
7880         (throw_exception): Change parameter to rvalue reference.
7881         * common/common-exceptions.c (throw_exception): Take rvalue
7882         reference.
7883         * cli/cli-interp.c (safe_execute_command): Use std::move.
7884         * breakpoint.c (insert_bp_location, location_to_sals): Use
7885         std::move.
7886
7887 2019-04-25  Tom Tromey  <tromey@adacore.com>
7888
7889         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7890         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7891         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7892         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7893         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7894         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7895         guile/scm-value.c: Use unpack.
7896         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7897         gdbscm_gdb_exception.
7898         (gdbscm_throw_gdb_exception): Likewise.
7899         (struct gdbscm_gdb_exception): New.
7900         (unpack): New function.
7901         (gdbscm_wrap): Use unpack.
7902
7903 2019-04-25  Tom Tromey  <tromey@adacore.com>
7904
7905         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7906         (gdb_rl_callback_handler): Use std::move.
7907         * common/common-exceptions.h (struct gdb_exception): Add move
7908         assignment operator.
7909         (throw_exception_sjlj): Change "exception" to const reference.
7910         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7911         (throw_exception_sjlj): Change "exception" to const reference.
7912
7913 2019-04-25  Tom Tromey  <tromey@adacore.com>
7914
7915         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7916         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7917         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7918         Update.
7919         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7920         Update.
7921         * mi/mi-interp.c (mi_interp::exec): Update.
7922         * linespec.c (parse_linespec): Update.
7923         * infcall.c (run_inferior_call): Update.
7924         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7925         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7926         (gdbscm_lookup_global_symbol): Update.
7927         * guile/scm-param.c (gdbscm_parameter_value): Update.
7928         * guile/scm-frame.c (gdbscm_frame_read_register)
7929         (gdbscm_frame_read_var): Update.
7930         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7931         * exec.c (try_open_exec_file): Update.
7932         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7933         (gdb_rl_callback_handler): Update.
7934         * common/common-exceptions.h (exception_none): Don't declare.
7935         * common/common-exceptions.c (exception_none): Don't define.
7936         (struct catcher) <exception>: Update.
7937         * cli/cli-interp.c (safe_execute_command): Update.
7938         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7939
7940 2019-04-25  Ali Tamur  <tamur@google.com>
7941
7942         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7943         (read_attribute_value): Likewise.
7944         (dwarf2_read_addr_index): Update comment.
7945         (read_str_index): Add DW_FORM_strx.
7946         (dwarf2_string_attr): Likewise.
7947         (dwarf2_const_value_attr): Likewise.
7948         (dump_die_shallow): Likewise.
7949         (dwarf2_fetch_constant_bytes): Likewise.
7950         (skip_form_bytes): Likewise.
7951         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7952
7953 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7954
7955         PR corefiles/11608
7956         PR corefiles/18187
7957         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7958         OFFSET.  Verify if current mapping contains an ELF header.
7959         (linux_find_memory_regions_full): Adjust call to
7960         dump_mapping_p.
7961
7962 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7963             Kang Li <kanglictf@gmail.com>
7964
7965         PR gdb/21600
7966
7967         * dwarf2-frame.c (read_initial_length): Be consistent about using
7968         unsigned representation of length.
7969         (decode_frame_entry_1): Likewise.  Check for wraparound of
7970         end pointer as well as buffer overflow.
7971
7972 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7973
7974         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7975         "vq".
7976
7977 2019-04-24  Tom Tromey  <tromey@adacore.com>
7978
7979         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7980
7981 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7982
7983         * s12z-tdep.c (s12z_unwind_pc): Delete.
7984         (s12z_unwind_sp): Delete.
7985         (s12z_gdbarch_init): Don't register deleted functions with
7986         gdbarch.
7987
7988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7989
7990         * rl78-tdep.c (rl78_unwind_sp): Delete.
7991         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7992
7993 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7994
7995         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7996         (xstormy16_unwind_pc): Delete.
7997         (xstormy16_dummy_id): Delete.
7998         (xstormy16_gdbarch_init): Don't register deleted functions with
7999         gdbarch.
8000
8001 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8002
8003         * vax-tdep.c (vax_unwind_pc): Delete.
8004         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8005
8006 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8007
8008         * v850-tdep.c (v850_unwind_sp): Delete.
8009         (v850_unwind_pc): Delete.
8010         (v850_dummy_id): Delete.
8011         (v850_gdbarch_init): Don't register deleted functions with
8012         gdbarch.
8013
8014 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8015
8016         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8017         (tilegx_unwind_pc): Delete.
8018         (tilegx_unwind_dummy_id): Delete.
8019         (tilegx_gdbarch_init): Don't register deleted functions with
8020         gdbarch.
8021
8022 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8023
8024         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8025         (tic6x_dummy_id): Delete.
8026         (tic6x_gdbarch_init): Don't register deleted functions with
8027         gdbarch.
8028
8029 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8030
8031         * sparc-tdep.c (sparc_unwind_pc): Delete.
8032         (sparc32_gdbarch_init): Don't register deleted function with
8033         gdbarch.
8034
8035 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8036
8037         * sh-tdep.c (sh_unwind_sp): Delete.
8038         (sh_unwind_pc): Delete.
8039         (sh_dummy_id): Delete.
8040         (sh_gdbarch_init): Don't register deleted functions with
8041         gdbarch.
8042
8043 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8044
8045         * score-tdep.c (score_unwind_sp): Delete.
8046         (score_unwind_pc): Delete.
8047         (score_dummy_id): Delete.
8048         (score_gdbarch_init): Don't register deleted functions with
8049         gdbarch.
8050
8051 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8052
8053         * rx-tdep.c (rx_unwind_pc): Delete.
8054         (rx_unwind_sp): Delete.
8055         (rx_dummy_id): Delete.
8056         (rx_gdbarch_init): Don't register deleted functions with
8057         gdbarch.  Update comment.
8058
8059 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8060
8061         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8062         (rs6000_dummy_id): Delete.
8063         (rs6000_gdbarch_init): Don't register deleted functions with
8064         gdbarch.
8065
8066 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8067
8068         * or1k-tdep.c (or1k_dummy_id): Delete.
8069         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8070
8071 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8072
8073         * nios2-tdep.c (nios2_dummy_id): Delete.
8074         (nios2_unwind_sp): Delete.
8075         (nios2_gdbarch_init): Don't register deleted functions with
8076         gdbarch.
8077
8078 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8079
8080         * nds32-tdep.c (nds32_dummy_id): Delete.
8081         (nds32_unwind_pc): Delete.
8082         (nds32_unwind_sp): Delete.
8083         (nds32_gdbarch_init): Don't register deleted functions with
8084         gdbarch.
8085
8086 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8087
8088         * msp430-tdep.c (msp430_unwind_pc): Delete.
8089         (msp430_unwind_sp): Delete.
8090         (msp430_dummy_id): Delete.
8091         (msp430_gdbarch_init): Don't register deleted functions with
8092         gdbarch.
8093
8094 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8095
8096         * moxie-tdep.c (moxie_unwind_sp): Delete.
8097         (moxie_unwind_pc): Delete.
8098         (moxie_dummy_id): Delete.
8099         (moxie_gdbarch_init): Don't register deleted functions with
8100         gdbarch.
8101
8102 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8103
8104         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8105         (mn10300_unwind_pc): Delete.
8106         (mn10300_unwind_sp): Delete.
8107         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8108         mn10300_unwind_sp.
8109         (mn10300_frame_unwind_init): Don't register deleted functions with
8110         gdbarch.
8111
8112 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8113
8114         * mep-tdep.c (mep_unwind_pc): Delete.
8115         (mep_unwind_sp): Delete.
8116         (mep_dummy_id): Delete.
8117         (mep_gdbarch_init): Don't register deleted functions with
8118         gdbarch.
8119
8120 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8121
8122         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8123         (m68hc11_unwind_sp): Delete.
8124         (m68hc11_gdbarch_init): Don't register deleted functions with
8125         gdbarch.
8126
8127 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8128
8129         * m32r-tdep.c (m32r_unwind_sp): Delete.
8130         (m32r_unwind_pc): Delete.
8131         (m32r_dummy_id): Delete.
8132         (m32r_gdbarch_init): Don't register deleted functions with
8133         gdbarch.
8134
8135 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8136
8137         * m32c-tdep.c (m32c_unwind_pc): Delete.
8138         (m32c_unwind_sp): Delete.
8139         (m32c_dummy_id): Delete.
8140         (m32c_gdbarch_init): Don't register deleted functions with
8141         gdbarch.
8142
8143 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8144
8145         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8146         (lm32_unwind_pc): Delete.
8147         (lm32_dummy_id): Delete.
8148         (lm32_gdbarch_init): Don't register deleted functions with
8149         gdbarch.
8150
8151 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8152
8153         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8154         (iq2000_unwind_pc): Delete.
8155         (iq2000_dummy_id): Delete.
8156         (iq2000_gdbarch_init): Don't register deleted functions with
8157         gdbarch.
8158
8159 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8160
8161         * nds32-tdep.c (nds32_type_align): Delete.
8162         (nds32_push_dummy_call): Use type_align instead.
8163
8164 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8165
8166         * arm-tdep.c (arm_type_align): Only handle vector override case.
8167         (arm_push_dummy_call): Use type_align.
8168         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8169
8170 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8171
8172         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8173         case.
8174         (pass_on_stack): Use type_align.
8175         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8176         function.
8177
8178 2019-04-23  Tom Tromey  <tromey@adacore.com>
8179
8180         * dwarf2read.c (line_header::file_name_at): Remove unused
8181         overload.
8182
8183 2019-04-23  Tom de Vries  <tdevries@suse.de>
8184
8185         PR gdb/24438
8186         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8187         invocation.
8188
8189
8190 2019-03-27  Ali Tamur  <tamur@google.com>
8191
8192         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8193         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8194         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8195         (dwarf_expr_context::get_addr_index): Likewise
8196         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8197         (symbol_needs_eval_context::get_addr_index): Likewise
8198         (disassemble_dwarf_expression): Add DW_OP_addrx
8199         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8200         (read_cutu_die_from_dwo): Update comment
8201         (skip_one_die): Add DW_FORM_addrx
8202         (read_attribute_value): Likewise
8203         (var_decode_location): Add DW_OP_addrx
8204         (dwarf2_const_value_attr): Add DW_FORM_addrx
8205         (dump_die_shallow): Likewise
8206         (dwarf2_fetch_constant_bytes): Likewise
8207         (decode_locdesc): Add DW_OP_addrx
8208         (skip_form_bytes): Add DW_FORM_addrx
8209
8210 2019-04-22  Ali Tamur  <tamur@google.com>
8211
8212         * MAINTAINERS (Write After Approval): Add self.
8213
8214 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8215
8216         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8217         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8218         (open_symbol_file_object): Likewise.
8219         (svr4_default_sos): Add info parameter.
8220         (svr4_read_so_list): Likewise.
8221         (svr4_current_sos_direct): Adjust functions calls to pass down
8222         info.
8223         (svr4_current_sos_1): Add info parameter.
8224         (svr4_current_sos): Call get_svr4_info, pass info down to
8225         svr4_current_sos_1.
8226         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8227         get_svr4_info.
8228         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8229         get_svr4_info.
8230         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8231         to get_svr4_info.
8232         (probes_table_remove_objfile_probes): Likewise.
8233         (register_solib_event_probe): Add info parameter.
8234         (solist_update_incremental): Pass info parameter down to
8235         svr4_read_so_list.
8236         (disable_probes_interface): Add info parameter.
8237         (svr4_handle_solib_event): Pass current_program_space to
8238         get_svr4_info.  Adjust disable_probes_interface cleanup.
8239         (svr4_create_probe_breakpoints): Add info parameter, pass it
8240         down to register_solib_event_probe.
8241         (svr4_create_solib_event_breakpoints): Add info parameter,
8242         pass it down to svr4_create_probe_breakpoints.
8243         (enable_break): Pass info down to
8244         svr4_create_solib_event_breakpoints.
8245         (svr4_solib_create_inferior_hook): Pass current_program_space to
8246         get_svr4_info.
8247         (svr4_clear_solib): Likewise.
8248
8249 2019-04-22  Pedro Alves  <palves@redhat.com>
8250
8251         * solib-svr4.c (svr4_free_objfile_observer): New.
8252         (probe_and_action::objfile): New field.
8253         (probes_table_htab_remove_objfile_probes)
8254         (probes_table_remove_objfile_probes): New functions.
8255         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8256         in the new probe_and_action.  Don't store the probe in 'lookup'.
8257         (svr4_create_probe_breakpoints): Pass objfile to
8258         register_solib_event_probe.
8259         (_initialize_svr4_solib): Register a free_objfile observer.
8260
8261 2019-04-19  Tom Tromey  <tom@tromey.com>
8262
8263         * common/queue.h: Remove.
8264
8265 2019-04-19  Tom Tromey  <tom@tromey.com>
8266
8267         * event-loop.c: Don't include "common/queue.h".
8268
8269 2019-04-19  Tom Tromey  <tom@tromey.com>
8270
8271         * remote.c (remote_target): Use delete.
8272         * remote-notif.h: Include <list>, not "common/queue.h".
8273         (notif_client_p): Remove typedef.
8274         (remote_notif_state): Add constructor, destructor, initializer.
8275         <notif_queue>: Now a std::list.
8276         (remote_notif_state_xfree): Don't declare.
8277         * remote-notif.c (remote_notif_process, handle_notification)
8278         (remote_notif_state_allocate): Update.
8279         (~remote_notif_state): Rename from remote_notif_state_xfree.
8280
8281 2019-04-19  Tom Tromey  <tom@tromey.com>
8282
8283         * symfile.c (reread_symbols): Update.
8284         * objfiles.c (objfile_register_static_link)
8285         (objfile_lookup_static_link): Update
8286         (~objfile) Don't delete static_links.
8287         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8288
8289 2019-04-19  Tom Tromey  <tom@tromey.com>
8290
8291         * type-stack.h (struct type_stack) <insert>: Constify string.
8292         * type-stack.c (type_stack::insert): Constify string.
8293         * gdbtypes.h (lookup_template_type): Update.
8294         (address_space_name_to_int): Update.
8295         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8296         const.
8297         (lookup_template_type): Make name const.
8298         * c-exp.y: Update rules.
8299         (lex_one_token, classify_name, classify_inner_name)
8300         (c_print_token): Update.
8301         * p-exp.y: Update rules.
8302         (yylex): Update.
8303         * f-exp.y: Update rules.
8304         (yylex): Update.
8305         * d-exp.y: Update rules.
8306         (lex_one_token, classify_name, classify_inner_name): Update.
8307         * parse.c (write_dollar_variable, copy_name): Return std::string.
8308         * parser-defs.h (copy_name): Change return type.
8309         * m2-exp.y: Update rules.
8310         (yylex): Update.
8311         * go-exp.y (lex_one_token): Update.
8312         Update rules.
8313         (classify_unsafe_function, classify_packaged_name)
8314         (classify_name, yylex): Update.
8315
8316 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8317
8318         * configure.ac: add --enable-source-highlight switch.
8319         * configure: Regenerate.
8320         * top.c (print_gdb_version): plumb --enable-source-highlight
8321         status to "show configuration".
8322
8323 2019-04-19  Tom Tromey  <tromey@adacore.com>
8324
8325         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8326         Check ADA_TYPE_P.
8327         (empty_record, ada_template_to_fixed_record_type_1)
8328         (template_to_static_fixed_type)
8329         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8330         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8331         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8332         macros.
8333
8334 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8335
8336         PR symtab/24423:
8337         * source.c (print_source_lines_base): Advance "iter" when a
8338         control character is seen.
8339
8340 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8341
8342         * inferior.h (struct infcall_suspend_state_deleter):
8343         Catch exception in destructor to avoid crash.
8344
8345 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8346
8347         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8348         close to the add_com "shell".
8349
8350 2019-04-18  Tom Tromey  <tromey@adacore.com>
8351
8352         * process-stratum-target.h (class process_stratum_target)
8353         <stratum>: Add "final".
8354
8355 2019-04-17  Tom Tromey  <tromey@adacore.com>
8356
8357         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8358         against nullptr before use.
8359
8360 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8361
8362         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8363
8364 2019-04-17  Jim Wilson  <jimw@sifive.com>
8365             Andrew Burgess  <andrew.burgess@embecosm.com>
8366
8367         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8368         code read might fail, assume 4-byte breakpoint in that case.
8369
8370 2019-04-15  Leszek Swirski  <leszeks@google.com>
8371
8372         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8373         rather than a hand-rolled POD check when checking for forced MEMORY
8374         classification.
8375
8376 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8377
8378         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8379         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8380         function.
8381         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8382         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8383         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8384         declaration.
8385
8386 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8387
8388         * aarch64-linux-nat.c
8389         (aarch64_linux_nat_target::thread_architecture): Add override.
8390         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8391         each VQ.
8392
8393 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8394
8395         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8396
8397 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8398
8399         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8400         target types of size 96-bits, add some additional comments, and
8401         check that the builtin type we found was the correct size.
8402
8403 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8404
8405         * utils.c (prompt_for_continue): Don't restore the styling at the
8406         end, as applied_style has the wrong value.  This fixes styling in
8407         long lists of file names that are interrupted by the "Continue?"
8408         prompt.
8409
8410 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8411
8412         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8413         * c-lang.c (c_language_defn): Likewise.
8414         (cplus_language_defn): Likewise.
8415         (asm_language_defn): Likewise.
8416         (minimal_language_defn): Likewise.
8417         * d-lang.c (d_language_defn): Likewise.
8418         * f-lang.c (f_language_defn): Likewise.
8419         * go-lang.c (go_language_defn): Likewise.
8420         * language.c (unknown_language_defn): Likewise.
8421         (auto_language_defn): Likewise.
8422         * language.h (struct language_defn): Remove la_magic field.
8423         (LANG_MAGIC): Delete.
8424         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8425         * objc-lang.c (objc_language_defn): Likewise.
8426         * opencl-lang.c (opencl_language_defn): Likewise.
8427         * p-lang.c (pascal_language_defn): Likewise.
8428         * rust-lang.c (rust_language_defn): Likewise.
8429
8430 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8431
8432         * riscv-tdep.c (riscv_type_align): New function.
8433         (riscv_type_alignment): Delete.
8434         (riscv_arg_location): Use 'type_align'.
8435         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8436
8437 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8438
8439         * gdbtypes.c (type_align): A struct with no non-static fields also
8440         has alignment of 1.
8441
8442 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8443
8444         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8445         component to 0.
8446         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8447         member.
8448         (riscv_struct_info::analyse): New implementation using new
8449         analyse_inner member function.
8450         (riscv_struct_info::field_offset): New member function.
8451         (riscv_struct_info::m_offsets): New member variable.
8452         (riscv_struct_info::analyse_inner): New private member function,
8453         takes the old implementation of riscv_struct_info::analyse but
8454         extended to track field offsets.
8455         (riscv_call_arg_struct): Update the struct folding special cases
8456         to handle cases where empty C++ structs, which are non-zero
8457         length, are found.
8458         (riscv_arg_location): Initialise the length of each location, a
8459         non-zero length now indicates the location is in use.
8460         (riscv_push_dummy_call): Allow for the first location having a
8461         non-zero offset when setting up arguments.
8462         (riscv_return_value): Likewise, but for return values.
8463
8464 2019-04-11  Tom Tromey  <tromey@adacore.com>
8465
8466         * utils.c (internal_vproblem): Make "msg" const.
8467
8468 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8469
8470         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8471         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8472         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8473         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8474
8475 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8476
8477         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8478         function.
8479         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8480         of amd64_collect_native_gregset.
8481         (amd64_linux_nat_target::store_registers): Likewise.
8482
8483 2019-04-10  Tom Tromey  <tom@tromey.com>
8484
8485         * symtab.c (lookup_global_symbol_from_objfile)
8486         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8487         * objfiles.h (class separate_debug_iterator): New.
8488         (class separate_debug_range): New.
8489         (struct objfile) <separate_debug_objfiles>: New method.
8490         (objfile_separate_debug_iterate): Don't declare.
8491         * objfiles.c (separate_debug_iterator::operator++): Rename from
8492         objfile_separate_debug_iterate.
8493         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8494         iterator.
8495         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8496         iterator.
8497
8498 2019-04-10  Tom Tromey  <tom@tromey.com>
8499
8500         * symfile.c (reread_symbols): Remove old comment.
8501         * objfiles.c (free_all_objfiles): Fix a typo.
8502
8503 2019-04-10  Tom Tromey  <tom@tromey.com>
8504
8505         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8506         * minsyms.c (lookup_minimal_symbol): Use foreach.
8507         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8508         (lookup_minimal_symbol_solib_trampoline): Likewise.
8509         * symfile.c (reread_symbols): Use foreach.
8510
8511 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8512             Tom Tromey  <tromey@adacore.com>
8513
8514         PR rust/24414:
8515         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8516         (rust_lex_int_test): Change "value" to be LONGEST.
8517         (rust_lex_tests): Add test for long integer literal.
8518
8519 2019-04-09  Tom Tromey  <tromey@adacore.com>
8520
8521         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8522         to bool.
8523         (extended_remote_target::attach): Update.
8524         (remote_target::remote_notice_new_inferior): Update.
8525         (remote_target::add_current_inferior_and_thread): Update.
8526         * inferior.c (exit_inferior_1): Use "false".
8527         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8528
8529 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8530
8531         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8532         the "start" command.
8533
8534 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8535
8536         * python/py-inferior.c (infpy_thread_from_thread_handle):
8537         Adjust comments to reflect renaming of thread_from_thread_handle
8538         to thread_from_handle.  Adjust keywords.  Fix type error message.
8539         (inferior_object_methods): Add thread_from_handle.  Retain
8540         thread_from_thread_handle, but mark it as deprecated.
8541
8542 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8543
8544         * gdbthread.h (find_thread_by_handle): Revise declaration.
8545         * thread.c (find_thread_by_handle): Likewise.  Adjust
8546         implementation too.
8547         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8548         support for buffer objects as handles.
8549
8550 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8551
8552         * python/py-infthread.c (thpy_thread_handle): New function.
8553         (thread_object_methods): Register thpy_thread_handle.
8554
8555 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8556
8557         * gdbthread.h (thread_to_thread_handle): Declare.
8558         * thread.c (gdbtypes.h): Include.
8559         (thread_to_thread_handle): New function.
8560
8561         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8562         (target_thread_info_to_thread_handle): Declare.
8563         * target.c (target_thread_info_to_thread_handle): New function.
8564         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8565         * target-delegates.c: Regenerate.
8566
8567         * linux-thread-db.c (class thread_db_target): Add method
8568         thread_info_to_thread_handle.
8569         (thread_db_target::thread_info_to_thread_handle): Define.
8570         * remote.c (class remote_target): Add new method
8571         thread_info_to_thread_handle.
8572         (remote_target::thread_info_to_thread_handle): Define.
8573
8574 2019-04-08  Pedro Alves  <palves@redhat.com>
8575
8576         * common/common-exceptions.c (throw_exception): Don't create
8577         named object to throw; throw directly.
8578         (throw_it): Likewise.  Don't initialize gdb_exception::message
8579         here, with new; pass FMT and AP to the ctor instead.
8580         * common/common-exceptions.h: Include <string>.
8581         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8582         const char *, va_list)): New ctor.  Use std::make_shared.
8583         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8584         errors)): Delete.
8585         (gdb_exception_error::gdb_exception_error(enum errors, const char
8586         *, va_list)): New.
8587         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8588         Add assertion.
8589         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8590         errors)): Delete.
8591         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8592         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8593         Add assertion.
8594
8595 2019-04-08  Tom Tromey  <tom@tromey.com>
8596
8597         * valops.c (value_rtti_indirect_type): Replace throw_exception
8598         with throw.
8599         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8600         with throw.
8601         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8602         throw.
8603         * target.c (target_translate_tls_address): Replace throw_exception
8604         with throw.
8605         * stack.c (frame_apply_command_count): Replace throw_exception
8606         with throw.
8607         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8608         throw.
8609         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8610         with throw.
8611         * rs6000-tdep.c (rs6000_frame_cache)
8612         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8613         * remote.c: Replace throw_exception with throw.
8614         * record-full.c (record_full_message, record_full_wait_1)
8615         (record_full_restore): Replace throw_exception with throw.
8616         * record-btrace.c:
8617         (get_thread_current_frame_id, record_btrace_start_replaying)
8618         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8619         (cmd_record_btrace_start): Replace throw_exception with throw.
8620         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8621         throw.
8622         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8623         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8624         * linespec.c:
8625         (find_linespec_symbols): Replace throw_exception with throw.
8626         * infrun.c (displaced_step_prepare, resume): Replace
8627         throw_exception with throw.
8628         * infcmd.c (post_create_inferior): Replace throw_exception with
8629         throw.
8630         * inf-loop.c (inferior_event_handler): Replace throw_exception
8631         with throw.
8632         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8633         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8634         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8635         (get_prev_frame_always, get_frame_pc_if_available)
8636         (get_frame_address_in_block_if_available, get_frame_language):
8637         Replace throw_exception with throw.
8638         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8639         throw_exception with throw.
8640         * eval.c (fetch_subexp_value, evaluate_var_value)
8641         (evaluate_funcall, evaluate_subexp_standard): Replace
8642         throw_exception with throw.
8643         * dwarf2loc.c (call_site_find_chain)
8644         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8645         Replace throw_exception with throw.
8646         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8647         with throw.
8648         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8649         throw.
8650         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8651         * completer.c (complete_line_internal): Replace throw_exception
8652         with throw.
8653         * compile/compile-object-run.c (compile_object_run): Replace
8654         throw_exception with throw.
8655         * cli/cli-script.c (process_next_line): Replace throw_exception
8656         with throw.
8657         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8658         (btrace_enable, btrace_maint_update_pt_packets): Replace
8659         throw_exception with throw.
8660         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8661         throw_exception with throw.
8662         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8663         throw_exception with throw.
8664         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8665         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8666         * aarch64-tdep.c (aarch64_make_prologue_cache)
8667         (aarch64_make_stub_cache): Replace throw_exception with throw.
8668
8669 2019-04-08  Tom Tromey  <tom@tromey.com>
8670
8671         * common/common-exceptions.c (throw_exception): Rename from
8672         throw_exception_cxx.  Remove old copy.  Make argument const.
8673         (throw_it): Create and throw exception objects directly.
8674         * common/common-exceptions.h (throw_exception): Make argument
8675         const.
8676         (struct gdb_exception_error): Add constructor.
8677         (struct gdb_exception_quit): Add constructor.
8678
8679 2019-04-08  Tom Tromey  <tom@tromey.com>
8680
8681         * common/common-exceptions.h (exception_rethrow): Don't declare.
8682         (TRY_SJLJ): Update comment.
8683         (TRY, CATCH, END_CATCH): Remove.
8684         * common/common-exceptions.c (exception_rethrow): Remove.
8685
8686 2019-04-08  Tom Tromey  <tom@tromey.com>
8687
8688         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8689         Remove.
8690         (gdb_exception_error): Rename from
8691         gdb_exception_RETURN_MASK_ERROR.
8692         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8693         (gdb_quit_bad_alloc): Update.
8694         * aarch64-tdep.c: Update.
8695         * ada-lang.c: Update.
8696         * ada-typeprint.c: Update.
8697         * ada-valprint.c: Update.
8698         * amd64-tdep.c: Update.
8699         * arch-utils.c: Update.
8700         * break-catch-throw.c: Update.
8701         * breakpoint.c: Update.
8702         * btrace.c: Update.
8703         * c-varobj.c: Update.
8704         * cli/cli-cmds.c: Update.
8705         * cli/cli-interp.c: Update.
8706         * cli/cli-script.c: Update.
8707         * common/common-exceptions.c: Update.
8708         * common/new-op.c: Update.
8709         * common/selftest.c: Update.
8710         * compile/compile-c-symbols.c: Update.
8711         * compile/compile-cplus-symbols.c: Update.
8712         * compile/compile-object-load.c: Update.
8713         * compile/compile-object-run.c: Update.
8714         * completer.c: Update.
8715         * corelow.c: Update.
8716         * cp-abi.c: Update.
8717         * cp-support.c: Update.
8718         * cp-valprint.c: Update.
8719         * darwin-nat.c: Update.
8720         * disasm-selftests.c: Update.
8721         * dtrace-probe.c: Update.
8722         * dwarf-index-cache.c: Update.
8723         * dwarf-index-write.c: Update.
8724         * dwarf2-frame-tailcall.c: Update.
8725         * dwarf2-frame.c: Update.
8726         * dwarf2loc.c: Update.
8727         * dwarf2read.c: Update.
8728         * eval.c: Update.
8729         * event-loop.c: Update.
8730         * event-top.c: Update.
8731         * exec.c: Update.
8732         * f-valprint.c: Update.
8733         * fbsd-tdep.c: Update.
8734         * frame-unwind.c: Update.
8735         * frame.c: Update.
8736         * gdbtypes.c: Update.
8737         * gnu-v3-abi.c: Update.
8738         * guile/guile-internal.h: Update.
8739         * guile/scm-block.c: Update.
8740         * guile/scm-breakpoint.c: Update.
8741         * guile/scm-cmd.c: Update.
8742         * guile/scm-disasm.c: Update.
8743         * guile/scm-frame.c: Update.
8744         * guile/scm-lazy-string.c: Update.
8745         * guile/scm-math.c: Update.
8746         * guile/scm-param.c: Update.
8747         * guile/scm-ports.c: Update.
8748         * guile/scm-pretty-print.c: Update.
8749         * guile/scm-symbol.c: Update.
8750         * guile/scm-symtab.c: Update.
8751         * guile/scm-type.c: Update.
8752         * guile/scm-value.c: Update.
8753         * i386-linux-tdep.c: Update.
8754         * i386-tdep.c: Update.
8755         * inf-loop.c: Update.
8756         * infcall.c: Update.
8757         * infcmd.c: Update.
8758         * infrun.c: Update.
8759         * jit.c: Update.
8760         * language.c: Update.
8761         * linespec.c: Update.
8762         * linux-fork.c: Update.
8763         * linux-nat.c: Update.
8764         * linux-tdep.c: Update.
8765         * linux-thread-db.c: Update.
8766         * main.c: Update.
8767         * mi/mi-cmd-break.c: Update.
8768         * mi/mi-cmd-stack.c: Update.
8769         * mi/mi-interp.c: Update.
8770         * mi/mi-main.c: Update.
8771         * objc-lang.c: Update.
8772         * p-valprint.c: Update.
8773         * parse.c: Update.
8774         * ppc-linux-tdep.c: Update.
8775         * printcmd.c: Update.
8776         * python/py-arch.c: Update.
8777         * python/py-breakpoint.c: Update.
8778         * python/py-cmd.c: Update.
8779         * python/py-finishbreakpoint.c: Update.
8780         * python/py-frame.c: Update.
8781         * python/py-framefilter.c: Update.
8782         * python/py-gdb-readline.c: Update.
8783         * python/py-inferior.c: Update.
8784         * python/py-infthread.c: Update.
8785         * python/py-lazy-string.c: Update.
8786         * python/py-linetable.c: Update.
8787         * python/py-objfile.c: Update.
8788         * python/py-param.c: Update.
8789         * python/py-prettyprint.c: Update.
8790         * python/py-progspace.c: Update.
8791         * python/py-record-btrace.c: Update.
8792         * python/py-record.c: Update.
8793         * python/py-symbol.c: Update.
8794         * python/py-type.c: Update.
8795         * python/py-unwind.c: Update.
8796         * python/py-utils.c: Update.
8797         * python/py-value.c: Update.
8798         * python/python.c: Update.
8799         * record-btrace.c: Update.
8800         * record-full.c: Update.
8801         * remote-fileio.c: Update.
8802         * remote.c: Update.
8803         * riscv-tdep.c: Update.
8804         * rs6000-aix-tdep.c: Update.
8805         * rs6000-tdep.c: Update.
8806         * rust-exp.y: Update.
8807         * rust-lang.c: Update.
8808         * s390-tdep.c: Update.
8809         * selftest-arch.c: Update.
8810         * solib-dsbt.c: Update.
8811         * solib-frv.c: Update.
8812         * solib-spu.c: Update.
8813         * solib-svr4.c: Update.
8814         * solib.c: Update.
8815         * sparc64-linux-tdep.c: Update.
8816         * stack.c: Update.
8817         * symfile-mem.c: Update.
8818         * symmisc.c: Update.
8819         * target.c: Update.
8820         * thread.c: Update.
8821         * top.c: Update.
8822         * tracefile-tfile.c: Update.
8823         * tui/tui.c: Update.
8824         * typeprint.c: Update.
8825         * unittests/cli-utils-selftests.c: Update.
8826         * unittests/parse-connection-spec-selftests.c: Update.
8827         * valops.c: Update.
8828         * valprint.c: Update.
8829         * value.c: Update.
8830         * varobj.c: Update.
8831         * windows-nat.c: Update.
8832         * x86-linux-nat.c: Update.
8833         * xml-support.c: Update.
8834
8835 2019-04-08  Tom Tromey  <tom@tromey.com>
8836
8837         * xml-support.c: Use C++ exception handling.
8838         * x86-linux-nat.c: Use C++ exception handling.
8839         * windows-nat.c: Use C++ exception handling.
8840         * varobj.c: Use C++ exception handling.
8841         * value.c: Use C++ exception handling.
8842         * valprint.c: Use C++ exception handling.
8843         * valops.c: Use C++ exception handling.
8844         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8845         handling.
8846         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8847         * typeprint.c: Use C++ exception handling.
8848         * tui/tui.c: Use C++ exception handling.
8849         * tracefile-tfile.c: Use C++ exception handling.
8850         * top.c: Use C++ exception handling.
8851         * thread.c: Use C++ exception handling.
8852         * target.c: Use C++ exception handling.
8853         * symmisc.c: Use C++ exception handling.
8854         * symfile-mem.c: Use C++ exception handling.
8855         * stack.c: Use C++ exception handling.
8856         * sparc64-linux-tdep.c: Use C++ exception handling.
8857         * solib.c: Use C++ exception handling.
8858         * solib-svr4.c: Use C++ exception handling.
8859         * solib-spu.c: Use C++ exception handling.
8860         * solib-frv.c: Use C++ exception handling.
8861         * solib-dsbt.c: Use C++ exception handling.
8862         * selftest-arch.c: Use C++ exception handling.
8863         * s390-tdep.c: Use C++ exception handling.
8864         * rust-lang.c: Use C++ exception handling.
8865         * rust-exp.y: Use C++ exception handling.
8866         * rs6000-tdep.c: Use C++ exception handling.
8867         * rs6000-aix-tdep.c: Use C++ exception handling.
8868         * riscv-tdep.c: Use C++ exception handling.
8869         * remote.c: Use C++ exception handling.
8870         * remote-fileio.c: Use C++ exception handling.
8871         * record-full.c: Use C++ exception handling.
8872         * record-btrace.c: Use C++ exception handling.
8873         * python/python.c: Use C++ exception handling.
8874         * python/py-value.c: Use C++ exception handling.
8875         * python/py-utils.c: Use C++ exception handling.
8876         * python/py-unwind.c: Use C++ exception handling.
8877         * python/py-type.c: Use C++ exception handling.
8878         * python/py-symbol.c: Use C++ exception handling.
8879         * python/py-record.c: Use C++ exception handling.
8880         * python/py-record-btrace.c: Use C++ exception handling.
8881         * python/py-progspace.c: Use C++ exception handling.
8882         * python/py-prettyprint.c: Use C++ exception handling.
8883         * python/py-param.c: Use C++ exception handling.
8884         * python/py-objfile.c: Use C++ exception handling.
8885         * python/py-linetable.c: Use C++ exception handling.
8886         * python/py-lazy-string.c: Use C++ exception handling.
8887         * python/py-infthread.c: Use C++ exception handling.
8888         * python/py-inferior.c: Use C++ exception handling.
8889         * python/py-gdb-readline.c: Use C++ exception handling.
8890         * python/py-framefilter.c: Use C++ exception handling.
8891         * python/py-frame.c: Use C++ exception handling.
8892         * python/py-finishbreakpoint.c: Use C++ exception handling.
8893         * python/py-cmd.c: Use C++ exception handling.
8894         * python/py-breakpoint.c: Use C++ exception handling.
8895         * python/py-arch.c: Use C++ exception handling.
8896         * printcmd.c: Use C++ exception handling.
8897         * ppc-linux-tdep.c: Use C++ exception handling.
8898         * parse.c: Use C++ exception handling.
8899         * p-valprint.c: Use C++ exception handling.
8900         * objc-lang.c: Use C++ exception handling.
8901         * mi/mi-main.c: Use C++ exception handling.
8902         * mi/mi-interp.c: Use C++ exception handling.
8903         * mi/mi-cmd-stack.c: Use C++ exception handling.
8904         * mi/mi-cmd-break.c: Use C++ exception handling.
8905         * main.c: Use C++ exception handling.
8906         * linux-thread-db.c: Use C++ exception handling.
8907         * linux-tdep.c: Use C++ exception handling.
8908         * linux-nat.c: Use C++ exception handling.
8909         * linux-fork.c: Use C++ exception handling.
8910         * linespec.c: Use C++ exception handling.
8911         * language.c: Use C++ exception handling.
8912         * jit.c: Use C++ exception handling.
8913         * infrun.c: Use C++ exception handling.
8914         * infcmd.c: Use C++ exception handling.
8915         * infcall.c: Use C++ exception handling.
8916         * inf-loop.c: Use C++ exception handling.
8917         * i386-tdep.c: Use C++ exception handling.
8918         * i386-linux-tdep.c: Use C++ exception handling.
8919         * guile/scm-value.c: Use C++ exception handling.
8920         * guile/scm-type.c: Use C++ exception handling.
8921         * guile/scm-symtab.c: Use C++ exception handling.
8922         * guile/scm-symbol.c: Use C++ exception handling.
8923         * guile/scm-pretty-print.c: Use C++ exception handling.
8924         * guile/scm-ports.c: Use C++ exception handling.
8925         * guile/scm-param.c: Use C++ exception handling.
8926         * guile/scm-math.c: Use C++ exception handling.
8927         * guile/scm-lazy-string.c: Use C++ exception handling.
8928         * guile/scm-frame.c: Use C++ exception handling.
8929         * guile/scm-disasm.c: Use C++ exception handling.
8930         * guile/scm-cmd.c: Use C++ exception handling.
8931         * guile/scm-breakpoint.c: Use C++ exception handling.
8932         * guile/scm-block.c: Use C++ exception handling.
8933         * guile/guile-internal.h: Use C++ exception handling.
8934         * gnu-v3-abi.c: Use C++ exception handling.
8935         * gdbtypes.c: Use C++ exception handling.
8936         * frame.c: Use C++ exception handling.
8937         * frame-unwind.c: Use C++ exception handling.
8938         * fbsd-tdep.c: Use C++ exception handling.
8939         * f-valprint.c: Use C++ exception handling.
8940         * exec.c: Use C++ exception handling.
8941         * event-top.c: Use C++ exception handling.
8942         * event-loop.c: Use C++ exception handling.
8943         * eval.c: Use C++ exception handling.
8944         * dwarf2read.c: Use C++ exception handling.
8945         * dwarf2loc.c: Use C++ exception handling.
8946         * dwarf2-frame.c: Use C++ exception handling.
8947         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8948         * dwarf-index-write.c: Use C++ exception handling.
8949         * dwarf-index-cache.c: Use C++ exception handling.
8950         * dtrace-probe.c: Use C++ exception handling.
8951         * disasm-selftests.c: Use C++ exception handling.
8952         * darwin-nat.c: Use C++ exception handling.
8953         * cp-valprint.c: Use C++ exception handling.
8954         * cp-support.c: Use C++ exception handling.
8955         * cp-abi.c: Use C++ exception handling.
8956         * corelow.c: Use C++ exception handling.
8957         * completer.c: Use C++ exception handling.
8958         * compile/compile-object-run.c: Use C++ exception handling.
8959         * compile/compile-object-load.c: Use C++ exception handling.
8960         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8961         * compile/compile-c-symbols.c: Use C++ exception handling.
8962         * common/selftest.c: Use C++ exception handling.
8963         * common/new-op.c: Use C++ exception handling.
8964         * cli/cli-script.c: Use C++ exception handling.
8965         * cli/cli-interp.c: Use C++ exception handling.
8966         * cli/cli-cmds.c: Use C++ exception handling.
8967         * c-varobj.c: Use C++ exception handling.
8968         * btrace.c: Use C++ exception handling.
8969         * breakpoint.c: Use C++ exception handling.
8970         * break-catch-throw.c: Use C++ exception handling.
8971         * arch-utils.c: Use C++ exception handling.
8972         * amd64-tdep.c: Use C++ exception handling.
8973         * ada-valprint.c: Use C++ exception handling.
8974         * ada-typeprint.c: Use C++ exception handling.
8975         * ada-lang.c: Use C++ exception handling.
8976         * aarch64-tdep.c: Use C++ exception handling.
8977
8978 2019-04-08  Tom Tromey  <tom@tromey.com>
8979
8980         * xml-support.c (gdb_xml_parser::parse): Update.
8981         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8982         * value.c (show_convenience): Update.
8983         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8984         (test_parse_flags_qcs): Update.
8985         * thread.c (thr_try_catch_cmd): Update.
8986         * target.c (target_translate_tls_address): Update.
8987         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8988         (info_frame_command_core, frame_apply_command_count): Update.
8989         * rust-exp.y (rust_lex_exception_test): Update.
8990         * riscv-tdep.c (riscv_print_one_register_info): Update.
8991         * remote.c (remote_target::enable_btrace): Update.
8992         * record-btrace.c (record_btrace_enable_warn): Update.
8993         * python/py-utils.c (gdbpy_convert_exception): Update.
8994         * printcmd.c (do_one_display, print_variable_and_value): Update.
8995         * mi/mi-main.c (mi_print_exception): Update.
8996         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8997         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8998         * linux-nat.c (linux_nat_target::attach): Update.
8999         * linux-fork.c (class scoped_switch_fork_info): Update.
9000         * infrun.c (displaced_step_prepare): Update.
9001         * infcall.c (call_function_by_hand_dummy): Update.
9002         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9003         * gnu-v3-abi.c (print_one_vtable): Update.
9004         * frame.c (get_prev_frame_always): Update.
9005         * f-valprint.c (info_common_command_for_block): Update.
9006         * exec.c (try_open_exec_file): Update.
9007         * exceptions.c (print_exception, exception_print)
9008         (exception_fprintf, exception_print_same): Update.
9009         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9010         * dwarf-index-cache.c (index_cache::store)
9011         (index_cache::lookup_gdb_index): Update.
9012         * darwin-nat.c (maybe_cache_shell): Update.
9013         * cp-valprint.c (cp_print_value_fields): Update.
9014         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9015         (gcc_cplus_symbol_address): Update.
9016         * compile/compile-c-symbols.c (gcc_convert_symbol)
9017         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9018         * common/selftest.c: Update.
9019         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9020         a std::string.
9021         (exception_try_scope_entry, exception_try_scope_exit): Don't
9022         declare.
9023         (struct exception_try_scope): Remove.
9024         (TRY): Don't use exception_try_scope.
9025         (struct gdb_exception): Add constructor, operator=.
9026         <what>: New method.
9027         (struct gdb_exception_RETURN_MASK_ALL)
9028         (struct gdb_exception_RETURN_MASK_ERROR)
9029         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9030         (struct gdb_quit_bad_alloc): Update.
9031         * common/common-exceptions.c (exception_none): Change
9032         initializer.
9033         (struct catcher) <state, exception>: Initialize inline.
9034         <prev>: Remove member.
9035         (current_catcher): Remove.
9036         (catchers): New global.
9037         (exceptions_state_mc_init): Simplify.
9038         (catcher_pop): Remove.
9039         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9040         (try_scope_depth, exception_try_scope_entry)
9041         (exception_try_scope_exit): Remove.
9042         (throw_exception_sjlj): Update.
9043         (exception_messages, exception_messages_size): Remove.
9044         (throw_it): Simplify.
9045         (gdb_exception_sliced_copy): Remove.
9046         (throw_exception_cxx): Update.
9047         * cli/cli-script.c (script_from_file): Update.
9048         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9049         Update.
9050         * ada-valprint.c (ada_val_print): Update.
9051         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9052         (create_excep_cond_exprs): Update.
9053
9054 2019-04-08  Tom Tromey  <tom@tromey.com>
9055
9056         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9057         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9058         (TRY, CATCH, END_CATCH): Remove some definitions.
9059         * common/common-exceptions.c: Don't use GDB_XCPT.
9060         (catcher_list_size): Remove.
9061         (throw_exception, throw_it): Simplify.
9062
9063 2019-04-05  Tom Tromey  <tom@tromey.com>
9064
9065         Revert the header-sorting patch.
9066         * ft32-tdep.c: Revert.
9067         * frv-tdep.c: Revert.
9068         * frv-linux-tdep.c: Revert.
9069         * frame.c: Revert.
9070         * frame-unwind.c: Revert.
9071         * frame-base.c: Revert.
9072         * fork-child.c: Revert.
9073         * findvar.c: Revert.
9074         * findcmd.c: Revert.
9075         * filesystem.c: Revert.
9076         * filename-seen-cache.h: Revert.
9077         * filename-seen-cache.c: Revert.
9078         * fbsd-tdep.c: Revert.
9079         * fbsd-nat.h: Revert.
9080         * fbsd-nat.c: Revert.
9081         * f-valprint.c: Revert.
9082         * f-typeprint.c: Revert.
9083         * f-lang.c: Revert.
9084         * extension.h: Revert.
9085         * extension.c: Revert.
9086         * extension-priv.h: Revert.
9087         * expprint.c: Revert.
9088         * exec.h: Revert.
9089         * exec.c: Revert.
9090         * exceptions.c: Revert.
9091         * event-top.c: Revert.
9092         * event-loop.c: Revert.
9093         * eval.c: Revert.
9094         * elfread.c: Revert.
9095         * dwarf2read.h: Revert.
9096         * dwarf2read.c: Revert.
9097         * dwarf2loc.c: Revert.
9098         * dwarf2expr.h: Revert.
9099         * dwarf2expr.c: Revert.
9100         * dwarf2-frame.c: Revert.
9101         * dwarf2-frame-tailcall.c: Revert.
9102         * dwarf-index-write.h: Revert.
9103         * dwarf-index-write.c: Revert.
9104         * dwarf-index-common.c: Revert.
9105         * dwarf-index-cache.h: Revert.
9106         * dwarf-index-cache.c: Revert.
9107         * dummy-frame.c: Revert.
9108         * dtrace-probe.c: Revert.
9109         * disasm.h: Revert.
9110         * disasm.c: Revert.
9111         * disasm-selftests.c: Revert.
9112         * dictionary.c: Revert.
9113         * dicos-tdep.c: Revert.
9114         * demangle.c: Revert.
9115         * dcache.h: Revert.
9116         * dcache.c: Revert.
9117         * darwin-nat.h: Revert.
9118         * darwin-nat.c: Revert.
9119         * darwin-nat-info.c: Revert.
9120         * d-valprint.c: Revert.
9121         * d-namespace.c: Revert.
9122         * d-lang.c: Revert.
9123         * ctf.c: Revert.
9124         * csky-tdep.c: Revert.
9125         * csky-linux-tdep.c: Revert.
9126         * cris-tdep.c: Revert.
9127         * cris-linux-tdep.c: Revert.
9128         * cp-valprint.c: Revert.
9129         * cp-support.c: Revert.
9130         * cp-namespace.c: Revert.
9131         * cp-abi.c: Revert.
9132         * corelow.c: Revert.
9133         * corefile.c: Revert.
9134         * continuations.c: Revert.
9135         * completer.h: Revert.
9136         * completer.c: Revert.
9137         * complaints.c: Revert.
9138         * coffread.c: Revert.
9139         * coff-pe-read.c: Revert.
9140         * cli-out.h: Revert.
9141         * cli-out.c: Revert.
9142         * charset.c: Revert.
9143         * c-varobj.c: Revert.
9144         * c-valprint.c: Revert.
9145         * c-typeprint.c: Revert.
9146         * c-lang.c: Revert.
9147         * buildsym.c: Revert.
9148         * buildsym-legacy.c: Revert.
9149         * build-id.h: Revert.
9150         * build-id.c: Revert.
9151         * btrace.c: Revert.
9152         * bsd-uthread.c: Revert.
9153         * breakpoint.h: Revert.
9154         * breakpoint.c: Revert.
9155         * break-catch-throw.c: Revert.
9156         * break-catch-syscall.c: Revert.
9157         * break-catch-sig.c: Revert.
9158         * blockframe.c: Revert.
9159         * block.c: Revert.
9160         * bfin-tdep.c: Revert.
9161         * bfin-linux-tdep.c: Revert.
9162         * bfd-target.c: Revert.
9163         * bcache.c: Revert.
9164         * ax-general.c: Revert.
9165         * ax-gdb.h: Revert.
9166         * ax-gdb.c: Revert.
9167         * avr-tdep.c: Revert.
9168         * auxv.c: Revert.
9169         * auto-load.c: Revert.
9170         * arm-wince-tdep.c: Revert.
9171         * arm-tdep.c: Revert.
9172         * arm-symbian-tdep.c: Revert.
9173         * arm-pikeos-tdep.c: Revert.
9174         * arm-obsd-tdep.c: Revert.
9175         * arm-nbsd-tdep.c: Revert.
9176         * arm-nbsd-nat.c: Revert.
9177         * arm-linux-tdep.c: Revert.
9178         * arm-linux-nat.c: Revert.
9179         * arm-fbsd-tdep.c: Revert.
9180         * arm-fbsd-nat.c: Revert.
9181         * arm-bsd-tdep.c: Revert.
9182         * arch-utils.c: Revert.
9183         * arc-tdep.c: Revert.
9184         * arc-newlib-tdep.c: Revert.
9185         * annotate.h: Revert.
9186         * annotate.c: Revert.
9187         * amd64-windows-tdep.c: Revert.
9188         * amd64-windows-nat.c: Revert.
9189         * amd64-tdep.c: Revert.
9190         * amd64-sol2-tdep.c: Revert.
9191         * amd64-obsd-tdep.c: Revert.
9192         * amd64-obsd-nat.c: Revert.
9193         * amd64-nbsd-tdep.c: Revert.
9194         * amd64-nbsd-nat.c: Revert.
9195         * amd64-nat.c: Revert.
9196         * amd64-linux-tdep.c: Revert.
9197         * amd64-linux-nat.c: Revert.
9198         * amd64-fbsd-tdep.c: Revert.
9199         * amd64-fbsd-nat.c: Revert.
9200         * amd64-dicos-tdep.c: Revert.
9201         * amd64-darwin-tdep.c: Revert.
9202         * amd64-bsd-nat.c: Revert.
9203         * alpha-tdep.c: Revert.
9204         * alpha-obsd-tdep.c: Revert.
9205         * alpha-nbsd-tdep.c: Revert.
9206         * alpha-mdebug-tdep.c: Revert.
9207         * alpha-linux-tdep.c: Revert.
9208         * alpha-linux-nat.c: Revert.
9209         * alpha-bsd-tdep.c: Revert.
9210         * alpha-bsd-nat.c: Revert.
9211         * aix-thread.c: Revert.
9212         * agent.c: Revert.
9213         * addrmap.c: Revert.
9214         * ada-varobj.c: Revert.
9215         * ada-valprint.c: Revert.
9216         * ada-typeprint.c: Revert.
9217         * ada-tasks.c: Revert.
9218         * ada-lang.c: Revert.
9219         * aarch64-tdep.c: Revert.
9220         * aarch64-ravenscar-thread.c: Revert.
9221         * aarch64-newlib-tdep.c: Revert.
9222         * aarch64-linux-tdep.c: Revert.
9223         * aarch64-linux-nat.c: Revert.
9224         * aarch64-fbsd-tdep.c: Revert.
9225         * aarch64-fbsd-nat.c: Revert.
9226         * aarch32-linux-nat.c: Revert.
9227
9228 2019-04-05  Tom Tromey  <tom@tromey.com>
9229
9230         * ft32-tdep.c: Sort headers.
9231         * frv-tdep.c: Sort headers.
9232         * frv-linux-tdep.c: Sort headers.
9233         * frame.c: Sort headers.
9234         * frame-unwind.c: Sort headers.
9235         * frame-base.c: Sort headers.
9236         * fork-child.c: Sort headers.
9237         * findvar.c: Sort headers.
9238         * findcmd.c: Sort headers.
9239         * filesystem.c: Sort headers.
9240         * filename-seen-cache.h: Sort headers.
9241         * filename-seen-cache.c: Sort headers.
9242         * fbsd-tdep.c: Sort headers.
9243         * fbsd-nat.h: Sort headers.
9244         * fbsd-nat.c: Sort headers.
9245         * f-valprint.c: Sort headers.
9246         * f-typeprint.c: Sort headers.
9247         * f-lang.c: Sort headers.
9248         * extension.h: Sort headers.
9249         * extension.c: Sort headers.
9250         * extension-priv.h: Sort headers.
9251         * expprint.c: Sort headers.
9252         * exec.h: Sort headers.
9253         * exec.c: Sort headers.
9254         * exceptions.c: Sort headers.
9255         * event-top.c: Sort headers.
9256         * event-loop.c: Sort headers.
9257         * eval.c: Sort headers.
9258         * elfread.c: Sort headers.
9259         * dwarf2read.h: Sort headers.
9260         * dwarf2read.c: Sort headers.
9261         * dwarf2loc.c: Sort headers.
9262         * dwarf2expr.h: Sort headers.
9263         * dwarf2expr.c: Sort headers.
9264         * dwarf2-frame.c: Sort headers.
9265         * dwarf2-frame-tailcall.c: Sort headers.
9266         * dwarf-index-write.h: Sort headers.
9267         * dwarf-index-write.c: Sort headers.
9268         * dwarf-index-common.c: Sort headers.
9269         * dwarf-index-cache.h: Sort headers.
9270         * dwarf-index-cache.c: Sort headers.
9271         * dummy-frame.c: Sort headers.
9272         * dtrace-probe.c: Sort headers.
9273         * disasm.h: Sort headers.
9274         * disasm.c: Sort headers.
9275         * disasm-selftests.c: Sort headers.
9276         * dictionary.c: Sort headers.
9277         * dicos-tdep.c: Sort headers.
9278         * demangle.c: Sort headers.
9279         * dcache.h: Sort headers.
9280         * dcache.c: Sort headers.
9281         * darwin-nat.h: Sort headers.
9282         * darwin-nat.c: Sort headers.
9283         * darwin-nat-info.c: Sort headers.
9284         * d-valprint.c: Sort headers.
9285         * d-namespace.c: Sort headers.
9286         * d-lang.c: Sort headers.
9287         * ctf.c: Sort headers.
9288         * csky-tdep.c: Sort headers.
9289         * csky-linux-tdep.c: Sort headers.
9290         * cris-tdep.c: Sort headers.
9291         * cris-linux-tdep.c: Sort headers.
9292         * cp-valprint.c: Sort headers.
9293         * cp-support.c: Sort headers.
9294         * cp-namespace.c: Sort headers.
9295         * cp-abi.c: Sort headers.
9296         * corelow.c: Sort headers.
9297         * corefile.c: Sort headers.
9298         * continuations.c: Sort headers.
9299         * completer.h: Sort headers.
9300         * completer.c: Sort headers.
9301         * complaints.c: Sort headers.
9302         * coffread.c: Sort headers.
9303         * coff-pe-read.c: Sort headers.
9304         * cli-out.h: Sort headers.
9305         * cli-out.c: Sort headers.
9306         * charset.c: Sort headers.
9307         * c-varobj.c: Sort headers.
9308         * c-valprint.c: Sort headers.
9309         * c-typeprint.c: Sort headers.
9310         * c-lang.c: Sort headers.
9311         * buildsym.c: Sort headers.
9312         * buildsym-legacy.c: Sort headers.
9313         * build-id.h: Sort headers.
9314         * build-id.c: Sort headers.
9315         * btrace.c: Sort headers.
9316         * bsd-uthread.c: Sort headers.
9317         * breakpoint.h: Sort headers.
9318         * breakpoint.c: Sort headers.
9319         * break-catch-throw.c: Sort headers.
9320         * break-catch-syscall.c: Sort headers.
9321         * break-catch-sig.c: Sort headers.
9322         * blockframe.c: Sort headers.
9323         * block.c: Sort headers.
9324         * bfin-tdep.c: Sort headers.
9325         * bfin-linux-tdep.c: Sort headers.
9326         * bfd-target.c: Sort headers.
9327         * bcache.c: Sort headers.
9328         * ax-general.c: Sort headers.
9329         * ax-gdb.h: Sort headers.
9330         * ax-gdb.c: Sort headers.
9331         * avr-tdep.c: Sort headers.
9332         * auxv.c: Sort headers.
9333         * auto-load.c: Sort headers.
9334         * arm-wince-tdep.c: Sort headers.
9335         * arm-tdep.c: Sort headers.
9336         * arm-symbian-tdep.c: Sort headers.
9337         * arm-pikeos-tdep.c: Sort headers.
9338         * arm-obsd-tdep.c: Sort headers.
9339         * arm-nbsd-tdep.c: Sort headers.
9340         * arm-nbsd-nat.c: Sort headers.
9341         * arm-linux-tdep.c: Sort headers.
9342         * arm-linux-nat.c: Sort headers.
9343         * arm-fbsd-tdep.c: Sort headers.
9344         * arm-fbsd-nat.c: Sort headers.
9345         * arm-bsd-tdep.c: Sort headers.
9346         * arch-utils.c: Sort headers.
9347         * arc-tdep.c: Sort headers.
9348         * arc-newlib-tdep.c: Sort headers.
9349         * annotate.h: Sort headers.
9350         * annotate.c: Sort headers.
9351         * amd64-windows-tdep.c: Sort headers.
9352         * amd64-windows-nat.c: Sort headers.
9353         * amd64-tdep.c: Sort headers.
9354         * amd64-sol2-tdep.c: Sort headers.
9355         * amd64-obsd-tdep.c: Sort headers.
9356         * amd64-obsd-nat.c: Sort headers.
9357         * amd64-nbsd-tdep.c: Sort headers.
9358         * amd64-nbsd-nat.c: Sort headers.
9359         * amd64-nat.c: Sort headers.
9360         * amd64-linux-tdep.c: Sort headers.
9361         * amd64-linux-nat.c: Sort headers.
9362         * amd64-fbsd-tdep.c: Sort headers.
9363         * amd64-fbsd-nat.c: Sort headers.
9364         * amd64-dicos-tdep.c: Sort headers.
9365         * amd64-darwin-tdep.c: Sort headers.
9366         * amd64-bsd-nat.c: Sort headers.
9367         * alpha-tdep.c: Sort headers.
9368         * alpha-obsd-tdep.c: Sort headers.
9369         * alpha-nbsd-tdep.c: Sort headers.
9370         * alpha-mdebug-tdep.c: Sort headers.
9371         * alpha-linux-tdep.c: Sort headers.
9372         * alpha-linux-nat.c: Sort headers.
9373         * alpha-bsd-tdep.c: Sort headers.
9374         * alpha-bsd-nat.c: Sort headers.
9375         * aix-thread.c: Sort headers.
9376         * agent.c: Sort headers.
9377         * addrmap.c: Sort headers.
9378         * ada-varobj.c: Sort headers.
9379         * ada-valprint.c: Sort headers.
9380         * ada-typeprint.c: Sort headers.
9381         * ada-tasks.c: Sort headers.
9382         * ada-lang.c: Sort headers.
9383         * aarch64-tdep.c: Sort headers.
9384         * aarch64-ravenscar-thread.c: Sort headers.
9385         * aarch64-newlib-tdep.c: Sort headers.
9386         * aarch64-linux-tdep.c: Sort headers.
9387         * aarch64-linux-nat.c: Sort headers.
9388         * aarch64-fbsd-tdep.c: Sort headers.
9389         * aarch64-fbsd-nat.c: Sort headers.
9390         * aarch32-linux-nat.c: Sort headers.
9391
9392 2019-04-04  Tom Tromey  <tom@tromey.com>
9393
9394         * varobj.c (varobj_create): Update.
9395         * rust-exp.y (struct rust_parser) <update_innermost_block,
9396         lookup_symbol>: New methods.
9397         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9398         Rename.
9399         (rust_parser::rust_lookup_type)
9400         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9401         * printcmd.c (display_command, do_one_display): Update.
9402         * parser-defs.h (struct parser_state) <parser_state>: Add
9403         "tracker" parameter.
9404         (block_tracker): New member.
9405         (class innermost_block_tracker) <innermost_block_tracker>: Add
9406         "types" parameter.
9407         <reset>: Remove method.
9408         (innermost_block): Don't declare.
9409         (null_post_parser): Update.
9410         * parse.c (innermost_block): Remove global.
9411         (write_dollar_variable): Update.
9412         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9413         Remove "tracker_types" parameter.
9414         (parse_expression): Add "tracker" parameter.
9415         (parse_expression_for_completion): Update.
9416         (null_post_parser): Add "tracker" parameter.
9417         * p-exp.y: Update rules.
9418         * m2-exp.y: Update rules.
9419         * language.h (struct language_defn) <la_post_parser>: Add
9420         "tracker" parameter.
9421         * go-exp.y: Update rules.
9422         * f-exp.y: Update rules.
9423         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9424         parameter.
9425         * d-exp.y: Update rules.
9426         * c-exp.y: Update rules.
9427         * breakpoint.c (set_breakpoint_condition): Create an
9428         innermost_block_tracker.
9429         (watch_command_1): Likewise.
9430         * ada-lang.c (resolve): Add "tracker" parameter.
9431         (resolve_subexp): Likewise.
9432         * ada-exp.y (write_var_from_sym): Update.
9433
9434 2019-04-04  Tom Tromey  <tom@tromey.com>
9435
9436         * type-stack.h: New file.
9437         * type-stack.c: New file.
9438         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9439         type-stack.h.
9440         (insert_into_type_stack, insert_type, push_type, push_type_int)
9441         (insert_type_address_space, pop_type, pop_type_int)
9442         (pop_typelist, pop_type_stack, append_type_stack)
9443         (push_type_stack, get_type_stack, push_typelist)
9444         (follow_type_instance_flags, follow_types): Don't declare.
9445         * parse.c (type_stack): Remove global.
9446         (parse_exp_in_context): Update.
9447         (insert_into_type_stack, insert_type, push_type, push_type_int)
9448         (insert_type_address_space, pop_type, pop_type_int)
9449         (pop_typelist, pop_type_stack, append_type_stack)
9450         (push_type_stack, get_type_stack, push_typelist)
9451         (follow_type_instance_flags, follow_types): Remove (moved to
9452         type-stack.c).
9453         * f-exp.y (type_stack): New global.
9454         Update rules.
9455         (push_kind_type, f_parse): Update.
9456         * d-exp.y (type_stack): New global.
9457         Update rules.
9458         (d_parse): Update.
9459         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9460         Update rules.
9461         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9462         (HFILES_NO_SRCDIR): Add type-stack.h.
9463
9464 2019-04-04  Tom Tromey  <tom@tromey.com>
9465
9466         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9467         (rust_parser::convert_ast_to_expression, rust_parse)
9468         (rust_lex_test_completion, rust_lex_tests): Update.
9469         * parser-defs.h (struct expr_completion_state): New.
9470         (struct parser_state) <parser_state>: Add completion parameter.
9471         <mark_struct_expression, mark_completion_tag>: New methods.
9472         <parse_completion, m_completion_state>: New members.
9473         (prefixify_expression, null_post_parser): Update.
9474         (mark_struct_expression, mark_completion_tag): Don't declare.
9475         * parse.c (parse_completion, expout_last_struct)
9476         (expout_tag_completion_type, expout_completion_name): Remove
9477         globals.
9478         (parser_state::mark_struct_expression)
9479         (parser_state::mark_completion_tag): Now methods.
9480         (prefixify_expression): Add last_struct parameter.
9481         (prefixify_subexp): Likewise.
9482         (parse_exp_1): Update.
9483         (parse_exp_in_context): Add cstate parameter.  Update.
9484         (parse_expression_for_completion): Create an
9485         expr_completion_state.
9486         (null_post_parser): Add "completion" parameter.
9487         * p-exp.y: Update rules.
9488         (yylex): Update.
9489         * language.h (struct language_defn) <la_post_parser>: Add
9490         "completing" parameter.
9491         * go-exp.y: Update rules.
9492         (lex_one_token): Update.
9493         * expression.h (parse_completion): Don't declare.
9494         * d-exp.y: Update rules.
9495         (lex_one_token): Update rules.
9496         * c-exp.y: Update rules.
9497         (lex_one_token): Update.
9498         * ada-lang.c (resolve): Add "parse_completion" parameter.
9499         (resolve_subexp): Likewise.
9500         (ada_resolve_function): Likewise.
9501
9502 2019-04-04  Tom Tromey  <tom@tromey.com>
9503
9504         * parser-defs.h (struct parser_state) <start_arglist,
9505         end_arglist>: New methods.
9506         <arglist_len, m_funcall_chain>: New members.
9507         (arglist_len, start_arglist, end_arglist): Don't declare.
9508         * parse.c (arglist_len, funcall_chain): Remove global.
9509         (start_arglist, end_arglist): Remove functions.
9510         (parse_exp_in_context): Update.
9511         * p-exp.y: Update rules.
9512         * m2-exp.y: Update rules.
9513         * go-exp.y: Update rules.
9514         * f-exp.y: Update rules.
9515         * d-exp.y: Update rules.
9516         * c-exp.y: Update rules.
9517
9518 2019-04-04  Tom Tromey  <tom@tromey.com>
9519
9520         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9521         lex_operator, push_back>: New methods.
9522         Update all rules.
9523         (rust_parser::lex_hex, lex_escape): Rename and update.
9524         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9525         (rust_parser::lex_operator): Rename and update.
9526         (rust_parser::lex_number, rustyylex, rustyyerror)
9527         (rust_lex_test_init, rust_lex_test_sequence)
9528         (rust_lex_test_push_back, rust_lex_tests): Update.
9529         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9530         parameter.
9531         <lexptr, prev_lexptr>: New members.
9532         (lexptr, prev_lexptr): Don't declare.
9533         * parse.c (lexptr, prev_lexptr): Remove globals.
9534         (parse_exp_in_context): Update.
9535         * p-exp.y (yylex, yyerror): Update.
9536         * m2-exp.y (parse_number, yylex, yyerror): Update.
9537         * go-exp.y (lex_one_token, yyerror): Update.
9538         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9539         * d-exp.y (lex_one_token, yyerror): Update.
9540         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9541         (lex_one_token, yyerror): Update.
9542         * ada-lex.l (YY_INPUT): Update.
9543         (rewind_to_char): Update.
9544         * ada-exp.y (yyerror): Update.
9545
9546 2019-04-04  Tom Tromey  <tom@tromey.com>
9547
9548         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9549         * parser-defs.h (struct parser_state) <parser_state>: Add new
9550         parameter.
9551         <comma_terminates>: New member.
9552         (comma_terminates): Don't declare global.
9553         * parse.c (comma_terminates): Remove global.
9554         (parse_exp_in_context): Update.
9555         * p-exp.y (yylex): Update.
9556         * m2-exp.y (yylex): Update.
9557         * go-exp.y (lex_one_token): Update.
9558         * f-exp.y (yylex): Update.
9559         * d-exp.y (lex_one_token): Update.
9560         * c-exp.y (lex_one_token): Update.
9561         * ada-lex.l: Update.
9562
9563 2019-04-04  Tom Tromey  <tom@tromey.com>
9564
9565         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9566         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9567         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9568         * parser-defs.h (paren_depth): Don't declare.
9569         * parse.c (paren_depth): Remove global.
9570         (parse_exp_in_context): Update.
9571         * p-exp.y (paren_depth): New global.
9572         (pascal_parse): Initialize it.
9573         * m2-exp.y (paren_depth): New global.
9574         (m2_parse): Initialize it.
9575         * go-exp.y (paren_depth): New global.
9576         (go_parse): Initialize it.
9577         * f-exp.y (paren_depth): New global.
9578         (f_parse): Initialize it.
9579         * d-exp.y (paren_depth): New global.
9580         (d_parse): Initialize it.
9581         * c-exp.y (paren_depth): New global.
9582         (c_parse): Initialize it.
9583         * ada-lex.l (paren_depth): New global.
9584         (lexer_init): Initialize it.
9585
9586 2019-04-04  Tom Tromey  <tom@tromey.com>
9587
9588         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9589         (rust_parser::convert_ast_to_type)
9590         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9591         * parser-defs.h (struct parser_state) <parser_state>: Add
9592         parameters.  Initialize new members.
9593         <expression_context_block, expression_context_pc>: New members.
9594         * parse.c (expression_context_block, expression_context_pc):
9595         Remove globals.
9596         (parse_exp_in_context): Update.
9597         * p-exp.y: Update all rules.
9598         (yylex): Update.
9599         * m2-exp.y: Update all rules.
9600         (yylex): Update.
9601         * go-exp.y (yylex): Update.
9602         * f-exp.y (yylex): Update.
9603         * d-exp.y: Update all rules.
9604         (yylex): Update.
9605         * c-exp.y: Update all rules.
9606         (lex_one_token, classify_name, yylex, c_parse): Update.
9607         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9608
9609 2019-04-04  Tom Tromey  <tom@tromey.com>
9610
9611         * gdbarch.h, gdbarch.c: Rebuild.
9612         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9613         * stap-probe.h:
9614         (struct stap_parse_info): Replace "parser_state" with
9615         "expr_builder".
9616         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9617         (parser_state): New class.
9618         * parse.c (expr_builder): Rename.
9619         (expr_builder::release): Rename.
9620         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9621         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9622         (write_exp_elt_longcst, write_exp_elt_floatcst)
9623         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9624         (write_exp_string_vector, write_exp_bitstring)
9625         (write_exp_msymbol, mark_struct_expression)
9626         (write_dollar_variable)
9627         (insert_type_address_space, increase_expout_size): Replace
9628         "parser_state" with "expr_builder".
9629         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9630         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9631         "parser_state" with "expr_builder".
9632
9633 2019-04-04  Tom Tromey  <tom@tromey.com>
9634
9635         * rust-exp.y: Replace "parse_language" with method call.
9636         * p-exp.y:
9637         (yylex): Replace "parse_language" with method call.
9638         * m2-exp.y:
9639         (yylex): Replace "parse_language" with method call.
9640         * go-exp.y (classify_name): Replace "parse_language" with method
9641         call.
9642         * f-exp.y (yylex): Replace "parse_language" with method call.
9643         * d-exp.y (lex_one_token): Replace "parse_language" with method
9644         call.
9645         * c-exp.y:
9646         (lex_one_token, classify_name, yylex): Replace "parse_language"
9647         with method call.
9648         * ada-exp.y (find_primitive_type, type_char)
9649         (type_system_address): Replace "parse_language" with method call.
9650
9651 2019-04-04  Tom Tromey  <tom@tromey.com>
9652
9653         * rust-exp.y: Replace "parse_gdbarch" with method call.
9654         * parse.c (write_dollar_variable, insert_type_address_space):
9655         Replace "parse_gdbarch" with method call.
9656         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9657         call.
9658         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9659         call.
9660         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9661         "parse_gdbarch" with method call.
9662         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9663         with method call.
9664         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9665         "parse_gdbarch" with method call.
9666         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9667         "parse_gdbarch" with method call.
9668         * c-exp.y (parse_type, parse_number, classify_name): Replace
9669         "parse_gdbarch" with method call.
9670         * ada-lex.l: Replace "parse_gdbarch" with method call.
9671         * ada-exp.y (parse_type, find_primitive_type, type_char)
9672         (type_system_address): Replace "parse_gdbarch" with method call.
9673
9674 2019-04-04  Tom Tromey  <tom@tromey.com>
9675
9676         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9677         * stap-probe.c (stap_parse_argument): Update.
9678         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9679         initial_size parameter.
9680         * rust-exp.y (rust_lex_tests): Update.
9681         * parse.c (parser_state): Update.
9682         (parse_exp_in_context): Update.
9683         * parser-defs.h (struct parser_state) <parser_state>: Remove
9684         "initial_size" parameter.
9685
9686 2019-04-04  Tom Tromey  <tom@tromey.com>
9687
9688         * parser-defs.h (increase_expout_size): Don't declare.
9689         * parse.c (increase_expout_size): Now static.
9690
9691 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9692
9693         * gnu-nat.c (gnu_nat_target::wait): Fix
9694         target_waitstatus_to_string call.
9695
9696 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9697
9698         * eval.c (evaluate_subexp_standard): Handle internal functions
9699         during Fortran function call handling.
9700
9701 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9702
9703         * NEWS: Mention new internal functions.
9704         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9705         (read_base_type): Use dwarf2_init_complex_target_type.
9706         * value.c (creal_internal_fn): New function.
9707         (cimag_internal_fn): New function.
9708         (_initialize_values): Register new internal functions.
9709
9710 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9711
9712         * infrun.c (stop_all_threads): If debug_infrun, always
9713         trace the wait status after wait_one, using
9714         target_waitstatus_to_string and target_pid_to_str.
9715         (handle_inferior_event): Replace various trace of
9716         wait status kind by a single trace.
9717         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9718         wait status kind image by target_waitstatus_to_string.
9719         * target/waitstatus.c (target_waitstatus_to_string): Fix
9720         obsolete comment.
9721
9722 2019-04-01  Tom Tromey  <tromey@adacore.com>
9723
9724         PR symtab/23331:
9725         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9726
9727 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9728             Pedro Alves  <palves@redhat.com>
9729
9730         * top.c (quit_force): Call 'finalize_values'.
9731         * value.c (finalize_values): New function.
9732         * value.h (finalize_values): Declare.
9733
9734 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9735
9736         * NEWS: Announce $_gdb_major and $_gdb_minor.
9737
9738         * top.c (init_gdb_version_vars): New function.
9739         (gdb_init): Call init_gdb_version_vars.
9740
9741 2019-03-29  Tom Tromey  <tromey@adacore.com>
9742
9743         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9744         help text.  Remove dead code.
9745
9746 2019-03-29  Keith Seitz  <keiths@redhat.com>
9747
9748         From Siddhesh Poyarekar:
9749         * f-lang.h (f77_get_upperbound): Return LONGEST.
9750         (f77_get_lowerbound): Likewise.
9751         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9752         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9753         print them.
9754         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9755         plongest to format print it.
9756         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9757         (f77_get_upperbound): Likewise.
9758         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9759         LOWER_BOUND to LONGEST.
9760         (f77_create_arrayprint_offset_tbl): Likewise.
9761
9762 2019-03-29  Keith Seitz  <keiths@redhat.com>
9763
9764         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9765         %s/pulongest for TYPE_LENGTH instead of %d in format
9766         strings.
9767         * ada-typerint.c (ada_print_type): Likewise.
9768         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9769         * compile/compile-c-support.c (generate_register_struct): Likewise.
9770         * gdbtypes.c (recursive_dump_type): Likewise.
9771         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9772         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9773         instead of %d in format strings.
9774         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9775         to std::min to ULONGEST.
9776         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9777         instead of %d in format strings.
9778         * tracepoint.c (info_scope_command): Likewise.
9779         * typeprint.c (print_offset_data::update)
9780         (print_offset_data::finish): Likewise.
9781         * xtensa-tdep.c (xtensa_store_return_value)
9782         (xtensa_push_dummy_call): Likewise.
9783
9784 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9785
9786         * windows-nat.c (display_selector): Fixed format specifications
9787         for 64-bit Cygwin.
9788
9789 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9790
9791         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9792
9793 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9794
9795         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9796         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9797         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9798         (nios2_linux_init_abi): Install it.
9799
9800 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9801
9802         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9803
9804 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9805
9806         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9807
9808 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9809             Tom Tromey  <tromey@adacore.com>
9810
9811         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9812
9813 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9814
9815         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9816         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9817         method to compute the bounds of range types. Also print "[evaluated]"
9818         if the bounds' values come from a dynamic evaluation.
9819
9820 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9821
9822         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9823         whitespace when pretty printing is on.
9824
9825 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9826
9827         * ppc-linux-nat.c: Add include.
9828
9829 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9830
9831         * NEWS: Mention AArch64 Pointer Authentication.
9832
9833 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9834
9835         * arm-linux-nat.c: Add include.
9836
9837 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9838
9839         * source-cache.c (source_cache::get_source_lines): Re-read
9840         fullname after calling open_source_file.
9841
9842 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9843
9844         * NEWS: Mention TLS support for FreeBSD.
9845
9846 2019-03-25  Tom Tromey  <tromey@adacore.com>
9847
9848         * minsyms.c (BUNCH_SIZE): Update comment.
9849         (~minimal_symbol_reader): Remove old comment.
9850         (compact_minimal_symbols): Update comment.
9851         (minimal_symbol_reader::install): Remove old comment.  Update
9852         other comments.
9853
9854 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9855
9856         * s390-linux-nat.c: Add include.
9857
9858 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9859
9860         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9861         Call linux_get_hwcap.
9862         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9863         Likewise.
9864         (aarch64_linux_get_hwcap): Remove function.
9865         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9866         declaration.
9867         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9868         linux_get_hwcap.
9869         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9870         * linux-tdep.c (linux_get_hwcap): Add function.
9871         (linux_get_hwcap2): Likewise.
9872         * linux-tdep.h (linux_get_hwcap): Add declaration.
9873         (linux_get_hwcap2): Likewise.
9874         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9875         (ppc_linux_get_hwcap2): Likewise.
9876         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9877         linux_get_hwcap.
9878         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9879         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9880         (ppc_linux_nat_target::read_description): Likewise.
9881         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9882         * s390-linux-nat.c: Likewise.
9883         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9884
9885 2019-03-24  Tom Tromey  <tom@tromey.com>
9886
9887         * ada-lang.c (standard_lookup): Simplify initialization.
9888         (ada_lookup_symbol_nonlocal): Simplify return.
9889         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9890         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9891         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9892         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9893         initialization.
9894         * solib.c (solib_global_lookup): Simplify.
9895         * symtab.c (null_block_symbol): Remove.
9896         (symbol_cache_lookup): Simplify returns.
9897         (lookup_language_this): Simplify returns.
9898         (lookup_symbol_aux): Simplify return.
9899         (lookup_local_symbol): Simplify returns.
9900         (lookup_global_symbol_from_objfile): Simplify return.
9901         (lookup_symbol_in_objfile_symtabs)
9902         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9903         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9904         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9905         * cp-namespace.c (cp_lookup_bare_symbol)
9906         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9907         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9908         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9909         (cp_lookup_symbol_via_imports): Simplify initialization.
9910         (find_symbol_in_baseclass): Likewise.
9911         * symtab.h (null_block_symbol): Remove.
9912         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9913         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9914         (d_lookup_symbol_module): Likewise.
9915         (find_symbol_in_baseclass): Simplify initialization.
9916
9917 2019-03-24  Tom Tromey  <tom@tromey.com>
9918
9919         * expression.h: Don't include symtab.h.
9920         (struct block): Forward declare.
9921
9922 2019-03-24  Tom Tromey  <tom@tromey.com>
9923
9924         * c-exp.y (typebase): Remove casts.
9925         * gdbtypes.c (lookup_unsigned_typename, )
9926         (lookup_signed_typename): Remove cast.
9927         * eval.c (parse_to_comma_and_eval): Remove cast.
9928         * parse.c (write_dollar_variable): Remove cast.
9929         * block.h (struct block) <superblock>: Now const.
9930         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9931         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9932         (map_block): Make "block" const.
9933         * symfile.h (struct quick_symbol_functions)
9934         <map_matching_symbols>: Constify block argument to "callback".
9935         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9936         const.
9937         (find_pc_sect_compunit_symtab): Make "b" const.
9938         (find_symbol_at_address): Likewise.
9939         (search_symbols): Likewise.
9940         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9941         (dw2_debug_names_lookup_symbol): Likewise.
9942         (dw2_map_matching_symbols): Update.
9943         * p-valprint.c (pascal_val_print): Remove "block".
9944         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9945         (aux_add_nonlocal_symbols): Make "block" const.
9946         (resolve_subexp): Remove cast.
9947         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9948         const.
9949         (iterate_over_file_blocks): Likewise.
9950         * f-exp.y (%union) <bval>: Remove.
9951         * coffread.c (patch_opaque_types): Make "b" const.
9952         * spu-tdep.c (spu_catch_start): Make "block" const.
9953         * c-valprint.c (print_unpacked_pointer): Remove "block".
9954         * symmisc.c (dump_symtab_1): Make "b" const.
9955         (block_depth): Make "block" const.
9956         * d-exp.y (%union) <bval>: Remove.
9957         * cp-support.h (cp_lookup_rtti_type): Update.
9958         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9959         * psymtab.c (psym_lookup_symbol): Make "block" const.
9960         (maintenance_check_psymtabs): Make "b" const.
9961         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9962         (enumerate_locals, enumerate_args): Update.
9963         * python/py-symtab.c (stpy_global_block): Make "block" const.
9964         (stpy_static_block): Likewise.
9965         * inline-frame.c (block_starting_point_at): Make "new_block"
9966         const.
9967         * block.c (find_block_in_blockvector): Make return type const.
9968         (blockvector_for_pc_sect): Make "b" const.
9969         (find_block_in_blockvector): Make "b" const.
9970
9971 2019-03-23  Tom Tromey  <tom@tromey.com>
9972
9973         * varobj.c (varobj_create): Update.
9974         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9975         * printcmd.c (display_command, do_one_display): Don't reset
9976         innermost_block.
9977         * parser-defs.h (enum innermost_block_tracker_type): Move to
9978         expression.h.
9979         (innermost_block): Update comment.
9980         * parse.c (parse_exp_1): Add tracker_types parameter.
9981         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9982         tracker_types parameter.  Reset innermost_block.
9983         (parse_exp_in_context): Remove.
9984         (parse_expression_for_completion): Update.
9985         * objfiles.c (~objfile): Don't reset expression_context_block or
9986         innermost_block.
9987         * expression.h (enum innermost_block_tracker_type): Move from
9988         parser-defs.h.
9989         (parse_exp_1): Add tracker_types parameter.
9990         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9991         reset innermost_block.
9992
9993 2019-03-23  Tom Tromey  <tom@tromey.com>
9994
9995         * objfiles.h: Include bcache.h.
9996
9997 2019-03-23  Tom Tromey  <tom@tromey.com>
9998
9999         * linespec.c (get_current_search_block): Use
10000         scoped_restore_current_language.
10001         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10002
10003 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10004             Jiong Wang  <jiong.wang@arm.com>
10005
10006         * aarch64-linux-tdep.c
10007         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10008         section.
10009         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10010
10011 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10012             Jiong Wang  <jiong.wang@arm.com>
10013
10014         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10015         instructions.
10016         (aarch64_analyze_prologue_test): Add PACIASP test.
10017         (aarch64_prologue_prev_register): Unmask PC value.
10018
10019 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10020             Jiong Wang  <jiong.wang@arm.com>
10021
10022         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10023         (aarch64_dwarf2_prev_register): Unmask PC value.
10024         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10025         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10026         DW_CFA_AARCH64_negate_ra_state.
10027         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10028
10029 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10030             Jiong Wang  <jiong.wang@arm.com>
10031
10032         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10033         registers.
10034         (aarch64_pseudo_register_name): Likewise.
10035         (aarch64_pseudo_register_type): Likewise.
10036         (aarch64_pseudo_register_reggroup_p): Likewise.
10037         (aarch64_gdbarch_init): Add pauth registers.
10038         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10039         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10040         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10041         (struct gdbarch_tdep): Add regnum for ra_state.
10042
10043 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10044             Jiong Wang  <jiong.wang@arm.com>
10045
10046         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10047
10048 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10049             Jiong Wang  <jiong.wang@arm.com>
10050
10051         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10052         function.
10053         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10054         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10055         (aarch64_gdbarch_init): Add puth registers.
10056         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10057         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10058         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10059
10060 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10061             Jiong Wang  <jiong.wang@arm.com>
10062
10063         * aarch64-linux-nat.c
10064         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10065         * aarch64-linux-tdep.c
10066         (aarch64_linux_core_read_description): Likewise.
10067         (aarch64_linux_get_hwcap): New function.
10068         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10069         (aarch64_linux_get_hwcap): New declaration.
10070
10071 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10072             Jiong Wang  <jiong.wang@arm.com>
10073
10074         * aarch64-linux-nat.c
10075         (aarch64_linux_nat_target::read_description): Add pauth param.
10076         * aarch64-linux-tdep.c
10077         (aarch64_linux_core_read_description): Likewise.
10078         * aarch64-tdep.c (struct target_desc): Add in pauth.
10079         (aarch64_read_description): Add pauth param.
10080         (aarch64_gdbarch_init): Likewise.
10081         * aarch64-tdep.h (aarch64_read_description): Likewise.
10082         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10083         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10084         * features/Makefile: Add new files.
10085         * features/aarch64-pauth.c: New file.
10086         * features/aarch64-pauth.xml: New file.
10087
10088 2019-03-20  Tom Tromey  <tromey@adacore.com>
10089
10090         * infrun.c (handle_inferior_event): Rename from
10091         handle_inferior_event_1.  Create a scoped_value_mark.
10092         (handle_inferior_event): Remove.
10093
10094 2019-03-19  Tom Tromey  <tromey@adacore.com>
10095
10096         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10097         * infrun.h (print_stop_event): Add "displays" parameter.
10098         * infrun.c (print_stop_event): Add "displays" parameter.
10099
10100 2019-03-19  Pedro Alves  <palves@redhat.com>
10101
10102         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10103         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10104         to -1.  Fix TABs vs spaces.
10105         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10106         * tui/tui-out.h (tui_ui_out) Add intro comments.
10107         <m_line, m_start_of_line>: In-class initialize, and add describing
10108         comment.
10109
10110 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10111
10112         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10113         variable names.
10114         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10115
10116 2019-03-18  Pedro Alves  <palves@redhat.com>
10117             Eli Zaretskii <eliz@gnu.org>
10118
10119         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10120         m_line and m_start_of_line.
10121
10122 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10123
10124         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10125         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10126         it returns a newline.  This fixes a regression in TU mode, whereby
10127         the next line is output on the same screen line as the user input.
10128
10129 2019-03-18  Tom Tromey  <tromey@adacore.com>
10130
10131         * minsyms.c (minimal_symbol_reader::install): Remove call to
10132         obstack_blank.
10133
10134 2019-03-18  Pedro Alves  <palves@redhat.com>
10135
10136         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10137         New globals.
10138         (apply_style): New, factored out from ...
10139         (apply_ansi_escape): ... this.  Handle reverse video mode.
10140         (tui_set_reverse_mode): New function.
10141         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10142         * tui/tui-winsource.c (tui_show_source_line): Use
10143         tui_set_reverse_mode instead of setting A_STANDOUT.
10144         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10145         New setter methods.
10146
10147 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10148
10149         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10150         Handle tabs.
10151
10152 2019-03-18  Tom Tromey  <tromey@adacore.com>
10153
10154         * ada-lang.c (empty_array): Add "high" parameter.
10155         (ada_evaluate_subexp): Update.
10156
10157 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10158
10159         * unittests/string_view-selftests.c: Define
10160         _initialize_string_view_selftests unconditionally.
10161
10162 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10163
10164         PR gdb/24350
10165         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10166
10167 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10168
10169         PR gdb/24351
10170         * windows-nat.c (display_selector): Fix format specifiers.
10171
10172 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10173
10174         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10175         tui_refill_source_window instead of tui_refresh_win, to update the
10176         current execution line.  This fixes redisplay of the current line
10177         when stepping through the code with "next" or "step".
10178
10179 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10180
10181         * source-cache.c (source_cache::get_source_lines): Call
10182         find_source_lines to initialize s->nlines.  This fixes vertical
10183         scrolling of TUI source window when the DOWN arrow is pressed.
10184
10185 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10186
10187         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10188         linux-thread-db.c (_initialize_thread_db): Likewise.
10189
10190 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10191
10192         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10193         wclrtoeol in tui_show_source_line".  This reverts changes made in
10194         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10195
10196 2019-03-15  Tom Tromey  <tom@tromey.com>
10197
10198         * symtab.h (struct minimal_symbol): Derive from
10199         general_symbol_info.
10200         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10201         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10202         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10203         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10204         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10205         (MSYMBOL_SEARCH_NAME): Update.
10206         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10207         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10208         * minsyms.c (minimal_symbol_reader::record_full): Update.
10209
10210 2019-03-15  Tom Tromey  <tom@tromey.com>
10211
10212         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10213
10214 2019-03-15  Tom Tromey  <tom@tromey.com>
10215
10216         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10217         unique_xmalloc_ptr.
10218         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10219         Update.
10220         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10221         (build_minimal_symbol_hash_tables)
10222         (minimal_symbol_reader::install): Update.
10223
10224 2019-03-15  Tom Tromey  <tom@tromey.com>
10225
10226         * symtab.c (create_demangled_names_hash): Update.
10227         (symbol_set_names): Update.
10228         * objfiles.h (struct objfile_per_bfd_storage)
10229         <demangled_names_hash>: Now an htab_up.
10230         * objfiles.c (objfile_per_bfd_storage): Simplify.
10231
10232 2019-03-15  Tom Tromey  <tom@tromey.com>
10233
10234         * objfiles.h (struct objfile_per_bfd_storage): Declare
10235         destructor.
10236         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10237         New.
10238         (get_objfile_bfd_data): Use new.  Don't initialize
10239         language_of_main.
10240         (free_objfile_per_bfd_storage): Remove.
10241         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10242
10243 2019-03-15  Tom Tromey  <tom@tromey.com>
10244
10245         * symfile.c (reread_symbols): Update.
10246         * objfiles.c (objfile::objfile): Update.
10247         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10248         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10249         comment.
10250         (minimal_symbol_reader::install): Update.
10251         (terminate_minimal_symbol_table): Remove.
10252         * jit.c (jit_object_close_impl): Update.
10253
10254 2019-03-15  Tom Tromey  <tom@tromey.com>
10255
10256         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10257         initializations.
10258
10259 2019-03-15  Tom Tromey  <tom@tromey.com>
10260
10261         * objfiles.h (struct objfile_per_bfd_storage)
10262         <demangled_hash_languages>: Now a bitset.
10263         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10264         (lookup_minimal_symbol): Update.
10265
10266 2019-03-15  Tom Tromey  <tom@tromey.com>
10267
10268         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10269         Don't return the symbol.
10270         * coffread.c (record_minimal_symbol): Use record_full.
10271
10272 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10273
10274         The MS-Windows port of ncurses fails to switch to a color pair if
10275         one or both of the colors are the implicit default colors.  This
10276         change records the default colors when TUI is initialized, and
10277         then specifies them explicitly when a color pair uses the default
10278         colors.  This allows color styling in TUI mode on MS-Windows.
10279
10280         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10281         ncurses_norm_attr.
10282         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10283         colors in ncurses_norm_attr.
10284         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10285         "none", replace it with the default color recorded in
10286         ncurses_norm_attr.
10287
10288 2019-03-14  Tom Tromey  <tromey@adacore.com>
10289
10290         * source-cache.h (class source_cache) <get_source_lines>: Return
10291         std::string.
10292         * source-cache.c (source_cache::extract_lines): Handle case where
10293         first_pos==npos.  Return std::string.
10294         (source_cache::get_source_lines): Update.
10295
10296 2019-03-14  Tom Tromey  <tromey@adacore.com>
10297
10298         * NEWS: Add item for "style sources" commands.
10299         * source-cache.c (source_cache::get_source_lines): Check
10300         source_styling.
10301         * cli/cli-style.c (source_styling): New global.
10302         (_initialize_cli_style): Add "style sources" commands.
10303         (show_style_sources): New function.
10304         * cli/cli-style.h (source_styling): Declare.
10305
10306 2019-03-14  Pedro Alves  <palves@redhat.com>
10307             Tom Tromey  <tromey@adacore.com>
10308
10309         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10310         * tui/tui-winsource.c (tui_refill_source_window): New function,
10311         from...
10312         (tui_horizontal_source_scroll): ... here.  Move some logic.
10313         * cli/cli-style.c (set_style_enabled): Notify new observable.
10314         * tui/tui-hooks.c (tui_redisplay_source): New function.
10315         (tui_attach_detach_observers): Attach or detach
10316         tui_redisplay_source.
10317         * observable.h (source_styling_changed): New observable.
10318         * observable.c: Define source_styling_changed observable.
10319
10320 2019-03-13  Tom Tromey  <tromey@adacore.com>
10321
10322         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10323         (i386_gnu_nat_target::store_registers): Update.
10324         * target-debug.h (target_debug_print_std_string): New macro.
10325         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10326         * windows-tdep.c (display_one_tib): Update.
10327         * tui/tui-stack.c (tui_make_status_line): Update.
10328         * top.c (print_inferior_quit_action): Update.
10329         * thread.c (thr_try_catch_cmd): Update.
10330         (add_thread_with_info): Update.
10331         (thread_target_id_str): Update.
10332         (thr_try_catch_cmd): Update.
10333         (thread_command): Update.
10334         (thread_find_command): Update.
10335         * record-btrace.c (record_btrace_target::info_record)
10336         (record_btrace_resume_thread, record_btrace_target::resume)
10337         (record_btrace_cancel_resume, record_btrace_step_thread)
10338         (record_btrace_target::wait, record_btrace_target::wait)
10339         (record_btrace_target::wait, record_btrace_target::stop): Update.
10340         * progspace.c (print_program_space): Update.
10341         * process-stratum-target.c
10342         (process_stratum_target::thread_address_space): Update.
10343         * linux-fork.c (linux_fork_mourn_inferior)
10344         (detach_checkpoint_command, info_checkpoints_command)
10345         (linux_fork_context): Update.
10346         (linux_fork_detach): Update.
10347         (class scoped_switch_fork_info): Update.
10348         (delete_checkpoint_command): Update.
10349         * infrun.c (follow_fork_inferior): Update.
10350         (follow_fork_inferior): Update.
10351         (proceed_after_vfork_done): Update.
10352         (handle_vfork_child_exec_or_exit): Update.
10353         (follow_exec): Update.
10354         (displaced_step_prepare_throw): Update.
10355         (displaced_step_restore): Update.
10356         (start_step_over): Update.
10357         (resume_1): Update.
10358         (clear_proceed_status_thread): Update.
10359         (proceed): Update.
10360         (print_target_wait_results): Update.
10361         (do_target_wait): Update.
10362         (context_switch): Update.
10363         (stop_all_threads): Update.
10364         (restart_threads): Update.
10365         (finish_step_over): Update.
10366         (handle_signal_stop): Update.
10367         (switch_back_to_stepped_thread): Update.
10368         (keep_going_pass_signal): Update.
10369         (print_exited_reason): Update.
10370         (normal_stop): Update.
10371         * inferior.c (inferior_pid_to_str): Change return type.
10372         (print_selected_inferior): Update.
10373         (add_inferior): Update.
10374         (detach_inferior): Update.
10375         * dummy-frame.c (fprint_dummy_frames): Update.
10376         * dcache.c (dcache_info_1): Update.
10377         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10378         (btrace_fetch, btrace_clear): Update.
10379         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10380         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10381         type.
10382         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10383         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10384         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10385         * gdbarch.c, gdbarch.h: Rebuild.
10386         * gdbarch.sh (core_pid_to_str): Change return type.
10387         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10388         return type.
10389         (windows_nat_target::pid_to_str): Change return type.
10390         (windows_delete_thread): Update.
10391         (windows_nat_target::attach): Update.
10392         (windows_nat_target::files_info): Update.
10393         * target-delegates.c: Rebuild.
10394         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10395         return type.
10396         (sol_thread_target::pid_to_str): Change return type.
10397         * remote.c (class remote_target) <pid_to_str>: Change return
10398         type.
10399         (remote_target::pid_to_str): Change return type.
10400         (extended_remote_target::attach, remote_target::remote_stop_ns)
10401         (remote_target::remote_notif_remove_queued_reply)
10402         (remote_target::push_stop_reply, remote_target::disable_btrace):
10403         Update.
10404         (extended_remote_target::attach): Update.
10405         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10406         type.
10407         (gdbsim_target::pid_to_str): Change return type.
10408         * ravenscar-thread.c (struct ravenscar_thread_target)
10409         <pid_to_str>: Change return type.
10410         (ravenscar_thread_target::pid_to_str): Change return type.
10411         * procfs.c (class procfs_target) <pid_to_str>: Change return
10412         type.
10413         (procfs_target::pid_to_str): Change return type.
10414         (procfs_target::attach): Update.
10415         (procfs_target::detach): Update.
10416         (procfs_target::fetch_registers): Update.
10417         (procfs_target::store_registers): Update.
10418         (procfs_target::wait): Update.
10419         (procfs_target::files_info): Update.
10420         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10421         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10422         return type.
10423         (nto_procfs_target::pid_to_str): Change return type.
10424         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10425         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10426         return type.
10427         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10428         (exit_lwp): Update.
10429         (attach_proc_task_lwp_callback, get_detach_signal)
10430         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10431         (linux_nat_target::resume, wait_lwp, stop_callback)
10432         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10433         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10434         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10435         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10436         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10437         type.
10438         (inf_ptrace_target::attach): Update.
10439         (inf_ptrace_target::files_info): Update.
10440         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10441         type.
10442         (go32_nat_target::pid_to_str): Change return type.
10443         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10444         (gnu_nat_target::wait): Update.
10445         (gnu_nat_target::wait): Update.
10446         (gnu_nat_target::resume): Update.
10447         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10448         (fbsd_nat_target::wait): Update.
10449         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10450         type.
10451         (darwin_nat_target::attach): Update.
10452         * corelow.c (class core_target) <pid_to_str>: Change return type.
10453         (core_target::pid_to_str): Change return type.
10454         * target.c (normal_pid_to_str): Change return type.
10455         (default_pid_to_str): Likewise.
10456         (target_pid_to_str): Change return type.
10457         (target_translate_tls_address): Update.
10458         (target_announce_detach): Update.
10459         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10460         return type.
10461         (bsd_uthread_target::pid_to_str): Change return type.
10462         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10463         type.
10464         (bsd_kvm_target::pid_to_str): Change return type.
10465         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10466         return type.
10467         (aix_thread_target::pid_to_str): Change return type.
10468         * target.h (struct target_ops) <pid_to_str>: Change return type.
10469         (target_pid_to_str, normal_pid_to_str): Likewise.
10470         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10471         type.
10472         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10473         type.
10474         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10475         return type.
10476         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10477         type.
10478         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10479         type.
10480         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10481         return type.
10482
10483 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10484
10485         * NEWS: Mention that the new default MI version is 3.  Mention
10486         changes to the output of commands and events that deal with
10487         multi-location breakpoints.
10488         * breakpoint.c: Include "mi/mi-out.h".
10489         (print_one_breakpoint): Change output syntax if using MI version
10490         >= 3.
10491         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10492         New.
10493         (mi_multi_location_breakpoint_output_fixed): New.
10494         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10495         (mi_cmd_fix_multi_location_breakpoint_output): New.
10496         (mi_multi_location_breakpoint_output_fixed): New.
10497         * mi/mi-cmds.c (mi_cmds): Register command
10498         -fix-multi-location-breakpoint-output.
10499         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10500         interpreter "mi".
10501
10502 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10503
10504         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10505         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10506         instantiate mi_ui_out based on interpreter name.
10507         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10508         * mi/mi-main.c (mi_load_progress): Likewise.
10509
10510 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10511
10512         * NEWS: Combine separate "New targets" sections for 8.3.
10513
10514 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10515
10516         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10517         (ppcfbsd_init_abi): Install gdbarch
10518         "fetch_tls_load_module_address" and "get_thread_local_address"
10519         methods.
10520
10521 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10522
10523         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10524         (riscv_fbsd_init_abi): Install gdbarch
10525         "fetch_tls_load_module_address" and "get_thread_local_address"
10526         methods.
10527
10528 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10529
10530         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10531         (i386fbsd_init_abi): Install gdbarch
10532         "fetch_tls_load_module_address" and "get_thread_local_address"
10533         methods.
10534
10535 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10536
10537         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10538         (amd64fbsd_init_abi): Install gdbarch
10539         "fetch_tls_load_module_address" and "get_thread_local_address"
10540         methods.
10541
10542 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10543
10544         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10545         (struct fbsd_pspace_data): New type.
10546         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10547         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10548         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10549         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10550         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10551
10552 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10553
10554         * gdbtypes.c (lookup_struct_elt): New function.
10555         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10556         * gdbtypes.h (struct struct_elt): New type.
10557         (lookup_struct_elt): New prototype.
10558
10559 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10560
10561         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10562         remove disabled code block.
10563
10564 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10565
10566         * gdbarch.sh (get_thread_local_address): New method.
10567         * gdbarch.h, gdbarch.c: Regenerate.
10568         * target.c (target_translate_tls_address): Use
10569         gdbarch_get_thread_local_address if present instead of
10570         target::get_thread_local_address.
10571
10572 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10573
10574         * target.h (target::get_thread_local_address): Update comment.
10575
10576 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10577
10578         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10579         objfile->separate_debug_objfile_backlink if not NULL.
10580
10581 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10582
10583         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10584         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10585         (amd64bsd_store_inferior_registers): Likewise.
10586         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10587         Enable segment base registers.
10588         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10589         PT_GETFSBASE and PT_GETGSBASE.
10590         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10591         PT_SETGSBASE.
10592         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10593         segment base registers.
10594         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10595
10596 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10597
10598         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10599         Update calls to i386_target_description to add 'segments'
10600         parameter.
10601         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10602         add segment base registers.
10603         * arch/i386.c (i386_create_target_description): Add 'segments'
10604         parameter to enable segment base registers.
10605         * arch/i386.h (i386_create_target_description): Likewise.
10606         * features/i386/32bit-segments.xml: New file.
10607         * features/i386/32bit-segments.c: Generate.
10608         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10609         call to i386_target_description to add 'segments' parameter.
10610         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10611         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10612         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10613         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10614         if feature is present.
10615         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10616         Add 'segments' parameter to call to i386_target_description.
10617         (i386_target_description): Add 'segments' parameter to enable
10618         segment base registers.
10619         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10620         to call to i386_target_description.
10621         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10622         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10623         Define I386_NUM_REGS.
10624         (i386_target_description): Add 'segments' parameter to enable
10625         segment base registers.
10626
10627 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10628
10629         PR/24325
10630         * source-cache.c: #undef open and close, to avoid unresolved
10631         externals during linking.
10632
10633 2019-03-12  Tom Tromey  <tromey@adacore.com>
10634
10635         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10636         const.  Add initializers.
10637         (_initialize_remote): Don't initialize ptid globals.
10638
10639 2019-03-12  Pedro Alves  <palves@redhat.com>
10640
10641         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10642
10643 2019-03-12  Pedro Alves  <palves@redhat.com>
10644
10645         * cp-name-parser.y (main): Remove unused 'len' variable.
10646
10647 2019-03-12  Tom Tromey  <tromey@adacore.com>
10648
10649         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10650         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10651
10652 2019-03-12  Tom Tromey  <tromey@adacore.com>
10653
10654         * linux-nat.c (iterate_over_lwps): Update.
10655         (stop_callback): Remove parameter.
10656         (stop_wait_callback, detach_callback, resume_set_callback)
10657         (select_singlestep_lwp_callback, set_ignore_sigint)
10658         (status_callback, resumed_callback, resume_clear_callback)
10659         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10660         data parameter.
10661         (linux_nat_target::detach, linux_nat_target::resume)
10662         (linux_stop_and_wait_all_lwps, select_event_lwp)
10663         (linux_nat_filter_event, linux_nat_wait_1)
10664         (linux_nat_target::kill, linux_nat_target::stop)
10665         (linux_nat_target::stop): Update.
10666         (linux_nat_resume_callback): Change type.
10667         (resume_stopped_resumed_lwps, count_events_callback)
10668         (select_event_lwp_callback): Likewise.
10669         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10670         * arm-linux-nat.c (struct update_registers_data): Remove.
10671         (update_registers_callback): Change type.
10672         (arm_linux_insert_hw_breakpoint1): Update.
10673         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10674         parameter.
10675         (x86_linux_dr_set_addr): Update.
10676         (x86_linux_dr_set_control): Update.
10677         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10678         (iterate_over_lwps): Use gdb::function_view.
10679         * nat/aarch64-linux-hw-point.c (struct
10680         aarch64_dr_update_callback_param): Remove.
10681         (debug_reg_change_callback): Change type.
10682         (aarch64_notify_debug_reg_change): Update.
10683         * s390-linux-nat.c (s390_refresh_per_info): Update.
10684
10685 2019-03-11  Tom Tromey  <tromey@adacore.com>
10686
10687         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10688         redundant assignment to "this_cu".
10689
10690 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10691
10692         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10693
10694 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10695
10696         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10697         from...
10698         (rank_one_type): ... this.
10699
10700 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10701
10702         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10703         from...
10704         (rank_one_type): ... this.
10705
10706 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10707
10708         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10709         from...
10710         (rank_one_type): ... this.
10711
10712 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10713
10714         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10715         from...
10716         (rank_one_type): ... this.
10717
10718 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10719
10720         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10721         from...
10722         (rank_one_type): ... this.
10723
10724 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10725
10726         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10727         from...
10728         (rank_one_type): ... this.
10729
10730 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10731
10732         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10733         from...
10734         (rank_one_type): ... this.
10735
10736 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10737
10738         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10739         from...
10740         (rank_one_type): ... this.
10741
10742 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10743
10744         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10745         from...
10746         (rank_one_type): ... this.
10747
10748 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10749
10750         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10751         from...
10752         (rank_one_type): ... this.
10753
10754 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10755
10756         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10757         from...
10758         (rank_one_type): ... this.
10759
10760 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10761
10762         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10763         from...
10764         (rank_one_type): ... this.
10765
10766 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10767
10768         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10769         inferior-events' shows the example events.
10770
10771 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10772
10773         Support styling on native MS-Windows console
10774
10775         PR/24315
10776         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10777         on MS-Windows if $TERM is not defined.
10778
10779         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10780
10781         * posix-hdep.c (gdb_console_fputs):
10782         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10783         functions.
10784         * ui-file.h (gdb_console_fputs): Add prototype.
10785
10786         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10787         back to fputs only if the former returns zero.
10788
10789 2019-03-07  Tom Tromey  <tom@tromey.com>
10790
10791         * symmisc.c (print_symbol_bcache_statistics): Update.
10792         (print_objfile_statistics): Update.
10793         * symfile.c (allocate_symtab): Update.
10794         * stabsread.c: Don't include bcache.h.
10795         * psymtab.h (struct psymbol_bcache): Don't declare.
10796         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10797         (psymbol_bcache_init, psymbol_bcache_free)
10798         (psymbol_bcache_get_bcache): Don't declare.
10799         * psymtab.c (struct psymbol_bcache): Remove.
10800         (psymtab_storage::psymtab_storage): Update.
10801         (psymtab_storage::~psymtab_storage): Update.
10802         (psymbol_bcache_init, psymbol_bcache_free)
10803         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10804         (add_psymbol_to_bcache): Update.
10805         (allocate_psymtab): Update.
10806         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10807         macro_cache>: No longer pointers.
10808         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10809         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10810         * macrotab.c (macro_bcache): Update.
10811         * macroexp.c: Don't include bcache.h.
10812         * gdbtypes.c (check_types_worklist): Update.
10813         (types_deeply_equal): Remove TRY/CATCH.  Update.
10814         * elfread.c (elf_symtab_read): Update.
10815         * dwarf2read.c: Don't include bcache.h.
10816         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10817         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10818         (print_bcache_statistics, bcache_memory_used): Don't declare.
10819         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10820         methods.  Rename all data members.
10821         * bcache.c (struct bcache): Move to bcache.h.
10822         (bcache::expand_hash_table): Rename from expand_hash_table.
10823         (bcache): Remove.
10824         (bcache::insert): Rename from bcache_full.
10825         (bcache::compare): Rename from bcache_compare.
10826         (bcache_xmalloc): Remove.
10827         (bcache::~bcache): Rename from bcache_xfree.
10828         (bcache::print_statistics): Rename from print_bcache_statistics.
10829         (bcache::memory_used): Rename from bcache_memory_used.
10830
10831 2019-03-07  Pedro Alves  <palves@redhat.com>
10832
10833         * infrun.c (normal_stop): Also check for
10834         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10835
10836 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10837
10838         * f-lang.c (value_from_host_double): Moved to...
10839         * value.c (value_from_host_double): ...here.
10840         * value.h (value_from_host_double): Declare.
10841         * guile/scm-math.c (vlscm_convert_typed_number): Use
10842         value_from_host_double.
10843         (vlscm_convert_number): Likewise.
10844         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10845         * python/py-value.c (convert_value_from_python): Likewise.
10846
10847 2019-03-06  Tom Tromey  <tom@tromey.com>
10848
10849         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10850
10851 2019-03-06  Tom Tromey  <tom@tromey.com>
10852
10853         * utils.h (free_current_contents): Don't declare.
10854         * utils.c (free_current_contents): Remove.
10855
10856 2019-03-06  Tom Tromey  <tom@tromey.com>
10857
10858         * top.c (quit_force): Update.
10859         * main.c (captured_command_loop): Update.
10860         * common/new-op.c (operator new): Update.
10861         * common/common-exceptions.c (struct catcher)
10862         <save_cleanup_chain>: Remove member.
10863         (exceptions_state_mc_init): Update.
10864         (exception_try_scope_entry): Return nullptr.
10865         (exception_try_scope_exit, exception_rethrow)
10866         (throw_exception_sjlj, throw_exception_cxx): Update.
10867         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10868         (all_cleanups, do_cleanups, discard_cleanups)
10869         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10870         (restore_cleanups, restore_final_cleanups): Don't declare.
10871         (do_final_cleanups): Remove parameter.
10872         * common/cleanups.c (cleanup_chain, make_cleanup)
10873         (make_cleanup_dtor, all_cleanups, do_cleanups)
10874         (discard_my_cleanups, discard_cleanups)
10875         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10876         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10877         (null_cleanup): Remove.
10878         (do_final_cleanups): Remove parameter.
10879
10880 2019-03-06  Tom Tromey  <tom@tromey.com>
10881
10882         * remote.c (remote_target::remote_parse_stop_reply): Use
10883         unique_xmalloc_ptr.
10884
10885 2019-03-06  Tom Tromey  <tom@tromey.com>
10886
10887         * stabsread.c (struct stabs_field_info): Rename from field_info.
10888         <list, fnlist>: Add initializers.
10889         <obstack>: New member.
10890         (read_member_functions, read_struct_fields, read_baseclasses):
10891         Allocate on obstack.  Don't use cleanups.
10892         (read_one_struct_field, read_member_functions, read_struct_fields)
10893         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10894         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10895         (read_struct_type): Update.
10896
10897 2019-03-06  Tom Tromey  <tom@tromey.com>
10898
10899         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10900         * common/filestuff.h (make_cleanup_close): Don't declare.
10901         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10902         Remove.
10903
10904 2019-03-06  Tom Tromey  <tom@tromey.com>
10905
10906         * solib-aix.c: Use make_scope_exit.
10907
10908 2019-03-06  Tom Tromey  <tom@tromey.com>
10909
10910         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10911         Use make_scope_exit.
10912
10913 2019-03-06  Tom Tromey  <tom@tromey.com>
10914
10915         * solib-svr4.c (disable_probes_interface): Remove parameter.
10916         (svr4_handle_solib_event): Use make_scope_exit.
10917
10918 2019-03-06  Tom Tromey  <tom@tromey.com>
10919
10920         * remote.c (struct stop_reply_deleter): Remove.
10921         (stop_reply_up): Update.
10922         (struct stop_reply): Derive from notif_event.  Don't typedef.
10923         <regcache>: Now a std::vector.
10924         (stop_reply_xfree): Remove.
10925         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10926         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10927         (remote_target::discard_pending_stop_replies): Use delete.
10928         (remote_target::remote_parse_stop_reply): Update.
10929         (remote_target::process_stop_reply): Update.
10930         * remote-notif.h (struct notif_event): Add virtual destructor.
10931         Remove "dtr" member.
10932         (struct notif_client) <alloc_event>: Return a unique_ptr.
10933         (notif_event_xfree): Don't declare.
10934         (notif_event_up): New typedef.
10935         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10936         (notif_event_xfree, do_notif_event_xfree): Remove.
10937         (remote_notif_state_xfree): Update.
10938
10939 2019-03-06  Tom Tromey  <tom@tromey.com>
10940
10941         * infrun.c (displaced_step_clear_cleanup): Now a
10942         forward_scope_exit type.
10943         (displaced_step_prepare_throw): Update.
10944         (displaced_step_fixup): Update.
10945
10946 2019-03-06  Tom Tromey  <tom@tromey.com>
10947
10948         * inferior.h (class inferior): Update comment.
10949         * gdbthread.h (class thread_info): Update comment.
10950
10951 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10952             Tom Tromey  <tom@tromey.com>
10953
10954         * stabsread.h (struct stab_section_list): Remove.
10955         (coffstab_build_psymtabs): Update.
10956         * dbxread.c (symbuf_sections): Now a std::vector.
10957         (sect_idx): New global.
10958         (fill_symbuf): Update.
10959         (coffstab_build_psymtabs): Change type of stabsects parameter.
10960         Update.
10961         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10962         std::vector.
10963         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10964         (coff_locate_sections): Update.
10965         (coff_symfile_read): Remove cleanups.  Update.
10966         (init_stringtab): Add storage parameter.
10967         (free_stringtab, free_stringtab_cleanup): Remove.
10968         (init_lineno): Add storage parameter.
10969         (free_linetab, free_linetab_cleanup): Remove.
10970
10971 2019-03-06  Pedro Alves  <palves@redhat.com>
10972
10973         * linux-fork.c (fork_info::clobber_regs): Delete.
10974         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10975         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10976         comment.  Adjust.
10977         (scoped_switch_fork_info::scoped_switch_fork_info)
10978         (checkpoint_command, linux_fork_context): Adjust
10979         fork_save_infrun_state calls.
10980
10981 2019-03-06  Pedro Alves  <palves@redhat.com>
10982
10983         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10984         (inf_has_multiple_threads): Return 'bool' and rewrite using
10985         inferior_info::threads().
10986
10987 2019-03-06  Pedro Alves  <palves@redhat.com>
10988
10989         * linux-fork.c: Include <list>.
10990         (fork_list): Now a std::list instance.
10991         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10992         (forks_exist_p, find_last_fork): Adjust.
10993         (new_fork): Delete.
10994         (one_fork_p): New.
10995         (add_fork): Adjust.
10996         (free_fork): Delete, folded into fork_info::~fork_info().
10997         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10998         Adjust.
10999         (init_fork_list): Delete.
11000         (linux_fork_killall, linux_fork_mourn_inferior)
11001         (linux_fork_detach, info_checkpoints_command): Adjust.
11002         (_initialize_linux_fork): No longer call init_fork_list.
11003
11004 2019-03-06  Pedro Alves  <palves@redhat.com>
11005
11006         * linux-fork.c (new_fork): New, split out of ...
11007         (add_fork): ... this.  Return void.  Move "first fork" special
11008         case from here, to ...
11009         (checkpoint_command): ... here.
11010         * linux-linux.h (add_fork): Return void.
11011
11012 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11013
11014         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11015
11016 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11017             Chris January  <chris.january@arm.com>
11018             David Lecomber  <david.lecomber@arm.com>
11019
11020         * f-exp.y: New token, UNOP_INTRINSIC.
11021         (exp): New pattern using UNOP_INTRINSIC token.
11022         (f77_keywords): Add 'abs' keyword.
11023         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11024         (value_from_host_double): New function.
11025         (evaluate_subexp_f): Support UNOP_ABS.
11026
11027 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11028
11029         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11030         types.
11031
11032 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11033
11034         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11035         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11036         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11037
11038 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11039
11040         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11041
11042 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11043             Chris January  <chris.january@arm.com>
11044
11045         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11046         * f-exp.y: Define 'KIND' token.
11047         (exp): New pattern for KIND expressions.
11048         (ptype): Handle types with a kind extension.
11049         (direct_abs_decl): Extend to spot kind extensions.
11050         (f77_keywords): Add 'kind' to the list.
11051         (push_kind_type): New function.
11052         (convert_to_kind_type): New function.
11053         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11054         * parse.c (operator_length_standard): Likewise.
11055         * parser-defs.h (enum type_pieces): Add tp_kind.
11056         * std-operator.def: Add UNOP_KIND.
11057
11058 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11059
11060         * f-exp.y (f_parse): Set yydebug.
11061
11062 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11063
11064         * f-lang.c (evaluate_subexp_f): New function.
11065         (exp_descriptor_f): New global.
11066         (f_language_defn): Use exp_descriptor_f instead of
11067         exp_descriptor_standard.
11068
11069 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11070
11071         * f-exp.y (struct token): Add comments.
11072         (dot_ops): Remove uppercase versions and the end marker.
11073         (f77_keywords): Likewise.
11074         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11075         entries in the dot_ops array are case insensitive, and use
11076         strncasecmp to compare strings.  Also some whitespace cleanup in
11077         this area.  Similar for the f77_keywords array, except entries in
11078         this list might be case sensitive.
11079
11080 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11081
11082         * f-exp.y (struct f77_boolean_val): Add comments.
11083         (boolean_values): Remove uppercase versions, and end marker.
11084         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11085         and use strncasecmp to achieve case insensitivity.  Additionally,
11086         perform whitespace cleanup around this code.
11087
11088 2019-03-06  Tom Tromey  <tromey@adacore.com>
11089
11090         * remote-sim.c (gdbsim_target_open): Use result of
11091         gdb_argv::release.
11092
11093 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11094         Dirk Schubert  <dirk.schubert@arm.com>
11095         Chris January  <chris.january@arm.com>
11096
11097         * eval.c (evaluate_subexp_standard): Call Fortran argument
11098         wrapping logic.
11099         * f-lang.c (struct value): A value which can be passed into a
11100         Fortran function call.
11101         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11102         where appropriate.
11103         (struct type): Value ready for a Fortran function call.
11104         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11105         is needed.
11106         * f-lang.h (fortran_argument_convert): Declaration.
11107         (fortran_preserve_arg_pointer): Declaration.
11108         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11109
11110 2019-03-05  Tom Tromey  <tromey@adacore.com>
11111
11112         * python/py-prettyprint.c (print_string_repr): Remove #if.
11113         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11114
11115 2019-03-05  Tom Tromey  <tromey@adacore.com>
11116
11117         * target.c (the_dummy_target): Move later.  Change type to
11118         "dummy_target".
11119         (initialize_targets): Don't initialize the_dummy_target.
11120
11121 2019-03-05  Tom Tromey  <tromey@adacore.com>
11122
11123         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11124         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11125
11126 2019-03-05  Tom Tromey  <tromey@adacore.com>
11127
11128         * windows-nat.c (windows_nat_target::attach)
11129         (windows_nat_target::detach): Don't call gdb_flush.
11130         * valprint.c (generic_val_print, val_print, val_print_string):
11131         Don't call gdb_flush.
11132         * utils.c (defaulted_query): Don't call gdb_flush.
11133         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11134         * target.c (target_announce_detach): Don't call gdb_flush.
11135         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11136         * remote.c (extended_remote_target::attach): Don't call
11137         gdb_flush.
11138         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11139         * printcmd.c (do_examine): Don't call gdb_flush.
11140         (info_display_command): Don't call gdb_flush.
11141         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11142         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11143         * memattr.c (info_mem_command): Don't call gdb_flush.
11144         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11145         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11146         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11147         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11148         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11149         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11150         (gnu_nat_target::detach): Don't call gdb_flush.
11151         * f-valprint.c (f_val_print): Don't call gdb_flush.
11152         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11153         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11154         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11155         gdb_flush.
11156         * c-valprint.c (c_val_print): Don't call gdb_flush.
11157         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11158
11159 2019-03-05  Tom Tromey  <tromey@adacore.com>
11160
11161         * varobj.c (update_dynamic_varobj_children): Update.
11162         (install_default_visualizer): Use reset, not release.
11163         * value.c (set_internalvar): Update.
11164         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11165         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11166         ATTRIBUTE_UNUSED_RESULT.
11167
11168 2019-03-05  Tom Tromey  <tromey@adacore.com>
11169
11170         * remote.c (class scoped_remote_fd) <release>: Add
11171         ATTRIBUTE_UNUSED_RESULT.
11172
11173 2019-03-05  Tom Tromey  <tromey@adacore.com>
11174
11175         * macroexp.c (struct macro_buffer) <release>: Add
11176         ATTRIBUTE_UNUSED_RESULT.
11177
11178 2019-03-05  Tom Tromey  <tromey@adacore.com>
11179
11180         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11181         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11182         ATTRIBUTE_UNUSED_RESULT.
11183
11184 2019-03-05  Tom Tromey  <tromey@adacore.com>
11185
11186         * common/scoped_fd.h (class scoped_fd) <release>: Add
11187         ATTRIBUTE_UNUSED_RESULT.
11188
11189 2019-03-05  Tom Tromey  <tromey@adacore.com>
11190
11191         * parser-defs.h (struct parser_state) <release>: Add
11192         ATTRIBUTE_UNUSED_RESULT.
11193
11194 2019-03-05  Tom Tromey  <tromey@adacore.com>
11195
11196         * utils.h (class gdb_argv) <release>: Add
11197         ATTRIBUTE_UNUSED_RESULT.
11198         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11199
11200 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11201
11202         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11203         for-loop range, to avoid compiler warnings.
11204
11205         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11206         avoid compiler warnings about unused variables.
11207
11208         * NEWS: Mention end of support for native debugging on MS-Windows
11209         before XP.
11210
11211         PR gdb/24292
11212         * common/netstuff.c:
11213         * gdbserver/gdbreplay.c
11214         * gdbserver/remote-utils.c:
11215         * ser-tcp.c:
11216         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11217         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11218         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11219         'getaddrinfo' and 'freeaddrinfo' were not available before
11220         Windows XP, and mingw.org's MinGW headers by default define
11221         _WIN32_WINNT to 0x500.
11222
11223 2019-03-01  Gary Benson <gbenson@redhat.com>
11224
11225         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11226
11227 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11228             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11229
11230         PR gdb/8527
11231         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11232         set_sigint_trap, clear_sigint_trap.
11233
11234 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11235
11236         * target.c (target_detach): Clear the regcache and the
11237         frame cache.
11238
11239 2019-02-27  Pedro Alves  <palves@redhat.com>
11240
11241         * utils.c (set_screen_size): When we cap the height/width sizes,
11242         tweak the corresponding command variable to show "unlimited":
11243
11244 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11245             Pedro Alves  <palves@redhat.com>
11246
11247         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11248         before calling rl_set_screen_size.
11249
11250 2019-02-27  Tom Tromey  <tromey@adacore.com>
11251
11252         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11253         define.
11254         * python/py-value.c: Remove Python 2.4 workaround.
11255         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11256         workaround.
11257         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11258         Python 2.4 workaround.
11259         * python/python-internal.h: Remove Python 2.4 comment.
11260         (Py_ssize_t): Don't define.
11261         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11262         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11263         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11264         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11265         * python/python.c (do_start_initialization): Remove Python 2.4
11266         workaround.
11267         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11268         (print_children): Remove Python 2.4 workaround.
11269         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11270         workaround.
11271         (CHARBUFFERPROC_NAME): Remove.
11272         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11273         Python 2.4 workaround.
11274
11275 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11276
11277         * NEWS: Note minimum Python version.
11278
11279 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11280
11281         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11282         code from these functions.  Remove corresponding ifdefs.  Use
11283         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11284         Remove gotos and target of gotos.
11285         (infpy_search_memory): Likewise.
11286
11287 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11288
11289         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11290         (hppa_gdbarch_init): Don't register deleted functions with
11291         gdbarch.
11292
11293 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11294
11295         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11296         (h8300_unwind_sp): Delete.
11297         (h8300_dummy_id): Delete.
11298         (h8300_gdbarch_init): Don't register deleted functions with
11299         gdbarch.
11300
11301 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11302
11303         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11304         (ft32_unwind_pc): Delete.
11305         (ft32_unwind_sp): Delete.
11306         (ft32_gdbarch_init): Don't register deleted functions with
11307         gdbarch.
11308
11309 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11310
11311         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11312         (frv_unwind_pc): Delete.
11313         (frv_unwind_sp): Delete.
11314         (frv_gdbarch_init): Don't register deleted functions with
11315         gdbarch.
11316
11317 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11318
11319         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11320         (riscv_unwind_pc): Delete.
11321         (riscv_unwind_sp): Delete.
11322         (riscv_gdbarch_init): Don't register deleted functions with
11323         gdbarch.
11324
11325 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11326
11327         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11328         (csky_unwind_pc): Delete.
11329         (csky_unwind_sp): Delete.
11330         (csky_gdbarch_init): Don't register deleted functions with
11331         gdbarch.
11332
11333 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11334
11335         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11336         (cris_unwind_pc): Delete.
11337         (cris_unwind_sp): Delete.
11338         (cris_gdbarch_init): Don't register deleted functions with
11339         gdbarch.
11340
11341 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11342
11343         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11344         (bfin_unwind_pc): Delete.
11345         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11346
11347 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11348
11349         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11350         (arm_unwind_pc): Delete.
11351         (arm_unwind_sp): Delete.
11352         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11353
11354 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11355
11356         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11357         (arc_unwind_pc): Delete.
11358         (arc_unwind_sp): Delete.
11359         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11360
11361 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11362
11363         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11364         (alpha_unwind_pc): Delete.
11365         (alpha_gdbarch_init): Don't register deleted functions with
11366         gdbarch.
11367
11368 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11369
11370         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11371         (aarch64_unwind_pc): Delete.
11372         (aarch64_unwind_sp): Delete.
11373         (aarch64_gdbarch_init): Don't register deleted functions with
11374         gdbarch.
11375
11376 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11377
11378         * gdbtypes.c (type_align): Don't consider static members when
11379         computing structure alignment.
11380
11381 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11382
11383         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11384         return 0 for other types.
11385         * arch-utils.c (default_type_align): Always return 0.
11386         * gdbarch.h: Regenerate.
11387         * gdbarch.sh (type_align): Extend comment.
11388         * gdbtypes.c (type_align): Add additional comments, always call
11389         gdbarch_type_align before applying the default rules.
11390         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11391         generic code will then apply a suitable default.
11392         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11393         types, return 0 for other types.
11394
11395 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11396
11397         * NEWS: Create a new section for the next release branch.
11398         Rename the section of the current branch, now that it has
11399         been cut.
11400
11401 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11402
11403         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11404         * version.in: Bump version to 8.3.50.DATE-git.
11405
11406 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11407
11408         * aix-thread.c (ptid_cmp): Remove unused variable.
11409         (get_signaled_thread): Likewise.
11410         (store_regs_user_thread): Likewise.
11411         (store_regs_kernel_thread): Likewise.
11412         (fetch_regs_kernel_thread): Remove shadowed variable.
11413
11414 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11415
11416         * features/riscv/32bit-cpu.xml: Add register numbers.
11417         * features/riscv/32bit-fpu.c: Regenerate.
11418         * features/riscv/32bit-fpu.xml: Add register numbers.
11419         * features/riscv/64bit-cpu.xml: Add register numbers.
11420         * features/riscv/64bit-fpu.c: Regenerate.
11421         * features/riscv/64bit-fpu.xml: Add register numbers.
11422
11423 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11424
11425         * NEWS: Mention two argument form of gdb.Value constructor.
11426         * python/py-value.c (convert_buffer_and_type_to_value): New
11427         function.
11428         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11429         Add support for handling an optional second argument.  Call
11430         convert_buffer_and_type_to_value as appropriate.
11431         * python/python-internal.h (Py_buffer_deleter): New struct.
11432         (Py_buffer_up): New typedef.
11433
11434 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11435
11436         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11437         instead of releasing ownership.
11438
11439 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11440
11441         * dwarf2read.c (open_and_init_dwp_file): Call
11442         elf_numsections instead of bfd_count_sections to initialize
11443         dwp_file->num_sections.
11444
11445 2019-02-25  Tom Tromey  <tromey@adacore.com>
11446
11447         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11448
11449 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11450
11451         * gcore.in: Add '--readnever' option when invoking GDB.
11452
11453 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11454
11455         * MAINTAINERS: Update my email address.
11456
11457 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11458
11459         * build-id.c (build_id_to_debug_bfd_1): New function.
11460         (build_id_to_debug_bfd): Look for separate debug file in
11461         sysroot.
11462
11463 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11464
11465         * gdbarch.sh: Update the copyright year range that is placed into
11466         generated files.
11467
11468 2019-02-22  Keith Seitz  <keiths@redhat.com>
11469
11470         PR symtab/23853
11471         * linespec.c (create_sals_line_offset): Search for the default
11472         symtab's filename instead of its fullname.
11473
11474 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11475
11476         * NEWS: Update style defaults.
11477
11478 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11479
11480         * main.c (captured_main_1): Disable styling in batch mode.
11481
11482 2019-02-20  Tom Tromey  <tom@tromey.com>
11483
11484         * symtab.c (symtab_symbol_info): Fix typos.
11485
11486 2019-02-20  Tom Tromey  <tromey@adacore.com>
11487
11488         * findcmd.c (_initialize_mem_search): Use upper case for
11489         metasyntactic variables.
11490
11491 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11492
11493         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11494         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11495
11496 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11497
11498         * top.h (source_file_name): Change to std::string.
11499         * top.c (source_file_name): Likewise.
11500         (command_line_input): Adjust.
11501         * cli/cli-script.c (script_from_file): Adjust.
11502
11503 2019-02-19  Tom Tromey  <tromey@adacore.com>
11504
11505         * ravenscar-thread.c
11506         (ravenscar_thread_target::update_thread_list): Don't call
11507         ada_build_task_list.
11508         * ada-lang.h (ada_build_task_list): Don't declare.
11509         * ada-tasks.c (struct ada_tasks_inferior_data)
11510         <task_list_valid_p>: Now bool.
11511         (read_known_tasks, ada_task_list_changed)
11512         (ada_tasks_invalidate_inferior_data): Update.
11513         (read_known_tasks_array): Return bool.
11514         (read_known_tasks_list): Likewise.
11515         (read_known_tasks): Return void.
11516         (ada_build_task_list): Now static.
11517
11518 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11519
11520         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11521         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11522
11523 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11524
11525         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11526         variant for ada_tasks_pspace_data_handle and
11527         ada_tasks_inferior_data_handle.
11528         (ada_tasks_pspace_data_cleanup): New function.
11529         (ada_tasks_inferior_data_cleanup): New function.
11530
11531 2019-02-17  Tom Tromey  <tom@tromey.com>
11532
11533         * macrotab.h (macro_source_fullname): Return a std::string.
11534         * macrotab.c (macro_include, check_for_redefinition)
11535         (macro_undef, macro_lookup_definition, foreach_macro)
11536         (foreach_macro_in_scope): Update.
11537         (macro_source_fullname): Return a std::string.
11538         * macrocmd.c (show_pp_source_pos): Update.
11539
11540 2019-02-17  Tom Tromey  <tom@tromey.com>
11541
11542         * macrocmd.c (show_pp_source_pos): Style the file names.
11543
11544 2019-02-17  Tom Tromey  <tom@tromey.com>
11545
11546         PR tui/24197:
11547         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11548
11549 2019-02-17  Tom Tromey  <tom@tromey.com>
11550
11551         * ada-lang.c (user_select_syms): Use filtered printing.
11552         * utils.c (wrap_style): New global.
11553         (desired_style): Remove.
11554         (emit_style_escape): Add stream parameter.
11555         (set_output_style, reset_terminal_style, prompt_for_continue):
11556         Update.
11557         (flush_wrap_buffer): Only flush gdb_stdout.
11558         (wrap_here): Set wrap_style.
11559         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11560         treat escape sequences as a character.  Change when wrap buffer is
11561         flushed.
11562         (fputs_styled): Do not set the output style when the default is
11563         requested.
11564         * ui-style.h (struct ui_file_style) <is_default>: New method.
11565         * source.c (print_source_lines_base): Emit escape sequences in one
11566         piece.
11567
11568 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11569
11570         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11571         integers and enumeration types.
11572
11573 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11574
11575         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11576         instead of lookup_symbol_in_language
11577         (do_exact_match): New function.
11578         (ada_get_symbol_name_matcher): Return do_exact_match when
11579         doing a verbatim match.
11580
11581 2019-02-15  Tom Tromey  <tromey@adacore.com>
11582
11583         * ravenscar-thread.c (ravenscar_thread_target::resume)
11584         (ravenscar_thread_target::wait): Special case wildcard requests.
11585
11586 2019-02-15  Tom Tromey  <tromey@adacore.com>
11587
11588         * ravenscar-thread.c (base_ptid): Remove.
11589         (struct ravenscar_thread_target) <close>: New method.
11590         <m_base_ptid>: New member.
11591         <update_inferior_ptid, active_task, task_is_currently_active,
11592         runtime_initialized>: Declare methods.
11593         <ravenscar_thread_target>: Add constructor.
11594         (ravenscar_thread_target::task_is_currently_active)
11595         (ravenscar_thread_target::update_inferior_ptid)
11596         (ravenscar_runtime_initialized): Rename.  Now methods.
11597         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11598         (ravenscar_thread_target::update_thread_list): Update.
11599         (ravenscar_thread_target::active_task): Now method.
11600         (ravenscar_thread_target::store_registers)
11601         (ravenscar_thread_target::prepare_to_store)
11602         (ravenscar_thread_target::prepare_to_store)
11603         (ravenscar_thread_target::mourn_inferior): Update.
11604         (ravenscar_inferior_created): Use "new" to create target.
11605         (ravenscar_thread_target::get_ada_task_ptid): Update.
11606         (_initialize_ravenscar): Don't initialize base_ptid.
11607         (ravenscar_ops): Remove global.
11608
11609 2019-02-15  Tom Tromey  <tromey@adacore.com>
11610
11611         * target.h (push_target): Declare new overload.
11612         * target.c (push_target): New overload, taking an rvalue reference.
11613         * remote.c (remote_target::open_1): Use push_target overload.
11614         * corelow.c (core_target_open): Use push_target overload.
11615
11616 2019-02-15  Tom Tromey  <tromey@adacore.com>
11617
11618         * ravenscar-thread.c (is_ravenscar_task)
11619         (ravenscar_task_is_currently_active): Return bool.
11620         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11621         (_initialize_ravenscar): Remove "(void)".
11622         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11623         Return bool.
11624
11625 2019-02-15  Tom Tromey  <tromey@adacore.com>
11626
11627         * ravenscar-thread.c (ravenscar_runtime_initializer)
11628         (has_ravenscar_runtime, get_running_thread_id)
11629         (ravenscar_thread_target::resume): Fix indentation.
11630
11631 2019-02-15  Tom Tromey  <tromey@adacore.com>
11632
11633         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11634         from ravenscar_arch_ops.
11635         (sparc_ravenscar_ops::fetch_registers)
11636         (sparc_ravenscar_ops::store_registers): Now methods.
11637         (sparc_ravenscar_prepare_to_store): Remove.
11638         (sparc_ravenscar_ops): Redefine.
11639         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11640         methods and destructor.  Remove members.
11641         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11642         (ravenscar_thread_target::store_registers)
11643         (ravenscar_thread_target::prepare_to_store): Update.
11644         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11645         Remove.
11646         (struct ppc_ravenscar_powerpc_ops): Derive from
11647         ravenscar_arch_ops.
11648         (ppc_ravenscar_powerpc_ops::fetch_registers)
11649         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11650         (ppc_ravenscar_powerpc_ops): Redefine.
11651         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11652         (ppc_ravenscar_e500_ops::fetch_registers)
11653         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11654         (ppc_ravenscar_e500_ops): Redefine.
11655         * aarch64-ravenscar-thread.c
11656         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11657         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11658         (aarch64_ravenscar_fetch_registers)
11659         (aarch64_ravenscar_store_registers): Now methods.
11660         (aarch64_ravenscar_ops): Redefine.
11661
11662 2019-02-15  Tom Tromey  <tromey@adacore.com>
11663
11664         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11665         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11666         (ravenscar_thread_target::stopped_by_watchpoint)
11667         (ravenscar_thread_target::stopped_data_address)
11668         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11669
11670 2019-02-15  Tom Tromey  <tromey@adacore.com>
11671
11672         * ravenscar-thread.c: Fix some typos.
11673
11674 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11675             Tom Tromey  <tromey@adacore.com>
11676
11677         * ada-lang.c (ada_exception_sal): Change addr_string to a
11678         std::string.
11679         (create_ada_exception_catchpoint): Update.
11680
11681 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11682             Tom Tromey  <tromey@adacore.com>
11683
11684         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11685         (bp_location_ops): Remove.
11686         (base_breakpoint_allocate_location): Update.
11687         (free_bp_location): Update.
11688         * ada-lang.c (class ada_catchpoint_location)
11689         <ada_catchpoint_location>: Remove ops parameter.
11690         (ada_catchpoint_location_dtor): Remove.
11691         (ada_catchpoint_location_ops): Remove.
11692         (allocate_location_exception): Update.
11693         * breakpoint.h (struct bp_location_ops): Remove.
11694         (class bp_location) <bp_location>: Remove bp_location_ops
11695         parameter.
11696         <~bp_location>: Add destructor.
11697         <ops>: Remove.
11698
11699 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11700             Pedro Alves  <palves@redhat.com>
11701
11702         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11703         'PATH_MAX'.
11704
11705 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11706             Samuel Thibault  <samuel.thibault@gnu.org>
11707             Thomas Schwinge  <thomas@codesourcery.com>
11708
11709         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11710         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11711
11712 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11713
11714         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11715         (check_empty): Use "const char *".
11716
11717         * gnu-nat.c (gnu_nat_target::detach): Instead of
11718         'detach_inferior (pid)' call
11719         'detach_inferior (find_inferior_pid (pid))'.
11720
11721         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11722         'nat/fork-inferior.o'.
11723         * gnu-nat.c: #include "nat/fork-inferior.h".
11724
11725         * gnu-nat.c (gnu_nat_target::detach): Instead of
11726         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11727         * gnu-nat.h: #include "inf-child.h".
11728         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11729         'i386_gnu_nat_target::fetch_registers'.
11730         (gnu_store_registers): Rename/move to
11731         'i386_gnu_nat_target::store_registers'.
11732
11733         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11734         * gnu-nat.h (mach_thread_info): New function.
11735         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11736
11737         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11738
11739 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11740
11741         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11742
11743 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11744
11745         * windows-nat.c (windows_add_thread): Add new parameter
11746         "main_thread_p" with default value set to false.  Update
11747         function documentation as well as all callers.
11748         (windows_delete_thread): Likewise.
11749         (fake_create_process): Update call to windows_add_thread.
11750         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11751         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11752         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11753         call to windows_delete_thread.
11754
11755 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11756
11757         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11758
11759 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11760
11761         * symfile.c (find_separate_debug_file): Use canonical path of
11762         sysroot with child_path instead of gdb_sysroot if it is valid.
11763
11764 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11765
11766         * symfile.c (find_separate_debug_file): Use child_path to
11767         determine if an object file is under a sysroot.
11768
11769 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11770
11771         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11772         unittests/child-path-selftests.c.
11773         * common/pathstuff.c (child_path): New function.
11774         * common/pathstuff.h (child_path): New prototype.
11775         * unittests/child-path-selftests.c: New file.
11776
11777 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11778
11779         * symfile.c (find_separate_debug_file): Look for separate debug
11780         files in debug directories under the sysroot.
11781
11782 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11783
11784         * symtab.h (struct minimal_symbol data_p): New const method.
11785         (struct minimal_symbol text_p): Likewise.
11786         * symtab.c (output_source_filename): Use file name style
11787         to print file name.
11788         (print_symbol_info): Likewise.
11789         (print_msymbol_info): Use address style to print addresses.
11790         Use function name style to print executable text symbols.
11791         (expand_symtab_containing_pc): Use data_p.
11792         (find_pc_sect_compunit_symtab): Likewise.
11793
11794 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11795
11796         * breakpoint.c (describe_other_breakpoints): Use address style
11797         to print addresses.
11798         (say_where): Likewise.
11799
11800 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11801
11802         * ada-typeprint.c (print_func_type): Print function name
11803         style to print function name.
11804         * c-typeprint.c (c_print_type_1): Likewise.
11805
11806 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11807
11808         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11809         for execve.
11810
11811 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11812
11813         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11814         type_stack.
11815
11816 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11817
11818         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11819         TYPE_CODE_REF types.
11820
11821 2019-02-08  Jim Wilson  <jimw@sifive.com>
11822
11823         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11824         (riscv_linux_fregset): New.
11825         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11826
11827 2019-02-07  Tom Tromey  <tom@tromey.com>
11828
11829         * thread.c (thread_cancel_execution_command): Update.
11830         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11831         methods.
11832         (struct thread_fsm_ops): Remove.
11833         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11834         (thread_fsm_should_stop, thread_fsm_return_value)
11835         (thread_fsm_set_finished, thread_fsm_finished_p)
11836         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11837         Don't declare.
11838         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11839         * infrun.c (clear_proceed_status_thread)
11840         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11841         (print_stop_event): Update.
11842         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11843         Add constructor.
11844         (step_command_fsm_ops): Remove.
11845         (new_step_command_fsm): Remove.
11846         (step_1): Update.
11847         (step_command_fsm::should_stop): Rename from
11848         step_command_fsm_should_stop.
11849         (step_command_fsm::clean_up): Rename from
11850         step_command_fsm_clean_up.
11851         (step_command_fsm::do_async_reply_reason): Rename from
11852         step_command_fsm_async_reply_reason.
11853         (struct until_next_fsm): Inherit from thread_fsm.  Add
11854         constructor.
11855         (until_next_fsm_ops): Remove.
11856         (new_until_next_fsm): Remove.
11857         (until_next_fsm::should_stop): Rename from
11858         until_next_fsm_should_stop.
11859         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11860         (until_next_fsm::do_async_reply_reason): Rename from
11861         until_next_fsm_async_reply_reason.
11862         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11863         constructor.  Change type of breakpoint.
11864         (finish_command_fsm_ops): Remove.
11865         (new_finish_command_fsm): Remove.
11866         (finish_command_fsm::should_stop): Rename from
11867         finish_command_fsm_should_stop.
11868         (finish_command_fsm::clean_up): Rename from
11869         finish_command_fsm_clean_up.
11870         (finish_command_fsm::return_value): Rename from
11871         finish_command_fsm_return_value.
11872         (finish_command_fsm::do_async_reply_reason): Rename from
11873         finish_command_fsm_async_reply_reason.
11874         (finish_command): Update.
11875         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11876         Add constructor.
11877         (call_thread_fsm_ops): Remove.
11878         (call_thread_fsm::call_thread_fsm): Rename from
11879         new_call_thread_fsm.
11880         (call_thread_fsm::should_stop): Rename from
11881         call_thread_fsm_should_stop.
11882         (call_thread_fsm::should_notify_stop): Rename from
11883         call_thread_fsm_should_notify_stop.
11884         (run_inferior_call, call_function_by_hand_dummy): Update.
11885         * cli/cli-interp.c (should_print_stop_to_console): Update.
11886         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11887         Add constructor.  Change type of location_breakpoint,
11888         caller_breakpoint.
11889         (until_break_fsm_ops): Remove.
11890         (new_until_break_fsm): Remove.
11891         (until_break_fsm::should_stop): Rename from
11892         until_break_fsm_should_stop.
11893         (until_break_fsm::clean_up): Rename from
11894         until_break_fsm_clean_up.
11895         (until_break_fsm::do_async_reply_reason): Rename from
11896         until_break_fsm_async_reply_reason.
11897         (until_break_command): Update.
11898         * thread-fsm.c: Remove.
11899         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11900
11901 2019-02-07  Tom Tromey  <tom@tromey.com>
11902
11903         * yy-remap.h: Add include guard.
11904         * xtensa-tdep.h: Add include guard.
11905         * xcoffread.h: Rename include guard.
11906         * varobj-iter.h: Add include guard.
11907         * tui/tui.h: Rename include guard.
11908         * tui/tui-winsource.h: Rename include guard.
11909         * tui/tui-wingeneral.h: Rename include guard.
11910         * tui/tui-windata.h: Rename include guard.
11911         * tui/tui-win.h: Rename include guard.
11912         * tui/tui-stack.h: Rename include guard.
11913         * tui/tui-source.h: Rename include guard.
11914         * tui/tui-regs.h: Rename include guard.
11915         * tui/tui-out.h: Rename include guard.
11916         * tui/tui-layout.h: Rename include guard.
11917         * tui/tui-io.h: Rename include guard.
11918         * tui/tui-hooks.h: Rename include guard.
11919         * tui/tui-file.h: Rename include guard.
11920         * tui/tui-disasm.h: Rename include guard.
11921         * tui/tui-data.h: Rename include guard.
11922         * tui/tui-command.h: Rename include guard.
11923         * tic6x-tdep.h: Add include guard.
11924         * target/waitstatus.h: Rename include guard.
11925         * target/wait.h: Rename include guard.
11926         * target/target.h: Rename include guard.
11927         * target/resume.h: Rename include guard.
11928         * target-float.h: Rename include guard.
11929         * stabsread.h: Add include guard.
11930         * rs6000-tdep.h: Add include guard.
11931         * riscv-fbsd-tdep.h: Add include guard.
11932         * regformats/regdef.h: Rename include guard.
11933         * record.h: Rename include guard.
11934         * python/python.h: Rename include guard.
11935         * python/python-internal.h: Rename include guard.
11936         * python/py-stopevent.h: Rename include guard.
11937         * python/py-ref.h: Rename include guard.
11938         * python/py-record.h: Rename include guard.
11939         * python/py-record-full.h: Rename include guard.
11940         * python/py-record-btrace.h: Rename include guard.
11941         * python/py-instruction.h: Rename include guard.
11942         * python/py-events.h: Rename include guard.
11943         * python/py-event.h: Rename include guard.
11944         * procfs.h: Add include guard.
11945         * proc-utils.h: Add include guard.
11946         * p-lang.h: Add include guard.
11947         * or1k-tdep.h: Rename include guard.
11948         * observable.h: Rename include guard.
11949         * nto-tdep.h: Rename include guard.
11950         * nat/x86-linux.h: Rename include guard.
11951         * nat/x86-linux-dregs.h: Rename include guard.
11952         * nat/x86-gcc-cpuid.h: Add include guard.
11953         * nat/x86-dregs.h: Rename include guard.
11954         * nat/x86-cpuid.h: Rename include guard.
11955         * nat/ppc-linux.h: Rename include guard.
11956         * nat/mips-linux-watch.h: Rename include guard.
11957         * nat/linux-waitpid.h: Rename include guard.
11958         * nat/linux-ptrace.h: Rename include guard.
11959         * nat/linux-procfs.h: Rename include guard.
11960         * nat/linux-osdata.h: Rename include guard.
11961         * nat/linux-nat.h: Rename include guard.
11962         * nat/linux-namespaces.h: Rename include guard.
11963         * nat/linux-btrace.h: Rename include guard.
11964         * nat/glibc_thread_db.h: Rename include guard.
11965         * nat/gdb_thread_db.h: Rename include guard.
11966         * nat/gdb_ptrace.h: Rename include guard.
11967         * nat/fork-inferior.h: Rename include guard.
11968         * nat/amd64-linux-siginfo.h: Rename include guard.
11969         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11970         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11971         * nat/aarch64-linux.h: Rename include guard.
11972         * nat/aarch64-linux-hw-point.h: Rename include guard.
11973         * mn10300-tdep.h: Add include guard.
11974         * mips-linux-tdep.h: Add include guard.
11975         * mi/mi-parse.h: Rename include guard.
11976         * mi/mi-out.h: Rename include guard.
11977         * mi/mi-main.h: Rename include guard.
11978         * mi/mi-interp.h: Rename include guard.
11979         * mi/mi-getopt.h: Rename include guard.
11980         * mi/mi-console.h: Rename include guard.
11981         * mi/mi-common.h: Rename include guard.
11982         * mi/mi-cmds.h: Rename include guard.
11983         * mi/mi-cmd-break.h: Rename include guard.
11984         * m2-lang.h: Add include guard.
11985         * location.h: Rename include guard.
11986         * linux-record.h: Rename include guard.
11987         * linux-nat.h: Add include guard.
11988         * linux-fork.h: Add include guard.
11989         * i386-darwin-tdep.h: Rename include guard.
11990         * hppa-linux-offsets.h: Add include guard.
11991         * guile/guile.h: Rename include guard.
11992         * guile/guile-internal.h: Rename include guard.
11993         * gnu-nat.h: Rename include guard.
11994         * gdb-stabs.h: Rename include guard.
11995         * frv-tdep.h: Add include guard.
11996         * f-lang.h: Add include guard.
11997         * event-loop.h: Add include guard.
11998         * darwin-nat.h: Rename include guard.
11999         * cp-abi.h: Rename include guard.
12000         * config/sparc/nm-sol2.h: Rename include guard.
12001         * config/nm-nto.h: Rename include guard.
12002         * config/nm-linux.h: Add include guard.
12003         * config/i386/nm-i386gnu.h: Rename include guard.
12004         * config/djgpp/nl_types.h: Rename include guard.
12005         * config/djgpp/langinfo.h: Rename include guard.
12006         * compile/gcc-cp-plugin.h: Add include guard.
12007         * compile/gcc-c-plugin.h: Add include guard.
12008         * compile/compile.h: Rename include guard.
12009         * compile/compile-object-run.h: Rename include guard.
12010         * compile/compile-object-load.h: Rename include guard.
12011         * compile/compile-internal.h: Rename include guard.
12012         * compile/compile-cplus.h: Rename include guard.
12013         * compile/compile-c.h: Rename include guard.
12014         * common/xml-utils.h: Rename include guard.
12015         * common/x86-xstate.h: Rename include guard.
12016         * common/version.h: Rename include guard.
12017         * common/vec.h: Rename include guard.
12018         * common/tdesc.h: Rename include guard.
12019         * common/selftest.h: Rename include guard.
12020         * common/scoped_restore.h: Rename include guard.
12021         * common/scoped_mmap.h: Rename include guard.
12022         * common/scoped_fd.h: Rename include guard.
12023         * common/safe-iterator.h: Rename include guard.
12024         * common/run-time-clock.h: Rename include guard.
12025         * common/refcounted-object.h: Rename include guard.
12026         * common/queue.h: Rename include guard.
12027         * common/ptid.h: Rename include guard.
12028         * common/print-utils.h: Rename include guard.
12029         * common/preprocessor.h: Rename include guard.
12030         * common/pathstuff.h: Rename include guard.
12031         * common/observable.h: Rename include guard.
12032         * common/netstuff.h: Rename include guard.
12033         * common/job-control.h: Rename include guard.
12034         * common/host-defs.h: Rename include guard.
12035         * common/gdb_wait.h: Rename include guard.
12036         * common/gdb_vecs.h: Rename include guard.
12037         * common/gdb_unlinker.h: Rename include guard.
12038         * common/gdb_unique_ptr.h: Rename include guard.
12039         * common/gdb_tilde_expand.h: Rename include guard.
12040         * common/gdb_sys_time.h: Rename include guard.
12041         * common/gdb_string_view.h: Rename include guard.
12042         * common/gdb_splay_tree.h: Rename include guard.
12043         * common/gdb_setjmp.h: Rename include guard.
12044         * common/gdb_ref_ptr.h: Rename include guard.
12045         * common/gdb_optional.h: Rename include guard.
12046         * common/gdb_locale.h: Rename include guard.
12047         * common/gdb_assert.h: Rename include guard.
12048         * common/filtered-iterator.h: Rename include guard.
12049         * common/filestuff.h: Rename include guard.
12050         * common/fileio.h: Rename include guard.
12051         * common/environ.h: Rename include guard.
12052         * common/common-utils.h: Rename include guard.
12053         * common/common-types.h: Rename include guard.
12054         * common/common-regcache.h: Rename include guard.
12055         * common/common-inferior.h: Rename include guard.
12056         * common/common-gdbthread.h: Rename include guard.
12057         * common/common-exceptions.h: Rename include guard.
12058         * common/common-defs.h: Rename include guard.
12059         * common/common-debug.h: Rename include guard.
12060         * common/cleanups.h: Rename include guard.
12061         * common/buffer.h: Rename include guard.
12062         * common/btrace-common.h: Rename include guard.
12063         * common/break-common.h: Rename include guard.
12064         * cli/cli-utils.h: Rename include guard.
12065         * cli/cli-style.h: Rename include guard.
12066         * cli/cli-setshow.h: Rename include guard.
12067         * cli/cli-script.h: Rename include guard.
12068         * cli/cli-interp.h: Rename include guard.
12069         * cli/cli-decode.h: Rename include guard.
12070         * cli/cli-cmds.h: Rename include guard.
12071         * charset-list.h: Add include guard.
12072         * buildsym-legacy.h: Rename include guard.
12073         * bfin-tdep.h: Add include guard.
12074         * ax.h: Rename include guard.
12075         * arm-linux-tdep.h: Add include guard.
12076         * arm-fbsd-tdep.h: Add include guard.
12077         * arch/xtensa.h: Rename include guard.
12078         * arch/tic6x.h: Add include guard.
12079         * arch/i386.h: Add include guard.
12080         * arch/arm.h: Rename include guard.
12081         * arch/arm-linux.h: Rename include guard.
12082         * arch/arm-get-next-pcs.h: Rename include guard.
12083         * arch/amd64.h: Add include guard.
12084         * arch/aarch64-insn.h: Rename include guard.
12085         * arch-utils.h: Rename include guard.
12086         * annotate.h: Add include guard.
12087         * amd64-darwin-tdep.h: Rename include guard.
12088         * aarch64-linux-tdep.h: Add include guard.
12089         * aarch64-fbsd-tdep.h: Add include guard.
12090         * aarch32-linux-nat.h: Add include guard.
12091
12092 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12093
12094         * macrotab.c (macro_define_internal): New function that
12095         factorizes macro_define_object_internal and macro_define_function
12096         code.
12097         (macro_define_object_internal): Use macro_define_internal.
12098         (macro_define_function): Likewise.
12099
12100 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12101
12102         * macrocmd.c (extract_identifier): Return
12103         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12104         callers.
12105
12106 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12107
12108         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12109
12110 2019-02-05  Tom Tromey  <tom@tromey.com>
12111
12112         * target.c (target_stack::unpush): Move assertion earlier.
12113
12114 2019-01-30  Tom Tromey  <tom@tromey.com>
12115
12116         PR python/23615:
12117         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12118         (gdbpy_parse_and_eval): Likewise.
12119         * python/python-internal.h (gdbpy_allow_threads): New class.
12120
12121 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12122
12123         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12124         (aarch64_fbsd_fpregmap): Move earlier.
12125         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12126         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12127         instead of individual calls to trad_frame_set_reg_addr.
12128         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12129         earlier.
12130         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12131         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12132         instead of individual calls to trad_frame_set_reg_addr.
12133
12134 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12135
12136         * CONTRIBUTE: Replace contribution list with wiki link.
12137
12138 2019-01-25  Tom Tromey  <tom@tromey.com>
12139
12140         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12141
12142 2019-01-25  Tom Tromey  <tom@tromey.com>
12143
12144         * xtensa-linux-nat.c: Fix common/ includes.
12145         * xml-support.h: Fix common/ includes.
12146         * xml-support.c: Fix common/ includes.
12147         * x86-linux-nat.c: Fix common/ includes.
12148         * windows-nat.c: Fix common/ includes.
12149         * varobj.h: Fix common/ includes.
12150         * varobj.c: Fix common/ includes.
12151         * value.c: Fix common/ includes.
12152         * valops.c: Fix common/ includes.
12153         * utils.c: Fix common/ includes.
12154         * unittests/xml-utils-selftests.c: Fix common/ includes.
12155         * unittests/utils-selftests.c: Fix common/ includes.
12156         * unittests/unpack-selftests.c: Fix common/ includes.
12157         * unittests/tracepoint-selftests.c: Fix common/ includes.
12158         * unittests/style-selftests.c: Fix common/ includes.
12159         * unittests/string_view-selftests.c: Fix common/ includes.
12160         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12161         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12162         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12163         * unittests/rsp-low-selftests.c: Fix common/ includes.
12164         * unittests/parse-connection-spec-selftests.c: Fix common/
12165         includes.
12166         * unittests/optional-selftests.c: Fix common/ includes.
12167         * unittests/offset-type-selftests.c: Fix common/ includes.
12168         * unittests/observable-selftests.c: Fix common/ includes.
12169         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12170         * unittests/memrange-selftests.c: Fix common/ includes.
12171         * unittests/memory-map-selftests.c: Fix common/ includes.
12172         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12173         * unittests/function-view-selftests.c: Fix common/ includes.
12174         * unittests/environ-selftests.c: Fix common/ includes.
12175         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12176         * unittests/common-utils-selftests.c: Fix common/ includes.
12177         * unittests/cli-utils-selftests.c: Fix common/ includes.
12178         * unittests/array-view-selftests.c: Fix common/ includes.
12179         * ui-file.c: Fix common/ includes.
12180         * tui/tui-io.c: Fix common/ includes.
12181         * tracepoint.h: Fix common/ includes.
12182         * tracepoint.c: Fix common/ includes.
12183         * tracefile-tfile.c: Fix common/ includes.
12184         * top.h: Fix common/ includes.
12185         * top.c: Fix common/ includes.
12186         * thread.c: Fix common/ includes.
12187         * target/waitstatus.h: Fix common/ includes.
12188         * target/waitstatus.c: Fix common/ includes.
12189         * target.h: Fix common/ includes.
12190         * target.c: Fix common/ includes.
12191         * target-memory.c: Fix common/ includes.
12192         * target-descriptions.c: Fix common/ includes.
12193         * symtab.h: Fix common/ includes.
12194         * symfile.c: Fix common/ includes.
12195         * stap-probe.c: Fix common/ includes.
12196         * spu-linux-nat.c: Fix common/ includes.
12197         * sparc-nat.c: Fix common/ includes.
12198         * source.c: Fix common/ includes.
12199         * solib.c: Fix common/ includes.
12200         * solib-target.c: Fix common/ includes.
12201         * ser-unix.c: Fix common/ includes.
12202         * ser-tcp.c: Fix common/ includes.
12203         * ser-pipe.c: Fix common/ includes.
12204         * ser-base.c: Fix common/ includes.
12205         * selftest-arch.c: Fix common/ includes.
12206         * s12z-tdep.c: Fix common/ includes.
12207         * rust-exp.y: Fix common/ includes.
12208         * rs6000-aix-tdep.c: Fix common/ includes.
12209         * riscv-tdep.c: Fix common/ includes.
12210         * remote.c: Fix common/ includes.
12211         * remote-notif.h: Fix common/ includes.
12212         * remote-fileio.h: Fix common/ includes.
12213         * remote-fileio.c: Fix common/ includes.
12214         * regcache.h: Fix common/ includes.
12215         * regcache.c: Fix common/ includes.
12216         * record-btrace.c: Fix common/ includes.
12217         * python/python.c: Fix common/ includes.
12218         * python/py-type.c: Fix common/ includes.
12219         * python/py-inferior.c: Fix common/ includes.
12220         * progspace.h: Fix common/ includes.
12221         * producer.c: Fix common/ includes.
12222         * procfs.c: Fix common/ includes.
12223         * proc-api.c: Fix common/ includes.
12224         * printcmd.c: Fix common/ includes.
12225         * ppc-linux-nat.c: Fix common/ includes.
12226         * parser-defs.h: Fix common/ includes.
12227         * osdata.c: Fix common/ includes.
12228         * obsd-nat.c: Fix common/ includes.
12229         * nat/x86-linux.c: Fix common/ includes.
12230         * nat/x86-linux-dregs.c: Fix common/ includes.
12231         * nat/x86-dregs.h: Fix common/ includes.
12232         * nat/x86-dregs.c: Fix common/ includes.
12233         * nat/ppc-linux.c: Fix common/ includes.
12234         * nat/mips-linux-watch.h: Fix common/ includes.
12235         * nat/mips-linux-watch.c: Fix common/ includes.
12236         * nat/linux-waitpid.c: Fix common/ includes.
12237         * nat/linux-ptrace.h: Fix common/ includes.
12238         * nat/linux-ptrace.c: Fix common/ includes.
12239         * nat/linux-procfs.c: Fix common/ includes.
12240         * nat/linux-personality.c: Fix common/ includes.
12241         * nat/linux-osdata.c: Fix common/ includes.
12242         * nat/linux-namespaces.c: Fix common/ includes.
12243         * nat/linux-btrace.h: Fix common/ includes.
12244         * nat/linux-btrace.c: Fix common/ includes.
12245         * nat/fork-inferior.c: Fix common/ includes.
12246         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12247         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12248         * nat/aarch64-linux.c: Fix common/ includes.
12249         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12250         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12251         * namespace.h: Fix common/ includes.
12252         * mips-linux-tdep.c: Fix common/ includes.
12253         * minsyms.c: Fix common/ includes.
12254         * mi/mi-parse.h: Fix common/ includes.
12255         * mi/mi-main.c: Fix common/ includes.
12256         * mi/mi-cmd-env.c: Fix common/ includes.
12257         * memrange.h: Fix common/ includes.
12258         * memattr.c: Fix common/ includes.
12259         * maint.h: Fix common/ includes.
12260         * maint.c: Fix common/ includes.
12261         * main.c: Fix common/ includes.
12262         * machoread.c: Fix common/ includes.
12263         * location.c: Fix common/ includes.
12264         * linux-thread-db.c: Fix common/ includes.
12265         * linux-nat.c: Fix common/ includes.
12266         * linux-fork.c: Fix common/ includes.
12267         * inline-frame.c: Fix common/ includes.
12268         * infrun.c: Fix common/ includes.
12269         * inflow.c: Fix common/ includes.
12270         * inferior.h: Fix common/ includes.
12271         * inferior.c: Fix common/ includes.
12272         * infcmd.c: Fix common/ includes.
12273         * inf-ptrace.c: Fix common/ includes.
12274         * inf-child.c: Fix common/ includes.
12275         * ia64-linux-nat.c: Fix common/ includes.
12276         * i387-tdep.c: Fix common/ includes.
12277         * i386-tdep.c: Fix common/ includes.
12278         * i386-linux-tdep.c: Fix common/ includes.
12279         * i386-linux-nat.c: Fix common/ includes.
12280         * i386-go32-tdep.c: Fix common/ includes.
12281         * i386-fbsd-tdep.c: Fix common/ includes.
12282         * i386-fbsd-nat.c: Fix common/ includes.
12283         * guile/scm-type.c: Fix common/ includes.
12284         * guile/guile.c: Fix common/ includes.
12285         * go32-nat.c: Fix common/ includes.
12286         * gnu-nat.c: Fix common/ includes.
12287         * gdbthread.h: Fix common/ includes.
12288         * gdbarch-selftests.c: Fix common/ includes.
12289         * gdb_usleep.c: Fix common/ includes.
12290         * gdb_select.h: Fix common/ includes.
12291         * gdb_bfd.c: Fix common/ includes.
12292         * gcore.c: Fix common/ includes.
12293         * fork-child.c: Fix common/ includes.
12294         * findvar.c: Fix common/ includes.
12295         * fbsd-nat.c: Fix common/ includes.
12296         * event-top.c: Fix common/ includes.
12297         * event-loop.c: Fix common/ includes.
12298         * dwarf2read.c: Fix common/ includes.
12299         * dwarf2loc.c: Fix common/ includes.
12300         * dwarf2-frame.c: Fix common/ includes.
12301         * dwarf-index-cache.c: Fix common/ includes.
12302         * dtrace-probe.c: Fix common/ includes.
12303         * disasm-selftests.c: Fix common/ includes.
12304         * defs.h: Fix common/ includes.
12305         * csky-tdep.c: Fix common/ includes.
12306         * cp-valprint.c: Fix common/ includes.
12307         * cp-support.h: Fix common/ includes.
12308         * cp-support.c: Fix common/ includes.
12309         * corelow.c: Fix common/ includes.
12310         * completer.h: Fix common/ includes.
12311         * completer.c: Fix common/ includes.
12312         * compile/compile.c: Fix common/ includes.
12313         * compile/compile-loc2c.c: Fix common/ includes.
12314         * compile/compile-cplus-types.c: Fix common/ includes.
12315         * compile/compile-cplus-symbols.c: Fix common/ includes.
12316         * command.h: Fix common/ includes.
12317         * cli/cli-dump.c: Fix common/ includes.
12318         * cli/cli-cmds.c: Fix common/ includes.
12319         * charset.c: Fix common/ includes.
12320         * build-id.c: Fix common/ includes.
12321         * btrace.h: Fix common/ includes.
12322         * btrace.c: Fix common/ includes.
12323         * breakpoint.h: Fix common/ includes.
12324         * breakpoint.c: Fix common/ includes.
12325         * ax.h:
12326         (enum agent_op): Fix common/ includes.
12327         * ax-general.c (struct aop_map): Fix common/ includes.
12328         * ax-gdb.c: Fix common/ includes.
12329         * auxv.c: Fix common/ includes.
12330         * auto-load.c: Fix common/ includes.
12331         * arm-tdep.c: Fix common/ includes.
12332         * arch/riscv.c: Fix common/ includes.
12333         * arch/ppc-linux-common.c: Fix common/ includes.
12334         * arch/i386.c: Fix common/ includes.
12335         * arch/arm.c: Fix common/ includes.
12336         * arch/arm-linux.c: Fix common/ includes.
12337         * arch/arm-get-next-pcs.c: Fix common/ includes.
12338         * arch/amd64.c: Fix common/ includes.
12339         * arch/aarch64.c: Fix common/ includes.
12340         * arch/aarch64-insn.c: Fix common/ includes.
12341         * arch-utils.c: Fix common/ includes.
12342         * amd64-windows-tdep.c: Fix common/ includes.
12343         * amd64-tdep.c: Fix common/ includes.
12344         * amd64-sol2-tdep.c: Fix common/ includes.
12345         * amd64-obsd-tdep.c: Fix common/ includes.
12346         * amd64-nbsd-tdep.c: Fix common/ includes.
12347         * amd64-linux-tdep.c: Fix common/ includes.
12348         * amd64-linux-nat.c: Fix common/ includes.
12349         * amd64-fbsd-tdep.c: Fix common/ includes.
12350         * amd64-fbsd-nat.c: Fix common/ includes.
12351         * amd64-dicos-tdep.c: Fix common/ includes.
12352         * amd64-darwin-tdep.c: Fix common/ includes.
12353         * agent.c: Fix common/ includes.
12354         * ada-lang.h: Fix common/ includes.
12355         * ada-lang.c: Fix common/ includes.
12356         * aarch64-tdep.c: Fix common/ includes.
12357
12358 2019-01-25  Tom Tromey  <tom@tromey.com>
12359
12360         * common/create-version.sh: Use common/version.h.
12361
12362 2019-01-24  Pedro Alves  <palves@redhat.com>
12363
12364         * infrun.c (signal_stop, signal_print, signal_program)
12365         (signal_catch, signal_pass): Now arrays instead of pointers.
12366         (update_signals_program_target, do_target_resume)
12367         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12368         * linux-nat.c (linux_nat_target::pass_signals)
12369         (linux_nat_target::create_inferior, linux_nat_target::attach):
12370         Adjust.
12371         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12372         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12373         * procfs.c (procfs_target::pass_signals): Adjust.
12374         * record-full.c (record_full_target::resume): Adjust.
12375         * remote.c (remote_target::pass_signals)
12376         (remote_target::program_signals): Adjust.
12377         * target-debug.h (target_debug_print_signals): Now takes a
12378         gdb::array_view as parameter.  Adjust.
12379         * target.h (target_ops) <pass_signals, program_signals>: Replace
12380         pointer and length parameters with gdb::array_view.
12381         (target_pass_signals, target_program_signals): Likewise.
12382         * target-delegates.c: Regenerate.
12383
12384 2019-01-24  Pedro Alves  <palves@redhat.com>
12385
12386         * common/forward-scope-exit.h
12387         (forward_scope_exit::forward_scope_exit): Pass arguments to
12388         m_bind_function directly, instead of creating a std::bind and
12389         copying that.
12390
12391 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12392
12393         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12394         for static members.
12395         (pass_in_v_vfp_candidate): Likewise.
12396
12397 2019-01-23  Tom Tromey  <tom@tromey.com>
12398             Pedro Alves  <palves@redhat.com>
12399
12400         * regcache.c (class regcache_invalidator): Remove.
12401         (regcache::raw_write): Use make_scope_exit.
12402
12403 2019-01-23  Tom Tromey  <tom@tromey.com>
12404
12405         * ui-out.h (class ui_out_emit_type): Update comment.
12406
12407 2019-01-23  Tom Tromey  <tom@tromey.com>
12408
12409         * infrun.c (fetch_inferior_event): Update comment.
12410
12411 2019-01-23  Tom Tromey  <tom@tromey.com>
12412             Pedro Alves  <palves@redhat.com>
12413
12414         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12415         parameter.
12416         (fetch_inferior_event): Use SCOPE_EXIT.
12417
12418
12419 2019-01-23  Tom Tromey  <tom@tromey.com>
12420             Pedro Alves  <palves@redhat.com>
12421
12422         * infrun.c (disable_thread_events): Delete.
12423         (stop_all_threads): Use SCOPE_EXIT.
12424
12425 2019-01-23  Tom Tromey  <tom@tromey.com>
12426             Pedro Alves  <palves@redhat.com>
12427
12428         * symfile.c: Include forward-scope-exit.h.
12429         (clear_symtab_users_cleanup): Replace forward declaration with
12430         a FORWARD_SCOPE_EXIT.
12431         (syms_from_objfile_1): Use the forward_scope_exit and
12432         gdb::optional instead of cleanup_function.
12433         (reread_symbols): Use the forward_scope_exit instead of
12434         cleanup_function.
12435         (clear_symtab_users_cleanup): Remove function.
12436
12437 2019-01-23  Tom Tromey  <tom@tromey.com>
12438             Pedro Alves  <palves@redhat.com>
12439
12440         * linux-nat.c: Include scope-exit.h.
12441         (cleanup_target_stop): Remove.
12442         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12443         SCOPE_EXIT.
12444
12445 2019-01-23  Tom Tromey  <tom@tromey.com>
12446             Pedro Alves  <palves@redhat.com>
12447
12448         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12449         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12450
12451 2019-01-23  Tom Tromey  <tom@tromey.com>
12452             Andrew Burgess  <andrew.burgess@embecosm.com>
12453             Pedro Alves  <palves@redhat.com>
12454
12455         * infrun.c (fetch_inferior_event): Use scope_exit.
12456         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12457         * top.c (execute_command): Use scope_exit.
12458         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12459         * utils.c (do_bpstat_clear_actions_cleanup)
12460         (make_bpstat_clear_actions_cleanup): Remove.
12461
12462 2019-01-23  Tom Tromey  <tom@tromey.com>
12463             Pedro Alves  <palves@redhat.com>
12464
12465         * infrun.c: Include "common/scope-exit.h"
12466         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12467         (wait_for_inferior): Use SCOPE_EXIT.
12468         (fetch_inferior_event): Use scope_exit.
12469
12470 2019-01-23  Tom Tromey  <tom@tromey.com>
12471             Pedro Alves  <palves@redhat.com>
12472
12473         * breakpoint.c (create_breakpoint): Remove cleanup.
12474
12475 2019-01-23  Tom Tromey  <tom@tromey.com>
12476             Andrew Burgess  <andrew.burgess@embecosm.com>
12477             Pedro Alves  <palves@redhat.com>
12478
12479 2019-01-23  Pedro Alves  <palves@redhat.com>
12480
12481         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12482
12483 2019-01-23  Pedro Alves  <palves@redhat.com>
12484             Andrew Burgess  <andrew.burgess@embecosm.com>
12485
12486         * gdbthread.h: Include "common/forward-scope-exit.h".
12487         (scoped_finish_thread_state): Redefine custom class in terms of
12488         forward_scope_exit.
12489
12490 2019-01-23  Pedro Alves  <palves@redhat.com>
12491             Andrew Burgess  <andrew.burgess@embecosm.com>
12492
12493         * common/forward-scope-exit.h: New file.
12494
12495 2019-01-23  Pedro Alves  <palves@redhat.com>
12496             Andrew Burgess  <andrew.burgess@embecosm.com>
12497             Tom Tromey  <tom@tromey.com>
12498
12499         * common/scope-exit.h: New file.
12500
12501 2019-01-23  Pedro Alves  <palves@redhat.com>
12502
12503         * common/preprocessor.h (ESC): Rename to ...
12504         (ESC_PARENS): ... this.
12505         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12506         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12507
12508 2019-01-23  Tom Tromey  <tom@tromey.com>
12509
12510         * language.h (class scoped_switch_to_sym_language_if_auto):
12511         Initialize m_lang in both cases.
12512
12513 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12514
12515         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12516         with XCNEW.
12517
12518 2019-01-22  Tom Tromey  <tom@tromey.com>
12519
12520         * corelow.c: Do not include sys/file.h.
12521
12522 2019-01-22  Tom Tromey  <tom@tromey.com>
12523
12524         * tui/tui-wingeneral.h: Include gdb_curses.h.
12525
12526 2019-01-22  Tom Tromey  <tom@tromey.com>
12527
12528         * source-cache.h (class source_cache) <get_source_lines,
12529         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12530
12531 2019-01-22  Tom Tromey  <tom@tromey.com>
12532
12533         * remote-fileio.h (struct remote_target): Declare.
12534
12535 2019-01-22  Tom Tromey  <tom@tromey.com>
12536
12537         * python/py-arch.c: Do not include py-ref.h.
12538         * python/py-bpevent.c: Do not include py-ref.h.
12539         * python/py-cmd.c: Do not include py-ref.h.
12540         * python/py-continueevent.c: Do not include py-ref.h.
12541         * python/py-event.h: Do not include py-ref.h.
12542         * python/py-evtregistry.c: Do not include py-ref.h.
12543         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12544         * python/py-frame.c: Do not include py-ref.h.
12545         * python/py-framefilter.c: Do not include py-ref.h.
12546         * python/py-function.c: Do not include py-ref.h.
12547         * python/py-infevents.c: Do not include py-ref.h.
12548         * python/py-linetable.c: Do not include py-ref.h.
12549         * python/py-objfile.c: Do not include py-ref.h.
12550         * python/py-param.c: Do not include py-ref.h.
12551         * python/py-prettyprint.c: Do not include py-ref.h.
12552         * python/py-progspace.c: Do not include py-ref.h.
12553         * python/py-symbol.c: Do not include py-ref.h.
12554         * python/py-symtab.c: Do not include py-ref.h.
12555         * python/py-type.c: Do not include py-ref.h.
12556         * python/py-unwind.c: Do not include py-ref.h.
12557         * python/py-utils.c: Do not include py-ref.h.
12558         * python/py-value.c: Do not include py-ref.h.
12559         * python/py-varobj.c: Do not include py-ref.h.
12560         * python/py-xmethods.c: Do not include py-ref.h.
12561         * python/python.c: Do not include py-ref.h.
12562         * varobj.c: Do not include py-ref.h.
12563
12564 2019-01-22  Tom Tromey  <tom@tromey.com>
12565
12566         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12567         keyword for bcache.
12568
12569 2019-01-22  Tom Tromey  <tom@tromey.com>
12570
12571         * compile/compile-cplus-types.c: Remove a comment by #include.
12572
12573 2019-01-22  Tom Tromey  <tom@tromey.com>
12574
12575         * compile/gcc-c-plugin.h: Include compile-internal.h.
12576
12577 2019-01-22  Tom Tromey  <tom@tromey.com>
12578
12579         * stabsread.c (EXTERN): Do not define.
12580         (symnum, next_symbol_text_func, processing_gcc_compilation)
12581         (within_function, global_sym_chain, global_stabs)
12582         (previous_stab_code, this_object_header_files)
12583         (n_this_object_header_files)
12584         (n_allocated_this_object_header_files): Define.
12585         * stabsread.h (EXTERN): Never define.  Use "extern".
12586
12587 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12588
12589         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12590         history_value.
12591
12592 2019-01-21  Tom Tromey  <tom@tromey.com>
12593
12594         * ui-out.c: Fix includes.
12595         * tui/tui-source.c: Fix includes.
12596         * target.c: Fix includes.
12597         * remote.c: Fix includes.
12598         * regcache.c: Fix includes.
12599         * python/py-block.c: Fix includes.
12600         * printcmd.c: Fix includes.
12601         * or1k-tdep.c: Fix includes.
12602         * mi/mi-main.c: Fix includes.
12603         * m32r-tdep.c: Fix includes.
12604         * csky-tdep.c: Fix includes.
12605         * compile/compile-cplus-types.c: Fix includes.
12606         * cli/cli-interp.c: Fix includes.
12607
12608 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12609
12610         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12611         for padding.
12612
12613 2019-01-16  Tom Tromey  <tom@tromey.com>
12614
12615         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12616         earlier.
12617         (struct objfile) <msymbols_range>: Move from top level.
12618         <msymbols>: New method.
12619         (class objfile_msymbols): Remove.
12620         * symtab.c (default_collect_symbol_completion_matches_break_on):
12621         Update.
12622         * symmisc.c (dump_msymbols): Update.
12623         * stabsread.c (scan_file_globals): Update.
12624         * objc-lang.c (info_selectors_command, info_classes_command)
12625         (find_methods): Update.
12626         * minsyms.c (find_solib_trampoline_target): Update.
12627         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12628         * coffread.c (coff_symfile_read): Update.
12629         * ada-lang.c (ada_lookup_simple_minsym)
12630         (ada_collect_symbol_completion_matches): Update.
12631
12632 2019-01-16  Tom Tromey  <tom@tromey.com>
12633
12634         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12635         type.  Remove no-argument constructor.
12636         <iterator::operator++>: Simplify.
12637         <begin>: Update.
12638         <end>: Use minimal_symbol_count.
12639
12640 2019-01-16  Tom Tromey  <tom@tromey.com>
12641
12642         * objfiles.h (struct objfile) <psymtabs>: New method.
12643         (class objfile_psymtabs): Remove.
12644         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12645         typedef.
12646         <range>: New method.
12647         (require_partial_symbols): Change return type.
12648         * psymtab.c (require_partial_symbols)
12649         (psym_expand_symtabs_matching): Update.
12650         * mdebugread.c (parse_partial_symbols): Update.
12651         * dbxread.c (dbx_end_psymtab): Update.
12652
12653 2019-01-15  Tom Tromey  <tom@tromey.com>
12654
12655         * symtab.c (lookup_objfile_from_block)
12656         (lookup_symbol_in_objfile_symtabs)
12657         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12658         (find_line_symtab, info_sources_command)
12659         (default_collect_symbol_completion_matches_break_on)
12660         (make_source_files_completion_list): Update.
12661         * symmisc.c (print_objfile_statistics, dump_objfile)
12662         (maintenance_print_symbols, maintenance_info_symtabs)
12663         (maintenance_check_symtabs, maintenance_info_line_tables):
12664         Update.
12665         * source.c (select_source_symtab)
12666         (forget_cached_source_info_for_objfile): Update.
12667         * objfiles.h (class objfile_compunits): Remove.
12668         (struct objfile) <compunits_range>: New typedef.
12669         (compunits): New method.
12670         * objfiles.c (objfile_relocate1): Update.
12671         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12672         * maint.c (count_symtabs_and_blocks): Update.
12673         * linespec.c (iterate_over_all_matching_symtabs): Update.
12674         * cp-support.c (add_symbol_overload_list_qualified): Update.
12675         * coffread.c (coff_symtab_read): Update.
12676         * ada-lang.c (add_nonlocal_symbols)
12677         (ada_collect_symbol_completion_matches)
12678         (ada_add_global_exceptions): Update.
12679
12680 2019-01-15  Tom Tromey  <tom@tromey.com>
12681
12682         * progspace.h (program_space) <objfiles_safe_range>: New
12683         typedef.
12684         <objfiles_safe>: New method.
12685         * objfiles.h (class all_objfiles_safe): Remove.
12686         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12687         * jit.c (jit_inferior_exit_hook): Update.
12688
12689 2019-01-17  Tom Tromey  <tom@tromey.com>
12690
12691         * progspace.h (program_space) <objfiles_range>: New typedef.
12692         <objfiles>: New method.
12693         <objfiles_head>: Rename from objfiles.
12694         (object_files): Update.
12695         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12696         * guile/scm-pretty-print.c
12697         (ppscm_find_pretty_printer_from_objfiles): Update.
12698         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12699         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12700         Update.
12701         * python/py-progspace.c (pspy_get_objfiles): Update.
12702         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12703         Update.
12704         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12705         (objfpy_lookup_objfile_by_build_id): Update.
12706         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12707         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12708         Update.
12709         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12710         (expand_symtab_containing_pc, lookup_objfile_from_block)
12711         (lookup_static_symbol, basic_lookup_transparent_type)
12712         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12713         (find_line_symtab, info_sources_command)
12714         (default_collect_symbol_completion_matches_break_on)
12715         (make_source_files_completion_list, find_main_name): Update.
12716         * symmisc.c (print_symbol_bcache_statistics)
12717         (print_objfile_statistics, maintenance_print_symbols)
12718         (maintenance_print_msymbols, maintenance_print_objfiles)
12719         (maintenance_info_symtabs, maintenance_check_symtabs)
12720         (maintenance_expand_symtabs, maintenance_info_line_tables):
12721         Update.
12722         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12723         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12724         (map_overlay_command, unmap_overlay_command)
12725         (simple_overlay_update, expand_symtabs_matching)
12726         (map_symbol_filenames): Update.
12727         * symfile-debug.c (set_debug_symfile): Update.
12728         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12729         Update.
12730         * source.c (select_source_symtab, forget_cached_source_info):
12731         Update.
12732         * solib.c (solib_read_symbols): Update.
12733         * solib-spu.c (append_ocl_sos): Update.
12734         * psymtab.c (maintenance_print_psymbols)
12735         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12736         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12737         * printcmd.c (info_symbol_command): Update.
12738         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12739         Update.
12740         * objfiles.h (class all_objfiles): Remove.
12741         * objfiles.c (have_partial_symbols, have_full_symbols)
12742         (have_minimal_symbols, qsort_cmp, update_section_map)
12743         (shared_objfile_contains_address_p)
12744         (default_iterate_over_objfiles_in_search_order): Update.
12745         * objc-lang.c (info_selectors_command, info_classes_command)
12746         (find_methods): Update.
12747         * minsyms.c (find_solib_trampoline_target): Update.
12748         * maint.c (maintenance_info_sections)
12749         (maintenance_translate_address, count_symtabs_and_blocks):
12750         Update.
12751         * main.c (captured_main_1): Update.
12752         * linux-thread-db.c (try_thread_db_load_from_pdir)
12753         (has_libpthread): Update.
12754         * linespec.c (iterate_over_all_matching_symtabs)
12755         (search_minsyms_for_name): Update.
12756         * jit.c (jit_find_objf_with_entry_addr): Update.
12757         * hppa-tdep.c (find_unwind_entry)
12758         (hppa_lookup_stub_minimal_symbol): Update.
12759         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12760         Update.
12761         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12762         (elf_gnu_ifunc_resolve_by_got): Update.
12763         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12764         * dwarf-index-write.c (save_gdb_index_command): Update.
12765         * cp-support.c (add_symbol_overload_list_qualified): Update.
12766         * breakpoint.c (create_overlay_event_breakpoint)
12767         (create_longjmp_master_breakpoint)
12768         (create_std_terminate_master_breakpoint)
12769         (create_exception_master_breakpoint): Update.
12770         * blockframe.c (find_pc_partial_function): Update.
12771         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12772         (ada_collect_symbol_completion_matches)
12773         (ada_add_global_exceptions): Update.
12774
12775 2019-01-17  Tom Tromey  <tom@tromey.com>
12776
12777         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12778         declare VEC.
12779         (solib_target_parse_libraries): Change return type.
12780         (library_list_start_segment, library_list_start_section)
12781         (library_list_end_library, library_list_start_library); Update.
12782         (solib_target_free_library_list): Remove.
12783         (solib_target_parse_libraries): Remove cleanup.  Change return
12784         type.
12785         (solib_target_current_sos): Update.
12786
12787 2019-01-17  Tom Tromey  <tromey@bapiya>
12788
12789         * valprint.c: Replace "the the" with "the".
12790         * symtab.c: Replace "the the" with "the".
12791         * solib.c: Replace "the the" with "the".
12792         * solib-dsbt.c: Replace "the the" with "the".
12793         * linespec.c: Replace "the the" with "the".
12794         * dwarf2loc.h: Replace "the the" with "the".
12795         * amd64-windows-tdep.c: Replace "the the" with "the".
12796         * aarch64-tdep.c: Replace "the the" with "the".
12797
12798 2019-01-16  Keith Seitz  <keiths@redhat.com>
12799
12800         PR gdb/23773
12801         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12802         <builder>: Rename to ..
12803         <m_builder>: ... this and make private.
12804         (dwarf2_cu::get_builder): New method.  Change all users of
12805         `builder' to use this method.
12806         (dwarf2_start_symtab): Move to ...
12807         (dwarf2_cu::start_symtab): ... here.  Update all callers
12808         (setup_type_unit_groups): Move to ...
12809         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12810         callers.
12811         (dwarf2_cu::reset_builder): New method.
12812         (process_full_compunit, process_full_type_unit): Use
12813         dwarf2_cu::reset_builder.
12814         (follow_die_offset): Record the ancestor CU if it is different
12815         from the followed DIE's CU.
12816         (follow_die_sig_1): Likewise.
12817
12818 2019-01-15  Tom Tromey  <tom@tromey.com>
12819
12820         * remote.c (class remote_state) <buf>: Now a char_vector.
12821         <buf_size>: Remove.
12822         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12823         parameter.
12824         (remote_target::getpkt_or_notif_sane_1)
12825         (remote_target::getpkt_sane)
12826         (remote_target::getpkt_or_notif_sane): Likewise.
12827         (class remote_target) <putpkt>: New overload.
12828         (remote_target::read_frame): Change type of "buf_p".  Remove
12829         sizeof_p parameter.
12830         (packet_ok): New overload.
12831         (packet_check_result): New overload.
12832         Update all uses.
12833
12834 2019-01-14  Tom Tromey  <tom@tromey.com>
12835
12836         * remote-notif.c (handle_notification, remote_notif_ack)
12837         (remote_notif_parse): Make "buf" const.
12838         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12839         const.
12840         (remote_notif_parse, remote_notif_ack, handle_notification):
12841         Likewise.
12842         * remote.c (remote_notif_stop_parse): Make "buf" const.
12843         (remote_target::remote_parse_stop_reply): Make "buf" const.
12844         (remote_notif_stop_ack): Make "buf" const.
12845
12846 2019-01-14  Tom Tromey  <tom@tromey.com>
12847
12848         * remote.c (remote_console_output): Make parameter const.
12849
12850 2019-01-14  Tom Tromey  <tom@tromey.com>
12851
12852         * target-debug.h (target_debug_print_signals): Constify.
12853         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12854         * procfs.c (procfs_target::pass_signals): Update.
12855         * linux-nat.c (linux_nat_target::pass_signals): Update.
12856         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12857         * target-delegates.c: Rebuild.
12858         * remote.c (remote_target::program_signals): Update.
12859         (remote_target::pass_signals): Update.
12860         * target.c (target_pass_signals): Constify argument.
12861         (target_program_signals): Likewise.
12862         * target.h (struct target_ops) <pass_signals, program_signals>:
12863         Constify argument.
12864         (target_pass_signals, target_program_signals): Constify argument.
12865
12866 2019-01-14  Tom Tromey  <tom@tromey.com>
12867
12868         PR tui/28819:
12869         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12870
12871 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12872
12873         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12874         field.
12875         * rs6000-tdep.c: Include reggroups.h.
12876         (IS_V_ALIAS_PSEUDOREG): Define.
12877         (rs6000_register_name): Return names for the "vX" aliases.
12878         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12879         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12880         aliases.  Call default_register_reggroup_p for all other
12881         pseudo-registers.
12882         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12883         New functions.
12884         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12885         Handle "vX" aliases.
12886         (v_alias_pseudo_register_collect): New function.
12887         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12888         (rs6000_gdbarch_init): Initialize "vX" aliases as
12889         pseudo-registers.  Restore registration of
12890         rs6000_pseudo_register_reggroup_p with
12891         set_tdesc_pseudo_register_reggroup_p.
12892
12893 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12894
12895         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12896         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12897         set_gdbarch_num_pseudo_regs.
12898
12899 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12900
12901         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12902         Remove arg prefixname, add do_set and do_show.
12903         Add member functions set_list and show_list.
12904         * cli/cli-style.c (class cli_style_option): Update accordingly.
12905         (style_set_list): Move to file scope.
12906         (style_show_list): Likewise.
12907         (set_style): Call help_list.
12908         (show_style): Call cmd_show_list.
12909         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12910         Update to use the new macro.
12911
12912 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12913
12914         * ada-lang.c (_initialize_ada_language): Expand the help text
12915         for the "catch exception" command.
12916
12917 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12918
12919         * symtab.c (matching_obj_sections): Initialize obj,
12920         declare it closer to its usage.
12921
12922 2019-01-10  Tom Tromey  <tom@tromey.com>
12923
12924         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12925         (basic_inf_threads_range): Remove.
12926         (inf_threads_range, inf_non_exited_threads_range)
12927         (safe_inf_threads_range): Use next_adapter.
12928
12929 2019-01-10  Keith Seitz  <keiths@redhat.com>
12930
12931         PR gdb/23712
12932         PR symtab/23010
12933         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12934         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12935
12936 2019-01-10  Keith Seitz  <keiths@redhat.com>
12937
12938         PR gdb/23712
12939         PR symtab/23010
12940         * dictionary.c (pending_to_vector): Remove.
12941         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12942         Remove _1 suffix, replacing functions of the same name.  Update
12943         all callers.
12944         (dict_create_hashed, dict_create_hashed_expandable)
12945         (dict_create_linear, dict_create_linear_expandable, dict_free)
12946         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12947         Make functions static.
12948
12949 2019-01-10  Keith Seitz  <keiths@redhat.com>
12950
12951         PR gdb/23712
12952         PR symtab/23010
12953         * dictionary.h (struct dictionary): Replace declaration with
12954         multidictionary.
12955         (dict_create_hashed, dict_create_hashed_expandable)
12956         (dict_create_linear, dict_create_linear_expandable)
12957         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12958         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12959         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12960         taking multidictionary argument.
12961         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12962         * block.h (struct block) <dict>: Change to multidictionary
12963         and rename `multidict'.
12964         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12965         symmisc.c: Update all dictionary references to multidictionary.
12966
12967 2019-01-10  Keith Seitz  <keiths@redhat.com>
12968
12969         PR gdb/23712
12970         PR symtab/23010
12971         * dictionary.c: Include unordered_map.
12972         (pending_to_vector): New function.
12973         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12974         Rewrite the non-"_1" functions to take vector instead
12975         of linked list.
12976         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12977         "new" _1 versions of the same name.
12978         (multidictionary): Define.
12979         (std::hash<enum language): New definition.
12980         (collate_pending_symbols_by_language, mdict_create_hashed)
12981         (mdict_create_hashed_expandable, mdict_create_linear)
12982         (mdict_create_linear_expandable, mdict_free)
12983         (find_language_dictionary, create_new_language_dictionary)
12984         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12985         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12986         (mdict_size, mdict_empty): New functions.
12987         * dictionary.h (mdict_iterator): Define.
12988
12989 2019-01-10  Pedro Alves  <palves@redhat.com>
12990
12991         * breakpoint.c (read_uploaded_action)
12992         (create_tracepoint_from_upload): Adjust to use
12993         gdb::unique_xmalloc_ptr.
12994         * ctf.c (ctf_write_uploaded_tp):
12995         (SET_ARRAY_FIELD): Use emplace_back.
12996         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12997         * tracefile-tfile.c (tfile_write_uploaded_tp):
12998         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12999         gdb::unique_xmalloc_ptr.
13000         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13001         at_string, cond_string, cmd_strings>: Replace char pointers
13002         with gdb::unique_xmalloc_ptr.
13003
13004 2019-01-10  Pedro Alves  <palves@redhat.com>
13005
13006         * solib-target.c (library_list_start_library): Don't xstrdup name.
13007
13008 2019-01-10  Pedro Alves  <palves@redhat.com>
13009
13010         * mdebugread.c (parse_partial_symbols): Use
13011         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13012
13013 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13014
13015         * linux-fork.c (scoped_switch_fork_info)
13016         <~scoped_switch_fork_info>: Fix incorrect variable name.
13017
13018 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13019
13020         * linux-fork.c (scoped_switch_fork_info)
13021         <scoped_switch_fork_info>: Make explicit.
13022         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13023
13024 2019-01-10  Tom Tromey  <tom@tromey.com>
13025
13026         * objfiles.h (objfile::reset_psymtabs): Update.
13027         * objfiles.c (objfile::objfile): Update.
13028         * psymtab.h (psymtab_storage::obstack): Update.
13029         (psymtab_storage::m_obstack): Use gdb::optional.
13030         (class psymtab_storage): Update comment.  Remove objfile
13031         parameter.
13032         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13033
13034 2019-01-10  Tom Tromey  <tom@tromey.com>
13035
13036         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13037         <free_psymtabs>: Now private.
13038         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13039         (allocate_psymtab): Use new method.
13040
13041 2019-01-10  Tom Tromey  <tom@tromey.com>
13042
13043         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13044         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13045         * mdebugread.c (parse_partial_symbols): Use
13046         allocate_dependencies.
13047         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13048         allocate_dependencies.
13049         (process_psymtab_comp_unit_reader)
13050         (build_type_psymtab_dependencies): Likewise.
13051         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13052
13053 2019-01-10  Tom Tromey  <tom@tromey.com>
13054
13055         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13056         PSYMBOL_SET_LANGUAGE.
13057         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13058
13059 2019-01-10  Tom Tromey  <tom@tromey.com>
13060
13061         * psymtab.h (psymtab_storage::obstack): New method.
13062         <m_obstack>: Rename from obstack; now private.
13063         * psymtab.c (psymtab_storage): Update.
13064         * dwarf2read.c (create_addrmap_from_index)
13065         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13066         Update.
13067
13068 2019-01-10  Tom Tromey  <tom@tromey.com>
13069
13070         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13071         * objfiles.h (objfile::reset_psymtabs): New method.
13072
13073 2019-01-10  Tom Tromey  <tom@tromey.com>
13074
13075         * symmisc.c (print_symbol_bcache_statistics): Update.
13076         (print_objfile_statistics): Update.
13077         * symfile.c (reread_symbols): Update.
13078         * psymtab.h (class psymtab_storage): New.
13079         * psymtab.c (psymtab_storage): New constructor.
13080         (~psymtab_storage): New destructor.
13081         (require_partial_symbols): Update.
13082         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13083         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13084         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13085         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13086         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13087         (start_psymtab_common, end_psymtab_common)
13088         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13089         (allocate_psymtab): Update.
13090         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13091         Update.
13092         (dump_psymtab_addrmap, maintenance_print_psymbols)
13093         (maintenance_check_psymtabs): Update.
13094         (class objfile_psymtabs): Move to objfiles.h.
13095         * psympriv.h (discard_psymtab): Now inline.
13096         (psymtab_discarder::psymtab_discarder): Update.
13097         (psymtab_discarder::~psymtab_discarder): Update.
13098         (ALL_OBJFILE_PSYMTABS): Rewrite.
13099         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13100         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13101         Remove fields.
13102         <partial_symtabs>: New field.
13103         (class objfile_psymtabs): Move from psymtab.h.  Update.
13104         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13105         psymbol_cache.
13106         (objfile::~objfile): Don't destroy psymbol_cache.
13107         * mdebugread.c (parse_partial_symbols): Update.
13108         * dwarf2read.c (create_addrmap_from_index)
13109         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13110         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13111         (add_partial_subprogram, dwarf2_ranges_read): Update.
13112         * dwarf-index-write.c (write_address_map)
13113         (write_one_signatured_type, recursively_write_psymbols)
13114         (class debug_names, class debug_names, write_psymtabs_to_index):
13115         Update.
13116
13117 2019-01-10  Tom Tromey  <tom@tromey.com>
13118
13119         * symtab.h (SYMBOL_SET_NAMES): Update.
13120         (symbol_set_names): Update.
13121         (MSYMBOL_SET_NAMES): Update.
13122         * symtab.c (symbol_set_names): Change argument to be an
13123         objfile_per_bfd_storage.
13124         * psymtab.c (add_psymbol_to_bcache): Update.
13125         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13126
13127 2019-01-10  Tom Tromey  <tom@tromey.com>
13128
13129         * symtab.c (create_demangled_names_hash): Change argument to be an
13130         objfile_per_bfd_storage.
13131         (symbol_set_names): Update.
13132
13133 2019-01-10  Tom Tromey  <tom@tromey.com>
13134
13135         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13136         init_psymbol_list.
13137         * psymtab.c (init_psymbol_list): Do nothing if already called.
13138         * psympriv.h (init_psymbol_list): Add comment.
13139         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13140         init_psymbol_list.
13141         * dbxread.c (dbx_symfile_read): Unconditionally call
13142         init_psymbol_list.
13143
13144 2019-01-10  Tom Tromey  <tom@tromey.com>
13145
13146         * xcoffread.c (scan_xcoff_symtab): Update.
13147         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13148         "where".
13149         * mdebugread.c (parse_partial_symbols)
13150         (handle_psymbol_enumerators): Update.
13151         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13152         * dbxread.c (read_dbx_symtab): Update.
13153         * psympriv.h (psymbol_placement): New enum.
13154         (add_psymbol_to_list): Update.
13155
13156 2019-01-10  Tom Tromey  <tom@tromey.com>
13157
13158         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13159         static_psymbols parameters.
13160         (scan_xcoff_symtab): Update.
13161         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13162         static_psymbols parameters.
13163         * psympriv.h (start_psymtab_common): Update.
13164         * mdebugread.c (parse_partial_symbols): Update.
13165         * dwarf2read.c (create_partial_symtab): Update.
13166         * dbxread.c (read_dbx_symtab): Update.
13167         (start_psymtab): Remove global_psymbols and static_psymbols
13168         parameters.
13169
13170 2019-01-10  Tom Tromey  <tom@tromey.com>
13171
13172         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13173         * psymtab.c (allocate_psymtab): Add comment.
13174         * psympriv.h (allocate_psymtab): Add comment.
13175         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13176         initializations.
13177         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13178
13179 2019-01-10  Tom Tromey  <tom@tromey.com>
13180
13181         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13182         Don't declare.
13183         * mipsread.c: Include mdebugread.h.
13184         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13185         Declare.
13186         * elfread.c: Include mdebugread.h.
13187
13188 2019-01-09  Tom Tromey  <tom@tromey.com>
13189
13190         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13191         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13192         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13193         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13194         (psym_lookup_symbol, psym_find_last_source_symtab)
13195         (psym_forget_cached_source_info, psym_print_stats)
13196         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13197         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13198         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13199         (psym_find_compunit_symtab_by_address)
13200         (maintenance_print_psymbols, maintenance_info_psymtabs)
13201         (maintenance_check_psymtabs): Use ranged for.
13202         * psymtab.h (class objfile_psymtabs): New.
13203         (require_partial_symbols): Return objfile_psymtabs.
13204         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13205
13206 2019-01-09  Tom Tromey  <tom@tromey.com>
13207
13208         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13209         (find_pc_mapped_section, list_overlays_command)
13210         (map_overlay_command, unmap_overlay_command)
13211         (simple_overlay_update): Use all_objfiles.
13212         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13213         * printcmd.c (info_symbol_command): Use all_objfiles.
13214         * objfiles.h (ALL_OBJSECTIONS): Remove.
13215         * maint.c (maintenance_translate_address): Use all_objfiles.
13216         * gcore.c (gcore_create_callback): Use all_objfiles.
13217         (objfile_find_memory_regions): Likewise.
13218
13219 2019-01-09  Tom Tromey  <tom@tromey.com>
13220
13221         * symtab.c (find_line_symtab, info_sources_command)
13222         (make_source_files_completion_list): Use objfile_compunits.
13223         * source.c (select_source_symtab): Use objfile_compunits.
13224         * objfiles.h (struct objfile): Update comment.
13225         (ALL_OBJFILES): Remove.
13226         (ALL_FILETABS): Remove.
13227         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13228         objfile_compunits.
13229
13230 2019-01-09  Tom Tromey  <tom@tromey.com>
13231
13232         * symmisc.c (print_objfile_statistics, dump_objfile)
13233         (maintenance_print_symbols): Use compunit_filetabs.
13234         * source.c (forget_cached_source_info_for_objfile): Use
13235         compunit_filetabs.
13236         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13237         (ALL_FILETABS): Use compunit_filetabs.
13238         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13239         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13240
13241 2019-01-09  Tom Tromey  <tom@tromey.com>
13242
13243         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13244         (compunit_filetabs): New.
13245         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13246         compunit_filetabs.
13247         (info_sources_command, make_source_files_completion_list): Remove
13248         declaration.
13249         * symmisc.c (print_objfile_statistics, dump_objfile)
13250         (maintenance_print_symbols): Remove declaration.
13251         (maintenance_info_symtabs): Use compunit_filetabs.
13252         (maintenance_info_line_tables): Likewise.
13253         * source.c (select_source_symtab): Change local variable name.
13254         (forget_cached_source_info_for_objfile): Remove declaration.
13255         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13256         * objfiles.c (objfile_relocate1): Remove declaration.
13257         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13258         declaration.
13259         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13260         * coffread.c (coff_symtab_read): Remove declaration.
13261         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13262         compunit_filetabs.
13263
13264 2019-01-09  Tom Tromey  <tom@tromey.com>
13265
13266         * symtab.c (lookup_objfile_from_block)
13267         (find_pc_sect_compunit_symtab, search_symbols)
13268         (default_collect_symbol_completion_matches_break_on): Use
13269         objfile_compunits.
13270         * objfiles.h (ALL_COMPUNITS): Remove.
13271         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13272         * cp-support.c (add_symbol_overload_list_qualified): Use
13273         objfile_compunits.
13274         * ada-lang.c (ada_collect_symbol_completion_matches)
13275         (ada_add_global_exceptions): Use objfile_compunits.
13276
13277 2019-01-09  Tom Tromey  <tom@tromey.com>
13278
13279         * source.c (select_source_symtab)
13280         (forget_cached_source_info_for_objfile): Remove declaration.
13281         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13282         declaration.
13283         * maint.c (count_symtabs_and_blocks): Remove declaration.
13284         * cp-support.c (add_symbol_overload_list_qualified): Remove
13285         declaration.
13286         * coffread.c (coff_symtab_read): Remove declaration.
13287         * symtab.c (lookup_symbol_in_objfile_symtabs)
13288         (basic_lookup_transparent_type_1): Use objfile_compunits.
13289         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13290         (info_sources_command, search_symbols)
13291         (default_collect_symbol_completion_matches_break_on)
13292         (make_source_files_completion_list): Remove declaration.
13293         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13294         (ada_collect_symbol_completion_matches)
13295         (ada_add_global_exceptions): Remove declaration.
13296         * linespec.c (iterate_over_all_matching_symtabs): Use
13297         objfile_compunits.
13298         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13299         (class objfile_compunits): New.
13300         (ALL_COMPUNITS): Use objfile_compunits.
13301         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13302         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13303         objfile_compunits.
13304         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13305
13306 2019-01-09  Tom Tromey  <tom@tromey.com>
13307
13308         * symtab.c (search_symbols)
13309         (default_collect_symbol_completion_matches_break_on): Use
13310         objfile_msymbols.
13311         * ada-lang.c (ada_lookup_simple_minsym)
13312         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13313         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13314         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13315         objfile_msymbols.
13316         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13317         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13318         * objc-lang.c (find_methods): Use objfile_msymbols.
13319         (info_selectors_command, info_classes_command): Likewise.
13320         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13321         * objfiles.h (class objfile_msymbols): New.
13322         (ALL_OBJFILE_MSYMBOLS): Remove.
13323         (ALL_MSYMBOLS): Remove.
13324
13325 2019-01-09  Tom Tromey  <tom@tromey.com>
13326
13327         * common/next-iterator.h (next_adapter): Add Iterator template
13328         parameter.
13329         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13330         (class all_objfiles_safe): New.
13331         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13332         * objfiles.c (put_objfile_before): Update comment.
13333         (add_separate_debug_objfile): Likewise.
13334         (free_all_objfiles): Use all_objfiles_safe.
13335         (objfile_purge_solibs): Likewise.
13336
13337 2019-01-09  Tom Tromey  <tom@tromey.com>
13338
13339         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13340         (expand_symtab_containing_pc, lookup_static_symbol)
13341         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13342         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13343         all_objfiles.
13344         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13345         * breakpoint.c (create_overlay_event_breakpoint)
13346         (create_longjmp_master_breakpoint)
13347         (create_std_terminate_master_breakpoint)
13348         (create_exception_master_breakpoint): Use all_objfiles.
13349         * linux-thread-db.c (try_thread_db_load_from_pdir)
13350         (has_libpthread): Use all_objfiles.
13351         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13352         * linespec.c (iterate_over_all_matching_symtabs)
13353         (search_minsyms_for_name): Use all_objfiles.
13354         * maint.c (maintenance_info_sections): Use all_objfiles.
13355         * main.c (captured_main_1): Use all_objfiles.
13356         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13357         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13358         * guile/scm-pretty-print.c
13359         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13360         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13361         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13362         (maintenance_print_msymbols): Use all_objfiles.
13363         * source.c (select_source_symtab): Use all_objfiles.
13364         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13365         * symfile.c (remove_symbol_file_command)
13366         (expand_symtabs_matching, map_symbol_filenames): Use
13367         all_objfiles.
13368         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13369         all_objfiles.
13370         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13371         * objc-lang.c (find_methods): Use all_objfiles.
13372         * objfiles.c (have_partial_symbols, have_full_symbols)
13373         (have_minimal_symbols, qsort_cmp)
13374         (default_iterate_over_objfiles_in_search_order): Use
13375         all_objfiles.
13376         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13377         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13378         (maintenance_check_psymtabs): Use all_objfiles.
13379         (ALL_PSYMTABS): Remove.
13380         * compile/compile-object-run.c (do_module_cleanup): Use
13381         all_objfiles.
13382         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13383         * cp-support.c (add_symbol_overload_list_qualified): Use
13384         all_objfiles.
13385         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13386         Use all_objfiles.
13387         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13388         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13389         all_objfiles.
13390         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13391         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13392         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13393         Uses all_objfiles.
13394         * solib.c (solib_read_symbols): Use all_objfiles
13395
13396 2019-01-09  Tom Tromey  <tom@tromey.com>
13397
13398         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13399         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13400         all_objfiles.
13401         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13402         * symmisc.c (print_symbol_bcache_statistics)
13403         (print_objfile_statistics, maintenance_print_objfiles)
13404         (maintenance_info_symtabs, maintenance_check_symtabs)
13405         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13406         all_objfiles.
13407         * source.c (forget_cached_source_info): Use all_objfiles.
13408         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13409         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13410         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13411         * objfiles.c (update_section_map): Use all_objfiles.
13412         (shared_objfile_contains_address_p): Likewise.
13413         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13414         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13415
13416 2019-01-09  Tom Tromey  <tom@tromey.com>
13417
13418         * common/next-iterator.h: New file.
13419         * objfiles.h (class all_objfiles): New.
13420         (struct objfile_iterator): New.
13421
13422 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13423
13424         * NEWS: Move the description of the changed "frame", "select-frame",
13425          and "info frame" commands to the Changed commands section.
13426
13427 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13428
13429         * gdbtypes.c (check_stub_method_group): Remove handling of old
13430         mangling schemes.
13431         * linespec.c (find_methods): Likewise.
13432         * stabsread.c (read_member_functions): Likewise.
13433         * valops.c (search_struct_method): Likewise.
13434         (value_struct_elt_for_reference): Likewise.
13435         * NEWS: Mention this change.
13436
13437 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13438
13439         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13440         print_source_lines.
13441         * source.c (print_source_lines_base): Update line number check.
13442         (print_source_lines): New function.
13443         (source_lines_range::source_lines_range): New function.
13444         * source.h (class source_lines_range): New class.
13445         (print_source_lines): New declaration.
13446
13447 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13448
13449         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13450
13451 2019-01-08  Tom Tromey  <tom@tromey.com>
13452             Simon Marchi  <simon.marchi@ericsson.com>
13453
13454         PR gdb/24060
13455         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13456         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13457         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13458         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13459         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13460         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13461
13462 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13463
13464         * source.c (select_source_symtab): Move header comment to
13465         declaration in source.h.
13466         (forget_cached_source_info_for_objfile): Likewise.
13467         (forget_cached_source_info): Likewise.
13468         (identify_source_line): Likewise.
13469         * source.h (identify_source_line): Move declaration from symtab.h
13470         and add comment from source.c
13471         (print_source_lines): Likewise.
13472         (forget_cached_source_info_for_objfile): Likewise.
13473         (forget_cached_source_info): Likewise.
13474         (select_source_symtab): Likewise.
13475         (enum print_source_lines_flag): Move definition from symtab.h.
13476         * symtab.h (identify_source_line): Move declaration to source.h.
13477         (print_source_lines): Likewise.
13478         (forget_cached_source_info_for_objfile): Likewise.
13479         (forget_cached_source_info): Likewise.
13480         (select_source_symtab): Likewise.
13481         (enum print_source_lines_flag): Move definition to source.h.
13482         * tui/tui-hooks.c: Add 'source.h' include.
13483
13484 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13485
13486         * source.c (print_source_lines_base): Handle requests to print
13487         reverse line number sequences, and guard against empty lines
13488         string.
13489
13490 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13491
13492         * source.c (print_source_lines_base): Fix skip of '\r' if next
13493         character is '\n'.
13494
13495 2019-01-06  Tom Tromey  <tom@tromey.com>
13496
13497         * c-exp.y (struct c_parse_state) <macro_original_text,
13498         expansion_obstack>: New member.
13499         (macro_original_text, expansion_obstack): Remove globals.
13500         (scan_macro_expansion, scanning_macro_expansion)
13501         (finished_macro_expansion): Update.
13502         (scan_macro_cleanup): Remove.
13503         (yylex, c_parse): Update.
13504
13505 2019-01-06  Tom Tromey  <tom@tromey.com>
13506
13507         * c-exp.y (struct c_parse_state) <strings>: New member.
13508         (operator_stoken): Update.
13509
13510 2019-01-06  Tom Tromey  <tom@tromey.com>
13511
13512         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13513         (union type_stack_elt) <typelist_val>: Now a pointer to
13514         std::vector.
13515         (type_stack_cleanup): Don't declare.
13516         (push_typelist): Update.
13517         * parse.c (pop_typelist): Return a std::vector.
13518         (push_typelist): Take a std::vector.
13519         (follow_types): Update.  Do not free args.
13520         (type_stack_cleanup): Remove.
13521         * c-exp.y (struct c_parse_state): New.
13522         (cpstate): New global.
13523         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13524         (nonempty_typelist): Update.
13525         (func_mod): Create a new vector.
13526         (c_parse): Create a c_parse_state.
13527         (check_parameter_typelist): Do not delete params.
13528         (function_method): Update.  Do not delete type_list.
13529
13530 2019-01-06  Tom Tromey  <tom@tromey.com>
13531
13532         PR gdb/28155:
13533         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13534         check_typedef.
13535         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13536         (print_return_value): Likewise.
13537
13538 2019-01-05  Tom Tromey  <tom@tromey.com>
13539
13540         * contrib/cleanup_check.py: Remove.
13541         * contrib/gcc-with-excheck: Remove.
13542         * contrib/exsummary.py: Remove.
13543         * contrib/excheck.py: Remove.
13544
13545 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13546
13547         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13548         NULL. Initialize tpprev to NULL instead of assigning it
13549         to NULL on the next statement.
13550         * windows-nat.c (windows_delete_thread): Remove check for
13551         main_thread_id before printing thread exit notifications.
13552         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13553         Remove thread ID check against main_thread_id.
13554         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13555         windows_delete_thread.
13556         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13557
13558 2019-01-04  Tom Tromey  <tom@tromey.com>
13559
13560         * compile/compile.c (_initialize_compile): Use upper case for
13561         metasyntactic variables.
13562         * symmisc.c (_initialize_symmisc): Use upper case for
13563         metasyntactic variables.
13564         * psymtab.c (_initialize_psymtab): Use upper case for
13565         metasyntactic variables.
13566         * demangle.c (demangle_command): Use upper case for metasyntactic
13567         variables.
13568         (_initialize_demangler): Likewise.
13569         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13570         variables.
13571
13572 2019-01-03  Tom Tromey  <tom@tromey.com>
13573
13574         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13575
13576 2019-01-03  Tom Tromey  <tom@tromey.com>
13577
13578         * python/py-symtab.c (salpy_str): Update.
13579         (struct salpy_sal_object) <symtab>: Now a PyObject.
13580         (salpy_dealloc): Update.
13581         (del_objfile_sal): Use gdbpy_ref.
13582
13583 2019-01-03  Tom Tromey  <tom@tromey.com>
13584
13585         * python/py-type.c (convert_field): Use new_reference.  Return
13586         gdbpy_ref.
13587         (make_fielditem): Return gdbpy_ref.
13588         (typy_fields): Update.
13589         (typy_getitem): Update.
13590         (field_name): Return gdbpy_ref.  Use new_reference.
13591         (typy_iterator_iternext): Update.
13592
13593 2019-01-03  Tom Tromey  <tom@tromey.com>
13594
13595         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13596
13597 2019-01-03  Tom Tromey  <tom@tromey.com>
13598
13599         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13600         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13601         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13602         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13603         (pspy_set_type_printers): Likewise.
13604         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13605         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13606         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13607         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13608         (objfpy_set_type_printers): Likewise.
13609
13610 2019-01-03  Tom Tromey  <tom@tromey.com>
13611
13612         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13613         (gdbpy_print_stack): Use gdbpy_err_fetch.
13614         * python/python-internal.h (class gdbpy_err_fetch): New class.
13615         (class gdbpy_enter) <m_error_type, m_error_value,
13616         m_error_traceback>: Remove.
13617         <m_error>: New member.
13618         (gdbpy_exception_to_string): Don't declare.
13619         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13620         * python/py-value.c (convert_value_from_python): Use
13621         gdbpy_err_fetch.
13622         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13623         gdbpy_exception_to_string.
13624         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13625         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13626         gdbpy_err_fetch.
13627
13628 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13629
13630         * linux-nat.c (delete_lwp_cleanup): Delete.
13631         (struct lwp_deleter): New struct.
13632         (lwp_info_up): New typedef.
13633         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13634         lwp_info_up.
13635
13636 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13637
13638         * linux-fork.c (class scoped_switch_fork_info): New class.
13639         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13640
13641 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13642
13643         * valops.c (find_overload_match): Remove use of null_cleanup, and
13644         calls to do_cleanups.
13645
13646 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13647
13648         * compile/compile-cplus-types.c
13649         (compile_cplus_instance::decl_name): Handle changes to
13650         cp_func_name.
13651         * cp-support.c (cp_func_name): Update header comment, update
13652         return type.
13653         * cp-support.h (cp_func_name): Update return type in declaration.
13654         * valops.c (find_overload_match): Move temp_func local to top
13655         level of function and change its type.  Use temp_func to hold and
13656         delete temporary string obtained from cp_func_name.
13657
13658 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13659
13660         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13661         gdb::char_vector, remove cleanup, and update uses of `msg`.
13662
13663 2019-01-03  Jim Wilson  <jimw@sifive.com>
13664
13665         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13666
13667 2019-01-02  Tom Tromey  <tom@tromey.com>
13668
13669         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13670         (tdesc_parse_xml): Remove cleanups.
13671         * target-descriptions.h (make_cleanup_free_target_description):
13672         Don't declare.
13673         (target_desc_deleter): New struct.
13674         (target_desc_up): New typedef.
13675         * target-descriptions.c (target_desc_deleter::operator()): Rename
13676         from free_target_description.
13677         (make_cleanup_free_target_description): Remove.
13678
13679 2019-01-02  Tom Tromey  <tom@tromey.com>
13680
13681         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13682         constructor, destructor.
13683         (linespec_parser): Remove typedef.
13684         (~linespec_parser): Rename from linespec_parser_delete.
13685         (linespec_lex_to_end, linespec_complete_label)
13686         (linespec_complete): Update.
13687         (decode_line_full): Remove cleanups.
13688         (decode_line_1): Update.
13689
13690 2019-01-02  Tom Tromey  <tom@tromey.com>
13691
13692         * python/python-internal.h (inferior_to_inferior_object): Change
13693         return type.
13694         * python/py-exitedevent.c (create_exited_event_object): Update.
13695         * python/py-inferior.c (inferior_to_inferior_object): Return
13696         gdbpy_ref.
13697         (python_new_inferior, python_inferior_deleted)
13698         (thread_to_thread_object, delete_thread_object)
13699         (build_inferior_list, gdbpy_selected_inferior): Update.
13700         * python/py-infthread.c (create_thread_object): Update.  Also fail
13701         if inferior_to_inferior_object fails.
13702
13703 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13704
13705         * inferior.h (class inferior) <displaced_step_state>: New field.
13706         * infrun.h (struct displaced_step_state): Move here from
13707         infrun.c.  Initialize fields, add constructor.
13708         <inf>: Remove field.
13709         <reset>: New method.
13710         * infrun.c (struct displaced_step_inferior_state): Move to
13711         infrun.h.
13712         (displaced_step_inferior_states): Remove.
13713         (get_displaced_stepping_state): Adust.
13714         (displaced_step_in_progress_any_inferior): Adjust.
13715         (displaced_step_in_progress_thread): Adjust.
13716         (displaced_step_in_progress): Adjust.
13717         (add_displaced_stepping_state): Remove.
13718         (get_displaced_step_closure_by_addr): Adjust.
13719         (remove_displaced_stepping_state): Remove.
13720         (infrun_inferior_exit): Call displaced_step_state.reset.
13721         (use_displaced_stepping): Don't check for NULL.
13722         (displaced_step_prepare_throw): Call
13723         get_displaced_stepping_state.
13724         (displaced_step_fixup): Don't check for NULL.
13725         (prepare_for_detach): Don't check for NULL.
13726
13727 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13728
13729         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13730          in case of call that did not complete.
13731
13732 2019-01-02  Andrey Utkin  <autkin@undo.io>
13733
13734         * symfile.c (find_separate_debug_file): Fix search of debug files for
13735         remote debuggee.
13736
13737 2019-01-02  Tom Tromey  <tom@tromey.com>
13738
13739         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13740         indentation.
13741         * python/py-frame.c (frapy_older): Remove cast.
13742         (frapy_newer): Likewise.
13743         * python/py-breakpoint.c (local_setattro): Remove cast.
13744         * python/py-arch.c (archpy_name): Remove local variable.
13745         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13746
13747 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13748
13749         * unittests/basic_string_view/element_access/char/empty.cc:
13750         Fix year range in copyright header.
13751
13752 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13753
13754         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13755         Delete.
13756         <operator==>: Update with for removed field.
13757         <hash>: Likewise.
13758         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13759         <isa_features>: ...this.
13760         <abi_features>: New field.
13761         (riscv_isa_flen): Update comment.
13762         (riscv_abi_xlen): New declaration.
13763         (riscv_abi_flen): New declaration.
13764         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13765         isa_features.
13766         (riscv_abi_xlen): New function.
13767         (riscv_isa_flen): Update to get answer from isa_features.
13768         (riscv_abi_flen): New function.
13769         (riscv_has_fp_abi): Update to get answer from abi_features.
13770         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13771         xlen and flen.
13772         (riscv_call_info) <xlen, flen>: Update comment.
13773         (riscv_call_arg_struct): Remove invalid assertions
13774         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13775         is removed.
13776         (riscv_gdbarch_init): Gather isa features and abi features
13777         separately, ensure both match on the gdbarch when reusing an old
13778         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13779         a target with 64-bit float hardware.
13780
13781 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13782
13783         * source.c (search_command_helper): Stop reverse search
13784         when line 1 has been searched.
13785
13786 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13787
13788         * record-full.c (record_full_base_target::close): Rewrite
13789         record_full_core_buf_list free logic.
13790
13791 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13792
13793         * break-catch-syscall.c (print_one_catch_syscall): xfree
13794         the last text.
13795
13796 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13797
13798         * top.c (print_gdb_version): Update Copyright year in version
13799         message.
13800
13801 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13802
13803         Update copyright year range in all GDB files.
13804
13805 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13806
13807         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13808
13809 For older changes see ChangeLog-2018.
13810 \f
13811 Local Variables:
13812 mode: change-log
13813 left-margin: 8
13814 fill-column: 74
13815 version-control: never
13816 coding: utf-8
13817 End:
13818