gdb/ChangeLog

   1 2019-07-03  Pedro Alves  <palves@redhat.com>
   2
   3         * maint-test-settings.c (maintenance_test_settings_xxx)
   4         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
   5         New.
   6         (maintenance_test_settings_enums): Use them.
   7         (maintenance_test_settings_enum): Default to
   8         maintenance_test_settings_xxx.
   9         (_initialize_maint_test_settings): Initialize
  10         MAINTENANCE_TEST_SETTINGS_FILENAME.
  11
  12 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
  13
  14         * breakpoint.h (remove_breakpoints_inf): Change return type to
  15         void, move function documentation here.
  16         * breakpoint.c (remove_breakpoints_inf): Change return type to
  17         void, move function documentation to header.
  18
  19 2019-07-02  Pedro Alves  <palves@redhat.com>
  20
  21         * NEWS (Completion improvements): Mention "info threads".
  22         * thread.c (struct info_threads_opts, info_threads_option_defs)
  23         (make_info_threads_options_def_group): New.
  24         (info_threads_command): Use gdb::option::process_options.
  25         (info_threads_command_completer): New.
  26         (_initialize_thread): Use gdb::option::build_help to build the
  27         help text for "info threads".
  28
  29 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
  30
  31         * defs.h (generic_load): Move from here...
  32         * symfile.h (generic_load): ... to here.  Rename name parameter
  33         to args.
  34         * symfile.c (generic_load): Add comment.
  35
  36 2019-07-01  Tom Tromey  <tromey@adacore.com>
  37
  38         * dwarf2read.c
  39         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
  40         declaration of without_params.  Fix formatting.
  41
  42 2019-07-01  Tom Tromey  <tromey@adacore.com>
  43
  44         * ada-exp.y (find_primitive_type): Update.
  45         * ada-lang.h (ada_lookup_symbol): Update.
  46         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
  47         parameter.
  48         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
  49
  50 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
  51
  52         PR breakpoints/24541
  53         * gdbarch.c: Regenerate.
  54         * gdbarch.h: Regenerate.
  55         * gdbarch.sh: Add 'stap_adjust_register'.
  56         * i386-tdep.c: Include '<unordered_set>'.
  57         (i386_stap_adjust_register): New function.
  58         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
  59         * stap-probe.c (stap_parse_register_operand): Call
  60         'gdbarch_stap_adjust_register'.
  61
  62 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
  63
  64         PR python/24742
  65         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
  66         * python/python.c (do_start_initialization): Use 'xmalloc'
  67         instead of 'PyMem_Malloc'.
  68
  69 2019-06-28  Tom Tromey  <tromey@adacore.com>
  70
  71         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
  72         for Ada.
  73
  74 2019-06-27  Tom Tromey  <tromey@adacore.com>
  75
  76         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
  77         objfile_key.
  78         (arm_find_mapping_symbol, arm_record_special_symbol)
  79         (_initialize_arm_tdep): Update.
  80         (arm_objfile_data_free): Remove.
  81
  82 2019-06-27  Tom Tromey  <tromey@adacore.com>
  83
  84         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
  85         to cp_print_static_field.
  86
  87 2019-06-26  Tom Tromey  <tromey@adacore.com>
  88
  89         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
  90         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
  91         declare.
  92
  93 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
  94
  95         * features/aarch64-core.c (create_feature_aarch64_core):
  96         Regenerate.
  97         * features/aarch64-core.xml: Add cpsr flags.
  98
  99 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 100
 101         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 102         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 103
 104 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 105
 106         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 107         field.
 108         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 109         use.
 110         (arm_record_special_symbol): Don't insert new symbol in sorted
 111         position, push it at the end.
 112
 113 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 114
 115         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 116         (arm_mapping_symbol_s): Remove.
 117         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 118         (arm_mapping_symbol_vec): New typedef.
 119         (struct arm_per_objfile): Add constructor.
 120         <section_maps>: Change type to
 121         std::unique_ptr<arm_mapping_symbol_vec[]>.
 122         (arm_compare_mapping_symbols): Remove.
 123         (arm_find_mapping_symbol): Adjust to section_maps type change.
 124         (arm_objfile_data_free): Call delete on arm_per_objfile.
 125         (arm_record_special_symbol): Adjust to section_maps type change.
 126         Allocate arm_per_objfile with new.
 127
 128 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 129
 130         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 131         with the command prefix.
 132
 133 2019-06-25  Tom Tromey  <tom@tromey.com>
 134
 135         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 136         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 137
 138 2019-06-25  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 141         type.
 142         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 143         protected.
 144
 145 2019-06-25  Tom Tromey  <tom@tromey.com>
 146
 147         * tui/tui-winsource.c
 148         (tui_source_window_base::set_is_exec_point_at): Add check against
 149         LOA_ADDRESS.
 150
 151 2019-06-25  Tom Tromey  <tom@tromey.com>
 152
 153         * tui/tui-source.c (tui_set_source_content): Don't check before
 154         xfree.
 155         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 156
 157 2019-06-25  Tom Tromey  <tom@tromey.com>
 158
 159         * tui/tui-winsource.h (tui_update_source_window_as_is)
 160         (tui_alloc_source_buffer, tui_line_is_displayed)
 161         (tui_addr_is_displayed): Change type of win_info.
 162         * tui/tui-winsource.c (tui_update_source_window_as_is)
 163         (tui_clear_source_content, tui_show_source_line)
 164         (tui_show_source_content, tui_source_window_base::refill)
 165         (tui_source_window_base::set_is_exec_point_at)
 166         (tui_source_window_base::set_is_exec_point_at)
 167         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 168         (tui_alloc_source_buffer, tui_line_is_displayed)
 169         (tui_addr_is_displayed): Change type of win_info.  Update.
 170         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 171         (tui_source_window_base::do_make_visible_with_new_height):
 172         Update.
 173         * tui/tui-source.c (tui_set_source_content)
 174         (tui_set_source_content_nil)
 175         (tui_source_window::do_scroll_vertical): Update.
 176         * tui/tui-layout.c (show_layout): Update.
 177         * tui/tui-disasm.c (tui_set_disassem_content)
 178         (tui_disasm_window::do_scroll_vertical): Update.
 179         * tui/tui-data.h (tui_win_content): Remove.
 180         (struct tui_gen_win_info) <content, content_size>: Remove.
 181         (struct tui_source_element): Add initializers and destructor.
 182         (union tui_which_element, struct tui_win_element): Remove.
 183         (struct tui_source_window_base) <content>: New field.
 184         (struct tui_data_window): Remove destructor.
 185         (tui_alloc_content, tui_free_win_content)
 186         (tui_free_all_source_wins_content): Don't declare.
 187         * tui/tui-data.c (tui_initialize_static_data): Update.
 188         (init_content_element, tui_alloc_content): Remove.
 189         (~tui_gen_win_info): Update.
 190         (~tui_data_window, tui_free_all_source_wins_content)
 191         (tui_free_win_content, free_content, free_content_elements):
 192         Remove.
 193
 194 2019-06-25  Tom Tromey  <tom@tromey.com>
 195
 196         * tui/tui-winsource.h (tui_clear_source_content)
 197         (tui_erase_source_content, tui_show_source_content): Change type
 198         of win_info.
 199         * tui/tui-winsource.c (tui_clear_source_content)
 200         (tui_erase_source_content, tui_show_source_content): Change type
 201         of win_info.
 202         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 203         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 204         win_info.
 205         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 206         win_info.
 207         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 208
 209 2019-06-25  Tom Tromey  <tom@tromey.com>
 210
 211         * tui/tui-winsource.c (tui_clear_source_content)
 212         (tui_source_window_base::set_is_exec_point_at): Update.
 213         * tui/tui-source.c (tui_set_source_content_nil): Update.
 214         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 215         a bool.
 216         * tui/tui-data.c (init_content_element): Update.
 217
 218 2019-06-25  Tom Tromey  <tom@tromey.com>
 219
 220         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 221         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 222         * tui/tui-layout.c (init_and_make_win): Update.
 223         * tui/tui.h (enum tui_win_type): Update.
 224         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 225         tui_win_is_auxillary.
 226         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 227         tui_win_is_auxillary.
 228
 229 2019-06-25  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 232         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 233         (tui_delete_data_content_windows, tui_display_all_data)
 234         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 235         Update.
 236         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 237         * tui/tui-regs.c (tui_last_regs_line_no)
 238         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 239         (tui_show_registers): Update.
 240         (tui_show_register_group): Return void.  Update.
 241         (tui_display_registers_from, tui_display_reg_element_at_line)
 242         (tui_display_registers_from_line, tui_check_register_values):
 243         Update.
 244         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 245         member.
 246         (struct tui_data_window) <regs_content>: Now a std::vector.
 247         <regs_content_count>: Remove.
 248         (tui_add_content_elements, tui_free_data_content): Don't declare.
 249         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 250         (init_content_element): Remove DATA_WIN case.  Add assert.
 251         (tui_add_content_elements): Remove.
 252         (tui_data_window): Update.
 253         (tui_free_data_content): Remove.
 254         (free_content_elements): Remove DATA_WIN case.
 255
 256 2019-06-25  Tom Tromey  <tom@tromey.com>
 257
 258         * tui/tui-data.c (tui_data_item_window): Update.
 259         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 260         * tui/tui-windata.c (tui_display_all_data)
 261         (tui_display_data_from_line): Update.
 262         (tui_check_data_values): Remove.
 263         * tui/tui-regs.c (tui_show_register_group)
 264         (tui_display_reg_element_at_line): Update.
 265         * tui/tui-hooks.c (tui_register_changed)
 266         (tui_refresh_frame_and_register_information): Call
 267         tui_check_register_values.
 268         * tui/tui-data.h (struct tui_data_window) <data_content,
 269         data_content_count, data_type>: Remove.
 270         (enum tui_data_type): Remove.
 271
 272         * tui/tui-data.c (tui_data_window::clear_detail)
 273         (~tui_data_window): Update.
 274
 275 2019-06-25  Tom Tromey  <tom@tromey.com>
 276
 277         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 278         declare.
 279         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 280         Rename from tui_first_data_item_displayed.  Update.
 281         (tui_data_window::refresh_all)
 282         (tui_data_window::do_scroll_vertical): Update.
 283         * tui/tui-data.h (struct tui_data_window)
 284         <first_data_item_displayed>: Declare new method.
 285
 286 2019-06-25  Tom Tromey  <tom@tromey.com>
 287
 288         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 289         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 290         contents...
 291         (tui_initialize_static_data): ...here.
 292
 293 2019-06-25  Tom Tromey  <tom@tromey.com>
 294
 295         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 296         (tui_display_registers_from, tui_check_register_values): Update.
 297         (tui_display_register): Remove win_info parameter; update.
 298         (tui_get_register): Change type of parameters.
 299         * tui/tui-data.h (struct tui_data_element): Remove.
 300         (union tui_which_element) <data>: Remove.
 301         <data_window>: Change type.
 302         (struct tui_data_item_window): New.
 303         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 304         case.  Add assert.
 305         (~tui_data_item_window): New destructor.
 306         (free_content_elements): Remove DATA_ITEM_WIN case.
 307
 308 2019-06-25  Tom Tromey  <tom@tromey.com>
 309
 310         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 311         Remove.
 312
 313 2019-06-25  Tom Tromey  <tom@tromey.com>
 314
 315         * tui/tui-data.h (struct tui_command_element): Remove.
 316         (union tui_which_element) <command>: Remove.
 317         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 318         assert.
 319         (free_content_elements): Remove CMD_WIN case.
 320
 321 2019-06-25  Tom Tromey  <tom@tromey.com>
 322
 323         * tui/tui-layout.c (tui_set_layout): Update.
 324         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 325         * tui/tui-data.c (layout_def): Update.
 326
 327 2019-06-25  Tom Tromey  <tom@tromey.com>
 328
 329         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 330         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 331         (tui_source_window_base::set_new_height): Update.
 332         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 333         Update.
 334         (tui_set_locator_fullname, tui_set_locator_info)
 335         (tui_show_frame_info): Update.
 336         * tui/tui-source.c (tui_set_source_content)
 337         (tui_source_is_displayed): Update.
 338         * tui/tui-layout.c (show_source_disasm_command, show_data)
 339         (show_source_or_disasm_and_command): Update.
 340         * tui/tui-disasm.c (tui_set_disassem_content)
 341         (tui_get_begin_asm_address): Update.
 342         * tui/tui-data.h (struct tui_locator_element): Remove.
 343         (union tui_which_element) <locator>: Remove.
 344         (struct tui_locator_window): New.
 345         (tui_locator_win_info_ptr): Change return type.
 346         * tui/tui-data.c (_locator): Change type.
 347         (tui_locator_win_info_ptr): Change return type.
 348         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 349         (tui_alloc_content): Add assert.
 350
 351 2019-06-25  Tom Tromey  <tom@tromey.com>
 352
 353         * tui/tui-winsource.c
 354         (tui_exec_info_window::maybe_allocate_content): New method.
 355         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 356         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 357         (make_source_or_disasm_window): Add cast.
 358         * tui/tui-data.h (union tui_which_element) <simple_string>:
 359         Remove.
 360         (struct tui_source_info): New.
 361         (struct tui_source_window_base) <execution_info>: Change type.
 362         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 363         case, and add assert.
 364         (tui_alloc_content): Add assert.
 365
 366 2019-06-25  Tom Tromey  <tom@tromey.com>
 367
 368         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 369         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 370         * tui/tui-data.c (tui_alloc_win_info): Remove.
 371
 372 2019-06-25  Tom Tromey  <tom@tromey.com>
 373
 374         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 375         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 376         can_highlight.
 377
 378 2019-06-25  Tom Tromey  <tom@tromey.com>
 379
 380         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 381         make_visible_with_new_height method.
 382         (tui_win_info::make_visible_with_new_height): New method.
 383         (tui_source_window_base::do_make_visible_with_new_height)
 384         (tui_data_window::do_make_visible_with_new_height)
 385         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 386         (make_visible_with_new_height): Remove.
 387         (tui_resize_all, tui_adjust_win_heights): Use
 388         make_visible_with_new_height method.
 389         * tui/tui-data.h (struct tui_win_info)
 390         <do_make_visible_with_new_height, make_visible_with_new_height>:
 391         New methods.
 392         (struct tui_source_window_base, struct tui_data_window)
 393         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 394         methods.
 395
 396 2019-06-25  Tom Tromey  <tom@tromey.com>
 397
 398         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 399         method.
 400         (update_tab_width): Call update_tab_width method.
 401         * tui/tui-data.h (struct tui_win_info)
 402         (struct tui_source_window_base) <update_tab_width>: New methods.
 403
 404 2019-06-25  Tom Tromey  <tom@tromey.com>
 405
 406         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 407         parameter.
 408         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 409         parameter.
 410         (tui_gen_win_info::make_visible): Update.
 411         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 412         parameter.
 413         * tui/tui-data.h (enum tui_box): New enum.
 414         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 415
 416 2019-06-25  Tom Tromey  <tom@tromey.com>
 417
 418         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 419         init_and_make_win for EXEC_INFO_WIN.
 420         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 421         longer inline.
 422         (struct tui_win_info) <~tui_win_info>: Inline.
 423         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 424         Don't declare.
 425         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 426         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 427         Remove.
 428         (tui_initialize_static_data): Update.
 429         (~tui_gen_win_info): Handle more cleanup here.
 430         (~tui_source_window_base): Delete "execution_info".
 431         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 432
 433 2019-06-25  Tom Tromey  <tom@tromey.com>
 434
 435         * tui/tui-layout.c (make_command_window): Don't set
 436         can_highlight.
 437         (show_source_disasm_command): Call the reset method.
 438         (show_data): Don't set can_highlight.  Call the reset method.
 439         (tui_gen_win_info::reset): Rename from init_gen_win_info
 440         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 441         (show_source_or_disasm_and_command): Call the reset method.
 442         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 443         (struct tui_cmd_window): Set can_highlight.
 444
 445 2019-06-25  Tom Tromey  <tom@tromey.com>
 446
 447         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 448         from make_visible.
 449         (tui_make_visible, tui_make_invisible): Rewrite.
 450         (tui_win_info::make_visible): Remove.
 451         (tui_source_window_base::make_visible): Update.
 452         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 453         method.  Moved from...
 454         (struct tui_win_info) <make_visible>: ...here.
 455
 456 2019-06-25  Tom Tromey  <tom@tromey.com>
 457
 458         * tui/tui-winsource.c
 459         (tui_source_window_base::do_scroll_horizontal): Remove direction
 460         parameter.
 461         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 462         direction parameter.
 463         * tui/tui-win.c (tui_win_info::forward_scroll)
 464         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 465         (tui_win_info::right_scroll): Update.
 466         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 467         direction parameter.
 468         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 469         direction parameter.
 470         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 471         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 472         Remove direction parameter.
 473         (struct tui_source_window_base, struct tui_source_window)
 474         (struct tui_disasm_window, struct tui_data_window)
 475         (struct tui_cmd_window): Update.
 476
 477 2019-06-25  Tom Tromey  <tom@tromey.com>
 478
 479         * tui/tui-winsource.h (tui_set_exec_info_content)
 480         (tui_show_exec_info_content, tui_erase_exec_info_content)
 481         (tui_clear_exec_info_content, tui_update_exec_info): Change
 482         argument to tui_source_window_base.
 483         * tui/tui-winsource.c (tui_set_exec_info_content)
 484         (tui_show_exec_info_content, tui_erase_exec_info_content)
 485         (tui_clear_exec_info_content, tui_update_exec_info): Change
 486         argument to tui_source_window_base.
 487
 488 2019-06-25  Tom Tromey  <tom@tromey.com>
 489
 490         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 491         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 492
 493 2019-06-25  Tom Tromey  <tom@tromey.com>
 494
 495         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 496         check.
 497
 498 2019-06-25  Tom Tromey  <tom@tromey.com>
 499
 500         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 501         type to void.
 502         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 503         type to void.
 504         * tui/tui-source.c (tui_set_source_content): Update.
 505         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 506
 507 2019-06-25  Tom Tromey  <tom@tromey.com>
 508
 509         * tui/tui-win.c (window_name_completer, tui_set_focus)
 510         (tui_all_windows_info): Use name method.
 511         * tui/tui-data.h (struct tui_gen_win_info)
 512         (struct tui_source_window, struct tui_disasm_window)
 513         (struct tui_data_window, struct tui_cmd_window) <name>: New
 514         method.
 515         (tui_win_name): Don't declare.
 516         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 517         (tui_win_name): Remove.
 518
 519 2019-06-25  Tom Tromey  <tom@tromey.com>
 520
 521         * tui/tui-winsource.h (tui_update_source_window)
 522         (tui_update_source_window_as_is): Change parameter type.
 523         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 524         to be a tui_source_window_base.
 525         (tui_update_source_window_as_is): Likewise.
 526         * tui/tui-win.c (make_visible_with_new_height): Update.
 527
 528 2019-06-25  Tom Tromey  <tom@tromey.com>
 529
 530         * tui/tui-winsource.c (tui_erase_source_content)
 531         (tui_show_source_content, tui_show_exec_info_content)
 532         (tui_erase_exec_info_content): Use refresh_window method.
 533         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 534         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 535         from tui_refresh_win.
 536         (tui_data_window::refresh_window): New method.
 537         (tui_win_info::refresh, tui_source_window_base::refresh)
 538         (tui_refresh_all): Use refresh_window method.
 539         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 540         method.
 541         * tui/tui-regs.c (tui_display_register): Call refresh_window
 542         method.
 543         * tui/tui-layout.c (show_source_disasm_command)
 544         (show_source_or_disasm_and_command): Call refresh_window method.
 545         * tui/tui-data.h (struct tui_gen_win_info)
 546         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 547         New method.
 548
 549 2019-06-25  Tom Tromey  <tom@tromey.com>
 550
 551         * tui/tui.c (tui_rl_other_window, tui_enable)
 552         (tui_is_window_visible, tui_get_command_dimension): Update.
 553         * tui/tui-winsource.c (tui_update_source_window_as_is)
 554         (tui_clear_source_content, tui_erase_source_content)
 555         (tui_show_source_line, tui_source_window_base::refill)
 556         (tui_source_window_base::do_scroll_horizontal)
 557         (tui_source_window_base::set_is_exec_point_at)
 558         (tui_update_breakpoint_info, tui_set_exec_info_content)
 559         (tui_alloc_source_buffer, tui_line_is_displayed)
 560         (tui_addr_is_displayed): Update.
 561         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 562         (tui_check_and_display_highlight_if_needed)
 563         (tui_win_info::make_visible, tui_win_info::refresh)
 564         (tui_refresh_all): Update.
 565         * tui/tui-windata.c (tui_first_data_item_displayed)
 566         (tui_delete_data_content_windows, tui_erase_data_content)
 567         (tui_display_all_data, tui_data_window::refresh_all)
 568         (tui_check_data_values): Update.
 569         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 570         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 571         (tui_win_info::backward_scroll, tui_refresh_all_win)
 572         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 573         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 574         (tui_source_window_base::set_new_height)
 575         (tui_data_window::set_new_height)
 576         (make_invisible_and_set_new_height)
 577         (make_visible_with_new_height, new_height_ok)
 578         (parse_scrolling_args): Update.
 579         * tui/tui-stack.c (tui_show_frame_info): Update.
 580         * tui/tui-source.c (tui_set_source_content)
 581         (tui_set_source_content_nil, tui_source_is_displayed)
 582         (tui_source_window::do_scroll_vertical): Update.
 583         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 584         (tui_display_registers_from, tui_display_reg_element_at_line)
 585         (tui_check_register_values, tui_reg_command): Update.
 586         * tui/tui-layout.c (tui_default_win_height)
 587         (show_source_disasm_command, show_data, init_and_make_win)
 588         (show_source_or_disasm_and_command): Update.
 589         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 590         (tui_redisplay_readline, tui_mld_flush)
 591         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 592         (tui_getc): Update.
 593         * tui/tui-disasm.c (tui_set_disassem_content)
 594         (tui_disasm_window::do_scroll_vertical): Update.
 595         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 596         Now virtual.
 597         (struct tui_win_info): Derive from tui_gen_win_info.
 598         <~tui_win_info>: Mark as override.
 599         <generic>: Remove member.
 600         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 601         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 602         (~tui_data_window, ~tui_win_info)
 603         (tui_free_all_source_wins_content): Update.
 604         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 605
 606 2019-06-25  Tom Tromey  <tom@tromey.com>
 607
 608         * tui/tui-layout.c (init_and_make_win): Use new.
 609         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 610         destructor, initializers.
 611         (tui_alloc_generic_win_info): Don't declare.
 612         * tui/tui-data.c (_locator): Add argument to constructor.
 613         (source_win, disasm_win): New globals.
 614         (exec_info): Remove.
 615         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 616         Update.
 617         (tui_alloc_generic_win_info): Remove.
 618         (init_content_element): Use new.
 619         (tui_win_info::tui_win_info): Update.
 620         (free_content_elements) <case DATA_WIN>: Use delete.
 621
 622 2019-06-25  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 625         * tui/tui-windata.c (tui_first_data_item_displayed)
 626         (tui_delete_data_content_windows): Update.
 627         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 628         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 629         (tui_display_registers_from, tui_check_register_values): Update.
 630         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 631         pointer.
 632         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 633         window.
 634         (tui_free_data_content): Update.
 635         (free_content_elements) <case DATA_WIN>: Free the window.
 636
 637 2019-06-25  Tom Tromey  <tom@tromey.com>
 638
 639         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 640         Update.
 641         * tui/tui-layout.c (make_command_window)
 642         (show_source_disasm_command, show_data, init_and_make_win)
 643         (show_source_or_disasm_and_command): Update.
 644         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 645         method.
 646         <can_highight, is_highlighted>: Now bool.
 647         (tui_set_win_highlight): Don't declare.
 648         * tui/tui-data.c (tui_set_win_highlight): Remove.
 649
 650 2019-06-25  Tom Tromey  <tom@tromey.com>
 651
 652         * tui/tui-wingeneral.c (make_visible): Remove check of window
 653         type.
 654
 655 2019-06-25  Tom Tromey  <tom@tromey.com>
 656
 657         * tui/tui-win.c (tui_win_info::max_height)
 658         (tui_cmd_window::max_height): New methods.
 659         (new_height_ok): Call max_height.
 660         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 661         <max_height>: New method.
 662
 663 2019-06-25  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui-win.c (tui_source_window_base::set_new_height)
 666         (tui_data_window::set_new_height): New methods.
 667         (make_invisible_and_set_new_height): Call set_new_height method.
 668         * tui/tui-data.h (struct tui_win_info)
 669         (struct tui_source_window_base, struct tui_data_window)
 670         <set_new_height>: New method.
 671
 672 2019-06-25  Tom Tromey  <tom@tromey.com>
 673
 674         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 675         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 676         tui_refresh_data_win.
 677         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 678         method.
 679         (tui_refresh_all_win): Call the refresh_all method.
 680         (tui_set_focus): Likewise.
 681         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 682         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 683         Likewise.
 684
 685 2019-06-25  Tom Tromey  <tom@tromey.com>
 686
 687         * tui/tui-winsource.h (tui_refill_source_window)
 688         (tui_set_is_exec_point_at): Don't declare.
 689         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 690         (tui_source_window_base::refill): Rename from
 691         tui_refill_source_window.
 692         (tui_source_window_base::do_scroll_horizontal): Update.
 693         (tui_source_window_base::set_is_exec_point_at): Rename from
 694         tui_set_is_exec_point_at.
 695         (tui_update_all_breakpoint_info): Update.
 696         * tui/tui-stack.c (tui_show_frame_info): Update.
 697         * tui/tui-layout.c (show_data): Add cast.
 698         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 699         * tui/tui-data.h (struct tui_source_window_base) <refill,
 700         set_is_exec_point_at>: New methods.
 701         (tui_source_windows, tui_add_to_source_windows): Update types.
 702         (tui_add_to_source_windows): Remove redundant declaration.
 703         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 704         (tui_source_windows): Change return type.
 705         (tui_clear_source_windows_detail): Update.
 706         (tui_add_to_source_windows): Change type of parameter.
 707         (tui_free_all_source_wins_content): Update.
 708
 709 2019-06-25  Tom Tromey  <tom@tromey.com>
 710
 711         * tui/tui-wingeneral.c (tui_win_info::refresh)
 712         (tui_source_window_base::refresh): New methods.
 713         (tui_refresh_all): Call the refresh method.
 714         * tui/tui-data.h (struct tui_win_info)
 715         (struct tui_source_window_base) <refresh>: New method.
 716
 717 2019-06-25  Tom Tromey  <tom@tromey.com>
 718
 719         * tui/tui.h (tui_is_window_visible): Return bool.
 720         * tui/tui.c (tui_is_window_visible): Return bool.
 721         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 722         (tui_make_visible, tui_make_invisible)
 723         (tui_win_info::make_visible)
 724         (tui_source_window_base::make_visible, make_all_visible)
 725         (tui_make_all_visible, tui_make_all_invisible): Update.
 726         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 727         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 728         bool.
 729         (struct tui_win_info, struct tui_source_window_base)
 730         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 731         * tui/tui-data.c (tui_init_generic_part): Update.
 732
 733 2019-06-25  Tom Tromey  <tom@tromey.com>
 734
 735         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 736         (tui_source_window_base::make_visible): New methods.
 737         (make_all_visible): Make method call.
 738         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 739         (struct tui_source_window_base, struct tui_cmd_window): Override
 740         make_visible.
 741         (tui_win_is_source_type): Don't declare.
 742         * tui/tui-data.c (tui_win_is_source_type): Remove.
 743
 744 2019-06-25  Tom Tromey  <tom@tromey.com>
 745
 746         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 747         NULL check.
 748
 749 2019-06-25  Tom Tromey  <tom@tromey.com>
 750
 751         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 752         Inline constructor.  Add initializers for members.
 753         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 754         constructors; now inline in class.
 755
 756 2019-06-25  Tom Tromey  <tom@tromey.com>
 757
 758         * tui/tui-regs.c (tui_show_registers): Update.
 759         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 760         bool.
 761         * tui/tui-data.c (tui_data_window::clear_detail)
 762         (tui_data_window): Update.
 763
 764 2019-06-25  Tom Tromey  <tom@tromey.com>
 765
 766         * tui/tui-windata.c (tui_display_all_data)
 767         (tui_display_data_from_line, tui_display_data_from)
 768         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 769         Update.
 770         * tui/tui-regs.c (tui_last_regs_line_no)
 771         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 772         (tui_show_registers, tui_show_register_group)
 773         (tui_display_registers_from, tui_display_reg_element_at_line)
 774         (tui_display_registers_from_line, tui_check_register_values)
 775         (tui_reg_next, tui_reg_prev): Update.
 776         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 777         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 778         tui_data_window.
 779         (struct tui_win_info) <detail>: Remove.  Add new fields from
 780         tui_data_info.
 781         (TUI_DATA_WIN): Add cast.
 782         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 783         (~tui_data_window): Simplify.
 784
 785 2019-06-25  Tom Tromey  <tom@tromey.com>
 786
 787         * tui/tui-layout.c (show_source_disasm_command)
 788         (show_source_or_disasm_and_command): Update.
 789         * tui/tui-io.c (update_cmdwin_start_line)
 790         (tui_redisplay_readline): Update.
 791         * tui/tui-data.h (struct tui_command_info): Remove.
 792         (struct tui_win_info) <detail>: Remove command_info member.
 793         (struct tui_data_window) <start_line>: New member, from
 794         tui_command_info.
 795         (TUI_CMD_WIN): Add casts.
 796
 797 2019-06-25  Tom Tromey  <tom@tromey.com>
 798
 799         * tui/tui-winsource.c (tui_update_source_window)
 800         (tui_refill_source_window)
 801         (tui_source_window_base::do_scroll_horizontal)
 802         (tui_update_breakpoint_info, tui_set_exec_info_content)
 803         (tui_show_exec_info_content, tui_erase_exec_info_content)
 804         (tui_clear_exec_info_content): Update.
 805         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 806         Update.
 807         * tui/tui-win.c (make_invisible_and_set_new_height)
 808         (make_visible_with_new_height): Update.
 809         * tui/tui-source.c (tui_set_source_content)
 810         (tui_show_symtab_source): Update.
 811         * tui/tui-layout.c (extract_display_start_addr)
 812         (show_source_disasm_command, show_data)
 813         (make_source_or_disasm_window)
 814         (show_source_or_disasm_and_command): Update.
 815         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 816         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 817         "gdbarch".
 818         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 819         to tui_source_window_base.
 820         (struct tui_win_info) <detail>: Remove source_info member.
 821         (struct tui_source_window_base) <has_locator>: Inline.
 822         Move contents from tui_source_info; rename has_locator member to
 823         m_has_locator.
 824         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 825         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 826         header file.
 827         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 828         Simplify.
 829         (tui_free_all_source_wins_content): Cast to
 830         tui_source_window_base.
 831
 832 2019-06-25  Tom Tromey  <tom@tromey.com>
 833
 834         * tui/tui-win.c (make_invisible_and_set_new_height)
 835         (make_visible_with_new_height): Call has_locator method.
 836         * tui/tui-layout.c (show_source_disasm_command, show_data)
 837         (show_source_or_disasm_and_command): Update for bool change.
 838         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 839         (tui_win_info) <has_locator>: New method.
 840         (struct tui_source_window_base) <has_locator>: New method.
 841         (tui_win_has_locator): Don't declare.
 842         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 843         from tui_win_has_locator.
 844         (tui_source_window_base): Use false, not FALSE.
 845
 846 2019-06-25  Tom Tromey  <tom@tromey.com>
 847
 848         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 849         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 850         clear_detail method directly.
 851         (tui_clear_win_detail): Remove.
 852
 853 2019-06-25  Tom Tromey  <tom@tromey.com>
 854
 855         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 856         "this", not TUI_DISASM_WIN.
 857
 858 2019-06-25  Tom Tromey  <tom@tromey.com>
 859
 860         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 861         declare.
 862         * tui/tui-winsource.c
 863         (tui_source_window_base::do_scroll_horizontal): Rename from
 864         tui_horizontal_source_scroll.
 865         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 866         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 867         from tui_vertical_data_scroll.
 868         * tui/tui-win.h (tui_scroll): Don't declare.
 869         * tui/tui-win.c (tui_win_info::forward_scroll)
 870         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 871         (tui_win_info::right_scroll): Rename and update.
 872         (tui_scroll_forward_command, tui_scroll_backward_command)
 873         (tui_scroll_left_command, tui_scroll_right_command): Update.
 874         (tui_scroll): Remove.
 875         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 876         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 877         from tui_vertical_source_scroll.
 878         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 879         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 880         from tui_vertical_disassem_scroll.
 881         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 882         do_scroll_horizontal>: New methods.
 883         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 884         Likewise.
 885         (struct tui_source_window_base): Add do_scroll_horizontal.
 886         (struct tui_source_window, struct tui_disasm_window): Add
 887         do_scroll_vertical.
 888         (struct tui_data_window, struct tui_cmd_window): Add
 889         do_scroll_horizontal and do_scroll_vertical.
 890         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 891
 892 2019-06-25  Tom Tromey  <tom@tromey.com>
 893
 894         * tui/tui-data.h (struct tui_source_window_base): New struct.
 895         (struct tui_source_window): Derive from tui_source_window_base.
 896         (struct tui_disasm_window): New struct.
 897         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 898         from tui_source_window::clear_detail.
 899         (tui_source_window_base): Rename from tui_source_window.
 900         (~tui_source_window_base): Rename from ~tui_source_window.
 901         (tui_alloc_win_info): Create a tui_disasm_window.
 902
 903 2019-06-25  Tom Tromey  <tom@tromey.com>
 904
 905         * tui/tui-data.h (struct tui_source_window)
 906         (struct tui_data_window): Declare destructors.
 907         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 908         destructors.
 909         (tui_win_info): Simplify.
 910
 911 2019-06-25  Tom Tromey  <tom@tromey.com>
 912
 913         * tui/tui-winsource.c (tui_display_main)
 914         (tui_update_source_windows_with_addr)
 915         (tui_update_all_breakpoint_info): Update.
 916         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 917         (new_height_ok, parse_scrolling_args): Update.
 918         * tui/tui-stack.c (tui_show_frame_info): Update.
 919         * tui/tui-data.h (struct tui_list): Remove.
 920         (tui_source_windows): Return a reference to a std::vector.
 921         * tui/tui-data.c (source_windows): Now a std::vector.
 922         (tui_source_windows): Change return type.
 923         (tui_clear_source_windows): Rewrite.
 924         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 925         (tui_free_all_source_wins_content): Rewrite.
 926
 927 2019-06-25  Tom Tromey  <tom@tromey.com>
 928
 929         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 930         (struct tui_data_window, struct tui_cmd_window): Declare
 931         clear_detail method.
 932         * tui/tui-data.c (tui_source_window::clear_detail)
 933         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 934         methods.
 935         (tui_clear_win_detail): Simplify.
 936
 937 2019-06-25  Tom Tromey  <tom@tromey.com>
 938
 939         * tui/tui-layout.c (make_source_window, make_disasm_window)
 940         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 941         Return the new window.
 942         (show_source_disasm_command, show_data)
 943         (show_source_or_disasm_and_command): Update.
 944
 945 2019-06-25  Tom Tromey  <tom@tromey.com>
 946
 947         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 948         parameter.  Return the new window.
 949         (show_source_disasm_command): Update and remove NULL check.
 950         (show_source_or_disasm_and_command): Update.
 951
 952 2019-06-25  Tom Tromey  <tom@tromey.com>
 953
 954         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 955
 956 2019-06-25  Tom Tromey  <tom@tromey.com>
 957
 958         * tui/tui-data.h (struct tui_win_info): Make constructor
 959         protected.  Make destructor virtual.  Add initializers.
 960         (tui_source_window, tui_data_window, tui_cmd_window): New
 961         classes.
 962         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 963         constructor.  Add "type" parameter.
 964         (tui_source_window, tui_data_window, tui_cmd_window): New
 965         constructors.
 966         (tui_alloc_win_info): Instantiate the appropriate subclass.
 967
 968 2019-06-25  Tom Tromey  <tom@tromey.com>
 969
 970         * tui/tui-win.c (tui_resize_all): Use delete.
 971         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 972         destructor.
 973         (tui_free_window): Don't declare.
 974         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 975         Update.
 976
 977 2019-06-25  Tom Tromey  <tom@tromey.com>
 978
 979         * tui/tui-data.h (struct tui_win_info): Add constructor.
 980         * tui/tui-data.c (tui_alloc_win_info): Use new.
 981         (tui_free_window): Use delete.
 982
 983 2019-06-22  Tom Tromey  <tom@tromey.com>
 984
 985         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 986         declare.
 987         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 988
 989 2019-06-22  Tom Tromey  <tom@tromey.com>
 990
 991         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 992         declare.
 993         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 994
 995 2019-06-22  Tom de Vries  <tdevries@suse.de>
 996
 997         * dwarf2read.c (create_addrmap_from_aranges)
 998         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 999         instead of '%zu'.
1000
1001 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1002
1003         * dwarf2read.h (dwarf2_section_info_def): Remove.
1004         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1005         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1006         std::vector<dwarf2_section_info>.
1007         (struct dwo_file) <~dwo_file>: Remove.
1008         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1009         types field.
1010         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1011         (dwarf2_read_debug_names): Likewise.
1012         (create_debug_types_hash_table): Change parameter type to
1013         array_view, adjust code accordingly.
1014         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1015         (partial_die_info::fixup): Likewise.
1016         (determine_prefix): Likewise.
1017         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1018
1019 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1020
1021         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1022         gdb_bfd_ref_ptr.
1023         <~dwo_file>: Remove call to gdb_bfd_unref.
1024         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1025         gdb_bfd_ref_ptr::get.
1026
1027 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1028
1029         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1030         type to htab_up.
1031         * dwarf2read.c (struct dwo_file): Initialize fields.
1032         <~dwo_file>: New.
1033         (free_dwo_file): Remove, move content to ~dwo_file.
1034         (struct dwo_file_deleter): Remove.
1035         (dwo_file_up>: Remove custom deleter.
1036         (free_dwo_files): Remove.
1037         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1038         dwo_files.
1039         (process_skeletonless_type_units): Call unique_ptr::get.
1040         (allocate_dwo_file_hash_table): Add deleter to created hash
1041         table.  Change return type to htab_up.
1042         (lookup_dwo_file_slot): Don't memset dwo_file, call
1043         unique_ptr::get.
1044         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1045         (create_dwo_unit_in_dwp_v2): Likewise.
1046         (open_and_init_dwo_file): Likewise.
1047         (free_dwo_file_from_slot): Remove.
1048
1049 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1050
1051         * dwarf2read.h (struct dwarf2_section_info) <readin,
1052         is_virtual>: Change type to bool.
1053         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1054         true instead of 1.
1055
1056 2019-06-19  Tom Tromey  <tom@tromey.com>
1057
1058         * tui/tui-data.h (tui_init_content_element): Don't declare.
1059
1060 2019-06-19  Tom Tromey  <tom@tromey.com>
1061
1062         * tui/tui-data.h (tui_init_win_info): Don't declare.
1063
1064 2019-06-19  Tom de Vries  <tdevries@suse.de>
1065
1066         * dwarf2read.h (abstract_to_concrete): Change type to
1067         std::unordered_map<sect_offset, std::vector<sect_offset>,
1068         gdb::hash_enum<sect_offset>>.
1069
1070 2019-06-19  Tom Tromey  <tromey@adacore.com>
1071
1072         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1073         EVAL_AVOID_SIDE_EFFECTS specially.
1074
1075 2019-06-19  Tom Tromey  <tromey@adacore.com>
1076
1077         * source-cache.c (highlighter): New global.
1078         (source_cache::get_source_lines): Create a highlighter on demand.
1079
1080 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1081
1082         * defs.h (deprecated_interactive_hook): Delete declaration.
1083         * interps.c (clear_interpreter_hooks): Remove use of
1084         deprecated_interactive_hook.
1085         * top.c (deprecated_interactive_hook): Delete definition.
1086         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1087
1088 2019-06-18  Tom de Vries  <tdevries@suse.de>
1089
1090         PR gdb/24515
1091         * dwarf2read.h (abstract_to_concrete): Change type from
1092         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1093         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1094         * dwarf2read.c (read_variable): Update.
1095         (dwarf2_fetch_die_loc_sect_off): Update.
1096
1097 2019-06-17  Tom de Vries  <tdevries@suse.de>
1098
1099         PR gdb/24617
1100         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1101         accessing parent[parent_len - 1].
1102
1103 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1104
1105         PR gdb/24364
1106         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1107         call dtrace_process_dof with NULL dof.
1108
1109 2019-06-16  Tom de Vries  <tdevries@suse.de>
1110
1111         PR gdb/24445
1112         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1113
1114 2019-06-16  Tom Tromey  <tom@tromey.com>
1115
1116         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1117         (make_all_visible): Use address of member.
1118
1119 2019-06-16  Tom Tromey  <tom@tromey.com>
1120
1121         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1122         (tui_free_window, free_content, free_content_elements): Remove
1123         unnecessary cast.
1124         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1125         cast.
1126         * tui/tui-regs.c (tui_show_register_group)
1127         (tui_display_registers_from, tui_display_reg_element_at_line):
1128         Remove unnecessary cast.
1129
1130 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1131
1132         * linux-nat.c (normal_mask): Delete.
1133         (_initialize_linux_nat): Don't initialise normal_mask.
1134
1135 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1136
1137         PR gdb/24445
1138         * dwarf-index-write.h (write_psymtabs_to_index): Add
1139         dwz_basename parameter.
1140         * dwarf-index-write.c (write_gdbindex): Move file writing to
1141         write_gdbindex_1.  Change return type void.
1142         (assert_file_size): Move up, remove filename parameter.
1143         (write_gdbindex_1): New function.
1144         (write_debug_names): Change return type to void, call
1145         assert_file_size.
1146         (struct index_wip_file): New struct.
1147         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1148         file logic to index_wip_file.  Write index for dwz file if
1149         needed.
1150         (save_gdb_index_command): Pass basename of dwz file, if present.
1151         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1152         build-id of dwz file, if present.
1153         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1154         (dwarf2_get_dwz_file): Likewise.
1155         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1156         (dwarf2_get_dwz_file): Likewise.
1157
1158 2019-06-16  Tom Tromey  <tom@tromey.com>
1159
1160         * coffread.c (process_coff_symbol): Use xstrdup.
1161         * value.c (create_internalvar): Use xstrdup.
1162
1163 2019-06-16  Tom Tromey  <tom@tromey.com>
1164
1165         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1166         * breakpoint.c (stopin_command, stopat_command)
1167         (until_break_command, decode_location_default): Remove unnecessary
1168         cast.
1169         * utils.c (subset_compare): Remove unnecessary cast.
1170         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1171         cast.
1172         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1173         cast.
1174         * infcmd.c (path_command): Remove unnecessary cast.
1175         * coffread.c (decode_type): Remove unnecessary cast.
1176         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1177         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1178         * tui/tui-stack.c (tui_show_locator_content)
1179         (tui_show_frame_info): Remove unnecessary cast.
1180         * tui/tui-win.c (tui_scroll_forward_command)
1181         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1182         (parse_scrolling_args): Remove unnecessary cast.
1183         * tui/tui-data.c (init_win_info, tui_del_window)
1184         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1185         (free_content_elements): Remove unnecessary cast.
1186         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1187         unnecessary cast.
1188         * tui/tui-source.c (tui_set_source_content)
1189         (tui_vertical_source_scroll): Remove unnecessary cast.
1190         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1191         cast.
1192         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1193         * tui/tui-regs.c (tui_display_registers_from)
1194         (tui_display_register): Remove unnecessary cast.
1195         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1196         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1197         (make_visible): Remove unnecessary cast.
1198         * tui/tui-winsource.c (tui_erase_source_content)
1199         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1200         unnecessary cast.
1201         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1202         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1203         * stabsread.c (read_type, read_array_type, read_range_type):
1204         Remove unnecessary cast.
1205         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1206         (parse_symbol, parse_type, upgrade_type, parse_external)
1207         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1208         unnecessary cast.
1209         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1210
1211 2019-06-16  Tom Tromey  <tom@tromey.com>
1212
1213         * tui/tui-data.c (tui_alloc_generic_win_info)
1214         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1215         checks.
1216
1217 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1218             Andrew Burgess  <andrew.burgess@embecosm.com>
1219
1220         * f-typeprint.c (f_print_type): Don't return early for not
1221         associated or not allocated types.
1222         (f_type_print_varspec_suffix): Add print_rank parameter and print
1223         ranks of array types in case they dangling.
1224         (f_type_print_base): Add print_rank parameter.
1225
1226 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1227
1228         * NEWS: Mention new MI commands.
1229         * break-catch-throw.c (enum exception_event_kind): Move to
1230         breakpoint.h.
1231         (print_mention_exception_catchpoint): Output text as a single
1232         message.
1233         (catch_exception_command_1): Rename to...
1234         (catch_exception_event): ...this, make non-static, update header
1235         command, and change some parameter types.
1236         (catch_catch_command): Update for changes to
1237         catch_exception_command_1.
1238         (catch_throw_command): Likewise.
1239         (catch_rethrow_command): Likewise.
1240         * breakpoint.c (enum exception_event_kind): Delete.
1241         * breakpoint.h (enum exception_event_kind): Moved here from
1242         break-catch-throw.c.
1243         (catch_exception_event): Declare.
1244         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1245         (mi_cmd_catch_throw): New function.
1246         (mi_cmd_catch_rethrow): New function.
1247         (mi_cmd_catch_catch): New function.
1248         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1249         'catch-catch' entries.
1250         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1251         (mi_cmd_catch_rethrow): Declare.
1252         (mi_cmd_catch_catch): Declare.
1253
1254 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1255
1256         * annotate.c (annotate_source_line): Change return type to void,
1257         update implementation to match.
1258         * annotate.h (annotate_source_line): Change return type to void,
1259         update header comment.
1260         * stack.c (print_frame_info): Don't change what frame information
1261         is printed based on whether annotations are on or not.
1262
1263 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1264
1265         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1266         (annotate_source): Make static.
1267         (annotate_source_line): Moved from source.c and renamed from
1268         identify_source_line.  Update the return type.
1269         * annotate.h (annotate_source): Delete declaration.
1270         (annotate_source_line): Declaration moved from source.h, and
1271         renamed from identify_source_line.  Return type updated.
1272         * source.c (identify_source_line): Moved to annotate.c and renamed
1273         to annotate_source_line.
1274         (info_line_command): Remove check of annotation_level.
1275         * source.h (identify_source_line): Move declaration to annotate.h
1276         and rename to annotate_source_line.
1277         * stack.c: Add 'annotate.h' include.
1278         (print_frame_info): Remove check of annotation_level before
1279         calling annotate_source_line.
1280
1281 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1282
1283         * source-cache.c (source_cache::get_plain_source_lines): Use
1284         open_source_file_with_line_charpos instead of just
1285         open_source_file, remove call to find_source_lines.
1286         (source_cache::get_source_lines): Likewise.
1287         * source.c (find_source_lines): Make static.
1288         (get_filename_and_charpos): Renamed into...
1289         (open_source_file_with_line_charpos): ..this along with changes to
1290         return a scoped_fd, and some other minor clean ups.
1291         (identify_source_line): Use open_source_file_with_line_charpos.
1292         (search_command_helper): Use open_source_file_with_line_charpos
1293         instead of just open_source_file, remove call to
1294         find_source_lines.
1295         * source.h (open_source_file_with_line_charpos): Declare new
1296         function.
1297         (find_source_lines): Delete declaration.
1298
1299 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1300
1301         * source.c (get_filename_and_charpos): Remove fullname
1302         parameter.
1303         (identify_source_line): Update call to get_filename_and_charpos.
1304
1305 2019-06-14  Tom Tromey  <tromey@adacore.com>
1306
1307         PR gdb/24502:
1308         * ui-style.h (skip_ansi_escape): Update comment.
1309         * ui-file.h (class no_terminal_escape_file): New class.
1310         * ui-file.c (no_terminal_escape_file::write)
1311         (no_terminal_escape_file::puts): New methods.
1312         * cli/cli-logging.c (handle_redirections): Use
1313         no_terminal_escape_file.
1314
1315 2019-06-14  Tom Tromey  <tromey@adacore.com>
1316
1317         * NEWS: Move convenience variable news above Python news.
1318
1319 2019-06-14  Tom Tromey  <tom@tromey.com>
1320
1321         * gnulib: Move directory to top-level.
1322         * configure.ac: Don't configure gnulib.
1323         * configure: Rebuild.
1324         * common/common-defs.h: Use new path to gnulib.
1325         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1326         (GNULIB_H): Remove.
1327         (INCGNU): Look in new gnulib location.
1328         (HFILES_NO_SRCDIR): Remove gnulib files.
1329         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1330         (generated_files): Remove GNULIB_H.
1331         ($(LIBGNU), all-lib): Remove targets.
1332         (distclean): Don't mention GNULIB_BUILDDIR.
1333         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1334
1335 2019-06-14  Tom Tromey  <tromey@adacore.com>
1336
1337         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1338         Warn if symbol file does not provide any symbols.
1339
1340 2019-06-14  Tom Tromey  <tromey@adacore.com>
1341
1342         * source.c (find_and_open_source): Respect basenames_may_differ.
1343
1344 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1345
1346         * annotate.c (annotate_breakpoints_invalid): Make use of
1347         scoped_restore_terminal_state.
1348         (annotate_frames_invalid): Likewise.
1349
1350 2019-06-14  Tom Tromey  <tromey@adacore.com>
1351
1352         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1353         allow assignment to an internalvar.
1354
1355 2019-06-14  Tom Tromey  <tromey@adacore.com>
1356
1357         * ada-lex.l: Allow "_" in attribute names.
1358
1359 2019-06-14  Tom Tromey  <tromey@adacore.com>
1360
1361         PR gdb/24653:
1362         * regcache.c (registers_changed): Don't call alloca.
1363         * top.c (execute_command): Don't call alloca.
1364
1365 2019-06-13  Pedro Alves  <palves@redhat.com>
1366
1367         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1368         'expression'.  When parsing an expression, error out if there's
1369         junk after "unlimited".
1370         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1371         (do_set_command): Adjust calls to is_unlimited_literal.
1372
1373 2019-06-13  Pedro Alves  <palves@redhat.com>
1374
1375         * compile/compile.c (make_compile_options_def_group): Add braces
1376         around array_view initializer.
1377         * thread.c (make_thread_apply_all_options_def_group)
1378         (make_thread_apply_all_options_def_group): Likewise.
1379
1380 2019-06-13  Pedro Alves  <palves@redhat.com>
1381
1382         * NEWS (New commands): Mention "maint test-options
1383         require-delimiter", "maint test-options unknown-is-error", "maint
1384         test-options unknown-is-operand" and "maint show
1385         test-options-completion-result".
1386         (New command options, command completion): New section.
1387         (Completion improvements): New section.
1388         Mention that you can abbreviate "unlimited".
1389
1390 2019-06-13  Pedro Alves  <palves@redhat.com>
1391
1392         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1393         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1394         * unittests/cli-utils-selftests.c (test_parse_flags)
1395         (test_parse_flags_qcs): Delete.
1396         (test_cli_utils): Don't call deleted functions.
1397
1398 2019-06-13  Pedro Alves  <palves@redhat.com>
1399
1400         * thread.c: Include "cli/cli-option.h".
1401         (tp_array_compar_ascending): Global.
1402         (tp_array_compar): Delete function.
1403         (tp_array_compar_ascending, tp_array_compar_descending): New
1404         functions.
1405         (ascending_option_def, qcs_flag_option_def)
1406         (thr_qcs_flags_option_defs)
1407         (make_thread_apply_all_options_def_group)
1408         (make_thread_apply_options_def_group): New.
1409         (thread_apply_all_command): Use gdb::option::process_options.
1410         (thread_apply_command_completer)
1411         (thread_apply_all_command_completer): New.
1412         (thread_apply_command): Use gdb::option::process_options.
1413         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1414         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1415         to generate help text of "thread apply".  Adjust "taas"'s help.
1416         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1417         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1418
1419 2019-06-13  Pedro Alves  <palves@redhat.com>
1420
1421         * thread.c (thread_apply_command): Check for invalid TID with
1422         isdigit instead of !isalpha.
1423
1424 2019-06-13  Pedro Alves  <palves@redhat.com>
1425
1426         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1427         (validate_flags_qcs): New.
1428         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1429         (validate_flags_qcs): Declare.
1430         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1431         (make_frame_apply_options_def_group): New.
1432         (frame_apply_command_count): Process options with
1433         gdb::option::process_options.
1434         (frame_apply_completer): New.
1435         (frame_apply_level_completer, frame_apply_all_completer)
1436         (frame_apply_completer): New.
1437         (_initialize_stack): Update help of "frame apply", "frame apply
1438         level", "frame apply all" and "faas" to mention supported options
1439         and install command completers.
1440         * stack.h (frame_apply_all_completer): Declare.
1441         * thread.c: Include "stack.h".
1442         (tfaas_command): Add "--".
1443         (_initialize_thread): Update help "tfaas" to mention supported
1444         options and install command completer.
1445
1446 2019-06-13  Pedro Alves  <palves@redhat.com>
1447
1448         * completer.c (complete_nested_command_line): New.
1449         (gdb_completion_word_break_characters_throw): Add assertion.
1450         * completer.h (complete_nested_command_line): Declare.
1451
1452 2019-06-13  Pedro Alves  <palves@redhat.com>
1453
1454         * stack.c (parse_backtrace_qualifiers): New.
1455         (backtrace_command): Use it.
1456         (backtrace_command_completer): Complete on qualifiers.
1457
1458 2019-06-13  Pedro Alves  <palves@redhat.com>
1459
1460         * frame.c: Include "cli/cli-option.h.
1461         (user_set_backtrace_options): New.
1462         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1463         Delete.
1464         (get_prev_frame): Adjust.
1465         (boolean_option_def, uinteger_option_def)
1466         (set_backtrace_option_defs): New.
1467         (_initialize_frame): Adjust and use
1468         gdb::option::add_setshow_cmds_for_options to install "set
1469         backtrace past-main" and "set backtrace past-entry".
1470         * frame.h: Include "cli/cli-option.h".
1471         (struct frame_print_options): Forward declare.
1472         (print_frame_arguments_all, print_frame_arguments_scalars)
1473         (print_frame_arguments_none): Declare.
1474         (print_entry_values): Delete declaration.
1475         (struct frame_print_options, user_frame_print_options): New.
1476         (struct set_backtrace_options): New.
1477         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1478         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1479         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1480         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1481         (list_args_or_locals): Add frame_print_options parameter.
1482         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1483         * python/py-framefilter.c (enumerate_args): Pass down
1484         USER_FRAME_PRINT_OPTIONS.
1485         * stack.c: Include "cli/cli-option.h".
1486         (print_frame_arguments_all, print_frame_arguments_scalars)
1487         (print_frame_arguments_none): Declare.
1488         (print_raw_frame_arguments, print_entry_values): Delete.
1489         (user_frame_print_options): New.
1490         (boolean_option_def, enum_option_def, frame_print_option_defs):
1491         New.
1492         (struct backtrace_cmd_options): New.
1493         (bt_flag_option_def): New.
1494         (backtrace_command_option_defs): New.
1495         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1496         (print_frame_arg, read_frame_arg, print_frame_args)
1497         (print_frame_info, print_frame): Add frame_print_options parameter
1498         and use it.
1499         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1500         (backtrace_command_1): Add frame_print_options and
1501         backtrace_cmd_options parameters and use them.
1502         (make_backtrace_options_def_group): New.
1503         (backtrace_command): Process command options with
1504         gdb::option::process_options.
1505         (backtrace_command_completer): New.
1506         (_initialize_stack): Extend "backtrace"'s help to mention
1507         supported options.  Install completer for "backtrace".
1508         Install some settings commands with add_setshow_cmds_for_options.
1509
1510 2019-06-13  Pedro Alves  <palves@redhat.com>
1511
1512         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1513         and that "set/show print raw frame-arguments" are now deprecated.
1514
1515         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1516         command.
1517         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1518         * stack.c (_initialize_stack): Install "set/show print
1519         raw-frame-arguments", and deprecate "set/show print raw
1520         frame-arguments".
1521         * valprint.c (_initialize_valprint): Deprecate "set/show print
1522         raw".
1523
1524 2019-06-13  Pedro Alves  <palves@redhat.com>
1525
1526         * compile/compile.c (struct compile_options): New.
1527         (compile_flag_option_def, compile_command_option_defs)
1528         (make_compile_options_def_group): New.
1529         (compile_file_command): Handle options with
1530         gdb::option::process_options.
1531         (compile_file_command_completer): New function.
1532         (compile_code_command): Handle options with
1533         gdb::option::process_options.
1534         (compile_code_command_completer): New function.
1535         (_initialize_compiler): Install completers for "compile code" and
1536         "compile file".  Mention available options in "compile code" and
1537         "compile code"'s help.
1538         * completer.c (advance_to_completion_word): New, factored out from
1539         ...
1540         (advance_to_expression_complete_word_point): ... this.
1541         (advance_to_filename_complete_word_point): New.
1542         * completer.h (advance_to_filename_complete_word_point): New
1543         declaration.
1544
1545 2019-06-13  Pedro Alves  <palves@redhat.com>
1546
1547         * compile/compile.c: Include "cli/cli-option.h".
1548         (compile_print_value): Scope data pointer is now a
1549         value_print_options pointer; adjust.
1550         (compile_print_command): Process options.  Scope data pointer is
1551         now a value_print_options pointer; adjust.
1552         (_initialize_compile): Update "compile print"'s help to include
1553         supported options.  Install a completer for "compile print".
1554         * cp-valprint.c (show_vtblprint, show_objectprint)
1555         (show_static_field_print): Delete.
1556         (_initialize_cp_valprint): Don't install "set print
1557         static-members", "set print vtbl", "set print object" here.
1558         * printcmd.c: Include "cli/cli-option.h" and
1559         "common/gdb_optional.h".
1560         (print_command_parse_format): Rework to fill in a
1561         value_print_options instead of a format_data.
1562         (print_value): Change parameter type from format_data pointer to
1563         value_print_options reference.  Adjust.
1564         (print_command_1): Process options.  Adjust to pass down a
1565         value_print_options.
1566         (print_command_completer): New.
1567         (_initialize_printcmd): Install print_command_completer as
1568         handle_brkchars completer for the "print" command.  Update
1569         "print"'s help to include supported options.
1570         * valprint.c: Include "cli/cli-option.h".
1571         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1572         here from cp-valprint.c.
1573         (boolean_option_def, uinteger_option_def)
1574         (value_print_option_defs, make_value_print_options_def_group):
1575         New.  Use gdb::option::add_setshow_cmds_for_options to install
1576         "set print elements", "set print null-stop", "set print repeats",
1577         "set print pretty", "set print union", "set print array", "set
1578         print address", "set print symbol", "set print array-indexes".
1579         * valprint.h: Include <string> and "cli/cli-option.h".
1580         (make_value_print_options_def_group): Declare.
1581         (print_value): Change parameter type from format_data pointer to
1582         value_print_options reference.
1583         (print_command_completer): Declare.
1584
1585 2019-06-13  Pedro Alves  <palves@redhat.com>
1586
1587         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1588         (COMMON_SFILES): Add maint-test-settings.c.
1589         * cli/cli-decode.c (boolean_enums): New global, factored out from
1590         ...
1591         (add_setshow_boolean_cmd): ... here.
1592         * cli/cli-decode.h (boolean_enums): Declare.
1593         * cli/cli-option.c: New file.
1594         * cli/cli-option.h: New file.
1595         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1596         factored out from ...
1597         (parse_cli_boolean_value(const char *)): ... this.
1598         (is_unlimited_literal): Change parameter type to pointer to
1599         pointer.  Adjust and advance ARG pointer.
1600         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1601         (parse_cli_var_enum): New, factored out from ...
1602         (do_set_command): ... this.  Adjust.
1603         * cli/cli-setshow.h (parse_cli_boolean_value)
1604         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1605         (parse_cli_var_enum): Declare.
1606         * cli/cli-utils.c: Include "cli/cli-option.h".
1607         (get_ulongest): New.
1608         * cli/cli-utils.h (get_ulongest): Declare.
1609         (check_for_argument): New overloads.
1610         * maint-test-options.c: New file.
1611
1612 2019-06-13  Pedro Alves  <palves@redhat.com>
1613
1614         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1615         parse a range if "-" is at the end of the string.
1616
1617 2019-06-13  Pedro Alves  <palves@redhat.com>
1618
1619         * cli/cli-setshow.c (parse_auto_binary_operation)
1620         (parse_cli_boolean_value): Don't allow "o".
1621
1622 2019-06-13  Pedro Alves  <palves@redhat.com>
1623
1624         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1625         * NEWS: Mention maint test-settings KIND.
1626         * maint-test-settings.c: New file.
1627
1628 2019-06-13  Pedro Alves  <palves@redhat.com>
1629
1630         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1631         completer.
1632         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1633         "set" completers.
1634
1635 2019-06-13  Pedro Alves  <palves@redhat.com>
1636
1637         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1638         after item.
1639
1640 2019-06-13  Pedro Alves  <palves@redhat.com>
1641
1642         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1643
1644 2019-06-13  Pedro Alves <palves@redhat.com>
1645
1646         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1647         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1648         call.
1649         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1650         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1651         calls.
1652         (check_for_argument): Skip spaces after argument.
1653
1654 2019-06-13  Pedro Alves  <palves@redhat.com>
1655
1656         * thread.c (thread_apply_command): Adjust TID parsing.
1657         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1658         detected before end of string.
1659         (tid_is_in_list): Error out if LIST is invalid.
1660
1661 2019-06-13  Pedro Alves  <palves@redhat.com>
1662
1663         * completer.c (complete_line_internal_1): Rewind completion word
1664         point.
1665         (completion_tracker::advance_custom_word_point_by): Change
1666         parameter type to int.
1667         * completer.h (completion_tracker::advance_custom_word_point_by):
1668         Likewise.
1669
1670 2019-06-13  Pedro Alves  <palves@redhat.com>
1671
1672         * completer.c (advance_to_completion_word): Handle delimiters.
1673
1674 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1675
1676         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1677
1678 2019-06-11  Tom Tromey  <tom@tromey.com>
1679
1680         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1681         (xmalloc_failed): Move to alloc.c.
1682         * alloc.c: New file.
1683         * Makefile.in (COMMON_SFILES): Add alloc.c.
1684
1685 2019-06-11  Tom Tromey  <tom@tromey.com>
1686
1687         * nat/linux-waitpid.c: Don't include server.h.
1688         (linux_debug): Remove.
1689         (my_waitpid): Update.
1690
1691 2019-06-11  Tom Tromey  <tromey@adacore.com>
1692
1693         * infcall.c (_initialize_infcall): Remove trailing newline from
1694         help.
1695         * user-regs.c (_initialize_user_regs): Remove trailing newline
1696         from help.
1697         * typeprint.c (_initialize_typeprint): Remove trailing newline
1698         from help.
1699         * reverse.c (_initialize_reverse): Remove trailing newlines from
1700         help.
1701         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1702         from help.
1703         * language.c (add_set_language_command): Remove trailing newline
1704         from help.
1705         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1706         help.
1707         * disasm.c (_initialize_disasm): Remove trailing newline from
1708         help.
1709         * top.c (init_main): Remove trailing newline from help.
1710         * interps.c (_initialize_interpreter): Remove trailing newline
1711         from help.
1712         * btrace.c (_initialize_btrace): Remove trailing newlines from
1713         help.
1714         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1715         from help.
1716         * python/python.c (_initialize_python): Remove trailing newline
1717         from help.
1718         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1719         help.
1720         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1721         from help.  Reformat some text.
1722         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1723         from help.
1724         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1725         newline from help.
1726
1727 2019-06-11  Tom Tromey  <tromey@adacore.com>
1728
1729         * darwin-nat.c (darwin_decode_exception_message)
1730         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1731
1732 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1733
1734         * valops.c (value_slice): Check for not allocated or not
1735         associated values.
1736
1737 2019-06-10  Tom de Vries  <tdevries@suse.de>
1738
1739         PR gdb/24618
1740         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1741         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1742         invalid.
1743
1744 2019-06-10  Tom de Vries  <tdevries@suse.de>
1745
1746         PR gdb/24611
1747         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1748         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1749
1750 2019-06-10  Tom de Vries  <tdevries@suse.de>
1751
1752         PR symtab/24545
1753         * symtab.c (struct demangled_name_entry): Add language field.
1754         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1755         static minimal symbol".  Set and use language field.
1756
1757 2019-06-10  Tom Tromey  <tromey@adacore.com>
1758
1759         * ada-lang.c (_initialize_ada_language): Update help text.
1760
1761 2019-06-10  Tom Tromey  <tromey@adacore.com>
1762
1763         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1764         with a newline.
1765         * guile/guile.c (handle_boot_error): Don't end warning with a
1766         newline.
1767         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1768         warning with a newline.
1769         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1770         newline.
1771         (s12z_frame_cache): Likewise.
1772         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1773         a newline.
1774         * solib-svr4.c (disable_probes_interface): Don't end warning with
1775         a newline.
1776         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1777         newline.
1778         * python/python.c (do_finish_initialization): Don't end warning
1779         with a newline.
1780
1781 2019-06-10  Tom Tromey  <tom@tromey.com>
1782
1783         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1784         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1785         gdbpy_enter.
1786
1787 2019-06-10  Tom Tromey  <tromey@adacore.com>
1788
1789         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1790         data.
1791         (elf_new_init): Don't call stabsread_new_init.
1792         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1793         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1794         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1795
1796 2019-06-10  Tom de Vries  <tdevries@suse.de>
1797
1798         PR symtab/16264
1799         PR symtab/24517
1800         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1801
1802 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1803
1804         * source.c (find_and_open_source): Also rewrite relative file
1805         names.
1806
1807 2019-04-26  Amos Bird  <amosbird@gmail.com>
1808
1809         * annotate.c (annotate_thread_exited): Add "thread-exited"
1810         annotation.
1811
1812 2019-06-06  Tom Tromey  <tromey@adacore.com>
1813
1814         * maint.h (class scoped_command_stats): Use
1815         DISABLE_COPY_AND_ASSIGN.
1816         <print_time>: New method.
1817         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1818         print_time.
1819         (scoped_command_stats::print_time): New method.
1820
1821 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1822
1823         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1824         instructions of lengths 6 or 8 bytes.
1825
1826 2019-06-04  Pedro Alves  <palves@redhat.com>
1827
1828         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1829
1830         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1831         * breakpoint.c (condition_completer): Likewise.
1832         * cli/cli-dump.c (scan_expression): Likewise.
1833         * common/filestuff.c (mkdir_recursive): Likewise.
1834         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1835         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1836         (gdb_abspath): Likewise.
1837         * compile/compile-cplus-types.c
1838         (compile_cplus_instance::decl_name): Likewise.
1839         * completer.c (complete_explicit_location):
1840         (signal_completer, reg_or_group_completer_1): Likewise.
1841         * cp-support.c (cp_remove_params_if_any): Likewise.
1842         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1843         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1844         * infcmd.c (strip_bg_char): Likewise.
1845         * linespec.c (copy_token_string): Likewise.
1846         * mi/mi-main.c (output_cores): Likewise.
1847         * psymtab.c (psymtab_search_name):
1848         * symfile.c (test_set_ext_lang_command): Likewise.
1849         * target.c (target_fileio_read_stralloc): Likewise.
1850         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1851         * value.c (complete_internalvar): Likewise.
1852
1853 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1854
1855         Add objfile property to gdb.Type.
1856         * NEWS: Mention Python API addition.
1857         * python/py-type.c (typy_get_objfile): New method.
1858
1859 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1860
1861         * NEWS: Mention the new set|show style [title|highlight].
1862         Mention changes to "show style", "help" and "apropos".
1863
1864 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1865
1866         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1867         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1868         instead of print_help_for_command.
1869         (print_doc_of_command): New function.
1870         (help_list): Add 'apropos -v word' suggestion.
1871         (print_help_for_command): Style the command name using title style.
1872         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1873         (_initialize_cli_cmds): Describe -v in apropos_command help.
1874
1875 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1876
1877         * cli/cli-style.h (cli_style_option): Add name in constructor,
1878         add m_name class member, add constructor with intensity,
1879         add name class function.
1880         (cli_style_option::add_setshow_commands): Remove name argument.
1881         (highlight_style, title_style): New styles.
1882         * cli/cli-style.c (do_show): New function that shows a style
1883         characteristic styling the style name with itself.
1884         (set_style_name): New function.
1885         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1886         Update all callers according to the changes in cli/cli-style.h.
1887         * utils.h (fputs_highlighted): New function.
1888         * utils.c (fputs_highlighted): Likewise.
1889
1890 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1891
1892         * NEWS: Mention new pipe command and new convenience variables.
1893
1894 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1895
1896         * cli/cli-cmds.c (pipe_command): New function.
1897         (_initialize_cli_cmds): Call add_com for pipe_command.
1898         Define | as an alias for pipe.
1899         (exit_status_set_internal_vars): New function.
1900         (shell_escape): Call exit_status_set_internal_vars.
1901         cli/cli-decode.c (find_command_name_length): Recognize | as
1902         a single character command.
1903
1904 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1905
1906         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1907         top.c (execute_command_to_ui_file): New function, mostly a copy
1908         of execute_command_to_string.
1909         (execute_command_to_string): Implement by calling
1910         execute_command_to_ui_file.
1911
1912 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1913
1914         * top.h (saved_command_line): Remove declaration.
1915         * top.c (previous_saved_command_line, previous_repeat_arguments):
1916         New variables.
1917         (saved_command_line): Make static, define together with other
1918         'repeat variables'.
1919         (dont_repeat): Clear repeat_arguments.
1920         (repeat_previous, get_saved_command_line, save_command_line):
1921         New functions.
1922         (gdb_init): Initialize saved_command_line
1923         and previous_saved_command_line.
1924         * main.c (captured_main_1): Remove saved_command_line initialization.
1925         * event-top.c (handle_line_of_input): Update to use
1926         the new 'repeat' related functions instead of direct access to
1927         saved_command_line.
1928         * command.h (repeat_previous, get_saved_command_line,
1929         save_command_line): New declarations.
1930         (dont_repeat): Add comment.
1931
1932 2019-05-30  Tom Tromey  <tromey@adacore.com>
1933
1934         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1935         Fix comment.
1936         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1937
1938 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1939
1940         PR cli/24587
1941         * completer.c (complete): Initialize variable word.
1942
1943 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1944
1945         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1946         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1947         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1948         'body' is NULL to the outter 'if', protecting the '!is_define'
1949         situation as well.
1950
1951 2019-05-29  Tom Tromey  <tromey@adacore.com>
1952
1953         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1954         (dwarf_unknown): New function.
1955         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1956         (dwarf_type_encoding_name): Use dwarf_unknown.
1957
1958 2019-05-29  Tom Tromey  <tromey@adacore.com>
1959
1960         PR c++/20020:
1961         * cp-valprint.c (cp_print_value_fields): Call
1962         cp_print_static_field inside "try".
1963
1964 2019-05-29  Tom Tromey  <tromey@adacore.com>
1965
1966         * inflow.c (struct terminal_info): Add default operator=.
1967         * configure: Rebuild.
1968         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1969         -Wdeprecated-copy-dtor, -Wredundant-move.
1970
1971 2019-05-29  Tom Tromey  <tromey@adacore.com>
1972
1973         * NEWS: Add entry.
1974         * infcmd.c (print_return_value_1): Handle finish_print
1975         option.
1976         (show_print_finish): New function.
1977         (_initialize_infcmd): Add "set/show print finish" commands.
1978         * valprint.c (user_print_options): Initialize new member.
1979         * valprint.h (struct value_print_options) <finish_print>: New
1980         member.
1981
1982 2019-05-28  Tom Tromey  <tromey@adacore.com>
1983
1984         * ada-lang.c (ada_remove_Xbn_suffix)
1985         (find_old_style_renaming_symbol)
1986         (parse_old_style_renaming): Remove.
1987         (ada_find_renaming_symbol): Don't call
1988         find_old_style_renaming_symbol.
1989         (ada_is_renaming_symbol): Rename from
1990         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1991         bool.  Now static.
1992         (ada_read_var_value): Update and simplify.
1993         * ada-exp.y (write_var_or_type): Remove old code.
1994
1995 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1996
1997         * event-top.c: Remove include comment.
1998         * inflow.c (class scoped_ignore_sigttou): Move from here...
1999         * inflow.h (class scoped_ignore_sigttou): ...to here.
2000         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2001         * top.c:  Remove include comment.
2002
2003 2019-05-27  Tom Tromey  <tom@tromey.com>
2004
2005         * NEWS: Fix typo.
2006
2007 2019-05-22  Tom Tromey  <tromey@adacore.com>
2008
2009         * target.c (target_follow_exec): Constify parameter.
2010         * target-delegates.c: Rebuild.
2011         * remote.c (remote_target::follow_exec): Constify parameter.
2012         * infrun.c (follow_exec): Constify parameter.
2013         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2014         (target_follow_exec): Likewise.
2015
2016 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2017
2018         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2019         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2020
2021 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2022
2023         * NEWS: Add debugredirect and testsuite sections.
2024
2025 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2026
2027         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2028         target descriptions using exclusively floating point register name
2029         aliases.
2030
2031 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2032
2033         PR gdb/18644:
2034         * f-lang.c (build_fortran_types): Handle the case where
2035         gdbarch_floatformat_for_type returns a nullptr.
2036
2037 2019-05-21  Tom de Vries  <tdevries@suse.de>
2038
2039         PR cli/24587
2040         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2041
2042 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2043
2044         PR gdb/18644:
2045         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2046         16-byte floats.
2047         * i386-tdep.c (i386_floatformat_for_type): Use
2048         floatformats_ia64_quad for the 16-byte floating point component
2049         within a fortran 32-byte complex number.
2050
2051 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2052
2053         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2054         delete default constructor.
2055         (find_partial_die): Update to return const struct.
2056         (partial_die_parent_scope): Move variable declaration into scope
2057         of its use and change its type to auto.
2058         (guess_partial_die_structure_name): Likewise.
2059         (partial_die_info::fixup): Likewise.
2060
2061 2019-05-17  Tom Tromey  <tromey@adacore.com>
2062
2063         * source.c (find_and_open_source): Remove cast.
2064
2065 2019-05-17  Tom Tromey  <tromey@adacore.com>
2066
2067         * annotate.c (annotate_source): Make "filename" const.
2068         * annotate.h (annotate_source): Use const.
2069
2070 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2071
2072         * disasm.c (set_disassembler_options): Send errors to stderr.
2073
2074 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2075
2076         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2077         (cli_interp_base::set_logging): Check debug_redirect.
2078         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2079         * cli/cli-logging.c (debug_redirect): Add static variable.
2080         (pop_output_files): Add default param.
2081         (handle_redirections): Print debug setting.
2082         (show_logging_command): Likewise.
2083         (_initialize_cli_logging): Add debugredirect command.
2084         * interps.c (current_interp_set_logging): Add debug_redirect
2085         parameter.
2086         * interps.h (set_logging): Add debug_redirect parameter.
2087         (current_interp_set_logging): Likewise.
2088         * mi/mi-common.h: Likewise.
2089         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2090
2091 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2092             Tom Tromey  <tromey@adacore.com>
2093
2094         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2095         directly.
2096         * cli/cli-interp.h (make_logging_output): Remove declaration.
2097         * cli/cli-logging.c (make_logging_output): Remove function.
2098         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2099         directly.
2100         * ui-file.c (tee_file::tee_file): Remove bools.
2101         (tee_file::~tee_file): Remove deletes.
2102         * ui-file.h (tee_file): Remove bools.
2103
2104 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2105
2106         * mi/mi-cmds.h (mi_cmd_complete): New function.
2107         * mi/mi-main.c (mi_cmd_complete): Likewise.
2108         * mi/mi-cmds.c: Define new MI command -complete.
2109         * NEWS: Mention new -complete command.
2110
2111 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2112
2113         * completer.h (complete): New function.
2114         * completer.c (complete): Likewise.
2115         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2116         function defined in completer.h.
2117
2118 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2119
2120         * MAINTAINERS (Write After Approval): Add myself.
2121
2122 2019-05-17  Tom de Vries  <tdevries@suse.de>
2123
2124         PR gdb/24094
2125         * dwarf2read.c (struct cu_partial_die_info): New struct.
2126         (find_partial_die): Return cu_partial_die_info.
2127         (partial_die_parent_scope, guess_partial_die_structure_name)
2128         (partial_die_info::fixup): Handle new return type of find_partial_die.
2129
2130 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2131
2132         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2133         "std::string", simplifying the algorithm.
2134
2135 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2136
2137         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2138         (stap_static_probe_ops::get_probes): Likewise.
2139
2140 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2141
2142         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2143         '-')" and "else if".
2144         (stap_parse_single_operand): Join checks for
2145         "gdbarch_stap_parse_special_token_p" and
2146         "gdbarch_stap_parse_special_token" in the same "if" statement.
2147         Invert check when verifying for operation on register
2148         displacement.
2149
2150 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2151
2152         * stap-probe.c (stap_get_opcode): Update comment.
2153         (stap_get_expected_argument_type): Likewise.
2154         (handle_stap_probe): Likewise.
2155
2156 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2157
2158         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2159         return type to 'bool'.  Adjust comment.  Use 'bool' when
2160         appropriate.
2161         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2162         * stap-probe.c (stap_parse_argument_1): Likewise.
2163         (stap_is_operator): Likewise.
2164         (stap_is_generic_prefix): Likewise.
2165         (stap_is_register_prefix): Likewise.
2166         (stap_is_register_indirection_prefix): Likewise.
2167         (stap_is_integer_prefix): Likewise.
2168         (stap_generic_check_suffix): Likewise.
2169         (stap_check_integer_suffix): Likewise.
2170         (stap_check_register_suffix): Likewise.
2171         (stap_check_register_indirection_suffix): Likewise.
2172         (stap_parse_register_operand): Likewise.
2173         (stap_parse_single_operand): Likewise.
2174         (stap_parse_argument_1): Likewise.
2175         (stap_probe::get_argument_count): Likewise.
2176         (stap_is_operator): Likewise.
2177
2178 2019-05-16  Tom Tromey  <tromey@adacore.com>
2179
2180         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2181         keyword to foreach.
2182
2183 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2184
2185         * linux-thread-db.c (try_thread_db_load_1): Change return type
2186         to bool.
2187         (try_thread_db_load): Likewise.
2188         (try_thread_db_load_from_pdir_1): Likewise.
2189         (try_thread_db_load_from_pdir): Likewise.
2190         (try_thread_db_load_from_sdir): Likewise.
2191         (try_thread_db_load_from_dir): Likewise.
2192         (thread_db_load_search): Likewise.
2193         (has_libpthread): Likewise.
2194         (thread_db_load): Likewise.
2195
2196 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2197
2198         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2199         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2200         NULL, and complain/return if that's the case.
2201
2202 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2203
2204         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2205         (advance, posn, abstract_read_memory): New functions.
2206         [struct mem_read_abstraction]: New struct.
2207         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2208
2209 2019-05-14  Tom Tromey  <tromey@adacore.com>
2210
2211         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2212         value is not lval_memory.
2213
2214 2019-05-14  Tom Tromey  <tromey@adacore.com>
2215
2216         * solib.c (info_sharedlibrary_command): Style the file name.
2217
2218 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2219
2220         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2221         (aarch64_vnv_type): Likewise.
2222         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2223         * common/tdesc.c: Likewise.
2224         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2225         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2226         * features/aarch64-fpu.xml: Add ieee half view.
2227         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2228         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2229         * gdbtypes.h (struct builtin_type): Likewise.
2230         (struct objfile_type): Likewise.
2231
2232 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2233
2234         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2235         typo.
2236         * location.h (string_to_event_location): Likewise.
2237
2238 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2239
2240         GDB 8.3 released.
2241
2242 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2243
2244         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2245         New variable declaration.
2246         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2247         New variable.
2248         (print_one_breakpoint): Use ui_out::test_flags and new global
2249         variable to compute use_fixed_output.
2250         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2251         Remove.
2252         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2253         (mi_multi_location_breakpoint_output_fixed): Remove.
2254         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2255         new variable.
2256         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2257         fix_multi_location_breakpoint_output flag if version >= 3.
2258         * ui-out.h (enum ui_out_flag)
2259         <fix_multi_location_breakpoint_output>: New enumerator.
2260
2261 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2262
2263         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2264
2265 2019-05-10  Tom Tromey  <tromey@adacore.com>
2266
2267         * ada-lang.c (catch_ada_completer): New function.
2268         (_initialize_ada_language): Use it.
2269
2270 2019-05-10  Tom Tromey  <tromey@adacore.com>
2271
2272         * thread.c (print_thread_info): Make "requested_threads" const.
2273         * gdbthread.h (print_thread_info): Make "requested_threads"
2274         const.
2275         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2276         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2277
2278 2019-05-08  Tom Tromey  <tom@tromey.com>
2279
2280         * gdbtypes.c (objfile_type_data): Change type.
2281         (objfile_type, _initialize_gdbtypes): Update.
2282
2283 2019-05-08  Tom Tromey  <tom@tromey.com>
2284
2285         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2286         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2287         (_initialize_dwarf2_frame): Update.
2288
2289 2019-05-08  Tom Tromey  <tom@tromey.com>
2290
2291         * objc-lang.c (objc_objfile_data): Change type.
2292         (find_methods): Update.
2293         (_initialize_objc_lang): Remove.
2294
2295 2019-05-08  Tom Tromey  <tom@tromey.com>
2296
2297         * stabsread.c (rs6000_builtin_type_data): Change type.
2298         (rs6000_builtin_type, _initialize_stabsread): Update.
2299
2300 2019-05-08  Tom Tromey  <tom@tromey.com>
2301
2302         * mips-tdep.c (mips_pdr_data): Remove.
2303         (_initialize_mips_tdep): Update.
2304
2305 2019-05-08  Tom Tromey  <tom@tromey.com>
2306
2307         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2308         (hppa_init_objfile_priv_data, read_unwind_info)
2309         (find_unwind_entry, _initialize_hppa_tdep): Update.
2310
2311 2019-05-08  Tom Tromey  <tom@tromey.com>
2312
2313         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2314         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2315         on obstack.
2316         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2317
2318 2019-05-08  Tom Tromey  <tom@tromey.com>
2319
2320         * mdebugread.c (basic_type_data): Change type.
2321         (basic_type, _initialize_mdebugread): Update.
2322
2323 2019-05-08  Tom Tromey  <tom@tromey.com>
2324
2325         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2326
2327 2019-05-08  Tom Tromey  <tom@tromey.com>
2328
2329         * nto-tdep.c (nto_inferior_data_reg): Change type.
2330         (nto_inferior_data): Update.
2331         (nto_inferior_data_cleanup, nto_new_inferior_data)
2332         (_initialize_nto_tdep): Remove.
2333         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2334
2335 2019-05-08  Tom Tromey  <tom@tromey.com>
2336
2337         * ada-lang.c (struct ada_inferior_data): Add initializers.
2338         (ada_inferior_data): Change type.
2339         (ada_inferior_data_cleanup): Remove.
2340         (get_ada_inferior_data, ada_inferior_exit)
2341         (struct ada_pspace_data): Add initializers, destructor.
2342         (ada_pspace_data_handle): Change type.
2343         (get_ada_pspace_data): Update.
2344         (ada_pspace_data_cleanup): Remove.
2345
2346 2019-05-08  Tom Tromey  <tom@tromey.com>
2347
2348         * coffread.c (struct coff_symfile_info): Add initializers.
2349         (coff_objfile_data_key): Move lower.  Change type.
2350         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2351         Update.
2352         (coff_free_info): Remove.
2353
2354 2019-05-08  Tom Tromey  <tom@tromey.com>
2355
2356         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2357         (fbsd_pspace_data_handle): Move lower.  Change type.
2358         (get_fbsd_pspace_data): Update.
2359         (fbsd_pspace_data_cleanup): Remove.
2360         (_initialize_fbsd_tdep): Update.
2361
2362 2019-05-08  Tom Tromey  <tom@tromey.com>
2363
2364         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2365         (get_ada_tasks_pspace_data): Update.
2366         (ada_tasks_pspace_data_cleanup): Remove.
2367         (_initialize_tasks): Update.
2368         (ada_tasks_inferior_data_handle): Change type.
2369         (get_ada_tasks_inferior_data): Update.
2370         (ada_tasks_inferior_data_cleanup): Remove.
2371         (struct ada_tasks_pspace_data): Add initializers.
2372
2373 2019-05-08  Tom Tromey  <tom@tromey.com>
2374
2375         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2376         * symfile-debug.c (debug_sym_get_probes): Change type.
2377         * stap-probe.c (handle_stap_probe):
2378         (stap_static_probe_ops::get_probes): Change type.
2379         * probe.h (class static_probe_ops) <get_probes>: Change type.
2380         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2381         (parse_probes_in_pspace): Update.
2382         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2383         Update.
2384         (any_static_probe_ops::get_probes): Change type.
2385         * elfread.c (elfread_data): New typedef.
2386         (probe_key): Change type.
2387         (elf_get_probes): Likewise.  Update.
2388         (probe_key_free): Remove.
2389         (_initialize_elfread): Update.
2390         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2391         Change type.
2392         (dtrace_process_dof_probe, dtrace_process_dof)
2393         (dtrace_static_probe_ops::get_probe): Change type.
2394
2395 2019-05-08  Tom Tromey  <tom@tromey.com>
2396
2397         * xcoffread.c (struct xcoff_symfile_info): Rename from
2398         coff_symfile_info.  Add initializers.
2399         (xcoff_objfile_data_key): Move lower.  Change type.
2400         (XCOFF_DATA): Rewrite.
2401         (xcoff_free_info): Remove.
2402         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2403         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2404         (xcoff_initial_scan): Update.
2405
2406 2019-05-08  Tom Tromey  <tom@tromey.com>
2407
2408         * solib-svr4.c (struct svr4_info): Add initializers and
2409         destructor.
2410         <probes_table>: Now an htab_up.
2411         (solib_svr4_pspace_data): Change type.
2412         (free_probes_table): Simplify.
2413         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2414         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2415         (probes_table_remove_objfile_probes, register_solib_event_probe)
2416         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2417         (_initialize_svr4_solib): Update.
2418
2419 2019-05-08  Tom Tromey  <tom@tromey.com>
2420
2421         * remote.c (remote_pspace_data): Change type.
2422         (remote_pspace_data_cleanup): Remove.
2423         (get_remote_exec_file, set_pspace_remote_exec_file)
2424         (_initialize_remote): Update.
2425
2426 2019-05-08  Tom Tromey  <tom@tromey.com>
2427
2428         * breakpoint.c (breakpoint_objfile_key): Change type.
2429         (get_breakpoint_objfile_data): Update.
2430         (free_breakpoint_objfile_data): Remove.
2431         (_initialize_breakpoint): Update.
2432
2433 2019-05-08  Tom Tromey  <tom@tromey.com>
2434
2435         * linux-tdep.c (struct linux_info): Add initializers.
2436         (linux_inferior_data): Move.  Change type.
2437         (invalidate_linux_cache_inf): Update.
2438         (linux_inferior_data_cleanup): Remove.
2439         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2440
2441 2019-05-08  Tom Tromey  <tom@tromey.com>
2442
2443         * auxv.c (auxv_inferior_data): Move.  Change type.
2444         (auxv_inferior_data_cleanup): Remove.
2445         (invalidate_auxv_cache_inf): Rewrite.
2446         (get_auxv_inferior_data, _initialize_auxv): Update.
2447
2448 2019-05-08  Tom Tromey  <tom@tromey.com>
2449
2450         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2451         (symfile_debug_objfile_data_key): Change type.
2452         (symfile_debug_installed, debug_qf_has_symbols)
2453         (debug_qf_find_last_source_symtab)
2454         (debug_qf_forget_cached_source_info)
2455         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2456         (debug_qf_print_stats, debug_qf_dump)
2457         (debug_qf_expand_symtabs_for_function)
2458         (debug_qf_expand_all_symtabs)
2459         (debug_qf_expand_symtabs_with_fullname)
2460         (debug_qf_map_matching_symbols)
2461         (debug_qf_expand_symtabs_matching)
2462         (debug_qf_find_pc_sect_compunit_symtab)
2463         (debug_qf_map_symbol_filenames)
2464         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2465         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2466         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2467         (debug_sym_read_linetable, debug_sym_relocate): Update.
2468         (symfile_debug_free_objfile): Remove.
2469         (install_symfile_debug_logging, _initialize_symfile_debug):
2470         Update.
2471
2472 2019-05-08  Tom Tromey  <tom@tromey.com>
2473
2474         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2475         allocate_on_obstack.
2476         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2477         (get_dwarf2_per_objfile): Update.
2478         (set_dwarf2_per_objfile): Remove.
2479         (dwarf2_has_info, dwarf2_get_section_info): Update.
2480         (dwarf2_free_objfile): Remove.
2481         (_initialize_dwarf2_read): Update.
2482
2483 2019-05-08  Tom Tromey  <tom@tromey.com>
2484
2485         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2486         initializers.
2487         <unsupported_script_warning_printed,
2488         script_not_found_warning_printed>: Now bool.
2489         (auto_load_pspace_data): Change type.
2490         (~auto_load_pspace_info): Rename from
2491         auto_load_pspace_data_cleanup.
2492         (get_auto_load_pspace_data, init_loaded_scripts_info)
2493         (clear_section_scripts, maybe_print_unsupported_script_warning)
2494         (maybe_print_script_not_found_warning, _initialize_auto_load):
2495         Update.
2496
2497 2019-05-08  Tom Tromey  <tom@tromey.com>
2498
2499         * objfiles.c (objfile_pspace_info): Add destructor and
2500         initializers.
2501         (objfiles_pspace_data): Change type.
2502         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2503         (get_objfile_pspace_data): Update.
2504         (objfiles_bfd_data): Change type.
2505         (get_objfile_bfd_data): Update.
2506         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2507
2508 2019-05-08  Tom Tromey  <tom@tromey.com>
2509
2510         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2511         Change type.
2512         (get_catch_syscall_inferior_data): Update.
2513         (catch_syscall_inferior_data_cleanup): Remove.
2514         (_initialize_break_catch_syscall): Update.
2515
2516 2019-05-08  Tom Tromey  <tom@tromey.com>
2517
2518         * inflow.c (struct terminal_info): Add destructor and
2519         initializers.
2520         (inflow_inferior_data): Change type.
2521         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2522         (get_inflow_inferior_data, inflow_inferior_exit)
2523         (swap_terminal_info, _initialize_inflow): Update.
2524
2525 2019-05-08  Tom Tromey  <tom@tromey.com>
2526
2527         * target-dcache.c (target_dcache_cleanup): Remove.
2528         (target_dcache_aspace_key): Change type.
2529         (target_dcache_init_p, target_dcache_invalidate)
2530         (target_dcache_get, target_dcache_get_or_init)
2531         (_initialize_target_dcache): Update.
2532         * dcache.h (struct dcache_deleter): New.
2533
2534 2019-05-08  Tom Tromey  <tom@tromey.com>
2535
2536         * symtab.c (struct symbol_cache): Add destructor and
2537         initializers.
2538         (symbol_cache_key): Move.  Change type.
2539         (make_symbol_cache, free_symbol_cache): Remove.
2540         (get_symbol_cache): Update.
2541         (symbol_cache_cleanup): Remove.
2542         (ALL_PSPACES, symbol_cache_flush)
2543         (maintenance_print_symbol_cache)
2544         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2545         Update.
2546
2547 2019-05-08  Tom Tromey  <tom@tromey.com>
2548
2549         * symtab.c (struct main_info): Add destructor and initializers.
2550         (main_progspace_key): Move.  Change type.
2551         (get_main_info): Update.
2552         (main_info_cleanup): Remove.
2553         (_initialize_symtab): Update.
2554
2555 2019-05-08  Tom Tromey  <tom@tromey.com>
2556
2557         * registry.h (DECLARE_REGISTRY): Define the _key class.
2558
2559 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2560
2561         * NEWS: Merge two 'New commands' sections.
2562
2563 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2564
2565         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2566         parameter and use Ada language definition instead.
2567         (ada_val_print_ptr): Remove unused language parameter.
2568         (ada_val_print_num): Remove language parameter and use Ada language
2569         definition instead.
2570         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2571         parameter.
2572         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2573         parameter and use Ada language definition instead.
2574         (ada_val_print_1): Update all ada_val_print_xxx calls.
2575         Remove language parameter.
2576         (ada_val_print): Update ada_val_print_1 call.
2577
2578 2019-05-08  Tom Tromey  <tromey@adacore.com>
2579
2580         * remote.c (remote_hw_watchpoint_limit)
2581         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2582         Now static.
2583
2584 2019-05-08  Tom Tromey  <tromey@adacore.com>
2585
2586         * maint.c (_initialize_maint_cmds): Move initialization code to
2587         remote.c.
2588         (watchdog, show_watchdog): Move to remote.c.
2589         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2590         "watchdog" static.
2591         (_initialize_remote): Move initialization code from maint.c.
2592         * defs.h (watchdog): Don't declare.
2593
2594 2019-05-08  Tom Tromey  <tromey@adacore.com>
2595
2596         * tui/tui-interp.c: Include main.h.
2597         * interps.c: Include main.h.
2598         * main.h (interpreter_p): Declare.
2599         * defs.h (interpreter_p): Don't declare.
2600
2601 2019-05-08  Tom Tromey  <tromey@adacore.com>
2602
2603         * dwarf2loc.c: Include dwarf2read.h.
2604         * defs.h (read_unsigned_leb128): Don't declare.
2605         * dwarf2read.h (read_unsigned_leb128): Declare.
2606
2607 2019-05-08  Tom Tromey  <tromey@adacore.com>
2608
2609         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2610         method.
2611
2612 2019-05-08  Tom Tromey  <tromey@adacore.com>
2613
2614         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2615         when no wrap column is set.
2616
2617 2019-05-08  Tom Tromey  <tromey@adacore.com>
2618
2619         * c-lang.c (c_get_string): Handle non-C-style arrays.
2620
2621 2019-05-08  Tom Tromey  <tromey@adacore.com>
2622
2623         * typeprint.c (print_offset_data::update): Print the bit offset,
2624         not the number of bits remaining.
2625
2626 2019-05-08  Tom Tromey  <tromey@adacore.com>
2627
2628         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2629         padding at end of comment.
2630
2631 2019-05-08  Tom Tromey  <tromey@adacore.com>
2632
2633         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2634         Compare main types.
2635
2636 2019-05-06  Tom Tromey  <tom@tromey.com>
2637
2638         * common/scoped_mmap.c: Include common-defs.h.
2639         * common/scoped_mmap.h: Don't include config.h.
2640
2641 2019-05-04  Tom Tromey  <tom@tromey.com>
2642
2643         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2644         (struct aarch64_call_info): Add initializers.
2645         <si>: Now a std::vector.
2646         (pass_on_stack, aarch64_push_dummy_call): Update.
2647
2648 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2649             Tom Tromey  <tom@tromey.com>
2650
2651         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2652         (ppc_threads): Now a std::vector.  Now static.
2653         (hwdebug_find_thread_points_by_tid)
2654         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2655         Update.
2656
2657 2019-05-04  Tom Tromey  <tom@tromey.com>
2658
2659         * arc-tdep.c (arc_tdesc_init): Return bool.
2660
2661 2019-05-04  Tom Tromey  <tom@tromey.com>
2662
2663         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2664         Use gdb_assert_not_reached.
2665
2666 2019-05-04  Tom Tromey  <tom@tromey.com>
2667
2668         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2669         "false".
2670
2671 2019-05-04  Tom Tromey  <tom@tromey.com>
2672
2673         * arc-tdep.c (arc_tdesc_init): Use bool.
2674
2675 2019-05-04  Tom Tromey  <tom@tromey.com>
2676
2677         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2678
2679 2019-05-04  Tom Tromey  <tom@tromey.com>
2680
2681         * cli/cli-cmds.c (valid_command_p): Return bool.
2682
2683 2019-05-04  Tom Tromey  <tom@tromey.com>
2684
2685         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2686         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2687
2688 2019-05-04  Raul Tambre  <raul@tambre.ee>
2689
2690         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2691         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2692         operator for comparison.
2693
2694 2019-05-04  Tom Tromey  <tom@tromey.com>
2695
2696         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2697         (lookup_partial_symbol, print_partial_symbols)
2698         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2699         (psymbol_compare): Update.
2700         (add_psymbol_to_bcache): Clear the entire psymbol.
2701         (maintenance_check_psymtabs): Update.
2702         * psympriv.h (struct partial_symbol): Don't derive from
2703         general_symbol_info.
2704         <obj_section, unrelocated_address, address,
2705         set_unrelocated_address>: Update.
2706         <ginfo>: New member.
2707         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2708         (debug_names::write_psymbols): Update.
2709
2710 2019-05-04  Tom de Vries  <tdevries@suse.de>
2711
2712         * contrib/cc-with-tweaks.sh: Support -n arg.
2713
2714 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2715
2716         * corelow.c (core_target::detach): Ensure frame cache and
2717         register caches are cleared.
2718         inferior.c (exit_inferior_1): Likewise.
2719
2720 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2721             Tom Tromey  <tom@tromey.com>
2722
2723         * dictionary.c (collate_pending_symbols_by_language): Remove
2724         "struct" from foreach.
2725         * symtab.c (lookup_global_symbol_from_objfile)
2726         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2727         foreach.
2728         * ser-tcp.c (net_open): Remove "struct" from foreach.
2729         * objfiles.c (objfile_relocate, objfile_rebase)
2730         (objfile_has_symbols): Remove "struct" from foreach.
2731         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2732         from foreach.
2733         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2734         foreach.
2735         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2736         "struct" from foreach.
2737         * ada-lang.c (create_excep_cond_exprs)
2738         (ada_exception_catchpoint_cond_string): Remove "struct" from
2739         foreach.
2740
2741 2019-05-03  Tom Tromey  <tromey@adacore.com>
2742
2743         * ada-exp.y (convert_char_literal): Check suffix of each
2744         enumerator.
2745
2746 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2747
2748         PR ada/21406:
2749         * ada-exp.y (yywrap): Don't define.
2750         * ada-lex.l (%option): Add noyywrap
2751         (yywrap): Remove.
2752
2753 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2754
2755         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2756         _WIN32_WINNT to the XP level, unless already defined to a higher
2757         level.
2758
2759         * unittests/parse-connection-spec-selftests.c:
2760         * ser-tcp.c:
2761         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2762         override.
2763
2764         * symfile.c (find_separate_debug_file): Remove colon from the
2765         drive spec of DOS/Windows file names of the target, so that the
2766         file name produced from DEBUGDIR and the target's directory will
2767         be valid on DOS/Windows systems.
2768
2769 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2770
2771         * rust-lang.c (val_print_struct): Handle printing structures
2772         containing strings.
2773
2774 2019-05-02  Tom Tromey  <tromey@adacore.com>
2775
2776         * valarith.c (_initialize_valarith): Remove.
2777
2778 2019-05-01  Tom Tromey  <tromey@adacore.com>
2779
2780         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2781         bitfields.
2782
2783 2019-05-01  Tom Tromey  <tromey@adacore.com>
2784
2785         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2786         for big-endian copies.
2787
2788 2019-04-30  Ali Tamur  <tamur@google.com>
2789         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2790         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2791         (read_3_bytes): New function.
2792
2793 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2794
2795         * windows-nat.c (main_thread_id): Delete.
2796         (handle_output_debug_string): Replace main_thread_id by
2797         current_event.dwThreadId.
2798         (fake_create_process): Likewise.
2799         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2800         Do not set main_thread_id.
2801         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2802         current_event.dwThreadId.
2803         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2804
2805 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2806
2807         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2808         Use current_event.dwThreadId instead of main_thread_id.
2809
2810 2019-04-30  Tom Tromey  <tromey@adacore.com>
2811
2812         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2813         (create_excep_cond_exprs): Iterate over program spaces.
2814         (ada_exception_catchpoint_cond_string): Examine all minimal
2815         symbols for exception types.
2816
2817 2019-04-30  Tom Tromey  <tromey@adacore.com>
2818
2819         PR c++/24470:
2820         * dwarf2read.c (process_structure_scope): Handle case where type
2821         has template parameters but no symbol was created.
2822
2823 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2824             Chris January  <chris.january@arm.com>
2825
2826         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2827         qualifier.
2828         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2829
2830 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2831
2832         * f-typeprint.c (f_print_type): Update rules for printing
2833         whitespace.
2834         (f_type_print_varspec_suffix): Likewise.
2835
2836 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2837             Chris January  <chris.january@arm.com>
2838
2839         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2840         function arguments.
2841
2842 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2843
2844         * f-lang.c (build_fortran_types): Change name of void type to
2845         lower case.
2846         * f-typeprint.c (f_type_print_base): Print the name of the void
2847         type, rather than a fixed string.
2848         * f-valprint.c (f_decorations): Use lower case void string.
2849
2850 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2851             Chris January  <chris.january@arm.com>
2852
2853         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2854         types for Fortran.
2855
2856 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2857             Chris January  <chris.january@arm.com>
2858             David Lecomber  <david.lecomber@arm.com>
2859
2860         * f-exp.y (BINOP_INTRINSIC): New token.
2861         (exp): New parser rule handling BINOP_INTRINSIC.
2862         (f77_keywords): Add new builtin procedures.
2863         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2864         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2865         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2866         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2867         (print_unop_subexp_f): New function.
2868         (print_binop_subexp_f): New function.
2869         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2870         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2871         (dump_subexp_body_f): Likewise.
2872         (operator_check_f): Likewise.
2873         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2874         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2875
2876 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2877
2878         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2879         UNOP_KIND.
2880         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2881         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2882         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2883         (operator_length_f): New fuction.
2884         (print_subexp_f): New function.
2885         (op_name_f): New function.
2886         (dump_subexp_body_f): New function.
2887         (operator_check_f): New function.
2888         (exp_descriptor_f): Replace standard expression handling functions
2889         with new functions.
2890         * gdb/fortran-operator.def: New file.
2891         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2892         * gdb/std-operator.def: Remove UNOP_KIND.
2893
2894 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2895
2896         * std-operator.def: Remove unbalanced, stray double quote
2897         character.
2898
2899 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2900             Chris January  <chris.january@arm.com>
2901             Daniel Everett  <daniel.everett@arm.com>
2902             Nick Forrington  <nick.forrington@arm.com>
2903             Richard Bunt  <richard.bunt@arm.com>
2904
2905         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2906         of depth when printing anonymous structs or unions.
2907         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2908         Don't print either the top-level value, or the children if the
2909         max-depth is exceeded.
2910         (ppscm_print_children): When printing the key of a map, allow one
2911         extra level of depth.
2912         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2913         print either the top-level value, or the children if the max-depth
2914         is exceeded.
2915         (print_children): When printing the key of a map, allow one extra
2916         level of depth.
2917         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2918         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2919         (user_print_options): Initialise max_depth field.
2920         (val_print_scalar_or_string_type_p): New function.
2921         (val_print): Check to see if the max depth has been reached.
2922         (val_print_check_max_depth): Define new function.
2923         (show_print_max_depth): New function.
2924         (_initialize_valprint): Add 'print max-depth' option.
2925         * valprint.h (struct value_print_options) <max_depth>: New field.
2926         (val_print_check_max_depth): Declare new function.
2927         * NEWS: Document new feature.
2928
2929 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2930
2931         * ada-lang.c (ada_language_defn): Initialise new field.
2932         * c-lang.c (c_is_string_type_p): New function.
2933         (c_language_defn): Initialise new field.
2934         (cplus_language_defn): Initialise new field.
2935         (asm_language_defn): Initialise new field.
2936         (minimal_language_defn): Initialise new field.
2937         * c-lang.h (c_is_string_type_p): Declare new function.
2938         * d-lang.c (d_language_defn): Initialise new field.
2939         * f-lang.c (f_is_string_type_p): New function.
2940         (f_language_defn): Initialise new field.
2941         * go-lang.c (go_is_string_type_p): New function.
2942         (go_language_defn): Initialise new field.
2943         * language.c (default_is_string_type_p): New function.
2944         (unknown_language_defn): Initialise new field.
2945         (auto_language_defn): Initialise new field.
2946         * language.h (struct language_defn) <la_is_string_type_p>: New
2947         member variable.
2948         (default_is_string_type_p): Declare new function.
2949         * m2-lang.c (m2_language_defn): Initialise new field.
2950         * objc-lang.c (objc_language_defn): Initialise new field.
2951         * opencl-lang.c (opencl_language_defn): Initialise new field.
2952         * p-lang.c (pascal_is_string_type_p): New function.
2953         (pascal_language_defn): Initialise new field.
2954         * rust-lang.c (rust_is_string_type_p): New function.
2955         (rust_language_defn): Initialise new field.
2956
2957 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2958
2959         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2960         New field.
2961         * ada-lang.c (ada_language_defn): Initialise new field.
2962         * c-lang.c (c_language_defn): Likewise.
2963         (cplus_language_defn): Likewise.
2964         (asm_language_defn): Likewise.
2965         (minimal_language_defn): Likewise.
2966         * d-lang.c (d_language_defn): Likewise.
2967         * f-lang.c (f_language_defn): Likewise.
2968         * go-lang.c (go_language_defn): Likewise.
2969         * language.c (unknown_language_defn): Likewise.
2970         (auto_language_defn): Likewise.
2971         * m2-lang.c (m2_language_defn): Likewise.
2972         * objc-lang.c (objc_language_defn): Likewise.
2973         * opencl-lang.c (opencl_language_defn): Likewise.
2974         * p-lang.c (pascal_language_defn): Likewise.
2975         * rust-lang.c (rust_language_defn): Likewise.
2976
2977 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2978
2979         * ada-lang.c (ada_is_character_type): Change return type to bool.
2980         (ada_is_string_type): Likewise.
2981         * ada-lang.h (ada_is_character_type): Update declaration
2982         (ada_is_string_type): Likewise.
2983
2984 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2985
2986         Support style in 'frame|thread apply'
2987
2988         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2989         * record.c (record_start, record_stop): Update callers of
2990         execute_command_to_string with false.
2991         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2992         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2993         methods.
2994         (class string_file): New constructor with term_out parameter.
2995         Override methods term_out and can_emit_style_escape.  New member
2996         term_out.
2997         (class stdio_file): Override can_emit_style_escape.
2998         (class tee_file): Override term_out and can_emit_style_escape.
2999         * utils.h (can_emit_style_escape): Remove.
3000         * utils.c (can_emit_style_escape): Likewise.
3001         Update all callers of can_emit_style_escape (SOMESTREAM) to
3002         SOMESTREAM->can_emit_style_escape.
3003         * source-cache.c (source_cache::get_source_lines): Likewise.
3004         * stack.c (frame_apply_command_count): Call execute_command_to_string
3005         passing the term_out characteristic of the current gdb_stdout.
3006         * thread.c (thr_try_catch_cmd): Likewise.
3007         * top.c (execute_command_to_string): pass term_out parameter
3008         to construct the string_file for the command output.
3009         * ui-file.c (term_cli_styling): New function (most code moved
3010         from utils.c can_emit_style_escape).
3011         (string_file::string_file, string_file::can_emit_style_escape,
3012         stdio_file::can_emit_style_escape, tee_file::term_out,
3013         tee_file::can_emit_style_escape): New functions.
3014
3015 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3016
3017         * NEWS: Mention the new set|show may-call-functions.
3018         * infcall.c (may_call_functions_p): New variable.
3019         (show_may_call_functions_p): New function.
3020         (call_function_by_hand_dummy): Throws an error if not
3021         may-call-functions.
3022         (_initialize_infcall): Call add_setshow_boolean_cmd for
3023         may-call-functions.
3024
3025 2019-04-25  Keith Seitz  <keiths@redhat.com>
3026
3027         PR c++/24367
3028         * cp-support.c (inspect_type): Don't attempt substitutions
3029         of symbol with the same name.
3030
3031 2019-04-25  Tom Tromey  <tromey@adacore.com>
3032
3033         PR gdb/24475:
3034         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3035         static.
3036
3037 2019-04-25  Tom Tromey  <tromey@adacore.com>
3038
3039         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3040         rvalue reference.
3041         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3042         (gdb_xml_parser::parse): Use std::move.
3043         * python/python-internal.h (gdbpy_convert_exception): Take a const
3044         reference.
3045         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3046         std::move.
3047         * python/py-utils.c (gdbpy_convert_exception): Take a const
3048         reference.
3049         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3050         Use std::move.
3051         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3052         Use std::move.
3053         * mi/mi-main.c (mi_print_exception): Take a const reference.
3054         * main.c (handle_command_errors): Take a const reference.
3055         * linespec.c (parse_linespec): Use std::move.
3056         * infcall.c (run_inferior_call): Use std::move.
3057         (call_function_by_hand_dummy): Use std::move.
3058         * exec.c (try_open_exec_file): Use std::move.
3059         * exceptions.h (exception_print, exception_fprintf)
3060         (exception_print_same): Update.
3061         * exceptions.c (print_exception, exception_print)
3062         (exception_fprintf, exception_print_same): Change parameters to
3063         const reference.
3064         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3065         * common/new-op.c: Use std::move.
3066         * common/common-exceptions.h (struct gdb_exception): Add move
3067         constructor.
3068         (struct gdb_exception_error, struct gdb_exception_quit, struct
3069         gdb_quit_bad_alloc): Change constructor to move constructor.
3070         (throw_exception): Change parameter to rvalue reference.
3071         * common/common-exceptions.c (throw_exception): Take rvalue
3072         reference.
3073         * cli/cli-interp.c (safe_execute_command): Use std::move.
3074         * breakpoint.c (insert_bp_location, location_to_sals): Use
3075         std::move.
3076
3077 2019-04-25  Tom Tromey  <tromey@adacore.com>
3078
3079         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3080         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3081         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3082         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3083         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3084         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3085         guile/scm-value.c: Use unpack.
3086         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3087         gdbscm_gdb_exception.
3088         (gdbscm_throw_gdb_exception): Likewise.
3089         (struct gdbscm_gdb_exception): New.
3090         (unpack): New function.
3091         (gdbscm_wrap): Use unpack.
3092
3093 2019-04-25  Tom Tromey  <tromey@adacore.com>
3094
3095         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3096         (gdb_rl_callback_handler): Use std::move.
3097         * common/common-exceptions.h (struct gdb_exception): Add move
3098         assignment operator.
3099         (throw_exception_sjlj): Change "exception" to const reference.
3100         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3101         (throw_exception_sjlj): Change "exception" to const reference.
3102
3103 2019-04-25  Tom Tromey  <tromey@adacore.com>
3104
3105         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3106         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3107         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3108         Update.
3109         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3110         Update.
3111         * mi/mi-interp.c (mi_interp::exec): Update.
3112         * linespec.c (parse_linespec): Update.
3113         * infcall.c (run_inferior_call): Update.
3114         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3115         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3116         (gdbscm_lookup_global_symbol): Update.
3117         * guile/scm-param.c (gdbscm_parameter_value): Update.
3118         * guile/scm-frame.c (gdbscm_frame_read_register)
3119         (gdbscm_frame_read_var): Update.
3120         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3121         * exec.c (try_open_exec_file): Update.
3122         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3123         (gdb_rl_callback_handler): Update.
3124         * common/common-exceptions.h (exception_none): Don't declare.
3125         * common/common-exceptions.c (exception_none): Don't define.
3126         (struct catcher) <exception>: Update.
3127         * cli/cli-interp.c (safe_execute_command): Update.
3128         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3129
3130 2019-04-25  Ali Tamur  <tamur@google.com>
3131
3132         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3133         (read_attribute_value): Likewise.
3134         (dwarf2_read_addr_index): Update comment.
3135         (read_str_index): Add DW_FORM_strx.
3136         (dwarf2_string_attr): Likewise.
3137         (dwarf2_const_value_attr): Likewise.
3138         (dump_die_shallow): Likewise.
3139         (dwarf2_fetch_constant_bytes): Likewise.
3140         (skip_form_bytes): Likewise.
3141         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3142
3143 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3144
3145         PR corefiles/11608
3146         PR corefiles/18187
3147         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3148         OFFSET.  Verify if current mapping contains an ELF header.
3149         (linux_find_memory_regions_full): Adjust call to
3150         dump_mapping_p.
3151
3152 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3153             Kang Li <kanglictf@gmail.com>
3154
3155         PR gdb/21600
3156
3157         * dwarf2-frame.c (read_initial_length): Be consistent about using
3158         unsigned representation of length.
3159         (decode_frame_entry_1): Likewise.  Check for wraparound of
3160         end pointer as well as buffer overflow.
3161
3162 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3163
3164         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3165         "vq".
3166
3167 2019-04-24  Tom Tromey  <tromey@adacore.com>
3168
3169         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3170
3171 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3172
3173         * s12z-tdep.c (s12z_unwind_pc): Delete.
3174         (s12z_unwind_sp): Delete.
3175         (s12z_gdbarch_init): Don't register deleted functions with
3176         gdbarch.
3177
3178 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3179
3180         * rl78-tdep.c (rl78_unwind_sp): Delete.
3181         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3182
3183 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3184
3185         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3186         (xstormy16_unwind_pc): Delete.
3187         (xstormy16_dummy_id): Delete.
3188         (xstormy16_gdbarch_init): Don't register deleted functions with
3189         gdbarch.
3190
3191 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3192
3193         * vax-tdep.c (vax_unwind_pc): Delete.
3194         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3195
3196 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3197
3198         * v850-tdep.c (v850_unwind_sp): Delete.
3199         (v850_unwind_pc): Delete.
3200         (v850_dummy_id): Delete.
3201         (v850_gdbarch_init): Don't register deleted functions with
3202         gdbarch.
3203
3204 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3205
3206         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3207         (tilegx_unwind_pc): Delete.
3208         (tilegx_unwind_dummy_id): Delete.
3209         (tilegx_gdbarch_init): Don't register deleted functions with
3210         gdbarch.
3211
3212 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3213
3214         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3215         (tic6x_dummy_id): Delete.
3216         (tic6x_gdbarch_init): Don't register deleted functions with
3217         gdbarch.
3218
3219 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3220
3221         * sparc-tdep.c (sparc_unwind_pc): Delete.
3222         (sparc32_gdbarch_init): Don't register deleted function with
3223         gdbarch.
3224
3225 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3226
3227         * sh-tdep.c (sh_unwind_sp): Delete.
3228         (sh_unwind_pc): Delete.
3229         (sh_dummy_id): Delete.
3230         (sh_gdbarch_init): Don't register deleted functions with
3231         gdbarch.
3232
3233 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3234
3235         * score-tdep.c (score_unwind_sp): Delete.
3236         (score_unwind_pc): Delete.
3237         (score_dummy_id): Delete.
3238         (score_gdbarch_init): Don't register deleted functions with
3239         gdbarch.
3240
3241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3242
3243         * rx-tdep.c (rx_unwind_pc): Delete.
3244         (rx_unwind_sp): Delete.
3245         (rx_dummy_id): Delete.
3246         (rx_gdbarch_init): Don't register deleted functions with
3247         gdbarch.  Update comment.
3248
3249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3250
3251         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3252         (rs6000_dummy_id): Delete.
3253         (rs6000_gdbarch_init): Don't register deleted functions with
3254         gdbarch.
3255
3256 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3257
3258         * or1k-tdep.c (or1k_dummy_id): Delete.
3259         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3260
3261 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3262
3263         * nios2-tdep.c (nios2_dummy_id): Delete.
3264         (nios2_unwind_sp): Delete.
3265         (nios2_gdbarch_init): Don't register deleted functions with
3266         gdbarch.
3267
3268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3269
3270         * nds32-tdep.c (nds32_dummy_id): Delete.
3271         (nds32_unwind_pc): Delete.
3272         (nds32_unwind_sp): Delete.
3273         (nds32_gdbarch_init): Don't register deleted functions with
3274         gdbarch.
3275
3276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3277
3278         * msp430-tdep.c (msp430_unwind_pc): Delete.
3279         (msp430_unwind_sp): Delete.
3280         (msp430_dummy_id): Delete.
3281         (msp430_gdbarch_init): Don't register deleted functions with
3282         gdbarch.
3283
3284 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3285
3286         * moxie-tdep.c (moxie_unwind_sp): Delete.
3287         (moxie_unwind_pc): Delete.
3288         (moxie_dummy_id): Delete.
3289         (moxie_gdbarch_init): Don't register deleted functions with
3290         gdbarch.
3291
3292 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3293
3294         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3295         (mn10300_unwind_pc): Delete.
3296         (mn10300_unwind_sp): Delete.
3297         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3298         mn10300_unwind_sp.
3299         (mn10300_frame_unwind_init): Don't register deleted functions with
3300         gdbarch.
3301
3302 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3303
3304         * mep-tdep.c (mep_unwind_pc): Delete.
3305         (mep_unwind_sp): Delete.
3306         (mep_dummy_id): Delete.
3307         (mep_gdbarch_init): Don't register deleted functions with
3308         gdbarch.
3309
3310 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3311
3312         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3313         (m68hc11_unwind_sp): Delete.
3314         (m68hc11_gdbarch_init): Don't register deleted functions with
3315         gdbarch.
3316
3317 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3318
3319         * m32r-tdep.c (m32r_unwind_sp): Delete.
3320         (m32r_unwind_pc): Delete.
3321         (m32r_dummy_id): Delete.
3322         (m32r_gdbarch_init): Don't register deleted functions with
3323         gdbarch.
3324
3325 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3326
3327         * m32c-tdep.c (m32c_unwind_pc): Delete.
3328         (m32c_unwind_sp): Delete.
3329         (m32c_dummy_id): Delete.
3330         (m32c_gdbarch_init): Don't register deleted functions with
3331         gdbarch.
3332
3333 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3334
3335         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3336         (lm32_unwind_pc): Delete.
3337         (lm32_dummy_id): Delete.
3338         (lm32_gdbarch_init): Don't register deleted functions with
3339         gdbarch.
3340
3341 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3342
3343         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3344         (iq2000_unwind_pc): Delete.
3345         (iq2000_dummy_id): Delete.
3346         (iq2000_gdbarch_init): Don't register deleted functions with
3347         gdbarch.
3348
3349 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3350
3351         * nds32-tdep.c (nds32_type_align): Delete.
3352         (nds32_push_dummy_call): Use type_align instead.
3353
3354 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3355
3356         * arm-tdep.c (arm_type_align): Only handle vector override case.
3357         (arm_push_dummy_call): Use type_align.
3358         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3359
3360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3361
3362         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3363         case.
3364         (pass_on_stack): Use type_align.
3365         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3366         function.
3367
3368 2019-04-23  Tom Tromey  <tromey@adacore.com>
3369
3370         * dwarf2read.c (line_header::file_name_at): Remove unused
3371         overload.
3372
3373 2019-04-23  Tom de Vries  <tdevries@suse.de>
3374
3375         PR gdb/24438
3376         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3377         invocation.
3378
3379
3380 2019-03-27  Ali Tamur  <tamur@google.com>
3381
3382         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3383         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3384         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3385         (dwarf_expr_context::get_addr_index): Likewise
3386         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3387         (symbol_needs_eval_context::get_addr_index): Likewise
3388         (disassemble_dwarf_expression): Add DW_OP_addrx
3389         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3390         (read_cutu_die_from_dwo): Update comment
3391         (skip_one_die): Add DW_FORM_addrx
3392         (read_attribute_value): Likewise
3393         (var_decode_location): Add DW_OP_addrx
3394         (dwarf2_const_value_attr): Add DW_FORM_addrx
3395         (dump_die_shallow): Likewise
3396         (dwarf2_fetch_constant_bytes): Likewise
3397         (decode_locdesc): Add DW_OP_addrx
3398         (skip_form_bytes): Add DW_FORM_addrx
3399
3400 2019-04-22  Ali Tamur  <tamur@google.com>
3401
3402         * MAINTAINERS (Write After Approval): Add self.
3403
3404 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3405
3406         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3407         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3408         (open_symbol_file_object): Likewise.
3409         (svr4_default_sos): Add info parameter.
3410         (svr4_read_so_list): Likewise.
3411         (svr4_current_sos_direct): Adjust functions calls to pass down
3412         info.
3413         (svr4_current_sos_1): Add info parameter.
3414         (svr4_current_sos): Call get_svr4_info, pass info down to
3415         svr4_current_sos_1.
3416         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3417         get_svr4_info.
3418         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3419         get_svr4_info.
3420         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3421         to get_svr4_info.
3422         (probes_table_remove_objfile_probes): Likewise.
3423         (register_solib_event_probe): Add info parameter.
3424         (solist_update_incremental): Pass info parameter down to
3425         svr4_read_so_list.
3426         (disable_probes_interface): Add info parameter.
3427         (svr4_handle_solib_event): Pass current_program_space to
3428         get_svr4_info.  Adjust disable_probes_interface cleanup.
3429         (svr4_create_probe_breakpoints): Add info parameter, pass it
3430         down to register_solib_event_probe.
3431         (svr4_create_solib_event_breakpoints): Add info parameter,
3432         pass it down to svr4_create_probe_breakpoints.
3433         (enable_break): Pass info down to
3434         svr4_create_solib_event_breakpoints.
3435         (svr4_solib_create_inferior_hook): Pass current_program_space to
3436         get_svr4_info.
3437         (svr4_clear_solib): Likewise.
3438
3439 2019-04-22  Pedro Alves  <palves@redhat.com>
3440
3441         * solib-svr4.c (svr4_free_objfile_observer): New.
3442         (probe_and_action::objfile): New field.
3443         (probes_table_htab_remove_objfile_probes)
3444         (probes_table_remove_objfile_probes): New functions.
3445         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3446         in the new probe_and_action.  Don't store the probe in 'lookup'.
3447         (svr4_create_probe_breakpoints): Pass objfile to
3448         register_solib_event_probe.
3449         (_initialize_svr4_solib): Register a free_objfile observer.
3450
3451 2019-04-19  Tom Tromey  <tom@tromey.com>
3452
3453         * common/queue.h: Remove.
3454
3455 2019-04-19  Tom Tromey  <tom@tromey.com>
3456
3457         * event-loop.c: Don't include "common/queue.h".
3458
3459 2019-04-19  Tom Tromey  <tom@tromey.com>
3460
3461         * remote.c (remote_target): Use delete.
3462         * remote-notif.h: Include <list>, not "common/queue.h".
3463         (notif_client_p): Remove typedef.
3464         (remote_notif_state): Add constructor, destructor, initializer.
3465         <notif_queue>: Now a std::list.
3466         (remote_notif_state_xfree): Don't declare.
3467         * remote-notif.c (remote_notif_process, handle_notification)
3468         (remote_notif_state_allocate): Update.
3469         (~remote_notif_state): Rename from remote_notif_state_xfree.
3470
3471 2019-04-19  Tom Tromey  <tom@tromey.com>
3472
3473         * symfile.c (reread_symbols): Update.
3474         * objfiles.c (objfile_register_static_link)
3475         (objfile_lookup_static_link): Update
3476         (~objfile) Don't delete static_links.
3477         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3478
3479 2019-04-19  Tom Tromey  <tom@tromey.com>
3480
3481         * type-stack.h (struct type_stack) <insert>: Constify string.
3482         * type-stack.c (type_stack::insert): Constify string.
3483         * gdbtypes.h (lookup_template_type): Update.
3484         (address_space_name_to_int): Update.
3485         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3486         const.
3487         (lookup_template_type): Make name const.
3488         * c-exp.y: Update rules.
3489         (lex_one_token, classify_name, classify_inner_name)
3490         (c_print_token): Update.
3491         * p-exp.y: Update rules.
3492         (yylex): Update.
3493         * f-exp.y: Update rules.
3494         (yylex): Update.
3495         * d-exp.y: Update rules.
3496         (lex_one_token, classify_name, classify_inner_name): Update.
3497         * parse.c (write_dollar_variable, copy_name): Return std::string.
3498         * parser-defs.h (copy_name): Change return type.
3499         * m2-exp.y: Update rules.
3500         (yylex): Update.
3501         * go-exp.y (lex_one_token): Update.
3502         Update rules.
3503         (classify_unsafe_function, classify_packaged_name)
3504         (classify_name, yylex): Update.
3505
3506 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3507
3508         * configure.ac: add --enable-source-highlight switch.
3509         * configure: Regenerate.
3510         * top.c (print_gdb_version): plumb --enable-source-highlight
3511         status to "show configuration".
3512
3513 2019-04-19  Tom Tromey  <tromey@adacore.com>
3514
3515         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3516         Check ADA_TYPE_P.
3517         (empty_record, ada_template_to_fixed_record_type_1)
3518         (template_to_static_fixed_type)
3519         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3520         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3521         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3522         macros.
3523
3524 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3525
3526         PR symtab/24423:
3527         * source.c (print_source_lines_base): Advance "iter" when a
3528         control character is seen.
3529
3530 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3531
3532         * inferior.h (struct infcall_suspend_state_deleter):
3533         Catch exception in destructor to avoid crash.
3534
3535 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3536
3537         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3538         close to the add_com "shell".
3539
3540 2019-04-18  Tom Tromey  <tromey@adacore.com>
3541
3542         * process-stratum-target.h (class process_stratum_target)
3543         <stratum>: Add "final".
3544
3545 2019-04-17  Tom Tromey  <tromey@adacore.com>
3546
3547         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3548         against nullptr before use.
3549
3550 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3551
3552         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3553
3554 2019-04-17  Jim Wilson  <jimw@sifive.com>
3555             Andrew Burgess  <andrew.burgess@embecosm.com>
3556
3557         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3558         code read might fail, assume 4-byte breakpoint in that case.
3559
3560 2019-04-15  Leszek Swirski  <leszeks@google.com>
3561
3562         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3563         rather than a hand-rolled POD check when checking for forced MEMORY
3564         classification.
3565
3566 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3567
3568         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3569         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3570         function.
3571         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3572         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3573         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3574         declaration.
3575
3576 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3577
3578         * aarch64-linux-nat.c
3579         (aarch64_linux_nat_target::thread_architecture): Add override.
3580         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3581         each VQ.
3582
3583 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3584
3585         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3586
3587 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3588
3589         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3590         target types of size 96-bits, add some additional comments, and
3591         check that the builtin type we found was the correct size.
3592
3593 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3594
3595         * utils.c (prompt_for_continue): Don't restore the styling at the
3596         end, as applied_style has the wrong value.  This fixes styling in
3597         long lists of file names that are interrupted by the "Continue?"
3598         prompt.
3599
3600 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3601
3602         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3603         * c-lang.c (c_language_defn): Likewise.
3604         (cplus_language_defn): Likewise.
3605         (asm_language_defn): Likewise.
3606         (minimal_language_defn): Likewise.
3607         * d-lang.c (d_language_defn): Likewise.
3608         * f-lang.c (f_language_defn): Likewise.
3609         * go-lang.c (go_language_defn): Likewise.
3610         * language.c (unknown_language_defn): Likewise.
3611         (auto_language_defn): Likewise.
3612         * language.h (struct language_defn): Remove la_magic field.
3613         (LANG_MAGIC): Delete.
3614         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3615         * objc-lang.c (objc_language_defn): Likewise.
3616         * opencl-lang.c (opencl_language_defn): Likewise.
3617         * p-lang.c (pascal_language_defn): Likewise.
3618         * rust-lang.c (rust_language_defn): Likewise.
3619
3620 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3621
3622         * riscv-tdep.c (riscv_type_align): New function.
3623         (riscv_type_alignment): Delete.
3624         (riscv_arg_location): Use 'type_align'.
3625         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3626
3627 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3628
3629         * gdbtypes.c (type_align): A struct with no non-static fields also
3630         has alignment of 1.
3631
3632 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3633
3634         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3635         component to 0.
3636         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3637         member.
3638         (riscv_struct_info::analyse): New implementation using new
3639         analyse_inner member function.
3640         (riscv_struct_info::field_offset): New member function.
3641         (riscv_struct_info::m_offsets): New member variable.
3642         (riscv_struct_info::analyse_inner): New private member function,
3643         takes the old implementation of riscv_struct_info::analyse but
3644         extended to track field offsets.
3645         (riscv_call_arg_struct): Update the struct folding special cases
3646         to handle cases where empty C++ structs, which are non-zero
3647         length, are found.
3648         (riscv_arg_location): Initialise the length of each location, a
3649         non-zero length now indicates the location is in use.
3650         (riscv_push_dummy_call): Allow for the first location having a
3651         non-zero offset when setting up arguments.
3652         (riscv_return_value): Likewise, but for return values.
3653
3654 2019-04-11  Tom Tromey  <tromey@adacore.com>
3655
3656         * utils.c (internal_vproblem): Make "msg" const.
3657
3658 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3659
3660         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3661         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3662         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3663         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3664
3665 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3666
3667         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3668         function.
3669         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3670         of amd64_collect_native_gregset.
3671         (amd64_linux_nat_target::store_registers): Likewise.
3672
3673 2019-04-10  Tom Tromey  <tom@tromey.com>
3674
3675         * symtab.c (lookup_global_symbol_from_objfile)
3676         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3677         * objfiles.h (class separate_debug_iterator): New.
3678         (class separate_debug_range): New.
3679         (struct objfile) <separate_debug_objfiles>: New method.
3680         (objfile_separate_debug_iterate): Don't declare.
3681         * objfiles.c (separate_debug_iterator::operator++): Rename from
3682         objfile_separate_debug_iterate.
3683         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3684         iterator.
3685         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3686         iterator.
3687
3688 2019-04-10  Tom Tromey  <tom@tromey.com>
3689
3690         * symfile.c (reread_symbols): Remove old comment.
3691         * objfiles.c (free_all_objfiles): Fix a typo.
3692
3693 2019-04-10  Tom Tromey  <tom@tromey.com>
3694
3695         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3696         * minsyms.c (lookup_minimal_symbol): Use foreach.
3697         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3698         (lookup_minimal_symbol_solib_trampoline): Likewise.
3699         * symfile.c (reread_symbols): Use foreach.
3700
3701 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3702             Tom Tromey  <tromey@adacore.com>
3703
3704         PR rust/24414:
3705         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3706         (rust_lex_int_test): Change "value" to be LONGEST.
3707         (rust_lex_tests): Add test for long integer literal.
3708
3709 2019-04-09  Tom Tromey  <tromey@adacore.com>
3710
3711         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3712         to bool.
3713         (extended_remote_target::attach): Update.
3714         (remote_target::remote_notice_new_inferior): Update.
3715         (remote_target::add_current_inferior_and_thread): Update.
3716         * inferior.c (exit_inferior_1): Use "false".
3717         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3718
3719 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3720
3721         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3722         the "start" command.
3723
3724 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3725
3726         * python/py-inferior.c (infpy_thread_from_thread_handle):
3727         Adjust comments to reflect renaming of thread_from_thread_handle
3728         to thread_from_handle.  Adjust keywords.  Fix type error message.
3729         (inferior_object_methods): Add thread_from_handle.  Retain
3730         thread_from_thread_handle, but mark it as deprecated.
3731
3732 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3733
3734         * gdbthread.h (find_thread_by_handle): Revise declaration.
3735         * thread.c (find_thread_by_handle): Likewise.  Adjust
3736         implementation too.
3737         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3738         support for buffer objects as handles.
3739
3740 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3741
3742         * python/py-infthread.c (thpy_thread_handle): New function.
3743         (thread_object_methods): Register thpy_thread_handle.
3744
3745 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3746
3747         * gdbthread.h (thread_to_thread_handle): Declare.
3748         * thread.c (gdbtypes.h): Include.
3749         (thread_to_thread_handle): New function.
3750
3751         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3752         (target_thread_info_to_thread_handle): Declare.
3753         * target.c (target_thread_info_to_thread_handle): New function.
3754         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3755         * target-delegates.c: Regenerate.
3756
3757         * linux-thread-db.c (class thread_db_target): Add method
3758         thread_info_to_thread_handle.
3759         (thread_db_target::thread_info_to_thread_handle): Define.
3760         * remote.c (class remote_target): Add new method
3761         thread_info_to_thread_handle.
3762         (remote_target::thread_info_to_thread_handle): Define.
3763
3764 2019-04-08  Pedro Alves  <palves@redhat.com>
3765
3766         * common/common-exceptions.c (throw_exception): Don't create
3767         named object to throw; throw directly.
3768         (throw_it): Likewise.  Don't initialize gdb_exception::message
3769         here, with new; pass FMT and AP to the ctor instead.
3770         * common/common-exceptions.h: Include <string>.
3771         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3772         const char *, va_list)): New ctor.  Use std::make_shared.
3773         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3774         errors)): Delete.
3775         (gdb_exception_error::gdb_exception_error(enum errors, const char
3776         *, va_list)): New.
3777         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3778         Add assertion.
3779         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3780         errors)): Delete.
3781         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3782         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3783         Add assertion.
3784
3785 2019-04-08  Tom Tromey  <tom@tromey.com>
3786
3787         * valops.c (value_rtti_indirect_type): Replace throw_exception
3788         with throw.
3789         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3790         with throw.
3791         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3792         throw.
3793         * target.c (target_translate_tls_address): Replace throw_exception
3794         with throw.
3795         * stack.c (frame_apply_command_count): Replace throw_exception
3796         with throw.
3797         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3798         throw.
3799         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3800         with throw.
3801         * rs6000-tdep.c (rs6000_frame_cache)
3802         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3803         * remote.c: Replace throw_exception with throw.
3804         * record-full.c (record_full_message, record_full_wait_1)
3805         (record_full_restore): Replace throw_exception with throw.
3806         * record-btrace.c:
3807         (get_thread_current_frame_id, record_btrace_start_replaying)
3808         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3809         (cmd_record_btrace_start): Replace throw_exception with throw.
3810         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3811         throw.
3812         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3813         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3814         * linespec.c:
3815         (find_linespec_symbols): Replace throw_exception with throw.
3816         * infrun.c (displaced_step_prepare, resume): Replace
3817         throw_exception with throw.
3818         * infcmd.c (post_create_inferior): Replace throw_exception with
3819         throw.
3820         * inf-loop.c (inferior_event_handler): Replace throw_exception
3821         with throw.
3822         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3823         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3824         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3825         (get_prev_frame_always, get_frame_pc_if_available)
3826         (get_frame_address_in_block_if_available, get_frame_language):
3827         Replace throw_exception with throw.
3828         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3829         throw_exception with throw.
3830         * eval.c (fetch_subexp_value, evaluate_var_value)
3831         (evaluate_funcall, evaluate_subexp_standard): Replace
3832         throw_exception with throw.
3833         * dwarf2loc.c (call_site_find_chain)
3834         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3835         Replace throw_exception with throw.
3836         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3837         with throw.
3838         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3839         throw.
3840         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3841         * completer.c (complete_line_internal): Replace throw_exception
3842         with throw.
3843         * compile/compile-object-run.c (compile_object_run): Replace
3844         throw_exception with throw.
3845         * cli/cli-script.c (process_next_line): Replace throw_exception
3846         with throw.
3847         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3848         (btrace_enable, btrace_maint_update_pt_packets): Replace
3849         throw_exception with throw.
3850         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3851         throw_exception with throw.
3852         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3853         throw_exception with throw.
3854         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3855         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3856         * aarch64-tdep.c (aarch64_make_prologue_cache)
3857         (aarch64_make_stub_cache): Replace throw_exception with throw.
3858
3859 2019-04-08  Tom Tromey  <tom@tromey.com>
3860
3861         * common/common-exceptions.c (throw_exception): Rename from
3862         throw_exception_cxx.  Remove old copy.  Make argument const.
3863         (throw_it): Create and throw exception objects directly.
3864         * common/common-exceptions.h (throw_exception): Make argument
3865         const.
3866         (struct gdb_exception_error): Add constructor.
3867         (struct gdb_exception_quit): Add constructor.
3868
3869 2019-04-08  Tom Tromey  <tom@tromey.com>
3870
3871         * common/common-exceptions.h (exception_rethrow): Don't declare.
3872         (TRY_SJLJ): Update comment.
3873         (TRY, CATCH, END_CATCH): Remove.
3874         * common/common-exceptions.c (exception_rethrow): Remove.
3875
3876 2019-04-08  Tom Tromey  <tom@tromey.com>
3877
3878         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3879         Remove.
3880         (gdb_exception_error): Rename from
3881         gdb_exception_RETURN_MASK_ERROR.
3882         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3883         (gdb_quit_bad_alloc): Update.
3884         * aarch64-tdep.c: Update.
3885         * ada-lang.c: Update.
3886         * ada-typeprint.c: Update.
3887         * ada-valprint.c: Update.
3888         * amd64-tdep.c: Update.
3889         * arch-utils.c: Update.
3890         * break-catch-throw.c: Update.
3891         * breakpoint.c: Update.
3892         * btrace.c: Update.
3893         * c-varobj.c: Update.
3894         * cli/cli-cmds.c: Update.
3895         * cli/cli-interp.c: Update.
3896         * cli/cli-script.c: Update.
3897         * common/common-exceptions.c: Update.
3898         * common/new-op.c: Update.
3899         * common/selftest.c: Update.
3900         * compile/compile-c-symbols.c: Update.
3901         * compile/compile-cplus-symbols.c: Update.
3902         * compile/compile-object-load.c: Update.
3903         * compile/compile-object-run.c: Update.
3904         * completer.c: Update.
3905         * corelow.c: Update.
3906         * cp-abi.c: Update.
3907         * cp-support.c: Update.
3908         * cp-valprint.c: Update.
3909         * darwin-nat.c: Update.
3910         * disasm-selftests.c: Update.
3911         * dtrace-probe.c: Update.
3912         * dwarf-index-cache.c: Update.
3913         * dwarf-index-write.c: Update.
3914         * dwarf2-frame-tailcall.c: Update.
3915         * dwarf2-frame.c: Update.
3916         * dwarf2loc.c: Update.
3917         * dwarf2read.c: Update.
3918         * eval.c: Update.
3919         * event-loop.c: Update.
3920         * event-top.c: Update.
3921         * exec.c: Update.
3922         * f-valprint.c: Update.
3923         * fbsd-tdep.c: Update.
3924         * frame-unwind.c: Update.
3925         * frame.c: Update.
3926         * gdbtypes.c: Update.
3927         * gnu-v3-abi.c: Update.
3928         * guile/guile-internal.h: Update.
3929         * guile/scm-block.c: Update.
3930         * guile/scm-breakpoint.c: Update.
3931         * guile/scm-cmd.c: Update.
3932         * guile/scm-disasm.c: Update.
3933         * guile/scm-frame.c: Update.
3934         * guile/scm-lazy-string.c: Update.
3935         * guile/scm-math.c: Update.
3936         * guile/scm-param.c: Update.
3937         * guile/scm-ports.c: Update.
3938         * guile/scm-pretty-print.c: Update.
3939         * guile/scm-symbol.c: Update.
3940         * guile/scm-symtab.c: Update.
3941         * guile/scm-type.c: Update.
3942         * guile/scm-value.c: Update.
3943         * i386-linux-tdep.c: Update.
3944         * i386-tdep.c: Update.
3945         * inf-loop.c: Update.
3946         * infcall.c: Update.
3947         * infcmd.c: Update.
3948         * infrun.c: Update.
3949         * jit.c: Update.
3950         * language.c: Update.
3951         * linespec.c: Update.
3952         * linux-fork.c: Update.
3953         * linux-nat.c: Update.
3954         * linux-tdep.c: Update.
3955         * linux-thread-db.c: Update.
3956         * main.c: Update.
3957         * mi/mi-cmd-break.c: Update.
3958         * mi/mi-cmd-stack.c: Update.
3959         * mi/mi-interp.c: Update.
3960         * mi/mi-main.c: Update.
3961         * objc-lang.c: Update.
3962         * p-valprint.c: Update.
3963         * parse.c: Update.
3964         * ppc-linux-tdep.c: Update.
3965         * printcmd.c: Update.
3966         * python/py-arch.c: Update.
3967         * python/py-breakpoint.c: Update.
3968         * python/py-cmd.c: Update.
3969         * python/py-finishbreakpoint.c: Update.
3970         * python/py-frame.c: Update.
3971         * python/py-framefilter.c: Update.
3972         * python/py-gdb-readline.c: Update.
3973         * python/py-inferior.c: Update.
3974         * python/py-infthread.c: Update.
3975         * python/py-lazy-string.c: Update.
3976         * python/py-linetable.c: Update.
3977         * python/py-objfile.c: Update.
3978         * python/py-param.c: Update.
3979         * python/py-prettyprint.c: Update.
3980         * python/py-progspace.c: Update.
3981         * python/py-record-btrace.c: Update.
3982         * python/py-record.c: Update.
3983         * python/py-symbol.c: Update.
3984         * python/py-type.c: Update.
3985         * python/py-unwind.c: Update.
3986         * python/py-utils.c: Update.
3987         * python/py-value.c: Update.
3988         * python/python.c: Update.
3989         * record-btrace.c: Update.
3990         * record-full.c: Update.
3991         * remote-fileio.c: Update.
3992         * remote.c: Update.
3993         * riscv-tdep.c: Update.
3994         * rs6000-aix-tdep.c: Update.
3995         * rs6000-tdep.c: Update.
3996         * rust-exp.y: Update.
3997         * rust-lang.c: Update.
3998         * s390-tdep.c: Update.
3999         * selftest-arch.c: Update.
4000         * solib-dsbt.c: Update.
4001         * solib-frv.c: Update.
4002         * solib-spu.c: Update.
4003         * solib-svr4.c: Update.
4004         * solib.c: Update.
4005         * sparc64-linux-tdep.c: Update.
4006         * stack.c: Update.
4007         * symfile-mem.c: Update.
4008         * symmisc.c: Update.
4009         * target.c: Update.
4010         * thread.c: Update.
4011         * top.c: Update.
4012         * tracefile-tfile.c: Update.
4013         * tui/tui.c: Update.
4014         * typeprint.c: Update.
4015         * unittests/cli-utils-selftests.c: Update.
4016         * unittests/parse-connection-spec-selftests.c: Update.
4017         * valops.c: Update.
4018         * valprint.c: Update.
4019         * value.c: Update.
4020         * varobj.c: Update.
4021         * windows-nat.c: Update.
4022         * x86-linux-nat.c: Update.
4023         * xml-support.c: Update.
4024
4025 2019-04-08  Tom Tromey  <tom@tromey.com>
4026
4027         * xml-support.c: Use C++ exception handling.
4028         * x86-linux-nat.c: Use C++ exception handling.
4029         * windows-nat.c: Use C++ exception handling.
4030         * varobj.c: Use C++ exception handling.
4031         * value.c: Use C++ exception handling.
4032         * valprint.c: Use C++ exception handling.
4033         * valops.c: Use C++ exception handling.
4034         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4035         handling.
4036         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4037         * typeprint.c: Use C++ exception handling.
4038         * tui/tui.c: Use C++ exception handling.
4039         * tracefile-tfile.c: Use C++ exception handling.
4040         * top.c: Use C++ exception handling.
4041         * thread.c: Use C++ exception handling.
4042         * target.c: Use C++ exception handling.
4043         * symmisc.c: Use C++ exception handling.
4044         * symfile-mem.c: Use C++ exception handling.
4045         * stack.c: Use C++ exception handling.
4046         * sparc64-linux-tdep.c: Use C++ exception handling.
4047         * solib.c: Use C++ exception handling.
4048         * solib-svr4.c: Use C++ exception handling.
4049         * solib-spu.c: Use C++ exception handling.
4050         * solib-frv.c: Use C++ exception handling.
4051         * solib-dsbt.c: Use C++ exception handling.
4052         * selftest-arch.c: Use C++ exception handling.
4053         * s390-tdep.c: Use C++ exception handling.
4054         * rust-lang.c: Use C++ exception handling.
4055         * rust-exp.y: Use C++ exception handling.
4056         * rs6000-tdep.c: Use C++ exception handling.
4057         * rs6000-aix-tdep.c: Use C++ exception handling.
4058         * riscv-tdep.c: Use C++ exception handling.
4059         * remote.c: Use C++ exception handling.
4060         * remote-fileio.c: Use C++ exception handling.
4061         * record-full.c: Use C++ exception handling.
4062         * record-btrace.c: Use C++ exception handling.
4063         * python/python.c: Use C++ exception handling.
4064         * python/py-value.c: Use C++ exception handling.
4065         * python/py-utils.c: Use C++ exception handling.
4066         * python/py-unwind.c: Use C++ exception handling.
4067         * python/py-type.c: Use C++ exception handling.
4068         * python/py-symbol.c: Use C++ exception handling.
4069         * python/py-record.c: Use C++ exception handling.
4070         * python/py-record-btrace.c: Use C++ exception handling.
4071         * python/py-progspace.c: Use C++ exception handling.
4072         * python/py-prettyprint.c: Use C++ exception handling.
4073         * python/py-param.c: Use C++ exception handling.
4074         * python/py-objfile.c: Use C++ exception handling.
4075         * python/py-linetable.c: Use C++ exception handling.
4076         * python/py-lazy-string.c: Use C++ exception handling.
4077         * python/py-infthread.c: Use C++ exception handling.
4078         * python/py-inferior.c: Use C++ exception handling.
4079         * python/py-gdb-readline.c: Use C++ exception handling.
4080         * python/py-framefilter.c: Use C++ exception handling.
4081         * python/py-frame.c: Use C++ exception handling.
4082         * python/py-finishbreakpoint.c: Use C++ exception handling.
4083         * python/py-cmd.c: Use C++ exception handling.
4084         * python/py-breakpoint.c: Use C++ exception handling.
4085         * python/py-arch.c: Use C++ exception handling.
4086         * printcmd.c: Use C++ exception handling.
4087         * ppc-linux-tdep.c: Use C++ exception handling.
4088         * parse.c: Use C++ exception handling.
4089         * p-valprint.c: Use C++ exception handling.
4090         * objc-lang.c: Use C++ exception handling.
4091         * mi/mi-main.c: Use C++ exception handling.
4092         * mi/mi-interp.c: Use C++ exception handling.
4093         * mi/mi-cmd-stack.c: Use C++ exception handling.
4094         * mi/mi-cmd-break.c: Use C++ exception handling.
4095         * main.c: Use C++ exception handling.
4096         * linux-thread-db.c: Use C++ exception handling.
4097         * linux-tdep.c: Use C++ exception handling.
4098         * linux-nat.c: Use C++ exception handling.
4099         * linux-fork.c: Use C++ exception handling.
4100         * linespec.c: Use C++ exception handling.
4101         * language.c: Use C++ exception handling.
4102         * jit.c: Use C++ exception handling.
4103         * infrun.c: Use C++ exception handling.
4104         * infcmd.c: Use C++ exception handling.
4105         * infcall.c: Use C++ exception handling.
4106         * inf-loop.c: Use C++ exception handling.
4107         * i386-tdep.c: Use C++ exception handling.
4108         * i386-linux-tdep.c: Use C++ exception handling.
4109         * guile/scm-value.c: Use C++ exception handling.
4110         * guile/scm-type.c: Use C++ exception handling.
4111         * guile/scm-symtab.c: Use C++ exception handling.
4112         * guile/scm-symbol.c: Use C++ exception handling.
4113         * guile/scm-pretty-print.c: Use C++ exception handling.
4114         * guile/scm-ports.c: Use C++ exception handling.
4115         * guile/scm-param.c: Use C++ exception handling.
4116         * guile/scm-math.c: Use C++ exception handling.
4117         * guile/scm-lazy-string.c: Use C++ exception handling.
4118         * guile/scm-frame.c: Use C++ exception handling.
4119         * guile/scm-disasm.c: Use C++ exception handling.
4120         * guile/scm-cmd.c: Use C++ exception handling.
4121         * guile/scm-breakpoint.c: Use C++ exception handling.
4122         * guile/scm-block.c: Use C++ exception handling.
4123         * guile/guile-internal.h: Use C++ exception handling.
4124         * gnu-v3-abi.c: Use C++ exception handling.
4125         * gdbtypes.c: Use C++ exception handling.
4126         * frame.c: Use C++ exception handling.
4127         * frame-unwind.c: Use C++ exception handling.
4128         * fbsd-tdep.c: Use C++ exception handling.
4129         * f-valprint.c: Use C++ exception handling.
4130         * exec.c: Use C++ exception handling.
4131         * event-top.c: Use C++ exception handling.
4132         * event-loop.c: Use C++ exception handling.
4133         * eval.c: Use C++ exception handling.
4134         * dwarf2read.c: Use C++ exception handling.
4135         * dwarf2loc.c: Use C++ exception handling.
4136         * dwarf2-frame.c: Use C++ exception handling.
4137         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4138         * dwarf-index-write.c: Use C++ exception handling.
4139         * dwarf-index-cache.c: Use C++ exception handling.
4140         * dtrace-probe.c: Use C++ exception handling.
4141         * disasm-selftests.c: Use C++ exception handling.
4142         * darwin-nat.c: Use C++ exception handling.
4143         * cp-valprint.c: Use C++ exception handling.
4144         * cp-support.c: Use C++ exception handling.
4145         * cp-abi.c: Use C++ exception handling.
4146         * corelow.c: Use C++ exception handling.
4147         * completer.c: Use C++ exception handling.
4148         * compile/compile-object-run.c: Use C++ exception handling.
4149         * compile/compile-object-load.c: Use C++ exception handling.
4150         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4151         * compile/compile-c-symbols.c: Use C++ exception handling.
4152         * common/selftest.c: Use C++ exception handling.
4153         * common/new-op.c: Use C++ exception handling.
4154         * cli/cli-script.c: Use C++ exception handling.
4155         * cli/cli-interp.c: Use C++ exception handling.
4156         * cli/cli-cmds.c: Use C++ exception handling.
4157         * c-varobj.c: Use C++ exception handling.
4158         * btrace.c: Use C++ exception handling.
4159         * breakpoint.c: Use C++ exception handling.
4160         * break-catch-throw.c: Use C++ exception handling.
4161         * arch-utils.c: Use C++ exception handling.
4162         * amd64-tdep.c: Use C++ exception handling.
4163         * ada-valprint.c: Use C++ exception handling.
4164         * ada-typeprint.c: Use C++ exception handling.
4165         * ada-lang.c: Use C++ exception handling.
4166         * aarch64-tdep.c: Use C++ exception handling.
4167
4168 2019-04-08  Tom Tromey  <tom@tromey.com>
4169
4170         * xml-support.c (gdb_xml_parser::parse): Update.
4171         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4172         * value.c (show_convenience): Update.
4173         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4174         (test_parse_flags_qcs): Update.
4175         * thread.c (thr_try_catch_cmd): Update.
4176         * target.c (target_translate_tls_address): Update.
4177         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4178         (info_frame_command_core, frame_apply_command_count): Update.
4179         * rust-exp.y (rust_lex_exception_test): Update.
4180         * riscv-tdep.c (riscv_print_one_register_info): Update.
4181         * remote.c (remote_target::enable_btrace): Update.
4182         * record-btrace.c (record_btrace_enable_warn): Update.
4183         * python/py-utils.c (gdbpy_convert_exception): Update.
4184         * printcmd.c (do_one_display, print_variable_and_value): Update.
4185         * mi/mi-main.c (mi_print_exception): Update.
4186         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4187         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4188         * linux-nat.c (linux_nat_target::attach): Update.
4189         * linux-fork.c (class scoped_switch_fork_info): Update.
4190         * infrun.c (displaced_step_prepare): Update.
4191         * infcall.c (call_function_by_hand_dummy): Update.
4192         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4193         * gnu-v3-abi.c (print_one_vtable): Update.
4194         * frame.c (get_prev_frame_always): Update.
4195         * f-valprint.c (info_common_command_for_block): Update.
4196         * exec.c (try_open_exec_file): Update.
4197         * exceptions.c (print_exception, exception_print)
4198         (exception_fprintf, exception_print_same): Update.
4199         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4200         * dwarf-index-cache.c (index_cache::store)
4201         (index_cache::lookup_gdb_index): Update.
4202         * darwin-nat.c (maybe_cache_shell): Update.
4203         * cp-valprint.c (cp_print_value_fields): Update.
4204         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4205         (gcc_cplus_symbol_address): Update.
4206         * compile/compile-c-symbols.c (gcc_convert_symbol)
4207         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4208         * common/selftest.c: Update.
4209         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4210         a std::string.
4211         (exception_try_scope_entry, exception_try_scope_exit): Don't
4212         declare.
4213         (struct exception_try_scope): Remove.
4214         (TRY): Don't use exception_try_scope.
4215         (struct gdb_exception): Add constructor, operator=.
4216         <what>: New method.
4217         (struct gdb_exception_RETURN_MASK_ALL)
4218         (struct gdb_exception_RETURN_MASK_ERROR)
4219         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4220         (struct gdb_quit_bad_alloc): Update.
4221         * common/common-exceptions.c (exception_none): Change
4222         initializer.
4223         (struct catcher) <state, exception>: Initialize inline.
4224         <prev>: Remove member.
4225         (current_catcher): Remove.
4226         (catchers): New global.
4227         (exceptions_state_mc_init): Simplify.
4228         (catcher_pop): Remove.
4229         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4230         (try_scope_depth, exception_try_scope_entry)
4231         (exception_try_scope_exit): Remove.
4232         (throw_exception_sjlj): Update.
4233         (exception_messages, exception_messages_size): Remove.
4234         (throw_it): Simplify.
4235         (gdb_exception_sliced_copy): Remove.
4236         (throw_exception_cxx): Update.
4237         * cli/cli-script.c (script_from_file): Update.
4238         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4239         Update.
4240         * ada-valprint.c (ada_val_print): Update.
4241         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4242         (create_excep_cond_exprs): Update.
4243
4244 2019-04-08  Tom Tromey  <tom@tromey.com>
4245
4246         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4247         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4248         (TRY, CATCH, END_CATCH): Remove some definitions.
4249         * common/common-exceptions.c: Don't use GDB_XCPT.
4250         (catcher_list_size): Remove.
4251         (throw_exception, throw_it): Simplify.
4252
4253 2019-04-05  Tom Tromey  <tom@tromey.com>
4254
4255         Revert the header-sorting patch.
4256         * ft32-tdep.c: Revert.
4257         * frv-tdep.c: Revert.
4258         * frv-linux-tdep.c: Revert.
4259         * frame.c: Revert.
4260         * frame-unwind.c: Revert.
4261         * frame-base.c: Revert.
4262         * fork-child.c: Revert.
4263         * findvar.c: Revert.
4264         * findcmd.c: Revert.
4265         * filesystem.c: Revert.
4266         * filename-seen-cache.h: Revert.
4267         * filename-seen-cache.c: Revert.
4268         * fbsd-tdep.c: Revert.
4269         * fbsd-nat.h: Revert.
4270         * fbsd-nat.c: Revert.
4271         * f-valprint.c: Revert.
4272         * f-typeprint.c: Revert.
4273         * f-lang.c: Revert.
4274         * extension.h: Revert.
4275         * extension.c: Revert.
4276         * extension-priv.h: Revert.
4277         * expprint.c: Revert.
4278         * exec.h: Revert.
4279         * exec.c: Revert.
4280         * exceptions.c: Revert.
4281         * event-top.c: Revert.
4282         * event-loop.c: Revert.
4283         * eval.c: Revert.
4284         * elfread.c: Revert.
4285         * dwarf2read.h: Revert.
4286         * dwarf2read.c: Revert.
4287         * dwarf2loc.c: Revert.
4288         * dwarf2expr.h: Revert.
4289         * dwarf2expr.c: Revert.
4290         * dwarf2-frame.c: Revert.
4291         * dwarf2-frame-tailcall.c: Revert.
4292         * dwarf-index-write.h: Revert.
4293         * dwarf-index-write.c: Revert.
4294         * dwarf-index-common.c: Revert.
4295         * dwarf-index-cache.h: Revert.
4296         * dwarf-index-cache.c: Revert.
4297         * dummy-frame.c: Revert.
4298         * dtrace-probe.c: Revert.
4299         * disasm.h: Revert.
4300         * disasm.c: Revert.
4301         * disasm-selftests.c: Revert.
4302         * dictionary.c: Revert.
4303         * dicos-tdep.c: Revert.
4304         * demangle.c: Revert.
4305         * dcache.h: Revert.
4306         * dcache.c: Revert.
4307         * darwin-nat.h: Revert.
4308         * darwin-nat.c: Revert.
4309         * darwin-nat-info.c: Revert.
4310         * d-valprint.c: Revert.
4311         * d-namespace.c: Revert.
4312         * d-lang.c: Revert.
4313         * ctf.c: Revert.
4314         * csky-tdep.c: Revert.
4315         * csky-linux-tdep.c: Revert.
4316         * cris-tdep.c: Revert.
4317         * cris-linux-tdep.c: Revert.
4318         * cp-valprint.c: Revert.
4319         * cp-support.c: Revert.
4320         * cp-namespace.c: Revert.
4321         * cp-abi.c: Revert.
4322         * corelow.c: Revert.
4323         * corefile.c: Revert.
4324         * continuations.c: Revert.
4325         * completer.h: Revert.
4326         * completer.c: Revert.
4327         * complaints.c: Revert.
4328         * coffread.c: Revert.
4329         * coff-pe-read.c: Revert.
4330         * cli-out.h: Revert.
4331         * cli-out.c: Revert.
4332         * charset.c: Revert.
4333         * c-varobj.c: Revert.
4334         * c-valprint.c: Revert.
4335         * c-typeprint.c: Revert.
4336         * c-lang.c: Revert.
4337         * buildsym.c: Revert.
4338         * buildsym-legacy.c: Revert.
4339         * build-id.h: Revert.
4340         * build-id.c: Revert.
4341         * btrace.c: Revert.
4342         * bsd-uthread.c: Revert.
4343         * breakpoint.h: Revert.
4344         * breakpoint.c: Revert.
4345         * break-catch-throw.c: Revert.
4346         * break-catch-syscall.c: Revert.
4347         * break-catch-sig.c: Revert.
4348         * blockframe.c: Revert.
4349         * block.c: Revert.
4350         * bfin-tdep.c: Revert.
4351         * bfin-linux-tdep.c: Revert.
4352         * bfd-target.c: Revert.
4353         * bcache.c: Revert.
4354         * ax-general.c: Revert.
4355         * ax-gdb.h: Revert.
4356         * ax-gdb.c: Revert.
4357         * avr-tdep.c: Revert.
4358         * auxv.c: Revert.
4359         * auto-load.c: Revert.
4360         * arm-wince-tdep.c: Revert.
4361         * arm-tdep.c: Revert.
4362         * arm-symbian-tdep.c: Revert.
4363         * arm-pikeos-tdep.c: Revert.
4364         * arm-obsd-tdep.c: Revert.
4365         * arm-nbsd-tdep.c: Revert.
4366         * arm-nbsd-nat.c: Revert.
4367         * arm-linux-tdep.c: Revert.
4368         * arm-linux-nat.c: Revert.
4369         * arm-fbsd-tdep.c: Revert.
4370         * arm-fbsd-nat.c: Revert.
4371         * arm-bsd-tdep.c: Revert.
4372         * arch-utils.c: Revert.
4373         * arc-tdep.c: Revert.
4374         * arc-newlib-tdep.c: Revert.
4375         * annotate.h: Revert.
4376         * annotate.c: Revert.
4377         * amd64-windows-tdep.c: Revert.
4378         * amd64-windows-nat.c: Revert.
4379         * amd64-tdep.c: Revert.
4380         * amd64-sol2-tdep.c: Revert.
4381         * amd64-obsd-tdep.c: Revert.
4382         * amd64-obsd-nat.c: Revert.
4383         * amd64-nbsd-tdep.c: Revert.
4384         * amd64-nbsd-nat.c: Revert.
4385         * amd64-nat.c: Revert.
4386         * amd64-linux-tdep.c: Revert.
4387         * amd64-linux-nat.c: Revert.
4388         * amd64-fbsd-tdep.c: Revert.
4389         * amd64-fbsd-nat.c: Revert.
4390         * amd64-dicos-tdep.c: Revert.
4391         * amd64-darwin-tdep.c: Revert.
4392         * amd64-bsd-nat.c: Revert.
4393         * alpha-tdep.c: Revert.
4394         * alpha-obsd-tdep.c: Revert.
4395         * alpha-nbsd-tdep.c: Revert.
4396         * alpha-mdebug-tdep.c: Revert.
4397         * alpha-linux-tdep.c: Revert.
4398         * alpha-linux-nat.c: Revert.
4399         * alpha-bsd-tdep.c: Revert.
4400         * alpha-bsd-nat.c: Revert.
4401         * aix-thread.c: Revert.
4402         * agent.c: Revert.
4403         * addrmap.c: Revert.
4404         * ada-varobj.c: Revert.
4405         * ada-valprint.c: Revert.
4406         * ada-typeprint.c: Revert.
4407         * ada-tasks.c: Revert.
4408         * ada-lang.c: Revert.
4409         * aarch64-tdep.c: Revert.
4410         * aarch64-ravenscar-thread.c: Revert.
4411         * aarch64-newlib-tdep.c: Revert.
4412         * aarch64-linux-tdep.c: Revert.
4413         * aarch64-linux-nat.c: Revert.
4414         * aarch64-fbsd-tdep.c: Revert.
4415         * aarch64-fbsd-nat.c: Revert.
4416         * aarch32-linux-nat.c: Revert.
4417
4418 2019-04-05  Tom Tromey  <tom@tromey.com>
4419
4420         * ft32-tdep.c: Sort headers.
4421         * frv-tdep.c: Sort headers.
4422         * frv-linux-tdep.c: Sort headers.
4423         * frame.c: Sort headers.
4424         * frame-unwind.c: Sort headers.
4425         * frame-base.c: Sort headers.
4426         * fork-child.c: Sort headers.
4427         * findvar.c: Sort headers.
4428         * findcmd.c: Sort headers.
4429         * filesystem.c: Sort headers.
4430         * filename-seen-cache.h: Sort headers.
4431         * filename-seen-cache.c: Sort headers.
4432         * fbsd-tdep.c: Sort headers.
4433         * fbsd-nat.h: Sort headers.
4434         * fbsd-nat.c: Sort headers.
4435         * f-valprint.c: Sort headers.
4436         * f-typeprint.c: Sort headers.
4437         * f-lang.c: Sort headers.
4438         * extension.h: Sort headers.
4439         * extension.c: Sort headers.
4440         * extension-priv.h: Sort headers.
4441         * expprint.c: Sort headers.
4442         * exec.h: Sort headers.
4443         * exec.c: Sort headers.
4444         * exceptions.c: Sort headers.
4445         * event-top.c: Sort headers.
4446         * event-loop.c: Sort headers.
4447         * eval.c: Sort headers.
4448         * elfread.c: Sort headers.
4449         * dwarf2read.h: Sort headers.
4450         * dwarf2read.c: Sort headers.
4451         * dwarf2loc.c: Sort headers.
4452         * dwarf2expr.h: Sort headers.
4453         * dwarf2expr.c: Sort headers.
4454         * dwarf2-frame.c: Sort headers.
4455         * dwarf2-frame-tailcall.c: Sort headers.
4456         * dwarf-index-write.h: Sort headers.
4457         * dwarf-index-write.c: Sort headers.
4458         * dwarf-index-common.c: Sort headers.
4459         * dwarf-index-cache.h: Sort headers.
4460         * dwarf-index-cache.c: Sort headers.
4461         * dummy-frame.c: Sort headers.
4462         * dtrace-probe.c: Sort headers.
4463         * disasm.h: Sort headers.
4464         * disasm.c: Sort headers.
4465         * disasm-selftests.c: Sort headers.
4466         * dictionary.c: Sort headers.
4467         * dicos-tdep.c: Sort headers.
4468         * demangle.c: Sort headers.
4469         * dcache.h: Sort headers.
4470         * dcache.c: Sort headers.
4471         * darwin-nat.h: Sort headers.
4472         * darwin-nat.c: Sort headers.
4473         * darwin-nat-info.c: Sort headers.
4474         * d-valprint.c: Sort headers.
4475         * d-namespace.c: Sort headers.
4476         * d-lang.c: Sort headers.
4477         * ctf.c: Sort headers.
4478         * csky-tdep.c: Sort headers.
4479         * csky-linux-tdep.c: Sort headers.
4480         * cris-tdep.c: Sort headers.
4481         * cris-linux-tdep.c: Sort headers.
4482         * cp-valprint.c: Sort headers.
4483         * cp-support.c: Sort headers.
4484         * cp-namespace.c: Sort headers.
4485         * cp-abi.c: Sort headers.
4486         * corelow.c: Sort headers.
4487         * corefile.c: Sort headers.
4488         * continuations.c: Sort headers.
4489         * completer.h: Sort headers.
4490         * completer.c: Sort headers.
4491         * complaints.c: Sort headers.
4492         * coffread.c: Sort headers.
4493         * coff-pe-read.c: Sort headers.
4494         * cli-out.h: Sort headers.
4495         * cli-out.c: Sort headers.
4496         * charset.c: Sort headers.
4497         * c-varobj.c: Sort headers.
4498         * c-valprint.c: Sort headers.
4499         * c-typeprint.c: Sort headers.
4500         * c-lang.c: Sort headers.
4501         * buildsym.c: Sort headers.
4502         * buildsym-legacy.c: Sort headers.
4503         * build-id.h: Sort headers.
4504         * build-id.c: Sort headers.
4505         * btrace.c: Sort headers.
4506         * bsd-uthread.c: Sort headers.
4507         * breakpoint.h: Sort headers.
4508         * breakpoint.c: Sort headers.
4509         * break-catch-throw.c: Sort headers.
4510         * break-catch-syscall.c: Sort headers.
4511         * break-catch-sig.c: Sort headers.
4512         * blockframe.c: Sort headers.
4513         * block.c: Sort headers.
4514         * bfin-tdep.c: Sort headers.
4515         * bfin-linux-tdep.c: Sort headers.
4516         * bfd-target.c: Sort headers.
4517         * bcache.c: Sort headers.
4518         * ax-general.c: Sort headers.
4519         * ax-gdb.h: Sort headers.
4520         * ax-gdb.c: Sort headers.
4521         * avr-tdep.c: Sort headers.
4522         * auxv.c: Sort headers.
4523         * auto-load.c: Sort headers.
4524         * arm-wince-tdep.c: Sort headers.
4525         * arm-tdep.c: Sort headers.
4526         * arm-symbian-tdep.c: Sort headers.
4527         * arm-pikeos-tdep.c: Sort headers.
4528         * arm-obsd-tdep.c: Sort headers.
4529         * arm-nbsd-tdep.c: Sort headers.
4530         * arm-nbsd-nat.c: Sort headers.
4531         * arm-linux-tdep.c: Sort headers.
4532         * arm-linux-nat.c: Sort headers.
4533         * arm-fbsd-tdep.c: Sort headers.
4534         * arm-fbsd-nat.c: Sort headers.
4535         * arm-bsd-tdep.c: Sort headers.
4536         * arch-utils.c: Sort headers.
4537         * arc-tdep.c: Sort headers.
4538         * arc-newlib-tdep.c: Sort headers.
4539         * annotate.h: Sort headers.
4540         * annotate.c: Sort headers.
4541         * amd64-windows-tdep.c: Sort headers.
4542         * amd64-windows-nat.c: Sort headers.
4543         * amd64-tdep.c: Sort headers.
4544         * amd64-sol2-tdep.c: Sort headers.
4545         * amd64-obsd-tdep.c: Sort headers.
4546         * amd64-obsd-nat.c: Sort headers.
4547         * amd64-nbsd-tdep.c: Sort headers.
4548         * amd64-nbsd-nat.c: Sort headers.
4549         * amd64-nat.c: Sort headers.
4550         * amd64-linux-tdep.c: Sort headers.
4551         * amd64-linux-nat.c: Sort headers.
4552         * amd64-fbsd-tdep.c: Sort headers.
4553         * amd64-fbsd-nat.c: Sort headers.
4554         * amd64-dicos-tdep.c: Sort headers.
4555         * amd64-darwin-tdep.c: Sort headers.
4556         * amd64-bsd-nat.c: Sort headers.
4557         * alpha-tdep.c: Sort headers.
4558         * alpha-obsd-tdep.c: Sort headers.
4559         * alpha-nbsd-tdep.c: Sort headers.
4560         * alpha-mdebug-tdep.c: Sort headers.
4561         * alpha-linux-tdep.c: Sort headers.
4562         * alpha-linux-nat.c: Sort headers.
4563         * alpha-bsd-tdep.c: Sort headers.
4564         * alpha-bsd-nat.c: Sort headers.
4565         * aix-thread.c: Sort headers.
4566         * agent.c: Sort headers.
4567         * addrmap.c: Sort headers.
4568         * ada-varobj.c: Sort headers.
4569         * ada-valprint.c: Sort headers.
4570         * ada-typeprint.c: Sort headers.
4571         * ada-tasks.c: Sort headers.
4572         * ada-lang.c: Sort headers.
4573         * aarch64-tdep.c: Sort headers.
4574         * aarch64-ravenscar-thread.c: Sort headers.
4575         * aarch64-newlib-tdep.c: Sort headers.
4576         * aarch64-linux-tdep.c: Sort headers.
4577         * aarch64-linux-nat.c: Sort headers.
4578         * aarch64-fbsd-tdep.c: Sort headers.
4579         * aarch64-fbsd-nat.c: Sort headers.
4580         * aarch32-linux-nat.c: Sort headers.
4581
4582 2019-04-04  Tom Tromey  <tom@tromey.com>
4583
4584         * varobj.c (varobj_create): Update.
4585         * rust-exp.y (struct rust_parser) <update_innermost_block,
4586         lookup_symbol>: New methods.
4587         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4588         Rename.
4589         (rust_parser::rust_lookup_type)
4590         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4591         * printcmd.c (display_command, do_one_display): Update.
4592         * parser-defs.h (struct parser_state) <parser_state>: Add
4593         "tracker" parameter.
4594         (block_tracker): New member.
4595         (class innermost_block_tracker) <innermost_block_tracker>: Add
4596         "types" parameter.
4597         <reset>: Remove method.
4598         (innermost_block): Don't declare.
4599         (null_post_parser): Update.
4600         * parse.c (innermost_block): Remove global.
4601         (write_dollar_variable): Update.
4602         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4603         Remove "tracker_types" parameter.
4604         (parse_expression): Add "tracker" parameter.
4605         (parse_expression_for_completion): Update.
4606         (null_post_parser): Add "tracker" parameter.
4607         * p-exp.y: Update rules.
4608         * m2-exp.y: Update rules.
4609         * language.h (struct language_defn) <la_post_parser>: Add
4610         "tracker" parameter.
4611         * go-exp.y: Update rules.
4612         * f-exp.y: Update rules.
4613         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4614         parameter.
4615         * d-exp.y: Update rules.
4616         * c-exp.y: Update rules.
4617         * breakpoint.c (set_breakpoint_condition): Create an
4618         innermost_block_tracker.
4619         (watch_command_1): Likewise.
4620         * ada-lang.c (resolve): Add "tracker" parameter.
4621         (resolve_subexp): Likewise.
4622         * ada-exp.y (write_var_from_sym): Update.
4623
4624 2019-04-04  Tom Tromey  <tom@tromey.com>
4625
4626         * type-stack.h: New file.
4627         * type-stack.c: New file.
4628         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4629         type-stack.h.
4630         (insert_into_type_stack, insert_type, push_type, push_type_int)
4631         (insert_type_address_space, pop_type, pop_type_int)
4632         (pop_typelist, pop_type_stack, append_type_stack)
4633         (push_type_stack, get_type_stack, push_typelist)
4634         (follow_type_instance_flags, follow_types): Don't declare.
4635         * parse.c (type_stack): Remove global.
4636         (parse_exp_in_context): Update.
4637         (insert_into_type_stack, insert_type, push_type, push_type_int)
4638         (insert_type_address_space, pop_type, pop_type_int)
4639         (pop_typelist, pop_type_stack, append_type_stack)
4640         (push_type_stack, get_type_stack, push_typelist)
4641         (follow_type_instance_flags, follow_types): Remove (moved to
4642         type-stack.c).
4643         * f-exp.y (type_stack): New global.
4644         Update rules.
4645         (push_kind_type, f_parse): Update.
4646         * d-exp.y (type_stack): New global.
4647         Update rules.
4648         (d_parse): Update.
4649         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4650         Update rules.
4651         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4652         (HFILES_NO_SRCDIR): Add type-stack.h.
4653
4654 2019-04-04  Tom Tromey  <tom@tromey.com>
4655
4656         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4657         (rust_parser::convert_ast_to_expression, rust_parse)
4658         (rust_lex_test_completion, rust_lex_tests): Update.
4659         * parser-defs.h (struct expr_completion_state): New.
4660         (struct parser_state) <parser_state>: Add completion parameter.
4661         <mark_struct_expression, mark_completion_tag>: New methods.
4662         <parse_completion, m_completion_state>: New members.
4663         (prefixify_expression, null_post_parser): Update.
4664         (mark_struct_expression, mark_completion_tag): Don't declare.
4665         * parse.c (parse_completion, expout_last_struct)
4666         (expout_tag_completion_type, expout_completion_name): Remove
4667         globals.
4668         (parser_state::mark_struct_expression)
4669         (parser_state::mark_completion_tag): Now methods.
4670         (prefixify_expression): Add last_struct parameter.
4671         (prefixify_subexp): Likewise.
4672         (parse_exp_1): Update.
4673         (parse_exp_in_context): Add cstate parameter.  Update.
4674         (parse_expression_for_completion): Create an
4675         expr_completion_state.
4676         (null_post_parser): Add "completion" parameter.
4677         * p-exp.y: Update rules.
4678         (yylex): Update.
4679         * language.h (struct language_defn) <la_post_parser>: Add
4680         "completing" parameter.
4681         * go-exp.y: Update rules.
4682         (lex_one_token): Update.
4683         * expression.h (parse_completion): Don't declare.
4684         * d-exp.y: Update rules.
4685         (lex_one_token): Update rules.
4686         * c-exp.y: Update rules.
4687         (lex_one_token): Update.
4688         * ada-lang.c (resolve): Add "parse_completion" parameter.
4689         (resolve_subexp): Likewise.
4690         (ada_resolve_function): Likewise.
4691
4692 2019-04-04  Tom Tromey  <tom@tromey.com>
4693
4694         * parser-defs.h (struct parser_state) <start_arglist,
4695         end_arglist>: New methods.
4696         <arglist_len, m_funcall_chain>: New members.
4697         (arglist_len, start_arglist, end_arglist): Don't declare.
4698         * parse.c (arglist_len, funcall_chain): Remove global.
4699         (start_arglist, end_arglist): Remove functions.
4700         (parse_exp_in_context): Update.
4701         * p-exp.y: Update rules.
4702         * m2-exp.y: Update rules.
4703         * go-exp.y: Update rules.
4704         * f-exp.y: Update rules.
4705         * d-exp.y: Update rules.
4706         * c-exp.y: Update rules.
4707
4708 2019-04-04  Tom Tromey  <tom@tromey.com>
4709
4710         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4711         lex_operator, push_back>: New methods.
4712         Update all rules.
4713         (rust_parser::lex_hex, lex_escape): Rename and update.
4714         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4715         (rust_parser::lex_operator): Rename and update.
4716         (rust_parser::lex_number, rustyylex, rustyyerror)
4717         (rust_lex_test_init, rust_lex_test_sequence)
4718         (rust_lex_test_push_back, rust_lex_tests): Update.
4719         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4720         parameter.
4721         <lexptr, prev_lexptr>: New members.
4722         (lexptr, prev_lexptr): Don't declare.
4723         * parse.c (lexptr, prev_lexptr): Remove globals.
4724         (parse_exp_in_context): Update.
4725         * p-exp.y (yylex, yyerror): Update.
4726         * m2-exp.y (parse_number, yylex, yyerror): Update.
4727         * go-exp.y (lex_one_token, yyerror): Update.
4728         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4729         * d-exp.y (lex_one_token, yyerror): Update.
4730         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4731         (lex_one_token, yyerror): Update.
4732         * ada-lex.l (YY_INPUT): Update.
4733         (rewind_to_char): Update.
4734         * ada-exp.y (yyerror): Update.
4735
4736 2019-04-04  Tom Tromey  <tom@tromey.com>
4737
4738         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4739         * parser-defs.h (struct parser_state) <parser_state>: Add new
4740         parameter.
4741         <comma_terminates>: New member.
4742         (comma_terminates): Don't declare global.
4743         * parse.c (comma_terminates): Remove global.
4744         (parse_exp_in_context): Update.
4745         * p-exp.y (yylex): Update.
4746         * m2-exp.y (yylex): Update.
4747         * go-exp.y (lex_one_token): Update.
4748         * f-exp.y (yylex): Update.
4749         * d-exp.y (lex_one_token): Update.
4750         * c-exp.y (lex_one_token): Update.
4751         * ada-lex.l: Update.
4752
4753 2019-04-04  Tom Tromey  <tom@tromey.com>
4754
4755         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4756         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4757         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4758         * parser-defs.h (paren_depth): Don't declare.
4759         * parse.c (paren_depth): Remove global.
4760         (parse_exp_in_context): Update.
4761         * p-exp.y (paren_depth): New global.
4762         (pascal_parse): Initialize it.
4763         * m2-exp.y (paren_depth): New global.
4764         (m2_parse): Initialize it.
4765         * go-exp.y (paren_depth): New global.
4766         (go_parse): Initialize it.
4767         * f-exp.y (paren_depth): New global.
4768         (f_parse): Initialize it.
4769         * d-exp.y (paren_depth): New global.
4770         (d_parse): Initialize it.
4771         * c-exp.y (paren_depth): New global.
4772         (c_parse): Initialize it.
4773         * ada-lex.l (paren_depth): New global.
4774         (lexer_init): Initialize it.
4775
4776 2019-04-04  Tom Tromey  <tom@tromey.com>
4777
4778         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4779         (rust_parser::convert_ast_to_type)
4780         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4781         * parser-defs.h (struct parser_state) <parser_state>: Add
4782         parameters.  Initialize new members.
4783         <expression_context_block, expression_context_pc>: New members.
4784         * parse.c (expression_context_block, expression_context_pc):
4785         Remove globals.
4786         (parse_exp_in_context): Update.
4787         * p-exp.y: Update all rules.
4788         (yylex): Update.
4789         * m2-exp.y: Update all rules.
4790         (yylex): Update.
4791         * go-exp.y (yylex): Update.
4792         * f-exp.y (yylex): Update.
4793         * d-exp.y: Update all rules.
4794         (yylex): Update.
4795         * c-exp.y: Update all rules.
4796         (lex_one_token, classify_name, yylex, c_parse): Update.
4797         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4798
4799 2019-04-04  Tom Tromey  <tom@tromey.com>
4800
4801         * gdbarch.h, gdbarch.c: Rebuild.
4802         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4803         * stap-probe.h:
4804         (struct stap_parse_info): Replace "parser_state" with
4805         "expr_builder".
4806         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4807         (parser_state): New class.
4808         * parse.c (expr_builder): Rename.
4809         (expr_builder::release): Rename.
4810         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4811         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4812         (write_exp_elt_longcst, write_exp_elt_floatcst)
4813         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4814         (write_exp_string_vector, write_exp_bitstring)
4815         (write_exp_msymbol, mark_struct_expression)
4816         (write_dollar_variable)
4817         (insert_type_address_space, increase_expout_size): Replace
4818         "parser_state" with "expr_builder".
4819         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4820         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4821         "parser_state" with "expr_builder".
4822
4823 2019-04-04  Tom Tromey  <tom@tromey.com>
4824
4825         * rust-exp.y: Replace "parse_language" with method call.
4826         * p-exp.y:
4827         (yylex): Replace "parse_language" with method call.
4828         * m2-exp.y:
4829         (yylex): Replace "parse_language" with method call.
4830         * go-exp.y (classify_name): Replace "parse_language" with method
4831         call.
4832         * f-exp.y (yylex): Replace "parse_language" with method call.
4833         * d-exp.y (lex_one_token): Replace "parse_language" with method
4834         call.
4835         * c-exp.y:
4836         (lex_one_token, classify_name, yylex): Replace "parse_language"
4837         with method call.
4838         * ada-exp.y (find_primitive_type, type_char)
4839         (type_system_address): Replace "parse_language" with method call.
4840
4841 2019-04-04  Tom Tromey  <tom@tromey.com>
4842
4843         * rust-exp.y: Replace "parse_gdbarch" with method call.
4844         * parse.c (write_dollar_variable, insert_type_address_space):
4845         Replace "parse_gdbarch" with method call.
4846         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4847         call.
4848         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4849         call.
4850         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4851         "parse_gdbarch" with method call.
4852         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4853         with method call.
4854         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4855         "parse_gdbarch" with method call.
4856         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4857         "parse_gdbarch" with method call.
4858         * c-exp.y (parse_type, parse_number, classify_name): Replace
4859         "parse_gdbarch" with method call.
4860         * ada-lex.l: Replace "parse_gdbarch" with method call.
4861         * ada-exp.y (parse_type, find_primitive_type, type_char)
4862         (type_system_address): Replace "parse_gdbarch" with method call.
4863
4864 2019-04-04  Tom Tromey  <tom@tromey.com>
4865
4866         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4867         * stap-probe.c (stap_parse_argument): Update.
4868         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4869         initial_size parameter.
4870         * rust-exp.y (rust_lex_tests): Update.
4871         * parse.c (parser_state): Update.
4872         (parse_exp_in_context): Update.
4873         * parser-defs.h (struct parser_state) <parser_state>: Remove
4874         "initial_size" parameter.
4875
4876 2019-04-04  Tom Tromey  <tom@tromey.com>
4877
4878         * parser-defs.h (increase_expout_size): Don't declare.
4879         * parse.c (increase_expout_size): Now static.
4880
4881 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4882
4883         * gnu-nat.c (gnu_nat_target::wait): Fix
4884         target_waitstatus_to_string call.
4885
4886 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4887
4888         * eval.c (evaluate_subexp_standard): Handle internal functions
4889         during Fortran function call handling.
4890
4891 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4892
4893         * NEWS: Mention new internal functions.
4894         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4895         (read_base_type): Use dwarf2_init_complex_target_type.
4896         * value.c (creal_internal_fn): New function.
4897         (cimag_internal_fn): New function.
4898         (_initialize_values): Register new internal functions.
4899
4900 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4901
4902         * infrun.c (stop_all_threads): If debug_infrun, always
4903         trace the wait status after wait_one, using
4904         target_waitstatus_to_string and target_pid_to_str.
4905         (handle_inferior_event): Replace various trace of
4906         wait status kind by a single trace.
4907         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4908         wait status kind image by target_waitstatus_to_string.
4909         * target/waitstatus.c (target_waitstatus_to_string): Fix
4910         obsolete comment.
4911
4912 2019-04-01  Tom Tromey  <tromey@adacore.com>
4913
4914         PR symtab/23331:
4915         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4916
4917 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4918             Pedro Alves  <palves@redhat.com>
4919
4920         * top.c (quit_force): Call 'finalize_values'.
4921         * value.c (finalize_values): New function.
4922         * value.h (finalize_values): Declare.
4923
4924 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4925
4926         * NEWS: Announce $_gdb_major and $_gdb_minor.
4927
4928         * top.c (init_gdb_version_vars): New function.
4929         (gdb_init): Call init_gdb_version_vars.
4930
4931 2019-03-29  Tom Tromey  <tromey@adacore.com>
4932
4933         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4934         help text.  Remove dead code.
4935
4936 2019-03-29  Keith Seitz  <keiths@redhat.com>
4937
4938         From Siddhesh Poyarekar:
4939         * f-lang.h (f77_get_upperbound): Return LONGEST.
4940         (f77_get_lowerbound): Likewise.
4941         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4942         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4943         print them.
4944         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4945         plongest to format print it.
4946         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4947         (f77_get_upperbound): Likewise.
4948         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4949         LOWER_BOUND to LONGEST.
4950         (f77_create_arrayprint_offset_tbl): Likewise.
4951
4952 2019-03-29  Keith Seitz  <keiths@redhat.com>
4953
4954         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4955         %s/pulongest for TYPE_LENGTH instead of %d in format
4956         strings.
4957         * ada-typerint.c (ada_print_type): Likewise.
4958         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4959         * compile/compile-c-support.c (generate_register_struct): Likewise.
4960         * gdbtypes.c (recursive_dump_type): Likewise.
4961         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4962         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4963         instead of %d in format strings.
4964         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4965         to std::min to ULONGEST.
4966         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4967         instead of %d in format strings.
4968         * tracepoint.c (info_scope_command): Likewise.
4969         * typeprint.c (print_offset_data::update)
4970         (print_offset_data::finish): Likewise.
4971         * xtensa-tdep.c (xtensa_store_return_value)
4972         (xtensa_push_dummy_call): Likewise.
4973
4974 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4975
4976         * windows-nat.c (display_selector): Fixed format specifications
4977         for 64-bit Cygwin.
4978
4979 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4980
4981         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4982
4983 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4984
4985         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4986         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4987         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4988         (nios2_linux_init_abi): Install it.
4989
4990 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4991
4992         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4993
4994 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4995
4996         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4997
4998 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4999             Tom Tromey  <tromey@adacore.com>
5000
5001         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5002
5003 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5004
5005         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5006         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5007         method to compute the bounds of range types. Also print "[evaluated]"
5008         if the bounds' values come from a dynamic evaluation.
5009
5010 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5011
5012         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5013         whitespace when pretty printing is on.
5014
5015 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5016
5017         * ppc-linux-nat.c: Add include.
5018
5019 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5020
5021         * NEWS: Mention AArch64 Pointer Authentication.
5022
5023 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5024
5025         * arm-linux-nat.c: Add include.
5026
5027 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5028
5029         * source-cache.c (source_cache::get_source_lines): Re-read
5030         fullname after calling open_source_file.
5031
5032 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5033
5034         * NEWS: Mention TLS support for FreeBSD.
5035
5036 2019-03-25  Tom Tromey  <tromey@adacore.com>
5037
5038         * minsyms.c (BUNCH_SIZE): Update comment.
5039         (~minimal_symbol_reader): Remove old comment.
5040         (compact_minimal_symbols): Update comment.
5041         (minimal_symbol_reader::install): Remove old comment.  Update
5042         other comments.
5043
5044 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5045
5046         * s390-linux-nat.c: Add include.
5047
5048 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5049
5050         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5051         Call linux_get_hwcap.
5052         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5053         Likewise.
5054         (aarch64_linux_get_hwcap): Remove function.
5055         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5056         declaration.
5057         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5058         linux_get_hwcap.
5059         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5060         * linux-tdep.c (linux_get_hwcap): Add function.
5061         (linux_get_hwcap2): Likewise.
5062         * linux-tdep.h (linux_get_hwcap): Add declaration.
5063         (linux_get_hwcap2): Likewise.
5064         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5065         (ppc_linux_get_hwcap2): Likewise.
5066         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5067         linux_get_hwcap.
5068         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5069         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5070         (ppc_linux_nat_target::read_description): Likewise.
5071         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5072         * s390-linux-nat.c: Likewise.
5073         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5074
5075 2019-03-24  Tom Tromey  <tom@tromey.com>
5076
5077         * ada-lang.c (standard_lookup): Simplify initialization.
5078         (ada_lookup_symbol_nonlocal): Simplify return.
5079         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5080         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5081         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5082         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5083         initialization.
5084         * solib.c (solib_global_lookup): Simplify.
5085         * symtab.c (null_block_symbol): Remove.
5086         (symbol_cache_lookup): Simplify returns.
5087         (lookup_language_this): Simplify returns.
5088         (lookup_symbol_aux): Simplify return.
5089         (lookup_local_symbol): Simplify returns.
5090         (lookup_global_symbol_from_objfile): Simplify return.
5091         (lookup_symbol_in_objfile_symtabs)
5092         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5093         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5094         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5095         * cp-namespace.c (cp_lookup_bare_symbol)
5096         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5097         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5098         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5099         (cp_lookup_symbol_via_imports): Simplify initialization.
5100         (find_symbol_in_baseclass): Likewise.
5101         * symtab.h (null_block_symbol): Remove.
5102         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5103         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5104         (d_lookup_symbol_module): Likewise.
5105         (find_symbol_in_baseclass): Simplify initialization.
5106
5107 2019-03-24  Tom Tromey  <tom@tromey.com>
5108
5109         * expression.h: Don't include symtab.h.
5110         (struct block): Forward declare.
5111
5112 2019-03-24  Tom Tromey  <tom@tromey.com>
5113
5114         * c-exp.y (typebase): Remove casts.
5115         * gdbtypes.c (lookup_unsigned_typename, )
5116         (lookup_signed_typename): Remove cast.
5117         * eval.c (parse_to_comma_and_eval): Remove cast.
5118         * parse.c (write_dollar_variable): Remove cast.
5119         * block.h (struct block) <superblock>: Now const.
5120         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5121         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5122         (map_block): Make "block" const.
5123         * symfile.h (struct quick_symbol_functions)
5124         <map_matching_symbols>: Constify block argument to "callback".
5125         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5126         const.
5127         (find_pc_sect_compunit_symtab): Make "b" const.
5128         (find_symbol_at_address): Likewise.
5129         (search_symbols): Likewise.
5130         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5131         (dw2_debug_names_lookup_symbol): Likewise.
5132         (dw2_map_matching_symbols): Update.
5133         * p-valprint.c (pascal_val_print): Remove "block".
5134         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5135         (aux_add_nonlocal_symbols): Make "block" const.
5136         (resolve_subexp): Remove cast.
5137         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5138         const.
5139         (iterate_over_file_blocks): Likewise.
5140         * f-exp.y (%union) <bval>: Remove.
5141         * coffread.c (patch_opaque_types): Make "b" const.
5142         * spu-tdep.c (spu_catch_start): Make "block" const.
5143         * c-valprint.c (print_unpacked_pointer): Remove "block".
5144         * symmisc.c (dump_symtab_1): Make "b" const.
5145         (block_depth): Make "block" const.
5146         * d-exp.y (%union) <bval>: Remove.
5147         * cp-support.h (cp_lookup_rtti_type): Update.
5148         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5149         * psymtab.c (psym_lookup_symbol): Make "block" const.
5150         (maintenance_check_psymtabs): Make "b" const.
5151         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5152         (enumerate_locals, enumerate_args): Update.
5153         * python/py-symtab.c (stpy_global_block): Make "block" const.
5154         (stpy_static_block): Likewise.
5155         * inline-frame.c (block_starting_point_at): Make "new_block"
5156         const.
5157         * block.c (find_block_in_blockvector): Make return type const.
5158         (blockvector_for_pc_sect): Make "b" const.
5159         (find_block_in_blockvector): Make "b" const.
5160
5161 2019-03-23  Tom Tromey  <tom@tromey.com>
5162
5163         * varobj.c (varobj_create): Update.
5164         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5165         * printcmd.c (display_command, do_one_display): Don't reset
5166         innermost_block.
5167         * parser-defs.h (enum innermost_block_tracker_type): Move to
5168         expression.h.
5169         (innermost_block): Update comment.
5170         * parse.c (parse_exp_1): Add tracker_types parameter.
5171         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5172         tracker_types parameter.  Reset innermost_block.
5173         (parse_exp_in_context): Remove.
5174         (parse_expression_for_completion): Update.
5175         * objfiles.c (~objfile): Don't reset expression_context_block or
5176         innermost_block.
5177         * expression.h (enum innermost_block_tracker_type): Move from
5178         parser-defs.h.
5179         (parse_exp_1): Add tracker_types parameter.
5180         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5181         reset innermost_block.
5182
5183 2019-03-23  Tom Tromey  <tom@tromey.com>
5184
5185         * objfiles.h: Include bcache.h.
5186
5187 2019-03-23  Tom Tromey  <tom@tromey.com>
5188
5189         * linespec.c (get_current_search_block): Use
5190         scoped_restore_current_language.
5191         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5192
5193 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5194             Jiong Wang  <jiong.wang@arm.com>
5195
5196         * aarch64-linux-tdep.c
5197         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5198         section.
5199         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5200
5201 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5202             Jiong Wang  <jiong.wang@arm.com>
5203
5204         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5205         instructions.
5206         (aarch64_analyze_prologue_test): Add PACIASP test.
5207         (aarch64_prologue_prev_register): Unmask PC value.
5208
5209 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5210             Jiong Wang  <jiong.wang@arm.com>
5211
5212         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5213         (aarch64_dwarf2_prev_register): Unmask PC value.
5214         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5215         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5216         DW_CFA_AARCH64_negate_ra_state.
5217         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5218
5219 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5220             Jiong Wang  <jiong.wang@arm.com>
5221
5222         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5223         registers.
5224         (aarch64_pseudo_register_name): Likewise.
5225         (aarch64_pseudo_register_type): Likewise.
5226         (aarch64_pseudo_register_reggroup_p): Likewise.
5227         (aarch64_gdbarch_init): Add pauth registers.
5228         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5229         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5230         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5231         (struct gdbarch_tdep): Add regnum for ra_state.
5232
5233 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5234             Jiong Wang  <jiong.wang@arm.com>
5235
5236         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5237
5238 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5239             Jiong Wang  <jiong.wang@arm.com>
5240
5241         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5242         function.
5243         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5244         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5245         (aarch64_gdbarch_init): Add puth registers.
5246         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5247         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5248         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5249
5250 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5251             Jiong Wang  <jiong.wang@arm.com>
5252
5253         * aarch64-linux-nat.c
5254         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5255         * aarch64-linux-tdep.c
5256         (aarch64_linux_core_read_description): Likewise.
5257         (aarch64_linux_get_hwcap): New function.
5258         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5259         (aarch64_linux_get_hwcap): New declaration.
5260
5261 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5262             Jiong Wang  <jiong.wang@arm.com>
5263
5264         * aarch64-linux-nat.c
5265         (aarch64_linux_nat_target::read_description): Add pauth param.
5266         * aarch64-linux-tdep.c
5267         (aarch64_linux_core_read_description): Likewise.
5268         * aarch64-tdep.c (struct target_desc): Add in pauth.
5269         (aarch64_read_description): Add pauth param.
5270         (aarch64_gdbarch_init): Likewise.
5271         * aarch64-tdep.h (aarch64_read_description): Likewise.
5272         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5273         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5274         * features/Makefile: Add new files.
5275         * features/aarch64-pauth.c: New file.
5276         * features/aarch64-pauth.xml: New file.
5277
5278 2019-03-20  Tom Tromey  <tromey@adacore.com>
5279
5280         * infrun.c (handle_inferior_event): Rename from
5281         handle_inferior_event_1.  Create a scoped_value_mark.
5282         (handle_inferior_event): Remove.
5283
5284 2019-03-19  Tom Tromey  <tromey@adacore.com>
5285
5286         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5287         * infrun.h (print_stop_event): Add "displays" parameter.
5288         * infrun.c (print_stop_event): Add "displays" parameter.
5289
5290 2019-03-19  Pedro Alves  <palves@redhat.com>
5291
5292         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5293         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5294         to -1.  Fix TABs vs spaces.
5295         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5296         * tui/tui-out.h (tui_ui_out) Add intro comments.
5297         <m_line, m_start_of_line>: In-class initialize, and add describing
5298         comment.
5299
5300 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5301
5302         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5303         variable names.
5304         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5305
5306 2019-03-18  Pedro Alves  <palves@redhat.com>
5307             Eli Zaretskii <eliz@gnu.org>
5308
5309         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5310         m_line and m_start_of_line.
5311
5312 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5313
5314         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5315         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5316         it returns a newline.  This fixes a regression in TU mode, whereby
5317         the next line is output on the same screen line as the user input.
5318
5319 2019-03-18  Tom Tromey  <tromey@adacore.com>
5320
5321         * minsyms.c (minimal_symbol_reader::install): Remove call to
5322         obstack_blank.
5323
5324 2019-03-18  Pedro Alves  <palves@redhat.com>
5325
5326         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5327         New globals.
5328         (apply_style): New, factored out from ...
5329         (apply_ansi_escape): ... this.  Handle reverse video mode.
5330         (tui_set_reverse_mode): New function.
5331         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5332         * tui/tui-winsource.c (tui_show_source_line): Use
5333         tui_set_reverse_mode instead of setting A_STANDOUT.
5334         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5335         New setter methods.
5336
5337 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5338
5339         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5340         Handle tabs.
5341
5342 2019-03-18  Tom Tromey  <tromey@adacore.com>
5343
5344         * ada-lang.c (empty_array): Add "high" parameter.
5345         (ada_evaluate_subexp): Update.
5346
5347 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5348
5349         * unittests/string_view-selftests.c: Define
5350         _initialize_string_view_selftests unconditionally.
5351
5352 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5353
5354         PR gdb/24350
5355         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5356
5357 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5358
5359         PR gdb/24351
5360         * windows-nat.c (display_selector): Fix format specifiers.
5361
5362 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5363
5364         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5365         tui_refill_source_window instead of tui_refresh_win, to update the
5366         current execution line.  This fixes redisplay of the current line
5367         when stepping through the code with "next" or "step".
5368
5369 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5370
5371         * source-cache.c (source_cache::get_source_lines): Call
5372         find_source_lines to initialize s->nlines.  This fixes vertical
5373         scrolling of TUI source window when the DOWN arrow is pressed.
5374
5375 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5376
5377         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5378         linux-thread-db.c (_initialize_thread_db): Likewise.
5379
5380 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5381
5382         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5383         wclrtoeol in tui_show_source_line".  This reverts changes made in
5384         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5385
5386 2019-03-15  Tom Tromey  <tom@tromey.com>
5387
5388         * symtab.h (struct minimal_symbol): Derive from
5389         general_symbol_info.
5390         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5391         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5392         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5393         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5394         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5395         (MSYMBOL_SEARCH_NAME): Update.
5396         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5397         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5398         * minsyms.c (minimal_symbol_reader::record_full): Update.
5399
5400 2019-03-15  Tom Tromey  <tom@tromey.com>
5401
5402         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5403
5404 2019-03-15  Tom Tromey  <tom@tromey.com>
5405
5406         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5407         unique_xmalloc_ptr.
5408         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5409         Update.
5410         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5411         (build_minimal_symbol_hash_tables)
5412         (minimal_symbol_reader::install): Update.
5413
5414 2019-03-15  Tom Tromey  <tom@tromey.com>
5415
5416         * symtab.c (create_demangled_names_hash): Update.
5417         (symbol_set_names): Update.
5418         * objfiles.h (struct objfile_per_bfd_storage)
5419         <demangled_names_hash>: Now an htab_up.
5420         * objfiles.c (objfile_per_bfd_storage): Simplify.
5421
5422 2019-03-15  Tom Tromey  <tom@tromey.com>
5423
5424         * objfiles.h (struct objfile_per_bfd_storage): Declare
5425         destructor.
5426         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5427         New.
5428         (get_objfile_bfd_data): Use new.  Don't initialize
5429         language_of_main.
5430         (free_objfile_per_bfd_storage): Remove.
5431         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5432
5433 2019-03-15  Tom Tromey  <tom@tromey.com>
5434
5435         * symfile.c (reread_symbols): Update.
5436         * objfiles.c (objfile::objfile): Update.
5437         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5438         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5439         comment.
5440         (minimal_symbol_reader::install): Update.
5441         (terminate_minimal_symbol_table): Remove.
5442         * jit.c (jit_object_close_impl): Update.
5443
5444 2019-03-15  Tom Tromey  <tom@tromey.com>
5445
5446         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5447         initializations.
5448
5449 2019-03-15  Tom Tromey  <tom@tromey.com>
5450
5451         * objfiles.h (struct objfile_per_bfd_storage)
5452         <demangled_hash_languages>: Now a bitset.
5453         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5454         (lookup_minimal_symbol): Update.
5455
5456 2019-03-15  Tom Tromey  <tom@tromey.com>
5457
5458         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5459         Don't return the symbol.
5460         * coffread.c (record_minimal_symbol): Use record_full.
5461
5462 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5463
5464         The MS-Windows port of ncurses fails to switch to a color pair if
5465         one or both of the colors are the implicit default colors.  This
5466         change records the default colors when TUI is initialized, and
5467         then specifies them explicitly when a color pair uses the default
5468         colors.  This allows color styling in TUI mode on MS-Windows.
5469
5470         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5471         ncurses_norm_attr.
5472         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5473         colors in ncurses_norm_attr.
5474         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5475         "none", replace it with the default color recorded in
5476         ncurses_norm_attr.
5477
5478 2019-03-14  Tom Tromey  <tromey@adacore.com>
5479
5480         * source-cache.h (class source_cache) <get_source_lines>: Return
5481         std::string.
5482         * source-cache.c (source_cache::extract_lines): Handle case where
5483         first_pos==npos.  Return std::string.
5484         (source_cache::get_source_lines): Update.
5485
5486 2019-03-14  Tom Tromey  <tromey@adacore.com>
5487
5488         * NEWS: Add item for "style sources" commands.
5489         * source-cache.c (source_cache::get_source_lines): Check
5490         source_styling.
5491         * cli/cli-style.c (source_styling): New global.
5492         (_initialize_cli_style): Add "style sources" commands.
5493         (show_style_sources): New function.
5494         * cli/cli-style.h (source_styling): Declare.
5495
5496 2019-03-14  Pedro Alves  <palves@redhat.com>
5497             Tom Tromey  <tromey@adacore.com>
5498
5499         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5500         * tui/tui-winsource.c (tui_refill_source_window): New function,
5501         from...
5502         (tui_horizontal_source_scroll): ... here.  Move some logic.
5503         * cli/cli-style.c (set_style_enabled): Notify new observable.
5504         * tui/tui-hooks.c (tui_redisplay_source): New function.
5505         (tui_attach_detach_observers): Attach or detach
5506         tui_redisplay_source.
5507         * observable.h (source_styling_changed): New observable.
5508         * observable.c: Define source_styling_changed observable.
5509
5510 2019-03-13  Tom Tromey  <tromey@adacore.com>
5511
5512         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5513         (i386_gnu_nat_target::store_registers): Update.
5514         * target-debug.h (target_debug_print_std_string): New macro.
5515         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5516         * windows-tdep.c (display_one_tib): Update.
5517         * tui/tui-stack.c (tui_make_status_line): Update.
5518         * top.c (print_inferior_quit_action): Update.
5519         * thread.c (thr_try_catch_cmd): Update.
5520         (add_thread_with_info): Update.
5521         (thread_target_id_str): Update.
5522         (thr_try_catch_cmd): Update.
5523         (thread_command): Update.
5524         (thread_find_command): Update.
5525         * record-btrace.c (record_btrace_target::info_record)
5526         (record_btrace_resume_thread, record_btrace_target::resume)
5527         (record_btrace_cancel_resume, record_btrace_step_thread)
5528         (record_btrace_target::wait, record_btrace_target::wait)
5529         (record_btrace_target::wait, record_btrace_target::stop): Update.
5530         * progspace.c (print_program_space): Update.
5531         * process-stratum-target.c
5532         (process_stratum_target::thread_address_space): Update.
5533         * linux-fork.c (linux_fork_mourn_inferior)
5534         (detach_checkpoint_command, info_checkpoints_command)
5535         (linux_fork_context): Update.
5536         (linux_fork_detach): Update.
5537         (class scoped_switch_fork_info): Update.
5538         (delete_checkpoint_command): Update.
5539         * infrun.c (follow_fork_inferior): Update.
5540         (follow_fork_inferior): Update.
5541         (proceed_after_vfork_done): Update.
5542         (handle_vfork_child_exec_or_exit): Update.
5543         (follow_exec): Update.
5544         (displaced_step_prepare_throw): Update.
5545         (displaced_step_restore): Update.
5546         (start_step_over): Update.
5547         (resume_1): Update.
5548         (clear_proceed_status_thread): Update.
5549         (proceed): Update.
5550         (print_target_wait_results): Update.
5551         (do_target_wait): Update.
5552         (context_switch): Update.
5553         (stop_all_threads): Update.
5554         (restart_threads): Update.
5555         (finish_step_over): Update.
5556         (handle_signal_stop): Update.
5557         (switch_back_to_stepped_thread): Update.
5558         (keep_going_pass_signal): Update.
5559         (print_exited_reason): Update.
5560         (normal_stop): Update.
5561         * inferior.c (inferior_pid_to_str): Change return type.
5562         (print_selected_inferior): Update.
5563         (add_inferior): Update.
5564         (detach_inferior): Update.
5565         * dummy-frame.c (fprint_dummy_frames): Update.
5566         * dcache.c (dcache_info_1): Update.
5567         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5568         (btrace_fetch, btrace_clear): Update.
5569         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5570         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5571         type.
5572         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5573         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5574         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5575         * gdbarch.c, gdbarch.h: Rebuild.
5576         * gdbarch.sh (core_pid_to_str): Change return type.
5577         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5578         return type.
5579         (windows_nat_target::pid_to_str): Change return type.
5580         (windows_delete_thread): Update.
5581         (windows_nat_target::attach): Update.
5582         (windows_nat_target::files_info): Update.
5583         * target-delegates.c: Rebuild.
5584         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5585         return type.
5586         (sol_thread_target::pid_to_str): Change return type.
5587         * remote.c (class remote_target) <pid_to_str>: Change return
5588         type.
5589         (remote_target::pid_to_str): Change return type.
5590         (extended_remote_target::attach, remote_target::remote_stop_ns)
5591         (remote_target::remote_notif_remove_queued_reply)
5592         (remote_target::push_stop_reply, remote_target::disable_btrace):
5593         Update.
5594         (extended_remote_target::attach): Update.
5595         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5596         type.
5597         (gdbsim_target::pid_to_str): Change return type.
5598         * ravenscar-thread.c (struct ravenscar_thread_target)
5599         <pid_to_str>: Change return type.
5600         (ravenscar_thread_target::pid_to_str): Change return type.
5601         * procfs.c (class procfs_target) <pid_to_str>: Change return
5602         type.
5603         (procfs_target::pid_to_str): Change return type.
5604         (procfs_target::attach): Update.
5605         (procfs_target::detach): Update.
5606         (procfs_target::fetch_registers): Update.
5607         (procfs_target::store_registers): Update.
5608         (procfs_target::wait): Update.
5609         (procfs_target::files_info): Update.
5610         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5611         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5612         return type.
5613         (nto_procfs_target::pid_to_str): Change return type.
5614         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5615         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5616         return type.
5617         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5618         (exit_lwp): Update.
5619         (attach_proc_task_lwp_callback, get_detach_signal)
5620         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5621         (linux_nat_target::resume, wait_lwp, stop_callback)
5622         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5623         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5624         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5625         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5626         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5627         type.
5628         (inf_ptrace_target::attach): Update.
5629         (inf_ptrace_target::files_info): Update.
5630         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5631         type.
5632         (go32_nat_target::pid_to_str): Change return type.
5633         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5634         (gnu_nat_target::wait): Update.
5635         (gnu_nat_target::wait): Update.
5636         (gnu_nat_target::resume): Update.
5637         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5638         (fbsd_nat_target::wait): Update.
5639         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5640         type.
5641         (darwin_nat_target::attach): Update.
5642         * corelow.c (class core_target) <pid_to_str>: Change return type.
5643         (core_target::pid_to_str): Change return type.
5644         * target.c (normal_pid_to_str): Change return type.
5645         (default_pid_to_str): Likewise.
5646         (target_pid_to_str): Change return type.
5647         (target_translate_tls_address): Update.
5648         (target_announce_detach): Update.
5649         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5650         return type.
5651         (bsd_uthread_target::pid_to_str): Change return type.
5652         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5653         type.
5654         (bsd_kvm_target::pid_to_str): Change return type.
5655         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5656         return type.
5657         (aix_thread_target::pid_to_str): Change return type.
5658         * target.h (struct target_ops) <pid_to_str>: Change return type.
5659         (target_pid_to_str, normal_pid_to_str): Likewise.
5660         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5661         type.
5662         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5663         type.
5664         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5665         return type.
5666         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5667         type.
5668         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5669         type.
5670         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5671         return type.
5672
5673 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5674
5675         * NEWS: Mention that the new default MI version is 3.  Mention
5676         changes to the output of commands and events that deal with
5677         multi-location breakpoints.
5678         * breakpoint.c: Include "mi/mi-out.h".
5679         (print_one_breakpoint): Change output syntax if using MI version
5680         >= 3.
5681         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5682         New.
5683         (mi_multi_location_breakpoint_output_fixed): New.
5684         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5685         (mi_cmd_fix_multi_location_breakpoint_output): New.
5686         (mi_multi_location_breakpoint_output_fixed): New.
5687         * mi/mi-cmds.c (mi_cmds): Register command
5688         -fix-multi-location-breakpoint-output.
5689         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5690         interpreter "mi".
5691
5692 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5693
5694         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5695         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5696         instantiate mi_ui_out based on interpreter name.
5697         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5698         * mi/mi-main.c (mi_load_progress): Likewise.
5699
5700 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5701
5702         * NEWS: Combine separate "New targets" sections for 8.3.
5703
5704 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5705
5706         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5707         (ppcfbsd_init_abi): Install gdbarch
5708         "fetch_tls_load_module_address" and "get_thread_local_address"
5709         methods.
5710
5711 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5712
5713         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5714         (riscv_fbsd_init_abi): Install gdbarch
5715         "fetch_tls_load_module_address" and "get_thread_local_address"
5716         methods.
5717
5718 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5719
5720         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5721         (i386fbsd_init_abi): Install gdbarch
5722         "fetch_tls_load_module_address" and "get_thread_local_address"
5723         methods.
5724
5725 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5726
5727         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5728         (amd64fbsd_init_abi): Install gdbarch
5729         "fetch_tls_load_module_address" and "get_thread_local_address"
5730         methods.
5731
5732 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5733
5734         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5735         (struct fbsd_pspace_data): New type.
5736         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5737         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5738         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5739         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5740         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5741
5742 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5743
5744         * gdbtypes.c (lookup_struct_elt): New function.
5745         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5746         * gdbtypes.h (struct struct_elt): New type.
5747         (lookup_struct_elt): New prototype.
5748
5749 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5750
5751         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5752         remove disabled code block.
5753
5754 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5755
5756         * gdbarch.sh (get_thread_local_address): New method.
5757         * gdbarch.h, gdbarch.c: Regenerate.
5758         * target.c (target_translate_tls_address): Use
5759         gdbarch_get_thread_local_address if present instead of
5760         target::get_thread_local_address.
5761
5762 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5763
5764         * target.h (target::get_thread_local_address): Update comment.
5765
5766 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5767
5768         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5769         objfile->separate_debug_objfile_backlink if not NULL.
5770
5771 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5772
5773         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5774         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5775         (amd64bsd_store_inferior_registers): Likewise.
5776         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5777         Enable segment base registers.
5778         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5779         PT_GETFSBASE and PT_GETGSBASE.
5780         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5781         PT_SETGSBASE.
5782         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5783         segment base registers.
5784         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5785
5786 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5787
5788         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5789         Update calls to i386_target_description to add 'segments'
5790         parameter.
5791         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5792         add segment base registers.
5793         * arch/i386.c (i386_create_target_description): Add 'segments'
5794         parameter to enable segment base registers.
5795         * arch/i386.h (i386_create_target_description): Likewise.
5796         * features/i386/32bit-segments.xml: New file.
5797         * features/i386/32bit-segments.c: Generate.
5798         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5799         call to i386_target_description to add 'segments' parameter.
5800         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5801         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5802         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5803         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5804         if feature is present.
5805         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5806         Add 'segments' parameter to call to i386_target_description.
5807         (i386_target_description): Add 'segments' parameter to enable
5808         segment base registers.
5809         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5810         to call to i386_target_description.
5811         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5812         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5813         Define I386_NUM_REGS.
5814         (i386_target_description): Add 'segments' parameter to enable
5815         segment base registers.
5816
5817 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5818
5819         PR/24325
5820         * source-cache.c: #undef open and close, to avoid unresolved
5821         externals during linking.
5822
5823 2019-03-12  Tom Tromey  <tromey@adacore.com>
5824
5825         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5826         const.  Add initializers.
5827         (_initialize_remote): Don't initialize ptid globals.
5828
5829 2019-03-12  Pedro Alves  <palves@redhat.com>
5830
5831         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5832
5833 2019-03-12  Pedro Alves  <palves@redhat.com>
5834
5835         * cp-name-parser.y (main): Remove unused 'len' variable.
5836
5837 2019-03-12  Tom Tromey  <tromey@adacore.com>
5838
5839         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5840         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5841
5842 2019-03-12  Tom Tromey  <tromey@adacore.com>
5843
5844         * linux-nat.c (iterate_over_lwps): Update.
5845         (stop_callback): Remove parameter.
5846         (stop_wait_callback, detach_callback, resume_set_callback)
5847         (select_singlestep_lwp_callback, set_ignore_sigint)
5848         (status_callback, resumed_callback, resume_clear_callback)
5849         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5850         data parameter.
5851         (linux_nat_target::detach, linux_nat_target::resume)
5852         (linux_stop_and_wait_all_lwps, select_event_lwp)
5853         (linux_nat_filter_event, linux_nat_wait_1)
5854         (linux_nat_target::kill, linux_nat_target::stop)
5855         (linux_nat_target::stop): Update.
5856         (linux_nat_resume_callback): Change type.
5857         (resume_stopped_resumed_lwps, count_events_callback)
5858         (select_event_lwp_callback): Likewise.
5859         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5860         * arm-linux-nat.c (struct update_registers_data): Remove.
5861         (update_registers_callback): Change type.
5862         (arm_linux_insert_hw_breakpoint1): Update.
5863         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5864         parameter.
5865         (x86_linux_dr_set_addr): Update.
5866         (x86_linux_dr_set_control): Update.
5867         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5868         (iterate_over_lwps): Use gdb::function_view.
5869         * nat/aarch64-linux-hw-point.c (struct
5870         aarch64_dr_update_callback_param): Remove.
5871         (debug_reg_change_callback): Change type.
5872         (aarch64_notify_debug_reg_change): Update.
5873         * s390-linux-nat.c (s390_refresh_per_info): Update.
5874
5875 2019-03-11  Tom Tromey  <tromey@adacore.com>
5876
5877         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5878         redundant assignment to "this_cu".
5879
5880 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5881
5882         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5883
5884 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5885
5886         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5887         from...
5888         (rank_one_type): ... this.
5889
5890 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5891
5892         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5893         from...
5894         (rank_one_type): ... this.
5895
5896 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5897
5898         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5899         from...
5900         (rank_one_type): ... this.
5901
5902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5903
5904         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5905         from...
5906         (rank_one_type): ... this.
5907
5908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5909
5910         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5911         from...
5912         (rank_one_type): ... this.
5913
5914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5915
5916         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5917         from...
5918         (rank_one_type): ... this.
5919
5920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5921
5922         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5923         from...
5924         (rank_one_type): ... this.
5925
5926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5927
5928         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5929         from...
5930         (rank_one_type): ... this.
5931
5932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5933
5934         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5935         from...
5936         (rank_one_type): ... this.
5937
5938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5939
5940         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5941         from...
5942         (rank_one_type): ... this.
5943
5944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5945
5946         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5947         from...
5948         (rank_one_type): ... this.
5949
5950 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5951
5952         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5953         from...
5954         (rank_one_type): ... this.
5955
5956 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5957
5958         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5959         inferior-events' shows the example events.
5960
5961 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5962
5963         Support styling on native MS-Windows console
5964
5965         PR/24315
5966         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5967         on MS-Windows if $TERM is not defined.
5968
5969         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5970
5971         * posix-hdep.c (gdb_console_fputs):
5972         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5973         functions.
5974         * ui-file.h (gdb_console_fputs): Add prototype.
5975
5976         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5977         back to fputs only if the former returns zero.
5978
5979 2019-03-07  Tom Tromey  <tom@tromey.com>
5980
5981         * symmisc.c (print_symbol_bcache_statistics): Update.
5982         (print_objfile_statistics): Update.
5983         * symfile.c (allocate_symtab): Update.
5984         * stabsread.c: Don't include bcache.h.
5985         * psymtab.h (struct psymbol_bcache): Don't declare.
5986         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5987         (psymbol_bcache_init, psymbol_bcache_free)
5988         (psymbol_bcache_get_bcache): Don't declare.
5989         * psymtab.c (struct psymbol_bcache): Remove.
5990         (psymtab_storage::psymtab_storage): Update.
5991         (psymtab_storage::~psymtab_storage): Update.
5992         (psymbol_bcache_init, psymbol_bcache_free)
5993         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5994         (add_psymbol_to_bcache): Update.
5995         (allocate_psymtab): Update.
5996         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5997         macro_cache>: No longer pointers.
5998         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5999         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6000         * macrotab.c (macro_bcache): Update.
6001         * macroexp.c: Don't include bcache.h.
6002         * gdbtypes.c (check_types_worklist): Update.
6003         (types_deeply_equal): Remove TRY/CATCH.  Update.
6004         * elfread.c (elf_symtab_read): Update.
6005         * dwarf2read.c: Don't include bcache.h.
6006         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6007         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6008         (print_bcache_statistics, bcache_memory_used): Don't declare.
6009         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6010         methods.  Rename all data members.
6011         * bcache.c (struct bcache): Move to bcache.h.
6012         (bcache::expand_hash_table): Rename from expand_hash_table.
6013         (bcache): Remove.
6014         (bcache::insert): Rename from bcache_full.
6015         (bcache::compare): Rename from bcache_compare.
6016         (bcache_xmalloc): Remove.
6017         (bcache::~bcache): Rename from bcache_xfree.
6018         (bcache::print_statistics): Rename from print_bcache_statistics.
6019         (bcache::memory_used): Rename from bcache_memory_used.
6020
6021 2019-03-07  Pedro Alves  <palves@redhat.com>
6022
6023         * infrun.c (normal_stop): Also check for
6024         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6025
6026 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6027
6028         * f-lang.c (value_from_host_double): Moved to...
6029         * value.c (value_from_host_double): ...here.
6030         * value.h (value_from_host_double): Declare.
6031         * guile/scm-math.c (vlscm_convert_typed_number): Use
6032         value_from_host_double.
6033         (vlscm_convert_number): Likewise.
6034         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6035         * python/py-value.c (convert_value_from_python): Likewise.
6036
6037 2019-03-06  Tom Tromey  <tom@tromey.com>
6038
6039         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6040
6041 2019-03-06  Tom Tromey  <tom@tromey.com>
6042
6043         * utils.h (free_current_contents): Don't declare.
6044         * utils.c (free_current_contents): Remove.
6045
6046 2019-03-06  Tom Tromey  <tom@tromey.com>
6047
6048         * top.c (quit_force): Update.
6049         * main.c (captured_command_loop): Update.
6050         * common/new-op.c (operator new): Update.
6051         * common/common-exceptions.c (struct catcher)
6052         <save_cleanup_chain>: Remove member.
6053         (exceptions_state_mc_init): Update.
6054         (exception_try_scope_entry): Return nullptr.
6055         (exception_try_scope_exit, exception_rethrow)
6056         (throw_exception_sjlj, throw_exception_cxx): Update.
6057         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6058         (all_cleanups, do_cleanups, discard_cleanups)
6059         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6060         (restore_cleanups, restore_final_cleanups): Don't declare.
6061         (do_final_cleanups): Remove parameter.
6062         * common/cleanups.c (cleanup_chain, make_cleanup)
6063         (make_cleanup_dtor, all_cleanups, do_cleanups)
6064         (discard_my_cleanups, discard_cleanups)
6065         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6066         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6067         (null_cleanup): Remove.
6068         (do_final_cleanups): Remove parameter.
6069
6070 2019-03-06  Tom Tromey  <tom@tromey.com>
6071
6072         * remote.c (remote_target::remote_parse_stop_reply): Use
6073         unique_xmalloc_ptr.
6074
6075 2019-03-06  Tom Tromey  <tom@tromey.com>
6076
6077         * stabsread.c (struct stabs_field_info): Rename from field_info.
6078         <list, fnlist>: Add initializers.
6079         <obstack>: New member.
6080         (read_member_functions, read_struct_fields, read_baseclasses):
6081         Allocate on obstack.  Don't use cleanups.
6082         (read_one_struct_field, read_member_functions, read_struct_fields)
6083         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6084         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6085         (read_struct_type): Update.
6086
6087 2019-03-06  Tom Tromey  <tom@tromey.com>
6088
6089         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6090         * common/filestuff.h (make_cleanup_close): Don't declare.
6091         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6092         Remove.
6093
6094 2019-03-06  Tom Tromey  <tom@tromey.com>
6095
6096         * solib-aix.c: Use make_scope_exit.
6097
6098 2019-03-06  Tom Tromey  <tom@tromey.com>
6099
6100         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6101         Use make_scope_exit.
6102
6103 2019-03-06  Tom Tromey  <tom@tromey.com>
6104
6105         * solib-svr4.c (disable_probes_interface): Remove parameter.
6106         (svr4_handle_solib_event): Use make_scope_exit.
6107
6108 2019-03-06  Tom Tromey  <tom@tromey.com>
6109
6110         * remote.c (struct stop_reply_deleter): Remove.
6111         (stop_reply_up): Update.
6112         (struct stop_reply): Derive from notif_event.  Don't typedef.
6113         <regcache>: Now a std::vector.
6114         (stop_reply_xfree): Remove.
6115         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6116         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6117         (remote_target::discard_pending_stop_replies): Use delete.
6118         (remote_target::remote_parse_stop_reply): Update.
6119         (remote_target::process_stop_reply): Update.
6120         * remote-notif.h (struct notif_event): Add virtual destructor.
6121         Remove "dtr" member.
6122         (struct notif_client) <alloc_event>: Return a unique_ptr.
6123         (notif_event_xfree): Don't declare.
6124         (notif_event_up): New typedef.
6125         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6126         (notif_event_xfree, do_notif_event_xfree): Remove.
6127         (remote_notif_state_xfree): Update.
6128
6129 2019-03-06  Tom Tromey  <tom@tromey.com>
6130
6131         * infrun.c (displaced_step_clear_cleanup): Now a
6132         forward_scope_exit type.
6133         (displaced_step_prepare_throw): Update.
6134         (displaced_step_fixup): Update.
6135
6136 2019-03-06  Tom Tromey  <tom@tromey.com>
6137
6138         * inferior.h (class inferior): Update comment.
6139         * gdbthread.h (class thread_info): Update comment.
6140
6141 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6142             Tom Tromey  <tom@tromey.com>
6143
6144         * stabsread.h (struct stab_section_list): Remove.
6145         (coffstab_build_psymtabs): Update.
6146         * dbxread.c (symbuf_sections): Now a std::vector.
6147         (sect_idx): New global.
6148         (fill_symbuf): Update.
6149         (coffstab_build_psymtabs): Change type of stabsects parameter.
6150         Update.
6151         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6152         std::vector.
6153         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6154         (coff_locate_sections): Update.
6155         (coff_symfile_read): Remove cleanups.  Update.
6156         (init_stringtab): Add storage parameter.
6157         (free_stringtab, free_stringtab_cleanup): Remove.
6158         (init_lineno): Add storage parameter.
6159         (free_linetab, free_linetab_cleanup): Remove.
6160
6161 2019-03-06  Pedro Alves  <palves@redhat.com>
6162
6163         * linux-fork.c (fork_info::clobber_regs): Delete.
6164         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6165         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6166         comment.  Adjust.
6167         (scoped_switch_fork_info::scoped_switch_fork_info)
6168         (checkpoint_command, linux_fork_context): Adjust
6169         fork_save_infrun_state calls.
6170
6171 2019-03-06  Pedro Alves  <palves@redhat.com>
6172
6173         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6174         (inf_has_multiple_threads): Return 'bool' and rewrite using
6175         inferior_info::threads().
6176
6177 2019-03-06  Pedro Alves  <palves@redhat.com>
6178
6179         * linux-fork.c: Include <list>.
6180         (fork_list): Now a std::list instance.
6181         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6182         (forks_exist_p, find_last_fork): Adjust.
6183         (new_fork): Delete.
6184         (one_fork_p): New.
6185         (add_fork): Adjust.
6186         (free_fork): Delete, folded into fork_info::~fork_info().
6187         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6188         Adjust.
6189         (init_fork_list): Delete.
6190         (linux_fork_killall, linux_fork_mourn_inferior)
6191         (linux_fork_detach, info_checkpoints_command): Adjust.
6192         (_initialize_linux_fork): No longer call init_fork_list.
6193
6194 2019-03-06  Pedro Alves  <palves@redhat.com>
6195
6196         * linux-fork.c (new_fork): New, split out of ...
6197         (add_fork): ... this.  Return void.  Move "first fork" special
6198         case from here, to ...
6199         (checkpoint_command): ... here.
6200         * linux-linux.h (add_fork): Return void.
6201
6202 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6203
6204         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6205
6206 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6207             Chris January  <chris.january@arm.com>
6208             David Lecomber  <david.lecomber@arm.com>
6209
6210         * f-exp.y: New token, UNOP_INTRINSIC.
6211         (exp): New pattern using UNOP_INTRINSIC token.
6212         (f77_keywords): Add 'abs' keyword.
6213         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6214         (value_from_host_double): New function.
6215         (evaluate_subexp_f): Support UNOP_ABS.
6216
6217 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6218
6219         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6220         types.
6221
6222 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6223
6224         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6225         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6226         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6227
6228 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6229
6230         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6231
6232 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6233             Chris January  <chris.january@arm.com>
6234
6235         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6236         * f-exp.y: Define 'KIND' token.
6237         (exp): New pattern for KIND expressions.
6238         (ptype): Handle types with a kind extension.
6239         (direct_abs_decl): Extend to spot kind extensions.
6240         (f77_keywords): Add 'kind' to the list.
6241         (push_kind_type): New function.
6242         (convert_to_kind_type): New function.
6243         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6244         * parse.c (operator_length_standard): Likewise.
6245         * parser-defs.h (enum type_pieces): Add tp_kind.
6246         * std-operator.def: Add UNOP_KIND.
6247
6248 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6249
6250         * f-exp.y (f_parse): Set yydebug.
6251
6252 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6253
6254         * f-lang.c (evaluate_subexp_f): New function.
6255         (exp_descriptor_f): New global.
6256         (f_language_defn): Use exp_descriptor_f instead of
6257         exp_descriptor_standard.
6258
6259 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6260
6261         * f-exp.y (struct token): Add comments.
6262         (dot_ops): Remove uppercase versions and the end marker.
6263         (f77_keywords): Likewise.
6264         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6265         entries in the dot_ops array are case insensitive, and use
6266         strncasecmp to compare strings.  Also some whitespace cleanup in
6267         this area.  Similar for the f77_keywords array, except entries in
6268         this list might be case sensitive.
6269
6270 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6271
6272         * f-exp.y (struct f77_boolean_val): Add comments.
6273         (boolean_values): Remove uppercase versions, and end marker.
6274         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6275         and use strncasecmp to achieve case insensitivity.  Additionally,
6276         perform whitespace cleanup around this code.
6277
6278 2019-03-06  Tom Tromey  <tromey@adacore.com>
6279
6280         * remote-sim.c (gdbsim_target_open): Use result of
6281         gdb_argv::release.
6282
6283 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6284         Dirk Schubert  <dirk.schubert@arm.com>
6285         Chris January  <chris.january@arm.com>
6286
6287         * eval.c (evaluate_subexp_standard): Call Fortran argument
6288         wrapping logic.
6289         * f-lang.c (struct value): A value which can be passed into a
6290         Fortran function call.
6291         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6292         where appropriate.
6293         (struct type): Value ready for a Fortran function call.
6294         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6295         is needed.
6296         * f-lang.h (fortran_argument_convert): Declaration.
6297         (fortran_preserve_arg_pointer): Declaration.
6298         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6299
6300 2019-03-05  Tom Tromey  <tromey@adacore.com>
6301
6302         * python/py-prettyprint.c (print_string_repr): Remove #if.
6303         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6304
6305 2019-03-05  Tom Tromey  <tromey@adacore.com>
6306
6307         * target.c (the_dummy_target): Move later.  Change type to
6308         "dummy_target".
6309         (initialize_targets): Don't initialize the_dummy_target.
6310
6311 2019-03-05  Tom Tromey  <tromey@adacore.com>
6312
6313         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6314         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6315
6316 2019-03-05  Tom Tromey  <tromey@adacore.com>
6317
6318         * windows-nat.c (windows_nat_target::attach)
6319         (windows_nat_target::detach): Don't call gdb_flush.
6320         * valprint.c (generic_val_print, val_print, val_print_string):
6321         Don't call gdb_flush.
6322         * utils.c (defaulted_query): Don't call gdb_flush.
6323         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6324         * target.c (target_announce_detach): Don't call gdb_flush.
6325         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6326         * remote.c (extended_remote_target::attach): Don't call
6327         gdb_flush.
6328         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6329         * printcmd.c (do_examine): Don't call gdb_flush.
6330         (info_display_command): Don't call gdb_flush.
6331         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6332         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6333         * memattr.c (info_mem_command): Don't call gdb_flush.
6334         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6335         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6336         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6337         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6338         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6339         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6340         (gnu_nat_target::detach): Don't call gdb_flush.
6341         * f-valprint.c (f_val_print): Don't call gdb_flush.
6342         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6343         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6344         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6345         gdb_flush.
6346         * c-valprint.c (c_val_print): Don't call gdb_flush.
6347         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6348
6349 2019-03-05  Tom Tromey  <tromey@adacore.com>
6350
6351         * varobj.c (update_dynamic_varobj_children): Update.
6352         (install_default_visualizer): Use reset, not release.
6353         * value.c (set_internalvar): Update.
6354         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6355         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6356         ATTRIBUTE_UNUSED_RESULT.
6357
6358 2019-03-05  Tom Tromey  <tromey@adacore.com>
6359
6360         * remote.c (class scoped_remote_fd) <release>: Add
6361         ATTRIBUTE_UNUSED_RESULT.
6362
6363 2019-03-05  Tom Tromey  <tromey@adacore.com>
6364
6365         * macroexp.c (struct macro_buffer) <release>: Add
6366         ATTRIBUTE_UNUSED_RESULT.
6367
6368 2019-03-05  Tom Tromey  <tromey@adacore.com>
6369
6370         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6371         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6372         ATTRIBUTE_UNUSED_RESULT.
6373
6374 2019-03-05  Tom Tromey  <tromey@adacore.com>
6375
6376         * common/scoped_fd.h (class scoped_fd) <release>: Add
6377         ATTRIBUTE_UNUSED_RESULT.
6378
6379 2019-03-05  Tom Tromey  <tromey@adacore.com>
6380
6381         * parser-defs.h (struct parser_state) <release>: Add
6382         ATTRIBUTE_UNUSED_RESULT.
6383
6384 2019-03-05  Tom Tromey  <tromey@adacore.com>
6385
6386         * utils.h (class gdb_argv) <release>: Add
6387         ATTRIBUTE_UNUSED_RESULT.
6388         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6389
6390 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6391
6392         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6393         for-loop range, to avoid compiler warnings.
6394
6395         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6396         avoid compiler warnings about unused variables.
6397
6398         * NEWS: Mention end of support for native debugging on MS-Windows
6399         before XP.
6400
6401         PR gdb/24292
6402         * common/netstuff.c:
6403         * gdbserver/gdbreplay.c
6404         * gdbserver/remote-utils.c:
6405         * ser-tcp.c:
6406         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6407         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6408         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6409         'getaddrinfo' and 'freeaddrinfo' were not available before
6410         Windows XP, and mingw.org's MinGW headers by default define
6411         _WIN32_WINNT to 0x500.
6412
6413 2019-03-01  Gary Benson <gbenson@redhat.com>
6414
6415         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6416
6417 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6418             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6419
6420         PR gdb/8527
6421         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6422         set_sigint_trap, clear_sigint_trap.
6423
6424 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6425
6426         * target.c (target_detach): Clear the regcache and the
6427         frame cache.
6428
6429 2019-02-27  Pedro Alves  <palves@redhat.com>
6430
6431         * utils.c (set_screen_size): When we cap the height/width sizes,
6432         tweak the corresponding command variable to show "unlimited":
6433
6434 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6435             Pedro Alves  <palves@redhat.com>
6436
6437         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6438         before calling rl_set_screen_size.
6439
6440 2019-02-27  Tom Tromey  <tromey@adacore.com>
6441
6442         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6443         define.
6444         * python/py-value.c: Remove Python 2.4 workaround.
6445         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6446         workaround.
6447         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6448         Python 2.4 workaround.
6449         * python/python-internal.h: Remove Python 2.4 comment.
6450         (Py_ssize_t): Don't define.
6451         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6452         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6453         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6454         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6455         * python/python.c (do_start_initialization): Remove Python 2.4
6456         workaround.
6457         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6458         (print_children): Remove Python 2.4 workaround.
6459         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6460         workaround.
6461         (CHARBUFFERPROC_NAME): Remove.
6462         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6463         Python 2.4 workaround.
6464
6465 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6466
6467         * NEWS: Note minimum Python version.
6468
6469 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6470
6471         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6472         code from these functions.  Remove corresponding ifdefs.  Use
6473         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6474         Remove gotos and target of gotos.
6475         (infpy_search_memory): Likewise.
6476
6477 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6478
6479         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6480         (hppa_gdbarch_init): Don't register deleted functions with
6481         gdbarch.
6482
6483 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6484
6485         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6486         (h8300_unwind_sp): Delete.
6487         (h8300_dummy_id): Delete.
6488         (h8300_gdbarch_init): Don't register deleted functions with
6489         gdbarch.
6490
6491 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6492
6493         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6494         (ft32_unwind_pc): Delete.
6495         (ft32_unwind_sp): Delete.
6496         (ft32_gdbarch_init): Don't register deleted functions with
6497         gdbarch.
6498
6499 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6500
6501         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6502         (frv_unwind_pc): Delete.
6503         (frv_unwind_sp): Delete.
6504         (frv_gdbarch_init): Don't register deleted functions with
6505         gdbarch.
6506
6507 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6508
6509         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6510         (riscv_unwind_pc): Delete.
6511         (riscv_unwind_sp): Delete.
6512         (riscv_gdbarch_init): Don't register deleted functions with
6513         gdbarch.
6514
6515 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6516
6517         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6518         (csky_unwind_pc): Delete.
6519         (csky_unwind_sp): Delete.
6520         (csky_gdbarch_init): Don't register deleted functions with
6521         gdbarch.
6522
6523 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6524
6525         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6526         (cris_unwind_pc): Delete.
6527         (cris_unwind_sp): Delete.
6528         (cris_gdbarch_init): Don't register deleted functions with
6529         gdbarch.
6530
6531 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6532
6533         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6534         (bfin_unwind_pc): Delete.
6535         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6536
6537 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6538
6539         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6540         (arm_unwind_pc): Delete.
6541         (arm_unwind_sp): Delete.
6542         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6543
6544 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6545
6546         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6547         (arc_unwind_pc): Delete.
6548         (arc_unwind_sp): Delete.
6549         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6550
6551 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6552
6553         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6554         (alpha_unwind_pc): Delete.
6555         (alpha_gdbarch_init): Don't register deleted functions with
6556         gdbarch.
6557
6558 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6559
6560         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6561         (aarch64_unwind_pc): Delete.
6562         (aarch64_unwind_sp): Delete.
6563         (aarch64_gdbarch_init): Don't register deleted functions with
6564         gdbarch.
6565
6566 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6567
6568         * gdbtypes.c (type_align): Don't consider static members when
6569         computing structure alignment.
6570
6571 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6572
6573         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6574         return 0 for other types.
6575         * arch-utils.c (default_type_align): Always return 0.
6576         * gdbarch.h: Regenerate.
6577         * gdbarch.sh (type_align): Extend comment.
6578         * gdbtypes.c (type_align): Add additional comments, always call
6579         gdbarch_type_align before applying the default rules.
6580         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6581         generic code will then apply a suitable default.
6582         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6583         types, return 0 for other types.
6584
6585 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6586
6587         * NEWS: Create a new section for the next release branch.
6588         Rename the section of the current branch, now that it has
6589         been cut.
6590
6591 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6592
6593         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6594         * version.in: Bump version to 8.3.50.DATE-git.
6595
6596 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6597
6598         * aix-thread.c (ptid_cmp): Remove unused variable.
6599         (get_signaled_thread): Likewise.
6600         (store_regs_user_thread): Likewise.
6601         (store_regs_kernel_thread): Likewise.
6602         (fetch_regs_kernel_thread): Remove shadowed variable.
6603
6604 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6605
6606         * features/riscv/32bit-cpu.xml: Add register numbers.
6607         * features/riscv/32bit-fpu.c: Regenerate.
6608         * features/riscv/32bit-fpu.xml: Add register numbers.
6609         * features/riscv/64bit-cpu.xml: Add register numbers.
6610         * features/riscv/64bit-fpu.c: Regenerate.
6611         * features/riscv/64bit-fpu.xml: Add register numbers.
6612
6613 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6614
6615         * NEWS: Mention two argument form of gdb.Value constructor.
6616         * python/py-value.c (convert_buffer_and_type_to_value): New
6617         function.
6618         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6619         Add support for handling an optional second argument.  Call
6620         convert_buffer_and_type_to_value as appropriate.
6621         * python/python-internal.h (Py_buffer_deleter): New struct.
6622         (Py_buffer_up): New typedef.
6623
6624 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6625
6626         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6627         instead of releasing ownership.
6628
6629 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6630
6631         * dwarf2read.c (open_and_init_dwp_file): Call
6632         elf_numsections instead of bfd_count_sections to initialize
6633         dwp_file->num_sections.
6634
6635 2019-02-25  Tom Tromey  <tromey@adacore.com>
6636
6637         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6638
6639 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6640
6641         * gcore.in: Add '--readnever' option when invoking GDB.
6642
6643 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6644
6645         * MAINTAINERS: Update my email address.
6646
6647 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6648
6649         * build-id.c (build_id_to_debug_bfd_1): New function.
6650         (build_id_to_debug_bfd): Look for separate debug file in
6651         sysroot.
6652
6653 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6654
6655         * gdbarch.sh: Update the copyright year range that is placed into
6656         generated files.
6657
6658 2019-02-22  Keith Seitz  <keiths@redhat.com>
6659
6660         PR symtab/23853
6661         * linespec.c (create_sals_line_offset): Search for the default
6662         symtab's filename instead of its fullname.
6663
6664 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6665
6666         * NEWS: Update style defaults.
6667
6668 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6669
6670         * main.c (captured_main_1): Disable styling in batch mode.
6671
6672 2019-02-20  Tom Tromey  <tom@tromey.com>
6673
6674         * symtab.c (symtab_symbol_info): Fix typos.
6675
6676 2019-02-20  Tom Tromey  <tromey@adacore.com>
6677
6678         * findcmd.c (_initialize_mem_search): Use upper case for
6679         metasyntactic variables.
6680
6681 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6682
6683         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6684         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6685
6686 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6687
6688         * top.h (source_file_name): Change to std::string.
6689         * top.c (source_file_name): Likewise.
6690         (command_line_input): Adjust.
6691         * cli/cli-script.c (script_from_file): Adjust.
6692
6693 2019-02-19  Tom Tromey  <tromey@adacore.com>
6694
6695         * ravenscar-thread.c
6696         (ravenscar_thread_target::update_thread_list): Don't call
6697         ada_build_task_list.
6698         * ada-lang.h (ada_build_task_list): Don't declare.
6699         * ada-tasks.c (struct ada_tasks_inferior_data)
6700         <task_list_valid_p>: Now bool.
6701         (read_known_tasks, ada_task_list_changed)
6702         (ada_tasks_invalidate_inferior_data): Update.
6703         (read_known_tasks_array): Return bool.
6704         (read_known_tasks_list): Likewise.
6705         (read_known_tasks): Return void.
6706         (ada_build_task_list): Now static.
6707
6708 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6709
6710         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6711         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6712
6713 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6714
6715         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6716         variant for ada_tasks_pspace_data_handle and
6717         ada_tasks_inferior_data_handle.
6718         (ada_tasks_pspace_data_cleanup): New function.
6719         (ada_tasks_inferior_data_cleanup): New function.
6720
6721 2019-02-17  Tom Tromey  <tom@tromey.com>
6722
6723         * macrotab.h (macro_source_fullname): Return a std::string.
6724         * macrotab.c (macro_include, check_for_redefinition)
6725         (macro_undef, macro_lookup_definition, foreach_macro)
6726         (foreach_macro_in_scope): Update.
6727         (macro_source_fullname): Return a std::string.
6728         * macrocmd.c (show_pp_source_pos): Update.
6729
6730 2019-02-17  Tom Tromey  <tom@tromey.com>
6731
6732         * macrocmd.c (show_pp_source_pos): Style the file names.
6733
6734 2019-02-17  Tom Tromey  <tom@tromey.com>
6735
6736         PR tui/24197:
6737         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6738
6739 2019-02-17  Tom Tromey  <tom@tromey.com>
6740
6741         * ada-lang.c (user_select_syms): Use filtered printing.
6742         * utils.c (wrap_style): New global.
6743         (desired_style): Remove.
6744         (emit_style_escape): Add stream parameter.
6745         (set_output_style, reset_terminal_style, prompt_for_continue):
6746         Update.
6747         (flush_wrap_buffer): Only flush gdb_stdout.
6748         (wrap_here): Set wrap_style.
6749         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6750         treat escape sequences as a character.  Change when wrap buffer is
6751         flushed.
6752         (fputs_styled): Do not set the output style when the default is
6753         requested.
6754         * ui-style.h (struct ui_file_style) <is_default>: New method.
6755         * source.c (print_source_lines_base): Emit escape sequences in one
6756         piece.
6757
6758 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6759
6760         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6761         integers and enumeration types.
6762
6763 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6764
6765         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6766         instead of lookup_symbol_in_language
6767         (do_exact_match): New function.
6768         (ada_get_symbol_name_matcher): Return do_exact_match when
6769         doing a verbatim match.
6770
6771 2019-02-15  Tom Tromey  <tromey@adacore.com>
6772
6773         * ravenscar-thread.c (ravenscar_thread_target::resume)
6774         (ravenscar_thread_target::wait): Special case wildcard requests.
6775
6776 2019-02-15  Tom Tromey  <tromey@adacore.com>
6777
6778         * ravenscar-thread.c (base_ptid): Remove.
6779         (struct ravenscar_thread_target) <close>: New method.
6780         <m_base_ptid>: New member.
6781         <update_inferior_ptid, active_task, task_is_currently_active,
6782         runtime_initialized>: Declare methods.
6783         <ravenscar_thread_target>: Add constructor.
6784         (ravenscar_thread_target::task_is_currently_active)
6785         (ravenscar_thread_target::update_inferior_ptid)
6786         (ravenscar_runtime_initialized): Rename.  Now methods.
6787         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6788         (ravenscar_thread_target::update_thread_list): Update.
6789         (ravenscar_thread_target::active_task): Now method.
6790         (ravenscar_thread_target::store_registers)
6791         (ravenscar_thread_target::prepare_to_store)
6792         (ravenscar_thread_target::prepare_to_store)
6793         (ravenscar_thread_target::mourn_inferior): Update.
6794         (ravenscar_inferior_created): Use "new" to create target.
6795         (ravenscar_thread_target::get_ada_task_ptid): Update.
6796         (_initialize_ravenscar): Don't initialize base_ptid.
6797         (ravenscar_ops): Remove global.
6798
6799 2019-02-15  Tom Tromey  <tromey@adacore.com>
6800
6801         * target.h (push_target): Declare new overload.
6802         * target.c (push_target): New overload, taking an rvalue reference.
6803         * remote.c (remote_target::open_1): Use push_target overload.
6804         * corelow.c (core_target_open): Use push_target overload.
6805
6806 2019-02-15  Tom Tromey  <tromey@adacore.com>
6807
6808         * ravenscar-thread.c (is_ravenscar_task)
6809         (ravenscar_task_is_currently_active): Return bool.
6810         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6811         (_initialize_ravenscar): Remove "(void)".
6812         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6813         Return bool.
6814
6815 2019-02-15  Tom Tromey  <tromey@adacore.com>
6816
6817         * ravenscar-thread.c (ravenscar_runtime_initializer)
6818         (has_ravenscar_runtime, get_running_thread_id)
6819         (ravenscar_thread_target::resume): Fix indentation.
6820
6821 2019-02-15  Tom Tromey  <tromey@adacore.com>
6822
6823         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6824         from ravenscar_arch_ops.
6825         (sparc_ravenscar_ops::fetch_registers)
6826         (sparc_ravenscar_ops::store_registers): Now methods.
6827         (sparc_ravenscar_prepare_to_store): Remove.
6828         (sparc_ravenscar_ops): Redefine.
6829         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6830         methods and destructor.  Remove members.
6831         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6832         (ravenscar_thread_target::store_registers)
6833         (ravenscar_thread_target::prepare_to_store): Update.
6834         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6835         Remove.
6836         (struct ppc_ravenscar_powerpc_ops): Derive from
6837         ravenscar_arch_ops.
6838         (ppc_ravenscar_powerpc_ops::fetch_registers)
6839         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6840         (ppc_ravenscar_powerpc_ops): Redefine.
6841         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6842         (ppc_ravenscar_e500_ops::fetch_registers)
6843         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6844         (ppc_ravenscar_e500_ops): Redefine.
6845         * aarch64-ravenscar-thread.c
6846         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6847         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6848         (aarch64_ravenscar_fetch_registers)
6849         (aarch64_ravenscar_store_registers): Now methods.
6850         (aarch64_ravenscar_ops): Redefine.
6851
6852 2019-02-15  Tom Tromey  <tromey@adacore.com>
6853
6854         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6855         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6856         (ravenscar_thread_target::stopped_by_watchpoint)
6857         (ravenscar_thread_target::stopped_data_address)
6858         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6859
6860 2019-02-15  Tom Tromey  <tromey@adacore.com>
6861
6862         * ravenscar-thread.c: Fix some typos.
6863
6864 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6865             Tom Tromey  <tromey@adacore.com>
6866
6867         * ada-lang.c (ada_exception_sal): Change addr_string to a
6868         std::string.
6869         (create_ada_exception_catchpoint): Update.
6870
6871 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6872             Tom Tromey  <tromey@adacore.com>
6873
6874         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6875         (bp_location_ops): Remove.
6876         (base_breakpoint_allocate_location): Update.
6877         (free_bp_location): Update.
6878         * ada-lang.c (class ada_catchpoint_location)
6879         <ada_catchpoint_location>: Remove ops parameter.
6880         (ada_catchpoint_location_dtor): Remove.
6881         (ada_catchpoint_location_ops): Remove.
6882         (allocate_location_exception): Update.
6883         * breakpoint.h (struct bp_location_ops): Remove.
6884         (class bp_location) <bp_location>: Remove bp_location_ops
6885         parameter.
6886         <~bp_location>: Add destructor.
6887         <ops>: Remove.
6888
6889 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6890             Pedro Alves  <palves@redhat.com>
6891
6892         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6893         'PATH_MAX'.
6894
6895 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6896             Samuel Thibault  <samuel.thibault@gnu.org>
6897             Thomas Schwinge  <thomas@codesourcery.com>
6898
6899         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6900         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6901
6902 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6903
6904         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6905         (check_empty): Use "const char *".
6906
6907         * gnu-nat.c (gnu_nat_target::detach): Instead of
6908         'detach_inferior (pid)' call
6909         'detach_inferior (find_inferior_pid (pid))'.
6910
6911         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6912         'nat/fork-inferior.o'.
6913         * gnu-nat.c: #include "nat/fork-inferior.h".
6914
6915         * gnu-nat.c (gnu_nat_target::detach): Instead of
6916         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6917         * gnu-nat.h: #include "inf-child.h".
6918         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6919         'i386_gnu_nat_target::fetch_registers'.
6920         (gnu_store_registers): Rename/move to
6921         'i386_gnu_nat_target::store_registers'.
6922
6923         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6924         * gnu-nat.h (mach_thread_info): New function.
6925         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6926
6927         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6928
6929 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6930
6931         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6932
6933 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6934
6935         * windows-nat.c (windows_add_thread): Add new parameter
6936         "main_thread_p" with default value set to false.  Update
6937         function documentation as well as all callers.
6938         (windows_delete_thread): Likewise.
6939         (fake_create_process): Update call to windows_add_thread.
6940         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6941         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6942         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6943         call to windows_delete_thread.
6944
6945 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6946
6947         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6948
6949 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6950
6951         * symfile.c (find_separate_debug_file): Use canonical path of
6952         sysroot with child_path instead of gdb_sysroot if it is valid.
6953
6954 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6955
6956         * symfile.c (find_separate_debug_file): Use child_path to
6957         determine if an object file is under a sysroot.
6958
6959 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6960
6961         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6962         unittests/child-path-selftests.c.
6963         * common/pathstuff.c (child_path): New function.
6964         * common/pathstuff.h (child_path): New prototype.
6965         * unittests/child-path-selftests.c: New file.
6966
6967 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6968
6969         * symfile.c (find_separate_debug_file): Look for separate debug
6970         files in debug directories under the sysroot.
6971
6972 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6973
6974         * symtab.h (struct minimal_symbol data_p): New const method.
6975         (struct minimal_symbol text_p): Likewise.
6976         * symtab.c (output_source_filename): Use file name style
6977         to print file name.
6978         (print_symbol_info): Likewise.
6979         (print_msymbol_info): Use address style to print addresses.
6980         Use function name style to print executable text symbols.
6981         (expand_symtab_containing_pc): Use data_p.
6982         (find_pc_sect_compunit_symtab): Likewise.
6983
6984 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6985
6986         * breakpoint.c (describe_other_breakpoints): Use address style
6987         to print addresses.
6988         (say_where): Likewise.
6989
6990 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6991
6992         * ada-typeprint.c (print_func_type): Print function name
6993         style to print function name.
6994         * c-typeprint.c (c_print_type_1): Likewise.
6995
6996 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6997
6998         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6999         for execve.
7000
7001 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7002
7003         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7004         type_stack.
7005
7006 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7007
7008         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7009         TYPE_CODE_REF types.
7010
7011 2019-02-08  Jim Wilson  <jimw@sifive.com>
7012
7013         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7014         (riscv_linux_fregset): New.
7015         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7016
7017 2019-02-07  Tom Tromey  <tom@tromey.com>
7018
7019         * thread.c (thread_cancel_execution_command): Update.
7020         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7021         methods.
7022         (struct thread_fsm_ops): Remove.
7023         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7024         (thread_fsm_should_stop, thread_fsm_return_value)
7025         (thread_fsm_set_finished, thread_fsm_finished_p)
7026         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7027         Don't declare.
7028         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7029         * infrun.c (clear_proceed_status_thread)
7030         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7031         (print_stop_event): Update.
7032         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7033         Add constructor.
7034         (step_command_fsm_ops): Remove.
7035         (new_step_command_fsm): Remove.
7036         (step_1): Update.
7037         (step_command_fsm::should_stop): Rename from
7038         step_command_fsm_should_stop.
7039         (step_command_fsm::clean_up): Rename from
7040         step_command_fsm_clean_up.
7041         (step_command_fsm::do_async_reply_reason): Rename from
7042         step_command_fsm_async_reply_reason.
7043         (struct until_next_fsm): Inherit from thread_fsm.  Add
7044         constructor.
7045         (until_next_fsm_ops): Remove.
7046         (new_until_next_fsm): Remove.
7047         (until_next_fsm::should_stop): Rename from
7048         until_next_fsm_should_stop.
7049         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7050         (until_next_fsm::do_async_reply_reason): Rename from
7051         until_next_fsm_async_reply_reason.
7052         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7053         constructor.  Change type of breakpoint.
7054         (finish_command_fsm_ops): Remove.
7055         (new_finish_command_fsm): Remove.
7056         (finish_command_fsm::should_stop): Rename from
7057         finish_command_fsm_should_stop.
7058         (finish_command_fsm::clean_up): Rename from
7059         finish_command_fsm_clean_up.
7060         (finish_command_fsm::return_value): Rename from
7061         finish_command_fsm_return_value.
7062         (finish_command_fsm::do_async_reply_reason): Rename from
7063         finish_command_fsm_async_reply_reason.
7064         (finish_command): Update.
7065         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7066         Add constructor.
7067         (call_thread_fsm_ops): Remove.
7068         (call_thread_fsm::call_thread_fsm): Rename from
7069         new_call_thread_fsm.
7070         (call_thread_fsm::should_stop): Rename from
7071         call_thread_fsm_should_stop.
7072         (call_thread_fsm::should_notify_stop): Rename from
7073         call_thread_fsm_should_notify_stop.
7074         (run_inferior_call, call_function_by_hand_dummy): Update.
7075         * cli/cli-interp.c (should_print_stop_to_console): Update.
7076         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7077         Add constructor.  Change type of location_breakpoint,
7078         caller_breakpoint.
7079         (until_break_fsm_ops): Remove.
7080         (new_until_break_fsm): Remove.
7081         (until_break_fsm::should_stop): Rename from
7082         until_break_fsm_should_stop.
7083         (until_break_fsm::clean_up): Rename from
7084         until_break_fsm_clean_up.
7085         (until_break_fsm::do_async_reply_reason): Rename from
7086         until_break_fsm_async_reply_reason.
7087         (until_break_command): Update.
7088         * thread-fsm.c: Remove.
7089         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7090
7091 2019-02-07  Tom Tromey  <tom@tromey.com>
7092
7093         * yy-remap.h: Add include guard.
7094         * xtensa-tdep.h: Add include guard.
7095         * xcoffread.h: Rename include guard.
7096         * varobj-iter.h: Add include guard.
7097         * tui/tui.h: Rename include guard.
7098         * tui/tui-winsource.h: Rename include guard.
7099         * tui/tui-wingeneral.h: Rename include guard.
7100         * tui/tui-windata.h: Rename include guard.
7101         * tui/tui-win.h: Rename include guard.
7102         * tui/tui-stack.h: Rename include guard.
7103         * tui/tui-source.h: Rename include guard.
7104         * tui/tui-regs.h: Rename include guard.
7105         * tui/tui-out.h: Rename include guard.
7106         * tui/tui-layout.h: Rename include guard.
7107         * tui/tui-io.h: Rename include guard.
7108         * tui/tui-hooks.h: Rename include guard.
7109         * tui/tui-file.h: Rename include guard.
7110         * tui/tui-disasm.h: Rename include guard.
7111         * tui/tui-data.h: Rename include guard.
7112         * tui/tui-command.h: Rename include guard.
7113         * tic6x-tdep.h: Add include guard.
7114         * target/waitstatus.h: Rename include guard.
7115         * target/wait.h: Rename include guard.
7116         * target/target.h: Rename include guard.
7117         * target/resume.h: Rename include guard.
7118         * target-float.h: Rename include guard.
7119         * stabsread.h: Add include guard.
7120         * rs6000-tdep.h: Add include guard.
7121         * riscv-fbsd-tdep.h: Add include guard.
7122         * regformats/regdef.h: Rename include guard.
7123         * record.h: Rename include guard.
7124         * python/python.h: Rename include guard.
7125         * python/python-internal.h: Rename include guard.
7126         * python/py-stopevent.h: Rename include guard.
7127         * python/py-ref.h: Rename include guard.
7128         * python/py-record.h: Rename include guard.
7129         * python/py-record-full.h: Rename include guard.
7130         * python/py-record-btrace.h: Rename include guard.
7131         * python/py-instruction.h: Rename include guard.
7132         * python/py-events.h: Rename include guard.
7133         * python/py-event.h: Rename include guard.
7134         * procfs.h: Add include guard.
7135         * proc-utils.h: Add include guard.
7136         * p-lang.h: Add include guard.
7137         * or1k-tdep.h: Rename include guard.
7138         * observable.h: Rename include guard.
7139         * nto-tdep.h: Rename include guard.
7140         * nat/x86-linux.h: Rename include guard.
7141         * nat/x86-linux-dregs.h: Rename include guard.
7142         * nat/x86-gcc-cpuid.h: Add include guard.
7143         * nat/x86-dregs.h: Rename include guard.
7144         * nat/x86-cpuid.h: Rename include guard.
7145         * nat/ppc-linux.h: Rename include guard.
7146         * nat/mips-linux-watch.h: Rename include guard.
7147         * nat/linux-waitpid.h: Rename include guard.
7148         * nat/linux-ptrace.h: Rename include guard.
7149         * nat/linux-procfs.h: Rename include guard.
7150         * nat/linux-osdata.h: Rename include guard.
7151         * nat/linux-nat.h: Rename include guard.
7152         * nat/linux-namespaces.h: Rename include guard.
7153         * nat/linux-btrace.h: Rename include guard.
7154         * nat/glibc_thread_db.h: Rename include guard.
7155         * nat/gdb_thread_db.h: Rename include guard.
7156         * nat/gdb_ptrace.h: Rename include guard.
7157         * nat/fork-inferior.h: Rename include guard.
7158         * nat/amd64-linux-siginfo.h: Rename include guard.
7159         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7160         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7161         * nat/aarch64-linux.h: Rename include guard.
7162         * nat/aarch64-linux-hw-point.h: Rename include guard.
7163         * mn10300-tdep.h: Add include guard.
7164         * mips-linux-tdep.h: Add include guard.
7165         * mi/mi-parse.h: Rename include guard.
7166         * mi/mi-out.h: Rename include guard.
7167         * mi/mi-main.h: Rename include guard.
7168         * mi/mi-interp.h: Rename include guard.
7169         * mi/mi-getopt.h: Rename include guard.
7170         * mi/mi-console.h: Rename include guard.
7171         * mi/mi-common.h: Rename include guard.
7172         * mi/mi-cmds.h: Rename include guard.
7173         * mi/mi-cmd-break.h: Rename include guard.
7174         * m2-lang.h: Add include guard.
7175         * location.h: Rename include guard.
7176         * linux-record.h: Rename include guard.
7177         * linux-nat.h: Add include guard.
7178         * linux-fork.h: Add include guard.
7179         * i386-darwin-tdep.h: Rename include guard.
7180         * hppa-linux-offsets.h: Add include guard.
7181         * guile/guile.h: Rename include guard.
7182         * guile/guile-internal.h: Rename include guard.
7183         * gnu-nat.h: Rename include guard.
7184         * gdb-stabs.h: Rename include guard.
7185         * frv-tdep.h: Add include guard.
7186         * f-lang.h: Add include guard.
7187         * event-loop.h: Add include guard.
7188         * darwin-nat.h: Rename include guard.
7189         * cp-abi.h: Rename include guard.
7190         * config/sparc/nm-sol2.h: Rename include guard.
7191         * config/nm-nto.h: Rename include guard.
7192         * config/nm-linux.h: Add include guard.
7193         * config/i386/nm-i386gnu.h: Rename include guard.
7194         * config/djgpp/nl_types.h: Rename include guard.
7195         * config/djgpp/langinfo.h: Rename include guard.
7196         * compile/gcc-cp-plugin.h: Add include guard.
7197         * compile/gcc-c-plugin.h: Add include guard.
7198         * compile/compile.h: Rename include guard.
7199         * compile/compile-object-run.h: Rename include guard.
7200         * compile/compile-object-load.h: Rename include guard.
7201         * compile/compile-internal.h: Rename include guard.
7202         * compile/compile-cplus.h: Rename include guard.
7203         * compile/compile-c.h: Rename include guard.
7204         * common/xml-utils.h: Rename include guard.
7205         * common/x86-xstate.h: Rename include guard.
7206         * common/version.h: Rename include guard.
7207         * common/vec.h: Rename include guard.
7208         * common/tdesc.h: Rename include guard.
7209         * common/selftest.h: Rename include guard.
7210         * common/scoped_restore.h: Rename include guard.
7211         * common/scoped_mmap.h: Rename include guard.
7212         * common/scoped_fd.h: Rename include guard.
7213         * common/safe-iterator.h: Rename include guard.
7214         * common/run-time-clock.h: Rename include guard.
7215         * common/refcounted-object.h: Rename include guard.
7216         * common/queue.h: Rename include guard.
7217         * common/ptid.h: Rename include guard.
7218         * common/print-utils.h: Rename include guard.
7219         * common/preprocessor.h: Rename include guard.
7220         * common/pathstuff.h: Rename include guard.
7221         * common/observable.h: Rename include guard.
7222         * common/netstuff.h: Rename include guard.
7223         * common/job-control.h: Rename include guard.
7224         * common/host-defs.h: Rename include guard.
7225         * common/gdb_wait.h: Rename include guard.
7226         * common/gdb_vecs.h: Rename include guard.
7227         * common/gdb_unlinker.h: Rename include guard.
7228         * common/gdb_unique_ptr.h: Rename include guard.
7229         * common/gdb_tilde_expand.h: Rename include guard.
7230         * common/gdb_sys_time.h: Rename include guard.
7231         * common/gdb_string_view.h: Rename include guard.
7232         * common/gdb_splay_tree.h: Rename include guard.
7233         * common/gdb_setjmp.h: Rename include guard.
7234         * common/gdb_ref_ptr.h: Rename include guard.
7235         * common/gdb_optional.h: Rename include guard.
7236         * common/gdb_locale.h: Rename include guard.
7237         * common/gdb_assert.h: Rename include guard.
7238         * common/filtered-iterator.h: Rename include guard.
7239         * common/filestuff.h: Rename include guard.
7240         * common/fileio.h: Rename include guard.
7241         * common/environ.h: Rename include guard.
7242         * common/common-utils.h: Rename include guard.
7243         * common/common-types.h: Rename include guard.
7244         * common/common-regcache.h: Rename include guard.
7245         * common/common-inferior.h: Rename include guard.
7246         * common/common-gdbthread.h: Rename include guard.
7247         * common/common-exceptions.h: Rename include guard.
7248         * common/common-defs.h: Rename include guard.
7249         * common/common-debug.h: Rename include guard.
7250         * common/cleanups.h: Rename include guard.
7251         * common/buffer.h: Rename include guard.
7252         * common/btrace-common.h: Rename include guard.
7253         * common/break-common.h: Rename include guard.
7254         * cli/cli-utils.h: Rename include guard.
7255         * cli/cli-style.h: Rename include guard.
7256         * cli/cli-setshow.h: Rename include guard.
7257         * cli/cli-script.h: Rename include guard.
7258         * cli/cli-interp.h: Rename include guard.
7259         * cli/cli-decode.h: Rename include guard.
7260         * cli/cli-cmds.h: Rename include guard.
7261         * charset-list.h: Add include guard.
7262         * buildsym-legacy.h: Rename include guard.
7263         * bfin-tdep.h: Add include guard.
7264         * ax.h: Rename include guard.
7265         * arm-linux-tdep.h: Add include guard.
7266         * arm-fbsd-tdep.h: Add include guard.
7267         * arch/xtensa.h: Rename include guard.
7268         * arch/tic6x.h: Add include guard.
7269         * arch/i386.h: Add include guard.
7270         * arch/arm.h: Rename include guard.
7271         * arch/arm-linux.h: Rename include guard.
7272         * arch/arm-get-next-pcs.h: Rename include guard.
7273         * arch/amd64.h: Add include guard.
7274         * arch/aarch64-insn.h: Rename include guard.
7275         * arch-utils.h: Rename include guard.
7276         * annotate.h: Add include guard.
7277         * amd64-darwin-tdep.h: Rename include guard.
7278         * aarch64-linux-tdep.h: Add include guard.
7279         * aarch64-fbsd-tdep.h: Add include guard.
7280         * aarch32-linux-nat.h: Add include guard.
7281
7282 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7283
7284         * macrotab.c (macro_define_internal): New function that
7285         factorizes macro_define_object_internal and macro_define_function
7286         code.
7287         (macro_define_object_internal): Use macro_define_internal.
7288         (macro_define_function): Likewise.
7289
7290 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7291
7292         * macrocmd.c (extract_identifier): Return
7293         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7294         callers.
7295
7296 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7297
7298         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7299
7300 2019-02-05  Tom Tromey  <tom@tromey.com>
7301
7302         * target.c (target_stack::unpush): Move assertion earlier.
7303
7304 2019-01-30  Tom Tromey  <tom@tromey.com>
7305
7306         PR python/23615:
7307         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7308         (gdbpy_parse_and_eval): Likewise.
7309         * python/python-internal.h (gdbpy_allow_threads): New class.
7310
7311 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7312
7313         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7314         (aarch64_fbsd_fpregmap): Move earlier.
7315         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7316         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7317         instead of individual calls to trad_frame_set_reg_addr.
7318         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7319         earlier.
7320         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7321         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7322         instead of individual calls to trad_frame_set_reg_addr.
7323
7324 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7325
7326         * CONTRIBUTE: Replace contribution list with wiki link.
7327
7328 2019-01-25  Tom Tromey  <tom@tromey.com>
7329
7330         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7331
7332 2019-01-25  Tom Tromey  <tom@tromey.com>
7333
7334         * xtensa-linux-nat.c: Fix common/ includes.
7335         * xml-support.h: Fix common/ includes.
7336         * xml-support.c: Fix common/ includes.
7337         * x86-linux-nat.c: Fix common/ includes.
7338         * windows-nat.c: Fix common/ includes.
7339         * varobj.h: Fix common/ includes.
7340         * varobj.c: Fix common/ includes.
7341         * value.c: Fix common/ includes.
7342         * valops.c: Fix common/ includes.
7343         * utils.c: Fix common/ includes.
7344         * unittests/xml-utils-selftests.c: Fix common/ includes.
7345         * unittests/utils-selftests.c: Fix common/ includes.
7346         * unittests/unpack-selftests.c: Fix common/ includes.
7347         * unittests/tracepoint-selftests.c: Fix common/ includes.
7348         * unittests/style-selftests.c: Fix common/ includes.
7349         * unittests/string_view-selftests.c: Fix common/ includes.
7350         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7351         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7352         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7353         * unittests/rsp-low-selftests.c: Fix common/ includes.
7354         * unittests/parse-connection-spec-selftests.c: Fix common/
7355         includes.
7356         * unittests/optional-selftests.c: Fix common/ includes.
7357         * unittests/offset-type-selftests.c: Fix common/ includes.
7358         * unittests/observable-selftests.c: Fix common/ includes.
7359         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7360         * unittests/memrange-selftests.c: Fix common/ includes.
7361         * unittests/memory-map-selftests.c: Fix common/ includes.
7362         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7363         * unittests/function-view-selftests.c: Fix common/ includes.
7364         * unittests/environ-selftests.c: Fix common/ includes.
7365         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7366         * unittests/common-utils-selftests.c: Fix common/ includes.
7367         * unittests/cli-utils-selftests.c: Fix common/ includes.
7368         * unittests/array-view-selftests.c: Fix common/ includes.
7369         * ui-file.c: Fix common/ includes.
7370         * tui/tui-io.c: Fix common/ includes.
7371         * tracepoint.h: Fix common/ includes.
7372         * tracepoint.c: Fix common/ includes.
7373         * tracefile-tfile.c: Fix common/ includes.
7374         * top.h: Fix common/ includes.
7375         * top.c: Fix common/ includes.
7376         * thread.c: Fix common/ includes.
7377         * target/waitstatus.h: Fix common/ includes.
7378         * target/waitstatus.c: Fix common/ includes.
7379         * target.h: Fix common/ includes.
7380         * target.c: Fix common/ includes.
7381         * target-memory.c: Fix common/ includes.
7382         * target-descriptions.c: Fix common/ includes.
7383         * symtab.h: Fix common/ includes.
7384         * symfile.c: Fix common/ includes.
7385         * stap-probe.c: Fix common/ includes.
7386         * spu-linux-nat.c: Fix common/ includes.
7387         * sparc-nat.c: Fix common/ includes.
7388         * source.c: Fix common/ includes.
7389         * solib.c: Fix common/ includes.
7390         * solib-target.c: Fix common/ includes.
7391         * ser-unix.c: Fix common/ includes.
7392         * ser-tcp.c: Fix common/ includes.
7393         * ser-pipe.c: Fix common/ includes.
7394         * ser-base.c: Fix common/ includes.
7395         * selftest-arch.c: Fix common/ includes.
7396         * s12z-tdep.c: Fix common/ includes.
7397         * rust-exp.y: Fix common/ includes.
7398         * rs6000-aix-tdep.c: Fix common/ includes.
7399         * riscv-tdep.c: Fix common/ includes.
7400         * remote.c: Fix common/ includes.
7401         * remote-notif.h: Fix common/ includes.
7402         * remote-fileio.h: Fix common/ includes.
7403         * remote-fileio.c: Fix common/ includes.
7404         * regcache.h: Fix common/ includes.
7405         * regcache.c: Fix common/ includes.
7406         * record-btrace.c: Fix common/ includes.
7407         * python/python.c: Fix common/ includes.
7408         * python/py-type.c: Fix common/ includes.
7409         * python/py-inferior.c: Fix common/ includes.
7410         * progspace.h: Fix common/ includes.
7411         * producer.c: Fix common/ includes.
7412         * procfs.c: Fix common/ includes.
7413         * proc-api.c: Fix common/ includes.
7414         * printcmd.c: Fix common/ includes.
7415         * ppc-linux-nat.c: Fix common/ includes.
7416         * parser-defs.h: Fix common/ includes.
7417         * osdata.c: Fix common/ includes.
7418         * obsd-nat.c: Fix common/ includes.
7419         * nat/x86-linux.c: Fix common/ includes.
7420         * nat/x86-linux-dregs.c: Fix common/ includes.
7421         * nat/x86-dregs.h: Fix common/ includes.
7422         * nat/x86-dregs.c: Fix common/ includes.
7423         * nat/ppc-linux.c: Fix common/ includes.
7424         * nat/mips-linux-watch.h: Fix common/ includes.
7425         * nat/mips-linux-watch.c: Fix common/ includes.
7426         * nat/linux-waitpid.c: Fix common/ includes.
7427         * nat/linux-ptrace.h: Fix common/ includes.
7428         * nat/linux-ptrace.c: Fix common/ includes.
7429         * nat/linux-procfs.c: Fix common/ includes.
7430         * nat/linux-personality.c: Fix common/ includes.
7431         * nat/linux-osdata.c: Fix common/ includes.
7432         * nat/linux-namespaces.c: Fix common/ includes.
7433         * nat/linux-btrace.h: Fix common/ includes.
7434         * nat/linux-btrace.c: Fix common/ includes.
7435         * nat/fork-inferior.c: Fix common/ includes.
7436         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7437         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7438         * nat/aarch64-linux.c: Fix common/ includes.
7439         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7440         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7441         * namespace.h: Fix common/ includes.
7442         * mips-linux-tdep.c: Fix common/ includes.
7443         * minsyms.c: Fix common/ includes.
7444         * mi/mi-parse.h: Fix common/ includes.
7445         * mi/mi-main.c: Fix common/ includes.
7446         * mi/mi-cmd-env.c: Fix common/ includes.
7447         * memrange.h: Fix common/ includes.
7448         * memattr.c: Fix common/ includes.
7449         * maint.h: Fix common/ includes.
7450         * maint.c: Fix common/ includes.
7451         * main.c: Fix common/ includes.
7452         * machoread.c: Fix common/ includes.
7453         * location.c: Fix common/ includes.
7454         * linux-thread-db.c: Fix common/ includes.
7455         * linux-nat.c: Fix common/ includes.
7456         * linux-fork.c: Fix common/ includes.
7457         * inline-frame.c: Fix common/ includes.
7458         * infrun.c: Fix common/ includes.
7459         * inflow.c: Fix common/ includes.
7460         * inferior.h: Fix common/ includes.
7461         * inferior.c: Fix common/ includes.
7462         * infcmd.c: Fix common/ includes.
7463         * inf-ptrace.c: Fix common/ includes.
7464         * inf-child.c: Fix common/ includes.
7465         * ia64-linux-nat.c: Fix common/ includes.
7466         * i387-tdep.c: Fix common/ includes.
7467         * i386-tdep.c: Fix common/ includes.
7468         * i386-linux-tdep.c: Fix common/ includes.
7469         * i386-linux-nat.c: Fix common/ includes.
7470         * i386-go32-tdep.c: Fix common/ includes.
7471         * i386-fbsd-tdep.c: Fix common/ includes.
7472         * i386-fbsd-nat.c: Fix common/ includes.
7473         * guile/scm-type.c: Fix common/ includes.
7474         * guile/guile.c: Fix common/ includes.
7475         * go32-nat.c: Fix common/ includes.
7476         * gnu-nat.c: Fix common/ includes.
7477         * gdbthread.h: Fix common/ includes.
7478         * gdbarch-selftests.c: Fix common/ includes.
7479         * gdb_usleep.c: Fix common/ includes.
7480         * gdb_select.h: Fix common/ includes.
7481         * gdb_bfd.c: Fix common/ includes.
7482         * gcore.c: Fix common/ includes.
7483         * fork-child.c: Fix common/ includes.
7484         * findvar.c: Fix common/ includes.
7485         * fbsd-nat.c: Fix common/ includes.
7486         * event-top.c: Fix common/ includes.
7487         * event-loop.c: Fix common/ includes.
7488         * dwarf2read.c: Fix common/ includes.
7489         * dwarf2loc.c: Fix common/ includes.
7490         * dwarf2-frame.c: Fix common/ includes.
7491         * dwarf-index-cache.c: Fix common/ includes.
7492         * dtrace-probe.c: Fix common/ includes.
7493         * disasm-selftests.c: Fix common/ includes.
7494         * defs.h: Fix common/ includes.
7495         * csky-tdep.c: Fix common/ includes.
7496         * cp-valprint.c: Fix common/ includes.
7497         * cp-support.h: Fix common/ includes.
7498         * cp-support.c: Fix common/ includes.
7499         * corelow.c: Fix common/ includes.
7500         * completer.h: Fix common/ includes.
7501         * completer.c: Fix common/ includes.
7502         * compile/compile.c: Fix common/ includes.
7503         * compile/compile-loc2c.c: Fix common/ includes.
7504         * compile/compile-cplus-types.c: Fix common/ includes.
7505         * compile/compile-cplus-symbols.c: Fix common/ includes.
7506         * command.h: Fix common/ includes.
7507         * cli/cli-dump.c: Fix common/ includes.
7508         * cli/cli-cmds.c: Fix common/ includes.
7509         * charset.c: Fix common/ includes.
7510         * build-id.c: Fix common/ includes.
7511         * btrace.h: Fix common/ includes.
7512         * btrace.c: Fix common/ includes.
7513         * breakpoint.h: Fix common/ includes.
7514         * breakpoint.c: Fix common/ includes.
7515         * ax.h:
7516         (enum agent_op): Fix common/ includes.
7517         * ax-general.c (struct aop_map): Fix common/ includes.
7518         * ax-gdb.c: Fix common/ includes.
7519         * auxv.c: Fix common/ includes.
7520         * auto-load.c: Fix common/ includes.
7521         * arm-tdep.c: Fix common/ includes.
7522         * arch/riscv.c: Fix common/ includes.
7523         * arch/ppc-linux-common.c: Fix common/ includes.
7524         * arch/i386.c: Fix common/ includes.
7525         * arch/arm.c: Fix common/ includes.
7526         * arch/arm-linux.c: Fix common/ includes.
7527         * arch/arm-get-next-pcs.c: Fix common/ includes.
7528         * arch/amd64.c: Fix common/ includes.
7529         * arch/aarch64.c: Fix common/ includes.
7530         * arch/aarch64-insn.c: Fix common/ includes.
7531         * arch-utils.c: Fix common/ includes.
7532         * amd64-windows-tdep.c: Fix common/ includes.
7533         * amd64-tdep.c: Fix common/ includes.
7534         * amd64-sol2-tdep.c: Fix common/ includes.
7535         * amd64-obsd-tdep.c: Fix common/ includes.
7536         * amd64-nbsd-tdep.c: Fix common/ includes.
7537         * amd64-linux-tdep.c: Fix common/ includes.
7538         * amd64-linux-nat.c: Fix common/ includes.
7539         * amd64-fbsd-tdep.c: Fix common/ includes.
7540         * amd64-fbsd-nat.c: Fix common/ includes.
7541         * amd64-dicos-tdep.c: Fix common/ includes.
7542         * amd64-darwin-tdep.c: Fix common/ includes.
7543         * agent.c: Fix common/ includes.
7544         * ada-lang.h: Fix common/ includes.
7545         * ada-lang.c: Fix common/ includes.
7546         * aarch64-tdep.c: Fix common/ includes.
7547
7548 2019-01-25  Tom Tromey  <tom@tromey.com>
7549
7550         * common/create-version.sh: Use common/version.h.
7551
7552 2019-01-24  Pedro Alves  <palves@redhat.com>
7553
7554         * infrun.c (signal_stop, signal_print, signal_program)
7555         (signal_catch, signal_pass): Now arrays instead of pointers.
7556         (update_signals_program_target, do_target_resume)
7557         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7558         * linux-nat.c (linux_nat_target::pass_signals)
7559         (linux_nat_target::create_inferior, linux_nat_target::attach):
7560         Adjust.
7561         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7562         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7563         * procfs.c (procfs_target::pass_signals): Adjust.
7564         * record-full.c (record_full_target::resume): Adjust.
7565         * remote.c (remote_target::pass_signals)
7566         (remote_target::program_signals): Adjust.
7567         * target-debug.h (target_debug_print_signals): Now takes a
7568         gdb::array_view as parameter.  Adjust.
7569         * target.h (target_ops) <pass_signals, program_signals>: Replace
7570         pointer and length parameters with gdb::array_view.
7571         (target_pass_signals, target_program_signals): Likewise.
7572         * target-delegates.c: Regenerate.
7573
7574 2019-01-24  Pedro Alves  <palves@redhat.com>
7575
7576         * common/forward-scope-exit.h
7577         (forward_scope_exit::forward_scope_exit): Pass arguments to
7578         m_bind_function directly, instead of creating a std::bind and
7579         copying that.
7580
7581 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7582
7583         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7584         for static members.
7585         (pass_in_v_vfp_candidate): Likewise.
7586
7587 2019-01-23  Tom Tromey  <tom@tromey.com>
7588             Pedro Alves  <palves@redhat.com>
7589
7590         * regcache.c (class regcache_invalidator): Remove.
7591         (regcache::raw_write): Use make_scope_exit.
7592
7593 2019-01-23  Tom Tromey  <tom@tromey.com>
7594
7595         * ui-out.h (class ui_out_emit_type): Update comment.
7596
7597 2019-01-23  Tom Tromey  <tom@tromey.com>
7598
7599         * infrun.c (fetch_inferior_event): Update comment.
7600
7601 2019-01-23  Tom Tromey  <tom@tromey.com>
7602             Pedro Alves  <palves@redhat.com>
7603
7604         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7605         parameter.
7606         (fetch_inferior_event): Use SCOPE_EXIT.
7607
7608
7609 2019-01-23  Tom Tromey  <tom@tromey.com>
7610             Pedro Alves  <palves@redhat.com>
7611
7612         * infrun.c (disable_thread_events): Delete.
7613         (stop_all_threads): Use SCOPE_EXIT.
7614
7615 2019-01-23  Tom Tromey  <tom@tromey.com>
7616             Pedro Alves  <palves@redhat.com>
7617
7618         * symfile.c: Include forward-scope-exit.h.
7619         (clear_symtab_users_cleanup): Replace forward declaration with
7620         a FORWARD_SCOPE_EXIT.
7621         (syms_from_objfile_1): Use the forward_scope_exit and
7622         gdb::optional instead of cleanup_function.
7623         (reread_symbols): Use the forward_scope_exit instead of
7624         cleanup_function.
7625         (clear_symtab_users_cleanup): Remove function.
7626
7627 2019-01-23  Tom Tromey  <tom@tromey.com>
7628             Pedro Alves  <palves@redhat.com>
7629
7630         * linux-nat.c: Include scope-exit.h.
7631         (cleanup_target_stop): Remove.
7632         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7633         SCOPE_EXIT.
7634
7635 2019-01-23  Tom Tromey  <tom@tromey.com>
7636             Pedro Alves  <palves@redhat.com>
7637
7638         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7639         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7640
7641 2019-01-23  Tom Tromey  <tom@tromey.com>
7642             Andrew Burgess  <andrew.burgess@embecosm.com>
7643             Pedro Alves  <palves@redhat.com>
7644
7645         * infrun.c (fetch_inferior_event): Use scope_exit.
7646         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7647         * top.c (execute_command): Use scope_exit.
7648         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7649         * utils.c (do_bpstat_clear_actions_cleanup)
7650         (make_bpstat_clear_actions_cleanup): Remove.
7651
7652 2019-01-23  Tom Tromey  <tom@tromey.com>
7653             Pedro Alves  <palves@redhat.com>
7654
7655         * infrun.c: Include "common/scope-exit.h"
7656         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7657         (wait_for_inferior): Use SCOPE_EXIT.
7658         (fetch_inferior_event): Use scope_exit.
7659
7660 2019-01-23  Tom Tromey  <tom@tromey.com>
7661             Pedro Alves  <palves@redhat.com>
7662
7663         * breakpoint.c (create_breakpoint): Remove cleanup.
7664
7665 2019-01-23  Tom Tromey  <tom@tromey.com>
7666             Andrew Burgess  <andrew.burgess@embecosm.com>
7667             Pedro Alves  <palves@redhat.com>
7668
7669 2019-01-23  Pedro Alves  <palves@redhat.com>
7670
7671         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7672
7673 2019-01-23  Pedro Alves  <palves@redhat.com>
7674             Andrew Burgess  <andrew.burgess@embecosm.com>
7675
7676         * gdbthread.h: Include "common/forward-scope-exit.h".
7677         (scoped_finish_thread_state): Redefine custom class in terms of
7678         forward_scope_exit.
7679
7680 2019-01-23  Pedro Alves  <palves@redhat.com>
7681             Andrew Burgess  <andrew.burgess@embecosm.com>
7682
7683         * common/forward-scope-exit.h: New file.
7684
7685 2019-01-23  Pedro Alves  <palves@redhat.com>
7686             Andrew Burgess  <andrew.burgess@embecosm.com>
7687             Tom Tromey  <tom@tromey.com>
7688
7689         * common/scope-exit.h: New file.
7690
7691 2019-01-23  Pedro Alves  <palves@redhat.com>
7692
7693         * common/preprocessor.h (ESC): Rename to ...
7694         (ESC_PARENS): ... this.
7695         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7696         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7697
7698 2019-01-23  Tom Tromey  <tom@tromey.com>
7699
7700         * language.h (class scoped_switch_to_sym_language_if_auto):
7701         Initialize m_lang in both cases.
7702
7703 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7704
7705         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7706         with XCNEW.
7707
7708 2019-01-22  Tom Tromey  <tom@tromey.com>
7709
7710         * corelow.c: Do not include sys/file.h.
7711
7712 2019-01-22  Tom Tromey  <tom@tromey.com>
7713
7714         * tui/tui-wingeneral.h: Include gdb_curses.h.
7715
7716 2019-01-22  Tom Tromey  <tom@tromey.com>
7717
7718         * source-cache.h (class source_cache) <get_source_lines,
7719         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7720
7721 2019-01-22  Tom Tromey  <tom@tromey.com>
7722
7723         * remote-fileio.h (struct remote_target): Declare.
7724
7725 2019-01-22  Tom Tromey  <tom@tromey.com>
7726
7727         * python/py-arch.c: Do not include py-ref.h.
7728         * python/py-bpevent.c: Do not include py-ref.h.
7729         * python/py-cmd.c: Do not include py-ref.h.
7730         * python/py-continueevent.c: Do not include py-ref.h.
7731         * python/py-event.h: Do not include py-ref.h.
7732         * python/py-evtregistry.c: Do not include py-ref.h.
7733         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7734         * python/py-frame.c: Do not include py-ref.h.
7735         * python/py-framefilter.c: Do not include py-ref.h.
7736         * python/py-function.c: Do not include py-ref.h.
7737         * python/py-infevents.c: Do not include py-ref.h.
7738         * python/py-linetable.c: Do not include py-ref.h.
7739         * python/py-objfile.c: Do not include py-ref.h.
7740         * python/py-param.c: Do not include py-ref.h.
7741         * python/py-prettyprint.c: Do not include py-ref.h.
7742         * python/py-progspace.c: Do not include py-ref.h.
7743         * python/py-symbol.c: Do not include py-ref.h.
7744         * python/py-symtab.c: Do not include py-ref.h.
7745         * python/py-type.c: Do not include py-ref.h.
7746         * python/py-unwind.c: Do not include py-ref.h.
7747         * python/py-utils.c: Do not include py-ref.h.
7748         * python/py-value.c: Do not include py-ref.h.
7749         * python/py-varobj.c: Do not include py-ref.h.
7750         * python/py-xmethods.c: Do not include py-ref.h.
7751         * python/python.c: Do not include py-ref.h.
7752         * varobj.c: Do not include py-ref.h.
7753
7754 2019-01-22  Tom Tromey  <tom@tromey.com>
7755
7756         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7757         keyword for bcache.
7758
7759 2019-01-22  Tom Tromey  <tom@tromey.com>
7760
7761         * compile/compile-cplus-types.c: Remove a comment by #include.
7762
7763 2019-01-22  Tom Tromey  <tom@tromey.com>
7764
7765         * compile/gcc-c-plugin.h: Include compile-internal.h.
7766
7767 2019-01-22  Tom Tromey  <tom@tromey.com>
7768
7769         * stabsread.c (EXTERN): Do not define.
7770         (symnum, next_symbol_text_func, processing_gcc_compilation)
7771         (within_function, global_sym_chain, global_stabs)
7772         (previous_stab_code, this_object_header_files)
7773         (n_this_object_header_files)
7774         (n_allocated_this_object_header_files): Define.
7775         * stabsread.h (EXTERN): Never define.  Use "extern".
7776
7777 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7778
7779         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7780         history_value.
7781
7782 2019-01-21  Tom Tromey  <tom@tromey.com>
7783
7784         * ui-out.c: Fix includes.
7785         * tui/tui-source.c: Fix includes.
7786         * target.c: Fix includes.
7787         * remote.c: Fix includes.
7788         * regcache.c: Fix includes.
7789         * python/py-block.c: Fix includes.
7790         * printcmd.c: Fix includes.
7791         * or1k-tdep.c: Fix includes.
7792         * mi/mi-main.c: Fix includes.
7793         * m32r-tdep.c: Fix includes.
7794         * csky-tdep.c: Fix includes.
7795         * compile/compile-cplus-types.c: Fix includes.
7796         * cli/cli-interp.c: Fix includes.
7797
7798 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7799
7800         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7801         for padding.
7802
7803 2019-01-16  Tom Tromey  <tom@tromey.com>
7804
7805         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7806         earlier.
7807         (struct objfile) <msymbols_range>: Move from top level.
7808         <msymbols>: New method.
7809         (class objfile_msymbols): Remove.
7810         * symtab.c (default_collect_symbol_completion_matches_break_on):
7811         Update.
7812         * symmisc.c (dump_msymbols): Update.
7813         * stabsread.c (scan_file_globals): Update.
7814         * objc-lang.c (info_selectors_command, info_classes_command)
7815         (find_methods): Update.
7816         * minsyms.c (find_solib_trampoline_target): Update.
7817         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7818         * coffread.c (coff_symfile_read): Update.
7819         * ada-lang.c (ada_lookup_simple_minsym)
7820         (ada_collect_symbol_completion_matches): Update.
7821
7822 2019-01-16  Tom Tromey  <tom@tromey.com>
7823
7824         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7825         type.  Remove no-argument constructor.
7826         <iterator::operator++>: Simplify.
7827         <begin>: Update.
7828         <end>: Use minimal_symbol_count.
7829
7830 2019-01-16  Tom Tromey  <tom@tromey.com>
7831
7832         * objfiles.h (struct objfile) <psymtabs>: New method.
7833         (class objfile_psymtabs): Remove.
7834         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7835         typedef.
7836         <range>: New method.
7837         (require_partial_symbols): Change return type.
7838         * psymtab.c (require_partial_symbols)
7839         (psym_expand_symtabs_matching): Update.
7840         * mdebugread.c (parse_partial_symbols): Update.
7841         * dbxread.c (dbx_end_psymtab): Update.
7842
7843 2019-01-15  Tom Tromey  <tom@tromey.com>
7844
7845         * symtab.c (lookup_objfile_from_block)
7846         (lookup_symbol_in_objfile_symtabs)
7847         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7848         (find_line_symtab, info_sources_command)
7849         (default_collect_symbol_completion_matches_break_on)
7850         (make_source_files_completion_list): Update.
7851         * symmisc.c (print_objfile_statistics, dump_objfile)
7852         (maintenance_print_symbols, maintenance_info_symtabs)
7853         (maintenance_check_symtabs, maintenance_info_line_tables):
7854         Update.
7855         * source.c (select_source_symtab)
7856         (forget_cached_source_info_for_objfile): Update.
7857         * objfiles.h (class objfile_compunits): Remove.
7858         (struct objfile) <compunits_range>: New typedef.
7859         (compunits): New method.
7860         * objfiles.c (objfile_relocate1): Update.
7861         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7862         * maint.c (count_symtabs_and_blocks): Update.
7863         * linespec.c (iterate_over_all_matching_symtabs): Update.
7864         * cp-support.c (add_symbol_overload_list_qualified): Update.
7865         * coffread.c (coff_symtab_read): Update.
7866         * ada-lang.c (add_nonlocal_symbols)
7867         (ada_collect_symbol_completion_matches)
7868         (ada_add_global_exceptions): Update.
7869
7870 2019-01-15  Tom Tromey  <tom@tromey.com>
7871
7872         * progspace.h (program_space) <objfiles_safe_range>: New
7873         typedef.
7874         <objfiles_safe>: New method.
7875         * objfiles.h (class all_objfiles_safe): Remove.
7876         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7877         * jit.c (jit_inferior_exit_hook): Update.
7878
7879 2019-01-17  Tom Tromey  <tom@tromey.com>
7880
7881         * progspace.h (program_space) <objfiles_range>: New typedef.
7882         <objfiles>: New method.
7883         <objfiles_head>: Rename from objfiles.
7884         (object_files): Update.
7885         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7886         * guile/scm-pretty-print.c
7887         (ppscm_find_pretty_printer_from_objfiles): Update.
7888         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7889         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7890         Update.
7891         * python/py-progspace.c (pspy_get_objfiles): Update.
7892         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7893         Update.
7894         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7895         (objfpy_lookup_objfile_by_build_id): Update.
7896         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7897         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7898         Update.
7899         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7900         (expand_symtab_containing_pc, lookup_objfile_from_block)
7901         (lookup_static_symbol, basic_lookup_transparent_type)
7902         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7903         (find_line_symtab, info_sources_command)
7904         (default_collect_symbol_completion_matches_break_on)
7905         (make_source_files_completion_list, find_main_name): Update.
7906         * symmisc.c (print_symbol_bcache_statistics)
7907         (print_objfile_statistics, maintenance_print_symbols)
7908         (maintenance_print_msymbols, maintenance_print_objfiles)
7909         (maintenance_info_symtabs, maintenance_check_symtabs)
7910         (maintenance_expand_symtabs, maintenance_info_line_tables):
7911         Update.
7912         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7913         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7914         (map_overlay_command, unmap_overlay_command)
7915         (simple_overlay_update, expand_symtabs_matching)
7916         (map_symbol_filenames): Update.
7917         * symfile-debug.c (set_debug_symfile): Update.
7918         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7919         Update.
7920         * source.c (select_source_symtab, forget_cached_source_info):
7921         Update.
7922         * solib.c (solib_read_symbols): Update.
7923         * solib-spu.c (append_ocl_sos): Update.
7924         * psymtab.c (maintenance_print_psymbols)
7925         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7926         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7927         * printcmd.c (info_symbol_command): Update.
7928         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7929         Update.
7930         * objfiles.h (class all_objfiles): Remove.
7931         * objfiles.c (have_partial_symbols, have_full_symbols)
7932         (have_minimal_symbols, qsort_cmp, update_section_map)
7933         (shared_objfile_contains_address_p)
7934         (default_iterate_over_objfiles_in_search_order): Update.
7935         * objc-lang.c (info_selectors_command, info_classes_command)
7936         (find_methods): Update.
7937         * minsyms.c (find_solib_trampoline_target): Update.
7938         * maint.c (maintenance_info_sections)
7939         (maintenance_translate_address, count_symtabs_and_blocks):
7940         Update.
7941         * main.c (captured_main_1): Update.
7942         * linux-thread-db.c (try_thread_db_load_from_pdir)
7943         (has_libpthread): Update.
7944         * linespec.c (iterate_over_all_matching_symtabs)
7945         (search_minsyms_for_name): Update.
7946         * jit.c (jit_find_objf_with_entry_addr): Update.
7947         * hppa-tdep.c (find_unwind_entry)
7948         (hppa_lookup_stub_minimal_symbol): Update.
7949         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7950         Update.
7951         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7952         (elf_gnu_ifunc_resolve_by_got): Update.
7953         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7954         * dwarf-index-write.c (save_gdb_index_command): Update.
7955         * cp-support.c (add_symbol_overload_list_qualified): Update.
7956         * breakpoint.c (create_overlay_event_breakpoint)
7957         (create_longjmp_master_breakpoint)
7958         (create_std_terminate_master_breakpoint)
7959         (create_exception_master_breakpoint): Update.
7960         * blockframe.c (find_pc_partial_function): Update.
7961         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7962         (ada_collect_symbol_completion_matches)
7963         (ada_add_global_exceptions): Update.
7964
7965 2019-01-17  Tom Tromey  <tom@tromey.com>
7966
7967         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7968         declare VEC.
7969         (solib_target_parse_libraries): Change return type.
7970         (library_list_start_segment, library_list_start_section)
7971         (library_list_end_library, library_list_start_library); Update.
7972         (solib_target_free_library_list): Remove.
7973         (solib_target_parse_libraries): Remove cleanup.  Change return
7974         type.
7975         (solib_target_current_sos): Update.
7976
7977 2019-01-17  Tom Tromey  <tromey@bapiya>
7978
7979         * valprint.c: Replace "the the" with "the".
7980         * symtab.c: Replace "the the" with "the".
7981         * solib.c: Replace "the the" with "the".
7982         * solib-dsbt.c: Replace "the the" with "the".
7983         * linespec.c: Replace "the the" with "the".
7984         * dwarf2loc.h: Replace "the the" with "the".
7985         * amd64-windows-tdep.c: Replace "the the" with "the".
7986         * aarch64-tdep.c: Replace "the the" with "the".
7987
7988 2019-01-16  Keith Seitz  <keiths@redhat.com>
7989
7990         PR gdb/23773
7991         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7992         <builder>: Rename to ..
7993         <m_builder>: ... this and make private.
7994         (dwarf2_cu::get_builder): New method.  Change all users of
7995         `builder' to use this method.
7996         (dwarf2_start_symtab): Move to ...
7997         (dwarf2_cu::start_symtab): ... here.  Update all callers
7998         (setup_type_unit_groups): Move to ...
7999         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8000         callers.
8001         (dwarf2_cu::reset_builder): New method.
8002         (process_full_compunit, process_full_type_unit): Use
8003         dwarf2_cu::reset_builder.
8004         (follow_die_offset): Record the ancestor CU if it is different
8005         from the followed DIE's CU.
8006         (follow_die_sig_1): Likewise.
8007
8008 2019-01-15  Tom Tromey  <tom@tromey.com>
8009
8010         * remote.c (class remote_state) <buf>: Now a char_vector.
8011         <buf_size>: Remove.
8012         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8013         parameter.
8014         (remote_target::getpkt_or_notif_sane_1)
8015         (remote_target::getpkt_sane)
8016         (remote_target::getpkt_or_notif_sane): Likewise.
8017         (class remote_target) <putpkt>: New overload.
8018         (remote_target::read_frame): Change type of "buf_p".  Remove
8019         sizeof_p parameter.
8020         (packet_ok): New overload.
8021         (packet_check_result): New overload.
8022         Update all uses.
8023
8024 2019-01-14  Tom Tromey  <tom@tromey.com>
8025
8026         * remote-notif.c (handle_notification, remote_notif_ack)
8027         (remote_notif_parse): Make "buf" const.
8028         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8029         const.
8030         (remote_notif_parse, remote_notif_ack, handle_notification):
8031         Likewise.
8032         * remote.c (remote_notif_stop_parse): Make "buf" const.
8033         (remote_target::remote_parse_stop_reply): Make "buf" const.
8034         (remote_notif_stop_ack): Make "buf" const.
8035
8036 2019-01-14  Tom Tromey  <tom@tromey.com>
8037
8038         * remote.c (remote_console_output): Make parameter const.
8039
8040 2019-01-14  Tom Tromey  <tom@tromey.com>
8041
8042         * target-debug.h (target_debug_print_signals): Constify.
8043         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8044         * procfs.c (procfs_target::pass_signals): Update.
8045         * linux-nat.c (linux_nat_target::pass_signals): Update.
8046         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8047         * target-delegates.c: Rebuild.
8048         * remote.c (remote_target::program_signals): Update.
8049         (remote_target::pass_signals): Update.
8050         * target.c (target_pass_signals): Constify argument.
8051         (target_program_signals): Likewise.
8052         * target.h (struct target_ops) <pass_signals, program_signals>:
8053         Constify argument.
8054         (target_pass_signals, target_program_signals): Constify argument.
8055
8056 2019-01-14  Tom Tromey  <tom@tromey.com>
8057
8058         PR tui/28819:
8059         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8060
8061 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8062
8063         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8064         field.
8065         * rs6000-tdep.c: Include reggroups.h.
8066         (IS_V_ALIAS_PSEUDOREG): Define.
8067         (rs6000_register_name): Return names for the "vX" aliases.
8068         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8069         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8070         aliases.  Call default_register_reggroup_p for all other
8071         pseudo-registers.
8072         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8073         New functions.
8074         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8075         Handle "vX" aliases.
8076         (v_alias_pseudo_register_collect): New function.
8077         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8078         (rs6000_gdbarch_init): Initialize "vX" aliases as
8079         pseudo-registers.  Restore registration of
8080         rs6000_pseudo_register_reggroup_p with
8081         set_tdesc_pseudo_register_reggroup_p.
8082
8083 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8084
8085         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8086         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8087         set_gdbarch_num_pseudo_regs.
8088
8089 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8090
8091         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8092         Remove arg prefixname, add do_set and do_show.
8093         Add member functions set_list and show_list.
8094         * cli/cli-style.c (class cli_style_option): Update accordingly.
8095         (style_set_list): Move to file scope.
8096         (style_show_list): Likewise.
8097         (set_style): Call help_list.
8098         (show_style): Call cmd_show_list.
8099         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8100         Update to use the new macro.
8101
8102 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8103
8104         * ada-lang.c (_initialize_ada_language): Expand the help text
8105         for the "catch exception" command.
8106
8107 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8108
8109         * symtab.c (matching_obj_sections): Initialize obj,
8110         declare it closer to its usage.
8111
8112 2019-01-10  Tom Tromey  <tom@tromey.com>
8113
8114         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8115         (basic_inf_threads_range): Remove.
8116         (inf_threads_range, inf_non_exited_threads_range)
8117         (safe_inf_threads_range): Use next_adapter.
8118
8119 2019-01-10  Keith Seitz  <keiths@redhat.com>
8120
8121         PR gdb/23712
8122         PR symtab/23010
8123         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8124         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8125
8126 2019-01-10  Keith Seitz  <keiths@redhat.com>
8127
8128         PR gdb/23712
8129         PR symtab/23010
8130         * dictionary.c (pending_to_vector): Remove.
8131         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8132         Remove _1 suffix, replacing functions of the same name.  Update
8133         all callers.
8134         (dict_create_hashed, dict_create_hashed_expandable)
8135         (dict_create_linear, dict_create_linear_expandable, dict_free)
8136         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8137         Make functions static.
8138
8139 2019-01-10  Keith Seitz  <keiths@redhat.com>
8140
8141         PR gdb/23712
8142         PR symtab/23010
8143         * dictionary.h (struct dictionary): Replace declaration with
8144         multidictionary.
8145         (dict_create_hashed, dict_create_hashed_expandable)
8146         (dict_create_linear, dict_create_linear_expandable)
8147         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8148         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8149         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8150         taking multidictionary argument.
8151         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8152         * block.h (struct block) <dict>: Change to multidictionary
8153         and rename `multidict'.
8154         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8155         symmisc.c: Update all dictionary references to multidictionary.
8156
8157 2019-01-10  Keith Seitz  <keiths@redhat.com>
8158
8159         PR gdb/23712
8160         PR symtab/23010
8161         * dictionary.c: Include unordered_map.
8162         (pending_to_vector): New function.
8163         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8164         Rewrite the non-"_1" functions to take vector instead
8165         of linked list.
8166         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8167         "new" _1 versions of the same name.
8168         (multidictionary): Define.
8169         (std::hash<enum language): New definition.
8170         (collate_pending_symbols_by_language, mdict_create_hashed)
8171         (mdict_create_hashed_expandable, mdict_create_linear)
8172         (mdict_create_linear_expandable, mdict_free)
8173         (find_language_dictionary, create_new_language_dictionary)
8174         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8175         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8176         (mdict_size, mdict_empty): New functions.
8177         * dictionary.h (mdict_iterator): Define.
8178
8179 2019-01-10  Pedro Alves  <palves@redhat.com>
8180
8181         * breakpoint.c (read_uploaded_action)
8182         (create_tracepoint_from_upload): Adjust to use
8183         gdb::unique_xmalloc_ptr.
8184         * ctf.c (ctf_write_uploaded_tp):
8185         (SET_ARRAY_FIELD): Use emplace_back.
8186         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8187         * tracefile-tfile.c (tfile_write_uploaded_tp):
8188         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8189         gdb::unique_xmalloc_ptr.
8190         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8191         at_string, cond_string, cmd_strings>: Replace char pointers
8192         with gdb::unique_xmalloc_ptr.
8193
8194 2019-01-10  Pedro Alves  <palves@redhat.com>
8195
8196         * solib-target.c (library_list_start_library): Don't xstrdup name.
8197
8198 2019-01-10  Pedro Alves  <palves@redhat.com>
8199
8200         * mdebugread.c (parse_partial_symbols): Use
8201         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8202
8203 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8204
8205         * linux-fork.c (scoped_switch_fork_info)
8206         <~scoped_switch_fork_info>: Fix incorrect variable name.
8207
8208 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8209
8210         * linux-fork.c (scoped_switch_fork_info)
8211         <scoped_switch_fork_info>: Make explicit.
8212         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8213
8214 2019-01-10  Tom Tromey  <tom@tromey.com>
8215
8216         * objfiles.h (objfile::reset_psymtabs): Update.
8217         * objfiles.c (objfile::objfile): Update.
8218         * psymtab.h (psymtab_storage::obstack): Update.
8219         (psymtab_storage::m_obstack): Use gdb::optional.
8220         (class psymtab_storage): Update comment.  Remove objfile
8221         parameter.
8222         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8223
8224 2019-01-10  Tom Tromey  <tom@tromey.com>
8225
8226         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8227         <free_psymtabs>: Now private.
8228         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8229         (allocate_psymtab): Use new method.
8230
8231 2019-01-10  Tom Tromey  <tom@tromey.com>
8232
8233         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8234         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8235         * mdebugread.c (parse_partial_symbols): Use
8236         allocate_dependencies.
8237         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8238         allocate_dependencies.
8239         (process_psymtab_comp_unit_reader)
8240         (build_type_psymtab_dependencies): Likewise.
8241         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8242
8243 2019-01-10  Tom Tromey  <tom@tromey.com>
8244
8245         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8246         PSYMBOL_SET_LANGUAGE.
8247         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8248
8249 2019-01-10  Tom Tromey  <tom@tromey.com>
8250
8251         * psymtab.h (psymtab_storage::obstack): New method.
8252         <m_obstack>: Rename from obstack; now private.
8253         * psymtab.c (psymtab_storage): Update.
8254         * dwarf2read.c (create_addrmap_from_index)
8255         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8256         Update.
8257
8258 2019-01-10  Tom Tromey  <tom@tromey.com>
8259
8260         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8261         * objfiles.h (objfile::reset_psymtabs): New method.
8262
8263 2019-01-10  Tom Tromey  <tom@tromey.com>
8264
8265         * symmisc.c (print_symbol_bcache_statistics): Update.
8266         (print_objfile_statistics): Update.
8267         * symfile.c (reread_symbols): Update.
8268         * psymtab.h (class psymtab_storage): New.
8269         * psymtab.c (psymtab_storage): New constructor.
8270         (~psymtab_storage): New destructor.
8271         (require_partial_symbols): Update.
8272         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8273         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8274         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8275         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8276         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8277         (start_psymtab_common, end_psymtab_common)
8278         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8279         (allocate_psymtab): Update.
8280         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8281         Update.
8282         (dump_psymtab_addrmap, maintenance_print_psymbols)
8283         (maintenance_check_psymtabs): Update.
8284         (class objfile_psymtabs): Move to objfiles.h.
8285         * psympriv.h (discard_psymtab): Now inline.
8286         (psymtab_discarder::psymtab_discarder): Update.
8287         (psymtab_discarder::~psymtab_discarder): Update.
8288         (ALL_OBJFILE_PSYMTABS): Rewrite.
8289         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8290         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8291         Remove fields.
8292         <partial_symtabs>: New field.
8293         (class objfile_psymtabs): Move from psymtab.h.  Update.
8294         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8295         psymbol_cache.
8296         (objfile::~objfile): Don't destroy psymbol_cache.
8297         * mdebugread.c (parse_partial_symbols): Update.
8298         * dwarf2read.c (create_addrmap_from_index)
8299         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8300         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8301         (add_partial_subprogram, dwarf2_ranges_read): Update.
8302         * dwarf-index-write.c (write_address_map)
8303         (write_one_signatured_type, recursively_write_psymbols)
8304         (class debug_names, class debug_names, write_psymtabs_to_index):
8305         Update.
8306
8307 2019-01-10  Tom Tromey  <tom@tromey.com>
8308
8309         * symtab.h (SYMBOL_SET_NAMES): Update.
8310         (symbol_set_names): Update.
8311         (MSYMBOL_SET_NAMES): Update.
8312         * symtab.c (symbol_set_names): Change argument to be an
8313         objfile_per_bfd_storage.
8314         * psymtab.c (add_psymbol_to_bcache): Update.
8315         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8316
8317 2019-01-10  Tom Tromey  <tom@tromey.com>
8318
8319         * symtab.c (create_demangled_names_hash): Change argument to be an
8320         objfile_per_bfd_storage.
8321         (symbol_set_names): Update.
8322
8323 2019-01-10  Tom Tromey  <tom@tromey.com>
8324
8325         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8326         init_psymbol_list.
8327         * psymtab.c (init_psymbol_list): Do nothing if already called.
8328         * psympriv.h (init_psymbol_list): Add comment.
8329         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8330         init_psymbol_list.
8331         * dbxread.c (dbx_symfile_read): Unconditionally call
8332         init_psymbol_list.
8333
8334 2019-01-10  Tom Tromey  <tom@tromey.com>
8335
8336         * xcoffread.c (scan_xcoff_symtab): Update.
8337         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8338         "where".
8339         * mdebugread.c (parse_partial_symbols)
8340         (handle_psymbol_enumerators): Update.
8341         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8342         * dbxread.c (read_dbx_symtab): Update.
8343         * psympriv.h (psymbol_placement): New enum.
8344         (add_psymbol_to_list): Update.
8345
8346 2019-01-10  Tom Tromey  <tom@tromey.com>
8347
8348         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8349         static_psymbols parameters.
8350         (scan_xcoff_symtab): Update.
8351         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8352         static_psymbols parameters.
8353         * psympriv.h (start_psymtab_common): Update.
8354         * mdebugread.c (parse_partial_symbols): Update.
8355         * dwarf2read.c (create_partial_symtab): Update.
8356         * dbxread.c (read_dbx_symtab): Update.
8357         (start_psymtab): Remove global_psymbols and static_psymbols
8358         parameters.
8359
8360 2019-01-10  Tom Tromey  <tom@tromey.com>
8361
8362         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8363         * psymtab.c (allocate_psymtab): Add comment.
8364         * psympriv.h (allocate_psymtab): Add comment.
8365         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8366         initializations.
8367         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8368
8369 2019-01-10  Tom Tromey  <tom@tromey.com>
8370
8371         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8372         Don't declare.
8373         * mipsread.c: Include mdebugread.h.
8374         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8375         Declare.
8376         * elfread.c: Include mdebugread.h.
8377
8378 2019-01-09  Tom Tromey  <tom@tromey.com>
8379
8380         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8381         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8382         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8383         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8384         (psym_lookup_symbol, psym_find_last_source_symtab)
8385         (psym_forget_cached_source_info, psym_print_stats)
8386         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8387         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8388         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8389         (psym_find_compunit_symtab_by_address)
8390         (maintenance_print_psymbols, maintenance_info_psymtabs)
8391         (maintenance_check_psymtabs): Use ranged for.
8392         * psymtab.h (class objfile_psymtabs): New.
8393         (require_partial_symbols): Return objfile_psymtabs.
8394         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8395
8396 2019-01-09  Tom Tromey  <tom@tromey.com>
8397
8398         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8399         (find_pc_mapped_section, list_overlays_command)
8400         (map_overlay_command, unmap_overlay_command)
8401         (simple_overlay_update): Use all_objfiles.
8402         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8403         * printcmd.c (info_symbol_command): Use all_objfiles.
8404         * objfiles.h (ALL_OBJSECTIONS): Remove.
8405         * maint.c (maintenance_translate_address): Use all_objfiles.
8406         * gcore.c (gcore_create_callback): Use all_objfiles.
8407         (objfile_find_memory_regions): Likewise.
8408
8409 2019-01-09  Tom Tromey  <tom@tromey.com>
8410
8411         * symtab.c (find_line_symtab, info_sources_command)
8412         (make_source_files_completion_list): Use objfile_compunits.
8413         * source.c (select_source_symtab): Use objfile_compunits.
8414         * objfiles.h (struct objfile): Update comment.
8415         (ALL_OBJFILES): Remove.
8416         (ALL_FILETABS): Remove.
8417         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8418         objfile_compunits.
8419
8420 2019-01-09  Tom Tromey  <tom@tromey.com>
8421
8422         * symmisc.c (print_objfile_statistics, dump_objfile)
8423         (maintenance_print_symbols): Use compunit_filetabs.
8424         * source.c (forget_cached_source_info_for_objfile): Use
8425         compunit_filetabs.
8426         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8427         (ALL_FILETABS): Use compunit_filetabs.
8428         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8429         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8430
8431 2019-01-09  Tom Tromey  <tom@tromey.com>
8432
8433         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8434         (compunit_filetabs): New.
8435         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8436         compunit_filetabs.
8437         (info_sources_command, make_source_files_completion_list): Remove
8438         declaration.
8439         * symmisc.c (print_objfile_statistics, dump_objfile)
8440         (maintenance_print_symbols): Remove declaration.
8441         (maintenance_info_symtabs): Use compunit_filetabs.
8442         (maintenance_info_line_tables): Likewise.
8443         * source.c (select_source_symtab): Change local variable name.
8444         (forget_cached_source_info_for_objfile): Remove declaration.
8445         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8446         * objfiles.c (objfile_relocate1): Remove declaration.
8447         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8448         declaration.
8449         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8450         * coffread.c (coff_symtab_read): Remove declaration.
8451         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8452         compunit_filetabs.
8453
8454 2019-01-09  Tom Tromey  <tom@tromey.com>
8455
8456         * symtab.c (lookup_objfile_from_block)
8457         (find_pc_sect_compunit_symtab, search_symbols)
8458         (default_collect_symbol_completion_matches_break_on): Use
8459         objfile_compunits.
8460         * objfiles.h (ALL_COMPUNITS): Remove.
8461         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8462         * cp-support.c (add_symbol_overload_list_qualified): Use
8463         objfile_compunits.
8464         * ada-lang.c (ada_collect_symbol_completion_matches)
8465         (ada_add_global_exceptions): Use objfile_compunits.
8466
8467 2019-01-09  Tom Tromey  <tom@tromey.com>
8468
8469         * source.c (select_source_symtab)
8470         (forget_cached_source_info_for_objfile): Remove declaration.
8471         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8472         declaration.
8473         * maint.c (count_symtabs_and_blocks): Remove declaration.
8474         * cp-support.c (add_symbol_overload_list_qualified): Remove
8475         declaration.
8476         * coffread.c (coff_symtab_read): Remove declaration.
8477         * symtab.c (lookup_symbol_in_objfile_symtabs)
8478         (basic_lookup_transparent_type_1): Use objfile_compunits.
8479         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8480         (info_sources_command, search_symbols)
8481         (default_collect_symbol_completion_matches_break_on)
8482         (make_source_files_completion_list): Remove declaration.
8483         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8484         (ada_collect_symbol_completion_matches)
8485         (ada_add_global_exceptions): Remove declaration.
8486         * linespec.c (iterate_over_all_matching_symtabs): Use
8487         objfile_compunits.
8488         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8489         (class objfile_compunits): New.
8490         (ALL_COMPUNITS): Use objfile_compunits.
8491         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8492         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8493         objfile_compunits.
8494         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8495
8496 2019-01-09  Tom Tromey  <tom@tromey.com>
8497
8498         * symtab.c (search_symbols)
8499         (default_collect_symbol_completion_matches_break_on): Use
8500         objfile_msymbols.
8501         * ada-lang.c (ada_lookup_simple_minsym)
8502         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8503         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8504         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8505         objfile_msymbols.
8506         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8507         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8508         * objc-lang.c (find_methods): Use objfile_msymbols.
8509         (info_selectors_command, info_classes_command): Likewise.
8510         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8511         * objfiles.h (class objfile_msymbols): New.
8512         (ALL_OBJFILE_MSYMBOLS): Remove.
8513         (ALL_MSYMBOLS): Remove.
8514
8515 2019-01-09  Tom Tromey  <tom@tromey.com>
8516
8517         * common/next-iterator.h (next_adapter): Add Iterator template
8518         parameter.
8519         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8520         (class all_objfiles_safe): New.
8521         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8522         * objfiles.c (put_objfile_before): Update comment.
8523         (add_separate_debug_objfile): Likewise.
8524         (free_all_objfiles): Use all_objfiles_safe.
8525         (objfile_purge_solibs): Likewise.
8526
8527 2019-01-09  Tom Tromey  <tom@tromey.com>
8528
8529         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8530         (expand_symtab_containing_pc, lookup_static_symbol)
8531         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8532         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8533         all_objfiles.
8534         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8535         * breakpoint.c (create_overlay_event_breakpoint)
8536         (create_longjmp_master_breakpoint)
8537         (create_std_terminate_master_breakpoint)
8538         (create_exception_master_breakpoint): Use all_objfiles.
8539         * linux-thread-db.c (try_thread_db_load_from_pdir)
8540         (has_libpthread): Use all_objfiles.
8541         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8542         * linespec.c (iterate_over_all_matching_symtabs)
8543         (search_minsyms_for_name): Use all_objfiles.
8544         * maint.c (maintenance_info_sections): Use all_objfiles.
8545         * main.c (captured_main_1): Use all_objfiles.
8546         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8547         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8548         * guile/scm-pretty-print.c
8549         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8550         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8551         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8552         (maintenance_print_msymbols): Use all_objfiles.
8553         * source.c (select_source_symtab): Use all_objfiles.
8554         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8555         * symfile.c (remove_symbol_file_command)
8556         (expand_symtabs_matching, map_symbol_filenames): Use
8557         all_objfiles.
8558         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8559         all_objfiles.
8560         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8561         * objc-lang.c (find_methods): Use all_objfiles.
8562         * objfiles.c (have_partial_symbols, have_full_symbols)
8563         (have_minimal_symbols, qsort_cmp)
8564         (default_iterate_over_objfiles_in_search_order): Use
8565         all_objfiles.
8566         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8567         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8568         (maintenance_check_psymtabs): Use all_objfiles.
8569         (ALL_PSYMTABS): Remove.
8570         * compile/compile-object-run.c (do_module_cleanup): Use
8571         all_objfiles.
8572         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8573         * cp-support.c (add_symbol_overload_list_qualified): Use
8574         all_objfiles.
8575         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8576         Use all_objfiles.
8577         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8578         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8579         all_objfiles.
8580         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8581         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8582         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8583         Uses all_objfiles.
8584         * solib.c (solib_read_symbols): Use all_objfiles
8585
8586 2019-01-09  Tom Tromey  <tom@tromey.com>
8587
8588         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8589         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8590         all_objfiles.
8591         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8592         * symmisc.c (print_symbol_bcache_statistics)
8593         (print_objfile_statistics, maintenance_print_objfiles)
8594         (maintenance_info_symtabs, maintenance_check_symtabs)
8595         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8596         all_objfiles.
8597         * source.c (forget_cached_source_info): Use all_objfiles.
8598         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8599         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8600         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8601         * objfiles.c (update_section_map): Use all_objfiles.
8602         (shared_objfile_contains_address_p): Likewise.
8603         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8604         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8605
8606 2019-01-09  Tom Tromey  <tom@tromey.com>
8607
8608         * common/next-iterator.h: New file.
8609         * objfiles.h (class all_objfiles): New.
8610         (struct objfile_iterator): New.
8611
8612 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8613
8614         * NEWS: Move the description of the changed "frame", "select-frame",
8615          and "info frame" commands to the Changed commands section.
8616
8617 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8618
8619         * gdbtypes.c (check_stub_method_group): Remove handling of old
8620         mangling schemes.
8621         * linespec.c (find_methods): Likewise.
8622         * stabsread.c (read_member_functions): Likewise.
8623         * valops.c (search_struct_method): Likewise.
8624         (value_struct_elt_for_reference): Likewise.
8625         * NEWS: Mention this change.
8626
8627 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8628
8629         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8630         print_source_lines.
8631         * source.c (print_source_lines_base): Update line number check.
8632         (print_source_lines): New function.
8633         (source_lines_range::source_lines_range): New function.
8634         * source.h (class source_lines_range): New class.
8635         (print_source_lines): New declaration.
8636
8637 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8638
8639         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8640
8641 2019-01-08  Tom Tromey  <tom@tromey.com>
8642             Simon Marchi  <simon.marchi@ericsson.com>
8643
8644         PR gdb/24060
8645         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8646         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8647         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8648         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8649         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8650         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8651
8652 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8653
8654         * source.c (select_source_symtab): Move header comment to
8655         declaration in source.h.
8656         (forget_cached_source_info_for_objfile): Likewise.
8657         (forget_cached_source_info): Likewise.
8658         (identify_source_line): Likewise.
8659         * source.h (identify_source_line): Move declaration from symtab.h
8660         and add comment from source.c
8661         (print_source_lines): Likewise.
8662         (forget_cached_source_info_for_objfile): Likewise.
8663         (forget_cached_source_info): Likewise.
8664         (select_source_symtab): Likewise.
8665         (enum print_source_lines_flag): Move definition from symtab.h.
8666         * symtab.h (identify_source_line): Move declaration to source.h.
8667         (print_source_lines): Likewise.
8668         (forget_cached_source_info_for_objfile): Likewise.
8669         (forget_cached_source_info): Likewise.
8670         (select_source_symtab): Likewise.
8671         (enum print_source_lines_flag): Move definition to source.h.
8672         * tui/tui-hooks.c: Add 'source.h' include.
8673
8674 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8675
8676         * source.c (print_source_lines_base): Handle requests to print
8677         reverse line number sequences, and guard against empty lines
8678         string.
8679
8680 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8681
8682         * source.c (print_source_lines_base): Fix skip of '\r' if next
8683         character is '\n'.
8684
8685 2019-01-06  Tom Tromey  <tom@tromey.com>
8686
8687         * c-exp.y (struct c_parse_state) <macro_original_text,
8688         expansion_obstack>: New member.
8689         (macro_original_text, expansion_obstack): Remove globals.
8690         (scan_macro_expansion, scanning_macro_expansion)
8691         (finished_macro_expansion): Update.
8692         (scan_macro_cleanup): Remove.
8693         (yylex, c_parse): Update.
8694
8695 2019-01-06  Tom Tromey  <tom@tromey.com>
8696
8697         * c-exp.y (struct c_parse_state) <strings>: New member.
8698         (operator_stoken): Update.
8699
8700 2019-01-06  Tom Tromey  <tom@tromey.com>
8701
8702         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8703         (union type_stack_elt) <typelist_val>: Now a pointer to
8704         std::vector.
8705         (type_stack_cleanup): Don't declare.
8706         (push_typelist): Update.
8707         * parse.c (pop_typelist): Return a std::vector.
8708         (push_typelist): Take a std::vector.
8709         (follow_types): Update.  Do not free args.
8710         (type_stack_cleanup): Remove.
8711         * c-exp.y (struct c_parse_state): New.
8712         (cpstate): New global.
8713         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8714         (nonempty_typelist): Update.
8715         (func_mod): Create a new vector.
8716         (c_parse): Create a c_parse_state.
8717         (check_parameter_typelist): Do not delete params.
8718         (function_method): Update.  Do not delete type_list.
8719
8720 2019-01-06  Tom Tromey  <tom@tromey.com>
8721
8722         PR gdb/28155:
8723         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8724         check_typedef.
8725         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8726         (print_return_value): Likewise.
8727
8728 2019-01-05  Tom Tromey  <tom@tromey.com>
8729
8730         * contrib/cleanup_check.py: Remove.
8731         * contrib/gcc-with-excheck: Remove.
8732         * contrib/exsummary.py: Remove.
8733         * contrib/excheck.py: Remove.
8734
8735 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8736
8737         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8738         NULL. Initialize tpprev to NULL instead of assigning it
8739         to NULL on the next statement.
8740         * windows-nat.c (windows_delete_thread): Remove check for
8741         main_thread_id before printing thread exit notifications.
8742         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8743         Remove thread ID check against main_thread_id.
8744         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8745         windows_delete_thread.
8746         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8747
8748 2019-01-04  Tom Tromey  <tom@tromey.com>
8749
8750         * compile/compile.c (_initialize_compile): Use upper case for
8751         metasyntactic variables.
8752         * symmisc.c (_initialize_symmisc): Use upper case for
8753         metasyntactic variables.
8754         * psymtab.c (_initialize_psymtab): Use upper case for
8755         metasyntactic variables.
8756         * demangle.c (demangle_command): Use upper case for metasyntactic
8757         variables.
8758         (_initialize_demangler): Likewise.
8759         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8760         variables.
8761
8762 2019-01-03  Tom Tromey  <tom@tromey.com>
8763
8764         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8765
8766 2019-01-03  Tom Tromey  <tom@tromey.com>
8767
8768         * python/py-symtab.c (salpy_str): Update.
8769         (struct salpy_sal_object) <symtab>: Now a PyObject.
8770         (salpy_dealloc): Update.
8771         (del_objfile_sal): Use gdbpy_ref.
8772
8773 2019-01-03  Tom Tromey  <tom@tromey.com>
8774
8775         * python/py-type.c (convert_field): Use new_reference.  Return
8776         gdbpy_ref.
8777         (make_fielditem): Return gdbpy_ref.
8778         (typy_fields): Update.
8779         (typy_getitem): Update.
8780         (field_name): Return gdbpy_ref.  Use new_reference.
8781         (typy_iterator_iternext): Update.
8782
8783 2019-01-03  Tom Tromey  <tom@tromey.com>
8784
8785         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8786
8787 2019-01-03  Tom Tromey  <tom@tromey.com>
8788
8789         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8790         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8791         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8792         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8793         (pspy_set_type_printers): Likewise.
8794         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8795         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8796         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8797         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8798         (objfpy_set_type_printers): Likewise.
8799
8800 2019-01-03  Tom Tromey  <tom@tromey.com>
8801
8802         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8803         (gdbpy_print_stack): Use gdbpy_err_fetch.
8804         * python/python-internal.h (class gdbpy_err_fetch): New class.
8805         (class gdbpy_enter) <m_error_type, m_error_value,
8806         m_error_traceback>: Remove.
8807         <m_error>: New member.
8808         (gdbpy_exception_to_string): Don't declare.
8809         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8810         * python/py-value.c (convert_value_from_python): Use
8811         gdbpy_err_fetch.
8812         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8813         gdbpy_exception_to_string.
8814         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8815         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8816         gdbpy_err_fetch.
8817
8818 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8819
8820         * linux-nat.c (delete_lwp_cleanup): Delete.
8821         (struct lwp_deleter): New struct.
8822         (lwp_info_up): New typedef.
8823         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8824         lwp_info_up.
8825
8826 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8827
8828         * linux-fork.c (class scoped_switch_fork_info): New class.
8829         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8830
8831 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8832
8833         * valops.c (find_overload_match): Remove use of null_cleanup, and
8834         calls to do_cleanups.
8835
8836 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8837
8838         * compile/compile-cplus-types.c
8839         (compile_cplus_instance::decl_name): Handle changes to
8840         cp_func_name.
8841         * cp-support.c (cp_func_name): Update header comment, update
8842         return type.
8843         * cp-support.h (cp_func_name): Update return type in declaration.
8844         * valops.c (find_overload_match): Move temp_func local to top
8845         level of function and change its type.  Use temp_func to hold and
8846         delete temporary string obtained from cp_func_name.
8847
8848 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8849
8850         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8851         gdb::char_vector, remove cleanup, and update uses of `msg`.
8852
8853 2019-01-03  Jim Wilson  <jimw@sifive.com>
8854
8855         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8856
8857 2019-01-02  Tom Tromey  <tom@tromey.com>
8858
8859         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8860         (tdesc_parse_xml): Remove cleanups.
8861         * target-descriptions.h (make_cleanup_free_target_description):
8862         Don't declare.
8863         (target_desc_deleter): New struct.
8864         (target_desc_up): New typedef.
8865         * target-descriptions.c (target_desc_deleter::operator()): Rename
8866         from free_target_description.
8867         (make_cleanup_free_target_description): Remove.
8868
8869 2019-01-02  Tom Tromey  <tom@tromey.com>
8870
8871         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8872         constructor, destructor.
8873         (linespec_parser): Remove typedef.
8874         (~linespec_parser): Rename from linespec_parser_delete.
8875         (linespec_lex_to_end, linespec_complete_label)
8876         (linespec_complete): Update.
8877         (decode_line_full): Remove cleanups.
8878         (decode_line_1): Update.
8879
8880 2019-01-02  Tom Tromey  <tom@tromey.com>
8881
8882         * python/python-internal.h (inferior_to_inferior_object): Change
8883         return type.
8884         * python/py-exitedevent.c (create_exited_event_object): Update.
8885         * python/py-inferior.c (inferior_to_inferior_object): Return
8886         gdbpy_ref.
8887         (python_new_inferior, python_inferior_deleted)
8888         (thread_to_thread_object, delete_thread_object)
8889         (build_inferior_list, gdbpy_selected_inferior): Update.
8890         * python/py-infthread.c (create_thread_object): Update.  Also fail
8891         if inferior_to_inferior_object fails.
8892
8893 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8894
8895         * inferior.h (class inferior) <displaced_step_state>: New field.
8896         * infrun.h (struct displaced_step_state): Move here from
8897         infrun.c.  Initialize fields, add constructor.
8898         <inf>: Remove field.
8899         <reset>: New method.
8900         * infrun.c (struct displaced_step_inferior_state): Move to
8901         infrun.h.
8902         (displaced_step_inferior_states): Remove.
8903         (get_displaced_stepping_state): Adust.
8904         (displaced_step_in_progress_any_inferior): Adjust.
8905         (displaced_step_in_progress_thread): Adjust.
8906         (displaced_step_in_progress): Adjust.
8907         (add_displaced_stepping_state): Remove.
8908         (get_displaced_step_closure_by_addr): Adjust.
8909         (remove_displaced_stepping_state): Remove.
8910         (infrun_inferior_exit): Call displaced_step_state.reset.
8911         (use_displaced_stepping): Don't check for NULL.
8912         (displaced_step_prepare_throw): Call
8913         get_displaced_stepping_state.
8914         (displaced_step_fixup): Don't check for NULL.
8915         (prepare_for_detach): Don't check for NULL.
8916
8917 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8918
8919         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8920          in case of call that did not complete.
8921
8922 2019-01-02  Andrey Utkin  <autkin@undo.io>
8923
8924         * symfile.c (find_separate_debug_file): Fix search of debug files for
8925         remote debuggee.
8926
8927 2019-01-02  Tom Tromey  <tom@tromey.com>
8928
8929         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8930         indentation.
8931         * python/py-frame.c (frapy_older): Remove cast.
8932         (frapy_newer): Likewise.
8933         * python/py-breakpoint.c (local_setattro): Remove cast.
8934         * python/py-arch.c (archpy_name): Remove local variable.
8935         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8936
8937 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8938
8939         * unittests/basic_string_view/element_access/char/empty.cc:
8940         Fix year range in copyright header.
8941
8942 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8943
8944         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8945         Delete.
8946         <operator==>: Update with for removed field.
8947         <hash>: Likewise.
8948         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8949         <isa_features>: ...this.
8950         <abi_features>: New field.
8951         (riscv_isa_flen): Update comment.
8952         (riscv_abi_xlen): New declaration.
8953         (riscv_abi_flen): New declaration.
8954         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8955         isa_features.
8956         (riscv_abi_xlen): New function.
8957         (riscv_isa_flen): Update to get answer from isa_features.
8958         (riscv_abi_flen): New function.
8959         (riscv_has_fp_abi): Update to get answer from abi_features.
8960         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8961         xlen and flen.
8962         (riscv_call_info) <xlen, flen>: Update comment.
8963         (riscv_call_arg_struct): Remove invalid assertions
8964         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8965         is removed.
8966         (riscv_gdbarch_init): Gather isa features and abi features
8967         separately, ensure both match on the gdbarch when reusing an old
8968         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8969         a target with 64-bit float hardware.
8970
8971 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8972
8973         * source.c (search_command_helper): Stop reverse search
8974         when line 1 has been searched.
8975
8976 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8977
8978         * record-full.c (record_full_base_target::close): Rewrite
8979         record_full_core_buf_list free logic.
8980
8981 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8982
8983         * break-catch-syscall.c (print_one_catch_syscall): xfree
8984         the last text.
8985
8986 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8987
8988         * top.c (print_gdb_version): Update Copyright year in version
8989         message.
8990
8991 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8992
8993         Update copyright year range in all GDB files.
8994
8995 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8996
8997         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8998
8999 For older changes see ChangeLog-2018.
9000 \f
9001 Local Variables:
9002 mode: change-log
9003 left-margin: 8
9004 fill-column: 74
9005 version-control: never
9006 coding: utf-8
9007 End:
9008