gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tromey@adacore.com>
   2
   3         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
   4         Compare main types.
   5
   6 2019-05-06  Tom Tromey  <tom@tromey.com>
   7
   8         * common/scoped_mmap.c: Include common-defs.h.
   9         * common/scoped_mmap.h: Don't include config.h.
  10
  11 2019-05-04  Tom Tromey  <tom@tromey.com>
  12
  13         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
  14         (struct aarch64_call_info): Add initializers.
  15         <si>: Now a std::vector.
  16         (pass_on_stack, aarch64_push_dummy_call): Update.
  17
  18 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
  19             Tom Tromey  <tom@tromey.com>
  20
  21         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
  22         (ppc_threads): Now a std::vector.  Now static.
  23         (hwdebug_find_thread_points_by_tid)
  24         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
  25         Update.
  26
  27 2019-05-04  Tom Tromey  <tom@tromey.com>
  28
  29         * arc-tdep.c (arc_tdesc_init): Return bool.
  30
  31 2019-05-04  Tom Tromey  <tom@tromey.com>
  32
  33         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
  34         Use gdb_assert_not_reached.
  35
  36 2019-05-04  Tom Tromey  <tom@tromey.com>
  37
  38         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
  39         "false".
  40
  41 2019-05-04  Tom Tromey  <tom@tromey.com>
  42
  43         * arc-tdep.c (arc_tdesc_init): Use bool.
  44
  45 2019-05-04  Tom Tromey  <tom@tromey.com>
  46
  47         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
  48
  49 2019-05-04  Tom Tromey  <tom@tromey.com>
  50
  51         * cli/cli-cmds.c (valid_command_p): Return bool.
  52
  53 2019-05-04  Tom Tromey  <tom@tromey.com>
  54
  55         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
  56         * command.h (valid_user_defined_cmd_name_p): Channge return type.
  57
  58 2019-05-04  Raul Tambre  <raul@tambre.ee>
  59
  60         * python/lib/gdb/prompt.py (_ExtendedPrompt)
  61         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
  62         operator for comparison.
  63
  64 2019-05-04  Tom Tromey  <tom@tromey.com>
  65
  66         * psymtab.c (psymbol_name_matches, match_partial_symbol)
  67         (lookup_partial_symbol, print_partial_symbols)
  68         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
  69         (psymbol_compare): Update.
  70         (add_psymbol_to_bcache): Clear the entire psymbol.
  71         (maintenance_check_psymtabs): Update.
  72         * psympriv.h (struct partial_symbol): Don't derive from
  73         general_symbol_info.
  74         <obj_section, unrelocated_address, address,
  75         set_unrelocated_address>: Update.
  76         <ginfo>: New member.
  77         * dwarf-index-write.c (write_psymbols, debug_names::insert)
  78         (debug_names::write_psymbols): Update.
  79
  80 2019-05-04  Tom de Vries  <tdevries@suse.de>
  81
  82         * contrib/cc-with-tweaks.sh: Support -n arg.
  83
  84 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  85
  86         * corelow.c (core_target::detach): Ensure frame cache and
  87         register caches are cleared.
  88         inferior.c (exit_inferior_1): Likewise.
  89
  90 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
  91             Tom Tromey  <tom@tromey.com>
  92
  93         * dictionary.c (collate_pending_symbols_by_language): Remove
  94         "struct" from foreach.
  95         * symtab.c (lookup_global_symbol_from_objfile)
  96         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
  97         foreach.
  98         * ser-tcp.c (net_open): Remove "struct" from foreach.
  99         * objfiles.c (objfile_relocate, objfile_rebase)
 100         (objfile_has_symbols): Remove "struct" from foreach.
 101         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 102         from foreach.
 103         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 104         foreach.
 105         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 106         "struct" from foreach.
 107         * ada-lang.c (create_excep_cond_exprs)
 108         (ada_exception_catchpoint_cond_string): Remove "struct" from
 109         foreach.
 110
 111 2019-05-03  Tom Tromey  <tromey@adacore.com>
 112
 113         * ada-exp.y (convert_char_literal): Check suffix of each
 114         enumerator.
 115
 116 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 117
 118         PR ada/21406:
 119         * ada-exp.y (yywrap): Don't define.
 120         * ada-lex.l (%option): Add noyywrap
 121         (yywrap): Remove.
 122
 123 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 124
 125         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 126         _WIN32_WINNT to the XP level, unless already defined to a higher
 127         level.
 128
 129         * unittests/parse-connection-spec-selftests.c:
 130         * ser-tcp.c:
 131         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 132         override.
 133
 134         * symfile.c (find_separate_debug_file): Remove colon from the
 135         drive spec of DOS/Windows file names of the target, so that the
 136         file name produced from DEBUGDIR and the target's directory will
 137         be valid on DOS/Windows systems.
 138
 139 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 140
 141         * rust-lang.c (val_print_struct): Handle printing structures
 142         containing strings.
 143
 144 2019-05-02  Tom Tromey  <tromey@adacore.com>
 145
 146         * valarith.c (_initialize_valarith): Remove.
 147
 148 2019-05-01  Tom Tromey  <tromey@adacore.com>
 149
 150         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 151         bitfields.
 152
 153 2019-05-01  Tom Tromey  <tromey@adacore.com>
 154
 155         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 156         for big-endian copies.
 157
 158 2019-04-30  Ali Tamur  <tamur@google.com>
 159         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 160         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 161         (read_3_bytes): New function.
 162
 163 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 164
 165         * windows-nat.c (main_thread_id): Delete.
 166         (handle_output_debug_string): Replace main_thread_id by
 167         current_event.dwThreadId.
 168         (fake_create_process): Likewise.
 169         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 170         Do not set main_thread_id.
 171         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 172         current_event.dwThreadId.
 173         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 174
 175 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 176
 177         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 178         Use current_event.dwThreadId instead of main_thread_id.
 179
 180 2019-04-30  Tom Tromey  <tromey@adacore.com>
 181
 182         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 183         (create_excep_cond_exprs): Iterate over program spaces.
 184         (ada_exception_catchpoint_cond_string): Examine all minimal
 185         symbols for exception types.
 186
 187 2019-04-30  Tom Tromey  <tromey@adacore.com>
 188
 189         PR c++/24470:
 190         * dwarf2read.c (process_structure_scope): Handle case where type
 191         has template parameters but no symbol was created.
 192
 193 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 194             Chris January  <chris.january@arm.com>
 195
 196         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 197         qualifier.
 198         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 199
 200 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 201
 202         * f-typeprint.c (f_print_type): Update rules for printing
 203         whitespace.
 204         (f_type_print_varspec_suffix): Likewise.
 205
 206 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 207             Chris January  <chris.january@arm.com>
 208
 209         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 210         function arguments.
 211
 212 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 213
 214         * f-lang.c (build_fortran_types): Change name of void type to
 215         lower case.
 216         * f-typeprint.c (f_type_print_base): Print the name of the void
 217         type, rather than a fixed string.
 218         * f-valprint.c (f_decorations): Use lower case void string.
 219
 220 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 221             Chris January  <chris.january@arm.com>
 222
 223         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 224         types for Fortran.
 225
 226 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 227             Chris January  <chris.january@arm.com>
 228             David Lecomber  <david.lecomber@arm.com>
 229
 230         * f-exp.y (BINOP_INTRINSIC): New token.
 231         (exp): New parser rule handling BINOP_INTRINSIC.
 232         (f77_keywords): Add new builtin procedures.
 233         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 234         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 235         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 236         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 237         (print_unop_subexp_f): New function.
 238         (print_binop_subexp_f): New function.
 239         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 240         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 241         (dump_subexp_body_f): Likewise.
 242         (operator_check_f): Likewise.
 243         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 244         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 245
 246 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 247
 248         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 249         UNOP_KIND.
 250         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 251         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 252         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 253         (operator_length_f): New fuction.
 254         (print_subexp_f): New function.
 255         (op_name_f): New function.
 256         (dump_subexp_body_f): New function.
 257         (operator_check_f): New function.
 258         (exp_descriptor_f): Replace standard expression handling functions
 259         with new functions.
 260         * gdb/fortran-operator.def: New file.
 261         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 262         * gdb/std-operator.def: Remove UNOP_KIND.
 263
 264 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 265
 266         * std-operator.def: Remove unbalanced, stray double quote
 267         character.
 268
 269 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 270             Chris January  <chris.january@arm.com>
 271             Daniel Everett  <daniel.everett@arm.com>
 272             Nick Forrington  <nick.forrington@arm.com>
 273             Richard Bunt  <richard.bunt@arm.com>
 274
 275         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 276         of depth when printing anonymous structs or unions.
 277         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 278         Don't print either the top-level value, or the children if the
 279         max-depth is exceeded.
 280         (ppscm_print_children): When printing the key of a map, allow one
 281         extra level of depth.
 282         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 283         print either the top-level value, or the children if the max-depth
 284         is exceeded.
 285         (print_children): When printing the key of a map, allow one extra
 286         level of depth.
 287         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 288         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 289         (user_print_options): Initialise max_depth field.
 290         (val_print_scalar_or_string_type_p): New function.
 291         (val_print): Check to see if the max depth has been reached.
 292         (val_print_check_max_depth): Define new function.
 293         (show_print_max_depth): New function.
 294         (_initialize_valprint): Add 'print max-depth' option.
 295         * valprint.h (struct value_print_options) <max_depth>: New field.
 296         (val_print_check_max_depth): Declare new function.
 297         * NEWS: Document new feature.
 298
 299 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 300
 301         * ada-lang.c (ada_language_defn): Initialise new field.
 302         * c-lang.c (c_is_string_type_p): New function.
 303         (c_language_defn): Initialise new field.
 304         (cplus_language_defn): Initialise new field.
 305         (asm_language_defn): Initialise new field.
 306         (minimal_language_defn): Initialise new field.
 307         * c-lang.h (c_is_string_type_p): Declare new function.
 308         * d-lang.c (d_language_defn): Initialise new field.
 309         * f-lang.c (f_is_string_type_p): New function.
 310         (f_language_defn): Initialise new field.
 311         * go-lang.c (go_is_string_type_p): New function.
 312         (go_language_defn): Initialise new field.
 313         * language.c (default_is_string_type_p): New function.
 314         (unknown_language_defn): Initialise new field.
 315         (auto_language_defn): Initialise new field.
 316         * language.h (struct language_defn) <la_is_string_type_p>: New
 317         member variable.
 318         (default_is_string_type_p): Declare new function.
 319         * m2-lang.c (m2_language_defn): Initialise new field.
 320         * objc-lang.c (objc_language_defn): Initialise new field.
 321         * opencl-lang.c (opencl_language_defn): Initialise new field.
 322         * p-lang.c (pascal_is_string_type_p): New function.
 323         (pascal_language_defn): Initialise new field.
 324         * rust-lang.c (rust_is_string_type_p): New function.
 325         (rust_language_defn): Initialise new field.
 326
 327 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 328
 329         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 330         New field.
 331         * ada-lang.c (ada_language_defn): Initialise new field.
 332         * c-lang.c (c_language_defn): Likewise.
 333         (cplus_language_defn): Likewise.
 334         (asm_language_defn): Likewise.
 335         (minimal_language_defn): Likewise.
 336         * d-lang.c (d_language_defn): Likewise.
 337         * f-lang.c (f_language_defn): Likewise.
 338         * go-lang.c (go_language_defn): Likewise.
 339         * language.c (unknown_language_defn): Likewise.
 340         (auto_language_defn): Likewise.
 341         * m2-lang.c (m2_language_defn): Likewise.
 342         * objc-lang.c (objc_language_defn): Likewise.
 343         * opencl-lang.c (opencl_language_defn): Likewise.
 344         * p-lang.c (pascal_language_defn): Likewise.
 345         * rust-lang.c (rust_language_defn): Likewise.
 346
 347 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 348
 349         * ada-lang.c (ada_is_character_type): Change return type to bool.
 350         (ada_is_string_type): Likewise.
 351         * ada-lang.h (ada_is_character_type): Update declaration
 352         (ada_is_string_type): Likewise.
 353
 354 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 355
 356         Support style in 'frame|thread apply'
 357
 358         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 359         * record.c (record_start, record_stop): Update callers of
 360         execute_command_to_string with false.
 361         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 362         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 363         methods.
 364         (class string_file): New constructor with term_out parameter.
 365         Override methods term_out and can_emit_style_escape.  New member
 366         term_out.
 367         (class stdio_file): Override can_emit_style_escape.
 368         (class tee_file): Override term_out and can_emit_style_escape.
 369         * utils.h (can_emit_style_escape): Remove.
 370         * utils.c (can_emit_style_escape): Likewise.
 371         Update all callers of can_emit_style_escape (SOMESTREAM) to
 372         SOMESTREAM->can_emit_style_escape.
 373         * source-cache.c (source_cache::get_source_lines): Likewise.
 374         * stack.c (frame_apply_command_count): Call execute_command_to_string
 375         passing the term_out characteristic of the current gdb_stdout.
 376         * thread.c (thr_try_catch_cmd): Likewise.
 377         * top.c (execute_command_to_string): pass term_out parameter
 378         to construct the string_file for the command output.
 379         * ui-file.c (term_cli_styling): New function (most code moved
 380         from utils.c can_emit_style_escape).
 381         (string_file::string_file, string_file::can_emit_style_escape,
 382         stdio_file::can_emit_style_escape, tee_file::term_out,
 383         tee_file::can_emit_style_escape): New functions.
 384
 385 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 386
 387         * NEWS: Mention the new set|show may-call-functions.
 388         * infcall.c (may_call_functions_p): New variable.
 389         (show_may_call_functions_p): New function.
 390         (call_function_by_hand_dummy): Throws an error if not
 391         may-call-functions.
 392         (_initialize_infcall): Call add_setshow_boolean_cmd for
 393         may-call-functions.
 394
 395 2019-04-25  Keith Seitz  <keiths@redhat.com>
 396
 397         PR c++/24367
 398         * cp-support.c (inspect_type): Don't attempt substitutions
 399         of symbol with the same name.
 400
 401 2019-04-25  Tom Tromey  <tromey@adacore.com>
 402
 403         PR gdb/24475:
 404         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 405         static.
 406
 407 2019-04-25  Tom Tromey  <tromey@adacore.com>
 408
 409         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 410         rvalue reference.
 411         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 412         (gdb_xml_parser::parse): Use std::move.
 413         * python/python-internal.h (gdbpy_convert_exception): Take a const
 414         reference.
 415         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 416         std::move.
 417         * python/py-utils.c (gdbpy_convert_exception): Take a const
 418         reference.
 419         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 420         Use std::move.
 421         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 422         Use std::move.
 423         * mi/mi-main.c (mi_print_exception): Take a const reference.
 424         * main.c (handle_command_errors): Take a const reference.
 425         * linespec.c (parse_linespec): Use std::move.
 426         * infcall.c (run_inferior_call): Use std::move.
 427         (call_function_by_hand_dummy): Use std::move.
 428         * exec.c (try_open_exec_file): Use std::move.
 429         * exceptions.h (exception_print, exception_fprintf)
 430         (exception_print_same): Update.
 431         * exceptions.c (print_exception, exception_print)
 432         (exception_fprintf, exception_print_same): Change parameters to
 433         const reference.
 434         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 435         * common/new-op.c: Use std::move.
 436         * common/common-exceptions.h (struct gdb_exception): Add move
 437         constructor.
 438         (struct gdb_exception_error, struct gdb_exception_quit, struct
 439         gdb_quit_bad_alloc): Change constructor to move constructor.
 440         (throw_exception): Change parameter to rvalue reference.
 441         * common/common-exceptions.c (throw_exception): Take rvalue
 442         reference.
 443         * cli/cli-interp.c (safe_execute_command): Use std::move.
 444         * breakpoint.c (insert_bp_location, location_to_sals): Use
 445         std::move.
 446
 447 2019-04-25  Tom Tromey  <tromey@adacore.com>
 448
 449         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 450         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 451         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 452         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 453         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 454         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 455         guile/scm-value.c: Use unpack.
 456         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 457         gdbscm_gdb_exception.
 458         (gdbscm_throw_gdb_exception): Likewise.
 459         (struct gdbscm_gdb_exception): New.
 460         (unpack): New function.
 461         (gdbscm_wrap): Use unpack.
 462
 463 2019-04-25  Tom Tromey  <tromey@adacore.com>
 464
 465         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 466         (gdb_rl_callback_handler): Use std::move.
 467         * common/common-exceptions.h (struct gdb_exception): Add move
 468         assignment operator.
 469         (throw_exception_sjlj): Change "exception" to const reference.
 470         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 471         (throw_exception_sjlj): Change "exception" to const reference.
 472
 473 2019-04-25  Tom Tromey  <tromey@adacore.com>
 474
 475         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 476         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 477         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 478         Update.
 479         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 480         Update.
 481         * mi/mi-interp.c (mi_interp::exec): Update.
 482         * linespec.c (parse_linespec): Update.
 483         * infcall.c (run_inferior_call): Update.
 484         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 485         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 486         (gdbscm_lookup_global_symbol): Update.
 487         * guile/scm-param.c (gdbscm_parameter_value): Update.
 488         * guile/scm-frame.c (gdbscm_frame_read_register)
 489         (gdbscm_frame_read_var): Update.
 490         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 491         * exec.c (try_open_exec_file): Update.
 492         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 493         (gdb_rl_callback_handler): Update.
 494         * common/common-exceptions.h (exception_none): Don't declare.
 495         * common/common-exceptions.c (exception_none): Don't define.
 496         (struct catcher) <exception>: Update.
 497         * cli/cli-interp.c (safe_execute_command): Update.
 498         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 499
 500 2019-04-25  Ali Tamur  <tamur@google.com>
 501
 502         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 503         (read_attribute_value): Likewise.
 504         (dwarf2_read_addr_index): Update comment.
 505         (read_str_index): Add DW_FORM_strx.
 506         (dwarf2_string_attr): Likewise.
 507         (dwarf2_const_value_attr): Likewise.
 508         (dump_die_shallow): Likewise.
 509         (dwarf2_fetch_constant_bytes): Likewise.
 510         (skip_form_bytes): Likewise.
 511         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 512
 513 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 514
 515         PR corefiles/11608
 516         PR corefiles/18187
 517         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 518         OFFSET.  Verify if current mapping contains an ELF header.
 519         (linux_find_memory_regions_full): Adjust call to
 520         dump_mapping_p.
 521
 522 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 523             Kang Li <kanglictf@gmail.com>
 524
 525         PR gdb/21600
 526
 527         * dwarf2-frame.c (read_initial_length): Be consistent about using
 528         unsigned representation of length.
 529         (decode_frame_entry_1): Likewise.  Check for wraparound of
 530         end pointer as well as buffer overflow.
 531
 532 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 533
 534         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 535         "vq".
 536
 537 2019-04-24  Tom Tromey  <tromey@adacore.com>
 538
 539         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 540
 541 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 542
 543         * s12z-tdep.c (s12z_unwind_pc): Delete.
 544         (s12z_unwind_sp): Delete.
 545         (s12z_gdbarch_init): Don't register deleted functions with
 546         gdbarch.
 547
 548 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 549
 550         * rl78-tdep.c (rl78_unwind_sp): Delete.
 551         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 552
 553 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 554
 555         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 556         (xstormy16_unwind_pc): Delete.
 557         (xstormy16_dummy_id): Delete.
 558         (xstormy16_gdbarch_init): Don't register deleted functions with
 559         gdbarch.
 560
 561 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 562
 563         * vax-tdep.c (vax_unwind_pc): Delete.
 564         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 565
 566 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 567
 568         * v850-tdep.c (v850_unwind_sp): Delete.
 569         (v850_unwind_pc): Delete.
 570         (v850_dummy_id): Delete.
 571         (v850_gdbarch_init): Don't register deleted functions with
 572         gdbarch.
 573
 574 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 575
 576         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 577         (tilegx_unwind_pc): Delete.
 578         (tilegx_unwind_dummy_id): Delete.
 579         (tilegx_gdbarch_init): Don't register deleted functions with
 580         gdbarch.
 581
 582 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 583
 584         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 585         (tic6x_dummy_id): Delete.
 586         (tic6x_gdbarch_init): Don't register deleted functions with
 587         gdbarch.
 588
 589 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 590
 591         * sparc-tdep.c (sparc_unwind_pc): Delete.
 592         (sparc32_gdbarch_init): Don't register deleted function with
 593         gdbarch.
 594
 595 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 596
 597         * sh-tdep.c (sh_unwind_sp): Delete.
 598         (sh_unwind_pc): Delete.
 599         (sh_dummy_id): Delete.
 600         (sh_gdbarch_init): Don't register deleted functions with
 601         gdbarch.
 602
 603 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 604
 605         * score-tdep.c (score_unwind_sp): Delete.
 606         (score_unwind_pc): Delete.
 607         (score_dummy_id): Delete.
 608         (score_gdbarch_init): Don't register deleted functions with
 609         gdbarch.
 610
 611 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 612
 613         * rx-tdep.c (rx_unwind_pc): Delete.
 614         (rx_unwind_sp): Delete.
 615         (rx_dummy_id): Delete.
 616         (rx_gdbarch_init): Don't register deleted functions with
 617         gdbarch.  Update comment.
 618
 619 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 620
 621         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 622         (rs6000_dummy_id): Delete.
 623         (rs6000_gdbarch_init): Don't register deleted functions with
 624         gdbarch.
 625
 626 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 627
 628         * or1k-tdep.c (or1k_dummy_id): Delete.
 629         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 630
 631 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 632
 633         * nios2-tdep.c (nios2_dummy_id): Delete.
 634         (nios2_unwind_sp): Delete.
 635         (nios2_gdbarch_init): Don't register deleted functions with
 636         gdbarch.
 637
 638 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 639
 640         * nds32-tdep.c (nds32_dummy_id): Delete.
 641         (nds32_unwind_pc): Delete.
 642         (nds32_unwind_sp): Delete.
 643         (nds32_gdbarch_init): Don't register deleted functions with
 644         gdbarch.
 645
 646 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 647
 648         * msp430-tdep.c (msp430_unwind_pc): Delete.
 649         (msp430_unwind_sp): Delete.
 650         (msp430_dummy_id): Delete.
 651         (msp430_gdbarch_init): Don't register deleted functions with
 652         gdbarch.
 653
 654 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 655
 656         * moxie-tdep.c (moxie_unwind_sp): Delete.
 657         (moxie_unwind_pc): Delete.
 658         (moxie_dummy_id): Delete.
 659         (moxie_gdbarch_init): Don't register deleted functions with
 660         gdbarch.
 661
 662 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 663
 664         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 665         (mn10300_unwind_pc): Delete.
 666         (mn10300_unwind_sp): Delete.
 667         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 668         mn10300_unwind_sp.
 669         (mn10300_frame_unwind_init): Don't register deleted functions with
 670         gdbarch.
 671
 672 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 673
 674         * mep-tdep.c (mep_unwind_pc): Delete.
 675         (mep_unwind_sp): Delete.
 676         (mep_dummy_id): Delete.
 677         (mep_gdbarch_init): Don't register deleted functions with
 678         gdbarch.
 679
 680 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 681
 682         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 683         (m68hc11_unwind_sp): Delete.
 684         (m68hc11_gdbarch_init): Don't register deleted functions with
 685         gdbarch.
 686
 687 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 688
 689         * m32r-tdep.c (m32r_unwind_sp): Delete.
 690         (m32r_unwind_pc): Delete.
 691         (m32r_dummy_id): Delete.
 692         (m32r_gdbarch_init): Don't register deleted functions with
 693         gdbarch.
 694
 695 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 696
 697         * m32c-tdep.c (m32c_unwind_pc): Delete.
 698         (m32c_unwind_sp): Delete.
 699         (m32c_dummy_id): Delete.
 700         (m32c_gdbarch_init): Don't register deleted functions with
 701         gdbarch.
 702
 703 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 704
 705         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 706         (lm32_unwind_pc): Delete.
 707         (lm32_dummy_id): Delete.
 708         (lm32_gdbarch_init): Don't register deleted functions with
 709         gdbarch.
 710
 711 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 712
 713         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 714         (iq2000_unwind_pc): Delete.
 715         (iq2000_dummy_id): Delete.
 716         (iq2000_gdbarch_init): Don't register deleted functions with
 717         gdbarch.
 718
 719 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 720
 721         * nds32-tdep.c (nds32_type_align): Delete.
 722         (nds32_push_dummy_call): Use type_align instead.
 723
 724 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 725
 726         * arm-tdep.c (arm_type_align): Only handle vector override case.
 727         (arm_push_dummy_call): Use type_align.
 728         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 729
 730 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 731
 732         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 733         case.
 734         (pass_on_stack): Use type_align.
 735         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 736         function.
 737
 738 2019-04-23  Tom Tromey  <tromey@adacore.com>
 739
 740         * dwarf2read.c (line_header::file_name_at): Remove unused
 741         overload.
 742
 743 2019-04-23  Tom de Vries  <tdevries@suse.de>
 744
 745         PR gdb/24438
 746         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 747         invocation.
 748
 749
 750 2019-03-27  Ali Tamur  <tamur@google.com>
 751
 752         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 753         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 754         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 755         (dwarf_expr_context::get_addr_index): Likewise
 756         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 757         (symbol_needs_eval_context::get_addr_index): Likewise
 758         (disassemble_dwarf_expression): Add DW_OP_addrx
 759         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 760         (read_cutu_die_from_dwo): Update comment
 761         (skip_one_die): Add DW_FORM_addrx
 762         (read_attribute_value): Likewise
 763         (var_decode_location): Add DW_OP_addrx
 764         (dwarf2_const_value_attr): Add DW_FORM_addrx
 765         (dump_die_shallow): Likewise
 766         (dwarf2_fetch_constant_bytes): Likewise
 767         (decode_locdesc): Add DW_OP_addrx
 768         (skip_form_bytes): Add DW_FORM_addrx
 769
 770 2019-04-22  Ali Tamur  <tamur@google.com>
 771
 772         * MAINTAINERS (Write After Approval): Add self.
 773
 774 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 775
 776         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 777         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 778         (open_symbol_file_object): Likewise.
 779         (svr4_default_sos): Add info parameter.
 780         (svr4_read_so_list): Likewise.
 781         (svr4_current_sos_direct): Adjust functions calls to pass down
 782         info.
 783         (svr4_current_sos_1): Add info parameter.
 784         (svr4_current_sos): Call get_svr4_info, pass info down to
 785         svr4_current_sos_1.
 786         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 787         get_svr4_info.
 788         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 789         get_svr4_info.
 790         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 791         to get_svr4_info.
 792         (probes_table_remove_objfile_probes): Likewise.
 793         (register_solib_event_probe): Add info parameter.
 794         (solist_update_incremental): Pass info parameter down to
 795         svr4_read_so_list.
 796         (disable_probes_interface): Add info parameter.
 797         (svr4_handle_solib_event): Pass current_program_space to
 798         get_svr4_info.  Adjust disable_probes_interface cleanup.
 799         (svr4_create_probe_breakpoints): Add info parameter, pass it
 800         down to register_solib_event_probe.
 801         (svr4_create_solib_event_breakpoints): Add info parameter,
 802         pass it down to svr4_create_probe_breakpoints.
 803         (enable_break): Pass info down to
 804         svr4_create_solib_event_breakpoints.
 805         (svr4_solib_create_inferior_hook): Pass current_program_space to
 806         get_svr4_info.
 807         (svr4_clear_solib): Likewise.
 808
 809 2019-04-22  Pedro Alves  <palves@redhat.com>
 810
 811         * solib-svr4.c (svr4_free_objfile_observer): New.
 812         (probe_and_action::objfile): New field.
 813         (probes_table_htab_remove_objfile_probes)
 814         (probes_table_remove_objfile_probes): New functions.
 815         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 816         in the new probe_and_action.  Don't store the probe in 'lookup'.
 817         (svr4_create_probe_breakpoints): Pass objfile to
 818         register_solib_event_probe.
 819         (_initialize_svr4_solib): Register a free_objfile observer.
 820
 821 2019-04-19  Tom Tromey  <tom@tromey.com>
 822
 823         * common/queue.h: Remove.
 824
 825 2019-04-19  Tom Tromey  <tom@tromey.com>
 826
 827         * event-loop.c: Don't include "common/queue.h".
 828
 829 2019-04-19  Tom Tromey  <tom@tromey.com>
 830
 831         * remote.c (remote_target): Use delete.
 832         * remote-notif.h: Include <list>, not "common/queue.h".
 833         (notif_client_p): Remove typedef.
 834         (remote_notif_state): Add constructor, destructor, initializer.
 835         <notif_queue>: Now a std::list.
 836         (remote_notif_state_xfree): Don't declare.
 837         * remote-notif.c (remote_notif_process, handle_notification)
 838         (remote_notif_state_allocate): Update.
 839         (~remote_notif_state): Rename from remote_notif_state_xfree.
 840
 841 2019-04-19  Tom Tromey  <tom@tromey.com>
 842
 843         * symfile.c (reread_symbols): Update.
 844         * objfiles.c (objfile_register_static_link)
 845         (objfile_lookup_static_link): Update
 846         (~objfile) Don't delete static_links.
 847         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 848
 849 2019-04-19  Tom Tromey  <tom@tromey.com>
 850
 851         * type-stack.h (struct type_stack) <insert>: Constify string.
 852         * type-stack.c (type_stack::insert): Constify string.
 853         * gdbtypes.h (lookup_template_type): Update.
 854         (address_space_name_to_int): Update.
 855         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 856         const.
 857         (lookup_template_type): Make name const.
 858         * c-exp.y: Update rules.
 859         (lex_one_token, classify_name, classify_inner_name)
 860         (c_print_token): Update.
 861         * p-exp.y: Update rules.
 862         (yylex): Update.
 863         * f-exp.y: Update rules.
 864         (yylex): Update.
 865         * d-exp.y: Update rules.
 866         (lex_one_token, classify_name, classify_inner_name): Update.
 867         * parse.c (write_dollar_variable, copy_name): Return std::string.
 868         * parser-defs.h (copy_name): Change return type.
 869         * m2-exp.y: Update rules.
 870         (yylex): Update.
 871         * go-exp.y (lex_one_token): Update.
 872         Update rules.
 873         (classify_unsafe_function, classify_packaged_name)
 874         (classify_name, yylex): Update.
 875
 876 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 877
 878         * configure.ac: add --enable-source-highlight switch.
 879         * configure: Regenerate.
 880         * top.c (print_gdb_version): plumb --enable-source-highlight
 881         status to "show configuration".
 882
 883 2019-04-19  Tom Tromey  <tromey@adacore.com>
 884
 885         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 886         Check ADA_TYPE_P.
 887         (empty_record, ada_template_to_fixed_record_type_1)
 888         (template_to_static_fixed_type)
 889         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 890         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 891         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 892         macros.
 893
 894 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 895
 896         PR symtab/24423:
 897         * source.c (print_source_lines_base): Advance "iter" when a
 898         control character is seen.
 899
 900 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 901
 902         * inferior.h (struct infcall_suspend_state_deleter):
 903         Catch exception in destructor to avoid crash.
 904
 905 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 906
 907         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 908         close to the add_com "shell".
 909
 910 2019-04-18  Tom Tromey  <tromey@adacore.com>
 911
 912         * process-stratum-target.h (class process_stratum_target)
 913         <stratum>: Add "final".
 914
 915 2019-04-17  Tom Tromey  <tromey@adacore.com>
 916
 917         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 918         against nullptr before use.
 919
 920 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 921
 922         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 923
 924 2019-04-17  Jim Wilson  <jimw@sifive.com>
 925             Andrew Burgess  <andrew.burgess@embecosm.com>
 926
 927         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 928         code read might fail, assume 4-byte breakpoint in that case.
 929
 930 2019-04-15  Leszek Swirski  <leszeks@google.com>
 931
 932         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 933         rather than a hand-rolled POD check when checking for forced MEMORY
 934         classification.
 935
 936 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 937
 938         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 939         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 940         function.
 941         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 942         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 943         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 944         declaration.
 945
 946 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 947
 948         * aarch64-linux-nat.c
 949         (aarch64_linux_nat_target::thread_architecture): Add override.
 950         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 951         each VQ.
 952
 953 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 954
 955         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 956
 957 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 958
 959         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 960         target types of size 96-bits, add some additional comments, and
 961         check that the builtin type we found was the correct size.
 962
 963 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 964
 965         * utils.c (prompt_for_continue): Don't restore the styling at the
 966         end, as applied_style has the wrong value.  This fixes styling in
 967         long lists of file names that are interrupted by the "Continue?"
 968         prompt.
 969
 970 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 971
 972         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 973         * c-lang.c (c_language_defn): Likewise.
 974         (cplus_language_defn): Likewise.
 975         (asm_language_defn): Likewise.
 976         (minimal_language_defn): Likewise.
 977         * d-lang.c (d_language_defn): Likewise.
 978         * f-lang.c (f_language_defn): Likewise.
 979         * go-lang.c (go_language_defn): Likewise.
 980         * language.c (unknown_language_defn): Likewise.
 981         (auto_language_defn): Likewise.
 982         * language.h (struct language_defn): Remove la_magic field.
 983         (LANG_MAGIC): Delete.
 984         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 985         * objc-lang.c (objc_language_defn): Likewise.
 986         * opencl-lang.c (opencl_language_defn): Likewise.
 987         * p-lang.c (pascal_language_defn): Likewise.
 988         * rust-lang.c (rust_language_defn): Likewise.
 989
 990 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 991
 992         * riscv-tdep.c (riscv_type_align): New function.
 993         (riscv_type_alignment): Delete.
 994         (riscv_arg_location): Use 'type_align'.
 995         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 996
 997 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 998
 999         * gdbtypes.c (type_align): A struct with no non-static fields also
1000         has alignment of 1.
1001
1002 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1003
1004         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1005         component to 0.
1006         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1007         member.
1008         (riscv_struct_info::analyse): New implementation using new
1009         analyse_inner member function.
1010         (riscv_struct_info::field_offset): New member function.
1011         (riscv_struct_info::m_offsets): New member variable.
1012         (riscv_struct_info::analyse_inner): New private member function,
1013         takes the old implementation of riscv_struct_info::analyse but
1014         extended to track field offsets.
1015         (riscv_call_arg_struct): Update the struct folding special cases
1016         to handle cases where empty C++ structs, which are non-zero
1017         length, are found.
1018         (riscv_arg_location): Initialise the length of each location, a
1019         non-zero length now indicates the location is in use.
1020         (riscv_push_dummy_call): Allow for the first location having a
1021         non-zero offset when setting up arguments.
1022         (riscv_return_value): Likewise, but for return values.
1023
1024 2019-04-11  Tom Tromey  <tromey@adacore.com>
1025
1026         * utils.c (internal_vproblem): Make "msg" const.
1027
1028 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1029
1030         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1031         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1032         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1033         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1034
1035 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1036
1037         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1038         function.
1039         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1040         of amd64_collect_native_gregset.
1041         (amd64_linux_nat_target::store_registers): Likewise.
1042
1043 2019-04-10  Tom Tromey  <tom@tromey.com>
1044
1045         * symtab.c (lookup_global_symbol_from_objfile)
1046         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1047         * objfiles.h (class separate_debug_iterator): New.
1048         (class separate_debug_range): New.
1049         (struct objfile) <separate_debug_objfiles>: New method.
1050         (objfile_separate_debug_iterate): Don't declare.
1051         * objfiles.c (separate_debug_iterator::operator++): Rename from
1052         objfile_separate_debug_iterate.
1053         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1054         iterator.
1055         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1056         iterator.
1057
1058 2019-04-10  Tom Tromey  <tom@tromey.com>
1059
1060         * symfile.c (reread_symbols): Remove old comment.
1061         * objfiles.c (free_all_objfiles): Fix a typo.
1062
1063 2019-04-10  Tom Tromey  <tom@tromey.com>
1064
1065         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1066         * minsyms.c (lookup_minimal_symbol): Use foreach.
1067         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1068         (lookup_minimal_symbol_solib_trampoline): Likewise.
1069         * symfile.c (reread_symbols): Use foreach.
1070
1071 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1072             Tom Tromey  <tromey@adacore.com>
1073
1074         PR rust/24414:
1075         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1076         (rust_lex_int_test): Change "value" to be LONGEST.
1077         (rust_lex_tests): Add test for long integer literal.
1078
1079 2019-04-09  Tom Tromey  <tromey@adacore.com>
1080
1081         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1082         to bool.
1083         (extended_remote_target::attach): Update.
1084         (remote_target::remote_notice_new_inferior): Update.
1085         (remote_target::add_current_inferior_and_thread): Update.
1086         * inferior.c (exit_inferior_1): Use "false".
1087         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1088
1089 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1090
1091         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1092         the "start" command.
1093
1094 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1095
1096         * python/py-inferior.c (infpy_thread_from_thread_handle):
1097         Adjust comments to reflect renaming of thread_from_thread_handle
1098         to thread_from_handle.  Adjust keywords.  Fix type error message.
1099         (inferior_object_methods): Add thread_from_handle.  Retain
1100         thread_from_thread_handle, but mark it as deprecated.
1101
1102 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1103
1104         * gdbthread.h (find_thread_by_handle): Revise declaration.
1105         * thread.c (find_thread_by_handle): Likewise.  Adjust
1106         implementation too.
1107         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1108         support for buffer objects as handles.
1109
1110 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1111
1112         * python/py-infthread.c (thpy_thread_handle): New function.
1113         (thread_object_methods): Register thpy_thread_handle.
1114
1115 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1116
1117         * gdbthread.h (thread_to_thread_handle): Declare.
1118         * thread.c (gdbtypes.h): Include.
1119         (thread_to_thread_handle): New function.
1120
1121         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1122         (target_thread_info_to_thread_handle): Declare.
1123         * target.c (target_thread_info_to_thread_handle): New function.
1124         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1125         * target-delegates.c: Regenerate.
1126
1127         * linux-thread-db.c (class thread_db_target): Add method
1128         thread_info_to_thread_handle.
1129         (thread_db_target::thread_info_to_thread_handle): Define.
1130         * remote.c (class remote_target): Add new method
1131         thread_info_to_thread_handle.
1132         (remote_target::thread_info_to_thread_handle): Define.
1133
1134 2019-04-08  Pedro Alves  <palves@redhat.com>
1135
1136         * common/common-exceptions.c (throw_exception): Don't create
1137         named object to throw; throw directly.
1138         (throw_it): Likewise.  Don't initialize gdb_exception::message
1139         here, with new; pass FMT and AP to the ctor instead.
1140         * common/common-exceptions.h: Include <string>.
1141         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1142         const char *, va_list)): New ctor.  Use std::make_shared.
1143         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1144         errors)): Delete.
1145         (gdb_exception_error::gdb_exception_error(enum errors, const char
1146         *, va_list)): New.
1147         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1148         Add assertion.
1149         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1150         errors)): Delete.
1151         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1152         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1153         Add assertion.
1154
1155 2019-04-08  Tom Tromey  <tom@tromey.com>
1156
1157         * valops.c (value_rtti_indirect_type): Replace throw_exception
1158         with throw.
1159         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1160         with throw.
1161         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1162         throw.
1163         * target.c (target_translate_tls_address): Replace throw_exception
1164         with throw.
1165         * stack.c (frame_apply_command_count): Replace throw_exception
1166         with throw.
1167         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1168         throw.
1169         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1170         with throw.
1171         * rs6000-tdep.c (rs6000_frame_cache)
1172         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1173         * remote.c: Replace throw_exception with throw.
1174         * record-full.c (record_full_message, record_full_wait_1)
1175         (record_full_restore): Replace throw_exception with throw.
1176         * record-btrace.c:
1177         (get_thread_current_frame_id, record_btrace_start_replaying)
1178         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1179         (cmd_record_btrace_start): Replace throw_exception with throw.
1180         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1181         throw.
1182         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1183         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1184         * linespec.c:
1185         (find_linespec_symbols): Replace throw_exception with throw.
1186         * infrun.c (displaced_step_prepare, resume): Replace
1187         throw_exception with throw.
1188         * infcmd.c (post_create_inferior): Replace throw_exception with
1189         throw.
1190         * inf-loop.c (inferior_event_handler): Replace throw_exception
1191         with throw.
1192         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1193         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1194         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1195         (get_prev_frame_always, get_frame_pc_if_available)
1196         (get_frame_address_in_block_if_available, get_frame_language):
1197         Replace throw_exception with throw.
1198         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1199         throw_exception with throw.
1200         * eval.c (fetch_subexp_value, evaluate_var_value)
1201         (evaluate_funcall, evaluate_subexp_standard): Replace
1202         throw_exception with throw.
1203         * dwarf2loc.c (call_site_find_chain)
1204         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1205         Replace throw_exception with throw.
1206         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1207         with throw.
1208         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1209         throw.
1210         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1211         * completer.c (complete_line_internal): Replace throw_exception
1212         with throw.
1213         * compile/compile-object-run.c (compile_object_run): Replace
1214         throw_exception with throw.
1215         * cli/cli-script.c (process_next_line): Replace throw_exception
1216         with throw.
1217         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1218         (btrace_enable, btrace_maint_update_pt_packets): Replace
1219         throw_exception with throw.
1220         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1221         throw_exception with throw.
1222         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1223         throw_exception with throw.
1224         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1225         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1226         * aarch64-tdep.c (aarch64_make_prologue_cache)
1227         (aarch64_make_stub_cache): Replace throw_exception with throw.
1228
1229 2019-04-08  Tom Tromey  <tom@tromey.com>
1230
1231         * common/common-exceptions.c (throw_exception): Rename from
1232         throw_exception_cxx.  Remove old copy.  Make argument const.
1233         (throw_it): Create and throw exception objects directly.
1234         * common/common-exceptions.h (throw_exception): Make argument
1235         const.
1236         (struct gdb_exception_error): Add constructor.
1237         (struct gdb_exception_quit): Add constructor.
1238
1239 2019-04-08  Tom Tromey  <tom@tromey.com>
1240
1241         * common/common-exceptions.h (exception_rethrow): Don't declare.
1242         (TRY_SJLJ): Update comment.
1243         (TRY, CATCH, END_CATCH): Remove.
1244         * common/common-exceptions.c (exception_rethrow): Remove.
1245
1246 2019-04-08  Tom Tromey  <tom@tromey.com>
1247
1248         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1249         Remove.
1250         (gdb_exception_error): Rename from
1251         gdb_exception_RETURN_MASK_ERROR.
1252         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1253         (gdb_quit_bad_alloc): Update.
1254         * aarch64-tdep.c: Update.
1255         * ada-lang.c: Update.
1256         * ada-typeprint.c: Update.
1257         * ada-valprint.c: Update.
1258         * amd64-tdep.c: Update.
1259         * arch-utils.c: Update.
1260         * break-catch-throw.c: Update.
1261         * breakpoint.c: Update.
1262         * btrace.c: Update.
1263         * c-varobj.c: Update.
1264         * cli/cli-cmds.c: Update.
1265         * cli/cli-interp.c: Update.
1266         * cli/cli-script.c: Update.
1267         * common/common-exceptions.c: Update.
1268         * common/new-op.c: Update.
1269         * common/selftest.c: Update.
1270         * compile/compile-c-symbols.c: Update.
1271         * compile/compile-cplus-symbols.c: Update.
1272         * compile/compile-object-load.c: Update.
1273         * compile/compile-object-run.c: Update.
1274         * completer.c: Update.
1275         * corelow.c: Update.
1276         * cp-abi.c: Update.
1277         * cp-support.c: Update.
1278         * cp-valprint.c: Update.
1279         * darwin-nat.c: Update.
1280         * disasm-selftests.c: Update.
1281         * dtrace-probe.c: Update.
1282         * dwarf-index-cache.c: Update.
1283         * dwarf-index-write.c: Update.
1284         * dwarf2-frame-tailcall.c: Update.
1285         * dwarf2-frame.c: Update.
1286         * dwarf2loc.c: Update.
1287         * dwarf2read.c: Update.
1288         * eval.c: Update.
1289         * event-loop.c: Update.
1290         * event-top.c: Update.
1291         * exec.c: Update.
1292         * f-valprint.c: Update.
1293         * fbsd-tdep.c: Update.
1294         * frame-unwind.c: Update.
1295         * frame.c: Update.
1296         * gdbtypes.c: Update.
1297         * gnu-v3-abi.c: Update.
1298         * guile/guile-internal.h: Update.
1299         * guile/scm-block.c: Update.
1300         * guile/scm-breakpoint.c: Update.
1301         * guile/scm-cmd.c: Update.
1302         * guile/scm-disasm.c: Update.
1303         * guile/scm-frame.c: Update.
1304         * guile/scm-lazy-string.c: Update.
1305         * guile/scm-math.c: Update.
1306         * guile/scm-param.c: Update.
1307         * guile/scm-ports.c: Update.
1308         * guile/scm-pretty-print.c: Update.
1309         * guile/scm-symbol.c: Update.
1310         * guile/scm-symtab.c: Update.
1311         * guile/scm-type.c: Update.
1312         * guile/scm-value.c: Update.
1313         * i386-linux-tdep.c: Update.
1314         * i386-tdep.c: Update.
1315         * inf-loop.c: Update.
1316         * infcall.c: Update.
1317         * infcmd.c: Update.
1318         * infrun.c: Update.
1319         * jit.c: Update.
1320         * language.c: Update.
1321         * linespec.c: Update.
1322         * linux-fork.c: Update.
1323         * linux-nat.c: Update.
1324         * linux-tdep.c: Update.
1325         * linux-thread-db.c: Update.
1326         * main.c: Update.
1327         * mi/mi-cmd-break.c: Update.
1328         * mi/mi-cmd-stack.c: Update.
1329         * mi/mi-interp.c: Update.
1330         * mi/mi-main.c: Update.
1331         * objc-lang.c: Update.
1332         * p-valprint.c: Update.
1333         * parse.c: Update.
1334         * ppc-linux-tdep.c: Update.
1335         * printcmd.c: Update.
1336         * python/py-arch.c: Update.
1337         * python/py-breakpoint.c: Update.
1338         * python/py-cmd.c: Update.
1339         * python/py-finishbreakpoint.c: Update.
1340         * python/py-frame.c: Update.
1341         * python/py-framefilter.c: Update.
1342         * python/py-gdb-readline.c: Update.
1343         * python/py-inferior.c: Update.
1344         * python/py-infthread.c: Update.
1345         * python/py-lazy-string.c: Update.
1346         * python/py-linetable.c: Update.
1347         * python/py-objfile.c: Update.
1348         * python/py-param.c: Update.
1349         * python/py-prettyprint.c: Update.
1350         * python/py-progspace.c: Update.
1351         * python/py-record-btrace.c: Update.
1352         * python/py-record.c: Update.
1353         * python/py-symbol.c: Update.
1354         * python/py-type.c: Update.
1355         * python/py-unwind.c: Update.
1356         * python/py-utils.c: Update.
1357         * python/py-value.c: Update.
1358         * python/python.c: Update.
1359         * record-btrace.c: Update.
1360         * record-full.c: Update.
1361         * remote-fileio.c: Update.
1362         * remote.c: Update.
1363         * riscv-tdep.c: Update.
1364         * rs6000-aix-tdep.c: Update.
1365         * rs6000-tdep.c: Update.
1366         * rust-exp.y: Update.
1367         * rust-lang.c: Update.
1368         * s390-tdep.c: Update.
1369         * selftest-arch.c: Update.
1370         * solib-dsbt.c: Update.
1371         * solib-frv.c: Update.
1372         * solib-spu.c: Update.
1373         * solib-svr4.c: Update.
1374         * solib.c: Update.
1375         * sparc64-linux-tdep.c: Update.
1376         * stack.c: Update.
1377         * symfile-mem.c: Update.
1378         * symmisc.c: Update.
1379         * target.c: Update.
1380         * thread.c: Update.
1381         * top.c: Update.
1382         * tracefile-tfile.c: Update.
1383         * tui/tui.c: Update.
1384         * typeprint.c: Update.
1385         * unittests/cli-utils-selftests.c: Update.
1386         * unittests/parse-connection-spec-selftests.c: Update.
1387         * valops.c: Update.
1388         * valprint.c: Update.
1389         * value.c: Update.
1390         * varobj.c: Update.
1391         * windows-nat.c: Update.
1392         * x86-linux-nat.c: Update.
1393         * xml-support.c: Update.
1394
1395 2019-04-08  Tom Tromey  <tom@tromey.com>
1396
1397         * xml-support.c: Use C++ exception handling.
1398         * x86-linux-nat.c: Use C++ exception handling.
1399         * windows-nat.c: Use C++ exception handling.
1400         * varobj.c: Use C++ exception handling.
1401         * value.c: Use C++ exception handling.
1402         * valprint.c: Use C++ exception handling.
1403         * valops.c: Use C++ exception handling.
1404         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1405         handling.
1406         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1407         * typeprint.c: Use C++ exception handling.
1408         * tui/tui.c: Use C++ exception handling.
1409         * tracefile-tfile.c: Use C++ exception handling.
1410         * top.c: Use C++ exception handling.
1411         * thread.c: Use C++ exception handling.
1412         * target.c: Use C++ exception handling.
1413         * symmisc.c: Use C++ exception handling.
1414         * symfile-mem.c: Use C++ exception handling.
1415         * stack.c: Use C++ exception handling.
1416         * sparc64-linux-tdep.c: Use C++ exception handling.
1417         * solib.c: Use C++ exception handling.
1418         * solib-svr4.c: Use C++ exception handling.
1419         * solib-spu.c: Use C++ exception handling.
1420         * solib-frv.c: Use C++ exception handling.
1421         * solib-dsbt.c: Use C++ exception handling.
1422         * selftest-arch.c: Use C++ exception handling.
1423         * s390-tdep.c: Use C++ exception handling.
1424         * rust-lang.c: Use C++ exception handling.
1425         * rust-exp.y: Use C++ exception handling.
1426         * rs6000-tdep.c: Use C++ exception handling.
1427         * rs6000-aix-tdep.c: Use C++ exception handling.
1428         * riscv-tdep.c: Use C++ exception handling.
1429         * remote.c: Use C++ exception handling.
1430         * remote-fileio.c: Use C++ exception handling.
1431         * record-full.c: Use C++ exception handling.
1432         * record-btrace.c: Use C++ exception handling.
1433         * python/python.c: Use C++ exception handling.
1434         * python/py-value.c: Use C++ exception handling.
1435         * python/py-utils.c: Use C++ exception handling.
1436         * python/py-unwind.c: Use C++ exception handling.
1437         * python/py-type.c: Use C++ exception handling.
1438         * python/py-symbol.c: Use C++ exception handling.
1439         * python/py-record.c: Use C++ exception handling.
1440         * python/py-record-btrace.c: Use C++ exception handling.
1441         * python/py-progspace.c: Use C++ exception handling.
1442         * python/py-prettyprint.c: Use C++ exception handling.
1443         * python/py-param.c: Use C++ exception handling.
1444         * python/py-objfile.c: Use C++ exception handling.
1445         * python/py-linetable.c: Use C++ exception handling.
1446         * python/py-lazy-string.c: Use C++ exception handling.
1447         * python/py-infthread.c: Use C++ exception handling.
1448         * python/py-inferior.c: Use C++ exception handling.
1449         * python/py-gdb-readline.c: Use C++ exception handling.
1450         * python/py-framefilter.c: Use C++ exception handling.
1451         * python/py-frame.c: Use C++ exception handling.
1452         * python/py-finishbreakpoint.c: Use C++ exception handling.
1453         * python/py-cmd.c: Use C++ exception handling.
1454         * python/py-breakpoint.c: Use C++ exception handling.
1455         * python/py-arch.c: Use C++ exception handling.
1456         * printcmd.c: Use C++ exception handling.
1457         * ppc-linux-tdep.c: Use C++ exception handling.
1458         * parse.c: Use C++ exception handling.
1459         * p-valprint.c: Use C++ exception handling.
1460         * objc-lang.c: Use C++ exception handling.
1461         * mi/mi-main.c: Use C++ exception handling.
1462         * mi/mi-interp.c: Use C++ exception handling.
1463         * mi/mi-cmd-stack.c: Use C++ exception handling.
1464         * mi/mi-cmd-break.c: Use C++ exception handling.
1465         * main.c: Use C++ exception handling.
1466         * linux-thread-db.c: Use C++ exception handling.
1467         * linux-tdep.c: Use C++ exception handling.
1468         * linux-nat.c: Use C++ exception handling.
1469         * linux-fork.c: Use C++ exception handling.
1470         * linespec.c: Use C++ exception handling.
1471         * language.c: Use C++ exception handling.
1472         * jit.c: Use C++ exception handling.
1473         * infrun.c: Use C++ exception handling.
1474         * infcmd.c: Use C++ exception handling.
1475         * infcall.c: Use C++ exception handling.
1476         * inf-loop.c: Use C++ exception handling.
1477         * i386-tdep.c: Use C++ exception handling.
1478         * i386-linux-tdep.c: Use C++ exception handling.
1479         * guile/scm-value.c: Use C++ exception handling.
1480         * guile/scm-type.c: Use C++ exception handling.
1481         * guile/scm-symtab.c: Use C++ exception handling.
1482         * guile/scm-symbol.c: Use C++ exception handling.
1483         * guile/scm-pretty-print.c: Use C++ exception handling.
1484         * guile/scm-ports.c: Use C++ exception handling.
1485         * guile/scm-param.c: Use C++ exception handling.
1486         * guile/scm-math.c: Use C++ exception handling.
1487         * guile/scm-lazy-string.c: Use C++ exception handling.
1488         * guile/scm-frame.c: Use C++ exception handling.
1489         * guile/scm-disasm.c: Use C++ exception handling.
1490         * guile/scm-cmd.c: Use C++ exception handling.
1491         * guile/scm-breakpoint.c: Use C++ exception handling.
1492         * guile/scm-block.c: Use C++ exception handling.
1493         * guile/guile-internal.h: Use C++ exception handling.
1494         * gnu-v3-abi.c: Use C++ exception handling.
1495         * gdbtypes.c: Use C++ exception handling.
1496         * frame.c: Use C++ exception handling.
1497         * frame-unwind.c: Use C++ exception handling.
1498         * fbsd-tdep.c: Use C++ exception handling.
1499         * f-valprint.c: Use C++ exception handling.
1500         * exec.c: Use C++ exception handling.
1501         * event-top.c: Use C++ exception handling.
1502         * event-loop.c: Use C++ exception handling.
1503         * eval.c: Use C++ exception handling.
1504         * dwarf2read.c: Use C++ exception handling.
1505         * dwarf2loc.c: Use C++ exception handling.
1506         * dwarf2-frame.c: Use C++ exception handling.
1507         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1508         * dwarf-index-write.c: Use C++ exception handling.
1509         * dwarf-index-cache.c: Use C++ exception handling.
1510         * dtrace-probe.c: Use C++ exception handling.
1511         * disasm-selftests.c: Use C++ exception handling.
1512         * darwin-nat.c: Use C++ exception handling.
1513         * cp-valprint.c: Use C++ exception handling.
1514         * cp-support.c: Use C++ exception handling.
1515         * cp-abi.c: Use C++ exception handling.
1516         * corelow.c: Use C++ exception handling.
1517         * completer.c: Use C++ exception handling.
1518         * compile/compile-object-run.c: Use C++ exception handling.
1519         * compile/compile-object-load.c: Use C++ exception handling.
1520         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1521         * compile/compile-c-symbols.c: Use C++ exception handling.
1522         * common/selftest.c: Use C++ exception handling.
1523         * common/new-op.c: Use C++ exception handling.
1524         * cli/cli-script.c: Use C++ exception handling.
1525         * cli/cli-interp.c: Use C++ exception handling.
1526         * cli/cli-cmds.c: Use C++ exception handling.
1527         * c-varobj.c: Use C++ exception handling.
1528         * btrace.c: Use C++ exception handling.
1529         * breakpoint.c: Use C++ exception handling.
1530         * break-catch-throw.c: Use C++ exception handling.
1531         * arch-utils.c: Use C++ exception handling.
1532         * amd64-tdep.c: Use C++ exception handling.
1533         * ada-valprint.c: Use C++ exception handling.
1534         * ada-typeprint.c: Use C++ exception handling.
1535         * ada-lang.c: Use C++ exception handling.
1536         * aarch64-tdep.c: Use C++ exception handling.
1537
1538 2019-04-08  Tom Tromey  <tom@tromey.com>
1539
1540         * xml-support.c (gdb_xml_parser::parse): Update.
1541         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1542         * value.c (show_convenience): Update.
1543         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1544         (test_parse_flags_qcs): Update.
1545         * thread.c (thr_try_catch_cmd): Update.
1546         * target.c (target_translate_tls_address): Update.
1547         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1548         (info_frame_command_core, frame_apply_command_count): Update.
1549         * rust-exp.y (rust_lex_exception_test): Update.
1550         * riscv-tdep.c (riscv_print_one_register_info): Update.
1551         * remote.c (remote_target::enable_btrace): Update.
1552         * record-btrace.c (record_btrace_enable_warn): Update.
1553         * python/py-utils.c (gdbpy_convert_exception): Update.
1554         * printcmd.c (do_one_display, print_variable_and_value): Update.
1555         * mi/mi-main.c (mi_print_exception): Update.
1556         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1557         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1558         * linux-nat.c (linux_nat_target::attach): Update.
1559         * linux-fork.c (class scoped_switch_fork_info): Update.
1560         * infrun.c (displaced_step_prepare): Update.
1561         * infcall.c (call_function_by_hand_dummy): Update.
1562         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1563         * gnu-v3-abi.c (print_one_vtable): Update.
1564         * frame.c (get_prev_frame_always): Update.
1565         * f-valprint.c (info_common_command_for_block): Update.
1566         * exec.c (try_open_exec_file): Update.
1567         * exceptions.c (print_exception, exception_print)
1568         (exception_fprintf, exception_print_same): Update.
1569         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1570         * dwarf-index-cache.c (index_cache::store)
1571         (index_cache::lookup_gdb_index): Update.
1572         * darwin-nat.c (maybe_cache_shell): Update.
1573         * cp-valprint.c (cp_print_value_fields): Update.
1574         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1575         (gcc_cplus_symbol_address): Update.
1576         * compile/compile-c-symbols.c (gcc_convert_symbol)
1577         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1578         * common/selftest.c: Update.
1579         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1580         a std::string.
1581         (exception_try_scope_entry, exception_try_scope_exit): Don't
1582         declare.
1583         (struct exception_try_scope): Remove.
1584         (TRY): Don't use exception_try_scope.
1585         (struct gdb_exception): Add constructor, operator=.
1586         <what>: New method.
1587         (struct gdb_exception_RETURN_MASK_ALL)
1588         (struct gdb_exception_RETURN_MASK_ERROR)
1589         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1590         (struct gdb_quit_bad_alloc): Update.
1591         * common/common-exceptions.c (exception_none): Change
1592         initializer.
1593         (struct catcher) <state, exception>: Initialize inline.
1594         <prev>: Remove member.
1595         (current_catcher): Remove.
1596         (catchers): New global.
1597         (exceptions_state_mc_init): Simplify.
1598         (catcher_pop): Remove.
1599         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1600         (try_scope_depth, exception_try_scope_entry)
1601         (exception_try_scope_exit): Remove.
1602         (throw_exception_sjlj): Update.
1603         (exception_messages, exception_messages_size): Remove.
1604         (throw_it): Simplify.
1605         (gdb_exception_sliced_copy): Remove.
1606         (throw_exception_cxx): Update.
1607         * cli/cli-script.c (script_from_file): Update.
1608         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1609         Update.
1610         * ada-valprint.c (ada_val_print): Update.
1611         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1612         (create_excep_cond_exprs): Update.
1613
1614 2019-04-08  Tom Tromey  <tom@tromey.com>
1615
1616         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1617         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1618         (TRY, CATCH, END_CATCH): Remove some definitions.
1619         * common/common-exceptions.c: Don't use GDB_XCPT.
1620         (catcher_list_size): Remove.
1621         (throw_exception, throw_it): Simplify.
1622
1623 2019-04-05  Tom Tromey  <tom@tromey.com>
1624
1625         Revert the header-sorting patch.
1626         * ft32-tdep.c: Revert.
1627         * frv-tdep.c: Revert.
1628         * frv-linux-tdep.c: Revert.
1629         * frame.c: Revert.
1630         * frame-unwind.c: Revert.
1631         * frame-base.c: Revert.
1632         * fork-child.c: Revert.
1633         * findvar.c: Revert.
1634         * findcmd.c: Revert.
1635         * filesystem.c: Revert.
1636         * filename-seen-cache.h: Revert.
1637         * filename-seen-cache.c: Revert.
1638         * fbsd-tdep.c: Revert.
1639         * fbsd-nat.h: Revert.
1640         * fbsd-nat.c: Revert.
1641         * f-valprint.c: Revert.
1642         * f-typeprint.c: Revert.
1643         * f-lang.c: Revert.
1644         * extension.h: Revert.
1645         * extension.c: Revert.
1646         * extension-priv.h: Revert.
1647         * expprint.c: Revert.
1648         * exec.h: Revert.
1649         * exec.c: Revert.
1650         * exceptions.c: Revert.
1651         * event-top.c: Revert.
1652         * event-loop.c: Revert.
1653         * eval.c: Revert.
1654         * elfread.c: Revert.
1655         * dwarf2read.h: Revert.
1656         * dwarf2read.c: Revert.
1657         * dwarf2loc.c: Revert.
1658         * dwarf2expr.h: Revert.
1659         * dwarf2expr.c: Revert.
1660         * dwarf2-frame.c: Revert.
1661         * dwarf2-frame-tailcall.c: Revert.
1662         * dwarf-index-write.h: Revert.
1663         * dwarf-index-write.c: Revert.
1664         * dwarf-index-common.c: Revert.
1665         * dwarf-index-cache.h: Revert.
1666         * dwarf-index-cache.c: Revert.
1667         * dummy-frame.c: Revert.
1668         * dtrace-probe.c: Revert.
1669         * disasm.h: Revert.
1670         * disasm.c: Revert.
1671         * disasm-selftests.c: Revert.
1672         * dictionary.c: Revert.
1673         * dicos-tdep.c: Revert.
1674         * demangle.c: Revert.
1675         * dcache.h: Revert.
1676         * dcache.c: Revert.
1677         * darwin-nat.h: Revert.
1678         * darwin-nat.c: Revert.
1679         * darwin-nat-info.c: Revert.
1680         * d-valprint.c: Revert.
1681         * d-namespace.c: Revert.
1682         * d-lang.c: Revert.
1683         * ctf.c: Revert.
1684         * csky-tdep.c: Revert.
1685         * csky-linux-tdep.c: Revert.
1686         * cris-tdep.c: Revert.
1687         * cris-linux-tdep.c: Revert.
1688         * cp-valprint.c: Revert.
1689         * cp-support.c: Revert.
1690         * cp-namespace.c: Revert.
1691         * cp-abi.c: Revert.
1692         * corelow.c: Revert.
1693         * corefile.c: Revert.
1694         * continuations.c: Revert.
1695         * completer.h: Revert.
1696         * completer.c: Revert.
1697         * complaints.c: Revert.
1698         * coffread.c: Revert.
1699         * coff-pe-read.c: Revert.
1700         * cli-out.h: Revert.
1701         * cli-out.c: Revert.
1702         * charset.c: Revert.
1703         * c-varobj.c: Revert.
1704         * c-valprint.c: Revert.
1705         * c-typeprint.c: Revert.
1706         * c-lang.c: Revert.
1707         * buildsym.c: Revert.
1708         * buildsym-legacy.c: Revert.
1709         * build-id.h: Revert.
1710         * build-id.c: Revert.
1711         * btrace.c: Revert.
1712         * bsd-uthread.c: Revert.
1713         * breakpoint.h: Revert.
1714         * breakpoint.c: Revert.
1715         * break-catch-throw.c: Revert.
1716         * break-catch-syscall.c: Revert.
1717         * break-catch-sig.c: Revert.
1718         * blockframe.c: Revert.
1719         * block.c: Revert.
1720         * bfin-tdep.c: Revert.
1721         * bfin-linux-tdep.c: Revert.
1722         * bfd-target.c: Revert.
1723         * bcache.c: Revert.
1724         * ax-general.c: Revert.
1725         * ax-gdb.h: Revert.
1726         * ax-gdb.c: Revert.
1727         * avr-tdep.c: Revert.
1728         * auxv.c: Revert.
1729         * auto-load.c: Revert.
1730         * arm-wince-tdep.c: Revert.
1731         * arm-tdep.c: Revert.
1732         * arm-symbian-tdep.c: Revert.
1733         * arm-pikeos-tdep.c: Revert.
1734         * arm-obsd-tdep.c: Revert.
1735         * arm-nbsd-tdep.c: Revert.
1736         * arm-nbsd-nat.c: Revert.
1737         * arm-linux-tdep.c: Revert.
1738         * arm-linux-nat.c: Revert.
1739         * arm-fbsd-tdep.c: Revert.
1740         * arm-fbsd-nat.c: Revert.
1741         * arm-bsd-tdep.c: Revert.
1742         * arch-utils.c: Revert.
1743         * arc-tdep.c: Revert.
1744         * arc-newlib-tdep.c: Revert.
1745         * annotate.h: Revert.
1746         * annotate.c: Revert.
1747         * amd64-windows-tdep.c: Revert.
1748         * amd64-windows-nat.c: Revert.
1749         * amd64-tdep.c: Revert.
1750         * amd64-sol2-tdep.c: Revert.
1751         * amd64-obsd-tdep.c: Revert.
1752         * amd64-obsd-nat.c: Revert.
1753         * amd64-nbsd-tdep.c: Revert.
1754         * amd64-nbsd-nat.c: Revert.
1755         * amd64-nat.c: Revert.
1756         * amd64-linux-tdep.c: Revert.
1757         * amd64-linux-nat.c: Revert.
1758         * amd64-fbsd-tdep.c: Revert.
1759         * amd64-fbsd-nat.c: Revert.
1760         * amd64-dicos-tdep.c: Revert.
1761         * amd64-darwin-tdep.c: Revert.
1762         * amd64-bsd-nat.c: Revert.
1763         * alpha-tdep.c: Revert.
1764         * alpha-obsd-tdep.c: Revert.
1765         * alpha-nbsd-tdep.c: Revert.
1766         * alpha-mdebug-tdep.c: Revert.
1767         * alpha-linux-tdep.c: Revert.
1768         * alpha-linux-nat.c: Revert.
1769         * alpha-bsd-tdep.c: Revert.
1770         * alpha-bsd-nat.c: Revert.
1771         * aix-thread.c: Revert.
1772         * agent.c: Revert.
1773         * addrmap.c: Revert.
1774         * ada-varobj.c: Revert.
1775         * ada-valprint.c: Revert.
1776         * ada-typeprint.c: Revert.
1777         * ada-tasks.c: Revert.
1778         * ada-lang.c: Revert.
1779         * aarch64-tdep.c: Revert.
1780         * aarch64-ravenscar-thread.c: Revert.
1781         * aarch64-newlib-tdep.c: Revert.
1782         * aarch64-linux-tdep.c: Revert.
1783         * aarch64-linux-nat.c: Revert.
1784         * aarch64-fbsd-tdep.c: Revert.
1785         * aarch64-fbsd-nat.c: Revert.
1786         * aarch32-linux-nat.c: Revert.
1787
1788 2019-04-05  Tom Tromey  <tom@tromey.com>
1789
1790         * ft32-tdep.c: Sort headers.
1791         * frv-tdep.c: Sort headers.
1792         * frv-linux-tdep.c: Sort headers.
1793         * frame.c: Sort headers.
1794         * frame-unwind.c: Sort headers.
1795         * frame-base.c: Sort headers.
1796         * fork-child.c: Sort headers.
1797         * findvar.c: Sort headers.
1798         * findcmd.c: Sort headers.
1799         * filesystem.c: Sort headers.
1800         * filename-seen-cache.h: Sort headers.
1801         * filename-seen-cache.c: Sort headers.
1802         * fbsd-tdep.c: Sort headers.
1803         * fbsd-nat.h: Sort headers.
1804         * fbsd-nat.c: Sort headers.
1805         * f-valprint.c: Sort headers.
1806         * f-typeprint.c: Sort headers.
1807         * f-lang.c: Sort headers.
1808         * extension.h: Sort headers.
1809         * extension.c: Sort headers.
1810         * extension-priv.h: Sort headers.
1811         * expprint.c: Sort headers.
1812         * exec.h: Sort headers.
1813         * exec.c: Sort headers.
1814         * exceptions.c: Sort headers.
1815         * event-top.c: Sort headers.
1816         * event-loop.c: Sort headers.
1817         * eval.c: Sort headers.
1818         * elfread.c: Sort headers.
1819         * dwarf2read.h: Sort headers.
1820         * dwarf2read.c: Sort headers.
1821         * dwarf2loc.c: Sort headers.
1822         * dwarf2expr.h: Sort headers.
1823         * dwarf2expr.c: Sort headers.
1824         * dwarf2-frame.c: Sort headers.
1825         * dwarf2-frame-tailcall.c: Sort headers.
1826         * dwarf-index-write.h: Sort headers.
1827         * dwarf-index-write.c: Sort headers.
1828         * dwarf-index-common.c: Sort headers.
1829         * dwarf-index-cache.h: Sort headers.
1830         * dwarf-index-cache.c: Sort headers.
1831         * dummy-frame.c: Sort headers.
1832         * dtrace-probe.c: Sort headers.
1833         * disasm.h: Sort headers.
1834         * disasm.c: Sort headers.
1835         * disasm-selftests.c: Sort headers.
1836         * dictionary.c: Sort headers.
1837         * dicos-tdep.c: Sort headers.
1838         * demangle.c: Sort headers.
1839         * dcache.h: Sort headers.
1840         * dcache.c: Sort headers.
1841         * darwin-nat.h: Sort headers.
1842         * darwin-nat.c: Sort headers.
1843         * darwin-nat-info.c: Sort headers.
1844         * d-valprint.c: Sort headers.
1845         * d-namespace.c: Sort headers.
1846         * d-lang.c: Sort headers.
1847         * ctf.c: Sort headers.
1848         * csky-tdep.c: Sort headers.
1849         * csky-linux-tdep.c: Sort headers.
1850         * cris-tdep.c: Sort headers.
1851         * cris-linux-tdep.c: Sort headers.
1852         * cp-valprint.c: Sort headers.
1853         * cp-support.c: Sort headers.
1854         * cp-namespace.c: Sort headers.
1855         * cp-abi.c: Sort headers.
1856         * corelow.c: Sort headers.
1857         * corefile.c: Sort headers.
1858         * continuations.c: Sort headers.
1859         * completer.h: Sort headers.
1860         * completer.c: Sort headers.
1861         * complaints.c: Sort headers.
1862         * coffread.c: Sort headers.
1863         * coff-pe-read.c: Sort headers.
1864         * cli-out.h: Sort headers.
1865         * cli-out.c: Sort headers.
1866         * charset.c: Sort headers.
1867         * c-varobj.c: Sort headers.
1868         * c-valprint.c: Sort headers.
1869         * c-typeprint.c: Sort headers.
1870         * c-lang.c: Sort headers.
1871         * buildsym.c: Sort headers.
1872         * buildsym-legacy.c: Sort headers.
1873         * build-id.h: Sort headers.
1874         * build-id.c: Sort headers.
1875         * btrace.c: Sort headers.
1876         * bsd-uthread.c: Sort headers.
1877         * breakpoint.h: Sort headers.
1878         * breakpoint.c: Sort headers.
1879         * break-catch-throw.c: Sort headers.
1880         * break-catch-syscall.c: Sort headers.
1881         * break-catch-sig.c: Sort headers.
1882         * blockframe.c: Sort headers.
1883         * block.c: Sort headers.
1884         * bfin-tdep.c: Sort headers.
1885         * bfin-linux-tdep.c: Sort headers.
1886         * bfd-target.c: Sort headers.
1887         * bcache.c: Sort headers.
1888         * ax-general.c: Sort headers.
1889         * ax-gdb.h: Sort headers.
1890         * ax-gdb.c: Sort headers.
1891         * avr-tdep.c: Sort headers.
1892         * auxv.c: Sort headers.
1893         * auto-load.c: Sort headers.
1894         * arm-wince-tdep.c: Sort headers.
1895         * arm-tdep.c: Sort headers.
1896         * arm-symbian-tdep.c: Sort headers.
1897         * arm-pikeos-tdep.c: Sort headers.
1898         * arm-obsd-tdep.c: Sort headers.
1899         * arm-nbsd-tdep.c: Sort headers.
1900         * arm-nbsd-nat.c: Sort headers.
1901         * arm-linux-tdep.c: Sort headers.
1902         * arm-linux-nat.c: Sort headers.
1903         * arm-fbsd-tdep.c: Sort headers.
1904         * arm-fbsd-nat.c: Sort headers.
1905         * arm-bsd-tdep.c: Sort headers.
1906         * arch-utils.c: Sort headers.
1907         * arc-tdep.c: Sort headers.
1908         * arc-newlib-tdep.c: Sort headers.
1909         * annotate.h: Sort headers.
1910         * annotate.c: Sort headers.
1911         * amd64-windows-tdep.c: Sort headers.
1912         * amd64-windows-nat.c: Sort headers.
1913         * amd64-tdep.c: Sort headers.
1914         * amd64-sol2-tdep.c: Sort headers.
1915         * amd64-obsd-tdep.c: Sort headers.
1916         * amd64-obsd-nat.c: Sort headers.
1917         * amd64-nbsd-tdep.c: Sort headers.
1918         * amd64-nbsd-nat.c: Sort headers.
1919         * amd64-nat.c: Sort headers.
1920         * amd64-linux-tdep.c: Sort headers.
1921         * amd64-linux-nat.c: Sort headers.
1922         * amd64-fbsd-tdep.c: Sort headers.
1923         * amd64-fbsd-nat.c: Sort headers.
1924         * amd64-dicos-tdep.c: Sort headers.
1925         * amd64-darwin-tdep.c: Sort headers.
1926         * amd64-bsd-nat.c: Sort headers.
1927         * alpha-tdep.c: Sort headers.
1928         * alpha-obsd-tdep.c: Sort headers.
1929         * alpha-nbsd-tdep.c: Sort headers.
1930         * alpha-mdebug-tdep.c: Sort headers.
1931         * alpha-linux-tdep.c: Sort headers.
1932         * alpha-linux-nat.c: Sort headers.
1933         * alpha-bsd-tdep.c: Sort headers.
1934         * alpha-bsd-nat.c: Sort headers.
1935         * aix-thread.c: Sort headers.
1936         * agent.c: Sort headers.
1937         * addrmap.c: Sort headers.
1938         * ada-varobj.c: Sort headers.
1939         * ada-valprint.c: Sort headers.
1940         * ada-typeprint.c: Sort headers.
1941         * ada-tasks.c: Sort headers.
1942         * ada-lang.c: Sort headers.
1943         * aarch64-tdep.c: Sort headers.
1944         * aarch64-ravenscar-thread.c: Sort headers.
1945         * aarch64-newlib-tdep.c: Sort headers.
1946         * aarch64-linux-tdep.c: Sort headers.
1947         * aarch64-linux-nat.c: Sort headers.
1948         * aarch64-fbsd-tdep.c: Sort headers.
1949         * aarch64-fbsd-nat.c: Sort headers.
1950         * aarch32-linux-nat.c: Sort headers.
1951
1952 2019-04-04  Tom Tromey  <tom@tromey.com>
1953
1954         * varobj.c (varobj_create): Update.
1955         * rust-exp.y (struct rust_parser) <update_innermost_block,
1956         lookup_symbol>: New methods.
1957         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1958         Rename.
1959         (rust_parser::rust_lookup_type)
1960         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1961         * printcmd.c (display_command, do_one_display): Update.
1962         * parser-defs.h (struct parser_state) <parser_state>: Add
1963         "tracker" parameter.
1964         (block_tracker): New member.
1965         (class innermost_block_tracker) <innermost_block_tracker>: Add
1966         "types" parameter.
1967         <reset>: Remove method.
1968         (innermost_block): Don't declare.
1969         (null_post_parser): Update.
1970         * parse.c (innermost_block): Remove global.
1971         (write_dollar_variable): Update.
1972         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1973         Remove "tracker_types" parameter.
1974         (parse_expression): Add "tracker" parameter.
1975         (parse_expression_for_completion): Update.
1976         (null_post_parser): Add "tracker" parameter.
1977         * p-exp.y: Update rules.
1978         * m2-exp.y: Update rules.
1979         * language.h (struct language_defn) <la_post_parser>: Add
1980         "tracker" parameter.
1981         * go-exp.y: Update rules.
1982         * f-exp.y: Update rules.
1983         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1984         parameter.
1985         * d-exp.y: Update rules.
1986         * c-exp.y: Update rules.
1987         * breakpoint.c (set_breakpoint_condition): Create an
1988         innermost_block_tracker.
1989         (watch_command_1): Likewise.
1990         * ada-lang.c (resolve): Add "tracker" parameter.
1991         (resolve_subexp): Likewise.
1992         * ada-exp.y (write_var_from_sym): Update.
1993
1994 2019-04-04  Tom Tromey  <tom@tromey.com>
1995
1996         * type-stack.h: New file.
1997         * type-stack.c: New file.
1998         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1999         type-stack.h.
2000         (insert_into_type_stack, insert_type, push_type, push_type_int)
2001         (insert_type_address_space, pop_type, pop_type_int)
2002         (pop_typelist, pop_type_stack, append_type_stack)
2003         (push_type_stack, get_type_stack, push_typelist)
2004         (follow_type_instance_flags, follow_types): Don't declare.
2005         * parse.c (type_stack): Remove global.
2006         (parse_exp_in_context): Update.
2007         (insert_into_type_stack, insert_type, push_type, push_type_int)
2008         (insert_type_address_space, pop_type, pop_type_int)
2009         (pop_typelist, pop_type_stack, append_type_stack)
2010         (push_type_stack, get_type_stack, push_typelist)
2011         (follow_type_instance_flags, follow_types): Remove (moved to
2012         type-stack.c).
2013         * f-exp.y (type_stack): New global.
2014         Update rules.
2015         (push_kind_type, f_parse): Update.
2016         * d-exp.y (type_stack): New global.
2017         Update rules.
2018         (d_parse): Update.
2019         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2020         Update rules.
2021         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2022         (HFILES_NO_SRCDIR): Add type-stack.h.
2023
2024 2019-04-04  Tom Tromey  <tom@tromey.com>
2025
2026         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2027         (rust_parser::convert_ast_to_expression, rust_parse)
2028         (rust_lex_test_completion, rust_lex_tests): Update.
2029         * parser-defs.h (struct expr_completion_state): New.
2030         (struct parser_state) <parser_state>: Add completion parameter.
2031         <mark_struct_expression, mark_completion_tag>: New methods.
2032         <parse_completion, m_completion_state>: New members.
2033         (prefixify_expression, null_post_parser): Update.
2034         (mark_struct_expression, mark_completion_tag): Don't declare.
2035         * parse.c (parse_completion, expout_last_struct)
2036         (expout_tag_completion_type, expout_completion_name): Remove
2037         globals.
2038         (parser_state::mark_struct_expression)
2039         (parser_state::mark_completion_tag): Now methods.
2040         (prefixify_expression): Add last_struct parameter.
2041         (prefixify_subexp): Likewise.
2042         (parse_exp_1): Update.
2043         (parse_exp_in_context): Add cstate parameter.  Update.
2044         (parse_expression_for_completion): Create an
2045         expr_completion_state.
2046         (null_post_parser): Add "completion" parameter.
2047         * p-exp.y: Update rules.
2048         (yylex): Update.
2049         * language.h (struct language_defn) <la_post_parser>: Add
2050         "completing" parameter.
2051         * go-exp.y: Update rules.
2052         (lex_one_token): Update.
2053         * expression.h (parse_completion): Don't declare.
2054         * d-exp.y: Update rules.
2055         (lex_one_token): Update rules.
2056         * c-exp.y: Update rules.
2057         (lex_one_token): Update.
2058         * ada-lang.c (resolve): Add "parse_completion" parameter.
2059         (resolve_subexp): Likewise.
2060         (ada_resolve_function): Likewise.
2061
2062 2019-04-04  Tom Tromey  <tom@tromey.com>
2063
2064         * parser-defs.h (struct parser_state) <start_arglist,
2065         end_arglist>: New methods.
2066         <arglist_len, m_funcall_chain>: New members.
2067         (arglist_len, start_arglist, end_arglist): Don't declare.
2068         * parse.c (arglist_len, funcall_chain): Remove global.
2069         (start_arglist, end_arglist): Remove functions.
2070         (parse_exp_in_context): Update.
2071         * p-exp.y: Update rules.
2072         * m2-exp.y: Update rules.
2073         * go-exp.y: Update rules.
2074         * f-exp.y: Update rules.
2075         * d-exp.y: Update rules.
2076         * c-exp.y: Update rules.
2077
2078 2019-04-04  Tom Tromey  <tom@tromey.com>
2079
2080         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2081         lex_operator, push_back>: New methods.
2082         Update all rules.
2083         (rust_parser::lex_hex, lex_escape): Rename and update.
2084         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2085         (rust_parser::lex_operator): Rename and update.
2086         (rust_parser::lex_number, rustyylex, rustyyerror)
2087         (rust_lex_test_init, rust_lex_test_sequence)
2088         (rust_lex_test_push_back, rust_lex_tests): Update.
2089         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2090         parameter.
2091         <lexptr, prev_lexptr>: New members.
2092         (lexptr, prev_lexptr): Don't declare.
2093         * parse.c (lexptr, prev_lexptr): Remove globals.
2094         (parse_exp_in_context): Update.
2095         * p-exp.y (yylex, yyerror): Update.
2096         * m2-exp.y (parse_number, yylex, yyerror): Update.
2097         * go-exp.y (lex_one_token, yyerror): Update.
2098         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2099         * d-exp.y (lex_one_token, yyerror): Update.
2100         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2101         (lex_one_token, yyerror): Update.
2102         * ada-lex.l (YY_INPUT): Update.
2103         (rewind_to_char): Update.
2104         * ada-exp.y (yyerror): Update.
2105
2106 2019-04-04  Tom Tromey  <tom@tromey.com>
2107
2108         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2109         * parser-defs.h (struct parser_state) <parser_state>: Add new
2110         parameter.
2111         <comma_terminates>: New member.
2112         (comma_terminates): Don't declare global.
2113         * parse.c (comma_terminates): Remove global.
2114         (parse_exp_in_context): Update.
2115         * p-exp.y (yylex): Update.
2116         * m2-exp.y (yylex): Update.
2117         * go-exp.y (lex_one_token): Update.
2118         * f-exp.y (yylex): Update.
2119         * d-exp.y (lex_one_token): Update.
2120         * c-exp.y (lex_one_token): Update.
2121         * ada-lex.l: Update.
2122
2123 2019-04-04  Tom Tromey  <tom@tromey.com>
2124
2125         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2126         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2127         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2128         * parser-defs.h (paren_depth): Don't declare.
2129         * parse.c (paren_depth): Remove global.
2130         (parse_exp_in_context): Update.
2131         * p-exp.y (paren_depth): New global.
2132         (pascal_parse): Initialize it.
2133         * m2-exp.y (paren_depth): New global.
2134         (m2_parse): Initialize it.
2135         * go-exp.y (paren_depth): New global.
2136         (go_parse): Initialize it.
2137         * f-exp.y (paren_depth): New global.
2138         (f_parse): Initialize it.
2139         * d-exp.y (paren_depth): New global.
2140         (d_parse): Initialize it.
2141         * c-exp.y (paren_depth): New global.
2142         (c_parse): Initialize it.
2143         * ada-lex.l (paren_depth): New global.
2144         (lexer_init): Initialize it.
2145
2146 2019-04-04  Tom Tromey  <tom@tromey.com>
2147
2148         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2149         (rust_parser::convert_ast_to_type)
2150         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2151         * parser-defs.h (struct parser_state) <parser_state>: Add
2152         parameters.  Initialize new members.
2153         <expression_context_block, expression_context_pc>: New members.
2154         * parse.c (expression_context_block, expression_context_pc):
2155         Remove globals.
2156         (parse_exp_in_context): Update.
2157         * p-exp.y: Update all rules.
2158         (yylex): Update.
2159         * m2-exp.y: Update all rules.
2160         (yylex): Update.
2161         * go-exp.y (yylex): Update.
2162         * f-exp.y (yylex): Update.
2163         * d-exp.y: Update all rules.
2164         (yylex): Update.
2165         * c-exp.y: Update all rules.
2166         (lex_one_token, classify_name, yylex, c_parse): Update.
2167         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2168
2169 2019-04-04  Tom Tromey  <tom@tromey.com>
2170
2171         * gdbarch.h, gdbarch.c: Rebuild.
2172         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2173         * stap-probe.h:
2174         (struct stap_parse_info): Replace "parser_state" with
2175         "expr_builder".
2176         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2177         (parser_state): New class.
2178         * parse.c (expr_builder): Rename.
2179         (expr_builder::release): Rename.
2180         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2181         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2182         (write_exp_elt_longcst, write_exp_elt_floatcst)
2183         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2184         (write_exp_string_vector, write_exp_bitstring)
2185         (write_exp_msymbol, mark_struct_expression)
2186         (write_dollar_variable)
2187         (insert_type_address_space, increase_expout_size): Replace
2188         "parser_state" with "expr_builder".
2189         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2190         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2191         "parser_state" with "expr_builder".
2192
2193 2019-04-04  Tom Tromey  <tom@tromey.com>
2194
2195         * rust-exp.y: Replace "parse_language" with method call.
2196         * p-exp.y:
2197         (yylex): Replace "parse_language" with method call.
2198         * m2-exp.y:
2199         (yylex): Replace "parse_language" with method call.
2200         * go-exp.y (classify_name): Replace "parse_language" with method
2201         call.
2202         * f-exp.y (yylex): Replace "parse_language" with method call.
2203         * d-exp.y (lex_one_token): Replace "parse_language" with method
2204         call.
2205         * c-exp.y:
2206         (lex_one_token, classify_name, yylex): Replace "parse_language"
2207         with method call.
2208         * ada-exp.y (find_primitive_type, type_char)
2209         (type_system_address): Replace "parse_language" with method call.
2210
2211 2019-04-04  Tom Tromey  <tom@tromey.com>
2212
2213         * rust-exp.y: Replace "parse_gdbarch" with method call.
2214         * parse.c (write_dollar_variable, insert_type_address_space):
2215         Replace "parse_gdbarch" with method call.
2216         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2217         call.
2218         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2219         call.
2220         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2221         "parse_gdbarch" with method call.
2222         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2223         with method call.
2224         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2225         "parse_gdbarch" with method call.
2226         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2227         "parse_gdbarch" with method call.
2228         * c-exp.y (parse_type, parse_number, classify_name): Replace
2229         "parse_gdbarch" with method call.
2230         * ada-lex.l: Replace "parse_gdbarch" with method call.
2231         * ada-exp.y (parse_type, find_primitive_type, type_char)
2232         (type_system_address): Replace "parse_gdbarch" with method call.
2233
2234 2019-04-04  Tom Tromey  <tom@tromey.com>
2235
2236         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2237         * stap-probe.c (stap_parse_argument): Update.
2238         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2239         initial_size parameter.
2240         * rust-exp.y (rust_lex_tests): Update.
2241         * parse.c (parser_state): Update.
2242         (parse_exp_in_context): Update.
2243         * parser-defs.h (struct parser_state) <parser_state>: Remove
2244         "initial_size" parameter.
2245
2246 2019-04-04  Tom Tromey  <tom@tromey.com>
2247
2248         * parser-defs.h (increase_expout_size): Don't declare.
2249         * parse.c (increase_expout_size): Now static.
2250
2251 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2252
2253         * gnu-nat.c (gnu_nat_target::wait): Fix
2254         target_waitstatus_to_string call.
2255
2256 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2257
2258         * eval.c (evaluate_subexp_standard): Handle internal functions
2259         during Fortran function call handling.
2260
2261 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2262
2263         * NEWS: Mention new internal functions.
2264         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2265         (read_base_type): Use dwarf2_init_complex_target_type.
2266         * value.c (creal_internal_fn): New function.
2267         (cimag_internal_fn): New function.
2268         (_initialize_values): Register new internal functions.
2269
2270 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2271
2272         * infrun.c (stop_all_threads): If debug_infrun, always
2273         trace the wait status after wait_one, using
2274         target_waitstatus_to_string and target_pid_to_str.
2275         (handle_inferior_event): Replace various trace of
2276         wait status kind by a single trace.
2277         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2278         wait status kind image by target_waitstatus_to_string.
2279         * target/waitstatus.c (target_waitstatus_to_string): Fix
2280         obsolete comment.
2281
2282 2019-04-01  Tom Tromey  <tromey@adacore.com>
2283
2284         PR symtab/23331:
2285         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2286
2287 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2288             Pedro Alves  <palves@redhat.com>
2289
2290         * top.c (quit_force): Call 'finalize_values'.
2291         * value.c (finalize_values): New function.
2292         * value.h (finalize_values): Declare.
2293
2294 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2295
2296         * NEWS: Announce $_gdb_major and $_gdb_minor.
2297
2298         * top.c (init_gdb_version_vars): New function.
2299         (gdb_init): Call init_gdb_version_vars.
2300
2301 2019-03-29  Tom Tromey  <tromey@adacore.com>
2302
2303         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2304         help text.  Remove dead code.
2305
2306 2019-03-29  Keith Seitz  <keiths@redhat.com>
2307
2308         From Siddhesh Poyarekar:
2309         * f-lang.h (f77_get_upperbound): Return LONGEST.
2310         (f77_get_lowerbound): Likewise.
2311         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2312         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2313         print them.
2314         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2315         plongest to format print it.
2316         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2317         (f77_get_upperbound): Likewise.
2318         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2319         LOWER_BOUND to LONGEST.
2320         (f77_create_arrayprint_offset_tbl): Likewise.
2321
2322 2019-03-29  Keith Seitz  <keiths@redhat.com>
2323
2324         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2325         %s/pulongest for TYPE_LENGTH instead of %d in format
2326         strings.
2327         * ada-typerint.c (ada_print_type): Likewise.
2328         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2329         * compile/compile-c-support.c (generate_register_struct): Likewise.
2330         * gdbtypes.c (recursive_dump_type): Likewise.
2331         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2332         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2333         instead of %d in format strings.
2334         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2335         to std::min to ULONGEST.
2336         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2337         instead of %d in format strings.
2338         * tracepoint.c (info_scope_command): Likewise.
2339         * typeprint.c (print_offset_data::update)
2340         (print_offset_data::finish): Likewise.
2341         * xtensa-tdep.c (xtensa_store_return_value)
2342         (xtensa_push_dummy_call): Likewise.
2343
2344 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2345
2346         * windows-nat.c (display_selector): Fixed format specifications
2347         for 64-bit Cygwin.
2348
2349 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2350
2351         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2352
2353 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2354
2355         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2356         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2357         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2358         (nios2_linux_init_abi): Install it.
2359
2360 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2361
2362         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2363
2364 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2365
2366         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2367
2368 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2369             Tom Tromey  <tromey@adacore.com>
2370
2371         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2372
2373 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2374
2375         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2376         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2377         method to compute the bounds of range types. Also print "[evaluated]"
2378         if the bounds' values come from a dynamic evaluation.
2379
2380 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2381
2382         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2383         whitespace when pretty printing is on.
2384
2385 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2386
2387         * ppc-linux-nat.c: Add include.
2388
2389 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2390
2391         * NEWS: Mention AArch64 Pointer Authentication.
2392
2393 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2394
2395         * arm-linux-nat.c: Add include.
2396
2397 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2398
2399         * source-cache.c (source_cache::get_source_lines): Re-read
2400         fullname after calling open_source_file.
2401
2402 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2403
2404         * NEWS: Mention TLS support for FreeBSD.
2405
2406 2019-03-25  Tom Tromey  <tromey@adacore.com>
2407
2408         * minsyms.c (BUNCH_SIZE): Update comment.
2409         (~minimal_symbol_reader): Remove old comment.
2410         (compact_minimal_symbols): Update comment.
2411         (minimal_symbol_reader::install): Remove old comment.  Update
2412         other comments.
2413
2414 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2415
2416         * s390-linux-nat.c: Add include.
2417
2418 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2419
2420         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2421         Call linux_get_hwcap.
2422         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2423         Likewise.
2424         (aarch64_linux_get_hwcap): Remove function.
2425         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2426         declaration.
2427         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2428         linux_get_hwcap.
2429         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2430         * linux-tdep.c (linux_get_hwcap): Add function.
2431         (linux_get_hwcap2): Likewise.
2432         * linux-tdep.h (linux_get_hwcap): Add declaration.
2433         (linux_get_hwcap2): Likewise.
2434         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2435         (ppc_linux_get_hwcap2): Likewise.
2436         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2437         linux_get_hwcap.
2438         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2439         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2440         (ppc_linux_nat_target::read_description): Likewise.
2441         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2442         * s390-linux-nat.c: Likewise.
2443         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2444
2445 2019-03-24  Tom Tromey  <tom@tromey.com>
2446
2447         * ada-lang.c (standard_lookup): Simplify initialization.
2448         (ada_lookup_symbol_nonlocal): Simplify return.
2449         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2450         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2451         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2452         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2453         initialization.
2454         * solib.c (solib_global_lookup): Simplify.
2455         * symtab.c (null_block_symbol): Remove.
2456         (symbol_cache_lookup): Simplify returns.
2457         (lookup_language_this): Simplify returns.
2458         (lookup_symbol_aux): Simplify return.
2459         (lookup_local_symbol): Simplify returns.
2460         (lookup_global_symbol_from_objfile): Simplify return.
2461         (lookup_symbol_in_objfile_symtabs)
2462         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2463         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2464         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2465         * cp-namespace.c (cp_lookup_bare_symbol)
2466         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2467         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2468         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2469         (cp_lookup_symbol_via_imports): Simplify initialization.
2470         (find_symbol_in_baseclass): Likewise.
2471         * symtab.h (null_block_symbol): Remove.
2472         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2473         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2474         (d_lookup_symbol_module): Likewise.
2475         (find_symbol_in_baseclass): Simplify initialization.
2476
2477 2019-03-24  Tom Tromey  <tom@tromey.com>
2478
2479         * expression.h: Don't include symtab.h.
2480         (struct block): Forward declare.
2481
2482 2019-03-24  Tom Tromey  <tom@tromey.com>
2483
2484         * c-exp.y (typebase): Remove casts.
2485         * gdbtypes.c (lookup_unsigned_typename, )
2486         (lookup_signed_typename): Remove cast.
2487         * eval.c (parse_to_comma_and_eval): Remove cast.
2488         * parse.c (write_dollar_variable): Remove cast.
2489         * block.h (struct block) <superblock>: Now const.
2490         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2491         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2492         (map_block): Make "block" const.
2493         * symfile.h (struct quick_symbol_functions)
2494         <map_matching_symbols>: Constify block argument to "callback".
2495         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2496         const.
2497         (find_pc_sect_compunit_symtab): Make "b" const.
2498         (find_symbol_at_address): Likewise.
2499         (search_symbols): Likewise.
2500         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2501         (dw2_debug_names_lookup_symbol): Likewise.
2502         (dw2_map_matching_symbols): Update.
2503         * p-valprint.c (pascal_val_print): Remove "block".
2504         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2505         (aux_add_nonlocal_symbols): Make "block" const.
2506         (resolve_subexp): Remove cast.
2507         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2508         const.
2509         (iterate_over_file_blocks): Likewise.
2510         * f-exp.y (%union) <bval>: Remove.
2511         * coffread.c (patch_opaque_types): Make "b" const.
2512         * spu-tdep.c (spu_catch_start): Make "block" const.
2513         * c-valprint.c (print_unpacked_pointer): Remove "block".
2514         * symmisc.c (dump_symtab_1): Make "b" const.
2515         (block_depth): Make "block" const.
2516         * d-exp.y (%union) <bval>: Remove.
2517         * cp-support.h (cp_lookup_rtti_type): Update.
2518         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2519         * psymtab.c (psym_lookup_symbol): Make "block" const.
2520         (maintenance_check_psymtabs): Make "b" const.
2521         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2522         (enumerate_locals, enumerate_args): Update.
2523         * python/py-symtab.c (stpy_global_block): Make "block" const.
2524         (stpy_static_block): Likewise.
2525         * inline-frame.c (block_starting_point_at): Make "new_block"
2526         const.
2527         * block.c (find_block_in_blockvector): Make return type const.
2528         (blockvector_for_pc_sect): Make "b" const.
2529         (find_block_in_blockvector): Make "b" const.
2530
2531 2019-03-23  Tom Tromey  <tom@tromey.com>
2532
2533         * varobj.c (varobj_create): Update.
2534         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2535         * printcmd.c (display_command, do_one_display): Don't reset
2536         innermost_block.
2537         * parser-defs.h (enum innermost_block_tracker_type): Move to
2538         expression.h.
2539         (innermost_block): Update comment.
2540         * parse.c (parse_exp_1): Add tracker_types parameter.
2541         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2542         tracker_types parameter.  Reset innermost_block.
2543         (parse_exp_in_context): Remove.
2544         (parse_expression_for_completion): Update.
2545         * objfiles.c (~objfile): Don't reset expression_context_block or
2546         innermost_block.
2547         * expression.h (enum innermost_block_tracker_type): Move from
2548         parser-defs.h.
2549         (parse_exp_1): Add tracker_types parameter.
2550         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2551         reset innermost_block.
2552
2553 2019-03-23  Tom Tromey  <tom@tromey.com>
2554
2555         * objfiles.h: Include bcache.h.
2556
2557 2019-03-23  Tom Tromey  <tom@tromey.com>
2558
2559         * linespec.c (get_current_search_block): Use
2560         scoped_restore_current_language.
2561         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2562
2563 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2564             Jiong Wang  <jiong.wang@arm.com>
2565
2566         * aarch64-linux-tdep.c
2567         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2568         section.
2569         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2570
2571 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2572             Jiong Wang  <jiong.wang@arm.com>
2573
2574         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2575         instructions.
2576         (aarch64_analyze_prologue_test): Add PACIASP test.
2577         (aarch64_prologue_prev_register): Unmask PC value.
2578
2579 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2580             Jiong Wang  <jiong.wang@arm.com>
2581
2582         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2583         (aarch64_dwarf2_prev_register): Unmask PC value.
2584         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2585         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2586         DW_CFA_AARCH64_negate_ra_state.
2587         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2588
2589 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2590             Jiong Wang  <jiong.wang@arm.com>
2591
2592         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2593         registers.
2594         (aarch64_pseudo_register_name): Likewise.
2595         (aarch64_pseudo_register_type): Likewise.
2596         (aarch64_pseudo_register_reggroup_p): Likewise.
2597         (aarch64_gdbarch_init): Add pauth registers.
2598         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2599         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2600         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2601         (struct gdbarch_tdep): Add regnum for ra_state.
2602
2603 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2604             Jiong Wang  <jiong.wang@arm.com>
2605
2606         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2607
2608 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2609             Jiong Wang  <jiong.wang@arm.com>
2610
2611         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2612         function.
2613         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2614         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2615         (aarch64_gdbarch_init): Add puth registers.
2616         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2617         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2618         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2619
2620 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2621             Jiong Wang  <jiong.wang@arm.com>
2622
2623         * aarch64-linux-nat.c
2624         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2625         * aarch64-linux-tdep.c
2626         (aarch64_linux_core_read_description): Likewise.
2627         (aarch64_linux_get_hwcap): New function.
2628         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2629         (aarch64_linux_get_hwcap): New declaration.
2630
2631 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2632             Jiong Wang  <jiong.wang@arm.com>
2633
2634         * aarch64-linux-nat.c
2635         (aarch64_linux_nat_target::read_description): Add pauth param.
2636         * aarch64-linux-tdep.c
2637         (aarch64_linux_core_read_description): Likewise.
2638         * aarch64-tdep.c (struct target_desc): Add in pauth.
2639         (aarch64_read_description): Add pauth param.
2640         (aarch64_gdbarch_init): Likewise.
2641         * aarch64-tdep.h (aarch64_read_description): Likewise.
2642         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2643         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2644         * features/Makefile: Add new files.
2645         * features/aarch64-pauth.c: New file.
2646         * features/aarch64-pauth.xml: New file.
2647
2648 2019-03-20  Tom Tromey  <tromey@adacore.com>
2649
2650         * infrun.c (handle_inferior_event): Rename from
2651         handle_inferior_event_1.  Create a scoped_value_mark.
2652         (handle_inferior_event): Remove.
2653
2654 2019-03-19  Tom Tromey  <tromey@adacore.com>
2655
2656         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2657         * infrun.h (print_stop_event): Add "displays" parameter.
2658         * infrun.c (print_stop_event): Add "displays" parameter.
2659
2660 2019-03-19  Pedro Alves  <palves@redhat.com>
2661
2662         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2663         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2664         to -1.  Fix TABs vs spaces.
2665         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2666         * tui/tui-out.h (tui_ui_out) Add intro comments.
2667         <m_line, m_start_of_line>: In-class initialize, and add describing
2668         comment.
2669
2670 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2671
2672         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2673         variable names.
2674         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2675
2676 2019-03-18  Pedro Alves  <palves@redhat.com>
2677             Eli Zaretskii <eliz@gnu.org>
2678
2679         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2680         m_line and m_start_of_line.
2681
2682 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2683
2684         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2685         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2686         it returns a newline.  This fixes a regression in TU mode, whereby
2687         the next line is output on the same screen line as the user input.
2688
2689 2019-03-18  Tom Tromey  <tromey@adacore.com>
2690
2691         * minsyms.c (minimal_symbol_reader::install): Remove call to
2692         obstack_blank.
2693
2694 2019-03-18  Pedro Alves  <palves@redhat.com>
2695
2696         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2697         New globals.
2698         (apply_style): New, factored out from ...
2699         (apply_ansi_escape): ... this.  Handle reverse video mode.
2700         (tui_set_reverse_mode): New function.
2701         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2702         * tui/tui-winsource.c (tui_show_source_line): Use
2703         tui_set_reverse_mode instead of setting A_STANDOUT.
2704         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2705         New setter methods.
2706
2707 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2708
2709         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2710         Handle tabs.
2711
2712 2019-03-18  Tom Tromey  <tromey@adacore.com>
2713
2714         * ada-lang.c (empty_array): Add "high" parameter.
2715         (ada_evaluate_subexp): Update.
2716
2717 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2718
2719         * unittests/string_view-selftests.c: Define
2720         _initialize_string_view_selftests unconditionally.
2721
2722 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2723
2724         PR gdb/24350
2725         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2726
2727 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2728
2729         PR gdb/24351
2730         * windows-nat.c (display_selector): Fix format specifiers.
2731
2732 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2733
2734         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2735         tui_refill_source_window instead of tui_refresh_win, to update the
2736         current execution line.  This fixes redisplay of the current line
2737         when stepping through the code with "next" or "step".
2738
2739 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2740
2741         * source-cache.c (source_cache::get_source_lines): Call
2742         find_source_lines to initialize s->nlines.  This fixes vertical
2743         scrolling of TUI source window when the DOWN arrow is pressed.
2744
2745 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2746
2747         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2748         linux-thread-db.c (_initialize_thread_db): Likewise.
2749
2750 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2751
2752         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2753         wclrtoeol in tui_show_source_line".  This reverts changes made in
2754         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2755
2756 2019-03-15  Tom Tromey  <tom@tromey.com>
2757
2758         * symtab.h (struct minimal_symbol): Derive from
2759         general_symbol_info.
2760         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2761         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2762         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2763         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2764         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2765         (MSYMBOL_SEARCH_NAME): Update.
2766         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2767         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2768         * minsyms.c (minimal_symbol_reader::record_full): Update.
2769
2770 2019-03-15  Tom Tromey  <tom@tromey.com>
2771
2772         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2773
2774 2019-03-15  Tom Tromey  <tom@tromey.com>
2775
2776         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2777         unique_xmalloc_ptr.
2778         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2779         Update.
2780         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2781         (build_minimal_symbol_hash_tables)
2782         (minimal_symbol_reader::install): Update.
2783
2784 2019-03-15  Tom Tromey  <tom@tromey.com>
2785
2786         * symtab.c (create_demangled_names_hash): Update.
2787         (symbol_set_names): Update.
2788         * objfiles.h (struct objfile_per_bfd_storage)
2789         <demangled_names_hash>: Now an htab_up.
2790         * objfiles.c (objfile_per_bfd_storage): Simplify.
2791
2792 2019-03-15  Tom Tromey  <tom@tromey.com>
2793
2794         * objfiles.h (struct objfile_per_bfd_storage): Declare
2795         destructor.
2796         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2797         New.
2798         (get_objfile_bfd_data): Use new.  Don't initialize
2799         language_of_main.
2800         (free_objfile_per_bfd_storage): Remove.
2801         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2802
2803 2019-03-15  Tom Tromey  <tom@tromey.com>
2804
2805         * symfile.c (reread_symbols): Update.
2806         * objfiles.c (objfile::objfile): Update.
2807         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2808         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2809         comment.
2810         (minimal_symbol_reader::install): Update.
2811         (terminate_minimal_symbol_table): Remove.
2812         * jit.c (jit_object_close_impl): Update.
2813
2814 2019-03-15  Tom Tromey  <tom@tromey.com>
2815
2816         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2817         initializations.
2818
2819 2019-03-15  Tom Tromey  <tom@tromey.com>
2820
2821         * objfiles.h (struct objfile_per_bfd_storage)
2822         <demangled_hash_languages>: Now a bitset.
2823         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2824         (lookup_minimal_symbol): Update.
2825
2826 2019-03-15  Tom Tromey  <tom@tromey.com>
2827
2828         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2829         Don't return the symbol.
2830         * coffread.c (record_minimal_symbol): Use record_full.
2831
2832 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2833
2834         The MS-Windows port of ncurses fails to switch to a color pair if
2835         one or both of the colors are the implicit default colors.  This
2836         change records the default colors when TUI is initialized, and
2837         then specifies them explicitly when a color pair uses the default
2838         colors.  This allows color styling in TUI mode on MS-Windows.
2839
2840         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2841         ncurses_norm_attr.
2842         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2843         colors in ncurses_norm_attr.
2844         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2845         "none", replace it with the default color recorded in
2846         ncurses_norm_attr.
2847
2848 2019-03-14  Tom Tromey  <tromey@adacore.com>
2849
2850         * source-cache.h (class source_cache) <get_source_lines>: Return
2851         std::string.
2852         * source-cache.c (source_cache::extract_lines): Handle case where
2853         first_pos==npos.  Return std::string.
2854         (source_cache::get_source_lines): Update.
2855
2856 2019-03-14  Tom Tromey  <tromey@adacore.com>
2857
2858         * NEWS: Add item for "style sources" commands.
2859         * source-cache.c (source_cache::get_source_lines): Check
2860         source_styling.
2861         * cli/cli-style.c (source_styling): New global.
2862         (_initialize_cli_style): Add "style sources" commands.
2863         (show_style_sources): New function.
2864         * cli/cli-style.h (source_styling): Declare.
2865
2866 2019-03-14  Pedro Alves  <palves@redhat.com>
2867             Tom Tromey  <tromey@adacore.com>
2868
2869         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2870         * tui/tui-winsource.c (tui_refill_source_window): New function,
2871         from...
2872         (tui_horizontal_source_scroll): ... here.  Move some logic.
2873         * cli/cli-style.c (set_style_enabled): Notify new observable.
2874         * tui/tui-hooks.c (tui_redisplay_source): New function.
2875         (tui_attach_detach_observers): Attach or detach
2876         tui_redisplay_source.
2877         * observable.h (source_styling_changed): New observable.
2878         * observable.c: Define source_styling_changed observable.
2879
2880 2019-03-13  Tom Tromey  <tromey@adacore.com>
2881
2882         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2883         (i386_gnu_nat_target::store_registers): Update.
2884         * target-debug.h (target_debug_print_std_string): New macro.
2885         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2886         * windows-tdep.c (display_one_tib): Update.
2887         * tui/tui-stack.c (tui_make_status_line): Update.
2888         * top.c (print_inferior_quit_action): Update.
2889         * thread.c (thr_try_catch_cmd): Update.
2890         (add_thread_with_info): Update.
2891         (thread_target_id_str): Update.
2892         (thr_try_catch_cmd): Update.
2893         (thread_command): Update.
2894         (thread_find_command): Update.
2895         * record-btrace.c (record_btrace_target::info_record)
2896         (record_btrace_resume_thread, record_btrace_target::resume)
2897         (record_btrace_cancel_resume, record_btrace_step_thread)
2898         (record_btrace_target::wait, record_btrace_target::wait)
2899         (record_btrace_target::wait, record_btrace_target::stop): Update.
2900         * progspace.c (print_program_space): Update.
2901         * process-stratum-target.c
2902         (process_stratum_target::thread_address_space): Update.
2903         * linux-fork.c (linux_fork_mourn_inferior)
2904         (detach_checkpoint_command, info_checkpoints_command)
2905         (linux_fork_context): Update.
2906         (linux_fork_detach): Update.
2907         (class scoped_switch_fork_info): Update.
2908         (delete_checkpoint_command): Update.
2909         * infrun.c (follow_fork_inferior): Update.
2910         (follow_fork_inferior): Update.
2911         (proceed_after_vfork_done): Update.
2912         (handle_vfork_child_exec_or_exit): Update.
2913         (follow_exec): Update.
2914         (displaced_step_prepare_throw): Update.
2915         (displaced_step_restore): Update.
2916         (start_step_over): Update.
2917         (resume_1): Update.
2918         (clear_proceed_status_thread): Update.
2919         (proceed): Update.
2920         (print_target_wait_results): Update.
2921         (do_target_wait): Update.
2922         (context_switch): Update.
2923         (stop_all_threads): Update.
2924         (restart_threads): Update.
2925         (finish_step_over): Update.
2926         (handle_signal_stop): Update.
2927         (switch_back_to_stepped_thread): Update.
2928         (keep_going_pass_signal): Update.
2929         (print_exited_reason): Update.
2930         (normal_stop): Update.
2931         * inferior.c (inferior_pid_to_str): Change return type.
2932         (print_selected_inferior): Update.
2933         (add_inferior): Update.
2934         (detach_inferior): Update.
2935         * dummy-frame.c (fprint_dummy_frames): Update.
2936         * dcache.c (dcache_info_1): Update.
2937         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2938         (btrace_fetch, btrace_clear): Update.
2939         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2940         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2941         type.
2942         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2943         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2944         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2945         * gdbarch.c, gdbarch.h: Rebuild.
2946         * gdbarch.sh (core_pid_to_str): Change return type.
2947         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2948         return type.
2949         (windows_nat_target::pid_to_str): Change return type.
2950         (windows_delete_thread): Update.
2951         (windows_nat_target::attach): Update.
2952         (windows_nat_target::files_info): Update.
2953         * target-delegates.c: Rebuild.
2954         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2955         return type.
2956         (sol_thread_target::pid_to_str): Change return type.
2957         * remote.c (class remote_target) <pid_to_str>: Change return
2958         type.
2959         (remote_target::pid_to_str): Change return type.
2960         (extended_remote_target::attach, remote_target::remote_stop_ns)
2961         (remote_target::remote_notif_remove_queued_reply)
2962         (remote_target::push_stop_reply, remote_target::disable_btrace):
2963         Update.
2964         (extended_remote_target::attach): Update.
2965         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2966         type.
2967         (gdbsim_target::pid_to_str): Change return type.
2968         * ravenscar-thread.c (struct ravenscar_thread_target)
2969         <pid_to_str>: Change return type.
2970         (ravenscar_thread_target::pid_to_str): Change return type.
2971         * procfs.c (class procfs_target) <pid_to_str>: Change return
2972         type.
2973         (procfs_target::pid_to_str): Change return type.
2974         (procfs_target::attach): Update.
2975         (procfs_target::detach): Update.
2976         (procfs_target::fetch_registers): Update.
2977         (procfs_target::store_registers): Update.
2978         (procfs_target::wait): Update.
2979         (procfs_target::files_info): Update.
2980         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2981         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2982         return type.
2983         (nto_procfs_target::pid_to_str): Change return type.
2984         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2985         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2986         return type.
2987         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2988         (exit_lwp): Update.
2989         (attach_proc_task_lwp_callback, get_detach_signal)
2990         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2991         (linux_nat_target::resume, wait_lwp, stop_callback)
2992         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2993         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2994         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2995         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2996         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2997         type.
2998         (inf_ptrace_target::attach): Update.
2999         (inf_ptrace_target::files_info): Update.
3000         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3001         type.
3002         (go32_nat_target::pid_to_str): Change return type.
3003         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3004         (gnu_nat_target::wait): Update.
3005         (gnu_nat_target::wait): Update.
3006         (gnu_nat_target::resume): Update.
3007         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3008         (fbsd_nat_target::wait): Update.
3009         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3010         type.
3011         (darwin_nat_target::attach): Update.
3012         * corelow.c (class core_target) <pid_to_str>: Change return type.
3013         (core_target::pid_to_str): Change return type.
3014         * target.c (normal_pid_to_str): Change return type.
3015         (default_pid_to_str): Likewise.
3016         (target_pid_to_str): Change return type.
3017         (target_translate_tls_address): Update.
3018         (target_announce_detach): Update.
3019         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3020         return type.
3021         (bsd_uthread_target::pid_to_str): Change return type.
3022         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3023         type.
3024         (bsd_kvm_target::pid_to_str): Change return type.
3025         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3026         return type.
3027         (aix_thread_target::pid_to_str): Change return type.
3028         * target.h (struct target_ops) <pid_to_str>: Change return type.
3029         (target_pid_to_str, normal_pid_to_str): Likewise.
3030         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3031         type.
3032         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3033         type.
3034         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3035         return type.
3036         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3037         type.
3038         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3039         type.
3040         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3041         return type.
3042
3043 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3044
3045         * NEWS: Mention that the new default MI version is 3.  Mention
3046         changes to the output of commands and events that deal with
3047         multi-location breakpoints.
3048         * breakpoint.c: Include "mi/mi-out.h".
3049         (print_one_breakpoint): Change output syntax if using MI version
3050         >= 3.
3051         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3052         New.
3053         (mi_multi_location_breakpoint_output_fixed): New.
3054         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3055         (mi_cmd_fix_multi_location_breakpoint_output): New.
3056         (mi_multi_location_breakpoint_output_fixed): New.
3057         * mi/mi-cmds.c (mi_cmds): Register command
3058         -fix-multi-location-breakpoint-output.
3059         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3060         interpreter "mi".
3061
3062 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3063
3064         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3065         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3066         instantiate mi_ui_out based on interpreter name.
3067         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3068         * mi/mi-main.c (mi_load_progress): Likewise.
3069
3070 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3071
3072         * NEWS: Combine separate "New targets" sections for 8.3.
3073
3074 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3075
3076         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3077         (ppcfbsd_init_abi): Install gdbarch
3078         "fetch_tls_load_module_address" and "get_thread_local_address"
3079         methods.
3080
3081 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3082
3083         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3084         (riscv_fbsd_init_abi): Install gdbarch
3085         "fetch_tls_load_module_address" and "get_thread_local_address"
3086         methods.
3087
3088 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3089
3090         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3091         (i386fbsd_init_abi): Install gdbarch
3092         "fetch_tls_load_module_address" and "get_thread_local_address"
3093         methods.
3094
3095 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3096
3097         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3098         (amd64fbsd_init_abi): Install gdbarch
3099         "fetch_tls_load_module_address" and "get_thread_local_address"
3100         methods.
3101
3102 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3103
3104         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3105         (struct fbsd_pspace_data): New type.
3106         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3107         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3108         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3109         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3110         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3111
3112 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3113
3114         * gdbtypes.c (lookup_struct_elt): New function.
3115         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3116         * gdbtypes.h (struct struct_elt): New type.
3117         (lookup_struct_elt): New prototype.
3118
3119 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3120
3121         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3122         remove disabled code block.
3123
3124 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3125
3126         * gdbarch.sh (get_thread_local_address): New method.
3127         * gdbarch.h, gdbarch.c: Regenerate.
3128         * target.c (target_translate_tls_address): Use
3129         gdbarch_get_thread_local_address if present instead of
3130         target::get_thread_local_address.
3131
3132 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3133
3134         * target.h (target::get_thread_local_address): Update comment.
3135
3136 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3137
3138         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3139         objfile->separate_debug_objfile_backlink if not NULL.
3140
3141 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3142
3143         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3144         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3145         (amd64bsd_store_inferior_registers): Likewise.
3146         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3147         Enable segment base registers.
3148         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3149         PT_GETFSBASE and PT_GETGSBASE.
3150         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3151         PT_SETGSBASE.
3152         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3153         segment base registers.
3154         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3155
3156 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3157
3158         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3159         Update calls to i386_target_description to add 'segments'
3160         parameter.
3161         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3162         add segment base registers.
3163         * arch/i386.c (i386_create_target_description): Add 'segments'
3164         parameter to enable segment base registers.
3165         * arch/i386.h (i386_create_target_description): Likewise.
3166         * features/i386/32bit-segments.xml: New file.
3167         * features/i386/32bit-segments.c: Generate.
3168         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3169         call to i386_target_description to add 'segments' parameter.
3170         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3171         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3172         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3173         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3174         if feature is present.
3175         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3176         Add 'segments' parameter to call to i386_target_description.
3177         (i386_target_description): Add 'segments' parameter to enable
3178         segment base registers.
3179         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3180         to call to i386_target_description.
3181         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3182         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3183         Define I386_NUM_REGS.
3184         (i386_target_description): Add 'segments' parameter to enable
3185         segment base registers.
3186
3187 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3188
3189         PR/24325
3190         * source-cache.c: #undef open and close, to avoid unresolved
3191         externals during linking.
3192
3193 2019-03-12  Tom Tromey  <tromey@adacore.com>
3194
3195         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3196         const.  Add initializers.
3197         (_initialize_remote): Don't initialize ptid globals.
3198
3199 2019-03-12  Pedro Alves  <palves@redhat.com>
3200
3201         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3202
3203 2019-03-12  Pedro Alves  <palves@redhat.com>
3204
3205         * cp-name-parser.y (main): Remove unused 'len' variable.
3206
3207 2019-03-12  Tom Tromey  <tromey@adacore.com>
3208
3209         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3210         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3211
3212 2019-03-12  Tom Tromey  <tromey@adacore.com>
3213
3214         * linux-nat.c (iterate_over_lwps): Update.
3215         (stop_callback): Remove parameter.
3216         (stop_wait_callback, detach_callback, resume_set_callback)
3217         (select_singlestep_lwp_callback, set_ignore_sigint)
3218         (status_callback, resumed_callback, resume_clear_callback)
3219         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3220         data parameter.
3221         (linux_nat_target::detach, linux_nat_target::resume)
3222         (linux_stop_and_wait_all_lwps, select_event_lwp)
3223         (linux_nat_filter_event, linux_nat_wait_1)
3224         (linux_nat_target::kill, linux_nat_target::stop)
3225         (linux_nat_target::stop): Update.
3226         (linux_nat_resume_callback): Change type.
3227         (resume_stopped_resumed_lwps, count_events_callback)
3228         (select_event_lwp_callback): Likewise.
3229         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3230         * arm-linux-nat.c (struct update_registers_data): Remove.
3231         (update_registers_callback): Change type.
3232         (arm_linux_insert_hw_breakpoint1): Update.
3233         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3234         parameter.
3235         (x86_linux_dr_set_addr): Update.
3236         (x86_linux_dr_set_control): Update.
3237         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3238         (iterate_over_lwps): Use gdb::function_view.
3239         * nat/aarch64-linux-hw-point.c (struct
3240         aarch64_dr_update_callback_param): Remove.
3241         (debug_reg_change_callback): Change type.
3242         (aarch64_notify_debug_reg_change): Update.
3243         * s390-linux-nat.c (s390_refresh_per_info): Update.
3244
3245 2019-03-11  Tom Tromey  <tromey@adacore.com>
3246
3247         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3248         redundant assignment to "this_cu".
3249
3250 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3251
3252         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3253
3254 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3255
3256         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3257         from...
3258         (rank_one_type): ... this.
3259
3260 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3261
3262         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3263         from...
3264         (rank_one_type): ... this.
3265
3266 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3267
3268         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3269         from...
3270         (rank_one_type): ... this.
3271
3272 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3273
3274         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3275         from...
3276         (rank_one_type): ... this.
3277
3278 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3279
3280         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3281         from...
3282         (rank_one_type): ... this.
3283
3284 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3285
3286         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3287         from...
3288         (rank_one_type): ... this.
3289
3290 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3291
3292         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3293         from...
3294         (rank_one_type): ... this.
3295
3296 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3297
3298         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3299         from...
3300         (rank_one_type): ... this.
3301
3302 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3303
3304         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3305         from...
3306         (rank_one_type): ... this.
3307
3308 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3309
3310         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3311         from...
3312         (rank_one_type): ... this.
3313
3314 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3315
3316         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3317         from...
3318         (rank_one_type): ... this.
3319
3320 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3321
3322         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3323         from...
3324         (rank_one_type): ... this.
3325
3326 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3327
3328         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3329         inferior-events' shows the example events.
3330
3331 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3332
3333         Support styling on native MS-Windows console
3334
3335         PR/24315
3336         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3337         on MS-Windows if $TERM is not defined.
3338
3339         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3340
3341         * posix-hdep.c (gdb_console_fputs):
3342         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3343         functions.
3344         * ui-file.h (gdb_console_fputs): Add prototype.
3345
3346         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3347         back to fputs only if the former returns zero.
3348
3349 2019-03-07  Tom Tromey  <tom@tromey.com>
3350
3351         * symmisc.c (print_symbol_bcache_statistics): Update.
3352         (print_objfile_statistics): Update.
3353         * symfile.c (allocate_symtab): Update.
3354         * stabsread.c: Don't include bcache.h.
3355         * psymtab.h (struct psymbol_bcache): Don't declare.
3356         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3357         (psymbol_bcache_init, psymbol_bcache_free)
3358         (psymbol_bcache_get_bcache): Don't declare.
3359         * psymtab.c (struct psymbol_bcache): Remove.
3360         (psymtab_storage::psymtab_storage): Update.
3361         (psymtab_storage::~psymtab_storage): Update.
3362         (psymbol_bcache_init, psymbol_bcache_free)
3363         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3364         (add_psymbol_to_bcache): Update.
3365         (allocate_psymtab): Update.
3366         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3367         macro_cache>: No longer pointers.
3368         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3369         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3370         * macrotab.c (macro_bcache): Update.
3371         * macroexp.c: Don't include bcache.h.
3372         * gdbtypes.c (check_types_worklist): Update.
3373         (types_deeply_equal): Remove TRY/CATCH.  Update.
3374         * elfread.c (elf_symtab_read): Update.
3375         * dwarf2read.c: Don't include bcache.h.
3376         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3377         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3378         (print_bcache_statistics, bcache_memory_used): Don't declare.
3379         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3380         methods.  Rename all data members.
3381         * bcache.c (struct bcache): Move to bcache.h.
3382         (bcache::expand_hash_table): Rename from expand_hash_table.
3383         (bcache): Remove.
3384         (bcache::insert): Rename from bcache_full.
3385         (bcache::compare): Rename from bcache_compare.
3386         (bcache_xmalloc): Remove.
3387         (bcache::~bcache): Rename from bcache_xfree.
3388         (bcache::print_statistics): Rename from print_bcache_statistics.
3389         (bcache::memory_used): Rename from bcache_memory_used.
3390
3391 2019-03-07  Pedro Alves  <palves@redhat.com>
3392
3393         * infrun.c (normal_stop): Also check for
3394         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3395
3396 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3397
3398         * f-lang.c (value_from_host_double): Moved to...
3399         * value.c (value_from_host_double): ...here.
3400         * value.h (value_from_host_double): Declare.
3401         * guile/scm-math.c (vlscm_convert_typed_number): Use
3402         value_from_host_double.
3403         (vlscm_convert_number): Likewise.
3404         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3405         * python/py-value.c (convert_value_from_python): Likewise.
3406
3407 2019-03-06  Tom Tromey  <tom@tromey.com>
3408
3409         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3410
3411 2019-03-06  Tom Tromey  <tom@tromey.com>
3412
3413         * utils.h (free_current_contents): Don't declare.
3414         * utils.c (free_current_contents): Remove.
3415
3416 2019-03-06  Tom Tromey  <tom@tromey.com>
3417
3418         * top.c (quit_force): Update.
3419         * main.c (captured_command_loop): Update.
3420         * common/new-op.c (operator new): Update.
3421         * common/common-exceptions.c (struct catcher)
3422         <save_cleanup_chain>: Remove member.
3423         (exceptions_state_mc_init): Update.
3424         (exception_try_scope_entry): Return nullptr.
3425         (exception_try_scope_exit, exception_rethrow)
3426         (throw_exception_sjlj, throw_exception_cxx): Update.
3427         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3428         (all_cleanups, do_cleanups, discard_cleanups)
3429         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3430         (restore_cleanups, restore_final_cleanups): Don't declare.
3431         (do_final_cleanups): Remove parameter.
3432         * common/cleanups.c (cleanup_chain, make_cleanup)
3433         (make_cleanup_dtor, all_cleanups, do_cleanups)
3434         (discard_my_cleanups, discard_cleanups)
3435         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3436         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3437         (null_cleanup): Remove.
3438         (do_final_cleanups): Remove parameter.
3439
3440 2019-03-06  Tom Tromey  <tom@tromey.com>
3441
3442         * remote.c (remote_target::remote_parse_stop_reply): Use
3443         unique_xmalloc_ptr.
3444
3445 2019-03-06  Tom Tromey  <tom@tromey.com>
3446
3447         * stabsread.c (struct stabs_field_info): Rename from field_info.
3448         <list, fnlist>: Add initializers.
3449         <obstack>: New member.
3450         (read_member_functions, read_struct_fields, read_baseclasses):
3451         Allocate on obstack.  Don't use cleanups.
3452         (read_one_struct_field, read_member_functions, read_struct_fields)
3453         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3454         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3455         (read_struct_type): Update.
3456
3457 2019-03-06  Tom Tromey  <tom@tromey.com>
3458
3459         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3460         * common/filestuff.h (make_cleanup_close): Don't declare.
3461         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3462         Remove.
3463
3464 2019-03-06  Tom Tromey  <tom@tromey.com>
3465
3466         * solib-aix.c: Use make_scope_exit.
3467
3468 2019-03-06  Tom Tromey  <tom@tromey.com>
3469
3470         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3471         Use make_scope_exit.
3472
3473 2019-03-06  Tom Tromey  <tom@tromey.com>
3474
3475         * solib-svr4.c (disable_probes_interface): Remove parameter.
3476         (svr4_handle_solib_event): Use make_scope_exit.
3477
3478 2019-03-06  Tom Tromey  <tom@tromey.com>
3479
3480         * remote.c (struct stop_reply_deleter): Remove.
3481         (stop_reply_up): Update.
3482         (struct stop_reply): Derive from notif_event.  Don't typedef.
3483         <regcache>: Now a std::vector.
3484         (stop_reply_xfree): Remove.
3485         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3486         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3487         (remote_target::discard_pending_stop_replies): Use delete.
3488         (remote_target::remote_parse_stop_reply): Update.
3489         (remote_target::process_stop_reply): Update.
3490         * remote-notif.h (struct notif_event): Add virtual destructor.
3491         Remove "dtr" member.
3492         (struct notif_client) <alloc_event>: Return a unique_ptr.
3493         (notif_event_xfree): Don't declare.
3494         (notif_event_up): New typedef.
3495         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3496         (notif_event_xfree, do_notif_event_xfree): Remove.
3497         (remote_notif_state_xfree): Update.
3498
3499 2019-03-06  Tom Tromey  <tom@tromey.com>
3500
3501         * infrun.c (displaced_step_clear_cleanup): Now a
3502         forward_scope_exit type.
3503         (displaced_step_prepare_throw): Update.
3504         (displaced_step_fixup): Update.
3505
3506 2019-03-06  Tom Tromey  <tom@tromey.com>
3507
3508         * inferior.h (class inferior): Update comment.
3509         * gdbthread.h (class thread_info): Update comment.
3510
3511 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3512             Tom Tromey  <tom@tromey.com>
3513
3514         * stabsread.h (struct stab_section_list): Remove.
3515         (coffstab_build_psymtabs): Update.
3516         * dbxread.c (symbuf_sections): Now a std::vector.
3517         (sect_idx): New global.
3518         (fill_symbuf): Update.
3519         (coffstab_build_psymtabs): Change type of stabsects parameter.
3520         Update.
3521         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3522         std::vector.
3523         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3524         (coff_locate_sections): Update.
3525         (coff_symfile_read): Remove cleanups.  Update.
3526         (init_stringtab): Add storage parameter.
3527         (free_stringtab, free_stringtab_cleanup): Remove.
3528         (init_lineno): Add storage parameter.
3529         (free_linetab, free_linetab_cleanup): Remove.
3530
3531 2019-03-06  Pedro Alves  <palves@redhat.com>
3532
3533         * linux-fork.c (fork_info::clobber_regs): Delete.
3534         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3535         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3536         comment.  Adjust.
3537         (scoped_switch_fork_info::scoped_switch_fork_info)
3538         (checkpoint_command, linux_fork_context): Adjust
3539         fork_save_infrun_state calls.
3540
3541 2019-03-06  Pedro Alves  <palves@redhat.com>
3542
3543         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3544         (inf_has_multiple_threads): Return 'bool' and rewrite using
3545         inferior_info::threads().
3546
3547 2019-03-06  Pedro Alves  <palves@redhat.com>
3548
3549         * linux-fork.c: Include <list>.
3550         (fork_list): Now a std::list instance.
3551         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3552         (forks_exist_p, find_last_fork): Adjust.
3553         (new_fork): Delete.
3554         (one_fork_p): New.
3555         (add_fork): Adjust.
3556         (free_fork): Delete, folded into fork_info::~fork_info().
3557         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3558         Adjust.
3559         (init_fork_list): Delete.
3560         (linux_fork_killall, linux_fork_mourn_inferior)
3561         (linux_fork_detach, info_checkpoints_command): Adjust.
3562         (_initialize_linux_fork): No longer call init_fork_list.
3563
3564 2019-03-06  Pedro Alves  <palves@redhat.com>
3565
3566         * linux-fork.c (new_fork): New, split out of ...
3567         (add_fork): ... this.  Return void.  Move "first fork" special
3568         case from here, to ...
3569         (checkpoint_command): ... here.
3570         * linux-linux.h (add_fork): Return void.
3571
3572 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3573
3574         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3575
3576 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3577             Chris January  <chris.january@arm.com>
3578             David Lecomber  <david.lecomber@arm.com>
3579
3580         * f-exp.y: New token, UNOP_INTRINSIC.
3581         (exp): New pattern using UNOP_INTRINSIC token.
3582         (f77_keywords): Add 'abs' keyword.
3583         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3584         (value_from_host_double): New function.
3585         (evaluate_subexp_f): Support UNOP_ABS.
3586
3587 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3588
3589         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3590         types.
3591
3592 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3593
3594         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3595         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3596         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3597
3598 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3599
3600         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3601
3602 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3603             Chris January  <chris.january@arm.com>
3604
3605         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3606         * f-exp.y: Define 'KIND' token.
3607         (exp): New pattern for KIND expressions.
3608         (ptype): Handle types with a kind extension.
3609         (direct_abs_decl): Extend to spot kind extensions.
3610         (f77_keywords): Add 'kind' to the list.
3611         (push_kind_type): New function.
3612         (convert_to_kind_type): New function.
3613         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3614         * parse.c (operator_length_standard): Likewise.
3615         * parser-defs.h (enum type_pieces): Add tp_kind.
3616         * std-operator.def: Add UNOP_KIND.
3617
3618 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3619
3620         * f-exp.y (f_parse): Set yydebug.
3621
3622 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3623
3624         * f-lang.c (evaluate_subexp_f): New function.
3625         (exp_descriptor_f): New global.
3626         (f_language_defn): Use exp_descriptor_f instead of
3627         exp_descriptor_standard.
3628
3629 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3630
3631         * f-exp.y (struct token): Add comments.
3632         (dot_ops): Remove uppercase versions and the end marker.
3633         (f77_keywords): Likewise.
3634         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3635         entries in the dot_ops array are case insensitive, and use
3636         strncasecmp to compare strings.  Also some whitespace cleanup in
3637         this area.  Similar for the f77_keywords array, except entries in
3638         this list might be case sensitive.
3639
3640 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3641
3642         * f-exp.y (struct f77_boolean_val): Add comments.
3643         (boolean_values): Remove uppercase versions, and end marker.
3644         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3645         and use strncasecmp to achieve case insensitivity.  Additionally,
3646         perform whitespace cleanup around this code.
3647
3648 2019-03-06  Tom Tromey  <tromey@adacore.com>
3649
3650         * remote-sim.c (gdbsim_target_open): Use result of
3651         gdb_argv::release.
3652
3653 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3654         Dirk Schubert  <dirk.schubert@arm.com>
3655         Chris January  <chris.january@arm.com>
3656
3657         * eval.c (evaluate_subexp_standard): Call Fortran argument
3658         wrapping logic.
3659         * f-lang.c (struct value): A value which can be passed into a
3660         Fortran function call.
3661         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3662         where appropriate.
3663         (struct type): Value ready for a Fortran function call.
3664         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3665         is needed.
3666         * f-lang.h (fortran_argument_convert): Declaration.
3667         (fortran_preserve_arg_pointer): Declaration.
3668         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3669
3670 2019-03-05  Tom Tromey  <tromey@adacore.com>
3671
3672         * python/py-prettyprint.c (print_string_repr): Remove #if.
3673         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3674
3675 2019-03-05  Tom Tromey  <tromey@adacore.com>
3676
3677         * target.c (the_dummy_target): Move later.  Change type to
3678         "dummy_target".
3679         (initialize_targets): Don't initialize the_dummy_target.
3680
3681 2019-03-05  Tom Tromey  <tromey@adacore.com>
3682
3683         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3684         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3685
3686 2019-03-05  Tom Tromey  <tromey@adacore.com>
3687
3688         * windows-nat.c (windows_nat_target::attach)
3689         (windows_nat_target::detach): Don't call gdb_flush.
3690         * valprint.c (generic_val_print, val_print, val_print_string):
3691         Don't call gdb_flush.
3692         * utils.c (defaulted_query): Don't call gdb_flush.
3693         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3694         * target.c (target_announce_detach): Don't call gdb_flush.
3695         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3696         * remote.c (extended_remote_target::attach): Don't call
3697         gdb_flush.
3698         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3699         * printcmd.c (do_examine): Don't call gdb_flush.
3700         (info_display_command): Don't call gdb_flush.
3701         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3702         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3703         * memattr.c (info_mem_command): Don't call gdb_flush.
3704         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3705         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3706         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3707         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3708         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3709         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3710         (gnu_nat_target::detach): Don't call gdb_flush.
3711         * f-valprint.c (f_val_print): Don't call gdb_flush.
3712         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3713         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3714         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3715         gdb_flush.
3716         * c-valprint.c (c_val_print): Don't call gdb_flush.
3717         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3718
3719 2019-03-05  Tom Tromey  <tromey@adacore.com>
3720
3721         * varobj.c (update_dynamic_varobj_children): Update.
3722         (install_default_visualizer): Use reset, not release.
3723         * value.c (set_internalvar): Update.
3724         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3725         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3726         ATTRIBUTE_UNUSED_RESULT.
3727
3728 2019-03-05  Tom Tromey  <tromey@adacore.com>
3729
3730         * remote.c (class scoped_remote_fd) <release>: Add
3731         ATTRIBUTE_UNUSED_RESULT.
3732
3733 2019-03-05  Tom Tromey  <tromey@adacore.com>
3734
3735         * macroexp.c (struct macro_buffer) <release>: Add
3736         ATTRIBUTE_UNUSED_RESULT.
3737
3738 2019-03-05  Tom Tromey  <tromey@adacore.com>
3739
3740         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3741         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3742         ATTRIBUTE_UNUSED_RESULT.
3743
3744 2019-03-05  Tom Tromey  <tromey@adacore.com>
3745
3746         * common/scoped_fd.h (class scoped_fd) <release>: Add
3747         ATTRIBUTE_UNUSED_RESULT.
3748
3749 2019-03-05  Tom Tromey  <tromey@adacore.com>
3750
3751         * parser-defs.h (struct parser_state) <release>: Add
3752         ATTRIBUTE_UNUSED_RESULT.
3753
3754 2019-03-05  Tom Tromey  <tromey@adacore.com>
3755
3756         * utils.h (class gdb_argv) <release>: Add
3757         ATTRIBUTE_UNUSED_RESULT.
3758         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3759
3760 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3761
3762         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3763         for-loop range, to avoid compiler warnings.
3764
3765         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3766         avoid compiler warnings about unused variables.
3767
3768         * NEWS: Mention end of support for native debugging on MS-Windows
3769         before XP.
3770
3771         PR gdb/24292
3772         * common/netstuff.c:
3773         * gdbserver/gdbreplay.c
3774         * gdbserver/remote-utils.c:
3775         * ser-tcp.c:
3776         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3777         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3778         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3779         'getaddrinfo' and 'freeaddrinfo' were not available before
3780         Windows XP, and mingw.org's MinGW headers by default define
3781         _WIN32_WINNT to 0x500.
3782
3783 2019-03-01  Gary Benson <gbenson@redhat.com>
3784
3785         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3786
3787 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3788             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3789
3790         PR gdb/8527
3791         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3792         set_sigint_trap, clear_sigint_trap.
3793
3794 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3795
3796         * target.c (target_detach): Clear the regcache and the
3797         frame cache.
3798
3799 2019-02-27  Pedro Alves  <palves@redhat.com>
3800
3801         * utils.c (set_screen_size): When we cap the height/width sizes,
3802         tweak the corresponding command variable to show "unlimited":
3803
3804 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3805             Pedro Alves  <palves@redhat.com>
3806
3807         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3808         before calling rl_set_screen_size.
3809
3810 2019-02-27  Tom Tromey  <tromey@adacore.com>
3811
3812         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3813         define.
3814         * python/py-value.c: Remove Python 2.4 workaround.
3815         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3816         workaround.
3817         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3818         Python 2.4 workaround.
3819         * python/python-internal.h: Remove Python 2.4 comment.
3820         (Py_ssize_t): Don't define.
3821         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3822         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3823         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3824         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3825         * python/python.c (do_start_initialization): Remove Python 2.4
3826         workaround.
3827         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3828         (print_children): Remove Python 2.4 workaround.
3829         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3830         workaround.
3831         (CHARBUFFERPROC_NAME): Remove.
3832         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3833         Python 2.4 workaround.
3834
3835 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3836
3837         * NEWS: Note minimum Python version.
3838
3839 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3840
3841         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3842         code from these functions.  Remove corresponding ifdefs.  Use
3843         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3844         Remove gotos and target of gotos.
3845         (infpy_search_memory): Likewise.
3846
3847 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3848
3849         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3850         (hppa_gdbarch_init): Don't register deleted functions with
3851         gdbarch.
3852
3853 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3854
3855         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3856         (h8300_unwind_sp): Delete.
3857         (h8300_dummy_id): Delete.
3858         (h8300_gdbarch_init): Don't register deleted functions with
3859         gdbarch.
3860
3861 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3862
3863         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3864         (ft32_unwind_pc): Delete.
3865         (ft32_unwind_sp): Delete.
3866         (ft32_gdbarch_init): Don't register deleted functions with
3867         gdbarch.
3868
3869 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3870
3871         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3872         (frv_unwind_pc): Delete.
3873         (frv_unwind_sp): Delete.
3874         (frv_gdbarch_init): Don't register deleted functions with
3875         gdbarch.
3876
3877 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3878
3879         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3880         (riscv_unwind_pc): Delete.
3881         (riscv_unwind_sp): Delete.
3882         (riscv_gdbarch_init): Don't register deleted functions with
3883         gdbarch.
3884
3885 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3886
3887         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3888         (csky_unwind_pc): Delete.
3889         (csky_unwind_sp): Delete.
3890         (csky_gdbarch_init): Don't register deleted functions with
3891         gdbarch.
3892
3893 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3894
3895         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3896         (cris_unwind_pc): Delete.
3897         (cris_unwind_sp): Delete.
3898         (cris_gdbarch_init): Don't register deleted functions with
3899         gdbarch.
3900
3901 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3902
3903         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3904         (bfin_unwind_pc): Delete.
3905         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3906
3907 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3908
3909         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3910         (arm_unwind_pc): Delete.
3911         (arm_unwind_sp): Delete.
3912         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3913
3914 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3915
3916         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3917         (arc_unwind_pc): Delete.
3918         (arc_unwind_sp): Delete.
3919         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3920
3921 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3922
3923         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3924         (alpha_unwind_pc): Delete.
3925         (alpha_gdbarch_init): Don't register deleted functions with
3926         gdbarch.
3927
3928 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3929
3930         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3931         (aarch64_unwind_pc): Delete.
3932         (aarch64_unwind_sp): Delete.
3933         (aarch64_gdbarch_init): Don't register deleted functions with
3934         gdbarch.
3935
3936 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3937
3938         * gdbtypes.c (type_align): Don't consider static members when
3939         computing structure alignment.
3940
3941 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3942
3943         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3944         return 0 for other types.
3945         * arch-utils.c (default_type_align): Always return 0.
3946         * gdbarch.h: Regenerate.
3947         * gdbarch.sh (type_align): Extend comment.
3948         * gdbtypes.c (type_align): Add additional comments, always call
3949         gdbarch_type_align before applying the default rules.
3950         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3951         generic code will then apply a suitable default.
3952         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3953         types, return 0 for other types.
3954
3955 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3956
3957         * NEWS: Create a new section for the next release branch.
3958         Rename the section of the current branch, now that it has
3959         been cut.
3960
3961 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3962
3963         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3964         * version.in: Bump version to 8.3.50.DATE-git.
3965
3966 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3967
3968         * aix-thread.c (ptid_cmp): Remove unused variable.
3969         (get_signaled_thread): Likewise.
3970         (store_regs_user_thread): Likewise.
3971         (store_regs_kernel_thread): Likewise.
3972         (fetch_regs_kernel_thread): Remove shadowed variable.
3973
3974 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3975
3976         * features/riscv/32bit-cpu.xml: Add register numbers.
3977         * features/riscv/32bit-fpu.c: Regenerate.
3978         * features/riscv/32bit-fpu.xml: Add register numbers.
3979         * features/riscv/64bit-cpu.xml: Add register numbers.
3980         * features/riscv/64bit-fpu.c: Regenerate.
3981         * features/riscv/64bit-fpu.xml: Add register numbers.
3982
3983 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3984
3985         * NEWS: Mention two argument form of gdb.Value constructor.
3986         * python/py-value.c (convert_buffer_and_type_to_value): New
3987         function.
3988         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3989         Add support for handling an optional second argument.  Call
3990         convert_buffer_and_type_to_value as appropriate.
3991         * python/python-internal.h (Py_buffer_deleter): New struct.
3992         (Py_buffer_up): New typedef.
3993
3994 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3995
3996         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3997         instead of releasing ownership.
3998
3999 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4000
4001         * dwarf2read.c (open_and_init_dwp_file): Call
4002         elf_numsections instead of bfd_count_sections to initialize
4003         dwp_file->num_sections.
4004
4005 2019-02-25  Tom Tromey  <tromey@adacore.com>
4006
4007         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4008
4009 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4010
4011         * gcore.in: Add '--readnever' option when invoking GDB.
4012
4013 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4014
4015         * MAINTAINERS: Update my email address.
4016
4017 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4018
4019         * build-id.c (build_id_to_debug_bfd_1): New function.
4020         (build_id_to_debug_bfd): Look for separate debug file in
4021         sysroot.
4022
4023 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4024
4025         * gdbarch.sh: Update the copyright year range that is placed into
4026         generated files.
4027
4028 2019-02-22  Keith Seitz  <keiths@redhat.com>
4029
4030         PR symtab/23853
4031         * linespec.c (create_sals_line_offset): Search for the default
4032         symtab's filename instead of its fullname.
4033
4034 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4035
4036         * NEWS: Update style defaults.
4037
4038 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4039
4040         * main.c (captured_main_1): Disable styling in batch mode.
4041
4042 2019-02-20  Tom Tromey  <tom@tromey.com>
4043
4044         * symtab.c (symtab_symbol_info): Fix typos.
4045
4046 2019-02-20  Tom Tromey  <tromey@adacore.com>
4047
4048         * findcmd.c (_initialize_mem_search): Use upper case for
4049         metasyntactic variables.
4050
4051 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4052
4053         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4054         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4055
4056 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4057
4058         * top.h (source_file_name): Change to std::string.
4059         * top.c (source_file_name): Likewise.
4060         (command_line_input): Adjust.
4061         * cli/cli-script.c (script_from_file): Adjust.
4062
4063 2019-02-19  Tom Tromey  <tromey@adacore.com>
4064
4065         * ravenscar-thread.c
4066         (ravenscar_thread_target::update_thread_list): Don't call
4067         ada_build_task_list.
4068         * ada-lang.h (ada_build_task_list): Don't declare.
4069         * ada-tasks.c (struct ada_tasks_inferior_data)
4070         <task_list_valid_p>: Now bool.
4071         (read_known_tasks, ada_task_list_changed)
4072         (ada_tasks_invalidate_inferior_data): Update.
4073         (read_known_tasks_array): Return bool.
4074         (read_known_tasks_list): Likewise.
4075         (read_known_tasks): Return void.
4076         (ada_build_task_list): Now static.
4077
4078 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4079
4080         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4081         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4082
4083 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4084
4085         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4086         variant for ada_tasks_pspace_data_handle and
4087         ada_tasks_inferior_data_handle.
4088         (ada_tasks_pspace_data_cleanup): New function.
4089         (ada_tasks_inferior_data_cleanup): New function.
4090
4091 2019-02-17  Tom Tromey  <tom@tromey.com>
4092
4093         * macrotab.h (macro_source_fullname): Return a std::string.
4094         * macrotab.c (macro_include, check_for_redefinition)
4095         (macro_undef, macro_lookup_definition, foreach_macro)
4096         (foreach_macro_in_scope): Update.
4097         (macro_source_fullname): Return a std::string.
4098         * macrocmd.c (show_pp_source_pos): Update.
4099
4100 2019-02-17  Tom Tromey  <tom@tromey.com>
4101
4102         * macrocmd.c (show_pp_source_pos): Style the file names.
4103
4104 2019-02-17  Tom Tromey  <tom@tromey.com>
4105
4106         PR tui/24197:
4107         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4108
4109 2019-02-17  Tom Tromey  <tom@tromey.com>
4110
4111         * ada-lang.c (user_select_syms): Use filtered printing.
4112         * utils.c (wrap_style): New global.
4113         (desired_style): Remove.
4114         (emit_style_escape): Add stream parameter.
4115         (set_output_style, reset_terminal_style, prompt_for_continue):
4116         Update.
4117         (flush_wrap_buffer): Only flush gdb_stdout.
4118         (wrap_here): Set wrap_style.
4119         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4120         treat escape sequences as a character.  Change when wrap buffer is
4121         flushed.
4122         (fputs_styled): Do not set the output style when the default is
4123         requested.
4124         * ui-style.h (struct ui_file_style) <is_default>: New method.
4125         * source.c (print_source_lines_base): Emit escape sequences in one
4126         piece.
4127
4128 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4129
4130         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4131         integers and enumeration types.
4132
4133 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4134
4135         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4136         instead of lookup_symbol_in_language
4137         (do_exact_match): New function.
4138         (ada_get_symbol_name_matcher): Return do_exact_match when
4139         doing a verbatim match.
4140
4141 2019-02-15  Tom Tromey  <tromey@adacore.com>
4142
4143         * ravenscar-thread.c (ravenscar_thread_target::resume)
4144         (ravenscar_thread_target::wait): Special case wildcard requests.
4145
4146 2019-02-15  Tom Tromey  <tromey@adacore.com>
4147
4148         * ravenscar-thread.c (base_ptid): Remove.
4149         (struct ravenscar_thread_target) <close>: New method.
4150         <m_base_ptid>: New member.
4151         <update_inferior_ptid, active_task, task_is_currently_active,
4152         runtime_initialized>: Declare methods.
4153         <ravenscar_thread_target>: Add constructor.
4154         (ravenscar_thread_target::task_is_currently_active)
4155         (ravenscar_thread_target::update_inferior_ptid)
4156         (ravenscar_runtime_initialized): Rename.  Now methods.
4157         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4158         (ravenscar_thread_target::update_thread_list): Update.
4159         (ravenscar_thread_target::active_task): Now method.
4160         (ravenscar_thread_target::store_registers)
4161         (ravenscar_thread_target::prepare_to_store)
4162         (ravenscar_thread_target::prepare_to_store)
4163         (ravenscar_thread_target::mourn_inferior): Update.
4164         (ravenscar_inferior_created): Use "new" to create target.
4165         (ravenscar_thread_target::get_ada_task_ptid): Update.
4166         (_initialize_ravenscar): Don't initialize base_ptid.
4167         (ravenscar_ops): Remove global.
4168
4169 2019-02-15  Tom Tromey  <tromey@adacore.com>
4170
4171         * target.h (push_target): Declare new overload.
4172         * target.c (push_target): New overload, taking an rvalue reference.
4173         * remote.c (remote_target::open_1): Use push_target overload.
4174         * corelow.c (core_target_open): Use push_target overload.
4175
4176 2019-02-15  Tom Tromey  <tromey@adacore.com>
4177
4178         * ravenscar-thread.c (is_ravenscar_task)
4179         (ravenscar_task_is_currently_active): Return bool.
4180         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4181         (_initialize_ravenscar): Remove "(void)".
4182         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4183         Return bool.
4184
4185 2019-02-15  Tom Tromey  <tromey@adacore.com>
4186
4187         * ravenscar-thread.c (ravenscar_runtime_initializer)
4188         (has_ravenscar_runtime, get_running_thread_id)
4189         (ravenscar_thread_target::resume): Fix indentation.
4190
4191 2019-02-15  Tom Tromey  <tromey@adacore.com>
4192
4193         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4194         from ravenscar_arch_ops.
4195         (sparc_ravenscar_ops::fetch_registers)
4196         (sparc_ravenscar_ops::store_registers): Now methods.
4197         (sparc_ravenscar_prepare_to_store): Remove.
4198         (sparc_ravenscar_ops): Redefine.
4199         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4200         methods and destructor.  Remove members.
4201         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4202         (ravenscar_thread_target::store_registers)
4203         (ravenscar_thread_target::prepare_to_store): Update.
4204         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4205         Remove.
4206         (struct ppc_ravenscar_powerpc_ops): Derive from
4207         ravenscar_arch_ops.
4208         (ppc_ravenscar_powerpc_ops::fetch_registers)
4209         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4210         (ppc_ravenscar_powerpc_ops): Redefine.
4211         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4212         (ppc_ravenscar_e500_ops::fetch_registers)
4213         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4214         (ppc_ravenscar_e500_ops): Redefine.
4215         * aarch64-ravenscar-thread.c
4216         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4217         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4218         (aarch64_ravenscar_fetch_registers)
4219         (aarch64_ravenscar_store_registers): Now methods.
4220         (aarch64_ravenscar_ops): Redefine.
4221
4222 2019-02-15  Tom Tromey  <tromey@adacore.com>
4223
4224         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4225         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4226         (ravenscar_thread_target::stopped_by_watchpoint)
4227         (ravenscar_thread_target::stopped_data_address)
4228         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4229
4230 2019-02-15  Tom Tromey  <tromey@adacore.com>
4231
4232         * ravenscar-thread.c: Fix some typos.
4233
4234 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4235             Tom Tromey  <tromey@adacore.com>
4236
4237         * ada-lang.c (ada_exception_sal): Change addr_string to a
4238         std::string.
4239         (create_ada_exception_catchpoint): Update.
4240
4241 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4242             Tom Tromey  <tromey@adacore.com>
4243
4244         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4245         (bp_location_ops): Remove.
4246         (base_breakpoint_allocate_location): Update.
4247         (free_bp_location): Update.
4248         * ada-lang.c (class ada_catchpoint_location)
4249         <ada_catchpoint_location>: Remove ops parameter.
4250         (ada_catchpoint_location_dtor): Remove.
4251         (ada_catchpoint_location_ops): Remove.
4252         (allocate_location_exception): Update.
4253         * breakpoint.h (struct bp_location_ops): Remove.
4254         (class bp_location) <bp_location>: Remove bp_location_ops
4255         parameter.
4256         <~bp_location>: Add destructor.
4257         <ops>: Remove.
4258
4259 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4260             Pedro Alves  <palves@redhat.com>
4261
4262         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4263         'PATH_MAX'.
4264
4265 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4266             Samuel Thibault  <samuel.thibault@gnu.org>
4267             Thomas Schwinge  <thomas@codesourcery.com>
4268
4269         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4270         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4271
4272 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4273
4274         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4275         (check_empty): Use "const char *".
4276
4277         * gnu-nat.c (gnu_nat_target::detach): Instead of
4278         'detach_inferior (pid)' call
4279         'detach_inferior (find_inferior_pid (pid))'.
4280
4281         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4282         'nat/fork-inferior.o'.
4283         * gnu-nat.c: #include "nat/fork-inferior.h".
4284
4285         * gnu-nat.c (gnu_nat_target::detach): Instead of
4286         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4287         * gnu-nat.h: #include "inf-child.h".
4288         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4289         'i386_gnu_nat_target::fetch_registers'.
4290         (gnu_store_registers): Rename/move to
4291         'i386_gnu_nat_target::store_registers'.
4292
4293         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4294         * gnu-nat.h (mach_thread_info): New function.
4295         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4296
4297         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4298
4299 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4300
4301         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4302
4303 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4304
4305         * windows-nat.c (windows_add_thread): Add new parameter
4306         "main_thread_p" with default value set to false.  Update
4307         function documentation as well as all callers.
4308         (windows_delete_thread): Likewise.
4309         (fake_create_process): Update call to windows_add_thread.
4310         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4311         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4312         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4313         call to windows_delete_thread.
4314
4315 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4316
4317         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4318
4319 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4320
4321         * symfile.c (find_separate_debug_file): Use canonical path of
4322         sysroot with child_path instead of gdb_sysroot if it is valid.
4323
4324 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4325
4326         * symfile.c (find_separate_debug_file): Use child_path to
4327         determine if an object file is under a sysroot.
4328
4329 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4330
4331         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4332         unittests/child-path-selftests.c.
4333         * common/pathstuff.c (child_path): New function.
4334         * common/pathstuff.h (child_path): New prototype.
4335         * unittests/child-path-selftests.c: New file.
4336
4337 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4338
4339         * symfile.c (find_separate_debug_file): Look for separate debug
4340         files in debug directories under the sysroot.
4341
4342 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4343
4344         * symtab.h (struct minimal_symbol data_p): New const method.
4345         (struct minimal_symbol text_p): Likewise.
4346         * symtab.c (output_source_filename): Use file name style
4347         to print file name.
4348         (print_symbol_info): Likewise.
4349         (print_msymbol_info): Use address style to print addresses.
4350         Use function name style to print executable text symbols.
4351         (expand_symtab_containing_pc): Use data_p.
4352         (find_pc_sect_compunit_symtab): Likewise.
4353
4354 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4355
4356         * breakpoint.c (describe_other_breakpoints): Use address style
4357         to print addresses.
4358         (say_where): Likewise.
4359
4360 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4361
4362         * ada-typeprint.c (print_func_type): Print function name
4363         style to print function name.
4364         * c-typeprint.c (c_print_type_1): Likewise.
4365
4366 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4367
4368         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4369         for execve.
4370
4371 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4372
4373         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4374         type_stack.
4375
4376 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4377
4378         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4379         TYPE_CODE_REF types.
4380
4381 2019-02-08  Jim Wilson  <jimw@sifive.com>
4382
4383         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4384         (riscv_linux_fregset): New.
4385         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4386
4387 2019-02-07  Tom Tromey  <tom@tromey.com>
4388
4389         * thread.c (thread_cancel_execution_command): Update.
4390         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4391         methods.
4392         (struct thread_fsm_ops): Remove.
4393         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4394         (thread_fsm_should_stop, thread_fsm_return_value)
4395         (thread_fsm_set_finished, thread_fsm_finished_p)
4396         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4397         Don't declare.
4398         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4399         * infrun.c (clear_proceed_status_thread)
4400         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4401         (print_stop_event): Update.
4402         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4403         Add constructor.
4404         (step_command_fsm_ops): Remove.
4405         (new_step_command_fsm): Remove.
4406         (step_1): Update.
4407         (step_command_fsm::should_stop): Rename from
4408         step_command_fsm_should_stop.
4409         (step_command_fsm::clean_up): Rename from
4410         step_command_fsm_clean_up.
4411         (step_command_fsm::do_async_reply_reason): Rename from
4412         step_command_fsm_async_reply_reason.
4413         (struct until_next_fsm): Inherit from thread_fsm.  Add
4414         constructor.
4415         (until_next_fsm_ops): Remove.
4416         (new_until_next_fsm): Remove.
4417         (until_next_fsm::should_stop): Rename from
4418         until_next_fsm_should_stop.
4419         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4420         (until_next_fsm::do_async_reply_reason): Rename from
4421         until_next_fsm_async_reply_reason.
4422         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4423         constructor.  Change type of breakpoint.
4424         (finish_command_fsm_ops): Remove.
4425         (new_finish_command_fsm): Remove.
4426         (finish_command_fsm::should_stop): Rename from
4427         finish_command_fsm_should_stop.
4428         (finish_command_fsm::clean_up): Rename from
4429         finish_command_fsm_clean_up.
4430         (finish_command_fsm::return_value): Rename from
4431         finish_command_fsm_return_value.
4432         (finish_command_fsm::do_async_reply_reason): Rename from
4433         finish_command_fsm_async_reply_reason.
4434         (finish_command): Update.
4435         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4436         Add constructor.
4437         (call_thread_fsm_ops): Remove.
4438         (call_thread_fsm::call_thread_fsm): Rename from
4439         new_call_thread_fsm.
4440         (call_thread_fsm::should_stop): Rename from
4441         call_thread_fsm_should_stop.
4442         (call_thread_fsm::should_notify_stop): Rename from
4443         call_thread_fsm_should_notify_stop.
4444         (run_inferior_call, call_function_by_hand_dummy): Update.
4445         * cli/cli-interp.c (should_print_stop_to_console): Update.
4446         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4447         Add constructor.  Change type of location_breakpoint,
4448         caller_breakpoint.
4449         (until_break_fsm_ops): Remove.
4450         (new_until_break_fsm): Remove.
4451         (until_break_fsm::should_stop): Rename from
4452         until_break_fsm_should_stop.
4453         (until_break_fsm::clean_up): Rename from
4454         until_break_fsm_clean_up.
4455         (until_break_fsm::do_async_reply_reason): Rename from
4456         until_break_fsm_async_reply_reason.
4457         (until_break_command): Update.
4458         * thread-fsm.c: Remove.
4459         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4460
4461 2019-02-07  Tom Tromey  <tom@tromey.com>
4462
4463         * yy-remap.h: Add include guard.
4464         * xtensa-tdep.h: Add include guard.
4465         * xcoffread.h: Rename include guard.
4466         * varobj-iter.h: Add include guard.
4467         * tui/tui.h: Rename include guard.
4468         * tui/tui-winsource.h: Rename include guard.
4469         * tui/tui-wingeneral.h: Rename include guard.
4470         * tui/tui-windata.h: Rename include guard.
4471         * tui/tui-win.h: Rename include guard.
4472         * tui/tui-stack.h: Rename include guard.
4473         * tui/tui-source.h: Rename include guard.
4474         * tui/tui-regs.h: Rename include guard.
4475         * tui/tui-out.h: Rename include guard.
4476         * tui/tui-layout.h: Rename include guard.
4477         * tui/tui-io.h: Rename include guard.
4478         * tui/tui-hooks.h: Rename include guard.
4479         * tui/tui-file.h: Rename include guard.
4480         * tui/tui-disasm.h: Rename include guard.
4481         * tui/tui-data.h: Rename include guard.
4482         * tui/tui-command.h: Rename include guard.
4483         * tic6x-tdep.h: Add include guard.
4484         * target/waitstatus.h: Rename include guard.
4485         * target/wait.h: Rename include guard.
4486         * target/target.h: Rename include guard.
4487         * target/resume.h: Rename include guard.
4488         * target-float.h: Rename include guard.
4489         * stabsread.h: Add include guard.
4490         * rs6000-tdep.h: Add include guard.
4491         * riscv-fbsd-tdep.h: Add include guard.
4492         * regformats/regdef.h: Rename include guard.
4493         * record.h: Rename include guard.
4494         * python/python.h: Rename include guard.
4495         * python/python-internal.h: Rename include guard.
4496         * python/py-stopevent.h: Rename include guard.
4497         * python/py-ref.h: Rename include guard.
4498         * python/py-record.h: Rename include guard.
4499         * python/py-record-full.h: Rename include guard.
4500         * python/py-record-btrace.h: Rename include guard.
4501         * python/py-instruction.h: Rename include guard.
4502         * python/py-events.h: Rename include guard.
4503         * python/py-event.h: Rename include guard.
4504         * procfs.h: Add include guard.
4505         * proc-utils.h: Add include guard.
4506         * p-lang.h: Add include guard.
4507         * or1k-tdep.h: Rename include guard.
4508         * observable.h: Rename include guard.
4509         * nto-tdep.h: Rename include guard.
4510         * nat/x86-linux.h: Rename include guard.
4511         * nat/x86-linux-dregs.h: Rename include guard.
4512         * nat/x86-gcc-cpuid.h: Add include guard.
4513         * nat/x86-dregs.h: Rename include guard.
4514         * nat/x86-cpuid.h: Rename include guard.
4515         * nat/ppc-linux.h: Rename include guard.
4516         * nat/mips-linux-watch.h: Rename include guard.
4517         * nat/linux-waitpid.h: Rename include guard.
4518         * nat/linux-ptrace.h: Rename include guard.
4519         * nat/linux-procfs.h: Rename include guard.
4520         * nat/linux-osdata.h: Rename include guard.
4521         * nat/linux-nat.h: Rename include guard.
4522         * nat/linux-namespaces.h: Rename include guard.
4523         * nat/linux-btrace.h: Rename include guard.
4524         * nat/glibc_thread_db.h: Rename include guard.
4525         * nat/gdb_thread_db.h: Rename include guard.
4526         * nat/gdb_ptrace.h: Rename include guard.
4527         * nat/fork-inferior.h: Rename include guard.
4528         * nat/amd64-linux-siginfo.h: Rename include guard.
4529         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4530         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4531         * nat/aarch64-linux.h: Rename include guard.
4532         * nat/aarch64-linux-hw-point.h: Rename include guard.
4533         * mn10300-tdep.h: Add include guard.
4534         * mips-linux-tdep.h: Add include guard.
4535         * mi/mi-parse.h: Rename include guard.
4536         * mi/mi-out.h: Rename include guard.
4537         * mi/mi-main.h: Rename include guard.
4538         * mi/mi-interp.h: Rename include guard.
4539         * mi/mi-getopt.h: Rename include guard.
4540         * mi/mi-console.h: Rename include guard.
4541         * mi/mi-common.h: Rename include guard.
4542         * mi/mi-cmds.h: Rename include guard.
4543         * mi/mi-cmd-break.h: Rename include guard.
4544         * m2-lang.h: Add include guard.
4545         * location.h: Rename include guard.
4546         * linux-record.h: Rename include guard.
4547         * linux-nat.h: Add include guard.
4548         * linux-fork.h: Add include guard.
4549         * i386-darwin-tdep.h: Rename include guard.
4550         * hppa-linux-offsets.h: Add include guard.
4551         * guile/guile.h: Rename include guard.
4552         * guile/guile-internal.h: Rename include guard.
4553         * gnu-nat.h: Rename include guard.
4554         * gdb-stabs.h: Rename include guard.
4555         * frv-tdep.h: Add include guard.
4556         * f-lang.h: Add include guard.
4557         * event-loop.h: Add include guard.
4558         * darwin-nat.h: Rename include guard.
4559         * cp-abi.h: Rename include guard.
4560         * config/sparc/nm-sol2.h: Rename include guard.
4561         * config/nm-nto.h: Rename include guard.
4562         * config/nm-linux.h: Add include guard.
4563         * config/i386/nm-i386gnu.h: Rename include guard.
4564         * config/djgpp/nl_types.h: Rename include guard.
4565         * config/djgpp/langinfo.h: Rename include guard.
4566         * compile/gcc-cp-plugin.h: Add include guard.
4567         * compile/gcc-c-plugin.h: Add include guard.
4568         * compile/compile.h: Rename include guard.
4569         * compile/compile-object-run.h: Rename include guard.
4570         * compile/compile-object-load.h: Rename include guard.
4571         * compile/compile-internal.h: Rename include guard.
4572         * compile/compile-cplus.h: Rename include guard.
4573         * compile/compile-c.h: Rename include guard.
4574         * common/xml-utils.h: Rename include guard.
4575         * common/x86-xstate.h: Rename include guard.
4576         * common/version.h: Rename include guard.
4577         * common/vec.h: Rename include guard.
4578         * common/tdesc.h: Rename include guard.
4579         * common/selftest.h: Rename include guard.
4580         * common/scoped_restore.h: Rename include guard.
4581         * common/scoped_mmap.h: Rename include guard.
4582         * common/scoped_fd.h: Rename include guard.
4583         * common/safe-iterator.h: Rename include guard.
4584         * common/run-time-clock.h: Rename include guard.
4585         * common/refcounted-object.h: Rename include guard.
4586         * common/queue.h: Rename include guard.
4587         * common/ptid.h: Rename include guard.
4588         * common/print-utils.h: Rename include guard.
4589         * common/preprocessor.h: Rename include guard.
4590         * common/pathstuff.h: Rename include guard.
4591         * common/observable.h: Rename include guard.
4592         * common/netstuff.h: Rename include guard.
4593         * common/job-control.h: Rename include guard.
4594         * common/host-defs.h: Rename include guard.
4595         * common/gdb_wait.h: Rename include guard.
4596         * common/gdb_vecs.h: Rename include guard.
4597         * common/gdb_unlinker.h: Rename include guard.
4598         * common/gdb_unique_ptr.h: Rename include guard.
4599         * common/gdb_tilde_expand.h: Rename include guard.
4600         * common/gdb_sys_time.h: Rename include guard.
4601         * common/gdb_string_view.h: Rename include guard.
4602         * common/gdb_splay_tree.h: Rename include guard.
4603         * common/gdb_setjmp.h: Rename include guard.
4604         * common/gdb_ref_ptr.h: Rename include guard.
4605         * common/gdb_optional.h: Rename include guard.
4606         * common/gdb_locale.h: Rename include guard.
4607         * common/gdb_assert.h: Rename include guard.
4608         * common/filtered-iterator.h: Rename include guard.
4609         * common/filestuff.h: Rename include guard.
4610         * common/fileio.h: Rename include guard.
4611         * common/environ.h: Rename include guard.
4612         * common/common-utils.h: Rename include guard.
4613         * common/common-types.h: Rename include guard.
4614         * common/common-regcache.h: Rename include guard.
4615         * common/common-inferior.h: Rename include guard.
4616         * common/common-gdbthread.h: Rename include guard.
4617         * common/common-exceptions.h: Rename include guard.
4618         * common/common-defs.h: Rename include guard.
4619         * common/common-debug.h: Rename include guard.
4620         * common/cleanups.h: Rename include guard.
4621         * common/buffer.h: Rename include guard.
4622         * common/btrace-common.h: Rename include guard.
4623         * common/break-common.h: Rename include guard.
4624         * cli/cli-utils.h: Rename include guard.
4625         * cli/cli-style.h: Rename include guard.
4626         * cli/cli-setshow.h: Rename include guard.
4627         * cli/cli-script.h: Rename include guard.
4628         * cli/cli-interp.h: Rename include guard.
4629         * cli/cli-decode.h: Rename include guard.
4630         * cli/cli-cmds.h: Rename include guard.
4631         * charset-list.h: Add include guard.
4632         * buildsym-legacy.h: Rename include guard.
4633         * bfin-tdep.h: Add include guard.
4634         * ax.h: Rename include guard.
4635         * arm-linux-tdep.h: Add include guard.
4636         * arm-fbsd-tdep.h: Add include guard.
4637         * arch/xtensa.h: Rename include guard.
4638         * arch/tic6x.h: Add include guard.
4639         * arch/i386.h: Add include guard.
4640         * arch/arm.h: Rename include guard.
4641         * arch/arm-linux.h: Rename include guard.
4642         * arch/arm-get-next-pcs.h: Rename include guard.
4643         * arch/amd64.h: Add include guard.
4644         * arch/aarch64-insn.h: Rename include guard.
4645         * arch-utils.h: Rename include guard.
4646         * annotate.h: Add include guard.
4647         * amd64-darwin-tdep.h: Rename include guard.
4648         * aarch64-linux-tdep.h: Add include guard.
4649         * aarch64-fbsd-tdep.h: Add include guard.
4650         * aarch32-linux-nat.h: Add include guard.
4651
4652 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4653
4654         * macrotab.c (macro_define_internal): New function that
4655         factorizes macro_define_object_internal and macro_define_function
4656         code.
4657         (macro_define_object_internal): Use macro_define_internal.
4658         (macro_define_function): Likewise.
4659
4660 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4661
4662         * macrocmd.c (extract_identifier): Return
4663         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4664         callers.
4665
4666 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4667
4668         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4669
4670 2019-02-05  Tom Tromey  <tom@tromey.com>
4671
4672         * target.c (target_stack::unpush): Move assertion earlier.
4673
4674 2019-01-30  Tom Tromey  <tom@tromey.com>
4675
4676         PR python/23615:
4677         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4678         (gdbpy_parse_and_eval): Likewise.
4679         * python/python-internal.h (gdbpy_allow_threads): New class.
4680
4681 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4682
4683         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4684         (aarch64_fbsd_fpregmap): Move earlier.
4685         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4686         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4687         instead of individual calls to trad_frame_set_reg_addr.
4688         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4689         earlier.
4690         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4691         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4692         instead of individual calls to trad_frame_set_reg_addr.
4693
4694 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4695
4696         * CONTRIBUTE: Replace contribution list with wiki link.
4697
4698 2019-01-25  Tom Tromey  <tom@tromey.com>
4699
4700         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4701
4702 2019-01-25  Tom Tromey  <tom@tromey.com>
4703
4704         * xtensa-linux-nat.c: Fix common/ includes.
4705         * xml-support.h: Fix common/ includes.
4706         * xml-support.c: Fix common/ includes.
4707         * x86-linux-nat.c: Fix common/ includes.
4708         * windows-nat.c: Fix common/ includes.
4709         * varobj.h: Fix common/ includes.
4710         * varobj.c: Fix common/ includes.
4711         * value.c: Fix common/ includes.
4712         * valops.c: Fix common/ includes.
4713         * utils.c: Fix common/ includes.
4714         * unittests/xml-utils-selftests.c: Fix common/ includes.
4715         * unittests/utils-selftests.c: Fix common/ includes.
4716         * unittests/unpack-selftests.c: Fix common/ includes.
4717         * unittests/tracepoint-selftests.c: Fix common/ includes.
4718         * unittests/style-selftests.c: Fix common/ includes.
4719         * unittests/string_view-selftests.c: Fix common/ includes.
4720         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4721         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4722         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4723         * unittests/rsp-low-selftests.c: Fix common/ includes.
4724         * unittests/parse-connection-spec-selftests.c: Fix common/
4725         includes.
4726         * unittests/optional-selftests.c: Fix common/ includes.
4727         * unittests/offset-type-selftests.c: Fix common/ includes.
4728         * unittests/observable-selftests.c: Fix common/ includes.
4729         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4730         * unittests/memrange-selftests.c: Fix common/ includes.
4731         * unittests/memory-map-selftests.c: Fix common/ includes.
4732         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4733         * unittests/function-view-selftests.c: Fix common/ includes.
4734         * unittests/environ-selftests.c: Fix common/ includes.
4735         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4736         * unittests/common-utils-selftests.c: Fix common/ includes.
4737         * unittests/cli-utils-selftests.c: Fix common/ includes.
4738         * unittests/array-view-selftests.c: Fix common/ includes.
4739         * ui-file.c: Fix common/ includes.
4740         * tui/tui-io.c: Fix common/ includes.
4741         * tracepoint.h: Fix common/ includes.
4742         * tracepoint.c: Fix common/ includes.
4743         * tracefile-tfile.c: Fix common/ includes.
4744         * top.h: Fix common/ includes.
4745         * top.c: Fix common/ includes.
4746         * thread.c: Fix common/ includes.
4747         * target/waitstatus.h: Fix common/ includes.
4748         * target/waitstatus.c: Fix common/ includes.
4749         * target.h: Fix common/ includes.
4750         * target.c: Fix common/ includes.
4751         * target-memory.c: Fix common/ includes.
4752         * target-descriptions.c: Fix common/ includes.
4753         * symtab.h: Fix common/ includes.
4754         * symfile.c: Fix common/ includes.
4755         * stap-probe.c: Fix common/ includes.
4756         * spu-linux-nat.c: Fix common/ includes.
4757         * sparc-nat.c: Fix common/ includes.
4758         * source.c: Fix common/ includes.
4759         * solib.c: Fix common/ includes.
4760         * solib-target.c: Fix common/ includes.
4761         * ser-unix.c: Fix common/ includes.
4762         * ser-tcp.c: Fix common/ includes.
4763         * ser-pipe.c: Fix common/ includes.
4764         * ser-base.c: Fix common/ includes.
4765         * selftest-arch.c: Fix common/ includes.
4766         * s12z-tdep.c: Fix common/ includes.
4767         * rust-exp.y: Fix common/ includes.
4768         * rs6000-aix-tdep.c: Fix common/ includes.
4769         * riscv-tdep.c: Fix common/ includes.
4770         * remote.c: Fix common/ includes.
4771         * remote-notif.h: Fix common/ includes.
4772         * remote-fileio.h: Fix common/ includes.
4773         * remote-fileio.c: Fix common/ includes.
4774         * regcache.h: Fix common/ includes.
4775         * regcache.c: Fix common/ includes.
4776         * record-btrace.c: Fix common/ includes.
4777         * python/python.c: Fix common/ includes.
4778         * python/py-type.c: Fix common/ includes.
4779         * python/py-inferior.c: Fix common/ includes.
4780         * progspace.h: Fix common/ includes.
4781         * producer.c: Fix common/ includes.
4782         * procfs.c: Fix common/ includes.
4783         * proc-api.c: Fix common/ includes.
4784         * printcmd.c: Fix common/ includes.
4785         * ppc-linux-nat.c: Fix common/ includes.
4786         * parser-defs.h: Fix common/ includes.
4787         * osdata.c: Fix common/ includes.
4788         * obsd-nat.c: Fix common/ includes.
4789         * nat/x86-linux.c: Fix common/ includes.
4790         * nat/x86-linux-dregs.c: Fix common/ includes.
4791         * nat/x86-dregs.h: Fix common/ includes.
4792         * nat/x86-dregs.c: Fix common/ includes.
4793         * nat/ppc-linux.c: Fix common/ includes.
4794         * nat/mips-linux-watch.h: Fix common/ includes.
4795         * nat/mips-linux-watch.c: Fix common/ includes.
4796         * nat/linux-waitpid.c: Fix common/ includes.
4797         * nat/linux-ptrace.h: Fix common/ includes.
4798         * nat/linux-ptrace.c: Fix common/ includes.
4799         * nat/linux-procfs.c: Fix common/ includes.
4800         * nat/linux-personality.c: Fix common/ includes.
4801         * nat/linux-osdata.c: Fix common/ includes.
4802         * nat/linux-namespaces.c: Fix common/ includes.
4803         * nat/linux-btrace.h: Fix common/ includes.
4804         * nat/linux-btrace.c: Fix common/ includes.
4805         * nat/fork-inferior.c: Fix common/ includes.
4806         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4807         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4808         * nat/aarch64-linux.c: Fix common/ includes.
4809         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4810         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4811         * namespace.h: Fix common/ includes.
4812         * mips-linux-tdep.c: Fix common/ includes.
4813         * minsyms.c: Fix common/ includes.
4814         * mi/mi-parse.h: Fix common/ includes.
4815         * mi/mi-main.c: Fix common/ includes.
4816         * mi/mi-cmd-env.c: Fix common/ includes.
4817         * memrange.h: Fix common/ includes.
4818         * memattr.c: Fix common/ includes.
4819         * maint.h: Fix common/ includes.
4820         * maint.c: Fix common/ includes.
4821         * main.c: Fix common/ includes.
4822         * machoread.c: Fix common/ includes.
4823         * location.c: Fix common/ includes.
4824         * linux-thread-db.c: Fix common/ includes.
4825         * linux-nat.c: Fix common/ includes.
4826         * linux-fork.c: Fix common/ includes.
4827         * inline-frame.c: Fix common/ includes.
4828         * infrun.c: Fix common/ includes.
4829         * inflow.c: Fix common/ includes.
4830         * inferior.h: Fix common/ includes.
4831         * inferior.c: Fix common/ includes.
4832         * infcmd.c: Fix common/ includes.
4833         * inf-ptrace.c: Fix common/ includes.
4834         * inf-child.c: Fix common/ includes.
4835         * ia64-linux-nat.c: Fix common/ includes.
4836         * i387-tdep.c: Fix common/ includes.
4837         * i386-tdep.c: Fix common/ includes.
4838         * i386-linux-tdep.c: Fix common/ includes.
4839         * i386-linux-nat.c: Fix common/ includes.
4840         * i386-go32-tdep.c: Fix common/ includes.
4841         * i386-fbsd-tdep.c: Fix common/ includes.
4842         * i386-fbsd-nat.c: Fix common/ includes.
4843         * guile/scm-type.c: Fix common/ includes.
4844         * guile/guile.c: Fix common/ includes.
4845         * go32-nat.c: Fix common/ includes.
4846         * gnu-nat.c: Fix common/ includes.
4847         * gdbthread.h: Fix common/ includes.
4848         * gdbarch-selftests.c: Fix common/ includes.
4849         * gdb_usleep.c: Fix common/ includes.
4850         * gdb_select.h: Fix common/ includes.
4851         * gdb_bfd.c: Fix common/ includes.
4852         * gcore.c: Fix common/ includes.
4853         * fork-child.c: Fix common/ includes.
4854         * findvar.c: Fix common/ includes.
4855         * fbsd-nat.c: Fix common/ includes.
4856         * event-top.c: Fix common/ includes.
4857         * event-loop.c: Fix common/ includes.
4858         * dwarf2read.c: Fix common/ includes.
4859         * dwarf2loc.c: Fix common/ includes.
4860         * dwarf2-frame.c: Fix common/ includes.
4861         * dwarf-index-cache.c: Fix common/ includes.
4862         * dtrace-probe.c: Fix common/ includes.
4863         * disasm-selftests.c: Fix common/ includes.
4864         * defs.h: Fix common/ includes.
4865         * csky-tdep.c: Fix common/ includes.
4866         * cp-valprint.c: Fix common/ includes.
4867         * cp-support.h: Fix common/ includes.
4868         * cp-support.c: Fix common/ includes.
4869         * corelow.c: Fix common/ includes.
4870         * completer.h: Fix common/ includes.
4871         * completer.c: Fix common/ includes.
4872         * compile/compile.c: Fix common/ includes.
4873         * compile/compile-loc2c.c: Fix common/ includes.
4874         * compile/compile-cplus-types.c: Fix common/ includes.
4875         * compile/compile-cplus-symbols.c: Fix common/ includes.
4876         * command.h: Fix common/ includes.
4877         * cli/cli-dump.c: Fix common/ includes.
4878         * cli/cli-cmds.c: Fix common/ includes.
4879         * charset.c: Fix common/ includes.
4880         * build-id.c: Fix common/ includes.
4881         * btrace.h: Fix common/ includes.
4882         * btrace.c: Fix common/ includes.
4883         * breakpoint.h: Fix common/ includes.
4884         * breakpoint.c: Fix common/ includes.
4885         * ax.h:
4886         (enum agent_op): Fix common/ includes.
4887         * ax-general.c (struct aop_map): Fix common/ includes.
4888         * ax-gdb.c: Fix common/ includes.
4889         * auxv.c: Fix common/ includes.
4890         * auto-load.c: Fix common/ includes.
4891         * arm-tdep.c: Fix common/ includes.
4892         * arch/riscv.c: Fix common/ includes.
4893         * arch/ppc-linux-common.c: Fix common/ includes.
4894         * arch/i386.c: Fix common/ includes.
4895         * arch/arm.c: Fix common/ includes.
4896         * arch/arm-linux.c: Fix common/ includes.
4897         * arch/arm-get-next-pcs.c: Fix common/ includes.
4898         * arch/amd64.c: Fix common/ includes.
4899         * arch/aarch64.c: Fix common/ includes.
4900         * arch/aarch64-insn.c: Fix common/ includes.
4901         * arch-utils.c: Fix common/ includes.
4902         * amd64-windows-tdep.c: Fix common/ includes.
4903         * amd64-tdep.c: Fix common/ includes.
4904         * amd64-sol2-tdep.c: Fix common/ includes.
4905         * amd64-obsd-tdep.c: Fix common/ includes.
4906         * amd64-nbsd-tdep.c: Fix common/ includes.
4907         * amd64-linux-tdep.c: Fix common/ includes.
4908         * amd64-linux-nat.c: Fix common/ includes.
4909         * amd64-fbsd-tdep.c: Fix common/ includes.
4910         * amd64-fbsd-nat.c: Fix common/ includes.
4911         * amd64-dicos-tdep.c: Fix common/ includes.
4912         * amd64-darwin-tdep.c: Fix common/ includes.
4913         * agent.c: Fix common/ includes.
4914         * ada-lang.h: Fix common/ includes.
4915         * ada-lang.c: Fix common/ includes.
4916         * aarch64-tdep.c: Fix common/ includes.
4917
4918 2019-01-25  Tom Tromey  <tom@tromey.com>
4919
4920         * common/create-version.sh: Use common/version.h.
4921
4922 2019-01-24  Pedro Alves  <palves@redhat.com>
4923
4924         * infrun.c (signal_stop, signal_print, signal_program)
4925         (signal_catch, signal_pass): Now arrays instead of pointers.
4926         (update_signals_program_target, do_target_resume)
4927         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4928         * linux-nat.c (linux_nat_target::pass_signals)
4929         (linux_nat_target::create_inferior, linux_nat_target::attach):
4930         Adjust.
4931         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4932         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4933         * procfs.c (procfs_target::pass_signals): Adjust.
4934         * record-full.c (record_full_target::resume): Adjust.
4935         * remote.c (remote_target::pass_signals)
4936         (remote_target::program_signals): Adjust.
4937         * target-debug.h (target_debug_print_signals): Now takes a
4938         gdb::array_view as parameter.  Adjust.
4939         * target.h (target_ops) <pass_signals, program_signals>: Replace
4940         pointer and length parameters with gdb::array_view.
4941         (target_pass_signals, target_program_signals): Likewise.
4942         * target-delegates.c: Regenerate.
4943
4944 2019-01-24  Pedro Alves  <palves@redhat.com>
4945
4946         * common/forward-scope-exit.h
4947         (forward_scope_exit::forward_scope_exit): Pass arguments to
4948         m_bind_function directly, instead of creating a std::bind and
4949         copying that.
4950
4951 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4952
4953         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4954         for static members.
4955         (pass_in_v_vfp_candidate): Likewise.
4956
4957 2019-01-23  Tom Tromey  <tom@tromey.com>
4958             Pedro Alves  <palves@redhat.com>
4959
4960         * regcache.c (class regcache_invalidator): Remove.
4961         (regcache::raw_write): Use make_scope_exit.
4962
4963 2019-01-23  Tom Tromey  <tom@tromey.com>
4964
4965         * ui-out.h (class ui_out_emit_type): Update comment.
4966
4967 2019-01-23  Tom Tromey  <tom@tromey.com>
4968
4969         * infrun.c (fetch_inferior_event): Update comment.
4970
4971 2019-01-23  Tom Tromey  <tom@tromey.com>
4972             Pedro Alves  <palves@redhat.com>
4973
4974         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4975         parameter.
4976         (fetch_inferior_event): Use SCOPE_EXIT.
4977
4978
4979 2019-01-23  Tom Tromey  <tom@tromey.com>
4980             Pedro Alves  <palves@redhat.com>
4981
4982         * infrun.c (disable_thread_events): Delete.
4983         (stop_all_threads): Use SCOPE_EXIT.
4984
4985 2019-01-23  Tom Tromey  <tom@tromey.com>
4986             Pedro Alves  <palves@redhat.com>
4987
4988         * symfile.c: Include forward-scope-exit.h.
4989         (clear_symtab_users_cleanup): Replace forward declaration with
4990         a FORWARD_SCOPE_EXIT.
4991         (syms_from_objfile_1): Use the forward_scope_exit and
4992         gdb::optional instead of cleanup_function.
4993         (reread_symbols): Use the forward_scope_exit instead of
4994         cleanup_function.
4995         (clear_symtab_users_cleanup): Remove function.
4996
4997 2019-01-23  Tom Tromey  <tom@tromey.com>
4998             Pedro Alves  <palves@redhat.com>
4999
5000         * linux-nat.c: Include scope-exit.h.
5001         (cleanup_target_stop): Remove.
5002         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5003         SCOPE_EXIT.
5004
5005 2019-01-23  Tom Tromey  <tom@tromey.com>
5006             Pedro Alves  <palves@redhat.com>
5007
5008         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5009         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5010
5011 2019-01-23  Tom Tromey  <tom@tromey.com>
5012             Andrew Burgess  <andrew.burgess@embecosm.com>
5013             Pedro Alves  <palves@redhat.com>
5014
5015         * infrun.c (fetch_inferior_event): Use scope_exit.
5016         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5017         * top.c (execute_command): Use scope_exit.
5018         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5019         * utils.c (do_bpstat_clear_actions_cleanup)
5020         (make_bpstat_clear_actions_cleanup): Remove.
5021
5022 2019-01-23  Tom Tromey  <tom@tromey.com>
5023             Pedro Alves  <palves@redhat.com>
5024
5025         * infrun.c: Include "common/scope-exit.h"
5026         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5027         (wait_for_inferior): Use SCOPE_EXIT.
5028         (fetch_inferior_event): Use scope_exit.
5029
5030 2019-01-23  Tom Tromey  <tom@tromey.com>
5031             Pedro Alves  <palves@redhat.com>
5032
5033         * breakpoint.c (create_breakpoint): Remove cleanup.
5034
5035 2019-01-23  Tom Tromey  <tom@tromey.com>
5036             Andrew Burgess  <andrew.burgess@embecosm.com>
5037             Pedro Alves  <palves@redhat.com>
5038
5039 2019-01-23  Pedro Alves  <palves@redhat.com>
5040
5041         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5042
5043 2019-01-23  Pedro Alves  <palves@redhat.com>
5044             Andrew Burgess  <andrew.burgess@embecosm.com>
5045
5046         * gdbthread.h: Include "common/forward-scope-exit.h".
5047         (scoped_finish_thread_state): Redefine custom class in terms of
5048         forward_scope_exit.
5049
5050 2019-01-23  Pedro Alves  <palves@redhat.com>
5051             Andrew Burgess  <andrew.burgess@embecosm.com>
5052
5053         * common/forward-scope-exit.h: New file.
5054
5055 2019-01-23  Pedro Alves  <palves@redhat.com>
5056             Andrew Burgess  <andrew.burgess@embecosm.com>
5057             Tom Tromey  <tom@tromey.com>
5058
5059         * common/scope-exit.h: New file.
5060
5061 2019-01-23  Pedro Alves  <palves@redhat.com>
5062
5063         * common/preprocessor.h (ESC): Rename to ...
5064         (ESC_PARENS): ... this.
5065         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5066         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5067
5068 2019-01-23  Tom Tromey  <tom@tromey.com>
5069
5070         * language.h (class scoped_switch_to_sym_language_if_auto):
5071         Initialize m_lang in both cases.
5072
5073 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5074
5075         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5076         with XCNEW.
5077
5078 2019-01-22  Tom Tromey  <tom@tromey.com>
5079
5080         * corelow.c: Do not include sys/file.h.
5081
5082 2019-01-22  Tom Tromey  <tom@tromey.com>
5083
5084         * tui/tui-wingeneral.h: Include gdb_curses.h.
5085
5086 2019-01-22  Tom Tromey  <tom@tromey.com>
5087
5088         * source-cache.h (class source_cache) <get_source_lines,
5089         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5090
5091 2019-01-22  Tom Tromey  <tom@tromey.com>
5092
5093         * remote-fileio.h (struct remote_target): Declare.
5094
5095 2019-01-22  Tom Tromey  <tom@tromey.com>
5096
5097         * python/py-arch.c: Do not include py-ref.h.
5098         * python/py-bpevent.c: Do not include py-ref.h.
5099         * python/py-cmd.c: Do not include py-ref.h.
5100         * python/py-continueevent.c: Do not include py-ref.h.
5101         * python/py-event.h: Do not include py-ref.h.
5102         * python/py-evtregistry.c: Do not include py-ref.h.
5103         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5104         * python/py-frame.c: Do not include py-ref.h.
5105         * python/py-framefilter.c: Do not include py-ref.h.
5106         * python/py-function.c: Do not include py-ref.h.
5107         * python/py-infevents.c: Do not include py-ref.h.
5108         * python/py-linetable.c: Do not include py-ref.h.
5109         * python/py-objfile.c: Do not include py-ref.h.
5110         * python/py-param.c: Do not include py-ref.h.
5111         * python/py-prettyprint.c: Do not include py-ref.h.
5112         * python/py-progspace.c: Do not include py-ref.h.
5113         * python/py-symbol.c: Do not include py-ref.h.
5114         * python/py-symtab.c: Do not include py-ref.h.
5115         * python/py-type.c: Do not include py-ref.h.
5116         * python/py-unwind.c: Do not include py-ref.h.
5117         * python/py-utils.c: Do not include py-ref.h.
5118         * python/py-value.c: Do not include py-ref.h.
5119         * python/py-varobj.c: Do not include py-ref.h.
5120         * python/py-xmethods.c: Do not include py-ref.h.
5121         * python/python.c: Do not include py-ref.h.
5122         * varobj.c: Do not include py-ref.h.
5123
5124 2019-01-22  Tom Tromey  <tom@tromey.com>
5125
5126         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5127         keyword for bcache.
5128
5129 2019-01-22  Tom Tromey  <tom@tromey.com>
5130
5131         * compile/compile-cplus-types.c: Remove a comment by #include.
5132
5133 2019-01-22  Tom Tromey  <tom@tromey.com>
5134
5135         * compile/gcc-c-plugin.h: Include compile-internal.h.
5136
5137 2019-01-22  Tom Tromey  <tom@tromey.com>
5138
5139         * stabsread.c (EXTERN): Do not define.
5140         (symnum, next_symbol_text_func, processing_gcc_compilation)
5141         (within_function, global_sym_chain, global_stabs)
5142         (previous_stab_code, this_object_header_files)
5143         (n_this_object_header_files)
5144         (n_allocated_this_object_header_files): Define.
5145         * stabsread.h (EXTERN): Never define.  Use "extern".
5146
5147 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5148
5149         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5150         history_value.
5151
5152 2019-01-21  Tom Tromey  <tom@tromey.com>
5153
5154         * ui-out.c: Fix includes.
5155         * tui/tui-source.c: Fix includes.
5156         * target.c: Fix includes.
5157         * remote.c: Fix includes.
5158         * regcache.c: Fix includes.
5159         * python/py-block.c: Fix includes.
5160         * printcmd.c: Fix includes.
5161         * or1k-tdep.c: Fix includes.
5162         * mi/mi-main.c: Fix includes.
5163         * m32r-tdep.c: Fix includes.
5164         * csky-tdep.c: Fix includes.
5165         * compile/compile-cplus-types.c: Fix includes.
5166         * cli/cli-interp.c: Fix includes.
5167
5168 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5169
5170         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5171         for padding.
5172
5173 2019-01-16  Tom Tromey  <tom@tromey.com>
5174
5175         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5176         earlier.
5177         (struct objfile) <msymbols_range>: Move from top level.
5178         <msymbols>: New method.
5179         (class objfile_msymbols): Remove.
5180         * symtab.c (default_collect_symbol_completion_matches_break_on):
5181         Update.
5182         * symmisc.c (dump_msymbols): Update.
5183         * stabsread.c (scan_file_globals): Update.
5184         * objc-lang.c (info_selectors_command, info_classes_command)
5185         (find_methods): Update.
5186         * minsyms.c (find_solib_trampoline_target): Update.
5187         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5188         * coffread.c (coff_symfile_read): Update.
5189         * ada-lang.c (ada_lookup_simple_minsym)
5190         (ada_collect_symbol_completion_matches): Update.
5191
5192 2019-01-16  Tom Tromey  <tom@tromey.com>
5193
5194         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5195         type.  Remove no-argument constructor.
5196         <iterator::operator++>: Simplify.
5197         <begin>: Update.
5198         <end>: Use minimal_symbol_count.
5199
5200 2019-01-16  Tom Tromey  <tom@tromey.com>
5201
5202         * objfiles.h (struct objfile) <psymtabs>: New method.
5203         (class objfile_psymtabs): Remove.
5204         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5205         typedef.
5206         <range>: New method.
5207         (require_partial_symbols): Change return type.
5208         * psymtab.c (require_partial_symbols)
5209         (psym_expand_symtabs_matching): Update.
5210         * mdebugread.c (parse_partial_symbols): Update.
5211         * dbxread.c (dbx_end_psymtab): Update.
5212
5213 2019-01-15  Tom Tromey  <tom@tromey.com>
5214
5215         * symtab.c (lookup_objfile_from_block)
5216         (lookup_symbol_in_objfile_symtabs)
5217         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5218         (find_line_symtab, info_sources_command)
5219         (default_collect_symbol_completion_matches_break_on)
5220         (make_source_files_completion_list): Update.
5221         * symmisc.c (print_objfile_statistics, dump_objfile)
5222         (maintenance_print_symbols, maintenance_info_symtabs)
5223         (maintenance_check_symtabs, maintenance_info_line_tables):
5224         Update.
5225         * source.c (select_source_symtab)
5226         (forget_cached_source_info_for_objfile): Update.
5227         * objfiles.h (class objfile_compunits): Remove.
5228         (struct objfile) <compunits_range>: New typedef.
5229         (compunits): New method.
5230         * objfiles.c (objfile_relocate1): Update.
5231         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5232         * maint.c (count_symtabs_and_blocks): Update.
5233         * linespec.c (iterate_over_all_matching_symtabs): Update.
5234         * cp-support.c (add_symbol_overload_list_qualified): Update.
5235         * coffread.c (coff_symtab_read): Update.
5236         * ada-lang.c (add_nonlocal_symbols)
5237         (ada_collect_symbol_completion_matches)
5238         (ada_add_global_exceptions): Update.
5239
5240 2019-01-15  Tom Tromey  <tom@tromey.com>
5241
5242         * progspace.h (program_space) <objfiles_safe_range>: New
5243         typedef.
5244         <objfiles_safe>: New method.
5245         * objfiles.h (class all_objfiles_safe): Remove.
5246         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5247         * jit.c (jit_inferior_exit_hook): Update.
5248
5249 2019-01-17  Tom Tromey  <tom@tromey.com>
5250
5251         * progspace.h (program_space) <objfiles_range>: New typedef.
5252         <objfiles>: New method.
5253         <objfiles_head>: Rename from objfiles.
5254         (object_files): Update.
5255         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5256         * guile/scm-pretty-print.c
5257         (ppscm_find_pretty_printer_from_objfiles): Update.
5258         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5259         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5260         Update.
5261         * python/py-progspace.c (pspy_get_objfiles): Update.
5262         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5263         Update.
5264         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5265         (objfpy_lookup_objfile_by_build_id): Update.
5266         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5267         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5268         Update.
5269         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5270         (expand_symtab_containing_pc, lookup_objfile_from_block)
5271         (lookup_static_symbol, basic_lookup_transparent_type)
5272         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5273         (find_line_symtab, info_sources_command)
5274         (default_collect_symbol_completion_matches_break_on)
5275         (make_source_files_completion_list, find_main_name): Update.
5276         * symmisc.c (print_symbol_bcache_statistics)
5277         (print_objfile_statistics, maintenance_print_symbols)
5278         (maintenance_print_msymbols, maintenance_print_objfiles)
5279         (maintenance_info_symtabs, maintenance_check_symtabs)
5280         (maintenance_expand_symtabs, maintenance_info_line_tables):
5281         Update.
5282         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5283         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5284         (map_overlay_command, unmap_overlay_command)
5285         (simple_overlay_update, expand_symtabs_matching)
5286         (map_symbol_filenames): Update.
5287         * symfile-debug.c (set_debug_symfile): Update.
5288         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5289         Update.
5290         * source.c (select_source_symtab, forget_cached_source_info):
5291         Update.
5292         * solib.c (solib_read_symbols): Update.
5293         * solib-spu.c (append_ocl_sos): Update.
5294         * psymtab.c (maintenance_print_psymbols)
5295         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5296         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5297         * printcmd.c (info_symbol_command): Update.
5298         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5299         Update.
5300         * objfiles.h (class all_objfiles): Remove.
5301         * objfiles.c (have_partial_symbols, have_full_symbols)
5302         (have_minimal_symbols, qsort_cmp, update_section_map)
5303         (shared_objfile_contains_address_p)
5304         (default_iterate_over_objfiles_in_search_order): Update.
5305         * objc-lang.c (info_selectors_command, info_classes_command)
5306         (find_methods): Update.
5307         * minsyms.c (find_solib_trampoline_target): Update.
5308         * maint.c (maintenance_info_sections)
5309         (maintenance_translate_address, count_symtabs_and_blocks):
5310         Update.
5311         * main.c (captured_main_1): Update.
5312         * linux-thread-db.c (try_thread_db_load_from_pdir)
5313         (has_libpthread): Update.
5314         * linespec.c (iterate_over_all_matching_symtabs)
5315         (search_minsyms_for_name): Update.
5316         * jit.c (jit_find_objf_with_entry_addr): Update.
5317         * hppa-tdep.c (find_unwind_entry)
5318         (hppa_lookup_stub_minimal_symbol): Update.
5319         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5320         Update.
5321         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5322         (elf_gnu_ifunc_resolve_by_got): Update.
5323         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5324         * dwarf-index-write.c (save_gdb_index_command): Update.
5325         * cp-support.c (add_symbol_overload_list_qualified): Update.
5326         * breakpoint.c (create_overlay_event_breakpoint)
5327         (create_longjmp_master_breakpoint)
5328         (create_std_terminate_master_breakpoint)
5329         (create_exception_master_breakpoint): Update.
5330         * blockframe.c (find_pc_partial_function): Update.
5331         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5332         (ada_collect_symbol_completion_matches)
5333         (ada_add_global_exceptions): Update.
5334
5335 2019-01-17  Tom Tromey  <tom@tromey.com>
5336
5337         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5338         declare VEC.
5339         (solib_target_parse_libraries): Change return type.
5340         (library_list_start_segment, library_list_start_section)
5341         (library_list_end_library, library_list_start_library); Update.
5342         (solib_target_free_library_list): Remove.
5343         (solib_target_parse_libraries): Remove cleanup.  Change return
5344         type.
5345         (solib_target_current_sos): Update.
5346
5347 2019-01-17  Tom Tromey  <tromey@bapiya>
5348
5349         * valprint.c: Replace "the the" with "the".
5350         * symtab.c: Replace "the the" with "the".
5351         * solib.c: Replace "the the" with "the".
5352         * solib-dsbt.c: Replace "the the" with "the".
5353         * linespec.c: Replace "the the" with "the".
5354         * dwarf2loc.h: Replace "the the" with "the".
5355         * amd64-windows-tdep.c: Replace "the the" with "the".
5356         * aarch64-tdep.c: Replace "the the" with "the".
5357
5358 2019-01-16  Keith Seitz  <keiths@redhat.com>
5359
5360         PR gdb/23773
5361         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5362         <builder>: Rename to ..
5363         <m_builder>: ... this and make private.
5364         (dwarf2_cu::get_builder): New method.  Change all users of
5365         `builder' to use this method.
5366         (dwarf2_start_symtab): Move to ...
5367         (dwarf2_cu::start_symtab): ... here.  Update all callers
5368         (setup_type_unit_groups): Move to ...
5369         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5370         callers.
5371         (dwarf2_cu::reset_builder): New method.
5372         (process_full_compunit, process_full_type_unit): Use
5373         dwarf2_cu::reset_builder.
5374         (follow_die_offset): Record the ancestor CU if it is different
5375         from the followed DIE's CU.
5376         (follow_die_sig_1): Likewise.
5377
5378 2019-01-15  Tom Tromey  <tom@tromey.com>
5379
5380         * remote.c (class remote_state) <buf>: Now a char_vector.
5381         <buf_size>: Remove.
5382         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5383         parameter.
5384         (remote_target::getpkt_or_notif_sane_1)
5385         (remote_target::getpkt_sane)
5386         (remote_target::getpkt_or_notif_sane): Likewise.
5387         (class remote_target) <putpkt>: New overload.
5388         (remote_target::read_frame): Change type of "buf_p".  Remove
5389         sizeof_p parameter.
5390         (packet_ok): New overload.
5391         (packet_check_result): New overload.
5392         Update all uses.
5393
5394 2019-01-14  Tom Tromey  <tom@tromey.com>
5395
5396         * remote-notif.c (handle_notification, remote_notif_ack)
5397         (remote_notif_parse): Make "buf" const.
5398         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5399         const.
5400         (remote_notif_parse, remote_notif_ack, handle_notification):
5401         Likewise.
5402         * remote.c (remote_notif_stop_parse): Make "buf" const.
5403         (remote_target::remote_parse_stop_reply): Make "buf" const.
5404         (remote_notif_stop_ack): Make "buf" const.
5405
5406 2019-01-14  Tom Tromey  <tom@tromey.com>
5407
5408         * remote.c (remote_console_output): Make parameter const.
5409
5410 2019-01-14  Tom Tromey  <tom@tromey.com>
5411
5412         * target-debug.h (target_debug_print_signals): Constify.
5413         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5414         * procfs.c (procfs_target::pass_signals): Update.
5415         * linux-nat.c (linux_nat_target::pass_signals): Update.
5416         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5417         * target-delegates.c: Rebuild.
5418         * remote.c (remote_target::program_signals): Update.
5419         (remote_target::pass_signals): Update.
5420         * target.c (target_pass_signals): Constify argument.
5421         (target_program_signals): Likewise.
5422         * target.h (struct target_ops) <pass_signals, program_signals>:
5423         Constify argument.
5424         (target_pass_signals, target_program_signals): Constify argument.
5425
5426 2019-01-14  Tom Tromey  <tom@tromey.com>
5427
5428         PR tui/28819:
5429         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5430
5431 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5432
5433         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5434         field.
5435         * rs6000-tdep.c: Include reggroups.h.
5436         (IS_V_ALIAS_PSEUDOREG): Define.
5437         (rs6000_register_name): Return names for the "vX" aliases.
5438         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5439         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5440         aliases.  Call default_register_reggroup_p for all other
5441         pseudo-registers.
5442         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5443         New functions.
5444         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5445         Handle "vX" aliases.
5446         (v_alias_pseudo_register_collect): New function.
5447         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5448         (rs6000_gdbarch_init): Initialize "vX" aliases as
5449         pseudo-registers.  Restore registration of
5450         rs6000_pseudo_register_reggroup_p with
5451         set_tdesc_pseudo_register_reggroup_p.
5452
5453 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5454
5455         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5456         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5457         set_gdbarch_num_pseudo_regs.
5458
5459 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5460
5461         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5462         Remove arg prefixname, add do_set and do_show.
5463         Add member functions set_list and show_list.
5464         * cli/cli-style.c (class cli_style_option): Update accordingly.
5465         (style_set_list): Move to file scope.
5466         (style_show_list): Likewise.
5467         (set_style): Call help_list.
5468         (show_style): Call cmd_show_list.
5469         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5470         Update to use the new macro.
5471
5472 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5473
5474         * ada-lang.c (_initialize_ada_language): Expand the help text
5475         for the "catch exception" command.
5476
5477 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5478
5479         * symtab.c (matching_obj_sections): Initialize obj,
5480         declare it closer to its usage.
5481
5482 2019-01-10  Tom Tromey  <tom@tromey.com>
5483
5484         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5485         (basic_inf_threads_range): Remove.
5486         (inf_threads_range, inf_non_exited_threads_range)
5487         (safe_inf_threads_range): Use next_adapter.
5488
5489 2019-01-10  Keith Seitz  <keiths@redhat.com>
5490
5491         PR gdb/23712
5492         PR symtab/23010
5493         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5494         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5495
5496 2019-01-10  Keith Seitz  <keiths@redhat.com>
5497
5498         PR gdb/23712
5499         PR symtab/23010
5500         * dictionary.c (pending_to_vector): Remove.
5501         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5502         Remove _1 suffix, replacing functions of the same name.  Update
5503         all callers.
5504         (dict_create_hashed, dict_create_hashed_expandable)
5505         (dict_create_linear, dict_create_linear_expandable, dict_free)
5506         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5507         Make functions static.
5508
5509 2019-01-10  Keith Seitz  <keiths@redhat.com>
5510
5511         PR gdb/23712
5512         PR symtab/23010
5513         * dictionary.h (struct dictionary): Replace declaration with
5514         multidictionary.
5515         (dict_create_hashed, dict_create_hashed_expandable)
5516         (dict_create_linear, dict_create_linear_expandable)
5517         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5518         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5519         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5520         taking multidictionary argument.
5521         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5522         * block.h (struct block) <dict>: Change to multidictionary
5523         and rename `multidict'.
5524         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5525         symmisc.c: Update all dictionary references to multidictionary.
5526
5527 2019-01-10  Keith Seitz  <keiths@redhat.com>
5528
5529         PR gdb/23712
5530         PR symtab/23010
5531         * dictionary.c: Include unordered_map.
5532         (pending_to_vector): New function.
5533         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5534         Rewrite the non-"_1" functions to take vector instead
5535         of linked list.
5536         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5537         "new" _1 versions of the same name.
5538         (multidictionary): Define.
5539         (std::hash<enum language): New definition.
5540         (collate_pending_symbols_by_language, mdict_create_hashed)
5541         (mdict_create_hashed_expandable, mdict_create_linear)
5542         (mdict_create_linear_expandable, mdict_free)
5543         (find_language_dictionary, create_new_language_dictionary)
5544         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5545         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5546         (mdict_size, mdict_empty): New functions.
5547         * dictionary.h (mdict_iterator): Define.
5548
5549 2019-01-10  Pedro Alves  <palves@redhat.com>
5550
5551         * breakpoint.c (read_uploaded_action)
5552         (create_tracepoint_from_upload): Adjust to use
5553         gdb::unique_xmalloc_ptr.
5554         * ctf.c (ctf_write_uploaded_tp):
5555         (SET_ARRAY_FIELD): Use emplace_back.
5556         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5557         * tracefile-tfile.c (tfile_write_uploaded_tp):
5558         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5559         gdb::unique_xmalloc_ptr.
5560         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5561         at_string, cond_string, cmd_strings>: Replace char pointers
5562         with gdb::unique_xmalloc_ptr.
5563
5564 2019-01-10  Pedro Alves  <palves@redhat.com>
5565
5566         * solib-target.c (library_list_start_library): Don't xstrdup name.
5567
5568 2019-01-10  Pedro Alves  <palves@redhat.com>
5569
5570         * mdebugread.c (parse_partial_symbols): Use
5571         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5572
5573 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5574
5575         * linux-fork.c (scoped_switch_fork_info)
5576         <~scoped_switch_fork_info>: Fix incorrect variable name.
5577
5578 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5579
5580         * linux-fork.c (scoped_switch_fork_info)
5581         <scoped_switch_fork_info>: Make explicit.
5582         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5583
5584 2019-01-10  Tom Tromey  <tom@tromey.com>
5585
5586         * objfiles.h (objfile::reset_psymtabs): Update.
5587         * objfiles.c (objfile::objfile): Update.
5588         * psymtab.h (psymtab_storage::obstack): Update.
5589         (psymtab_storage::m_obstack): Use gdb::optional.
5590         (class psymtab_storage): Update comment.  Remove objfile
5591         parameter.
5592         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5593
5594 2019-01-10  Tom Tromey  <tom@tromey.com>
5595
5596         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5597         <free_psymtabs>: Now private.
5598         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5599         (allocate_psymtab): Use new method.
5600
5601 2019-01-10  Tom Tromey  <tom@tromey.com>
5602
5603         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5604         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5605         * mdebugread.c (parse_partial_symbols): Use
5606         allocate_dependencies.
5607         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5608         allocate_dependencies.
5609         (process_psymtab_comp_unit_reader)
5610         (build_type_psymtab_dependencies): Likewise.
5611         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5612
5613 2019-01-10  Tom Tromey  <tom@tromey.com>
5614
5615         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5616         PSYMBOL_SET_LANGUAGE.
5617         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5618
5619 2019-01-10  Tom Tromey  <tom@tromey.com>
5620
5621         * psymtab.h (psymtab_storage::obstack): New method.
5622         <m_obstack>: Rename from obstack; now private.
5623         * psymtab.c (psymtab_storage): Update.
5624         * dwarf2read.c (create_addrmap_from_index)
5625         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5626         Update.
5627
5628 2019-01-10  Tom Tromey  <tom@tromey.com>
5629
5630         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5631         * objfiles.h (objfile::reset_psymtabs): New method.
5632
5633 2019-01-10  Tom Tromey  <tom@tromey.com>
5634
5635         * symmisc.c (print_symbol_bcache_statistics): Update.
5636         (print_objfile_statistics): Update.
5637         * symfile.c (reread_symbols): Update.
5638         * psymtab.h (class psymtab_storage): New.
5639         * psymtab.c (psymtab_storage): New constructor.
5640         (~psymtab_storage): New destructor.
5641         (require_partial_symbols): Update.
5642         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5643         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5644         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5645         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5646         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5647         (start_psymtab_common, end_psymtab_common)
5648         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5649         (allocate_psymtab): Update.
5650         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5651         Update.
5652         (dump_psymtab_addrmap, maintenance_print_psymbols)
5653         (maintenance_check_psymtabs): Update.
5654         (class objfile_psymtabs): Move to objfiles.h.
5655         * psympriv.h (discard_psymtab): Now inline.
5656         (psymtab_discarder::psymtab_discarder): Update.
5657         (psymtab_discarder::~psymtab_discarder): Update.
5658         (ALL_OBJFILE_PSYMTABS): Rewrite.
5659         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5660         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5661         Remove fields.
5662         <partial_symtabs>: New field.
5663         (class objfile_psymtabs): Move from psymtab.h.  Update.
5664         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5665         psymbol_cache.
5666         (objfile::~objfile): Don't destroy psymbol_cache.
5667         * mdebugread.c (parse_partial_symbols): Update.
5668         * dwarf2read.c (create_addrmap_from_index)
5669         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5670         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5671         (add_partial_subprogram, dwarf2_ranges_read): Update.
5672         * dwarf-index-write.c (write_address_map)
5673         (write_one_signatured_type, recursively_write_psymbols)
5674         (class debug_names, class debug_names, write_psymtabs_to_index):
5675         Update.
5676
5677 2019-01-10  Tom Tromey  <tom@tromey.com>
5678
5679         * symtab.h (SYMBOL_SET_NAMES): Update.
5680         (symbol_set_names): Update.
5681         (MSYMBOL_SET_NAMES): Update.
5682         * symtab.c (symbol_set_names): Change argument to be an
5683         objfile_per_bfd_storage.
5684         * psymtab.c (add_psymbol_to_bcache): Update.
5685         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5686
5687 2019-01-10  Tom Tromey  <tom@tromey.com>
5688
5689         * symtab.c (create_demangled_names_hash): Change argument to be an
5690         objfile_per_bfd_storage.
5691         (symbol_set_names): Update.
5692
5693 2019-01-10  Tom Tromey  <tom@tromey.com>
5694
5695         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5696         init_psymbol_list.
5697         * psymtab.c (init_psymbol_list): Do nothing if already called.
5698         * psympriv.h (init_psymbol_list): Add comment.
5699         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5700         init_psymbol_list.
5701         * dbxread.c (dbx_symfile_read): Unconditionally call
5702         init_psymbol_list.
5703
5704 2019-01-10  Tom Tromey  <tom@tromey.com>
5705
5706         * xcoffread.c (scan_xcoff_symtab): Update.
5707         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5708         "where".
5709         * mdebugread.c (parse_partial_symbols)
5710         (handle_psymbol_enumerators): Update.
5711         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5712         * dbxread.c (read_dbx_symtab): Update.
5713         * psympriv.h (psymbol_placement): New enum.
5714         (add_psymbol_to_list): Update.
5715
5716 2019-01-10  Tom Tromey  <tom@tromey.com>
5717
5718         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5719         static_psymbols parameters.
5720         (scan_xcoff_symtab): Update.
5721         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5722         static_psymbols parameters.
5723         * psympriv.h (start_psymtab_common): Update.
5724         * mdebugread.c (parse_partial_symbols): Update.
5725         * dwarf2read.c (create_partial_symtab): Update.
5726         * dbxread.c (read_dbx_symtab): Update.
5727         (start_psymtab): Remove global_psymbols and static_psymbols
5728         parameters.
5729
5730 2019-01-10  Tom Tromey  <tom@tromey.com>
5731
5732         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5733         * psymtab.c (allocate_psymtab): Add comment.
5734         * psympriv.h (allocate_psymtab): Add comment.
5735         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5736         initializations.
5737         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5738
5739 2019-01-10  Tom Tromey  <tom@tromey.com>
5740
5741         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5742         Don't declare.
5743         * mipsread.c: Include mdebugread.h.
5744         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5745         Declare.
5746         * elfread.c: Include mdebugread.h.
5747
5748 2019-01-09  Tom Tromey  <tom@tromey.com>
5749
5750         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5751         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5752         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5753         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5754         (psym_lookup_symbol, psym_find_last_source_symtab)
5755         (psym_forget_cached_source_info, psym_print_stats)
5756         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5757         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5758         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5759         (psym_find_compunit_symtab_by_address)
5760         (maintenance_print_psymbols, maintenance_info_psymtabs)
5761         (maintenance_check_psymtabs): Use ranged for.
5762         * psymtab.h (class objfile_psymtabs): New.
5763         (require_partial_symbols): Return objfile_psymtabs.
5764         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5765
5766 2019-01-09  Tom Tromey  <tom@tromey.com>
5767
5768         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5769         (find_pc_mapped_section, list_overlays_command)
5770         (map_overlay_command, unmap_overlay_command)
5771         (simple_overlay_update): Use all_objfiles.
5772         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5773         * printcmd.c (info_symbol_command): Use all_objfiles.
5774         * objfiles.h (ALL_OBJSECTIONS): Remove.
5775         * maint.c (maintenance_translate_address): Use all_objfiles.
5776         * gcore.c (gcore_create_callback): Use all_objfiles.
5777         (objfile_find_memory_regions): Likewise.
5778
5779 2019-01-09  Tom Tromey  <tom@tromey.com>
5780
5781         * symtab.c (find_line_symtab, info_sources_command)
5782         (make_source_files_completion_list): Use objfile_compunits.
5783         * source.c (select_source_symtab): Use objfile_compunits.
5784         * objfiles.h (struct objfile): Update comment.
5785         (ALL_OBJFILES): Remove.
5786         (ALL_FILETABS): Remove.
5787         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5788         objfile_compunits.
5789
5790 2019-01-09  Tom Tromey  <tom@tromey.com>
5791
5792         * symmisc.c (print_objfile_statistics, dump_objfile)
5793         (maintenance_print_symbols): Use compunit_filetabs.
5794         * source.c (forget_cached_source_info_for_objfile): Use
5795         compunit_filetabs.
5796         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5797         (ALL_FILETABS): Use compunit_filetabs.
5798         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5799         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5800
5801 2019-01-09  Tom Tromey  <tom@tromey.com>
5802
5803         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5804         (compunit_filetabs): New.
5805         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5806         compunit_filetabs.
5807         (info_sources_command, make_source_files_completion_list): Remove
5808         declaration.
5809         * symmisc.c (print_objfile_statistics, dump_objfile)
5810         (maintenance_print_symbols): Remove declaration.
5811         (maintenance_info_symtabs): Use compunit_filetabs.
5812         (maintenance_info_line_tables): Likewise.
5813         * source.c (select_source_symtab): Change local variable name.
5814         (forget_cached_source_info_for_objfile): Remove declaration.
5815         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5816         * objfiles.c (objfile_relocate1): Remove declaration.
5817         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5818         declaration.
5819         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5820         * coffread.c (coff_symtab_read): Remove declaration.
5821         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5822         compunit_filetabs.
5823
5824 2019-01-09  Tom Tromey  <tom@tromey.com>
5825
5826         * symtab.c (lookup_objfile_from_block)
5827         (find_pc_sect_compunit_symtab, search_symbols)
5828         (default_collect_symbol_completion_matches_break_on): Use
5829         objfile_compunits.
5830         * objfiles.h (ALL_COMPUNITS): Remove.
5831         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5832         * cp-support.c (add_symbol_overload_list_qualified): Use
5833         objfile_compunits.
5834         * ada-lang.c (ada_collect_symbol_completion_matches)
5835         (ada_add_global_exceptions): Use objfile_compunits.
5836
5837 2019-01-09  Tom Tromey  <tom@tromey.com>
5838
5839         * source.c (select_source_symtab)
5840         (forget_cached_source_info_for_objfile): Remove declaration.
5841         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5842         declaration.
5843         * maint.c (count_symtabs_and_blocks): Remove declaration.
5844         * cp-support.c (add_symbol_overload_list_qualified): Remove
5845         declaration.
5846         * coffread.c (coff_symtab_read): Remove declaration.
5847         * symtab.c (lookup_symbol_in_objfile_symtabs)
5848         (basic_lookup_transparent_type_1): Use objfile_compunits.
5849         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5850         (info_sources_command, search_symbols)
5851         (default_collect_symbol_completion_matches_break_on)
5852         (make_source_files_completion_list): Remove declaration.
5853         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5854         (ada_collect_symbol_completion_matches)
5855         (ada_add_global_exceptions): Remove declaration.
5856         * linespec.c (iterate_over_all_matching_symtabs): Use
5857         objfile_compunits.
5858         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5859         (class objfile_compunits): New.
5860         (ALL_COMPUNITS): Use objfile_compunits.
5861         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5862         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5863         objfile_compunits.
5864         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5865
5866 2019-01-09  Tom Tromey  <tom@tromey.com>
5867
5868         * symtab.c (search_symbols)
5869         (default_collect_symbol_completion_matches_break_on): Use
5870         objfile_msymbols.
5871         * ada-lang.c (ada_lookup_simple_minsym)
5872         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5873         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5874         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5875         objfile_msymbols.
5876         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5877         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5878         * objc-lang.c (find_methods): Use objfile_msymbols.
5879         (info_selectors_command, info_classes_command): Likewise.
5880         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5881         * objfiles.h (class objfile_msymbols): New.
5882         (ALL_OBJFILE_MSYMBOLS): Remove.
5883         (ALL_MSYMBOLS): Remove.
5884
5885 2019-01-09  Tom Tromey  <tom@tromey.com>
5886
5887         * common/next-iterator.h (next_adapter): Add Iterator template
5888         parameter.
5889         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5890         (class all_objfiles_safe): New.
5891         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5892         * objfiles.c (put_objfile_before): Update comment.
5893         (add_separate_debug_objfile): Likewise.
5894         (free_all_objfiles): Use all_objfiles_safe.
5895         (objfile_purge_solibs): Likewise.
5896
5897 2019-01-09  Tom Tromey  <tom@tromey.com>
5898
5899         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5900         (expand_symtab_containing_pc, lookup_static_symbol)
5901         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5902         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5903         all_objfiles.
5904         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5905         * breakpoint.c (create_overlay_event_breakpoint)
5906         (create_longjmp_master_breakpoint)
5907         (create_std_terminate_master_breakpoint)
5908         (create_exception_master_breakpoint): Use all_objfiles.
5909         * linux-thread-db.c (try_thread_db_load_from_pdir)
5910         (has_libpthread): Use all_objfiles.
5911         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5912         * linespec.c (iterate_over_all_matching_symtabs)
5913         (search_minsyms_for_name): Use all_objfiles.
5914         * maint.c (maintenance_info_sections): Use all_objfiles.
5915         * main.c (captured_main_1): Use all_objfiles.
5916         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5917         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5918         * guile/scm-pretty-print.c
5919         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5920         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5921         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5922         (maintenance_print_msymbols): Use all_objfiles.
5923         * source.c (select_source_symtab): Use all_objfiles.
5924         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5925         * symfile.c (remove_symbol_file_command)
5926         (expand_symtabs_matching, map_symbol_filenames): Use
5927         all_objfiles.
5928         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5929         all_objfiles.
5930         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5931         * objc-lang.c (find_methods): Use all_objfiles.
5932         * objfiles.c (have_partial_symbols, have_full_symbols)
5933         (have_minimal_symbols, qsort_cmp)
5934         (default_iterate_over_objfiles_in_search_order): Use
5935         all_objfiles.
5936         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5937         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5938         (maintenance_check_psymtabs): Use all_objfiles.
5939         (ALL_PSYMTABS): Remove.
5940         * compile/compile-object-run.c (do_module_cleanup): Use
5941         all_objfiles.
5942         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5943         * cp-support.c (add_symbol_overload_list_qualified): Use
5944         all_objfiles.
5945         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5946         Use all_objfiles.
5947         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5948         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5949         all_objfiles.
5950         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5951         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5952         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5953         Uses all_objfiles.
5954         * solib.c (solib_read_symbols): Use all_objfiles
5955
5956 2019-01-09  Tom Tromey  <tom@tromey.com>
5957
5958         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5959         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5960         all_objfiles.
5961         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5962         * symmisc.c (print_symbol_bcache_statistics)
5963         (print_objfile_statistics, maintenance_print_objfiles)
5964         (maintenance_info_symtabs, maintenance_check_symtabs)
5965         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5966         all_objfiles.
5967         * source.c (forget_cached_source_info): Use all_objfiles.
5968         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5969         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5970         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5971         * objfiles.c (update_section_map): Use all_objfiles.
5972         (shared_objfile_contains_address_p): Likewise.
5973         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5974         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5975
5976 2019-01-09  Tom Tromey  <tom@tromey.com>
5977
5978         * common/next-iterator.h: New file.
5979         * objfiles.h (class all_objfiles): New.
5980         (struct objfile_iterator): New.
5981
5982 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5983
5984         * NEWS: Move the description of the changed "frame", "select-frame",
5985          and "info frame" commands to the Changed commands section.
5986
5987 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5988
5989         * gdbtypes.c (check_stub_method_group): Remove handling of old
5990         mangling schemes.
5991         * linespec.c (find_methods): Likewise.
5992         * stabsread.c (read_member_functions): Likewise.
5993         * valops.c (search_struct_method): Likewise.
5994         (value_struct_elt_for_reference): Likewise.
5995         * NEWS: Mention this change.
5996
5997 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5998
5999         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6000         print_source_lines.
6001         * source.c (print_source_lines_base): Update line number check.
6002         (print_source_lines): New function.
6003         (source_lines_range::source_lines_range): New function.
6004         * source.h (class source_lines_range): New class.
6005         (print_source_lines): New declaration.
6006
6007 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6008
6009         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6010
6011 2019-01-08  Tom Tromey  <tom@tromey.com>
6012             Simon Marchi  <simon.marchi@ericsson.com>
6013
6014         PR gdb/24060
6015         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6016         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6017         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6018         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6019         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6020         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6021
6022 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6023
6024         * source.c (select_source_symtab): Move header comment to
6025         declaration in source.h.
6026         (forget_cached_source_info_for_objfile): Likewise.
6027         (forget_cached_source_info): Likewise.
6028         (identify_source_line): Likewise.
6029         * source.h (identify_source_line): Move declaration from symtab.h
6030         and add comment from source.c
6031         (print_source_lines): Likewise.
6032         (forget_cached_source_info_for_objfile): Likewise.
6033         (forget_cached_source_info): Likewise.
6034         (select_source_symtab): Likewise.
6035         (enum print_source_lines_flag): Move definition from symtab.h.
6036         * symtab.h (identify_source_line): Move declaration to source.h.
6037         (print_source_lines): Likewise.
6038         (forget_cached_source_info_for_objfile): Likewise.
6039         (forget_cached_source_info): Likewise.
6040         (select_source_symtab): Likewise.
6041         (enum print_source_lines_flag): Move definition to source.h.
6042         * tui/tui-hooks.c: Add 'source.h' include.
6043
6044 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6045
6046         * source.c (print_source_lines_base): Handle requests to print
6047         reverse line number sequences, and guard against empty lines
6048         string.
6049
6050 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6051
6052         * source.c (print_source_lines_base): Fix skip of '\r' if next
6053         character is '\n'.
6054
6055 2019-01-06  Tom Tromey  <tom@tromey.com>
6056
6057         * c-exp.y (struct c_parse_state) <macro_original_text,
6058         expansion_obstack>: New member.
6059         (macro_original_text, expansion_obstack): Remove globals.
6060         (scan_macro_expansion, scanning_macro_expansion)
6061         (finished_macro_expansion): Update.
6062         (scan_macro_cleanup): Remove.
6063         (yylex, c_parse): Update.
6064
6065 2019-01-06  Tom Tromey  <tom@tromey.com>
6066
6067         * c-exp.y (struct c_parse_state) <strings>: New member.
6068         (operator_stoken): Update.
6069
6070 2019-01-06  Tom Tromey  <tom@tromey.com>
6071
6072         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6073         (union type_stack_elt) <typelist_val>: Now a pointer to
6074         std::vector.
6075         (type_stack_cleanup): Don't declare.
6076         (push_typelist): Update.
6077         * parse.c (pop_typelist): Return a std::vector.
6078         (push_typelist): Take a std::vector.
6079         (follow_types): Update.  Do not free args.
6080         (type_stack_cleanup): Remove.
6081         * c-exp.y (struct c_parse_state): New.
6082         (cpstate): New global.
6083         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6084         (nonempty_typelist): Update.
6085         (func_mod): Create a new vector.
6086         (c_parse): Create a c_parse_state.
6087         (check_parameter_typelist): Do not delete params.
6088         (function_method): Update.  Do not delete type_list.
6089
6090 2019-01-06  Tom Tromey  <tom@tromey.com>
6091
6092         PR gdb/28155:
6093         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6094         check_typedef.
6095         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6096         (print_return_value): Likewise.
6097
6098 2019-01-05  Tom Tromey  <tom@tromey.com>
6099
6100         * contrib/cleanup_check.py: Remove.
6101         * contrib/gcc-with-excheck: Remove.
6102         * contrib/exsummary.py: Remove.
6103         * contrib/excheck.py: Remove.
6104
6105 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6106
6107         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6108         NULL. Initialize tpprev to NULL instead of assigning it
6109         to NULL on the next statement.
6110         * windows-nat.c (windows_delete_thread): Remove check for
6111         main_thread_id before printing thread exit notifications.
6112         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6113         Remove thread ID check against main_thread_id.
6114         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6115         windows_delete_thread.
6116         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6117
6118 2019-01-04  Tom Tromey  <tom@tromey.com>
6119
6120         * compile/compile.c (_initialize_compile): Use upper case for
6121         metasyntactic variables.
6122         * symmisc.c (_initialize_symmisc): Use upper case for
6123         metasyntactic variables.
6124         * psymtab.c (_initialize_psymtab): Use upper case for
6125         metasyntactic variables.
6126         * demangle.c (demangle_command): Use upper case for metasyntactic
6127         variables.
6128         (_initialize_demangler): Likewise.
6129         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6130         variables.
6131
6132 2019-01-03  Tom Tromey  <tom@tromey.com>
6133
6134         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6135
6136 2019-01-03  Tom Tromey  <tom@tromey.com>
6137
6138         * python/py-symtab.c (salpy_str): Update.
6139         (struct salpy_sal_object) <symtab>: Now a PyObject.
6140         (salpy_dealloc): Update.
6141         (del_objfile_sal): Use gdbpy_ref.
6142
6143 2019-01-03  Tom Tromey  <tom@tromey.com>
6144
6145         * python/py-type.c (convert_field): Use new_reference.  Return
6146         gdbpy_ref.
6147         (make_fielditem): Return gdbpy_ref.
6148         (typy_fields): Update.
6149         (typy_getitem): Update.
6150         (field_name): Return gdbpy_ref.  Use new_reference.
6151         (typy_iterator_iternext): Update.
6152
6153 2019-01-03  Tom Tromey  <tom@tromey.com>
6154
6155         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6156
6157 2019-01-03  Tom Tromey  <tom@tromey.com>
6158
6159         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6160         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6161         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6162         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6163         (pspy_set_type_printers): Likewise.
6164         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6165         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6166         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6167         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6168         (objfpy_set_type_printers): Likewise.
6169
6170 2019-01-03  Tom Tromey  <tom@tromey.com>
6171
6172         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6173         (gdbpy_print_stack): Use gdbpy_err_fetch.
6174         * python/python-internal.h (class gdbpy_err_fetch): New class.
6175         (class gdbpy_enter) <m_error_type, m_error_value,
6176         m_error_traceback>: Remove.
6177         <m_error>: New member.
6178         (gdbpy_exception_to_string): Don't declare.
6179         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6180         * python/py-value.c (convert_value_from_python): Use
6181         gdbpy_err_fetch.
6182         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6183         gdbpy_exception_to_string.
6184         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6185         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6186         gdbpy_err_fetch.
6187
6188 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6189
6190         * linux-nat.c (delete_lwp_cleanup): Delete.
6191         (struct lwp_deleter): New struct.
6192         (lwp_info_up): New typedef.
6193         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6194         lwp_info_up.
6195
6196 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6197
6198         * linux-fork.c (class scoped_switch_fork_info): New class.
6199         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6200
6201 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6202
6203         * valops.c (find_overload_match): Remove use of null_cleanup, and
6204         calls to do_cleanups.
6205
6206 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6207
6208         * compile/compile-cplus-types.c
6209         (compile_cplus_instance::decl_name): Handle changes to
6210         cp_func_name.
6211         * cp-support.c (cp_func_name): Update header comment, update
6212         return type.
6213         * cp-support.h (cp_func_name): Update return type in declaration.
6214         * valops.c (find_overload_match): Move temp_func local to top
6215         level of function and change its type.  Use temp_func to hold and
6216         delete temporary string obtained from cp_func_name.
6217
6218 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6219
6220         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6221         gdb::char_vector, remove cleanup, and update uses of `msg`.
6222
6223 2019-01-03  Jim Wilson  <jimw@sifive.com>
6224
6225         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6226
6227 2019-01-02  Tom Tromey  <tom@tromey.com>
6228
6229         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6230         (tdesc_parse_xml): Remove cleanups.
6231         * target-descriptions.h (make_cleanup_free_target_description):
6232         Don't declare.
6233         (target_desc_deleter): New struct.
6234         (target_desc_up): New typedef.
6235         * target-descriptions.c (target_desc_deleter::operator()): Rename
6236         from free_target_description.
6237         (make_cleanup_free_target_description): Remove.
6238
6239 2019-01-02  Tom Tromey  <tom@tromey.com>
6240
6241         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6242         constructor, destructor.
6243         (linespec_parser): Remove typedef.
6244         (~linespec_parser): Rename from linespec_parser_delete.
6245         (linespec_lex_to_end, linespec_complete_label)
6246         (linespec_complete): Update.
6247         (decode_line_full): Remove cleanups.
6248         (decode_line_1): Update.
6249
6250 2019-01-02  Tom Tromey  <tom@tromey.com>
6251
6252         * python/python-internal.h (inferior_to_inferior_object): Change
6253         return type.
6254         * python/py-exitedevent.c (create_exited_event_object): Update.
6255         * python/py-inferior.c (inferior_to_inferior_object): Return
6256         gdbpy_ref.
6257         (python_new_inferior, python_inferior_deleted)
6258         (thread_to_thread_object, delete_thread_object)
6259         (build_inferior_list, gdbpy_selected_inferior): Update.
6260         * python/py-infthread.c (create_thread_object): Update.  Also fail
6261         if inferior_to_inferior_object fails.
6262
6263 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6264
6265         * inferior.h (class inferior) <displaced_step_state>: New field.
6266         * infrun.h (struct displaced_step_state): Move here from
6267         infrun.c.  Initialize fields, add constructor.
6268         <inf>: Remove field.
6269         <reset>: New method.
6270         * infrun.c (struct displaced_step_inferior_state): Move to
6271         infrun.h.
6272         (displaced_step_inferior_states): Remove.
6273         (get_displaced_stepping_state): Adust.
6274         (displaced_step_in_progress_any_inferior): Adjust.
6275         (displaced_step_in_progress_thread): Adjust.
6276         (displaced_step_in_progress): Adjust.
6277         (add_displaced_stepping_state): Remove.
6278         (get_displaced_step_closure_by_addr): Adjust.
6279         (remove_displaced_stepping_state): Remove.
6280         (infrun_inferior_exit): Call displaced_step_state.reset.
6281         (use_displaced_stepping): Don't check for NULL.
6282         (displaced_step_prepare_throw): Call
6283         get_displaced_stepping_state.
6284         (displaced_step_fixup): Don't check for NULL.
6285         (prepare_for_detach): Don't check for NULL.
6286
6287 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6288
6289         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6290          in case of call that did not complete.
6291
6292 2019-01-02  Andrey Utkin  <autkin@undo.io>
6293
6294         * symfile.c (find_separate_debug_file): Fix search of debug files for
6295         remote debuggee.
6296
6297 2019-01-02  Tom Tromey  <tom@tromey.com>
6298
6299         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6300         indentation.
6301         * python/py-frame.c (frapy_older): Remove cast.
6302         (frapy_newer): Likewise.
6303         * python/py-breakpoint.c (local_setattro): Remove cast.
6304         * python/py-arch.c (archpy_name): Remove local variable.
6305         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6306
6307 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6308
6309         * unittests/basic_string_view/element_access/char/empty.cc:
6310         Fix year range in copyright header.
6311
6312 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6313
6314         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6315         Delete.
6316         <operator==>: Update with for removed field.
6317         <hash>: Likewise.
6318         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6319         <isa_features>: ...this.
6320         <abi_features>: New field.
6321         (riscv_isa_flen): Update comment.
6322         (riscv_abi_xlen): New declaration.
6323         (riscv_abi_flen): New declaration.
6324         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6325         isa_features.
6326         (riscv_abi_xlen): New function.
6327         (riscv_isa_flen): Update to get answer from isa_features.
6328         (riscv_abi_flen): New function.
6329         (riscv_has_fp_abi): Update to get answer from abi_features.
6330         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6331         xlen and flen.
6332         (riscv_call_info) <xlen, flen>: Update comment.
6333         (riscv_call_arg_struct): Remove invalid assertions
6334         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6335         is removed.
6336         (riscv_gdbarch_init): Gather isa features and abi features
6337         separately, ensure both match on the gdbarch when reusing an old
6338         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6339         a target with 64-bit float hardware.
6340
6341 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6342
6343         * source.c (search_command_helper): Stop reverse search
6344         when line 1 has been searched.
6345
6346 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6347
6348         * record-full.c (record_full_base_target::close): Rewrite
6349         record_full_core_buf_list free logic.
6350
6351 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6352
6353         * break-catch-syscall.c (print_one_catch_syscall): xfree
6354         the last text.
6355
6356 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6357
6358         * top.c (print_gdb_version): Update Copyright year in version
6359         message.
6360
6361 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6362
6363         Update copyright year range in all GDB files.
6364
6365 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6366
6367         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6368
6369 For older changes see ChangeLog-2018.
6370 \f
6371 Local Variables:
6372 mode: change-log
6373 left-margin: 8
6374 fill-column: 74
6375 version-control: never
6376 coding: utf-8
6377 End:
6378