gdb/ChangeLog

   1 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
   2
   3         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
   4         instead of find_function_entry_range_from_pc.
   5
   6 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
   7
   8         * stack.c (find_frame_funname): Remove code which preferred
   9         minsym over symtab sym in "certain pathological cases".
  10
  11         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
  12         parameter.  Change type of "do_demangle" to bool.
  13         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
  14         Pass suitable "prefer_sym_over_minsym" flag to
  15         build_address_symbolic().  Don't output "+" for negative offsets.
  16         * printcmd.c (print_address_symbolic): Update invocation of
  17         build_address_symbolic to include a "prefer_sym_over_minsym"
  18         flag.
  19         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
  20         Restrict cases in which use of minimal symbol is preferred to that
  21         of a found symbol.  Update comments.
  22
  23         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
  24         for entry pc when entry pc is out of range for that FDE.
  25
  26         * printcmd.c (print_address_symbolic): Print negative offsets.
  27         (build_address_symbolic): Force signed arithmetic when computing
  28         offset.
  29
  30 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
  31
  32         PR gdb/24839:
  33         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
  34         type.
  35
  36 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
  37
  38         * python/py-objfile.c (add_separate_debug_file): Fix comment about
  39         this function's Python signature.
  40
  41
  42 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
  43
  44         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
  45         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
  46         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
  47         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
  48         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
  49
  50
  51 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
  52
  53         * h8300-tdep.c (h8300_register_name_common): New.
  54         h8300_register_name): Use h8300_register_name_common.
  55         (h8300s_register_name): Likewise.
  56         (h8300sx_register_name): Likewise.
  57         (h8300h_register_nam): New.
  58         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
  59
  60
  61 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
  62
  63         * arm-tdep.c (arm_skip_cmse_entry): New function.
  64         (arm_is_sgstubs_section): New function.
  65         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
  66
  67 2019-07-22  Tom Tromey  <tom@tromey.com>
  68
  69         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
  70         Don't self-assign.
  71
  72 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  73
  74         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
  75         type_print.
  76
  77 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  78
  79         * symtab.c (search_symbols): Adjust msymbol matching type arrays
  80         so that GDB doesn't match any msymbols when searching in the
  81         TYPES_DOMAIN.
  82         (print_symbol_info): Print using typedef_print or type_print based
  83         on the type of the symbol.  Add updated FIXME comment moved from...
  84         (_initialize_symtab): ... move and update FIXME comment to above.
  85
  86 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  87
  88         * NEWS: Mention adding -q option to "info types".
  89         * symtab.c (struct info_types_options): New struct.
  90         (info_types_options_defs): New variable.
  91         (make_info_types_options_def_group): New function.
  92         (info_types_command): Use gdb::option framework to parse options.
  93         (info_types_command_completer): New function.
  94         (_initialize_symtab): Extend the help text on "info types" and
  95         register command completer.
  96
  97 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
  98
  99         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 100         (lookup_symbol_in_objfile): Change int to block_enum and add a
 101         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 102
 103 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 104
 105         * MAINTAINERS (Write After Approval): Add self.
 106
 107 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 108
 109         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 110         instruction to the dummy code region.
 111
 112 2019-07-19  Tom Tromey  <tromey@adacore.com>
 113
 114         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 115         (ARGSUSED, PARAMS, __func__): Remove rules.
 116
 117 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 118
 119         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 120         * features/arm/arm-with-iwmmxt.c: Remove.
 121         * features/arm/arm-with-iwmmxt.xml: Remove.
 122         * features/arm/arm-with-m-fpa-layout.c: Remove.
 123         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 124         * features/arm/arm-with-m-vfp-d16.c: Remove.
 125         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 126         * features/arm/arm-with-m.c: Remove.
 127         * features/arm/arm-with-m.xml: Remove.
 128         * features/arm/arm-with-neon.c: Remove.
 129         * features/arm/arm-with-neon.xml: Remove.
 130         * features/arm/arm-with-vfpv2.c: Remove.
 131         * features/arm/arm-with-vfpv2.xml: Remove.
 132         * features/arm/arm-with-vfpv3.c: Remove.
 133         * features/arm/arm-with-vfpv3.xml: Remove.
 134
 135 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 136
 137         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 138
 139 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 140
 141         * arch/aarch32.c (aarch32_create_target_description): Create
 142         target descriptions using features.
 143         * arch/arm.c (arm_create_target_description)
 144         (arm_create_mprofile_target_description): Likewise.
 145         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 146
 147 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 148
 149         * Makefile.in: Add new files.
 150         * aarch32-tdep.c: New file.
 151         * aarch32-tdep.h: New file.
 152         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 153         Call aarch32_read_description.
 154         * arch/aarch32.c: New file.
 155         * arch/aarch32.h: New file.
 156         * arch/arm.c (arm_create_target_description)
 157         (arm_create_mprofile_target_description): New function.
 158         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 159         (arm_create_target_description)
 160         (arm_create_mprofile_target_description): New declaration.
 161         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 162         read_description functions.
 163         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 164         Likewise.
 165         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 166         * arm-tdep.c (tdesc_arm_list): New variable.
 167         (arm_register_g_packet_guesses): Call create description functions.
 168         (arm_read_description) (arm_read_mprofile_description): New
 169         function.
 170         * arm-tdep.h (arm_read_description)
 171         (arm_read_mprofile_description): Add declaration.
 172         * configure.tgt: Add new files.
 173
 174 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 175
 176         * top.c (new_ui_command): Open specified terminal just once.
 177
 178 2019-07-18  Tom Tromey  <tromey@adacore.com>
 179
 180         * symtab.c (main_name): Constify return type.
 181         * symfile.c (set_initial_language): Update.
 182         * symtab.h (main_name): Constify return type.
 183
 184 2019-07-17  Tom Tromey  <tom@tromey.com>
 185
 186         * tui/tui-winsource.c (tui_update_source_window)
 187         (tui_update_source_window_as_is)
 188         (tui_update_source_windows_with_line): Remove return.
 189         * tui/tui-disasm.c (tui_show_disassem)
 190         (tui_show_disassem_and_update_source): Remove return.
 191         * tui/tui.c (tui_reset): Remove return.
 192         * tui/tui-wingeneral.c
 193         (tui_check_and_display_highlight_if_needed): Remove return.
 194
 195 2019-07-17  Tom Tromey  <tom@tromey.com>
 196
 197         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 198
 199 2019-07-17  Tom Tromey  <tom@tromey.com>
 200
 201         * tui/tui-winsource.h (struct tui_exec_info_window)
 202         (struct tui_source_window_base): Move from tui-data.h.
 203         * tui/tui-winsource.c: Move many method definitions from
 204         elsewhere.  Remove "structuring" comments.
 205         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 206         (tui_source_window_base::refresh_window): Move to
 207         tui-winsource.c.
 208         * tui/tui-win.c (tui_source_window_base::refresh_all)
 209         (tui_source_window_base::update_tab_width)
 210         (tui_source_window_base::set_new_height)
 211         (tui_source_window_base::do_make_visible_with_new_height): Move to
 212         tui-winsource.c.
 213         * tui/tui-source.h: Update.
 214         * tui/tui-source.c (tui_source_window_base::reset): Move to
 215         tui-winsource.c.
 216         * tui/tui-disasm.h: Update.
 217         * tui/tui-data.h (struct tui_exec_info_window): Move to
 218         tui-winsource.h.
 219         (struct tui_source_window_base): Likewise.
 220         * tui/tui-data.c (tui_source_window_base::clear_detail)
 221         (tui_source_window_base, ~tui_source_window_base): Move to
 222         tui-winsource.c.
 223
 224 2019-07-17  Tom Tromey  <tom@tromey.com>
 225
 226         * tui/tui-win.c (tui_resize_all)
 227         (tui_source_window_base::update_tab_width)
 228         (tui_adjust_win_heights): Update.
 229         (tui_win_info::make_invisible_and_set_new_height): Rename from
 230         make_invisible_and_set_new_height.
 231         * tui/tui-data.h (struct tui_win_info)
 232         <make_invisible_and_set_new_height>: New method.
 233
 234 2019-07-17  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui.c: Update.
 237         * tui/tui-source.h (struct tui_source_window): Move from
 238         tui-data.h.
 239         * tui/tui-layout.c: Update.
 240         * tui/tui-disasm.c: Update.
 241         * tui/tui-data.h (struct tui_source_window): Move to
 242         tui-source.h.
 243
 244 2019-07-17  Tom Tromey  <tom@tromey.com>
 245
 246         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 247         tui-data.h.
 248         * tui/tui-data.h (struct tui_disasm_window): Move to
 249         tui-disasm.h.
 250
 251 2019-07-17  Tom Tromey  <tom@tromey.com>
 252
 253         * tui/tui-regs.h (struct tui_data_item_window): Move from
 254         tui-data.h.
 255         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 256         * tui/tui-data.h (struct tui_data_item_window): Move to
 257         tui-regs.h.
 258         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 259
 260 2019-07-17  Tom Tromey  <tom@tromey.com>
 261
 262         * tui/tui.c: Update.
 263         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 264         (tui_cmd_window::max_height): Move to tui-command.c.
 265         * tui/tui-layout.c: Update.
 266         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 267         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 268         tui-command.c.
 269         * tui/tui-command.h (struct tui_cmd_window): Move from
 270         tui-data.h.
 271         * tui/tui-command.c: Remove "structuring" comments.
 272         (tui_cmd_window::clear_detail)
 273         (tui_cmd_window::do_make_visible_with_new_height)
 274         (tui_cmd_window::max_height): Move from elsewhere.
 275
 276 2019-07-17  Tom Tromey  <tom@tromey.com>
 277
 278         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 279         Now static.
 280         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 281         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 282
 283 2019-07-17  Tom Tromey  <tom@tromey.com>
 284
 285         * tui/tui.c: Update.
 286         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 287         tui-regs.c.
 288         * tui/tui-windata.h: Remove file.
 289         * tui/tui-windata.c: Remove file.
 290         * tui/tui-win.c (tui_data_window::set_new_height)
 291         (tui_data_window::do_make_visible_with_new_height): Move to
 292         tui-regs.c.
 293         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 294         * tui/tui-regs.c: Remove "structuring" comments.
 295         (tui_data_window::first_data_item_displayed)
 296         (tui_data_window::delete_data_content_windows)
 297         (tui_data_window::erase_data_content)
 298         (tui_data_window::display_all_data)
 299         (tui_data_window::refresh_all)
 300         (tui_data_window::do_scroll_vertical)
 301         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 302         (tui_data_window::do_make_visible_with_new_height)
 303         (tui_data_window::refresh_window): Move from elsewhere.
 304         (_initialize_tui_regs): Move to end of file.
 305         * tui/tui-layout.c: Update.
 306         * tui/tui-hooks.c: Update.
 307         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 308         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 309         tui-regs.c.
 310         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 311
 312 2019-07-17  Tom Tromey  <tom@tromey.com>
 313
 314         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 315         seen.
 316
 317 2019-07-17  Tom Tromey  <tom@tromey.com>
 318
 319         * tui/tui-win.c (tui_source_window_base::set_new_height)
 320         (tui_source_window_base::do_make_visible_with_new_height): Use
 321         m_has_locator field directly.
 322         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 323         method.
 324         (struct tui_source_window_base) <has_locator>: Likewise.
 325
 326 2019-07-17  Tom Tromey  <tom@tromey.com>
 327
 328         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 329         Don't declare.
 330         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 331         Remove.
 332         * tui/tui-win.c (tui_source_window_base::set_new_height)
 333         (tui_source_window_base::set_new_height)
 334         (make_invisible_and_set_new_height)
 335         (tui_source_window_base::do_make_visible_with_new_height)
 336         (tui_source_window_base::do_make_visible_with_new_height):
 337         Update.
 338         * tui/tui-layout.c (show_source_disasm_command, show_data)
 339         (show_source_or_disasm_and_command): Update.
 340         * tui/tui-layout.c (show_layout): Update.
 341
 342 2019-07-17  Tom Tromey  <tom@tromey.com>
 343
 344         * tui/tui-layout.c (make_data_window): Remove.
 345         (show_data): Unify creation and re-initialization cases.
 346
 347 2019-07-17  Tom Tromey  <tom@tromey.com>
 348
 349         * tui/tui-layout.c (make_source_window, make_disasm_window):
 350         Remove.
 351         (show_data): Unify creation and re-initialization cases.
 352
 353 2019-07-17  Tom Tromey  <tom@tromey.com>
 354
 355         * tui/tui-layout.c (make_command_window): Remove.
 356         (show_source_disasm_command, show_source_or_disasm_and_command):
 357         Unify creation and re-initialization cases.
 358
 359 2019-07-17  Tom Tromey  <tom@tromey.com>
 360
 361         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 362         creation and re-initialization cases.
 363
 364 2019-07-17  Tom Tromey  <tom@tromey.com>
 365
 366         * tui/tui-regs.c (tui_get_register): Return void.
 367
 368 2019-07-17  Tom Tromey  <tom@tromey.com>
 369
 370         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 371         Simplify.
 372
 373 2019-07-17  Tom Tromey  <tom@tromey.com>
 374
 375         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 376         resetting.
 377
 378 2019-07-17  Tom Tromey  <tom@tromey.com>
 379
 380         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 381         * tui/tui-regs.c (tui_reg_layout): New function.
 382         (tui_show_registers, tui_reg_command): Use it.
 383         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 384         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 385         parameters.
 386         (tui_layout_command): Remove.
 387
 388 2019-07-17  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui-layout.h (tui/tui-layout): Return void.
 391         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 392
 393 2019-07-17  Tom Tromey  <tom@tromey.com>
 394
 395         * tui/tui-layout.c (show_source_disasm_command, show_data):
 396         Update.
 397         (reset_locator): Remove.
 398         (show_source_or_disasm_and_command): Update.
 399
 400 2019-07-17  Tom Tromey  <tom@tromey.com>
 401
 402         * tui/tui-source.c (tui_source_window_base::reset): Remove
 403         win_type parameter.
 404         * tui/tui-layout.c (make_command_window, make_source_window)
 405         (make_disasm_window, make_data_window)
 406         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 407         (reset_locator, show_source_or_disasm_and_command): Update.
 408         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 409         win_type parameter.
 410         (struct tui_source_window_base) <reset>: Likewise.
 411
 412 2019-07-17  Tom Tromey  <tom@tromey.com>
 413
 414         * tui/tui-layout.c (show_source_disasm_command): Use
 415         reset_locator.
 416         (reset_locator): New function.
 417         (init_and_make_win): Remove.
 418         (show_source_or_disasm_and_command): Use reset_locator.
 419
 420 2019-07-17  Tom Tromey  <tom@tromey.com>
 421
 422         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 423         condition.
 424         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 425         Remove condition.
 426         * tui/tui-source.c (tui_source_window_base::reset): New method.
 427         * tui/tui-layout.c (make_command_window): Don't call
 428         init_and_make_win.
 429         (make_source_window, make_disasm_window): Don't call
 430         make_source_or_disasm_window.
 431         (make_data_window): Don't call init_and_make_win.  Change calling
 432         convention.
 433         (show_source_disasm_command, show_data): Simplify.
 434         (make_source_or_disasm_window): Remove.
 435         (show_source_or_disasm_and_command): Simplify.
 436         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 437         (struct tui_source_window_base) <reset>: Likewise.
 438         <execution_info>: Remove initializer.
 439         * tui/tui-data.c (tui_source_window_base): Initialize
 440         execution_info.
 441
 442 2019-07-17  Tom Tromey  <tom@tromey.com>
 443
 444         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 445         variable.
 446
 447 2019-07-17  Tom Tromey  <tom@tromey.com>
 448
 449         * tui/tui.c (tui_rl_other_window): Update.
 450         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 451         superclass method first.  Always iterate over regs_content.
 452         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 453         method.
 454         * tui/tui-win.c (tui_set_focus_command): Update.
 455
 456 2019-07-17  Tom Tromey  <tom@tromey.com>
 457
 458         * tui/tui-win.c (tui_set_focus_command): Rename from
 459         tui_set_focus.  Call tui_enable.
 460         (tui_set_focus_command): Remove.
 461
 462 2019-07-17  Tom Tromey  <tom@tromey.com>
 463
 464         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 465         refresh_window.
 466         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 467         touchwin.
 468         (tui_data_window::refresh_window): Call refresh_window on data
 469         items.  Always call superclass refresh_window.
 470         (tui_win_info::refresh): Remove.
 471         (tui_source_window_base::refresh_window): Update.
 472         (tui_refresh_all): Update.
 473         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 474         refresh_window.
 475         (show_source_or_disasm_and_command): Likewise.
 476         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 477         (struct tui_source_window_base) <refresh>: Likewise.
 478
 479 2019-07-17  Tom Tromey  <tom@tromey.com>
 480
 481         * tui/tui-winsource.c (tui_clear_source_content)
 482         (tui_show_source_content): Update.
 483         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 484         whether content is empty.
 485         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 486         Remove.
 487
 488 2019-07-17  Tom Tromey  <tom@tromey.com>
 489
 490         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 491         window's contents.
 492         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 493         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 494
 495 2019-07-17  Tom Tromey  <tom@tromey.com>
 496
 497         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 498         (struct tui_data_item_window): Update.
 499
 500 2019-07-17  Tom Tromey  <tom@tromey.com>
 501
 502         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 503         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 504         defines.
 505
 506 2019-07-17  Tom Tromey  <tom@tromey.com>
 507
 508         * tui/tui-winsource.h (tui_erase_source_content)
 509         (tui_clear_source_content): Remove "display_prompt" parameter.
 510         * tui/tui-winsource.c (tui_update_source_window_as_is)
 511         (tui_update_source_windows_with_addr): Update.
 512         (tui_clear_source_content): Remove "display_prompt" parameter.
 513         (tui_erase_source_content): Likewise.  Simplify.
 514         (tui_show_source_content): Update.
 515         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 516         * tui/tui-stack.c (tui_show_frame_info): Update.
 517         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 518         Remove defines.
 519
 520 2019-07-17  Tom Tromey  <tom@tromey.com>
 521
 522         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 523         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 524         parameter.
 525         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 526         parameter.
 527
 528 2019-07-17  Tom Tromey  <tom@tromey.com>
 529
 530         * tui/tui-winsource.c (tui_clear_source_content)
 531         (tui_show_source_content, tui_show_exec_info_content)
 532         (tui_clear_exec_info_content): Update.
 533         * tui/tui-stack.c (tui_show_locator_content): Update.
 534         (tui_show_frame_info): Update.
 535         * tui/tui-source.h (tui_source_window): Don't declare.
 536         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 537         from tui_source_is_displayed.
 538         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 539         Remove field.
 540         (struct tui_source_window_base) <content_in_use>: New field.  Now
 541         bool.
 542         (struct tui_source_window) <showing_source_p>: New method.
 543         (TUI_SRC_WIN): Change cast.
 544         * tui/tui-data.c (tui_initialize_static_data): Update.
 545
 546 2019-07-17  Tom Tromey  <tom@tromey.com>
 547
 548         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 549         location_matches_p.
 550         * tui/tui-source.c (tui_source_window::location_matches_p): New
 551         method.
 552         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 553         method.
 554         * tui/tui-data.h (struct tui_source_window_base)
 555         <location_matches_p>: New method.
 556         (struct tui_source_window, struct tui_disasm_window)
 557         <location_matches_p>: Likewise.
 558
 559 2019-07-17  Tom Tromey  <tom@tromey.com>
 560
 561         * tui/tui-win.c (tui_set_win_height_command): Rename from
 562         tui_set_win_height.
 563         (tui_set_win_height_command): Remove.
 564
 565 2019-07-17  Tom Tromey  <tom@tromey.com>
 566
 567         * tui/tui-source.c (tui_source_window): New constructor.  Add
 568         observer.
 569         (~tui_source_window): New destructor.
 570         (tui_source_window::style_changed): New method.
 571         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 572         (tui_attach_detach_observers): Update.
 573         * tui/tui-data.h (struct tui_source_window): Make constructor not
 574         inline.  Add destructor.
 575         (struct tui_source_window) <style_changed>: New method.
 576         <m_observable>: New member.
 577
 578 2019-07-17  Tom Tromey  <tom@tromey.com>
 579
 580         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 581         * tui/tui-win.c (tui_resize_all): Fix typo.
 582
 583 2019-07-17  Tom Tromey  <tom@tromey.com>
 584
 585         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 586         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 587         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 588         * tui/tui-win.c (window_name_completer): Use foreach.
 589         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 590         (update_tab_width): Likewise.
 591         * tui/tui-layout.c (show_layout): Update.
 592         * tui/tui-data.h (class tui_window_iterator): New.
 593         (struct all_tui_windows): New.
 594         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 595
 596 2019-07-17  Tom Tromey  <tom@tromey.com>
 597
 598         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 599         parameter.  Don't reference globals.
 600         (tui_reg_command): Update.
 601
 602 2019-07-17  Tom Tromey  <tom@tromey.com>
 603
 604         * tui/tui-regs.c (tui_show_registers): Simplify.
 605
 606 2019-07-17  Tom Tromey  <tom@tromey.com>
 607
 608         * tui/tui-regs.c (tui_show_registers): Update.
 609         (tui_show_register_group): Add win_info parameter.
 610
 611 2019-07-17  Tom Tromey  <tom@tromey.com>
 612
 613         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 614         Rename from tui_display_reg_element_at_line.
 615         (tui_data_window::display_registers_from_line): Update.
 616         * tui/tui-data.h (struct tui_data_window)
 617         <display_reg_element_at_line>: New method.
 618
 619 2019-07-17  Tom Tromey  <tom@tromey.com>
 620
 621         * tui/tui-regs.h (tui_display_registers_from)
 622         (tui_display_registers_from_line): Don't declare.
 623         * tui/tui-windata.c (tui_data_window::display_all_data)
 624         (tui_data_window::refresh_all)
 625         (tui_data_window::do_scroll_vertical): Update.
 626         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 627         from tui_display_registers_from.
 628         (tui_display_reg_element_at_line): Update.
 629         (tui_data_window::display_registers_from_line): Rename from
 630         tui_display_registers_from_line.
 631         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 632         display_registers_from_line>: New methods.
 633
 634 2019-07-17  Tom Tromey  <tom@tromey.com>
 635
 636         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 637         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 638         from tui_erase_data_content.
 639         (tui_data_window::display_all_data)
 640         (tui_data_window::refresh_all)
 641         (tui_data_window::do_scroll_vertical): Update.
 642         * tui/tui-regs.c (tui_show_registers): Update.
 643         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 644         New method.
 645
 646 2019-07-17  Tom Tromey  <tom@tromey.com>
 647
 648         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 649         declare.
 650         * tui/tui-windata.c
 651         (tui_data_window::delete_data_content_windows): Rename from
 652         tui_delete_data_content_windows.
 653         (tui_data_window::display_all_data)
 654         (tui_data_window::do_scroll_vertical): Update.
 655         * tui/tui-data.h (struct tui_data_window)
 656         <delete_data_content_windows>: New method.
 657
 658 2019-07-17  Tom Tromey  <tom@tromey.com>
 659
 660         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 661         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 662
 663 2019-07-17  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 666         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 667         from tui_display_all_data.
 668         * tui/tui-win.c
 669         (tui_data_window::do_make_visible_with_new_height): Update.
 670         * tui/tui-regs.c (tui_show_registers): Update.
 671         * tui/tui-layout.c (tui_set_layout): Update.
 672         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 673         method.
 674
 675 2019-07-17  Tom Tromey  <tom@tromey.com>
 676
 677         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 678         * tui/tui-windata.c (tui_display_data_from): Remove.
 679         (tui_data_window::refresh_all): Update.
 680
 681 2019-07-17  Tom Tromey  <tom@tromey.com>
 682
 683         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 684         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 685         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 686         tui_display_registers_from_line.
 687         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 688         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 689         "force_display" parameter.
 690
 691 2019-07-17  Tom Tromey  <tom@tromey.com>
 692
 693         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 694         declare.
 695         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 696         Rename from tui_first_reg_element_no_inline.
 697         (tui_display_reg_element_at_line)
 698         (tui_display_registers_from_line): Update.
 699         * tui/tui-data.h (struct tui_data_window)
 700         <first_reg_element_no_inline>: New method.
 701
 702 2019-07-17  Tom Tromey  <tom@tromey.com>
 703
 704         * tui/tui-windata.c (tui_display_data_from)
 705         (tui_data_window::do_scroll_vertical): Update.
 706         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 707         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 708         Rename from tui_line_from_reg_element_no.
 709         (tui_display_registers_from_line): Update.
 710         * tui/tui-data.h (struct tui_data_window)
 711         <line_from_reg_element_no>: New method.
 712
 713 2019-07-17  Tom Tromey  <tom@tromey.com>
 714
 715         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 716         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 717         tui_last_regs_line_no.
 718         (tui_display_reg_element_at_line)
 719         (tui_display_registers_from_line): Update.
 720         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 721         method.
 722
 723 2019-07-17  Tom Tromey  <tom@tromey.com>
 724
 725         PR tui/24722:
 726         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 727         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 728         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 729         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 730         (tui_update_breakpoint_info): Likewise.
 731         * tui/tui-hooks.c (tui_event_create_breakpoint)
 732         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 733         Update.
 734
 735 2019-07-17  Tom Tromey  <tom@tromey.com>
 736
 737         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 738
 739 2019-07-17  Tom Tromey  <tom@tromey.com>
 740
 741         * tui/tui-winsource.c (tui_update_source_window_as_is)
 742         (tui_update_source_windows_with_addr): Update.
 743         * tui/tui-source.h (tui_set_source_content)
 744         (tui_show_symtab_source): Add "win_info" parameter.
 745         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 746         parameter.
 747         (tui_show_symtab_source): Likewise.
 748
 749 2019-07-17  Tom Tromey  <tom@tromey.com>
 750
 751         * tui/tui-wingeneral.c
 752         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 753
 754 2019-07-17  Tom Tromey  <tom@tromey.com>
 755
 756         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 757         (struct tui_cmd_window) <can_scroll>: New method.
 758         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 759         method.
 760
 761 2019-07-17  Tom Tromey  <tromey@adacore.com>
 762
 763         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 764         do_field_signed>: Rename.  Change type of "value".
 765         * ui-out.c (ui_out::field_signed): Rename from field_int.
 766         Change type of "value".
 767         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 768         type of "value".
 769         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 770         do_field_int.  Change type of "value".
 771         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 772         do_field_int.  Change type of "value".
 773         * tracepoint.c (trace_status_mi, tfind_1)
 774         (print_one_static_tracepoint_marker): Update.
 775         * thread.c (print_thread_info_1, print_selected_thread_frame):
 776         Update.
 777         * stack.c (print_frame, print_frame_info): Update.
 778         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 779         Update.
 780         * source.c (print_source_lines_base): Update.
 781         * skip.c (info_skip_command): Update.
 782         * record-btrace.c (btrace_ui_out_decode_error)
 783         (btrace_call_history_src_line): Update.
 784         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 785         Update.
 786         * progspace.c (print_program_space): Update.
 787         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 788         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 789         do_field_int.  Change type of "value".
 790         * mi/mi-out.c (mi_ui_out::do_table_begin)
 791         (mi_ui_out::do_table_header): Update.
 792         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 793         type of "value".
 794         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 795         (mi_cmd_data_list_changed_registers, output_register)
 796         (mi_cmd_data_read_memory, mi_load_progress)
 797         (mi_cmd_trace_frame_collected): Update.
 798         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 799         Update.
 800         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 801         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 802         (mi_cmd_var_list_children, varobj_update_one): Update.
 803         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 804         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 805         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 806         * inferior.c (print_inferior): Update.
 807         * gdb_bfd.c (print_one_bfd): Update.
 808         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 809         Update.
 810         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 811         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 812         do_field_int.  Change type of "value".
 813         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 814         do_field_int.  Change type of "value".
 815         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 816         (print_one_breakpoint_location, print_it_catch_fork)
 817         (print_one_catch_fork, print_it_catch_vfork)
 818         (print_one_catch_vfork, print_it_catch_solib)
 819         (print_it_catch_exec, print_it_ranged_breakpoint)
 820         (print_mention_watchpoint, print_mention_masked_watchpoint)
 821         (bkpt_print_it, update_static_tracepoint): Update.
 822         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 823         * break-catch-syscall.c (print_it_catch_syscall): Update.
 824         * ada-tasks.c (print_ada_task_info): Update.
 825         * ada-lang.c (print_it_exception, print_mention_exception):
 826         Update.
 827
 828 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 829
 830         PR breakpoints/24541
 831         * gdbarch.c: Regenerate.
 832         * gdbarch.h: Regenerate.
 833         * gdbarch.sh: Adjust return type and parameter types for
 834         'stap_adjust_register'.
 835         (i386_stap_adjust_register): Adjust signature and return new
 836         register name.
 837         * stap-probe.c (stap_parse_register_operand): Adjust use of
 838         'gdbarch_stap_adjust_register'.
 839
 840 2019-07-17  Tom Tromey  <tromey@adacore.com>
 841
 842         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 843         declare VEC.
 844         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 845         std::vector.
 846         (struct s390_process_info): Add initializers.
 847         (s390_add_process): Use new.
 848         (s390_linux_nat_target::low_forget_process): Use delete.
 849         (s390_linux_nat_target::low_new_fork)
 850         (s390_linux_nat_target::stopped_by_watchpoint)
 851         (s390_linux_nat_target::low_prepare_to_resume)
 852         (s390_linux_nat_target::insert_watchpoint)
 853         (s390_linux_nat_target::insert_hw_breakpoint)
 854         (s390_linux_nat_target::remove_watchpoint)
 855         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 856
 857 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 858
 859         * aarch64-fbsd-nat.c: Include regcache.h.
 860         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 861         argument.
 862         (aarch64_fbsd_nat_target::fetch_registers)
 863         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 864         variable.
 865         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 866
 867 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 868
 869         * fbsd-nat.c: Include gdbarch.h.
 870
 871 2019-07-15  Tom Tromey  <tromey@adacore.com>
 872
 873         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 874
 875 2019-07-15  Tom Tromey  <tromey@adacore.com>
 876
 877         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 878         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 879         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 880         * cli-out.c (cli_ui_out::do_field_int): New method.
 881         * ui-out.c (ui_out::field_unsigned): New method.
 882         * symfile.c (generic_load): Use field_unsigned.
 883         (print_transfer_performance): Likewise.
 884         * record-btrace.c (ui_out_field_uint): Remove.
 885         (btrace_call_history_insn_range, btrace_call_history): Use
 886         field_unsigned.
 887         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 888         field_unsigned.
 889         * ui-out.h (class ui_out) <field_unsigned>: New method.
 890         <do_field_unsigned>: Likewise.
 891
 892 2019-07-15  Tom Tromey  <tromey@adacore.com>
 893
 894         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 895         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 896         * target.c (flash_erase_command): Use field_string.
 897         * infrun.c (print_signal_received_reason): Use field_string.
 898         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 899         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 900         field_string.
 901         * ada-tasks.c (print_ada_task_info): Use field_string.
 902
 903 2019-07-15  Tom Tromey  <tromey@adacore.com>
 904
 905         * target.c (flash_erase_command): Use field_core_addr.
 906         * symfile.c (generic_load): Use field_core_addr.
 907         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 908         Use field_core_addr.
 909         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 910         field_core_addr.
 911
 912 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 913
 914         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 915         value if its desired type is smaller than a CORE_ADDR and signed.
 916
 917 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 918
 919         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 920         of changes to field names, and use new is_reference field to
 921         decide if a property is a reference or not.
 922         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 923         field.
 924         (struct dwarf2_property_baton): Update header comment, rename
 925         'referenced_type' to 'property_type' and update comments.
 926         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 927         default property type, store in property baton, update to take
 928         accound of renamed field.
 929         (read_func_scope): Update call to attr_to_dynamic_prop.
 930         (read_array_type): Likewise.
 931         (dwarf2_per_cu_addr_sized_int_type): New function.
 932         (read_subrange_index_type): Move type finding code to
 933         dwarf2_per_cu_addr_sized_int_type.
 934         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 935         (dwarf2_per_cu_addr_type): New function.
 936         (set_die_type): Update calls to attr_to_dynamic_prop.
 937
 938 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 939
 940         * dwarf2read.c (read_subrange_index_type): New function.
 941         (read_subrange_type): Move code into new function and call it.
 942         * gdbtypes.c (create_range_type): Add some asserts.
 943
 944 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 945
 946         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 947         update return statements.
 948         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 949         declaration, and update comment to match.
 950         * gdbtypes.c (resolve_dynamic_array): Update call to
 951         dwarf2_evaluate_property to match new return type.
 952
 953 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 954
 955         * valarith.c (value_subscripted_rvalue): Change lowerbound
 956         parameter type from int to LONGEST.
 957         * value.h (value_subscripted_rvalue): Likewise in declaration.
 958
 959 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 960
 961         * cli/cli-utils.c (info_print_command_completer): New function.
 962         * cli/cli-utils.h: Add 'completer.h' include, and forward
 963         declaration for 'struct cmd_list_element'.
 964         (info_print_command_completer): Declare.
 965         * stack.c (_initialize_stack): Add completer for 'info locals' and
 966         'info args'.
 967         * symtab.c (_initialize_symtab): Add completer for 'info
 968         variables' and 'info functions'.
 969         * NEWS: Mention completion for additional info commands.
 970
 971 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 972
 973         * cli/cli-utils.c (extract_info_print_args): Delete.
 974         (extract_arg_maybe_quoted): Delete.
 975         (info_print_options_defs): New variable.
 976         (make_info_print_options_def_group): New function.
 977         (extract_info_print_options): Define new function.
 978         * cli/cli-utils.h (extract_info_print_args): Delete.
 979         (struct info_print_options): New structure.
 980         (extract_info_print_options): Declare new function.
 981         * stack.c (info_locals_command): Update to use new
 982         extract_info_print_options, also add a header comment.
 983         (info_args_command): Likewise.
 984         * symtab.c (info_variables_command): Likewise.
 985         (info_functions_command): Likewise.
 986
 987 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 988
 989         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 990         to extract string arguments.
 991         * common/common-utils.c (extract_string_maybe_quoted): New function.
 992         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 993
 994 2019-07-11  Tom Tromey  <tromey@adacore.com>
 995
 996         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 997         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 998         * top.h (gdbinit): Don't declare.
 999         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1000         into...
1001         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1002         * top.c (gdb_init): Don't call init_cli_cmds.
1003         (gdbinit): Remove.
1004         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1005
1006 2019-07-11  Tom Tromey  <tromey@adacore.com>
1007
1008         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1009         after it has been moved.
1010
1011 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1012
1013         * valops.c (value_must_coerce_to_target): Change return type to
1014         bool.
1015         * value.h (value_must_coerce_to_target): Likewise.
1016
1017 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1018
1019         * breakpoint.c (is_hardware_watchpoint): Remove
1020         forward-declaration.
1021         (is_masked_watchpoint): Change return type to bool.
1022         (is_tracepoint): Likewise.
1023         (is_breakpoint): Likewise.
1024         (is_hardware_watchpoint): Likewise.
1025         (is_watchpoint): Likewise.
1026         (is_no_memory_software_watchpoint): Likewise.
1027         (is_catchpoint): Likewise.
1028         (breakpoint_1): Make FILTER parameter's return type bool.
1029         is_masked_watchpoint): Change return type to bool.
1030         (save_breakpoints): Make FILTER parameter's return type bool.
1031         * breakpoint.h (is_breakpoint): Change return type to bool.
1032         (is_watchpoint): Likewise.
1033         (is_catchpoint): Likewise.
1034         (is_tracepoint): Likewise.
1035
1036 2019-07-10  Tom Tromey  <tom@tromey.com>
1037
1038         * defs.h: Don't include gdbarch.h.
1039         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1040         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1041         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1042         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1043         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1044         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1045         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1046         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1047         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1048         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1049         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1050         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1051         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1052         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1053         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1054         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1055         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1056         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1057         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1058         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1059         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1060         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1061         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1062         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1063         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1064         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1065         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1066
1067 2019-07-10  Tom Tromey  <tromey@adacore.com>
1068
1069         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1070         * breakpoint.c (init_ada_exception_breakpoint): Register as
1071         bp_catchpoint.
1072         (print_one_breakpoint_location, print_one_breakpoint): Use
1073         is_ada_exception_catchpoint.
1074         * ada-lang.c (class ada_catchpoint_location): Pass
1075         bp_loc_software_breakpoint to bp_location constructor.
1076         (is_ada_exception_catchpoint): New function.
1077
1078 2019-07-10  Tom Tromey  <tromey@adacore.com>
1079
1080         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1081         VEC.
1082         (struct arm_exidx_entry): New method operator<.
1083         (struct arm_exidx_data) <section_maps>: Change type.
1084         (arm_exidx_data_free): Remove.
1085         (arm_exidx_data_key): Change type.  Move lower.
1086         (arm_exidx_new_objfile): Update.
1087         (arm_compare_exidx_entries): Remove.
1088         (arm_find_exidx_entry, _initialize_arm_tdep)
1089
1090 2019-07-10  Tom Tromey  <tromey@adacore.com>
1091
1092         * solib-spu.c (ocl_program_data_key): Change type.
1093         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1094         Update.
1095
1096 2019-07-10  Tom Tromey  <tromey@adacore.com>
1097
1098         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1099         (struct solib_aix_inferior_data) <library_list>: Change type.
1100         (solib_aix_inferior_data_handle): Change type.
1101         (get_solib_aix_inferior_data): Update.
1102         (solib_aix_free_library_list): Remove.
1103         (library_list_start_library): Update.
1104         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1105         return type.
1106         (solib_aix_get_library_list)
1107         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1108         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1109
1110 2019-07-10  Tom Tromey  <tromey@adacore.com>
1111
1112         * solib-dsbt.c (struct dsbt_info): Add initializers.
1113         (solib_dsbt_pspace_data): Change type.
1114         (dsbt_pspace_data_cleanup): Remove.
1115         (get_dsbt_info, _initialize_dsbt_solib): Update.
1116
1117 2019-07-10  Tom Tromey  <tromey@adacore.com>
1118
1119         * spu-tdep.c (spu_overlay_data): Change type.
1120         (spu_get_overlay_table, spu_overlay_new_objfile)
1121         (_initialize_spu_tdep): Update.
1122
1123 2019-07-10  Tom Tromey  <tromey@adacore.com>
1124
1125         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1126         destructor.
1127         (dbx_objfile_data_key): Change type and declare later.
1128         (DBX_SYMFILE_INFO): Rewrite.
1129         * dbxread.c (dbx_objfile_data_key): Change type.
1130         (dbx_symfile_init): Update.
1131         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1132         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1133         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1134
1135 2019-07-10  Tom Tromey  <tromey@adacore.com>
1136
1137         * jit.c (jit_program_space_key): Change type.  Move lower.
1138         (get_jit_program_space_data): Update.
1139         (jit_program_space_data_cleanup): Remove.
1140         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1141         Update.
1142         (struct jit_program_space_data): Add initializers.
1143
1144 2019-07-10  Tom Tromey  <tromey@adacore.com>
1145
1146         * solib-darwin.c (struct darwin_info): Add initializers.
1147         (solib_darwin_pspace_data): Change type.
1148         (darwin_pspace_data_cleanup): Remove.
1149         (get_darwin_info, _initialize_darwin_solib): Update.
1150
1151 2019-07-10  Tom Tromey  <tromey@adacore.com>
1152
1153         * remote-sim.c (struct sim_inferior_data): Add initializers,
1154         constructor, and destructor.
1155         (sim_inferior_data_key): Change type.  Move lower.
1156         (check_for_duplicate_sim_descriptor): Update.
1157         (get_sim_inferior_data): Use new.  Update.
1158         (~sim_inferior_data_cleanup): Rename from
1159         sim_inferior_data_cleanup.  Simplify.
1160         (gdbsim_close_inferior, simulator_command)
1161         (sim_command_completer, _initialize_remote_sim): Update.
1162         (next_pid, INITIAL_PID): Move earlier.
1163
1164 2019-07-10  Tom Tromey  <tromey@adacore.com>
1165
1166         * python/python-internal.h (create_thread_object): Return
1167         gdbpy_ref.
1168         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1169         * python/py-inferior.c (struct threadlist_entry): Add
1170         constructor.
1171         <thread_obj>: Now a gdbpy_ref.
1172         (thread_to_thread_object): Update.
1173         (add_thread_object): Use new.
1174         (delete_thread_object): Use delete.
1175         (infpy_threads): Update.
1176         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1177         GIL.
1178
1179 2019-07-10  Tom Tromey  <tromey@adacore.com>
1180
1181         * valops.c (value_cast): Specialize error message for Ada.
1182
1183 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1184
1185         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1186
1187 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1188
1189         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1190         bpstat_should_step): Return bool, adjust comments.
1191         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1192         bpstat_should_step): Likewise.
1193
1194 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1195
1196         * features/Makefile: Use feature target descriptions for Arm.
1197         * features/arm/arm-core.c: Generate new file.
1198         * features/arm/arm-fpa.c: Likewise.
1199         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1200         * features/arm/arm-m-profile.c: Likewise.
1201         * features/arm/arm-vfpv2.c: Likewise.
1202         * features/arm/arm-vfpv3.c: Likewise.
1203         * features/arm/xscale-iwmmxt.c: Likewise.
1204         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1205
1206 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1207
1208         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1209         ptrace earlier.
1210
1211 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1212
1213         * features/aarch64-pauth.c: Regenerate.
1214
1215 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1216
1217         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1218         bool.
1219         (bpstat_what): Use false instead of 0.
1220
1221 2019-07-09  Pedro Alves  <palves@redhat.com>
1222
1223         * break-catch-throw.c (is_exception_catchpoint): New.
1224         * breakpoint.c (print_one_breakpoint_location): New parameter
1225         'raw_loc'.  Handle it.  Use
1226         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1227         looking at the breakpoint's type.
1228         (print_one_breakpoint): If handling "maint info breakpoints", also
1229         print locations of exception catchpoints.
1230         * breakpoint.h (is_exception_catchpoint): Declare.
1231
1232 2019-07-09  Pedro Alves  <palves@redhat.com>
1233
1234         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1235         "addr" field.
1236         (allocate_location_exception_catchpoint): New.
1237         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1238         (initialize_throw_catchpoint_ops): Install
1239         allocate_location_exception_catchpoint as allocate_location
1240         method.
1241         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1242         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1243         bp_loc_other.
1244         (breakpoint_address_is_meaningful): Delete.
1245         (bl_address_is_meaningful): New.
1246         (breakpoint_locations_match): Adjust comment.
1247         (bp_location_from_bp_type): New, factored out of...
1248         (bp_location::bp_location(breakpoint *)): ... this.
1249         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1250         factored out of...
1251         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1252         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1253         breakpoint_address_is_meaningful.
1254         (bp_locations_compare): Adjust comment.
1255         (update_global_location_list): Use bl_address_is_meaningful
1256         instead of breakpoint_address_is_meaningful.
1257         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1258         explicit.
1259         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1260         * python/py-breakpoint.c (bppy_get_location): No longer check
1261         whether location is null.
1262
1263 2019-07-09  Pedro Alves  <palves@redhat.com>
1264
1265         PR c++/15468
1266         * breakpoint.c (print_one_breakpoint_location): Remove
1267         single-location assert.
1268
1269 2019-07-09  Tom Tromey  <tom@tromey.com>
1270
1271         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1272         * configure: Rebuild.
1273         * configure.ac: Change common to gdbsupport.
1274         * gdbsupport: Rename from common.
1275         * acinclude.m4: Change common to gdbsupport.
1276         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1277         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1278         gdbsupport.
1279         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1280         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1281         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1282         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1283         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1284         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1285         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1286         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1287         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1288         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1289         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1290         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1291         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1292         coff-pe-read.c, command.h, compile/compile-c-support.c,
1293         compile/compile-c.h, compile/compile-cplus-symbols.c,
1294         compile/compile-cplus-types.c, compile/compile-cplus.h,
1295         compile/compile-loc2c.c, compile/compile.c, completer.c,
1296         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1297         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1298         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1299         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1300         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1301         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1302         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1303         features/aarch64-core.c, features/aarch64-fpu.c,
1304         features/aarch64-pauth.c, features/aarch64-sve.c,
1305         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1306         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1307         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1308         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1309         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1310         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1311         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1312         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1313         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1314         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1315         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1316         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1317         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1318         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1319         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1320         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1321         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1322         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1323         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1324         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1325         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1326         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1327         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1328         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1329         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1330         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1331         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1332         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1333         minsyms.c, mips-linux-tdep.c, namespace.h,
1334         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1335         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1336         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1337         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1338         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1339         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1340         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1341         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1342         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1343         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1344         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1345         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1346         procfs.c, producer.c, progspace.h, psymtab.h,
1347         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1348         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1349         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1350         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1351         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1352         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1353         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1354         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1355         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1356         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1357         target-memory.c, target.c, target.h, target/waitstatus.c,
1358         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1359         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1360         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1361         unittests/array-view-selftests.c,
1362         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1363         unittests/common-utils-selftests.c,
1364         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1365         unittests/format_pieces-selftests.c,
1366         unittests/function-view-selftests.c,
1367         unittests/lookup_name_info-selftests.c,
1368         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1369         unittests/mkdir-recursive-selftests.c,
1370         unittests/observable-selftests.c,
1371         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1372         unittests/parse-connection-spec-selftests.c,
1373         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1374         unittests/scoped_fd-selftests.c,
1375         unittests/scoped_mmap-selftests.c,
1376         unittests/scoped_restore-selftests.c,
1377         unittests/string_view-selftests.c, unittests/style-selftests.c,
1378         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1379         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1380         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1381         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1382         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1383         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1384
1385 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1386
1387         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1388         bool value.
1389         (decode_digits_ordinary): Set explicit_line field in sal.
1390         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1391         symtab_and_line that was set on an explicit line number in
1392         assembler code.  Do always update the recorded symtab and line if
1393         we do skip the prologue.
1394
1395 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1396
1397         * breakpoint.c (set_breakpoint_location_function): Remove
1398         explicit_loc parameter.
1399         (momentary_breakpoint_from_master): Update call to
1400         set_breakpoint_location_function.
1401         (add_location_to_breakpoint): Likewise.
1402
1403 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1404
1405         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1406         required features based on default bfd type when no specific bfd
1407         is present.
1408
1409 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1410
1411         * NEWS: Mention that GDB printf and eval commands can now print
1412         C-style and Ada-style convenience var strings without
1413         calling the inferior.
1414         * printcmd.c (printf_c_string): Locally print GDB internal var
1415         instead of transiting via the inferior.
1416         (printf_wide_c_string): Likewise.
1417
1418 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1419
1420         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1421
1422 2019-07-04  Tom Tromey  <tom@tromey.com>
1423
1424         PR tui/24724:
1425         * tui/tui-winsource.c (tui_clear_source_content): Update.
1426         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1427         (tui_update_breakpoint_info): Update.
1428         (tui_set_exec_info_content): Update.
1429         * tui/tui-source.c (tui_set_source_content_nil): Update.
1430         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1431         has_break.
1432         * tui/tui-data.h (enum tui_bp_flag): New.
1433         (tui_bp_flags): New enum flags type.
1434         (struct tui_source_element) <break_mode>: Change type.  Rename
1435         from has_break.
1436         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1437         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1438         constants.
1439         * tui/tui-winsource.h: Fix comment.
1440
1441 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1442
1443         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1444         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1445         (store_fpregs_to_thread)
1446         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1447         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1448         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1449         (IWMMXT_REGS_SIZE): Add define.
1450         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1451         (fetch_vfp_regs, store_vfp_regs)
1452         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1453         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1454
1455 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1456
1457         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1458         defines.
1459         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1460         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1461         (ARM_INT_REGISTER_SIZE): ...to this.
1462         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1463         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1464         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1465         (arm_linux_collect_gregset, supply_nwfpe_register)
1466         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1467         defines.
1468         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1469         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1470         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1471         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1472         (arm_return_in_memory, arm_store_return_value)
1473         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1474         (arm_record_ld_st_multiple): Likewise.
1475         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1476         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1477
1478 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1479
1480         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1481         AARCH64_DISPLACED_MODIFIED_INSNS.
1482         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1483         (aarch64_displaced_step_copy_insn): Likewise.
1484         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1485         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1486         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1487         ARM_DISPLACED_MODIFIED_INSNS.
1488         * arm-tdep.c (arm_gdbarch_init): Likewise.
1489         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1490         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1491         (struct arm_displaced_step_closure): Use
1492         ARM_DISPLACED_MODIFIED_INSNS.
1493
1494 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1495
1496         * features/Makefile: Remove unused xml files.
1497         * features/aarch64.xml: Remove.
1498         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1499         * features/i386/amd64-avx-avx512.xml: Remove.
1500         * features/i386/amd64-avx-linux.xml: Remove.
1501         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1502         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1503         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1504         * features/i386/amd64-avx-mpx.xml: Remove.
1505         * features/i386/amd64-avx.xml: Remove.
1506         * features/i386/amd64-linux.xml: Remove.
1507         * features/i386/amd64-mpx-linux.xml: Remove.
1508         * features/i386/amd64-mpx.xml: Remove.
1509         * features/i386/amd64.xml: Remove.
1510         * features/i386/i386-avx-avx512-linux.xml: Remove.
1511         * features/i386/i386-avx-avx512.xml: Remove.
1512         * features/i386/i386-avx-linux.xml: Remove.
1513         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1514         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1515         * features/i386/i386-avx-mpx-linux.xml: Remove.
1516         * features/i386/i386-avx-mpx.xml: Remove.
1517         * features/i386/i386-avx.xml: Remove.
1518         * features/i386/i386-linux.xml: Remove.
1519         * features/i386/i386-mmx-linux.xml: Remove.
1520         * features/i386/i386-mmx.xml: Remove.
1521         * features/i386/i386-mpx-linux.xml: Remove.
1522         * features/i386/i386-mpx.xml: Remove.
1523         * features/i386/i386.xml: Remove.
1524         * features/i386/x32-avx-avx512-linux.xml: Remove.
1525         * features/i386/x32-avx-linux.xml: Remove.
1526         * features/i386/x32-linux.xml: Remove.
1527
1528 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1529
1530         * regformats/aarch64.dat: Remove.
1531         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1532         * regformats/i386/amd64-avx-linux.dat: Remove.
1533         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1534         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1535         * regformats/i386/amd64-linux.dat: Remove.
1536         * regformats/i386/amd64-mpx-linux.dat: Remove.
1537         * regformats/i386/amd64.dat: Remove.
1538         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1539         * regformats/i386/i386-avx-linux.dat: Remove.
1540         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1541         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1542         * regformats/i386/i386-linux.dat: Remove.
1543         * regformats/i386/i386-mmx-linux.dat: Remove.
1544         * regformats/i386/i386-mpx-linux.dat: Remove.
1545         * regformats/i386/i386.dat: Remove.
1546         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1547         * regformats/i386/x32-avx-linux.dat: Remove.
1548         * regformats/i386/x32-linux.dat: Remove.
1549
1550 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1551
1552         * aarch64-tdep.c: Remove xml self tests.
1553         * amd64-linux-tdep.c: Likewise.
1554         * amd64-tdep.c: Likewise.
1555         * i386-linux-tdep.c: Likewise.
1556         * i386-tdep.c: Likewise.
1557
1558 2019-07-03  Pedro Alves  <palves@redhat.com>
1559
1560         PR cli/24732
1561         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1562         (pipe_cmd_option_defs): New.
1563         (make_pipe_cmd_options_def_group): New.
1564         (pipe_command): Use gdb::option::process_options.
1565         (pipe_command_completer): New function.
1566         (_initialize_cli_cmds): Install completer for "pipe" command.
1567
1568 2019-07-03  Pedro Alves  <palves@redhat.com>
1569
1570         * cli/cli-option.c (union option_value) <string>: New field.
1571         (struct option_def_and_value): Add ctor, move ctor, dtor and
1572         use DISABLE_COPY_AND_ASSIGN.
1573         (option_def_and_value::clear_value): New.
1574         (parse_option, save_option_value_in_ctx, get_val_type_str)
1575         (add_setshow_cmds_for_options): Handle var_string.
1576         * cli-option.h (union option_def::var_address) <string>: New
1577         field.
1578         (struct string_option_def): New.
1579         * maint-test-options.c (struct test_options_opts): Add default
1580         ctor and use DISABLE_COPY_AND_ASSIGN.
1581         <string_opt>: New field.
1582         (test_options_opts::~test_options_opts): New.
1583         (test_options_opts::dump): Also dump "-string".
1584         (test_options_option_defs): Install "string.
1585
1586 2019-07-03  Pedro Alves  <palves@redhat.com>
1587
1588         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1589         option_value with a null enumeration.
1590         (complete_options): Save the option values in the context.
1591         (save_option_value_in_ctx): New, factored out from ...
1592         (process_options): ... here.
1593         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1594         of the function.
1595         * maint-test-options.c (test_options_opts::dump): New, factored
1596         out from ...
1597         (maintenance_test_options_command_mode): ... here.
1598         (maintenance_test_options_command_completion_result): Delete.
1599         (maintenance_test_options_command_completion_text): Update
1600         comment.
1601         (maintenance_show_test_options_completion_result): Change
1602         prototype.  Just print
1603         maintenance_test_options_command_completion_text.
1604         (save_completion_result): New.
1605         (maintenance_test_options_completer_mode): Pass options context to
1606         complete_options, and then save a dump.
1607         (_initialize_maint_test_options): Use add_cmd to install "maint
1608         show test-options-completion-result".
1609
1610 2019-07-03  Pedro Alves  <palves@redhat.com>
1611
1612         * NEWS (New commands): Mention "with" and "maint with".
1613         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1614         (with_command, with_command_completer): New.
1615         (pipe_command): Adjust to new repeat_previous
1616         interface.
1617         (_initialize_cli_cmds): Install the "with" command and its "w"
1618         alias.
1619         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1620         declarations.
1621         * cli/cli-setshow.c (parse_cli_var_uinteger)
1622         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1623         argument strings for all var_types.
1624         (get_setshow_command_value_string): New, factored out from ...
1625         (do_show_command): ... this.
1626         * cli/cli-setshow.h: Include <string>.
1627         (get_setshow_command_value_string): Declare.
1628         * command.h (repeat_previous): Now returns const char *.  Adjust
1629         comment.
1630         * maint.c: Include "cli/cli-cmds.h".
1631         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1632         (_initialize_maint_cmds): Register the "maintenance with" command.
1633         * top.c (repeat_previous): Move bits from pipe_command here:
1634         Return the saved command line, if any; error out if there's no
1635         command to relaunch.
1636
1637 2019-07-03  Pedro Alves  <palves@redhat.com>
1638
1639         * NEWS (New commands): Mention "maint set/show test-settings"
1640         instead of "maint test-settings".
1641         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1642         (maintenance_test_settings_set_list): Rename to ...
1643         (maintenance_set_test_settings_list): ... this.
1644         (maintenance_test_settings_show_list): Rename to  ...
1645         (maintenance_show_test_settings_list): ... this.
1646         (maintenance_test_settings_cmd): Delete.
1647         (maintenance_test_settings_set_cmd): ...
1648         (maintenance_set_test_settings_cmd): ... this.
1649         (maintenance_test_settings_show_cmd): ...
1650         (maintenance_show_test_settings_cmd): ... this.
1651         (maintenance_test_settings_show_value_cmd):
1652         (maintenance_show_test_settings_value_cmd): ... this.
1653         (_initialize_maint_test_settings): No longer install the "maint
1654         test-settings" prefix command.  Rename "maint test-settings set"
1655         to "maint set test-settings", and "maint test-settings show" to
1656         "maint show test-settings".  Adjust all subcommands.
1657
1658 2019-07-03  Pedro Alves  <palves@redhat.com>
1659
1660         * maint-test-settings.c: Fix file's intro comment.  Replace all
1661         references to "test-options" with references to "test-settings",
1662         in comments.
1663
1664 2019-07-03  Pedro Alves  <palves@redhat.com>
1665
1666         * maint-test-settings.c (maintenance_test_settings_xxx)
1667         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1668         New.
1669         (maintenance_test_settings_enums): Use them.
1670         (maintenance_test_settings_enum): Default to
1671         maintenance_test_settings_xxx.
1672         (_initialize_maint_test_settings): Initialize
1673         MAINTENANCE_TEST_SETTINGS_FILENAME.
1674
1675 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1676
1677         * breakpoint.h (remove_breakpoints_inf): Change return type to
1678         void, move function documentation here.
1679         * breakpoint.c (remove_breakpoints_inf): Change return type to
1680         void, move function documentation to header.
1681
1682 2019-07-02  Pedro Alves  <palves@redhat.com>
1683
1684         * NEWS (Completion improvements): Mention "info threads".
1685         * thread.c (struct info_threads_opts, info_threads_option_defs)
1686         (make_info_threads_options_def_group): New.
1687         (info_threads_command): Use gdb::option::process_options.
1688         (info_threads_command_completer): New.
1689         (_initialize_thread): Use gdb::option::build_help to build the
1690         help text for "info threads".
1691
1692 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1693
1694         * defs.h (generic_load): Move from here...
1695         * symfile.h (generic_load): ... to here.  Rename name parameter
1696         to args.
1697         * symfile.c (generic_load): Add comment.
1698
1699 2019-07-01  Tom Tromey  <tromey@adacore.com>
1700
1701         * dwarf2read.c
1702         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1703         declaration of without_params.  Fix formatting.
1704
1705 2019-07-01  Tom Tromey  <tromey@adacore.com>
1706
1707         * ada-exp.y (find_primitive_type): Update.
1708         * ada-lang.h (ada_lookup_symbol): Update.
1709         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1710         parameter.
1711         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1712
1713 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1714
1715         PR breakpoints/24541
1716         * gdbarch.c: Regenerate.
1717         * gdbarch.h: Regenerate.
1718         * gdbarch.sh: Add 'stap_adjust_register'.
1719         * i386-tdep.c: Include '<unordered_set>'.
1720         (i386_stap_adjust_register): New function.
1721         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1722         * stap-probe.c (stap_parse_register_operand): Call
1723         'gdbarch_stap_adjust_register'.
1724
1725 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1726
1727         PR python/24742
1728         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1729         * python/python.c (do_start_initialization): Use 'xmalloc'
1730         instead of 'PyMem_Malloc'.
1731
1732 2019-06-28  Tom Tromey  <tromey@adacore.com>
1733
1734         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1735         for Ada.
1736
1737 2019-06-27  Tom Tromey  <tromey@adacore.com>
1738
1739         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1740         objfile_key.
1741         (arm_find_mapping_symbol, arm_record_special_symbol)
1742         (_initialize_arm_tdep): Update.
1743         (arm_objfile_data_free): Remove.
1744
1745 2019-06-27  Tom Tromey  <tromey@adacore.com>
1746
1747         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1748         to cp_print_static_field.
1749
1750 2019-06-26  Tom Tromey  <tromey@adacore.com>
1751
1752         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1753         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1754         declare.
1755
1756 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1757
1758         * features/aarch64-core.c (create_feature_aarch64_core):
1759         Regenerate.
1760         * features/aarch64-core.xml: Add cpsr flags.
1761
1762 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1763
1764         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1765         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1766
1767 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1768
1769         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1770         field.
1771         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1772         use.
1773         (arm_record_special_symbol): Don't insert new symbol in sorted
1774         position, push it at the end.
1775
1776 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1777
1778         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1779         (arm_mapping_symbol_s): Remove.
1780         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1781         (arm_mapping_symbol_vec): New typedef.
1782         (struct arm_per_objfile): Add constructor.
1783         <section_maps>: Change type to
1784         std::unique_ptr<arm_mapping_symbol_vec[]>.
1785         (arm_compare_mapping_symbols): Remove.
1786         (arm_find_mapping_symbol): Adjust to section_maps type change.
1787         (arm_objfile_data_free): Call delete on arm_per_objfile.
1788         (arm_record_special_symbol): Adjust to section_maps type change.
1789         Allocate arm_per_objfile with new.
1790
1791 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1792
1793         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1794         with the command prefix.
1795
1796 2019-06-25  Tom Tromey  <tom@tromey.com>
1797
1798         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1799         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1800
1801 2019-06-25  Tom Tromey  <tom@tromey.com>
1802
1803         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1804         type.
1805         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1806         protected.
1807
1808 2019-06-25  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-winsource.c
1811         (tui_source_window_base::set_is_exec_point_at): Add check against
1812         LOA_ADDRESS.
1813
1814 2019-06-25  Tom Tromey  <tom@tromey.com>
1815
1816         * tui/tui-source.c (tui_set_source_content): Don't check before
1817         xfree.
1818         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1819
1820 2019-06-25  Tom Tromey  <tom@tromey.com>
1821
1822         * tui/tui-winsource.h (tui_update_source_window_as_is)
1823         (tui_alloc_source_buffer, tui_line_is_displayed)
1824         (tui_addr_is_displayed): Change type of win_info.
1825         * tui/tui-winsource.c (tui_update_source_window_as_is)
1826         (tui_clear_source_content, tui_show_source_line)
1827         (tui_show_source_content, tui_source_window_base::refill)
1828         (tui_source_window_base::set_is_exec_point_at)
1829         (tui_source_window_base::set_is_exec_point_at)
1830         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1831         (tui_alloc_source_buffer, tui_line_is_displayed)
1832         (tui_addr_is_displayed): Change type of win_info.  Update.
1833         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1834         (tui_source_window_base::do_make_visible_with_new_height):
1835         Update.
1836         * tui/tui-source.c (tui_set_source_content)
1837         (tui_set_source_content_nil)
1838         (tui_source_window::do_scroll_vertical): Update.
1839         * tui/tui-layout.c (show_layout): Update.
1840         * tui/tui-disasm.c (tui_set_disassem_content)
1841         (tui_disasm_window::do_scroll_vertical): Update.
1842         * tui/tui-data.h (tui_win_content): Remove.
1843         (struct tui_gen_win_info) <content, content_size>: Remove.
1844         (struct tui_source_element): Add initializers and destructor.
1845         (union tui_which_element, struct tui_win_element): Remove.
1846         (struct tui_source_window_base) <content>: New field.
1847         (struct tui_data_window): Remove destructor.
1848         (tui_alloc_content, tui_free_win_content)
1849         (tui_free_all_source_wins_content): Don't declare.
1850         * tui/tui-data.c (tui_initialize_static_data): Update.
1851         (init_content_element, tui_alloc_content): Remove.
1852         (~tui_gen_win_info): Update.
1853         (~tui_data_window, tui_free_all_source_wins_content)
1854         (tui_free_win_content, free_content, free_content_elements):
1855         Remove.
1856
1857 2019-06-25  Tom Tromey  <tom@tromey.com>
1858
1859         * tui/tui-winsource.h (tui_clear_source_content)
1860         (tui_erase_source_content, tui_show_source_content): Change type
1861         of win_info.
1862         * tui/tui-winsource.c (tui_clear_source_content)
1863         (tui_erase_source_content, tui_show_source_content): Change type
1864         of win_info.
1865         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1866         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1867         win_info.
1868         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1869         win_info.
1870         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1871
1872 2019-06-25  Tom Tromey  <tom@tromey.com>
1873
1874         * tui/tui-winsource.c (tui_clear_source_content)
1875         (tui_source_window_base::set_is_exec_point_at): Update.
1876         * tui/tui-source.c (tui_set_source_content_nil): Update.
1877         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1878         a bool.
1879         * tui/tui-data.c (init_content_element): Update.
1880
1881 2019-06-25  Tom Tromey  <tom@tromey.com>
1882
1883         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1884         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1885         * tui/tui-layout.c (init_and_make_win): Update.
1886         * tui/tui.h (enum tui_win_type): Update.
1887         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1888         tui_win_is_auxillary.
1889         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1890         tui_win_is_auxillary.
1891
1892 2019-06-25  Tom Tromey  <tom@tromey.com>
1893
1894         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1895         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1896         (tui_delete_data_content_windows, tui_display_all_data)
1897         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1898         Update.
1899         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1900         * tui/tui-regs.c (tui_last_regs_line_no)
1901         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1902         (tui_show_registers): Update.
1903         (tui_show_register_group): Return void.  Update.
1904         (tui_display_registers_from, tui_display_reg_element_at_line)
1905         (tui_display_registers_from_line, tui_check_register_values):
1906         Update.
1907         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1908         member.
1909         (struct tui_data_window) <regs_content>: Now a std::vector.
1910         <regs_content_count>: Remove.
1911         (tui_add_content_elements, tui_free_data_content): Don't declare.
1912         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1913         (init_content_element): Remove DATA_WIN case.  Add assert.
1914         (tui_add_content_elements): Remove.
1915         (tui_data_window): Update.
1916         (tui_free_data_content): Remove.
1917         (free_content_elements): Remove DATA_WIN case.
1918
1919 2019-06-25  Tom Tromey  <tom@tromey.com>
1920
1921         * tui/tui-data.c (tui_data_item_window): Update.
1922         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1923         * tui/tui-windata.c (tui_display_all_data)
1924         (tui_display_data_from_line): Update.
1925         (tui_check_data_values): Remove.
1926         * tui/tui-regs.c (tui_show_register_group)
1927         (tui_display_reg_element_at_line): Update.
1928         * tui/tui-hooks.c (tui_register_changed)
1929         (tui_refresh_frame_and_register_information): Call
1930         tui_check_register_values.
1931         * tui/tui-data.h (struct tui_data_window) <data_content,
1932         data_content_count, data_type>: Remove.
1933         (enum tui_data_type): Remove.
1934
1935         * tui/tui-data.c (tui_data_window::clear_detail)
1936         (~tui_data_window): Update.
1937
1938 2019-06-25  Tom Tromey  <tom@tromey.com>
1939
1940         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1941         declare.
1942         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1943         Rename from tui_first_data_item_displayed.  Update.
1944         (tui_data_window::refresh_all)
1945         (tui_data_window::do_scroll_vertical): Update.
1946         * tui/tui-data.h (struct tui_data_window)
1947         <first_data_item_displayed>: Declare new method.
1948
1949 2019-06-25  Tom Tromey  <tom@tromey.com>
1950
1951         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1952         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1953         contents...
1954         (tui_initialize_static_data): ...here.
1955
1956 2019-06-25  Tom Tromey  <tom@tromey.com>
1957
1958         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1959         (tui_display_registers_from, tui_check_register_values): Update.
1960         (tui_display_register): Remove win_info parameter; update.
1961         (tui_get_register): Change type of parameters.
1962         * tui/tui-data.h (struct tui_data_element): Remove.
1963         (union tui_which_element) <data>: Remove.
1964         <data_window>: Change type.
1965         (struct tui_data_item_window): New.
1966         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1967         case.  Add assert.
1968         (~tui_data_item_window): New destructor.
1969         (free_content_elements): Remove DATA_ITEM_WIN case.
1970
1971 2019-06-25  Tom Tromey  <tom@tromey.com>
1972
1973         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1974         Remove.
1975
1976 2019-06-25  Tom Tromey  <tom@tromey.com>
1977
1978         * tui/tui-data.h (struct tui_command_element): Remove.
1979         (union tui_which_element) <command>: Remove.
1980         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1981         assert.
1982         (free_content_elements): Remove CMD_WIN case.
1983
1984 2019-06-25  Tom Tromey  <tom@tromey.com>
1985
1986         * tui/tui-layout.c (tui_set_layout): Update.
1987         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1988         * tui/tui-data.c (layout_def): Update.
1989
1990 2019-06-25  Tom Tromey  <tom@tromey.com>
1991
1992         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1993         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1994         (tui_source_window_base::set_new_height): Update.
1995         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1996         Update.
1997         (tui_set_locator_fullname, tui_set_locator_info)
1998         (tui_show_frame_info): Update.
1999         * tui/tui-source.c (tui_set_source_content)
2000         (tui_source_is_displayed): Update.
2001         * tui/tui-layout.c (show_source_disasm_command, show_data)
2002         (show_source_or_disasm_and_command): Update.
2003         * tui/tui-disasm.c (tui_set_disassem_content)
2004         (tui_get_begin_asm_address): Update.
2005         * tui/tui-data.h (struct tui_locator_element): Remove.
2006         (union tui_which_element) <locator>: Remove.
2007         (struct tui_locator_window): New.
2008         (tui_locator_win_info_ptr): Change return type.
2009         * tui/tui-data.c (_locator): Change type.
2010         (tui_locator_win_info_ptr): Change return type.
2011         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2012         (tui_alloc_content): Add assert.
2013
2014 2019-06-25  Tom Tromey  <tom@tromey.com>
2015
2016         * tui/tui-winsource.c
2017         (tui_exec_info_window::maybe_allocate_content): New method.
2018         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2019         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2020         (make_source_or_disasm_window): Add cast.
2021         * tui/tui-data.h (union tui_which_element) <simple_string>:
2022         Remove.
2023         (struct tui_source_info): New.
2024         (struct tui_source_window_base) <execution_info>: Change type.
2025         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2026         case, and add assert.
2027         (tui_alloc_content): Add assert.
2028
2029 2019-06-25  Tom Tromey  <tom@tromey.com>
2030
2031         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2032         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2033         * tui/tui-data.c (tui_alloc_win_info): Remove.
2034
2035 2019-06-25  Tom Tromey  <tom@tromey.com>
2036
2037         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2038         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2039         can_highlight.
2040
2041 2019-06-25  Tom Tromey  <tom@tromey.com>
2042
2043         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2044         make_visible_with_new_height method.
2045         (tui_win_info::make_visible_with_new_height): New method.
2046         (tui_source_window_base::do_make_visible_with_new_height)
2047         (tui_data_window::do_make_visible_with_new_height)
2048         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2049         (make_visible_with_new_height): Remove.
2050         (tui_resize_all, tui_adjust_win_heights): Use
2051         make_visible_with_new_height method.
2052         * tui/tui-data.h (struct tui_win_info)
2053         <do_make_visible_with_new_height, make_visible_with_new_height>:
2054         New methods.
2055         (struct tui_source_window_base, struct tui_data_window)
2056         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2057         methods.
2058
2059 2019-06-25  Tom Tromey  <tom@tromey.com>
2060
2061         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2062         method.
2063         (update_tab_width): Call update_tab_width method.
2064         * tui/tui-data.h (struct tui_win_info)
2065         (struct tui_source_window_base) <update_tab_width>: New methods.
2066
2067 2019-06-25  Tom Tromey  <tom@tromey.com>
2068
2069         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2070         parameter.
2071         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2072         parameter.
2073         (tui_gen_win_info::make_visible): Update.
2074         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2075         parameter.
2076         * tui/tui-data.h (enum tui_box): New enum.
2077         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2078
2079 2019-06-25  Tom Tromey  <tom@tromey.com>
2080
2081         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2082         init_and_make_win for EXEC_INFO_WIN.
2083         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2084         longer inline.
2085         (struct tui_win_info) <~tui_win_info>: Inline.
2086         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2087         Don't declare.
2088         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2089         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2090         Remove.
2091         (tui_initialize_static_data): Update.
2092         (~tui_gen_win_info): Handle more cleanup here.
2093         (~tui_source_window_base): Delete "execution_info".
2094         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2095
2096 2019-06-25  Tom Tromey  <tom@tromey.com>
2097
2098         * tui/tui-layout.c (make_command_window): Don't set
2099         can_highlight.
2100         (show_source_disasm_command): Call the reset method.
2101         (show_data): Don't set can_highlight.  Call the reset method.
2102         (tui_gen_win_info::reset): Rename from init_gen_win_info
2103         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2104         (show_source_or_disasm_and_command): Call the reset method.
2105         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2106         (struct tui_cmd_window): Set can_highlight.
2107
2108 2019-06-25  Tom Tromey  <tom@tromey.com>
2109
2110         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2111         from make_visible.
2112         (tui_make_visible, tui_make_invisible): Rewrite.
2113         (tui_win_info::make_visible): Remove.
2114         (tui_source_window_base::make_visible): Update.
2115         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2116         method.  Moved from...
2117         (struct tui_win_info) <make_visible>: ...here.
2118
2119 2019-06-25  Tom Tromey  <tom@tromey.com>
2120
2121         * tui/tui-winsource.c
2122         (tui_source_window_base::do_scroll_horizontal): Remove direction
2123         parameter.
2124         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2125         direction parameter.
2126         * tui/tui-win.c (tui_win_info::forward_scroll)
2127         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2128         (tui_win_info::right_scroll): Update.
2129         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2130         direction parameter.
2131         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2132         direction parameter.
2133         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2134         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2135         Remove direction parameter.
2136         (struct tui_source_window_base, struct tui_source_window)
2137         (struct tui_disasm_window, struct tui_data_window)
2138         (struct tui_cmd_window): Update.
2139
2140 2019-06-25  Tom Tromey  <tom@tromey.com>
2141
2142         * tui/tui-winsource.h (tui_set_exec_info_content)
2143         (tui_show_exec_info_content, tui_erase_exec_info_content)
2144         (tui_clear_exec_info_content, tui_update_exec_info): Change
2145         argument to tui_source_window_base.
2146         * tui/tui-winsource.c (tui_set_exec_info_content)
2147         (tui_show_exec_info_content, tui_erase_exec_info_content)
2148         (tui_clear_exec_info_content, tui_update_exec_info): Change
2149         argument to tui_source_window_base.
2150
2151 2019-06-25  Tom Tromey  <tom@tromey.com>
2152
2153         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2154         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2155
2156 2019-06-25  Tom Tromey  <tom@tromey.com>
2157
2158         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2159         check.
2160
2161 2019-06-25  Tom Tromey  <tom@tromey.com>
2162
2163         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2164         type to void.
2165         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2166         type to void.
2167         * tui/tui-source.c (tui_set_source_content): Update.
2168         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2169
2170 2019-06-25  Tom Tromey  <tom@tromey.com>
2171
2172         * tui/tui-win.c (window_name_completer, tui_set_focus)
2173         (tui_all_windows_info): Use name method.
2174         * tui/tui-data.h (struct tui_gen_win_info)
2175         (struct tui_source_window, struct tui_disasm_window)
2176         (struct tui_data_window, struct tui_cmd_window) <name>: New
2177         method.
2178         (tui_win_name): Don't declare.
2179         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2180         (tui_win_name): Remove.
2181
2182 2019-06-25  Tom Tromey  <tom@tromey.com>
2183
2184         * tui/tui-winsource.h (tui_update_source_window)
2185         (tui_update_source_window_as_is): Change parameter type.
2186         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2187         to be a tui_source_window_base.
2188         (tui_update_source_window_as_is): Likewise.
2189         * tui/tui-win.c (make_visible_with_new_height): Update.
2190
2191 2019-06-25  Tom Tromey  <tom@tromey.com>
2192
2193         * tui/tui-winsource.c (tui_erase_source_content)
2194         (tui_show_source_content, tui_show_exec_info_content)
2195         (tui_erase_exec_info_content): Use refresh_window method.
2196         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2197         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2198         from tui_refresh_win.
2199         (tui_data_window::refresh_window): New method.
2200         (tui_win_info::refresh, tui_source_window_base::refresh)
2201         (tui_refresh_all): Use refresh_window method.
2202         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2203         method.
2204         * tui/tui-regs.c (tui_display_register): Call refresh_window
2205         method.
2206         * tui/tui-layout.c (show_source_disasm_command)
2207         (show_source_or_disasm_and_command): Call refresh_window method.
2208         * tui/tui-data.h (struct tui_gen_win_info)
2209         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2210         New method.
2211
2212 2019-06-25  Tom Tromey  <tom@tromey.com>
2213
2214         * tui/tui.c (tui_rl_other_window, tui_enable)
2215         (tui_is_window_visible, tui_get_command_dimension): Update.
2216         * tui/tui-winsource.c (tui_update_source_window_as_is)
2217         (tui_clear_source_content, tui_erase_source_content)
2218         (tui_show_source_line, tui_source_window_base::refill)
2219         (tui_source_window_base::do_scroll_horizontal)
2220         (tui_source_window_base::set_is_exec_point_at)
2221         (tui_update_breakpoint_info, tui_set_exec_info_content)
2222         (tui_alloc_source_buffer, tui_line_is_displayed)
2223         (tui_addr_is_displayed): Update.
2224         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2225         (tui_check_and_display_highlight_if_needed)
2226         (tui_win_info::make_visible, tui_win_info::refresh)
2227         (tui_refresh_all): Update.
2228         * tui/tui-windata.c (tui_first_data_item_displayed)
2229         (tui_delete_data_content_windows, tui_erase_data_content)
2230         (tui_display_all_data, tui_data_window::refresh_all)
2231         (tui_check_data_values): Update.
2232         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2233         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2234         (tui_win_info::backward_scroll, tui_refresh_all_win)
2235         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2236         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2237         (tui_source_window_base::set_new_height)
2238         (tui_data_window::set_new_height)
2239         (make_invisible_and_set_new_height)
2240         (make_visible_with_new_height, new_height_ok)
2241         (parse_scrolling_args): Update.
2242         * tui/tui-stack.c (tui_show_frame_info): Update.
2243         * tui/tui-source.c (tui_set_source_content)
2244         (tui_set_source_content_nil, tui_source_is_displayed)
2245         (tui_source_window::do_scroll_vertical): Update.
2246         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2247         (tui_display_registers_from, tui_display_reg_element_at_line)
2248         (tui_check_register_values, tui_reg_command): Update.
2249         * tui/tui-layout.c (tui_default_win_height)
2250         (show_source_disasm_command, show_data, init_and_make_win)
2251         (show_source_or_disasm_and_command): Update.
2252         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2253         (tui_redisplay_readline, tui_mld_flush)
2254         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2255         (tui_getc): Update.
2256         * tui/tui-disasm.c (tui_set_disassem_content)
2257         (tui_disasm_window::do_scroll_vertical): Update.
2258         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2259         Now virtual.
2260         (struct tui_win_info): Derive from tui_gen_win_info.
2261         <~tui_win_info>: Mark as override.
2262         <generic>: Remove member.
2263         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2264         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2265         (~tui_data_window, ~tui_win_info)
2266         (tui_free_all_source_wins_content): Update.
2267         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2268
2269 2019-06-25  Tom Tromey  <tom@tromey.com>
2270
2271         * tui/tui-layout.c (init_and_make_win): Use new.
2272         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2273         destructor, initializers.
2274         (tui_alloc_generic_win_info): Don't declare.
2275         * tui/tui-data.c (_locator): Add argument to constructor.
2276         (source_win, disasm_win): New globals.
2277         (exec_info): Remove.
2278         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2279         Update.
2280         (tui_alloc_generic_win_info): Remove.
2281         (init_content_element): Use new.
2282         (tui_win_info::tui_win_info): Update.
2283         (free_content_elements) <case DATA_WIN>: Use delete.
2284
2285 2019-06-25  Tom Tromey  <tom@tromey.com>
2286
2287         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2288         * tui/tui-windata.c (tui_first_data_item_displayed)
2289         (tui_delete_data_content_windows): Update.
2290         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2291         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2292         (tui_display_registers_from, tui_check_register_values): Update.
2293         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2294         pointer.
2295         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2296         window.
2297         (tui_free_data_content): Update.
2298         (free_content_elements) <case DATA_WIN>: Free the window.
2299
2300 2019-06-25  Tom Tromey  <tom@tromey.com>
2301
2302         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2303         Update.
2304         * tui/tui-layout.c (make_command_window)
2305         (show_source_disasm_command, show_data, init_and_make_win)
2306         (show_source_or_disasm_and_command): Update.
2307         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2308         method.
2309         <can_highight, is_highlighted>: Now bool.
2310         (tui_set_win_highlight): Don't declare.
2311         * tui/tui-data.c (tui_set_win_highlight): Remove.
2312
2313 2019-06-25  Tom Tromey  <tom@tromey.com>
2314
2315         * tui/tui-wingeneral.c (make_visible): Remove check of window
2316         type.
2317
2318 2019-06-25  Tom Tromey  <tom@tromey.com>
2319
2320         * tui/tui-win.c (tui_win_info::max_height)
2321         (tui_cmd_window::max_height): New methods.
2322         (new_height_ok): Call max_height.
2323         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2324         <max_height>: New method.
2325
2326 2019-06-25  Tom Tromey  <tom@tromey.com>
2327
2328         * tui/tui-win.c (tui_source_window_base::set_new_height)
2329         (tui_data_window::set_new_height): New methods.
2330         (make_invisible_and_set_new_height): Call set_new_height method.
2331         * tui/tui-data.h (struct tui_win_info)
2332         (struct tui_source_window_base, struct tui_data_window)
2333         <set_new_height>: New method.
2334
2335 2019-06-25  Tom Tromey  <tom@tromey.com>
2336
2337         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2338         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2339         tui_refresh_data_win.
2340         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2341         method.
2342         (tui_refresh_all_win): Call the refresh_all method.
2343         (tui_set_focus): Likewise.
2344         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2345         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2346         Likewise.
2347
2348 2019-06-25  Tom Tromey  <tom@tromey.com>
2349
2350         * tui/tui-winsource.h (tui_refill_source_window)
2351         (tui_set_is_exec_point_at): Don't declare.
2352         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2353         (tui_source_window_base::refill): Rename from
2354         tui_refill_source_window.
2355         (tui_source_window_base::do_scroll_horizontal): Update.
2356         (tui_source_window_base::set_is_exec_point_at): Rename from
2357         tui_set_is_exec_point_at.
2358         (tui_update_all_breakpoint_info): Update.
2359         * tui/tui-stack.c (tui_show_frame_info): Update.
2360         * tui/tui-layout.c (show_data): Add cast.
2361         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2362         * tui/tui-data.h (struct tui_source_window_base) <refill,
2363         set_is_exec_point_at>: New methods.
2364         (tui_source_windows, tui_add_to_source_windows): Update types.
2365         (tui_add_to_source_windows): Remove redundant declaration.
2366         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2367         (tui_source_windows): Change return type.
2368         (tui_clear_source_windows_detail): Update.
2369         (tui_add_to_source_windows): Change type of parameter.
2370         (tui_free_all_source_wins_content): Update.
2371
2372 2019-06-25  Tom Tromey  <tom@tromey.com>
2373
2374         * tui/tui-wingeneral.c (tui_win_info::refresh)
2375         (tui_source_window_base::refresh): New methods.
2376         (tui_refresh_all): Call the refresh method.
2377         * tui/tui-data.h (struct tui_win_info)
2378         (struct tui_source_window_base) <refresh>: New method.
2379
2380 2019-06-25  Tom Tromey  <tom@tromey.com>
2381
2382         * tui/tui.h (tui_is_window_visible): Return bool.
2383         * tui/tui.c (tui_is_window_visible): Return bool.
2384         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2385         (tui_make_visible, tui_make_invisible)
2386         (tui_win_info::make_visible)
2387         (tui_source_window_base::make_visible, make_all_visible)
2388         (tui_make_all_visible, tui_make_all_invisible): Update.
2389         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2390         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2391         bool.
2392         (struct tui_win_info, struct tui_source_window_base)
2393         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2394         * tui/tui-data.c (tui_init_generic_part): Update.
2395
2396 2019-06-25  Tom Tromey  <tom@tromey.com>
2397
2398         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2399         (tui_source_window_base::make_visible): New methods.
2400         (make_all_visible): Make method call.
2401         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2402         (struct tui_source_window_base, struct tui_cmd_window): Override
2403         make_visible.
2404         (tui_win_is_source_type): Don't declare.
2405         * tui/tui-data.c (tui_win_is_source_type): Remove.
2406
2407 2019-06-25  Tom Tromey  <tom@tromey.com>
2408
2409         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2410         NULL check.
2411
2412 2019-06-25  Tom Tromey  <tom@tromey.com>
2413
2414         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2415         Inline constructor.  Add initializers for members.
2416         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2417         constructors; now inline in class.
2418
2419 2019-06-25  Tom Tromey  <tom@tromey.com>
2420
2421         * tui/tui-regs.c (tui_show_registers): Update.
2422         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2423         bool.
2424         * tui/tui-data.c (tui_data_window::clear_detail)
2425         (tui_data_window): Update.
2426
2427 2019-06-25  Tom Tromey  <tom@tromey.com>
2428
2429         * tui/tui-windata.c (tui_display_all_data)
2430         (tui_display_data_from_line, tui_display_data_from)
2431         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2432         Update.
2433         * tui/tui-regs.c (tui_last_regs_line_no)
2434         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2435         (tui_show_registers, tui_show_register_group)
2436         (tui_display_registers_from, tui_display_reg_element_at_line)
2437         (tui_display_registers_from_line, tui_check_register_values)
2438         (tui_reg_next, tui_reg_prev): Update.
2439         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2440         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2441         tui_data_window.
2442         (struct tui_win_info) <detail>: Remove.  Add new fields from
2443         tui_data_info.
2444         (TUI_DATA_WIN): Add cast.
2445         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2446         (~tui_data_window): Simplify.
2447
2448 2019-06-25  Tom Tromey  <tom@tromey.com>
2449
2450         * tui/tui-layout.c (show_source_disasm_command)
2451         (show_source_or_disasm_and_command): Update.
2452         * tui/tui-io.c (update_cmdwin_start_line)
2453         (tui_redisplay_readline): Update.
2454         * tui/tui-data.h (struct tui_command_info): Remove.
2455         (struct tui_win_info) <detail>: Remove command_info member.
2456         (struct tui_data_window) <start_line>: New member, from
2457         tui_command_info.
2458         (TUI_CMD_WIN): Add casts.
2459
2460 2019-06-25  Tom Tromey  <tom@tromey.com>
2461
2462         * tui/tui-winsource.c (tui_update_source_window)
2463         (tui_refill_source_window)
2464         (tui_source_window_base::do_scroll_horizontal)
2465         (tui_update_breakpoint_info, tui_set_exec_info_content)
2466         (tui_show_exec_info_content, tui_erase_exec_info_content)
2467         (tui_clear_exec_info_content): Update.
2468         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2469         Update.
2470         * tui/tui-win.c (make_invisible_and_set_new_height)
2471         (make_visible_with_new_height): Update.
2472         * tui/tui-source.c (tui_set_source_content)
2473         (tui_show_symtab_source): Update.
2474         * tui/tui-layout.c (extract_display_start_addr)
2475         (show_source_disasm_command, show_data)
2476         (make_source_or_disasm_window)
2477         (show_source_or_disasm_and_command): Update.
2478         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2479         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2480         "gdbarch".
2481         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2482         to tui_source_window_base.
2483         (struct tui_win_info) <detail>: Remove source_info member.
2484         (struct tui_source_window_base) <has_locator>: Inline.
2485         Move contents from tui_source_info; rename has_locator member to
2486         m_has_locator.
2487         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2488         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2489         header file.
2490         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2491         Simplify.
2492         (tui_free_all_source_wins_content): Cast to
2493         tui_source_window_base.
2494
2495 2019-06-25  Tom Tromey  <tom@tromey.com>
2496
2497         * tui/tui-win.c (make_invisible_and_set_new_height)
2498         (make_visible_with_new_height): Call has_locator method.
2499         * tui/tui-layout.c (show_source_disasm_command, show_data)
2500         (show_source_or_disasm_and_command): Update for bool change.
2501         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2502         (tui_win_info) <has_locator>: New method.
2503         (struct tui_source_window_base) <has_locator>: New method.
2504         (tui_win_has_locator): Don't declare.
2505         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2506         from tui_win_has_locator.
2507         (tui_source_window_base): Use false, not FALSE.
2508
2509 2019-06-25  Tom Tromey  <tom@tromey.com>
2510
2511         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2512         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2513         clear_detail method directly.
2514         (tui_clear_win_detail): Remove.
2515
2516 2019-06-25  Tom Tromey  <tom@tromey.com>
2517
2518         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2519         "this", not TUI_DISASM_WIN.
2520
2521 2019-06-25  Tom Tromey  <tom@tromey.com>
2522
2523         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2524         declare.
2525         * tui/tui-winsource.c
2526         (tui_source_window_base::do_scroll_horizontal): Rename from
2527         tui_horizontal_source_scroll.
2528         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2529         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2530         from tui_vertical_data_scroll.
2531         * tui/tui-win.h (tui_scroll): Don't declare.
2532         * tui/tui-win.c (tui_win_info::forward_scroll)
2533         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2534         (tui_win_info::right_scroll): Rename and update.
2535         (tui_scroll_forward_command, tui_scroll_backward_command)
2536         (tui_scroll_left_command, tui_scroll_right_command): Update.
2537         (tui_scroll): Remove.
2538         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2539         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2540         from tui_vertical_source_scroll.
2541         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2542         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2543         from tui_vertical_disassem_scroll.
2544         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2545         do_scroll_horizontal>: New methods.
2546         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2547         Likewise.
2548         (struct tui_source_window_base): Add do_scroll_horizontal.
2549         (struct tui_source_window, struct tui_disasm_window): Add
2550         do_scroll_vertical.
2551         (struct tui_data_window, struct tui_cmd_window): Add
2552         do_scroll_horizontal and do_scroll_vertical.
2553         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2554
2555 2019-06-25  Tom Tromey  <tom@tromey.com>
2556
2557         * tui/tui-data.h (struct tui_source_window_base): New struct.
2558         (struct tui_source_window): Derive from tui_source_window_base.
2559         (struct tui_disasm_window): New struct.
2560         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2561         from tui_source_window::clear_detail.
2562         (tui_source_window_base): Rename from tui_source_window.
2563         (~tui_source_window_base): Rename from ~tui_source_window.
2564         (tui_alloc_win_info): Create a tui_disasm_window.
2565
2566 2019-06-25  Tom Tromey  <tom@tromey.com>
2567
2568         * tui/tui-data.h (struct tui_source_window)
2569         (struct tui_data_window): Declare destructors.
2570         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2571         destructors.
2572         (tui_win_info): Simplify.
2573
2574 2019-06-25  Tom Tromey  <tom@tromey.com>
2575
2576         * tui/tui-winsource.c (tui_display_main)
2577         (tui_update_source_windows_with_addr)
2578         (tui_update_all_breakpoint_info): Update.
2579         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2580         (new_height_ok, parse_scrolling_args): Update.
2581         * tui/tui-stack.c (tui_show_frame_info): Update.
2582         * tui/tui-data.h (struct tui_list): Remove.
2583         (tui_source_windows): Return a reference to a std::vector.
2584         * tui/tui-data.c (source_windows): Now a std::vector.
2585         (tui_source_windows): Change return type.
2586         (tui_clear_source_windows): Rewrite.
2587         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2588         (tui_free_all_source_wins_content): Rewrite.
2589
2590 2019-06-25  Tom Tromey  <tom@tromey.com>
2591
2592         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2593         (struct tui_data_window, struct tui_cmd_window): Declare
2594         clear_detail method.
2595         * tui/tui-data.c (tui_source_window::clear_detail)
2596         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2597         methods.
2598         (tui_clear_win_detail): Simplify.
2599
2600 2019-06-25  Tom Tromey  <tom@tromey.com>
2601
2602         * tui/tui-layout.c (make_source_window, make_disasm_window)
2603         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2604         Return the new window.
2605         (show_source_disasm_command, show_data)
2606         (show_source_or_disasm_and_command): Update.
2607
2608 2019-06-25  Tom Tromey  <tom@tromey.com>
2609
2610         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2611         parameter.  Return the new window.
2612         (show_source_disasm_command): Update and remove NULL check.
2613         (show_source_or_disasm_and_command): Update.
2614
2615 2019-06-25  Tom Tromey  <tom@tromey.com>
2616
2617         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2618
2619 2019-06-25  Tom Tromey  <tom@tromey.com>
2620
2621         * tui/tui-data.h (struct tui_win_info): Make constructor
2622         protected.  Make destructor virtual.  Add initializers.
2623         (tui_source_window, tui_data_window, tui_cmd_window): New
2624         classes.
2625         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2626         constructor.  Add "type" parameter.
2627         (tui_source_window, tui_data_window, tui_cmd_window): New
2628         constructors.
2629         (tui_alloc_win_info): Instantiate the appropriate subclass.
2630
2631 2019-06-25  Tom Tromey  <tom@tromey.com>
2632
2633         * tui/tui-win.c (tui_resize_all): Use delete.
2634         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2635         destructor.
2636         (tui_free_window): Don't declare.
2637         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2638         Update.
2639
2640 2019-06-25  Tom Tromey  <tom@tromey.com>
2641
2642         * tui/tui-data.h (struct tui_win_info): Add constructor.
2643         * tui/tui-data.c (tui_alloc_win_info): Use new.
2644         (tui_free_window): Use delete.
2645
2646 2019-06-22  Tom Tromey  <tom@tromey.com>
2647
2648         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2649         declare.
2650         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2651
2652 2019-06-22  Tom Tromey  <tom@tromey.com>
2653
2654         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2655         declare.
2656         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2657
2658 2019-06-22  Tom de Vries  <tdevries@suse.de>
2659
2660         * dwarf2read.c (create_addrmap_from_aranges)
2661         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2662         instead of '%zu'.
2663
2664 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2665
2666         * dwarf2read.h (dwarf2_section_info_def): Remove.
2667         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2668         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2669         std::vector<dwarf2_section_info>.
2670         (struct dwo_file) <~dwo_file>: Remove.
2671         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2672         types field.
2673         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2674         (dwarf2_read_debug_names): Likewise.
2675         (create_debug_types_hash_table): Change parameter type to
2676         array_view, adjust code accordingly.
2677         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2678         (partial_die_info::fixup): Likewise.
2679         (determine_prefix): Likewise.
2680         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2681
2682 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2683
2684         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2685         gdb_bfd_ref_ptr.
2686         <~dwo_file>: Remove call to gdb_bfd_unref.
2687         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2688         gdb_bfd_ref_ptr::get.
2689
2690 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2691
2692         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2693         type to htab_up.
2694         * dwarf2read.c (struct dwo_file): Initialize fields.
2695         <~dwo_file>: New.
2696         (free_dwo_file): Remove, move content to ~dwo_file.
2697         (struct dwo_file_deleter): Remove.
2698         (dwo_file_up>: Remove custom deleter.
2699         (free_dwo_files): Remove.
2700         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2701         dwo_files.
2702         (process_skeletonless_type_units): Call unique_ptr::get.
2703         (allocate_dwo_file_hash_table): Add deleter to created hash
2704         table.  Change return type to htab_up.
2705         (lookup_dwo_file_slot): Don't memset dwo_file, call
2706         unique_ptr::get.
2707         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2708         (create_dwo_unit_in_dwp_v2): Likewise.
2709         (open_and_init_dwo_file): Likewise.
2710         (free_dwo_file_from_slot): Remove.
2711
2712 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2713
2714         * dwarf2read.h (struct dwarf2_section_info) <readin,
2715         is_virtual>: Change type to bool.
2716         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2717         true instead of 1.
2718
2719 2019-06-19  Tom Tromey  <tom@tromey.com>
2720
2721         * tui/tui-data.h (tui_init_content_element): Don't declare.
2722
2723 2019-06-19  Tom Tromey  <tom@tromey.com>
2724
2725         * tui/tui-data.h (tui_init_win_info): Don't declare.
2726
2727 2019-06-19  Tom de Vries  <tdevries@suse.de>
2728
2729         * dwarf2read.h (abstract_to_concrete): Change type to
2730         std::unordered_map<sect_offset, std::vector<sect_offset>,
2731         gdb::hash_enum<sect_offset>>.
2732
2733 2019-06-19  Tom Tromey  <tromey@adacore.com>
2734
2735         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2736         EVAL_AVOID_SIDE_EFFECTS specially.
2737
2738 2019-06-19  Tom Tromey  <tromey@adacore.com>
2739
2740         * source-cache.c (highlighter): New global.
2741         (source_cache::get_source_lines): Create a highlighter on demand.
2742
2743 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2744
2745         * defs.h (deprecated_interactive_hook): Delete declaration.
2746         * interps.c (clear_interpreter_hooks): Remove use of
2747         deprecated_interactive_hook.
2748         * top.c (deprecated_interactive_hook): Delete definition.
2749         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2750
2751 2019-06-18  Tom de Vries  <tdevries@suse.de>
2752
2753         PR gdb/24515
2754         * dwarf2read.h (abstract_to_concrete): Change type from
2755         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2756         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2757         * dwarf2read.c (read_variable): Update.
2758         (dwarf2_fetch_die_loc_sect_off): Update.
2759
2760 2019-06-17  Tom de Vries  <tdevries@suse.de>
2761
2762         PR gdb/24617
2763         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2764         accessing parent[parent_len - 1].
2765
2766 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2767
2768         PR gdb/24364
2769         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2770         call dtrace_process_dof with NULL dof.
2771
2772 2019-06-16  Tom de Vries  <tdevries@suse.de>
2773
2774         PR gdb/24445
2775         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2776
2777 2019-06-16  Tom Tromey  <tom@tromey.com>
2778
2779         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2780         (make_all_visible): Use address of member.
2781
2782 2019-06-16  Tom Tromey  <tom@tromey.com>
2783
2784         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2785         (tui_free_window, free_content, free_content_elements): Remove
2786         unnecessary cast.
2787         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2788         cast.
2789         * tui/tui-regs.c (tui_show_register_group)
2790         (tui_display_registers_from, tui_display_reg_element_at_line):
2791         Remove unnecessary cast.
2792
2793 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2794
2795         * linux-nat.c (normal_mask): Delete.
2796         (_initialize_linux_nat): Don't initialise normal_mask.
2797
2798 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2799
2800         PR gdb/24445
2801         * dwarf-index-write.h (write_psymtabs_to_index): Add
2802         dwz_basename parameter.
2803         * dwarf-index-write.c (write_gdbindex): Move file writing to
2804         write_gdbindex_1.  Change return type void.
2805         (assert_file_size): Move up, remove filename parameter.
2806         (write_gdbindex_1): New function.
2807         (write_debug_names): Change return type to void, call
2808         assert_file_size.
2809         (struct index_wip_file): New struct.
2810         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2811         file logic to index_wip_file.  Write index for dwz file if
2812         needed.
2813         (save_gdb_index_command): Pass basename of dwz file, if present.
2814         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2815         build-id of dwz file, if present.
2816         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2817         (dwarf2_get_dwz_file): Likewise.
2818         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2819         (dwarf2_get_dwz_file): Likewise.
2820
2821 2019-06-16  Tom Tromey  <tom@tromey.com>
2822
2823         * coffread.c (process_coff_symbol): Use xstrdup.
2824         * value.c (create_internalvar): Use xstrdup.
2825
2826 2019-06-16  Tom Tromey  <tom@tromey.com>
2827
2828         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2829         * breakpoint.c (stopin_command, stopat_command)
2830         (until_break_command, decode_location_default): Remove unnecessary
2831         cast.
2832         * utils.c (subset_compare): Remove unnecessary cast.
2833         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2834         cast.
2835         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2836         cast.
2837         * infcmd.c (path_command): Remove unnecessary cast.
2838         * coffread.c (decode_type): Remove unnecessary cast.
2839         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2840         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2841         * tui/tui-stack.c (tui_show_locator_content)
2842         (tui_show_frame_info): Remove unnecessary cast.
2843         * tui/tui-win.c (tui_scroll_forward_command)
2844         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2845         (parse_scrolling_args): Remove unnecessary cast.
2846         * tui/tui-data.c (init_win_info, tui_del_window)
2847         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2848         (free_content_elements): Remove unnecessary cast.
2849         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2850         unnecessary cast.
2851         * tui/tui-source.c (tui_set_source_content)
2852         (tui_vertical_source_scroll): Remove unnecessary cast.
2853         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2854         cast.
2855         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2856         * tui/tui-regs.c (tui_display_registers_from)
2857         (tui_display_register): Remove unnecessary cast.
2858         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2859         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2860         (make_visible): Remove unnecessary cast.
2861         * tui/tui-winsource.c (tui_erase_source_content)
2862         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2863         unnecessary cast.
2864         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2865         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2866         * stabsread.c (read_type, read_array_type, read_range_type):
2867         Remove unnecessary cast.
2868         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2869         (parse_symbol, parse_type, upgrade_type, parse_external)
2870         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2871         unnecessary cast.
2872         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2873
2874 2019-06-16  Tom Tromey  <tom@tromey.com>
2875
2876         * tui/tui-data.c (tui_alloc_generic_win_info)
2877         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2878         checks.
2879
2880 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2881             Andrew Burgess  <andrew.burgess@embecosm.com>
2882
2883         * f-typeprint.c (f_print_type): Don't return early for not
2884         associated or not allocated types.
2885         (f_type_print_varspec_suffix): Add print_rank parameter and print
2886         ranks of array types in case they dangling.
2887         (f_type_print_base): Add print_rank parameter.
2888
2889 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2890
2891         * NEWS: Mention new MI commands.
2892         * break-catch-throw.c (enum exception_event_kind): Move to
2893         breakpoint.h.
2894         (print_mention_exception_catchpoint): Output text as a single
2895         message.
2896         (catch_exception_command_1): Rename to...
2897         (catch_exception_event): ...this, make non-static, update header
2898         command, and change some parameter types.
2899         (catch_catch_command): Update for changes to
2900         catch_exception_command_1.
2901         (catch_throw_command): Likewise.
2902         (catch_rethrow_command): Likewise.
2903         * breakpoint.c (enum exception_event_kind): Delete.
2904         * breakpoint.h (enum exception_event_kind): Moved here from
2905         break-catch-throw.c.
2906         (catch_exception_event): Declare.
2907         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2908         (mi_cmd_catch_throw): New function.
2909         (mi_cmd_catch_rethrow): New function.
2910         (mi_cmd_catch_catch): New function.
2911         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2912         'catch-catch' entries.
2913         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2914         (mi_cmd_catch_rethrow): Declare.
2915         (mi_cmd_catch_catch): Declare.
2916
2917 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2918
2919         * annotate.c (annotate_source_line): Change return type to void,
2920         update implementation to match.
2921         * annotate.h (annotate_source_line): Change return type to void,
2922         update header comment.
2923         * stack.c (print_frame_info): Don't change what frame information
2924         is printed based on whether annotations are on or not.
2925
2926 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2927
2928         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2929         (annotate_source): Make static.
2930         (annotate_source_line): Moved from source.c and renamed from
2931         identify_source_line.  Update the return type.
2932         * annotate.h (annotate_source): Delete declaration.
2933         (annotate_source_line): Declaration moved from source.h, and
2934         renamed from identify_source_line.  Return type updated.
2935         * source.c (identify_source_line): Moved to annotate.c and renamed
2936         to annotate_source_line.
2937         (info_line_command): Remove check of annotation_level.
2938         * source.h (identify_source_line): Move declaration to annotate.h
2939         and rename to annotate_source_line.
2940         * stack.c: Add 'annotate.h' include.
2941         (print_frame_info): Remove check of annotation_level before
2942         calling annotate_source_line.
2943
2944 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2945
2946         * source-cache.c (source_cache::get_plain_source_lines): Use
2947         open_source_file_with_line_charpos instead of just
2948         open_source_file, remove call to find_source_lines.
2949         (source_cache::get_source_lines): Likewise.
2950         * source.c (find_source_lines): Make static.
2951         (get_filename_and_charpos): Renamed into...
2952         (open_source_file_with_line_charpos): ..this along with changes to
2953         return a scoped_fd, and some other minor clean ups.
2954         (identify_source_line): Use open_source_file_with_line_charpos.
2955         (search_command_helper): Use open_source_file_with_line_charpos
2956         instead of just open_source_file, remove call to
2957         find_source_lines.
2958         * source.h (open_source_file_with_line_charpos): Declare new
2959         function.
2960         (find_source_lines): Delete declaration.
2961
2962 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2963
2964         * source.c (get_filename_and_charpos): Remove fullname
2965         parameter.
2966         (identify_source_line): Update call to get_filename_and_charpos.
2967
2968 2019-06-14  Tom Tromey  <tromey@adacore.com>
2969
2970         PR gdb/24502:
2971         * ui-style.h (skip_ansi_escape): Update comment.
2972         * ui-file.h (class no_terminal_escape_file): New class.
2973         * ui-file.c (no_terminal_escape_file::write)
2974         (no_terminal_escape_file::puts): New methods.
2975         * cli/cli-logging.c (handle_redirections): Use
2976         no_terminal_escape_file.
2977
2978 2019-06-14  Tom Tromey  <tromey@adacore.com>
2979
2980         * NEWS: Move convenience variable news above Python news.
2981
2982 2019-06-14  Tom Tromey  <tom@tromey.com>
2983
2984         * gnulib: Move directory to top-level.
2985         * configure.ac: Don't configure gnulib.
2986         * configure: Rebuild.
2987         * common/common-defs.h: Use new path to gnulib.
2988         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2989         (GNULIB_H): Remove.
2990         (INCGNU): Look in new gnulib location.
2991         (HFILES_NO_SRCDIR): Remove gnulib files.
2992         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2993         (generated_files): Remove GNULIB_H.
2994         ($(LIBGNU), all-lib): Remove targets.
2995         (distclean): Don't mention GNULIB_BUILDDIR.
2996         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2997
2998 2019-06-14  Tom Tromey  <tromey@adacore.com>
2999
3000         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3001         Warn if symbol file does not provide any symbols.
3002
3003 2019-06-14  Tom Tromey  <tromey@adacore.com>
3004
3005         * source.c (find_and_open_source): Respect basenames_may_differ.
3006
3007 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3008
3009         * annotate.c (annotate_breakpoints_invalid): Make use of
3010         scoped_restore_terminal_state.
3011         (annotate_frames_invalid): Likewise.
3012
3013 2019-06-14  Tom Tromey  <tromey@adacore.com>
3014
3015         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3016         allow assignment to an internalvar.
3017
3018 2019-06-14  Tom Tromey  <tromey@adacore.com>
3019
3020         * ada-lex.l: Allow "_" in attribute names.
3021
3022 2019-06-14  Tom Tromey  <tromey@adacore.com>
3023
3024         PR gdb/24653:
3025         * regcache.c (registers_changed): Don't call alloca.
3026         * top.c (execute_command): Don't call alloca.
3027
3028 2019-06-13  Pedro Alves  <palves@redhat.com>
3029
3030         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3031         'expression'.  When parsing an expression, error out if there's
3032         junk after "unlimited".
3033         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3034         (do_set_command): Adjust calls to is_unlimited_literal.
3035
3036 2019-06-13  Pedro Alves  <palves@redhat.com>
3037
3038         * compile/compile.c (make_compile_options_def_group): Add braces
3039         around array_view initializer.
3040         * thread.c (make_thread_apply_all_options_def_group)
3041         (make_thread_apply_all_options_def_group): Likewise.
3042
3043 2019-06-13  Pedro Alves  <palves@redhat.com>
3044
3045         * NEWS (New commands): Mention "maint test-options
3046         require-delimiter", "maint test-options unknown-is-error", "maint
3047         test-options unknown-is-operand" and "maint show
3048         test-options-completion-result".
3049         (New command options, command completion): New section.
3050         (Completion improvements): New section.
3051         Mention that you can abbreviate "unlimited".
3052
3053 2019-06-13  Pedro Alves  <palves@redhat.com>
3054
3055         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3056         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3057         * unittests/cli-utils-selftests.c (test_parse_flags)
3058         (test_parse_flags_qcs): Delete.
3059         (test_cli_utils): Don't call deleted functions.
3060
3061 2019-06-13  Pedro Alves  <palves@redhat.com>
3062
3063         * thread.c: Include "cli/cli-option.h".
3064         (tp_array_compar_ascending): Global.
3065         (tp_array_compar): Delete function.
3066         (tp_array_compar_ascending, tp_array_compar_descending): New
3067         functions.
3068         (ascending_option_def, qcs_flag_option_def)
3069         (thr_qcs_flags_option_defs)
3070         (make_thread_apply_all_options_def_group)
3071         (make_thread_apply_options_def_group): New.
3072         (thread_apply_all_command): Use gdb::option::process_options.
3073         (thread_apply_command_completer)
3074         (thread_apply_all_command_completer): New.
3075         (thread_apply_command): Use gdb::option::process_options.
3076         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3077         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3078         to generate help text of "thread apply".  Adjust "taas"'s help.
3079         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3080         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3081
3082 2019-06-13  Pedro Alves  <palves@redhat.com>
3083
3084         * thread.c (thread_apply_command): Check for invalid TID with
3085         isdigit instead of !isalpha.
3086
3087 2019-06-13  Pedro Alves  <palves@redhat.com>
3088
3089         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3090         (validate_flags_qcs): New.
3091         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3092         (validate_flags_qcs): Declare.
3093         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3094         (make_frame_apply_options_def_group): New.
3095         (frame_apply_command_count): Process options with
3096         gdb::option::process_options.
3097         (frame_apply_completer): New.
3098         (frame_apply_level_completer, frame_apply_all_completer)
3099         (frame_apply_completer): New.
3100         (_initialize_stack): Update help of "frame apply", "frame apply
3101         level", "frame apply all" and "faas" to mention supported options
3102         and install command completers.
3103         * stack.h (frame_apply_all_completer): Declare.
3104         * thread.c: Include "stack.h".
3105         (tfaas_command): Add "--".
3106         (_initialize_thread): Update help "tfaas" to mention supported
3107         options and install command completer.
3108
3109 2019-06-13  Pedro Alves  <palves@redhat.com>
3110
3111         * completer.c (complete_nested_command_line): New.
3112         (gdb_completion_word_break_characters_throw): Add assertion.
3113         * completer.h (complete_nested_command_line): Declare.
3114
3115 2019-06-13  Pedro Alves  <palves@redhat.com>
3116
3117         * stack.c (parse_backtrace_qualifiers): New.
3118         (backtrace_command): Use it.
3119         (backtrace_command_completer): Complete on qualifiers.
3120
3121 2019-06-13  Pedro Alves  <palves@redhat.com>
3122
3123         * frame.c: Include "cli/cli-option.h.
3124         (user_set_backtrace_options): New.
3125         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3126         Delete.
3127         (get_prev_frame): Adjust.
3128         (boolean_option_def, uinteger_option_def)
3129         (set_backtrace_option_defs): New.
3130         (_initialize_frame): Adjust and use
3131         gdb::option::add_setshow_cmds_for_options to install "set
3132         backtrace past-main" and "set backtrace past-entry".
3133         * frame.h: Include "cli/cli-option.h".
3134         (struct frame_print_options): Forward declare.
3135         (print_frame_arguments_all, print_frame_arguments_scalars)
3136         (print_frame_arguments_none): Declare.
3137         (print_entry_values): Delete declaration.
3138         (struct frame_print_options, user_frame_print_options): New.
3139         (struct set_backtrace_options): New.
3140         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3141         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3142         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3143         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3144         (list_args_or_locals): Add frame_print_options parameter.
3145         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3146         * python/py-framefilter.c (enumerate_args): Pass down
3147         USER_FRAME_PRINT_OPTIONS.
3148         * stack.c: Include "cli/cli-option.h".
3149         (print_frame_arguments_all, print_frame_arguments_scalars)
3150         (print_frame_arguments_none): Declare.
3151         (print_raw_frame_arguments, print_entry_values): Delete.
3152         (user_frame_print_options): New.
3153         (boolean_option_def, enum_option_def, frame_print_option_defs):
3154         New.
3155         (struct backtrace_cmd_options): New.
3156         (bt_flag_option_def): New.
3157         (backtrace_command_option_defs): New.
3158         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3159         (print_frame_arg, read_frame_arg, print_frame_args)
3160         (print_frame_info, print_frame): Add frame_print_options parameter
3161         and use it.
3162         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3163         (backtrace_command_1): Add frame_print_options and
3164         backtrace_cmd_options parameters and use them.
3165         (make_backtrace_options_def_group): New.
3166         (backtrace_command): Process command options with
3167         gdb::option::process_options.
3168         (backtrace_command_completer): New.
3169         (_initialize_stack): Extend "backtrace"'s help to mention
3170         supported options.  Install completer for "backtrace".
3171         Install some settings commands with add_setshow_cmds_for_options.
3172
3173 2019-06-13  Pedro Alves  <palves@redhat.com>
3174
3175         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3176         and that "set/show print raw frame-arguments" are now deprecated.
3177
3178         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3179         command.
3180         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3181         * stack.c (_initialize_stack): Install "set/show print
3182         raw-frame-arguments", and deprecate "set/show print raw
3183         frame-arguments".
3184         * valprint.c (_initialize_valprint): Deprecate "set/show print
3185         raw".
3186
3187 2019-06-13  Pedro Alves  <palves@redhat.com>
3188
3189         * compile/compile.c (struct compile_options): New.
3190         (compile_flag_option_def, compile_command_option_defs)
3191         (make_compile_options_def_group): New.
3192         (compile_file_command): Handle options with
3193         gdb::option::process_options.
3194         (compile_file_command_completer): New function.
3195         (compile_code_command): Handle options with
3196         gdb::option::process_options.
3197         (compile_code_command_completer): New function.
3198         (_initialize_compiler): Install completers for "compile code" and
3199         "compile file".  Mention available options in "compile code" and
3200         "compile code"'s help.
3201         * completer.c (advance_to_completion_word): New, factored out from
3202         ...
3203         (advance_to_expression_complete_word_point): ... this.
3204         (advance_to_filename_complete_word_point): New.
3205         * completer.h (advance_to_filename_complete_word_point): New
3206         declaration.
3207
3208 2019-06-13  Pedro Alves  <palves@redhat.com>
3209
3210         * compile/compile.c: Include "cli/cli-option.h".
3211         (compile_print_value): Scope data pointer is now a
3212         value_print_options pointer; adjust.
3213         (compile_print_command): Process options.  Scope data pointer is
3214         now a value_print_options pointer; adjust.
3215         (_initialize_compile): Update "compile print"'s help to include
3216         supported options.  Install a completer for "compile print".
3217         * cp-valprint.c (show_vtblprint, show_objectprint)
3218         (show_static_field_print): Delete.
3219         (_initialize_cp_valprint): Don't install "set print
3220         static-members", "set print vtbl", "set print object" here.
3221         * printcmd.c: Include "cli/cli-option.h" and
3222         "common/gdb_optional.h".
3223         (print_command_parse_format): Rework to fill in a
3224         value_print_options instead of a format_data.
3225         (print_value): Change parameter type from format_data pointer to
3226         value_print_options reference.  Adjust.
3227         (print_command_1): Process options.  Adjust to pass down a
3228         value_print_options.
3229         (print_command_completer): New.
3230         (_initialize_printcmd): Install print_command_completer as
3231         handle_brkchars completer for the "print" command.  Update
3232         "print"'s help to include supported options.
3233         * valprint.c: Include "cli/cli-option.h".
3234         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3235         here from cp-valprint.c.
3236         (boolean_option_def, uinteger_option_def)
3237         (value_print_option_defs, make_value_print_options_def_group):
3238         New.  Use gdb::option::add_setshow_cmds_for_options to install
3239         "set print elements", "set print null-stop", "set print repeats",
3240         "set print pretty", "set print union", "set print array", "set
3241         print address", "set print symbol", "set print array-indexes".
3242         * valprint.h: Include <string> and "cli/cli-option.h".
3243         (make_value_print_options_def_group): Declare.
3244         (print_value): Change parameter type from format_data pointer to
3245         value_print_options reference.
3246         (print_command_completer): Declare.
3247
3248 2019-06-13  Pedro Alves  <palves@redhat.com>
3249
3250         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3251         (COMMON_SFILES): Add maint-test-settings.c.
3252         * cli/cli-decode.c (boolean_enums): New global, factored out from
3253         ...
3254         (add_setshow_boolean_cmd): ... here.
3255         * cli/cli-decode.h (boolean_enums): Declare.
3256         * cli/cli-option.c: New file.
3257         * cli/cli-option.h: New file.
3258         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3259         factored out from ...
3260         (parse_cli_boolean_value(const char *)): ... this.
3261         (is_unlimited_literal): Change parameter type to pointer to
3262         pointer.  Adjust and advance ARG pointer.
3263         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3264         (parse_cli_var_enum): New, factored out from ...
3265         (do_set_command): ... this.  Adjust.
3266         * cli/cli-setshow.h (parse_cli_boolean_value)
3267         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3268         (parse_cli_var_enum): Declare.
3269         * cli/cli-utils.c: Include "cli/cli-option.h".
3270         (get_ulongest): New.
3271         * cli/cli-utils.h (get_ulongest): Declare.
3272         (check_for_argument): New overloads.
3273         * maint-test-options.c: New file.
3274
3275 2019-06-13  Pedro Alves  <palves@redhat.com>
3276
3277         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3278         parse a range if "-" is at the end of the string.
3279
3280 2019-06-13  Pedro Alves  <palves@redhat.com>
3281
3282         * cli/cli-setshow.c (parse_auto_binary_operation)
3283         (parse_cli_boolean_value): Don't allow "o".
3284
3285 2019-06-13  Pedro Alves  <palves@redhat.com>
3286
3287         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3288         * NEWS: Mention maint test-settings KIND.
3289         * maint-test-settings.c: New file.
3290
3291 2019-06-13  Pedro Alves  <palves@redhat.com>
3292
3293         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3294         completer.
3295         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3296         "set" completers.
3297
3298 2019-06-13  Pedro Alves  <palves@redhat.com>
3299
3300         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3301         after item.
3302
3303 2019-06-13  Pedro Alves  <palves@redhat.com>
3304
3305         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3306
3307 2019-06-13  Pedro Alves <palves@redhat.com>
3308
3309         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3310         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3311         call.
3312         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3313         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3314         calls.
3315         (check_for_argument): Skip spaces after argument.
3316
3317 2019-06-13  Pedro Alves  <palves@redhat.com>
3318
3319         * thread.c (thread_apply_command): Adjust TID parsing.
3320         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3321         detected before end of string.
3322         (tid_is_in_list): Error out if LIST is invalid.
3323
3324 2019-06-13  Pedro Alves  <palves@redhat.com>
3325
3326         * completer.c (complete_line_internal_1): Rewind completion word
3327         point.
3328         (completion_tracker::advance_custom_word_point_by): Change
3329         parameter type to int.
3330         * completer.h (completion_tracker::advance_custom_word_point_by):
3331         Likewise.
3332
3333 2019-06-13  Pedro Alves  <palves@redhat.com>
3334
3335         * completer.c (advance_to_completion_word): Handle delimiters.
3336
3337 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3338
3339         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3340
3341 2019-06-11  Tom Tromey  <tom@tromey.com>
3342
3343         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3344         (xmalloc_failed): Move to alloc.c.
3345         * alloc.c: New file.
3346         * Makefile.in (COMMON_SFILES): Add alloc.c.
3347
3348 2019-06-11  Tom Tromey  <tom@tromey.com>
3349
3350         * nat/linux-waitpid.c: Don't include server.h.
3351         (linux_debug): Remove.
3352         (my_waitpid): Update.
3353
3354 2019-06-11  Tom Tromey  <tromey@adacore.com>
3355
3356         * infcall.c (_initialize_infcall): Remove trailing newline from
3357         help.
3358         * user-regs.c (_initialize_user_regs): Remove trailing newline
3359         from help.
3360         * typeprint.c (_initialize_typeprint): Remove trailing newline
3361         from help.
3362         * reverse.c (_initialize_reverse): Remove trailing newlines from
3363         help.
3364         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3365         from help.
3366         * language.c (add_set_language_command): Remove trailing newline
3367         from help.
3368         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3369         help.
3370         * disasm.c (_initialize_disasm): Remove trailing newline from
3371         help.
3372         * top.c (init_main): Remove trailing newline from help.
3373         * interps.c (_initialize_interpreter): Remove trailing newline
3374         from help.
3375         * btrace.c (_initialize_btrace): Remove trailing newlines from
3376         help.
3377         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3378         from help.
3379         * python/python.c (_initialize_python): Remove trailing newline
3380         from help.
3381         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3382         help.
3383         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3384         from help.  Reformat some text.
3385         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3386         from help.
3387         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3388         newline from help.
3389
3390 2019-06-11  Tom Tromey  <tromey@adacore.com>
3391
3392         * darwin-nat.c (darwin_decode_exception_message)
3393         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3394
3395 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3396
3397         * valops.c (value_slice): Check for not allocated or not
3398         associated values.
3399
3400 2019-06-10  Tom de Vries  <tdevries@suse.de>
3401
3402         PR gdb/24618
3403         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3404         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3405         invalid.
3406
3407 2019-06-10  Tom de Vries  <tdevries@suse.de>
3408
3409         PR gdb/24611
3410         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3411         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3412
3413 2019-06-10  Tom de Vries  <tdevries@suse.de>
3414
3415         PR symtab/24545
3416         * symtab.c (struct demangled_name_entry): Add language field.
3417         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3418         static minimal symbol".  Set and use language field.
3419
3420 2019-06-10  Tom Tromey  <tromey@adacore.com>
3421
3422         * ada-lang.c (_initialize_ada_language): Update help text.
3423
3424 2019-06-10  Tom Tromey  <tromey@adacore.com>
3425
3426         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3427         with a newline.
3428         * guile/guile.c (handle_boot_error): Don't end warning with a
3429         newline.
3430         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3431         warning with a newline.
3432         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3433         newline.
3434         (s12z_frame_cache): Likewise.
3435         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3436         a newline.
3437         * solib-svr4.c (disable_probes_interface): Don't end warning with
3438         a newline.
3439         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3440         newline.
3441         * python/python.c (do_finish_initialization): Don't end warning
3442         with a newline.
3443
3444 2019-06-10  Tom Tromey  <tom@tromey.com>
3445
3446         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3447         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3448         gdbpy_enter.
3449
3450 2019-06-10  Tom Tromey  <tromey@adacore.com>
3451
3452         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3453         data.
3454         (elf_new_init): Don't call stabsread_new_init.
3455         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3456         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3457         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3458
3459 2019-06-10  Tom de Vries  <tdevries@suse.de>
3460
3461         PR symtab/16264
3462         PR symtab/24517
3463         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3464
3465 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3466
3467         * source.c (find_and_open_source): Also rewrite relative file
3468         names.
3469
3470 2019-04-26  Amos Bird  <amosbird@gmail.com>
3471
3472         * annotate.c (annotate_thread_exited): Add "thread-exited"
3473         annotation.
3474
3475 2019-06-06  Tom Tromey  <tromey@adacore.com>
3476
3477         * maint.h (class scoped_command_stats): Use
3478         DISABLE_COPY_AND_ASSIGN.
3479         <print_time>: New method.
3480         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3481         print_time.
3482         (scoped_command_stats::print_time): New method.
3483
3484 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3485
3486         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3487         instructions of lengths 6 or 8 bytes.
3488
3489 2019-06-04  Pedro Alves  <palves@redhat.com>
3490
3491         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3492
3493         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3494         * breakpoint.c (condition_completer): Likewise.
3495         * cli/cli-dump.c (scan_expression): Likewise.
3496         * common/filestuff.c (mkdir_recursive): Likewise.
3497         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3498         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3499         (gdb_abspath): Likewise.
3500         * compile/compile-cplus-types.c
3501         (compile_cplus_instance::decl_name): Likewise.
3502         * completer.c (complete_explicit_location):
3503         (signal_completer, reg_or_group_completer_1): Likewise.
3504         * cp-support.c (cp_remove_params_if_any): Likewise.
3505         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3506         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3507         * infcmd.c (strip_bg_char): Likewise.
3508         * linespec.c (copy_token_string): Likewise.
3509         * mi/mi-main.c (output_cores): Likewise.
3510         * psymtab.c (psymtab_search_name):
3511         * symfile.c (test_set_ext_lang_command): Likewise.
3512         * target.c (target_fileio_read_stralloc): Likewise.
3513         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3514         * value.c (complete_internalvar): Likewise.
3515
3516 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3517
3518         Add objfile property to gdb.Type.
3519         * NEWS: Mention Python API addition.
3520         * python/py-type.c (typy_get_objfile): New method.
3521
3522 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3523
3524         * NEWS: Mention the new set|show style [title|highlight].
3525         Mention changes to "show style", "help" and "apropos".
3526
3527 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3528
3529         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3530         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3531         instead of print_help_for_command.
3532         (print_doc_of_command): New function.
3533         (help_list): Add 'apropos -v word' suggestion.
3534         (print_help_for_command): Style the command name using title style.
3535         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3536         (_initialize_cli_cmds): Describe -v in apropos_command help.
3537
3538 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3539
3540         * cli/cli-style.h (cli_style_option): Add name in constructor,
3541         add m_name class member, add constructor with intensity,
3542         add name class function.
3543         (cli_style_option::add_setshow_commands): Remove name argument.
3544         (highlight_style, title_style): New styles.
3545         * cli/cli-style.c (do_show): New function that shows a style
3546         characteristic styling the style name with itself.
3547         (set_style_name): New function.
3548         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3549         Update all callers according to the changes in cli/cli-style.h.
3550         * utils.h (fputs_highlighted): New function.
3551         * utils.c (fputs_highlighted): Likewise.
3552
3553 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3554
3555         * NEWS: Mention new pipe command and new convenience variables.
3556
3557 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3558
3559         * cli/cli-cmds.c (pipe_command): New function.
3560         (_initialize_cli_cmds): Call add_com for pipe_command.
3561         Define | as an alias for pipe.
3562         (exit_status_set_internal_vars): New function.
3563         (shell_escape): Call exit_status_set_internal_vars.
3564         cli/cli-decode.c (find_command_name_length): Recognize | as
3565         a single character command.
3566
3567 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3568
3569         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3570         top.c (execute_command_to_ui_file): New function, mostly a copy
3571         of execute_command_to_string.
3572         (execute_command_to_string): Implement by calling
3573         execute_command_to_ui_file.
3574
3575 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3576
3577         * top.h (saved_command_line): Remove declaration.
3578         * top.c (previous_saved_command_line, previous_repeat_arguments):
3579         New variables.
3580         (saved_command_line): Make static, define together with other
3581         'repeat variables'.
3582         (dont_repeat): Clear repeat_arguments.
3583         (repeat_previous, get_saved_command_line, save_command_line):
3584         New functions.
3585         (gdb_init): Initialize saved_command_line
3586         and previous_saved_command_line.
3587         * main.c (captured_main_1): Remove saved_command_line initialization.
3588         * event-top.c (handle_line_of_input): Update to use
3589         the new 'repeat' related functions instead of direct access to
3590         saved_command_line.
3591         * command.h (repeat_previous, get_saved_command_line,
3592         save_command_line): New declarations.
3593         (dont_repeat): Add comment.
3594
3595 2019-05-30  Tom Tromey  <tromey@adacore.com>
3596
3597         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3598         Fix comment.
3599         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3600
3601 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3602
3603         PR cli/24587
3604         * completer.c (complete): Initialize variable word.
3605
3606 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3607
3608         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3609         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3610         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3611         'body' is NULL to the outter 'if', protecting the '!is_define'
3612         situation as well.
3613
3614 2019-05-29  Tom Tromey  <tromey@adacore.com>
3615
3616         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3617         (dwarf_unknown): New function.
3618         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3619         (dwarf_type_encoding_name): Use dwarf_unknown.
3620
3621 2019-05-29  Tom Tromey  <tromey@adacore.com>
3622
3623         PR c++/20020:
3624         * cp-valprint.c (cp_print_value_fields): Call
3625         cp_print_static_field inside "try".
3626
3627 2019-05-29  Tom Tromey  <tromey@adacore.com>
3628
3629         * inflow.c (struct terminal_info): Add default operator=.
3630         * configure: Rebuild.
3631         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3632         -Wdeprecated-copy-dtor, -Wredundant-move.
3633
3634 2019-05-29  Tom Tromey  <tromey@adacore.com>
3635
3636         * NEWS: Add entry.
3637         * infcmd.c (print_return_value_1): Handle finish_print
3638         option.
3639         (show_print_finish): New function.
3640         (_initialize_infcmd): Add "set/show print finish" commands.
3641         * valprint.c (user_print_options): Initialize new member.
3642         * valprint.h (struct value_print_options) <finish_print>: New
3643         member.
3644
3645 2019-05-28  Tom Tromey  <tromey@adacore.com>
3646
3647         * ada-lang.c (ada_remove_Xbn_suffix)
3648         (find_old_style_renaming_symbol)
3649         (parse_old_style_renaming): Remove.
3650         (ada_find_renaming_symbol): Don't call
3651         find_old_style_renaming_symbol.
3652         (ada_is_renaming_symbol): Rename from
3653         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3654         bool.  Now static.
3655         (ada_read_var_value): Update and simplify.
3656         * ada-exp.y (write_var_or_type): Remove old code.
3657
3658 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3659
3660         * event-top.c: Remove include comment.
3661         * inflow.c (class scoped_ignore_sigttou): Move from here...
3662         * inflow.h (class scoped_ignore_sigttou): ...to here.
3663         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3664         * top.c:  Remove include comment.
3665
3666 2019-05-27  Tom Tromey  <tom@tromey.com>
3667
3668         * NEWS: Fix typo.
3669
3670 2019-05-22  Tom Tromey  <tromey@adacore.com>
3671
3672         * target.c (target_follow_exec): Constify parameter.
3673         * target-delegates.c: Rebuild.
3674         * remote.c (remote_target::follow_exec): Constify parameter.
3675         * infrun.c (follow_exec): Constify parameter.
3676         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3677         (target_follow_exec): Likewise.
3678
3679 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3680
3681         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3682         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3683
3684 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3685
3686         * NEWS: Add debugredirect and testsuite sections.
3687
3688 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3689
3690         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3691         target descriptions using exclusively floating point register name
3692         aliases.
3693
3694 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3695
3696         PR gdb/18644:
3697         * f-lang.c (build_fortran_types): Handle the case where
3698         gdbarch_floatformat_for_type returns a nullptr.
3699
3700 2019-05-21  Tom de Vries  <tdevries@suse.de>
3701
3702         PR cli/24587
3703         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3704
3705 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3706
3707         PR gdb/18644:
3708         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3709         16-byte floats.
3710         * i386-tdep.c (i386_floatformat_for_type): Use
3711         floatformats_ia64_quad for the 16-byte floating point component
3712         within a fortran 32-byte complex number.
3713
3714 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3715
3716         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3717         delete default constructor.
3718         (find_partial_die): Update to return const struct.
3719         (partial_die_parent_scope): Move variable declaration into scope
3720         of its use and change its type to auto.
3721         (guess_partial_die_structure_name): Likewise.
3722         (partial_die_info::fixup): Likewise.
3723
3724 2019-05-17  Tom Tromey  <tromey@adacore.com>
3725
3726         * source.c (find_and_open_source): Remove cast.
3727
3728 2019-05-17  Tom Tromey  <tromey@adacore.com>
3729
3730         * annotate.c (annotate_source): Make "filename" const.
3731         * annotate.h (annotate_source): Use const.
3732
3733 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3734
3735         * disasm.c (set_disassembler_options): Send errors to stderr.
3736
3737 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3738
3739         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3740         (cli_interp_base::set_logging): Check debug_redirect.
3741         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3742         * cli/cli-logging.c (debug_redirect): Add static variable.
3743         (pop_output_files): Add default param.
3744         (handle_redirections): Print debug setting.
3745         (show_logging_command): Likewise.
3746         (_initialize_cli_logging): Add debugredirect command.
3747         * interps.c (current_interp_set_logging): Add debug_redirect
3748         parameter.
3749         * interps.h (set_logging): Add debug_redirect parameter.
3750         (current_interp_set_logging): Likewise.
3751         * mi/mi-common.h: Likewise.
3752         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3753
3754 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3755             Tom Tromey  <tromey@adacore.com>
3756
3757         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3758         directly.
3759         * cli/cli-interp.h (make_logging_output): Remove declaration.
3760         * cli/cli-logging.c (make_logging_output): Remove function.
3761         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3762         directly.
3763         * ui-file.c (tee_file::tee_file): Remove bools.
3764         (tee_file::~tee_file): Remove deletes.
3765         * ui-file.h (tee_file): Remove bools.
3766
3767 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3768
3769         * mi/mi-cmds.h (mi_cmd_complete): New function.
3770         * mi/mi-main.c (mi_cmd_complete): Likewise.
3771         * mi/mi-cmds.c: Define new MI command -complete.
3772         * NEWS: Mention new -complete command.
3773
3774 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3775
3776         * completer.h (complete): New function.
3777         * completer.c (complete): Likewise.
3778         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3779         function defined in completer.h.
3780
3781 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3782
3783         * MAINTAINERS (Write After Approval): Add myself.
3784
3785 2019-05-17  Tom de Vries  <tdevries@suse.de>
3786
3787         PR gdb/24094
3788         * dwarf2read.c (struct cu_partial_die_info): New struct.
3789         (find_partial_die): Return cu_partial_die_info.
3790         (partial_die_parent_scope, guess_partial_die_structure_name)
3791         (partial_die_info::fixup): Handle new return type of find_partial_die.
3792
3793 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3794
3795         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3796         "std::string", simplifying the algorithm.
3797
3798 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3799
3800         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3801         (stap_static_probe_ops::get_probes): Likewise.
3802
3803 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3804
3805         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3806         '-')" and "else if".
3807         (stap_parse_single_operand): Join checks for
3808         "gdbarch_stap_parse_special_token_p" and
3809         "gdbarch_stap_parse_special_token" in the same "if" statement.
3810         Invert check when verifying for operation on register
3811         displacement.
3812
3813 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3814
3815         * stap-probe.c (stap_get_opcode): Update comment.
3816         (stap_get_expected_argument_type): Likewise.
3817         (handle_stap_probe): Likewise.
3818
3819 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3820
3821         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3822         return type to 'bool'.  Adjust comment.  Use 'bool' when
3823         appropriate.
3824         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3825         * stap-probe.c (stap_parse_argument_1): Likewise.
3826         (stap_is_operator): Likewise.
3827         (stap_is_generic_prefix): Likewise.
3828         (stap_is_register_prefix): Likewise.
3829         (stap_is_register_indirection_prefix): Likewise.
3830         (stap_is_integer_prefix): Likewise.
3831         (stap_generic_check_suffix): Likewise.
3832         (stap_check_integer_suffix): Likewise.
3833         (stap_check_register_suffix): Likewise.
3834         (stap_check_register_indirection_suffix): Likewise.
3835         (stap_parse_register_operand): Likewise.
3836         (stap_parse_single_operand): Likewise.
3837         (stap_parse_argument_1): Likewise.
3838         (stap_probe::get_argument_count): Likewise.
3839         (stap_is_operator): Likewise.
3840
3841 2019-05-16  Tom Tromey  <tromey@adacore.com>
3842
3843         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3844         keyword to foreach.
3845
3846 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3847
3848         * linux-thread-db.c (try_thread_db_load_1): Change return type
3849         to bool.
3850         (try_thread_db_load): Likewise.
3851         (try_thread_db_load_from_pdir_1): Likewise.
3852         (try_thread_db_load_from_pdir): Likewise.
3853         (try_thread_db_load_from_sdir): Likewise.
3854         (try_thread_db_load_from_dir): Likewise.
3855         (thread_db_load_search): Likewise.
3856         (has_libpthread): Likewise.
3857         (thread_db_load): Likewise.
3858
3859 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3860
3861         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3862         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3863         NULL, and complain/return if that's the case.
3864
3865 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3866
3867         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3868         (advance, posn, abstract_read_memory): New functions.
3869         [struct mem_read_abstraction]: New struct.
3870         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3871
3872 2019-05-14  Tom Tromey  <tromey@adacore.com>
3873
3874         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3875         value is not lval_memory.
3876
3877 2019-05-14  Tom Tromey  <tromey@adacore.com>
3878
3879         * solib.c (info_sharedlibrary_command): Style the file name.
3880
3881 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3882
3883         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3884         (aarch64_vnv_type): Likewise.
3885         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3886         * common/tdesc.c: Likewise.
3887         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3888         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3889         * features/aarch64-fpu.xml: Add ieee half view.
3890         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3891         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3892         * gdbtypes.h (struct builtin_type): Likewise.
3893         (struct objfile_type): Likewise.
3894
3895 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3896
3897         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3898         typo.
3899         * location.h (string_to_event_location): Likewise.
3900
3901 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3902
3903         GDB 8.3 released.
3904
3905 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3906
3907         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3908         New variable declaration.
3909         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3910         New variable.
3911         (print_one_breakpoint): Use ui_out::test_flags and new global
3912         variable to compute use_fixed_output.
3913         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3914         Remove.
3915         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3916         (mi_multi_location_breakpoint_output_fixed): Remove.
3917         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3918         new variable.
3919         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3920         fix_multi_location_breakpoint_output flag if version >= 3.
3921         * ui-out.h (enum ui_out_flag)
3922         <fix_multi_location_breakpoint_output>: New enumerator.
3923
3924 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3925
3926         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3927
3928 2019-05-10  Tom Tromey  <tromey@adacore.com>
3929
3930         * ada-lang.c (catch_ada_completer): New function.
3931         (_initialize_ada_language): Use it.
3932
3933 2019-05-10  Tom Tromey  <tromey@adacore.com>
3934
3935         * thread.c (print_thread_info): Make "requested_threads" const.
3936         * gdbthread.h (print_thread_info): Make "requested_threads"
3937         const.
3938         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3939         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3940
3941 2019-05-08  Tom Tromey  <tom@tromey.com>
3942
3943         * gdbtypes.c (objfile_type_data): Change type.
3944         (objfile_type, _initialize_gdbtypes): Update.
3945
3946 2019-05-08  Tom Tromey  <tom@tromey.com>
3947
3948         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3949         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3950         (_initialize_dwarf2_frame): Update.
3951
3952 2019-05-08  Tom Tromey  <tom@tromey.com>
3953
3954         * objc-lang.c (objc_objfile_data): Change type.
3955         (find_methods): Update.
3956         (_initialize_objc_lang): Remove.
3957
3958 2019-05-08  Tom Tromey  <tom@tromey.com>
3959
3960         * stabsread.c (rs6000_builtin_type_data): Change type.
3961         (rs6000_builtin_type, _initialize_stabsread): Update.
3962
3963 2019-05-08  Tom Tromey  <tom@tromey.com>
3964
3965         * mips-tdep.c (mips_pdr_data): Remove.
3966         (_initialize_mips_tdep): Update.
3967
3968 2019-05-08  Tom Tromey  <tom@tromey.com>
3969
3970         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3971         (hppa_init_objfile_priv_data, read_unwind_info)
3972         (find_unwind_entry, _initialize_hppa_tdep): Update.
3973
3974 2019-05-08  Tom Tromey  <tom@tromey.com>
3975
3976         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3977         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3978         on obstack.
3979         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3980
3981 2019-05-08  Tom Tromey  <tom@tromey.com>
3982
3983         * mdebugread.c (basic_type_data): Change type.
3984         (basic_type, _initialize_mdebugread): Update.
3985
3986 2019-05-08  Tom Tromey  <tom@tromey.com>
3987
3988         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3989
3990 2019-05-08  Tom Tromey  <tom@tromey.com>
3991
3992         * nto-tdep.c (nto_inferior_data_reg): Change type.
3993         (nto_inferior_data): Update.
3994         (nto_inferior_data_cleanup, nto_new_inferior_data)
3995         (_initialize_nto_tdep): Remove.
3996         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3997
3998 2019-05-08  Tom Tromey  <tom@tromey.com>
3999
4000         * ada-lang.c (struct ada_inferior_data): Add initializers.
4001         (ada_inferior_data): Change type.
4002         (ada_inferior_data_cleanup): Remove.
4003         (get_ada_inferior_data, ada_inferior_exit)
4004         (struct ada_pspace_data): Add initializers, destructor.
4005         (ada_pspace_data_handle): Change type.
4006         (get_ada_pspace_data): Update.
4007         (ada_pspace_data_cleanup): Remove.
4008
4009 2019-05-08  Tom Tromey  <tom@tromey.com>
4010
4011         * coffread.c (struct coff_symfile_info): Add initializers.
4012         (coff_objfile_data_key): Move lower.  Change type.
4013         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4014         Update.
4015         (coff_free_info): Remove.
4016
4017 2019-05-08  Tom Tromey  <tom@tromey.com>
4018
4019         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4020         (fbsd_pspace_data_handle): Move lower.  Change type.
4021         (get_fbsd_pspace_data): Update.
4022         (fbsd_pspace_data_cleanup): Remove.
4023         (_initialize_fbsd_tdep): Update.
4024
4025 2019-05-08  Tom Tromey  <tom@tromey.com>
4026
4027         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4028         (get_ada_tasks_pspace_data): Update.
4029         (ada_tasks_pspace_data_cleanup): Remove.
4030         (_initialize_tasks): Update.
4031         (ada_tasks_inferior_data_handle): Change type.
4032         (get_ada_tasks_inferior_data): Update.
4033         (ada_tasks_inferior_data_cleanup): Remove.
4034         (struct ada_tasks_pspace_data): Add initializers.
4035
4036 2019-05-08  Tom Tromey  <tom@tromey.com>
4037
4038         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4039         * symfile-debug.c (debug_sym_get_probes): Change type.
4040         * stap-probe.c (handle_stap_probe):
4041         (stap_static_probe_ops::get_probes): Change type.
4042         * probe.h (class static_probe_ops) <get_probes>: Change type.
4043         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4044         (parse_probes_in_pspace): Update.
4045         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4046         Update.
4047         (any_static_probe_ops::get_probes): Change type.
4048         * elfread.c (elfread_data): New typedef.
4049         (probe_key): Change type.
4050         (elf_get_probes): Likewise.  Update.
4051         (probe_key_free): Remove.
4052         (_initialize_elfread): Update.
4053         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4054         Change type.
4055         (dtrace_process_dof_probe, dtrace_process_dof)
4056         (dtrace_static_probe_ops::get_probe): Change type.
4057
4058 2019-05-08  Tom Tromey  <tom@tromey.com>
4059
4060         * xcoffread.c (struct xcoff_symfile_info): Rename from
4061         coff_symfile_info.  Add initializers.
4062         (xcoff_objfile_data_key): Move lower.  Change type.
4063         (XCOFF_DATA): Rewrite.
4064         (xcoff_free_info): Remove.
4065         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4066         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4067         (xcoff_initial_scan): Update.
4068
4069 2019-05-08  Tom Tromey  <tom@tromey.com>
4070
4071         * solib-svr4.c (struct svr4_info): Add initializers and
4072         destructor.
4073         <probes_table>: Now an htab_up.
4074         (solib_svr4_pspace_data): Change type.
4075         (free_probes_table): Simplify.
4076         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4077         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4078         (probes_table_remove_objfile_probes, register_solib_event_probe)
4079         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4080         (_initialize_svr4_solib): Update.
4081
4082 2019-05-08  Tom Tromey  <tom@tromey.com>
4083
4084         * remote.c (remote_pspace_data): Change type.
4085         (remote_pspace_data_cleanup): Remove.
4086         (get_remote_exec_file, set_pspace_remote_exec_file)
4087         (_initialize_remote): Update.
4088
4089 2019-05-08  Tom Tromey  <tom@tromey.com>
4090
4091         * breakpoint.c (breakpoint_objfile_key): Change type.
4092         (get_breakpoint_objfile_data): Update.
4093         (free_breakpoint_objfile_data): Remove.
4094         (_initialize_breakpoint): Update.
4095
4096 2019-05-08  Tom Tromey  <tom@tromey.com>
4097
4098         * linux-tdep.c (struct linux_info): Add initializers.
4099         (linux_inferior_data): Move.  Change type.
4100         (invalidate_linux_cache_inf): Update.
4101         (linux_inferior_data_cleanup): Remove.
4102         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4103
4104 2019-05-08  Tom Tromey  <tom@tromey.com>
4105
4106         * auxv.c (auxv_inferior_data): Move.  Change type.
4107         (auxv_inferior_data_cleanup): Remove.
4108         (invalidate_auxv_cache_inf): Rewrite.
4109         (get_auxv_inferior_data, _initialize_auxv): Update.
4110
4111 2019-05-08  Tom Tromey  <tom@tromey.com>
4112
4113         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4114         (symfile_debug_objfile_data_key): Change type.
4115         (symfile_debug_installed, debug_qf_has_symbols)
4116         (debug_qf_find_last_source_symtab)
4117         (debug_qf_forget_cached_source_info)
4118         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4119         (debug_qf_print_stats, debug_qf_dump)
4120         (debug_qf_expand_symtabs_for_function)
4121         (debug_qf_expand_all_symtabs)
4122         (debug_qf_expand_symtabs_with_fullname)
4123         (debug_qf_map_matching_symbols)
4124         (debug_qf_expand_symtabs_matching)
4125         (debug_qf_find_pc_sect_compunit_symtab)
4126         (debug_qf_map_symbol_filenames)
4127         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4128         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4129         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4130         (debug_sym_read_linetable, debug_sym_relocate): Update.
4131         (symfile_debug_free_objfile): Remove.
4132         (install_symfile_debug_logging, _initialize_symfile_debug):
4133         Update.
4134
4135 2019-05-08  Tom Tromey  <tom@tromey.com>
4136
4137         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4138         allocate_on_obstack.
4139         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4140         (get_dwarf2_per_objfile): Update.
4141         (set_dwarf2_per_objfile): Remove.
4142         (dwarf2_has_info, dwarf2_get_section_info): Update.
4143         (dwarf2_free_objfile): Remove.
4144         (_initialize_dwarf2_read): Update.
4145
4146 2019-05-08  Tom Tromey  <tom@tromey.com>
4147
4148         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4149         initializers.
4150         <unsupported_script_warning_printed,
4151         script_not_found_warning_printed>: Now bool.
4152         (auto_load_pspace_data): Change type.
4153         (~auto_load_pspace_info): Rename from
4154         auto_load_pspace_data_cleanup.
4155         (get_auto_load_pspace_data, init_loaded_scripts_info)
4156         (clear_section_scripts, maybe_print_unsupported_script_warning)
4157         (maybe_print_script_not_found_warning, _initialize_auto_load):
4158         Update.
4159
4160 2019-05-08  Tom Tromey  <tom@tromey.com>
4161
4162         * objfiles.c (objfile_pspace_info): Add destructor and
4163         initializers.
4164         (objfiles_pspace_data): Change type.
4165         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4166         (get_objfile_pspace_data): Update.
4167         (objfiles_bfd_data): Change type.
4168         (get_objfile_bfd_data): Update.
4169         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4170
4171 2019-05-08  Tom Tromey  <tom@tromey.com>
4172
4173         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4174         Change type.
4175         (get_catch_syscall_inferior_data): Update.
4176         (catch_syscall_inferior_data_cleanup): Remove.
4177         (_initialize_break_catch_syscall): Update.
4178
4179 2019-05-08  Tom Tromey  <tom@tromey.com>
4180
4181         * inflow.c (struct terminal_info): Add destructor and
4182         initializers.
4183         (inflow_inferior_data): Change type.
4184         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4185         (get_inflow_inferior_data, inflow_inferior_exit)
4186         (swap_terminal_info, _initialize_inflow): Update.
4187
4188 2019-05-08  Tom Tromey  <tom@tromey.com>
4189
4190         * target-dcache.c (target_dcache_cleanup): Remove.
4191         (target_dcache_aspace_key): Change type.
4192         (target_dcache_init_p, target_dcache_invalidate)
4193         (target_dcache_get, target_dcache_get_or_init)
4194         (_initialize_target_dcache): Update.
4195         * dcache.h (struct dcache_deleter): New.
4196
4197 2019-05-08  Tom Tromey  <tom@tromey.com>
4198
4199         * symtab.c (struct symbol_cache): Add destructor and
4200         initializers.
4201         (symbol_cache_key): Move.  Change type.
4202         (make_symbol_cache, free_symbol_cache): Remove.
4203         (get_symbol_cache): Update.
4204         (symbol_cache_cleanup): Remove.
4205         (ALL_PSPACES, symbol_cache_flush)
4206         (maintenance_print_symbol_cache)
4207         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4208         Update.
4209
4210 2019-05-08  Tom Tromey  <tom@tromey.com>
4211
4212         * symtab.c (struct main_info): Add destructor and initializers.
4213         (main_progspace_key): Move.  Change type.
4214         (get_main_info): Update.
4215         (main_info_cleanup): Remove.
4216         (_initialize_symtab): Update.
4217
4218 2019-05-08  Tom Tromey  <tom@tromey.com>
4219
4220         * registry.h (DECLARE_REGISTRY): Define the _key class.
4221
4222 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4223
4224         * NEWS: Merge two 'New commands' sections.
4225
4226 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4227
4228         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4229         parameter and use Ada language definition instead.
4230         (ada_val_print_ptr): Remove unused language parameter.
4231         (ada_val_print_num): Remove language parameter and use Ada language
4232         definition instead.
4233         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4234         parameter.
4235         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4236         parameter and use Ada language definition instead.
4237         (ada_val_print_1): Update all ada_val_print_xxx calls.
4238         Remove language parameter.
4239         (ada_val_print): Update ada_val_print_1 call.
4240
4241 2019-05-08  Tom Tromey  <tromey@adacore.com>
4242
4243         * remote.c (remote_hw_watchpoint_limit)
4244         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4245         Now static.
4246
4247 2019-05-08  Tom Tromey  <tromey@adacore.com>
4248
4249         * maint.c (_initialize_maint_cmds): Move initialization code to
4250         remote.c.
4251         (watchdog, show_watchdog): Move to remote.c.
4252         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4253         "watchdog" static.
4254         (_initialize_remote): Move initialization code from maint.c.
4255         * defs.h (watchdog): Don't declare.
4256
4257 2019-05-08  Tom Tromey  <tromey@adacore.com>
4258
4259         * tui/tui-interp.c: Include main.h.
4260         * interps.c: Include main.h.
4261         * main.h (interpreter_p): Declare.
4262         * defs.h (interpreter_p): Don't declare.
4263
4264 2019-05-08  Tom Tromey  <tromey@adacore.com>
4265
4266         * dwarf2loc.c: Include dwarf2read.h.
4267         * defs.h (read_unsigned_leb128): Don't declare.
4268         * dwarf2read.h (read_unsigned_leb128): Declare.
4269
4270 2019-05-08  Tom Tromey  <tromey@adacore.com>
4271
4272         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4273         method.
4274
4275 2019-05-08  Tom Tromey  <tromey@adacore.com>
4276
4277         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4278         when no wrap column is set.
4279
4280 2019-05-08  Tom Tromey  <tromey@adacore.com>
4281
4282         * c-lang.c (c_get_string): Handle non-C-style arrays.
4283
4284 2019-05-08  Tom Tromey  <tromey@adacore.com>
4285
4286         * typeprint.c (print_offset_data::update): Print the bit offset,
4287         not the number of bits remaining.
4288
4289 2019-05-08  Tom Tromey  <tromey@adacore.com>
4290
4291         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4292         padding at end of comment.
4293
4294 2019-05-08  Tom Tromey  <tromey@adacore.com>
4295
4296         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4297         Compare main types.
4298
4299 2019-05-06  Tom Tromey  <tom@tromey.com>
4300
4301         * common/scoped_mmap.c: Include common-defs.h.
4302         * common/scoped_mmap.h: Don't include config.h.
4303
4304 2019-05-04  Tom Tromey  <tom@tromey.com>
4305
4306         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4307         (struct aarch64_call_info): Add initializers.
4308         <si>: Now a std::vector.
4309         (pass_on_stack, aarch64_push_dummy_call): Update.
4310
4311 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4312             Tom Tromey  <tom@tromey.com>
4313
4314         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4315         (ppc_threads): Now a std::vector.  Now static.
4316         (hwdebug_find_thread_points_by_tid)
4317         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4318         Update.
4319
4320 2019-05-04  Tom Tromey  <tom@tromey.com>
4321
4322         * arc-tdep.c (arc_tdesc_init): Return bool.
4323
4324 2019-05-04  Tom Tromey  <tom@tromey.com>
4325
4326         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4327         Use gdb_assert_not_reached.
4328
4329 2019-05-04  Tom Tromey  <tom@tromey.com>
4330
4331         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4332         "false".
4333
4334 2019-05-04  Tom Tromey  <tom@tromey.com>
4335
4336         * arc-tdep.c (arc_tdesc_init): Use bool.
4337
4338 2019-05-04  Tom Tromey  <tom@tromey.com>
4339
4340         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4341
4342 2019-05-04  Tom Tromey  <tom@tromey.com>
4343
4344         * cli/cli-cmds.c (valid_command_p): Return bool.
4345
4346 2019-05-04  Tom Tromey  <tom@tromey.com>
4347
4348         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4349         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4350
4351 2019-05-04  Raul Tambre  <raul@tambre.ee>
4352
4353         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4354         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4355         operator for comparison.
4356
4357 2019-05-04  Tom Tromey  <tom@tromey.com>
4358
4359         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4360         (lookup_partial_symbol, print_partial_symbols)
4361         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4362         (psymbol_compare): Update.
4363         (add_psymbol_to_bcache): Clear the entire psymbol.
4364         (maintenance_check_psymtabs): Update.
4365         * psympriv.h (struct partial_symbol): Don't derive from
4366         general_symbol_info.
4367         <obj_section, unrelocated_address, address,
4368         set_unrelocated_address>: Update.
4369         <ginfo>: New member.
4370         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4371         (debug_names::write_psymbols): Update.
4372
4373 2019-05-04  Tom de Vries  <tdevries@suse.de>
4374
4375         * contrib/cc-with-tweaks.sh: Support -n arg.
4376
4377 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4378
4379         * corelow.c (core_target::detach): Ensure frame cache and
4380         register caches are cleared.
4381         inferior.c (exit_inferior_1): Likewise.
4382
4383 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4384             Tom Tromey  <tom@tromey.com>
4385
4386         * dictionary.c (collate_pending_symbols_by_language): Remove
4387         "struct" from foreach.
4388         * symtab.c (lookup_global_symbol_from_objfile)
4389         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4390         foreach.
4391         * ser-tcp.c (net_open): Remove "struct" from foreach.
4392         * objfiles.c (objfile_relocate, objfile_rebase)
4393         (objfile_has_symbols): Remove "struct" from foreach.
4394         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4395         from foreach.
4396         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4397         foreach.
4398         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4399         "struct" from foreach.
4400         * ada-lang.c (create_excep_cond_exprs)
4401         (ada_exception_catchpoint_cond_string): Remove "struct" from
4402         foreach.
4403
4404 2019-05-03  Tom Tromey  <tromey@adacore.com>
4405
4406         * ada-exp.y (convert_char_literal): Check suffix of each
4407         enumerator.
4408
4409 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4410
4411         PR ada/21406:
4412         * ada-exp.y (yywrap): Don't define.
4413         * ada-lex.l (%option): Add noyywrap
4414         (yywrap): Remove.
4415
4416 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4417
4418         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4419         _WIN32_WINNT to the XP level, unless already defined to a higher
4420         level.
4421
4422         * unittests/parse-connection-spec-selftests.c:
4423         * ser-tcp.c:
4424         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4425         override.
4426
4427         * symfile.c (find_separate_debug_file): Remove colon from the
4428         drive spec of DOS/Windows file names of the target, so that the
4429         file name produced from DEBUGDIR and the target's directory will
4430         be valid on DOS/Windows systems.
4431
4432 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4433
4434         * rust-lang.c (val_print_struct): Handle printing structures
4435         containing strings.
4436
4437 2019-05-02  Tom Tromey  <tromey@adacore.com>
4438
4439         * valarith.c (_initialize_valarith): Remove.
4440
4441 2019-05-01  Tom Tromey  <tromey@adacore.com>
4442
4443         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4444         bitfields.
4445
4446 2019-05-01  Tom Tromey  <tromey@adacore.com>
4447
4448         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4449         for big-endian copies.
4450
4451 2019-04-30  Ali Tamur  <tamur@google.com>
4452         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4453         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4454         (read_3_bytes): New function.
4455
4456 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4457
4458         * windows-nat.c (main_thread_id): Delete.
4459         (handle_output_debug_string): Replace main_thread_id by
4460         current_event.dwThreadId.
4461         (fake_create_process): Likewise.
4462         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4463         Do not set main_thread_id.
4464         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4465         current_event.dwThreadId.
4466         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4467
4468 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4469
4470         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4471         Use current_event.dwThreadId instead of main_thread_id.
4472
4473 2019-04-30  Tom Tromey  <tromey@adacore.com>
4474
4475         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4476         (create_excep_cond_exprs): Iterate over program spaces.
4477         (ada_exception_catchpoint_cond_string): Examine all minimal
4478         symbols for exception types.
4479
4480 2019-04-30  Tom Tromey  <tromey@adacore.com>
4481
4482         PR c++/24470:
4483         * dwarf2read.c (process_structure_scope): Handle case where type
4484         has template parameters but no symbol was created.
4485
4486 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4487             Chris January  <chris.january@arm.com>
4488
4489         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4490         qualifier.
4491         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4492
4493 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4494
4495         * f-typeprint.c (f_print_type): Update rules for printing
4496         whitespace.
4497         (f_type_print_varspec_suffix): Likewise.
4498
4499 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4500             Chris January  <chris.january@arm.com>
4501
4502         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4503         function arguments.
4504
4505 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4506
4507         * f-lang.c (build_fortran_types): Change name of void type to
4508         lower case.
4509         * f-typeprint.c (f_type_print_base): Print the name of the void
4510         type, rather than a fixed string.
4511         * f-valprint.c (f_decorations): Use lower case void string.
4512
4513 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4514             Chris January  <chris.january@arm.com>
4515
4516         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4517         types for Fortran.
4518
4519 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4520             Chris January  <chris.january@arm.com>
4521             David Lecomber  <david.lecomber@arm.com>
4522
4523         * f-exp.y (BINOP_INTRINSIC): New token.
4524         (exp): New parser rule handling BINOP_INTRINSIC.
4525         (f77_keywords): Add new builtin procedures.
4526         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4527         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4528         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4529         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4530         (print_unop_subexp_f): New function.
4531         (print_binop_subexp_f): New function.
4532         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4533         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4534         (dump_subexp_body_f): Likewise.
4535         (operator_check_f): Likewise.
4536         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4537         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4538
4539 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4540
4541         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4542         UNOP_KIND.
4543         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4544         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4545         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4546         (operator_length_f): New fuction.
4547         (print_subexp_f): New function.
4548         (op_name_f): New function.
4549         (dump_subexp_body_f): New function.
4550         (operator_check_f): New function.
4551         (exp_descriptor_f): Replace standard expression handling functions
4552         with new functions.
4553         * gdb/fortran-operator.def: New file.
4554         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4555         * gdb/std-operator.def: Remove UNOP_KIND.
4556
4557 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4558
4559         * std-operator.def: Remove unbalanced, stray double quote
4560         character.
4561
4562 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4563             Chris January  <chris.january@arm.com>
4564             Daniel Everett  <daniel.everett@arm.com>
4565             Nick Forrington  <nick.forrington@arm.com>
4566             Richard Bunt  <richard.bunt@arm.com>
4567
4568         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4569         of depth when printing anonymous structs or unions.
4570         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4571         Don't print either the top-level value, or the children if the
4572         max-depth is exceeded.
4573         (ppscm_print_children): When printing the key of a map, allow one
4574         extra level of depth.
4575         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4576         print either the top-level value, or the children if the max-depth
4577         is exceeded.
4578         (print_children): When printing the key of a map, allow one extra
4579         level of depth.
4580         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4581         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4582         (user_print_options): Initialise max_depth field.
4583         (val_print_scalar_or_string_type_p): New function.
4584         (val_print): Check to see if the max depth has been reached.
4585         (val_print_check_max_depth): Define new function.
4586         (show_print_max_depth): New function.
4587         (_initialize_valprint): Add 'print max-depth' option.
4588         * valprint.h (struct value_print_options) <max_depth>: New field.
4589         (val_print_check_max_depth): Declare new function.
4590         * NEWS: Document new feature.
4591
4592 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4593
4594         * ada-lang.c (ada_language_defn): Initialise new field.
4595         * c-lang.c (c_is_string_type_p): New function.
4596         (c_language_defn): Initialise new field.
4597         (cplus_language_defn): Initialise new field.
4598         (asm_language_defn): Initialise new field.
4599         (minimal_language_defn): Initialise new field.
4600         * c-lang.h (c_is_string_type_p): Declare new function.
4601         * d-lang.c (d_language_defn): Initialise new field.
4602         * f-lang.c (f_is_string_type_p): New function.
4603         (f_language_defn): Initialise new field.
4604         * go-lang.c (go_is_string_type_p): New function.
4605         (go_language_defn): Initialise new field.
4606         * language.c (default_is_string_type_p): New function.
4607         (unknown_language_defn): Initialise new field.
4608         (auto_language_defn): Initialise new field.
4609         * language.h (struct language_defn) <la_is_string_type_p>: New
4610         member variable.
4611         (default_is_string_type_p): Declare new function.
4612         * m2-lang.c (m2_language_defn): Initialise new field.
4613         * objc-lang.c (objc_language_defn): Initialise new field.
4614         * opencl-lang.c (opencl_language_defn): Initialise new field.
4615         * p-lang.c (pascal_is_string_type_p): New function.
4616         (pascal_language_defn): Initialise new field.
4617         * rust-lang.c (rust_is_string_type_p): New function.
4618         (rust_language_defn): Initialise new field.
4619
4620 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4621
4622         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4623         New field.
4624         * ada-lang.c (ada_language_defn): Initialise new field.
4625         * c-lang.c (c_language_defn): Likewise.
4626         (cplus_language_defn): Likewise.
4627         (asm_language_defn): Likewise.
4628         (minimal_language_defn): Likewise.
4629         * d-lang.c (d_language_defn): Likewise.
4630         * f-lang.c (f_language_defn): Likewise.
4631         * go-lang.c (go_language_defn): Likewise.
4632         * language.c (unknown_language_defn): Likewise.
4633         (auto_language_defn): Likewise.
4634         * m2-lang.c (m2_language_defn): Likewise.
4635         * objc-lang.c (objc_language_defn): Likewise.
4636         * opencl-lang.c (opencl_language_defn): Likewise.
4637         * p-lang.c (pascal_language_defn): Likewise.
4638         * rust-lang.c (rust_language_defn): Likewise.
4639
4640 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4641
4642         * ada-lang.c (ada_is_character_type): Change return type to bool.
4643         (ada_is_string_type): Likewise.
4644         * ada-lang.h (ada_is_character_type): Update declaration
4645         (ada_is_string_type): Likewise.
4646
4647 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4648
4649         Support style in 'frame|thread apply'
4650
4651         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4652         * record.c (record_start, record_stop): Update callers of
4653         execute_command_to_string with false.
4654         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4655         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4656         methods.
4657         (class string_file): New constructor with term_out parameter.
4658         Override methods term_out and can_emit_style_escape.  New member
4659         term_out.
4660         (class stdio_file): Override can_emit_style_escape.
4661         (class tee_file): Override term_out and can_emit_style_escape.
4662         * utils.h (can_emit_style_escape): Remove.
4663         * utils.c (can_emit_style_escape): Likewise.
4664         Update all callers of can_emit_style_escape (SOMESTREAM) to
4665         SOMESTREAM->can_emit_style_escape.
4666         * source-cache.c (source_cache::get_source_lines): Likewise.
4667         * stack.c (frame_apply_command_count): Call execute_command_to_string
4668         passing the term_out characteristic of the current gdb_stdout.
4669         * thread.c (thr_try_catch_cmd): Likewise.
4670         * top.c (execute_command_to_string): pass term_out parameter
4671         to construct the string_file for the command output.
4672         * ui-file.c (term_cli_styling): New function (most code moved
4673         from utils.c can_emit_style_escape).
4674         (string_file::string_file, string_file::can_emit_style_escape,
4675         stdio_file::can_emit_style_escape, tee_file::term_out,
4676         tee_file::can_emit_style_escape): New functions.
4677
4678 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4679
4680         * NEWS: Mention the new set|show may-call-functions.
4681         * infcall.c (may_call_functions_p): New variable.
4682         (show_may_call_functions_p): New function.
4683         (call_function_by_hand_dummy): Throws an error if not
4684         may-call-functions.
4685         (_initialize_infcall): Call add_setshow_boolean_cmd for
4686         may-call-functions.
4687
4688 2019-04-25  Keith Seitz  <keiths@redhat.com>
4689
4690         PR c++/24367
4691         * cp-support.c (inspect_type): Don't attempt substitutions
4692         of symbol with the same name.
4693
4694 2019-04-25  Tom Tromey  <tromey@adacore.com>
4695
4696         PR gdb/24475:
4697         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4698         static.
4699
4700 2019-04-25  Tom Tromey  <tromey@adacore.com>
4701
4702         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4703         rvalue reference.
4704         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4705         (gdb_xml_parser::parse): Use std::move.
4706         * python/python-internal.h (gdbpy_convert_exception): Take a const
4707         reference.
4708         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4709         std::move.
4710         * python/py-utils.c (gdbpy_convert_exception): Take a const
4711         reference.
4712         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4713         Use std::move.
4714         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4715         Use std::move.
4716         * mi/mi-main.c (mi_print_exception): Take a const reference.
4717         * main.c (handle_command_errors): Take a const reference.
4718         * linespec.c (parse_linespec): Use std::move.
4719         * infcall.c (run_inferior_call): Use std::move.
4720         (call_function_by_hand_dummy): Use std::move.
4721         * exec.c (try_open_exec_file): Use std::move.
4722         * exceptions.h (exception_print, exception_fprintf)
4723         (exception_print_same): Update.
4724         * exceptions.c (print_exception, exception_print)
4725         (exception_fprintf, exception_print_same): Change parameters to
4726         const reference.
4727         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4728         * common/new-op.c: Use std::move.
4729         * common/common-exceptions.h (struct gdb_exception): Add move
4730         constructor.
4731         (struct gdb_exception_error, struct gdb_exception_quit, struct
4732         gdb_quit_bad_alloc): Change constructor to move constructor.
4733         (throw_exception): Change parameter to rvalue reference.
4734         * common/common-exceptions.c (throw_exception): Take rvalue
4735         reference.
4736         * cli/cli-interp.c (safe_execute_command): Use std::move.
4737         * breakpoint.c (insert_bp_location, location_to_sals): Use
4738         std::move.
4739
4740 2019-04-25  Tom Tromey  <tromey@adacore.com>
4741
4742         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4743         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4744         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4745         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4746         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4747         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4748         guile/scm-value.c: Use unpack.
4749         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4750         gdbscm_gdb_exception.
4751         (gdbscm_throw_gdb_exception): Likewise.
4752         (struct gdbscm_gdb_exception): New.
4753         (unpack): New function.
4754         (gdbscm_wrap): Use unpack.
4755
4756 2019-04-25  Tom Tromey  <tromey@adacore.com>
4757
4758         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4759         (gdb_rl_callback_handler): Use std::move.
4760         * common/common-exceptions.h (struct gdb_exception): Add move
4761         assignment operator.
4762         (throw_exception_sjlj): Change "exception" to const reference.
4763         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4764         (throw_exception_sjlj): Change "exception" to const reference.
4765
4766 2019-04-25  Tom Tromey  <tromey@adacore.com>
4767
4768         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4769         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4770         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4771         Update.
4772         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4773         Update.
4774         * mi/mi-interp.c (mi_interp::exec): Update.
4775         * linespec.c (parse_linespec): Update.
4776         * infcall.c (run_inferior_call): Update.
4777         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4778         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4779         (gdbscm_lookup_global_symbol): Update.
4780         * guile/scm-param.c (gdbscm_parameter_value): Update.
4781         * guile/scm-frame.c (gdbscm_frame_read_register)
4782         (gdbscm_frame_read_var): Update.
4783         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4784         * exec.c (try_open_exec_file): Update.
4785         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4786         (gdb_rl_callback_handler): Update.
4787         * common/common-exceptions.h (exception_none): Don't declare.
4788         * common/common-exceptions.c (exception_none): Don't define.
4789         (struct catcher) <exception>: Update.
4790         * cli/cli-interp.c (safe_execute_command): Update.
4791         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4792
4793 2019-04-25  Ali Tamur  <tamur@google.com>
4794
4795         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4796         (read_attribute_value): Likewise.
4797         (dwarf2_read_addr_index): Update comment.
4798         (read_str_index): Add DW_FORM_strx.
4799         (dwarf2_string_attr): Likewise.
4800         (dwarf2_const_value_attr): Likewise.
4801         (dump_die_shallow): Likewise.
4802         (dwarf2_fetch_constant_bytes): Likewise.
4803         (skip_form_bytes): Likewise.
4804         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4805
4806 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4807
4808         PR corefiles/11608
4809         PR corefiles/18187
4810         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4811         OFFSET.  Verify if current mapping contains an ELF header.
4812         (linux_find_memory_regions_full): Adjust call to
4813         dump_mapping_p.
4814
4815 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4816             Kang Li <kanglictf@gmail.com>
4817
4818         PR gdb/21600
4819
4820         * dwarf2-frame.c (read_initial_length): Be consistent about using
4821         unsigned representation of length.
4822         (decode_frame_entry_1): Likewise.  Check for wraparound of
4823         end pointer as well as buffer overflow.
4824
4825 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4826
4827         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4828         "vq".
4829
4830 2019-04-24  Tom Tromey  <tromey@adacore.com>
4831
4832         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4833
4834 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4835
4836         * s12z-tdep.c (s12z_unwind_pc): Delete.
4837         (s12z_unwind_sp): Delete.
4838         (s12z_gdbarch_init): Don't register deleted functions with
4839         gdbarch.
4840
4841 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4842
4843         * rl78-tdep.c (rl78_unwind_sp): Delete.
4844         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4845
4846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4847
4848         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4849         (xstormy16_unwind_pc): Delete.
4850         (xstormy16_dummy_id): Delete.
4851         (xstormy16_gdbarch_init): Don't register deleted functions with
4852         gdbarch.
4853
4854 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4855
4856         * vax-tdep.c (vax_unwind_pc): Delete.
4857         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4858
4859 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4860
4861         * v850-tdep.c (v850_unwind_sp): Delete.
4862         (v850_unwind_pc): Delete.
4863         (v850_dummy_id): Delete.
4864         (v850_gdbarch_init): Don't register deleted functions with
4865         gdbarch.
4866
4867 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4868
4869         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4870         (tilegx_unwind_pc): Delete.
4871         (tilegx_unwind_dummy_id): Delete.
4872         (tilegx_gdbarch_init): Don't register deleted functions with
4873         gdbarch.
4874
4875 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4876
4877         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4878         (tic6x_dummy_id): Delete.
4879         (tic6x_gdbarch_init): Don't register deleted functions with
4880         gdbarch.
4881
4882 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4883
4884         * sparc-tdep.c (sparc_unwind_pc): Delete.
4885         (sparc32_gdbarch_init): Don't register deleted function with
4886         gdbarch.
4887
4888 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4889
4890         * sh-tdep.c (sh_unwind_sp): Delete.
4891         (sh_unwind_pc): Delete.
4892         (sh_dummy_id): Delete.
4893         (sh_gdbarch_init): Don't register deleted functions with
4894         gdbarch.
4895
4896 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4897
4898         * score-tdep.c (score_unwind_sp): Delete.
4899         (score_unwind_pc): Delete.
4900         (score_dummy_id): Delete.
4901         (score_gdbarch_init): Don't register deleted functions with
4902         gdbarch.
4903
4904 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4905
4906         * rx-tdep.c (rx_unwind_pc): Delete.
4907         (rx_unwind_sp): Delete.
4908         (rx_dummy_id): Delete.
4909         (rx_gdbarch_init): Don't register deleted functions with
4910         gdbarch.  Update comment.
4911
4912 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4913
4914         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4915         (rs6000_dummy_id): Delete.
4916         (rs6000_gdbarch_init): Don't register deleted functions with
4917         gdbarch.
4918
4919 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4920
4921         * or1k-tdep.c (or1k_dummy_id): Delete.
4922         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4923
4924 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4925
4926         * nios2-tdep.c (nios2_dummy_id): Delete.
4927         (nios2_unwind_sp): Delete.
4928         (nios2_gdbarch_init): Don't register deleted functions with
4929         gdbarch.
4930
4931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4932
4933         * nds32-tdep.c (nds32_dummy_id): Delete.
4934         (nds32_unwind_pc): Delete.
4935         (nds32_unwind_sp): Delete.
4936         (nds32_gdbarch_init): Don't register deleted functions with
4937         gdbarch.
4938
4939 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4940
4941         * msp430-tdep.c (msp430_unwind_pc): Delete.
4942         (msp430_unwind_sp): Delete.
4943         (msp430_dummy_id): Delete.
4944         (msp430_gdbarch_init): Don't register deleted functions with
4945         gdbarch.
4946
4947 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4948
4949         * moxie-tdep.c (moxie_unwind_sp): Delete.
4950         (moxie_unwind_pc): Delete.
4951         (moxie_dummy_id): Delete.
4952         (moxie_gdbarch_init): Don't register deleted functions with
4953         gdbarch.
4954
4955 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4956
4957         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4958         (mn10300_unwind_pc): Delete.
4959         (mn10300_unwind_sp): Delete.
4960         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4961         mn10300_unwind_sp.
4962         (mn10300_frame_unwind_init): Don't register deleted functions with
4963         gdbarch.
4964
4965 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4966
4967         * mep-tdep.c (mep_unwind_pc): Delete.
4968         (mep_unwind_sp): Delete.
4969         (mep_dummy_id): Delete.
4970         (mep_gdbarch_init): Don't register deleted functions with
4971         gdbarch.
4972
4973 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4974
4975         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4976         (m68hc11_unwind_sp): Delete.
4977         (m68hc11_gdbarch_init): Don't register deleted functions with
4978         gdbarch.
4979
4980 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4981
4982         * m32r-tdep.c (m32r_unwind_sp): Delete.
4983         (m32r_unwind_pc): Delete.
4984         (m32r_dummy_id): Delete.
4985         (m32r_gdbarch_init): Don't register deleted functions with
4986         gdbarch.
4987
4988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4989
4990         * m32c-tdep.c (m32c_unwind_pc): Delete.
4991         (m32c_unwind_sp): Delete.
4992         (m32c_dummy_id): Delete.
4993         (m32c_gdbarch_init): Don't register deleted functions with
4994         gdbarch.
4995
4996 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4997
4998         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4999         (lm32_unwind_pc): Delete.
5000         (lm32_dummy_id): Delete.
5001         (lm32_gdbarch_init): Don't register deleted functions with
5002         gdbarch.
5003
5004 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5005
5006         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5007         (iq2000_unwind_pc): Delete.
5008         (iq2000_dummy_id): Delete.
5009         (iq2000_gdbarch_init): Don't register deleted functions with
5010         gdbarch.
5011
5012 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5013
5014         * nds32-tdep.c (nds32_type_align): Delete.
5015         (nds32_push_dummy_call): Use type_align instead.
5016
5017 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5018
5019         * arm-tdep.c (arm_type_align): Only handle vector override case.
5020         (arm_push_dummy_call): Use type_align.
5021         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5022
5023 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5024
5025         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5026         case.
5027         (pass_on_stack): Use type_align.
5028         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5029         function.
5030
5031 2019-04-23  Tom Tromey  <tromey@adacore.com>
5032
5033         * dwarf2read.c (line_header::file_name_at): Remove unused
5034         overload.
5035
5036 2019-04-23  Tom de Vries  <tdevries@suse.de>
5037
5038         PR gdb/24438
5039         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5040         invocation.
5041
5042
5043 2019-03-27  Ali Tamur  <tamur@google.com>
5044
5045         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5046         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5047         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5048         (dwarf_expr_context::get_addr_index): Likewise
5049         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5050         (symbol_needs_eval_context::get_addr_index): Likewise
5051         (disassemble_dwarf_expression): Add DW_OP_addrx
5052         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5053         (read_cutu_die_from_dwo): Update comment
5054         (skip_one_die): Add DW_FORM_addrx
5055         (read_attribute_value): Likewise
5056         (var_decode_location): Add DW_OP_addrx
5057         (dwarf2_const_value_attr): Add DW_FORM_addrx
5058         (dump_die_shallow): Likewise
5059         (dwarf2_fetch_constant_bytes): Likewise
5060         (decode_locdesc): Add DW_OP_addrx
5061         (skip_form_bytes): Add DW_FORM_addrx
5062
5063 2019-04-22  Ali Tamur  <tamur@google.com>
5064
5065         * MAINTAINERS (Write After Approval): Add self.
5066
5067 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5068
5069         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5070         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5071         (open_symbol_file_object): Likewise.
5072         (svr4_default_sos): Add info parameter.
5073         (svr4_read_so_list): Likewise.
5074         (svr4_current_sos_direct): Adjust functions calls to pass down
5075         info.
5076         (svr4_current_sos_1): Add info parameter.
5077         (svr4_current_sos): Call get_svr4_info, pass info down to
5078         svr4_current_sos_1.
5079         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5080         get_svr4_info.
5081         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5082         get_svr4_info.
5083         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5084         to get_svr4_info.
5085         (probes_table_remove_objfile_probes): Likewise.
5086         (register_solib_event_probe): Add info parameter.
5087         (solist_update_incremental): Pass info parameter down to
5088         svr4_read_so_list.
5089         (disable_probes_interface): Add info parameter.
5090         (svr4_handle_solib_event): Pass current_program_space to
5091         get_svr4_info.  Adjust disable_probes_interface cleanup.
5092         (svr4_create_probe_breakpoints): Add info parameter, pass it
5093         down to register_solib_event_probe.
5094         (svr4_create_solib_event_breakpoints): Add info parameter,
5095         pass it down to svr4_create_probe_breakpoints.
5096         (enable_break): Pass info down to
5097         svr4_create_solib_event_breakpoints.
5098         (svr4_solib_create_inferior_hook): Pass current_program_space to
5099         get_svr4_info.
5100         (svr4_clear_solib): Likewise.
5101
5102 2019-04-22  Pedro Alves  <palves@redhat.com>
5103
5104         * solib-svr4.c (svr4_free_objfile_observer): New.
5105         (probe_and_action::objfile): New field.
5106         (probes_table_htab_remove_objfile_probes)
5107         (probes_table_remove_objfile_probes): New functions.
5108         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5109         in the new probe_and_action.  Don't store the probe in 'lookup'.
5110         (svr4_create_probe_breakpoints): Pass objfile to
5111         register_solib_event_probe.
5112         (_initialize_svr4_solib): Register a free_objfile observer.
5113
5114 2019-04-19  Tom Tromey  <tom@tromey.com>
5115
5116         * common/queue.h: Remove.
5117
5118 2019-04-19  Tom Tromey  <tom@tromey.com>
5119
5120         * event-loop.c: Don't include "common/queue.h".
5121
5122 2019-04-19  Tom Tromey  <tom@tromey.com>
5123
5124         * remote.c (remote_target): Use delete.
5125         * remote-notif.h: Include <list>, not "common/queue.h".
5126         (notif_client_p): Remove typedef.
5127         (remote_notif_state): Add constructor, destructor, initializer.
5128         <notif_queue>: Now a std::list.
5129         (remote_notif_state_xfree): Don't declare.
5130         * remote-notif.c (remote_notif_process, handle_notification)
5131         (remote_notif_state_allocate): Update.
5132         (~remote_notif_state): Rename from remote_notif_state_xfree.
5133
5134 2019-04-19  Tom Tromey  <tom@tromey.com>
5135
5136         * symfile.c (reread_symbols): Update.
5137         * objfiles.c (objfile_register_static_link)
5138         (objfile_lookup_static_link): Update
5139         (~objfile) Don't delete static_links.
5140         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5141
5142 2019-04-19  Tom Tromey  <tom@tromey.com>
5143
5144         * type-stack.h (struct type_stack) <insert>: Constify string.
5145         * type-stack.c (type_stack::insert): Constify string.
5146         * gdbtypes.h (lookup_template_type): Update.
5147         (address_space_name_to_int): Update.
5148         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5149         const.
5150         (lookup_template_type): Make name const.
5151         * c-exp.y: Update rules.
5152         (lex_one_token, classify_name, classify_inner_name)
5153         (c_print_token): Update.
5154         * p-exp.y: Update rules.
5155         (yylex): Update.
5156         * f-exp.y: Update rules.
5157         (yylex): Update.
5158         * d-exp.y: Update rules.
5159         (lex_one_token, classify_name, classify_inner_name): Update.
5160         * parse.c (write_dollar_variable, copy_name): Return std::string.
5161         * parser-defs.h (copy_name): Change return type.
5162         * m2-exp.y: Update rules.
5163         (yylex): Update.
5164         * go-exp.y (lex_one_token): Update.
5165         Update rules.
5166         (classify_unsafe_function, classify_packaged_name)
5167         (classify_name, yylex): Update.
5168
5169 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5170
5171         * configure.ac: add --enable-source-highlight switch.
5172         * configure: Regenerate.
5173         * top.c (print_gdb_version): plumb --enable-source-highlight
5174         status to "show configuration".
5175
5176 2019-04-19  Tom Tromey  <tromey@adacore.com>
5177
5178         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5179         Check ADA_TYPE_P.
5180         (empty_record, ada_template_to_fixed_record_type_1)
5181         (template_to_static_fixed_type)
5182         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5183         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5184         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5185         macros.
5186
5187 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5188
5189         PR symtab/24423:
5190         * source.c (print_source_lines_base): Advance "iter" when a
5191         control character is seen.
5192
5193 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5194
5195         * inferior.h (struct infcall_suspend_state_deleter):
5196         Catch exception in destructor to avoid crash.
5197
5198 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5199
5200         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5201         close to the add_com "shell".
5202
5203 2019-04-18  Tom Tromey  <tromey@adacore.com>
5204
5205         * process-stratum-target.h (class process_stratum_target)
5206         <stratum>: Add "final".
5207
5208 2019-04-17  Tom Tromey  <tromey@adacore.com>
5209
5210         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5211         against nullptr before use.
5212
5213 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5214
5215         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5216
5217 2019-04-17  Jim Wilson  <jimw@sifive.com>
5218             Andrew Burgess  <andrew.burgess@embecosm.com>
5219
5220         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5221         code read might fail, assume 4-byte breakpoint in that case.
5222
5223 2019-04-15  Leszek Swirski  <leszeks@google.com>
5224
5225         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5226         rather than a hand-rolled POD check when checking for forced MEMORY
5227         classification.
5228
5229 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5230
5231         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5232         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5233         function.
5234         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5235         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5236         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5237         declaration.
5238
5239 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5240
5241         * aarch64-linux-nat.c
5242         (aarch64_linux_nat_target::thread_architecture): Add override.
5243         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5244         each VQ.
5245
5246 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5247
5248         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5249
5250 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5251
5252         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5253         target types of size 96-bits, add some additional comments, and
5254         check that the builtin type we found was the correct size.
5255
5256 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5257
5258         * utils.c (prompt_for_continue): Don't restore the styling at the
5259         end, as applied_style has the wrong value.  This fixes styling in
5260         long lists of file names that are interrupted by the "Continue?"
5261         prompt.
5262
5263 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5264
5265         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5266         * c-lang.c (c_language_defn): Likewise.
5267         (cplus_language_defn): Likewise.
5268         (asm_language_defn): Likewise.
5269         (minimal_language_defn): Likewise.
5270         * d-lang.c (d_language_defn): Likewise.
5271         * f-lang.c (f_language_defn): Likewise.
5272         * go-lang.c (go_language_defn): Likewise.
5273         * language.c (unknown_language_defn): Likewise.
5274         (auto_language_defn): Likewise.
5275         * language.h (struct language_defn): Remove la_magic field.
5276         (LANG_MAGIC): Delete.
5277         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5278         * objc-lang.c (objc_language_defn): Likewise.
5279         * opencl-lang.c (opencl_language_defn): Likewise.
5280         * p-lang.c (pascal_language_defn): Likewise.
5281         * rust-lang.c (rust_language_defn): Likewise.
5282
5283 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5284
5285         * riscv-tdep.c (riscv_type_align): New function.
5286         (riscv_type_alignment): Delete.
5287         (riscv_arg_location): Use 'type_align'.
5288         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5289
5290 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5291
5292         * gdbtypes.c (type_align): A struct with no non-static fields also
5293         has alignment of 1.
5294
5295 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5296
5297         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5298         component to 0.
5299         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5300         member.
5301         (riscv_struct_info::analyse): New implementation using new
5302         analyse_inner member function.
5303         (riscv_struct_info::field_offset): New member function.
5304         (riscv_struct_info::m_offsets): New member variable.
5305         (riscv_struct_info::analyse_inner): New private member function,
5306         takes the old implementation of riscv_struct_info::analyse but
5307         extended to track field offsets.
5308         (riscv_call_arg_struct): Update the struct folding special cases
5309         to handle cases where empty C++ structs, which are non-zero
5310         length, are found.
5311         (riscv_arg_location): Initialise the length of each location, a
5312         non-zero length now indicates the location is in use.
5313         (riscv_push_dummy_call): Allow for the first location having a
5314         non-zero offset when setting up arguments.
5315         (riscv_return_value): Likewise, but for return values.
5316
5317 2019-04-11  Tom Tromey  <tromey@adacore.com>
5318
5319         * utils.c (internal_vproblem): Make "msg" const.
5320
5321 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5322
5323         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5324         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5325         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5326         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5327
5328 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5329
5330         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5331         function.
5332         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5333         of amd64_collect_native_gregset.
5334         (amd64_linux_nat_target::store_registers): Likewise.
5335
5336 2019-04-10  Tom Tromey  <tom@tromey.com>
5337
5338         * symtab.c (lookup_global_symbol_from_objfile)
5339         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5340         * objfiles.h (class separate_debug_iterator): New.
5341         (class separate_debug_range): New.
5342         (struct objfile) <separate_debug_objfiles>: New method.
5343         (objfile_separate_debug_iterate): Don't declare.
5344         * objfiles.c (separate_debug_iterator::operator++): Rename from
5345         objfile_separate_debug_iterate.
5346         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5347         iterator.
5348         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5349         iterator.
5350
5351 2019-04-10  Tom Tromey  <tom@tromey.com>
5352
5353         * symfile.c (reread_symbols): Remove old comment.
5354         * objfiles.c (free_all_objfiles): Fix a typo.
5355
5356 2019-04-10  Tom Tromey  <tom@tromey.com>
5357
5358         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5359         * minsyms.c (lookup_minimal_symbol): Use foreach.
5360         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5361         (lookup_minimal_symbol_solib_trampoline): Likewise.
5362         * symfile.c (reread_symbols): Use foreach.
5363
5364 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5365             Tom Tromey  <tromey@adacore.com>
5366
5367         PR rust/24414:
5368         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5369         (rust_lex_int_test): Change "value" to be LONGEST.
5370         (rust_lex_tests): Add test for long integer literal.
5371
5372 2019-04-09  Tom Tromey  <tromey@adacore.com>
5373
5374         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5375         to bool.
5376         (extended_remote_target::attach): Update.
5377         (remote_target::remote_notice_new_inferior): Update.
5378         (remote_target::add_current_inferior_and_thread): Update.
5379         * inferior.c (exit_inferior_1): Use "false".
5380         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5381
5382 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5383
5384         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5385         the "start" command.
5386
5387 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5388
5389         * python/py-inferior.c (infpy_thread_from_thread_handle):
5390         Adjust comments to reflect renaming of thread_from_thread_handle
5391         to thread_from_handle.  Adjust keywords.  Fix type error message.
5392         (inferior_object_methods): Add thread_from_handle.  Retain
5393         thread_from_thread_handle, but mark it as deprecated.
5394
5395 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5396
5397         * gdbthread.h (find_thread_by_handle): Revise declaration.
5398         * thread.c (find_thread_by_handle): Likewise.  Adjust
5399         implementation too.
5400         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5401         support for buffer objects as handles.
5402
5403 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5404
5405         * python/py-infthread.c (thpy_thread_handle): New function.
5406         (thread_object_methods): Register thpy_thread_handle.
5407
5408 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5409
5410         * gdbthread.h (thread_to_thread_handle): Declare.
5411         * thread.c (gdbtypes.h): Include.
5412         (thread_to_thread_handle): New function.
5413
5414         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5415         (target_thread_info_to_thread_handle): Declare.
5416         * target.c (target_thread_info_to_thread_handle): New function.
5417         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5418         * target-delegates.c: Regenerate.
5419
5420         * linux-thread-db.c (class thread_db_target): Add method
5421         thread_info_to_thread_handle.
5422         (thread_db_target::thread_info_to_thread_handle): Define.
5423         * remote.c (class remote_target): Add new method
5424         thread_info_to_thread_handle.
5425         (remote_target::thread_info_to_thread_handle): Define.
5426
5427 2019-04-08  Pedro Alves  <palves@redhat.com>
5428
5429         * common/common-exceptions.c (throw_exception): Don't create
5430         named object to throw; throw directly.
5431         (throw_it): Likewise.  Don't initialize gdb_exception::message
5432         here, with new; pass FMT and AP to the ctor instead.
5433         * common/common-exceptions.h: Include <string>.
5434         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5435         const char *, va_list)): New ctor.  Use std::make_shared.
5436         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5437         errors)): Delete.
5438         (gdb_exception_error::gdb_exception_error(enum errors, const char
5439         *, va_list)): New.
5440         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5441         Add assertion.
5442         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5443         errors)): Delete.
5444         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5445         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5446         Add assertion.
5447
5448 2019-04-08  Tom Tromey  <tom@tromey.com>
5449
5450         * valops.c (value_rtti_indirect_type): Replace throw_exception
5451         with throw.
5452         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5453         with throw.
5454         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5455         throw.
5456         * target.c (target_translate_tls_address): Replace throw_exception
5457         with throw.
5458         * stack.c (frame_apply_command_count): Replace throw_exception
5459         with throw.
5460         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5461         throw.
5462         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5463         with throw.
5464         * rs6000-tdep.c (rs6000_frame_cache)
5465         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5466         * remote.c: Replace throw_exception with throw.
5467         * record-full.c (record_full_message, record_full_wait_1)
5468         (record_full_restore): Replace throw_exception with throw.
5469         * record-btrace.c:
5470         (get_thread_current_frame_id, record_btrace_start_replaying)
5471         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5472         (cmd_record_btrace_start): Replace throw_exception with throw.
5473         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5474         throw.
5475         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5476         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5477         * linespec.c:
5478         (find_linespec_symbols): Replace throw_exception with throw.
5479         * infrun.c (displaced_step_prepare, resume): Replace
5480         throw_exception with throw.
5481         * infcmd.c (post_create_inferior): Replace throw_exception with
5482         throw.
5483         * inf-loop.c (inferior_event_handler): Replace throw_exception
5484         with throw.
5485         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5486         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5487         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5488         (get_prev_frame_always, get_frame_pc_if_available)
5489         (get_frame_address_in_block_if_available, get_frame_language):
5490         Replace throw_exception with throw.
5491         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5492         throw_exception with throw.
5493         * eval.c (fetch_subexp_value, evaluate_var_value)
5494         (evaluate_funcall, evaluate_subexp_standard): Replace
5495         throw_exception with throw.
5496         * dwarf2loc.c (call_site_find_chain)
5497         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5498         Replace throw_exception with throw.
5499         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5500         with throw.
5501         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5502         throw.
5503         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5504         * completer.c (complete_line_internal): Replace throw_exception
5505         with throw.
5506         * compile/compile-object-run.c (compile_object_run): Replace
5507         throw_exception with throw.
5508         * cli/cli-script.c (process_next_line): Replace throw_exception
5509         with throw.
5510         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5511         (btrace_enable, btrace_maint_update_pt_packets): Replace
5512         throw_exception with throw.
5513         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5514         throw_exception with throw.
5515         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5516         throw_exception with throw.
5517         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5518         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5519         * aarch64-tdep.c (aarch64_make_prologue_cache)
5520         (aarch64_make_stub_cache): Replace throw_exception with throw.
5521
5522 2019-04-08  Tom Tromey  <tom@tromey.com>
5523
5524         * common/common-exceptions.c (throw_exception): Rename from
5525         throw_exception_cxx.  Remove old copy.  Make argument const.
5526         (throw_it): Create and throw exception objects directly.
5527         * common/common-exceptions.h (throw_exception): Make argument
5528         const.
5529         (struct gdb_exception_error): Add constructor.
5530         (struct gdb_exception_quit): Add constructor.
5531
5532 2019-04-08  Tom Tromey  <tom@tromey.com>
5533
5534         * common/common-exceptions.h (exception_rethrow): Don't declare.
5535         (TRY_SJLJ): Update comment.
5536         (TRY, CATCH, END_CATCH): Remove.
5537         * common/common-exceptions.c (exception_rethrow): Remove.
5538
5539 2019-04-08  Tom Tromey  <tom@tromey.com>
5540
5541         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5542         Remove.
5543         (gdb_exception_error): Rename from
5544         gdb_exception_RETURN_MASK_ERROR.
5545         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5546         (gdb_quit_bad_alloc): Update.
5547         * aarch64-tdep.c: Update.
5548         * ada-lang.c: Update.
5549         * ada-typeprint.c: Update.
5550         * ada-valprint.c: Update.
5551         * amd64-tdep.c: Update.
5552         * arch-utils.c: Update.
5553         * break-catch-throw.c: Update.
5554         * breakpoint.c: Update.
5555         * btrace.c: Update.
5556         * c-varobj.c: Update.
5557         * cli/cli-cmds.c: Update.
5558         * cli/cli-interp.c: Update.
5559         * cli/cli-script.c: Update.
5560         * common/common-exceptions.c: Update.
5561         * common/new-op.c: Update.
5562         * common/selftest.c: Update.
5563         * compile/compile-c-symbols.c: Update.
5564         * compile/compile-cplus-symbols.c: Update.
5565         * compile/compile-object-load.c: Update.
5566         * compile/compile-object-run.c: Update.
5567         * completer.c: Update.
5568         * corelow.c: Update.
5569         * cp-abi.c: Update.
5570         * cp-support.c: Update.
5571         * cp-valprint.c: Update.
5572         * darwin-nat.c: Update.
5573         * disasm-selftests.c: Update.
5574         * dtrace-probe.c: Update.
5575         * dwarf-index-cache.c: Update.
5576         * dwarf-index-write.c: Update.
5577         * dwarf2-frame-tailcall.c: Update.
5578         * dwarf2-frame.c: Update.
5579         * dwarf2loc.c: Update.
5580         * dwarf2read.c: Update.
5581         * eval.c: Update.
5582         * event-loop.c: Update.
5583         * event-top.c: Update.
5584         * exec.c: Update.
5585         * f-valprint.c: Update.
5586         * fbsd-tdep.c: Update.
5587         * frame-unwind.c: Update.
5588         * frame.c: Update.
5589         * gdbtypes.c: Update.
5590         * gnu-v3-abi.c: Update.
5591         * guile/guile-internal.h: Update.
5592         * guile/scm-block.c: Update.
5593         * guile/scm-breakpoint.c: Update.
5594         * guile/scm-cmd.c: Update.
5595         * guile/scm-disasm.c: Update.
5596         * guile/scm-frame.c: Update.
5597         * guile/scm-lazy-string.c: Update.
5598         * guile/scm-math.c: Update.
5599         * guile/scm-param.c: Update.
5600         * guile/scm-ports.c: Update.
5601         * guile/scm-pretty-print.c: Update.
5602         * guile/scm-symbol.c: Update.
5603         * guile/scm-symtab.c: Update.
5604         * guile/scm-type.c: Update.
5605         * guile/scm-value.c: Update.
5606         * i386-linux-tdep.c: Update.
5607         * i386-tdep.c: Update.
5608         * inf-loop.c: Update.
5609         * infcall.c: Update.
5610         * infcmd.c: Update.
5611         * infrun.c: Update.
5612         * jit.c: Update.
5613         * language.c: Update.
5614         * linespec.c: Update.
5615         * linux-fork.c: Update.
5616         * linux-nat.c: Update.
5617         * linux-tdep.c: Update.
5618         * linux-thread-db.c: Update.
5619         * main.c: Update.
5620         * mi/mi-cmd-break.c: Update.
5621         * mi/mi-cmd-stack.c: Update.
5622         * mi/mi-interp.c: Update.
5623         * mi/mi-main.c: Update.
5624         * objc-lang.c: Update.
5625         * p-valprint.c: Update.
5626         * parse.c: Update.
5627         * ppc-linux-tdep.c: Update.
5628         * printcmd.c: Update.
5629         * python/py-arch.c: Update.
5630         * python/py-breakpoint.c: Update.
5631         * python/py-cmd.c: Update.
5632         * python/py-finishbreakpoint.c: Update.
5633         * python/py-frame.c: Update.
5634         * python/py-framefilter.c: Update.
5635         * python/py-gdb-readline.c: Update.
5636         * python/py-inferior.c: Update.
5637         * python/py-infthread.c: Update.
5638         * python/py-lazy-string.c: Update.
5639         * python/py-linetable.c: Update.
5640         * python/py-objfile.c: Update.
5641         * python/py-param.c: Update.
5642         * python/py-prettyprint.c: Update.
5643         * python/py-progspace.c: Update.
5644         * python/py-record-btrace.c: Update.
5645         * python/py-record.c: Update.
5646         * python/py-symbol.c: Update.
5647         * python/py-type.c: Update.
5648         * python/py-unwind.c: Update.
5649         * python/py-utils.c: Update.
5650         * python/py-value.c: Update.
5651         * python/python.c: Update.
5652         * record-btrace.c: Update.
5653         * record-full.c: Update.
5654         * remote-fileio.c: Update.
5655         * remote.c: Update.
5656         * riscv-tdep.c: Update.
5657         * rs6000-aix-tdep.c: Update.
5658         * rs6000-tdep.c: Update.
5659         * rust-exp.y: Update.
5660         * rust-lang.c: Update.
5661         * s390-tdep.c: Update.
5662         * selftest-arch.c: Update.
5663         * solib-dsbt.c: Update.
5664         * solib-frv.c: Update.
5665         * solib-spu.c: Update.
5666         * solib-svr4.c: Update.
5667         * solib.c: Update.
5668         * sparc64-linux-tdep.c: Update.
5669         * stack.c: Update.
5670         * symfile-mem.c: Update.
5671         * symmisc.c: Update.
5672         * target.c: Update.
5673         * thread.c: Update.
5674         * top.c: Update.
5675         * tracefile-tfile.c: Update.
5676         * tui/tui.c: Update.
5677         * typeprint.c: Update.
5678         * unittests/cli-utils-selftests.c: Update.
5679         * unittests/parse-connection-spec-selftests.c: Update.
5680         * valops.c: Update.
5681         * valprint.c: Update.
5682         * value.c: Update.
5683         * varobj.c: Update.
5684         * windows-nat.c: Update.
5685         * x86-linux-nat.c: Update.
5686         * xml-support.c: Update.
5687
5688 2019-04-08  Tom Tromey  <tom@tromey.com>
5689
5690         * xml-support.c: Use C++ exception handling.
5691         * x86-linux-nat.c: Use C++ exception handling.
5692         * windows-nat.c: Use C++ exception handling.
5693         * varobj.c: Use C++ exception handling.
5694         * value.c: Use C++ exception handling.
5695         * valprint.c: Use C++ exception handling.
5696         * valops.c: Use C++ exception handling.
5697         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5698         handling.
5699         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5700         * typeprint.c: Use C++ exception handling.
5701         * tui/tui.c: Use C++ exception handling.
5702         * tracefile-tfile.c: Use C++ exception handling.
5703         * top.c: Use C++ exception handling.
5704         * thread.c: Use C++ exception handling.
5705         * target.c: Use C++ exception handling.
5706         * symmisc.c: Use C++ exception handling.
5707         * symfile-mem.c: Use C++ exception handling.
5708         * stack.c: Use C++ exception handling.
5709         * sparc64-linux-tdep.c: Use C++ exception handling.
5710         * solib.c: Use C++ exception handling.
5711         * solib-svr4.c: Use C++ exception handling.
5712         * solib-spu.c: Use C++ exception handling.
5713         * solib-frv.c: Use C++ exception handling.
5714         * solib-dsbt.c: Use C++ exception handling.
5715         * selftest-arch.c: Use C++ exception handling.
5716         * s390-tdep.c: Use C++ exception handling.
5717         * rust-lang.c: Use C++ exception handling.
5718         * rust-exp.y: Use C++ exception handling.
5719         * rs6000-tdep.c: Use C++ exception handling.
5720         * rs6000-aix-tdep.c: Use C++ exception handling.
5721         * riscv-tdep.c: Use C++ exception handling.
5722         * remote.c: Use C++ exception handling.
5723         * remote-fileio.c: Use C++ exception handling.
5724         * record-full.c: Use C++ exception handling.
5725         * record-btrace.c: Use C++ exception handling.
5726         * python/python.c: Use C++ exception handling.
5727         * python/py-value.c: Use C++ exception handling.
5728         * python/py-utils.c: Use C++ exception handling.
5729         * python/py-unwind.c: Use C++ exception handling.
5730         * python/py-type.c: Use C++ exception handling.
5731         * python/py-symbol.c: Use C++ exception handling.
5732         * python/py-record.c: Use C++ exception handling.
5733         * python/py-record-btrace.c: Use C++ exception handling.
5734         * python/py-progspace.c: Use C++ exception handling.
5735         * python/py-prettyprint.c: Use C++ exception handling.
5736         * python/py-param.c: Use C++ exception handling.
5737         * python/py-objfile.c: Use C++ exception handling.
5738         * python/py-linetable.c: Use C++ exception handling.
5739         * python/py-lazy-string.c: Use C++ exception handling.
5740         * python/py-infthread.c: Use C++ exception handling.
5741         * python/py-inferior.c: Use C++ exception handling.
5742         * python/py-gdb-readline.c: Use C++ exception handling.
5743         * python/py-framefilter.c: Use C++ exception handling.
5744         * python/py-frame.c: Use C++ exception handling.
5745         * python/py-finishbreakpoint.c: Use C++ exception handling.
5746         * python/py-cmd.c: Use C++ exception handling.
5747         * python/py-breakpoint.c: Use C++ exception handling.
5748         * python/py-arch.c: Use C++ exception handling.
5749         * printcmd.c: Use C++ exception handling.
5750         * ppc-linux-tdep.c: Use C++ exception handling.
5751         * parse.c: Use C++ exception handling.
5752         * p-valprint.c: Use C++ exception handling.
5753         * objc-lang.c: Use C++ exception handling.
5754         * mi/mi-main.c: Use C++ exception handling.
5755         * mi/mi-interp.c: Use C++ exception handling.
5756         * mi/mi-cmd-stack.c: Use C++ exception handling.
5757         * mi/mi-cmd-break.c: Use C++ exception handling.
5758         * main.c: Use C++ exception handling.
5759         * linux-thread-db.c: Use C++ exception handling.
5760         * linux-tdep.c: Use C++ exception handling.
5761         * linux-nat.c: Use C++ exception handling.
5762         * linux-fork.c: Use C++ exception handling.
5763         * linespec.c: Use C++ exception handling.
5764         * language.c: Use C++ exception handling.
5765         * jit.c: Use C++ exception handling.
5766         * infrun.c: Use C++ exception handling.
5767         * infcmd.c: Use C++ exception handling.
5768         * infcall.c: Use C++ exception handling.
5769         * inf-loop.c: Use C++ exception handling.
5770         * i386-tdep.c: Use C++ exception handling.
5771         * i386-linux-tdep.c: Use C++ exception handling.
5772         * guile/scm-value.c: Use C++ exception handling.
5773         * guile/scm-type.c: Use C++ exception handling.
5774         * guile/scm-symtab.c: Use C++ exception handling.
5775         * guile/scm-symbol.c: Use C++ exception handling.
5776         * guile/scm-pretty-print.c: Use C++ exception handling.
5777         * guile/scm-ports.c: Use C++ exception handling.
5778         * guile/scm-param.c: Use C++ exception handling.
5779         * guile/scm-math.c: Use C++ exception handling.
5780         * guile/scm-lazy-string.c: Use C++ exception handling.
5781         * guile/scm-frame.c: Use C++ exception handling.
5782         * guile/scm-disasm.c: Use C++ exception handling.
5783         * guile/scm-cmd.c: Use C++ exception handling.
5784         * guile/scm-breakpoint.c: Use C++ exception handling.
5785         * guile/scm-block.c: Use C++ exception handling.
5786         * guile/guile-internal.h: Use C++ exception handling.
5787         * gnu-v3-abi.c: Use C++ exception handling.
5788         * gdbtypes.c: Use C++ exception handling.
5789         * frame.c: Use C++ exception handling.
5790         * frame-unwind.c: Use C++ exception handling.
5791         * fbsd-tdep.c: Use C++ exception handling.
5792         * f-valprint.c: Use C++ exception handling.
5793         * exec.c: Use C++ exception handling.
5794         * event-top.c: Use C++ exception handling.
5795         * event-loop.c: Use C++ exception handling.
5796         * eval.c: Use C++ exception handling.
5797         * dwarf2read.c: Use C++ exception handling.
5798         * dwarf2loc.c: Use C++ exception handling.
5799         * dwarf2-frame.c: Use C++ exception handling.
5800         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5801         * dwarf-index-write.c: Use C++ exception handling.
5802         * dwarf-index-cache.c: Use C++ exception handling.
5803         * dtrace-probe.c: Use C++ exception handling.
5804         * disasm-selftests.c: Use C++ exception handling.
5805         * darwin-nat.c: Use C++ exception handling.
5806         * cp-valprint.c: Use C++ exception handling.
5807         * cp-support.c: Use C++ exception handling.
5808         * cp-abi.c: Use C++ exception handling.
5809         * corelow.c: Use C++ exception handling.
5810         * completer.c: Use C++ exception handling.
5811         * compile/compile-object-run.c: Use C++ exception handling.
5812         * compile/compile-object-load.c: Use C++ exception handling.
5813         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5814         * compile/compile-c-symbols.c: Use C++ exception handling.
5815         * common/selftest.c: Use C++ exception handling.
5816         * common/new-op.c: Use C++ exception handling.
5817         * cli/cli-script.c: Use C++ exception handling.
5818         * cli/cli-interp.c: Use C++ exception handling.
5819         * cli/cli-cmds.c: Use C++ exception handling.
5820         * c-varobj.c: Use C++ exception handling.
5821         * btrace.c: Use C++ exception handling.
5822         * breakpoint.c: Use C++ exception handling.
5823         * break-catch-throw.c: Use C++ exception handling.
5824         * arch-utils.c: Use C++ exception handling.
5825         * amd64-tdep.c: Use C++ exception handling.
5826         * ada-valprint.c: Use C++ exception handling.
5827         * ada-typeprint.c: Use C++ exception handling.
5828         * ada-lang.c: Use C++ exception handling.
5829         * aarch64-tdep.c: Use C++ exception handling.
5830
5831 2019-04-08  Tom Tromey  <tom@tromey.com>
5832
5833         * xml-support.c (gdb_xml_parser::parse): Update.
5834         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5835         * value.c (show_convenience): Update.
5836         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5837         (test_parse_flags_qcs): Update.
5838         * thread.c (thr_try_catch_cmd): Update.
5839         * target.c (target_translate_tls_address): Update.
5840         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5841         (info_frame_command_core, frame_apply_command_count): Update.
5842         * rust-exp.y (rust_lex_exception_test): Update.
5843         * riscv-tdep.c (riscv_print_one_register_info): Update.
5844         * remote.c (remote_target::enable_btrace): Update.
5845         * record-btrace.c (record_btrace_enable_warn): Update.
5846         * python/py-utils.c (gdbpy_convert_exception): Update.
5847         * printcmd.c (do_one_display, print_variable_and_value): Update.
5848         * mi/mi-main.c (mi_print_exception): Update.
5849         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5850         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5851         * linux-nat.c (linux_nat_target::attach): Update.
5852         * linux-fork.c (class scoped_switch_fork_info): Update.
5853         * infrun.c (displaced_step_prepare): Update.
5854         * infcall.c (call_function_by_hand_dummy): Update.
5855         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5856         * gnu-v3-abi.c (print_one_vtable): Update.
5857         * frame.c (get_prev_frame_always): Update.
5858         * f-valprint.c (info_common_command_for_block): Update.
5859         * exec.c (try_open_exec_file): Update.
5860         * exceptions.c (print_exception, exception_print)
5861         (exception_fprintf, exception_print_same): Update.
5862         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5863         * dwarf-index-cache.c (index_cache::store)
5864         (index_cache::lookup_gdb_index): Update.
5865         * darwin-nat.c (maybe_cache_shell): Update.
5866         * cp-valprint.c (cp_print_value_fields): Update.
5867         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5868         (gcc_cplus_symbol_address): Update.
5869         * compile/compile-c-symbols.c (gcc_convert_symbol)
5870         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5871         * common/selftest.c: Update.
5872         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5873         a std::string.
5874         (exception_try_scope_entry, exception_try_scope_exit): Don't
5875         declare.
5876         (struct exception_try_scope): Remove.
5877         (TRY): Don't use exception_try_scope.
5878         (struct gdb_exception): Add constructor, operator=.
5879         <what>: New method.
5880         (struct gdb_exception_RETURN_MASK_ALL)
5881         (struct gdb_exception_RETURN_MASK_ERROR)
5882         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5883         (struct gdb_quit_bad_alloc): Update.
5884         * common/common-exceptions.c (exception_none): Change
5885         initializer.
5886         (struct catcher) <state, exception>: Initialize inline.
5887         <prev>: Remove member.
5888         (current_catcher): Remove.
5889         (catchers): New global.
5890         (exceptions_state_mc_init): Simplify.
5891         (catcher_pop): Remove.
5892         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5893         (try_scope_depth, exception_try_scope_entry)
5894         (exception_try_scope_exit): Remove.
5895         (throw_exception_sjlj): Update.
5896         (exception_messages, exception_messages_size): Remove.
5897         (throw_it): Simplify.
5898         (gdb_exception_sliced_copy): Remove.
5899         (throw_exception_cxx): Update.
5900         * cli/cli-script.c (script_from_file): Update.
5901         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5902         Update.
5903         * ada-valprint.c (ada_val_print): Update.
5904         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5905         (create_excep_cond_exprs): Update.
5906
5907 2019-04-08  Tom Tromey  <tom@tromey.com>
5908
5909         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5910         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5911         (TRY, CATCH, END_CATCH): Remove some definitions.
5912         * common/common-exceptions.c: Don't use GDB_XCPT.
5913         (catcher_list_size): Remove.
5914         (throw_exception, throw_it): Simplify.
5915
5916 2019-04-05  Tom Tromey  <tom@tromey.com>
5917
5918         Revert the header-sorting patch.
5919         * ft32-tdep.c: Revert.
5920         * frv-tdep.c: Revert.
5921         * frv-linux-tdep.c: Revert.
5922         * frame.c: Revert.
5923         * frame-unwind.c: Revert.
5924         * frame-base.c: Revert.
5925         * fork-child.c: Revert.
5926         * findvar.c: Revert.
5927         * findcmd.c: Revert.
5928         * filesystem.c: Revert.
5929         * filename-seen-cache.h: Revert.
5930         * filename-seen-cache.c: Revert.
5931         * fbsd-tdep.c: Revert.
5932         * fbsd-nat.h: Revert.
5933         * fbsd-nat.c: Revert.
5934         * f-valprint.c: Revert.
5935         * f-typeprint.c: Revert.
5936         * f-lang.c: Revert.
5937         * extension.h: Revert.
5938         * extension.c: Revert.
5939         * extension-priv.h: Revert.
5940         * expprint.c: Revert.
5941         * exec.h: Revert.
5942         * exec.c: Revert.
5943         * exceptions.c: Revert.
5944         * event-top.c: Revert.
5945         * event-loop.c: Revert.
5946         * eval.c: Revert.
5947         * elfread.c: Revert.
5948         * dwarf2read.h: Revert.
5949         * dwarf2read.c: Revert.
5950         * dwarf2loc.c: Revert.
5951         * dwarf2expr.h: Revert.
5952         * dwarf2expr.c: Revert.
5953         * dwarf2-frame.c: Revert.
5954         * dwarf2-frame-tailcall.c: Revert.
5955         * dwarf-index-write.h: Revert.
5956         * dwarf-index-write.c: Revert.
5957         * dwarf-index-common.c: Revert.
5958         * dwarf-index-cache.h: Revert.
5959         * dwarf-index-cache.c: Revert.
5960         * dummy-frame.c: Revert.
5961         * dtrace-probe.c: Revert.
5962         * disasm.h: Revert.
5963         * disasm.c: Revert.
5964         * disasm-selftests.c: Revert.
5965         * dictionary.c: Revert.
5966         * dicos-tdep.c: Revert.
5967         * demangle.c: Revert.
5968         * dcache.h: Revert.
5969         * dcache.c: Revert.
5970         * darwin-nat.h: Revert.
5971         * darwin-nat.c: Revert.
5972         * darwin-nat-info.c: Revert.
5973         * d-valprint.c: Revert.
5974         * d-namespace.c: Revert.
5975         * d-lang.c: Revert.
5976         * ctf.c: Revert.
5977         * csky-tdep.c: Revert.
5978         * csky-linux-tdep.c: Revert.
5979         * cris-tdep.c: Revert.
5980         * cris-linux-tdep.c: Revert.
5981         * cp-valprint.c: Revert.
5982         * cp-support.c: Revert.
5983         * cp-namespace.c: Revert.
5984         * cp-abi.c: Revert.
5985         * corelow.c: Revert.
5986         * corefile.c: Revert.
5987         * continuations.c: Revert.
5988         * completer.h: Revert.
5989         * completer.c: Revert.
5990         * complaints.c: Revert.
5991         * coffread.c: Revert.
5992         * coff-pe-read.c: Revert.
5993         * cli-out.h: Revert.
5994         * cli-out.c: Revert.
5995         * charset.c: Revert.
5996         * c-varobj.c: Revert.
5997         * c-valprint.c: Revert.
5998         * c-typeprint.c: Revert.
5999         * c-lang.c: Revert.
6000         * buildsym.c: Revert.
6001         * buildsym-legacy.c: Revert.
6002         * build-id.h: Revert.
6003         * build-id.c: Revert.
6004         * btrace.c: Revert.
6005         * bsd-uthread.c: Revert.
6006         * breakpoint.h: Revert.
6007         * breakpoint.c: Revert.
6008         * break-catch-throw.c: Revert.
6009         * break-catch-syscall.c: Revert.
6010         * break-catch-sig.c: Revert.
6011         * blockframe.c: Revert.
6012         * block.c: Revert.
6013         * bfin-tdep.c: Revert.
6014         * bfin-linux-tdep.c: Revert.
6015         * bfd-target.c: Revert.
6016         * bcache.c: Revert.
6017         * ax-general.c: Revert.
6018         * ax-gdb.h: Revert.
6019         * ax-gdb.c: Revert.
6020         * avr-tdep.c: Revert.
6021         * auxv.c: Revert.
6022         * auto-load.c: Revert.
6023         * arm-wince-tdep.c: Revert.
6024         * arm-tdep.c: Revert.
6025         * arm-symbian-tdep.c: Revert.
6026         * arm-pikeos-tdep.c: Revert.
6027         * arm-obsd-tdep.c: Revert.
6028         * arm-nbsd-tdep.c: Revert.
6029         * arm-nbsd-nat.c: Revert.
6030         * arm-linux-tdep.c: Revert.
6031         * arm-linux-nat.c: Revert.
6032         * arm-fbsd-tdep.c: Revert.
6033         * arm-fbsd-nat.c: Revert.
6034         * arm-bsd-tdep.c: Revert.
6035         * arch-utils.c: Revert.
6036         * arc-tdep.c: Revert.
6037         * arc-newlib-tdep.c: Revert.
6038         * annotate.h: Revert.
6039         * annotate.c: Revert.
6040         * amd64-windows-tdep.c: Revert.
6041         * amd64-windows-nat.c: Revert.
6042         * amd64-tdep.c: Revert.
6043         * amd64-sol2-tdep.c: Revert.
6044         * amd64-obsd-tdep.c: Revert.
6045         * amd64-obsd-nat.c: Revert.
6046         * amd64-nbsd-tdep.c: Revert.
6047         * amd64-nbsd-nat.c: Revert.
6048         * amd64-nat.c: Revert.
6049         * amd64-linux-tdep.c: Revert.
6050         * amd64-linux-nat.c: Revert.
6051         * amd64-fbsd-tdep.c: Revert.
6052         * amd64-fbsd-nat.c: Revert.
6053         * amd64-dicos-tdep.c: Revert.
6054         * amd64-darwin-tdep.c: Revert.
6055         * amd64-bsd-nat.c: Revert.
6056         * alpha-tdep.c: Revert.
6057         * alpha-obsd-tdep.c: Revert.
6058         * alpha-nbsd-tdep.c: Revert.
6059         * alpha-mdebug-tdep.c: Revert.
6060         * alpha-linux-tdep.c: Revert.
6061         * alpha-linux-nat.c: Revert.
6062         * alpha-bsd-tdep.c: Revert.
6063         * alpha-bsd-nat.c: Revert.
6064         * aix-thread.c: Revert.
6065         * agent.c: Revert.
6066         * addrmap.c: Revert.
6067         * ada-varobj.c: Revert.
6068         * ada-valprint.c: Revert.
6069         * ada-typeprint.c: Revert.
6070         * ada-tasks.c: Revert.
6071         * ada-lang.c: Revert.
6072         * aarch64-tdep.c: Revert.
6073         * aarch64-ravenscar-thread.c: Revert.
6074         * aarch64-newlib-tdep.c: Revert.
6075         * aarch64-linux-tdep.c: Revert.
6076         * aarch64-linux-nat.c: Revert.
6077         * aarch64-fbsd-tdep.c: Revert.
6078         * aarch64-fbsd-nat.c: Revert.
6079         * aarch32-linux-nat.c: Revert.
6080
6081 2019-04-05  Tom Tromey  <tom@tromey.com>
6082
6083         * ft32-tdep.c: Sort headers.
6084         * frv-tdep.c: Sort headers.
6085         * frv-linux-tdep.c: Sort headers.
6086         * frame.c: Sort headers.
6087         * frame-unwind.c: Sort headers.
6088         * frame-base.c: Sort headers.
6089         * fork-child.c: Sort headers.
6090         * findvar.c: Sort headers.
6091         * findcmd.c: Sort headers.
6092         * filesystem.c: Sort headers.
6093         * filename-seen-cache.h: Sort headers.
6094         * filename-seen-cache.c: Sort headers.
6095         * fbsd-tdep.c: Sort headers.
6096         * fbsd-nat.h: Sort headers.
6097         * fbsd-nat.c: Sort headers.
6098         * f-valprint.c: Sort headers.
6099         * f-typeprint.c: Sort headers.
6100         * f-lang.c: Sort headers.
6101         * extension.h: Sort headers.
6102         * extension.c: Sort headers.
6103         * extension-priv.h: Sort headers.
6104         * expprint.c: Sort headers.
6105         * exec.h: Sort headers.
6106         * exec.c: Sort headers.
6107         * exceptions.c: Sort headers.
6108         * event-top.c: Sort headers.
6109         * event-loop.c: Sort headers.
6110         * eval.c: Sort headers.
6111         * elfread.c: Sort headers.
6112         * dwarf2read.h: Sort headers.
6113         * dwarf2read.c: Sort headers.
6114         * dwarf2loc.c: Sort headers.
6115         * dwarf2expr.h: Sort headers.
6116         * dwarf2expr.c: Sort headers.
6117         * dwarf2-frame.c: Sort headers.
6118         * dwarf2-frame-tailcall.c: Sort headers.
6119         * dwarf-index-write.h: Sort headers.
6120         * dwarf-index-write.c: Sort headers.
6121         * dwarf-index-common.c: Sort headers.
6122         * dwarf-index-cache.h: Sort headers.
6123         * dwarf-index-cache.c: Sort headers.
6124         * dummy-frame.c: Sort headers.
6125         * dtrace-probe.c: Sort headers.
6126         * disasm.h: Sort headers.
6127         * disasm.c: Sort headers.
6128         * disasm-selftests.c: Sort headers.
6129         * dictionary.c: Sort headers.
6130         * dicos-tdep.c: Sort headers.
6131         * demangle.c: Sort headers.
6132         * dcache.h: Sort headers.
6133         * dcache.c: Sort headers.
6134         * darwin-nat.h: Sort headers.
6135         * darwin-nat.c: Sort headers.
6136         * darwin-nat-info.c: Sort headers.
6137         * d-valprint.c: Sort headers.
6138         * d-namespace.c: Sort headers.
6139         * d-lang.c: Sort headers.
6140         * ctf.c: Sort headers.
6141         * csky-tdep.c: Sort headers.
6142         * csky-linux-tdep.c: Sort headers.
6143         * cris-tdep.c: Sort headers.
6144         * cris-linux-tdep.c: Sort headers.
6145         * cp-valprint.c: Sort headers.
6146         * cp-support.c: Sort headers.
6147         * cp-namespace.c: Sort headers.
6148         * cp-abi.c: Sort headers.
6149         * corelow.c: Sort headers.
6150         * corefile.c: Sort headers.
6151         * continuations.c: Sort headers.
6152         * completer.h: Sort headers.
6153         * completer.c: Sort headers.
6154         * complaints.c: Sort headers.
6155         * coffread.c: Sort headers.
6156         * coff-pe-read.c: Sort headers.
6157         * cli-out.h: Sort headers.
6158         * cli-out.c: Sort headers.
6159         * charset.c: Sort headers.
6160         * c-varobj.c: Sort headers.
6161         * c-valprint.c: Sort headers.
6162         * c-typeprint.c: Sort headers.
6163         * c-lang.c: Sort headers.
6164         * buildsym.c: Sort headers.
6165         * buildsym-legacy.c: Sort headers.
6166         * build-id.h: Sort headers.
6167         * build-id.c: Sort headers.
6168         * btrace.c: Sort headers.
6169         * bsd-uthread.c: Sort headers.
6170         * breakpoint.h: Sort headers.
6171         * breakpoint.c: Sort headers.
6172         * break-catch-throw.c: Sort headers.
6173         * break-catch-syscall.c: Sort headers.
6174         * break-catch-sig.c: Sort headers.
6175         * blockframe.c: Sort headers.
6176         * block.c: Sort headers.
6177         * bfin-tdep.c: Sort headers.
6178         * bfin-linux-tdep.c: Sort headers.
6179         * bfd-target.c: Sort headers.
6180         * bcache.c: Sort headers.
6181         * ax-general.c: Sort headers.
6182         * ax-gdb.h: Sort headers.
6183         * ax-gdb.c: Sort headers.
6184         * avr-tdep.c: Sort headers.
6185         * auxv.c: Sort headers.
6186         * auto-load.c: Sort headers.
6187         * arm-wince-tdep.c: Sort headers.
6188         * arm-tdep.c: Sort headers.
6189         * arm-symbian-tdep.c: Sort headers.
6190         * arm-pikeos-tdep.c: Sort headers.
6191         * arm-obsd-tdep.c: Sort headers.
6192         * arm-nbsd-tdep.c: Sort headers.
6193         * arm-nbsd-nat.c: Sort headers.
6194         * arm-linux-tdep.c: Sort headers.
6195         * arm-linux-nat.c: Sort headers.
6196         * arm-fbsd-tdep.c: Sort headers.
6197         * arm-fbsd-nat.c: Sort headers.
6198         * arm-bsd-tdep.c: Sort headers.
6199         * arch-utils.c: Sort headers.
6200         * arc-tdep.c: Sort headers.
6201         * arc-newlib-tdep.c: Sort headers.
6202         * annotate.h: Sort headers.
6203         * annotate.c: Sort headers.
6204         * amd64-windows-tdep.c: Sort headers.
6205         * amd64-windows-nat.c: Sort headers.
6206         * amd64-tdep.c: Sort headers.
6207         * amd64-sol2-tdep.c: Sort headers.
6208         * amd64-obsd-tdep.c: Sort headers.
6209         * amd64-obsd-nat.c: Sort headers.
6210         * amd64-nbsd-tdep.c: Sort headers.
6211         * amd64-nbsd-nat.c: Sort headers.
6212         * amd64-nat.c: Sort headers.
6213         * amd64-linux-tdep.c: Sort headers.
6214         * amd64-linux-nat.c: Sort headers.
6215         * amd64-fbsd-tdep.c: Sort headers.
6216         * amd64-fbsd-nat.c: Sort headers.
6217         * amd64-dicos-tdep.c: Sort headers.
6218         * amd64-darwin-tdep.c: Sort headers.
6219         * amd64-bsd-nat.c: Sort headers.
6220         * alpha-tdep.c: Sort headers.
6221         * alpha-obsd-tdep.c: Sort headers.
6222         * alpha-nbsd-tdep.c: Sort headers.
6223         * alpha-mdebug-tdep.c: Sort headers.
6224         * alpha-linux-tdep.c: Sort headers.
6225         * alpha-linux-nat.c: Sort headers.
6226         * alpha-bsd-tdep.c: Sort headers.
6227         * alpha-bsd-nat.c: Sort headers.
6228         * aix-thread.c: Sort headers.
6229         * agent.c: Sort headers.
6230         * addrmap.c: Sort headers.
6231         * ada-varobj.c: Sort headers.
6232         * ada-valprint.c: Sort headers.
6233         * ada-typeprint.c: Sort headers.
6234         * ada-tasks.c: Sort headers.
6235         * ada-lang.c: Sort headers.
6236         * aarch64-tdep.c: Sort headers.
6237         * aarch64-ravenscar-thread.c: Sort headers.
6238         * aarch64-newlib-tdep.c: Sort headers.
6239         * aarch64-linux-tdep.c: Sort headers.
6240         * aarch64-linux-nat.c: Sort headers.
6241         * aarch64-fbsd-tdep.c: Sort headers.
6242         * aarch64-fbsd-nat.c: Sort headers.
6243         * aarch32-linux-nat.c: Sort headers.
6244
6245 2019-04-04  Tom Tromey  <tom@tromey.com>
6246
6247         * varobj.c (varobj_create): Update.
6248         * rust-exp.y (struct rust_parser) <update_innermost_block,
6249         lookup_symbol>: New methods.
6250         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6251         Rename.
6252         (rust_parser::rust_lookup_type)
6253         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6254         * printcmd.c (display_command, do_one_display): Update.
6255         * parser-defs.h (struct parser_state) <parser_state>: Add
6256         "tracker" parameter.
6257         (block_tracker): New member.
6258         (class innermost_block_tracker) <innermost_block_tracker>: Add
6259         "types" parameter.
6260         <reset>: Remove method.
6261         (innermost_block): Don't declare.
6262         (null_post_parser): Update.
6263         * parse.c (innermost_block): Remove global.
6264         (write_dollar_variable): Update.
6265         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6266         Remove "tracker_types" parameter.
6267         (parse_expression): Add "tracker" parameter.
6268         (parse_expression_for_completion): Update.
6269         (null_post_parser): Add "tracker" parameter.
6270         * p-exp.y: Update rules.
6271         * m2-exp.y: Update rules.
6272         * language.h (struct language_defn) <la_post_parser>: Add
6273         "tracker" parameter.
6274         * go-exp.y: Update rules.
6275         * f-exp.y: Update rules.
6276         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6277         parameter.
6278         * d-exp.y: Update rules.
6279         * c-exp.y: Update rules.
6280         * breakpoint.c (set_breakpoint_condition): Create an
6281         innermost_block_tracker.
6282         (watch_command_1): Likewise.
6283         * ada-lang.c (resolve): Add "tracker" parameter.
6284         (resolve_subexp): Likewise.
6285         * ada-exp.y (write_var_from_sym): Update.
6286
6287 2019-04-04  Tom Tromey  <tom@tromey.com>
6288
6289         * type-stack.h: New file.
6290         * type-stack.c: New file.
6291         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6292         type-stack.h.
6293         (insert_into_type_stack, insert_type, push_type, push_type_int)
6294         (insert_type_address_space, pop_type, pop_type_int)
6295         (pop_typelist, pop_type_stack, append_type_stack)
6296         (push_type_stack, get_type_stack, push_typelist)
6297         (follow_type_instance_flags, follow_types): Don't declare.
6298         * parse.c (type_stack): Remove global.
6299         (parse_exp_in_context): Update.
6300         (insert_into_type_stack, insert_type, push_type, push_type_int)
6301         (insert_type_address_space, pop_type, pop_type_int)
6302         (pop_typelist, pop_type_stack, append_type_stack)
6303         (push_type_stack, get_type_stack, push_typelist)
6304         (follow_type_instance_flags, follow_types): Remove (moved to
6305         type-stack.c).
6306         * f-exp.y (type_stack): New global.
6307         Update rules.
6308         (push_kind_type, f_parse): Update.
6309         * d-exp.y (type_stack): New global.
6310         Update rules.
6311         (d_parse): Update.
6312         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6313         Update rules.
6314         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6315         (HFILES_NO_SRCDIR): Add type-stack.h.
6316
6317 2019-04-04  Tom Tromey  <tom@tromey.com>
6318
6319         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6320         (rust_parser::convert_ast_to_expression, rust_parse)
6321         (rust_lex_test_completion, rust_lex_tests): Update.
6322         * parser-defs.h (struct expr_completion_state): New.
6323         (struct parser_state) <parser_state>: Add completion parameter.
6324         <mark_struct_expression, mark_completion_tag>: New methods.
6325         <parse_completion, m_completion_state>: New members.
6326         (prefixify_expression, null_post_parser): Update.
6327         (mark_struct_expression, mark_completion_tag): Don't declare.
6328         * parse.c (parse_completion, expout_last_struct)
6329         (expout_tag_completion_type, expout_completion_name): Remove
6330         globals.
6331         (parser_state::mark_struct_expression)
6332         (parser_state::mark_completion_tag): Now methods.
6333         (prefixify_expression): Add last_struct parameter.
6334         (prefixify_subexp): Likewise.
6335         (parse_exp_1): Update.
6336         (parse_exp_in_context): Add cstate parameter.  Update.
6337         (parse_expression_for_completion): Create an
6338         expr_completion_state.
6339         (null_post_parser): Add "completion" parameter.
6340         * p-exp.y: Update rules.
6341         (yylex): Update.
6342         * language.h (struct language_defn) <la_post_parser>: Add
6343         "completing" parameter.
6344         * go-exp.y: Update rules.
6345         (lex_one_token): Update.
6346         * expression.h (parse_completion): Don't declare.
6347         * d-exp.y: Update rules.
6348         (lex_one_token): Update rules.
6349         * c-exp.y: Update rules.
6350         (lex_one_token): Update.
6351         * ada-lang.c (resolve): Add "parse_completion" parameter.
6352         (resolve_subexp): Likewise.
6353         (ada_resolve_function): Likewise.
6354
6355 2019-04-04  Tom Tromey  <tom@tromey.com>
6356
6357         * parser-defs.h (struct parser_state) <start_arglist,
6358         end_arglist>: New methods.
6359         <arglist_len, m_funcall_chain>: New members.
6360         (arglist_len, start_arglist, end_arglist): Don't declare.
6361         * parse.c (arglist_len, funcall_chain): Remove global.
6362         (start_arglist, end_arglist): Remove functions.
6363         (parse_exp_in_context): Update.
6364         * p-exp.y: Update rules.
6365         * m2-exp.y: Update rules.
6366         * go-exp.y: Update rules.
6367         * f-exp.y: Update rules.
6368         * d-exp.y: Update rules.
6369         * c-exp.y: Update rules.
6370
6371 2019-04-04  Tom Tromey  <tom@tromey.com>
6372
6373         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6374         lex_operator, push_back>: New methods.
6375         Update all rules.
6376         (rust_parser::lex_hex, lex_escape): Rename and update.
6377         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6378         (rust_parser::lex_operator): Rename and update.
6379         (rust_parser::lex_number, rustyylex, rustyyerror)
6380         (rust_lex_test_init, rust_lex_test_sequence)
6381         (rust_lex_test_push_back, rust_lex_tests): Update.
6382         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6383         parameter.
6384         <lexptr, prev_lexptr>: New members.
6385         (lexptr, prev_lexptr): Don't declare.
6386         * parse.c (lexptr, prev_lexptr): Remove globals.
6387         (parse_exp_in_context): Update.
6388         * p-exp.y (yylex, yyerror): Update.
6389         * m2-exp.y (parse_number, yylex, yyerror): Update.
6390         * go-exp.y (lex_one_token, yyerror): Update.
6391         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6392         * d-exp.y (lex_one_token, yyerror): Update.
6393         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6394         (lex_one_token, yyerror): Update.
6395         * ada-lex.l (YY_INPUT): Update.
6396         (rewind_to_char): Update.
6397         * ada-exp.y (yyerror): Update.
6398
6399 2019-04-04  Tom Tromey  <tom@tromey.com>
6400
6401         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6402         * parser-defs.h (struct parser_state) <parser_state>: Add new
6403         parameter.
6404         <comma_terminates>: New member.
6405         (comma_terminates): Don't declare global.
6406         * parse.c (comma_terminates): Remove global.
6407         (parse_exp_in_context): Update.
6408         * p-exp.y (yylex): Update.
6409         * m2-exp.y (yylex): Update.
6410         * go-exp.y (lex_one_token): Update.
6411         * f-exp.y (yylex): Update.
6412         * d-exp.y (lex_one_token): Update.
6413         * c-exp.y (lex_one_token): Update.
6414         * ada-lex.l: Update.
6415
6416 2019-04-04  Tom Tromey  <tom@tromey.com>
6417
6418         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6419         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6420         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6421         * parser-defs.h (paren_depth): Don't declare.
6422         * parse.c (paren_depth): Remove global.
6423         (parse_exp_in_context): Update.
6424         * p-exp.y (paren_depth): New global.
6425         (pascal_parse): Initialize it.
6426         * m2-exp.y (paren_depth): New global.
6427         (m2_parse): Initialize it.
6428         * go-exp.y (paren_depth): New global.
6429         (go_parse): Initialize it.
6430         * f-exp.y (paren_depth): New global.
6431         (f_parse): Initialize it.
6432         * d-exp.y (paren_depth): New global.
6433         (d_parse): Initialize it.
6434         * c-exp.y (paren_depth): New global.
6435         (c_parse): Initialize it.
6436         * ada-lex.l (paren_depth): New global.
6437         (lexer_init): Initialize it.
6438
6439 2019-04-04  Tom Tromey  <tom@tromey.com>
6440
6441         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6442         (rust_parser::convert_ast_to_type)
6443         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6444         * parser-defs.h (struct parser_state) <parser_state>: Add
6445         parameters.  Initialize new members.
6446         <expression_context_block, expression_context_pc>: New members.
6447         * parse.c (expression_context_block, expression_context_pc):
6448         Remove globals.
6449         (parse_exp_in_context): Update.
6450         * p-exp.y: Update all rules.
6451         (yylex): Update.
6452         * m2-exp.y: Update all rules.
6453         (yylex): Update.
6454         * go-exp.y (yylex): Update.
6455         * f-exp.y (yylex): Update.
6456         * d-exp.y: Update all rules.
6457         (yylex): Update.
6458         * c-exp.y: Update all rules.
6459         (lex_one_token, classify_name, yylex, c_parse): Update.
6460         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6461
6462 2019-04-04  Tom Tromey  <tom@tromey.com>
6463
6464         * gdbarch.h, gdbarch.c: Rebuild.
6465         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6466         * stap-probe.h:
6467         (struct stap_parse_info): Replace "parser_state" with
6468         "expr_builder".
6469         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6470         (parser_state): New class.
6471         * parse.c (expr_builder): Rename.
6472         (expr_builder::release): Rename.
6473         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6474         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6475         (write_exp_elt_longcst, write_exp_elt_floatcst)
6476         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6477         (write_exp_string_vector, write_exp_bitstring)
6478         (write_exp_msymbol, mark_struct_expression)
6479         (write_dollar_variable)
6480         (insert_type_address_space, increase_expout_size): Replace
6481         "parser_state" with "expr_builder".
6482         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6483         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6484         "parser_state" with "expr_builder".
6485
6486 2019-04-04  Tom Tromey  <tom@tromey.com>
6487
6488         * rust-exp.y: Replace "parse_language" with method call.
6489         * p-exp.y:
6490         (yylex): Replace "parse_language" with method call.
6491         * m2-exp.y:
6492         (yylex): Replace "parse_language" with method call.
6493         * go-exp.y (classify_name): Replace "parse_language" with method
6494         call.
6495         * f-exp.y (yylex): Replace "parse_language" with method call.
6496         * d-exp.y (lex_one_token): Replace "parse_language" with method
6497         call.
6498         * c-exp.y:
6499         (lex_one_token, classify_name, yylex): Replace "parse_language"
6500         with method call.
6501         * ada-exp.y (find_primitive_type, type_char)
6502         (type_system_address): Replace "parse_language" with method call.
6503
6504 2019-04-04  Tom Tromey  <tom@tromey.com>
6505
6506         * rust-exp.y: Replace "parse_gdbarch" with method call.
6507         * parse.c (write_dollar_variable, insert_type_address_space):
6508         Replace "parse_gdbarch" with method call.
6509         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6510         call.
6511         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6512         call.
6513         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6514         "parse_gdbarch" with method call.
6515         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6516         with method call.
6517         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6518         "parse_gdbarch" with method call.
6519         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6520         "parse_gdbarch" with method call.
6521         * c-exp.y (parse_type, parse_number, classify_name): Replace
6522         "parse_gdbarch" with method call.
6523         * ada-lex.l: Replace "parse_gdbarch" with method call.
6524         * ada-exp.y (parse_type, find_primitive_type, type_char)
6525         (type_system_address): Replace "parse_gdbarch" with method call.
6526
6527 2019-04-04  Tom Tromey  <tom@tromey.com>
6528
6529         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6530         * stap-probe.c (stap_parse_argument): Update.
6531         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6532         initial_size parameter.
6533         * rust-exp.y (rust_lex_tests): Update.
6534         * parse.c (parser_state): Update.
6535         (parse_exp_in_context): Update.
6536         * parser-defs.h (struct parser_state) <parser_state>: Remove
6537         "initial_size" parameter.
6538
6539 2019-04-04  Tom Tromey  <tom@tromey.com>
6540
6541         * parser-defs.h (increase_expout_size): Don't declare.
6542         * parse.c (increase_expout_size): Now static.
6543
6544 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6545
6546         * gnu-nat.c (gnu_nat_target::wait): Fix
6547         target_waitstatus_to_string call.
6548
6549 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6550
6551         * eval.c (evaluate_subexp_standard): Handle internal functions
6552         during Fortran function call handling.
6553
6554 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6555
6556         * NEWS: Mention new internal functions.
6557         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6558         (read_base_type): Use dwarf2_init_complex_target_type.
6559         * value.c (creal_internal_fn): New function.
6560         (cimag_internal_fn): New function.
6561         (_initialize_values): Register new internal functions.
6562
6563 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6564
6565         * infrun.c (stop_all_threads): If debug_infrun, always
6566         trace the wait status after wait_one, using
6567         target_waitstatus_to_string and target_pid_to_str.
6568         (handle_inferior_event): Replace various trace of
6569         wait status kind by a single trace.
6570         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6571         wait status kind image by target_waitstatus_to_string.
6572         * target/waitstatus.c (target_waitstatus_to_string): Fix
6573         obsolete comment.
6574
6575 2019-04-01  Tom Tromey  <tromey@adacore.com>
6576
6577         PR symtab/23331:
6578         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6579
6580 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6581             Pedro Alves  <palves@redhat.com>
6582
6583         * top.c (quit_force): Call 'finalize_values'.
6584         * value.c (finalize_values): New function.
6585         * value.h (finalize_values): Declare.
6586
6587 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6588
6589         * NEWS: Announce $_gdb_major and $_gdb_minor.
6590
6591         * top.c (init_gdb_version_vars): New function.
6592         (gdb_init): Call init_gdb_version_vars.
6593
6594 2019-03-29  Tom Tromey  <tromey@adacore.com>
6595
6596         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6597         help text.  Remove dead code.
6598
6599 2019-03-29  Keith Seitz  <keiths@redhat.com>
6600
6601         From Siddhesh Poyarekar:
6602         * f-lang.h (f77_get_upperbound): Return LONGEST.
6603         (f77_get_lowerbound): Likewise.
6604         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6605         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6606         print them.
6607         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6608         plongest to format print it.
6609         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6610         (f77_get_upperbound): Likewise.
6611         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6612         LOWER_BOUND to LONGEST.
6613         (f77_create_arrayprint_offset_tbl): Likewise.
6614
6615 2019-03-29  Keith Seitz  <keiths@redhat.com>
6616
6617         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6618         %s/pulongest for TYPE_LENGTH instead of %d in format
6619         strings.
6620         * ada-typerint.c (ada_print_type): Likewise.
6621         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6622         * compile/compile-c-support.c (generate_register_struct): Likewise.
6623         * gdbtypes.c (recursive_dump_type): Likewise.
6624         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6625         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6626         instead of %d in format strings.
6627         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6628         to std::min to ULONGEST.
6629         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6630         instead of %d in format strings.
6631         * tracepoint.c (info_scope_command): Likewise.
6632         * typeprint.c (print_offset_data::update)
6633         (print_offset_data::finish): Likewise.
6634         * xtensa-tdep.c (xtensa_store_return_value)
6635         (xtensa_push_dummy_call): Likewise.
6636
6637 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6638
6639         * windows-nat.c (display_selector): Fixed format specifications
6640         for 64-bit Cygwin.
6641
6642 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6643
6644         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6645
6646 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6647
6648         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6649         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6650         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6651         (nios2_linux_init_abi): Install it.
6652
6653 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6654
6655         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6656
6657 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6658
6659         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6660
6661 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6662             Tom Tromey  <tromey@adacore.com>
6663
6664         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6665
6666 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6667
6668         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6669         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6670         method to compute the bounds of range types. Also print "[evaluated]"
6671         if the bounds' values come from a dynamic evaluation.
6672
6673 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6674
6675         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6676         whitespace when pretty printing is on.
6677
6678 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6679
6680         * ppc-linux-nat.c: Add include.
6681
6682 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6683
6684         * NEWS: Mention AArch64 Pointer Authentication.
6685
6686 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6687
6688         * arm-linux-nat.c: Add include.
6689
6690 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6691
6692         * source-cache.c (source_cache::get_source_lines): Re-read
6693         fullname after calling open_source_file.
6694
6695 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6696
6697         * NEWS: Mention TLS support for FreeBSD.
6698
6699 2019-03-25  Tom Tromey  <tromey@adacore.com>
6700
6701         * minsyms.c (BUNCH_SIZE): Update comment.
6702         (~minimal_symbol_reader): Remove old comment.
6703         (compact_minimal_symbols): Update comment.
6704         (minimal_symbol_reader::install): Remove old comment.  Update
6705         other comments.
6706
6707 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6708
6709         * s390-linux-nat.c: Add include.
6710
6711 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6712
6713         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6714         Call linux_get_hwcap.
6715         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6716         Likewise.
6717         (aarch64_linux_get_hwcap): Remove function.
6718         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6719         declaration.
6720         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6721         linux_get_hwcap.
6722         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6723         * linux-tdep.c (linux_get_hwcap): Add function.
6724         (linux_get_hwcap2): Likewise.
6725         * linux-tdep.h (linux_get_hwcap): Add declaration.
6726         (linux_get_hwcap2): Likewise.
6727         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6728         (ppc_linux_get_hwcap2): Likewise.
6729         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6730         linux_get_hwcap.
6731         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6732         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6733         (ppc_linux_nat_target::read_description): Likewise.
6734         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6735         * s390-linux-nat.c: Likewise.
6736         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6737
6738 2019-03-24  Tom Tromey  <tom@tromey.com>
6739
6740         * ada-lang.c (standard_lookup): Simplify initialization.
6741         (ada_lookup_symbol_nonlocal): Simplify return.
6742         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6743         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6744         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6745         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6746         initialization.
6747         * solib.c (solib_global_lookup): Simplify.
6748         * symtab.c (null_block_symbol): Remove.
6749         (symbol_cache_lookup): Simplify returns.
6750         (lookup_language_this): Simplify returns.
6751         (lookup_symbol_aux): Simplify return.
6752         (lookup_local_symbol): Simplify returns.
6753         (lookup_global_symbol_from_objfile): Simplify return.
6754         (lookup_symbol_in_objfile_symtabs)
6755         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6756         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6757         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6758         * cp-namespace.c (cp_lookup_bare_symbol)
6759         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6760         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6761         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6762         (cp_lookup_symbol_via_imports): Simplify initialization.
6763         (find_symbol_in_baseclass): Likewise.
6764         * symtab.h (null_block_symbol): Remove.
6765         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6766         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6767         (d_lookup_symbol_module): Likewise.
6768         (find_symbol_in_baseclass): Simplify initialization.
6769
6770 2019-03-24  Tom Tromey  <tom@tromey.com>
6771
6772         * expression.h: Don't include symtab.h.
6773         (struct block): Forward declare.
6774
6775 2019-03-24  Tom Tromey  <tom@tromey.com>
6776
6777         * c-exp.y (typebase): Remove casts.
6778         * gdbtypes.c (lookup_unsigned_typename, )
6779         (lookup_signed_typename): Remove cast.
6780         * eval.c (parse_to_comma_and_eval): Remove cast.
6781         * parse.c (write_dollar_variable): Remove cast.
6782         * block.h (struct block) <superblock>: Now const.
6783         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6784         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6785         (map_block): Make "block" const.
6786         * symfile.h (struct quick_symbol_functions)
6787         <map_matching_symbols>: Constify block argument to "callback".
6788         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6789         const.
6790         (find_pc_sect_compunit_symtab): Make "b" const.
6791         (find_symbol_at_address): Likewise.
6792         (search_symbols): Likewise.
6793         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6794         (dw2_debug_names_lookup_symbol): Likewise.
6795         (dw2_map_matching_symbols): Update.
6796         * p-valprint.c (pascal_val_print): Remove "block".
6797         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6798         (aux_add_nonlocal_symbols): Make "block" const.
6799         (resolve_subexp): Remove cast.
6800         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6801         const.
6802         (iterate_over_file_blocks): Likewise.
6803         * f-exp.y (%union) <bval>: Remove.
6804         * coffread.c (patch_opaque_types): Make "b" const.
6805         * spu-tdep.c (spu_catch_start): Make "block" const.
6806         * c-valprint.c (print_unpacked_pointer): Remove "block".
6807         * symmisc.c (dump_symtab_1): Make "b" const.
6808         (block_depth): Make "block" const.
6809         * d-exp.y (%union) <bval>: Remove.
6810         * cp-support.h (cp_lookup_rtti_type): Update.
6811         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6812         * psymtab.c (psym_lookup_symbol): Make "block" const.
6813         (maintenance_check_psymtabs): Make "b" const.
6814         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6815         (enumerate_locals, enumerate_args): Update.
6816         * python/py-symtab.c (stpy_global_block): Make "block" const.
6817         (stpy_static_block): Likewise.
6818         * inline-frame.c (block_starting_point_at): Make "new_block"
6819         const.
6820         * block.c (find_block_in_blockvector): Make return type const.
6821         (blockvector_for_pc_sect): Make "b" const.
6822         (find_block_in_blockvector): Make "b" const.
6823
6824 2019-03-23  Tom Tromey  <tom@tromey.com>
6825
6826         * varobj.c (varobj_create): Update.
6827         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6828         * printcmd.c (display_command, do_one_display): Don't reset
6829         innermost_block.
6830         * parser-defs.h (enum innermost_block_tracker_type): Move to
6831         expression.h.
6832         (innermost_block): Update comment.
6833         * parse.c (parse_exp_1): Add tracker_types parameter.
6834         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6835         tracker_types parameter.  Reset innermost_block.
6836         (parse_exp_in_context): Remove.
6837         (parse_expression_for_completion): Update.
6838         * objfiles.c (~objfile): Don't reset expression_context_block or
6839         innermost_block.
6840         * expression.h (enum innermost_block_tracker_type): Move from
6841         parser-defs.h.
6842         (parse_exp_1): Add tracker_types parameter.
6843         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6844         reset innermost_block.
6845
6846 2019-03-23  Tom Tromey  <tom@tromey.com>
6847
6848         * objfiles.h: Include bcache.h.
6849
6850 2019-03-23  Tom Tromey  <tom@tromey.com>
6851
6852         * linespec.c (get_current_search_block): Use
6853         scoped_restore_current_language.
6854         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6855
6856 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6857             Jiong Wang  <jiong.wang@arm.com>
6858
6859         * aarch64-linux-tdep.c
6860         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6861         section.
6862         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6863
6864 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6865             Jiong Wang  <jiong.wang@arm.com>
6866
6867         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6868         instructions.
6869         (aarch64_analyze_prologue_test): Add PACIASP test.
6870         (aarch64_prologue_prev_register): Unmask PC value.
6871
6872 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6873             Jiong Wang  <jiong.wang@arm.com>
6874
6875         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6876         (aarch64_dwarf2_prev_register): Unmask PC value.
6877         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6878         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6879         DW_CFA_AARCH64_negate_ra_state.
6880         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6881
6882 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6883             Jiong Wang  <jiong.wang@arm.com>
6884
6885         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6886         registers.
6887         (aarch64_pseudo_register_name): Likewise.
6888         (aarch64_pseudo_register_type): Likewise.
6889         (aarch64_pseudo_register_reggroup_p): Likewise.
6890         (aarch64_gdbarch_init): Add pauth registers.
6891         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6892         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6893         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6894         (struct gdbarch_tdep): Add regnum for ra_state.
6895
6896 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6897             Jiong Wang  <jiong.wang@arm.com>
6898
6899         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6900
6901 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6902             Jiong Wang  <jiong.wang@arm.com>
6903
6904         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6905         function.
6906         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6907         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6908         (aarch64_gdbarch_init): Add puth registers.
6909         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6910         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6911         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6912
6913 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6914             Jiong Wang  <jiong.wang@arm.com>
6915
6916         * aarch64-linux-nat.c
6917         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6918         * aarch64-linux-tdep.c
6919         (aarch64_linux_core_read_description): Likewise.
6920         (aarch64_linux_get_hwcap): New function.
6921         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6922         (aarch64_linux_get_hwcap): New declaration.
6923
6924 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6925             Jiong Wang  <jiong.wang@arm.com>
6926
6927         * aarch64-linux-nat.c
6928         (aarch64_linux_nat_target::read_description): Add pauth param.
6929         * aarch64-linux-tdep.c
6930         (aarch64_linux_core_read_description): Likewise.
6931         * aarch64-tdep.c (struct target_desc): Add in pauth.
6932         (aarch64_read_description): Add pauth param.
6933         (aarch64_gdbarch_init): Likewise.
6934         * aarch64-tdep.h (aarch64_read_description): Likewise.
6935         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6936         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6937         * features/Makefile: Add new files.
6938         * features/aarch64-pauth.c: New file.
6939         * features/aarch64-pauth.xml: New file.
6940
6941 2019-03-20  Tom Tromey  <tromey@adacore.com>
6942
6943         * infrun.c (handle_inferior_event): Rename from
6944         handle_inferior_event_1.  Create a scoped_value_mark.
6945         (handle_inferior_event): Remove.
6946
6947 2019-03-19  Tom Tromey  <tromey@adacore.com>
6948
6949         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6950         * infrun.h (print_stop_event): Add "displays" parameter.
6951         * infrun.c (print_stop_event): Add "displays" parameter.
6952
6953 2019-03-19  Pedro Alves  <palves@redhat.com>
6954
6955         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6956         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6957         to -1.  Fix TABs vs spaces.
6958         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6959         * tui/tui-out.h (tui_ui_out) Add intro comments.
6960         <m_line, m_start_of_line>: In-class initialize, and add describing
6961         comment.
6962
6963 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6964
6965         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6966         variable names.
6967         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6968
6969 2019-03-18  Pedro Alves  <palves@redhat.com>
6970             Eli Zaretskii <eliz@gnu.org>
6971
6972         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6973         m_line and m_start_of_line.
6974
6975 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6976
6977         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6978         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6979         it returns a newline.  This fixes a regression in TU mode, whereby
6980         the next line is output on the same screen line as the user input.
6981
6982 2019-03-18  Tom Tromey  <tromey@adacore.com>
6983
6984         * minsyms.c (minimal_symbol_reader::install): Remove call to
6985         obstack_blank.
6986
6987 2019-03-18  Pedro Alves  <palves@redhat.com>
6988
6989         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6990         New globals.
6991         (apply_style): New, factored out from ...
6992         (apply_ansi_escape): ... this.  Handle reverse video mode.
6993         (tui_set_reverse_mode): New function.
6994         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6995         * tui/tui-winsource.c (tui_show_source_line): Use
6996         tui_set_reverse_mode instead of setting A_STANDOUT.
6997         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6998         New setter methods.
6999
7000 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7001
7002         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7003         Handle tabs.
7004
7005 2019-03-18  Tom Tromey  <tromey@adacore.com>
7006
7007         * ada-lang.c (empty_array): Add "high" parameter.
7008         (ada_evaluate_subexp): Update.
7009
7010 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7011
7012         * unittests/string_view-selftests.c: Define
7013         _initialize_string_view_selftests unconditionally.
7014
7015 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7016
7017         PR gdb/24350
7018         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7019
7020 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7021
7022         PR gdb/24351
7023         * windows-nat.c (display_selector): Fix format specifiers.
7024
7025 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7026
7027         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7028         tui_refill_source_window instead of tui_refresh_win, to update the
7029         current execution line.  This fixes redisplay of the current line
7030         when stepping through the code with "next" or "step".
7031
7032 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7033
7034         * source-cache.c (source_cache::get_source_lines): Call
7035         find_source_lines to initialize s->nlines.  This fixes vertical
7036         scrolling of TUI source window when the DOWN arrow is pressed.
7037
7038 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7039
7040         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7041         linux-thread-db.c (_initialize_thread_db): Likewise.
7042
7043 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7044
7045         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7046         wclrtoeol in tui_show_source_line".  This reverts changes made in
7047         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7048
7049 2019-03-15  Tom Tromey  <tom@tromey.com>
7050
7051         * symtab.h (struct minimal_symbol): Derive from
7052         general_symbol_info.
7053         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7054         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7055         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7056         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7057         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7058         (MSYMBOL_SEARCH_NAME): Update.
7059         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7060         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7061         * minsyms.c (minimal_symbol_reader::record_full): Update.
7062
7063 2019-03-15  Tom Tromey  <tom@tromey.com>
7064
7065         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7066
7067 2019-03-15  Tom Tromey  <tom@tromey.com>
7068
7069         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7070         unique_xmalloc_ptr.
7071         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7072         Update.
7073         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7074         (build_minimal_symbol_hash_tables)
7075         (minimal_symbol_reader::install): Update.
7076
7077 2019-03-15  Tom Tromey  <tom@tromey.com>
7078
7079         * symtab.c (create_demangled_names_hash): Update.
7080         (symbol_set_names): Update.
7081         * objfiles.h (struct objfile_per_bfd_storage)
7082         <demangled_names_hash>: Now an htab_up.
7083         * objfiles.c (objfile_per_bfd_storage): Simplify.
7084
7085 2019-03-15  Tom Tromey  <tom@tromey.com>
7086
7087         * objfiles.h (struct objfile_per_bfd_storage): Declare
7088         destructor.
7089         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7090         New.
7091         (get_objfile_bfd_data): Use new.  Don't initialize
7092         language_of_main.
7093         (free_objfile_per_bfd_storage): Remove.
7094         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7095
7096 2019-03-15  Tom Tromey  <tom@tromey.com>
7097
7098         * symfile.c (reread_symbols): Update.
7099         * objfiles.c (objfile::objfile): Update.
7100         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7101         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7102         comment.
7103         (minimal_symbol_reader::install): Update.
7104         (terminate_minimal_symbol_table): Remove.
7105         * jit.c (jit_object_close_impl): Update.
7106
7107 2019-03-15  Tom Tromey  <tom@tromey.com>
7108
7109         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7110         initializations.
7111
7112 2019-03-15  Tom Tromey  <tom@tromey.com>
7113
7114         * objfiles.h (struct objfile_per_bfd_storage)
7115         <demangled_hash_languages>: Now a bitset.
7116         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7117         (lookup_minimal_symbol): Update.
7118
7119 2019-03-15  Tom Tromey  <tom@tromey.com>
7120
7121         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7122         Don't return the symbol.
7123         * coffread.c (record_minimal_symbol): Use record_full.
7124
7125 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7126
7127         The MS-Windows port of ncurses fails to switch to a color pair if
7128         one or both of the colors are the implicit default colors.  This
7129         change records the default colors when TUI is initialized, and
7130         then specifies them explicitly when a color pair uses the default
7131         colors.  This allows color styling in TUI mode on MS-Windows.
7132
7133         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7134         ncurses_norm_attr.
7135         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7136         colors in ncurses_norm_attr.
7137         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7138         "none", replace it with the default color recorded in
7139         ncurses_norm_attr.
7140
7141 2019-03-14  Tom Tromey  <tromey@adacore.com>
7142
7143         * source-cache.h (class source_cache) <get_source_lines>: Return
7144         std::string.
7145         * source-cache.c (source_cache::extract_lines): Handle case where
7146         first_pos==npos.  Return std::string.
7147         (source_cache::get_source_lines): Update.
7148
7149 2019-03-14  Tom Tromey  <tromey@adacore.com>
7150
7151         * NEWS: Add item for "style sources" commands.
7152         * source-cache.c (source_cache::get_source_lines): Check
7153         source_styling.
7154         * cli/cli-style.c (source_styling): New global.
7155         (_initialize_cli_style): Add "style sources" commands.
7156         (show_style_sources): New function.
7157         * cli/cli-style.h (source_styling): Declare.
7158
7159 2019-03-14  Pedro Alves  <palves@redhat.com>
7160             Tom Tromey  <tromey@adacore.com>
7161
7162         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7163         * tui/tui-winsource.c (tui_refill_source_window): New function,
7164         from...
7165         (tui_horizontal_source_scroll): ... here.  Move some logic.
7166         * cli/cli-style.c (set_style_enabled): Notify new observable.
7167         * tui/tui-hooks.c (tui_redisplay_source): New function.
7168         (tui_attach_detach_observers): Attach or detach
7169         tui_redisplay_source.
7170         * observable.h (source_styling_changed): New observable.
7171         * observable.c: Define source_styling_changed observable.
7172
7173 2019-03-13  Tom Tromey  <tromey@adacore.com>
7174
7175         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7176         (i386_gnu_nat_target::store_registers): Update.
7177         * target-debug.h (target_debug_print_std_string): New macro.
7178         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7179         * windows-tdep.c (display_one_tib): Update.
7180         * tui/tui-stack.c (tui_make_status_line): Update.
7181         * top.c (print_inferior_quit_action): Update.
7182         * thread.c (thr_try_catch_cmd): Update.
7183         (add_thread_with_info): Update.
7184         (thread_target_id_str): Update.
7185         (thr_try_catch_cmd): Update.
7186         (thread_command): Update.
7187         (thread_find_command): Update.
7188         * record-btrace.c (record_btrace_target::info_record)
7189         (record_btrace_resume_thread, record_btrace_target::resume)
7190         (record_btrace_cancel_resume, record_btrace_step_thread)
7191         (record_btrace_target::wait, record_btrace_target::wait)
7192         (record_btrace_target::wait, record_btrace_target::stop): Update.
7193         * progspace.c (print_program_space): Update.
7194         * process-stratum-target.c
7195         (process_stratum_target::thread_address_space): Update.
7196         * linux-fork.c (linux_fork_mourn_inferior)
7197         (detach_checkpoint_command, info_checkpoints_command)
7198         (linux_fork_context): Update.
7199         (linux_fork_detach): Update.
7200         (class scoped_switch_fork_info): Update.
7201         (delete_checkpoint_command): Update.
7202         * infrun.c (follow_fork_inferior): Update.
7203         (follow_fork_inferior): Update.
7204         (proceed_after_vfork_done): Update.
7205         (handle_vfork_child_exec_or_exit): Update.
7206         (follow_exec): Update.
7207         (displaced_step_prepare_throw): Update.
7208         (displaced_step_restore): Update.
7209         (start_step_over): Update.
7210         (resume_1): Update.
7211         (clear_proceed_status_thread): Update.
7212         (proceed): Update.
7213         (print_target_wait_results): Update.
7214         (do_target_wait): Update.
7215         (context_switch): Update.
7216         (stop_all_threads): Update.
7217         (restart_threads): Update.
7218         (finish_step_over): Update.
7219         (handle_signal_stop): Update.
7220         (switch_back_to_stepped_thread): Update.
7221         (keep_going_pass_signal): Update.
7222         (print_exited_reason): Update.
7223         (normal_stop): Update.
7224         * inferior.c (inferior_pid_to_str): Change return type.
7225         (print_selected_inferior): Update.
7226         (add_inferior): Update.
7227         (detach_inferior): Update.
7228         * dummy-frame.c (fprint_dummy_frames): Update.
7229         * dcache.c (dcache_info_1): Update.
7230         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7231         (btrace_fetch, btrace_clear): Update.
7232         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7233         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7234         type.
7235         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7236         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7237         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7238         * gdbarch.c, gdbarch.h: Rebuild.
7239         * gdbarch.sh (core_pid_to_str): Change return type.
7240         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7241         return type.
7242         (windows_nat_target::pid_to_str): Change return type.
7243         (windows_delete_thread): Update.
7244         (windows_nat_target::attach): Update.
7245         (windows_nat_target::files_info): Update.
7246         * target-delegates.c: Rebuild.
7247         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7248         return type.
7249         (sol_thread_target::pid_to_str): Change return type.
7250         * remote.c (class remote_target) <pid_to_str>: Change return
7251         type.
7252         (remote_target::pid_to_str): Change return type.
7253         (extended_remote_target::attach, remote_target::remote_stop_ns)
7254         (remote_target::remote_notif_remove_queued_reply)
7255         (remote_target::push_stop_reply, remote_target::disable_btrace):
7256         Update.
7257         (extended_remote_target::attach): Update.
7258         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7259         type.
7260         (gdbsim_target::pid_to_str): Change return type.
7261         * ravenscar-thread.c (struct ravenscar_thread_target)
7262         <pid_to_str>: Change return type.
7263         (ravenscar_thread_target::pid_to_str): Change return type.
7264         * procfs.c (class procfs_target) <pid_to_str>: Change return
7265         type.
7266         (procfs_target::pid_to_str): Change return type.
7267         (procfs_target::attach): Update.
7268         (procfs_target::detach): Update.
7269         (procfs_target::fetch_registers): Update.
7270         (procfs_target::store_registers): Update.
7271         (procfs_target::wait): Update.
7272         (procfs_target::files_info): Update.
7273         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7274         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7275         return type.
7276         (nto_procfs_target::pid_to_str): Change return type.
7277         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7278         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7279         return type.
7280         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7281         (exit_lwp): Update.
7282         (attach_proc_task_lwp_callback, get_detach_signal)
7283         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7284         (linux_nat_target::resume, wait_lwp, stop_callback)
7285         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7286         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7287         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7288         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7289         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7290         type.
7291         (inf_ptrace_target::attach): Update.
7292         (inf_ptrace_target::files_info): Update.
7293         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7294         type.
7295         (go32_nat_target::pid_to_str): Change return type.
7296         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7297         (gnu_nat_target::wait): Update.
7298         (gnu_nat_target::wait): Update.
7299         (gnu_nat_target::resume): Update.
7300         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7301         (fbsd_nat_target::wait): Update.
7302         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7303         type.
7304         (darwin_nat_target::attach): Update.
7305         * corelow.c (class core_target) <pid_to_str>: Change return type.
7306         (core_target::pid_to_str): Change return type.
7307         * target.c (normal_pid_to_str): Change return type.
7308         (default_pid_to_str): Likewise.
7309         (target_pid_to_str): Change return type.
7310         (target_translate_tls_address): Update.
7311         (target_announce_detach): Update.
7312         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7313         return type.
7314         (bsd_uthread_target::pid_to_str): Change return type.
7315         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7316         type.
7317         (bsd_kvm_target::pid_to_str): Change return type.
7318         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7319         return type.
7320         (aix_thread_target::pid_to_str): Change return type.
7321         * target.h (struct target_ops) <pid_to_str>: Change return type.
7322         (target_pid_to_str, normal_pid_to_str): Likewise.
7323         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7324         type.
7325         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7326         type.
7327         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7328         return type.
7329         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7330         type.
7331         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7332         type.
7333         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7334         return type.
7335
7336 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7337
7338         * NEWS: Mention that the new default MI version is 3.  Mention
7339         changes to the output of commands and events that deal with
7340         multi-location breakpoints.
7341         * breakpoint.c: Include "mi/mi-out.h".
7342         (print_one_breakpoint): Change output syntax if using MI version
7343         >= 3.
7344         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7345         New.
7346         (mi_multi_location_breakpoint_output_fixed): New.
7347         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7348         (mi_cmd_fix_multi_location_breakpoint_output): New.
7349         (mi_multi_location_breakpoint_output_fixed): New.
7350         * mi/mi-cmds.c (mi_cmds): Register command
7351         -fix-multi-location-breakpoint-output.
7352         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7353         interpreter "mi".
7354
7355 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7356
7357         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7358         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7359         instantiate mi_ui_out based on interpreter name.
7360         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7361         * mi/mi-main.c (mi_load_progress): Likewise.
7362
7363 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7364
7365         * NEWS: Combine separate "New targets" sections for 8.3.
7366
7367 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7368
7369         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7370         (ppcfbsd_init_abi): Install gdbarch
7371         "fetch_tls_load_module_address" and "get_thread_local_address"
7372         methods.
7373
7374 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7375
7376         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7377         (riscv_fbsd_init_abi): Install gdbarch
7378         "fetch_tls_load_module_address" and "get_thread_local_address"
7379         methods.
7380
7381 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7382
7383         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7384         (i386fbsd_init_abi): Install gdbarch
7385         "fetch_tls_load_module_address" and "get_thread_local_address"
7386         methods.
7387
7388 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7389
7390         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7391         (amd64fbsd_init_abi): Install gdbarch
7392         "fetch_tls_load_module_address" and "get_thread_local_address"
7393         methods.
7394
7395 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7396
7397         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7398         (struct fbsd_pspace_data): New type.
7399         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7400         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7401         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7402         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7403         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7404
7405 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7406
7407         * gdbtypes.c (lookup_struct_elt): New function.
7408         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7409         * gdbtypes.h (struct struct_elt): New type.
7410         (lookup_struct_elt): New prototype.
7411
7412 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7413
7414         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7415         remove disabled code block.
7416
7417 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7418
7419         * gdbarch.sh (get_thread_local_address): New method.
7420         * gdbarch.h, gdbarch.c: Regenerate.
7421         * target.c (target_translate_tls_address): Use
7422         gdbarch_get_thread_local_address if present instead of
7423         target::get_thread_local_address.
7424
7425 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7426
7427         * target.h (target::get_thread_local_address): Update comment.
7428
7429 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7430
7431         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7432         objfile->separate_debug_objfile_backlink if not NULL.
7433
7434 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7435
7436         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7437         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7438         (amd64bsd_store_inferior_registers): Likewise.
7439         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7440         Enable segment base registers.
7441         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7442         PT_GETFSBASE and PT_GETGSBASE.
7443         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7444         PT_SETGSBASE.
7445         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7446         segment base registers.
7447         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7448
7449 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7450
7451         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7452         Update calls to i386_target_description to add 'segments'
7453         parameter.
7454         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7455         add segment base registers.
7456         * arch/i386.c (i386_create_target_description): Add 'segments'
7457         parameter to enable segment base registers.
7458         * arch/i386.h (i386_create_target_description): Likewise.
7459         * features/i386/32bit-segments.xml: New file.
7460         * features/i386/32bit-segments.c: Generate.
7461         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7462         call to i386_target_description to add 'segments' parameter.
7463         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7464         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7465         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7466         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7467         if feature is present.
7468         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7469         Add 'segments' parameter to call to i386_target_description.
7470         (i386_target_description): Add 'segments' parameter to enable
7471         segment base registers.
7472         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7473         to call to i386_target_description.
7474         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7475         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7476         Define I386_NUM_REGS.
7477         (i386_target_description): Add 'segments' parameter to enable
7478         segment base registers.
7479
7480 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7481
7482         PR/24325
7483         * source-cache.c: #undef open and close, to avoid unresolved
7484         externals during linking.
7485
7486 2019-03-12  Tom Tromey  <tromey@adacore.com>
7487
7488         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7489         const.  Add initializers.
7490         (_initialize_remote): Don't initialize ptid globals.
7491
7492 2019-03-12  Pedro Alves  <palves@redhat.com>
7493
7494         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7495
7496 2019-03-12  Pedro Alves  <palves@redhat.com>
7497
7498         * cp-name-parser.y (main): Remove unused 'len' variable.
7499
7500 2019-03-12  Tom Tromey  <tromey@adacore.com>
7501
7502         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7503         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7504
7505 2019-03-12  Tom Tromey  <tromey@adacore.com>
7506
7507         * linux-nat.c (iterate_over_lwps): Update.
7508         (stop_callback): Remove parameter.
7509         (stop_wait_callback, detach_callback, resume_set_callback)
7510         (select_singlestep_lwp_callback, set_ignore_sigint)
7511         (status_callback, resumed_callback, resume_clear_callback)
7512         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7513         data parameter.
7514         (linux_nat_target::detach, linux_nat_target::resume)
7515         (linux_stop_and_wait_all_lwps, select_event_lwp)
7516         (linux_nat_filter_event, linux_nat_wait_1)
7517         (linux_nat_target::kill, linux_nat_target::stop)
7518         (linux_nat_target::stop): Update.
7519         (linux_nat_resume_callback): Change type.
7520         (resume_stopped_resumed_lwps, count_events_callback)
7521         (select_event_lwp_callback): Likewise.
7522         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7523         * arm-linux-nat.c (struct update_registers_data): Remove.
7524         (update_registers_callback): Change type.
7525         (arm_linux_insert_hw_breakpoint1): Update.
7526         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7527         parameter.
7528         (x86_linux_dr_set_addr): Update.
7529         (x86_linux_dr_set_control): Update.
7530         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7531         (iterate_over_lwps): Use gdb::function_view.
7532         * nat/aarch64-linux-hw-point.c (struct
7533         aarch64_dr_update_callback_param): Remove.
7534         (debug_reg_change_callback): Change type.
7535         (aarch64_notify_debug_reg_change): Update.
7536         * s390-linux-nat.c (s390_refresh_per_info): Update.
7537
7538 2019-03-11  Tom Tromey  <tromey@adacore.com>
7539
7540         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7541         redundant assignment to "this_cu".
7542
7543 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7544
7545         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7546
7547 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7548
7549         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7550         from...
7551         (rank_one_type): ... this.
7552
7553 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7554
7555         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7556         from...
7557         (rank_one_type): ... this.
7558
7559 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7560
7561         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7562         from...
7563         (rank_one_type): ... this.
7564
7565 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7566
7567         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7568         from...
7569         (rank_one_type): ... this.
7570
7571 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7572
7573         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7574         from...
7575         (rank_one_type): ... this.
7576
7577 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7578
7579         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7580         from...
7581         (rank_one_type): ... this.
7582
7583 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7584
7585         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7586         from...
7587         (rank_one_type): ... this.
7588
7589 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7590
7591         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7592         from...
7593         (rank_one_type): ... this.
7594
7595 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7596
7597         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7598         from...
7599         (rank_one_type): ... this.
7600
7601 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7602
7603         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7604         from...
7605         (rank_one_type): ... this.
7606
7607 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7608
7609         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7610         from...
7611         (rank_one_type): ... this.
7612
7613 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7614
7615         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7616         from...
7617         (rank_one_type): ... this.
7618
7619 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7620
7621         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7622         inferior-events' shows the example events.
7623
7624 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7625
7626         Support styling on native MS-Windows console
7627
7628         PR/24315
7629         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7630         on MS-Windows if $TERM is not defined.
7631
7632         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7633
7634         * posix-hdep.c (gdb_console_fputs):
7635         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7636         functions.
7637         * ui-file.h (gdb_console_fputs): Add prototype.
7638
7639         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7640         back to fputs only if the former returns zero.
7641
7642 2019-03-07  Tom Tromey  <tom@tromey.com>
7643
7644         * symmisc.c (print_symbol_bcache_statistics): Update.
7645         (print_objfile_statistics): Update.
7646         * symfile.c (allocate_symtab): Update.
7647         * stabsread.c: Don't include bcache.h.
7648         * psymtab.h (struct psymbol_bcache): Don't declare.
7649         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7650         (psymbol_bcache_init, psymbol_bcache_free)
7651         (psymbol_bcache_get_bcache): Don't declare.
7652         * psymtab.c (struct psymbol_bcache): Remove.
7653         (psymtab_storage::psymtab_storage): Update.
7654         (psymtab_storage::~psymtab_storage): Update.
7655         (psymbol_bcache_init, psymbol_bcache_free)
7656         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7657         (add_psymbol_to_bcache): Update.
7658         (allocate_psymtab): Update.
7659         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7660         macro_cache>: No longer pointers.
7661         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7662         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7663         * macrotab.c (macro_bcache): Update.
7664         * macroexp.c: Don't include bcache.h.
7665         * gdbtypes.c (check_types_worklist): Update.
7666         (types_deeply_equal): Remove TRY/CATCH.  Update.
7667         * elfread.c (elf_symtab_read): Update.
7668         * dwarf2read.c: Don't include bcache.h.
7669         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7670         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7671         (print_bcache_statistics, bcache_memory_used): Don't declare.
7672         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7673         methods.  Rename all data members.
7674         * bcache.c (struct bcache): Move to bcache.h.
7675         (bcache::expand_hash_table): Rename from expand_hash_table.
7676         (bcache): Remove.
7677         (bcache::insert): Rename from bcache_full.
7678         (bcache::compare): Rename from bcache_compare.
7679         (bcache_xmalloc): Remove.
7680         (bcache::~bcache): Rename from bcache_xfree.
7681         (bcache::print_statistics): Rename from print_bcache_statistics.
7682         (bcache::memory_used): Rename from bcache_memory_used.
7683
7684 2019-03-07  Pedro Alves  <palves@redhat.com>
7685
7686         * infrun.c (normal_stop): Also check for
7687         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7688
7689 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7690
7691         * f-lang.c (value_from_host_double): Moved to...
7692         * value.c (value_from_host_double): ...here.
7693         * value.h (value_from_host_double): Declare.
7694         * guile/scm-math.c (vlscm_convert_typed_number): Use
7695         value_from_host_double.
7696         (vlscm_convert_number): Likewise.
7697         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7698         * python/py-value.c (convert_value_from_python): Likewise.
7699
7700 2019-03-06  Tom Tromey  <tom@tromey.com>
7701
7702         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7703
7704 2019-03-06  Tom Tromey  <tom@tromey.com>
7705
7706         * utils.h (free_current_contents): Don't declare.
7707         * utils.c (free_current_contents): Remove.
7708
7709 2019-03-06  Tom Tromey  <tom@tromey.com>
7710
7711         * top.c (quit_force): Update.
7712         * main.c (captured_command_loop): Update.
7713         * common/new-op.c (operator new): Update.
7714         * common/common-exceptions.c (struct catcher)
7715         <save_cleanup_chain>: Remove member.
7716         (exceptions_state_mc_init): Update.
7717         (exception_try_scope_entry): Return nullptr.
7718         (exception_try_scope_exit, exception_rethrow)
7719         (throw_exception_sjlj, throw_exception_cxx): Update.
7720         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7721         (all_cleanups, do_cleanups, discard_cleanups)
7722         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7723         (restore_cleanups, restore_final_cleanups): Don't declare.
7724         (do_final_cleanups): Remove parameter.
7725         * common/cleanups.c (cleanup_chain, make_cleanup)
7726         (make_cleanup_dtor, all_cleanups, do_cleanups)
7727         (discard_my_cleanups, discard_cleanups)
7728         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7729         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7730         (null_cleanup): Remove.
7731         (do_final_cleanups): Remove parameter.
7732
7733 2019-03-06  Tom Tromey  <tom@tromey.com>
7734
7735         * remote.c (remote_target::remote_parse_stop_reply): Use
7736         unique_xmalloc_ptr.
7737
7738 2019-03-06  Tom Tromey  <tom@tromey.com>
7739
7740         * stabsread.c (struct stabs_field_info): Rename from field_info.
7741         <list, fnlist>: Add initializers.
7742         <obstack>: New member.
7743         (read_member_functions, read_struct_fields, read_baseclasses):
7744         Allocate on obstack.  Don't use cleanups.
7745         (read_one_struct_field, read_member_functions, read_struct_fields)
7746         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7747         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7748         (read_struct_type): Update.
7749
7750 2019-03-06  Tom Tromey  <tom@tromey.com>
7751
7752         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7753         * common/filestuff.h (make_cleanup_close): Don't declare.
7754         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7755         Remove.
7756
7757 2019-03-06  Tom Tromey  <tom@tromey.com>
7758
7759         * solib-aix.c: Use make_scope_exit.
7760
7761 2019-03-06  Tom Tromey  <tom@tromey.com>
7762
7763         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7764         Use make_scope_exit.
7765
7766 2019-03-06  Tom Tromey  <tom@tromey.com>
7767
7768         * solib-svr4.c (disable_probes_interface): Remove parameter.
7769         (svr4_handle_solib_event): Use make_scope_exit.
7770
7771 2019-03-06  Tom Tromey  <tom@tromey.com>
7772
7773         * remote.c (struct stop_reply_deleter): Remove.
7774         (stop_reply_up): Update.
7775         (struct stop_reply): Derive from notif_event.  Don't typedef.
7776         <regcache>: Now a std::vector.
7777         (stop_reply_xfree): Remove.
7778         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7779         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7780         (remote_target::discard_pending_stop_replies): Use delete.
7781         (remote_target::remote_parse_stop_reply): Update.
7782         (remote_target::process_stop_reply): Update.
7783         * remote-notif.h (struct notif_event): Add virtual destructor.
7784         Remove "dtr" member.
7785         (struct notif_client) <alloc_event>: Return a unique_ptr.
7786         (notif_event_xfree): Don't declare.
7787         (notif_event_up): New typedef.
7788         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7789         (notif_event_xfree, do_notif_event_xfree): Remove.
7790         (remote_notif_state_xfree): Update.
7791
7792 2019-03-06  Tom Tromey  <tom@tromey.com>
7793
7794         * infrun.c (displaced_step_clear_cleanup): Now a
7795         forward_scope_exit type.
7796         (displaced_step_prepare_throw): Update.
7797         (displaced_step_fixup): Update.
7798
7799 2019-03-06  Tom Tromey  <tom@tromey.com>
7800
7801         * inferior.h (class inferior): Update comment.
7802         * gdbthread.h (class thread_info): Update comment.
7803
7804 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7805             Tom Tromey  <tom@tromey.com>
7806
7807         * stabsread.h (struct stab_section_list): Remove.
7808         (coffstab_build_psymtabs): Update.
7809         * dbxread.c (symbuf_sections): Now a std::vector.
7810         (sect_idx): New global.
7811         (fill_symbuf): Update.
7812         (coffstab_build_psymtabs): Change type of stabsects parameter.
7813         Update.
7814         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7815         std::vector.
7816         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7817         (coff_locate_sections): Update.
7818         (coff_symfile_read): Remove cleanups.  Update.
7819         (init_stringtab): Add storage parameter.
7820         (free_stringtab, free_stringtab_cleanup): Remove.
7821         (init_lineno): Add storage parameter.
7822         (free_linetab, free_linetab_cleanup): Remove.
7823
7824 2019-03-06  Pedro Alves  <palves@redhat.com>
7825
7826         * linux-fork.c (fork_info::clobber_regs): Delete.
7827         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7828         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7829         comment.  Adjust.
7830         (scoped_switch_fork_info::scoped_switch_fork_info)
7831         (checkpoint_command, linux_fork_context): Adjust
7832         fork_save_infrun_state calls.
7833
7834 2019-03-06  Pedro Alves  <palves@redhat.com>
7835
7836         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7837         (inf_has_multiple_threads): Return 'bool' and rewrite using
7838         inferior_info::threads().
7839
7840 2019-03-06  Pedro Alves  <palves@redhat.com>
7841
7842         * linux-fork.c: Include <list>.
7843         (fork_list): Now a std::list instance.
7844         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7845         (forks_exist_p, find_last_fork): Adjust.
7846         (new_fork): Delete.
7847         (one_fork_p): New.
7848         (add_fork): Adjust.
7849         (free_fork): Delete, folded into fork_info::~fork_info().
7850         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7851         Adjust.
7852         (init_fork_list): Delete.
7853         (linux_fork_killall, linux_fork_mourn_inferior)
7854         (linux_fork_detach, info_checkpoints_command): Adjust.
7855         (_initialize_linux_fork): No longer call init_fork_list.
7856
7857 2019-03-06  Pedro Alves  <palves@redhat.com>
7858
7859         * linux-fork.c (new_fork): New, split out of ...
7860         (add_fork): ... this.  Return void.  Move "first fork" special
7861         case from here, to ...
7862         (checkpoint_command): ... here.
7863         * linux-linux.h (add_fork): Return void.
7864
7865 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7866
7867         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7868
7869 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7870             Chris January  <chris.january@arm.com>
7871             David Lecomber  <david.lecomber@arm.com>
7872
7873         * f-exp.y: New token, UNOP_INTRINSIC.
7874         (exp): New pattern using UNOP_INTRINSIC token.
7875         (f77_keywords): Add 'abs' keyword.
7876         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7877         (value_from_host_double): New function.
7878         (evaluate_subexp_f): Support UNOP_ABS.
7879
7880 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7881
7882         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7883         types.
7884
7885 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7886
7887         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7888         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7889         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7890
7891 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7892
7893         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7894
7895 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7896             Chris January  <chris.january@arm.com>
7897
7898         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7899         * f-exp.y: Define 'KIND' token.
7900         (exp): New pattern for KIND expressions.
7901         (ptype): Handle types with a kind extension.
7902         (direct_abs_decl): Extend to spot kind extensions.
7903         (f77_keywords): Add 'kind' to the list.
7904         (push_kind_type): New function.
7905         (convert_to_kind_type): New function.
7906         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7907         * parse.c (operator_length_standard): Likewise.
7908         * parser-defs.h (enum type_pieces): Add tp_kind.
7909         * std-operator.def: Add UNOP_KIND.
7910
7911 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7912
7913         * f-exp.y (f_parse): Set yydebug.
7914
7915 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7916
7917         * f-lang.c (evaluate_subexp_f): New function.
7918         (exp_descriptor_f): New global.
7919         (f_language_defn): Use exp_descriptor_f instead of
7920         exp_descriptor_standard.
7921
7922 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7923
7924         * f-exp.y (struct token): Add comments.
7925         (dot_ops): Remove uppercase versions and the end marker.
7926         (f77_keywords): Likewise.
7927         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7928         entries in the dot_ops array are case insensitive, and use
7929         strncasecmp to compare strings.  Also some whitespace cleanup in
7930         this area.  Similar for the f77_keywords array, except entries in
7931         this list might be case sensitive.
7932
7933 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7934
7935         * f-exp.y (struct f77_boolean_val): Add comments.
7936         (boolean_values): Remove uppercase versions, and end marker.
7937         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7938         and use strncasecmp to achieve case insensitivity.  Additionally,
7939         perform whitespace cleanup around this code.
7940
7941 2019-03-06  Tom Tromey  <tromey@adacore.com>
7942
7943         * remote-sim.c (gdbsim_target_open): Use result of
7944         gdb_argv::release.
7945
7946 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7947         Dirk Schubert  <dirk.schubert@arm.com>
7948         Chris January  <chris.january@arm.com>
7949
7950         * eval.c (evaluate_subexp_standard): Call Fortran argument
7951         wrapping logic.
7952         * f-lang.c (struct value): A value which can be passed into a
7953         Fortran function call.
7954         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7955         where appropriate.
7956         (struct type): Value ready for a Fortran function call.
7957         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7958         is needed.
7959         * f-lang.h (fortran_argument_convert): Declaration.
7960         (fortran_preserve_arg_pointer): Declaration.
7961         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7962
7963 2019-03-05  Tom Tromey  <tromey@adacore.com>
7964
7965         * python/py-prettyprint.c (print_string_repr): Remove #if.
7966         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7967
7968 2019-03-05  Tom Tromey  <tromey@adacore.com>
7969
7970         * target.c (the_dummy_target): Move later.  Change type to
7971         "dummy_target".
7972         (initialize_targets): Don't initialize the_dummy_target.
7973
7974 2019-03-05  Tom Tromey  <tromey@adacore.com>
7975
7976         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7977         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7978
7979 2019-03-05  Tom Tromey  <tromey@adacore.com>
7980
7981         * windows-nat.c (windows_nat_target::attach)
7982         (windows_nat_target::detach): Don't call gdb_flush.
7983         * valprint.c (generic_val_print, val_print, val_print_string):
7984         Don't call gdb_flush.
7985         * utils.c (defaulted_query): Don't call gdb_flush.
7986         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7987         * target.c (target_announce_detach): Don't call gdb_flush.
7988         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7989         * remote.c (extended_remote_target::attach): Don't call
7990         gdb_flush.
7991         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7992         * printcmd.c (do_examine): Don't call gdb_flush.
7993         (info_display_command): Don't call gdb_flush.
7994         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7995         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7996         * memattr.c (info_mem_command): Don't call gdb_flush.
7997         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7998         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7999         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8000         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8001         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8002         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8003         (gnu_nat_target::detach): Don't call gdb_flush.
8004         * f-valprint.c (f_val_print): Don't call gdb_flush.
8005         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8006         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8007         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8008         gdb_flush.
8009         * c-valprint.c (c_val_print): Don't call gdb_flush.
8010         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8011
8012 2019-03-05  Tom Tromey  <tromey@adacore.com>
8013
8014         * varobj.c (update_dynamic_varobj_children): Update.
8015         (install_default_visualizer): Use reset, not release.
8016         * value.c (set_internalvar): Update.
8017         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8018         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8019         ATTRIBUTE_UNUSED_RESULT.
8020
8021 2019-03-05  Tom Tromey  <tromey@adacore.com>
8022
8023         * remote.c (class scoped_remote_fd) <release>: Add
8024         ATTRIBUTE_UNUSED_RESULT.
8025
8026 2019-03-05  Tom Tromey  <tromey@adacore.com>
8027
8028         * macroexp.c (struct macro_buffer) <release>: Add
8029         ATTRIBUTE_UNUSED_RESULT.
8030
8031 2019-03-05  Tom Tromey  <tromey@adacore.com>
8032
8033         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8034         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8035         ATTRIBUTE_UNUSED_RESULT.
8036
8037 2019-03-05  Tom Tromey  <tromey@adacore.com>
8038
8039         * common/scoped_fd.h (class scoped_fd) <release>: Add
8040         ATTRIBUTE_UNUSED_RESULT.
8041
8042 2019-03-05  Tom Tromey  <tromey@adacore.com>
8043
8044         * parser-defs.h (struct parser_state) <release>: Add
8045         ATTRIBUTE_UNUSED_RESULT.
8046
8047 2019-03-05  Tom Tromey  <tromey@adacore.com>
8048
8049         * utils.h (class gdb_argv) <release>: Add
8050         ATTRIBUTE_UNUSED_RESULT.
8051         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8052
8053 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8054
8055         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8056         for-loop range, to avoid compiler warnings.
8057
8058         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8059         avoid compiler warnings about unused variables.
8060
8061         * NEWS: Mention end of support for native debugging on MS-Windows
8062         before XP.
8063
8064         PR gdb/24292
8065         * common/netstuff.c:
8066         * gdbserver/gdbreplay.c
8067         * gdbserver/remote-utils.c:
8068         * ser-tcp.c:
8069         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8070         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8071         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8072         'getaddrinfo' and 'freeaddrinfo' were not available before
8073         Windows XP, and mingw.org's MinGW headers by default define
8074         _WIN32_WINNT to 0x500.
8075
8076 2019-03-01  Gary Benson <gbenson@redhat.com>
8077
8078         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8079
8080 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8081             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8082
8083         PR gdb/8527
8084         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8085         set_sigint_trap, clear_sigint_trap.
8086
8087 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8088
8089         * target.c (target_detach): Clear the regcache and the
8090         frame cache.
8091
8092 2019-02-27  Pedro Alves  <palves@redhat.com>
8093
8094         * utils.c (set_screen_size): When we cap the height/width sizes,
8095         tweak the corresponding command variable to show "unlimited":
8096
8097 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8098             Pedro Alves  <palves@redhat.com>
8099
8100         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8101         before calling rl_set_screen_size.
8102
8103 2019-02-27  Tom Tromey  <tromey@adacore.com>
8104
8105         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8106         define.
8107         * python/py-value.c: Remove Python 2.4 workaround.
8108         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8109         workaround.
8110         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8111         Python 2.4 workaround.
8112         * python/python-internal.h: Remove Python 2.4 comment.
8113         (Py_ssize_t): Don't define.
8114         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8115         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8116         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8117         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8118         * python/python.c (do_start_initialization): Remove Python 2.4
8119         workaround.
8120         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8121         (print_children): Remove Python 2.4 workaround.
8122         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8123         workaround.
8124         (CHARBUFFERPROC_NAME): Remove.
8125         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8126         Python 2.4 workaround.
8127
8128 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8129
8130         * NEWS: Note minimum Python version.
8131
8132 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8133
8134         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8135         code from these functions.  Remove corresponding ifdefs.  Use
8136         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8137         Remove gotos and target of gotos.
8138         (infpy_search_memory): Likewise.
8139
8140 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8141
8142         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8143         (hppa_gdbarch_init): Don't register deleted functions with
8144         gdbarch.
8145
8146 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8147
8148         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8149         (h8300_unwind_sp): Delete.
8150         (h8300_dummy_id): Delete.
8151         (h8300_gdbarch_init): Don't register deleted functions with
8152         gdbarch.
8153
8154 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8155
8156         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8157         (ft32_unwind_pc): Delete.
8158         (ft32_unwind_sp): Delete.
8159         (ft32_gdbarch_init): Don't register deleted functions with
8160         gdbarch.
8161
8162 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8163
8164         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8165         (frv_unwind_pc): Delete.
8166         (frv_unwind_sp): Delete.
8167         (frv_gdbarch_init): Don't register deleted functions with
8168         gdbarch.
8169
8170 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8171
8172         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8173         (riscv_unwind_pc): Delete.
8174         (riscv_unwind_sp): Delete.
8175         (riscv_gdbarch_init): Don't register deleted functions with
8176         gdbarch.
8177
8178 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8179
8180         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8181         (csky_unwind_pc): Delete.
8182         (csky_unwind_sp): Delete.
8183         (csky_gdbarch_init): Don't register deleted functions with
8184         gdbarch.
8185
8186 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8187
8188         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8189         (cris_unwind_pc): Delete.
8190         (cris_unwind_sp): Delete.
8191         (cris_gdbarch_init): Don't register deleted functions with
8192         gdbarch.
8193
8194 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8195
8196         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8197         (bfin_unwind_pc): Delete.
8198         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8199
8200 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8201
8202         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8203         (arm_unwind_pc): Delete.
8204         (arm_unwind_sp): Delete.
8205         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8206
8207 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8208
8209         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8210         (arc_unwind_pc): Delete.
8211         (arc_unwind_sp): Delete.
8212         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8213
8214 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8215
8216         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8217         (alpha_unwind_pc): Delete.
8218         (alpha_gdbarch_init): Don't register deleted functions with
8219         gdbarch.
8220
8221 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8222
8223         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8224         (aarch64_unwind_pc): Delete.
8225         (aarch64_unwind_sp): Delete.
8226         (aarch64_gdbarch_init): Don't register deleted functions with
8227         gdbarch.
8228
8229 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8230
8231         * gdbtypes.c (type_align): Don't consider static members when
8232         computing structure alignment.
8233
8234 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8235
8236         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8237         return 0 for other types.
8238         * arch-utils.c (default_type_align): Always return 0.
8239         * gdbarch.h: Regenerate.
8240         * gdbarch.sh (type_align): Extend comment.
8241         * gdbtypes.c (type_align): Add additional comments, always call
8242         gdbarch_type_align before applying the default rules.
8243         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8244         generic code will then apply a suitable default.
8245         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8246         types, return 0 for other types.
8247
8248 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8249
8250         * NEWS: Create a new section for the next release branch.
8251         Rename the section of the current branch, now that it has
8252         been cut.
8253
8254 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8255
8256         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8257         * version.in: Bump version to 8.3.50.DATE-git.
8258
8259 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8260
8261         * aix-thread.c (ptid_cmp): Remove unused variable.
8262         (get_signaled_thread): Likewise.
8263         (store_regs_user_thread): Likewise.
8264         (store_regs_kernel_thread): Likewise.
8265         (fetch_regs_kernel_thread): Remove shadowed variable.
8266
8267 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8268
8269         * features/riscv/32bit-cpu.xml: Add register numbers.
8270         * features/riscv/32bit-fpu.c: Regenerate.
8271         * features/riscv/32bit-fpu.xml: Add register numbers.
8272         * features/riscv/64bit-cpu.xml: Add register numbers.
8273         * features/riscv/64bit-fpu.c: Regenerate.
8274         * features/riscv/64bit-fpu.xml: Add register numbers.
8275
8276 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8277
8278         * NEWS: Mention two argument form of gdb.Value constructor.
8279         * python/py-value.c (convert_buffer_and_type_to_value): New
8280         function.
8281         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8282         Add support for handling an optional second argument.  Call
8283         convert_buffer_and_type_to_value as appropriate.
8284         * python/python-internal.h (Py_buffer_deleter): New struct.
8285         (Py_buffer_up): New typedef.
8286
8287 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8288
8289         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8290         instead of releasing ownership.
8291
8292 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8293
8294         * dwarf2read.c (open_and_init_dwp_file): Call
8295         elf_numsections instead of bfd_count_sections to initialize
8296         dwp_file->num_sections.
8297
8298 2019-02-25  Tom Tromey  <tromey@adacore.com>
8299
8300         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8301
8302 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8303
8304         * gcore.in: Add '--readnever' option when invoking GDB.
8305
8306 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8307
8308         * MAINTAINERS: Update my email address.
8309
8310 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8311
8312         * build-id.c (build_id_to_debug_bfd_1): New function.
8313         (build_id_to_debug_bfd): Look for separate debug file in
8314         sysroot.
8315
8316 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8317
8318         * gdbarch.sh: Update the copyright year range that is placed into
8319         generated files.
8320
8321 2019-02-22  Keith Seitz  <keiths@redhat.com>
8322
8323         PR symtab/23853
8324         * linespec.c (create_sals_line_offset): Search for the default
8325         symtab's filename instead of its fullname.
8326
8327 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8328
8329         * NEWS: Update style defaults.
8330
8331 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8332
8333         * main.c (captured_main_1): Disable styling in batch mode.
8334
8335 2019-02-20  Tom Tromey  <tom@tromey.com>
8336
8337         * symtab.c (symtab_symbol_info): Fix typos.
8338
8339 2019-02-20  Tom Tromey  <tromey@adacore.com>
8340
8341         * findcmd.c (_initialize_mem_search): Use upper case for
8342         metasyntactic variables.
8343
8344 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8345
8346         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8347         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8348
8349 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8350
8351         * top.h (source_file_name): Change to std::string.
8352         * top.c (source_file_name): Likewise.
8353         (command_line_input): Adjust.
8354         * cli/cli-script.c (script_from_file): Adjust.
8355
8356 2019-02-19  Tom Tromey  <tromey@adacore.com>
8357
8358         * ravenscar-thread.c
8359         (ravenscar_thread_target::update_thread_list): Don't call
8360         ada_build_task_list.
8361         * ada-lang.h (ada_build_task_list): Don't declare.
8362         * ada-tasks.c (struct ada_tasks_inferior_data)
8363         <task_list_valid_p>: Now bool.
8364         (read_known_tasks, ada_task_list_changed)
8365         (ada_tasks_invalidate_inferior_data): Update.
8366         (read_known_tasks_array): Return bool.
8367         (read_known_tasks_list): Likewise.
8368         (read_known_tasks): Return void.
8369         (ada_build_task_list): Now static.
8370
8371 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8372
8373         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8374         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8375
8376 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8377
8378         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8379         variant for ada_tasks_pspace_data_handle and
8380         ada_tasks_inferior_data_handle.
8381         (ada_tasks_pspace_data_cleanup): New function.
8382         (ada_tasks_inferior_data_cleanup): New function.
8383
8384 2019-02-17  Tom Tromey  <tom@tromey.com>
8385
8386         * macrotab.h (macro_source_fullname): Return a std::string.
8387         * macrotab.c (macro_include, check_for_redefinition)
8388         (macro_undef, macro_lookup_definition, foreach_macro)
8389         (foreach_macro_in_scope): Update.
8390         (macro_source_fullname): Return a std::string.
8391         * macrocmd.c (show_pp_source_pos): Update.
8392
8393 2019-02-17  Tom Tromey  <tom@tromey.com>
8394
8395         * macrocmd.c (show_pp_source_pos): Style the file names.
8396
8397 2019-02-17  Tom Tromey  <tom@tromey.com>
8398
8399         PR tui/24197:
8400         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8401
8402 2019-02-17  Tom Tromey  <tom@tromey.com>
8403
8404         * ada-lang.c (user_select_syms): Use filtered printing.
8405         * utils.c (wrap_style): New global.
8406         (desired_style): Remove.
8407         (emit_style_escape): Add stream parameter.
8408         (set_output_style, reset_terminal_style, prompt_for_continue):
8409         Update.
8410         (flush_wrap_buffer): Only flush gdb_stdout.
8411         (wrap_here): Set wrap_style.
8412         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8413         treat escape sequences as a character.  Change when wrap buffer is
8414         flushed.
8415         (fputs_styled): Do not set the output style when the default is
8416         requested.
8417         * ui-style.h (struct ui_file_style) <is_default>: New method.
8418         * source.c (print_source_lines_base): Emit escape sequences in one
8419         piece.
8420
8421 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8422
8423         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8424         integers and enumeration types.
8425
8426 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8427
8428         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8429         instead of lookup_symbol_in_language
8430         (do_exact_match): New function.
8431         (ada_get_symbol_name_matcher): Return do_exact_match when
8432         doing a verbatim match.
8433
8434 2019-02-15  Tom Tromey  <tromey@adacore.com>
8435
8436         * ravenscar-thread.c (ravenscar_thread_target::resume)
8437         (ravenscar_thread_target::wait): Special case wildcard requests.
8438
8439 2019-02-15  Tom Tromey  <tromey@adacore.com>
8440
8441         * ravenscar-thread.c (base_ptid): Remove.
8442         (struct ravenscar_thread_target) <close>: New method.
8443         <m_base_ptid>: New member.
8444         <update_inferior_ptid, active_task, task_is_currently_active,
8445         runtime_initialized>: Declare methods.
8446         <ravenscar_thread_target>: Add constructor.
8447         (ravenscar_thread_target::task_is_currently_active)
8448         (ravenscar_thread_target::update_inferior_ptid)
8449         (ravenscar_runtime_initialized): Rename.  Now methods.
8450         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8451         (ravenscar_thread_target::update_thread_list): Update.
8452         (ravenscar_thread_target::active_task): Now method.
8453         (ravenscar_thread_target::store_registers)
8454         (ravenscar_thread_target::prepare_to_store)
8455         (ravenscar_thread_target::prepare_to_store)
8456         (ravenscar_thread_target::mourn_inferior): Update.
8457         (ravenscar_inferior_created): Use "new" to create target.
8458         (ravenscar_thread_target::get_ada_task_ptid): Update.
8459         (_initialize_ravenscar): Don't initialize base_ptid.
8460         (ravenscar_ops): Remove global.
8461
8462 2019-02-15  Tom Tromey  <tromey@adacore.com>
8463
8464         * target.h (push_target): Declare new overload.
8465         * target.c (push_target): New overload, taking an rvalue reference.
8466         * remote.c (remote_target::open_1): Use push_target overload.
8467         * corelow.c (core_target_open): Use push_target overload.
8468
8469 2019-02-15  Tom Tromey  <tromey@adacore.com>
8470
8471         * ravenscar-thread.c (is_ravenscar_task)
8472         (ravenscar_task_is_currently_active): Return bool.
8473         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8474         (_initialize_ravenscar): Remove "(void)".
8475         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8476         Return bool.
8477
8478 2019-02-15  Tom Tromey  <tromey@adacore.com>
8479
8480         * ravenscar-thread.c (ravenscar_runtime_initializer)
8481         (has_ravenscar_runtime, get_running_thread_id)
8482         (ravenscar_thread_target::resume): Fix indentation.
8483
8484 2019-02-15  Tom Tromey  <tromey@adacore.com>
8485
8486         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8487         from ravenscar_arch_ops.
8488         (sparc_ravenscar_ops::fetch_registers)
8489         (sparc_ravenscar_ops::store_registers): Now methods.
8490         (sparc_ravenscar_prepare_to_store): Remove.
8491         (sparc_ravenscar_ops): Redefine.
8492         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8493         methods and destructor.  Remove members.
8494         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8495         (ravenscar_thread_target::store_registers)
8496         (ravenscar_thread_target::prepare_to_store): Update.
8497         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8498         Remove.
8499         (struct ppc_ravenscar_powerpc_ops): Derive from
8500         ravenscar_arch_ops.
8501         (ppc_ravenscar_powerpc_ops::fetch_registers)
8502         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8503         (ppc_ravenscar_powerpc_ops): Redefine.
8504         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8505         (ppc_ravenscar_e500_ops::fetch_registers)
8506         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8507         (ppc_ravenscar_e500_ops): Redefine.
8508         * aarch64-ravenscar-thread.c
8509         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8510         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8511         (aarch64_ravenscar_fetch_registers)
8512         (aarch64_ravenscar_store_registers): Now methods.
8513         (aarch64_ravenscar_ops): Redefine.
8514
8515 2019-02-15  Tom Tromey  <tromey@adacore.com>
8516
8517         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8518         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8519         (ravenscar_thread_target::stopped_by_watchpoint)
8520         (ravenscar_thread_target::stopped_data_address)
8521         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8522
8523 2019-02-15  Tom Tromey  <tromey@adacore.com>
8524
8525         * ravenscar-thread.c: Fix some typos.
8526
8527 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8528             Tom Tromey  <tromey@adacore.com>
8529
8530         * ada-lang.c (ada_exception_sal): Change addr_string to a
8531         std::string.
8532         (create_ada_exception_catchpoint): Update.
8533
8534 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8535             Tom Tromey  <tromey@adacore.com>
8536
8537         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8538         (bp_location_ops): Remove.
8539         (base_breakpoint_allocate_location): Update.
8540         (free_bp_location): Update.
8541         * ada-lang.c (class ada_catchpoint_location)
8542         <ada_catchpoint_location>: Remove ops parameter.
8543         (ada_catchpoint_location_dtor): Remove.
8544         (ada_catchpoint_location_ops): Remove.
8545         (allocate_location_exception): Update.
8546         * breakpoint.h (struct bp_location_ops): Remove.
8547         (class bp_location) <bp_location>: Remove bp_location_ops
8548         parameter.
8549         <~bp_location>: Add destructor.
8550         <ops>: Remove.
8551
8552 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8553             Pedro Alves  <palves@redhat.com>
8554
8555         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8556         'PATH_MAX'.
8557
8558 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8559             Samuel Thibault  <samuel.thibault@gnu.org>
8560             Thomas Schwinge  <thomas@codesourcery.com>
8561
8562         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8563         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8564
8565 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8566
8567         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8568         (check_empty): Use "const char *".
8569
8570         * gnu-nat.c (gnu_nat_target::detach): Instead of
8571         'detach_inferior (pid)' call
8572         'detach_inferior (find_inferior_pid (pid))'.
8573
8574         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8575         'nat/fork-inferior.o'.
8576         * gnu-nat.c: #include "nat/fork-inferior.h".
8577
8578         * gnu-nat.c (gnu_nat_target::detach): Instead of
8579         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8580         * gnu-nat.h: #include "inf-child.h".
8581         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8582         'i386_gnu_nat_target::fetch_registers'.
8583         (gnu_store_registers): Rename/move to
8584         'i386_gnu_nat_target::store_registers'.
8585
8586         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8587         * gnu-nat.h (mach_thread_info): New function.
8588         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8589
8590         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8591
8592 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8593
8594         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8595
8596 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8597
8598         * windows-nat.c (windows_add_thread): Add new parameter
8599         "main_thread_p" with default value set to false.  Update
8600         function documentation as well as all callers.
8601         (windows_delete_thread): Likewise.
8602         (fake_create_process): Update call to windows_add_thread.
8603         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8604         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8605         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8606         call to windows_delete_thread.
8607
8608 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8609
8610         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8611
8612 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8613
8614         * symfile.c (find_separate_debug_file): Use canonical path of
8615         sysroot with child_path instead of gdb_sysroot if it is valid.
8616
8617 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8618
8619         * symfile.c (find_separate_debug_file): Use child_path to
8620         determine if an object file is under a sysroot.
8621
8622 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8623
8624         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8625         unittests/child-path-selftests.c.
8626         * common/pathstuff.c (child_path): New function.
8627         * common/pathstuff.h (child_path): New prototype.
8628         * unittests/child-path-selftests.c: New file.
8629
8630 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8631
8632         * symfile.c (find_separate_debug_file): Look for separate debug
8633         files in debug directories under the sysroot.
8634
8635 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8636
8637         * symtab.h (struct minimal_symbol data_p): New const method.
8638         (struct minimal_symbol text_p): Likewise.
8639         * symtab.c (output_source_filename): Use file name style
8640         to print file name.
8641         (print_symbol_info): Likewise.
8642         (print_msymbol_info): Use address style to print addresses.
8643         Use function name style to print executable text symbols.
8644         (expand_symtab_containing_pc): Use data_p.
8645         (find_pc_sect_compunit_symtab): Likewise.
8646
8647 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8648
8649         * breakpoint.c (describe_other_breakpoints): Use address style
8650         to print addresses.
8651         (say_where): Likewise.
8652
8653 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8654
8655         * ada-typeprint.c (print_func_type): Print function name
8656         style to print function name.
8657         * c-typeprint.c (c_print_type_1): Likewise.
8658
8659 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8660
8661         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8662         for execve.
8663
8664 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8665
8666         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8667         type_stack.
8668
8669 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8670
8671         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8672         TYPE_CODE_REF types.
8673
8674 2019-02-08  Jim Wilson  <jimw@sifive.com>
8675
8676         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8677         (riscv_linux_fregset): New.
8678         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8679
8680 2019-02-07  Tom Tromey  <tom@tromey.com>
8681
8682         * thread.c (thread_cancel_execution_command): Update.
8683         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8684         methods.
8685         (struct thread_fsm_ops): Remove.
8686         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8687         (thread_fsm_should_stop, thread_fsm_return_value)
8688         (thread_fsm_set_finished, thread_fsm_finished_p)
8689         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8690         Don't declare.
8691         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8692         * infrun.c (clear_proceed_status_thread)
8693         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8694         (print_stop_event): Update.
8695         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8696         Add constructor.
8697         (step_command_fsm_ops): Remove.
8698         (new_step_command_fsm): Remove.
8699         (step_1): Update.
8700         (step_command_fsm::should_stop): Rename from
8701         step_command_fsm_should_stop.
8702         (step_command_fsm::clean_up): Rename from
8703         step_command_fsm_clean_up.
8704         (step_command_fsm::do_async_reply_reason): Rename from
8705         step_command_fsm_async_reply_reason.
8706         (struct until_next_fsm): Inherit from thread_fsm.  Add
8707         constructor.
8708         (until_next_fsm_ops): Remove.
8709         (new_until_next_fsm): Remove.
8710         (until_next_fsm::should_stop): Rename from
8711         until_next_fsm_should_stop.
8712         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8713         (until_next_fsm::do_async_reply_reason): Rename from
8714         until_next_fsm_async_reply_reason.
8715         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8716         constructor.  Change type of breakpoint.
8717         (finish_command_fsm_ops): Remove.
8718         (new_finish_command_fsm): Remove.
8719         (finish_command_fsm::should_stop): Rename from
8720         finish_command_fsm_should_stop.
8721         (finish_command_fsm::clean_up): Rename from
8722         finish_command_fsm_clean_up.
8723         (finish_command_fsm::return_value): Rename from
8724         finish_command_fsm_return_value.
8725         (finish_command_fsm::do_async_reply_reason): Rename from
8726         finish_command_fsm_async_reply_reason.
8727         (finish_command): Update.
8728         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8729         Add constructor.
8730         (call_thread_fsm_ops): Remove.
8731         (call_thread_fsm::call_thread_fsm): Rename from
8732         new_call_thread_fsm.
8733         (call_thread_fsm::should_stop): Rename from
8734         call_thread_fsm_should_stop.
8735         (call_thread_fsm::should_notify_stop): Rename from
8736         call_thread_fsm_should_notify_stop.
8737         (run_inferior_call, call_function_by_hand_dummy): Update.
8738         * cli/cli-interp.c (should_print_stop_to_console): Update.
8739         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8740         Add constructor.  Change type of location_breakpoint,
8741         caller_breakpoint.
8742         (until_break_fsm_ops): Remove.
8743         (new_until_break_fsm): Remove.
8744         (until_break_fsm::should_stop): Rename from
8745         until_break_fsm_should_stop.
8746         (until_break_fsm::clean_up): Rename from
8747         until_break_fsm_clean_up.
8748         (until_break_fsm::do_async_reply_reason): Rename from
8749         until_break_fsm_async_reply_reason.
8750         (until_break_command): Update.
8751         * thread-fsm.c: Remove.
8752         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8753
8754 2019-02-07  Tom Tromey  <tom@tromey.com>
8755
8756         * yy-remap.h: Add include guard.
8757         * xtensa-tdep.h: Add include guard.
8758         * xcoffread.h: Rename include guard.
8759         * varobj-iter.h: Add include guard.
8760         * tui/tui.h: Rename include guard.
8761         * tui/tui-winsource.h: Rename include guard.
8762         * tui/tui-wingeneral.h: Rename include guard.
8763         * tui/tui-windata.h: Rename include guard.
8764         * tui/tui-win.h: Rename include guard.
8765         * tui/tui-stack.h: Rename include guard.
8766         * tui/tui-source.h: Rename include guard.
8767         * tui/tui-regs.h: Rename include guard.
8768         * tui/tui-out.h: Rename include guard.
8769         * tui/tui-layout.h: Rename include guard.
8770         * tui/tui-io.h: Rename include guard.
8771         * tui/tui-hooks.h: Rename include guard.
8772         * tui/tui-file.h: Rename include guard.
8773         * tui/tui-disasm.h: Rename include guard.
8774         * tui/tui-data.h: Rename include guard.
8775         * tui/tui-command.h: Rename include guard.
8776         * tic6x-tdep.h: Add include guard.
8777         * target/waitstatus.h: Rename include guard.
8778         * target/wait.h: Rename include guard.
8779         * target/target.h: Rename include guard.
8780         * target/resume.h: Rename include guard.
8781         * target-float.h: Rename include guard.
8782         * stabsread.h: Add include guard.
8783         * rs6000-tdep.h: Add include guard.
8784         * riscv-fbsd-tdep.h: Add include guard.
8785         * regformats/regdef.h: Rename include guard.
8786         * record.h: Rename include guard.
8787         * python/python.h: Rename include guard.
8788         * python/python-internal.h: Rename include guard.
8789         * python/py-stopevent.h: Rename include guard.
8790         * python/py-ref.h: Rename include guard.
8791         * python/py-record.h: Rename include guard.
8792         * python/py-record-full.h: Rename include guard.
8793         * python/py-record-btrace.h: Rename include guard.
8794         * python/py-instruction.h: Rename include guard.
8795         * python/py-events.h: Rename include guard.
8796         * python/py-event.h: Rename include guard.
8797         * procfs.h: Add include guard.
8798         * proc-utils.h: Add include guard.
8799         * p-lang.h: Add include guard.
8800         * or1k-tdep.h: Rename include guard.
8801         * observable.h: Rename include guard.
8802         * nto-tdep.h: Rename include guard.
8803         * nat/x86-linux.h: Rename include guard.
8804         * nat/x86-linux-dregs.h: Rename include guard.
8805         * nat/x86-gcc-cpuid.h: Add include guard.
8806         * nat/x86-dregs.h: Rename include guard.
8807         * nat/x86-cpuid.h: Rename include guard.
8808         * nat/ppc-linux.h: Rename include guard.
8809         * nat/mips-linux-watch.h: Rename include guard.
8810         * nat/linux-waitpid.h: Rename include guard.
8811         * nat/linux-ptrace.h: Rename include guard.
8812         * nat/linux-procfs.h: Rename include guard.
8813         * nat/linux-osdata.h: Rename include guard.
8814         * nat/linux-nat.h: Rename include guard.
8815         * nat/linux-namespaces.h: Rename include guard.
8816         * nat/linux-btrace.h: Rename include guard.
8817         * nat/glibc_thread_db.h: Rename include guard.
8818         * nat/gdb_thread_db.h: Rename include guard.
8819         * nat/gdb_ptrace.h: Rename include guard.
8820         * nat/fork-inferior.h: Rename include guard.
8821         * nat/amd64-linux-siginfo.h: Rename include guard.
8822         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8823         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8824         * nat/aarch64-linux.h: Rename include guard.
8825         * nat/aarch64-linux-hw-point.h: Rename include guard.
8826         * mn10300-tdep.h: Add include guard.
8827         * mips-linux-tdep.h: Add include guard.
8828         * mi/mi-parse.h: Rename include guard.
8829         * mi/mi-out.h: Rename include guard.
8830         * mi/mi-main.h: Rename include guard.
8831         * mi/mi-interp.h: Rename include guard.
8832         * mi/mi-getopt.h: Rename include guard.
8833         * mi/mi-console.h: Rename include guard.
8834         * mi/mi-common.h: Rename include guard.
8835         * mi/mi-cmds.h: Rename include guard.
8836         * mi/mi-cmd-break.h: Rename include guard.
8837         * m2-lang.h: Add include guard.
8838         * location.h: Rename include guard.
8839         * linux-record.h: Rename include guard.
8840         * linux-nat.h: Add include guard.
8841         * linux-fork.h: Add include guard.
8842         * i386-darwin-tdep.h: Rename include guard.
8843         * hppa-linux-offsets.h: Add include guard.
8844         * guile/guile.h: Rename include guard.
8845         * guile/guile-internal.h: Rename include guard.
8846         * gnu-nat.h: Rename include guard.
8847         * gdb-stabs.h: Rename include guard.
8848         * frv-tdep.h: Add include guard.
8849         * f-lang.h: Add include guard.
8850         * event-loop.h: Add include guard.
8851         * darwin-nat.h: Rename include guard.
8852         * cp-abi.h: Rename include guard.
8853         * config/sparc/nm-sol2.h: Rename include guard.
8854         * config/nm-nto.h: Rename include guard.
8855         * config/nm-linux.h: Add include guard.
8856         * config/i386/nm-i386gnu.h: Rename include guard.
8857         * config/djgpp/nl_types.h: Rename include guard.
8858         * config/djgpp/langinfo.h: Rename include guard.
8859         * compile/gcc-cp-plugin.h: Add include guard.
8860         * compile/gcc-c-plugin.h: Add include guard.
8861         * compile/compile.h: Rename include guard.
8862         * compile/compile-object-run.h: Rename include guard.
8863         * compile/compile-object-load.h: Rename include guard.
8864         * compile/compile-internal.h: Rename include guard.
8865         * compile/compile-cplus.h: Rename include guard.
8866         * compile/compile-c.h: Rename include guard.
8867         * common/xml-utils.h: Rename include guard.
8868         * common/x86-xstate.h: Rename include guard.
8869         * common/version.h: Rename include guard.
8870         * common/vec.h: Rename include guard.
8871         * common/tdesc.h: Rename include guard.
8872         * common/selftest.h: Rename include guard.
8873         * common/scoped_restore.h: Rename include guard.
8874         * common/scoped_mmap.h: Rename include guard.
8875         * common/scoped_fd.h: Rename include guard.
8876         * common/safe-iterator.h: Rename include guard.
8877         * common/run-time-clock.h: Rename include guard.
8878         * common/refcounted-object.h: Rename include guard.
8879         * common/queue.h: Rename include guard.
8880         * common/ptid.h: Rename include guard.
8881         * common/print-utils.h: Rename include guard.
8882         * common/preprocessor.h: Rename include guard.
8883         * common/pathstuff.h: Rename include guard.
8884         * common/observable.h: Rename include guard.
8885         * common/netstuff.h: Rename include guard.
8886         * common/job-control.h: Rename include guard.
8887         * common/host-defs.h: Rename include guard.
8888         * common/gdb_wait.h: Rename include guard.
8889         * common/gdb_vecs.h: Rename include guard.
8890         * common/gdb_unlinker.h: Rename include guard.
8891         * common/gdb_unique_ptr.h: Rename include guard.
8892         * common/gdb_tilde_expand.h: Rename include guard.
8893         * common/gdb_sys_time.h: Rename include guard.
8894         * common/gdb_string_view.h: Rename include guard.
8895         * common/gdb_splay_tree.h: Rename include guard.
8896         * common/gdb_setjmp.h: Rename include guard.
8897         * common/gdb_ref_ptr.h: Rename include guard.
8898         * common/gdb_optional.h: Rename include guard.
8899         * common/gdb_locale.h: Rename include guard.
8900         * common/gdb_assert.h: Rename include guard.
8901         * common/filtered-iterator.h: Rename include guard.
8902         * common/filestuff.h: Rename include guard.
8903         * common/fileio.h: Rename include guard.
8904         * common/environ.h: Rename include guard.
8905         * common/common-utils.h: Rename include guard.
8906         * common/common-types.h: Rename include guard.
8907         * common/common-regcache.h: Rename include guard.
8908         * common/common-inferior.h: Rename include guard.
8909         * common/common-gdbthread.h: Rename include guard.
8910         * common/common-exceptions.h: Rename include guard.
8911         * common/common-defs.h: Rename include guard.
8912         * common/common-debug.h: Rename include guard.
8913         * common/cleanups.h: Rename include guard.
8914         * common/buffer.h: Rename include guard.
8915         * common/btrace-common.h: Rename include guard.
8916         * common/break-common.h: Rename include guard.
8917         * cli/cli-utils.h: Rename include guard.
8918         * cli/cli-style.h: Rename include guard.
8919         * cli/cli-setshow.h: Rename include guard.
8920         * cli/cli-script.h: Rename include guard.
8921         * cli/cli-interp.h: Rename include guard.
8922         * cli/cli-decode.h: Rename include guard.
8923         * cli/cli-cmds.h: Rename include guard.
8924         * charset-list.h: Add include guard.
8925         * buildsym-legacy.h: Rename include guard.
8926         * bfin-tdep.h: Add include guard.
8927         * ax.h: Rename include guard.
8928         * arm-linux-tdep.h: Add include guard.
8929         * arm-fbsd-tdep.h: Add include guard.
8930         * arch/xtensa.h: Rename include guard.
8931         * arch/tic6x.h: Add include guard.
8932         * arch/i386.h: Add include guard.
8933         * arch/arm.h: Rename include guard.
8934         * arch/arm-linux.h: Rename include guard.
8935         * arch/arm-get-next-pcs.h: Rename include guard.
8936         * arch/amd64.h: Add include guard.
8937         * arch/aarch64-insn.h: Rename include guard.
8938         * arch-utils.h: Rename include guard.
8939         * annotate.h: Add include guard.
8940         * amd64-darwin-tdep.h: Rename include guard.
8941         * aarch64-linux-tdep.h: Add include guard.
8942         * aarch64-fbsd-tdep.h: Add include guard.
8943         * aarch32-linux-nat.h: Add include guard.
8944
8945 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8946
8947         * macrotab.c (macro_define_internal): New function that
8948         factorizes macro_define_object_internal and macro_define_function
8949         code.
8950         (macro_define_object_internal): Use macro_define_internal.
8951         (macro_define_function): Likewise.
8952
8953 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8954
8955         * macrocmd.c (extract_identifier): Return
8956         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8957         callers.
8958
8959 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8960
8961         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8962
8963 2019-02-05  Tom Tromey  <tom@tromey.com>
8964
8965         * target.c (target_stack::unpush): Move assertion earlier.
8966
8967 2019-01-30  Tom Tromey  <tom@tromey.com>
8968
8969         PR python/23615:
8970         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8971         (gdbpy_parse_and_eval): Likewise.
8972         * python/python-internal.h (gdbpy_allow_threads): New class.
8973
8974 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8975
8976         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8977         (aarch64_fbsd_fpregmap): Move earlier.
8978         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8979         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8980         instead of individual calls to trad_frame_set_reg_addr.
8981         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8982         earlier.
8983         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8984         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8985         instead of individual calls to trad_frame_set_reg_addr.
8986
8987 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8988
8989         * CONTRIBUTE: Replace contribution list with wiki link.
8990
8991 2019-01-25  Tom Tromey  <tom@tromey.com>
8992
8993         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8994
8995 2019-01-25  Tom Tromey  <tom@tromey.com>
8996
8997         * xtensa-linux-nat.c: Fix common/ includes.
8998         * xml-support.h: Fix common/ includes.
8999         * xml-support.c: Fix common/ includes.
9000         * x86-linux-nat.c: Fix common/ includes.
9001         * windows-nat.c: Fix common/ includes.
9002         * varobj.h: Fix common/ includes.
9003         * varobj.c: Fix common/ includes.
9004         * value.c: Fix common/ includes.
9005         * valops.c: Fix common/ includes.
9006         * utils.c: Fix common/ includes.
9007         * unittests/xml-utils-selftests.c: Fix common/ includes.
9008         * unittests/utils-selftests.c: Fix common/ includes.
9009         * unittests/unpack-selftests.c: Fix common/ includes.
9010         * unittests/tracepoint-selftests.c: Fix common/ includes.
9011         * unittests/style-selftests.c: Fix common/ includes.
9012         * unittests/string_view-selftests.c: Fix common/ includes.
9013         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9014         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9015         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9016         * unittests/rsp-low-selftests.c: Fix common/ includes.
9017         * unittests/parse-connection-spec-selftests.c: Fix common/
9018         includes.
9019         * unittests/optional-selftests.c: Fix common/ includes.
9020         * unittests/offset-type-selftests.c: Fix common/ includes.
9021         * unittests/observable-selftests.c: Fix common/ includes.
9022         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9023         * unittests/memrange-selftests.c: Fix common/ includes.
9024         * unittests/memory-map-selftests.c: Fix common/ includes.
9025         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9026         * unittests/function-view-selftests.c: Fix common/ includes.
9027         * unittests/environ-selftests.c: Fix common/ includes.
9028         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9029         * unittests/common-utils-selftests.c: Fix common/ includes.
9030         * unittests/cli-utils-selftests.c: Fix common/ includes.
9031         * unittests/array-view-selftests.c: Fix common/ includes.
9032         * ui-file.c: Fix common/ includes.
9033         * tui/tui-io.c: Fix common/ includes.
9034         * tracepoint.h: Fix common/ includes.
9035         * tracepoint.c: Fix common/ includes.
9036         * tracefile-tfile.c: Fix common/ includes.
9037         * top.h: Fix common/ includes.
9038         * top.c: Fix common/ includes.
9039         * thread.c: Fix common/ includes.
9040         * target/waitstatus.h: Fix common/ includes.
9041         * target/waitstatus.c: Fix common/ includes.
9042         * target.h: Fix common/ includes.
9043         * target.c: Fix common/ includes.
9044         * target-memory.c: Fix common/ includes.
9045         * target-descriptions.c: Fix common/ includes.
9046         * symtab.h: Fix common/ includes.
9047         * symfile.c: Fix common/ includes.
9048         * stap-probe.c: Fix common/ includes.
9049         * spu-linux-nat.c: Fix common/ includes.
9050         * sparc-nat.c: Fix common/ includes.
9051         * source.c: Fix common/ includes.
9052         * solib.c: Fix common/ includes.
9053         * solib-target.c: Fix common/ includes.
9054         * ser-unix.c: Fix common/ includes.
9055         * ser-tcp.c: Fix common/ includes.
9056         * ser-pipe.c: Fix common/ includes.
9057         * ser-base.c: Fix common/ includes.
9058         * selftest-arch.c: Fix common/ includes.
9059         * s12z-tdep.c: Fix common/ includes.
9060         * rust-exp.y: Fix common/ includes.
9061         * rs6000-aix-tdep.c: Fix common/ includes.
9062         * riscv-tdep.c: Fix common/ includes.
9063         * remote.c: Fix common/ includes.
9064         * remote-notif.h: Fix common/ includes.
9065         * remote-fileio.h: Fix common/ includes.
9066         * remote-fileio.c: Fix common/ includes.
9067         * regcache.h: Fix common/ includes.
9068         * regcache.c: Fix common/ includes.
9069         * record-btrace.c: Fix common/ includes.
9070         * python/python.c: Fix common/ includes.
9071         * python/py-type.c: Fix common/ includes.
9072         * python/py-inferior.c: Fix common/ includes.
9073         * progspace.h: Fix common/ includes.
9074         * producer.c: Fix common/ includes.
9075         * procfs.c: Fix common/ includes.
9076         * proc-api.c: Fix common/ includes.
9077         * printcmd.c: Fix common/ includes.
9078         * ppc-linux-nat.c: Fix common/ includes.
9079         * parser-defs.h: Fix common/ includes.
9080         * osdata.c: Fix common/ includes.
9081         * obsd-nat.c: Fix common/ includes.
9082         * nat/x86-linux.c: Fix common/ includes.
9083         * nat/x86-linux-dregs.c: Fix common/ includes.
9084         * nat/x86-dregs.h: Fix common/ includes.
9085         * nat/x86-dregs.c: Fix common/ includes.
9086         * nat/ppc-linux.c: Fix common/ includes.
9087         * nat/mips-linux-watch.h: Fix common/ includes.
9088         * nat/mips-linux-watch.c: Fix common/ includes.
9089         * nat/linux-waitpid.c: Fix common/ includes.
9090         * nat/linux-ptrace.h: Fix common/ includes.
9091         * nat/linux-ptrace.c: Fix common/ includes.
9092         * nat/linux-procfs.c: Fix common/ includes.
9093         * nat/linux-personality.c: Fix common/ includes.
9094         * nat/linux-osdata.c: Fix common/ includes.
9095         * nat/linux-namespaces.c: Fix common/ includes.
9096         * nat/linux-btrace.h: Fix common/ includes.
9097         * nat/linux-btrace.c: Fix common/ includes.
9098         * nat/fork-inferior.c: Fix common/ includes.
9099         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9100         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9101         * nat/aarch64-linux.c: Fix common/ includes.
9102         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9103         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9104         * namespace.h: Fix common/ includes.
9105         * mips-linux-tdep.c: Fix common/ includes.
9106         * minsyms.c: Fix common/ includes.
9107         * mi/mi-parse.h: Fix common/ includes.
9108         * mi/mi-main.c: Fix common/ includes.
9109         * mi/mi-cmd-env.c: Fix common/ includes.
9110         * memrange.h: Fix common/ includes.
9111         * memattr.c: Fix common/ includes.
9112         * maint.h: Fix common/ includes.
9113         * maint.c: Fix common/ includes.
9114         * main.c: Fix common/ includes.
9115         * machoread.c: Fix common/ includes.
9116         * location.c: Fix common/ includes.
9117         * linux-thread-db.c: Fix common/ includes.
9118         * linux-nat.c: Fix common/ includes.
9119         * linux-fork.c: Fix common/ includes.
9120         * inline-frame.c: Fix common/ includes.
9121         * infrun.c: Fix common/ includes.
9122         * inflow.c: Fix common/ includes.
9123         * inferior.h: Fix common/ includes.
9124         * inferior.c: Fix common/ includes.
9125         * infcmd.c: Fix common/ includes.
9126         * inf-ptrace.c: Fix common/ includes.
9127         * inf-child.c: Fix common/ includes.
9128         * ia64-linux-nat.c: Fix common/ includes.
9129         * i387-tdep.c: Fix common/ includes.
9130         * i386-tdep.c: Fix common/ includes.
9131         * i386-linux-tdep.c: Fix common/ includes.
9132         * i386-linux-nat.c: Fix common/ includes.
9133         * i386-go32-tdep.c: Fix common/ includes.
9134         * i386-fbsd-tdep.c: Fix common/ includes.
9135         * i386-fbsd-nat.c: Fix common/ includes.
9136         * guile/scm-type.c: Fix common/ includes.
9137         * guile/guile.c: Fix common/ includes.
9138         * go32-nat.c: Fix common/ includes.
9139         * gnu-nat.c: Fix common/ includes.
9140         * gdbthread.h: Fix common/ includes.
9141         * gdbarch-selftests.c: Fix common/ includes.
9142         * gdb_usleep.c: Fix common/ includes.
9143         * gdb_select.h: Fix common/ includes.
9144         * gdb_bfd.c: Fix common/ includes.
9145         * gcore.c: Fix common/ includes.
9146         * fork-child.c: Fix common/ includes.
9147         * findvar.c: Fix common/ includes.
9148         * fbsd-nat.c: Fix common/ includes.
9149         * event-top.c: Fix common/ includes.
9150         * event-loop.c: Fix common/ includes.
9151         * dwarf2read.c: Fix common/ includes.
9152         * dwarf2loc.c: Fix common/ includes.
9153         * dwarf2-frame.c: Fix common/ includes.
9154         * dwarf-index-cache.c: Fix common/ includes.
9155         * dtrace-probe.c: Fix common/ includes.
9156         * disasm-selftests.c: Fix common/ includes.
9157         * defs.h: Fix common/ includes.
9158         * csky-tdep.c: Fix common/ includes.
9159         * cp-valprint.c: Fix common/ includes.
9160         * cp-support.h: Fix common/ includes.
9161         * cp-support.c: Fix common/ includes.
9162         * corelow.c: Fix common/ includes.
9163         * completer.h: Fix common/ includes.
9164         * completer.c: Fix common/ includes.
9165         * compile/compile.c: Fix common/ includes.
9166         * compile/compile-loc2c.c: Fix common/ includes.
9167         * compile/compile-cplus-types.c: Fix common/ includes.
9168         * compile/compile-cplus-symbols.c: Fix common/ includes.
9169         * command.h: Fix common/ includes.
9170         * cli/cli-dump.c: Fix common/ includes.
9171         * cli/cli-cmds.c: Fix common/ includes.
9172         * charset.c: Fix common/ includes.
9173         * build-id.c: Fix common/ includes.
9174         * btrace.h: Fix common/ includes.
9175         * btrace.c: Fix common/ includes.
9176         * breakpoint.h: Fix common/ includes.
9177         * breakpoint.c: Fix common/ includes.
9178         * ax.h:
9179         (enum agent_op): Fix common/ includes.
9180         * ax-general.c (struct aop_map): Fix common/ includes.
9181         * ax-gdb.c: Fix common/ includes.
9182         * auxv.c: Fix common/ includes.
9183         * auto-load.c: Fix common/ includes.
9184         * arm-tdep.c: Fix common/ includes.
9185         * arch/riscv.c: Fix common/ includes.
9186         * arch/ppc-linux-common.c: Fix common/ includes.
9187         * arch/i386.c: Fix common/ includes.
9188         * arch/arm.c: Fix common/ includes.
9189         * arch/arm-linux.c: Fix common/ includes.
9190         * arch/arm-get-next-pcs.c: Fix common/ includes.
9191         * arch/amd64.c: Fix common/ includes.
9192         * arch/aarch64.c: Fix common/ includes.
9193         * arch/aarch64-insn.c: Fix common/ includes.
9194         * arch-utils.c: Fix common/ includes.
9195         * amd64-windows-tdep.c: Fix common/ includes.
9196         * amd64-tdep.c: Fix common/ includes.
9197         * amd64-sol2-tdep.c: Fix common/ includes.
9198         * amd64-obsd-tdep.c: Fix common/ includes.
9199         * amd64-nbsd-tdep.c: Fix common/ includes.
9200         * amd64-linux-tdep.c: Fix common/ includes.
9201         * amd64-linux-nat.c: Fix common/ includes.
9202         * amd64-fbsd-tdep.c: Fix common/ includes.
9203         * amd64-fbsd-nat.c: Fix common/ includes.
9204         * amd64-dicos-tdep.c: Fix common/ includes.
9205         * amd64-darwin-tdep.c: Fix common/ includes.
9206         * agent.c: Fix common/ includes.
9207         * ada-lang.h: Fix common/ includes.
9208         * ada-lang.c: Fix common/ includes.
9209         * aarch64-tdep.c: Fix common/ includes.
9210
9211 2019-01-25  Tom Tromey  <tom@tromey.com>
9212
9213         * common/create-version.sh: Use common/version.h.
9214
9215 2019-01-24  Pedro Alves  <palves@redhat.com>
9216
9217         * infrun.c (signal_stop, signal_print, signal_program)
9218         (signal_catch, signal_pass): Now arrays instead of pointers.
9219         (update_signals_program_target, do_target_resume)
9220         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9221         * linux-nat.c (linux_nat_target::pass_signals)
9222         (linux_nat_target::create_inferior, linux_nat_target::attach):
9223         Adjust.
9224         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9225         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9226         * procfs.c (procfs_target::pass_signals): Adjust.
9227         * record-full.c (record_full_target::resume): Adjust.
9228         * remote.c (remote_target::pass_signals)
9229         (remote_target::program_signals): Adjust.
9230         * target-debug.h (target_debug_print_signals): Now takes a
9231         gdb::array_view as parameter.  Adjust.
9232         * target.h (target_ops) <pass_signals, program_signals>: Replace
9233         pointer and length parameters with gdb::array_view.
9234         (target_pass_signals, target_program_signals): Likewise.
9235         * target-delegates.c: Regenerate.
9236
9237 2019-01-24  Pedro Alves  <palves@redhat.com>
9238
9239         * common/forward-scope-exit.h
9240         (forward_scope_exit::forward_scope_exit): Pass arguments to
9241         m_bind_function directly, instead of creating a std::bind and
9242         copying that.
9243
9244 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9245
9246         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9247         for static members.
9248         (pass_in_v_vfp_candidate): Likewise.
9249
9250 2019-01-23  Tom Tromey  <tom@tromey.com>
9251             Pedro Alves  <palves@redhat.com>
9252
9253         * regcache.c (class regcache_invalidator): Remove.
9254         (regcache::raw_write): Use make_scope_exit.
9255
9256 2019-01-23  Tom Tromey  <tom@tromey.com>
9257
9258         * ui-out.h (class ui_out_emit_type): Update comment.
9259
9260 2019-01-23  Tom Tromey  <tom@tromey.com>
9261
9262         * infrun.c (fetch_inferior_event): Update comment.
9263
9264 2019-01-23  Tom Tromey  <tom@tromey.com>
9265             Pedro Alves  <palves@redhat.com>
9266
9267         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9268         parameter.
9269         (fetch_inferior_event): Use SCOPE_EXIT.
9270
9271
9272 2019-01-23  Tom Tromey  <tom@tromey.com>
9273             Pedro Alves  <palves@redhat.com>
9274
9275         * infrun.c (disable_thread_events): Delete.
9276         (stop_all_threads): Use SCOPE_EXIT.
9277
9278 2019-01-23  Tom Tromey  <tom@tromey.com>
9279             Pedro Alves  <palves@redhat.com>
9280
9281         * symfile.c: Include forward-scope-exit.h.
9282         (clear_symtab_users_cleanup): Replace forward declaration with
9283         a FORWARD_SCOPE_EXIT.
9284         (syms_from_objfile_1): Use the forward_scope_exit and
9285         gdb::optional instead of cleanup_function.
9286         (reread_symbols): Use the forward_scope_exit instead of
9287         cleanup_function.
9288         (clear_symtab_users_cleanup): Remove function.
9289
9290 2019-01-23  Tom Tromey  <tom@tromey.com>
9291             Pedro Alves  <palves@redhat.com>
9292
9293         * linux-nat.c: Include scope-exit.h.
9294         (cleanup_target_stop): Remove.
9295         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9296         SCOPE_EXIT.
9297
9298 2019-01-23  Tom Tromey  <tom@tromey.com>
9299             Pedro Alves  <palves@redhat.com>
9300
9301         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9302         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9303
9304 2019-01-23  Tom Tromey  <tom@tromey.com>
9305             Andrew Burgess  <andrew.burgess@embecosm.com>
9306             Pedro Alves  <palves@redhat.com>
9307
9308         * infrun.c (fetch_inferior_event): Use scope_exit.
9309         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9310         * top.c (execute_command): Use scope_exit.
9311         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9312         * utils.c (do_bpstat_clear_actions_cleanup)
9313         (make_bpstat_clear_actions_cleanup): Remove.
9314
9315 2019-01-23  Tom Tromey  <tom@tromey.com>
9316             Pedro Alves  <palves@redhat.com>
9317
9318         * infrun.c: Include "common/scope-exit.h"
9319         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9320         (wait_for_inferior): Use SCOPE_EXIT.
9321         (fetch_inferior_event): Use scope_exit.
9322
9323 2019-01-23  Tom Tromey  <tom@tromey.com>
9324             Pedro Alves  <palves@redhat.com>
9325
9326         * breakpoint.c (create_breakpoint): Remove cleanup.
9327
9328 2019-01-23  Tom Tromey  <tom@tromey.com>
9329             Andrew Burgess  <andrew.burgess@embecosm.com>
9330             Pedro Alves  <palves@redhat.com>
9331
9332 2019-01-23  Pedro Alves  <palves@redhat.com>
9333
9334         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9335
9336 2019-01-23  Pedro Alves  <palves@redhat.com>
9337             Andrew Burgess  <andrew.burgess@embecosm.com>
9338
9339         * gdbthread.h: Include "common/forward-scope-exit.h".
9340         (scoped_finish_thread_state): Redefine custom class in terms of
9341         forward_scope_exit.
9342
9343 2019-01-23  Pedro Alves  <palves@redhat.com>
9344             Andrew Burgess  <andrew.burgess@embecosm.com>
9345
9346         * common/forward-scope-exit.h: New file.
9347
9348 2019-01-23  Pedro Alves  <palves@redhat.com>
9349             Andrew Burgess  <andrew.burgess@embecosm.com>
9350             Tom Tromey  <tom@tromey.com>
9351
9352         * common/scope-exit.h: New file.
9353
9354 2019-01-23  Pedro Alves  <palves@redhat.com>
9355
9356         * common/preprocessor.h (ESC): Rename to ...
9357         (ESC_PARENS): ... this.
9358         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9359         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9360
9361 2019-01-23  Tom Tromey  <tom@tromey.com>
9362
9363         * language.h (class scoped_switch_to_sym_language_if_auto):
9364         Initialize m_lang in both cases.
9365
9366 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9367
9368         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9369         with XCNEW.
9370
9371 2019-01-22  Tom Tromey  <tom@tromey.com>
9372
9373         * corelow.c: Do not include sys/file.h.
9374
9375 2019-01-22  Tom Tromey  <tom@tromey.com>
9376
9377         * tui/tui-wingeneral.h: Include gdb_curses.h.
9378
9379 2019-01-22  Tom Tromey  <tom@tromey.com>
9380
9381         * source-cache.h (class source_cache) <get_source_lines,
9382         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9383
9384 2019-01-22  Tom Tromey  <tom@tromey.com>
9385
9386         * remote-fileio.h (struct remote_target): Declare.
9387
9388 2019-01-22  Tom Tromey  <tom@tromey.com>
9389
9390         * python/py-arch.c: Do not include py-ref.h.
9391         * python/py-bpevent.c: Do not include py-ref.h.
9392         * python/py-cmd.c: Do not include py-ref.h.
9393         * python/py-continueevent.c: Do not include py-ref.h.
9394         * python/py-event.h: Do not include py-ref.h.
9395         * python/py-evtregistry.c: Do not include py-ref.h.
9396         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9397         * python/py-frame.c: Do not include py-ref.h.
9398         * python/py-framefilter.c: Do not include py-ref.h.
9399         * python/py-function.c: Do not include py-ref.h.
9400         * python/py-infevents.c: Do not include py-ref.h.
9401         * python/py-linetable.c: Do not include py-ref.h.
9402         * python/py-objfile.c: Do not include py-ref.h.
9403         * python/py-param.c: Do not include py-ref.h.
9404         * python/py-prettyprint.c: Do not include py-ref.h.
9405         * python/py-progspace.c: Do not include py-ref.h.
9406         * python/py-symbol.c: Do not include py-ref.h.
9407         * python/py-symtab.c: Do not include py-ref.h.
9408         * python/py-type.c: Do not include py-ref.h.
9409         * python/py-unwind.c: Do not include py-ref.h.
9410         * python/py-utils.c: Do not include py-ref.h.
9411         * python/py-value.c: Do not include py-ref.h.
9412         * python/py-varobj.c: Do not include py-ref.h.
9413         * python/py-xmethods.c: Do not include py-ref.h.
9414         * python/python.c: Do not include py-ref.h.
9415         * varobj.c: Do not include py-ref.h.
9416
9417 2019-01-22  Tom Tromey  <tom@tromey.com>
9418
9419         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9420         keyword for bcache.
9421
9422 2019-01-22  Tom Tromey  <tom@tromey.com>
9423
9424         * compile/compile-cplus-types.c: Remove a comment by #include.
9425
9426 2019-01-22  Tom Tromey  <tom@tromey.com>
9427
9428         * compile/gcc-c-plugin.h: Include compile-internal.h.
9429
9430 2019-01-22  Tom Tromey  <tom@tromey.com>
9431
9432         * stabsread.c (EXTERN): Do not define.
9433         (symnum, next_symbol_text_func, processing_gcc_compilation)
9434         (within_function, global_sym_chain, global_stabs)
9435         (previous_stab_code, this_object_header_files)
9436         (n_this_object_header_files)
9437         (n_allocated_this_object_header_files): Define.
9438         * stabsread.h (EXTERN): Never define.  Use "extern".
9439
9440 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9441
9442         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9443         history_value.
9444
9445 2019-01-21  Tom Tromey  <tom@tromey.com>
9446
9447         * ui-out.c: Fix includes.
9448         * tui/tui-source.c: Fix includes.
9449         * target.c: Fix includes.
9450         * remote.c: Fix includes.
9451         * regcache.c: Fix includes.
9452         * python/py-block.c: Fix includes.
9453         * printcmd.c: Fix includes.
9454         * or1k-tdep.c: Fix includes.
9455         * mi/mi-main.c: Fix includes.
9456         * m32r-tdep.c: Fix includes.
9457         * csky-tdep.c: Fix includes.
9458         * compile/compile-cplus-types.c: Fix includes.
9459         * cli/cli-interp.c: Fix includes.
9460
9461 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9462
9463         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9464         for padding.
9465
9466 2019-01-16  Tom Tromey  <tom@tromey.com>
9467
9468         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9469         earlier.
9470         (struct objfile) <msymbols_range>: Move from top level.
9471         <msymbols>: New method.
9472         (class objfile_msymbols): Remove.
9473         * symtab.c (default_collect_symbol_completion_matches_break_on):
9474         Update.
9475         * symmisc.c (dump_msymbols): Update.
9476         * stabsread.c (scan_file_globals): Update.
9477         * objc-lang.c (info_selectors_command, info_classes_command)
9478         (find_methods): Update.
9479         * minsyms.c (find_solib_trampoline_target): Update.
9480         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9481         * coffread.c (coff_symfile_read): Update.
9482         * ada-lang.c (ada_lookup_simple_minsym)
9483         (ada_collect_symbol_completion_matches): Update.
9484
9485 2019-01-16  Tom Tromey  <tom@tromey.com>
9486
9487         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9488         type.  Remove no-argument constructor.
9489         <iterator::operator++>: Simplify.
9490         <begin>: Update.
9491         <end>: Use minimal_symbol_count.
9492
9493 2019-01-16  Tom Tromey  <tom@tromey.com>
9494
9495         * objfiles.h (struct objfile) <psymtabs>: New method.
9496         (class objfile_psymtabs): Remove.
9497         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9498         typedef.
9499         <range>: New method.
9500         (require_partial_symbols): Change return type.
9501         * psymtab.c (require_partial_symbols)
9502         (psym_expand_symtabs_matching): Update.
9503         * mdebugread.c (parse_partial_symbols): Update.
9504         * dbxread.c (dbx_end_psymtab): Update.
9505
9506 2019-01-15  Tom Tromey  <tom@tromey.com>
9507
9508         * symtab.c (lookup_objfile_from_block)
9509         (lookup_symbol_in_objfile_symtabs)
9510         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9511         (find_line_symtab, info_sources_command)
9512         (default_collect_symbol_completion_matches_break_on)
9513         (make_source_files_completion_list): Update.
9514         * symmisc.c (print_objfile_statistics, dump_objfile)
9515         (maintenance_print_symbols, maintenance_info_symtabs)
9516         (maintenance_check_symtabs, maintenance_info_line_tables):
9517         Update.
9518         * source.c (select_source_symtab)
9519         (forget_cached_source_info_for_objfile): Update.
9520         * objfiles.h (class objfile_compunits): Remove.
9521         (struct objfile) <compunits_range>: New typedef.
9522         (compunits): New method.
9523         * objfiles.c (objfile_relocate1): Update.
9524         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9525         * maint.c (count_symtabs_and_blocks): Update.
9526         * linespec.c (iterate_over_all_matching_symtabs): Update.
9527         * cp-support.c (add_symbol_overload_list_qualified): Update.
9528         * coffread.c (coff_symtab_read): Update.
9529         * ada-lang.c (add_nonlocal_symbols)
9530         (ada_collect_symbol_completion_matches)
9531         (ada_add_global_exceptions): Update.
9532
9533 2019-01-15  Tom Tromey  <tom@tromey.com>
9534
9535         * progspace.h (program_space) <objfiles_safe_range>: New
9536         typedef.
9537         <objfiles_safe>: New method.
9538         * objfiles.h (class all_objfiles_safe): Remove.
9539         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9540         * jit.c (jit_inferior_exit_hook): Update.
9541
9542 2019-01-17  Tom Tromey  <tom@tromey.com>
9543
9544         * progspace.h (program_space) <objfiles_range>: New typedef.
9545         <objfiles>: New method.
9546         <objfiles_head>: Rename from objfiles.
9547         (object_files): Update.
9548         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9549         * guile/scm-pretty-print.c
9550         (ppscm_find_pretty_printer_from_objfiles): Update.
9551         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9552         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9553         Update.
9554         * python/py-progspace.c (pspy_get_objfiles): Update.
9555         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9556         Update.
9557         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9558         (objfpy_lookup_objfile_by_build_id): Update.
9559         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9560         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9561         Update.
9562         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9563         (expand_symtab_containing_pc, lookup_objfile_from_block)
9564         (lookup_static_symbol, basic_lookup_transparent_type)
9565         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9566         (find_line_symtab, info_sources_command)
9567         (default_collect_symbol_completion_matches_break_on)
9568         (make_source_files_completion_list, find_main_name): Update.
9569         * symmisc.c (print_symbol_bcache_statistics)
9570         (print_objfile_statistics, maintenance_print_symbols)
9571         (maintenance_print_msymbols, maintenance_print_objfiles)
9572         (maintenance_info_symtabs, maintenance_check_symtabs)
9573         (maintenance_expand_symtabs, maintenance_info_line_tables):
9574         Update.
9575         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9576         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9577         (map_overlay_command, unmap_overlay_command)
9578         (simple_overlay_update, expand_symtabs_matching)
9579         (map_symbol_filenames): Update.
9580         * symfile-debug.c (set_debug_symfile): Update.
9581         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9582         Update.
9583         * source.c (select_source_symtab, forget_cached_source_info):
9584         Update.
9585         * solib.c (solib_read_symbols): Update.
9586         * solib-spu.c (append_ocl_sos): Update.
9587         * psymtab.c (maintenance_print_psymbols)
9588         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9589         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9590         * printcmd.c (info_symbol_command): Update.
9591         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9592         Update.
9593         * objfiles.h (class all_objfiles): Remove.
9594         * objfiles.c (have_partial_symbols, have_full_symbols)
9595         (have_minimal_symbols, qsort_cmp, update_section_map)
9596         (shared_objfile_contains_address_p)
9597         (default_iterate_over_objfiles_in_search_order): Update.
9598         * objc-lang.c (info_selectors_command, info_classes_command)
9599         (find_methods): Update.
9600         * minsyms.c (find_solib_trampoline_target): Update.
9601         * maint.c (maintenance_info_sections)
9602         (maintenance_translate_address, count_symtabs_and_blocks):
9603         Update.
9604         * main.c (captured_main_1): Update.
9605         * linux-thread-db.c (try_thread_db_load_from_pdir)
9606         (has_libpthread): Update.
9607         * linespec.c (iterate_over_all_matching_symtabs)
9608         (search_minsyms_for_name): Update.
9609         * jit.c (jit_find_objf_with_entry_addr): Update.
9610         * hppa-tdep.c (find_unwind_entry)
9611         (hppa_lookup_stub_minimal_symbol): Update.
9612         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9613         Update.
9614         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9615         (elf_gnu_ifunc_resolve_by_got): Update.
9616         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9617         * dwarf-index-write.c (save_gdb_index_command): Update.
9618         * cp-support.c (add_symbol_overload_list_qualified): Update.
9619         * breakpoint.c (create_overlay_event_breakpoint)
9620         (create_longjmp_master_breakpoint)
9621         (create_std_terminate_master_breakpoint)
9622         (create_exception_master_breakpoint): Update.
9623         * blockframe.c (find_pc_partial_function): Update.
9624         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9625         (ada_collect_symbol_completion_matches)
9626         (ada_add_global_exceptions): Update.
9627
9628 2019-01-17  Tom Tromey  <tom@tromey.com>
9629
9630         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9631         declare VEC.
9632         (solib_target_parse_libraries): Change return type.
9633         (library_list_start_segment, library_list_start_section)
9634         (library_list_end_library, library_list_start_library); Update.
9635         (solib_target_free_library_list): Remove.
9636         (solib_target_parse_libraries): Remove cleanup.  Change return
9637         type.
9638         (solib_target_current_sos): Update.
9639
9640 2019-01-17  Tom Tromey  <tromey@bapiya>
9641
9642         * valprint.c: Replace "the the" with "the".
9643         * symtab.c: Replace "the the" with "the".
9644         * solib.c: Replace "the the" with "the".
9645         * solib-dsbt.c: Replace "the the" with "the".
9646         * linespec.c: Replace "the the" with "the".
9647         * dwarf2loc.h: Replace "the the" with "the".
9648         * amd64-windows-tdep.c: Replace "the the" with "the".
9649         * aarch64-tdep.c: Replace "the the" with "the".
9650
9651 2019-01-16  Keith Seitz  <keiths@redhat.com>
9652
9653         PR gdb/23773
9654         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9655         <builder>: Rename to ..
9656         <m_builder>: ... this and make private.
9657         (dwarf2_cu::get_builder): New method.  Change all users of
9658         `builder' to use this method.
9659         (dwarf2_start_symtab): Move to ...
9660         (dwarf2_cu::start_symtab): ... here.  Update all callers
9661         (setup_type_unit_groups): Move to ...
9662         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9663         callers.
9664         (dwarf2_cu::reset_builder): New method.
9665         (process_full_compunit, process_full_type_unit): Use
9666         dwarf2_cu::reset_builder.
9667         (follow_die_offset): Record the ancestor CU if it is different
9668         from the followed DIE's CU.
9669         (follow_die_sig_1): Likewise.
9670
9671 2019-01-15  Tom Tromey  <tom@tromey.com>
9672
9673         * remote.c (class remote_state) <buf>: Now a char_vector.
9674         <buf_size>: Remove.
9675         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9676         parameter.
9677         (remote_target::getpkt_or_notif_sane_1)
9678         (remote_target::getpkt_sane)
9679         (remote_target::getpkt_or_notif_sane): Likewise.
9680         (class remote_target) <putpkt>: New overload.
9681         (remote_target::read_frame): Change type of "buf_p".  Remove
9682         sizeof_p parameter.
9683         (packet_ok): New overload.
9684         (packet_check_result): New overload.
9685         Update all uses.
9686
9687 2019-01-14  Tom Tromey  <tom@tromey.com>
9688
9689         * remote-notif.c (handle_notification, remote_notif_ack)
9690         (remote_notif_parse): Make "buf" const.
9691         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9692         const.
9693         (remote_notif_parse, remote_notif_ack, handle_notification):
9694         Likewise.
9695         * remote.c (remote_notif_stop_parse): Make "buf" const.
9696         (remote_target::remote_parse_stop_reply): Make "buf" const.
9697         (remote_notif_stop_ack): Make "buf" const.
9698
9699 2019-01-14  Tom Tromey  <tom@tromey.com>
9700
9701         * remote.c (remote_console_output): Make parameter const.
9702
9703 2019-01-14  Tom Tromey  <tom@tromey.com>
9704
9705         * target-debug.h (target_debug_print_signals): Constify.
9706         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9707         * procfs.c (procfs_target::pass_signals): Update.
9708         * linux-nat.c (linux_nat_target::pass_signals): Update.
9709         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9710         * target-delegates.c: Rebuild.
9711         * remote.c (remote_target::program_signals): Update.
9712         (remote_target::pass_signals): Update.
9713         * target.c (target_pass_signals): Constify argument.
9714         (target_program_signals): Likewise.
9715         * target.h (struct target_ops) <pass_signals, program_signals>:
9716         Constify argument.
9717         (target_pass_signals, target_program_signals): Constify argument.
9718
9719 2019-01-14  Tom Tromey  <tom@tromey.com>
9720
9721         PR tui/28819:
9722         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9723
9724 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9725
9726         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9727         field.
9728         * rs6000-tdep.c: Include reggroups.h.
9729         (IS_V_ALIAS_PSEUDOREG): Define.
9730         (rs6000_register_name): Return names for the "vX" aliases.
9731         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9732         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9733         aliases.  Call default_register_reggroup_p for all other
9734         pseudo-registers.
9735         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9736         New functions.
9737         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9738         Handle "vX" aliases.
9739         (v_alias_pseudo_register_collect): New function.
9740         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9741         (rs6000_gdbarch_init): Initialize "vX" aliases as
9742         pseudo-registers.  Restore registration of
9743         rs6000_pseudo_register_reggroup_p with
9744         set_tdesc_pseudo_register_reggroup_p.
9745
9746 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9747
9748         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9749         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9750         set_gdbarch_num_pseudo_regs.
9751
9752 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9753
9754         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9755         Remove arg prefixname, add do_set and do_show.
9756         Add member functions set_list and show_list.
9757         * cli/cli-style.c (class cli_style_option): Update accordingly.
9758         (style_set_list): Move to file scope.
9759         (style_show_list): Likewise.
9760         (set_style): Call help_list.
9761         (show_style): Call cmd_show_list.
9762         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9763         Update to use the new macro.
9764
9765 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9766
9767         * ada-lang.c (_initialize_ada_language): Expand the help text
9768         for the "catch exception" command.
9769
9770 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9771
9772         * symtab.c (matching_obj_sections): Initialize obj,
9773         declare it closer to its usage.
9774
9775 2019-01-10  Tom Tromey  <tom@tromey.com>
9776
9777         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9778         (basic_inf_threads_range): Remove.
9779         (inf_threads_range, inf_non_exited_threads_range)
9780         (safe_inf_threads_range): Use next_adapter.
9781
9782 2019-01-10  Keith Seitz  <keiths@redhat.com>
9783
9784         PR gdb/23712
9785         PR symtab/23010
9786         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9787         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9788
9789 2019-01-10  Keith Seitz  <keiths@redhat.com>
9790
9791         PR gdb/23712
9792         PR symtab/23010
9793         * dictionary.c (pending_to_vector): Remove.
9794         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9795         Remove _1 suffix, replacing functions of the same name.  Update
9796         all callers.
9797         (dict_create_hashed, dict_create_hashed_expandable)
9798         (dict_create_linear, dict_create_linear_expandable, dict_free)
9799         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9800         Make functions static.
9801
9802 2019-01-10  Keith Seitz  <keiths@redhat.com>
9803
9804         PR gdb/23712
9805         PR symtab/23010
9806         * dictionary.h (struct dictionary): Replace declaration with
9807         multidictionary.
9808         (dict_create_hashed, dict_create_hashed_expandable)
9809         (dict_create_linear, dict_create_linear_expandable)
9810         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9811         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9812         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9813         taking multidictionary argument.
9814         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9815         * block.h (struct block) <dict>: Change to multidictionary
9816         and rename `multidict'.
9817         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9818         symmisc.c: Update all dictionary references to multidictionary.
9819
9820 2019-01-10  Keith Seitz  <keiths@redhat.com>
9821
9822         PR gdb/23712
9823         PR symtab/23010
9824         * dictionary.c: Include unordered_map.
9825         (pending_to_vector): New function.
9826         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9827         Rewrite the non-"_1" functions to take vector instead
9828         of linked list.
9829         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9830         "new" _1 versions of the same name.
9831         (multidictionary): Define.
9832         (std::hash<enum language): New definition.
9833         (collate_pending_symbols_by_language, mdict_create_hashed)
9834         (mdict_create_hashed_expandable, mdict_create_linear)
9835         (mdict_create_linear_expandable, mdict_free)
9836         (find_language_dictionary, create_new_language_dictionary)
9837         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9838         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9839         (mdict_size, mdict_empty): New functions.
9840         * dictionary.h (mdict_iterator): Define.
9841
9842 2019-01-10  Pedro Alves  <palves@redhat.com>
9843
9844         * breakpoint.c (read_uploaded_action)
9845         (create_tracepoint_from_upload): Adjust to use
9846         gdb::unique_xmalloc_ptr.
9847         * ctf.c (ctf_write_uploaded_tp):
9848         (SET_ARRAY_FIELD): Use emplace_back.
9849         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9850         * tracefile-tfile.c (tfile_write_uploaded_tp):
9851         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9852         gdb::unique_xmalloc_ptr.
9853         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9854         at_string, cond_string, cmd_strings>: Replace char pointers
9855         with gdb::unique_xmalloc_ptr.
9856
9857 2019-01-10  Pedro Alves  <palves@redhat.com>
9858
9859         * solib-target.c (library_list_start_library): Don't xstrdup name.
9860
9861 2019-01-10  Pedro Alves  <palves@redhat.com>
9862
9863         * mdebugread.c (parse_partial_symbols): Use
9864         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9865
9866 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9867
9868         * linux-fork.c (scoped_switch_fork_info)
9869         <~scoped_switch_fork_info>: Fix incorrect variable name.
9870
9871 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9872
9873         * linux-fork.c (scoped_switch_fork_info)
9874         <scoped_switch_fork_info>: Make explicit.
9875         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9876
9877 2019-01-10  Tom Tromey  <tom@tromey.com>
9878
9879         * objfiles.h (objfile::reset_psymtabs): Update.
9880         * objfiles.c (objfile::objfile): Update.
9881         * psymtab.h (psymtab_storage::obstack): Update.
9882         (psymtab_storage::m_obstack): Use gdb::optional.
9883         (class psymtab_storage): Update comment.  Remove objfile
9884         parameter.
9885         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9886
9887 2019-01-10  Tom Tromey  <tom@tromey.com>
9888
9889         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9890         <free_psymtabs>: Now private.
9891         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9892         (allocate_psymtab): Use new method.
9893
9894 2019-01-10  Tom Tromey  <tom@tromey.com>
9895
9896         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9897         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9898         * mdebugread.c (parse_partial_symbols): Use
9899         allocate_dependencies.
9900         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9901         allocate_dependencies.
9902         (process_psymtab_comp_unit_reader)
9903         (build_type_psymtab_dependencies): Likewise.
9904         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9905
9906 2019-01-10  Tom Tromey  <tom@tromey.com>
9907
9908         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9909         PSYMBOL_SET_LANGUAGE.
9910         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9911
9912 2019-01-10  Tom Tromey  <tom@tromey.com>
9913
9914         * psymtab.h (psymtab_storage::obstack): New method.
9915         <m_obstack>: Rename from obstack; now private.
9916         * psymtab.c (psymtab_storage): Update.
9917         * dwarf2read.c (create_addrmap_from_index)
9918         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9919         Update.
9920
9921 2019-01-10  Tom Tromey  <tom@tromey.com>
9922
9923         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9924         * objfiles.h (objfile::reset_psymtabs): New method.
9925
9926 2019-01-10  Tom Tromey  <tom@tromey.com>
9927
9928         * symmisc.c (print_symbol_bcache_statistics): Update.
9929         (print_objfile_statistics): Update.
9930         * symfile.c (reread_symbols): Update.
9931         * psymtab.h (class psymtab_storage): New.
9932         * psymtab.c (psymtab_storage): New constructor.
9933         (~psymtab_storage): New destructor.
9934         (require_partial_symbols): Update.
9935         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9936         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9937         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9938         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9939         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9940         (start_psymtab_common, end_psymtab_common)
9941         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9942         (allocate_psymtab): Update.
9943         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9944         Update.
9945         (dump_psymtab_addrmap, maintenance_print_psymbols)
9946         (maintenance_check_psymtabs): Update.
9947         (class objfile_psymtabs): Move to objfiles.h.
9948         * psympriv.h (discard_psymtab): Now inline.
9949         (psymtab_discarder::psymtab_discarder): Update.
9950         (psymtab_discarder::~psymtab_discarder): Update.
9951         (ALL_OBJFILE_PSYMTABS): Rewrite.
9952         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9953         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9954         Remove fields.
9955         <partial_symtabs>: New field.
9956         (class objfile_psymtabs): Move from psymtab.h.  Update.
9957         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9958         psymbol_cache.
9959         (objfile::~objfile): Don't destroy psymbol_cache.
9960         * mdebugread.c (parse_partial_symbols): Update.
9961         * dwarf2read.c (create_addrmap_from_index)
9962         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9963         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9964         (add_partial_subprogram, dwarf2_ranges_read): Update.
9965         * dwarf-index-write.c (write_address_map)
9966         (write_one_signatured_type, recursively_write_psymbols)
9967         (class debug_names, class debug_names, write_psymtabs_to_index):
9968         Update.
9969
9970 2019-01-10  Tom Tromey  <tom@tromey.com>
9971
9972         * symtab.h (SYMBOL_SET_NAMES): Update.
9973         (symbol_set_names): Update.
9974         (MSYMBOL_SET_NAMES): Update.
9975         * symtab.c (symbol_set_names): Change argument to be an
9976         objfile_per_bfd_storage.
9977         * psymtab.c (add_psymbol_to_bcache): Update.
9978         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9979
9980 2019-01-10  Tom Tromey  <tom@tromey.com>
9981
9982         * symtab.c (create_demangled_names_hash): Change argument to be an
9983         objfile_per_bfd_storage.
9984         (symbol_set_names): Update.
9985
9986 2019-01-10  Tom Tromey  <tom@tromey.com>
9987
9988         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9989         init_psymbol_list.
9990         * psymtab.c (init_psymbol_list): Do nothing if already called.
9991         * psympriv.h (init_psymbol_list): Add comment.
9992         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9993         init_psymbol_list.
9994         * dbxread.c (dbx_symfile_read): Unconditionally call
9995         init_psymbol_list.
9996
9997 2019-01-10  Tom Tromey  <tom@tromey.com>
9998
9999         * xcoffread.c (scan_xcoff_symtab): Update.
10000         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10001         "where".
10002         * mdebugread.c (parse_partial_symbols)
10003         (handle_psymbol_enumerators): Update.
10004         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10005         * dbxread.c (read_dbx_symtab): Update.
10006         * psympriv.h (psymbol_placement): New enum.
10007         (add_psymbol_to_list): Update.
10008
10009 2019-01-10  Tom Tromey  <tom@tromey.com>
10010
10011         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10012         static_psymbols parameters.
10013         (scan_xcoff_symtab): Update.
10014         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10015         static_psymbols parameters.
10016         * psympriv.h (start_psymtab_common): Update.
10017         * mdebugread.c (parse_partial_symbols): Update.
10018         * dwarf2read.c (create_partial_symtab): Update.
10019         * dbxread.c (read_dbx_symtab): Update.
10020         (start_psymtab): Remove global_psymbols and static_psymbols
10021         parameters.
10022
10023 2019-01-10  Tom Tromey  <tom@tromey.com>
10024
10025         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10026         * psymtab.c (allocate_psymtab): Add comment.
10027         * psympriv.h (allocate_psymtab): Add comment.
10028         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10029         initializations.
10030         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10031
10032 2019-01-10  Tom Tromey  <tom@tromey.com>
10033
10034         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10035         Don't declare.
10036         * mipsread.c: Include mdebugread.h.
10037         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10038         Declare.
10039         * elfread.c: Include mdebugread.h.
10040
10041 2019-01-09  Tom Tromey  <tom@tromey.com>
10042
10043         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10044         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10045         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10046         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10047         (psym_lookup_symbol, psym_find_last_source_symtab)
10048         (psym_forget_cached_source_info, psym_print_stats)
10049         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10050         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10051         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10052         (psym_find_compunit_symtab_by_address)
10053         (maintenance_print_psymbols, maintenance_info_psymtabs)
10054         (maintenance_check_psymtabs): Use ranged for.
10055         * psymtab.h (class objfile_psymtabs): New.
10056         (require_partial_symbols): Return objfile_psymtabs.
10057         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10058
10059 2019-01-09  Tom Tromey  <tom@tromey.com>
10060
10061         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10062         (find_pc_mapped_section, list_overlays_command)
10063         (map_overlay_command, unmap_overlay_command)
10064         (simple_overlay_update): Use all_objfiles.
10065         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10066         * printcmd.c (info_symbol_command): Use all_objfiles.
10067         * objfiles.h (ALL_OBJSECTIONS): Remove.
10068         * maint.c (maintenance_translate_address): Use all_objfiles.
10069         * gcore.c (gcore_create_callback): Use all_objfiles.
10070         (objfile_find_memory_regions): Likewise.
10071
10072 2019-01-09  Tom Tromey  <tom@tromey.com>
10073
10074         * symtab.c (find_line_symtab, info_sources_command)
10075         (make_source_files_completion_list): Use objfile_compunits.
10076         * source.c (select_source_symtab): Use objfile_compunits.
10077         * objfiles.h (struct objfile): Update comment.
10078         (ALL_OBJFILES): Remove.
10079         (ALL_FILETABS): Remove.
10080         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10081         objfile_compunits.
10082
10083 2019-01-09  Tom Tromey  <tom@tromey.com>
10084
10085         * symmisc.c (print_objfile_statistics, dump_objfile)
10086         (maintenance_print_symbols): Use compunit_filetabs.
10087         * source.c (forget_cached_source_info_for_objfile): Use
10088         compunit_filetabs.
10089         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10090         (ALL_FILETABS): Use compunit_filetabs.
10091         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10092         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10093
10094 2019-01-09  Tom Tromey  <tom@tromey.com>
10095
10096         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10097         (compunit_filetabs): New.
10098         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10099         compunit_filetabs.
10100         (info_sources_command, make_source_files_completion_list): Remove
10101         declaration.
10102         * symmisc.c (print_objfile_statistics, dump_objfile)
10103         (maintenance_print_symbols): Remove declaration.
10104         (maintenance_info_symtabs): Use compunit_filetabs.
10105         (maintenance_info_line_tables): Likewise.
10106         * source.c (select_source_symtab): Change local variable name.
10107         (forget_cached_source_info_for_objfile): Remove declaration.
10108         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10109         * objfiles.c (objfile_relocate1): Remove declaration.
10110         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10111         declaration.
10112         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10113         * coffread.c (coff_symtab_read): Remove declaration.
10114         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10115         compunit_filetabs.
10116
10117 2019-01-09  Tom Tromey  <tom@tromey.com>
10118
10119         * symtab.c (lookup_objfile_from_block)
10120         (find_pc_sect_compunit_symtab, search_symbols)
10121         (default_collect_symbol_completion_matches_break_on): Use
10122         objfile_compunits.
10123         * objfiles.h (ALL_COMPUNITS): Remove.
10124         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10125         * cp-support.c (add_symbol_overload_list_qualified): Use
10126         objfile_compunits.
10127         * ada-lang.c (ada_collect_symbol_completion_matches)
10128         (ada_add_global_exceptions): Use objfile_compunits.
10129
10130 2019-01-09  Tom Tromey  <tom@tromey.com>
10131
10132         * source.c (select_source_symtab)
10133         (forget_cached_source_info_for_objfile): Remove declaration.
10134         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10135         declaration.
10136         * maint.c (count_symtabs_and_blocks): Remove declaration.
10137         * cp-support.c (add_symbol_overload_list_qualified): Remove
10138         declaration.
10139         * coffread.c (coff_symtab_read): Remove declaration.
10140         * symtab.c (lookup_symbol_in_objfile_symtabs)
10141         (basic_lookup_transparent_type_1): Use objfile_compunits.
10142         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10143         (info_sources_command, search_symbols)
10144         (default_collect_symbol_completion_matches_break_on)
10145         (make_source_files_completion_list): Remove declaration.
10146         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10147         (ada_collect_symbol_completion_matches)
10148         (ada_add_global_exceptions): Remove declaration.
10149         * linespec.c (iterate_over_all_matching_symtabs): Use
10150         objfile_compunits.
10151         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10152         (class objfile_compunits): New.
10153         (ALL_COMPUNITS): Use objfile_compunits.
10154         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10155         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10156         objfile_compunits.
10157         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10158
10159 2019-01-09  Tom Tromey  <tom@tromey.com>
10160
10161         * symtab.c (search_symbols)
10162         (default_collect_symbol_completion_matches_break_on): Use
10163         objfile_msymbols.
10164         * ada-lang.c (ada_lookup_simple_minsym)
10165         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10166         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10167         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10168         objfile_msymbols.
10169         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10170         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10171         * objc-lang.c (find_methods): Use objfile_msymbols.
10172         (info_selectors_command, info_classes_command): Likewise.
10173         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10174         * objfiles.h (class objfile_msymbols): New.
10175         (ALL_OBJFILE_MSYMBOLS): Remove.
10176         (ALL_MSYMBOLS): Remove.
10177
10178 2019-01-09  Tom Tromey  <tom@tromey.com>
10179
10180         * common/next-iterator.h (next_adapter): Add Iterator template
10181         parameter.
10182         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10183         (class all_objfiles_safe): New.
10184         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10185         * objfiles.c (put_objfile_before): Update comment.
10186         (add_separate_debug_objfile): Likewise.
10187         (free_all_objfiles): Use all_objfiles_safe.
10188         (objfile_purge_solibs): Likewise.
10189
10190 2019-01-09  Tom Tromey  <tom@tromey.com>
10191
10192         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10193         (expand_symtab_containing_pc, lookup_static_symbol)
10194         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10195         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10196         all_objfiles.
10197         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10198         * breakpoint.c (create_overlay_event_breakpoint)
10199         (create_longjmp_master_breakpoint)
10200         (create_std_terminate_master_breakpoint)
10201         (create_exception_master_breakpoint): Use all_objfiles.
10202         * linux-thread-db.c (try_thread_db_load_from_pdir)
10203         (has_libpthread): Use all_objfiles.
10204         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10205         * linespec.c (iterate_over_all_matching_symtabs)
10206         (search_minsyms_for_name): Use all_objfiles.
10207         * maint.c (maintenance_info_sections): Use all_objfiles.
10208         * main.c (captured_main_1): Use all_objfiles.
10209         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10210         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10211         * guile/scm-pretty-print.c
10212         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10213         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10214         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10215         (maintenance_print_msymbols): Use all_objfiles.
10216         * source.c (select_source_symtab): Use all_objfiles.
10217         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10218         * symfile.c (remove_symbol_file_command)
10219         (expand_symtabs_matching, map_symbol_filenames): Use
10220         all_objfiles.
10221         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10222         all_objfiles.
10223         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10224         * objc-lang.c (find_methods): Use all_objfiles.
10225         * objfiles.c (have_partial_symbols, have_full_symbols)
10226         (have_minimal_symbols, qsort_cmp)
10227         (default_iterate_over_objfiles_in_search_order): Use
10228         all_objfiles.
10229         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10230         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10231         (maintenance_check_psymtabs): Use all_objfiles.
10232         (ALL_PSYMTABS): Remove.
10233         * compile/compile-object-run.c (do_module_cleanup): Use
10234         all_objfiles.
10235         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10236         * cp-support.c (add_symbol_overload_list_qualified): Use
10237         all_objfiles.
10238         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10239         Use all_objfiles.
10240         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10241         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10242         all_objfiles.
10243         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10244         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10245         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10246         Uses all_objfiles.
10247         * solib.c (solib_read_symbols): Use all_objfiles
10248
10249 2019-01-09  Tom Tromey  <tom@tromey.com>
10250
10251         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10252         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10253         all_objfiles.
10254         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10255         * symmisc.c (print_symbol_bcache_statistics)
10256         (print_objfile_statistics, maintenance_print_objfiles)
10257         (maintenance_info_symtabs, maintenance_check_symtabs)
10258         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10259         all_objfiles.
10260         * source.c (forget_cached_source_info): Use all_objfiles.
10261         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10262         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10263         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10264         * objfiles.c (update_section_map): Use all_objfiles.
10265         (shared_objfile_contains_address_p): Likewise.
10266         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10267         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10268
10269 2019-01-09  Tom Tromey  <tom@tromey.com>
10270
10271         * common/next-iterator.h: New file.
10272         * objfiles.h (class all_objfiles): New.
10273         (struct objfile_iterator): New.
10274
10275 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10276
10277         * NEWS: Move the description of the changed "frame", "select-frame",
10278          and "info frame" commands to the Changed commands section.
10279
10280 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10281
10282         * gdbtypes.c (check_stub_method_group): Remove handling of old
10283         mangling schemes.
10284         * linespec.c (find_methods): Likewise.
10285         * stabsread.c (read_member_functions): Likewise.
10286         * valops.c (search_struct_method): Likewise.
10287         (value_struct_elt_for_reference): Likewise.
10288         * NEWS: Mention this change.
10289
10290 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10291
10292         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10293         print_source_lines.
10294         * source.c (print_source_lines_base): Update line number check.
10295         (print_source_lines): New function.
10296         (source_lines_range::source_lines_range): New function.
10297         * source.h (class source_lines_range): New class.
10298         (print_source_lines): New declaration.
10299
10300 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10301
10302         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10303
10304 2019-01-08  Tom Tromey  <tom@tromey.com>
10305             Simon Marchi  <simon.marchi@ericsson.com>
10306
10307         PR gdb/24060
10308         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10309         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10310         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10311         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10312         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10313         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10314
10315 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10316
10317         * source.c (select_source_symtab): Move header comment to
10318         declaration in source.h.
10319         (forget_cached_source_info_for_objfile): Likewise.
10320         (forget_cached_source_info): Likewise.
10321         (identify_source_line): Likewise.
10322         * source.h (identify_source_line): Move declaration from symtab.h
10323         and add comment from source.c
10324         (print_source_lines): Likewise.
10325         (forget_cached_source_info_for_objfile): Likewise.
10326         (forget_cached_source_info): Likewise.
10327         (select_source_symtab): Likewise.
10328         (enum print_source_lines_flag): Move definition from symtab.h.
10329         * symtab.h (identify_source_line): Move declaration to source.h.
10330         (print_source_lines): Likewise.
10331         (forget_cached_source_info_for_objfile): Likewise.
10332         (forget_cached_source_info): Likewise.
10333         (select_source_symtab): Likewise.
10334         (enum print_source_lines_flag): Move definition to source.h.
10335         * tui/tui-hooks.c: Add 'source.h' include.
10336
10337 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10338
10339         * source.c (print_source_lines_base): Handle requests to print
10340         reverse line number sequences, and guard against empty lines
10341         string.
10342
10343 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10344
10345         * source.c (print_source_lines_base): Fix skip of '\r' if next
10346         character is '\n'.
10347
10348 2019-01-06  Tom Tromey  <tom@tromey.com>
10349
10350         * c-exp.y (struct c_parse_state) <macro_original_text,
10351         expansion_obstack>: New member.
10352         (macro_original_text, expansion_obstack): Remove globals.
10353         (scan_macro_expansion, scanning_macro_expansion)
10354         (finished_macro_expansion): Update.
10355         (scan_macro_cleanup): Remove.
10356         (yylex, c_parse): Update.
10357
10358 2019-01-06  Tom Tromey  <tom@tromey.com>
10359
10360         * c-exp.y (struct c_parse_state) <strings>: New member.
10361         (operator_stoken): Update.
10362
10363 2019-01-06  Tom Tromey  <tom@tromey.com>
10364
10365         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10366         (union type_stack_elt) <typelist_val>: Now a pointer to
10367         std::vector.
10368         (type_stack_cleanup): Don't declare.
10369         (push_typelist): Update.
10370         * parse.c (pop_typelist): Return a std::vector.
10371         (push_typelist): Take a std::vector.
10372         (follow_types): Update.  Do not free args.
10373         (type_stack_cleanup): Remove.
10374         * c-exp.y (struct c_parse_state): New.
10375         (cpstate): New global.
10376         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10377         (nonempty_typelist): Update.
10378         (func_mod): Create a new vector.
10379         (c_parse): Create a c_parse_state.
10380         (check_parameter_typelist): Do not delete params.
10381         (function_method): Update.  Do not delete type_list.
10382
10383 2019-01-06  Tom Tromey  <tom@tromey.com>
10384
10385         PR gdb/28155:
10386         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10387         check_typedef.
10388         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10389         (print_return_value): Likewise.
10390
10391 2019-01-05  Tom Tromey  <tom@tromey.com>
10392
10393         * contrib/cleanup_check.py: Remove.
10394         * contrib/gcc-with-excheck: Remove.
10395         * contrib/exsummary.py: Remove.
10396         * contrib/excheck.py: Remove.
10397
10398 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10399
10400         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10401         NULL. Initialize tpprev to NULL instead of assigning it
10402         to NULL on the next statement.
10403         * windows-nat.c (windows_delete_thread): Remove check for
10404         main_thread_id before printing thread exit notifications.
10405         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10406         Remove thread ID check against main_thread_id.
10407         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10408         windows_delete_thread.
10409         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10410
10411 2019-01-04  Tom Tromey  <tom@tromey.com>
10412
10413         * compile/compile.c (_initialize_compile): Use upper case for
10414         metasyntactic variables.
10415         * symmisc.c (_initialize_symmisc): Use upper case for
10416         metasyntactic variables.
10417         * psymtab.c (_initialize_psymtab): Use upper case for
10418         metasyntactic variables.
10419         * demangle.c (demangle_command): Use upper case for metasyntactic
10420         variables.
10421         (_initialize_demangler): Likewise.
10422         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10423         variables.
10424
10425 2019-01-03  Tom Tromey  <tom@tromey.com>
10426
10427         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10428
10429 2019-01-03  Tom Tromey  <tom@tromey.com>
10430
10431         * python/py-symtab.c (salpy_str): Update.
10432         (struct salpy_sal_object) <symtab>: Now a PyObject.
10433         (salpy_dealloc): Update.
10434         (del_objfile_sal): Use gdbpy_ref.
10435
10436 2019-01-03  Tom Tromey  <tom@tromey.com>
10437
10438         * python/py-type.c (convert_field): Use new_reference.  Return
10439         gdbpy_ref.
10440         (make_fielditem): Return gdbpy_ref.
10441         (typy_fields): Update.
10442         (typy_getitem): Update.
10443         (field_name): Return gdbpy_ref.  Use new_reference.
10444         (typy_iterator_iternext): Update.
10445
10446 2019-01-03  Tom Tromey  <tom@tromey.com>
10447
10448         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10449
10450 2019-01-03  Tom Tromey  <tom@tromey.com>
10451
10452         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10453         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10454         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10455         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10456         (pspy_set_type_printers): Likewise.
10457         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10458         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10459         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10460         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10461         (objfpy_set_type_printers): Likewise.
10462
10463 2019-01-03  Tom Tromey  <tom@tromey.com>
10464
10465         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10466         (gdbpy_print_stack): Use gdbpy_err_fetch.
10467         * python/python-internal.h (class gdbpy_err_fetch): New class.
10468         (class gdbpy_enter) <m_error_type, m_error_value,
10469         m_error_traceback>: Remove.
10470         <m_error>: New member.
10471         (gdbpy_exception_to_string): Don't declare.
10472         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10473         * python/py-value.c (convert_value_from_python): Use
10474         gdbpy_err_fetch.
10475         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10476         gdbpy_exception_to_string.
10477         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10478         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10479         gdbpy_err_fetch.
10480
10481 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10482
10483         * linux-nat.c (delete_lwp_cleanup): Delete.
10484         (struct lwp_deleter): New struct.
10485         (lwp_info_up): New typedef.
10486         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10487         lwp_info_up.
10488
10489 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10490
10491         * linux-fork.c (class scoped_switch_fork_info): New class.
10492         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10493
10494 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10495
10496         * valops.c (find_overload_match): Remove use of null_cleanup, and
10497         calls to do_cleanups.
10498
10499 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10500
10501         * compile/compile-cplus-types.c
10502         (compile_cplus_instance::decl_name): Handle changes to
10503         cp_func_name.
10504         * cp-support.c (cp_func_name): Update header comment, update
10505         return type.
10506         * cp-support.h (cp_func_name): Update return type in declaration.
10507         * valops.c (find_overload_match): Move temp_func local to top
10508         level of function and change its type.  Use temp_func to hold and
10509         delete temporary string obtained from cp_func_name.
10510
10511 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10512
10513         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10514         gdb::char_vector, remove cleanup, and update uses of `msg`.
10515
10516 2019-01-03  Jim Wilson  <jimw@sifive.com>
10517
10518         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10519
10520 2019-01-02  Tom Tromey  <tom@tromey.com>
10521
10522         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10523         (tdesc_parse_xml): Remove cleanups.
10524         * target-descriptions.h (make_cleanup_free_target_description):
10525         Don't declare.
10526         (target_desc_deleter): New struct.
10527         (target_desc_up): New typedef.
10528         * target-descriptions.c (target_desc_deleter::operator()): Rename
10529         from free_target_description.
10530         (make_cleanup_free_target_description): Remove.
10531
10532 2019-01-02  Tom Tromey  <tom@tromey.com>
10533
10534         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10535         constructor, destructor.
10536         (linespec_parser): Remove typedef.
10537         (~linespec_parser): Rename from linespec_parser_delete.
10538         (linespec_lex_to_end, linespec_complete_label)
10539         (linespec_complete): Update.
10540         (decode_line_full): Remove cleanups.
10541         (decode_line_1): Update.
10542
10543 2019-01-02  Tom Tromey  <tom@tromey.com>
10544
10545         * python/python-internal.h (inferior_to_inferior_object): Change
10546         return type.
10547         * python/py-exitedevent.c (create_exited_event_object): Update.
10548         * python/py-inferior.c (inferior_to_inferior_object): Return
10549         gdbpy_ref.
10550         (python_new_inferior, python_inferior_deleted)
10551         (thread_to_thread_object, delete_thread_object)
10552         (build_inferior_list, gdbpy_selected_inferior): Update.
10553         * python/py-infthread.c (create_thread_object): Update.  Also fail
10554         if inferior_to_inferior_object fails.
10555
10556 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10557
10558         * inferior.h (class inferior) <displaced_step_state>: New field.
10559         * infrun.h (struct displaced_step_state): Move here from
10560         infrun.c.  Initialize fields, add constructor.
10561         <inf>: Remove field.
10562         <reset>: New method.
10563         * infrun.c (struct displaced_step_inferior_state): Move to
10564         infrun.h.
10565         (displaced_step_inferior_states): Remove.
10566         (get_displaced_stepping_state): Adust.
10567         (displaced_step_in_progress_any_inferior): Adjust.
10568         (displaced_step_in_progress_thread): Adjust.
10569         (displaced_step_in_progress): Adjust.
10570         (add_displaced_stepping_state): Remove.
10571         (get_displaced_step_closure_by_addr): Adjust.
10572         (remove_displaced_stepping_state): Remove.
10573         (infrun_inferior_exit): Call displaced_step_state.reset.
10574         (use_displaced_stepping): Don't check for NULL.
10575         (displaced_step_prepare_throw): Call
10576         get_displaced_stepping_state.
10577         (displaced_step_fixup): Don't check for NULL.
10578         (prepare_for_detach): Don't check for NULL.
10579
10580 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10581
10582         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10583          in case of call that did not complete.
10584
10585 2019-01-02  Andrey Utkin  <autkin@undo.io>
10586
10587         * symfile.c (find_separate_debug_file): Fix search of debug files for
10588         remote debuggee.
10589
10590 2019-01-02  Tom Tromey  <tom@tromey.com>
10591
10592         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10593         indentation.
10594         * python/py-frame.c (frapy_older): Remove cast.
10595         (frapy_newer): Likewise.
10596         * python/py-breakpoint.c (local_setattro): Remove cast.
10597         * python/py-arch.c (archpy_name): Remove local variable.
10598         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10599
10600 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10601
10602         * unittests/basic_string_view/element_access/char/empty.cc:
10603         Fix year range in copyright header.
10604
10605 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10606
10607         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10608         Delete.
10609         <operator==>: Update with for removed field.
10610         <hash>: Likewise.
10611         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10612         <isa_features>: ...this.
10613         <abi_features>: New field.
10614         (riscv_isa_flen): Update comment.
10615         (riscv_abi_xlen): New declaration.
10616         (riscv_abi_flen): New declaration.
10617         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10618         isa_features.
10619         (riscv_abi_xlen): New function.
10620         (riscv_isa_flen): Update to get answer from isa_features.
10621         (riscv_abi_flen): New function.
10622         (riscv_has_fp_abi): Update to get answer from abi_features.
10623         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10624         xlen and flen.
10625         (riscv_call_info) <xlen, flen>: Update comment.
10626         (riscv_call_arg_struct): Remove invalid assertions
10627         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10628         is removed.
10629         (riscv_gdbarch_init): Gather isa features and abi features
10630         separately, ensure both match on the gdbarch when reusing an old
10631         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10632         a target with 64-bit float hardware.
10633
10634 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10635
10636         * source.c (search_command_helper): Stop reverse search
10637         when line 1 has been searched.
10638
10639 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10640
10641         * record-full.c (record_full_base_target::close): Rewrite
10642         record_full_core_buf_list free logic.
10643
10644 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10645
10646         * break-catch-syscall.c (print_one_catch_syscall): xfree
10647         the last text.
10648
10649 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10650
10651         * top.c (print_gdb_version): Update Copyright year in version
10652         message.
10653
10654 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10655
10656         Update copyright year range in all GDB files.
10657
10658 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10659
10660         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10661
10662 For older changes see ChangeLog-2018.
10663 \f
10664 Local Variables:
10665 mode: change-log
10666 left-margin: 8
10667 fill-column: 74
10668 version-control: never
10669 coding: utf-8
10670 End:
10671