gdb/ChangeLog

   1 2019-05-04  Tom Tromey  <tom@tromey.com>
   2
   3         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
   4         "false".
   5
   6 2019-05-04  Tom Tromey  <tom@tromey.com>
   7
   8         * arc-tdep.c (arc_tdesc_init): Use bool.
   9
  10 2019-05-04  Tom Tromey  <tom@tromey.com>
  11
  12         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
  13
  14 2019-05-04  Tom Tromey  <tom@tromey.com>
  15
  16         * cli/cli-cmds.c (valid_command_p): Return bool.
  17
  18 2019-05-04  Tom Tromey  <tom@tromey.com>
  19
  20         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
  21         * command.h (valid_user_defined_cmd_name_p): Channge return type.
  22
  23 2019-05-04  Raul Tambre  <raul@tambre.ee>
  24
  25         * python/lib/gdb/prompt.py (_ExtendedPrompt)
  26         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
  27         operator for comparison.
  28
  29 2019-05-04  Tom Tromey  <tom@tromey.com>
  30
  31         * psymtab.c (psymbol_name_matches, match_partial_symbol)
  32         (lookup_partial_symbol, print_partial_symbols)
  33         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
  34         (psymbol_compare): Update.
  35         (add_psymbol_to_bcache): Clear the entire psymbol.
  36         (maintenance_check_psymtabs): Update.
  37         * psympriv.h (struct partial_symbol): Don't derive from
  38         general_symbol_info.
  39         <obj_section, unrelocated_address, address,
  40         set_unrelocated_address>: Update.
  41         <ginfo>: New member.
  42         * dwarf-index-write.c (write_psymbols, debug_names::insert)
  43         (debug_names::write_psymbols): Update.
  44
  45 2019-05-04  Tom de Vries  <tdevries@suse.de>
  46
  47         * contrib/cc-with-tweaks.sh: Support -n arg.
  48
  49 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  50
  51         * corelow.c (core_target::detach): Ensure frame cache and
  52         register caches are cleared.
  53         inferior.c (exit_inferior_1): Likewise.
  54
  55 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
  56             Tom Tromey  <tom@tromey.com>
  57
  58         * dictionary.c (collate_pending_symbols_by_language): Remove
  59         "struct" from foreach.
  60         * symtab.c (lookup_global_symbol_from_objfile)
  61         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
  62         foreach.
  63         * ser-tcp.c (net_open): Remove "struct" from foreach.
  64         * objfiles.c (objfile_relocate, objfile_rebase)
  65         (objfile_has_symbols): Remove "struct" from foreach.
  66         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
  67         from foreach.
  68         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
  69         foreach.
  70         * darwin-nat.c (thread_info_from_private_thread_info): Remove
  71         "struct" from foreach.
  72         * ada-lang.c (create_excep_cond_exprs)
  73         (ada_exception_catchpoint_cond_string): Remove "struct" from
  74         foreach.
  75
  76 2019-05-03  Tom Tromey  <tromey@adacore.com>
  77
  78         * ada-exp.y (convert_char_literal): Check suffix of each
  79         enumerator.
  80
  81 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
  82
  83         PR ada/21406:
  84         * ada-exp.y (yywrap): Don't define.
  85         * ada-lex.l (%option): Add noyywrap
  86         (yywrap): Remove.
  87
  88 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
  89
  90         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
  91         _WIN32_WINNT to the XP level, unless already defined to a higher
  92         level.
  93
  94         * unittests/parse-connection-spec-selftests.c:
  95         * ser-tcp.c:
  96         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
  97         override.
  98
  99         * symfile.c (find_separate_debug_file): Remove colon from the
 100         drive spec of DOS/Windows file names of the target, so that the
 101         file name produced from DEBUGDIR and the target's directory will
 102         be valid on DOS/Windows systems.
 103
 104 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 105
 106         * rust-lang.c (val_print_struct): Handle printing structures
 107         containing strings.
 108
 109 2019-05-02  Tom Tromey  <tromey@adacore.com>
 110
 111         * valarith.c (_initialize_valarith): Remove.
 112
 113 2019-05-01  Tom Tromey  <tromey@adacore.com>
 114
 115         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 116         bitfields.
 117
 118 2019-05-01  Tom Tromey  <tromey@adacore.com>
 119
 120         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 121         for big-endian copies.
 122
 123 2019-04-30  Ali Tamur  <tamur@google.com>
 124         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 125         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 126         (read_3_bytes): New function.
 127
 128 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 129
 130         * windows-nat.c (main_thread_id): Delete.
 131         (handle_output_debug_string): Replace main_thread_id by
 132         current_event.dwThreadId.
 133         (fake_create_process): Likewise.
 134         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 135         Do not set main_thread_id.
 136         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 137         current_event.dwThreadId.
 138         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 139
 140 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 141
 142         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 143         Use current_event.dwThreadId instead of main_thread_id.
 144
 145 2019-04-30  Tom Tromey  <tromey@adacore.com>
 146
 147         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 148         (create_excep_cond_exprs): Iterate over program spaces.
 149         (ada_exception_catchpoint_cond_string): Examine all minimal
 150         symbols for exception types.
 151
 152 2019-04-30  Tom Tromey  <tromey@adacore.com>
 153
 154         PR c++/24470:
 155         * dwarf2read.c (process_structure_scope): Handle case where type
 156         has template parameters but no symbol was created.
 157
 158 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 159             Chris January  <chris.january@arm.com>
 160
 161         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 162         qualifier.
 163         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 164
 165 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 166
 167         * f-typeprint.c (f_print_type): Update rules for printing
 168         whitespace.
 169         (f_type_print_varspec_suffix): Likewise.
 170
 171 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 172             Chris January  <chris.january@arm.com>
 173
 174         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 175         function arguments.
 176
 177 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 178
 179         * f-lang.c (build_fortran_types): Change name of void type to
 180         lower case.
 181         * f-typeprint.c (f_type_print_base): Print the name of the void
 182         type, rather than a fixed string.
 183         * f-valprint.c (f_decorations): Use lower case void string.
 184
 185 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 186             Chris January  <chris.january@arm.com>
 187
 188         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 189         types for Fortran.
 190
 191 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 192             Chris January  <chris.january@arm.com>
 193             David Lecomber  <david.lecomber@arm.com>
 194
 195         * f-exp.y (BINOP_INTRINSIC): New token.
 196         (exp): New parser rule handling BINOP_INTRINSIC.
 197         (f77_keywords): Add new builtin procedures.
 198         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 199         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 200         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 201         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 202         (print_unop_subexp_f): New function.
 203         (print_binop_subexp_f): New function.
 204         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 205         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 206         (dump_subexp_body_f): Likewise.
 207         (operator_check_f): Likewise.
 208         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 209         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 210
 211 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 212
 213         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 214         UNOP_KIND.
 215         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 216         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 217         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 218         (operator_length_f): New fuction.
 219         (print_subexp_f): New function.
 220         (op_name_f): New function.
 221         (dump_subexp_body_f): New function.
 222         (operator_check_f): New function.
 223         (exp_descriptor_f): Replace standard expression handling functions
 224         with new functions.
 225         * gdb/fortran-operator.def: New file.
 226         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 227         * gdb/std-operator.def: Remove UNOP_KIND.
 228
 229 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 230
 231         * std-operator.def: Remove unbalanced, stray double quote
 232         character.
 233
 234 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 235             Chris January  <chris.january@arm.com>
 236             Daniel Everett  <daniel.everett@arm.com>
 237             Nick Forrington  <nick.forrington@arm.com>
 238             Richard Bunt  <richard.bunt@arm.com>
 239
 240         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 241         of depth when printing anonymous structs or unions.
 242         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 243         Don't print either the top-level value, or the children if the
 244         max-depth is exceeded.
 245         (ppscm_print_children): When printing the key of a map, allow one
 246         extra level of depth.
 247         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 248         print either the top-level value, or the children if the max-depth
 249         is exceeded.
 250         (print_children): When printing the key of a map, allow one extra
 251         level of depth.
 252         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 253         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 254         (user_print_options): Initialise max_depth field.
 255         (val_print_scalar_or_string_type_p): New function.
 256         (val_print): Check to see if the max depth has been reached.
 257         (val_print_check_max_depth): Define new function.
 258         (show_print_max_depth): New function.
 259         (_initialize_valprint): Add 'print max-depth' option.
 260         * valprint.h (struct value_print_options) <max_depth>: New field.
 261         (val_print_check_max_depth): Declare new function.
 262         * NEWS: Document new feature.
 263
 264 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 265
 266         * ada-lang.c (ada_language_defn): Initialise new field.
 267         * c-lang.c (c_is_string_type_p): New function.
 268         (c_language_defn): Initialise new field.
 269         (cplus_language_defn): Initialise new field.
 270         (asm_language_defn): Initialise new field.
 271         (minimal_language_defn): Initialise new field.
 272         * c-lang.h (c_is_string_type_p): Declare new function.
 273         * d-lang.c (d_language_defn): Initialise new field.
 274         * f-lang.c (f_is_string_type_p): New function.
 275         (f_language_defn): Initialise new field.
 276         * go-lang.c (go_is_string_type_p): New function.
 277         (go_language_defn): Initialise new field.
 278         * language.c (default_is_string_type_p): New function.
 279         (unknown_language_defn): Initialise new field.
 280         (auto_language_defn): Initialise new field.
 281         * language.h (struct language_defn) <la_is_string_type_p>: New
 282         member variable.
 283         (default_is_string_type_p): Declare new function.
 284         * m2-lang.c (m2_language_defn): Initialise new field.
 285         * objc-lang.c (objc_language_defn): Initialise new field.
 286         * opencl-lang.c (opencl_language_defn): Initialise new field.
 287         * p-lang.c (pascal_is_string_type_p): New function.
 288         (pascal_language_defn): Initialise new field.
 289         * rust-lang.c (rust_is_string_type_p): New function.
 290         (rust_language_defn): Initialise new field.
 291
 292 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 293
 294         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 295         New field.
 296         * ada-lang.c (ada_language_defn): Initialise new field.
 297         * c-lang.c (c_language_defn): Likewise.
 298         (cplus_language_defn): Likewise.
 299         (asm_language_defn): Likewise.
 300         (minimal_language_defn): Likewise.
 301         * d-lang.c (d_language_defn): Likewise.
 302         * f-lang.c (f_language_defn): Likewise.
 303         * go-lang.c (go_language_defn): Likewise.
 304         * language.c (unknown_language_defn): Likewise.
 305         (auto_language_defn): Likewise.
 306         * m2-lang.c (m2_language_defn): Likewise.
 307         * objc-lang.c (objc_language_defn): Likewise.
 308         * opencl-lang.c (opencl_language_defn): Likewise.
 309         * p-lang.c (pascal_language_defn): Likewise.
 310         * rust-lang.c (rust_language_defn): Likewise.
 311
 312 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 313
 314         * ada-lang.c (ada_is_character_type): Change return type to bool.
 315         (ada_is_string_type): Likewise.
 316         * ada-lang.h (ada_is_character_type): Update declaration
 317         (ada_is_string_type): Likewise.
 318
 319 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 320
 321         Support style in 'frame|thread apply'
 322
 323         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 324         * record.c (record_start, record_stop): Update callers of
 325         execute_command_to_string with false.
 326         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 327         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 328         methods.
 329         (class string_file): New constructor with term_out parameter.
 330         Override methods term_out and can_emit_style_escape.  New member
 331         term_out.
 332         (class stdio_file): Override can_emit_style_escape.
 333         (class tee_file): Override term_out and can_emit_style_escape.
 334         * utils.h (can_emit_style_escape): Remove.
 335         * utils.c (can_emit_style_escape): Likewise.
 336         Update all callers of can_emit_style_escape (SOMESTREAM) to
 337         SOMESTREAM->can_emit_style_escape.
 338         * source-cache.c (source_cache::get_source_lines): Likewise.
 339         * stack.c (frame_apply_command_count): Call execute_command_to_string
 340         passing the term_out characteristic of the current gdb_stdout.
 341         * thread.c (thr_try_catch_cmd): Likewise.
 342         * top.c (execute_command_to_string): pass term_out parameter
 343         to construct the string_file for the command output.
 344         * ui-file.c (term_cli_styling): New function (most code moved
 345         from utils.c can_emit_style_escape).
 346         (string_file::string_file, string_file::can_emit_style_escape,
 347         stdio_file::can_emit_style_escape, tee_file::term_out,
 348         tee_file::can_emit_style_escape): New functions.
 349
 350 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 351
 352         * NEWS: Mention the new set|show may-call-functions.
 353         * infcall.c (may_call_functions_p): New variable.
 354         (show_may_call_functions_p): New function.
 355         (call_function_by_hand_dummy): Throws an error if not
 356         may-call-functions.
 357         (_initialize_infcall): Call add_setshow_boolean_cmd for
 358         may-call-functions.
 359
 360 2019-04-25  Keith Seitz  <keiths@redhat.com>
 361
 362         PR c++/24367
 363         * cp-support.c (inspect_type): Don't attempt substitutions
 364         of symbol with the same name.
 365
 366 2019-04-25  Tom Tromey  <tromey@adacore.com>
 367
 368         PR gdb/24475:
 369         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 370         static.
 371
 372 2019-04-25  Tom Tromey  <tromey@adacore.com>
 373
 374         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 375         rvalue reference.
 376         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 377         (gdb_xml_parser::parse): Use std::move.
 378         * python/python-internal.h (gdbpy_convert_exception): Take a const
 379         reference.
 380         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 381         std::move.
 382         * python/py-utils.c (gdbpy_convert_exception): Take a const
 383         reference.
 384         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 385         Use std::move.
 386         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 387         Use std::move.
 388         * mi/mi-main.c (mi_print_exception): Take a const reference.
 389         * main.c (handle_command_errors): Take a const reference.
 390         * linespec.c (parse_linespec): Use std::move.
 391         * infcall.c (run_inferior_call): Use std::move.
 392         (call_function_by_hand_dummy): Use std::move.
 393         * exec.c (try_open_exec_file): Use std::move.
 394         * exceptions.h (exception_print, exception_fprintf)
 395         (exception_print_same): Update.
 396         * exceptions.c (print_exception, exception_print)
 397         (exception_fprintf, exception_print_same): Change parameters to
 398         const reference.
 399         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 400         * common/new-op.c: Use std::move.
 401         * common/common-exceptions.h (struct gdb_exception): Add move
 402         constructor.
 403         (struct gdb_exception_error, struct gdb_exception_quit, struct
 404         gdb_quit_bad_alloc): Change constructor to move constructor.
 405         (throw_exception): Change parameter to rvalue reference.
 406         * common/common-exceptions.c (throw_exception): Take rvalue
 407         reference.
 408         * cli/cli-interp.c (safe_execute_command): Use std::move.
 409         * breakpoint.c (insert_bp_location, location_to_sals): Use
 410         std::move.
 411
 412 2019-04-25  Tom Tromey  <tromey@adacore.com>
 413
 414         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 415         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 416         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 417         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 418         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 419         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 420         guile/scm-value.c: Use unpack.
 421         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 422         gdbscm_gdb_exception.
 423         (gdbscm_throw_gdb_exception): Likewise.
 424         (struct gdbscm_gdb_exception): New.
 425         (unpack): New function.
 426         (gdbscm_wrap): Use unpack.
 427
 428 2019-04-25  Tom Tromey  <tromey@adacore.com>
 429
 430         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 431         (gdb_rl_callback_handler): Use std::move.
 432         * common/common-exceptions.h (struct gdb_exception): Add move
 433         assignment operator.
 434         (throw_exception_sjlj): Change "exception" to const reference.
 435         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 436         (throw_exception_sjlj): Change "exception" to const reference.
 437
 438 2019-04-25  Tom Tromey  <tromey@adacore.com>
 439
 440         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 441         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 442         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 443         Update.
 444         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 445         Update.
 446         * mi/mi-interp.c (mi_interp::exec): Update.
 447         * linespec.c (parse_linespec): Update.
 448         * infcall.c (run_inferior_call): Update.
 449         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 450         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 451         (gdbscm_lookup_global_symbol): Update.
 452         * guile/scm-param.c (gdbscm_parameter_value): Update.
 453         * guile/scm-frame.c (gdbscm_frame_read_register)
 454         (gdbscm_frame_read_var): Update.
 455         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 456         * exec.c (try_open_exec_file): Update.
 457         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 458         (gdb_rl_callback_handler): Update.
 459         * common/common-exceptions.h (exception_none): Don't declare.
 460         * common/common-exceptions.c (exception_none): Don't define.
 461         (struct catcher) <exception>: Update.
 462         * cli/cli-interp.c (safe_execute_command): Update.
 463         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 464
 465 2019-04-25  Ali Tamur  <tamur@google.com>
 466
 467         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 468         (read_attribute_value): Likewise.
 469         (dwarf2_read_addr_index): Update comment.
 470         (read_str_index): Add DW_FORM_strx.
 471         (dwarf2_string_attr): Likewise.
 472         (dwarf2_const_value_attr): Likewise.
 473         (dump_die_shallow): Likewise.
 474         (dwarf2_fetch_constant_bytes): Likewise.
 475         (skip_form_bytes): Likewise.
 476         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 477
 478 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 479
 480         PR corefiles/11608
 481         PR corefiles/18187
 482         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 483         OFFSET.  Verify if current mapping contains an ELF header.
 484         (linux_find_memory_regions_full): Adjust call to
 485         dump_mapping_p.
 486
 487 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 488             Kang Li <kanglictf@gmail.com>
 489
 490         PR gdb/21600
 491
 492         * dwarf2-frame.c (read_initial_length): Be consistent about using
 493         unsigned representation of length.
 494         (decode_frame_entry_1): Likewise.  Check for wraparound of
 495         end pointer as well as buffer overflow.
 496
 497 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 498
 499         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 500         "vq".
 501
 502 2019-04-24  Tom Tromey  <tromey@adacore.com>
 503
 504         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 505
 506 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 507
 508         * s12z-tdep.c (s12z_unwind_pc): Delete.
 509         (s12z_unwind_sp): Delete.
 510         (s12z_gdbarch_init): Don't register deleted functions with
 511         gdbarch.
 512
 513 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 514
 515         * rl78-tdep.c (rl78_unwind_sp): Delete.
 516         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 517
 518 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 519
 520         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 521         (xstormy16_unwind_pc): Delete.
 522         (xstormy16_dummy_id): Delete.
 523         (xstormy16_gdbarch_init): Don't register deleted functions with
 524         gdbarch.
 525
 526 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 527
 528         * vax-tdep.c (vax_unwind_pc): Delete.
 529         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 530
 531 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 532
 533         * v850-tdep.c (v850_unwind_sp): Delete.
 534         (v850_unwind_pc): Delete.
 535         (v850_dummy_id): Delete.
 536         (v850_gdbarch_init): Don't register deleted functions with
 537         gdbarch.
 538
 539 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 540
 541         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 542         (tilegx_unwind_pc): Delete.
 543         (tilegx_unwind_dummy_id): Delete.
 544         (tilegx_gdbarch_init): Don't register deleted functions with
 545         gdbarch.
 546
 547 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 548
 549         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 550         (tic6x_dummy_id): Delete.
 551         (tic6x_gdbarch_init): Don't register deleted functions with
 552         gdbarch.
 553
 554 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 555
 556         * sparc-tdep.c (sparc_unwind_pc): Delete.
 557         (sparc32_gdbarch_init): Don't register deleted function with
 558         gdbarch.
 559
 560 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 561
 562         * sh-tdep.c (sh_unwind_sp): Delete.
 563         (sh_unwind_pc): Delete.
 564         (sh_dummy_id): Delete.
 565         (sh_gdbarch_init): Don't register deleted functions with
 566         gdbarch.
 567
 568 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 569
 570         * score-tdep.c (score_unwind_sp): Delete.
 571         (score_unwind_pc): Delete.
 572         (score_dummy_id): Delete.
 573         (score_gdbarch_init): Don't register deleted functions with
 574         gdbarch.
 575
 576 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 577
 578         * rx-tdep.c (rx_unwind_pc): Delete.
 579         (rx_unwind_sp): Delete.
 580         (rx_dummy_id): Delete.
 581         (rx_gdbarch_init): Don't register deleted functions with
 582         gdbarch.  Update comment.
 583
 584 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 585
 586         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 587         (rs6000_dummy_id): Delete.
 588         (rs6000_gdbarch_init): Don't register deleted functions with
 589         gdbarch.
 590
 591 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 592
 593         * or1k-tdep.c (or1k_dummy_id): Delete.
 594         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 595
 596 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 597
 598         * nios2-tdep.c (nios2_dummy_id): Delete.
 599         (nios2_unwind_sp): Delete.
 600         (nios2_gdbarch_init): Don't register deleted functions with
 601         gdbarch.
 602
 603 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 604
 605         * nds32-tdep.c (nds32_dummy_id): Delete.
 606         (nds32_unwind_pc): Delete.
 607         (nds32_unwind_sp): Delete.
 608         (nds32_gdbarch_init): Don't register deleted functions with
 609         gdbarch.
 610
 611 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 612
 613         * msp430-tdep.c (msp430_unwind_pc): Delete.
 614         (msp430_unwind_sp): Delete.
 615         (msp430_dummy_id): Delete.
 616         (msp430_gdbarch_init): Don't register deleted functions with
 617         gdbarch.
 618
 619 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 620
 621         * moxie-tdep.c (moxie_unwind_sp): Delete.
 622         (moxie_unwind_pc): Delete.
 623         (moxie_dummy_id): Delete.
 624         (moxie_gdbarch_init): Don't register deleted functions with
 625         gdbarch.
 626
 627 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 628
 629         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 630         (mn10300_unwind_pc): Delete.
 631         (mn10300_unwind_sp): Delete.
 632         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 633         mn10300_unwind_sp.
 634         (mn10300_frame_unwind_init): Don't register deleted functions with
 635         gdbarch.
 636
 637 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 638
 639         * mep-tdep.c (mep_unwind_pc): Delete.
 640         (mep_unwind_sp): Delete.
 641         (mep_dummy_id): Delete.
 642         (mep_gdbarch_init): Don't register deleted functions with
 643         gdbarch.
 644
 645 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 646
 647         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 648         (m68hc11_unwind_sp): Delete.
 649         (m68hc11_gdbarch_init): Don't register deleted functions with
 650         gdbarch.
 651
 652 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 653
 654         * m32r-tdep.c (m32r_unwind_sp): Delete.
 655         (m32r_unwind_pc): Delete.
 656         (m32r_dummy_id): Delete.
 657         (m32r_gdbarch_init): Don't register deleted functions with
 658         gdbarch.
 659
 660 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 661
 662         * m32c-tdep.c (m32c_unwind_pc): Delete.
 663         (m32c_unwind_sp): Delete.
 664         (m32c_dummy_id): Delete.
 665         (m32c_gdbarch_init): Don't register deleted functions with
 666         gdbarch.
 667
 668 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 669
 670         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 671         (lm32_unwind_pc): Delete.
 672         (lm32_dummy_id): Delete.
 673         (lm32_gdbarch_init): Don't register deleted functions with
 674         gdbarch.
 675
 676 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 677
 678         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 679         (iq2000_unwind_pc): Delete.
 680         (iq2000_dummy_id): Delete.
 681         (iq2000_gdbarch_init): Don't register deleted functions with
 682         gdbarch.
 683
 684 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 685
 686         * nds32-tdep.c (nds32_type_align): Delete.
 687         (nds32_push_dummy_call): Use type_align instead.
 688
 689 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 690
 691         * arm-tdep.c (arm_type_align): Only handle vector override case.
 692         (arm_push_dummy_call): Use type_align.
 693         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 694
 695 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 696
 697         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 698         case.
 699         (pass_on_stack): Use type_align.
 700         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 701         function.
 702
 703 2019-04-23  Tom Tromey  <tromey@adacore.com>
 704
 705         * dwarf2read.c (line_header::file_name_at): Remove unused
 706         overload.
 707
 708 2019-04-23  Tom de Vries  <tdevries@suse.de>
 709
 710         PR gdb/24438
 711         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 712         invocation.
 713
 714
 715 2019-03-27  Ali Tamur  <tamur@google.com>
 716
 717         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 718         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 719         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 720         (dwarf_expr_context::get_addr_index): Likewise
 721         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 722         (symbol_needs_eval_context::get_addr_index): Likewise
 723         (disassemble_dwarf_expression): Add DW_OP_addrx
 724         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 725         (read_cutu_die_from_dwo): Update comment
 726         (skip_one_die): Add DW_FORM_addrx
 727         (read_attribute_value): Likewise
 728         (var_decode_location): Add DW_OP_addrx
 729         (dwarf2_const_value_attr): Add DW_FORM_addrx
 730         (dump_die_shallow): Likewise
 731         (dwarf2_fetch_constant_bytes): Likewise
 732         (decode_locdesc): Add DW_OP_addrx
 733         (skip_form_bytes): Add DW_FORM_addrx
 734
 735 2019-04-22  Ali Tamur  <tamur@google.com>
 736
 737         * MAINTAINERS (Write After Approval): Add self.
 738
 739 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 740
 741         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 742         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 743         (open_symbol_file_object): Likewise.
 744         (svr4_default_sos): Add info parameter.
 745         (svr4_read_so_list): Likewise.
 746         (svr4_current_sos_direct): Adjust functions calls to pass down
 747         info.
 748         (svr4_current_sos_1): Add info parameter.
 749         (svr4_current_sos): Call get_svr4_info, pass info down to
 750         svr4_current_sos_1.
 751         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 752         get_svr4_info.
 753         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 754         get_svr4_info.
 755         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 756         to get_svr4_info.
 757         (probes_table_remove_objfile_probes): Likewise.
 758         (register_solib_event_probe): Add info parameter.
 759         (solist_update_incremental): Pass info parameter down to
 760         svr4_read_so_list.
 761         (disable_probes_interface): Add info parameter.
 762         (svr4_handle_solib_event): Pass current_program_space to
 763         get_svr4_info.  Adjust disable_probes_interface cleanup.
 764         (svr4_create_probe_breakpoints): Add info parameter, pass it
 765         down to register_solib_event_probe.
 766         (svr4_create_solib_event_breakpoints): Add info parameter,
 767         pass it down to svr4_create_probe_breakpoints.
 768         (enable_break): Pass info down to
 769         svr4_create_solib_event_breakpoints.
 770         (svr4_solib_create_inferior_hook): Pass current_program_space to
 771         get_svr4_info.
 772         (svr4_clear_solib): Likewise.
 773
 774 2019-04-22  Pedro Alves  <palves@redhat.com>
 775
 776         * solib-svr4.c (svr4_free_objfile_observer): New.
 777         (probe_and_action::objfile): New field.
 778         (probes_table_htab_remove_objfile_probes)
 779         (probes_table_remove_objfile_probes): New functions.
 780         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 781         in the new probe_and_action.  Don't store the probe in 'lookup'.
 782         (svr4_create_probe_breakpoints): Pass objfile to
 783         register_solib_event_probe.
 784         (_initialize_svr4_solib): Register a free_objfile observer.
 785
 786 2019-04-19  Tom Tromey  <tom@tromey.com>
 787
 788         * common/queue.h: Remove.
 789
 790 2019-04-19  Tom Tromey  <tom@tromey.com>
 791
 792         * event-loop.c: Don't include "common/queue.h".
 793
 794 2019-04-19  Tom Tromey  <tom@tromey.com>
 795
 796         * remote.c (remote_target): Use delete.
 797         * remote-notif.h: Include <list>, not "common/queue.h".
 798         (notif_client_p): Remove typedef.
 799         (remote_notif_state): Add constructor, destructor, initializer.
 800         <notif_queue>: Now a std::list.
 801         (remote_notif_state_xfree): Don't declare.
 802         * remote-notif.c (remote_notif_process, handle_notification)
 803         (remote_notif_state_allocate): Update.
 804         (~remote_notif_state): Rename from remote_notif_state_xfree.
 805
 806 2019-04-19  Tom Tromey  <tom@tromey.com>
 807
 808         * symfile.c (reread_symbols): Update.
 809         * objfiles.c (objfile_register_static_link)
 810         (objfile_lookup_static_link): Update
 811         (~objfile) Don't delete static_links.
 812         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 813
 814 2019-04-19  Tom Tromey  <tom@tromey.com>
 815
 816         * type-stack.h (struct type_stack) <insert>: Constify string.
 817         * type-stack.c (type_stack::insert): Constify string.
 818         * gdbtypes.h (lookup_template_type): Update.
 819         (address_space_name_to_int): Update.
 820         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 821         const.
 822         (lookup_template_type): Make name const.
 823         * c-exp.y: Update rules.
 824         (lex_one_token, classify_name, classify_inner_name)
 825         (c_print_token): Update.
 826         * p-exp.y: Update rules.
 827         (yylex): Update.
 828         * f-exp.y: Update rules.
 829         (yylex): Update.
 830         * d-exp.y: Update rules.
 831         (lex_one_token, classify_name, classify_inner_name): Update.
 832         * parse.c (write_dollar_variable, copy_name): Return std::string.
 833         * parser-defs.h (copy_name): Change return type.
 834         * m2-exp.y: Update rules.
 835         (yylex): Update.
 836         * go-exp.y (lex_one_token): Update.
 837         Update rules.
 838         (classify_unsafe_function, classify_packaged_name)
 839         (classify_name, yylex): Update.
 840
 841 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 842
 843         * configure.ac: add --enable-source-highlight switch.
 844         * configure: Regenerate.
 845         * top.c (print_gdb_version): plumb --enable-source-highlight
 846         status to "show configuration".
 847
 848 2019-04-19  Tom Tromey  <tromey@adacore.com>
 849
 850         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 851         Check ADA_TYPE_P.
 852         (empty_record, ada_template_to_fixed_record_type_1)
 853         (template_to_static_fixed_type)
 854         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 855         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 856         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 857         macros.
 858
 859 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 860
 861         PR symtab/24423:
 862         * source.c (print_source_lines_base): Advance "iter" when a
 863         control character is seen.
 864
 865 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 866
 867         * inferior.h (struct infcall_suspend_state_deleter):
 868         Catch exception in destructor to avoid crash.
 869
 870 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 871
 872         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 873         close to the add_com "shell".
 874
 875 2019-04-18  Tom Tromey  <tromey@adacore.com>
 876
 877         * process-stratum-target.h (class process_stratum_target)
 878         <stratum>: Add "final".
 879
 880 2019-04-17  Tom Tromey  <tromey@adacore.com>
 881
 882         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 883         against nullptr before use.
 884
 885 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 886
 887         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 888
 889 2019-04-17  Jim Wilson  <jimw@sifive.com>
 890             Andrew Burgess  <andrew.burgess@embecosm.com>
 891
 892         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 893         code read might fail, assume 4-byte breakpoint in that case.
 894
 895 2019-04-15  Leszek Swirski  <leszeks@google.com>
 896
 897         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 898         rather than a hand-rolled POD check when checking for forced MEMORY
 899         classification.
 900
 901 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 902
 903         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 904         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 905         function.
 906         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 907         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 908         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 909         declaration.
 910
 911 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 912
 913         * aarch64-linux-nat.c
 914         (aarch64_linux_nat_target::thread_architecture): Add override.
 915         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 916         each VQ.
 917
 918 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 919
 920         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 921
 922 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 923
 924         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 925         target types of size 96-bits, add some additional comments, and
 926         check that the builtin type we found was the correct size.
 927
 928 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 929
 930         * utils.c (prompt_for_continue): Don't restore the styling at the
 931         end, as applied_style has the wrong value.  This fixes styling in
 932         long lists of file names that are interrupted by the "Continue?"
 933         prompt.
 934
 935 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 936
 937         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 938         * c-lang.c (c_language_defn): Likewise.
 939         (cplus_language_defn): Likewise.
 940         (asm_language_defn): Likewise.
 941         (minimal_language_defn): Likewise.
 942         * d-lang.c (d_language_defn): Likewise.
 943         * f-lang.c (f_language_defn): Likewise.
 944         * go-lang.c (go_language_defn): Likewise.
 945         * language.c (unknown_language_defn): Likewise.
 946         (auto_language_defn): Likewise.
 947         * language.h (struct language_defn): Remove la_magic field.
 948         (LANG_MAGIC): Delete.
 949         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 950         * objc-lang.c (objc_language_defn): Likewise.
 951         * opencl-lang.c (opencl_language_defn): Likewise.
 952         * p-lang.c (pascal_language_defn): Likewise.
 953         * rust-lang.c (rust_language_defn): Likewise.
 954
 955 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 956
 957         * riscv-tdep.c (riscv_type_align): New function.
 958         (riscv_type_alignment): Delete.
 959         (riscv_arg_location): Use 'type_align'.
 960         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 961
 962 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 963
 964         * gdbtypes.c (type_align): A struct with no non-static fields also
 965         has alignment of 1.
 966
 967 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 968
 969         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 970         component to 0.
 971         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 972         member.
 973         (riscv_struct_info::analyse): New implementation using new
 974         analyse_inner member function.
 975         (riscv_struct_info::field_offset): New member function.
 976         (riscv_struct_info::m_offsets): New member variable.
 977         (riscv_struct_info::analyse_inner): New private member function,
 978         takes the old implementation of riscv_struct_info::analyse but
 979         extended to track field offsets.
 980         (riscv_call_arg_struct): Update the struct folding special cases
 981         to handle cases where empty C++ structs, which are non-zero
 982         length, are found.
 983         (riscv_arg_location): Initialise the length of each location, a
 984         non-zero length now indicates the location is in use.
 985         (riscv_push_dummy_call): Allow for the first location having a
 986         non-zero offset when setting up arguments.
 987         (riscv_return_value): Likewise, but for return values.
 988
 989 2019-04-11  Tom Tromey  <tromey@adacore.com>
 990
 991         * utils.c (internal_vproblem): Make "msg" const.
 992
 993 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 994
 995         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 996         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 997         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 998         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 999
1000 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1001
1002         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1003         function.
1004         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1005         of amd64_collect_native_gregset.
1006         (amd64_linux_nat_target::store_registers): Likewise.
1007
1008 2019-04-10  Tom Tromey  <tom@tromey.com>
1009
1010         * symtab.c (lookup_global_symbol_from_objfile)
1011         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1012         * objfiles.h (class separate_debug_iterator): New.
1013         (class separate_debug_range): New.
1014         (struct objfile) <separate_debug_objfiles>: New method.
1015         (objfile_separate_debug_iterate): Don't declare.
1016         * objfiles.c (separate_debug_iterator::operator++): Rename from
1017         objfile_separate_debug_iterate.
1018         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1019         iterator.
1020         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1021         iterator.
1022
1023 2019-04-10  Tom Tromey  <tom@tromey.com>
1024
1025         * symfile.c (reread_symbols): Remove old comment.
1026         * objfiles.c (free_all_objfiles): Fix a typo.
1027
1028 2019-04-10  Tom Tromey  <tom@tromey.com>
1029
1030         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1031         * minsyms.c (lookup_minimal_symbol): Use foreach.
1032         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1033         (lookup_minimal_symbol_solib_trampoline): Likewise.
1034         * symfile.c (reread_symbols): Use foreach.
1035
1036 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1037             Tom Tromey  <tromey@adacore.com>
1038
1039         PR rust/24414:
1040         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1041         (rust_lex_int_test): Change "value" to be LONGEST.
1042         (rust_lex_tests): Add test for long integer literal.
1043
1044 2019-04-09  Tom Tromey  <tromey@adacore.com>
1045
1046         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1047         to bool.
1048         (extended_remote_target::attach): Update.
1049         (remote_target::remote_notice_new_inferior): Update.
1050         (remote_target::add_current_inferior_and_thread): Update.
1051         * inferior.c (exit_inferior_1): Use "false".
1052         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1053
1054 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1055
1056         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1057         the "start" command.
1058
1059 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1060
1061         * python/py-inferior.c (infpy_thread_from_thread_handle):
1062         Adjust comments to reflect renaming of thread_from_thread_handle
1063         to thread_from_handle.  Adjust keywords.  Fix type error message.
1064         (inferior_object_methods): Add thread_from_handle.  Retain
1065         thread_from_thread_handle, but mark it as deprecated.
1066
1067 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1068
1069         * gdbthread.h (find_thread_by_handle): Revise declaration.
1070         * thread.c (find_thread_by_handle): Likewise.  Adjust
1071         implementation too.
1072         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1073         support for buffer objects as handles.
1074
1075 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1076
1077         * python/py-infthread.c (thpy_thread_handle): New function.
1078         (thread_object_methods): Register thpy_thread_handle.
1079
1080 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1081
1082         * gdbthread.h (thread_to_thread_handle): Declare.
1083         * thread.c (gdbtypes.h): Include.
1084         (thread_to_thread_handle): New function.
1085
1086         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1087         (target_thread_info_to_thread_handle): Declare.
1088         * target.c (target_thread_info_to_thread_handle): New function.
1089         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1090         * target-delegates.c: Regenerate.
1091
1092         * linux-thread-db.c (class thread_db_target): Add method
1093         thread_info_to_thread_handle.
1094         (thread_db_target::thread_info_to_thread_handle): Define.
1095         * remote.c (class remote_target): Add new method
1096         thread_info_to_thread_handle.
1097         (remote_target::thread_info_to_thread_handle): Define.
1098
1099 2019-04-08  Pedro Alves  <palves@redhat.com>
1100
1101         * common/common-exceptions.c (throw_exception): Don't create
1102         named object to throw; throw directly.
1103         (throw_it): Likewise.  Don't initialize gdb_exception::message
1104         here, with new; pass FMT and AP to the ctor instead.
1105         * common/common-exceptions.h: Include <string>.
1106         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1107         const char *, va_list)): New ctor.  Use std::make_shared.
1108         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1109         errors)): Delete.
1110         (gdb_exception_error::gdb_exception_error(enum errors, const char
1111         *, va_list)): New.
1112         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1113         Add assertion.
1114         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1115         errors)): Delete.
1116         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1117         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1118         Add assertion.
1119
1120 2019-04-08  Tom Tromey  <tom@tromey.com>
1121
1122         * valops.c (value_rtti_indirect_type): Replace throw_exception
1123         with throw.
1124         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1125         with throw.
1126         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1127         throw.
1128         * target.c (target_translate_tls_address): Replace throw_exception
1129         with throw.
1130         * stack.c (frame_apply_command_count): Replace throw_exception
1131         with throw.
1132         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1133         throw.
1134         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1135         with throw.
1136         * rs6000-tdep.c (rs6000_frame_cache)
1137         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1138         * remote.c: Replace throw_exception with throw.
1139         * record-full.c (record_full_message, record_full_wait_1)
1140         (record_full_restore): Replace throw_exception with throw.
1141         * record-btrace.c:
1142         (get_thread_current_frame_id, record_btrace_start_replaying)
1143         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1144         (cmd_record_btrace_start): Replace throw_exception with throw.
1145         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1146         throw.
1147         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1148         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1149         * linespec.c:
1150         (find_linespec_symbols): Replace throw_exception with throw.
1151         * infrun.c (displaced_step_prepare, resume): Replace
1152         throw_exception with throw.
1153         * infcmd.c (post_create_inferior): Replace throw_exception with
1154         throw.
1155         * inf-loop.c (inferior_event_handler): Replace throw_exception
1156         with throw.
1157         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1158         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1159         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1160         (get_prev_frame_always, get_frame_pc_if_available)
1161         (get_frame_address_in_block_if_available, get_frame_language):
1162         Replace throw_exception with throw.
1163         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1164         throw_exception with throw.
1165         * eval.c (fetch_subexp_value, evaluate_var_value)
1166         (evaluate_funcall, evaluate_subexp_standard): Replace
1167         throw_exception with throw.
1168         * dwarf2loc.c (call_site_find_chain)
1169         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1170         Replace throw_exception with throw.
1171         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1172         with throw.
1173         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1174         throw.
1175         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1176         * completer.c (complete_line_internal): Replace throw_exception
1177         with throw.
1178         * compile/compile-object-run.c (compile_object_run): Replace
1179         throw_exception with throw.
1180         * cli/cli-script.c (process_next_line): Replace throw_exception
1181         with throw.
1182         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1183         (btrace_enable, btrace_maint_update_pt_packets): Replace
1184         throw_exception with throw.
1185         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1186         throw_exception with throw.
1187         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1188         throw_exception with throw.
1189         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1190         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1191         * aarch64-tdep.c (aarch64_make_prologue_cache)
1192         (aarch64_make_stub_cache): Replace throw_exception with throw.
1193
1194 2019-04-08  Tom Tromey  <tom@tromey.com>
1195
1196         * common/common-exceptions.c (throw_exception): Rename from
1197         throw_exception_cxx.  Remove old copy.  Make argument const.
1198         (throw_it): Create and throw exception objects directly.
1199         * common/common-exceptions.h (throw_exception): Make argument
1200         const.
1201         (struct gdb_exception_error): Add constructor.
1202         (struct gdb_exception_quit): Add constructor.
1203
1204 2019-04-08  Tom Tromey  <tom@tromey.com>
1205
1206         * common/common-exceptions.h (exception_rethrow): Don't declare.
1207         (TRY_SJLJ): Update comment.
1208         (TRY, CATCH, END_CATCH): Remove.
1209         * common/common-exceptions.c (exception_rethrow): Remove.
1210
1211 2019-04-08  Tom Tromey  <tom@tromey.com>
1212
1213         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1214         Remove.
1215         (gdb_exception_error): Rename from
1216         gdb_exception_RETURN_MASK_ERROR.
1217         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1218         (gdb_quit_bad_alloc): Update.
1219         * aarch64-tdep.c: Update.
1220         * ada-lang.c: Update.
1221         * ada-typeprint.c: Update.
1222         * ada-valprint.c: Update.
1223         * amd64-tdep.c: Update.
1224         * arch-utils.c: Update.
1225         * break-catch-throw.c: Update.
1226         * breakpoint.c: Update.
1227         * btrace.c: Update.
1228         * c-varobj.c: Update.
1229         * cli/cli-cmds.c: Update.
1230         * cli/cli-interp.c: Update.
1231         * cli/cli-script.c: Update.
1232         * common/common-exceptions.c: Update.
1233         * common/new-op.c: Update.
1234         * common/selftest.c: Update.
1235         * compile/compile-c-symbols.c: Update.
1236         * compile/compile-cplus-symbols.c: Update.
1237         * compile/compile-object-load.c: Update.
1238         * compile/compile-object-run.c: Update.
1239         * completer.c: Update.
1240         * corelow.c: Update.
1241         * cp-abi.c: Update.
1242         * cp-support.c: Update.
1243         * cp-valprint.c: Update.
1244         * darwin-nat.c: Update.
1245         * disasm-selftests.c: Update.
1246         * dtrace-probe.c: Update.
1247         * dwarf-index-cache.c: Update.
1248         * dwarf-index-write.c: Update.
1249         * dwarf2-frame-tailcall.c: Update.
1250         * dwarf2-frame.c: Update.
1251         * dwarf2loc.c: Update.
1252         * dwarf2read.c: Update.
1253         * eval.c: Update.
1254         * event-loop.c: Update.
1255         * event-top.c: Update.
1256         * exec.c: Update.
1257         * f-valprint.c: Update.
1258         * fbsd-tdep.c: Update.
1259         * frame-unwind.c: Update.
1260         * frame.c: Update.
1261         * gdbtypes.c: Update.
1262         * gnu-v3-abi.c: Update.
1263         * guile/guile-internal.h: Update.
1264         * guile/scm-block.c: Update.
1265         * guile/scm-breakpoint.c: Update.
1266         * guile/scm-cmd.c: Update.
1267         * guile/scm-disasm.c: Update.
1268         * guile/scm-frame.c: Update.
1269         * guile/scm-lazy-string.c: Update.
1270         * guile/scm-math.c: Update.
1271         * guile/scm-param.c: Update.
1272         * guile/scm-ports.c: Update.
1273         * guile/scm-pretty-print.c: Update.
1274         * guile/scm-symbol.c: Update.
1275         * guile/scm-symtab.c: Update.
1276         * guile/scm-type.c: Update.
1277         * guile/scm-value.c: Update.
1278         * i386-linux-tdep.c: Update.
1279         * i386-tdep.c: Update.
1280         * inf-loop.c: Update.
1281         * infcall.c: Update.
1282         * infcmd.c: Update.
1283         * infrun.c: Update.
1284         * jit.c: Update.
1285         * language.c: Update.
1286         * linespec.c: Update.
1287         * linux-fork.c: Update.
1288         * linux-nat.c: Update.
1289         * linux-tdep.c: Update.
1290         * linux-thread-db.c: Update.
1291         * main.c: Update.
1292         * mi/mi-cmd-break.c: Update.
1293         * mi/mi-cmd-stack.c: Update.
1294         * mi/mi-interp.c: Update.
1295         * mi/mi-main.c: Update.
1296         * objc-lang.c: Update.
1297         * p-valprint.c: Update.
1298         * parse.c: Update.
1299         * ppc-linux-tdep.c: Update.
1300         * printcmd.c: Update.
1301         * python/py-arch.c: Update.
1302         * python/py-breakpoint.c: Update.
1303         * python/py-cmd.c: Update.
1304         * python/py-finishbreakpoint.c: Update.
1305         * python/py-frame.c: Update.
1306         * python/py-framefilter.c: Update.
1307         * python/py-gdb-readline.c: Update.
1308         * python/py-inferior.c: Update.
1309         * python/py-infthread.c: Update.
1310         * python/py-lazy-string.c: Update.
1311         * python/py-linetable.c: Update.
1312         * python/py-objfile.c: Update.
1313         * python/py-param.c: Update.
1314         * python/py-prettyprint.c: Update.
1315         * python/py-progspace.c: Update.
1316         * python/py-record-btrace.c: Update.
1317         * python/py-record.c: Update.
1318         * python/py-symbol.c: Update.
1319         * python/py-type.c: Update.
1320         * python/py-unwind.c: Update.
1321         * python/py-utils.c: Update.
1322         * python/py-value.c: Update.
1323         * python/python.c: Update.
1324         * record-btrace.c: Update.
1325         * record-full.c: Update.
1326         * remote-fileio.c: Update.
1327         * remote.c: Update.
1328         * riscv-tdep.c: Update.
1329         * rs6000-aix-tdep.c: Update.
1330         * rs6000-tdep.c: Update.
1331         * rust-exp.y: Update.
1332         * rust-lang.c: Update.
1333         * s390-tdep.c: Update.
1334         * selftest-arch.c: Update.
1335         * solib-dsbt.c: Update.
1336         * solib-frv.c: Update.
1337         * solib-spu.c: Update.
1338         * solib-svr4.c: Update.
1339         * solib.c: Update.
1340         * sparc64-linux-tdep.c: Update.
1341         * stack.c: Update.
1342         * symfile-mem.c: Update.
1343         * symmisc.c: Update.
1344         * target.c: Update.
1345         * thread.c: Update.
1346         * top.c: Update.
1347         * tracefile-tfile.c: Update.
1348         * tui/tui.c: Update.
1349         * typeprint.c: Update.
1350         * unittests/cli-utils-selftests.c: Update.
1351         * unittests/parse-connection-spec-selftests.c: Update.
1352         * valops.c: Update.
1353         * valprint.c: Update.
1354         * value.c: Update.
1355         * varobj.c: Update.
1356         * windows-nat.c: Update.
1357         * x86-linux-nat.c: Update.
1358         * xml-support.c: Update.
1359
1360 2019-04-08  Tom Tromey  <tom@tromey.com>
1361
1362         * xml-support.c: Use C++ exception handling.
1363         * x86-linux-nat.c: Use C++ exception handling.
1364         * windows-nat.c: Use C++ exception handling.
1365         * varobj.c: Use C++ exception handling.
1366         * value.c: Use C++ exception handling.
1367         * valprint.c: Use C++ exception handling.
1368         * valops.c: Use C++ exception handling.
1369         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1370         handling.
1371         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1372         * typeprint.c: Use C++ exception handling.
1373         * tui/tui.c: Use C++ exception handling.
1374         * tracefile-tfile.c: Use C++ exception handling.
1375         * top.c: Use C++ exception handling.
1376         * thread.c: Use C++ exception handling.
1377         * target.c: Use C++ exception handling.
1378         * symmisc.c: Use C++ exception handling.
1379         * symfile-mem.c: Use C++ exception handling.
1380         * stack.c: Use C++ exception handling.
1381         * sparc64-linux-tdep.c: Use C++ exception handling.
1382         * solib.c: Use C++ exception handling.
1383         * solib-svr4.c: Use C++ exception handling.
1384         * solib-spu.c: Use C++ exception handling.
1385         * solib-frv.c: Use C++ exception handling.
1386         * solib-dsbt.c: Use C++ exception handling.
1387         * selftest-arch.c: Use C++ exception handling.
1388         * s390-tdep.c: Use C++ exception handling.
1389         * rust-lang.c: Use C++ exception handling.
1390         * rust-exp.y: Use C++ exception handling.
1391         * rs6000-tdep.c: Use C++ exception handling.
1392         * rs6000-aix-tdep.c: Use C++ exception handling.
1393         * riscv-tdep.c: Use C++ exception handling.
1394         * remote.c: Use C++ exception handling.
1395         * remote-fileio.c: Use C++ exception handling.
1396         * record-full.c: Use C++ exception handling.
1397         * record-btrace.c: Use C++ exception handling.
1398         * python/python.c: Use C++ exception handling.
1399         * python/py-value.c: Use C++ exception handling.
1400         * python/py-utils.c: Use C++ exception handling.
1401         * python/py-unwind.c: Use C++ exception handling.
1402         * python/py-type.c: Use C++ exception handling.
1403         * python/py-symbol.c: Use C++ exception handling.
1404         * python/py-record.c: Use C++ exception handling.
1405         * python/py-record-btrace.c: Use C++ exception handling.
1406         * python/py-progspace.c: Use C++ exception handling.
1407         * python/py-prettyprint.c: Use C++ exception handling.
1408         * python/py-param.c: Use C++ exception handling.
1409         * python/py-objfile.c: Use C++ exception handling.
1410         * python/py-linetable.c: Use C++ exception handling.
1411         * python/py-lazy-string.c: Use C++ exception handling.
1412         * python/py-infthread.c: Use C++ exception handling.
1413         * python/py-inferior.c: Use C++ exception handling.
1414         * python/py-gdb-readline.c: Use C++ exception handling.
1415         * python/py-framefilter.c: Use C++ exception handling.
1416         * python/py-frame.c: Use C++ exception handling.
1417         * python/py-finishbreakpoint.c: Use C++ exception handling.
1418         * python/py-cmd.c: Use C++ exception handling.
1419         * python/py-breakpoint.c: Use C++ exception handling.
1420         * python/py-arch.c: Use C++ exception handling.
1421         * printcmd.c: Use C++ exception handling.
1422         * ppc-linux-tdep.c: Use C++ exception handling.
1423         * parse.c: Use C++ exception handling.
1424         * p-valprint.c: Use C++ exception handling.
1425         * objc-lang.c: Use C++ exception handling.
1426         * mi/mi-main.c: Use C++ exception handling.
1427         * mi/mi-interp.c: Use C++ exception handling.
1428         * mi/mi-cmd-stack.c: Use C++ exception handling.
1429         * mi/mi-cmd-break.c: Use C++ exception handling.
1430         * main.c: Use C++ exception handling.
1431         * linux-thread-db.c: Use C++ exception handling.
1432         * linux-tdep.c: Use C++ exception handling.
1433         * linux-nat.c: Use C++ exception handling.
1434         * linux-fork.c: Use C++ exception handling.
1435         * linespec.c: Use C++ exception handling.
1436         * language.c: Use C++ exception handling.
1437         * jit.c: Use C++ exception handling.
1438         * infrun.c: Use C++ exception handling.
1439         * infcmd.c: Use C++ exception handling.
1440         * infcall.c: Use C++ exception handling.
1441         * inf-loop.c: Use C++ exception handling.
1442         * i386-tdep.c: Use C++ exception handling.
1443         * i386-linux-tdep.c: Use C++ exception handling.
1444         * guile/scm-value.c: Use C++ exception handling.
1445         * guile/scm-type.c: Use C++ exception handling.
1446         * guile/scm-symtab.c: Use C++ exception handling.
1447         * guile/scm-symbol.c: Use C++ exception handling.
1448         * guile/scm-pretty-print.c: Use C++ exception handling.
1449         * guile/scm-ports.c: Use C++ exception handling.
1450         * guile/scm-param.c: Use C++ exception handling.
1451         * guile/scm-math.c: Use C++ exception handling.
1452         * guile/scm-lazy-string.c: Use C++ exception handling.
1453         * guile/scm-frame.c: Use C++ exception handling.
1454         * guile/scm-disasm.c: Use C++ exception handling.
1455         * guile/scm-cmd.c: Use C++ exception handling.
1456         * guile/scm-breakpoint.c: Use C++ exception handling.
1457         * guile/scm-block.c: Use C++ exception handling.
1458         * guile/guile-internal.h: Use C++ exception handling.
1459         * gnu-v3-abi.c: Use C++ exception handling.
1460         * gdbtypes.c: Use C++ exception handling.
1461         * frame.c: Use C++ exception handling.
1462         * frame-unwind.c: Use C++ exception handling.
1463         * fbsd-tdep.c: Use C++ exception handling.
1464         * f-valprint.c: Use C++ exception handling.
1465         * exec.c: Use C++ exception handling.
1466         * event-top.c: Use C++ exception handling.
1467         * event-loop.c: Use C++ exception handling.
1468         * eval.c: Use C++ exception handling.
1469         * dwarf2read.c: Use C++ exception handling.
1470         * dwarf2loc.c: Use C++ exception handling.
1471         * dwarf2-frame.c: Use C++ exception handling.
1472         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1473         * dwarf-index-write.c: Use C++ exception handling.
1474         * dwarf-index-cache.c: Use C++ exception handling.
1475         * dtrace-probe.c: Use C++ exception handling.
1476         * disasm-selftests.c: Use C++ exception handling.
1477         * darwin-nat.c: Use C++ exception handling.
1478         * cp-valprint.c: Use C++ exception handling.
1479         * cp-support.c: Use C++ exception handling.
1480         * cp-abi.c: Use C++ exception handling.
1481         * corelow.c: Use C++ exception handling.
1482         * completer.c: Use C++ exception handling.
1483         * compile/compile-object-run.c: Use C++ exception handling.
1484         * compile/compile-object-load.c: Use C++ exception handling.
1485         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1486         * compile/compile-c-symbols.c: Use C++ exception handling.
1487         * common/selftest.c: Use C++ exception handling.
1488         * common/new-op.c: Use C++ exception handling.
1489         * cli/cli-script.c: Use C++ exception handling.
1490         * cli/cli-interp.c: Use C++ exception handling.
1491         * cli/cli-cmds.c: Use C++ exception handling.
1492         * c-varobj.c: Use C++ exception handling.
1493         * btrace.c: Use C++ exception handling.
1494         * breakpoint.c: Use C++ exception handling.
1495         * break-catch-throw.c: Use C++ exception handling.
1496         * arch-utils.c: Use C++ exception handling.
1497         * amd64-tdep.c: Use C++ exception handling.
1498         * ada-valprint.c: Use C++ exception handling.
1499         * ada-typeprint.c: Use C++ exception handling.
1500         * ada-lang.c: Use C++ exception handling.
1501         * aarch64-tdep.c: Use C++ exception handling.
1502
1503 2019-04-08  Tom Tromey  <tom@tromey.com>
1504
1505         * xml-support.c (gdb_xml_parser::parse): Update.
1506         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1507         * value.c (show_convenience): Update.
1508         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1509         (test_parse_flags_qcs): Update.
1510         * thread.c (thr_try_catch_cmd): Update.
1511         * target.c (target_translate_tls_address): Update.
1512         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1513         (info_frame_command_core, frame_apply_command_count): Update.
1514         * rust-exp.y (rust_lex_exception_test): Update.
1515         * riscv-tdep.c (riscv_print_one_register_info): Update.
1516         * remote.c (remote_target::enable_btrace): Update.
1517         * record-btrace.c (record_btrace_enable_warn): Update.
1518         * python/py-utils.c (gdbpy_convert_exception): Update.
1519         * printcmd.c (do_one_display, print_variable_and_value): Update.
1520         * mi/mi-main.c (mi_print_exception): Update.
1521         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1522         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1523         * linux-nat.c (linux_nat_target::attach): Update.
1524         * linux-fork.c (class scoped_switch_fork_info): Update.
1525         * infrun.c (displaced_step_prepare): Update.
1526         * infcall.c (call_function_by_hand_dummy): Update.
1527         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1528         * gnu-v3-abi.c (print_one_vtable): Update.
1529         * frame.c (get_prev_frame_always): Update.
1530         * f-valprint.c (info_common_command_for_block): Update.
1531         * exec.c (try_open_exec_file): Update.
1532         * exceptions.c (print_exception, exception_print)
1533         (exception_fprintf, exception_print_same): Update.
1534         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1535         * dwarf-index-cache.c (index_cache::store)
1536         (index_cache::lookup_gdb_index): Update.
1537         * darwin-nat.c (maybe_cache_shell): Update.
1538         * cp-valprint.c (cp_print_value_fields): Update.
1539         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1540         (gcc_cplus_symbol_address): Update.
1541         * compile/compile-c-symbols.c (gcc_convert_symbol)
1542         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1543         * common/selftest.c: Update.
1544         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1545         a std::string.
1546         (exception_try_scope_entry, exception_try_scope_exit): Don't
1547         declare.
1548         (struct exception_try_scope): Remove.
1549         (TRY): Don't use exception_try_scope.
1550         (struct gdb_exception): Add constructor, operator=.
1551         <what>: New method.
1552         (struct gdb_exception_RETURN_MASK_ALL)
1553         (struct gdb_exception_RETURN_MASK_ERROR)
1554         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1555         (struct gdb_quit_bad_alloc): Update.
1556         * common/common-exceptions.c (exception_none): Change
1557         initializer.
1558         (struct catcher) <state, exception>: Initialize inline.
1559         <prev>: Remove member.
1560         (current_catcher): Remove.
1561         (catchers): New global.
1562         (exceptions_state_mc_init): Simplify.
1563         (catcher_pop): Remove.
1564         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1565         (try_scope_depth, exception_try_scope_entry)
1566         (exception_try_scope_exit): Remove.
1567         (throw_exception_sjlj): Update.
1568         (exception_messages, exception_messages_size): Remove.
1569         (throw_it): Simplify.
1570         (gdb_exception_sliced_copy): Remove.
1571         (throw_exception_cxx): Update.
1572         * cli/cli-script.c (script_from_file): Update.
1573         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1574         Update.
1575         * ada-valprint.c (ada_val_print): Update.
1576         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1577         (create_excep_cond_exprs): Update.
1578
1579 2019-04-08  Tom Tromey  <tom@tromey.com>
1580
1581         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1582         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1583         (TRY, CATCH, END_CATCH): Remove some definitions.
1584         * common/common-exceptions.c: Don't use GDB_XCPT.
1585         (catcher_list_size): Remove.
1586         (throw_exception, throw_it): Simplify.
1587
1588 2019-04-05  Tom Tromey  <tom@tromey.com>
1589
1590         Revert the header-sorting patch.
1591         * ft32-tdep.c: Revert.
1592         * frv-tdep.c: Revert.
1593         * frv-linux-tdep.c: Revert.
1594         * frame.c: Revert.
1595         * frame-unwind.c: Revert.
1596         * frame-base.c: Revert.
1597         * fork-child.c: Revert.
1598         * findvar.c: Revert.
1599         * findcmd.c: Revert.
1600         * filesystem.c: Revert.
1601         * filename-seen-cache.h: Revert.
1602         * filename-seen-cache.c: Revert.
1603         * fbsd-tdep.c: Revert.
1604         * fbsd-nat.h: Revert.
1605         * fbsd-nat.c: Revert.
1606         * f-valprint.c: Revert.
1607         * f-typeprint.c: Revert.
1608         * f-lang.c: Revert.
1609         * extension.h: Revert.
1610         * extension.c: Revert.
1611         * extension-priv.h: Revert.
1612         * expprint.c: Revert.
1613         * exec.h: Revert.
1614         * exec.c: Revert.
1615         * exceptions.c: Revert.
1616         * event-top.c: Revert.
1617         * event-loop.c: Revert.
1618         * eval.c: Revert.
1619         * elfread.c: Revert.
1620         * dwarf2read.h: Revert.
1621         * dwarf2read.c: Revert.
1622         * dwarf2loc.c: Revert.
1623         * dwarf2expr.h: Revert.
1624         * dwarf2expr.c: Revert.
1625         * dwarf2-frame.c: Revert.
1626         * dwarf2-frame-tailcall.c: Revert.
1627         * dwarf-index-write.h: Revert.
1628         * dwarf-index-write.c: Revert.
1629         * dwarf-index-common.c: Revert.
1630         * dwarf-index-cache.h: Revert.
1631         * dwarf-index-cache.c: Revert.
1632         * dummy-frame.c: Revert.
1633         * dtrace-probe.c: Revert.
1634         * disasm.h: Revert.
1635         * disasm.c: Revert.
1636         * disasm-selftests.c: Revert.
1637         * dictionary.c: Revert.
1638         * dicos-tdep.c: Revert.
1639         * demangle.c: Revert.
1640         * dcache.h: Revert.
1641         * dcache.c: Revert.
1642         * darwin-nat.h: Revert.
1643         * darwin-nat.c: Revert.
1644         * darwin-nat-info.c: Revert.
1645         * d-valprint.c: Revert.
1646         * d-namespace.c: Revert.
1647         * d-lang.c: Revert.
1648         * ctf.c: Revert.
1649         * csky-tdep.c: Revert.
1650         * csky-linux-tdep.c: Revert.
1651         * cris-tdep.c: Revert.
1652         * cris-linux-tdep.c: Revert.
1653         * cp-valprint.c: Revert.
1654         * cp-support.c: Revert.
1655         * cp-namespace.c: Revert.
1656         * cp-abi.c: Revert.
1657         * corelow.c: Revert.
1658         * corefile.c: Revert.
1659         * continuations.c: Revert.
1660         * completer.h: Revert.
1661         * completer.c: Revert.
1662         * complaints.c: Revert.
1663         * coffread.c: Revert.
1664         * coff-pe-read.c: Revert.
1665         * cli-out.h: Revert.
1666         * cli-out.c: Revert.
1667         * charset.c: Revert.
1668         * c-varobj.c: Revert.
1669         * c-valprint.c: Revert.
1670         * c-typeprint.c: Revert.
1671         * c-lang.c: Revert.
1672         * buildsym.c: Revert.
1673         * buildsym-legacy.c: Revert.
1674         * build-id.h: Revert.
1675         * build-id.c: Revert.
1676         * btrace.c: Revert.
1677         * bsd-uthread.c: Revert.
1678         * breakpoint.h: Revert.
1679         * breakpoint.c: Revert.
1680         * break-catch-throw.c: Revert.
1681         * break-catch-syscall.c: Revert.
1682         * break-catch-sig.c: Revert.
1683         * blockframe.c: Revert.
1684         * block.c: Revert.
1685         * bfin-tdep.c: Revert.
1686         * bfin-linux-tdep.c: Revert.
1687         * bfd-target.c: Revert.
1688         * bcache.c: Revert.
1689         * ax-general.c: Revert.
1690         * ax-gdb.h: Revert.
1691         * ax-gdb.c: Revert.
1692         * avr-tdep.c: Revert.
1693         * auxv.c: Revert.
1694         * auto-load.c: Revert.
1695         * arm-wince-tdep.c: Revert.
1696         * arm-tdep.c: Revert.
1697         * arm-symbian-tdep.c: Revert.
1698         * arm-pikeos-tdep.c: Revert.
1699         * arm-obsd-tdep.c: Revert.
1700         * arm-nbsd-tdep.c: Revert.
1701         * arm-nbsd-nat.c: Revert.
1702         * arm-linux-tdep.c: Revert.
1703         * arm-linux-nat.c: Revert.
1704         * arm-fbsd-tdep.c: Revert.
1705         * arm-fbsd-nat.c: Revert.
1706         * arm-bsd-tdep.c: Revert.
1707         * arch-utils.c: Revert.
1708         * arc-tdep.c: Revert.
1709         * arc-newlib-tdep.c: Revert.
1710         * annotate.h: Revert.
1711         * annotate.c: Revert.
1712         * amd64-windows-tdep.c: Revert.
1713         * amd64-windows-nat.c: Revert.
1714         * amd64-tdep.c: Revert.
1715         * amd64-sol2-tdep.c: Revert.
1716         * amd64-obsd-tdep.c: Revert.
1717         * amd64-obsd-nat.c: Revert.
1718         * amd64-nbsd-tdep.c: Revert.
1719         * amd64-nbsd-nat.c: Revert.
1720         * amd64-nat.c: Revert.
1721         * amd64-linux-tdep.c: Revert.
1722         * amd64-linux-nat.c: Revert.
1723         * amd64-fbsd-tdep.c: Revert.
1724         * amd64-fbsd-nat.c: Revert.
1725         * amd64-dicos-tdep.c: Revert.
1726         * amd64-darwin-tdep.c: Revert.
1727         * amd64-bsd-nat.c: Revert.
1728         * alpha-tdep.c: Revert.
1729         * alpha-obsd-tdep.c: Revert.
1730         * alpha-nbsd-tdep.c: Revert.
1731         * alpha-mdebug-tdep.c: Revert.
1732         * alpha-linux-tdep.c: Revert.
1733         * alpha-linux-nat.c: Revert.
1734         * alpha-bsd-tdep.c: Revert.
1735         * alpha-bsd-nat.c: Revert.
1736         * aix-thread.c: Revert.
1737         * agent.c: Revert.
1738         * addrmap.c: Revert.
1739         * ada-varobj.c: Revert.
1740         * ada-valprint.c: Revert.
1741         * ada-typeprint.c: Revert.
1742         * ada-tasks.c: Revert.
1743         * ada-lang.c: Revert.
1744         * aarch64-tdep.c: Revert.
1745         * aarch64-ravenscar-thread.c: Revert.
1746         * aarch64-newlib-tdep.c: Revert.
1747         * aarch64-linux-tdep.c: Revert.
1748         * aarch64-linux-nat.c: Revert.
1749         * aarch64-fbsd-tdep.c: Revert.
1750         * aarch64-fbsd-nat.c: Revert.
1751         * aarch32-linux-nat.c: Revert.
1752
1753 2019-04-05  Tom Tromey  <tom@tromey.com>
1754
1755         * ft32-tdep.c: Sort headers.
1756         * frv-tdep.c: Sort headers.
1757         * frv-linux-tdep.c: Sort headers.
1758         * frame.c: Sort headers.
1759         * frame-unwind.c: Sort headers.
1760         * frame-base.c: Sort headers.
1761         * fork-child.c: Sort headers.
1762         * findvar.c: Sort headers.
1763         * findcmd.c: Sort headers.
1764         * filesystem.c: Sort headers.
1765         * filename-seen-cache.h: Sort headers.
1766         * filename-seen-cache.c: Sort headers.
1767         * fbsd-tdep.c: Sort headers.
1768         * fbsd-nat.h: Sort headers.
1769         * fbsd-nat.c: Sort headers.
1770         * f-valprint.c: Sort headers.
1771         * f-typeprint.c: Sort headers.
1772         * f-lang.c: Sort headers.
1773         * extension.h: Sort headers.
1774         * extension.c: Sort headers.
1775         * extension-priv.h: Sort headers.
1776         * expprint.c: Sort headers.
1777         * exec.h: Sort headers.
1778         * exec.c: Sort headers.
1779         * exceptions.c: Sort headers.
1780         * event-top.c: Sort headers.
1781         * event-loop.c: Sort headers.
1782         * eval.c: Sort headers.
1783         * elfread.c: Sort headers.
1784         * dwarf2read.h: Sort headers.
1785         * dwarf2read.c: Sort headers.
1786         * dwarf2loc.c: Sort headers.
1787         * dwarf2expr.h: Sort headers.
1788         * dwarf2expr.c: Sort headers.
1789         * dwarf2-frame.c: Sort headers.
1790         * dwarf2-frame-tailcall.c: Sort headers.
1791         * dwarf-index-write.h: Sort headers.
1792         * dwarf-index-write.c: Sort headers.
1793         * dwarf-index-common.c: Sort headers.
1794         * dwarf-index-cache.h: Sort headers.
1795         * dwarf-index-cache.c: Sort headers.
1796         * dummy-frame.c: Sort headers.
1797         * dtrace-probe.c: Sort headers.
1798         * disasm.h: Sort headers.
1799         * disasm.c: Sort headers.
1800         * disasm-selftests.c: Sort headers.
1801         * dictionary.c: Sort headers.
1802         * dicos-tdep.c: Sort headers.
1803         * demangle.c: Sort headers.
1804         * dcache.h: Sort headers.
1805         * dcache.c: Sort headers.
1806         * darwin-nat.h: Sort headers.
1807         * darwin-nat.c: Sort headers.
1808         * darwin-nat-info.c: Sort headers.
1809         * d-valprint.c: Sort headers.
1810         * d-namespace.c: Sort headers.
1811         * d-lang.c: Sort headers.
1812         * ctf.c: Sort headers.
1813         * csky-tdep.c: Sort headers.
1814         * csky-linux-tdep.c: Sort headers.
1815         * cris-tdep.c: Sort headers.
1816         * cris-linux-tdep.c: Sort headers.
1817         * cp-valprint.c: Sort headers.
1818         * cp-support.c: Sort headers.
1819         * cp-namespace.c: Sort headers.
1820         * cp-abi.c: Sort headers.
1821         * corelow.c: Sort headers.
1822         * corefile.c: Sort headers.
1823         * continuations.c: Sort headers.
1824         * completer.h: Sort headers.
1825         * completer.c: Sort headers.
1826         * complaints.c: Sort headers.
1827         * coffread.c: Sort headers.
1828         * coff-pe-read.c: Sort headers.
1829         * cli-out.h: Sort headers.
1830         * cli-out.c: Sort headers.
1831         * charset.c: Sort headers.
1832         * c-varobj.c: Sort headers.
1833         * c-valprint.c: Sort headers.
1834         * c-typeprint.c: Sort headers.
1835         * c-lang.c: Sort headers.
1836         * buildsym.c: Sort headers.
1837         * buildsym-legacy.c: Sort headers.
1838         * build-id.h: Sort headers.
1839         * build-id.c: Sort headers.
1840         * btrace.c: Sort headers.
1841         * bsd-uthread.c: Sort headers.
1842         * breakpoint.h: Sort headers.
1843         * breakpoint.c: Sort headers.
1844         * break-catch-throw.c: Sort headers.
1845         * break-catch-syscall.c: Sort headers.
1846         * break-catch-sig.c: Sort headers.
1847         * blockframe.c: Sort headers.
1848         * block.c: Sort headers.
1849         * bfin-tdep.c: Sort headers.
1850         * bfin-linux-tdep.c: Sort headers.
1851         * bfd-target.c: Sort headers.
1852         * bcache.c: Sort headers.
1853         * ax-general.c: Sort headers.
1854         * ax-gdb.h: Sort headers.
1855         * ax-gdb.c: Sort headers.
1856         * avr-tdep.c: Sort headers.
1857         * auxv.c: Sort headers.
1858         * auto-load.c: Sort headers.
1859         * arm-wince-tdep.c: Sort headers.
1860         * arm-tdep.c: Sort headers.
1861         * arm-symbian-tdep.c: Sort headers.
1862         * arm-pikeos-tdep.c: Sort headers.
1863         * arm-obsd-tdep.c: Sort headers.
1864         * arm-nbsd-tdep.c: Sort headers.
1865         * arm-nbsd-nat.c: Sort headers.
1866         * arm-linux-tdep.c: Sort headers.
1867         * arm-linux-nat.c: Sort headers.
1868         * arm-fbsd-tdep.c: Sort headers.
1869         * arm-fbsd-nat.c: Sort headers.
1870         * arm-bsd-tdep.c: Sort headers.
1871         * arch-utils.c: Sort headers.
1872         * arc-tdep.c: Sort headers.
1873         * arc-newlib-tdep.c: Sort headers.
1874         * annotate.h: Sort headers.
1875         * annotate.c: Sort headers.
1876         * amd64-windows-tdep.c: Sort headers.
1877         * amd64-windows-nat.c: Sort headers.
1878         * amd64-tdep.c: Sort headers.
1879         * amd64-sol2-tdep.c: Sort headers.
1880         * amd64-obsd-tdep.c: Sort headers.
1881         * amd64-obsd-nat.c: Sort headers.
1882         * amd64-nbsd-tdep.c: Sort headers.
1883         * amd64-nbsd-nat.c: Sort headers.
1884         * amd64-nat.c: Sort headers.
1885         * amd64-linux-tdep.c: Sort headers.
1886         * amd64-linux-nat.c: Sort headers.
1887         * amd64-fbsd-tdep.c: Sort headers.
1888         * amd64-fbsd-nat.c: Sort headers.
1889         * amd64-dicos-tdep.c: Sort headers.
1890         * amd64-darwin-tdep.c: Sort headers.
1891         * amd64-bsd-nat.c: Sort headers.
1892         * alpha-tdep.c: Sort headers.
1893         * alpha-obsd-tdep.c: Sort headers.
1894         * alpha-nbsd-tdep.c: Sort headers.
1895         * alpha-mdebug-tdep.c: Sort headers.
1896         * alpha-linux-tdep.c: Sort headers.
1897         * alpha-linux-nat.c: Sort headers.
1898         * alpha-bsd-tdep.c: Sort headers.
1899         * alpha-bsd-nat.c: Sort headers.
1900         * aix-thread.c: Sort headers.
1901         * agent.c: Sort headers.
1902         * addrmap.c: Sort headers.
1903         * ada-varobj.c: Sort headers.
1904         * ada-valprint.c: Sort headers.
1905         * ada-typeprint.c: Sort headers.
1906         * ada-tasks.c: Sort headers.
1907         * ada-lang.c: Sort headers.
1908         * aarch64-tdep.c: Sort headers.
1909         * aarch64-ravenscar-thread.c: Sort headers.
1910         * aarch64-newlib-tdep.c: Sort headers.
1911         * aarch64-linux-tdep.c: Sort headers.
1912         * aarch64-linux-nat.c: Sort headers.
1913         * aarch64-fbsd-tdep.c: Sort headers.
1914         * aarch64-fbsd-nat.c: Sort headers.
1915         * aarch32-linux-nat.c: Sort headers.
1916
1917 2019-04-04  Tom Tromey  <tom@tromey.com>
1918
1919         * varobj.c (varobj_create): Update.
1920         * rust-exp.y (struct rust_parser) <update_innermost_block,
1921         lookup_symbol>: New methods.
1922         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1923         Rename.
1924         (rust_parser::rust_lookup_type)
1925         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1926         * printcmd.c (display_command, do_one_display): Update.
1927         * parser-defs.h (struct parser_state) <parser_state>: Add
1928         "tracker" parameter.
1929         (block_tracker): New member.
1930         (class innermost_block_tracker) <innermost_block_tracker>: Add
1931         "types" parameter.
1932         <reset>: Remove method.
1933         (innermost_block): Don't declare.
1934         (null_post_parser): Update.
1935         * parse.c (innermost_block): Remove global.
1936         (write_dollar_variable): Update.
1937         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1938         Remove "tracker_types" parameter.
1939         (parse_expression): Add "tracker" parameter.
1940         (parse_expression_for_completion): Update.
1941         (null_post_parser): Add "tracker" parameter.
1942         * p-exp.y: Update rules.
1943         * m2-exp.y: Update rules.
1944         * language.h (struct language_defn) <la_post_parser>: Add
1945         "tracker" parameter.
1946         * go-exp.y: Update rules.
1947         * f-exp.y: Update rules.
1948         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1949         parameter.
1950         * d-exp.y: Update rules.
1951         * c-exp.y: Update rules.
1952         * breakpoint.c (set_breakpoint_condition): Create an
1953         innermost_block_tracker.
1954         (watch_command_1): Likewise.
1955         * ada-lang.c (resolve): Add "tracker" parameter.
1956         (resolve_subexp): Likewise.
1957         * ada-exp.y (write_var_from_sym): Update.
1958
1959 2019-04-04  Tom Tromey  <tom@tromey.com>
1960
1961         * type-stack.h: New file.
1962         * type-stack.c: New file.
1963         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1964         type-stack.h.
1965         (insert_into_type_stack, insert_type, push_type, push_type_int)
1966         (insert_type_address_space, pop_type, pop_type_int)
1967         (pop_typelist, pop_type_stack, append_type_stack)
1968         (push_type_stack, get_type_stack, push_typelist)
1969         (follow_type_instance_flags, follow_types): Don't declare.
1970         * parse.c (type_stack): Remove global.
1971         (parse_exp_in_context): Update.
1972         (insert_into_type_stack, insert_type, push_type, push_type_int)
1973         (insert_type_address_space, pop_type, pop_type_int)
1974         (pop_typelist, pop_type_stack, append_type_stack)
1975         (push_type_stack, get_type_stack, push_typelist)
1976         (follow_type_instance_flags, follow_types): Remove (moved to
1977         type-stack.c).
1978         * f-exp.y (type_stack): New global.
1979         Update rules.
1980         (push_kind_type, f_parse): Update.
1981         * d-exp.y (type_stack): New global.
1982         Update rules.
1983         (d_parse): Update.
1984         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1985         Update rules.
1986         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1987         (HFILES_NO_SRCDIR): Add type-stack.h.
1988
1989 2019-04-04  Tom Tromey  <tom@tromey.com>
1990
1991         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1992         (rust_parser::convert_ast_to_expression, rust_parse)
1993         (rust_lex_test_completion, rust_lex_tests): Update.
1994         * parser-defs.h (struct expr_completion_state): New.
1995         (struct parser_state) <parser_state>: Add completion parameter.
1996         <mark_struct_expression, mark_completion_tag>: New methods.
1997         <parse_completion, m_completion_state>: New members.
1998         (prefixify_expression, null_post_parser): Update.
1999         (mark_struct_expression, mark_completion_tag): Don't declare.
2000         * parse.c (parse_completion, expout_last_struct)
2001         (expout_tag_completion_type, expout_completion_name): Remove
2002         globals.
2003         (parser_state::mark_struct_expression)
2004         (parser_state::mark_completion_tag): Now methods.
2005         (prefixify_expression): Add last_struct parameter.
2006         (prefixify_subexp): Likewise.
2007         (parse_exp_1): Update.
2008         (parse_exp_in_context): Add cstate parameter.  Update.
2009         (parse_expression_for_completion): Create an
2010         expr_completion_state.
2011         (null_post_parser): Add "completion" parameter.
2012         * p-exp.y: Update rules.
2013         (yylex): Update.
2014         * language.h (struct language_defn) <la_post_parser>: Add
2015         "completing" parameter.
2016         * go-exp.y: Update rules.
2017         (lex_one_token): Update.
2018         * expression.h (parse_completion): Don't declare.
2019         * d-exp.y: Update rules.
2020         (lex_one_token): Update rules.
2021         * c-exp.y: Update rules.
2022         (lex_one_token): Update.
2023         * ada-lang.c (resolve): Add "parse_completion" parameter.
2024         (resolve_subexp): Likewise.
2025         (ada_resolve_function): Likewise.
2026
2027 2019-04-04  Tom Tromey  <tom@tromey.com>
2028
2029         * parser-defs.h (struct parser_state) <start_arglist,
2030         end_arglist>: New methods.
2031         <arglist_len, m_funcall_chain>: New members.
2032         (arglist_len, start_arglist, end_arglist): Don't declare.
2033         * parse.c (arglist_len, funcall_chain): Remove global.
2034         (start_arglist, end_arglist): Remove functions.
2035         (parse_exp_in_context): Update.
2036         * p-exp.y: Update rules.
2037         * m2-exp.y: Update rules.
2038         * go-exp.y: Update rules.
2039         * f-exp.y: Update rules.
2040         * d-exp.y: Update rules.
2041         * c-exp.y: Update rules.
2042
2043 2019-04-04  Tom Tromey  <tom@tromey.com>
2044
2045         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2046         lex_operator, push_back>: New methods.
2047         Update all rules.
2048         (rust_parser::lex_hex, lex_escape): Rename and update.
2049         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2050         (rust_parser::lex_operator): Rename and update.
2051         (rust_parser::lex_number, rustyylex, rustyyerror)
2052         (rust_lex_test_init, rust_lex_test_sequence)
2053         (rust_lex_test_push_back, rust_lex_tests): Update.
2054         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2055         parameter.
2056         <lexptr, prev_lexptr>: New members.
2057         (lexptr, prev_lexptr): Don't declare.
2058         * parse.c (lexptr, prev_lexptr): Remove globals.
2059         (parse_exp_in_context): Update.
2060         * p-exp.y (yylex, yyerror): Update.
2061         * m2-exp.y (parse_number, yylex, yyerror): Update.
2062         * go-exp.y (lex_one_token, yyerror): Update.
2063         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2064         * d-exp.y (lex_one_token, yyerror): Update.
2065         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2066         (lex_one_token, yyerror): Update.
2067         * ada-lex.l (YY_INPUT): Update.
2068         (rewind_to_char): Update.
2069         * ada-exp.y (yyerror): Update.
2070
2071 2019-04-04  Tom Tromey  <tom@tromey.com>
2072
2073         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2074         * parser-defs.h (struct parser_state) <parser_state>: Add new
2075         parameter.
2076         <comma_terminates>: New member.
2077         (comma_terminates): Don't declare global.
2078         * parse.c (comma_terminates): Remove global.
2079         (parse_exp_in_context): Update.
2080         * p-exp.y (yylex): Update.
2081         * m2-exp.y (yylex): Update.
2082         * go-exp.y (lex_one_token): Update.
2083         * f-exp.y (yylex): Update.
2084         * d-exp.y (lex_one_token): Update.
2085         * c-exp.y (lex_one_token): Update.
2086         * ada-lex.l: Update.
2087
2088 2019-04-04  Tom Tromey  <tom@tromey.com>
2089
2090         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2091         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2092         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2093         * parser-defs.h (paren_depth): Don't declare.
2094         * parse.c (paren_depth): Remove global.
2095         (parse_exp_in_context): Update.
2096         * p-exp.y (paren_depth): New global.
2097         (pascal_parse): Initialize it.
2098         * m2-exp.y (paren_depth): New global.
2099         (m2_parse): Initialize it.
2100         * go-exp.y (paren_depth): New global.
2101         (go_parse): Initialize it.
2102         * f-exp.y (paren_depth): New global.
2103         (f_parse): Initialize it.
2104         * d-exp.y (paren_depth): New global.
2105         (d_parse): Initialize it.
2106         * c-exp.y (paren_depth): New global.
2107         (c_parse): Initialize it.
2108         * ada-lex.l (paren_depth): New global.
2109         (lexer_init): Initialize it.
2110
2111 2019-04-04  Tom Tromey  <tom@tromey.com>
2112
2113         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2114         (rust_parser::convert_ast_to_type)
2115         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2116         * parser-defs.h (struct parser_state) <parser_state>: Add
2117         parameters.  Initialize new members.
2118         <expression_context_block, expression_context_pc>: New members.
2119         * parse.c (expression_context_block, expression_context_pc):
2120         Remove globals.
2121         (parse_exp_in_context): Update.
2122         * p-exp.y: Update all rules.
2123         (yylex): Update.
2124         * m2-exp.y: Update all rules.
2125         (yylex): Update.
2126         * go-exp.y (yylex): Update.
2127         * f-exp.y (yylex): Update.
2128         * d-exp.y: Update all rules.
2129         (yylex): Update.
2130         * c-exp.y: Update all rules.
2131         (lex_one_token, classify_name, yylex, c_parse): Update.
2132         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2133
2134 2019-04-04  Tom Tromey  <tom@tromey.com>
2135
2136         * gdbarch.h, gdbarch.c: Rebuild.
2137         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2138         * stap-probe.h:
2139         (struct stap_parse_info): Replace "parser_state" with
2140         "expr_builder".
2141         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2142         (parser_state): New class.
2143         * parse.c (expr_builder): Rename.
2144         (expr_builder::release): Rename.
2145         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2146         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2147         (write_exp_elt_longcst, write_exp_elt_floatcst)
2148         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2149         (write_exp_string_vector, write_exp_bitstring)
2150         (write_exp_msymbol, mark_struct_expression)
2151         (write_dollar_variable)
2152         (insert_type_address_space, increase_expout_size): Replace
2153         "parser_state" with "expr_builder".
2154         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2155         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2156         "parser_state" with "expr_builder".
2157
2158 2019-04-04  Tom Tromey  <tom@tromey.com>
2159
2160         * rust-exp.y: Replace "parse_language" with method call.
2161         * p-exp.y:
2162         (yylex): Replace "parse_language" with method call.
2163         * m2-exp.y:
2164         (yylex): Replace "parse_language" with method call.
2165         * go-exp.y (classify_name): Replace "parse_language" with method
2166         call.
2167         * f-exp.y (yylex): Replace "parse_language" with method call.
2168         * d-exp.y (lex_one_token): Replace "parse_language" with method
2169         call.
2170         * c-exp.y:
2171         (lex_one_token, classify_name, yylex): Replace "parse_language"
2172         with method call.
2173         * ada-exp.y (find_primitive_type, type_char)
2174         (type_system_address): Replace "parse_language" with method call.
2175
2176 2019-04-04  Tom Tromey  <tom@tromey.com>
2177
2178         * rust-exp.y: Replace "parse_gdbarch" with method call.
2179         * parse.c (write_dollar_variable, insert_type_address_space):
2180         Replace "parse_gdbarch" with method call.
2181         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2182         call.
2183         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2184         call.
2185         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2186         "parse_gdbarch" with method call.
2187         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2188         with method call.
2189         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2190         "parse_gdbarch" with method call.
2191         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2192         "parse_gdbarch" with method call.
2193         * c-exp.y (parse_type, parse_number, classify_name): Replace
2194         "parse_gdbarch" with method call.
2195         * ada-lex.l: Replace "parse_gdbarch" with method call.
2196         * ada-exp.y (parse_type, find_primitive_type, type_char)
2197         (type_system_address): Replace "parse_gdbarch" with method call.
2198
2199 2019-04-04  Tom Tromey  <tom@tromey.com>
2200
2201         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2202         * stap-probe.c (stap_parse_argument): Update.
2203         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2204         initial_size parameter.
2205         * rust-exp.y (rust_lex_tests): Update.
2206         * parse.c (parser_state): Update.
2207         (parse_exp_in_context): Update.
2208         * parser-defs.h (struct parser_state) <parser_state>: Remove
2209         "initial_size" parameter.
2210
2211 2019-04-04  Tom Tromey  <tom@tromey.com>
2212
2213         * parser-defs.h (increase_expout_size): Don't declare.
2214         * parse.c (increase_expout_size): Now static.
2215
2216 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2217
2218         * gnu-nat.c (gnu_nat_target::wait): Fix
2219         target_waitstatus_to_string call.
2220
2221 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2222
2223         * eval.c (evaluate_subexp_standard): Handle internal functions
2224         during Fortran function call handling.
2225
2226 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2227
2228         * NEWS: Mention new internal functions.
2229         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2230         (read_base_type): Use dwarf2_init_complex_target_type.
2231         * value.c (creal_internal_fn): New function.
2232         (cimag_internal_fn): New function.
2233         (_initialize_values): Register new internal functions.
2234
2235 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2236
2237         * infrun.c (stop_all_threads): If debug_infrun, always
2238         trace the wait status after wait_one, using
2239         target_waitstatus_to_string and target_pid_to_str.
2240         (handle_inferior_event): Replace various trace of
2241         wait status kind by a single trace.
2242         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2243         wait status kind image by target_waitstatus_to_string.
2244         * target/waitstatus.c (target_waitstatus_to_string): Fix
2245         obsolete comment.
2246
2247 2019-04-01  Tom Tromey  <tromey@adacore.com>
2248
2249         PR symtab/23331:
2250         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2251
2252 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2253             Pedro Alves  <palves@redhat.com>
2254
2255         * top.c (quit_force): Call 'finalize_values'.
2256         * value.c (finalize_values): New function.
2257         * value.h (finalize_values): Declare.
2258
2259 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2260
2261         * NEWS: Announce $_gdb_major and $_gdb_minor.
2262
2263         * top.c (init_gdb_version_vars): New function.
2264         (gdb_init): Call init_gdb_version_vars.
2265
2266 2019-03-29  Tom Tromey  <tromey@adacore.com>
2267
2268         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2269         help text.  Remove dead code.
2270
2271 2019-03-29  Keith Seitz  <keiths@redhat.com>
2272
2273         From Siddhesh Poyarekar:
2274         * f-lang.h (f77_get_upperbound): Return LONGEST.
2275         (f77_get_lowerbound): Likewise.
2276         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2277         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2278         print them.
2279         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2280         plongest to format print it.
2281         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2282         (f77_get_upperbound): Likewise.
2283         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2284         LOWER_BOUND to LONGEST.
2285         (f77_create_arrayprint_offset_tbl): Likewise.
2286
2287 2019-03-29  Keith Seitz  <keiths@redhat.com>
2288
2289         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2290         %s/pulongest for TYPE_LENGTH instead of %d in format
2291         strings.
2292         * ada-typerint.c (ada_print_type): Likewise.
2293         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2294         * compile/compile-c-support.c (generate_register_struct): Likewise.
2295         * gdbtypes.c (recursive_dump_type): Likewise.
2296         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2297         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2298         instead of %d in format strings.
2299         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2300         to std::min to ULONGEST.
2301         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2302         instead of %d in format strings.
2303         * tracepoint.c (info_scope_command): Likewise.
2304         * typeprint.c (print_offset_data::update)
2305         (print_offset_data::finish): Likewise.
2306         * xtensa-tdep.c (xtensa_store_return_value)
2307         (xtensa_push_dummy_call): Likewise.
2308
2309 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2310
2311         * windows-nat.c (display_selector): Fixed format specifications
2312         for 64-bit Cygwin.
2313
2314 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2315
2316         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2317
2318 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2319
2320         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2321         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2322         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2323         (nios2_linux_init_abi): Install it.
2324
2325 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2326
2327         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2328
2329 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2330
2331         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2332
2333 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2334             Tom Tromey  <tromey@adacore.com>
2335
2336         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2337
2338 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2339
2340         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2341         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2342         method to compute the bounds of range types. Also print "[evaluated]"
2343         if the bounds' values come from a dynamic evaluation.
2344
2345 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2346
2347         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2348         whitespace when pretty printing is on.
2349
2350 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2351
2352         * ppc-linux-nat.c: Add include.
2353
2354 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2355
2356         * NEWS: Mention AArch64 Pointer Authentication.
2357
2358 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2359
2360         * arm-linux-nat.c: Add include.
2361
2362 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2363
2364         * source-cache.c (source_cache::get_source_lines): Re-read
2365         fullname after calling open_source_file.
2366
2367 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2368
2369         * NEWS: Mention TLS support for FreeBSD.
2370
2371 2019-03-25  Tom Tromey  <tromey@adacore.com>
2372
2373         * minsyms.c (BUNCH_SIZE): Update comment.
2374         (~minimal_symbol_reader): Remove old comment.
2375         (compact_minimal_symbols): Update comment.
2376         (minimal_symbol_reader::install): Remove old comment.  Update
2377         other comments.
2378
2379 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2380
2381         * s390-linux-nat.c: Add include.
2382
2383 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2384
2385         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2386         Call linux_get_hwcap.
2387         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2388         Likewise.
2389         (aarch64_linux_get_hwcap): Remove function.
2390         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2391         declaration.
2392         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2393         linux_get_hwcap.
2394         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2395         * linux-tdep.c (linux_get_hwcap): Add function.
2396         (linux_get_hwcap2): Likewise.
2397         * linux-tdep.h (linux_get_hwcap): Add declaration.
2398         (linux_get_hwcap2): Likewise.
2399         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2400         (ppc_linux_get_hwcap2): Likewise.
2401         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2402         linux_get_hwcap.
2403         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2404         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2405         (ppc_linux_nat_target::read_description): Likewise.
2406         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2407         * s390-linux-nat.c: Likewise.
2408         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2409
2410 2019-03-24  Tom Tromey  <tom@tromey.com>
2411
2412         * ada-lang.c (standard_lookup): Simplify initialization.
2413         (ada_lookup_symbol_nonlocal): Simplify return.
2414         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2415         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2416         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2417         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2418         initialization.
2419         * solib.c (solib_global_lookup): Simplify.
2420         * symtab.c (null_block_symbol): Remove.
2421         (symbol_cache_lookup): Simplify returns.
2422         (lookup_language_this): Simplify returns.
2423         (lookup_symbol_aux): Simplify return.
2424         (lookup_local_symbol): Simplify returns.
2425         (lookup_global_symbol_from_objfile): Simplify return.
2426         (lookup_symbol_in_objfile_symtabs)
2427         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2428         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2429         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2430         * cp-namespace.c (cp_lookup_bare_symbol)
2431         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2432         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2433         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2434         (cp_lookup_symbol_via_imports): Simplify initialization.
2435         (find_symbol_in_baseclass): Likewise.
2436         * symtab.h (null_block_symbol): Remove.
2437         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2438         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2439         (d_lookup_symbol_module): Likewise.
2440         (find_symbol_in_baseclass): Simplify initialization.
2441
2442 2019-03-24  Tom Tromey  <tom@tromey.com>
2443
2444         * expression.h: Don't include symtab.h.
2445         (struct block): Forward declare.
2446
2447 2019-03-24  Tom Tromey  <tom@tromey.com>
2448
2449         * c-exp.y (typebase): Remove casts.
2450         * gdbtypes.c (lookup_unsigned_typename, )
2451         (lookup_signed_typename): Remove cast.
2452         * eval.c (parse_to_comma_and_eval): Remove cast.
2453         * parse.c (write_dollar_variable): Remove cast.
2454         * block.h (struct block) <superblock>: Now const.
2455         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2456         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2457         (map_block): Make "block" const.
2458         * symfile.h (struct quick_symbol_functions)
2459         <map_matching_symbols>: Constify block argument to "callback".
2460         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2461         const.
2462         (find_pc_sect_compunit_symtab): Make "b" const.
2463         (find_symbol_at_address): Likewise.
2464         (search_symbols): Likewise.
2465         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2466         (dw2_debug_names_lookup_symbol): Likewise.
2467         (dw2_map_matching_symbols): Update.
2468         * p-valprint.c (pascal_val_print): Remove "block".
2469         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2470         (aux_add_nonlocal_symbols): Make "block" const.
2471         (resolve_subexp): Remove cast.
2472         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2473         const.
2474         (iterate_over_file_blocks): Likewise.
2475         * f-exp.y (%union) <bval>: Remove.
2476         * coffread.c (patch_opaque_types): Make "b" const.
2477         * spu-tdep.c (spu_catch_start): Make "block" const.
2478         * c-valprint.c (print_unpacked_pointer): Remove "block".
2479         * symmisc.c (dump_symtab_1): Make "b" const.
2480         (block_depth): Make "block" const.
2481         * d-exp.y (%union) <bval>: Remove.
2482         * cp-support.h (cp_lookup_rtti_type): Update.
2483         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2484         * psymtab.c (psym_lookup_symbol): Make "block" const.
2485         (maintenance_check_psymtabs): Make "b" const.
2486         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2487         (enumerate_locals, enumerate_args): Update.
2488         * python/py-symtab.c (stpy_global_block): Make "block" const.
2489         (stpy_static_block): Likewise.
2490         * inline-frame.c (block_starting_point_at): Make "new_block"
2491         const.
2492         * block.c (find_block_in_blockvector): Make return type const.
2493         (blockvector_for_pc_sect): Make "b" const.
2494         (find_block_in_blockvector): Make "b" const.
2495
2496 2019-03-23  Tom Tromey  <tom@tromey.com>
2497
2498         * varobj.c (varobj_create): Update.
2499         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2500         * printcmd.c (display_command, do_one_display): Don't reset
2501         innermost_block.
2502         * parser-defs.h (enum innermost_block_tracker_type): Move to
2503         expression.h.
2504         (innermost_block): Update comment.
2505         * parse.c (parse_exp_1): Add tracker_types parameter.
2506         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2507         tracker_types parameter.  Reset innermost_block.
2508         (parse_exp_in_context): Remove.
2509         (parse_expression_for_completion): Update.
2510         * objfiles.c (~objfile): Don't reset expression_context_block or
2511         innermost_block.
2512         * expression.h (enum innermost_block_tracker_type): Move from
2513         parser-defs.h.
2514         (parse_exp_1): Add tracker_types parameter.
2515         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2516         reset innermost_block.
2517
2518 2019-03-23  Tom Tromey  <tom@tromey.com>
2519
2520         * objfiles.h: Include bcache.h.
2521
2522 2019-03-23  Tom Tromey  <tom@tromey.com>
2523
2524         * linespec.c (get_current_search_block): Use
2525         scoped_restore_current_language.
2526         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2527
2528 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2529             Jiong Wang  <jiong.wang@arm.com>
2530
2531         * aarch64-linux-tdep.c
2532         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2533         section.
2534         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2535
2536 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2537             Jiong Wang  <jiong.wang@arm.com>
2538
2539         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2540         instructions.
2541         (aarch64_analyze_prologue_test): Add PACIASP test.
2542         (aarch64_prologue_prev_register): Unmask PC value.
2543
2544 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2545             Jiong Wang  <jiong.wang@arm.com>
2546
2547         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2548         (aarch64_dwarf2_prev_register): Unmask PC value.
2549         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2550         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2551         DW_CFA_AARCH64_negate_ra_state.
2552         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2553
2554 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2555             Jiong Wang  <jiong.wang@arm.com>
2556
2557         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2558         registers.
2559         (aarch64_pseudo_register_name): Likewise.
2560         (aarch64_pseudo_register_type): Likewise.
2561         (aarch64_pseudo_register_reggroup_p): Likewise.
2562         (aarch64_gdbarch_init): Add pauth registers.
2563         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2564         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2565         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2566         (struct gdbarch_tdep): Add regnum for ra_state.
2567
2568 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2569             Jiong Wang  <jiong.wang@arm.com>
2570
2571         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2572
2573 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2574             Jiong Wang  <jiong.wang@arm.com>
2575
2576         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2577         function.
2578         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2579         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2580         (aarch64_gdbarch_init): Add puth registers.
2581         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2582         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2583         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2584
2585 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2586             Jiong Wang  <jiong.wang@arm.com>
2587
2588         * aarch64-linux-nat.c
2589         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2590         * aarch64-linux-tdep.c
2591         (aarch64_linux_core_read_description): Likewise.
2592         (aarch64_linux_get_hwcap): New function.
2593         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2594         (aarch64_linux_get_hwcap): New declaration.
2595
2596 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2597             Jiong Wang  <jiong.wang@arm.com>
2598
2599         * aarch64-linux-nat.c
2600         (aarch64_linux_nat_target::read_description): Add pauth param.
2601         * aarch64-linux-tdep.c
2602         (aarch64_linux_core_read_description): Likewise.
2603         * aarch64-tdep.c (struct target_desc): Add in pauth.
2604         (aarch64_read_description): Add pauth param.
2605         (aarch64_gdbarch_init): Likewise.
2606         * aarch64-tdep.h (aarch64_read_description): Likewise.
2607         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2608         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2609         * features/Makefile: Add new files.
2610         * features/aarch64-pauth.c: New file.
2611         * features/aarch64-pauth.xml: New file.
2612
2613 2019-03-20  Tom Tromey  <tromey@adacore.com>
2614
2615         * infrun.c (handle_inferior_event): Rename from
2616         handle_inferior_event_1.  Create a scoped_value_mark.
2617         (handle_inferior_event): Remove.
2618
2619 2019-03-19  Tom Tromey  <tromey@adacore.com>
2620
2621         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2622         * infrun.h (print_stop_event): Add "displays" parameter.
2623         * infrun.c (print_stop_event): Add "displays" parameter.
2624
2625 2019-03-19  Pedro Alves  <palves@redhat.com>
2626
2627         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2628         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2629         to -1.  Fix TABs vs spaces.
2630         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2631         * tui/tui-out.h (tui_ui_out) Add intro comments.
2632         <m_line, m_start_of_line>: In-class initialize, and add describing
2633         comment.
2634
2635 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2636
2637         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2638         variable names.
2639         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2640
2641 2019-03-18  Pedro Alves  <palves@redhat.com>
2642             Eli Zaretskii <eliz@gnu.org>
2643
2644         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2645         m_line and m_start_of_line.
2646
2647 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2648
2649         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2650         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2651         it returns a newline.  This fixes a regression in TU mode, whereby
2652         the next line is output on the same screen line as the user input.
2653
2654 2019-03-18  Tom Tromey  <tromey@adacore.com>
2655
2656         * minsyms.c (minimal_symbol_reader::install): Remove call to
2657         obstack_blank.
2658
2659 2019-03-18  Pedro Alves  <palves@redhat.com>
2660
2661         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2662         New globals.
2663         (apply_style): New, factored out from ...
2664         (apply_ansi_escape): ... this.  Handle reverse video mode.
2665         (tui_set_reverse_mode): New function.
2666         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2667         * tui/tui-winsource.c (tui_show_source_line): Use
2668         tui_set_reverse_mode instead of setting A_STANDOUT.
2669         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2670         New setter methods.
2671
2672 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2673
2674         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2675         Handle tabs.
2676
2677 2019-03-18  Tom Tromey  <tromey@adacore.com>
2678
2679         * ada-lang.c (empty_array): Add "high" parameter.
2680         (ada_evaluate_subexp): Update.
2681
2682 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2683
2684         * unittests/string_view-selftests.c: Define
2685         _initialize_string_view_selftests unconditionally.
2686
2687 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2688
2689         PR gdb/24350
2690         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2691
2692 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2693
2694         PR gdb/24351
2695         * windows-nat.c (display_selector): Fix format specifiers.
2696
2697 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2698
2699         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2700         tui_refill_source_window instead of tui_refresh_win, to update the
2701         current execution line.  This fixes redisplay of the current line
2702         when stepping through the code with "next" or "step".
2703
2704 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2705
2706         * source-cache.c (source_cache::get_source_lines): Call
2707         find_source_lines to initialize s->nlines.  This fixes vertical
2708         scrolling of TUI source window when the DOWN arrow is pressed.
2709
2710 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2711
2712         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2713         linux-thread-db.c (_initialize_thread_db): Likewise.
2714
2715 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2716
2717         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2718         wclrtoeol in tui_show_source_line".  This reverts changes made in
2719         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2720
2721 2019-03-15  Tom Tromey  <tom@tromey.com>
2722
2723         * symtab.h (struct minimal_symbol): Derive from
2724         general_symbol_info.
2725         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2726         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2727         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2728         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2729         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2730         (MSYMBOL_SEARCH_NAME): Update.
2731         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2732         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2733         * minsyms.c (minimal_symbol_reader::record_full): Update.
2734
2735 2019-03-15  Tom Tromey  <tom@tromey.com>
2736
2737         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2738
2739 2019-03-15  Tom Tromey  <tom@tromey.com>
2740
2741         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2742         unique_xmalloc_ptr.
2743         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2744         Update.
2745         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2746         (build_minimal_symbol_hash_tables)
2747         (minimal_symbol_reader::install): Update.
2748
2749 2019-03-15  Tom Tromey  <tom@tromey.com>
2750
2751         * symtab.c (create_demangled_names_hash): Update.
2752         (symbol_set_names): Update.
2753         * objfiles.h (struct objfile_per_bfd_storage)
2754         <demangled_names_hash>: Now an htab_up.
2755         * objfiles.c (objfile_per_bfd_storage): Simplify.
2756
2757 2019-03-15  Tom Tromey  <tom@tromey.com>
2758
2759         * objfiles.h (struct objfile_per_bfd_storage): Declare
2760         destructor.
2761         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2762         New.
2763         (get_objfile_bfd_data): Use new.  Don't initialize
2764         language_of_main.
2765         (free_objfile_per_bfd_storage): Remove.
2766         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2767
2768 2019-03-15  Tom Tromey  <tom@tromey.com>
2769
2770         * symfile.c (reread_symbols): Update.
2771         * objfiles.c (objfile::objfile): Update.
2772         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2773         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2774         comment.
2775         (minimal_symbol_reader::install): Update.
2776         (terminate_minimal_symbol_table): Remove.
2777         * jit.c (jit_object_close_impl): Update.
2778
2779 2019-03-15  Tom Tromey  <tom@tromey.com>
2780
2781         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2782         initializations.
2783
2784 2019-03-15  Tom Tromey  <tom@tromey.com>
2785
2786         * objfiles.h (struct objfile_per_bfd_storage)
2787         <demangled_hash_languages>: Now a bitset.
2788         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2789         (lookup_minimal_symbol): Update.
2790
2791 2019-03-15  Tom Tromey  <tom@tromey.com>
2792
2793         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2794         Don't return the symbol.
2795         * coffread.c (record_minimal_symbol): Use record_full.
2796
2797 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2798
2799         The MS-Windows port of ncurses fails to switch to a color pair if
2800         one or both of the colors are the implicit default colors.  This
2801         change records the default colors when TUI is initialized, and
2802         then specifies them explicitly when a color pair uses the default
2803         colors.  This allows color styling in TUI mode on MS-Windows.
2804
2805         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2806         ncurses_norm_attr.
2807         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2808         colors in ncurses_norm_attr.
2809         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2810         "none", replace it with the default color recorded in
2811         ncurses_norm_attr.
2812
2813 2019-03-14  Tom Tromey  <tromey@adacore.com>
2814
2815         * source-cache.h (class source_cache) <get_source_lines>: Return
2816         std::string.
2817         * source-cache.c (source_cache::extract_lines): Handle case where
2818         first_pos==npos.  Return std::string.
2819         (source_cache::get_source_lines): Update.
2820
2821 2019-03-14  Tom Tromey  <tromey@adacore.com>
2822
2823         * NEWS: Add item for "style sources" commands.
2824         * source-cache.c (source_cache::get_source_lines): Check
2825         source_styling.
2826         * cli/cli-style.c (source_styling): New global.
2827         (_initialize_cli_style): Add "style sources" commands.
2828         (show_style_sources): New function.
2829         * cli/cli-style.h (source_styling): Declare.
2830
2831 2019-03-14  Pedro Alves  <palves@redhat.com>
2832             Tom Tromey  <tromey@adacore.com>
2833
2834         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2835         * tui/tui-winsource.c (tui_refill_source_window): New function,
2836         from...
2837         (tui_horizontal_source_scroll): ... here.  Move some logic.
2838         * cli/cli-style.c (set_style_enabled): Notify new observable.
2839         * tui/tui-hooks.c (tui_redisplay_source): New function.
2840         (tui_attach_detach_observers): Attach or detach
2841         tui_redisplay_source.
2842         * observable.h (source_styling_changed): New observable.
2843         * observable.c: Define source_styling_changed observable.
2844
2845 2019-03-13  Tom Tromey  <tromey@adacore.com>
2846
2847         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2848         (i386_gnu_nat_target::store_registers): Update.
2849         * target-debug.h (target_debug_print_std_string): New macro.
2850         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2851         * windows-tdep.c (display_one_tib): Update.
2852         * tui/tui-stack.c (tui_make_status_line): Update.
2853         * top.c (print_inferior_quit_action): Update.
2854         * thread.c (thr_try_catch_cmd): Update.
2855         (add_thread_with_info): Update.
2856         (thread_target_id_str): Update.
2857         (thr_try_catch_cmd): Update.
2858         (thread_command): Update.
2859         (thread_find_command): Update.
2860         * record-btrace.c (record_btrace_target::info_record)
2861         (record_btrace_resume_thread, record_btrace_target::resume)
2862         (record_btrace_cancel_resume, record_btrace_step_thread)
2863         (record_btrace_target::wait, record_btrace_target::wait)
2864         (record_btrace_target::wait, record_btrace_target::stop): Update.
2865         * progspace.c (print_program_space): Update.
2866         * process-stratum-target.c
2867         (process_stratum_target::thread_address_space): Update.
2868         * linux-fork.c (linux_fork_mourn_inferior)
2869         (detach_checkpoint_command, info_checkpoints_command)
2870         (linux_fork_context): Update.
2871         (linux_fork_detach): Update.
2872         (class scoped_switch_fork_info): Update.
2873         (delete_checkpoint_command): Update.
2874         * infrun.c (follow_fork_inferior): Update.
2875         (follow_fork_inferior): Update.
2876         (proceed_after_vfork_done): Update.
2877         (handle_vfork_child_exec_or_exit): Update.
2878         (follow_exec): Update.
2879         (displaced_step_prepare_throw): Update.
2880         (displaced_step_restore): Update.
2881         (start_step_over): Update.
2882         (resume_1): Update.
2883         (clear_proceed_status_thread): Update.
2884         (proceed): Update.
2885         (print_target_wait_results): Update.
2886         (do_target_wait): Update.
2887         (context_switch): Update.
2888         (stop_all_threads): Update.
2889         (restart_threads): Update.
2890         (finish_step_over): Update.
2891         (handle_signal_stop): Update.
2892         (switch_back_to_stepped_thread): Update.
2893         (keep_going_pass_signal): Update.
2894         (print_exited_reason): Update.
2895         (normal_stop): Update.
2896         * inferior.c (inferior_pid_to_str): Change return type.
2897         (print_selected_inferior): Update.
2898         (add_inferior): Update.
2899         (detach_inferior): Update.
2900         * dummy-frame.c (fprint_dummy_frames): Update.
2901         * dcache.c (dcache_info_1): Update.
2902         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2903         (btrace_fetch, btrace_clear): Update.
2904         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2905         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2906         type.
2907         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2908         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2909         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2910         * gdbarch.c, gdbarch.h: Rebuild.
2911         * gdbarch.sh (core_pid_to_str): Change return type.
2912         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2913         return type.
2914         (windows_nat_target::pid_to_str): Change return type.
2915         (windows_delete_thread): Update.
2916         (windows_nat_target::attach): Update.
2917         (windows_nat_target::files_info): Update.
2918         * target-delegates.c: Rebuild.
2919         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2920         return type.
2921         (sol_thread_target::pid_to_str): Change return type.
2922         * remote.c (class remote_target) <pid_to_str>: Change return
2923         type.
2924         (remote_target::pid_to_str): Change return type.
2925         (extended_remote_target::attach, remote_target::remote_stop_ns)
2926         (remote_target::remote_notif_remove_queued_reply)
2927         (remote_target::push_stop_reply, remote_target::disable_btrace):
2928         Update.
2929         (extended_remote_target::attach): Update.
2930         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2931         type.
2932         (gdbsim_target::pid_to_str): Change return type.
2933         * ravenscar-thread.c (struct ravenscar_thread_target)
2934         <pid_to_str>: Change return type.
2935         (ravenscar_thread_target::pid_to_str): Change return type.
2936         * procfs.c (class procfs_target) <pid_to_str>: Change return
2937         type.
2938         (procfs_target::pid_to_str): Change return type.
2939         (procfs_target::attach): Update.
2940         (procfs_target::detach): Update.
2941         (procfs_target::fetch_registers): Update.
2942         (procfs_target::store_registers): Update.
2943         (procfs_target::wait): Update.
2944         (procfs_target::files_info): Update.
2945         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2946         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2947         return type.
2948         (nto_procfs_target::pid_to_str): Change return type.
2949         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2950         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2951         return type.
2952         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2953         (exit_lwp): Update.
2954         (attach_proc_task_lwp_callback, get_detach_signal)
2955         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2956         (linux_nat_target::resume, wait_lwp, stop_callback)
2957         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2958         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2959         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2960         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2961         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2962         type.
2963         (inf_ptrace_target::attach): Update.
2964         (inf_ptrace_target::files_info): Update.
2965         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2966         type.
2967         (go32_nat_target::pid_to_str): Change return type.
2968         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2969         (gnu_nat_target::wait): Update.
2970         (gnu_nat_target::wait): Update.
2971         (gnu_nat_target::resume): Update.
2972         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2973         (fbsd_nat_target::wait): Update.
2974         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2975         type.
2976         (darwin_nat_target::attach): Update.
2977         * corelow.c (class core_target) <pid_to_str>: Change return type.
2978         (core_target::pid_to_str): Change return type.
2979         * target.c (normal_pid_to_str): Change return type.
2980         (default_pid_to_str): Likewise.
2981         (target_pid_to_str): Change return type.
2982         (target_translate_tls_address): Update.
2983         (target_announce_detach): Update.
2984         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2985         return type.
2986         (bsd_uthread_target::pid_to_str): Change return type.
2987         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2988         type.
2989         (bsd_kvm_target::pid_to_str): Change return type.
2990         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2991         return type.
2992         (aix_thread_target::pid_to_str): Change return type.
2993         * target.h (struct target_ops) <pid_to_str>: Change return type.
2994         (target_pid_to_str, normal_pid_to_str): Likewise.
2995         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2996         type.
2997         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2998         type.
2999         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3000         return type.
3001         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3002         type.
3003         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3004         type.
3005         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3006         return type.
3007
3008 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3009
3010         * NEWS: Mention that the new default MI version is 3.  Mention
3011         changes to the output of commands and events that deal with
3012         multi-location breakpoints.
3013         * breakpoint.c: Include "mi/mi-out.h".
3014         (print_one_breakpoint): Change output syntax if using MI version
3015         >= 3.
3016         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3017         New.
3018         (mi_multi_location_breakpoint_output_fixed): New.
3019         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3020         (mi_cmd_fix_multi_location_breakpoint_output): New.
3021         (mi_multi_location_breakpoint_output_fixed): New.
3022         * mi/mi-cmds.c (mi_cmds): Register command
3023         -fix-multi-location-breakpoint-output.
3024         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3025         interpreter "mi".
3026
3027 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3028
3029         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3030         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3031         instantiate mi_ui_out based on interpreter name.
3032         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3033         * mi/mi-main.c (mi_load_progress): Likewise.
3034
3035 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3036
3037         * NEWS: Combine separate "New targets" sections for 8.3.
3038
3039 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3040
3041         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3042         (ppcfbsd_init_abi): Install gdbarch
3043         "fetch_tls_load_module_address" and "get_thread_local_address"
3044         methods.
3045
3046 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3047
3048         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3049         (riscv_fbsd_init_abi): Install gdbarch
3050         "fetch_tls_load_module_address" and "get_thread_local_address"
3051         methods.
3052
3053 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3054
3055         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3056         (i386fbsd_init_abi): Install gdbarch
3057         "fetch_tls_load_module_address" and "get_thread_local_address"
3058         methods.
3059
3060 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3061
3062         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3063         (amd64fbsd_init_abi): Install gdbarch
3064         "fetch_tls_load_module_address" and "get_thread_local_address"
3065         methods.
3066
3067 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3068
3069         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3070         (struct fbsd_pspace_data): New type.
3071         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3072         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3073         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3074         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3075         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3076
3077 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3078
3079         * gdbtypes.c (lookup_struct_elt): New function.
3080         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3081         * gdbtypes.h (struct struct_elt): New type.
3082         (lookup_struct_elt): New prototype.
3083
3084 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3085
3086         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3087         remove disabled code block.
3088
3089 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3090
3091         * gdbarch.sh (get_thread_local_address): New method.
3092         * gdbarch.h, gdbarch.c: Regenerate.
3093         * target.c (target_translate_tls_address): Use
3094         gdbarch_get_thread_local_address if present instead of
3095         target::get_thread_local_address.
3096
3097 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3098
3099         * target.h (target::get_thread_local_address): Update comment.
3100
3101 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3102
3103         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3104         objfile->separate_debug_objfile_backlink if not NULL.
3105
3106 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3107
3108         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3109         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3110         (amd64bsd_store_inferior_registers): Likewise.
3111         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3112         Enable segment base registers.
3113         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3114         PT_GETFSBASE and PT_GETGSBASE.
3115         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3116         PT_SETGSBASE.
3117         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3118         segment base registers.
3119         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3120
3121 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3122
3123         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3124         Update calls to i386_target_description to add 'segments'
3125         parameter.
3126         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3127         add segment base registers.
3128         * arch/i386.c (i386_create_target_description): Add 'segments'
3129         parameter to enable segment base registers.
3130         * arch/i386.h (i386_create_target_description): Likewise.
3131         * features/i386/32bit-segments.xml: New file.
3132         * features/i386/32bit-segments.c: Generate.
3133         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3134         call to i386_target_description to add 'segments' parameter.
3135         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3136         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3137         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3138         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3139         if feature is present.
3140         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3141         Add 'segments' parameter to call to i386_target_description.
3142         (i386_target_description): Add 'segments' parameter to enable
3143         segment base registers.
3144         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3145         to call to i386_target_description.
3146         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3147         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3148         Define I386_NUM_REGS.
3149         (i386_target_description): Add 'segments' parameter to enable
3150         segment base registers.
3151
3152 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3153
3154         PR/24325
3155         * source-cache.c: #undef open and close, to avoid unresolved
3156         externals during linking.
3157
3158 2019-03-12  Tom Tromey  <tromey@adacore.com>
3159
3160         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3161         const.  Add initializers.
3162         (_initialize_remote): Don't initialize ptid globals.
3163
3164 2019-03-12  Pedro Alves  <palves@redhat.com>
3165
3166         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3167
3168 2019-03-12  Pedro Alves  <palves@redhat.com>
3169
3170         * cp-name-parser.y (main): Remove unused 'len' variable.
3171
3172 2019-03-12  Tom Tromey  <tromey@adacore.com>
3173
3174         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3175         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3176
3177 2019-03-12  Tom Tromey  <tromey@adacore.com>
3178
3179         * linux-nat.c (iterate_over_lwps): Update.
3180         (stop_callback): Remove parameter.
3181         (stop_wait_callback, detach_callback, resume_set_callback)
3182         (select_singlestep_lwp_callback, set_ignore_sigint)
3183         (status_callback, resumed_callback, resume_clear_callback)
3184         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3185         data parameter.
3186         (linux_nat_target::detach, linux_nat_target::resume)
3187         (linux_stop_and_wait_all_lwps, select_event_lwp)
3188         (linux_nat_filter_event, linux_nat_wait_1)
3189         (linux_nat_target::kill, linux_nat_target::stop)
3190         (linux_nat_target::stop): Update.
3191         (linux_nat_resume_callback): Change type.
3192         (resume_stopped_resumed_lwps, count_events_callback)
3193         (select_event_lwp_callback): Likewise.
3194         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3195         * arm-linux-nat.c (struct update_registers_data): Remove.
3196         (update_registers_callback): Change type.
3197         (arm_linux_insert_hw_breakpoint1): Update.
3198         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3199         parameter.
3200         (x86_linux_dr_set_addr): Update.
3201         (x86_linux_dr_set_control): Update.
3202         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3203         (iterate_over_lwps): Use gdb::function_view.
3204         * nat/aarch64-linux-hw-point.c (struct
3205         aarch64_dr_update_callback_param): Remove.
3206         (debug_reg_change_callback): Change type.
3207         (aarch64_notify_debug_reg_change): Update.
3208         * s390-linux-nat.c (s390_refresh_per_info): Update.
3209
3210 2019-03-11  Tom Tromey  <tromey@adacore.com>
3211
3212         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3213         redundant assignment to "this_cu".
3214
3215 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3216
3217         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3218
3219 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3220
3221         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3222         from...
3223         (rank_one_type): ... this.
3224
3225 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3226
3227         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3228         from...
3229         (rank_one_type): ... this.
3230
3231 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3232
3233         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3234         from...
3235         (rank_one_type): ... this.
3236
3237 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3238
3239         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3240         from...
3241         (rank_one_type): ... this.
3242
3243 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3244
3245         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3246         from...
3247         (rank_one_type): ... this.
3248
3249 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3250
3251         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3252         from...
3253         (rank_one_type): ... this.
3254
3255 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3256
3257         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3258         from...
3259         (rank_one_type): ... this.
3260
3261 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3262
3263         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3264         from...
3265         (rank_one_type): ... this.
3266
3267 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3268
3269         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3270         from...
3271         (rank_one_type): ... this.
3272
3273 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3274
3275         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3276         from...
3277         (rank_one_type): ... this.
3278
3279 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3280
3281         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3282         from...
3283         (rank_one_type): ... this.
3284
3285 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3286
3287         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3288         from...
3289         (rank_one_type): ... this.
3290
3291 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3292
3293         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3294         inferior-events' shows the example events.
3295
3296 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3297
3298         Support styling on native MS-Windows console
3299
3300         PR/24315
3301         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3302         on MS-Windows if $TERM is not defined.
3303
3304         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3305
3306         * posix-hdep.c (gdb_console_fputs):
3307         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3308         functions.
3309         * ui-file.h (gdb_console_fputs): Add prototype.
3310
3311         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3312         back to fputs only if the former returns zero.
3313
3314 2019-03-07  Tom Tromey  <tom@tromey.com>
3315
3316         * symmisc.c (print_symbol_bcache_statistics): Update.
3317         (print_objfile_statistics): Update.
3318         * symfile.c (allocate_symtab): Update.
3319         * stabsread.c: Don't include bcache.h.
3320         * psymtab.h (struct psymbol_bcache): Don't declare.
3321         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3322         (psymbol_bcache_init, psymbol_bcache_free)
3323         (psymbol_bcache_get_bcache): Don't declare.
3324         * psymtab.c (struct psymbol_bcache): Remove.
3325         (psymtab_storage::psymtab_storage): Update.
3326         (psymtab_storage::~psymtab_storage): Update.
3327         (psymbol_bcache_init, psymbol_bcache_free)
3328         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3329         (add_psymbol_to_bcache): Update.
3330         (allocate_psymtab): Update.
3331         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3332         macro_cache>: No longer pointers.
3333         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3334         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3335         * macrotab.c (macro_bcache): Update.
3336         * macroexp.c: Don't include bcache.h.
3337         * gdbtypes.c (check_types_worklist): Update.
3338         (types_deeply_equal): Remove TRY/CATCH.  Update.
3339         * elfread.c (elf_symtab_read): Update.
3340         * dwarf2read.c: Don't include bcache.h.
3341         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3342         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3343         (print_bcache_statistics, bcache_memory_used): Don't declare.
3344         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3345         methods.  Rename all data members.
3346         * bcache.c (struct bcache): Move to bcache.h.
3347         (bcache::expand_hash_table): Rename from expand_hash_table.
3348         (bcache): Remove.
3349         (bcache::insert): Rename from bcache_full.
3350         (bcache::compare): Rename from bcache_compare.
3351         (bcache_xmalloc): Remove.
3352         (bcache::~bcache): Rename from bcache_xfree.
3353         (bcache::print_statistics): Rename from print_bcache_statistics.
3354         (bcache::memory_used): Rename from bcache_memory_used.
3355
3356 2019-03-07  Pedro Alves  <palves@redhat.com>
3357
3358         * infrun.c (normal_stop): Also check for
3359         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3360
3361 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3362
3363         * f-lang.c (value_from_host_double): Moved to...
3364         * value.c (value_from_host_double): ...here.
3365         * value.h (value_from_host_double): Declare.
3366         * guile/scm-math.c (vlscm_convert_typed_number): Use
3367         value_from_host_double.
3368         (vlscm_convert_number): Likewise.
3369         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3370         * python/py-value.c (convert_value_from_python): Likewise.
3371
3372 2019-03-06  Tom Tromey  <tom@tromey.com>
3373
3374         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3375
3376 2019-03-06  Tom Tromey  <tom@tromey.com>
3377
3378         * utils.h (free_current_contents): Don't declare.
3379         * utils.c (free_current_contents): Remove.
3380
3381 2019-03-06  Tom Tromey  <tom@tromey.com>
3382
3383         * top.c (quit_force): Update.
3384         * main.c (captured_command_loop): Update.
3385         * common/new-op.c (operator new): Update.
3386         * common/common-exceptions.c (struct catcher)
3387         <save_cleanup_chain>: Remove member.
3388         (exceptions_state_mc_init): Update.
3389         (exception_try_scope_entry): Return nullptr.
3390         (exception_try_scope_exit, exception_rethrow)
3391         (throw_exception_sjlj, throw_exception_cxx): Update.
3392         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3393         (all_cleanups, do_cleanups, discard_cleanups)
3394         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3395         (restore_cleanups, restore_final_cleanups): Don't declare.
3396         (do_final_cleanups): Remove parameter.
3397         * common/cleanups.c (cleanup_chain, make_cleanup)
3398         (make_cleanup_dtor, all_cleanups, do_cleanups)
3399         (discard_my_cleanups, discard_cleanups)
3400         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3401         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3402         (null_cleanup): Remove.
3403         (do_final_cleanups): Remove parameter.
3404
3405 2019-03-06  Tom Tromey  <tom@tromey.com>
3406
3407         * remote.c (remote_target::remote_parse_stop_reply): Use
3408         unique_xmalloc_ptr.
3409
3410 2019-03-06  Tom Tromey  <tom@tromey.com>
3411
3412         * stabsread.c (struct stabs_field_info): Rename from field_info.
3413         <list, fnlist>: Add initializers.
3414         <obstack>: New member.
3415         (read_member_functions, read_struct_fields, read_baseclasses):
3416         Allocate on obstack.  Don't use cleanups.
3417         (read_one_struct_field, read_member_functions, read_struct_fields)
3418         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3419         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3420         (read_struct_type): Update.
3421
3422 2019-03-06  Tom Tromey  <tom@tromey.com>
3423
3424         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3425         * common/filestuff.h (make_cleanup_close): Don't declare.
3426         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3427         Remove.
3428
3429 2019-03-06  Tom Tromey  <tom@tromey.com>
3430
3431         * solib-aix.c: Use make_scope_exit.
3432
3433 2019-03-06  Tom Tromey  <tom@tromey.com>
3434
3435         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3436         Use make_scope_exit.
3437
3438 2019-03-06  Tom Tromey  <tom@tromey.com>
3439
3440         * solib-svr4.c (disable_probes_interface): Remove parameter.
3441         (svr4_handle_solib_event): Use make_scope_exit.
3442
3443 2019-03-06  Tom Tromey  <tom@tromey.com>
3444
3445         * remote.c (struct stop_reply_deleter): Remove.
3446         (stop_reply_up): Update.
3447         (struct stop_reply): Derive from notif_event.  Don't typedef.
3448         <regcache>: Now a std::vector.
3449         (stop_reply_xfree): Remove.
3450         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3451         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3452         (remote_target::discard_pending_stop_replies): Use delete.
3453         (remote_target::remote_parse_stop_reply): Update.
3454         (remote_target::process_stop_reply): Update.
3455         * remote-notif.h (struct notif_event): Add virtual destructor.
3456         Remove "dtr" member.
3457         (struct notif_client) <alloc_event>: Return a unique_ptr.
3458         (notif_event_xfree): Don't declare.
3459         (notif_event_up): New typedef.
3460         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3461         (notif_event_xfree, do_notif_event_xfree): Remove.
3462         (remote_notif_state_xfree): Update.
3463
3464 2019-03-06  Tom Tromey  <tom@tromey.com>
3465
3466         * infrun.c (displaced_step_clear_cleanup): Now a
3467         forward_scope_exit type.
3468         (displaced_step_prepare_throw): Update.
3469         (displaced_step_fixup): Update.
3470
3471 2019-03-06  Tom Tromey  <tom@tromey.com>
3472
3473         * inferior.h (class inferior): Update comment.
3474         * gdbthread.h (class thread_info): Update comment.
3475
3476 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3477             Tom Tromey  <tom@tromey.com>
3478
3479         * stabsread.h (struct stab_section_list): Remove.
3480         (coffstab_build_psymtabs): Update.
3481         * dbxread.c (symbuf_sections): Now a std::vector.
3482         (sect_idx): New global.
3483         (fill_symbuf): Update.
3484         (coffstab_build_psymtabs): Change type of stabsects parameter.
3485         Update.
3486         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3487         std::vector.
3488         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3489         (coff_locate_sections): Update.
3490         (coff_symfile_read): Remove cleanups.  Update.
3491         (init_stringtab): Add storage parameter.
3492         (free_stringtab, free_stringtab_cleanup): Remove.
3493         (init_lineno): Add storage parameter.
3494         (free_linetab, free_linetab_cleanup): Remove.
3495
3496 2019-03-06  Pedro Alves  <palves@redhat.com>
3497
3498         * linux-fork.c (fork_info::clobber_regs): Delete.
3499         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3500         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3501         comment.  Adjust.
3502         (scoped_switch_fork_info::scoped_switch_fork_info)
3503         (checkpoint_command, linux_fork_context): Adjust
3504         fork_save_infrun_state calls.
3505
3506 2019-03-06  Pedro Alves  <palves@redhat.com>
3507
3508         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3509         (inf_has_multiple_threads): Return 'bool' and rewrite using
3510         inferior_info::threads().
3511
3512 2019-03-06  Pedro Alves  <palves@redhat.com>
3513
3514         * linux-fork.c: Include <list>.
3515         (fork_list): Now a std::list instance.
3516         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3517         (forks_exist_p, find_last_fork): Adjust.
3518         (new_fork): Delete.
3519         (one_fork_p): New.
3520         (add_fork): Adjust.
3521         (free_fork): Delete, folded into fork_info::~fork_info().
3522         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3523         Adjust.
3524         (init_fork_list): Delete.
3525         (linux_fork_killall, linux_fork_mourn_inferior)
3526         (linux_fork_detach, info_checkpoints_command): Adjust.
3527         (_initialize_linux_fork): No longer call init_fork_list.
3528
3529 2019-03-06  Pedro Alves  <palves@redhat.com>
3530
3531         * linux-fork.c (new_fork): New, split out of ...
3532         (add_fork): ... this.  Return void.  Move "first fork" special
3533         case from here, to ...
3534         (checkpoint_command): ... here.
3535         * linux-linux.h (add_fork): Return void.
3536
3537 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3538
3539         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3540
3541 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3542             Chris January  <chris.january@arm.com>
3543             David Lecomber  <david.lecomber@arm.com>
3544
3545         * f-exp.y: New token, UNOP_INTRINSIC.
3546         (exp): New pattern using UNOP_INTRINSIC token.
3547         (f77_keywords): Add 'abs' keyword.
3548         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3549         (value_from_host_double): New function.
3550         (evaluate_subexp_f): Support UNOP_ABS.
3551
3552 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3553
3554         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3555         types.
3556
3557 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3558
3559         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3560         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3561         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3562
3563 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3564
3565         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3566
3567 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3568             Chris January  <chris.january@arm.com>
3569
3570         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3571         * f-exp.y: Define 'KIND' token.
3572         (exp): New pattern for KIND expressions.
3573         (ptype): Handle types with a kind extension.
3574         (direct_abs_decl): Extend to spot kind extensions.
3575         (f77_keywords): Add 'kind' to the list.
3576         (push_kind_type): New function.
3577         (convert_to_kind_type): New function.
3578         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3579         * parse.c (operator_length_standard): Likewise.
3580         * parser-defs.h (enum type_pieces): Add tp_kind.
3581         * std-operator.def: Add UNOP_KIND.
3582
3583 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3584
3585         * f-exp.y (f_parse): Set yydebug.
3586
3587 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3588
3589         * f-lang.c (evaluate_subexp_f): New function.
3590         (exp_descriptor_f): New global.
3591         (f_language_defn): Use exp_descriptor_f instead of
3592         exp_descriptor_standard.
3593
3594 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3595
3596         * f-exp.y (struct token): Add comments.
3597         (dot_ops): Remove uppercase versions and the end marker.
3598         (f77_keywords): Likewise.
3599         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3600         entries in the dot_ops array are case insensitive, and use
3601         strncasecmp to compare strings.  Also some whitespace cleanup in
3602         this area.  Similar for the f77_keywords array, except entries in
3603         this list might be case sensitive.
3604
3605 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3606
3607         * f-exp.y (struct f77_boolean_val): Add comments.
3608         (boolean_values): Remove uppercase versions, and end marker.
3609         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3610         and use strncasecmp to achieve case insensitivity.  Additionally,
3611         perform whitespace cleanup around this code.
3612
3613 2019-03-06  Tom Tromey  <tromey@adacore.com>
3614
3615         * remote-sim.c (gdbsim_target_open): Use result of
3616         gdb_argv::release.
3617
3618 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3619         Dirk Schubert  <dirk.schubert@arm.com>
3620         Chris January  <chris.january@arm.com>
3621
3622         * eval.c (evaluate_subexp_standard): Call Fortran argument
3623         wrapping logic.
3624         * f-lang.c (struct value): A value which can be passed into a
3625         Fortran function call.
3626         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3627         where appropriate.
3628         (struct type): Value ready for a Fortran function call.
3629         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3630         is needed.
3631         * f-lang.h (fortran_argument_convert): Declaration.
3632         (fortran_preserve_arg_pointer): Declaration.
3633         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3634
3635 2019-03-05  Tom Tromey  <tromey@adacore.com>
3636
3637         * python/py-prettyprint.c (print_string_repr): Remove #if.
3638         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3639
3640 2019-03-05  Tom Tromey  <tromey@adacore.com>
3641
3642         * target.c (the_dummy_target): Move later.  Change type to
3643         "dummy_target".
3644         (initialize_targets): Don't initialize the_dummy_target.
3645
3646 2019-03-05  Tom Tromey  <tromey@adacore.com>
3647
3648         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3649         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3650
3651 2019-03-05  Tom Tromey  <tromey@adacore.com>
3652
3653         * windows-nat.c (windows_nat_target::attach)
3654         (windows_nat_target::detach): Don't call gdb_flush.
3655         * valprint.c (generic_val_print, val_print, val_print_string):
3656         Don't call gdb_flush.
3657         * utils.c (defaulted_query): Don't call gdb_flush.
3658         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3659         * target.c (target_announce_detach): Don't call gdb_flush.
3660         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3661         * remote.c (extended_remote_target::attach): Don't call
3662         gdb_flush.
3663         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3664         * printcmd.c (do_examine): Don't call gdb_flush.
3665         (info_display_command): Don't call gdb_flush.
3666         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3667         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3668         * memattr.c (info_mem_command): Don't call gdb_flush.
3669         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3670         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3671         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3672         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3673         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3674         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3675         (gnu_nat_target::detach): Don't call gdb_flush.
3676         * f-valprint.c (f_val_print): Don't call gdb_flush.
3677         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3678         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3679         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3680         gdb_flush.
3681         * c-valprint.c (c_val_print): Don't call gdb_flush.
3682         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3683
3684 2019-03-05  Tom Tromey  <tromey@adacore.com>
3685
3686         * varobj.c (update_dynamic_varobj_children): Update.
3687         (install_default_visualizer): Use reset, not release.
3688         * value.c (set_internalvar): Update.
3689         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3690         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3691         ATTRIBUTE_UNUSED_RESULT.
3692
3693 2019-03-05  Tom Tromey  <tromey@adacore.com>
3694
3695         * remote.c (class scoped_remote_fd) <release>: Add
3696         ATTRIBUTE_UNUSED_RESULT.
3697
3698 2019-03-05  Tom Tromey  <tromey@adacore.com>
3699
3700         * macroexp.c (struct macro_buffer) <release>: Add
3701         ATTRIBUTE_UNUSED_RESULT.
3702
3703 2019-03-05  Tom Tromey  <tromey@adacore.com>
3704
3705         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3706         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3707         ATTRIBUTE_UNUSED_RESULT.
3708
3709 2019-03-05  Tom Tromey  <tromey@adacore.com>
3710
3711         * common/scoped_fd.h (class scoped_fd) <release>: Add
3712         ATTRIBUTE_UNUSED_RESULT.
3713
3714 2019-03-05  Tom Tromey  <tromey@adacore.com>
3715
3716         * parser-defs.h (struct parser_state) <release>: Add
3717         ATTRIBUTE_UNUSED_RESULT.
3718
3719 2019-03-05  Tom Tromey  <tromey@adacore.com>
3720
3721         * utils.h (class gdb_argv) <release>: Add
3722         ATTRIBUTE_UNUSED_RESULT.
3723         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3724
3725 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3726
3727         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3728         for-loop range, to avoid compiler warnings.
3729
3730         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3731         avoid compiler warnings about unused variables.
3732
3733         * NEWS: Mention end of support for native debugging on MS-Windows
3734         before XP.
3735
3736         PR gdb/24292
3737         * common/netstuff.c:
3738         * gdbserver/gdbreplay.c
3739         * gdbserver/remote-utils.c:
3740         * ser-tcp.c:
3741         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3742         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3743         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3744         'getaddrinfo' and 'freeaddrinfo' were not available before
3745         Windows XP, and mingw.org's MinGW headers by default define
3746         _WIN32_WINNT to 0x500.
3747
3748 2019-03-01  Gary Benson <gbenson@redhat.com>
3749
3750         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3751
3752 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3753             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3754
3755         PR gdb/8527
3756         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3757         set_sigint_trap, clear_sigint_trap.
3758
3759 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3760
3761         * target.c (target_detach): Clear the regcache and the
3762         frame cache.
3763
3764 2019-02-27  Pedro Alves  <palves@redhat.com>
3765
3766         * utils.c (set_screen_size): When we cap the height/width sizes,
3767         tweak the corresponding command variable to show "unlimited":
3768
3769 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3770             Pedro Alves  <palves@redhat.com>
3771
3772         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3773         before calling rl_set_screen_size.
3774
3775 2019-02-27  Tom Tromey  <tromey@adacore.com>
3776
3777         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3778         define.
3779         * python/py-value.c: Remove Python 2.4 workaround.
3780         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3781         workaround.
3782         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3783         Python 2.4 workaround.
3784         * python/python-internal.h: Remove Python 2.4 comment.
3785         (Py_ssize_t): Don't define.
3786         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3787         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3788         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3789         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3790         * python/python.c (do_start_initialization): Remove Python 2.4
3791         workaround.
3792         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3793         (print_children): Remove Python 2.4 workaround.
3794         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3795         workaround.
3796         (CHARBUFFERPROC_NAME): Remove.
3797         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3798         Python 2.4 workaround.
3799
3800 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3801
3802         * NEWS: Note minimum Python version.
3803
3804 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3805
3806         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3807         code from these functions.  Remove corresponding ifdefs.  Use
3808         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3809         Remove gotos and target of gotos.
3810         (infpy_search_memory): Likewise.
3811
3812 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3813
3814         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3815         (hppa_gdbarch_init): Don't register deleted functions with
3816         gdbarch.
3817
3818 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3819
3820         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3821         (h8300_unwind_sp): Delete.
3822         (h8300_dummy_id): Delete.
3823         (h8300_gdbarch_init): Don't register deleted functions with
3824         gdbarch.
3825
3826 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3827
3828         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3829         (ft32_unwind_pc): Delete.
3830         (ft32_unwind_sp): Delete.
3831         (ft32_gdbarch_init): Don't register deleted functions with
3832         gdbarch.
3833
3834 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3835
3836         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3837         (frv_unwind_pc): Delete.
3838         (frv_unwind_sp): Delete.
3839         (frv_gdbarch_init): Don't register deleted functions with
3840         gdbarch.
3841
3842 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3843
3844         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3845         (riscv_unwind_pc): Delete.
3846         (riscv_unwind_sp): Delete.
3847         (riscv_gdbarch_init): Don't register deleted functions with
3848         gdbarch.
3849
3850 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3851
3852         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3853         (csky_unwind_pc): Delete.
3854         (csky_unwind_sp): Delete.
3855         (csky_gdbarch_init): Don't register deleted functions with
3856         gdbarch.
3857
3858 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3859
3860         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3861         (cris_unwind_pc): Delete.
3862         (cris_unwind_sp): Delete.
3863         (cris_gdbarch_init): Don't register deleted functions with
3864         gdbarch.
3865
3866 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3867
3868         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3869         (bfin_unwind_pc): Delete.
3870         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3871
3872 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3873
3874         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3875         (arm_unwind_pc): Delete.
3876         (arm_unwind_sp): Delete.
3877         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3878
3879 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3880
3881         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3882         (arc_unwind_pc): Delete.
3883         (arc_unwind_sp): Delete.
3884         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3885
3886 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3887
3888         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3889         (alpha_unwind_pc): Delete.
3890         (alpha_gdbarch_init): Don't register deleted functions with
3891         gdbarch.
3892
3893 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3894
3895         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3896         (aarch64_unwind_pc): Delete.
3897         (aarch64_unwind_sp): Delete.
3898         (aarch64_gdbarch_init): Don't register deleted functions with
3899         gdbarch.
3900
3901 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3902
3903         * gdbtypes.c (type_align): Don't consider static members when
3904         computing structure alignment.
3905
3906 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3907
3908         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3909         return 0 for other types.
3910         * arch-utils.c (default_type_align): Always return 0.
3911         * gdbarch.h: Regenerate.
3912         * gdbarch.sh (type_align): Extend comment.
3913         * gdbtypes.c (type_align): Add additional comments, always call
3914         gdbarch_type_align before applying the default rules.
3915         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3916         generic code will then apply a suitable default.
3917         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3918         types, return 0 for other types.
3919
3920 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3921
3922         * NEWS: Create a new section for the next release branch.
3923         Rename the section of the current branch, now that it has
3924         been cut.
3925
3926 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3927
3928         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3929         * version.in: Bump version to 8.3.50.DATE-git.
3930
3931 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3932
3933         * aix-thread.c (ptid_cmp): Remove unused variable.
3934         (get_signaled_thread): Likewise.
3935         (store_regs_user_thread): Likewise.
3936         (store_regs_kernel_thread): Likewise.
3937         (fetch_regs_kernel_thread): Remove shadowed variable.
3938
3939 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3940
3941         * features/riscv/32bit-cpu.xml: Add register numbers.
3942         * features/riscv/32bit-fpu.c: Regenerate.
3943         * features/riscv/32bit-fpu.xml: Add register numbers.
3944         * features/riscv/64bit-cpu.xml: Add register numbers.
3945         * features/riscv/64bit-fpu.c: Regenerate.
3946         * features/riscv/64bit-fpu.xml: Add register numbers.
3947
3948 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3949
3950         * NEWS: Mention two argument form of gdb.Value constructor.
3951         * python/py-value.c (convert_buffer_and_type_to_value): New
3952         function.
3953         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3954         Add support for handling an optional second argument.  Call
3955         convert_buffer_and_type_to_value as appropriate.
3956         * python/python-internal.h (Py_buffer_deleter): New struct.
3957         (Py_buffer_up): New typedef.
3958
3959 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3960
3961         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3962         instead of releasing ownership.
3963
3964 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3965
3966         * dwarf2read.c (open_and_init_dwp_file): Call
3967         elf_numsections instead of bfd_count_sections to initialize
3968         dwp_file->num_sections.
3969
3970 2019-02-25  Tom Tromey  <tromey@adacore.com>
3971
3972         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3973
3974 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3975
3976         * gcore.in: Add '--readnever' option when invoking GDB.
3977
3978 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3979
3980         * MAINTAINERS: Update my email address.
3981
3982 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3983
3984         * build-id.c (build_id_to_debug_bfd_1): New function.
3985         (build_id_to_debug_bfd): Look for separate debug file in
3986         sysroot.
3987
3988 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3989
3990         * gdbarch.sh: Update the copyright year range that is placed into
3991         generated files.
3992
3993 2019-02-22  Keith Seitz  <keiths@redhat.com>
3994
3995         PR symtab/23853
3996         * linespec.c (create_sals_line_offset): Search for the default
3997         symtab's filename instead of its fullname.
3998
3999 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4000
4001         * NEWS: Update style defaults.
4002
4003 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4004
4005         * main.c (captured_main_1): Disable styling in batch mode.
4006
4007 2019-02-20  Tom Tromey  <tom@tromey.com>
4008
4009         * symtab.c (symtab_symbol_info): Fix typos.
4010
4011 2019-02-20  Tom Tromey  <tromey@adacore.com>
4012
4013         * findcmd.c (_initialize_mem_search): Use upper case for
4014         metasyntactic variables.
4015
4016 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4017
4018         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4019         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4020
4021 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4022
4023         * top.h (source_file_name): Change to std::string.
4024         * top.c (source_file_name): Likewise.
4025         (command_line_input): Adjust.
4026         * cli/cli-script.c (script_from_file): Adjust.
4027
4028 2019-02-19  Tom Tromey  <tromey@adacore.com>
4029
4030         * ravenscar-thread.c
4031         (ravenscar_thread_target::update_thread_list): Don't call
4032         ada_build_task_list.
4033         * ada-lang.h (ada_build_task_list): Don't declare.
4034         * ada-tasks.c (struct ada_tasks_inferior_data)
4035         <task_list_valid_p>: Now bool.
4036         (read_known_tasks, ada_task_list_changed)
4037         (ada_tasks_invalidate_inferior_data): Update.
4038         (read_known_tasks_array): Return bool.
4039         (read_known_tasks_list): Likewise.
4040         (read_known_tasks): Return void.
4041         (ada_build_task_list): Now static.
4042
4043 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4044
4045         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4046         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4047
4048 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4049
4050         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4051         variant for ada_tasks_pspace_data_handle and
4052         ada_tasks_inferior_data_handle.
4053         (ada_tasks_pspace_data_cleanup): New function.
4054         (ada_tasks_inferior_data_cleanup): New function.
4055
4056 2019-02-17  Tom Tromey  <tom@tromey.com>
4057
4058         * macrotab.h (macro_source_fullname): Return a std::string.
4059         * macrotab.c (macro_include, check_for_redefinition)
4060         (macro_undef, macro_lookup_definition, foreach_macro)
4061         (foreach_macro_in_scope): Update.
4062         (macro_source_fullname): Return a std::string.
4063         * macrocmd.c (show_pp_source_pos): Update.
4064
4065 2019-02-17  Tom Tromey  <tom@tromey.com>
4066
4067         * macrocmd.c (show_pp_source_pos): Style the file names.
4068
4069 2019-02-17  Tom Tromey  <tom@tromey.com>
4070
4071         PR tui/24197:
4072         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4073
4074 2019-02-17  Tom Tromey  <tom@tromey.com>
4075
4076         * ada-lang.c (user_select_syms): Use filtered printing.
4077         * utils.c (wrap_style): New global.
4078         (desired_style): Remove.
4079         (emit_style_escape): Add stream parameter.
4080         (set_output_style, reset_terminal_style, prompt_for_continue):
4081         Update.
4082         (flush_wrap_buffer): Only flush gdb_stdout.
4083         (wrap_here): Set wrap_style.
4084         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4085         treat escape sequences as a character.  Change when wrap buffer is
4086         flushed.
4087         (fputs_styled): Do not set the output style when the default is
4088         requested.
4089         * ui-style.h (struct ui_file_style) <is_default>: New method.
4090         * source.c (print_source_lines_base): Emit escape sequences in one
4091         piece.
4092
4093 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4094
4095         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4096         integers and enumeration types.
4097
4098 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4099
4100         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4101         instead of lookup_symbol_in_language
4102         (do_exact_match): New function.
4103         (ada_get_symbol_name_matcher): Return do_exact_match when
4104         doing a verbatim match.
4105
4106 2019-02-15  Tom Tromey  <tromey@adacore.com>
4107
4108         * ravenscar-thread.c (ravenscar_thread_target::resume)
4109         (ravenscar_thread_target::wait): Special case wildcard requests.
4110
4111 2019-02-15  Tom Tromey  <tromey@adacore.com>
4112
4113         * ravenscar-thread.c (base_ptid): Remove.
4114         (struct ravenscar_thread_target) <close>: New method.
4115         <m_base_ptid>: New member.
4116         <update_inferior_ptid, active_task, task_is_currently_active,
4117         runtime_initialized>: Declare methods.
4118         <ravenscar_thread_target>: Add constructor.
4119         (ravenscar_thread_target::task_is_currently_active)
4120         (ravenscar_thread_target::update_inferior_ptid)
4121         (ravenscar_runtime_initialized): Rename.  Now methods.
4122         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4123         (ravenscar_thread_target::update_thread_list): Update.
4124         (ravenscar_thread_target::active_task): Now method.
4125         (ravenscar_thread_target::store_registers)
4126         (ravenscar_thread_target::prepare_to_store)
4127         (ravenscar_thread_target::prepare_to_store)
4128         (ravenscar_thread_target::mourn_inferior): Update.
4129         (ravenscar_inferior_created): Use "new" to create target.
4130         (ravenscar_thread_target::get_ada_task_ptid): Update.
4131         (_initialize_ravenscar): Don't initialize base_ptid.
4132         (ravenscar_ops): Remove global.
4133
4134 2019-02-15  Tom Tromey  <tromey@adacore.com>
4135
4136         * target.h (push_target): Declare new overload.
4137         * target.c (push_target): New overload, taking an rvalue reference.
4138         * remote.c (remote_target::open_1): Use push_target overload.
4139         * corelow.c (core_target_open): Use push_target overload.
4140
4141 2019-02-15  Tom Tromey  <tromey@adacore.com>
4142
4143         * ravenscar-thread.c (is_ravenscar_task)
4144         (ravenscar_task_is_currently_active): Return bool.
4145         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4146         (_initialize_ravenscar): Remove "(void)".
4147         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4148         Return bool.
4149
4150 2019-02-15  Tom Tromey  <tromey@adacore.com>
4151
4152         * ravenscar-thread.c (ravenscar_runtime_initializer)
4153         (has_ravenscar_runtime, get_running_thread_id)
4154         (ravenscar_thread_target::resume): Fix indentation.
4155
4156 2019-02-15  Tom Tromey  <tromey@adacore.com>
4157
4158         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4159         from ravenscar_arch_ops.
4160         (sparc_ravenscar_ops::fetch_registers)
4161         (sparc_ravenscar_ops::store_registers): Now methods.
4162         (sparc_ravenscar_prepare_to_store): Remove.
4163         (sparc_ravenscar_ops): Redefine.
4164         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4165         methods and destructor.  Remove members.
4166         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4167         (ravenscar_thread_target::store_registers)
4168         (ravenscar_thread_target::prepare_to_store): Update.
4169         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4170         Remove.
4171         (struct ppc_ravenscar_powerpc_ops): Derive from
4172         ravenscar_arch_ops.
4173         (ppc_ravenscar_powerpc_ops::fetch_registers)
4174         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4175         (ppc_ravenscar_powerpc_ops): Redefine.
4176         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4177         (ppc_ravenscar_e500_ops::fetch_registers)
4178         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4179         (ppc_ravenscar_e500_ops): Redefine.
4180         * aarch64-ravenscar-thread.c
4181         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4182         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4183         (aarch64_ravenscar_fetch_registers)
4184         (aarch64_ravenscar_store_registers): Now methods.
4185         (aarch64_ravenscar_ops): Redefine.
4186
4187 2019-02-15  Tom Tromey  <tromey@adacore.com>
4188
4189         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4190         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4191         (ravenscar_thread_target::stopped_by_watchpoint)
4192         (ravenscar_thread_target::stopped_data_address)
4193         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4194
4195 2019-02-15  Tom Tromey  <tromey@adacore.com>
4196
4197         * ravenscar-thread.c: Fix some typos.
4198
4199 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4200             Tom Tromey  <tromey@adacore.com>
4201
4202         * ada-lang.c (ada_exception_sal): Change addr_string to a
4203         std::string.
4204         (create_ada_exception_catchpoint): Update.
4205
4206 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4207             Tom Tromey  <tromey@adacore.com>
4208
4209         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4210         (bp_location_ops): Remove.
4211         (base_breakpoint_allocate_location): Update.
4212         (free_bp_location): Update.
4213         * ada-lang.c (class ada_catchpoint_location)
4214         <ada_catchpoint_location>: Remove ops parameter.
4215         (ada_catchpoint_location_dtor): Remove.
4216         (ada_catchpoint_location_ops): Remove.
4217         (allocate_location_exception): Update.
4218         * breakpoint.h (struct bp_location_ops): Remove.
4219         (class bp_location) <bp_location>: Remove bp_location_ops
4220         parameter.
4221         <~bp_location>: Add destructor.
4222         <ops>: Remove.
4223
4224 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4225             Pedro Alves  <palves@redhat.com>
4226
4227         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4228         'PATH_MAX'.
4229
4230 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4231             Samuel Thibault  <samuel.thibault@gnu.org>
4232             Thomas Schwinge  <thomas@codesourcery.com>
4233
4234         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4235         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4236
4237 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4238
4239         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4240         (check_empty): Use "const char *".
4241
4242         * gnu-nat.c (gnu_nat_target::detach): Instead of
4243         'detach_inferior (pid)' call
4244         'detach_inferior (find_inferior_pid (pid))'.
4245
4246         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4247         'nat/fork-inferior.o'.
4248         * gnu-nat.c: #include "nat/fork-inferior.h".
4249
4250         * gnu-nat.c (gnu_nat_target::detach): Instead of
4251         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4252         * gnu-nat.h: #include "inf-child.h".
4253         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4254         'i386_gnu_nat_target::fetch_registers'.
4255         (gnu_store_registers): Rename/move to
4256         'i386_gnu_nat_target::store_registers'.
4257
4258         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4259         * gnu-nat.h (mach_thread_info): New function.
4260         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4261
4262         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4263
4264 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4265
4266         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4267
4268 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4269
4270         * windows-nat.c (windows_add_thread): Add new parameter
4271         "main_thread_p" with default value set to false.  Update
4272         function documentation as well as all callers.
4273         (windows_delete_thread): Likewise.
4274         (fake_create_process): Update call to windows_add_thread.
4275         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4276         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4277         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4278         call to windows_delete_thread.
4279
4280 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4281
4282         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4283
4284 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4285
4286         * symfile.c (find_separate_debug_file): Use canonical path of
4287         sysroot with child_path instead of gdb_sysroot if it is valid.
4288
4289 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4290
4291         * symfile.c (find_separate_debug_file): Use child_path to
4292         determine if an object file is under a sysroot.
4293
4294 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4295
4296         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4297         unittests/child-path-selftests.c.
4298         * common/pathstuff.c (child_path): New function.
4299         * common/pathstuff.h (child_path): New prototype.
4300         * unittests/child-path-selftests.c: New file.
4301
4302 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4303
4304         * symfile.c (find_separate_debug_file): Look for separate debug
4305         files in debug directories under the sysroot.
4306
4307 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4308
4309         * symtab.h (struct minimal_symbol data_p): New const method.
4310         (struct minimal_symbol text_p): Likewise.
4311         * symtab.c (output_source_filename): Use file name style
4312         to print file name.
4313         (print_symbol_info): Likewise.
4314         (print_msymbol_info): Use address style to print addresses.
4315         Use function name style to print executable text symbols.
4316         (expand_symtab_containing_pc): Use data_p.
4317         (find_pc_sect_compunit_symtab): Likewise.
4318
4319 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4320
4321         * breakpoint.c (describe_other_breakpoints): Use address style
4322         to print addresses.
4323         (say_where): Likewise.
4324
4325 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4326
4327         * ada-typeprint.c (print_func_type): Print function name
4328         style to print function name.
4329         * c-typeprint.c (c_print_type_1): Likewise.
4330
4331 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4332
4333         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4334         for execve.
4335
4336 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4337
4338         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4339         type_stack.
4340
4341 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4342
4343         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4344         TYPE_CODE_REF types.
4345
4346 2019-02-08  Jim Wilson  <jimw@sifive.com>
4347
4348         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4349         (riscv_linux_fregset): New.
4350         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4351
4352 2019-02-07  Tom Tromey  <tom@tromey.com>
4353
4354         * thread.c (thread_cancel_execution_command): Update.
4355         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4356         methods.
4357         (struct thread_fsm_ops): Remove.
4358         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4359         (thread_fsm_should_stop, thread_fsm_return_value)
4360         (thread_fsm_set_finished, thread_fsm_finished_p)
4361         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4362         Don't declare.
4363         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4364         * infrun.c (clear_proceed_status_thread)
4365         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4366         (print_stop_event): Update.
4367         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4368         Add constructor.
4369         (step_command_fsm_ops): Remove.
4370         (new_step_command_fsm): Remove.
4371         (step_1): Update.
4372         (step_command_fsm::should_stop): Rename from
4373         step_command_fsm_should_stop.
4374         (step_command_fsm::clean_up): Rename from
4375         step_command_fsm_clean_up.
4376         (step_command_fsm::do_async_reply_reason): Rename from
4377         step_command_fsm_async_reply_reason.
4378         (struct until_next_fsm): Inherit from thread_fsm.  Add
4379         constructor.
4380         (until_next_fsm_ops): Remove.
4381         (new_until_next_fsm): Remove.
4382         (until_next_fsm::should_stop): Rename from
4383         until_next_fsm_should_stop.
4384         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4385         (until_next_fsm::do_async_reply_reason): Rename from
4386         until_next_fsm_async_reply_reason.
4387         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4388         constructor.  Change type of breakpoint.
4389         (finish_command_fsm_ops): Remove.
4390         (new_finish_command_fsm): Remove.
4391         (finish_command_fsm::should_stop): Rename from
4392         finish_command_fsm_should_stop.
4393         (finish_command_fsm::clean_up): Rename from
4394         finish_command_fsm_clean_up.
4395         (finish_command_fsm::return_value): Rename from
4396         finish_command_fsm_return_value.
4397         (finish_command_fsm::do_async_reply_reason): Rename from
4398         finish_command_fsm_async_reply_reason.
4399         (finish_command): Update.
4400         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4401         Add constructor.
4402         (call_thread_fsm_ops): Remove.
4403         (call_thread_fsm::call_thread_fsm): Rename from
4404         new_call_thread_fsm.
4405         (call_thread_fsm::should_stop): Rename from
4406         call_thread_fsm_should_stop.
4407         (call_thread_fsm::should_notify_stop): Rename from
4408         call_thread_fsm_should_notify_stop.
4409         (run_inferior_call, call_function_by_hand_dummy): Update.
4410         * cli/cli-interp.c (should_print_stop_to_console): Update.
4411         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4412         Add constructor.  Change type of location_breakpoint,
4413         caller_breakpoint.
4414         (until_break_fsm_ops): Remove.
4415         (new_until_break_fsm): Remove.
4416         (until_break_fsm::should_stop): Rename from
4417         until_break_fsm_should_stop.
4418         (until_break_fsm::clean_up): Rename from
4419         until_break_fsm_clean_up.
4420         (until_break_fsm::do_async_reply_reason): Rename from
4421         until_break_fsm_async_reply_reason.
4422         (until_break_command): Update.
4423         * thread-fsm.c: Remove.
4424         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4425
4426 2019-02-07  Tom Tromey  <tom@tromey.com>
4427
4428         * yy-remap.h: Add include guard.
4429         * xtensa-tdep.h: Add include guard.
4430         * xcoffread.h: Rename include guard.
4431         * varobj-iter.h: Add include guard.
4432         * tui/tui.h: Rename include guard.
4433         * tui/tui-winsource.h: Rename include guard.
4434         * tui/tui-wingeneral.h: Rename include guard.
4435         * tui/tui-windata.h: Rename include guard.
4436         * tui/tui-win.h: Rename include guard.
4437         * tui/tui-stack.h: Rename include guard.
4438         * tui/tui-source.h: Rename include guard.
4439         * tui/tui-regs.h: Rename include guard.
4440         * tui/tui-out.h: Rename include guard.
4441         * tui/tui-layout.h: Rename include guard.
4442         * tui/tui-io.h: Rename include guard.
4443         * tui/tui-hooks.h: Rename include guard.
4444         * tui/tui-file.h: Rename include guard.
4445         * tui/tui-disasm.h: Rename include guard.
4446         * tui/tui-data.h: Rename include guard.
4447         * tui/tui-command.h: Rename include guard.
4448         * tic6x-tdep.h: Add include guard.
4449         * target/waitstatus.h: Rename include guard.
4450         * target/wait.h: Rename include guard.
4451         * target/target.h: Rename include guard.
4452         * target/resume.h: Rename include guard.
4453         * target-float.h: Rename include guard.
4454         * stabsread.h: Add include guard.
4455         * rs6000-tdep.h: Add include guard.
4456         * riscv-fbsd-tdep.h: Add include guard.
4457         * regformats/regdef.h: Rename include guard.
4458         * record.h: Rename include guard.
4459         * python/python.h: Rename include guard.
4460         * python/python-internal.h: Rename include guard.
4461         * python/py-stopevent.h: Rename include guard.
4462         * python/py-ref.h: Rename include guard.
4463         * python/py-record.h: Rename include guard.
4464         * python/py-record-full.h: Rename include guard.
4465         * python/py-record-btrace.h: Rename include guard.
4466         * python/py-instruction.h: Rename include guard.
4467         * python/py-events.h: Rename include guard.
4468         * python/py-event.h: Rename include guard.
4469         * procfs.h: Add include guard.
4470         * proc-utils.h: Add include guard.
4471         * p-lang.h: Add include guard.
4472         * or1k-tdep.h: Rename include guard.
4473         * observable.h: Rename include guard.
4474         * nto-tdep.h: Rename include guard.
4475         * nat/x86-linux.h: Rename include guard.
4476         * nat/x86-linux-dregs.h: Rename include guard.
4477         * nat/x86-gcc-cpuid.h: Add include guard.
4478         * nat/x86-dregs.h: Rename include guard.
4479         * nat/x86-cpuid.h: Rename include guard.
4480         * nat/ppc-linux.h: Rename include guard.
4481         * nat/mips-linux-watch.h: Rename include guard.
4482         * nat/linux-waitpid.h: Rename include guard.
4483         * nat/linux-ptrace.h: Rename include guard.
4484         * nat/linux-procfs.h: Rename include guard.
4485         * nat/linux-osdata.h: Rename include guard.
4486         * nat/linux-nat.h: Rename include guard.
4487         * nat/linux-namespaces.h: Rename include guard.
4488         * nat/linux-btrace.h: Rename include guard.
4489         * nat/glibc_thread_db.h: Rename include guard.
4490         * nat/gdb_thread_db.h: Rename include guard.
4491         * nat/gdb_ptrace.h: Rename include guard.
4492         * nat/fork-inferior.h: Rename include guard.
4493         * nat/amd64-linux-siginfo.h: Rename include guard.
4494         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4495         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4496         * nat/aarch64-linux.h: Rename include guard.
4497         * nat/aarch64-linux-hw-point.h: Rename include guard.
4498         * mn10300-tdep.h: Add include guard.
4499         * mips-linux-tdep.h: Add include guard.
4500         * mi/mi-parse.h: Rename include guard.
4501         * mi/mi-out.h: Rename include guard.
4502         * mi/mi-main.h: Rename include guard.
4503         * mi/mi-interp.h: Rename include guard.
4504         * mi/mi-getopt.h: Rename include guard.
4505         * mi/mi-console.h: Rename include guard.
4506         * mi/mi-common.h: Rename include guard.
4507         * mi/mi-cmds.h: Rename include guard.
4508         * mi/mi-cmd-break.h: Rename include guard.
4509         * m2-lang.h: Add include guard.
4510         * location.h: Rename include guard.
4511         * linux-record.h: Rename include guard.
4512         * linux-nat.h: Add include guard.
4513         * linux-fork.h: Add include guard.
4514         * i386-darwin-tdep.h: Rename include guard.
4515         * hppa-linux-offsets.h: Add include guard.
4516         * guile/guile.h: Rename include guard.
4517         * guile/guile-internal.h: Rename include guard.
4518         * gnu-nat.h: Rename include guard.
4519         * gdb-stabs.h: Rename include guard.
4520         * frv-tdep.h: Add include guard.
4521         * f-lang.h: Add include guard.
4522         * event-loop.h: Add include guard.
4523         * darwin-nat.h: Rename include guard.
4524         * cp-abi.h: Rename include guard.
4525         * config/sparc/nm-sol2.h: Rename include guard.
4526         * config/nm-nto.h: Rename include guard.
4527         * config/nm-linux.h: Add include guard.
4528         * config/i386/nm-i386gnu.h: Rename include guard.
4529         * config/djgpp/nl_types.h: Rename include guard.
4530         * config/djgpp/langinfo.h: Rename include guard.
4531         * compile/gcc-cp-plugin.h: Add include guard.
4532         * compile/gcc-c-plugin.h: Add include guard.
4533         * compile/compile.h: Rename include guard.
4534         * compile/compile-object-run.h: Rename include guard.
4535         * compile/compile-object-load.h: Rename include guard.
4536         * compile/compile-internal.h: Rename include guard.
4537         * compile/compile-cplus.h: Rename include guard.
4538         * compile/compile-c.h: Rename include guard.
4539         * common/xml-utils.h: Rename include guard.
4540         * common/x86-xstate.h: Rename include guard.
4541         * common/version.h: Rename include guard.
4542         * common/vec.h: Rename include guard.
4543         * common/tdesc.h: Rename include guard.
4544         * common/selftest.h: Rename include guard.
4545         * common/scoped_restore.h: Rename include guard.
4546         * common/scoped_mmap.h: Rename include guard.
4547         * common/scoped_fd.h: Rename include guard.
4548         * common/safe-iterator.h: Rename include guard.
4549         * common/run-time-clock.h: Rename include guard.
4550         * common/refcounted-object.h: Rename include guard.
4551         * common/queue.h: Rename include guard.
4552         * common/ptid.h: Rename include guard.
4553         * common/print-utils.h: Rename include guard.
4554         * common/preprocessor.h: Rename include guard.
4555         * common/pathstuff.h: Rename include guard.
4556         * common/observable.h: Rename include guard.
4557         * common/netstuff.h: Rename include guard.
4558         * common/job-control.h: Rename include guard.
4559         * common/host-defs.h: Rename include guard.
4560         * common/gdb_wait.h: Rename include guard.
4561         * common/gdb_vecs.h: Rename include guard.
4562         * common/gdb_unlinker.h: Rename include guard.
4563         * common/gdb_unique_ptr.h: Rename include guard.
4564         * common/gdb_tilde_expand.h: Rename include guard.
4565         * common/gdb_sys_time.h: Rename include guard.
4566         * common/gdb_string_view.h: Rename include guard.
4567         * common/gdb_splay_tree.h: Rename include guard.
4568         * common/gdb_setjmp.h: Rename include guard.
4569         * common/gdb_ref_ptr.h: Rename include guard.
4570         * common/gdb_optional.h: Rename include guard.
4571         * common/gdb_locale.h: Rename include guard.
4572         * common/gdb_assert.h: Rename include guard.
4573         * common/filtered-iterator.h: Rename include guard.
4574         * common/filestuff.h: Rename include guard.
4575         * common/fileio.h: Rename include guard.
4576         * common/environ.h: Rename include guard.
4577         * common/common-utils.h: Rename include guard.
4578         * common/common-types.h: Rename include guard.
4579         * common/common-regcache.h: Rename include guard.
4580         * common/common-inferior.h: Rename include guard.
4581         * common/common-gdbthread.h: Rename include guard.
4582         * common/common-exceptions.h: Rename include guard.
4583         * common/common-defs.h: Rename include guard.
4584         * common/common-debug.h: Rename include guard.
4585         * common/cleanups.h: Rename include guard.
4586         * common/buffer.h: Rename include guard.
4587         * common/btrace-common.h: Rename include guard.
4588         * common/break-common.h: Rename include guard.
4589         * cli/cli-utils.h: Rename include guard.
4590         * cli/cli-style.h: Rename include guard.
4591         * cli/cli-setshow.h: Rename include guard.
4592         * cli/cli-script.h: Rename include guard.
4593         * cli/cli-interp.h: Rename include guard.
4594         * cli/cli-decode.h: Rename include guard.
4595         * cli/cli-cmds.h: Rename include guard.
4596         * charset-list.h: Add include guard.
4597         * buildsym-legacy.h: Rename include guard.
4598         * bfin-tdep.h: Add include guard.
4599         * ax.h: Rename include guard.
4600         * arm-linux-tdep.h: Add include guard.
4601         * arm-fbsd-tdep.h: Add include guard.
4602         * arch/xtensa.h: Rename include guard.
4603         * arch/tic6x.h: Add include guard.
4604         * arch/i386.h: Add include guard.
4605         * arch/arm.h: Rename include guard.
4606         * arch/arm-linux.h: Rename include guard.
4607         * arch/arm-get-next-pcs.h: Rename include guard.
4608         * arch/amd64.h: Add include guard.
4609         * arch/aarch64-insn.h: Rename include guard.
4610         * arch-utils.h: Rename include guard.
4611         * annotate.h: Add include guard.
4612         * amd64-darwin-tdep.h: Rename include guard.
4613         * aarch64-linux-tdep.h: Add include guard.
4614         * aarch64-fbsd-tdep.h: Add include guard.
4615         * aarch32-linux-nat.h: Add include guard.
4616
4617 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4618
4619         * macrotab.c (macro_define_internal): New function that
4620         factorizes macro_define_object_internal and macro_define_function
4621         code.
4622         (macro_define_object_internal): Use macro_define_internal.
4623         (macro_define_function): Likewise.
4624
4625 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4626
4627         * macrocmd.c (extract_identifier): Return
4628         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4629         callers.
4630
4631 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4632
4633         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4634
4635 2019-02-05  Tom Tromey  <tom@tromey.com>
4636
4637         * target.c (target_stack::unpush): Move assertion earlier.
4638
4639 2019-01-30  Tom Tromey  <tom@tromey.com>
4640
4641         PR python/23615:
4642         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4643         (gdbpy_parse_and_eval): Likewise.
4644         * python/python-internal.h (gdbpy_allow_threads): New class.
4645
4646 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4647
4648         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4649         (aarch64_fbsd_fpregmap): Move earlier.
4650         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4651         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4652         instead of individual calls to trad_frame_set_reg_addr.
4653         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4654         earlier.
4655         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4656         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4657         instead of individual calls to trad_frame_set_reg_addr.
4658
4659 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4660
4661         * CONTRIBUTE: Replace contribution list with wiki link.
4662
4663 2019-01-25  Tom Tromey  <tom@tromey.com>
4664
4665         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4666
4667 2019-01-25  Tom Tromey  <tom@tromey.com>
4668
4669         * xtensa-linux-nat.c: Fix common/ includes.
4670         * xml-support.h: Fix common/ includes.
4671         * xml-support.c: Fix common/ includes.
4672         * x86-linux-nat.c: Fix common/ includes.
4673         * windows-nat.c: Fix common/ includes.
4674         * varobj.h: Fix common/ includes.
4675         * varobj.c: Fix common/ includes.
4676         * value.c: Fix common/ includes.
4677         * valops.c: Fix common/ includes.
4678         * utils.c: Fix common/ includes.
4679         * unittests/xml-utils-selftests.c: Fix common/ includes.
4680         * unittests/utils-selftests.c: Fix common/ includes.
4681         * unittests/unpack-selftests.c: Fix common/ includes.
4682         * unittests/tracepoint-selftests.c: Fix common/ includes.
4683         * unittests/style-selftests.c: Fix common/ includes.
4684         * unittests/string_view-selftests.c: Fix common/ includes.
4685         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4686         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4687         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4688         * unittests/rsp-low-selftests.c: Fix common/ includes.
4689         * unittests/parse-connection-spec-selftests.c: Fix common/
4690         includes.
4691         * unittests/optional-selftests.c: Fix common/ includes.
4692         * unittests/offset-type-selftests.c: Fix common/ includes.
4693         * unittests/observable-selftests.c: Fix common/ includes.
4694         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4695         * unittests/memrange-selftests.c: Fix common/ includes.
4696         * unittests/memory-map-selftests.c: Fix common/ includes.
4697         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4698         * unittests/function-view-selftests.c: Fix common/ includes.
4699         * unittests/environ-selftests.c: Fix common/ includes.
4700         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4701         * unittests/common-utils-selftests.c: Fix common/ includes.
4702         * unittests/cli-utils-selftests.c: Fix common/ includes.
4703         * unittests/array-view-selftests.c: Fix common/ includes.
4704         * ui-file.c: Fix common/ includes.
4705         * tui/tui-io.c: Fix common/ includes.
4706         * tracepoint.h: Fix common/ includes.
4707         * tracepoint.c: Fix common/ includes.
4708         * tracefile-tfile.c: Fix common/ includes.
4709         * top.h: Fix common/ includes.
4710         * top.c: Fix common/ includes.
4711         * thread.c: Fix common/ includes.
4712         * target/waitstatus.h: Fix common/ includes.
4713         * target/waitstatus.c: Fix common/ includes.
4714         * target.h: Fix common/ includes.
4715         * target.c: Fix common/ includes.
4716         * target-memory.c: Fix common/ includes.
4717         * target-descriptions.c: Fix common/ includes.
4718         * symtab.h: Fix common/ includes.
4719         * symfile.c: Fix common/ includes.
4720         * stap-probe.c: Fix common/ includes.
4721         * spu-linux-nat.c: Fix common/ includes.
4722         * sparc-nat.c: Fix common/ includes.
4723         * source.c: Fix common/ includes.
4724         * solib.c: Fix common/ includes.
4725         * solib-target.c: Fix common/ includes.
4726         * ser-unix.c: Fix common/ includes.
4727         * ser-tcp.c: Fix common/ includes.
4728         * ser-pipe.c: Fix common/ includes.
4729         * ser-base.c: Fix common/ includes.
4730         * selftest-arch.c: Fix common/ includes.
4731         * s12z-tdep.c: Fix common/ includes.
4732         * rust-exp.y: Fix common/ includes.
4733         * rs6000-aix-tdep.c: Fix common/ includes.
4734         * riscv-tdep.c: Fix common/ includes.
4735         * remote.c: Fix common/ includes.
4736         * remote-notif.h: Fix common/ includes.
4737         * remote-fileio.h: Fix common/ includes.
4738         * remote-fileio.c: Fix common/ includes.
4739         * regcache.h: Fix common/ includes.
4740         * regcache.c: Fix common/ includes.
4741         * record-btrace.c: Fix common/ includes.
4742         * python/python.c: Fix common/ includes.
4743         * python/py-type.c: Fix common/ includes.
4744         * python/py-inferior.c: Fix common/ includes.
4745         * progspace.h: Fix common/ includes.
4746         * producer.c: Fix common/ includes.
4747         * procfs.c: Fix common/ includes.
4748         * proc-api.c: Fix common/ includes.
4749         * printcmd.c: Fix common/ includes.
4750         * ppc-linux-nat.c: Fix common/ includes.
4751         * parser-defs.h: Fix common/ includes.
4752         * osdata.c: Fix common/ includes.
4753         * obsd-nat.c: Fix common/ includes.
4754         * nat/x86-linux.c: Fix common/ includes.
4755         * nat/x86-linux-dregs.c: Fix common/ includes.
4756         * nat/x86-dregs.h: Fix common/ includes.
4757         * nat/x86-dregs.c: Fix common/ includes.
4758         * nat/ppc-linux.c: Fix common/ includes.
4759         * nat/mips-linux-watch.h: Fix common/ includes.
4760         * nat/mips-linux-watch.c: Fix common/ includes.
4761         * nat/linux-waitpid.c: Fix common/ includes.
4762         * nat/linux-ptrace.h: Fix common/ includes.
4763         * nat/linux-ptrace.c: Fix common/ includes.
4764         * nat/linux-procfs.c: Fix common/ includes.
4765         * nat/linux-personality.c: Fix common/ includes.
4766         * nat/linux-osdata.c: Fix common/ includes.
4767         * nat/linux-namespaces.c: Fix common/ includes.
4768         * nat/linux-btrace.h: Fix common/ includes.
4769         * nat/linux-btrace.c: Fix common/ includes.
4770         * nat/fork-inferior.c: Fix common/ includes.
4771         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4772         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4773         * nat/aarch64-linux.c: Fix common/ includes.
4774         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4775         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4776         * namespace.h: Fix common/ includes.
4777         * mips-linux-tdep.c: Fix common/ includes.
4778         * minsyms.c: Fix common/ includes.
4779         * mi/mi-parse.h: Fix common/ includes.
4780         * mi/mi-main.c: Fix common/ includes.
4781         * mi/mi-cmd-env.c: Fix common/ includes.
4782         * memrange.h: Fix common/ includes.
4783         * memattr.c: Fix common/ includes.
4784         * maint.h: Fix common/ includes.
4785         * maint.c: Fix common/ includes.
4786         * main.c: Fix common/ includes.
4787         * machoread.c: Fix common/ includes.
4788         * location.c: Fix common/ includes.
4789         * linux-thread-db.c: Fix common/ includes.
4790         * linux-nat.c: Fix common/ includes.
4791         * linux-fork.c: Fix common/ includes.
4792         * inline-frame.c: Fix common/ includes.
4793         * infrun.c: Fix common/ includes.
4794         * inflow.c: Fix common/ includes.
4795         * inferior.h: Fix common/ includes.
4796         * inferior.c: Fix common/ includes.
4797         * infcmd.c: Fix common/ includes.
4798         * inf-ptrace.c: Fix common/ includes.
4799         * inf-child.c: Fix common/ includes.
4800         * ia64-linux-nat.c: Fix common/ includes.
4801         * i387-tdep.c: Fix common/ includes.
4802         * i386-tdep.c: Fix common/ includes.
4803         * i386-linux-tdep.c: Fix common/ includes.
4804         * i386-linux-nat.c: Fix common/ includes.
4805         * i386-go32-tdep.c: Fix common/ includes.
4806         * i386-fbsd-tdep.c: Fix common/ includes.
4807         * i386-fbsd-nat.c: Fix common/ includes.
4808         * guile/scm-type.c: Fix common/ includes.
4809         * guile/guile.c: Fix common/ includes.
4810         * go32-nat.c: Fix common/ includes.
4811         * gnu-nat.c: Fix common/ includes.
4812         * gdbthread.h: Fix common/ includes.
4813         * gdbarch-selftests.c: Fix common/ includes.
4814         * gdb_usleep.c: Fix common/ includes.
4815         * gdb_select.h: Fix common/ includes.
4816         * gdb_bfd.c: Fix common/ includes.
4817         * gcore.c: Fix common/ includes.
4818         * fork-child.c: Fix common/ includes.
4819         * findvar.c: Fix common/ includes.
4820         * fbsd-nat.c: Fix common/ includes.
4821         * event-top.c: Fix common/ includes.
4822         * event-loop.c: Fix common/ includes.
4823         * dwarf2read.c: Fix common/ includes.
4824         * dwarf2loc.c: Fix common/ includes.
4825         * dwarf2-frame.c: Fix common/ includes.
4826         * dwarf-index-cache.c: Fix common/ includes.
4827         * dtrace-probe.c: Fix common/ includes.
4828         * disasm-selftests.c: Fix common/ includes.
4829         * defs.h: Fix common/ includes.
4830         * csky-tdep.c: Fix common/ includes.
4831         * cp-valprint.c: Fix common/ includes.
4832         * cp-support.h: Fix common/ includes.
4833         * cp-support.c: Fix common/ includes.
4834         * corelow.c: Fix common/ includes.
4835         * completer.h: Fix common/ includes.
4836         * completer.c: Fix common/ includes.
4837         * compile/compile.c: Fix common/ includes.
4838         * compile/compile-loc2c.c: Fix common/ includes.
4839         * compile/compile-cplus-types.c: Fix common/ includes.
4840         * compile/compile-cplus-symbols.c: Fix common/ includes.
4841         * command.h: Fix common/ includes.
4842         * cli/cli-dump.c: Fix common/ includes.
4843         * cli/cli-cmds.c: Fix common/ includes.
4844         * charset.c: Fix common/ includes.
4845         * build-id.c: Fix common/ includes.
4846         * btrace.h: Fix common/ includes.
4847         * btrace.c: Fix common/ includes.
4848         * breakpoint.h: Fix common/ includes.
4849         * breakpoint.c: Fix common/ includes.
4850         * ax.h:
4851         (enum agent_op): Fix common/ includes.
4852         * ax-general.c (struct aop_map): Fix common/ includes.
4853         * ax-gdb.c: Fix common/ includes.
4854         * auxv.c: Fix common/ includes.
4855         * auto-load.c: Fix common/ includes.
4856         * arm-tdep.c: Fix common/ includes.
4857         * arch/riscv.c: Fix common/ includes.
4858         * arch/ppc-linux-common.c: Fix common/ includes.
4859         * arch/i386.c: Fix common/ includes.
4860         * arch/arm.c: Fix common/ includes.
4861         * arch/arm-linux.c: Fix common/ includes.
4862         * arch/arm-get-next-pcs.c: Fix common/ includes.
4863         * arch/amd64.c: Fix common/ includes.
4864         * arch/aarch64.c: Fix common/ includes.
4865         * arch/aarch64-insn.c: Fix common/ includes.
4866         * arch-utils.c: Fix common/ includes.
4867         * amd64-windows-tdep.c: Fix common/ includes.
4868         * amd64-tdep.c: Fix common/ includes.
4869         * amd64-sol2-tdep.c: Fix common/ includes.
4870         * amd64-obsd-tdep.c: Fix common/ includes.
4871         * amd64-nbsd-tdep.c: Fix common/ includes.
4872         * amd64-linux-tdep.c: Fix common/ includes.
4873         * amd64-linux-nat.c: Fix common/ includes.
4874         * amd64-fbsd-tdep.c: Fix common/ includes.
4875         * amd64-fbsd-nat.c: Fix common/ includes.
4876         * amd64-dicos-tdep.c: Fix common/ includes.
4877         * amd64-darwin-tdep.c: Fix common/ includes.
4878         * agent.c: Fix common/ includes.
4879         * ada-lang.h: Fix common/ includes.
4880         * ada-lang.c: Fix common/ includes.
4881         * aarch64-tdep.c: Fix common/ includes.
4882
4883 2019-01-25  Tom Tromey  <tom@tromey.com>
4884
4885         * common/create-version.sh: Use common/version.h.
4886
4887 2019-01-24  Pedro Alves  <palves@redhat.com>
4888
4889         * infrun.c (signal_stop, signal_print, signal_program)
4890         (signal_catch, signal_pass): Now arrays instead of pointers.
4891         (update_signals_program_target, do_target_resume)
4892         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4893         * linux-nat.c (linux_nat_target::pass_signals)
4894         (linux_nat_target::create_inferior, linux_nat_target::attach):
4895         Adjust.
4896         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4897         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4898         * procfs.c (procfs_target::pass_signals): Adjust.
4899         * record-full.c (record_full_target::resume): Adjust.
4900         * remote.c (remote_target::pass_signals)
4901         (remote_target::program_signals): Adjust.
4902         * target-debug.h (target_debug_print_signals): Now takes a
4903         gdb::array_view as parameter.  Adjust.
4904         * target.h (target_ops) <pass_signals, program_signals>: Replace
4905         pointer and length parameters with gdb::array_view.
4906         (target_pass_signals, target_program_signals): Likewise.
4907         * target-delegates.c: Regenerate.
4908
4909 2019-01-24  Pedro Alves  <palves@redhat.com>
4910
4911         * common/forward-scope-exit.h
4912         (forward_scope_exit::forward_scope_exit): Pass arguments to
4913         m_bind_function directly, instead of creating a std::bind and
4914         copying that.
4915
4916 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4917
4918         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4919         for static members.
4920         (pass_in_v_vfp_candidate): Likewise.
4921
4922 2019-01-23  Tom Tromey  <tom@tromey.com>
4923             Pedro Alves  <palves@redhat.com>
4924
4925         * regcache.c (class regcache_invalidator): Remove.
4926         (regcache::raw_write): Use make_scope_exit.
4927
4928 2019-01-23  Tom Tromey  <tom@tromey.com>
4929
4930         * ui-out.h (class ui_out_emit_type): Update comment.
4931
4932 2019-01-23  Tom Tromey  <tom@tromey.com>
4933
4934         * infrun.c (fetch_inferior_event): Update comment.
4935
4936 2019-01-23  Tom Tromey  <tom@tromey.com>
4937             Pedro Alves  <palves@redhat.com>
4938
4939         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4940         parameter.
4941         (fetch_inferior_event): Use SCOPE_EXIT.
4942
4943
4944 2019-01-23  Tom Tromey  <tom@tromey.com>
4945             Pedro Alves  <palves@redhat.com>
4946
4947         * infrun.c (disable_thread_events): Delete.
4948         (stop_all_threads): Use SCOPE_EXIT.
4949
4950 2019-01-23  Tom Tromey  <tom@tromey.com>
4951             Pedro Alves  <palves@redhat.com>
4952
4953         * symfile.c: Include forward-scope-exit.h.
4954         (clear_symtab_users_cleanup): Replace forward declaration with
4955         a FORWARD_SCOPE_EXIT.
4956         (syms_from_objfile_1): Use the forward_scope_exit and
4957         gdb::optional instead of cleanup_function.
4958         (reread_symbols): Use the forward_scope_exit instead of
4959         cleanup_function.
4960         (clear_symtab_users_cleanup): Remove function.
4961
4962 2019-01-23  Tom Tromey  <tom@tromey.com>
4963             Pedro Alves  <palves@redhat.com>
4964
4965         * linux-nat.c: Include scope-exit.h.
4966         (cleanup_target_stop): Remove.
4967         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4968         SCOPE_EXIT.
4969
4970 2019-01-23  Tom Tromey  <tom@tromey.com>
4971             Pedro Alves  <palves@redhat.com>
4972
4973         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4974         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4975
4976 2019-01-23  Tom Tromey  <tom@tromey.com>
4977             Andrew Burgess  <andrew.burgess@embecosm.com>
4978             Pedro Alves  <palves@redhat.com>
4979
4980         * infrun.c (fetch_inferior_event): Use scope_exit.
4981         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4982         * top.c (execute_command): Use scope_exit.
4983         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4984         * utils.c (do_bpstat_clear_actions_cleanup)
4985         (make_bpstat_clear_actions_cleanup): Remove.
4986
4987 2019-01-23  Tom Tromey  <tom@tromey.com>
4988             Pedro Alves  <palves@redhat.com>
4989
4990         * infrun.c: Include "common/scope-exit.h"
4991         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4992         (wait_for_inferior): Use SCOPE_EXIT.
4993         (fetch_inferior_event): Use scope_exit.
4994
4995 2019-01-23  Tom Tromey  <tom@tromey.com>
4996             Pedro Alves  <palves@redhat.com>
4997
4998         * breakpoint.c (create_breakpoint): Remove cleanup.
4999
5000 2019-01-23  Tom Tromey  <tom@tromey.com>
5001             Andrew Burgess  <andrew.burgess@embecosm.com>
5002             Pedro Alves  <palves@redhat.com>
5003
5004 2019-01-23  Pedro Alves  <palves@redhat.com>
5005
5006         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5007
5008 2019-01-23  Pedro Alves  <palves@redhat.com>
5009             Andrew Burgess  <andrew.burgess@embecosm.com>
5010
5011         * gdbthread.h: Include "common/forward-scope-exit.h".
5012         (scoped_finish_thread_state): Redefine custom class in terms of
5013         forward_scope_exit.
5014
5015 2019-01-23  Pedro Alves  <palves@redhat.com>
5016             Andrew Burgess  <andrew.burgess@embecosm.com>
5017
5018         * common/forward-scope-exit.h: New file.
5019
5020 2019-01-23  Pedro Alves  <palves@redhat.com>
5021             Andrew Burgess  <andrew.burgess@embecosm.com>
5022             Tom Tromey  <tom@tromey.com>
5023
5024         * common/scope-exit.h: New file.
5025
5026 2019-01-23  Pedro Alves  <palves@redhat.com>
5027
5028         * common/preprocessor.h (ESC): Rename to ...
5029         (ESC_PARENS): ... this.
5030         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5031         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5032
5033 2019-01-23  Tom Tromey  <tom@tromey.com>
5034
5035         * language.h (class scoped_switch_to_sym_language_if_auto):
5036         Initialize m_lang in both cases.
5037
5038 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5039
5040         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5041         with XCNEW.
5042
5043 2019-01-22  Tom Tromey  <tom@tromey.com>
5044
5045         * corelow.c: Do not include sys/file.h.
5046
5047 2019-01-22  Tom Tromey  <tom@tromey.com>
5048
5049         * tui/tui-wingeneral.h: Include gdb_curses.h.
5050
5051 2019-01-22  Tom Tromey  <tom@tromey.com>
5052
5053         * source-cache.h (class source_cache) <get_source_lines,
5054         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5055
5056 2019-01-22  Tom Tromey  <tom@tromey.com>
5057
5058         * remote-fileio.h (struct remote_target): Declare.
5059
5060 2019-01-22  Tom Tromey  <tom@tromey.com>
5061
5062         * python/py-arch.c: Do not include py-ref.h.
5063         * python/py-bpevent.c: Do not include py-ref.h.
5064         * python/py-cmd.c: Do not include py-ref.h.
5065         * python/py-continueevent.c: Do not include py-ref.h.
5066         * python/py-event.h: Do not include py-ref.h.
5067         * python/py-evtregistry.c: Do not include py-ref.h.
5068         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5069         * python/py-frame.c: Do not include py-ref.h.
5070         * python/py-framefilter.c: Do not include py-ref.h.
5071         * python/py-function.c: Do not include py-ref.h.
5072         * python/py-infevents.c: Do not include py-ref.h.
5073         * python/py-linetable.c: Do not include py-ref.h.
5074         * python/py-objfile.c: Do not include py-ref.h.
5075         * python/py-param.c: Do not include py-ref.h.
5076         * python/py-prettyprint.c: Do not include py-ref.h.
5077         * python/py-progspace.c: Do not include py-ref.h.
5078         * python/py-symbol.c: Do not include py-ref.h.
5079         * python/py-symtab.c: Do not include py-ref.h.
5080         * python/py-type.c: Do not include py-ref.h.
5081         * python/py-unwind.c: Do not include py-ref.h.
5082         * python/py-utils.c: Do not include py-ref.h.
5083         * python/py-value.c: Do not include py-ref.h.
5084         * python/py-varobj.c: Do not include py-ref.h.
5085         * python/py-xmethods.c: Do not include py-ref.h.
5086         * python/python.c: Do not include py-ref.h.
5087         * varobj.c: Do not include py-ref.h.
5088
5089 2019-01-22  Tom Tromey  <tom@tromey.com>
5090
5091         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5092         keyword for bcache.
5093
5094 2019-01-22  Tom Tromey  <tom@tromey.com>
5095
5096         * compile/compile-cplus-types.c: Remove a comment by #include.
5097
5098 2019-01-22  Tom Tromey  <tom@tromey.com>
5099
5100         * compile/gcc-c-plugin.h: Include compile-internal.h.
5101
5102 2019-01-22  Tom Tromey  <tom@tromey.com>
5103
5104         * stabsread.c (EXTERN): Do not define.
5105         (symnum, next_symbol_text_func, processing_gcc_compilation)
5106         (within_function, global_sym_chain, global_stabs)
5107         (previous_stab_code, this_object_header_files)
5108         (n_this_object_header_files)
5109         (n_allocated_this_object_header_files): Define.
5110         * stabsread.h (EXTERN): Never define.  Use "extern".
5111
5112 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5113
5114         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5115         history_value.
5116
5117 2019-01-21  Tom Tromey  <tom@tromey.com>
5118
5119         * ui-out.c: Fix includes.
5120         * tui/tui-source.c: Fix includes.
5121         * target.c: Fix includes.
5122         * remote.c: Fix includes.
5123         * regcache.c: Fix includes.
5124         * python/py-block.c: Fix includes.
5125         * printcmd.c: Fix includes.
5126         * or1k-tdep.c: Fix includes.
5127         * mi/mi-main.c: Fix includes.
5128         * m32r-tdep.c: Fix includes.
5129         * csky-tdep.c: Fix includes.
5130         * compile/compile-cplus-types.c: Fix includes.
5131         * cli/cli-interp.c: Fix includes.
5132
5133 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5134
5135         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5136         for padding.
5137
5138 2019-01-16  Tom Tromey  <tom@tromey.com>
5139
5140         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5141         earlier.
5142         (struct objfile) <msymbols_range>: Move from top level.
5143         <msymbols>: New method.
5144         (class objfile_msymbols): Remove.
5145         * symtab.c (default_collect_symbol_completion_matches_break_on):
5146         Update.
5147         * symmisc.c (dump_msymbols): Update.
5148         * stabsread.c (scan_file_globals): Update.
5149         * objc-lang.c (info_selectors_command, info_classes_command)
5150         (find_methods): Update.
5151         * minsyms.c (find_solib_trampoline_target): Update.
5152         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5153         * coffread.c (coff_symfile_read): Update.
5154         * ada-lang.c (ada_lookup_simple_minsym)
5155         (ada_collect_symbol_completion_matches): Update.
5156
5157 2019-01-16  Tom Tromey  <tom@tromey.com>
5158
5159         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5160         type.  Remove no-argument constructor.
5161         <iterator::operator++>: Simplify.
5162         <begin>: Update.
5163         <end>: Use minimal_symbol_count.
5164
5165 2019-01-16  Tom Tromey  <tom@tromey.com>
5166
5167         * objfiles.h (struct objfile) <psymtabs>: New method.
5168         (class objfile_psymtabs): Remove.
5169         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5170         typedef.
5171         <range>: New method.
5172         (require_partial_symbols): Change return type.
5173         * psymtab.c (require_partial_symbols)
5174         (psym_expand_symtabs_matching): Update.
5175         * mdebugread.c (parse_partial_symbols): Update.
5176         * dbxread.c (dbx_end_psymtab): Update.
5177
5178 2019-01-15  Tom Tromey  <tom@tromey.com>
5179
5180         * symtab.c (lookup_objfile_from_block)
5181         (lookup_symbol_in_objfile_symtabs)
5182         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5183         (find_line_symtab, info_sources_command)
5184         (default_collect_symbol_completion_matches_break_on)
5185         (make_source_files_completion_list): Update.
5186         * symmisc.c (print_objfile_statistics, dump_objfile)
5187         (maintenance_print_symbols, maintenance_info_symtabs)
5188         (maintenance_check_symtabs, maintenance_info_line_tables):
5189         Update.
5190         * source.c (select_source_symtab)
5191         (forget_cached_source_info_for_objfile): Update.
5192         * objfiles.h (class objfile_compunits): Remove.
5193         (struct objfile) <compunits_range>: New typedef.
5194         (compunits): New method.
5195         * objfiles.c (objfile_relocate1): Update.
5196         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5197         * maint.c (count_symtabs_and_blocks): Update.
5198         * linespec.c (iterate_over_all_matching_symtabs): Update.
5199         * cp-support.c (add_symbol_overload_list_qualified): Update.
5200         * coffread.c (coff_symtab_read): Update.
5201         * ada-lang.c (add_nonlocal_symbols)
5202         (ada_collect_symbol_completion_matches)
5203         (ada_add_global_exceptions): Update.
5204
5205 2019-01-15  Tom Tromey  <tom@tromey.com>
5206
5207         * progspace.h (program_space) <objfiles_safe_range>: New
5208         typedef.
5209         <objfiles_safe>: New method.
5210         * objfiles.h (class all_objfiles_safe): Remove.
5211         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5212         * jit.c (jit_inferior_exit_hook): Update.
5213
5214 2019-01-17  Tom Tromey  <tom@tromey.com>
5215
5216         * progspace.h (program_space) <objfiles_range>: New typedef.
5217         <objfiles>: New method.
5218         <objfiles_head>: Rename from objfiles.
5219         (object_files): Update.
5220         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5221         * guile/scm-pretty-print.c
5222         (ppscm_find_pretty_printer_from_objfiles): Update.
5223         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5224         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5225         Update.
5226         * python/py-progspace.c (pspy_get_objfiles): Update.
5227         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5228         Update.
5229         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5230         (objfpy_lookup_objfile_by_build_id): Update.
5231         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5232         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5233         Update.
5234         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5235         (expand_symtab_containing_pc, lookup_objfile_from_block)
5236         (lookup_static_symbol, basic_lookup_transparent_type)
5237         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5238         (find_line_symtab, info_sources_command)
5239         (default_collect_symbol_completion_matches_break_on)
5240         (make_source_files_completion_list, find_main_name): Update.
5241         * symmisc.c (print_symbol_bcache_statistics)
5242         (print_objfile_statistics, maintenance_print_symbols)
5243         (maintenance_print_msymbols, maintenance_print_objfiles)
5244         (maintenance_info_symtabs, maintenance_check_symtabs)
5245         (maintenance_expand_symtabs, maintenance_info_line_tables):
5246         Update.
5247         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5248         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5249         (map_overlay_command, unmap_overlay_command)
5250         (simple_overlay_update, expand_symtabs_matching)
5251         (map_symbol_filenames): Update.
5252         * symfile-debug.c (set_debug_symfile): Update.
5253         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5254         Update.
5255         * source.c (select_source_symtab, forget_cached_source_info):
5256         Update.
5257         * solib.c (solib_read_symbols): Update.
5258         * solib-spu.c (append_ocl_sos): Update.
5259         * psymtab.c (maintenance_print_psymbols)
5260         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5261         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5262         * printcmd.c (info_symbol_command): Update.
5263         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5264         Update.
5265         * objfiles.h (class all_objfiles): Remove.
5266         * objfiles.c (have_partial_symbols, have_full_symbols)
5267         (have_minimal_symbols, qsort_cmp, update_section_map)
5268         (shared_objfile_contains_address_p)
5269         (default_iterate_over_objfiles_in_search_order): Update.
5270         * objc-lang.c (info_selectors_command, info_classes_command)
5271         (find_methods): Update.
5272         * minsyms.c (find_solib_trampoline_target): Update.
5273         * maint.c (maintenance_info_sections)
5274         (maintenance_translate_address, count_symtabs_and_blocks):
5275         Update.
5276         * main.c (captured_main_1): Update.
5277         * linux-thread-db.c (try_thread_db_load_from_pdir)
5278         (has_libpthread): Update.
5279         * linespec.c (iterate_over_all_matching_symtabs)
5280         (search_minsyms_for_name): Update.
5281         * jit.c (jit_find_objf_with_entry_addr): Update.
5282         * hppa-tdep.c (find_unwind_entry)
5283         (hppa_lookup_stub_minimal_symbol): Update.
5284         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5285         Update.
5286         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5287         (elf_gnu_ifunc_resolve_by_got): Update.
5288         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5289         * dwarf-index-write.c (save_gdb_index_command): Update.
5290         * cp-support.c (add_symbol_overload_list_qualified): Update.
5291         * breakpoint.c (create_overlay_event_breakpoint)
5292         (create_longjmp_master_breakpoint)
5293         (create_std_terminate_master_breakpoint)
5294         (create_exception_master_breakpoint): Update.
5295         * blockframe.c (find_pc_partial_function): Update.
5296         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5297         (ada_collect_symbol_completion_matches)
5298         (ada_add_global_exceptions): Update.
5299
5300 2019-01-17  Tom Tromey  <tom@tromey.com>
5301
5302         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5303         declare VEC.
5304         (solib_target_parse_libraries): Change return type.
5305         (library_list_start_segment, library_list_start_section)
5306         (library_list_end_library, library_list_start_library); Update.
5307         (solib_target_free_library_list): Remove.
5308         (solib_target_parse_libraries): Remove cleanup.  Change return
5309         type.
5310         (solib_target_current_sos): Update.
5311
5312 2019-01-17  Tom Tromey  <tromey@bapiya>
5313
5314         * valprint.c: Replace "the the" with "the".
5315         * symtab.c: Replace "the the" with "the".
5316         * solib.c: Replace "the the" with "the".
5317         * solib-dsbt.c: Replace "the the" with "the".
5318         * linespec.c: Replace "the the" with "the".
5319         * dwarf2loc.h: Replace "the the" with "the".
5320         * amd64-windows-tdep.c: Replace "the the" with "the".
5321         * aarch64-tdep.c: Replace "the the" with "the".
5322
5323 2019-01-16  Keith Seitz  <keiths@redhat.com>
5324
5325         PR gdb/23773
5326         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5327         <builder>: Rename to ..
5328         <m_builder>: ... this and make private.
5329         (dwarf2_cu::get_builder): New method.  Change all users of
5330         `builder' to use this method.
5331         (dwarf2_start_symtab): Move to ...
5332         (dwarf2_cu::start_symtab): ... here.  Update all callers
5333         (setup_type_unit_groups): Move to ...
5334         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5335         callers.
5336         (dwarf2_cu::reset_builder): New method.
5337         (process_full_compunit, process_full_type_unit): Use
5338         dwarf2_cu::reset_builder.
5339         (follow_die_offset): Record the ancestor CU if it is different
5340         from the followed DIE's CU.
5341         (follow_die_sig_1): Likewise.
5342
5343 2019-01-15  Tom Tromey  <tom@tromey.com>
5344
5345         * remote.c (class remote_state) <buf>: Now a char_vector.
5346         <buf_size>: Remove.
5347         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5348         parameter.
5349         (remote_target::getpkt_or_notif_sane_1)
5350         (remote_target::getpkt_sane)
5351         (remote_target::getpkt_or_notif_sane): Likewise.
5352         (class remote_target) <putpkt>: New overload.
5353         (remote_target::read_frame): Change type of "buf_p".  Remove
5354         sizeof_p parameter.
5355         (packet_ok): New overload.
5356         (packet_check_result): New overload.
5357         Update all uses.
5358
5359 2019-01-14  Tom Tromey  <tom@tromey.com>
5360
5361         * remote-notif.c (handle_notification, remote_notif_ack)
5362         (remote_notif_parse): Make "buf" const.
5363         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5364         const.
5365         (remote_notif_parse, remote_notif_ack, handle_notification):
5366         Likewise.
5367         * remote.c (remote_notif_stop_parse): Make "buf" const.
5368         (remote_target::remote_parse_stop_reply): Make "buf" const.
5369         (remote_notif_stop_ack): Make "buf" const.
5370
5371 2019-01-14  Tom Tromey  <tom@tromey.com>
5372
5373         * remote.c (remote_console_output): Make parameter const.
5374
5375 2019-01-14  Tom Tromey  <tom@tromey.com>
5376
5377         * target-debug.h (target_debug_print_signals): Constify.
5378         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5379         * procfs.c (procfs_target::pass_signals): Update.
5380         * linux-nat.c (linux_nat_target::pass_signals): Update.
5381         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5382         * target-delegates.c: Rebuild.
5383         * remote.c (remote_target::program_signals): Update.
5384         (remote_target::pass_signals): Update.
5385         * target.c (target_pass_signals): Constify argument.
5386         (target_program_signals): Likewise.
5387         * target.h (struct target_ops) <pass_signals, program_signals>:
5388         Constify argument.
5389         (target_pass_signals, target_program_signals): Constify argument.
5390
5391 2019-01-14  Tom Tromey  <tom@tromey.com>
5392
5393         PR tui/28819:
5394         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5395
5396 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5397
5398         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5399         field.
5400         * rs6000-tdep.c: Include reggroups.h.
5401         (IS_V_ALIAS_PSEUDOREG): Define.
5402         (rs6000_register_name): Return names for the "vX" aliases.
5403         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5404         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5405         aliases.  Call default_register_reggroup_p for all other
5406         pseudo-registers.
5407         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5408         New functions.
5409         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5410         Handle "vX" aliases.
5411         (v_alias_pseudo_register_collect): New function.
5412         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5413         (rs6000_gdbarch_init): Initialize "vX" aliases as
5414         pseudo-registers.  Restore registration of
5415         rs6000_pseudo_register_reggroup_p with
5416         set_tdesc_pseudo_register_reggroup_p.
5417
5418 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5419
5420         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5421         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5422         set_gdbarch_num_pseudo_regs.
5423
5424 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5425
5426         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5427         Remove arg prefixname, add do_set and do_show.
5428         Add member functions set_list and show_list.
5429         * cli/cli-style.c (class cli_style_option): Update accordingly.
5430         (style_set_list): Move to file scope.
5431         (style_show_list): Likewise.
5432         (set_style): Call help_list.
5433         (show_style): Call cmd_show_list.
5434         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5435         Update to use the new macro.
5436
5437 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5438
5439         * ada-lang.c (_initialize_ada_language): Expand the help text
5440         for the "catch exception" command.
5441
5442 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5443
5444         * symtab.c (matching_obj_sections): Initialize obj,
5445         declare it closer to its usage.
5446
5447 2019-01-10  Tom Tromey  <tom@tromey.com>
5448
5449         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5450         (basic_inf_threads_range): Remove.
5451         (inf_threads_range, inf_non_exited_threads_range)
5452         (safe_inf_threads_range): Use next_adapter.
5453
5454 2019-01-10  Keith Seitz  <keiths@redhat.com>
5455
5456         PR gdb/23712
5457         PR symtab/23010
5458         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5459         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5460
5461 2019-01-10  Keith Seitz  <keiths@redhat.com>
5462
5463         PR gdb/23712
5464         PR symtab/23010
5465         * dictionary.c (pending_to_vector): Remove.
5466         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5467         Remove _1 suffix, replacing functions of the same name.  Update
5468         all callers.
5469         (dict_create_hashed, dict_create_hashed_expandable)
5470         (dict_create_linear, dict_create_linear_expandable, dict_free)
5471         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5472         Make functions static.
5473
5474 2019-01-10  Keith Seitz  <keiths@redhat.com>
5475
5476         PR gdb/23712
5477         PR symtab/23010
5478         * dictionary.h (struct dictionary): Replace declaration with
5479         multidictionary.
5480         (dict_create_hashed, dict_create_hashed_expandable)
5481         (dict_create_linear, dict_create_linear_expandable)
5482         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5483         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5484         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5485         taking multidictionary argument.
5486         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5487         * block.h (struct block) <dict>: Change to multidictionary
5488         and rename `multidict'.
5489         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5490         symmisc.c: Update all dictionary references to multidictionary.
5491
5492 2019-01-10  Keith Seitz  <keiths@redhat.com>
5493
5494         PR gdb/23712
5495         PR symtab/23010
5496         * dictionary.c: Include unordered_map.
5497         (pending_to_vector): New function.
5498         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5499         Rewrite the non-"_1" functions to take vector instead
5500         of linked list.
5501         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5502         "new" _1 versions of the same name.
5503         (multidictionary): Define.
5504         (std::hash<enum language): New definition.
5505         (collate_pending_symbols_by_language, mdict_create_hashed)
5506         (mdict_create_hashed_expandable, mdict_create_linear)
5507         (mdict_create_linear_expandable, mdict_free)
5508         (find_language_dictionary, create_new_language_dictionary)
5509         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5510         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5511         (mdict_size, mdict_empty): New functions.
5512         * dictionary.h (mdict_iterator): Define.
5513
5514 2019-01-10  Pedro Alves  <palves@redhat.com>
5515
5516         * breakpoint.c (read_uploaded_action)
5517         (create_tracepoint_from_upload): Adjust to use
5518         gdb::unique_xmalloc_ptr.
5519         * ctf.c (ctf_write_uploaded_tp):
5520         (SET_ARRAY_FIELD): Use emplace_back.
5521         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5522         * tracefile-tfile.c (tfile_write_uploaded_tp):
5523         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5524         gdb::unique_xmalloc_ptr.
5525         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5526         at_string, cond_string, cmd_strings>: Replace char pointers
5527         with gdb::unique_xmalloc_ptr.
5528
5529 2019-01-10  Pedro Alves  <palves@redhat.com>
5530
5531         * solib-target.c (library_list_start_library): Don't xstrdup name.
5532
5533 2019-01-10  Pedro Alves  <palves@redhat.com>
5534
5535         * mdebugread.c (parse_partial_symbols): Use
5536         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5537
5538 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5539
5540         * linux-fork.c (scoped_switch_fork_info)
5541         <~scoped_switch_fork_info>: Fix incorrect variable name.
5542
5543 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5544
5545         * linux-fork.c (scoped_switch_fork_info)
5546         <scoped_switch_fork_info>: Make explicit.
5547         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5548
5549 2019-01-10  Tom Tromey  <tom@tromey.com>
5550
5551         * objfiles.h (objfile::reset_psymtabs): Update.
5552         * objfiles.c (objfile::objfile): Update.
5553         * psymtab.h (psymtab_storage::obstack): Update.
5554         (psymtab_storage::m_obstack): Use gdb::optional.
5555         (class psymtab_storage): Update comment.  Remove objfile
5556         parameter.
5557         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5558
5559 2019-01-10  Tom Tromey  <tom@tromey.com>
5560
5561         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5562         <free_psymtabs>: Now private.
5563         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5564         (allocate_psymtab): Use new method.
5565
5566 2019-01-10  Tom Tromey  <tom@tromey.com>
5567
5568         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5569         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5570         * mdebugread.c (parse_partial_symbols): Use
5571         allocate_dependencies.
5572         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5573         allocate_dependencies.
5574         (process_psymtab_comp_unit_reader)
5575         (build_type_psymtab_dependencies): Likewise.
5576         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5577
5578 2019-01-10  Tom Tromey  <tom@tromey.com>
5579
5580         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5581         PSYMBOL_SET_LANGUAGE.
5582         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5583
5584 2019-01-10  Tom Tromey  <tom@tromey.com>
5585
5586         * psymtab.h (psymtab_storage::obstack): New method.
5587         <m_obstack>: Rename from obstack; now private.
5588         * psymtab.c (psymtab_storage): Update.
5589         * dwarf2read.c (create_addrmap_from_index)
5590         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5591         Update.
5592
5593 2019-01-10  Tom Tromey  <tom@tromey.com>
5594
5595         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5596         * objfiles.h (objfile::reset_psymtabs): New method.
5597
5598 2019-01-10  Tom Tromey  <tom@tromey.com>
5599
5600         * symmisc.c (print_symbol_bcache_statistics): Update.
5601         (print_objfile_statistics): Update.
5602         * symfile.c (reread_symbols): Update.
5603         * psymtab.h (class psymtab_storage): New.
5604         * psymtab.c (psymtab_storage): New constructor.
5605         (~psymtab_storage): New destructor.
5606         (require_partial_symbols): Update.
5607         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5608         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5609         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5610         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5611         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5612         (start_psymtab_common, end_psymtab_common)
5613         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5614         (allocate_psymtab): Update.
5615         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5616         Update.
5617         (dump_psymtab_addrmap, maintenance_print_psymbols)
5618         (maintenance_check_psymtabs): Update.
5619         (class objfile_psymtabs): Move to objfiles.h.
5620         * psympriv.h (discard_psymtab): Now inline.
5621         (psymtab_discarder::psymtab_discarder): Update.
5622         (psymtab_discarder::~psymtab_discarder): Update.
5623         (ALL_OBJFILE_PSYMTABS): Rewrite.
5624         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5625         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5626         Remove fields.
5627         <partial_symtabs>: New field.
5628         (class objfile_psymtabs): Move from psymtab.h.  Update.
5629         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5630         psymbol_cache.
5631         (objfile::~objfile): Don't destroy psymbol_cache.
5632         * mdebugread.c (parse_partial_symbols): Update.
5633         * dwarf2read.c (create_addrmap_from_index)
5634         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5635         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5636         (add_partial_subprogram, dwarf2_ranges_read): Update.
5637         * dwarf-index-write.c (write_address_map)
5638         (write_one_signatured_type, recursively_write_psymbols)
5639         (class debug_names, class debug_names, write_psymtabs_to_index):
5640         Update.
5641
5642 2019-01-10  Tom Tromey  <tom@tromey.com>
5643
5644         * symtab.h (SYMBOL_SET_NAMES): Update.
5645         (symbol_set_names): Update.
5646         (MSYMBOL_SET_NAMES): Update.
5647         * symtab.c (symbol_set_names): Change argument to be an
5648         objfile_per_bfd_storage.
5649         * psymtab.c (add_psymbol_to_bcache): Update.
5650         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5651
5652 2019-01-10  Tom Tromey  <tom@tromey.com>
5653
5654         * symtab.c (create_demangled_names_hash): Change argument to be an
5655         objfile_per_bfd_storage.
5656         (symbol_set_names): Update.
5657
5658 2019-01-10  Tom Tromey  <tom@tromey.com>
5659
5660         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5661         init_psymbol_list.
5662         * psymtab.c (init_psymbol_list): Do nothing if already called.
5663         * psympriv.h (init_psymbol_list): Add comment.
5664         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5665         init_psymbol_list.
5666         * dbxread.c (dbx_symfile_read): Unconditionally call
5667         init_psymbol_list.
5668
5669 2019-01-10  Tom Tromey  <tom@tromey.com>
5670
5671         * xcoffread.c (scan_xcoff_symtab): Update.
5672         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5673         "where".
5674         * mdebugread.c (parse_partial_symbols)
5675         (handle_psymbol_enumerators): Update.
5676         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5677         * dbxread.c (read_dbx_symtab): Update.
5678         * psympriv.h (psymbol_placement): New enum.
5679         (add_psymbol_to_list): Update.
5680
5681 2019-01-10  Tom Tromey  <tom@tromey.com>
5682
5683         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5684         static_psymbols parameters.
5685         (scan_xcoff_symtab): Update.
5686         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5687         static_psymbols parameters.
5688         * psympriv.h (start_psymtab_common): Update.
5689         * mdebugread.c (parse_partial_symbols): Update.
5690         * dwarf2read.c (create_partial_symtab): Update.
5691         * dbxread.c (read_dbx_symtab): Update.
5692         (start_psymtab): Remove global_psymbols and static_psymbols
5693         parameters.
5694
5695 2019-01-10  Tom Tromey  <tom@tromey.com>
5696
5697         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5698         * psymtab.c (allocate_psymtab): Add comment.
5699         * psympriv.h (allocate_psymtab): Add comment.
5700         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5701         initializations.
5702         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5703
5704 2019-01-10  Tom Tromey  <tom@tromey.com>
5705
5706         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5707         Don't declare.
5708         * mipsread.c: Include mdebugread.h.
5709         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5710         Declare.
5711         * elfread.c: Include mdebugread.h.
5712
5713 2019-01-09  Tom Tromey  <tom@tromey.com>
5714
5715         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5716         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5717         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5718         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5719         (psym_lookup_symbol, psym_find_last_source_symtab)
5720         (psym_forget_cached_source_info, psym_print_stats)
5721         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5722         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5723         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5724         (psym_find_compunit_symtab_by_address)
5725         (maintenance_print_psymbols, maintenance_info_psymtabs)
5726         (maintenance_check_psymtabs): Use ranged for.
5727         * psymtab.h (class objfile_psymtabs): New.
5728         (require_partial_symbols): Return objfile_psymtabs.
5729         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5730
5731 2019-01-09  Tom Tromey  <tom@tromey.com>
5732
5733         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5734         (find_pc_mapped_section, list_overlays_command)
5735         (map_overlay_command, unmap_overlay_command)
5736         (simple_overlay_update): Use all_objfiles.
5737         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5738         * printcmd.c (info_symbol_command): Use all_objfiles.
5739         * objfiles.h (ALL_OBJSECTIONS): Remove.
5740         * maint.c (maintenance_translate_address): Use all_objfiles.
5741         * gcore.c (gcore_create_callback): Use all_objfiles.
5742         (objfile_find_memory_regions): Likewise.
5743
5744 2019-01-09  Tom Tromey  <tom@tromey.com>
5745
5746         * symtab.c (find_line_symtab, info_sources_command)
5747         (make_source_files_completion_list): Use objfile_compunits.
5748         * source.c (select_source_symtab): Use objfile_compunits.
5749         * objfiles.h (struct objfile): Update comment.
5750         (ALL_OBJFILES): Remove.
5751         (ALL_FILETABS): Remove.
5752         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5753         objfile_compunits.
5754
5755 2019-01-09  Tom Tromey  <tom@tromey.com>
5756
5757         * symmisc.c (print_objfile_statistics, dump_objfile)
5758         (maintenance_print_symbols): Use compunit_filetabs.
5759         * source.c (forget_cached_source_info_for_objfile): Use
5760         compunit_filetabs.
5761         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5762         (ALL_FILETABS): Use compunit_filetabs.
5763         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5764         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5765
5766 2019-01-09  Tom Tromey  <tom@tromey.com>
5767
5768         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5769         (compunit_filetabs): New.
5770         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5771         compunit_filetabs.
5772         (info_sources_command, make_source_files_completion_list): Remove
5773         declaration.
5774         * symmisc.c (print_objfile_statistics, dump_objfile)
5775         (maintenance_print_symbols): Remove declaration.
5776         (maintenance_info_symtabs): Use compunit_filetabs.
5777         (maintenance_info_line_tables): Likewise.
5778         * source.c (select_source_symtab): Change local variable name.
5779         (forget_cached_source_info_for_objfile): Remove declaration.
5780         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5781         * objfiles.c (objfile_relocate1): Remove declaration.
5782         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5783         declaration.
5784         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5785         * coffread.c (coff_symtab_read): Remove declaration.
5786         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5787         compunit_filetabs.
5788
5789 2019-01-09  Tom Tromey  <tom@tromey.com>
5790
5791         * symtab.c (lookup_objfile_from_block)
5792         (find_pc_sect_compunit_symtab, search_symbols)
5793         (default_collect_symbol_completion_matches_break_on): Use
5794         objfile_compunits.
5795         * objfiles.h (ALL_COMPUNITS): Remove.
5796         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5797         * cp-support.c (add_symbol_overload_list_qualified): Use
5798         objfile_compunits.
5799         * ada-lang.c (ada_collect_symbol_completion_matches)
5800         (ada_add_global_exceptions): Use objfile_compunits.
5801
5802 2019-01-09  Tom Tromey  <tom@tromey.com>
5803
5804         * source.c (select_source_symtab)
5805         (forget_cached_source_info_for_objfile): Remove declaration.
5806         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5807         declaration.
5808         * maint.c (count_symtabs_and_blocks): Remove declaration.
5809         * cp-support.c (add_symbol_overload_list_qualified): Remove
5810         declaration.
5811         * coffread.c (coff_symtab_read): Remove declaration.
5812         * symtab.c (lookup_symbol_in_objfile_symtabs)
5813         (basic_lookup_transparent_type_1): Use objfile_compunits.
5814         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5815         (info_sources_command, search_symbols)
5816         (default_collect_symbol_completion_matches_break_on)
5817         (make_source_files_completion_list): Remove declaration.
5818         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5819         (ada_collect_symbol_completion_matches)
5820         (ada_add_global_exceptions): Remove declaration.
5821         * linespec.c (iterate_over_all_matching_symtabs): Use
5822         objfile_compunits.
5823         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5824         (class objfile_compunits): New.
5825         (ALL_COMPUNITS): Use objfile_compunits.
5826         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5827         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5828         objfile_compunits.
5829         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5830
5831 2019-01-09  Tom Tromey  <tom@tromey.com>
5832
5833         * symtab.c (search_symbols)
5834         (default_collect_symbol_completion_matches_break_on): Use
5835         objfile_msymbols.
5836         * ada-lang.c (ada_lookup_simple_minsym)
5837         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5838         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5839         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5840         objfile_msymbols.
5841         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5842         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5843         * objc-lang.c (find_methods): Use objfile_msymbols.
5844         (info_selectors_command, info_classes_command): Likewise.
5845         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5846         * objfiles.h (class objfile_msymbols): New.
5847         (ALL_OBJFILE_MSYMBOLS): Remove.
5848         (ALL_MSYMBOLS): Remove.
5849
5850 2019-01-09  Tom Tromey  <tom@tromey.com>
5851
5852         * common/next-iterator.h (next_adapter): Add Iterator template
5853         parameter.
5854         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5855         (class all_objfiles_safe): New.
5856         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5857         * objfiles.c (put_objfile_before): Update comment.
5858         (add_separate_debug_objfile): Likewise.
5859         (free_all_objfiles): Use all_objfiles_safe.
5860         (objfile_purge_solibs): Likewise.
5861
5862 2019-01-09  Tom Tromey  <tom@tromey.com>
5863
5864         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5865         (expand_symtab_containing_pc, lookup_static_symbol)
5866         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5867         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5868         all_objfiles.
5869         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5870         * breakpoint.c (create_overlay_event_breakpoint)
5871         (create_longjmp_master_breakpoint)
5872         (create_std_terminate_master_breakpoint)
5873         (create_exception_master_breakpoint): Use all_objfiles.
5874         * linux-thread-db.c (try_thread_db_load_from_pdir)
5875         (has_libpthread): Use all_objfiles.
5876         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5877         * linespec.c (iterate_over_all_matching_symtabs)
5878         (search_minsyms_for_name): Use all_objfiles.
5879         * maint.c (maintenance_info_sections): Use all_objfiles.
5880         * main.c (captured_main_1): Use all_objfiles.
5881         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5882         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5883         * guile/scm-pretty-print.c
5884         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5885         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5886         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5887         (maintenance_print_msymbols): Use all_objfiles.
5888         * source.c (select_source_symtab): Use all_objfiles.
5889         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5890         * symfile.c (remove_symbol_file_command)
5891         (expand_symtabs_matching, map_symbol_filenames): Use
5892         all_objfiles.
5893         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5894         all_objfiles.
5895         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5896         * objc-lang.c (find_methods): Use all_objfiles.
5897         * objfiles.c (have_partial_symbols, have_full_symbols)
5898         (have_minimal_symbols, qsort_cmp)
5899         (default_iterate_over_objfiles_in_search_order): Use
5900         all_objfiles.
5901         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5902         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5903         (maintenance_check_psymtabs): Use all_objfiles.
5904         (ALL_PSYMTABS): Remove.
5905         * compile/compile-object-run.c (do_module_cleanup): Use
5906         all_objfiles.
5907         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5908         * cp-support.c (add_symbol_overload_list_qualified): Use
5909         all_objfiles.
5910         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5911         Use all_objfiles.
5912         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5913         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5914         all_objfiles.
5915         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5916         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5917         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5918         Uses all_objfiles.
5919         * solib.c (solib_read_symbols): Use all_objfiles
5920
5921 2019-01-09  Tom Tromey  <tom@tromey.com>
5922
5923         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5924         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5925         all_objfiles.
5926         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5927         * symmisc.c (print_symbol_bcache_statistics)
5928         (print_objfile_statistics, maintenance_print_objfiles)
5929         (maintenance_info_symtabs, maintenance_check_symtabs)
5930         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5931         all_objfiles.
5932         * source.c (forget_cached_source_info): Use all_objfiles.
5933         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5934         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5935         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5936         * objfiles.c (update_section_map): Use all_objfiles.
5937         (shared_objfile_contains_address_p): Likewise.
5938         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5939         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5940
5941 2019-01-09  Tom Tromey  <tom@tromey.com>
5942
5943         * common/next-iterator.h: New file.
5944         * objfiles.h (class all_objfiles): New.
5945         (struct objfile_iterator): New.
5946
5947 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5948
5949         * NEWS: Move the description of the changed "frame", "select-frame",
5950          and "info frame" commands to the Changed commands section.
5951
5952 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5953
5954         * gdbtypes.c (check_stub_method_group): Remove handling of old
5955         mangling schemes.
5956         * linespec.c (find_methods): Likewise.
5957         * stabsread.c (read_member_functions): Likewise.
5958         * valops.c (search_struct_method): Likewise.
5959         (value_struct_elt_for_reference): Likewise.
5960         * NEWS: Mention this change.
5961
5962 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5963
5964         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5965         print_source_lines.
5966         * source.c (print_source_lines_base): Update line number check.
5967         (print_source_lines): New function.
5968         (source_lines_range::source_lines_range): New function.
5969         * source.h (class source_lines_range): New class.
5970         (print_source_lines): New declaration.
5971
5972 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5973
5974         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5975
5976 2019-01-08  Tom Tromey  <tom@tromey.com>
5977             Simon Marchi  <simon.marchi@ericsson.com>
5978
5979         PR gdb/24060
5980         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5981         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5982         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5983         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5984         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5985         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5986
5987 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5988
5989         * source.c (select_source_symtab): Move header comment to
5990         declaration in source.h.
5991         (forget_cached_source_info_for_objfile): Likewise.
5992         (forget_cached_source_info): Likewise.
5993         (identify_source_line): Likewise.
5994         * source.h (identify_source_line): Move declaration from symtab.h
5995         and add comment from source.c
5996         (print_source_lines): Likewise.
5997         (forget_cached_source_info_for_objfile): Likewise.
5998         (forget_cached_source_info): Likewise.
5999         (select_source_symtab): Likewise.
6000         (enum print_source_lines_flag): Move definition from symtab.h.
6001         * symtab.h (identify_source_line): Move declaration to source.h.
6002         (print_source_lines): Likewise.
6003         (forget_cached_source_info_for_objfile): Likewise.
6004         (forget_cached_source_info): Likewise.
6005         (select_source_symtab): Likewise.
6006         (enum print_source_lines_flag): Move definition to source.h.
6007         * tui/tui-hooks.c: Add 'source.h' include.
6008
6009 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6010
6011         * source.c (print_source_lines_base): Handle requests to print
6012         reverse line number sequences, and guard against empty lines
6013         string.
6014
6015 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6016
6017         * source.c (print_source_lines_base): Fix skip of '\r' if next
6018         character is '\n'.
6019
6020 2019-01-06  Tom Tromey  <tom@tromey.com>
6021
6022         * c-exp.y (struct c_parse_state) <macro_original_text,
6023         expansion_obstack>: New member.
6024         (macro_original_text, expansion_obstack): Remove globals.
6025         (scan_macro_expansion, scanning_macro_expansion)
6026         (finished_macro_expansion): Update.
6027         (scan_macro_cleanup): Remove.
6028         (yylex, c_parse): Update.
6029
6030 2019-01-06  Tom Tromey  <tom@tromey.com>
6031
6032         * c-exp.y (struct c_parse_state) <strings>: New member.
6033         (operator_stoken): Update.
6034
6035 2019-01-06  Tom Tromey  <tom@tromey.com>
6036
6037         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6038         (union type_stack_elt) <typelist_val>: Now a pointer to
6039         std::vector.
6040         (type_stack_cleanup): Don't declare.
6041         (push_typelist): Update.
6042         * parse.c (pop_typelist): Return a std::vector.
6043         (push_typelist): Take a std::vector.
6044         (follow_types): Update.  Do not free args.
6045         (type_stack_cleanup): Remove.
6046         * c-exp.y (struct c_parse_state): New.
6047         (cpstate): New global.
6048         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6049         (nonempty_typelist): Update.
6050         (func_mod): Create a new vector.
6051         (c_parse): Create a c_parse_state.
6052         (check_parameter_typelist): Do not delete params.
6053         (function_method): Update.  Do not delete type_list.
6054
6055 2019-01-06  Tom Tromey  <tom@tromey.com>
6056
6057         PR gdb/28155:
6058         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6059         check_typedef.
6060         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6061         (print_return_value): Likewise.
6062
6063 2019-01-05  Tom Tromey  <tom@tromey.com>
6064
6065         * contrib/cleanup_check.py: Remove.
6066         * contrib/gcc-with-excheck: Remove.
6067         * contrib/exsummary.py: Remove.
6068         * contrib/excheck.py: Remove.
6069
6070 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6071
6072         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6073         NULL. Initialize tpprev to NULL instead of assigning it
6074         to NULL on the next statement.
6075         * windows-nat.c (windows_delete_thread): Remove check for
6076         main_thread_id before printing thread exit notifications.
6077         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6078         Remove thread ID check against main_thread_id.
6079         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6080         windows_delete_thread.
6081         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6082
6083 2019-01-04  Tom Tromey  <tom@tromey.com>
6084
6085         * compile/compile.c (_initialize_compile): Use upper case for
6086         metasyntactic variables.
6087         * symmisc.c (_initialize_symmisc): Use upper case for
6088         metasyntactic variables.
6089         * psymtab.c (_initialize_psymtab): Use upper case for
6090         metasyntactic variables.
6091         * demangle.c (demangle_command): Use upper case for metasyntactic
6092         variables.
6093         (_initialize_demangler): Likewise.
6094         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6095         variables.
6096
6097 2019-01-03  Tom Tromey  <tom@tromey.com>
6098
6099         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6100
6101 2019-01-03  Tom Tromey  <tom@tromey.com>
6102
6103         * python/py-symtab.c (salpy_str): Update.
6104         (struct salpy_sal_object) <symtab>: Now a PyObject.
6105         (salpy_dealloc): Update.
6106         (del_objfile_sal): Use gdbpy_ref.
6107
6108 2019-01-03  Tom Tromey  <tom@tromey.com>
6109
6110         * python/py-type.c (convert_field): Use new_reference.  Return
6111         gdbpy_ref.
6112         (make_fielditem): Return gdbpy_ref.
6113         (typy_fields): Update.
6114         (typy_getitem): Update.
6115         (field_name): Return gdbpy_ref.  Use new_reference.
6116         (typy_iterator_iternext): Update.
6117
6118 2019-01-03  Tom Tromey  <tom@tromey.com>
6119
6120         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6121
6122 2019-01-03  Tom Tromey  <tom@tromey.com>
6123
6124         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6125         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6126         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6127         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6128         (pspy_set_type_printers): Likewise.
6129         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6130         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6131         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6132         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6133         (objfpy_set_type_printers): Likewise.
6134
6135 2019-01-03  Tom Tromey  <tom@tromey.com>
6136
6137         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6138         (gdbpy_print_stack): Use gdbpy_err_fetch.
6139         * python/python-internal.h (class gdbpy_err_fetch): New class.
6140         (class gdbpy_enter) <m_error_type, m_error_value,
6141         m_error_traceback>: Remove.
6142         <m_error>: New member.
6143         (gdbpy_exception_to_string): Don't declare.
6144         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6145         * python/py-value.c (convert_value_from_python): Use
6146         gdbpy_err_fetch.
6147         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6148         gdbpy_exception_to_string.
6149         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6150         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6151         gdbpy_err_fetch.
6152
6153 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6154
6155         * linux-nat.c (delete_lwp_cleanup): Delete.
6156         (struct lwp_deleter): New struct.
6157         (lwp_info_up): New typedef.
6158         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6159         lwp_info_up.
6160
6161 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6162
6163         * linux-fork.c (class scoped_switch_fork_info): New class.
6164         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6165
6166 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6167
6168         * valops.c (find_overload_match): Remove use of null_cleanup, and
6169         calls to do_cleanups.
6170
6171 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6172
6173         * compile/compile-cplus-types.c
6174         (compile_cplus_instance::decl_name): Handle changes to
6175         cp_func_name.
6176         * cp-support.c (cp_func_name): Update header comment, update
6177         return type.
6178         * cp-support.h (cp_func_name): Update return type in declaration.
6179         * valops.c (find_overload_match): Move temp_func local to top
6180         level of function and change its type.  Use temp_func to hold and
6181         delete temporary string obtained from cp_func_name.
6182
6183 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6184
6185         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6186         gdb::char_vector, remove cleanup, and update uses of `msg`.
6187
6188 2019-01-03  Jim Wilson  <jimw@sifive.com>
6189
6190         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6191
6192 2019-01-02  Tom Tromey  <tom@tromey.com>
6193
6194         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6195         (tdesc_parse_xml): Remove cleanups.
6196         * target-descriptions.h (make_cleanup_free_target_description):
6197         Don't declare.
6198         (target_desc_deleter): New struct.
6199         (target_desc_up): New typedef.
6200         * target-descriptions.c (target_desc_deleter::operator()): Rename
6201         from free_target_description.
6202         (make_cleanup_free_target_description): Remove.
6203
6204 2019-01-02  Tom Tromey  <tom@tromey.com>
6205
6206         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6207         constructor, destructor.
6208         (linespec_parser): Remove typedef.
6209         (~linespec_parser): Rename from linespec_parser_delete.
6210         (linespec_lex_to_end, linespec_complete_label)
6211         (linespec_complete): Update.
6212         (decode_line_full): Remove cleanups.
6213         (decode_line_1): Update.
6214
6215 2019-01-02  Tom Tromey  <tom@tromey.com>
6216
6217         * python/python-internal.h (inferior_to_inferior_object): Change
6218         return type.
6219         * python/py-exitedevent.c (create_exited_event_object): Update.
6220         * python/py-inferior.c (inferior_to_inferior_object): Return
6221         gdbpy_ref.
6222         (python_new_inferior, python_inferior_deleted)
6223         (thread_to_thread_object, delete_thread_object)
6224         (build_inferior_list, gdbpy_selected_inferior): Update.
6225         * python/py-infthread.c (create_thread_object): Update.  Also fail
6226         if inferior_to_inferior_object fails.
6227
6228 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6229
6230         * inferior.h (class inferior) <displaced_step_state>: New field.
6231         * infrun.h (struct displaced_step_state): Move here from
6232         infrun.c.  Initialize fields, add constructor.
6233         <inf>: Remove field.
6234         <reset>: New method.
6235         * infrun.c (struct displaced_step_inferior_state): Move to
6236         infrun.h.
6237         (displaced_step_inferior_states): Remove.
6238         (get_displaced_stepping_state): Adust.
6239         (displaced_step_in_progress_any_inferior): Adjust.
6240         (displaced_step_in_progress_thread): Adjust.
6241         (displaced_step_in_progress): Adjust.
6242         (add_displaced_stepping_state): Remove.
6243         (get_displaced_step_closure_by_addr): Adjust.
6244         (remove_displaced_stepping_state): Remove.
6245         (infrun_inferior_exit): Call displaced_step_state.reset.
6246         (use_displaced_stepping): Don't check for NULL.
6247         (displaced_step_prepare_throw): Call
6248         get_displaced_stepping_state.
6249         (displaced_step_fixup): Don't check for NULL.
6250         (prepare_for_detach): Don't check for NULL.
6251
6252 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6253
6254         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6255          in case of call that did not complete.
6256
6257 2019-01-02  Andrey Utkin  <autkin@undo.io>
6258
6259         * symfile.c (find_separate_debug_file): Fix search of debug files for
6260         remote debuggee.
6261
6262 2019-01-02  Tom Tromey  <tom@tromey.com>
6263
6264         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6265         indentation.
6266         * python/py-frame.c (frapy_older): Remove cast.
6267         (frapy_newer): Likewise.
6268         * python/py-breakpoint.c (local_setattro): Remove cast.
6269         * python/py-arch.c (archpy_name): Remove local variable.
6270         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6271
6272 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6273
6274         * unittests/basic_string_view/element_access/char/empty.cc:
6275         Fix year range in copyright header.
6276
6277 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6278
6279         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6280         Delete.
6281         <operator==>: Update with for removed field.
6282         <hash>: Likewise.
6283         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6284         <isa_features>: ...this.
6285         <abi_features>: New field.
6286         (riscv_isa_flen): Update comment.
6287         (riscv_abi_xlen): New declaration.
6288         (riscv_abi_flen): New declaration.
6289         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6290         isa_features.
6291         (riscv_abi_xlen): New function.
6292         (riscv_isa_flen): Update to get answer from isa_features.
6293         (riscv_abi_flen): New function.
6294         (riscv_has_fp_abi): Update to get answer from abi_features.
6295         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6296         xlen and flen.
6297         (riscv_call_info) <xlen, flen>: Update comment.
6298         (riscv_call_arg_struct): Remove invalid assertions
6299         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6300         is removed.
6301         (riscv_gdbarch_init): Gather isa features and abi features
6302         separately, ensure both match on the gdbarch when reusing an old
6303         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6304         a target with 64-bit float hardware.
6305
6306 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6307
6308         * source.c (search_command_helper): Stop reverse search
6309         when line 1 has been searched.
6310
6311 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6312
6313         * record-full.c (record_full_base_target::close): Rewrite
6314         record_full_core_buf_list free logic.
6315
6316 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6317
6318         * break-catch-syscall.c (print_one_catch_syscall): xfree
6319         the last text.
6320
6321 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6322
6323         * top.c (print_gdb_version): Update Copyright year in version
6324         message.
6325
6326 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6327
6328         Update copyright year range in all GDB files.
6329
6330 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6331
6332         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6333
6334 For older changes see ChangeLog-2018.
6335 \f
6336 Local Variables:
6337 mode: change-log
6338 left-margin: 8
6339 fill-column: 74
6340 version-control: never
6341 coding: utf-8
6342 End:
6343