Add win_info parameter to tui_set_disassem_content
[deliverable/binutils-gdb.git] / gdb / ChangeLog
1 2019-07-17 Tom Tromey <tom@tromey.com>
2
3 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
5 parameter.
6 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
7 parameter.
8
9 2019-07-17 Tom Tromey <tom@tromey.com>
10
11 * tui/tui-winsource.c (tui_clear_source_content)
12 (tui_show_source_content, tui_show_exec_info_content)
13 (tui_clear_exec_info_content): Update.
14 * tui/tui-stack.c (tui_show_locator_content): Update.
15 (tui_show_frame_info): Update.
16 * tui/tui-source.h (tui_source_window): Don't declare.
17 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
18 from tui_source_is_displayed.
19 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
20 Remove field.
21 (struct tui_source_window_base) <content_in_use>: New field. Now
22 bool.
23 (struct tui_source_window) <showing_source_p>: New method.
24 (TUI_SRC_WIN): Change cast.
25 * tui/tui-data.c (tui_initialize_static_data): Update.
26
27 2019-07-17 Tom Tromey <tom@tromey.com>
28
29 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
30 location_matches_p.
31 * tui/tui-source.c (tui_source_window::location_matches_p): New
32 method.
33 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
34 method.
35 * tui/tui-data.h (struct tui_source_window_base)
36 <location_matches_p>: New method.
37 (struct tui_source_window, struct tui_disasm_window)
38 <location_matches_p>: Likewise.
39
40 2019-07-17 Tom Tromey <tom@tromey.com>
41
42 * tui/tui-win.c (tui_set_win_height_command): Rename from
43 tui_set_win_height.
44 (tui_set_win_height_command): Remove.
45
46 2019-07-17 Tom Tromey <tom@tromey.com>
47
48 * tui/tui-source.c (tui_source_window): New constructor. Add
49 observer.
50 (~tui_source_window): New destructor.
51 (tui_source_window::style_changed): New method.
52 * tui/tui-hooks.c (tui_redisplay_source): Remove.
53 (tui_attach_detach_observers): Update.
54 * tui/tui-data.h (struct tui_source_window): Make constructor not
55 inline. Add destructor.
56 (struct tui_source_window) <style_changed>: New method.
57 <m_observable>: New member.
58
59 2019-07-17 Tom Tromey <tom@tromey.com>
60
61 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
62 * tui/tui-win.c (tui_resize_all): Fix typo.
63
64 2019-07-17 Tom Tromey <tom@tromey.com>
65
66 * tui/tui-wingeneral.h (tui_refresh_all): Update.
67 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
68 (tui_refresh_all): Remove "list" parameter. Use foreach.
69 * tui/tui-win.c (window_name_completer): Use foreach.
70 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
71 (update_tab_width): Likewise.
72 * tui/tui-layout.c (show_layout): Update.
73 * tui/tui-data.h (class tui_window_iterator): New.
74 (struct all_tui_windows): New.
75 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
76
77 2019-07-17 Tom Tromey <tom@tromey.com>
78
79 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
80 parameter. Don't reference globals.
81 (tui_reg_command): Update.
82
83 2019-07-17 Tom Tromey <tom@tromey.com>
84
85 * tui/tui-regs.c (tui_show_registers): Simplify.
86
87 2019-07-17 Tom Tromey <tom@tromey.com>
88
89 * tui/tui-regs.c (tui_show_registers): Update.
90 (tui_show_register_group): Add win_info parameter.
91
92 2019-07-17 Tom Tromey <tom@tromey.com>
93
94 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
95 Rename from tui_display_reg_element_at_line.
96 (tui_data_window::display_registers_from_line): Update.
97 * tui/tui-data.h (struct tui_data_window)
98 <display_reg_element_at_line>: New method.
99
100 2019-07-17 Tom Tromey <tom@tromey.com>
101
102 * tui/tui-regs.h (tui_display_registers_from)
103 (tui_display_registers_from_line): Don't declare.
104 * tui/tui-windata.c (tui_data_window::display_all_data)
105 (tui_data_window::refresh_all)
106 (tui_data_window::do_scroll_vertical): Update.
107 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
108 from tui_display_registers_from.
109 (tui_display_reg_element_at_line): Update.
110 (tui_data_window::display_registers_from_line): Rename from
111 tui_display_registers_from_line.
112 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
113 display_registers_from_line>: New methods.
114
115 2019-07-17 Tom Tromey <tom@tromey.com>
116
117 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
118 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
119 from tui_erase_data_content.
120 (tui_data_window::display_all_data)
121 (tui_data_window::refresh_all)
122 (tui_data_window::do_scroll_vertical): Update.
123 * tui/tui-regs.c (tui_show_registers): Update.
124 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
125 New method.
126
127 2019-07-17 Tom Tromey <tom@tromey.com>
128
129 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
130 declare.
131 * tui/tui-windata.c
132 (tui_data_window::delete_data_content_windows): Rename from
133 tui_delete_data_content_windows.
134 (tui_data_window::display_all_data)
135 (tui_data_window::do_scroll_vertical): Update.
136 * tui/tui-data.h (struct tui_data_window)
137 <delete_data_content_windows>: New method.
138
139 2019-07-17 Tom Tromey <tom@tromey.com>
140
141 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
142 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
143
144 2019-07-17 Tom Tromey <tom@tromey.com>
145
146 * tui/tui-windata.h (tui_display_all_data): Don't declare.
147 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
148 from tui_display_all_data.
149 * tui/tui-win.c
150 (tui_data_window::do_make_visible_with_new_height): Update.
151 * tui/tui-regs.c (tui_show_registers): Update.
152 * tui/tui-layout.c (tui_set_layout): Update.
153 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
154 method.
155
156 2019-07-17 Tom Tromey <tom@tromey.com>
157
158 * tui/tui-windata.h (tui_display_data_from): Don't declare.
159 * tui/tui-windata.c (tui_display_data_from): Remove.
160 (tui_data_window::refresh_all): Update.
161
162 2019-07-17 Tom Tromey <tom@tromey.com>
163
164 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
165 * tui/tui-windata.c (tui_display_data_from_line): Remove.
166 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
167 tui_display_registers_from_line.
168 * tui/tui-regs.h (tui_display_registers_from_line): Update.
169 * tui/tui-regs.c (tui_display_registers_from_line): Remove
170 "force_display" parameter.
171
172 2019-07-17 Tom Tromey <tom@tromey.com>
173
174 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
175 declare.
176 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
177 Rename from tui_first_reg_element_no_inline.
178 (tui_display_reg_element_at_line)
179 (tui_display_registers_from_line): Update.
180 * tui/tui-data.h (struct tui_data_window)
181 <first_reg_element_no_inline>: New method.
182
183 2019-07-17 Tom Tromey <tom@tromey.com>
184
185 * tui/tui-windata.c (tui_display_data_from)
186 (tui_data_window::do_scroll_vertical): Update.
187 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
188 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
189 Rename from tui_line_from_reg_element_no.
190 (tui_display_registers_from_line): Update.
191 * tui/tui-data.h (struct tui_data_window)
192 <line_from_reg_element_no>: New method.
193
194 2019-07-17 Tom Tromey <tom@tromey.com>
195
196 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
197 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
198 tui_last_regs_line_no.
199 (tui_display_reg_element_at_line)
200 (tui_display_registers_from_line): Update.
201 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
202 method.
203
204 2019-07-17 Tom Tromey <tom@tromey.com>
205
206 PR tui/24722:
207 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
208 (tui_update_breakpoint_info): Add "being_deleted" parameter.
209 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
210 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
211 (tui_update_breakpoint_info): Likewise.
212 * tui/tui-hooks.c (tui_event_create_breakpoint)
213 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
214 Update.
215
216 2019-07-17 Tom Tromey <tom@tromey.com>
217
218 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
219
220 2019-07-17 Tom Tromey <tom@tromey.com>
221
222 * tui/tui-winsource.c (tui_update_source_window_as_is)
223 (tui_update_source_windows_with_addr): Update.
224 * tui/tui-source.h (tui_set_source_content)
225 (tui_show_symtab_source): Add "win_info" parameter.
226 * tui/tui-source.c (tui_set_source_content): Add "win_info"
227 parameter.
228 (tui_show_symtab_source): Likewise.
229
230 2019-07-17 Tom Tromey <tom@tromey.com>
231
232 * tui/tui-wingeneral.c
233 (tui_check_and_display_highlight_if_needed): Check can_highlight.
234
235 2019-07-17 Tom Tromey <tom@tromey.com>
236
237 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
238 (struct tui_cmd_window) <can_scroll>: New method.
239 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
240 method.
241
242 2019-07-17 Tom Tromey <tromey@adacore.com>
243
244 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
245 do_field_signed>: Rename. Change type of "value".
246 * ui-out.c (ui_out::field_signed): Rename from field_int.
247 Change type of "value".
248 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
249 type of "value".
250 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
251 do_field_int. Change type of "value".
252 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
253 do_field_int. Change type of "value".
254 * tracepoint.c (trace_status_mi, tfind_1)
255 (print_one_static_tracepoint_marker): Update.
256 * thread.c (print_thread_info_1, print_selected_thread_frame):
257 Update.
258 * stack.c (print_frame, print_frame_info): Update.
259 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
260 Update.
261 * source.c (print_source_lines_base): Update.
262 * skip.c (info_skip_command): Update.
263 * record-btrace.c (btrace_ui_out_decode_error)
264 (btrace_call_history_src_line): Update.
265 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
266 Update.
267 * progspace.c (print_program_space): Update.
268 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
269 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
270 do_field_int. Change type of "value".
271 * mi/mi-out.c (mi_ui_out::do_table_begin)
272 (mi_ui_out::do_table_header): Update.
273 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
274 type of "value".
275 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
276 (mi_cmd_data_list_changed_registers, output_register)
277 (mi_cmd_data_read_memory, mi_load_progress)
278 (mi_cmd_trace_frame_collected): Update.
279 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
280 Update.
281 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
282 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
283 (mi_cmd_var_list_children, varobj_update_one): Update.
284 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
285 (mi_cmd_stack_list_args, list_arg_or_local): Update.
286 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
287 * inferior.c (print_inferior): Update.
288 * gdb_bfd.c (print_one_bfd): Update.
289 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
290 Update.
291 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
292 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
293 do_field_int. Change type of "value".
294 * cli-out.c (cli_ui_out::do_field_signed): Rename from
295 do_field_int. Change type of "value".
296 * breakpoint.c (watchpoint_check, print_breakpoint_location)
297 (print_one_breakpoint_location, print_it_catch_fork)
298 (print_one_catch_fork, print_it_catch_vfork)
299 (print_one_catch_vfork, print_it_catch_solib)
300 (print_it_catch_exec, print_it_ranged_breakpoint)
301 (print_mention_watchpoint, print_mention_masked_watchpoint)
302 (bkpt_print_it, update_static_tracepoint): Update.
303 * break-catch-throw.c (print_it_exception_catchpoint): Update.
304 * break-catch-syscall.c (print_it_catch_syscall): Update.
305 * ada-tasks.c (print_ada_task_info): Update.
306 * ada-lang.c (print_it_exception, print_mention_exception):
307 Update.
308
309 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
310
311 PR breakpoints/24541
312 * gdbarch.c: Regenerate.
313 * gdbarch.h: Regenerate.
314 * gdbarch.sh: Adjust return type and parameter types for
315 'stap_adjust_register'.
316 (i386_stap_adjust_register): Adjust signature and return new
317 register name.
318 * stap-probe.c (stap_parse_register_operand): Adjust use of
319 'gdbarch_stap_adjust_register'.
320
321 2019-07-17 Tom Tromey <tromey@adacore.com>
322
323 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
324 declare VEC.
325 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
326 std::vector.
327 (struct s390_process_info): Add initializers.
328 (s390_add_process): Use new.
329 (s390_linux_nat_target::low_forget_process): Use delete.
330 (s390_linux_nat_target::low_new_fork)
331 (s390_linux_nat_target::stopped_by_watchpoint)
332 (s390_linux_nat_target::low_prepare_to_resume)
333 (s390_linux_nat_target::insert_watchpoint)
334 (s390_linux_nat_target::insert_hw_breakpoint)
335 (s390_linux_nat_target::remove_watchpoint)
336 (s390_linux_nat_target::remove_hw_breakpoint): Update.
337
338 2019-07-16 John Baldwin <jhb@FreeBSD.org>
339
340 * aarch64-fbsd-nat.c: Include regcache.h.
341 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
342 argument.
343 (aarch64_fbsd_nat_target::fetch_registers)
344 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
345 variable.
346 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
347
348 2019-07-16 John Baldwin <jhb@FreeBSD.org>
349
350 * fbsd-nat.c: Include gdbarch.h.
351
352 2019-07-15 Tom Tromey <tromey@adacore.com>
353
354 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
355
356 2019-07-15 Tom Tromey <tromey@adacore.com>
357
358 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
359 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
360 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
361 * cli-out.c (cli_ui_out::do_field_int): New method.
362 * ui-out.c (ui_out::field_unsigned): New method.
363 * symfile.c (generic_load): Use field_unsigned.
364 (print_transfer_performance): Likewise.
365 * record-btrace.c (ui_out_field_uint): Remove.
366 (btrace_call_history_insn_range, btrace_call_history): Use
367 field_unsigned.
368 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
369 field_unsigned.
370 * ui-out.h (class ui_out) <field_unsigned>: New method.
371 <do_field_unsigned>: Likewise.
372
373 2019-07-15 Tom Tromey <tromey@adacore.com>
374
375 * mi/mi-main.c (list_available_thread_groups): Use field_string.
376 * mi/mi-interp.c (mi_memory_changed): Use field_string.
377 * target.c (flash_erase_command): Use field_string.
378 * infrun.c (print_signal_received_reason): Use field_string.
379 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
380 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
381 field_string.
382 * ada-tasks.c (print_ada_task_info): Use field_string.
383
384 2019-07-15 Tom Tromey <tromey@adacore.com>
385
386 * target.c (flash_erase_command): Use field_core_addr.
387 * symfile.c (generic_load): Use field_core_addr.
388 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
389 Use field_core_addr.
390 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
391 field_core_addr.
392
393 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
394
395 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
396 value if its desired type is smaller than a CORE_ADDR and signed.
397
398 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
399
400 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
401 of changes to field names, and use new is_reference field to
402 decide if a property is a reference or not.
403 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
404 field.
405 (struct dwarf2_property_baton): Update header comment, rename
406 'referenced_type' to 'property_type' and update comments.
407 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
408 default property type, store in property baton, update to take
409 accound of renamed field.
410 (read_func_scope): Update call to attr_to_dynamic_prop.
411 (read_array_type): Likewise.
412 (dwarf2_per_cu_addr_sized_int_type): New function.
413 (read_subrange_index_type): Move type finding code to
414 dwarf2_per_cu_addr_sized_int_type.
415 (read_subrange_type): Update calls to attr_to_dynamic_prop.
416 (dwarf2_per_cu_addr_type): New function.
417 (set_die_type): Update calls to attr_to_dynamic_prop.
418
419 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
420
421 * dwarf2read.c (read_subrange_index_type): New function.
422 (read_subrange_type): Move code into new function and call it.
423 * gdbtypes.c (create_range_type): Add some asserts.
424
425 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
426
427 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
428 update return statements.
429 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
430 declaration, and update comment to match.
431 * gdbtypes.c (resolve_dynamic_array): Update call to
432 dwarf2_evaluate_property to match new return type.
433
434 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
435
436 * valarith.c (value_subscripted_rvalue): Change lowerbound
437 parameter type from int to LONGEST.
438 * value.h (value_subscripted_rvalue): Likewise in declaration.
439
440 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
441
442 * cli/cli-utils.c (info_print_command_completer): New function.
443 * cli/cli-utils.h: Add 'completer.h' include, and forward
444 declaration for 'struct cmd_list_element'.
445 (info_print_command_completer): Declare.
446 * stack.c (_initialize_stack): Add completer for 'info locals' and
447 'info args'.
448 * symtab.c (_initialize_symtab): Add completer for 'info
449 variables' and 'info functions'.
450 * NEWS: Mention completion for additional info commands.
451
452 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
453
454 * cli/cli-utils.c (extract_info_print_args): Delete.
455 (extract_arg_maybe_quoted): Delete.
456 (info_print_options_defs): New variable.
457 (make_info_print_options_def_group): New function.
458 (extract_info_print_options): Define new function.
459 * cli/cli-utils.h (extract_info_print_args): Delete.
460 (struct info_print_options): New structure.
461 (extract_info_print_options): Declare new function.
462 * stack.c (info_locals_command): Update to use new
463 extract_info_print_options, also add a header comment.
464 (info_args_command): Likewise.
465 * symtab.c (info_variables_command): Likewise.
466 (info_functions_command): Likewise.
467
468 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
469
470 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
471 to extract string arguments.
472 * common/common-utils.c (extract_string_maybe_quoted): New function.
473 * common/common-utils.h (extract_string_maybe_quoted): Declare.
474
475 2019-07-11 Tom Tromey <tromey@adacore.com>
476
477 * main.c (get_init_files): Use GDBINIT, not gdbinit.
478 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
479 * top.h (gdbinit): Don't declare.
480 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
481 into...
482 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
483 * top.c (gdb_init): Don't call init_cli_cmds.
484 (gdbinit): Remove.
485 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
486
487 2019-07-11 Tom Tromey <tromey@adacore.com>
488
489 * python/py-inferior.c (add_thread_object): Don't use thread_obj
490 after it has been moved.
491
492 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
493
494 * valops.c (value_must_coerce_to_target): Change return type to
495 bool.
496 * value.h (value_must_coerce_to_target): Likewise.
497
498 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
499
500 * breakpoint.c (is_hardware_watchpoint): Remove
501 forward-declaration.
502 (is_masked_watchpoint): Change return type to bool.
503 (is_tracepoint): Likewise.
504 (is_breakpoint): Likewise.
505 (is_hardware_watchpoint): Likewise.
506 (is_watchpoint): Likewise.
507 (is_no_memory_software_watchpoint): Likewise.
508 (is_catchpoint): Likewise.
509 (breakpoint_1): Make FILTER parameter's return type bool.
510 is_masked_watchpoint): Change return type to bool.
511 (save_breakpoints): Make FILTER parameter's return type bool.
512 * breakpoint.h (is_breakpoint): Change return type to bool.
513 (is_watchpoint): Likewise.
514 (is_catchpoint): Likewise.
515 (is_tracepoint): Likewise.
516
517 2019-07-10 Tom Tromey <tom@tromey.com>
518
519 * defs.h: Don't include gdbarch.h.
520 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
521 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
522 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
523 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
524 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
525 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
526 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
527 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
528 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
529 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
530 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
531 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
532 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
533 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
534 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
535 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
536 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
537 record-btrace.c, record.h, regcache-dump.c, regcache.h,
538 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
539 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
540 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
541 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
542 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
543 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
544 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
545 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
546 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
547
548 2019-07-10 Tom Tromey <tromey@adacore.com>
549
550 * ada-lang.h (is_ada_exception_catchpoint): Declare.
551 * breakpoint.c (init_ada_exception_breakpoint): Register as
552 bp_catchpoint.
553 (print_one_breakpoint_location, print_one_breakpoint): Use
554 is_ada_exception_catchpoint.
555 * ada-lang.c (class ada_catchpoint_location): Pass
556 bp_loc_software_breakpoint to bp_location constructor.
557 (is_ada_exception_catchpoint): New function.
558
559 2019-07-10 Tom Tromey <tromey@adacore.com>
560
561 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
562 VEC.
563 (struct arm_exidx_entry): New method operator<.
564 (struct arm_exidx_data) <section_maps>: Change type.
565 (arm_exidx_data_free): Remove.
566 (arm_exidx_data_key): Change type. Move lower.
567 (arm_exidx_new_objfile): Update.
568 (arm_compare_exidx_entries): Remove.
569 (arm_find_exidx_entry, _initialize_arm_tdep)
570
571 2019-07-10 Tom Tromey <tromey@adacore.com>
572
573 * solib-spu.c (ocl_program_data_key): Change type.
574 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
575 Update.
576
577 2019-07-10 Tom Tromey <tromey@adacore.com>
578
579 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
580 (struct solib_aix_inferior_data) <library_list>: Change type.
581 (solib_aix_inferior_data_handle): Change type.
582 (get_solib_aix_inferior_data): Update.
583 (solib_aix_free_library_list): Remove.
584 (library_list_start_library): Update.
585 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
586 return type.
587 (solib_aix_get_library_list)
588 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
589 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
590
591 2019-07-10 Tom Tromey <tromey@adacore.com>
592
593 * solib-dsbt.c (struct dsbt_info): Add initializers.
594 (solib_dsbt_pspace_data): Change type.
595 (dsbt_pspace_data_cleanup): Remove.
596 (get_dsbt_info, _initialize_dsbt_solib): Update.
597
598 2019-07-10 Tom Tromey <tromey@adacore.com>
599
600 * spu-tdep.c (spu_overlay_data): Change type.
601 (spu_get_overlay_table, spu_overlay_new_objfile)
602 (_initialize_spu_tdep): Update.
603
604 2019-07-10 Tom Tromey <tromey@adacore.com>
605
606 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
607 destructor.
608 (dbx_objfile_data_key): Change type and declare later.
609 (DBX_SYMFILE_INFO): Rewrite.
610 * dbxread.c (dbx_objfile_data_key): Change type.
611 (dbx_symfile_init): Update.
612 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
613 (coffstab_build_psymtabs, elfstab_build_psymtabs)
614 (stabsect_build_psymtabs, _initialize_dbxread): Update.
615
616 2019-07-10 Tom Tromey <tromey@adacore.com>
617
618 * jit.c (jit_program_space_key): Change type. Move lower.
619 (get_jit_program_space_data): Update.
620 (jit_program_space_data_cleanup): Remove.
621 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
622 Update.
623 (struct jit_program_space_data): Add initializers.
624
625 2019-07-10 Tom Tromey <tromey@adacore.com>
626
627 * solib-darwin.c (struct darwin_info): Add initializers.
628 (solib_darwin_pspace_data): Change type.
629 (darwin_pspace_data_cleanup): Remove.
630 (get_darwin_info, _initialize_darwin_solib): Update.
631
632 2019-07-10 Tom Tromey <tromey@adacore.com>
633
634 * remote-sim.c (struct sim_inferior_data): Add initializers,
635 constructor, and destructor.
636 (sim_inferior_data_key): Change type. Move lower.
637 (check_for_duplicate_sim_descriptor): Update.
638 (get_sim_inferior_data): Use new. Update.
639 (~sim_inferior_data_cleanup): Rename from
640 sim_inferior_data_cleanup. Simplify.
641 (gdbsim_close_inferior, simulator_command)
642 (sim_command_completer, _initialize_remote_sim): Update.
643 (next_pid, INITIAL_PID): Move earlier.
644
645 2019-07-10 Tom Tromey <tromey@adacore.com>
646
647 * python/python-internal.h (create_thread_object): Return
648 gdbpy_ref.
649 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
650 * python/py-inferior.c (struct threadlist_entry): Add
651 constructor.
652 <thread_obj>: Now a gdbpy_ref.
653 (thread_to_thread_object): Update.
654 (add_thread_object): Use new.
655 (delete_thread_object): Use delete.
656 (infpy_threads): Update.
657 (py_free_inferior): Update. Construct "inf_obj" after acquiring
658 GIL.
659
660 2019-07-10 Tom Tromey <tromey@adacore.com>
661
662 * valops.c (value_cast): Specialize error message for Ada.
663
664 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
665
666 * breakpoint.c (breakpoint_1): Update doc and parameter names.
667
668 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
669
670 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
671 bpstat_should_step): Return bool, adjust comments.
672 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
673 bpstat_should_step): Likewise.
674
675 2019-07-10 Alan Hayward <alan.hayward@arm.com>
676
677 * features/Makefile: Use feature target descriptions for Arm.
678 * features/arm/arm-core.c: Generate new file.
679 * features/arm/arm-fpa.c: Likewise.
680 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
681 * features/arm/arm-m-profile.c: Likewise.
682 * features/arm/arm-vfpv2.c: Likewise.
683 * features/arm/arm-vfpv3.c: Likewise.
684 * features/arm/xscale-iwmmxt.c: Likewise.
685 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
686
687 2019-07-10 Alan Hayward <alan.hayward@arm.com>
688
689 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
690 ptrace earlier.
691
692 2019-07-10 Alan Hayward <alan.hayward@arm.com>
693
694 * features/aarch64-pauth.c: Regenerate.
695
696 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
697
698 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
699 bool.
700 (bpstat_what): Use false instead of 0.
701
702 2019-07-09 Pedro Alves <palves@redhat.com>
703
704 * break-catch-throw.c (is_exception_catchpoint): New.
705 * breakpoint.c (print_one_breakpoint_location): New parameter
706 'raw_loc'. Handle it. Use
707 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
708 looking at the breakpoint's type.
709 (print_one_breakpoint): If handling "maint info breakpoints", also
710 print locations of exception catchpoints.
711 * breakpoint.h (is_exception_catchpoint): Declare.
712
713 2019-07-09 Pedro Alves <palves@redhat.com>
714
715 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
716 "addr" field.
717 (allocate_location_exception_catchpoint): New.
718 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
719 (initialize_throw_catchpoint_ops): Install
720 allocate_location_exception_catchpoint as allocate_location
721 method.
722 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
723 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
724 bp_loc_other.
725 (breakpoint_address_is_meaningful): Delete.
726 (bl_address_is_meaningful): New.
727 (breakpoint_locations_match): Adjust comment.
728 (bp_location_from_bp_type): New, factored out of...
729 (bp_location::bp_location(breakpoint *)): ... this.
730 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
731 factored out of...
732 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
733 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
734 breakpoint_address_is_meaningful.
735 (bp_locations_compare): Adjust comment.
736 (update_global_location_list): Use bl_address_is_meaningful
737 instead of breakpoint_address_is_meaningful.
738 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
739 explicit.
740 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
741 * python/py-breakpoint.c (bppy_get_location): No longer check
742 whether location is null.
743
744 2019-07-09 Pedro Alves <palves@redhat.com>
745
746 PR c++/15468
747 * breakpoint.c (print_one_breakpoint_location): Remove
748 single-location assert.
749
750 2019-07-09 Tom Tromey <tom@tromey.com>
751
752 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
753 * configure: Rebuild.
754 * configure.ac: Change common to gdbsupport.
755 * gdbsupport: Rename from common.
756 * acinclude.m4: Change common to gdbsupport.
757 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
758 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
759 gdbsupport.
760 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
761 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
762 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
763 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
764 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
765 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
766 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
767 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
768 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
769 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
770 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
771 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
772 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
773 coff-pe-read.c, command.h, compile/compile-c-support.c,
774 compile/compile-c.h, compile/compile-cplus-symbols.c,
775 compile/compile-cplus-types.c, compile/compile-cplus.h,
776 compile/compile-loc2c.c, compile/compile.c, completer.c,
777 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
778 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
779 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
780 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
781 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
782 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
783 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
784 features/aarch64-core.c, features/aarch64-fpu.c,
785 features/aarch64-pauth.c, features/aarch64-sve.c,
786 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
787 features/i386/32bit-core.c, features/i386/32bit-linux.c,
788 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
789 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
790 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
791 features/i386/64bit-core.c, features/i386/64bit-linux.c,
792 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
793 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
794 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
795 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
796 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
797 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
798 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
799 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
800 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
801 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
802 go32-nat.c, guile/guile.c, guile/scm-ports.c,
803 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
804 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
805 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
806 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
807 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
808 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
809 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
810 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
811 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
812 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
813 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
814 minsyms.c, mips-linux-tdep.c, namespace.h,
815 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
816 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
817 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
818 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
819 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
820 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
821 nat/linux-waitpid.c, nat/mips-linux-watch.c,
822 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
823 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
824 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
825 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
826 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
827 procfs.c, producer.c, progspace.h, psymtab.h,
828 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
829 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
830 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
831 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
832 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
833 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
834 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
835 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
836 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
837 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
838 target-memory.c, target.c, target.h, target/waitstatus.c,
839 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
840 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
841 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
842 unittests/array-view-selftests.c,
843 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
844 unittests/common-utils-selftests.c,
845 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
846 unittests/format_pieces-selftests.c,
847 unittests/function-view-selftests.c,
848 unittests/lookup_name_info-selftests.c,
849 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
850 unittests/mkdir-recursive-selftests.c,
851 unittests/observable-selftests.c,
852 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
853 unittests/parse-connection-spec-selftests.c,
854 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
855 unittests/scoped_fd-selftests.c,
856 unittests/scoped_mmap-selftests.c,
857 unittests/scoped_restore-selftests.c,
858 unittests/string_view-selftests.c, unittests/style-selftests.c,
859 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
860 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
861 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
862 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
863 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
864 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
865
866 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
867
868 * linespec.c (decode_digits_list_mode): Set explicit_line to a
869 bool value.
870 (decode_digits_ordinary): Set explicit_line field in sal.
871 * symtab.c (skip_prologue_sal): Don't skip prologue for a
872 symtab_and_line that was set on an explicit line number in
873 assembler code. Do always update the recorded symtab and line if
874 we do skip the prologue.
875
876 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
877
878 * breakpoint.c (set_breakpoint_location_function): Remove
879 explicit_loc parameter.
880 (momentary_breakpoint_from_master): Update call to
881 set_breakpoint_location_function.
882 (add_location_to_breakpoint): Likewise.
883
884 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
885
886 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
887 required features based on default bfd type when no specific bfd
888 is present.
889
890 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
891
892 * NEWS: Mention that GDB printf and eval commands can now print
893 C-style and Ada-style convenience var strings without
894 calling the inferior.
895 * printcmd.c (printf_c_string): Locally print GDB internal var
896 instead of transiting via the inferior.
897 (printf_wide_c_string): Likewise.
898
899 2019-07-04 Alan Hayward <alan.hayward@arm.com>
900
901 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
902
903 2019-07-04 Tom Tromey <tom@tromey.com>
904
905 PR tui/24724:
906 * tui/tui-winsource.c (tui_clear_source_content): Update.
907 (tui_source_window_base::set_is_exec_point_at): Fix comment.
908 (tui_update_breakpoint_info): Update.
909 (tui_set_exec_info_content): Update.
910 * tui/tui-source.c (tui_set_source_content_nil): Update.
911 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
912 has_break.
913 * tui/tui-data.h (enum tui_bp_flag): New.
914 (tui_bp_flags): New enum flags type.
915 (struct tui_source_element) <break_mode>: Change type. Rename
916 from has_break.
917 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
918 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
919 constants.
920 * tui/tui-winsource.h: Fix comment.
921
922 2019-07-04 Alan Hayward <alan.hayward@arm.com>
923
924 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
925 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
926 (store_fpregs_to_thread)
927 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
928 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
929 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
930 (IWMMXT_REGS_SIZE): Add define.
931 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
932 (fetch_vfp_regs, store_vfp_regs)
933 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
934 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
935
936 2019-07-04 Alan Hayward <alan.hayward@arm.com>
937
938 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
939 defines.
940 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
941 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
942 (ARM_INT_REGISTER_SIZE): ...to this.
943 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
944 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
945 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
946 (arm_linux_collect_gregset, supply_nwfpe_register)
947 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
948 defines.
949 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
950 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
951 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
952 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
953 (arm_return_in_memory, arm_store_return_value)
954 (arm_get_longjmp_target, arm_register_g_packet_guesses)
955 (arm_record_ld_st_multiple): Likewise.
956 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
957 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
958
959 2019-07-04 Alan Hayward <alan.hayward@arm.com>
960
961 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
962 AARCH64_DISPLACED_MODIFIED_INSNS.
963 * aarch64-tdep.c (struct aarch64_displaced_step_data)
964 (aarch64_displaced_step_copy_insn): Likewise.
965 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
966 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
967 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
968 ARM_DISPLACED_MODIFIED_INSNS.
969 * arm-tdep.c (arm_gdbarch_init): Likewise.
970 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
971 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
972 (struct arm_displaced_step_closure): Use
973 ARM_DISPLACED_MODIFIED_INSNS.
974
975 2019-07-04 Alan Hayward <alan.hayward@arm.com>
976
977 * features/Makefile: Remove unused xml files.
978 * features/aarch64.xml: Remove.
979 * features/i386/amd64-avx-avx512-linux.xml: Remove.
980 * features/i386/amd64-avx-avx512.xml: Remove.
981 * features/i386/amd64-avx-linux.xml: Remove.
982 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
983 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
984 * features/i386/amd64-avx-mpx-linux.xml: Remove.
985 * features/i386/amd64-avx-mpx.xml: Remove.
986 * features/i386/amd64-avx.xml: Remove.
987 * features/i386/amd64-linux.xml: Remove.
988 * features/i386/amd64-mpx-linux.xml: Remove.
989 * features/i386/amd64-mpx.xml: Remove.
990 * features/i386/amd64.xml: Remove.
991 * features/i386/i386-avx-avx512-linux.xml: Remove.
992 * features/i386/i386-avx-avx512.xml: Remove.
993 * features/i386/i386-avx-linux.xml: Remove.
994 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
995 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
996 * features/i386/i386-avx-mpx-linux.xml: Remove.
997 * features/i386/i386-avx-mpx.xml: Remove.
998 * features/i386/i386-avx.xml: Remove.
999 * features/i386/i386-linux.xml: Remove.
1000 * features/i386/i386-mmx-linux.xml: Remove.
1001 * features/i386/i386-mmx.xml: Remove.
1002 * features/i386/i386-mpx-linux.xml: Remove.
1003 * features/i386/i386-mpx.xml: Remove.
1004 * features/i386/i386.xml: Remove.
1005 * features/i386/x32-avx-avx512-linux.xml: Remove.
1006 * features/i386/x32-avx-linux.xml: Remove.
1007 * features/i386/x32-linux.xml: Remove.
1008
1009 2019-07-04 Alan Hayward <alan.hayward@arm.com>
1010
1011 * regformats/aarch64.dat: Remove.
1012 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1013 * regformats/i386/amd64-avx-linux.dat: Remove.
1014 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1015 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1016 * regformats/i386/amd64-linux.dat: Remove.
1017 * regformats/i386/amd64-mpx-linux.dat: Remove.
1018 * regformats/i386/amd64.dat: Remove.
1019 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1020 * regformats/i386/i386-avx-linux.dat: Remove.
1021 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1022 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1023 * regformats/i386/i386-linux.dat: Remove.
1024 * regformats/i386/i386-mmx-linux.dat: Remove.
1025 * regformats/i386/i386-mpx-linux.dat: Remove.
1026 * regformats/i386/i386.dat: Remove.
1027 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1028 * regformats/i386/x32-avx-linux.dat: Remove.
1029 * regformats/i386/x32-linux.dat: Remove.
1030
1031 2019-07-04 Alan Hayward <alan.hayward@arm.com>
1032
1033 * aarch64-tdep.c: Remove xml self tests.
1034 * amd64-linux-tdep.c: Likewise.
1035 * amd64-tdep.c: Likewise.
1036 * i386-linux-tdep.c: Likewise.
1037 * i386-tdep.c: Likewise.
1038
1039 2019-07-03 Pedro Alves <palves@redhat.com>
1040
1041 PR cli/24732
1042 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1043 (pipe_cmd_option_defs): New.
1044 (make_pipe_cmd_options_def_group): New.
1045 (pipe_command): Use gdb::option::process_options.
1046 (pipe_command_completer): New function.
1047 (_initialize_cli_cmds): Install completer for "pipe" command.
1048
1049 2019-07-03 Pedro Alves <palves@redhat.com>
1050
1051 * cli/cli-option.c (union option_value) <string>: New field.
1052 (struct option_def_and_value): Add ctor, move ctor, dtor and
1053 use DISABLE_COPY_AND_ASSIGN.
1054 (option_def_and_value::clear_value): New.
1055 (parse_option, save_option_value_in_ctx, get_val_type_str)
1056 (add_setshow_cmds_for_options): Handle var_string.
1057 * cli-option.h (union option_def::var_address) <string>: New
1058 field.
1059 (struct string_option_def): New.
1060 * maint-test-options.c (struct test_options_opts): Add default
1061 ctor and use DISABLE_COPY_AND_ASSIGN.
1062 <string_opt>: New field.
1063 (test_options_opts::~test_options_opts): New.
1064 (test_options_opts::dump): Also dump "-string".
1065 (test_options_option_defs): Install "string.
1066
1067 2019-07-03 Pedro Alves <palves@redhat.com>
1068
1069 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1070 option_value with a null enumeration.
1071 (complete_options): Save the option values in the context.
1072 (save_option_value_in_ctx): New, factored out from ...
1073 (process_options): ... here.
1074 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1075 of the function.
1076 * maint-test-options.c (test_options_opts::dump): New, factored
1077 out from ...
1078 (maintenance_test_options_command_mode): ... here.
1079 (maintenance_test_options_command_completion_result): Delete.
1080 (maintenance_test_options_command_completion_text): Update
1081 comment.
1082 (maintenance_show_test_options_completion_result): Change
1083 prototype. Just print
1084 maintenance_test_options_command_completion_text.
1085 (save_completion_result): New.
1086 (maintenance_test_options_completer_mode): Pass options context to
1087 complete_options, and then save a dump.
1088 (_initialize_maint_test_options): Use add_cmd to install "maint
1089 show test-options-completion-result".
1090
1091 2019-07-03 Pedro Alves <palves@redhat.com>
1092
1093 * NEWS (New commands): Mention "with" and "maint with".
1094 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1095 (with_command, with_command_completer): New.
1096 (pipe_command): Adjust to new repeat_previous
1097 interface.
1098 (_initialize_cli_cmds): Install the "with" command and its "w"
1099 alias.
1100 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1101 declarations.
1102 * cli/cli-setshow.c (parse_cli_var_uinteger)
1103 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1104 argument strings for all var_types.
1105 (get_setshow_command_value_string): New, factored out from ...
1106 (do_show_command): ... this.
1107 * cli/cli-setshow.h: Include <string>.
1108 (get_setshow_command_value_string): Declare.
1109 * command.h (repeat_previous): Now returns const char *. Adjust
1110 comment.
1111 * maint.c: Include "cli/cli-cmds.h".
1112 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1113 (_initialize_maint_cmds): Register the "maintenance with" command.
1114 * top.c (repeat_previous): Move bits from pipe_command here:
1115 Return the saved command line, if any; error out if there's no
1116 command to relaunch.
1117
1118 2019-07-03 Pedro Alves <palves@redhat.com>
1119
1120 * NEWS (New commands): Mention "maint set/show test-settings"
1121 instead of "maint test-settings".
1122 * maint-test-settings.c (maintenance_test_settings_list): Delete.
1123 (maintenance_test_settings_set_list): Rename to ...
1124 (maintenance_set_test_settings_list): ... this.
1125 (maintenance_test_settings_show_list): Rename to ...
1126 (maintenance_show_test_settings_list): ... this.
1127 (maintenance_test_settings_cmd): Delete.
1128 (maintenance_test_settings_set_cmd): ...
1129 (maintenance_set_test_settings_cmd): ... this.
1130 (maintenance_test_settings_show_cmd): ...
1131 (maintenance_show_test_settings_cmd): ... this.
1132 (maintenance_test_settings_show_value_cmd):
1133 (maintenance_show_test_settings_value_cmd): ... this.
1134 (_initialize_maint_test_settings): No longer install the "maint
1135 test-settings" prefix command. Rename "maint test-settings set"
1136 to "maint set test-settings", and "maint test-settings show" to
1137 "maint show test-settings". Adjust all subcommands.
1138
1139 2019-07-03 Pedro Alves <palves@redhat.com>
1140
1141 * maint-test-settings.c: Fix file's intro comment. Replace all
1142 references to "test-options" with references to "test-settings",
1143 in comments.
1144
1145 2019-07-03 Pedro Alves <palves@redhat.com>
1146
1147 * maint-test-settings.c (maintenance_test_settings_xxx)
1148 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1149 New.
1150 (maintenance_test_settings_enums): Use them.
1151 (maintenance_test_settings_enum): Default to
1152 maintenance_test_settings_xxx.
1153 (_initialize_maint_test_settings): Initialize
1154 MAINTENANCE_TEST_SETTINGS_FILENAME.
1155
1156 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
1157
1158 * breakpoint.h (remove_breakpoints_inf): Change return type to
1159 void, move function documentation here.
1160 * breakpoint.c (remove_breakpoints_inf): Change return type to
1161 void, move function documentation to header.
1162
1163 2019-07-02 Pedro Alves <palves@redhat.com>
1164
1165 * NEWS (Completion improvements): Mention "info threads".
1166 * thread.c (struct info_threads_opts, info_threads_option_defs)
1167 (make_info_threads_options_def_group): New.
1168 (info_threads_command): Use gdb::option::process_options.
1169 (info_threads_command_completer): New.
1170 (_initialize_thread): Use gdb::option::build_help to build the
1171 help text for "info threads".
1172
1173 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
1174
1175 * defs.h (generic_load): Move from here...
1176 * symfile.h (generic_load): ... to here. Rename name parameter
1177 to args.
1178 * symfile.c (generic_load): Add comment.
1179
1180 2019-07-01 Tom Tromey <tromey@adacore.com>
1181
1182 * dwarf2read.c
1183 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1184 declaration of without_params. Fix formatting.
1185
1186 2019-07-01 Tom Tromey <tromey@adacore.com>
1187
1188 * ada-exp.y (find_primitive_type): Update.
1189 * ada-lang.h (ada_lookup_symbol): Update.
1190 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1191 parameter.
1192 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1193
1194 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
1195
1196 PR breakpoints/24541
1197 * gdbarch.c: Regenerate.
1198 * gdbarch.h: Regenerate.
1199 * gdbarch.sh: Add 'stap_adjust_register'.
1200 * i386-tdep.c: Include '<unordered_set>'.
1201 (i386_stap_adjust_register): New function.
1202 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1203 * stap-probe.c (stap_parse_register_operand): Call
1204 'gdbarch_stap_adjust_register'.
1205
1206 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
1207
1208 PR python/24742
1209 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1210 * python/python.c (do_start_initialization): Use 'xmalloc'
1211 instead of 'PyMem_Malloc'.
1212
1213 2019-06-28 Tom Tromey <tromey@adacore.com>
1214
1215 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1216 for Ada.
1217
1218 2019-06-27 Tom Tromey <tromey@adacore.com>
1219
1220 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
1221 objfile_key.
1222 (arm_find_mapping_symbol, arm_record_special_symbol)
1223 (_initialize_arm_tdep): Update.
1224 (arm_objfile_data_free): Remove.
1225
1226 2019-06-27 Tom Tromey <tromey@adacore.com>
1227
1228 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1229 to cp_print_static_field.
1230
1231 2019-06-26 Tom Tromey <tromey@adacore.com>
1232
1233 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1234 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1235 declare.
1236
1237 2019-06-26 Alan Hayward <alan.hayward@arm.com>
1238
1239 * features/aarch64-core.c (create_feature_aarch64_core):
1240 Regenerate.
1241 * features/aarch64-core.xml: Add cpsr flags.
1242
1243 2019-06-26 Alan Hayward <alan.hayward@arm.com>
1244
1245 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1246 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1247
1248 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
1249
1250 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1251 field.
1252 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1253 use.
1254 (arm_record_special_symbol): Don't insert new symbol in sorted
1255 position, push it at the end.
1256
1257 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
1258
1259 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1260 (arm_mapping_symbol_s): Remove.
1261 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1262 (arm_mapping_symbol_vec): New typedef.
1263 (struct arm_per_objfile): Add constructor.
1264 <section_maps>: Change type to
1265 std::unique_ptr<arm_mapping_symbol_vec[]>.
1266 (arm_compare_mapping_symbols): Remove.
1267 (arm_find_mapping_symbol): Adjust to section_maps type change.
1268 (arm_objfile_data_free): Call delete on arm_per_objfile.
1269 (arm_record_special_symbol): Adjust to section_maps type change.
1270 Allocate arm_per_objfile with new.
1271
1272 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1273
1274 * cli/cli-cmds.c (alias_command): Compare the alias prefix
1275 with the command prefix.
1276
1277 2019-06-25 Tom Tromey <tom@tromey.com>
1278
1279 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1280 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1281
1282 2019-06-25 Tom Tromey <tom@tromey.com>
1283
1284 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1285 type.
1286 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1287 protected.
1288
1289 2019-06-25 Tom Tromey <tom@tromey.com>
1290
1291 * tui/tui-winsource.c
1292 (tui_source_window_base::set_is_exec_point_at): Add check against
1293 LOA_ADDRESS.
1294
1295 2019-06-25 Tom Tromey <tom@tromey.com>
1296
1297 * tui/tui-source.c (tui_set_source_content): Don't check before
1298 xfree.
1299 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1300
1301 2019-06-25 Tom Tromey <tom@tromey.com>
1302
1303 * tui/tui-winsource.h (tui_update_source_window_as_is)
1304 (tui_alloc_source_buffer, tui_line_is_displayed)
1305 (tui_addr_is_displayed): Change type of win_info.
1306 * tui/tui-winsource.c (tui_update_source_window_as_is)
1307 (tui_clear_source_content, tui_show_source_line)
1308 (tui_show_source_content, tui_source_window_base::refill)
1309 (tui_source_window_base::set_is_exec_point_at)
1310 (tui_source_window_base::set_is_exec_point_at)
1311 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1312 (tui_alloc_source_buffer, tui_line_is_displayed)
1313 (tui_addr_is_displayed): Change type of win_info. Update.
1314 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1315 (tui_source_window_base::do_make_visible_with_new_height):
1316 Update.
1317 * tui/tui-source.c (tui_set_source_content)
1318 (tui_set_source_content_nil)
1319 (tui_source_window::do_scroll_vertical): Update.
1320 * tui/tui-layout.c (show_layout): Update.
1321 * tui/tui-disasm.c (tui_set_disassem_content)
1322 (tui_disasm_window::do_scroll_vertical): Update.
1323 * tui/tui-data.h (tui_win_content): Remove.
1324 (struct tui_gen_win_info) <content, content_size>: Remove.
1325 (struct tui_source_element): Add initializers and destructor.
1326 (union tui_which_element, struct tui_win_element): Remove.
1327 (struct tui_source_window_base) <content>: New field.
1328 (struct tui_data_window): Remove destructor.
1329 (tui_alloc_content, tui_free_win_content)
1330 (tui_free_all_source_wins_content): Don't declare.
1331 * tui/tui-data.c (tui_initialize_static_data): Update.
1332 (init_content_element, tui_alloc_content): Remove.
1333 (~tui_gen_win_info): Update.
1334 (~tui_data_window, tui_free_all_source_wins_content)
1335 (tui_free_win_content, free_content, free_content_elements):
1336 Remove.
1337
1338 2019-06-25 Tom Tromey <tom@tromey.com>
1339
1340 * tui/tui-winsource.h (tui_clear_source_content)
1341 (tui_erase_source_content, tui_show_source_content): Change type
1342 of win_info.
1343 * tui/tui-winsource.c (tui_clear_source_content)
1344 (tui_erase_source_content, tui_show_source_content): Change type
1345 of win_info.
1346 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1347 * tui/tui-source.h (tui_set_source_content_nil): Change type of
1348 win_info.
1349 * tui/tui-source.c (tui_set_source_content_nil): Change type of
1350 win_info.
1351 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1352
1353 2019-06-25 Tom Tromey <tom@tromey.com>
1354
1355 * tui/tui-winsource.c (tui_clear_source_content)
1356 (tui_source_window_base::set_is_exec_point_at): Update.
1357 * tui/tui-source.c (tui_set_source_content_nil): Update.
1358 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1359 a bool.
1360 * tui/tui-data.c (init_content_element): Update.
1361
1362 2019-06-25 Tom Tromey <tom@tromey.com>
1363
1364 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1365 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1366 * tui/tui-layout.c (init_and_make_win): Update.
1367 * tui/tui.h (enum tui_win_type): Update.
1368 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1369 tui_win_is_auxillary.
1370 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1371 tui_win_is_auxillary.
1372
1373 2019-06-25 Tom Tromey <tom@tromey.com>
1374
1375 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1376 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1377 (tui_delete_data_content_windows, tui_display_all_data)
1378 (tui_data_window::do_scroll_vertical, tui_display_data_from):
1379 Update.
1380 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1381 * tui/tui-regs.c (tui_last_regs_line_no)
1382 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1383 (tui_show_registers): Update.
1384 (tui_show_register_group): Return void. Update.
1385 (tui_display_registers_from, tui_display_reg_element_at_line)
1386 (tui_display_registers_from_line, tui_check_register_values):
1387 Update.
1388 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1389 member.
1390 (struct tui_data_window) <regs_content>: Now a std::vector.
1391 <regs_content_count>: Remove.
1392 (tui_add_content_elements, tui_free_data_content): Don't declare.
1393 * tui/tui-data.c (tui_data_window::clear_detail): Update.
1394 (init_content_element): Remove DATA_WIN case. Add assert.
1395 (tui_add_content_elements): Remove.
1396 (tui_data_window): Update.
1397 (tui_free_data_content): Remove.
1398 (free_content_elements): Remove DATA_WIN case.
1399
1400 2019-06-25 Tom Tromey <tom@tromey.com>
1401
1402 * tui/tui-data.c (tui_data_item_window): Update.
1403 * tui/tui-windata.h (tui_check_data_values): Don't declare.
1404 * tui/tui-windata.c (tui_display_all_data)
1405 (tui_display_data_from_line): Update.
1406 (tui_check_data_values): Remove.
1407 * tui/tui-regs.c (tui_show_register_group)
1408 (tui_display_reg_element_at_line): Update.
1409 * tui/tui-hooks.c (tui_register_changed)
1410 (tui_refresh_frame_and_register_information): Call
1411 tui_check_register_values.
1412 * tui/tui-data.h (struct tui_data_window) <data_content,
1413 data_content_count, data_type>: Remove.
1414 (enum tui_data_type): Remove.
1415
1416 * tui/tui-data.c (tui_data_window::clear_detail)
1417 (~tui_data_window): Update.
1418
1419 2019-06-25 Tom Tromey <tom@tromey.com>
1420
1421 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1422 declare.
1423 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1424 Rename from tui_first_data_item_displayed. Update.
1425 (tui_data_window::refresh_all)
1426 (tui_data_window::do_scroll_vertical): Update.
1427 * tui/tui-data.h (struct tui_data_window)
1428 <first_data_item_displayed>: Declare new method.
1429
1430 2019-06-25 Tom Tromey <tom@tromey.com>
1431
1432 * tui/tui-data.h (tui_init_generic_part): Don't declare.
1433 * tui/tui-data.c (tui_init_generic_part): Remove, moving
1434 contents...
1435 (tui_initialize_static_data): ...here.
1436
1437 2019-06-25 Tom Tromey <tom@tromey.com>
1438
1439 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1440 (tui_display_registers_from, tui_check_register_values): Update.
1441 (tui_display_register): Remove win_info parameter; update.
1442 (tui_get_register): Change type of parameters.
1443 * tui/tui-data.h (struct tui_data_element): Remove.
1444 (union tui_which_element) <data>: Remove.
1445 <data_window>: Change type.
1446 (struct tui_data_item_window): New.
1447 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1448 case. Add assert.
1449 (~tui_data_item_window): New destructor.
1450 (free_content_elements): Remove DATA_ITEM_WIN case.
1451
1452 2019-06-25 Tom Tromey <tom@tromey.com>
1453
1454 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1455 Remove.
1456
1457 2019-06-25 Tom Tromey <tom@tromey.com>
1458
1459 * tui/tui-data.h (struct tui_command_element): Remove.
1460 (union tui_which_element) <command>: Remove.
1461 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
1462 assert.
1463 (free_content_elements): Remove CMD_WIN case.
1464
1465 2019-06-25 Tom Tromey <tom@tromey.com>
1466
1467 * tui/tui-layout.c (tui_set_layout): Update.
1468 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1469 * tui/tui-data.c (layout_def): Update.
1470
1471 2019-06-25 Tom Tromey <tom@tromey.com>
1472
1473 * tui/tui-wingeneral.c (tui_refresh_all): Update.
1474 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1475 (tui_source_window_base::set_new_height): Update.
1476 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1477 Update.
1478 (tui_set_locator_fullname, tui_set_locator_info)
1479 (tui_show_frame_info): Update.
1480 * tui/tui-source.c (tui_set_source_content)
1481 (tui_source_is_displayed): Update.
1482 * tui/tui-layout.c (show_source_disasm_command, show_data)
1483 (show_source_or_disasm_and_command): Update.
1484 * tui/tui-disasm.c (tui_set_disassem_content)
1485 (tui_get_begin_asm_address): Update.
1486 * tui/tui-data.h (struct tui_locator_element): Remove.
1487 (union tui_which_element) <locator>: Remove.
1488 (struct tui_locator_window): New.
1489 (tui_locator_win_info_ptr): Change return type.
1490 * tui/tui-data.c (_locator): Change type.
1491 (tui_locator_win_info_ptr): Change return type.
1492 (init_content_element): Remove LOCATOR_WIN case. Add assert.
1493 (tui_alloc_content): Add assert.
1494
1495 2019-06-25 Tom Tromey <tom@tromey.com>
1496
1497 * tui/tui-winsource.c
1498 (tui_exec_info_window::maybe_allocate_content): New method.
1499 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1500 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1501 (make_source_or_disasm_window): Add cast.
1502 * tui/tui-data.h (union tui_which_element) <simple_string>:
1503 Remove.
1504 (struct tui_source_info): New.
1505 (struct tui_source_window_base) <execution_info>: Change type.
1506 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1507 case, and add assert.
1508 (tui_alloc_content): Add assert.
1509
1510 2019-06-25 Tom Tromey <tom@tromey.com>
1511
1512 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1513 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1514 * tui/tui-data.c (tui_alloc_win_info): Remove.
1515
1516 2019-06-25 Tom Tromey <tom@tromey.com>
1517
1518 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1519 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1520 can_highlight.
1521
1522 2019-06-25 Tom Tromey <tom@tromey.com>
1523
1524 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1525 make_visible_with_new_height method.
1526 (tui_win_info::make_visible_with_new_height): New method.
1527 (tui_source_window_base::do_make_visible_with_new_height)
1528 (tui_data_window::do_make_visible_with_new_height)
1529 (tui_cmd_window::do_make_visible_with_new_height): New methods.
1530 (make_visible_with_new_height): Remove.
1531 (tui_resize_all, tui_adjust_win_heights): Use
1532 make_visible_with_new_height method.
1533 * tui/tui-data.h (struct tui_win_info)
1534 <do_make_visible_with_new_height, make_visible_with_new_height>:
1535 New methods.
1536 (struct tui_source_window_base, struct tui_data_window)
1537 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1538 methods.
1539
1540 2019-06-25 Tom Tromey <tom@tromey.com>
1541
1542 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1543 method.
1544 (update_tab_width): Call update_tab_width method.
1545 * tui/tui-data.h (struct tui_win_info)
1546 (struct tui_source_window_base) <update_tab_width>: New methods.
1547
1548 2019-06-25 Tom Tromey <tom@tromey.com>
1549
1550 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1551 parameter.
1552 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1553 parameter.
1554 (tui_gen_win_info::make_visible): Update.
1555 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1556 parameter.
1557 * tui/tui-data.h (enum tui_box): New enum.
1558 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1559
1560 2019-06-25 Tom Tromey <tom@tromey.com>
1561
1562 * tui/tui-layout.c (make_source_or_disasm_window): Always use
1563 init_and_make_win for EXEC_INFO_WIN.
1564 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1565 longer inline.
1566 (struct tui_win_info) <~tui_win_info>: Inline.
1567 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1568 Don't declare.
1569 * tui/tui-data.c (source_win, disasm_win): Remove globals.
1570 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1571 Remove.
1572 (tui_initialize_static_data): Update.
1573 (~tui_gen_win_info): Handle more cleanup here.
1574 (~tui_source_window_base): Delete "execution_info".
1575 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1576
1577 2019-06-25 Tom Tromey <tom@tromey.com>
1578
1579 * tui/tui-layout.c (make_command_window): Don't set
1580 can_highlight.
1581 (show_source_disasm_command): Call the reset method.
1582 (show_data): Don't set can_highlight. Call the reset method.
1583 (tui_gen_win_info::reset): Rename from init_gen_win_info
1584 (init_and_make_win): Simplify. Return tui_gen_win_info.
1585 (show_source_or_disasm_and_command): Call the reset method.
1586 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1587 (struct tui_cmd_window): Set can_highlight.
1588
1589 2019-06-25 Tom Tromey <tom@tromey.com>
1590
1591 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1592 from make_visible.
1593 (tui_make_visible, tui_make_invisible): Rewrite.
1594 (tui_win_info::make_visible): Remove.
1595 (tui_source_window_base::make_visible): Update.
1596 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1597 method. Moved from...
1598 (struct tui_win_info) <make_visible>: ...here.
1599
1600 2019-06-25 Tom Tromey <tom@tromey.com>
1601
1602 * tui/tui-winsource.c
1603 (tui_source_window_base::do_scroll_horizontal): Remove direction
1604 parameter.
1605 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1606 direction parameter.
1607 * tui/tui-win.c (tui_win_info::forward_scroll)
1608 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1609 (tui_win_info::right_scroll): Update.
1610 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1611 direction parameter.
1612 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1613 direction parameter.
1614 * tui/tui-data.h (enum tui_scroll_direction): Remove.
1615 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1616 Remove direction parameter.
1617 (struct tui_source_window_base, struct tui_source_window)
1618 (struct tui_disasm_window, struct tui_data_window)
1619 (struct tui_cmd_window): Update.
1620
1621 2019-06-25 Tom Tromey <tom@tromey.com>
1622
1623 * tui/tui-winsource.h (tui_set_exec_info_content)
1624 (tui_show_exec_info_content, tui_erase_exec_info_content)
1625 (tui_clear_exec_info_content, tui_update_exec_info): Change
1626 argument to tui_source_window_base.
1627 * tui/tui-winsource.c (tui_set_exec_info_content)
1628 (tui_show_exec_info_content, tui_erase_exec_info_content)
1629 (tui_clear_exec_info_content, tui_update_exec_info): Change
1630 argument to tui_source_window_base.
1631
1632 2019-06-25 Tom Tromey <tom@tromey.com>
1633
1634 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1635 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1636
1637 2019-06-25 Tom Tromey <tom@tromey.com>
1638
1639 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1640 check.
1641
1642 2019-06-25 Tom Tromey <tom@tromey.com>
1643
1644 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1645 type to void.
1646 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1647 type to void.
1648 * tui/tui-source.c (tui_set_source_content): Update.
1649 * tui/tui-disasm.c (tui_set_disassem_content): Update.
1650
1651 2019-06-25 Tom Tromey <tom@tromey.com>
1652
1653 * tui/tui-win.c (window_name_completer, tui_set_focus)
1654 (tui_all_windows_info): Use name method.
1655 * tui/tui-data.h (struct tui_gen_win_info)
1656 (struct tui_source_window, struct tui_disasm_window)
1657 (struct tui_data_window, struct tui_cmd_window) <name>: New
1658 method.
1659 (tui_win_name): Don't declare.
1660 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1661 (tui_win_name): Remove.
1662
1663 2019-06-25 Tom Tromey <tom@tromey.com>
1664
1665 * tui/tui-winsource.h (tui_update_source_window)
1666 (tui_update_source_window_as_is): Change parameter type.
1667 * tui/tui-winsource.c (tui_update_source_window): Change win_info
1668 to be a tui_source_window_base.
1669 (tui_update_source_window_as_is): Likewise.
1670 * tui/tui-win.c (make_visible_with_new_height): Update.
1671
1672 2019-06-25 Tom Tromey <tom@tromey.com>
1673
1674 * tui/tui-winsource.c (tui_erase_source_content)
1675 (tui_show_source_content, tui_show_exec_info_content)
1676 (tui_erase_exec_info_content): Use refresh_window method.
1677 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1678 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1679 from tui_refresh_win.
1680 (tui_data_window::refresh_window): New method.
1681 (tui_win_info::refresh, tui_source_window_base::refresh)
1682 (tui_refresh_all): Use refresh_window method.
1683 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1684 method.
1685 * tui/tui-regs.c (tui_display_register): Call refresh_window
1686 method.
1687 * tui/tui-layout.c (show_source_disasm_command)
1688 (show_source_or_disasm_and_command): Call refresh_window method.
1689 * tui/tui-data.h (struct tui_gen_win_info)
1690 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1691 New method.
1692
1693 2019-06-25 Tom Tromey <tom@tromey.com>
1694
1695 * tui/tui.c (tui_rl_other_window, tui_enable)
1696 (tui_is_window_visible, tui_get_command_dimension): Update.
1697 * tui/tui-winsource.c (tui_update_source_window_as_is)
1698 (tui_clear_source_content, tui_erase_source_content)
1699 (tui_show_source_line, tui_source_window_base::refill)
1700 (tui_source_window_base::do_scroll_horizontal)
1701 (tui_source_window_base::set_is_exec_point_at)
1702 (tui_update_breakpoint_info, tui_set_exec_info_content)
1703 (tui_alloc_source_buffer, tui_line_is_displayed)
1704 (tui_addr_is_displayed): Update.
1705 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1706 (tui_check_and_display_highlight_if_needed)
1707 (tui_win_info::make_visible, tui_win_info::refresh)
1708 (tui_refresh_all): Update.
1709 * tui/tui-windata.c (tui_first_data_item_displayed)
1710 (tui_delete_data_content_windows, tui_erase_data_content)
1711 (tui_display_all_data, tui_data_window::refresh_all)
1712 (tui_check_data_values): Update.
1713 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1714 (tui_set_win_focus_to, tui_win_info::forward_scroll)
1715 (tui_win_info::backward_scroll, tui_refresh_all_win)
1716 (tui_resize_all, tui_set_focus, tui_all_windows_info)
1717 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1718 (tui_source_window_base::set_new_height)
1719 (tui_data_window::set_new_height)
1720 (make_invisible_and_set_new_height)
1721 (make_visible_with_new_height, new_height_ok)
1722 (parse_scrolling_args): Update.
1723 * tui/tui-stack.c (tui_show_frame_info): Update.
1724 * tui/tui-source.c (tui_set_source_content)
1725 (tui_set_source_content_nil, tui_source_is_displayed)
1726 (tui_source_window::do_scroll_vertical): Update.
1727 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1728 (tui_display_registers_from, tui_display_reg_element_at_line)
1729 (tui_check_register_values, tui_reg_command): Update.
1730 * tui/tui-layout.c (tui_default_win_height)
1731 (show_source_disasm_command, show_data, init_and_make_win)
1732 (show_source_or_disasm_and_command): Update.
1733 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1734 (tui_redisplay_readline, tui_mld_flush)
1735 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1736 (tui_getc): Update.
1737 * tui/tui-disasm.c (tui_set_disassem_content)
1738 (tui_disasm_window::do_scroll_vertical): Update.
1739 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1740 Now virtual.
1741 (struct tui_win_info): Derive from tui_gen_win_info.
1742 <~tui_win_info>: Mark as override.
1743 <generic>: Remove member.
1744 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1745 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1746 (~tui_data_window, ~tui_win_info)
1747 (tui_free_all_source_wins_content): Update.
1748 * tui/tui-command.c (tui_refresh_cmd_win): Update.
1749
1750 2019-06-25 Tom Tromey <tom@tromey.com>
1751
1752 * tui/tui-layout.c (init_and_make_win): Use new.
1753 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1754 destructor, initializers.
1755 (tui_alloc_generic_win_info): Don't declare.
1756 * tui/tui-data.c (_locator): Add argument to constructor.
1757 (source_win, disasm_win): New globals.
1758 (exec_info): Remove.
1759 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1760 Update.
1761 (tui_alloc_generic_win_info): Remove.
1762 (init_content_element): Use new.
1763 (tui_win_info::tui_win_info): Update.
1764 (free_content_elements) <case DATA_WIN>: Use delete.
1765
1766 2019-06-25 Tom Tromey <tom@tromey.com>
1767
1768 * tui/tui-wingeneral.c (tui_refresh_win): Update.
1769 * tui/tui-windata.c (tui_first_data_item_displayed)
1770 (tui_delete_data_content_windows): Update.
1771 * tui/tui-win.c (tui_data_window::set_new_height): Update.
1772 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1773 (tui_display_registers_from, tui_check_register_values): Update.
1774 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1775 pointer.
1776 * tui/tui-data.c (init_content_element): Update. Allocate the new
1777 window.
1778 (tui_free_data_content): Update.
1779 (free_content_elements) <case DATA_WIN>: Free the window.
1780
1781 2019-06-25 Tom Tromey <tom@tromey.com>
1782
1783 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1784 Update.
1785 * tui/tui-layout.c (make_command_window)
1786 (show_source_disasm_command, show_data, init_and_make_win)
1787 (show_source_or_disasm_and_command): Update.
1788 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1789 method.
1790 <can_highight, is_highlighted>: Now bool.
1791 (tui_set_win_highlight): Don't declare.
1792 * tui/tui-data.c (tui_set_win_highlight): Remove.
1793
1794 2019-06-25 Tom Tromey <tom@tromey.com>
1795
1796 * tui/tui-wingeneral.c (make_visible): Remove check of window
1797 type.
1798
1799 2019-06-25 Tom Tromey <tom@tromey.com>
1800
1801 * tui/tui-win.c (tui_win_info::max_height)
1802 (tui_cmd_window::max_height): New methods.
1803 (new_height_ok): Call max_height.
1804 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1805 <max_height>: New method.
1806
1807 2019-06-25 Tom Tromey <tom@tromey.com>
1808
1809 * tui/tui-win.c (tui_source_window_base::set_new_height)
1810 (tui_data_window::set_new_height): New methods.
1811 (make_invisible_and_set_new_height): Call set_new_height method.
1812 * tui/tui-data.h (struct tui_win_info)
1813 (struct tui_source_window_base, struct tui_data_window)
1814 <set_new_height>: New method.
1815
1816 2019-06-25 Tom Tromey <tom@tromey.com>
1817
1818 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1819 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1820 tui_refresh_data_win.
1821 * tui/tui-win.c (tui_source_window_base::refresh_all): New
1822 method.
1823 (tui_refresh_all_win): Call the refresh_all method.
1824 (tui_set_focus): Likewise.
1825 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1826 (struct tui_source_window_base, struct tui_data_window) <refresh>:
1827 Likewise.
1828
1829 2019-06-25 Tom Tromey <tom@tromey.com>
1830
1831 * tui/tui-winsource.h (tui_refill_source_window)
1832 (tui_set_is_exec_point_at): Don't declare.
1833 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1834 (tui_source_window_base::refill): Rename from
1835 tui_refill_source_window.
1836 (tui_source_window_base::do_scroll_horizontal): Update.
1837 (tui_source_window_base::set_is_exec_point_at): Rename from
1838 tui_set_is_exec_point_at.
1839 (tui_update_all_breakpoint_info): Update.
1840 * tui/tui-stack.c (tui_show_frame_info): Update.
1841 * tui/tui-layout.c (show_data): Add cast.
1842 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1843 * tui/tui-data.h (struct tui_source_window_base) <refill,
1844 set_is_exec_point_at>: New methods.
1845 (tui_source_windows, tui_add_to_source_windows): Update types.
1846 (tui_add_to_source_windows): Remove redundant declaration.
1847 * tui/tui-data.c (source_windows): Store tui_source_window_base.
1848 (tui_source_windows): Change return type.
1849 (tui_clear_source_windows_detail): Update.
1850 (tui_add_to_source_windows): Change type of parameter.
1851 (tui_free_all_source_wins_content): Update.
1852
1853 2019-06-25 Tom Tromey <tom@tromey.com>
1854
1855 * tui/tui-wingeneral.c (tui_win_info::refresh)
1856 (tui_source_window_base::refresh): New methods.
1857 (tui_refresh_all): Call the refresh method.
1858 * tui/tui-data.h (struct tui_win_info)
1859 (struct tui_source_window_base) <refresh>: New method.
1860
1861 2019-06-25 Tom Tromey <tom@tromey.com>
1862
1863 * tui/tui.h (tui_is_window_visible): Return bool.
1864 * tui/tui.c (tui_is_window_visible): Return bool.
1865 * tui/tui-wingeneral.c (tui_make_window, make_visible)
1866 (tui_make_visible, tui_make_invisible)
1867 (tui_win_info::make_visible)
1868 (tui_source_window_base::make_visible, make_all_visible)
1869 (tui_make_all_visible, tui_make_all_invisible): Update.
1870 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1871 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1872 bool.
1873 (struct tui_win_info, struct tui_source_window_base)
1874 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1875 * tui/tui-data.c (tui_init_generic_part): Update.
1876
1877 2019-06-25 Tom Tromey <tom@tromey.com>
1878
1879 * tui/tui-wingeneral.c (tui_win_info::make_visible)
1880 (tui_source_window_base::make_visible): New methods.
1881 (make_all_visible): Make method call.
1882 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1883 (struct tui_source_window_base, struct tui_cmd_window): Override
1884 make_visible.
1885 (tui_win_is_source_type): Don't declare.
1886 * tui/tui-data.c (tui_win_is_source_type): Remove.
1887
1888 2019-06-25 Tom Tromey <tom@tromey.com>
1889
1890 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1891 NULL check.
1892
1893 2019-06-25 Tom Tromey <tom@tromey.com>
1894
1895 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1896 Inline constructor. Add initializers for members.
1897 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1898 constructors; now inline in class.
1899
1900 2019-06-25 Tom Tromey <tom@tromey.com>
1901
1902 * tui/tui-regs.c (tui_show_registers): Update.
1903 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1904 bool.
1905 * tui/tui-data.c (tui_data_window::clear_detail)
1906 (tui_data_window): Update.
1907
1908 2019-06-25 Tom Tromey <tom@tromey.com>
1909
1910 * tui/tui-windata.c (tui_display_all_data)
1911 (tui_display_data_from_line, tui_display_data_from)
1912 (tui_check_data_values, tui_data_window::do_scroll_vertical):
1913 Update.
1914 * tui/tui-regs.c (tui_last_regs_line_no)
1915 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1916 (tui_show_registers, tui_show_register_group)
1917 (tui_display_registers_from, tui_display_reg_element_at_line)
1918 (tui_display_registers_from_line, tui_check_register_values)
1919 (tui_reg_next, tui_reg_prev): Update.
1920 * tui/tui-layout.c (tui_set_layout, show_data): Update.
1921 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
1922 tui_data_window.
1923 (struct tui_win_info) <detail>: Remove. Add new fields from
1924 tui_data_info.
1925 (TUI_DATA_WIN): Add cast.
1926 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1927 (~tui_data_window): Simplify.
1928
1929 2019-06-25 Tom Tromey <tom@tromey.com>
1930
1931 * tui/tui-layout.c (show_source_disasm_command)
1932 (show_source_or_disasm_and_command): Update.
1933 * tui/tui-io.c (update_cmdwin_start_line)
1934 (tui_redisplay_readline): Update.
1935 * tui/tui-data.h (struct tui_command_info): Remove.
1936 (struct tui_win_info) <detail>: Remove command_info member.
1937 (struct tui_data_window) <start_line>: New member, from
1938 tui_command_info.
1939 (TUI_CMD_WIN): Add casts.
1940
1941 2019-06-25 Tom Tromey <tom@tromey.com>
1942
1943 * tui/tui-winsource.c (tui_update_source_window)
1944 (tui_refill_source_window)
1945 (tui_source_window_base::do_scroll_horizontal)
1946 (tui_update_breakpoint_info, tui_set_exec_info_content)
1947 (tui_show_exec_info_content, tui_erase_exec_info_content)
1948 (tui_clear_exec_info_content): Update.
1949 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1950 Update.
1951 * tui/tui-win.c (make_invisible_and_set_new_height)
1952 (make_visible_with_new_height): Update.
1953 * tui/tui-source.c (tui_set_source_content)
1954 (tui_show_symtab_source): Update.
1955 * tui/tui-layout.c (extract_display_start_addr)
1956 (show_source_disasm_command, show_data)
1957 (make_source_or_disasm_window)
1958 (show_source_or_disasm_and_command): Update.
1959 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1960 (tui_disasm_window::do_scroll_vertical): Remove shadowing
1961 "gdbarch".
1962 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
1963 to tui_source_window_base.
1964 (struct tui_win_info) <detail>: Remove source_info member.
1965 (struct tui_source_window_base) <has_locator>: Inline.
1966 Move contents from tui_source_info; rename has_locator member to
1967 m_has_locator.
1968 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1969 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1970 header file.
1971 (tui_source_window_base::clear_detail, ~tui_source_window_base):
1972 Simplify.
1973 (tui_free_all_source_wins_content): Cast to
1974 tui_source_window_base.
1975
1976 2019-06-25 Tom Tromey <tom@tromey.com>
1977
1978 * tui/tui-win.c (make_invisible_and_set_new_height)
1979 (make_visible_with_new_height): Call has_locator method.
1980 * tui/tui-layout.c (show_source_disasm_command, show_data)
1981 (show_source_or_disasm_and_command): Update for bool change.
1982 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1983 (tui_win_info) <has_locator>: New method.
1984 (struct tui_source_window_base) <has_locator>: New method.
1985 (tui_win_has_locator): Don't declare.
1986 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1987 from tui_win_has_locator.
1988 (tui_source_window_base): Use false, not FALSE.
1989
1990 2019-06-25 Tom Tromey <tom@tromey.com>
1991
1992 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1993 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1994 clear_detail method directly.
1995 (tui_clear_win_detail): Remove.
1996
1997 2019-06-25 Tom Tromey <tom@tromey.com>
1998
1999 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2000 "this", not TUI_DISASM_WIN.
2001
2002 2019-06-25 Tom Tromey <tom@tromey.com>
2003
2004 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
2005 declare.
2006 * tui/tui-winsource.c
2007 (tui_source_window_base::do_scroll_horizontal): Rename from
2008 tui_horizontal_source_scroll.
2009 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2010 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2011 from tui_vertical_data_scroll.
2012 * tui/tui-win.h (tui_scroll): Don't declare.
2013 * tui/tui-win.c (tui_win_info::forward_scroll)
2014 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2015 (tui_win_info::right_scroll): Rename and update.
2016 (tui_scroll_forward_command, tui_scroll_backward_command)
2017 (tui_scroll_left_command, tui_scroll_right_command): Update.
2018 (tui_scroll): Remove.
2019 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2020 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2021 from tui_vertical_source_scroll.
2022 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2023 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2024 from tui_vertical_disassem_scroll.
2025 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2026 do_scroll_horizontal>: New methods.
2027 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2028 Likewise.
2029 (struct tui_source_window_base): Add do_scroll_horizontal.
2030 (struct tui_source_window, struct tui_disasm_window): Add
2031 do_scroll_vertical.
2032 (struct tui_data_window, struct tui_cmd_window): Add
2033 do_scroll_horizontal and do_scroll_vertical.
2034 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2035
2036 2019-06-25 Tom Tromey <tom@tromey.com>
2037
2038 * tui/tui-data.h (struct tui_source_window_base): New struct.
2039 (struct tui_source_window): Derive from tui_source_window_base.
2040 (struct tui_disasm_window): New struct.
2041 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2042 from tui_source_window::clear_detail.
2043 (tui_source_window_base): Rename from tui_source_window.
2044 (~tui_source_window_base): Rename from ~tui_source_window.
2045 (tui_alloc_win_info): Create a tui_disasm_window.
2046
2047 2019-06-25 Tom Tromey <tom@tromey.com>
2048
2049 * tui/tui-data.h (struct tui_source_window)
2050 (struct tui_data_window): Declare destructors.
2051 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2052 destructors.
2053 (tui_win_info): Simplify.
2054
2055 2019-06-25 Tom Tromey <tom@tromey.com>
2056
2057 * tui/tui-winsource.c (tui_display_main)
2058 (tui_update_source_windows_with_addr)
2059 (tui_update_all_breakpoint_info): Update.
2060 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2061 (new_height_ok, parse_scrolling_args): Update.
2062 * tui/tui-stack.c (tui_show_frame_info): Update.
2063 * tui/tui-data.h (struct tui_list): Remove.
2064 (tui_source_windows): Return a reference to a std::vector.
2065 * tui/tui-data.c (source_windows): Now a std::vector.
2066 (tui_source_windows): Change return type.
2067 (tui_clear_source_windows): Rewrite.
2068 (tui_clear_source_windows_detail, tui_add_to_source_windows)
2069 (tui_free_all_source_wins_content): Rewrite.
2070
2071 2019-06-25 Tom Tromey <tom@tromey.com>
2072
2073 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2074 (struct tui_data_window, struct tui_cmd_window): Declare
2075 clear_detail method.
2076 * tui/tui-data.c (tui_source_window::clear_detail)
2077 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2078 methods.
2079 (tui_clear_win_detail): Simplify.
2080
2081 2019-06-25 Tom Tromey <tom@tromey.com>
2082
2083 * tui/tui-layout.c (make_source_window, make_disasm_window)
2084 (make_source_or_disasm_window): Remove win_info_ptr parameter.
2085 Return the new window.
2086 (show_source_disasm_command, show_data)
2087 (show_source_or_disasm_and_command): Update.
2088
2089 2019-06-25 Tom Tromey <tom@tromey.com>
2090
2091 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2092 parameter. Return the new window.
2093 (show_source_disasm_command): Update and remove NULL check.
2094 (show_source_or_disasm_and_command): Update.
2095
2096 2019-06-25 Tom Tromey <tom@tromey.com>
2097
2098 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2099
2100 2019-06-25 Tom Tromey <tom@tromey.com>
2101
2102 * tui/tui-data.h (struct tui_win_info): Make constructor
2103 protected. Make destructor virtual. Add initializers.
2104 (tui_source_window, tui_data_window, tui_cmd_window): New
2105 classes.
2106 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
2107 constructor. Add "type" parameter.
2108 (tui_source_window, tui_data_window, tui_cmd_window): New
2109 constructors.
2110 (tui_alloc_win_info): Instantiate the appropriate subclass.
2111
2112 2019-06-25 Tom Tromey <tom@tromey.com>
2113
2114 * tui/tui-win.c (tui_resize_all): Use delete.
2115 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2116 destructor.
2117 (tui_free_window): Don't declare.
2118 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2119 Update.
2120
2121 2019-06-25 Tom Tromey <tom@tromey.com>
2122
2123 * tui/tui-data.h (struct tui_win_info): Add constructor.
2124 * tui/tui-data.c (tui_alloc_win_info): Use new.
2125 (tui_free_window): Use delete.
2126
2127 2019-06-22 Tom Tromey <tom@tromey.com>
2128
2129 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2130 declare.
2131 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2132
2133 2019-06-22 Tom Tromey <tom@tromey.com>
2134
2135 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2136 declare.
2137 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2138
2139 2019-06-22 Tom de Vries <tdevries@suse.de>
2140
2141 * dwarf2read.c (create_addrmap_from_aranges)
2142 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2143 instead of '%zu'.
2144
2145 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
2146
2147 * dwarf2read.h (dwarf2_section_info_def): Remove.
2148 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2149 * dwarf2read.c (struct dwo_sections) <types>: Change type to
2150 std::vector<dwarf2_section_info>.
2151 (struct dwo_file) <~dwo_file>: Remove.
2152 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2153 types field.
2154 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2155 (dwarf2_read_debug_names): Likewise.
2156 (create_debug_types_hash_table): Change parameter type to
2157 array_view, adjust code accordingly.
2158 (dwarf2_locate_dwo_sections): Adjust to std::vector.
2159 (partial_die_info::fixup): Likewise.
2160 (determine_prefix): Likewise.
2161 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2162
2163 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
2164
2165 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2166 gdb_bfd_ref_ptr.
2167 <~dwo_file>: Remove call to gdb_bfd_unref.
2168 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2169 gdb_bfd_ref_ptr::get.
2170
2171 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
2172
2173 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2174 type to htab_up.
2175 * dwarf2read.c (struct dwo_file): Initialize fields.
2176 <~dwo_file>: New.
2177 (free_dwo_file): Remove, move content to ~dwo_file.
2178 (struct dwo_file_deleter): Remove.
2179 (dwo_file_up>: Remove custom deleter.
2180 (free_dwo_files): Remove.
2181 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2182 dwo_files.
2183 (process_skeletonless_type_units): Call unique_ptr::get.
2184 (allocate_dwo_file_hash_table): Add deleter to created hash
2185 table. Change return type to htab_up.
2186 (lookup_dwo_file_slot): Don't memset dwo_file, call
2187 unique_ptr::get.
2188 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2189 (create_dwo_unit_in_dwp_v2): Likewise.
2190 (open_and_init_dwo_file): Likewise.
2191 (free_dwo_file_from_slot): Remove.
2192
2193 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
2194
2195 * dwarf2read.h (struct dwarf2_section_info) <readin,
2196 is_virtual>: Change type to bool.
2197 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2198 true instead of 1.
2199
2200 2019-06-19 Tom Tromey <tom@tromey.com>
2201
2202 * tui/tui-data.h (tui_init_content_element): Don't declare.
2203
2204 2019-06-19 Tom Tromey <tom@tromey.com>
2205
2206 * tui/tui-data.h (tui_init_win_info): Don't declare.
2207
2208 2019-06-19 Tom de Vries <tdevries@suse.de>
2209
2210 * dwarf2read.h (abstract_to_concrete): Change type to
2211 std::unordered_map<sect_offset, std::vector<sect_offset>,
2212 gdb::hash_enum<sect_offset>>.
2213
2214 2019-06-19 Tom Tromey <tromey@adacore.com>
2215
2216 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2217 EVAL_AVOID_SIDE_EFFECTS specially.
2218
2219 2019-06-19 Tom Tromey <tromey@adacore.com>
2220
2221 * source-cache.c (highlighter): New global.
2222 (source_cache::get_source_lines): Create a highlighter on demand.
2223
2224 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
2225
2226 * defs.h (deprecated_interactive_hook): Delete declaration.
2227 * interps.c (clear_interpreter_hooks): Remove use of
2228 deprecated_interactive_hook.
2229 * top.c (deprecated_interactive_hook): Delete definition.
2230 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2231
2232 2019-06-18 Tom de Vries <tdevries@suse.de>
2233
2234 PR gdb/24515
2235 * dwarf2read.h (abstract_to_concrete): Change type from
2236 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2237 std::unordered_map<sect_offset, std::vector<sect_offset>>.
2238 * dwarf2read.c (read_variable): Update.
2239 (dwarf2_fetch_die_loc_sect_off): Update.
2240
2241 2019-06-17 Tom de Vries <tdevries@suse.de>
2242
2243 PR gdb/24617
2244 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2245 accessing parent[parent_len - 1].
2246
2247 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
2248
2249 PR gdb/24364
2250 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2251 call dtrace_process_dof with NULL dof.
2252
2253 2019-06-16 Tom de Vries <tdevries@suse.de>
2254
2255 PR gdb/24445
2256 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2257
2258 2019-06-16 Tom Tromey <tom@tromey.com>
2259
2260 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2261 (make_all_visible): Use address of member.
2262
2263 2019-06-16 Tom Tromey <tom@tromey.com>
2264
2265 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2266 (tui_free_window, free_content, free_content_elements): Remove
2267 unnecessary cast.
2268 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2269 cast.
2270 * tui/tui-regs.c (tui_show_register_group)
2271 (tui_display_registers_from, tui_display_reg_element_at_line):
2272 Remove unnecessary cast.
2273
2274 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
2275
2276 * linux-nat.c (normal_mask): Delete.
2277 (_initialize_linux_nat): Don't initialise normal_mask.
2278
2279 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
2280
2281 PR gdb/24445
2282 * dwarf-index-write.h (write_psymtabs_to_index): Add
2283 dwz_basename parameter.
2284 * dwarf-index-write.c (write_gdbindex): Move file writing to
2285 write_gdbindex_1. Change return type void.
2286 (assert_file_size): Move up, remove filename parameter.
2287 (write_gdbindex_1): New function.
2288 (write_debug_names): Change return type to void, call
2289 assert_file_size.
2290 (struct index_wip_file): New struct.
2291 (write_psymtabs_to_index): Add dwz_basename parameter. Move
2292 file logic to index_wip_file. Write index for dwz file if
2293 needed.
2294 (save_gdb_index_command): Pass basename of dwz file, if present.
2295 * dwarf-index-cache.c (index_cache::store): Obtain and pass
2296 build-id of dwz file, if present.
2297 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2298 (dwarf2_get_dwz_file): Likewise.
2299 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2300 (dwarf2_get_dwz_file): Likewise.
2301
2302 2019-06-16 Tom Tromey <tom@tromey.com>
2303
2304 * coffread.c (process_coff_symbol): Use xstrdup.
2305 * value.c (create_internalvar): Use xstrdup.
2306
2307 2019-06-16 Tom Tromey <tom@tromey.com>
2308
2309 * valops.c (value_cast, value_slice): Remove unnecessary cast.
2310 * breakpoint.c (stopin_command, stopat_command)
2311 (until_break_command, decode_location_default): Remove unnecessary
2312 cast.
2313 * utils.c (subset_compare): Remove unnecessary cast.
2314 * ada-lang.c (ada_update_initial_language): Remove unnecessary
2315 cast.
2316 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2317 cast.
2318 * infcmd.c (path_command): Remove unnecessary cast.
2319 * coffread.c (decode_type): Remove unnecessary cast.
2320 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2321 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2322 * tui/tui-stack.c (tui_show_locator_content)
2323 (tui_show_frame_info): Remove unnecessary cast.
2324 * tui/tui-win.c (tui_scroll_forward_command)
2325 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2326 (parse_scrolling_args): Remove unnecessary cast.
2327 * tui/tui-data.c (init_win_info, tui_del_window)
2328 (tui_free_window, tui_del_data_windows, tui_free_data_content)
2329 (free_content_elements): Remove unnecessary cast.
2330 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2331 unnecessary cast.
2332 * tui/tui-source.c (tui_set_source_content)
2333 (tui_vertical_source_scroll): Remove unnecessary cast.
2334 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2335 cast.
2336 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2337 * tui/tui-regs.c (tui_display_registers_from)
2338 (tui_display_register): Remove unnecessary cast.
2339 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2340 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2341 (make_visible): Remove unnecessary cast.
2342 * tui/tui-winsource.c (tui_erase_source_content)
2343 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2344 unnecessary cast.
2345 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2346 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2347 * stabsread.c (read_type, read_array_type, read_range_type):
2348 Remove unnecessary cast.
2349 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2350 (parse_symbol, parse_type, upgrade_type, parse_external)
2351 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2352 unnecessary cast.
2353 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2354
2355 2019-06-16 Tom Tromey <tom@tromey.com>
2356
2357 * tui/tui-data.c (tui_alloc_generic_win_info)
2358 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2359 checks.
2360
2361 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
2362 Andrew Burgess <andrew.burgess@embecosm.com>
2363
2364 * f-typeprint.c (f_print_type): Don't return early for not
2365 associated or not allocated types.
2366 (f_type_print_varspec_suffix): Add print_rank parameter and print
2367 ranks of array types in case they dangling.
2368 (f_type_print_base): Add print_rank parameter.
2369
2370 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
2371
2372 * NEWS: Mention new MI commands.
2373 * break-catch-throw.c (enum exception_event_kind): Move to
2374 breakpoint.h.
2375 (print_mention_exception_catchpoint): Output text as a single
2376 message.
2377 (catch_exception_command_1): Rename to...
2378 (catch_exception_event): ...this, make non-static, update header
2379 command, and change some parameter types.
2380 (catch_catch_command): Update for changes to
2381 catch_exception_command_1.
2382 (catch_throw_command): Likewise.
2383 (catch_rethrow_command): Likewise.
2384 * breakpoint.c (enum exception_event_kind): Delete.
2385 * breakpoint.h (enum exception_event_kind): Moved here from
2386 break-catch-throw.c.
2387 (catch_exception_event): Declare.
2388 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2389 (mi_cmd_catch_throw): New function.
2390 (mi_cmd_catch_rethrow): New function.
2391 (mi_cmd_catch_catch): New function.
2392 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2393 'catch-catch' entries.
2394 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2395 (mi_cmd_catch_rethrow): Declare.
2396 (mi_cmd_catch_catch): Declare.
2397
2398 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
2399
2400 * annotate.c (annotate_source_line): Change return type to void,
2401 update implementation to match.
2402 * annotate.h (annotate_source_line): Change return type to void,
2403 update header comment.
2404 * stack.c (print_frame_info): Don't change what frame information
2405 is printed based on whether annotations are on or not.
2406
2407 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
2408
2409 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2410 (annotate_source): Make static.
2411 (annotate_source_line): Moved from source.c and renamed from
2412 identify_source_line. Update the return type.
2413 * annotate.h (annotate_source): Delete declaration.
2414 (annotate_source_line): Declaration moved from source.h, and
2415 renamed from identify_source_line. Return type updated.
2416 * source.c (identify_source_line): Moved to annotate.c and renamed
2417 to annotate_source_line.
2418 (info_line_command): Remove check of annotation_level.
2419 * source.h (identify_source_line): Move declaration to annotate.h
2420 and rename to annotate_source_line.
2421 * stack.c: Add 'annotate.h' include.
2422 (print_frame_info): Remove check of annotation_level before
2423 calling annotate_source_line.
2424
2425 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
2426
2427 * source-cache.c (source_cache::get_plain_source_lines): Use
2428 open_source_file_with_line_charpos instead of just
2429 open_source_file, remove call to find_source_lines.
2430 (source_cache::get_source_lines): Likewise.
2431 * source.c (find_source_lines): Make static.
2432 (get_filename_and_charpos): Renamed into...
2433 (open_source_file_with_line_charpos): ..this along with changes to
2434 return a scoped_fd, and some other minor clean ups.
2435 (identify_source_line): Use open_source_file_with_line_charpos.
2436 (search_command_helper): Use open_source_file_with_line_charpos
2437 instead of just open_source_file, remove call to
2438 find_source_lines.
2439 * source.h (open_source_file_with_line_charpos): Declare new
2440 function.
2441 (find_source_lines): Delete declaration.
2442
2443 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
2444
2445 * source.c (get_filename_and_charpos): Remove fullname
2446 parameter.
2447 (identify_source_line): Update call to get_filename_and_charpos.
2448
2449 2019-06-14 Tom Tromey <tromey@adacore.com>
2450
2451 PR gdb/24502:
2452 * ui-style.h (skip_ansi_escape): Update comment.
2453 * ui-file.h (class no_terminal_escape_file): New class.
2454 * ui-file.c (no_terminal_escape_file::write)
2455 (no_terminal_escape_file::puts): New methods.
2456 * cli/cli-logging.c (handle_redirections): Use
2457 no_terminal_escape_file.
2458
2459 2019-06-14 Tom Tromey <tromey@adacore.com>
2460
2461 * NEWS: Move convenience variable news above Python news.
2462
2463 2019-06-14 Tom Tromey <tom@tromey.com>
2464
2465 * gnulib: Move directory to top-level.
2466 * configure.ac: Don't configure gnulib.
2467 * configure: Rebuild.
2468 * common/common-defs.h: Use new path to gnulib.
2469 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2470 (GNULIB_H): Remove.
2471 (INCGNU): Look in new gnulib location.
2472 (HFILES_NO_SRCDIR): Remove gnulib files.
2473 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2474 (generated_files): Remove GNULIB_H.
2475 ($(LIBGNU), all-lib): Remove targets.
2476 (distclean): Don't mention GNULIB_BUILDDIR.
2477 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2478
2479 2019-06-14 Tom Tromey <tromey@adacore.com>
2480
2481 * symfile.c (add_symbol_file_command): Remove obsolete comment.
2482 Warn if symbol file does not provide any symbols.
2483
2484 2019-06-14 Tom Tromey <tromey@adacore.com>
2485
2486 * source.c (find_and_open_source): Respect basenames_may_differ.
2487
2488 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
2489
2490 * annotate.c (annotate_breakpoints_invalid): Make use of
2491 scoped_restore_terminal_state.
2492 (annotate_frames_invalid): Likewise.
2493
2494 2019-06-14 Tom Tromey <tromey@adacore.com>
2495
2496 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2497 allow assignment to an internalvar.
2498
2499 2019-06-14 Tom Tromey <tromey@adacore.com>
2500
2501 * ada-lex.l: Allow "_" in attribute names.
2502
2503 2019-06-14 Tom Tromey <tromey@adacore.com>
2504
2505 PR gdb/24653:
2506 * regcache.c (registers_changed): Don't call alloca.
2507 * top.c (execute_command): Don't call alloca.
2508
2509 2019-06-13 Pedro Alves <palves@redhat.com>
2510
2511 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2512 'expression'. When parsing an expression, error out if there's
2513 junk after "unlimited".
2514 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2515 (do_set_command): Adjust calls to is_unlimited_literal.
2516
2517 2019-06-13 Pedro Alves <palves@redhat.com>
2518
2519 * compile/compile.c (make_compile_options_def_group): Add braces
2520 around array_view initializer.
2521 * thread.c (make_thread_apply_all_options_def_group)
2522 (make_thread_apply_all_options_def_group): Likewise.
2523
2524 2019-06-13 Pedro Alves <palves@redhat.com>
2525
2526 * NEWS (New commands): Mention "maint test-options
2527 require-delimiter", "maint test-options unknown-is-error", "maint
2528 test-options unknown-is-operand" and "maint show
2529 test-options-completion-result".
2530 (New command options, command completion): New section.
2531 (Completion improvements): New section.
2532 Mention that you can abbreviate "unlimited".
2533
2534 2019-06-13 Pedro Alves <palves@redhat.com>
2535
2536 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2537 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2538 * unittests/cli-utils-selftests.c (test_parse_flags)
2539 (test_parse_flags_qcs): Delete.
2540 (test_cli_utils): Don't call deleted functions.
2541
2542 2019-06-13 Pedro Alves <palves@redhat.com>
2543
2544 * thread.c: Include "cli/cli-option.h".
2545 (tp_array_compar_ascending): Global.
2546 (tp_array_compar): Delete function.
2547 (tp_array_compar_ascending, tp_array_compar_descending): New
2548 functions.
2549 (ascending_option_def, qcs_flag_option_def)
2550 (thr_qcs_flags_option_defs)
2551 (make_thread_apply_all_options_def_group)
2552 (make_thread_apply_options_def_group): New.
2553 (thread_apply_all_command): Use gdb::option::process_options.
2554 (thread_apply_command_completer)
2555 (thread_apply_all_command_completer): New.
2556 (thread_apply_command): Use gdb::option::process_options.
2557 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2558 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
2559 to generate help text of "thread apply". Adjust "taas"'s help.
2560 * tid-parse.c (tid_range_parser::in_thread_range): New method.
2561 * tid-parse.h (tid_range_parser::in_thread_range): New method.
2562
2563 2019-06-13 Pedro Alves <palves@redhat.com>
2564
2565 * thread.c (thread_apply_command): Check for invalid TID with
2566 isdigit instead of !isalpha.
2567
2568 2019-06-13 Pedro Alves <palves@redhat.com>
2569
2570 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2571 (validate_flags_qcs): New.
2572 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2573 (validate_flags_qcs): Declare.
2574 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2575 (make_frame_apply_options_def_group): New.
2576 (frame_apply_command_count): Process options with
2577 gdb::option::process_options.
2578 (frame_apply_completer): New.
2579 (frame_apply_level_completer, frame_apply_all_completer)
2580 (frame_apply_completer): New.
2581 (_initialize_stack): Update help of "frame apply", "frame apply
2582 level", "frame apply all" and "faas" to mention supported options
2583 and install command completers.
2584 * stack.h (frame_apply_all_completer): Declare.
2585 * thread.c: Include "stack.h".
2586 (tfaas_command): Add "--".
2587 (_initialize_thread): Update help "tfaas" to mention supported
2588 options and install command completer.
2589
2590 2019-06-13 Pedro Alves <palves@redhat.com>
2591
2592 * completer.c (complete_nested_command_line): New.
2593 (gdb_completion_word_break_characters_throw): Add assertion.
2594 * completer.h (complete_nested_command_line): Declare.
2595
2596 2019-06-13 Pedro Alves <palves@redhat.com>
2597
2598 * stack.c (parse_backtrace_qualifiers): New.
2599 (backtrace_command): Use it.
2600 (backtrace_command_completer): Complete on qualifiers.
2601
2602 2019-06-13 Pedro Alves <palves@redhat.com>
2603
2604 * frame.c: Include "cli/cli-option.h.
2605 (user_set_backtrace_options): New.
2606 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2607 Delete.
2608 (get_prev_frame): Adjust.
2609 (boolean_option_def, uinteger_option_def)
2610 (set_backtrace_option_defs): New.
2611 (_initialize_frame): Adjust and use
2612 gdb::option::add_setshow_cmds_for_options to install "set
2613 backtrace past-main" and "set backtrace past-entry".
2614 * frame.h: Include "cli/cli-option.h".
2615 (struct frame_print_options): Forward declare.
2616 (print_frame_arguments_all, print_frame_arguments_scalars)
2617 (print_frame_arguments_none): Declare.
2618 (print_entry_values): Delete declaration.
2619 (struct frame_print_options, user_frame_print_options): New.
2620 (struct set_backtrace_options): New.
2621 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2622 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2623 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2624 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2625 (list_args_or_locals): Add frame_print_options parameter.
2626 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2627 * python/py-framefilter.c (enumerate_args): Pass down
2628 USER_FRAME_PRINT_OPTIONS.
2629 * stack.c: Include "cli/cli-option.h".
2630 (print_frame_arguments_all, print_frame_arguments_scalars)
2631 (print_frame_arguments_none): Declare.
2632 (print_raw_frame_arguments, print_entry_values): Delete.
2633 (user_frame_print_options): New.
2634 (boolean_option_def, enum_option_def, frame_print_option_defs):
2635 New.
2636 (struct backtrace_cmd_options): New.
2637 (bt_flag_option_def): New.
2638 (backtrace_command_option_defs): New.
2639 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2640 (print_frame_arg, read_frame_arg, print_frame_args)
2641 (print_frame_info, print_frame): Add frame_print_options parameter
2642 and use it.
2643 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2644 (backtrace_command_1): Add frame_print_options and
2645 backtrace_cmd_options parameters and use them.
2646 (make_backtrace_options_def_group): New.
2647 (backtrace_command): Process command options with
2648 gdb::option::process_options.
2649 (backtrace_command_completer): New.
2650 (_initialize_stack): Extend "backtrace"'s help to mention
2651 supported options. Install completer for "backtrace".
2652 Install some settings commands with add_setshow_cmds_for_options.
2653
2654 2019-06-13 Pedro Alves <palves@redhat.com>
2655
2656 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2657 and that "set/show print raw frame-arguments" are now deprecated.
2658
2659 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2660 command.
2661 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2662 * stack.c (_initialize_stack): Install "set/show print
2663 raw-frame-arguments", and deprecate "set/show print raw
2664 frame-arguments".
2665 * valprint.c (_initialize_valprint): Deprecate "set/show print
2666 raw".
2667
2668 2019-06-13 Pedro Alves <palves@redhat.com>
2669
2670 * compile/compile.c (struct compile_options): New.
2671 (compile_flag_option_def, compile_command_option_defs)
2672 (make_compile_options_def_group): New.
2673 (compile_file_command): Handle options with
2674 gdb::option::process_options.
2675 (compile_file_command_completer): New function.
2676 (compile_code_command): Handle options with
2677 gdb::option::process_options.
2678 (compile_code_command_completer): New function.
2679 (_initialize_compiler): Install completers for "compile code" and
2680 "compile file". Mention available options in "compile code" and
2681 "compile code"'s help.
2682 * completer.c (advance_to_completion_word): New, factored out from
2683 ...
2684 (advance_to_expression_complete_word_point): ... this.
2685 (advance_to_filename_complete_word_point): New.
2686 * completer.h (advance_to_filename_complete_word_point): New
2687 declaration.
2688
2689 2019-06-13 Pedro Alves <palves@redhat.com>
2690
2691 * compile/compile.c: Include "cli/cli-option.h".
2692 (compile_print_value): Scope data pointer is now a
2693 value_print_options pointer; adjust.
2694 (compile_print_command): Process options. Scope data pointer is
2695 now a value_print_options pointer; adjust.
2696 (_initialize_compile): Update "compile print"'s help to include
2697 supported options. Install a completer for "compile print".
2698 * cp-valprint.c (show_vtblprint, show_objectprint)
2699 (show_static_field_print): Delete.
2700 (_initialize_cp_valprint): Don't install "set print
2701 static-members", "set print vtbl", "set print object" here.
2702 * printcmd.c: Include "cli/cli-option.h" and
2703 "common/gdb_optional.h".
2704 (print_command_parse_format): Rework to fill in a
2705 value_print_options instead of a format_data.
2706 (print_value): Change parameter type from format_data pointer to
2707 value_print_options reference. Adjust.
2708 (print_command_1): Process options. Adjust to pass down a
2709 value_print_options.
2710 (print_command_completer): New.
2711 (_initialize_printcmd): Install print_command_completer as
2712 handle_brkchars completer for the "print" command. Update
2713 "print"'s help to include supported options.
2714 * valprint.c: Include "cli/cli-option.h".
2715 (show_vtblprint, show_objectprint, show_static_field_print): Moved
2716 here from cp-valprint.c.
2717 (boolean_option_def, uinteger_option_def)
2718 (value_print_option_defs, make_value_print_options_def_group):
2719 New. Use gdb::option::add_setshow_cmds_for_options to install
2720 "set print elements", "set print null-stop", "set print repeats",
2721 "set print pretty", "set print union", "set print array", "set
2722 print address", "set print symbol", "set print array-indexes".
2723 * valprint.h: Include <string> and "cli/cli-option.h".
2724 (make_value_print_options_def_group): Declare.
2725 (print_value): Change parameter type from format_data pointer to
2726 value_print_options reference.
2727 (print_command_completer): Declare.
2728
2729 2019-06-13 Pedro Alves <palves@redhat.com>
2730
2731 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2732 (COMMON_SFILES): Add maint-test-settings.c.
2733 * cli/cli-decode.c (boolean_enums): New global, factored out from
2734 ...
2735 (add_setshow_boolean_cmd): ... here.
2736 * cli/cli-decode.h (boolean_enums): Declare.
2737 * cli/cli-option.c: New file.
2738 * cli/cli-option.h: New file.
2739 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2740 factored out from ...
2741 (parse_cli_boolean_value(const char *)): ... this.
2742 (is_unlimited_literal): Change parameter type to pointer to
2743 pointer. Adjust and advance ARG pointer.
2744 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2745 (parse_cli_var_enum): New, factored out from ...
2746 (do_set_command): ... this. Adjust.
2747 * cli/cli-setshow.h (parse_cli_boolean_value)
2748 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2749 (parse_cli_var_enum): Declare.
2750 * cli/cli-utils.c: Include "cli/cli-option.h".
2751 (get_ulongest): New.
2752 * cli/cli-utils.h (get_ulongest): Declare.
2753 (check_for_argument): New overloads.
2754 * maint-test-options.c: New file.
2755
2756 2019-06-13 Pedro Alves <palves@redhat.com>
2757
2758 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2759 parse a range if "-" is at the end of the string.
2760
2761 2019-06-13 Pedro Alves <palves@redhat.com>
2762
2763 * cli/cli-setshow.c (parse_auto_binary_operation)
2764 (parse_cli_boolean_value): Don't allow "o".
2765
2766 2019-06-13 Pedro Alves <palves@redhat.com>
2767
2768 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2769 * NEWS: Mention maint test-settings KIND.
2770 * maint-test-settings.c: New file.
2771
2772 2019-06-13 Pedro Alves <palves@redhat.com>
2773
2774 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2775 completer.
2776 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2777 "set" completers.
2778
2779 2019-06-13 Pedro Alves <palves@redhat.com>
2780
2781 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2782 after item.
2783
2784 2019-06-13 Pedro Alves <palves@redhat.com>
2785
2786 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2787
2788 2019-06-13 Pedro Alves <palves@redhat.com>
2789
2790 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2791 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2792 call.
2793 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2794 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2795 calls.
2796 (check_for_argument): Skip spaces after argument.
2797
2798 2019-06-13 Pedro Alves <palves@redhat.com>
2799
2800 * thread.c (thread_apply_command): Adjust TID parsing.
2801 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2802 detected before end of string.
2803 (tid_is_in_list): Error out if LIST is invalid.
2804
2805 2019-06-13 Pedro Alves <palves@redhat.com>
2806
2807 * completer.c (complete_line_internal_1): Rewind completion word
2808 point.
2809 (completion_tracker::advance_custom_word_point_by): Change
2810 parameter type to int.
2811 * completer.h (completion_tracker::advance_custom_word_point_by):
2812 Likewise.
2813
2814 2019-06-13 Pedro Alves <palves@redhat.com>
2815
2816 * completer.c (advance_to_completion_word): Handle delimiters.
2817
2818 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
2819
2820 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2821
2822 2019-06-11 Tom Tromey <tom@tromey.com>
2823
2824 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2825 (xmalloc_failed): Move to alloc.c.
2826 * alloc.c: New file.
2827 * Makefile.in (COMMON_SFILES): Add alloc.c.
2828
2829 2019-06-11 Tom Tromey <tom@tromey.com>
2830
2831 * nat/linux-waitpid.c: Don't include server.h.
2832 (linux_debug): Remove.
2833 (my_waitpid): Update.
2834
2835 2019-06-11 Tom Tromey <tromey@adacore.com>
2836
2837 * infcall.c (_initialize_infcall): Remove trailing newline from
2838 help.
2839 * user-regs.c (_initialize_user_regs): Remove trailing newline
2840 from help.
2841 * typeprint.c (_initialize_typeprint): Remove trailing newline
2842 from help.
2843 * reverse.c (_initialize_reverse): Remove trailing newlines from
2844 help.
2845 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2846 from help.
2847 * language.c (add_set_language_command): Remove trailing newline
2848 from help.
2849 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2850 help.
2851 * disasm.c (_initialize_disasm): Remove trailing newline from
2852 help.
2853 * top.c (init_main): Remove trailing newline from help.
2854 * interps.c (_initialize_interpreter): Remove trailing newline
2855 from help.
2856 * btrace.c (_initialize_btrace): Remove trailing newlines from
2857 help.
2858 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2859 from help.
2860 * python/python.c (_initialize_python): Remove trailing newline
2861 from help.
2862 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2863 help.
2864 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2865 from help. Reformat some text.
2866 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2867 from help.
2868 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2869 newline from help.
2870
2871 2019-06-11 Tom Tromey <tromey@adacore.com>
2872
2873 * darwin-nat.c (darwin_decode_exception_message)
2874 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2875
2876 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
2877
2878 * valops.c (value_slice): Check for not allocated or not
2879 associated values.
2880
2881 2019-06-10 Tom de Vries <tdevries@suse.de>
2882
2883 PR gdb/24618
2884 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2885 sure an empty slot (defined by a 32-bit zero pair) is recognized as
2886 invalid.
2887
2888 2019-06-10 Tom de Vries <tdevries@suse.de>
2889
2890 PR gdb/24611
2891 * linespec.c (linespec_lexer_lex_string): Remove incorrect
2892 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
2893
2894 2019-06-10 Tom de Vries <tdevries@suse.de>
2895
2896 PR symtab/24545
2897 * symtab.c (struct demangled_name_entry): Add language field.
2898 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
2899 static minimal symbol". Set and use language field.
2900
2901 2019-06-10 Tom Tromey <tromey@adacore.com>
2902
2903 * ada-lang.c (_initialize_ada_language): Update help text.
2904
2905 2019-06-10 Tom Tromey <tromey@adacore.com>
2906
2907 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2908 with a newline.
2909 * guile/guile.c (handle_boot_error): Don't end warning with a
2910 newline.
2911 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2912 warning with a newline.
2913 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2914 newline.
2915 (s12z_frame_cache): Likewise.
2916 * dwarf-index-cache.c (index_cache::store): Don't end warning with
2917 a newline.
2918 * solib-svr4.c (disable_probes_interface): Don't end warning with
2919 a newline.
2920 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2921 newline.
2922 * python/python.c (do_finish_initialization): Don't end warning
2923 with a newline.
2924
2925 2019-06-10 Tom Tromey <tom@tromey.com>
2926
2927 * python/py-breakpoint.c (gdbpy_breakpoint_created)
2928 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2929 gdbpy_enter.
2930
2931 2019-06-10 Tom Tromey <tromey@adacore.com>
2932
2933 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2934 data.
2935 (elf_new_init): Don't call stabsread_new_init.
2936 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2937 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
2938 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2939
2940 2019-06-10 Tom de Vries <tdevries@suse.de>
2941
2942 PR symtab/16264
2943 PR symtab/24517
2944 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2945
2946 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
2947
2948 * source.c (find_and_open_source): Also rewrite relative file
2949 names.
2950
2951 2019-04-26 Amos Bird <amosbird@gmail.com>
2952
2953 * annotate.c (annotate_thread_exited): Add "thread-exited"
2954 annotation.
2955
2956 2019-06-06 Tom Tromey <tromey@adacore.com>
2957
2958 * maint.h (class scoped_command_stats): Use
2959 DISABLE_COPY_AND_ASSIGN.
2960 <print_time>: New method.
2961 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2962 print_time.
2963 (scoped_command_stats::print_time): New method.
2964
2965 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
2966
2967 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2968 instructions of lengths 6 or 8 bytes.
2969
2970 2019-06-04 Pedro Alves <palves@redhat.com>
2971
2972 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2973
2974 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2975 * breakpoint.c (condition_completer): Likewise.
2976 * cli/cli-dump.c (scan_expression): Likewise.
2977 * common/filestuff.c (mkdir_recursive): Likewise.
2978 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2979 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2980 (gdb_abspath): Likewise.
2981 * compile/compile-cplus-types.c
2982 (compile_cplus_instance::decl_name): Likewise.
2983 * completer.c (complete_explicit_location):
2984 (signal_completer, reg_or_group_completer_1): Likewise.
2985 * cp-support.c (cp_remove_params_if_any): Likewise.
2986 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2987 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2988 * infcmd.c (strip_bg_char): Likewise.
2989 * linespec.c (copy_token_string): Likewise.
2990 * mi/mi-main.c (output_cores): Likewise.
2991 * psymtab.c (psymtab_search_name):
2992 * symfile.c (test_set_ext_lang_command): Likewise.
2993 * target.c (target_fileio_read_stralloc): Likewise.
2994 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2995 * value.c (complete_internalvar): Likewise.
2996
2997 2019-06-04 Christian Biesinger <cbiesinger@google.com>
2998
2999 Add objfile property to gdb.Type.
3000 * NEWS: Mention Python API addition.
3001 * python/py-type.c (typy_get_objfile): New method.
3002
3003 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3004
3005 * NEWS: Mention the new set|show style [title|highlight].
3006 Mention changes to "show style", "help" and "apropos".
3007
3008 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3009
3010 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3011 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
3012 instead of print_help_for_command.
3013 (print_doc_of_command): New function.
3014 (help_list): Add 'apropos -v word' suggestion.
3015 (print_help_for_command): Style the command name using title style.
3016 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3017 (_initialize_cli_cmds): Describe -v in apropos_command help.
3018
3019 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3020
3021 * cli/cli-style.h (cli_style_option): Add name in constructor,
3022 add m_name class member, add constructor with intensity,
3023 add name class function.
3024 (cli_style_option::add_setshow_commands): Remove name argument.
3025 (highlight_style, title_style): New styles.
3026 * cli/cli-style.c (do_show): New function that shows a style
3027 characteristic styling the style name with itself.
3028 (set_style_name): New function.
3029 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3030 Update all callers according to the changes in cli/cli-style.h.
3031 * utils.h (fputs_highlighted): New function.
3032 * utils.c (fputs_highlighted): Likewise.
3033
3034 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3035
3036 * NEWS: Mention new pipe command and new convenience variables.
3037
3038 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3039
3040 * cli/cli-cmds.c (pipe_command): New function.
3041 (_initialize_cli_cmds): Call add_com for pipe_command.
3042 Define | as an alias for pipe.
3043 (exit_status_set_internal_vars): New function.
3044 (shell_escape): Call exit_status_set_internal_vars.
3045 cli/cli-decode.c (find_command_name_length): Recognize | as
3046 a single character command.
3047
3048 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3049
3050 * gdbcmd.h (execute_command_to_ui_file): New declaration.
3051 top.c (execute_command_to_ui_file): New function, mostly a copy
3052 of execute_command_to_string.
3053 (execute_command_to_string): Implement by calling
3054 execute_command_to_ui_file.
3055
3056 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3057
3058 * top.h (saved_command_line): Remove declaration.
3059 * top.c (previous_saved_command_line, previous_repeat_arguments):
3060 New variables.
3061 (saved_command_line): Make static, define together with other
3062 'repeat variables'.
3063 (dont_repeat): Clear repeat_arguments.
3064 (repeat_previous, get_saved_command_line, save_command_line):
3065 New functions.
3066 (gdb_init): Initialize saved_command_line
3067 and previous_saved_command_line.
3068 * main.c (captured_main_1): Remove saved_command_line initialization.
3069 * event-top.c (handle_line_of_input): Update to use
3070 the new 'repeat' related functions instead of direct access to
3071 saved_command_line.
3072 * command.h (repeat_previous, get_saved_command_line,
3073 save_command_line): New declarations.
3074 (dont_repeat): Add comment.
3075
3076 2019-05-30 Tom Tromey <tromey@adacore.com>
3077
3078 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3079 Fix comment.
3080 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3081
3082 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
3083
3084 PR cli/24587
3085 * completer.c (complete): Initialize variable word.
3086
3087 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
3088
3089 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3090 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3091 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3092 'body' is NULL to the outter 'if', protecting the '!is_define'
3093 situation as well.
3094
3095 2019-05-29 Tom Tromey <tromey@adacore.com>
3096
3097 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3098 (dwarf_unknown): New function.
3099 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3100 (dwarf_type_encoding_name): Use dwarf_unknown.
3101
3102 2019-05-29 Tom Tromey <tromey@adacore.com>
3103
3104 PR c++/20020:
3105 * cp-valprint.c (cp_print_value_fields): Call
3106 cp_print_static_field inside "try".
3107
3108 2019-05-29 Tom Tromey <tromey@adacore.com>
3109
3110 * inflow.c (struct terminal_info): Add default operator=.
3111 * configure: Rebuild.
3112 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3113 -Wdeprecated-copy-dtor, -Wredundant-move.
3114
3115 2019-05-29 Tom Tromey <tromey@adacore.com>
3116
3117 * NEWS: Add entry.
3118 * infcmd.c (print_return_value_1): Handle finish_print
3119 option.
3120 (show_print_finish): New function.
3121 (_initialize_infcmd): Add "set/show print finish" commands.
3122 * valprint.c (user_print_options): Initialize new member.
3123 * valprint.h (struct value_print_options) <finish_print>: New
3124 member.
3125
3126 2019-05-28 Tom Tromey <tromey@adacore.com>
3127
3128 * ada-lang.c (ada_remove_Xbn_suffix)
3129 (find_old_style_renaming_symbol)
3130 (parse_old_style_renaming): Remove.
3131 (ada_find_renaming_symbol): Don't call
3132 find_old_style_renaming_symbol.
3133 (ada_is_renaming_symbol): Rename from
3134 ada_find_renaming_symbol. Remove "block" parameter. Return
3135 bool. Now static.
3136 (ada_read_var_value): Update and simplify.
3137 * ada-exp.y (write_var_or_type): Remove old code.
3138
3139 2019-05-28 Alan Hayward <alan.hayward@arm.com>
3140
3141 * event-top.c: Remove include comment.
3142 * inflow.c (class scoped_ignore_sigttou): Move from here...
3143 * inflow.h (class scoped_ignore_sigttou): ...to here.
3144 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3145 * top.c: Remove include comment.
3146
3147 2019-05-27 Tom Tromey <tom@tromey.com>
3148
3149 * NEWS: Fix typo.
3150
3151 2019-05-22 Tom Tromey <tromey@adacore.com>
3152
3153 * target.c (target_follow_exec): Constify parameter.
3154 * target-delegates.c: Rebuild.
3155 * remote.c (remote_target::follow_exec): Constify parameter.
3156 * infrun.c (follow_exec): Constify parameter.
3157 * target.h (struct target_ops) <follow_exec>: Constify parameter.
3158 (target_follow_exec): Likewise.
3159
3160 2019-05-22 Alan Hayward <alan.hayward@arm.com>
3161
3162 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3163 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3164
3165 2019-05-22 Alan Hayward <alan.hayward@arm.com>
3166
3167 * NEWS: Add debugredirect and testsuite sections.
3168
3169 2019-05-22 Simon Cook <simon.cook@embecosm.com>
3170
3171 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3172 target descriptions using exclusively floating point register name
3173 aliases.
3174
3175 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
3176
3177 PR gdb/18644:
3178 * f-lang.c (build_fortran_types): Handle the case where
3179 gdbarch_floatformat_for_type returns a nullptr.
3180
3181 2019-05-21 Tom de Vries <tdevries@suse.de>
3182
3183 PR cli/24587
3184 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3185
3186 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
3187
3188 PR gdb/18644:
3189 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3190 16-byte floats.
3191 * i386-tdep.c (i386_floatformat_for_type): Use
3192 floatformats_ia64_quad for the 16-byte floating point component
3193 within a fortran 32-byte complex number.
3194
3195 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
3196
3197 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3198 delete default constructor.
3199 (find_partial_die): Update to return const struct.
3200 (partial_die_parent_scope): Move variable declaration into scope
3201 of its use and change its type to auto.
3202 (guess_partial_die_structure_name): Likewise.
3203 (partial_die_info::fixup): Likewise.
3204
3205 2019-05-17 Tom Tromey <tromey@adacore.com>
3206
3207 * source.c (find_and_open_source): Remove cast.
3208
3209 2019-05-17 Tom Tromey <tromey@adacore.com>
3210
3211 * annotate.c (annotate_source): Make "filename" const.
3212 * annotate.h (annotate_source): Use const.
3213
3214 2019-05-17 Alan Hayward <alan.hayward@arm.com>
3215
3216 * disasm.c (set_disassembler_options): Send errors to stderr.
3217
3218 2019-05-17 Alan Hayward <alan.hayward@arm.com>
3219
3220 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3221 (cli_interp_base::set_logging): Check debug_redirect.
3222 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3223 * cli/cli-logging.c (debug_redirect): Add static variable.
3224 (pop_output_files): Add default param.
3225 (handle_redirections): Print debug setting.
3226 (show_logging_command): Likewise.
3227 (_initialize_cli_logging): Add debugredirect command.
3228 * interps.c (current_interp_set_logging): Add debug_redirect
3229 parameter.
3230 * interps.h (set_logging): Add debug_redirect parameter.
3231 (current_interp_set_logging): Likewise.
3232 * mi/mi-common.h: Likewise.
3233 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3234
3235 2019-05-17 Alan Hayward <alan.hayward@arm.com>
3236 Tom Tromey <tromey@adacore.com>
3237
3238 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3239 directly.
3240 * cli/cli-interp.h (make_logging_output): Remove declaration.
3241 * cli/cli-logging.c (make_logging_output): Remove function.
3242 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3243 directly.
3244 * ui-file.c (tee_file::tee_file): Remove bools.
3245 (tee_file::~tee_file): Remove deletes.
3246 * ui-file.h (tee_file): Remove bools.
3247
3248 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
3249
3250 * mi/mi-cmds.h (mi_cmd_complete): New function.
3251 * mi/mi-main.c (mi_cmd_complete): Likewise.
3252 * mi/mi-cmds.c: Define new MI command -complete.
3253 * NEWS: Mention new -complete command.
3254
3255 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
3256
3257 * completer.h (complete): New function.
3258 * completer.c (complete): Likewise.
3259 * cli/cli-cmds.c: (complete_command): Update to use new complete()
3260 function defined in completer.h.
3261
3262 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
3263
3264 * MAINTAINERS (Write After Approval): Add myself.
3265
3266 2019-05-17 Tom de Vries <tdevries@suse.de>
3267
3268 PR gdb/24094
3269 * dwarf2read.c (struct cu_partial_die_info): New struct.
3270 (find_partial_die): Return cu_partial_die_info.
3271 (partial_die_parent_scope, guess_partial_die_structure_name)
3272 (partial_die_info::fixup): Handle new return type of find_partial_die.
3273
3274 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
3275
3276 * stap-probe.c (stap_parse_register_operand): Make "regname" an
3277 "std::string", simplifying the algorithm.
3278
3279 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
3280
3281 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3282 (stap_static_probe_ops::get_probes): Likewise.
3283
3284 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
3285
3286 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3287 '-')" and "else if".
3288 (stap_parse_single_operand): Join checks for
3289 "gdbarch_stap_parse_special_token_p" and
3290 "gdbarch_stap_parse_special_token" in the same "if" statement.
3291 Invert check when verifying for operation on register
3292 displacement.
3293
3294 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
3295
3296 * stap-probe.c (stap_get_opcode): Update comment.
3297 (stap_get_expected_argument_type): Likewise.
3298 (handle_stap_probe): Likewise.
3299
3300 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
3301
3302 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3303 return type to 'bool'. Adjust comment. Use 'bool' when
3304 appropriate.
3305 (i386_stap_parse_special_token_three_arg_disp): Likewise.
3306 * stap-probe.c (stap_parse_argument_1): Likewise.
3307 (stap_is_operator): Likewise.
3308 (stap_is_generic_prefix): Likewise.
3309 (stap_is_register_prefix): Likewise.
3310 (stap_is_register_indirection_prefix): Likewise.
3311 (stap_is_integer_prefix): Likewise.
3312 (stap_generic_check_suffix): Likewise.
3313 (stap_check_integer_suffix): Likewise.
3314 (stap_check_register_suffix): Likewise.
3315 (stap_check_register_indirection_suffix): Likewise.
3316 (stap_parse_register_operand): Likewise.
3317 (stap_parse_single_operand): Likewise.
3318 (stap_parse_argument_1): Likewise.
3319 (stap_probe::get_argument_count): Likewise.
3320 (stap_is_operator): Likewise.
3321
3322 2019-05-16 Tom Tromey <tromey@adacore.com>
3323
3324 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3325 keyword to foreach.
3326
3327 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
3328
3329 * linux-thread-db.c (try_thread_db_load_1): Change return type
3330 to bool.
3331 (try_thread_db_load): Likewise.
3332 (try_thread_db_load_from_pdir_1): Likewise.
3333 (try_thread_db_load_from_pdir): Likewise.
3334 (try_thread_db_load_from_sdir): Likewise.
3335 (try_thread_db_load_from_dir): Likewise.
3336 (thread_db_load_search): Likewise.
3337 (has_libpthread): Likewise.
3338 (thread_db_load): Likewise.
3339
3340 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
3341
3342 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3343 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3344 NULL, and complain/return if that's the case.
3345
3346 2019-05-15 John Darrington <john@darrington.wattle.id.au>
3347
3348 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3349 (advance, posn, abstract_read_memory): New functions.
3350 [struct mem_read_abstraction]: New struct.
3351 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3352
3353 2019-05-14 Tom Tromey <tromey@adacore.com>
3354
3355 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3356 value is not lval_memory.
3357
3358 2019-05-14 Tom Tromey <tromey@adacore.com>
3359
3360 * solib.c (info_sharedlibrary_command): Style the file name.
3361
3362 2019-05-14 Alan Hayward <alan.hayward@arm.com>
3363
3364 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3365 (aarch64_vnv_type): Likewise.
3366 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3367 * common/tdesc.c: Likewise.
3368 * common/tdesc.h (enum tdesc_type_kind): Likewise.
3369 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3370 * features/aarch64-fpu.xml: Add ieee half view.
3371 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3372 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3373 * gdbtypes.h (struct builtin_type): Likewise.
3374 (struct objfile_type): Likewise.
3375
3376 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
3377
3378 * language.c (language_sniff_from_mangled_name): Fix "langauge"
3379 typo.
3380 * location.h (string_to_event_location): Likewise.
3381
3382 2019-05-11 Joel Brobecker <brobecker@adacore.com>
3383
3384 GDB 8.3 released.
3385
3386 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
3387
3388 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3389 New variable declaration.
3390 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3391 New variable.
3392 (print_one_breakpoint): Use ui_out::test_flags and new global
3393 variable to compute use_fixed_output.
3394 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3395 Remove.
3396 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3397 (mi_multi_location_breakpoint_output_fixed): Remove.
3398 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3399 new variable.
3400 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3401 fix_multi_location_breakpoint_output flag if version >= 3.
3402 * ui-out.h (enum ui_out_flag)
3403 <fix_multi_location_breakpoint_output>: New enumerator.
3404
3405 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
3406
3407 * contrib/cc-with-tweaks.sh: Validate dwz's work.
3408
3409 2019-05-10 Tom Tromey <tromey@adacore.com>
3410
3411 * ada-lang.c (catch_ada_completer): New function.
3412 (_initialize_ada_language): Use it.
3413
3414 2019-05-10 Tom Tromey <tromey@adacore.com>
3415
3416 * thread.c (print_thread_info): Make "requested_threads" const.
3417 * gdbthread.h (print_thread_info): Make "requested_threads"
3418 const.
3419 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3420 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3421
3422 2019-05-08 Tom Tromey <tom@tromey.com>
3423
3424 * gdbtypes.c (objfile_type_data): Change type.
3425 (objfile_type, _initialize_gdbtypes): Update.
3426
3427 2019-05-08 Tom Tromey <tom@tromey.com>
3428
3429 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3430 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3431 (_initialize_dwarf2_frame): Update.
3432
3433 2019-05-08 Tom Tromey <tom@tromey.com>
3434
3435 * objc-lang.c (objc_objfile_data): Change type.
3436 (find_methods): Update.
3437 (_initialize_objc_lang): Remove.
3438
3439 2019-05-08 Tom Tromey <tom@tromey.com>
3440
3441 * stabsread.c (rs6000_builtin_type_data): Change type.
3442 (rs6000_builtin_type, _initialize_stabsread): Update.
3443
3444 2019-05-08 Tom Tromey <tom@tromey.com>
3445
3446 * mips-tdep.c (mips_pdr_data): Remove.
3447 (_initialize_mips_tdep): Update.
3448
3449 2019-05-08 Tom Tromey <tom@tromey.com>
3450
3451 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3452 (hppa_init_objfile_priv_data, read_unwind_info)
3453 (find_unwind_entry, _initialize_hppa_tdep): Update.
3454
3455 2019-05-08 Tom Tromey <tom@tromey.com>
3456
3457 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3458 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
3459 on obstack.
3460 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3461
3462 2019-05-08 Tom Tromey <tom@tromey.com>
3463
3464 * mdebugread.c (basic_type_data): Change type.
3465 (basic_type, _initialize_mdebugread): Update.
3466
3467 2019-05-08 Tom Tromey <tom@tromey.com>
3468
3469 * common/gdb_unique_ptr.h (struct noop_deleter): New.
3470
3471 2019-05-08 Tom Tromey <tom@tromey.com>
3472
3473 * nto-tdep.c (nto_inferior_data_reg): Change type.
3474 (nto_inferior_data): Update.
3475 (nto_inferior_data_cleanup, nto_new_inferior_data)
3476 (_initialize_nto_tdep): Remove.
3477 * nto-tdep.h (struct nto_inferior_data): Add initializers.
3478
3479 2019-05-08 Tom Tromey <tom@tromey.com>
3480
3481 * ada-lang.c (struct ada_inferior_data): Add initializers.
3482 (ada_inferior_data): Change type.
3483 (ada_inferior_data_cleanup): Remove.
3484 (get_ada_inferior_data, ada_inferior_exit)
3485 (struct ada_pspace_data): Add initializers, destructor.
3486 (ada_pspace_data_handle): Change type.
3487 (get_ada_pspace_data): Update.
3488 (ada_pspace_data_cleanup): Remove.
3489
3490 2019-05-08 Tom Tromey <tom@tromey.com>
3491
3492 * coffread.c (struct coff_symfile_info): Add initializers.
3493 (coff_objfile_data_key): Move lower. Change type.
3494 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3495 Update.
3496 (coff_free_info): Remove.
3497
3498 2019-05-08 Tom Tromey <tom@tromey.com>
3499
3500 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3501 (fbsd_pspace_data_handle): Move lower. Change type.
3502 (get_fbsd_pspace_data): Update.
3503 (fbsd_pspace_data_cleanup): Remove.
3504 (_initialize_fbsd_tdep): Update.
3505
3506 2019-05-08 Tom Tromey <tom@tromey.com>
3507
3508 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3509 (get_ada_tasks_pspace_data): Update.
3510 (ada_tasks_pspace_data_cleanup): Remove.
3511 (_initialize_tasks): Update.
3512 (ada_tasks_inferior_data_handle): Change type.
3513 (get_ada_tasks_inferior_data): Update.
3514 (ada_tasks_inferior_data_cleanup): Remove.
3515 (struct ada_tasks_pspace_data): Add initializers.
3516
3517 2019-05-08 Tom Tromey <tom@tromey.com>
3518
3519 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3520 * symfile-debug.c (debug_sym_get_probes): Change type.
3521 * stap-probe.c (handle_stap_probe):
3522 (stap_static_probe_ops::get_probes): Change type.
3523 * probe.h (class static_probe_ops) <get_probes>: Change type.
3524 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3525 (parse_probes_in_pspace): Update.
3526 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3527 Update.
3528 (any_static_probe_ops::get_probes): Change type.
3529 * elfread.c (elfread_data): New typedef.
3530 (probe_key): Change type.
3531 (elf_get_probes): Likewise. Update.
3532 (probe_key_free): Remove.
3533 (_initialize_elfread): Update.
3534 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3535 Change type.
3536 (dtrace_process_dof_probe, dtrace_process_dof)
3537 (dtrace_static_probe_ops::get_probe): Change type.
3538
3539 2019-05-08 Tom Tromey <tom@tromey.com>
3540
3541 * xcoffread.c (struct xcoff_symfile_info): Rename from
3542 coff_symfile_info. Add initializers.
3543 (xcoff_objfile_data_key): Move lower. Change type.
3544 (XCOFF_DATA): Rewrite.
3545 (xcoff_free_info): Remove.
3546 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3547 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3548 (xcoff_initial_scan): Update.
3549
3550 2019-05-08 Tom Tromey <tom@tromey.com>
3551
3552 * solib-svr4.c (struct svr4_info): Add initializers and
3553 destructor.
3554 <probes_table>: Now an htab_up.
3555 (solib_svr4_pspace_data): Change type.
3556 (free_probes_table): Simplify.
3557 (~svr4_info): Rename from svr4_pspace_data_cleanup.
3558 (get_svr4_info, probes_table_htab_remove_objfile_probes)
3559 (probes_table_remove_objfile_probes, register_solib_event_probe)
3560 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3561 (_initialize_svr4_solib): Update.
3562
3563 2019-05-08 Tom Tromey <tom@tromey.com>
3564
3565 * remote.c (remote_pspace_data): Change type.
3566 (remote_pspace_data_cleanup): Remove.
3567 (get_remote_exec_file, set_pspace_remote_exec_file)
3568 (_initialize_remote): Update.
3569
3570 2019-05-08 Tom Tromey <tom@tromey.com>
3571
3572 * breakpoint.c (breakpoint_objfile_key): Change type.
3573 (get_breakpoint_objfile_data): Update.
3574 (free_breakpoint_objfile_data): Remove.
3575 (_initialize_breakpoint): Update.
3576
3577 2019-05-08 Tom Tromey <tom@tromey.com>
3578
3579 * linux-tdep.c (struct linux_info): Add initializers.
3580 (linux_inferior_data): Move. Change type.
3581 (invalidate_linux_cache_inf): Update.
3582 (linux_inferior_data_cleanup): Remove.
3583 (get_linux_inferior_data, _initialize_linux_tdep): Update.
3584
3585 2019-05-08 Tom Tromey <tom@tromey.com>
3586
3587 * auxv.c (auxv_inferior_data): Move. Change type.
3588 (auxv_inferior_data_cleanup): Remove.
3589 (invalidate_auxv_cache_inf): Rewrite.
3590 (get_auxv_inferior_data, _initialize_auxv): Update.
3591
3592 2019-05-08 Tom Tromey <tom@tromey.com>
3593
3594 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3595 (symfile_debug_objfile_data_key): Change type.
3596 (symfile_debug_installed, debug_qf_has_symbols)
3597 (debug_qf_find_last_source_symtab)
3598 (debug_qf_forget_cached_source_info)
3599 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3600 (debug_qf_print_stats, debug_qf_dump)
3601 (debug_qf_expand_symtabs_for_function)
3602 (debug_qf_expand_all_symtabs)
3603 (debug_qf_expand_symtabs_with_fullname)
3604 (debug_qf_map_matching_symbols)
3605 (debug_qf_expand_symtabs_matching)
3606 (debug_qf_find_pc_sect_compunit_symtab)
3607 (debug_qf_map_symbol_filenames)
3608 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3609 (debug_sym_new_init, debug_sym_init, debug_sym_read)
3610 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3611 (debug_sym_read_linetable, debug_sym_relocate): Update.
3612 (symfile_debug_free_objfile): Remove.
3613 (install_symfile_debug_logging, _initialize_symfile_debug):
3614 Update.
3615
3616 2019-05-08 Tom Tromey <tom@tromey.com>
3617
3618 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3619 allocate_on_obstack.
3620 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3621 (get_dwarf2_per_objfile): Update.
3622 (set_dwarf2_per_objfile): Remove.
3623 (dwarf2_has_info, dwarf2_get_section_info): Update.
3624 (dwarf2_free_objfile): Remove.
3625 (_initialize_dwarf2_read): Update.
3626
3627 2019-05-08 Tom Tromey <tom@tromey.com>
3628
3629 * auto-load.c (struct auto_load_pspace_info): Add destructor and
3630 initializers.
3631 <unsupported_script_warning_printed,
3632 script_not_found_warning_printed>: Now bool.
3633 (auto_load_pspace_data): Change type.
3634 (~auto_load_pspace_info): Rename from
3635 auto_load_pspace_data_cleanup.
3636 (get_auto_load_pspace_data, init_loaded_scripts_info)
3637 (clear_section_scripts, maybe_print_unsupported_script_warning)
3638 (maybe_print_script_not_found_warning, _initialize_auto_load):
3639 Update.
3640
3641 2019-05-08 Tom Tromey <tom@tromey.com>
3642
3643 * objfiles.c (objfile_pspace_info): Add destructor and
3644 initializers.
3645 (objfiles_pspace_data): Change type.
3646 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3647 (get_objfile_pspace_data): Update.
3648 (objfiles_bfd_data): Change type.
3649 (get_objfile_bfd_data): Update.
3650 (objfile_bfd_data_free, _initialize_objfiles): Remove.
3651
3652 2019-05-08 Tom Tromey <tom@tromey.com>
3653
3654 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3655 Change type.
3656 (get_catch_syscall_inferior_data): Update.
3657 (catch_syscall_inferior_data_cleanup): Remove.
3658 (_initialize_break_catch_syscall): Update.
3659
3660 2019-05-08 Tom Tromey <tom@tromey.com>
3661
3662 * inflow.c (struct terminal_info): Add destructor and
3663 initializers.
3664 (inflow_inferior_data): Change type.
3665 (~terminal_info): Rename from inflow_inferior_data_cleanup.
3666 (get_inflow_inferior_data, inflow_inferior_exit)
3667 (swap_terminal_info, _initialize_inflow): Update.
3668
3669 2019-05-08 Tom Tromey <tom@tromey.com>
3670
3671 * target-dcache.c (target_dcache_cleanup): Remove.
3672 (target_dcache_aspace_key): Change type.
3673 (target_dcache_init_p, target_dcache_invalidate)
3674 (target_dcache_get, target_dcache_get_or_init)
3675 (_initialize_target_dcache): Update.
3676 * dcache.h (struct dcache_deleter): New.
3677
3678 2019-05-08 Tom Tromey <tom@tromey.com>
3679
3680 * symtab.c (struct symbol_cache): Add destructor and
3681 initializers.
3682 (symbol_cache_key): Move. Change type.
3683 (make_symbol_cache, free_symbol_cache): Remove.
3684 (get_symbol_cache): Update.
3685 (symbol_cache_cleanup): Remove.
3686 (ALL_PSPACES, symbol_cache_flush)
3687 (maintenance_print_symbol_cache)
3688 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3689 Update.
3690
3691 2019-05-08 Tom Tromey <tom@tromey.com>
3692
3693 * symtab.c (struct main_info): Add destructor and initializers.
3694 (main_progspace_key): Move. Change type.
3695 (get_main_info): Update.
3696 (main_info_cleanup): Remove.
3697 (_initialize_symtab): Update.
3698
3699 2019-05-08 Tom Tromey <tom@tromey.com>
3700
3701 * registry.h (DECLARE_REGISTRY): Define the _key class.
3702
3703 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
3704
3705 * NEWS: Merge two 'New commands' sections.
3706
3707 2019-05-08 Joel Brobecker <brobecker@adacore.com>
3708
3709 * ada-valprint.c (ada_val_print_gnat_array): Remove language
3710 parameter and use Ada language definition instead.
3711 (ada_val_print_ptr): Remove unused language parameter.
3712 (ada_val_print_num): Remove language parameter and use Ada language
3713 definition instead.
3714 (ada_val_print_enum, ada_val_print_flt): Remove unused language
3715 parameter.
3716 (ada_val_print_struct_union, ada_val_print_ref): Remove language
3717 parameter and use Ada language definition instead.
3718 (ada_val_print_1): Update all ada_val_print_xxx calls.
3719 Remove language parameter.
3720 (ada_val_print): Update ada_val_print_1 call.
3721
3722 2019-05-08 Tom Tromey <tromey@adacore.com>
3723
3724 * remote.c (remote_hw_watchpoint_limit)
3725 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3726 Now static.
3727
3728 2019-05-08 Tom Tromey <tromey@adacore.com>
3729
3730 * maint.c (_initialize_maint_cmds): Move initialization code to
3731 remote.c.
3732 (watchdog, show_watchdog): Move to remote.c.
3733 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
3734 "watchdog" static.
3735 (_initialize_remote): Move initialization code from maint.c.
3736 * defs.h (watchdog): Don't declare.
3737
3738 2019-05-08 Tom Tromey <tromey@adacore.com>
3739
3740 * tui/tui-interp.c: Include main.h.
3741 * interps.c: Include main.h.
3742 * main.h (interpreter_p): Declare.
3743 * defs.h (interpreter_p): Don't declare.
3744
3745 2019-05-08 Tom Tromey <tromey@adacore.com>
3746
3747 * dwarf2loc.c: Include dwarf2read.h.
3748 * defs.h (read_unsigned_leb128): Don't declare.
3749 * dwarf2read.h (read_unsigned_leb128): Declare.
3750
3751 2019-05-08 Tom Tromey <tromey@adacore.com>
3752
3753 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3754 method.
3755
3756 2019-05-08 Tom Tromey <tromey@adacore.com>
3757
3758 * utils.c (fputs_maybe_filtered): Reset style after paging, even
3759 when no wrap column is set.
3760
3761 2019-05-08 Tom Tromey <tromey@adacore.com>
3762
3763 * c-lang.c (c_get_string): Handle non-C-style arrays.
3764
3765 2019-05-08 Tom Tromey <tromey@adacore.com>
3766
3767 * typeprint.c (print_offset_data::update): Print the bit offset,
3768 not the number of bits remaining.
3769
3770 2019-05-08 Tom Tromey <tromey@adacore.com>
3771
3772 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3773 padding at end of comment.
3774
3775 2019-05-08 Tom Tromey <tromey@adacore.com>
3776
3777 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3778 Compare main types.
3779
3780 2019-05-06 Tom Tromey <tom@tromey.com>
3781
3782 * common/scoped_mmap.c: Include common-defs.h.
3783 * common/scoped_mmap.h: Don't include config.h.
3784
3785 2019-05-04 Tom Tromey <tom@tromey.com>
3786
3787 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3788 (struct aarch64_call_info): Add initializers.
3789 <si>: Now a std::vector.
3790 (pass_on_stack, aarch64_push_dummy_call): Update.
3791
3792 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
3793 Tom Tromey <tom@tromey.com>
3794
3795 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3796 (ppc_threads): Now a std::vector. Now static.
3797 (hwdebug_find_thread_points_by_tid)
3798 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3799 Update.
3800
3801 2019-05-04 Tom Tromey <tom@tromey.com>
3802
3803 * arc-tdep.c (arc_tdesc_init): Return bool.
3804
3805 2019-05-04 Tom Tromey <tom@tromey.com>
3806
3807 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3808 Use gdb_assert_not_reached.
3809
3810 2019-05-04 Tom Tromey <tom@tromey.com>
3811
3812 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3813 "false".
3814
3815 2019-05-04 Tom Tromey <tom@tromey.com>
3816
3817 * arc-tdep.c (arc_tdesc_init): Use bool.
3818
3819 2019-05-04 Tom Tromey <tom@tromey.com>
3820
3821 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3822
3823 2019-05-04 Tom Tromey <tom@tromey.com>
3824
3825 * cli/cli-cmds.c (valid_command_p): Return bool.
3826
3827 2019-05-04 Tom Tromey <tom@tromey.com>
3828
3829 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3830 * command.h (valid_user_defined_cmd_name_p): Channge return type.
3831
3832 2019-05-04 Raul Tambre <raul@tambre.ee>
3833
3834 * python/lib/gdb/prompt.py (_ExtendedPrompt)
3835 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3836 operator for comparison.
3837
3838 2019-05-04 Tom Tromey <tom@tromey.com>
3839
3840 * psymtab.c (psymbol_name_matches, match_partial_symbol)
3841 (lookup_partial_symbol, print_partial_symbols)
3842 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3843 (psymbol_compare): Update.
3844 (add_psymbol_to_bcache): Clear the entire psymbol.
3845 (maintenance_check_psymtabs): Update.
3846 * psympriv.h (struct partial_symbol): Don't derive from
3847 general_symbol_info.
3848 <obj_section, unrelocated_address, address,
3849 set_unrelocated_address>: Update.
3850 <ginfo>: New member.
3851 * dwarf-index-write.c (write_psymbols, debug_names::insert)
3852 (debug_names::write_psymbols): Update.
3853
3854 2019-05-04 Tom de Vries <tdevries@suse.de>
3855
3856 * contrib/cc-with-tweaks.sh: Support -n arg.
3857
3858 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3859
3860 * corelow.c (core_target::detach): Ensure frame cache and
3861 register caches are cleared.
3862 inferior.c (exit_inferior_1): Likewise.
3863
3864 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
3865 Tom Tromey <tom@tromey.com>
3866
3867 * dictionary.c (collate_pending_symbols_by_language): Remove
3868 "struct" from foreach.
3869 * symtab.c (lookup_global_symbol_from_objfile)
3870 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3871 foreach.
3872 * ser-tcp.c (net_open): Remove "struct" from foreach.
3873 * objfiles.c (objfile_relocate, objfile_rebase)
3874 (objfile_has_symbols): Remove "struct" from foreach.
3875 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3876 from foreach.
3877 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3878 foreach.
3879 * darwin-nat.c (thread_info_from_private_thread_info): Remove
3880 "struct" from foreach.
3881 * ada-lang.c (create_excep_cond_exprs)
3882 (ada_exception_catchpoint_cond_string): Remove "struct" from
3883 foreach.
3884
3885 2019-05-03 Tom Tromey <tromey@adacore.com>
3886
3887 * ada-exp.y (convert_char_literal): Check suffix of each
3888 enumerator.
3889
3890 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
3891
3892 PR ada/21406:
3893 * ada-exp.y (yywrap): Don't define.
3894 * ada-lex.l (%option): Add noyywrap
3895 (yywrap): Remove.
3896
3897 2019-05-03 Eli Zaretskii <eliz@gnu.org>
3898
3899 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3900 _WIN32_WINNT to the XP level, unless already defined to a higher
3901 level.
3902
3903 * unittests/parse-connection-spec-selftests.c:
3904 * ser-tcp.c:
3905 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
3906 override.
3907
3908 * symfile.c (find_separate_debug_file): Remove colon from the
3909 drive spec of DOS/Windows file names of the target, so that the
3910 file name produced from DEBUGDIR and the target's directory will
3911 be valid on DOS/Windows systems.
3912
3913 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
3914
3915 * rust-lang.c (val_print_struct): Handle printing structures
3916 containing strings.
3917
3918 2019-05-02 Tom Tromey <tromey@adacore.com>
3919
3920 * valarith.c (_initialize_valarith): Remove.
3921
3922 2019-05-01 Tom Tromey <tromey@adacore.com>
3923
3924 * ada-lang.c (ada_value_primitive_field): Treat more fields as
3925 bitfields.
3926
3927 2019-05-01 Tom Tromey <tromey@adacore.com>
3928
3929 * ada-lang.c (ada_value_assign): Correctly compute starting offset
3930 for big-endian copies.
3931
3932 2019-04-30 Ali Tamur <tamur@google.com>
3933 * gdb/dwarf2read.c (read_3_bytes): New declaration.
3934 (read_attribute_value): Added DW_FORM_strx1-4 cases.
3935 (read_3_bytes): New function.
3936
3937 2019-04-30 Joel Brobecker <brobecker@adacore.com>
3938
3939 * windows-nat.c (main_thread_id): Delete.
3940 (handle_output_debug_string): Replace main_thread_id by
3941 current_event.dwThreadId.
3942 (fake_create_process): Likewise.
3943 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3944 Do not set main_thread_id.
3945 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3946 current_event.dwThreadId.
3947 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3948
3949 2019-04-30 Joel Brobecker <brobecker@adacore.com>
3950
3951 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3952 Use current_event.dwThreadId instead of main_thread_id.
3953
3954 2019-04-30 Tom Tromey <tromey@adacore.com>
3955
3956 * ada-lang.c (ada_lookup_simple_minsyms): New function.
3957 (create_excep_cond_exprs): Iterate over program spaces.
3958 (ada_exception_catchpoint_cond_string): Examine all minimal
3959 symbols for exception types.
3960
3961 2019-04-30 Tom Tromey <tromey@adacore.com>
3962
3963 PR c++/24470:
3964 * dwarf2read.c (process_structure_scope): Handle case where type
3965 has template parameters but no symbol was created.
3966
3967 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
3968 Chris January <chris.january@arm.com>
3969
3970 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3971 qualifier.
3972 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3973
3974 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
3975
3976 * f-typeprint.c (f_print_type): Update rules for printing
3977 whitespace.
3978 (f_type_print_varspec_suffix): Likewise.
3979
3980 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
3981 Chris January <chris.january@arm.com>
3982
3983 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3984 function arguments.
3985
3986 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
3987
3988 * f-lang.c (build_fortran_types): Change name of void type to
3989 lower case.
3990 * f-typeprint.c (f_type_print_base): Print the name of the void
3991 type, rather than a fixed string.
3992 * f-valprint.c (f_decorations): Use lower case void string.
3993
3994 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
3995 Chris January <chris.january@arm.com>
3996
3997 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3998 types for Fortran.
3999
4000 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4001 Chris January <chris.january@arm.com>
4002 David Lecomber <david.lecomber@arm.com>
4003
4004 * f-exp.y (BINOP_INTRINSIC): New token.
4005 (exp): New parser rule handling BINOP_INTRINSIC.
4006 (f77_keywords): Add new builtin procedures.
4007 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4008 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4009 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4010 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4011 (print_unop_subexp_f): New function.
4012 (print_binop_subexp_f): New function.
4013 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4014 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4015 (dump_subexp_body_f): Likewise.
4016 (operator_check_f): Likewise.
4017 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4018 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4019
4020 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4021
4022 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4023 UNOP_KIND.
4024 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4025 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4026 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4027 (operator_length_f): New fuction.
4028 (print_subexp_f): New function.
4029 (op_name_f): New function.
4030 (dump_subexp_body_f): New function.
4031 (operator_check_f): New function.
4032 (exp_descriptor_f): Replace standard expression handling functions
4033 with new functions.
4034 * gdb/fortran-operator.def: New file.
4035 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4036 * gdb/std-operator.def: Remove UNOP_KIND.
4037
4038 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4039
4040 * std-operator.def: Remove unbalanced, stray double quote
4041 character.
4042
4043 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
4044 Chris January <chris.january@arm.com>
4045 Daniel Everett <daniel.everett@arm.com>
4046 Nick Forrington <nick.forrington@arm.com>
4047 Richard Bunt <richard.bunt@arm.com>
4048
4049 * cp-valprint.c (cp_print_value_fields): Allow an additional level
4050 of depth when printing anonymous structs or unions.
4051 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4052 Don't print either the top-level value, or the children if the
4053 max-depth is exceeded.
4054 (ppscm_print_children): When printing the key of a map, allow one
4055 extra level of depth.
4056 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4057 print either the top-level value, or the children if the max-depth
4058 is exceeded.
4059 (print_children): When printing the key of a map, allow one extra
4060 level of depth.
4061 * python/py-value.c (valpy_format_string): Add max_depth keyword.
4062 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4063 (user_print_options): Initialise max_depth field.
4064 (val_print_scalar_or_string_type_p): New function.
4065 (val_print): Check to see if the max depth has been reached.
4066 (val_print_check_max_depth): Define new function.
4067 (show_print_max_depth): New function.
4068 (_initialize_valprint): Add 'print max-depth' option.
4069 * valprint.h (struct value_print_options) <max_depth>: New field.
4070 (val_print_check_max_depth): Declare new function.
4071 * NEWS: Document new feature.
4072
4073 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
4074
4075 * ada-lang.c (ada_language_defn): Initialise new field.
4076 * c-lang.c (c_is_string_type_p): New function.
4077 (c_language_defn): Initialise new field.
4078 (cplus_language_defn): Initialise new field.
4079 (asm_language_defn): Initialise new field.
4080 (minimal_language_defn): Initialise new field.
4081 * c-lang.h (c_is_string_type_p): Declare new function.
4082 * d-lang.c (d_language_defn): Initialise new field.
4083 * f-lang.c (f_is_string_type_p): New function.
4084 (f_language_defn): Initialise new field.
4085 * go-lang.c (go_is_string_type_p): New function.
4086 (go_language_defn): Initialise new field.
4087 * language.c (default_is_string_type_p): New function.
4088 (unknown_language_defn): Initialise new field.
4089 (auto_language_defn): Initialise new field.
4090 * language.h (struct language_defn) <la_is_string_type_p>: New
4091 member variable.
4092 (default_is_string_type_p): Declare new function.
4093 * m2-lang.c (m2_language_defn): Initialise new field.
4094 * objc-lang.c (objc_language_defn): Initialise new field.
4095 * opencl-lang.c (opencl_language_defn): Initialise new field.
4096 * p-lang.c (pascal_is_string_type_p): New function.
4097 (pascal_language_defn): Initialise new field.
4098 * rust-lang.c (rust_is_string_type_p): New function.
4099 (rust_language_defn): Initialise new field.
4100
4101 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
4102
4103 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4104 New field.
4105 * ada-lang.c (ada_language_defn): Initialise new field.
4106 * c-lang.c (c_language_defn): Likewise.
4107 (cplus_language_defn): Likewise.
4108 (asm_language_defn): Likewise.
4109 (minimal_language_defn): Likewise.
4110 * d-lang.c (d_language_defn): Likewise.
4111 * f-lang.c (f_language_defn): Likewise.
4112 * go-lang.c (go_language_defn): Likewise.
4113 * language.c (unknown_language_defn): Likewise.
4114 (auto_language_defn): Likewise.
4115 * m2-lang.c (m2_language_defn): Likewise.
4116 * objc-lang.c (objc_language_defn): Likewise.
4117 * opencl-lang.c (opencl_language_defn): Likewise.
4118 * p-lang.c (pascal_language_defn): Likewise.
4119 * rust-lang.c (rust_language_defn): Likewise.
4120
4121 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
4122
4123 * ada-lang.c (ada_is_character_type): Change return type to bool.
4124 (ada_is_string_type): Likewise.
4125 * ada-lang.h (ada_is_character_type): Update declaration
4126 (ada_is_string_type): Likewise.
4127
4128 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4129
4130 Support style in 'frame|thread apply'
4131
4132 * gdbcmd.h (execute_command_to_string): New term_out parameter.
4133 * record.c (record_start, record_stop): Update callers of
4134 execute_command_to_string with false.
4135 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4136 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4137 methods.
4138 (class string_file): New constructor with term_out parameter.
4139 Override methods term_out and can_emit_style_escape. New member
4140 term_out.
4141 (class stdio_file): Override can_emit_style_escape.
4142 (class tee_file): Override term_out and can_emit_style_escape.
4143 * utils.h (can_emit_style_escape): Remove.
4144 * utils.c (can_emit_style_escape): Likewise.
4145 Update all callers of can_emit_style_escape (SOMESTREAM) to
4146 SOMESTREAM->can_emit_style_escape.
4147 * source-cache.c (source_cache::get_source_lines): Likewise.
4148 * stack.c (frame_apply_command_count): Call execute_command_to_string
4149 passing the term_out characteristic of the current gdb_stdout.
4150 * thread.c (thr_try_catch_cmd): Likewise.
4151 * top.c (execute_command_to_string): pass term_out parameter
4152 to construct the string_file for the command output.
4153 * ui-file.c (term_cli_styling): New function (most code moved
4154 from utils.c can_emit_style_escape).
4155 (string_file::string_file, string_file::can_emit_style_escape,
4156 stdio_file::can_emit_style_escape, tee_file::term_out,
4157 tee_file::can_emit_style_escape): New functions.
4158
4159 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4160
4161 * NEWS: Mention the new set|show may-call-functions.
4162 * infcall.c (may_call_functions_p): New variable.
4163 (show_may_call_functions_p): New function.
4164 (call_function_by_hand_dummy): Throws an error if not
4165 may-call-functions.
4166 (_initialize_infcall): Call add_setshow_boolean_cmd for
4167 may-call-functions.
4168
4169 2019-04-25 Keith Seitz <keiths@redhat.com>
4170
4171 PR c++/24367
4172 * cp-support.c (inspect_type): Don't attempt substitutions
4173 of symbol with the same name.
4174
4175 2019-04-25 Tom Tromey <tromey@adacore.com>
4176
4177 PR gdb/24475:
4178 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4179 static.
4180
4181 2019-04-25 Tom Tromey <tromey@adacore.com>
4182
4183 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4184 rvalue reference.
4185 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4186 (gdb_xml_parser::parse): Use std::move.
4187 * python/python-internal.h (gdbpy_convert_exception): Take a const
4188 reference.
4189 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4190 std::move.
4191 * python/py-utils.c (gdbpy_convert_exception): Take a const
4192 reference.
4193 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4194 Use std::move.
4195 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4196 Use std::move.
4197 * mi/mi-main.c (mi_print_exception): Take a const reference.
4198 * main.c (handle_command_errors): Take a const reference.
4199 * linespec.c (parse_linespec): Use std::move.
4200 * infcall.c (run_inferior_call): Use std::move.
4201 (call_function_by_hand_dummy): Use std::move.
4202 * exec.c (try_open_exec_file): Use std::move.
4203 * exceptions.h (exception_print, exception_fprintf)
4204 (exception_print_same): Update.
4205 * exceptions.c (print_exception, exception_print)
4206 (exception_fprintf, exception_print_same): Change parameters to
4207 const reference.
4208 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4209 * common/new-op.c: Use std::move.
4210 * common/common-exceptions.h (struct gdb_exception): Add move
4211 constructor.
4212 (struct gdb_exception_error, struct gdb_exception_quit, struct
4213 gdb_quit_bad_alloc): Change constructor to move constructor.
4214 (throw_exception): Change parameter to rvalue reference.
4215 * common/common-exceptions.c (throw_exception): Take rvalue
4216 reference.
4217 * cli/cli-interp.c (safe_execute_command): Use std::move.
4218 * breakpoint.c (insert_bp_location, location_to_sals): Use
4219 std::move.
4220
4221 2019-04-25 Tom Tromey <tromey@adacore.com>
4222
4223 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4224 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4225 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4226 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4227 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4228 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4229 guile/scm-value.c: Use unpack.
4230 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4231 gdbscm_gdb_exception.
4232 (gdbscm_throw_gdb_exception): Likewise.
4233 (struct gdbscm_gdb_exception): New.
4234 (unpack): New function.
4235 (gdbscm_wrap): Use unpack.
4236
4237 2019-04-25 Tom Tromey <tromey@adacore.com>
4238
4239 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4240 (gdb_rl_callback_handler): Use std::move.
4241 * common/common-exceptions.h (struct gdb_exception): Add move
4242 assignment operator.
4243 (throw_exception_sjlj): Change "exception" to const reference.
4244 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4245 (throw_exception_sjlj): Change "exception" to const reference.
4246
4247 2019-04-25 Tom Tromey <tromey@adacore.com>
4248
4249 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4250 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4251 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4252 Update.
4253 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4254 Update.
4255 * mi/mi-interp.c (mi_interp::exec): Update.
4256 * linespec.c (parse_linespec): Update.
4257 * infcall.c (run_inferior_call): Update.
4258 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4259 * guile/scm-symbol.c (gdbscm_lookup_symbol)
4260 (gdbscm_lookup_global_symbol): Update.
4261 * guile/scm-param.c (gdbscm_parameter_value): Update.
4262 * guile/scm-frame.c (gdbscm_frame_read_register)
4263 (gdbscm_frame_read_var): Update.
4264 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4265 * exec.c (try_open_exec_file): Update.
4266 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4267 (gdb_rl_callback_handler): Update.
4268 * common/common-exceptions.h (exception_none): Don't declare.
4269 * common/common-exceptions.c (exception_none): Don't define.
4270 (struct catcher) <exception>: Update.
4271 * cli/cli-interp.c (safe_execute_command): Update.
4272 * breakpoint.c (insert_bp_location, location_to_sals): Update.
4273
4274 2019-04-25 Ali Tamur <tamur@google.com>
4275
4276 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4277 (read_attribute_value): Likewise.
4278 (dwarf2_read_addr_index): Update comment.
4279 (read_str_index): Add DW_FORM_strx.
4280 (dwarf2_string_attr): Likewise.
4281 (dwarf2_const_value_attr): Likewise.
4282 (dump_die_shallow): Likewise.
4283 (dwarf2_fetch_constant_bytes): Likewise.
4284 (skip_form_bytes): Likewise.
4285 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4286
4287 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
4288
4289 PR corefiles/11608
4290 PR corefiles/18187
4291 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4292 OFFSET. Verify if current mapping contains an ELF header.
4293 (linux_find_memory_regions_full): Adjust call to
4294 dump_mapping_p.
4295
4296 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
4297 Kang Li <kanglictf@gmail.com>
4298
4299 PR gdb/21600
4300
4301 * dwarf2-frame.c (read_initial_length): Be consistent about using
4302 unsigned representation of length.
4303 (decode_frame_entry_1): Likewise. Check for wraparound of
4304 end pointer as well as buffer overflow.
4305
4306 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
4307
4308 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4309 "vq".
4310
4311 2019-04-24 Tom Tromey <tromey@adacore.com>
4312
4313 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4314
4315 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4316
4317 * s12z-tdep.c (s12z_unwind_pc): Delete.
4318 (s12z_unwind_sp): Delete.
4319 (s12z_gdbarch_init): Don't register deleted functions with
4320 gdbarch.
4321
4322 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4323
4324 * rl78-tdep.c (rl78_unwind_sp): Delete.
4325 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4326
4327 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4328
4329 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4330 (xstormy16_unwind_pc): Delete.
4331 (xstormy16_dummy_id): Delete.
4332 (xstormy16_gdbarch_init): Don't register deleted functions with
4333 gdbarch.
4334
4335 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4336
4337 * vax-tdep.c (vax_unwind_pc): Delete.
4338 (vax_gdbarch_init): Don't register deleted function with gdbarch.
4339
4340 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4341
4342 * v850-tdep.c (v850_unwind_sp): Delete.
4343 (v850_unwind_pc): Delete.
4344 (v850_dummy_id): Delete.
4345 (v850_gdbarch_init): Don't register deleted functions with
4346 gdbarch.
4347
4348 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4349
4350 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4351 (tilegx_unwind_pc): Delete.
4352 (tilegx_unwind_dummy_id): Delete.
4353 (tilegx_gdbarch_init): Don't register deleted functions with
4354 gdbarch.
4355
4356 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4357
4358 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4359 (tic6x_dummy_id): Delete.
4360 (tic6x_gdbarch_init): Don't register deleted functions with
4361 gdbarch.
4362
4363 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4364
4365 * sparc-tdep.c (sparc_unwind_pc): Delete.
4366 (sparc32_gdbarch_init): Don't register deleted function with
4367 gdbarch.
4368
4369 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4370
4371 * sh-tdep.c (sh_unwind_sp): Delete.
4372 (sh_unwind_pc): Delete.
4373 (sh_dummy_id): Delete.
4374 (sh_gdbarch_init): Don't register deleted functions with
4375 gdbarch.
4376
4377 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4378
4379 * score-tdep.c (score_unwind_sp): Delete.
4380 (score_unwind_pc): Delete.
4381 (score_dummy_id): Delete.
4382 (score_gdbarch_init): Don't register deleted functions with
4383 gdbarch.
4384
4385 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4386
4387 * rx-tdep.c (rx_unwind_pc): Delete.
4388 (rx_unwind_sp): Delete.
4389 (rx_dummy_id): Delete.
4390 (rx_gdbarch_init): Don't register deleted functions with
4391 gdbarch. Update comment.
4392
4393 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4394
4395 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4396 (rs6000_dummy_id): Delete.
4397 (rs6000_gdbarch_init): Don't register deleted functions with
4398 gdbarch.
4399
4400 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4401
4402 * or1k-tdep.c (or1k_dummy_id): Delete.
4403 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4404
4405 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4406
4407 * nios2-tdep.c (nios2_dummy_id): Delete.
4408 (nios2_unwind_sp): Delete.
4409 (nios2_gdbarch_init): Don't register deleted functions with
4410 gdbarch.
4411
4412 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4413
4414 * nds32-tdep.c (nds32_dummy_id): Delete.
4415 (nds32_unwind_pc): Delete.
4416 (nds32_unwind_sp): Delete.
4417 (nds32_gdbarch_init): Don't register deleted functions with
4418 gdbarch.
4419
4420 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4421
4422 * msp430-tdep.c (msp430_unwind_pc): Delete.
4423 (msp430_unwind_sp): Delete.
4424 (msp430_dummy_id): Delete.
4425 (msp430_gdbarch_init): Don't register deleted functions with
4426 gdbarch.
4427
4428 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4429
4430 * moxie-tdep.c (moxie_unwind_sp): Delete.
4431 (moxie_unwind_pc): Delete.
4432 (moxie_dummy_id): Delete.
4433 (moxie_gdbarch_init): Don't register deleted functions with
4434 gdbarch.
4435
4436 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4437
4438 * mn10300-tdep.c (mn10300_dummy_id): Delete.
4439 (mn10300_unwind_pc): Delete.
4440 (mn10300_unwind_sp): Delete.
4441 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4442 mn10300_unwind_sp.
4443 (mn10300_frame_unwind_init): Don't register deleted functions with
4444 gdbarch.
4445
4446 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4447
4448 * mep-tdep.c (mep_unwind_pc): Delete.
4449 (mep_unwind_sp): Delete.
4450 (mep_dummy_id): Delete.
4451 (mep_gdbarch_init): Don't register deleted functions with
4452 gdbarch.
4453
4454 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4455
4456 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4457 (m68hc11_unwind_sp): Delete.
4458 (m68hc11_gdbarch_init): Don't register deleted functions with
4459 gdbarch.
4460
4461 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4462
4463 * m32r-tdep.c (m32r_unwind_sp): Delete.
4464 (m32r_unwind_pc): Delete.
4465 (m32r_dummy_id): Delete.
4466 (m32r_gdbarch_init): Don't register deleted functions with
4467 gdbarch.
4468
4469 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4470
4471 * m32c-tdep.c (m32c_unwind_pc): Delete.
4472 (m32c_unwind_sp): Delete.
4473 (m32c_dummy_id): Delete.
4474 (m32c_gdbarch_init): Don't register deleted functions with
4475 gdbarch.
4476
4477 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4478
4479 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4480 (lm32_unwind_pc): Delete.
4481 (lm32_dummy_id): Delete.
4482 (lm32_gdbarch_init): Don't register deleted functions with
4483 gdbarch.
4484
4485 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4486
4487 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4488 (iq2000_unwind_pc): Delete.
4489 (iq2000_dummy_id): Delete.
4490 (iq2000_gdbarch_init): Don't register deleted functions with
4491 gdbarch.
4492
4493 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4494
4495 * nds32-tdep.c (nds32_type_align): Delete.
4496 (nds32_push_dummy_call): Use type_align instead.
4497
4498 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4499
4500 * arm-tdep.c (arm_type_align): Only handle vector override case.
4501 (arm_push_dummy_call): Use type_align.
4502 (arm_gdbarch_init): Register arm_type_align gdbarch function.
4503
4504 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
4505
4506 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4507 case.
4508 (pass_on_stack): Use type_align.
4509 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4510 function.
4511
4512 2019-04-23 Tom Tromey <tromey@adacore.com>
4513
4514 * dwarf2read.c (line_header::file_name_at): Remove unused
4515 overload.
4516
4517 2019-04-23 Tom de Vries <tdevries@suse.de>
4518
4519 PR gdb/24438
4520 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4521 invocation.
4522
4523
4524 2019-03-27 Ali Tamur <tamur@google.com>
4525
4526 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4527 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4528 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4529 (dwarf_expr_context::get_addr_index): Likewise
4530 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4531 (symbol_needs_eval_context::get_addr_index): Likewise
4532 (disassemble_dwarf_expression): Add DW_OP_addrx
4533 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4534 (read_cutu_die_from_dwo): Update comment
4535 (skip_one_die): Add DW_FORM_addrx
4536 (read_attribute_value): Likewise
4537 (var_decode_location): Add DW_OP_addrx
4538 (dwarf2_const_value_attr): Add DW_FORM_addrx
4539 (dump_die_shallow): Likewise
4540 (dwarf2_fetch_constant_bytes): Likewise
4541 (decode_locdesc): Add DW_OP_addrx
4542 (skip_form_bytes): Add DW_FORM_addrx
4543
4544 2019-04-22 Ali Tamur <tamur@google.com>
4545
4546 * MAINTAINERS (Write After Approval): Add self.
4547
4548 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
4549
4550 * solib-svr4.c (get_svr4_info): Add pspace parameter.
4551 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4552 (open_symbol_file_object): Likewise.
4553 (svr4_default_sos): Add info parameter.
4554 (svr4_read_so_list): Likewise.
4555 (svr4_current_sos_direct): Adjust functions calls to pass down
4556 info.
4557 (svr4_current_sos_1): Add info parameter.
4558 (svr4_current_sos): Call get_svr4_info, pass info down to
4559 svr4_current_sos_1.
4560 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4561 get_svr4_info.
4562 (svr4_in_dynsym_resolve_code): Pass current_program_space to
4563 get_svr4_info.
4564 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4565 to get_svr4_info.
4566 (probes_table_remove_objfile_probes): Likewise.
4567 (register_solib_event_probe): Add info parameter.
4568 (solist_update_incremental): Pass info parameter down to
4569 svr4_read_so_list.
4570 (disable_probes_interface): Add info parameter.
4571 (svr4_handle_solib_event): Pass current_program_space to
4572 get_svr4_info. Adjust disable_probes_interface cleanup.
4573 (svr4_create_probe_breakpoints): Add info parameter, pass it
4574 down to register_solib_event_probe.
4575 (svr4_create_solib_event_breakpoints): Add info parameter,
4576 pass it down to svr4_create_probe_breakpoints.
4577 (enable_break): Pass info down to
4578 svr4_create_solib_event_breakpoints.
4579 (svr4_solib_create_inferior_hook): Pass current_program_space to
4580 get_svr4_info.
4581 (svr4_clear_solib): Likewise.
4582
4583 2019-04-22 Pedro Alves <palves@redhat.com>
4584
4585 * solib-svr4.c (svr4_free_objfile_observer): New.
4586 (probe_and_action::objfile): New field.
4587 (probes_table_htab_remove_objfile_probes)
4588 (probes_table_remove_objfile_probes): New functions.
4589 (register_solib_event_probe): Add 'objfile' parameter. Store it
4590 in the new probe_and_action. Don't store the probe in 'lookup'.
4591 (svr4_create_probe_breakpoints): Pass objfile to
4592 register_solib_event_probe.
4593 (_initialize_svr4_solib): Register a free_objfile observer.
4594
4595 2019-04-19 Tom Tromey <tom@tromey.com>
4596
4597 * common/queue.h: Remove.
4598
4599 2019-04-19 Tom Tromey <tom@tromey.com>
4600
4601 * event-loop.c: Don't include "common/queue.h".
4602
4603 2019-04-19 Tom Tromey <tom@tromey.com>
4604
4605 * remote.c (remote_target): Use delete.
4606 * remote-notif.h: Include <list>, not "common/queue.h".
4607 (notif_client_p): Remove typedef.
4608 (remote_notif_state): Add constructor, destructor, initializer.
4609 <notif_queue>: Now a std::list.
4610 (remote_notif_state_xfree): Don't declare.
4611 * remote-notif.c (remote_notif_process, handle_notification)
4612 (remote_notif_state_allocate): Update.
4613 (~remote_notif_state): Rename from remote_notif_state_xfree.
4614
4615 2019-04-19 Tom Tromey <tom@tromey.com>
4616
4617 * symfile.c (reread_symbols): Update.
4618 * objfiles.c (objfile_register_static_link)
4619 (objfile_lookup_static_link): Update
4620 (~objfile) Don't delete static_links.
4621 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4622
4623 2019-04-19 Tom Tromey <tom@tromey.com>
4624
4625 * type-stack.h (struct type_stack) <insert>: Constify string.
4626 * type-stack.c (type_stack::insert): Constify string.
4627 * gdbtypes.h (lookup_template_type): Update.
4628 (address_space_name_to_int): Update.
4629 * gdbtypes.c (address_space_name_to_int): Make space_identifier
4630 const.
4631 (lookup_template_type): Make name const.
4632 * c-exp.y: Update rules.
4633 (lex_one_token, classify_name, classify_inner_name)
4634 (c_print_token): Update.
4635 * p-exp.y: Update rules.
4636 (yylex): Update.
4637 * f-exp.y: Update rules.
4638 (yylex): Update.
4639 * d-exp.y: Update rules.
4640 (lex_one_token, classify_name, classify_inner_name): Update.
4641 * parse.c (write_dollar_variable, copy_name): Return std::string.
4642 * parser-defs.h (copy_name): Change return type.
4643 * m2-exp.y: Update rules.
4644 (yylex): Update.
4645 * go-exp.y (lex_one_token): Update.
4646 Update rules.
4647 (classify_unsafe_function, classify_packaged_name)
4648 (classify_name, yylex): Update.
4649
4650 2019-04-19 Sergei Trofimovich <siarheit@google.com>
4651
4652 * configure.ac: add --enable-source-highlight switch.
4653 * configure: Regenerate.
4654 * top.c (print_gdb_version): plumb --enable-source-highlight
4655 status to "show configuration".
4656
4657 2019-04-19 Tom Tromey <tromey@adacore.com>
4658
4659 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4660 Check ADA_TYPE_P.
4661 (empty_record, ada_template_to_fixed_record_type_1)
4662 (template_to_static_fixed_type)
4663 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4664 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4665 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4666 macros.
4667
4668 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
4669
4670 PR symtab/24423:
4671 * source.c (print_source_lines_base): Advance "iter" when a
4672 control character is seen.
4673
4674 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4675
4676 * inferior.h (struct infcall_suspend_state_deleter):
4677 Catch exception in destructor to avoid crash.
4678
4679 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4680
4681 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4682 close to the add_com "shell".
4683
4684 2019-04-18 Tom Tromey <tromey@adacore.com>
4685
4686 * process-stratum-target.h (class process_stratum_target)
4687 <stratum>: Add "final".
4688
4689 2019-04-17 Tom Tromey <tromey@adacore.com>
4690
4691 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4692 against nullptr before use.
4693
4694 2019-04-17 Alan Hayward <alan.hayward@arm.com>
4695
4696 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4697
4698 2019-04-17 Jim Wilson <jimw@sifive.com>
4699 Andrew Burgess <andrew.burgess@embecosm.com>
4700
4701 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4702 code read might fail, assume 4-byte breakpoint in that case.
4703
4704 2019-04-15 Leszek Swirski <leszeks@google.com>
4705
4706 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4707 rather than a hand-rolled POD check when checking for forced MEMORY
4708 classification.
4709
4710 2019-04-15 Alan Hayward <alan.hayward@arm.com>
4711
4712 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4713 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4714 function.
4715 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4716 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4717 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4718 declaration.
4719
4720 2019-04-15 Alan Hayward <alan.hayward@arm.com>
4721
4722 * aarch64-linux-nat.c
4723 (aarch64_linux_nat_target::thread_architecture): Add override.
4724 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4725 each VQ.
4726
4727 2019-04-15 Alan Hayward <alan.hayward@arm.com>
4728
4729 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4730
4731 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
4732
4733 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4734 target types of size 96-bits, add some additional comments, and
4735 check that the builtin type we found was the correct size.
4736
4737 2019-04-12 Eli Zaretskii <eliz@gnu.org>
4738
4739 * utils.c (prompt_for_continue): Don't restore the styling at the
4740 end, as applied_style has the wrong value. This fixes styling in
4741 long lists of file names that are interrupted by the "Continue?"
4742 prompt.
4743
4744 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
4745
4746 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4747 * c-lang.c (c_language_defn): Likewise.
4748 (cplus_language_defn): Likewise.
4749 (asm_language_defn): Likewise.
4750 (minimal_language_defn): Likewise.
4751 * d-lang.c (d_language_defn): Likewise.
4752 * f-lang.c (f_language_defn): Likewise.
4753 * go-lang.c (go_language_defn): Likewise.
4754 * language.c (unknown_language_defn): Likewise.
4755 (auto_language_defn): Likewise.
4756 * language.h (struct language_defn): Remove la_magic field.
4757 (LANG_MAGIC): Delete.
4758 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4759 * objc-lang.c (objc_language_defn): Likewise.
4760 * opencl-lang.c (opencl_language_defn): Likewise.
4761 * p-lang.c (pascal_language_defn): Likewise.
4762 * rust-lang.c (rust_language_defn): Likewise.
4763
4764 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
4765
4766 * riscv-tdep.c (riscv_type_align): New function.
4767 (riscv_type_alignment): Delete.
4768 (riscv_arg_location): Use 'type_align'.
4769 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4770
4771 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
4772
4773 * gdbtypes.c (type_align): A struct with no non-static fields also
4774 has alignment of 1.
4775
4776 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
4777
4778 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4779 component to 0.
4780 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4781 member.
4782 (riscv_struct_info::analyse): New implementation using new
4783 analyse_inner member function.
4784 (riscv_struct_info::field_offset): New member function.
4785 (riscv_struct_info::m_offsets): New member variable.
4786 (riscv_struct_info::analyse_inner): New private member function,
4787 takes the old implementation of riscv_struct_info::analyse but
4788 extended to track field offsets.
4789 (riscv_call_arg_struct): Update the struct folding special cases
4790 to handle cases where empty C++ structs, which are non-zero
4791 length, are found.
4792 (riscv_arg_location): Initialise the length of each location, a
4793 non-zero length now indicates the location is in use.
4794 (riscv_push_dummy_call): Allow for the first location having a
4795 non-zero offset when setting up arguments.
4796 (riscv_return_value): Likewise, but for return values.
4797
4798 2019-04-11 Tom Tromey <tromey@adacore.com>
4799
4800 * utils.c (internal_vproblem): Make "msg" const.
4801
4802 2019-04-11 Alan Hayward <alan.hayward@arm.com>
4803
4804 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4805 * trad-frame.c (trad_frame_reset_saved_regs): New function.
4806 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4807 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4808
4809 2019-04-10 Kevin Buettner <kevinb@redhat.com>
4810
4811 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4812 function.
4813 (fill_gregset): Call amd64_linux_collect_native_gregset instead
4814 of amd64_collect_native_gregset.
4815 (amd64_linux_nat_target::store_registers): Likewise.
4816
4817 2019-04-10 Tom Tromey <tom@tromey.com>
4818
4819 * symtab.c (lookup_global_symbol_from_objfile)
4820 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4821 * objfiles.h (class separate_debug_iterator): New.
4822 (class separate_debug_range): New.
4823 (struct objfile) <separate_debug_objfiles>: New method.
4824 (objfile_separate_debug_iterate): Don't declare.
4825 * objfiles.c (separate_debug_iterator::operator++): Rename from
4826 objfile_separate_debug_iterate.
4827 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4828 iterator.
4829 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4830 iterator.
4831
4832 2019-04-10 Tom Tromey <tom@tromey.com>
4833
4834 * symfile.c (reread_symbols): Remove old comment.
4835 * objfiles.c (free_all_objfiles): Fix a typo.
4836
4837 2019-04-10 Tom Tromey <tom@tromey.com>
4838
4839 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4840 * minsyms.c (lookup_minimal_symbol): Use foreach.
4841 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4842 (lookup_minimal_symbol_solib_trampoline): Likewise.
4843 * symfile.c (reread_symbols): Use foreach.
4844
4845 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
4846 Tom Tromey <tromey@adacore.com>
4847
4848 PR rust/24414:
4849 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4850 (rust_lex_int_test): Change "value" to be LONGEST.
4851 (rust_lex_tests): Add test for long integer literal.
4852
4853 2019-04-09 Tom Tromey <tromey@adacore.com>
4854
4855 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4856 to bool.
4857 (extended_remote_target::attach): Update.
4858 (remote_target::remote_notice_new_inferior): Update.
4859 (remote_target::add_current_inferior_and_thread): Update.
4860 * inferior.c (exit_inferior_1): Use "false".
4861 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4862
4863 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
4864
4865 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4866 the "start" command.
4867
4868 2019-04-08 Kevin Buettner <kevinb@redhat.com>
4869
4870 * python/py-inferior.c (infpy_thread_from_thread_handle):
4871 Adjust comments to reflect renaming of thread_from_thread_handle
4872 to thread_from_handle. Adjust keywords. Fix type error message.
4873 (inferior_object_methods): Add thread_from_handle. Retain
4874 thread_from_thread_handle, but mark it as deprecated.
4875
4876 2019-04-08 Kevin Buettner <kevinb@redhat.com>
4877
4878 * gdbthread.h (find_thread_by_handle): Revise declaration.
4879 * thread.c (find_thread_by_handle): Likewise. Adjust
4880 implementation too.
4881 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4882 support for buffer objects as handles.
4883
4884 2019-04-08 Kevin Buettner <kevinb@redhat.com>
4885
4886 * python/py-infthread.c (thpy_thread_handle): New function.
4887 (thread_object_methods): Register thpy_thread_handle.
4888
4889 2019-04-08 Kevin Buettner <kevinb@redhat.com>
4890
4891 * gdbthread.h (thread_to_thread_handle): Declare.
4892 * thread.c (gdbtypes.h): Include.
4893 (thread_to_thread_handle): New function.
4894
4895 * target.h (struct target_ops): Add thread_info_to_thread_handle.
4896 (target_thread_info_to_thread_handle): Declare.
4897 * target.c (target_thread_info_to_thread_handle): New function.
4898 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4899 * target-delegates.c: Regenerate.
4900
4901 * linux-thread-db.c (class thread_db_target): Add method
4902 thread_info_to_thread_handle.
4903 (thread_db_target::thread_info_to_thread_handle): Define.
4904 * remote.c (class remote_target): Add new method
4905 thread_info_to_thread_handle.
4906 (remote_target::thread_info_to_thread_handle): Define.
4907
4908 2019-04-08 Pedro Alves <palves@redhat.com>
4909
4910 * common/common-exceptions.c (throw_exception): Don't create
4911 named object to throw; throw directly.
4912 (throw_it): Likewise. Don't initialize gdb_exception::message
4913 here, with new; pass FMT and AP to the ctor instead.
4914 * common/common-exceptions.h: Include <string>.
4915 (gdb_exception::gdb_exception(enum return_reason, enum errors,
4916 const char *, va_list)): New ctor. Use std::make_shared.
4917 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4918 errors)): Delete.
4919 (gdb_exception_error::gdb_exception_error(enum errors, const char
4920 *, va_list)): New.
4921 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4922 Add assertion.
4923 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4924 errors)): Delete.
4925 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4926 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4927 Add assertion.
4928
4929 2019-04-08 Tom Tromey <tom@tromey.com>
4930
4931 * valops.c (value_rtti_indirect_type): Replace throw_exception
4932 with throw.
4933 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4934 with throw.
4935 * thread.c (thr_try_catch_cmd): Replace throw_exception with
4936 throw.
4937 * target.c (target_translate_tls_address): Replace throw_exception
4938 with throw.
4939 * stack.c (frame_apply_command_count): Replace throw_exception
4940 with throw.
4941 * solib-spu.c (append_ocl_sos): Replace throw_exception with
4942 throw.
4943 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4944 with throw.
4945 * rs6000-tdep.c (rs6000_frame_cache)
4946 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4947 * remote.c: Replace throw_exception with throw.
4948 * record-full.c (record_full_message, record_full_wait_1)
4949 (record_full_restore): Replace throw_exception with throw.
4950 * record-btrace.c:
4951 (get_thread_current_frame_id, record_btrace_start_replaying)
4952 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4953 (cmd_record_btrace_start): Replace throw_exception with throw.
4954 * parse.c (parse_exp_in_context_1): Replace throw_exception with
4955 throw.
4956 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4957 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4958 * linespec.c:
4959 (find_linespec_symbols): Replace throw_exception with throw.
4960 * infrun.c (displaced_step_prepare, resume): Replace
4961 throw_exception with throw.
4962 * infcmd.c (post_create_inferior): Replace throw_exception with
4963 throw.
4964 * inf-loop.c (inferior_event_handler): Replace throw_exception
4965 with throw.
4966 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4967 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4968 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4969 (get_prev_frame_always, get_frame_pc_if_available)
4970 (get_frame_address_in_block_if_available, get_frame_language):
4971 Replace throw_exception with throw.
4972 * frame-unwind.c (frame_unwind_try_unwinder): Replace
4973 throw_exception with throw.
4974 * eval.c (fetch_subexp_value, evaluate_var_value)
4975 (evaluate_funcall, evaluate_subexp_standard): Replace
4976 throw_exception with throw.
4977 * dwarf2loc.c (call_site_find_chain)
4978 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4979 Replace throw_exception with throw.
4980 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4981 with throw.
4982 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4983 throw.
4984 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4985 * completer.c (complete_line_internal): Replace throw_exception
4986 with throw.
4987 * compile/compile-object-run.c (compile_object_run): Replace
4988 throw_exception with throw.
4989 * cli/cli-script.c (process_next_line): Replace throw_exception
4990 with throw.
4991 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4992 (btrace_enable, btrace_maint_update_pt_packets): Replace
4993 throw_exception with throw.
4994 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4995 throw_exception with throw.
4996 * break-catch-throw.c (re_set_exception_catchpoint): Replace
4997 throw_exception with throw.
4998 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4999 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5000 * aarch64-tdep.c (aarch64_make_prologue_cache)
5001 (aarch64_make_stub_cache): Replace throw_exception with throw.
5002
5003 2019-04-08 Tom Tromey <tom@tromey.com>
5004
5005 * common/common-exceptions.c (throw_exception): Rename from
5006 throw_exception_cxx. Remove old copy. Make argument const.
5007 (throw_it): Create and throw exception objects directly.
5008 * common/common-exceptions.h (throw_exception): Make argument
5009 const.
5010 (struct gdb_exception_error): Add constructor.
5011 (struct gdb_exception_quit): Add constructor.
5012
5013 2019-04-08 Tom Tromey <tom@tromey.com>
5014
5015 * common/common-exceptions.h (exception_rethrow): Don't declare.
5016 (TRY_SJLJ): Update comment.
5017 (TRY, CATCH, END_CATCH): Remove.
5018 * common/common-exceptions.c (exception_rethrow): Remove.
5019
5020 2019-04-08 Tom Tromey <tom@tromey.com>
5021
5022 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5023 Remove.
5024 (gdb_exception_error): Rename from
5025 gdb_exception_RETURN_MASK_ERROR.
5026 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5027 (gdb_quit_bad_alloc): Update.
5028 * aarch64-tdep.c: Update.
5029 * ada-lang.c: Update.
5030 * ada-typeprint.c: Update.
5031 * ada-valprint.c: Update.
5032 * amd64-tdep.c: Update.
5033 * arch-utils.c: Update.
5034 * break-catch-throw.c: Update.
5035 * breakpoint.c: Update.
5036 * btrace.c: Update.
5037 * c-varobj.c: Update.
5038 * cli/cli-cmds.c: Update.
5039 * cli/cli-interp.c: Update.
5040 * cli/cli-script.c: Update.
5041 * common/common-exceptions.c: Update.
5042 * common/new-op.c: Update.
5043 * common/selftest.c: Update.
5044 * compile/compile-c-symbols.c: Update.
5045 * compile/compile-cplus-symbols.c: Update.
5046 * compile/compile-object-load.c: Update.
5047 * compile/compile-object-run.c: Update.
5048 * completer.c: Update.
5049 * corelow.c: Update.
5050 * cp-abi.c: Update.
5051 * cp-support.c: Update.
5052 * cp-valprint.c: Update.
5053 * darwin-nat.c: Update.
5054 * disasm-selftests.c: Update.
5055 * dtrace-probe.c: Update.
5056 * dwarf-index-cache.c: Update.
5057 * dwarf-index-write.c: Update.
5058 * dwarf2-frame-tailcall.c: Update.
5059 * dwarf2-frame.c: Update.
5060 * dwarf2loc.c: Update.
5061 * dwarf2read.c: Update.
5062 * eval.c: Update.
5063 * event-loop.c: Update.
5064 * event-top.c: Update.
5065 * exec.c: Update.
5066 * f-valprint.c: Update.
5067 * fbsd-tdep.c: Update.
5068 * frame-unwind.c: Update.
5069 * frame.c: Update.
5070 * gdbtypes.c: Update.
5071 * gnu-v3-abi.c: Update.
5072 * guile/guile-internal.h: Update.
5073 * guile/scm-block.c: Update.
5074 * guile/scm-breakpoint.c: Update.
5075 * guile/scm-cmd.c: Update.
5076 * guile/scm-disasm.c: Update.
5077 * guile/scm-frame.c: Update.
5078 * guile/scm-lazy-string.c: Update.
5079 * guile/scm-math.c: Update.
5080 * guile/scm-param.c: Update.
5081 * guile/scm-ports.c: Update.
5082 * guile/scm-pretty-print.c: Update.
5083 * guile/scm-symbol.c: Update.
5084 * guile/scm-symtab.c: Update.
5085 * guile/scm-type.c: Update.
5086 * guile/scm-value.c: Update.
5087 * i386-linux-tdep.c: Update.
5088 * i386-tdep.c: Update.
5089 * inf-loop.c: Update.
5090 * infcall.c: Update.
5091 * infcmd.c: Update.
5092 * infrun.c: Update.
5093 * jit.c: Update.
5094 * language.c: Update.
5095 * linespec.c: Update.
5096 * linux-fork.c: Update.
5097 * linux-nat.c: Update.
5098 * linux-tdep.c: Update.
5099 * linux-thread-db.c: Update.
5100 * main.c: Update.
5101 * mi/mi-cmd-break.c: Update.
5102 * mi/mi-cmd-stack.c: Update.
5103 * mi/mi-interp.c: Update.
5104 * mi/mi-main.c: Update.
5105 * objc-lang.c: Update.
5106 * p-valprint.c: Update.
5107 * parse.c: Update.
5108 * ppc-linux-tdep.c: Update.
5109 * printcmd.c: Update.
5110 * python/py-arch.c: Update.
5111 * python/py-breakpoint.c: Update.
5112 * python/py-cmd.c: Update.
5113 * python/py-finishbreakpoint.c: Update.
5114 * python/py-frame.c: Update.
5115 * python/py-framefilter.c: Update.
5116 * python/py-gdb-readline.c: Update.
5117 * python/py-inferior.c: Update.
5118 * python/py-infthread.c: Update.
5119 * python/py-lazy-string.c: Update.
5120 * python/py-linetable.c: Update.
5121 * python/py-objfile.c: Update.
5122 * python/py-param.c: Update.
5123 * python/py-prettyprint.c: Update.
5124 * python/py-progspace.c: Update.
5125 * python/py-record-btrace.c: Update.
5126 * python/py-record.c: Update.
5127 * python/py-symbol.c: Update.
5128 * python/py-type.c: Update.
5129 * python/py-unwind.c: Update.
5130 * python/py-utils.c: Update.
5131 * python/py-value.c: Update.
5132 * python/python.c: Update.
5133 * record-btrace.c: Update.
5134 * record-full.c: Update.
5135 * remote-fileio.c: Update.
5136 * remote.c: Update.
5137 * riscv-tdep.c: Update.
5138 * rs6000-aix-tdep.c: Update.
5139 * rs6000-tdep.c: Update.
5140 * rust-exp.y: Update.
5141 * rust-lang.c: Update.
5142 * s390-tdep.c: Update.
5143 * selftest-arch.c: Update.
5144 * solib-dsbt.c: Update.
5145 * solib-frv.c: Update.
5146 * solib-spu.c: Update.
5147 * solib-svr4.c: Update.
5148 * solib.c: Update.
5149 * sparc64-linux-tdep.c: Update.
5150 * stack.c: Update.
5151 * symfile-mem.c: Update.
5152 * symmisc.c: Update.
5153 * target.c: Update.
5154 * thread.c: Update.
5155 * top.c: Update.
5156 * tracefile-tfile.c: Update.
5157 * tui/tui.c: Update.
5158 * typeprint.c: Update.
5159 * unittests/cli-utils-selftests.c: Update.
5160 * unittests/parse-connection-spec-selftests.c: Update.
5161 * valops.c: Update.
5162 * valprint.c: Update.
5163 * value.c: Update.
5164 * varobj.c: Update.
5165 * windows-nat.c: Update.
5166 * x86-linux-nat.c: Update.
5167 * xml-support.c: Update.
5168
5169 2019-04-08 Tom Tromey <tom@tromey.com>
5170
5171 * xml-support.c: Use C++ exception handling.
5172 * x86-linux-nat.c: Use C++ exception handling.
5173 * windows-nat.c: Use C++ exception handling.
5174 * varobj.c: Use C++ exception handling.
5175 * value.c: Use C++ exception handling.
5176 * valprint.c: Use C++ exception handling.
5177 * valops.c: Use C++ exception handling.
5178 * unittests/parse-connection-spec-selftests.c: Use C++ exception
5179 handling.
5180 * unittests/cli-utils-selftests.c: Use C++ exception handling.
5181 * typeprint.c: Use C++ exception handling.
5182 * tui/tui.c: Use C++ exception handling.
5183 * tracefile-tfile.c: Use C++ exception handling.
5184 * top.c: Use C++ exception handling.
5185 * thread.c: Use C++ exception handling.
5186 * target.c: Use C++ exception handling.
5187 * symmisc.c: Use C++ exception handling.
5188 * symfile-mem.c: Use C++ exception handling.
5189 * stack.c: Use C++ exception handling.
5190 * sparc64-linux-tdep.c: Use C++ exception handling.
5191 * solib.c: Use C++ exception handling.
5192 * solib-svr4.c: Use C++ exception handling.
5193 * solib-spu.c: Use C++ exception handling.
5194 * solib-frv.c: Use C++ exception handling.
5195 * solib-dsbt.c: Use C++ exception handling.
5196 * selftest-arch.c: Use C++ exception handling.
5197 * s390-tdep.c: Use C++ exception handling.
5198 * rust-lang.c: Use C++ exception handling.
5199 * rust-exp.y: Use C++ exception handling.
5200 * rs6000-tdep.c: Use C++ exception handling.
5201 * rs6000-aix-tdep.c: Use C++ exception handling.
5202 * riscv-tdep.c: Use C++ exception handling.
5203 * remote.c: Use C++ exception handling.
5204 * remote-fileio.c: Use C++ exception handling.
5205 * record-full.c: Use C++ exception handling.
5206 * record-btrace.c: Use C++ exception handling.
5207 * python/python.c: Use C++ exception handling.
5208 * python/py-value.c: Use C++ exception handling.
5209 * python/py-utils.c: Use C++ exception handling.
5210 * python/py-unwind.c: Use C++ exception handling.
5211 * python/py-type.c: Use C++ exception handling.
5212 * python/py-symbol.c: Use C++ exception handling.
5213 * python/py-record.c: Use C++ exception handling.
5214 * python/py-record-btrace.c: Use C++ exception handling.
5215 * python/py-progspace.c: Use C++ exception handling.
5216 * python/py-prettyprint.c: Use C++ exception handling.
5217 * python/py-param.c: Use C++ exception handling.
5218 * python/py-objfile.c: Use C++ exception handling.
5219 * python/py-linetable.c: Use C++ exception handling.
5220 * python/py-lazy-string.c: Use C++ exception handling.
5221 * python/py-infthread.c: Use C++ exception handling.
5222 * python/py-inferior.c: Use C++ exception handling.
5223 * python/py-gdb-readline.c: Use C++ exception handling.
5224 * python/py-framefilter.c: Use C++ exception handling.
5225 * python/py-frame.c: Use C++ exception handling.
5226 * python/py-finishbreakpoint.c: Use C++ exception handling.
5227 * python/py-cmd.c: Use C++ exception handling.
5228 * python/py-breakpoint.c: Use C++ exception handling.
5229 * python/py-arch.c: Use C++ exception handling.
5230 * printcmd.c: Use C++ exception handling.
5231 * ppc-linux-tdep.c: Use C++ exception handling.
5232 * parse.c: Use C++ exception handling.
5233 * p-valprint.c: Use C++ exception handling.
5234 * objc-lang.c: Use C++ exception handling.
5235 * mi/mi-main.c: Use C++ exception handling.
5236 * mi/mi-interp.c: Use C++ exception handling.
5237 * mi/mi-cmd-stack.c: Use C++ exception handling.
5238 * mi/mi-cmd-break.c: Use C++ exception handling.
5239 * main.c: Use C++ exception handling.
5240 * linux-thread-db.c: Use C++ exception handling.
5241 * linux-tdep.c: Use C++ exception handling.
5242 * linux-nat.c: Use C++ exception handling.
5243 * linux-fork.c: Use C++ exception handling.
5244 * linespec.c: Use C++ exception handling.
5245 * language.c: Use C++ exception handling.
5246 * jit.c: Use C++ exception handling.
5247 * infrun.c: Use C++ exception handling.
5248 * infcmd.c: Use C++ exception handling.
5249 * infcall.c: Use C++ exception handling.
5250 * inf-loop.c: Use C++ exception handling.
5251 * i386-tdep.c: Use C++ exception handling.
5252 * i386-linux-tdep.c: Use C++ exception handling.
5253 * guile/scm-value.c: Use C++ exception handling.
5254 * guile/scm-type.c: Use C++ exception handling.
5255 * guile/scm-symtab.c: Use C++ exception handling.
5256 * guile/scm-symbol.c: Use C++ exception handling.
5257 * guile/scm-pretty-print.c: Use C++ exception handling.
5258 * guile/scm-ports.c: Use C++ exception handling.
5259 * guile/scm-param.c: Use C++ exception handling.
5260 * guile/scm-math.c: Use C++ exception handling.
5261 * guile/scm-lazy-string.c: Use C++ exception handling.
5262 * guile/scm-frame.c: Use C++ exception handling.
5263 * guile/scm-disasm.c: Use C++ exception handling.
5264 * guile/scm-cmd.c: Use C++ exception handling.
5265 * guile/scm-breakpoint.c: Use C++ exception handling.
5266 * guile/scm-block.c: Use C++ exception handling.
5267 * guile/guile-internal.h: Use C++ exception handling.
5268 * gnu-v3-abi.c: Use C++ exception handling.
5269 * gdbtypes.c: Use C++ exception handling.
5270 * frame.c: Use C++ exception handling.
5271 * frame-unwind.c: Use C++ exception handling.
5272 * fbsd-tdep.c: Use C++ exception handling.
5273 * f-valprint.c: Use C++ exception handling.
5274 * exec.c: Use C++ exception handling.
5275 * event-top.c: Use C++ exception handling.
5276 * event-loop.c: Use C++ exception handling.
5277 * eval.c: Use C++ exception handling.
5278 * dwarf2read.c: Use C++ exception handling.
5279 * dwarf2loc.c: Use C++ exception handling.
5280 * dwarf2-frame.c: Use C++ exception handling.
5281 * dwarf2-frame-tailcall.c: Use C++ exception handling.
5282 * dwarf-index-write.c: Use C++ exception handling.
5283 * dwarf-index-cache.c: Use C++ exception handling.
5284 * dtrace-probe.c: Use C++ exception handling.
5285 * disasm-selftests.c: Use C++ exception handling.
5286 * darwin-nat.c: Use C++ exception handling.
5287 * cp-valprint.c: Use C++ exception handling.
5288 * cp-support.c: Use C++ exception handling.
5289 * cp-abi.c: Use C++ exception handling.
5290 * corelow.c: Use C++ exception handling.
5291 * completer.c: Use C++ exception handling.
5292 * compile/compile-object-run.c: Use C++ exception handling.
5293 * compile/compile-object-load.c: Use C++ exception handling.
5294 * compile/compile-cplus-symbols.c: Use C++ exception handling.
5295 * compile/compile-c-symbols.c: Use C++ exception handling.
5296 * common/selftest.c: Use C++ exception handling.
5297 * common/new-op.c: Use C++ exception handling.
5298 * cli/cli-script.c: Use C++ exception handling.
5299 * cli/cli-interp.c: Use C++ exception handling.
5300 * cli/cli-cmds.c: Use C++ exception handling.
5301 * c-varobj.c: Use C++ exception handling.
5302 * btrace.c: Use C++ exception handling.
5303 * breakpoint.c: Use C++ exception handling.
5304 * break-catch-throw.c: Use C++ exception handling.
5305 * arch-utils.c: Use C++ exception handling.
5306 * amd64-tdep.c: Use C++ exception handling.
5307 * ada-valprint.c: Use C++ exception handling.
5308 * ada-typeprint.c: Use C++ exception handling.
5309 * ada-lang.c: Use C++ exception handling.
5310 * aarch64-tdep.c: Use C++ exception handling.
5311
5312 2019-04-08 Tom Tromey <tom@tromey.com>
5313
5314 * xml-support.c (gdb_xml_parser::parse): Update.
5315 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5316 * value.c (show_convenience): Update.
5317 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5318 (test_parse_flags_qcs): Update.
5319 * thread.c (thr_try_catch_cmd): Update.
5320 * target.c (target_translate_tls_address): Update.
5321 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5322 (info_frame_command_core, frame_apply_command_count): Update.
5323 * rust-exp.y (rust_lex_exception_test): Update.
5324 * riscv-tdep.c (riscv_print_one_register_info): Update.
5325 * remote.c (remote_target::enable_btrace): Update.
5326 * record-btrace.c (record_btrace_enable_warn): Update.
5327 * python/py-utils.c (gdbpy_convert_exception): Update.
5328 * printcmd.c (do_one_display, print_variable_and_value): Update.
5329 * mi/mi-main.c (mi_print_exception): Update.
5330 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5331 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5332 * linux-nat.c (linux_nat_target::attach): Update.
5333 * linux-fork.c (class scoped_switch_fork_info): Update.
5334 * infrun.c (displaced_step_prepare): Update.
5335 * infcall.c (call_function_by_hand_dummy): Update.
5336 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5337 * gnu-v3-abi.c (print_one_vtable): Update.
5338 * frame.c (get_prev_frame_always): Update.
5339 * f-valprint.c (info_common_command_for_block): Update.
5340 * exec.c (try_open_exec_file): Update.
5341 * exceptions.c (print_exception, exception_print)
5342 (exception_fprintf, exception_print_same): Update.
5343 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5344 * dwarf-index-cache.c (index_cache::store)
5345 (index_cache::lookup_gdb_index): Update.
5346 * darwin-nat.c (maybe_cache_shell): Update.
5347 * cp-valprint.c (cp_print_value_fields): Update.
5348 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5349 (gcc_cplus_symbol_address): Update.
5350 * compile/compile-c-symbols.c (gcc_convert_symbol)
5351 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5352 * common/selftest.c: Update.
5353 * common/common-exceptions.h (struct gdb_exception) <message>: Now
5354 a std::string.
5355 (exception_try_scope_entry, exception_try_scope_exit): Don't
5356 declare.
5357 (struct exception_try_scope): Remove.
5358 (TRY): Don't use exception_try_scope.
5359 (struct gdb_exception): Add constructor, operator=.
5360 <what>: New method.
5361 (struct gdb_exception_RETURN_MASK_ALL)
5362 (struct gdb_exception_RETURN_MASK_ERROR)
5363 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5364 (struct gdb_quit_bad_alloc): Update.
5365 * common/common-exceptions.c (exception_none): Change
5366 initializer.
5367 (struct catcher) <state, exception>: Initialize inline.
5368 <prev>: Remove member.
5369 (current_catcher): Remove.
5370 (catchers): New global.
5371 (exceptions_state_mc_init): Simplify.
5372 (catcher_pop): Remove.
5373 (exceptions_state_mc, exceptions_state_mc_catch): Update.
5374 (try_scope_depth, exception_try_scope_entry)
5375 (exception_try_scope_exit): Remove.
5376 (throw_exception_sjlj): Update.
5377 (exception_messages, exception_messages_size): Remove.
5378 (throw_it): Simplify.
5379 (gdb_exception_sliced_copy): Remove.
5380 (throw_exception_cxx): Update.
5381 * cli/cli-script.c (script_from_file): Update.
5382 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5383 Update.
5384 * ada-valprint.c (ada_val_print): Update.
5385 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5386 (create_excep_cond_exprs): Update.
5387
5388 2019-04-08 Tom Tromey <tom@tromey.com>
5389
5390 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5391 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5392 (TRY, CATCH, END_CATCH): Remove some definitions.
5393 * common/common-exceptions.c: Don't use GDB_XCPT.
5394 (catcher_list_size): Remove.
5395 (throw_exception, throw_it): Simplify.
5396
5397 2019-04-05 Tom Tromey <tom@tromey.com>
5398
5399 Revert the header-sorting patch.
5400 * ft32-tdep.c: Revert.
5401 * frv-tdep.c: Revert.
5402 * frv-linux-tdep.c: Revert.
5403 * frame.c: Revert.
5404 * frame-unwind.c: Revert.
5405 * frame-base.c: Revert.
5406 * fork-child.c: Revert.
5407 * findvar.c: Revert.
5408 * findcmd.c: Revert.
5409 * filesystem.c: Revert.
5410 * filename-seen-cache.h: Revert.
5411 * filename-seen-cache.c: Revert.
5412 * fbsd-tdep.c: Revert.
5413 * fbsd-nat.h: Revert.
5414 * fbsd-nat.c: Revert.
5415 * f-valprint.c: Revert.
5416 * f-typeprint.c: Revert.
5417 * f-lang.c: Revert.
5418 * extension.h: Revert.
5419 * extension.c: Revert.
5420 * extension-priv.h: Revert.
5421 * expprint.c: Revert.
5422 * exec.h: Revert.
5423 * exec.c: Revert.
5424 * exceptions.c: Revert.
5425 * event-top.c: Revert.
5426 * event-loop.c: Revert.
5427 * eval.c: Revert.
5428 * elfread.c: Revert.
5429 * dwarf2read.h: Revert.
5430 * dwarf2read.c: Revert.
5431 * dwarf2loc.c: Revert.
5432 * dwarf2expr.h: Revert.
5433 * dwarf2expr.c: Revert.
5434 * dwarf2-frame.c: Revert.
5435 * dwarf2-frame-tailcall.c: Revert.
5436 * dwarf-index-write.h: Revert.
5437 * dwarf-index-write.c: Revert.
5438 * dwarf-index-common.c: Revert.
5439 * dwarf-index-cache.h: Revert.
5440 * dwarf-index-cache.c: Revert.
5441 * dummy-frame.c: Revert.
5442 * dtrace-probe.c: Revert.
5443 * disasm.h: Revert.
5444 * disasm.c: Revert.
5445 * disasm-selftests.c: Revert.
5446 * dictionary.c: Revert.
5447 * dicos-tdep.c: Revert.
5448 * demangle.c: Revert.
5449 * dcache.h: Revert.
5450 * dcache.c: Revert.
5451 * darwin-nat.h: Revert.
5452 * darwin-nat.c: Revert.
5453 * darwin-nat-info.c: Revert.
5454 * d-valprint.c: Revert.
5455 * d-namespace.c: Revert.
5456 * d-lang.c: Revert.
5457 * ctf.c: Revert.
5458 * csky-tdep.c: Revert.
5459 * csky-linux-tdep.c: Revert.
5460 * cris-tdep.c: Revert.
5461 * cris-linux-tdep.c: Revert.
5462 * cp-valprint.c: Revert.
5463 * cp-support.c: Revert.
5464 * cp-namespace.c: Revert.
5465 * cp-abi.c: Revert.
5466 * corelow.c: Revert.
5467 * corefile.c: Revert.
5468 * continuations.c: Revert.
5469 * completer.h: Revert.
5470 * completer.c: Revert.
5471 * complaints.c: Revert.
5472 * coffread.c: Revert.
5473 * coff-pe-read.c: Revert.
5474 * cli-out.h: Revert.
5475 * cli-out.c: Revert.
5476 * charset.c: Revert.
5477 * c-varobj.c: Revert.
5478 * c-valprint.c: Revert.
5479 * c-typeprint.c: Revert.
5480 * c-lang.c: Revert.
5481 * buildsym.c: Revert.
5482 * buildsym-legacy.c: Revert.
5483 * build-id.h: Revert.
5484 * build-id.c: Revert.
5485 * btrace.c: Revert.
5486 * bsd-uthread.c: Revert.
5487 * breakpoint.h: Revert.
5488 * breakpoint.c: Revert.
5489 * break-catch-throw.c: Revert.
5490 * break-catch-syscall.c: Revert.
5491 * break-catch-sig.c: Revert.
5492 * blockframe.c: Revert.
5493 * block.c: Revert.
5494 * bfin-tdep.c: Revert.
5495 * bfin-linux-tdep.c: Revert.
5496 * bfd-target.c: Revert.
5497 * bcache.c: Revert.
5498 * ax-general.c: Revert.
5499 * ax-gdb.h: Revert.
5500 * ax-gdb.c: Revert.
5501 * avr-tdep.c: Revert.
5502 * auxv.c: Revert.
5503 * auto-load.c: Revert.
5504 * arm-wince-tdep.c: Revert.
5505 * arm-tdep.c: Revert.
5506 * arm-symbian-tdep.c: Revert.
5507 * arm-pikeos-tdep.c: Revert.
5508 * arm-obsd-tdep.c: Revert.
5509 * arm-nbsd-tdep.c: Revert.
5510 * arm-nbsd-nat.c: Revert.
5511 * arm-linux-tdep.c: Revert.
5512 * arm-linux-nat.c: Revert.
5513 * arm-fbsd-tdep.c: Revert.
5514 * arm-fbsd-nat.c: Revert.
5515 * arm-bsd-tdep.c: Revert.
5516 * arch-utils.c: Revert.
5517 * arc-tdep.c: Revert.
5518 * arc-newlib-tdep.c: Revert.
5519 * annotate.h: Revert.
5520 * annotate.c: Revert.
5521 * amd64-windows-tdep.c: Revert.
5522 * amd64-windows-nat.c: Revert.
5523 * amd64-tdep.c: Revert.
5524 * amd64-sol2-tdep.c: Revert.
5525 * amd64-obsd-tdep.c: Revert.
5526 * amd64-obsd-nat.c: Revert.
5527 * amd64-nbsd-tdep.c: Revert.
5528 * amd64-nbsd-nat.c: Revert.
5529 * amd64-nat.c: Revert.
5530 * amd64-linux-tdep.c: Revert.
5531 * amd64-linux-nat.c: Revert.
5532 * amd64-fbsd-tdep.c: Revert.
5533 * amd64-fbsd-nat.c: Revert.
5534 * amd64-dicos-tdep.c: Revert.
5535 * amd64-darwin-tdep.c: Revert.
5536 * amd64-bsd-nat.c: Revert.
5537 * alpha-tdep.c: Revert.
5538 * alpha-obsd-tdep.c: Revert.
5539 * alpha-nbsd-tdep.c: Revert.
5540 * alpha-mdebug-tdep.c: Revert.
5541 * alpha-linux-tdep.c: Revert.
5542 * alpha-linux-nat.c: Revert.
5543 * alpha-bsd-tdep.c: Revert.
5544 * alpha-bsd-nat.c: Revert.
5545 * aix-thread.c: Revert.
5546 * agent.c: Revert.
5547 * addrmap.c: Revert.
5548 * ada-varobj.c: Revert.
5549 * ada-valprint.c: Revert.
5550 * ada-typeprint.c: Revert.
5551 * ada-tasks.c: Revert.
5552 * ada-lang.c: Revert.
5553 * aarch64-tdep.c: Revert.
5554 * aarch64-ravenscar-thread.c: Revert.
5555 * aarch64-newlib-tdep.c: Revert.
5556 * aarch64-linux-tdep.c: Revert.
5557 * aarch64-linux-nat.c: Revert.
5558 * aarch64-fbsd-tdep.c: Revert.
5559 * aarch64-fbsd-nat.c: Revert.
5560 * aarch32-linux-nat.c: Revert.
5561
5562 2019-04-05 Tom Tromey <tom@tromey.com>
5563
5564 * ft32-tdep.c: Sort headers.
5565 * frv-tdep.c: Sort headers.
5566 * frv-linux-tdep.c: Sort headers.
5567 * frame.c: Sort headers.
5568 * frame-unwind.c: Sort headers.
5569 * frame-base.c: Sort headers.
5570 * fork-child.c: Sort headers.
5571 * findvar.c: Sort headers.
5572 * findcmd.c: Sort headers.
5573 * filesystem.c: Sort headers.
5574 * filename-seen-cache.h: Sort headers.
5575 * filename-seen-cache.c: Sort headers.
5576 * fbsd-tdep.c: Sort headers.
5577 * fbsd-nat.h: Sort headers.
5578 * fbsd-nat.c: Sort headers.
5579 * f-valprint.c: Sort headers.
5580 * f-typeprint.c: Sort headers.
5581 * f-lang.c: Sort headers.
5582 * extension.h: Sort headers.
5583 * extension.c: Sort headers.
5584 * extension-priv.h: Sort headers.
5585 * expprint.c: Sort headers.
5586 * exec.h: Sort headers.
5587 * exec.c: Sort headers.
5588 * exceptions.c: Sort headers.
5589 * event-top.c: Sort headers.
5590 * event-loop.c: Sort headers.
5591 * eval.c: Sort headers.
5592 * elfread.c: Sort headers.
5593 * dwarf2read.h: Sort headers.
5594 * dwarf2read.c: Sort headers.
5595 * dwarf2loc.c: Sort headers.
5596 * dwarf2expr.h: Sort headers.
5597 * dwarf2expr.c: Sort headers.
5598 * dwarf2-frame.c: Sort headers.
5599 * dwarf2-frame-tailcall.c: Sort headers.
5600 * dwarf-index-write.h: Sort headers.
5601 * dwarf-index-write.c: Sort headers.
5602 * dwarf-index-common.c: Sort headers.
5603 * dwarf-index-cache.h: Sort headers.
5604 * dwarf-index-cache.c: Sort headers.
5605 * dummy-frame.c: Sort headers.
5606 * dtrace-probe.c: Sort headers.
5607 * disasm.h: Sort headers.
5608 * disasm.c: Sort headers.
5609 * disasm-selftests.c: Sort headers.
5610 * dictionary.c: Sort headers.
5611 * dicos-tdep.c: Sort headers.
5612 * demangle.c: Sort headers.
5613 * dcache.h: Sort headers.
5614 * dcache.c: Sort headers.
5615 * darwin-nat.h: Sort headers.
5616 * darwin-nat.c: Sort headers.
5617 * darwin-nat-info.c: Sort headers.
5618 * d-valprint.c: Sort headers.
5619 * d-namespace.c: Sort headers.
5620 * d-lang.c: Sort headers.
5621 * ctf.c: Sort headers.
5622 * csky-tdep.c: Sort headers.
5623 * csky-linux-tdep.c: Sort headers.
5624 * cris-tdep.c: Sort headers.
5625 * cris-linux-tdep.c: Sort headers.
5626 * cp-valprint.c: Sort headers.
5627 * cp-support.c: Sort headers.
5628 * cp-namespace.c: Sort headers.
5629 * cp-abi.c: Sort headers.
5630 * corelow.c: Sort headers.
5631 * corefile.c: Sort headers.
5632 * continuations.c: Sort headers.
5633 * completer.h: Sort headers.
5634 * completer.c: Sort headers.
5635 * complaints.c: Sort headers.
5636 * coffread.c: Sort headers.
5637 * coff-pe-read.c: Sort headers.
5638 * cli-out.h: Sort headers.
5639 * cli-out.c: Sort headers.
5640 * charset.c: Sort headers.
5641 * c-varobj.c: Sort headers.
5642 * c-valprint.c: Sort headers.
5643 * c-typeprint.c: Sort headers.
5644 * c-lang.c: Sort headers.
5645 * buildsym.c: Sort headers.
5646 * buildsym-legacy.c: Sort headers.
5647 * build-id.h: Sort headers.
5648 * build-id.c: Sort headers.
5649 * btrace.c: Sort headers.
5650 * bsd-uthread.c: Sort headers.
5651 * breakpoint.h: Sort headers.
5652 * breakpoint.c: Sort headers.
5653 * break-catch-throw.c: Sort headers.
5654 * break-catch-syscall.c: Sort headers.
5655 * break-catch-sig.c: Sort headers.
5656 * blockframe.c: Sort headers.
5657 * block.c: Sort headers.
5658 * bfin-tdep.c: Sort headers.
5659 * bfin-linux-tdep.c: Sort headers.
5660 * bfd-target.c: Sort headers.
5661 * bcache.c: Sort headers.
5662 * ax-general.c: Sort headers.
5663 * ax-gdb.h: Sort headers.
5664 * ax-gdb.c: Sort headers.
5665 * avr-tdep.c: Sort headers.
5666 * auxv.c: Sort headers.
5667 * auto-load.c: Sort headers.
5668 * arm-wince-tdep.c: Sort headers.
5669 * arm-tdep.c: Sort headers.
5670 * arm-symbian-tdep.c: Sort headers.
5671 * arm-pikeos-tdep.c: Sort headers.
5672 * arm-obsd-tdep.c: Sort headers.
5673 * arm-nbsd-tdep.c: Sort headers.
5674 * arm-nbsd-nat.c: Sort headers.
5675 * arm-linux-tdep.c: Sort headers.
5676 * arm-linux-nat.c: Sort headers.
5677 * arm-fbsd-tdep.c: Sort headers.
5678 * arm-fbsd-nat.c: Sort headers.
5679 * arm-bsd-tdep.c: Sort headers.
5680 * arch-utils.c: Sort headers.
5681 * arc-tdep.c: Sort headers.
5682 * arc-newlib-tdep.c: Sort headers.
5683 * annotate.h: Sort headers.
5684 * annotate.c: Sort headers.
5685 * amd64-windows-tdep.c: Sort headers.
5686 * amd64-windows-nat.c: Sort headers.
5687 * amd64-tdep.c: Sort headers.
5688 * amd64-sol2-tdep.c: Sort headers.
5689 * amd64-obsd-tdep.c: Sort headers.
5690 * amd64-obsd-nat.c: Sort headers.
5691 * amd64-nbsd-tdep.c: Sort headers.
5692 * amd64-nbsd-nat.c: Sort headers.
5693 * amd64-nat.c: Sort headers.
5694 * amd64-linux-tdep.c: Sort headers.
5695 * amd64-linux-nat.c: Sort headers.
5696 * amd64-fbsd-tdep.c: Sort headers.
5697 * amd64-fbsd-nat.c: Sort headers.
5698 * amd64-dicos-tdep.c: Sort headers.
5699 * amd64-darwin-tdep.c: Sort headers.
5700 * amd64-bsd-nat.c: Sort headers.
5701 * alpha-tdep.c: Sort headers.
5702 * alpha-obsd-tdep.c: Sort headers.
5703 * alpha-nbsd-tdep.c: Sort headers.
5704 * alpha-mdebug-tdep.c: Sort headers.
5705 * alpha-linux-tdep.c: Sort headers.
5706 * alpha-linux-nat.c: Sort headers.
5707 * alpha-bsd-tdep.c: Sort headers.
5708 * alpha-bsd-nat.c: Sort headers.
5709 * aix-thread.c: Sort headers.
5710 * agent.c: Sort headers.
5711 * addrmap.c: Sort headers.
5712 * ada-varobj.c: Sort headers.
5713 * ada-valprint.c: Sort headers.
5714 * ada-typeprint.c: Sort headers.
5715 * ada-tasks.c: Sort headers.
5716 * ada-lang.c: Sort headers.
5717 * aarch64-tdep.c: Sort headers.
5718 * aarch64-ravenscar-thread.c: Sort headers.
5719 * aarch64-newlib-tdep.c: Sort headers.
5720 * aarch64-linux-tdep.c: Sort headers.
5721 * aarch64-linux-nat.c: Sort headers.
5722 * aarch64-fbsd-tdep.c: Sort headers.
5723 * aarch64-fbsd-nat.c: Sort headers.
5724 * aarch32-linux-nat.c: Sort headers.
5725
5726 2019-04-04 Tom Tromey <tom@tromey.com>
5727
5728 * varobj.c (varobj_create): Update.
5729 * rust-exp.y (struct rust_parser) <update_innermost_block,
5730 lookup_symbol>: New methods.
5731 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5732 Rename.
5733 (rust_parser::rust_lookup_type)
5734 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5735 * printcmd.c (display_command, do_one_display): Update.
5736 * parser-defs.h (struct parser_state) <parser_state>: Add
5737 "tracker" parameter.
5738 (block_tracker): New member.
5739 (class innermost_block_tracker) <innermost_block_tracker>: Add
5740 "types" parameter.
5741 <reset>: Remove method.
5742 (innermost_block): Don't declare.
5743 (null_post_parser): Update.
5744 * parse.c (innermost_block): Remove global.
5745 (write_dollar_variable): Update.
5746 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5747 Remove "tracker_types" parameter.
5748 (parse_expression): Add "tracker" parameter.
5749 (parse_expression_for_completion): Update.
5750 (null_post_parser): Add "tracker" parameter.
5751 * p-exp.y: Update rules.
5752 * m2-exp.y: Update rules.
5753 * language.h (struct language_defn) <la_post_parser>: Add
5754 "tracker" parameter.
5755 * go-exp.y: Update rules.
5756 * f-exp.y: Update rules.
5757 * expression.h (parse_expression, parse_exp_1): Add "tracker"
5758 parameter.
5759 * d-exp.y: Update rules.
5760 * c-exp.y: Update rules.
5761 * breakpoint.c (set_breakpoint_condition): Create an
5762 innermost_block_tracker.
5763 (watch_command_1): Likewise.
5764 * ada-lang.c (resolve): Add "tracker" parameter.
5765 (resolve_subexp): Likewise.
5766 * ada-exp.y (write_var_from_sym): Update.
5767
5768 2019-04-04 Tom Tromey <tom@tromey.com>
5769
5770 * type-stack.h: New file.
5771 * type-stack.c: New file.
5772 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5773 type-stack.h.
5774 (insert_into_type_stack, insert_type, push_type, push_type_int)
5775 (insert_type_address_space, pop_type, pop_type_int)
5776 (pop_typelist, pop_type_stack, append_type_stack)
5777 (push_type_stack, get_type_stack, push_typelist)
5778 (follow_type_instance_flags, follow_types): Don't declare.
5779 * parse.c (type_stack): Remove global.
5780 (parse_exp_in_context): Update.
5781 (insert_into_type_stack, insert_type, push_type, push_type_int)
5782 (insert_type_address_space, pop_type, pop_type_int)
5783 (pop_typelist, pop_type_stack, append_type_stack)
5784 (push_type_stack, get_type_stack, push_typelist)
5785 (follow_type_instance_flags, follow_types): Remove (moved to
5786 type-stack.c).
5787 * f-exp.y (type_stack): New global.
5788 Update rules.
5789 (push_kind_type, f_parse): Update.
5790 * d-exp.y (type_stack): New global.
5791 Update rules.
5792 (d_parse): Update.
5793 * c-exp.y (struct c_parse_state) <type_stack>: New member.
5794 Update rules.
5795 * Makefile.in (COMMON_SFILES): Add type-stack.c.
5796 (HFILES_NO_SRCDIR): Add type-stack.h.
5797
5798 2019-04-04 Tom Tromey <tom@tromey.com>
5799
5800 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5801 (rust_parser::convert_ast_to_expression, rust_parse)
5802 (rust_lex_test_completion, rust_lex_tests): Update.
5803 * parser-defs.h (struct expr_completion_state): New.
5804 (struct parser_state) <parser_state>: Add completion parameter.
5805 <mark_struct_expression, mark_completion_tag>: New methods.
5806 <parse_completion, m_completion_state>: New members.
5807 (prefixify_expression, null_post_parser): Update.
5808 (mark_struct_expression, mark_completion_tag): Don't declare.
5809 * parse.c (parse_completion, expout_last_struct)
5810 (expout_tag_completion_type, expout_completion_name): Remove
5811 globals.
5812 (parser_state::mark_struct_expression)
5813 (parser_state::mark_completion_tag): Now methods.
5814 (prefixify_expression): Add last_struct parameter.
5815 (prefixify_subexp): Likewise.
5816 (parse_exp_1): Update.
5817 (parse_exp_in_context): Add cstate parameter. Update.
5818 (parse_expression_for_completion): Create an
5819 expr_completion_state.
5820 (null_post_parser): Add "completion" parameter.
5821 * p-exp.y: Update rules.
5822 (yylex): Update.
5823 * language.h (struct language_defn) <la_post_parser>: Add
5824 "completing" parameter.
5825 * go-exp.y: Update rules.
5826 (lex_one_token): Update.
5827 * expression.h (parse_completion): Don't declare.
5828 * d-exp.y: Update rules.
5829 (lex_one_token): Update rules.
5830 * c-exp.y: Update rules.
5831 (lex_one_token): Update.
5832 * ada-lang.c (resolve): Add "parse_completion" parameter.
5833 (resolve_subexp): Likewise.
5834 (ada_resolve_function): Likewise.
5835
5836 2019-04-04 Tom Tromey <tom@tromey.com>
5837
5838 * parser-defs.h (struct parser_state) <start_arglist,
5839 end_arglist>: New methods.
5840 <arglist_len, m_funcall_chain>: New members.
5841 (arglist_len, start_arglist, end_arglist): Don't declare.
5842 * parse.c (arglist_len, funcall_chain): Remove global.
5843 (start_arglist, end_arglist): Remove functions.
5844 (parse_exp_in_context): Update.
5845 * p-exp.y: Update rules.
5846 * m2-exp.y: Update rules.
5847 * go-exp.y: Update rules.
5848 * f-exp.y: Update rules.
5849 * d-exp.y: Update rules.
5850 * c-exp.y: Update rules.
5851
5852 2019-04-04 Tom Tromey <tom@tromey.com>
5853
5854 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5855 lex_operator, push_back>: New methods.
5856 Update all rules.
5857 (rust_parser::lex_hex, lex_escape): Rename and update.
5858 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5859 (rust_parser::lex_operator): Rename and update.
5860 (rust_parser::lex_number, rustyylex, rustyyerror)
5861 (rust_lex_test_init, rust_lex_test_sequence)
5862 (rust_lex_test_push_back, rust_lex_tests): Update.
5863 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5864 parameter.
5865 <lexptr, prev_lexptr>: New members.
5866 (lexptr, prev_lexptr): Don't declare.
5867 * parse.c (lexptr, prev_lexptr): Remove globals.
5868 (parse_exp_in_context): Update.
5869 * p-exp.y (yylex, yyerror): Update.
5870 * m2-exp.y (parse_number, yylex, yyerror): Update.
5871 * go-exp.y (lex_one_token, yyerror): Update.
5872 * f-exp.y (match_string_literal, yylex, yyerror): Update.
5873 * d-exp.y (lex_one_token, yyerror): Update.
5874 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5875 (lex_one_token, yyerror): Update.
5876 * ada-lex.l (YY_INPUT): Update.
5877 (rewind_to_char): Update.
5878 * ada-exp.y (yyerror): Update.
5879
5880 2019-04-04 Tom Tromey <tom@tromey.com>
5881
5882 * rust-exp.y (rustyylex, rust_lex_tests): Update.
5883 * parser-defs.h (struct parser_state) <parser_state>: Add new
5884 parameter.
5885 <comma_terminates>: New member.
5886 (comma_terminates): Don't declare global.
5887 * parse.c (comma_terminates): Remove global.
5888 (parse_exp_in_context): Update.
5889 * p-exp.y (yylex): Update.
5890 * m2-exp.y (yylex): Update.
5891 * go-exp.y (lex_one_token): Update.
5892 * f-exp.y (yylex): Update.
5893 * d-exp.y (lex_one_token): Update.
5894 * c-exp.y (lex_one_token): Update.
5895 * ada-lex.l: Update.
5896
5897 2019-04-04 Tom Tromey <tom@tromey.com>
5898
5899 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5900 (rustyylex, rust_lex_test_init, rust_lex_test_one)
5901 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5902 * parser-defs.h (paren_depth): Don't declare.
5903 * parse.c (paren_depth): Remove global.
5904 (parse_exp_in_context): Update.
5905 * p-exp.y (paren_depth): New global.
5906 (pascal_parse): Initialize it.
5907 * m2-exp.y (paren_depth): New global.
5908 (m2_parse): Initialize it.
5909 * go-exp.y (paren_depth): New global.
5910 (go_parse): Initialize it.
5911 * f-exp.y (paren_depth): New global.
5912 (f_parse): Initialize it.
5913 * d-exp.y (paren_depth): New global.
5914 (d_parse): Initialize it.
5915 * c-exp.y (paren_depth): New global.
5916 (c_parse): Initialize it.
5917 * ada-lex.l (paren_depth): New global.
5918 (lexer_init): Initialize it.
5919
5920 2019-04-04 Tom Tromey <tom@tromey.com>
5921
5922 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5923 (rust_parser::convert_ast_to_type)
5924 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5925 * parser-defs.h (struct parser_state) <parser_state>: Add
5926 parameters. Initialize new members.
5927 <expression_context_block, expression_context_pc>: New members.
5928 * parse.c (expression_context_block, expression_context_pc):
5929 Remove globals.
5930 (parse_exp_in_context): Update.
5931 * p-exp.y: Update all rules.
5932 (yylex): Update.
5933 * m2-exp.y: Update all rules.
5934 (yylex): Update.
5935 * go-exp.y (yylex): Update.
5936 * f-exp.y (yylex): Update.
5937 * d-exp.y: Update all rules.
5938 (yylex): Update.
5939 * c-exp.y: Update all rules.
5940 (lex_one_token, classify_name, yylex, c_parse): Update.
5941 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5942
5943 2019-04-04 Tom Tromey <tom@tromey.com>
5944
5945 * gdbarch.h, gdbarch.c: Rebuild.
5946 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5947 * stap-probe.h:
5948 (struct stap_parse_info): Replace "parser_state" with
5949 "expr_builder".
5950 * parser-defs.h (struct expr_builder): Rename from "parser_state".
5951 (parser_state): New class.
5952 * parse.c (expr_builder): Rename.
5953 (expr_builder::release): Rename.
5954 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5955 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5956 (write_exp_elt_longcst, write_exp_elt_floatcst)
5957 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5958 (write_exp_string_vector, write_exp_bitstring)
5959 (write_exp_msymbol, mark_struct_expression)
5960 (write_dollar_variable)
5961 (insert_type_address_space, increase_expout_size): Replace
5962 "parser_state" with "expr_builder".
5963 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5964 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5965 "parser_state" with "expr_builder".
5966
5967 2019-04-04 Tom Tromey <tom@tromey.com>
5968
5969 * rust-exp.y: Replace "parse_language" with method call.
5970 * p-exp.y:
5971 (yylex): Replace "parse_language" with method call.
5972 * m2-exp.y:
5973 (yylex): Replace "parse_language" with method call.
5974 * go-exp.y (classify_name): Replace "parse_language" with method
5975 call.
5976 * f-exp.y (yylex): Replace "parse_language" with method call.
5977 * d-exp.y (lex_one_token): Replace "parse_language" with method
5978 call.
5979 * c-exp.y:
5980 (lex_one_token, classify_name, yylex): Replace "parse_language"
5981 with method call.
5982 * ada-exp.y (find_primitive_type, type_char)
5983 (type_system_address): Replace "parse_language" with method call.
5984
5985 2019-04-04 Tom Tromey <tom@tromey.com>
5986
5987 * rust-exp.y: Replace "parse_gdbarch" with method call.
5988 * parse.c (write_dollar_variable, insert_type_address_space):
5989 Replace "parse_gdbarch" with method call.
5990 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5991 call.
5992 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5993 call.
5994 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5995 "parse_gdbarch" with method call.
5996 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5997 with method call.
5998 * f-exp.y (parse_type, parse_f_type, yylex): Replace
5999 "parse_gdbarch" with method call.
6000 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6001 "parse_gdbarch" with method call.
6002 * c-exp.y (parse_type, parse_number, classify_name): Replace
6003 "parse_gdbarch" with method call.
6004 * ada-lex.l: Replace "parse_gdbarch" with method call.
6005 * ada-exp.y (parse_type, find_primitive_type, type_char)
6006 (type_system_address): Replace "parse_gdbarch" with method call.
6007
6008 2019-04-04 Tom Tromey <tom@tromey.com>
6009
6010 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6011 * stap-probe.c (stap_parse_argument): Update.
6012 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6013 initial_size parameter.
6014 * rust-exp.y (rust_lex_tests): Update.
6015 * parse.c (parser_state): Update.
6016 (parse_exp_in_context): Update.
6017 * parser-defs.h (struct parser_state) <parser_state>: Remove
6018 "initial_size" parameter.
6019
6020 2019-04-04 Tom Tromey <tom@tromey.com>
6021
6022 * parser-defs.h (increase_expout_size): Don't declare.
6023 * parse.c (increase_expout_size): Now static.
6024
6025 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
6026
6027 * gnu-nat.c (gnu_nat_target::wait): Fix
6028 target_waitstatus_to_string call.
6029
6030 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
6031
6032 * eval.c (evaluate_subexp_standard): Handle internal functions
6033 during Fortran function call handling.
6034
6035 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
6036
6037 * NEWS: Mention new internal functions.
6038 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6039 (read_base_type): Use dwarf2_init_complex_target_type.
6040 * value.c (creal_internal_fn): New function.
6041 (cimag_internal_fn): New function.
6042 (_initialize_values): Register new internal functions.
6043
6044 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6045
6046 * infrun.c (stop_all_threads): If debug_infrun, always
6047 trace the wait status after wait_one, using
6048 target_waitstatus_to_string and target_pid_to_str.
6049 (handle_inferior_event): Replace various trace of
6050 wait status kind by a single trace.
6051 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6052 wait status kind image by target_waitstatus_to_string.
6053 * target/waitstatus.c (target_waitstatus_to_string): Fix
6054 obsolete comment.
6055
6056 2019-04-01 Tom Tromey <tromey@adacore.com>
6057
6058 PR symtab/23331:
6059 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6060
6061 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
6062 Pedro Alves <palves@redhat.com>
6063
6064 * top.c (quit_force): Call 'finalize_values'.
6065 * value.c (finalize_values): New function.
6066 * value.h (finalize_values): Declare.
6067
6068 2019-03-30 Eli Zaretskii <eliz@gnu.org>
6069
6070 * NEWS: Announce $_gdb_major and $_gdb_minor.
6071
6072 * top.c (init_gdb_version_vars): New function.
6073 (gdb_init): Call init_gdb_version_vars.
6074
6075 2019-03-29 Tom Tromey <tromey@adacore.com>
6076
6077 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
6078 help text. Remove dead code.
6079
6080 2019-03-29 Keith Seitz <keiths@redhat.com>
6081
6082 From Siddhesh Poyarekar:
6083 * f-lang.h (f77_get_upperbound): Return LONGEST.
6084 (f77_get_lowerbound): Likewise.
6085 * f-typeprint.c (f_type_print_varspec_suffix): Expand
6086 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
6087 print them.
6088 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
6089 plongest to format print it.
6090 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6091 (f77_get_upperbound): Likewise.
6092 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6093 LOWER_BOUND to LONGEST.
6094 (f77_create_arrayprint_offset_tbl): Likewise.
6095
6096 2019-03-29 Keith Seitz <keiths@redhat.com>
6097
6098 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6099 %s/pulongest for TYPE_LENGTH instead of %d in format
6100 strings.
6101 * ada-typerint.c (ada_print_type): Likewise.
6102 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6103 * compile/compile-c-support.c (generate_register_struct): Likewise.
6104 * gdbtypes.c (recursive_dump_type): Likewise.
6105 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6106 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
6107 instead of %d in format strings.
6108 * riscv-tdep.c (riscv_type_alignment): Cast second argument
6109 to std::min to ULONGEST.
6110 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6111 instead of %d in format strings.
6112 * tracepoint.c (info_scope_command): Likewise.
6113 * typeprint.c (print_offset_data::update)
6114 (print_offset_data::finish): Likewise.
6115 * xtensa-tdep.c (xtensa_store_return_value)
6116 (xtensa_push_dummy_call): Likewise.
6117
6118 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
6119
6120 * windows-nat.c (display_selector): Fixed format specifications
6121 for 64-bit Cygwin.
6122
6123 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6124
6125 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6126
6127 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
6128
6129 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6130 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6131 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6132 (nios2_linux_init_abi): Install it.
6133
6134 2019-03-28 Alan Hayward <alan.hayward@arm.com>
6135
6136 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6137
6138 2019-03-28 Alan Hayward <alan.hayward@arm.com>
6139
6140 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6141
6142 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6143 Tom Tromey <tromey@adacore.com>
6144
6145 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6146
6147 2019-03-26 Joel Brobecker <brobecker@adacore.com>
6148
6149 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6150 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6151 method to compute the bounds of range types. Also print "[evaluated]"
6152 if the bounds' values come from a dynamic evaluation.
6153
6154 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
6155
6156 * cp-valprint.c (cp_print_value_fields): Don't print trailing
6157 whitespace when pretty printing is on.
6158
6159 2019-03-26 Alan Hayward <alan.hayward@arm.com>
6160
6161 * ppc-linux-nat.c: Add include.
6162
6163 2019-03-26 Alan Hayward <alan.hayward@arm.com>
6164
6165 * NEWS: Mention AArch64 Pointer Authentication.
6166
6167 2019-03-26 Alan Hayward <alan.hayward@arm.com>
6168
6169 * arm-linux-nat.c: Add include.
6170
6171 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
6172
6173 * source-cache.c (source_cache::get_source_lines): Re-read
6174 fullname after calling open_source_file.
6175
6176 2019-03-25 John Baldwin <jhb@FreeBSD.org>
6177
6178 * NEWS: Mention TLS support for FreeBSD.
6179
6180 2019-03-25 Tom Tromey <tromey@adacore.com>
6181
6182 * minsyms.c (BUNCH_SIZE): Update comment.
6183 (~minimal_symbol_reader): Remove old comment.
6184 (compact_minimal_symbols): Update comment.
6185 (minimal_symbol_reader::install): Remove old comment. Update
6186 other comments.
6187
6188 2019-03-25 Alan Hayward <alan.hayward@arm.com>
6189
6190 * s390-linux-nat.c: Add include.
6191
6192 2019-03-25 Alan Hayward <alan.hayward@arm.com>
6193
6194 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6195 Call linux_get_hwcap.
6196 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6197 Likewise.
6198 (aarch64_linux_get_hwcap): Remove function.
6199 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6200 declaration.
6201 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6202 linux_get_hwcap.
6203 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6204 * linux-tdep.c (linux_get_hwcap): Add function.
6205 (linux_get_hwcap2): Likewise.
6206 * linux-tdep.h (linux_get_hwcap): Add declaration.
6207 (linux_get_hwcap2): Likewise.
6208 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6209 (ppc_linux_get_hwcap2): Likewise.
6210 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6211 linux_get_hwcap.
6212 (ppc_linux_nat_target::insert_watchpoint): Likewise.
6213 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6214 (ppc_linux_nat_target::read_description): Likewise.
6215 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6216 * s390-linux-nat.c: Likewise.
6217 * s390-linux-tdep.c (s390_core_read_description): Likewise.
6218
6219 2019-03-24 Tom Tromey <tom@tromey.com>
6220
6221 * ada-lang.c (standard_lookup): Simplify initialization.
6222 (ada_lookup_symbol_nonlocal): Simplify return.
6223 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6224 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6225 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6226 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6227 initialization.
6228 * solib.c (solib_global_lookup): Simplify.
6229 * symtab.c (null_block_symbol): Remove.
6230 (symbol_cache_lookup): Simplify returns.
6231 (lookup_language_this): Simplify returns.
6232 (lookup_symbol_aux): Simplify return.
6233 (lookup_local_symbol): Simplify returns.
6234 (lookup_global_symbol_from_objfile): Simplify return.
6235 (lookup_symbol_in_objfile_symtabs)
6236 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6237 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6238 (lookup_static_symbol, lookup_global_symbol): Simplify return.
6239 * cp-namespace.c (cp_lookup_bare_symbol)
6240 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6241 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6242 (cp_lookup_nested_symbol): Don't use null_block_symbol.
6243 (cp_lookup_symbol_via_imports): Simplify initialization.
6244 (find_symbol_in_baseclass): Likewise.
6245 * symtab.h (null_block_symbol): Remove.
6246 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6247 (d_lookup_nested_symbol, d_lookup_symbol_imports)
6248 (d_lookup_symbol_module): Likewise.
6249 (find_symbol_in_baseclass): Simplify initialization.
6250
6251 2019-03-24 Tom Tromey <tom@tromey.com>
6252
6253 * expression.h: Don't include symtab.h.
6254 (struct block): Forward declare.
6255
6256 2019-03-24 Tom Tromey <tom@tromey.com>
6257
6258 * c-exp.y (typebase): Remove casts.
6259 * gdbtypes.c (lookup_unsigned_typename, )
6260 (lookup_signed_typename): Remove cast.
6261 * eval.c (parse_to_comma_and_eval): Remove cast.
6262 * parse.c (write_dollar_variable): Remove cast.
6263 * block.h (struct block) <superblock>: Now const.
6264 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6265 * psymtab.c (psym_map_matching_symbols): Make "block" const.
6266 (map_block): Make "block" const.
6267 * symfile.h (struct quick_symbol_functions)
6268 <map_matching_symbols>: Constify block argument to "callback".
6269 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6270 const.
6271 (find_pc_sect_compunit_symtab): Make "b" const.
6272 (find_symbol_at_address): Likewise.
6273 (search_symbols): Likewise.
6274 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6275 (dw2_debug_names_lookup_symbol): Likewise.
6276 (dw2_map_matching_symbols): Update.
6277 * p-valprint.c (pascal_val_print): Remove "block".
6278 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6279 (aux_add_nonlocal_symbols): Make "block" const.
6280 (resolve_subexp): Remove cast.
6281 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6282 const.
6283 (iterate_over_file_blocks): Likewise.
6284 * f-exp.y (%union) <bval>: Remove.
6285 * coffread.c (patch_opaque_types): Make "b" const.
6286 * spu-tdep.c (spu_catch_start): Make "block" const.
6287 * c-valprint.c (print_unpacked_pointer): Remove "block".
6288 * symmisc.c (dump_symtab_1): Make "b" const.
6289 (block_depth): Make "block" const.
6290 * d-exp.y (%union) <bval>: Remove.
6291 * cp-support.h (cp_lookup_rtti_type): Update.
6292 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6293 * psymtab.c (psym_lookup_symbol): Make "block" const.
6294 (maintenance_check_psymtabs): Make "b" const.
6295 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6296 (enumerate_locals, enumerate_args): Update.
6297 * python/py-symtab.c (stpy_global_block): Make "block" const.
6298 (stpy_static_block): Likewise.
6299 * inline-frame.c (block_starting_point_at): Make "new_block"
6300 const.
6301 * block.c (find_block_in_blockvector): Make return type const.
6302 (blockvector_for_pc_sect): Make "b" const.
6303 (find_block_in_blockvector): Make "b" const.
6304
6305 2019-03-23 Tom Tromey <tom@tromey.com>
6306
6307 * varobj.c (varobj_create): Update.
6308 * symfile.c (clear_symtab_users): Don't reset innermost_block.
6309 * printcmd.c (display_command, do_one_display): Don't reset
6310 innermost_block.
6311 * parser-defs.h (enum innermost_block_tracker_type): Move to
6312 expression.h.
6313 (innermost_block): Update comment.
6314 * parse.c (parse_exp_1): Add tracker_types parameter.
6315 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
6316 tracker_types parameter. Reset innermost_block.
6317 (parse_exp_in_context): Remove.
6318 (parse_expression_for_completion): Update.
6319 * objfiles.c (~objfile): Don't reset expression_context_block or
6320 innermost_block.
6321 * expression.h (enum innermost_block_tracker_type): Move from
6322 parser-defs.h.
6323 (parse_exp_1): Add tracker_types parameter.
6324 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6325 reset innermost_block.
6326
6327 2019-03-23 Tom Tromey <tom@tromey.com>
6328
6329 * objfiles.h: Include bcache.h.
6330
6331 2019-03-23 Tom Tromey <tom@tromey.com>
6332
6333 * linespec.c (get_current_search_block): Use
6334 scoped_restore_current_language.
6335 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6336
6337 2019-03-22 Alan Hayward <alan.hayward@arm.com>
6338 Jiong Wang <jiong.wang@arm.com>
6339
6340 * aarch64-linux-tdep.c
6341 (aarch64_linux_iterate_over_regset_sections): Check for pauth
6342 section.
6343 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6344
6345 2019-03-22 Alan Hayward <alan.hayward@arm.com>
6346 Jiong Wang <jiong.wang@arm.com>
6347
6348 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6349 instructions.
6350 (aarch64_analyze_prologue_test): Add PACIASP test.
6351 (aarch64_prologue_prev_register): Unmask PC value.
6352
6353 2019-03-22 Alan Hayward <alan.hayward@arm.com>
6354 Jiong Wang <jiong.wang@arm.com>
6355
6356 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6357 (aarch64_dwarf2_prev_register): Unmask PC value.
6358 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6359 (aarch64_execute_dwarf_cfa_vendor_op): Check for
6360 DW_CFA_AARCH64_negate_ra_state.
6361 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6362
6363 2019-03-22 Alan Hayward <alan.hayward@arm.com>
6364 Jiong Wang <jiong.wang@arm.com>
6365
6366 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6367 registers.
6368 (aarch64_pseudo_register_name): Likewise.
6369 (aarch64_pseudo_register_type): Likewise.
6370 (aarch64_pseudo_register_reggroup_p): Likewise.
6371 (aarch64_gdbarch_init): Add pauth registers.
6372 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6373 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6374 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6375 (struct gdbarch_tdep): Add regnum for ra_state.
6376
6377 2019-03-22 Alan Hayward <alan.hayward@arm.com>
6378 Jiong Wang <jiong.wang@arm.com>
6379
6380 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6381
6382 2019-03-22 Alan Hayward <alan.hayward@arm.com>
6383 Jiong Wang <jiong.wang@arm.com>
6384
6385 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6386 function.
6387 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6388 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6389 (aarch64_gdbarch_init): Add puth registers.
6390 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6391 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6392 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6393
6394 2019-03-22 Alan Hayward <alan.hayward@arm.com>
6395 Jiong Wang <jiong.wang@arm.com>
6396
6397 * aarch64-linux-nat.c
6398 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6399 * aarch64-linux-tdep.c
6400 (aarch64_linux_core_read_description): Likewise.
6401 (aarch64_linux_get_hwcap): New function.
6402 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6403 (aarch64_linux_get_hwcap): New declaration.
6404
6405 2019-03-22 Alan Hayward <alan.hayward@arm.com>
6406 Jiong Wang <jiong.wang@arm.com>
6407
6408 * aarch64-linux-nat.c
6409 (aarch64_linux_nat_target::read_description): Add pauth param.
6410 * aarch64-linux-tdep.c
6411 (aarch64_linux_core_read_description): Likewise.
6412 * aarch64-tdep.c (struct target_desc): Add in pauth.
6413 (aarch64_read_description): Add pauth param.
6414 (aarch64_gdbarch_init): Likewise.
6415 * aarch64-tdep.h (aarch64_read_description): Likewise.
6416 * arch/aarch64.c (aarch64_create_target_description): Likewise.
6417 * arch/aarch64.h (aarch64_create_target_description): Likewise.
6418 * features/Makefile: Add new files.
6419 * features/aarch64-pauth.c: New file.
6420 * features/aarch64-pauth.xml: New file.
6421
6422 2019-03-20 Tom Tromey <tromey@adacore.com>
6423
6424 * infrun.c (handle_inferior_event): Rename from
6425 handle_inferior_event_1. Create a scoped_value_mark.
6426 (handle_inferior_event): Remove.
6427
6428 2019-03-19 Tom Tromey <tromey@adacore.com>
6429
6430 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6431 * infrun.h (print_stop_event): Add "displays" parameter.
6432 * infrun.c (print_stop_event): Add "displays" parameter.
6433
6434 2019-03-19 Pedro Alves <palves@redhat.com>
6435
6436 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6437 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
6438 to -1. Fix TABs vs spaces.
6439 (tui_ui_out::tui_ui_out): Don't initialize fields here.
6440 * tui/tui-out.h (tui_ui_out) Add intro comments.
6441 <m_line, m_start_of_line>: In-class initialize, and add describing
6442 comment.
6443
6444 2019-03-18 Alan Hayward <alan.hayward@arm.com>
6445
6446 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6447 variable names.
6448 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6449
6450 2019-03-18 Pedro Alves <palves@redhat.com>
6451 Eli Zaretskii <eliz@gnu.org>
6452
6453 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6454 m_line and m_start_of_line.
6455
6456 2019-03-18 Eli Zaretskii <eliz@gnu.org>
6457
6458 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6459 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6460 it returns a newline. This fixes a regression in TU mode, whereby
6461 the next line is output on the same screen line as the user input.
6462
6463 2019-03-18 Tom Tromey <tromey@adacore.com>
6464
6465 * minsyms.c (minimal_symbol_reader::install): Remove call to
6466 obstack_blank.
6467
6468 2019-03-18 Pedro Alves <palves@redhat.com>
6469
6470 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6471 New globals.
6472 (apply_style): New, factored out from ...
6473 (apply_ansi_escape): ... this. Handle reverse video mode.
6474 (tui_set_reverse_mode): New function.
6475 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6476 * tui/tui-winsource.c (tui_show_source_line): Use
6477 tui_set_reverse_mode instead of setting A_STANDOUT.
6478 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6479 New setter methods.
6480
6481 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
6482
6483 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6484 Handle tabs.
6485
6486 2019-03-18 Tom Tromey <tromey@adacore.com>
6487
6488 * ada-lang.c (empty_array): Add "high" parameter.
6489 (ada_evaluate_subexp): Update.
6490
6491 2019-03-17 Sergei Trofimovich <siarheit@google.com>
6492
6493 * unittests/string_view-selftests.c: Define
6494 _initialize_string_view_selftests unconditionally.
6495
6496 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
6497
6498 PR gdb/24350
6499 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6500
6501 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
6502
6503 PR gdb/24351
6504 * windows-nat.c (display_selector): Fix format specifiers.
6505
6506 2019-03-17 Eli Zaretskii <eliz@gnu.org>
6507
6508 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6509 tui_refill_source_window instead of tui_refresh_win, to update the
6510 current execution line. This fixes redisplay of the current line
6511 when stepping through the code with "next" or "step".
6512
6513 2019-03-16 Eli Zaretskii <eliz@gnu.org>
6514
6515 * source-cache.c (source_cache::get_source_lines): Call
6516 find_source_lines to initialize s->nlines. This fixes vertical
6517 scrolling of TUI source window when the DOWN arrow is pressed.
6518
6519 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6520
6521 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6522 linux-thread-db.c (_initialize_thread_db): Likewise.
6523
6524 2019-03-16 Eli Zaretskii <eliz@gnu.org>
6525
6526 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6527 wclrtoeol in tui_show_source_line". This reverts changes made in
6528 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6529
6530 2019-03-15 Tom Tromey <tom@tromey.com>
6531
6532 * symtab.h (struct minimal_symbol): Derive from
6533 general_symbol_info.
6534 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6535 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6536 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6537 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6538 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6539 (MSYMBOL_SEARCH_NAME): Update.
6540 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6541 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6542 * minsyms.c (minimal_symbol_reader::record_full): Update.
6543
6544 2019-03-15 Tom Tromey <tom@tromey.com>
6545
6546 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6547
6548 2019-03-15 Tom Tromey <tom@tromey.com>
6549
6550 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6551 unique_xmalloc_ptr.
6552 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6553 Update.
6554 * minsyms.c (lookup_minimal_symbol_by_pc_section)
6555 (build_minimal_symbol_hash_tables)
6556 (minimal_symbol_reader::install): Update.
6557
6558 2019-03-15 Tom Tromey <tom@tromey.com>
6559
6560 * symtab.c (create_demangled_names_hash): Update.
6561 (symbol_set_names): Update.
6562 * objfiles.h (struct objfile_per_bfd_storage)
6563 <demangled_names_hash>: Now an htab_up.
6564 * objfiles.c (objfile_per_bfd_storage): Simplify.
6565
6566 2019-03-15 Tom Tromey <tom@tromey.com>
6567
6568 * objfiles.h (struct objfile_per_bfd_storage): Declare
6569 destructor.
6570 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6571 New.
6572 (get_objfile_bfd_data): Use new. Don't initialize
6573 language_of_main.
6574 (free_objfile_per_bfd_storage): Remove.
6575 (objfile_bfd_data_free, objfile::~objfile): Use delete.
6576
6577 2019-03-15 Tom Tromey <tom@tromey.com>
6578
6579 * symfile.c (reread_symbols): Update.
6580 * objfiles.c (objfile::objfile): Update.
6581 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6582 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6583 comment.
6584 (minimal_symbol_reader::install): Update.
6585 (terminate_minimal_symbol_table): Remove.
6586 * jit.c (jit_object_close_impl): Update.
6587
6588 2019-03-15 Tom Tromey <tom@tromey.com>
6589
6590 * minsyms.c (minimal_symbol_reader::record_full): Remove some
6591 initializations.
6592
6593 2019-03-15 Tom Tromey <tom@tromey.com>
6594
6595 * objfiles.h (struct objfile_per_bfd_storage)
6596 <demangled_hash_languages>: Now a bitset.
6597 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6598 (lookup_minimal_symbol): Update.
6599
6600 2019-03-15 Tom Tromey <tom@tromey.com>
6601
6602 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6603 Don't return the symbol.
6604 * coffread.c (record_minimal_symbol): Use record_full.
6605
6606 2019-03-14 Eli Zaretskii <eliz@gnu.org>
6607
6608 The MS-Windows port of ncurses fails to switch to a color pair if
6609 one or both of the colors are the implicit default colors. This
6610 change records the default colors when TUI is initialized, and
6611 then specifies them explicitly when a color pair uses the default
6612 colors. This allows color styling in TUI mode on MS-Windows.
6613
6614 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
6615 ncurses_norm_attr.
6616 (tui_initialize_io) [__MINGW32__]: Record the default terminal
6617 colors in ncurses_norm_attr.
6618 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6619 "none", replace it with the default color recorded in
6620 ncurses_norm_attr.
6621
6622 2019-03-14 Tom Tromey <tromey@adacore.com>
6623
6624 * source-cache.h (class source_cache) <get_source_lines>: Return
6625 std::string.
6626 * source-cache.c (source_cache::extract_lines): Handle case where
6627 first_pos==npos. Return std::string.
6628 (source_cache::get_source_lines): Update.
6629
6630 2019-03-14 Tom Tromey <tromey@adacore.com>
6631
6632 * NEWS: Add item for "style sources" commands.
6633 * source-cache.c (source_cache::get_source_lines): Check
6634 source_styling.
6635 * cli/cli-style.c (source_styling): New global.
6636 (_initialize_cli_style): Add "style sources" commands.
6637 (show_style_sources): New function.
6638 * cli/cli-style.h (source_styling): Declare.
6639
6640 2019-03-14 Pedro Alves <palves@redhat.com>
6641 Tom Tromey <tromey@adacore.com>
6642
6643 * tui/tui-winsource.h (tui_refill_source_window): Declare.
6644 * tui/tui-winsource.c (tui_refill_source_window): New function,
6645 from...
6646 (tui_horizontal_source_scroll): ... here. Move some logic.
6647 * cli/cli-style.c (set_style_enabled): Notify new observable.
6648 * tui/tui-hooks.c (tui_redisplay_source): New function.
6649 (tui_attach_detach_observers): Attach or detach
6650 tui_redisplay_source.
6651 * observable.h (source_styling_changed): New observable.
6652 * observable.c: Define source_styling_changed observable.
6653
6654 2019-03-13 Tom Tromey <tromey@adacore.com>
6655
6656 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6657 (i386_gnu_nat_target::store_registers): Update.
6658 * target-debug.h (target_debug_print_std_string): New macro.
6659 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6660 * windows-tdep.c (display_one_tib): Update.
6661 * tui/tui-stack.c (tui_make_status_line): Update.
6662 * top.c (print_inferior_quit_action): Update.
6663 * thread.c (thr_try_catch_cmd): Update.
6664 (add_thread_with_info): Update.
6665 (thread_target_id_str): Update.
6666 (thr_try_catch_cmd): Update.
6667 (thread_command): Update.
6668 (thread_find_command): Update.
6669 * record-btrace.c (record_btrace_target::info_record)
6670 (record_btrace_resume_thread, record_btrace_target::resume)
6671 (record_btrace_cancel_resume, record_btrace_step_thread)
6672 (record_btrace_target::wait, record_btrace_target::wait)
6673 (record_btrace_target::wait, record_btrace_target::stop): Update.
6674 * progspace.c (print_program_space): Update.
6675 * process-stratum-target.c
6676 (process_stratum_target::thread_address_space): Update.
6677 * linux-fork.c (linux_fork_mourn_inferior)
6678 (detach_checkpoint_command, info_checkpoints_command)
6679 (linux_fork_context): Update.
6680 (linux_fork_detach): Update.
6681 (class scoped_switch_fork_info): Update.
6682 (delete_checkpoint_command): Update.
6683 * infrun.c (follow_fork_inferior): Update.
6684 (follow_fork_inferior): Update.
6685 (proceed_after_vfork_done): Update.
6686 (handle_vfork_child_exec_or_exit): Update.
6687 (follow_exec): Update.
6688 (displaced_step_prepare_throw): Update.
6689 (displaced_step_restore): Update.
6690 (start_step_over): Update.
6691 (resume_1): Update.
6692 (clear_proceed_status_thread): Update.
6693 (proceed): Update.
6694 (print_target_wait_results): Update.
6695 (do_target_wait): Update.
6696 (context_switch): Update.
6697 (stop_all_threads): Update.
6698 (restart_threads): Update.
6699 (finish_step_over): Update.
6700 (handle_signal_stop): Update.
6701 (switch_back_to_stepped_thread): Update.
6702 (keep_going_pass_signal): Update.
6703 (print_exited_reason): Update.
6704 (normal_stop): Update.
6705 * inferior.c (inferior_pid_to_str): Change return type.
6706 (print_selected_inferior): Update.
6707 (add_inferior): Update.
6708 (detach_inferior): Update.
6709 * dummy-frame.c (fprint_dummy_frames): Update.
6710 * dcache.c (dcache_info_1): Update.
6711 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6712 (btrace_fetch, btrace_clear): Update.
6713 * linux-tdep.c (linux_core_pid_to_str): Change return type.
6714 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6715 type.
6716 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6717 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6718 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6719 * gdbarch.c, gdbarch.h: Rebuild.
6720 * gdbarch.sh (core_pid_to_str): Change return type.
6721 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6722 return type.
6723 (windows_nat_target::pid_to_str): Change return type.
6724 (windows_delete_thread): Update.
6725 (windows_nat_target::attach): Update.
6726 (windows_nat_target::files_info): Update.
6727 * target-delegates.c: Rebuild.
6728 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6729 return type.
6730 (sol_thread_target::pid_to_str): Change return type.
6731 * remote.c (class remote_target) <pid_to_str>: Change return
6732 type.
6733 (remote_target::pid_to_str): Change return type.
6734 (extended_remote_target::attach, remote_target::remote_stop_ns)
6735 (remote_target::remote_notif_remove_queued_reply)
6736 (remote_target::push_stop_reply, remote_target::disable_btrace):
6737 Update.
6738 (extended_remote_target::attach): Update.
6739 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6740 type.
6741 (gdbsim_target::pid_to_str): Change return type.
6742 * ravenscar-thread.c (struct ravenscar_thread_target)
6743 <pid_to_str>: Change return type.
6744 (ravenscar_thread_target::pid_to_str): Change return type.
6745 * procfs.c (class procfs_target) <pid_to_str>: Change return
6746 type.
6747 (procfs_target::pid_to_str): Change return type.
6748 (procfs_target::attach): Update.
6749 (procfs_target::detach): Update.
6750 (procfs_target::fetch_registers): Update.
6751 (procfs_target::store_registers): Update.
6752 (procfs_target::wait): Update.
6753 (procfs_target::files_info): Update.
6754 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6755 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6756 return type.
6757 (nto_procfs_target::pid_to_str): Change return type.
6758 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6759 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6760 return type.
6761 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6762 (exit_lwp): Update.
6763 (attach_proc_task_lwp_callback, get_detach_signal)
6764 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6765 (linux_nat_target::resume, wait_lwp, stop_callback)
6766 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6767 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6768 (linux_nat_wait_1, resume_stopped_resumed_lwps)
6769 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6770 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6771 type.
6772 (inf_ptrace_target::attach): Update.
6773 (inf_ptrace_target::files_info): Update.
6774 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6775 type.
6776 (go32_nat_target::pid_to_str): Change return type.
6777 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6778 (gnu_nat_target::wait): Update.
6779 (gnu_nat_target::wait): Update.
6780 (gnu_nat_target::resume): Update.
6781 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6782 (fbsd_nat_target::wait): Update.
6783 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6784 type.
6785 (darwin_nat_target::attach): Update.
6786 * corelow.c (class core_target) <pid_to_str>: Change return type.
6787 (core_target::pid_to_str): Change return type.
6788 * target.c (normal_pid_to_str): Change return type.
6789 (default_pid_to_str): Likewise.
6790 (target_pid_to_str): Change return type.
6791 (target_translate_tls_address): Update.
6792 (target_announce_detach): Update.
6793 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6794 return type.
6795 (bsd_uthread_target::pid_to_str): Change return type.
6796 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6797 type.
6798 (bsd_kvm_target::pid_to_str): Change return type.
6799 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6800 return type.
6801 (aix_thread_target::pid_to_str): Change return type.
6802 * target.h (struct target_ops) <pid_to_str>: Change return type.
6803 (target_pid_to_str, normal_pid_to_str): Likewise.
6804 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6805 type.
6806 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6807 type.
6808 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6809 return type.
6810 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6811 type.
6812 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6813 type.
6814 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6815 return type.
6816
6817 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
6818
6819 * NEWS: Mention that the new default MI version is 3. Mention
6820 changes to the output of commands and events that deal with
6821 multi-location breakpoints.
6822 * breakpoint.c: Include "mi/mi-out.h".
6823 (print_one_breakpoint): Change output syntax if using MI version
6824 >= 3.
6825 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6826 New.
6827 (mi_multi_location_breakpoint_output_fixed): New.
6828 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6829 (mi_cmd_fix_multi_location_breakpoint_output): New.
6830 (mi_multi_location_breakpoint_output_fixed): New.
6831 * mi/mi-cmds.c (mi_cmds): Register command
6832 -fix-multi-location-breakpoint-output.
6833 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6834 interpreter "mi".
6835
6836 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
6837
6838 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6839 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6840 instantiate mi_ui_out based on interpreter name.
6841 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6842 * mi/mi-main.c (mi_load_progress): Likewise.
6843
6844 2019-03-12 John Baldwin <jhb@FreeBSD.org>
6845
6846 * NEWS: Combine separate "New targets" sections for 8.3.
6847
6848 2019-03-12 John Baldwin <jhb@FreeBSD.org>
6849
6850 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6851 (ppcfbsd_init_abi): Install gdbarch
6852 "fetch_tls_load_module_address" and "get_thread_local_address"
6853 methods.
6854
6855 2019-03-12 John Baldwin <jhb@FreeBSD.org>
6856
6857 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6858 (riscv_fbsd_init_abi): Install gdbarch
6859 "fetch_tls_load_module_address" and "get_thread_local_address"
6860 methods.
6861
6862 2019-03-12 John Baldwin <jhb@FreeBSD.org>
6863
6864 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6865 (i386fbsd_init_abi): Install gdbarch
6866 "fetch_tls_load_module_address" and "get_thread_local_address"
6867 methods.
6868
6869 2019-03-12 John Baldwin <jhb@FreeBSD.org>
6870
6871 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6872 (amd64fbsd_init_abi): Install gdbarch
6873 "fetch_tls_load_module_address" and "get_thread_local_address"
6874 methods.
6875
6876 2019-03-12 John Baldwin <jhb@FreeBSD.org>
6877
6878 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6879 (struct fbsd_pspace_data): New type.
6880 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6881 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6882 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6883 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6884 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6885
6886 2019-03-12 John Baldwin <jhb@FreeBSD.org>
6887
6888 * gdbtypes.c (lookup_struct_elt): New function.
6889 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6890 * gdbtypes.h (struct struct_elt): New type.
6891 (lookup_struct_elt): New prototype.
6892
6893 2019-03-12 John Baldwin <jhb@FreeBSD.org>
6894
6895 * gdbtypes.c (lookup_struct_elt_type): Update comment and
6896 remove disabled code block.
6897
6898 2019-03-12 John Baldwin <jhb@FreeBSD.org>
6899
6900 * gdbarch.sh (get_thread_local_address): New method.
6901 * gdbarch.h, gdbarch.c: Regenerate.
6902 * target.c (target_translate_tls_address): Use
6903 gdbarch_get_thread_local_address if present instead of
6904 target::get_thread_local_address.
6905
6906 2019-03-12 John Baldwin <jhb@FreeBSD.org>
6907
6908 * target.h (target::get_thread_local_address): Update comment.
6909
6910 2019-03-12 John Baldwin <jhb@FreeBSD.org>
6911
6912 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6913 objfile->separate_debug_objfile_backlink if not NULL.
6914
6915 2019-03-12 John Baldwin <jhb@FreeBSD.org>
6916
6917 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6918 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6919 (amd64bsd_store_inferior_registers): Likewise.
6920 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6921 Enable segment base registers.
6922 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6923 PT_GETFSBASE and PT_GETGSBASE.
6924 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6925 PT_SETGSBASE.
6926 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6927 segment base registers.
6928 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6929
6930 2019-03-12 John Baldwin <jhb@FreeBSD.org>
6931
6932 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6933 Update calls to i386_target_description to add 'segments'
6934 parameter.
6935 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
6936 add segment base registers.
6937 * arch/i386.c (i386_create_target_description): Add 'segments'
6938 parameter to enable segment base registers.
6939 * arch/i386.h (i386_create_target_description): Likewise.
6940 * features/i386/32bit-segments.xml: New file.
6941 * features/i386/32bit-segments.c: Generate.
6942 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6943 call to i386_target_description to add 'segments' parameter.
6944 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6945 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6946 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6947 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6948 if feature is present.
6949 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6950 Add 'segments' parameter to call to i386_target_description.
6951 (i386_target_description): Add 'segments' parameter to enable
6952 segment base registers.
6953 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6954 to call to i386_target_description.
6955 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6956 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6957 Define I386_NUM_REGS.
6958 (i386_target_description): Add 'segments' parameter to enable
6959 segment base registers.
6960
6961 2019-03-12 Eli Zaretskii <eliz@gnu.org>
6962
6963 PR/24325
6964 * source-cache.c: #undef open and close, to avoid unresolved
6965 externals during linking.
6966
6967 2019-03-12 Tom Tromey <tromey@adacore.com>
6968
6969 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6970 const. Add initializers.
6971 (_initialize_remote): Don't initialize ptid globals.
6972
6973 2019-03-12 Pedro Alves <palves@redhat.com>
6974
6975 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6976
6977 2019-03-12 Pedro Alves <palves@redhat.com>
6978
6979 * cp-name-parser.y (main): Remove unused 'len' variable.
6980
6981 2019-03-12 Tom Tromey <tromey@adacore.com>
6982
6983 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6984 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6985
6986 2019-03-12 Tom Tromey <tromey@adacore.com>
6987
6988 * linux-nat.c (iterate_over_lwps): Update.
6989 (stop_callback): Remove parameter.
6990 (stop_wait_callback, detach_callback, resume_set_callback)
6991 (select_singlestep_lwp_callback, set_ignore_sigint)
6992 (status_callback, resumed_callback, resume_clear_callback)
6993 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6994 data parameter.
6995 (linux_nat_target::detach, linux_nat_target::resume)
6996 (linux_stop_and_wait_all_lwps, select_event_lwp)
6997 (linux_nat_filter_event, linux_nat_wait_1)
6998 (linux_nat_target::kill, linux_nat_target::stop)
6999 (linux_nat_target::stop): Update.
7000 (linux_nat_resume_callback): Change type.
7001 (resume_stopped_resumed_lwps, count_events_callback)
7002 (select_event_lwp_callback): Likewise.
7003 (linux_stop_lwp, linux_nat_stop_lwp): Update.
7004 * arm-linux-nat.c (struct update_registers_data): Remove.
7005 (update_registers_callback): Change type.
7006 (arm_linux_insert_hw_breakpoint1): Update.
7007 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7008 parameter.
7009 (x86_linux_dr_set_addr): Update.
7010 (x86_linux_dr_set_control): Update.
7011 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7012 (iterate_over_lwps): Use gdb::function_view.
7013 * nat/aarch64-linux-hw-point.c (struct
7014 aarch64_dr_update_callback_param): Remove.
7015 (debug_reg_change_callback): Change type.
7016 (aarch64_notify_debug_reg_change): Update.
7017 * s390-linux-nat.c (s390_refresh_per_info): Update.
7018
7019 2019-03-11 Tom Tromey <tromey@adacore.com>
7020
7021 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7022 redundant assignment to "this_cu".
7023
7024 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7025
7026 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7027
7028 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7029
7030 * gdbtypes.c (rank_one_type_parm_set): New function extracted
7031 from...
7032 (rank_one_type): ... this.
7033
7034 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7035
7036 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7037 from...
7038 (rank_one_type): ... this.
7039
7040 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7041
7042 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7043 from...
7044 (rank_one_type): ... this.
7045
7046 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7047
7048 * gdbtypes.c (rank_one_type_parm_float): New function extracted
7049 from...
7050 (rank_one_type): ... this.
7051
7052 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7053
7054 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7055 from...
7056 (rank_one_type): ... this.
7057
7058 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7059
7060 * gdbtypes.c (rank_one_type_parm_range): New function extracted
7061 from...
7062 (rank_one_type): ... this.
7063
7064 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7065
7066 * gdbtypes.c (rank_one_type_parm_char): New function extracted
7067 from...
7068 (rank_one_type): ... this.
7069
7070 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7071
7072 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7073 from...
7074 (rank_one_type): ... this.
7075
7076 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7077
7078 * gdbtypes.c (rank_one_type_parm_int): New function extracted
7079 from...
7080 (rank_one_type): ... this.
7081
7082 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7083
7084 * gdbtypes.c (rank_one_type_parm_func): New function extracted
7085 from...
7086 (rank_one_type): ... this.
7087
7088 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7089
7090 * gdbtypes.c (rank_one_type_parm_array): New function extracted
7091 from...
7092 (rank_one_type): ... this.
7093
7094 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7095
7096 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7097 from...
7098 (rank_one_type): ... this.
7099
7100 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7101
7102 * inferior.c (initialize_inferiors): Ensure 'help set/show print
7103 inferior-events' shows the example events.
7104
7105 2019-03-08 Eli Zaretskii <eliz@gnu.org>
7106
7107 Support styling on native MS-Windows console
7108
7109 PR/24315
7110 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7111 on MS-Windows if $TERM is not defined.
7112
7113 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7114
7115 * posix-hdep.c (gdb_console_fputs):
7116 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7117 functions.
7118 * ui-file.h (gdb_console_fputs): Add prototype.
7119
7120 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7121 back to fputs only if the former returns zero.
7122
7123 2019-03-07 Tom Tromey <tom@tromey.com>
7124
7125 * symmisc.c (print_symbol_bcache_statistics): Update.
7126 (print_objfile_statistics): Update.
7127 * symfile.c (allocate_symtab): Update.
7128 * stabsread.c: Don't include bcache.h.
7129 * psymtab.h (struct psymbol_bcache): Don't declare.
7130 (class psymtab_storage) <psymbol_cache>: Now a bcache.
7131 (psymbol_bcache_init, psymbol_bcache_free)
7132 (psymbol_bcache_get_bcache): Don't declare.
7133 * psymtab.c (struct psymbol_bcache): Remove.
7134 (psymtab_storage::psymtab_storage): Update.
7135 (psymtab_storage::~psymtab_storage): Update.
7136 (psymbol_bcache_init, psymbol_bcache_free)
7137 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7138 (add_psymbol_to_bcache): Update.
7139 (allocate_psymtab): Update.
7140 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7141 macro_cache>: No longer pointers.
7142 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7143 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7144 * macrotab.c (macro_bcache): Update.
7145 * macroexp.c: Don't include bcache.h.
7146 * gdbtypes.c (check_types_worklist): Update.
7147 (types_deeply_equal): Remove TRY/CATCH. Update.
7148 * elfread.c (elf_symtab_read): Update.
7149 * dwarf2read.c: Don't include bcache.h.
7150 * buildsym.c (buildsym_compunit::get_macro_table): Update.
7151 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7152 (print_bcache_statistics, bcache_memory_used): Don't declare.
7153 (struct bcache): Move from bcache.c. Add constructor, destructor,
7154 methods. Rename all data members.
7155 * bcache.c (struct bcache): Move to bcache.h.
7156 (bcache::expand_hash_table): Rename from expand_hash_table.
7157 (bcache): Remove.
7158 (bcache::insert): Rename from bcache_full.
7159 (bcache::compare): Rename from bcache_compare.
7160 (bcache_xmalloc): Remove.
7161 (bcache::~bcache): Rename from bcache_xfree.
7162 (bcache::print_statistics): Rename from print_bcache_statistics.
7163 (bcache::memory_used): Rename from bcache_memory_used.
7164
7165 2019-03-07 Pedro Alves <palves@redhat.com>
7166
7167 * infrun.c (normal_stop): Also check for
7168 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7169
7170 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
7171
7172 * f-lang.c (value_from_host_double): Moved to...
7173 * value.c (value_from_host_double): ...here.
7174 * value.h (value_from_host_double): Declare.
7175 * guile/scm-math.c (vlscm_convert_typed_number): Use
7176 value_from_host_double.
7177 (vlscm_convert_number): Likewise.
7178 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7179 * python/py-value.c (convert_value_from_python): Likewise.
7180
7181 2019-03-06 Tom Tromey <tom@tromey.com>
7182
7183 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7184
7185 2019-03-06 Tom Tromey <tom@tromey.com>
7186
7187 * utils.h (free_current_contents): Don't declare.
7188 * utils.c (free_current_contents): Remove.
7189
7190 2019-03-06 Tom Tromey <tom@tromey.com>
7191
7192 * top.c (quit_force): Update.
7193 * main.c (captured_command_loop): Update.
7194 * common/new-op.c (operator new): Update.
7195 * common/common-exceptions.c (struct catcher)
7196 <save_cleanup_chain>: Remove member.
7197 (exceptions_state_mc_init): Update.
7198 (exception_try_scope_entry): Return nullptr.
7199 (exception_try_scope_exit, exception_rethrow)
7200 (throw_exception_sjlj, throw_exception_cxx): Update.
7201 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7202 (all_cleanups, do_cleanups, discard_cleanups)
7203 (discard_final_cleanups, save_cleanups, save_final_cleanups)
7204 (restore_cleanups, restore_final_cleanups): Don't declare.
7205 (do_final_cleanups): Remove parameter.
7206 * common/cleanups.c (cleanup_chain, make_cleanup)
7207 (make_cleanup_dtor, all_cleanups, do_cleanups)
7208 (discard_my_cleanups, discard_cleanups)
7209 (discard_final_cleanups, save_my_cleanups, save_cleanups)
7210 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7211 (null_cleanup): Remove.
7212 (do_final_cleanups): Remove parameter.
7213
7214 2019-03-06 Tom Tromey <tom@tromey.com>
7215
7216 * remote.c (remote_target::remote_parse_stop_reply): Use
7217 unique_xmalloc_ptr.
7218
7219 2019-03-06 Tom Tromey <tom@tromey.com>
7220
7221 * stabsread.c (struct stabs_field_info): Rename from field_info.
7222 <list, fnlist>: Add initializers.
7223 <obstack>: New member.
7224 (read_member_functions, read_struct_fields, read_baseclasses):
7225 Allocate on obstack. Don't use cleanups.
7226 (read_one_struct_field, read_member_functions, read_struct_fields)
7227 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7228 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7229 (read_struct_type): Update.
7230
7231 2019-03-06 Tom Tromey <tom@tromey.com>
7232
7233 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7234 * common/filestuff.h (make_cleanup_close): Don't declare.
7235 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7236 Remove.
7237
7238 2019-03-06 Tom Tromey <tom@tromey.com>
7239
7240 * solib-aix.c: Use make_scope_exit.
7241
7242 2019-03-06 Tom Tromey <tom@tromey.com>
7243
7244 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7245 Use make_scope_exit.
7246
7247 2019-03-06 Tom Tromey <tom@tromey.com>
7248
7249 * solib-svr4.c (disable_probes_interface): Remove parameter.
7250 (svr4_handle_solib_event): Use make_scope_exit.
7251
7252 2019-03-06 Tom Tromey <tom@tromey.com>
7253
7254 * remote.c (struct stop_reply_deleter): Remove.
7255 (stop_reply_up): Update.
7256 (struct stop_reply): Derive from notif_event. Don't typedef.
7257 <regcache>: Now a std::vector.
7258 (stop_reply_xfree): Remove.
7259 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7260 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
7261 (remote_target::discard_pending_stop_replies): Use delete.
7262 (remote_target::remote_parse_stop_reply): Update.
7263 (remote_target::process_stop_reply): Update.
7264 * remote-notif.h (struct notif_event): Add virtual destructor.
7265 Remove "dtr" member.
7266 (struct notif_client) <alloc_event>: Return a unique_ptr.
7267 (notif_event_xfree): Don't declare.
7268 (notif_event_up): New typedef.
7269 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7270 (notif_event_xfree, do_notif_event_xfree): Remove.
7271 (remote_notif_state_xfree): Update.
7272
7273 2019-03-06 Tom Tromey <tom@tromey.com>
7274
7275 * infrun.c (displaced_step_clear_cleanup): Now a
7276 forward_scope_exit type.
7277 (displaced_step_prepare_throw): Update.
7278 (displaced_step_fixup): Update.
7279
7280 2019-03-06 Tom Tromey <tom@tromey.com>
7281
7282 * inferior.h (class inferior): Update comment.
7283 * gdbthread.h (class thread_info): Update comment.
7284
7285 2019-03-06 Joel Brobecker <brobecker@adacore.com>
7286 Tom Tromey <tom@tromey.com>
7287
7288 * stabsread.h (struct stab_section_list): Remove.
7289 (coffstab_build_psymtabs): Update.
7290 * dbxread.c (symbuf_sections): Now a std::vector.
7291 (sect_idx): New global.
7292 (fill_symbuf): Update.
7293 (coffstab_build_psymtabs): Change type of stabsects parameter.
7294 Update.
7295 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7296 std::vector.
7297 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7298 (coff_locate_sections): Update.
7299 (coff_symfile_read): Remove cleanups. Update.
7300 (init_stringtab): Add storage parameter.
7301 (free_stringtab, free_stringtab_cleanup): Remove.
7302 (init_lineno): Add storage parameter.
7303 (free_linetab, free_linetab_cleanup): Remove.
7304
7305 2019-03-06 Pedro Alves <palves@redhat.com>
7306
7307 * linux-fork.c (fork_info::clobber_regs): Delete.
7308 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7309 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
7310 comment. Adjust.
7311 (scoped_switch_fork_info::scoped_switch_fork_info)
7312 (checkpoint_command, linux_fork_context): Adjust
7313 fork_save_infrun_state calls.
7314
7315 2019-03-06 Pedro Alves <palves@redhat.com>
7316
7317 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7318 (inf_has_multiple_threads): Return 'bool' and rewrite using
7319 inferior_info::threads().
7320
7321 2019-03-06 Pedro Alves <palves@redhat.com>
7322
7323 * linux-fork.c: Include <list>.
7324 (fork_list): Now a std::list instance.
7325 (fork_info): Add ctor, dtor, and in-class initialize all fields.
7326 (forks_exist_p, find_last_fork): Adjust.
7327 (new_fork): Delete.
7328 (one_fork_p): New.
7329 (add_fork): Adjust.
7330 (free_fork): Delete, folded into fork_info::~fork_info().
7331 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7332 Adjust.
7333 (init_fork_list): Delete.
7334 (linux_fork_killall, linux_fork_mourn_inferior)
7335 (linux_fork_detach, info_checkpoints_command): Adjust.
7336 (_initialize_linux_fork): No longer call init_fork_list.
7337
7338 2019-03-06 Pedro Alves <palves@redhat.com>
7339
7340 * linux-fork.c (new_fork): New, split out of ...
7341 (add_fork): ... this. Return void. Move "first fork" special
7342 case from here, to ...
7343 (checkpoint_command): ... here.
7344 * linux-linux.h (add_fork): Return void.
7345
7346 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
7347
7348 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7349
7350 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
7351 Chris January <chris.january@arm.com>
7352 David Lecomber <david.lecomber@arm.com>
7353
7354 * f-exp.y: New token, UNOP_INTRINSIC.
7355 (exp): New pattern using UNOP_INTRINSIC token.
7356 (f77_keywords): Add 'abs' keyword.
7357 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7358 (value_from_host_double): New function.
7359 (evaluate_subexp_f): Support UNOP_ABS.
7360
7361 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
7362
7363 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7364 types.
7365
7366 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
7367
7368 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7369 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7370 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7371
7372 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
7373
7374 * f-exp.y (convert_to_kind_type): Handle more type kinds.
7375
7376 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
7377 Chris January <chris.january@arm.com>
7378
7379 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7380 * f-exp.y: Define 'KIND' token.
7381 (exp): New pattern for KIND expressions.
7382 (ptype): Handle types with a kind extension.
7383 (direct_abs_decl): Extend to spot kind extensions.
7384 (f77_keywords): Add 'kind' to the list.
7385 (push_kind_type): New function.
7386 (convert_to_kind_type): New function.
7387 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7388 * parse.c (operator_length_standard): Likewise.
7389 * parser-defs.h (enum type_pieces): Add tp_kind.
7390 * std-operator.def: Add UNOP_KIND.
7391
7392 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
7393
7394 * f-exp.y (f_parse): Set yydebug.
7395
7396 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
7397
7398 * f-lang.c (evaluate_subexp_f): New function.
7399 (exp_descriptor_f): New global.
7400 (f_language_defn): Use exp_descriptor_f instead of
7401 exp_descriptor_standard.
7402
7403 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
7404
7405 * f-exp.y (struct token): Add comments.
7406 (dot_ops): Remove uppercase versions and the end marker.
7407 (f77_keywords): Likewise.
7408 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7409 entries in the dot_ops array are case insensitive, and use
7410 strncasecmp to compare strings. Also some whitespace cleanup in
7411 this area. Similar for the f77_keywords array, except entries in
7412 this list might be case sensitive.
7413
7414 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
7415
7416 * f-exp.y (struct f77_boolean_val): Add comments.
7417 (boolean_values): Remove uppercase versions, and end marker.
7418 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7419 and use strncasecmp to achieve case insensitivity. Additionally,
7420 perform whitespace cleanup around this code.
7421
7422 2019-03-06 Tom Tromey <tromey@adacore.com>
7423
7424 * remote-sim.c (gdbsim_target_open): Use result of
7425 gdb_argv::release.
7426
7427 2019-03-06 Richard Bunt <richard.bunt@arm.com>
7428 Dirk Schubert <dirk.schubert@arm.com>
7429 Chris January <chris.january@arm.com>
7430
7431 * eval.c (evaluate_subexp_standard): Call Fortran argument
7432 wrapping logic.
7433 * f-lang.c (struct value): A value which can be passed into a
7434 Fortran function call.
7435 (fortran_argument_convert): Wrap Fortran arguments in a pointer
7436 where appropriate.
7437 (struct type): Value ready for a Fortran function call.
7438 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7439 is needed.
7440 * f-lang.h (fortran_argument_convert): Declaration.
7441 (fortran_preserve_arg_pointer): Declaration.
7442 * infcall.c (value_arg_coerce): Call Fortran argument logic.
7443
7444 2019-03-05 Tom Tromey <tromey@adacore.com>
7445
7446 * python/py-prettyprint.c (print_string_repr): Remove #if.
7447 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7448
7449 2019-03-05 Tom Tromey <tromey@adacore.com>
7450
7451 * target.c (the_dummy_target): Move later. Change type to
7452 "dummy_target".
7453 (initialize_targets): Don't initialize the_dummy_target.
7454
7455 2019-03-05 Tom Tromey <tromey@adacore.com>
7456
7457 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7458 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7459
7460 2019-03-05 Tom Tromey <tromey@adacore.com>
7461
7462 * windows-nat.c (windows_nat_target::attach)
7463 (windows_nat_target::detach): Don't call gdb_flush.
7464 * valprint.c (generic_val_print, val_print, val_print_string):
7465 Don't call gdb_flush.
7466 * utils.c (defaulted_query): Don't call gdb_flush.
7467 * typeprint.c (print_type_scalar): Don't call gdb_flush.
7468 * target.c (target_announce_detach): Don't call gdb_flush.
7469 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7470 * remote.c (extended_remote_target::attach): Don't call
7471 gdb_flush.
7472 * procfs.c (procfs_target::detach): Don't call gdb_flush.
7473 * printcmd.c (do_examine): Don't call gdb_flush.
7474 (info_display_command): Don't call gdb_flush.
7475 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7476 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7477 * memattr.c (info_mem_command): Don't call gdb_flush.
7478 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7479 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7480 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7481 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7482 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7483 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7484 (gnu_nat_target::detach): Don't call gdb_flush.
7485 * f-valprint.c (f_val_print): Don't call gdb_flush.
7486 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7487 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7488 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7489 gdb_flush.
7490 * c-valprint.c (c_val_print): Don't call gdb_flush.
7491 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7492
7493 2019-03-05 Tom Tromey <tromey@adacore.com>
7494
7495 * varobj.c (update_dynamic_varobj_children): Update.
7496 (install_default_visualizer): Use reset, not release.
7497 * value.c (set_internalvar): Update.
7498 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7499 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7500 ATTRIBUTE_UNUSED_RESULT.
7501
7502 2019-03-05 Tom Tromey <tromey@adacore.com>
7503
7504 * remote.c (class scoped_remote_fd) <release>: Add
7505 ATTRIBUTE_UNUSED_RESULT.
7506
7507 2019-03-05 Tom Tromey <tromey@adacore.com>
7508
7509 * macroexp.c (struct macro_buffer) <release>: Add
7510 ATTRIBUTE_UNUSED_RESULT.
7511
7512 2019-03-05 Tom Tromey <tromey@adacore.com>
7513
7514 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7515 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7516 ATTRIBUTE_UNUSED_RESULT.
7517
7518 2019-03-05 Tom Tromey <tromey@adacore.com>
7519
7520 * common/scoped_fd.h (class scoped_fd) <release>: Add
7521 ATTRIBUTE_UNUSED_RESULT.
7522
7523 2019-03-05 Tom Tromey <tromey@adacore.com>
7524
7525 * parser-defs.h (struct parser_state) <release>: Add
7526 ATTRIBUTE_UNUSED_RESULT.
7527
7528 2019-03-05 Tom Tromey <tromey@adacore.com>
7529
7530 * utils.h (class gdb_argv) <release>: Add
7531 ATTRIBUTE_UNUSED_RESULT.
7532 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7533
7534 2019-03-02 Eli Zaretskii <eliz@gnu.org>
7535
7536 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7537 for-loop range, to avoid compiler warnings.
7538
7539 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7540 avoid compiler warnings about unused variables.
7541
7542 * NEWS: Mention end of support for native debugging on MS-Windows
7543 before XP.
7544
7545 PR gdb/24292
7546 * common/netstuff.c:
7547 * gdbserver/gdbreplay.c
7548 * gdbserver/remote-utils.c:
7549 * ser-tcp.c:
7550 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7551 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
7552 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7553 'getaddrinfo' and 'freeaddrinfo' were not available before
7554 Windows XP, and mingw.org's MinGW headers by default define
7555 _WIN32_WINNT to 0x500.
7556
7557 2019-03-01 Gary Benson <gbenson@redhat.com>
7558
7559 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7560
7561 2019-02-28 Brian Vandenberg <phantall@gmail.com>
7562 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
7563
7564 PR gdb/8527
7565 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7566 set_sigint_trap, clear_sigint_trap.
7567
7568 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7569
7570 * target.c (target_detach): Clear the regcache and the
7571 frame cache.
7572
7573 2019-02-27 Pedro Alves <palves@redhat.com>
7574
7575 * utils.c (set_screen_size): When we cap the height/width sizes,
7576 tweak the corresponding command variable to show "unlimited":
7577
7578 2019-02-27 Saagar Jha <saagar@saagarjha.com>
7579 Pedro Alves <palves@redhat.com>
7580
7581 * utils.c (set_screen_size): Reduce "infinite" rows and columns
7582 before calling rl_set_screen_size.
7583
7584 2019-02-27 Tom Tromey <tromey@adacore.com>
7585
7586 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7587 define.
7588 * python/py-value.c: Remove Python 2.4 workaround.
7589 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7590 workaround.
7591 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7592 Python 2.4 workaround.
7593 * python/python-internal.h: Remove Python 2.4 comment.
7594 (Py_ssize_t): Don't define.
7595 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7596 (gdb_Py_DECREF): Remove Python 2.4 workaround.
7597 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7598 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7599 * python/python.c (do_start_initialization): Remove Python 2.4
7600 workaround.
7601 * python/py-prettyprint.c (class dummy_python_frame): Remove.
7602 (print_children): Remove Python 2.4 workaround.
7603 * python/py-inferior.c (buffer_procs): Remove Python 2.4
7604 workaround.
7605 (CHARBUFFERPROC_NAME): Remove.
7606 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7607 Python 2.4 workaround.
7608
7609 2019-02-27 Kevin Buettner <kevinb@redhat.com>
7610
7611 * NEWS: Note minimum Python version.
7612
7613 2019-02-27 Kevin Buettner <kevinb@redhat.com>
7614
7615 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7616 code from these functions. Remove corresponding ifdefs. Use
7617 Py_buffer_up instead of explicit calls to PyBuffer_Release.
7618 Remove gotos and target of gotos.
7619 (infpy_search_memory): Likewise.
7620
7621 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
7622
7623 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7624 (hppa_gdbarch_init): Don't register deleted functions with
7625 gdbarch.
7626
7627 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
7628
7629 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7630 (h8300_unwind_sp): Delete.
7631 (h8300_dummy_id): Delete.
7632 (h8300_gdbarch_init): Don't register deleted functions with
7633 gdbarch.
7634
7635 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
7636
7637 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7638 (ft32_unwind_pc): Delete.
7639 (ft32_unwind_sp): Delete.
7640 (ft32_gdbarch_init): Don't register deleted functions with
7641 gdbarch.
7642
7643 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
7644
7645 * gdb/frv-tdep.c (frv_dummy_id): Delete.
7646 (frv_unwind_pc): Delete.
7647 (frv_unwind_sp): Delete.
7648 (frv_gdbarch_init): Don't register deleted functions with
7649 gdbarch.
7650
7651 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
7652
7653 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7654 (riscv_unwind_pc): Delete.
7655 (riscv_unwind_sp): Delete.
7656 (riscv_gdbarch_init): Don't register deleted functions with
7657 gdbarch.
7658
7659 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
7660
7661 * gdb/csky-tdep.c (csky_dummy_id): Delete.
7662 (csky_unwind_pc): Delete.
7663 (csky_unwind_sp): Delete.
7664 (csky_gdbarch_init): Don't register deleted functions with
7665 gdbarch.
7666
7667 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
7668
7669 * gdb/cris-tdep.c (cris_dummy_id): Delete.
7670 (cris_unwind_pc): Delete.
7671 (cris_unwind_sp): Delete.
7672 (cris_gdbarch_init): Don't register deleted functions with
7673 gdbarch.
7674
7675 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
7676
7677 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7678 (bfin_unwind_pc): Delete.
7679 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7680
7681 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
7682
7683 * gdb/arm-tdep.c (arm_dummy_id): Delete.
7684 (arm_unwind_pc): Delete.
7685 (arm_unwind_sp): Delete.
7686 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7687
7688 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
7689
7690 * gdb/arc-tdep.c (arc_dummy_id): Delete.
7691 (arc_unwind_pc): Delete.
7692 (arc_unwind_sp): Delete.
7693 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7694
7695 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
7696
7697 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7698 (alpha_unwind_pc): Delete.
7699 (alpha_gdbarch_init): Don't register deleted functions with
7700 gdbarch.
7701
7702 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
7703
7704 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7705 (aarch64_unwind_pc): Delete.
7706 (aarch64_unwind_sp): Delete.
7707 (aarch64_gdbarch_init): Don't register deleted functions with
7708 gdbarch.
7709
7710 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
7711
7712 * gdbtypes.c (type_align): Don't consider static members when
7713 computing structure alignment.
7714
7715 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
7716
7717 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7718 return 0 for other types.
7719 * arch-utils.c (default_type_align): Always return 0.
7720 * gdbarch.h: Regenerate.
7721 * gdbarch.sh (type_align): Extend comment.
7722 * gdbtypes.c (type_align): Add additional comments, always call
7723 gdbarch_type_align before applying the default rules.
7724 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7725 generic code will then apply a suitable default.
7726 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7727 types, return 0 for other types.
7728
7729 2019-02-27 Joel Brobecker <brobecker@adacore.com>
7730
7731 * NEWS: Create a new section for the next release branch.
7732 Rename the section of the current branch, now that it has
7733 been cut.
7734
7735 2019-02-27 Joel Brobecker <brobecker@adacore.com>
7736
7737 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7738 * version.in: Bump version to 8.3.50.DATE-git.
7739
7740 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
7741
7742 * aix-thread.c (ptid_cmp): Remove unused variable.
7743 (get_signaled_thread): Likewise.
7744 (store_regs_user_thread): Likewise.
7745 (store_regs_kernel_thread): Likewise.
7746 (fetch_regs_kernel_thread): Remove shadowed variable.
7747
7748 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
7749
7750 * features/riscv/32bit-cpu.xml: Add register numbers.
7751 * features/riscv/32bit-fpu.c: Regenerate.
7752 * features/riscv/32bit-fpu.xml: Add register numbers.
7753 * features/riscv/64bit-cpu.xml: Add register numbers.
7754 * features/riscv/64bit-fpu.c: Regenerate.
7755 * features/riscv/64bit-fpu.xml: Add register numbers.
7756
7757 2019-02-26 Kevin Buettner <kevinb@redhat.com>
7758
7759 * NEWS: Mention two argument form of gdb.Value constructor.
7760 * python/py-value.c (convert_buffer_and_type_to_value): New
7761 function.
7762 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7763 Add support for handling an optional second argument. Call
7764 convert_buffer_and_type_to_value as appropriate.
7765 * python/python-internal.h (Py_buffer_deleter): New struct.
7766 (Py_buffer_up): New typedef.
7767
7768 2019-02-25 John Baldwin <jhb@FreeBSD.org>
7769
7770 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7771 instead of releasing ownership.
7772
7773 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
7774
7775 * dwarf2read.c (open_and_init_dwp_file): Call
7776 elf_numsections instead of bfd_count_sections to initialize
7777 dwp_file->num_sections.
7778
7779 2019-02-25 Tom Tromey <tromey@adacore.com>
7780
7781 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7782
7783 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
7784
7785 * gcore.in: Add '--readnever' option when invoking GDB.
7786
7787 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
7788
7789 * MAINTAINERS: Update my email address.
7790
7791 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
7792
7793 * build-id.c (build_id_to_debug_bfd_1): New function.
7794 (build_id_to_debug_bfd): Look for separate debug file in
7795 sysroot.
7796
7797 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
7798
7799 * gdbarch.sh: Update the copyright year range that is placed into
7800 generated files.
7801
7802 2019-02-22 Keith Seitz <keiths@redhat.com>
7803
7804 PR symtab/23853
7805 * linespec.c (create_sals_line_offset): Search for the default
7806 symtab's filename instead of its fullname.
7807
7808 2019-02-21 Alan Hayward <alan.hayward@arm.com>
7809
7810 * NEWS: Update style defaults.
7811
7812 2019-02-21 Alan Hayward <alan.hayward@arm.com>
7813
7814 * main.c (captured_main_1): Disable styling in batch mode.
7815
7816 2019-02-20 Tom Tromey <tom@tromey.com>
7817
7818 * symtab.c (symtab_symbol_info): Fix typos.
7819
7820 2019-02-20 Tom Tromey <tromey@adacore.com>
7821
7822 * findcmd.c (_initialize_mem_search): Use upper case for
7823 metasyntactic variables.
7824
7825 2019-02-20 Alan Hayward <alan.hayward@arm.com>
7826
7827 * aarch64-tdep.c (aarch64_add_reggroups): New function.
7828 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7829
7830 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
7831
7832 * top.h (source_file_name): Change to std::string.
7833 * top.c (source_file_name): Likewise.
7834 (command_line_input): Adjust.
7835 * cli/cli-script.c (script_from_file): Adjust.
7836
7837 2019-02-19 Tom Tromey <tromey@adacore.com>
7838
7839 * ravenscar-thread.c
7840 (ravenscar_thread_target::update_thread_list): Don't call
7841 ada_build_task_list.
7842 * ada-lang.h (ada_build_task_list): Don't declare.
7843 * ada-tasks.c (struct ada_tasks_inferior_data)
7844 <task_list_valid_p>: Now bool.
7845 (read_known_tasks, ada_task_list_changed)
7846 (ada_tasks_invalidate_inferior_data): Update.
7847 (read_known_tasks_array): Return bool.
7848 (read_known_tasks_list): Likewise.
7849 (read_known_tasks): Return void.
7850 (ada_build_task_list): Now static.
7851
7852 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
7853
7854 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7855 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7856
7857 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7858
7859 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7860 variant for ada_tasks_pspace_data_handle and
7861 ada_tasks_inferior_data_handle.
7862 (ada_tasks_pspace_data_cleanup): New function.
7863 (ada_tasks_inferior_data_cleanup): New function.
7864
7865 2019-02-17 Tom Tromey <tom@tromey.com>
7866
7867 * macrotab.h (macro_source_fullname): Return a std::string.
7868 * macrotab.c (macro_include, check_for_redefinition)
7869 (macro_undef, macro_lookup_definition, foreach_macro)
7870 (foreach_macro_in_scope): Update.
7871 (macro_source_fullname): Return a std::string.
7872 * macrocmd.c (show_pp_source_pos): Update.
7873
7874 2019-02-17 Tom Tromey <tom@tromey.com>
7875
7876 * macrocmd.c (show_pp_source_pos): Style the file names.
7877
7878 2019-02-17 Tom Tromey <tom@tromey.com>
7879
7880 PR tui/24197:
7881 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7882
7883 2019-02-17 Tom Tromey <tom@tromey.com>
7884
7885 * ada-lang.c (user_select_syms): Use filtered printing.
7886 * utils.c (wrap_style): New global.
7887 (desired_style): Remove.
7888 (emit_style_escape): Add stream parameter.
7889 (set_output_style, reset_terminal_style, prompt_for_continue):
7890 Update.
7891 (flush_wrap_buffer): Only flush gdb_stdout.
7892 (wrap_here): Set wrap_style.
7893 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
7894 treat escape sequences as a character. Change when wrap buffer is
7895 flushed.
7896 (fputs_styled): Do not set the output style when the default is
7897 requested.
7898 * ui-style.h (struct ui_file_style) <is_default>: New method.
7899 * source.c (print_source_lines_base): Emit escape sequences in one
7900 piece.
7901
7902 2019-02-17 Joel Brobecker <brobecker@adacore.com>
7903
7904 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7905 integers and enumeration types.
7906
7907 2019-02-17 Joel Brobecker <brobecker@adacore.com>
7908
7909 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7910 instead of lookup_symbol_in_language
7911 (do_exact_match): New function.
7912 (ada_get_symbol_name_matcher): Return do_exact_match when
7913 doing a verbatim match.
7914
7915 2019-02-15 Tom Tromey <tromey@adacore.com>
7916
7917 * ravenscar-thread.c (ravenscar_thread_target::resume)
7918 (ravenscar_thread_target::wait): Special case wildcard requests.
7919
7920 2019-02-15 Tom Tromey <tromey@adacore.com>
7921
7922 * ravenscar-thread.c (base_ptid): Remove.
7923 (struct ravenscar_thread_target) <close>: New method.
7924 <m_base_ptid>: New member.
7925 <update_inferior_ptid, active_task, task_is_currently_active,
7926 runtime_initialized>: Declare methods.
7927 <ravenscar_thread_target>: Add constructor.
7928 (ravenscar_thread_target::task_is_currently_active)
7929 (ravenscar_thread_target::update_inferior_ptid)
7930 (ravenscar_runtime_initialized): Rename. Now methods.
7931 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7932 (ravenscar_thread_target::update_thread_list): Update.
7933 (ravenscar_thread_target::active_task): Now method.
7934 (ravenscar_thread_target::store_registers)
7935 (ravenscar_thread_target::prepare_to_store)
7936 (ravenscar_thread_target::prepare_to_store)
7937 (ravenscar_thread_target::mourn_inferior): Update.
7938 (ravenscar_inferior_created): Use "new" to create target.
7939 (ravenscar_thread_target::get_ada_task_ptid): Update.
7940 (_initialize_ravenscar): Don't initialize base_ptid.
7941 (ravenscar_ops): Remove global.
7942
7943 2019-02-15 Tom Tromey <tromey@adacore.com>
7944
7945 * target.h (push_target): Declare new overload.
7946 * target.c (push_target): New overload, taking an rvalue reference.
7947 * remote.c (remote_target::open_1): Use push_target overload.
7948 * corelow.c (core_target_open): Use push_target overload.
7949
7950 2019-02-15 Tom Tromey <tromey@adacore.com>
7951
7952 * ravenscar-thread.c (is_ravenscar_task)
7953 (ravenscar_task_is_currently_active): Return bool.
7954 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7955 (_initialize_ravenscar): Remove "(void)".
7956 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7957 Return bool.
7958
7959 2019-02-15 Tom Tromey <tromey@adacore.com>
7960
7961 * ravenscar-thread.c (ravenscar_runtime_initializer)
7962 (has_ravenscar_runtime, get_running_thread_id)
7963 (ravenscar_thread_target::resume): Fix indentation.
7964
7965 2019-02-15 Tom Tromey <tromey@adacore.com>
7966
7967 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7968 from ravenscar_arch_ops.
7969 (sparc_ravenscar_ops::fetch_registers)
7970 (sparc_ravenscar_ops::store_registers): Now methods.
7971 (sparc_ravenscar_prepare_to_store): Remove.
7972 (sparc_ravenscar_ops): Redefine.
7973 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7974 methods and destructor. Remove members.
7975 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7976 (ravenscar_thread_target::store_registers)
7977 (ravenscar_thread_target::prepare_to_store): Update.
7978 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7979 Remove.
7980 (struct ppc_ravenscar_powerpc_ops): Derive from
7981 ravenscar_arch_ops.
7982 (ppc_ravenscar_powerpc_ops::fetch_registers)
7983 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7984 (ppc_ravenscar_powerpc_ops): Redefine.
7985 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7986 (ppc_ravenscar_e500_ops::fetch_registers)
7987 (ppc_ravenscar_e500_ops::store_registers): Now methods.
7988 (ppc_ravenscar_e500_ops): Redefine.
7989 * aarch64-ravenscar-thread.c
7990 (aarch64_ravenscar_generic_prepare_to_store): Remove.
7991 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7992 (aarch64_ravenscar_fetch_registers)
7993 (aarch64_ravenscar_store_registers): Now methods.
7994 (aarch64_ravenscar_ops): Redefine.
7995
7996 2019-02-15 Tom Tromey <tromey@adacore.com>
7997
7998 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7999 (ravenscar_thread_target::stopped_by_hw_breakpoint)
8000 (ravenscar_thread_target::stopped_by_watchpoint)
8001 (ravenscar_thread_target::stopped_data_address)
8002 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8003
8004 2019-02-15 Tom Tromey <tromey@adacore.com>
8005
8006 * ravenscar-thread.c: Fix some typos.
8007
8008 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8009 Tom Tromey <tromey@adacore.com>
8010
8011 * ada-lang.c (ada_exception_sal): Change addr_string to a
8012 std::string.
8013 (create_ada_exception_catchpoint): Update.
8014
8015 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8016 Tom Tromey <tromey@adacore.com>
8017
8018 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8019 (bp_location_ops): Remove.
8020 (base_breakpoint_allocate_location): Update.
8021 (free_bp_location): Update.
8022 * ada-lang.c (class ada_catchpoint_location)
8023 <ada_catchpoint_location>: Remove ops parameter.
8024 (ada_catchpoint_location_dtor): Remove.
8025 (ada_catchpoint_location_ops): Remove.
8026 (allocate_location_exception): Update.
8027 * breakpoint.h (struct bp_location_ops): Remove.
8028 (class bp_location) <bp_location>: Remove bp_location_ops
8029 parameter.
8030 <~bp_location>: Add destructor.
8031 <ops>: Remove.
8032
8033 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
8034 Pedro Alves <palves@redhat.com>
8035
8036 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8037 'PATH_MAX'.
8038
8039 2019-02-14 David Michael <fedora.dm0@gmail.com>
8040 Samuel Thibault <samuel.thibault@gnu.org>
8041 Thomas Schwinge <thomas@codesourcery.com>
8042
8043 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8044 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8045
8046 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
8047
8048 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8049 (check_empty): Use "const char *".
8050
8051 * gnu-nat.c (gnu_nat_target::detach): Instead of
8052 'detach_inferior (pid)' call
8053 'detach_inferior (find_inferior_pid (pid))'.
8054
8055 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8056 'nat/fork-inferior.o'.
8057 * gnu-nat.c: #include "nat/fork-inferior.h".
8058
8059 * gnu-nat.c (gnu_nat_target::detach): Instead of
8060 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8061 * gnu-nat.h: #include "inf-child.h".
8062 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8063 'i386_gnu_nat_target::fetch_registers'.
8064 (gnu_store_registers): Rename/move to
8065 'i386_gnu_nat_target::store_registers'.
8066
8067 * config/i386/nm-i386gnu.h: Don't "#include" any files.
8068 * gnu-nat.h (mach_thread_info): New function.
8069 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8070
8071 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8072
8073 2019-02-14 Frederic Konrad <konrad@adacore.com>
8074
8075 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8076
8077 2019-02-14 Joel Brobecker <brobecker@adacore.com>
8078
8079 * windows-nat.c (windows_add_thread): Add new parameter
8080 "main_thread_p" with default value set to false. Update
8081 function documentation as well as all callers.
8082 (windows_delete_thread): Likewise.
8083 (fake_create_process): Update call to windows_add_thread.
8084 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8085 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8086 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8087 call to windows_delete_thread.
8088
8089 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
8090
8091 * MAINTAINERS: Add Andrew Burgess as global maintainer.
8092
8093 2019-02-12 John Baldwin <jhb@FreeBSD.org>
8094
8095 * symfile.c (find_separate_debug_file): Use canonical path of
8096 sysroot with child_path instead of gdb_sysroot if it is valid.
8097
8098 2019-02-12 John Baldwin <jhb@FreeBSD.org>
8099
8100 * symfile.c (find_separate_debug_file): Use child_path to
8101 determine if an object file is under a sysroot.
8102
8103 2019-02-12 John Baldwin <jhb@FreeBSD.org>
8104
8105 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8106 unittests/child-path-selftests.c.
8107 * common/pathstuff.c (child_path): New function.
8108 * common/pathstuff.h (child_path): New prototype.
8109 * unittests/child-path-selftests.c: New file.
8110
8111 2019-02-12 John Baldwin <jhb@FreeBSD.org>
8112
8113 * symfile.c (find_separate_debug_file): Look for separate debug
8114 files in debug directories under the sysroot.
8115
8116 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8117
8118 * symtab.h (struct minimal_symbol data_p): New const method.
8119 (struct minimal_symbol text_p): Likewise.
8120 * symtab.c (output_source_filename): Use file name style
8121 to print file name.
8122 (print_symbol_info): Likewise.
8123 (print_msymbol_info): Use address style to print addresses.
8124 Use function name style to print executable text symbols.
8125 (expand_symtab_containing_pc): Use data_p.
8126 (find_pc_sect_compunit_symtab): Likewise.
8127
8128 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8129
8130 * breakpoint.c (describe_other_breakpoints): Use address style
8131 to print addresses.
8132 (say_where): Likewise.
8133
8134 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8135
8136 * ada-typeprint.c (print_func_type): Print function name
8137 style to print function name.
8138 * c-typeprint.c (c_print_type_1): Likewise.
8139
8140 2019-02-11 Alan Hayward <alan.hayward@arm.com>
8141
8142 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8143 for execve.
8144
8145 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8146
8147 * c-exp.y (direct_abs_decl): Use emplace_back to record the
8148 type_stack.
8149
8150 2019-02-10 Joel Brobecker <brobecker@adacore.com>
8151
8152 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8153 TYPE_CODE_REF types.
8154
8155 2019-02-08 Jim Wilson <jimw@sifive.com>
8156
8157 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8158 (riscv_linux_fregset): New.
8159 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8160
8161 2019-02-07 Tom Tromey <tom@tromey.com>
8162
8163 * thread.c (thread_cancel_execution_command): Update.
8164 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8165 methods.
8166 (struct thread_fsm_ops): Remove.
8167 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8168 (thread_fsm_should_stop, thread_fsm_return_value)
8169 (thread_fsm_set_finished, thread_fsm_finished_p)
8170 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8171 Don't declare.
8172 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8173 * infrun.c (clear_proceed_status_thread)
8174 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8175 (print_stop_event): Update.
8176 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8177 Add constructor.
8178 (step_command_fsm_ops): Remove.
8179 (new_step_command_fsm): Remove.
8180 (step_1): Update.
8181 (step_command_fsm::should_stop): Rename from
8182 step_command_fsm_should_stop.
8183 (step_command_fsm::clean_up): Rename from
8184 step_command_fsm_clean_up.
8185 (step_command_fsm::do_async_reply_reason): Rename from
8186 step_command_fsm_async_reply_reason.
8187 (struct until_next_fsm): Inherit from thread_fsm. Add
8188 constructor.
8189 (until_next_fsm_ops): Remove.
8190 (new_until_next_fsm): Remove.
8191 (until_next_fsm::should_stop): Rename from
8192 until_next_fsm_should_stop.
8193 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8194 (until_next_fsm::do_async_reply_reason): Rename from
8195 until_next_fsm_async_reply_reason.
8196 (struct finish_command_fsm): Inherit from thread_fsm. Add
8197 constructor. Change type of breakpoint.
8198 (finish_command_fsm_ops): Remove.
8199 (new_finish_command_fsm): Remove.
8200 (finish_command_fsm::should_stop): Rename from
8201 finish_command_fsm_should_stop.
8202 (finish_command_fsm::clean_up): Rename from
8203 finish_command_fsm_clean_up.
8204 (finish_command_fsm::return_value): Rename from
8205 finish_command_fsm_return_value.
8206 (finish_command_fsm::do_async_reply_reason): Rename from
8207 finish_command_fsm_async_reply_reason.
8208 (finish_command): Update.
8209 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8210 Add constructor.
8211 (call_thread_fsm_ops): Remove.
8212 (call_thread_fsm::call_thread_fsm): Rename from
8213 new_call_thread_fsm.
8214 (call_thread_fsm::should_stop): Rename from
8215 call_thread_fsm_should_stop.
8216 (call_thread_fsm::should_notify_stop): Rename from
8217 call_thread_fsm_should_notify_stop.
8218 (run_inferior_call, call_function_by_hand_dummy): Update.
8219 * cli/cli-interp.c (should_print_stop_to_console): Update.
8220 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8221 Add constructor. Change type of location_breakpoint,
8222 caller_breakpoint.
8223 (until_break_fsm_ops): Remove.
8224 (new_until_break_fsm): Remove.
8225 (until_break_fsm::should_stop): Rename from
8226 until_break_fsm_should_stop.
8227 (until_break_fsm::clean_up): Rename from
8228 until_break_fsm_clean_up.
8229 (until_break_fsm::do_async_reply_reason): Rename from
8230 until_break_fsm_async_reply_reason.
8231 (until_break_command): Update.
8232 * thread-fsm.c: Remove.
8233 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8234
8235 2019-02-07 Tom Tromey <tom@tromey.com>
8236
8237 * yy-remap.h: Add include guard.
8238 * xtensa-tdep.h: Add include guard.
8239 * xcoffread.h: Rename include guard.
8240 * varobj-iter.h: Add include guard.
8241 * tui/tui.h: Rename include guard.
8242 * tui/tui-winsource.h: Rename include guard.
8243 * tui/tui-wingeneral.h: Rename include guard.
8244 * tui/tui-windata.h: Rename include guard.
8245 * tui/tui-win.h: Rename include guard.
8246 * tui/tui-stack.h: Rename include guard.
8247 * tui/tui-source.h: Rename include guard.
8248 * tui/tui-regs.h: Rename include guard.
8249 * tui/tui-out.h: Rename include guard.
8250 * tui/tui-layout.h: Rename include guard.
8251 * tui/tui-io.h: Rename include guard.
8252 * tui/tui-hooks.h: Rename include guard.
8253 * tui/tui-file.h: Rename include guard.
8254 * tui/tui-disasm.h: Rename include guard.
8255 * tui/tui-data.h: Rename include guard.
8256 * tui/tui-command.h: Rename include guard.
8257 * tic6x-tdep.h: Add include guard.
8258 * target/waitstatus.h: Rename include guard.
8259 * target/wait.h: Rename include guard.
8260 * target/target.h: Rename include guard.
8261 * target/resume.h: Rename include guard.
8262 * target-float.h: Rename include guard.
8263 * stabsread.h: Add include guard.
8264 * rs6000-tdep.h: Add include guard.
8265 * riscv-fbsd-tdep.h: Add include guard.
8266 * regformats/regdef.h: Rename include guard.
8267 * record.h: Rename include guard.
8268 * python/python.h: Rename include guard.
8269 * python/python-internal.h: Rename include guard.
8270 * python/py-stopevent.h: Rename include guard.
8271 * python/py-ref.h: Rename include guard.
8272 * python/py-record.h: Rename include guard.
8273 * python/py-record-full.h: Rename include guard.
8274 * python/py-record-btrace.h: Rename include guard.
8275 * python/py-instruction.h: Rename include guard.
8276 * python/py-events.h: Rename include guard.
8277 * python/py-event.h: Rename include guard.
8278 * procfs.h: Add include guard.
8279 * proc-utils.h: Add include guard.
8280 * p-lang.h: Add include guard.
8281 * or1k-tdep.h: Rename include guard.
8282 * observable.h: Rename include guard.
8283 * nto-tdep.h: Rename include guard.
8284 * nat/x86-linux.h: Rename include guard.
8285 * nat/x86-linux-dregs.h: Rename include guard.
8286 * nat/x86-gcc-cpuid.h: Add include guard.
8287 * nat/x86-dregs.h: Rename include guard.
8288 * nat/x86-cpuid.h: Rename include guard.
8289 * nat/ppc-linux.h: Rename include guard.
8290 * nat/mips-linux-watch.h: Rename include guard.
8291 * nat/linux-waitpid.h: Rename include guard.
8292 * nat/linux-ptrace.h: Rename include guard.
8293 * nat/linux-procfs.h: Rename include guard.
8294 * nat/linux-osdata.h: Rename include guard.
8295 * nat/linux-nat.h: Rename include guard.
8296 * nat/linux-namespaces.h: Rename include guard.
8297 * nat/linux-btrace.h: Rename include guard.
8298 * nat/glibc_thread_db.h: Rename include guard.
8299 * nat/gdb_thread_db.h: Rename include guard.
8300 * nat/gdb_ptrace.h: Rename include guard.
8301 * nat/fork-inferior.h: Rename include guard.
8302 * nat/amd64-linux-siginfo.h: Rename include guard.
8303 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8304 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8305 * nat/aarch64-linux.h: Rename include guard.
8306 * nat/aarch64-linux-hw-point.h: Rename include guard.
8307 * mn10300-tdep.h: Add include guard.
8308 * mips-linux-tdep.h: Add include guard.
8309 * mi/mi-parse.h: Rename include guard.
8310 * mi/mi-out.h: Rename include guard.
8311 * mi/mi-main.h: Rename include guard.
8312 * mi/mi-interp.h: Rename include guard.
8313 * mi/mi-getopt.h: Rename include guard.
8314 * mi/mi-console.h: Rename include guard.
8315 * mi/mi-common.h: Rename include guard.
8316 * mi/mi-cmds.h: Rename include guard.
8317 * mi/mi-cmd-break.h: Rename include guard.
8318 * m2-lang.h: Add include guard.
8319 * location.h: Rename include guard.
8320 * linux-record.h: Rename include guard.
8321 * linux-nat.h: Add include guard.
8322 * linux-fork.h: Add include guard.
8323 * i386-darwin-tdep.h: Rename include guard.
8324 * hppa-linux-offsets.h: Add include guard.
8325 * guile/guile.h: Rename include guard.
8326 * guile/guile-internal.h: Rename include guard.
8327 * gnu-nat.h: Rename include guard.
8328 * gdb-stabs.h: Rename include guard.
8329 * frv-tdep.h: Add include guard.
8330 * f-lang.h: Add include guard.
8331 * event-loop.h: Add include guard.
8332 * darwin-nat.h: Rename include guard.
8333 * cp-abi.h: Rename include guard.
8334 * config/sparc/nm-sol2.h: Rename include guard.
8335 * config/nm-nto.h: Rename include guard.
8336 * config/nm-linux.h: Add include guard.
8337 * config/i386/nm-i386gnu.h: Rename include guard.
8338 * config/djgpp/nl_types.h: Rename include guard.
8339 * config/djgpp/langinfo.h: Rename include guard.
8340 * compile/gcc-cp-plugin.h: Add include guard.
8341 * compile/gcc-c-plugin.h: Add include guard.
8342 * compile/compile.h: Rename include guard.
8343 * compile/compile-object-run.h: Rename include guard.
8344 * compile/compile-object-load.h: Rename include guard.
8345 * compile/compile-internal.h: Rename include guard.
8346 * compile/compile-cplus.h: Rename include guard.
8347 * compile/compile-c.h: Rename include guard.
8348 * common/xml-utils.h: Rename include guard.
8349 * common/x86-xstate.h: Rename include guard.
8350 * common/version.h: Rename include guard.
8351 * common/vec.h: Rename include guard.
8352 * common/tdesc.h: Rename include guard.
8353 * common/selftest.h: Rename include guard.
8354 * common/scoped_restore.h: Rename include guard.
8355 * common/scoped_mmap.h: Rename include guard.
8356 * common/scoped_fd.h: Rename include guard.
8357 * common/safe-iterator.h: Rename include guard.
8358 * common/run-time-clock.h: Rename include guard.
8359 * common/refcounted-object.h: Rename include guard.
8360 * common/queue.h: Rename include guard.
8361 * common/ptid.h: Rename include guard.
8362 * common/print-utils.h: Rename include guard.
8363 * common/preprocessor.h: Rename include guard.
8364 * common/pathstuff.h: Rename include guard.
8365 * common/observable.h: Rename include guard.
8366 * common/netstuff.h: Rename include guard.
8367 * common/job-control.h: Rename include guard.
8368 * common/host-defs.h: Rename include guard.
8369 * common/gdb_wait.h: Rename include guard.
8370 * common/gdb_vecs.h: Rename include guard.
8371 * common/gdb_unlinker.h: Rename include guard.
8372 * common/gdb_unique_ptr.h: Rename include guard.
8373 * common/gdb_tilde_expand.h: Rename include guard.
8374 * common/gdb_sys_time.h: Rename include guard.
8375 * common/gdb_string_view.h: Rename include guard.
8376 * common/gdb_splay_tree.h: Rename include guard.
8377 * common/gdb_setjmp.h: Rename include guard.
8378 * common/gdb_ref_ptr.h: Rename include guard.
8379 * common/gdb_optional.h: Rename include guard.
8380 * common/gdb_locale.h: Rename include guard.
8381 * common/gdb_assert.h: Rename include guard.
8382 * common/filtered-iterator.h: Rename include guard.
8383 * common/filestuff.h: Rename include guard.
8384 * common/fileio.h: Rename include guard.
8385 * common/environ.h: Rename include guard.
8386 * common/common-utils.h: Rename include guard.
8387 * common/common-types.h: Rename include guard.
8388 * common/common-regcache.h: Rename include guard.
8389 * common/common-inferior.h: Rename include guard.
8390 * common/common-gdbthread.h: Rename include guard.
8391 * common/common-exceptions.h: Rename include guard.
8392 * common/common-defs.h: Rename include guard.
8393 * common/common-debug.h: Rename include guard.
8394 * common/cleanups.h: Rename include guard.
8395 * common/buffer.h: Rename include guard.
8396 * common/btrace-common.h: Rename include guard.
8397 * common/break-common.h: Rename include guard.
8398 * cli/cli-utils.h: Rename include guard.
8399 * cli/cli-style.h: Rename include guard.
8400 * cli/cli-setshow.h: Rename include guard.
8401 * cli/cli-script.h: Rename include guard.
8402 * cli/cli-interp.h: Rename include guard.
8403 * cli/cli-decode.h: Rename include guard.
8404 * cli/cli-cmds.h: Rename include guard.
8405 * charset-list.h: Add include guard.
8406 * buildsym-legacy.h: Rename include guard.
8407 * bfin-tdep.h: Add include guard.
8408 * ax.h: Rename include guard.
8409 * arm-linux-tdep.h: Add include guard.
8410 * arm-fbsd-tdep.h: Add include guard.
8411 * arch/xtensa.h: Rename include guard.
8412 * arch/tic6x.h: Add include guard.
8413 * arch/i386.h: Add include guard.
8414 * arch/arm.h: Rename include guard.
8415 * arch/arm-linux.h: Rename include guard.
8416 * arch/arm-get-next-pcs.h: Rename include guard.
8417 * arch/amd64.h: Add include guard.
8418 * arch/aarch64-insn.h: Rename include guard.
8419 * arch-utils.h: Rename include guard.
8420 * annotate.h: Add include guard.
8421 * amd64-darwin-tdep.h: Rename include guard.
8422 * aarch64-linux-tdep.h: Add include guard.
8423 * aarch64-fbsd-tdep.h: Add include guard.
8424 * aarch32-linux-nat.h: Add include guard.
8425
8426 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8427
8428 * macrotab.c (macro_define_internal): New function that
8429 factorizes macro_define_object_internal and macro_define_function
8430 code.
8431 (macro_define_object_internal): Use macro_define_internal.
8432 (macro_define_function): Likewise.
8433
8434 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8435
8436 * macrocmd.c (extract_identifier): Return
8437 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8438 callers.
8439
8440 2019-02-06 John Baldwin <jhb@FreeBSD.org>
8441
8442 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8443
8444 2019-02-05 Tom Tromey <tom@tromey.com>
8445
8446 * target.c (target_stack::unpush): Move assertion earlier.
8447
8448 2019-01-30 Tom Tromey <tom@tromey.com>
8449
8450 PR python/23615:
8451 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8452 (gdbpy_parse_and_eval): Likewise.
8453 * python/python-internal.h (gdbpy_allow_threads): New class.
8454
8455 2019-01-28 John Baldwin <jhb@FreeBSD.org>
8456
8457 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8458 (aarch64_fbsd_fpregmap): Move earlier.
8459 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8460 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8461 instead of individual calls to trad_frame_set_reg_addr.
8462 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8463 earlier.
8464 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8465 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8466 instead of individual calls to trad_frame_set_reg_addr.
8467
8468 2019-01-28 Alan Hayward <alan.hayward@arm.com>
8469
8470 * CONTRIBUTE: Replace contribution list with wiki link.
8471
8472 2019-01-25 Tom Tromey <tom@tromey.com>
8473
8474 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8475
8476 2019-01-25 Tom Tromey <tom@tromey.com>
8477
8478 * xtensa-linux-nat.c: Fix common/ includes.
8479 * xml-support.h: Fix common/ includes.
8480 * xml-support.c: Fix common/ includes.
8481 * x86-linux-nat.c: Fix common/ includes.
8482 * windows-nat.c: Fix common/ includes.
8483 * varobj.h: Fix common/ includes.
8484 * varobj.c: Fix common/ includes.
8485 * value.c: Fix common/ includes.
8486 * valops.c: Fix common/ includes.
8487 * utils.c: Fix common/ includes.
8488 * unittests/xml-utils-selftests.c: Fix common/ includes.
8489 * unittests/utils-selftests.c: Fix common/ includes.
8490 * unittests/unpack-selftests.c: Fix common/ includes.
8491 * unittests/tracepoint-selftests.c: Fix common/ includes.
8492 * unittests/style-selftests.c: Fix common/ includes.
8493 * unittests/string_view-selftests.c: Fix common/ includes.
8494 * unittests/scoped_restore-selftests.c: Fix common/ includes.
8495 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8496 * unittests/scoped_fd-selftests.c: Fix common/ includes.
8497 * unittests/rsp-low-selftests.c: Fix common/ includes.
8498 * unittests/parse-connection-spec-selftests.c: Fix common/
8499 includes.
8500 * unittests/optional-selftests.c: Fix common/ includes.
8501 * unittests/offset-type-selftests.c: Fix common/ includes.
8502 * unittests/observable-selftests.c: Fix common/ includes.
8503 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8504 * unittests/memrange-selftests.c: Fix common/ includes.
8505 * unittests/memory-map-selftests.c: Fix common/ includes.
8506 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8507 * unittests/function-view-selftests.c: Fix common/ includes.
8508 * unittests/environ-selftests.c: Fix common/ includes.
8509 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8510 * unittests/common-utils-selftests.c: Fix common/ includes.
8511 * unittests/cli-utils-selftests.c: Fix common/ includes.
8512 * unittests/array-view-selftests.c: Fix common/ includes.
8513 * ui-file.c: Fix common/ includes.
8514 * tui/tui-io.c: Fix common/ includes.
8515 * tracepoint.h: Fix common/ includes.
8516 * tracepoint.c: Fix common/ includes.
8517 * tracefile-tfile.c: Fix common/ includes.
8518 * top.h: Fix common/ includes.
8519 * top.c: Fix common/ includes.
8520 * thread.c: Fix common/ includes.
8521 * target/waitstatus.h: Fix common/ includes.
8522 * target/waitstatus.c: Fix common/ includes.
8523 * target.h: Fix common/ includes.
8524 * target.c: Fix common/ includes.
8525 * target-memory.c: Fix common/ includes.
8526 * target-descriptions.c: Fix common/ includes.
8527 * symtab.h: Fix common/ includes.
8528 * symfile.c: Fix common/ includes.
8529 * stap-probe.c: Fix common/ includes.
8530 * spu-linux-nat.c: Fix common/ includes.
8531 * sparc-nat.c: Fix common/ includes.
8532 * source.c: Fix common/ includes.
8533 * solib.c: Fix common/ includes.
8534 * solib-target.c: Fix common/ includes.
8535 * ser-unix.c: Fix common/ includes.
8536 * ser-tcp.c: Fix common/ includes.
8537 * ser-pipe.c: Fix common/ includes.
8538 * ser-base.c: Fix common/ includes.
8539 * selftest-arch.c: Fix common/ includes.
8540 * s12z-tdep.c: Fix common/ includes.
8541 * rust-exp.y: Fix common/ includes.
8542 * rs6000-aix-tdep.c: Fix common/ includes.
8543 * riscv-tdep.c: Fix common/ includes.
8544 * remote.c: Fix common/ includes.
8545 * remote-notif.h: Fix common/ includes.
8546 * remote-fileio.h: Fix common/ includes.
8547 * remote-fileio.c: Fix common/ includes.
8548 * regcache.h: Fix common/ includes.
8549 * regcache.c: Fix common/ includes.
8550 * record-btrace.c: Fix common/ includes.
8551 * python/python.c: Fix common/ includes.
8552 * python/py-type.c: Fix common/ includes.
8553 * python/py-inferior.c: Fix common/ includes.
8554 * progspace.h: Fix common/ includes.
8555 * producer.c: Fix common/ includes.
8556 * procfs.c: Fix common/ includes.
8557 * proc-api.c: Fix common/ includes.
8558 * printcmd.c: Fix common/ includes.
8559 * ppc-linux-nat.c: Fix common/ includes.
8560 * parser-defs.h: Fix common/ includes.
8561 * osdata.c: Fix common/ includes.
8562 * obsd-nat.c: Fix common/ includes.
8563 * nat/x86-linux.c: Fix common/ includes.
8564 * nat/x86-linux-dregs.c: Fix common/ includes.
8565 * nat/x86-dregs.h: Fix common/ includes.
8566 * nat/x86-dregs.c: Fix common/ includes.
8567 * nat/ppc-linux.c: Fix common/ includes.
8568 * nat/mips-linux-watch.h: Fix common/ includes.
8569 * nat/mips-linux-watch.c: Fix common/ includes.
8570 * nat/linux-waitpid.c: Fix common/ includes.
8571 * nat/linux-ptrace.h: Fix common/ includes.
8572 * nat/linux-ptrace.c: Fix common/ includes.
8573 * nat/linux-procfs.c: Fix common/ includes.
8574 * nat/linux-personality.c: Fix common/ includes.
8575 * nat/linux-osdata.c: Fix common/ includes.
8576 * nat/linux-namespaces.c: Fix common/ includes.
8577 * nat/linux-btrace.h: Fix common/ includes.
8578 * nat/linux-btrace.c: Fix common/ includes.
8579 * nat/fork-inferior.c: Fix common/ includes.
8580 * nat/amd64-linux-siginfo.c: Fix common/ includes.
8581 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8582 * nat/aarch64-linux.c: Fix common/ includes.
8583 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8584 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8585 * namespace.h: Fix common/ includes.
8586 * mips-linux-tdep.c: Fix common/ includes.
8587 * minsyms.c: Fix common/ includes.
8588 * mi/mi-parse.h: Fix common/ includes.
8589 * mi/mi-main.c: Fix common/ includes.
8590 * mi/mi-cmd-env.c: Fix common/ includes.
8591 * memrange.h: Fix common/ includes.
8592 * memattr.c: Fix common/ includes.
8593 * maint.h: Fix common/ includes.
8594 * maint.c: Fix common/ includes.
8595 * main.c: Fix common/ includes.
8596 * machoread.c: Fix common/ includes.
8597 * location.c: Fix common/ includes.
8598 * linux-thread-db.c: Fix common/ includes.
8599 * linux-nat.c: Fix common/ includes.
8600 * linux-fork.c: Fix common/ includes.
8601 * inline-frame.c: Fix common/ includes.
8602 * infrun.c: Fix common/ includes.
8603 * inflow.c: Fix common/ includes.
8604 * inferior.h: Fix common/ includes.
8605 * inferior.c: Fix common/ includes.
8606 * infcmd.c: Fix common/ includes.
8607 * inf-ptrace.c: Fix common/ includes.
8608 * inf-child.c: Fix common/ includes.
8609 * ia64-linux-nat.c: Fix common/ includes.
8610 * i387-tdep.c: Fix common/ includes.
8611 * i386-tdep.c: Fix common/ includes.
8612 * i386-linux-tdep.c: Fix common/ includes.
8613 * i386-linux-nat.c: Fix common/ includes.
8614 * i386-go32-tdep.c: Fix common/ includes.
8615 * i386-fbsd-tdep.c: Fix common/ includes.
8616 * i386-fbsd-nat.c: Fix common/ includes.
8617 * guile/scm-type.c: Fix common/ includes.
8618 * guile/guile.c: Fix common/ includes.
8619 * go32-nat.c: Fix common/ includes.
8620 * gnu-nat.c: Fix common/ includes.
8621 * gdbthread.h: Fix common/ includes.
8622 * gdbarch-selftests.c: Fix common/ includes.
8623 * gdb_usleep.c: Fix common/ includes.
8624 * gdb_select.h: Fix common/ includes.
8625 * gdb_bfd.c: Fix common/ includes.
8626 * gcore.c: Fix common/ includes.
8627 * fork-child.c: Fix common/ includes.
8628 * findvar.c: Fix common/ includes.
8629 * fbsd-nat.c: Fix common/ includes.
8630 * event-top.c: Fix common/ includes.
8631 * event-loop.c: Fix common/ includes.
8632 * dwarf2read.c: Fix common/ includes.
8633 * dwarf2loc.c: Fix common/ includes.
8634 * dwarf2-frame.c: Fix common/ includes.
8635 * dwarf-index-cache.c: Fix common/ includes.
8636 * dtrace-probe.c: Fix common/ includes.
8637 * disasm-selftests.c: Fix common/ includes.
8638 * defs.h: Fix common/ includes.
8639 * csky-tdep.c: Fix common/ includes.
8640 * cp-valprint.c: Fix common/ includes.
8641 * cp-support.h: Fix common/ includes.
8642 * cp-support.c: Fix common/ includes.
8643 * corelow.c: Fix common/ includes.
8644 * completer.h: Fix common/ includes.
8645 * completer.c: Fix common/ includes.
8646 * compile/compile.c: Fix common/ includes.
8647 * compile/compile-loc2c.c: Fix common/ includes.
8648 * compile/compile-cplus-types.c: Fix common/ includes.
8649 * compile/compile-cplus-symbols.c: Fix common/ includes.
8650 * command.h: Fix common/ includes.
8651 * cli/cli-dump.c: Fix common/ includes.
8652 * cli/cli-cmds.c: Fix common/ includes.
8653 * charset.c: Fix common/ includes.
8654 * build-id.c: Fix common/ includes.
8655 * btrace.h: Fix common/ includes.
8656 * btrace.c: Fix common/ includes.
8657 * breakpoint.h: Fix common/ includes.
8658 * breakpoint.c: Fix common/ includes.
8659 * ax.h:
8660 (enum agent_op): Fix common/ includes.
8661 * ax-general.c (struct aop_map): Fix common/ includes.
8662 * ax-gdb.c: Fix common/ includes.
8663 * auxv.c: Fix common/ includes.
8664 * auto-load.c: Fix common/ includes.
8665 * arm-tdep.c: Fix common/ includes.
8666 * arch/riscv.c: Fix common/ includes.
8667 * arch/ppc-linux-common.c: Fix common/ includes.
8668 * arch/i386.c: Fix common/ includes.
8669 * arch/arm.c: Fix common/ includes.
8670 * arch/arm-linux.c: Fix common/ includes.
8671 * arch/arm-get-next-pcs.c: Fix common/ includes.
8672 * arch/amd64.c: Fix common/ includes.
8673 * arch/aarch64.c: Fix common/ includes.
8674 * arch/aarch64-insn.c: Fix common/ includes.
8675 * arch-utils.c: Fix common/ includes.
8676 * amd64-windows-tdep.c: Fix common/ includes.
8677 * amd64-tdep.c: Fix common/ includes.
8678 * amd64-sol2-tdep.c: Fix common/ includes.
8679 * amd64-obsd-tdep.c: Fix common/ includes.
8680 * amd64-nbsd-tdep.c: Fix common/ includes.
8681 * amd64-linux-tdep.c: Fix common/ includes.
8682 * amd64-linux-nat.c: Fix common/ includes.
8683 * amd64-fbsd-tdep.c: Fix common/ includes.
8684 * amd64-fbsd-nat.c: Fix common/ includes.
8685 * amd64-dicos-tdep.c: Fix common/ includes.
8686 * amd64-darwin-tdep.c: Fix common/ includes.
8687 * agent.c: Fix common/ includes.
8688 * ada-lang.h: Fix common/ includes.
8689 * ada-lang.c: Fix common/ includes.
8690 * aarch64-tdep.c: Fix common/ includes.
8691
8692 2019-01-25 Tom Tromey <tom@tromey.com>
8693
8694 * common/create-version.sh: Use common/version.h.
8695
8696 2019-01-24 Pedro Alves <palves@redhat.com>
8697
8698 * infrun.c (signal_stop, signal_print, signal_program)
8699 (signal_catch, signal_pass): Now arrays instead of pointers.
8700 (update_signals_program_target, do_target_resume)
8701 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8702 * linux-nat.c (linux_nat_target::pass_signals)
8703 (linux_nat_target::create_inferior, linux_nat_target::attach):
8704 Adjust.
8705 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8706 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8707 * procfs.c (procfs_target::pass_signals): Adjust.
8708 * record-full.c (record_full_target::resume): Adjust.
8709 * remote.c (remote_target::pass_signals)
8710 (remote_target::program_signals): Adjust.
8711 * target-debug.h (target_debug_print_signals): Now takes a
8712 gdb::array_view as parameter. Adjust.
8713 * target.h (target_ops) <pass_signals, program_signals>: Replace
8714 pointer and length parameters with gdb::array_view.
8715 (target_pass_signals, target_program_signals): Likewise.
8716 * target-delegates.c: Regenerate.
8717
8718 2019-01-24 Pedro Alves <palves@redhat.com>
8719
8720 * common/forward-scope-exit.h
8721 (forward_scope_exit::forward_scope_exit): Pass arguments to
8722 m_bind_function directly, instead of creating a std::bind and
8723 copying that.
8724
8725 2019-01-24 Alan Hayward <alan.hayward@arm.com>
8726
8727 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8728 for static members.
8729 (pass_in_v_vfp_candidate): Likewise.
8730
8731 2019-01-23 Tom Tromey <tom@tromey.com>
8732 Pedro Alves <palves@redhat.com>
8733
8734 * regcache.c (class regcache_invalidator): Remove.
8735 (regcache::raw_write): Use make_scope_exit.
8736
8737 2019-01-23 Tom Tromey <tom@tromey.com>
8738
8739 * ui-out.h (class ui_out_emit_type): Update comment.
8740
8741 2019-01-23 Tom Tromey <tom@tromey.com>
8742
8743 * infrun.c (fetch_inferior_event): Update comment.
8744
8745 2019-01-23 Tom Tromey <tom@tromey.com>
8746 Pedro Alves <palves@redhat.com>
8747
8748 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8749 parameter.
8750 (fetch_inferior_event): Use SCOPE_EXIT.
8751
8752
8753 2019-01-23 Tom Tromey <tom@tromey.com>
8754 Pedro Alves <palves@redhat.com>
8755
8756 * infrun.c (disable_thread_events): Delete.
8757 (stop_all_threads): Use SCOPE_EXIT.
8758
8759 2019-01-23 Tom Tromey <tom@tromey.com>
8760 Pedro Alves <palves@redhat.com>
8761
8762 * symfile.c: Include forward-scope-exit.h.
8763 (clear_symtab_users_cleanup): Replace forward declaration with
8764 a FORWARD_SCOPE_EXIT.
8765 (syms_from_objfile_1): Use the forward_scope_exit and
8766 gdb::optional instead of cleanup_function.
8767 (reread_symbols): Use the forward_scope_exit instead of
8768 cleanup_function.
8769 (clear_symtab_users_cleanup): Remove function.
8770
8771 2019-01-23 Tom Tromey <tom@tromey.com>
8772 Pedro Alves <palves@redhat.com>
8773
8774 * linux-nat.c: Include scope-exit.h.
8775 (cleanup_target_stop): Remove.
8776 (linux_nat_target::static_tracepoint_markers_by_strid): Use
8777 SCOPE_EXIT.
8778
8779 2019-01-23 Tom Tromey <tom@tromey.com>
8780 Pedro Alves <palves@redhat.com>
8781
8782 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8783 (call_function_by_hand_dummy): Use SCOPE_EXIT.
8784
8785 2019-01-23 Tom Tromey <tom@tromey.com>
8786 Andrew Burgess <andrew.burgess@embecosm.com>
8787 Pedro Alves <palves@redhat.com>
8788
8789 * infrun.c (fetch_inferior_event): Use scope_exit.
8790 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8791 * top.c (execute_command): Use scope_exit.
8792 * breakpoint.c (bpstat_do_actions): Use scope_exit.
8793 * utils.c (do_bpstat_clear_actions_cleanup)
8794 (make_bpstat_clear_actions_cleanup): Remove.
8795
8796 2019-01-23 Tom Tromey <tom@tromey.com>
8797 Pedro Alves <palves@redhat.com>
8798
8799 * infrun.c: Include "common/scope-exit.h"
8800 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8801 (wait_for_inferior): Use SCOPE_EXIT.
8802 (fetch_inferior_event): Use scope_exit.
8803
8804 2019-01-23 Tom Tromey <tom@tromey.com>
8805 Pedro Alves <palves@redhat.com>
8806
8807 * breakpoint.c (create_breakpoint): Remove cleanup.
8808
8809 2019-01-23 Tom Tromey <tom@tromey.com>
8810 Andrew Burgess <andrew.burgess@embecosm.com>
8811 Pedro Alves <palves@redhat.com>
8812
8813 2019-01-23 Pedro Alves <palves@redhat.com>
8814
8815 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8816
8817 2019-01-23 Pedro Alves <palves@redhat.com>
8818 Andrew Burgess <andrew.burgess@embecosm.com>
8819
8820 * gdbthread.h: Include "common/forward-scope-exit.h".
8821 (scoped_finish_thread_state): Redefine custom class in terms of
8822 forward_scope_exit.
8823
8824 2019-01-23 Pedro Alves <palves@redhat.com>
8825 Andrew Burgess <andrew.burgess@embecosm.com>
8826
8827 * common/forward-scope-exit.h: New file.
8828
8829 2019-01-23 Pedro Alves <palves@redhat.com>
8830 Andrew Burgess <andrew.burgess@embecosm.com>
8831 Tom Tromey <tom@tromey.com>
8832
8833 * common/scope-exit.h: New file.
8834
8835 2019-01-23 Pedro Alves <palves@redhat.com>
8836
8837 * common/preprocessor.h (ESC): Rename to ...
8838 (ESC_PARENS): ... this.
8839 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8840 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8841
8842 2019-01-23 Tom Tromey <tom@tromey.com>
8843
8844 * language.h (class scoped_switch_to_sym_language_if_auto):
8845 Initialize m_lang in both cases.
8846
8847 2019-01-23 Alan Hayward <alan.hayward@arm.com>
8848
8849 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8850 with XCNEW.
8851
8852 2019-01-22 Tom Tromey <tom@tromey.com>
8853
8854 * corelow.c: Do not include sys/file.h.
8855
8856 2019-01-22 Tom Tromey <tom@tromey.com>
8857
8858 * tui/tui-wingeneral.h: Include gdb_curses.h.
8859
8860 2019-01-22 Tom Tromey <tom@tromey.com>
8861
8862 * source-cache.h (class source_cache) <get_source_lines,
8863 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8864
8865 2019-01-22 Tom Tromey <tom@tromey.com>
8866
8867 * remote-fileio.h (struct remote_target): Declare.
8868
8869 2019-01-22 Tom Tromey <tom@tromey.com>
8870
8871 * python/py-arch.c: Do not include py-ref.h.
8872 * python/py-bpevent.c: Do not include py-ref.h.
8873 * python/py-cmd.c: Do not include py-ref.h.
8874 * python/py-continueevent.c: Do not include py-ref.h.
8875 * python/py-event.h: Do not include py-ref.h.
8876 * python/py-evtregistry.c: Do not include py-ref.h.
8877 * python/py-finishbreakpoint.c: Do not include py-ref.h.
8878 * python/py-frame.c: Do not include py-ref.h.
8879 * python/py-framefilter.c: Do not include py-ref.h.
8880 * python/py-function.c: Do not include py-ref.h.
8881 * python/py-infevents.c: Do not include py-ref.h.
8882 * python/py-linetable.c: Do not include py-ref.h.
8883 * python/py-objfile.c: Do not include py-ref.h.
8884 * python/py-param.c: Do not include py-ref.h.
8885 * python/py-prettyprint.c: Do not include py-ref.h.
8886 * python/py-progspace.c: Do not include py-ref.h.
8887 * python/py-symbol.c: Do not include py-ref.h.
8888 * python/py-symtab.c: Do not include py-ref.h.
8889 * python/py-type.c: Do not include py-ref.h.
8890 * python/py-unwind.c: Do not include py-ref.h.
8891 * python/py-utils.c: Do not include py-ref.h.
8892 * python/py-value.c: Do not include py-ref.h.
8893 * python/py-varobj.c: Do not include py-ref.h.
8894 * python/py-xmethods.c: Do not include py-ref.h.
8895 * python/python.c: Do not include py-ref.h.
8896 * varobj.c: Do not include py-ref.h.
8897
8898 2019-01-22 Tom Tromey <tom@tromey.com>
8899
8900 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8901 keyword for bcache.
8902
8903 2019-01-22 Tom Tromey <tom@tromey.com>
8904
8905 * compile/compile-cplus-types.c: Remove a comment by #include.
8906
8907 2019-01-22 Tom Tromey <tom@tromey.com>
8908
8909 * compile/gcc-c-plugin.h: Include compile-internal.h.
8910
8911 2019-01-22 Tom Tromey <tom@tromey.com>
8912
8913 * stabsread.c (EXTERN): Do not define.
8914 (symnum, next_symbol_text_func, processing_gcc_compilation)
8915 (within_function, global_sym_chain, global_stabs)
8916 (previous_stab_code, this_object_header_files)
8917 (n_this_object_header_files)
8918 (n_allocated_this_object_header_files): Define.
8919 * stabsread.h (EXTERN): Never define. Use "extern".
8920
8921 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8922
8923 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8924 history_value.
8925
8926 2019-01-21 Tom Tromey <tom@tromey.com>
8927
8928 * ui-out.c: Fix includes.
8929 * tui/tui-source.c: Fix includes.
8930 * target.c: Fix includes.
8931 * remote.c: Fix includes.
8932 * regcache.c: Fix includes.
8933 * python/py-block.c: Fix includes.
8934 * printcmd.c: Fix includes.
8935 * or1k-tdep.c: Fix includes.
8936 * mi/mi-main.c: Fix includes.
8937 * m32r-tdep.c: Fix includes.
8938 * csky-tdep.c: Fix includes.
8939 * compile/compile-cplus-types.c: Fix includes.
8940 * cli/cli-interp.c: Fix includes.
8941
8942 2019-01-21 Alan Hayward <alan.hayward@arm.com>
8943
8944 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8945 for padding.
8946
8947 2019-01-16 Tom Tromey <tom@tromey.com>
8948
8949 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
8950 earlier.
8951 (struct objfile) <msymbols_range>: Move from top level.
8952 <msymbols>: New method.
8953 (class objfile_msymbols): Remove.
8954 * symtab.c (default_collect_symbol_completion_matches_break_on):
8955 Update.
8956 * symmisc.c (dump_msymbols): Update.
8957 * stabsread.c (scan_file_globals): Update.
8958 * objc-lang.c (info_selectors_command, info_classes_command)
8959 (find_methods): Update.
8960 * minsyms.c (find_solib_trampoline_target): Update.
8961 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8962 * coffread.c (coff_symfile_read): Update.
8963 * ada-lang.c (ada_lookup_simple_minsym)
8964 (ada_collect_symbol_completion_matches): Update.
8965
8966 2019-01-16 Tom Tromey <tom@tromey.com>
8967
8968 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8969 type. Remove no-argument constructor.
8970 <iterator::operator++>: Simplify.
8971 <begin>: Update.
8972 <end>: Use minimal_symbol_count.
8973
8974 2019-01-16 Tom Tromey <tom@tromey.com>
8975
8976 * objfiles.h (struct objfile) <psymtabs>: New method.
8977 (class objfile_psymtabs): Remove.
8978 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8979 typedef.
8980 <range>: New method.
8981 (require_partial_symbols): Change return type.
8982 * psymtab.c (require_partial_symbols)
8983 (psym_expand_symtabs_matching): Update.
8984 * mdebugread.c (parse_partial_symbols): Update.
8985 * dbxread.c (dbx_end_psymtab): Update.
8986
8987 2019-01-15 Tom Tromey <tom@tromey.com>
8988
8989 * symtab.c (lookup_objfile_from_block)
8990 (lookup_symbol_in_objfile_symtabs)
8991 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8992 (find_line_symtab, info_sources_command)
8993 (default_collect_symbol_completion_matches_break_on)
8994 (make_source_files_completion_list): Update.
8995 * symmisc.c (print_objfile_statistics, dump_objfile)
8996 (maintenance_print_symbols, maintenance_info_symtabs)
8997 (maintenance_check_symtabs, maintenance_info_line_tables):
8998 Update.
8999 * source.c (select_source_symtab)
9000 (forget_cached_source_info_for_objfile): Update.
9001 * objfiles.h (class objfile_compunits): Remove.
9002 (struct objfile) <compunits_range>: New typedef.
9003 (compunits): New method.
9004 * objfiles.c (objfile_relocate1): Update.
9005 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9006 * maint.c (count_symtabs_and_blocks): Update.
9007 * linespec.c (iterate_over_all_matching_symtabs): Update.
9008 * cp-support.c (add_symbol_overload_list_qualified): Update.
9009 * coffread.c (coff_symtab_read): Update.
9010 * ada-lang.c (add_nonlocal_symbols)
9011 (ada_collect_symbol_completion_matches)
9012 (ada_add_global_exceptions): Update.
9013
9014 2019-01-15 Tom Tromey <tom@tromey.com>
9015
9016 * progspace.h (program_space) <objfiles_safe_range>: New
9017 typedef.
9018 <objfiles_safe>: New method.
9019 * objfiles.h (class all_objfiles_safe): Remove.
9020 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9021 * jit.c (jit_inferior_exit_hook): Update.
9022
9023 2019-01-17 Tom Tromey <tom@tromey.com>
9024
9025 * progspace.h (program_space) <objfiles_range>: New typedef.
9026 <objfiles>: New method.
9027 <objfiles_head>: Rename from objfiles.
9028 (object_files): Update.
9029 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9030 * guile/scm-pretty-print.c
9031 (ppscm_find_pretty_printer_from_objfiles): Update.
9032 * guile/scm-objfile.c (gdbscm_objfiles): Update.
9033 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9034 Update.
9035 * python/py-progspace.c (pspy_get_objfiles): Update.
9036 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9037 Update.
9038 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9039 (objfpy_lookup_objfile_by_build_id): Update.
9040 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9041 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9042 Update.
9043 * symtab.c (iterate_over_symtabs, matching_obj_sections)
9044 (expand_symtab_containing_pc, lookup_objfile_from_block)
9045 (lookup_static_symbol, basic_lookup_transparent_type)
9046 (find_pc_sect_compunit_symtab, find_symbol_at_address)
9047 (find_line_symtab, info_sources_command)
9048 (default_collect_symbol_completion_matches_break_on)
9049 (make_source_files_completion_list, find_main_name): Update.
9050 * symmisc.c (print_symbol_bcache_statistics)
9051 (print_objfile_statistics, maintenance_print_symbols)
9052 (maintenance_print_msymbols, maintenance_print_objfiles)
9053 (maintenance_info_symtabs, maintenance_check_symtabs)
9054 (maintenance_expand_symtabs, maintenance_info_line_tables):
9055 Update.
9056 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9057 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9058 (map_overlay_command, unmap_overlay_command)
9059 (simple_overlay_update, expand_symtabs_matching)
9060 (map_symbol_filenames): Update.
9061 * symfile-debug.c (set_debug_symfile): Update.
9062 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9063 Update.
9064 * source.c (select_source_symtab, forget_cached_source_info):
9065 Update.
9066 * solib.c (solib_read_symbols): Update.
9067 * solib-spu.c (append_ocl_sos): Update.
9068 * psymtab.c (maintenance_print_psymbols)
9069 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9070 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9071 * printcmd.c (info_symbol_command): Update.
9072 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9073 Update.
9074 * objfiles.h (class all_objfiles): Remove.
9075 * objfiles.c (have_partial_symbols, have_full_symbols)
9076 (have_minimal_symbols, qsort_cmp, update_section_map)
9077 (shared_objfile_contains_address_p)
9078 (default_iterate_over_objfiles_in_search_order): Update.
9079 * objc-lang.c (info_selectors_command, info_classes_command)
9080 (find_methods): Update.
9081 * minsyms.c (find_solib_trampoline_target): Update.
9082 * maint.c (maintenance_info_sections)
9083 (maintenance_translate_address, count_symtabs_and_blocks):
9084 Update.
9085 * main.c (captured_main_1): Update.
9086 * linux-thread-db.c (try_thread_db_load_from_pdir)
9087 (has_libpthread): Update.
9088 * linespec.c (iterate_over_all_matching_symtabs)
9089 (search_minsyms_for_name): Update.
9090 * jit.c (jit_find_objf_with_entry_addr): Update.
9091 * hppa-tdep.c (find_unwind_entry)
9092 (hppa_lookup_stub_minimal_symbol): Update.
9093 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9094 Update.
9095 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9096 (elf_gnu_ifunc_resolve_by_got): Update.
9097 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9098 * dwarf-index-write.c (save_gdb_index_command): Update.
9099 * cp-support.c (add_symbol_overload_list_qualified): Update.
9100 * breakpoint.c (create_overlay_event_breakpoint)
9101 (create_longjmp_master_breakpoint)
9102 (create_std_terminate_master_breakpoint)
9103 (create_exception_master_breakpoint): Update.
9104 * blockframe.c (find_pc_partial_function): Update.
9105 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9106 (ada_collect_symbol_completion_matches)
9107 (ada_add_global_exceptions): Update.
9108
9109 2019-01-17 Tom Tromey <tom@tromey.com>
9110
9111 * solib-target.c (lm_info_target_p): Remove typedef. Don't
9112 declare VEC.
9113 (solib_target_parse_libraries): Change return type.
9114 (library_list_start_segment, library_list_start_section)
9115 (library_list_end_library, library_list_start_library); Update.
9116 (solib_target_free_library_list): Remove.
9117 (solib_target_parse_libraries): Remove cleanup. Change return
9118 type.
9119 (solib_target_current_sos): Update.
9120
9121 2019-01-17 Tom Tromey <tromey@bapiya>
9122
9123 * valprint.c: Replace "the the" with "the".
9124 * symtab.c: Replace "the the" with "the".
9125 * solib.c: Replace "the the" with "the".
9126 * solib-dsbt.c: Replace "the the" with "the".
9127 * linespec.c: Replace "the the" with "the".
9128 * dwarf2loc.h: Replace "the the" with "the".
9129 * amd64-windows-tdep.c: Replace "the the" with "the".
9130 * aarch64-tdep.c: Replace "the the" with "the".
9131
9132 2019-01-16 Keith Seitz <keiths@redhat.com>
9133
9134 PR gdb/23773
9135 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9136 <builder>: Rename to ..
9137 <m_builder>: ... this and make private.
9138 (dwarf2_cu::get_builder): New method. Change all users of
9139 `builder' to use this method.
9140 (dwarf2_start_symtab): Move to ...
9141 (dwarf2_cu::start_symtab): ... here. Update all callers
9142 (setup_type_unit_groups): Move to ...
9143 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
9144 callers.
9145 (dwarf2_cu::reset_builder): New method.
9146 (process_full_compunit, process_full_type_unit): Use
9147 dwarf2_cu::reset_builder.
9148 (follow_die_offset): Record the ancestor CU if it is different
9149 from the followed DIE's CU.
9150 (follow_die_sig_1): Likewise.
9151
9152 2019-01-15 Tom Tromey <tom@tromey.com>
9153
9154 * remote.c (class remote_state) <buf>: Now a char_vector.
9155 <buf_size>: Remove.
9156 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
9157 parameter.
9158 (remote_target::getpkt_or_notif_sane_1)
9159 (remote_target::getpkt_sane)
9160 (remote_target::getpkt_or_notif_sane): Likewise.
9161 (class remote_target) <putpkt>: New overload.
9162 (remote_target::read_frame): Change type of "buf_p". Remove
9163 sizeof_p parameter.
9164 (packet_ok): New overload.
9165 (packet_check_result): New overload.
9166 Update all uses.
9167
9168 2019-01-14 Tom Tromey <tom@tromey.com>
9169
9170 * remote-notif.c (handle_notification, remote_notif_ack)
9171 (remote_notif_parse): Make "buf" const.
9172 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9173 const.
9174 (remote_notif_parse, remote_notif_ack, handle_notification):
9175 Likewise.
9176 * remote.c (remote_notif_stop_parse): Make "buf" const.
9177 (remote_target::remote_parse_stop_reply): Make "buf" const.
9178 (remote_notif_stop_ack): Make "buf" const.
9179
9180 2019-01-14 Tom Tromey <tom@tromey.com>
9181
9182 * remote.c (remote_console_output): Make parameter const.
9183
9184 2019-01-14 Tom Tromey <tom@tromey.com>
9185
9186 * target-debug.h (target_debug_print_signals): Constify.
9187 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9188 * procfs.c (procfs_target::pass_signals): Update.
9189 * linux-nat.c (linux_nat_target::pass_signals): Update.
9190 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9191 * target-delegates.c: Rebuild.
9192 * remote.c (remote_target::program_signals): Update.
9193 (remote_target::pass_signals): Update.
9194 * target.c (target_pass_signals): Constify argument.
9195 (target_program_signals): Likewise.
9196 * target.h (struct target_ops) <pass_signals, program_signals>:
9197 Constify argument.
9198 (target_pass_signals, target_program_signals): Constify argument.
9199
9200 2019-01-14 Tom Tromey <tom@tromey.com>
9201
9202 PR tui/28819:
9203 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9204
9205 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
9206
9207 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9208 field.
9209 * rs6000-tdep.c: Include reggroups.h.
9210 (IS_V_ALIAS_PSEUDOREG): Define.
9211 (rs6000_register_name): Return names for the "vX" aliases.
9212 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9213 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
9214 aliases. Call default_register_reggroup_p for all other
9215 pseudo-registers.
9216 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9217 New functions.
9218 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9219 Handle "vX" aliases.
9220 (v_alias_pseudo_register_collect): New function.
9221 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9222 (rs6000_gdbarch_init): Initialize "vX" aliases as
9223 pseudo-registers. Restore registration of
9224 rs6000_pseudo_register_reggroup_p with
9225 set_tdesc_pseudo_register_reggroup_p.
9226
9227 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
9228
9229 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9230 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9231 set_gdbarch_num_pseudo_regs.
9232
9233 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9234
9235 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9236 Remove arg prefixname, add do_set and do_show.
9237 Add member functions set_list and show_list.
9238 * cli/cli-style.c (class cli_style_option): Update accordingly.
9239 (style_set_list): Move to file scope.
9240 (style_show_list): Likewise.
9241 (set_style): Call help_list.
9242 (show_style): Call cmd_show_list.
9243 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9244 Update to use the new macro.
9245
9246 2019-10-12 Joel Brobecker <brobecker@adacore.com>
9247
9248 * ada-lang.c (_initialize_ada_language): Expand the help text
9249 for the "catch exception" command.
9250
9251 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9252
9253 * symtab.c (matching_obj_sections): Initialize obj,
9254 declare it closer to its usage.
9255
9256 2019-01-10 Tom Tromey <tom@tromey.com>
9257
9258 * thread-iter.h (inf_threads_iterator): Use next_iterator.
9259 (basic_inf_threads_range): Remove.
9260 (inf_threads_range, inf_non_exited_threads_range)
9261 (safe_inf_threads_range): Use next_adapter.
9262
9263 2019-01-10 Keith Seitz <keiths@redhat.com>
9264
9265 PR gdb/23712
9266 PR symtab/23010
9267 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9268 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9269
9270 2019-01-10 Keith Seitz <keiths@redhat.com>
9271
9272 PR gdb/23712
9273 PR symtab/23010
9274 * dictionary.c (pending_to_vector): Remove.
9275 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9276 Remove _1 suffix, replacing functions of the same name. Update
9277 all callers.
9278 (dict_create_hashed, dict_create_hashed_expandable)
9279 (dict_create_linear, dict_create_linear_expandable, dict_free)
9280 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9281 Make functions static.
9282
9283 2019-01-10 Keith Seitz <keiths@redhat.com>
9284
9285 PR gdb/23712
9286 PR symtab/23010
9287 * dictionary.h (struct dictionary): Replace declaration with
9288 multidictionary.
9289 (dict_create_hashed, dict_create_hashed_expandable)
9290 (dict_create_linear, dict_create_linear_expandable)
9291 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9292 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9293 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9294 taking multidictionary argument.
9295 [ALL_DICT_SYMBOLS]: Update for multidictionary.
9296 * block.h (struct block) <dict>: Change to multidictionary
9297 and rename `multidict'.
9298 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9299 symmisc.c: Update all dictionary references to multidictionary.
9300
9301 2019-01-10 Keith Seitz <keiths@redhat.com>
9302
9303 PR gdb/23712
9304 PR symtab/23010
9305 * dictionary.c: Include unordered_map.
9306 (pending_to_vector): New function.
9307 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9308 Rewrite the non-"_1" functions to take vector instead
9309 of linked list.
9310 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9311 "new" _1 versions of the same name.
9312 (multidictionary): Define.
9313 (std::hash<enum language): New definition.
9314 (collate_pending_symbols_by_language, mdict_create_hashed)
9315 (mdict_create_hashed_expandable, mdict_create_linear)
9316 (mdict_create_linear_expandable, mdict_free)
9317 (find_language_dictionary, create_new_language_dictionary)
9318 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9319 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9320 (mdict_size, mdict_empty): New functions.
9321 * dictionary.h (mdict_iterator): Define.
9322
9323 2019-01-10 Pedro Alves <palves@redhat.com>
9324
9325 * breakpoint.c (read_uploaded_action)
9326 (create_tracepoint_from_upload): Adjust to use
9327 gdb::unique_xmalloc_ptr.
9328 * ctf.c (ctf_write_uploaded_tp):
9329 (SET_ARRAY_FIELD): Use emplace_back.
9330 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9331 * tracefile-tfile.c (tfile_write_uploaded_tp):
9332 * tracepoint.c (parse_tracepoint_definition): Adjust to use
9333 gdb::unique_xmalloc_ptr.
9334 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9335 at_string, cond_string, cmd_strings>: Replace char pointers
9336 with gdb::unique_xmalloc_ptr.
9337
9338 2019-01-10 Pedro Alves <palves@redhat.com>
9339
9340 * solib-target.c (library_list_start_library): Don't xstrdup name.
9341
9342 2019-01-10 Pedro Alves <palves@redhat.com>
9343
9344 * mdebugread.c (parse_partial_symbols): Use
9345 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9346
9347 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
9348
9349 * linux-fork.c (scoped_switch_fork_info)
9350 <~scoped_switch_fork_info>: Fix incorrect variable name.
9351
9352 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
9353
9354 * linux-fork.c (scoped_switch_fork_info)
9355 <scoped_switch_fork_info>: Make explicit.
9356 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9357
9358 2019-01-10 Tom Tromey <tom@tromey.com>
9359
9360 * objfiles.h (objfile::reset_psymtabs): Update.
9361 * objfiles.c (objfile::objfile): Update.
9362 * psymtab.h (psymtab_storage::obstack): Update.
9363 (psymtab_storage::m_obstack): Use gdb::optional.
9364 (class psymtab_storage): Update comment. Remove objfile
9365 parameter.
9366 * psymtab.c (psymtab_storage::psymtab_storage): Update.
9367
9368 2019-01-10 Tom Tromey <tom@tromey.com>
9369
9370 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9371 <free_psymtabs>: Now private.
9372 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9373 (allocate_psymtab): Use new method.
9374
9375 2019-01-10 Tom Tromey <tom@tromey.com>
9376
9377 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9378 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9379 * mdebugread.c (parse_partial_symbols): Use
9380 allocate_dependencies.
9381 * dwarf2read.c (dwarf2_create_include_psymtab): Use
9382 allocate_dependencies.
9383 (process_psymtab_comp_unit_reader)
9384 (build_type_psymtab_dependencies): Likewise.
9385 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9386
9387 2019-01-10 Tom Tromey <tom@tromey.com>
9388
9389 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9390 PSYMBOL_SET_LANGUAGE.
9391 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9392
9393 2019-01-10 Tom Tromey <tom@tromey.com>
9394
9395 * psymtab.h (psymtab_storage::obstack): New method.
9396 <m_obstack>: Rename from obstack; now private.
9397 * psymtab.c (psymtab_storage): Update.
9398 * dwarf2read.c (create_addrmap_from_index)
9399 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9400 Update.
9401
9402 2019-01-10 Tom Tromey <tom@tromey.com>
9403
9404 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9405 * objfiles.h (objfile::reset_psymtabs): New method.
9406
9407 2019-01-10 Tom Tromey <tom@tromey.com>
9408
9409 * symmisc.c (print_symbol_bcache_statistics): Update.
9410 (print_objfile_statistics): Update.
9411 * symfile.c (reread_symbols): Update.
9412 * psymtab.h (class psymtab_storage): New.
9413 * psymtab.c (psymtab_storage): New constructor.
9414 (~psymtab_storage): New destructor.
9415 (require_partial_symbols): Update.
9416 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9417 (find_pc_sect_psymtab, find_pc_sect_psymbol)
9418 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9419 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9420 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9421 (start_psymtab_common, end_psymtab_common)
9422 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9423 (allocate_psymtab): Update.
9424 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9425 Update.
9426 (dump_psymtab_addrmap, maintenance_print_psymbols)
9427 (maintenance_check_psymtabs): Update.
9428 (class objfile_psymtabs): Move to objfiles.h.
9429 * psympriv.h (discard_psymtab): Now inline.
9430 (psymtab_discarder::psymtab_discarder): Update.
9431 (psymtab_discarder::~psymtab_discarder): Update.
9432 (ALL_OBJFILE_PSYMTABS): Rewrite.
9433 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9434 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9435 Remove fields.
9436 <partial_symtabs>: New field.
9437 (class objfile_psymtabs): Move from psymtab.h. Update.
9438 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9439 psymbol_cache.
9440 (objfile::~objfile): Don't destroy psymbol_cache.
9441 * mdebugread.c (parse_partial_symbols): Update.
9442 * dwarf2read.c (create_addrmap_from_index)
9443 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9444 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9445 (add_partial_subprogram, dwarf2_ranges_read): Update.
9446 * dwarf-index-write.c (write_address_map)
9447 (write_one_signatured_type, recursively_write_psymbols)
9448 (class debug_names, class debug_names, write_psymtabs_to_index):
9449 Update.
9450
9451 2019-01-10 Tom Tromey <tom@tromey.com>
9452
9453 * symtab.h (SYMBOL_SET_NAMES): Update.
9454 (symbol_set_names): Update.
9455 (MSYMBOL_SET_NAMES): Update.
9456 * symtab.c (symbol_set_names): Change argument to be an
9457 objfile_per_bfd_storage.
9458 * psymtab.c (add_psymbol_to_bcache): Update.
9459 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9460
9461 2019-01-10 Tom Tromey <tom@tromey.com>
9462
9463 * symtab.c (create_demangled_names_hash): Change argument to be an
9464 objfile_per_bfd_storage.
9465 (symbol_set_names): Update.
9466
9467 2019-01-10 Tom Tromey <tom@tromey.com>
9468
9469 * xcoffread.c (xcoff_initial_scan): Unconditionally call
9470 init_psymbol_list.
9471 * psymtab.c (init_psymbol_list): Do nothing if already called.
9472 * psympriv.h (init_psymbol_list): Add comment.
9473 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9474 init_psymbol_list.
9475 * dbxread.c (dbx_symfile_read): Unconditionally call
9476 init_psymbol_list.
9477
9478 2019-01-10 Tom Tromey <tom@tromey.com>
9479
9480 * xcoffread.c (scan_xcoff_symtab): Update.
9481 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9482 "where".
9483 * mdebugread.c (parse_partial_symbols)
9484 (handle_psymbol_enumerators): Update.
9485 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9486 * dbxread.c (read_dbx_symtab): Update.
9487 * psympriv.h (psymbol_placement): New enum.
9488 (add_psymbol_to_list): Update.
9489
9490 2019-01-10 Tom Tromey <tom@tromey.com>
9491
9492 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9493 static_psymbols parameters.
9494 (scan_xcoff_symtab): Update.
9495 * psymtab.c (start_psymtab_common): Remove global_psymbols and
9496 static_psymbols parameters.
9497 * psympriv.h (start_psymtab_common): Update.
9498 * mdebugread.c (parse_partial_symbols): Update.
9499 * dwarf2read.c (create_partial_symtab): Update.
9500 * dbxread.c (read_dbx_symtab): Update.
9501 (start_psymtab): Remove global_psymbols and static_psymbols
9502 parameters.
9503
9504 2019-01-10 Tom Tromey <tom@tromey.com>
9505
9506 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9507 * psymtab.c (allocate_psymtab): Add comment.
9508 * psympriv.h (allocate_psymtab): Add comment.
9509 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9510 initializations.
9511 * dbxread.c (dbx_end_psymtab): Remove some initializations.
9512
9513 2019-01-10 Tom Tromey <tom@tromey.com>
9514
9515 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9516 Don't declare.
9517 * mipsread.c: Include mdebugread.h.
9518 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9519 Declare.
9520 * elfread.c: Include mdebugread.h.
9521
9522 2019-01-09 Tom Tromey <tom@tromey.com>
9523
9524 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9525 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9526 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9527 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9528 (psym_lookup_symbol, psym_find_last_source_symtab)
9529 (psym_forget_cached_source_info, psym_print_stats)
9530 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9531 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9532 (psym_map_matching_symbols, psym_expand_symtabs_matching)
9533 (psym_find_compunit_symtab_by_address)
9534 (maintenance_print_psymbols, maintenance_info_psymtabs)
9535 (maintenance_check_psymtabs): Use ranged for.
9536 * psymtab.h (class objfile_psymtabs): New.
9537 (require_partial_symbols): Return objfile_psymtabs.
9538 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9539
9540 2019-01-09 Tom Tromey <tom@tromey.com>
9541
9542 * symfile.c (overlay_invalidate_all, find_pc_overlay)
9543 (find_pc_mapped_section, list_overlays_command)
9544 (map_overlay_command, unmap_overlay_command)
9545 (simple_overlay_update): Use all_objfiles.
9546 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9547 * printcmd.c (info_symbol_command): Use all_objfiles.
9548 * objfiles.h (ALL_OBJSECTIONS): Remove.
9549 * maint.c (maintenance_translate_address): Use all_objfiles.
9550 * gcore.c (gcore_create_callback): Use all_objfiles.
9551 (objfile_find_memory_regions): Likewise.
9552
9553 2019-01-09 Tom Tromey <tom@tromey.com>
9554
9555 * symtab.c (find_line_symtab, info_sources_command)
9556 (make_source_files_completion_list): Use objfile_compunits.
9557 * source.c (select_source_symtab): Use objfile_compunits.
9558 * objfiles.h (struct objfile): Update comment.
9559 (ALL_OBJFILES): Remove.
9560 (ALL_FILETABS): Remove.
9561 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9562 objfile_compunits.
9563
9564 2019-01-09 Tom Tromey <tom@tromey.com>
9565
9566 * symmisc.c (print_objfile_statistics, dump_objfile)
9567 (maintenance_print_symbols): Use compunit_filetabs.
9568 * source.c (forget_cached_source_info_for_objfile): Use
9569 compunit_filetabs.
9570 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9571 (ALL_FILETABS): Use compunit_filetabs.
9572 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9573 * coffread.c (coff_symtab_read): Use compunit_filetabs.
9574
9575 2019-01-09 Tom Tromey <tom@tromey.com>
9576
9577 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9578 (compunit_filetabs): New.
9579 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9580 compunit_filetabs.
9581 (info_sources_command, make_source_files_completion_list): Remove
9582 declaration.
9583 * symmisc.c (print_objfile_statistics, dump_objfile)
9584 (maintenance_print_symbols): Remove declaration.
9585 (maintenance_info_symtabs): Use compunit_filetabs.
9586 (maintenance_info_line_tables): Likewise.
9587 * source.c (select_source_symtab): Change local variable name.
9588 (forget_cached_source_info_for_objfile): Remove declaration.
9589 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9590 * objfiles.c (objfile_relocate1): Remove declaration.
9591 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9592 declaration.
9593 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9594 * coffread.c (coff_symtab_read): Remove declaration.
9595 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9596 compunit_filetabs.
9597
9598 2019-01-09 Tom Tromey <tom@tromey.com>
9599
9600 * symtab.c (lookup_objfile_from_block)
9601 (find_pc_sect_compunit_symtab, search_symbols)
9602 (default_collect_symbol_completion_matches_break_on): Use
9603 objfile_compunits.
9604 * objfiles.h (ALL_COMPUNITS): Remove.
9605 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9606 * cp-support.c (add_symbol_overload_list_qualified): Use
9607 objfile_compunits.
9608 * ada-lang.c (ada_collect_symbol_completion_matches)
9609 (ada_add_global_exceptions): Use objfile_compunits.
9610
9611 2019-01-09 Tom Tromey <tom@tromey.com>
9612
9613 * source.c (select_source_symtab)
9614 (forget_cached_source_info_for_objfile): Remove declaration.
9615 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9616 declaration.
9617 * maint.c (count_symtabs_and_blocks): Remove declaration.
9618 * cp-support.c (add_symbol_overload_list_qualified): Remove
9619 declaration.
9620 * coffread.c (coff_symtab_read): Remove declaration.
9621 * symtab.c (lookup_symbol_in_objfile_symtabs)
9622 (basic_lookup_transparent_type_1): Use objfile_compunits.
9623 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9624 (info_sources_command, search_symbols)
9625 (default_collect_symbol_completion_matches_break_on)
9626 (make_source_files_completion_list): Remove declaration.
9627 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9628 (ada_collect_symbol_completion_matches)
9629 (ada_add_global_exceptions): Remove declaration.
9630 * linespec.c (iterate_over_all_matching_symtabs): Use
9631 objfile_compunits.
9632 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9633 (class objfile_compunits): New.
9634 (ALL_COMPUNITS): Use objfile_compunits.
9635 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9636 (maintenance_check_symtabs, maintenance_info_line_tables): Use
9637 objfile_compunits.
9638 * objfiles.c (objfile_relocate1): Use objfile_compunits.
9639
9640 2019-01-09 Tom Tromey <tom@tromey.com>
9641
9642 * symtab.c (search_symbols)
9643 (default_collect_symbol_completion_matches_break_on): Use
9644 objfile_msymbols.
9645 * ada-lang.c (ada_lookup_simple_minsym)
9646 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9647 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9648 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9649 objfile_msymbols.
9650 * coffread.c (coff_symfile_read): Use objfile_msymbols.
9651 * symmisc.c (dump_msymbols): Use objfile_msymbols.
9652 * objc-lang.c (find_methods): Use objfile_msymbols.
9653 (info_selectors_command, info_classes_command): Likewise.
9654 * stabsread.c (scan_file_globals): Use objfile_msymbols.
9655 * objfiles.h (class objfile_msymbols): New.
9656 (ALL_OBJFILE_MSYMBOLS): Remove.
9657 (ALL_MSYMBOLS): Remove.
9658
9659 2019-01-09 Tom Tromey <tom@tromey.com>
9660
9661 * common/next-iterator.h (next_adapter): Add Iterator template
9662 parameter.
9663 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9664 (class all_objfiles_safe): New.
9665 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9666 * objfiles.c (put_objfile_before): Update comment.
9667 (add_separate_debug_objfile): Likewise.
9668 (free_all_objfiles): Use all_objfiles_safe.
9669 (objfile_purge_solibs): Likewise.
9670
9671 2019-01-09 Tom Tromey <tom@tromey.com>
9672
9673 * symtab.c (iterate_over_symtabs, matching_obj_sections)
9674 (expand_symtab_containing_pc, lookup_static_symbol)
9675 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9676 (find_symbol_at_address, find_line_symtab, find_main_name): Use
9677 all_objfiles.
9678 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9679 * breakpoint.c (create_overlay_event_breakpoint)
9680 (create_longjmp_master_breakpoint)
9681 (create_std_terminate_master_breakpoint)
9682 (create_exception_master_breakpoint): Use all_objfiles.
9683 * linux-thread-db.c (try_thread_db_load_from_pdir)
9684 (has_libpthread): Use all_objfiles.
9685 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9686 * linespec.c (iterate_over_all_matching_symtabs)
9687 (search_minsyms_for_name): Use all_objfiles.
9688 * maint.c (maintenance_info_sections): Use all_objfiles.
9689 * main.c (captured_main_1): Use all_objfiles.
9690 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9691 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9692 * guile/scm-pretty-print.c
9693 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9694 * solib-spu.c (append_ocl_sos): Use all_objfiles.
9695 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9696 (maintenance_print_msymbols): Use all_objfiles.
9697 * source.c (select_source_symtab): Use all_objfiles.
9698 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9699 * symfile.c (remove_symbol_file_command)
9700 (expand_symtabs_matching, map_symbol_filenames): Use
9701 all_objfiles.
9702 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9703 all_objfiles.
9704 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9705 * objc-lang.c (find_methods): Use all_objfiles.
9706 * objfiles.c (have_partial_symbols, have_full_symbols)
9707 (have_minimal_symbols, qsort_cmp)
9708 (default_iterate_over_objfiles_in_search_order): Use
9709 all_objfiles.
9710 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9711 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9712 (maintenance_check_psymtabs): Use all_objfiles.
9713 (ALL_PSYMTABS): Remove.
9714 * compile/compile-object-run.c (do_module_cleanup): Use
9715 all_objfiles.
9716 * blockframe.c (find_pc_partial_function): Use all_objfiles.
9717 * cp-support.c (add_symbol_overload_list_qualified): Use
9718 all_objfiles.
9719 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9720 Use all_objfiles.
9721 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9722 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9723 all_objfiles.
9724 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9725 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9726 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9727 Uses all_objfiles.
9728 * solib.c (solib_read_symbols): Use all_objfiles
9729
9730 2019-01-09 Tom Tromey <tom@tromey.com>
9731
9732 * probe.c (parse_probes_in_pspace): Use all_objfiles.
9733 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9734 all_objfiles.
9735 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9736 * symmisc.c (print_symbol_bcache_statistics)
9737 (print_objfile_statistics, maintenance_print_objfiles)
9738 (maintenance_info_symtabs, maintenance_check_symtabs)
9739 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9740 all_objfiles.
9741 * source.c (forget_cached_source_info): Use all_objfiles.
9742 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9743 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9744 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9745 * objfiles.c (update_section_map): Use all_objfiles.
9746 (shared_objfile_contains_address_p): Likewise.
9747 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9748 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9749
9750 2019-01-09 Tom Tromey <tom@tromey.com>
9751
9752 * common/next-iterator.h: New file.
9753 * objfiles.h (class all_objfiles): New.
9754 (struct objfile_iterator): New.
9755
9756 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9757
9758 * NEWS: Move the description of the changed "frame", "select-frame",
9759 and "info frame" commands to the Changed commands section.
9760
9761 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
9762
9763 * gdbtypes.c (check_stub_method_group): Remove handling of old
9764 mangling schemes.
9765 * linespec.c (find_methods): Likewise.
9766 * stabsread.c (read_member_functions): Likewise.
9767 * valops.c (search_struct_method): Likewise.
9768 (value_struct_elt_for_reference): Likewise.
9769 * NEWS: Mention this change.
9770
9771 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
9772
9773 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9774 print_source_lines.
9775 * source.c (print_source_lines_base): Update line number check.
9776 (print_source_lines): New function.
9777 (source_lines_range::source_lines_range): New function.
9778 * source.h (class source_lines_range): New class.
9779 (print_source_lines): New declaration.
9780
9781 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9782
9783 * linespec.c (linespec_state_destructor): Free self->canonical_names.
9784
9785 2019-01-08 Tom Tromey <tom@tromey.com>
9786 Simon Marchi <simon.marchi@ericsson.com>
9787
9788 PR gdb/24060
9789 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9790 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9791 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9792 * f-exp.y (DOLLAR_VARIABLE): Likewise.
9793 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9794 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9795
9796 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
9797
9798 * source.c (select_source_symtab): Move header comment to
9799 declaration in source.h.
9800 (forget_cached_source_info_for_objfile): Likewise.
9801 (forget_cached_source_info): Likewise.
9802 (identify_source_line): Likewise.
9803 * source.h (identify_source_line): Move declaration from symtab.h
9804 and add comment from source.c
9805 (print_source_lines): Likewise.
9806 (forget_cached_source_info_for_objfile): Likewise.
9807 (forget_cached_source_info): Likewise.
9808 (select_source_symtab): Likewise.
9809 (enum print_source_lines_flag): Move definition from symtab.h.
9810 * symtab.h (identify_source_line): Move declaration to source.h.
9811 (print_source_lines): Likewise.
9812 (forget_cached_source_info_for_objfile): Likewise.
9813 (forget_cached_source_info): Likewise.
9814 (select_source_symtab): Likewise.
9815 (enum print_source_lines_flag): Move definition to source.h.
9816 * tui/tui-hooks.c: Add 'source.h' include.
9817
9818 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
9819
9820 * source.c (print_source_lines_base): Handle requests to print
9821 reverse line number sequences, and guard against empty lines
9822 string.
9823
9824 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
9825
9826 * source.c (print_source_lines_base): Fix skip of '\r' if next
9827 character is '\n'.
9828
9829 2019-01-06 Tom Tromey <tom@tromey.com>
9830
9831 * c-exp.y (struct c_parse_state) <macro_original_text,
9832 expansion_obstack>: New member.
9833 (macro_original_text, expansion_obstack): Remove globals.
9834 (scan_macro_expansion, scanning_macro_expansion)
9835 (finished_macro_expansion): Update.
9836 (scan_macro_cleanup): Remove.
9837 (yylex, c_parse): Update.
9838
9839 2019-01-06 Tom Tromey <tom@tromey.com>
9840
9841 * c-exp.y (struct c_parse_state) <strings>: New member.
9842 (operator_stoken): Update.
9843
9844 2019-01-06 Tom Tromey <tom@tromey.com>
9845
9846 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
9847 (union type_stack_elt) <typelist_val>: Now a pointer to
9848 std::vector.
9849 (type_stack_cleanup): Don't declare.
9850 (push_typelist): Update.
9851 * parse.c (pop_typelist): Return a std::vector.
9852 (push_typelist): Take a std::vector.
9853 (follow_types): Update. Do not free args.
9854 (type_stack_cleanup): Remove.
9855 * c-exp.y (struct c_parse_state): New.
9856 (cpstate): New global.
9857 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9858 (nonempty_typelist): Update.
9859 (func_mod): Create a new vector.
9860 (c_parse): Create a c_parse_state.
9861 (check_parameter_typelist): Do not delete params.
9862 (function_method): Update. Do not delete type_list.
9863
9864 2019-01-06 Tom Tromey <tom@tromey.com>
9865
9866 PR gdb/28155:
9867 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9868 check_typedef.
9869 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9870 (print_return_value): Likewise.
9871
9872 2019-01-05 Tom Tromey <tom@tromey.com>
9873
9874 * contrib/cleanup_check.py: Remove.
9875 * contrib/gcc-with-excheck: Remove.
9876 * contrib/exsummary.py: Remove.
9877 * contrib/excheck.py: Remove.
9878
9879 2019-01-05 Joel Brobecker <brobecker@adacore.com>
9880
9881 * thread.c (delete_thread_1): Add gdb_assert that THR is not
9882 NULL. Initialize tpprev to NULL instead of assigning it
9883 to NULL on the next statement.
9884 * windows-nat.c (windows_delete_thread): Remove check for
9885 main_thread_id before printing thread exit notifications.
9886 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9887 Remove thread ID check against main_thread_id.
9888 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9889 windows_delete_thread.
9890 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9891
9892 2019-01-04 Tom Tromey <tom@tromey.com>
9893
9894 * compile/compile.c (_initialize_compile): Use upper case for
9895 metasyntactic variables.
9896 * symmisc.c (_initialize_symmisc): Use upper case for
9897 metasyntactic variables.
9898 * psymtab.c (_initialize_psymtab): Use upper case for
9899 metasyntactic variables.
9900 * demangle.c (demangle_command): Use upper case for metasyntactic
9901 variables.
9902 (_initialize_demangler): Likewise.
9903 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9904 variables.
9905
9906 2019-01-03 Tom Tromey <tom@tromey.com>
9907
9908 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9909
9910 2019-01-03 Tom Tromey <tom@tromey.com>
9911
9912 * python/py-symtab.c (salpy_str): Update.
9913 (struct salpy_sal_object) <symtab>: Now a PyObject.
9914 (salpy_dealloc): Update.
9915 (del_objfile_sal): Use gdbpy_ref.
9916
9917 2019-01-03 Tom Tromey <tom@tromey.com>
9918
9919 * python/py-type.c (convert_field): Use new_reference. Return
9920 gdbpy_ref.
9921 (make_fielditem): Return gdbpy_ref.
9922 (typy_fields): Update.
9923 (typy_getitem): Update.
9924 (field_name): Return gdbpy_ref. Use new_reference.
9925 (typy_iterator_iternext): Update.
9926
9927 2019-01-03 Tom Tromey <tom@tromey.com>
9928
9929 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9930
9931 2019-01-03 Tom Tromey <tom@tromey.com>
9932
9933 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9934 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9935 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9936 (pspy_set_frame_filters, pspy_set_frame_unwinders)
9937 (pspy_set_type_printers): Likewise.
9938 * python/py-function.c (fnpy_init): Use gdbpy_ref.
9939 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9940 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9941 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9942 (objfpy_set_type_printers): Likewise.
9943
9944 2019-01-03 Tom Tromey <tom@tromey.com>
9945
9946 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9947 (gdbpy_print_stack): Use gdbpy_err_fetch.
9948 * python/python-internal.h (class gdbpy_err_fetch): New class.
9949 (class gdbpy_enter) <m_error_type, m_error_value,
9950 m_error_traceback>: Remove.
9951 <m_error>: New member.
9952 (gdbpy_exception_to_string): Don't declare.
9953 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9954 * python/py-value.c (convert_value_from_python): Use
9955 gdbpy_err_fetch.
9956 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9957 gdbpy_exception_to_string.
9958 (gdbpy_handle_exception): Use gdbpy_err_fetch.
9959 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9960 gdbpy_err_fetch.
9961
9962 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
9963
9964 * linux-nat.c (delete_lwp_cleanup): Delete.
9965 (struct lwp_deleter): New struct.
9966 (lwp_info_up): New typedef.
9967 (linux_nat_target::follow_fork): Delete cleanup, and make use of
9968 lwp_info_up.
9969
9970 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
9971
9972 * linux-fork.c (class scoped_switch_fork_info): New class.
9973 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9974
9975 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
9976
9977 * valops.c (find_overload_match): Remove use of null_cleanup, and
9978 calls to do_cleanups.
9979
9980 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
9981
9982 * compile/compile-cplus-types.c
9983 (compile_cplus_instance::decl_name): Handle changes to
9984 cp_func_name.
9985 * cp-support.c (cp_func_name): Update header comment, update
9986 return type.
9987 * cp-support.h (cp_func_name): Update return type in declaration.
9988 * valops.c (find_overload_match): Move temp_func local to top
9989 level of function and change its type. Use temp_func to hold and
9990 delete temporary string obtained from cp_func_name.
9991
9992 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
9993
9994 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9995 gdb::char_vector, remove cleanup, and update uses of `msg`.
9996
9997 2019-01-03 Jim Wilson <jimw@sifive.com>
9998
9999 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10000
10001 2019-01-02 Tom Tromey <tom@tromey.com>
10002
10003 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10004 (tdesc_parse_xml): Remove cleanups.
10005 * target-descriptions.h (make_cleanup_free_target_description):
10006 Don't declare.
10007 (target_desc_deleter): New struct.
10008 (target_desc_up): New typedef.
10009 * target-descriptions.c (target_desc_deleter::operator()): Rename
10010 from free_target_description.
10011 (make_cleanup_free_target_description): Remove.
10012
10013 2019-01-02 Tom Tromey <tom@tromey.com>
10014
10015 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
10016 constructor, destructor.
10017 (linespec_parser): Remove typedef.
10018 (~linespec_parser): Rename from linespec_parser_delete.
10019 (linespec_lex_to_end, linespec_complete_label)
10020 (linespec_complete): Update.
10021 (decode_line_full): Remove cleanups.
10022 (decode_line_1): Update.
10023
10024 2019-01-02 Tom Tromey <tom@tromey.com>
10025
10026 * python/python-internal.h (inferior_to_inferior_object): Change
10027 return type.
10028 * python/py-exitedevent.c (create_exited_event_object): Update.
10029 * python/py-inferior.c (inferior_to_inferior_object): Return
10030 gdbpy_ref.
10031 (python_new_inferior, python_inferior_deleted)
10032 (thread_to_thread_object, delete_thread_object)
10033 (build_inferior_list, gdbpy_selected_inferior): Update.
10034 * python/py-infthread.c (create_thread_object): Update. Also fail
10035 if inferior_to_inferior_object fails.
10036
10037 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
10038
10039 * inferior.h (class inferior) <displaced_step_state>: New field.
10040 * infrun.h (struct displaced_step_state): Move here from
10041 infrun.c. Initialize fields, add constructor.
10042 <inf>: Remove field.
10043 <reset>: New method.
10044 * infrun.c (struct displaced_step_inferior_state): Move to
10045 infrun.h.
10046 (displaced_step_inferior_states): Remove.
10047 (get_displaced_stepping_state): Adust.
10048 (displaced_step_in_progress_any_inferior): Adjust.
10049 (displaced_step_in_progress_thread): Adjust.
10050 (displaced_step_in_progress): Adjust.
10051 (add_displaced_stepping_state): Remove.
10052 (get_displaced_step_closure_by_addr): Adjust.
10053 (remove_displaced_stepping_state): Remove.
10054 (infrun_inferior_exit): Call displaced_step_state.reset.
10055 (use_displaced_stepping): Don't check for NULL.
10056 (displaced_step_prepare_throw): Call
10057 get_displaced_stepping_state.
10058 (displaced_step_fixup): Don't check for NULL.
10059 (prepare_for_detach): Don't check for NULL.
10060
10061 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10062
10063 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10064 in case of call that did not complete.
10065
10066 2019-01-02 Andrey Utkin <autkin@undo.io>
10067
10068 * symfile.c (find_separate_debug_file): Fix search of debug files for
10069 remote debuggee.
10070
10071 2019-01-02 Tom Tromey <tom@tromey.com>
10072
10073 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10074 indentation.
10075 * python/py-frame.c (frapy_older): Remove cast.
10076 (frapy_newer): Likewise.
10077 * python/py-breakpoint.c (local_setattro): Remove cast.
10078 * python/py-arch.c (archpy_name): Remove local variable.
10079 * python/py-type.c (gdbpy_lookup_type): Remove cast.
10080
10081 2019-01-02 Joel Brobecker <brobecker@adacore.com>
10082
10083 * unittests/basic_string_view/element_access/char/empty.cc:
10084 Fix year range in copyright header.
10085
10086 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
10087
10088 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10089 Delete.
10090 <operator==>: Update with for removed field.
10091 <hash>: Likewise.
10092 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10093 <isa_features>: ...this.
10094 <abi_features>: New field.
10095 (riscv_isa_flen): Update comment.
10096 (riscv_abi_xlen): New declaration.
10097 (riscv_abi_flen): New declaration.
10098 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10099 isa_features.
10100 (riscv_abi_xlen): New function.
10101 (riscv_isa_flen): Update to get answer from isa_features.
10102 (riscv_abi_flen): New function.
10103 (riscv_has_fp_abi): Update to get answer from abi_features.
10104 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10105 xlen and flen.
10106 (riscv_call_info) <xlen, flen>: Update comment.
10107 (riscv_call_arg_struct): Remove invalid assertions
10108 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10109 is removed.
10110 (riscv_gdbarch_init): Gather isa features and abi features
10111 separately, ensure both match on the gdbarch when reusing an old
10112 gdbarch. Relax an error check to allow 32-bit abi float to run on
10113 a target with 64-bit float hardware.
10114
10115 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10116
10117 * source.c (search_command_helper): Stop reverse search
10118 when line 1 has been searched.
10119
10120 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10121
10122 * record-full.c (record_full_base_target::close): Rewrite
10123 record_full_core_buf_list free logic.
10124
10125 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10126
10127 * break-catch-syscall.c (print_one_catch_syscall): xfree
10128 the last text.
10129
10130 2019-01-01 Joel Brobecker <brobecker@adacore.com>
10131
10132 * top.c (print_gdb_version): Update Copyright year in version
10133 message.
10134
10135 2019-01-01 Joel Brobecker <brobecker@adacore.com>
10136
10137 Update copyright year range in all GDB files.
10138
10139 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
10140
10141 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10142
10143 For older changes see ChangeLog-2018.
10144 \f
10145 Local Variables:
10146 mode: change-log
10147 left-margin: 8
10148 fill-column: 74
10149 version-control: never
10150 coding: utf-8
10151 End:
10152
This page took 0.264919 seconds and 5 git commands to generate.