gdb/ChangeLog

   1 2020-06-30  Tom Tromey  <tromey@adacore.com>
   2
   3         * dwarf2/read.c (quirk_rust_enum): Correctly call
   4         alloc_rust_variant for default-less enum.
   5
   6 2020-06-30  Tom Tromey  <tromey@adacore.com>
   7
   8         PR build/26183:
   9         * ada-lang.c (ada_lookup_name_info::ada_lookup_name_info): Use
  10         gdb::to_string.
  11
  12 2020-06-29  Simon Marchi  <simon.marchi@efficios.com>
  13
  14         * gdbarch.sh (displaced_step_copy_insn): Update doc.
  15         * gdbarch.h: Re-generate.
  16
  17 2020-06-28  Tom Tromey  <tom@tromey.com>
  18
  19         * command.h (cmd_types): Remove.
  20         (cmd_type): Don't declare.
  21         * cli/cli-decode.h (enum cmd_types): Uncomment.  No longer a
  22         typedef.
  23         * cli/cli-cmds.c (setting_cmd): Use cmd->type directly.
  24         * cli/cli-decode.c (cmd_type): Remove.
  25
  26 2020-06-27  Pedro Alves  <palves@redhat.com>
  27
  28         * fork-child.c (prefork_hook): Adjust.
  29         * infcmd.c (set_inferior_io_terminal, get_inferior_io_terminal):
  30         Delete.
  31         (set_inferior_tty_command, show_inferior_tty_command): Adjust.
  32         * inferior.c (inferior::set_tty, inferior::tty): New methods.
  33         * inferior.h (set_inferior_io_terminal, get_inferior_io_terminal):
  34         Remove declarations.
  35         (struct inferior) <set_tty, tty>: New methods.
  36         (struct inferior) <terminal>: Rename to ...
  37         (struct inferior) <m_terminal>: ... this and make private.
  38         * main.c (captured_main_1): Adjust.
  39         * mi/mi-cmd-env.c (mi_cmd_inferior_tty_set): Adjust.
  40         (mi_cmd_inferior_tty_show): Adjust.
  41         * nto-procfs.c (nto_procfs_target::create_inferior): Adjust.
  42         * windows-nat.c (windows_nat_target::create_inferior): Adjust.
  43
  44 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
  45
  46         * configure.ac: Add --enable-libctf: handle --disable-static
  47         properly.
  48         * acinclude.m4: sinclude ../config/enable.m4.
  49         * Makefile.in (aclocal_m4_deps): Adjust accordingly.
  50         (LIBCTF): Substitute in.
  51         (CTF_DEPS): New, likewise.
  52         (CLIBS): libctf needs symbols from libbfd: move earlier.
  53         (CDEPS): Use CTF_DEPS, not LIBCTF, now LIBCTF can include rpath
  54         flags.
  55         * ctfread.c: Surround in ENABLE_LIBCTF.
  56         (elfctf_build_psymtabs) [!ENABLE_LIBCTF]: New stub.
  57         * configure: Regenerate.
  58         * config.in: Likewise.
  59
  60 2020-06-25  Simon Marchi  <simon.marchi@efficios.com>
  61
  62         * infcmd.c (set_inferior_io_terminal): Use make_unique_xstrdup.
  63
  64 2020-06-25  Simon Marchi  <simon.marchi@efficios.com>
  65
  66         * inferior.h (struct inferior) <terminal>: Change type to
  67         gdb::unique_xmalloc_ptr<char>.
  68         * inferior.c (inferior::~inferior): Don't free inf->terminal.
  69         * infcmd.c (set_inferior_io_terminal): Don't free terminal
  70         field, adjust to unique pointer.
  71         (get_inferior_io_terminal): Adjust to unique pointer.
  72
  73 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
  74
  75         * riscv-tdep.c (riscv_print_registers_info): Loop over all
  76         registers, not just the known core set of registers.
  77
  78 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
  79
  80         * riscv-tdep.c (riscv_register_name): Return NULL for duplicate
  81         fflags, frm, and fcsr registers.
  82         (riscv_register_reggroup_p): Remove unknown CSRs from save and
  83         restore groups.
  84         (riscv_tdesc_unknown_reg): New function.
  85         (riscv_gdbarch_init): Pass riscv_tdesc_unknown_reg to
  86         tdesc_use_registers.
  87         * riscv-tdep.h (struct gdbarch_tdep): Add
  88         unknown_csrs_first_regnum, unknown_csrs_count,
  89         duplicate_fflags_regnum, duplicate_frm_regnum, and
  90         duplicate_fcsr_regnum fields.
  91
  92 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
  93
  94         * target-descriptions.c (tdesc_use_registers): Add new parameter a
  95         callback, use the callback (when not null) to help number unknown
  96         registers.
  97         * target-descriptions.h (tdesc_unknown_register_ftype): New typedef.
  98         (tdesc_use_registers): Add extra parameter to declaration.
  99
 100 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 101
 102         * riscv-tdep.c (value_of_riscv_user_reg): Moved to here from later
 103         in the file.
 104         (class riscv_pending_register_alias): Likewise.
 105         (riscv_register_feature::register_info): Change 'required_p' field
 106         to 'required', and change its type.  Add 'check' member function.
 107         (riscv_register_feature::register_info::check): Define new member
 108         function.
 109         (riscv_xreg_feature): Change initialisation of 'required' field.
 110         (riscv_freg_feature): Likewise.
 111         (riscv_virtual_feature): Likewise.
 112         (riscv_csr_feature): Likewise.
 113         (riscv_check_tdesc_feature): Take extra parameter, the csr
 114         tdesc_feature, rewrite the function to use the new
 115         riscv_register_feature::register_info::check function.
 116         (riscv_gdbarch_init): Pass the csr tdesc_feature where needed.
 117
 118 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 119
 120         * features/Makefile: Remove all references to the deleted files
 121         below.
 122         * features/riscv/32bit-csr.c: Deleted.
 123         * features/riscv/32bit-csr.xml: Deleted.
 124         * features/riscv/64bit-csr.c: Deleted.
 125         * features/riscv/64bit-csr.xml: Deleted.
 126         * features/riscv/rebuild-csr-xml.sh: Deleted.
 127
 128 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 129
 130         * riscv-tdep.c (struct riscv_register_feature::register_info): Fix
 131         whitespace error for declaration of names member variable.
 132         (struct riscv_register_feature): Add new prefer_first_name member
 133         variable, and fix whitespace error in declaration of registers.
 134         (riscv_xreg_feature): Initialize prefer_first_name field.
 135         (riscv_freg_feature): Likewise.
 136         (riscv_virtual_feature): Likewise.
 137         (riscv_csr_feature): Likewise.
 138         (riscv_register_name): Expand on comments.  Remove register name
 139         modifications for CSR and virtual registers.
 140
 141 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 142
 143         * riscv-tdep.c (struct riscv_register_feature): Fix whitespace
 144         errors.
 145
 146 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 147
 148         * riscv-tdep.c (riscv_create_csr_aliases): Handle csr aliases from
 149         riscv-opc.h.
 150         (class riscv_pending_register_alias): New class.
 151         (riscv_check_tdesc_feature): Take vector of pending aliases and
 152         populate it as appropriate.
 153         (riscv_setup_register_aliases): Delete.
 154         (riscv_gdbarch_init): Create vector of pending aliases and pass it
 155         to riscv_check_tdesc_feature in all cases.  Use the vector to
 156         create the register aliases.
 157
 158 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 159
 160         * sol2-tdep.c (sol2_static_transform_name): Remove.
 161         (sol2_init_abi): Don't register it.
 162         * gdbarch.sh (static_transform_name): Remove.
 163         * gdbarch.c, gdbarch.h: Regenerate.
 164
 165         * dbxread.c (read_dbx_symtab) <'S'>: Remove call to
 166         gdbarch_static_transform_name.
 167         * mdebugread.c (parse_partial_symbols) <'S'>: Likewise.
 168         * stabsread.c (define_symbol) <'X'>: Remove.
 169         (define_symbol) <'S'>: Remove gdbarch_static_transform_name
 170         handling.
 171         <'V'>: Likewise.
 172         * xcoffread.c (scan_xcoff_symtab): Remove gdbarch.
 173         <'S'>: Remove call to gdbarch_static_transform_name.
 174
 175 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 176
 177         * procfs.c (procfs_pre_trace): New function.
 178         (procfs_target::create_inferior): Pass it to fork_inferior.
 179
 180 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 181
 182         * configure.tgt <sparc-*-linux*> (gdb_target_obs): Remove
 183         sparc-sol2-tdep.o, sol2-tdep.o, sparc64-sol2-tdep.o.
 184         <sparc64-*-linux*> (gdb_target_obs): Remove sparc64-sol2-tdep.o,
 185         sol2-tdep.o, sparc-sol2-tdep.o.
 186         * sparc-sol2-tdep.c (sparc32_sol2_init_abi): Make static.
 187         * sparc-tdep.h (sparc32_sol2_init_abi): Remove.
 188         * sparc64-sol2-tdep.c (sparc64_sol2_init_abi): Make static.
 189         * sparc64-tdep.h (sparc64_sol2_init_abi): Remove.
 190
 191 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 192
 193         * amd64-sol2-tdep.c (amd64_sol2_sigtramp_p): Remove.
 194         (amd64_sol2_init_abi): Use sol2_sigtramp_p.
 195         Call sol2_init_abi.
 196         Remove calls to set_gdbarch_skip_solib_resolver,
 197         set_gdbarch_core_pid_to_str.
 198         * i386-sol2-tdep.c (i386_sol2_sigtramp_p): Remove.
 199         (i386_sol2_static_transform_name): Remove.
 200         (i386_sol2_init_abi): Call sol2_init_abi.
 201         Remove calls to set_gdbarch_sofun_address_maybe_missing,
 202         set_gdbarch_static_transform_name,
 203         set_gdbarch_skip_solib_resolver, set_gdbarch_core_pid_to_str.
 204         Use sol2_sigtramp_p.
 205         * sol2-tdep.c (sol2_pc_in_sigtramp): New function.
 206         (sol2_sigtramp_p): New function.
 207         (sol2_static_transform_name): New function.
 208         (sol2_skip_solib_resolver, sol2_core_pid_to_str): Make static.
 209         (sol2_init_abi): New function.
 210         * sol2-tdep.h (sol2_sigtramp_p, sol2_init_abi): Declare.
 211         (sol2_skip_solib_resolver, sol2_core_pid_to_str): Remove.
 212         * sparc-sol2-tdep.c (sparc_sol2_pc_in_sigtramp): Remove.
 213         (sparc32_sol2_sigtramp_frame_sniffer): Just call sol2_sigtramp_p.
 214         (sparc_sol2_static_transform_name): Remove.
 215         (sparc32_sol2_init_abi): Call sol2_init_abi.
 216         Remove calls to set_gdbarch_sofun_address_maybe_missing,
 217         set_gdbarch_static_transform_name,
 218         set_gdbarch_skip_solib_resolver,
 219         set_gdbarch_core_pid_to_str.
 220         * sparc-tdep.h (sparc_sol2_pc_in_sigtramp)
 221         (sparc_sol2_static_transform_name): Remove
 222         * sparc64-sol2-tdep.c (sparc64_sol2_sigtramp_frame_sniffer): Just
 223         call sol2_sigtramp_p.
 224         (sparc64_sol2_init_abi): Call sol2_init_abi.
 225         Remove calls to set_gdbarch_sofun_address_maybe_missing,
 226         set_gdbarch_static_transform_name,
 227         set_gdbarch_skip_solib_resolver, set_gdbarch_core_pid_to_str.
 228
 229 2020-06-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 230
 231         * symfile-add-flags.h: New flag SYMFILE_ALWAYS_CONFIRM.
 232         * exec.c (validate_exec_file): If from_tty, set both
 233         SYMFILE_VERBOSE (== from_tty) and SYMFILE_ALWAYS_CONFIRM.
 234         * symfile.c (symbol_file_add_with_addrs): if always_confirm
 235         and from_tty, unconditionally ask a confirmation.
 236
 237 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 238
 239         * target-descriptions.c (tdesc_architecture_name): Protect against
 240         NULL pointer dereference.
 241         (maint_print_xml_tdesc_cmd): New function.
 242         (_initialize_target_descriptions): Register new 'maint print
 243         xml-tdesc' command and give it the filename completer.
 244         * NEWS: Mention new 'maint print xml-tdesc' command.
 245
 246 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 247
 248         * target-descriptions.c (class tdesc_compatible_info): New class.
 249         (struct target_desc): Change type of compatible vector.
 250         (tdesc_compatible_p): Update for change in type of
 251         target_desc::compatible.
 252         (tdesc_compatible_info_list): New function.
 253         (tdesc_compatible_info_arch_name): New function.
 254         (tdesc_add_compatible): Update for change in type of
 255         target_desc::compatible.
 256         (print_c_tdesc::visit_pre): Likewise.
 257
 258 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 259
 260         * target-descriptions.c (print_c_tdesc::print_c_tdesc): Change
 261         whitespace to underscore.
 262         (maint_print_c_tdesc_cmd): Use fake filename for target
 263         descriptions that came from the target.
 264         (_initialize_target_descriptions): Add filename command completion
 265         for 'maint print c-tdesc'.
 266
 267 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
 268
 269         * dwarf2/loc.c (decode_debug_loclists_addresses): Add empty
 270         lines.
 271
 272 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
 273
 274         * dwarf2/loc.c (decode_debug_loc_dwo_addresses): Add empty
 275         lines.
 276         (dwarf2_find_location_expression): Likewise.
 277         (call_site_parameter_matches): Likewise.
 278         (dwarf2_compile_expr_to_ax): Likewise.
 279         (disassemble_dwarf_expression): Likewise.
 280         (loclist_describe_location): Likewise.
 281
 282 2020-06-23  Pedro Alves  <palves@redhat.com>
 283
 284         * gdbarch-selftests.c: Don't include inferior.h, gdbthread.h or
 285         progspace-and-thread.h.  Include scoped-mock-context.h instead.
 286         (register_to_value_test): Use scoped_mock_context.
 287         * regcache.c: Include "scoped-mock-context.h".
 288         (cooked_read_test): Don't error out if a target is already pushed.
 289         Use scoped_mock_context.  Adjust.
 290         * scoped-mock-context.h: New file.
 291
 292 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 293
 294         * ada-lang.c (ada_language_data): Delete la_is_string_type_p
 295         initializer.
 296         (ada_language::is_string_type_p): New member function.
 297         * c-lang.c (c_language_data): Delete la_is_string_type_p
 298         initializer.
 299         (cplus_language_data): Likewise.
 300         (asm_language_data): Likewise.
 301         (minimal_language_data): Likewise.
 302         * d-lang.c (d_language_data): Likewise.
 303         * f-lang.c (f_is_string_type_p): Delete function, implementation
 304         moved to f_language::is_string_type_p.
 305         (f_language_data): Delete la_is_string_type_p initializer.
 306         (f_language::is_string_type_p): New member function,
 307         implementation from f_is_string_type_p.
 308         * go-lang.c (go_is_string_type_p): Delete function, implementation
 309         moved to go_language::is_string_type_p.
 310         (go_language_data): Delete la_is_string_type_p initializer.
 311         (go_language::is_string_type_p): New member function,
 312         implementation from go_is_string_type_p.
 313         * language.c (language_defn::is_string_type_p): Define new member
 314         function.
 315         (default_is_string_type_p): Make static, add comment copied from
 316         header file.
 317         (unknown_language_data): Delete la_is_string_type_p initializer.
 318         (unknown_language::is_string_type_p): New member function.
 319         (auto_language_data): Delete la_is_string_type_p initializer.
 320         (auto_language::is_string_type_p): New member function.
 321         * language.h (language_data): Delete la_is_string_type_p field.
 322         (language_defn::is_string_type_p): Declare new function.
 323         (default_is_string_type_p): Delete desclaration, move comment to
 324         definition.
 325         * m2-lang.c (m2_is_string_type_p): Delete function, implementation
 326         moved to m2_language::is_string_type_p.
 327         (m2_language_data): Delete la_is_string_type_p initializer.
 328         (m2_language::is_string_type_p): New member function,
 329         implementation from m2_is_string_type_p.
 330         * objc-lang.c (objc_language_data): Delete la_is_string_type_p
 331         initializer.
 332         * opencl-lang.c (opencl_language_data): Likewise.
 333         * p-lang.c (pascal_is_string_type_p): Delete function,
 334         implementation moved to pascal_language::is_string_type_p.
 335         (pascal_language_data): Delete la_is_string_type_p initializer.
 336         (pascal_language::is_string_type_p): New member function,
 337         implementation from pascal_is_string_type_p.
 338         * rust-lang.c (rust_is_string_type_p): Delete function,
 339         implementation moved to rust_language::is_string_type_p.
 340         (rust_language_data): Delete la_is_string_type_p initializer.
 341         (rust_language::is_string_type_p): New member function,
 342         implementation from rust_is_string_type_p.
 343         * valprint.c (val_print_scalar_or_string_type_p): Update call to
 344         is_string_type_p.
 345
 346 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 347
 348         * ada-lang.c (ada_language_data): Delete la_print_typedef
 349         initializer.
 350         (ada_language::print_typedef): New member function.
 351         * c-lang.c (c_language_data): Delete la_print_typedef initializer.
 352         (cplus_language_data): Likewise.
 353         (asm_language_data): Likewise.
 354         (minimal_language_data): Likewise.
 355         * d-lang.c (d_language_data): Likewise.
 356         * f-lang.c (f_language_data): Likewise.
 357         (f_language::print_typedef): New member function.
 358         * go-lang.c (go_language_data): Delete la_print_typedef
 359         initializer.
 360         * language.c (language_defn::print_typedef): Define member
 361         function.
 362         (unknown_language_data): Delete la_print_typedef initializer.
 363         (unknown_language::print_typedef): New member function.
 364         (auto_language_data): Delete la_print_typedef initializer.
 365         (auto_language::print_typedef): New member function.
 366         * language.h (language_data): Delete la_print_typedef field.
 367         (language_defn::print_typedef): Declare new member function.
 368         (LA_PRINT_TYPEDEF): Update call to print_typedef.
 369         (default_print_typedef): Delete declaration.
 370         * m2-lang.c (m2_language_data): Delete la_print_typedef
 371         initializer.
 372         (m2_language::print_typedef): New member function.
 373         * objc-lang.c (objc_language_data): Delete la_print_typedef
 374         initializer.
 375         * opencl-lang.c (opencl_language_data): Likewise.
 376         * p-lang.c (pascal_language_data): Likewise.
 377         (pascal_language::print_typedef): New member function.
 378         * rust-lang.c (rust_print_typedef): Delete function,
 379         implementation moved to rust_language::print_typedef.
 380         (rust_language): Delete la_print_typedef initializer.
 381         (rust_language::print_typedef): New member function,
 382         implementation from rust_print_typedef.
 383         * typeprint.c (default_print_typedef): Delete.
 384
 385 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 386
 387         * ada-lang.c (ada_language_data): Delete la_printstr initializer.
 388         (ada_language::printstr): New member function.
 389         * c-lang.c (c_language_data): Delete la_printstr initializer.
 390         (cplus_language_data): Likewise.
 391         (asm_language_data): Likewise.
 392         (minimal_language_data): Likewise.
 393         * d-lang.c (d_language_data): Likewise.
 394         * f-lang.c (f_printstr): Rename to f_language::printstr.
 395         (f_language_data): Delete la_printstr initializer.
 396         (f_language::printstr): New member function, implementation from
 397         f_printstr.
 398         * go-lang.c (go_language_data): Delete la_printstr initializer.
 399         * language.c (language_defn::printstr): Define new member
 400         function.
 401         (unk_lang_printstr): Delete.
 402         (unknown_language_data): Delete la_printstr initializer.
 403         (unknown_language::printstr): New member function.
 404         (auto_language_data): Delete la_printstr initializer.
 405         (auto_language::printstr): New member function.
 406         * language.h (language_data): Delete la_printstr field.
 407         (language_defn::printstr): Declare new member function.
 408         (LA_PRINT_STRING): Update call to printstr.
 409         * m2-lang.c (m2_printstr): Rename to m2_language::printstr.
 410         (m2_language_data): Delete la_printstr initializer.
 411         (m2_language::printstr): New member function, implementation from
 412         m2_printstr.
 413         * objc-lang.c (objc_language_data): Delete la_printstr
 414         initializer.
 415         * opencl-lang.c (opencl_language_data): Likewise.
 416         * p-lang.c (pascal_printstr): Rename to pascal_language::printstr.
 417         (pascal_language_data): Delete la_printstr initializer.
 418         (pascal_language::printstr): New member function, implementation
 419         from pascal_printstr.
 420         * p-lang.h (pascal_printstr): Delete declaration.
 421         * rust-lang.c (rust_printstr): Update header comment.
 422         (rust_language_data): Delete la_printstr initializer.
 423         (rust_language::printstr): New member function.
 424
 425 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 426
 427         * ada-lang.c (ada_language_data): Delete la_printchar initializer.
 428         (ada_language::printchar): New member function.
 429         * c-lang.c (c_language_data): Delete la_printchar initializer.
 430         (cplus_language_data): Likewise.
 431         (asm_language_data): Likewise.
 432         (minimal_language_data): Likewise.
 433         * d-lang.c (d_language_data): Likewise.
 434         * f-lang.c (f_printchar): Rename to f_language::printchar.
 435         (f_language_data): Delete la_printchar initializer.
 436         (f_language::printchar): New member function, implementation from
 437         f_printchar.
 438         * go-lang.c (go_language_data): Delete la_printchar initializer.
 439         * language.c (unk_lang_printchar): Delete.
 440         (language_defn::printchar): Define new member function.
 441         (unknown_language_data): Delete la_printchar initializer.
 442         (unknown_language::printchar): New member function.
 443         (auto_language_data): Delete la_printchar initializer.
 444         (auto_language::printchar): New member function.
 445         * language.h (language_data): Delete la_printchar field.
 446         (language_defn::printchar): Declare new member function.
 447         (LA_PRINT_CHAR): Update call to printchar.
 448         * m2-lang.c (m2_language_data): Delete la_printchar initializer.
 449         (m2_language::printchar): New member function.
 450         * objc-lang.c (objc_language_data): Delete la_printchar
 451         initializer.
 452         * opencl-lang.c (opencl_language_data): Likewise.
 453         * p-lang.c (pascal_language_data): Delete la_printchar
 454         initializer.
 455         (pascal_language::printchar): New member function.
 456         * rust-lang.c (rust_printchar): Rename to
 457         rust_language::printchar.
 458         (rust_language_data): Delete la_printchar initializer.
 459         (rust_language::printchar): New member function, implementation
 460         from rust_printchar.
 461
 462 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 463
 464         * ada-lang.c (emit_char): Renamed to ada_language::emitchar.
 465         (ada_language_data): Delete la_emitchar initializer.
 466         (ada_language::emitchar): New member function, implementation from
 467         emit_char.
 468         * c-lang.c (c_language_data): Delete la_emitchar initializer.
 469         (cplus_language_data): Likewise.
 470         (asm_language_data): Likewise.
 471         (minimal_language_data): Likewise.
 472         * d-lang.c (d_language_data): Likewise.
 473         * f-lang.c (f_emit_char): Rename to f_language::emitchar.
 474         (f_language_data): Delete la_emitchar initializer.
 475         (f_language::emitchar): New member function, implementation from
 476         f_emit_char.
 477         * go-lang.c (go_language_data): Delete la_emitchar initializer.
 478         * language.c (unk_lang_emit_char): Delete.
 479         (language_defn::emitchar): New member function definition.
 480         (unknown_language_data): Delete la_emitchar initializer.
 481         (unknown_language::emitchar): New member function.
 482         (auto_language_data): Delete la_emitchar initializer.
 483         (auto_language::emitchar): New member function.
 484         * language.h (language_data): Delete la_emitchar field.
 485         (language_defn::emitchar): New member field declaration.
 486         (LA_EMIT_CHAR): Update call to emitchar.
 487         * m2-lang.c (m2_emit_char): Rename to m2_language::emitchar.
 488         (m2_language_data): Delete la_emitchar initializer.
 489         (m2_language::emitchar): New member function, implementation from
 490         m2_emit_char.
 491         * objc-lang.c (objc_language_data): Delete la_emitchar
 492         initializer.
 493         * opencl-lang.c (opencl_language_data): Likewise.
 494         * p-lang.c (pascal_emit_char): Rename to pascal_language::emitchar.
 495         (pascal_language_data): Delete la_emitchar initializer.
 496         (pascal_language::emitchar): New member function, implementation
 497         from pascal_emit_char.
 498         * rust-lang.c (rust_emitchar): Rename to rust_language::emitchar.
 499         (rust_language_data): Delete la_emitchar initializer.
 500         (rust_language::emitchar): New member function, implementation
 501         from rust_emitchar.
 502
 503 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 504
 505         * ada-lang.c (resolve): Rename to ada_language::post_parser.
 506         (ada_language_data): Delete la_post_parser initializer.
 507         (ada_language::post_parser): New member function.
 508         * c-lang.c (c_language_data): Delete la_post_parser initializer.
 509         (cplus_language_data): Likewise.
 510         (asm_language_data): Likewise.
 511         (minimal_language_data): Likewise.
 512         * d-lang.c (d_language_data): Likewise.
 513         * f-lang.c (f_language_data): Likewise.
 514         * go-lang.c (go_language_data): Likewise.
 515         * language.c (unknown_language_data): Likewise.
 516         (auto_language_data): Likewise.
 517         * language.h (language_data): Delete la_post_parser field.
 518         (language_defn::post_parser): New member function.
 519         * m2-lang.c (m2_language_data): Delete la_post_parser initializer.
 520         * objc-lang.c (objc_language_data): Likewise.
 521         * opencl-lang.c (opencl_language_data): Likewise.
 522         * p-lang.c (pascal_language_data): Likewise.
 523         * parse.c (parse_exp_in_context): Update call to post_parser.
 524         (null_post_parser): Delete definition.
 525         * parser-defs.h (null_post_parser): Delete declaration.
 526         * rust-lang.c (rust_language_data): Delete la_post_parser
 527         initializer.
 528
 529 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 530
 531         * ada-lang.c (parse): Rename to ada_language::parser.
 532         (ada_language_data): Delete la_parser initializer.
 533         (ada_language::parser): New member function, implementation from
 534         parse.
 535         * c-lang.c (c_language_data): Delete la_parser initializer.
 536         (cplus_language_data): Likewise.
 537         (asm_language_data): Likewise.
 538         (minimal_language_data): Likewise.
 539         * d-lang.c (d_language_data): Likewise.
 540         (d_language::parser): New member function.
 541         * f-lang.c (f_language_data): Delete la_parser initializer.
 542         (f_language::parser): New member function.
 543         * go-lang.c (go_language_data): Delete la_parser initializer.
 544         (go_language::parser): New member function.
 545         * language.c (unk_lang_parser): Delete.
 546         (language_defn::parser): Define new member function.
 547         (unknown_language_data): Delete la_parser initializer.
 548         (unknown_language::parser): New member function.
 549         (auto_language_data): Delete la_parser initializer.
 550         (auto_language::parser): New member function.
 551         * language.h (language_data): Delete la_parser field.
 552         (language_defn::parser): Declare new member function.
 553         * m2-lang.c (m2_language_data): Delete la_parser initializer.
 554         (m2_language::parser): New member function.
 555         * objc-lang.c (objc_language_data): Delete la_parser initializer.
 556         * opencl-lang.c (opencl_language_data): Likewise.
 557         * p-lang.c (pascal_language_data): Likewise.
 558         (pascal_language::parser): New member function.
 559         * parse.c (parse_exp_in_context): Update call to parser.
 560         * rust-lang.c (rust_language_data): Delete la_parser initializer.
 561         (rust_language::parser): New member function.
 562
 563 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 564
 565         * top.c (print_gdb_configuration): Print --with-python-libdir
 566         configuration value.
 567
 568 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 569
 570         * NEWS: Mention change to the alias command.
 571
 572 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 573
 574         * cli/cli-cmds.c (lookup_cmd_for_default_args)
 575         (alias_command_completer)
 576         (make_alias_options_def_group): New functions.
 577         (alias_opts, alias_option_defs): New struct and array.
 578         (alias_usage_error): Update usage.
 579         (alias_command): Handles optional DEFAULT-ARGS... arguments.
 580         Use option framework.
 581         (_initialize_cli_cmds): Update alias command help.
 582         Update aliases command help.
 583         (show_user):
 584         Add NULL for new default_args lookup_cmd argument.
 585         (valid_command_p): Rename to validate_aliased_command.
 586         Add NULL for new default_args lookup_cmd argument.  Verify that the
 587         aliased_command has no default args.
 588         * cli/cli-decode.c (help_cmd): Show aliases definitions.
 589         (lookup_cmd_1, lookup_cmd): New argument default_args.
 590         (add_alias_cmd):
 591         Add NULL for new default_args lookup_cmd argument.
 592         (print_help_for_command): Show default args under the layout
 593          alias some_alias = some_aliased_cmd some_alias_default_arg.
 594         * cli/cli-decode.h (struct cmd_list_element): New member default_args.
 595         xfree default_args in destructor.
 596         * cli/cli-script.c (process_next_line, do_define_command):
 597         Add NULL for new default_args lookup_cmd argument.
 598         * command.h: Declare new default_args argument in lookup_cmd
 599         and lookup_cmd_1.
 600         * completer.c (complete_line_internal_1):
 601         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
 602         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 603         * guile/scm-param.c (add_setshow_generic, pascm_parameter_defined_p):
 604         Likewise.
 605         * infcmd.c (_initialize_infcmd): Likewise.
 606         * python/py-auto-load.c (gdbpy_initialize_auto_load): Likewise.
 607         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 608         * python/py-param.c (add_setshow_generic): Likewise.
 609         * remote.c (_initialize_remote): Likewise.
 610         * top.c (execute_command): Prepend default_args if command has some.
 611         (set_verbose):
 612         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
 613         * tracepoint.c (validate_actionline, encode_actions_1):
 614         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
 615
 616 2020-06-22  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 617
 618         * jit.c (jit_read_descriptor): Use bool as the return type.
 619         (jit_breakpoint_re_set_internal): Use bool as the return type.
 620         Invert the return value logic; return true if the jit breakpoint
 621         has been successfully initialized.
 622         (jit_inferior_init): Update the call to
 623         jit_breakpoint_re_set_internal.
 624
 625 2020-06-22  Pedro Alves  <palves@redhat.com>
 626
 627         PR gdb/25939
 628         * procfs.c (procfs_target::wait): Don't reference inferior_ptid.
 629         Use the current inferior instead.  Don't return
 630         TARGET_WAITKIND_SPURIOUS/inferior_ptid -- instead continue and
 631         wait again.
 632         * sol-thread.c (sol_thread_target::wait): Don't reference
 633         inferior_ptid.
 634         (ps_lgetregs, ps_lsetregs, ps_lgetfpregs, ps_lsetfpregs)
 635         (sol_update_thread_list_callback): Use the current inferior's pid
 636         instead of inferior_ptid.
 637
 638 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 639
 640         * procfs.c: Cleanup many comments.
 641
 642         (READ_WATCHFLAG, WRITE_WATCHFLAG, EXEC_WATCHFLAG)
 643         (AFTER_WATCHFLAG): Replace by value.
 644
 645         (MAIN_PROC_NAME_FORMAT): Inline ...
 646         (create_procinfo): ... here.
 647
 648         (procfs_debug_inferior): Remove SYS_exec handling.
 649         (syscall_is_exec): Likewise.
 650         (procfs_set_exec_trap): Likewise.
 651
 652         (syscall_is_lwp_exit): Inline in callers.
 653         (syscall_is_exit): Likewise.
 654         (syscall_is_exec): Likewise.
 655         (syscall_is_lwp_create): Likewise.
 656
 657         (invalidate_cache): Remove #if 0 code.
 658
 659         (make_signal_thread_runnable):  Remove.
 660         (procfs_target::resume): Remove #if 0 code.
 661
 662 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 663
 664         PR gdb/25939
 665         * procfs.c (procfs_target::procfs_init_inferior): Move push_target
 666         call ...
 667         (procfs_target::create_inferior): ... here.
 668
 669 2020-06-21  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 670
 671         * exec.c (validate_exec_file): Ensure the build-id is up to
 672         date by calling reopen_exec_file (that checks file timestamp
 673         to decide to re-read the file).
 674
 675 2020-06-18  Pedro Alves  <palves@redhat.com>
 676
 677         PR gdb/25412
 678         * gdbthread.h (delete_thread, delete_thread_silent)
 679         (find_thread_ptid): Update comments.
 680         * thread.c (current_thread_): New global.
 681         (is_current_thread): Move higher, and reimplement.
 682         (inferior_thread): Reimplement.
 683         (set_thread_exited): Use bool.  Add assertions.
 684         (add_thread_silent): Simplify thread-reuse handling by always
 685         calling delete_thread.
 686         (delete_thread): Remove intro comment.
 687         (find_thread_ptid): Skip exited threads.
 688         (switch_to_thread_no_regs): Write to current_thread_.
 689         (switch_to_no_thread): Check CURRENT_THREAD_ instead of
 690         INFERIOR_PTID.  Clear current_thread_.
 691
 692 2020-06-18  Pedro Alves  <palves@redhat.com>
 693
 694         * aix-thread.c (pd_update): Use switch_to_thread.
 695
 696 2020-06-18  Pedro Alves  <palves@redhat.com>
 697
 698         * ravenscar-thread.c (ravenscar_thread_target): Update.
 699         (ravenscar_thread_target::update_inferior_ptid): Rename to ...
 700         (ravenscar_thread_target::add_active_thread): ... this.  Don't
 701         set m_base_ptid here.  Update to avoid referencing inferior_ptid.
 702         (ravenscar_thread_target::wait): Don't write to inferior_ptid.
 703
 704 2020-06-18  Pedro Alves  <palves@redhat.com>
 705
 706         * nat/windows-nat.c (current_windows_thread): Remove.
 707         * nat/windows-nat.h (current_windows_thread): Remove.
 708         * windows-nat.c (windows_nat_target::stopped_by_sw_breakpoint):
 709         Adjust.
 710         (display_selectors): Adjust to fetch the current
 711         windows_thread_info based on inferior_ptid.
 712         (fake_create_process): No longer write to current_windows_thread.
 713         (windows_nat_target::get_windows_debug_event):
 714         Don't set inferior_ptid or current_windows_thread.
 715         (windows_nat_target::wait): Adjust to not rely on
 716         current_windows_thread.
 717         (do_initial_windows_stuff): Now a method of windows_nat_target.
 718         Switch to the last_ptid thread.
 719         (windows_nat_target::attach): Adjust.
 720         (windows_nat_target::detach): Use switch_to_no_thread instead of
 721         writing to inferior_ptid directly.
 722         (windows_nat_target::create_inferior): Adjust.
 723
 724 2020-06-18  Pedro Alves  <palves@redhat.com>
 725
 726         * windows-nat.c (do_initial_windows_stuff): No longer set inferior_ptid.
 727
 728 2020-06-18  Pedro Alves  <palves@redhat.com>
 729
 730         * go32-nat.c (go32_nat_target::create_inferior): Switch to thread
 731         after creating it, instead of writing to inferior_ptid.  Don't
 732         write to inferior_ptid.
 733
 734 2020-06-18  Pedro Alves  <palves@redhat.com>
 735
 736         * fork-child.c (postfork_hook): Don't write to inferior_ptid.
 737
 738 2020-06-18  Pedro Alves  <palves@redhat.com>
 739
 740         * bsd-kvm.c (bsd_kvm_target_open): Switch to thread after adding
 741         it, instead of writing to inferior_ptid.
 742
 743 2020-06-18  Pedro Alves  <palves@redhat.com>
 744
 745         * btrace.c (btrace_fetch): Use switch_to_thread instead of writing
 746         to inferior_ptid.
 747
 748 2020-06-18  Pedro Alves  <palves@redhat.com>
 749
 750         * bsd-kvm.c (bsd_kvm_target::close): Use switch_to_no_thread
 751         instead of writing to inferior_ptid directly.
 752
 753 2020-06-18  Pedro Alves  <palves@redhat.com>
 754
 755         * corelow.c (core_target::close): Use switch_to_no_thread instead
 756         of writing to inferior_ptid directly.
 757         (add_to_thread_list, core_target_open): Use switch_to_thread
 758         instead of writing to inferior_ptid directly.
 759
 760 2020-06-18  Pedro Alves  <palves@redhat.com>
 761
 762         * darwin-nat.c (darwin_nat_target::decode_message): Don't write to
 763         inferior_ptid.
 764         (darwin_nat_target::stop_inferior, darwin_nat_target::kill): Avoid
 765         inferior_ptid.
 766         (darwin_attach_pid): Use switch_to_no_thread instead of writing to
 767         inferior_ptid directly.
 768         (darwin_nat_target::init_thread_list): Switch to thread, instead
 769         of writing to inferior_ptid.
 770         (darwin_nat_target::attach): Don't write to inferior_ptid.
 771         (darwin_nat_target::get_ada_task_ptid): Avoid inferior_ptid.
 772
 773 2020-06-18  Pedro Alves  <palves@redhat.com>
 774
 775         * gnu-nat.c (gnu_nat_target::create_inferior): Switch to the added
 776         thread.
 777         (gnu_nat_target::attach): Don't write to inferior_ptid directly.
 778         Instead use switch_to_thread.
 779         (gnu_nat_target::detach): Use switch_to_no_thread
 780         instead of writing to inferior_ptid directly.  Used passed-in
 781         inferior instead of looking up the inferior by pid.
 782
 783 2020-06-18  Pedro Alves  <palves@redhat.com>
 784
 785         * go32-nat.c (go32_nat_target::create_inferior): Don't write to
 786         inferior_ptid.
 787
 788 2020-06-18  Pedro Alves  <palves@redhat.com>
 789
 790         * nto-procfs.c (nto_procfs_target::update_thread_list): Avoid
 791         inferior_ptid.
 792         (nto_procfs_target::attach): Avoid inferior_ptid.  Switch to
 793         thread.
 794         (nto_procfs_target::detach): Avoid referencing
 795         inferior_ptid.  Use switch_to_no_thread instead of writing to
 796         inferior_ptid directly.
 797         (nto_procfs_target::mourn_inferior): Use switch_to_no_thread
 798         instead of writing to inferior_ptid directly.
 799         (nto_procfs_target::create_inferior): Avoid inferior_ptid.  Switch
 800         to thread.
 801
 802 2020-06-18  Pedro Alves  <palves@redhat.com>
 803
 804         * remote-sim.c (gdbsim_target::create_inferior): Switch to thread
 805         after creating it, instead of writing to inferior_ptid.
 806         (gdbsim_target_open): Use switch_to_no_thread instead of writing
 807         to inferior_ptid directly.
 808         (gdbsim_target::wait): Don't write to inferior_ptid.
 809
 810 2020-06-18  Pedro Alves  <palves@redhat.com>
 811
 812         * remote.c (remote_target::remote_notice_new_inferior): Use
 813         switch_to_thread instead of writing to inferior_ptid directly.
 814         (remote_target::add_current_inferior_and_thread): Use
 815         switch_to_no_thread instead of writing to inferior_ptid directly.
 816         (extended_remote_target::attach): Use switch_to_inferior_no_thread
 817         and switch_to_thread instead of using set_current_inferior or
 818         writing to inferior_ptid directly.
 819
 820 2020-06-18  Pedro Alves  <palves@redhat.com>
 821
 822         * tracectf.c (ctf_target_open): Switch to added thread instead of
 823         writing to inferior_ptid directly.
 824         (ctf_target::close): Use switch_to_no_thread instead of writing to
 825         inferior_ptid directly.
 826
 827 2020-06-18  Pedro Alves  <palves@redhat.com>
 828
 829         * tracefile-tfile.c (tfile_target_open): Don't write to
 830         inferior_ptid directly, instead switch to added thread.
 831         (tfile_target::close): Use switch_to_no_thread instead of writing
 832         to inferior_ptid directly.
 833
 834 2020-06-18  Pedro Alves  <palves@redhat.com>
 835
 836         * procfs.c (procfs_target::attach): Don't write to inferior_ptid.
 837         (procfs_target::detach): Use switch_to_no_thread
 838         instead of writing to inferior_ptid directly.
 839         (do_attach): Change return type to void.  Switch to the added
 840         thread.
 841         (procfs_target::create_inferior): Switch to the added thread.
 842         (procfs_do_thread_registers): Don't write to inferior_ptid.
 843
 844 2020-06-18  Pedro Alves  <palves@redhat.com>
 845
 846         * infrun.c (generic_mourn_inferior): Use switch_to_thread instead
 847         of writing to inferior_ptid.
 848         (scoped_restore_exited_inferior): Delete.
 849         (handle_vfork_child_exec_or_exit): Simplify using
 850         scoped_restore_current_pspace_and_thread.  Use switch_to_thread
 851         instead of writing to inferior_ptid.
 852         (THREAD_STOPPED_BY): Delete.
 853         (thread_stopped_by_watchpoint, thread_stopped_by_sw_breakpoint)
 854         (thread_stopped_by_hw_breakpoint): Delete.
 855         (save_waitstatus): Use
 856         scoped_restore_current_thread+switch_to_thread, and call
 857         target_stopped_by_watchpoint instead of
 858         thread_stopped_by_watchpoint, target_stopped_by_sw_breakpoint
 859         instead of thread_stopped_by_sw_breakpoint, and
 860         target_stopped_by_hw_breakpoint instead of
 861         thread_stopped_by_hw_breakpoint.
 862         (handle_inferior_event)
 863         <TARGET_WAITKIND_EXITED/TARGET_WAITKIND_SIGNALLED>: Don't write to
 864         inferior_ptid directly, nor
 865         set_current_inferior/set_current_program_space.  Use
 866         switch_to_thread / switch_to_inferior_no_thread instead.
 867
 868 2020-06-18  Pedro Alves  <palves@redhat.com>
 869
 870         * target.c (generic_mourn_inferior): Use switch_to_no_thread
 871         instead of writing to inferior_ptid.
 872
 873 2020-06-18  Pedro Alves  <palves@redhat.com>
 874
 875         * inf-ptrace.c (inf_ptrace_target::create_inferior): Switch to the
 876         added thread.
 877         (inf_ptrace_target::attach): Don't write to inferior_ptid.  Switch
 878         to the added thread.
 879         (inf_ptrace_target::detach_success): Use switch_to_no_thread
 880         instead of writing to inferior_ptid.
 881
 882 2020-06-18  Pedro Alves  <palves@redhat.com>
 883
 884         * gdbarch-selftests.c: Include "progspace-and-thread.h".
 885         (register_to_value_test): Mock a program_space too.  Heap-allocate
 886         the address space.  Don't write to inferior_ptid.  Use
 887         switch_to_thread instead.
 888
 889 2020-06-18  Pedro Alves  <palves@redhat.com>
 890
 891         * linux-tdep.c (find_signalled_thread(thread_info *,void *)):
 892         Delete.
 893         (find_signalled_thread()): New, factored out from
 894         linux_make_corefile_notes and adjusted to handle exited threads.
 895         (linux_make_corefile_notes): Adjust to use the new
 896         find_signalled_thread.
 897
 898 2020-06-18  Pedro Alves  <palves@redhat.com>
 899
 900         * linux-tdep.c (btrace_fetch): Save/restore current thread instead
 901         of saving/restoring inferior_ptid.
 902
 903 2020-06-17  Tom Tromey  <tom@tromey.com>
 904
 905         * tui/tui-win.h (tui_scroll_forward, tui_scroll_backward)
 906         (tui_scroll_left, tui_scroll_right, struct tui_win_info): Don't
 907         declare.
 908         * tui/tui-data.h (MIN_CMD_WIN_HEIGHT): Remove.
 909
 910 2020-06-15  Simon Marchi  <simon.marchi@efficios.com>
 911
 912         * dwarf2/read.c (dwarf2_initialize_objfile): Check for presence
 913         of partial symtabs.
 914
 915 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
 916
 917         * regformats/reg-arm.dat: Remove.
 918         * regformats/reg-bfin.dat: Remove.
 919         * regformats/reg-cris.dat: Remove.
 920         * regformats/reg-crisv32.dat: Remove.
 921         * regformats/reg-m32r.dat: Remove.
 922         * regformats/reg-tilegx.dat: Remove.
 923         * regformats/reg-tilegx32.dat: Remove.
 924
 925 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
 926
 927         * features/Makefile (WHICH): Remove arm files.
 928         * regformats/arm/arm-with-iwmmxt.dat: Remove.
 929         * regformats/arm/arm-with-neon.dat: Remove.
 930         * regformats/arm/arm-with-vfpv2.dat: Remove.
 931         * regformats/arm/arm-with-vfpv3.dat: Remove.
 932
 933 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
 934
 935         * features/Makefile (XMLTOC): Remove rx.xml.
 936
 937 2020-06-17  Pedro Alves  <palves@redhat.com>
 938
 939         * gdbthread.h (thread_control_state) <trap_expected> Update
 940         comments.
 941
 942 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 943
 944         * ada-lang.c (ada_lookup_symbol_nonlocal): Rename to
 945         ada_language::lookup_symbol_nonlocal.
 946         (ada_language_data): Delete la_lookup_symbol_nonlocal initializer.
 947         (ada_language::lookup_symbol_nonlocal): New member function,
 948         implementation from ada_lookup_symbol_nonlocal.
 949         * c-lang.c (c_language_data): Delete la_lookup_symbol_nonlocal
 950         initializer.
 951         (cplus_language_data): Delete la_lookup_symbol_nonlocal
 952         initializer.
 953         (cplus_language::lookup_symbol_nonlocal): New member function.
 954         (asm_language_data): Delete la_lookup_symbol_nonlocal initializer.
 955         (minimal_language_data) Likewise.
 956         * cp-namespace.c (cp_lookup_nested_symbol): Update comment.
 957         * d-lang.c (d_language_data): Delete la_lookup_symbol_nonlocal
 958         initializer.
 959         (d_language::lookup_symbol_nonlocal): New member function.
 960         * f-lang.c (f_language_data): Delete la_lookup_symbol_nonlocal
 961         initializer.
 962         (f_language::lookup_symbol_nonlocal): New member function.
 963         * go-lang.c (go_language_data): Delete la_lookup_symbol_nonlocal
 964         initializer.
 965         * language.c (unknown_language_data): Likewise.
 966         (auto_language_data): Likewise.
 967         * language.h (language_data): Delete la_lookup_symbol_nonlocal
 968         field.
 969         (language_defn::lookup_symbol_nonlocal): New member function.
 970         * m2-lang.c (m2_language_data): Delete la_lookup_symbol_nonlocal
 971         initializer.
 972         * objc-lang.c (objc_language_data): Likewise.
 973         * opencl-lang.c (opencl_language_data): Likewise.
 974         * p-lang.c (pascal_language_data): Likewise.
 975         * rust-lang.c (rust_lookup_symbol_nonlocal): Rename to
 976         rust_language::lookup_symbol_nonlocal.
 977         (rust_language_data): Delete la_lookup_symbol_nonlocal
 978         initializer.
 979         (rust_language::lookup_symbol_nonlocal): New member function,
 980         implementation from rust_lookup_symbol_nonlocal.
 981         * symtab.c (lookup_symbol_aux): Update call to
 982         lookup_symbol_nonlocal.
 983         (basic_lookup_symbol_nonlocal): Rename to...
 984         (language_defn::lookup_symbol_nonlocal): ...this, and update
 985         header comment.  Remove language_defn parameter, and replace with
 986         uses of `this'.
 987         * symtab.h (basic_lookup_symbol_nonlocal): Delete declaration.
 988
 989 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 990
 991         * ada-lang.c (ada_language_data): Delete la_value_print_inner
 992         initializer.
 993         (ada_language::value_print_inner): New member function.
 994         * c-lang.c (c_language_data): Delete la_value_print_inner
 995         initializer.
 996         (cplus_language_data): Likewise.
 997         (asm_language_data): Likewise.
 998         (minimal_language_data): Likewise.
 999         * d-lang.c (d_language_data): Likewise.
1000         (d_language::value_print_inner): New member function.
1001         * f-lang.c (f_language_data): Delete la_value_print_inner
1002         initializer.
1003         (f_language::value_print_inner): New member function.
1004         * f-lang.h (f_value_print_innner): Rename to...
1005         (f_value_print_inner): ...this (note spelling of 'inner').
1006         * f-valprint.c (f_value_print_innner): Rename to...
1007         (f_value_print_inner): ...this (note spelling of 'inner').
1008         * go-lang.c (go_language_data): Delete la_value_print_inner
1009         initializer.
1010         (go_language::value_print_inner): New member function.
1011         * language.c (language_defn::value_print_inner): Define new member
1012         function.
1013         (unk_lang_value_print_inner): Delete.
1014         (unknown_language_data): Delete la_value_print_inner initializer.
1015         (unknown_language::value_print_inner): New member function.
1016         (auto_language_data): Delete la_value_print_inner initializer.
1017         (auto_language::value_print_inner): New member function.
1018         * language.h (language_data): Delete la_value_print_inner field.
1019         (language_defn::value_print_inner): Delcare new member function.
1020         * m2-lang.c (m2_language_data): Delete la_value_print_inner
1021         initializer.
1022         (m2_language::value_print_inner): New member function.
1023         * objc-lang.c (objc_language_data): Delete la_value_print_inner
1024         initializer.
1025         * opencl-lang.c (opencl_language_data): Likewise.
1026         * p-lang.c (pascal_language_data): Likewise.
1027         (pascal_language::value_print_inner): New member function.
1028         * rust-lang.c (rust_language_data): Delete la_value_print_inner
1029         initializer.
1030         (rust_language::value_print_inner): New member function.
1031         * valprint.c (do_val_print): Update call to value_print_inner.
1032
1033 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1034
1035         * ada-lang.c (ada_language_data): Delete la_value_print
1036         initializer.
1037         (ada_language::value_print): New member function.
1038         * c-lang.c (c_language_data): Delete la_value_print initializer.
1039         (cplus_language_data): Likewise.
1040         (asm_language_data): Likewise.
1041         (minimal_language_data): Likewise.
1042         * d-lang.c (d_language_data): Likewise.
1043         * f-lang.c (f_language_data): Likewise.
1044         * go-lang.c (go_language_data): Likewise.
1045         * language.c (unk_lang_value_print): Delete.
1046         (language_defn::value_print): Define new member function.
1047         (unknown_language_data): Delete la_value_print initializer.
1048         (unknown_language::value_print): New member function.
1049         (auto_language_data): Delete la_value_print initializer.
1050         (auto_language::value_print): New member function.
1051         * language.h (language_data): Delete la_value_print field.
1052         (language_defn::value_print): Declare new member function.
1053         (LA_VALUE_PRINT): Update call to value_print.
1054         * m2-lang.c (m2_language_data): Delete la_value_print initializer.
1055         * objc-lang.c (objc_language_data): Likewise.
1056         * opencl-lang.c (opencl_language_data): Likewise.
1057         * p-lang.c (pascal_language_data): Likewise.
1058         (pascal_language::value_print): New member function.
1059         * rust-lang.c (rust_language_data): Delete la_value_print
1060         initializer.
1061
1062 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1063
1064         * ada-lang.c (ada_watch_location_expression): Rename to
1065         ada_language::watch_location_expression.
1066         (ada_language_data): Delete la_watch_location_expression
1067         initializer.
1068         (ada_language::watch_location_expression): New member function,
1069         implementation from ada_watch_location_expression.
1070         * breakpoint.c (watch_command_1): Update call to
1071         watch_location_expression.
1072         * c-lang.c (c_watch_location_expression): Rename to
1073         language_defn::watch_location_expression.
1074         (c_language_data): Delete la_watch_location_expression
1075         initializer.
1076         (cplus_language_data): Likewise.
1077         (asm_language_data): Likewise.
1078         (minimal_language_data): Likewise.
1079         * c-lang.h (c_watch_location_expression): Delete declaration.
1080         * d-lang.c (d_language_data): Delete la_watch_location_expression
1081         initializer.
1082         * f-lang.c (f_language_data): Likewise.
1083         * go-lang.c (go_language_data): Likewise.
1084         * language.c (language_defn::watch_location_expression): Member
1085         function implementation from c_watch_location_expression.
1086         (unknown_language_data): Delete la_watch_location_expression
1087         initializer.
1088         (auto_language_data): Likewise.
1089         * language.h (language_data): Delete la_watch_location_expression
1090         field.
1091         (language_defn::watch_location_expression): Declare new member
1092         function.
1093         * m2-lang.c (m2_language_data): Delete
1094         la_watch_location_expression initializer.
1095         * objc-lang.c (objc_language_data): Likewise.
1096         * opencl-lang.c (opencl_language_data): Likewise.
1097         * p-lang.c (pascal_language_data): Likewise.
1098         * rust-lang.c (rust_watch_location_expression): Rename to
1099         rust_language::watch_location_expression.
1100         (rust_language_data): Delete la_watch_location_expression
1101         initializer.
1102         (rust_language::watch_location_expression): New member function,
1103         implementation from rust_watch_location_expression.
1104
1105 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1106
1107         * ada-lang.c (ada_collect_symbol_completion_matches): Rename to
1108         ada_language::collect_symbol_completion_matches.
1109         (ada_language_data): Delete la_collect_symbol_completion_matches
1110         initializer.
1111         (ada_language::collect_symbol_completion_matches): New member
1112         function, implementation from
1113         ada_collect_symbol_completion_matches.
1114         * c-lang.c (c_language_data): Delete
1115         la_collect_symbol_completion_matches initializer.
1116         (cplus_language_data): Likewise.
1117         (asm_language_data): Likewise.
1118         (minimal_language_data): Likewise.
1119         * d-lang.c (d_language_data): Likewise.
1120         * f-lang.c (f_collect_symbol_completion_matches): Rename to
1121         f_language::collect_symbol_completion_matches.
1122         (f_language_data): Delete la_collect_symbol_completion_matches
1123         initializer.
1124         (f_language::collect_symbol_completion_matches) New member
1125         function, implementation from f_collect_symbol_completion_matches.
1126         * go-lang.c (go_language_data): Delete
1127         la_collect_symbol_completion_matches initializer.
1128         * language.c (unknown_language_data): Likewise.
1129         (auto_language_data): Likewise.
1130         * language.h (language_data): Delete
1131         la_collect_symbol_completion_matches field.
1132         (language_defn::collect_symbol_completion_matches): New member
1133         function.
1134         * m2-lang.c (m2_language_data): Delete
1135         la_collect_symbol_completion_matches initializer.
1136         * objc-lang.c (objc_language_data): Likewise.
1137         * opencl-lang.c (opencl_language_data): Likewise.
1138         * p-lang.c (pascal_language_data): Likewise.
1139         * rust-lang.c (rust_language_data): Likewise.
1140         * symtab.c (default_collect_symbol_completion_matches): Delete.
1141         (collect_symbol_completion_matches): Update call to
1142         collect_symbol_completion_matches.
1143         (collect_symbol_completion_matches_type): Likewise.
1144         * symtab.h (default_collect_symbol_completion_matches): Delete
1145         declaration.
1146
1147 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1148
1149         * ada-lang.c (ada_get_gdb_completer_word_break_characters): Delete.
1150         (ada_language_data): Delete la_word_break_characters initializer.
1151         (ada_language::word_break_characters): New member function.
1152         * c-lang.c (c_language_data): Delete la_word_break_characters
1153         initializer.
1154         (cplus_language_data): Likewise.
1155         (asm_language_data): Likewise.
1156         (minimal_language_data): Likewise.
1157         * completer.c: Update global comment.
1158         (advance_to_expression_complete_word_point): Update call to
1159         word_break_characters.
1160         (complete_files_symbols): Likewise.
1161         (complete_line_internal_1): Likewise.
1162         (default_completer_handle_brkchars): Likewise.
1163         (skip_quoted_chars): Likewise.
1164         * d-lang.c (d_language_data): Delete la_word_break_characters
1165         initializer.
1166         * f-lang.c (f_word_break_characters): Delete.
1167         (f_language_data): Delete la_word_break_characters initializer.
1168         (f_language::word_break_characters): New member function.
1169         * go-lang.c (go_language_data): Delete la_word_break_characters
1170         initializer.
1171         * language.c (unknown_language_data): Likewise.
1172         (auto_language_data): Likewise.
1173         * language.h (default_word_break_characters): Move declaration to
1174         earlier in the file.
1175         (language_data): Delete la_word_break_characters field.
1176         (language_defn::word_break_characters): New member function.
1177         * m2-lang.c (m2_language_data): Delete la_word_break_characters
1178         initializer.
1179         * objc-lang.c (objc_language_data): Likewise.
1180         * opencl-lang.c (opencl_language_data): Likewise.
1181         * p-lang.c (pascal_language_data): Likewise.
1182         * rust-lang.c (rust_language_data): Likewise.
1183
1184 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1185
1186         * ada-lang.c (ada_get_symbol_name_matcher): Update header comment.
1187         (ada_language_data): Delete la_get_symbol_name_matcher
1188         initializer.
1189         (language_defn::get_symbol_name_matcher_inner): New member
1190         function.
1191         * c-lang.c (c_language_data): Delete la_get_symbol_name_matcher
1192         initializer.
1193         (cplus_language_data): Likewise.
1194         (cplus_language::get_symbol_name_matcher_inner): New member
1195         function.
1196         (asm_language_data): Delete la_get_symbol_name_matcher initializer.
1197         (minimal_language_data): Likewise.
1198         * cp-support.h (cp_get_symbol_name_matcher): Update header comment.
1199         * d-lang.c (d_language_data): Delete la_get_symbol_name_matcher
1200         initializer.
1201         * dictionary.c (iter_match_first_hashed): Update call to
1202         get_symbol_name_matcher.
1203         (iter_match_next_hashed): Likewise.
1204         (iter_match_next_linear): Likewise.
1205         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Likewise.
1206         * f-lang.c (f_language_data): Delete la_get_symbol_name_matcher
1207         initializer.
1208         (f_language::get_symbol_name_matcher_inner): New member function.
1209         * go-lang.c (go_language_data): Delete la_get_symbol_name_matcher
1210         initializer.
1211         * language.c (default_symbol_name_matcher): Update header comment,
1212         make static.
1213         (language_defn::get_symbol_name_matcher): New definition.
1214         (language_defn::get_symbol_name_matcher_inner): Likewise.
1215         (get_symbol_name_matcher): Delete.
1216         (unknown_language_data): Delete la_get_symbol_name_matcher
1217         initializer.
1218         (auto_language_data): Likewise.
1219         * language.h (language_data): Delete la_get_symbol_name_matcher
1220         field.
1221         (language_defn::get_symbol_name_matcher): New member function.
1222         (language_defn::get_symbol_name_matcher_inner): Likewise.
1223         (default_symbol_name_matcher): Delete declaration.
1224         * linespec.c (find_methods): Update call to
1225         get_symbol_name_matcher.
1226         * m2-lang.c (m2_language_data): Delete la_get_symbol_name_matcher
1227         initializer.
1228         * minsyms.c (lookup_minimal_symbol): Update call to
1229         get_symbol_name_matcher.
1230         (iterate_over_minimal_symbols): Likewise.
1231         * objc-lang.c (objc_language_data): Delete
1232         la_get_symbol_name_matcher initializer.
1233         * opencl-lang.c (opencl_language_data): Likewise.
1234         * p-lang.c (pascal_language_data): Likewise.
1235         * psymtab.c (psymbol_name_matches): Update call to
1236         get_symbol_name_matcher.
1237         * rust-lang.c (rust_language_data): Delete
1238         la_get_symbol_name_matcher initializer.
1239         * symtab.c (symbol_matches_search_name): Update call to
1240         get_symbol_name_matcher.
1241         (compare_symbol_name): Likewise.
1242
1243 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1244
1245         * ada-lang.c (ada_language_data): Delete la_compute_program
1246         initializer.
1247         * c-lang.c (c_language_data): Likewise.
1248         (c_language::compute_program): New member function.
1249         (cplus_language_data): Delete la_compute_program initializer.
1250         (cplus_language::compute_program): New member function.
1251         (asm_language_data): Delete la_compute_program initializer.
1252         (minimal_language_data): Likewise.
1253         * c-lang.h (c_compute_program): Update comment.
1254         (cplus_compute_program): Likewise.
1255         * compile/compile-c-support.c (c_compute_program): Likewise.
1256         (cplus_compute_program): Likewise.
1257         * compile/compile.c (compile_to_object): Update call to
1258         la_compute_program.
1259         * d-lang.c (d_language_data): Delete la_compute_program
1260         initializer.
1261         * f-lang.c (f_language_data): Likewise.
1262         * go-lang.c (go_language_data): Likewise.
1263         * language.c (unknown_language_data): Likewise.
1264         (auto_language_data): Likewise.
1265         * language.h (language_data): Delete la_compute_program field.
1266         (language_defn::compute_program): New member function.
1267         * m2-lang.c (m2_language_data): Delete la_compute_program
1268         initializer.
1269         * objc-lang.c (objc_language_data): Likewise.
1270         * opencl-lang.c (opencl_language_data): Likewise.
1271         * p-lang.c (pascal_language_data): Likewise.
1272         * rust-lang.c (rust_language_data): Likewise.
1273
1274 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1275
1276         * ada-lang.c (ada_language_data) Delete
1277         la_class_name_from_physname initializer.
1278         * c-lang.c (c_language_data): Likewise.
1279         (cplus_language_data): Likewise.
1280         (cplus_language::class_name_from_physname): New member function.
1281         (asm_language_data): Delete la_class_name_from_physname
1282         initializer.
1283         (minimal_language_data): Likewise.
1284         * d-lang.c (d_language_data): Likewise.
1285         * dwarf2/read.c (guess_partial_die_structure_name): Update to call
1286         method on language_defn class.
1287         (guess_full_die_structure_name): Likewise.
1288         * f-lang.c (f_language_data): Delete la_class_name_from_physname
1289         initializer.
1290         * go-lang.c (go_language_data): Likewise.
1291         * language.c (language_class_name_from_physname): Delete.
1292         (unk_lang_class_name): Delete.
1293         (unknown_language_data): Delete la_class_name_from_physname
1294         initializer.
1295         (auto_language_data): Likewise.
1296         * language.h (language_data): Delete la_class_name_from_physname
1297         field.
1298         (language_defn::class_name_from_physname): New function.
1299         (language_class_name_from_physname): Delete declaration.
1300         * m2-lang.c (m2_language_data): Delete la_class_name_from_physname
1301         initializer.
1302         * objc-lang.c (objc_language_data): Likewise.
1303         * opencl-lang.c (opencl_language_data): Likewise.
1304         * p-lang.c (pascal_language_data): Likewise.
1305         * rust-lang.c (rust_language_data): Likewise.
1306
1307 2020-06-16  Tom Tromey  <tom@tromey.com>
1308
1309         * tui/tui-data.h (STATUS_NAME): New macro.
1310         * tui/tui-layout.c (tui_remove_some_windows)
1311         (initialize_known_windows, tui_register_window)
1312         (tui_layout_split::remove_windows, initialize_layouts)
1313         (tui_new_layout_command): Don't use hard-coded window names.
1314
1315 2020-06-16  Tom Tromey  <tom@tromey.com>
1316
1317         PR tui/25348:
1318         * tui/tui.c (tui_ensure_readline_initialized): Rename from
1319         tui_initialize_readline.  Only run once.  Call rl_initialize.
1320         * tui/tui.h (tui_ensure_readline_initialized): Rename from
1321         tui_initialize_readline.
1322         * tui/tui-io.c (tui_setup_io): Call
1323         tui_ensure_readline_initialized.
1324         * tui/tui-interp.c (tui_interp::init): Update.
1325
1326 2020-06-16  Tom Tromey  <tom@tromey.com>
1327
1328         * tui/tui-layout.c (tui_layout_split::remove_windows): Fix logic.
1329         Also preserve the status window.
1330
1331 2020-06-16  Tom Tromey  <tom@tromey.com>
1332
1333         * python/py-tui.c (tui_py_window::~tui_py_window): Handle case
1334         where m_window==nullptr.
1335
1336 2020-06-15  Tom Tromey  <tromey@adacore.com>
1337
1338         * windows-nat.c (windows_nat::handle_output_debug_string):
1339         Update.
1340         (windows_nat::handle_ms_vc_exception): Update.
1341         * target.h (target_read_string): Change API.
1342         * target.c (target_read_string): Change API.
1343         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
1344         Update.
1345         * solib-frv.c (frv_current_sos): Update.
1346         * solib-dsbt.c (dsbt_current_sos): Update.
1347         * solib-darwin.c (darwin_current_sos): Update.
1348         * linux-thread-db.c (inferior_has_bug): Update.
1349         * expprint.c (print_subexp_standard): Update.
1350         * ada-lang.c (ada_main_name, ada_tag_name_from_tsd)
1351         (ada_exception_message_1): Update.
1352
1353 2020-06-15  Tom Tromey  <tromey@adacore.com>
1354
1355         * linux-tdep.c (dump_mapping_p): Use target_read_memory.
1356
1357 2020-06-15  Tom Tromey  <tromey@adacore.com>
1358
1359         * valprint.c (read_string): Update comment.
1360         * target.c (MIN): Remove.
1361         (target_read_string): Rewrite.
1362
1363 2020-06-15  Tom Tromey  <tromey@adacore.com>
1364
1365         * corefile.c (read_memory_string): Remove.
1366         * ada-valprint.c (ada_value_print_ptr): Update.
1367         * ada-lang.h (ada_tag_name): Change return type.
1368         * ada-lang.c (type_from_tag): Update.
1369         (ada_tag_name_from_tsd): Change return type.  Use
1370         target_read_string.
1371         (ada_tag_name): Likewise.
1372         * gdbcore.h (read_memory_string): Don't declare.
1373
1374 2020-06-14  Hannes Domani  <ssbssa@yahoo.de>
1375
1376         * symtab.c (rbreak_command): Ignore Windows drive colon.
1377
1378 2020-06-12  Simon Marchi  <simon.marchi@efficios.com>
1379
1380         * NEWS: Mention removed GDBserver host support.
1381
1382 2020-06-12  Nelson Chu  <nelson.chu@sifive.com>
1383
1384         * features/riscv/rebuild-csr-xml.sh: Updated.
1385
1386 2020-06-11  Tom Tromey  <tom@tromey.com>
1387
1388         PR gdb/18318:
1389         * c-exp.y (lex_one_token): Handle 'p' like 'e'.
1390
1391 2020-06-09  Jonny Grant  <jg@jguk.org>
1392 2020-06-09  Simon Marchi  <simon.marchi@polymtl.ca>
1393
1394         * main.c (captured_main_1): Don't print new line after help.
1395         (print_gdb_help): add mailing list and IRC channel information
1396         to --help.  Add new lines between items in the footer.  Remove
1397         quotes around bug url.
1398
1399 2020-06-11  Keith Seitz  <keiths@redhat.com>
1400
1401         PR gdb/21356
1402         * gdbtypes.c (resolve_dynamic_union, resolve_dynamic_struct):
1403         Resolve typedefs for type length calculations.
1404
1405 2020-06-10  Tom de Vries  <tdevries@suse.de>
1406
1407         PR ada/24713
1408         * dwarf2/index-write.c (struct mapped_symtab): Add m_string_obstack.
1409         (write_psymbols): Enable .gdb_index for ada.
1410         * dwarf2/read.c: Remove comment stating .gdb_index is unsupported for
1411         ada.
1412
1413 2020-06-10  Tom de Vries  <tdevries@suse.de>
1414
1415         * dwarf2/read.c (dw2_symtab_iter_init_common): Factor out of ...
1416         (dw2_symtab_iter_init): ... here.  Add variant with "offset_type
1417         namei" instead of "const char *name" argument.
1418         (dw2_map_matching_symbols): Use "offset_type namei" variant of
1419         dw2_symtab_iter_init.
1420
1421 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1422
1423         * gdbtypes.h (TYPE_FIELD_TYPE): Remove.  Change all call sites
1424         to use type::field and field::type instead.
1425
1426 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1427
1428         * gdbtypes.h (FIELD_TYPE): Remove.  Change all call sites
1429         to use field::type instead.
1430
1431 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1432
1433         * gdbtypes.h (struct field) <type, set_type>: New methods.
1434         Rename `type` field to...
1435         <m_type>: ... this.  Change references throughout to use type or
1436         set_type methods.
1437         (FIELD_TYPE): Use field::type.  Change call sites that modify
1438         the field's type to use field::set_type instead.
1439
1440 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1441
1442         * gdbtypes.h (TYPE_INDEX_TYPE): Remove.  Change all call sites
1443         to use type::index_type instead.
1444
1445 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1446
1447         * gdbtypes.h (struct type) <index_type, set_index_type>: New
1448         methods.
1449         (TYPE_INDEX_TYPE): Use type::index_type.
1450         * gdbtypes.c (create_array_type_with_stride): Likewise.
1451
1452 2020-06-07  Tom Tromey  <tom@tromey.com>
1453
1454         * valprint.c (generic_val_print_float): Remove "embedded_offset"
1455         parameter.
1456         (generic_value_print): Update.
1457
1458 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1459
1460         Revert commit 982a38f60b0.
1461         * python/py-tui.c (gdbpy_tui_set_title): Restore use of get.
1462
1463 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1464
1465         * python/py-tui.c (gdbpy_tui_set_title): Use release, not get, to
1466         avoid use after free.
1467
1468 2020-06-05  Tom de Vries  <tdevries@suse.de>
1469
1470         * NEWS: Fix typos.
1471
1472 2020-06-04  Simon Marchi  <simon.marchi@efficios.com>
1473
1474         * dwarf2/read.c (dwarf2_read_gdb_index): Save partial_symtabs in
1475         the per_bfd object.
1476         (dwarf2_read_debug_names): Likewise.
1477         (dwarf2_initialize_objfile): Use partial_symtabs from per_bfd
1478         object when re-using a per_bfd object with an index.
1479
1480 2020-06-03  Tom de Vries  <tdevries@suse.de>
1481
1482         PR symtab/26046
1483         * dwarf2/read.c (scan_partial_symbols): Recurse into DW_TAG_subprogram
1484         children for C++.
1485         (load_partial_dies): Don't skip DW_TAG_inlined_subroutine child of
1486         DW_TAG_subprogram.
1487
1488 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1489
1490         * ada-lang.c (ada_language_data): Delete skip_trampoline
1491         initializer.
1492         * c-lang.c (c_language_data): Likewise.
1493         (cplus_language_data): Likewise.
1494         (cplus_language::skip_trampoline): New member function.
1495         (asm_language_data): Delete skip_trampoline initializer.
1496         (minimal_language_data): Likewise.
1497         * d-lang.c (d_language_data): Likewise.
1498         * f-lang.c (f_language_data): Likewise.
1499         * go-lang.c (go_language_data): Likewise.
1500         * language.c (unk_lang_trampoline): Delete function.
1501         (skip_language_trampoline): Update.
1502         (unknown_language_data): Delete skip_trampoline initializer.
1503         (auto_language_data): Likewise.
1504         * language.h (language_data): Delete skip_trampoline field.
1505         (language_defn::skip_trampoline): New function.
1506         * m2-lang.c (m2_language_data): Delete skip_trampoline
1507         initializer.
1508         * objc-lang.c (objc_skip_trampoline): Delete function, move
1509         implementation to objc_language::skip_trampoline.
1510         (objc_language_data): Delete skip_trampoline initializer.
1511         (objc_language::skip_trampoline): New member function with
1512         implementation from objc_skip_trampoline.
1513         * opencl-lang.c (opencl_language_data): Delete skip_trampoline
1514         initializer.
1515         * p-lang.c (pascal_language_data): Likewise.
1516         * rust-lang.c (rust_language_data): Likewise.
1517
1518 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1519
1520         * ada-lang.c (ada_language_data): Delete la_demangle initializer.
1521         (ada_language::demangle): New member function.
1522         * c-lang.c (c_language_data): Delete la_demangle initializer.
1523         (cplus_language_data): Delete la_demangle initializer.
1524         (cplus_language::demangle): New member function.
1525         (asm_language_data): Delete la_demangle initializer.
1526         (minimal_language_data): Delete la_demangle initializer.
1527         * d-lang.c (d_language_data): Delete la_demangle initializer.
1528         (d_language::demangle): New member function.
1529         * f-lang.c (f_language_data): Delete la_demangle initializer.
1530         (f_language::demangle): New member function.
1531         * go-lang.c (go_language_data): Delete la_demangle initializer.
1532         (go_language::demangle): New member function.
1533         * language.c (language_demangle): Update.
1534         (unk_lang_demangle): Delete.
1535         (unknown_language_data): Delete la_demangle initializer.
1536         (unknown_language::demangle): New member function.
1537         (auto_language_data): Delete la_demangle initializer.
1538         (auto_language::demangle): New member function.
1539         * language.h (language_data): Delete la_demangle field.
1540         (language_defn::demangle): New function.
1541         * m2-lang.c (m2_language_data): Delete la_demangle initializer.
1542         * objc-lang.c (objc_language_data): Delete la_demangle
1543         initializer.
1544         (objc_language::demangle): New member function.
1545         * opencl-lang.c (opencl_language_data): Delete la_demangle
1546         initializer.
1547         * p-lang.c (pascal_language_data): Likewise.
1548         * rust-lang.c (rust_language_data): Likewise.
1549         (rust_language::demangle): New member function.
1550
1551 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1552
1553         * ada-lang.c (ada_language_data): Delete la_print_type
1554         initializer.
1555         (ada_language::print_type): New member function.
1556         * c-lang.c (c_language_data): Delete la_print_type initializer.
1557         (c_language::print_type): New member function.
1558         (cplus_language_data): Delete la_print_type initializer.
1559         (cplus_language::print_type): New member function.
1560         (asm_language_data): Delete la_print_type initializer.
1561         (asm_language::print_type): New member function.
1562         (minimal_language_data): Delete la_print_type initializer.
1563         (minimal_language::print_type): New member function.
1564         * d-lang.c (d_language_data): Delete la_print_type initializer.
1565         (d_language::print_type): New member function.
1566         * f-lang.c (f_language_data): Delete la_print_type initializer.
1567         (f_language::print_type): New member function.
1568         * go-lang.c (go_language_data): Delete la_print_type initializer.
1569         (go_language::print_type): New member function.
1570         * language.c (unk_lang_print_type): Delete.
1571         (unknown_language_data): Delete la_print_type initializer.
1572         (unknown_language::print_type): New member function.
1573         (auto_language_data): Delete la_print_type initializer.
1574         (auto_language::print_type): New member function.
1575         * language.h (language_data): Delete la_print_type field.
1576         (language_defn::print_type): New function.
1577         (LA_PRINT_TYPE): Update.
1578         * m2-lang.c (m2_language_data): Delete la_print_type initializer.
1579         (m2_language::print_type): New member function.
1580         * objc-lang.c (objc_language_data): Delete la_print_type
1581         initializer.
1582         (objc_language::print_type): New member function.
1583         * opencl-lang.c (opencl_print_type): Delete, implementation moved
1584         to opencl_language::print_type.
1585         (opencl_language_data): Delete la_print_type initializer.
1586         (opencl_language::print_type): New member function, implementation
1587         from opencl_print_type.
1588         * p-lang.c (pascal_language_data): Delete la_print_type
1589         initializer.
1590         (pascal_language::print_type): New member function.
1591         * rust-lang.c (rust_print_type): Delete, implementation moved to
1592         rust_language::print_type.
1593         (rust_language_data): Delete la_print_type initializer.
1594         (rust_language::print_type): New member function, implementation
1595         from rust_print_type.
1596
1597 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1598
1599         * ada-lang.c (ada_sniff_from_mangled_name): Delete function,
1600         implementation moves to...
1601         (ada_language::sniff_from_mangled_name): ...here.  Update return
1602         type.
1603         (ada_language_data): Delete la_sniff_from_mangled_name
1604         initializer.
1605         * c-lang.c (c_language_data): Likewise.
1606         (cplus_language_data): Likewise.
1607         (cplus_language::sniff_from_mangled_name): New member function,
1608         implementation taken from gdb_sniff_from_mangled_name.
1609         (asm_language_data): Delete la_sniff_from_mangled_name
1610         initializer.
1611         (minimal_language_data): Likewise.
1612         * cp-support.c (gdb_sniff_from_mangled_name): Delete,
1613         implementation moves to cplus_language::sniff_from_mangled_name.
1614         * cp-support.h (gdb_sniff_from_mangled_name): Delete declaration.
1615         * d-lang.c (d_sniff_from_mangled_name): Delete, implementation
1616         moves to...
1617         (d_language::sniff_from_mangled_name): ...here.
1618         (d_language_data): Delete la_sniff_from_mangled_name initializer.
1619         * f-lang.c (f_language_data): Likewise.
1620         * go-lang.c (go_sniff_from_mangled_name): Delete, implementation
1621         moves to...
1622         (go_language::sniff_from_mangled_name): ...here.
1623         (go_language_data): Delete la_sniff_from_mangled_name initializer.
1624         * language.c (language_sniff_from_mangled_name): Delete.
1625         (unknown_language_data): Delete la_sniff_from_mangled_name
1626         initializer.
1627         (auto_language_data): Likewise.
1628         * language.h (language_data): Delete la_sniff_from_mangled_name
1629         field.
1630         (language_defn::sniff_from_mangled_name): New function.
1631         (language_sniff_from_mangled_name): Delete declaration.
1632         * m2-lang.c (m2_language_data): Delete la_sniff_from_mangled_name
1633         field.
1634         * objc-lang.c (objc_sniff_from_mangled_name): Delete,
1635         implementation moves to...
1636         (objc_language::sniff_from_mangled_name): ...here.
1637         (objc_language_data): Delete la_sniff_from_mangled_name initializer.
1638         * opencl-lang.c (opencl_language_data): Likewise.
1639         * p-lang.c (pascal_language_data): Likewise.
1640         * rust-lang.c (rust_sniff_from_mangled_name): Delete,
1641         implementation moves to...
1642         (rust_language::sniff_from_mangled_name): ...here.
1643         (rust_language_data): Delete la_sniff_from_mangled_name
1644         initializer.
1645         * symtab.c (symbol_find_demangled_name): Call
1646         sniff_from_mangled_name member function.
1647
1648 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1649
1650         * ada-lang.c (ada_language_data): Delete la_search_name_hash
1651         initializer.
1652         * c-lang.c (c_language_data): Likewise.
1653         (cplus_language_data): Likewise.
1654         (cplus_language::search_name_hash): New member function.
1655         (asm_language_data): Delete la_search_name_hash initializer.
1656         (minimal_language_data): Likewise.
1657         * d-lang.c (d_language_data): Likewise.
1658         * dictionary.c (default_search_name_hash): Rename to...
1659         (language_defn::search_name_hash): ...this.
1660         * f-lang.c (f_language_data): Likewise.
1661         (f_language::search_name_hash): New member function.
1662         * go-lang.c (go_language_data): Delete la_search_name_hash
1663         initializer.
1664         * language.c (unknown_language_data): Likewise.
1665         (auto_language_data): Likewise.
1666         * language.h (struct language_data): Delete la_search_name_hash
1667         field.
1668         (language_defn::search_name_hash): Declare new member function.
1669         (default_search_name_hash): Delete declaration.
1670         * m2-lang.c (m2_language_data): Delete la_search_name_hash
1671         initializer.
1672         * objc-lang.c (objc_language_data): Likewise.
1673         * opencl-lang.c (opencl_language_data): Likewise.
1674         * p-lang.c (pascal_language_data): Likewise.
1675         * rust-lang.c (rust_language_data): Likewise.
1676         * symtab.c (search_name_hash): Update call.
1677
1678 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1679
1680         * ada-lang.c (ada_language_data): Delete la_get_compile_instance
1681         initializer.
1682         * c-lang.c (class compile_instance): Declare.
1683         (c_language_data): Delete la_get_compile_instance initializer.
1684         (c_language::get_compile_instance): New member function.
1685         (cplus_language_data): Delete la_get_compile_instance initializer.
1686         (cplus_language::get_compile_instance): New member function.
1687         (asm_language_data): Delete la_get_compile_instance initializer.
1688         (minimal_language_data): Likewise.
1689         * c-lang.h (c_get_compile_context): Update comment.
1690         (cplus_get_compile_context): Update comment.
1691         * compile/compile.c (compile_to_object): Update calls, don't rely
1692         on function pointer being NULL.
1693         * d-lang.c (d_language_data): Delete la_get_compile_instance
1694         initializer.
1695         * f-lang.c (f_language_data): Likewise.
1696         * go-lang.c (go_language_data): Likewise.
1697         * language.c (unknown_language_data): Likewise.
1698         (auto_language_data): Likewise.
1699         * language.h (language_data): Delete la_get_compile_instance field.
1700         (language_defn::get_compile_instance): New member function.
1701         * m2-lang.c (m2_language_data): Delete la_get_compile_instance
1702         initializer.
1703         * objc-lang.c (objc_language_data): Likewise.
1704         * opencl-lang.c (opencl_language_data): Likewise.
1705         * p-lang.c (pascal_language_data): Likewise.
1706         * rust-lang.c (rust_language_data): Likewise.
1707
1708 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1709
1710         * ada-lang.c (ada_add_all_symbols): Update comment.
1711         (ada_iterate_over_symbols): Delete, move implementation to...
1712         (ada_language::iterate_over_symbols): ...here, a new member
1713         function, rewrite to use range based for loop.
1714         (ada_language_data): Delete la_iterate_over_symbols initializer.
1715         * c-lang.c (c_language_data): Likewise.
1716         (cplus_language_data): Likewise.
1717         (asm_language_data): Likewise.
1718         (minimal_language_data): Likewise.
1719         * d-lang.c (d_language_data): Likewise.
1720         * f-lang.c (f_language_data): Likewise.
1721         * go-lang.c (go_language_data): Likewise.
1722         * language.c (unknown_language_data): Likewise.
1723         (auto_language_data): Likewise.
1724         * language.h (language_data): Delete la_iterate_over_symbols field.
1725         (language_defn::iterate_over_symbols): New member function.
1726         (LA_ITERATE_OVER_SYMBOLS): Update.
1727         * linespec.c (iterate_over_all_matching_symtabs): Update.
1728         * m2-lang.c (m2_language_data): Delete la_iterate_over_symbols
1729         initializer.
1730         * objc-lang.c (objc_language_data): Likewise.
1731         * opencl-lang.c (opencl_language_data): Likewise.
1732         * p-lang.c (pascal_language_data): Likewise.
1733         * rust-lang.c (rust_language_data): Likewise.
1734
1735 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1736
1737         * ada-lang.c (ada_language_data): Delete
1738         la_lookup_transparent_type initializer.
1739         * c-lang.c (c_language_data): Likewise.
1740         (cplus_language_data): Likewise.
1741         (cplus_language::lookup_transparent_type): New member function.
1742         (asm_language_data): Delete la_lookup_transparent_type
1743         initializer.
1744         (minimal_language_data): Likewise.
1745         * d-lang.c (d_language_data): Likewise.
1746         * f-lang.c (f_language_data): Likewise.
1747         * go-lang.c (go_language_data): Likewise.
1748         * language.c (unknown_language_data): Likewise.
1749         (auto_language_data): Likewise.
1750         * language.h (struct language_data): Delete
1751         la_lookup_transparent_type field.
1752         (language_defn::lookup_transparent_type): New member function.
1753         * m2-lang.c (m2_language_data): Delete la_lookup_transparent_type
1754         initializer.
1755         * objc-lang.c (objc_language_data): Likewise.
1756         * opencl-lang.c (opencl_language_data): Likewise.
1757         * p-lang.c (pascal_language_data): Likewise.
1758         * rust-lang.c (rust_language_data): Likewise.
1759         * symtab.c (symbol_matches_domain): Update call.
1760
1761 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1762
1763         * ada-lang.c (ada_language_arch_info): Delete function, move
1764         implementation to...
1765         (ada_language::language_arch_info): ...here, a new member
1766         function.
1767         (ada_language_data): Delete la_language_arch_info.
1768         * c-lang.c (c_language_data): Likewise.
1769         (c_language::language_arch_info): New member function.
1770         (cplus_language_arch_info): Delete function, move
1771         implementation to...
1772         (cplus_language::language_arch_info): ...here, a new member
1773         function.
1774         (cplus_language_data): Delete la_language_arch_info.
1775         (asm_language_data): Likewise.
1776         (asm_language::language_arch_info): New member function.
1777         (minimal_language_data): Delete la_language_arch_info.
1778         (minimal_language::language_arch_info): New member function.
1779         * d-lang.c (d_language_arch_info): Delete function, move
1780         implementation to...
1781         (d_language::language_arch_info): ...here, a new member
1782         function.
1783         (d_language_data): Delete la_language_arch_info.
1784         * f-lang.c (f_language_arch_info): Delete function, move
1785         implementation to...
1786         (f_language::language_arch_info): ...here, a new member
1787         function.
1788         (f_language_data): Delete la_language_arch_info.
1789         * go-lang.c (go_language_arch_info): Delete function, move
1790         implementation to...
1791         (go_language::language_arch_info): ...here, a new member
1792         function.
1793         (go_language_data): Delete la_language_arch_info.
1794         * language.c (unknown_language_data): Likewise.
1795         (unknown_language::language_arch_info): New member function.
1796         (auto_language_data): Delete la_language_arch_info.
1797         (auto_language::language_arch_info): New member function.
1798         (language_gdbarch_post_init): Update call to
1799         la_language_arch_info.
1800         * language.h (language_data): Delete la_language_arch_info
1801         function pointer.
1802         (language_defn::language_arch_info): New function.
1803         * m2-lang.c (m2_language_arch_info): Delete function, move
1804         implementation to...
1805         (m2_language::language_arch_info): ...here, a new member
1806         function.
1807         (m2_language_data): Delete la_language_arch_info.
1808         * objc-lang.c (objc_language_arch_info): Delete function, move
1809         implementation to...
1810         (objc_language::language_arch_info): ...here, a new member
1811         function.
1812         (objc_language_data): Delete la_language_arch_info.
1813         * opencl-lang.c (opencl_language_arch_info): Delete function, move
1814         implementation to...
1815         (opencl_language::language_arch_info): ...here, a new member
1816         function.
1817         (opencl_language_data): Delete la_language_arch_info.
1818         * p-lang.c (pascal_language_arch_info): Delete function, move
1819         implementation to...
1820         (pascal_language::language_arch_info): ...here, a new member
1821         function.
1822         (pascal_language_data): Delete la_language_arch_info.
1823         * rust-lang.c (rust_language_arch_info): Delete function, move
1824         implementation to...
1825         (rust_language::language_arch_info): ...here, a new member
1826         function.
1827         (rust_language_data): Delete la_language_arch_info.
1828
1829 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1830
1831         * ada-lang.c (ada_language_data): Delete la_pass_by_reference
1832         initializer.
1833         * c-lang.c (c_language_data): Likewise.
1834         (cplus_language_data): Likewise.
1835         (cplus_language::pass_by_reference_info): New method.
1836         (asm_language_data): Delete la_pass_by_reference initializer.
1837         (minimal_language_data): Likewise.
1838         * cp-abi.c (cp_pass_by_reference): Remove use of
1839         default_pass_by_reference.
1840         * d-lang.c (d_language_data): Likewise.
1841         * f-lang.c (f_language_data): Likewise.
1842         * gnu-v3-abi.c (gnuv3_pass_by_reference): Remove use of
1843         default_pass_by_reference.
1844         * go-lang.c (go_language_data): Likewise.
1845         * language.c (language_pass_by_reference): Update.
1846         (default_pass_by_reference): Delete.
1847         (unknown_language_data): Delete la_pass_by_reference
1848         initializer.
1849         (auto_language_data): Likewise.
1850         * language.h (struct language_data): Delete la_pass_by_reference
1851         field.
1852         (language_defn::pass_by_reference_info): New member function.
1853         (default_pass_by_reference): Delete declaration.
1854         * m2-lang.c (m2_language_data): Delete la_pass_by_reference
1855         initializer.
1856         * objc-lang.c (objc_language_data): Likewise.
1857         * opencl-lang.c (opencl_language_data): Likewise.
1858         * p-lang.c (pascal_language_data): Likewise.
1859         * rust-lang.c (rust_language_data): Likewise.
1860
1861 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1862
1863         * ada-lang.c (ada_read_var_value): Delete function, move
1864         implementation to...
1865         (ada_language::read_var_value): ...here.
1866         (ada_language_data): Delete la_read_var_value initializer.
1867         * c-lang.c (c_language_data): Likewise.
1868         (cplus_language_data): Likewise.
1869         (minimal_language_data): Likewise.
1870         * d-lang.c (d_language_data): Likewise.
1871         * f-lang.c (f_language_data): Likewise.
1872         * findvar.c (default_read_var_value): Rename to...
1873         (language_defn::read_var_value): ...this.
1874         * findvar.c (read_var_value): Update header comment, and change to
1875         call member function instead of function pointer.
1876         * go-lang.c (go_language_data): Likewise.
1877         * language.c (unknown_language_data): Delete la_read_var_value
1878         initializer.
1879         (auto_language_data): Likewise.
1880         * language.h (struct language_data): Delete la_read_var_value
1881         field.
1882         (language_defn::read_var_value): New member function.
1883         (default_read_var_value): Delete declaration.
1884         * m2-lang.c (m2_language_data): Delete la_read_var_value
1885         initializer.
1886         * objc-lang.c (objc_language_data): Likewise.
1887         * opencl-lang.c (opencl_language_data): Likewise.
1888         * p-lang.c (pascal_language_data): Likewise.
1889         * rust-lang.c (rust_language_data): Likewise.
1890         * value.h (default_read_var_value): Delete declaration.
1891
1892 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1893
1894         * ada-lang.c (ada_print_array_index): Delete function, move
1895         implementation to...
1896         (ada_language::print_array_index): ...here.
1897         (ada_language_data): Delete la_print_array_index initializer.
1898         * c-lang.c (c_language_data): Likewise.
1899         (cplus_language_data): Likewise.
1900         (minimal_language_data): Likewise.
1901         * d-lang.c (d_language_data): Likewise.
1902         * f-lang.c (f_language_data): Likewise.
1903         * go-lang.c (go_language_data): Likewise.
1904         * language.c (default_print_array_index): Delete function, move
1905         implementation to...
1906         (language_defn::print_array_index): ...here.
1907         (unknown_language_data): Delete la_print_array_index initializer.
1908         (auto_language_data): Likewise.
1909         * language.h (struct language_data): Delete la_print_array_index
1910         field.
1911         (language_defn::print_array_index): New member function.
1912         (LA_PRINT_ARRAY_INDEX): Update.
1913         (default_print_array_index): Delete declaration.
1914         * m2-lang.c (m2_language_data): Delete la_print_array_index
1915         initializer.
1916         * objc-lang.c (objc_language_data): Likewise.
1917         * opencl-lang.c (opencl_language_data): Likewise.
1918         * p-lang.c (pascal_language_data): Likewise.
1919         * rust-lang.c (rust_language_data): Likewise.
1920
1921 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1922
1923         * gdb/ada-lang.c (ada_language_defn): Convert to...
1924         (ada_language_data): ...this.
1925         (class ada_language): New class.
1926         (ada_language_defn): New static global.
1927         * gdb/c-lang.c (c_language_defn): Convert to...
1928         (c_language_data): ...this.
1929         (class c_language): New class.
1930         (c_language_defn): New static global.
1931         (cplus_language_defn): Convert to...
1932         (cplus_language_data): ...this.
1933         (class cplus_language): New class.
1934         (cplus_language_defn): New static global.
1935         (asm_language_defn): Convert to...
1936         (asm_language_data): ...this.
1937         (class asm_language): New class.
1938         (asm_language_defn): New static global.
1939         (minimal_language_defn): Convert to...
1940         (minimal_language_data): ...this.
1941         (class minimal_language): New class.
1942         (minimal_language_defn): New static global.
1943         * gdb/d-lang.c (d_language_defn): Convert to...
1944         (d_language_data): ...this.
1945         (class d_language): New class.
1946         (d_language_defn): New static global.
1947         * gdb/f-lang.c (f_language_defn): Convert to...
1948         (f_language_data): ...this.
1949         (class f_language): New class.
1950         (f_language_defn): New static global.
1951         * gdb/go-lang.c (go_language_defn): Convert to...
1952         (go_language_data): ...this.
1953         (class go_language): New class.
1954         (go_language_defn): New static global.
1955         * gdb/language.c (unknown_language_defn): Remove declaration.
1956         (current_language): Initialize to nullptr, real initialization is
1957         moved to _initialize_language.
1958         (languages): Delete global.
1959         (language_defn::languages): Define.
1960         (set_language_command): Use language_defn::languages.
1961         (set_language): Likewise.
1962         (range_error): Likewise.
1963         (language_enum): Likewise.
1964         (language_def): Likewise.
1965         (add_set_language_command): Use language_def::languages for the
1966         language list, and language_def to lookup language pointers.
1967         (skip_language_trampoline): Use language_defn::languages.
1968         (unknown_language_defn): Convert to...
1969         (unknown_language_data): ...this.
1970         (class unknown_language): New class.
1971         (unknown_language_defn): New static global.
1972         (auto_language_defn): Convert to...
1973         (auto_language_data): ...this.
1974         (class auto_language): New class.
1975         (auto_language_defn): New static global.
1976         (language_gdbarch_post_init): Use language_defn::languages.
1977         (_initialize_language): Initialize current_language.
1978         * gdb/language.h (struct language_defn): Rename to...
1979         (struct language_data): ...this.
1980         (struct language_defn): New.
1981         (auto_language_defn): Delete.
1982         (unknown_language_defn): Delete.
1983         (minimal_language_defn): Delete.
1984         (ada_language_defn): Delete.
1985         (asm_language_defn): Delete.
1986         (c_language_defn): Delete.
1987         (cplus_language_defn): Delete.
1988         (d_language_defn): Delete.
1989         (f_language_defn): Delete.
1990         (go_language_defn): Delete.
1991         (m2_language_defn): Delete.
1992         (objc_language_defn): Delete.
1993         (opencl_language_defn): Delete.
1994         (pascal_language_defn): Delete.
1995         (rust_language_defn): Delete.
1996         * gdb/m2-lang.c (m2_language_defn): Convert to...
1997         (m2_language_data): ...this.
1998         (class m2_language): New class.
1999         (m2_language_defn): New static global.
2000         * gdb/objc-lang.c (objc_language_defn): Convert to...
2001         (objc_language_data): ...this.
2002         (class objc_language): New class.
2003         (objc_language_defn): New static global.
2004         * gdb/opencl-lang.c (opencl_language_defn): Convert to...
2005         (opencl_language_data): ...this.
2006         (class opencl_language): New class.
2007         (opencl_language_defn): New static global.
2008         * gdb/p-lang.c (pascal_language_defn): Convert to...
2009         (pascal_language_data): ...this.
2010         (class pascal_language): New class.
2011         (pascal_language_defn): New static global.
2012         * gdb/rust-exp.y (rust_lex_tests): Use language_def to find
2013         language pointer, update comment format.
2014         * gdb/rust-lang.c (rust_language_defn): Convert to...
2015         (rust_language_data): ...this.
2016         (class rust_language): New class.
2017         (rust_language_defn): New static global.
2018
2019 2020-06-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2020
2021         * dwarf2/read.c (class lnp_state_machine) <m_last_address>: New
2022         member variable.
2023         <m_stmt_at_address>: New member variable.
2024         (lnp_state_machine::record_line): Don't record some lines, update
2025         tracking of is_stmt at the same address.
2026         (lnp_state_machine::lnp_state_machine): Initialise new member
2027         variables.
2028
2029 2020-06-01  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2030
2031         * config/i386/i386gnu.mn [%_S.o %_U.o] (COMPILE.post): Add
2032         "-include gnu-nat-mig.h".
2033         * gnu-nat-mig.h: New file.
2034         * gnu-nat.c: Include "gnu-nat-mig.h".
2035         (exc_server, msg_reply_server, notify_server,
2036         process_reply_server): Remove declarations.
2037
2038 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2039
2040         * gnu-nat.h (inf_validate_procs, inf_suspend, inf_set_traced,
2041         steal_exc_port, proc_get_state, inf_clear_wait, inf_cleanup,
2042         inf_startup, inf_update_suspends, inf_set_pid, inf_steal_exc_ports,
2043         inf_validate_procinfo, inf_validate_task_sc, inf_restore_exc_ports,
2044         inf_set_threads_resume_sc, inf_set_threads_resume_sc_for_signal_thread,
2045         inf_resume, inf_set_step_thread, inf_detach, inf_attach, inf_signal,
2046         inf_continue, make_proc, proc_abort, _proc_free, proc_update_sc,
2047         proc_get_exception_port, proc_set_exception_port, _proc_get_exc_port,
2048         proc_steal_exc_port, proc_restore_exc_port, proc_trace): Move functions
2049         to gnu_nat_target class.
2050         * gnu-nat.c: Likewise.
2051         (inf_update_procs, S_proc_wait_reply, set_task_pause_cmd,
2052         set_task_exc_port_cmd, set_signals_cmd, set_thread_pause_cmd,
2053         set_thread_exc_port_cmd): Call inf_validate_procs through gnu_target
2054         object.
2055         (gnu_nat_target::create_inferior, gnu_nat_target::detach): Pass `this'
2056         instead of `gnu_target'.
2057
2058 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2059
2060         * i386-gnu-tdep.c: Include "gdbcore.h"
2061         (gnu_sigtramp_code, i386_gnu_sc_reg_offset): New arrays.
2062         (GNU_SIGTRAMP_LEN, GNU_SIGTRAMP_TAIL,
2063         I386_GNU_SIGCONTEXT_THREAD_STATE_OFFSET): New macros
2064         (i386_gnu_sigtramp_start, i386_gnu_sigtramp_p,
2065         i386_gnu_sigcontext_addr): New functions
2066         (i386gnu_init_abi): Register i386_gnu_sigtramp_p,
2067         i386_gnu_sigcontext_addr, and i386_gnu_sc_reg_offset in the gdbarch
2068         tdep.
2069
2070 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2071
2072         * gnu-nat.c (gnu_nat_target::create_inferior): Move push_target call
2073         before fork_inferior call. Avoid calling it if target_is_pushed returns
2074         true.
2075
2076 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2077
2078         * gnu-nat.h (gnu_target): New variable declaration.
2079         * i386-gnu-nat.c (_initialize_i386gnu_nat): Initialize
2080         gnu_target.
2081         * gnu-nat.c (gnu_target): New variable.
2082         (inf_validate_procs): Pass gnu_target to thread_change_ptid,
2083         add_thread_silent, and add_thread calls.
2084         (gnu_nat_target::create_inferior): Pass gnu_target to
2085         add_thread_silent, thread_change_ptid call.
2086         (gnu_nat_target::detach): Pass gnu_target to detach_inferior
2087         call.
2088
2089 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2090
2091         * gnu-nat.c (gnu_xfer_auxv): Remove unused `res' variable.
2092         (gnu_nat_target::find_memory_regions): Remove unused
2093         `old_address' variable.
2094
2095 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2096
2097         * gnu-nat.c: Include "gdbarch.h".
2098
2099 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2100
2101         * reply_mig_hack.awk (Error return): Cast function through
2102         void *, to bypass compiler function call check.
2103
2104 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2105
2106         * config/i386/i386gnu.mn (%_reply_S.c): Add dependency on
2107         $(srcdir)/reply_mig_hack.awk.
2108
2109 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2110
2111         * gnu-nat.h (gnu_debug_flag): Set type to bool.
2112
2113 2020-05-30  Jonny Grant  <jg@jguk.org>
2114
2115         * configure.ac (ACX_BUGURL): change bug URL to https.
2116
2117 2020-05-30  Pedro Alves  <palves@redhat.com>
2118
2119         * cp-support.c (replace_typedefs_template): New.
2120         (replace_typedefs_qualified_name): Handle
2121         DEMANGLE_COMPONENT_TEMPLATE.
2122
2123 2020-05-29  Simon Marchi  <simon.marchi@efficios.com>
2124
2125         * dwarf2/comp-unit.c, dwarf2/comp-unit.h, dwarf2/index-cache.c,
2126         dwarf2/index-cache.h, dwarf2/index-write.c,
2127         dwarf2/index-write.h, dwarf2/line-header.c,
2128         dwarf2/line-header.h, dwarf2/macro.c, dwarf2/macro.h,
2129         dwarf2/read.c, dwarf2/read.h: Rename struct dwarf2_per_objfile
2130         variables and fields from `dwarf2_per_objfile` to just
2131         `per_objfile` throughout.
2132
2133 2020-05-28  Simon Marchi  <simon.marchi@polymtl.ca>
2134
2135         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
2136         <push_dwarf_reg_entry_value>: Add comment.
2137
2138 2020-05-28  Kevin Buettner  <kevinb@redhat.com>
2139             Keith Seitz  <keiths@redhat.com>
2140
2141         * python/python.c (do_start_initialization): Call PyEval_SaveThread
2142         instead of PyEval_ReleaseLock.
2143         (class gdbpy_gil): Move to earlier in file.
2144         (finalize_python): Set gdb_python_initialized.
2145         (gdbpy_check_quit_flag): Acquire GIL via gdbpy_gil.  Return early
2146         when not initialized.
2147
2148 2020-05-28  Simon Marchi  <simon.marchi@efficios.com>
2149
2150         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
2151         <push_dwarf_reg_entry_value>: Remove assert.  Override
2152         per_objfile with caller_per_objfile.
2153
2154 2020-05-28  Tom de Vries  <tdevries@suse.de>
2155
2156         * dwarf2/read.c (dw2_symtab_iter_next, dw2_expand_marked_cus): Limit
2157         PR gold/15646 workaround to symbol kind "type".
2158
2159 2020-05-27  Tom Tromey  <tromey@adacore.com>
2160
2161         * dwarf2/read.c (load_partial_dies): Use add_partial_symbol.
2162
2163 2020-05-27  Tom Tromey  <tromey@adacore.com>
2164
2165         * dwarf2/abbrev.h (struct abbrev_table) <lookup_abbrev>: Inline.
2166         Use htab_find_with_hash.
2167         <add_abbrev>: Remove "abbrev_number" parameter.
2168         * dwarf2/abbrev.c (abbrev_table::add_abbrev): Remove
2169         "abbrev_number" parameter.  Use htab_find_slot_with_hash.
2170         (hash_abbrev): Add comment.
2171         (abbrev_table::lookup_abbrev): Move to header file.
2172         (abbrev_table::read): Update.
2173
2174 2020-05-27  Tom Tromey  <tromey@adacore.com>
2175
2176         * dwarf2/read.c (struct partial_die_info) <name>: Declare new
2177         method.
2178         <canonical_name>: New member.
2179         <raw_name>: Rename from "name".
2180         (partial_die_info): Initialize canonical_name.
2181         (scan_partial_symbols): Check raw_name.
2182         (partial_die_parent_scope, partial_die_full_name)
2183         (add_partial_symbol, add_partial_subprogram)
2184         (add_partial_enumeration, load_partial_dies): Use "name" method.
2185         (partial_die_info::name): New method.
2186         (partial_die_info::read, guess_partial_die_structure_name)
2187         (partial_die_info::fixup): Update.
2188
2189 2020-05-27  Tom Tromey  <tromey@adacore.com>
2190
2191         * dwarf2/attribute.h (struct attribute) <form_is_ref>: Inline.
2192         <get_ref_die_offset>: Inline.
2193         <get_ref_die_offset_complaint>: New method.
2194         * dwarf2/attribute.c (attribute::form_is_ref): Move to header.
2195         (attribute::get_ref_die_offset_complaint): Rename from
2196         get_ref_die_offset.  Just issue complaint.
2197
2198 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
2199
2200         * cli/cli-cmds.c (shell_escape): Move exit_status_set_internal_vars.
2201
2202 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
2203
2204         * exec.c (exec_file_attach): Use errno value of first openp failure.
2205
2206 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
2207
2208         * nat/windows-nat.c (windows_thread_info::~windows_thread_info):
2209         Don't close thread handle.
2210
2211 2020-05-27  Tom Tromey  <tom@tromey.com>
2212             Simon Marchi  <simon.marchi@efficios.com>
2213
2214         * objfiles.h (struct objfile) <partial_symtabs>: Now a
2215         shared_ptr.
2216         * dwarf2/read.h (struct dwarf2_per_objfile) <partial_symtabs>: New
2217         member.
2218         * dwarf2/read.c (dwarf2_per_bfd_bfd_data_key,
2219         dwarf2_per_bfd_objfile_data_key>: New globals.
2220         (dwarf2_has_info): Use shared dwarf2_per_bfd if possible.
2221         (dwarf2_get_section_info): Use get_dwarf2_per_objfile.
2222         (dwarf2_initialize_objfile): Consider cases where per_bfd can be
2223         shared.
2224         (dwarf2_build_psymtabs): Set objfile::partial_symtabs and
2225         short-circuit when sharing.
2226         (dwarf2_build_psymtabs): Set dwarf2_per_objfile::partial_symtabs.
2227         (dwarf2_psymtab::expand_psymtab): Use free_cached_comp_units.
2228
2229 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2230
2231         * dwarf2/read.h (struct dwarf2_per_bfd) <line_header_hash>: Move
2232         to...
2233         (struct dwarf2_per_objfile) <line_header_hash>: ... here.
2234         * dwarf2/read.c (handle_DW_AT_stmt_list): Update.
2235
2236 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2237
2238         * dwarf2/read.c (struct mapped_index_base) <symbol_name_at,
2239         build_name_components, find_name_components_bounds>:
2240         Add per_objfile parameter.
2241         (struct mapped_index) <symbol_name_at>: Likewise.
2242         (struct mapped_debug_names): Remove constructor.
2243         <dwarf2_per_objfile>: Remove field.
2244         <namei_to_name, symbol_name_at>: Add per_objfile parameter.
2245         (mapped_index_base::find_name_components_bounds,
2246         mapped_index_base::build_name_components,
2247         dw2_expand_symtabs_matching_symbol): Likewise.
2248         (class mock_mapped_index) <symbol_name_at>: Likewise.
2249         (check_match): Likewise.
2250         (check_find_bounds_finds): Likewise.
2251         (test_mapped_index_find_name_component_bounds): Update.
2252         (CHECK_MATCH): Update.
2253         (dw2_expand_symtabs_matching): Update.
2254         (class dw2_debug_names_iterator) <dw2_debug_names_iterator>: Add
2255         per_objfile parameter.
2256         <find_vec_in_debug_names>: Likewise.
2257         <m_per_objfile>: New field.
2258         (mapped_debug_names::namei_to_name): Add dwarf2_per_objfile
2259         parameter.
2260         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
2261         (dw2_debug_names_iterator::next): Update.
2262         (dw2_debug_names_lookup_symbol): Update.
2263         (dw2_debug_names_expand_symtabs_for_function): Update.
2264         (dw2_debug_names_map_matching_symbols): Update.
2265         (dw2_debug_names_expand_symtabs_matching): Update.
2266         (dwarf2_read_debug_names): Update.
2267
2268 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2269
2270         * dwarf2/read.h (struct dwarf2_cu): Forward-declare.
2271         (struct dwarf2_per_bfd) <free_cached_comp_units>: Remove,
2272         move to dwarf2_per_objfile.
2273         <read_in_chain>: Remove.
2274         (struct dwarf2_per_objfile) <get_cu, set_cu, remove_cu,
2275         remove_all_cus, age_comp_units>: New methods.
2276         <m_dwarf2_cus>: New member.
2277         (struct dwarf2_per_cu_data) <cu>: Remove.
2278         * dwarf2/read.c (struct dwarf2_cu) <read_in_chain>: Remove.
2279         (age_cached_comp_units, free_one_cached_comp_unit): Remove,
2280         moved to methods of dwarf2_per_objfile.
2281         (dwarf2_clear_marks): Remove.
2282         (dwarf2_queue_item::~dwarf2_queue_item): Update.
2283         (dwarf2_per_bfd::~dwarf2_per_bfd): Don't free dwarf2_cus.
2284         (dwarf2_per_bfd::free_cached_comp_units): Remove.
2285         (dwarf2_per_objfile::remove_all_cus): New.
2286         (class free_cached_comp_units) <~free_cached_comp_units>:
2287         Update.
2288         (load_cu): Update.
2289         (dw2_do_instantiate_symtab): Adjust.
2290         (fill_in_sig_entry_from_dwo_entry): Adjust.
2291         (cutu_reader::init_tu_and_read_dwo_dies): Update.
2292         (cutu_reader::cutu_reader): Likewise.
2293         (cutu_reader::keep): Use dwarf2_per_objfile::set_cu.
2294         (cutu_reader::cutu_reader): Use dwarf2_per_objfile::get_cu.
2295         (process_psymtab_comp_unit): Use dwarf2_per_objfile::remove_cu
2296         and dwarf2_per_objfile::age_comp_units.
2297         (load_partial_comp_unit): Update.
2298         (maybe_queue_comp_unit): Use dwarf2_per_objfile::get_cu.
2299         (process_queue): Likewise.
2300         (find_partial_die): Use dwarf2_per_objfile::get_cu instead of cu
2301         backlink.
2302         (dwarf2_read_addr_index): Likewise.
2303         (follow_die_offset): Likewise.
2304         (dwarf2_fetch_die_loc_sect_off): Likewise.
2305         (dwarf2_fetch_constant_bytes): Likewise.
2306         (dwarf2_fetch_die_type_sect_off): Likewise.
2307         (follow_die_sig_1): Likewise.
2308         (load_full_type_unit): Likewise.
2309         (read_signatured_type): Likewise.
2310         (dwarf2_cu::dwarf2_cu): Don't set cu field.
2311         (dwarf2_cu::~dwarf2_cu): Remove.
2312         (dwarf2_per_objfile::get_cu): New.
2313         (dwarf2_per_objfile::set_cu): New.
2314         (age_cached_comp_units): Rename to...
2315         (dwarf2_per_objfile::age_comp_units): ... this.  Adjust
2316         to std::unordered_map.
2317         (free_one_cached_comp_unit): Rename to...
2318         (dwarf2_per_objfile::remove_cu): ... this.  Adjust
2319         to std::unordered_map.
2320         (dwarf2_per_objfile::~dwarf2_per_objfile): New.
2321         (dwarf2_mark_helper): Use dwarf2_per_objfile::get_cu, expect
2322         a dwarf2_per_objfile in data.
2323         (dwarf2_mark): Pass dwarf2_per_objfile in data to htab_traverse.
2324         (dwarf2_clear_marks): Remove.
2325
2326 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2327
2328         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Replace
2329         `int use_existing_cu` parameter with `dwarf2_cu *existing_cu`.
2330         (init_tu_and_read_dwo_dies): Likewise.
2331         (cutu_reader::init_tu_and_read_dwo_dies): Likewise.
2332         (cutu_reader::cutu_reader): Likewise.
2333         (load_partial_comp_unit): Likewise.
2334         (process_psymtab_comp_unit): Update.
2335         (build_type_psymtabs_1): Update.
2336         (process_skeletonless_type_unit): Update.
2337         (load_full_comp_unit): Update.
2338         (find_partial_die): Update.
2339         (dwarf2_read_addr_index): Update.
2340         (read_signatured_type): Update.
2341
2342 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2343
2344         * dwarf2/read.h (struct dwarf2_per_cu_data) <m_header,
2345         m_header_read_in>: New fields.
2346         <get_header>: New method.
2347         * dwarf2/read.c (per_cu_header_read_in): Remove.
2348         (dwarf2_per_cu_data::get_header): New.
2349         (dwarf2_per_cu_data::addr_size): Update.
2350         (dwarf2_per_cu_data::offset_size): Update.
2351         (dwarf2_per_cu_data::ref_addr_size): Update.
2352
2353 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2354
2355         * dwarf2/read.c (load_cu): Return dwarf2_cu.
2356         (dw2_do_instantiate_symtab): Update.
2357         (queue_and_load_all_dwo_tus): Change parameter from
2358         dwarf2_per_cu_data to dwarf2_cu.
2359         (dwarf2_fetch_die_loc_sect_off): Update.
2360         (dwarf2_fetch_constant_bytes): Update.
2361         (dwarf2_fetch_die_type_sect_off): Update.
2362
2363 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2364
2365         * dwarf2/read.c (process_full_comp_unit,
2366         process_full_type_unit): Remove per_cu, per_objfile paramters.
2367         Add dwarf2_cu parameter.
2368         (process_queue): Update.
2369
2370 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2371
2372         * dwarf2/read.c (create_cu_from_index_list): Replace
2373         dwarf2_per_objfile parameter with dwarf2_per_bfd.
2374         (create_cus_from_index_list): Likewise.
2375         (create_cus_from_index): Likewise.
2376         (create_signatured_type_table_from_index): Likewise.
2377         (create_cus_from_debug_names_list): Likewise.
2378         (create_cus_from_debug_names): Likewise.
2379         (dwarf2_read_gdb_index): Update.
2380         (dwarf2_read_debug_names): Update.
2381
2382 2020-05-27  Tom Tromey  <tom@tromey.com>
2383             Simon Marchi  <simon.marchi@efficios.com>
2384
2385         * dwarf2/read.h (struct dwarf2_per_objfile)
2386         <get_type_for_signatured_type, set_type_for_signatured_type>:
2387         New methods.
2388         <m_type_map>: New member.
2389         (struct signatured_type) <type>: Remove.
2390         * dwarf2/read.c
2391         (dwarf2_per_objfile::get_type_for_signatured_type,
2392         dwarf2_per_objfile::set_type_for_signatured_type): New.
2393         (get_signatured_type): Use new methods.
2394
2395 2020-05-27  Tom Tromey  <tom@tromey.com>
2396             Simon Marchi  <simon.marchi@efficios.com>
2397
2398         * dwarf2/read.h (struct type_unit_group_unshareable): New.
2399         (struct dwarf2_per_objfile) <type_units>: New member.
2400         <get_type_unit_group_unshareable>: New method.
2401         * dwarf2/read.c (struct type_unit_group) <compunit_symtab,
2402         num_symtabs, symtabs>: Remove; move to
2403         type_unit_group_unshareable.
2404         (dwarf2_per_objfile::get_type_unit_group_unshareable): New.
2405         (process_full_type_unit, dwarf2_cu::setup_type_unit_groups)
2406         (dwarf2_cu::setup_type_unit_groups): Use type_unit_group_unshareable.
2407
2408 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2409
2410         * dwarf2/read.h (struct dwarf2_per_cu_data):
2411         <dwarf2_per_objfile>: Remove.
2412         * dwarf2/read.c (create_cu_from_index_list): Don't assign
2413         dwarf2_per_objfile.
2414         (create_signatured_type_table_from_index): Likewise.
2415         (create_signatured_type_table_from_debug_names): Likewise.
2416         (create_debug_type_hash_table): Likewise.
2417         (fill_in_sig_entry_from_dwo_entry): Likewise.
2418         (create_type_unit_group): Likewise.
2419         (read_comp_units_from_section): Likewise.
2420         (create_cus_hash_table): Likewise.
2421
2422 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2423
2424         * dwarf2/read.c (process_psymtab_comp_unit): Remove reference to
2425         dwarf2_per_cu_data::dwarf2_per_objfile.
2426         (compute_compunit_symtab_includes): Likewise.
2427         (dwarf2_cu::start_symtab): Likewise.
2428
2429 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2430
2431         * dwarf2/read.h (dwarf2_get_die_type): Add dwarf2_per_objfile
2432         parameter.
2433         * dwarf2/read.c (get_die_type_at_offset): Likewise.
2434         (read_namespace_alias): Update.
2435         (lookup_die_type): Update.
2436         (dwarf2_get_die_type): Add dwarf2_per_objfile parameter.
2437         * dwarf2/loc.c (class dwarf_evaluate_loc_desc) <get_base_type>:
2438         Update.
2439         (disassemble_dwarf_expression): Update.
2440
2441 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2442
2443         * dwarf2/read.h (struct dwarf2_queue_item): Add
2444         dwarf2_per_objfile parameter, assign new parameter.
2445         <per_objfile>: New field.
2446         * dwarf2/read.c (free_one_cached_comp_unit): Add
2447         dwarf2_per_objfile parameter.
2448         (queue_comp_unit): Likewise.
2449         (dw2_do_instantiate_symtab): Update.
2450         (process_psymtab_comp_unit): Update.
2451         (maybe_queue_comp_unit): Add dwarf2_per_objfile parameter.
2452         (process_imported_unit_die): Update.
2453         (queue_and_load_dwo_tu): Update.
2454         (follow_die_offset): Update.
2455         (follow_die_sig_1): Update.
2456
2457 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2458
2459         * dwarf2/read.h (struct dwarf2_per_cu_data) <objfile>: Remove.
2460         * dwarf2/read.c (dwarf2_compute_name): Pass per_objfile down.
2461         (read_call_site_scope): Assign per_objfile.
2462         (dwarf2_per_cu_data::objfile): Remove.
2463         * gdbtypes.h (struct call_site) <per_objfile>: New member.
2464         * dwarf2/loc.h (dwarf2_evaluate_loc_desc): Add
2465         dwarf2_per_objfile parameter.
2466         * dwarf2/loc.c (dwarf2_evaluate_loc_desc_full): Add
2467         dwarf2_per_objfile parameter.
2468         (dwarf_expr_reg_to_entry_parameter): Add output
2469         dwarf2_per_objfile parameter.
2470         (locexpr_get_frame_base): Update.
2471         (class dwarf_evaluate_loc_desc) <get_tls_address>: Update.
2472         <push_dwarf_reg_entry_value>: Update.
2473         <call_site_to_target_addr>: Update.
2474         (dwarf_entry_parameter_to_value): Add dwarf2_per_objfile
2475         parameter.
2476         (value_of_dwarf_reg_entry): Update.
2477         (rw_pieced_value): Update.
2478         (indirect_synthetic_pointer): Update.
2479         (dwarf2_evaluate_property): Update.
2480         (dwarf2_loc_desc_get_symbol_read_needs): Add dwarf2_per_objfile
2481         parameter.
2482         (locexpr_read_variable): Update.
2483         (locexpr_get_symbol_read_needs): Update.
2484         (loclist_read_variable): Update.
2485
2486 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2487
2488         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
2489         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2490         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
2491         parameter.
2492         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
2493         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2494         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
2495         parameter.
2496         * dwarf2/loc.c (indirect_synthetic_pointer, per_cu_dwarf_call,
2497         sect_variable_value): Add dwarf2_per_objfile parameter.
2498         (class dwarf_evaluate_loc_desc) <dwarf_call,
2499         dwarf_variable_value>: Update.
2500         (fetch_const_value_from_synthetic_pointer): Add
2501         dwarf2_per_objfile parameter.
2502         (fetch_const_value_from_synthetic_pointer): Update.
2503         (coerced_pieced_ref): Update.
2504         (class symbol_needs_eval_context) <dwarf_call,
2505         dwarf_variable_value>: Update.
2506         (dwarf2_compile_expr_to_ax): Update.
2507
2508 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2509
2510         * dwarf2/loc.c (allocate_piece_closure): Add dwarf2_per_objfile
2511         parameter.
2512         (dwarf2_evaluate_loc_desc_full): Update.
2513
2514 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2515
2516         * dwarf2/read.h (dwarf2_read_addr_index): Add dwarf2_per_objfile
2517         parameter.
2518         * dwarf2/read.c (dwarf2_read_addr_index): Likewise.
2519         * dwarf2/loc.c (decode_debug_loclists_addresses): Add
2520         dwarf2_per_objfile parameter.
2521         (decode_debug_loc_dwo_addresses): Likewise.
2522         (dwarf2_find_location_expression): Update.
2523         (class dwarf_evaluate_loc_desc) <get_addr_index>: Update.
2524         (locexpr_describe_location_piece): Add dwarf2_per_objfile
2525         parameter.
2526         (disassemble_dwarf_expression): Add dwarf2_per_objfile
2527         parameter.
2528         (locexpr_describe_location_1): Likewise.
2529         (locexpr_describe_location): Update.
2530
2531 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2532
2533         * dwarf2/read.h (struct dwarf2_per_cu_data) <text_offset>:
2534         Remove.
2535         * dwarf2/read.c (dwarf2_per_cu_data::text_offset): Remove.
2536         * dwarf2/loc.c (dwarf2_find_location_expression): Update.
2537         (dwarf2_compile_property_to_c): Update.
2538         (dwarf2_compile_expr_to_ax): Add dwarf2_per_objfile parameter,
2539         use text offset from objfile.
2540         (locexpr_tracepoint_var_ref): Update.
2541         (locexpr_generate_c_location): Update.
2542         (loclist_describe_location): Update.
2543         (loclist_tracepoint_var_ref): Update.
2544         * dwarf2/compile.h (compile_dwarf_bounds_to_c): Add
2545         dwarf2_per_objfile parameter.
2546         * dwarf2/loc2c.c (do_compile_dwarf_expr_to_c): Likewise,
2547         use text offset from objfile.
2548         (compile_dwarf_expr_to_c): Add dwarf2_per_objfile parameter.
2549
2550 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2551
2552         * dwarf2/expr.h (struct dwarf_expr_context)
2553         <dwarf_expr_context>: Add dwarf2_per_objfile parameter.
2554         <offset>: Remove.
2555         <per_objfile>: New member.
2556         * dwarf2/expr.c (dwarf_expr_context::dwarf_expr_context): Add
2557         dwarf2_per_objfile parameter.  Don't set offset, set
2558         per_objfile.
2559         (dwarf_expr_context::execute_stack_op): Use offset from objfile.
2560         * dwarf2/frame.c (dwarf2_frame_find_fde): Return (by parameter)
2561         a dwarf2_per_objfile object instead of an offset.
2562         (class dwarf_expr_executor) <dwarf_expr_executor>: Add
2563         constructor.
2564         (execute_stack_op): Add dwarf2_per_objfile parameter, pass it
2565         to dwarf2_expr_executor constructor.  Don't set offset.
2566         (dwarf2_fetch_cfa_info): Update.
2567         (struct dwarf2_frame_cache) <text_offset>: Remove.
2568         <per_objfile>: New field.
2569         (dwarf2_frame_cache): Update.
2570         (dwarf2_frame_prev_register): Update.
2571         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
2572         <dwarf_evaluate_loc_desc>: Add constructor.
2573         (dwarf2_evaluate_loc_desc_full): Update.
2574         (dwarf2_locexpr_baton_eval): Update.
2575         (class symbol_needs_eval_context) <symbol_needs_eval_context>:
2576         Add constructor.
2577         (dwarf2_loc_desc_get_symbol_read_needs): Update.
2578
2579 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2580
2581         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_type,
2582         addr_sized_int_type>: Move to dwarf2_cu.
2583         <int_type>: Move to dwarf2_per_objfile.
2584         (struct dwarf2_per_objfile) <int_type>: Move here.
2585         * dwarf2/read.c (struct dwarf2_cu) <addr_type,
2586         addr_sized_int_type>: Move here.
2587         (read_func_scope): Update.
2588         (read_array_type): Update.
2589         (read_tag_string_type): Update.
2590         (attr_to_dynamic_prop): Update.
2591         (dwarf2_per_cu_data::int_type): Rename to...
2592         (dwarf2_per_objfile::int_type): ... this.
2593         (dwarf2_per_cu_data::addr_sized_int_type): Rename to...
2594         (dwarf2_cu::addr_sized_int_type): ... this.
2595         (read_subrange_type): Update.
2596         (dwarf2_per_cu_data::addr_type): Rename to...
2597         (dwarf2_cu::addr_type): ... this.
2598         (set_die_type): Update.
2599
2600 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2601
2602         * dwarf2/read.c (queue_and_load_all_dwo_tus): Access per_objfile
2603         data through per_cu->cu.
2604
2605 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2606
2607         * dwarf2/read.c (lookup_dwo_comp_unit): Change
2608         dwarf2_per_cu_data parameter fo dwarf2_cu.
2609         (lookup_dwo_type_unit): Likewise.
2610         (read_cutu_die_from_dwo): Likewise.
2611         (lookup_dwo_unit): Likewise.
2612         (open_and_init_dwo_file): Likewise.
2613         (lookup_dwo_cutu): Likewise.
2614         (lookup_dwo_comp_unit): Likewise.
2615         (lookup_dwo_type_unit): Likewise.
2616         (cutu_reader::init_tu_and_read_dwo_dies): Update.
2617         (cutu_reader::cutu_reader): Update.
2618
2619 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2620
2621         * dwarf2/read.c (process_full_comp_unit): Add dwarf2_per_objfile
2622         parameter.
2623         (process_full_type_unit): Likewise.
2624         (process_queue): Update.
2625
2626 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2627
2628         * dwarf2/read.c (recursively_compute_inclusions): Add
2629         dwarf2_per_objfile parameter.
2630         (compute_compunit_symtab_includes): Likewise.
2631         (process_cu_includes): Update.
2632
2633 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2634
2635         * dwarf2/read.c (create_partial_symtab): Add dwarf2_per_objfile
2636         parameter.
2637         (create_type_unit_group): Update.
2638         (process_psymtab_comp_unit_reader): Update.
2639         (build_type_psymtabs_reader): Update.
2640
2641 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2642
2643         * dwarf2/read.c (cutu_reader::keep): Access dwarf2_per_objfile
2644         object through m_this_cu->cu.
2645
2646 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2647
2648         * dwarf2/read.c (queue_and_load_dwo_tu): Expect a dwarf2_cu as
2649         the info parameter.
2650         (queue_and_load_all_dwo_tus): Pass per_cu->cu.
2651
2652 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2653
2654         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Add
2655         per_objfile parameter.
2656         (load_full_type_unit): Add per_objfile parameter.
2657         (read_signatured_type): Likewise.
2658         (load_full_comp_unit): Likewise.
2659         (load_cu): Likewise.
2660         (dw2_do_instantiate_symtab): Likewise.
2661         (dw2_get_file_names): Likewise.
2662         (dw2_map_symtabs_matching_filename): Update.
2663         (dw_expand_symtabs_matching_file_matcher): Update.
2664         (dw2_map_symbol_filenames): Update.
2665         (process_psymtab_comp_unit): Add per_objfile parameter.
2666         (build_type_psymtabs_1): Update.
2667         (process_skeletonless_type_unit): Update.
2668         (dwarf2_build_psymtabs_hard): Update.
2669         (load_partial_comp_unit): Add per_objfile parameter.
2670         (scan_partial_symbols): Update.
2671         (load_full_comp_unit): Add per_objfile parameter.
2672         (process_imported_unit_die): Update.
2673         (create_cus_hash_table): Update.
2674         (find_partial_die): Update.
2675         (dwarf2_read_addr_index): Update.
2676         (follow_die_offset): Update.
2677         (dwarf2_fetch_die_loc_sect_off): Update.
2678         (dwarf2_fetch_constant_bytes): Update.
2679         (dwarf2_fetch_die_type_sect_off): Update.
2680         (follow_die_sig_1): Update.
2681         (load_full_type_unit): Add per_objfile parameter.
2682         (read_signatured_type): Likewise.
2683
2684 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2685
2686         * dwarf2/read.c (lookup_dwo_unit): Use bfd_get_filename instead
2687         of objfile_name.
2688
2689 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2690
2691         * dwarf2/read.h (struct dwarf2_per_bfd) <obfd>: New member.
2692         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
2693         * dwarf2/read.c (dwarf2_per_bfd::dwarf2_per_bfd): Assign obfd
2694         field.
2695         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
2696         (create_cus_from_index): Update.
2697         (dwarf2_read_gdb_index): Update.
2698         (create_cus_from_debug_names): Update.
2699         (dwarf2_read_debug_names): Update.
2700         (get_abbrev_section_for_cu): Update.
2701         (create_all_comp_units): Update.
2702         (read_attribute_value): Update.
2703         (get_debug_line_section): Update.
2704         * dwarf2/index-cache.c (index_cache::store): Update.
2705         * dwarf2/index-write.c (save_gdb_index_command): Update.
2706         * dwarf2/macro.c (dwarf_decode_macro_bytes): Update.
2707
2708 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2709
2710         * dwarf2/read.h (struct dwarf2_per_cu_data) <per_bfd>: New
2711         member.
2712         * dwarf2/read.c (dwarf2_per_bfd::allocate_per_cu): Initialize
2713         dwarf2_per_cu_data::per_bfd.
2714         (dwarf2_per_bfd::allocate_signatured_type): Likewise.
2715         (create_type_unit_group): Likewise.
2716         (queue_comp_unit): Remove reference to
2717         per_cu->dwarf2_per_objfile.
2718         (maybe_queue_comp_unit): Likewise.
2719         (fill_in_sig_entry_from_dwo_entry): Assign new field.
2720         (create_cus_hash_table): Assign new field.
2721
2722 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2723
2724         * dwarf2/read.c: Replace
2725         dwarf2_cu->per_cu->dwarf2_per_objfile references with
2726         dwarf2_cu->per_objfile throughout.
2727
2728 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2729
2730         * dwarf2/read.c (dw2_do_instantiate_symtab): Add per_objfile
2731         parameter, don't use per_cu->dwarf2_per_objfile.
2732         (dw2_instantiate_symtab): Likewise.
2733         (dw2_find_last_source_symtab): Update.
2734         (dw2_map_expand_apply): Update.
2735         (dw2_lookup_symbol): Update.
2736         (dw2_expand_symtabs_for_function): Update.
2737         (dw2_expand_all_symtabs): Update.
2738         (dw2_expand_symtabs_with_fullname): Update.
2739         (dw2_expand_symtabs_matching_one): Add per_objfile parameter,
2740         don't use per_cu->dwarf2_per_objfile.
2741         (dw2_expand_marked_cus): Update.
2742         (dw2_find_pc_sect_compunit_symtab): Update.
2743         (dw2_debug_names_lookup_symbol): Update.
2744         (dw2_debug_names_expand_symtabs_for_function): Update.
2745         (dw2_debug_names_map_matching_symbols): Update.
2746         (dwarf2_psymtab::expand_psymtab): Update.
2747
2748 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2749
2750         * dwarf2/read.c (struct dwarf2_cu) <dwarf2_cu>: Add parameter.
2751         <per_objfile>: New member.
2752         (class cutu_reader) <init_tu_and_read_dwo_dies>: Add parameter.
2753         (cutu_reader::init_tu_and_read_dwo_dies): Add parameter, update
2754         call to dwarf2_cu.
2755         (cutu_reader::cutu_reader): Update.
2756         (dwarf2_cu::dwarf2_cu): Add parameter, initialize per_objfile.
2757
2758 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2759
2760         * dwarf2/read.h (struct dwarf2_per_bfd) <die_type_hash>: Move to
2761         struct dwarf2_per_objfile.
2762         (struct dwarf2_per_objfile) <die_type_hash>: Move from struct
2763         dwarf2_per_bfd.
2764         * dwarf2/read.c (set_die_type): Update.
2765         (get_die_type_at_offset): Update.
2766
2767 2020-05-27  Tom Tromey  <tom@tromey.com>
2768             Simon Marchi  <simon.marchi@efficios.com>
2769
2770         * dwarf2/read.h (struct dwarf2_per_bfd) <num_psymtabs>: New
2771         method.
2772         (struct dwarf2_per_objfile) <resize_symtabs, symtab_set_p,
2773         get_symtab, set_symtab>: New methods.
2774         <m_symtabs>: New field.
2775         (struct dwarf2_psymtab): Derive from partial_symtab.
2776         <readin_p, get_compunit_symtab>: Declare methods.
2777         * dwarf2/read.c (dwarf2_per_objfile::symtab_set_p,
2778         dwarf2_per_objfile::get_symtab, dwarf2_per_objfile::set_symtab):
2779         New methods.
2780         (struct dwarf2_per_cu_quick_data) <compunit_symtab>: Remove.
2781         (dw2_do_instantiate_symtab, dw2_instantiate_symtab)
2782         (dw2_map_expand_apply, dw2_map_symtabs_matching_filename)
2783         (dw2_symtab_iter_next, dw2_print_stats)
2784         (dw2_expand_symtabs_with_fullname)
2785         (dw2_expand_symtabs_matching_one)
2786         (dw_expand_symtabs_matching_file_matcher)
2787         (dw2_find_pc_sect_compunit_symtab, dw2_map_symbol_filenames)
2788         (dw2_debug_names_iterator::next)
2789         (dw2_debug_names_map_matching_symbols)
2790         (fill_in_sig_entry_from_dwo_entry, dwarf2_psymtab::read_symtab)
2791         (process_queue, dwarf2_psymtab::expand_psymtab): Update.
2792         (dwarf2_psymtab::readin_p, dwarf2_psymtab::get_compunit_symtab):
2793         New methods.
2794         (get_compunit_symtab, process_full_comp_unit)
2795         (process_full_type_unit): Update.
2796         (dwarf2_build_psymtabs, dwarf2_initialize_objfile, add_type_unit): Call
2797
2798 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2799
2800         * dwarf2/read.h (dwarf2_per_objfile): Rename to dwarf2_per_bfd,
2801         then introduce a new dwarf2_per_objfile type.
2802         <read_line_string>: Move to the new dwarf2_per_objfile type.
2803         <objfile>: Likewise.
2804         (dwarf2_per_bfd): Rename dwarf2_per_objfile to this.
2805         * dwarf2/read.c: Replace references to dwarf2_per_objfile with
2806         dwarf2_per_objfile->per_bfd.
2807         (dwarf2_per_objfile::dwarf2_per_objfile): Rename to...
2808         (dwarf2_per_bfd::dwarf2_per_bfd): ... this.
2809         (dwarf2_per_objfile::free_cached_comp_units): Rename to...
2810         (dwarf2_per_bfd::free_cached_comp_units): ... this.
2811         (dwarf2_has_info): Allocate dwarf2_per_bfd.
2812         (dwarf2_per_objfile::locate_sections): Rename to...
2813         (dwarf2_per_bfd::locate_sections): ... this.
2814         (dwarf2_per_objfile::get_cutu): Rename to...
2815         (dwarf2_per_bfd::get_cutu): ... this.
2816         (dwarf2_per_objfile::get_cu): Rename to...
2817         (dwarf2_per_bfd::get_cu): ... this.
2818         (dwarf2_per_objfile::get_tu): Rename to...
2819         (dwarf2_per_bfd::get_tu): ... this.
2820         (dwarf2_per_objfile::allocate_per_cu): Rename to...
2821         (dwarf2_per_bfd::allocate_per_cu): ... this.
2822         (dwarf2_per_objfile::allocate_signatured_type): Rename to...
2823         (dwarf2_per_bfd::allocate_signatured_type): ... this.
2824         (get_gdb_index_contents_ftype): Change parameter from
2825         dwarf2_per_objfile to dwarf2_per_bfd.
2826         * dwarf2/macro.c, dwarf2/index-write.c: Replace references to
2827         dwarf2_per_objfile with dwarf2_per_objfile->per_bfd.
2828
2829 2020-05-27  Tom Tromey  <tom@tromey.com>
2830             Simon Marchi  <simon.marchi@efficios.com>
2831
2832         * dwarf2/loc.c (struct piece_closure) <per_objfile>: New member.
2833         (allocate_piece_closure): Set "per_objfile" member.
2834         (dwarf2_find_location_expression, dwarf2_locexpr_baton_eval)
2835         (locexpr_describe_location, loclist_describe_location): Use new
2836         member.
2837         * dwarf2/read.c (read_call_site_scope)
2838         (mark_common_block_symbol_computed, attr_to_dynamic_prop)
2839         (dwarf2_const_value_attr, dwarf2_fetch_die_loc_sect_off)
2840         (fill_in_loclist_baton, dwarf2_symbol_mark_computed,
2841         handle_data_member_location): Set per_objfile member.
2842         * dwarf2/loc.h (struct dwarf2_locexpr_baton) <per_objfile>: New
2843         member.
2844         (struct dwarf2_loclist_baton) <per_objfile>: New member.
2845
2846 2020-05-27  Tom Tromey  <tom@tromey.com>
2847
2848         * dwarf2/read.h (struct dwarf2_per_objfile) <allocate_per_cu,
2849         allocate_signatured_type>: Declare new methods.
2850         <m_num_psymtabs>: New member.
2851         (struct dwarf2_per_cu_data) <index>: New member.
2852         * dwarf2/read.c (dwarf2_per_objfile::allocate_per_cu)
2853         (dwarf2_per_objfile::allocate_signatured_type): New methods.
2854         (create_cu_from_index_list): Use allocate_per_cu.
2855         (create_signatured_type_table_from_index)
2856         (create_signatured_type_table_from_debug_names)
2857         (create_debug_type_hash_table, add_type_unit)
2858         (read_comp_units_from_section): Use allocate_signatured_type.
2859
2860 2020-05-27  Tom Tromey  <tom@tromey.com>
2861
2862         * psymtab.c (partial_map_expand_apply)
2863         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
2864         (psym_lookup_global_symbol_language)
2865         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
2866         (psym_print_stats, psym_expand_symtabs_for_function)
2867         (psym_map_symbol_filenames, psym_map_matching_symbols)
2868         (psym_expand_symtabs_matching)
2869         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
2870         (maintenance_check_psymtabs): Update.
2871         * psympriv.h (struct partial_symtab) <readin_p,
2872         get_compunit_symtab>: Add objfile parameter.
2873         (struct standard_psymtab) <readin_p, get_compunit_symtab>:
2874         Likewise.
2875         * dwarf2/read.c (struct dwarf2_include_psymtab) <readin_p,
2876         get_compunit_symtab>: Likewise.
2877         (dwarf2_psymtab::expand_psymtab): Pass objfile argument.
2878
2879 2020-05-27  Tom Tromey  <tom@tromey.com>
2880
2881         * dwarf2/read.h (struct dwarf2_per_objfile) <obstack>: New
2882         member.
2883         * dwarf2/read.c (delete_file_name_entry): Fix comment.
2884         (create_cu_from_index_list)
2885         (create_signatured_type_table_from_index)
2886         (create_signatured_type_table_from_debug_names)
2887         (dw2_get_file_names_reader, dwarf2_initialize_objfile)
2888         (dwarf2_create_include_psymtab)
2889         (create_debug_type_hash_table, add_type_unit)
2890         (create_type_unit_group, read_comp_units_from_section)
2891         (dwarf2_compute_name, create_cus_hash_table)
2892         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
2893         (create_dwo_unit_in_dwp_v2, open_and_init_dwp_file): Use new
2894         obstack.
2895         (dw2_get_real_path): Likewise.  Change argument to
2896         dwarf2_per_objfile.
2897
2898 2020-05-27  Luis Machado  <luis.machado@linaro.org>
2899
2900         PR tdep/26000
2901         * arm-tdep.c (thumb_analyze_prologue): Fix instruction matching
2902         for ldrd (immediate).
2903
2904 2020-05-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2905
2906         * command.h: Add comment giving the name of class_tui.
2907         * cli/cli-cmds.c (_initialize_cli_cmds): If TUI defined,
2908         create the fake command for the help for class_tui.
2909
2910 2020-05-26  Tom Tromey  <tromey@adacore.com>
2911
2912         * ada-lang.c (ada_print_array_index): Change type.  Call val_atr.
2913         (ada_value_ptr_subscript): Don't call pos_atr on the lower bound.
2914         (val_atr): New function.
2915         (value_val_atr): Use it.
2916         * ada-valprint.c (print_optional_low_bound): Change low bound
2917         handling for enums.
2918         (val_print_packed_array_elements): Don't call discrete_position.
2919         * gdbtypes.c (get_discrete_bounds) <TYPE_CODE_RANGE>: Call
2920         discrete_position for enum types.
2921         * language.c (default_print_array_index): Change type.
2922         * language.h (struct language_defn) <la_print_array_index>: Add
2923         index_type parameter, change type of index_value.
2924         (LA_PRINT_ARRAY_INDEX): Add index_type parameter.
2925         (default_print_array_index): Update.
2926         * valprint.c (maybe_print_array_index): Don't call
2927         value_from_longest.  Update.
2928         (value_print_array_elements): Don't call discrete_position.
2929
2930 2020-05-26  Tom Tromey  <tromey@adacore.com>
2931
2932         * ada-lang.c (value_val_atr): Handle TYPE_CODE_RANGE.
2933         * gdbtypes.c (discrete_position): Handle TYPE_CODE_RANGE.
2934
2935 2020-05-25  Cristiano De Alti  <cristiano_dealti@hotmail.com>
2936
2937         PR gdb/13519
2938         * avr-tdep.c (avr_integer_to_address): Return data or code
2939         address accordingly to the second 'type' argument of the
2940         function.
2941
2942 2020-05-25  Michael Weghorn  <m.weghorn@posteo.de>
2943
2944         * infcmd.c, inferior.h: (construct_inferior_arguments):
2945         Moved function from here to gdbsupport/common-inferior.{h,cc}
2946
2947 2020-05-23  Tom Tromey  <tom@tromey.com>
2948
2949         Revert commit eca1f90c:
2950         * NEWS: Remove entry for completion styling.
2951         * completer.c (_rl_completion_prefix_display_length): Move
2952         declaration later.
2953         (gdb_fnprint): Revert.
2954         (gdb_display_match_list_1): Likewise.
2955         * cli/cli-style.c (completion_prefix_style)
2956         (completion_difference_style, completion_suffix_style): Remove.
2957         (_initialize_cli_style): Revert.
2958         * cli/cli-style.h (completion_prefix_style)
2959         (completion_difference_style, completion_suffix_style): Don't
2960         declare.
2961
2962 2020-05-24  Pedro Alves  <palves@redhat.com>
2963
2964         * symtab.c (completion_list_add_name): Return boolean indication
2965         of whether the symbol matched.
2966         (completion_list_add_symbol): Don't try to remove C++ aliases if
2967         the symbol didn't match in the first place.
2968         * symtab.h (completion_list_add_name): Return bool.
2969
2970 2020-05-23  Simon Marchi  <simon.marchi@polymtl.ca>
2971
2972         * gdbtypes.h (TYPE_FIELD): Remove.  Replace all uses with
2973         type::field.
2974
2975 2020-05-23  Joel Brobecker  <brobecker@adacore.com>
2976
2977         GDB 9.2 released.
2978
2979 2020-05-23  Tom Tromey  <tom@tromey.com>
2980
2981         * NEWS: Add entry for completion styling.
2982         * completer.c (_rl_completion_prefix_display_length): Move
2983         declaration earlier.
2984         (gdb_fnprint): Use completion_style.
2985         (gdb_display_match_list_1): Likewise.
2986         * cli/cli-style.c (completion_prefix_style)
2987         (completion_difference_style, completion_suffix_style): New
2988         globals.
2989         (_initialize_cli_style): Register new globals.
2990         * cli/cli-style.h (completion_prefix_style)
2991         (completion_difference_style, completion_suffix_style): Declare.
2992
2993 2020-05-23  Pedro Alves  <palves@redhat.com>
2994
2995         * utils.c: Include "gdbsupport/gdb-safe-ctype.h".
2996         (parse_escape): Use ISDIGIT instead of isdigit.
2997         (puts_debug): Use gdb_isprint instead of isprint.
2998         (fprintf_symbol_filtered): Use ISALNUM instead of isalnum.
2999         (cp_skip_operator_token, skip_ws, strncmp_iw_with_mode): Use
3000         ISSPACE instead of isspace.
3001         (strncmp_iw_with_mode): Use TOLOWER instead of tolower and ISSPACE
3002         instead of isspace.
3003         (strcmp_iw_ordered): Use ISSPACE instead of isspace.
3004         (string_to_core_addr): Use TOLOWER instead of tolower, ISXDIGIT
3005         instead of isxdigit and ISDIGIT instead of isdigit.
3006
3007 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
3008
3009         * gdbtypes.h (struct type) <field>: New method.
3010         (TYPE_FIELDS): Remove, replace all uses with either type::fields
3011         or type::field.
3012
3013 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
3014
3015         * gdbtypes.h (struct type) <fields, set_fields>: New methods.
3016         (TYPE_FIELDS): Use type::fields.  Change all call sites that
3017         modify the propery to use type::set_fields instead.
3018
3019 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
3020
3021         * gdbtypes.h (TYPE_NFIELDS): Remove.  Change all cal sites to use
3022         type::num_fields instead.
3023
3024 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
3025
3026         * gdbtypes.h (struct type) <num_fields, set_num_fields>: New
3027         methods.
3028         (TYPE_NFIELDS): Use type::num_fields.  Change all call sites
3029         that modify the number of fields to use type::set_num_fields
3030         instead.
3031
3032 2020-05-22  Tom Tromey  <tromey@adacore.com>
3033
3034         * compile/compile-object-load.h (munmap_list_free): Don't
3035         declare.
3036
3037 2020-05-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3038
3039         * annotate.c (annotate_source_line): Update return type, add call
3040         to update current symtab and line.
3041         * annotate.h (annotate_source_line): Update return type, and
3042         extend header comment.
3043         * source.c (info_line_command): Check annotation_level before
3044         calling annotate_source_line.
3045         * stack.c (print_frame_info): If calling annotate_source_line
3046         returns true, then don't print any other source line information.
3047
3048 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
3049
3050         * lm32-tdep.c (lm32_register_reggroup_p): Fix condition.
3051
3052 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
3053
3054         * coffread.c (patch_type): Remove NULL check before xfree.
3055         * corefile.c (set_gnutarget): Likewise.
3056         * cp-abi.c (set_cp_abi_as_auto_default): Likewise.
3057         * exec.c (build_section_table): Likewise.
3058         * remote.c (remote_target::pass_signals): Likewise.
3059         * utils.c (n_spaces): Likewise.
3060         * cli/cli-script.c (document_command): Likewise.
3061         * i386-windows-tdep.c (core_process_module_section): Likewise.
3062         * linux-fork.c (struct fork_info) <~fork_info>: Likewise.
3063
3064 2020-05-20  Simon Marchi  <simon.marchi@efficios.com>
3065
3066         * symfile.c (reread_symbols): Clear objfile's section_offsets
3067         vector and section indices, re-compute them by calling
3068         sym_offsets.
3069
3070 2020-05-20  Tom Tromey  <tromey@adacore.com>
3071
3072         * ada-lang.c (bound_name, MAX_ADA_DIMENS): Remove.
3073         (desc_one_bound, desc_index_type): Compute field name.
3074
3075 2020-05-20  Tom de Vries  <tdevries@suse.de>
3076
3077         PR symtab/25833
3078         * dwarf2/read.c (dw2_map_matching_symbols): Handle .gdb_index.
3079
3080 2020-05-20  Alan Modra  <amodra@gmail.com>
3081
3082         PR 25993
3083         * solib-darwin.c (darwin_bfd_open): Don't strdup pathname for
3084         bfd_set_filename.
3085         * solib-aix.c (solib_aix_bfd_open): Use std::string for name
3086         passed to bfd_set_filename.
3087         * symfile-mem.c (add_vsyscall_page): Likewise for string
3088         passed to symbol_file_add_from_memory.
3089         (symbol_file_add_from_memory): Make name param a const char* and
3090         don't strdup.
3091
3092 2020-05-20  Alan Modra  <amodra@gmail.com>
3093
3094         * coff-pe-read.c (read_pe_exported_syms): Use bfd_get_filename
3095         rather than accessing bfd->filename directly.
3096         * dtrace-probe.c (dtrace_static_probe_ops::get_probes): Likewise,
3097         and use bfd_section_name.
3098         * dwarf2/frame.c (decode_frame_entry): Likewise.
3099         * exec.c (exec_set_section_address): Likewise.
3100         * solib-aix.c (solib_aix_bfd_open): Likewise.
3101         * stap-probe.c (get_stap_base_address): Likewise.
3102         * symfile.c (reread_symbols): Likewise.
3103
3104 2020-05-19  Tom Tromey  <tromey@adacore.com>
3105
3106         * sparc64-tdep.c (adi_tag_fd): Update call to target_fileio_open.
3107
3108 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
3109
3110         * dwarf2/read.c (quirk_rust_enum): Allocate enough fields.
3111
3112 2020-05-19  Pedro Alves  <palves@redhat.com>
3113
3114         * NEWS (set exec-file-mismatch): Adjust entry.
3115         * exec.c: Include "build-id.h".
3116         (validate_exec_file): Try to match build IDs instead of filenames.
3117         * gdb_bfd.c (struct gdb_bfd_open_closure): New.
3118         (gdb_bfd_iovec_fileio_open): Adjust to use gdb_bfd_open_closure
3119         and pass down 'warn_if_slow'.
3120         (gdb_bfd_open): Add 'warn_if_slow' parameter.  Use
3121         gdb_bfd_open_closure to pass it down.
3122         * gdb_bfd.h (gdb_bfd_open): Add 'warn_if_slow' parameter.
3123
3124 2020-05-19  Pedro Alves  <palves@redhat.com>
3125
3126         * gdb_bfd.c (gdb_bfd_iovec_fileio_open): Adjust.
3127         * target.c (target_fileio_open_1): Rename to target_fileio_open
3128         and make extern.  Use bool.
3129         (target_fileio_open, target_fileio_open_warn_if_slow): Delete.
3130         (target_fileio_read_alloc_1): Adjust.
3131         * target.h (target_fileio_open): Add 'warn_if_slow' parameter.
3132         (target_fileio_open_warn_if_slow): Delete declaration.
3133
3134 2020-05-19  Pedro Alves  <palves@redhat.com>
3135
3136         * gdb_bfd.h: (gdb_bfd_open): Default to 'fd' parameter to -1.
3137         Adjust all callers.
3138
3139 2020-05-19  Yoshinori Sato  <ysato@users.sourceforge.jp>
3140
3141         * h8300-tdep.c (h8300_is_argument_spill): Change how we check
3142         whether disp is negative.
3143
3144 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
3145
3146         * symfile.h (struct symfile_segment_data)
3147         <~symfile_segment_data>: Remove.
3148         <segment_info>: Change to std::vector.
3149         * symfile.c (default_symfile_segments): Update.
3150         * elfread.c (elf_symfile_segments): Update.
3151
3152 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
3153
3154         * symfile.h (struct symfile_segment_data) <struct segment>: New.
3155         <segments>: New.
3156         <segment_bases, segment_sizes>: Remove.
3157         * symfile.c (default_symfile_segments): Update.
3158         * elfread.c (elf_symfile_segments): Update.
3159         * remote.c (remote_target::get_offsets): Update.
3160         * solib-target.c (solib_target_relocate_section_addresses):
3161         Update.
3162
3163 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
3164
3165         * symfile.h (struct symfile_segment_data): Initialize fields.
3166         <~symfile_segment_data>: Add.
3167         (symfile_segment_data_up): New.
3168         (struct sym_fns) <sym_segments>: Return a
3169         symfile_segment_data_up.
3170         (default_symfile_segments): Return a symfile_segment_data_up.
3171         (free_symfile_segment_data): Remove.
3172         (get_symfile_segment_data): Return a symfile_segment_data_up.
3173         * symfile.c (default_symfile_segments): Likewise.
3174         (get_symfile_segment_data): Likewise.
3175         (free_symfile_segment_data): Remove.
3176         (symfile_find_segment_sections): Update.
3177         * elfread.c (elf_symfile_segments): Return a
3178         symfile_segment_data_up.
3179         * remote.c (remote_target::get_offsets): Update.
3180         * solib-target.c (solib_target_relocate_section_addresses):
3181         Update.
3182         * symfile-debug.c (debug_sym_segments): Return a
3183         symfile_segment_data_up.
3184
3185 2020-05-18  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3186
3187         PR build/25981
3188         * i386-sol2-nat.c [PR_MODEL_NATIVE != PR_MODEL_LP64] (regmap):
3189         Hardcode register numbers.
3190
3191         PR build/25981
3192         * procfs.c [(__i386__ || __x86_64__) && sun] (proc_get_LDT_entry,
3193         procfs_find_LDT_entry): Remove.
3194         * procfs.h [(__i386__ || __x86_64__) && sun] (struct ssd,
3195         procfs_find_LDT_entry): Remove.
3196         * sol-thread.c [(__i386__ || __x86_64__) && sun] (ps_lgetLDT):
3197         Remove.
3198
3199 2020-05-17  Pedro Alves  <palves@redhat.com>
3200             Andrew Burgess  <andrew.burgess@embecosm.com>
3201             Keno Fischer  <keno@juliacomputing.com>
3202
3203         PR gdb/25741
3204         * breakpoint.c (build_target_condition_list): Update comments.
3205         (build_target_command_list): Update comments and skip matching
3206         locations.
3207         (insert_bp_location): Move "set breakpoint auto-hw on" handling to
3208         a separate function.  Simplify "set breakpoint auto-hw off"
3209         handling.
3210         (insert_breakpoints): Update comment.
3211         (tracepoint_locations_match): New parameter.  For breakpoints,
3212         compare location types too, if the caller wants to.
3213         (handle_automatic_hardware_breakpoints): New functions.
3214         (bp_location_is_less_than): Also sort by location type and
3215         hardware breakpoint length.
3216         (update_global_location_list): Handle "set breakpoint auto-hw on"
3217         here.
3218         (update_breakpoint_locations): Ask breakpoint_locations_match to
3219         ignore location types.
3220
3221 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
3222
3223         * gdbtypes.h (TYPE_NAME): Remove.  Change all cal sites to use
3224         type::name instead.
3225
3226 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
3227
3228         * gdbtypes.h (struct type) <name, set_name>: New methods.
3229         (TYPE_CODE): Use type::name.  Change all call sites used to set
3230         the name to use type::set_name instead.
3231
3232 2020-05-16  Tom Tromey  <tom@tromey.com>
3233
3234         * top.c (quit_force): Update.
3235         * infrun.c (handle_no_resumed): Update.
3236         * top.h (all_uis): New function.
3237         (ALL_UIS): Remove.
3238
3239 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
3240
3241         * mips-linux-tdep.c (mips_linux_in_dynsym_stub): Fix condition.
3242
3243 2020-05-16  Pedro Alves  <palves@redhat.com>
3244
3245         * ia64-linux-nat.c
3246         (ia64_linux_nat_target) <enable_watchpoints_in_psr(ptid_t)>:
3247         Declare method.
3248         (enable_watchpoints_in_psr): Now a method of ia64_linux_nat_target.
3249
3250 2020-05-15  Simon Marchi  <simon.marchi@efficios.com>
3251
3252         * sparc64-tdep.c (adi_stat_t): Remove typedef (leaving struct).
3253         (sparc64_adi_info): Likewise.
3254
3255 2020-05-15  Tom Tromey  <tom@tromey.com>
3256
3257         * symtab.c (lookup_language_this, lookup_symbol_aux): Use
3258         block_objfile.
3259         (lookup_objfile_from_block): Remove.
3260         (lookup_symbol_in_block, lookup_symbol_in_static_block)
3261         (lookup_global_symbol): Use block_objfile.
3262         * symtab.h (lookup_objfile_from_block): Don't declare.
3263         * printcmd.c (clear_dangling_display_expressions): Use
3264         block_objfile.
3265         * parse.c (operator_check_standard): Use block_objfile.
3266
3267 2020-05-15  Tom Tromey  <tom@tromey.com>
3268
3269         * language.c (language_alloc_type_symbol): Set
3270         SYMBOL_SECTION.
3271         * symtab.c (initialize_objfile_symbol): Remove.
3272         (allocate_symbol): Remove.
3273         (allocate_template_symbol): Remove.
3274         * dwarf2/read.c (fixup_go_packaging): Use "new".
3275         (new_symbol): Use "new".
3276         (read_variable): Don't call initialize_objfile_symbol.  Use
3277         "new".
3278         (read_func_scope): Use "new".
3279         * xcoffread.c (process_xcoff_symbol): Don't call
3280         initialize_objfile_symbol.
3281         (SYMBOL_DUP): Remove.
3282         * coffread.c (process_coff_symbol, coff_read_enum_type): Use
3283         "new".
3284         * symtab.h (allocate_symbol, initialize_objfile_symbol)
3285         (allocate_template_symbol): Don't declare.
3286         (struct symbol): Add copy constructor.  Change defaults.
3287         * jit.c (finalize_symtab): Use "new".
3288         * ctfread.c (ctf_add_enum_member_cb, new_symbol, ctf_add_var_cb):
3289         Use "new".
3290         * stabsread.c (patch_block_stabs, define_symbol, read_enum_type)
3291         (common_block_end): Use "new".
3292         * mdebugread.c (parse_symbol): Use "new".
3293         (new_symbol): Likewise.
3294
3295 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3296
3297         * NEWS: Mention changes to help and apropos.
3298
3299 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3300
3301         * command.h (enum command_class): Improve comments, document
3302         that class_alias is for user-defined aliases, give the class
3303         name for each class, remove unused class_xdb.
3304         * cli/cli-decode.c (add_com_alias): Document THECLASS intended usage.
3305         * breakpoint.c (_initialize_breakpoint): Replace class_alias
3306         by a precise class.
3307         * infcmd.c (_initialize_infcmd): Likewise.
3308         * reverse.c (_initialize_reverse): Likewise.
3309         * stack.c (_initialize_stack): Likewise.
3310         * symfile.c (_initialize_symfile): Likewise.
3311         * tracepoint.c (_initialize_tracepoint): Likewise.
3312
3313 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3314
3315         * cli/cli-decode.c (apropos_cmd): Produce output for aliases
3316         when their aliased command is traversed.
3317         (help_cmd): Add fput_command_names_styled call to
3318         output command name and aliases when command has an alias.
3319
3320 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3321
3322         * cli/cli-decode.h (help_cmd_list): Remove declaration.
3323         * cli/cli-decode.c (help_cmd_list): Declare as static,
3324         remove prefix argument, use bool for recurse arg, rework to show the aliases of
3325         a command together with the command.
3326         (fput_command_name_styled, fput_command_names_styled): New functions.
3327         (print_help_for_command): Remove prefix arg, use bool for recurse arg, use
3328         fput_command_name_styled.
3329         (help_list, help_all): Update callers to remove prefix arg and use bool recurse.
3330         * cli/cli-cmds.c (_initialize_cli_cmds): Update alias_command doc.
3331
3332 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3333
3334         * cli/cli-setshow.h (cmd_show_list): Remove prefix argument.
3335         * cli/cli-decode.c (do_show_prefix_cmd): Likewise.
3336         * command.h (cmd_show_list): Likewise.
3337         * dwarf2/index-cache.c (show_index_cache_command): Likewise.
3338         * cli/cli-setshow.c (cmd_show_list): Use the prefix to produce the output.  Skip aliases.
3339
3340 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3341
3342         * unittests/command-def-selftests.c (traverse_command_structure):
3343         Verify all commands of a list have the same prefix command and
3344         that only the top cmdlist commands have a null prefix.
3345
3346 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3347
3348         * cli/cli-decode.c (lookup_cmd_for_prefix): Return the aliased command
3349         as prefix, not one of its aliases.
3350         (set_cmd_prefix): Remove.
3351         (do_add_cmd): Centralize the setting of the prefix of a command, when
3352         command is defined after its full chain of prefix commands.
3353         (add_alias_cmd): Remove call to set_cmd_prefix, as do_add_cmd does it.
3354         (add_setshow_cmd_full): Likewise.
3355         (update_prefix_field_of_prefixed_commands): New function.
3356         (add_prefix_cmd): Replace non working call to set_cmd_prefix by
3357         update_prefix_field_of_prefixed_commands.
3358         * gdb/remote-fileio.c (initialize_remote_fileio): Use the real
3359         addresses of remote_set_cmdlist and remote_show_cmdlist given
3360         as argument, not the address of an argument.
3361         * gdb/remote-fileio.h (initialize_remote_fileio): Likewise.
3362         * gdb/remote.c (_initialize_remote): Likewise.
3363
3364 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3365
3366         * cli/cli-cmds.c (alias_command): Check for an existing alias
3367         using lookup_cmd_composition, as valid_command_p is too strict
3368         and forbids aliases that are the prefix of an existing alias
3369         or command.
3370         * cli/cli-decode.c (lookup_cmd_composition): Ensure a prefix
3371         command is properly recognised as a valid command.
3372
3373 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3374
3375         * unittests/help-doc-selftests.c: Rename to
3376         unittests/command-def-selftests.c
3377         * unittests/command-def-selftests.c (help_doc_tests): Update some
3378         comments.
3379         (command_structure_tests, traverse_command_structure): New namespace
3380         and function.
3381         (command_structure_invariants_tests): New function.
3382         (_initialize_command_def_selftests) Renamed from
3383         _initialize_help_doc_selftests, register command_structure_invariants
3384         selftest.
3385
3386 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3387
3388         * cli/cli-cmds.c (_initialize_cli_cmds): Define 'info set' as
3389         an alias of 'show'.
3390
3391 2020-05-15  Joel Brobecker  <brobecker@adacore.com>
3392
3393         * ada-lang.h: (ada_is_gnat_encoded_fixed_point_type): Renames
3394         ada_is_fixed_point_type.  Update all callers.
3395         (gnat_encoded_fixed_point_delta): Renames ada_delta.  Update
3396         all callers.
3397         * ada-lang.c (gnat_encoded_fixed_type_info): Renames fixed_type_info.
3398         Update all callers.
3399         * ada-typeprint.c (print_gnat_encoded_fixed_point_type): Renames
3400         print_fixed_point_type.  Update all callers.
3401         * ada-valprint.c (ada_value_print_num): Replace call to
3402         ada_is_fixed_point_type by ada_is_gnat_encoded_fixed_point_type.
3403
3404 2020-05-14  Kevin Buettner  <kevinb@redhat.com>
3405
3406         * nat/linux-btrace.c (btrace_this_cpu): Add check for AMD
3407         processors.
3408         (cpu_supports_bts): Add CV_AMD case.
3409
3410 2020-05-14  Laurent Morichetti  <Laurent.Morichetti@amd.com>
3411             Simon Marchi  <simon.marchi@efficios.com>
3412
3413         * infrun.c (stop_all_threads): Collect multiple wait events at
3414         each pass.
3415
3416 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
3417
3418         * gdbtypes.h (TYPE_CODE): Remove.  Change all call sites to use
3419         type::code instead.
3420
3421 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
3422
3423         * gdbtypes.h (struct type) <code, set_code>: New methods.
3424         (TYPE_CODE): Use type::code.  Change all call sites used to set
3425         the code to use type::set_code instead.
3426
3427 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3428             Tom de Vries  <tdevries@suse.de>
3429             Pedro Alves  <palves@redhat.com>
3430
3431         PR threads/25478
3432         * infrun.c (stop_all_threads): Do NOT ignore
3433         TARGET_WAITKIND_NO_RESUMED, TARGET_WAITKIND_THREAD_EXITED,
3434         TARGET_WAITKIND_EXITED, TARGET_WAITKIND_SIGNALLED wait statuses
3435         received.
3436         (handle_no_resumed): Remove code handling a live inferior with no
3437         threads.
3438         * remote.c (has_single_non_exited_thread): New.
3439         (remote_target::update_thread_list): Do not delete a thread if is
3440         the last thread of the process.
3441         * thread.c (thread_select): Call delete_exited_threads instead of
3442         prune_threads.
3443
3444 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3445
3446         * infrun.c (stop_all_threads): Enable/disable thread events of all
3447         targets.  Move a debug message denoting the end of the function
3448         into the SCOPED_EXIT block.
3449
3450 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3451
3452         * process-stratum-target.h: Include <set>.
3453         (all_non_exited_process_targets, switch_to_target_no_thread): New
3454         function declarations.
3455         * process-stratum-target.c (all_non_exited_process_targets)
3456         (switch_to_target_no_thread): New function implementations.
3457
3458 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3459
3460         * infrun.c (handle_inferior_event): Extract out a piece of code
3461         into...
3462         (mark_non_executing_threads): ...this new function.
3463
3464 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3465
3466         * infrun.c (resume_1): Move a 'regcache_read_pc' call down to first
3467         use.
3468
3469 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3470
3471         * regcache.c (regcache_read_pc_protected): New function
3472         implementation that returns 0 if the PC cannot read via
3473         'regcache_read_pc'.
3474         * infrun.c (proceed): Call 'regcache_read_pc_protected'
3475         instead of 'regcache_read_pc'.
3476         (keep_going_pass_signal): Ditto.
3477
3478 2020-05-13  Tom Tromey  <tromey@adacore.com>
3479
3480         * ada-lang.c (align_value): Remove.
3481         (ada_template_to_fixed_record_type_1): Use align_up.
3482
3483 2020-05-13  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3484
3485         * async-event.c: Update the copyright year.
3486         * async-event.h: Update the copyright year.
3487
3488 2020-05-12  Simon Marchi  <simon.marchi@efficios.com>
3489
3490         * objfiles.h (is_addr_in_objfile,
3491         shared_objfile_contains_address_p): Return bool.
3492         * objfile.c (is_addr_in_objfile,
3493         shared_objfile_contains_address_p): Return bool.
3494
3495 2020-05-11  Tom Tromey  <tromey@adacore.com>
3496
3497         * cli/cli-cmds.c (info_command): Restore.
3498         (_initialize_cli_cmds): Use add_prefix_command for "info".
3499         * gdb-gdb.gdb.in: Restore breakpoint on info_command.
3500
3501 2020-05-11  Tom Tromey  <tromey@adacore.com>
3502
3503         * ada-lang.c (ada_value_primitive_field): Now public.
3504         * ada-lang.h (ada_value_primitive_field): Declare.
3505         * ada-valprint.c (print_field_values): Use
3506         ada_value_primitive_field for wrapper fields.
3507
3508 2020-05-11  Tom de Vries  <tdevries@suse.de>
3509
3510         * dwarf2/index-write.c (debug_names::psymbol_tag): Handle
3511         MODULE_DOMAIN.
3512
3513 2020-05-11  Tom de Vries  <tdevries@suse.de>
3514
3515         PR symtab/25941
3516         * dwarf2/read.c (create_cus_from_debug_names_list): Initialize CUs
3517         with length 0, if not gdb-produced.
3518         (cutu_reader::cutu_reader): Set CU length to actual length if 0.
3519
3520 2020-05-09  Tom de Vries  <tdevries@suse.de>
3521
3522         PR gdb/25955
3523         * break-catch-throw.c (check_status_exception_catchpoint): Fix name
3524         calculation.
3525
3526 2020-05-09  Tom Tromey  <tom@tromey.com>
3527
3528         * top.c (server_command): Now bool.
3529         * top.h (server_command): Now bool.
3530
3531 2020-05-08  Tom Tromey  <tromey@adacore.com>
3532
3533         * dwarf2/read.c (read_lexical_block_scope): Don't process a DIE
3534         already being processed.
3535
3536 2020-05-08  Tom Tromey  <tom@tromey.com>
3537
3538         * printcmd.c (struct display) <next>: Remove.
3539         <display>: New constructor.
3540         <exp_string>: Now a std::string.
3541         <enabled_p>: Now a bool.
3542         (display_number): Move definition earlier.
3543         (displays): Rename from display_chain.  Now a std::vector.
3544         (ALL_DISPLAYS, ALL_DISPLAYS_SAFE): Remove.
3545         (display_command): Update.
3546         (do_one_display, disable_display)
3547         (enable_disable_display_command, do_enable_disable_display):
3548         Update.
3549         (free_display): Remove.
3550         (clear_displays): Rewrite.
3551         (delete_display): Update.
3552         (map_display_numbers): Use function_view.  Remove "data"
3553         parameter.  Update.
3554         (do_delete_display): Remove.
3555         (undisplay_command): Update.
3556         (do_one_display, do_displays, disable_display)
3557         (info_display_command): Update.
3558         (do_enable_disable_display): Remove.
3559         (enable_disable_display_command)
3560         (clear_dangling_display_expressions): Update.
3561
3562 2020-05-08  Tom Tromey  <tom@tromey.com>
3563
3564         * symtab.c (set_symbol_cache_size)
3565         (maintenance_print_symbol_cache, maintenance_flush_symbol_cache)
3566         (maintenance_print_symbol_cache_statistics): Update.
3567         * symmisc.c (print_symbol_bcache_statistics)
3568         (print_objfile_statistics, maintenance_print_objfiles)
3569         (maintenance_info_symtabs, maintenance_check_symtabs)
3570         (maintenance_expand_symtabs, maintenance_info_line_tables):
3571         Update.
3572         * symfile-debug.c (set_debug_symfile): Update.
3573         * source.c (forget_cached_source_info): Update.
3574         * python/python.c (gdbpy_progspaces): Update.
3575         * psymtab.c (maintenance_info_psymtabs): Update.
3576         * probe.c (parse_probes): Update.
3577         * linespec.c (iterate_over_all_matching_symtabs)
3578         (collect_symtabs_from_filename, search_minsyms_for_name): Update.
3579         * guile/scm-progspace.c (gdbscm_progspaces): Update.
3580         * exec.c (exec_target::close): Update.
3581         * ada-tasks.c (ada_tasks_new_objfile_observer): Update.
3582         * breakpoint.c (print_one_breakpoint_location)
3583         (create_longjmp_master_breakpoint)
3584         (create_std_terminate_master_breakpoint): Update.
3585         * progspace.c (program_spaces): Now a std::vector.
3586         (maybe_new_address_space): Update.
3587         (add_program_space): Remove.
3588         (program_space::program_space): Update.
3589         (remove_program_space): Update.
3590         (number_of_program_spaces): Remove.
3591         (print_program_space, update_address_spaces): Update.
3592         * progspace.h (program_spaces): Change type.
3593         (ALL_PSPACES): Remove.
3594         (number_of_program_spaces): Don't declare.
3595         (struct program_space) <next>: Remove.
3596
3597 2020-05-08  Tom Tromey  <tom@tromey.com>
3598
3599         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Update.
3600         * solib-svr4.c (svr4_fetch_objfile_link_map): Update.
3601         (enable_break): Update.
3602         * solib-frv.c (frv_fdpic_find_global_pointer): Update.
3603         (frv_fdpic_find_canonical_descriptor): Update.
3604         (frv_fetch_objfile_link_map): Update.
3605         * progspace.c (program_space::free_all_objfiles): Update.
3606         (program_space::solibs): New method.
3607         * progspace.h (struct program_space) <solibs>: New method.
3608         * solist.h (master_so_list): Don't declare.
3609         (ALL_SO_LIBS): Remove.
3610         * solib.h (so_list_head): Remove.
3611         (update_solib_list): Update comment.
3612         * solib.c (master_so_list): Remove.
3613         (solib_used, update_solib_list, solib_add)
3614         (info_sharedlibrary_command, clear_solib)
3615         (reload_shared_libraries_1, remove_user_added_objfile): Update.
3616
3617 2020-05-08  Tom Tromey  <tom@tromey.com>
3618
3619         * extension.c (extension_languages): Now a std::array.
3620         (ALL_EXTENSION_LANGUAGES): Remove.
3621         (get_ext_lang_defn, get_ext_lang_of_file)
3622         (eval_ext_lang_from_control_command): Update.
3623         (finish_ext_lang_initialization)
3624         (auto_load_ext_lang_scripts_for_objfile)
3625         (ext_lang_type_printers::ext_lang_type_printers)
3626         (apply_ext_lang_type_printers)
3627         (ext_lang_type_printers::~ext_lang_type_printers)
3628         (apply_ext_lang_val_pretty_printer, apply_ext_lang_frame_filter)
3629         (preserve_ext_lang_values, get_breakpoint_cond_ext_lang)
3630         (breakpoint_ext_lang_cond_says_stop, check_quit_flag)
3631         (get_matching_xmethod_workers, ext_lang_colorize)
3632         (ext_lang_before_prompt): Update.
3633         (ALL_ENABLED_EXTENSION_LANGUAGES): Remove.
3634
3635 2020-05-08  Tom Tromey  <tom@tromey.com>
3636
3637         * symtab.h (class demangle_result_storage) <set_malloc_ptr>: New
3638         overload.
3639         <swap_string, m_string>: Remove.
3640         * symtab.c (demangle_for_lookup, completion_list_add_symbol):
3641         Update.
3642         * stabsread.c (define_symbol, read_type): Update.
3643         * linespec.c (find_linespec_symbols): Update.
3644         * gnu-v3-abi.c (gnuv3_get_typeid): Update.
3645         * dwarf2/read.c (dwarf2_canonicalize_name): Update.
3646         * dbxread.c (read_dbx_symtab): Update.
3647         * cp-support.h (cp_canonicalize_string_full)
3648         (cp_canonicalize_string, cp_canonicalize_string_no_typedefs):
3649         Return unique_xmalloc_ptr.
3650         * cp-support.c (inspect_type): Update.
3651         (cp_canonicalize_string_full): Return unique_xmalloc_ptr.
3652         (cp_canonicalize_string_no_typedefs, cp_canonicalize_string):
3653         Likewise.
3654         * c-typeprint.c (print_name_maybe_canonical): Update.
3655         * break-catch-throw.c (check_status_exception_catchpoint):
3656         Update.
3657
3658 2020-05-08  Tom de Vries  <tdevries@suse.de>
3659
3660         * infrun.c (follow_fork): Copy current_line and current_symtab to
3661         child thread.
3662
3663 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3664
3665         * async-event.c (struct async_signal_handler, struct
3666         async_event_handler): Reformat, remove typedef.
3667
3668 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3669
3670         * gdbtypes.h (TYPE_DYN_PROP_LIST): Remove.  Update all users
3671         access thistype->main_type->dyn_prop_list directly.
3672
3673 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3674
3675         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
3676         (remove_dyn_prop): Remove.  Update all users to use
3677         type::remove_dyn_prop.
3678         * gdbtypes.c (remove_dyn_prop): Rename to...
3679         (type::remove_dyn_prop): ... this.
3680
3681 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
3682
3683         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
3684         (add_dyn_prop): Remove.  Update all users to use
3685         type::add_dyn_prop.
3686         * gdbtypes.c (add_dyn_prop): Rename to...
3687         (type::add_dyn_prop): ... this.
3688
3689 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3690
3691         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
3692         (get_dyn_prop): Remove.  Update all users to use
3693         type::dyn_prop.
3694         * gdbtypes.c (get_dyn_prop): Rename to...
3695         (type::dyn_prop): ... this.
3696
3697 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
3698
3699         * gdbtypes.h (struct main_type) <flag_static>: Remove.
3700
3701 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
3702
3703         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
3704         instruction, skip it if it's there.
3705
3706 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
3707
3708         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
3709
3710 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
3711
3712         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
3713         * gdbtypes.c (recursive_dump_type): Remove use of
3714         TYPE_INCOMPLETE.
3715
3716 2020-05-03  Tom Tromey  <tom@tromey.com>
3717
3718         * breakpoint.c (catch_command, tcatch_command): Remove.
3719         (_initialize_breakpoint): Use add_basic_prefix_cmd,
3720         add_show_prefix_cmd.
3721         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
3722         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
3723         Remove.
3724         (add_internal_problem_command): Use add_basic_prefix_cmd,
3725         add_show_prefix_cmd.
3726         * mips-tdep.c (set_mipsfpu_command): Remove.
3727         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
3728         * dwarf2/index-cache.c (set_index_cache_command): Remove.
3729         (_initialize_index_cache): Use add_basic_prefix_cmd.
3730         * memattr.c (dummy_cmd): Remove.
3731         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
3732         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
3733         (_initialize_tui_win): Use add_basic_prefix_cmd,
3734         add_show_prefix_cmd.
3735         * cli/cli-logging.c (set_logging_command): Remove.
3736         (_initialize_cli_logging): Use add_basic_prefix_cmd,
3737         add_show_prefix_cmd.
3738         (show_logging_command): Remove.
3739         * target.c (target_command): Remove.
3740         (add_target): Use add_basic_prefix_cmd.
3741
3742 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
3743
3744         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
3745
3746 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3747
3748         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
3749         info_command.
3750
3751 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
3752
3753         * nbsd-nat.c (nbsd_enable_proc_events)
3754         (nbsd_nat_target::post_startup_inferior): Add.
3755         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
3756         (nbsd_nat_target::update_thread_list): Rewrite.
3757         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
3758         "PTRACE_LWP_CREATE".
3759         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
3760
3761 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3762
3763         * stack.c (_initialize_stack): Remove duplicated creation
3764         of "frame" command and "f" alias.
3765
3766 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
3767
3768         PR gdb/18706
3769         * gdbtypes.c (check_typedef): Calculate size of array of
3770         stubbed type.
3771
3772 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
3773
3774         PR gdb/15559
3775         * i386-tdep.c (i386_push_dummy_call): Call
3776         i386_thiscall_push_dummy_call.
3777         (i386_thiscall_push_dummy_call): New function.
3778         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
3779         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
3780         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
3781
3782 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3783
3784         * gdbarch.sh (do_read): Add shellcheck disable directive for
3785         warning SC2162.
3786
3787 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3788
3789         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
3790         "referenced but not assigned" warning.
3791
3792 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3793
3794         * gdbarch.sh: Remove code that sets fallbackdefault.
3795
3796 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3797
3798         * gdbarch.sh: Use shell operators && and || instead of
3799         -a and -o.
3800
3801 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3802
3803         * gdbarch.sh: Use $(...) instead of `...`.
3804
3805 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3806
3807         * gdbarch.sh: Use double quotes around variables.
3808
3809 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3810
3811         * gdbarch.sh: Use %s with printf, instead of variables in the
3812         format string.
3813
3814 2020-04-29  Tom Tromey  <tromey@adacore.com>
3815
3816         PR ada/25875:
3817         * dwarf2/read.c (update_enumeration_type_from_children): Compute
3818         type fields here.
3819         (read_enumeration_type): Call
3820         update_enumeration_type_from_children later.  Update comments.
3821         (process_enumeration_scope): Don't create type fields.
3822
3823 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
3824
3825         * nbsd-tdep.c: Include "xml-syscall.h".
3826         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
3827
3828 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
3829
3830         * nbsd-nat.c: Include "sys/wait.h".
3831         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
3832         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
3833         (nbsd_nat_target::remove_exec_catchpoint)
3834         (nbsd_nat_target::set_syscall_catchpoint): Add.
3835         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
3836         (nbsd_nat_target::insert_exec_catchpoint)
3837         (nbsd_nat_target::remove_exec_catchpoint)
3838         (nbsd_nat_target::set_syscall_catchpoint): Add.
3839         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
3840         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
3841         `nbsd_get_syscall_number'.
3842
3843 2020-04-29  Tom Tromey  <tom@tromey.com>
3844
3845         * stack.c (print_block_frame_labels): Remove.
3846
3847 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
3848
3849         PR gdb/17320
3850         * ada-valprint.c (val_print_packed_array_elements): Move array
3851         end bracket to new line.
3852         (ada_val_print_string): Remove extra spaces before first array
3853         element.
3854         * c-valprint.c (c_value_print_array): Likewise.
3855         * m2-valprint.c (m2_print_array_contents): Likewise.
3856         (m2_value_print_inner): Likewise.
3857         * p-valprint.c (pascal_value_print_inner): Likewise.
3858         * valprint.c (generic_val_print_array): Likewise.
3859         (value_print_array_elements): Move first array element and array
3860         end bracket to new line.
3861
3862 2020-04-29  Tom de Vries  <tdevries@suse.de>
3863
3864         PR symtab/25889
3865         * linespec.c (find_method): Fix ix calculation.
3866
3867 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
3868
3869         * syscalls/update-netbsd.sh: New file.
3870         * syscalls/netbsd.xml: Regenerate.
3871         * data-directory/Makefile.in: Register `netbsd.xml' in
3872         `SYSCALLS_FILES'.
3873
3874 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
3875
3876         * syscalls/update-freebsd.sh: Add double quotes.
3877
3878 2020-04-28  Tom Tromey  <tom@tromey.com>
3879
3880         * NEWS: Update.
3881         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
3882         (cmdpy_init): Allow class_tui.
3883
3884 2020-04-28 Mark Williams <mark@myosotissp.com>
3885
3886         PR gdb/24480
3887         * dwarf2read.c: Add missing assingments to list_in_scope when
3888         start_symtab was already called.
3889
3890 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
3891
3892         PR gdb/25881
3893         * dwarf2/read.c (offset_map_type): Use
3894         gdb:hash_enum<sect_offset> as hash function.
3895
3896 2020-04-28  Tom de Vries  <tdevries@suse.de>
3897
3898         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
3899         with DW_AT_signature.
3900
3901 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
3902
3903         * configure.ac: Remove check for fs_base/gs_base in
3904         user_regs_struct.
3905         * configure: Re-generate.
3906         * config.in: Re-generate.
3907         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
3908         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
3909         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
3910
3911 2020-04-27  Luis Machado  <luis.machado@linaro.org>
3912
3913         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
3914         problematic inline frame unwinding situation.
3915         * frame.c (frame_id_computed_p): New function.
3916         * frame.h (frame_id_computed_p): New prototype.
3917
3918 2020-04-26  Tom Tromey  <tom@tromey.com>
3919
3920         * command.h (enum command_class) <class_pseudo>: Remove.
3921
3922 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3923
3924         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
3925         and whitespace.
3926
3927 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
3928
3929         * inf-ptrace.c (inf_ptrace_target::wait): Remove
3930         `PT_GET_PROCESS_STATE' block.
3931
3932 2020-04-24  Tom Tromey  <tom@tromey.com>
3933
3934         * symtab.h (symbol_get_demangled_name): Don't declare.
3935         * symtab.c (symbol_get_demangled_name): Remove.
3936         (general_symbol_info::natural_name)
3937         (general_symbol_info::demangled_name): Update.
3938
3939 2020-04-24  Tom Tromey  <tom@tromey.com>
3940
3941         PR rust/25025:
3942         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
3943
3944 2020-04-24  Tom Tromey  <tom@tromey.com>
3945
3946         PR symtab/12707:
3947         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
3948         exists.
3949         (new_symbol): Likewise.
3950         * compile/compile-object-load.c (get_out_value_type): Use
3951         symbol_matches_search_name.
3952
3953 2020-04-24  Tom Tromey  <tom@tromey.com>
3954
3955         * dwarf2/read.c (add_partial_symbol): Do not call
3956         compute_and_set_names.
3957
3958 2020-04-24  Tom Tromey  <tom@tromey.com>
3959
3960         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
3961         overload.
3962
3963 2020-04-24  Tom Tromey  <tom@tromey.com>
3964
3965         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
3966         (add_psymbol_to_list): New overload.  Make old overload call new
3967         one.
3968         * psympriv.h (add_psymbol_to_list): New overload.
3969
3970 2020-04-24  Tom Tromey  <tom@tromey.com>
3971
3972         * dwarf2/read.c (partial_die_info::read) <case
3973         DW_AT_linkage_name>: Use value_as_string.
3974         (dwarf2_string_attr): Use value_as_string.
3975         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
3976         method.
3977         * dwarf2/attribute.c (attribute::value_as_string): New method.
3978
3979 2020-04-24  Tom Tromey  <tom@tromey.com>
3980
3981         * symtab.c (general_symbol_info::natural_name)
3982         (general_symbol_info::demangled_name): Check for language_rust.
3983
3984 2020-04-24  Tom Tromey  <tom@tromey.com>
3985
3986         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
3987         (dwarf2_physname): ... from here.
3988         (partial_die_info::read): Add Rust "{" hack.
3989
3990 2020-04-24  Tom Tromey  <tom@tromey.com>
3991
3992         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
3993         method.
3994         (symbol_set_demangled_name): Don't declare.
3995         * symtab.c (general_symbol_info::set_demangled_name): Rename from
3996         symbol_set_demangled_name.
3997         (general_symbol_info::set_language)
3998         (general_symbol_info::compute_and_set_names): Update.
3999         * minsyms.c (minimal_symbol_reader::install): Update.
4000         * dwarf2/read.c (new_symbol): Update.
4001
4002 2020-04-24  Tom Tromey  <tromey@adacore.com>
4003
4004         PR python/23662:
4005         * python/py-type.c (convert_field): Handle
4006         FIELD_LOC_KIND_DWARF_BLOCK.
4007         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
4008         (typy_get_dynamic): Nw function.
4009         (type_object_getset): Add "dynamic".
4010         * NEWS: Add entry.
4011
4012 2020-04-24  Tom Tromey  <tromey@adacore.com>
4013
4014         * ada-typeprint.c (print_choices, print_variant_part)
4015         (print_record_field_types_dynamic): New functions.
4016         (print_record_field_types): Use print_record_field_types_dynamic.
4017
4018 2020-04-24  Tom Tromey  <tromey@adacore.com>
4019
4020         * dwarf2/read.c (handle_data_member_location): New overload.
4021         (dwarf2_add_field): Use it.
4022         (decode_locdesc): Add "computed" parameter.  Update comment.
4023         * gdbtypes.c (is_dynamic_type_internal): Also look for
4024         FIELD_LOC_KIND_DWARF_BLOCK.
4025         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
4026         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
4027         virtual base classes.
4028         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
4029         FIELD_LOC_KIND_DWARF_BLOCK.
4030
4031 2020-04-24  Tom Tromey  <tromey@adacore.com>
4032
4033         * dwarf2/read.c (read_structure_type): Handle dynamic length.
4034         * gdbtypes.c (is_dynamic_type_internal): Check
4035         TYPE_HAS_DYNAMIC_LENGTH.
4036         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
4037         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
4038         New macros.
4039         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
4040         constant.
4041
4042 2020-04-24  Tom Tromey  <tromey@adacore.com>
4043
4044         * dwarf2/read.c (struct variant_field): Rewrite.
4045         (struct variant_part_builder): New.
4046         (struct nextfield): Remove "variant" field.  Add "offset".
4047         (struct field_info): Add "current_variant_part" and
4048         "variant_parts".
4049         (alloc_discriminant_info): Remove.
4050         (alloc_rust_variant): New function.
4051         (quirk_rust_enum): Update.
4052         (dwarf2_add_field): Set "offset" member.  Don't handle
4053         DW_TAG_variant_part.
4054         (offset_map_type): New typedef.
4055         (convert_variant_range, create_one_variant)
4056         (create_one_variant_part, create_variant_parts)
4057         (add_variant_property): New functions.
4058         (dwarf2_attach_fields_to_type): Call add_variant_property.
4059         (read_structure_type): Don't handle DW_TAG_variant_part.
4060         (handle_variant_part, handle_variant): New functions.
4061         (handle_struct_member_die): Use them.
4062         (process_structure_scope): Don't handle variant parts.
4063         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
4064         (struct discriminant_info): Remove.
4065         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
4066         (struct main_type) <flag_discriminated_union>: Remove.
4067         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
4068         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
4069         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
4070         Update.
4071         * valops.c (value_union_variant): Remove.
4072         * value.h (value_union_variant): Don't declare.
4073
4074 2020-04-24  Tom Tromey  <tromey@adacore.com>
4075
4076         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
4077         (ada_value_primitive_packed_val): Update.
4078         * ada-valprint.c (ada_value_print_1): Update.
4079         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
4080         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
4081         just an address.  Use evaluate_for_locexpr_baton.
4082         (dwarf2_evaluate_property): Update.
4083         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
4084         array_view.
4085         * findvar.c (default_read_var_value): Update.
4086         * gdbtypes.c (compute_variant_fields_inner)
4087         (resolve_dynamic_type_internal): Update.
4088         (resolve_dynamic_type): Change type of valaddr parameter.
4089         * gdbtypes.h (resolve_dynamic_type): Update.
4090         * valarith.c (value_subscripted_rvalue): Update.
4091         * value.c (value_from_contents_and_address): Update.
4092
4093 2020-04-24  Tom Tromey  <tromey@adacore.com>
4094
4095         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
4096         "push_initial_value" parameter.
4097         (dwarf2_evaluate_property): Likewise.
4098         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
4099
4100 2020-04-24  Tom Tromey  <tromey@adacore.com>
4101
4102         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
4103         (variant::matches, compute_variant_fields_recurse)
4104         (compute_variant_fields_inner, compute_variant_fields): New
4105         functions.
4106         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
4107         Use resolved_type after type is made.
4108         (operator==): Add new cases.
4109         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
4110         (struct discriminant_range, struct variant, struct variant_part):
4111         New.
4112         (union dynamic_prop_data) <variant_parts, original_type>: New
4113         members.
4114         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
4115         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
4116         constants.
4117         * value.c (unpack_bits_as_long): Now public.
4118         * value.h (unpack_bits_as_long): Declare.
4119
4120 2020-04-24  Tom Tromey  <tromey@adacore.com>
4121
4122         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
4123         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
4124
4125 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
4126
4127         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
4128
4129 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
4130
4131         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
4132         (remove_fork_catchpoint, post_startup_inferior)
4133         (post_attach): Move...
4134         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
4135         (remove_fork_catchpoint, post_startup_inferior)
4136         (post_attach): ...here.
4137         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
4138         (remove_fork_catchpoint, post_startup_inferior)
4139         (post_attach): Move...
4140         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
4141         (remove_fork_catchpoint, post_startup_inferior)
4142         (post_attach): ...here.
4143
4144 2020-04-24  Tom Tromey  <tromey@adacore.com>
4145
4146         * nat/windows-nat.h (struct windows_thread_info)
4147         <pc_adjusted>: New member.
4148         * windows-nat.c (windows_fetch_one_register): Check
4149         pc_adjusted.
4150         (windows_nat_target::get_windows_debug_event)
4151         (windows_nat_target::wait): Set pc_adjusted.
4152
4153 2020-04-24  Tom de Vries  <tdevries@suse.de>
4154
4155         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
4156         Run gdb-add-index inside temp dir.
4157
4158 2020-04-23  Tom Tromey  <tromey@adacore.com>
4159
4160         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
4161         in loop.
4162
4163 2020-04-23  Luis Machado  <luis.machado@linaro.org>
4164
4165         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
4166         get_frame_register instead of gdbarch_unwind_pc.
4167
4168 2020-04-23  Tom de Vries  <tdevries@suse.de>
4169
4170         * symtab.c (lookup_global_symbol): Prefer def over decl.
4171
4172 2020-04-23  Tom de Vries  <tdevries@suse.de>
4173
4174         PR symtab/25807
4175         * block.c (best_symbol, better_symbol): Promote to external.
4176         * block.h (best_symbol, better_symbol): Declare.
4177         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
4178         decl.
4179
4180 2020-04-23  Tom Tromey  <tromey@adacore.com>
4181
4182         PR ada/25837:
4183         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
4184         "const char *", not a "const std::string &".
4185         <name_and_matcher::operator==>: Update.
4186         * unittests/lookup_name_info-selftests.c: Change type of
4187         "result".
4188
4189 2020-04-23  Tom Tromey  <tom@tromey.com>
4190
4191         * inferior.h (iterate_over_inferiors): Don't declare.
4192         * inferior.c (iterate_over_inferiors): Remove.
4193         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
4194         Remove.
4195         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
4196         use iterate_over_inferiors.
4197         (darwin_resume_inferior_it)
4198         (struct resume_inferior_threads_param)
4199         (darwin_resume_inferior_threads_it): Remove.
4200         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
4201
4202 2020-04-23  Tom de Vries  <tdevries@suse.de>
4203
4204         * blockframe.c (find_pc_partial_function): Use
4205         find_pc_sect_compunit_symtab rather than
4206         objfile->sf->qf->find_pc_sect_compunit_symtab.
4207
4208 2020-04-22  Tom de Vries  <tdevries@suse.de>
4209
4210         PR symtab/25764
4211         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
4212         in psymtabs.
4213
4214 2020-04-22  Tom de Vries  <tdevries@suse.de>
4215
4216         PR symtab/25801
4217         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
4218         symtabs.
4219
4220 2020-04-22  Tom de Vries  <tdevries@suse.de>
4221
4222         PR symtab/25700
4223         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
4224         CU if already created.
4225
4226 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4227
4228         * infrun.c (displaced_step_fixup): Switch to the event_thread
4229         before calling displaced_step_restore, not after.
4230
4231 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
4232
4233         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
4234         its inferior is not recorded by us.
4235         (record_btrace_target_open): Replace call to
4236         all_non_exited_threads () with call to current_inferior
4237         ()->non_exited_threads ().
4238         (record_btrace_target::stop_recording): Likewise.
4239         (record_btrace_target::close): Likewise.
4240         (record_btrace_target::wait): Likewise.
4241         (record_btrace_target::record_stop_replaying): Likewise.
4242
4243 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
4244
4245         * btrace.c (btrace_enable): Throw an error on double enables and
4246         when enabling recording fails.
4247         (btrace_disable): Throw an error if the thread is not recorded.
4248
4249 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
4250
4251         * record-btrace.c (record_btrace_target::fetch_registers): Forward
4252         request if we do not have a thread_info.
4253
4254 2020-04-21  Tom de Vries  <tdevries@suse.de>
4255
4256         PR gdb/25471
4257         * thread.c
4258         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
4259         exception in get_frame_id.
4260
4261 2020-04-20  Tom Tromey  <tromey@adacore.com>
4262
4263         * python/python.c (struct gdbpy_event): Mark move constructor as
4264         noexcept.
4265         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
4266         constructor as noexcept.
4267         * completer.h (struct completion_result): Mark move constructor as
4268         noexcept.
4269         * completer.c (completion_result::completion_result): Use
4270         initialization style.  Don't call reset_match_list.
4271
4272 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
4273
4274         * MAINTAINERS (Write After Approval): Add myself.
4275
4276 2020-04-18  Tom Tromey  <tom@tromey.com>
4277
4278         * windows-tdep.c (init_w32_command_list)
4279         (w32_prefix_command_valid): Restore.
4280         (_initialize_windows_tdep): Call init_w32_command_list.
4281
4282 2020-04-18  Tom Tromey  <tom@tromey.com>
4283
4284         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
4285         * value.c (value_fn_field): Update.
4286         * valops.c (find_function_in_inferior)
4287         (value_allocate_space_in_inferior): Update.
4288         * tui/tui-winsource.c (tui_update_source_windows_with_line):
4289         Update.
4290         * tui/tui-source.c (tui_source_window::set_contents): Update.
4291         * symtab.c (lookup_global_or_static_symbol)
4292         (find_function_start_sal_1, skip_prologue_sal)
4293         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
4294         * symmisc.c (dump_msymbols, dump_symtab_1)
4295         (maintenance_print_one_line_table): Update.
4296         * symfile.c (init_entry_point_info, section_is_mapped)
4297         (list_overlays_command, simple_read_overlay_table)
4298         (simple_overlay_update_1): Update.
4299         * stap-probe.c (handle_stap_probe): Update.
4300         * stabsread.c (dbx_init_float_type, define_symbol)
4301         (read_one_struct_field, read_enum_type, read_range_type): Update.
4302         * source.c (info_line_command): Update.
4303         * python/python.c (gdbpy_source_objfile_script)
4304         (gdbpy_execute_objfile_script): Update.
4305         * python/py-type.c (save_objfile_types): Update.
4306         * python/py-objfile.c (py_free_objfile): Update.
4307         * python/py-inferior.c (python_new_objfile): Update.
4308         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
4309         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
4310         (maintenance_check_psymtabs): Update.
4311         * printcmd.c (info_address_command): Update.
4312         * objfiles.h (struct objfile) <arch>: New method, from
4313         get_objfile_arch.
4314         (get_objfile_arch): Don't declare.
4315         * objfiles.c (get_objfile_arch): Remove.
4316         (filter_overlapping_sections): Update.
4317         * minsyms.c (msymbol_is_function): Update.
4318         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
4319         (output_nondebug_symbol): Update.
4320         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
4321         (mdebug_expand_psymtab): Update.
4322         * machoread.c (macho_add_oso_symfile): Update.
4323         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
4324         Update.
4325         * linux-fork.c (checkpoint_command): Update.
4326         * linespec.c (convert_linespec_to_sals): Update.
4327         * jit.c (finalize_symtab): Update.
4328         * infrun.c (insert_exception_resume_from_probe): Update.
4329         * ia64-tdep.c (ia64_find_unwind_table): Update.
4330         * hppa-tdep.c (internalize_unwinds): Update.
4331         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
4332         Update.
4333         * gcore.c (call_target_sbrk): Update.
4334         * elfread.c (record_minimal_symbol, elf_symtab_read)
4335         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
4336         (elf_gnu_ifunc_resolve_by_got): Update.
4337         * dwarf2/read.c (create_addrmap_from_index)
4338         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4339         (read_debug_names_from_section)
4340         (process_psymtab_comp_unit_reader, add_partial_symbol)
4341         (add_partial_subprogram, process_full_comp_unit)
4342         (read_file_scope, read_func_scope, read_lexical_block_scope)
4343         (read_call_site_scope, dwarf2_ranges_read)
4344         (dwarf2_record_block_ranges, dwarf2_add_field)
4345         (mark_common_block_symbol_computed, read_tag_pointer_type)
4346         (read_tag_string_type, dwarf2_init_float_type)
4347         (dwarf2_init_complex_target_type, read_base_type)
4348         (partial_die_info::read, partial_die_info::read)
4349         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
4350         (dwarf2_fetch_die_loc_sect_off): Update.
4351         * dwarf2/loc.c (dwarf2_find_location_expression)
4352         (class dwarf_evaluate_loc_desc, rw_pieced_value)
4353         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
4354         (dwarf2_loc_desc_get_symbol_read_needs)
4355         (locexpr_describe_location_piece, locexpr_describe_location_1)
4356         (loclist_describe_location): Update.
4357         * dwarf2/index-write.c (write_debug_names): Update.
4358         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
4359         * dtrace-probe.c (dtrace_process_dof): Update.
4360         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
4361         (process_one_symbol): Update.
4362         * ctfread.c (ctf_init_float_type, read_base_type): Update.
4363         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
4364         (coff_read_enum_type): Update.
4365         * cli/cli-cmds.c (edit_command, list_command): Update.
4366         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
4367         * breakpoint.c (create_overlay_event_breakpoint)
4368         (create_longjmp_master_breakpoint)
4369         (create_std_terminate_master_breakpoint)
4370         (create_exception_master_breakpoint, get_sal_arch): Update.
4371         * block.c (block_gdbarch): Update.
4372         * annotate.c (annotate_source_line): Update.
4373
4374 2020-04-17  Tom Tromey  <tromey@adacore.com>
4375
4376         * auto-load.c (show_auto_load_cmd): Remove.
4377         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
4378         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
4379         (maintenance_print_arc_command): Remove.
4380         * tui/tui-win.c (tui_command): Remove.
4381         (tui_get_cmd_list): Use add_basic_prefix_cmd.
4382         * tui/tui-layout.c (tui_layout_command): Remove.
4383         (_initialize_tui_layout): Use add_basic_prefix_cmd.
4384         * python/python.c (user_set_python, user_show_python): Remove.
4385         (_initialize_python): Use add_basic_prefix_cmd,
4386         add_show_prefix_cmd.
4387         * guile/guile.c (set_guile_command, show_guile_command): Remove.
4388         (install_gdb_commands): Use add_basic_prefix_cmd,
4389         add_show_prefix_cmd.
4390         (info_guile_command): Remove.
4391         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
4392         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
4393         add_show_prefix_cmd.
4394         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
4395         Remove do_set and do_show parameters.
4396         * cli/cli-style.c (set_style, show_style): Remove.
4397         (_initialize_cli_style): Use add_basic_prefix_cmd,
4398         add_show_prefix_cmd.
4399         (cli_style_option::add_setshow_commands): Remove do_set and
4400         do_show parameters.
4401         (cli_style_option::add_setshow_commands): Use
4402         add_basic_prefix_cmd, add_show_prefix_cmd.
4403         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
4404         (set_style_name): Remove.
4405         * cli/cli-dump.c (dump_command, append_command): Remove.
4406         (srec_dump_command, ihex_dump_command, verilog_dump_command)
4407         (tekhex_dump_command, binary_dump_command)
4408         (binary_append_command): Remove.
4409         (_initialize_cli_dump): Use add_basic_prefix_cmd.
4410         * windows-tdep.c (w32_prefix_command_valid): Remove global.
4411         (init_w32_command_list): Remove; move into ...
4412         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
4413         * valprint.c (set_print, show_print, set_print_raw)
4414         (show_print_raw): Remove.
4415         (_initialize_valprint): Use add_basic_prefix_cmd,
4416         add_show_prefix_cmd.
4417         * typeprint.c (set_print_type, show_print_type): Remove.
4418         (_initialize_typeprint): Use add_basic_prefix_cmd,
4419         add_show_prefix_cmd.
4420         * record.c (set_record_command, show_record_command): Remove.
4421         (_initialize_record): Use add_basic_prefix_cmd,
4422         add_show_prefix_cmd.
4423         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
4424         add_show_prefix_cmd.
4425         (info_command, show_command, set_debug, show_debug): Remove.
4426         * top.h (set_history, show_history): Don't declare.
4427         * top.c (set_history, show_history): Remove.
4428         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
4429         (unset_tdesc_cmd): Remove.
4430         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
4431         add_show_prefix_cmd.
4432         * symtab.c (info_module_command): Remove.
4433         (_initialize_symtab): Use add_basic_prefix_cmd.
4434         * symfile.c (overlay_command): Remove.
4435         (_initialize_symfile): Use add_basic_prefix_cmd.
4436         * sparc64-tdep.c (info_adi_command): Remove.
4437         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
4438         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
4439         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
4440         add_show_prefix_cmd.
4441         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
4442         (_initialize_serial): Use add_basic_prefix_cmd,
4443         add_show_prefix_cmd.
4444         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
4445         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
4446         add_show_prefix_cmd.
4447         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
4448         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
4449         add_show_prefix_cmd.
4450         * riscv-tdep.c (show_riscv_command, set_riscv_command)
4451         (show_debug_riscv_command, set_debug_riscv_command): Remove.
4452         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
4453         add_show_prefix_cmd.
4454         * remote.c (remote_command, set_remote_cmd): Remove.
4455         (_initialize_remote): Use add_basic_prefix_cmd.
4456         * record-full.c (set_record_full_command)
4457         (show_record_full_command): Remove.
4458         (_initialize_record_full): Use add_basic_prefix_cmd,
4459         add_show_prefix_cmd.
4460         * record-btrace.c (cmd_set_record_btrace)
4461         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
4462         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
4463         (cmd_show_record_btrace_pt): Remove.
4464         (_initialize_record_btrace): Use add_basic_prefix_cmd,
4465         add_show_prefix_cmd.
4466         * ravenscar-thread.c (set_ravenscar_command)
4467         (show_ravenscar_command): Remove.
4468         (_initialize_ravenscar): Use add_basic_prefix_cmd,
4469         add_show_prefix_cmd.
4470         * mips-tdep.c (show_mips_command, set_mips_command)
4471         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
4472         add_show_prefix_cmd.
4473         * maint.c (maintenance_command, maintenance_info_command)
4474         (maintenance_check_command, maintenance_print_command)
4475         (maintenance_set_cmd, maintenance_show_cmd): Remove.
4476         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
4477         add_show_prefix_cmd.
4478         (show_per_command_cmd): Remove.
4479         * maint-test-settings.c (maintenance_set_test_settings_cmd):
4480         Remove.
4481         (maintenance_show_test_settings_cmd): Remove.
4482         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
4483         add_show_prefix_cmd.
4484         * maint-test-options.c (maintenance_test_options_command):
4485         Remove.
4486         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
4487         * macrocmd.c (macro_command): Remove
4488         (_initialize_macrocmd): Use add_basic_prefix_cmd.
4489         * language.c (set_check, show_check): Remove.
4490         (_initialize_language): Use add_basic_prefix_cmd,
4491         add_show_prefix_cmd.
4492         * infcmd.c (unset_command): Remove.
4493         (_initialize_infcmd): Use add_basic_prefix_cmd.
4494         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
4495         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
4496         add_show_prefix_cmd.
4497         * go32-nat.c (go32_info_dos_command): Remove.
4498         (_initialize_go32_nat): Use add_basic_prefix_cmd.
4499         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
4500         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
4501         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
4502         (_initialize_frame): Use add_basic_prefix_cmd,
4503         add_show_prefix_cmd.
4504         * dcache.c (set_dcache_command, show_dcache_command): Remove.
4505         (_initialize_dcache): Use add_basic_prefix_cmd,
4506         add_show_prefix_cmd.
4507         * cp-support.c (maint_cplus_command): Remove.
4508         (_initialize_cp_support): Use add_basic_prefix_cmd.
4509         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
4510         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
4511         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
4512         add_basic_prefix_cmd, add_show_prefix_cmd.
4513         * breakpoint.c (save_command): Remove.
4514         (_initialize_breakpoint): Use add_basic_prefix_cmd.
4515         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
4516         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
4517         add_show_prefix_cmd.
4518         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
4519         (set_ada_command, show_ada_command): Remove.
4520         (_initialize_ada_language): Use add_basic_prefix_cmd,
4521         add_show_prefix_cmd.
4522         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
4523
4524 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
4525
4526         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
4527         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
4528
4529 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
4530
4531         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
4532         warning messages.
4533
4534 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
4535
4536         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
4537         import table is not at beginning of .idata section.
4538
4539 2020-04-16  Pedro Alves  <palves@redhat.com>
4540
4541         * inferior.c (delete_inferior): Use delete operator directly
4542         instead of delete_program_space.
4543         * progspace.c (add_program_space): New, factored out from
4544         program_space::program_space.
4545         (remove_program_space): New, factored out from
4546         delete_program_space.
4547         (program_space::program_space): Remove intro comment.  Rewrite.
4548         (program_space::~program_space): Remove intro comment.  Call
4549         remove_program_space.
4550         (delete_program_space): Delete.
4551         * progspace.h (program_space::program_space): Make explicit.  Move
4552         intro comment here, adjusted.
4553         (program_space::~program_space): Move intro comment here,
4554         adjusted.
4555         (delete_program_space): Remove.
4556
4557 2020-04-16  Tom Tromey  <tromey@adacore.com>
4558
4559         * windows-nat.c (windows_nat::handle_access_violation): New
4560         function.
4561         * nat/windows-nat.h (handle_access_violation): Declare.
4562         * nat/windows-nat.c (handle_exception): Move Cygwin code to
4563         windows-nat.c.  Call handle_access_violation.
4564
4565 2020-04-16  Tom de Vries  <tdevries@suse.de>
4566
4567         PR symtab/25791
4568         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
4569         CUs without psymtab.
4570
4571 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
4572
4573         * python/python.c (do_start_initialization): Don't call
4574         PyEval_InitThreads for Python 3.9 and beyond.
4575
4576 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
4577
4578         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
4579         thread functions.
4580         (obsd_nat_target::wait): Likewise.
4581
4582 2020-04-15  Tom Tromey  <tromey@adacore.com>
4583
4584         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
4585         (DEBUG_EXCEPT): Use debug_printf.
4586
4587 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4588
4589         * completer.c (class completion_tracker::completion_hash_entry)
4590         <hash_name>: New member function.
4591         (completion_tracker::discard_completions): New callback to hash a
4592         completion_hash_entry, pass this to htab_create_alloc.
4593
4594 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
4595
4596         * windows-nat.c (windows_make_so): Warn rather than stopping with
4597         an error if realpath() fails.
4598
4599 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
4600
4601         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
4602         (nbsd_nat_target::info_proc): Add do_status.
4603
4604 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
4605             Tom de Vries  <tdevries@suse.de>
4606
4607         PR symtab/25718
4608         * psympriv.h (struct partial_symtab::read_symtab)
4609         (struct partial_symtab::expand_psymtab)
4610         (struct partial_symtab::read_dependencies): Update comments.
4611         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
4612         read_symtab for includer.
4613         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
4614         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
4615         (struct dwarf2_include_psymtab::m_readin): Remove.
4616         (struct dwarf2_include_psymtab::includer): New member function.
4617         (dwarf2_psymtab::expand_psymtab): Assert !readin.
4618
4619 2020-04-14  Tom de Vries  <tdevries@suse.de>
4620
4621         PR symtab/25720
4622         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
4623         with NULL symbol_matcher and lookup_name.
4624         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
4625         and lookup_name.
4626         * dwarf2/read.c (dw2_expand_symtabs_matching)
4627         (dw2_debug_names_expand_symtabs_matching): Same.
4628         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
4629         Make lookup_name a pointer.  Update comment.
4630         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
4631         lookup_name being a pointer.
4632         * symfile.c (expand_symtabs_matching): Same.
4633         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
4634         * linespec.c (iterate_over_all_matching_symtabs): Same.
4635
4636 2020-04-13  Tom Tromey  <tom@tromey.com>
4637
4638         * run-on-main-thread.c: Update include.
4639         * unittests/main-thread-selftests.c: Update include.
4640         * tui/tui-win.c: Update include.
4641         * tui/tui-io.c: Update include.
4642         * tui/tui-interp.c: Update include.
4643         * tui/tui-hooks.c: Update include.
4644         * top.h: Update include.
4645         * top.c: Update include.
4646         * ser-base.c: Update include.
4647         * remote.c: Update include.
4648         * remote-notif.c: Update include.
4649         * remote-fileio.c: Update include.
4650         * record-full.c: Update include.
4651         * record-btrace.c: Update include.
4652         * python/python.c: Update include.
4653         * posix-hdep.c: Update include.
4654         * mingw-hdep.c: Update include.
4655         * mi/mi-main.c: Update include.
4656         * mi/mi-interp.c: Update include.
4657         * main.c: Update include.
4658         * linux-nat.c: Update include.
4659         * interps.c: Update include.
4660         * infrun.c: Update include.
4661         * inf-loop.c: Update include.
4662         * event-top.c: Update include.
4663         * event-loop.c: Move to ../gdbsupport/.
4664         * event-loop.h: Move to ../gdbsupport/.
4665         * async-event.h: Update include.
4666         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
4667
4668 2020-04-13  Tom Tromey  <tom@tromey.com>
4669
4670         * tui/tui-win.c: Include async-event.h.
4671         * remote.c: Include async-event.h.
4672         * remote-notif.c: Include async-event.h.
4673         * record-full.c: Include async-event.h.
4674         * record-btrace.c: Include async-event.h.
4675         * infrun.c: Include async-event.h.
4676         * event-top.c: Include async-event.h.
4677         * event-loop.h: Move some declarations to async-event.h.
4678         * event-loop.c: Don't include ser-event.h or top.h.  Move some
4679         code to async-event.c.
4680         * async-event.h: New file.
4681         * async-event.c: New file.
4682         * Makefile.in (COMMON_SFILES): Add async-event.c.
4683         (HFILES_NO_SRCDIR): Add async-event.h.
4684
4685 2020-04-13  Tom Tromey  <tom@tromey.com>
4686
4687         * utils.c (flush_streams): New function.
4688         * event-loop.c (gdb_wait_for_event): Call flush_streams.
4689
4690 2020-04-13  Tom Tromey  <tom@tromey.com>
4691
4692         * event-loop.c (handle_file_event): Use warning, not
4693         printf_unfiltered.
4694
4695 2020-04-13  Tom Tromey  <tom@tromey.com>
4696
4697         * event-loop.c: Include <chrono>.
4698
4699 2020-04-13  Tom Tromey  <tom@tromey.com>
4700
4701         * gdb_select.h: Move to ../gdbsupport/.
4702         * event-loop.c: Update include path.
4703         * top.c: Update include path.
4704         * ser-base.c: Update include path.
4705         * ui-file.c: Update include path.
4706         * ser-tcp.c: Update include path.
4707         * guile/scm-ports.c: Update include path.
4708         * posix-hdep.c: Update include path.
4709         * ser-unix.c: Update include path.
4710         * gdb_usleep.c: Update include path.
4711         * mingw-hdep.c: Update include path.
4712         * inflow.c: Update include path.
4713         * infrun.c: Update include path.
4714         * event-top.c: Update include path.
4715
4716 2020-04-13  Tom Tromey  <tom@tromey.com>
4717
4718         * configure: Rebuild.
4719         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
4720
4721 2020-04-13  Tom Tromey  <tom@tromey.com>
4722
4723         * event-loop.h (start_event_loop): Don't declare.
4724         * event-loop.c (start_event_loop): Move...
4725         * main.c (start_event_loop): ...here.  Now static.
4726
4727 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
4728
4729         * MAINTAINERS: Update my email address.
4730
4731 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4732
4733         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
4734         IP_ALL.
4735
4736 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4737
4738         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
4739         (nbsd_nat_target::info_proc): Add do_cmdline.
4740
4741 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4742
4743         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
4744         (nbsd_nat_target::info_proc): Add do_cwd.
4745
4746 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4747
4748         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
4749
4750 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
4751
4752         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
4753         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
4754         (nbsd_nat_target::info_proc): New functions.
4755         * nbsd-nat.c (kinfo_get_vmmap): New function.
4756         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
4757         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
4758         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
4759         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
4760         functions.
4761         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
4762         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
4763         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
4764         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
4765         (KINFO_VME_FLAG_GROWS_DOWN): New.
4766
4767 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
4768
4769         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
4770         bit shift.
4771
4772 2020-04-10  Tom Tromey  <tromey@adacore.com>
4773
4774         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
4775
4776 2020-04-10  Tom Tromey  <tromey@adacore.com>
4777
4778         * symtab.c (get_symbol_address, get_msymbol_address): Skip
4779         separate debug files.
4780
4781 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
4782
4783         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
4784         Move to...
4785         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
4786         ... here.
4787         * windows-nat.c (windows_nat_target::get_windows_debug_event):
4788         Check for STATUS_WX86_BREAKPOINT.
4789         (windows_nat_target::wait): Same.
4790
4791 2020-04-10  Tom de Vries  <tdevries@suse.de>
4792
4793         PR cli/25808
4794         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
4795
4796 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4797
4798         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
4799         (Write After Approval): Remove Tom de Vries.
4800
4801 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4802
4803         revert partially:
4804         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4805
4806         * buildsym.c (record_line): Fix undefined behavior and preserve
4807         lines at eof.
4808
4809 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
4810
4811         * auxv.h (svr4_auxv_parse): New.
4812         * auxv.c (default_auxv_parse): Split into default_auxv_parse
4813         and generic_auxv_parse.
4814         (svr4_auxv_parse): Add.
4815         * obsd-tdep.c: Include "auxv.h".
4816         (obsd_auxv_parse): Remove.
4817         (obsd_init_abi): Remove comment.
4818         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
4819         from `obsd_auxv_parse' to `svr4_auxv_parse'.
4820         * nbsd-tdep.c: Include "auxv.h".
4821         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
4822
4823 2020-04-08  Tom Tromey  <tromey@adacore.com>
4824
4825         * nat/windows-nat.h (last_wait_event): Don't declare.
4826         (wait_for_debug_event): Update comment.
4827         * nat/windows-nat.c (last_wait_event): Now static.
4828
4829 2020-04-08  Tom Tromey  <tromey@adacore.com>
4830
4831         * windows-nat.c (wait_for_debug_event): Move to
4832         nat/windows-nat.c.
4833         * nat/windows-nat.h (wait_for_debug_event): Declare.
4834         * nat/windows-nat.c (wait_for_debug_event): Move from
4835         windows-nat.c.  No longer static.
4836
4837 2020-04-08  Tom Tromey  <tromey@adacore.com>
4838
4839         * windows-nat.c (get_windows_debug_event): Use
4840         fetch_pending_stop.
4841         * nat/windows-nat.h (fetch_pending_stop): Declare.
4842         * nat/windows-nat.c (fetch_pending_stop): New function.
4843
4844 2020-04-08  Tom Tromey  <tromey@adacore.com>
4845
4846         * windows-nat.c (windows_continue): Use matching_pending_stop and
4847         continue_last_debug_event.
4848         * nat/windows-nat.h (matching_pending_stop)
4849         (continue_last_debug_event): Declare.
4850         * nat/windows-nat.c (DEBUG_EVENTS): New define.
4851         (matching_pending_stop, continue_last_debug_event): New
4852         functions.
4853
4854 2020-04-08  Tom Tromey  <tromey@adacore.com>
4855
4856         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
4857         (handle_exception_result): Move to nat/windows-nat.h.
4858         (DEBUG_EXCEPTION_SIMPLE): Remove.
4859         (windows_nat::handle_ms_vc_exception): New function.
4860         (handle_exception): Move to nat/windows-nat.c.
4861         (get_windows_debug_event): Update.
4862         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
4863         nat/windows-nat.c.
4864         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
4865         (handle_exception_result): Move from windows-nat.c.
4866         (handle_exception): Declare.
4867         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
4868         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
4869         windows-nat.c.
4870
4871 2020-04-08  Tom Tromey  <tromey@adacore.com>
4872
4873         * windows-nat.c (exception_count, event_count): Remove.
4874         (handle_exception, get_windows_debug_event)
4875         (do_initial_windows_stuff): Update.
4876
4877 2020-04-08  Tom Tromey  <tromey@adacore.com>
4878
4879         * windows-nat.c (windows_nat::handle_load_dll)
4880         (windows_nat::handle_unload_dll): Rename.  No longer static.
4881         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
4882         Declare.
4883
4884 2020-04-08  Tom Tromey  <tromey@adacore.com>
4885
4886         * complaints.h (stop_whining): Declare at top-level.
4887         (complaint): Don't declare stop_whining.
4888
4889 2020-04-08  Tom Tromey  <tromey@adacore.com>
4890
4891         * windows-nat.c (windows_nat::handle_output_debug_string):
4892         Rename.  No longer static.
4893         * nat/windows-nat.h (handle_output_debug_string): Declare.
4894
4895 2020-04-08  Tom Tromey  <tromey@adacore.com>
4896
4897         * windows-nat.c (current_process_handle, current_process_id)
4898         (main_thread_id, last_sig, current_event, last_wait_event)
4899         (current_windows_thread, desired_stop_thread_id, pending_stops)
4900         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
4901         (display_selectors, fake_create_process)
4902         (get_windows_debug_event): Update.
4903         * nat/windows-nat.h (current_process_handle, current_process_id)
4904         (main_thread_id, last_sig, current_event, last_wait_event)
4905         (current_windows_thread, desired_stop_thread_id, pending_stops)
4906         (struct pending_stop, siginfo_er): Move from windows-nat.c.
4907         * nat/windows-nat.c (current_process_handle, current_process_id)
4908         (main_thread_id, last_sig, current_event, last_wait_event)
4909         (current_windows_thread, desired_stop_thread_id, pending_stops)
4910         (siginfo_er): New globals.  Move from windows-nat.c.
4911
4912 2020-04-08  Tom Tromey  <tromey@adacore.com>
4913
4914         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
4915         (handle_load_dll): Update.
4916         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
4917
4918 2020-04-08  Tom Tromey  <tromey@adacore.com>
4919
4920         * windows-nat.c (enum thread_disposition_type): Move to
4921         nat/windows-nat.h.
4922         (windows_nat::thread_rec): Rename from thread_rec.  No longer
4923         static.
4924         (windows_add_thread, windows_nat_target::fetch_registers)
4925         (windows_nat_target::store_registers, handle_exception)
4926         (windows_nat_target::resume, get_windows_debug_event)
4927         (windows_nat_target::get_tib_address)
4928         (windows_nat_target::thread_name)
4929         (windows_nat_target::thread_alive): Update.
4930         * nat/windows-nat.h (enum thread_disposition_type): Move from
4931         windows-nat.c.
4932         (thread_rec): Declare.
4933
4934 2020-04-08  Tom Tromey  <tromey@adacore.com>
4935
4936         * windows-nat.c: Add "using namespace".
4937         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
4938         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
4939
4940 2020-04-08  Tom Tromey  <tromey@adacore.com>
4941
4942         * nat/windows-nat.h (struct windows_thread_info): Declare
4943         destructor.
4944         * nat/windows-nat.c (~windows_thread_info): New.
4945
4946 2020-04-08  Tom Tromey  <tromey@adacore.com>
4947
4948         PR gdb/22992
4949         * windows-nat.c (current_event): Update comment.
4950         (last_wait_event, desired_stop_thread_id): New globals.
4951         (struct pending_stop): New.
4952         (pending_stops): New global.
4953         (windows_nat_target) <stopped_by_sw_breakpoint>
4954         <supports_stopped_by_sw_breakpoint>: New methods.
4955         (windows_fetch_one_register): Add assertions.  Adjust PC.
4956         (windows_continue): Handle pending stops.  Suspend other threads
4957         when stepping.  Use last_wait_event
4958         (wait_for_debug_event): New function.
4959         (get_windows_debug_event): Use wait_for_debug_event.  Handle
4960         pending stops.  Queue spurious stops.
4961         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
4962         (windows_nat_target::kill): Use wait_for_debug_event.
4963         * nat/windows-nat.h (struct windows_thread_info)
4964         <stopped_at_software_breakpoint>: New field.
4965         * nat/windows-nat.c (windows_thread_info::resume): Clear
4966         stopped_at_software_breakpoint.
4967
4968 2020-04-08  Tom Tromey  <tromey@adacore.com>
4969
4970         * windows-nat.c (enum thread_disposition_type): New.
4971         (thread_rec): Replace "get_context" parameter with "disposition";
4972         change type.
4973         (windows_add_thread, windows_nat_target::fetch_registers)
4974         (windows_nat_target::store_registers, handle_exception)
4975         (windows_nat_target::resume, get_windows_debug_event)
4976         (windows_nat_target::get_tib_address)
4977         (windows_nat_target::thread_name)
4978         (windows_nat_target::thread_alive): Update.
4979
4980 2020-04-08  Tom Tromey  <tromey@adacore.com>
4981
4982         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
4983         (windows_continue): Use windows_continue::resume.
4984         * nat/windows-nat.h (struct windows_thread_info) <suspend,
4985         resume>: Declare new methods.
4986         * nat/windows-nat.c: New file.
4987         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
4988
4989 2020-04-08  Tom Tromey  <tromey@adacore.com>
4990
4991         * windows-nat.c (windows_add_thread, windows_delete_thread)
4992         (windows_nat_target::fetch_registers)
4993         (windows_nat_target::store_registers, fake_create_process)
4994         (windows_nat_target::resume, windows_nat_target::resume)
4995         (get_windows_debug_event, windows_nat_target::wait)
4996         (windows_nat_target::pid_to_str)
4997         (windows_nat_target::get_tib_address)
4998         (windows_nat_target::get_ada_task_ptid)
4999         (windows_nat_target::thread_name)
5000         (windows_nat_target::thread_alive): Use lwp, not tid.
5001
5002 2020-04-08  Tom Tromey  <tromey@adacore.com>
5003
5004         * windows-nat.c (handle_exception)
5005         (windows_nat_target::thread_name): Update.
5006         * nat/windows-nat.h (windows_thread_info): Remove destructor.
5007         <name>: Now unique_xmalloc_ptr.
5008
5009 2020-04-08  Tom Tromey  <tromey@adacore.com>
5010
5011         * windows-nat.c (thread_rec)
5012         (windows_nat_target::fetch_registers): Update.
5013         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
5014         Update comment.
5015         <debug_registers_changed, reload_context>: Now bool.
5016
5017 2020-04-08  Tom Tromey  <tromey@adacore.com>
5018
5019         * windows-nat.c (windows_add_thread): Use new.
5020         (windows_init_thread_list, windows_delete_thread): Use delete.
5021         (get_windows_debug_event): Update.
5022         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
5023         destructor, and initializers.
5024
5025 2020-04-08  Tom Tromey  <tromey@adacore.com>
5026
5027         * windows-nat.c (struct windows_thread_info): Remove.
5028         * nat/windows-nat.h: New file.
5029
5030 2020-04-08  Tom Tromey  <tromey@adacore.com>
5031
5032         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
5033         (thread_rec, windows_add_thread, windows_delete_thread)
5034         (windows_continue): Update.
5035
5036 2020-04-08  Tom Tromey  <tromey@adacore.com>
5037
5038         * windows-nat.c (struct windows_thread_info): Remove typedef.
5039         (thread_head): Remove.
5040         (thread_list): New global.
5041         (thread_rec, windows_add_thread, windows_init_thread_list)
5042         (windows_delete_thread, windows_continue): Update.
5043
5044 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
5045
5046         * windows-tdep.h (windows_init_abi): Add comment.
5047         (cygwin_init_abi): New declaration.
5048         * windows-tdep.c: Split signal enumeration in two, one for
5049         Windows and one for Cygwin.
5050         (windows_gdb_signal_to_target): Only deal with signal of the
5051         Windows OS ABI.
5052         (cygwin_gdb_signal_to_target): New function.
5053         (windows_init_abi): Rename to windows_init_abi_common, don't set
5054         gdb_signal_to_target gdbarch method.  Add new new function with
5055         this name.
5056         (cygwin_init_abi): New function.
5057         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
5058         comment.  Don't call windows_init_abi.
5059         (amd64_windows_init_abi): Add comment, call windows_init_abi.
5060         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
5061         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
5062         i386_windows_init_abi_common, don't call windows_init_abi.  Add
5063         a new function of this name.
5064         (i386_cygwin_init_abi): New function.
5065         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
5066         OS ABI Cygwin.
5067
5068 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
5069
5070         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
5071         parameter.c.
5072         (dwarf2_read_gdb_index): Update.
5073
5074 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
5075
5076         * nbsd-tdep.c: Include "objfiles.h".
5077         (nbsd_skip_solib_resolver): New.
5078         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
5079
5080 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
5081
5082         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
5083         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
5084         with DW_LLE_base_addressx are being emitted in DWARFv5.
5085         Add the newly added kind DW_LOC_OFFSET_PAIR also.
5086         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
5087         unsigned integer.
5088
5089 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
5090
5091         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
5092         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
5093         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
5094         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
5095         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
5096         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
5097         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
5098
5099
5100 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
5101
5102         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
5103         (read_loclist_index): New function definition.
5104         (lookup_loclist_base): New function definition.
5105         (read_loclist_header): New function definition.
5106         (dwarf2_cu): Add loclist_base and loclist_header field.
5107         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
5108         (read_full_die_1): Read the value of DW_AT_loclists_base.
5109         (read_attribute_reprocess): Handle DW_FORM_loclistx.
5110         (read_attribute_value): Handle DW_FORM_loclistx.
5111         (skip_one_die): Handle DW_FORM_loclistx.
5112         (loclist_header): New structure declaration.
5113         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
5114
5115 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
5116
5117         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
5118         constructor.  Remove `addr` parameter from other constructor and
5119         add `per_cu` parameter.
5120         * dwarf2/read.c (create_partial_symtab): Update.
5121
5122 2020-04-07  Tom de Vries  <tdevries@suse.de>
5123
5124         PR symtab/25796
5125         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
5126         (partial_die_info::fixup): Inherit has_const_value.
5127
5128 2020-04-07  Tom de Vries  <tdevries@suse.de>
5129
5130         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
5131         symbols without address.
5132
5133 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
5134
5135         * nbsd-nat.h (struct thread_info): Add forward declaration.
5136         (nbsd_nat_target::thread_alive): Add.
5137         (nbsd_nat_target::thread_name): Likewise.
5138         (nbsd_nat_target::update_thread_list): Likewise.
5139         (update_thread_list::post_attach): Likewise.
5140         (post_attach::pid_to_str): Likewise.
5141         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
5142         (nbsd_thread_lister): Add.
5143         (nbsd_nat_target::thread_alive): Likewise.
5144         (nbsd_nat_target::thread_name): Likewise.
5145         (nbsd_add_threads): Likewise.
5146         (update_thread_list::post_attach): Likewise.
5147         (nbsd_nat_target::update_thread_list): Likewise.
5148         (post_attach::pid_to_str): Likewise.
5149
5150 2020-04-06  Tom Tromey  <tromey@adacore.com>
5151
5152         * ada-valprint.c (print_variant_part): Extract the variant field.
5153         (print_field_values): Use the field as the outer value when
5154         recursing.
5155
5156 2020-04-06  Tom Tromey  <tromey@adacore.com>
5157
5158         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
5159         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
5160         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
5161         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
5162         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
5163
5164 2020-04-06  Tom Tromey  <tromey@adacore.com>
5165
5166         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
5167         TYPE_CODE_ERROR.
5168
5169 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
5170
5171         * nbsd-tdep.c: Include "gdbarch.h".
5172         Define enum with NetBSD signal numbers.
5173         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
5174         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
5175         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
5176         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
5177         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
5178         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
5179         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
5180         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
5181         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
5182         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
5183         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
5184         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
5185
5186 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
5187
5188         PR gdb/25325
5189         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
5190
5191 2020-04-03  Tom Tromey  <tromey@adacore.com>
5192
5193         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
5194         Read constant block.
5195
5196 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
5197
5198         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
5199         (gdb_bfd_get_full_section_contents): New declaration.
5200         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
5201         * windows-tdep.c (is_linked_with_cygwin_dll): Use
5202         gdb_bfd_get_full_section_contents.
5203
5204 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
5205
5206         * exec.c (build_section_table): Replace internal_error with
5207         gdb_assert.
5208         (section_table_xfer_memory_partial): Likewise.
5209         * mdebugread.c (parse_partial_symbols): Likewise.
5210         * psymtab.c (lookup_partial_symbol): Likewise.
5211         * utils.c (wrap_here): Likewise.
5212
5213 2020-04-02  Tom Tromey  <tromey@adacore.com>
5214
5215         * f-lang.c (build_fortran_types): Use arch_type to initialize
5216         builtin_complex_s32 in the TYPE_CODE_ERROR case.
5217
5218 2020-04-02  Tom Tromey  <tromey@adacore.com>
5219
5220         * dwarf2/read.c (partial_die_info::read): Do not create a vector
5221         of attributes.
5222
5223 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5224             Bernd Edlinger <bernd.edlinger@hotmail.de>
5225             Tom Tromey  <tromey@adacore.com>
5226
5227         * buildsym.c (buildsym_compunit::record_line): Remove
5228         deduplication code.
5229
5230 2020-04-02  Tom de Vries  <tdevries@suse.de>
5231
5232         PR ada/24671
5233         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
5234
5235 2020-04-02  Tom de Vries  <tdevries@suse.de>
5236
5237         * dwarf2/read.c (dwarf2_gdb_index_functions,
5238         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
5239         NULL.
5240         * psymtab.c (psym_lookup_global_symbol_language): New function.
5241         (psym_functions): Init psym_lookup_global_symbol_language with
5242         psym_lookup_global_symbol_language.
5243         * symfile-debug.c (debug_sym_quick_functions): Init
5244         lookup_global_symbol_language with NULL.
5245         * symfile.c (set_initial_language): Remove fixme comment.
5246         * symfile.h (struct quick_symbol_functions): Add
5247         lookup_global_symbol_language.
5248         * symtab.c (find_quick_global_symbol_language): New function.
5249         (find_main_name): Use find_quick_global_symbol_language.
5250
5251 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
5252
5253         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
5254
5255 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5256
5257         * buildsym.c (record_line): Fix undefined behavior and preserve
5258         lines at eof.
5259
5260 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5261
5262         * buildsym.c (record_line): Fix the resizing condition.
5263
5264 2020-04-01  Tom Tromey  <tom@tromey.com>
5265
5266         * value.h (value_literal_complex): Add comment.
5267         * valops.c (value_literal_complex): Refer to value.h.
5268
5269 2020-04-01  Tom Tromey  <tom@tromey.com>
5270
5271         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
5272         (scalar_type): New rule, from typebase.
5273         (typebase): Use scalar_type.  Recognize complex types.
5274         (field_name): Handle FLOAT_KEYWORD.
5275         (ident_tokens): Add _Complex and __complex__.
5276
5277 2020-04-01  Tom Tromey  <tom@tromey.com>
5278
5279         PR exp/25299:
5280         * valarith.c (promotion_type, complex_binop): New functions.
5281         (scalar_binop): Handle complex numbers.  Use promotion_type.
5282         (value_pos, value_neg, value_complement): Handle complex numbers.
5283
5284 2020-04-01  Tom Tromey  <tom@tromey.com>
5285
5286         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
5287         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
5288         (parse_number): Handle complex numbers.
5289
5290 2020-04-01  Tom Tromey  <tom@tromey.com>
5291
5292         * c-valprint.c (c_decorations): Change complex suffix to "i".
5293
5294 2020-04-01  Tom Tromey  <tom@tromey.com>
5295
5296         * valprint.c (generic_value_print_complex): Use accessors.
5297         * value.h (value_real_part, value_imaginary_part): Declare.
5298         * valops.c (value_real_part, value_imaginary_part): New
5299         functions.
5300         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
5301
5302 2020-04-01  Tom Tromey  <tom@tromey.com>
5303
5304         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
5305         (read_range_type): Update.
5306         * mdebugread.c (basic_type): Update.
5307         * go-lang.c (build_go_types): Use init_complex_type.
5308         * gdbtypes.h (struct main_type) <complex_type>: New member.
5309         (init_complex_type): Update.
5310         (arch_complex_type): Don't declare.
5311         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
5312         Make name if none given.  Use alloc_type_copy.  Look for cached
5313         complex type.
5314         (arch_complex_type): Remove.
5315         (gdbtypes_post_init): Use init_complex_type.
5316         * f-lang.c (build_fortran_types): Use init_complex_type.
5317         * dwarf2/read.c (read_base_type): Update.
5318         * d-lang.c (build_d_types): Use init_complex_type.
5319         * ctfread.c (read_base_type): Update.
5320
5321 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5322
5323         * infrun.c (stop_all_threads): Update assertion, plus when
5324         stopping threads, take into account that we might be trying
5325         to stop an all-stop target.
5326         (stop_waiting): Call 'stop_all_threads' if there exists a
5327         non-stop target.
5328
5329 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5330
5331         * target.h (exists_non_stop_target): New function declaration.
5332         * target.c (exists_non_stop_target): New function.
5333
5334 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
5335
5336         PR gdb/24789
5337         * eval.c (is_integral_or_integral_reference): New function.
5338         (evaluate_subexp_standard): Allow integer references in
5339         pointer arithmetic.
5340
5341 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5342
5343         * remote.c (remote_target::remote_parse_stop_reply): Remove the
5344         check for no ptid in the stop reply when the target is non-stop.
5345
5346 2020-04-01  Tom Tromey  <tromey@adacore.com>
5347
5348         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
5349         "name" parameter to rvalue reference.  Initialize m_name_holder.
5350         <lookup_name_info>: New overloads.
5351         <name>: Return gdb::string_view.
5352         <c_str>: New method.
5353         <make_ignore_params>: Update.
5354         <search_name_hash>: Update.
5355         <language_lookup_name>: Return const char *.
5356         <m_name>: Change type.
5357         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
5358         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
5359         (lookup_name_info::match_any): Update.
5360         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
5361         Update.
5362         * minsyms.c (linkage_name_str): Update.
5363         * language.c (default_symbol_name_matcher): Update.
5364         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
5365         Update.
5366         * ada-lang.c (ada_fold_name): Change parameter to string_view.
5367         (ada_lookup_name_info::ada_lookup_name_info): Update.
5368         (literal_symbol_name_matcher): Update.
5369
5370 2020-04-01  Tom Tromey  <tromey@adacore.com>
5371
5372         * psymtab.c (psymtab_search_name): Remove function.
5373         (psym_lookup_symbol): Create search name and lookup name here.
5374         (lookup_partial_symbol): Remove "name" parameter; add
5375         lookup_name.
5376         (psym_expand_symtabs_for_function): Update.
5377
5378 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
5379
5380         PR tui/25597:
5381         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
5382
5383 2020-03-31  Tom Tromey  <tromey@adacore.com>
5384
5385         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
5386         memcpy.
5387
5388 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
5389
5390         * features/riscv/32bit-csr.xml: Regenerated.
5391         * features/riscv/64bit-csr.xml: Regenerated.
5392
5393 2020-03-30  Tom Tromey  <tromey@adacore.com>
5394
5395         * ada-valprint.c (print_variant_part): Update.
5396         * ada-lang.h (ada_which_variant_applies): Update.
5397         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
5398         outer_valaddr parameters; replace with "outer" value parameter.
5399         (to_fixed_variant_branch_type): Update.
5400
5401 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5402
5403         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
5404         <list>.  Remove inclusion of observable.h.
5405         (PPC_DEBUG_CURRENT_VERSION): Move up define.
5406         (struct arch_lwp_info): New struct.
5407         (class ppc_linux_dreg_interface): New class.
5408         (struct ppc_linux_process_info): New struct.
5409         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
5410         <low_new_clone, low_forget_process, low_prepare_to_resume>
5411         <copy_thread_dreg_state, mark_thread_stale>
5412         <mark_debug_registers_changed, register_hw_breakpoint>
5413         <clear_hw_breakpoint, register_wp, clear_wp>
5414         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
5415         <num_memory_accesses, get_trigger_type>
5416         <create_watchpoint_request, hwdebug_point_cmp>
5417         <init_arch_lwp_info, get_arch_lwp_info>
5418         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
5419         methods.
5420         <struct ptid_hash>: New inner struct.
5421         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
5422         members.
5423         (saved_dabr_value, hwdebug_info, max_slots_number)
5424         (struct hw_break_tuple, struct thread_points, ppc_threads)
5425         (have_ptrace_hwdebug_interface)
5426         (hwdebug_find_thread_points_by_tid)
5427         (hwdebug_insert_point, hwdebug_remove_point): Remove.
5428         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
5429         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
5430         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
5431         use m_dreg_interface.
5432         (hwdebug_point_cmp): Change to...
5433         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
5434         reference arguments instead of pointers.
5435         (ppc_linux_nat_target::ranged_break_num_registers): Use
5436         m_dreg_interface.
5437         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
5438         m_dreg_interface.  Call register_hw_breakpoint.
5439         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
5440         m_dreg_interface.  Call clear_hw_breakpoint.
5441         (get_trigger_type): Change to...
5442         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
5443         comment.
5444         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
5445         use m_dreg_interface.  Call register_hw_breakpoint.
5446         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
5447         use m_dreg_interface.  Call clear_hw_breakpoint.
5448         (can_use_watchpoint_cond_accel): Change to...
5449         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
5450         method.  Update comment, use m_dreg_interface and
5451         m_process_info.
5452         (calculate_dvc): Change to...
5453         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
5454         m_dreg_interface.
5455         (num_memory_accesses): Change to...
5456         (ppc_linux_nat_target::num_memory_accesses): ...this method.
5457         (check_condition): Change to...
5458         (ppc_linux_nat_target::check_condition): ...this method.
5459         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
5460         comment, use m_dreg_interface.
5461         (create_watchpoint_request): Change to...
5462         (ppc_linux_nat_target::create_watchpoint_request): ...this
5463         method.  Use m_dreg_interface.
5464         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
5465         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
5466         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
5467         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
5468         (ppc_linux_nat_target::low_forget_process)
5469         (ppc_linux_nat_target::low_new_fork)
5470         (ppc_linux_nat_target::low_new_clone)
5471         (ppc_linux_nat_target::low_delete_thread)
5472         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
5473         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
5474         only call mark_thread_stale.
5475         (ppc_linux_thread_exit): Remove.
5476         (ppc_linux_nat_target::stopped_data_address): Change to...
5477         (ppc_linux_nat_target::low_stopped_data_address): This. Add
5478         comment, use m_dreg_interface and m_thread_hw_breakpoints.
5479         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
5480         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
5481         comment.  Call low_stopped_data_address.
5482         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
5483         m_dreg_interface.
5484         (ppc_linux_nat_target::masked_watch_num_registers): Use
5485         m_dreg_interface.
5486         (ppc_linux_nat_target::copy_thread_dreg_state)
5487         (ppc_linux_nat_target::mark_thread_stale)
5488         (ppc_linux_nat_target::mark_debug_registers_changed)
5489         (ppc_linux_nat_target::register_hw_breakpoint)
5490         (ppc_linux_nat_target::clear_hw_breakpoint)
5491         (ppc_linux_nat_target::register_wp)
5492         (ppc_linux_nat_target::clear_wp)
5493         (ppc_linux_nat_target::init_arch_lwp_info)
5494         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
5495         (_initialize_ppc_linux_nat): Remove observer callback.
5496
5497 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5498
5499         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
5500         (ppc_linux_nat_target::auxv_parse)
5501         (ppc_linux_nat_target::read_description)
5502         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
5503         Move up.
5504
5505 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5506
5507         * linux-nat.h (low_new_clone): New method.
5508         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
5509
5510 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
5511
5512         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
5513         (dbx_expand_psymtab): ... this.
5514         (start_psymtab): Update.
5515         * mdebugread.c (psymtab_to_symtab_1): Rename to...
5516         (mdebug_expand_psymtab): ... this.
5517         (parse_partial_symbols): Update.
5518         (new_psymtab): Update.
5519         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
5520         (xcoff_expand_psymtab): ... this.
5521         (xcoff_start_psymtab): Update.
5522
5523 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
5524
5525         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
5526         <expand_dependencies>: ... this.
5527         * psymtab.c (partial_symtab::read_dependencies): Rename to...
5528         (partial_symtab::expand_dependencies): ... this.
5529         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
5530         Update.
5531         (dwarf2_psymtab::expand_psymtab): Update.
5532         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
5533         * mdebugread.c (psymtab_to_symtab_1): Update.
5534         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
5535
5536 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
5537
5538         * psympriv.h (discard_psymtab): Remove.
5539         * dbxread.c (dbx_end_psymtab): Update.
5540         * xcoffread.c (xcoff_end_psymtab): Update.
5541
5542 2020-03-28  Tom Tromey  <tom@tromey.com>
5543
5544         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
5545         comment.
5546
5547 2020-03-28  Tom Tromey  <tom@tromey.com>
5548
5549         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
5550
5551 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
5552
5553         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
5554
5555 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
5556
5557         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
5558
5559 2020-03-26  Tom Tromey  <tom@tromey.com>
5560
5561         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
5562         (mark_common_block_symbol_computed, read_tag_string_type)
5563         (attr_to_dynamic_prop, read_subrange_type): Update.
5564         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
5565         to be methods on struct attribute.
5566         (skip_one_die, process_imported_unit_die, read_namespace_alias)
5567         (read_call_site_scope, partial_die_info::read)
5568         (partial_die_info::read, lookup_die_type, follow_die_ref):
5569         Update.
5570         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
5571         from dwarf2_get_ref_die_offset.
5572         (attribute::constant_value): New method, from
5573         dwarf2_get_attr_constant_value.
5574         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
5575         Declare method.
5576         <constant_value>: New method.
5577
5578 2020-03-26  Tom Tromey  <tom@tromey.com>
5579
5580         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
5581         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
5582         (dwarf_type_encoding_name): Move to stringify.c.
5583         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
5584         * dwarf2/stringify.c: New file.
5585         * dwarf2/stringify.h: New file.
5586
5587 2020-03-26  Tom Tromey  <tom@tromey.com>
5588
5589         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
5590         Rewrite.
5591
5592 2020-03-26  Tom Tromey  <tom@tromey.com>
5593
5594         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
5595         methods.
5596         * dwarf2/read.c (lookup_addr_base): Move to die.h.
5597         (lookup_ranges_base): Likewise.
5598         (read_cutu_die_from_dwo, read_full_die_1): Update.
5599
5600 2020-03-26  Tom Tromey  <tom@tromey.com>
5601
5602         * dwarf2/read.c (read_import_statement, read_file_scope)
5603         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
5604         (read_lexical_block_scope, read_call_site_scope)
5605         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
5606         (handle_struct_member_die, process_structure_scope)
5607         (update_enumeration_type_from_children)
5608         (process_enumeration_scope, read_array_type, read_common_block)
5609         (read_namespace, read_module, read_subroutine_type): Update.
5610         (sibling_die): Remove.
5611
5612 2020-03-26  Tom Tromey  <tom@tromey.com>
5613
5614         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
5615         (build_type_psymtabs_reader, read_structure_type)
5616         (read_enumeration_type, read_full_die_1): Update.
5617         (dwarf2_attr_no_follow): Move to die.h.
5618         * dwarf2/die.h (struct die_info) <attr>: New method.
5619
5620 2020-03-26  Tom Tromey  <tom@tromey.com>
5621
5622         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
5623         <base_address>: Now an optional.
5624         (dwarf2_find_base_address, dwarf2_rnglists_process)
5625         (dwarf2_ranges_process, fill_in_loclist_baton)
5626         (dwarf2_symbol_mark_computed): Update.
5627
5628 2020-03-26  Tom Tromey  <tom@tromey.com>
5629
5630         * dwarf2/read.c (struct die_info): Move to die.h.
5631         * dwarf2/die.h: New file.
5632
5633 2020-03-26  Tom Tromey  <tom@tromey.com>
5634
5635         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
5636         * dwarf2/read.c
5637         (dwarf2_statement_list_fits_in_line_number_section_complaint):
5638         Move to line-header.c.
5639         (read_checked_initial_length_and_offset, read_formatted_entries):
5640         Likewise.
5641         (dwarf_decode_line_header): Split into two.
5642         * dwarf2/line-header.c
5643         (dwarf2_statement_list_fits_in_line_number_section_complaint):
5644         Move from read.c.
5645         (read_checked_initial_length_and_offset, read_formatted_entries):
5646         Likewise.
5647         (dwarf_decode_line_header): New function, split from read.c.
5648
5649 2020-03-26  Tom Tromey  <tom@tromey.com>
5650
5651         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
5652         Declare method.
5653         * dwarf2/read.c (read_attribute_value): Update.
5654         (dwarf2_per_objfile::read_line_string): Rename from
5655         read_indirect_line_string.
5656         (read_formatted_entries): Update.
5657
5658 2020-03-26  Tom Tromey  <tom@tromey.com>
5659
5660         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
5661         variable.
5662
5663 2020-03-26  Tom Tromey  <tom@tromey.com>
5664
5665         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
5666         const.
5667         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
5668         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
5669         parameter const.
5670
5671 2020-03-26  Tom Tromey  <tom@tromey.com>
5672
5673         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
5674         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
5675         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
5676         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
5677
5678 2020-03-26  Tom Tromey  <tom@tromey.com>
5679
5680         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
5681         file_names_size, file_full_name, file_file_name>: Use const.
5682         <file_name_at, file_names>: Add const overload.
5683         * dwarf2/line-header.c (line_header::file_file_name)
5684         (line_header::file_full_name): Update.
5685
5686 2020-03-26  Tom Tromey  <tom@tromey.com>
5687
5688         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
5689         (macro_start_file, consume_improper_spaces)
5690         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
5691         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
5692         (dwarf_decode_macros): Move to macro.c.
5693         * dwarf2/macro.c: New file.
5694         * dwarf2/macro.h: New file.
5695         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
5696
5697 2020-03-26  Tom Tromey  <tom@tromey.com>
5698
5699         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
5700         method.
5701         * dwarf2/section.c: New method.  From
5702         read_indirect_string_at_offset_from.
5703         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
5704         (read_indirect_string_at_offset_from): Move to section.c.
5705         (read_indirect_string_at_offset): Rewrite.
5706         (read_indirect_line_string_at_offset): Remove.
5707         (read_indirect_string, read_indirect_line_string)
5708         (dwarf_decode_macro_bytes): Update.
5709
5710 2020-03-26  Tom Tromey  <tom@tromey.com>
5711
5712         * dwarf2/section.h (struct dwarf2_section_info)
5713         <overload_complaint>: Declare.
5714         (dwarf2_section_buffer_overflow_complaint): Don't declare.
5715         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
5716         Rename from dwarf2_section_buffer_overflow_complaint.
5717         * dwarf2/read.c (skip_one_die, partial_die_info::read)
5718         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
5719
5720 2020-03-26  Tom Tromey  <tom@tromey.com>
5721
5722         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
5723         Declare.
5724         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
5725         Move from read.c.
5726         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
5727         to section.c.
5728
5729 2020-03-26  Tom Tromey  <tom@tromey.com>
5730
5731         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
5732
5733 2020-03-26  Tom Tromey  <tom@tromey.com>
5734
5735         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
5736         "builder".
5737         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
5738         parameter.
5739         (dwarf_decode_macros): Update.
5740
5741 2020-03-26  Tom Tromey  <tom@tromey.com>
5742
5743         * dwarf2/read.c (read_attribute_value): Update.
5744         (read_indirect_string_from_dwz): Move to dwz.c; change into
5745         method.
5746         (dwarf_decode_macro_bytes): Update.
5747         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
5748         * dwarf2/dwz.c: New file.
5749         * Makefile.in (COMMON_SFILES): Add dwz.c.
5750
5751 2020-03-26  Tom Tromey  <tom@tromey.com>
5752
5753         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
5754         * dwarf2/read.c: Add include.
5755         * dwarf2/index-write.c: Add include.
5756         * dwarf2/index-cache.c: Add include.
5757         * dwarf2/dwz.h: New file.
5758
5759 2020-03-25  Tom Tromey  <tom@tromey.com>
5760
5761         * compile/compile-object-load.c (get_out_value_type): Mention
5762         correct symbol name in error message.
5763
5764 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
5765
5766         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
5767
5768 2020-03-25  Tom de Vries  <tdevries@suse.de>
5769
5770         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
5771         * symmisc.c (dump_symtab_1): Print user and includes fields.
5772         (maintenance_info_symtabs): Same.
5773
5774 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
5775
5776         PR gdb/25534
5777         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
5778         (riscv_regcache_cooked_write): New function.
5779         (riscv_push_dummy_call): Use new function.
5780         (riscv_return_value): Likewise.
5781
5782 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
5783
5784         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
5785         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
5786         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
5787         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
5788         * infrun.c (follow_fork): Likewise.
5789         (follow_fork_inferior): Likewise.
5790         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
5791         * linux-nat.h (class linux_nat_target): Likewise.
5792         * remote.c (class remote_target) <follow_fork>: Likewise.
5793         (remote_target::follow_fork): Likewise.
5794         * target-delegates.c: Re-generate.
5795         * target.c (default_follow_fork): Likewise.
5796         (target_follow_fork): Likewise.
5797         * target.h (struct target_ops) <follow_fork>: Likewise.
5798         (target_follow_fork): Likewise.
5799
5800 2020-03-24  Tom de Vries  <tdevries@suse.de>
5801
5802         * psymtab.c (maintenance_info_psymtabs): Print user field.
5803
5804 2020-03-20  Tom Tromey  <tromey@adacore.com>
5805
5806         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
5807         const.
5808         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
5809         const.
5810
5811 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
5812
5813         * ptrace.m4: Don't check for ptrace declaration.
5814         * config.in: Re-generate.
5815         * configure: Re-generate.
5816         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
5817         not defined.
5818
5819 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5820
5821         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
5822         `PTRACE_TYPE_RET'.
5823         * i386-bsd-nat.c (gdb_ptrace): Likewise.
5824         * sparc-nat.c (gdb_ptrace): Likewise.
5825         * x86-bsd-nat.c (gdb_ptrace): Likewise.
5826
5827 2020-03-20  Tom Tromey  <tromey@adacore.com>
5828
5829         * c-exp.y (lex_one_token): Fix assert.
5830
5831 2020-03-20  Tom Tromey  <tromey@adacore.com>
5832
5833         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
5834         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
5835         strncpy call.
5836
5837 2020-03-20  Tom Tromey  <tromey@adacore.com>
5838
5839         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
5840
5841 2020-03-20  Tom Tromey  <tromey@adacore.com>
5842
5843         * ada-valprint.c (print_variant_part): Remove parameters; switch
5844         to value-based API.
5845         (print_field_values): Likewise.
5846         (ada_val_print_struct_union): Likewise.
5847         (ada_value_print_1): Update.
5848
5849 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5850
5851         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
5852         nbsd_nat_target instead of inf_ptrace_target.
5853         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
5854         nbsd_nat_target.
5855
5856 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5857
5858         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
5859         it to the ptrace call.
5860         * (store_registers): Likewise.
5861
5862 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5863
5864         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
5865         it to the ptrace call.
5866         * (store_registers): Likewise.
5867
5868 2020-03-19  Luis Machado  <luis.machado@linaro.org>
5869
5870         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
5871         valid, fetch vg value from ptrace.
5872
5873 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
5874         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
5875         * inf-ptrace.c: Likewise.
5876         * (gdb_ptrace): Add.
5877         * (inf_ptrace_target::resume): Update.
5878         * (inf_ptrace_target::xfer_partial): Likewise.
5879         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
5880         * (inf_ptrace_peek_poke): Update.
5881
5882 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
5883
5884         * x86-bsd-nat.c (gdb_ptrace): New.
5885         * (x86bsd_dr_set): Add new argument `ptid'.
5886         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
5887         x86bsd_dr_set_addr): Update.
5888
5889 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5890
5891         * remote.c (remote_target::process_stop_reply): Handle events for
5892         all threads differently.
5893
5894 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5895
5896         * completer.c (completion_tracker::remove_completion): Define new
5897         function.
5898         * completer.h (completion_tracker::remove_completion): Declare new
5899         function.
5900         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
5901         when adding a C++ function symbol.
5902
5903 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5904
5905         * completer.c (completion_tracker::completion_hash_entry): Define
5906         new class.
5907         (advance_to_filename_complete_word_point): Call
5908         recompute_lowest_common_denominator.
5909         (completion_tracker::completion_tracker): Call discard_completions
5910         to setup the hash table.
5911         (completion_tracker::discard_completions): Allow for being called
5912         from the constructor, pass new equal function, and element deleter
5913         when constructing the hash table.  Initialise new class member
5914         variables.
5915         (completion_tracker::maybe_add_completion): Remove use of
5916         m_entries_vec, and store more information into m_entries_hash.
5917         (completion_tracker::recompute_lcd_visitor): New function, most
5918         content taken from...
5919         (completion_tracker::recompute_lowest_common_denominator):
5920         ...here, this now just visits each item in the hash calling the
5921         above visitor.
5922         (completion_tracker::build_completion_result): Remove use of
5923         m_entries_vec, call recompute_lowest_common_denominator.
5924         * completer.h (completion_tracker::have_completions): Remove use
5925         of m_entries_vec.
5926         (completion_tracker::completion_hash_entry): Declare new class.
5927         (completion_tracker::recompute_lowest_common_denominator): Change
5928         function signature.
5929         (completion_tracker::recompute_lcd_visitor): Declare new function.
5930         (completion_tracker::m_entries_vec): Delete.
5931         (completion_tracker::m_entries_hash): Initialize to NULL.
5932         (completion_tracker::m_lowest_common_denominator_valid): New
5933         member variable.
5934         (completion_tracker::m_lowest_common_denominator_max_length): New
5935         member variable.
5936
5937 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5938
5939         * regformats/regdef.h: Put reg in gdb namespace.
5940
5941 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5942
5943         * i386-bsd-nat.c (gdb_ptrace): New.
5944         * (i386bsd_fetch_inferior_registers,
5945         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
5946         * (i386bsd_fetch_inferior_registers,
5947         i386bsd_store_inferior_registers) Use gdb_ptrace.
5948
5949 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5950
5951         * amd64-bsd-nat.c (gdb_ptrace): New.
5952         * (amd64bsd_fetch_inferior_registers,
5953         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
5954         * (amd64bsd_fetch_inferior_registers,
5955         amd64bsd_store_inferior_registers) Use gdb_ptrace.
5956
5957 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5958
5959         * user-regs.c (user_reg::read): Rename to...
5960         (user_reg::xread): ...this.
5961         * (append_user_reg): Rename argument `read' to `xread'.
5962         * (user_reg_add_builtin): Likewise.
5963         * (user_reg_add): Likewise.
5964         * (value_of_user_reg): Likewise.
5965
5966 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5967
5968         * sparc-nat.c (gdb_ptrace): New.
5969         * sparc-nat.c (sparc_fetch_inferior_registers)
5970         (sparc_store_inferior_registers) Remove obsolete comment.
5971         * sparc-nat.c (sparc_fetch_inferior_registers)
5972         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
5973         * sparc-nat.c (sparc_fetch_inferior_registers)
5974         (sparc_store_inferior_registers) Use gdb_ptrace.
5975
5976 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5977
5978         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
5979         it to the ptrace call.
5980         * sh-nbsd-nat.c (store_registers): Likewise.
5981
5982 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5983
5984         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
5985         nbsd_nat_target instead of inf_ptrace_target.
5986         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
5987         nbsd_nat_target.
5988
5989 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5990
5991         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
5992
5993 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5994
5995         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
5996         <sys/sysctl.h>.
5997         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
5998
5999 2020-03-17  Tom de Vries  <tdevries@suse.de>
6000
6001         PR gdb/23710
6002         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
6003         fields.
6004         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
6005         fields.
6006         (process_imported_unit_die): Skip import of c++ CUs.
6007
6008 2020-03-16  Tom Tromey  <tom@tromey.com>
6009
6010         * p-valprint.c (pascal_object_print_value): Initialize
6011         base_value.
6012
6013 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
6014             Shahab Vahedi  <shahab@synopsys.com>
6015
6016         * Makefile.in: Add arch/arc.o
6017         * configure.tgt: Likewise.
6018         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
6019         (_initialize_arc_tdep): Don't initialize old target descriptions.
6020         (arc_read_description): New function to cache target descriptions.
6021         * arc-tdep.h (arc_read_description): Add proto type.
6022         * arch/arc.c: New file.
6023         * arch/arc.h: Likewise.
6024         * features/Makefile: Replace old target descriptions with new.
6025         * features/arc-arcompact.c: Remove.
6026         * features/arc-arcompact.xml: Likewise.
6027         * features/arc-v2.c: Likewise
6028         * features/arc-v2.xml: Likewise
6029         * features/arc/aux-arcompact.xml: New file.
6030         * features/arc/aux-v2.xml: Likewise.
6031         * features/arc/core-arcompact.xml: Likewise.
6032         * features/arc/core-v2.xml: Likewise.
6033         * features/arc/aux-arcompact.c: Generate.
6034         * features/arc/aux-v2.c: Likewise.
6035         * features/arc/core-arcompact.c: Likewise.
6036         * features/arc/core-v2.c: Likewise.
6037         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
6038
6039 2020-03-16  Tom Tromey  <tromey@adacore.com>
6040
6041         PR gdb/25663:
6042         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
6043         putting value into bcache.
6044
6045 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6046
6047         PR gdb/21500
6048         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
6049         to...
6050         (amd64_windows_init_abi_common): ... this.  Don't set size of
6051         long type.
6052         (amd64_windows_init_abi): New function.
6053         (amd64_cygwin_init_abi): New function.
6054         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
6055         the Cygwin OS ABI.
6056         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
6057         comment.
6058
6059 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6060
6061         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
6062         * windows-tdep.c (CYGWIN_DLL_NAME): New.
6063         (pe_import_directory_entry): New struct type.
6064         (is_linked_with_cygwin_dll): New function.
6065         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
6066         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
6067         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
6068
6069 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6070
6071         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
6072         i386_cygwin_core_osabi_sniffer.
6073
6074 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6075
6076         * i386-cygwin-tdep.c: Rename to...
6077         * i386-windows-tdep.c: ... this.
6078         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
6079         i386-windows-tdep.c.
6080         * configure.tgt: Likewise.
6081
6082 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6083
6084         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
6085         * osabi.c (gdb_osabi_names): Add "Windows".
6086         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
6087         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
6088         (i386_cygwin_core_osabi_sniffer): New function, extracted from
6089         i386_cygwin_osabi_sniffer.
6090         (_initialize_i386_cygwin_tdep): Register OS ABI
6091         GDB_OSABI_WINDOWS for i386.
6092         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
6093         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
6094         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
6095         for x86-64.
6096         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
6097         when the target matches '*-*-mingw*'.
6098
6099 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6100
6101         * defs.h (enum gdb_osabi): Move to...
6102         * osabi.h (enum gdb_osabi): ... here.
6103         * gdbarch.sh: Include osabi.h in gdbarch.h.
6104         * gdbarch.h: Re-generate.
6105
6106 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6107
6108         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
6109         function.
6110         (_initialize_amd64_windows_tdep): Register osabi sniffer.
6111
6112 2020-03-14  Tom Tromey  <tom@tromey.com>
6113
6114         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
6115         for C++.
6116         (c_type_print_modifier): Likewise.  Add "language" parameter.
6117         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
6118         (c_type_print_base_1): Update.
6119         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
6120         constants.
6121         * type-stack.c (type_stack::insert): Handle tp_atomic and
6122         tp_restrict.
6123         (type_stack::follow_type_instance_flags): Likewise.
6124         (type_stack::follow_types): Likewise.  Merge type-following code.
6125         * c-exp.y (RESTRICT, ATOMIC): New tokens.
6126         (space_identifier, cv_with_space_id)
6127         (const_or_volatile_or_space_identifier_noopt)
6128         (const_or_volatile_or_space_identifier): Remove.
6129         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
6130         rules.
6131         (ptr_operator, typebase): Update.
6132         (enum token_flag) <FLAG_C>: New constant.
6133         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
6134         "_Atomic".
6135         (lex_one_token): Handle FLAG_C.
6136
6137 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6138
6139         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
6140         it to the ptrace call.
6141         * m68k-bsd-nat.c (store_registers): Likewise.
6142
6143 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6144
6145         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
6146         gdb_byte *.
6147         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
6148         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
6149         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
6150
6151 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6152
6153         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
6154         nbsd_nat_target instead of inf_ptrace_target.
6155         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
6156         nbsd_nat_target.
6157
6158 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6159
6160         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
6161         register_t.
6162
6163 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6164
6165         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
6166         it to the ptrace call.
6167         * alpha-bsd-nat.c (store_registers): Likewise.
6168
6169 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6170
6171         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
6172         includes.
6173         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
6174         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
6175         fill_fpregset): Likewise.
6176
6177 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6178
6179         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
6180         nbsd_nat_target instead of inf_ptrace_target.
6181         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
6182         nbsd_nat_target.
6183
6184 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6185
6186         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
6187         register_t.
6188
6189 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6190
6191         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
6192         it to the ptrace call.
6193         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
6194         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
6195         * arm-nbsd-nat.c (store_register): Likewise.
6196         * arm-nbsd-nat.c (store_regs): Likewise.
6197         * arm-nbsd-nat.c (store_fp_register): Likewise.
6198         * arm-nbsd-nat.c (store_fp_regs): Likewise.
6199
6200 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6201
6202         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
6203         nbsd_nat_target instead of inf_ptrace_target.
6204         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
6205         nbsd_nat_target.
6206
6207 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6208
6209         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
6210         it to the ptrace call.
6211         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
6212
6213 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6214
6215         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
6216         it to the ptrace call.
6217         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
6218
6219 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6220
6221         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
6222         gdb_byte *.
6223         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
6224
6225 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6226
6227         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
6228         instead of inf_ptrace_target.
6229         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
6230         nbsd_nat_target.
6231
6232 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6233
6234         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
6235         register_t.
6236
6237 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6238
6239         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
6240         register_t.
6241
6242 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6243
6244         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
6245         register_t.
6246
6247 2020-03-13  Tom Tromey  <tom@tromey.com>
6248
6249         * value.h (val_print): Don't declare.
6250         * valprint.h (val_print_array_elements)
6251         (val_print_scalar_formatted, generic_val_print): Don't declare.
6252         * valprint.c (generic_val_print_array): Take a struct value.
6253         (generic_val_print_ptr, generic_val_print_memberptr)
6254         (generic_val_print_bool, generic_val_print_int)
6255         (generic_val_print_char, generic_val_print_complex)
6256         (generic_val_print): Remove.
6257         (generic_value_print): Update.
6258         (do_val_print): Remove unused parameters.  Don't call
6259         la_val_print.
6260         (val_print): Remove.
6261         (common_val_print): Update.  Don't call value_check_printable.
6262         (val_print_scalar_formatted, val_print_array_elements): Remove.
6263         * rust-lang.c (rust_val_print): Remove.
6264         (rust_language_defn): Update.
6265         * p-valprint.c (pascal_val_print): Remove.
6266         (pascal_value_print_inner): Update.
6267         (pascal_object_print_val_fields, pascal_object_print_val):
6268         Remove.
6269         (pascal_object_print_static_field): Update.
6270         * p-lang.h (pascal_val_print): Don't declare.
6271         * p-lang.c (pascal_language_defn): Update.
6272         * opencl-lang.c (opencl_language_defn): Update.
6273         * objc-lang.c (objc_language_defn): Update.
6274         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
6275         * m2-lang.h (m2_val_print): Don't declare.
6276         * m2-lang.c (m2_language_defn): Update.
6277         * language.h (struct language_defn) <la_val_print>: Remove.
6278         * language.c (unk_lang_value_print_inner): Rename.  Change
6279         argument types.
6280         (unknown_language_defn, auto_language_defn): Update.
6281         * go-valprint.c (go_val_print): Remove.
6282         * go-lang.h (go_val_print): Don't declare.
6283         * go-lang.c (go_language_defn): Update.
6284         * f-valprint.c (f_val_print): Remove.
6285         * f-lang.h (f_value_print): Don't declare.
6286         * f-lang.c (f_language_defn): Update.
6287         * d-valprint.c (d_val_print): Remove.
6288         * d-lang.h (d_value_print): Don't declare.
6289         * d-lang.c (d_language_defn): Update.
6290         * cp-valprint.c (cp_print_value_fields)
6291         (cp_print_value_fields_rtti, cp_print_value): Remove.
6292         (cp_print_static_field): Update.
6293         * c-valprint.c (c_val_print_array, c_val_print_ptr)
6294         (c_val_print_struct, c_val_print_union, c_val_print_int)
6295         (c_val_print_memberptr, c_val_print): Remove.
6296         * c-lang.h (c_val_print_array, cp_print_value_fields)
6297         (cp_print_value_fields_rtti): Don't declare.
6298         * c-lang.c (c_language_defn, cplus_language_defn)
6299         (asm_language_defn, minimal_language_defn): Update.
6300         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
6301         (ada_val_print_enum): Take a struct value.
6302         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
6303         (ada_val_print): Remove.
6304         (ada_value_print_1): Update.
6305         (printable_val_type): Remove.
6306         * ada-lang.h (ada_val_print): Don't declare.
6307         * ada-lang.c (ada_language_defn): Update.
6308
6309 2020-03-13  Tom Tromey  <tom@tromey.com>
6310
6311         * valprint.c (do_val_print): Update.
6312         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
6313         a struct value.
6314         (value_to_value_object_no_release): Declare.
6315         * python/py-value.c (value_to_value_object_no_release): New
6316         function.
6317         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
6318         struct value.
6319         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
6320         function.
6321         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
6322         a struct value.
6323         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
6324         Declare.
6325         (gdbscm_apply_val_pretty_printer): Take a struct value.
6326         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
6327         value.
6328         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
6329         value.
6330         * extension-priv.h (struct extension_language_ops)
6331         <apply_val_pretty_printer>: Take a struct value.
6332         * cp-valprint.c (cp_print_value): Create a struct value.
6333         (cp_print_value): Update.
6334
6335 2020-03-13  Tom Tromey  <tom@tromey.com>
6336
6337         * ada-valprint.c (print_field_values): Call common_val_print.
6338
6339 2020-03-13  Tom Tromey  <tom@tromey.com>
6340
6341         * ada-valprint.c (val_print_packed_array_elements): Remove
6342         bitoffset and val parameters.  Call common_val_print.
6343         (ada_val_print_string): Remove offset, address, and original_value
6344         parameters.
6345         (ada_val_print_array): Update.
6346         (ada_value_print_array): New function.
6347         (ada_value_print_1): Call it.
6348
6349 2020-03-13  Tom Tromey  <tom@tromey.com>
6350
6351         * ada-valprint.c (ada_value_print): Use common_val_print.
6352
6353 2020-03-13  Tom Tromey  <tom@tromey.com>
6354
6355         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
6356
6357 2020-03-13  Tom Tromey  <tom@tromey.com>
6358
6359         * ada-valprint.c (ada_value_print_num): New function.
6360         (ada_value_print_1): Use it.
6361
6362 2020-03-13  Tom Tromey  <tom@tromey.com>
6363
6364         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
6365
6366 2020-03-13  Tom Tromey  <tom@tromey.com>
6367
6368         * ada-valprint.c (ada_value_print_ptr): New function.
6369         (ada_value_print_1): Use it.
6370
6371 2020-03-13  Tom Tromey  <tom@tromey.com>
6372
6373         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
6374         call common_val_print.
6375         (ada_val_print_1): Update.
6376         (ada_value_print_1): New function.
6377         (ada_value_print_inner): Rewrite.
6378
6379 2020-03-13  Tom Tromey  <tom@tromey.com>
6380
6381         * cp-valprint.c (cp_print_value_fields): Update.
6382         (cp_print_value): New function.
6383
6384 2020-03-13  Tom Tromey  <tom@tromey.com>
6385
6386         * m2-valprint.c (m2_value_print_inner): Use
6387         cp_print_value_fields.
6388         * cp-valprint.c (cp_print_value_fields): New function.
6389         * c-valprint.c (c_value_print_struct): New function.
6390         (c_value_print_inner): Use c_value_print_struct.
6391         * c-lang.h (cp_print_value_fields): Declare.
6392
6393 2020-03-13  Tom Tromey  <tom@tromey.com>
6394
6395         * c-valprint.c (c_value_print_array): New function.
6396         (c_value_print_inner): Use it.
6397
6398 2020-03-13  Tom Tromey  <tom@tromey.com>
6399
6400         * c-valprint.c (c_value_print_memberptr): New function.
6401         (c_value_print_inner): Use it.
6402
6403 2020-03-13  Tom Tromey  <tom@tromey.com>
6404
6405         * c-valprint.c (c_value_print_int): New function.
6406         (c_value_print_inner): Use it.
6407
6408 2020-03-13  Tom Tromey  <tom@tromey.com>
6409
6410         * c-valprint.c (c_value_print_ptr): New function.
6411         (c_value_print_inner): Use it.
6412
6413 2020-03-13  Tom Tromey  <tom@tromey.com>
6414
6415         * c-valprint.c (c_value_print_inner): Rewrite.
6416
6417 2020-03-13  Tom Tromey  <tom@tromey.com>
6418
6419         * valprint.c (generic_value_print_complex): New function.
6420         (generic_value_print): Use it.
6421
6422 2020-03-13  Tom Tromey  <tom@tromey.com>
6423
6424         * valprint.c (generic_val_print_float): Don't call
6425         val_print_scalar_formatted.
6426         (generic_val_print, generic_value_print): Update.
6427
6428 2020-03-13  Tom Tromey  <tom@tromey.com>
6429
6430         * valprint.c (generic_value_print_char): New function
6431         (generic_value_print): Use it.
6432
6433 2020-03-13  Tom Tromey  <tom@tromey.com>
6434
6435         * valprint.c (generic_value_print_int): New function.
6436         (generic_value_print): Use it.
6437
6438 2020-03-13  Tom Tromey  <tom@tromey.com>
6439
6440         * valprint.c (generic_value_print_bool): New function.
6441         (generic_value_print): Use it.
6442
6443 2020-03-13  Tom Tromey  <tom@tromey.com>
6444
6445         * valprint.c (generic_val_print_func): Simplify.
6446         (generic_val_print, generic_value_print): Update.
6447
6448 2020-03-13  Tom Tromey  <tom@tromey.com>
6449
6450         * valprint.c (generic_val_print_flags): Remove.
6451         (generic_val_print, generic_value_print): Update.
6452         (val_print_type_code_flags): Add original_value parameter.
6453
6454 2020-03-13  Tom Tromey  <tom@tromey.com>
6455
6456         * valprint.c (generic_val_print): Update.
6457         (generic_value_print): Update.
6458         * valprint.c (generic_val_print_enum): Don't call
6459         val_print_scalar_formatted.
6460
6461 2020-03-13  Tom Tromey  <tom@tromey.com>
6462
6463         * valprint.c (generic_value_print): Call generic_value_print_ptr.
6464         * valprint.c (generic_value_print_ptr): New function.
6465
6466 2020-03-13  Tom Tromey  <tom@tromey.com>
6467
6468         * valprint.c (generic_value_print): Rewrite.
6469
6470 2020-03-13  Tom Tromey  <tom@tromey.com>
6471
6472         * p-valprint.c (pascal_object_print_value_fields)
6473         (pascal_object_print_value): New functions.
6474
6475 2020-03-13  Tom Tromey  <tom@tromey.com>
6476
6477         * p-valprint.c (pascal_value_print_inner): Rewrite.
6478
6479 2020-03-13  Tom Tromey  <tom@tromey.com>
6480
6481         * f-valprint.c (f_value_print_innner): Rewrite.
6482
6483 2020-03-13  Tom Tromey  <tom@tromey.com>
6484
6485         * m2-valprint.c (m2_print_unbounded_array): New overload.
6486         (m2_print_unbounded_array): Update.
6487         (m2_print_array_contents): Take a struct value.
6488         (m2_value_print_inner): Rewrite.
6489
6490 2020-03-13  Tom Tromey  <tom@tromey.com>
6491
6492         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
6493         (d_value_print_inner): New function.
6494         * d-lang.h (d_value_print_inner): Declare.
6495         * d-lang.c (d_language_defn): Use d_value_print_inner.
6496
6497 2020-03-13  Tom Tromey  <tom@tromey.com>
6498
6499         * go-valprint.c (go_value_print_inner): New function.
6500         * go-lang.h (go_value_print_inner): Declare.
6501         * go-lang.c (go_language_defn): Use go_value_print_inner.
6502
6503 2020-03-13  Tom Tromey  <tom@tromey.com>
6504
6505         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
6506         API.
6507         (rust_val_print): Rewrite.
6508         (rust_value_print_inner): New function, from rust_val_print.
6509         (rust_language_defn): Use rust_value_print_inner.
6510
6511 2020-03-13  Tom Tromey  <tom@tromey.com>
6512
6513         * ada-valprint.c (ada_value_print_inner): New function.
6514         * ada-lang.h (ada_value_print_inner): Declare.
6515         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
6516
6517 2020-03-13  Tom Tromey  <tom@tromey.com>
6518
6519         * f-valprint.c (f_value_print_innner): New function.
6520         * f-lang.h (f_value_print_innner): Declare.
6521         * f-lang.c (f_language_defn): Use f_value_print_innner.
6522
6523 2020-03-13  Tom Tromey  <tom@tromey.com>
6524
6525         * p-valprint.c (pascal_value_print_inner): New function.
6526         * p-lang.h (pascal_value_print_inner): Declare.
6527         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
6528
6529 2020-03-13  Tom Tromey  <tom@tromey.com>
6530
6531         * m2-valprint.c (m2_value_print_inner): New function.
6532         * m2-lang.h (m2_value_print_inner): Declare.
6533         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
6534
6535 2020-03-13  Tom Tromey  <tom@tromey.com>
6536
6537         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
6538         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
6539         * c-valprint.c (c_value_print_inner): New function.
6540         * c-lang.h (c_value_print_inner): Declare.
6541         * c-lang.c (c_language_defn, cplus_language_defn)
6542         (asm_language_defn, minimal_language_defn): Use
6543         c_value_print_inner.
6544
6545 2020-03-13  Tom Tromey  <tom@tromey.com>
6546
6547         * p-valprint.c (pascal_object_print_value_fields): Now static.
6548         * p-lang.h (pascal_object_print_value_fields): Don't declare.
6549
6550 2020-03-13  Tom Tromey  <tom@tromey.com>
6551
6552         * c-valprint.c (c_val_print_array): Simplify.
6553
6554 2020-03-13  Tom Tromey  <tom@tromey.com>
6555
6556         * valprint.c (value_print_array_elements): New function.
6557         * valprint.h (value_print_array_elements): Declare.
6558
6559 2020-03-13  Tom Tromey  <tom@tromey.com>
6560
6561         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
6562         * mips-tdep.c (mips_print_register): Use
6563         value_print_scalar_formatted.
6564
6565 2020-03-13  Tom Tromey  <tom@tromey.com>
6566
6567         * valprint.h (value_print_scalar_formatted): Declare.
6568         * valprint.c (value_print_scalar_formatted): New function.
6569
6570 2020-03-13  Tom Tromey  <tom@tromey.com>
6571
6572         * valprint.h (generic_value_print): Declare.
6573         * valprint.c (generic_value_print): New function.
6574
6575 2020-03-13  Tom Tromey  <tom@tromey.com>
6576
6577         * valprint.c (do_val_print): Call la_value_print_inner, if
6578         available.
6579         * rust-lang.c (rust_language_defn): Update.
6580         * p-lang.c (pascal_language_defn): Update.
6581         * opencl-lang.c (opencl_language_defn): Update.
6582         * objc-lang.c (objc_language_defn): Update.
6583         * m2-lang.c (m2_language_defn): Update.
6584         * language.h (struct language_defn) <la_value_print_inner>: New
6585         member.
6586         * language.c (unknown_language_defn, auto_language_defn): Update.
6587         * go-lang.c (go_language_defn): Update.
6588         * f-lang.c (f_language_defn): Update.
6589         * d-lang.c (d_language_defn): Update.
6590         * c-lang.c (c_language_defn, cplus_language_defn)
6591         (asm_language_defn, minimal_language_defn): Update.
6592         * ada-lang.c (ada_language_defn): Update.
6593
6594 2020-03-13  Tom Tromey  <tom@tromey.com>
6595
6596         * c-valprint.c (c_value_print): Use common_val_print.
6597
6598 2020-03-13  Tom Tromey  <tom@tromey.com>
6599
6600         * cp-valprint.c (cp_print_static_field): Use common_val_print.
6601
6602 2020-03-13  Tom Tromey  <tom@tromey.com>
6603
6604         * f-valprint.c (f77_print_array_1, f_val_print): Use
6605         common_val_print.
6606
6607 2020-03-13  Tom Tromey  <tom@tromey.com>
6608
6609         * riscv-tdep.c (riscv_print_one_register_info): Use
6610         common_val_print.
6611
6612 2020-03-13  Tom Tromey  <tom@tromey.com>
6613
6614         * mi/mi-main.c (output_register): Use common_val_print.
6615
6616 2020-03-13  Tom Tromey  <tom@tromey.com>
6617
6618         * infcmd.c (default_print_one_register_info): Use
6619         common_val_print.
6620
6621 2020-03-13  Tom Tromey  <tom@tromey.com>
6622
6623         * valprint.h (common_val_print_checked): Declare.
6624         * valprint.c (common_val_print_checked): New function.
6625         * stack.c (print_frame_arg): Use common_val_print_checked.
6626
6627 2020-03-13  Tom Tromey  <tom@tromey.com>
6628
6629         * valprint.c (do_val_print): New function, from val_print.
6630         (val_print): Use do_val_print.
6631         (common_val_print): Use do_val_print.
6632
6633 2020-03-13  Tom Tromey  <tom@tromey.com>
6634
6635         * valprint.c (value_print): Use scoped_value_mark.
6636
6637 2020-03-13  Tom de Vries  <tdevries@suse.de>
6638
6639         PR symtab/25646
6640         * psymtab.c (partial_symtab::partial_symtab): Don't set
6641         globals_offset and statics_offset.  Push element onto
6642         current_global_psymbols and current_static_psymbols stacks.
6643         (concat): New function.
6644         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
6645         element from current_global_psymbols and current_static_psymbols
6646         stacks.  Concat popped elements to global_psymbols and
6647         static_symbols.
6648         (add_psymbol_to_list): Use current_global_psymbols and
6649         current_static_psymbols stacks.
6650         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
6651         current_static_psymbols fields.
6652
6653 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
6654
6655         * corelow.c (sniff_core_bfd): Remove.
6656         (class core_target) <m_core_vec>: Remove.
6657         (core_target::core_target): Update.
6658         (core_file_fns): Remove.
6659         (deprecated_add_core_fns): Remove.
6660         (default_core_sniffer): Remove.
6661         (sniff_core_bfd): Remove.
6662         (default_check_format): Remove.
6663         (gdb_check_format): Remove.
6664         (core_target_open): Update.
6665         (core_target::get_core_register_section): Update.
6666         (get_core_registers_cb): Update.
6667         (core_target::fetch_registers): Update.
6668         * gdbcore.h (struct core_fns): Remove.
6669         (deprecated_add_core_fns): Remove.
6670         (default_core_sniffer): Remove.
6671         (default_check_format): Remove.
6672
6673 2020-03-12  Tom Tromey  <tom@tromey.com>
6674
6675         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
6676         CORE_ADDR.
6677         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
6678
6679 2020-03-12  Tom Tromey  <tom@tromey.com>
6680
6681         * remote.c (remote_target::download_tracepoint)
6682         (remote_target::enable_tracepoint)
6683         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
6684         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
6685         sprintf_vma.
6686
6687 2020-03-12  Tom Tromey  <tom@tromey.com>
6688
6689         * symfile-mem.c: Update CORE_ADDR size assert.
6690
6691 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6692
6693         * selftest.m4: Move to gdbsupport/.
6694         * acinclude.m4: Update path to selftest.m4.
6695
6696 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6697
6698         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
6699         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
6700         gdbarch-selfselftests.c and selftest-arch.c.
6701         (SUBDIR_UNITTESTS_OBS): Rename to...
6702         (SELFTESTS_OBS): ... this.
6703         (COMMON_SFILES): Remove disasm-selftests.c and
6704         gdbarch-selftests.c.
6705         * configure.ac: Don't add selftest-arch.{c,o} to
6706         CONFIG_{SRCS,OBS}.
6707         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
6708         preprocessor conditions.
6709
6710 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6711
6712         * configure.ac: Don't source bfd/development.sh.
6713         * selftest.m4: Modify comment.
6714         * configure: Re-generate.
6715
6716 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6717
6718         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
6719         not "true" or "false".
6720         * configure: Re-generate.
6721
6722 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
6723
6724         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
6725         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
6726         renamed to arm_nbsd_supply_gregset.
6727         (fetch_register): Update to call arm_nbsd_supply_gregset.
6728         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
6729         (arm_netbsd_nat_target::fetch_registers): Update.
6730         (fetch_elfcore_registers): Removed.
6731         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
6732         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
6733         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
6734         not require NetBSD system headers.
6735         (arm_nbsd_regset): New struct.
6736         (arm_nbsd_iterate_over_regset_sections): New function.
6737         (arm_netbsd_init_abi_common): Updated to call
6738         set_gdbarch_iterate_over_regset_sections.
6739         * arm-nbsd-tdep.h: New file.
6740
6741 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
6742
6743         * symtab.c (find_pc_sect_line): Add check which prevents infinite
6744         recursion.
6745
6746 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
6747
6748         * configure: Re-generate.
6749
6750 2020-03-11  Tom Tromey  <tromey@adacore.com>
6751
6752         * ada-typeprint.c (print_choices): Fix comment.
6753
6754 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6755
6756         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
6757         previous item in the list, when the list has no items.
6758
6759 2020-03-11  Tom de Vries  <tdevries@suse.de>
6760
6761         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
6762         PROP_LOCLIST handling code.
6763
6764 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6765
6766         * buildsym-legacy.c (record_line): Pass extra parameter to
6767         record_line.
6768         * buildsym.c (buildsym_compunit::record_line): Take an extra
6769         parameter, reduce duplication in the line table, and record the
6770         is_stmt flag in the line table.
6771         * buildsym.h (buildsym_compunit::record_line): Add extra
6772         parameter.
6773         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
6774         non-statement lines.
6775         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
6776         this to the symtab builder.
6777         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
6778         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
6779         through to dwarf_record_line_1.
6780         * infrun.c (process_event_stop_test): When stepping, don't stop at
6781         a non-statement instruction, and only refresh the step info when
6782         we land in the middle of a line's range.  Also add an extra
6783         comment.
6784         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
6785         field.
6786         * record-btrace.c (btrace_find_line_range): Only record lines
6787         marked as is-statement.
6788         * stack.c (frame_show_address): Show the frame address if we are
6789         in a non-statement sal.
6790         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
6791         (maintenance_print_one_line_table): Print a header for the is_stmt
6792         column, and include is_stmt information in the output.
6793         * symtab.c (find_pc_sect_line): Find lines marked as statements in
6794         preference to non-statements.
6795         (find_pcs_for_symtab_line): Prefer is-statement entries.
6796         (find_line_common): Likewise.
6797         * symtab.h (struct linetable_entry): Add is_stmt field.
6798         (struct symtab_and_line): Likewise.
6799         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
6800         arranging the line table.
6801
6802 2020-03-07  Tom de Vries  <tdevries@suse.de>
6803
6804         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
6805         DIE.
6806
6807 2020-03-07  Tom Tromey  <tom@tromey.com>
6808
6809         * valops.c (value_literal_complex): Remove obsolete comment.
6810         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
6811         comment.
6812
6813 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
6814
6815         * infrun.h: Forward-declare thread_info.
6816         (set_step_info): Add thread_info parameter, add doc.
6817         * infrun.c (set_step_info): Add thread_info parameter, move doc
6818         to header.
6819         * infrun.c (process_event_stop_test): Pass thread to
6820         set_step_info call.
6821         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
6822         set_step_info.
6823         (prepare_one_step): Add thread_info parameter, pass it to
6824         set_step_frame and prepare_one_step (recursive) call.
6825         (step_1): Pass thread to prepare_one_step call.
6826         (step_command_fsm::should_stop): Pass thread to
6827         prepare_one_step.
6828         (until_next_fsm): Pass thread to set_step_frame call.
6829         (finish_command): Pass thread to set_step_info call.
6830
6831 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
6832
6833         * windows-tdep.c (windows_solib_create_inferior_hook):
6834         Check if inferior is running.
6835
6836 2020-03-06  Tom de Vries  <tdevries@suse.de>
6837
6838         * NEWS: Fix "the the".
6839         * ctfread.c: Same.
6840
6841 2020-03-06  Tom de Vries  <tdevries@suse.de>
6842
6843         * psymtab.c (psymtab_to_symtab): Don't print "done.".
6844
6845 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6846
6847         * .dir-locals.el: Add a comment referencing the other copies of
6848         this file.
6849
6850 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
6851
6852         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
6853         psargs.
6854
6855 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6856
6857         * .gitattributes: New file.
6858
6859 2020-03-04  Tom Tromey  <tom@tromey.com>
6860
6861         * symmisc.c (print_symbol_bcache_statistics)
6862         (print_objfile_statistics): Update.
6863         * symfile.c (allocate_symtab): Use intern.
6864         * psymtab.c (partial_symtab::partial_symtab): Use intern.
6865         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6866         macro_cache>: Remove.
6867         <string_cache>: New member.
6868         (struct objfile) <intern>: New methods.
6869         * elfread.c (elf_symtab_read): Use intern.
6870         * dwarf2/read.c (fixup_go_packaging): Intern package name.
6871         (dwarf2_compute_name, dwarf2_physname)
6872         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
6873         names.
6874         (guess_partial_die_structure_name): Update.
6875         (partial_die_info::fixup): Intern name.
6876         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
6877         name.
6878         (dwarf2_name): Intern name.  Update.
6879         * buildsym.c (buildsym_compunit::get_macro_table): Use
6880         string_cache.
6881
6882 2020-03-04  Tom Tromey  <tom@tromey.com>
6883
6884         * jit.c (bfd_open_from_target_memory): Make "target" const.
6885         * corefile.c (gnutarget): Now const.
6886         * gdbcore.h (gnutarget): Now const.
6887
6888 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
6889
6890         * NEWS: Mention support for WOW64 processes.
6891         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
6892         (amd64_windows_segment_register_p): Remove static.
6893         (_initialize_amd64_windows_nat): Update.
6894         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
6895         * i386-windows-nat.c (context_offset): Update.
6896         (i386_mappings): Rename and remove static.
6897         (i386_windows_segment_register_p): Remove static.
6898         (_initialize_i386_windows_nat): Update.
6899         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
6900         (STATUS_WX86_SINGLE_STEP): New macro.
6901         (EnumProcessModulesEx): New macro.
6902         (Wow64SuspendThread): New macro.
6903         (Wow64GetThreadContext): New macro.
6904         (Wow64SetThreadContext): New macro.
6905         (Wow64GetThreadSelectorEntry): New macro.
6906         (windows_set_context_register_offsets): Add static.
6907         (windows_set_segment_register_p): Likewise.
6908         (windows_add_thread): Adapt for WOW64 processes.
6909         (windows_fetch_one_register): Likewise.
6910         (windows_nat_target::fetch_registers): Likewise.
6911         (windows_store_one_register): Likewise.
6912         (display_selector): Likewise.
6913         (display_selectors): Likewise.
6914         (handle_exception): Likewise.
6915         (windows_continue): Likewise.
6916         (windows_nat_target::resume): Likewise.
6917         (windows_add_all_dlls): Likewise.
6918         (do_initial_windows_stuff): Likewise.
6919         (windows_nat_target::attach): Likewise.
6920         (windows_get_exec_module_filename): Likewise.
6921         (windows_nat_target::create_inferior): Likewise.
6922         (windows_xfer_siginfo): Likewise.
6923         (_initialize_loadable): Initialize Wow64SuspendThread,
6924         Wow64GetThreadContext, Wow64SetThreadContext,
6925         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
6926         * windows-nat.h (windows_set_context_register_offsets):
6927         Remove declaration.
6928         (windows_set_segment_register_p): Likewise.
6929         (i386_windows_segment_register_p): Add declaration.
6930         (amd64_windows_segment_register_p): Likewise.
6931
6932 2020-03-04  Luis Machado  <luis.machado@linaro.org>
6933
6934         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
6935         in "info registers" for AArch64/ARM.
6936
6937         The change caused "info registers" to not print GPR's.
6938
6939         gdb/ChangeLog:
6940
6941         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
6942
6943         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
6944         when reg->group is empty and reggroup is not.
6945
6946 2020-03-03  Tom Tromey  <tromey@adacore.com>
6947
6948         * dwarf2/frame.c (struct dwarf2_frame_cache)
6949         <checked_tailcall_bottom, entry_cfa_sp_offset,
6950         entry_cfa_sp_offset_p>: Remove members.
6951         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
6952         (dwarf2_frame_prev_register): Don't call
6953         dwarf2_tailcall_sniffer_first.
6954         (dwarf2_append_unwinders): Don't append tailcall unwinder.
6955         * frame-unwind.c (add_unwinder): New fuction.
6956         (frame_unwind_init): Use it.  Add tailcall unwinder.
6957
6958 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6959             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
6960
6961         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
6962         value should be printed as true.
6963
6964 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
6965
6966         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
6967         (windows_init_abi): Set and use windows_so_ops.
6968
6969 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
6970
6971         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
6972         when verifying if dealing with a convenience variable.
6973
6974 2020-03-03  Luis Machado  <luis.machado@linaro.org>
6975
6976         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
6977
6978 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
6979
6980         * infrun.c (gdbarch_supports_displaced_stepping): New.
6981         (use_displaced_stepping): Break up conditions in smaller pieces.
6982         Use gdbarch_supports_displaced_stepping.
6983         (displaced_step_prepare_throw): Use
6984         gdbarch_supports_displaced_stepping.
6985
6986 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6987
6988         * NEWS: Mention new behaviour of the history filename.
6989         * top.c (write_history_p): Add comment.
6990         (show_write_history_p): Add header comment, give a different
6991         message when history writing is on, but the history filename is
6992         empty.
6993         (history_filename): Add comment.
6994         (history_filename_empty): New function.
6995         (show_history_filename): Add header comment, give a different
6996         message when the filename is empty.
6997         (init_history): Compare history_filename against nullptr, and only
6998         read history if the filename is not empty.
6999         (set_history_filename): Add header comment, and only make
7000         non-empty filenames absolute.
7001         (init_main): Make the filename argument to 'set history filename'
7002         optional.
7003
7004 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
7005
7006         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
7007         (arm_supply_vfpregset): ...this, and update to use VFP registers.
7008         (fetch_fp_register): Update.
7009         (fetch_fp_regs): Update.
7010         (store_fp_register): Update.
7011         (store_fp_regs): Update.
7012         (arm_netbsd_nat_target::read_description): New function.
7013         (fetch_elfcore_registers): Update.
7014
7015 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7016
7017         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
7018         general_thread if the stop reply is missing a thread-id.
7019         (remote_target::process_stop_reply): Use the first non-exited
7020         thread if the target didn't pass a thread-id.
7021         * infrun.c (do_target_wait): Move call to
7022         switch_to_inferior_no_thread to ....
7023         (do_target_wait_1): ... here.
7024
7025 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
7026
7027         * debuginfod-support.c: Include defs.h first.
7028
7029 2020-02-28  Tom de Vries  <tdevries@suse.de>
7030
7031         * symfile.c (set_initial_language): Use default language for lookup.
7032
7033 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
7034
7035         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
7036         reader variable, pass `this` to read_cutu_die_from_dwo.
7037
7038 2020-02-27  Aaron Merey  <amerey@redhat.com>
7039
7040         * source.c (open_source_file): Check for nullptr when computing
7041         srcpath.
7042
7043 2020-02-27  Tom Tromey  <tromey@adacore.com>
7044
7045         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
7046         member.
7047         (dwarf2_add_field): Don't update nfields.
7048         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
7049
7050 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7051
7052         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
7053         abs.
7054
7055 2020-02-26  Tom Tromey  <tom@tromey.com>
7056
7057         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
7058         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
7059         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
7060         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
7061         per_cu_data.
7062
7063 2020-02-26  Tom Tromey  <tom@tromey.com>
7064
7065         * dwarf2/index-write.c (psym_index_map): Change type.
7066         (add_address_entry_worker, write_one_signatured_type)
7067         (recursively_count_psymbols, recursively_write_psymbols)
7068         (class debug_names, psyms_seen_size, write_gdbindex)
7069         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
7070
7071 2020-02-26  Aaron Merey  <amerey@redhat.com>
7072
7073         * Makefile.in: Handle optional debuginfod support.
7074         * NEWS: Update.
7075         * README: Add --with-debuginfod summary.
7076         * config.in: Regenerate.
7077         * configure: Regenerate.
7078         * configure.ac: Handle optional debuginfod support.
7079         * debuginfod-support.c: debuginfod helper functions.
7080         * debuginfod-support.h: Ditto.
7081         * doc/gdb.texinfo: Add --with-debuginfod to configure options
7082         summary.
7083         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
7084         when a dwz file cannot be found.
7085         * elfread.c (elf_symfile_read): Query debuginfod servers when a
7086         debuginfo file cannot be found.
7087         * source.c (open_source_file): Query debuginfod servers when a
7088         source file cannot be found.
7089         * top.c (print_gdb_configuration): Include
7090         --{with,without}-debuginfod in the output.
7091
7092 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
7093
7094         * thread.c (thr_try_catch_cmd): Print thread name.
7095
7096 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
7097
7098         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
7099         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
7100         dwarf2_fetch_die_type_sect_off): Move to...
7101         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
7102         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
7103         dwarf2_fetch_die_type_sect_off): ... here.
7104         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
7105         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
7106         dwarf2_fetch_die_type_sect_off): Move doc to header file.
7107
7108 2020-02-26  Tom de Vries  <tdevries@suse.de>
7109
7110         PR gdb/25603
7111         * symfile.c (set_initial_language): Exit-early if
7112         language_mode == language_mode_manual.
7113
7114 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
7115
7116         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
7117         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
7118         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
7119
7120 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
7121
7122         * gdbtypes.c (create_array_type_with_stride): Handle negative
7123         array strides.
7124         * valarith.c (value_subscripted_rvalue): Likewise.
7125
7126 2020-02-25  Luis Machado  <luis.machado@linaro.org>
7127
7128         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
7129
7130 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
7131
7132         * loc.h (dwarf2_get_die_type): Move to...
7133         * read.h (dwarf2_get_die_type): ... here.
7134         * read.c (dwarf2_get_die_type): Move doc to header.
7135
7136 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
7137
7138         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
7139         'gnulib/Makefile.in' to the list.
7140
7141 2020-02-24  Tom Tromey  <tom@tromey.com>
7142
7143         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
7144         Remove.
7145         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
7146         XOBNEWVEC.
7147
7148 2020-02-24  Tom Tromey  <tom@tromey.com>
7149
7150         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
7151         New method.
7152         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
7153         (dw2_do_instantiate_symtab, dw2_get_file_names)
7154         (build_type_psymtab_dependencies, load_full_type_unit): Update.
7155
7156 2020-02-24  Tom Tromey  <tom@tromey.com>
7157
7158         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
7159         make_scoped_restore.
7160         (dwarf2_psymtab::read_symtab): Don't clear
7161         reading_partial_symbols.
7162
7163 2020-02-24  Tom de Vries  <tdevries@suse.de>
7164
7165         PR gdb/25592
7166         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
7167
7168 2020-02-24  Tom de Vries  <tdevries@suse.de>
7169
7170         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
7171         commands layout next/prev/regs.
7172
7173 2020-02-22  Tom Tromey  <tom@tromey.com>
7174
7175         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
7176         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
7177
7178 2020-02-22  Tom Tromey  <tom@tromey.com>
7179
7180         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
7181
7182 2020-02-22  Tom Tromey  <tom@tromey.com>
7183
7184         * tui/tui-win.c (_initialize_tui_win): Add usage text.
7185         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
7186         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
7187         * tui/tui.c (_initialize_tui): Add usage text.
7188
7189 2020-02-22  Tom Tromey  <tom@tromey.com>
7190
7191         * tui/tui-win.c (tui_set_focus_command)
7192         (tui_set_win_height_command): Use error_no_arg.
7193         (_initialize_tui_win): Update help text.
7194         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
7195
7196 2020-02-22  Tom Tromey  <tom@tromey.com>
7197
7198         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
7199         * tui/tui-disasm.h (struct tui_disasm_window)
7200         <display_start_addr>: Declare.
7201         * tui/tui-source.h (struct tui_source_window)
7202         <display_start_addr>: Declare.
7203         * tui/tui-winsource.h (struct tui_source_window_base)
7204         <show_source_line, display_start_addr>: New methods.
7205         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
7206         Rename and move to protected section.
7207         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
7208         (tui_source_window_base::do_erase_source_content): Update.
7209         (tui_source_window_base::show_source_line): Now a method.
7210         (tui_source_window_base::show_source_content)
7211         (tui_source_window_base::tui_source_window_base)
7212         (tui_source_window_base::rerender)
7213         (tui_source_window_base::refill)
7214         (tui_source_window_base::do_scroll_horizontal)
7215         (tui_source_window_base::set_is_exec_point_at)
7216         (tui_source_window_base::update_breakpoint_info)
7217         (tui_source_window_base::update_exec_info): Update.
7218         * tui/tui-source.c (tui_source_window::set_contents)
7219         (tui_source_window::showing_source_p)
7220         (tui_source_window::do_scroll_vertical)
7221         (tui_source_window::location_matches_p)
7222         (tui_source_window::line_is_displayed): Update.
7223         (tui_source_window::display_start_addr): New method.
7224         * tui/tui-disasm.c (tui_disasm_window::set_contents)
7225         (tui_disasm_window::do_scroll_vertical)
7226         (tui_disasm_window::location_matches_p): Update.
7227         (tui_disasm_window::display_start_addr): New method.
7228
7229 2020-02-22  Tom Tromey  <tom@tromey.com>
7230
7231         * NEWS: Add entry for gdb.register_window_type.
7232         * tui/tui-layout.h (window_factory): New typedef.
7233         (tui_register_window): Declare.
7234         * tui/tui-layout.c (saved_tui_windows): New global.
7235         (tui_apply_current_layout): Use it.
7236         (tui_register_window): New function.
7237         * python/python.c (do_start_initialization): Call
7238         gdbpy_initialize_tui.
7239         (python_GdbMethods): Add "register_window_type" function.
7240         * python/python-internal.h (gdbpy_register_tui_window)
7241         (gdbpy_initialize_tui): Declare.
7242         * python/py-tui.c: New file.
7243         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
7244
7245 2020-02-22  Tom Tromey  <tom@tromey.com>
7246
7247         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
7248
7249 2020-02-22  Tom Tromey  <tom@tromey.com>
7250
7251         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
7252         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
7253         * tui/tui-data.c (tui_set_win_with_focus): Remove.
7254         (tui_set_win_focus_to): Move from tui-win.c.
7255
7256 2020-02-22  Tom Tromey  <tom@tromey.com>
7257
7258         * tui/tui-layout.c (make_standard_window, get_locator_window): New
7259         functions.
7260         (known_window_types): New global.
7261         (tui_get_window_by_name): Reimplement.
7262         (initialize_known_windows): New function.
7263         (validate_window_name): Rewrite.
7264         (_initialize_tui_layout): Call initialize_known_windows.
7265
7266 2020-02-22  Tom Tromey  <tom@tromey.com>
7267
7268         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
7269         Remove constants.
7270         * tui/tui-winsource.h (struct tui_source_window_base)
7271         <tui_source_window_base>: Remove parameter.
7272         * tui/tui-winsource.c
7273         (tui_source_window_base::tui_source_window_base): Remove
7274         parameter.
7275         (tui_source_window_base::refill): Update.
7276         * tui/tui-stack.h (struct tui_locator_window)
7277         <tui_locator_window>: Update.
7278         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
7279         Default the constructor.
7280         * tui/tui-regs.h (struct tui_data_item_window)
7281         <tui_data_item_window>: Default the constructor.
7282         (struct tui_data_window) <tui_data_window>: Likewise.
7283         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
7284         Default the constructor.
7285         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
7286         Default the constructor.
7287         <type>: Remove.
7288         (struct tui_win_info) <tui_win_info>: Default the constructor.
7289         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
7290         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
7291         Default the constructor.
7292
7293 2020-02-22  Tom Tromey  <tom@tromey.com>
7294
7295         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
7296         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
7297         * tui/tui-win.c (tui_resize_all): Don't call
7298         tui_delete_invisible_windows.
7299         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
7300         done.
7301         (tui_set_layout): Update.
7302         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
7303         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
7304         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
7305
7306 2020-02-22  Tom Tromey  <tom@tromey.com>
7307
7308         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
7309         correctly.
7310
7311 2020-02-22  Tom Tromey  <tom@tromey.com>
7312
7313         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
7314
7315 2020-02-22  Tom Tromey  <tom@tromey.com>
7316
7317         * tui/tui-winsource.h (struct tui_source_window_iterator)
7318         <inner_iterator>: New etytypedef.
7319         <tui_source_window_iterator>: Take "end" parameter.
7320         <tui_source_window_iterator>: Take iterator.
7321         <operator*, advance>: Update.
7322         <m_iter>: Change type.
7323         <m_end>: New field.
7324         (struct tui_source_windows) <begin, end>: Update.
7325         * tui/tui-layout.c (tui_windows): New global.
7326         (tui_apply_current_layout): Clear tui_windows.
7327         (tui_layout_window::apply): Update tui_windows.
7328         * tui/tui-data.h (tui_windows): Declare.
7329         (all_tui_windows): Now inline function.
7330         (class tui_window_iterator, struct all_tui_windows): Remove.
7331
7332 2020-02-22  Tom Tromey  <tom@tromey.com>
7333
7334         PR tui/17850:
7335         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
7336         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
7337         "height" argument.
7338         (class tui_layout_window) <get_sizes>: Likewise.
7339         (class tui_layout_split) <tui_layout_split>: Add "vertical"
7340         argument.
7341         <get_sizes>: Add "height" argument.
7342         <m_vertical>: New field.
7343         * tui/tui-layout.c (tui_layout_split::clone): Update.
7344         (tui_layout_split::get_sizes): Add "height" argument.
7345         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
7346         (tui_new_layout_command): Parse "-horizontal".
7347         (_initialize_tui_layout): Update help string.
7348         (tui_layout_split::specification): Add "-horizontal" when needed.
7349         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
7350         argument.
7351         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
7352         New methods.
7353
7354 2020-02-22  Tom Tromey  <tom@tromey.com>
7355
7356         * tui/tui-layout.h (enum tui_adjust_result): New.
7357         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
7358         (class tui_layout_window) <adjust_size>: Return
7359         tui_adjust_result.  Rewrite.
7360         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
7361         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
7362
7363 2020-02-22  Tom Tromey  <tom@tromey.com>
7364
7365         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
7366         parameter and return types.
7367         (class tui_layout_base) <specification>: Add "depth".
7368         (class tui_layout_window) <specification>: Add "depth".
7369         (class tui_layout_split) <specification>: Add "depth".
7370         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
7371         and return types.
7372         (tui_new_layout_command): Parse sub-layouts.
7373         (_initialize_tui_layout): Update help string.
7374         (tui_layout_window::specification): Add "depth".
7375         (add_layout_command): Update.
7376
7377 2020-02-22  Tom Tromey  <tom@tromey.com>
7378
7379         * NEWS: Add "tui new-layout" item.
7380         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
7381         Add new-layout command to help text.
7382         (validate_window_name): New function.
7383         (tui_new_layout_command): New function.
7384         (_initialize_tui_layout): Register "new-layout".
7385         (tui_layout_window::specification): New method.
7386         (tui_layout_window::specification): New method.
7387         * tui/tui-layout.h (class tui_layout_base) <specification>: New
7388         method.
7389         (class tui_layout_window) <specification>: New method.
7390         (class tui_layout_split) <specification>: New method.
7391
7392 2020-02-22  Tom Tromey  <tom@tromey.com>
7393
7394         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
7395         * tui/tui-win.c (window_name_completer): Update comment.
7396         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
7397         Declare method.
7398         (class tui_layout_window) <replace_window>: Likewise.
7399         (class tui_layout_split) <replace_window>: Likewise.
7400         (tui_set_layout): Don't declare.
7401         (tui_set_initial_layout): Declare function.
7402         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
7403         (asm_regs_layout): New globals.
7404         (tui_current_layout, show_layout): Remove.
7405         (tui_set_layout, tui_add_win_to_layout): Rewrite.
7406         (find_layout, tui_apply_layout): New function.
7407         (layout_completer): Remove.
7408         (tui_next_layout): Reimplement.
7409         (tui_next_layout_command): New function.
7410         (tui_set_initial_layout, tui_prev_layout_command): New functions.
7411         (tui_regs_layout): Reimplement.
7412         (tui_regs_layout_command): New function.
7413         (extract_display_start_addr): Rewrite.
7414         (next_layout, prev_layout): Remove.
7415         (tui_layout_window::replace_window): New method.
7416         (tui_layout_split::replace_window): New method.
7417         (destroy_layout): New function.
7418         (layout_list): New global.
7419         (add_layout_command): New function.
7420         (initialize_layouts): Update.
7421         (tui_layout_command): New function.
7422         (_initialize_tui_layout): Install "layout" commands.
7423         * tui/tui-data.h (enum tui_layout_type): Remove.
7424         (tui_current_layout): Don't declare.
7425
7426 2020-02-22  Tom Tromey  <tom@tromey.com>
7427
7428         * tui/tui-regs.c (tui_reg_layout): Remove.
7429         (tui_reg_command): Use tui_regs_layout.
7430         * tui/tui-layout.h (tui_reg_command): Declare.
7431         * tui/tui-layout.c (tui_reg_command): New function.
7432
7433 2020-02-22  Tom Tromey  <tom@tromey.com>
7434
7435         * tui/tui.c (tui_rl_delete_other_windows): Call
7436         tui_remove_some_windows.
7437         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
7438         Declare method.
7439         (class tui_layout_window) <remove_windows>: New method.
7440         (class tui_layout_split) <remove_windows>: Declare.
7441         (tui_remove_some_windows): Declare.
7442         * tui/tui-layout.c (tui_remove_some_windows): New function.
7443         (tui_layout_split::remove_windows): New method.
7444
7445 2020-02-22  Tom Tromey  <tom@tromey.com>
7446
7447         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
7448         * tui/tui-layout.h (tui_next_layout): Declare.
7449         * tui/tui-layout.c (tui_next_layout): New function.
7450
7451 2020-02-22  Tom Tromey  <tom@tromey.com>
7452
7453         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
7454         correct coordinates.
7455
7456 2020-02-22  Tom Tromey  <tom@tromey.com>
7457
7458         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
7459         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
7460         DATA_WIN case.
7461
7462 2020-02-22  Tom Tromey  <tom@tromey.com>
7463
7464         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
7465         TUI_DISASM_WIN, not tui_win_list.
7466
7467 2020-02-22  Tom Tromey  <tom@tromey.com>
7468
7469         * valprint.c (generic_val_print_enum_1)
7470         (val_print_type_code_flags): Style member names.
7471         * rust-lang.c (val_print_struct, rust_print_enum)
7472         (rust_print_struct_def, rust_internal_print_type): Style member
7473         names.
7474         * p-valprint.c (pascal_object_print_value_fields): Style member
7475         names.  Only call fprintf_symbol_filtered for static members.
7476         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
7477         * f-valprint.c (f_val_print): Style member names.
7478         * f-typeprint.c (f_type_print_base): Style member names.
7479         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
7480         call fprintf_symbol_filtered for static members.
7481         (cp_print_class_member): Style member names.
7482         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
7483         member names.
7484         * ada-valprint.c (ada_print_scalar): Style enum names.
7485         (ada_val_print_enum): Likewise.
7486         * ada-typeprint.c (print_enum_type): Style enum names.
7487
7488 2020-02-21  Tom Tromey  <tom@tromey.com>
7489
7490         * psympriv.h (struct partial_symtab): Update comment.
7491
7492 2020-02-21  Tom Tromey  <tromey@adacore.com>
7493
7494         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
7495         type is CORE_ADDR.
7496
7497 2020-02-21  Tom de Vries  <tdevries@suse.de>
7498
7499         PR gdb/25534
7500         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
7501         if dependencies[i]->user != NULL.
7502
7503 2020-02-21  Ali Tamur  <tamur@google.com>
7504
7505         * dwarf2/read.c (dwarf2_name): Add null check.
7506
7507 2020-02-20  Tom Tromey  <tom@tromey.com>
7508
7509         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
7510         ">=", in binary search.
7511         (dwarf2_find_containing_comp_unit): New overload.
7512         (run_test): New self-test.
7513         (_initialize_dwarf2_read): Register new test.
7514
7515 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
7516
7517         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
7518         * riscv-tdep.h: Likewise.
7519         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
7520         rv32-only CSR.
7521         * features/riscv/64bit-csr.xml: Regenerated.
7522
7523 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
7524             Tom Tromey  <tom@tromey.com>
7525
7526         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
7527         of 'fputc_unfiltered'.
7528         (putchar_unfiltered): Call 'fputc_unfiltered'.
7529         (fputc_unfiltered): Call 'fputs_unfiltered'.
7530
7531 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
7532
7533         * config.in: Regenerate.
7534         * configure: Regenerate.
7535         * configure.ac: Add --with-python-libdir option.
7536         * main.c: Use WITH_PYTHON_LIBDIR.
7537
7538 2020-02-19  Tom Tromey  <tom@tromey.com>
7539
7540         * symtab.c (general_symbol_info::compute_and_set_names): Use
7541         obstack_strndup.  Simplify call to symbol_set_demangled_name.
7542
7543 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
7544
7545         * dwarf2/read.c (allocate_signatured_type_table,
7546         allocate_dwo_unit_table, allocate_type_unit_groups_table,
7547         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
7548         Remove objfile parameter, update all callers.
7549
7550 2020-02-19  Doug Evans  <dje@google.com>
7551
7552         PR rust/25535
7553         * rust-lang.c (rust_print_enum): Apply embedded_offset to
7554         rust_enum_variant calculation.
7555
7556 2020-02-19  Tom Tromey  <tromey@adacore.com>
7557
7558         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
7559
7560 2020-02-19  Tom Tromey  <tromey@adacore.com>
7561
7562         * ada-lang.c (cache_symbol): Use obstack_strdup.
7563
7564 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
7565
7566         * configure: Regenerate.
7567
7568 2020-02-19  Tom Tromey  <tromey@adacore.com>
7569
7570         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
7571         NULL check.
7572
7573 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
7574
7575         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
7576
7577 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
7578
7579         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
7580         if GDBSERVER is not defined.
7581         (riscv_tdesc_cache): Likewise, also store const target_desc.
7582         (STATIC_IN_GDB): Define.
7583         (riscv_create_target_description): Update declaration with
7584         STATIC_IN_GDB.
7585         (riscv_lookup_target_description): New function, only define if
7586         GDBSERVER is not defined.
7587         * arch/riscv.h (riscv_create_target_description): Declare only
7588         when GDBSERVER is defined.
7589         (riscv_lookup_target_description): New declaration when GDBSERVER
7590         is not defined.
7591         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
7592         (riscv_linux_read_features): ...this, and return
7593         riscv_gdbarch_features instead of target_desc.
7594         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
7595         (riscv_linux_read_description): Rename to...
7596         (riscv_linux_read_features): ...this.
7597         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
7598         Update to use riscv_gdbarch_features and
7599         riscv_lookup_target_description.
7600         * riscv-tdep.c (riscv_find_default_target_description): Use
7601         riscv_lookup_target_description instead of
7602         riscv_create_target_description.
7603
7604 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7605
7606         * valprint.c (generic_val_print_enum_1): When printing a flag
7607         enum with value 0 and there is no enumerator with value 0, print
7608         just "0" instead of "(unknown: 0x0)".
7609
7610 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7611
7612         * valprint.c (generic_val_print_enum_1): Print unknown part of
7613         flag enum in hex.
7614
7615 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7616
7617         * dwarf2/read.c (update_enumeration_type_from_children): Allow
7618         flag enums to contain duplicate enumerators.
7619         * valprint.c (generic_val_print_enum_1): Update comment.
7620
7621 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7622
7623         * dwarf2/read.c: Include "count-one-bits.h".
7624         (update_enumeration_type_from_children): If an enumerator has
7625         multiple bits set, don't treat the enumeration as a "flag enum".
7626         * valprint.c (generic_val_print_enum_1): Assert that enumerators
7627         of flag enums have 0 or 1 bit set.
7628
7629 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
7630
7631         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
7632         conversion.
7633         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
7634         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
7635         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
7636         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
7637         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
7638
7639 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7640
7641         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
7642
7643 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7644
7645         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
7646         displaced_step_closure_up.
7647         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
7648         (struct displaced_step_closure_up):
7649         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
7650         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
7651         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
7652         Likewise.
7653         * gdbarch.sh (displaced_step_copy_insn): Likewise.
7654         * gdbarch.c, gdbarch.h: Re-generate.
7655         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
7656         displaced_step_closure_up.
7657         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
7658         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
7659         * infrun.h (displaced_step_closure_up): New type alias.
7660         (struct displaced_step_inferior_state) <step_closure>: Change
7661         type to displaced_step_closure_up.
7662         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
7663         displaced_step_closure_up.
7664         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
7665
7666 2020-02-14  Tom Tromey  <tom@tromey.com>
7667
7668         * minidebug.c (gnu_debug_key): New global.
7669         (find_separate_debug_file_in_section): Use it.
7670
7671 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7672
7673         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
7674         std::unique_ptr.
7675         * gdbarch.c: Re-generate.
7676         * gdbarch.h: Re-generate.
7677         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
7678         change.
7679         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
7680         type to std::unique_ptr.
7681         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
7682         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
7683         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
7684         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
7685         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
7686         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
7687         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
7688         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
7689         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
7690
7691 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7692
7693         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
7694         std::unique_ptr.
7695         (displaced_step_clear): Rename to...
7696         (displaced_step_reset): ... this.  Just call displaced->reset ().
7697         (displaced_step_clear_cleanup): Rename to...
7698         (displaced_step_reset_cleanup): ... this.
7699         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
7700         (displaced_step_fixup): Likewise.
7701         (resume_1): Likewise.
7702         (handle_inferior_event): Restore child's memory before calling
7703         displaced_step_fixup on the parent.
7704         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
7705         to std::unique_ptr.
7706         <step_closure>: Change type to std::unique_ptr.
7707
7708 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7709
7710         * arm-tdep.c: Include count-one-bits.h.
7711         (cleanup_block_store_pc): Use count_one_bits.
7712         (cleanup_block_load_pc): Use count_one_bits.
7713         (arm_copy_block_xfer): Use count_one_bits.
7714         (thumb2_copy_block_xfer): Use count_one_bits.
7715         (thumb_copy_pop_pc_16bit): Use count_one_bits.
7716         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
7717         (thumb_get_next_pcs_raw): Use count_one_bits.
7718         (arm_get_next_pcs_raw): Use count_one_bits_l.
7719         * arch/arm.c (bitcount): Remove.
7720         * arch/arm.h (bitcount): Remove.
7721
7722 2020-02-14  Tom Tromey  <tromey@adacore.com>
7723
7724         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
7725         Update.
7726         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
7727         * dwarf2/loc.c (call_site_find_chain_1): Return
7728         unique_xmalloc_ptr.
7729         (call_site_find_chain): Likewise.
7730
7731 2020-02-14  Richard Biener  <rguenther@suse.de>
7732
7733         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
7734         on expression with division operators.
7735
7736 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
7737
7738         * MAINTAINERS (Write After Approval): Adding myself.
7739
7740 2020-02-12  Tom Tromey  <tom@tromey.com>
7741
7742         * event-loop.c (event_data, gdb_event, event_handler_func):
7743         Remove.
7744
7745 2020-02-12  Tom Tromey  <tom@tromey.com>
7746
7747         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
7748         (dwarf2_frame_objfile_data): Add comment.
7749         (find_comp_unit, set_comp_unit): New functions.
7750         (dwarf2_frame_find_fde): Use find_comp_unit.
7751         (dwarf2_build_frame_info): Use set_comp_unit.
7752
7753 2020-02-12  Tom Tromey  <tom@tromey.com>
7754
7755         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
7756         (comp_unit): Don't initialize objfile.
7757         (execute_cfa_program): Add text_offset parameter.
7758         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
7759         (dwarf2_frame_cache): Update.
7760         (dwarf2_build_frame_info): Don't set "objfile" member.
7761
7762 2020-02-12  Tom Tromey  <tom@tromey.com>
7763
7764         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
7765         (decode_frame_entry): Likewise.
7766         (dwarf2_build_frame_info): Update.
7767
7768 2020-02-12  Tom Tromey  <tom@tromey.com>
7769
7770         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
7771         (decode_frame_entry_1): Use the comp_unit obstack.
7772
7773 2020-02-12  Tom Tromey  <tom@tromey.com>
7774
7775         * dwarf2/frame.c (struct comp_unit): Add initializers and
7776         constructor.
7777         (dwarf2_frame_objfile_data): Store a comp_unit.
7778         (dwarf2_frame_find_fde): Update.
7779         (dwarf2_build_frame_info): Use "new".
7780
7781 2020-02-12  Tom Tromey  <tom@tromey.com>
7782
7783         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
7784         (dwarf2_fde_table): Typedef for std::vector.
7785         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
7786         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
7787         (decode_frame_entry): Update.
7788         (dwarf2_build_frame_info): Use "new".
7789
7790 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
7791
7792         * arm-tdep.c (arm_gdbarch_init): Update.
7793         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
7794         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
7795         have_neon, is_m>: Change to bool.
7796
7797 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
7798
7799         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
7800
7801 2020-02-12  Tom Tromey  <tom@tromey.com>
7802
7803         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
7804
7805 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
7806
7807         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
7808         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
7809
7810 2020-02-11  Tom Tromey  <tom@tromey.com>
7811
7812         * psymtab.h: Update comment.
7813
7814 2020-02-11  Tom Tromey  <tom@tromey.com>
7815
7816         * gdb_obstack.h (struct auto_obstack): Use
7817         DISABLE_COPY_AND_ASSIGN.
7818
7819 2020-02-11  Tom Tromey  <tom@tromey.com>
7820
7821         * dwarf2/frame.h (struct objfile): Don't forward declare.
7822
7823 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
7824
7825         * cris-tdep.c (cris_supply_gregset): Change signature to match
7826         what struct regset expects.
7827         (cris_regset): New struct.
7828         (fetch_core_registers): Remove.
7829         (cris_iterate_over_regset_sections): New function.
7830         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
7831         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
7832
7833 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
7834
7835         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
7836         registers.
7837
7838 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
7839
7840         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
7841
7842 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7843
7844         * configure: Re-generate.
7845
7846 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7847
7848         * configure: Re-generate.
7849
7850 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7851
7852         * acinclude: Update warning.m4 path.
7853         * warning.m4: Move to gdbsupport.
7854
7855 2020-02-11  Tom Tromey  <tromey@adacore.com>
7856
7857         * remote.c (remote_console_output): Update.
7858         * printcmd.c (printf_command): Update.
7859         * event-loop.c (gdb_wait_for_event): Update.
7860         * linux-nat.c (sigchld_handler): Update.
7861         * remote-sim.c (gdb_os_write_stdout): Update.
7862         (gdb_os_flush_stdout): Update.
7863         (gdb_os_flush_stderr): Update.
7864         (gdb_os_write_stderr): Update.
7865         * exceptions.c (print_exception): Update.
7866         * remote-fileio.c (remote_fileio_func_read): Update.
7867         (remote_fileio_func_write): Update.
7868         * tui/tui.c (tui_enable): Update.
7869         * tui/tui-interp.c (tui_interp::init): Update.
7870         * utils.c (init_page_info): Update.
7871         (putchar_unfiltered, fputc_unfiltered): Update.
7872         (gdb_flush): Update.
7873         (emit_style_escape): Update.
7874         (flush_wrap_buffer, fputs_maybe_filtered): Update.
7875         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
7876         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
7877         (stderr_file::write): Update.
7878         (stderr_file::puts): Update.
7879         * ui-file.h (ui_file_isatty, ui_file_write)
7880         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
7881         (ui_file_puts): Don't declare.
7882
7883 2020-02-10  Tom de Vries  <tdevries@suse.de>
7884
7885         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
7886         sentinel to char *.
7887
7888 2020-02-09  Tom de Vries  <tdevries@suse.de>
7889
7890         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
7891         filename if it matches "<artificial>".
7892
7893 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
7894
7895         * windows-tdep.c (struct enum_value_name): New struct.
7896         (create_enum): New function.
7897         (windows_get_siginfo_type): Create and use enum types.
7898
7899 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
7900
7901         * NEWS: Mention $_siginfo support for Windows.
7902         * windows-nat.c (handle_exception): Set siginfo_er.
7903         (windows_nat_target::mourn_inferior): Reset siginfo_er.
7904         (windows_xfer_siginfo): New function.
7905         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
7906         * windows-tdep.c (struct windows_gdbarch_data): New struct.
7907         (init_windows_gdbarch_data): New function.
7908         (get_windows_gdbarch_data): New function.
7909         (windows_get_siginfo_type): New function.
7910         (windows_init_abi): Register windows_get_siginfo_type.
7911         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
7912
7913 2020-02-08  Tom Tromey  <tom@tromey.com>
7914
7915         * dwarf2/read.c (class cutu_reader) <cutu_reader,
7916         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
7917         <keep>: Declare method.
7918         <m_keep>: Remove member.
7919         <~cutu_reader>: Remove.
7920         (cutu_reader::init_tu_and_read_dwo_dies): Update.
7921         (cutu_reader::cutu_reader): Update.
7922         (cutu_reader::keep): Rename from ~cutu_reader.
7923         (process_psymtab_comp_unit, build_type_psymtabs_1)
7924         (process_skeletonless_type_unit, load_partial_comp_unit)
7925         (load_full_comp_unit, dwarf2_read_addr_index)
7926         (read_signatured_type): Update.
7927
7928 2020-02-08  Tom Tromey  <tom@tromey.com>
7929
7930         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
7931         "want_partial_unit" parameter.
7932         (process_psymtab_comp_unit): Change want_partial_unit to bool.
7933         Inline check for DW_TAG_partial_unit.
7934         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
7935
7936 2020-02-08  Tom Tromey  <tom@tromey.com>
7937
7938         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
7939         read.c.
7940         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
7941         read.c.
7942
7943 2020-02-08  Tom Tromey  <tom@tromey.com>
7944
7945         * dwarf2/read.c (read_address): Move to comp-unit.c.
7946         (dwarf2_rnglists_process, dwarf2_ranges_process)
7947         (read_attribute_value, dwarf_decode_lines_1)
7948         (var_decode_location, decode_locdesc): Update.
7949         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
7950         read.c.  Remove "cu" parameter.
7951         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
7952         method.
7953
7954 2020-02-08  Tom Tromey  <tom@tromey.com>
7955
7956         * dwarf2/read.c (read_attribute_value, read_indirect_string)
7957         (read_indirect_line_string): Update.
7958         * dwarf2/comp-unit.c (read_offset): Remove.
7959         (read_comp_unit_head): Update.
7960         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
7961         method.
7962         (read_offset): Don't declare.
7963
7964 2020-02-08  Tom Tromey  <tom@tromey.com>
7965
7966         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
7967         * dwarf2/read.c (struct comp_unit_head): Move to
7968         dwarf2/comp-unit.h.
7969         (enum class rcuh_kind): Move to comp-unit.h.
7970         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
7971         (read_comp_unit_head, error_check_comp_unit_head)
7972         (read_and_check_comp_unit_head): Move to comp-unit.c.
7973         (read_offset, dwarf_unit_type_name): Likewise.
7974         (create_debug_type_hash_table, read_cutu_die_from_dwo)
7975         (cutu_reader::cutu_reader, read_call_site_scope)
7976         (find_partial_die, follow_die_offset): Update.
7977         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
7978
7979 2020-02-08  Tom Tromey  <tom@tromey.com>
7980
7981         * dwarf2/read.c (read_offset_1): Move to leb.c.
7982         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
7983         (dwarf_decode_macro_bytes): Update.
7984         * dwarf2/leb.c (read_offset): Rename; move from read.c.
7985         * dwarf2/leb.h (read_offset): Declare.
7986
7987 2020-02-08  Tom Tromey  <tom@tromey.com>
7988
7989         * dwarf2/read.c (dwarf2_section_size): Remove.
7990         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
7991         Update.
7992         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
7993
7994 2020-02-08  Tom Tromey  <tom@tromey.com>
7995
7996         * dwarf2/read.c (read_initial_length): Move to leb.c.
7997         * dwarf2/leb.h (read_initial_length): Declare.
7998         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
7999         handle_nonstd parameter.
8000         * dwarf2/frame.c (read_initial_length): Remove.
8001         (decode_frame_entry_1): Update.
8002
8003 2020-02-08  Tom Tromey  <tom@tromey.com>
8004
8005         * dwarf2/loc.c (dwarf2_find_location_expression)
8006         (dwarf_evaluate_loc_desc::get_tls_address)
8007         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
8008         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
8009         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
8010         (dwarf2_compile_property_to_c)
8011         (dwarf2_loc_desc_get_symbol_read_needs)
8012         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
8013         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
8014         (loclist_describe_location, loclist_tracepoint_var_ref)
8015         (loclist_generate_c_location): Update.
8016         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
8017         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
8018         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
8019         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
8020         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
8021         (dwarf2_per_cu_data::addr_size)
8022         (dwarf2_per_cu_data::ref_addr_size)
8023         (dwarf2_per_cu_data::text_offset)
8024         (dwarf2_per_cu_data::addr_type): Now methods.
8025         (per_cu_header_read_in): Make per_cu "const".
8026         (dwarf2_version): Remove.
8027         (dwarf2_per_cu_data::int_type): Now a method.
8028         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
8029         (set_die_type, read_array_type, read_subrange_index_type)
8030         (read_tag_string_type, read_subrange_type): Update.
8031         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
8032         offset_size, ref_addr_size, text_offset, addr_type, version,
8033         objfile, int_type, addr_sized_int_type>: Declare methods.
8034
8035 2020-02-08  Tom Tromey  <tom@tromey.com>
8036
8037         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
8038         Move earlier.
8039
8040 2020-02-08  Tom Tromey  <tom@tromey.com>
8041
8042         * dwarf2/read.h (dwarf_line_debug): Declare.
8043         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
8044         * dwarf2/read.c: Move line_header code to new files.
8045         (dwarf_line_debug): No longer static.
8046         * dwarf2/line-header.c: New file.
8047         * dwarf2/line-header.h: New file.
8048
8049 2020-02-08  Tom Tromey  <tom@tromey.com>
8050
8051         * dwarf2/read.c (struct line_header) <file_full_name,
8052         file_file_name>: Return unique_xmalloc_ptr.
8053         (line_header::file_file_name): Update.
8054         (line_header::file_full_name): Update.
8055         (dw2_get_file_names_reader): Update.
8056         (macro_start_file): Update.
8057
8058 2020-02-08  Tom Tromey  <tom@tromey.com>
8059
8060         * dwarf2/read.c (struct line_header) <file_full_name,
8061         file_file_name>: Declare methods.
8062         (dw2_get_file_names_reader): Update.
8063         (file_file_name): Now a method.
8064         (file_full_name): Likewise.
8065         (macro_start_file): Update.
8066
8067 2020-02-08  Tom Tromey  <tom@tromey.com>
8068
8069         * dwarf2/read.c (dwarf_always_disassemble)
8070         (show_dwarf_always_disassemble): Move to loc.c.
8071         (_initialize_dwarf2_read): Move "always-disassemble" registration
8072         to loc.c.
8073         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
8074         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
8075         static.
8076         (show_dwarf_always_disassemble): Move from read.c.
8077         (_initialize_dwarf2loc): Move always-disassemble from read.c.
8078
8079 2020-02-08  Tom Tromey  <tom@tromey.com>
8080
8081         * dwarf2/read.c (~dwarf2_per_objfile): Update.
8082         (create_quick_file_names_table): Return htab_up.
8083         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
8084         Update.
8085         * dwarf2/read.h (struct dwarf2_per_objfile)
8086         <quick_file_names_table>: Now htab_up.
8087
8088 2020-02-08  Tom Tromey  <tom@tromey.com>
8089
8090         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
8091
8092 2020-02-08  Tom Tromey  <tom@tromey.com>
8093
8094         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
8095         Rewrite.
8096         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
8097         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
8098         (abbrev_table::abbrev_table): No longer inline.
8099         (ABBREV_HASH_SIZE): Remove.
8100         (abbrev_table::m_abbrevs): Now an htab_up.
8101
8102 2020-02-08  Tom Tromey  <tom@tromey.com>
8103
8104         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
8105         (cutu_reader): Update.
8106         (build_type_psymtabs_1): Update.
8107         * dwarf2/abbrev.c (abbrev_table::read): Rename.
8108         (abbrev_table::alloc_abbrev): Update.
8109         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
8110         (abbrev_table::read): New static method, renamed from
8111         abbrev_table_read_table.
8112         (abbrev_table::alloc_abbrev)
8113         (abbrev_table::add_abbrev): Now private.
8114         (abbrev_table::abbrev_table): Now private.
8115         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
8116
8117 2020-02-08  Tom Tromey  <tom@tromey.com>
8118
8119         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
8120         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
8121         htab_up.
8122
8123 2020-02-08  Tom Tromey  <tom@tromey.com>
8124
8125         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
8126         htab_up.
8127         (lookup_dwo_unit_in_dwp): Update.
8128         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
8129         on obstack.
8130
8131 2020-02-08  Tom Tromey  <tom@tromey.com>
8132
8133         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
8134         obstack.
8135
8136 2020-02-08  Tom Tromey  <tom@tromey.com>
8137
8138         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
8139         line_header_hash.
8140         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
8141         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
8142         Change type to htab_up.
8143
8144 2020-02-08  Tom Tromey  <tom@tromey.com>
8145
8146         * dwarf2/read.c (allocate_type_unit_groups_table): Return
8147         htab_up.  Don't allocate on obstack.
8148         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
8149         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
8150         Change type to htab_up.
8151
8152 2020-02-08  Tom Tromey  <tom@tromey.com>
8153
8154         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
8155         Change type to htab_up.
8156         * dwarf2/read.c (create_signatured_type_table_from_index)
8157         (create_signatured_type_table_from_debug_names)
8158         (create_all_type_units, add_type_unit)
8159         (lookup_dwo_signatured_type, lookup_signatured_type)
8160         (process_skeletonless_type_unit): Update.
8161         (create_debug_type_hash_table, create_debug_types_hash_table):
8162         Change type of types_htab.
8163         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
8164         htab_up.  Don't allocate on obstack.
8165         (create_cus_hash_table): Change type of cus_htab parameter.
8166         (struct dwo_file) <cus, tus>: Now htab_up.
8167         (lookup_dwo_signatured_type, lookup_dwo_cutu)
8168         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
8169         (queue_and_load_all_dwo_tus): Update.
8170         * dwarf2/index-write.c (write_gdbindex): Update.
8171         (write_debug_names): Update.
8172
8173 2020-02-08  Tom Tromey  <tom@tromey.com>
8174
8175         * dwarf2/read.h (struct dwarf2_queue_item): Move from
8176         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
8177         destructor.
8178         (struct dwarf2_per_objfile) <queue>: New member.
8179         * dwarf2/read.c (struct dwarf2_queue_item): Move to
8180         dwarf2/read.h.
8181         (dwarf2_queue, dwarf2_queue_tail): Remove.
8182         (class dwarf2_queue_guard): Add parameter to constructor.  Use
8183         DISABLE_COPY_AND_ASSIGN.
8184         <m_per_objfile>: New member.
8185         <~dwarf2_queue_guard>: Rewrite.
8186         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
8187         Update.
8188         (~dwarf2_queue_item): New.
8189
8190 2020-02-08  Tom Tromey  <tom@tromey.com>
8191
8192         * dwarf2/read.c (struct die_info) <has_children>: New member.
8193         (dw2_get_file_names_reader): Remove has_children.
8194         (dw2_get_file_names): Update.
8195         (read_cutu_die_from_dwo): Remove has_children.
8196         (cutu_reader::init_tu_and_read_dwo_dies)
8197         (cutu_reader::cutu_reader): Update.
8198         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
8199         Remove has_children.
8200         (build_type_psymtabs_1, process_skeletonless_type_unit)
8201         (load_partial_comp_unit, load_full_comp_unit): Update.
8202         (create_dwo_cu_reader): Remove has_children.
8203         (create_cus_hash_table, read_die_and_children): Update.
8204         (read_full_die_1,read_full_die): Remove has_children.
8205         (read_signatured_type): Update.
8206         (class cutu_reader) <has_children>: Remove.
8207
8208 2020-02-08  Tom Tromey  <tom@tromey.com>
8209
8210         * dwarf2/expr.c: Rename from dwarf2expr.c.
8211         * dwarf2/expr.h: Rename from dwarf2expr.h.
8212         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
8213         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
8214         * dwarf2/frame.c: Rename from dwarf2-frame.c.
8215         * dwarf2/frame.h: Rename from dwarf2-frame.h.
8216         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
8217         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
8218         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
8219         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
8220         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
8221         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
8222         * dwarf2/loc.c: Rename from dwarf2loc.c.
8223         * dwarf2/loc.h: Rename from dwarf2loc.h.
8224         * dwarf2/read.c: Rename from dwarf2read.c.
8225         * dwarf2/read.h: Rename from dwarf2read.h.
8226         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
8227         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
8228         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
8229         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
8230         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
8231         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
8232         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
8233         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
8234         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
8235         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
8236         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
8237         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
8238         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
8239         Update.
8240         * Makefile.in (COMMON_SFILES): Update.
8241         (HFILES_NO_SRCDIR): Update.
8242
8243 2020-02-08  Tom Tromey  <tom@tromey.com>
8244
8245         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
8246         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
8247
8248 2020-02-08  Tom Tromey  <tom@tromey.com>
8249
8250         * dwarf2read.h (struct die_info): Don't declare.
8251
8252 2020-02-08  Tom Tromey  <tom@tromey.com>
8253
8254         * dwarf2read.h (die_info_ptr): Remove typedef.
8255
8256 2020-02-08  Tom Tromey  <tom@tromey.com>
8257
8258         * dwarf2read.c (read_call_site_scope)
8259         (handle_data_member_location, dwarf2_add_member_fn)
8260         (mark_common_block_symbol_computed, read_common_block)
8261         (attr_to_dynamic_prop, partial_die_info::read)
8262         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
8263         (dwarf2_symbol_mark_computed, set_die_type): Update.
8264         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
8265         method.
8266         (attr_form_is_block): Don't declare.
8267         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
8268
8269 2020-02-08  Tom Tromey  <tom@tromey.com>
8270
8271         * dwarf2read.c (dwarf2_find_base_address, )
8272         (read_call_site_scope, rust_containing_type)
8273         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
8274         (handle_data_member_location, dwarf2_add_member_fn)
8275         (get_alignment, read_structure_type, process_structure_scope)
8276         (mark_common_block_symbol_computed, read_common_block)
8277         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
8278         (partial_die_info::read, read_attribute_value, new_symbol)
8279         (lookup_die_type, dwarf2_get_ref_die_offset)
8280         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
8281         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
8282         (dwarf2_symbol_mark_computed): Update.
8283         * dwarf2/attribute.h (struct attribute) <value_as_address,
8284         form_is_section_offset, form_is_constant, form_is_ref>: Declare
8285         methods.
8286         (value_as_address, attr_form_is_section_offset)
8287         (attr_form_is_constant, attr_form_is_ref): Don't declare.
8288         * dwarf2/attribute.c (attribute::value_as_address)
8289         (attribute::form_is_section_offset, attribute::form_is_constant)
8290         (attribute::form_is_ref): Now methods.
8291
8292 2020-02-08  Tom Tromey  <tom@tromey.com>
8293
8294         * dwarf2read.c (struct attribute, DW_STRING)
8295         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
8296         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
8297         (attr_form_is_block, attr_form_is_section_offset)
8298         (attr_form_is_constant, attr_form_is_ref): Move.
8299         * dwarf2/attribute.h: New file.
8300         * dwarf2/attribute.c: New file, from dwarf2read.c.
8301         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
8302
8303 2020-02-08  Tom Tromey  <tom@tromey.com>
8304
8305         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
8306         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
8307         Move.
8308         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
8309         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
8310         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
8311         abbrev.c.
8312         * dwarf2/abbrev.h: New file.
8313         * dwarf2/abbrev.c: New file, from dwarf2read.c.
8314         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
8315
8316 2020-02-08  Tom Tromey  <tom@tromey.com>
8317
8318         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
8319         (dwarf2_section_size, dwarf2_get_section_info)
8320         (create_signatured_type_table_from_debug_names)
8321         (create_addrmap_from_aranges, read_debug_names_from_section)
8322         (get_gdb_index_contents_from_section, read_comp_unit_head)
8323         (error_check_comp_unit_head, read_abbrev_offset)
8324         (create_debug_type_hash_table, init_cu_die_reader)
8325         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
8326         (read_comp_units_from_section, create_cus_hash_table)
8327         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
8328         (create_dwp_v2_section, dwarf2_rnglists_process)
8329         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
8330         (abbrev_table_read_table, read_indirect_string_at_offset_from)
8331         (read_indirect_string_from_dwz, read_addr_index_1)
8332         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
8333         (dwarf_decode_macro_bytes, dwarf_decode_macros)
8334         (fill_in_loclist_baton): Update.
8335         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
8336         get_containing_section, get_bfd_owner, get_bfd_section,
8337         get_file_name, get_id, get_flags, empty, read>: Declare methods.
8338         (dwarf2_read_section, get_section_name, get_section_file_name)
8339         (get_containing_section, get_section_bfd_owner)
8340         (get_section_bfd_section, get_section_name, get_section_file_name)
8341         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
8342         declare.
8343         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
8344         (dwarf2_section_info::get_bfd_owner)
8345         (dwarf2_section_info::get_bfd_section)
8346         (dwarf2_section_info::get_name)
8347         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
8348         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
8349         (dwarf2_section_info::read): Now methods.
8350         * dwarf-index-write.c (class debug_names): Update.
8351
8352 2020-02-08  Tom Tromey  <tom@tromey.com>
8353
8354         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
8355         Move to dwarf2/section.h.
8356         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
8357         (get_section_bfd_section, get_section_name)
8358         (get_section_file_name, get_section_id, get_section_flags)
8359         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
8360         dwarf2/section.c.
8361         * dwarf2/section.h: New file.
8362         * dwarf2/section.c: New file, from dwarf2read.c.
8363         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
8364
8365 2020-02-08  Tom Tromey  <tom@tromey.com>
8366
8367         * dwarf2read.h (read_unsigned_leb128): Don't declare.
8368         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
8369         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
8370         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
8371         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
8372         * dwarf2/leb.h: New file, from dwarf2read.c.
8373         * dwarf2/leb.c: New file, from dwarf2read.c.
8374         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
8375         Remove.
8376         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
8377         (COMMON_SFILES): Add dwarf2/leb.c.
8378
8379 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
8380
8381         GDB 9.1 released.
8382
8383 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
8384
8385         PR gdb/25190:
8386         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
8387         * gdb/remote.c (remote_console_output): Update.
8388         * gdb/ui-file.c (fputs_unfiltered): Rename to...
8389         (ui_file_puts): ...this.
8390         * gdb/ui-file.h (ui_file_puts): Add declaration.
8391         * gdb/utils.c (emit_style_escape): Update.
8392         (flush_wrap_buffer): Update.
8393         (fputs_maybe_filtered): Update.
8394         (fputs_unfiltered): Add function.
8395
8396 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
8397
8398         * gdb/event-loop.c (gdb_wait_for_event): Update.
8399         * gdb/printcmd.c (printf_command): Update.
8400         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
8401         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
8402         (gdb_os_flush_stderr): Update.
8403         * gdb/remote.c (remote_console_output): Update.
8404         * gdb/ui-file.c (gdb_flush): Rename to...
8405         (ui_file_flush): ...this.
8406         (stderr_file::write): Update.
8407         (stderr_file::puts): Update.
8408         * gdb/ui-file.h (gdb_flush): Rename to...
8409         (ui_file_flush): ...this.
8410         * gdb/utils.c (gdb_flush): Add function.
8411         * gdb/utils.h (gdb_flush): Add declaration.
8412
8413 2020-02-07  Tom Tromey  <tromey@adacore.com>
8414
8415         PR breakpoints/24915:
8416         * source.c (find_and_open_source): Do not check basenames_may_differ.
8417
8418 2020-02-07  Tom Tromey  <tom@tromey.com>
8419
8420         * README: Update gdbserver documentation.
8421         * gdbserver: Move to top level.
8422         * configure.tgt (build_gdbserver): Remove.
8423         * configure.ac: Remove --enable-gdbserver.
8424         * configure: Rebuild.
8425         * Makefile.in (distclean): Don't mention gdbserver.
8426
8427 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
8428
8429         * source-cache.c (source_cache::ensure): Surround
8430         get_plain_source_lines with a try/catch.
8431         (source_cache::get_line_charpos): Get rid of try/catch
8432         and only check for the return value of "ensure".
8433         * tui/tui-source.c (tui_source_window::set_contents):
8434         Simplify "nlines" calculation.
8435
8436 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
8437
8438         * MAINTAINERS (Write After Approval): Add myself.
8439
8440 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
8441
8442         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
8443         function call.
8444
8445 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
8446
8447         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
8448
8449 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
8450
8451         * nat/riscv-linux-tdesc.h: New file.
8452         * nat/riscv-linux-tdesc.c: New file, taking code from...
8453         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
8454         ... here.
8455         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
8456         NATDEPFILES.
8457
8458 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
8459
8460         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
8461         we don't set the fake simulator ptid to the null_ptid.
8462
8463 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
8464
8465         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
8466         * gdbthread.h (class thread_info) <resumed>: Likewise.
8467         * infrun.c (resume_1): Likewise.
8468         (proceed): Likewise.
8469         (infrun_thread_stop_requested): Likewise.
8470         (stop_all_threads): Likewise.
8471         (handle_inferior_event): Likewise.
8472         (restart_threads): Likewise.
8473         (finish_step_over): Likewise.
8474         (keep_going_stepped_thread): Likewise.
8475         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
8476         (linux_handle_extended_wait): Likewise.
8477         * record-btrace.c (get_thread_current_frame_id): Likewise.
8478         * record-full.c (record_full_wait_1): Likewise.
8479         * remote.c (remote_target::process_initial_stop_replies): Likewise.
8480         * target.c (target_resume): Likewise.
8481         * thread.c (set_running_thread): Likewise.
8482
8483 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
8484
8485         * f-valprint.c (f77_print_array_1): Changed datatype of index
8486         variable to LONGEST from int to enable it to contain bound
8487         values correctly.
8488
8489 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
8490
8491         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
8492         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
8493         offsets according to FLEN determined.
8494         (riscv_linux_nat_target::read_description): Determine FLEN
8495         dynamically.
8496         (riscv_linux_nat_target::fetch_registers): Size regset buffer
8497         according to FLEN determined.
8498         (riscv_linux_nat_target::store_registers): Likewise.
8499
8500 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
8501
8502         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
8503         when reg->group is empty and reggroup is not.
8504
8505 2020-01-31  Tom Tromey  <tromey@adacore.com>
8506
8507         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
8508         Call beneath target's mourn_inferior after unpushing.
8509
8510 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
8511
8512         PR tui/9765
8513         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
8514         have enough lines to fill the screen, still return the lowest
8515         address we found.
8516
8517 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
8518
8519         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
8520         '-', '<', and '>' commands.
8521
8522 2020-01-29  Pedro Alves  <palves@redhat.com>
8523             Sergio Durigan Junior  <sergiodj@redhat.com>
8524
8525         * infcmd.c (construct_inferior_arguments): Assert that
8526         'argc' is greater than 0.
8527
8528 2020-01-29  Luis Machado  <luis.machado@linaro.org>
8529
8530         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
8531         (BRK_INSN_MASK): Define to 0xd4200000.
8532         (aarch64_program_breakpoint_here_p): New function.
8533         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
8534         * arch-utils.c (default_program_breakpoint_here_p): Moved from
8535         breakpoint.c.
8536         * arch-utils.h (default_program_breakpoint_here_p): Moved from
8537         breakpoint.h
8538         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
8539         call gdbarch_program_breakpoint_here_p.
8540         (program_breakpoint_here): Moved to arch-utils.c, renamed to
8541         default_program_breakpoint_here_p, changed return type to bool and
8542         simplified.
8543         * breakpoint.h (program_breakpoint_here): Moved prototype to
8544         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
8545         return type to bool.
8546         * gdbarch.c: Regenerate.
8547         * gdbarch.h: Regenerate.
8548         * gdbarch.sh (program_breakpoint_here_p): New method.
8549         * infrun.c (handle_signal_stop): Call
8550         gdbarch_program_breakpoint_here_p.
8551
8552 2020-01-26  Tom Tromey  <tom@tromey.com>
8553
8554         * ctfread.c (struct ctf_fp_info): Reindent.
8555         (_initialize_ctfread): Remove.
8556
8557 2020-01-26  Tom Tromey  <tom@tromey.com>
8558
8559         * psymtab.c (partial_map_expand_apply)
8560         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
8561         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
8562         (psym_print_stats, psym_expand_symtabs_for_function)
8563         (psym_map_symbol_filenames, psym_map_matching_symbols)
8564         (psym_expand_symtabs_matching)
8565         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
8566         (maintenance_check_psymtabs): Use new methods.
8567         * psympriv.h (struct partial_symtab) <readin_p,
8568         get_compunit_symtab>: New methods.
8569         <readin, compunit_symtab>: Remove members.
8570         (struct standard_psymtab): New.
8571         (struct legacy_psymtab): Derive from standard_psymtab.
8572         * dwarf2read.h (struct dwarf2_psymtab): Derive from
8573         standard_psymtab.
8574         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
8575
8576 2020-01-26  Tom Tromey  <tom@tromey.com>
8577
8578         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
8579         read_dependencies.  Add assert.
8580         * psymtab.c (partial_symtab::read_dependencies): New method.
8581         * psympriv.h (struct partial_symtab) <read_dependencies>: New
8582         method.
8583         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
8584         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
8585         read_dependencies.
8586         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
8587         Add assert.
8588
8589 2020-01-26  Tom Tromey  <tom@tromey.com>
8590
8591         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
8592         Call expand_psymtab.
8593         (xcoff_read_symtab): Call expand_psymtab.
8594         (xcoff_start_psymtab, xcoff_end_psymtab): Set
8595         legacy_expand_psymtab.
8596         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
8597         method.
8598         (struct legacy_psymtab) <expand_psymtab>: Implement.
8599         <legacy_expand_psymtab>: New member.
8600         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
8601         (parse_partial_symbols): Set legacy_expand_psymtab.
8602         (psymtab_to_symtab_1): Change argument order.  Call
8603         expand_psymtab.
8604         (new_psymtab): Set legacy_expand_psymtab.
8605         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
8606         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
8607         expand_psymtab.
8608         (dwarf2_psymtab::expand_psymtab): Rename from
8609         psymtab_to_symtab_1.  Call expand_psymtab.
8610         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
8611         (dbx_end_psymtab): Likewise.
8612         (dbx_psymtab_to_symtab_1): Change argument order. Call
8613         expand_psymtab.
8614         (dbx_read_symtab): Call expand_psymtab.
8615         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
8616         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
8617         (ctf_psymtab::read_symtab): Call expand_psymtab.
8618
8619 2020-01-26  Tom Tromey  <tom@tromey.com>
8620
8621         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
8622         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
8623         messages.
8624         * mdebugread.c (mdebug_read_symtab): Remove prints.
8625         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
8626         assert.
8627         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
8628
8629 2020-01-26  Tom Tromey  <tom@tromey.com>
8630
8631         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
8632         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
8633         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
8634         legacy_symtab.
8635         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
8636         * psymtab.c (psymtab_to_symtab): Call method.
8637         (dump_psymtab): Update.
8638         * psympriv.h (struct partial_symtab): Add virtual destructor.
8639         <read_symtab>: New method.
8640         (struct legacy_symtab): New.
8641         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
8642         (struct pst_map) <pst>: Now a legacy_psymtab.
8643         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
8644         (new_psymtab): Use legacy_psymtab.
8645         * dwarf2read.h (struct dwarf2_psymtab): New.
8646         (struct dwarf2_per_cu_data) <psymtab>: Use it.
8647         * dwarf2read.c (dwarf2_create_include_psymtab)
8648         (dwarf2_build_include_psymtabs, create_type_unit_group)
8649         (create_partial_symtab, process_psymtab_comp_unit_reader)
8650         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
8651         (set_partial_user): Use dwarf2_psymtab.
8652         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
8653         (psymtab_to_symtab_1, process_full_comp_unit)
8654         (process_full_type_unit, dwarf2_ranges_read)
8655         (dwarf2_get_pc_bounds, psymtab_include_file_name)
8656         (dwarf_decode_lines): Use dwarf2_psymtab.
8657         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
8658         (add_address_entry_worker, write_one_signatured_type)
8659         (recursively_count_psymbols, recursively_write_psymbols)
8660         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
8661         (write_debug_names): Likewise.
8662         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
8663         <pst>: Now a legacy_psymtab.
8664         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
8665         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
8666         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
8667         * ctfread.c (struct ctf_psymtab): New.
8668         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
8669         ctf_psymtab.
8670         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
8671         (create_partial_symtab): Return a ctf_psymtab.
8672         (scan_partial_symbols): Update.
8673
8674 2020-01-26  Tom Tromey  <tom@tromey.com>
8675
8676         * xcoffread.c (xcoff_start_psymtab): Use new.
8677         * psymtab.c (partial_symtab::partial_symtab): New constructor,
8678         renamed from start_psymtab_common.
8679         * psympriv.h (struct partial_symtab): Add new constructor.
8680         (start_psymtab_common): Don't declare.
8681         * mdebugread.c (parse_partial_symbols): Use new.
8682         * dwarf2read.c (create_partial_symtab): Use new.
8683         * dbxread.c (start_psymtab): Use new.
8684         * ctfread.c (create_partial_symtab): Use new.
8685
8686 2020-01-26  Tom Tromey  <tom@tromey.com>
8687
8688         * xcoffread.c (xcoff_end_psymtab): Use new.
8689         * psymtab.c (start_psymtab_common): Use new.
8690         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
8691         Update.
8692         * psympriv.h (struct partial_symtab): Add parameters to
8693         constructor.  Don't inline.
8694         (allocate_psymtab): Don't declare.
8695         * mdebugread.c (new_psymtab): Use new.
8696         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
8697         * dbxread.c (dbx_end_psymtab): Use new.
8698
8699 2020-01-26  Tom Tromey  <tom@tromey.com>
8700
8701         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
8702         allocate_psymtab.  Update documentation.
8703         * psymtab.c (psymtab_storage::install_psymtab): Rename from
8704         allocate_psymtab.  Do not use new.
8705         (allocate_psymtab): Use new.  Update.
8706
8707 2020-01-26  Tom Tromey  <tom@tromey.com>
8708
8709         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
8710         * psymtab.c (psym_print_stats): Update.
8711         * psympriv.h (struct partial_symtab) <readin,
8712         psymtabs_addrmap_supported, anonymous>: Now bool.
8713         * mdebugread.c (psymtab_to_symtab_1): Update.
8714         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
8715         (build_type_psymtabs_reader, psymtab_to_symtab_1)
8716         (process_full_comp_unit, process_full_type_unit): Update.
8717         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
8718         * ctfread.c (psymtab_to_symtab): Update.
8719
8720 2020-01-26  Tom Tromey  <tom@tromey.com>
8721
8722         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
8723         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
8724         * psymtab.c (psymtab_storage): Delete psymtabs.
8725         (psymtab_storage::allocate_psymtab): Use new.
8726         (psymtab_storage::discard_psymtab): Use delete.
8727         * psympriv.h (struct partial_symtab): Add constructor and
8728         initializers.
8729
8730 2020-01-26  Tom Tromey  <tom@tromey.com>
8731
8732         * machoread.c: Do not include psympriv.h.
8733
8734 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8735
8736         * NEWS: Mention the new option and the set/show commands.
8737
8738 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8739
8740         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
8741         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
8742         (validate_exec_file): New variables, enums, functions.
8743         (exec_file_locate_attach, print_section_info): Style the filenames.
8744         (_initialize_exec): Install show_exec_file_mismatch_command and
8745          set_exec_file_mismatch_command.
8746         * gdbcore.h (validate_exec_file): Declare.
8747         * infcmd.c (attach_command): Call validate_exec_file.
8748         * remote.c ( remote_target::remote_add_inferior): Likewise.
8749
8750 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8751
8752         * frame.c (find_frame_sal): Move call to get_next_frame into more
8753         inner scope.
8754         * inline-frame.c (inilne_state) <inline_state>: Update argument
8755         types.
8756         (inilne_state) <skipped_symbol>: Rename to...
8757         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
8758         (skip_inline_frames): Build vector of skipped symbols and use this
8759         to reate the inline_state.
8760         (inline_skipped_symbol): Add a comment and some assertions, fetch
8761         skipped symbol from the list.
8762
8763 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8764
8765         * buildsym.c (lte_is_less_than): Delete.
8766         (buildsym_compunit::end_symtab_with_blockvector): Create local
8767         lambda function to sort line table entries, and use
8768         std::stable_sort instead of std::sort.
8769         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
8770         markers when looking for a previous line.
8771
8772 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8773
8774         * dwarf2read.c (lnp_state_machine::record_line): Include
8775         end_sequence parameter in debug print out.  Record the line if we
8776         are at an end_sequence marker even if it's not the start of a
8777         statement.
8778         * symmisc.c (maintenance_print_one_line_table): Print end of
8779         sequence markers with 'END' not '0'.
8780
8781 2020-01-24  Pedro Alves  <palves@redhat.com>
8782
8783         PR gdb/25410
8784         * thread.c (scoped_restore_current_thread::restore): Use
8785         switch_to_inferior_no_thread.
8786         * exec.c: Include "progspace-and-thread.h".
8787         (add_target_sections, remove_target_sections):
8788         scoped_restore_current_pspace_and_thread instead of
8789         scoped_restore_current_thread.
8790         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
8791         and aspace to the inferior before calling clone_program_space.
8792         Remove stale comment.
8793
8794 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8795
8796         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
8797         (arm_netbsd_nat_target::fetch_registers): ...this.
8798         (arm_nbsd_nat_target::store_registers): Rename to...
8799         (arm_netbsd_nat_target::store_registers): ...this.
8800
8801 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8802
8803         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
8804         register_t.
8805
8806 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8807
8808         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
8809         Update comment.
8810         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
8811         Likewise.
8812         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
8813         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
8814         the correct replacement (iterate_over_regset_sections).
8815         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
8816         Update comment.
8817
8818 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
8819
8820         PR gdb/23718
8821         * gdb/python/python.c (execute_gdb_command): Call
8822         async_enable_stdin in catch block.
8823
8824 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8825
8826         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
8827         SWITCH_THRU_ALL_UIS.
8828
8829 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8830
8831         PR tui/9765
8832         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
8833         comment, add extra parameter, and update to store previous symbol
8834         when appropriate.
8835         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
8836         add extra parameter.
8837         * tui/tui-disasm.c (tui_disassemble): Update header comment,
8838         remove unneeded parameter, add try/catch around gdb_print_insn,
8839         rewrite to add items to asm_lines vector.
8840         (tui_find_backward_disassembly_start_address): New function.
8841         (tui_find_disassembly_address): Updated throughout.
8842         (tui_disasm_window::set_contents): Update for changes to
8843         tui_disassemble.
8844         (tui_disasm_window::do_scroll_vertical): No need to adjust the
8845         number of lines to scroll.
8846
8847 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
8848
8849         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
8850         (SECT_OFF_DATA): Likewise.
8851         (SECT_OFF_RODATA): Likewise.
8852         (SECT_OFF_TEXT): Likewise.
8853         (SECT_OFF_BSS): Likewise.
8854         (struct objfile) <text_section_offset, data_section_offset>: New
8855         methods.
8856         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
8857         objfile::text_section_offset.
8858         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
8859         * coffread.c (coff_symtab_read): Likewise.
8860         (enter_linenos): Likewise.
8861         (process_coff_symbol): Likewise.
8862         * ctfread.c (get_objfile_text_range): Likewise.
8863         * dtrace-probe.c (dtrace_probe::get_relocated_address):
8864         Use objfile::data_section_offset.
8865         * dwarf2-frame.c (execute_cfa_program): Use
8866         objfile::text_section_offset.
8867         (dwarf2_frame_find_fde): Likewise.
8868         * dwarf2read.c (create_addrmap_from_index): Likewise.
8869         (create_addrmap_from_aranges): Likewise.
8870         (dw2_find_pc_sect_compunit_symtab): Likewise.
8871         (process_psymtab_comp_unit_reader): Likewise.
8872         (add_partial_symbol): Likewise.
8873         (add_partial_subprogram): Likewise.
8874         (process_full_comp_unit): Likewise.
8875         (read_file_scope): Likewise.
8876         (read_func_scope): Likewise.
8877         (read_lexical_block_scope): Likewise.
8878         (read_call_site_scope): Likewise.
8879         (dwarf2_rnglists_process): Likewise.
8880         (dwarf2_ranges_process): Likewise.
8881         (dwarf2_ranges_read): Likewise.
8882         (dwarf_decode_lines_1): Likewise.
8883         (new_symbol): Likewise.
8884         (dwarf2_fetch_die_loc_sect_off): Likewise.
8885         (dwarf2_per_cu_text_offset): Likewise.
8886         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
8887         * hppa-tdep.c (read_unwind_info): Likewise.
8888         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
8889         * psympriv.h (struct partial_symtab): Likewise.
8890         * psymtab.c (find_pc_sect_psymtab): Likewise.
8891         * solib-svr4.c (enable_break): Likewise.
8892         * stap-probe.c (relocate_address): Use
8893         objfile::data_section_offset.
8894         * xcoffread.c (enter_line_range): Use
8895         objfile::text_section_offset.
8896         (read_xcoff_symtab): Likewise.
8897
8898 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
8899
8900         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
8901         declaration to narrower scopes.
8902
8903 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
8904
8905         * darwin-nat.h (struct darwin_exception_msg, enum
8906         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
8907         Move up.
8908         (class darwin_nat_target) <wait_1, check_new_threads,
8909         decode_exception_message, decode_message, stop_inferior,
8910         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
8911         * darwin-nat.c (darwin_check_new_threads): Rename to...
8912         (darwin_nat_target::check_new_threads): ... this.
8913         (darwin_suspend_inferior_it): Remove.
8914         (darwin_decode_exception_message): Rename to...
8915         (darwin_nat_target::decode_exception_message): ... this.
8916         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
8917         (darwin_decode_message): Rename to...
8918         (darwin_nat_target::decode_message): ... this.
8919         (cancel_breakpoint): Rename to...
8920         (darwin_nat_target::cancel_breakpoint): ... this.
8921         (darwin_wait): Rename to...
8922         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
8923         instead of iterate_over_inferiors.
8924         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
8925         (darwin_stop_inferior): Rename to...
8926         (darwin_nat_target::stop_inferior): ... this.
8927         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
8928         (darwin_init_thread_list): Rename to...
8929         (darwin_nat_target::init_thread_list): ... this.
8930         (darwin_ptrace_him): Rename to...
8931         (darwin_nat_target::ptrace_him): ... this.
8932         (darwin_nat_target::create_inferior): Pass lambda function to
8933         fork_inferior.
8934         (darwin_nat_target::detach): Call stop_inferior instead of
8935         darwin_stop_inferior.
8936         * fork-inferior.h (fork_inferior): Change init_trace_fun
8937         parameter to gdb::function_view.
8938         * fork-inferior.c (fork_inferior): Likewise.
8939
8940 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
8941
8942         * i386-cygwin-tdep.c (core_process_module_section): Update.
8943         * windows-nat.c (struct lm_info_windows): Add text_offset.
8944         (windows_xfer_shared_libraries): Update.
8945         * windows-tdep.c (windows_xfer_shared_library):
8946         Add text_offset_cached argument.
8947         * windows-tdep.h (windows_xfer_shared_library): Update.
8948
8949 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8950
8951         * gdbarch.sh: Add declaration for _initialize_gdbarch.
8952
8953 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8954
8955         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
8956         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
8957         replace with range-based for.
8958         (gdbsim_interrupt_inferior): Remove.
8959         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
8960         with a range-based for.  Inline code from
8961         gdbsim_interrupt_inferior.
8962
8963 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8964
8965         * infrun.c (proceed): Fix indentation.
8966
8967 2020-01-21  Tom Tromey  <tromey@adacore.com>
8968
8969         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
8970         * python/python.c (python_extension_ops): Update.
8971         (gdbpy_colorize): New function.
8972         * python/lib/gdb/__init__.py (colorize): New function.
8973         * extension.h (ext_lang_colorize): Declare.
8974         * extension.c (ext_lang_colorize): New function.
8975         * extension-priv.h (struct extension_language_ops) <colorize>: New
8976         member.
8977         * cli/cli-style.c (_initialize_cli_style): Update help text.
8978
8979 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8980
8981         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
8982         <cond>: Change type to bool.
8983         (aarch64_displaced_step_b_cond): Update cond to use bool type.
8984         (aarch64_displaced_step_cb): Likewise.
8985         (aarch64_displaced_step_tb): Likewise.
8986
8987 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8988
8989         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
8990         output.
8991
8992 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8993
8994         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
8995         <pc_adjust>: Adjust the documentation.
8996         (aarch64_displaced_step_fixup): Check if PC really moved before
8997         adjusting it.
8998
8999 2020-01-19  Tom Tromey  <tom@tromey.com>
9000
9001         * disasm.c (~gdb_disassembler): New destructor.
9002         (gdb_buffered_insn_length): Call disassemble_free_target.
9003         * disasm.h (class gdb_disassembler): Declare destructor.  Use
9004         DISABLE_COPY_AND_ASSIGN.
9005
9006 2020-01-19  Tom Tromey  <tom@tromey.com>
9007
9008         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
9009         (die_reader_func_ftype): Remove.
9010         (cutu_reader): New class.
9011         (dw2_get_file_names_reader): Remove "data" parameter.
9012         (dw2_get_file_names): Use cutu_reader.
9013         (create_debug_type_hash_table): Update.
9014         (read_cutu_die_from_dwo): Update comment.
9015         (lookup_dwo_unit): Add dwo_name parameter.
9016         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
9017         die_reader_func_ftype and data parameters.
9018         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
9019         Remove die_reader_func_ftype and data parameters.
9020         (~cutu_reader): New; from init_cutu_and_read_dies.
9021         (cutu_reader::cutu_reader): Rename from
9022         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
9023         and data parameters.
9024         (init_cutu_and_read_dies_simple): Remove.
9025         (struct process_psymtab_comp_unit_data): Remove.
9026         (process_psymtab_comp_unit_reader): Remove data parameter; add
9027         want_partial_unit and pretend_language parameters.
9028         (process_psymtab_comp_unit): Use cutu_reader.
9029         (build_type_psymtabs_reader): Remove data parameter.
9030         (build_type_psymtabs_1): Use cutu_reader.
9031         (process_skeletonless_type_unit): Likewise.
9032         (load_partial_comp_unit_reader): Remove.
9033         (load_partial_comp_unit): Use cutu_reader.
9034         (load_full_comp_unit_reader): Remove.
9035         (load_full_comp_unit): Use cutu_reader.
9036         (struct create_dwo_cu_data): Remove.
9037         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
9038         dwo_unit parameters.
9039         (create_cus_hash_table): Use cutu_reader.
9040         (struct dwarf2_read_addr_index_data): Remove.
9041         (dwarf2_read_addr_index_reader): Remove.
9042         (dwarf2_read_addr_index): Use cutu_reader.
9043         (read_signatured_type_reader): Remove.
9044         (read_signatured_type): Use cutu_reader.
9045
9046 2020-01-19  Tom Tromey  <tom@tromey.com>
9047
9048         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
9049         * tui/tui-wingeneral.h (class tui_suppress_output): New.
9050         (tui_wrefresh): Declare.
9051         * tui/tui-wingeneral.c (suppress_output): New global.
9052         (tui_suppress_output, ~tui_suppress_output): New constructor and
9053         destructor.
9054         (tui_wrefresh): New function.
9055         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
9056         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
9057         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
9058         method.
9059         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
9060         tui_wrefresh.
9061         (tui_data_window::no_refresh): New method.
9062         (tui_data_item_window::refresh_window): Call tui_wrefresh.
9063         (tui_reg_command): Use tui_suppress_output
9064         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
9065         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
9066         method.
9067         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
9068
9069 2020-01-19  Tom Tromey  <tom@tromey.com>
9070
9071         * tui/tui-winsource.c (tui_update_source_windows_with_line):
9072         Handle case where symtab is null.
9073
9074 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
9075
9076         * linux-fork.c (one_fork_p): Simplify.
9077
9078 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
9079
9080         * top.c (struct qt_args): Remove.
9081         (kill_or_detach): Change return type to void, replace `void *`
9082         parameter with a proper one.
9083         (print_inferior_quit_action):  Likewise.
9084         (quit_confirm): Use range-based for loop to iterate over inferiors.
9085         (quit_force): Likewise.
9086
9087 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
9088
9089         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
9090         `void *` parameter with proper parameters.
9091         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
9092         (print_one_inferior): Change return type to void, replace `void *`
9093         parameter with proper parameters.
9094         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
9095         inferiors.
9096         (get_other_inferior): Remove.
9097         (mi_cmd_remove_inferior): Use range-based loop to iterate over
9098         inferiors.
9099
9100 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
9101
9102         * mi/mi-interp.c (report_initial_inferior): Remove.
9103         (mi_interp::init): Use range-based for to iterate over inferiors.
9104
9105 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
9106
9107         * python/py-inferior.c (build_inferior_list): Remove.
9108         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
9109
9110 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
9111
9112         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
9113         (btrace_stitch_trace): Likewise.
9114         * charset.c (intermediate_encoding): Likewise (vaild).
9115         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
9116         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
9117         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
9118
9119 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
9120
9121         * windows-tdep.c (windows_get_tlb_type):
9122         Add rtl_user_process_parameters type.
9123
9124 2020-01-16  Pedro Alves  <palves@redhat.com>
9125             Norbert Lange  <nolange79@gmail.com>
9126
9127         PR build/24805
9128         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
9129         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
9130         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
9131         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
9132         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
9133         (ps_plog): Redeclare exported functions with default visibility.
9134
9135 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
9136
9137         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
9138         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
9139
9140 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
9141
9142         * infcmd.c (post_create_inferior): Use get_thread_regcache
9143         instead of get_current_regcache.
9144
9145 2020-01-14  Tom Tromey  <tom@tromey.com>
9146
9147         PR symtab/12535:
9148         * python/python.c (gdbpy_decode_line): Treat empty string the same
9149         as no argument.
9150
9151 2020-01-14  Tom Tromey  <tom@tromey.com>
9152
9153         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
9154
9155 2020-01-14  Tom Tromey  <tom@tromey.com>
9156
9157         * nat/linux-btrace.c: Don't include <config.h>.
9158         * nat/linux-ptrace.c: Don't include <config.h>.
9159         * nat/x86-linux-dregs.c: Don't include <config.h>.
9160
9161 2020-01-14  Tom Tromey  <tom@tromey.com>
9162
9163         * configure: Rebuild.
9164         * configure.ac: Move many checks to ../gdbsupport/common.m4.
9165
9166 2020-01-14  Tom Tromey  <tom@tromey.com>
9167
9168         * nat/x86-linux-dregs.c: Include configh.h.
9169         * nat/linux-ptrace.c: Include configh.h.
9170         * nat/linux-btrace.c: Include configh.h.
9171         * defs.h: Include config.h, bfd.h.
9172         * configure.ac: Don't source common.host.
9173         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
9174         * configure: Rebuild.
9175         * acinclude.m4: Update path.
9176         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
9177         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
9178         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
9179         (CLIBS): Add LIBSUPPORT.
9180         (CDEPS): Likewise.
9181         (COMMON_SFILES): Remove gdbsupport files.
9182         (HFILES_NO_SRCDIR): Likewise.
9183         (stamp-version): Update path to create-version.sh.
9184         (ALLDEPFILES): Remove gdbsupport files.
9185
9186 2020-01-14  Tom Tromey  <tom@tromey.com>
9187
9188         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
9189         USE_WIN32API when needed.
9190         * configure.ac (USE_WIN32API): Don't define.
9191         (WIN32LIBS): Use WIN32APILIBS.
9192         * configure: Rebuild.
9193
9194 2020-01-14  Tom Tromey  <tom@tromey.com>
9195
9196         * configure: Rebuild.
9197         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
9198
9199 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
9200
9201         * skip.c (skip_function_command): Make skip w/o arguments use the
9202         name of the inlined function if pc is inside any inlined function.
9203
9204 2020-01-14  Luis Machado  <luis.machado@linaro.org>
9205
9206         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
9207         * infrun.c (resume_1): Likewise.
9208         (handle_inferior_event): Remove stale comment.
9209         * linux-nat.c (linux_nat_target::resume): Update comments.
9210         (save_stop_reason): Likewise.
9211         (linux_nat_filter_event): Likewise.
9212         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
9213
9214 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9215
9216         * elfread.c (record_minimal_symbol): Set section index to 0 for
9217         non-allocatable sections.
9218
9219
9220 2020-01-13  Ali Tamur <tamur@google.com>
9221
9222         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
9223         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
9224         to gdb::optional.  Update comments.
9225         (dwo_file): Update comments.
9226         (read_attribute): Update API to take an additional out parameter,
9227         need_reprocess.  This is used to mark attributes that need other
9228         attributes (e.g. str_offsets_base) for correct computation which may not
9229         have been read yet.
9230         (read_attribute_reprocess): New function declaration.
9231         (read_addr_index): Likewise.
9232         (read_dwo_str_index): Likewise.
9233         (read_stub_str_index): Likewise.
9234         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
9235         (lookup_addr_base): New function definition.
9236         (lookup_ranges_base): Likewise.
9237         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
9238         lookup_ranges_base.
9239         (init_cutu_and_read_dies): Update comments.
9240         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
9241         unit.  This is used to inherit parent's str_offsets_base and addr_base.
9242         Update comments.
9243         (init_cutu_and_read_dies_simple): Reflect API changes.
9244         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
9245         (create_cus_hash_table): Change API to take parent compile unit.
9246         Reflect API changes.
9247         (open_and_init_dwo_file): Reflect API changes.
9248         (dwarf2_get_pc_bounds): Update comments.
9249         (dwarf2_record_block_ranges): Likewise.
9250         (read_full_die_1): Change implementation to reprocess attributes that
9251         need str_offsets_base and addr_base.
9252         (partial_die_info::read): Likewise.
9253         (read_attribute_reprocess): New function definition.
9254         (read_attribute_value): Change API to take an additional out parameter,
9255         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
9256         when a non-dwo compile unit has index based attributes.
9257         (read_attribute): Reflect API changes.
9258         (read_addr_index_1): Reflect API changes.  Update comments.
9259         (dwarf2_read_addr_index_data): Reflect API changes.
9260         (dwarf2_read_addr_index): Likewise.
9261         (read_str_index): Change API and implementation.  This becomes a helper
9262         to be used by the new string index related methods.  Update error
9263         message and comments.
9264         (read_dwo_str_index): New function definition.
9265         (read_stub_str_index): Likewise.
9266         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
9267         * symfile.h (dwarf2_debug_sections): Likewise.
9268         * xcoffread.c (dwarf2_debug_sections): Likewise.
9269
9270 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9271
9272         * gdbcore.h (struct core_fns) <core_read_registers>: Change
9273         core_reg_sect type to gdb_byte *.
9274         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
9275         * cris-tdep.c (fetch_core_registers): Likewise.
9276         * corelow.c (core_target::get_core_register_section): Change
9277         type of `contents` to gdb::byte_vector.
9278
9279 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9280
9281         * tui/tui-wingeneral.c (box_win): Position the title in the center
9282         of the border.
9283
9284 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
9285
9286         * corelow.c (core_target::get_core_register_section): Use
9287           std::vector instead of alloca.
9288
9289 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9290
9291         * warning.m4: Add -Wmissing-declarations to build_warnings.
9292         * configure: Re-generate.
9293
9294 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9295
9296         * python/python.c (init__gdb_module): Add declaration.
9297
9298 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9299
9300         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
9301         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
9302         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
9303         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
9304         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
9305         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
9306         * ada-exp.y (_initialize_ada_exp): Add declaration.
9307         * ada-lang.c (_initialize_ada_language): Add declaration.
9308         * ada-tasks.c (_initialize_tasks): Add declaration.
9309         * agent.c (_initialize_agent): Add declaration.
9310         * aix-thread.c (_initialize_aix_thread): Add declaration.
9311         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
9312         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
9313         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
9314         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
9315         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
9316         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
9317         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
9318         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
9319         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
9320         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
9321         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
9322         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
9323         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
9324         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
9325         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
9326         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
9327         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
9328         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
9329         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
9330         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
9331         * annotate.c (_initialize_annotate): Add declaration.
9332         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
9333         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
9334         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
9335         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
9336         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
9337         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
9338         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
9339         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
9340         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
9341         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
9342         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
9343         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
9344         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
9345         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
9346         * auto-load.c (_initialize_auto_load): Add declaration.
9347         * auxv.c (_initialize_auxv): Add declaration.
9348         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
9349         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
9350         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
9351         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
9352         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
9353         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
9354         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
9355         * breakpoint.c (_initialize_breakpoint): Add declaration.
9356         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
9357         * btrace.c (_initialize_btrace): Add declaration.
9358         * charset.c (_initialize_charset): Add declaration.
9359         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
9360         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
9361         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
9362         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
9363         * cli/cli-script.c (_initialize_cli_script): Add declaration.
9364         * cli/cli-style.c (_initialize_cli_style): Add declaration.
9365         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
9366         * coffread.c (_initialize_coffread): Add declaration.
9367         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
9368         * compile/compile.c (_initialize_compile): Add declaration.
9369         * complaints.c (_initialize_complaints): Add declaration.
9370         * completer.c (_initialize_completer): Add declaration.
9371         * copying.c (_initialize_copying): Add declaration.
9372         * corefile.c (_initialize_core): Add declaration.
9373         * corelow.c (_initialize_corelow): Add declaration.
9374         * cp-abi.c (_initialize_cp_abi): Add declaration.
9375         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
9376         * cp-support.c (_initialize_cp_support): Add declaration.
9377         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
9378         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
9379         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
9380         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
9381         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
9382         * ctfread.c (_initialize_ctfread): Add declaration.
9383         * d-lang.c (_initialize_d_language): Add declaration.
9384         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
9385         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
9386         * dbxread.c (_initialize_dbxread): Add declaration.
9387         * dcache.c (_initialize_dcache): Add declaration.
9388         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
9389         * disasm.c (_initialize_disasm): Add declaration.
9390         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
9391         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
9392         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
9393         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
9394         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
9395         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
9396         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
9397         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
9398         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
9399         * elfread.c (_initialize_elfread): Add declaration.
9400         * exec.c (_initialize_exec): Add declaration.
9401         * extension.c (_initialize_extension): Add declaration.
9402         * f-lang.c (_initialize_f_language): Add declaration.
9403         * f-valprint.c (_initialize_f_valprint): Add declaration.
9404         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
9405         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
9406         * filesystem.c (_initialize_filesystem): Add declaration.
9407         * findcmd.c (_initialize_mem_search): Add declaration.
9408         * findvar.c (_initialize_findvar): Add declaration.
9409         * fork-child.c (_initialize_fork_child): Add declaration.
9410         * frame-base.c (_initialize_frame_base): Add declaration.
9411         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
9412         * frame.c (_initialize_frame): Add declaration.
9413         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
9414         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
9415         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
9416         * gcore.c (_initialize_gcore): Add declaration.
9417         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
9418         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
9419         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
9420         * gdbarch.c (_initialize_gdbarch): Add declaration.
9421         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
9422         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
9423         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
9424         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
9425         * go-lang.c (_initialize_go_language): Add declaration.
9426         * go32-nat.c (_initialize_go32_nat): Add declaration.
9427         * guile/guile.c (_initialize_guile): Add declaration.
9428         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
9429         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
9430         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
9431         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
9432         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
9433         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
9434         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
9435         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
9436         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
9437         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
9438         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
9439         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
9440         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
9441         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
9442         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
9443         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
9444         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
9445         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
9446         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
9447         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
9448         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
9449         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
9450         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
9451         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
9452         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
9453         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
9454         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
9455         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
9456         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
9457         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
9458         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
9459         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
9460         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
9461         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
9462         * infcall.c (_initialize_infcall): Add declaration.
9463         * infcmd.c (_initialize_infcmd): Add declaration.
9464         * inflow.c (_initialize_inflow): Add declaration.
9465         * infrun.c (_initialize_infrun): Add declaration.
9466         * interps.c (_initialize_interpreter): Add declaration.
9467         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
9468         * jit.c (_initialize_jit): Add declaration.
9469         * language.c (_initialize_language): Add declaration.
9470         * linux-fork.c (_initialize_linux_fork): Add declaration.
9471         * linux-nat.c (_initialize_linux_nat): Add declaration.
9472         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
9473         * linux-thread-db.c (_initialize_thread_db): Add declaration.
9474         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
9475         * m2-lang.c (_initialize_m2_language): Add declaration.
9476         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
9477         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
9478         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
9479         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
9480         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
9481         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
9482         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
9483         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
9484         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
9485         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
9486         * machoread.c (_initialize_machoread): Add declaration.
9487         * macrocmd.c (_initialize_macrocmd): Add declaration.
9488         * macroscope.c (_initialize_macroscope): Add declaration.
9489         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
9490         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
9491         * maint.c (_initialize_maint_cmds): Add declaration.
9492         * mdebugread.c (_initialize_mdebugread): Add declaration.
9493         * memattr.c (_initialize_mem): Add declaration.
9494         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
9495         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
9496         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
9497         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
9498         * mi/mi-main.c (_initialize_mi_main): Add declaration.
9499         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
9500         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
9501         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
9502         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
9503         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
9504         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
9505         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
9506         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
9507         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
9508         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
9509         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
9510         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
9511         * mipsread.c (_initialize_mipsread): Add declaration.
9512         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
9513         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
9514         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
9515         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
9516         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
9517         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
9518         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
9519         * nto-procfs.c (_initialize_procfs): Add declaration.
9520         * objc-lang.c (_initialize_objc_language): Add declaration.
9521         * observable.c (_initialize_observer): Add declaration.
9522         * opencl-lang.c (_initialize_opencl_language): Add declaration.
9523         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
9524         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
9525         * osabi.c (_initialize_gdb_osabi): Add declaration.
9526         * osdata.c (_initialize_osdata): Add declaration.
9527         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
9528         * parse.c (_initialize_parse): Add declaration.
9529         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
9530         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
9531         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
9532         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
9533         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
9534         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
9535         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
9536         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
9537         * printcmd.c (_initialize_printcmd): Add declaration.
9538         * probe.c (_initialize_probe): Add declaration.
9539         * proc-api.c (_initialize_proc_api): Add declaration.
9540         * proc-events.c (_initialize_proc_events): Add declaration.
9541         * proc-service.c (_initialize_proc_service): Add declaration.
9542         * procfs.c (_initialize_procfs): Add declaration.
9543         * producer.c (_initialize_producer): Add declaration.
9544         * psymtab.c (_initialize_psymtab): Add declaration.
9545         * python/python.c (_initialize_python): Add declaration.
9546         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
9547         * record-btrace.c (_initialize_record_btrace): Add declaration.
9548         * record-full.c (_initialize_record_full): Add declaration.
9549         * record.c (_initialize_record): Add declaration.
9550         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
9551         * regcache.c (_initialize_regcache): Add declaration.
9552         * reggroups.c (_initialize_reggroup): Add declaration.
9553         * remote-notif.c (_initialize_notif): Add declaration.
9554         * remote-sim.c (_initialize_remote_sim): Add declaration.
9555         * remote.c (_initialize_remote): Add declaration.
9556         * reverse.c (_initialize_reverse): Add declaration.
9557         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
9558         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
9559         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
9560         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
9561         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
9562         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
9563         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
9564         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
9565         Add declaration.
9566         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
9567         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
9568         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
9569         * rust-exp.y (_initialize_rust_exp): Add declaration.
9570         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
9571         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
9572         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
9573         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
9574         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
9575         * score-tdep.c (_initialize_score_tdep): Add declaration.
9576         * ser-go32.c (_initialize_ser_dos): Add declaration.
9577         * ser-mingw.c (_initialize_ser_windows): Add declaration.
9578         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
9579         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
9580         * ser-uds.c (_initialize_ser_socket): Add declaration.
9581         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
9582         * serial.c (_initialize_serial): Add declaration.
9583         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
9584         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
9585         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
9586         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
9587         * skip.c (_initialize_step_skip): Add declaration.
9588         * sol-thread.c (_initialize_sol_thread): Add declaration.
9589         * solib-aix.c (_initialize_solib_aix): Add declaration.
9590         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
9591         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
9592         * solib-frv.c (_initialize_frv_solib): Add declaration.
9593         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
9594         * solib-target.c (_initialize_solib_target): Add declaration.
9595         * solib.c (_initialize_solib): Add declaration.
9596         * source-cache.c (_initialize_source_cache): Add declaration.
9597         * source.c (_initialize_source): Add declaration.
9598         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
9599         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
9600         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
9601         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
9602         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
9603         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
9604         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
9605         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
9606         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
9607         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
9608         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
9609         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
9610         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
9611         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
9612         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
9613         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
9614         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
9615         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
9616         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
9617         * stabsread.c (_initialize_stabsread): Add declaration.
9618         * stack.c (_initialize_stack): Add declaration.
9619         * stap-probe.c (_initialize_stap_probe): Add declaration.
9620         * std-regs.c (_initialize_frame_reg): Add declaration.
9621         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
9622         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
9623         * symfile.c (_initialize_symfile): Add declaration.
9624         * symmisc.c (_initialize_symmisc): Add declaration.
9625         * symtab.c (_initialize_symtab): Add declaration.
9626         * target.c (_initialize_target): Add declaration.
9627         * target-connection.c (_initialize_target_connection): Add
9628         declaration.
9629         * target-dcache.c (_initialize_target_dcache): Add declaration.
9630         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
9631         * thread.c (_initialize_thread): Add declaration.
9632         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
9633         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
9634         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
9635         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
9636         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
9637         * tracectf.c (_initialize_ctf): Add declaration.
9638         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
9639         * tracefile.c (_initialize_tracefile): Add declaration.
9640         * tracepoint.c (_initialize_tracepoint): Add declaration.
9641         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
9642         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
9643         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
9644         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
9645         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
9646         * tui/tui-win.c (_initialize_tui_win): Add declaration.
9647         * tui/tui.c (_initialize_tui): Add declaration.
9648         * typeprint.c (_initialize_typeprint): Add declaration.
9649         * ui-style.c (_initialize_ui_style): Add declaration.
9650         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
9651         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
9652         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
9653         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
9654         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
9655         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
9656         * unittests/filtered_iterator-selftests.c
9657         (_initialize_filtered_iterator_selftests): Add declaration.
9658         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
9659         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
9660         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
9661         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
9662         * unittests/main-thread-selftests.c
9663         (_initialize_main_thread_selftests): Add declaration.
9664         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
9665         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
9666         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
9667         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
9668         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
9669         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
9670         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
9671         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
9672         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
9673         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
9674         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
9675         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
9676         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
9677         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
9678         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
9679         declaration.
9680         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
9681         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
9682         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
9683         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
9684         * user-regs.c (_initialize_user_regs): Add declaration.
9685         * utils.c (_initialize_utils): Add declaration.
9686         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
9687         * valops.c (_initialize_valops): Add declaration.
9688         * valprint.c (_initialize_valprint): Add declaration.
9689         * value.c (_initialize_values): Add declaration.
9690         * varobj.c (_initialize_varobj): Add declaration.
9691         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
9692         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
9693         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
9694         * windows-nat.c (_initialize_windows_nat): Add declaration.
9695         (_initialize_check_for_gdb_ini): Add declaration.
9696         (_initialize_loadable): Add declaration.
9697         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
9698         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
9699         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
9700         * xcoffread.c (_initialize_xcoffread): Add declaration.
9701         * xml-support.c (_initialize_xml_support): Add declaration.
9702         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
9703         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
9704         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
9705         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
9706
9707 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
9708
9709         * regformats/regdat.sh: Generate declaration for init function.
9710
9711 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
9712
9713         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
9714         up.
9715         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
9716         close_one_inferior>: New methods.
9717         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
9718         pass down target to find_inferior_pid.
9719         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
9720         Pass down target to find_inferior_ptid.
9721         (gdbsim_target::create_inferior): Pass down target to
9722         add_thread_silent.
9723         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
9724         target down to find_inferior_ptid and switch_to_thread.
9725         (gdbsim_target::close): Update to call close_one_inferior.
9726         (struct resume_data): Remove.
9727         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
9728         directly, rather than through a void pointer.
9729         (gdbsim_target::resume): Update to call resume_one_inferior.
9730
9731 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
9732
9733         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
9734
9735 2020-01-12  Pedro Alves  <palves@redhat.com>
9736
9737         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
9738         directly for the current inferior instead of
9739         discard_all_inferiors.
9740         (discard_all_inferiors): Delete.
9741
9742 2020-01-11  Tom Tromey  <tom@tromey.com>
9743
9744         * tui/tui-wingeneral.c (box_win): Check cli_styling.
9745         * tui/tui-winsource.c (tui_source_window_base::refill): Use
9746         deprecated_safe_get_selected_frame.
9747
9748 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
9749
9750         * inferior.c (print_inferior): Switch inferior before printing it.
9751
9752 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
9753             Pedro Alves  <palves@redhat.com>
9754
9755         * progspace-and-thread.c (switch_to_program_space_and_thread):
9756         Assert there's an inferior for PSPACE.  Use
9757         switch_to_inferior_no_thread to switch the inferior too.
9758         * progspace.c (program_space::~program_space): Call
9759         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
9760         (program_space::free_all_objfiles): Don't call clear_symtab_users
9761         here.
9762         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
9763
9764 2020-01-10  Pedro Alves  <palves@redhat.com>
9765
9766         * NEWS: Mention multi-target debugging, "info connections", and
9767         "add-inferior -no-connection".
9768
9769 2020-01-10  Pedro Alves  <palves@redhat.com>
9770
9771         * infrun.c: Include "target-connection.h".
9772         (check_multi_target_resumption): New.
9773         (proceed): Call it.
9774         * target-connection.c (make_target_connection_string): Make
9775         extern.
9776         * target-connection.h (make_target_connection_string): Declare.
9777
9778 2020-01-10  Pedro Alves  <palves@redhat.com>
9779
9780         * Makefile.in (COMMON_SFILES): Add target-connection.c.
9781         * inferior.c (uiout_field_connection): New function.
9782         (print_inferior): Add new "connection-id" column.
9783         (add_inferior_command): Show connection number/string of added
9784         inferior.
9785         * process-stratum-target.h
9786         (process_stratum_target::connection_string): New virtual method.
9787         (process_stratum_target::connection_number): New field.
9788         * remote.c (remote_target::connection_string): New override.
9789         * target-connection.c: New file.
9790         * target-connection.h: New file.
9791         * target.c (decref_target): Remove process_stratum targets from
9792         the connection list.
9793         (target_stack::push): Add process_stratum targets to the
9794         connection list.
9795
9796 2020-01-10  Pedro Alves  <palves@redhat.com>
9797
9798         Revert:
9799         2016-04-12  Pedro Alves  <palves@redhat.com>
9800         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
9801         Remove references to name.
9802         * serial.h (struct serial) <name>: Delete.
9803
9804 2020-01-10  Pedro Alves  <palves@redhat.com>
9805
9806         * gdbarch-selftests.c (register_to_value_test): Remove "target
9807         already pushed" check.
9808
9809 2020-01-10  Pedro Alves  <palves@redhat.com>
9810             John Baldwin  <jhb@FreeBSD.org>
9811
9812         * aarch64-linux-nat.c
9813         (aarch64_linux_nat_target::thread_architecture): Adjust.
9814         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
9815         (task_command_1): Likewise.
9816         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
9817         (aix_thread_target::wait, aix_thread_target::fetch_registers)
9818         (aix_thread_target::store_registers)
9819         (aix_thread_target::thread_alive): Adjust.
9820         * amd64-fbsd-tdep.c: Include "inferior.h".
9821         (amd64fbsd_get_thread_local_address): Pass down target.
9822         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
9823         thread's gdbarch instead of target_gdbarch.
9824         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
9825         get_last_target_status.
9826         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
9827         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
9828         inferiors.
9829         (update_inserted_breakpoint_locations): Skip if inferiors with no
9830         execution.
9831         (update_global_location_list): When handling moribund locations,
9832         find representative inferior for location's pspace, and use thread
9833         count of its process_stratum target.
9834         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
9835         * bsd-uthread.c (bsd_uthread_target::wait): Use
9836         as_process_stratum_target and adjust thread_change_ptid and
9837         add_thread calls.
9838         (bsd_uthread_target::update_thread_list): Use
9839         as_process_stratum_target and adjust find_thread_ptid,
9840         thread_change_ptid and add_thread calls.
9841         * btrace.c (maint_btrace_packet_history_cmd): Adjust
9842         find_thread_ptid call.
9843         * corelow.c (add_to_thread_list): Adjust add_thread call.
9844         (core_target_open): Adjust add_thread_silent and thread_count
9845         calls.
9846         (core_target::pid_to_str): Adjust find_inferior_ptid call.
9847         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
9848         * event-top.c (async_disconnect): Pop targets from all inferiors.
9849         * exec.c (add_target_sections): Push exec target on all inferiors
9850         sharing the program space.
9851         (remove_target_sections): Remove the exec target from all
9852         inferiors sharing the program space.
9853         (exec_on_vfork): New.
9854         * exec.h (exec_on_vfork): Declare.
9855         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
9856         Pass it down.
9857         (fbsd_nat_target::update_thread_list): Adjust.
9858         (fbsd_nat_target::resume): Adjust.
9859         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
9860         down.
9861         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
9862         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
9863         get_thread_arch_regcache call.
9864         * fork-child.c (gdb_startup_inferior): Pass target down to
9865         startup_inferior and set_executing.
9866         * gdbthread.h (struct process_stratum_target): Forward declare.
9867         (add_thread, add_thread_silent, add_thread_with_info)
9868         (in_thread_list): Add process_stratum_target parameter.
9869         (find_thread_ptid(inferior*, ptid_t)): New overload.
9870         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
9871         parameter.
9872         (all_threads()): Delete overload.
9873         (all_threads, all_non_exited_threads): Add process_stratum_target
9874         parameter.
9875         (all_threads_safe): Use brace initialization.
9876         (thread_count): Add process_stratum_target parameter.
9877         (set_resumed, set_running, set_stop_requested, set_executing)
9878         (threads_are_executing, finish_thread_state): Add
9879         process_stratum_target parameter.
9880         (switch_to_thread): Use is_current_thread.
9881         * i386-fbsd-tdep.c: Include "inferior.h".
9882         (i386fbsd_get_thread_local_address): Pass down target.
9883         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
9884         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
9885         have_inferiors check.
9886         * inf-ptrace.c (inf_ptrace_target::create_inferior)
9887         (inf_ptrace_target::attach): Adjust.
9888         * infcall.c (run_inferior_call): Adjust.
9889         * infcmd.c (run_command_1): Pass target to
9890         scoped_finish_thread_state.
9891         (proceed_thread_callback): Skip inferiors with no execution.
9892         (continue_command): Rename 'all_threads' local to avoid hiding
9893         'all_threads' function.  Adjust get_last_target_status call.
9894         (prepare_one_step): Adjust set_running call.
9895         (signal_command): Use user_visible_resume_target.  Compare thread
9896         pointers instead of inferior_ptid.
9897         (info_program_command): Adjust to pass down target.
9898         (attach_command): Mark target's 'thread_executing' flag.
9899         (stop_current_target_threads_ns): New, factored out from ...
9900         (interrupt_target_1): ... this.  Switch inferior before making
9901         target calls.
9902         * inferior-iter.h
9903         (struct all_inferiors_iterator, struct all_inferiors_range)
9904         (struct all_inferiors_safe_range)
9905         (struct all_non_exited_inferiors_range): Filter on
9906         process_stratum_target too.  Remove explicit.
9907         * inferior.c (inferior::inferior): Push dummy target on target
9908         stack.
9909         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
9910         Add process_stratum_target parameter, and pass it down.
9911         (have_live_inferiors): Adjust.
9912         (switch_to_inferior_and_push_target): New.
9913         (add_inferior_command, clone_inferior_command): Handle
9914         "-no-connection" parameter.  Use
9915         switch_to_inferior_and_push_target.
9916         (_initialize_inferior): Mention "-no-connection" option in
9917         the help of "add-inferior" and "clone-inferior" commands.
9918         * inferior.h: Include "process-stratum-target.h".
9919         (interrupt_target_1): Use bool.
9920         (struct inferior) <push_target, unpush_target, target_is_pushed,
9921         find_target_beneath, top_target, process_target, target_at,
9922         m_stack>: New.
9923         (discard_all_inferiors): Delete.
9924         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
9925         (all_inferiors, all_non_exited_inferiors): Add
9926         process_stratum_target parameter.
9927         * infrun.c: Include "gdb_select.h" and <unordered_map>.
9928         (target_last_proc_target): New global.
9929         (follow_fork_inferior): Push target on new inferior.  Pass target
9930         to add_thread_silent.  Call exec_on_vfork.  Handle target's
9931         reference count.
9932         (follow_fork): Adjust get_last_target_status call.  Also consider
9933         target.
9934         (follow_exec): Push target on new inferior.
9935         (struct execution_control_state) <target>: New field.
9936         (user_visible_resume_target): New.
9937         (do_target_resume): Call target_async.
9938         (resume_1): Set target's threads_executing flag.  Consider resume
9939         target.
9940         (commit_resume_all_targets): New.
9941         (proceed): Also consider resume target.  Skip threads of inferiors
9942         with no execution.  Commit resumtion in all targets.
9943         (start_remote): Pass current inferior to wait_for_inferior.
9944         (infrun_thread_stop_requested): Consider target as well.  Pass
9945         thread_info pointer to clear_inline_frame_state instead of ptid.
9946         (infrun_thread_thread_exit): Consider target as well.
9947         (random_pending_event_thread): New inferior parameter.  Use it.
9948         (do_target_wait): Rename to ...
9949         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
9950         down.
9951         (threads_are_resumed_pending_p, do_target_wait): New.
9952         (prepare_for_detach): Adjust calls.
9953         (wait_for_inferior): New inferior parameter.  Handle it.  Use
9954         do_target_wait_1 instead of do_target_wait.
9955         (fetch_inferior_event): Adjust.  Switch to representative
9956         inferior.  Pass target down.
9957         (set_last_target_status): Add process_stratum_target parameter.
9958         Save target in global.
9959         (get_last_target_status): Add process_stratum_target parameter and
9960         handle it.
9961         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
9962         (context_switch): Check inferior_ptid == null_ptid before calling
9963         inferior_thread().
9964         (get_inferior_stop_soon): Pass down target.
9965         (wait_one): Rename to ...
9966         (poll_one_curr_target): ... this.
9967         (struct wait_one_event): New.
9968         (wait_one): New.
9969         (stop_all_threads): Adjust.
9970         (handle_no_resumed, handle_inferior_event): Adjust to consider the
9971         event's target.
9972         (switch_back_to_stepped_thread): Also consider target.
9973         (print_stop_event): Update.
9974         (normal_stop): Update.  Also consider the resume target.
9975         * infrun.h (wait_for_inferior): Remove declaration.
9976         (user_visible_resume_target): New declaration.
9977         (get_last_target_status, set_last_target_status): New
9978         process_stratum_target parameter.
9979         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
9980         process_stratum_target parameter, and use it.
9981         (clear_inline_frame_state (thread_info*)): New.
9982         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
9983         process_stratum_target parameter.
9984         (clear_inline_frame_state (thread_info*)): Declare.
9985         * linux-fork.c (delete_checkpoint_command): Pass target down to
9986         find_thread_ptid.
9987         (checkpoint_command): Adjust.
9988         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
9989         instead of just tweaking inferior_ptid.
9990         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
9991         (exit_lwp): Pass target down to find_thread_ptid.
9992         (attach_proc_task_lwp_callback): Pass target down to
9993         add_thread/set_running/set_executing.
9994         (linux_nat_target::attach): Pass target down to
9995         thread_change_ptid.
9996         (get_detach_signal): Pass target down to find_thread_ptid.
9997         Consider last target status's target.
9998         (linux_resume_one_lwp_throw, resume_lwp)
9999         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
10000         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
10001         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
10002         (linux_nat_target::async_wait_fd): New.
10003         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
10004         target down.
10005         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
10006         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
10007         * linux-thread-db.c (struct thread_db_info::process_target): New
10008         field.
10009         (add_thread_db_info): Save target.
10010         (get_thread_db_info): New process_stratum_target parameter.  Also
10011         match target.
10012         (delete_thread_db_info): New process_stratum_target parameter.
10013         Also match target.
10014         (thread_from_lwp): Adjust to pass down target.
10015         (thread_db_notice_clone): Pass down target.
10016         (check_thread_db_callback): Pass down target.
10017         (try_thread_db_load_1): Always push the thread_db target.
10018         (try_thread_db_load, record_thread): Pass target down.
10019         (thread_db_target::detach): Pass target down.  Always unpush the
10020         thread_db target.
10021         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
10022         target down.  Always unpush the thread_db target.
10023         (find_new_threads_callback, thread_db_find_new_threads_2)
10024         (thread_db_target::update_thread_list): Pass target down.
10025         (thread_db_target::pid_to_str): Pass current inferior down.
10026         (thread_db_target::get_thread_local_address): Pass target down.
10027         (thread_db_target::resume, maintenance_check_libthread_db): Pass
10028         target down.
10029         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
10030         * procfs.c (procfs_target::procfs_init_inferior): Declare.
10031         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
10032         (procfs_init_inferior): Rename to ...
10033         (procfs_target::procfs_init_inferior): ... this and adjust.
10034         (procfs_target::create_inferior, procfs_notice_thread)
10035         (procfs_do_thread_registers): Adjust.
10036         * ppc-fbsd-tdep.c: Include "inferior.h".
10037         (ppcfbsd_get_thread_local_address): Pass down target.
10038         * proc-service.c (ps_xfer_memory): Switch current inferior and
10039         program space as well.
10040         (get_ps_regcache): Pass target down.
10041         * process-stratum-target.c
10042         (process_stratum_target::thread_address_space)
10043         (process_stratum_target::thread_architecture): Pass target down.
10044         * process-stratum-target.h
10045         (process_stratum_target::threads_executing): New field.
10046         (as_process_stratum_target): New.
10047         * ravenscar-thread.c
10048         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
10049         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
10050         down.
10051         * record-btrace.c (record_btrace_target::info_record): Adjust.
10052         (record_btrace_target::record_method)
10053         (record_btrace_target::record_is_replaying)
10054         (record_btrace_target::fetch_registers)
10055         (get_thread_current_frame_id, record_btrace_target::resume)
10056         (record_btrace_target::wait, record_btrace_target::stop): Pass
10057         target down.
10058         * record-full.c (record_full_wait_1): Switch to event thread.
10059         Pass target down.
10060         * regcache.c (regcache::regcache)
10061         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
10062         process_stratum_target parameter and handle it.
10063         (current_thread_target): New global.
10064         (get_thread_regcache): Add process_stratum_target parameter and
10065         handle it.  Switch inferior before calling target method.
10066         (get_thread_regcache): Pass target down.
10067         (get_thread_regcache_for_ptid): Pass target down.
10068         (registers_changed_ptid): Add process_stratum_target parameter and
10069         handle it.
10070         (registers_changed_thread, registers_changed): Pass target down.
10071         (test_get_thread_arch_aspace_regcache): New.
10072         (current_regcache_test): Define a couple local test_target_ops
10073         instances and use them for testing.
10074         (readwrite_regcache): Pass process_stratum_target parameter.
10075         (cooked_read_test, cooked_write_test): Pass mock_target down.
10076         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
10077         (get_thread_arch_aspace_regcache): Add process_stratum_target
10078         parameter.
10079         (regcache::target): New method.
10080         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
10081         (regcache::registers_changed_ptid): Add process_stratum_target
10082         parameter.
10083         (regcache::m_target): New field.
10084         (registers_changed_ptid): Add process_stratum_target parameter.
10085         * remote.c (remote_state::supports_vCont_probed): New field.
10086         (remote_target::async_wait_fd): New method.
10087         (remote_unpush_and_throw): Add remote_target parameter.
10088         (get_current_remote_target): Adjust.
10089         (remote_target::remote_add_inferior): Push target.
10090         (remote_target::remote_add_thread)
10091         (remote_target::remote_notice_new_inferior)
10092         (get_remote_thread_info): Pass target down.
10093         (remote_target::update_thread_list): Skip threads of inferiors
10094         bound to other targets.  (remote_target::close): Don't discard
10095         inferiors.  (remote_target::add_current_inferior_and_thread)
10096         (remote_target::process_initial_stop_replies)
10097         (remote_target::start_remote)
10098         (remote_target::remote_serial_quit_handler): Pass down target.
10099         (remote_target::remote_unpush_target): New remote_target
10100         parameter.  Unpush the target from all inferiors.
10101         (remote_target::remote_unpush_and_throw): New remote_target
10102         parameter.  Pass it down.
10103         (remote_target::open_1): Check whether the current inferior has
10104         execution instead of checking whether any inferior is live.  Pass
10105         target down.
10106         (remote_target::remote_detach_1): Pass down target.  Use
10107         remote_unpush_target.
10108         (extended_remote_target::attach): Pass down target.
10109         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
10110         (remote_target::append_resumption): Pass down target.
10111         (remote_target::append_pending_thread_resumptions)
10112         (remote_target::remote_resume_with_hc, remote_target::resume)
10113         (remote_target::commit_resume): Pass down target.
10114         (remote_target::remote_stop_ns): Check supports_vCont_probed.
10115         (remote_target::interrupt_query)
10116         (remote_target::remove_new_fork_children)
10117         (remote_target::check_pending_events_prevent_wildcard_vcont)
10118         (remote_target::remote_parse_stop_reply)
10119         (remote_target::process_stop_reply): Pass down target.
10120         (first_remote_resumed_thread): New remote_target parameter.  Pass
10121         it down.
10122         (remote_target::wait_as): Pass down target.
10123         (unpush_and_perror): New remote_target parameter.  Pass it down.
10124         (remote_target::readchar, remote_target::remote_serial_write)
10125         (remote_target::getpkt_or_notif_sane_1)
10126         (remote_target::kill_new_fork_children, remote_target::kill): Pass
10127         down target.
10128         (remote_target::mourn_inferior): Pass down target.  Use
10129         remote_unpush_target.
10130         (remote_target::core_of_thread)
10131         (remote_target::remote_btrace_maybe_reopen): Pass down target.
10132         (remote_target::pid_to_exec_file)
10133         (remote_target::thread_handle_to_thread_info): Pass down target.
10134         (remote_target::async_wait_fd): New.
10135         * riscv-fbsd-tdep.c: Include "inferior.h".
10136         (riscv_fbsd_get_thread_local_address): Pass down target.
10137         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
10138         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
10139         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
10140         Adjust.
10141         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
10142         * solib-svr4.c (enable_break): Pass down target.
10143         * spu-multiarch.c (parse_spufs_run): Pass down target.
10144         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
10145         * target-delegates.c: Regenerate.
10146         * target.c (g_target_stack): Delete.
10147         (current_top_target): Return the current inferior's top target.
10148         (target_has_execution_1): Refer to the passed-in inferior's top
10149         target.
10150         (target_supports_terminal_ours): Check whether the initial
10151         inferior was already created.
10152         (decref_target): New.
10153         (target_stack::push): Incref/decref the target.
10154         (push_target, push_target, unpush_target): Adjust.
10155         (target_stack::unpush): Defref target.
10156         (target_is_pushed): Return bool.  Adjust to refer to the current
10157         inferior's target stack.
10158         (dispose_inferior): Delete, and inline parts ...
10159         (target_preopen): ... here.  Only dispose of the current inferior.
10160         (target_detach): Hold strong target reference while detaching.
10161         Pass target down.
10162         (target_thread_name): Add assertion.
10163         (target_resume): Pass down target.
10164         (target_ops::beneath, find_target_at): Adjust to refer to the
10165         current inferior's target stack.
10166         (get_dummy_target): New.
10167         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
10168         has a thread running.
10169         (initialize_targets): Rename to ...
10170         (_initialize_target): ... this.
10171         * target.h: Include "gdbsupport/refcounted-object.h".
10172         (struct target_ops): Inherit refcounted_object.
10173         (target_ops::shortname, target_ops::longname): Make const.
10174         (target_ops::async_wait_fd): New method.
10175         (decref_target): Declare.
10176         (struct target_ops_ref_policy): New.
10177         (target_ops_ref): New typedef.
10178         (get_dummy_target): Declare function.
10179         (target_is_pushed): Return bool.
10180         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
10181         (all_matching_threads_iterator::all_matching_threads_iterator):
10182         Handle filter target.
10183         * thread-iter.h (struct all_matching_threads_iterator, struct
10184         all_matching_threads_range, class all_non_exited_threads_range):
10185         Filter by target too.  Remove explicit.
10186         * thread.c (threads_executing): Delete.
10187         (inferior_thread): Pass down current inferior.
10188         (clear_thread_inferior_resources): Pass down thread pointer
10189         instead of ptid_t.
10190         (add_thread_silent, add_thread_with_info, add_thread): Add
10191         process_stratum_target parameter.  Use it for thread and inferior
10192         searches.
10193         (is_current_thread): New.
10194         (thread_info::deletable): Use it.
10195         (find_thread_ptid, thread_count, in_thread_list)
10196         (thread_change_ptid, set_resumed, set_running): New
10197         process_stratum_target parameter.  Pass it down.
10198         (set_executing): New process_stratum_target parameter.  Pass it
10199         down.  Adjust reference to 'threads_executing'.
10200         (threads_are_executing): New process_stratum_target parameter.
10201         Adjust reference to 'threads_executing'.
10202         (set_stop_requested, finish_thread_state): New
10203         process_stratum_target parameter.  Pass it down.
10204         (switch_to_thread): Also match inferior.
10205         (switch_to_thread): New process_stratum_target parameter.  Pass it
10206         down.
10207         (update_threads_executing): Reimplement.
10208         * top.c (quit_force): Pop targets from all inferior.
10209         (gdb_init): Don't call initialize_targets.
10210         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
10211         Declare.
10212         (windows_add_thread, windows_delete_thread): Adjust.
10213         (get_windows_debug_event): Rename to ...
10214         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
10215         * tracefile-tfile.c (tfile_target_open): Pass down target.
10216         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
10217         Forward declare.
10218         (switch_to_thread): Add process_stratum_target parameter.
10219         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
10220         parameter.  Use it.
10221         (mi_on_resume): Pass target down.
10222         * nat/fork-inferior.c (startup_inferior): Add
10223         process_stratum_target parameter.  Pass it down.
10224         * nat/fork-inferior.h (startup_inferior): Add
10225         process_stratum_target parameter.
10226         * python/py-threadevent.c (py_get_event_thread): Pass target down.
10227
10228 2020-01-10  Pedro Alves  <palves@redhat.com>
10229
10230         * remote.c (remote_target::start_remote): Don't set inferior_ptid
10231         directly.  Instead find the first thread in the thread list and
10232         use switch_to_thread.
10233
10234 2020-01-10  Pedro Alves  <palves@redhat.com>
10235
10236         * remote.c (remote_target::remote_add_inferior): Don't bind a
10237         process to the current inferior if the current inferior is already
10238         bound to a process.
10239
10240 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
10241             Pedro Alves  <palves@redhat.com>
10242
10243         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
10244         If no process is specified, return null_ptid instead of
10245         inferior_ptid.
10246         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
10247         TARGET_WAITKIND_SIGNALLED with no pid.
10248
10249 2020-01-10  Pedro Alves  <palves@redhat.com>
10250
10251         * remote.c (first_remote_resumed_thread): New.
10252         (remote_target::wait_as): Use it as default event_ptid instead of
10253         inferior_ptid.
10254
10255 2020-01-10  Pedro Alves  <palves@redhat.com>
10256
10257         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
10258
10259 2020-01-10  Pedro Alves  <palves@redhat.com>
10260
10261         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
10262         not -1.
10263
10264 2020-01-10  Pedro Alves  <palves@redhat.com>
10265
10266         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
10267         ptid to get_last_target_status.
10268         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
10269         ptid to get_last_target_status.
10270         * infcmd.c (continue_command): Don't pass a target_waitstatus to
10271         get_last_target_status.
10272         (info_program_command): Don't pass a target_waitstatus to
10273         get_last_target_status.
10274         * infrun.c (init_wait_for_inferior): Use
10275         nullify_last_target_wait_ptid.
10276         (get_last_target_status): Handle nullptr arguments.
10277         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
10278         (print_stop_event): Don't pass a ptid to get_last_target_status.
10279         (normal_stop): Don't pass a ptid to get_last_target_status.
10280         * infrun.h (get_last_target_status, set_last_target_status): Move
10281         comments here and update.
10282         (nullify_last_target_wait_ptid): Declare.
10283         * linux-fork.c (fork_load_infrun_state): Remove local extern
10284         declaration of nullify_last_target_wait_ptid.
10285         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
10286         to get_last_target_status.
10287
10288 2020-01-10  Pedro Alves  <palves@redhat.com>
10289
10290         * gdbthread.h (scoped_restore_current_thread)
10291         <dont_restore, restore, m_dont_restore>: Declare.
10292         * thread.c (thread_alive): Add assertion.  Return bool.
10293         (switch_to_thread_if_alive): New.
10294         (prune_threads): Switch inferior/thread.
10295         (print_thread_info_1): Switch thread before calling target methods.
10296         (scoped_restore_current_thread::restore): New, factored out from
10297         ...
10298         (scoped_restore_current_thread::~scoped_restore_current_thread):
10299         ... this.
10300         (scoped_restore_current_thread::scoped_restore_current_thread):
10301         Add assertion.
10302         (thread_apply_all_command, thread_select): Use
10303         switch_to_thread_if_alive.
10304         * infrun.c (proceed, restart_threads, handle_signal_stop)
10305         (switch_back_to_stepped_thread): Switch current thread before
10306         calling target methods.
10307
10308 2020-01-10  Pedro Alves <palves@redhat.com>
10309
10310         * inferior.c (switch_to_inferior_no_thread): New function,
10311         factored out from ...
10312         (inferior_command): ... here.
10313         * inferior.h (switch_to_inferior_no_thread): Declare.
10314         * mi/mi-main.c (run_one_inferior): Use
10315         switch_to_inferior_no_thread.
10316
10317 2020-01-10  Pedro Alves  <palves@redhat.com>
10318
10319         * infcmd.c (kill_command): Remove dead code.
10320
10321 2020-01-10  Pedro Alves  <palves@redhat.com>
10322
10323         * remote.c (remote_target::mourn_inferior): No longer check
10324         whether the target is running.
10325
10326 2020-01-10  Pedro Alves  <palves@redhat.com>
10327
10328         * corelow.c (core_target::has_execution): Change parameter type to
10329         inferior pointer.
10330         * inferior.c (number_of_live_inferiors): Use
10331         inferior::has_execution instead of target_has_execution_1.
10332         * inferior.h (inferior::has_execution): New.
10333         * linux-thread-db.c (thread_db_target::update_thread_list): Use
10334         inferior::has_execution instead of target_has_execution_1.
10335         * process-stratum-target.c
10336         (process_stratum_target::has_execution): Change parameter type to
10337         inferior pointer.  Check the inferior's PID instead of
10338         inferior_ptid.
10339         * process-stratum-target.h
10340         (process_stratum_target::has_execution): Change parameter type to
10341         inferior pointer.
10342         * record-full.c (record_full_core_target::has_execution): Change
10343         parameter type to inferior pointer.
10344         * target.c (target_has_execution_1): Change parameter type to
10345         inferior pointer.
10346         (target_has_execution_current): Adjust.
10347         * target.h (target_ops::has_execution): Change parameter type to
10348         inferior pointer.
10349         (target_has_execution_1): Change parameter type to inferior
10350         pointer.  Change return type to bool.
10351         * tracefile.h (tracefile_target::has_execution): Change parameter
10352         type to inferior pointer.
10353
10354 2020-01-10  Pedro Alves  <palves@redhat.com>
10355
10356         * exceptions.c (print_flush): Remove current_top_target() check.
10357
10358 2020-01-10  Pedro Alves  <palves@redhat.com>
10359
10360         * remote.c (show_remote_exec_file): Show the current inferior's
10361         exec-file instead of the command variable's value.
10362
10363 2020-01-10  Pedro Alves  <palves@redhat.com>
10364
10365         * record-full.c (record_full_resume_ptid): New global.
10366         (record_full_target::resume): Set it.
10367         (record_full_wait_1): Use record_full_resume_ptid instead of
10368         inferior_ptid.
10369
10370 2020-01-10  Pedro Alves  <palves@redhat.com>
10371
10372         * gdbthread.h (scoped_restore_current_thread)
10373         <dont_restore, restore, m_dont_restore>: Declare.
10374         * thread.c (thread_alive): Add assertion.  Return bool.
10375         (switch_to_thread_if_alive): New.
10376         (prune_threads): Switch inferior/thread.
10377         (print_thread_info_1): Switch thread before calling target methods.
10378         (scoped_restore_current_thread::restore): New, factored out from
10379         ...
10380         (scoped_restore_current_thread::~scoped_restore_current_thread):
10381         ... this.
10382         (scoped_restore_current_thread::scoped_restore_current_thread):
10383         Add assertion.
10384         (thread_apply_all_command, thread_select): Use
10385         switch_to_thread_if_alive.
10386
10387 2020-01-10  George Barrett  <bob@bob131.so>
10388
10389         * stap-probe.c (stap_modify_semaphore): Don't check for null
10390         semaphores.
10391         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
10392         for null semaphores.
10393
10394 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10395
10396         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
10397         all source windows, and maintain horizontal scroll status while
10398         doing so.
10399
10400 2020-01-09  Tom Tromey  <tom@tromey.com>
10401
10402         PR tui/18932:
10403         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
10404         update_source_window, not print_source_lines.
10405
10406 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10407
10408         * tui/tui.c (tui_enable): Register tui hooks after calling
10409         tui_display_main.
10410
10411 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
10412
10413         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
10414
10415 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
10416
10417         * thread.c (print_thread_info_1): Fix indentation.
10418
10419 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
10420
10421         * symtab.c (general_symbol_info::compute_and_set_names): Move the
10422         unique_xmalloc_ptr outside the if to always free the demangled name.
10423
10424 2020-01-08  Tom Tromey  <tromey@adacore.com>
10425
10426         * xcoffread.c (enter_line_range, read_xcoff_symtab)
10427         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
10428         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
10429         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
10430         Remove.
10431         (section_offsets): New typedef.
10432         * symtab.c (fixup_section, get_msymbol_address): Update.
10433         * symmisc.c (dump_msymbols): Update.
10434         * symfile.h (relative_addr_info_to_section_offsets)
10435         (symfile_map_offsets_to_segments): Update.
10436         * symfile.c (build_section_addr_info_from_objfile)
10437         (init_objfile_sect_indices): Update.
10438         (struct place_section_arg): Change type of "offsets".
10439         (place_section): Update.
10440         (relative_addr_info_to_section_offsets): Change type of
10441         "section_offsets".  Remove "num_sections" parameter.
10442         (default_symfile_offsets, syms_from_objfile_1)
10443         (set_objfile_default_section_offset): Update.
10444         (reread_symbols): No need to preserve section offsets by hand.
10445         (symfile_map_offsets_to_segments): Change type of "offsets".
10446         * stap-probe.c (relocate_address): Update.
10447         * stabsread.h (process_one_symbol): Update.
10448         * solib-target.c (struct lm_info_target) <offsets>: Change type.
10449         (solib_target_relocate_section_addresses): Update.
10450         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
10451         Update.
10452         * solib-frv.c (frv_relocate_main_executable): Update.
10453         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
10454         * solib-aix.c (solib_aix_get_section_offsets): Change return
10455         type.
10456         (solib_aix_solib_create_inferior_hook): Update.
10457         * remote.c (remote_target::get_offsets): Update.
10458         * psymtab.c (find_pc_sect_psymtab): Update.
10459         * psympriv.h (struct partial_symbol) <address, text_low,
10460         text_high>: Update.
10461         * objfiles.h (obj_section_offset): Update.
10462         (struct objfile) <section_offsets>: Change type.
10463         <num_sections>: Remove.
10464         (objfile_relocate): Update.
10465         * objfiles.c (entry_point_address_query): Update
10466         (relocate_one_symbol): Change type of "section_offsets".
10467         (objfile_relocate1, objfile_relocate1): Change type of
10468         "new_offsets".
10469         (objfile_rebase1): Update.
10470         * mipsread.c (mipscoff_symfile_read): Update.
10471         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
10472         parameter.
10473         * mdebugread.c (parse_symbol): Change type of "section_offsets".
10474         (parse_external, psymtab_to_symtab_1): Update.
10475         * machoread.c (macho_symfile_offsets): Update.
10476         * ia64-tdep.c (ia64_find_unwind_table): Update.
10477         * hppa-tdep.c (read_unwind_info): Update.
10478         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
10479         * dwarf2read.c (create_addrmap_from_index)
10480         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10481         (process_psymtab_comp_unit_reader, add_partial_symbol)
10482         (add_partial_subprogram, process_full_comp_unit)
10483         (read_file_scope, read_func_scope, read_lexical_block_scope)
10484         (read_call_site_scope, dwarf2_rnglists_process)
10485         (dwarf2_ranges_process, dwarf2_ranges_read)
10486         (dwarf_decode_lines_1, var_decode_location, new_symbol)
10487         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
10488         Update.
10489         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
10490         Update.
10491         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
10492         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
10493         (process_one_symbol): Change type of "section_offsets".
10494         * ctfread.c (get_objfile_text_range): Update.
10495         * coffread.c (coff_symtab_read, enter_linenos)
10496         (process_coff_symbol): Update.
10497         * coff-pe-read.c (add_pe_forwarded_sym): Update.
10498         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
10499
10500 2020-01-08  Tom Tromey  <tromey@adacore.com>
10501
10502         * dwarf2read.c (parse_macro_definition): Use std::string.
10503         (parse_macro_definition): Likewise.
10504
10505 2020-01-08  Tom Tromey  <tromey@adacore.com>
10506
10507         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
10508         (ATTR_ALLOC_CHUNK): Remove.
10509
10510 2020-01-08  Tom Tromey  <tromey@adacore.com>
10511
10512         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
10513
10514 2020-01-08  Tom Tromey  <tromey@adacore.com>
10515
10516         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
10517         (dwarf2_compute_name, open_dwo_file): Likewise.
10518         (process_enumeration_scope): Use std::vector.
10519         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
10520         (partial_die_info::fixup, dwarf2_start_subfile)
10521         (guess_full_die_structure_name, dwarf2_name): Likewise.
10522         (determine_prefix): Update.
10523         (guess_full_die_structure_name): Make return type const.
10524         (partial_die_full_name): Return unique_xmalloc_ptr.
10525         (DW_FIELD_ALLOC_CHUNK): Remove.
10526
10527 2020-01-07  Tom Tromey  <tromey@adacore.com>
10528
10529         PR build/24937:
10530         * stap-probe.c (class stap_static_probe_ops): Add constructor.
10531
10532 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
10533
10534         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
10535
10536 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10537
10538         * stack.c (print_frame_info): Move disassemble_next_line code
10539         inside source_print block.
10540
10541 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10542
10543         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
10544         gdb/signals.h, as we are now using native signal symbols.
10545
10546 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
10547
10548         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
10549         overflow by an early check of content vs threshold.
10550         * tui/tui-source.c (tui_source_window::line_is_displayed):
10551         Likewise.
10552
10553 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10554
10555         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
10556
10557 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
10558
10559         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
10560         export table if no section contains it's RVA.
10561
10562 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10563
10564         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
10565
10566 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
10567
10568         * source.c (print_source_lines_base): Set last_line_listed.
10569
10570 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
10571
10572         * tui/tui-disasm.c: Remove trailing spaces.
10573
10574 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10575             Pedro Alves  <palves@redhat.com>
10576
10577         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
10578         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
10579         (windows_gdb_signal_to_target): New function, uses the above
10580         enumeration to convert GDB internal signal codes to equivalent
10581         Windows codes.
10582         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
10583         * windows-nat.c: Include "gdb_wait.h".
10584         (get_windows_debug_event): Extract the fatal exception from the
10585         exit status and convert to the equivalent Posix signal number.
10586         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
10587         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
10588         * gdbsupport/gdb_wait.c: New file, implements
10589         windows_status_to_termsig.
10590         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
10591         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
10592
10593 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
10594
10595         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
10596         show_layout.
10597
10598 2020-01-05  Luis Machado  <luis.machado@linaro.org>
10599
10600         * aarch64-linux-nat.c
10601         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
10602         and bfd_mach_aarch64.
10603
10604 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10605
10606         * ui-file.c (stdio_file::can_emit_style_escape)
10607         (tee_file::can_emit_style_escape): Ensure style is used also on
10608         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
10609         to gdb_stdout.
10610         * main.c (set_gdb_data_directory): Use file style to output the
10611         warning that the given pathname is not a directory.
10612         * top.c (show_history_filename, gdb_safe_append_history)
10613         (show_gdb_datadir): Use file style.
10614
10615 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
10616
10617         * solib-target.c (struct lm_info_target):
10618         Change offsets to be a unique_xmalloc_ptr.
10619         (solib_target_relocate_section_addresses): Update.
10620
10621 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
10622
10623         * windows-nat.c (windows_clear_solib): Free so_list linked list.
10624
10625 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
10626
10627         * MAINTAINERS (Write After Approval): Add myself.
10628
10629 2020-01-02  Luis Machado  <luis.machado@linaro.org>
10630
10631         * proc-service.c (get_ps_regcache): Remove reference to obsolete
10632         Cell BE architecture.
10633         * target.h (struct target_ops) <thread_architecture>: Likewise.
10634
10635 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
10636
10637         * Makefile.in: Use INSTALL_PROGRAM_ENV.
10638
10639 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
10640
10641         * MAINTAINERS (Write After Approval): Add myself.
10642
10643 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10644
10645         * gdbarch.sh: Update copyright year range of generated files.
10646
10647 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10648
10649         Update copyright year range in all GDB files.
10650
10651 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10652
10653         * copyright.py: Convert to Python 3.
10654
10655 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10656
10657         * copyright.py: Adapt after move of gnulib directory from gdb
10658         directory to toplevel directory.
10659
10660 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10661
10662         * copyright.py (main): Exit if run from the wrong directory.
10663
10664 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10665
10666         * top.c (print_gdb_version): Change copyright year to 2020.
10667
10668 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10669
10670         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
10671
10672 For older changes see ChangeLog-2019.
10673 \f
10674 Local Variables:
10675 mode: change-log
10676 left-margin: 8
10677 fill-column: 74
10678 version-control: never
10679 coding: utf-8
10680 End: