gdb/ChangeLog

   1 2019-03-24  Tom Tromey  <tom@tromey.com>
   2
   3         * expression.h: Don't include symtab.h.
   4         (struct block): Forward declare.
   5
   6 2019-03-24  Tom Tromey  <tom@tromey.com>
   7
   8         * c-exp.y (typebase): Remove casts.
   9         * gdbtypes.c (lookup_unsigned_typename, )
  10         (lookup_signed_typename): Remove cast.
  11         * eval.c (parse_to_comma_and_eval): Remove cast.
  12         * parse.c (write_dollar_variable): Remove cast.
  13         * block.h (struct block) <superblock>: Now const.
  14         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
  15         * psymtab.c (psym_map_matching_symbols): Make "block" const.
  16         (map_block): Make "block" const.
  17         * symfile.h (struct quick_symbol_functions)
  18         <map_matching_symbols>: Constify block argument to "callback".
  19         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
  20         const.
  21         (find_pc_sect_compunit_symtab): Make "b" const.
  22         (find_symbol_at_address): Likewise.
  23         (search_symbols): Likewise.
  24         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
  25         (dw2_debug_names_lookup_symbol): Likewise.
  26         (dw2_map_matching_symbols): Update.
  27         * p-valprint.c (pascal_val_print): Remove "block".
  28         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
  29         (aux_add_nonlocal_symbols): Make "block" const.
  30         (resolve_subexp): Remove cast.
  31         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
  32         const.
  33         (iterate_over_file_blocks): Likewise.
  34         * f-exp.y (%union) <bval>: Remove.
  35         * coffread.c (patch_opaque_types): Make "b" const.
  36         * spu-tdep.c (spu_catch_start): Make "block" const.
  37         * c-valprint.c (print_unpacked_pointer): Remove "block".
  38         * symmisc.c (dump_symtab_1): Make "b" const.
  39         (block_depth): Make "block" const.
  40         * d-exp.y (%union) <bval>: Remove.
  41         * cp-support.h (cp_lookup_rtti_type): Update.
  42         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
  43         * psymtab.c (psym_lookup_symbol): Make "block" const.
  44         (maintenance_check_psymtabs): Make "b" const.
  45         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
  46         (enumerate_locals, enumerate_args): Update.
  47         * python/py-symtab.c (stpy_global_block): Make "block" const.
  48         (stpy_static_block): Likewise.
  49         * inline-frame.c (block_starting_point_at): Make "new_block"
  50         const.
  51         * block.c (find_block_in_blockvector): Make return type const.
  52         (blockvector_for_pc_sect): Make "b" const.
  53         (find_block_in_blockvector): Make "b" const.
  54
  55 2019-03-23  Tom Tromey  <tom@tromey.com>
  56
  57         * varobj.c (varobj_create): Update.
  58         * symfile.c (clear_symtab_users): Don't reset innermost_block.
  59         * printcmd.c (display_command, do_one_display): Don't reset
  60         innermost_block.
  61         * parser-defs.h (enum innermost_block_tracker_type): Move to
  62         expression.h.
  63         (innermost_block): Update comment.
  64         * parse.c (parse_exp_1): Add tracker_types parameter.
  65         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
  66         tracker_types parameter.  Reset innermost_block.
  67         (parse_exp_in_context): Remove.
  68         (parse_expression_for_completion): Update.
  69         * objfiles.c (~objfile): Don't reset expression_context_block or
  70         innermost_block.
  71         * expression.h (enum innermost_block_tracker_type): Move from
  72         parser-defs.h.
  73         (parse_exp_1): Add tracker_types parameter.
  74         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
  75         reset innermost_block.
  76
  77 2019-03-23  Tom Tromey  <tom@tromey.com>
  78
  79         * objfiles.h: Include bcache.h.
  80
  81 2019-03-23  Tom Tromey  <tom@tromey.com>
  82
  83         * linespec.c (get_current_search_block): Use
  84         scoped_restore_current_language.
  85         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
  86
  87 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
  88             Jiong Wang  <jiong.wang@arm.com>
  89
  90         * aarch64-linux-tdep.c
  91         (aarch64_linux_iterate_over_regset_sections): Check for pauth
  92         section.
  93         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
  94
  95 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
  96             Jiong Wang  <jiong.wang@arm.com>
  97
  98         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
  99         instructions.
 100         (aarch64_analyze_prologue_test): Add PACIASP test.
 101         (aarch64_prologue_prev_register): Unmask PC value.
 102
 103 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 104             Jiong Wang  <jiong.wang@arm.com>
 105
 106         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 107         (aarch64_dwarf2_prev_register): Unmask PC value.
 108         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 109         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 110         DW_CFA_AARCH64_negate_ra_state.
 111         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 112
 113 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 114             Jiong Wang  <jiong.wang@arm.com>
 115
 116         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 117         registers.
 118         (aarch64_pseudo_register_name): Likewise.
 119         (aarch64_pseudo_register_type): Likewise.
 120         (aarch64_pseudo_register_reggroup_p): Likewise.
 121         (aarch64_gdbarch_init): Add pauth registers.
 122         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 123         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 124         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 125         (struct gdbarch_tdep): Add regnum for ra_state.
 126
 127 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 128             Jiong Wang  <jiong.wang@arm.com>
 129
 130         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 131
 132 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 133             Jiong Wang  <jiong.wang@arm.com>
 134
 135         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 136         function.
 137         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 138         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 139         (aarch64_gdbarch_init): Add puth registers.
 140         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 141         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 142         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 143
 144 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 145             Jiong Wang  <jiong.wang@arm.com>
 146
 147         * aarch64-linux-nat.c
 148         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 149         * aarch64-linux-tdep.c
 150         (aarch64_linux_core_read_description): Likewise.
 151         (aarch64_linux_get_hwcap): New function.
 152         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 153         (aarch64_linux_get_hwcap): New declaration.
 154
 155 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 156             Jiong Wang  <jiong.wang@arm.com>
 157
 158         * aarch64-linux-nat.c
 159         (aarch64_linux_nat_target::read_description): Add pauth param.
 160         * aarch64-linux-tdep.c
 161         (aarch64_linux_core_read_description): Likewise.
 162         * aarch64-tdep.c (struct target_desc): Add in pauth.
 163         (aarch64_read_description): Add pauth param.
 164         (aarch64_gdbarch_init): Likewise.
 165         * aarch64-tdep.h (aarch64_read_description): Likewise.
 166         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 167         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 168         * features/Makefile: Add new files.
 169         * features/aarch64-pauth.c: New file.
 170         * features/aarch64-pauth.xml: New file.
 171
 172 2019-03-20  Tom Tromey  <tromey@adacore.com>
 173
 174         * infrun.c (handle_inferior_event): Rename from
 175         handle_inferior_event_1.  Create a scoped_value_mark.
 176         (handle_inferior_event): Remove.
 177
 178 2019-03-19  Tom Tromey  <tromey@adacore.com>
 179
 180         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 181         * infrun.h (print_stop_event): Add "displays" parameter.
 182         * infrun.c (print_stop_event): Add "displays" parameter.
 183
 184 2019-03-19  Pedro Alves  <palves@redhat.com>
 185
 186         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 187         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 188         to -1.  Fix TABs vs spaces.
 189         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 190         * tui/tui-out.h (tui_ui_out) Add intro comments.
 191         <m_line, m_start_of_line>: In-class initialize, and add describing
 192         comment.
 193
 194 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 195
 196         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 197         variable names.
 198         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 199
 200 2019-03-18  Pedro Alves  <palves@redhat.com>
 201             Eli Zaretskii <eliz@gnu.org>
 202
 203         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 204         m_line and m_start_of_line.
 205
 206 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 207
 208         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 209         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 210         it returns a newline.  This fixes a regression in TU mode, whereby
 211         the next line is output on the same screen line as the user input.
 212
 213 2019-03-18  Tom Tromey  <tromey@adacore.com>
 214
 215         * minsyms.c (minimal_symbol_reader::install): Remove call to
 216         obstack_blank.
 217
 218 2019-03-18  Pedro Alves  <palves@redhat.com>
 219
 220         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 221         New globals.
 222         (apply_style): New, factored out from ...
 223         (apply_ansi_escape): ... this.  Handle reverse video mode.
 224         (tui_set_reverse_mode): New function.
 225         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 226         * tui/tui-winsource.c (tui_show_source_line): Use
 227         tui_set_reverse_mode instead of setting A_STANDOUT.
 228         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 229         New setter methods.
 230
 231 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 232
 233         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 234         Handle tabs.
 235
 236 2019-03-18  Tom Tromey  <tromey@adacore.com>
 237
 238         * ada-lang.c (empty_array): Add "high" parameter.
 239         (ada_evaluate_subexp): Update.
 240
 241 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 242
 243         * unittests/string_view-selftests.c: Define
 244         _initialize_string_view_selftests unconditionally.
 245
 246 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 247
 248         PR gdb/24350
 249         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 250
 251 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 252
 253         PR gdb/24351
 254         * windows-nat.c (display_selector): Fix format specifiers.
 255
 256 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 257
 258         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 259         tui_refill_source_window instead of tui_refresh_win, to update the
 260         current execution line.  This fixes redisplay of the current line
 261         when stepping through the code with "next" or "step".
 262
 263 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 264
 265         * source-cache.c (source_cache::get_source_lines): Call
 266         find_source_lines to initialize s->nlines.  This fixes vertical
 267         scrolling of TUI source window when the DOWN arrow is pressed.
 268
 269 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 270
 271         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 272         linux-thread-db.c (_initialize_thread_db): Likewise.
 273
 274 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 275
 276         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 277         wclrtoeol in tui_show_source_line".  This reverts changes made in
 278         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 279
 280 2019-03-15  Tom Tromey  <tom@tromey.com>
 281
 282         * symtab.h (struct minimal_symbol): Derive from
 283         general_symbol_info.
 284         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 285         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 286         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 287         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 288         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 289         (MSYMBOL_SEARCH_NAME): Update.
 290         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 291         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 292         * minsyms.c (minimal_symbol_reader::record_full): Update.
 293
 294 2019-03-15  Tom Tromey  <tom@tromey.com>
 295
 296         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 297
 298 2019-03-15  Tom Tromey  <tom@tromey.com>
 299
 300         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 301         unique_xmalloc_ptr.
 302         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 303         Update.
 304         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 305         (build_minimal_symbol_hash_tables)
 306         (minimal_symbol_reader::install): Update.
 307
 308 2019-03-15  Tom Tromey  <tom@tromey.com>
 309
 310         * symtab.c (create_demangled_names_hash): Update.
 311         (symbol_set_names): Update.
 312         * objfiles.h (struct objfile_per_bfd_storage)
 313         <demangled_names_hash>: Now an htab_up.
 314         * objfiles.c (objfile_per_bfd_storage): Simplify.
 315
 316 2019-03-15  Tom Tromey  <tom@tromey.com>
 317
 318         * objfiles.h (struct objfile_per_bfd_storage): Declare
 319         destructor.
 320         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 321         New.
 322         (get_objfile_bfd_data): Use new.  Don't initialize
 323         language_of_main.
 324         (free_objfile_per_bfd_storage): Remove.
 325         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 326
 327 2019-03-15  Tom Tromey  <tom@tromey.com>
 328
 329         * symfile.c (reread_symbols): Update.
 330         * objfiles.c (objfile::objfile): Update.
 331         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 332         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 333         comment.
 334         (minimal_symbol_reader::install): Update.
 335         (terminate_minimal_symbol_table): Remove.
 336         * jit.c (jit_object_close_impl): Update.
 337
 338 2019-03-15  Tom Tromey  <tom@tromey.com>
 339
 340         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 341         initializations.
 342
 343 2019-03-15  Tom Tromey  <tom@tromey.com>
 344
 345         * objfiles.h (struct objfile_per_bfd_storage)
 346         <demangled_hash_languages>: Now a bitset.
 347         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 348         (lookup_minimal_symbol): Update.
 349
 350 2019-03-15  Tom Tromey  <tom@tromey.com>
 351
 352         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 353         Don't return the symbol.
 354         * coffread.c (record_minimal_symbol): Use record_full.
 355
 356 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 357
 358         The MS-Windows port of ncurses fails to switch to a color pair if
 359         one or both of the colors are the implicit default colors.  This
 360         change records the default colors when TUI is initialized, and
 361         then specifies them explicitly when a color pair uses the default
 362         colors.  This allows color styling in TUI mode on MS-Windows.
 363
 364         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 365         ncurses_norm_attr.
 366         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 367         colors in ncurses_norm_attr.
 368         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 369         "none", replace it with the default color recorded in
 370         ncurses_norm_attr.
 371
 372 2019-03-14  Tom Tromey  <tromey@adacore.com>
 373
 374         * source-cache.h (class source_cache) <get_source_lines>: Return
 375         std::string.
 376         * source-cache.c (source_cache::extract_lines): Handle case where
 377         first_pos==npos.  Return std::string.
 378         (source_cache::get_source_lines): Update.
 379
 380 2019-03-14  Tom Tromey  <tromey@adacore.com>
 381
 382         * NEWS: Add item for "style sources" commands.
 383         * source-cache.c (source_cache::get_source_lines): Check
 384         source_styling.
 385         * cli/cli-style.c (source_styling): New global.
 386         (_initialize_cli_style): Add "style sources" commands.
 387         (show_style_sources): New function.
 388         * cli/cli-style.h (source_styling): Declare.
 389
 390 2019-03-14  Pedro Alves  <palves@redhat.com>
 391             Tom Tromey  <tromey@adacore.com>
 392
 393         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 394         * tui/tui-winsource.c (tui_refill_source_window): New function,
 395         from...
 396         (tui_horizontal_source_scroll): ... here.  Move some logic.
 397         * cli/cli-style.c (set_style_enabled): Notify new observable.
 398         * tui/tui-hooks.c (tui_redisplay_source): New function.
 399         (tui_attach_detach_observers): Attach or detach
 400         tui_redisplay_source.
 401         * observable.h (source_styling_changed): New observable.
 402         * observable.c: Define source_styling_changed observable.
 403
 404 2019-03-13  Tom Tromey  <tromey@adacore.com>
 405
 406         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 407         (i386_gnu_nat_target::store_registers): Update.
 408         * target-debug.h (target_debug_print_std_string): New macro.
 409         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 410         * windows-tdep.c (display_one_tib): Update.
 411         * tui/tui-stack.c (tui_make_status_line): Update.
 412         * top.c (print_inferior_quit_action): Update.
 413         * thread.c (thr_try_catch_cmd): Update.
 414         (add_thread_with_info): Update.
 415         (thread_target_id_str): Update.
 416         (thr_try_catch_cmd): Update.
 417         (thread_command): Update.
 418         (thread_find_command): Update.
 419         * record-btrace.c (record_btrace_target::info_record)
 420         (record_btrace_resume_thread, record_btrace_target::resume)
 421         (record_btrace_cancel_resume, record_btrace_step_thread)
 422         (record_btrace_target::wait, record_btrace_target::wait)
 423         (record_btrace_target::wait, record_btrace_target::stop): Update.
 424         * progspace.c (print_program_space): Update.
 425         * process-stratum-target.c
 426         (process_stratum_target::thread_address_space): Update.
 427         * linux-fork.c (linux_fork_mourn_inferior)
 428         (detach_checkpoint_command, info_checkpoints_command)
 429         (linux_fork_context): Update.
 430         (linux_fork_detach): Update.
 431         (class scoped_switch_fork_info): Update.
 432         (delete_checkpoint_command): Update.
 433         * infrun.c (follow_fork_inferior): Update.
 434         (follow_fork_inferior): Update.
 435         (proceed_after_vfork_done): Update.
 436         (handle_vfork_child_exec_or_exit): Update.
 437         (follow_exec): Update.
 438         (displaced_step_prepare_throw): Update.
 439         (displaced_step_restore): Update.
 440         (start_step_over): Update.
 441         (resume_1): Update.
 442         (clear_proceed_status_thread): Update.
 443         (proceed): Update.
 444         (print_target_wait_results): Update.
 445         (do_target_wait): Update.
 446         (context_switch): Update.
 447         (stop_all_threads): Update.
 448         (restart_threads): Update.
 449         (finish_step_over): Update.
 450         (handle_signal_stop): Update.
 451         (switch_back_to_stepped_thread): Update.
 452         (keep_going_pass_signal): Update.
 453         (print_exited_reason): Update.
 454         (normal_stop): Update.
 455         * inferior.c (inferior_pid_to_str): Change return type.
 456         (print_selected_inferior): Update.
 457         (add_inferior): Update.
 458         (detach_inferior): Update.
 459         * dummy-frame.c (fprint_dummy_frames): Update.
 460         * dcache.c (dcache_info_1): Update.
 461         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 462         (btrace_fetch, btrace_clear): Update.
 463         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 464         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 465         type.
 466         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 467         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 468         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 469         * gdbarch.c, gdbarch.h: Rebuild.
 470         * gdbarch.sh (core_pid_to_str): Change return type.
 471         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 472         return type.
 473         (windows_nat_target::pid_to_str): Change return type.
 474         (windows_delete_thread): Update.
 475         (windows_nat_target::attach): Update.
 476         (windows_nat_target::files_info): Update.
 477         * target-delegates.c: Rebuild.
 478         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 479         return type.
 480         (sol_thread_target::pid_to_str): Change return type.
 481         * remote.c (class remote_target) <pid_to_str>: Change return
 482         type.
 483         (remote_target::pid_to_str): Change return type.
 484         (extended_remote_target::attach, remote_target::remote_stop_ns)
 485         (remote_target::remote_notif_remove_queued_reply)
 486         (remote_target::push_stop_reply, remote_target::disable_btrace):
 487         Update.
 488         (extended_remote_target::attach): Update.
 489         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 490         type.
 491         (gdbsim_target::pid_to_str): Change return type.
 492         * ravenscar-thread.c (struct ravenscar_thread_target)
 493         <pid_to_str>: Change return type.
 494         (ravenscar_thread_target::pid_to_str): Change return type.
 495         * procfs.c (class procfs_target) <pid_to_str>: Change return
 496         type.
 497         (procfs_target::pid_to_str): Change return type.
 498         (procfs_target::attach): Update.
 499         (procfs_target::detach): Update.
 500         (procfs_target::fetch_registers): Update.
 501         (procfs_target::store_registers): Update.
 502         (procfs_target::wait): Update.
 503         (procfs_target::files_info): Update.
 504         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 505         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 506         return type.
 507         (nto_procfs_target::pid_to_str): Change return type.
 508         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 509         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 510         return type.
 511         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 512         (exit_lwp): Update.
 513         (attach_proc_task_lwp_callback, get_detach_signal)
 514         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 515         (linux_nat_target::resume, wait_lwp, stop_callback)
 516         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 517         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 518         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 519         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 520         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 521         type.
 522         (inf_ptrace_target::attach): Update.
 523         (inf_ptrace_target::files_info): Update.
 524         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 525         type.
 526         (go32_nat_target::pid_to_str): Change return type.
 527         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 528         (gnu_nat_target::wait): Update.
 529         (gnu_nat_target::wait): Update.
 530         (gnu_nat_target::resume): Update.
 531         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 532         (fbsd_nat_target::wait): Update.
 533         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 534         type.
 535         (darwin_nat_target::attach): Update.
 536         * corelow.c (class core_target) <pid_to_str>: Change return type.
 537         (core_target::pid_to_str): Change return type.
 538         * target.c (normal_pid_to_str): Change return type.
 539         (default_pid_to_str): Likewise.
 540         (target_pid_to_str): Change return type.
 541         (target_translate_tls_address): Update.
 542         (target_announce_detach): Update.
 543         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 544         return type.
 545         (bsd_uthread_target::pid_to_str): Change return type.
 546         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 547         type.
 548         (bsd_kvm_target::pid_to_str): Change return type.
 549         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 550         return type.
 551         (aix_thread_target::pid_to_str): Change return type.
 552         * target.h (struct target_ops) <pid_to_str>: Change return type.
 553         (target_pid_to_str, normal_pid_to_str): Likewise.
 554         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 555         type.
 556         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 557         type.
 558         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 559         return type.
 560         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 561         type.
 562         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 563         type.
 564         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 565         return type.
 566
 567 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 568
 569         * NEWS: Mention that the new default MI version is 3.  Mention
 570         changes to the output of commands and events that deal with
 571         multi-location breakpoints.
 572         * breakpoint.c: Include "mi/mi-out.h".
 573         (print_one_breakpoint): Change output syntax if using MI version
 574         >= 3.
 575         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 576         New.
 577         (mi_multi_location_breakpoint_output_fixed): New.
 578         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 579         (mi_cmd_fix_multi_location_breakpoint_output): New.
 580         (mi_multi_location_breakpoint_output_fixed): New.
 581         * mi/mi-cmds.c (mi_cmds): Register command
 582         -fix-multi-location-breakpoint-output.
 583         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 584         interpreter "mi".
 585
 586 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 587
 588         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 589         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 590         instantiate mi_ui_out based on interpreter name.
 591         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 592         * mi/mi-main.c (mi_load_progress): Likewise.
 593
 594 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 595
 596         * NEWS: Combine separate "New targets" sections for 8.3.
 597
 598 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 599
 600         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 601         (ppcfbsd_init_abi): Install gdbarch
 602         "fetch_tls_load_module_address" and "get_thread_local_address"
 603         methods.
 604
 605 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 606
 607         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 608         (riscv_fbsd_init_abi): Install gdbarch
 609         "fetch_tls_load_module_address" and "get_thread_local_address"
 610         methods.
 611
 612 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 613
 614         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 615         (i386fbsd_init_abi): Install gdbarch
 616         "fetch_tls_load_module_address" and "get_thread_local_address"
 617         methods.
 618
 619 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 620
 621         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 622         (amd64fbsd_init_abi): Install gdbarch
 623         "fetch_tls_load_module_address" and "get_thread_local_address"
 624         methods.
 625
 626 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 627
 628         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 629         (struct fbsd_pspace_data): New type.
 630         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 631         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 632         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 633         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 634         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 635
 636 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 637
 638         * gdbtypes.c (lookup_struct_elt): New function.
 639         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 640         * gdbtypes.h (struct struct_elt): New type.
 641         (lookup_struct_elt): New prototype.
 642
 643 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 644
 645         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 646         remove disabled code block.
 647
 648 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 649
 650         * gdbarch.sh (get_thread_local_address): New method.
 651         * gdbarch.h, gdbarch.c: Regenerate.
 652         * target.c (target_translate_tls_address): Use
 653         gdbarch_get_thread_local_address if present instead of
 654         target::get_thread_local_address.
 655
 656 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 657
 658         * target.h (target::get_thread_local_address): Update comment.
 659
 660 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 661
 662         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 663         objfile->separate_debug_objfile_backlink if not NULL.
 664
 665 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 666
 667         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 668         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 669         (amd64bsd_store_inferior_registers): Likewise.
 670         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 671         Enable segment base registers.
 672         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 673         PT_GETFSBASE and PT_GETGSBASE.
 674         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 675         PT_SETGSBASE.
 676         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 677         segment base registers.
 678         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 679
 680 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 681
 682         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 683         Update calls to i386_target_description to add 'segments'
 684         parameter.
 685         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 686         add segment base registers.
 687         * arch/i386.c (i386_create_target_description): Add 'segments'
 688         parameter to enable segment base registers.
 689         * arch/i386.h (i386_create_target_description): Likewise.
 690         * features/i386/32bit-segments.xml: New file.
 691         * features/i386/32bit-segments.c: Generate.
 692         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 693         call to i386_target_description to add 'segments' parameter.
 694         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 695         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 696         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 697         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 698         if feature is present.
 699         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 700         Add 'segments' parameter to call to i386_target_description.
 701         (i386_target_description): Add 'segments' parameter to enable
 702         segment base registers.
 703         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 704         to call to i386_target_description.
 705         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 706         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 707         Define I386_NUM_REGS.
 708         (i386_target_description): Add 'segments' parameter to enable
 709         segment base registers.
 710
 711 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 712
 713         PR/24325
 714         * source-cache.c: #undef open and close, to avoid unresolved
 715         externals during linking.
 716
 717 2019-03-12  Tom Tromey  <tromey@adacore.com>
 718
 719         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 720         const.  Add initializers.
 721         (_initialize_remote): Don't initialize ptid globals.
 722
 723 2019-03-12  Pedro Alves  <palves@redhat.com>
 724
 725         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 726
 727 2019-03-12  Pedro Alves  <palves@redhat.com>
 728
 729         * cp-name-parser.y (main): Remove unused 'len' variable.
 730
 731 2019-03-12  Tom Tromey  <tromey@adacore.com>
 732
 733         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 734         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 735
 736 2019-03-12  Tom Tromey  <tromey@adacore.com>
 737
 738         * linux-nat.c (iterate_over_lwps): Update.
 739         (stop_callback): Remove parameter.
 740         (stop_wait_callback, detach_callback, resume_set_callback)
 741         (select_singlestep_lwp_callback, set_ignore_sigint)
 742         (status_callback, resumed_callback, resume_clear_callback)
 743         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 744         data parameter.
 745         (linux_nat_target::detach, linux_nat_target::resume)
 746         (linux_stop_and_wait_all_lwps, select_event_lwp)
 747         (linux_nat_filter_event, linux_nat_wait_1)
 748         (linux_nat_target::kill, linux_nat_target::stop)
 749         (linux_nat_target::stop): Update.
 750         (linux_nat_resume_callback): Change type.
 751         (resume_stopped_resumed_lwps, count_events_callback)
 752         (select_event_lwp_callback): Likewise.
 753         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 754         * arm-linux-nat.c (struct update_registers_data): Remove.
 755         (update_registers_callback): Change type.
 756         (arm_linux_insert_hw_breakpoint1): Update.
 757         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 758         parameter.
 759         (x86_linux_dr_set_addr): Update.
 760         (x86_linux_dr_set_control): Update.
 761         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 762         (iterate_over_lwps): Use gdb::function_view.
 763         * nat/aarch64-linux-hw-point.c (struct
 764         aarch64_dr_update_callback_param): Remove.
 765         (debug_reg_change_callback): Change type.
 766         (aarch64_notify_debug_reg_change): Update.
 767         * s390-linux-nat.c (s390_refresh_per_info): Update.
 768
 769 2019-03-11  Tom Tromey  <tromey@adacore.com>
 770
 771         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 772         redundant assignment to "this_cu".
 773
 774 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 775
 776         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 777
 778 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 779
 780         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 781         from...
 782         (rank_one_type): ... this.
 783
 784 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 785
 786         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 787         from...
 788         (rank_one_type): ... this.
 789
 790 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 791
 792         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 793         from...
 794         (rank_one_type): ... this.
 795
 796 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 797
 798         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 799         from...
 800         (rank_one_type): ... this.
 801
 802 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 803
 804         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 805         from...
 806         (rank_one_type): ... this.
 807
 808 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 809
 810         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 811         from...
 812         (rank_one_type): ... this.
 813
 814 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 815
 816         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 817         from...
 818         (rank_one_type): ... this.
 819
 820 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 821
 822         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 823         from...
 824         (rank_one_type): ... this.
 825
 826 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 827
 828         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 829         from...
 830         (rank_one_type): ... this.
 831
 832 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 833
 834         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 835         from...
 836         (rank_one_type): ... this.
 837
 838 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 839
 840         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 841         from...
 842         (rank_one_type): ... this.
 843
 844 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 845
 846         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 847         from...
 848         (rank_one_type): ... this.
 849
 850 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 851
 852         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 853         inferior-events' shows the example events.
 854
 855 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 856
 857         Support styling on native MS-Windows console
 858
 859         PR/24315
 860         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 861         on MS-Windows if $TERM is not defined.
 862
 863         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 864
 865         * posix-hdep.c (gdb_console_fputs):
 866         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 867         functions.
 868         * ui-file.h (gdb_console_fputs): Add prototype.
 869
 870         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 871         back to fputs only if the former returns zero.
 872
 873 2019-03-07  Tom Tromey  <tom@tromey.com>
 874
 875         * symmisc.c (print_symbol_bcache_statistics): Update.
 876         (print_objfile_statistics): Update.
 877         * symfile.c (allocate_symtab): Update.
 878         * stabsread.c: Don't include bcache.h.
 879         * psymtab.h (struct psymbol_bcache): Don't declare.
 880         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 881         (psymbol_bcache_init, psymbol_bcache_free)
 882         (psymbol_bcache_get_bcache): Don't declare.
 883         * psymtab.c (struct psymbol_bcache): Remove.
 884         (psymtab_storage::psymtab_storage): Update.
 885         (psymtab_storage::~psymtab_storage): Update.
 886         (psymbol_bcache_init, psymbol_bcache_free)
 887         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 888         (add_psymbol_to_bcache): Update.
 889         (allocate_psymtab): Update.
 890         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 891         macro_cache>: No longer pointers.
 892         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 893         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 894         * macrotab.c (macro_bcache): Update.
 895         * macroexp.c: Don't include bcache.h.
 896         * gdbtypes.c (check_types_worklist): Update.
 897         (types_deeply_equal): Remove TRY/CATCH.  Update.
 898         * elfread.c (elf_symtab_read): Update.
 899         * dwarf2read.c: Don't include bcache.h.
 900         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 901         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 902         (print_bcache_statistics, bcache_memory_used): Don't declare.
 903         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 904         methods.  Rename all data members.
 905         * bcache.c (struct bcache): Move to bcache.h.
 906         (bcache::expand_hash_table): Rename from expand_hash_table.
 907         (bcache): Remove.
 908         (bcache::insert): Rename from bcache_full.
 909         (bcache::compare): Rename from bcache_compare.
 910         (bcache_xmalloc): Remove.
 911         (bcache::~bcache): Rename from bcache_xfree.
 912         (bcache::print_statistics): Rename from print_bcache_statistics.
 913         (bcache::memory_used): Rename from bcache_memory_used.
 914
 915 2019-03-07  Pedro Alves  <palves@redhat.com>
 916
 917         * infrun.c (normal_stop): Also check for
 918         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 919
 920 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 921
 922         * f-lang.c (value_from_host_double): Moved to...
 923         * value.c (value_from_host_double): ...here.
 924         * value.h (value_from_host_double): Declare.
 925         * guile/scm-math.c (vlscm_convert_typed_number): Use
 926         value_from_host_double.
 927         (vlscm_convert_number): Likewise.
 928         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 929         * python/py-value.c (convert_value_from_python): Likewise.
 930
 931 2019-03-06  Tom Tromey  <tom@tromey.com>
 932
 933         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 934
 935 2019-03-06  Tom Tromey  <tom@tromey.com>
 936
 937         * utils.h (free_current_contents): Don't declare.
 938         * utils.c (free_current_contents): Remove.
 939
 940 2019-03-06  Tom Tromey  <tom@tromey.com>
 941
 942         * top.c (quit_force): Update.
 943         * main.c (captured_command_loop): Update.
 944         * common/new-op.c (operator new): Update.
 945         * common/common-exceptions.c (struct catcher)
 946         <save_cleanup_chain>: Remove member.
 947         (exceptions_state_mc_init): Update.
 948         (exception_try_scope_entry): Return nullptr.
 949         (exception_try_scope_exit, exception_rethrow)
 950         (throw_exception_sjlj, throw_exception_cxx): Update.
 951         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 952         (all_cleanups, do_cleanups, discard_cleanups)
 953         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 954         (restore_cleanups, restore_final_cleanups): Don't declare.
 955         (do_final_cleanups): Remove parameter.
 956         * common/cleanups.c (cleanup_chain, make_cleanup)
 957         (make_cleanup_dtor, all_cleanups, do_cleanups)
 958         (discard_my_cleanups, discard_cleanups)
 959         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 960         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 961         (null_cleanup): Remove.
 962         (do_final_cleanups): Remove parameter.
 963
 964 2019-03-06  Tom Tromey  <tom@tromey.com>
 965
 966         * remote.c (remote_target::remote_parse_stop_reply): Use
 967         unique_xmalloc_ptr.
 968
 969 2019-03-06  Tom Tromey  <tom@tromey.com>
 970
 971         * stabsread.c (struct stabs_field_info): Rename from field_info.
 972         <list, fnlist>: Add initializers.
 973         <obstack>: New member.
 974         (read_member_functions, read_struct_fields, read_baseclasses):
 975         Allocate on obstack.  Don't use cleanups.
 976         (read_one_struct_field, read_member_functions, read_struct_fields)
 977         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 978         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 979         (read_struct_type): Update.
 980
 981 2019-03-06  Tom Tromey  <tom@tromey.com>
 982
 983         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 984         * common/filestuff.h (make_cleanup_close): Don't declare.
 985         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 986         Remove.
 987
 988 2019-03-06  Tom Tromey  <tom@tromey.com>
 989
 990         * solib-aix.c: Use make_scope_exit.
 991
 992 2019-03-06  Tom Tromey  <tom@tromey.com>
 993
 994         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 995         Use make_scope_exit.
 996
 997 2019-03-06  Tom Tromey  <tom@tromey.com>
 998
 999         * solib-svr4.c (disable_probes_interface): Remove parameter.
1000         (svr4_handle_solib_event): Use make_scope_exit.
1001
1002 2019-03-06  Tom Tromey  <tom@tromey.com>
1003
1004         * remote.c (struct stop_reply_deleter): Remove.
1005         (stop_reply_up): Update.
1006         (struct stop_reply): Derive from notif_event.  Don't typedef.
1007         <regcache>: Now a std::vector.
1008         (stop_reply_xfree): Remove.
1009         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1010         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1011         (remote_target::discard_pending_stop_replies): Use delete.
1012         (remote_target::remote_parse_stop_reply): Update.
1013         (remote_target::process_stop_reply): Update.
1014         * remote-notif.h (struct notif_event): Add virtual destructor.
1015         Remove "dtr" member.
1016         (struct notif_client) <alloc_event>: Return a unique_ptr.
1017         (notif_event_xfree): Don't declare.
1018         (notif_event_up): New typedef.
1019         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1020         (notif_event_xfree, do_notif_event_xfree): Remove.
1021         (remote_notif_state_xfree): Update.
1022
1023 2019-03-06  Tom Tromey  <tom@tromey.com>
1024
1025         * infrun.c (displaced_step_clear_cleanup): Now a
1026         forward_scope_exit type.
1027         (displaced_step_prepare_throw): Update.
1028         (displaced_step_fixup): Update.
1029
1030 2019-03-06  Tom Tromey  <tom@tromey.com>
1031
1032         * inferior.h (class inferior): Update comment.
1033         * gdbthread.h (class thread_info): Update comment.
1034
1035 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1036             Tom Tromey  <tom@tromey.com>
1037
1038         * stabsread.h (struct stab_section_list): Remove.
1039         (coffstab_build_psymtabs): Update.
1040         * dbxread.c (symbuf_sections): Now a std::vector.
1041         (sect_idx): New global.
1042         (fill_symbuf): Update.
1043         (coffstab_build_psymtabs): Change type of stabsects parameter.
1044         Update.
1045         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1046         std::vector.
1047         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1048         (coff_locate_sections): Update.
1049         (coff_symfile_read): Remove cleanups.  Update.
1050         (init_stringtab): Add storage parameter.
1051         (free_stringtab, free_stringtab_cleanup): Remove.
1052         (init_lineno): Add storage parameter.
1053         (free_linetab, free_linetab_cleanup): Remove.
1054
1055 2019-03-06  Pedro Alves  <palves@redhat.com>
1056
1057         * linux-fork.c (fork_info::clobber_regs): Delete.
1058         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1059         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1060         comment.  Adjust.
1061         (scoped_switch_fork_info::scoped_switch_fork_info)
1062         (checkpoint_command, linux_fork_context): Adjust
1063         fork_save_infrun_state calls.
1064
1065 2019-03-06  Pedro Alves  <palves@redhat.com>
1066
1067         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1068         (inf_has_multiple_threads): Return 'bool' and rewrite using
1069         inferior_info::threads().
1070
1071 2019-03-06  Pedro Alves  <palves@redhat.com>
1072
1073         * linux-fork.c: Include <list>.
1074         (fork_list): Now a std::list instance.
1075         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1076         (forks_exist_p, find_last_fork): Adjust.
1077         (new_fork): Delete.
1078         (one_fork_p): New.
1079         (add_fork): Adjust.
1080         (free_fork): Delete, folded into fork_info::~fork_info().
1081         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1082         Adjust.
1083         (init_fork_list): Delete.
1084         (linux_fork_killall, linux_fork_mourn_inferior)
1085         (linux_fork_detach, info_checkpoints_command): Adjust.
1086         (_initialize_linux_fork): No longer call init_fork_list.
1087
1088 2019-03-06  Pedro Alves  <palves@redhat.com>
1089
1090         * linux-fork.c (new_fork): New, split out of ...
1091         (add_fork): ... this.  Return void.  Move "first fork" special
1092         case from here, to ...
1093         (checkpoint_command): ... here.
1094         * linux-linux.h (add_fork): Return void.
1095
1096 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1097
1098         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1099
1100 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1101             Chris January  <chris.january@arm.com>
1102             David Lecomber  <david.lecomber@arm.com>
1103
1104         * f-exp.y: New token, UNOP_INTRINSIC.
1105         (exp): New pattern using UNOP_INTRINSIC token.
1106         (f77_keywords): Add 'abs' keyword.
1107         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1108         (value_from_host_double): New function.
1109         (evaluate_subexp_f): Support UNOP_ABS.
1110
1111 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1112
1113         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1114         types.
1115
1116 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1117
1118         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1119         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1120         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1121
1122 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1123
1124         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1125
1126 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1127             Chris January  <chris.january@arm.com>
1128
1129         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1130         * f-exp.y: Define 'KIND' token.
1131         (exp): New pattern for KIND expressions.
1132         (ptype): Handle types with a kind extension.
1133         (direct_abs_decl): Extend to spot kind extensions.
1134         (f77_keywords): Add 'kind' to the list.
1135         (push_kind_type): New function.
1136         (convert_to_kind_type): New function.
1137         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1138         * parse.c (operator_length_standard): Likewise.
1139         * parser-defs.h (enum type_pieces): Add tp_kind.
1140         * std-operator.def: Add UNOP_KIND.
1141
1142 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1143
1144         * f-exp.y (f_parse): Set yydebug.
1145
1146 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1147
1148         * f-lang.c (evaluate_subexp_f): New function.
1149         (exp_descriptor_f): New global.
1150         (f_language_defn): Use exp_descriptor_f instead of
1151         exp_descriptor_standard.
1152
1153 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1154
1155         * f-exp.y (struct token): Add comments.
1156         (dot_ops): Remove uppercase versions and the end marker.
1157         (f77_keywords): Likewise.
1158         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1159         entries in the dot_ops array are case insensitive, and use
1160         strncasecmp to compare strings.  Also some whitespace cleanup in
1161         this area.  Similar for the f77_keywords array, except entries in
1162         this list might be case sensitive.
1163
1164 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1165
1166         * f-exp.y (struct f77_boolean_val): Add comments.
1167         (boolean_values): Remove uppercase versions, and end marker.
1168         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1169         and use strncasecmp to achieve case insensitivity.  Additionally,
1170         perform whitespace cleanup around this code.
1171
1172 2019-03-06  Tom Tromey  <tromey@adacore.com>
1173
1174         * remote-sim.c (gdbsim_target_open): Use result of
1175         gdb_argv::release.
1176
1177 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1178         Dirk Schubert  <dirk.schubert@arm.com>
1179         Chris January  <chris.january@arm.com>
1180
1181         * eval.c (evaluate_subexp_standard): Call Fortran argument
1182         wrapping logic.
1183         * f-lang.c (struct value): A value which can be passed into a
1184         Fortran function call.
1185         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1186         where appropriate.
1187         (struct type): Value ready for a Fortran function call.
1188         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1189         is needed.
1190         * f-lang.h (fortran_argument_convert): Declaration.
1191         (fortran_preserve_arg_pointer): Declaration.
1192         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1193
1194 2019-03-05  Tom Tromey  <tromey@adacore.com>
1195
1196         * python/py-prettyprint.c (print_string_repr): Remove #if.
1197         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1198
1199 2019-03-05  Tom Tromey  <tromey@adacore.com>
1200
1201         * target.c (the_dummy_target): Move later.  Change type to
1202         "dummy_target".
1203         (initialize_targets): Don't initialize the_dummy_target.
1204
1205 2019-03-05  Tom Tromey  <tromey@adacore.com>
1206
1207         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1208         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1209
1210 2019-03-05  Tom Tromey  <tromey@adacore.com>
1211
1212         * windows-nat.c (windows_nat_target::attach)
1213         (windows_nat_target::detach): Don't call gdb_flush.
1214         * valprint.c (generic_val_print, val_print, val_print_string):
1215         Don't call gdb_flush.
1216         * utils.c (defaulted_query): Don't call gdb_flush.
1217         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1218         * target.c (target_announce_detach): Don't call gdb_flush.
1219         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1220         * remote.c (extended_remote_target::attach): Don't call
1221         gdb_flush.
1222         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1223         * printcmd.c (do_examine): Don't call gdb_flush.
1224         (info_display_command): Don't call gdb_flush.
1225         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1226         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1227         * memattr.c (info_mem_command): Don't call gdb_flush.
1228         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1229         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1230         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1231         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1232         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1233         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1234         (gnu_nat_target::detach): Don't call gdb_flush.
1235         * f-valprint.c (f_val_print): Don't call gdb_flush.
1236         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1237         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1238         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1239         gdb_flush.
1240         * c-valprint.c (c_val_print): Don't call gdb_flush.
1241         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1242
1243 2019-03-05  Tom Tromey  <tromey@adacore.com>
1244
1245         * varobj.c (update_dynamic_varobj_children): Update.
1246         (install_default_visualizer): Use reset, not release.
1247         * value.c (set_internalvar): Update.
1248         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1249         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1250         ATTRIBUTE_UNUSED_RESULT.
1251
1252 2019-03-05  Tom Tromey  <tromey@adacore.com>
1253
1254         * remote.c (class scoped_remote_fd) <release>: Add
1255         ATTRIBUTE_UNUSED_RESULT.
1256
1257 2019-03-05  Tom Tromey  <tromey@adacore.com>
1258
1259         * macroexp.c (struct macro_buffer) <release>: Add
1260         ATTRIBUTE_UNUSED_RESULT.
1261
1262 2019-03-05  Tom Tromey  <tromey@adacore.com>
1263
1264         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1265         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1266         ATTRIBUTE_UNUSED_RESULT.
1267
1268 2019-03-05  Tom Tromey  <tromey@adacore.com>
1269
1270         * common/scoped_fd.h (class scoped_fd) <release>: Add
1271         ATTRIBUTE_UNUSED_RESULT.
1272
1273 2019-03-05  Tom Tromey  <tromey@adacore.com>
1274
1275         * parser-defs.h (struct parser_state) <release>: Add
1276         ATTRIBUTE_UNUSED_RESULT.
1277
1278 2019-03-05  Tom Tromey  <tromey@adacore.com>
1279
1280         * utils.h (class gdb_argv) <release>: Add
1281         ATTRIBUTE_UNUSED_RESULT.
1282         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1283
1284 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1285
1286         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1287         for-loop range, to avoid compiler warnings.
1288
1289         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1290         avoid compiler warnings about unused variables.
1291
1292         * NEWS: Mention end of support for native debugging on MS-Windows
1293         before XP.
1294
1295         PR gdb/24292
1296         * common/netstuff.c:
1297         * gdbserver/gdbreplay.c
1298         * gdbserver/remote-utils.c:
1299         * ser-tcp.c:
1300         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1301         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1302         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1303         'getaddrinfo' and 'freeaddrinfo' were not available before
1304         Windows XP, and mingw.org's MinGW headers by default define
1305         _WIN32_WINNT to 0x500.
1306
1307 2019-03-01  Gary Benson <gbenson@redhat.com>
1308
1309         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1310
1311 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1312             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1313
1314         PR gdb/8527
1315         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1316         set_sigint_trap, clear_sigint_trap.
1317
1318 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1319
1320         * target.c (target_detach): Clear the regcache and the
1321         frame cache.
1322
1323 2019-02-27  Pedro Alves  <palves@redhat.com>
1324
1325         * utils.c (set_screen_size): When we cap the height/width sizes,
1326         tweak the corresponding command variable to show "unlimited":
1327
1328 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1329             Pedro Alves  <palves@redhat.com>
1330
1331         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1332         before calling rl_set_screen_size.
1333
1334 2019-02-27  Tom Tromey  <tromey@adacore.com>
1335
1336         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1337         define.
1338         * python/py-value.c: Remove Python 2.4 workaround.
1339         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1340         workaround.
1341         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1342         Python 2.4 workaround.
1343         * python/python-internal.h: Remove Python 2.4 comment.
1344         (Py_ssize_t): Don't define.
1345         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1346         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1347         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1348         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1349         * python/python.c (do_start_initialization): Remove Python 2.4
1350         workaround.
1351         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1352         (print_children): Remove Python 2.4 workaround.
1353         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1354         workaround.
1355         (CHARBUFFERPROC_NAME): Remove.
1356         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1357         Python 2.4 workaround.
1358
1359 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1360
1361         * NEWS: Note minimum Python version.
1362
1363 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1364
1365         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1366         code from these functions.  Remove corresponding ifdefs.  Use
1367         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1368         Remove gotos and target of gotos.
1369         (infpy_search_memory): Likewise.
1370
1371 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1372
1373         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1374         (hppa_gdbarch_init): Don't register deleted functions with
1375         gdbarch.
1376
1377 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1378
1379         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1380         (h8300_unwind_sp): Delete.
1381         (h8300_dummy_id): Delete.
1382         (h8300_gdbarch_init): Don't register deleted functions with
1383         gdbarch.
1384
1385 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1386
1387         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1388         (ft32_unwind_pc): Delete.
1389         (ft32_unwind_sp): Delete.
1390         (ft32_gdbarch_init): Don't register deleted functions with
1391         gdbarch.
1392
1393 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1394
1395         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1396         (frv_unwind_pc): Delete.
1397         (frv_unwind_sp): Delete.
1398         (frv_gdbarch_init): Don't register deleted functions with
1399         gdbarch.
1400
1401 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1402
1403         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1404         (riscv_unwind_pc): Delete.
1405         (riscv_unwind_sp): Delete.
1406         (riscv_gdbarch_init): Don't register deleted functions with
1407         gdbarch.
1408
1409 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1410
1411         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1412         (csky_unwind_pc): Delete.
1413         (csky_unwind_sp): Delete.
1414         (csky_gdbarch_init): Don't register deleted functions with
1415         gdbarch.
1416
1417 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1418
1419         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1420         (cris_unwind_pc): Delete.
1421         (cris_unwind_sp): Delete.
1422         (cris_gdbarch_init): Don't register deleted functions with
1423         gdbarch.
1424
1425 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1426
1427         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1428         (bfin_unwind_pc): Delete.
1429         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1430
1431 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1432
1433         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1434         (arm_unwind_pc): Delete.
1435         (arm_unwind_sp): Delete.
1436         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1437
1438 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1439
1440         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1441         (arc_unwind_pc): Delete.
1442         (arc_unwind_sp): Delete.
1443         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1444
1445 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1446
1447         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1448         (alpha_unwind_pc): Delete.
1449         (alpha_gdbarch_init): Don't register deleted functions with
1450         gdbarch.
1451
1452 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1453
1454         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1455         (aarch64_unwind_pc): Delete.
1456         (aarch64_unwind_sp): Delete.
1457         (aarch64_gdbarch_init): Don't register deleted functions with
1458         gdbarch.
1459
1460 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1461
1462         * gdbtypes.c (type_align): Don't consider static members when
1463         computing structure alignment.
1464
1465 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1466
1467         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1468         return 0 for other types.
1469         * arch-utils.c (default_type_align): Always return 0.
1470         * gdbarch.h: Regenerate.
1471         * gdbarch.sh (type_align): Extend comment.
1472         * gdbtypes.c (type_align): Add additional comments, always call
1473         gdbarch_type_align before applying the default rules.
1474         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1475         generic code will then apply a suitable default.
1476         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1477         types, return 0 for other types.
1478
1479 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1480
1481         * NEWS: Create a new section for the next release branch.
1482         Rename the section of the current branch, now that it has
1483         been cut.
1484
1485 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1486
1487         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1488         * version.in: Bump version to 8.3.50.DATE-git.
1489
1490 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1491
1492         * aix-thread.c (ptid_cmp): Remove unused variable.
1493         (get_signaled_thread): Likewise.
1494         (store_regs_user_thread): Likewise.
1495         (store_regs_kernel_thread): Likewise.
1496         (fetch_regs_kernel_thread): Remove shadowed variable.
1497
1498 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1499
1500         * features/riscv/32bit-cpu.xml: Add register numbers.
1501         * features/riscv/32bit-fpu.c: Regenerate.
1502         * features/riscv/32bit-fpu.xml: Add register numbers.
1503         * features/riscv/64bit-cpu.xml: Add register numbers.
1504         * features/riscv/64bit-fpu.c: Regenerate.
1505         * features/riscv/64bit-fpu.xml: Add register numbers.
1506
1507 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1508
1509         * NEWS: Mention two argument form of gdb.Value constructor.
1510         * python/py-value.c (convert_buffer_and_type_to_value): New
1511         function.
1512         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1513         Add support for handling an optional second argument.  Call
1514         convert_buffer_and_type_to_value as appropriate.
1515         * python/python-internal.h (Py_buffer_deleter): New struct.
1516         (Py_buffer_up): New typedef.
1517
1518 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1519
1520         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1521         instead of releasing ownership.
1522
1523 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1524
1525         * dwarf2read.c (open_and_init_dwp_file): Call
1526         elf_numsections instead of bfd_count_sections to initialize
1527         dwp_file->num_sections.
1528
1529 2019-02-25  Tom Tromey  <tromey@adacore.com>
1530
1531         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1532
1533 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1534
1535         * gcore.in: Add '--readnever' option when invoking GDB.
1536
1537 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1538
1539         * MAINTAINERS: Update my email address.
1540
1541 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1542
1543         * build-id.c (build_id_to_debug_bfd_1): New function.
1544         (build_id_to_debug_bfd): Look for separate debug file in
1545         sysroot.
1546
1547 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1548
1549         * gdbarch.sh: Update the copyright year range that is placed into
1550         generated files.
1551
1552 2019-02-22  Keith Seitz  <keiths@redhat.com>
1553
1554         PR symtab/23853
1555         * linespec.c (create_sals_line_offset): Search for the default
1556         symtab's filename instead of its fullname.
1557
1558 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1559
1560         * NEWS: Update style defaults.
1561
1562 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1563
1564         * main.c (captured_main_1): Disable styling in batch mode.
1565
1566 2019-02-20  Tom Tromey  <tom@tromey.com>
1567
1568         * symtab.c (symtab_symbol_info): Fix typos.
1569
1570 2019-02-20  Tom Tromey  <tromey@adacore.com>
1571
1572         * findcmd.c (_initialize_mem_search): Use upper case for
1573         metasyntactic variables.
1574
1575 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1576
1577         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1578         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1579
1580 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1581
1582         * top.h (source_file_name): Change to std::string.
1583         * top.c (source_file_name): Likewise.
1584         (command_line_input): Adjust.
1585         * cli/cli-script.c (script_from_file): Adjust.
1586
1587 2019-02-19  Tom Tromey  <tromey@adacore.com>
1588
1589         * ravenscar-thread.c
1590         (ravenscar_thread_target::update_thread_list): Don't call
1591         ada_build_task_list.
1592         * ada-lang.h (ada_build_task_list): Don't declare.
1593         * ada-tasks.c (struct ada_tasks_inferior_data)
1594         <task_list_valid_p>: Now bool.
1595         (read_known_tasks, ada_task_list_changed)
1596         (ada_tasks_invalidate_inferior_data): Update.
1597         (read_known_tasks_array): Return bool.
1598         (read_known_tasks_list): Likewise.
1599         (read_known_tasks): Return void.
1600         (ada_build_task_list): Now static.
1601
1602 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1603
1604         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1605         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1606
1607 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1608
1609         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1610         variant for ada_tasks_pspace_data_handle and
1611         ada_tasks_inferior_data_handle.
1612         (ada_tasks_pspace_data_cleanup): New function.
1613         (ada_tasks_inferior_data_cleanup): New function.
1614
1615 2019-02-17  Tom Tromey  <tom@tromey.com>
1616
1617         * macrotab.h (macro_source_fullname): Return a std::string.
1618         * macrotab.c (macro_include, check_for_redefinition)
1619         (macro_undef, macro_lookup_definition, foreach_macro)
1620         (foreach_macro_in_scope): Update.
1621         (macro_source_fullname): Return a std::string.
1622         * macrocmd.c (show_pp_source_pos): Update.
1623
1624 2019-02-17  Tom Tromey  <tom@tromey.com>
1625
1626         * macrocmd.c (show_pp_source_pos): Style the file names.
1627
1628 2019-02-17  Tom Tromey  <tom@tromey.com>
1629
1630         PR tui/24197:
1631         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1632
1633 2019-02-17  Tom Tromey  <tom@tromey.com>
1634
1635         * ada-lang.c (user_select_syms): Use filtered printing.
1636         * utils.c (wrap_style): New global.
1637         (desired_style): Remove.
1638         (emit_style_escape): Add stream parameter.
1639         (set_output_style, reset_terminal_style, prompt_for_continue):
1640         Update.
1641         (flush_wrap_buffer): Only flush gdb_stdout.
1642         (wrap_here): Set wrap_style.
1643         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1644         treat escape sequences as a character.  Change when wrap buffer is
1645         flushed.
1646         (fputs_styled): Do not set the output style when the default is
1647         requested.
1648         * ui-style.h (struct ui_file_style) <is_default>: New method.
1649         * source.c (print_source_lines_base): Emit escape sequences in one
1650         piece.
1651
1652 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1653
1654         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1655         integers and enumeration types.
1656
1657 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1658
1659         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1660         instead of lookup_symbol_in_language
1661         (do_exact_match): New function.
1662         (ada_get_symbol_name_matcher): Return do_exact_match when
1663         doing a verbatim match.
1664
1665 2019-02-15  Tom Tromey  <tromey@adacore.com>
1666
1667         * ravenscar-thread.c (ravenscar_thread_target::resume)
1668         (ravenscar_thread_target::wait): Special case wildcard requests.
1669
1670 2019-02-15  Tom Tromey  <tromey@adacore.com>
1671
1672         * ravenscar-thread.c (base_ptid): Remove.
1673         (struct ravenscar_thread_target) <close>: New method.
1674         <m_base_ptid>: New member.
1675         <update_inferior_ptid, active_task, task_is_currently_active,
1676         runtime_initialized>: Declare methods.
1677         <ravenscar_thread_target>: Add constructor.
1678         (ravenscar_thread_target::task_is_currently_active)
1679         (ravenscar_thread_target::update_inferior_ptid)
1680         (ravenscar_runtime_initialized): Rename.  Now methods.
1681         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1682         (ravenscar_thread_target::update_thread_list): Update.
1683         (ravenscar_thread_target::active_task): Now method.
1684         (ravenscar_thread_target::store_registers)
1685         (ravenscar_thread_target::prepare_to_store)
1686         (ravenscar_thread_target::prepare_to_store)
1687         (ravenscar_thread_target::mourn_inferior): Update.
1688         (ravenscar_inferior_created): Use "new" to create target.
1689         (ravenscar_thread_target::get_ada_task_ptid): Update.
1690         (_initialize_ravenscar): Don't initialize base_ptid.
1691         (ravenscar_ops): Remove global.
1692
1693 2019-02-15  Tom Tromey  <tromey@adacore.com>
1694
1695         * target.h (push_target): Declare new overload.
1696         * target.c (push_target): New overload, taking an rvalue reference.
1697         * remote.c (remote_target::open_1): Use push_target overload.
1698         * corelow.c (core_target_open): Use push_target overload.
1699
1700 2019-02-15  Tom Tromey  <tromey@adacore.com>
1701
1702         * ravenscar-thread.c (is_ravenscar_task)
1703         (ravenscar_task_is_currently_active): Return bool.
1704         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1705         (_initialize_ravenscar): Remove "(void)".
1706         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1707         Return bool.
1708
1709 2019-02-15  Tom Tromey  <tromey@adacore.com>
1710
1711         * ravenscar-thread.c (ravenscar_runtime_initializer)
1712         (has_ravenscar_runtime, get_running_thread_id)
1713         (ravenscar_thread_target::resume): Fix indentation.
1714
1715 2019-02-15  Tom Tromey  <tromey@adacore.com>
1716
1717         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1718         from ravenscar_arch_ops.
1719         (sparc_ravenscar_ops::fetch_registers)
1720         (sparc_ravenscar_ops::store_registers): Now methods.
1721         (sparc_ravenscar_prepare_to_store): Remove.
1722         (sparc_ravenscar_ops): Redefine.
1723         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1724         methods and destructor.  Remove members.
1725         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1726         (ravenscar_thread_target::store_registers)
1727         (ravenscar_thread_target::prepare_to_store): Update.
1728         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1729         Remove.
1730         (struct ppc_ravenscar_powerpc_ops): Derive from
1731         ravenscar_arch_ops.
1732         (ppc_ravenscar_powerpc_ops::fetch_registers)
1733         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1734         (ppc_ravenscar_powerpc_ops): Redefine.
1735         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1736         (ppc_ravenscar_e500_ops::fetch_registers)
1737         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1738         (ppc_ravenscar_e500_ops): Redefine.
1739         * aarch64-ravenscar-thread.c
1740         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1741         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1742         (aarch64_ravenscar_fetch_registers)
1743         (aarch64_ravenscar_store_registers): Now methods.
1744         (aarch64_ravenscar_ops): Redefine.
1745
1746 2019-02-15  Tom Tromey  <tromey@adacore.com>
1747
1748         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1749         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1750         (ravenscar_thread_target::stopped_by_watchpoint)
1751         (ravenscar_thread_target::stopped_data_address)
1752         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1753
1754 2019-02-15  Tom Tromey  <tromey@adacore.com>
1755
1756         * ravenscar-thread.c: Fix some typos.
1757
1758 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1759             Tom Tromey  <tromey@adacore.com>
1760
1761         * ada-lang.c (ada_exception_sal): Change addr_string to a
1762         std::string.
1763         (create_ada_exception_catchpoint): Update.
1764
1765 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1766             Tom Tromey  <tromey@adacore.com>
1767
1768         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1769         (bp_location_ops): Remove.
1770         (base_breakpoint_allocate_location): Update.
1771         (free_bp_location): Update.
1772         * ada-lang.c (class ada_catchpoint_location)
1773         <ada_catchpoint_location>: Remove ops parameter.
1774         (ada_catchpoint_location_dtor): Remove.
1775         (ada_catchpoint_location_ops): Remove.
1776         (allocate_location_exception): Update.
1777         * breakpoint.h (struct bp_location_ops): Remove.
1778         (class bp_location) <bp_location>: Remove bp_location_ops
1779         parameter.
1780         <~bp_location>: Add destructor.
1781         <ops>: Remove.
1782
1783 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1784             Pedro Alves  <palves@redhat.com>
1785
1786         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1787         'PATH_MAX'.
1788
1789 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1790             Samuel Thibault  <samuel.thibault@gnu.org>
1791             Thomas Schwinge  <thomas@codesourcery.com>
1792
1793         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1794         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1795
1796 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1797
1798         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1799         (check_empty): Use "const char *".
1800
1801         * gnu-nat.c (gnu_nat_target::detach): Instead of
1802         'detach_inferior (pid)' call
1803         'detach_inferior (find_inferior_pid (pid))'.
1804
1805         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1806         'nat/fork-inferior.o'.
1807         * gnu-nat.c: #include "nat/fork-inferior.h".
1808
1809         * gnu-nat.c (gnu_nat_target::detach): Instead of
1810         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1811         * gnu-nat.h: #include "inf-child.h".
1812         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1813         'i386_gnu_nat_target::fetch_registers'.
1814         (gnu_store_registers): Rename/move to
1815         'i386_gnu_nat_target::store_registers'.
1816
1817         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1818         * gnu-nat.h (mach_thread_info): New function.
1819         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1820
1821         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1822
1823 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1824
1825         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1826
1827 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1828
1829         * windows-nat.c (windows_add_thread): Add new parameter
1830         "main_thread_p" with default value set to false.  Update
1831         function documentation as well as all callers.
1832         (windows_delete_thread): Likewise.
1833         (fake_create_process): Update call to windows_add_thread.
1834         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1835         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1836         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1837         call to windows_delete_thread.
1838
1839 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1840
1841         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1842
1843 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1844
1845         * symfile.c (find_separate_debug_file): Use canonical path of
1846         sysroot with child_path instead of gdb_sysroot if it is valid.
1847
1848 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1849
1850         * symfile.c (find_separate_debug_file): Use child_path to
1851         determine if an object file is under a sysroot.
1852
1853 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1854
1855         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1856         unittests/child-path-selftests.c.
1857         * common/pathstuff.c (child_path): New function.
1858         * common/pathstuff.h (child_path): New prototype.
1859         * unittests/child-path-selftests.c: New file.
1860
1861 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1862
1863         * symfile.c (find_separate_debug_file): Look for separate debug
1864         files in debug directories under the sysroot.
1865
1866 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1867
1868         * symtab.h (struct minimal_symbol data_p): New const method.
1869         (struct minimal_symbol text_p): Likewise.
1870         * symtab.c (output_source_filename): Use file name style
1871         to print file name.
1872         (print_symbol_info): Likewise.
1873         (print_msymbol_info): Use address style to print addresses.
1874         Use function name style to print executable text symbols.
1875         (expand_symtab_containing_pc): Use data_p.
1876         (find_pc_sect_compunit_symtab): Likewise.
1877
1878 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1879
1880         * breakpoint.c (describe_other_breakpoints): Use address style
1881         to print addresses.
1882         (say_where): Likewise.
1883
1884 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1885
1886         * ada-typeprint.c (print_func_type): Print function name
1887         style to print function name.
1888         * c-typeprint.c (c_print_type_1): Likewise.
1889
1890 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1891
1892         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1893         for execve.
1894
1895 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1896
1897         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1898         type_stack.
1899
1900 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1901
1902         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1903         TYPE_CODE_REF types.
1904
1905 2019-02-08  Jim Wilson  <jimw@sifive.com>
1906
1907         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1908         (riscv_linux_fregset): New.
1909         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1910
1911 2019-02-07  Tom Tromey  <tom@tromey.com>
1912
1913         * thread.c (thread_cancel_execution_command): Update.
1914         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1915         methods.
1916         (struct thread_fsm_ops): Remove.
1917         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1918         (thread_fsm_should_stop, thread_fsm_return_value)
1919         (thread_fsm_set_finished, thread_fsm_finished_p)
1920         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1921         Don't declare.
1922         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1923         * infrun.c (clear_proceed_status_thread)
1924         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1925         (print_stop_event): Update.
1926         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1927         Add constructor.
1928         (step_command_fsm_ops): Remove.
1929         (new_step_command_fsm): Remove.
1930         (step_1): Update.
1931         (step_command_fsm::should_stop): Rename from
1932         step_command_fsm_should_stop.
1933         (step_command_fsm::clean_up): Rename from
1934         step_command_fsm_clean_up.
1935         (step_command_fsm::do_async_reply_reason): Rename from
1936         step_command_fsm_async_reply_reason.
1937         (struct until_next_fsm): Inherit from thread_fsm.  Add
1938         constructor.
1939         (until_next_fsm_ops): Remove.
1940         (new_until_next_fsm): Remove.
1941         (until_next_fsm::should_stop): Rename from
1942         until_next_fsm_should_stop.
1943         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1944         (until_next_fsm::do_async_reply_reason): Rename from
1945         until_next_fsm_async_reply_reason.
1946         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1947         constructor.  Change type of breakpoint.
1948         (finish_command_fsm_ops): Remove.
1949         (new_finish_command_fsm): Remove.
1950         (finish_command_fsm::should_stop): Rename from
1951         finish_command_fsm_should_stop.
1952         (finish_command_fsm::clean_up): Rename from
1953         finish_command_fsm_clean_up.
1954         (finish_command_fsm::return_value): Rename from
1955         finish_command_fsm_return_value.
1956         (finish_command_fsm::do_async_reply_reason): Rename from
1957         finish_command_fsm_async_reply_reason.
1958         (finish_command): Update.
1959         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1960         Add constructor.
1961         (call_thread_fsm_ops): Remove.
1962         (call_thread_fsm::call_thread_fsm): Rename from
1963         new_call_thread_fsm.
1964         (call_thread_fsm::should_stop): Rename from
1965         call_thread_fsm_should_stop.
1966         (call_thread_fsm::should_notify_stop): Rename from
1967         call_thread_fsm_should_notify_stop.
1968         (run_inferior_call, call_function_by_hand_dummy): Update.
1969         * cli/cli-interp.c (should_print_stop_to_console): Update.
1970         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1971         Add constructor.  Change type of location_breakpoint,
1972         caller_breakpoint.
1973         (until_break_fsm_ops): Remove.
1974         (new_until_break_fsm): Remove.
1975         (until_break_fsm::should_stop): Rename from
1976         until_break_fsm_should_stop.
1977         (until_break_fsm::clean_up): Rename from
1978         until_break_fsm_clean_up.
1979         (until_break_fsm::do_async_reply_reason): Rename from
1980         until_break_fsm_async_reply_reason.
1981         (until_break_command): Update.
1982         * thread-fsm.c: Remove.
1983         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1984
1985 2019-02-07  Tom Tromey  <tom@tromey.com>
1986
1987         * yy-remap.h: Add include guard.
1988         * xtensa-tdep.h: Add include guard.
1989         * xcoffread.h: Rename include guard.
1990         * varobj-iter.h: Add include guard.
1991         * tui/tui.h: Rename include guard.
1992         * tui/tui-winsource.h: Rename include guard.
1993         * tui/tui-wingeneral.h: Rename include guard.
1994         * tui/tui-windata.h: Rename include guard.
1995         * tui/tui-win.h: Rename include guard.
1996         * tui/tui-stack.h: Rename include guard.
1997         * tui/tui-source.h: Rename include guard.
1998         * tui/tui-regs.h: Rename include guard.
1999         * tui/tui-out.h: Rename include guard.
2000         * tui/tui-layout.h: Rename include guard.
2001         * tui/tui-io.h: Rename include guard.
2002         * tui/tui-hooks.h: Rename include guard.
2003         * tui/tui-file.h: Rename include guard.
2004         * tui/tui-disasm.h: Rename include guard.
2005         * tui/tui-data.h: Rename include guard.
2006         * tui/tui-command.h: Rename include guard.
2007         * tic6x-tdep.h: Add include guard.
2008         * target/waitstatus.h: Rename include guard.
2009         * target/wait.h: Rename include guard.
2010         * target/target.h: Rename include guard.
2011         * target/resume.h: Rename include guard.
2012         * target-float.h: Rename include guard.
2013         * stabsread.h: Add include guard.
2014         * rs6000-tdep.h: Add include guard.
2015         * riscv-fbsd-tdep.h: Add include guard.
2016         * regformats/regdef.h: Rename include guard.
2017         * record.h: Rename include guard.
2018         * python/python.h: Rename include guard.
2019         * python/python-internal.h: Rename include guard.
2020         * python/py-stopevent.h: Rename include guard.
2021         * python/py-ref.h: Rename include guard.
2022         * python/py-record.h: Rename include guard.
2023         * python/py-record-full.h: Rename include guard.
2024         * python/py-record-btrace.h: Rename include guard.
2025         * python/py-instruction.h: Rename include guard.
2026         * python/py-events.h: Rename include guard.
2027         * python/py-event.h: Rename include guard.
2028         * procfs.h: Add include guard.
2029         * proc-utils.h: Add include guard.
2030         * p-lang.h: Add include guard.
2031         * or1k-tdep.h: Rename include guard.
2032         * observable.h: Rename include guard.
2033         * nto-tdep.h: Rename include guard.
2034         * nat/x86-linux.h: Rename include guard.
2035         * nat/x86-linux-dregs.h: Rename include guard.
2036         * nat/x86-gcc-cpuid.h: Add include guard.
2037         * nat/x86-dregs.h: Rename include guard.
2038         * nat/x86-cpuid.h: Rename include guard.
2039         * nat/ppc-linux.h: Rename include guard.
2040         * nat/mips-linux-watch.h: Rename include guard.
2041         * nat/linux-waitpid.h: Rename include guard.
2042         * nat/linux-ptrace.h: Rename include guard.
2043         * nat/linux-procfs.h: Rename include guard.
2044         * nat/linux-osdata.h: Rename include guard.
2045         * nat/linux-nat.h: Rename include guard.
2046         * nat/linux-namespaces.h: Rename include guard.
2047         * nat/linux-btrace.h: Rename include guard.
2048         * nat/glibc_thread_db.h: Rename include guard.
2049         * nat/gdb_thread_db.h: Rename include guard.
2050         * nat/gdb_ptrace.h: Rename include guard.
2051         * nat/fork-inferior.h: Rename include guard.
2052         * nat/amd64-linux-siginfo.h: Rename include guard.
2053         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2054         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2055         * nat/aarch64-linux.h: Rename include guard.
2056         * nat/aarch64-linux-hw-point.h: Rename include guard.
2057         * mn10300-tdep.h: Add include guard.
2058         * mips-linux-tdep.h: Add include guard.
2059         * mi/mi-parse.h: Rename include guard.
2060         * mi/mi-out.h: Rename include guard.
2061         * mi/mi-main.h: Rename include guard.
2062         * mi/mi-interp.h: Rename include guard.
2063         * mi/mi-getopt.h: Rename include guard.
2064         * mi/mi-console.h: Rename include guard.
2065         * mi/mi-common.h: Rename include guard.
2066         * mi/mi-cmds.h: Rename include guard.
2067         * mi/mi-cmd-break.h: Rename include guard.
2068         * m2-lang.h: Add include guard.
2069         * location.h: Rename include guard.
2070         * linux-record.h: Rename include guard.
2071         * linux-nat.h: Add include guard.
2072         * linux-fork.h: Add include guard.
2073         * i386-darwin-tdep.h: Rename include guard.
2074         * hppa-linux-offsets.h: Add include guard.
2075         * guile/guile.h: Rename include guard.
2076         * guile/guile-internal.h: Rename include guard.
2077         * gnu-nat.h: Rename include guard.
2078         * gdb-stabs.h: Rename include guard.
2079         * frv-tdep.h: Add include guard.
2080         * f-lang.h: Add include guard.
2081         * event-loop.h: Add include guard.
2082         * darwin-nat.h: Rename include guard.
2083         * cp-abi.h: Rename include guard.
2084         * config/sparc/nm-sol2.h: Rename include guard.
2085         * config/nm-nto.h: Rename include guard.
2086         * config/nm-linux.h: Add include guard.
2087         * config/i386/nm-i386gnu.h: Rename include guard.
2088         * config/djgpp/nl_types.h: Rename include guard.
2089         * config/djgpp/langinfo.h: Rename include guard.
2090         * compile/gcc-cp-plugin.h: Add include guard.
2091         * compile/gcc-c-plugin.h: Add include guard.
2092         * compile/compile.h: Rename include guard.
2093         * compile/compile-object-run.h: Rename include guard.
2094         * compile/compile-object-load.h: Rename include guard.
2095         * compile/compile-internal.h: Rename include guard.
2096         * compile/compile-cplus.h: Rename include guard.
2097         * compile/compile-c.h: Rename include guard.
2098         * common/xml-utils.h: Rename include guard.
2099         * common/x86-xstate.h: Rename include guard.
2100         * common/version.h: Rename include guard.
2101         * common/vec.h: Rename include guard.
2102         * common/tdesc.h: Rename include guard.
2103         * common/selftest.h: Rename include guard.
2104         * common/scoped_restore.h: Rename include guard.
2105         * common/scoped_mmap.h: Rename include guard.
2106         * common/scoped_fd.h: Rename include guard.
2107         * common/safe-iterator.h: Rename include guard.
2108         * common/run-time-clock.h: Rename include guard.
2109         * common/refcounted-object.h: Rename include guard.
2110         * common/queue.h: Rename include guard.
2111         * common/ptid.h: Rename include guard.
2112         * common/print-utils.h: Rename include guard.
2113         * common/preprocessor.h: Rename include guard.
2114         * common/pathstuff.h: Rename include guard.
2115         * common/observable.h: Rename include guard.
2116         * common/netstuff.h: Rename include guard.
2117         * common/job-control.h: Rename include guard.
2118         * common/host-defs.h: Rename include guard.
2119         * common/gdb_wait.h: Rename include guard.
2120         * common/gdb_vecs.h: Rename include guard.
2121         * common/gdb_unlinker.h: Rename include guard.
2122         * common/gdb_unique_ptr.h: Rename include guard.
2123         * common/gdb_tilde_expand.h: Rename include guard.
2124         * common/gdb_sys_time.h: Rename include guard.
2125         * common/gdb_string_view.h: Rename include guard.
2126         * common/gdb_splay_tree.h: Rename include guard.
2127         * common/gdb_setjmp.h: Rename include guard.
2128         * common/gdb_ref_ptr.h: Rename include guard.
2129         * common/gdb_optional.h: Rename include guard.
2130         * common/gdb_locale.h: Rename include guard.
2131         * common/gdb_assert.h: Rename include guard.
2132         * common/filtered-iterator.h: Rename include guard.
2133         * common/filestuff.h: Rename include guard.
2134         * common/fileio.h: Rename include guard.
2135         * common/environ.h: Rename include guard.
2136         * common/common-utils.h: Rename include guard.
2137         * common/common-types.h: Rename include guard.
2138         * common/common-regcache.h: Rename include guard.
2139         * common/common-inferior.h: Rename include guard.
2140         * common/common-gdbthread.h: Rename include guard.
2141         * common/common-exceptions.h: Rename include guard.
2142         * common/common-defs.h: Rename include guard.
2143         * common/common-debug.h: Rename include guard.
2144         * common/cleanups.h: Rename include guard.
2145         * common/buffer.h: Rename include guard.
2146         * common/btrace-common.h: Rename include guard.
2147         * common/break-common.h: Rename include guard.
2148         * cli/cli-utils.h: Rename include guard.
2149         * cli/cli-style.h: Rename include guard.
2150         * cli/cli-setshow.h: Rename include guard.
2151         * cli/cli-script.h: Rename include guard.
2152         * cli/cli-interp.h: Rename include guard.
2153         * cli/cli-decode.h: Rename include guard.
2154         * cli/cli-cmds.h: Rename include guard.
2155         * charset-list.h: Add include guard.
2156         * buildsym-legacy.h: Rename include guard.
2157         * bfin-tdep.h: Add include guard.
2158         * ax.h: Rename include guard.
2159         * arm-linux-tdep.h: Add include guard.
2160         * arm-fbsd-tdep.h: Add include guard.
2161         * arch/xtensa.h: Rename include guard.
2162         * arch/tic6x.h: Add include guard.
2163         * arch/i386.h: Add include guard.
2164         * arch/arm.h: Rename include guard.
2165         * arch/arm-linux.h: Rename include guard.
2166         * arch/arm-get-next-pcs.h: Rename include guard.
2167         * arch/amd64.h: Add include guard.
2168         * arch/aarch64-insn.h: Rename include guard.
2169         * arch-utils.h: Rename include guard.
2170         * annotate.h: Add include guard.
2171         * amd64-darwin-tdep.h: Rename include guard.
2172         * aarch64-linux-tdep.h: Add include guard.
2173         * aarch64-fbsd-tdep.h: Add include guard.
2174         * aarch32-linux-nat.h: Add include guard.
2175
2176 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2177
2178         * macrotab.c (macro_define_internal): New function that
2179         factorizes macro_define_object_internal and macro_define_function
2180         code.
2181         (macro_define_object_internal): Use macro_define_internal.
2182         (macro_define_function): Likewise.
2183
2184 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2185
2186         * macrocmd.c (extract_identifier): Return
2187         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2188         callers.
2189
2190 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2191
2192         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2193
2194 2019-02-05  Tom Tromey  <tom@tromey.com>
2195
2196         * target.c (target_stack::unpush): Move assertion earlier.
2197
2198 2019-01-30  Tom Tromey  <tom@tromey.com>
2199
2200         PR python/23615:
2201         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2202         (gdbpy_parse_and_eval): Likewise.
2203         * python/python-internal.h (gdbpy_allow_threads): New class.
2204
2205 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2206
2207         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2208         (aarch64_fbsd_fpregmap): Move earlier.
2209         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2210         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2211         instead of individual calls to trad_frame_set_reg_addr.
2212         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2213         earlier.
2214         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2215         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2216         instead of individual calls to trad_frame_set_reg_addr.
2217
2218 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2219
2220         * CONTRIBUTE: Replace contribution list with wiki link.
2221
2222 2019-01-25  Tom Tromey  <tom@tromey.com>
2223
2224         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2225
2226 2019-01-25  Tom Tromey  <tom@tromey.com>
2227
2228         * xtensa-linux-nat.c: Fix common/ includes.
2229         * xml-support.h: Fix common/ includes.
2230         * xml-support.c: Fix common/ includes.
2231         * x86-linux-nat.c: Fix common/ includes.
2232         * windows-nat.c: Fix common/ includes.
2233         * varobj.h: Fix common/ includes.
2234         * varobj.c: Fix common/ includes.
2235         * value.c: Fix common/ includes.
2236         * valops.c: Fix common/ includes.
2237         * utils.c: Fix common/ includes.
2238         * unittests/xml-utils-selftests.c: Fix common/ includes.
2239         * unittests/utils-selftests.c: Fix common/ includes.
2240         * unittests/unpack-selftests.c: Fix common/ includes.
2241         * unittests/tracepoint-selftests.c: Fix common/ includes.
2242         * unittests/style-selftests.c: Fix common/ includes.
2243         * unittests/string_view-selftests.c: Fix common/ includes.
2244         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2245         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2246         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2247         * unittests/rsp-low-selftests.c: Fix common/ includes.
2248         * unittests/parse-connection-spec-selftests.c: Fix common/
2249         includes.
2250         * unittests/optional-selftests.c: Fix common/ includes.
2251         * unittests/offset-type-selftests.c: Fix common/ includes.
2252         * unittests/observable-selftests.c: Fix common/ includes.
2253         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2254         * unittests/memrange-selftests.c: Fix common/ includes.
2255         * unittests/memory-map-selftests.c: Fix common/ includes.
2256         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2257         * unittests/function-view-selftests.c: Fix common/ includes.
2258         * unittests/environ-selftests.c: Fix common/ includes.
2259         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2260         * unittests/common-utils-selftests.c: Fix common/ includes.
2261         * unittests/cli-utils-selftests.c: Fix common/ includes.
2262         * unittests/array-view-selftests.c: Fix common/ includes.
2263         * ui-file.c: Fix common/ includes.
2264         * tui/tui-io.c: Fix common/ includes.
2265         * tracepoint.h: Fix common/ includes.
2266         * tracepoint.c: Fix common/ includes.
2267         * tracefile-tfile.c: Fix common/ includes.
2268         * top.h: Fix common/ includes.
2269         * top.c: Fix common/ includes.
2270         * thread.c: Fix common/ includes.
2271         * target/waitstatus.h: Fix common/ includes.
2272         * target/waitstatus.c: Fix common/ includes.
2273         * target.h: Fix common/ includes.
2274         * target.c: Fix common/ includes.
2275         * target-memory.c: Fix common/ includes.
2276         * target-descriptions.c: Fix common/ includes.
2277         * symtab.h: Fix common/ includes.
2278         * symfile.c: Fix common/ includes.
2279         * stap-probe.c: Fix common/ includes.
2280         * spu-linux-nat.c: Fix common/ includes.
2281         * sparc-nat.c: Fix common/ includes.
2282         * source.c: Fix common/ includes.
2283         * solib.c: Fix common/ includes.
2284         * solib-target.c: Fix common/ includes.
2285         * ser-unix.c: Fix common/ includes.
2286         * ser-tcp.c: Fix common/ includes.
2287         * ser-pipe.c: Fix common/ includes.
2288         * ser-base.c: Fix common/ includes.
2289         * selftest-arch.c: Fix common/ includes.
2290         * s12z-tdep.c: Fix common/ includes.
2291         * rust-exp.y: Fix common/ includes.
2292         * rs6000-aix-tdep.c: Fix common/ includes.
2293         * riscv-tdep.c: Fix common/ includes.
2294         * remote.c: Fix common/ includes.
2295         * remote-notif.h: Fix common/ includes.
2296         * remote-fileio.h: Fix common/ includes.
2297         * remote-fileio.c: Fix common/ includes.
2298         * regcache.h: Fix common/ includes.
2299         * regcache.c: Fix common/ includes.
2300         * record-btrace.c: Fix common/ includes.
2301         * python/python.c: Fix common/ includes.
2302         * python/py-type.c: Fix common/ includes.
2303         * python/py-inferior.c: Fix common/ includes.
2304         * progspace.h: Fix common/ includes.
2305         * producer.c: Fix common/ includes.
2306         * procfs.c: Fix common/ includes.
2307         * proc-api.c: Fix common/ includes.
2308         * printcmd.c: Fix common/ includes.
2309         * ppc-linux-nat.c: Fix common/ includes.
2310         * parser-defs.h: Fix common/ includes.
2311         * osdata.c: Fix common/ includes.
2312         * obsd-nat.c: Fix common/ includes.
2313         * nat/x86-linux.c: Fix common/ includes.
2314         * nat/x86-linux-dregs.c: Fix common/ includes.
2315         * nat/x86-dregs.h: Fix common/ includes.
2316         * nat/x86-dregs.c: Fix common/ includes.
2317         * nat/ppc-linux.c: Fix common/ includes.
2318         * nat/mips-linux-watch.h: Fix common/ includes.
2319         * nat/mips-linux-watch.c: Fix common/ includes.
2320         * nat/linux-waitpid.c: Fix common/ includes.
2321         * nat/linux-ptrace.h: Fix common/ includes.
2322         * nat/linux-ptrace.c: Fix common/ includes.
2323         * nat/linux-procfs.c: Fix common/ includes.
2324         * nat/linux-personality.c: Fix common/ includes.
2325         * nat/linux-osdata.c: Fix common/ includes.
2326         * nat/linux-namespaces.c: Fix common/ includes.
2327         * nat/linux-btrace.h: Fix common/ includes.
2328         * nat/linux-btrace.c: Fix common/ includes.
2329         * nat/fork-inferior.c: Fix common/ includes.
2330         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2331         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2332         * nat/aarch64-linux.c: Fix common/ includes.
2333         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2334         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2335         * namespace.h: Fix common/ includes.
2336         * mips-linux-tdep.c: Fix common/ includes.
2337         * minsyms.c: Fix common/ includes.
2338         * mi/mi-parse.h: Fix common/ includes.
2339         * mi/mi-main.c: Fix common/ includes.
2340         * mi/mi-cmd-env.c: Fix common/ includes.
2341         * memrange.h: Fix common/ includes.
2342         * memattr.c: Fix common/ includes.
2343         * maint.h: Fix common/ includes.
2344         * maint.c: Fix common/ includes.
2345         * main.c: Fix common/ includes.
2346         * machoread.c: Fix common/ includes.
2347         * location.c: Fix common/ includes.
2348         * linux-thread-db.c: Fix common/ includes.
2349         * linux-nat.c: Fix common/ includes.
2350         * linux-fork.c: Fix common/ includes.
2351         * inline-frame.c: Fix common/ includes.
2352         * infrun.c: Fix common/ includes.
2353         * inflow.c: Fix common/ includes.
2354         * inferior.h: Fix common/ includes.
2355         * inferior.c: Fix common/ includes.
2356         * infcmd.c: Fix common/ includes.
2357         * inf-ptrace.c: Fix common/ includes.
2358         * inf-child.c: Fix common/ includes.
2359         * ia64-linux-nat.c: Fix common/ includes.
2360         * i387-tdep.c: Fix common/ includes.
2361         * i386-tdep.c: Fix common/ includes.
2362         * i386-linux-tdep.c: Fix common/ includes.
2363         * i386-linux-nat.c: Fix common/ includes.
2364         * i386-go32-tdep.c: Fix common/ includes.
2365         * i386-fbsd-tdep.c: Fix common/ includes.
2366         * i386-fbsd-nat.c: Fix common/ includes.
2367         * guile/scm-type.c: Fix common/ includes.
2368         * guile/guile.c: Fix common/ includes.
2369         * go32-nat.c: Fix common/ includes.
2370         * gnu-nat.c: Fix common/ includes.
2371         * gdbthread.h: Fix common/ includes.
2372         * gdbarch-selftests.c: Fix common/ includes.
2373         * gdb_usleep.c: Fix common/ includes.
2374         * gdb_select.h: Fix common/ includes.
2375         * gdb_bfd.c: Fix common/ includes.
2376         * gcore.c: Fix common/ includes.
2377         * fork-child.c: Fix common/ includes.
2378         * findvar.c: Fix common/ includes.
2379         * fbsd-nat.c: Fix common/ includes.
2380         * event-top.c: Fix common/ includes.
2381         * event-loop.c: Fix common/ includes.
2382         * dwarf2read.c: Fix common/ includes.
2383         * dwarf2loc.c: Fix common/ includes.
2384         * dwarf2-frame.c: Fix common/ includes.
2385         * dwarf-index-cache.c: Fix common/ includes.
2386         * dtrace-probe.c: Fix common/ includes.
2387         * disasm-selftests.c: Fix common/ includes.
2388         * defs.h: Fix common/ includes.
2389         * csky-tdep.c: Fix common/ includes.
2390         * cp-valprint.c: Fix common/ includes.
2391         * cp-support.h: Fix common/ includes.
2392         * cp-support.c: Fix common/ includes.
2393         * corelow.c: Fix common/ includes.
2394         * completer.h: Fix common/ includes.
2395         * completer.c: Fix common/ includes.
2396         * compile/compile.c: Fix common/ includes.
2397         * compile/compile-loc2c.c: Fix common/ includes.
2398         * compile/compile-cplus-types.c: Fix common/ includes.
2399         * compile/compile-cplus-symbols.c: Fix common/ includes.
2400         * command.h: Fix common/ includes.
2401         * cli/cli-dump.c: Fix common/ includes.
2402         * cli/cli-cmds.c: Fix common/ includes.
2403         * charset.c: Fix common/ includes.
2404         * build-id.c: Fix common/ includes.
2405         * btrace.h: Fix common/ includes.
2406         * btrace.c: Fix common/ includes.
2407         * breakpoint.h: Fix common/ includes.
2408         * breakpoint.c: Fix common/ includes.
2409         * ax.h:
2410         (enum agent_op): Fix common/ includes.
2411         * ax-general.c (struct aop_map): Fix common/ includes.
2412         * ax-gdb.c: Fix common/ includes.
2413         * auxv.c: Fix common/ includes.
2414         * auto-load.c: Fix common/ includes.
2415         * arm-tdep.c: Fix common/ includes.
2416         * arch/riscv.c: Fix common/ includes.
2417         * arch/ppc-linux-common.c: Fix common/ includes.
2418         * arch/i386.c: Fix common/ includes.
2419         * arch/arm.c: Fix common/ includes.
2420         * arch/arm-linux.c: Fix common/ includes.
2421         * arch/arm-get-next-pcs.c: Fix common/ includes.
2422         * arch/amd64.c: Fix common/ includes.
2423         * arch/aarch64.c: Fix common/ includes.
2424         * arch/aarch64-insn.c: Fix common/ includes.
2425         * arch-utils.c: Fix common/ includes.
2426         * amd64-windows-tdep.c: Fix common/ includes.
2427         * amd64-tdep.c: Fix common/ includes.
2428         * amd64-sol2-tdep.c: Fix common/ includes.
2429         * amd64-obsd-tdep.c: Fix common/ includes.
2430         * amd64-nbsd-tdep.c: Fix common/ includes.
2431         * amd64-linux-tdep.c: Fix common/ includes.
2432         * amd64-linux-nat.c: Fix common/ includes.
2433         * amd64-fbsd-tdep.c: Fix common/ includes.
2434         * amd64-fbsd-nat.c: Fix common/ includes.
2435         * amd64-dicos-tdep.c: Fix common/ includes.
2436         * amd64-darwin-tdep.c: Fix common/ includes.
2437         * agent.c: Fix common/ includes.
2438         * ada-lang.h: Fix common/ includes.
2439         * ada-lang.c: Fix common/ includes.
2440         * aarch64-tdep.c: Fix common/ includes.
2441
2442 2019-01-25  Tom Tromey  <tom@tromey.com>
2443
2444         * common/create-version.sh: Use common/version.h.
2445
2446 2019-01-24  Pedro Alves  <palves@redhat.com>
2447
2448         * infrun.c (signal_stop, signal_print, signal_program)
2449         (signal_catch, signal_pass): Now arrays instead of pointers.
2450         (update_signals_program_target, do_target_resume)
2451         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2452         * linux-nat.c (linux_nat_target::pass_signals)
2453         (linux_nat_target::create_inferior, linux_nat_target::attach):
2454         Adjust.
2455         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2456         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2457         * procfs.c (procfs_target::pass_signals): Adjust.
2458         * record-full.c (record_full_target::resume): Adjust.
2459         * remote.c (remote_target::pass_signals)
2460         (remote_target::program_signals): Adjust.
2461         * target-debug.h (target_debug_print_signals): Now takes a
2462         gdb::array_view as parameter.  Adjust.
2463         * target.h (target_ops) <pass_signals, program_signals>: Replace
2464         pointer and length parameters with gdb::array_view.
2465         (target_pass_signals, target_program_signals): Likewise.
2466         * target-delegates.c: Regenerate.
2467
2468 2019-01-24  Pedro Alves  <palves@redhat.com>
2469
2470         * common/forward-scope-exit.h
2471         (forward_scope_exit::forward_scope_exit): Pass arguments to
2472         m_bind_function directly, instead of creating a std::bind and
2473         copying that.
2474
2475 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2476
2477         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2478         for static members.
2479         (pass_in_v_vfp_candidate): Likewise.
2480
2481 2019-01-23  Tom Tromey  <tom@tromey.com>
2482             Pedro Alves  <palves@redhat.com>
2483
2484         * regcache.c (class regcache_invalidator): Remove.
2485         (regcache::raw_write): Use make_scope_exit.
2486
2487 2019-01-23  Tom Tromey  <tom@tromey.com>
2488
2489         * ui-out.h (class ui_out_emit_type): Update comment.
2490
2491 2019-01-23  Tom Tromey  <tom@tromey.com>
2492
2493         * infrun.c (fetch_inferior_event): Update comment.
2494
2495 2019-01-23  Tom Tromey  <tom@tromey.com>
2496             Pedro Alves  <palves@redhat.com>
2497
2498         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2499         parameter.
2500         (fetch_inferior_event): Use SCOPE_EXIT.
2501
2502
2503 2019-01-23  Tom Tromey  <tom@tromey.com>
2504             Pedro Alves  <palves@redhat.com>
2505
2506         * infrun.c (disable_thread_events): Delete.
2507         (stop_all_threads): Use SCOPE_EXIT.
2508
2509 2019-01-23  Tom Tromey  <tom@tromey.com>
2510             Pedro Alves  <palves@redhat.com>
2511
2512         * symfile.c: Include forward-scope-exit.h.
2513         (clear_symtab_users_cleanup): Replace forward declaration with
2514         a FORWARD_SCOPE_EXIT.
2515         (syms_from_objfile_1): Use the forward_scope_exit and
2516         gdb::optional instead of cleanup_function.
2517         (reread_symbols): Use the forward_scope_exit instead of
2518         cleanup_function.
2519         (clear_symtab_users_cleanup): Remove function.
2520
2521 2019-01-23  Tom Tromey  <tom@tromey.com>
2522             Pedro Alves  <palves@redhat.com>
2523
2524         * linux-nat.c: Include scope-exit.h.
2525         (cleanup_target_stop): Remove.
2526         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2527         SCOPE_EXIT.
2528
2529 2019-01-23  Tom Tromey  <tom@tromey.com>
2530             Pedro Alves  <palves@redhat.com>
2531
2532         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2533         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2534
2535 2019-01-23  Tom Tromey  <tom@tromey.com>
2536             Andrew Burgess  <andrew.burgess@embecosm.com>
2537             Pedro Alves  <palves@redhat.com>
2538
2539         * infrun.c (fetch_inferior_event): Use scope_exit.
2540         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2541         * top.c (execute_command): Use scope_exit.
2542         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2543         * utils.c (do_bpstat_clear_actions_cleanup)
2544         (make_bpstat_clear_actions_cleanup): Remove.
2545
2546 2019-01-23  Tom Tromey  <tom@tromey.com>
2547             Pedro Alves  <palves@redhat.com>
2548
2549         * infrun.c: Include "common/scope-exit.h"
2550         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2551         (wait_for_inferior): Use SCOPE_EXIT.
2552         (fetch_inferior_event): Use scope_exit.
2553
2554 2019-01-23  Tom Tromey  <tom@tromey.com>
2555             Pedro Alves  <palves@redhat.com>
2556
2557         * breakpoint.c (create_breakpoint): Remove cleanup.
2558
2559 2019-01-23  Tom Tromey  <tom@tromey.com>
2560             Andrew Burgess  <andrew.burgess@embecosm.com>
2561             Pedro Alves  <palves@redhat.com>
2562
2563 2019-01-23  Pedro Alves  <palves@redhat.com>
2564
2565         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2566
2567 2019-01-23  Pedro Alves  <palves@redhat.com>
2568             Andrew Burgess  <andrew.burgess@embecosm.com>
2569
2570         * gdbthread.h: Include "common/forward-scope-exit.h".
2571         (scoped_finish_thread_state): Redefine custom class in terms of
2572         forward_scope_exit.
2573
2574 2019-01-23  Pedro Alves  <palves@redhat.com>
2575             Andrew Burgess  <andrew.burgess@embecosm.com>
2576
2577         * common/forward-scope-exit.h: New file.
2578
2579 2019-01-23  Pedro Alves  <palves@redhat.com>
2580             Andrew Burgess  <andrew.burgess@embecosm.com>
2581             Tom Tromey  <tom@tromey.com>
2582
2583         * common/scope-exit.h: New file.
2584
2585 2019-01-23  Pedro Alves  <palves@redhat.com>
2586
2587         * common/preprocessor.h (ESC): Rename to ...
2588         (ESC_PARENS): ... this.
2589         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2590         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2591
2592 2019-01-23  Tom Tromey  <tom@tromey.com>
2593
2594         * language.h (class scoped_switch_to_sym_language_if_auto):
2595         Initialize m_lang in both cases.
2596
2597 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2598
2599         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2600         with XCNEW.
2601
2602 2019-01-22  Tom Tromey  <tom@tromey.com>
2603
2604         * corelow.c: Do not include sys/file.h.
2605
2606 2019-01-22  Tom Tromey  <tom@tromey.com>
2607
2608         * tui/tui-wingeneral.h: Include gdb_curses.h.
2609
2610 2019-01-22  Tom Tromey  <tom@tromey.com>
2611
2612         * source-cache.h (class source_cache) <get_source_lines,
2613         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2614
2615 2019-01-22  Tom Tromey  <tom@tromey.com>
2616
2617         * remote-fileio.h (struct remote_target): Declare.
2618
2619 2019-01-22  Tom Tromey  <tom@tromey.com>
2620
2621         * python/py-arch.c: Do not include py-ref.h.
2622         * python/py-bpevent.c: Do not include py-ref.h.
2623         * python/py-cmd.c: Do not include py-ref.h.
2624         * python/py-continueevent.c: Do not include py-ref.h.
2625         * python/py-event.h: Do not include py-ref.h.
2626         * python/py-evtregistry.c: Do not include py-ref.h.
2627         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2628         * python/py-frame.c: Do not include py-ref.h.
2629         * python/py-framefilter.c: Do not include py-ref.h.
2630         * python/py-function.c: Do not include py-ref.h.
2631         * python/py-infevents.c: Do not include py-ref.h.
2632         * python/py-linetable.c: Do not include py-ref.h.
2633         * python/py-objfile.c: Do not include py-ref.h.
2634         * python/py-param.c: Do not include py-ref.h.
2635         * python/py-prettyprint.c: Do not include py-ref.h.
2636         * python/py-progspace.c: Do not include py-ref.h.
2637         * python/py-symbol.c: Do not include py-ref.h.
2638         * python/py-symtab.c: Do not include py-ref.h.
2639         * python/py-type.c: Do not include py-ref.h.
2640         * python/py-unwind.c: Do not include py-ref.h.
2641         * python/py-utils.c: Do not include py-ref.h.
2642         * python/py-value.c: Do not include py-ref.h.
2643         * python/py-varobj.c: Do not include py-ref.h.
2644         * python/py-xmethods.c: Do not include py-ref.h.
2645         * python/python.c: Do not include py-ref.h.
2646         * varobj.c: Do not include py-ref.h.
2647
2648 2019-01-22  Tom Tromey  <tom@tromey.com>
2649
2650         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2651         keyword for bcache.
2652
2653 2019-01-22  Tom Tromey  <tom@tromey.com>
2654
2655         * compile/compile-cplus-types.c: Remove a comment by #include.
2656
2657 2019-01-22  Tom Tromey  <tom@tromey.com>
2658
2659         * compile/gcc-c-plugin.h: Include compile-internal.h.
2660
2661 2019-01-22  Tom Tromey  <tom@tromey.com>
2662
2663         * stabsread.c (EXTERN): Do not define.
2664         (symnum, next_symbol_text_func, processing_gcc_compilation)
2665         (within_function, global_sym_chain, global_stabs)
2666         (previous_stab_code, this_object_header_files)
2667         (n_this_object_header_files)
2668         (n_allocated_this_object_header_files): Define.
2669         * stabsread.h (EXTERN): Never define.  Use "extern".
2670
2671 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2672
2673         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2674         history_value.
2675
2676 2019-01-21  Tom Tromey  <tom@tromey.com>
2677
2678         * ui-out.c: Fix includes.
2679         * tui/tui-source.c: Fix includes.
2680         * target.c: Fix includes.
2681         * remote.c: Fix includes.
2682         * regcache.c: Fix includes.
2683         * python/py-block.c: Fix includes.
2684         * printcmd.c: Fix includes.
2685         * or1k-tdep.c: Fix includes.
2686         * mi/mi-main.c: Fix includes.
2687         * m32r-tdep.c: Fix includes.
2688         * csky-tdep.c: Fix includes.
2689         * compile/compile-cplus-types.c: Fix includes.
2690         * cli/cli-interp.c: Fix includes.
2691
2692 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2693
2694         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2695         for padding.
2696
2697 2019-01-16  Tom Tromey  <tom@tromey.com>
2698
2699         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2700         earlier.
2701         (struct objfile) <msymbols_range>: Move from top level.
2702         <msymbols>: New method.
2703         (class objfile_msymbols): Remove.
2704         * symtab.c (default_collect_symbol_completion_matches_break_on):
2705         Update.
2706         * symmisc.c (dump_msymbols): Update.
2707         * stabsread.c (scan_file_globals): Update.
2708         * objc-lang.c (info_selectors_command, info_classes_command)
2709         (find_methods): Update.
2710         * minsyms.c (find_solib_trampoline_target): Update.
2711         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2712         * coffread.c (coff_symfile_read): Update.
2713         * ada-lang.c (ada_lookup_simple_minsym)
2714         (ada_collect_symbol_completion_matches): Update.
2715
2716 2019-01-16  Tom Tromey  <tom@tromey.com>
2717
2718         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2719         type.  Remove no-argument constructor.
2720         <iterator::operator++>: Simplify.
2721         <begin>: Update.
2722         <end>: Use minimal_symbol_count.
2723
2724 2019-01-16  Tom Tromey  <tom@tromey.com>
2725
2726         * objfiles.h (struct objfile) <psymtabs>: New method.
2727         (class objfile_psymtabs): Remove.
2728         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2729         typedef.
2730         <range>: New method.
2731         (require_partial_symbols): Change return type.
2732         * psymtab.c (require_partial_symbols)
2733         (psym_expand_symtabs_matching): Update.
2734         * mdebugread.c (parse_partial_symbols): Update.
2735         * dbxread.c (dbx_end_psymtab): Update.
2736
2737 2019-01-15  Tom Tromey  <tom@tromey.com>
2738
2739         * symtab.c (lookup_objfile_from_block)
2740         (lookup_symbol_in_objfile_symtabs)
2741         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2742         (find_line_symtab, info_sources_command)
2743         (default_collect_symbol_completion_matches_break_on)
2744         (make_source_files_completion_list): Update.
2745         * symmisc.c (print_objfile_statistics, dump_objfile)
2746         (maintenance_print_symbols, maintenance_info_symtabs)
2747         (maintenance_check_symtabs, maintenance_info_line_tables):
2748         Update.
2749         * source.c (select_source_symtab)
2750         (forget_cached_source_info_for_objfile): Update.
2751         * objfiles.h (class objfile_compunits): Remove.
2752         (struct objfile) <compunits_range>: New typedef.
2753         (compunits): New method.
2754         * objfiles.c (objfile_relocate1): Update.
2755         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2756         * maint.c (count_symtabs_and_blocks): Update.
2757         * linespec.c (iterate_over_all_matching_symtabs): Update.
2758         * cp-support.c (add_symbol_overload_list_qualified): Update.
2759         * coffread.c (coff_symtab_read): Update.
2760         * ada-lang.c (add_nonlocal_symbols)
2761         (ada_collect_symbol_completion_matches)
2762         (ada_add_global_exceptions): Update.
2763
2764 2019-01-15  Tom Tromey  <tom@tromey.com>
2765
2766         * progspace.h (program_space) <objfiles_safe_range>: New
2767         typedef.
2768         <objfiles_safe>: New method.
2769         * objfiles.h (class all_objfiles_safe): Remove.
2770         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2771         * jit.c (jit_inferior_exit_hook): Update.
2772
2773 2019-01-17  Tom Tromey  <tom@tromey.com>
2774
2775         * progspace.h (program_space) <objfiles_range>: New typedef.
2776         <objfiles>: New method.
2777         <objfiles_head>: Rename from objfiles.
2778         (object_files): Update.
2779         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2780         * guile/scm-pretty-print.c
2781         (ppscm_find_pretty_printer_from_objfiles): Update.
2782         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2783         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2784         Update.
2785         * python/py-progspace.c (pspy_get_objfiles): Update.
2786         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2787         Update.
2788         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2789         (objfpy_lookup_objfile_by_build_id): Update.
2790         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2791         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2792         Update.
2793         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2794         (expand_symtab_containing_pc, lookup_objfile_from_block)
2795         (lookup_static_symbol, basic_lookup_transparent_type)
2796         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2797         (find_line_symtab, info_sources_command)
2798         (default_collect_symbol_completion_matches_break_on)
2799         (make_source_files_completion_list, find_main_name): Update.
2800         * symmisc.c (print_symbol_bcache_statistics)
2801         (print_objfile_statistics, maintenance_print_symbols)
2802         (maintenance_print_msymbols, maintenance_print_objfiles)
2803         (maintenance_info_symtabs, maintenance_check_symtabs)
2804         (maintenance_expand_symtabs, maintenance_info_line_tables):
2805         Update.
2806         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2807         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2808         (map_overlay_command, unmap_overlay_command)
2809         (simple_overlay_update, expand_symtabs_matching)
2810         (map_symbol_filenames): Update.
2811         * symfile-debug.c (set_debug_symfile): Update.
2812         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2813         Update.
2814         * source.c (select_source_symtab, forget_cached_source_info):
2815         Update.
2816         * solib.c (solib_read_symbols): Update.
2817         * solib-spu.c (append_ocl_sos): Update.
2818         * psymtab.c (maintenance_print_psymbols)
2819         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2820         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2821         * printcmd.c (info_symbol_command): Update.
2822         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2823         Update.
2824         * objfiles.h (class all_objfiles): Remove.
2825         * objfiles.c (have_partial_symbols, have_full_symbols)
2826         (have_minimal_symbols, qsort_cmp, update_section_map)
2827         (shared_objfile_contains_address_p)
2828         (default_iterate_over_objfiles_in_search_order): Update.
2829         * objc-lang.c (info_selectors_command, info_classes_command)
2830         (find_methods): Update.
2831         * minsyms.c (find_solib_trampoline_target): Update.
2832         * maint.c (maintenance_info_sections)
2833         (maintenance_translate_address, count_symtabs_and_blocks):
2834         Update.
2835         * main.c (captured_main_1): Update.
2836         * linux-thread-db.c (try_thread_db_load_from_pdir)
2837         (has_libpthread): Update.
2838         * linespec.c (iterate_over_all_matching_symtabs)
2839         (search_minsyms_for_name): Update.
2840         * jit.c (jit_find_objf_with_entry_addr): Update.
2841         * hppa-tdep.c (find_unwind_entry)
2842         (hppa_lookup_stub_minimal_symbol): Update.
2843         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2844         Update.
2845         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2846         (elf_gnu_ifunc_resolve_by_got): Update.
2847         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2848         * dwarf-index-write.c (save_gdb_index_command): Update.
2849         * cp-support.c (add_symbol_overload_list_qualified): Update.
2850         * breakpoint.c (create_overlay_event_breakpoint)
2851         (create_longjmp_master_breakpoint)
2852         (create_std_terminate_master_breakpoint)
2853         (create_exception_master_breakpoint): Update.
2854         * blockframe.c (find_pc_partial_function): Update.
2855         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2856         (ada_collect_symbol_completion_matches)
2857         (ada_add_global_exceptions): Update.
2858
2859 2019-01-17  Tom Tromey  <tom@tromey.com>
2860
2861         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2862         declare VEC.
2863         (solib_target_parse_libraries): Change return type.
2864         (library_list_start_segment, library_list_start_section)
2865         (library_list_end_library, library_list_start_library); Update.
2866         (solib_target_free_library_list): Remove.
2867         (solib_target_parse_libraries): Remove cleanup.  Change return
2868         type.
2869         (solib_target_current_sos): Update.
2870
2871 2019-01-17  Tom Tromey  <tromey@bapiya>
2872
2873         * valprint.c: Replace "the the" with "the".
2874         * symtab.c: Replace "the the" with "the".
2875         * solib.c: Replace "the the" with "the".
2876         * solib-dsbt.c: Replace "the the" with "the".
2877         * linespec.c: Replace "the the" with "the".
2878         * dwarf2loc.h: Replace "the the" with "the".
2879         * amd64-windows-tdep.c: Replace "the the" with "the".
2880         * aarch64-tdep.c: Replace "the the" with "the".
2881
2882 2019-01-16  Keith Seitz  <keiths@redhat.com>
2883
2884         PR gdb/23773
2885         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2886         <builder>: Rename to ..
2887         <m_builder>: ... this and make private.
2888         (dwarf2_cu::get_builder): New method.  Change all users of
2889         `builder' to use this method.
2890         (dwarf2_start_symtab): Move to ...
2891         (dwarf2_cu::start_symtab): ... here.  Update all callers
2892         (setup_type_unit_groups): Move to ...
2893         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2894         callers.
2895         (dwarf2_cu::reset_builder): New method.
2896         (process_full_compunit, process_full_type_unit): Use
2897         dwarf2_cu::reset_builder.
2898         (follow_die_offset): Record the ancestor CU if it is different
2899         from the followed DIE's CU.
2900         (follow_die_sig_1): Likewise.
2901
2902 2019-01-15  Tom Tromey  <tom@tromey.com>
2903
2904         * remote.c (class remote_state) <buf>: Now a char_vector.
2905         <buf_size>: Remove.
2906         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2907         parameter.
2908         (remote_target::getpkt_or_notif_sane_1)
2909         (remote_target::getpkt_sane)
2910         (remote_target::getpkt_or_notif_sane): Likewise.
2911         (class remote_target) <putpkt>: New overload.
2912         (remote_target::read_frame): Change type of "buf_p".  Remove
2913         sizeof_p parameter.
2914         (packet_ok): New overload.
2915         (packet_check_result): New overload.
2916         Update all uses.
2917
2918 2019-01-14  Tom Tromey  <tom@tromey.com>
2919
2920         * remote-notif.c (handle_notification, remote_notif_ack)
2921         (remote_notif_parse): Make "buf" const.
2922         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2923         const.
2924         (remote_notif_parse, remote_notif_ack, handle_notification):
2925         Likewise.
2926         * remote.c (remote_notif_stop_parse): Make "buf" const.
2927         (remote_target::remote_parse_stop_reply): Make "buf" const.
2928         (remote_notif_stop_ack): Make "buf" const.
2929
2930 2019-01-14  Tom Tromey  <tom@tromey.com>
2931
2932         * remote.c (remote_console_output): Make parameter const.
2933
2934 2019-01-14  Tom Tromey  <tom@tromey.com>
2935
2936         * target-debug.h (target_debug_print_signals): Constify.
2937         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2938         * procfs.c (procfs_target::pass_signals): Update.
2939         * linux-nat.c (linux_nat_target::pass_signals): Update.
2940         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2941         * target-delegates.c: Rebuild.
2942         * remote.c (remote_target::program_signals): Update.
2943         (remote_target::pass_signals): Update.
2944         * target.c (target_pass_signals): Constify argument.
2945         (target_program_signals): Likewise.
2946         * target.h (struct target_ops) <pass_signals, program_signals>:
2947         Constify argument.
2948         (target_pass_signals, target_program_signals): Constify argument.
2949
2950 2019-01-14  Tom Tromey  <tom@tromey.com>
2951
2952         PR tui/28819:
2953         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2954
2955 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2956
2957         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2958         field.
2959         * rs6000-tdep.c: Include reggroups.h.
2960         (IS_V_ALIAS_PSEUDOREG): Define.
2961         (rs6000_register_name): Return names for the "vX" aliases.
2962         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2963         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2964         aliases.  Call default_register_reggroup_p for all other
2965         pseudo-registers.
2966         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2967         New functions.
2968         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2969         Handle "vX" aliases.
2970         (v_alias_pseudo_register_collect): New function.
2971         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2972         (rs6000_gdbarch_init): Initialize "vX" aliases as
2973         pseudo-registers.  Restore registration of
2974         rs6000_pseudo_register_reggroup_p with
2975         set_tdesc_pseudo_register_reggroup_p.
2976
2977 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2978
2979         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2980         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2981         set_gdbarch_num_pseudo_regs.
2982
2983 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2984
2985         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2986         Remove arg prefixname, add do_set and do_show.
2987         Add member functions set_list and show_list.
2988         * cli/cli-style.c (class cli_style_option): Update accordingly.
2989         (style_set_list): Move to file scope.
2990         (style_show_list): Likewise.
2991         (set_style): Call help_list.
2992         (show_style): Call cmd_show_list.
2993         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2994         Update to use the new macro.
2995
2996 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2997
2998         * ada-lang.c (_initialize_ada_language): Expand the help text
2999         for the "catch exception" command.
3000
3001 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3002
3003         * symtab.c (matching_obj_sections): Initialize obj,
3004         declare it closer to its usage.
3005
3006 2019-01-10  Tom Tromey  <tom@tromey.com>
3007
3008         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3009         (basic_inf_threads_range): Remove.
3010         (inf_threads_range, inf_non_exited_threads_range)
3011         (safe_inf_threads_range): Use next_adapter.
3012
3013 2019-01-10  Keith Seitz  <keiths@redhat.com>
3014
3015         PR gdb/23712
3016         PR symtab/23010
3017         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3018         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3019
3020 2019-01-10  Keith Seitz  <keiths@redhat.com>
3021
3022         PR gdb/23712
3023         PR symtab/23010
3024         * dictionary.c (pending_to_vector): Remove.
3025         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3026         Remove _1 suffix, replacing functions of the same name.  Update
3027         all callers.
3028         (dict_create_hashed, dict_create_hashed_expandable)
3029         (dict_create_linear, dict_create_linear_expandable, dict_free)
3030         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3031         Make functions static.
3032
3033 2019-01-10  Keith Seitz  <keiths@redhat.com>
3034
3035         PR gdb/23712
3036         PR symtab/23010
3037         * dictionary.h (struct dictionary): Replace declaration with
3038         multidictionary.
3039         (dict_create_hashed, dict_create_hashed_expandable)
3040         (dict_create_linear, dict_create_linear_expandable)
3041         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3042         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3043         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3044         taking multidictionary argument.
3045         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3046         * block.h (struct block) <dict>: Change to multidictionary
3047         and rename `multidict'.
3048         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3049         symmisc.c: Update all dictionary references to multidictionary.
3050
3051 2019-01-10  Keith Seitz  <keiths@redhat.com>
3052
3053         PR gdb/23712
3054         PR symtab/23010
3055         * dictionary.c: Include unordered_map.
3056         (pending_to_vector): New function.
3057         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3058         Rewrite the non-"_1" functions to take vector instead
3059         of linked list.
3060         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3061         "new" _1 versions of the same name.
3062         (multidictionary): Define.
3063         (std::hash<enum language): New definition.
3064         (collate_pending_symbols_by_language, mdict_create_hashed)
3065         (mdict_create_hashed_expandable, mdict_create_linear)
3066         (mdict_create_linear_expandable, mdict_free)
3067         (find_language_dictionary, create_new_language_dictionary)
3068         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3069         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3070         (mdict_size, mdict_empty): New functions.
3071         * dictionary.h (mdict_iterator): Define.
3072
3073 2019-01-10  Pedro Alves  <palves@redhat.com>
3074
3075         * breakpoint.c (read_uploaded_action)
3076         (create_tracepoint_from_upload): Adjust to use
3077         gdb::unique_xmalloc_ptr.
3078         * ctf.c (ctf_write_uploaded_tp):
3079         (SET_ARRAY_FIELD): Use emplace_back.
3080         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3081         * tracefile-tfile.c (tfile_write_uploaded_tp):
3082         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3083         gdb::unique_xmalloc_ptr.
3084         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3085         at_string, cond_string, cmd_strings>: Replace char pointers
3086         with gdb::unique_xmalloc_ptr.
3087
3088 2019-01-10  Pedro Alves  <palves@redhat.com>
3089
3090         * solib-target.c (library_list_start_library): Don't xstrdup name.
3091
3092 2019-01-10  Pedro Alves  <palves@redhat.com>
3093
3094         * mdebugread.c (parse_partial_symbols): Use
3095         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3096
3097 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3098
3099         * linux-fork.c (scoped_switch_fork_info)
3100         <~scoped_switch_fork_info>: Fix incorrect variable name.
3101
3102 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3103
3104         * linux-fork.c (scoped_switch_fork_info)
3105         <scoped_switch_fork_info>: Make explicit.
3106         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3107
3108 2019-01-10  Tom Tromey  <tom@tromey.com>
3109
3110         * objfiles.h (objfile::reset_psymtabs): Update.
3111         * objfiles.c (objfile::objfile): Update.
3112         * psymtab.h (psymtab_storage::obstack): Update.
3113         (psymtab_storage::m_obstack): Use gdb::optional.
3114         (class psymtab_storage): Update comment.  Remove objfile
3115         parameter.
3116         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3117
3118 2019-01-10  Tom Tromey  <tom@tromey.com>
3119
3120         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3121         <free_psymtabs>: Now private.
3122         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3123         (allocate_psymtab): Use new method.
3124
3125 2019-01-10  Tom Tromey  <tom@tromey.com>
3126
3127         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3128         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3129         * mdebugread.c (parse_partial_symbols): Use
3130         allocate_dependencies.
3131         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3132         allocate_dependencies.
3133         (process_psymtab_comp_unit_reader)
3134         (build_type_psymtab_dependencies): Likewise.
3135         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3136
3137 2019-01-10  Tom Tromey  <tom@tromey.com>
3138
3139         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3140         PSYMBOL_SET_LANGUAGE.
3141         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3142
3143 2019-01-10  Tom Tromey  <tom@tromey.com>
3144
3145         * psymtab.h (psymtab_storage::obstack): New method.
3146         <m_obstack>: Rename from obstack; now private.
3147         * psymtab.c (psymtab_storage): Update.
3148         * dwarf2read.c (create_addrmap_from_index)
3149         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3150         Update.
3151
3152 2019-01-10  Tom Tromey  <tom@tromey.com>
3153
3154         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3155         * objfiles.h (objfile::reset_psymtabs): New method.
3156
3157 2019-01-10  Tom Tromey  <tom@tromey.com>
3158
3159         * symmisc.c (print_symbol_bcache_statistics): Update.
3160         (print_objfile_statistics): Update.
3161         * symfile.c (reread_symbols): Update.
3162         * psymtab.h (class psymtab_storage): New.
3163         * psymtab.c (psymtab_storage): New constructor.
3164         (~psymtab_storage): New destructor.
3165         (require_partial_symbols): Update.
3166         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3167         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3168         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3169         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3170         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3171         (start_psymtab_common, end_psymtab_common)
3172         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3173         (allocate_psymtab): Update.
3174         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3175         Update.
3176         (dump_psymtab_addrmap, maintenance_print_psymbols)
3177         (maintenance_check_psymtabs): Update.
3178         (class objfile_psymtabs): Move to objfiles.h.
3179         * psympriv.h (discard_psymtab): Now inline.
3180         (psymtab_discarder::psymtab_discarder): Update.
3181         (psymtab_discarder::~psymtab_discarder): Update.
3182         (ALL_OBJFILE_PSYMTABS): Rewrite.
3183         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3184         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3185         Remove fields.
3186         <partial_symtabs>: New field.
3187         (class objfile_psymtabs): Move from psymtab.h.  Update.
3188         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3189         psymbol_cache.
3190         (objfile::~objfile): Don't destroy psymbol_cache.
3191         * mdebugread.c (parse_partial_symbols): Update.
3192         * dwarf2read.c (create_addrmap_from_index)
3193         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3194         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3195         (add_partial_subprogram, dwarf2_ranges_read): Update.
3196         * dwarf-index-write.c (write_address_map)
3197         (write_one_signatured_type, recursively_write_psymbols)
3198         (class debug_names, class debug_names, write_psymtabs_to_index):
3199         Update.
3200
3201 2019-01-10  Tom Tromey  <tom@tromey.com>
3202
3203         * symtab.h (SYMBOL_SET_NAMES): Update.
3204         (symbol_set_names): Update.
3205         (MSYMBOL_SET_NAMES): Update.
3206         * symtab.c (symbol_set_names): Change argument to be an
3207         objfile_per_bfd_storage.
3208         * psymtab.c (add_psymbol_to_bcache): Update.
3209         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3210
3211 2019-01-10  Tom Tromey  <tom@tromey.com>
3212
3213         * symtab.c (create_demangled_names_hash): Change argument to be an
3214         objfile_per_bfd_storage.
3215         (symbol_set_names): Update.
3216
3217 2019-01-10  Tom Tromey  <tom@tromey.com>
3218
3219         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3220         init_psymbol_list.
3221         * psymtab.c (init_psymbol_list): Do nothing if already called.
3222         * psympriv.h (init_psymbol_list): Add comment.
3223         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3224         init_psymbol_list.
3225         * dbxread.c (dbx_symfile_read): Unconditionally call
3226         init_psymbol_list.
3227
3228 2019-01-10  Tom Tromey  <tom@tromey.com>
3229
3230         * xcoffread.c (scan_xcoff_symtab): Update.
3231         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3232         "where".
3233         * mdebugread.c (parse_partial_symbols)
3234         (handle_psymbol_enumerators): Update.
3235         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3236         * dbxread.c (read_dbx_symtab): Update.
3237         * psympriv.h (psymbol_placement): New enum.
3238         (add_psymbol_to_list): Update.
3239
3240 2019-01-10  Tom Tromey  <tom@tromey.com>
3241
3242         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3243         static_psymbols parameters.
3244         (scan_xcoff_symtab): Update.
3245         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3246         static_psymbols parameters.
3247         * psympriv.h (start_psymtab_common): Update.
3248         * mdebugread.c (parse_partial_symbols): Update.
3249         * dwarf2read.c (create_partial_symtab): Update.
3250         * dbxread.c (read_dbx_symtab): Update.
3251         (start_psymtab): Remove global_psymbols and static_psymbols
3252         parameters.
3253
3254 2019-01-10  Tom Tromey  <tom@tromey.com>
3255
3256         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3257         * psymtab.c (allocate_psymtab): Add comment.
3258         * psympriv.h (allocate_psymtab): Add comment.
3259         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3260         initializations.
3261         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3262
3263 2019-01-10  Tom Tromey  <tom@tromey.com>
3264
3265         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3266         Don't declare.
3267         * mipsread.c: Include mdebugread.h.
3268         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3269         Declare.
3270         * elfread.c: Include mdebugread.h.
3271
3272 2019-01-09  Tom Tromey  <tom@tromey.com>
3273
3274         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3275         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3276         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3277         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3278         (psym_lookup_symbol, psym_find_last_source_symtab)
3279         (psym_forget_cached_source_info, psym_print_stats)
3280         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3281         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3282         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3283         (psym_find_compunit_symtab_by_address)
3284         (maintenance_print_psymbols, maintenance_info_psymtabs)
3285         (maintenance_check_psymtabs): Use ranged for.
3286         * psymtab.h (class objfile_psymtabs): New.
3287         (require_partial_symbols): Return objfile_psymtabs.
3288         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3289
3290 2019-01-09  Tom Tromey  <tom@tromey.com>
3291
3292         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3293         (find_pc_mapped_section, list_overlays_command)
3294         (map_overlay_command, unmap_overlay_command)
3295         (simple_overlay_update): Use all_objfiles.
3296         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3297         * printcmd.c (info_symbol_command): Use all_objfiles.
3298         * objfiles.h (ALL_OBJSECTIONS): Remove.
3299         * maint.c (maintenance_translate_address): Use all_objfiles.
3300         * gcore.c (gcore_create_callback): Use all_objfiles.
3301         (objfile_find_memory_regions): Likewise.
3302
3303 2019-01-09  Tom Tromey  <tom@tromey.com>
3304
3305         * symtab.c (find_line_symtab, info_sources_command)
3306         (make_source_files_completion_list): Use objfile_compunits.
3307         * source.c (select_source_symtab): Use objfile_compunits.
3308         * objfiles.h (struct objfile): Update comment.
3309         (ALL_OBJFILES): Remove.
3310         (ALL_FILETABS): Remove.
3311         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3312         objfile_compunits.
3313
3314 2019-01-09  Tom Tromey  <tom@tromey.com>
3315
3316         * symmisc.c (print_objfile_statistics, dump_objfile)
3317         (maintenance_print_symbols): Use compunit_filetabs.
3318         * source.c (forget_cached_source_info_for_objfile): Use
3319         compunit_filetabs.
3320         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3321         (ALL_FILETABS): Use compunit_filetabs.
3322         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3323         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3324
3325 2019-01-09  Tom Tromey  <tom@tromey.com>
3326
3327         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3328         (compunit_filetabs): New.
3329         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3330         compunit_filetabs.
3331         (info_sources_command, make_source_files_completion_list): Remove
3332         declaration.
3333         * symmisc.c (print_objfile_statistics, dump_objfile)
3334         (maintenance_print_symbols): Remove declaration.
3335         (maintenance_info_symtabs): Use compunit_filetabs.
3336         (maintenance_info_line_tables): Likewise.
3337         * source.c (select_source_symtab): Change local variable name.
3338         (forget_cached_source_info_for_objfile): Remove declaration.
3339         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3340         * objfiles.c (objfile_relocate1): Remove declaration.
3341         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3342         declaration.
3343         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3344         * coffread.c (coff_symtab_read): Remove declaration.
3345         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3346         compunit_filetabs.
3347
3348 2019-01-09  Tom Tromey  <tom@tromey.com>
3349
3350         * symtab.c (lookup_objfile_from_block)
3351         (find_pc_sect_compunit_symtab, search_symbols)
3352         (default_collect_symbol_completion_matches_break_on): Use
3353         objfile_compunits.
3354         * objfiles.h (ALL_COMPUNITS): Remove.
3355         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3356         * cp-support.c (add_symbol_overload_list_qualified): Use
3357         objfile_compunits.
3358         * ada-lang.c (ada_collect_symbol_completion_matches)
3359         (ada_add_global_exceptions): Use objfile_compunits.
3360
3361 2019-01-09  Tom Tromey  <tom@tromey.com>
3362
3363         * source.c (select_source_symtab)
3364         (forget_cached_source_info_for_objfile): Remove declaration.
3365         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3366         declaration.
3367         * maint.c (count_symtabs_and_blocks): Remove declaration.
3368         * cp-support.c (add_symbol_overload_list_qualified): Remove
3369         declaration.
3370         * coffread.c (coff_symtab_read): Remove declaration.
3371         * symtab.c (lookup_symbol_in_objfile_symtabs)
3372         (basic_lookup_transparent_type_1): Use objfile_compunits.
3373         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3374         (info_sources_command, search_symbols)
3375         (default_collect_symbol_completion_matches_break_on)
3376         (make_source_files_completion_list): Remove declaration.
3377         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3378         (ada_collect_symbol_completion_matches)
3379         (ada_add_global_exceptions): Remove declaration.
3380         * linespec.c (iterate_over_all_matching_symtabs): Use
3381         objfile_compunits.
3382         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3383         (class objfile_compunits): New.
3384         (ALL_COMPUNITS): Use objfile_compunits.
3385         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3386         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3387         objfile_compunits.
3388         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3389
3390 2019-01-09  Tom Tromey  <tom@tromey.com>
3391
3392         * symtab.c (search_symbols)
3393         (default_collect_symbol_completion_matches_break_on): Use
3394         objfile_msymbols.
3395         * ada-lang.c (ada_lookup_simple_minsym)
3396         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3397         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3398         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3399         objfile_msymbols.
3400         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3401         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3402         * objc-lang.c (find_methods): Use objfile_msymbols.
3403         (info_selectors_command, info_classes_command): Likewise.
3404         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3405         * objfiles.h (class objfile_msymbols): New.
3406         (ALL_OBJFILE_MSYMBOLS): Remove.
3407         (ALL_MSYMBOLS): Remove.
3408
3409 2019-01-09  Tom Tromey  <tom@tromey.com>
3410
3411         * common/next-iterator.h (next_adapter): Add Iterator template
3412         parameter.
3413         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3414         (class all_objfiles_safe): New.
3415         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3416         * objfiles.c (put_objfile_before): Update comment.
3417         (add_separate_debug_objfile): Likewise.
3418         (free_all_objfiles): Use all_objfiles_safe.
3419         (objfile_purge_solibs): Likewise.
3420
3421 2019-01-09  Tom Tromey  <tom@tromey.com>
3422
3423         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3424         (expand_symtab_containing_pc, lookup_static_symbol)
3425         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3426         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3427         all_objfiles.
3428         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3429         * breakpoint.c (create_overlay_event_breakpoint)
3430         (create_longjmp_master_breakpoint)
3431         (create_std_terminate_master_breakpoint)
3432         (create_exception_master_breakpoint): Use all_objfiles.
3433         * linux-thread-db.c (try_thread_db_load_from_pdir)
3434         (has_libpthread): Use all_objfiles.
3435         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3436         * linespec.c (iterate_over_all_matching_symtabs)
3437         (search_minsyms_for_name): Use all_objfiles.
3438         * maint.c (maintenance_info_sections): Use all_objfiles.
3439         * main.c (captured_main_1): Use all_objfiles.
3440         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3441         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3442         * guile/scm-pretty-print.c
3443         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3444         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3445         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3446         (maintenance_print_msymbols): Use all_objfiles.
3447         * source.c (select_source_symtab): Use all_objfiles.
3448         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3449         * symfile.c (remove_symbol_file_command)
3450         (expand_symtabs_matching, map_symbol_filenames): Use
3451         all_objfiles.
3452         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3453         all_objfiles.
3454         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3455         * objc-lang.c (find_methods): Use all_objfiles.
3456         * objfiles.c (have_partial_symbols, have_full_symbols)
3457         (have_minimal_symbols, qsort_cmp)
3458         (default_iterate_over_objfiles_in_search_order): Use
3459         all_objfiles.
3460         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3461         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3462         (maintenance_check_psymtabs): Use all_objfiles.
3463         (ALL_PSYMTABS): Remove.
3464         * compile/compile-object-run.c (do_module_cleanup): Use
3465         all_objfiles.
3466         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3467         * cp-support.c (add_symbol_overload_list_qualified): Use
3468         all_objfiles.
3469         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3470         Use all_objfiles.
3471         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3472         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3473         all_objfiles.
3474         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3475         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3476         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3477         Uses all_objfiles.
3478         * solib.c (solib_read_symbols): Use all_objfiles
3479
3480 2019-01-09  Tom Tromey  <tom@tromey.com>
3481
3482         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3483         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3484         all_objfiles.
3485         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3486         * symmisc.c (print_symbol_bcache_statistics)
3487         (print_objfile_statistics, maintenance_print_objfiles)
3488         (maintenance_info_symtabs, maintenance_check_symtabs)
3489         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3490         all_objfiles.
3491         * source.c (forget_cached_source_info): Use all_objfiles.
3492         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3493         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3494         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3495         * objfiles.c (update_section_map): Use all_objfiles.
3496         (shared_objfile_contains_address_p): Likewise.
3497         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3498         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3499
3500 2019-01-09  Tom Tromey  <tom@tromey.com>
3501
3502         * common/next-iterator.h: New file.
3503         * objfiles.h (class all_objfiles): New.
3504         (struct objfile_iterator): New.
3505
3506 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3507
3508         * NEWS: Move the description of the changed "frame", "select-frame",
3509          and "info frame" commands to the Changed commands section.
3510
3511 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3512
3513         * gdbtypes.c (check_stub_method_group): Remove handling of old
3514         mangling schemes.
3515         * linespec.c (find_methods): Likewise.
3516         * stabsread.c (read_member_functions): Likewise.
3517         * valops.c (search_struct_method): Likewise.
3518         (value_struct_elt_for_reference): Likewise.
3519         * NEWS: Mention this change.
3520
3521 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3522
3523         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3524         print_source_lines.
3525         * source.c (print_source_lines_base): Update line number check.
3526         (print_source_lines): New function.
3527         (source_lines_range::source_lines_range): New function.
3528         * source.h (class source_lines_range): New class.
3529         (print_source_lines): New declaration.
3530
3531 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3532
3533         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3534
3535 2019-01-08  Tom Tromey  <tom@tromey.com>
3536             Simon Marchi  <simon.marchi@ericsson.com>
3537
3538         PR gdb/24060
3539         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3540         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3541         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3542         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3543         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3544         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3545
3546 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3547
3548         * source.c (select_source_symtab): Move header comment to
3549         declaration in source.h.
3550         (forget_cached_source_info_for_objfile): Likewise.
3551         (forget_cached_source_info): Likewise.
3552         (identify_source_line): Likewise.
3553         * source.h (identify_source_line): Move declaration from symtab.h
3554         and add comment from source.c
3555         (print_source_lines): Likewise.
3556         (forget_cached_source_info_for_objfile): Likewise.
3557         (forget_cached_source_info): Likewise.
3558         (select_source_symtab): Likewise.
3559         (enum print_source_lines_flag): Move definition from symtab.h.
3560         * symtab.h (identify_source_line): Move declaration to source.h.
3561         (print_source_lines): Likewise.
3562         (forget_cached_source_info_for_objfile): Likewise.
3563         (forget_cached_source_info): Likewise.
3564         (select_source_symtab): Likewise.
3565         (enum print_source_lines_flag): Move definition to source.h.
3566         * tui/tui-hooks.c: Add 'source.h' include.
3567
3568 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3569
3570         * source.c (print_source_lines_base): Handle requests to print
3571         reverse line number sequences, and guard against empty lines
3572         string.
3573
3574 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3575
3576         * source.c (print_source_lines_base): Fix skip of '\r' if next
3577         character is '\n'.
3578
3579 2019-01-06  Tom Tromey  <tom@tromey.com>
3580
3581         * c-exp.y (struct c_parse_state) <macro_original_text,
3582         expansion_obstack>: New member.
3583         (macro_original_text, expansion_obstack): Remove globals.
3584         (scan_macro_expansion, scanning_macro_expansion)
3585         (finished_macro_expansion): Update.
3586         (scan_macro_cleanup): Remove.
3587         (yylex, c_parse): Update.
3588
3589 2019-01-06  Tom Tromey  <tom@tromey.com>
3590
3591         * c-exp.y (struct c_parse_state) <strings>: New member.
3592         (operator_stoken): Update.
3593
3594 2019-01-06  Tom Tromey  <tom@tromey.com>
3595
3596         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3597         (union type_stack_elt) <typelist_val>: Now a pointer to
3598         std::vector.
3599         (type_stack_cleanup): Don't declare.
3600         (push_typelist): Update.
3601         * parse.c (pop_typelist): Return a std::vector.
3602         (push_typelist): Take a std::vector.
3603         (follow_types): Update.  Do not free args.
3604         (type_stack_cleanup): Remove.
3605         * c-exp.y (struct c_parse_state): New.
3606         (cpstate): New global.
3607         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3608         (nonempty_typelist): Update.
3609         (func_mod): Create a new vector.
3610         (c_parse): Create a c_parse_state.
3611         (check_parameter_typelist): Do not delete params.
3612         (function_method): Update.  Do not delete type_list.
3613
3614 2019-01-06  Tom Tromey  <tom@tromey.com>
3615
3616         PR gdb/28155:
3617         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3618         check_typedef.
3619         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3620         (print_return_value): Likewise.
3621
3622 2019-01-05  Tom Tromey  <tom@tromey.com>
3623
3624         * contrib/cleanup_check.py: Remove.
3625         * contrib/gcc-with-excheck: Remove.
3626         * contrib/exsummary.py: Remove.
3627         * contrib/excheck.py: Remove.
3628
3629 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3630
3631         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3632         NULL. Initialize tpprev to NULL instead of assigning it
3633         to NULL on the next statement.
3634         * windows-nat.c (windows_delete_thread): Remove check for
3635         main_thread_id before printing thread exit notifications.
3636         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3637         Remove thread ID check against main_thread_id.
3638         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3639         windows_delete_thread.
3640         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3641
3642 2019-01-04  Tom Tromey  <tom@tromey.com>
3643
3644         * compile/compile.c (_initialize_compile): Use upper case for
3645         metasyntactic variables.
3646         * symmisc.c (_initialize_symmisc): Use upper case for
3647         metasyntactic variables.
3648         * psymtab.c (_initialize_psymtab): Use upper case for
3649         metasyntactic variables.
3650         * demangle.c (demangle_command): Use upper case for metasyntactic
3651         variables.
3652         (_initialize_demangler): Likewise.
3653         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3654         variables.
3655
3656 2019-01-03  Tom Tromey  <tom@tromey.com>
3657
3658         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3659
3660 2019-01-03  Tom Tromey  <tom@tromey.com>
3661
3662         * python/py-symtab.c (salpy_str): Update.
3663         (struct salpy_sal_object) <symtab>: Now a PyObject.
3664         (salpy_dealloc): Update.
3665         (del_objfile_sal): Use gdbpy_ref.
3666
3667 2019-01-03  Tom Tromey  <tom@tromey.com>
3668
3669         * python/py-type.c (convert_field): Use new_reference.  Return
3670         gdbpy_ref.
3671         (make_fielditem): Return gdbpy_ref.
3672         (typy_fields): Update.
3673         (typy_getitem): Update.
3674         (field_name): Return gdbpy_ref.  Use new_reference.
3675         (typy_iterator_iternext): Update.
3676
3677 2019-01-03  Tom Tromey  <tom@tromey.com>
3678
3679         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3680
3681 2019-01-03  Tom Tromey  <tom@tromey.com>
3682
3683         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3684         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3685         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3686         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3687         (pspy_set_type_printers): Likewise.
3688         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3689         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3690         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3691         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3692         (objfpy_set_type_printers): Likewise.
3693
3694 2019-01-03  Tom Tromey  <tom@tromey.com>
3695
3696         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3697         (gdbpy_print_stack): Use gdbpy_err_fetch.
3698         * python/python-internal.h (class gdbpy_err_fetch): New class.
3699         (class gdbpy_enter) <m_error_type, m_error_value,
3700         m_error_traceback>: Remove.
3701         <m_error>: New member.
3702         (gdbpy_exception_to_string): Don't declare.
3703         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3704         * python/py-value.c (convert_value_from_python): Use
3705         gdbpy_err_fetch.
3706         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3707         gdbpy_exception_to_string.
3708         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3709         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3710         gdbpy_err_fetch.
3711
3712 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3713
3714         * linux-nat.c (delete_lwp_cleanup): Delete.
3715         (struct lwp_deleter): New struct.
3716         (lwp_info_up): New typedef.
3717         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3718         lwp_info_up.
3719
3720 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3721
3722         * linux-fork.c (class scoped_switch_fork_info): New class.
3723         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3724
3725 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3726
3727         * valops.c (find_overload_match): Remove use of null_cleanup, and
3728         calls to do_cleanups.
3729
3730 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3731
3732         * compile/compile-cplus-types.c
3733         (compile_cplus_instance::decl_name): Handle changes to
3734         cp_func_name.
3735         * cp-support.c (cp_func_name): Update header comment, update
3736         return type.
3737         * cp-support.h (cp_func_name): Update return type in declaration.
3738         * valops.c (find_overload_match): Move temp_func local to top
3739         level of function and change its type.  Use temp_func to hold and
3740         delete temporary string obtained from cp_func_name.
3741
3742 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3743
3744         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3745         gdb::char_vector, remove cleanup, and update uses of `msg`.
3746
3747 2019-01-03  Jim Wilson  <jimw@sifive.com>
3748
3749         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3750
3751 2019-01-02  Tom Tromey  <tom@tromey.com>
3752
3753         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3754         (tdesc_parse_xml): Remove cleanups.
3755         * target-descriptions.h (make_cleanup_free_target_description):
3756         Don't declare.
3757         (target_desc_deleter): New struct.
3758         (target_desc_up): New typedef.
3759         * target-descriptions.c (target_desc_deleter::operator()): Rename
3760         from free_target_description.
3761         (make_cleanup_free_target_description): Remove.
3762
3763 2019-01-02  Tom Tromey  <tom@tromey.com>
3764
3765         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3766         constructor, destructor.
3767         (linespec_parser): Remove typedef.
3768         (~linespec_parser): Rename from linespec_parser_delete.
3769         (linespec_lex_to_end, linespec_complete_label)
3770         (linespec_complete): Update.
3771         (decode_line_full): Remove cleanups.
3772         (decode_line_1): Update.
3773
3774 2019-01-02  Tom Tromey  <tom@tromey.com>
3775
3776         * python/python-internal.h (inferior_to_inferior_object): Change
3777         return type.
3778         * python/py-exitedevent.c (create_exited_event_object): Update.
3779         * python/py-inferior.c (inferior_to_inferior_object): Return
3780         gdbpy_ref.
3781         (python_new_inferior, python_inferior_deleted)
3782         (thread_to_thread_object, delete_thread_object)
3783         (build_inferior_list, gdbpy_selected_inferior): Update.
3784         * python/py-infthread.c (create_thread_object): Update.  Also fail
3785         if inferior_to_inferior_object fails.
3786
3787 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3788
3789         * inferior.h (class inferior) <displaced_step_state>: New field.
3790         * infrun.h (struct displaced_step_state): Move here from
3791         infrun.c.  Initialize fields, add constructor.
3792         <inf>: Remove field.
3793         <reset>: New method.
3794         * infrun.c (struct displaced_step_inferior_state): Move to
3795         infrun.h.
3796         (displaced_step_inferior_states): Remove.
3797         (get_displaced_stepping_state): Adust.
3798         (displaced_step_in_progress_any_inferior): Adjust.
3799         (displaced_step_in_progress_thread): Adjust.
3800         (displaced_step_in_progress): Adjust.
3801         (add_displaced_stepping_state): Remove.
3802         (get_displaced_step_closure_by_addr): Adjust.
3803         (remove_displaced_stepping_state): Remove.
3804         (infrun_inferior_exit): Call displaced_step_state.reset.
3805         (use_displaced_stepping): Don't check for NULL.
3806         (displaced_step_prepare_throw): Call
3807         get_displaced_stepping_state.
3808         (displaced_step_fixup): Don't check for NULL.
3809         (prepare_for_detach): Don't check for NULL.
3810
3811 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3812
3813         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3814          in case of call that did not complete.
3815
3816 2019-01-02  Andrey Utkin  <autkin@undo.io>
3817
3818         * symfile.c (find_separate_debug_file): Fix search of debug files for
3819         remote debuggee.
3820
3821 2019-01-02  Tom Tromey  <tom@tromey.com>
3822
3823         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3824         indentation.
3825         * python/py-frame.c (frapy_older): Remove cast.
3826         (frapy_newer): Likewise.
3827         * python/py-breakpoint.c (local_setattro): Remove cast.
3828         * python/py-arch.c (archpy_name): Remove local variable.
3829         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3830
3831 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3832
3833         * unittests/basic_string_view/element_access/char/empty.cc:
3834         Fix year range in copyright header.
3835
3836 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3837
3838         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3839         Delete.
3840         <operator==>: Update with for removed field.
3841         <hash>: Likewise.
3842         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3843         <isa_features>: ...this.
3844         <abi_features>: New field.
3845         (riscv_isa_flen): Update comment.
3846         (riscv_abi_xlen): New declaration.
3847         (riscv_abi_flen): New declaration.
3848         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3849         isa_features.
3850         (riscv_abi_xlen): New function.
3851         (riscv_isa_flen): Update to get answer from isa_features.
3852         (riscv_abi_flen): New function.
3853         (riscv_has_fp_abi): Update to get answer from abi_features.
3854         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3855         xlen and flen.
3856         (riscv_call_info) <xlen, flen>: Update comment.
3857         (riscv_call_arg_struct): Remove invalid assertions
3858         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3859         is removed.
3860         (riscv_gdbarch_init): Gather isa features and abi features
3861         separately, ensure both match on the gdbarch when reusing an old
3862         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3863         a target with 64-bit float hardware.
3864
3865 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3866
3867         * source.c (search_command_helper): Stop reverse search
3868         when line 1 has been searched.
3869
3870 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3871
3872         * record-full.c (record_full_base_target::close): Rewrite
3873         record_full_core_buf_list free logic.
3874
3875 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3876
3877         * break-catch-syscall.c (print_one_catch_syscall): xfree
3878         the last text.
3879
3880 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3881
3882         * top.c (print_gdb_version): Update Copyright year in version
3883         message.
3884
3885 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3886
3887         Update copyright year range in all GDB files.
3888
3889 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3890
3891         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3892
3893 For older changes see ChangeLog-2018.
3894 \f
3895 Local Variables:
3896 mode: change-log
3897 left-margin: 8
3898 fill-column: 74
3899 version-control: never
3900 coding: utf-8
3901 End:
3902